1 2012-05-12 Glenn Morris <rgm@gnu.org>
3 * Makefile.in (MKDIR_P): New, set by configure.
4 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
6 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
8 Remove unused function hourglass_started.
9 * dispextern.h (hourglass_started):
10 * w32fns.c (hourglass_started):
11 * xdisp.c (hourglass_started): Remove.
13 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
15 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
18 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
20 * xgselect.c (xg_select): Put maxfds+1 into a var.
21 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
23 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
25 2012-05-10 Dave Abrahams <dave@boostpro.com>
27 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
28 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
30 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
32 * dbusbind.c (xd_registered_buses): New internal Lisp object.
33 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
34 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
35 Initialize xd_registered_buses.
37 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
39 Untag more efficiently if USE_LSB_TAG.
40 This is based on a proposal by YAMAMOTO Mitsuharu in
41 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
42 For an admittedly artificial (nth 8000 longlist) benchmark on
43 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
44 Emacs's overall text size by 1%.
45 * lisp.h (XUNTAG): New macro.
46 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
47 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
48 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
50 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
51 * frame.h (XFRAME): Use XUNTAG.
53 Port recent dbusbind.c changes to 32-bit --with-wide-int.
54 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
55 Remove unportable assumptions about print widths of types like
57 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
58 intptr_t when converting between pointer and integer, to avoid GCC
59 warnings about wrong width.
61 2012-05-09 Eli Zaretskii <eliz@gnu.org>
63 * w32proc.c (new_child): Force Windows to reserve only 64KB of
64 stack for each reader_thread, instead of defaulting to 8MB
65 determined by the linker. This avoids failures in creating
66 subprocesses on Windows 7, see the discussion in this thread:
67 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
69 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
71 Fix up display of the *Minibuf-0* buffer in the mini window.
72 * keyboard.c (read_char): Don't clear the echo area if there's no
74 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
75 contents of *Minibuf-0*) if there's no message displayed in its stead.
77 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
79 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
82 2012-05-06 Chong Yidong <cyd@gnu.org>
84 * lisp.mk (lisp): Update.
86 2012-05-05 Jim Meyering <meyering@redhat.com>
88 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
90 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
92 * data.c (PUT_ERROR): New macro.
93 (syms_of_data): Use it. Add new error type `user-error'.
94 * undo.c (user_error): New function.
95 (Fprimitive_undo): Use it.
96 * print.c (print_error_message): Adjust print style for `user-error'.
97 * keyboard.c (user_error): New function.
98 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
100 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
102 Do not limit current-time-string to years 1000..9999.
103 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
104 (Fcurrent_time_string): Support any year that is supported by the
105 underlying localtime representation. Don't use asctime, as it
106 has undefined behavior for years outside the range -999..9999.
108 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
110 Fix race conditions involving setenv, gmtime, localtime, asctime.
111 Without this fix, interrupts could mess up code that uses these
112 nonreentrant functions, since setting TZ invalidates existing
113 tm_zone or tzname values, and since most of these functions return
114 pointers to static storage.
115 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
116 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
117 Grow the critical sections to include not just invoking
118 localtime/gmtime, but also accessing these functions' results
119 including their tm_zone values if any, and any related TZ setting.
120 (format_time_string): Last arg is now struct tm *, not struct tm **,
121 so that the struct tm is saved in the critical section.
122 All callers changed. Simplify allocation of initial buffer, partly
123 motivated by the fact that memory allocation needs to be outside
124 the critical section.
126 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
128 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
131 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
132 Remove duplicated buffer name initialization.
134 2012-05-02 Jim Meyering <jim@meyering.net>
136 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
138 * xfns.c (x_window): Use xstrdup (Bug#11375).
140 2012-05-02 Eli Zaretskii <eliz@gnu.org>
142 * xdisp.c (pos_visible_p): If already at a newline from the
143 display string before the 'while' loop, don't walk back the glyphs
144 from it3.glyph_row. Solves assertion violation when the display
145 string begins with a newline (egg.el). (Bug#11367)
147 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
149 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
152 2012-05-01 Glenn Morris <rgm@gnu.org>
154 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
155 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
156 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
157 All were removed before 23.1.
159 * dispnew.c: Remove HAVE_LIBNCURSES test;
160 it is always true on relevant platforms.
162 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
163 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
165 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
167 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
169 * .gdbinit (xpr): Remove checks for no longer existing misc types.
170 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
173 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
175 Do not avoid creating empty evaporating overlays (Bug#9642).
176 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
177 That is, do not delete an evaporating overlay if it becomes
178 empty after its bounds are adjusted to fit within its buffer.
179 This fix caused other problems, and I'm reverting it until we get
180 to the bottom of them.
182 2012-04-27 Chong Yidong <cyd@gnu.org>
184 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
186 2012-04-27 Eli Zaretskii <eliz@gnu.org>
188 * xdisp.c (pos_visible_p): If the window start position is beyond
189 ZV, start the display from buffer beginning. Prevents assertion
190 violation in init_iterator when the minibuffer window is scrolled
193 * window.c (window_scroll_pixel_based): Likewise.
195 2012-04-27 Chong Yidong <cyd@gnu.org>
197 * keymap.c (where_is_internal): Doc fix (Bug#10872).
199 2012-04-27 Glenn Morris <rgm@gnu.org>
201 * fileio.c (Fcopy_file, Fset_file_selinux_context):
202 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
204 2012-04-27 Eli Zaretskii <eliz@gnu.org>
206 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
207 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
209 2012-04-26 Eli Zaretskii <eliz@gnu.org>
211 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
212 display element, check also the underlying string or buffer
213 character. (Bug#11341)
215 * w32menu.c: Include w32heap.h.
216 (add_menu_item): If the call to AppendMenuW (via
217 unicode_append_menu) fails, disable Unicode menus only if we are
218 running on Windows 9X/Me.
220 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
222 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
223 (xgetint): Add missing shift for LSB tags.
225 2012-04-24 Martin Rudalics <rudalics@gmx.at>
227 * keyboard.c (read_char): Don't wipe echo area for select window
228 events: These might get delayed via `mouse-autoselect-window'
231 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
233 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
234 manipulation of :loaded-from data.
236 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
238 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
239 now a cons (bug#11311).
241 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
243 Do not create empty overlays with the evaporate property (Bug#9642).
244 * buffer.c (Fmove_overlay): Delete an evaporating overlay
245 if it becomes empty after its bounds are adjusted to fit within
246 its buffer. Without this fix, in a nonempty buffer (let ((o
247 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
248 yields an empty overlay that has the evaporate property, which is
249 not supposed to happen.
251 Fix minor GTK3 problems found by static checking.
252 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
253 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
254 (struct _EmacsFixedClass, emacs_fixed_get_type):
255 Move decls here from emacsgtkfixed.h, since they needn't be public.
256 (emacs_fixed_get_type): Now static.
257 (emacs_fixed_class_init): Omit unused local.
258 (emacs_fixed_child_type): Remove; unused.
259 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
260 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
261 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
262 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
263 (EMACS_FIXED_GET_CLASS): Remove; unused.
264 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
266 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
267 Problem reported by Juanma Barranquero for Windows -Wunused-function.
269 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
271 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
272 * gmalloc.c: (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
273 (__malloc_size_t, __malloc_ptrdiff_t):
274 Remove. All uses removed, replaced by the definiens if needed,
275 since we can assume C89 or better now.
276 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
277 (protect_malloc_state, align, get_contiguous_space)
278 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
279 (malloc_atfork_handler_child, malloc_enable_thread)
280 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
281 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
282 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
283 (special_realloc, _realloc_internal_nolock, _realloc_internal)
284 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
285 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
286 Define using prototypes, not old style.
287 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
288 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
289 (align): Don't assume that signed integer overflow wraps around.
290 Omit unused local var.
291 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
292 (_free_internal_nolock, memalign, mallochook, reallochook):
293 Omit no-longer-needed casts.
294 (valloc): Use getpagesize, not __getpagesize.
295 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
296 (struct hdr): The 'magic' member is now size_t, not unsigned long.
298 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
300 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
302 Move functions from C to Lisp. Make non-blocking method calls
303 the default. Implement further D-Bus standard interfaces.
305 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
306 (QCdbus_request_name_allow_replacement)
307 (QCdbus_request_name_replace_existing)
308 (QCdbus_request_name_do_not_queue)
309 (QCdbus_request_name_reply_primary_owner)
310 (QCdbus_request_name_reply_in_queue)
311 (QCdbus_request_name_reply_exists)
312 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
313 (QCdbus_registered_serial, QCdbus_registered_method)
314 (QCdbus_registered_signal): New Lisp objects.
315 (XD_DEBUG_MESSAGE): Use sizeof.
316 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
317 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
318 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
319 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
320 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
321 (xd_signature, xd_append_arg): Allow float for integer types.
322 (xd_get_connection_references): New function.
323 (xd_get_connection_address): Rename from xd_initialize.
324 Return cached address.
325 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
326 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
328 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
329 Return number of refcounts.
330 (Fdbus_get_unique_name): Make stronger parameter check.
331 (Fdbus_message_internal): New defun.
332 (Fdbus_call_method, Fdbus_call_method_asynchronously)
333 (Fdbus_method_return_internal, Fdbus_method_error_internal)
334 (Fdbus_send_signal, Fdbus_register_service)
335 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
336 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
337 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
338 (Vdbus_compiled_version, Vdbus_runtime_version)
339 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
340 (Vdbus_message_type_method_return, Vdbus_message_type_error)
341 (Vdbus_message_type_signal): New defvars.
342 (Vdbus_registered_buses, Vdbus_registered_objects_table):
345 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
347 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
348 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
349 Do not assume ptrdiff_t is the same width as 'int'.
351 * alloc.c: Handle unusual debugging option combinations.
352 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
353 since the two debugging options are incompatible.
354 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
356 (mem_init, mem_insert, mem_insert_fixup):
357 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
358 (NEED_MEM_INSERT): Remove; no longer needed.
360 2012-04-22 Leo Liu <sdl.web@gmail.com>
362 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
364 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
366 * sysdep.c [__FreeBSD__]: Minor cleanups.
367 (list_system_processes, system_process_attributes) [__FreeBSD__]:
368 Use Emacs indenting style more consistently. Avoid some casts.
369 Use 'double' consistently rather than mixing 'float' and 'double'.
371 2012-04-21 Eduard Wiebe <usenet@pusto.de>
373 * sysdep.c (list_system_processes, system_process_attributes):
374 Add implementation for FreeBSD (Bug#5243).
376 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
378 * lisp.mk (lisp): Update.
380 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
382 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
383 It is never used otherwise.
385 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
387 * print.c (print_preprocess): Only check print_depth if print-circle
389 (print_object): Check for cycles even when print-circle is nil and
390 print-gensym is t, but only check print_depth if print-circle is nil.
392 2012-04-20 Chong Yidong <cyd@gnu.org>
394 * process.c (wait_reading_process_output): If EIO occurs on a pty,
395 set the status to "failed" and ensure that sentinel is run.
397 2012-04-20 Glenn Morris <rgm@gnu.org>
399 * process.c (Fset_process_inherit_coding_system_flag)
400 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
401 (Fmake_network_process, Fmake_serial_process): Doc fix.
403 2012-04-20 Eli Zaretskii <eliz@gnu.org>
405 * xdisp.c (string_buffer_position_lim): Limit starting position to
407 (set_cursor_from_row): If called for a mode-line or header-line
408 row, return zero immediately.
409 (try_cursor_movement): If inside continuation line, don't back up
410 farther than the first row after the header line, if any.
411 Don't consider the header-line row as "partially visible", even if
412 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
414 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
416 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
419 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
420 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
422 configure: new option --enable-gcc-warnings (Bug#11207)
423 * Makefile.in (C_WARNINGS_SWITCH): Remove.
424 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
425 (ALL_CFLAGS): Use new macros rather than old.
426 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
427 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
428 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
429 -Wunused-result, -Wunused-variable. This should go away once
430 the Emacs and Gnulib regex code is merged.
431 (xmalloc, xrealloc): Now static.
433 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
435 * dired.c (Fsystem_groups): Remove unused local.
437 2012-04-17 Glenn Morris <rgm@gnu.org>
439 * dired.c (Fsystem_users): Doc fix.
441 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
443 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
444 (syms_of_dired): Add them.
446 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
448 Fix minor alloc.c problems found by static checking.
449 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
450 New extern decls, to avoid calling undeclared functions.
451 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
452 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
453 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
454 (NEED_MEM_INSERT): New macro.
455 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
456 Remove one incorrect comment and fix another.
458 Fix minor ralloc.c problems found by static checking.
459 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
460 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
461 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
462 (r_alloc_sbrk): Now static.
464 Improve ralloc.c interface checking.
465 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
466 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
467 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
468 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
469 [REL_ALLOC]: ... to here, to check interface.
470 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
471 Remove decls. This fixes an "It stinks!".
473 * alloc.c (which_symbols): Fix alignment issue / type clash.
475 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
477 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
478 (struct Lisp_Misc_Any): Likewise.
479 (struct Lisp_Free): Likewise.
480 * alloc.c (union aligned_Lisp_Symbol): Define.
481 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
482 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
483 (union aligned_Lisp_Misc): Define.
484 (MARKER_BLOCK_SIZE, struct marker_block): Use union
485 aligned_Lisp_Misc instead of union Lisp_Misc.
486 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
488 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
490 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
491 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
492 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
493 * s/netbsd.h, s/sol2-6.h:
494 Remove definition of GC_MARK_STACK, since the default now works.
495 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
496 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
497 no longer the default.
498 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
500 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
502 * lread.c (lisp_file_lexically_bound_p):
503 Fix hang at ";-*-\n" (bug#11238).
505 2012-04-14 Eli Zaretskii <eliz@gnu.org>
507 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
508 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
510 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
512 * nsterm.m (constrainFrameRect): Always constrain when there is only
513 one screen (Bug#10962).
515 2012-04-13 Ken Brown <kbrown@cornell.edu>
517 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
519 2012-04-13 Reuben Thomas <rrt@sc3d.org>
521 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
523 2012-04-11 Daniel Colascione <dancol@dancol.org>
525 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
526 against is gone. It's better to use vfork now so that when Cygwin
527 gains a new, working vfork, we use it automatically (bug#10398).
529 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
531 * window.c (save_window_save): Obey window-point-insertion-type.
533 2012-04-11 Glenn Morris <rgm@gnu.org>
535 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
537 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
539 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
541 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
543 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
544 (force_quit_count): New var.
545 (handle_interrupt): Use it.
547 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
549 * w32.c (w32_delayed_load): Record the full path of the library
550 being loaded (bug#10424).
552 2012-04-09 Glenn Morris <rgm@gnu.org>
554 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
555 not just in the obarray, before snarfing them. (Bug#11036)
557 * Makefile.in ($(leimdir)/leim-list.el):
558 Pass EMACS rather than BUILT_EMACS.
560 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
562 * process.c (make_process):
563 * process.h: Add integer `gnutls_handshakes_tried' member to
566 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
567 Add convenience `GNUTLS_LOG2i' macro.
569 * gnutls.c (gnutls_log_function2i): Convenience log function.
570 (emacs_gnutls_read): Use new log functions,
571 `gnutls_handshakes_tried' process member, and
572 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
573 attempts per process (connection).
575 2012-04-09 Chong Yidong <cyd@gnu.org>
577 * eval.c (Fuser_variable_p, user_variable_p_eh)
578 (lisp_indirect_variable): Functions deleted.
579 (Fdefvar): Caller changed.
581 * callint.c (Finteractive, Fcall_interactively):
582 * minibuf.c (Fread_variable): Callers changed.
584 2012-04-09 Eli Zaretskii <eliz@gnu.org>
586 * xdisp.c (set_cursor_from_row): If the display string appears in
587 the buffer at position that is closer to point than the position
588 after the display string, display the cursor on the first glyph of
589 the display string. Fixes cursor display when a 'display' text
590 property immediately follows invisible text. (Bug#11094)
592 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
594 composite.c: use 'double' consistently
595 * composite.c (get_composition_id): Use 'double' consistently
596 instead of converting 'float' to 'double' and vice versa; this is
597 easier to understand and avoids a GCC warning.
599 2012-04-09 Glenn Morris <rgm@gnu.org>
601 * Makefile.in: Generate leim-list with bootstrap-emacs, in
602 preparation for dumping it with emacs. (Bug#4789)
603 (leimdir): New variable.
604 ($(leimdir)/leim-list.el): New rule.
605 (emacs$(EXEEXT)): Depend on leim-list.el.
607 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
608 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
609 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
611 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
613 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
616 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
618 * xml.c (init_libxml2_functions) [WINDOWSNT]:
619 Remove unused local variable.
621 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
623 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
624 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
625 (mark_memory): Mark Lisp_Objects only if pointers might hide in
626 objects, as mark_maybe_pointer will catch them otherwise.
627 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
628 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
630 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
632 Fix typo that broke non-Windows builds.
633 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
635 2012-04-07 Eli Zaretskii <eliz@gnu.org>
637 Support building on MS-Windows with libxml2.
639 * makefile.w32-in (OBJ2): Add xml.$(O).
640 (GLOBAL_SOURCES): Add xml.c.
641 ($(BLD)/xml.$(O)): New dependency list.
643 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
644 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
645 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
646 [!WINDOWSNT]: New macros.
647 (init_libxml2_functions, libxml2_loaded_p): New functions.
648 (parse_region): Call fn_xmlCheckVersion instead of using the macro
649 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
650 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
651 Calls xmlCleanupParser only if libxml2 was loaded (or statically
653 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
654 Call init_libxml2_functions before calling libxml2 functions.
655 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
657 * emacs.c: Don't include libxml/parser.h.
658 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
659 xmlCleanupParser directly.
661 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
663 2012-04-07 Eli Zaretskii <eliz@gnu.org>
665 * indent.c (Fvertical_motion): If there is a display string at
666 point, use it.vpos to compute how many lines to backtrack after
667 move_it_to point. (Bug#11133)
669 2012-04-06 Eli Zaretskii <eliz@gnu.org>
671 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
672 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
673 about subtle differences between FETCH_CHAR* and STRING_CHAR*
674 macros related to unification of CJK characters. For the details,
675 see the discussion following the message here:
676 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
678 2012-04-04 Chong Yidong <cyd@gnu.org>
680 * keyboard.c (Vdelayed_warnings_list): Doc fix.
682 2012-04-01 Eli Zaretskii <eliz@gnu.org>
684 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
685 instead of alloca. (Bug#11138)
687 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
689 * w32menu.c (is_simple_dialog): Properly check lisp types.
692 2012-03-31 Eli Zaretskii <eliz@gnu.org>
694 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
695 position we get to after a call to move_it_to fails the
696 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
697 only if we wind up in a string from display property. (Bug#11063)
699 * window.c (Fdelete_other_windows_internal): Invalidate the row
700 and column information about mouse highlight, so that redisplay
701 restores it after reallocating the glyph matrices. (Bug#7464)
703 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
704 string comes from a `display' text property, use the buffer
705 position of that property as if we actually saw that position in
707 (move_it_by_lines): Remove the assertion that
708 "it->current_x == 0 && it->hpos == 0" which can be legitimately
709 violated when there's a before-string at the beginning of a line.
712 2012-03-30 Eli Zaretskii <eliz@gnu.org>
714 * xdisp.c (append_space_for_newline): If the default face was
715 remapped, use the remapped face for the appended newline.
716 (extend_face_to_end_of_line): Use the remapped default face for
717 extending the face to the end of the line.
718 (display_line): Call extend_face_to_end_of_line when the default
719 face was remapped. (Bug#11068)
721 2012-03-29 Eli Zaretskii <eliz@gnu.org>
723 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
725 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
727 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
729 2012-03-27 Glenn Morris <rgm@gnu.org>
731 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
734 2012-03-26 Kenichi Handa <handa@m17n.org>
736 * dispextern.h (struct glyph): Fix previous change. Change the
737 bit length of glyphless.ch to 25 (Bug#11082).
739 2012-03-26 Chong Yidong <cyd@gnu.org>
741 * keyboard.c (Vselection_inhibit_update_commands): New variable.
742 (command_loop_1): Use it; inhibit selection update for
743 handle-select-window too (Bug#8996).
745 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
747 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
749 2012-03-25 Kenichi Handa <handa@m17n.org>
751 * dispextern.h (struct glyph): Change the bit length of
752 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
754 2012-03-24 Eli Zaretskii <eliz@gnu.org>
756 * s/ms-w32.h (tzname): Include time.h before redirecting to
757 _tzname. Fixes the MSVC build. (Bug#9960)
759 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
761 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
764 * xterm.c (XTread_socket): Only modify handling_signal if
765 !SYNC_INPUT. (Bug#11080)
767 2012-03-23 Eli Zaretskii <eliz@gnu.org>
769 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
770 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
771 when fetching a multibyte character consumes more bytes than
772 CHAR_BYTES returns, due to unification of CJK characters in
773 string_char. (Bug#11073)
775 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
777 * process.c (wait_reading_process_output): Handle pty disconnect
778 by refraining from sending oneself a SIGCHLD (bug#10933).
780 2012-03-22 Chong Yidong <cyd@gnu.org>
782 * dispextern.h (struct it): New member string_from_prefix_prop_p.
784 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
785 Mark string as coming from a prefix property.
786 (handle_face_prop): Use default face for prefix strings (Bug#4281).
787 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
789 2012-03-21 Chong Yidong <cyd@gnu.org>
791 * xfaces.c (Vface_remapping_alist): Doc fix.
793 2012-03-20 Eli Zaretskii <eliz@gnu.org>
795 * w32proc.c (Fw32_set_console_codepage)
796 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
799 2012-03-20 Chong Yidong <cyd@gnu.org>
801 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
802 to reflect default non-nil value of redisplay-dont-pause.
804 2012-03-19 Kenichi Handa <handa@m17n.org>
806 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
807 it fit in a valid range (Bug#11003).
809 2012-03-18 Eli Zaretskii <eliz@gnu.org>
811 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
812 that is not from display property, accept the row as a "cursor
813 row" if one of the string's character has a non-nil `cursor'
814 property. Fixes cursor positioning when there are newlines in
815 overlay strings, e.g. in icomplete.el. (Bug#11035)
817 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
819 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
821 2012-03-12 Chong Yidong <cyd@gnu.org>
823 * eval.c (inhibit_lisp_code): Rename from
824 inhibit_window_configuration_change_hook; move from window.c.
826 * xfns.c (unwind_create_frame_1, Fx_create_frame):
827 * window.c (run_window_configuration_change_hook)
828 (syms_of_window): Callers changed.
830 2012-03-11 Chong Yidong <cyd@gnu.org>
832 * keymap.c (Fkey_description): Doc fix (Bug#9700).
834 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
836 2012-03-10 Chong Yidong <cyd@gnu.org>
838 * frame.c (other_visible_frames): Don't assume the selected frame
839 is visible (Bug#10955).
841 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
843 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
845 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
847 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
848 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
851 2012-03-03 Glenn Morris <rgm@gnu.org>
853 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
855 2012-03-02 Eli Zaretskii <eliz@gnu.org>
857 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
858 position past the first glyph_row that ends at ZV. (Bug#10902)
859 (redisplay_window, next_element_from_string): Fix typos in
861 (redisplay_window): Pass to move_it_vertically the margin in
862 pixels, not in screen lines.
864 2012-03-02 Glenn Morris <rgm@gnu.org>
866 * buffer.c (buffer-list-update-hook): Doc fix.
868 2012-02-29 Eli Zaretskii <eliz@gnu.org>
870 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
871 push_it before setting up the iterator for the first overlay
872 string, even if we have an empty string loaded.
873 (next_overlay_string): If there's an empty string on the iterator
874 stack, pop the stack. (Bug#10903)
876 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
878 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
879 Suggested by Stefan Monnier in
880 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
881 * alloc.c (widen_to_Lisp_Object): New static function.
882 (mark_memory): Also mark Lisp_Objects by fetching pointer words
883 and widening them to Lisp_Objects. This would work even if
884 USE_LSB_TAG is defined and wide integers are used, which might
885 happen in a future version of Emacs.
887 2012-02-25 Chong Yidong <cyd@gnu.org>
889 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
892 * xselect.c (Fx_selection_exists_p): Doc fix.
893 (x_clipboard_manager_save_all): Print an informative message
894 before saving to clipboard manager.
896 2012-02-24 Chong Yidong <cyd@gnu.org>
898 * keyboard.c (process_special_events): Handle all X selection
899 requests in kbd_buffer, not just the next one (Bug#8869).
901 2012-02-23 Chong Yidong <cyd@gnu.org>
903 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
904 call when setting menu-bar-lines and tool-bar-lines parameters.
905 (unwind_create_frame_1): New helper function.
907 * window.c (inhibit_window_configuration_change_hook): New var.
908 (run_window_configuration_change_hook): Obey it.
909 (syms_of_window): Initialize it.
911 2012-02-22 Chong Yidong <cyd@gnu.org>
913 * xterm.c (x_draw_image_relief): Add missing type check for
914 Vtool_bar_button_margin (Bug#10743).
916 2012-02-21 Chong Yidong <cyd@gnu.org>
918 * fileio.c (Vfile_name_handler_alist): Doc fix.
920 * buffer.c (Fget_file_buffer): Protect against invalid file
921 handler return value.
923 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
925 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
926 when computing $valmask.
928 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
929 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
930 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
931 It's useless in that case, and it can cause problems on hosts
932 that allocate halves of EMACS_INT values separately.
933 Reported by Dan Horák. Diagnosed by Andreas Schwab in
934 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
935 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
936 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
937 it avoids undefined behavior on hosts where shifting right by more
938 than the word width has undefined behavior.
940 2012-02-19 Chong Yidong <cyd@gnu.org>
942 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
943 (Funhandled_file_name_directory, Ffile_name_as_directory)
944 (Fdirectory_file_name, Fexpand_file_name)
945 (Fsubstitute_in_file_name): Protect against invalid file handler
946 return values (Bug#10845).
948 2012-02-18 Eli Zaretskii <eliz@gnu.org>
950 * .gdbinit (pitx): Fix incorrect references to fields of the
953 2012-02-17 Chong Yidong <cyd@gnu.org>
955 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
957 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
959 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
960 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
962 2012-02-15 Chong Yidong <cyd@gnu.org>
964 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
965 marked as special. Also, starting docstrings with * is obsolete.
967 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
969 * gnutls.c (emacs_gnutls_write): Fix last change.
971 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
973 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
976 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
978 * keymap.c (Fsingle_key_description): Handle char ranges.
980 2012-02-12 Chong Yidong <cyd@gnu.org>
982 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
983 as that creates a dangerous corner case.
985 * window.c (Fdelete_window_internal): Invalidate the mouse
986 highlight (Bug#9904).
988 2012-02-12 Glenn Morris <rgm@gnu.org>
990 * xselect.c (Fx_own_selection_internal)
991 (Fx_get_selection_internal, Fx_disown_selection_internal)
992 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
993 * nsselect.m (Fx_own_selection_internal)
994 (Fx_disown_selection_internal, Fx_selection_exists_p)
995 (Fx_selection_owner_p, Fx_get_selection_internal):
996 Sync docs and argument specs with the xselect.c versions.
998 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
1000 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
1002 2012-02-11 Eli Zaretskii <eliz@gnu.org>
1004 * w32select.c (Fx_selection_exists_p): Sync doc string and
1005 argument list with xselect.c. (Bug#10783)
1007 * w16select.c (Fx_selection_exists_p): Sync doc string and
1008 argument list with xselect.c. (Bug#10783)
1010 2012-02-10 Glenn Morris <rgm@gnu.org>
1012 * fns.c (Fsecure_hash): Doc fix.
1014 2012-02-09 Kenichi Handa <handa@m17n.org>
1016 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
1018 2012-02-07 Chong Yidong <cyd@gnu.org>
1020 * buffer.c (Fbuffer_local_variables)
1021 (buffer_lisp_local_variables): Handle unbound vars correctly;
1022 don't let Qunbound leak into Lisp.
1024 2012-02-07 Glenn Morris <rgm@gnu.org>
1026 * image.c (Fimagemagick_types): Doc fix.
1028 * image.c (imagemagick-render-type): Change it from a lisp object
1029 to an integer. Move the doc here from the lisp manual.
1030 Treat all values not equal to 0 the same.
1032 2012-02-06 Chong Yidong <cyd@gnu.org>
1034 * doc.c (store_function_docstring): Avoid applying docstring of
1035 alias to base function (Bug#2603).
1037 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
1039 * .gdbinit (pp1, pv1): Remove redundant defines.
1042 2012-02-04 Chong Yidong <cyd@gnu.org>
1044 * nsterm.m: Declare a global (Bug#10694).
1046 2012-02-04 Eli Zaretskii <eliz@gnu.org>
1048 * w32.c (get_emacs_configuration_options):
1049 Include --enable-checking, if specified, in the return value.
1051 2012-02-04 Martin Rudalics <rudalics@gmx.at>
1053 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
1054 after rounding frame sizes. (Bug#9723)
1056 2012-02-04 Eli Zaretskii <eliz@gnu.org>
1058 * keyboard.c (adjust_point_for_property): Don't position point
1059 before BEGV. (Bug#10696)
1061 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
1063 Handle overflow when computing char display width (Bug#9496).
1064 * character.c (char_width): Return EMACS_INT, not int.
1065 (char_width, c_string_width): Check for overflow when
1066 computing the width; this is possible now that individual
1067 characters can have unbounded width. Problem introduced
1068 by merge from Emacs 23 on 2012-01-19.
1070 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
1072 * dbusbind.c (Fdbus_register_method): Mention the return value
1073 :ignore in the docstring.
1075 2012-02-02 Glenn Morris <rgm@gnu.org>
1077 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
1079 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1080 Unconditionally set to t. (Bug#10673)
1081 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1082 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
1083 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
1085 2012-02-02 Kenichi Handa <handa@m17n.org>
1087 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
1088 0, do not call append_composite_glyph.
1090 2012-02-02 Kenichi Handa <handa@m17n.org>
1092 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
1094 (x_produce_glyphs): If the component of a composition is a null
1095 string, set it->pixel_width to 1 to avoid zero-width glyph.
1097 2012-02-01 Eli Zaretskii <eliz@gnu.org>
1099 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
1100 first 2 arguments are identical. This makes inserting large
1101 output from a subprocess an order of magnitude faster on
1102 MS-Windows, where all sbrk'ed memory is always contiguous.
1104 2012-01-31 Glenn Morris <rgm@gnu.org>
1106 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1107 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
1108 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
1110 2012-01-29 Glenn Morris <rgm@gnu.org>
1112 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
1114 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
1116 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
1118 2012-01-28 Chong Yidong <cyd@gnu.org>
1120 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
1122 2012-01-26 Chong Yidong <cyd@gnu.org>
1124 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
1126 * search.c (Fsearch_forward, Fsearch_backward): Document negative
1127 repeat counts (Bug#10507).
1129 2012-01-26 Glenn Morris <rgm@gnu.org>
1131 * lread.c (syms_of_lread): Doc fix.
1133 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
1135 * coding.c (encode_designation_at_bol): Change return value to
1138 2012-01-25 Chong Yidong <cyd@gnu.org>
1140 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
1142 2012-01-21 Chong Yidong <cyd@gnu.org>
1144 * floatfns.c (Fcopysign): Make the second argument non-optional,
1145 since nil is not allowed anyway.
1147 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
1149 * process.c (read_process_output): Use p instead of XPROCESS (proc).
1150 (send_process): Likewise.
1152 2012-01-19 Martin Rudalics <rudalics@gmx.at>
1154 * window.c (save_window_save, Fcurrent_window_configuration)
1155 (Vwindow_persistent_parameters): Do not use Qstate.
1156 Rewrite doc-strings.
1158 2012-01-19 Kenichi Handa <handa@m17n.org>
1160 * character.c (char_width): New function.
1161 (Fchar_width, c_string_width, lisp_string_width):
1162 Use char_width (Bug#9496).
1164 2012-01-16 Martin Rudalics <rudalics@gmx.at>
1166 * window.c (Vwindow_persistent_parameters): New variable.
1167 (Fset_window_configuration, save_window_save): Handle persistent
1170 2012-01-14 Eli Zaretskii <eliz@gnu.org>
1172 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
1173 thrashing the stack of the thread. (Bug#9087)
1175 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
1177 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
1179 2012-01-11 Eli Zaretskii <eliz@gnu.org>
1181 * xdisp.c (rows_from_pos_range): Handle the case where the
1182 highlight ends on a newline. (Bug#10464)
1183 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
1184 he end column for display of highlight that ends on a newline
1187 2012-01-11 Glenn Morris <rgm@gnu.org>
1189 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
1190 from load-path also when installation-directory is nil. (Bug#10208)
1192 2012-01-10 Glenn Morris <rgm@gnu.org>
1194 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
1196 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
1197 Update template values to be closer to their typical values these days.
1199 2012-01-09 Eli Zaretskii <eliz@gnu.org>
1201 * xdisp.c (rows_from_pos_range): Accept additional argument
1202 DISP_STRING, and accept any glyph in a row whose object is that
1203 string as eligible for mouse highlight. Fixes mouse highlight of
1204 display strings from overlays. (Bug#10464)
1206 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
1208 emacs: fix an auto-save permissions race condition (Bug#10400)
1209 * fileio.c (auto_saving_dir_umask): New static var.
1210 (Fmake_directory_internal): Use it.
1211 (do_auto_save_make_dir): Set it, instead of invoking chmod after
1212 creating the directory. The old code temporarily assigns
1213 too-generous permissions to the directory.
1214 (do_auto_save_eh): Clear it.
1215 (Fdo_auto_save): Catch all errors, not just file errors, so
1216 that the var is always cleared.
1218 2012-01-07 Eli Zaretskii <eliz@gnu.org>
1220 * search.c (scan_buffer): Pass character positions to
1221 know_region_cache, not byte positions. (Bug#6540)
1223 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
1225 * w32.c (sys_rename): Report EXDEV when rename of a directory
1226 fails because the target is on another logical disk. (Bug#10284)
1228 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
1230 * xterm.c (x_embed_request_focus): New function.
1232 * xterm.h: Add prototype.
1234 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
1236 2012-01-05 Glenn Morris <rgm@gnu.org>
1238 * emacs.c (emacs_copyright): Update short copyright year to 2012.
1240 2012-01-01 Eli Zaretskii <eliz@gnu.org>
1242 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
1243 Load gnutls_transport_set_lowat only if GnuTLS version is below
1245 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
1246 GnuTLS versions below 2.11.1.
1248 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
1250 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
1251 to the doc string advising against its use for altering the way
1252 windows are scrolled.
1254 2011-12-28 Kenichi Handa <handa@m17n.org>
1256 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
1257 coding-system ASCII compatible only when it does not produce BOM
1258 on encoding (Bug#10383).
1260 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
1262 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
1264 (create_and_show_popup_menu): Always use menu_position_func for
1267 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
1269 * callint.c (Fcall_interactively): Don't truncate prompt string.
1271 2011-12-23 Eli Zaretskii <eliz@gnu.org>
1273 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
1274 property that ends at ZV, so that the bidi iteration could be
1275 resumed from there (after widening). (Bug#10360)
1277 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
1279 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
1281 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
1283 * nsterm.m (x_free_frame_resources):
1284 Release f->output_data.ns->miniimage.
1285 (ns_index_color): Fix indentation. Do not retain
1286 color_table->colors[i].
1288 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
1291 * nsfns.m (x_set_background_color): Assign return value from
1292 ns_index_color to face-background instead of NSColor*.
1293 (ns_implicitly_set_icon_type): Fix indentation.
1294 Change assignment in for loop to comparison.
1296 * emacs.c (ns_pool): New variable.
1297 (main): Assign ns_pool.
1298 (Fkill_emacs): Call ns_release_autorelease_pool.
1300 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1301 autorelease fdesc, release fdAttrs and tdict.
1302 (ns_get_covering_families): Release charset.
1303 (ns_findfonts): Release NSFontDescriptor created with new.
1304 (ns_uni_to_glyphs): Fix indentation.
1305 (setString): Release attrStr before assigning new value.
1307 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1309 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1311 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1312 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1314 2011-12-18 David Reitter <reitter@cmu.edu>
1316 * nsterm.m (ns_term_init): Subscribe for notifications
1317 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1318 to method trackingNotification in EmacsMenu.
1320 * nsmenu.m (trackingMenu): New variable.
1321 (trackingNotification): New method (from Aquamacs).
1322 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
1323 from Aquamacs (Bug#7030).
1325 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1327 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1328 (symbol_to_nsstring): Fix indentation.
1329 (ns_symbol_to_pb): New function.
1330 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1331 (Fns_rotate_cut_buffers_internal): Remove.
1332 (Fns_store_selection_internal): Rename from
1333 Fns_store_cut_buffer_internal.
1334 (ns_get_foreign_selection, Fx_own_selection_internal)
1335 (Fx_disown_selection_internal, Fx_selection_exists_p)
1336 (Fns_get_selection_internal, Fns_store_selection_internal):
1337 Use ns_symbol_to_pb and check if return value is nil.
1338 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1339 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
1340 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1341 renamed to Sns_store_selection_internal.
1342 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1343 and remove this function.
1344 (ns_handle_selection_clear): Remove, never used.
1345 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1348 2011-12-17 Ken Brown <kbrown@cornell.edu>
1350 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1351 GID is unknown (Bug#10257).
1353 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1355 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1356 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1357 which caused a build failure on GNU/Linux IA-64. This problem was
1358 introduced by my 2011-10-07 patch.
1360 2011-12-15 Juri Linkov <juri@jurta.org>
1362 * image.c (imagemagick_error): New function. (Bug#10112)
1363 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1364 Use `imagemagick_error' where ImageMagick functions return
1366 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1369 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1371 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1372 fill background (Bug#8992).
1374 2011-12-13 Martin Rudalics <rudalics@gmx.at>
1376 * window.c (Vwindow_combination_resize)
1377 (Vwindow_combination_limit): Use t instead of non-nil in
1379 (Vrecenter_redisplay): Add first sentence of doc-string on
1381 (Frecenter): Fix doc-string typo.
1383 2011-12-11 Kenichi Handa <handa@m17n.org>
1385 * coding.c (Funencodable_char_position): Pay attention to the
1386 buffer text relocation (Bug#9389).
1388 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1390 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1391 gtk_init (Bug#10100).
1393 2011-12-10 Eli Zaretskii <eliz@gnu.org>
1395 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1396 IT->string is nil. (Bug#10263)
1398 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1400 * nsterm.h (x_free_frame_resources): Declare.
1402 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1403 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1405 * nsterm.h (ns_get_defaults_value): Declare.
1407 * nsterm.m (ns_default): Call ns_get_defaults_value.
1409 2011-12-09 Eli Zaretskii <eliz@gnu.org>
1411 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1414 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1416 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1417 that where the value of an _OBJC_* symbol points to is in the .bss
1418 section (Bug#10240).
1420 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1422 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
1423 after the loop to call ccl_driver at least once (Bug#8619).
1425 2011-12-08 Kenichi Handa <handa@m17n.org>
1427 * ftfont.c (get_adstyle_property): Fix previous change
1430 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
1432 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1433 dirs from the default value of EMACSLOADPATH (bug#10208).
1435 2011-12-07 Glenn Morris <rgm@gnu.org>
1437 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1438 installation and source directories as well. (Bug#10208)
1440 2011-12-06 Chong Yidong <cyd@gnu.org>
1442 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1444 2011-12-06 Glenn Morris <rgm@gnu.org>
1446 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1447 as an error, not just -1. (Bug#10217)
1449 2011-12-05 Chong Yidong <cyd@gnu.org>
1451 * keyboard.c (process_special_events): New function.
1452 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1454 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1456 * coding.c (encode_designation_at_bol): Don't use uninitialized
1457 local variable (Bug#9318).
1459 2011-12-05 Kenichi Handa <handa@m17n.org>
1461 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1462 return Qnil (Bug#8046, Bug#10193).
1464 2011-12-05 Kenichi Handa <handa@m17n.org>
1466 * coding.c (encode_designation_at_bol): New args charbuf_end and
1467 dst. Return the number of produced bytes. Callers changed.
1468 (coding_set_source): Return how many bytes coding->source was
1470 (coding_set_destination): Return how many bytes
1471 coding->destination was relocated.
1472 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1473 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1475 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1477 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1478 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1481 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1483 The following changes are to fix Bug#9318.
1485 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1486 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1487 (encode_coding_iso_2022, encode_coding_sjis)
1488 (encode_coding_big5, encode_coding_charset): Use the above macros.
1490 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1492 * lisp.h (process_quit_flag): Fix external declaration.
1494 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1496 Don't macro-inline non-performance-critical code.
1497 * eval.c (process_quit_flag): New function.
1498 * lisp.h (QUIT): Use it.
1500 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1502 * nsfns.m (get_geometry_from_preferences): New function.
1503 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1505 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1507 * emacs.c (Qkill_emacs): Define.
1508 (syms_of_emacs): Initialize it.
1509 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1510 Qquit_flag to `kill-emacs' instead.
1511 (quit_throw_to_read_char): Add parameter `from_signal'.
1512 All callers changed. Call Fkill_emacs if requested and safe.
1513 * lisp.h (QUIT): Call Fkill_emacs if requested.
1515 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1517 * widget.c (update_wm_hints): Return if wmshell is null.
1518 (widget_update_wm_size_hints): New function.
1520 * widget.h (widget_update_wm_size_hints): Declare.
1522 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1523 widget_update_wm_size_hints (Bug#10104).
1525 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1527 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1528 before a newline, prepare the bidi iterator for consuming the
1529 newline, and keep the current paragraph direction. (Bug#10183)
1530 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1532 2011-12-02 Juri Linkov <juri@jurta.org>
1534 * search.c (Fword_search_regexp): New Lisp function created from
1535 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1536 (Fword_search_backward, Fword_search_forward)
1537 (Fword_search_backward_lax, Fword_search_forward_lax):
1538 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1539 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1541 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1543 * fileio.c (Finsert_file_contents): Move after-change-function call
1544 to before the "handled:" label, since all "goto handled" appear in
1545 cases where the *-change-functions have already been properly called
1548 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1550 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1551 waiting for input. (Bug#10169)
1553 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1555 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1556 verifies glyph row's hash code--we have just reallocated the
1557 glyphs, so their contents can be complete garbage. (Bug#10164)
1559 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1561 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1563 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1565 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1566 attributes are tested _before_ calling verify_row_hash, to protect
1567 against GCC re-ordering of the tests. (Bug#10164)
1569 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1571 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1573 * xterm.c (handle_one_xevent): Only set async_visible and friends
1574 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1575 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1576 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1578 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1580 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1581 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1582 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1583 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1584 All uses changed to use GCPRO1 etc.
1585 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1586 Revert to old implementation (i.e., before 2011-03-11).
1588 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1590 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1591 of scroll runs so as to avoid assigning disabled bogus rows and
1592 unnecessary graphics copy operations.
1594 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1596 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1597 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1598 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1599 (malloc, free, realloc, calloc): Redirect to e_* only when
1602 * lisp.h (GCTYPEBITS): Move before first use.
1603 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1604 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1605 this macro definition.
1607 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1610 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1612 * gtkutil.c (xg_create_frame_widgets):
1613 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1614 present with Gtk+ 2.0.
1616 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1618 * fileio.c (Finsert_file_contents): Undo previous change; see
1619 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1621 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1623 Rename locals to avoid shadowing.
1624 * fileio.c (Finsert_file_contents):
1625 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1626 * process.c (wait_reading_process_output):
1627 Rename inner 'proc' to 'p' to avoid shadowing.
1628 Indent for consistency with usual Emacs style.
1630 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1632 * xdisp.c (redisplay_window): If cursor row is not fully visible
1633 after recentering, and scroll-conservatively is set to a large
1634 number, scroll window by a few more lines to make the cursor fully
1635 visible and out of scroll-margin. (Bug#10105)
1636 (start_display): Don't move to the next line if the display should
1637 start at a newline that is part of a display vector or an overlay
1640 2011-11-24 Juri Linkov <juri@jurta.org>
1642 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1643 after the `MagickPingImage' call. (Bug#10112)
1645 2011-11-23 Chong Yidong <cyd@gnu.org>
1647 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1649 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1651 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1652 making another buffer current. (Bug#10114)
1654 2011-11-23 Glenn Morris <rgm@gnu.org>
1656 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1658 2011-11-23 Chong Yidong <cyd@gnu.org>
1660 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1661 using it (Bug#5984).
1663 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1665 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1666 and header-lines, as they don't have one computed for them.
1669 * .gdbinit (prow): Make displayed values more self-explaining.
1670 Add row's hash code.
1672 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1674 * process.c (wait_reading_process_output): Fix asynchrounous
1675 GnuTLS socket handling on some versions of the GnuTLS library.
1676 (wait_reading_process_output): Add comment and URL.
1678 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1680 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1682 2011-11-21 Chong Yidong <cyd@gnu.org>
1684 * window.c (Fnext_window, Fprevious_window): Doc fix.
1686 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1688 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1690 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1692 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1694 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1696 * window.c (Fset_window_combination_limit): Rename argument
1698 (Vwindow_combination_limit): Remove "status" from doc-string.
1700 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1702 * m/ibms390.h: Remove.
1703 * m/ibms390x.h: Don't include "ibms390.h".
1705 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1707 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1708 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1710 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1712 * casetab.c (Fset_case_table):
1713 * charset.c (Fcharset_after): Fix typos.
1715 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1717 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1718 Otherwise, valgrind does not work on some platforms.
1719 Problem reported by Andreas Schwab in
1720 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1721 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1722 is set, removing the need for VIRT_ADDRESS_VARIES.
1723 (PURE_P): Use a more-efficient implementation that needs just one
1724 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1725 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1726 to 4 (xorl, subq, cmpq, setbe).
1727 * alloc.c (pure): Always extern now, since that's the
1728 VIRT_ADDR_VARIES behavior.
1729 (PURE_POINTER_P): Use a single comparison, not two, for
1730 consistency with the new puresize.h.
1731 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1732 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1733 Remove VIRT_ADDR_VARIES no longer needed.
1735 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1737 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1738 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1739 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1740 behave as if the cursor position were at the window margin.
1742 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1743 and the cursor position is out of bounds, behave as if the cursor
1744 position were at the window margin. (Bug#10075)
1746 2011-11-18 Chong Yidong <cyd@gnu.org>
1748 * window.c (Fwindow_combination_limit): Make first argument
1749 non-optional, since it is meaningless for live windows like the
1752 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1754 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1756 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1758 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1759 (graft_intervals_into_buffer): Simplify.
1761 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1763 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1764 hash values of the two rows.
1765 (copy_row_except_pointers): Preserve the used[] arrays and the
1766 hash values of the two rows. (Bug#10035)
1767 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1769 * xdisp.c (row_hash): New function, body extracted from
1770 compute_line_metrics.
1771 (compute_line_metrics): Call row_hash, instead of computing the
1774 * dispnew.c (verify_row_hash): Call row_hash for computing the
1775 hash code of a row, instead of duplicating code from xdisp.c.
1777 * dispextern.h (row_hash): Add prototype.
1779 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1781 * frame.c (delete_frame): Don't delete the terminal when the last
1782 X frame is closed if emacs is built with GTK toolkit.
1784 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1786 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1788 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1790 * window.c (Vwindow_splits): Rename to
1791 Vwindow_combination_resize. Suggested by Juri Linkov.
1792 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1795 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1797 * nsfns.m (Fns_font_name):
1798 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1800 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1802 * window.h (window): Rename slot "nest" to "combination_limit".
1803 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1804 (Fset_window_nest): Rename to Fset_window_combination_limit.
1805 (Vwindow_nest): Rename to Vwindow_combination_limit.
1806 (recombine_windows, make_parent_window, make_window)
1807 (Fsplit_window_internal, saved_window)
1808 (Fset_window_configuration, save_window_save): Rename all
1809 occurrences of window_nest to window_combination_limit.
1811 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1813 * image.c (imagemagick_load_image): Fix typo.
1815 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1817 * xdisp.c (display_line): Move the call to
1818 highlight_trailing_whitespace before the call to
1819 compute_line_metrics, since the latter needs to see the final
1820 faces of all the glyphs to compute ROW's hash value.
1821 Fixes assertion violations in row_equal_p. (Bug#10035)
1823 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1825 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1826 just return (bug#10044).
1828 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1830 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1831 with user-defined heap size. Bump the default size of the temacs
1832 heap to 27MB, to avoid memory warning when running temacs.
1833 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1835 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1836 current_matrix and desired_matrix. (Bug#9990)
1837 (verify_row_hash) [XASSERTS]: New function.
1838 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1839 that the hash value of glyph rows is correct.
1841 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1843 * window.h (window): Remove splits slot.
1844 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1845 (Fdelete_other_windows_internal, make_parent_window)
1846 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1847 (Fset_window_configuration, save_window_save): Don't deal with
1848 split status of windows.
1849 (saved_window): Remove splits slot.
1850 (Vwindow_splits): Rewrite doc-string.
1852 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1854 * xfns.c (unwind_create_frame):
1855 * nsfns.m (unwind_create_frame):
1856 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1857 Vframe_list (Bug#9999).
1859 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1861 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1863 2011-11-11 Kenichi Handa <handa@m17n.org>
1865 * callproc.c (Fcall_process): Set the member dst_multibyte of
1868 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1870 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1871 avoid a crash (bug#9496).
1873 2011-11-09 Chong Yidong <cyd@gnu.org>
1875 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1876 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1878 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1880 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1882 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1884 Avoid some portability problems by eschewing 'extern inline' functions.
1885 The trivial performance wins aren't worth the portability hassles; see
1886 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1888 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1889 (window_box_width, window_box_left, window_box_left_offset)
1890 (window_box_right, window_box_right_offset): Undo previous change,
1891 by removing the "extern"s.
1892 * intervals.c (adjust_intervals_for_insertion)
1893 (adjust_intervals_for_deletion): Undo previous change,
1894 making these static again.
1895 (offset_intervals, temp_set_point_both, temp_set_point)
1896 (copy_intervals_to_string): No longer inline.
1897 * xdisp.c (window_text_bottom_y, window_box_width)
1898 (window_box_height, window_box_left_offset)
1899 (window_box_right_offset, window_box_left, window_box_right)
1900 (window_box): No longer inline.
1902 2011-11-08 Chong Yidong <cyd@gnu.org>
1904 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1905 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1906 Signal an error if not a live window.
1907 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1908 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1910 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1912 * lisp.h (syms_of_abbrev): Remove declaration.
1913 Reported by CHENG Gao <chenggao@royau.me>.
1915 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1917 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1918 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1919 of temacs in GUI mode.
1921 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1923 * window.h: Declare delete_all_child_windows instead of
1924 delete_all_subwindows.
1925 * window.c (Fwindow_nest, Fset_window_nest)
1926 (Fset_window_new_total, Fset_window_new_normal)
1927 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1928 (delete_all_subwindows): Rename to delete_all_child_windows.
1929 (Fdelete_other_windows_internal, Fset_window_configuration):
1930 Call delete_all_child_windows instead of delete_all_subwindows.
1931 * frame.c (delete_frame): Call delete_all_child_windows instead
1932 of delete_all_subwindows.
1934 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1936 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1937 This is also needed for porting to any host where GC_MARK_STACK is
1938 not GC_MAKE_GCPROS_NOOPS.
1939 (which_symbols): Use it.
1941 2011-11-07 Kenichi Handa <handa@m17n.org>
1943 * coding.c (coding_set_destination): Check coding->src_pos only
1944 when coding->src_object is a buffer (bug#9910).
1946 * process.c (send_process): Set the member src_multibyte of coding
1947 to 0 (bug#9911) when sending a unibyte text.
1949 * callproc.c (Fcall_process): Set the member src_multibyte of
1950 process_coding to 0 (bug#9912).
1952 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1954 * xmenu.c (cleanup_widget_value_tree): New function.
1955 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1956 calling free_menubar_widget_value_tree directly (Bug#9830).
1958 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1960 Fix some portability problems with 'inline'.
1961 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1962 (window_box_width, window_box_left, window_box_left_offset)
1963 (window_box_right, window_box_right_offset): Declare extern.
1964 Otherwise, these inline functions do not conform to C99 and
1965 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1966 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1967 * intervals.c (adjust_intervals_for_insertion)
1968 (adjust_intervals_for_deletion): Now extern, because otherwise the
1969 extern inline functions 'offset_intervals' couldn't refer to it.
1970 (static_offset_intervals): Remove.
1971 (offset_intervals): Rewrite using the old contents of
1972 static_offset_intervals. The old version didn't conform to C99
1973 because an extern inline function contained a reference to an
1974 identifier with static linkage.
1976 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1978 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1981 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1983 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1984 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1985 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1986 return Qleft_to_right.
1988 2011-11-06 Chong Yidong <cyd@gnu.org>
1990 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1991 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1992 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1993 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1994 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1995 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1996 (Fwindow_vscroll): Doc fix.
1997 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1998 argument, since it makes no sense to pass a live window and for
1999 consistency with window-child.
2001 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
2003 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
2006 2011-11-05 Jason Rumney <jasonr@gnu.org>
2008 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
2009 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
2011 (add_font_entity_to_list): Fix logic errors in mixed boolean and
2012 bitwise arithmetic preventing use of unicode-sip and non-truetype
2015 2011-11-05 Eli Zaretskii <eliz@gnu.org>
2017 * s/ms-w32.h (fstat, stat, utime): Move redirections to
2020 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
2021 initialization code to keep similarity to xfns.c after changes
2024 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
2026 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
2027 (unwind_create_frame): New function (Bug#9943).
2028 (Fx_create_frame): Restructure code to be more similar to the one in
2029 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
2030 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
2031 Move terminal->reference_count++ just before making the frame official
2034 * nsterm.m (x_free_frame_resources): New function.
2035 (x_destroy_window): Move code to x_free_frame_resources.
2037 * xfns.c (unwind_create_frame): Fix comment.
2038 (Fx_create_frame, x_create_tip_frame):
2039 Move terminal->reference_count++ just before making the frame
2040 official. Move initialization of image_cache_refcount and
2041 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
2043 2011-11-05 Eli Zaretskii <eliz@gnu.org>
2045 Support MSVC build with newer versions of Visual Studio.
2046 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
2047 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
2050 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
2051 which are not supported by MSVC.
2052 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
2053 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
2055 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
2057 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
2059 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
2061 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
2063 Support MSVC build with newer versions of Visual Studio.
2064 * w32.c: Don't include w32api.h for MSVC.
2065 (init_environment) [_MSC_VER]: Call sys_access, not _access.
2067 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
2068 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
2069 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
2070 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
2072 (alloca) [_MSC_VER]: Define to _alloca.
2074 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
2076 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
2078 2011-11-04 Eli Zaretskii <eliz@gnu.org>
2080 * xdisp.c (note_mouse_highlight): If either of
2081 previous/next-single-property-change returns nil, treat that as
2082 the beginning or the end of the buffer. (Bug#9955)
2084 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
2086 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
2087 label is not null (Bug#9951).
2088 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
2091 2011-11-04 Eli Zaretskii <eliz@gnu.org>
2093 * window.c (Fwindow_body_size): Mention in the doc string that the
2094 return value is in frame's canonical units. (Bug#9949)
2096 2011-11-03 Eli Zaretskii <eliz@gnu.org>
2098 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
2100 * w32fns.c (unwind_create_frame): If needed, free the glyph
2101 matrices of the partially constructed frame. (Bug#9943)
2102 * xfns.c (unwind_create_frame): Likewise.
2104 2011-11-01 Eli Zaretskii <eliz@gnu.org>
2106 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
2107 Don't stop backward scan on the continuation glyph, even though
2108 its CHARPOS is positive.
2109 (mouse_face_from_buffer_pos, note_mouse_highlight):
2110 Rename cover_string to disp_string.
2112 2011-11-01 Martin Rudalics <rudalics@gmx.at>
2114 * window.c (temp_output_buffer_show): Don't use
2115 Vtemp_buffer_show_specifiers.
2116 (Vtemp_buffer_show_specifiers): Remove unused variable.
2118 2011-10-30 Eli Zaretskii <eliz@gnu.org>
2120 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
2121 past the beginning of the current glyph matrix.
2123 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
2125 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
2126 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
2127 HAVE_GTK3 (Bug#9869).
2129 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
2130 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
2132 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
2134 * xterm.c: Declare x_handle_net_wm_state to return int.
2135 (handle_one_xevent): Check if we are iconified but don't have
2136 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
2137 (get_current_wm_state): Return non-zero if not hidden,
2138 check for _NET_WM_STATE_HIDDEN (Bug#9893).
2139 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
2140 (x_handle_net_wm_state): Return what get_current_wm_state returns.
2141 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
2143 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
2145 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
2146 so that this new function doesn't get optimized away by a
2147 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
2149 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2151 * frame.h (MOUSE_HL_INFO): Remove excess parens.
2153 2011-10-29 Eli Zaretskii <eliz@gnu.org>
2155 Fix the `xbytecode' command.
2156 * .gdbinit (xprintbytestr): New command.
2157 (xwhichsymbols): Rename from `which'; all callers changed.
2158 (xbytecode): Print the byte-code string as well.
2160 2011-10-29 Kim Storm <storm@cua.dk>
2162 * alloc.c (which_symbols): New function.
2164 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2166 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
2169 2011-10-29 Glenn Morris <rgm@gnu.org>
2171 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
2172 Not clear what it was for, and it causes various bugs. (Bug#9839)
2174 2011-10-28 Eli Zaretskii <eliz@gnu.org>
2176 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
2177 possible random value that matches one of those tested as
2178 condition to clear the mouse face.
2180 2011-10-28 Chong Yidong <cyd@gnu.org>
2182 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
2184 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
2186 * window.c (make_window): Initialize phys_cursor_on_p.
2188 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
2190 * lisp.h (struct Lisp_Symbol): Update comments.
2192 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
2194 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
2196 2011-10-28 Eli Zaretskii <eliz@gnu.org>
2198 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
2199 <oslsachem@gmail.com> for helping to debug this.
2201 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
2202 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
2203 (g_b_init_get_glyph_outline_w): New static variables.
2204 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
2205 (GetGlyphOutlineW_Proc): New typedefs.
2206 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
2207 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
2209 (w32font_open_internal, compute_metrics):
2210 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
2211 instead of calling the "wide" APIs directly.
2213 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
2215 * w32.h (syms_of_w32font): Add prototype.
2217 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2219 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
2220 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
2221 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
2222 (Fmove_to_window_line): Doc fix.
2224 2011-10-27 Chong Yidong <cyd@gnu.org>
2226 * process.c (make_process): Set gnutls_state to NULL.
2228 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
2229 non-NULL, regardless of GNUTLS_INITSTAGE.
2230 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
2231 an error. Set process slots as soon as we allocate them.
2233 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
2235 2011-10-27 Chong Yidong <cyd@gnu.org>
2237 * gnutls.c (emacs_gnutls_deinit): New function.
2238 Deallocate credentials structures as well as calling gnutls_deinit.
2239 (Fgnutls_deinit, Fgnutls_boot): Use it.
2241 * process.c (make_process): Initialize GnuTLS credentials to NULL.
2242 (deactivate_process): Call emacs_gnutls_deinit.
2244 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2246 * image.c (x_create_x_image_and_pixmap):
2247 * w32.c (sys_rename, w32_delayed_load):
2248 * w32font.c (fill_in_logfont):
2249 * w32reg.c (x_get_string_resource): Silence compiler warnings.
2251 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
2253 * w32fns.c (w32_default_color_map): New function,
2254 extracted from Fw32_default_color_map.
2255 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
2257 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
2259 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
2261 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
2263 * keyboard.c (test_undefined): New function (bug#9751).
2264 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
2266 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
2268 * sysdep.c (init_sys_modes): Fix the check for the controlling
2269 terminal (Bug#6649).
2271 2011-10-20 Eli Zaretskii <eliz@gnu.org>
2273 * dispextern.h (struct bidi_it): New member next_en_type.
2275 * bidi.c (bidi_line_init): Initialize the next_en_type member.
2276 (bidi_resolve_explicit_1): When next_en_pos is valid for the
2277 current character, check also for next_en_type being WEAK_EN.
2278 (bidi_resolve_weak): Don't enter the expensive loop if the current
2279 position is before next_en_pos. Record the bidi type of the first
2280 non-ET, non-BN character we find, in addition to its position.
2281 (bidi_level_of_next_char): Invalidate next_en_type when
2282 next_en_pos is over-stepped.
2284 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2286 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
2287 * editfns.c: Rewrite current-time-zone so that it invokes
2288 the equivalent of (format-time-string "%Z") to get the time zone name.
2289 This fixes a bug when the time zone name contains characters that
2290 need converting from the system time locale to Emacs internal format.
2291 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
2292 that patch fixed format-time-string to do the conversion, but
2293 I forgot to fix current-time-zone.
2294 (format_time_string): New function, containing most of
2295 what Fformat_time_string used to contain.
2296 (Fformat_time_string): Rewrite in terms of format_time_string.
2297 This doesn't change this function's behavior.
2298 (current-time-zone): Rewrite to use format_time_string.
2299 This fixes the bug reported by Michael Schierl in
2300 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2301 Jason Rumney's 2007-06-07 change worked around this bug, but
2303 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2305 2011-10-19 Eli Zaretskii <eliz@gnu.org>
2307 * xdisp.c (start_display): If the character at POS is displayed
2308 via a display vector, reset IT->current.dpvec_index to zero.
2309 (try_window_reusing_current_matrix): If a line ends in a display
2310 vector or the next line starts in a display vector, continue
2311 redrawing the window even though the character position of
2312 start_row was reached.
2315 2011-10-18 Chong Yidong <cyd@gnu.org>
2317 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2318 with nobreak-char-display too.
2320 2011-10-18 Eli Zaretskii <eliz@gnu.org>
2322 Fix part 3 of bug#9771.
2323 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2324 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2325 non-neutral characters if the current character is a paragraph
2326 separator (a.k.a. Newline). This avoids running the same
2327 expensive loop twice, once when we consume the preceding newline
2328 and the other time when the line actually needs to be displayed.
2329 Avoid the loop when we see neutrals on the base embedding level
2330 following a character whose directionality is the same as the
2331 paragraph's. This avoids running the expensive loop when a line
2332 ends in a long sequence of neutrals, like control characters.
2333 Add assertion against STRONG_AL type. Slightly rearrange code
2334 that determines the type of a neutral given the first non-neutral
2336 (bidi_level_of_next_char): Set next_en_pos to zero when
2337 invalidating its info.
2339 2011-10-17 Eli Zaretskii <eliz@gnu.org>
2341 * xdisp.c (push_display_prop): Determine whether to record string
2342 or buffer position by IT->string, not by IT->method. Allow
2343 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
2344 (move_it_vertically_backward): Don't look for character position
2345 immediately after the newline when in a continuation line.
2348 2011-10-15 Martin Rudalics <rudalics@gmx.at>
2350 * window.c (coordinates_in_window): Rewrite and delabelize
2351 vertical border check. (Bug#5357) (Bug#9618)
2353 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2355 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2356 errors in XSetWindowBorder (bug#9310).
2358 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2360 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2361 avoid crash when xmalloc overrun checking is enabled.
2363 2011-10-13 Eli Zaretskii <eliz@gnu.org>
2365 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2366 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2367 cursor motion with <left> and <right> arrow keys.
2369 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2370 some callers set that themselves.
2372 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2374 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2375 display string and the previous row comes from the same string and
2376 is empty. (Bug#9739) (Bug#9738)
2378 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2380 * doc.c (get_doc_string): Encode file name (bug#9735).
2382 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2384 * bidi.c (bidi_level_of_next_char):
2385 * xdisp.c (get_visually_first_element): Remove old incorrect
2386 comments regarding the Unicode Line Separator character.
2388 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2390 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2392 * alloc.c (Fgc_status): Do not access beyond zombies array
2393 boundary if nzombies > MAX_ZOMBIES.
2394 * alloc.c (dump_zombies): Add missing format specifier.
2396 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2398 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2399 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2401 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2402 Some packages use them to denote characters with modifiers.
2404 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2406 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2407 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2408 matching a pp-number. Rename parameter var to var1.
2410 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2412 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2414 2011-10-08 Glenn Morris <rgm@gnu.org>
2416 * callint.c (Fcall_interactively): Give a more explicit error for the
2417 'c' case with a non-character input. (Bug#8479)
2419 2011-10-08 Eli Zaretskii <eliz@gnu.org>
2421 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2423 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2424 lines that are hscrolled on the left.
2426 * dispnew.c (buffer_posn_from_coords): Account for a possible
2427 presence of header-line. (Bug#4426)
2429 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2431 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2432 Don't advertise functionality which we discourage or doesn't work.
2434 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2436 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2437 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2438 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2439 this makes Emacs dump core during garbage collection on rare
2440 occasions. sizeof is obviously inferior to offsetof here, so
2441 stick with offsetof.
2442 (GC_POINTER_ALIGNMENT): New macro.
2443 (mark_memory): Omit 3rd (offset) arg; caller changed.
2444 Don't assume EMACS_INT alignment is the same as pointer alignment.
2446 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2448 * keyboard.c (read_key_sequence_remapped): New var.
2449 (read_key_sequence): Compute remapping in the right buffer.
2450 (command_loop_1): Use read_key_sequence's remapping directly.
2452 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2454 * dired.c (file_name_completion): Don't expand file name.
2455 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2456 before checking file name handler.
2458 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2459 they've been requested explicitly (bug#9591).
2461 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
2463 * keymap.c (Fsingle_key_description): Use make_specified_string
2464 instead of build_string to build string from push_key_description.
2467 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2469 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2470 This fixes a Y2038 bug on 64-bit hosts.
2471 * buffer.c (reset_buffer):
2472 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2473 (Fclear_buffer_auto_save_failure):
2474 Use 0, not -1, to represent an unset failure time, since time_t
2475 might not be signed.
2477 Remove dependency on glibc malloc internals.
2478 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2479 Move back here from lisp.h, but with their new implementations.
2480 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2481 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2482 * charset.c (charset_table_init): New static var.
2483 (syms_of_charset): Use it instead of xmalloc. This removes a
2484 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2485 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2486 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2487 Move back to alloc.c.
2488 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2489 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2491 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2493 * nsterm.m (windowDidResize): Call x_set_window_size only when
2494 ns_in_resize is true. Otherwise set pixelwidth/height and
2495 call change_frame_size (Bug#9628).
2497 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2499 Port --enable-checking=all to Fedora 14 x86-64.
2500 * charset.c (syms_of_charset): Also account for glibc malloc's
2501 internal overhead when calculating the initial malloc maximum.
2503 Port --enable-checking=all to Fedora 14 x86.
2504 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2506 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2507 (overrun_check_realloc, overrun_check_free):
2508 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2509 That way, xmalloc returns a properly-aligned pointer even if
2510 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2511 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2512 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2513 into account when calculating the initial malloc maximum.
2514 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2515 Move here from alloc.c, so that charset.c can use it too.
2516 Properly align; the old code wasn't right for common 32-bit hosts
2517 when configured with --enable-checking=all.
2518 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2519 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2521 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2523 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2526 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2528 * xdisp.c (compute_display_string_end): If there's no display
2529 string at CHARPOS, return -1.
2531 * bidi.c (bidi_fetch_char): When compute_display_string_end
2532 returns a negative value, treat the character as a normal
2533 character not covered by a display string. (Bug#9624)
2535 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2537 * lread.c (Fread_from_string): Fix typo in docstring.
2539 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2541 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2542 newline, reseat the iterator instead of bidi-iterating there one
2543 character at a time. (Bug#9610)
2544 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2545 TO_CHARPOS if the bidi iterator is at base embedding level.
2547 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2549 * lread.c (readevalloop): Use correct code for NBSP.
2550 (read1): Likewise. (Bug#9608)
2552 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2554 * dbusbind.c (Fdbus_register_signal): When service is not
2555 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2557 2011-09-25 Glenn Morris <rgm@gnu.org>
2559 * buffer.c (truncate-lines): Doc fix.
2561 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2563 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2564 (Fset_window_next_buffers): Doc fix.
2566 2011-09-24 Glenn Morris <rgm@gnu.org>
2568 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2570 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2572 Fix minor problems found by static checking.
2573 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2574 * indent.c (Fvertical_motion): Fix == vs = typo.
2576 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2578 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2579 Default value is now t. Doc fix.
2581 * indent.c (Fvertical_motion): Compute and apply the overshoot
2582 logic when moving up, not only when moving down. Fix the
2583 confusing name and values of the it_overshoot_expected variable;
2584 logic changes accordingly. (Bug#9254) (Bug#9549)
2586 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2587 CHARPOS is covered by a display string which includes newlines.
2588 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2589 is covered by a display string with embedded newlines.
2591 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2593 * dbusbind.c (Fdbus_register_signal): Add match rule to
2594 Vdbus_registered_objects_table. (Bug#9581)
2595 (Fdbus_register_method, Vdbus_registered_objects_table):
2598 2011-09-24 Jim Meyering <meyering@redhat.com>
2600 do not ignore write error for any output size
2601 The previous change was incomplete.
2602 While it makes emacs --batch detect the vast majority of stdout
2603 write failures, errors were still ignored whenever the output size is
2604 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2605 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2606 && echo FAIL: ignored write error
2607 FAIL: ignored write error
2608 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2609 && echo FAIL: ignored write error
2610 FAIL: ignored write error
2611 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2613 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2615 * emacs.c (Fkill_emacs): In noninteractive mode exit
2616 non-successfully if a write error occurred on stdout. (Bug#9574)
2618 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2620 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2623 * dispextern.h (struct it): Update the comment documenting what
2626 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2628 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2629 a display string, extend search for cursor position to end of row.
2630 (find_row_edges): If the row ends in a newline from a display
2631 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2632 Handle the case of a display string with multiple newlines.
2633 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2634 non-empty line. Fixes confusing cursor motion with arrow keys at
2635 the beginning of a line that starts with whitespace.
2637 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2639 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2642 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2644 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2647 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2649 * xdisp.c (display_line): Record maximum and minimum buffer
2650 positions even if no glyphs were produced (e.g., by a zero-width
2651 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2652 buffer positions that will be removed from the glyph row because
2654 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2655 column is beyond frame width: don't subtract 1 "pixel" when
2656 computing width of the stretch.
2657 (reseat_at_next_visible_line_start): Undo the change made on
2658 2011-09-17 that saved paragraph information and restored it after
2659 the call to `reseat'. (Bug#9545)
2661 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2663 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2664 and turn window cursor on if cleared (Bug#9415).
2666 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2668 * search.c (boyer_moore): Take unibyte characters from pattern
2669 literally. (Bug#9458)
2671 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2673 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2675 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2677 Fix minor problem found by static checking.
2678 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2679 initialized, to pacify gcc -Wuninitialized.
2681 * fileio.c: Report proper errno when syscall falls.
2682 (Finsert_file_contents): Save and restore errno,
2683 so that report_file_error outputs the correct diagnostic.
2684 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2686 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2688 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2690 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2692 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2693 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2695 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2697 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2698 about the current paragraph and restore it after the call to reseat.
2700 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2701 (bidi_find_paragraph_start): Search back for paragraph beginning
2702 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2703 (bidi_move_to_visually_next): Only trigger paragraph-related
2704 computations when the last character is a newline or at EOB, not
2705 just any NEUTRAL_B. (Bug#9470)
2707 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2708 truncated lines if point is covered by a display string. (Bug#9524)
2710 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2712 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2713 (cons_to_x_long): New function.
2714 (lisp_data_to_selection_data): Use it. Correct the test for
2715 short-versus-long data; it was negated. Break out of vector
2716 loop, for efficiency, when a long datum is discovered.
2718 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2720 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2722 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2724 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2725 GCC PR/17406) by declaring this function with external scope.
2727 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2729 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2730 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2732 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2734 * editfns.c (Fformat): Correctly handle text properties on "%%".
2736 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2738 * xterm.c (x_draw_composite_glyph_string_foreground):
2739 * w32term.c (x_draw_composite_glyph_string_foreground):
2740 * term.c (encode_terminal_code):
2741 * composite.c (composition_update_it, get_composition_id):
2742 * xdisp.c (get_next_display_element)
2743 (fill_composite_glyph_string): Add comments about special meaning
2744 of TAB characters in a composition.
2746 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2748 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2749 This occurs when processing a multibyte format.
2750 Problem reported by Wolfgang Jenker.
2752 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2754 * xdisp.c (try_cursor_movement): Only check for exact match if
2755 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2757 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2759 Remove unused external symbols.
2760 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2761 * xdisp.c (calc_pixel_width_or_height): Now static.
2762 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2763 * indent.c (check_display_width):
2764 * w32term.c: Fix comment to match code.
2765 * xterm.c, xterm.h (x_catching_errors): Remove.
2767 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2769 * xselect.c: Use signed conversions more consistently (Bug#9498).
2770 (selection_data_to_lisp_data): Assume incoming selection data are
2771 signed integers, not unsigned. This is to be consistent with
2772 outgoing selection data, which was modified to use signed integers
2773 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2774 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2775 expects long, not unsigned long.
2777 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2779 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2780 computation of loop end. Reported by Johan Bockgård
2783 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2785 * frame.c (Fother_visible_frames_p): Function deleted.
2787 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2789 * indent.c (compute_motion): Process display vector front to back
2790 rather than the other way around. (Bug#2496)
2792 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2794 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2796 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2798 * minibuf.c (Fread_from_minibuffer): Doc fix.
2800 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2802 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2803 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2805 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2807 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2808 value for non-existent files.
2810 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2812 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2813 set its "size" to -1. This will set the modtime_size field of
2814 the corresponding buffer to -1, which is what
2815 verify-visited-file-modtime expects for files that do not exist.
2818 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2820 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2822 * lisp.h: ... from here. push_key_description is no longer
2823 defined in keyboard.c, so its declaration should not be in
2824 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2825 logically belongs with push_key_description.
2827 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2829 * buffer.h: Include <sys/types.h> instead of <time.h>.
2830 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2831 Problem reported by Herbert J. Skuhra.
2833 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2835 * xml.c (parse_region): Make the parsing work for
2836 non-comment-starting XML files again (bug#9144).
2838 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2840 * image.c (gif_load): Fix calculation of bottom and right corner.
2843 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2845 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2846 redisplay in small windows.
2848 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2850 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2852 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2854 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2855 Operate on live windows only.
2857 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2859 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2861 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2863 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2864 only under bidi iteration.
2866 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2868 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2870 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2872 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2873 Without this fix, the command to link temacs failed due to an
2874 undefined symbol __builtin_isnan. This is because
2875 /usr/include/iso/math_c99.h #defines isnan(x) to
2876 __builtin_isnan(x), but the bundled gcc, which identifies itself
2877 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2879 * floatfns.c (isnan): #undef, and then #define to a clone of
2881 (Fisnan): Always define, since it's always available now.
2882 (syms_of_floatfns): Always define isnan at the Lisp level.
2884 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2886 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2888 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2890 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2891 The previous code assumed that file offsets (off_t values) fit in
2892 EMACS_INT variables, which is not true on typical 32-bit hosts.
2893 The code messed up by falsely reporting buffer overflow in cases
2894 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2895 when "big" contains more than 2**29 bytes, even though this
2896 inserts just one byte and does not overflow the buffer.
2897 (Finsert_file_contents): Store file offsets as off_t
2898 values, not as EMACS_INT values. Check for overflow when
2899 converting between EMACS_INT and off_t. When checking for
2900 buffer overflow or for overlap, take the offsets into account.
2901 Don't use EMACS_INT for small values where int suffices.
2902 When checking for overlap, fix a typo: ZV was used where
2903 ZV_BYTE was intended.
2904 (Fwrite_region): Don't assume off_t fits into 'long'.
2905 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2907 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2909 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2911 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2913 sprintf-related integer and memory overflow issues (Bug#9412).
2915 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2916 (esprintf, exprintf, evxprintf): New functions.
2917 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2918 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2919 (modify_event_symbol): Do not assume that the length of
2920 name_alist_or_stem is safe to alloca and fits in int.
2921 (Fexecute_extended_command): Likewise for function name and binding.
2922 (Frecursion_depth): Wrap around reliably on integer overflow.
2923 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2924 since some callers pass EMACS_INT values.
2925 (Fsingle_key_description): Don't crash if symbol name contains more
2926 than MAX_ALLOCA bytes.
2927 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2928 (get_minibuffer): Arg is now EMACS_INT, not int.
2929 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2930 (esprintf, exprintf, evxprintf): New decls.
2931 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2933 * dbusbind.c (signature_cat): New function.
2934 (xd_signature, Fdbus_register_signal):
2935 Do not overrun buffer; instead, report string overflow.
2937 * dispnew.c (add_window_display_history): Don't overrun buffer.
2938 Truncate instead; this is OK since it's just a log.
2940 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2941 even if the time zone offset is outlandishly large.
2942 Don't mishandle offset == INT_MIN.
2944 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2945 when creating daemon; the previous buffer-overflow check was incorrect.
2947 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2948 which has the guts of the old verror function.
2950 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2951 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2953 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2954 (font_unparse_xlfd): Don't blindly alloca long strings.
2955 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2956 fits in int, when using sprintf. Use single snprintf to count
2957 length of string rather than counting it via multiple sprintfs;
2958 that's simpler and more reliable.
2959 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2960 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2961 sprintf, in case result does not fit in int.
2963 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2964 (fontset_from_font): Print it.
2966 * frame.c (tty_frame_count): Now printmax_t, not int.
2967 (make_terminal_frame, set_term_frame_name): Print it.
2968 (x_report_frame_params): In X, window IDs are unsigned long,
2969 not signed long, so print them as unsigned.
2970 (validate_x_resource_name): Check for implausibly long names,
2971 and don't assume name length fits in 'int'.
2972 (x_get_resource_string): Don't blindly alloca invocation name;
2973 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2976 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2977 (xg_check_special_colors, xg_set_geometry):
2978 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2980 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2981 Use esprintf, not sprintf, in case result does not fit in int.
2983 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2984 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2985 it as a large positive number.
2986 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2987 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2989 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2990 in case result does not fit in int.
2992 * print.c (float_to_string): Detect width overflow more reliably.
2993 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2994 buffer overrun. Don't assume list length fits in 'int'. Treat
2995 print length of 0 as 0, not as infinity; to be consistent with other
2996 uses of print length in this function. Don't overflow print length
2997 index. Don't assume hash table size fits in 'long', or that
2998 vectorlike size fits in 'unsigned long'.
3000 * process.c (make_process): Use printmax_t, not int, to format
3001 process-name gensyms.
3003 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
3005 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
3006 to avoid potential buffer overrun.
3008 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
3009 if X resource line is longer than 512 bytes.
3011 * xfns.c (x_window): Make sprintf buffer a bit bigger
3012 to avoid potential buffer overrun.
3014 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
3016 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
3018 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
3020 Integer overflow fixes for scrolling, etc.
3021 Without these, Emacs silently mishandles large integers sometimes.
3022 For example, "C-u 4294967297 M-x recenter" was treated as if
3023 it were "C-u 1 M-x recenter" on a typical 64-bit host.
3025 * xdisp.c (try_window_id): Check Emacs fixnum range before
3026 converting to 'int'.
3028 * window.c (window_scroll_line_based, Frecenter):
3029 Check that an Emacs fixnum is in range before assigning it to 'int'.
3030 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
3031 values converted from Emacs fixnums.
3032 (Frecenter): Don't wrap around a line count if it is out of 'int'
3033 range; instead, treat it as an extreme value.
3034 (Fset_window_configuration, compare_window_configurations):
3035 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
3037 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
3038 that can exceed INT_MAX. Check that EMACS_INT value is in range
3039 before assigning it to the (possibly-narrower) index.
3040 (match_limit): Don't assume that a fixnum can fit in 'int'.
3042 * print.c (print_object): Use ptrdiff_t, not int, for index that can
3045 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3046 (Fvertical_motion): Don't wrap around LINES values that don't fit
3047 in 'int'. Instead, treat them as extreme values. This is good
3048 enough for windows, which can't have more than INT_MAX lines anyway.
3050 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3052 * Require libxml/parser.h to avoid compilation warning.
3054 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
3056 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
3057 since this reportedly can destroy thread storage.
3059 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
3061 * syntax.c (find_defun_start): Update all cache variables if
3062 exiting early (Bug#9401).
3064 2011-08-30 Eli Zaretskii <eliz@gnu.org>
3066 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
3068 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
3069 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
3070 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
3072 * term.c (tty_append_glyph): New function.
3073 (produce_stretch_glyph): Static function and its prototype deleted.
3075 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
3078 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
3080 * image.c (parse_image_spec): Check for nonnegative, not for positive,
3081 when checking :margin (Bug#9390).
3082 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
3083 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
3084 so that the name doesn't mislead. All uses changed.
3086 2011-08-28 Johan Bockgård <bojohan@gnu.org>
3088 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
3091 2011-08-27 Eli Zaretskii <eliz@gnu.org>
3093 * xdisp.c (move_it_to): Don't bail out early when reaching
3094 position beyond to_charpos, if we are scanning backwards.
3095 (move_it_vertically_backward): When DY == 0, make sure we get to
3096 the first character in the line after the newline.
3098 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
3100 * ccl.c: Improve and simplify overflow checking (Bug#9196).
3101 (ccl_driver): Do not generate an out-of-range pointer.
3102 (Fccl_execute_on_string): Remove unnecessary check for
3103 integer overflow, noted by Stefan Monnier in
3104 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
3105 Remove a FIXME that didn't need fixing.
3106 Simplify the newly-introduced buffer reallocation code.
3108 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
3110 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
3112 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
3114 Integer and memory overflow issues (Bug#9196).
3116 * doc.c (get_doc_string): Rework so that
3117 get_doc_string_buffer_size is the actual buffer size, rather than
3118 being 1 less than the actual buffer size; this makes xpalloc more
3121 * image.c (x_allocate_bitmap_record, cache_image):
3122 * xselect.c (Fx_register_dnd_atom):
3123 Simplify previous changes by using xpalloc.
3125 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
3126 since either will do and ptrdiff_t is convenient with xpalloc.
3128 * charset.c (charset_table_size)
3129 (struct charset_sort_data.priority): Now ptrdiff_t.
3130 (charset_compare): Don't overflow if priorities differ greatly.
3131 (Fsort_charsets): Don't assume list length fits in int.
3132 Check for size-calculation overflow when allocating sort data.
3133 (syms_of_charset): Allocate an initial charset table that is
3134 just under 64 KiB, to avoid problems with glibc malloc and mmap.
3136 * cmds.c (internal_self_insert): Check for size-calculation overflow.
3138 * composite.h (struct composition.glyph_len): Now int, not unsigned.
3139 The actual value is always <= INT_MAX, and leaving it unsigned made
3140 overflow checking harder.
3142 * dispextern.h (struct glyph_matrix.rows_allocated)
3143 (struct face_cache.size): Now ptrdiff_t, for convenience in use
3144 with xpalloc. The values are still always <= INT_MAX.
3146 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
3148 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
3149 (SAFE_NALLOCA): New macro.
3151 * region-cache.c (struct boundary.pos, find_cache_boundary)
3152 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
3153 (set_cache_region, invalidate_region_cache)
3154 (revalidate_region_cache, know_region_cache, region_cache_forward)
3155 (region_cache_backward, pp_cache):
3156 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
3157 so that ptrdiff_t * can be passed to xpalloc.
3158 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
3159 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
3160 (pp_cache): Don't assume cache_len fits in int.
3161 * region-cache.h: Adjust extern decls to match.
3163 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
3164 EMACS_INT, since either will do, for xpalloc.
3166 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
3167 (xnmalloc, xnrealloc, xpalloc): New functions.
3169 * bidi.c (bidi_shelve_header_size): New constant.
3170 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
3171 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
3173 * bidi.c (bidi_cache_shrink):
3174 * buffer.c (overlays_at, overlays_in, record_overlay_string)
3176 Don't update size of array until after memory allocation succeeds,
3177 because xmalloc/xrealloc may not return.
3178 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
3179 now that we have proper integer overflow checking.
3180 (record_overlay_string, overlay_strings): Catch overflows when
3181 calculating size of overlay_str_buf.
3183 * callproc.c (Fcall_process): Check for size overflow when
3184 calculating size of args2.
3185 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
3186 Normally we prefer signed values, but sticking with ptrdiff_t would
3187 require adding more-complicated checks.
3189 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
3190 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
3191 Redo buffer-overflow calculations to avoid integer overflow.
3192 Add a FIXME comment where memory seems to be over-allocated.
3194 * character.c (Fstring): Check for size-calculation overflow.
3196 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
3197 unnecessary integer overflow. Check for size overflow.
3198 (encode_coding_object): Don't update size until xmalloc succeeds.
3200 * composite.c (get_composition_id): Check for overflow in glyph
3201 length calculations.
3203 Integer and memory overflow fixes for display code.
3204 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
3205 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
3206 (scrolling_window): Check for overflow in size calculations.
3207 (line_draw_cost, realloc_glyph_pool, add_row_entry):
3208 Don't assume glyph table len fits in int.
3209 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
3210 (row_table_size): Now ptrdiff_t, not int.
3211 (scrolling_window): Avoid overflow in size calculations.
3212 Don't update size until allocation succeeds.
3213 * fns.c (concat): Check for overflow in size calculations.
3214 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
3215 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3216 (NEXT_ALMOST_PRIME_LIMIT): New constant.
3218 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
3219 (get_doc_string): Check for size calculation overflow.
3220 Don't update size until allocation succeeds.
3221 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
3222 EMACS_INT, where ptrdiff_t will do.
3223 (Fsubstitute_command_keys): Check for string overflow.
3225 * editfns.c (set_time_zone_rule): Don't assume environment length
3227 (message_length): Now ptrdiff_t, not int.
3228 (Fmessage_box): Don't update size until allocation succeeds.
3229 Don't assume message length fits in int.
3230 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
3232 * emacs.c (main): Do not reallocate argv, since there is a null at
3233 the end that can be overwritten, and this way there's no need to
3234 worry about size-calculation overflow.
3235 (sort_args): Check for size-calculation overflow.
3237 * eval.c (init_eval_once, grow_specpdl): Don't update size until
3239 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
3241 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
3242 (x_set_scroll_bar_width, x_figure_window_size):
3243 Check for integer overflow.
3244 (x_set_alpha): Do not assume XINT fits in int.
3246 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
3247 This is for the members text_lines, text_cols, total_lines, total_cols,
3248 where the system imposes an 'int' limit.
3250 * fringe.c (Fdefine_fringe_bitmap):
3251 Don't update size until alloc works.
3253 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
3254 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
3256 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
3257 Check for size-calculation overflow.
3258 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
3259 do, as we prefer signed integers.
3260 (id_to_widget.max_size, id_to_widget.used)
3261 (xg_store_widget_in_map, xg_remove_widget_from_map)
3262 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
3263 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
3264 Use and return ptrdiff_t, not int.
3265 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
3266 * gtkutil.h: Change prototypes to match the above.
3268 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
3269 are duplicate now that they've been promoted to lisp.h.
3270 (x_allocate_bitmap_record, x_alloc_image_color)
3271 (make_image_cache, cache_image, xpm_load):
3272 Don't update size until alloc is done.
3273 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
3275 Check for size calculation overflow.
3276 (ct_colors_allocated_max): New constant.
3277 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
3280 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
3281 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
3282 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
3283 Use ptrdiff_t, not int, to count maps.
3284 (read_char_minibuf_menu_prompt): Check for overflow in size
3285 calculations. Don't update size until allocation succeeds.
3286 Redo calculations to avoid overflow.
3287 * keyboard.h: Change prototypes to match the above.
3289 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
3291 (current_minor_maps): Check for size calculation overflow.
3292 * keymap.h: Change prototypes to match the above.
3294 * lread.c (read1, init_obarray): Don't update size until alloc done.
3296 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
3297 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
3299 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3300 Now ptrdiff_t, not int.
3301 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3302 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3304 * process.c (Fnetwork_interface_list): Check for overflow
3305 in size calculation.
3307 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3309 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3310 overflow. Don't bother calling xmalloc when xrealloc will do.
3312 * search.c (Freplace_match): Check for size calculation overflow.
3313 (Fset_match_data): Don't assume list lengths fit in 'int'.
3315 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3316 for command line length. Do not attempt to address one before the
3317 beginning of an array, as that's not portable.
3319 * term.c (max_frame_lines): Remove; unused.
3320 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3322 (encode_terminal_code, calculate_costs): Check for size
3323 calculation overflow.
3324 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3325 table lengths and related sizes. Don't update size until alloc
3326 done. Redo calculations to avoid overflow.
3327 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3329 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3330 subtracting pointers.
3331 (gobble_line): Check for overflow more carefully. Don't update size
3334 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3335 Don't update size until alloc done.
3336 Redo size calculations to avoid overflow.
3337 Check for size calculation overflow.
3338 (main) [DEBUG]: Fix typo in invoking tparam1.
3340 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3341 Use ptrdiff_t, not int, for sizes.
3342 (store_mode_line_noprop_char): Don't update size until alloc done.
3344 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3345 Use ptrdiff_t, not int, for sizes.
3346 (Finternal_make_lisp_face, cache_face):
3347 Check for size calculation overflow.
3348 (cache_face): Treat size calculation overflows as if they were
3349 memory exhaustion (the usual treatment), rather than aborting.
3351 * xfns.c (x_encode_text, x_set_name_internal)
3352 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3353 sizes, since they can exceed INT_MAX in size. Check for size
3354 calculation overflow.
3356 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3357 (xg_select): Check for size calculation overflow.
3358 Don't update size until alloc done.
3360 * xrdb.c (get_environ_db): Don't assume path length fits in int,
3361 as sprintf is limited to int lengths.
3363 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3364 (X_LONG_MIN): New macros.
3365 Use them to make the following changes clearer.
3366 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3367 This change doesn't affect the value now, but it may help remind
3368 future maintainers not to raise the value too much later.
3369 (SELECTION_QUANTUM): Remove, replacing with ...
3370 (selection_quantum): ... new function, which avoids overflow.
3372 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3373 assumption that selection length fits in 'int'.
3374 (x_reply_selection_request, x_handle_selection_request)
3375 (x_get_window_property, receive_incremental_selection)
3376 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3377 (lisp_data_to_selection_data, clean_local_selection_data):
3378 Use ptrdiff_t, not int, to record length of selection.
3379 (x_reply_selection_request, x_get_window_property)
3380 (receive_incremental_selection, x_property_data_to_lisp):
3381 Redo calculations to avoid overflow.
3382 (x_reply_selection_request): When sending hint, ceiling it at
3383 X_LONG_MAX rather than relying on wraparound overflow to send
3385 (x_get_window_property, receive_incremental_selection)
3386 (lisp_data_to_selection_data, x_property_data_to_lisp):
3387 Check for size-calculation overflow.
3388 (x_get_window_property, receive_incremental_selection)
3389 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3390 Don't store size until memory allocation succeeds.
3391 (x_get_window_property): Plug memory leak on memory exhaustion.
3392 Don't double-block input; malloc is safe here. Don't assume 2**34
3393 - 4 fits in unsigned long. Add an xassert to check
3394 XGetWindowProperty overflow. Be more careful about overflow
3395 calculations, and distinguish size from memory overflow better.
3396 (receive_incremental_selection): When tracing, don't assume
3397 unsigned int is less than INT_MAX.
3398 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3399 harmful) conversions of unsigned short to int.
3400 (lisp_data_to_selection_data): Don't assume that integers
3401 in the range -65535 through -1 fit in an X unsigned short.
3402 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3403 result parameters unless successful. Rely on cons_to_unsigned
3404 to report problems with elements; the old code wasn't right anyway.
3405 (x_check_property_data): Check for int overflow; we cannot use
3406 a wider type due to X limits.
3407 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3409 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
3411 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3412 (x_term_init): Check for size calculation overflow.
3413 (x_color_cells): Don't store size until memory allocation succeeds.
3414 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
3415 Don't assume alloca size is less than MAX_ALLOCA.
3416 (x_term_init): Don't assume length fits in int (sprintf is limited
3419 Use ptrdiff_t for composition IDs.
3420 * character.c (lisp_string_width):
3421 * composite.c (composition_table_size, n_compositions)
3422 (get_composition_id, composition_gstring_from_id):
3423 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3424 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3425 * window.c (Frecenter):
3426 Use ptrdiff_t, not int, for composition IDs.
3427 * composite.c (get_composition_id): Check for integer overflow.
3428 * composite.h: Adjust prototypes to match the above changes.
3430 Use ptrdiff_t for hash table indexes.
3431 * category.c (hash_get_category_set):
3432 * ccl.c (ccl_driver):
3433 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3434 * coding.c (coding_system_charset_list, detect_coding_system):
3435 * coding.h (struct coding_system.id):
3436 * composite.c (get_composition_id, gstring_lookup_cache):
3437 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3438 * image.c (xpm_get_color_table_h):
3439 * lisp.h (hash_lookup, hash_put):
3440 * minibuf.c (Ftest_completion):
3441 Use ptrdiff_t for hash table indexes, not int (which is too
3442 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3443 32-bit --with-wide-int hosts).
3445 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3446 Add a FIXME comment about memory leaks.
3447 (syms_of_charset): Don't assume xmalloc returns.
3449 Don't assume that stated character widths fit in int.
3450 * character.c (Fchar_width, c_string_width, lisp_string_width):
3451 * character.h (CHAR_WIDTH):
3452 * indent.c (MULTIBYTE_BYTES_WIDTH):
3453 Use sanitize_char_width to avoid undefined and/or bad behavior
3454 with outlandish widths.
3455 * character.h (sanitize_tab_width): Rename from sanitize_width,
3456 now that we have two such functions. All uses changed.
3457 (sanitize_char_width): New inline function.
3459 Don't assume that tab-width fits in int.
3460 * character.h (sanitize_width): New inline function.
3461 (SANE_TAB_WIDTH): New macro.
3462 (ASCII_CHAR_WIDTH): Use it.
3463 * indent.c (sane_tab_width): Remove. All uses replaced by
3464 SANE_TAB_WIDTH (current_buffer).
3465 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3467 * fileio.c: Integer overflow issues with file modes.
3468 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3470 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3471 Remove unreachable code.
3472 (read_hex, load_charset_map_from_file): Check for integer overflow.
3474 * xterm.c: Don't go over XClientMessageEvent limit.
3475 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3476 (x_send_scroll_bar_event): Likewise. Check that the size does not
3477 exceed limits imposed by XClientMessageEvent, as well as the usual
3478 ptrdiff_t and size_t limits.
3480 * keyboard.c: Overflow, signedness and related fixes.
3481 (make_lispy_movement): Use same integer type in forward decl
3482 that is used in the definition.
3483 (read_key_sequence, keyremap_step):
3484 Change bufsize argument back to int, undoing my 2011-03-30 change.
3485 We prefer signed types, and int is wide enough here.
3486 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3487 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3488 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3489 length, not size_t. Use ptrdiff_t for index, not int.
3490 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3491 possibility of integer overflow.
3493 Overflow, signedness and related fixes for images.
3495 * dispextern.h (struct it.stack[0].u.image.image_id)
3496 (struct_it.image_id, struct image.id, struct image_cache.size)
3497 (struct image_cache.used, struct image_cache.ref_count):
3498 * gtkutil.c (update_frame_tool_bar):
3499 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3500 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3501 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3502 * nsmenu.m (update_frame_tool_bar):
3503 * xdisp.c (calc_pixel_width_or_height):
3504 * xfns.c (image_cache_refcount):
3505 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3506 on typical 64-bit hosts.
3508 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3509 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3510 Omit unnecessary casts to int.
3511 (parse_image_spec): Check that integers fall into 'int' range
3512 when the callers expect that.
3513 (image_ascent): Redo ascent calculation to avoid int overflow.
3514 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3515 (lookup_image): Remove unnecessary tests.
3516 (xbm_image_p): Locals are now of int, not EMACS_INT,
3517 since parse_image_check makes sure they fit into int.
3518 (png_load, gif_load, svg_load_image):
3519 Prefer int to unsigned where either will do.
3520 (tiff_handler): New function, combining the cores of the
3521 old tiff_error_handler and tiff_warning_handler.
3522 This function is rewritten to use vsnprintf and thereby avoid
3523 stack buffer overflows. It uses only the features of vsnprintf
3524 that are common to both POSIX and native Microsoft.
3525 (tiff_error_handler, tiff_warning_handler): Use it.
3526 (tiff_load, gif_load, imagemagick_load_image):
3527 Don't assume :index value fits in 'int'.
3528 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3529 (imagemagick_load_image): Check that crop parameters fit into
3530 the integer types that MagickCropImage accepts. Don't assume
3531 Vimagemagick_render_type has a nonnegative value. Don't assume
3532 size_t fits in 'long'.
3533 (gs_load): Use printmax_t to print the widest integers possible.
3534 Check for integer overflow when computing image height and width.
3536 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3538 * xdisp.c (redisplay_window): Don't force window start if point
3539 will be invisible in the resulting window. (Bug#9324)
3541 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3543 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3544 the display spec is of the form `(space ...)'.
3545 (handle_display_spec): Return the value returned by
3546 handle_single_display_spec, not just 1 or zero.
3547 (handle_single_display_spec): If the display spec is of the form
3548 `(space ...)', and specifies display in the text area, return 2
3550 (try_cursor_movement): Check for the need to scroll more
3551 accurately, and prefer exact match for point under bidi.
3552 Don't advance `row' beyond the last row of the window.
3554 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3555 into disp_prop; all users changed.
3557 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3558 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3559 for the text covered by the display property.
3561 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3563 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3564 Change return value to nil.
3565 (Frecord_buffer): Delete unused function.
3567 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3569 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3570 buffers, return left-to-right.
3571 (set_cursor_from_row): Consider candidate row a win if its glyph
3572 represents a newline and point is on that newline. Fixes cursor
3573 positioning on the newline at EOL of R2L text within L2R
3574 paragraph, and vice versa.
3575 (try_cursor_movement): Check continued rows, in addition to
3576 continuation rows. Fixes unwarranted scroll when point enters a
3577 continued line of R2L text within an L2R paragraph, or vice versa.
3578 (cursor_row_p): Consider the case of point being equal to
3579 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3580 from the end of a short line to the beginning of a continued line
3581 of R2L text within L2R paragraph.
3582 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3583 composed characters.
3585 * bidi.c (bidi_check_type): Use xassert.
3586 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3589 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3591 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3594 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3596 * nsfont.m (ns_otf_to_script): Fix typo.
3598 2011-08-22 Kenichi Handa <handa@m17n.org>
3600 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3601 extra slot even if the purpose is char-code-property-table.
3603 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3605 * xdisp.c (redisplay_window): When computing centering_position,
3606 account for the height of the header line. (Bug#8874)
3608 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3609 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3610 candidate is selected by the mouse, and that candidate has a
3611 composed character under the mouse.
3613 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3614 coordinates reported by pos-visible-in-window-p for a composed
3615 character in column zero.
3617 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3619 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3621 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3623 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3624 consider it a hit if to_charpos is anywhere in the range of the
3625 composed buffer positions.
3627 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3629 * image.c (gif_load): Don't assume that each subimage has the same
3630 dimensions as the base image. Handle disposal method that is
3631 "undefined" by the gif spec (Bug#9335).
3633 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3635 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3636 (Fcondition_case): Document `debug' symbol in error handler.
3638 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3640 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3641 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3642 from an Org mode buffer to a Speedbar frame.
3644 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3645 a composition, take its buffer position from IT->cmp_it.charpos.
3646 Fixes cursor positioning at the beginning of a line that begins
3647 with a composed character.
3649 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3651 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3652 character bidirectional type, use STRONG_L instead. Fixes crashes
3653 in a buffer produced by `describe-categories'.
3655 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3656 members before the level stack, so they would be saved and
3657 restored when copying iterator state. Fixes incorrect reordering
3658 around TABs covered by display properties.
3660 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3662 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3664 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3666 * eval.c (internal_condition_case, internal_condition_case_1)
3667 (internal_condition_case_2, internal_condition_case_n):
3668 Remove unnecessary aborts (Bug#9081).
3670 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3672 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3673 has no `load' handler, try opening the file locally. (Bug#9311)
3675 2011-08-16 Ken Brown <kbrown@cornell.edu>
3677 * gmalloc.c: Expand comment.
3679 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3681 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3682 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3684 2011-08-16 Ken Brown <kbrown@cornell.edu>
3686 Fix memory allocation problems in Cygwin build (Bug#9273).
3688 * unexcw.c ( __malloc_initialized): Declare external variable.
3689 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3691 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3693 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3695 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3697 [CYGWIN] (special_realloc): New function.
3698 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3699 requests to realloc storage in the static heap.
3701 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3703 * bidi.c (bidi_initialize): Remove unused local.
3705 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3708 * biditype.h: Remove file.
3709 * makefile.w32-in ($(BLD)/bidi.$(O)):
3710 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3712 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3714 * chartab.c: Improve commentary for the uniprop_table API.
3716 * bidi.c (bidi_paragraph_init): Support zero value of
3717 bidi_ignore_explicit_marks_for_paragraph_level.
3718 (bidi_initialize): Use uniprop_table instead of including
3719 biditype.h and bidimirror.h.
3721 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3722 coordinates of the iterator when restoring from ppos_it.
3725 2011-08-14 Kenichi Handa <handa@m17n.org>
3727 * process.c (create_process): Call setup_process_coding_systems
3728 after the pid of the process is set to -1 (Bug#8162).
3730 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3732 * xdisp.c (move_it_in_display_line_to): Don't invoke
3733 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3734 ppos_it. Fixes vertical cursor motion when line beginning is
3735 covered by an image. (Bug#9296)
3737 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3739 * nsterm.h (ns_run_ascript): Declare.
3740 (NSAPP_DATA2_RUNASSCRIPT): Define.
3742 * nsfns.m (as_script, as_result, as_status): New static variables.
3743 (ns_run_ascript): New function.
3744 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3745 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3746 the event loop. Get status from as_status (Bug#7276).
3748 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3749 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3750 the event loop (Bug#7276).
3752 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3754 * gnutls.c (QCgnutls_bootprop_priority)
3755 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3756 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3757 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3758 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3759 (QCgnutls_bootprop_verify_hostname_error)
3760 (QCgnutls_bootprop_callbacks_verify): Rename from
3761 Qgnutls_bootprop_..., all uses changed.
3763 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3766 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3768 * xfaces.c (Qframe_set_background_mode): Now static.
3769 * dispextern.h (Qframe_set_background_mode): Remove decl.
3771 * process.c (Fnetwork_interface_info): Declare local only if needed.
3773 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3775 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3776 (Fnetwork_interface_list): Allocate in increments of bytes instead
3777 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3778 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3780 (struct ifflag_def): notrailers is smart on OSX.
3781 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3782 Get hardware address with getifaddrs if available.
3784 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3786 * xdisp.c (iterate_out_of_display_property): xassert that
3787 IT->position is set to within IT->object's boundaries. Break from
3788 the loop as soon as EOB is reached; avoids infloops in redisplay
3789 when IT->position is set up wrongly due to some bug.
3790 Set IT->current to match the bidi iterator unconditionally.
3791 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3792 entry. Force push_it to save on the stack the current
3793 buffer/string position, to be restored by pop_it. Fix flags in
3794 the iterator structure wrt the object coming from a display
3795 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3796 properties. (Bug#9284)
3798 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3800 * fontset.c (fontset_get_font_group): Add proper type checks.
3803 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3805 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3806 and LC_VERSION_MIN_MACOSX.
3807 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3808 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3810 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3812 * xdisp.c (forward_to_next_line_start): Allow to use the
3813 no-display-properties-and-no-overlays under bidi display.
3814 Set disp_pos in the bidi iterator to avoid searches for display
3815 properties and overlays.
3817 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3819 * editfns.c (Fset_time_zone_rule): Document relationship with the
3822 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3823 the font entity extracted from the cache (Bug#8109).
3825 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3827 * composite.c (autocmp_chars): Don't reset point. That is done by
3828 restore_point_unwind (Bug#5984).
3830 2011-08-07 Juri Linkov <juri@jurta.org>
3832 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3833 to show the arg `TIME' instead of `TIMEVAL'.
3835 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3837 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3838 display property strides EOL and includes a newline, as in
3839 longlines-mode. (Bug#9254)
3840 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3841 word-wrap under bidirectional display. (Bug#9224)
3843 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3844 is non-zero, even if the data buffer is NULL. Fixes a crash in
3845 vertical-motion with longlines-mode. (Bug#9254)
3847 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3849 * bidi.c <bidi_cache_total_alloc>: Now static.
3850 (bidi_initialize): Initialize bidi_cache_total_alloc.
3852 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3855 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3856 amount allocated this far in `bidi_cache_total_alloc'.
3857 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3858 non-zero, only free the data buffer without restoring the cache
3859 contents. All callers changed.
3861 * dispextern.h (bidi_unshelve_cache): Update prototype.
3863 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3864 (move_it_in_display_line, move_it_to)
3865 (move_it_vertically_backward, move_it_by_lines): Replace the call
3866 to xfree to an equivalent call to bidi_unshelve_cache.
3867 (move_it_in_display_line_to): Fix logic of returning
3868 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3870 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3872 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3873 came from a string character with a `cursor' property. (Bug#9229)
3875 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3877 * Makefile.in (LIB_PTHREAD): New variable.
3878 (LIBES): Add LIB_PTHREAD (Bug#9216).
3880 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3881 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3883 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3885 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3887 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3889 * xterm.c (x_find_topmost_parent): New function.
3890 (x_set_frame_alpha): Find topmost parent window with
3891 x_find_topmost_parent and set the property there also (bug#9181).
3892 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3894 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3896 * callproc.c (Fcall_process): Avoid vfork clobbering
3897 the local vars buffer, coding_systems, current_dir.
3899 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3901 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3903 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3905 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3906 so that it is not optimized away.
3908 * xdisp.c (compute_display_string_pos): Remove unused local.
3910 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3912 Fix slow cursor motion and scrolling in large buffers with
3913 selective display, like Org Mode buffers. (Bug#9218)
3915 * dispextern.h (struct bidi_it): New member disp_prop_p.
3917 * xdisp.c: Remove one-slot cache of display string positions.
3918 (compute_display_string_pos): Accept an additional argument
3919 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3920 for a display string or property. If found, set DISP_PROP_P
3923 * bidi.c (bidi_fetch_char): Accept an additional argument
3924 DISP_PROP_P, and pass it to compute_display_string_pos.
3925 Only handle text covered by a display string if DISP_PROP_P is returned
3926 non-zero. All callers of bidi_fetch_char changed.
3928 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3930 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3932 2010-12-03 Don March <don@ohspite.net>
3934 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3935 last character M-[char] is translated to ESC [char] (bug#7541).
3937 2011-08-02 Kenichi Handa <handa@m17n.org>
3939 * lisp.h (uniprop_table): Extern it.
3941 * chartab.c (uniprop_table): Make it non-static.
3943 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3945 * xdisp.c (forward_to_next_line_start): Accept additional argument
3946 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3948 (reseat_at_next_visible_line_start): Use the bidi iterator state
3949 returned by forward_to_next_line_start to restore the state of
3950 it->bidi_it after backing up to previous newline. (Bug#9212)
3952 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3954 * regex.c (re_comp): Protoize.
3955 (re_exec): Fix return type.
3956 (regexec): Fix type of `ret'. (Bug#9203)
3958 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3960 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3961 This is needed if max-image-size is a floating-point number.
3963 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3965 * print.c (print_object): Print empty symbol as ##.
3967 * lread.c (read1): Read ## as empty symbol.
3969 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3971 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3972 setting frame foreground color (Bug#9175).
3973 (x_set_background_color): Likewise.
3975 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3976 contents (Bug#9176).
3977 (EmacsTooltip -init): Remove bezels and add shadows to
3980 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3981 or scroll bar (Bug#8470).
3983 * nsfont.m (nsfont_open): Remove assignment to voffset and
3984 unnecessary vars hshink, expand, hd, full_height, min_height.
3985 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3987 * nsterm.h (nsfont_info): Remove voffset field.
3989 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3991 Implement strike-through and overline on NextStep (Bug#8863).
3993 * nsfont.m (nsfont_open): Use underline position provided by font,
3994 instead of hard-coded value of 2.
3995 (nsfont_draw): Call ns_draw_text_decoration instead.
3997 * nsterm.h: Add declaration for ns_draw_text_decoration.
3999 * nsterm.m (ns_draw_text_decoration): New function for drawing
4000 underline, overline, and strike-through.
4001 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
4002 ns_draw_text_decoration. Change treatment of cursor drawing to
4003 accommodate underlining, etc.
4005 2011-07-28 Eli Zaretskii <eliz@gnu.org>
4007 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
4010 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4012 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
4013 Without this fix, if a signal arrives just after memory fills up,
4014 'malloc' might be invoked reentrantly.
4016 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
4017 In other words, assume that every image size is allowed, on non-X
4018 hosts. This assumption is probably wrong, but it lets Emacs compile.
4020 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
4022 * regex.c (re_iswctype): Convert return values to boolean.
4024 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
4026 * xdisp.c (compute_display_string_pos): Don't use cached display
4027 string position if the buffer had its restriction changed.
4030 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4032 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4034 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4036 Integer signedness and overflow and related fixes. (Bug#9079)
4038 * bidi.c: Integer size and overflow fixes.
4039 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
4040 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
4041 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4042 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
4043 (bidi_find_other_level_edge):
4044 Use ptrdiff_t instead of EMACS_INT where either will do.
4045 This works better on 32-bit hosts configured --with-wide-int.
4046 (bidi_cache_ensure_space): Check for size-calculation overflow.
4047 Use % rather than repeated addition, for better worst-case speed.
4048 Don't set bidi_cache_size until after xrealloc returns, because it
4050 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
4051 (bidi_cache_ensure_space): Also check that the bidi cache size
4052 does not exceed that of the largest Lisp string or buffer. See Eli
4053 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
4055 * alloc.c (__malloc_size_t): Remove.
4056 All uses replaced by size_t. See Andreas Schwab's note
4057 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
4059 * image.c: Improve checking for integer overflow.
4060 (check_image_size): Assume that f is nonnull, since
4061 it is always nonnull in practice. This is one less thing to
4062 worry about when checking for integer overflow later.
4063 (x_check_image_size): New function, which checks for integer
4064 overflow issues inside X.
4065 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
4066 This removes the need for a memory_full check.
4067 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
4068 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
4069 (xbm_read_bitmap_data): Change locals back to 'int', since
4070 their values must fit in 'int'.
4071 (xpm_load_image, png_load, tiff_load):
4072 Invoke x_create_x_image_and_pixmap earlier,
4073 to avoid much needless work if the image is too large.
4074 (tiff_load): Treat overly large images as if
4075 x_create_x_image_and_pixmap failed, not as malloc failures.
4076 (gs_load): Use x_check_image_size.
4078 * gtkutil.c: Omit integer casts.
4079 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
4080 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
4082 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
4084 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
4085 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
4086 would wrongly return t on a 64-bit host.
4088 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
4089 The plain *_OVERFLOW macros run afoul of GCC bug 49705
4090 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
4091 and therefore cause GCC to emit a bogus diagnostic in some cases.
4093 * image.c: Integer signedness and overflow and related fixes.
4094 This is not an exhaustive set of fixes, but it's time to
4095 record what I've got.
4096 (lookup_pixel_color, check_image_size): Remove redundant decls.
4097 (check_image_size): Don't assume that arbitrary EMACS_INT values
4098 fit in 'int', or that arbitrary 'double' values fit in 'int'.
4099 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
4100 (tiff_load, imagemagick_load_image):
4101 Check for overflow in size calculations.
4102 (x_create_x_image_and_pixmap): Remove unnecessary test for
4103 xmalloc returning NULL; that can't happen.
4104 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
4105 (xpm_color_bucket): Use better integer hashing function.
4106 (xpm_cache_color): Don't possibly over-allocate memory.
4107 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
4108 (gif_memory_source):
4109 Use ptrdiff_t, not int or size_t, to record sizes.
4110 (png_load): Don't assume values greater than 2**31 fit in 'int'.
4111 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
4112 either works, as we prefer signed integers.
4113 (tiff_read_from_memory, tiff_write_from_memory):
4114 Return tsize_t, not size_t, since that's what the TIFF API wants.
4115 (tiff_read_from_memory): Don't fail simply because the read would
4116 go past EOF; instead, return a short read.
4117 (tiff_load): Omit no-longer-needed casts.
4118 (Fimagemagick_types): Don't assume size fits into 'int'.
4120 Improve hashing quality when configured --with-wide-int.
4121 * fns.c (hash_string): New function, taken from sxhash_string.
4122 Do not discard information about ASCII character case; this
4123 discarding is no longer needed.
4124 (sxhash-string): Use it. Change sig to match it. Caller changed.
4125 * lisp.h: Declare it.
4126 * lread.c (hash_string): Remove, since we now use fns.c's version.
4127 The fns.c version returns a wider integer if --with-wide-int is
4128 specified, so this should help the quality of the hashing a bit.
4130 * emacs.c: Integer overflow minor fix.
4131 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
4132 Define only if GNU_LINUX.
4133 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
4135 * dispnew.c: Integer signedness and overflow fixes.
4136 Remove unnecessary forward decls, that were a maintenance hassle.
4137 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
4139 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
4140 (scrolling_window): Use ptrdiff_t, not int, for byte count.
4141 (prepare_desired_row, line_draw_cost):
4142 Use int, not unsigned, where either works.
4143 (save_current_matrix, restore_current_matrix):
4144 Use ptrdiff_t, not size_t, where either works.
4145 (init_display): Check for overflow more accurately, and without
4146 relying on undefined behavior.
4148 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
4149 Remove, replacing with the new symbols in lisp.h. All uses changed.
4150 * fileio.c (make_temp_name):
4151 * filelock.c (lock_file_1, lock_file):
4152 * xdisp.c (message_dolog):
4153 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
4154 Use pMd etc. instead.
4155 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
4156 replacing the pWIDE etc. symbols removed from editfns.c.
4158 * keyboard.h (num_input_events): Now uintmax_t.
4159 This is (very slightly) less likely to mess up due to wraparound.
4162 * buffer.c: Integer signedness fixes.
4163 (alloc_buffer_text, enlarge_buffer_text):
4164 Use ptrdiff_t rather than size_t when either will do, as we prefer
4167 * alloc.c: Integer signedness and overflow fixes.
4168 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
4169 (__malloc_size_t): Default to size_t, not to int.
4170 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
4171 (Fgarbage_collect, mark_object_loop_halt, mark_object):
4172 Prefer ptrdiff_t to size_t when either would do, as we prefer
4174 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
4175 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
4176 Now const. Initialize with values that are in range even if char
4178 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
4179 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
4180 These functions do the right thing with sizes > 2**32.
4181 (check_depth): Now ptrdiff_t, not int.
4182 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
4183 Adjust to new way of storing sizes. Check for size overflow bugs
4185 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
4186 slightly wrong anyway, as it missed one instance of
4187 XMALLOC_OVERRUN_CHECK_OVERHEAD.
4188 (refill_memory_reserve): Omit needless cast to size_t.
4189 (mark_object_loop_halt): Mark as externally visible.
4191 * xselect.c: Integer signedness and overflow fixes.
4192 (Fx_register_dnd_atom, x_handle_dnd_message):
4193 Use ptrdiff_t, not size_t, since we prefer signed.
4194 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
4195 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
4196 x_dnd_atoms_size and x_dnd_atoms_length.
4198 * doprnt.c: Prefer signed to unsigned when either works.
4200 * doprnt.c (doprnt):
4202 * xdisp.c (vmessage):
4203 Use ptrdiff_t, not size_t, when using or implementing doprnt,
4204 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
4205 prefer signed arithmetic to avoid comparison confusion.
4206 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
4207 but is a bit tricky.
4209 Assume freestanding C89 headers, string.h, stdlib.h.
4210 * data.c, doprnt.c, floatfns.c, print.c:
4211 Include float.h unconditionally.
4212 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
4213 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
4214 * regex.c: Likewise for stddef.h, string.h.
4215 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
4216 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
4217 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
4218 (STDC_HEADERS): Remove obsolete defines.
4219 * sysdep.c: Include limits.h unconditionally.
4221 Assume support for memcmp, memcpy, memmove, memset.
4222 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
4223 * regex.c (memcmp, memcpy):
4224 Remove; we assume C89 now.
4226 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
4227 (__malloc_safe_bcopy): Remove; no longer needed.
4229 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
4230 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
4231 well either way, and we prefer signed to unsigned.
4233 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
4235 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
4236 closes the connection while we're reading (bug#9182).
4238 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
4240 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
4241 are specified (Bug#9168).
4243 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
4245 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
4246 Found by GCC static checking and --with-wide-int on a 32-bit host.
4248 2011-07-25 Eli Zaretskii <eliz@gnu.org>
4250 * xdisp.c (compute_display_string_pos): Fix logic of caching
4251 previous display string position. Initialize cached_prev_pos to
4252 -1. Fixes slow-down at the beginning of a buffer.
4254 2011-07-24 Eli Zaretskii <eliz@gnu.org>
4256 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
4257 for attrs[LFACE_FONTSET_INDEX].
4259 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
4261 * xml.c (parse_region): Remove unused local
4262 that was recently introduced.
4264 2011-07-23 Eli Zaretskii <eliz@gnu.org>
4266 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
4267 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
4269 * xdisp.c (move_it_in_display_line_to): Record the best matching
4270 position for TO_CHARPOS while scanning the line, and restore it on
4271 exit if none of the characters scanned was an exact match.
4272 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
4273 when exact match is impossible due to invisible text, and the
4274 lines are truncated.
4276 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
4278 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4281 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4283 Fix a significant slow-down of cursor motion with C-n, C-p,
4284 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
4285 auto-repeat under bidi redisplay in fontified buffers.
4286 * xdisp.c (compute_stop_pos_backwards): New function.
4287 (next_element_from_buffer): Call compute_stop_pos_backwards to
4288 find a suitable prev_stop when we find ourselves before
4290 (reseat): Don't look for prev_stop, as that could mean a very long
4292 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
4293 <cached_disp_overlay_modiff>: Cache for last found display string
4295 (compute_display_string_pos): Return the cached position if asked
4296 about the same buffer in the same area of character positions, and
4297 the buffer wasn't changed since the time the display string
4298 position was cached.
4300 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4302 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4303 is an integer, which is important for empty lines. (Bug#9149)
4305 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
4307 * frame.c (Fmodify_frame_parameters): In tty case, update the
4308 default face if necessary (Bug#4238).
4310 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
4312 * editfns.c (Fstring_to_char): No need to explain what a character
4313 is in the docstring (Bug#6576).
4315 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4317 * xml.c (parse_region): Make sure we always return a tree.
4319 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4321 * xml.c (parse_region): If a document contains only comments,
4324 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4326 * xml.c (make_dom): Return comments, too.
4328 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4331 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4332 and the surrounding thread.
4333 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4334 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4335 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4337 * s/openbsd.h (BROKEN_SIGIO): Define.
4338 * unexelf.c (unexec) [__OpenBSD__]:
4339 Don't update the .mdebug section of the Alpha COFF symbol table.
4341 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4343 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4346 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4348 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4349 This fixes some race conditions on the permissions of any newly
4352 * alloc.c (valid_pointer_p): Use pipe, not open.
4353 This fixes some permissions issues when debugging.
4355 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4356 If fchown fails to set both uid and gid, try to set just gid,
4357 as that is sometimes allowed. Adjust the file's mode to eliminate
4358 setuid or setgid bits that are inappropriate if fchown fails.
4360 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4362 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4363 to compare Lisp_Objects.
4364 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4365 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4366 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4368 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4370 * lread.c (read_integer): Unread even EOF character.
4371 (read1): Likewise. Properly record start position of symbol.
4373 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4374 symbol character follows.
4376 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4378 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4379 This works around a problem with the previous change to Fcopy_file.
4380 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4381 and without this change, GCC might complain about discarding
4382 fchown's return value.
4384 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
4386 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4388 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4390 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4392 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4394 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4395 it's used from the C level.
4397 * process.c: Use the same condition for POLL_FOR_INPUT in both
4398 keyboard.c and process.c (bug#1858).
4400 2011-07-09 Lawrence Mitchell <wence@gmx.li>
4402 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4403 (Fgnutls_boot): Use it.
4405 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4407 * doc.c (Fsubstitute_command_keys): Revert last change.
4409 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4411 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4412 quotes the next character, and doesn't affect other longer
4413 sequences (bug#8935).
4415 * lread.c (syms_of_lread): Clarify that is isn't only
4416 `eval-buffer' and `eval-defun' that's affected by
4417 `lexical-binding' (bug#8460).
4419 2011-07-15 Eli Zaretskii <eliz@gnu.org>
4421 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
4422 bidi redisplay when a line includes both an image and is truncated.
4424 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4426 Fix minor problems found by static checking.
4427 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4428 (elsz): Now a signed constant, not a size_t var. We prefer signed
4429 types to unsigned, to avoid integer comparison confusion. Without
4430 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4431 "cannot optimize loop, the loop counter may overflow", a symptom
4433 * indent.c (Fvertical_motion): Mark locals as initialized.
4434 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4436 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4438 * search.c (Fre_search_backward): Mention `case-fold-search' in
4439 all the re_search_* functions (bug#8138).
4441 * keyboard.c (Fopen_dribble_file): Document when the file is
4444 2011-07-14 Eli Zaretskii <eliz@gnu.org>
4446 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4449 Support bidi reordering of display and overlay strings.
4450 * xdisp.c (compute_display_string_pos)
4451 (compute_display_string_end): Accept additional argument STRING.
4452 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4453 (reseat_to_string): Initialize bidi_it->string.s and
4454 bidi_it->string.schars.
4455 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
4456 NULL (avoids a crash in bidi_paragraph_init).
4457 Initialize itb.string.lstring.
4458 (init_iterator): Call bidi_init_it only of a valid
4459 buffer position was specified. Initialize paragraph_embedding to
4461 (reseat_to_string): Initialize the bidi iterator.
4462 (display_string): If we need to ignore text properties of
4463 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4464 original value of -1 will not work with bidi.)
4465 (compute_display_string_pos): First arg is now struct
4466 `text_pos *'; all callers changed. Support display properties on
4468 (compute_display_string_end): Support display properties on Lisp
4470 (init_iterator, reseat_1, reseat_to_string): Initialize the
4471 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4472 when iterating on a string not from display properties).
4473 (compute_display_string_pos, compute_display_string_end):
4474 Fix calculation of the object to scan. Fixes an error when using
4476 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4477 base_level_stop; instead, set base_level_stop to BEGV.
4478 Fixes crashes in vertical-motion.
4479 (next_element_from_buffer): Improve commentary for when
4480 the iterator is before prev_stop.
4481 (init_iterator): Initialize bidi_p from the default value of
4482 bidi-display-reordering, not from buffer-local value. Use the
4483 buffer-local value only if initializing for buffer iteration.
4484 (handle_invisible_prop): Support invisible properties on strings
4485 that are being bidi-reordered.
4486 (set_iterator_to_next): Support bidi reordering of C strings and
4488 (next_element_from_string): Support bidi reordering of Lisp
4490 (handle_stop_backwards): Support Lisp strings as well.
4491 (display_string): Support display of R2L glyph rows.
4492 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4493 (init_iterator): Don't initialize it->bidi_p for strings
4495 (reseat_to_string): Initialize it->bidi_p for strings here.
4496 (next_element_from_string, next_element_from_c_string)
4497 (next_element_from_buffer): Add xassert's for correspondence
4498 between IT's object being iterated and it->bidi_it.string
4500 (face_before_or_after_it_pos): Support bidi iteration.
4501 (next_element_from_c_string): Handle the case of the first string
4502 character that is not the first one in the visual order.
4503 (get_visually_first_element): New function, refactored from common
4504 parts of next_element_from_buffer, next_element_from_string, and
4505 next_element_from_c_string.
4506 (tool_bar_lines_needed, redisplay_tool_bar)
4507 (display_menu_bar): Force left-to-right direction. Add a FIXME
4508 comment for making that be controlled by a user option.
4509 (push_it, pop_it): Save and restore the state of the
4510 bidi iterator. Save and restore the bidi_p flag.
4511 (pop_it): Iterate out of display property for string iteration as
4513 (iterate_out_of_display_property): Support iteration over strings.
4514 (handle_single_display_spec): Set up it->bidi_it for iteration
4515 over a display string, and call bidi_init_it.
4516 (handle_single_display_spec, next_overlay_string)
4517 (get_overlay_strings_1, push_display_prop): Set up the bidi
4518 iterator for displaying display or overlay strings.
4519 (forward_to_next_line_start): Don't use the shortcut if
4521 (back_to_previous_visible_line_start): If handle_display_prop
4522 pushed the iterator stack, restore the internal state of the bidi
4523 iterator by calling bidi_pop_it same number of times.
4524 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4525 and we are bidi-iterating, don't decrement the iterator position;
4526 instead, set the first_elt flag in the bidi iterator, to produce
4528 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4529 (push_display_prop): xassert that we are iterating a buffer.
4530 (push_it, pop_it): Save and restore paragraph_embedding member.
4531 (handle_single_display_spec, next_overlay_string)
4532 (get_overlay_strings_1, reseat_1, reseat_to_string)
4533 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4534 correctly. Don't assume unibyte strings are not bidi-reordered.
4535 (compute_display_string_pos)
4536 (compute_display_string_end): Fix handling the case of C string.
4537 (push_it, pop_it): Save and restore from_disp_prop_p.
4538 (handle_single_display_spec, push_display_prop): Set the
4539 from_disp_prop_p flag.
4540 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4541 (pop_it): Call iterate_out_of_display_property only if we are
4542 popping after iteration over a string that came from a display
4543 property. Fix a typo in popping stretch info. Add an assertion
4544 for verifying that the iterator position is in sync with the bidi
4546 (handle_single_display_spec, get_overlay_strings_1)
4547 (push_display_prop): Fix initialization of paragraph direction for
4548 string when that of the parent object is not yet determined.
4549 (reseat_1): Call bidi_init_it to resync the bidi
4550 iterator with IT's position. (Bug#7616)
4551 (find_row_edges): If ROW->start.pos gives position
4552 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4553 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4554 Reset the from_disp_prop_p flag.
4555 (SAVE_IT, RESTORE_IT): New macros.
4556 (pos_visible_p, face_before_or_after_it_pos)
4557 (back_to_previous_visible_line_start)
4558 (move_it_in_display_line_to, move_it_in_display_line)
4559 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4560 (try_scrolling, redisplay_window, display_line): Use them when
4561 saving a temporary copy of the iterator and restoring it back.
4562 (back_to_previous_visible_line_start, reseat_1)
4563 (init_iterator): Empty the bidi cache "stack".
4564 (move_it_in_display_line_to): If iterator ended up at
4565 EOL, but we never saw any buffer positions smaller than
4566 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4567 motion in bidi-reordered lines.
4568 (move_it_in_display_line_to): Record prev_method and prev_pos
4569 immediately before the call to set_iterator_to_next. Fixes cursor
4570 motion in bidi-reordered lines with stretch glyphs and strings
4571 displayed in margins. (Bug#8133) (Bug#8867)
4572 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4574 (pos_visible_p): Support positions in bidi-reordered lines.
4575 Save and restore bidi cache.
4577 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4578 (bidi_paragraph_info): Delete unused struct.
4579 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4580 (bidi_cache_start): New variable.
4581 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4583 (bidi_cache_fetch_state, bidi_cache_search)
4584 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4585 (bidi_cache_find, bidi_peek_at_next_level)
4586 (bidi_level_of_next_char, bidi_find_other_level_edge)
4587 (bidi_move_to_visually_next): Compare cache index with
4588 bidi_cache_start rather than with zero.
4589 (bidi_fetch_char): Accept new argument STRING; all callers
4590 changed. Support iteration over a string. Support strings with
4591 display properties. Support unibyte strings. Fix the type of
4592 `len' according to what STRING_CHAR_AND_LENGTH expects.
4593 (bidi_paragraph_init, bidi_resolve_explicit_1)
4594 (bidi_resolve_explicit, bidi_resolve_weak)
4595 (bidi_level_of_next_char, bidi_move_to_visually_next):
4596 Support iteration over a string.
4597 (bidi_set_sor_type, bidi_resolve_explicit_1)
4598 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4599 can now be zero (for strings); special values 0 and -1 were
4600 changed to -1 and -2, respectively.
4601 (bidi_char_at_pos): New function.
4602 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4603 Call it instead of FETCH_MULTIBYTE_CHAR.
4604 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4605 initialized to valid values.
4606 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4608 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4609 the test for valid cached positions. Fix the logic for looking up
4610 the sentinel state in the cache. GCPRO the Lisp string we are
4612 (bidi_push_it, bidi_pop_it): New functions.
4613 (bidi_initialize): Initialize the bidi cache start stack pointer.
4614 (bidi_cache_ensure_space): New function, refactored from part of
4615 bidi_cache_iterator_state. Don't assume the required size is just
4616 one BIDI_CACHE_CHUNK away.
4617 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4618 (bidi_count_bytes, bidi_char_at_pos): New functions.
4619 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4620 always valid if bidi_cache_idx is valid.
4621 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4622 is valid if it's going to be used.
4623 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4624 (bidi_cache_fetch_state, bidi_cache_search)
4625 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4626 (bidi_cache_iterator_state, bidi_cache_find)
4627 (bidi_find_other_level_edge, bidi_cache_start_stack):
4628 All variables related to cache indices are now EMACS_INT.
4630 * dispextern.h (struct bidi_string_data): New structure.
4631 (struct bidi_it): New member `string'. Make flag members be 1-bit
4632 fields, and put them last in the struct.
4633 (compute_display_string_pos, compute_display_string_end):
4635 (bidi_push_it, bidi_pop_it): Add prototypes.
4636 (struct iterator_stack_entry): New members bidi_p,
4637 paragraph_embedding, and from_disp_prop_p.
4638 (struct it): Member bidi_p is now a bit field 1 bit wide.
4639 (bidi_shelve_cache, bidi_unshelve_cache):
4642 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4643 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4644 and vector-like objects.
4646 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4647 cache around display iteration.
4649 * window.c (Fwindow_end, window_scroll_pixel_based)
4650 (displayed_window_lines, Frecenter): Save and restore the bidi
4651 cache around display iteration.
4653 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4655 * editfns.c (Fdelete_region): Clarify the use of the named
4656 parameters (bug#6788).
4658 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4660 * indent.c (Fvertical_motion): Set and restore w->pointm when
4661 saving and restoring the window's buffer (Bug#9006).
4663 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4665 * editfns.c (Fstring_to_char): Clarify just what is returned
4666 (bug#6576). Text by Eli Zaretskii.
4668 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4670 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4672 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4674 * buffer.c (mmap_find): Fix a typo.
4676 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4678 Fix execution of x selection hooks.
4679 * xselect.c (Qx_lost_selection_functions)
4680 (Qx_sent_selection_functions): New vars.
4681 (syms_of_xselect): DEFSYM them.
4682 (x_handle_selection_request): Pass Qx_sent_selection_functions
4683 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4684 (x_handle_selection_clear,x_clear_frame_selections):
4685 Pass Qx_lost_selection_functions rather than
4686 Vx_lost_selection_functions to Frun_hook_with_args.
4688 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4690 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4691 The old code sometimes used this field without initializing it.
4693 * alloc.c (gc_sweep): Don't read past end of array.
4694 In theory, the old code could also have corrupted Emacs internals,
4695 though it'd be very unlikely.
4697 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4699 * character.c (Fcharacterp): Don't advertise optional ignored
4700 argument. (Bug#4026)
4702 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4704 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4707 * window.c (Fset_window_start): Doc fix (bug#4199).
4708 (Fset_window_hscroll): Ditto.
4710 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4712 Fix minor new problems caught by GCC 4.6.1.
4713 * term.c (init_tty): Remove unused local.
4714 * xsettings.c (store_monospaced_changed): Define this function only
4715 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4718 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4720 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4722 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4724 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4725 are the mini-buffer and the echo area (bug#3320).
4727 * term.c (init_tty): Remove support for supdup, c10 and perq
4728 terminals, which are no longer supported (bug#1482).
4730 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4732 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4734 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4736 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4737 for non-popups (Bug#3642).
4739 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4741 * alloc.c (reset_malloc_hooks): Protoize.
4742 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4743 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4744 * cm.c (losecursor): Likewise.
4745 * data.c (fmod): Likewise.
4746 * dispnew.c (swap_glyphs_in_rows): Likewise.
4747 * emacs.c (memory_warning_signal): Likewise.
4748 * floatfns.c (float_error): Likewise.
4749 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4750 (otf_open, font_otf_capability, generate_otf_features)
4751 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4753 * image.c (pbm_read_file): Likewise.
4754 * indent.c (string_display_width): Likewise.
4755 * intervals.c (check_for_interval, search_for_interval)
4756 (inc_interval_count, count_intervals, root_interval)
4757 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4758 * lread.c (defalias): Likewise.
4759 * ralloc.c (r_alloc_check): Likewise.
4760 * regex.c (set_image_of_range_1, set_image_of_range)
4761 (regex_grow_registers): Likewise.
4762 * sysdep.c (strerror): Likewise.
4763 * termcap.c (valid_filename_p, tprint, main): Likewise.
4764 * tparam.c (main): Likewise.
4765 * unexhp9k800.c (run_time_remap, save_data_space)
4766 (update_file_ptrs, read_header, write_header, calculate_checksum)
4767 (copy_file, copy_rest, display_header): Likewise.
4768 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4770 * xdisp.c (check_it): Likewise.
4771 * xfaces.c (register_color, unregister_color, unregister_colors):
4773 * xfns.c (print_fontset_result): Likewise.
4774 * xrdb.c (member, fatal, main): Likewise.
4776 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4778 Fix minor problems found by static checking (Bug#9031).
4779 * chartab.c (char_table_set_range, map_sub_char_table):
4780 Remove unused locals.
4781 (uniprop_table): Now static.
4782 * composite.c (_work_char): Remove unused static var.
4784 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4786 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4788 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4790 * gtkutil.c (qttip_cb): Remove code without function.
4792 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4794 * w32.c (pthread_sigmask): New stub.
4796 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4798 Use pthread_sigmask, not sigprocmask (Bug#9010).
4799 sigprocmask is portable only for single-threaded applications, and
4800 Emacs can be multi-threaded when it uses GTK.
4801 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4803 * callproc.c (Fcall_process):
4804 * process.c (create_process):
4805 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4806 Use pthread_sigmask, not sigprocmask.
4808 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4810 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4811 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4814 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4816 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4817 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4818 (xg_hide_tooltip): Fix comment.
4820 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4821 in registerServicesMenuSendTypes.
4822 (validRequestorForSendType): Don't check ns_return_types.
4824 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4827 2011-07-08 Jason Rumney <jasonr@gnu.org>
4829 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4830 SH_SHOW for hidden windows (Bug#5482).
4832 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4833 frame struct members of non-existent frames (Bug#6284).
4835 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4837 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4838 variable firstTime not needed on OSX >= 10.6.
4839 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4840 >= 10.5. Use setKnobProportion, setDoubleValue.
4842 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4843 (MAC_OS_X_VERSION_10_5): Define if not defined.
4844 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4845 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4846 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4848 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4849 cString and lossyCString on OSX >= 10.4
4851 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4852 sizeToFit on OSX >= 10.2.
4854 * nsimage.m (allocInitFromFile): Don't use deprecated method
4855 bestRepresentationForDevice on OSX >= 10.6.
4857 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4860 * emacs.c: Declare unexec_init_emacs_zone.
4862 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4864 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4866 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4867 on svcsMenu (Bug#8842).
4869 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4871 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4873 * nsterm.m (QUTF8_STRING): Declare.
4874 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4875 (validRequestorForSendType): Return type is (id).
4876 Change indexOfObjectIdenticalTo to indexOfObject.
4877 Check if we have local selection before returning self (Bug#8842).
4878 (writeSelectionToPasteboard): Put local selection into paste board
4879 if we have a local selection (Bug#8842).
4880 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4882 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4883 (ns_get_local_selection): Declare.
4885 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4887 * keymap.c (describe_map_tree): Don't insert a double newline at
4888 the end of the buffer (bug#1169) and return whether we inserted
4891 * callint.c (Fcall_interactively): Change "reading args" to
4892 "providing args" to try to clarify what it does (bug#1010).
4894 2011-07-07 Kenichi Handa <handa@m17n.org>
4896 * composite.c (composition_compute_stop_pos): Ignore a static
4897 composition starting before CHARPOS (Bug#8915).
4899 * xdisp.c (handle_composition_prop): Likewise.
4901 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4903 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4906 2011-07-07 Kenichi Handa <handa@m17n.org>
4908 * character.h (unicode_category_t): New enum type.
4910 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4911 (Qchar_code_property_table): New variable.
4912 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4913 (UNIPROP_COMPRESSED_FORM_P): New macros.
4914 (char_table_ascii): Uncompress the compressed values.
4915 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4916 Uncompress the compressed values.
4917 (sub_char_table_ref_and_range): Likewise.
4918 (char_table_ref_and_range): Uncompress the compressed values.
4919 (sub_char_table_set): New arg is_uniprop. Callers changed.
4920 Uncompress the compressed values.
4921 (sub_char_table_set_range): Args changed. Callers changed.
4922 (char_table_set_range): Adjuted for the above change.
4923 (map_sub_char_table): Delete args default_val and parent. Add arg
4924 top. Give decoded values to a Lisp function.
4925 (map_char_table): Adjust for the above change. Give decoded
4926 values to a Lisp function. Gcpro more variables.
4927 (uniprop_table_uncompress)
4928 (uniprop_decode_value_run_length): New functions.
4929 (uniprop_decoder, uniprop_decoder_count): New variables.
4930 (uniprop_get_decoder, uniprop_encode_value_character)
4931 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4933 (uniprop_encoder, uniprop_encoder_count): New variables.
4934 (uniprop_get_encoder, uniprop_table)
4935 (Funicode_property_table_internal, Fget_unicode_property_internal)
4936 (Fput_unicode_property_internal): New functions.
4937 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4938 Sunicode_property_table_internal, Sget_unicode_property_internal,
4939 and Sput_unicode_property_internal. Defvar_lisp
4940 char-code-property-alist.
4942 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4943 Vunicode_category_table.
4945 * font.c (font_range): Adjust for the change of
4946 Vunicode_category_table.
4948 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4950 * m/iris4d.h: Remove file, move contents ...
4951 * s/irix6-5.h: ... here.
4953 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4955 Remove unportable assumption about struct layout (Bug#8884).
4956 * alloc.c (mark_buffer):
4957 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4958 (clone_per_buffer_values): Don't assume that
4959 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4960 This isn't true in general, and it's particularly not true
4961 if Emacs is configured with --with-wide-int.
4962 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4963 New macros, used in the buffer.c change.
4965 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4967 * xsettings.c: Use both GConf and GSettings if both are available.
4968 (store_config_changed_event): Add comment.
4969 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4970 (store_tool_bar_style_changed): New functions.
4971 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4972 (struct xsettings): Move font inside HAVE_XFT.
4973 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4974 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4975 Move inside HAVE_XFT.
4976 (something_changed_gsettingsCB): Rename from something_changedCB.
4977 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4979 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4980 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4981 (something_changed_gconfCB): Rename from something_changedCB.
4982 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4983 (parse_settings): Move check for font inside HAVE_XFT.
4984 (read_settings, apply_xft_settings): Add comment.
4985 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4986 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4987 call store_font_name_changed.
4988 (xft_settings_event): Add comment.
4989 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4990 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4991 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4992 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4993 (xsettings_initialize): Call init_gsettings last.
4994 (xsettings_get_system_font, xsettings_get_system_normal_font):
4997 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4999 Random fixes. E.g., (random) never returned negative values.
5000 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
5001 subseconds part to the entropy, as that's a bit more random.
5002 Prefer signed to unsigned, since the signedness doesn't matter and
5003 in general we prefer signed. When given a limit, use a
5004 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
5005 latter isn't right if USE_2_TAGS_FOR_INTS.
5006 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
5007 not 0..VALMASK. Don't discard "excess" bits that random () returns.
5009 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
5011 * textprop.c (text_property_stickiness):
5012 Obey Vtext_property_default_nonsticky.
5013 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
5014 * w32fns.c (syms_of_w32fns):
5015 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
5017 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
5019 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
5020 This is more efficient than Ffile_directory_p and avoids a minor race.
5022 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
5024 * buffer.c (Foverlay_put): Say what the return value is
5027 * fileio.c (barf_or_query_if_file_exists): Check first if the file
5028 is a directory before asking whether to use the file name
5030 (barf_or_query_if_file_exists): Make the "File is a directory"
5031 error be more correct.
5033 * fns.c (Frequire): Remove the mention of the .gz files, since
5034 that's installation-specific, but keep the mention of
5035 `get-load-suffixes'.
5037 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
5039 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
5040 Report string overflow if the output is too long.
5042 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
5044 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
5045 (syms_of_gnutls): Remove duplicate DEFSYM for
5046 Qgnutls_bootprop_verify_hostname_error, an error for
5047 Qgnutls_bootprop_verify_error (which is no longer used).
5049 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
5050 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
5051 Also (re)move comments that are misplaced or no longer relevant.
5053 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5055 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
5057 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
5059 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
5060 and background color parameters if they have been changed.
5062 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5064 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
5066 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
5068 * xsettings.c (SYSTEM_FONT): Define only when used.
5069 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
5071 * keymap.c (access_keymap_1): Now static.
5073 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
5075 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
5076 leave any prefix arg for the up event (Bug#1586).
5078 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
5080 * lread.c (syms_of_lread): Mention single symbols defined by
5081 `defvar' or `defconst' (bug#7154).
5083 * fns.c (Frequire): Mention .el.gz files (bug#7314).
5084 (Frequire): Mention get-load-suffixes.
5086 2011-07-02 Martin Rudalics <rudalics@gmx.at>
5088 * window.h (window): Remove clone_number slot.
5089 * window.c (Fwindow_clone_number, Fset_window_clone_number):
5091 (make_parent_window, make_window, saved_window)
5092 (Fset_window_configuration, save_window_save): Don't deal with
5094 * buffer.c (Qclone_number): Remove declaration.
5095 (sort_overlays, overlay_strings): Don't deal with clone numbers.
5097 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
5099 Add multiple inheritance to keymaps.
5100 * keymap.c (Fmake_composed_keymap): New function.
5101 (Fset_keymap_parent): Simplify.
5102 (fix_submap_inheritance): Remove.
5103 (access_keymap_1): New function extracted from access_keymap to handle
5104 embedded parents and handle lists of maps.
5105 (access_keymap): Use it.
5106 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
5107 (Fcopy_keymap): Handle embedded parents.
5108 (Fcommand_remapping, define_as_prefix): Simplify.
5109 (Fkey_binding): Simplify.
5110 (syms_of_keymap): Move minibuffer-local-completion-map,
5111 minibuffer-local-filename-completion-map,
5112 minibuffer-local-must-match-map, and
5113 minibuffer-local-filename-must-match-map to Elisp.
5114 (syms_of_keymap): Defsubr make-composed-keymap.
5115 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
5116 (parse_menu_item): Trivial simplification.
5118 2011-07-01 Glenn Morris <rgm@gnu.org>
5120 * Makefile.in (SETTINGS_LIBS): Fix typo.
5122 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
5124 * coding.c (Fencode_coding_string): Record the last coding system
5125 used, as the function doc string says (bug#8738).
5127 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
5129 * xsettings.c (store_monospaced_changed): Take new font as arg and
5130 check for change against current_mono_font.
5131 (EMACS_TYPE_SETTINGS): Remove this and related defines.
5132 (emacs_settings_constructor, emacs_settings_get_property)
5133 (emacs_settings_set_property, emacs_settings_class_init)
5134 (emacs_settings_init, gsettings_obj): Remove.
5135 (something_changedCB): New function for HAVE_GSETTINGS.
5136 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
5137 with value as argument.
5138 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
5139 g_settings_new (Bug#8967). Do not create gsettings_obj.
5140 Remove calls to g_settings_bind. Connect something_changedCB to
5143 * xgselect.c: Add defined (HAVE_GSETTINGS).
5144 (xgselect_initialize): Ditto.
5146 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
5147 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
5150 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
5152 * eval.c (struct backtrace): Simplify and port the data structure.
5153 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
5154 signed bit field, as this assumption is not portable and it makes
5155 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
5156 "char debug_on_exit : 1" as this is not portable either; instead,
5157 use the portable "unsigned int debug_on_exit : 1". Remove unused
5158 member evalargs. Remove obsolete comments about cc bombing out.
5160 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
5162 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
5163 Let HAVE_GSETTINGS override HAVE_GCONF.
5164 (store_monospaced_changed): New function.
5165 (EMACS_SETTINGS): A new type derived from GObject to handle
5166 GSettings notifications.
5167 (emacs_settings_constructor, emacs_settings_get_property)
5168 (emacs_settings_set_property, emacs_settings_class_init):
5170 (gsettings_client, gsettings_obj): New variables.
5171 (GSETTINGS_SCHEMA): New define.
5172 (something_changedCB): Call store_monospaced_changed.
5173 (init_gsettings): New function.
5174 (xsettings_initialize): Call init_gsettings.
5175 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
5178 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
5181 2011-06-29 Martin Rudalics <rudalics@gmx.at>
5183 * window.c (resize_root_window, grow_mini_window)
5184 (shrink_mini_window): Rename Qresize_root_window to
5185 Qwindow_resize_root_window and Qresize_root_window_vertically to
5186 Qwindow_resize_root_window_vertically.
5188 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
5190 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
5192 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
5194 * makefile.w32-in: Redesign dependencies so they reflect more
5195 clearly which files are directly included by each source file,
5196 and not through other includes.
5198 2011-06-27 Martin Rudalics <rudalics@gmx.at>
5200 * buffer.c (Qclone_number): Declare static and DEFSYM it.
5201 (sort_overlays, overlay_strings): When an overlay's clone number
5202 matches the window's clone number process the overlay even if
5203 the overlay's window property doesn't match the current window.
5205 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
5206 (Fwindow_hchild): Rename to Fwindow_left_child.
5207 (Fwindow_next): Rename to Fwindow_next_sibling.
5208 (Fwindow_prev): Rename to Fwindow_prev_sibling.
5209 (resize_window_check): Rename to window_resize_check.
5210 (resize_window_apply): Rename to window_resize_apply.
5211 (Fresize_window_apply): Rename to Fwindow_resize_apply.
5212 (Fdelete_other_windows_internal, resize_frame_windows)
5213 (Fsplit_window_internal, Fdelete_window_internal)
5214 (grow_mini_window, shrink_mini_window)
5215 (Fresize_mini_window_internal): Fix callers accordingly.
5217 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
5219 * emacsgtkfixed.h: State that this is only used with Gtk+3.
5220 (emacs_fixed_set_min_size): Remove.
5221 (emacs_fixed_new): Take frame as argument.
5223 * emacsgtkfixed.c: State that this is only used with Gtk+3.
5224 (_EmacsFixedPrivate): Remove minwidth/height.
5225 Add struct frame *f.
5226 (emacs_fixed_init): Initialize priv->f.
5227 (get_parent_class, emacs_fixed_set_min_size): Remove.
5228 (emacs_fixed_new): Set priv->f to argument.
5229 (emacs_fixed_get_preferred_width)
5230 (emacs_fixed_get_preferred_height): Use min_width/height from
5231 frames size_hint to set minimum and natural (Bug#8919).
5232 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
5233 and use min_width/height from frames size_hint to set
5234 min_width/height (Bug#8919).
5236 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
5237 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
5240 2011-06-26 Eli Zaretskii <eliz@gnu.org>
5242 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
5243 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
5246 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
5248 * process.c (wait_reading_process_output): Bypass select if
5249 waiting for a cell while ignoring keyboard input, and input is
5250 pending. Suggested by Jan Djärv (Bug#8869).
5252 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
5254 Use gnulib's dup2 module instead of rolling our own.
5255 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
5257 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5259 * dispnew.c (scrolling_window): Before scrolling, turn off a
5260 mouse-highlight in the window being scrolled.
5262 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
5264 Move DEFSYM to lisp.h and use everywhere.
5266 * character.h (DEFSYM): Move declaration...
5267 * lisp.h (DEFSYM): ...here.
5273 * w32select.c: Don't include character.h.
5275 * alloc.c (syms_of_alloc):
5276 * buffer.c (syms_of_buffer):
5277 * bytecode.c (syms_of_bytecode):
5278 * callint.c (syms_of_callint):
5279 * casefiddle.c (syms_of_casefiddle):
5280 * casetab.c (init_casetab_once):
5281 * category.c (init_category_once, syms_of_category):
5282 * ccl.c (syms_of_ccl):
5283 * cmds.c (syms_of_cmds):
5284 * composite.c (syms_of_composite):
5285 * dbusbind.c (syms_of_dbusbind):
5286 * dired.c (syms_of_dired):
5287 * dispnew.c (syms_of_display):
5288 * doc.c (syms_of_doc):
5289 * editfns.c (syms_of_editfns):
5290 * emacs.c (syms_of_emacs):
5291 * eval.c (syms_of_eval):
5292 * fileio.c (syms_of_fileio):
5293 * fns.c (syms_of_fns):
5294 * frame.c (syms_of_frame):
5295 * fringe.c (syms_of_fringe):
5296 * insdel.c (syms_of_insdel):
5297 * keymap.c (syms_of_keymap):
5298 * lread.c (init_obarray, syms_of_lread):
5299 * macros.c (syms_of_macros):
5300 * msdos.c (syms_of_msdos):
5301 * print.c (syms_of_print):
5302 * process.c (syms_of_process):
5303 * search.c (syms_of_search):
5304 * sound.c (syms_of_sound):
5305 * syntax.c (init_syntax_once, syms_of_syntax):
5306 * terminal.c (syms_of_terminal):
5307 * textprop.c (syms_of_textprop):
5308 * undo.c (syms_of_undo):
5309 * w32.c (globals_of_w32):
5310 * window.c (syms_of_window):
5311 * xdisp.c (syms_of_xdisp):
5312 * xfaces.c (syms_of_xfaces):
5313 * xfns.c (syms_of_xfns):
5314 * xmenu.c (syms_of_xmenu):
5315 * xsettings.c (syms_of_xsettings):
5316 * xterm.c (syms_of_xterm): Use DEFSYM.
5318 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5320 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
5322 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5324 Integer and buffer overflow fixes (Bug#8873).
5326 * print.c (printchar, strout): Check for string overflow.
5327 (PRINTPREPARE, printchar, strout):
5328 Don't set size unless allocation succeeds.
5330 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5331 for sizes. Check for string overflow more accurately.
5332 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5334 * macros.c: Integer and buffer overflow fixes.
5335 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5336 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5337 Use ptrdiff_t, not int, for sizes.
5338 Don't increment bufsize until after realloc succeeds.
5339 Check for size-calculation overflow.
5340 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5342 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5344 * lread.c: Integer overflow fixes.
5345 (read_integer): Radix is now EMACS_INT, not int,
5346 to improve quality of diagnostics for out-of-range radices.
5347 Calculate buffer size correctly for out-of-range radices.
5348 (read1): Check for integer overflow in radices, and in
5349 read-circle numbers.
5350 (read_escape): Avoid int overflow.
5351 (Fload, openp, read_buffer_size, read1)
5352 (substitute_object_recurse, read_vector, read_list, map_obarray):
5353 Use ptrdiff_t, not int, for sizes.
5354 (read1): Use EMACS_INT, not int, for sizes.
5355 Check for size overflow.
5357 * image.c (cache_image): Check for size arithmetic overflow.
5359 * lread.c: Integer overflow issues.
5360 (saved_doc_string_size, saved_doc_string_length)
5361 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5362 Now ptrdiff_t, not int.
5363 (read1): Don't assume doc string length fits in int. Check for
5364 out-of-range doc string lengths.
5365 (read_list): Don't assume file position fits in int.
5366 (read_escape): Check for hex character overflow.
5368 2011-06-22 Leo Liu <sdl.web@gmail.com>
5370 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5371 Move to minibuffer.el.
5373 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5375 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
5376 The following patches are for when GLYPH_DEBUG && !XASSERT.
5377 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5378 * dispnew.c (flush_stdout):
5379 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5380 Mark as externally visible.
5381 * dispnew.c (check_window_matrix_pointers): Now static.
5382 * dispnew.c (window_to_frame_vpos):
5383 * xfns.c (unwind_create_frame):
5384 * xterm.c (x_check_font): Remove unused local.
5385 * scroll.c (CHECK_BOUNDS):
5386 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5387 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5388 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5389 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5390 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5392 (debug_method_add): Use va_list and vsprintf rather than relying
5393 on undefined behavior with wrong number of arguments.
5394 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5395 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5396 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5397 since we're not interested in debugging glyphs with old libraries.
5398 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5399 GCC 4.6.0's static checking.
5401 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5403 Integer overflow and signedness fixes (Bug#8873).
5404 A few related buffer overrun fixes, too.
5406 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5408 * dispextern.h (struct face.stipple):
5409 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5410 (x_bitmap_mask, x_allocate_bitmap_record)
5411 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5412 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5413 (x_create_bitmap_from_xpm_data):
5414 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5415 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5417 * xfaces.c (load_pixmap):
5418 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5419 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5420 (.bitmaps_last, struct x_output.icon_bitmap):
5421 Use ptrdiff_t, not int, for bitmap indexes.
5422 (x_allocate_bitmap_record): Check for size overflow.
5423 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5425 Use ptrdiff_t, not int, for overlay counts.
5426 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5427 * editfns.c (overlays_around, get_pos_property):
5428 * textprop.c (get_char_property_and_overlay):
5429 * xdisp.c (next_overlay_change, note_mouse_highlight):
5430 * xfaces.c (face_at_buffer_position):
5431 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5432 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5433 (Fnext_overlay_change, Fprevious_overlay_change)
5434 (mouse_face_overlay_overlaps, Foverlays_in):
5435 Use ptrdiff_t, not int, for sizes.
5436 (overlays_at, overlays_in): Check for size-calculation overflow.
5438 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5440 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5441 (x_session_initialize): Do not assume string length fits in int.
5443 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5444 This is unlikely, but can occur if DPI is outlandish.
5446 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
5447 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5449 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5450 * xrdb.c (magic_file_p, search_magic_path):
5451 Omit last arg SUFFIX; it was always 0. All callers changed.
5452 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5454 * xfont.c (xfont_match): Avoid need for strlen.
5456 * xfns.c: Don't assume strlen fits in int.
5457 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5459 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5460 not unsigned long, as we prefer signed integers. All callers changed.
5461 Detect integer overflow in repeat count.
5462 (message_dolog): Don't assume print length fits in 39 bytes.
5463 (display_mode_element): Don't assume strlen fits in int.
5465 * termcap.c: Don't assume sizes fit in int and never overflow.
5466 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5467 (gobble_line): Check for size-calculation overflow.
5469 * minibuf.c (Fread_buffer):
5470 * lread.c (intern, intern_c_string):
5471 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5472 Don't assume string length fits in int.
5474 * keyboard.c (parse_tool_bar_item):
5475 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5477 * font.c: Don't assume string length fits in int.
5478 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5479 Use ptrdiff_t, not int.
5480 (font_intern_prop): Don't assume string length fits in int.
5481 Don't assume integer property fits in fixnum.
5482 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5484 * filelock.c: Fix some buffer overrun and integer overflow issues.
5485 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5486 Reformulate so as not to need the command string.
5487 Invoke gzip -cd rather than gunzip, as it's more portable.
5488 (lock_info_type, lock_file_1, lock_file):
5489 Don't assume pid_t and time_t fit in unsigned long.
5490 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5491 (current_lock_owner): Prefer signed type for sizes.
5492 Use memcpy, not strncpy, where memcpy is what is really wanted.
5493 Don't assume (via atoi) that time_t and pid_t fit in int.
5494 Check for time_t and/or pid_t out of range, e.g., via a network share.
5495 Don't alloca where an auto var works fine.
5497 * fileio.c: Fix some integer overflow issues.
5498 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5499 Don't assume string length fits in int.
5500 (directory_file_name): Don't assume string length fits in long.
5501 (make_temp_name): Don't assume pid fits in int, or that its print
5502 length is less than 20.
5504 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5506 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5508 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5510 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5511 We prefer signed integers, even for size calculations.
5513 * emacs.c: Don't assume string length fits in 'int'.
5514 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5515 (main): Don't invoke strlen when not needed.
5517 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5518 (XD_DEBUG_MESSAGE): Don't waste a byte.
5520 * callproc.c (getenv_internal_1, getenv_internal)
5522 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5524 * lread.c (invalid_syntax): Omit length argument.
5525 All uses changed. This doesn't fix a bug, but it simplifies the
5526 code away from its former Hollerith-constant appearance, and it's
5527 one less 'int' to worry about when looking at integer-overflow issues.
5528 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5530 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5531 This didn't break anything, but it didn't help either.
5532 It's confusing to put a bogus integer in a place where the actual
5533 value does not matter.
5534 (LIST_END_P): Remove unused macro and its bogus comment.
5535 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5537 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5538 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5540 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5541 We prefer signed types, and the value cannot exceed the EMACS_INT
5542 range anyway (because otherwise the length would not be representable).
5543 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5544 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5545 This avoids a GCC warning when WIDE_EMACS_INT.
5547 * indent.c (sane_tab_width): New function.
5548 (current_column, scan_for_column, Findent_to, position_indentation)
5549 (compute_motion): Use it. This is just for clarity.
5550 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5552 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5554 * lisp.h (lint_assume): New macro.
5555 * composite.c (composition_gstring_put_cache):
5556 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5558 * editfns.c, insdel.c:
5559 Omit unnecessary forward decls, to simplify future changes.
5561 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5563 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5565 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5566 Use much-faster test for byte-length change.
5567 Don't assume string byte-length fits in 'int'.
5568 Check that character arg fits in 'int'.
5569 (mapcar1): Declare byte as byte, for clarity.
5571 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5573 * fns.c (concat): Catch string overflow earlier.
5574 Do not rely on integer wraparound.
5576 * dispextern.h (struct it.overlay_strings_charpos)
5577 (struct it.selective): Now EMACS_INT, not int.
5578 * xdisp.c (forward_to_next_line_start)
5579 (back_to_previous_visible_line_start)
5580 (reseat_at_next_visible_line_start, next_element_from_buffer):
5581 Don't arbitrarily truncate the value of 'selective' to int.
5583 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5585 * composite.c: Don't truncate sizes to 'int'.
5586 (composition_gstring_p, composition_reseat_it)
5587 (composition_adjust_point): Use EMACS_INT, not int.
5588 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5589 not EMACS_UINT, for indexes.
5591 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5593 * buffer.c: Include <verify.h>.
5594 (struct sortvec.priority, struct sortstr.priority):
5595 Now EMACS_INT, not int.
5596 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5597 (struct sortstr.size, record_overlay_string)
5598 (struct sortstrlist.size, struct sortlist.used):
5599 Don't truncate size to int.
5600 (record_overlay_string): Check for size-calculation overflow.
5601 (init_buffer_once): Check at compile-time, not run-time.
5603 2011-06-22 Jim Meyering <meyering@redhat.com>
5605 Don't leak an XBM-image-sized buffer
5606 * image.c (xbm_load): Free the image buffer after using it.
5608 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5611 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5612 that Sun C diagnosed.
5613 * fns.c (secure_hash): Fix pointer signedness issue.
5614 * intervals.c (static_offset_intervals): New function.
5615 (offset_intervals): Use it.
5617 2011-06-21 Leo Liu <sdl.web@gmail.com>
5620 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5623 * fns.c (secure_hash): Rename from crypto_hash_function and change
5624 the first arg to accept symbols.
5625 (Fsecure_hash): New primitive.
5626 (syms_of_fns): New symbols.
5628 2011-06-20 Deniz Dogan <deniz@dogan.se>
5630 * process.c (Fset_process_buffer): Clarify return value in
5633 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5635 * dispnew.c (add_window_display_history): Use BVAR.
5637 * xdisp.c (debug_method_add): Use BVAR.
5638 (check_window_end, dump_glyph_matrix, dump_glyph)
5639 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5641 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5644 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5645 check till after the cache is created in init_frame_faces.
5647 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5649 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5651 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5653 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5654 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5655 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5657 Improve buffer-overflow checking (Bug#8873).
5658 * fileio.c (Finsert_file_contents):
5659 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5660 Remove the old (too-loose) buffer overflow checks.
5661 They weren't needed, since make_gap checks for buffer overflow.
5662 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5663 The old code merely checked for Emacs fixnum overflow, and relied
5664 on undefined (wraparound) behavior. The new code avoids undefined
5665 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5667 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5668 Tune. Don't use wider integers than needed. Don't use alloca.
5669 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5671 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5673 * insdel.c, lisp.h (buffer_overflow): New function.
5674 (insert_from_buffer_1, replace_range, replace_range_2):
5675 * insdel.c (make_gap_larger):
5676 * editfns.c (Finsert_char):
5677 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5679 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5681 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5683 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5685 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5686 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5688 * fileio.c: Don't assume EMACS_INT fits in off_t.
5689 (emacs_lseek): New static function.
5690 (Finsert_file_contents, Fwrite_region): Use it.
5691 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5693 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5695 * fns.c: Don't overflow int when computing a list length.
5696 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5697 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5698 truncation on 64-bit hosts. Check for QUIT every
5699 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5700 faster and is responsive enough.
5701 (Flength): Report an error instead of overflowing an integer.
5702 (Fsafe_length): Return a float if the value is not representable
5703 as a fixnum. This shouldn't happen except in contrived situations.
5704 (Fnthcdr, Fsort): Don't assume list length fits in int.
5705 (Fcopy_sequence): Don't assume vector length fits in int.
5707 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5708 (header_size, word_size): New constants.
5709 (allocate_vectorlike): Don't check size overflow here.
5710 (allocate_vector): Check it here instead, since this is the only
5711 caller of allocate_vectorlike that could cause overflow.
5712 Check that the new vector's length is representable as a fixnum.
5714 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5715 The previous code was bogus. For example, next_almost_prime (32)
5716 returned 39, which is undesirable as it is a multiple of 3; and
5717 next_almost_prime (24) returned 25, which is a multiple of 5 so
5718 why was the code bothering to check for multiples of 7?
5720 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5722 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5724 Variadic C functions now count arguments with ptrdiff_t.
5725 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5726 Back then I didn't know that the Emacs coding style prefers signed int.
5727 Also, in the meantime I found a few more instances where arguments
5728 were being counted with int, which may truncate counts on 64-bit
5729 machines, or EMACS_INT, which may be unnecessarily wide.
5730 * lisp.h (struct Lisp_Subr.function.aMANY)
5731 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5732 Arg counts are now ptrdiff_t, not size_t.
5733 All variadic functions and their callers changed accordingly.
5734 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5735 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5736 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5737 * callint.c (Fcall_interactively): Check arg count for overflow,
5738 to avoid potential buffer overrun. Use signed char, not 'int',
5739 for 'varies' array, so that we needn't bother to check its size
5740 calculation for overflow.
5741 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5742 * eval.c (apply_lambda):
5743 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5744 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5745 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5747 * callint.c (Fcall_interactively): Don't use index var as event count.
5749 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5750 * mem-limits.h (SIZE): Remove; no longer used.
5752 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5754 Remove unnecessary casts.
5755 * xterm.c (x_term_init):
5756 * xfns.c (x_set_border_pixel):
5757 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5758 These aren't needed now that we assume ANSI C.
5760 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5761 It's more likely to cause problems (due to unsigned overflow)
5764 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5766 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5768 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5770 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5772 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5774 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5776 GLYPH_CODE_FACE returns EMACS_INT, not int.
5777 * dispextern.h (merge_faces):
5778 * xfaces.c (merge_faces):
5779 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5780 Don't assume EMACS_INT fits in int.
5782 * character.h (CHAR_VALID_P): Remove unused parameter.
5783 * fontset.c, lisp.h, xdisp.c: All uses changed.
5785 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5787 * fns.c (concat): Minor tuning based on overflow analysis.
5788 This doesn't fix any bugs. Use int to hold character, instead
5789 of constantly refetching from Emacs object. Use XFASTINT, not
5790 XINT, for value known to be a character. Don't bother comparing
5791 a single byte to 0400, as it's always less.
5793 * floatfns.c (Fexpt):
5794 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5796 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5799 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5801 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5802 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5803 incorrectly succeed when S was a string, because 4294967386 was
5804 truncated before it was used.
5806 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5807 Otherwise, an out-of-range integer could cause undefined behavior
5810 * composite.c: Use int, not EMACS_INT, for characters.
5811 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5812 EMACS_INT, for values that are known to be in character range.
5813 This doesn't fix any bugs but is the usual style inside Emacs and
5814 may generate better code on 32-bit machines.
5816 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5817 This is for reasons similar to the recent CHAR_STRING fix.
5818 * charset.c (Fencode_char): Check that character arg is actually
5819 a character. Pass an int to ENCODE_CHAR.
5820 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5821 wider than 'int', as a compile-time check to prevent future regressions
5824 * character.c (char_string): Remove unnecessary casts.
5826 Make sure a 64-bit char is never passed to CHAR_STRING.
5827 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5828 by silently ignoring the top 32 bits, allowing some values
5829 that were far too large to be valid characters.
5830 * character.h: Include <verify.h>.
5831 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5832 arguments are no wider than unsigned, as a compile-time check
5833 to prevent future regressions in this area.
5835 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5836 (Fsubst_char_in_region):
5838 * xdisp.c (decode_mode_spec_coding):
5839 Adjust to CHAR_STRING's new requirement.
5840 * editfns.c (Finsert_char, Fsubst_char_in_region):
5841 * fns.c (concat): Check that character args are actually
5842 characters. Without this test, these functions did the wrong
5843 thing with wildly out-of-range values on 64-bit hosts.
5845 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5846 These casts should not be needed on 32-bit hosts, either.
5847 * keyboard.c (read_char):
5848 * lread.c (Fload): Remove casts to unsigned.
5850 * lisp.h (UNSIGNED_CMP): New macro.
5851 This fixes comparison bugs on 64-bit hosts.
5852 (ASCII_CHAR_P): Use it.
5853 * casefiddle.c (casify_object):
5854 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5855 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5856 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5857 * dispextern.h (FACE_FROM_ID):
5858 * keyboard.c (read_char): Use UNSIGNED_CMP.
5860 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5861 not to EMACS_INT, to avoid GCC warning.
5863 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5865 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5866 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5867 isn't needed on 32-bit machines.
5869 * buffer.c (Fgenerate_new_buffer_name):
5870 Use EMACS_INT for count, not int.
5871 (advance_to_char_boundary): Return EMACS_INT, not int.
5873 * data.c (Qcompiled_function): Now static.
5875 * window.c (window_body_lines): Now static.
5877 * image.c (gif_load): Rename local to avoid shadowing.
5879 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5880 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5881 * alloc.c (make_save_value): Integer argument is now of type
5883 (mark_object): Use ptrdiff_t, not int.
5884 * lisp.h (pD): New macro.
5885 * print.c (print_object): Use it.
5887 * alloc.c: Use EMACS_INT, not int, to count objects.
5888 (total_conses, total_markers, total_symbols, total_vector_size)
5889 (total_free_conses, total_free_markers, total_free_symbols)
5890 (total_free_floats, total_floats, total_free_intervals)
5891 (total_intervals, total_strings, total_free_strings):
5892 Now EMACS_INT, not int. All uses changed.
5893 (Fgarbage_collect): Compute overall total using a double, so that
5894 integer overflow is less likely to be a problem. Check for overflow
5895 when converting back to an integer.
5896 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5897 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5898 These were 'int' variables that could overflow on 64-bit hosts;
5899 they were never used, so remove them instead of repairing them.
5900 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5901 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5902 Previously, this ceilinged at INT_MAX, but that doesn't work on
5904 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5906 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5907 (allocate_vectorlike): Check for ptrdiff_t overflow.
5908 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5909 when a (possibly-narrower) signed value would do just as well.
5910 We prefer using signed arithmetic, to avoid comparison confusion.
5912 * alloc.c: Catch some string size overflows that we were missing.
5913 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5914 for convenience in STRING_BYTES_MAX.
5915 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5916 The definition here is exact; the one in lisp.h was approximate.
5917 (allocate_string_data): Check for string overflow. This catches
5918 some instances we weren't catching before. Also, it catches
5919 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5920 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5921 and ptrdiff_t and EMACS_INT are both 64 bits.
5923 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5924 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5925 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5927 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5929 * alloc.c (Fmake_string): Check for out-of-range init.
5931 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5933 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5935 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5937 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5938 xg_get_default_scrollbar_width.
5940 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5941 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5942 (style_changed_cb): Call update_theme_scrollbar_width and call
5943 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5944 all frames (Bug#8505).
5945 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5946 Call gtk_window_set_resizable if HAVE_GTK3.
5947 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5948 and height if HAVE_GTK3 (Bug#8505).
5949 (scroll_bar_width_for_theme): New variable.
5950 (update_theme_scrollbar_width): New function.
5951 (xg_get_default_scrollbar_width): Move code to
5952 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5953 (xg_initialize): Call update_theme_scrollbar_width.
5955 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5957 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5959 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5961 * frame.c (make_frame): Call other_buffer_safely instead of
5964 * window.c (temp_output_buffer_show): Call display_buffer with
5965 second argument Vtemp_buffer_show_specifiers and reset latter
5966 immediately after the call.
5967 (Vtemp_buffer_show_specifiers): New variable.
5968 (auto_window_vscroll_p, next_screen_context_lines)
5969 (Vscroll_preserve_screen_position): Remove leading asterisks from
5972 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5974 Fix minor problems found by GCC 4.6.0 static checking.
5975 * buffer.c (Qclone_number): Remove for now, as it's unused.
5976 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5977 (record_buffer): Remove unused local.
5978 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5979 (set_frame_buffer_list): Remove; unused.
5980 * frame.h (other_visible_frames): Remove decl.
5981 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5982 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5983 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5985 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5986 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5987 Define only if HAVE_GPM.
5988 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5989 (update_hints_inhibit): Remove; never set. All uses removed.
5990 * widgetprv.h (emacsFrameClassRec): Remove decl.
5991 * window.c (delete_deletable_window): Now returns void, since it
5992 wasn't returning anything.
5993 (compare_window_configurations): Remove unused locals.
5994 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5995 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5996 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5997 the same widths as pointers. This follows up on the 2011-05-06 patch.
5998 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5999 * xterm.h: Likewise.
6000 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
6002 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
6004 * makefile.w32-in: Update dependencies.
6005 (LISP_H): Add lib/intprops.h.
6007 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
6009 * image.c (gif_load): Add animation frame delay to the metadata.
6010 (syms_of_image): Use DEFSYM. New symbol `delay'.
6012 2011-06-11 Martin Rudalics <rudalics@gmx.at>
6014 * window.c (delete_deletable_window): Re-add.
6015 (Fset_window_configuration): Rewrite to handle dead buffers and
6016 consequently deletable windows.
6017 (window_tree, Fwindow_tree): Remove. Supply functionality in
6019 (compare_window_configurations): Simplify code.
6021 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
6023 * image.c (imagemagick_load_image): Fix type mismatch.
6024 (Fimagemagick_types): Likewise.
6026 * window.h (replace_buffer_in_windows): Declare.
6028 2011-06-11 Martin Rudalics <rudalics@gmx.at>
6030 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
6031 Qclone_number. Remove external declaration of Qdelete_window.
6032 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
6034 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
6035 Run Qbuffer_list_update_hook if allowed.
6036 (Fother_buffer): Rewrite doc-string. Major rewrite for new
6037 buffer list implementation.
6038 (other_buffer_safely): New function.
6039 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
6040 calls to replace_buffer_in_windows and
6041 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
6043 (record_buffer): Inhibit quitting and rewrite using quittable
6044 functions. Run Qbuffer_list_update_hook if allowed.
6045 (Frecord_buffer, Funrecord_buffer): New functions.
6046 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
6047 Move switch-to-buffer to window.el.
6048 (bury-buffer): Move to window.el.
6049 (Vbuffer_list_update_hook): New variable.
6051 * lisp.h (other_buffer_safely): Add prototype in buffer.c
6054 * window.h (resize_frame_windows): Move up in code.
6055 (Fwindow_frame): Remove EXFUN.
6056 (replace_buffer_in_all_windows): Remove prototype.
6057 (replace_buffer_in_windows_safely): Add prototype.
6059 * window.c: Declare Qdelete_window static again. Move down
6060 declaration of select_count.
6061 (Fnext_window, Fprevious_window): Rewrite doc-strings.
6062 (Fother_window): Move to window.el.
6063 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
6064 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
6065 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
6067 (replace_buffer_in_windows): Implement by calling
6068 Qreplace_buffer_in_windows.
6069 (replace_buffer_in_all_windows): Remove with some functionality
6070 moved into replace_buffer_in_windows_safely.
6071 (replace_buffer_in_windows_safely): New function.
6072 (select_window_norecord, select_frame_norecord): Move in front
6073 of run_window_configuration_change_hook. Remove now obsolete
6075 (Fset_window_buffer): Rewrite doc-string.
6076 Call Qrecord_window_buffer.
6077 (keys_of_window): Move binding for other-window to window.el.
6079 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
6081 * dispextern.h (struct image): Replace data member, whose int_val
6082 and ptr_val fields were not used by anything, with a single
6085 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
6086 (gif_clear_image, gif_load, imagemagick_load_image)
6087 (gs_clear_image, gs_load): Callers changed.
6089 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
6091 * buffer.h: Include <time.h>, for time_t.
6092 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
6094 Fix minor problems found by static checking.
6096 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
6098 Make identifiers static if they are not used in other modules.
6099 * data.c (Qcompiled_function, Qframe, Qvector):
6100 * image.c (QimageMagick, Qsvg):
6101 * minibuf.c (Qmetadata):
6102 * window.c (resize_window_check, resize_root_window): Now static.
6103 * window.h (resize_window_check, resize_root_window): Remove decls.
6105 * window.c (window_deletion_count, delete_deletable_window):
6107 (window_body_lines): Now static.
6108 (Fdelete_other_windows_internal): Mark vars as initialized.
6109 Make sure 'resize_failed' is initialized.
6110 (run_window_configuration_change_hook): Rename local to avoid shadowing.
6111 (resize_window_apply): Remove unused local.
6112 * window.h (delete_deletable_window): Remove decl.
6114 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
6115 (imagemagick_load_image): Fix pointer signedness problem by changing
6116 last arg from unsigned char * to char *. All uses changed.
6117 Also, fix a local for similar reasons.
6118 Remove unused locals. Remove locals to avoid shadowing.
6119 (fn_rsvg_handle_free): Remove; unused.
6120 (svg_load, svg_load_image): Fix pointer signedness problem.
6121 (imagemagick_load_image): Don't use garbage pointer image_wand.
6123 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
6125 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
6127 * image.c (gif_load): Fix omitted cast error introduced by
6130 2011-06-10 Martin Rudalics <rudalics@gmx.at>
6132 * window.h (resize_proportionally, orig_total_lines)
6133 (orig_top_line): Remove from window structure.
6134 (set_window_height, set_window_width, change_window_heights)
6135 (Fdelete_window): Remove prototypes.
6136 (resize_frame_windows): Remove duplicate declaration.
6138 2011-06-10 Eli Zaretskii <eliz@gnu.org>
6140 * window.h (resize_frame_windows, resize_window_check)
6141 (delete_deletable_window, resize_root_window)
6142 (resize_frame_windows): Declare prototypes.
6144 * window.c (resize_window_apply): Make definition be "static" to
6145 match the prototype.
6147 2011-06-10 Martin Rudalics <rudalics@gmx.at>
6149 * window.c: Remove declarations of Qwindow_size_fixed,
6150 window_min_size_1, window_min_size_2, window_min_size,
6151 size_window, window_fixed_size_p, enlarge_window, delete_window.
6152 Remove static from declaration of Qdelete_window, it's
6153 temporarily needed by Fbury_buffer.
6154 (replace_window): Don't assign orig_top_line and
6156 (Fdelete_window, delete_window): Remove. Window deletion is
6157 handled by window.el.
6158 (window_loop): Remove DELETE_OTHER_WINDOWS case.
6159 Replace Fdelete_window calls with calls to Qdelete_window.
6160 (Fdelete_other_windows): Remove. Deleting other windows is
6161 handled by window.el.
6162 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
6163 handled in window.el.
6164 (window_min_size_2, window_min_size_1, window_min_size): Remove.
6165 Window minimum sizes are handled in window.el.
6166 (shrink_windows, size_window, set_window_height)
6167 (set_window_width, change_window_heights, window_height)
6168 (window_width, CURBEG, CURSIZE, enlarge_window)
6169 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
6170 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
6171 handled in window.el.
6172 (make_dummy_parent): Rename to make_parent_window and give it a
6173 second argument horflag.
6174 (make_window): Don't set resize_proportionally any more.
6175 (Fsplit_window): Remove. Windows are split in window.el.
6176 (save_restore_action, save_restore_orig_size)
6177 (shrink_window_lowest_first, save_restore_orig_size): Remove.
6178 Resize mini windows in window.el.
6179 (grow_mini_window, shrink_mini_window): Implement by calling
6180 Qresize_root_window_vertically, resize_window_check and
6181 resize_window_apply.
6182 (saved_window, Fset_window_configuration, save_window_save):
6183 Do not handle orig_top_line, orig_total_lines, and
6184 resize_proportionally.
6185 (window_min_height, window_min_width): Move to window.el.
6186 (keys_of_window): Move bindings for delete-other-windows,
6187 split-window, delete-window and enlarge-window to window.el.
6189 * buffer.c: Temporarily extern Qdelete_window.
6190 (Fbury_buffer): Temporarily call Qdelete_window instead of
6191 Fdelete_window (Fbury_buffer will move to window.el soon).
6193 * frame.c (set_menu_bar_lines_1): Remove code handling
6194 orig_top_line and orig_total_lines.
6196 * dispnew.c (adjust_frame_glyphs_initially): Don't use
6197 set_window_height but set heights directly.
6198 (change_frame_size_1): Use resize_frame_windows.
6200 * xdisp.c (init_xdisp): Don't use set_window_height but set
6203 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
6204 Use resize_frame_windows instead of change_window_heights and run
6205 run_window_configuration_change_hook.
6207 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
6208 instead of change_window_heights and run
6209 run_window_configuration_change_hook.
6211 2011-06-09 Martin Rudalics <rudalics@gmx.at>
6213 * window.c (replace_window): Rename second argument REPLACEMENT to
6214 NEW. New third argument SETFLAG. Rewrite.
6215 (delete_window, make_dummy_parent): Call replace_window with
6217 (window_list_1): Move down in code.
6218 (run_window_configuration_change_hook): Move set_buffer part
6219 before select_frame_norecord part in order to unwind correctly.
6220 Rename count1 to count.
6221 (recombine_windows, delete_deletable_window, resize_root_window)
6222 (Fdelete_other_windows_internal)
6223 (Frun_window_configuration_change_hook, make_parent_window)
6224 (resize_window_check, resize_window_apply, Fresize_window_apply)
6225 (resize_frame_windows, Fsplit_window_internal)
6226 (Fdelete_window_internal, Fresize_mini_window_internal):
6228 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
6230 2011-06-08 Martin Rudalics <rudalics@gmx.at>
6232 * window.h (window): Add some new members to window structure -
6233 normal_lines, normal_cols, new_total, new_normal, clone_number,
6234 splits, nest, prev_buffers, next_buffers.
6235 (WINDOW_TOTAL_SIZE): Move here from window.c.
6236 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
6238 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
6240 (make_dummy_parent): Set new members of windows structure.
6241 (make_window): Move down in code. Handle new members of window
6243 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
6244 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
6245 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
6246 (Fset_window_prev_buffers, Fwindow_next_buffers)
6247 (Fset_window_next_buffers, Fset_window_clone_number):
6249 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
6250 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
6252 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
6253 Argument WINDOW can be now internal window too.
6254 (Fwindow_use_time): Move up in code.
6255 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
6257 (Fset_window_configuration, saved_window)
6258 (Fcurrent_window_configuration, save_window_save): Handle new
6259 members of window structure.
6260 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
6261 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
6262 (syms_of_window): New Lisp objects Qrecord_window_buffer,
6263 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
6264 Qget_mru_window, Qresize_root_window,
6265 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
6266 Qauto_buffer_name; staticpro them.
6268 2011-06-07 Martin Rudalics <rudalics@gmx.at>
6270 * window.c (Fwindow_total_size, Fwindow_left_column)
6271 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
6272 (Fwindow_list_1): New functions.
6273 (window_box_text_cols): Replace with window_body_cols.
6274 (Fwindow_width, Fscroll_left, Fscroll_right):
6275 Use window_body_cols instead of window_box_text_cols.
6276 (delete_window, Fset_window_configuration):
6277 Call delete_all_subwindows with window as argument.
6278 (delete_all_subwindows): Take a window as argument and not a
6280 (window_loop): Remove handling of GET_LRU_WINDOW and
6282 (Fget_lru_window, Fget_largest_window): Move to window.el.
6284 * window.h: Extern window_body_cols instead of
6285 window_box_text_cols. delete_all_subwindows now takes a
6286 Lisp_Object as argument.
6288 * indent.c (compute_motion, Fcompute_motion):
6289 Use window_body_cols instead of window_box_text_cols.
6291 * frame.c (delete_frame): Call delete_all_subwindows with root
6294 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
6296 * fns.c (Fputhash): Document return value.
6298 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
6300 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6302 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6304 Cons<->int and similar integer overflow fixes (Bug#8794).
6306 Check for overflow when converting integer to cons and back.
6307 * charset.c (Fdefine_charset_internal, Fdecode_char):
6308 Use cons_to_unsigned to catch overflow.
6309 (Fencode_char): Use INTEGER_TO_CONS.
6310 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6311 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6312 * data.c (long_to_cons, cons_to_long): Remove.
6313 (cons_to_unsigned, cons_to_signed): New functions.
6314 These signal an error for invalid or out-of-range values.
6315 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6316 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6317 * font.c (Ffont_variation_glyphs):
6318 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6319 * lisp.h: Include <intprops.h>.
6320 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6321 (cons_to_signed, cons_to_unsigned): New decls.
6322 (long_to_cons, cons_to_long): Remove decls.
6323 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6324 (Fprimitive_undo): Use CONS_TO_INTEGER.
6325 * xfns.c (Fx_window_property): Likewise.
6326 * xselect.c: Include <limits.h>.
6327 (x_own_selection, selection_data_to_lisp_data):
6328 Use INTEGER_TO_CONS.
6329 (x_handle_selection_request, x_handle_selection_clear)
6330 (x_get_foreign_selection, Fx_disown_selection_internal)
6331 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6332 (lisp_data_to_selection_data): Use cons_to_unsigned.
6333 (x_fill_property_data): Use cons_to_signed.
6334 Report values out of range.
6336 Check for buffer and string overflow more precisely.
6337 * buffer.h (BUF_BYTES_MAX): New macro.
6338 * lisp.h (STRING_BYTES_MAX): New macro.
6339 * alloc.c (Fmake_string):
6340 * character.c (string_escape_byte8):
6341 * coding.c (coding_alloc_by_realloc):
6342 * doprnt.c (doprnt):
6343 * editfns.c (Fformat):
6345 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6346 since they may not be the same number.
6347 * editfns.c (Finsert_char):
6348 * fileio.c (Finsert_file_contents):
6349 Likewise for BUF_BYTES_MAX.
6351 * image.c: Use ptrdiff_t, not int, for sizes.
6352 (slurp_file): Switch from int to ptrdiff_t.
6354 (slurp_file): Check that file size fits in both size_t (for
6355 malloc) and ptrdiff_t (for sanity and safety).
6357 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6358 if b->modtime has its maximal value.
6360 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6362 Don't assume time_t can fit into int.
6363 * buffer.h (struct buffer.modtime): Now time_t, not int.
6364 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6365 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6367 Minor fixes for signed vs unsigned integers.
6368 * character.h (MAYBE_UNIFY_CHAR):
6369 * charset.c (maybe_unify_char):
6370 * keyboard.c (read_char, reorder_modifiers):
6371 XINT -> XFASTINT, since the integer must be nonnegative.
6372 * ftfont.c (ftfont_spec_pattern):
6373 * keymap.c (access_keymap, silly_event_symbol_error):
6374 XUINT -> XFASTINT, since the integer must be nonnegative.
6375 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6376 since it makes no difference and we prefer signed.
6377 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6378 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6381 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6383 * window.h (Fwindow_frame): Declare.
6385 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6387 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6388 (SPARE_MEMORY): Always define.
6389 (LARGE_REQUEST): Remove.
6390 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6392 2011-06-06 Martin Rudalics <rudalics@gmx.at>
6394 * lisp.h: Move EXFUNS for Fframe_root_window,
6395 Fframe_first_window and Fset_frame_selected_window to window.h.
6397 * window.h: Move EXFUNS for Fframe_root_window,
6398 Fframe_first_window and Fset_frame_selected_window here from
6401 * frame.c (Fwindow_frame, Fframe_first_window)
6402 (Fframe_root_window, Fframe_selected_window)
6403 (Fset_frame_selected_window): Move to window.c.
6404 (Factive_minibuffer_window): Move to minibuf.c.
6405 (Fother_visible_frames_p): New function.
6407 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6409 * window.c (decode_window, decode_any_window): Move up in code.
6410 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6411 (inhibit_frame_unsplittable): Remove unused variable.
6412 (Fwindow_buffer): Move up and rewrite doc-string.
6413 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6414 (Fwindow_prev): New functions.
6415 (Fwindow_frame): Move here from frame.c. Accept any window as
6417 (Fframe_root_window, Fframe_first_window)
6418 (Fframe_selected_window): Move here from frame.c. Accept frame
6419 or arbitrary window as argument. Update doc-strings.
6420 (Fminibuffer_window): Move up in code.
6421 (Fwindow_minibuffer_p): Move up in code and simplify.
6422 (Fset_frame_selected_window): Move here from frame.c.
6424 (Fselected_window, select_window, Fselect_window): Move up in
6425 code. Minor doc-string fixes.
6427 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6429 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6430 Do not assume that spare memory exists; that assumption is valid
6431 only if SYSTEM_MALLOC.
6432 (LARGE_REQUEST): New macro, so that the issue of large requests
6433 is separated from the issue of spare memory.
6435 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6437 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6440 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6442 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6445 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6447 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6449 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6451 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6452 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6454 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
6456 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6458 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
6460 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6461 (x_clipboard_manager_save): Add return value.
6462 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6464 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6465 Obey Vx_select_enable_clipboard_manager. Catch errors in
6466 x_clipboard_manager_save (Bug#8779).
6467 (Vx_select_enable_clipboard_manager): New variable.
6468 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6470 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6472 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6474 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6476 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6477 in the current matrix if keep_current_p is non-zero.
6479 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6481 * bidi.c (bidi_level_of_next_char): Fix last change.
6483 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6485 Support bidi reordering of text covered by display properties.
6487 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6488 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6489 (bidi_cache_search, bidi_cache_iterator_state)
6490 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6491 (bidi_level_of_next_char, bidi_move_to_visually_next):
6492 Support character positions inside a run of characters covered by a
6494 (bidi_paragraph_init, bidi_resolve_explicit_1)
6495 (bidi_level_of_next_char): Call bidi_fetch_char and
6496 bidi_fetch_char_advance instead of FETCH_CHAR and
6498 (bidi_init_it): Initialize new members.
6499 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6501 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6502 instead of using explicit *_CHAR codes.
6503 (bidi_resolve_explicit, bidi_resolve_weak):
6504 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6505 bidirectional text is supported only in multibyte buffers.
6506 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6507 it to initialize the frame_window_p member of struct bidi_it.
6508 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6509 (bidi_resolve_explicit, bidi_resolve_weak)
6510 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6511 bidi_it->nchars is non-positive.
6512 (bidi_level_of_next_char): Don't try to lookup the cache for the
6513 next/previous character if nothing is cached there yet, or if we
6514 were just reseat()'ed to a new position.
6516 * xdisp.c (set_cursor_from_row): Set start and stop points
6517 according to the row's direction when priming the loop that looks
6518 for the glyph on which to display cursor.
6519 (single_display_spec_intangible_p): Function deleted.
6520 (display_prop_intangible_p): Reimplement to call
6521 handle_display_spec instead of single_display_spec_intangible_p.
6522 Accept 3 additional arguments needed by handle_display_spec.
6523 This fixes incorrect cursor motion across display property with complex
6524 values: lists, `(when COND...)' forms, etc.
6525 (single_display_spec_string_p): Support property values that are
6526 lists with the argument STRING its top-level element.
6527 (display_prop_string_p): Fix the condition for processing a
6528 property that is a list to be consistent with handle_display_spec.
6529 (handle_display_spec): New function, refactored from the
6530 last portion of handle_display_prop.
6531 (compute_display_string_pos): Accept additional argument
6532 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6533 value of a `display' property is a "replacing spec".
6534 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6535 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6536 the display property, but just return a value indicating whether
6537 the display property will replace the characters it covers.
6538 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6539 frame_window_p members of struct bidi_it.
6540 (compute_display_string_pos, compute_display_string_end):
6542 (push_it): Accept second argument POSITION, where pop_it should
6543 jump to continue iteration.
6544 (reseat_1): Initialize bidi_it.disp_pos.
6546 * keyboard.c (adjust_point_for_property): Adjust the call to
6547 display_prop_intangible_p to its new signature.
6549 * dispextern.h (struct bidi_it): New member frame_window_p.
6550 (bidi_init_it): Update prototypes.
6551 (display_prop_intangible_p): Update prototype.
6552 (compute_display_string_pos, compute_display_string_end):
6554 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6557 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6559 Malloc failure behavior now depends on size of allocation.
6560 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6561 * lisp.h: Change signatures accordingly.
6562 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6563 All callers changed. (Bug#8762)
6565 * gnutls.c: Use Emacs's memory allocators.
6566 Without this change, the gnutls library would invoke malloc etc.
6567 directly, which causes problems on non-SYNC_INPUT hosts, and which
6568 runs afoul of improving memory_full behavior. (Bug#8761)
6569 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6570 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6571 xfree instead of the default malloc, realloc, free.
6572 (Fgnutls_boot): No need to check for memory allocation failure,
6573 since xmalloc does that for us.
6575 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6576 * category.c (hash_get_category_set):
6577 * ccl.c (ccl_driver):
6578 * charset.c (Fdefine_charset_internal):
6579 * charset.h (struct charset.hash_index):
6580 * composite.c (get_composition_id, gstring_lookup_cache)
6581 (composition_gstring_put_cache):
6582 * composite.h (struct composition.hash_index):
6583 * dispextern.h (struct image.hash):
6584 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6585 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6586 (hashfn_equal, hashfn_user_defined, make_hash_table)
6587 (maybe_resize_hash_table, hash_lookup, hash_put)
6588 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6589 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6590 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6591 * image.c (make_image, search_image_cache, lookup_image)
6592 (xpm_put_color_table_h):
6593 * lisp.h (struct Lisp_Hash_Table):
6594 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6595 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6596 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6597 * alloc.c (allocate_vectorlike):
6598 Check for overflow in vector size calculations.
6599 * ccl.c (ccl_driver):
6600 Check for overflow when converting EMACS_INT to int.
6601 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6602 need to be updated by these changes.
6603 * fns.c (make_hash_table, maybe_resize_hash_table):
6604 Check for integer overflow with large hash tables.
6605 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6606 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6607 (SXHASH_REDUCE): New macro.
6608 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6609 Use it instead of discarding useful hash info with large hash values.
6610 (sxhash_float): New function.
6611 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6612 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6613 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6614 Rewrite to use FIXNUM_BITS, as this simplifies things.
6615 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6616 Adjust signatures to match updated version of code.
6617 (consing_since_gc): Now EMACS_INT, since a single hash table can
6618 use more than INT_MAX bytes.
6620 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6622 Make it possible to build with GCC-4.6+ -O2 -flto.
6624 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6626 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6628 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6629 Call minibuffer-inactive-mode.
6631 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6633 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6634 Update dependencies.
6636 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6638 * data.c (init_data): Remove code for UTS, this system is not
6641 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6643 Don't force ./temacs to start in terminal mode.
6645 * frame.c (make_initial_frame): Initialize faces in all cases, not
6646 only when CANNOT_DUMP is defined.
6647 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6649 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6651 * dispnew.c (add_window_display_history): Use const for the string
6652 pointer. Remove declaration, not needed.
6654 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6656 Use 'inline', not 'INLINE'.
6657 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6658 * alloc.c, fontset.c (INLINE): Remove.
6659 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6660 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6661 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6662 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6663 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6665 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6667 Make it possible to run ./temacs.
6669 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6670 syms_of_callproc does the same thing. Remove test for
6671 "initialized", do it in the caller.
6672 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6674 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6676 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6677 (read_minibuf): Use get_minibuffer.
6678 (syms_of_minibuf): Use DEFSYM.
6679 (Qmetadata): New var.
6680 * data.c (Qbuffer): Don't make it static.
6681 (syms_of_data): Use DEFSYM.
6683 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6685 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6686 (CCL_CODE_MIN): New macro.
6688 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6690 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6692 * eval.c (Qdebug): Now static.
6693 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6694 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6695 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6697 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6699 * image.c: Various fixes to ImageMagick code comments.
6700 (Fimagemagick_types): Doc fix.
6702 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6704 Minor fixes prompted by GCC 4.6.0 warnings.
6706 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6708 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6709 (x_clipboard_manager_save_all): Move extern decl to ...
6710 * xterm.h: ... here, so that it can be checked for consistency.
6712 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6714 * xselect.c (x_clipboard_manager_save_frame)
6715 (x_clipboard_manager_save_all): New functions.
6716 (Fx_clipboard_manager_save): Lisp function deleted.
6718 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6719 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6721 * xterm.h: Update prototype.
6723 2011-05-28 William Xu <william.xwl@gmail.com>
6725 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6728 2011-05-28 Jim Meyering <meyering@redhat.com>
6730 Avoid a sign-extension bug in crypto_hash_function.
6731 * fns.c (to_uchar): Define.
6732 (crypto_hash_function): Use it to convert some newly-signed
6733 variables to unsigned, to avoid sign-extension bugs. For example,
6734 without this change, (md5 "truc") would evaluate to
6735 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6736 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6737 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6739 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6741 Integer overflow fixes.
6743 * dbusbind.c: Serial number integer overflow fixes.
6744 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6745 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6746 to hold a serial number that is too large for a fixnum.
6747 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6748 Check for serial numbers out of range. Decode any serial number
6749 that was so large that it became a float. (Bug#8722)
6751 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6752 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6753 Use XFASTINT rather than XUINT when numbers are nonnegative.
6754 (xd_append_arg, Fdbus_method_return_internal):
6755 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6756 arguments, check that Lisp number is nonnegative, rather than
6757 silently wrapping negative numbers around. (Bug#8722)
6758 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6761 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6763 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6765 ccl: Add integer overflow checks.
6766 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6767 (IN_INT_RANGE): New macros.
6768 (ccl_driver): Use them to check for integer overflow when
6769 decoding a CCL program. Many of the new checks are whether XINT (x)
6770 fits in int; it doesn't always, on 64-bit hosts. The new version
6771 doesn't catch all possible integer overflows, but it's an
6772 improvement. (Bug#8719)
6774 * alloc.c (make_event_array): Use XINT, not XUINT.
6775 There's no need for unsigned here.
6777 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6778 This follows up to the 2011-05-06 change that substituted uintptr_t
6779 for EMACS_INT. This case wasn't caught back then.
6781 Rework Fformat to avoid integer overflow issues.
6782 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6783 now (part of C89). Include <verify.h>.
6784 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6785 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6786 (Fformat): Avoid the prepass trying to compute sizes; it was only
6787 approximate and thus did not catch overflow reliably. Instead, walk
6788 through the format just once, formatting and computing sizes as we go,
6789 checking for integer overflow at every step, and allocating a larger
6790 buffer as needed. Keep track separately whether the format is
6791 multibyte. Keep only the most-recently calculated precision, rather
6792 than them all. Record whether each argument has been converted to
6793 string. Use EMACS_INT, not int, for byte and char and arg counts.
6794 Support field widths and precisions larger than INT_MAX. Avoid
6795 sprintf's undefined behavior with conversion specifications such as %#d
6796 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6797 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6798 formatting out-of-range floating point numbers with int
6801 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6803 * data.c: Avoid integer truncation in expressions involving floats.
6804 * data.c: Include <intprops.h>.
6805 (arith_driver): When there's an integer overflow in an expression
6806 involving floating point, convert the integers to floating point
6807 so that the resulting value does not suffer from catastrophic
6808 integer truncation. For example, on a 64-bit host (* 4
6809 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6810 Do not rely on undefined behavior after integer overflow.
6812 merge count_size_as_multibyte, parse_str_to_multibyte
6813 * character.c, character.h (count_size_as_multibyte):
6814 Rename from parse_str_to_multibyte; all uses changed.
6815 Check for integer overflow.
6816 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6817 since it's now a duplicate of the other. This is more of
6818 a character than a buffer op, so better that it's in character.c.
6819 * fns.c, print.c: Adjust to above changes.
6821 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6823 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6825 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6827 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6828 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6829 (x_clipboard_manager_save): Now static.
6830 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6832 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6833 (crypto_hash_function): Now static.
6834 Fix pointer signedness problems. Avoid unnecessary initializations.
6836 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6838 * termhooks.h (Vselection_alist): Make it terminal-local.
6840 * terminal.c (create_terminal): Initialize it.
6842 * xselect.c: Support for clipboard managers.
6843 (Vselection_alist): Move to termhooks.h as terminal-local var.
6844 (LOCAL_SELECTION): New macro.
6845 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6846 (symbol_to_x_atom): Remove gratuitous arg.
6847 (x_handle_selection_request, lisp_data_to_selection_data)
6848 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6849 (x_own_selection, x_get_local_selection, x_convert_selection):
6850 New arg, specifying work frame. Use terminal-local Vselection_alist.
6851 (some_frame_on_display): Delete unused function.
6852 (Fx_own_selection_internal, Fx_get_selection_internal)
6853 (Fx_disown_selection_internal, Fx_selection_owner_p)
6854 (Fx_selection_exists_p): New optional frame arg.
6855 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6856 (x_handle_selection_clear): Don't treat other terminals with the
6857 same keyboard specially. Use the terminal-local Vselection_alist.
6858 (x_clear_frame_selections): Use Frun_hook_with_args.
6860 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6862 * xterm.h: Add support for those atoms.
6864 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6866 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6867 (converted_selections, conversion_fail_tag): New global variables.
6868 (x_selection_request_lisp_error): Free the above.
6869 (x_get_local_selection): Remove unnecessary code.
6870 (x_reply_selection_request): Args changed; handle arbitrary array
6871 of converted selections stored in converted_selections.
6872 Separate the XChangeProperty and SelectionNotify steps.
6873 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6874 (x_convert_selection): New function.
6875 (x_handle_selection_event): Simplify.
6876 (x_get_foreign_selection): Don't ignore incoming requests while
6877 waiting for an answer; this will fail when we implement
6878 SAVE_TARGETS, and seems unnecessary anyway.
6879 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6880 (Vx_sent_selection_functions): Doc fix.
6882 2011-05-26 Leo Liu <sdl.web@gmail.com>
6884 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6886 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6888 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6890 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6891 for fringe update if it has periodic bitmap.
6892 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6893 and fringe_bitmap_periodic_p.
6895 * fringe.c (get_fringe_bitmap_data): New function.
6896 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6897 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6898 row. Mark glyph row for fringe update if periodicity changed.
6900 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6901 for fringe update unless it has periodic bitmap.
6903 2011-05-25 Kenichi Handa <handa@m17n.org>
6905 * xdisp.c (get_next_display_element): Set correct it->face_id for
6906 a static composition.
6908 2011-05-24 Leo Liu <sdl.web@gmail.com>
6911 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6913 * fns.c (crypto_hash_function, Fsha1): New function.
6914 (Fmd5): Use crypto_hash_function.
6915 (syms_of_fns): Add Ssha1.
6917 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6919 * gnutls.c: Remove unused macros.
6920 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6921 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6922 Remove macros that are defined and never used.
6923 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6925 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6927 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6928 (Fx_get_selection_internal): Minor cleanup.
6929 (Fx_own_selection_internal): Rename arguments for consistency with
6932 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6934 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6936 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6938 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6940 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6942 * dispnew.c (scrolling_window): Don't exclude the case that the
6943 last enabled row in the desired matrix touches the bottom boundary.
6945 2011-05-21 Glenn Morris <rgm@gnu.org>
6947 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6948 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6949 and add some more files.
6951 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6953 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6954 report_file_error introduced by the change from 2011-05-07.
6956 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6958 * systime.h (Time): Define only if emacs is defined.
6959 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6960 where the include path doesn't have X11/X.h by default. See
6961 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6963 2011-05-20 Kenichi Handa <handa@m17n.org>
6965 * composite.c (find_automatic_composition): Fix previous change.
6967 2011-05-20 Glenn Morris <rgm@gnu.org>
6969 * lisp.mk: New file, split from Makefile.in.
6970 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6971 (shortlisp): Remove.
6972 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6974 2011-05-19 Glenn Morris <rgm@gnu.org>
6976 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6977 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6978 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6979 (lisp): Set the order to that of loadup.el.
6980 (shortlisp): Make it a copy of $lisp.
6981 (SOME_MACHINE_LISP): Remove.
6982 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6983 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6985 2011-05-18 Kenichi Handa <handa@m17n.org>
6987 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6988 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6989 (find_automatic_composition): Mostly rewrite for efficiency.
6991 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6993 * makefile.w32-in: Update dependencies.
6995 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6997 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6998 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
7000 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
7002 Fix some integer overflow issues, such as string length overflow.
7004 * insdel.c (count_size_as_multibyte): Check for string overflow.
7006 * character.c (lisp_string_width): Check for string overflow.
7007 Use EMACS_INT, not int, for string indexes and lengths; in
7008 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
7009 the resulting string length overflows an EMACS_INT; instead,
7010 report a string overflow if no precision given. When checking for
7011 precision exhaustion, use a check that cannot possibly have
7012 integer overflow. (Bug#8675)
7013 * character.h (lisp_string_width): Adjust to new signature.
7015 * alloc.c (string_overflow): New function.
7016 (Fmake_string): Use it. This doesn't change behavior, but saves
7017 a few bytes and will simplify future changes.
7018 * character.c (string_escape_byte8): Likewise.
7019 * lisp.h (string_overflow): New decl.
7021 Fixups, following up to the user-interface timestamp change.
7022 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
7023 for UI timestamps, instead of unsigned long.
7024 * msdos.c (mouse_get_pos): Likewise.
7025 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
7026 * w32gui.h (Time): Define by including "systime.h" rather than by
7027 declaring it ourselves. (Bug#8664)
7029 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
7030 * image.c (clear_image_cache): Likewise.
7032 * term.c (term_mouse_position): Don't assume time_t wraparound.
7034 Be more systematic about user-interface timestamps.
7035 Before, the code sometimes used 'Time', sometimes 'unsigned long',
7036 and sometimes 'EMACS_UINT', to represent these timestamps.
7037 This change causes it to use 'Time' uniformly, as that's what X uses.
7038 This makes the code easier to follow, and makes it easier to catch
7039 integer overflow bugs such as Bug#8664.
7040 * frame.c (Fmouse_position, Fmouse_pixel_position):
7041 Use Time, not unsigned long, for user-interface timestamps.
7042 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
7043 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
7044 * keyboard.h (last_event_timestamp): Likewise.
7045 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
7046 * menu.h (xmenu_show): Likewise.
7047 * term.c (term_mouse_position): Likewise.
7048 * termhooks.h (struct input_event.timestamp): Likewise.
7049 (struct terminal.mouse_position_hook): Likewise.
7050 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
7051 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
7052 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
7053 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
7055 * menu.h, termhooks.h: Include "systime.h", for Time.
7057 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
7058 Don't assume that the difference between two unsigned long values
7059 can fit into an integer. At this point, we know button_down_time
7060 <= event->timestamp, so the difference must be nonnegative, so
7061 there's no need to cast the result if double-click-time is
7062 nonnegative, as it should be; check that it's nonnegative, just in
7063 case. This bug is triggered when events are more than 2**31 ms
7064 apart (about 25 days). (Bug#8664)
7066 * xselect.c (last_event_timestamp): Remove duplicate decl.
7067 (x_own_selection): Remove needless cast to unsigned long.
7069 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
7070 that always fit in int. Use a sentinel instead of a counter, to
7071 avoid a temp and to allay GCC's concerns about possible int overflow.
7072 * frame.h (struct frame): Use int for menu_bar_items_used
7073 instead of EMACS_INT, since it always fits in int.
7075 * menu.c (grow_menu_items): Check for int overflow.
7077 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
7079 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
7080 Before, the code was not consistent. These values cannot exceed
7081 2**31 - 1 so there's no need to make them unsigned.
7082 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
7083 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
7084 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
7086 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
7088 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
7089 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
7090 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
7091 presumably because the widths might not match.
7093 * window.c (size_window): Avoid needless test at loop start.
7095 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
7097 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
7099 2011-05-12 Drew Adams <drew.adams@oracle.com>
7101 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
7103 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7105 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
7106 `width' to `bar_area_x' and `bar_area_width', respectively.
7107 (x_scroll_run): Take account of fringe background extension.
7109 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
7110 Rename local vars `left' and `width' to `bar_area_x' and
7111 `bar_area_width', respectively.
7112 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
7113 background extension.
7115 2011-05-10 Jim Meyering <meyering@redhat.com>
7117 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
7119 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
7121 * image.c (Finit_image_library): Return t for built-in image types,
7122 like pbm and xbm. (Bug#8640)
7124 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
7126 * w32menu.c (set_frame_menubar): Fix submenu allocation.
7128 2011-05-07 Eli Zaretskii <eliz@gnu.org>
7130 * w32console.c (Fset_screen_color): Doc fix.
7131 (Fget_screen_color): New function.
7132 (syms_of_ntterm): Defsubr it.
7134 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
7135 unlink the temporary file if Fcall_process didn't create it in the
7137 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
7138 child process will be redirected to a file specified with `:file'.
7139 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
7140 cue to call_process_cleanup not to close that handle.
7142 2011-05-07 Ben Key <bkey76@gmail.com>
7144 * makefile.w32-in: The bootstrap-temacs rule now makes use of
7145 one of two shell specific rules, either bootstrap-temacs-CMD or
7146 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
7147 to the previous implementation of the bootstrap-temacs rule.
7148 The bootstrap-temacs-CMD rule is similar to the previous
7149 implementation of the bootstrap-temacs rule except that it
7150 makes use of the ESC_CFLAGS variable instead of the CFLAGS
7153 These changes, along with some changes to nt/configure.bat,
7154 nt/gmake.defs, and nt/nmake.defs, are required to extend my
7155 earlier fix to add support for --cflags and --ldflags options
7156 that include quotes so that it works whether make uses cmd or
7159 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
7161 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
7162 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
7164 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
7165 a string. Handle both cases.
7166 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
7167 (Fdbus_register_method): Use Qinvalid_function.
7169 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7171 * makefile.w32-in: Update dependencies.
7172 (LISP_H): Add inttypes.h and stdin.h.
7173 (PROCESS_H): Add unistd.h.
7175 2011-05-06 Eli Zaretskii <eliz@gnu.org>
7177 * lread.c: Include limits.h (fixes the MS-Windows build broken by
7178 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
7180 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
7182 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
7184 * term.c (vfatal): Remove stray call to va_end.
7185 It's not needed and the C Standard doesn't allow it here anyway.
7187 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
7188 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
7190 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
7193 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
7195 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7197 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
7199 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
7201 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
7203 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
7204 * charset.c (Fdefine_charset_internal): Don't initialize
7205 charset.code_space[15]. The value was garbage, on hosts with
7206 32-bit int (Bug#8600).
7208 * lread.c (read_integer): Be more consistent with string-to-number.
7209 Use string_to_number to do the actual conversion; this avoids
7210 rounding errors and fixes some other screwups. Without this fix,
7211 for example, #x1fffffffffffffff was misread as -2305843009213693952.
7212 (digit_to_number): Move earlier, for benefit of read_integer.
7213 Return -1 if the digit is out of range for the base, -2 if it is
7214 not a digit in any supported base. (Bug#8602)
7216 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
7218 * dispnew.c (scrolling_window): Return 1 if we scrolled,
7219 to match comment at start of function. This also removes a
7220 GCC warning about overflow in a 32+64-bit port.
7222 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
7224 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
7225 Reported by Stefan Monnier in
7226 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
7227 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7228 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
7230 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
7231 (EMACS_UINTPTR): Likewise, with uintptr_t.
7233 * lisp.h: Prefer 64-bit EMACS_INT if available.
7234 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
7235 on 32-bit hosts that have 64-bit int, so that they can access
7237 However, temporarily disable this change unless the temporary
7238 symbol WIDE_EMACS_INT is defined.
7240 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
7242 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
7243 This removes an assumption that EMACS_INT and long are the same
7244 width as pointers. The assumption is true for Emacs porting targets
7245 now, but we want to make other targets possible.
7246 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
7247 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
7248 In the rest of the code, change types of integers that hold casted
7249 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
7250 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
7251 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
7252 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
7253 No need to cast type when ORing.
7254 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
7255 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
7256 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
7257 assume EMACS_INT is the same width as char *.
7258 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
7259 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
7260 Remove no-longer-needed casts.
7261 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
7262 (xg_tool_bar_help_callback, xg_make_tool_item):
7263 Use EMACS_INTPTR to hold an integer
7264 that will be cast to void *; this can avoid a GCC warning
7265 if EMACS_INT is not the same width as void *.
7266 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
7267 * xdisp.c (display_echo_area_1, resize_mini_window_1):
7268 (current_message_1, set_message_1):
7269 Use a local to convert to proper width without a cast.
7270 * xmenu.c (dialog_selection_callback): Likewise.
7272 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
7273 Also, don't assume VALBITS / RAND_BITS is less than 5,
7274 and don't rely on undefined behavior when shifting a 1 left into
7276 * lisp.h (get_random): Change signature to match.
7278 * lread.c (hash_string): Use size_t, not int, for hash computation.
7279 Normally we prefer signed values; but hashing is special, because
7280 it's better to use unsigned division on hash table sizes so that
7281 the remainder is nonnegative. Also, size_t is the natural width
7282 for hashing into memory. The previous code used 'int', which doesn't
7283 retain enough info to hash well into very large tables.
7284 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
7286 * dbusbind.c: Don't possibly lose pointer info when converting.
7287 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7288 Use XPNTR rather than XHASH, so that the high-order bits of
7289 the pointer aren't lost when converting through void *.
7291 * eval.c (Fautoload): Don't double-shift a pointer.
7293 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
7295 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7297 * gnutls.c (DEF_GNUTLS_FN):
7298 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7300 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7302 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7305 2011-05-05 Eli Zaretskii <eliz@gnu.org>
7307 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7308 New version that can reserve upto 2GB of heap space.
7310 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
7312 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7314 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7316 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7317 `gnutls_certificate_set_x509_key_file'.
7319 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
7321 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7322 Update dependencies.
7324 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7326 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7327 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7328 Remove unused parameter `fildes'.
7329 * process.c (read_process_output, send_process): Don't pass it.
7331 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7333 Fix previous change: the library cache is defined in w32.c.
7334 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7335 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7337 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7339 Implement dynamic loading of GnuTLS on Windows.
7341 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7342 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7343 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7346 * gnutls.c (Qgnutls_dll): Define.
7347 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7348 (gnutls_*): Declare function pointers.
7349 (init_gnutls_functions): New function to initialize function pointers.
7350 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7351 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7352 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7353 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7354 (emacs_gnutls_write, emacs_gnutls_read)
7355 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7356 (Fgnutls_available_p): New function.
7357 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7358 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7359 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7361 * image.c: Include w32.h.
7362 (Vimage_type_cache): Delete.
7363 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7364 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7365 (w32_delayed_load): Move to w32.c.
7367 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7369 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7370 (w32_delayed_load): Move from image.c. When loading a library, record
7371 its filename in the :loaded-from property of the library id.
7372 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7373 Initialize and staticpro them.
7374 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7376 * process.c: Include lisp.h before w32.h, not after.
7377 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7378 instead of gnutls_record_check_pending.
7380 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7382 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7384 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7385 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7388 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7390 * xterm.c (x_set_frame_alpha): Do not set property on anything
7391 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7393 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7395 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7397 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7399 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7400 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7401 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7402 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7403 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7404 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7405 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7406 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7407 (Qgnutls_bootprop_callbacks_verify): Make static.
7409 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7411 * callproc.c: Indentation fixup.
7413 * sysdep.c (wait_for_termination_1): Make static.
7414 (wait_for_termination, interruptible_wait_for_termination):
7415 Move after wait_for_termination_1.
7417 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7419 * sysdep.c (interruptible_wait_for_termination): New function
7420 which is like wait_for_termination, but allows keyboard
7423 * callproc.c (Fcall_process): Add (:file "file") as an option for
7425 (Fcall_process_region): Ditto.
7427 2011-04-30 Eli Zaretskii <eliz@gnu.org>
7429 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7430 rather than `XVECTOR (FOO)->size'.
7432 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7433 inttypes.h, as a gnulib replacement is used if it not available in
7436 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7438 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7439 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7440 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7442 * coding.c (coding_alloc_by_realloc): Error out if destination
7443 will grow beyond MOST_POSITIVE_FIXNUM.
7444 (decode_coding_emacs_mule): Abort if there isn't enough place in
7445 charbuf for the composition carryover bytes. Reserve an extra
7446 space for up to 2 characters produced in a loop.
7447 (decode_coding_iso_2022): Abort if there isn't enough place in
7448 charbuf for the composition carryover bytes.
7450 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7452 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7453 aborting when %lld or %lll format is passed.
7454 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7455 %llo or %llx format is passed. (Bug#8545)
7457 * window.c (window_scroll_line_based): Use a marker instead of
7458 simple variables to record original value of point. (Bug#7952)
7460 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7461 produced by %s or %c overflows available buffer space. (Bug#8545)
7463 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7465 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7466 (SIZE_MAX): Move defn after all includes, as they might #define it.
7468 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7470 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7472 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7474 * keyboard.c (Qdelayed_warnings_hook): Define.
7475 (command_loop_1): Run `delayed-warnings-hook'
7476 if Vdelayed_warnings_list is non-nil.
7477 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7478 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7480 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7482 * doprnt.c (doprnt): Don't return value smaller than the buffer
7483 size if the message was truncated. (Bug#8545).
7485 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7487 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7488 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7490 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7492 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7494 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7496 * makefile.w32-in: Update dependencies.
7498 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7500 Improve `doprnt' and its usage. (Bug#8545)
7501 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7502 `format_end'. Remove support for %l as a conversion specifier.
7503 Don't use xrealloc. Improve diagnostics when the %l size modifier
7504 is used. Update the commentary.
7506 * eval.c (verror): Simplify calculation of size_t.
7508 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7511 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7513 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7516 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7518 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7519 This makes this file independent of the recent pseudovector change.
7521 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7523 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7525 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7526 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7527 Remove unused local.
7528 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7530 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7531 GCC 4.6.0 optimizes based on type-based alias analysis.
7532 For example, if b is of type struct buffer * and v of type struct
7533 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7534 != &v->size, and therefore "v->size = 1; b->size = 2; return
7535 v->size;" must therefore return 1. This assumption is incorrect
7536 for Emacs, since it type-puns struct Lisp_Vector * with many other
7537 types. To fix this problem, this patch adds a new type struct
7538 vectorlike_header that documents the constraints on layout of vectors
7539 and pseudovectors, and helps optimizing compilers not get fooled
7540 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7541 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7542 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7544 (XSETPVECTYPE): Rewrite in terms of new macro.
7545 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7546 This is a bit clearer, and further avoids the possibility of
7547 undesirable aliasing.
7548 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7549 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7550 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7551 since Lisp_Subr is a special case (no "next" field).
7552 (ASIZE): Now uses header.size rather than size.
7553 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7554 to avoid the hassle of writing XVECTOR (foo)->header.size.
7555 (struct vectorlike_header): New type.
7556 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7557 object, to help avoid aliasing.
7558 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7559 (SUBRP): Likewise, since Lisp_Subr is a special case.
7560 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7561 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7562 (struct Lisp_Hash_Table): Combine first two members into a single
7563 struct vectorlike_header member. All uses of "size" and "next" members
7564 changed to be "header.size" and "header.next".
7565 * buffer.h (struct buffer): Likewise.
7566 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7567 * frame.h (struct frame): Likewise.
7568 * process.h (struct Lisp_Process): Likewise.
7569 * termhooks.h (struct terminal): Likewise.
7570 * window.c (struct save_window_data, struct saved_window): Likewise.
7571 * window.h (struct window): Likewise.
7572 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7573 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7574 * buffer.c (init_buffer_once): Likewise.
7575 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7577 * process.c (Fformat_network_address): Use local var for size,
7580 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7582 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7583 * data.c (atof): Remove decl; no longer used or needed.
7584 (digit_to_number): Move to lread.c.
7585 (Fstring_to_number): Use new string_to_number function, to be
7586 consistent with how the Lisp reader treats infinities and NaNs.
7587 Do not assume that floating-point numbers represent EMACS_INT
7588 without losing information; this is not true on most 64-bit hosts.
7589 Avoid double-rounding errors, by insisting on integers when
7590 parsing non-base-10 numbers, as the documentation specifies.
7591 * lisp.h (string_to_number): New decl, replacing ...
7592 (isfloat_string): Remove.
7593 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7594 (read1): Do not accept +. and -. as integers; this
7595 appears to have been a coding error. Similarly, do not accept
7596 strings like +-1e0 as floating point numbers. Do not report
7597 overflow for integer overflows unless the base is not 10 which
7598 means we have no simple and reliable way to continue.
7599 Break out the floating-point parsing into a new
7600 function string_to_number, so that Fstring_to_number parses
7601 floating point numbers consistently with the Lisp reader.
7602 (digit_to_number): Move here from data.c. Make it static inline.
7603 (E_CHAR, EXP_INT): Remove, replacing with ...
7604 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7605 (string_to_number): New function, replacing isfloat_string.
7606 This function checks for valid syntax and produces the resulting
7607 Lisp float number too. Rework it so that string-to-number
7608 no longer mishandles examples like "1.0e+". Use strtoumax,
7609 so that overflow for non-base-10 numbers is reported only when
7610 there's no portable and simple way to convert to floating point.
7612 * textprop.c (set_text_properties_1): Rewrite for clarity,
7613 and to avoid GCC warning about integer overflow.
7615 * intervals.h (struct interval): Use EMACS_INT for members
7616 where EMACS_UINT might cause problems. See
7617 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7618 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7619 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7621 (offset_intervals): Tell GCC not to worry about length overflow
7622 when negating a negative length.
7624 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7625 (overrun_check_free): Likewise.
7627 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7628 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7631 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7632 (gnutls_make_error): Rename local to avoid shadowing.
7633 (gnutls_emacs_global_deinit): ifdef out; not used.
7634 (Fgnutls_boot): Use const for pointer to readonly storage.
7635 Comment out unused local. Fix pointer signedness problems.
7637 * lread.c (openp): Don't stuff size_t into an 'int'.
7638 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7639 about possible signed overflow.
7641 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7642 (GDK_KEY_g): Don't define if already defined.
7643 (xg_prepare_tooltip): Avoid pointer signedness problem.
7644 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7646 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7647 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7649 * xfns.c (Fx_window_property): Simplify a bit,
7650 to make a bit faster and to avoid GCC 4.6.0 warning.
7651 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7653 * fns.c (internal_equal): Don't assume size_t fits in int.
7655 * alloc.c (compact_small_strings): Tighten assertion a little.
7657 Replace pEd with more-general pI, and fix some printf arg casts.
7658 * lisp.h (pI): New macro, generalizing old pEd macro to other
7659 conversion specifiers. For example, use "...%"pI"d..." rather
7660 than "...%"pEd"...".
7661 (pEd): Remove. All uses replaced with similar uses of pI.
7662 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7663 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7664 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7665 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7666 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7667 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7668 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7670 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7671 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7672 * print.c (safe_debug_print, print_object): Likewise.
7673 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7675 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7676 avoiding the 0 flag, which is not portable.
7677 * process.c (Fmake_network_process): Use pI to avoid cast.
7678 * region-cache.c (pp_cache): Likewise.
7679 * xdisp.c (decode_mode_spec): Likewise.
7680 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7681 behavior on 64-bit hosts with printf arg.
7682 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7683 (x_stop_queuing_selection_requests): Likewise.
7684 (x_get_window_property): Don't truncate byte count to an 'int'
7687 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7688 here, since it parses constructs like leading '-' and spaces,
7689 which are not wanted; and it overflows with large numbers.
7690 Instead, simply match F[0-9]+, which is what is wanted anyway.
7692 * alloc.c: Remove unportable assumptions about struct layout.
7693 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7694 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7695 (allocate_vectorlike, make_pure_vector): Use the new macros,
7696 plus offsetof, to remove unportable assumptions about struct layout.
7697 These assumptions hold on all porting targets that I know of, but
7698 they are not guaranteed, they're easy to remove, and removing them
7699 makes further changes easier.
7701 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7702 This doesn't fix a bug but makes the code clearer.
7703 (string_overrun_cookie): Now const. Use initializers that
7704 don't formally overflow signed char, to avoid warnings.
7705 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7706 can cause Emacs to crash when string overrun checking is enabled.
7707 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7708 multiple of sizeof (EMACS_INT); it need not be, if
7709 alignof(EMACS_INT) < sizeof (EMACS_INT).
7710 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7712 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7714 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7716 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7718 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7719 supposed to be handshaking. (Bug#8556)
7720 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7722 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7724 * lisp.h (Qdebug): List symbol.
7725 * eval.c (Qdebug): Restore global linkage.
7726 * keyboard.c (debug-on-event): New variable.
7727 (handle_user_signal): Break into debugger when debug-on-event
7728 matches the current signal symbol.
7730 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7732 * alloc.c (check_sblock, check_string_bytes)
7733 (check_string_free_list): Convert to standard C.
7735 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7737 * w32.c (emacs_gnutls_push): Fix typo.
7739 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7741 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7742 "cast to pointer from integer of different size".
7744 Improve doprnt and its use in verror. (Bug#8545)
7745 * doprnt.c (doprnt): Document the set of format control sequences
7746 supported by the function. Use SAFE_ALLOCA instead of always
7749 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7750 is one byte too soon. Don't use xrealloc; instead xfree and
7753 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7755 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7758 * gnutls.c: Renamed global_initialized to
7759 gnutls_global_initialized. Added internals for the
7760 :verify-hostname-error, :verify-error, and :verify-flags
7761 parameters of `gnutls-boot' and documented those parameters in the
7762 docstring. Start callback support.
7763 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7764 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7765 on error. Return error code.
7766 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7767 (emacs_gnutls_read): Likewise.
7768 (Fgnutls_boot): Return handshake error code.
7769 (emacs_gnutls_handle_error): New function.
7770 (wsaerror_to_errno): Likewise.
7772 * w32.h (emacs_gnutls_pull): Add prototype.
7773 (emacs_gnutls_push): Likewise.
7775 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7776 (emacs_gnutls_push): Likewise.
7778 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7780 * process.c (wait_reading_process_output): Check if GnuTLS
7781 buffered some data internally if no FDs are set for TLS
7784 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7785 (LIBS): Link to USER_LIBS.
7786 ($(BLD)/gnutls.$(0)): New target.
7788 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7790 * xdisp.c (handle_single_display_spec): Rename the
7791 display_replaced_before_p argument into display_replaced_p, to
7792 make it consistent with the commentary. Fix typos in the
7795 * textprop.c (syms_of_textprop): Remove dead code.
7796 (copy_text_properties): Delete obsolete commentary about an
7797 interface that was deleted long ago. Fix typos in the description
7800 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7801 to changes in oldXMenu/XMenu.h from 2011-04-16.
7802 <menu_help_message, prev_menu_help_message>: Constify.
7803 (IT_menu_make_room): menu->help_text is now `const char **';
7806 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7807 to changes in oldXMenu/XMenu.h from 2011-04-16.
7808 (struct XMenu): Declare `help_text' `const char **'.
7810 * xfaces.c <Qunspecified>: Make extern again.
7812 * syntax.c: Include sys/types.h before including regex.h, as
7815 * doc.c (get_doc_string): Improve the format passed to `error'.
7817 * doprnt.c (doprnt): Improve commentary.
7819 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7821 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7824 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7825 changes in globals.h immediately force recompilation.
7826 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7827 $(CURDIR)/s/ms-w32.h.
7828 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7830 * character.c (Fchar_direction): Function deleted.
7831 (syms_of_character): Don't defsubr it.
7832 <char-direction-table>: Deleted.
7834 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7836 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7837 * doprnt.c: Include limits.h.
7838 (SIZE_MAX): New macro.
7839 (doprnt): Return a size_t value. 2nd arg is now size_t.
7840 Many local variables are now size_t instead of int or unsigned.
7841 Improve overflow protection. Support `l' modifier for integer
7842 conversions. Support %l conversion. Don't assume an EMACS_INT
7843 argument for integer conversions and for %c.
7845 * lisp.h (doprnt): Restore prototype.
7847 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7850 * Makefile.in (base_obj): Add back doprnt.o.
7852 * deps.mk (doprnt.o): Add back prerequisites.
7853 (callint.o): Depend on character.h.
7855 * eval.c (internal_lisp_condition_case): Include the handler
7856 representation in the error message.
7857 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7858 when breaking from the loop.
7860 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7862 * callint.c (Fcall_interactively): When displaying error message
7863 about invalid control letter, pass the character's codepoint, not
7864 a pointer to its multibyte form. Improve display of the character
7865 in octal and display also its hex code.
7867 * character.c (char_string): Use %x to display the (unsigned)
7868 codepoint of an invalid character, to avoid displaying a bogus
7871 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7872 `error', not SYMBOL_NAME itself.
7874 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7875 character arguments to `error'.
7877 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7878 to `error' in error message about FINAL_CHAR argument. Make sure
7879 FINAL_CHAR is a character, and use %c when it is passed as
7880 argument to `error'.
7882 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7884 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7886 * w32.c: Include <time.h>.
7887 (sys_localtime): New function.
7889 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7891 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7893 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7895 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7897 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7900 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7902 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7903 gl_state.e_property when gl_state.object is Qt.
7905 * insdel.c (make_gap_larger): Remove limitation of buffer size
7908 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7910 * xdisp.c (lookup_glyphless_char_display)
7911 (produce_glyphless_glyph): Handle cons cell entry in
7912 glyphless-char-display.
7913 (Vglyphless_char_display): Document it.
7915 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7916 glyphless-char-display.
7918 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7920 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7922 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7924 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7925 definition for no-X builds.
7927 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7929 Static checks with GCC 4.6.0 and non-default toolkits.
7931 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7933 * process.c (keyboard_bit_set): Define only if SIGIO.
7934 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7935 (send_process): Repair possible setjmp clobbering.
7937 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7939 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7941 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7943 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7944 Define only if needed.
7946 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7947 by pacifying GCC about it. Maybe it's time to retire it?
7948 * xfaces.c (USG, __TIMEVAL__): Likewise.
7950 * dispextern.h (struct redisplay_interface): Rename param
7952 * termhooks.h (struct terminal): Likewise.
7953 * xterm.c (xembed_send_message): Likewise.
7955 * insdel.c (make_gap_smaller): Define only if
7956 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7958 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7961 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7962 so that we aren't warned about unused symbols.
7964 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7966 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7968 * xfns.c (x_real_positions): Mark locals as initialized.
7970 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7972 * xterm.c: Fix problems found by static analysis with other toolkits.
7973 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7974 (x_dispatch_event): Declare static if USE_GTK, and
7975 define if USE_GTK || USE_X_TOOLKIT.
7976 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7977 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7978 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7979 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7981 * xmenu.c (menu_help_callback): Pointer type fixes.
7982 Use const pointers when pointing at readonly data. Avoid pointer
7984 (FALSE): Remove unused macro.
7985 (update_frame_menubar): Remove unused decl.
7987 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7989 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7990 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7991 (single_menu_item): Rename local to avoid shadowing.
7993 * keyboard.c (make_lispy_event): Remove unused local var.
7995 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7996 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7998 * bitmaps: Change bitmaps from unsigned char back to the X11
7999 compatible char. Avoid the old compiler warnings about
8000 out-of-range initializers by using, for example, '\xab' rather
8003 * xgselect.c (xgselect_initialize): Check vs interface
8004 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
8006 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
8008 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
8009 to read-only memory.
8011 * fns.c (vector): Remove; this old hack is no longer needed.
8013 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
8015 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
8017 * xrdb.c (x_load_resources): Omit unused local.
8019 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8020 (x_window): Rename locals to avoid shadowing.
8021 (USG): Use the kludged USG macro, to pacify gcc.
8023 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
8024 (x_term_init): Remove local to avoid shadowing.
8026 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
8028 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
8029 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
8031 2011-04-16 Eli Zaretskii <eliz@gnu.org>
8033 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
8035 Fix regex.c, syntax.c and friends for buffers > 2GB.
8036 * syntax.h (struct gl_state_s): Declare character position members
8039 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
8041 * textprop.c (verify_interval_modification, interval_of):
8042 Declare arguments EMACS_INT.
8044 * intervals.c (adjust_intervals_for_insertion): Declare arguments
8047 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
8049 * indent.c (Fvertical_motion): Local variable it_start is now
8052 * regex.c (re_match, re_match_2, re_match_2_internal)
8053 (bcmp_translate, regcomp, regexec, print_double_string)
8054 (group_in_compile_stack, re_search, re_search_2, regex_compile)
8055 (re_compile_pattern, re_exec): Declare arguments and local
8056 variables `size_t' and `ssize_t' and return values `regoff_t', as
8058 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
8059 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
8060 <compile_stack_type>: `size' and `avail' are now `size_t'.
8062 * regex.h <regoff_t>: Use ssize_t, not int.
8063 (re_search, re_search_2, re_match, re_match_2): Arguments that
8064 specify buffer/string position and length are now ssize_t and
8065 size_t. Return type is regoff_t.
8067 2011-04-16 Ben Key <bkey76@gmail.com>
8069 * nsfont.m: Fixed bugs in ns_get_family and
8070 ns_descriptor_to_entity that were caused by using free to
8071 deallocate memory blocks that were allocated by xmalloc (via
8072 xstrdup). This caused Emacs to crash when compiled with
8073 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
8074 --enable-checking=xmallocoverrun). xfree is now used to
8075 deallocate these memory blocks.
8077 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
8079 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
8081 emacs_write: Accept and return EMACS_INT for sizes.
8082 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
8084 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
8085 Accept and return EMACS_INT.
8086 (emacs_gnutls_write): Return the number of bytes written on
8088 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
8089 (emacs_read, emacs_write): Remove check for negative size, as the
8090 Emacs source code has been audited now.
8091 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
8092 (emacs_read, emacs_write): Use it.
8093 * process.c (send_process): Adjust to the new signatures of
8094 emacs_write and emacs_gnutls_write. Do not attempt to store
8095 a byte offset into an 'int'; it might overflow.
8096 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
8098 * sound.c: Don't assume sizes fit in 'int'.
8099 (struct sound_device.period_size, alsa_period_size):
8100 Return EMACS_INT, not int.
8101 (struct sound_device.write, vox_write, alsa_write):
8102 Accept EMACS_INT, not int.
8103 (wav_play, au_play): Use EMACS_INT to store sizes and to
8104 record read return values.
8106 2011-04-15 Ben Key <bkey76@gmail.com>
8108 * keyboard.c (Qundefined): Don't declare static since it is used
8110 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
8111 static since they are used in nsfont.m.
8113 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
8115 * process.c (Qprocessp): Don't declare static.
8116 * lisp.h (Qprocessp): Declare again.
8118 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
8120 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
8122 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
8124 Improve C-level modularity by making more things 'static'.
8126 Don't publish debugger-only interfaces to other modules.
8127 * lisp.h (safe_debug_print, debug_output_compilation_hack):
8128 (verify_bytepos, count_markers): Move decls to the only modules
8130 * region-cache.h (pp_cache): Likewise.
8131 * window.h (check_all_windows): Likewise.
8132 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
8134 * sysdep.c (croak): Now static, if
8135 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
8136 * syssignal.h (croak): Declare only if not static.
8138 * alloc.c (refill_memory_reserve): Now static if
8139 !defined REL_ALLOC || defined SYSTEM_MALLOC.
8140 * lisp.h (refill_memory_reserve): Declare only if not static.
8142 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
8143 Define only if USE_LUCID.
8145 * xrdb.c (x_customization_string, x_rm_string): Now static.
8147 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
8148 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
8150 * xdisp.c (draw_row_with_mouse_face): Now static.
8151 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
8153 * window.h (check_all_windows): Mark externally visible.
8155 * window.c (window_deletion_count): Now static.
8157 * undo.c: Make symbols static if they're not exported.
8158 (last_undo_buffer, last_boundary_position, pending_boundary):
8161 * textprop.c (interval_insert_behind_hooks): Now static.
8162 (interval_insert_in_front_hooks): Likewise.
8164 * term.c: Make symbols static if they're not exported.
8165 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
8166 (max_frame_lines, tty_set_terminal_modes):
8167 (tty_reset_terminal_modes, tty_turn_off_highlight):
8168 (get_tty_terminal): Now static.
8169 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
8170 * termhooks.h (term_mouse_moveto): Do not declare if
8172 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
8173 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
8175 * sysdep.c: Make symbols static if they're not exported.
8176 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
8178 (sigprocmask_set, full_mask): Remove; unused.
8179 (wait_debugging): Mark as visible.
8180 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
8181 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
8183 * syntax.c (syntax_temp): Define only if !__GNUC__.
8185 * sound.c (current_sound_device, current_sound): Now static.
8187 * search.c (searchbufs, searchbuf_head): Now static.
8189 * scroll.c (scroll_cost): Remove; unused.
8190 * dispextern.h (scroll_cost): Remove decl.
8192 * region-cache.h (pp_cache): Mark as externally visible.
8194 * process.c: Make symbols static if they're not exported.
8195 (process_tick, update_tick, create_process, chan_process):
8196 (Vprocess_alist, proc_buffered_char, datagram_access):
8197 (fd_callback_data, send_process_frame, process_sent_to): Now static.
8198 (deactivate_process): Mark defn as static, as well as decl.
8199 * lisp.h (create_process): Remove decl.
8200 * process.h (chan_process, Vprocess_alist): Remove decls.
8202 * print.c: Make symbols static if they're not exported.
8203 (print_depth, new_backquote_output, being_printed, print_buffer):
8204 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
8205 (print_interval, print_number_index, initial_stderr_stream):
8207 * lisp.h (Fprinc): Remove decl.
8208 (debug_output_compilation_hack): Mark as externally visible.
8210 * sysdep.c (croak): Move decl from here to syssignal.h.
8211 * syssignal.h (croak): Put it here, so the API can be checked when
8212 'croak' is called from dissociate_if_controlling_tty.
8214 * minibuf.c: Make symbols static if they're not exported.
8215 (minibuf_save_list, choose_minibuf_frame): Now static.
8216 * lisp.h (choose_minibuf_frame): Remove decl.
8218 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
8220 * lread.c: Make symbols static if they're not exported.
8221 (read_objects, initial_obarray, oblookup_last_bucket_number):
8223 (make_symbol): Remove; unused.
8224 * lisp.h (initial_obarray, make_symbol): Remove decls.
8226 * keyboard.c: Make symbols static if they're not exported.
8227 (single_kboard, recent_keys_index, total_keys, recent_keys):
8228 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
8229 (this_single_command_key_start, echoing, last_auto_save):
8230 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
8231 (command_loop, echo_now, keyboard_init_hook, help_char_p):
8232 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
8233 (Vlispy_mouse_stem, double_click_count):
8235 (force_auto_save_soon): Define only if SIGDANGER.
8236 (ignore_mouse_drag_p): Now static if
8237 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
8238 (print_help): Remove; unused.
8239 (stop_character, last_timer_event): Mark as externally visible.
8240 * keyboard.h (ignore_mouse_drag_p): Declare only if
8241 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
8242 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
8243 * lisp.h (echoing): Remove decl.
8244 (force_auto_save_soon): Declare only if SIGDANGER.
8245 * xdisp.c (redisplay_window): Simplify code, to make it more
8246 obvious that ignore_mouse_drag_p is not accessed if !defined
8247 USE_GTK && !defined HAVE_NS.
8249 * intervals.c: Make symbols static if they're not exported.
8250 (merge_properties_sticky, merge_interval_right, delete_interval):
8252 * intervals.h (merge_interval_right, delete_interval): Remove decls.
8254 * insdel.c: Make symbols static if they're not exported.
8255 However, leave prepare_to_modify_buffer alone. It's never
8256 called from outside this function, but that appears to be a bug.
8257 (combine_after_change_list, combine_after_change_buffer):
8258 (adjust_after_replace, signal_before_change): Now static.
8259 (adjust_after_replace_noundo): Remove; unused.
8260 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
8261 (signal_before_change): Remove decls.
8263 * indent.c (val_compute_motion, val_vmotion): Now static.
8265 * image.c: Make symbols static if they're not exported.
8266 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
8268 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
8269 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8271 * fringe.c (standard_bitmaps): Now static.
8272 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
8274 * frame.c: Make symbols static if they're not exported.
8275 (x_report_frame_params, make_terminal_frame): Now static.
8276 (get_frame_param): Now static, unless HAVE_NS.
8277 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
8278 (x_get_resource_string): Remove; not used.
8279 * frame.h (make_terminal_frame, x_report_frame_params):
8280 (x_get_resource_string); Remove decls.
8281 (x_fullscreen_adjust): Declare only if WINDOWSNT.
8282 * lisp.h (get_frame_param): Declare only if HAVE_NS.
8284 * font.c, fontset.c: Make symbols static if they're not exported.
8285 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
8286 (FACE_SUITABLE_FOR_CHAR_P): Use it.
8287 * font.c (font_close_object): Now static.
8288 * font.h (font_close_object): Remove.
8289 * fontset.c (FONTSET_OBJLIST): Remove.
8290 (free_realized_fontset) #if-0 the body, which does nothing.
8291 (face_suitable_for_char_p): #if-0, as it's never called.
8292 * fontset.h (face_suitable_for_char_p): Remove decl.
8293 * xfaces.c (face_at_string_position):
8294 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
8295 since 0 is always ASCII.
8297 * fns.c (weak_hash_tables): Now static.
8299 * fileio.c: Make symbols static if they're not exported.
8300 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8301 (Vwrite_region_annotation_buffers): Now static.
8303 * eval.c: Make symbols static if they're not exported.
8304 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8305 * lisp.h (backtrace_list): Remove decl.
8307 * emacs.c: Make symbols static if they're not exported.
8308 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8309 (fatal_error_code, fatal_error_signal_hook, standard_args):
8311 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8312 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8313 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8314 * lisp.h (fatal_error_signal_hook): Remove decl.
8315 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8317 * editfns.c: Move a (normally-unused) function to its only use.
8318 * editfns.c, lisp.h (get_operating_system_release): Remove.
8319 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8320 worth the hassle of breaking this out.
8322 * xterm.c: Make symbols static if they're not exported.
8323 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8324 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8325 (x_destroy_window, x_delete_display):
8327 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8328 (x_mouse_leave): Remove; unused.
8329 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8330 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8331 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8333 (x_mouse_leave): Declare only if WINDOWSNT.
8334 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8335 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8338 * ftxfont.c: Make symbols static if they're not exported.
8339 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8341 * font.h (ftxfont_driver): Likewise.
8343 * xfns.c: Make symbols static if they're not exported.
8344 (x_last_font_name, x_display_info_for_name):
8345 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8346 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8347 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8348 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8349 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8350 (last_show_tip_args): Now static.
8351 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8352 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8353 (x_screen_planes): Remove; unused.
8354 * dispextern.h (x_screen_planes): Remove decl.
8356 * dispnew.c: Make symbols static if they're not exported.
8357 * dispextern.h (redraw_garbaged_frames, scrolling):
8358 (increment_row_positions): Remove.
8359 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8360 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8362 (redraw_garbaged_frames): Remove; unused.
8364 * xfaces.c: Make symbols static if they're not exported.
8365 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8367 * xterm.h (defined_color): Remove decls.
8368 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8369 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8370 (menu_face_changed_default, defined_color, free_realized_face):
8371 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8372 (ascii_face_of_lisp_face): Remove; unused.
8374 * xdisp.c: Make symbols static if they're not exported.
8375 * dispextern.h (scratch_glyph_row, window_box_edges):
8376 (glyph_to_pixel_coords, set_cursor_from_row):
8377 (get_next_display_element, set_iterator_to_next):
8378 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8379 (show_mouse_face): Remove decls
8380 * frame.h (message_buf_print): Likewise.
8381 * lisp.h (pop_message, set_message, check_point_in_composition):
8383 * xterm.h (set_vertical_scroll_bar): Likewise.
8384 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8385 (message_buf_print, scratch_glyph_row, displayed_buffer):
8386 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8387 (get_next_display_element, show_mouse_face, window_box_edges):
8388 (frame_to_window_pixel_xy, check_point_in_composition):
8389 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8390 (glyph_to_pixel_coords): Remove; unused.
8392 * dired.c (file_name_completion): Now static.
8394 * dbusbind.c (xd_in_read_queued_messages): Now static.
8396 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8397 * data.c (circular_list_error): Remove.
8399 * commands.h (last_point_position, last_point_position_buffer):
8400 (last_point_position_window): Remove decls.
8401 * keyboard.c: Make these variables static.
8403 * coding.h (coding, code_convert_region, encode_coding_gap):
8405 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8406 (iso_code_class, detect_coding, code_convert_region): Now static.
8407 (encode_coding_gap): Remove; unused.
8409 * chartab.c (chartab_chars, chartab_bits): Now static.
8411 * charset.h (charset_iso_8859_1): Remove decl.
8412 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8415 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8416 * ccl.c (Vccl_program_table): Now static.
8417 (check_ccl_update): Remove; unused.
8419 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8420 * category.h: ... from here.
8421 * category.c (check_category_table, set_category_set): Now static.
8423 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8424 * lisp.h: Remove these decls.
8426 * buffer.c (buffer_count): Remove unused var.
8428 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8429 so that it's not optimized away.
8430 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8431 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8432 exported only to the debugger.
8434 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
8435 * atimer.h (run_all_atimers): Remove; not exported.
8437 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8438 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8439 was inaccessible from Lisp.
8440 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8441 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8443 alloc.c: Import and export fewer symbols, and remove unused items.
8444 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8446 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8447 it's not optimized away by whole-program optimization.
8448 (message_enable_multibyte, free_misc): Remove.
8449 (catchlist, handlerlist, mark_backtrace):
8450 Declare only if BYTE_MARK_STACK.
8451 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8452 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8453 (message_enable_multibyte): Remove decl.
8454 (free_misc, interval_free_list, float_block, float_block_index):
8455 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8456 (cons_free_list, last_marked_index):
8458 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8459 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8460 (mark_backtrace): Define only if BYTE_MARK_STACK.
8461 * xdisp.c (message_enable_multibyte): Now static.
8463 Declare Lisp_Object Q* variables to be 'static' if not exported.
8464 This makes it easier for human readers (and static analyzers)
8465 to see whether these variables are used from other modules.
8466 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8467 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8468 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8469 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8470 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8471 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8472 * xmenu.c, xselect.c:
8473 Declare Q* vars static if they are not used in other modules.
8474 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8475 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8476 Remove decls of unexported vars.
8477 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8479 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8481 Make Emacs functions such as Fatom 'static' by default.
8482 This makes it easier for human readers (and static analyzers)
8483 to see whether these functions can be called from other modules.
8484 DEFUN now defines a static function. To make the function external
8485 so that it can be used in other C modules, use the new macro DEFUE.
8486 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8487 (Finit_image_library):
8488 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8489 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8490 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8491 Remove decls, since these functions are now static.
8492 (Funintern, Fget_internal_run_time): New decls, since these functions
8493 were already external.
8495 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8496 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8497 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8498 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8499 * keyboard.c, keymap.c, lread.c:
8500 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8501 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8502 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8503 Mark functions with DEFUE instead of DEFUN,
8504 if they are used in other modules.
8505 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8506 decls for now-static functions.
8507 * buffer.h (Fdelete_overlay): Remove decl.
8508 * callproc.c (Fgetenv_internal): Mark as internal.
8509 * composite.c (Fremove_list_of_text_properties): Remove decl.
8510 (Fcomposition_get_gstring): New forward static decl.
8511 * composite.h (Fcomposite_get_gstring): Remove decl.
8512 * dired.c (Ffile_attributes): New forward static decl.
8513 * doc.c (Fdocumntation_property): New forward static decl.
8514 * eval.c (Ffetch_bytecode): New forward static decl.
8515 (Funintern): Remove extern decl; now in .h file where it belongs.
8516 * fileio.c (Fmake_symbolic_link): New forward static decl.
8517 * image.c (Finit_image_library): New forward static decl.
8518 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8519 * intervals.h (Fprevious_property_change):
8520 (Fremove_list_of_text_properties): Remove decls.
8521 * keyboard.c (Fthis_command_keys): Remove decl.
8522 (Fcommand_execute): New forward static decl.
8523 * keymap.c (Flookup_key): New forward static decl.
8524 (Fcopy_keymap): Now static.
8525 * keymap.h (Flookup_key): Remove decl.
8526 * process.c (Fget_process): New forward static decl.
8527 (Fprocess_datagram_address): Mark as internal.
8528 * syntax.c (Fsyntax_table_p): New forward static decl.
8529 (skip_chars): Remove duplicate decl.
8530 * textprop.c (Fprevious_property_change): New forward static decl.
8531 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8533 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8534 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8536 * editfns.c (Fformat): Remove unreachable code.
8538 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8540 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8543 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8545 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8546 when at ZV. (Bug#8487)
8548 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8550 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8552 * keyboard.c (parse_tool_bar_item): Likewise.
8553 * sound.c (sound_cleanup, alsa_close): Likewise.
8554 * termcap.c (tgetent): Likewise.
8555 * xfns.c (x_default_font_parameter): Likewise.
8556 * xsettings.c (read_and_apply_settings): Likewise.
8558 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8559 (overrun_check_free): Protoize.
8561 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8563 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8564 since callers should never pass a negative size.
8565 Change the signature to match that of plain 'read' and 'write'; see
8566 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8567 * lisp.h: Update prototypes of emacs_write and emacs_read.
8569 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8571 * xdisp.c (redisplay_window): Don't try to determine the character
8572 position of the scroll margin if the window start point w->startp
8573 is outside the buffer's accessible region. (Bug#8468)
8575 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8577 Fix write-region and its subroutines for buffers > 2GB.
8578 * fileio.c (a_write, e_write): Modify declaration of arguments and
8579 local variables to support buffers larger than 2GB.
8580 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8582 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8583 argument, local variables, and return value.
8585 * lisp.h: Update prototypes of emacs_write and emacs_read.
8587 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8589 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8591 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8593 Fix more problems found by GCC 4.6.0's static checks.
8595 * xdisp.c (vmessage): Use a better test for character truncation.
8597 * charset.c (load_charset_map): <, not <=, for optimization,
8598 and to avoid potential problems with integer overflow.
8599 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8600 * casetab.c (set_identity, shuffle): Likewise.
8601 * editfns.c (Fformat): Likewise.
8602 * syntax.c (skip_chars): Likewise.
8604 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8605 This also lets GCC 4.6.0 generate slightly better loop code.
8607 * callint.c (Fcall_interactively): <, not <=, for optimization.
8608 (Fcall_interactively): Count the number of arguments produced,
8609 not the number of arguments given. This is simpler and lets GCC
8610 4.6.0 generate slightly better code.
8612 * ftfont.c: Distingish more carefully between FcChar8 and char.
8613 The previous code passed unsigned char * to a functions like
8614 strlen and xstrcasecmp that expect char *, which does not
8615 conform to the C standard.
8616 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8617 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8618 char * when the C standard requires it.
8620 * keyboard.c (read_char): Remove unused var.
8622 * eval.c: Port to Windows vsnprintf (Bug#8435).
8624 (SIZE_MAX): Define if the headers do not.
8625 (verror): Do not give up if vsnprintf returns a negative count.
8626 Instead, grow the buffer. This ports to Windows vsnprintf, which
8627 does not conform to C99. Problem reported by Eli Zaretskii.
8628 Also, simplify the allocation scheme, by avoiding the need for
8629 calling realloc, and removing the ALLOCATED variable.
8631 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8633 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8634 But keep the doprint source code for now, as we might revamp it
8635 and use it again (Bug#8435).
8636 * lisp.h (doprnt): Remove.
8637 * Makefile.in (base_obj): Remove doprnt.o.
8638 * deps.mk (doprnt.o): Remove.
8640 error: Print 32- and 64-bit integers portably (Bug#8435).
8641 Without this change, on typical 64-bit hosts error ("...%d...", N)
8642 was used to print both 32- and 64-bit integers N, which relied on
8644 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8645 * lisp.h (error, verror): Mark as printf-like functions.
8646 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8647 Report overflow in size calculations when allocating printf buffer.
8648 Do not truncate output string at its first null byte.
8649 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8650 Truncate the output at a character boundary, since vsnprintf does not
8652 * charset.c (check_iso_charset_parameter): Convert internal
8653 character to string before calling 'error', since %c now has the
8655 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8656 overflow when computing char to be passed to 'error'. Do not
8657 pass Lisp_Object to 'error'; pass the integer instead.
8658 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8659 formatted with plain %d.
8661 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8663 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8665 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8667 * xterm.c (x_catch_errors): Remove duplicate declaration.
8669 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8671 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8673 2011-04-10 Jim Meyering <meyering@redhat.com>
8675 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8676 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8677 return ssize_t not "int", and use size_t as the buffer length.
8678 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8679 * gnutls.h: Update declarations.
8680 * process.c (read_process_output): Use ssize_t, to match.
8681 (send_process): Likewise.
8683 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8685 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8687 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8689 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8690 Use unsigned char, to match FcChar8 type definition.
8692 * xterm.c (handle_one_xevent):
8693 * xmenu.c (create_and_show_popup_menu):
8694 * xselect.c (x_decline_selection_request)
8695 (x_reply_selection_request): Avoid type-punned deref of X events.
8697 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8699 Fix some uses of `int' instead of EMACS_INT.
8700 * search.c (string_match_1, fast_string_match)
8701 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8702 (scan_buffer, find_next_newline_no_quit)
8703 (find_before_next_newline, search_command, Freplace_match)
8704 (Fmatch_data): Make some `int' variables be EMACS_INT.
8706 * xdisp.c (display_count_lines): 3rd argument and return value now
8707 EMACS_INT. All callers changed.
8708 (pint2hrstr): Last argument is now EMACS_INT.
8710 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8711 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8712 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8713 (decode_coding_utf_16, decode_coding_emacs_mule)
8714 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8715 (decode_coding_ccl, decode_coding_charset)
8716 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8717 (decode_coding_iso_2022, decode_coding_emacs_mule)
8718 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8719 <char_offset, last_offset>: Declare EMACS_INT.
8720 (encode_coding_utf_8, encode_coding_utf_16)
8721 (encode_coding_emacs_mule, encode_invocation_designation)
8722 (encode_designation_at_bol, encode_coding_iso_2022)
8723 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8724 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8726 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8727 (encode_invocation_designation): Last argument P_NCHARS is now
8729 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8730 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8732 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8735 * ccl.c (Fccl_execute_on_string): Declare some variables
8738 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8740 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8742 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8744 * process.c (Fformat_network_address): Doc fix.
8746 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8748 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8750 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8752 * keyboard.c (read_char): Call Lisp function help-form-show,
8753 instead of using internal_with_output_to_temp_buffer.
8754 (Qhelp_form_show): New var.
8755 (syms_of_keyboard): Use DEFSYM macro.
8757 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8759 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8761 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8763 * process.c (Flist_processes): Remove to Lisp.
8764 (list_processes_1): Delete.
8766 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8768 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8770 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8772 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8774 Fix more problems found by GCC 4.6.0's static checks.
8776 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8778 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8780 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8782 * xdisp.c (vmessage): Mark as a printf-like function.
8784 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8786 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8788 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8789 printf-like functions.
8790 (tiff_load): Add casts to remove these marks before passing them
8791 to system-supplied API.
8793 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8795 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8796 This avoids several warnings with gcc -Wstrict-overflow.
8797 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8798 directly, rather than having caller test rule sign. This avoids
8799 some unnecessary tests.
8800 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8801 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8802 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8804 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8805 (xfont_open): Avoid unnecessary tests.
8807 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8809 * composite.h, composite.c (composition_gstring_put_cache):
8810 Use EMACS_INT, not int, for length.
8812 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8813 breaking out part of COMPOSITION_DECODE_RULE.
8814 (COMPOSITION_DECODE_RULE): Use it.
8815 * composite.c (get_composition_id): Remove unused local vars,
8816 by using the new macro.
8818 * textprop.c (set_text_properties_1): Change while to do-while,
8819 since the condition is always true at first.
8821 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8822 (interval_deletion_adjustment): Return unsigned value.
8825 * process.c (list_processes_1, create_pty, read_process_output):
8826 (exec_sentinel): Remove vars that were set but not used.
8827 (create_pty): Remove unnecessary "volatile"s.
8828 (Fnetwork_interface_info): Avoid possibility of int overflow.
8829 (read_process_output): Do adaptive read buffering even if carryover.
8830 (read_process_output): Simplify nbytes computation if buffered.
8832 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8834 * syntax.c (scan_words): Remove var that was set but not used.
8835 (update_syntax_table): Use unsigned instead of int.
8837 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8838 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8839 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8841 * print.c (print_error_message): Avoid int overflow.
8843 * font.c (font_list_entities): Redo for clarity,
8844 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8846 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8847 (font_score): Avoid potential overflow in diff calculation.
8849 * fns.c (substring_both): Remove var that is set but not used.
8850 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8852 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8854 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8855 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8856 can always succeed if overflow has undefined behavior.
8858 * search.c (boyer_moore, wordify): Remove vars set but not used.
8859 (wordify): Omit three unnecessary tests.
8861 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8862 All callers changed. This avoids the need for an unused var.
8864 * casefiddle.c (casify_region): Remove var that is set but not used.
8866 * dired.c (file_name_completion): Remove var that is set but not used.
8868 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8870 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8871 (Finsert_file_contents): Remove unnecessary code checking fd.
8873 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8874 Check for integer overflow on size calculations.
8876 * buffer.c (Fprevious_overlay_change): Remove var that is set
8879 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8880 Remove vars that are set but not used.
8881 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8882 (timer_check_2): Mark vars as initialized.
8884 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8886 * image.c (lookup_image): Remove var that is set but not used.
8887 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8889 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8890 that are set but not used.
8892 * xfns.c (make_invisible_cursor): Don't return garbage
8893 if XCreateBitmapFromData fails (Bug#8410).
8895 * xselect.c (x_get_local_selection, x_handle_property_notify):
8896 Remove vars that are set but not used.
8898 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8899 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8901 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8902 Remove var that is set but not used.
8903 (scroll_bar_windows_size): Now size_t, not int.
8904 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8907 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8908 (map_tty_color) [!defined MSDOS]: Likewise.
8910 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8912 * coding.c: Remove vars that are set but not used.
8913 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8914 All callers changed.
8915 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8916 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8917 (decode_coding_charset): Remove vars that are set but not used.
8919 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8920 that is set but not used.
8922 * print.c (print_object): Remove var that is set but not used.
8924 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8925 The gnulib version avoids calling malloc in the usual case,
8926 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8927 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8928 * filelock.c (current_lock_owner): Likewise.
8929 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8930 * sysdep.c: Include allocator.h, careadlinkat.h.
8931 (emacs_no_realloc_allocator): New static constant.
8932 (emacs_readlink): New function.
8933 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8934 ../lib/careadlinkat.h.
8936 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8938 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8939 first non-nil return value).
8941 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8943 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8944 if not defined (Bug#8403).
8946 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8948 * xdisp.c (display_count_lines): Remove parameter `start',
8949 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8950 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8951 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8952 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8953 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8954 and thereabouts. All callers changed.
8955 (get_per_char_metric): Remove parameter `f', unused since
8956 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8958 2011-04-02 Jim Meyering <meyering@redhat.com>
8960 do not dereference NULL upon failed strdup
8961 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8962 (ns_get_family): Likewise.
8964 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8966 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8968 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8970 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8973 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8975 Add lexical binding.
8977 * window.c (Ftemp_output_buffer_show): New fun.
8978 (Fsave_window_excursion):
8979 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8981 * lread.c (lisp_file_lexically_bound_p): New function.
8982 (Fload): Bind Qlexical_binding.
8983 (readevalloop): Remove `evalfun' arg.
8984 Bind Qinternal_interpreter_environment.
8985 (Feval_buffer): Bind Qlexical_binding.
8986 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8988 (syms_of_lread): Declare `lexical-binding'.
8990 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8992 * keyboard.c (eval_dyn): New fun.
8993 (menu_item_eval_property): Use it.
8995 * image.c (parse_image_spec): Use Ffunctionp.
8997 * fns.c (concat, mapcar1): Accept byte-code-functions.
8999 * eval.c (Fsetq): Handle lexical vars.
9000 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
9001 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
9002 (FletX, Flet): Obey lexical binding.
9003 (Fcommandp): Handle closures.
9004 (Feval): New `lexical' arg.
9005 (eval_sub): New function extracted from Feval. Use it almost
9006 everywhere where Feval was used. Look up vars in lexical env.
9008 (Ffunctionp): Move from subr.el.
9009 (Ffuncall): Handle closures.
9010 (apply_lambda): Remove `eval_flags'.
9011 (funcall_lambda): Handle closures and new byte-code-functions.
9012 (Fspecial_variable_p): New function.
9013 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
9014 but without exporting it to Lisp.
9016 * doc.c (Fdocumentation, store_function_docstring):
9017 * data.c (Finteractive_form): Handle closures.
9019 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
9022 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
9024 (exec_byte_code): New function extracted from Fbyte_code to handle new
9025 calling convention for byte-code-functions. Add new byte-codes.
9027 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
9029 * alloc.c (Fmake_symbol): Init new `declared_special' field.
9031 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
9033 * xdisp.c (redisplay_internal): Fix prototype.
9035 2011-03-31 Eli Zaretskii <eliz@gnu.org>
9037 * xdisp.c (SCROLL_LIMIT): New macro.
9038 (try_scrolling): Use it when setting scroll_limit.
9039 Limit scrolling to 100 screen lines.
9040 (redisplay_window): Even when falling back on "recentering",
9041 position point in the window according to scroll-conservatively,
9042 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
9044 (try_scrolling): When point is above the window, allow searching
9045 as far as scroll_max, or one screenful, to compute vertical
9046 distance from PT to the scroll margin position. This prevents
9047 try_scrolling from unnecessarily failing when
9048 scroll-conservatively is set to a value slightly larger than the
9049 window height. Clean up the case of PT below the margin at bottom
9050 of window: scroll_max can no longer be INT_MAX. When aggressive
9051 scrolling is in use, don't let point enter the opposite scroll
9052 margin as result of the scroll.
9053 (syms_of_xdisp) <scroll-conservatively>: Document the
9054 threshold of 100 lines for never-recentering scrolling.
9056 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
9058 * dispextern.h (move_it_by_lines):
9059 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
9060 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
9061 (message_log_check_duplicate): Remove parameters `prev_bol' and
9062 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
9063 (redisplay_internal): Remove parameter `preserve_echo_area',
9064 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
9066 * indent.c (Fvertical_motion):
9067 * window.c (window_scroll_pixel_based, Frecenter):
9068 Don't pass `need_y_p' to `move_it_by_lines'.
9070 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
9072 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
9073 steal a few bits to be more compact.
9074 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
9075 Remove unneeded casts.
9077 * bytecode.c (Fbyte_code): CAR and CDR can GC.
9079 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
9081 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
9082 binding" message (bug#7967).
9084 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
9086 Fix more problems found by GCC 4.6.0's static checks.
9088 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
9089 Remove unused local var.
9091 * editfns.c (Fmessage_box): Remove unused local var.
9093 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
9094 (note_mode_line_or_margin_highlight, note_mouse_highlight):
9095 Omit unused local vars.
9096 * window.c (shrink_windows): Omit unused local var.
9097 * menu.c (digest_single_submenu): Omit unused local var.
9098 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
9099 Omit unused local var.
9101 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
9102 Don't assume string length fits in int.
9103 (keyremap_step, read_key_sequence): Use size_t for sizes.
9104 (read_key_sequence): Don't check last_real_key_start redundantly.
9106 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
9107 instead of alloca (Bug#8344).
9109 * eval.c (Fbacktrace): Don't assume nargs fits in int.
9110 (Fbacktrace_frame): Don't assume nframes fits in int.
9112 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
9114 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
9117 * term.c (produce_glyphless_glyph): Remove unnecessary test.
9119 * cm.c (calccost): Turn while-do into do-while, for clarity.
9121 * keyboard.c (syms_of_keyboard): Use the same style as later
9122 in this function when indexing through an array. This also
9123 works around GCC bug 48267.
9125 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
9127 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
9129 * chartab.c (sub_char_table_ref_and_range): Redo for slight
9130 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
9132 * keyboard.c, keyboard.h (num_input_events): Now size_t.
9133 This avoids undefined behavior on integer overflow, and is a bit
9134 more convenient anyway since it is compared to a size_t variable.
9136 Variadic C functions now count arguments with size_t, not int.
9137 This avoids an unnecessary limitation on 64-bit machines, which
9138 caused (substring ...) to crash on large vectors (Bug#8344).
9139 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
9140 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
9141 All variadic functions and their callers changed accordingly.
9142 (struct gcpro.nvars): Now size_t, not int. All uses changed.
9143 * data.c (arith_driver, float_arith_driver): Likewise.
9144 * editfns.c (general_insert_function): Likewise.
9145 * eval.c (struct backtrace.nargs, interactive_p)
9146 (internal_condition_case_n, run_hook_with_args, apply_lambda)
9147 (funcall_lambda, mark_backtrace): Likewise.
9148 * fns.c (concat): Likewise.
9149 * frame.c (x_set_frame_parameters): Likewise.
9150 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
9151 0 if not found, not -1. All callers changed.
9153 * alloc.c (garbage_collect): Don't assume stack size fits in int.
9154 (stack_copy_size): Now size_t, not int.
9155 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
9157 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
9159 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
9160 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9161 All callers changed.
9163 * lisp.h (multibyte_char_to_unibyte):
9164 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
9165 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9166 * character.h (CHAR_TO_BYTE8):
9167 * cmds.c (internal_self_insert):
9168 * editfns.c (general_insert_function):
9169 * keymap.c (push_key_description):
9170 * search.c (Freplace_match):
9171 * xdisp.c (message_dolog, set_message_1): All callers changed.
9173 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
9175 * keyboard.c (safe_run_hook_funcall): New function.
9176 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
9177 don't set the hook to nil, but remove the offending function instead.
9178 (Qcommand_hook_internal): Remove, unused.
9179 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
9180 Vcommand_hook_internal.
9182 * eval.c (enum run_hooks_condition): Remove.
9183 (funcall_nil, funcall_not): New functions.
9184 (run_hook_with_args): Call each function through a `funcall' argument.
9185 Remove `cond' argument, now redundant.
9186 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
9187 (Frun_hook_with_args_until_failure): Adjust accordingly.
9188 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
9190 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
9192 * dispextern.h (string_buffer_position): Remove declaration.
9194 * print.c (strout): Remove parameter `multibyte', unused since
9195 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
9197 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
9198 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
9199 All callers changed.
9201 * w32.c (_wsa_errlist): Use braces for struct initializers.
9203 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
9204 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
9205 All callers changed.
9206 (string_buffer_position): Likewise. Also, make static (it's never
9207 used outside xdisp.c).
9208 (cursor_row_p): Remove parameter `w', unused since
9209 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
9210 (decode_mode_spec): Remove parameter `precision', introduced during
9211 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
9212 All callers changed.
9214 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9216 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
9218 2011-03-27 Anders Lindgren <andlind@gmail.com>
9220 * nsterm.m (ns_menu_bar_is_hidden): New variable.
9221 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
9222 (ns_update_auto_hide_menu_bar): New functions.
9223 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
9224 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
9225 ns_constrain_all_frames.
9226 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
9227 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
9229 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9231 * nsmenu.m (runDialogAt): Remove argument to timer_check.
9233 2011-03-27 Glenn Morris <rgm@gnu.org>
9235 * syssignal.h: Replace RETSIGTYPE with void.
9236 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
9237 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
9238 Replace SIGTYPE with void everywhere.
9239 * s/usg5-4-common.h (SIGTYPE): Remove definition.
9240 * s/template.h (SIGTYPE): Remove commented out definition.
9242 2011-03-26 Eli Zaretskii <eliz@gnu.org>
9244 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
9245 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
9247 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
9249 * w32.c (read_unc_volume): Use parameter `henum', instead of
9250 global variable `wget_enum_handle'.
9252 * keymap.c (describe_vector): Remove parameters `indices' and
9253 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
9254 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
9256 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
9258 * keyboard.c (timer_check): Remove parameter `do_it_now',
9259 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
9260 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
9261 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
9263 * keyboard.c (read_char):
9264 * w32menu.c (w32_menu_display_help):
9265 * xmenu.c (show_help_event, menu_help_callback):
9266 Adjust calls to `show_help_echo'.
9268 * gtkutil.c (xg_maybe_add_timer):
9269 * keyboard.c (readable_events):
9270 * process.c (wait_reading_process_output):
9271 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
9273 * insdel.c (adjust_markers_gap_motion):
9274 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
9275 (gap_left, gap_right): Don't call it.
9277 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
9279 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
9280 incurred during fontification.
9282 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9284 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
9285 (DEFVAR_PER_BUFFER): Don't pass it.
9287 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
9288 (scrolling_window): Don't pass it.
9290 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9292 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
9294 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
9296 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
9297 of variables specific to SELinux and computation of `encoded_absname'.
9299 * image.c (XPutPixel): Remove unused variable `height'.
9301 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9303 * unexw32.c (get_section_info): Remove unused variable `section'.
9305 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9306 (system_process_attributes): Remove unused variable `sess'.
9307 (sys_read): Remove unused variable `err'.
9309 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9310 (w32_wnd_proc): Remove unused variable `isdead'.
9311 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9312 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9313 (x_create_tip_frame): Remove unused variable `tem'.
9315 * w32inevt.c (w32_console_read_socket):
9316 Remove unused variable `no_events'.
9318 * w32term.c (x_draw_composite_glyph_string_foreground):
9319 Remove unused variable `width'.
9321 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
9323 * w32term.c (x_set_glyph_string_clipping):
9324 Don't pass uninitialized region to CombineRgn.
9326 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
9328 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9329 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9330 (Fx_close_connection): Remove unused variable `i'.
9332 * w32font.c (w32font_draw): Return number of glyphs.
9333 (w32font_open_internal): Remove unused variable `i'.
9334 (w32font_driver): Add missing initializer.
9336 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9337 (fill_in_menu): Remove unused variable `items_added'.
9339 * w32term.c (last_mouse_press_frame): Remove static global variable.
9340 (w32_clip_to_row): Remove unused variable `f'.
9341 (x_delete_terminal): Remove unused variable `i'.
9343 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9344 (NOTHING): Remove unused static global variable.
9345 (uniscribe_check_otf): Remove unused variable `table'.
9346 (uniscribe_font_driver): Add missing initializers.
9348 2011-03-23 Julien Danjou <julien@danjou.info>
9350 * term.c (Fsuspend_tty, Fresume_tty):
9351 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9352 * window.c (temp_output_buffer_show):
9353 * insdel.c (signal_before_change):
9354 * frame.c (Fhandle_switch_frame):
9355 * fileio.c (Fdo_auto_save):
9356 * emacs.c (Fkill_emacs):
9357 * editfns.c (save_excursion_restore):
9358 * cmds.c (internal_self_insert):
9359 * callint.c (Fcall_interactively):
9360 * buffer.c (Fkill_all_local_variables):
9361 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9363 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
9364 unconditionally since it does the check itself.
9366 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
9368 Fix more problems found by GCC 4.5.2's static checks.
9370 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9371 the first time through the loop, since we know p0 < p1 then.
9372 This also avoids a gcc -Wstrict-overflow warning.
9374 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9375 leading to a memory leak, possible in functions like
9376 load_charset_map_from_file that can allocate an unbounded number
9377 of objects (Bug#8318).
9379 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9380 that could (at least in theory) be that large.
9382 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9383 This is less likely to overflow, and avoids undefined behavior if
9384 overflow does occur. All callers changed. Use strtoul to scan
9385 for the unsigned long integer.
9386 (pint2hrstr): Simplify and tune code slightly.
9387 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
9389 * scroll.c (do_scrolling): Work around GCC bug 48228.
9390 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9392 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9393 This also avoids a warning with gcc -Wstrict-overflow.
9394 (validate_x_resource_name): Simplify count usage.
9395 This also avoids a warning with gcc -Wstrict-overflow.
9397 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9400 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
9402 * process.c (Fmake_network_process): Use socklen_t, not int,
9403 where POSIX says socklen_t is required in portable programs.
9404 This fixes a porting bug on hosts like 64-bit HP-UX, where
9405 socklen_t is wider than int (Bug#8277).
9406 (Fmake_network_process, server_accept_connection):
9407 (wait_reading_process_output, read_process_output):
9410 * process.c: Rename or move locals to avoid shadowing.
9411 (list_processes_1, Fmake_network_process):
9412 (read_process_output_error_handler, exec_sentinel_error_handler):
9413 Rename or move locals.
9414 (Fmake_network_process): Define label "retry_connect" only if needed.
9415 (Fnetwork_interface_info): Fix pointer signedness.
9416 (process_send_signal): Add cast to avoid pointer signedness problem.
9417 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
9418 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
9420 Make tparam.h and terminfo.c consistent.
9421 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9422 Include tparam.h instead, since it declares them.
9423 * cm.h (PC): Remove extern decl; tparam.h now does this.
9424 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9425 * terminfo.c: Include tparam.h, to check interfaces.
9426 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9427 (tparam): Adjust signature to match interface in tparam.h;
9428 this removes some undefined behavior. Check that outstring and len
9429 are zero, which they always are with Emacs.
9430 * tparam.h (PC, BC, UP): New extern decls.
9432 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
9433 (xftfont_open): Rename locals to avoid shadowing.
9435 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
9436 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9437 (OTF_TAG_SYM): Omit macro if not needed.
9438 (ftfont_list): Remove unused local.
9439 (get_adstyle_property, ftfont_pattern_entity):
9440 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9441 Rename locals to avoid shadowing.
9443 * xfont.c (xfont_list_family): Mark var as initialized.
9445 * xml.c (make_dom): Now static.
9447 * composite.c (composition_compute_stop_pos): Rename local to
9449 (composition_reseat_it): Remove unused locals.
9450 (find_automatic_composition, composition_adjust_point): Likewise.
9451 (composition_update_it): Mark var as initialized.
9452 (find_automatic_composition): Mark vars as initialized,
9453 with a FIXME (Bug#8290).
9455 character.h: Rename locals to avoid shadowing.
9456 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9457 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9458 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9459 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9462 * textprop.c (property_change_between_p): Remove; unused.
9464 * intervals.c (interval_start_pos): Now static.
9466 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9468 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9469 Rename locals to avoid shadowing.
9471 * sound.c (wav_play, au_play, Fplay_sound_internal):
9472 Fix pointer signedness.
9473 (alsa_choose_format): Remove unused local var.
9474 (wav_play): Initialize a variable to 0, to prevent undefined
9475 behavior (Bug#8278).
9477 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9479 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9481 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9482 clobbering (Bug#8298).
9483 * sysdep.c (sys_subshell): Likewise.
9484 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9486 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9487 This should get cleaned up, so that child_setup has the
9488 same signature on all platforms.
9490 * callproc.c (call_process_cleanup): Now static.
9491 (relocate_fd): Rename locals to avoid shadowing.
9493 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9495 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9496 not to be necessary, and produces flickering.
9498 2011-03-20 Glenn Morris <rgm@gnu.org>
9500 * config.in: Remove file.
9502 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9504 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9505 are now in src/globals.h.
9506 (syms_of_minibuf): Remove spurious & from previous change.
9508 2011-03-20 Leo Liu <sdl.web@gmail.com>
9510 * minibuf.c (completing-read-function): New variable.
9511 (completing-read-default): Rename from completing-read.
9512 (completing-read): Call completing-read-function.
9514 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9516 * xfaces.c (Fx_load_color_file):
9517 Read color file from absolute filename (bug#8250).
9519 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9521 * makefile.w32-in: Update dependencies.
9523 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9525 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9527 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9529 Fix more problems found by GCC 4.5.2's static checks.
9531 * process.c (make_serial_process_unwind, send_process_trap):
9532 (sigchld_handler): Now static.
9534 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9535 That way, the code declares only the vars that it needs.
9536 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9537 * s/cygwin.h (PTY_ITERATION): Likewise.
9538 * s/darwin.h (PTY_ITERATION): Likewise.
9539 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9541 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9542 * process.c (allocate_pty): Don't declare stb unless it's needed.
9544 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9545 (CONSTANTLIM): Remove; unused.
9546 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9547 Define only if needed.
9549 * unexelf.c (unexec): Name an expression,
9550 to avoid gcc -Wbad-function-cast warning.
9551 Use a different way to cause a compilation error if anyone uses
9552 n rather than nn, a way that does not involve shadowing.
9553 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9555 * deps.mk (unexalpha.o): Remove; unused.
9557 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9558 * unexec.h: New file.
9559 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9560 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9562 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9563 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9564 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9565 Change as necessary to match prototype in unexec.h.
9567 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9569 (back_comment, skip_chars): Mark vars as initialized.
9571 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9572 Rename locals to avoid shadowing.
9574 * lread.c (read1): Rewrite so as not to use empty "else".
9575 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9577 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9579 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9580 warning when compiling print.c.
9582 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9583 instead of using an uninitialized var.
9584 (font_sort_entities): Mark var as initialized.
9586 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9588 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9589 pointers to constants.
9590 (font_parse_fcname): Remove unused vars.
9591 (font_delete_unmatched): Now static.
9592 (font_get_spec): Remove; unused.
9593 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9594 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9595 Rename or move locals to avoid shadowing.
9597 * fns.c (require_nesting_list, require_unwind): Now static.
9598 (Ffillarray): Rename locals to avoid shadowing.
9600 * floatfns.c (domain_error2): Define only if needed.
9601 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9603 * alloc.c (mark_backtrace): Move decl from here ...
9604 * lisp.h: ... to here, so that it can be checked.
9606 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9607 (Fdefvar): Rewrite so as not to use empty "else".
9608 (lisp_indirect_variable): Name an expression,
9609 to avoid gcc -Wbad-function-cast warning.
9610 (Fdefvar): Rename locals to avoid shadowing.
9612 * callint.c (quotify_arg, quotify_args): Now static.
9613 (Fcall_interactively): Rename locals to avoid shadowing.
9614 Use const pointer when appropriate.
9616 * lisp.h (get_system_name, get_operating_system_release):
9617 Move decls here, to check interfaces.
9618 * process.c (get_operating_system_release): Move decl to lisp.h.
9619 * xrdb.c (get_system_name): Likewise.
9620 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9621 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9622 some of which prompt warnings from gcc -Wbad-function-cast.
9623 (Fformat_time_string, Fencode_time, Finsert_char):
9624 (Ftranslate_region_internal, Fformat):
9625 Rename or remove local vars to avoid shadowing.
9626 (Ftranslate_region_internal): Mark var as initialized.
9628 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9631 * lisp.h (eassert): Check that the argument compiles, even if
9632 ENABLE_CHECKING is not defined.
9634 * data.c (Findirect_variable): Name an expression, to avoid
9635 gcc -Wbad-function-cast warning.
9636 (default_value, arithcompare, arith_driver, arith_error): Now static.
9637 (store_symval_forwarding): Rename local to avoid shadowing.
9638 (Fmake_variable_buffer_local, Fmake_local_variable):
9639 Mark variables as initialized.
9640 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9642 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9643 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9644 Rename locals to avoid shadowing.
9645 (mark_stack): Move local variables into the #ifdef region where
9647 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9648 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9650 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9651 (GC_STRING_CHARS): Remove; not used.
9652 (Fmemory_limit): Cast sbrk's returned value to char *.
9654 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9655 avoids undefined behavior in theory.
9657 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9659 Use functions, not macros, for up- and down-casing (Bug#8254).
9660 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9661 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9662 to use the following functions instead of these macros.
9663 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9664 EMACS_INT, since callers assume the returned value fits in int.
9665 (upcase1): Likewise, for UPCASE_TABLE.
9666 (uppercasep, lowercasep, upcase): New static inline functions.
9667 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9668 the race-condition problem in the old DOWNCASE.
9670 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9671 Rename locals to avoid shadowing.
9672 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9673 (regex_compile, re_search_2, re_match_2_internal):
9674 Remove unused local vars.
9675 (FREE_VAR): Rewrite so as not to use empty "else",
9676 which gcc can warn about.
9677 (regex_compile, re_match_2_internal): Mark locals as initialized.
9678 (RETALLOC_IF): Define only if needed.
9679 (WORDCHAR_P): Likewise. This one is never needed, but is used
9680 only in a comment talking about a compiler bug, so put inside
9681 the #if 0 of that comment.
9682 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9683 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9686 * search.c (boyer_moore): Rename locals to avoid shadowing.
9687 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9688 (PREV_CHAR_BOUNDARY): Likewise.
9690 * search.c (simple_search): Remove unused var.
9692 * dired.c (compile_pattern): Move decl from here ...
9693 * lisp.h: ... to here, so that it can be checked.
9694 (struct re_registers): New forward decl.
9696 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9698 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9700 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9701 Rename locals to avoid shadowing.
9702 (Fvertical_motion): Mark locals as initialized.
9704 * casefiddle.c (casify_object, casify_region): Now static.
9705 (casify_region): Mark local as initialized.
9707 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9709 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9710 New macros, so that the caller can use some names other than
9711 gcpro1, gcpro2, etc.
9712 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9714 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9715 argument, for consistency with GCPRO2_VAR, etc: it is now the
9716 prefix of the variable, not the variable itself. All uses
9718 * dired.c (directory_files_internal, file_name_completion):
9719 Rename locals to avoid shadowing.
9721 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9722 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9723 dired.c's scmp function, had undefined behavior.
9724 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9725 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9726 * buffer.h: ... to here, because these macros use current_buffer,
9727 and the new implementation with inline functions needs to have
9728 current_buffer in scope now, rather than later when the macros
9730 (downcase, upcase1): New static inline functions.
9731 (DOWNCASE, UPCASE1): Reimplement using these functions.
9732 This avoids undefined behavior in expressions like
9733 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9734 from race conditions in accessing the global variables
9735 case_temp1 and case_temp2.
9736 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9737 * lisp.h (case_temp1, case_temp2): Remove their decls.
9738 * character.h (ASCII_CHAR_P): Move from here ...
9739 * lisp.h: ... to here, so that the inline functions mentioned
9742 * dired.c (directory_files_internal_unwind): Now static.
9744 * fileio.c (file_name_as_directory, directory_file_name):
9745 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9747 (file_name_as_directory): Use const pointers when appropriate.
9748 (Fexpand_file_name): Likewise. In particular, newdir might
9749 point at constant storage, so make it a const pointer.
9750 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9751 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9753 (Fset_file_times, Finsert_file_contents, auto_save_error):
9754 Rename locals to avoid shadowing.
9756 * minibuf.c (choose_minibuf_frame_1): Now static.
9757 (Ftry_completion, Fall_completions): Rename or remove locals
9760 * marker.c (bytepos_to_charpos): Remove; unused.
9762 * lisp.h (verify_bytepos, count_markers): New decls,
9763 so that gcc does not warn that these functions aren't declared.
9765 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9766 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9767 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9768 (copy_text): Remove unused local var.
9770 * filelock.c (within_one_second): Now static.
9771 (lock_file_1): Rename local to avoid shadowing.
9773 * buffer.c (fix_overlays_before): Mark locals as initialized.
9774 (fix_start_end_in_overlays): Likewise. This function should be
9775 simplified by using pointers-to-pointers, but that's a different
9777 (switch_to_buffer_1): Now static.
9778 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9779 (report_overlay_modification): Rename locals to avoid shadowing.
9781 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9782 Fix pointer signedness issue.
9783 (sys_subshell): Mark local as volatile if checking for lint,
9784 to suppress a gcc -Wclobbered warning that does not seem to be right.
9785 (MAXPATHLEN): Define only if needed.
9787 * process.c (serial_open, serial_configure): Move decls from here ...
9788 * systty.h: ... to here, so that they can be checked.
9790 * fns.c (get_random, seed_random): Move extern decls from here ...
9791 * lisp.h: ... to here, so that they can be checked.
9793 * sysdep.c (reset_io): Now static.
9794 (wait_for_termination_signal): Remove; unused.
9796 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9797 (copy_keymap_item, append_key, push_text_char_description):
9799 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9800 (DENSE_TABLE_SIZE): Remove; unused.
9801 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9802 (describe_map_tree):
9803 Rename locals to avoid shadowing.
9805 * keyboard.c: Declare functions static if they are not used elsewhere.
9806 (echo_char, echo_dash, cmd_error, top_level_2):
9807 (poll_for_input, handle_async_input): Now static.
9808 (read_char, kbd_buffer_get_event, make_lispy_position):
9809 (make_lispy_event, make_lispy_movement, apply_modifiers):
9810 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9811 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9812 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9813 (read_key_sequence, read_char): Mark locals as initialized.
9814 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9816 * keyboard.h (make_ctrl_char): New decl.
9817 (mark_kboards): Move decl here ...
9818 * alloc.c (mark_kboards): ... from here.
9820 * lisp.h (force_auto_save_soon): New decl.
9822 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9823 (DEFINE_DUMMY_FUNCTION): New macro.
9824 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9826 (main): Add casts to avoid warnings
9827 if GCC considers string literals to be constants.
9829 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9831 * dbusbind.c: Pointer signedness fixes.
9832 (xd_signature, xd_append_arg, xd_initialize):
9833 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9834 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9835 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9836 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9838 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9839 if GCC considers string literals to be constants.
9840 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9842 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9844 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9845 (print_preprocess, print_object): New macro to fix last change.
9847 * print.c (print_preprocess): Don't forget font objects.
9849 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9851 * emacs.c (USAGE3): Doc fixes.
9853 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9855 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9858 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9860 * lisp.h (VWindow_system, Qfile_name_history):
9861 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9862 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9863 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9865 * w32select.c: Don't #include "keyboard.h".
9866 (run_protected): Add extern declaration for waiting_for_input.
9868 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9869 * w32console.c (detect_input_pending, read_input_pending)
9870 (encode_terminal_code):
9871 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9872 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9873 (w32_system_caret_y, Qfile_name_history):
9874 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9875 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9876 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9877 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9878 * w32proc.c (Qlocal, report_file_error):
9879 * w32term.c (Vwindow_system, updating_frame):
9880 * w32uniscribe.c (initialized, uniscribe_font_driver):
9881 Remove unneeded extern declarations.
9883 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9885 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9887 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9889 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9890 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9891 These macros can no longer be used for assignment.
9893 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9894 Assign struct members directly, instead of using BUF_BEGV etc.
9895 (record_buffer_markers, fetch_buffer_markers): New functions for
9896 recording and fetching special buffer markers.
9897 (set_buffer_internal_1, set_buffer_temp): Use them.
9899 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9901 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9903 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9904 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9906 * xdisp.c (hscroll_window_tree):
9907 (reconsider_clip_changes): Use PT instead of BUF_PT.
9909 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9911 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9912 $(EMACS_ROOT)/lib/intprops.h.
9914 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9916 Fix more problems found by GCC 4.5.2's static checks.
9918 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9919 to unsigned char * to avoid compiler diagnostic.
9920 (xg_free_frame_widgets): Make it clear that a local variable is
9921 needed only if USE_GTK_TOOLTIP.
9922 (gdk_window_get_screen): Make it clear that this macro is needed
9923 only if USE_GTK_TOOLTIP.
9924 (int_gtk_range_get_value): New function, which avoids a diagnostic
9925 from gcc -Wbad-function-cast.
9926 (xg_set_toolkit_scroll_bar_thumb): Use it.
9927 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9928 diagnostic from gcc -Wbad-function-cast.
9929 (get_utf8_string, xg_get_file_with_chooser):
9930 Rename locals to avoid shadowing.
9931 (create_dialog): Move locals to avoid shadowing.
9933 * xgselect.c (xg_select): Remove unused var.
9935 * image.c (four_corners_best): Mark locals as initialized.
9936 (gif_load): Initialize transparent_p to zero (Bug#8238).
9937 Mark another local as initialized.
9938 (my_png_error, my_error_exit): Mark with NO_RETURN.
9940 * image.c (clear_image_cache): Now static.
9941 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9942 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9943 (x_edge_detection): Remove unnecessary cast that
9944 gcc -Wbad-function-cast diagnoses.
9945 (gif_load): Fix pointer signedness.
9946 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9947 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9949 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9951 Improve quality of tests for time stamp overflow.
9952 For example, without this patch (encode-time 0 0 0 1 1
9953 1152921504606846976) returns the obviously-bogus value (-948597
9954 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9955 reports time overflow. See
9956 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9957 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9958 * editfns.c: Include limits.h and intprops.h.
9959 (TIME_T_MIN, TIME_T_MAX): New macros.
9960 (time_overflow): Move earlier, to before first use.
9961 (hi_time, lo_time): New functions, for an accurate test for
9963 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9964 (Fget_internal_run_time): Don't assume time_t fits in int.
9965 (make_time): Use list2 instead of Fcons twice.
9966 (Fdecode_time): More accurate test for out-of-range times.
9967 (check_tm_member): New function.
9968 (Fencode_time): Use it, to test for out-of-range times.
9969 (lisp_time_argument): Don't rely on undefined left-shift and
9970 right-shift behavior when checking for time stamp overflow.
9972 * editfns.c (time_overflow): New function, refactoring common code.
9973 (Fformat_time_string, Fdecode_time, Fencode_time):
9974 (Fcurrent_time_string): Use it.
9976 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9977 * dired.c (make_time): Move to ...
9978 * editfns.c (make_time): ... here.
9979 * systime.h: Note the move.
9981 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9983 * fringe.c (update_window_fringes): Remove unused variables.
9985 * unexmacosx.c (copy_data_segment): Also copy __got section.
9988 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9990 * termcap.c [MSDOS]: Include "msdos.h".
9991 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9992 Constify `char *' arguments and their references according to
9993 prototypes in tparam.h.
9995 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9997 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9998 Adapt all references accordingly.
10000 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
10002 2011-03-11 Tom Tromey <tromey@redhat.com>
10004 * buffer.c (syms_of_buffer): Remove obsolete comment.
10006 2011-03-11 Eli Zaretskii <eliz@gnu.org>
10008 * termhooks.h (encode_terminal_code): Declare prototype.
10010 * msdos.c (encode_terminal_code): Don't declare prototype.
10012 * term.c (encode_terminal_code): Now external again, used by
10013 w32console.c and msdos.c.
10015 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
10016 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
10018 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
10020 Fix some minor problems found by GCC 4.5.2's static checks.
10022 * fringe.c (update_window_fringes): Mark locals as initialized
10024 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
10026 * alloc.c (mark_fringe_data): Move decl from here ...
10027 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
10028 to check its interface.
10029 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
10031 * fontset.c (free_realized_fontset): Now static.
10032 (Fset_fontset_font): Rename local to avoid shadowing.
10033 (fontset_font): Mark local as initialized.
10034 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
10036 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
10038 * xselect.c (x_disown_buffer_selections): Remove; not used.
10039 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
10040 (x_own_selection, Fx_disown_selection_internal): Rename locals
10041 to avoid shadowing.
10042 (x_handle_dnd_message): Remove local to avoid shadowing.
10044 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
10045 so that the caller can use some name other than gcpro1.
10046 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
10047 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
10048 (Fx_backspace_delete_keys_p):
10049 Use them to avoid shadowing, and rename vars to avoid shadowing.
10050 (x_decode_color, x_set_name, x_window): Now static.
10051 (Fx_create_frame): Add braces to silence GCC warning.
10052 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
10053 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
10054 Remove unused locals.
10055 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
10056 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
10057 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
10060 * xterm.h (x_mouse_leave): New decl.
10062 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
10063 Remove unused functions.
10064 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
10065 (x_calc_absolute_position): Now static.
10066 (XTread_socket): Don't define label "out" unless it's used.
10067 Don't declare local "event" unless it's used.
10068 (x_iconify_frame, x_free_frame_resources): Don't declare locals
10069 unless they are used.
10070 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
10071 (x_fatal_error_signal): Remove; not used.
10072 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
10073 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
10074 (x_error_catcher, x_connection_closed, x_error_handler):
10075 (x_error_quitter, xembed_send_message, x_iconify_frame):
10076 (my_log_handler): Rename locals to avoid shadowing.
10077 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
10078 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
10080 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
10081 Rename or move locals to avoid shadowing.
10082 (tty_defined_color, merge_face_heights): Now static.
10083 (free_realized_faces_for_fontset): Remove; not used.
10084 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
10085 does not deduce is never used uninitialized.
10086 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
10087 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
10089 * terminal.c (store_terminal_param): Now static.
10091 * xmenu.c (menu_highlight_callback): Now static.
10092 (set_frame_menubar): Remove unused local.
10093 (xmenu_show): Rename parameter to avoid shadowing.
10094 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
10095 since they might point to immutable storage.
10096 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
10097 since it's unused otherwise.
10099 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
10100 Add a FIXME, since the code still doesn't look right. (Bug#8215)
10101 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
10102 avoids a gcc -Wuninitialized diagnostic.
10103 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
10104 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
10105 does not deduce are never used uninitialized.
10107 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
10109 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
10110 * window.c (window_loop, size_window):
10111 (run_window_configuration_change_hook, enlarge_window): Likewise.
10113 * window.c (display_buffer): Now static.
10114 (size_window): Mark variables that gcc -Wuninitialized
10115 does not deduce are never used uninitialized.
10116 * window.h (check_all_windows): New decl, to forestall
10117 gcc -Wmissing-prototypes diagnostic.
10118 * dispextern.h (bidi_dump_cached_states): Likewise.
10120 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
10122 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
10123 Include <limits.h>.
10124 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
10125 and to avoid gcc -Wuninitialized warning.
10126 (load_charset_map): Mark variables that gcc -Wuninitialized
10127 does not deduce are never used uninitialized.
10128 (load_charset): Abort instead of using uninitialized var (Bug#8229).
10130 * coding.c (coding_set_source, coding_set_destination):
10131 Use "else { /* comment */ }" rather than "else /* comment */;"
10132 for clarity, and to avoid gcc -Wempty-body warning.
10133 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
10134 a block, when the outer 'i' will do.
10135 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
10136 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
10137 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
10138 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
10139 (Fdecode_sjis_char, Fdefine_coding_system_internal):
10140 Rename locals to avoid shadowing.
10141 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
10142 * coding.c (emacs_mule_char, encode_invocation_designation):
10143 Now static, since they're not used elsewhere.
10144 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
10145 (decode_coding_object, encode_coding_object, detect_coding_system):
10146 (decode_coding_emacs_mule): Mark variables that gcc
10147 -Wuninitialized does not deduce are never used uninitialized.
10148 (detect_coding_iso_2022): Initialize a local variable that might
10149 be used uninitialized. Leave a FIXME because it's not clear that
10150 this initialization is needed. (Bug#8211)
10151 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
10152 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
10153 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
10154 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
10155 Remove unused macros.
10157 * category.c (hash_get_category_set): Remove unused local var.
10158 (copy_category_table): Now static, since it's not used elsewhere.
10159 * character.c (string_count_byte8): Likewise.
10161 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
10162 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
10164 * chartab.c (copy_sub_char_table): Now static, since it's not used
10166 (sub_char_table_ref_and_range, char_table_ref_and_range):
10167 Rename locals to avoid shadowing.
10168 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
10170 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
10171 (BIDI_BOB): Remove unused macro.
10173 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
10174 deduce are never used uninitialized.
10175 * term.c (encode_terminal_code): Likewise.
10177 * term.c (encode_terminal_code): Now static. Remove unused local.
10179 * tparam.h: New file.
10180 * term.c, tparam.h: Include it.
10181 * deps.mk (term.o, tparam.o): Depend on tparam.h.
10182 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
10183 Move these decls to tparam.h, and make them agree with what
10184 is actually in tparam.c. The previous trick of using incompatible
10185 decls in different modules does not conform to the C standard.
10186 All callers of tparam changed to use tparam's actual API.
10187 * tparam.c (tparam1, tparam, tgoto):
10188 Use const pointers where appropriate.
10190 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
10191 * cm.h (struct cm): Likewise.
10192 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
10193 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
10194 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
10195 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
10196 (turn_on_face, init_tty): Likewise.
10197 * termchar.h (struct tty_display_info): Likewise.
10199 * term.c (term_mouse_position): Rename local to avoid shadowing.
10201 * alloc.c (mark_ttys): Move decl from here ...
10202 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
10204 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
10206 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
10208 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
10210 * search.c (compile_pattern_1): Remove argument regp, unused since
10211 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
10212 (compile_pattern): Don't pass it.
10214 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
10216 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
10217 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
10219 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
10221 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
10223 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
10224 gdk_window_get_screen, gdk_window_get_geometry,
10225 gdk_x11_window_lookup_for_display and GDK_KEY_g.
10226 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
10227 (xg_get_pixbuf_from_pixmap): New function.
10228 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
10229 to Pixmap, take frame as parameter, remove GdkColormap parameter.
10230 Call xg_get_pixbuf_from_pixmap instead of
10231 gdk_pixbuf_get_from_drawable.
10232 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
10233 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
10234 (xg_check_special_colors): Use GtkStyleContext and its functions
10236 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
10237 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
10238 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
10239 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
10240 Call gtk_widget_get_preferred_size.
10241 (xg_frame_resized): gdk_window_get_geometry only takes 5
10243 (xg_win_to_widget, xg_event_is_for_menubar):
10244 Call gdk_x11_window_lookup_for_display.
10245 (xg_set_widget_bg): New function.
10246 (delete_cb): New function.
10247 (xg_create_frame_widgets): Connect delete-event to delete_cb.
10248 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
10249 (xg_set_background_color): Call xg_set_widget_bg.
10250 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
10251 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
10252 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
10253 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
10255 (update_frame_tool_bar): Call gtk_widget_hide.
10256 (xg_initialize): Use GDK_KEY_g.
10258 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
10260 (x_session_initialize): Call gdk_x11_set_sm_client_id.
10262 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
10263 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
10264 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
10266 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
10268 * w32xfns.c (select_palette): Check success of RealizePalette against
10269 GDI_ERROR, not zero.
10271 See ChangeLog.11 for earlier changes.
10273 ;; Local Variables:
10277 Copyright (C) 2011-2012 Free Software Foundation, Inc.
10279 This file is part of GNU Emacs.
10281 GNU Emacs is free software: you can redistribute it and/or modify
10282 it under the terms of the GNU General Public License as published by
10283 the Free Software Foundation, either version 3 of the License, or
10284 (at your option) any later version.
10286 GNU Emacs is distributed in the hope that it will be useful,
10287 but WITHOUT ANY WARRANTY; without even the implied warranty of
10288 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10289 GNU General Public License for more details.
10291 You should have received a copy of the GNU General Public License
10292 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.