1 2011-07-09 Paul Eggert <eggert@cs.ucla.edu>
3 * image.c: Integer signedness and overflow and related fixes.
4 This is not an exhaustive set of fixes, but it's time to
6 (lookup_pixel_color, check_image_size): Remove redundant decls.
7 (check_image_size): Don't assume that arbitrary EMACS_INT values
8 fit in 'int', or that arbitrary 'double' values fit in 'int'.
9 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
10 (tiff_load, imagemagick_load_image):
11 Check for overflow in size calculations.
12 (x_create_x_image_and_pixmap): Remove unnecessary test for
13 xmalloc returning NULL; that can't happen.
14 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
15 (xpm_color_bucket): Use better integer hashing function.
16 (xpm_cache_color): Don't possibly over-allocate memory.
17 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
19 Use ptrdiff_t, not int or size_t, to record sizes.
20 (png_load): Don't assume values greater than 2**31 fit in 'int'.
21 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
22 either works, as we prefer signed integers.
23 (tiff_read_from_memory, tiff_write_from_memory):
24 Return tsize_t, not size_t, since that's what the TIFF API wants.
25 (tiff_read_from_memory): Don't fail simply because the read would
26 go past EOF; instead, return a short read.
27 (tiff_load): Omit no-longer-needed casts.
28 (Fimagemagick_types): Don't assume size fits into 'int'.
30 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
32 Improve hashing quality when configured --with-wide-int.
33 * fns.c (hash_string): New function, taken from sxhash_string.
34 Do not discard information about ASCII character case; this
35 discarding is no longer needed.
36 (sxhash-string): Use it. Change sig to match it. Caller changed.
38 * lread.c (hash_string): Remove, since we now use fns.c's version.
39 The fns.c version returns a wider integer if --with-wide-int is
40 specified, so this should help the quality of the hashing a bit.
42 2011-07-07 Paul Eggert <eggert@cs.ucla.edu>
44 * emacs.c: Integer overflow minor fix.
45 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
46 Define only if GNU_LINUX.
47 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
49 * dispnew.c: Integer signedness and overflow fixes.
50 Remove unnecessary forward decls, that were a maintenance hassle.
51 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
53 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
54 (scrolling_window): Use ptrdiff_t, not int, for byte count.
55 (prepare_desired_row, line_draw_cost):
56 Use int, not unsigned, where either works.
57 (save_current_matrix, restore_current_matrix):
58 Use ptrdiff_t, not size_t, where either works.
59 (init_display): Check for overflow more accurately, and without
60 relying on undefined behavior.
62 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
63 Remove, replacing with the new symbols in lisp.h. All uses changed.
64 * fileio.c (make_temp_name):
65 * filelock.c (lock_file_1, lock_file):
66 * xdisp.c (message_dolog):
67 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
69 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
70 replacing the pWIDE etc. symbols removed from editfns.c.
72 * keyboard.h (num_input_events): Now uintmax_t.
73 This is (very slightly) less likely to mess up due to wraparound.
76 * buffer.c: Integer signedness fixes.
77 (alloc_buffer_text, enlarge_buffer_text):
78 Use ptrdiff_t rather than size_t when either will do, as we prefer
81 * bidi.c: Integer signedness and overflow fixes.
82 (bidi_cache_idx, bidi_cache_last_idx, bidi_cache_fetch_state)
83 (bidi_cache_search, bidi_cache_find_level_change)
84 (bidi_cache_iterator_state, bidi_cache_find, bidi_find_other_level_edge)
85 (bidi_dump_cached_states):
86 Don't arbitrarily limit cache indexes to int; use ptrdiff_t instead.
87 (bidi_cache_size): Use ptrdiff_t rather than size_t, as we prefer
89 (elsz): Make it a (signed) constant.
90 (bidi_cache_iterator_state): Check for size-calculation overflow.
92 * alloc.c: Integer signedness and overflow fixes.
93 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
94 (__malloc_size_t): Default to size_t, not to int.
95 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
96 (Fgarbage_collect, mark_object_loop_halt, mark_object):
97 Prefer ptrdiff_t to size_t when either would do, as we prefer
99 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
100 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
101 Now const. Initialize with values that are in range even if char
103 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
104 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
105 These functions do the right thing with sizes > 2**32.
106 (check_depth): Now ptrdiff_t, not int.
107 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
108 Adjust to new way of storing sizes. Check for size overflow bugs
110 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
111 slightly wrong anyway, as it missed one instance of
112 XMALLOC_OVERRUN_CHECK_OVERHEAD.
113 (refill_memory_reserve): Omit needless cast to size_t.
114 (mark_object_loop_halt): Mark as externally visible.
116 * xselect.c: Integer signedness and overflow fixes.
117 (Fx_register_dnd_atom, x_handle_dnd_message):
118 Use ptrdiff_t, not size_t, since we prefer signed.
119 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
120 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
121 x_dnd_atoms_size and x_dnd_atoms_length.
123 * doprnt.c: Prefer signed to unsigned when either works.
127 * xdisp.c (vmessage):
128 Use ptrdiff_t, not size_t, when using or implementing doprnt,
129 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
130 prefer signed arithmetic to avoid comparison confusion.
131 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
134 Assume freestanding C89 headers, string.h, stdlib.h.
135 * data.c, doprnt.c, floatfns.c, print.c:
136 Include float.h unconditionally.
137 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
138 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
139 * regex.c: Likewise for stddef.h, string.h.
140 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
141 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
142 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
143 (STDC_HEADERS): Remove obsolete defines.
144 * sysdep.c: Include limits.h unconditionally.
146 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
148 Assume support for memcmp, memcpy, memmove, memset.
149 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
150 * regex.c (memcmp, memcpy):
151 Remove; we assume C89 now.
153 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
154 (__malloc_safe_bcopy): Remove; no longer needed.
156 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
157 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
158 well either way, and we prefer signed to unsigned.
160 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
162 Remove unportable assumption about struct layout (Bug#8884).
163 * alloc.c (mark_buffer):
164 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
165 (clone_per_buffer_values): Don't assume that
166 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
167 This isn't true in general, and it's particularly not true
168 if Emacs is configured with --with-wide-int.
169 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
170 New macros, used in the buffer.c change.
172 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
174 * xsettings.c: Use both GConf and GSettings if both are available.
175 (store_config_changed_event): Add comment.
176 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
177 (store_tool_bar_style_changed): New functions.
178 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
179 (struct xsettings): Move font inside HAVE_XFT.
180 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
181 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
182 Move inside HAVE_XFT.
183 (something_changed_gsettingsCB): Renamed from something_changedCB.
184 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
186 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
187 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
188 (something_changed_gconfCB): Renamed from something_changedCB.
189 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
190 (parse_settings): Move check for font inside HAVE_XFT.
191 (read_settings, apply_xft_settings): Add comment.
192 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
193 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
194 call store_font_name_changed.
195 (xft_settings_event): Add comment.
196 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
197 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
198 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
199 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
200 (xsettings_initialize): Call init_gsettings last.
201 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
204 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
206 Random fixes. E.g., (random) never returned negative values.
207 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
208 subseconds part to the entropy, as that's a bit more random.
209 Prefer signed to unsigned, since the signedness doesn't matter and
210 in general we prefer signed. When given a limit, use a
211 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
212 latter isn't right if USE_2_TAGS_FOR_INTS.
213 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
214 not 0..VALMASK. Don't discard "excess" bits that random () returns.
216 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
218 * textprop.c (text_property_stickiness):
219 Obey Vtext_property_default_nonsticky.
220 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
221 * w32fns.c (syms_of_w32fns):
222 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
224 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
226 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
227 This is more efficient than Ffile_directory_p and avoids a minor race.
229 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
231 * buffer.c (Foverlay_put): Say what the return value is
234 * fileio.c (barf_or_query_if_file_exists): Check first if the file
235 is a directory before asking whether to use the file name
237 (barf_or_query_if_file_exists): Make the "File is a directory"
238 error be more correct.
240 * fns.c (Frequire): Remove the mention of the .gz files, since
241 that's installation-specific, but keep the mention of
244 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
246 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
247 Report string overflow if the output is too long.
249 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
251 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
252 (syms_of_gnutls): Remove duplicate DEFSYM for
253 Qgnutls_bootprop_verify_hostname_error, an error for
254 Qgnutls_bootprop_verify_error (which is no longer used).
256 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
257 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
258 Also (re)move comments that are misplaced or no longer relevant.
260 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
262 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
264 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
266 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
267 and background color parameters if they have been changed.
269 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
271 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
273 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
275 * xsettings.c (SYSTEM_FONT): Define only when used.
276 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
278 * keymap.c (access_keymap_1): Now static.
280 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
282 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
283 leave any prefix arg for the up event (Bug#1586).
285 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
287 * lread.c (syms_of_lread): Mention single symbols defined by
288 `defvar' or `defconst' (bug#7154).
290 * fns.c (Frequire): Mention .el.gz files (bug#7314).
291 (Frequire): Mention get-load-suffixes.
293 2011-07-02 Martin Rudalics <rudalics@gmx.at>
295 * window.h (window): Remove clone_number slot.
296 * window.c (Fwindow_clone_number, Fset_window_clone_number):
298 (make_parent_window, make_window, saved_window)
299 (Fset_window_configuration, save_window_save): Don't deal with
301 * buffer.c (Qclone_number): Remove declaration.
302 (sort_overlays, overlay_strings): Don't deal with clone numbers.
304 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
306 Add multiple inheritance to keymaps.
307 * keymap.c (Fmake_composed_keymap): New function.
308 (Fset_keymap_parent): Simplify.
309 (fix_submap_inheritance): Remove.
310 (access_keymap_1): New function extracted from access_keymap to handle
311 embedded parents and handle lists of maps.
312 (access_keymap): Use it.
313 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
314 (Fcopy_keymap): Handle embedded parents.
315 (Fcommand_remapping, define_as_prefix): Simplify.
316 (Fkey_binding): Simplify.
317 (syms_of_keymap): Move minibuffer-local-completion-map,
318 minibuffer-local-filename-completion-map,
319 minibuffer-local-must-match-map, and
320 minibuffer-local-filename-must-match-map to Elisp.
321 (syms_of_keymap): Defsubr make-composed-keymap.
322 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
323 (parse_menu_item): Trivial simplification.
325 2011-07-01 Glenn Morris <rgm@gnu.org>
327 * Makefile.in (SETTINGS_LIBS): Fix typo.
329 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
331 * coding.c (Fencode_coding_string): Record the last coding system
332 used, as the function doc string says (bug#8738).
334 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
336 * xsettings.c (store_monospaced_changed): Take new font as arg and
337 check for change against current_mono_font.
338 (EMACS_TYPE_SETTINGS): Remove this and related defines.
339 (emacs_settings_constructor, emacs_settings_get_property)
340 (emacs_settings_set_property, emacs_settings_class_init)
341 (emacs_settings_init, gsettings_obj): Remove.
342 (something_changedCB): New function for HAVE_GSETTINGS.
343 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
344 with value as argument.
345 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
346 g_settings_new (Bug#8967). Do not create gsettings_obj.
347 Remove calls to g_settings_bind. Connect something_changedCB to
350 * xgselect.c: Add defined (HAVE_GSETTINGS).
351 (xgselect_initialize): Ditto.
353 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
354 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
357 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
359 * eval.c (struct backtrace): Simplify and port the data structure.
360 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
361 signed bit field, as this assumption is not portable and it makes
362 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
363 "char debug_on_exit : 1" as this is not portable either; instead,
364 use the portable "unsigned int debug_on_exit : 1". Remove unused
365 member evalargs. Remove obsolete comments about cc bombing out.
367 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
369 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
370 Let HAVE_GSETTINGS override HAVE_GCONF.
371 (store_monospaced_changed): New function.
372 (EMACS_SETTINGS): A new type derived from GObject to handle
373 GSettings notifications.
374 (emacs_settings_constructor, emacs_settings_get_property)
375 (emacs_settings_set_property, emacs_settings_class_init):
377 (gsettings_client, gsettings_obj): New variables.
378 (GSETTINGS_SCHEMA): New define.
379 (something_changedCB): Call store_monospaced_changed.
380 (init_gsettings): New function.
381 (xsettings_initialize): Call init_gsettings.
382 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
385 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
388 2011-06-29 Martin Rudalics <rudalics@gmx.at>
390 * window.c (resize_root_window, grow_mini_window)
391 (shrink_mini_window): Rename Qresize_root_window to
392 Qwindow_resize_root_window and Qresize_root_window_vertically to
393 Qwindow_resize_root_window_vertically.
395 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
397 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
399 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
401 * makefile.w32-in: Redesign dependencies so they reflect more
402 clearly which files are directly included by each source file,
403 and not through other includes.
405 2011-06-27 Martin Rudalics <rudalics@gmx.at>
407 * buffer.c (Qclone_number): Declare static and DEFSYM it.
408 (sort_overlays, overlay_strings): When an overlay's clone number
409 matches the window's clone number process the overlay even if
410 the overlay's window property doesn't match the current window.
412 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
413 (Fwindow_hchild): Rename to Fwindow_left_child.
414 (Fwindow_next): Rename to Fwindow_next_sibling.
415 (Fwindow_prev): Rename to Fwindow_prev_sibling.
416 (resize_window_check): Rename to window_resize_check.
417 (resize_window_apply): Rename to window_resize_apply.
418 (Fresize_window_apply): Rename to Fwindow_resize_apply.
419 (Fdelete_other_windows_internal, resize_frame_windows)
420 (Fsplit_window_internal, Fdelete_window_internal)
421 (grow_mini_window, shrink_mini_window)
422 (Fresize_mini_window_internal): Fix callers accordingly.
424 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
426 * emacsgtkfixed.h: State that this is only used with Gtk+3.
427 (emacs_fixed_set_min_size): Remove.
428 (emacs_fixed_new): Take frame as argument.
430 * emacsgtkfixed.c: State that this is only used with Gtk+3.
431 (_EmacsFixedPrivate): Remove minwidth/height.
433 (emacs_fixed_init): Initialize priv->f.
434 (get_parent_class, emacs_fixed_set_min_size): Remove.
435 (emacs_fixed_new): Set priv->f to argument.
436 (emacs_fixed_get_preferred_width)
437 (emacs_fixed_get_preferred_height): Use min_width/height from
438 frames size_hint to set minimum and natural (Bug#8919).
439 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
440 and use min_width/height from frames size_hint to set
441 min_width/height (Bug#8919).
443 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
444 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
447 2011-06-26 Eli Zaretskii <eliz@gnu.org>
449 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
450 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
453 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
455 * process.c (wait_reading_process_output): Bypass select if
456 waiting for a cell while ignoring keyboard input, and input is
457 pending. Suggested by Jan Djärv (Bug#8869).
459 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
461 Use gnulib's dup2 module instead of rolling our own.
462 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
464 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
466 * dispnew.c (scrolling_window): Before scrolling, turn off a
467 mouse-highlight in the window being scrolled.
469 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
471 Move DEFSYM to lisp.h and use everywhere.
473 * character.h (DEFSYM): Move declaration...
474 * lisp.h (DEFSYM): ...here.
480 * w32select.c: Don't include character.h.
482 * alloc.c (syms_of_alloc):
483 * buffer.c (syms_of_buffer):
484 * bytecode.c (syms_of_bytecode):
485 * callint.c (syms_of_callint):
486 * casefiddle.c (syms_of_casefiddle):
487 * casetab.c (init_casetab_once):
488 * category.c (init_category_once, syms_of_category):
489 * ccl.c (syms_of_ccl):
490 * cmds.c (syms_of_cmds):
491 * composite.c (syms_of_composite):
492 * dbusbind.c (syms_of_dbusbind):
493 * dired.c (syms_of_dired):
494 * dispnew.c (syms_of_display):
495 * doc.c (syms_of_doc):
496 * editfns.c (syms_of_editfns):
497 * emacs.c (syms_of_emacs):
498 * eval.c (syms_of_eval):
499 * fileio.c (syms_of_fileio):
500 * fns.c (syms_of_fns):
501 * frame.c (syms_of_frame):
502 * fringe.c (syms_of_fringe):
503 * insdel.c (syms_of_insdel):
504 * keymap.c (syms_of_keymap):
505 * lread.c (init_obarray, syms_of_lread):
506 * macros.c (syms_of_macros):
507 * msdos.c (syms_of_msdos):
508 * print.c (syms_of_print):
509 * process.c (syms_of_process):
510 * search.c (syms_of_search):
511 * sound.c (syms_of_sound):
512 * syntax.c (init_syntax_once, syms_of_syntax):
513 * terminal.c (syms_of_terminal):
514 * textprop.c (syms_of_textprop):
515 * undo.c (syms_of_undo):
516 * w32.c (globals_of_w32):
517 * window.c (syms_of_window):
518 * xdisp.c (syms_of_xdisp):
519 * xfaces.c (syms_of_xfaces):
520 * xfns.c (syms_of_xfns):
521 * xmenu.c (syms_of_xmenu):
522 * xsettings.c (syms_of_xsettings):
523 * xterm.c (syms_of_xterm): Use DEFSYM.
525 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
527 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
529 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
531 Integer and buffer overflow fixes (Bug#8873).
533 * print.c (printchar, strout): Check for string overflow.
534 (PRINTPREPARE, printchar, strout):
535 Don't set size unless allocation succeeds.
537 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
538 for sizes. Check for string overflow more accurately.
539 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
541 * macros.c: Integer and buffer overflow fixes.
542 * keyboard.h (struct keyboard.kbd_macro_bufsize):
543 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
544 Use ptrdiff_t, not int, for sizes.
545 Don't increment bufsize until after realloc succeeds.
546 Check for size-calculation overflow.
547 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
549 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
551 * lread.c: Integer overflow fixes.
552 (read_integer): Radix is now EMACS_INT, not int,
553 to improve quality of diagnostics for out-of-range radices.
554 Calculate buffer size correctly for out-of-range radices.
555 (read1): Check for integer overflow in radices, and in
557 (read_escape): Avoid int overflow.
558 (Fload, openp, read_buffer_size, read1)
559 (substitute_object_recurse, read_vector, read_list, map_obarray):
560 Use ptrdiff_t, not int, for sizes.
561 (read1): Use EMACS_INT, not int, for sizes.
562 Check for size overflow.
564 * image.c (cache_image): Check for size arithmetic overflow.
566 * lread.c: Integer overflow issues.
567 (saved_doc_string_size, saved_doc_string_length)
568 (prev_saved_doc_string_size, prev_saved_doc_string_length):
569 Now ptrdiff_t, not int.
570 (read1): Don't assume doc string length fits in int. Check for
571 out-of-range doc string lengths.
572 (read_list): Don't assume file position fits in int.
573 (read_escape): Check for hex character overflow.
575 2011-06-22 Leo Liu <sdl.web@gmail.com>
577 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
578 Move to minibuffer.el.
580 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
582 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
583 The following patches are for when GLYPH_DEBUG && !XASSERT.
584 * dispextern.h (trace_redisplay_p, dump_glyph_string):
585 * dispnew.c (flush_stdout):
586 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
587 Mark as externally visible.
588 * dispnew.c (check_window_matrix_pointers): Now static.
589 * dispnew.c (window_to_frame_vpos):
590 * xfns.c (unwind_create_frame):
591 * xterm.c (x_check_font): Remove unused local.
592 * scroll.c (CHECK_BOUNDS):
593 * xfaces.c (cache_fache): Rename local to avoid shadowing.
594 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
595 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
596 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
597 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
599 (debug_method_add): Use va_list and vsprintf rather than relying
600 on undefined behavior with wrong number of arguments.
601 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
602 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
603 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
604 since we're not interested in debugging glyphs with old libraries.
605 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
606 GCC 4.6.0's static checking.
608 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
610 Integer overflow and signedness fixes (Bug#8873).
611 A few related buffer overrun fixes, too.
613 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
615 * dispextern.h (struct face.stipple):
616 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
617 (x_bitmap_mask, x_allocate_bitmap_record)
618 (x_create_bitmap_from_data, x_create_bitmap_from_file)
619 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
620 (x_create_bitmap_from_xpm_data):
621 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
622 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
624 * xfaces.c (load_pixmap):
625 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
626 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
627 (.bitmaps_last, struct x_output.icon_bitmap):
628 Use ptrdiff_t, not int, for bitmap indexes.
629 (x_allocate_bitmap_record): Check for size overflow.
630 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
632 Use ptrdiff_t, not int, for overlay counts.
633 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
634 * editfns.c (overlays_around, get_pos_property):
635 * textprop.c (get_char_property_and_overlay):
636 * xdisp.c (next_overlay_change, note_mouse_highlight):
637 * xfaces.c (face_at_buffer_position):
638 * buffer.c (OVERLAY_COUNT_MAX): New macro.
639 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
640 (Fnext_overlay_change, Fprevious_overlay_change)
641 (mouse_face_overlay_overlaps, Foverlays_in):
642 Use ptrdiff_t, not int, for sizes.
643 (overlays_at, overlays_in): Check for size-calculation overflow.
645 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
647 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
648 (x_session_initialize): Do not assume string length fits in int.
650 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
651 This is unlikely, but can occur if DPI is outlandish.
653 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
654 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
656 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
657 * xrdb.c (magic_file_p, search_magic_path):
658 Omit last arg SUFFIX; it was always 0. All callers changed.
659 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
661 * xfont.c (xfont_match): Avoid need for strlen.
663 * xfns.c: Don't assume strlen fits in int.
664 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
666 * xdisp.c (message_log_check_duplicate): Return intmax_t,
667 not unsigned long, as we prefer signed integers. All callers changed.
668 Detect integer overflow in repeat count.
669 (message_dolog): Don't assume print length fits in 39 bytes.
670 (display_mode_element): Don't assume strlen fits in int.
672 * termcap.c: Don't assume sizes fit in int and never overflow.
673 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
674 (gobble_line): Check for size-calculation overflow.
676 * minibuf.c (Fread_buffer):
677 * lread.c (intern, intern_c_string):
678 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
679 Don't assume string length fits in int.
681 * keyboard.c (parse_tool_bar_item):
682 * gtkutil.c (style_changed_cb): Avoid need for strlen.
684 * font.c: Don't assume string length fits in int.
685 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
686 Use ptrdiff_t, not int.
687 (font_intern_prop): Don't assume string length fits in int.
688 Don't assume integer property fits in fixnum.
689 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
691 * filelock.c: Fix some buffer overrun and integer overflow issues.
692 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
693 Reformulate so as not to need the command string.
694 Invoke gzip -cd rather than gunzip, as it's more portable.
695 (lock_info_type, lock_file_1, lock_file):
696 Don't assume pid_t and time_t fit in unsigned long.
697 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
698 (current_lock_owner): Prefer signed type for sizes.
699 Use memcpy, not strncpy, where memcpy is what is really wanted.
700 Don't assume (via atoi) that time_t and pid_t fit in int.
701 Check for time_t and/or pid_t out of range, e.g., via a network share.
702 Don't alloca where an auto var works fine.
704 * fileio.c: Fix some integer overflow issues.
705 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
706 Don't assume string length fits in int.
707 (directory_file_name): Don't assume string length fits in long.
708 (make_temp_name): Don't assume pid fits in int, or that its print
709 length is less than 20.
711 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
713 * coding.c (make_subsidiaries): Don't assume string length fits in int.
715 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
717 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
718 We prefer signed integers, even for size calculations.
720 * emacs.c: Don't assume string length fits in 'int'.
721 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
722 (main): Don't invoke strlen when not needed.
724 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
725 (XD_DEBUG_MESSAGE): Don't waste a byte.
727 * callproc.c (getenv_internal_1, getenv_internal)
729 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
731 * lread.c (invalid_syntax): Omit length argument.
732 All uses changed. This doesn't fix a bug, but it simplifies the
733 code away from its former Hollerith-constant appearance, and it's
734 one less 'int' to worry about when looking at integer-overflow issues.
735 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
737 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
738 This didn't break anything, but it didn't help either.
739 It's confusing to put a bogus integer in a place where the actual
740 value does not matter.
741 (LIST_END_P): Remove unused macro and its bogus comment.
742 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
744 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
745 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
747 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
748 We prefer signed types, and the value cannot exceed the EMACS_INT
749 range anyway (because otherwise the length would not be representable).
750 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
751 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
752 This avoids a GCC warning when WIDE_EMACS_INT.
754 * indent.c (sane_tab_width): New function.
755 (current_column, scan_for_column, Findent_to, position_indentation)
756 (compute_motion): Use it. This is just for clarity.
757 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
759 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
761 * lisp.h (lint_assume): New macro.
762 * composite.c (composition_gstring_put_cache):
763 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
765 * editfns.c, insdel.c:
766 Omit unnecessary forward decls, to simplify future changes.
768 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
770 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
772 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
773 Use much-faster test for byte-length change.
774 Don't assume string byte-length fits in 'int'.
775 Check that character arg fits in 'int'.
776 (mapcar1): Declare byte as byte, for clarity.
778 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
780 * fns.c (concat): Catch string overflow earlier.
781 Do not rely on integer wraparound.
783 * dispextern.h (struct it.overlay_strings_charpos)
784 (struct it.selective): Now EMACS_INT, not int.
785 * xdisp.c (forward_to_next_line_start)
786 (back_to_previous_visible_line_start)
787 (reseat_at_next_visible_line_start, next_element_from_buffer):
788 Don't arbitrarily truncate the value of 'selective' to int.
790 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
792 * composite.c: Don't truncate sizes to 'int'.
793 (composition_gstring_p, composition_reseat_it)
794 (composition_adjust_point): Use EMACS_INT, not int.
795 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
796 not EMACS_UINT, for indexes.
798 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
800 * buffer.c: Include <verify.h>.
801 (struct sortvec.priority, struct sortstr.priority):
802 Now EMACS_INT, not int.
803 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
804 (struct sortstr.size, record_overlay_string)
805 (struct sortstrlist.size, struct sortlist.used):
806 Don't truncate size to int.
807 (record_overlay_string): Check for size-calculation overflow.
808 (init_buffer_once): Check at compile-time, not run-time.
810 2011-06-22 Jim Meyering <meyering@redhat.com>
812 Don't leak an XBM-image-sized buffer
813 * image.c (xbm_load): Free the image buffer after using it.
815 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
818 * composite.c (find_automatic_composition): Omit needless 'return 0;'
819 that Sun C diagnosed.
820 * fns.c (secure_hash): Fix pointer signedness issue.
821 * intervals.c (static_offset_intervals): New function.
822 (offset_intervals): Use it.
824 2011-06-21 Leo Liu <sdl.web@gmail.com>
827 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
830 * fns.c (secure_hash): Rename from crypto_hash_function and change
831 the first arg to accept symbols.
832 (Fsecure_hash): New primitive.
833 (syms_of_fns): New symbols.
835 2011-06-20 Deniz Dogan <deniz@dogan.se>
837 * process.c (Fset_process_buffer): Clarify return value in
840 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
842 * dispnew.c (add_window_display_history): Use BVAR.
844 * xdisp.c (debug_method_add): Use BVAR.
845 (check_window_end, dump_glyph_matrix, dump_glyph)
846 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
848 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
851 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
852 check till after the cache is created in init_frame_faces.
854 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
856 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
858 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
860 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
861 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
862 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
864 Improve buffer-overflow checking (Bug#8873).
865 * fileio.c (Finsert_file_contents):
866 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
867 Remove the old (too-loose) buffer overflow checks.
868 They weren't needed, since make_gap checks for buffer overflow.
869 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
870 The old code merely checked for Emacs fixnum overflow, and relied
871 on undefined (wraparound) behavior. The new code avoids undefined
872 behavior, and also checks for ptrdiff_t and/or size_t overflow.
874 * editfns.c (Finsert_char): Don't dump core with very negative counts.
875 Tune. Don't use wider integers than needed. Don't use alloca.
876 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
878 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
880 * insdel.c, lisp.h (buffer_overflow): New function.
881 (insert_from_buffer_1, replace_range, replace_range_2):
882 * insdel.c (make_gap_larger):
883 * editfns.c (Finsert_char):
884 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
886 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
888 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
890 Integer overflow and signedness fixes (Bug#8873).
892 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
893 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
895 * fileio.c: Don't assume EMACS_INT fits in off_t.
896 (emacs_lseek): New static function.
897 (Finsert_file_contents, Fwrite_region): Use it.
898 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
900 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
902 * fns.c: Don't overflow int when computing a list length.
903 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
904 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
905 truncation on 64-bit hosts. Check for QUIT every
906 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
907 faster and is responsive enough.
908 (Flength): Report an error instead of overflowing an integer.
909 (Fsafe_length): Return a float if the value is not representable
910 as a fixnum. This shouldn't happen except in contrived situations.
911 (Fnthcdr, Fsort): Don't assume list length fits in int.
912 (Fcopy_sequence): Don't assume vector length fits in int.
914 * alloc.c: Check that resized vectors' lengths fit in fixnums.
915 (header_size, word_size): New constants.
916 (allocate_vectorlike): Don't check size overflow here.
917 (allocate_vector): Check it here instead, since this is the only
918 caller of allocate_vectorlike that could cause overflow.
919 Check that the new vector's length is representable as a fixnum.
921 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
922 The previous code was bogus. For example, next_almost_prime (32)
923 returned 39, which is undesirable as it is a multiple of 3; and
924 next_almost_prime (24) returned 25, which is a multiple of 5 so
925 why was the code bothering to check for multiples of 7?
927 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
929 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
931 Variadic C functions now count arguments with ptrdiff_t.
932 This partly undoes my 2011-03-30 change, which replaced int with size_t.
933 Back then I didn't know that the Emacs coding style prefers signed int.
934 Also, in the meantime I found a few more instances where arguments
935 were being counted with int, which may truncate counts on 64-bit
936 machines, or EMACS_INT, which may be unnecessarily wide.
937 * lisp.h (struct Lisp_Subr.function.aMANY)
938 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
939 Arg counts are now ptrdiff_t, not size_t.
940 All variadic functions and their callers changed accordingly.
941 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
942 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
943 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
944 * callint.c (Fcall_interactively): Check arg count for overflow,
945 to avoid potential buffer overrun. Use signed char, not 'int',
946 for 'varies' array, so that we needn't bother to check its size
947 calculation for overflow.
948 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
949 * eval.c (apply_lambda):
950 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
951 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
952 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
954 * callint.c (Fcall_interactively): Don't use index var as event count.
956 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
957 * mem-limits.h (SIZE): Remove; no longer used.
959 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
961 Remove unnecessary casts.
962 * xterm.c (x_term_init):
963 * xfns.c (x_set_border_pixel):
964 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
965 These aren't needed now that we assume ANSI C.
967 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
968 It's more likely to cause problems (due to unsigned overflow)
971 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
973 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
975 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
977 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
979 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
981 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
983 GLYPH_CODE_FACE returns EMACS_INT, not int.
984 * dispextern.h (merge_faces):
985 * xfaces.c (merge_faces):
986 * xdisp.c (get_next_display_element, next_element_from_display_vector):
987 Don't assume EMACS_INT fits in int.
989 * character.h (CHAR_VALID_P): Remove unused parameter.
990 * fontset.c, lisp.h, xdisp.c: All uses changed.
992 * editfns.c (Ftranslate_region_internal): Omit redundant test.
994 * fns.c (concat): Minor tuning based on overflow analysis.
995 This doesn't fix any bugs. Use int to hold character, instead
996 of constantly refetching from Emacs object. Use XFASTINT, not
997 XINT, for value known to be a character. Don't bother comparing
998 a single byte to 0400, as it's always less.
1000 * floatfns.c (Fexpt):
1001 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1003 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1006 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1008 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1009 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1010 incorrectly succeed when S was a string, because 4294967386 was
1011 truncated before it was used.
1013 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1014 Otherwise, an out-of-range integer could cause undefined behavior
1017 * composite.c: Use int, not EMACS_INT, for characters.
1018 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1019 EMACS_INT, for values that are known to be in character range.
1020 This doesn't fix any bugs but is the usual style inside Emacs and
1021 may generate better code on 32-bit machines.
1023 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1024 This is for reasons similar to the recent CHAR_STRING fix.
1025 * charset.c (Fencode_char): Check that character arg is actually
1026 a character. Pass an int to ENCODE_CHAR.
1027 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1028 wider than 'int', as a compile-time check to prevent future regressions
1031 * character.c (char_string): Remove unnecessary casts.
1033 Make sure a 64-bit char is never passed to CHAR_STRING.
1034 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1035 by silently ignoring the top 32 bits, allowing some values
1036 that were far too large to be valid characters.
1037 * character.h: Include <verify.h>.
1038 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1039 arguments are no wider than unsigned, as a compile-time check
1040 to prevent future regressions in this area.
1042 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1043 (Fsubst_char_in_region):
1045 * xdisp.c (decode_mode_spec_coding):
1046 Adjust to CHAR_STRING's new requirement.
1047 * editfns.c (Finsert_char, Fsubst_char_in_region):
1048 * fns.c (concat): Check that character args are actually
1049 characters. Without this test, these functions did the wrong
1050 thing with wildly out-of-range values on 64-bit hosts.
1052 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1053 These casts should not be needed on 32-bit hosts, either.
1054 * keyboard.c (read_char):
1055 * lread.c (Fload): Remove casts to unsigned.
1057 * lisp.h (UNSIGNED_CMP): New macro.
1058 This fixes comparison bugs on 64-bit hosts.
1059 (ASCII_CHAR_P): Use it.
1060 * casefiddle.c (casify_object):
1061 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1062 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1063 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1064 * dispextern.h (FACE_FROM_ID):
1065 * keyboard.c (read_char): Use UNSIGNED_CMP.
1067 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1068 not to EMACS_INT, to avoid GCC warning.
1070 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1072 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1073 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1074 isn't needed on 32-bit machines.
1076 * buffer.c (Fgenerate_new_buffer_name):
1077 Use EMACS_INT for count, not int.
1078 (advance_to_char_boundary): Return EMACS_INT, not int.
1080 * data.c (Qcompiled_function): Now static.
1082 * window.c (window_body_lines): Now static.
1084 * image.c (gif_load): Rename local to avoid shadowing.
1086 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1087 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1088 * alloc.c (make_save_value): Integer argument is now of type
1090 (mark_object): Use ptrdiff_t, not int.
1091 * lisp.h (pD): New macro.
1092 * print.c (print_object): Use it.
1094 * alloc.c: Use EMACS_INT, not int, to count objects.
1095 (total_conses, total_markers, total_symbols, total_vector_size)
1096 (total_free_conses, total_free_markers, total_free_symbols)
1097 (total_free_floats, total_floats, total_free_intervals)
1098 (total_intervals, total_strings, total_free_strings):
1099 Now EMACS_INT, not int. All uses changed.
1100 (Fgarbage_collect): Compute overall total using a double, so that
1101 integer overflow is less likely to be a problem. Check for overflow
1102 when converting back to an integer.
1103 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1104 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1105 These were 'int' variables that could overflow on 64-bit hosts;
1106 they were never used, so remove them instead of repairing them.
1107 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1108 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1109 Previously, this ceilinged at INT_MAX, but that doesn't work on
1111 (allocate_pseudovector): Don't use EMACS_INT when int would do.
1113 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1114 (allocate_vectorlike): Check for ptrdiff_t overflow.
1115 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1116 when a (possibly-narrower) signed value would do just as well.
1117 We prefer using signed arithmetic, to avoid comparison confusion.
1119 * alloc.c: Catch some string size overflows that we were missing.
1120 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1121 for convenience in STRING_BYTES_MAX.
1122 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1123 The definition here is exact; the one in lisp.h was approximate.
1124 (allocate_string_data): Check for string overflow. This catches
1125 some instances we weren't catching before. Also, it catches
1126 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1127 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1128 and ptrdiff_t and EMACS_INT are both 64 bits.
1130 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1131 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1132 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1134 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1136 * alloc.c (Fmake_string): Check for out-of-range init.
1138 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1140 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1142 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1144 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1145 xg_get_default_scrollbar_width.
1147 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1148 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1149 (style_changed_cb): Call update_theme_scrollbar_width and call
1150 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1151 all frames (Bug#8505).
1152 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1153 Call gtk_window_set_resizable if HAVE_GTK3.
1154 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1155 and height if HAVE_GTK3 (Bug#8505).
1156 (scroll_bar_width_for_theme): New variable.
1157 (update_theme_scrollbar_width): New function.
1158 (xg_get_default_scrollbar_width): Move code to
1159 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1160 (xg_initialize): Call update_theme_scrollbar_width.
1162 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1164 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1166 2011-06-12 Martin Rudalics <rudalics@gmx.at>
1168 * frame.c (make_frame): Call other_buffer_safely instead of
1171 * window.c (temp_output_buffer_show): Call display_buffer with
1172 second argument Vtemp_buffer_show_specifiers and reset latter
1173 immediately after the call.
1174 (Vtemp_buffer_show_specifiers): New variable.
1175 (auto_window_vscroll_p, next_screen_context_lines)
1176 (Vscroll_preserve_screen_position): Remove leading asterisks from
1179 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
1181 Fix minor problems found by GCC 4.6.0 static checking.
1182 * buffer.c (Qclone_number): Remove for now, as it's unused.
1183 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1184 (record_buffer): Remove unused local.
1185 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1186 (set_frame_buffer_list): Remove; unused.
1187 * frame.h (other_visible_frames): Remove decl.
1188 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1189 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1190 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1192 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1193 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1194 Define only if HAVE_GPM.
1195 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1196 (update_hints_inhibit): Remove; never set. All uses removed.
1197 * widgetprv.h (emacsFrameClassRec): Remove decl.
1198 * window.c (delete_deletable_window): Now returns void, since it
1199 wasn't returning anything.
1200 (compare_window_configurations): Remove unused locals.
1201 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1202 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
1203 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1204 the same widths as pointers. This follows up on the 2011-05-06 patch.
1205 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1206 * xterm.h: Likewise.
1207 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1209 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
1211 * makefile.w32-in: Update dependencies.
1212 (LISP_H): Add lib/intprops.h.
1214 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1216 * image.c (gif_load): Add animation frame delay to the metadata.
1217 (syms_of_image): Use DEFSYM. New symbol `delay'.
1219 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1221 * window.c (delete_deletable_window): Re-add.
1222 (Fset_window_configuration): Rewrite to handle dead buffers and
1223 consequently deletable windows.
1224 (window_tree, Fwindow_tree): Remove. Supply functionality in
1226 (compare_window_configurations): Simplify code.
1228 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1230 * image.c (imagemagick_load_image): Fix type mismatch.
1231 (Fimagemagick_types): Likewise.
1233 * window.h (replace_buffer_in_windows): Declare.
1235 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1237 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1238 Qclone_number. Remove external declaration of Qdelete_window.
1239 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1241 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1242 Qbuffer_list_update_hook if allowed.
1243 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1244 buffer list implementation.
1245 (other_buffer_safely): New function.
1246 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1247 calls to replace_buffer_in_windows and
1248 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1250 (record_buffer): Inhibit quitting and rewrite using quittable
1251 functions. Run Qbuffer_list_update_hook if allowed.
1252 (Frecord_buffer, Funrecord_buffer): New functions.
1253 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1254 switch-to-buffer to window.el.
1255 (bury-buffer): Move to window.el.
1256 (Vbuffer_list_update_hook): New variable.
1258 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1261 * window.h (resize_frame_windows): Move up in code.
1262 (Fwindow_frame): Remove EXFUN.
1263 (replace_buffer_in_all_windows): Remove prototype.
1264 (replace_buffer_in_windows_safely): Add prototype.
1266 * window.c: Declare Qdelete_window static again. Move down
1267 declaration of select_count.
1268 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1269 (Fother_window): Move to window.el.
1270 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1271 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1272 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1274 (replace_buffer_in_windows): Implement by calling
1275 Qreplace_buffer_in_windows.
1276 (replace_buffer_in_all_windows): Remove with some functionality
1277 moved into replace_buffer_in_windows_safely.
1278 (replace_buffer_in_windows_safely): New function.
1279 (select_window_norecord, select_frame_norecord): Move in front
1280 of run_window_configuration_change_hook. Remove now obsolete
1282 (Fset_window_buffer): Rewrite doc-string. Call
1283 Qrecord_window_buffer.
1284 (keys_of_window): Move binding for other-window to window.el.
1286 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1288 * dispextern.h (struct image): Replace data member, whose int_val
1289 and ptr_val fields were not used by anything, with a single
1292 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1293 (gif_clear_image, gif_load, imagemagick_load_image)
1294 (gs_clear_image, gs_load): Callers changed.
1296 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1298 * buffer.h: Include <time.h>, for time_t.
1299 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1301 Fix minor problems found by static checking.
1303 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1305 Make identifiers static if they are not used in other modules.
1306 * data.c (Qcompiled_function, Qframe, Qvector):
1307 * image.c (QimageMagick, Qsvg):
1308 * minibuf.c (Qmetadata):
1309 * window.c (resize_window_check, resize_root_window): Now static.
1310 * window.h (resize_window_check, resize_root_window): Remove decls.
1312 * window.c (window_deletion_count, delete_deletable_window):
1314 (window_body_lines): Now static.
1315 (Fdelete_other_windows_internal): Mark vars as initialized.
1316 Make sure 'resize_failed' is initialized.
1317 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1318 (resize_window_apply): Remove unused local.
1319 * window.h (delete_deletable_window): Remove decl.
1321 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
1322 (imagemagick_load_image): Fix pointer signedness problem by changing
1323 last arg from unsigned char * to char *. All uses changed.
1324 Also, fix a local for similar reasons.
1325 Remove unused locals. Remove locals to avoid shadowing.
1326 (fn_rsvg_handle_free): Remove; unused.
1327 (svg_load, svg_load_image): Fix pointer signedness problem.
1328 (imagemagick_load_image): Don't use garbage pointer image_wand.
1330 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1332 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
1334 * image.c (gif_load): Fix omitted cast error introduced by
1337 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1339 * window.h (resize_proportionally, orig_total_lines)
1340 (orig_top_line): Remove from window structure.
1341 (set_window_height, set_window_width, change_window_heights)
1342 (Fdelete_window): Remove prototypes.
1343 (resize_frame_windows): Remove duplicate declaration.
1345 2011-06-10 Eli Zaretskii <eliz@gnu.org>
1347 * window.h (resize_frame_windows, resize_window_check)
1348 (delete_deletable_window, resize_root_window)
1349 (resize_frame_windows): Declare prototypes.
1351 * window.c (resize_window_apply): Make definition be "static" to
1352 match the prototype.
1354 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1356 * window.c: Remove declarations of Qwindow_size_fixed,
1357 window_min_size_1, window_min_size_2, window_min_size,
1358 size_window, window_fixed_size_p, enlarge_window, delete_window.
1359 Remove static from declaration of Qdelete_window, it's
1360 temporarily needed by Fbury_buffer.
1361 (replace_window): Don't assign orig_top_line and
1363 (Fdelete_window, delete_window): Remove. Window deletion is
1364 handled by window.el.
1365 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1366 Fdelete_window calls with calls to Qdelete_window.
1367 (Fdelete_other_windows): Remove. Deleting other windows is
1368 handled by window.el.
1369 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1370 handled in window.el.
1371 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1372 Window minimum sizes are handled in window.el.
1373 (shrink_windows, size_window, set_window_height)
1374 (set_window_width, change_window_heights, window_height)
1375 (window_width, CURBEG, CURSIZE, enlarge_window)
1376 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1377 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1378 handled in window.el.
1379 (make_dummy_parent): Rename to make_parent_window and give it a
1380 second argument horflag.
1381 (make_window): Don't set resize_proportionally any more.
1382 (Fsplit_window): Remove. Windows are split in window.el.
1383 (save_restore_action, save_restore_orig_size)
1384 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1385 Resize mini windows in window.el.
1386 (grow_mini_window, shrink_mini_window): Implement by calling
1387 Qresize_root_window_vertically, resize_window_check and
1388 resize_window_apply.
1389 (saved_window, Fset_window_configuration, save_window_save): Do
1390 not handle orig_top_line, orig_total_lines, and
1391 resize_proportionally.
1392 (window_min_height, window_min_width): Move to window.el.
1393 (keys_of_window): Move bindings for delete-other-windows,
1394 split-window, delete-window and enlarge-window to window.el.
1396 * buffer.c: Temporarily extern Qdelete_window.
1397 (Fbury_buffer): Temporarily call Qdelete_window instead of
1398 Fdelete_window (Fbury_buffer will move to window.el soon).
1400 * frame.c (set_menu_bar_lines_1): Remove code handling
1401 orig_top_line and orig_total_lines.
1403 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1404 set_window_height but set heights directly.
1405 (change_frame_size_1): Use resize_frame_windows.
1407 * xdisp.c (init_xdisp): Don't use set_window_height but set
1410 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1411 resize_frame_windows instead of change_window_heights and run
1412 run_window_configuration_change_hook.
1414 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1415 instead of change_window_heights and run
1416 run_window_configuration_change_hook.
1418 2011-06-09 Martin Rudalics <rudalics@gmx.at>
1420 * window.c (replace_window): Rename second argument REPLACEMENT to
1421 NEW. New third argument SETFLAG. Rewrite.
1422 (delete_window, make_dummy_parent): Call replace_window with
1424 (window_list_1): Move down in code.
1425 (run_window_configuration_change_hook): Move set_buffer part
1426 before select_frame_norecord part in order to unwind correctly.
1427 Rename count1 to count.
1428 (recombine_windows, delete_deletable_window, resize_root_window)
1429 (Fdelete_other_windows_internal)
1430 (Frun_window_configuration_change_hook, make_parent_window)
1431 (resize_window_check, resize_window_apply, Fresize_window_apply)
1432 (resize_frame_windows, Fsplit_window_internal)
1433 (Fdelete_window_internal, Fresize_mini_window_internal): New
1435 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1437 2011-06-08 Martin Rudalics <rudalics@gmx.at>
1439 * window.h (window): Add some new members to window structure -
1440 normal_lines, normal_cols, new_total, new_normal, clone_number,
1441 splits, nest, prev_buffers, next_buffers.
1442 (WINDOW_TOTAL_SIZE): Move here from window.c.
1443 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1445 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1447 (make_dummy_parent): Set new members of windows structure.
1448 (make_window): Move down in code. Handle new members of window
1450 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1451 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1452 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1453 (Fset_window_prev_buffers, Fwindow_next_buffers)
1454 (Fset_window_next_buffers, Fset_window_clone_number): New
1456 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1457 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1459 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1460 Argument WINDOW can be now internal window too.
1461 (Fwindow_use_time): Move up in code.
1462 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1464 (Fset_window_configuration, saved_window)
1465 (Fcurrent_window_configuration, save_window_save): Handle new
1466 members of window structure.
1467 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1468 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1469 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1470 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1471 Qget_mru_window, Qresize_root_window,
1472 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1473 Qauto_buffer_name; staticpro them.
1475 2011-06-07 Martin Rudalics <rudalics@gmx.at>
1477 * window.c (Fwindow_total_size, Fwindow_left_column)
1478 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1479 (Fwindow_list_1): New functions.
1480 (window_box_text_cols): Replace with window_body_cols.
1481 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1482 window_body_cols instead of window_box_text_cols.
1483 (delete_window, Fset_window_configuration): Call
1484 delete_all_subwindows with window as argument.
1485 (delete_all_subwindows): Take a window as argument and not a
1487 (window_loop): Remove handling of GET_LRU_WINDOW and
1489 (Fget_lru_window, Fget_largest_window): Move to window.el.
1491 * window.h: Extern window_body_cols instead of
1492 window_box_text_cols. delete_all_subwindows now takes a
1493 Lisp_Object as argument.
1495 * indent.c (compute_motion, Fcompute_motion): Use
1496 window_body_cols instead of window_box_text_cols.
1498 * frame.c (delete_frame): Call delete_all_subwindows with root
1501 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1503 * fns.c (Fputhash): Document return value.
1505 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
1507 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1509 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1511 Cons<->int and similar integer overflow fixes (Bug#8794).
1513 Check for overflow when converting integer to cons and back.
1514 * charset.c (Fdefine_charset_internal, Fdecode_char):
1515 Use cons_to_unsigned to catch overflow.
1516 (Fencode_char): Use INTEGER_TO_CONS.
1517 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1518 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1519 * data.c (long_to_cons, cons_to_long): Remove.
1520 (cons_to_unsigned, cons_to_signed): New functions.
1521 These signal an error for invalid or out-of-range values.
1522 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1523 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1524 * font.c (Ffont_variation_glyphs):
1525 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1526 * lisp.h: Include <intprops.h>.
1527 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1528 (cons_to_signed, cons_to_unsigned): New decls.
1529 (long_to_cons, cons_to_long): Remove decls.
1530 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1531 (Fprimitive_undo): Use CONS_TO_INTEGER.
1532 * xfns.c (Fx_window_property): Likewise.
1533 * xselect.c: Include <limits.h>.
1534 (x_own_selection, selection_data_to_lisp_data):
1535 Use INTEGER_TO_CONS.
1536 (x_handle_selection_request, x_handle_selection_clear)
1537 (x_get_foreign_selection, Fx_disown_selection_internal)
1538 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1539 (lisp_data_to_selection_data): Use cons_to_unsigned.
1540 (x_fill_property_data): Use cons_to_signed.
1541 Report values out of range.
1543 Check for buffer and string overflow more precisely.
1544 * buffer.h (BUF_BYTES_MAX): New macro.
1545 * lisp.h (STRING_BYTES_MAX): New macro.
1546 * alloc.c (Fmake_string):
1547 * character.c (string_escape_byte8):
1548 * coding.c (coding_alloc_by_realloc):
1549 * doprnt.c (doprnt):
1550 * editfns.c (Fformat):
1552 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1553 since they may not be the same number.
1554 * editfns.c (Finsert_char):
1555 * fileio.c (Finsert_file_contents):
1556 Likewise for BUF_BYTES_MAX.
1558 * image.c: Use ptrdiff_t, not int, for sizes.
1559 (slurp_file): Switch from int to ptrdiff_t.
1561 (slurp_file): Check that file size fits in both size_t (for
1562 malloc) and ptrdiff_t (for sanity and safety).
1564 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1565 if b->modtime has its maximal value.
1567 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1569 Don't assume time_t can fit into int.
1570 * buffer.h (struct buffer.modtime): Now time_t, not int.
1571 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1572 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1574 Minor fixes for signed vs unsigned integers.
1575 * character.h (MAYBE_UNIFY_CHAR):
1576 * charset.c (maybe_unify_char):
1577 * keyboard.c (read_char, reorder_modifiers):
1578 XINT -> XFASTINT, since the integer must be nonnegative.
1579 * ftfont.c (ftfont_spec_pattern):
1580 * keymap.c (access_keymap, silly_event_symbol_error):
1581 XUINT -> XFASTINT, since the integer must be nonnegative.
1582 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1583 since it makes no difference and we prefer signed.
1584 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1585 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1588 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1590 * window.h (Fwindow_frame): Declare.
1592 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1594 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1595 (SPARE_MEMORY): Always define.
1596 (LARGE_REQUEST): Remove.
1597 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1599 2011-06-06 Martin Rudalics <rudalics@gmx.at>
1601 * lisp.h: Move EXFUNS for Fframe_root_window,
1602 Fframe_first_window and Fset_frame_selected_window to window.h.
1604 * window.h: Move EXFUNS for Fframe_root_window,
1605 Fframe_first_window and Fset_frame_selected_window here from
1608 * frame.c (Fwindow_frame, Fframe_first_window)
1609 (Fframe_root_window, Fframe_selected_window)
1610 (Fset_frame_selected_window): Move to window.c.
1611 (Factive_minibuffer_window): Move to minibuf.c.
1612 (Fother_visible_frames_p): New function.
1614 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1616 * window.c (decode_window, decode_any_window): Move up in code.
1617 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1618 (inhibit_frame_unsplittable): Remove unused variable.
1619 (Fwindow_buffer): Move up and rewrite doc-string.
1620 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1621 (Fwindow_prev): New functions.
1622 (Fwindow_frame): Move here from frame.c. Accept any window as
1624 (Fframe_root_window, Fframe_first_window)
1625 (Fframe_selected_window): Move here from frame.c. Accept frame
1626 or arbitrary window as argument. Update doc-strings.
1627 (Fminibuffer_window): Move up in code.
1628 (Fwindow_minibuffer_p): Move up in code and simplify.
1629 (Fset_frame_selected_window): Move here from frame.c.
1631 (Fselected_window, select_window, Fselect_window): Move up in
1632 code. Minor doc-string fixes.
1634 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1636 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1637 Do not assume that spare memory exists; that assumption is valid
1638 only if SYSTEM_MALLOC.
1639 (LARGE_REQUEST): New macro, so that the issue of large requests
1640 is separated from the issue of spare memory.
1642 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1644 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1647 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1649 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1652 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1654 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1656 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1658 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1659 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1661 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
1663 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1665 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
1667 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1668 (x_clipboard_manager_save): Add return value.
1669 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1671 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1672 Obey Vx_select_enable_clipboard_manager. Catch errors in
1673 x_clipboard_manager_save (Bug#8779).
1674 (Vx_select_enable_clipboard_manager): New variable.
1675 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
1677 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
1679 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1681 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1683 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1684 in the current matrix if keep_current_p is non-zero.
1686 2011-06-04 Eli Zaretskii <eliz@gnu.org>
1688 * bidi.c (bidi_level_of_next_char): Fix last change.
1690 2011-06-03 Eli Zaretskii <eliz@gnu.org>
1692 Support bidi reordering of text covered by display properties.
1694 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1695 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1696 (bidi_cache_search, bidi_cache_iterator_state)
1697 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1698 (bidi_level_of_next_char, bidi_move_to_visually_next):
1699 Support character positions inside a run of characters covered by a
1701 (bidi_paragraph_init, bidi_resolve_explicit_1)
1702 (bidi_level_of_next_char): Call bidi_fetch_char and
1703 bidi_fetch_char_advance instead of FETCH_CHAR and
1705 (bidi_init_it): Initialize new members.
1706 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1708 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1709 instead of using explicit *_CHAR codes.
1710 (bidi_resolve_explicit, bidi_resolve_weak):
1711 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
1712 bidirectional text is supported only in multibyte buffers.
1713 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1714 it to initialize the frame_window_p member of struct bidi_it.
1715 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1716 (bidi_resolve_explicit, bidi_resolve_weak)
1717 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1718 bidi_it->nchars is non-positive.
1719 (bidi_level_of_next_char): Don't try to lookup the cache for the
1720 next/previous character if nothing is cached there yet, or if we
1721 were just reseat()'ed to a new position.
1723 * xdisp.c (set_cursor_from_row): Set start and stop points
1724 according to the row's direction when priming the loop that looks
1725 for the glyph on which to display cursor.
1726 (single_display_spec_intangible_p): Function deleted.
1727 (display_prop_intangible_p): Reimplement to call
1728 handle_display_spec instead of single_display_spec_intangible_p.
1729 Accept 3 additional arguments needed by handle_display_spec.
1730 This fixes incorrect cursor motion across display property with complex
1731 values: lists, `(when COND...)' forms, etc.
1732 (single_display_spec_string_p): Support property values that are
1733 lists with the argument STRING its top-level element.
1734 (display_prop_string_p): Fix the condition for processing a
1735 property that is a list to be consistent with handle_display_spec.
1736 (handle_display_spec): New function, refactored from the
1737 last portion of handle_display_prop.
1738 (compute_display_string_pos): Accept additional argument
1739 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1740 value of a `display' property is a "replacing spec".
1741 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1742 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1743 the display property, but just return a value indicating whether
1744 the display property will replace the characters it covers.
1745 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1746 frame_window_p members of struct bidi_it.
1747 (compute_display_string_pos, compute_display_string_end):
1749 (push_it): Accept second argument POSITION, where pop_it should
1750 jump to continue iteration.
1751 (reseat_1): Initialize bidi_it.disp_pos.
1753 * keyboard.c (adjust_point_for_property): Adjust the call to
1754 display_prop_intangible_p to its new signature.
1756 * dispextern.h (struct bidi_it): New member frame_window_p.
1757 (bidi_init_it): Update prototypes.
1758 (display_prop_intangible_p): Update prototype.
1759 (compute_display_string_pos, compute_display_string_end):
1761 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1764 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1766 Malloc failure behavior now depends on size of allocation.
1767 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1768 * lisp.h: Change signatures accordingly.
1769 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1770 All callers changed. (Bug#8762)
1772 * gnutls.c: Use Emacs's memory allocators.
1773 Without this change, the gnutls library would invoke malloc etc.
1774 directly, which causes problems on non-SYNC_INPUT hosts, and which
1775 runs afoul of improving memory_full behavior. (Bug#8761)
1776 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1777 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1778 xfree instead of the default malloc, realloc, free.
1779 (Fgnutls_boot): No need to check for memory allocation failure,
1780 since xmalloc does that for us.
1782 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1783 * category.c (hash_get_category_set):
1784 * ccl.c (ccl_driver):
1785 * charset.c (Fdefine_charset_internal):
1786 * charset.h (struct charset.hash_index):
1787 * composite.c (get_composition_id, gstring_lookup_cache)
1788 (composition_gstring_put_cache):
1789 * composite.h (struct composition.hash_index):
1790 * dispextern.h (struct image.hash):
1791 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1792 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1793 (hashfn_equal, hashfn_user_defined, make_hash_table)
1794 (maybe_resize_hash_table, hash_lookup, hash_put)
1795 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1796 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1797 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1798 * image.c (make_image, search_image_cache, lookup_image)
1799 (xpm_put_color_table_h):
1800 * lisp.h (struct Lisp_Hash_Table):
1801 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1802 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1803 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1804 * alloc.c (allocate_vectorlike):
1805 Check for overflow in vector size calculations.
1806 * ccl.c (ccl_driver):
1807 Check for overflow when converting EMACS_INT to int.
1808 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1809 need to be updated by these changes.
1810 * fns.c (make_hash_table, maybe_resize_hash_table):
1811 Check for integer overflow with large hash tables.
1812 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1813 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1814 (SXHASH_REDUCE): New macro.
1815 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1816 Use it instead of discarding useful hash info with large hash values.
1817 (sxhash_float): New function.
1818 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1819 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1820 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1821 Rewrite to use FIXNUM_BITS, as this simplifies things.
1822 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1823 Adjust signatures to match updated version of code.
1824 (consing_since_gc): Now EMACS_INT, since a single hash table can
1825 use more than INT_MAX bytes.
1827 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1829 Make it possible to build with GCC-4.6+ -O2 -flto.
1831 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1833 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1835 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1836 Call minibuffer-inactive-mode.
1838 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1840 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1841 Update dependencies.
1843 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1845 * data.c (init_data): Remove code for UTS, this system is not
1848 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1850 Don't force ./temacs to start in terminal mode.
1852 * frame.c (make_initial_frame): Initialize faces in all cases, not
1853 only when CANNOT_DUMP is defined.
1854 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1856 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1858 * dispnew.c (add_window_display_history): Use const for the string
1859 pointer. Remove declaration, not needed.
1861 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1863 Use 'inline', not 'INLINE'.
1864 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1865 * alloc.c, fontset.c (INLINE): Remove.
1866 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1867 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1868 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1869 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1870 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1872 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1874 Make it possible to run ./temacs.
1876 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1877 syms_of_callproc does the same thing. Remove test for
1878 "initialized", do it in the caller.
1879 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1881 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1883 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1884 (read_minibuf): Use get_minibuffer.
1885 (syms_of_minibuf): Use DEFSYM.
1886 (Qmetadata): New var.
1887 * data.c (Qbuffer): Don't make it static.
1888 (syms_of_data): Use DEFSYM.
1890 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1892 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1893 (CCL_CODE_MIN): New macro.
1895 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1897 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1899 * eval.c (Qdebug): Now static.
1900 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1901 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1902 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1904 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1906 * image.c: Various fixes to ImageMagick code comments.
1907 (Fimagemagick_types): Doc fix.
1909 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1911 Minor fixes prompted by GCC 4.6.0 warnings.
1913 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1915 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1916 (x_clipboard_manager_save_all): Move extern decl to ...
1917 * xterm.h: ... here, so that it can be checked for consistency.
1919 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1921 * xselect.c (x_clipboard_manager_save_frame)
1922 (x_clipboard_manager_save_all): New functions.
1923 (Fx_clipboard_manager_save): Lisp function deleted.
1925 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1926 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1928 * xterm.h: Update prototype.
1930 2011-05-28 William Xu <william.xwl@gmail.com>
1932 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1935 2011-05-28 Jim Meyering <meyering@redhat.com>
1937 Avoid a sign-extension bug in crypto_hash_function.
1938 * fns.c (to_uchar): Define.
1939 (crypto_hash_function): Use it to convert some newly-signed
1940 variables to unsigned, to avoid sign-extension bugs. For example,
1941 without this change, (md5 "truc") would evaluate to
1942 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1943 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1944 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1946 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1948 Integer overflow fixes.
1950 * dbusbind.c: Serial number integer overflow fixes.
1951 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1952 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1953 to hold a serial number that is too large for a fixnum.
1954 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1955 Check for serial numbers out of range. Decode any serial number
1956 that was so large that it became a float. (Bug#8722)
1958 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1959 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1960 Use XFASTINT rather than XUINT when numbers are nonnegative.
1961 (xd_append_arg, Fdbus_method_return_internal):
1962 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1963 arguments, check that Lisp number is nonnegative, rather than
1964 silently wrapping negative numbers around. (Bug#8722)
1965 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1968 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1970 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1972 ccl: add integer overflow checks
1973 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1974 (IN_INT_RANGE): New macros.
1975 (ccl_driver): Use them to check for integer overflow when
1976 decoding a CCL program. Many of the new checks are whether XINT (x)
1977 fits in int; it doesn't always, on 64-bit hosts. The new version
1978 doesn't catch all possible integer overflows, but it's an
1979 improvement. (Bug#8719)
1981 * alloc.c (make_event_array): Use XINT, not XUINT.
1982 There's no need for unsigned here.
1984 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1985 This follows up to the 2011-05-06 change that substituted uintptr_t
1986 for EMACS_INT. This case wasn't caught back then.
1988 Rework Fformat to avoid integer overflow issues.
1989 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1990 now (part of C89). Include <verify.h>.
1991 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1992 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1993 (Fformat): Avoid the prepass trying to compute sizes; it was only
1994 approximate and thus did not catch overflow reliably. Instead, walk
1995 through the format just once, formatting and computing sizes as we go,
1996 checking for integer overflow at every step, and allocating a larger
1997 buffer as needed. Keep track separately whether the format is
1998 multibyte. Keep only the most-recently calculated precision, rather
1999 than them all. Record whether each argument has been converted to
2000 string. Use EMACS_INT, not int, for byte and char and arg counts.
2001 Support field widths and precisions larger than INT_MAX. Avoid
2002 sprintf's undefined behavior with conversion specifications such as %#d
2003 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2004 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2005 formatting out-of-range floating point numbers with int
2008 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2010 * data.c: Avoid integer truncation in expressions involving floats.
2011 * data.c: Include <intprops.h>.
2012 (arith_driver): When there's an integer overflow in an expression
2013 involving floating point, convert the integers to floating point
2014 so that the resulting value does not suffer from catastrophic
2015 integer truncation. For example, on a 64-bit host (* 4
2016 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2017 Do not rely on undefined behavior after integer overflow.
2019 merge count_size_as_multibyte, parse_str_to_multibyte
2020 * character.c, character.h (count_size_as_multibyte):
2021 Rename from parse_str_to_multibyte; all uses changed.
2022 Check for integer overflow.
2023 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2024 since it's now a duplicate of the other. This is more of
2025 a character than a buffer op, so better that it's in character.c.
2026 * fns.c, print.c: Adjust to above changes.
2028 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2030 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2032 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2034 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2035 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2036 (x_clipboard_manager_save): Now static.
2037 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2039 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2040 (crypto_hash_function): Now static.
2041 Fix pointer signedness problems. Avoid unnecessary initializations.
2043 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2045 * termhooks.h (Vselection_alist): Make it terminal-local.
2047 * terminal.c (create_terminal): Initialize it.
2049 * xselect.c: Support for clipboard managers.
2050 (Vselection_alist): Move to termhooks.h as terminal-local var.
2051 (LOCAL_SELECTION): New macro.
2052 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2053 (symbol_to_x_atom): Remove gratuitous arg.
2054 (x_handle_selection_request, lisp_data_to_selection_data)
2055 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2056 (x_own_selection, x_get_local_selection, x_convert_selection):
2057 New arg, specifying work frame. Use terminal-local Vselection_alist.
2058 (some_frame_on_display): Delete unused function.
2059 (Fx_own_selection_internal, Fx_get_selection_internal)
2060 (Fx_disown_selection_internal, Fx_selection_owner_p)
2061 (Fx_selection_exists_p): New optional frame arg.
2062 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2063 (x_handle_selection_clear): Don't treat other terminals with the
2064 same keyboard specially. Use the terminal-local Vselection_alist.
2065 (x_clear_frame_selections): Use Frun_hook_with_args.
2067 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2069 * xterm.h: Add support for those atoms.
2071 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2073 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2074 (converted_selections, conversion_fail_tag): New global variables.
2075 (x_selection_request_lisp_error): Free the above.
2076 (x_get_local_selection): Remove unnecessary code.
2077 (x_reply_selection_request): Args changed; handle arbitrary array
2078 of converted selections stored in converted_selections.
2079 Separate the XChangeProperty and SelectionNotify steps.
2080 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2081 (x_convert_selection): New function.
2082 (x_handle_selection_event): Simplify.
2083 (x_get_foreign_selection): Don't ignore incoming requests while
2084 waiting for an answer; this will fail when we implement
2085 SAVE_TARGETS, and seems unnecessary anyway.
2086 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2087 (Vx_sent_selection_functions): Doc fix.
2089 2011-05-26 Leo Liu <sdl.web@gmail.com>
2091 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2093 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2095 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2097 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2098 for fringe update if it has periodic bitmap.
2099 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2100 and fringe_bitmap_periodic_p.
2102 * fringe.c (get_fringe_bitmap_data): New function.
2103 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2104 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2105 row. Mark glyph row for fringe update if periodicity changed.
2107 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2108 for fringe update unless it has periodic bitmap.
2110 2011-05-25 Kenichi Handa <handa@m17n.org>
2112 * xdisp.c (get_next_display_element): Set correct it->face_id for
2113 a static composition.
2115 2011-05-24 Leo Liu <sdl.web@gmail.com>
2118 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2120 * fns.c (crypto_hash_function, Fsha1): New function.
2121 (Fmd5): Use crypto_hash_function.
2122 (syms_of_fns): Add Ssha1.
2124 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2126 * gnutls.c: Remove unused macros.
2127 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2128 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2129 Remove macros that are defined and never used.
2130 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2132 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2134 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2135 (Fx_get_selection_internal): Minor cleanup.
2136 (Fx_own_selection_internal): Rename arguments for consistency with
2139 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2141 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2143 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2145 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2147 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2149 * dispnew.c (scrolling_window): Don't exclude the case that the
2150 last enabled row in the desired matrix touches the bottom boundary.
2152 2011-05-21 Glenn Morris <rgm@gnu.org>
2154 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2155 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2156 and add some more files.
2158 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2160 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2161 report_file_error introduced by the change from 2011-05-07.
2163 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2165 * systime.h (Time): Define only if emacs is defined.
2166 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2167 where the include path doesn't have X11/X.h by default. See
2168 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2170 2011-05-20 Kenichi Handa <handa@m17n.org>
2172 * composite.c (find_automatic_composition): Fix previous change.
2174 2011-05-20 Glenn Morris <rgm@gnu.org>
2176 * lisp.mk: New file, split from Makefile.in.
2177 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2178 (shortlisp): Remove.
2179 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2181 2011-05-19 Glenn Morris <rgm@gnu.org>
2183 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2184 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2185 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2186 (lisp): Set the order to that of loadup.el.
2187 (shortlisp): Make it a copy of $lisp.
2188 (SOME_MACHINE_LISP): Remove.
2189 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2190 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2192 2011-05-18 Kenichi Handa <handa@m17n.org>
2194 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2195 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2196 (find_automatic_composition): Mostly rewrite for efficiency.
2198 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
2200 * makefile.w32-in: Update dependencies.
2202 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2204 * menu.c: Include limits.h (fixes the MS-Windows build broken by
2205 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
2207 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
2209 Fix some integer overflow issues, such as string length overflow.
2211 * insdel.c (count_size_as_multibyte): Check for string overflow.
2213 * character.c (lisp_string_width): Check for string overflow.
2214 Use EMACS_INT, not int, for string indexes and lengths; in
2215 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2216 the resulting string length overflows an EMACS_INT; instead,
2217 report a string overflow if no precision given. When checking for
2218 precision exhaustion, use a check that cannot possibly have
2219 integer overflow. (Bug#8675)
2220 * character.h (lisp_string_width): Adjust to new signature.
2222 * alloc.c (string_overflow): New function.
2223 (Fmake_string): Use it. This doesn't change behavior, but saves
2224 a few bytes and will simplify future changes.
2225 * character.c (string_escape_byte8): Likewise.
2226 * lisp.h (string_overflow): New decl.
2228 Fixups, following up to the user-interface timestamp change.
2229 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2230 for UI timestamps, instead of unsigned long.
2231 * msdos.c (mouse_get_pos): Likewise.
2232 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
2233 * w32gui.h (Time): Define by including "systime.h" rather than by
2234 declaring it ourselves. (Bug#8664)
2236 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2237 * image.c (clear_image_cache): Likewise.
2239 * term.c (term_mouse_position): Don't assume time_t wraparound.
2241 Be more systematic about user-interface timestamps.
2242 Before, the code sometimes used 'Time', sometimes 'unsigned long',
2243 and sometimes 'EMACS_UINT', to represent these timestamps.
2244 This change causes it to use 'Time' uniformly, as that's what X uses.
2245 This makes the code easier to follow, and makes it easier to catch
2246 integer overflow bugs such as Bug#8664.
2247 * frame.c (Fmouse_position, Fmouse_pixel_position):
2248 Use Time, not unsigned long, for user-interface timestamps.
2249 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2250 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2251 * keyboard.h (last_event_timestamp): Likewise.
2252 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2253 * menu.h (xmenu_show): Likewise.
2254 * term.c (term_mouse_position): Likewise.
2255 * termhooks.h (struct input_event.timestamp): Likewise.
2256 (struct terminal.mouse_position_hook): Likewise.
2257 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2258 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2259 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2260 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2262 * menu.h, termhooks.h: Include "systime.h", for Time.
2264 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2265 Don't assume that the difference between two unsigned long values
2266 can fit into an integer. At this point, we know button_down_time
2267 <= event->timestamp, so the difference must be nonnegative, so
2268 there's no need to cast the result if double-click-time is
2269 nonnegative, as it should be; check that it's nonnegative, just in
2270 case. This bug is triggered when events are more than 2**31 ms
2271 apart (about 25 days). (Bug#8664)
2273 * xselect.c (last_event_timestamp): Remove duplicate decl.
2274 (x_own_selection): Remove needless cast to unsigned long.
2276 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2277 that always fit in int. Use a sentinel instead of a counter, to
2278 avoid a temp and to allay GCC's concerns about possible int overflow.
2279 * frame.h (struct frame): Use int for menu_bar_items_used
2280 instead of EMACS_INT, since it always fits in int.
2282 * menu.c (grow_menu_items): Check for int overflow.
2284 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2286 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2287 Before, the code was not consistent. These values cannot exceed
2288 2**31 - 1 so there's no need to make them unsigned.
2289 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2290 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2291 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2293 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2295 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2296 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2297 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2298 presumably because the widths might not match.
2300 * window.c (size_window): Avoid needless test at loop start.
2302 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2304 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2306 2011-05-12 Drew Adams <drew.adams@oracle.com>
2308 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2310 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2312 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2313 `width' to `bar_area_x' and `bar_area_width', respectively.
2314 (x_scroll_run): Take account of fringe background extension.
2316 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2317 Rename local vars `left' and `width' to `bar_area_x' and
2318 `bar_area_width', respectively.
2319 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2320 background extension.
2322 2011-05-10 Jim Meyering <meyering@redhat.com>
2324 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2326 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
2328 * image.c (Finit_image_library): Return t for built-in image types,
2329 like pbm and xbm. (Bug#8640)
2331 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2333 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2335 2011-05-07 Eli Zaretskii <eliz@gnu.org>
2337 * w32console.c (Fset_screen_color): Doc fix.
2338 (Fget_screen_color): New function.
2339 (syms_of_ntterm): Defsubr it.
2341 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2342 unlink the temporary file if Fcall_process didn't create it in the
2344 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2345 child process will be redirected to a file specified with `:file'.
2346 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2347 cue to call_process_cleanup not to close that handle.
2349 2011-05-07 Ben Key <bkey76@gmail.com>
2351 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2352 one of two shell specific rules, either bootstrap-temacs-CMD or
2353 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2354 to the previous implementation of the bootstrap-temacs rule.
2355 The bootstrap-temacs-CMD rule is similar to the previous
2356 implementation of the bootstrap-temacs rule except that it
2357 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2360 These changes, along with some changes to nt/configure.bat,
2361 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2362 earlier fix to add support for --cflags and --ldflags options
2363 that include quotes so that it works whether make uses cmd or
2366 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
2368 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2369 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2371 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2372 a string. Handle both cases.
2373 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2374 (Fdbus_register_method): Use Qinvalid_function.
2376 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2378 * makefile.w32-in: Update dependencies.
2379 (LISP_H): Add inttypes.h and stdin.h.
2380 (PROCESS_H): Add unistd.h.
2382 2011-05-06 Eli Zaretskii <eliz@gnu.org>
2384 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2385 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2387 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
2389 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2391 * term.c (vfatal): Remove stray call to va_end.
2392 It's not needed and the C Standard doesn't allow it here anyway.
2394 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2395 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2397 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2400 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2402 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2404 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2406 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2408 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2410 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2411 * charset.c (Fdefine_charset_internal): Don't initialize
2412 charset.code_space[15]. The value was garbage, on hosts with
2413 32-bit int (Bug#8600).
2415 * lread.c (read_integer): Be more consistent with string-to-number.
2416 Use string_to_number to do the actual conversion; this avoids
2417 rounding errors and fixes some other screwups. Without this fix,
2418 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2419 (digit_to_number): Move earlier, for benefit of read_integer.
2420 Return -1 if the digit is out of range for the base, -2 if it is
2421 not a digit in any supported base. (Bug#8602)
2423 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2425 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2426 to match comment at start of function. This also removes a
2427 GCC warning about overflow in a 32+64-bit port.
2429 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2431 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2432 Reported by Stefan Monnier in
2433 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2434 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2435 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2437 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2438 (EMACS_UINTPTR): Likewise, with uintptr_t.
2440 * lisp.h: Prefer 64-bit EMACS_INT if available.
2441 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2442 on 32-bit hosts that have 64-bit int, so that they can access
2444 However, temporarily disable this change unless the temporary
2445 symbol WIDE_EMACS_INT is defined.
2447 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2449 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2450 This removes an assumption that EMACS_INT and long are the same
2451 width as pointers. The assumption is true for Emacs porting targets
2452 now, but we want to make other targets possible.
2453 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2454 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2455 In the rest of the code, change types of integers that hold casted
2456 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2457 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2458 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2459 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2460 No need to cast type when ORing.
2461 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2462 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2463 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2464 assume EMACS_INT is the same width as char *.
2465 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2466 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2467 Remove no-longer-needed casts.
2468 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2469 (xg_tool_bar_help_callback, xg_make_tool_item):
2470 Use EMACS_INTPTR to hold an integer
2471 that will be cast to void *; this can avoid a GCC warning
2472 if EMACS_INT is not the same width as void *.
2473 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2474 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2475 (current_message_1, set_message_1):
2476 Use a local to convert to proper width without a cast.
2477 * xmenu.c (dialog_selection_callback): Likewise.
2479 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2480 Also, don't assume VALBITS / RAND_BITS is less than 5,
2481 and don't rely on undefined behavior when shifting a 1 left into
2483 * lisp.h (get_random): Change signature to match.
2485 * lread.c (hash_string): Use size_t, not int, for hash computation.
2486 Normally we prefer signed values; but hashing is special, because
2487 it's better to use unsigned division on hash table sizes so that
2488 the remainder is nonnegative. Also, size_t is the natural width
2489 for hashing into memory. The previous code used 'int', which doesn't
2490 retain enough info to hash well into very large tables.
2491 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2493 * dbusbind.c: Don't possibly lose pointer info when converting.
2494 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2495 Use XPNTR rather than XHASH, so that the high-order bits of
2496 the pointer aren't lost when converting through void *.
2498 * eval.c (Fautoload): Don't double-shift a pointer.
2500 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2502 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2504 * gnutls.c (DEF_GNUTLS_FN):
2505 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2507 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2509 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2512 2011-05-05 Eli Zaretskii <eliz@gnu.org>
2514 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2515 New version that can reserve upto 2GB of heap space.
2517 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
2519 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2521 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2523 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2524 `gnutls_certificate_set_x509_key_file'.
2526 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
2528 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2529 Update dependencies.
2531 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2533 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2534 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2535 Remove unused parameter `fildes'.
2536 * process.c (read_process_output, send_process): Don't pass it.
2538 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2540 Fix previous change: the library cache is defined in w32.c.
2541 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2542 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2544 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2546 Implement dynamic loading of GnuTLS on Windows.
2548 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2549 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2550 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2553 * gnutls.c (Qgnutls_dll): Define.
2554 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2555 (gnutls_*): Declare function pointers.
2556 (init_gnutls_functions): New function to initialize function pointers.
2557 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2558 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2559 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2560 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2561 (emacs_gnutls_write, emacs_gnutls_read)
2562 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2563 (Fgnutls_available_p): New function.
2564 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2565 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2566 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2568 * image.c: Include w32.h.
2569 (Vimage_type_cache): Delete.
2570 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2571 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2572 (w32_delayed_load): Move to w32.c.
2574 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2576 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2577 (w32_delayed_load): Move from image.c. When loading a library, record
2578 its filename in the :loaded-from property of the library id.
2579 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2580 Initialize and staticpro them.
2581 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2583 * process.c: Include lisp.h before w32.h, not after.
2584 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2585 instead of gnutls_record_check_pending.
2587 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2589 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2591 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2592 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2595 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2597 * xterm.c (x_set_frame_alpha): Do not set property on anything
2598 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2600 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2602 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2604 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2606 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2607 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2608 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2609 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2610 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2611 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2612 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2613 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2614 (Qgnutls_bootprop_callbacks_verify): Make static.
2616 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2618 * callproc.c: Indentation fixup.
2620 * sysdep.c (wait_for_termination_1): Make static.
2621 (wait_for_termination, interruptible_wait_for_termination):
2622 Move after wait_for_termination_1.
2624 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2626 * sysdep.c (interruptible_wait_for_termination): New function
2627 which is like wait_for_termination, but allows keyboard
2630 * callproc.c (Fcall_process): Add (:file "file") as an option for
2632 (Fcall_process_region): Ditto.
2634 2011-04-30 Eli Zaretskii <eliz@gnu.org>
2636 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2637 rather than `XVECTOR (FOO)->size'.
2639 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2640 inttypes.h, as a gnulib replacement is used if it not available in
2643 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2645 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2646 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2647 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2649 * coding.c (coding_alloc_by_realloc): Error out if destination
2650 will grow beyond MOST_POSITIVE_FIXNUM.
2651 (decode_coding_emacs_mule): Abort if there isn't enough place in
2652 charbuf for the composition carryover bytes. Reserve an extra
2653 space for up to 2 characters produced in a loop.
2654 (decode_coding_iso_2022): Abort if there isn't enough place in
2655 charbuf for the composition carryover bytes.
2657 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2659 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2660 aborting when %lld or %lll format is passed.
2661 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2662 %llo or %llx format is passed. (Bug#8545)
2664 * window.c (window_scroll_line_based): Use a marker instead of
2665 simple variables to record original value of point. (Bug#7952)
2667 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2668 produced by %s or %c overflows available buffer space. (Bug#8545)
2670 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2672 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
2673 (SIZE_MAX): Move defn after all includes, as they might #define it.
2675 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2677 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2679 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2681 * keyboard.c (Qdelayed_warnings_hook): Define.
2682 (command_loop_1): Run `delayed-warnings-hook'
2683 if Vdelayed_warnings_list is non-nil.
2684 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2685 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2687 2011-04-28 Eli Zaretskii <eliz@gnu.org>
2689 * doprnt.c (doprnt): Don't return value smaller than the buffer
2690 size if the message was truncated. (Bug#8545).
2692 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2694 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2695 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2697 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2699 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2701 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
2703 * makefile.w32-in: Update dependencies.
2705 2011-04-27 Eli Zaretskii <eliz@gnu.org>
2707 Improve `doprnt' and its usage. (Bug#8545)
2708 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2709 `format_end'. Remove support for %l as a conversion specifier.
2710 Don't use xrealloc. Improve diagnostics when the %l size modifier
2711 is used. Update the commentary.
2713 * eval.c (verror): Simplify calculation of size_t.
2715 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2718 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2720 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2723 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2725 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2726 This makes this file independent of the recent pseudovector change.
2728 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2730 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2732 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2733 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2734 Remove unused local.
2735 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2737 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2738 GCC 4.6.0 optimizes based on type-based alias analysis.
2739 For example, if b is of type struct buffer * and v of type struct
2740 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2741 != &v->size, and therefore "v->size = 1; b->size = 2; return
2742 v->size;" must therefore return 1. This assumption is incorrect
2743 for Emacs, since it type-puns struct Lisp_Vector * with many other
2744 types. To fix this problem, this patch adds a new type struct
2745 vectorlike_header that documents the constraints on layout of vectors
2746 and pseudovectors, and helps optimizing compilers not get fooled
2747 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2748 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2749 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2751 (XSETPVECTYPE): Rewrite in terms of new macro.
2752 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2753 This is a bit clearer, and further avoids the possibility of
2754 undesirable aliasing.
2755 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2756 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2757 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2758 since Lisp_Subr is a special case (no "next" field).
2759 (ASIZE): Now uses header.size rather than size.
2760 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2761 to avoid the hassle of writing XVECTOR (foo)->header.size.
2762 (struct vectorlike_header): New type.
2763 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2764 object, to help avoid aliasing.
2765 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2766 (SUBRP): Likewise, since Lisp_Subr is a special case.
2767 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2768 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2769 (struct Lisp_Hash_Table): Combine first two members into a single
2770 struct vectorlike_header member. All uses of "size" and "next" members
2771 changed to be "header.size" and "header.next".
2772 * buffer.h (struct buffer): Likewise.
2773 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2774 * frame.h (struct frame): Likewise.
2775 * process.h (struct Lisp_Process): Likewise.
2776 * termhooks.h (struct terminal): Likewise.
2777 * window.c (struct save_window_data, struct saved_window): Likewise.
2778 * window.h (struct window): Likewise.
2779 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2780 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2781 * buffer.c (init_buffer_once): Likewise.
2782 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2784 * process.c (Fformat_network_address): Use local var for size,
2787 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2789 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2790 * data.c (atof): Remove decl; no longer used or needed.
2791 (digit_to_number): Move to lread.c.
2792 (Fstring_to_number): Use new string_to_number function, to be
2793 consistent with how the Lisp reader treats infinities and NaNs.
2794 Do not assume that floating-point numbers represent EMACS_INT
2795 without losing information; this is not true on most 64-bit hosts.
2796 Avoid double-rounding errors, by insisting on integers when
2797 parsing non-base-10 numbers, as the documentation specifies.
2798 * lisp.h (string_to_number): New decl, replacing ...
2799 (isfloat_string): Remove.
2800 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2801 (read1): Do not accept +. and -. as integers; this
2802 appears to have been a coding error. Similarly, do not accept
2803 strings like +-1e0 as floating point numbers. Do not report
2804 overflow for integer overflows unless the base is not 10 which
2805 means we have no simple and reliable way to continue.
2806 Break out the floating-point parsing into a new
2807 function string_to_number, so that Fstring_to_number parses
2808 floating point numbers consistently with the Lisp reader.
2809 (digit_to_number): Move here from data.c. Make it static inline.
2810 (E_CHAR, EXP_INT): Remove, replacing with ...
2811 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2812 (string_to_number): New function, replacing isfloat_string.
2813 This function checks for valid syntax and produces the resulting
2814 Lisp float number too. Rework it so that string-to-number
2815 no longer mishandles examples like "1.0e+". Use strtoumax,
2816 so that overflow for non-base-10 numbers is reported only when
2817 there's no portable and simple way to convert to floating point.
2819 * textprop.c (set_text_properties_1): Rewrite for clarity,
2820 and to avoid GCC warning about integer overflow.
2822 * intervals.h (struct interval): Use EMACS_INT for members
2823 where EMACS_UINT might cause problems. See
2824 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2825 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2826 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2828 (offset_intervals): Tell GCC not to worry about length overflow
2829 when negating a negative length.
2831 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2832 (overrun_check_free): Likewise.
2834 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2835 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2838 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2839 (gnutls_make_error): Rename local to avoid shadowing.
2840 (gnutls_emacs_global_deinit): ifdef out; not used.
2841 (Fgnutls_boot): Use const for pointer to readonly storage.
2842 Comment out unused local. Fix pointer signedness problems.
2844 * lread.c (openp): Don't stuff size_t into an 'int'.
2845 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2846 about possible signed overflow.
2848 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2849 (GDK_KEY_g): Don't define if already defined.
2850 (xg_prepare_tooltip): Avoid pointer signedness problem.
2851 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2853 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2854 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2856 * xfns.c (Fx_window_property): Simplify a bit,
2857 to make a bit faster and to avoid GCC 4.6.0 warning.
2858 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2860 * fns.c (internal_equal): Don't assume size_t fits in int.
2862 * alloc.c (compact_small_strings): Tighten assertion a little.
2864 Replace pEd with more-general pI, and fix some printf arg casts.
2865 * lisp.h (pI): New macro, generalizing old pEd macro to other
2866 conversion specifiers. For example, use "...%"pI"d..." rather
2867 than "...%"pEd"...".
2868 (pEd): Remove. All uses replaced with similar uses of pI.
2869 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2870 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2871 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2872 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2873 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2874 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2875 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2877 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2878 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2879 * print.c (safe_debug_print, print_object): Likewise.
2880 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2882 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2883 avoiding the 0 flag, which is not portable.
2884 * process.c (Fmake_network_process): Use pI to avoid cast.
2885 * region-cache.c (pp_cache): Likewise.
2886 * xdisp.c (decode_mode_spec): Likewise.
2887 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2888 behavior on 64-bit hosts with printf arg.
2889 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2890 (x_stop_queuing_selection_requests): Likewise.
2891 (x_get_window_property): Don't truncate byte count to an 'int'
2894 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2895 here, since it parses constructs like leading '-' and spaces,
2896 which are not wanted; and it overflows with large numbers.
2897 Instead, simply match F[0-9]+, which is what is wanted anyway.
2899 * alloc.c: Remove unportable assumptions about struct layout.
2900 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2901 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2902 (allocate_vectorlike, make_pure_vector): Use the new macros,
2903 plus offsetof, to remove unportable assumptions about struct layout.
2904 These assumptions hold on all porting targets that I know of, but
2905 they are not guaranteed, they're easy to remove, and removing them
2906 makes further changes easier.
2908 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2909 This doesn't fix a bug but makes the code clearer.
2910 (string_overrun_cookie): Now const. Use initializers that
2911 don't formally overflow signed char, to avoid warnings.
2912 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2913 can cause Emacs to crash when string overrun checking is enabled.
2914 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2915 multiple of sizeof (EMACS_INT); it need not be, if
2916 alignof(EMACS_INT) < sizeof (EMACS_INT).
2917 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2919 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2921 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2923 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2925 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2926 supposed to be handshaking. (Bug#8556)
2927 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2929 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2931 * lisp.h (Qdebug): List symbol.
2932 * eval.c (Qdebug): Restore global linkage.
2933 * keyboard.c (debug-on-event): New variable.
2934 (handle_user_signal): Break into debugger when debug-on-event
2935 matches the current signal symbol.
2937 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2939 * alloc.c (check_sblock, check_string_bytes)
2940 (check_string_free_list): Convert to standard C.
2942 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2944 * w32.c (emacs_gnutls_push): Fix typo.
2946 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2948 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2949 "cast to pointer from integer of different size".
2951 Improve doprnt and its use in verror. (Bug#8545)
2952 * doprnt.c (doprnt): Document the set of format control sequences
2953 supported by the function. Use SAFE_ALLOCA instead of always
2956 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2957 is one byte too soon. Don't use xrealloc; instead xfree and
2960 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2962 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2965 * gnutls.c: Renamed global_initialized to
2966 gnutls_global_initialized. Added internals for the
2967 :verify-hostname-error, :verify-error, and :verify-flags
2968 parameters of `gnutls-boot' and documented those parameters in the
2969 docstring. Start callback support.
2970 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2971 unless a fatal error occurred. Call gnutls_alert_send_appropriate
2972 on error. Return error code.
2973 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2974 (emacs_gnutls_read): Likewise.
2975 (Fgnutls_boot): Return handshake error code.
2976 (emacs_gnutls_handle_error): New function.
2977 (wsaerror_to_errno): Likewise.
2979 * w32.h (emacs_gnutls_pull): Add prototype.
2980 (emacs_gnutls_push): Likewise.
2982 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2983 (emacs_gnutls_push): Likewise.
2985 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2987 * process.c (wait_reading_process_output): Check if GnuTLS
2988 buffered some data internally if no FDs are set for TLS
2991 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2992 (LIBS): Link to USER_LIBS.
2993 ($(BLD)/gnutls.$(0)): New target.
2995 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2997 * xdisp.c (handle_single_display_spec): Rename the
2998 display_replaced_before_p argument into display_replaced_p, to
2999 make it consistent with the commentary. Fix typos in the
3002 * textprop.c (syms_of_textprop): Remove dead code.
3003 (copy_text_properties): Delete obsolete commentary about an
3004 interface that was deleted long ago. Fix typos in the description
3007 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3008 to changes in oldXMenu/XMenu.h from 2011-04-16.
3009 <menu_help_message, prev_menu_help_message>: Constify.
3010 (IT_menu_make_room): menu->help_text is now `const char **';
3013 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3014 to changes in oldXMenu/XMenu.h from 2011-04-16.
3015 (struct XMenu): Declare `help_text' `const char **'.
3017 * xfaces.c <Qunspecified>: Make extern again.
3019 * syntax.c: Include sys/types.h before including regex.h, as
3022 * doc.c (get_doc_string): Improve the format passed to `error'.
3024 * doprnt.c (doprnt): Improve commentary.
3026 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3028 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3031 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3032 changes in globals.h immediately force recompilation.
3033 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3034 $(CURDIR)/s/ms-w32.h.
3035 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3037 * character.c (Fchar_direction): Function deleted.
3038 (syms_of_character): Don't defsubr it.
3039 <char-direction-table>: Deleted.
3041 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3043 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3044 * doprnt.c: Include limits.h.
3045 (SIZE_MAX): New macro.
3046 (doprnt): Return a size_t value. 2nd arg is now size_t.
3047 Many local variables are now size_t instead of int or unsigned.
3048 Improve overflow protection. Support `l' modifier for integer
3049 conversions. Support %l conversion. Don't assume an EMACS_INT
3050 argument for integer conversions and for %c.
3052 * lisp.h (doprnt): Restore prototype.
3054 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3057 * Makefile.in (base_obj): Add back doprnt.o.
3059 * deps.mk (doprnt.o): Add back prerequisites.
3060 (callint.o): Depend on character.h.
3062 * eval.c (internal_lisp_condition_case): Include the handler
3063 representation in the error message.
3064 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3065 when breaking from the loop.
3067 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3069 * callint.c (Fcall_interactively): When displaying error message
3070 about invalid control letter, pass the character's codepoint, not
3071 a pointer to its multibyte form. Improve display of the character
3072 in octal and display also its hex code.
3074 * character.c (char_string): Use %x to display the (unsigned)
3075 codepoint of an invalid character, to avoid displaying a bogus
3078 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3079 `error', not SYMBOL_NAME itself.
3081 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3082 character arguments to `error'.
3084 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3085 to `error' in error message about FINAL_CHAR argument. Make sure
3086 FINAL_CHAR is a character, and use %c when it is passed as
3087 argument to `error'.
3089 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3091 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3093 * w32.c: Include <time.h>.
3094 (sys_localtime): New function.
3096 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
3098 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3100 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3102 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3104 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3107 2011-04-19 Eli Zaretskii <eliz@gnu.org>
3109 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3110 gl_state.e_property when gl_state.object is Qt.
3112 * insdel.c (make_gap_larger): Remove limitation of buffer size
3115 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
3117 * xdisp.c (lookup_glyphless_char_display)
3118 (produce_glyphless_glyph): Handle cons cell entry in
3119 glyphless-char-display.
3120 (Vglyphless_char_display): Document it.
3122 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3123 glyphless-char-display.
3125 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
3127 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3129 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3131 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3132 definition for no-X builds.
3134 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3136 Static checks with GCC 4.6.0 and non-default toolkits.
3138 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3140 * process.c (keyboard_bit_set): Define only if SIGIO.
3141 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3142 (send_process): Repair possible setjmp clobbering.
3144 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3146 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3148 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3150 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3151 Define only if needed.
3153 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3154 by pacifying GCC about it. Maybe it's time to retire it?
3155 * xfaces.c (USG, __TIMEVAL__): Likewise.
3157 * dispextern.h (struct redisplay_interface): Rename param
3159 * termhooks.h (struct terminal): Likewise.
3160 * xterm.c (xembed_send_message): Likewise.
3162 * insdel.c (make_gap_smaller): Define only if
3163 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3165 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3168 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3169 so that we aren't warned about unused symbols.
3171 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3173 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
3175 * xfns.c (x_real_positions): Mark locals as initialized.
3177 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3179 * xterm.c: Fix problems found by static analysis with other toolkits.
3180 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
3181 (x_dispatch_event): Declare static if USE_GTK, and
3182 define if USE_GTK || USE_X_TOOLKIT.
3183 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
3184 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
3185 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3186 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
3188 * xmenu.c (menu_help_callback): Pointer type fixes.
3189 Use const pointers when pointing at readonly data. Avoid pointer
3191 (FALSE): Remove unused macro.
3192 (update_frame_menubar): Remove unused decl.
3194 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3196 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3197 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3198 (single_menu_item): Rename local to avoid shadowing.
3200 * keyboard.c (make_lispy_event): Remove unused local var.
3202 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3203 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3205 * bitmaps: Change bitmaps from unsigned char back to the X11
3206 compatible char. Avoid the old compiler warnings about
3207 out-of-range initializers by using, for example, '\xab' rather
3210 * xgselect.c (xgselect_initialize): Check vs interface
3211 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3213 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3215 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3216 to read-only memory.
3218 * fns.c (vector): Remove; this old hack is no longer needed.
3220 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
3222 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
3224 * xrdb.c (x_load_resources): Omit unused local.
3226 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
3227 (x_window): Rename locals to avoid shadowing.
3228 (USG): Use the kludged USG macro, to pacify gcc.
3230 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
3231 (x_term_init): Remove local to avoid shadowing.
3233 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
3235 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3236 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3238 2011-04-16 Eli Zaretskii <eliz@gnu.org>
3240 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3242 Fix regex.c, syntax.c and friends for buffers > 2GB.
3243 * syntax.h (struct gl_state_s): Declare character position members
3246 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3248 * textprop.c (verify_interval_modification, interval_of):
3249 Declare arguments EMACS_INT.
3251 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3254 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3256 * indent.c (Fvertical_motion): Local variable it_start is now
3259 * regex.c (re_match, re_match_2, re_match_2_internal)
3260 (bcmp_translate, regcomp, regexec, print_double_string)
3261 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3262 (re_compile_pattern, re_exec): Declare arguments and local
3263 variables `size_t' and `ssize_t' and return values `regoff_t', as
3265 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3266 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3267 <compile_stack_type>: `size' and `avail' are now `size_t'.
3269 * regex.h <regoff_t>: Use ssize_t, not int.
3270 (re_search, re_search_2, re_match, re_match_2): Arguments that
3271 specify buffer/string position and length are now ssize_t and
3272 size_t. Return type is regoff_t.
3274 2011-04-16 Ben Key <bkey76@gmail.com>
3276 * nsfont.m: Fixed bugs in ns_get_family and
3277 ns_descriptor_to_entity that were caused by using free to
3278 deallocate memory blocks that were allocated by xmalloc (via
3279 xstrdup). This caused Emacs to crash when compiled with
3280 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3281 --enable-checking=xmallocoverrun). xfree is now used to
3282 deallocate these memory blocks.
3284 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3286 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3288 emacs_write: Accept and return EMACS_INT for sizes.
3289 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3291 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3292 Accept and return EMACS_INT.
3293 (emacs_gnutls_write): Return the number of bytes written on
3295 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
3296 (emacs_read, emacs_write): Remove check for negative size, as the
3297 Emacs source code has been audited now.
3298 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3299 (emacs_read, emacs_write): Use it.
3300 * process.c (send_process): Adjust to the new signatures of
3301 emacs_write and emacs_gnutls_write. Do not attempt to store
3302 a byte offset into an 'int'; it might overflow.
3303 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
3305 * sound.c: Don't assume sizes fit in 'int'.
3306 (struct sound_device.period_size, alsa_period_size):
3307 Return EMACS_INT, not int.
3308 (struct sound_device.write, vox_write, alsa_write):
3309 Accept EMACS_INT, not int.
3310 (wav_play, au_play): Use EMACS_INT to store sizes and to
3311 record read return values.
3313 2011-04-15 Ben Key <bkey76@gmail.com>
3315 * keyboard.c (Qundefined): Don't declare static since it is used
3317 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3318 static since they are used in nsfont.m.
3320 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3322 * process.c (Qprocessp): Don't declare static.
3323 * lisp.h (Qprocessp): Declare again.
3325 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
3327 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3329 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3331 Improve C-level modularity by making more things 'static'.
3333 Don't publish debugger-only interfaces to other modules.
3334 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3335 (verify_bytepos, count_markers): Move decls to the only modules
3337 * region-cache.h (pp_cache): Likewise.
3338 * window.h (check_all_windows): Likewise.
3339 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3341 * sysdep.c (croak): Now static, if
3342 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3343 * syssignal.h (croak): Declare only if not static.
3345 * alloc.c (refill_memory_reserve): Now static if
3346 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3347 * lisp.h (refill_memory_reserve): Declare only if not static.
3349 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3350 Define only if USE_LUCID.
3352 * xrdb.c (x_customization_string, x_rm_string): Now static.
3354 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3355 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3357 * xdisp.c (draw_row_with_mouse_face): Now static.
3358 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3360 * window.h (check_all_windows): Mark externally visible.
3362 * window.c (window_deletion_count): Now static.
3364 * undo.c: Make symbols static if they're not exported.
3365 (last_undo_buffer, last_boundary_position, pending_boundary):
3368 * textprop.c (interval_insert_behind_hooks): Now static.
3369 (interval_insert_in_front_hooks): Likewise.
3371 * term.c: Make symbols static if they're not exported.
3372 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3373 (max_frame_lines, tty_set_terminal_modes):
3374 (tty_reset_terminal_modes, tty_turn_off_highlight):
3375 (get_tty_terminal): Now static.
3376 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3377 * termhooks.h (term_mouse_moveto): Do not declare if
3379 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3380 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3382 * sysdep.c: Make symbols static if they're not exported.
3383 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3385 (sigprocmask_set, full_mask): Remove; unused.
3386 (wait_debugging): Mark as visible.
3387 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3388 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3390 * syntax.c (syntax_temp): Define only if !__GNUC__.
3392 * sound.c (current_sound_device, current_sound): Now static.
3394 * search.c (searchbufs, searchbuf_head): Now static.
3396 * scroll.c (scroll_cost): Remove; unused.
3397 * dispextern.h (scroll_cost): Remove decl.
3399 * region-cache.h (pp_cache): Mark as externally visible.
3401 * process.c: Make symbols static if they're not exported.
3402 (process_tick, update_tick, create_process, chan_process):
3403 (Vprocess_alist, proc_buffered_char, datagram_access):
3404 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3405 (deactivate_process): Mark defn as static, as well as decl.
3406 * lisp.h (create_process): Remove decl.
3407 * process.h (chan_process, Vprocess_alist): Remove decls.
3409 * print.c: Make symbols static if they're not exported.
3410 (print_depth, new_backquote_output, being_printed, print_buffer):
3411 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3412 (print_interval, print_number_index, initial_stderr_stream):
3414 * lisp.h (Fprinc): Remove decl.
3415 (debug_output_compilation_hack): Mark as externally visible.
3417 * sysdep.c (croak): Move decl from here to syssignal.h.
3418 * syssignal.h (croak): Put it here, so the API can be checked when
3419 'croak' is called from dissociate_if_controlling_tty.
3421 * minibuf.c: Make symbols static if they're not exported.
3422 (minibuf_save_list, choose_minibuf_frame): Now static.
3423 * lisp.h (choose_minibuf_frame): Remove decl.
3425 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3427 * lread.c: Make symbols static if they're not exported.
3428 (read_objects, initial_obarray, oblookup_last_bucket_number):
3430 (make_symbol): Remove; unused.
3431 * lisp.h (initial_obarray, make_symbol): Remove decls.
3433 * keyboard.c: Make symbols static if they're not exported.
3434 (single_kboard, recent_keys_index, total_keys, recent_keys):
3435 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3436 (this_single_command_key_start, echoing, last_auto_save):
3437 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3438 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3439 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3440 (Vlispy_mouse_stem, double_click_count):
3442 (force_auto_save_soon): Define only if SIGDANGER.
3443 (ignore_mouse_drag_p): Now static if
3444 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3445 (print_help): Remove; unused.
3446 (stop_character, last_timer_event): Mark as externally visible.
3447 * keyboard.h (ignore_mouse_drag_p): Declare only if
3448 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3449 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3450 * lisp.h (echoing): Remove decl.
3451 (force_auto_save_soon): Declare only if SIGDANGER.
3452 * xdisp.c (redisplay_window): Simplify code, to make it more
3453 obvious that ignore_mouse_drag_p is not accessed if !defined
3454 USE_GTK && !defined HAVE_NS.
3456 * intervals.c: Make symbols static if they're not exported.
3457 (merge_properties_sticky, merge_interval_right, delete_interval):
3459 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3461 * insdel.c: Make symbols static if they're not exported.
3462 However, leave prepare_to_modify_buffer alone. It's never
3463 called from outside this function, but that appears to be a bug.
3464 (combine_after_change_list, combine_after_change_buffer):
3465 (adjust_after_replace, signal_before_change): Now static.
3466 (adjust_after_replace_noundo): Remove; unused.
3467 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3468 (signal_before_change): Remove decls.
3470 * indent.c (val_compute_motion, val_vmotion): Now static.
3472 * image.c: Make symbols static if they're not exported.
3473 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3475 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3476 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3478 * fringe.c (standard_bitmaps): Now static.
3479 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3481 * frame.c: Make symbols static if they're not exported.
3482 (x_report_frame_params, make_terminal_frame): Now static.
3483 (get_frame_param): Now static, unless HAVE_NS.
3484 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3485 (x_get_resource_string): Remove; not used.
3486 * frame.h (make_terminal_frame, x_report_frame_params):
3487 (x_get_resource_string); Remove decls.
3488 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3489 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3491 * font.c, fontset.c: Make symbols static if they're not exported.
3492 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3493 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3494 * font.c (font_close_object): Now static.
3495 * font.h (font_close_object): Remove.
3496 * fontset.c (FONTSET_OBJLIST): Remove.
3497 (free_realized_fontset) #if-0 the body, which does nothing.
3498 (face_suitable_for_char_p): #if-0, as it's never called.
3499 * fontset.h (face_suitable_for_char_p): Remove decl.
3500 * xfaces.c (face_at_string_position):
3501 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
3502 since 0 is always ASCII.
3504 * fns.c (weak_hash_tables): Now static.
3506 * fileio.c: Make symbols static if they're not exported.
3507 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3508 (Vwrite_region_annotation_buffers): Now static.
3510 * eval.c: Make symbols static if they're not exported.
3511 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3512 * lisp.h (backtrace_list): Remove decl.
3514 * emacs.c: Make symbols static if they're not exported.
3515 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3516 (fatal_error_code, fatal_error_signal_hook, standard_args):
3518 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3519 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3520 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3521 * lisp.h (fatal_error_signal_hook): Remove decl.
3522 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3524 * editfns.c: Move a (normally-unused) function to its only use.
3525 * editfns.c, lisp.h (get_operating_system_release): Remove.
3526 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3527 worth the hassle of breaking this out.
3529 * xterm.c: Make symbols static if they're not exported.
3530 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3531 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3532 (x_destroy_window, x_delete_display):
3534 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3535 (x_mouse_leave): Remove; unused.
3536 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3537 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3538 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3540 (x_mouse_leave): Declare only if WINDOWSNT.
3541 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3542 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3545 * ftxfont.c: Make symbols static if they're not exported.
3546 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3548 * font.h (ftxfont_driver): Likewise.
3550 * xfns.c: Make symbols static if they're not exported.
3551 (x_last_font_name, x_display_info_for_name):
3552 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3553 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3554 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3555 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3556 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3557 (last_show_tip_args): Now static.
3558 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3559 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3560 (x_screen_planes): Remove; unused.
3561 * dispextern.h (x_screen_planes): Remove decl.
3563 * dispnew.c: Make symbols static if they're not exported.
3564 * dispextern.h (redraw_garbaged_frames, scrolling):
3565 (increment_row_positions): Remove.
3566 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3567 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3569 (redraw_garbaged_frames): Remove; unused.
3571 * xfaces.c: Make symbols static if they're not exported.
3572 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3574 * xterm.h (defined_color): Remove decls.
3575 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3576 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3577 (menu_face_changed_default, defined_color, free_realized_face):
3578 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3579 (ascii_face_of_lisp_face): Remove; unused.
3581 * xdisp.c: Make symbols static if they're not exported.
3582 * dispextern.h (scratch_glyph_row, window_box_edges):
3583 (glyph_to_pixel_coords, set_cursor_from_row):
3584 (get_next_display_element, set_iterator_to_next):
3585 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3586 (show_mouse_face): Remove decls
3587 * frame.h (message_buf_print): Likewise.
3588 * lisp.h (pop_message, set_message, check_point_in_composition):
3590 * xterm.h (set_vertical_scroll_bar): Likewise.
3591 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3592 (message_buf_print, scratch_glyph_row, displayed_buffer):
3593 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3594 (get_next_display_element, show_mouse_face, window_box_edges):
3595 (frame_to_window_pixel_xy, check_point_in_composition):
3596 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3597 (glyph_to_pixel_coords): Remove; unused.
3599 * dired.c (file_name_completion): Now static.
3601 * dbusbind.c (xd_in_read_queued_messages): Now static.
3603 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3604 * data.c (circular_list_error): Remove.
3606 * commands.h (last_point_position, last_point_position_buffer):
3607 (last_point_position_window): Remove decls.
3608 * keyboard.c: Make these variables static.
3610 * coding.h (coding, code_convert_region, encode_coding_gap):
3612 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3613 (iso_code_class, detect_coding, code_convert_region): Now static.
3614 (encode_coding_gap): Remove; unused.
3616 * chartab.c (chartab_chars, chartab_bits): Now static.
3618 * charset.h (charset_iso_8859_1): Remove decl.
3619 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3622 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3623 * ccl.c (Vccl_program_table): Now static.
3624 (check_ccl_update): Remove; unused.
3626 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3627 * category.h: ... from here.
3628 * category.c (check_category_table, set_category_set): Now static.
3630 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3631 * lisp.h: Remove these decls.
3633 * buffer.c (buffer_count): Remove unused var.
3635 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3636 so that it's not optimized away.
3637 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3638 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3639 exported only to the debugger.
3641 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
3642 * atimer.h (run_all_atimers): Remove; not exported.
3644 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3645 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3646 was inaccessible from Lisp.
3647 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3648 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3650 alloc.c: Import and export fewer symbols, and remove unused items.
3651 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3653 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3654 it's not optimized away by whole-program optimization.
3655 (message_enable_multibyte, free_misc): Remove.
3656 (catchlist, handlerlist, mark_backtrace):
3657 Declare only if BYTE_MARK_STACK.
3658 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3659 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3660 (message_enable_multibyte): Remove decl.
3661 (free_misc, interval_free_list, float_block, float_block_index):
3662 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3663 (cons_free_list, last_marked_index):
3665 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3666 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3667 (mark_backtrace): Define only if BYTE_MARK_STACK.
3668 * xdisp.c (message_enable_multibyte): Now static.
3670 Declare Lisp_Object Q* variables to be 'static' if not exported.
3671 This makes it easier for human readers (and static analyzers)
3672 to see whether these variables are used from other modules.
3673 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3674 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3675 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3676 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3677 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3678 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3679 * xmenu.c, xselect.c:
3680 Declare Q* vars static if they are not used in other modules.
3681 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3682 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3683 Remove decls of unexported vars.
3684 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3686 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3688 Make Emacs functions such as Fatom 'static' by default.
3689 This makes it easier for human readers (and static analyzers)
3690 to see whether these functions can be called from other modules.
3691 DEFUN now defines a static function. To make the function external
3692 so that it can be used in other C modules, use the new macro DEFUE.
3693 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3694 (Finit_image_library):
3695 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3696 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3697 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3698 Remove decls, since these functions are now static.
3699 (Funintern, Fget_internal_run_time): New decls, since these functions
3700 were already external.
3702 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3703 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3704 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3705 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3706 * keyboard.c, keymap.c, lread.c:
3707 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3708 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3709 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3710 Mark functions with DEFUE instead of DEFUN,
3711 if they are used in other modules.
3712 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3713 decls for now-static functions.
3714 * buffer.h (Fdelete_overlay): Remove decl.
3715 * callproc.c (Fgetenv_internal): Mark as internal.
3716 * composite.c (Fremove_list_of_text_properties): Remove decl.
3717 (Fcomposition_get_gstring): New forward static decl.
3718 * composite.h (Fcomposite_get_gstring): Remove decl.
3719 * dired.c (Ffile_attributes): New forward static decl.
3720 * doc.c (Fdocumntation_property): New forward static decl.
3721 * eval.c (Ffetch_bytecode): New forward static decl.
3722 (Funintern): Remove extern decl; now in .h file where it belongs.
3723 * fileio.c (Fmake_symbolic_link): New forward static decl.
3724 * image.c (Finit_image_library): New forward static decl.
3725 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3726 * intervals.h (Fprevious_property_change):
3727 (Fremove_list_of_text_properties): Remove decls.
3728 * keyboard.c (Fthis_command_keys): Remove decl.
3729 (Fcommand_execute): New forward static decl.
3730 * keymap.c (Flookup_key): New forward static decl.
3731 (Fcopy_keymap): Now static.
3732 * keymap.h (Flookup_key): Remove decl.
3733 * process.c (Fget_process): New forward static decl.
3734 (Fprocess_datagram_address): Mark as internal.
3735 * syntax.c (Fsyntax_table_p): New forward static decl.
3736 (skip_chars): Remove duplicate decl.
3737 * textprop.c (Fprevious_property_change): New forward static decl.
3738 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3740 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3741 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3743 * editfns.c (Fformat): Remove unreachable code.
3745 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3747 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3750 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3752 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3753 when at ZV. (Bug#8487)
3755 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3757 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3759 * keyboard.c (parse_tool_bar_item): Likewise.
3760 * sound.c (sound_cleanup, alsa_close): Likewise.
3761 * termcap.c (tgetent): Likewise.
3762 * xfns.c (x_default_font_parameter): Likewise.
3763 * xsettings.c (read_and_apply_settings): Likewise.
3765 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3766 (overrun_check_free): Protoize.
3768 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3770 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3771 since callers should never pass a negative size.
3772 Change the signature to match that of plain 'read' and 'write'; see
3773 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3774 * lisp.h: Update prototypes of emacs_write and emacs_read.
3776 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3778 * xdisp.c (redisplay_window): Don't try to determine the character
3779 position of the scroll margin if the window start point w->startp
3780 is outside the buffer's accessible region. (Bug#8468)
3782 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3784 Fix write-region and its subroutines for buffers > 2GB.
3785 * fileio.c (a_write, e_write): Modify declaration of arguments and
3786 local variables to support buffers larger than 2GB.
3787 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3789 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3790 argument, local variables, and return value.
3792 * lisp.h: Update prototypes of emacs_write and emacs_read.
3794 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3796 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3798 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3800 Fix more problems found by GCC 4.6.0's static checks.
3802 * xdisp.c (vmessage): Use a better test for character truncation.
3804 * charset.c (load_charset_map): <, not <=, for optimization,
3805 and to avoid potential problems with integer overflow.
3806 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3807 * casetab.c (set_identity, shuffle): Likewise.
3808 * editfns.c (Fformat): Likewise.
3809 * syntax.c (skip_chars): Likewise.
3811 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3812 This also lets GCC 4.6.0 generate slightly better loop code.
3814 * callint.c (Fcall_interactively): <, not <=, for optimization.
3815 (Fcall_interactively): Count the number of arguments produced,
3816 not the number of arguments given. This is simpler and lets GCC
3817 4.6.0 generate slightly better code.
3819 * ftfont.c: Distingish more carefully between FcChar8 and char.
3820 The previous code passed unsigned char * to a functions like
3821 strlen and xstrcasecmp that expect char *, which does not
3822 conform to the C standard.
3823 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3824 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3825 char * when the C standard requires it.
3827 * keyboard.c (read_char): Remove unused var.
3829 * eval.c: Port to Windows vsnprintf (Bug#8435).
3831 (SIZE_MAX): Define if the headers do not.
3832 (verror): Do not give up if vsnprintf returns a negative count.
3833 Instead, grow the buffer. This ports to Windows vsnprintf, which
3834 does not conform to C99. Problem reported by Eli Zaretskii.
3835 Also, simplify the allocation scheme, by avoiding the need for
3836 calling realloc, and removing the ALLOCATED variable.
3838 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3840 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3841 But keep the doprint source code for now, as we might revamp it
3842 and use it again (Bug#8435).
3843 * lisp.h (doprnt): Remove.
3844 * Makefile.in (base_obj): Remove doprnt.o.
3845 * deps.mk (doprnt.o): Remove.
3847 error: Print 32- and 64-bit integers portably (Bug#8435).
3848 Without this change, on typical 64-bit hosts error ("...%d...", N)
3849 was used to print both 32- and 64-bit integers N, which relied on
3851 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3853 * lisp.h (error, verror): Mark as printf-like functions.
3854 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3855 Report overflow in size calculations when allocating printf buffer.
3856 Do not truncate output string at its first null byte.
3857 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3858 Truncate the output at a character boundary, since vsnprintf does not
3860 * charset.c (check_iso_charset_parameter): Convert internal
3861 character to string before calling 'error', since %c now has the
3863 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3864 overflow when computing char to be passed to 'error'. Do not
3865 pass Lisp_Object to 'error'; pass the integer instead.
3866 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3867 formatted with plain %d.
3869 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3871 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3873 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3875 * xterm.c (x_catch_errors): Remove duplicate declaration.
3877 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3879 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3881 2011-04-10 Jim Meyering <meyering@redhat.com>
3883 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3884 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3885 return ssize_t not "int", and use size_t as the buffer length.
3886 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3887 * gnutls.h: Update declarations.
3888 * process.c (read_process_output): Use ssize_t, to match.
3889 (send_process): Likewise.
3891 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3893 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3895 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3897 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3898 Use unsigned char, to match FcChar8 type definition.
3900 * xterm.c (handle_one_xevent):
3901 * xmenu.c (create_and_show_popup_menu):
3902 * xselect.c (x_decline_selection_request)
3903 (x_reply_selection_request): Avoid type-punned deref of X events.
3905 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3907 Fix some uses of `int' instead of EMACS_INT.
3908 * search.c (string_match_1, fast_string_match)
3909 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3910 (scan_buffer, find_next_newline_no_quit)
3911 (find_before_next_newline, search_command, Freplace_match)
3912 (Fmatch_data): Make some `int' variables be EMACS_INT.
3914 * xdisp.c (display_count_lines): 3rd argument and return value now
3915 EMACS_INT. All callers changed.
3916 (pint2hrstr): Last argument is now EMACS_INT.
3918 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3919 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3920 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3921 (decode_coding_utf_16, decode_coding_emacs_mule)
3922 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3923 (decode_coding_ccl, decode_coding_charset)
3924 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3925 (decode_coding_iso_2022, decode_coding_emacs_mule)
3926 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3927 <char_offset, last_offset>: Declare EMACS_INT.
3928 (encode_coding_utf_8, encode_coding_utf_16)
3929 (encode_coding_emacs_mule, encode_invocation_designation)
3930 (encode_designation_at_bol, encode_coding_iso_2022)
3931 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3932 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3934 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3935 (encode_invocation_designation): Last argument P_NCHARS is now
3937 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3938 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3940 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3943 * ccl.c (Fccl_execute_on_string): Declare some variables
3946 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3948 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3950 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3952 * process.c (Fformat_network_address): Doc fix.
3954 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3956 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3958 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3960 * keyboard.c (read_char): Call Lisp function help-form-show,
3961 instead of using internal_with_output_to_temp_buffer.
3962 (Qhelp_form_show): New var.
3963 (syms_of_keyboard): Use DEFSYM macro.
3965 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3967 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3969 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3971 * process.c (Flist_processes): Remove to Lisp.
3972 (list_processes_1): Delete.
3974 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3976 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3978 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3980 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3982 Fix more problems found by GCC 4.6.0's static checks.
3984 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3986 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3988 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3990 * xdisp.c (vmessage): Mark as a printf-like function.
3992 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3994 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3996 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3997 printf-like functions.
3998 (tiff_load): Add casts to remove these marks before passing them
3999 to system-supplied API.
4001 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4003 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4004 This avoids several warnings with gcc -Wstrict-overflow.
4005 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4006 directly, rather than having caller test rule sign. This avoids
4007 some unnecessary tests.
4008 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4009 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4010 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4012 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4013 (xfont_open): Avoid unnecessary tests.
4015 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4017 * composite.h, composite.c (composition_gstring_put_cache):
4018 Use EMACS_INT, not int, for length.
4020 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4021 breaking out part of COMPOSITION_DECODE_RULE.
4022 (COMPOSITION_DECODE_RULE): Use it.
4023 * composite.c (get_composition_id): Remove unused local vars,
4024 by using the new macro.
4026 * textprop.c (set_text_properties_1): Change while to do-while,
4027 since the condition is always true at first.
4029 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4030 (interval_deletion_adjustment): Return unsigned value.
4033 * process.c (list_processes_1, create_pty, read_process_output):
4034 (exec_sentinel): Remove vars that were set but not used.
4035 (create_pty): Remove unnecessary "volatile"s.
4036 (Fnetwork_interface_info): Avoid possibility of int overflow.
4037 (read_process_output): Do adaptive read buffering even if carryover.
4038 (read_process_output): Simplify nbytes computation if buffered.
4040 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4042 * syntax.c (scan_words): Remove var that was set but not used.
4043 (update_syntax_table): Use unsigned instead of int.
4045 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4046 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4047 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4049 * print.c (print_error_message): Avoid int overflow.
4051 * font.c (font_list_entities): Redo for clarity,
4052 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4054 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4055 (font_score): Avoid potential overflow in diff calculation.
4057 * fns.c (substring_both): Remove var that is set but not used.
4058 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4060 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4062 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4063 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4064 can always succeed if overflow has undefined behavior.
4066 * search.c (boyer_moore, wordify): Remove vars set but not used.
4067 (wordify): Omit three unnecessary tests.
4069 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4070 All callers changed. This avoids the need for an unused var.
4072 * casefiddle.c (casify_region): Remove var that is set but not used.
4074 * dired.c (file_name_completion): Remove var that is set but not used.
4076 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4078 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4079 (Finsert_file_contents): Remove unnecessary code checking fd.
4081 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4082 Check for integer overflow on size calculations.
4084 * buffer.c (Fprevious_overlay_change): Remove var that is set
4087 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4088 Remove vars that are set but not used.
4089 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4090 (timer_check_2): Mark vars as initialized.
4092 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4094 * image.c (lookup_image): Remove var that is set but not used.
4095 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4097 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4098 that are set but not used.
4100 * xfns.c (make_invisible_cursor): Don't return garbage
4101 if XCreateBitmapFromData fails (Bug#8410).
4103 * xselect.c (x_get_local_selection, x_handle_property_notify):
4104 Remove vars that are set but not used.
4106 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4107 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4109 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4110 Remove var that is set but not used.
4111 (scroll_bar_windows_size): Now size_t, not int.
4112 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4115 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4116 (map_tty_color) [!defined MSDOS]: Likewise.
4118 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4120 * coding.c: Remove vars that are set but not used.
4121 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4122 All callers changed.
4123 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4124 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4125 (decode_coding_charset): Remove vars that are set but not used.
4127 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4128 that is set but not used.
4130 * print.c (print_object): Remove var that is set but not used.
4132 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4133 The gnulib version avoids calling malloc in the usual case,
4134 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4135 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4136 * filelock.c (current_lock_owner): Likewise.
4137 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4138 * sysdep.c: Include allocator.h, careadlinkat.h.
4139 (emacs_no_realloc_allocator): New static constant.
4140 (emacs_readlink): New function.
4141 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4142 ../lib/careadlinkat.h.
4144 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4146 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4147 first non-nil return value).
4149 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4151 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4152 if not defined (Bug#8403).
4154 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4156 * xdisp.c (display_count_lines): Remove parameter `start',
4157 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4158 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4159 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4160 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4161 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4162 and thereabouts. All callers changed.
4163 (get_per_char_metric): Remove parameter `f', unused since
4164 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4166 2011-04-02 Jim Meyering <meyering@redhat.com>
4168 do not dereference NULL upon failed strdup
4169 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4170 (ns_get_family): Likewise.
4172 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4174 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4176 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4178 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4181 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4183 Add lexical binding.
4185 * window.c (Ftemp_output_buffer_show): New fun.
4186 (Fsave_window_excursion):
4187 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4189 * lread.c (lisp_file_lexically_bound_p): New function.
4190 (Fload): Bind Qlexical_binding.
4191 (readevalloop): Remove `evalfun' arg.
4192 Bind Qinternal_interpreter_environment.
4193 (Feval_buffer): Bind Qlexical_binding.
4194 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4196 (syms_of_lread): Declare `lexical-binding'.
4198 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4200 * keyboard.c (eval_dyn): New fun.
4201 (menu_item_eval_property): Use it.
4203 * image.c (parse_image_spec): Use Ffunctionp.
4205 * fns.c (concat, mapcar1): Accept byte-code-functions.
4207 * eval.c (Fsetq): Handle lexical vars.
4208 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4209 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4210 (FletX, Flet): Obey lexical binding.
4211 (Fcommandp): Handle closures.
4212 (Feval): New `lexical' arg.
4213 (eval_sub): New function extracted from Feval. Use it almost
4214 everywhere where Feval was used. Look up vars in lexical env.
4216 (Ffunctionp): Move from subr.el.
4217 (Ffuncall): Handle closures.
4218 (apply_lambda): Remove `eval_flags'.
4219 (funcall_lambda): Handle closures and new byte-code-functions.
4220 (Fspecial_variable_p): New function.
4221 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4222 but without exporting it to Lisp.
4224 * doc.c (Fdocumentation, store_function_docstring):
4225 * data.c (Finteractive_form): Handle closures.
4227 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4230 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4232 (exec_byte_code): New function extracted from Fbyte_code to handle new
4233 calling convention for byte-code-functions. Add new byte-codes.
4235 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
4237 * alloc.c (Fmake_symbol): Init new `declared_special' field.
4239 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4241 * xdisp.c (redisplay_internal): Fix prototype.
4243 2011-03-31 Eli Zaretskii <eliz@gnu.org>
4245 * xdisp.c (SCROLL_LIMIT): New macro.
4246 (try_scrolling): Use it when setting scroll_limit.
4247 Limit scrolling to 100 screen lines.
4248 (redisplay_window): Even when falling back on "recentering",
4249 position point in the window according to scroll-conservatively,
4250 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4252 (try_scrolling): When point is above the window, allow searching
4253 as far as scroll_max, or one screenful, to compute vertical
4254 distance from PT to the scroll margin position. This prevents
4255 try_scrolling from unnecessarily failing when
4256 scroll-conservatively is set to a value slightly larger than the
4257 window height. Clean up the case of PT below the margin at bottom
4258 of window: scroll_max can no longer be INT_MAX. When aggressive
4259 scrolling is in use, don't let point enter the opposite scroll
4260 margin as result of the scroll.
4261 (syms_of_xdisp) <scroll-conservatively>: Document the
4262 threshold of 100 lines for never-recentering scrolling.
4264 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4266 * dispextern.h (move_it_by_lines):
4267 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4268 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4269 (message_log_check_duplicate): Remove parameters `prev_bol' and
4270 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4271 (redisplay_internal): Remove parameter `preserve_echo_area',
4272 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4274 * indent.c (Fvertical_motion):
4275 * window.c (window_scroll_pixel_based, Frecenter):
4276 Don't pass `need_y_p' to `move_it_by_lines'.
4278 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4280 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4281 steal a few bits to be more compact.
4282 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4283 Remove unneeded casts.
4285 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4287 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4289 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4290 binding" message (bug#7967).
4292 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4294 Fix more problems found by GCC 4.6.0's static checks.
4296 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4297 Remove unused local var.
4299 * editfns.c (Fmessage_box): Remove unused local var.
4301 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4302 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4303 Omit unused local vars.
4304 * window.c (shrink_windows): Omit unused local var.
4305 * menu.c (digest_single_submenu): Omit unused local var.
4306 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4307 Omit unused local var.
4309 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4310 Don't assume string length fits in int.
4311 (keyremap_step, read_key_sequence): Use size_t for sizes.
4312 (read_key_sequence): Don't check last_real_key_start redundantly.
4314 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4315 instead of alloca (Bug#8344).
4317 * eval.c (Fbacktrace): Don't assume nargs fits in int.
4318 (Fbacktrace_frame): Don't assume nframes fits in int.
4320 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4322 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4325 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4327 * cm.c (calccost): Turn while-do into do-while, for clarity.
4329 * keyboard.c (syms_of_keyboard): Use the same style as later
4330 in this function when indexing through an array. This also
4331 works around GCC bug 48267.
4333 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4335 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4337 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4338 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4340 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4341 This avoids undefined behavior on integer overflow, and is a bit
4342 more convenient anyway since it is compared to a size_t variable.
4344 Variadic C functions now count arguments with size_t, not int.
4345 This avoids an unnecessary limitation on 64-bit machines, which
4346 caused (substring ...) to crash on large vectors (Bug#8344).
4347 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4348 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
4349 All variadic functions and their callers changed accordingly.
4350 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4351 * data.c (arith_driver, float_arith_driver): Likewise.
4352 * editfns.c (general_insert_function): Likewise.
4353 * eval.c (struct backtrace.nargs, interactive_p)
4354 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4355 (funcall_lambda, mark_backtrace): Likewise.
4356 * fns.c (concat): Likewise.
4357 * frame.c (x_set_frame_parameters): Likewise.
4358 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4359 0 if not found, not -1. All callers changed.
4361 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4362 (stack_copy_size): Now size_t, not int.
4363 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4365 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4367 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4368 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4369 All callers changed.
4371 * lisp.h (multibyte_char_to_unibyte):
4372 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4373 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4374 * character.h (CHAR_TO_BYTE8):
4375 * cmds.c (internal_self_insert):
4376 * editfns.c (general_insert_function):
4377 * keymap.c (push_key_description):
4378 * search.c (Freplace_match):
4379 * xdisp.c (message_dolog, set_message_1): All callers changed.
4381 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4383 * keyboard.c (safe_run_hook_funcall): New function.
4384 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4385 don't set the hook to nil, but remove the offending function instead.
4386 (Qcommand_hook_internal): Remove, unused.
4387 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4388 Vcommand_hook_internal.
4390 * eval.c (enum run_hooks_condition): Remove.
4391 (funcall_nil, funcall_not): New functions.
4392 (run_hook_with_args): Call each function through a `funcall' argument.
4393 Remove `cond' argument, now redundant.
4394 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4395 (Frun_hook_with_args_until_failure): Adjust accordingly.
4396 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4398 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4400 * dispextern.h (string_buffer_position): Remove declaration.
4402 * print.c (strout): Remove parameter `multibyte', unused since
4403 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4405 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4406 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4407 All callers changed.
4409 * w32.c (_wsa_errlist): Use braces for struct initializers.
4411 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4412 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4413 All callers changed.
4414 (string_buffer_position): Likewise. Also, make static (it's never
4415 used outside xdisp.c).
4416 (cursor_row_p): Remove parameter `w', unused since
4417 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4418 (decode_mode_spec): Remove parameter `precision', introduced during
4419 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4420 All callers changed.
4422 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4424 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4426 2011-03-27 Anders Lindgren <andlind@gmail.com>
4428 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4429 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4430 (ns_update_auto_hide_menu_bar): New functions.
4431 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4432 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4433 ns_constrain_all_frames.
4434 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4435 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4437 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4439 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4441 2011-03-27 Glenn Morris <rgm@gnu.org>
4443 * syssignal.h: Replace RETSIGTYPE with void.
4444 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4445 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4446 Replace SIGTYPE with void everywhere.
4447 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4448 * s/template.h (SIGTYPE): Remove commented out definition.
4450 2011-03-26 Eli Zaretskii <eliz@gnu.org>
4452 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4453 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4455 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
4457 * w32.c (read_unc_volume): Use parameter `henum', instead of
4458 global variable `wget_enum_handle'.
4460 * keymap.c (describe_vector): Remove parameters `indices' and
4461 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4462 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4464 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4466 * keyboard.c (timer_check): Remove parameter `do_it_now',
4467 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4468 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4469 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4471 * keyboard.c (read_char):
4472 * w32menu.c (w32_menu_display_help):
4473 * xmenu.c (show_help_event, menu_help_callback):
4474 Adjust calls to `show_help_echo'.
4476 * gtkutil.c (xg_maybe_add_timer):
4477 * keyboard.c (readable_events):
4478 * process.c (wait_reading_process_output):
4479 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4481 * insdel.c (adjust_markers_gap_motion):
4482 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4483 (gap_left, gap_right): Don't call it.
4485 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
4487 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4488 incurred during fontification.
4490 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4492 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4493 (DEFVAR_PER_BUFFER): Don't pass it.
4495 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4496 (scrolling_window): Don't pass it.
4498 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4500 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4502 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4504 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4505 of variables specific to SELinux and computation of `encoded_absname'.
4507 * image.c (XPutPixel): Remove unused variable `height'.
4509 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4511 * unexw32.c (get_section_info): Remove unused variable `section'.
4513 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4514 (system_process_attributes): Remove unused variable `sess'.
4515 (sys_read): Remove unused variable `err'.
4517 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4518 (w32_wnd_proc): Remove unused variable `isdead'.
4519 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4520 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4521 (x_create_tip_frame): Remove unused variable `tem'.
4523 * w32inevt.c (w32_console_read_socket):
4524 Remove unused variable `no_events'.
4526 * w32term.c (x_draw_composite_glyph_string_foreground):
4527 Remove unused variable `width'.
4529 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
4531 * w32term.c (x_set_glyph_string_clipping):
4532 Don't pass uninitialized region to CombineRgn.
4534 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
4536 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4537 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4538 (Fx_close_connection): Remove unused variable `i'.
4540 * w32font.c (w32font_draw): Return number of glyphs.
4541 (w32font_open_internal): Remove unused variable `i'.
4542 (w32font_driver): Add missing initializer.
4544 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4545 (fill_in_menu): Remove unused variable `items_added'.
4547 * w32term.c (last_mouse_press_frame): Remove static global variable.
4548 (w32_clip_to_row): Remove unused variable `f'.
4549 (x_delete_terminal): Remove unused variable `i'.
4551 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4552 (NOTHING): Remove unused static global variable.
4553 (uniscribe_check_otf): Remove unused variable `table'.
4554 (uniscribe_font_driver): Add missing initializers.
4556 2011-03-23 Julien Danjou <julien@danjou.info>
4558 * term.c (Fsuspend_tty, Fresume_tty):
4559 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4560 * window.c (temp_output_buffer_show):
4561 * insdel.c (signal_before_change):
4562 * frame.c (Fhandle_switch_frame):
4563 * fileio.c (Fdo_auto_save):
4564 * emacs.c (Fkill_emacs):
4565 * editfns.c (save_excursion_restore):
4566 * cmds.c (internal_self_insert):
4567 * callint.c (Fcall_interactively):
4568 * buffer.c (Fkill_all_local_variables):
4569 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4571 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
4572 unconditionnaly since it does the check itself.
4574 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
4576 Fix more problems found by GCC 4.5.2's static checks.
4578 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4579 the first time through the loop, since we know p0 < p1 then.
4580 This also avoids a gcc -Wstrict-overflow warning.
4582 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4583 leading to a memory leak, possible in functions like
4584 load_charset_map_from_file that can allocate an unbounded number
4585 of objects (Bug#8318).
4587 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4588 that could (at least in theory) be that large.
4590 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4591 This is less likely to overflow, and avoids undefined behavior if
4592 overflow does occur. All callers changed. Use strtoul to scan
4593 for the unsigned long integer.
4594 (pint2hrstr): Simplify and tune code slightly.
4595 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
4597 * scroll.c (do_scrolling): Work around GCC bug 48228.
4598 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4600 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4601 This also avoids a warning with gcc -Wstrict-overflow.
4602 (validate_x_resource_name): Simplify count usage.
4603 This also avoids a warning with gcc -Wstrict-overflow.
4605 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4608 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
4610 * process.c (Fmake_network_process): Use socklen_t, not int,
4611 where POSIX says socklen_t is required in portable programs.
4612 This fixes a porting bug on hosts like 64-bit HP-UX, where
4613 socklen_t is wider than int (Bug#8277).
4614 (Fmake_network_process, server_accept_connection):
4615 (wait_reading_process_output, read_process_output):
4618 * process.c: Rename or move locals to avoid shadowing.
4619 (list_processes_1, Fmake_network_process):
4620 (read_process_output_error_handler, exec_sentinel_error_handler):
4621 Rename or move locals.
4622 (Fmake_network_process): Define label "retry_connect" only if needed.
4623 (Fnetwork_interface_info): Fix pointer signedness.
4624 (process_send_signal): Add cast to avoid pointer signedness problem.
4625 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
4626 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
4628 Make tparam.h and terminfo.c consistent.
4629 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4630 Include tparam.h instead, since it declares them.
4631 * cm.h (PC): Remove extern decl; tparam.h now does this.
4632 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4633 * terminfo.c: Include tparam.h, to check interfaces.
4634 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4635 (tparam): Adjust signature to match interface in tparam.h;
4636 this removes some undefined behavior. Check that outstring and len
4637 are zero, which they always are with Emacs.
4638 * tparam.h (PC, BC, UP): New extern decls.
4640 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
4641 (xftfont_open): Rename locals to avoid shadowing.
4643 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
4644 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4645 (OTF_TAG_SYM): Omit macro if not needed.
4646 (ftfont_list): Remove unused local.
4647 (get_adstyle_property, ftfont_pattern_entity):
4648 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4649 Rename locals to avoid shadowing.
4651 * xfont.c (xfont_list_family): Mark var as initialized.
4653 * xml.c (make_dom): Now static.
4655 * composite.c (composition_compute_stop_pos): Rename local to
4657 (composition_reseat_it): Remove unused locals.
4658 (find_automatic_composition, composition_adjust_point): Likewise.
4659 (composition_update_it): Mark var as initialized.
4660 (find_automatic_composition): Mark vars as initialized,
4661 with a FIXME (Bug#8290).
4663 character.h: Rename locals to avoid shadowing.
4664 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4665 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4666 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4667 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4670 * textprop.c (property_change_between_p): Remove; unused.
4672 * intervals.c (interval_start_pos): Now static.
4674 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4676 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4677 Rename locals to avoid shadowing.
4679 * sound.c (wav_play, au_play, Fplay_sound_internal):
4680 Fix pointer signedness.
4681 (alsa_choose_format): Remove unused local var.
4682 (wav_play): Initialize a variable to 0, to prevent undefined
4683 behavior (Bug#8278).
4685 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4687 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4689 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4690 clobbering (Bug#8298).
4691 * sysdep.c (sys_subshell): Likewise.
4692 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
4694 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4695 This should get cleaned up, so that child_setup has the
4696 same signature on all platforms.
4698 * callproc.c (call_process_cleanup): Now static.
4699 (relocate_fd): Rename locals to avoid shadowing.
4701 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
4703 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4704 not to be necessary, and produces flickering.
4706 2011-03-20 Glenn Morris <rgm@gnu.org>
4708 * config.in: Remove file.
4710 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
4712 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4713 are now in src/globals.h.
4714 (syms_of_minibuf): Remove spurious & from previous change.
4716 2011-03-20 Leo <sdl.web@gmail.com>
4718 * minibuf.c (completing-read-function): New variable.
4719 (completing-read-default): Rename from completing-read.
4720 (completing-read): Call completing-read-function.
4722 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4724 * xfaces.c (Fx_load_color_file):
4725 Read color file from absolute filename (bug#8250).
4727 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4729 * makefile.w32-in: Update dependencies.
4731 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4733 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4735 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4737 Fix more problems found by GCC 4.5.2's static checks.
4739 * process.c (make_serial_process_unwind, send_process_trap):
4740 (sigchld_handler): Now static.
4742 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4743 That way, the code declares only the vars that it needs.
4744 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4745 * s/cygwin.h (PTY_ITERATION): Likewise.
4746 * s/darwin.h (PTY_ITERATION): Likewise.
4747 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4749 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4750 * process.c (allocate_pty): Don't declare stb unless it's needed.
4752 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4753 (CONSTANTLIM): Remove; unused.
4754 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4755 Define only if needed.
4757 * unexelf.c (unexec): Name an expression,
4758 to avoid gcc -Wbad-function-cast warning.
4759 Use a different way to cause a compilation error if anyone uses
4760 n rather than nn, a way that does not involve shadowing.
4761 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4763 * deps.mk (unexalpha.o): Remove; unused.
4765 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4766 * unexec.h: New file.
4767 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4768 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4770 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4771 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4772 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4773 Change as necessary to match prototype in unexec.h.
4775 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4777 (back_comment, skip_chars): Mark vars as initialized.
4779 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4780 Rename locals to avoid shadowing.
4782 * lread.c (read1): Rewrite so as not to use empty "else".
4783 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4785 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4787 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4788 warning when compiling print.c.
4790 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4791 instead of using an uninitialized var.
4792 (font_sort_entities): Mark var as initialized.
4794 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4796 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4797 pointers to constants.
4798 (font_parse_fcname): Remove unused vars.
4799 (font_delete_unmatched): Now static.
4800 (font_get_spec): Remove; unused.
4801 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4802 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4803 Rename or move locals to avoid shadowing.
4805 * fns.c (require_nesting_list, require_unwind): Now static.
4806 (Ffillarray): Rename locals to avoid shadowing.
4808 * floatfns.c (domain_error2): Define only if needed.
4809 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4811 * alloc.c (mark_backtrace): Move decl from here ...
4812 * lisp.h: ... to here, so that it can be checked.
4814 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4815 (Fdefvar): Rewrite so as not to use empty "else".
4816 (lisp_indirect_variable): Name an expression,
4817 to avoid gcc -Wbad-function-cast warning.
4818 (Fdefvar): Rename locals to avoid shadowing.
4820 * callint.c (quotify_arg, quotify_args): Now static.
4821 (Fcall_interactively): Rename locals to avoid shadowing.
4822 Use const pointer when appropriate.
4824 * lisp.h (get_system_name, get_operating_system_release):
4825 Move decls here, to check interfaces.
4826 * process.c (get_operating_system_release): Move decl to lisp.h.
4827 * xrdb.c (get_system_name): Likewise.
4828 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4829 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4830 some of which prompt warnings from gcc -Wbad-function-cast.
4831 (Fformat_time_string, Fencode_time, Finsert_char):
4832 (Ftranslate_region_internal, Fformat):
4833 Rename or remove local vars to avoid shadowing.
4834 (Ftranslate_region_internal): Mark var as initialized.
4836 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4839 * lisp.h (eassert): Check that the argument compiles, even if
4840 ENABLE_CHECKING is not defined.
4842 * data.c (Findirect_variable): Name an expression, to avoid
4843 gcc -Wbad-function-cast warning.
4844 (default_value, arithcompare, arith_driver, arith_error): Now static.
4845 (store_symval_forwarding): Rename local to avoid shadowing.
4846 (Fmake_variable_buffer_local, Fmake_local_variable):
4847 Mark variables as initialized.
4848 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4850 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4851 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4852 Rename locals to avoid shadowing.
4853 (mark_stack): Move local variables into the #ifdef region where
4855 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4856 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4858 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4859 (GC_STRING_CHARS): Remove; not used.
4860 (Fmemory_limit): Cast sbrk's returned value to char *.
4862 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4863 avoids undefined behavior in theory.
4865 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4867 Use functions, not macros, for up- and down-casing (Bug#8254).
4868 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4869 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4870 to use the following functions instead of these macros.
4871 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4872 EMACS_INT, since callers assume the returned value fits in int.
4873 (upcase1): Likewise, for UPCASE_TABLE.
4874 (uppercasep, lowercasep, upcase): New static inline functions.
4875 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4876 the race-condition problem in the old DOWNCASE.
4878 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4879 Rename locals to avoid shadowing.
4880 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4881 (regex_compile, re_search_2, re_match_2_internal):
4882 Remove unused local vars.
4883 (FREE_VAR): Rewrite so as not to use empty "else",
4884 which gcc can warn about.
4885 (regex_compile, re_match_2_internal): Mark locals as initialized.
4886 (RETALLOC_IF): Define only if needed.
4887 (WORDCHAR_P): Likewise. This one is never needed, but is used
4888 only in a comment talking about a compiler bug, so put inside
4889 the #if 0 of that comment.
4890 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4891 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4894 * search.c (boyer_moore): Rename locals to avoid shadowing.
4895 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4896 (PREV_CHAR_BOUNDARY): Likewise.
4898 * search.c (simple_search): Remove unused var.
4900 * dired.c (compile_pattern): Move decl from here ...
4901 * lisp.h: ... to here, so that it can be checked.
4902 (struct re_registers): New forward decl.
4904 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4906 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4908 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4909 Rename locals to avoid shadowing.
4910 (Fvertical_motion): Mark locals as initialized.
4912 * casefiddle.c (casify_object, casify_region): Now static.
4913 (casify_region): Mark local as initialized.
4915 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4917 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4918 New macros, so that the caller can use some names other than
4919 gcpro1, gcpro2, etc.
4920 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4922 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4923 argument, for consistency with GCPRO2_VAR, etc: it is now the
4924 prefix of the variable, not the variable itself. All uses
4926 * dired.c (directory_files_internal, file_name_completion):
4927 Rename locals to avoid shadowing.
4929 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4930 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4931 dired.c's scmp function, had undefined behavior.
4932 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4933 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4934 * buffer.h: ... to here, because these macros use current_buffer,
4935 and the new implementation with inline functions needs to have
4936 current_buffer in scope now, rather than later when the macros
4938 (downcase, upcase1): New static inline functions.
4939 (DOWNCASE, UPCASE1): Reimplement using these functions.
4940 This avoids undefined behavior in expressions like
4941 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4942 from race conditions in accessing the global variables
4943 case_temp1 and case_temp2.
4944 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4945 * lisp.h (case_temp1, case_temp2): Remove their decls.
4946 * character.h (ASCII_CHAR_P): Move from here ...
4947 * lisp.h: ... to here, so that the inline functions mentioned
4950 * dired.c (directory_files_internal_unwind): Now static.
4952 * fileio.c (file_name_as_directory, directory_file_name):
4953 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4955 (file_name_as_directory): Use const pointers when appropriate.
4956 (Fexpand_file_name): Likewise. In particular, newdir might
4957 point at constant storage, so make it a const pointer.
4958 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4959 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4961 (Fset_file_times, Finsert_file_contents, auto_save_error):
4962 Rename locals to avoid shadowing.
4964 * minibuf.c (choose_minibuf_frame_1): Now static.
4965 (Ftry_completion, Fall_completions): Rename or remove locals
4968 * marker.c (bytepos_to_charpos): Remove; unused.
4970 * lisp.h (verify_bytepos, count_markers): New decls,
4971 so that gcc does not warn that these functions aren't declared.
4973 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4974 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4975 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4976 (copy_text): Remove unused local var.
4978 * filelock.c (within_one_second): Now static.
4979 (lock_file_1): Rename local to avoid shadowing.
4981 * buffer.c (fix_overlays_before): Mark locals as initialized.
4982 (fix_start_end_in_overlays): Likewise. This function should be
4983 simplified by using pointers-to-pointers, but that's a different
4985 (switch_to_buffer_1): Now static.
4986 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4987 (report_overlay_modification): Rename locals to avoid shadowing.
4989 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4990 Fix pointer signedness issue.
4991 (sys_subshell): Mark local as volatile if checking for lint,
4992 to suppress a gcc -Wclobbered warning that does not seem to be right.
4993 (MAXPATHLEN): Define only if needed.
4995 * process.c (serial_open, serial_configure): Move decls from here ...
4996 * systty.h: ... to here, so that they can be checked.
4998 * fns.c (get_random, seed_random): Move extern decls from here ...
4999 * lisp.h: ... to here, so that they can be checked.
5001 * sysdep.c (reset_io): Now static.
5002 (wait_for_termination_signal): Remove; unused.
5004 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5005 (copy_keymap_item, append_key, push_text_char_description):
5007 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5008 (DENSE_TABLE_SIZE): Remove; unused.
5009 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5010 (describe_map_tree):
5011 Rename locals to avoid shadowing.
5013 * keyboard.c: Declare functions static if they are not used elsewhere.
5014 (echo_char, echo_dash, cmd_error, top_level_2):
5015 (poll_for_input, handle_async_input): Now static.
5016 (read_char, kbd_buffer_get_event, make_lispy_position):
5017 (make_lispy_event, make_lispy_movement, apply_modifiers):
5018 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5019 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5020 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5021 (read_key_sequence, read_char): Mark locals as initialized.
5022 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5024 * keyboard.h (make_ctrl_char): New decl.
5025 (mark_kboards): Move decl here ...
5026 * alloc.c (mark_kboards): ... from here.
5028 * lisp.h (force_auto_save_soon): New decl.
5030 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5031 (DEFINE_DUMMY_FUNCTION): New macro.
5032 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5034 (main): Add casts to avoid warnings
5035 if GCC considers string literals to be constants.
5037 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5039 * dbusbind.c: Pointer signedness fixes.
5040 (xd_signature, xd_append_arg, xd_initialize):
5041 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5042 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5043 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5044 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5046 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5047 if GCC considers string literals to be constants.
5048 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5050 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5052 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5053 (print_preprocess, print_object): New macro to fix last change.
5055 * print.c (print_preprocess): Don't forget font objects.
5057 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5059 * emacs.c (USAGE3): Doc fixes.
5061 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5063 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5066 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5068 * lisp.h (VWindow_system, Qfile_name_history):
5069 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5070 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5071 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5073 * w32select.c: Don't #include "keyboard.h".
5074 (run_protected): Add extern declaration for waiting_for_input.
5076 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5077 * w32console.c (detect_input_pending, read_input_pending)
5078 (encode_terminal_code):
5079 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5080 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5081 (w32_system_caret_y, Qfile_name_history):
5082 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5083 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5084 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5085 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5086 * w32proc.c (Qlocal, report_file_error):
5087 * w32term.c (Vwindow_system, updating_frame):
5088 * w32uniscribe.c (initialized, uniscribe_font_driver):
5089 Remove unneeded extern declarations.
5091 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5093 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5095 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
5097 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5098 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5099 These macros can no longer be used for assignment.
5101 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5102 Assign struct members directly, instead of using BUF_BEGV etc.
5103 (record_buffer_markers, fetch_buffer_markers): New functions for
5104 recording and fetching special buffer markers.
5105 (set_buffer_internal_1, set_buffer_temp): Use them.
5107 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5109 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5111 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5112 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5114 * xdisp.c (hscroll_window_tree):
5115 (reconsider_clip_changes): Use PT instead of BUF_PT.
5117 2011-03-13 Eli Zaretskii <eliz@gnu.org>
5119 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5120 $(EMACS_ROOT)/lib/intprops.h.
5122 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5124 Fix more problems found by GCC 4.5.2's static checks.
5126 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5127 to unsigned char * to avoid compiler diagnostic.
5128 (xg_free_frame_widgets): Make it clear that a local variable is
5129 needed only if USE_GTK_TOOLTIP.
5130 (gdk_window_get_screen): Make it clear that this macro is needed
5131 only if USE_GTK_TOOLTIP.
5132 (int_gtk_range_get_value): New function, which avoids a diagnostic
5133 from gcc -Wbad-function-cast.
5134 (xg_set_toolkit_scroll_bar_thumb): Use it.
5135 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5136 diagnostic from gcc -Wbad-function-cast.
5137 (get_utf8_string, xg_get_file_with_chooser):
5138 Rename locals to avoid shadowing.
5139 (create_dialog): Move locals to avoid shadowing.
5141 * xgselect.c (xg_select): Remove unused var.
5143 * image.c (four_corners_best): Mark locals as initialized.
5144 (gif_load): Initialize transparent_p to zero (Bug#8238).
5145 Mark another local as initialized.
5146 (my_png_error, my_error_exit): Mark with NO_RETURN.
5148 * image.c (clear_image_cache): Now static.
5149 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5150 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5151 (x_edge_detection): Remove unnecessary cast that
5152 gcc -Wbad-function-cast diagnoses.
5153 (gif_load): Fix pointer signedness.
5154 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5155 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5157 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5159 Improve quality of tests for time stamp overflow.
5160 For example, without this patch (encode-time 0 0 0 1 1
5161 1152921504606846976) returns the obviously-bogus value (-948597
5162 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5163 reports time overflow. See
5164 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5165 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5166 * editfns.c: Include limits.h and intprops.h.
5167 (TIME_T_MIN, TIME_T_MAX): New macros.
5168 (time_overflow): Move earlier, to before first use.
5169 (hi_time, lo_time): New functions, for an accurate test for
5171 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5172 (Fget_internal_run_time): Don't assume time_t fits in int.
5173 (make_time): Use list2 instead of Fcons twice.
5174 (Fdecode_time): More accurate test for out-of-range times.
5175 (check_tm_member): New function.
5176 (Fencode_time): Use it, to test for out-of-range times.
5177 (lisp_time_argument): Don't rely on undefined left-shift and
5178 right-shift behavior when checking for time stamp overflow.
5180 * editfns.c (time_overflow): New function, refactoring common code.
5181 (Fformat_time_string, Fdecode_time, Fencode_time):
5182 (Fcurrent_time_string): Use it.
5184 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5185 * dired.c (make_time): Move to ...
5186 * editfns.c (make_time): ... here.
5187 * systime.h: Note the move.
5189 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5191 * fringe.c (update_window_fringes): Remove unused variables.
5193 * unexmacosx.c (copy_data_segment): Also copy __got section.
5196 2011-03-12 Eli Zaretskii <eliz@gnu.org>
5198 * termcap.c [MSDOS]: Include "msdos.h".
5199 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5200 Constify `char *' arguments and their references according to
5201 prototypes in tparam.h.
5203 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
5205 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5206 Adapt all references accordingly.
5208 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5210 2011-03-11 Tom Tromey <tromey@redhat.com>
5212 * buffer.c (syms_of_buffer): Remove obsolete comment.
5214 2011-03-11 Eli Zaretskii <eliz@gnu.org>
5216 * termhooks.h (encode_terminal_code): Declare prototype.
5218 * msdos.c (encode_terminal_code): Don't declare prototype.
5220 * term.c (encode_terminal_code): Now external again, used by
5221 w32console.c and msdos.c.
5223 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5224 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
5226 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
5228 Fix some minor problems found by GCC 4.5.2's static checks.
5230 * fringe.c (update_window_fringes): Mark locals as initialized
5232 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
5234 * alloc.c (mark_fringe_data): Move decl from here ...
5235 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5236 to check its interface.
5237 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5239 * fontset.c (free_realized_fontset): Now static.
5240 (Fset_fontset_font): Rename local to avoid shadowing.
5241 (fontset_font): Mark local as initialized.
5242 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
5244 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5246 * xselect.c (x_disown_buffer_selections): Remove; not used.
5247 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
5248 (x_own_selection, Fx_disown_selection_internal): Rename locals
5250 (x_handle_dnd_message): Remove local to avoid shadowing.
5252 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5253 so that the caller can use some name other than gcpro1.
5254 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
5255 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5256 (Fx_backspace_delete_keys_p):
5257 Use them to avoid shadowing, and rename vars to avoid shadowing.
5258 (x_decode_color, x_set_name, x_window): Now static.
5259 (Fx_create_frame): Add braces to silence GCC warning.
5260 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
5261 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5262 Remove unused locals.
5263 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5264 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5265 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5268 * xterm.h (x_mouse_leave): New decl.
5270 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5271 Remove unused functions.
5272 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5273 (x_calc_absolute_position): Now static.
5274 (XTread_socket): Don't define label "out" unless it's used.
5275 Don't declare local "event" unless it's used.
5276 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5277 unless they are used.
5278 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5279 (x_fatal_error_signal): Remove; not used.
5280 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5281 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5282 (x_error_catcher, x_connection_closed, x_error_handler):
5283 (x_error_quitter, xembed_send_message, x_iconify_frame):
5284 (my_log_handler): Rename locals to avoid shadowing.
5285 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
5286 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
5288 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5289 Rename or move locals to avoid shadowing.
5290 (tty_defined_color, merge_face_heights): Now static.
5291 (free_realized_faces_for_fontset): Remove; not used.
5292 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5293 does not deduce is never used uninitialized.
5294 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5295 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
5297 * terminal.c (store_terminal_param): Now static.
5299 * xmenu.c (menu_highlight_callback): Now static.
5300 (set_frame_menubar): Remove unused local.
5301 (xmenu_show): Rename parameter to avoid shadowing.
5302 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5303 since they might point to immutable storage.
5304 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5305 since it's unused otherwise.
5307 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
5308 Add a FIXME, since the code still doesn't look right. (Bug#8215)
5309 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5310 avoids a gcc -Wuninitialized diagnostic.
5311 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
5312 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5313 does not deduce are never used uninitialized.
5315 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5317 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
5318 * window.c (window_loop, size_window):
5319 (run_window_configuration_change_hook, enlarge_window): Likewise.
5321 * window.c (display_buffer): Now static.
5322 (size_window): Mark variables that gcc -Wuninitialized
5323 does not deduce are never used uninitialized.
5324 * window.h (check_all_windows): New decl, to forestall
5325 gcc -Wmissing-prototypes diagnostic.
5326 * dispextern.h (bidi_dump_cached_states): Likewise.
5328 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5330 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
5332 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5333 and to avoid gcc -Wuninitialized warning.
5334 (load_charset_map): Mark variables that gcc -Wuninitialized
5335 does not deduce are never used uninitialized.
5336 (load_charset): Abort instead of using uninitialized var (Bug#8229).
5338 * coding.c (coding_set_source, coding_set_destination):
5339 Use "else { /* comment */ }" rather than "else /* comment */;"
5340 for clarity, and to avoid gcc -Wempty-body warning.
5341 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5342 a block, when the outer 'i' will do.
5343 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5344 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5345 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5346 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5347 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5348 Rename locals to avoid shadowing.
5349 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
5350 * coding.c (emacs_mule_char, encode_invocation_designation):
5351 Now static, since they're not used elsewhere.
5352 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
5353 (decode_coding_object, encode_coding_object, detect_coding_system):
5354 (decode_coding_emacs_mule): Mark variables that gcc
5355 -Wuninitialized does not deduce are never used uninitialized.
5356 (detect_coding_iso_2022): Initialize a local variable that might
5357 be used uninitialized. Leave a FIXME because it's not clear that
5358 this initialization is needed. (Bug#8211)
5359 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5360 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5361 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5362 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5363 Remove unused macros.
5365 * category.c (hash_get_category_set): Remove unused local var.
5366 (copy_category_table): Now static, since it's not used elsewhere.
5367 * character.c (string_count_byte8): Likewise.
5369 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5370 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5372 * chartab.c (copy_sub_char_table): Now static, since it's not used
5374 (sub_char_table_ref_and_range, char_table_ref_and_range):
5375 Rename locals to avoid shadowing.
5376 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
5378 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
5379 (BIDI_BOB): Remove unused macro.
5381 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5382 deduce are never used uninitialized.
5383 * term.c (encode_terminal_code): Likewise.
5385 * term.c (encode_terminal_code): Now static. Remove unused local.
5387 * tparam.h: New file.
5388 * term.c, tparam.h: Include it.
5389 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5390 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5391 Move these decls to tparam.h, and make them agree with what
5392 is actually in tparam.c. The previous trick of using incompatible
5393 decls in different modules does not conform to the C standard.
5394 All callers of tparam changed to use tparam's actual API.
5395 * tparam.c (tparam1, tparam, tgoto):
5396 Use const pointers where appropriate.
5398 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5399 * cm.h (struct cm): Likewise.
5400 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5401 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5402 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5403 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5404 (turn_on_face, init_tty): Likewise.
5405 * termchar.h (struct tty_display_info): Likewise.
5407 * term.c (term_mouse_position): Rename local to avoid shadowing.
5409 * alloc.c (mark_ttys): Move decl from here ...
5410 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5412 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5414 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5416 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
5418 * search.c (compile_pattern_1): Remove argument regp, unused since
5419 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5420 (compile_pattern): Don't pass it.
5422 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5424 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5425 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5427 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5429 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5431 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5432 gdk_window_get_screen, gdk_window_get_geometry,
5433 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5434 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5435 (xg_get_pixbuf_from_pixmap): New function.
5436 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5437 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5438 Call xg_get_pixbuf_from_pixmap instead of
5439 gdk_pixbuf_get_from_drawable.
5440 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5441 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5442 (xg_check_special_colors): Use GtkStyleContext and its functions
5444 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5445 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5446 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5447 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5448 Call gtk_widget_get_preferred_size.
5449 (xg_frame_resized): gdk_window_get_geometry only takes 5
5451 (xg_win_to_widget, xg_event_is_for_menubar):
5452 Call gdk_x11_window_lookup_for_display.
5453 (xg_set_widget_bg): New function.
5454 (delete_cb): New function.
5455 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5456 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5457 (xg_set_background_color): Call xg_set_widget_bg.
5458 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5459 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5460 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5461 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5463 (update_frame_tool_bar): Call gtk_widget_hide.
5464 (xg_initialize): Use GDK_KEY_g.
5466 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5468 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5470 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5471 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5472 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5474 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
5476 * w32xfns.c (select_palette): Check success of RealizePalette against
5477 GDI_ERROR, not zero.
5479 See ChangeLog.11 for earlier changes.
5485 Copyright (C) 2011 Free Software Foundation, Inc.
5487 This file is part of GNU Emacs.
5489 GNU Emacs is free software: you can redistribute it and/or modify
5490 it under the terms of the GNU General Public License as published by
5491 the Free Software Foundation, either version 3 of the License, or
5492 (at your option) any later version.
5494 GNU Emacs is distributed in the hope that it will be useful,
5495 but WITHOUT ANY WARRANTY; without even the implied warranty of
5496 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5497 GNU General Public License for more details.
5499 You should have received a copy of the GNU General Public License
5500 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.