* ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
[bpt/emacs.git] / src / ChangeLog
1 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2
3 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4
5 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
6
7 * image.c (gif_load): Fix omitted cast error introduced by
8 2011-06-06 change.
9
10 2011-06-10 Martin Rudalics <rudalics@gmx.at>
11
12 * window.h (resize_proportionally, orig_total_lines)
13 (orig_top_line): Remove from window structure.
14 (set_window_height, set_window_width, change_window_heights)
15 (Fdelete_window): Remove prototypes.
16 (resize_frame_windows): Remove duplicate declaration.
17
18 2011-06-10 Eli Zaretskii <eliz@gnu.org>
19
20 * window.h (resize_frame_windows, resize_window_check)
21 (delete_deletable_window, resize_root_window)
22 (resize_frame_windows): Declare prototypes.
23
24 * window.c (resize_window_apply): Make definition be "static" to
25 match the prototype.
26
27 2011-06-10 Martin Rudalics <rudalics@gmx.at>
28
29 * window.c: Remove declarations of Qwindow_size_fixed,
30 window_min_size_1, window_min_size_2, window_min_size,
31 size_window, window_fixed_size_p, enlarge_window, delete_window.
32 Remove static from declaration of Qdelete_window, it's
33 temporarily needed by Fbury_buffer.
34 (replace_window): Don't assign orig_top_line and
35 orig_total_lines.
36 (Fdelete_window, delete_window): Remove. Window deletion is
37 handled by window.el.
38 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
39 Fdelete_window calls with calls to Qdelete_window.
40 (Fdelete_other_windows): Remove. Deleting other windows is
41 handled by window.el.
42 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
43 handled in window.el.
44 (window_min_size_2, window_min_size_1, window_min_size): Remove.
45 Window minimum sizes are handled in window.el.
46 (shrink_windows, size_window, set_window_height)
47 (set_window_width, change_window_heights, window_height)
48 (window_width, CURBEG, CURSIZE, enlarge_window)
49 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
50 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
51 handled in window.el.
52 (make_dummy_parent): Rename to make_parent_window and give it a
53 second argument horflag.
54 (make_window): Don't set resize_proportionally any more.
55 (Fsplit_window): Remove. Windows are split in window.el.
56 (save_restore_action, save_restore_orig_size)
57 (shrink_window_lowest_first, save_restore_orig_size): Remove.
58 Resize mini windows in window.el.
59 (grow_mini_window, shrink_mini_window): Implement by calling
60 Qresize_root_window_vertically, resize_window_check and
61 resize_window_apply.
62 (saved_window, Fset_window_configuration, save_window_save): Do
63 not handle orig_top_line, orig_total_lines, and
64 resize_proportionally.
65 (window_min_height, window_min_width): Move to window.el.
66 (keys_of_window): Move bindings for delete-other-windows,
67 split-window, delete-window and enlarge-window to window.el.
68
69 * buffer.c: Temporarily extern Qdelete_window.
70 (Fbury_buffer): Temporarily call Qdelete_window instead of
71 Fdelete_window (Fbury_buffer will move to window.el soon).
72
73 * frame.c (set_menu_bar_lines_1): Remove code handling
74 orig_top_line and orig_total_lines.
75
76 * dispnew.c (adjust_frame_glyphs_initially): Don't use
77 set_window_height but set heights directly.
78 (change_frame_size_1): Use resize_frame_windows.
79
80 * xdisp.c (init_xdisp): Don't use set_window_height but set
81 heights directly.
82
83 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
84 resize_frame_windows instead of change_window_heights and run
85 run_window_configuration_change_hook.
86
87 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
88 instead of change_window_heights and run
89 run_window_configuration_change_hook.
90
91 2011-06-09 Martin Rudalics <rudalics@gmx.at>
92
93 * window.c (replace_window): Rename second argument REPLACEMENT to
94 NEW. New third argument SETFLAG. Rewrite.
95 (delete_window, make_dummy_parent): Call replace_window with
96 third argument 1.
97 (window_list_1): Move down in code.
98 (run_window_configuration_change_hook): Move set_buffer part
99 before select_frame_norecord part in order to unwind correctly.
100 Rename count1 to count.
101 (recombine_windows, delete_deletable_window, resize_root_window)
102 (Fdelete_other_windows_internal)
103 (Frun_window_configuration_change_hook, make_parent_window)
104 (resize_window_check, resize_window_apply, Fresize_window_apply)
105 (resize_frame_windows, Fsplit_window_internal)
106 (Fdelete_window_internal, Fresize_mini_window_internal): New
107 functions.
108 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
109
110 2011-06-08 Martin Rudalics <rudalics@gmx.at>
111
112 * window.h (window): Add some new members to window structure -
113 normal_lines, normal_cols, new_total, new_normal, clone_number,
114 splits, nest, prev_buffers, next_buffers.
115 (WINDOW_TOTAL_SIZE): Move here from window.c.
116 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
117
118 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
119 Remove.
120 (make_dummy_parent): Set new members of windows structure.
121 (make_window): Move down in code. Handle new members of window
122 structure.
123 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
124 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
125 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
126 (Fset_window_prev_buffers, Fwindow_next_buffers)
127 (Fset_window_next_buffers, Fset_window_clone_number): New
128 functions.
129 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
130 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
131 Doc-string fixes.
132 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
133 Argument WINDOW can be now internal window too.
134 (Fwindow_use_time): Move up in code.
135 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
136 Rewrite doc-string.
137 (Fset_window_configuration, saved_window)
138 (Fcurrent_window_configuration, save_window_save): Handle new
139 members of window structure.
140 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
141 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
142 (syms_of_window): New Lisp objects Qrecord_window_buffer,
143 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
144 Qget_mru_window, Qresize_root_window,
145 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
146 Qauto_buffer_name; staticpro them.
147
148 2011-06-07 Martin Rudalics <rudalics@gmx.at>
149
150 * window.c (Fwindow_total_size, Fwindow_left_column)
151 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
152 (Fwindow_list_1): New functions.
153 (window_box_text_cols): Replace with window_body_cols.
154 (Fwindow_width, Fscroll_left, Fscroll_right): Use
155 window_body_cols instead of window_box_text_cols.
156 (delete_window, Fset_window_configuration): Call
157 delete_all_subwindows with window as argument.
158 (delete_all_subwindows): Take a window as argument and not a
159 structure. Rewrite.
160 (window_loop): Remove handling of GET_LRU_WINDOW and
161 GET_LARGEST_WINDOW.
162 (Fget_lru_window, Fget_largest_window): Move to window.el.
163
164 * window.h: Extern window_body_cols instead of
165 window_box_text_cols. delete_all_subwindows now takes a
166 Lisp_Object as argument.
167
168 * indent.c (compute_motion, Fcompute_motion): Use
169 window_body_cols instead of window_box_text_cols.
170
171 * frame.c (delete_frame): Call delete_all_subwindows with root
172 window as argument.
173
174 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
175
176 * fns.c (Fputhash): Document return value.
177
178 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
179
180 * image.c (gif_load): Implement gif89a spec "no disposal" method.
181
182 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
183
184 Cons<->int and similar integer overflow fixes (Bug#8794).
185
186 Check for overflow when converting integer to cons and back.
187 * charset.c (Fdefine_charset_internal, Fdecode_char):
188 Use cons_to_unsigned to catch overflow.
189 (Fencode_char): Use INTEGER_TO_CONS.
190 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
191 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
192 * data.c (long_to_cons, cons_to_long): Remove.
193 (cons_to_unsigned, cons_to_signed): New functions.
194 These signal an error for invalid or out-of-range values.
195 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
196 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
197 * font.c (Ffont_variation_glyphs):
198 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
199 * lisp.h: Include <intprops.h>.
200 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
201 (cons_to_signed, cons_to_unsigned): New decls.
202 (long_to_cons, cons_to_long): Remove decls.
203 * undo.c (record_first_change): Use INTEGER_TO_CONS.
204 (Fprimitive_undo): Use CONS_TO_INTEGER.
205 * xfns.c (Fx_window_property): Likewise.
206 * xselect.c: Include <limits.h>.
207 (x_own_selection, selection_data_to_lisp_data):
208 Use INTEGER_TO_CONS.
209 (x_handle_selection_request, x_handle_selection_clear)
210 (x_get_foreign_selection, Fx_disown_selection_internal)
211 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
212 (lisp_data_to_selection_data): Use cons_to_unsigned.
213 (x_fill_property_data): Use cons_to_signed.
214 Report values out of range.
215
216 Check for buffer and string overflow more precisely.
217 * buffer.h (BUF_BYTES_MAX): New macro.
218 * lisp.h (STRING_BYTES_MAX): New macro.
219 * alloc.c (Fmake_string):
220 * character.c (string_escape_byte8):
221 * coding.c (coding_alloc_by_realloc):
222 * doprnt.c (doprnt):
223 * editfns.c (Fformat):
224 * eval.c (verror):
225 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
226 since they may not be the same number.
227 * editfns.c (Finsert_char):
228 * fileio.c (Finsert_file_contents):
229 Likewise for BUF_BYTES_MAX.
230
231 * image.c: Use ptrdiff_t, not int, for sizes.
232 (slurp_file): Switch from int to ptrdiff_t.
233 All uses changed.
234 (slurp_file): Check that file size fits in both size_t (for
235 malloc) and ptrdiff_t (for sanity and safety).
236
237 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
238 if b->modtime has its maximal value.
239
240 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
241
242 Don't assume time_t can fit into int.
243 * buffer.h (struct buffer.modtime): Now time_t, not int.
244 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
245 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
246
247 Minor fixes for signed vs unsigned integers.
248 * character.h (MAYBE_UNIFY_CHAR):
249 * charset.c (maybe_unify_char):
250 * keyboard.c (read_char, reorder_modifiers):
251 XINT -> XFASTINT, since the integer must be nonnegative.
252 * ftfont.c (ftfont_spec_pattern):
253 * keymap.c (access_keymap, silly_event_symbol_error):
254 XUINT -> XFASTINT, since the integer must be nonnegative.
255 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
256 since it makes no difference and we prefer signed.
257 * keyboard.c (record_char): Use XUINT when all the neighbors do.
258 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
259 nonnegative.
260
261 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
262
263 * window.h (Fwindow_frame): Declare.
264
265 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
266
267 * alloc.c: Simplify handling of large-request failures (Bug#8800).
268 (SPARE_MEMORY): Always define.
269 (LARGE_REQUEST): Remove.
270 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
271
272 2011-06-06 Martin Rudalics <rudalics@gmx.at>
273
274 * lisp.h: Move EXFUNS for Fframe_root_window,
275 Fframe_first_window and Fset_frame_selected_window to window.h.
276
277 * window.h: Move EXFUNS for Fframe_root_window,
278 Fframe_first_window and Fset_frame_selected_window here from
279 lisp.h.
280
281 * frame.c (Fwindow_frame, Fframe_first_window)
282 (Fframe_root_window, Fframe_selected_window)
283 (Fset_frame_selected_window): Move to window.c.
284 (Factive_minibuffer_window): Move to minibuf.c.
285 (Fother_visible_frames_p): New function.
286
287 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
288
289 * window.c (decode_window, decode_any_window): Move up in code.
290 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
291 (inhibit_frame_unsplittable): Remove unused variable.
292 (Fwindow_buffer): Move up and rewrite doc-string.
293 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
294 (Fwindow_prev): New functions.
295 (Fwindow_frame): Move here from frame.c. Accept any window as
296 argument.
297 (Fframe_root_window, Fframe_first_window)
298 (Fframe_selected_window): Move here from frame.c. Accept frame
299 or arbitrary window as argument. Update doc-strings.
300 (Fminibuffer_window): Move up in code.
301 (Fwindow_minibuffer_p): Move up in code and simplify.
302 (Fset_frame_selected_window): Move here from frame.c.
303 Marginal rewrite.
304 (Fselected_window, select_window, Fselect_window): Move up in
305 code. Minor doc-string fixes.
306
307 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
308
309 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
310 Do not assume that spare memory exists; that assumption is valid
311 only if SYSTEM_MALLOC.
312 (LARGE_REQUEST): New macro, so that the issue of large requests
313 is separated from the issue of spare memory.
314
315 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
316
317 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
318 format. (Bug#8806)
319
320 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
321
322 * xfns.c (x_set_scroll_bar_default_width): Move declarations
323 before statements.
324
325 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
326
327 * gtkutil.c (xg_get_default_scrollbar_width): New function.
328
329 * gtkutil.h: Declare xg_get_default_scrollbar_width.
330
331 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
332 min width by calling x_set_scroll_bar_default_width (Bug#8505).
333
334 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
335
336 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
337
338 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
339
340 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
341 (x_clipboard_manager_save): Add return value.
342 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
343 New error handlers.
344 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
345 Obey Vx_select_enable_clipboard_manager. Catch errors in
346 x_clipboard_manager_save (Bug#8779).
347 (Vx_select_enable_clipboard_manager): New variable.
348 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
349
350 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
351
352 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
353
354 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
355
356 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
357 in the current matrix if keep_current_p is non-zero.
358
359 2011-06-04 Eli Zaretskii <eliz@gnu.org>
360
361 * bidi.c (bidi_level_of_next_char): Fix last change.
362
363 2011-06-03 Eli Zaretskii <eliz@gnu.org>
364
365 Support bidi reordering of text covered by display properties.
366
367 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
368 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
369 (bidi_cache_search, bidi_cache_iterator_state)
370 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
371 (bidi_level_of_next_char, bidi_move_to_visually_next):
372 Support character positions inside a run of characters covered by a
373 display string.
374 (bidi_paragraph_init, bidi_resolve_explicit_1)
375 (bidi_level_of_next_char): Call bidi_fetch_char and
376 bidi_fetch_char_advance instead of FETCH_CHAR and
377 FETCH_CHAR_ADVANCE.
378 (bidi_init_it): Initialize new members.
379 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
380 definitions.
381 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
382 instead of using explicit *_CHAR codes.
383 (bidi_resolve_explicit, bidi_resolve_weak):
384 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
385 bidirectional text is supported only in multibyte buffers.
386 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
387 it to initialize the frame_window_p member of struct bidi_it.
388 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
389 (bidi_resolve_explicit, bidi_resolve_weak)
390 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
391 bidi_it->nchars is non-positive.
392 (bidi_level_of_next_char): Don't try to lookup the cache for the
393 next/previous character if nothing is cached there yet, or if we
394 were just reseat()'ed to a new position.
395
396 * xdisp.c (set_cursor_from_row): Set start and stop points
397 according to the row's direction when priming the loop that looks
398 for the glyph on which to display cursor.
399 (single_display_spec_intangible_p): Function deleted.
400 (display_prop_intangible_p): Reimplement to call
401 handle_display_spec instead of single_display_spec_intangible_p.
402 Accept 3 additional arguments needed by handle_display_spec.
403 This fixes incorrect cursor motion across display property with complex
404 values: lists, `(when COND...)' forms, etc.
405 (single_display_spec_string_p): Support property values that are
406 lists with the argument STRING its top-level element.
407 (display_prop_string_p): Fix the condition for processing a
408 property that is a list to be consistent with handle_display_spec.
409 (handle_display_spec): New function, refactored from the
410 last portion of handle_display_prop.
411 (compute_display_string_pos): Accept additional argument
412 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
413 value of a `display' property is a "replacing spec".
414 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
415 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
416 the display property, but just return a value indicating whether
417 the display property will replace the characters it covers.
418 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
419 frame_window_p members of struct bidi_it.
420 (compute_display_string_pos, compute_display_string_end):
421 New functions.
422 (push_it): Accept second argument POSITION, where pop_it should
423 jump to continue iteration.
424 (reseat_1): Initialize bidi_it.disp_pos.
425
426 * keyboard.c (adjust_point_for_property): Adjust the call to
427 display_prop_intangible_p to its new signature.
428
429 * dispextern.h (struct bidi_it): New member frame_window_p.
430 (bidi_init_it): Update prototypes.
431 (display_prop_intangible_p): Update prototype.
432 (compute_display_string_pos, compute_display_string_end):
433 Declare prototypes.
434 (struct bidi_it): New members nchars and disp_pos. ch_len is now
435 EMACS_INT.
436
437 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
438
439 Malloc failure behavior now depends on size of allocation.
440 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
441 * lisp.h: Change signatures accordingly.
442 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
443 All callers changed. (Bug#8762)
444
445 * gnutls.c: Use Emacs's memory allocators.
446 Without this change, the gnutls library would invoke malloc etc.
447 directly, which causes problems on non-SYNC_INPUT hosts, and which
448 runs afoul of improving memory_full behavior. (Bug#8761)
449 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
450 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
451 xfree instead of the default malloc, realloc, free.
452 (Fgnutls_boot): No need to check for memory allocation failure,
453 since xmalloc does that for us.
454
455 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
456 * category.c (hash_get_category_set):
457 * ccl.c (ccl_driver):
458 * charset.c (Fdefine_charset_internal):
459 * charset.h (struct charset.hash_index):
460 * composite.c (get_composition_id, gstring_lookup_cache)
461 (composition_gstring_put_cache):
462 * composite.h (struct composition.hash_index):
463 * dispextern.h (struct image.hash):
464 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
465 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
466 (hashfn_equal, hashfn_user_defined, make_hash_table)
467 (maybe_resize_hash_table, hash_lookup, hash_put)
468 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
469 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
470 (Fsxhash, Fgethash, Fputhash, Fmaphash):
471 * image.c (make_image, search_image_cache, lookup_image)
472 (xpm_put_color_table_h):
473 * lisp.h (struct Lisp_Hash_Table):
474 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
475 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
476 for hashes and hash indexes, instead of 'unsigned' and 'int'.
477 * alloc.c (allocate_vectorlike):
478 Check for overflow in vector size calculations.
479 * ccl.c (ccl_driver):
480 Check for overflow when converting EMACS_INT to int.
481 * fns.c, image.c: Remove unnecessary static decls that would otherwise
482 need to be updated by these changes.
483 * fns.c (make_hash_table, maybe_resize_hash_table):
484 Check for integer overflow with large hash tables.
485 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
486 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
487 (SXHASH_REDUCE): New macro.
488 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
489 Use it instead of discarding useful hash info with large hash values.
490 (sxhash_float): New function.
491 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
492 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
493 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
494 Rewrite to use FIXNUM_BITS, as this simplifies things.
495 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
496 Adjust signatures to match updated version of code.
497 (consing_since_gc): Now EMACS_INT, since a single hash table can
498 use more than INT_MAX bytes.
499
500 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
501
502 Make it possible to build with GCC-4.6+ -O2 -flto.
503
504 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
505
506 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
507
508 * minibuf.c (get_minibuffer, read_minibuf_unwind):
509 Call minibuffer-inactive-mode.
510
511 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
512
513 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
514 Update dependencies.
515
516 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
517
518 * data.c (init_data): Remove code for UTS, this system is not
519 supported anymore.
520
521 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
522
523 Don't force ./temacs to start in terminal mode.
524
525 * frame.c (make_initial_frame): Initialize faces in all cases, not
526 only when CANNOT_DUMP is defined.
527 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
528
529 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
530
531 * dispnew.c (add_window_display_history): Use const for the string
532 pointer. Remove declaration, not needed.
533
534 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
535
536 Use 'inline', not 'INLINE'.
537 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
538 * alloc.c, fontset.c (INLINE): Remove.
539 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
540 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
541 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
542 * gmalloc.c (register_heapinfo): Use inline unconditionally.
543 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
544
545 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
546
547 Make it possible to run ./temacs.
548
549 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
550 syms_of_callproc does the same thing. Remove test for
551 "initialized", do it in the caller.
552 * emacs.c (main): Avoid calling set_initial_environment when dumping.
553
554 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
555
556 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
557 (read_minibuf): Use get_minibuffer.
558 (syms_of_minibuf): Use DEFSYM.
559 (Qmetadata): New var.
560 * data.c (Qbuffer): Don't make it static.
561 (syms_of_data): Use DEFSYM.
562
563 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
564
565 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
566 (CCL_CODE_MIN): New macro.
567
568 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
569
570 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
571
572 * eval.c (Qdebug): Now static.
573 * lisp.h (Qdebug): Remove decl. This reverts a part of the
574 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
575 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
576
577 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
578
579 * image.c: Various fixes to ImageMagick code comments.
580 (Fimagemagick_types): Doc fix.
581
582 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
583
584 Minor fixes prompted by GCC 4.6.0 warnings.
585
586 * xselect.c (converted_selections, conversion_fail_tag): Now static.
587
588 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
589 (x_clipboard_manager_save_all): Move extern decl to ...
590 * xterm.h: ... here, so that it can be checked for consistency.
591
592 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
593
594 * xselect.c (x_clipboard_manager_save_frame)
595 (x_clipboard_manager_save_all): New functions.
596 (Fx_clipboard_manager_save): Lisp function deleted.
597
598 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
599 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
600
601 * xterm.h: Update prototype.
602
603 2011-05-28 William Xu <william.xwl@gmail.com>
604
605 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
606 exiting (Bug#8239).
607
608 2011-05-28 Jim Meyering <meyering@redhat.com>
609
610 Avoid a sign-extension bug in crypto_hash_function.
611 * fns.c (to_uchar): Define.
612 (crypto_hash_function): Use it to convert some newly-signed
613 variables to unsigned, to avoid sign-extension bugs. For example,
614 without this change, (md5 "truc") would evaluate to
615 45723a2aff78ff4fff7fff1114760e62 rather than the expected
616 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
617 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
618
619 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
620
621 Integer overflow fixes.
622
623 * dbusbind.c: Serial number integer overflow fixes.
624 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
625 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
626 to hold a serial number that is too large for a fixnum.
627 (Fdbus_method_return_internal, Fdbus_method_error_internal):
628 Check for serial numbers out of range. Decode any serial number
629 that was so large that it became a float. (Bug#8722)
630
631 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
632 (Fdbus_call_method, Fdbus_call_method_asynchronously):
633 Use XFASTINT rather than XUINT when numbers are nonnegative.
634 (xd_append_arg, Fdbus_method_return_internal):
635 (Fdbus_method_error_internal): Likewise. Also, for unsigned
636 arguments, check that Lisp number is nonnegative, rather than
637 silently wrapping negative numbers around. (Bug#8722)
638 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
639 (Bug#8722)
640
641 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
642
643 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
644
645 ccl: add integer overflow checks
646 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
647 (IN_INT_RANGE): New macros.
648 (ccl_driver): Use them to check for integer overflow when
649 decoding a CCL program. Many of the new checks are whether XINT (x)
650 fits in int; it doesn't always, on 64-bit hosts. The new version
651 doesn't catch all possible integer overflows, but it's an
652 improvement. (Bug#8719)
653
654 * alloc.c (make_event_array): Use XINT, not XUINT.
655 There's no need for unsigned here.
656
657 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
658 This follows up to the 2011-05-06 change that substituted uintptr_t
659 for EMACS_INT. This case wasn't caught back then.
660
661 Rework Fformat to avoid integer overflow issues.
662 * editfns.c: Include <float.h> unconditionally, as it's everywhere
663 now (part of C89). Include <verify.h>.
664 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
665 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
666 (Fformat): Avoid the prepass trying to compute sizes; it was only
667 approximate and thus did not catch overflow reliably. Instead, walk
668 through the format just once, formatting and computing sizes as we go,
669 checking for integer overflow at every step, and allocating a larger
670 buffer as needed. Keep track separately whether the format is
671 multibyte. Keep only the most-recently calculated precision, rather
672 than them all. Record whether each argument has been converted to
673 string. Use EMACS_INT, not int, for byte and char and arg counts.
674 Support field widths and precisions larger than INT_MAX. Avoid
675 sprintf's undefined behavior with conversion specifications such as %#d
676 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
677 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
678 formatting out-of-range floating point numbers with int
679 formats. (Bug#8668)
680
681 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
682
683 * data.c: Avoid integer truncation in expressions involving floats.
684 * data.c: Include <intprops.h>.
685 (arith_driver): When there's an integer overflow in an expression
686 involving floating point, convert the integers to floating point
687 so that the resulting value does not suffer from catastrophic
688 integer truncation. For example, on a 64-bit host (* 4
689 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
690 Do not rely on undefined behavior after integer overflow.
691
692 merge count_size_as_multibyte, parse_str_to_multibyte
693 * character.c, character.h (count_size_as_multibyte):
694 Rename from parse_str_to_multibyte; all uses changed.
695 Check for integer overflow.
696 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
697 since it's now a duplicate of the other. This is more of
698 a character than a buffer op, so better that it's in character.c.
699 * fns.c, print.c: Adjust to above changes.
700
701 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
702
703 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
704
705 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
706
707 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
708 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
709 (x_clipboard_manager_save): Now static.
710 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
711
712 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
713 (crypto_hash_function): Now static.
714 Fix pointer signedness problems. Avoid unnecessary initializations.
715
716 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
717
718 * termhooks.h (Vselection_alist): Make it terminal-local.
719
720 * terminal.c (create_terminal): Initialize it.
721
722 * xselect.c: Support for clipboard managers.
723 (Vselection_alist): Move to termhooks.h as terminal-local var.
724 (LOCAL_SELECTION): New macro.
725 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
726 (symbol_to_x_atom): Remove gratuitous arg.
727 (x_handle_selection_request, lisp_data_to_selection_data)
728 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
729 (x_own_selection, x_get_local_selection, x_convert_selection):
730 New arg, specifying work frame. Use terminal-local Vselection_alist.
731 (some_frame_on_display): Delete unused function.
732 (Fx_own_selection_internal, Fx_get_selection_internal)
733 (Fx_disown_selection_internal, Fx_selection_owner_p)
734 (Fx_selection_exists_p): New optional frame arg.
735 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
736 (x_handle_selection_clear): Don't treat other terminals with the
737 same keyboard specially. Use the terminal-local Vselection_alist.
738 (x_clear_frame_selections): Use Frun_hook_with_args.
739
740 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
741
742 * xterm.h: Add support for those atoms.
743
744 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
745
746 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
747 (converted_selections, conversion_fail_tag): New global variables.
748 (x_selection_request_lisp_error): Free the above.
749 (x_get_local_selection): Remove unnecessary code.
750 (x_reply_selection_request): Args changed; handle arbitrary array
751 of converted selections stored in converted_selections.
752 Separate the XChangeProperty and SelectionNotify steps.
753 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
754 (x_convert_selection): New function.
755 (x_handle_selection_event): Simplify.
756 (x_get_foreign_selection): Don't ignore incoming requests while
757 waiting for an answer; this will fail when we implement
758 SAVE_TARGETS, and seems unnecessary anyway.
759 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
760 (Vx_sent_selection_functions): Doc fix.
761
762 2011-05-26 Leo Liu <sdl.web@gmail.com>
763
764 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
765
766 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
767
768 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
769
770 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
771 for fringe update if it has periodic bitmap.
772 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
773 and fringe_bitmap_periodic_p.
774
775 * fringe.c (get_fringe_bitmap_data): New function.
776 (draw_fringe_bitmap_1, update_window_fringes): Use it.
777 (update_window_fringes): Record periodicity of fringe bitmap in glyph
778 row. Mark glyph row for fringe update if periodicity changed.
779
780 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
781 for fringe update unless it has periodic bitmap.
782
783 2011-05-25 Kenichi Handa <handa@m17n.org>
784
785 * xdisp.c (get_next_display_element): Set correct it->face_id for
786 a static composition.
787
788 2011-05-24 Leo Liu <sdl.web@gmail.com>
789
790 * deps.mk (fns.o):
791 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
792
793 * fns.c (crypto_hash_function, Fsha1): New function.
794 (Fmd5): Use crypto_hash_function.
795 (syms_of_fns): Add Ssha1.
796
797 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
798
799 * gnutls.c: Remove unused macros.
800 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
801 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
802 Remove macros that are defined and never used.
803 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
804
805 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
806
807 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
808 (Fx_get_selection_internal): Minor cleanup.
809 (Fx_own_selection_internal): Rename arguments for consistency with
810 select.el.
811
812 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
813
814 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
815
816 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
817
818 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
819
820 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
821
822 * dispnew.c (scrolling_window): Don't exclude the case that the
823 last enabled row in the desired matrix touches the bottom boundary.
824
825 2011-05-21 Glenn Morris <rgm@gnu.org>
826
827 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
828 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
829 and add some more files.
830
831 2011-05-20 Eli Zaretskii <eliz@gnu.org>
832
833 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
834 report_file_error introduced by the change from 2011-05-07.
835
836 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
837
838 * systime.h (Time): Define only if emacs is defined.
839 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
840 where the include path doesn't have X11/X.h by default. See
841 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
842
843 2011-05-20 Kenichi Handa <handa@m17n.org>
844
845 * composite.c (find_automatic_composition): Fix previous change.
846
847 2011-05-20 Glenn Morris <rgm@gnu.org>
848
849 * lisp.mk: New file, split from Makefile.in.
850 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
851 (shortlisp): Remove.
852 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
853
854 2011-05-19 Glenn Morris <rgm@gnu.org>
855
856 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
857 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
858 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
859 (lisp): Set the order to that of loadup.el.
860 (shortlisp): Make it a copy of $lisp.
861 (SOME_MACHINE_LISP): Remove.
862 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
863 Use just $shortlisp, not $SOME_MACHINE_LISP too.
864
865 2011-05-18 Kenichi Handa <handa@m17n.org>
866
867 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
868 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
869 (find_automatic_composition): Mostly rewrite for efficiency.
870
871 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
872
873 * makefile.w32-in: Update dependencies.
874
875 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
876
877 * menu.c: Include limits.h (fixes the MS-Windows build broken by
878 revision 104625).
879
880 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
881
882 Fix some integer overflow issues, such as string length overflow.
883
884 * insdel.c (count_size_as_multibyte): Check for string overflow.
885
886 * character.c (lisp_string_width): Check for string overflow.
887 Use EMACS_INT, not int, for string indexes and lengths; in
888 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
889 the resulting string length overflows an EMACS_INT; instead,
890 report a string overflow if no precision given. When checking for
891 precision exhaustion, use a check that cannot possibly have
892 integer overflow. (Bug#8675)
893 * character.h (lisp_string_width): Adjust to new signature.
894
895 * alloc.c (string_overflow): New function.
896 (Fmake_string): Use it. This doesn't change behavior, but saves
897 a few bytes and will simplify future changes.
898 * character.c (string_escape_byte8): Likewise.
899 * lisp.h (string_overflow): New decl.
900
901 Fixups, following up to the user-interface timestamp change.
902 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
903 for UI timestamps, instead of unsigned long.
904 * msdos.c (mouse_get_pos): Likewise.
905 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
906 * w32gui.h (Time): Define by including "systime.h" rather than by
907 declaring it ourselves. (Bug#8664)
908
909 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
910 * image.c (clear_image_cache): Likewise.
911
912 * term.c (term_mouse_position): Don't assume time_t wraparound.
913
914 Be more systematic about user-interface timestamps.
915 Before, the code sometimes used 'Time', sometimes 'unsigned long',
916 and sometimes 'EMACS_UINT', to represent these timestamps.
917 This change causes it to use 'Time' uniformly, as that's what X uses.
918 This makes the code easier to follow, and makes it easier to catch
919 integer overflow bugs such as Bug#8664.
920 * frame.c (Fmouse_position, Fmouse_pixel_position):
921 Use Time, not unsigned long, for user-interface timestamps.
922 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
923 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
924 * keyboard.h (last_event_timestamp): Likewise.
925 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
926 * menu.h (xmenu_show): Likewise.
927 * term.c (term_mouse_position): Likewise.
928 * termhooks.h (struct input_event.timestamp): Likewise.
929 (struct terminal.mouse_position_hook): Likewise.
930 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
931 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
932 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
933 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
934 what it was before.
935 * menu.h, termhooks.h: Include "systime.h", for Time.
936
937 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
938 Don't assume that the difference between two unsigned long values
939 can fit into an integer. At this point, we know button_down_time
940 <= event->timestamp, so the difference must be nonnegative, so
941 there's no need to cast the result if double-click-time is
942 nonnegative, as it should be; check that it's nonnegative, just in
943 case. This bug is triggered when events are more than 2**31 ms
944 apart (about 25 days). (Bug#8664)
945
946 * xselect.c (last_event_timestamp): Remove duplicate decl.
947 (x_own_selection): Remove needless cast to unsigned long.
948
949 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
950 that always fit in int. Use a sentinel instead of a counter, to
951 avoid a temp and to allay GCC's concerns about possible int overflow.
952 * frame.h (struct frame): Use int for menu_bar_items_used
953 instead of EMACS_INT, since it always fits in int.
954
955 * menu.c (grow_menu_items): Check for int overflow.
956
957 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
958
959 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
960 Before, the code was not consistent. These values cannot exceed
961 2**31 - 1 so there's no need to make them unsigned.
962 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
963 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
964 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
965 as modifiers.
966 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
967
968 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
969 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
970 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
971 presumably because the widths might not match.
972
973 * window.c (size_window): Avoid needless test at loop start.
974
975 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
976
977 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
978
979 2011-05-12 Drew Adams <drew.adams@oracle.com>
980
981 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
982
983 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
984
985 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
986 `width' to `bar_area_x' and `bar_area_width', respectively.
987 (x_scroll_run): Take account of fringe background extension.
988
989 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
990 Rename local vars `left' and `width' to `bar_area_x' and
991 `bar_area_width', respectively.
992 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
993 background extension.
994
995 2011-05-10 Jim Meyering <meyering@redhat.com>
996
997 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
998
999 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1000
1001 * image.c (Finit_image_library): Return t for built-in image types,
1002 like pbm and xbm. (Bug#8640)
1003
1004 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1005
1006 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1007
1008 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1009
1010 * w32console.c (Fset_screen_color): Doc fix.
1011 (Fget_screen_color): New function.
1012 (syms_of_ntterm): Defsubr it.
1013
1014 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1015 unlink the temporary file if Fcall_process didn't create it in the
1016 first place.
1017 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1018 child process will be redirected to a file specified with `:file'.
1019 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1020 cue to call_process_cleanup not to close that handle.
1021
1022 2011-05-07 Ben Key <bkey76@gmail.com>
1023
1024 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1025 one of two shell specific rules, either bootstrap-temacs-CMD or
1026 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1027 to the previous implementation of the bootstrap-temacs rule.
1028 The bootstrap-temacs-CMD rule is similar to the previous
1029 implementation of the bootstrap-temacs rule except that it
1030 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1031 variable.
1032
1033 These changes, along with some changes to nt/configure.bat,
1034 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1035 earlier fix to add support for --cflags and --ldflags options
1036 that include quotes so that it works whether make uses cmd or
1037 sh as the shell.
1038
1039 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1040
1041 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1042 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1043 is a constant.
1044 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1045 a string. Handle both cases.
1046 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1047 (Fdbus_register_method): Use Qinvalid_function.
1048
1049 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1050
1051 * makefile.w32-in: Update dependencies.
1052 (LISP_H): Add inttypes.h and stdin.h.
1053 (PROCESS_H): Add unistd.h.
1054
1055 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1056
1057 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1058 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1059
1060 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1061
1062 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1063
1064 * term.c (vfatal): Remove stray call to va_end.
1065 It's not needed and the C Standard doesn't allow it here anyway.
1066
1067 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1068 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1069
1070 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1071 bytes.
1072
1073 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1074
1075 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1076
1077 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1078
1079 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1080
1081 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1082
1083 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1084 * charset.c (Fdefine_charset_internal): Don't initialize
1085 charset.code_space[15]. The value was garbage, on hosts with
1086 32-bit int (Bug#8600).
1087
1088 * lread.c (read_integer): Be more consistent with string-to-number.
1089 Use string_to_number to do the actual conversion; this avoids
1090 rounding errors and fixes some other screwups. Without this fix,
1091 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1092 (digit_to_number): Move earlier, for benefit of read_integer.
1093 Return -1 if the digit is out of range for the base, -2 if it is
1094 not a digit in any supported base. (Bug#8602)
1095
1096 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1097
1098 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1099 to match comment at start of function. This also removes a
1100 GCC warning about overflow in a 32+64-bit port.
1101
1102 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1103
1104 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1105 Reported by Stefan Monnier in
1106 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1107 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1108 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1109
1110 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1111 (EMACS_UINTPTR): Likewise, with uintptr_t.
1112
1113 * lisp.h: Prefer 64-bit EMACS_INT if available.
1114 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1115 on 32-bit hosts that have 64-bit int, so that they can access
1116 large files.
1117 However, temporarily disable this change unless the temporary
1118 symbol WIDE_EMACS_INT is defined.
1119
1120 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1121
1122 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1123 This removes an assumption that EMACS_INT and long are the same
1124 width as pointers. The assumption is true for Emacs porting targets
1125 now, but we want to make other targets possible.
1126 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1127 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1128 In the rest of the code, change types of integers that hold casted
1129 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1130 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1131 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1132 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1133 No need to cast type when ORing.
1134 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1135 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1136 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1137 assume EMACS_INT is the same width as char *.
1138 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1139 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1140 Remove no-longer-needed casts.
1141 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1142 (xg_tool_bar_help_callback, xg_make_tool_item):
1143 Use EMACS_INTPTR to hold an integer
1144 that will be cast to void *; this can avoid a GCC warning
1145 if EMACS_INT is not the same width as void *.
1146 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1147 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1148 (current_message_1, set_message_1):
1149 Use a local to convert to proper width without a cast.
1150 * xmenu.c (dialog_selection_callback): Likewise.
1151
1152 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1153 Also, don't assume VALBITS / RAND_BITS is less than 5,
1154 and don't rely on undefined behavior when shifting a 1 left into
1155 the sign bit.
1156 * lisp.h (get_random): Change signature to match.
1157
1158 * lread.c (hash_string): Use size_t, not int, for hash computation.
1159 Normally we prefer signed values; but hashing is special, because
1160 it's better to use unsigned division on hash table sizes so that
1161 the remainder is nonnegative. Also, size_t is the natural width
1162 for hashing into memory. The previous code used 'int', which doesn't
1163 retain enough info to hash well into very large tables.
1164 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1165
1166 * dbusbind.c: Don't possibly lose pointer info when converting.
1167 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1168 Use XPNTR rather than XHASH, so that the high-order bits of
1169 the pointer aren't lost when converting through void *.
1170
1171 * eval.c (Fautoload): Don't double-shift a pointer.
1172
1173 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1174
1175 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1176
1177 * gnutls.c (DEF_GNUTLS_FN):
1178 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1179
1180 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1181
1182 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1183 marker. (Bug#8610)
1184
1185 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1186
1187 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1188 New version that can reserve upto 2GB of heap space.
1189
1190 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1191
1192 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1193
1194 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1195
1196 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1197 `gnutls_certificate_set_x509_key_file'.
1198
1199 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1200
1201 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1202 Update dependencies.
1203
1204 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1205
1206 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1207 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1208 Remove unused parameter `fildes'.
1209 * process.c (read_process_output, send_process): Don't pass it.
1210
1211 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1212
1213 Fix previous change: the library cache is defined in w32.c.
1214 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1215 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1216
1217 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1218
1219 Implement dynamic loading of GnuTLS on Windows.
1220
1221 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1222 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1223 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1224 Declare.
1225
1226 * gnutls.c (Qgnutls_dll): Define.
1227 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1228 (gnutls_*): Declare function pointers.
1229 (init_gnutls_functions): New function to initialize function pointers.
1230 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1231 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1232 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1233 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1234 (emacs_gnutls_write, emacs_gnutls_read)
1235 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1236 (Fgnutls_available_p): New function.
1237 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1238 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1239 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1240
1241 * image.c: Include w32.h.
1242 (Vimage_type_cache): Delete.
1243 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1244 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1245 (w32_delayed_load): Move to w32.c.
1246
1247 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1248
1249 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1250 (w32_delayed_load): Move from image.c. When loading a library, record
1251 its filename in the :loaded-from property of the library id.
1252 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1253 Initialize and staticpro them.
1254 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1255
1256 * process.c: Include lisp.h before w32.h, not after.
1257 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1258 instead of gnutls_record_check_pending.
1259
1260 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1261
1262 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1263
1264 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1265 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1266 as passed in.
1267
1268 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1269
1270 * xterm.c (x_set_frame_alpha): Do not set property on anything
1271 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1272
1273 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1274
1275 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1276
1277 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1278
1279 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1280 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1281 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1282 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1283 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1284 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1285 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1286 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1287 (Qgnutls_bootprop_callbacks_verify): Make static.
1288
1289 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1290
1291 * callproc.c: Indentation fixup.
1292
1293 * sysdep.c (wait_for_termination_1): Make static.
1294 (wait_for_termination, interruptible_wait_for_termination):
1295 Move after wait_for_termination_1.
1296
1297 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1298
1299 * sysdep.c (interruptible_wait_for_termination): New function
1300 which is like wait_for_termination, but allows keyboard
1301 interruptions.
1302
1303 * callproc.c (Fcall_process): Add (:file "file") as an option for
1304 the STDOUT buffer.
1305 (Fcall_process_region): Ditto.
1306
1307 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1308
1309 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1310 rather than `XVECTOR (FOO)->size'.
1311
1312 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1313 inttypes.h, as a gnulib replacement is used if it not available in
1314 system headers.
1315
1316 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1317
1318 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1319 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1320 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1321
1322 * coding.c (coding_alloc_by_realloc): Error out if destination
1323 will grow beyond MOST_POSITIVE_FIXNUM.
1324 (decode_coding_emacs_mule): Abort if there isn't enough place in
1325 charbuf for the composition carryover bytes. Reserve an extra
1326 space for up to 2 characters produced in a loop.
1327 (decode_coding_iso_2022): Abort if there isn't enough place in
1328 charbuf for the composition carryover bytes.
1329
1330 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1331
1332 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1333 aborting when %lld or %lll format is passed.
1334 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1335 %llo or %llx format is passed. (Bug#8545)
1336
1337 * window.c (window_scroll_line_based): Use a marker instead of
1338 simple variables to record original value of point. (Bug#7952)
1339
1340 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1341 produced by %s or %c overflows available buffer space. (Bug#8545)
1342
1343 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1344
1345 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1346 (SIZE_MAX): Move defn after all includes, as they might #define it.
1347
1348 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1349
1350 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1351
1352 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1353
1354 * keyboard.c (Qdelayed_warnings_hook): Define.
1355 (command_loop_1): Run `delayed-warnings-hook'
1356 if Vdelayed_warnings_list is non-nil.
1357 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1358 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1359
1360 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1361
1362 * doprnt.c (doprnt): Don't return value smaller than the buffer
1363 size if the message was truncated. (Bug#8545).
1364
1365 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1366
1367 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1368 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1369
1370 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1371
1372 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1373
1374 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1375
1376 * makefile.w32-in: Update dependencies.
1377
1378 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1379
1380 Improve `doprnt' and its usage. (Bug#8545)
1381 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1382 `format_end'. Remove support for %l as a conversion specifier.
1383 Don't use xrealloc. Improve diagnostics when the %l size modifier
1384 is used. Update the commentary.
1385
1386 * eval.c (verror): Simplify calculation of size_t.
1387
1388 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1389 messages.
1390
1391 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1392
1393 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1394 change.
1395
1396 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1397
1398 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1399 This makes this file independent of the recent pseudovector change.
1400
1401 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1402
1403 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1404
1405 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1406 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1407 Remove unused local.
1408 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1409
1410 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1411 GCC 4.6.0 optimizes based on type-based alias analysis.
1412 For example, if b is of type struct buffer * and v of type struct
1413 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1414 != &v->size, and therefore "v->size = 1; b->size = 2; return
1415 v->size;" must therefore return 1. This assumption is incorrect
1416 for Emacs, since it type-puns struct Lisp_Vector * with many other
1417 types. To fix this problem, this patch adds a new type struct
1418 vectorlike_header that documents the constraints on layout of vectors
1419 and pseudovectors, and helps optimizing compilers not get fooled
1420 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1421 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1422 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1423 the size member.
1424 (XSETPVECTYPE): Rewrite in terms of new macro.
1425 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1426 This is a bit clearer, and further avoids the possibility of
1427 undesirable aliasing.
1428 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1429 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1430 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1431 since Lisp_Subr is a special case (no "next" field).
1432 (ASIZE): Now uses header.size rather than size.
1433 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1434 to avoid the hassle of writing XVECTOR (foo)->header.size.
1435 (struct vectorlike_header): New type.
1436 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1437 object, to help avoid aliasing.
1438 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1439 (SUBRP): Likewise, since Lisp_Subr is a special case.
1440 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1441 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1442 (struct Lisp_Hash_Table): Combine first two members into a single
1443 struct vectorlike_header member. All uses of "size" and "next" members
1444 changed to be "header.size" and "header.next".
1445 * buffer.h (struct buffer): Likewise.
1446 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1447 * frame.h (struct frame): Likewise.
1448 * process.h (struct Lisp_Process): Likewise.
1449 * termhooks.h (struct terminal): Likewise.
1450 * window.c (struct save_window_data, struct saved_window): Likewise.
1451 * window.h (struct window): Likewise.
1452 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1453 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1454 * buffer.c (init_buffer_once): Likewise.
1455 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1456 special case.
1457 * process.c (Fformat_network_address): Use local var for size,
1458 for brevity.
1459
1460 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1461
1462 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1463 * data.c (atof): Remove decl; no longer used or needed.
1464 (digit_to_number): Move to lread.c.
1465 (Fstring_to_number): Use new string_to_number function, to be
1466 consistent with how the Lisp reader treats infinities and NaNs.
1467 Do not assume that floating-point numbers represent EMACS_INT
1468 without losing information; this is not true on most 64-bit hosts.
1469 Avoid double-rounding errors, by insisting on integers when
1470 parsing non-base-10 numbers, as the documentation specifies.
1471 * lisp.h (string_to_number): New decl, replacing ...
1472 (isfloat_string): Remove.
1473 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1474 (read1): Do not accept +. and -. as integers; this
1475 appears to have been a coding error. Similarly, do not accept
1476 strings like +-1e0 as floating point numbers. Do not report
1477 overflow for integer overflows unless the base is not 10 which
1478 means we have no simple and reliable way to continue.
1479 Break out the floating-point parsing into a new
1480 function string_to_number, so that Fstring_to_number parses
1481 floating point numbers consistently with the Lisp reader.
1482 (digit_to_number): Move here from data.c. Make it static inline.
1483 (E_CHAR, EXP_INT): Remove, replacing with ...
1484 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1485 (string_to_number): New function, replacing isfloat_string.
1486 This function checks for valid syntax and produces the resulting
1487 Lisp float number too. Rework it so that string-to-number
1488 no longer mishandles examples like "1.0e+". Use strtoumax,
1489 so that overflow for non-base-10 numbers is reported only when
1490 there's no portable and simple way to convert to floating point.
1491
1492 * textprop.c (set_text_properties_1): Rewrite for clarity,
1493 and to avoid GCC warning about integer overflow.
1494
1495 * intervals.h (struct interval): Use EMACS_INT for members
1496 where EMACS_UINT might cause problems. See
1497 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1498 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1499 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1500 All uses changed.
1501 (offset_intervals): Tell GCC not to worry about length overflow
1502 when negating a negative length.
1503
1504 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1505 (overrun_check_free): Likewise.
1506
1507 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1508 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1509 word size.
1510
1511 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1512 (gnutls_make_error): Rename local to avoid shadowing.
1513 (gnutls_emacs_global_deinit): ifdef out; not used.
1514 (Fgnutls_boot): Use const for pointer to readonly storage.
1515 Comment out unused local. Fix pointer signedness problems.
1516
1517 * lread.c (openp): Don't stuff size_t into an 'int'.
1518 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1519 about possible signed overflow.
1520
1521 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1522 (GDK_KEY_g): Don't define if already defined.
1523 (xg_prepare_tooltip): Avoid pointer signedness problem.
1524 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1525
1526 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1527 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1528
1529 * xfns.c (Fx_window_property): Simplify a bit,
1530 to make a bit faster and to avoid GCC 4.6.0 warning.
1531 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1532
1533 * fns.c (internal_equal): Don't assume size_t fits in int.
1534
1535 * alloc.c (compact_small_strings): Tighten assertion a little.
1536
1537 Replace pEd with more-general pI, and fix some printf arg casts.
1538 * lisp.h (pI): New macro, generalizing old pEd macro to other
1539 conversion specifiers. For example, use "...%"pI"d..." rather
1540 than "...%"pEd"...".
1541 (pEd): Remove. All uses replaced with similar uses of pI.
1542 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1543 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1544 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1545 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1546 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1547 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1548 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1549 64-bit hosts.
1550 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1551 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1552 * print.c (safe_debug_print, print_object): Likewise.
1553 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1554 to int.
1555 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1556 avoiding the 0 flag, which is not portable.
1557 * process.c (Fmake_network_process): Use pI to avoid cast.
1558 * region-cache.c (pp_cache): Likewise.
1559 * xdisp.c (decode_mode_spec): Likewise.
1560 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1561 behavior on 64-bit hosts with printf arg.
1562 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
1563 (x_stop_queuing_selection_requests): Likewise.
1564 (x_get_window_property): Don't truncate byte count to an 'int'
1565 when tracing.
1566
1567 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1568 here, since it parses constructs like leading '-' and spaces,
1569 which are not wanted; and it overflows with large numbers.
1570 Instead, simply match F[0-9]+, which is what is wanted anyway.
1571
1572 * alloc.c: Remove unportable assumptions about struct layout.
1573 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1574 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1575 (allocate_vectorlike, make_pure_vector): Use the new macros,
1576 plus offsetof, to remove unportable assumptions about struct layout.
1577 These assumptions hold on all porting targets that I know of, but
1578 they are not guaranteed, they're easy to remove, and removing them
1579 makes further changes easier.
1580
1581 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1582 This doesn't fix a bug but makes the code clearer.
1583 (string_overrun_cookie): Now const. Use initializers that
1584 don't formally overflow signed char, to avoid warnings.
1585 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1586 can cause Emacs to crash when string overrun checking is enabled.
1587 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1588 multiple of sizeof (EMACS_INT); it need not be, if
1589 alignof(EMACS_INT) < sizeof (EMACS_INT).
1590 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1591
1592 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1593
1594 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1595
1596 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1597
1598 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1599 supposed to be handshaking. (Bug#8556)
1600 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1601
1602 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1603
1604 * lisp.h (Qdebug): List symbol.
1605 * eval.c (Qdebug): Restore global linkage.
1606 * keyboard.c (debug-on-event): New variable.
1607 (handle_user_signal): Break into debugger when debug-on-event
1608 matches the current signal symbol.
1609
1610 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1611
1612 * alloc.c (check_sblock, check_string_bytes)
1613 (check_string_free_list): Convert to standard C.
1614
1615 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1616
1617 * w32.c (emacs_gnutls_push): Fix typo.
1618
1619 2011-04-25 Eli Zaretskii <eliz@gnu.org>
1620
1621 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1622 "cast to pointer from integer of different size".
1623
1624 Improve doprnt and its use in verror. (Bug#8545)
1625 * doprnt.c (doprnt): Document the set of format control sequences
1626 supported by the function. Use SAFE_ALLOCA instead of always
1627 using `alloca'.
1628
1629 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1630 is one byte too soon. Don't use xrealloc; instead xfree and
1631 xmalloc anew.
1632
1633 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1634
1635 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1636 callbacks stage.
1637
1638 * gnutls.c: Renamed global_initialized to
1639 gnutls_global_initialized. Added internals for the
1640 :verify-hostname-error, :verify-error, and :verify-flags
1641 parameters of `gnutls-boot' and documented those parameters in the
1642 docstring. Start callback support.
1643 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1644 unless a fatal error occured. Call gnutls_alert_send_appropriate
1645 on error. Return error code.
1646 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1647 (emacs_gnutls_read): Likewise.
1648 (Fgnutls_boot): Return handshake error code.
1649 (emacs_gnutls_handle_error): New function.
1650 (wsaerror_to_errno): Likewise.
1651
1652 * w32.h (emacs_gnutls_pull): Add prototype.
1653 (emacs_gnutls_push): Likewise.
1654
1655 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1656 (emacs_gnutls_push): Likewise.
1657
1658 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1659
1660 * process.c (wait_reading_process_output): Check if GnuTLS
1661 buffered some data internally if no FDs are set for TLS
1662 connections.
1663
1664 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1665 (LIBS): Link to USER_LIBS.
1666 ($(BLD)/gnutls.$(0)): New target.
1667
1668 2011-04-24 Eli Zaretskii <eliz@gnu.org>
1669
1670 * xdisp.c (handle_single_display_spec): Rename the
1671 display_replaced_before_p argument into display_replaced_p, to
1672 make it consistent with the commentary. Fix typos in the
1673 commentary.
1674
1675 * textprop.c (syms_of_textprop): Remove dead code.
1676 (copy_text_properties): Delete obsolete commentary about an
1677 interface that was deleted long ago. Fix typos in the description
1678 of arguments.
1679
1680 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1681 to changes in oldXMenu/XMenu.h from 2011-04-16.
1682 <menu_help_message, prev_menu_help_message>: Constify.
1683 (IT_menu_make_room): menu->help_text is now `const char **';
1684 adjust.
1685
1686 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1687 to changes in oldXMenu/XMenu.h from 2011-04-16.
1688 (struct XMenu): Declare `help_text' `const char **'.
1689
1690 * xfaces.c <Qunspecified>: Make extern again.
1691
1692 * syntax.c: Include sys/types.h before including regex.h, as
1693 required by Posix.
1694
1695 * doc.c (get_doc_string): Improve the format passed to `error'.
1696
1697 * doprnt.c (doprnt): Improve commentary.
1698
1699 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1700
1701 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1702 them with etags.
1703
1704 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1705 changes in globals.h immediately force recompilation.
1706 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1707 $(CURDIR)/s/ms-w32.h.
1708 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1709
1710 * character.c (Fchar_direction): Function deleted.
1711 (syms_of_character): Don't defsubr it.
1712 <char-direction-table>: Deleted.
1713
1714 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1715
1716 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1717 * doprnt.c: Include limits.h.
1718 (SIZE_MAX): New macro.
1719 (doprnt): Return a size_t value. 2nd arg is now size_t.
1720 Many local variables are now size_t instead of int or unsigned.
1721 Improve overflow protection. Support `l' modifier for integer
1722 conversions. Support %l conversion. Don't assume an EMACS_INT
1723 argument for integer conversions and for %c.
1724
1725 * lisp.h (doprnt): Restore prototype.
1726
1727 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1728 $(SRC)/character.h.
1729
1730 * Makefile.in (base_obj): Add back doprnt.o.
1731
1732 * deps.mk (doprnt.o): Add back prerequisites.
1733 (callint.o): Depend on character.h.
1734
1735 * eval.c (internal_lisp_condition_case): Include the handler
1736 representation in the error message.
1737 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1738 when breaking from the loop.
1739
1740 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1741
1742 * callint.c (Fcall_interactively): When displaying error message
1743 about invalid control letter, pass the character's codepoint, not
1744 a pointer to its multibyte form. Improve display of the character
1745 in octal and display also its hex code.
1746
1747 * character.c (char_string): Use %x to display the (unsigned)
1748 codepoint of an invalid character, to avoid displaying a bogus
1749 negative value.
1750
1751 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1752 `error', not SYMBOL_NAME itself.
1753
1754 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1755 character arguments to `error'.
1756
1757 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1758 to `error' in error message about FINAL_CHAR argument. Make sure
1759 FINAL_CHAR is a character, and use %c when it is passed as
1760 argument to `error'.
1761
1762 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1763
1764 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1765
1766 * w32.c: Include <time.h>.
1767 (sys_localtime): New function.
1768
1769 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1770
1771 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1772
1773 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1774
1775 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1776
1777 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1778 zombies (Bug#8467).
1779
1780 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1781
1782 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1783 gl_state.e_property when gl_state.object is Qt.
1784
1785 * insdel.c (make_gap_larger): Remove limitation of buffer size
1786 to <= INT_MAX.
1787
1788 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1789
1790 * xdisp.c (lookup_glyphless_char_display)
1791 (produce_glyphless_glyph): Handle cons cell entry in
1792 glyphless-char-display.
1793 (Vglyphless_char_display): Document it.
1794
1795 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1796 glyphless-char-display.
1797
1798 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
1799
1800 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1801
1802 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1803
1804 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1805 definition for no-X builds.
1806
1807 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1808
1809 Static checks with GCC 4.6.0 and non-default toolkits.
1810
1811 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1812
1813 * process.c (keyboard_bit_set): Define only if SIGIO.
1814 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1815 (send_process): Repair possible setjmp clobbering.
1816
1817 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1818
1819 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1820
1821 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1822
1823 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1824 Define only if needed.
1825
1826 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1827 by pacifying GCC about it. Maybe it's time to retire it?
1828 * xfaces.c (USG, __TIMEVAL__): Likewise.
1829
1830 * dispextern.h (struct redisplay_interface): Rename param
1831 to avoid shadowing.
1832 * termhooks.h (struct terminal): Likewise.
1833 * xterm.c (xembed_send_message): Likewise.
1834
1835 * insdel.c (make_gap_smaller): Define only if
1836 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1837
1838 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1839 it.
1840
1841 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1842 so that we aren't warned about unused symbols.
1843
1844 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1845
1846 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1847
1848 * xfns.c (x_real_positions): Mark locals as initialized.
1849
1850 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1851
1852 * xterm.c: Fix problems found by static analysis with other toolkits.
1853 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1854 (x_dispatch_event): Declare static if USE_GTK, and
1855 define if USE_GTK || USE_X_TOOLKIT.
1856 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1857 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1858 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1859 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1860
1861 * xmenu.c (menu_help_callback): Pointer type fixes.
1862 Use const pointers when pointing at readonly data. Avoid pointer
1863 signedness clashes.
1864 (FALSE): Remove unused macro.
1865 (update_frame_menubar): Remove unused decl.
1866
1867 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1868
1869 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1870 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1871 (single_menu_item): Rename local to avoid shadowing.
1872
1873 * keyboard.c (make_lispy_event): Remove unused local var.
1874
1875 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1876 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1877
1878 * bitmaps: Change bitmaps from unsigned char back to the X11
1879 compatible char. Avoid the old compiler warnings about
1880 out-of-range initializers by using, for example, '\xab' rather
1881 than 0xab.
1882
1883 * xgselect.c (xgselect_initialize): Check vs interface
1884 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1885
1886 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1887
1888 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1889 to read-only memory.
1890
1891 * fns.c (vector): Remove; this old hack is no longer needed.
1892
1893 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1894 Remove unused var.
1895 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1896
1897 * xrdb.c (x_load_resources): Omit unused local.
1898
1899 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1900 (x_window): Rename locals to avoid shadowing.
1901 (USG): Use the kludged USG macro, to pacify gcc.
1902
1903 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1904 (x_term_init): Remove local to avoid shadowing.
1905
1906 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1907
1908 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1909 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1910
1911 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1912
1913 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1914
1915 Fix regex.c, syntax.c and friends for buffers > 2GB.
1916 * syntax.h (struct gl_state_s): Declare character position members
1917 EMACS_INT.
1918
1919 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1920
1921 * textprop.c (verify_interval_modification, interval_of):
1922 Declare arguments EMACS_INT.
1923
1924 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1925 EMACS_INT.
1926
1927 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1928
1929 * indent.c (Fvertical_motion): Local variable it_start is now
1930 EMACS_INT.
1931
1932 * regex.c (re_match, re_match_2, re_match_2_internal)
1933 (bcmp_translate, regcomp, regexec, print_double_string)
1934 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1935 (re_compile_pattern, re_exec): Declare arguments and local
1936 variables `size_t' and `ssize_t' and return values `regoff_t', as
1937 appropriate.
1938 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1939 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1940 <compile_stack_type>: `size' and `avail' are now `size_t'.
1941
1942 * regex.h <regoff_t>: Use ssize_t, not int.
1943 (re_search, re_search_2, re_match, re_match_2): Arguments that
1944 specify buffer/string position and length are now ssize_t and
1945 size_t. Return type is regoff_t.
1946
1947 2011-04-16 Ben Key <bkey76@gmail.com>
1948
1949 * nsfont.m: Fixed bugs in ns_get_family and
1950 ns_descriptor_to_entity that were caused by using free to
1951 deallocate memory blocks that were allocated by xmalloc (via
1952 xstrdup). This caused Emacs to crash when compiled with
1953 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1954 --enable-checking=xmallocoverrun). xfree is now used to
1955 deallocate these memory blocks.
1956
1957 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1958
1959 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1960
1961 emacs_write: Accept and return EMACS_INT for sizes.
1962 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1963 et seq.
1964 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1965 Accept and return EMACS_INT.
1966 (emacs_gnutls_write): Return the number of bytes written on
1967 partial writes.
1968 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1969 (emacs_read, emacs_write): Remove check for negative size, as the
1970 Emacs source code has been audited now.
1971 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1972 (emacs_read, emacs_write): Use it.
1973 * process.c (send_process): Adjust to the new signatures of
1974 emacs_write and emacs_gnutls_write. Do not attempt to store
1975 a byte offset into an 'int'; it might overflow.
1976 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1977
1978 * sound.c: Don't assume sizes fit in 'int'.
1979 (struct sound_device.period_size, alsa_period_size):
1980 Return EMACS_INT, not int.
1981 (struct sound_device.write, vox_write, alsa_write):
1982 Accept EMACS_INT, not int.
1983 (wav_play, au_play): Use EMACS_INT to store sizes and to
1984 record read return values.
1985
1986 2011-04-15 Ben Key <bkey76@gmail.com>
1987
1988 * keyboard.c (Qundefined): Don't declare static since it is used
1989 in nsfns.m.
1990 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1991 static since they are used in nsfont.m.
1992
1993 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1994
1995 * process.c (Qprocessp): Don't declare static.
1996 * lisp.h (Qprocessp): Declare again.
1997
1998 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
1999
2000 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2001
2002 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2003
2004 Improve C-level modularity by making more things 'static'.
2005
2006 Don't publish debugger-only interfaces to other modules.
2007 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2008 (verify_bytepos, count_markers): Move decls to the only modules
2009 that need them.
2010 * region-cache.h (pp_cache): Likewise.
2011 * window.h (check_all_windows): Likewise.
2012 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2013
2014 * sysdep.c (croak): Now static, if
2015 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2016 * syssignal.h (croak): Declare only if not static.
2017
2018 * alloc.c (refill_memory_reserve): Now static if
2019 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2020 * lisp.h (refill_memory_reserve): Declare only if not static.
2021
2022 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2023 Define only if USE_LUCID.
2024
2025 * xrdb.c (x_customization_string, x_rm_string): Now static.
2026
2027 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2028 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2029
2030 * xdisp.c (draw_row_with_mouse_face): Now static.
2031 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2032
2033 * window.h (check_all_windows): Mark externally visible.
2034
2035 * window.c (window_deletion_count): Now static.
2036
2037 * undo.c: Make symbols static if they're not exported.
2038 (last_undo_buffer, last_boundary_position, pending_boundary):
2039 Now static.
2040
2041 * textprop.c (interval_insert_behind_hooks): Now static.
2042 (interval_insert_in_front_hooks): Likewise.
2043
2044 * term.c: Make symbols static if they're not exported.
2045 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2046 (max_frame_lines, tty_set_terminal_modes):
2047 (tty_reset_terminal_modes, tty_turn_off_highlight):
2048 (get_tty_terminal): Now static.
2049 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2050 * termhooks.h (term_mouse_moveto): Do not declare if
2051 HAVE_WINDOW_SYSTEM.
2052 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2053 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2054
2055 * sysdep.c: Make symbols static if they're not exported.
2056 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2057 Now static.
2058 (sigprocmask_set, full_mask): Remove; unused.
2059 (wait_debugging): Mark as visible.
2060 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2061 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2062
2063 * syntax.c (syntax_temp): Define only if !__GNUC__.
2064
2065 * sound.c (current_sound_device, current_sound): Now static.
2066
2067 * search.c (searchbufs, searchbuf_head): Now static.
2068
2069 * scroll.c (scroll_cost): Remove; unused.
2070 * dispextern.h (scroll_cost): Remove decl.
2071
2072 * region-cache.h (pp_cache): Mark as externally visible.
2073
2074 * process.c: Make symbols static if they're not exported.
2075 (process_tick, update_tick, create_process, chan_process):
2076 (Vprocess_alist, proc_buffered_char, datagram_access):
2077 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2078 (deactivate_process): Mark defn as static, as well as decl.
2079 * lisp.h (create_process): Remove decl.
2080 * process.h (chan_process, Vprocess_alist): Remove decls.
2081
2082 * print.c: Make symbols static if they're not exported.
2083 (print_depth, new_backquote_output, being_printed, print_buffer):
2084 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2085 (print_interval, print_number_index, initial_stderr_stream):
2086 Now static.
2087 * lisp.h (Fprinc): Remove decl.
2088 (debug_output_compilation_hack): Mark as externally visible.
2089
2090 * sysdep.c (croak): Move decl from here to syssignal.h.
2091 * syssignal.h (croak): Put it here, so the API can be checked when
2092 'croak' is called from dissociate_if_controlling_tty.
2093
2094 * minibuf.c: Make symbols static if they're not exported.
2095 (minibuf_save_list, choose_minibuf_frame): Now static.
2096 * lisp.h (choose_minibuf_frame): Remove decl.
2097
2098 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2099
2100 * lread.c: Make symbols static if they're not exported.
2101 (read_objects, initial_obarray, oblookup_last_bucket_number):
2102 Now static.
2103 (make_symbol): Remove; unused.
2104 * lisp.h (initial_obarray, make_symbol): Remove decls.
2105
2106 * keyboard.c: Make symbols static if they're not exported.
2107 (single_kboard, recent_keys_index, total_keys, recent_keys):
2108 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2109 (this_single_command_key_start, echoing, last_auto_save):
2110 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2111 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2112 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2113 (Vlispy_mouse_stem, double_click_count):
2114 Now static.
2115 (force_auto_save_soon): Define only if SIGDANGER.
2116 (ignore_mouse_drag_p): Now static if
2117 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2118 (print_help): Remove; unused.
2119 (stop_character, last_timer_event): Mark as externally visible.
2120 * keyboard.h (ignore_mouse_drag_p): Declare only if
2121 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2122 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2123 * lisp.h (echoing): Remove decl.
2124 (force_auto_save_soon): Declare only if SIGDANGER.
2125 * xdisp.c (redisplay_window): Simplify code, to make it more
2126 obvious that ignore_mouse_drag_p is not accessed if !defined
2127 USE_GTK && !defined HAVE_NS.
2128
2129 * intervals.c: Make symbols static if they're not exported.
2130 (merge_properties_sticky, merge_interval_right, delete_interval):
2131 Now static.
2132 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2133
2134 * insdel.c: Make symbols static if they're not exported.
2135 However, leave prepare_to_modify_buffer alone. It's never
2136 called from outside this function, but that appears to be a bug.
2137 (combine_after_change_list, combine_after_change_buffer):
2138 (adjust_after_replace, signal_before_change): Now static.
2139 (adjust_after_replace_noundo): Remove; unused.
2140 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2141 (signal_before_change): Remove decls.
2142
2143 * indent.c (val_compute_motion, val_vmotion): Now static.
2144
2145 * image.c: Make symbols static if they're not exported.
2146 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2147 if USE_GTK.
2148 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2149 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2150
2151 * fringe.c (standard_bitmaps): Now static.
2152 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2153
2154 * frame.c: Make symbols static if they're not exported.
2155 (x_report_frame_params, make_terminal_frame): Now static.
2156 (get_frame_param): Now static, unless HAVE_NS.
2157 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2158 (x_get_resource_string): Remove; not used.
2159 * frame.h (make_terminal_frame, x_report_frame_params):
2160 (x_get_resource_string); Remove decls.
2161 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2162 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2163
2164 * font.c, fontset.c: Make symbols static if they're not exported.
2165 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2166 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2167 * font.c (font_close_object): Now static.
2168 * font.h (font_close_object): Remove.
2169 * fontset.c (FONTSET_OBJLIST): Remove.
2170 (free_realized_fontset) #if-0 the body, which does nothing.
2171 (face_suitable_for_char_p): #if-0, as it's never called.
2172 * fontset.h (face_suitable_for_char_p): Remove decl.
2173 * xfaces.c (face_at_string_position):
2174 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2175 since 0 is always ASCII.
2176
2177 * fns.c (weak_hash_tables): Now static.
2178
2179 * fileio.c: Make symbols static if they're not exported.
2180 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2181 (Vwrite_region_annotation_buffers): Now static.
2182
2183 * eval.c: Make symbols static if they're not exported.
2184 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2185 * lisp.h (backtrace_list): Remove decl.
2186
2187 * emacs.c: Make symbols static if they're not exported.
2188 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2189 (fatal_error_code, fatal_error_signal_hook, standard_args):
2190 Now static.
2191 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2192 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2193 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2194 * lisp.h (fatal_error_signal_hook): Remove decl.
2195 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2196
2197 * editfns.c: Move a (normally-unused) function to its only use.
2198 * editfns.c, lisp.h (get_operating_system_release): Remove.
2199 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2200 worth the hassle of breaking this out.
2201
2202 * xterm.c: Make symbols static if they're not exported.
2203 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2204 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2205 (x_destroy_window, x_delete_display):
2206 Now static.
2207 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2208 (x_mouse_leave): Remove; unused.
2209 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2210 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2211 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2212 Remove decls.
2213 (x_mouse_leave): Declare only if WINDOWSNT.
2214 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2215 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2216 USE_X_TOOLKIT.
2217
2218 * ftxfont.c: Make symbols static if they're not exported.
2219 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2220 HAVE_FREETYPE.
2221 * font.h (ftxfont_driver): Likewise.
2222
2223 * xfns.c: Make symbols static if they're not exported.
2224 (x_last_font_name, x_display_info_for_name):
2225 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2226 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2227 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2228 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2229 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2230 (last_show_tip_args): Now static.
2231 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2232 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2233 (x_screen_planes): Remove; unused.
2234 * dispextern.h (x_screen_planes): Remove decl.
2235
2236 * dispnew.c: Make symbols static if they're not exported.
2237 * dispextern.h (redraw_garbaged_frames, scrolling):
2238 (increment_row_positions): Remove.
2239 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2240 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2241 Now static.
2242 (redraw_garbaged_frames): Remove; unused.
2243
2244 * xfaces.c: Make symbols static if they're not exported.
2245 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2246 Remove decls.
2247 * xterm.h (defined_color): Remove decls.
2248 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2249 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2250 (menu_face_changed_default, defined_color, free_realized_face):
2251 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2252 (ascii_face_of_lisp_face): Remove; unused.
2253
2254 * xdisp.c: Make symbols static if they're not exported.
2255 * dispextern.h (scratch_glyph_row, window_box_edges):
2256 (glyph_to_pixel_coords, set_cursor_from_row):
2257 (get_next_display_element, set_iterator_to_next):
2258 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2259 (show_mouse_face): Remove decls
2260 * frame.h (message_buf_print): Likewise.
2261 * lisp.h (pop_message, set_message, check_point_in_composition):
2262 Likewise.
2263 * xterm.h (set_vertical_scroll_bar): Likewise.
2264 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2265 (message_buf_print, scratch_glyph_row, displayed_buffer):
2266 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2267 (get_next_display_element, show_mouse_face, window_box_edges):
2268 (frame_to_window_pixel_xy, check_point_in_composition):
2269 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2270 (glyph_to_pixel_coords): Remove; unused.
2271
2272 * dired.c (file_name_completion): Now static.
2273
2274 * dbusbind.c (xd_in_read_queued_messages): Now static.
2275
2276 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2277 * data.c (circular_list_error): Remove.
2278
2279 * commands.h (last_point_position, last_point_position_buffer):
2280 (last_point_position_window): Remove decls.
2281 * keyboard.c: Make these variables static.
2282
2283 * coding.h (coding, code_convert_region, encode_coding_gap):
2284 Remove decls.
2285 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2286 (iso_code_class, detect_coding, code_convert_region): Now static.
2287 (encode_coding_gap): Remove; unused.
2288
2289 * chartab.c (chartab_chars, chartab_bits): Now static.
2290
2291 * charset.h (charset_iso_8859_1): Remove decl.
2292 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2293 Now static.
2294
2295 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2296 * ccl.c (Vccl_program_table): Now static.
2297 (check_ccl_update): Remove; unused.
2298
2299 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2300 * category.h: ... from here.
2301 * category.c (check_category_table, set_category_set): Now static.
2302
2303 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2304 * lisp.h: Remove these decls.
2305
2306 * buffer.c (buffer_count): Remove unused var.
2307
2308 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2309 so that it's not optimized away.
2310 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2311 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2312 exported only to the debugger.
2313
2314 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2315 * atimer.h (run_all_atimers): Remove; not exported.
2316
2317 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2318 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2319 was inaccessible from Lisp.
2320 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2321 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2322
2323 alloc.c: Import and export fewer symbols, and remove unused items.
2324 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2325 is defined.
2326 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2327 it's not optimized away by whole-program optimization.
2328 (message_enable_multibyte, free_misc): Remove.
2329 (catchlist, handlerlist, mark_backtrace):
2330 Declare only if BYTE_MARK_STACK.
2331 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2332 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2333 (message_enable_multibyte): Remove decl.
2334 (free_misc, interval_free_list, float_block, float_block_index):
2335 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2336 (cons_free_list, last_marked_index):
2337 Now static.
2338 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2339 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2340 (mark_backtrace): Define only if BYTE_MARK_STACK.
2341 * xdisp.c (message_enable_multibyte): Now static.
2342
2343 Declare Lisp_Object Q* variables to be 'static' if not exported.
2344 This makes it easier for human readers (and static analyzers)
2345 to see whether these variables are used from other modules.
2346 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2347 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2348 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2349 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2350 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2351 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2352 * xmenu.c, xselect.c:
2353 Declare Q* vars static if they are not used in other modules.
2354 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2355 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2356 Remove decls of unexported vars.
2357 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2358
2359 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2360
2361 Make Emacs functions such as Fatom 'static' by default.
2362 This makes it easier for human readers (and static analyzers)
2363 to see whether these functions can be called from other modules.
2364 DEFUN now defines a static function. To make the function external
2365 so that it can be used in other C modules, use the new macro DEFUE.
2366 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2367 (Finit_image_library):
2368 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2369 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2370 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2371 Remove decls, since these functions are now static.
2372 (Funintern, Fget_internal_run_time): New decls, since these functions
2373 were already external.
2374
2375 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2376 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2377 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2378 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2379 * keyboard.c, keymap.c, lread.c:
2380 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2381 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2382 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2383 Mark functions with DEFUE instead of DEFUN,
2384 if they are used in other modules.
2385 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2386 decls for now-static functions.
2387 * buffer.h (Fdelete_overlay): Remove decl.
2388 * callproc.c (Fgetenv_internal): Mark as internal.
2389 * composite.c (Fremove_list_of_text_properties): Remove decl.
2390 (Fcomposition_get_gstring): New forward static decl.
2391 * composite.h (Fcomposite_get_gstring): Remove decl.
2392 * dired.c (Ffile_attributes): New forward static decl.
2393 * doc.c (Fdocumntation_property): New forward static decl.
2394 * eval.c (Ffetch_bytecode): New forward static decl.
2395 (Funintern): Remove extern decl; now in .h file where it belongs.
2396 * fileio.c (Fmake_symbolic_link): New forward static decl.
2397 * image.c (Finit_image_library): New forward static decl.
2398 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2399 * intervals.h (Fprevious_property_change):
2400 (Fremove_list_of_text_properties): Remove decls.
2401 * keyboard.c (Fthis_command_keys): Remove decl.
2402 (Fcommand_execute): New forward static decl.
2403 * keymap.c (Flookup_key): New forward static decl.
2404 (Fcopy_keymap): Now static.
2405 * keymap.h (Flookup_key): Remove decl.
2406 * process.c (Fget_process): New forward static decl.
2407 (Fprocess_datagram_address): Mark as internal.
2408 * syntax.c (Fsyntax_table_p): New forward static decl.
2409 (skip_chars): Remove duplicate decl.
2410 * textprop.c (Fprevious_property_change): New forward static decl.
2411 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2412 Now internal.
2413 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2414 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2415
2416 * editfns.c (Fformat): Remove unreachable code.
2417
2418 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2419
2420 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2421 change. (Bug#8496)
2422
2423 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2424
2425 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2426 when at ZV. (Bug#8487)
2427
2428 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2429
2430 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2431 (Bug#8437)
2432 * keyboard.c (parse_tool_bar_item): Likewise.
2433 * sound.c (sound_cleanup, alsa_close): Likewise.
2434 * termcap.c (tgetent): Likewise.
2435 * xfns.c (x_default_font_parameter): Likewise.
2436 * xsettings.c (read_and_apply_settings): Likewise.
2437
2438 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2439 (overrun_check_free): Protoize.
2440
2441 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2442
2443 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2444 since callers should never pass a negative size.
2445 Change the signature to match that of plain 'read' and 'write'; see
2446 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2447 * lisp.h: Update prototypes of emacs_write and emacs_read.
2448
2449 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2450
2451 * xdisp.c (redisplay_window): Don't try to determine the character
2452 position of the scroll margin if the window start point w->startp
2453 is outside the buffer's accessible region. (Bug#8468)
2454
2455 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2456
2457 Fix write-region and its subroutines for buffers > 2GB.
2458 * fileio.c (a_write, e_write): Modify declaration of arguments and
2459 local variables to support buffers larger than 2GB.
2460 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2461
2462 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2463 argument, local variables, and return value.
2464
2465 * lisp.h: Update prototypes of emacs_write and emacs_read.
2466
2467 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2468
2469 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2470
2471 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2472
2473 Fix more problems found by GCC 4.6.0's static checks.
2474
2475 * xdisp.c (vmessage): Use a better test for character truncation.
2476
2477 * charset.c (load_charset_map): <, not <=, for optimization,
2478 and to avoid potential problems with integer overflow.
2479 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2480 * casetab.c (set_identity, shuffle): Likewise.
2481 * editfns.c (Fformat): Likewise.
2482 * syntax.c (skip_chars): Likewise.
2483
2484 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2485 This also lets GCC 4.6.0 generate slightly better loop code.
2486
2487 * callint.c (Fcall_interactively): <, not <=, for optimization.
2488 (Fcall_interactively): Count the number of arguments produced,
2489 not the number of arguments given. This is simpler and lets GCC
2490 4.6.0 generate slightly better code.
2491
2492 * ftfont.c: Distingish more carefully between FcChar8 and char.
2493 The previous code passed unsigned char * to a functions like
2494 strlen and xstrcasecmp that expect char *, which does not
2495 conform to the C standard.
2496 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2497 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2498 char * when the C standard requires it.
2499
2500 * keyboard.c (read_char): Remove unused var.
2501
2502 * eval.c: Port to Windows vsnprintf (Bug#8435).
2503 Include <limits.h>.
2504 (SIZE_MAX): Define if the headers do not.
2505 (verror): Do not give up if vsnprintf returns a negative count.
2506 Instead, grow the buffer. This ports to Windows vsnprintf, which
2507 does not conform to C99. Problem reported by Eli Zaretskii.
2508 Also, simplify the allocation scheme, by avoiding the need for
2509 calling realloc, and removing the ALLOCATED variable.
2510
2511 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2512
2513 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2514 But keep the doprint source code for now, as we might revamp it
2515 and use it again (Bug#8435).
2516 * lisp.h (doprnt): Remove.
2517 * Makefile.in (base_obj): Remove doprnt.o.
2518 * deps.mk (doprnt.o): Remove.
2519
2520 error: Print 32- and 64-bit integers portably (Bug#8435).
2521 Without this change, on typical 64-bit hosts error ("...%d...", N)
2522 was used to print both 32- and 64-bit integers N, which relied on
2523 undefined behavior.
2524 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2525 New macro.
2526 * lisp.h (error, verror): Mark as printf-like functions.
2527 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2528 Report overflow in size calculations when allocating printf buffer.
2529 Do not truncate output string at its first null byte.
2530 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2531 Truncate the output at a character boundary, since vsnprintf does not
2532 do that.
2533 * charset.c (check_iso_charset_parameter): Convert internal
2534 character to string before calling 'error', since %c now has the
2535 printf meaning.
2536 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2537 overflow when computing char to be passed to 'error'. Do not
2538 pass Lisp_Object to 'error'; pass the integer instead.
2539 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2540 formatted with plain %d.
2541
2542 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2543
2544 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2545
2546 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2547
2548 * xterm.c (x_catch_errors): Remove duplicate declaration.
2549
2550 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2551
2552 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2553
2554 2011-04-10 Jim Meyering <meyering@redhat.com>
2555
2556 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2557 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2558 return ssize_t not "int", and use size_t as the buffer length.
2559 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2560 * gnutls.h: Update declarations.
2561 * process.c (read_process_output): Use ssize_t, to match.
2562 (send_process): Likewise.
2563
2564 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2565
2566 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2567
2568 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2569
2570 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2571 Use unsigned char, to match FcChar8 type definition.
2572
2573 * xterm.c (handle_one_xevent):
2574 * xmenu.c (create_and_show_popup_menu):
2575 * xselect.c (x_decline_selection_request)
2576 (x_reply_selection_request): Avoid type-punned deref of X events.
2577
2578 2011-04-09 Eli Zaretskii <eliz@gnu.org>
2579
2580 Fix some uses of `int' instead of EMACS_INT.
2581 * search.c (string_match_1, fast_string_match)
2582 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2583 (scan_buffer, find_next_newline_no_quit)
2584 (find_before_next_newline, search_command, Freplace_match)
2585 (Fmatch_data): Make some `int' variables be EMACS_INT.
2586
2587 * xdisp.c (display_count_lines): 3rd argument and return value now
2588 EMACS_INT. All callers changed.
2589 (pint2hrstr): Last argument is now EMACS_INT.
2590
2591 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2592 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2593 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2594 (decode_coding_utf_16, decode_coding_emacs_mule)
2595 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2596 (decode_coding_ccl, decode_coding_charset)
2597 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2598 (decode_coding_iso_2022, decode_coding_emacs_mule)
2599 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2600 <char_offset, last_offset>: Declare EMACS_INT.
2601 (encode_coding_utf_8, encode_coding_utf_16)
2602 (encode_coding_emacs_mule, encode_invocation_designation)
2603 (encode_designation_at_bol, encode_coding_iso_2022)
2604 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2605 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2606 Declare EMACS_INT.
2607 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2608 (encode_invocation_designation): Last argument P_NCHARS is now
2609 EMACS_INT.
2610 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2611 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2612
2613 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2614 All users changed.
2615
2616 * ccl.c (Fccl_execute_on_string): Declare some variables
2617 EMACS_INT.
2618
2619 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2620
2621 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2622
2623 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2624
2625 * process.c (Fformat_network_address): Doc fix.
2626
2627 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2628
2629 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2630
2631 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
2632
2633 * keyboard.c (read_char): Call Lisp function help-form-show,
2634 instead of using internal_with_output_to_temp_buffer.
2635 (Qhelp_form_show): New var.
2636 (syms_of_keyboard): Use DEFSYM macro.
2637
2638 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2639
2640 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2641
2642 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
2643
2644 * process.c (Flist_processes): Remove to Lisp.
2645 (list_processes_1): Delete.
2646
2647 2011-04-06 Eli Zaretskii <eliz@gnu.org>
2648
2649 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2650
2651 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2652
2653 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
2654
2655 Fix more problems found by GCC 4.6.0's static checks.
2656
2657 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2658
2659 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2660
2661 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
2662
2663 * xdisp.c (vmessage): Mark as a printf-like function.
2664
2665 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2666
2667 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2668
2669 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2670 printf-like functions.
2671 (tiff_load): Add casts to remove these marks before passing them
2672 to system-supplied API.
2673
2674 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2675
2676 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2677 This avoids several warnings with gcc -Wstrict-overflow.
2678 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2679 directly, rather than having caller test rule sign. This avoids
2680 some unnecessary tests.
2681 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2682 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2683 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
2684
2685 * xfont.c (xfont_text_extents): Remove var that was set but not used.
2686 (xfont_open): Avoid unnecessary tests.
2687
2688 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2689
2690 * composite.h, composite.c (composition_gstring_put_cache):
2691 Use EMACS_INT, not int, for length.
2692
2693 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2694 breaking out part of COMPOSITION_DECODE_RULE.
2695 (COMPOSITION_DECODE_RULE): Use it.
2696 * composite.c (get_composition_id): Remove unused local vars,
2697 by using the new macro.
2698
2699 * textprop.c (set_text_properties_1): Change while to do-while,
2700 since the condition is always true at first.
2701
2702 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2703 (interval_deletion_adjustment): Return unsigned value.
2704 All uses changed.
2705
2706 * process.c (list_processes_1, create_pty, read_process_output):
2707 (exec_sentinel): Remove vars that were set but not used.
2708 (create_pty): Remove unnecessary "volatile"s.
2709 (Fnetwork_interface_info): Avoid possibility of int overflow.
2710 (read_process_output): Do adaptive read buffering even if carryover.
2711 (read_process_output): Simplify nbytes computation if buffered.
2712
2713 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2714
2715 * syntax.c (scan_words): Remove var that was set but not used.
2716 (update_syntax_table): Use unsigned instead of int.
2717
2718 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2719 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2720 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2721
2722 * print.c (print_error_message): Avoid int overflow.
2723
2724 * font.c (font_list_entities): Redo for clarity,
2725 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2726
2727 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2728 (font_score): Avoid potential overflow in diff calculation.
2729
2730 * fns.c (substring_both): Remove var that is set but not used.
2731 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2732
2733 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2734
2735 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2736 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2737 can always succeed if overflow has undefined behavior.
2738
2739 * search.c (boyer_moore, wordify): Remove vars set but not used.
2740 (wordify): Omit three unnecessary tests.
2741
2742 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2743 All callers changed. This avoids the need for an unused var.
2744
2745 * casefiddle.c (casify_region): Remove var that is set but not used.
2746
2747 * dired.c (file_name_completion): Remove var that is set but not used.
2748
2749 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2750
2751 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2752 (Finsert_file_contents): Remove unnecessary code checking fd.
2753
2754 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2755 Check for integer overflow on size calculations.
2756
2757 * buffer.c (Fprevious_overlay_change): Remove var that is set
2758 but not used.
2759
2760 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2761 Remove vars that are set but not used.
2762 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2763 (timer_check_2): Mark vars as initialized.
2764
2765 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2766
2767 * image.c (lookup_image): Remove var that is set but not used.
2768 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2769
2770 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2771 that are set but not used.
2772
2773 * xfns.c (make_invisible_cursor): Don't return garbage
2774 if XCreateBitmapFromData fails (Bug#8410).
2775
2776 * xselect.c (x_get_local_selection, x_handle_property_notify):
2777 Remove vars that are set but not used.
2778
2779 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2780 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2781
2782 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2783 Remove var that is set but not used.
2784 (scroll_bar_windows_size): Now size_t, not int.
2785 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2786 Check for overflow.
2787
2788 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2789 (map_tty_color) [!defined MSDOS]: Likewise.
2790
2791 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2792
2793 * coding.c: Remove vars that are set but not used.
2794 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2795 All callers changed.
2796 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2797 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2798 (decode_coding_charset): Remove vars that are set but not used.
2799
2800 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2801 that is set but not used.
2802
2803 * print.c (print_object): Remove var that is set but not used.
2804
2805 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2806 The gnulib version avoids calling malloc in the usual case,
2807 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2808 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2809 * filelock.c (current_lock_owner): Likewise.
2810 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2811 * sysdep.c: Include allocator.h, careadlinkat.h.
2812 (emacs_no_realloc_allocator): New static constant.
2813 (emacs_readlink): New function.
2814 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2815 ../lib/careadlinkat.h.
2816
2817 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2818
2819 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2820 first non-nil return value).
2821
2822 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2823
2824 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2825 if not defined (Bug#8403).
2826
2827 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2828
2829 * xdisp.c (display_count_lines): Remove parameter `start',
2830 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2831 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2832 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2833 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2834 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2835 and thereabouts. All callers changed.
2836 (get_per_char_metric): Remove parameter `f', unused since
2837 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2838
2839 2011-04-02 Jim Meyering <meyering@redhat.com>
2840
2841 do not dereference NULL upon failed strdup
2842 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2843 (ns_get_family): Likewise.
2844
2845 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2846
2847 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2848
2849 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2850
2851 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2852 later (Bug#8403).
2853
2854 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2855
2856 Add lexical binding.
2857
2858 * window.c (Ftemp_output_buffer_show): New fun.
2859 (Fsave_window_excursion):
2860 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2861
2862 * lread.c (lisp_file_lexically_bound_p): New function.
2863 (Fload): Bind Qlexical_binding.
2864 (readevalloop): Remove `evalfun' arg.
2865 Bind Qinternal_interpreter_environment.
2866 (Feval_buffer): Bind Qlexical_binding.
2867 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2868 Mark as dynamic.
2869 (syms_of_lread): Declare `lexical-binding'.
2870
2871 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2872
2873 * keyboard.c (eval_dyn): New fun.
2874 (menu_item_eval_property): Use it.
2875
2876 * image.c (parse_image_spec): Use Ffunctionp.
2877
2878 * fns.c (concat, mapcar1): Accept byte-code-functions.
2879
2880 * eval.c (Fsetq): Handle lexical vars.
2881 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2882 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2883 (FletX, Flet): Obey lexical binding.
2884 (Fcommandp): Handle closures.
2885 (Feval): New `lexical' arg.
2886 (eval_sub): New function extracted from Feval. Use it almost
2887 everywhere where Feval was used. Look up vars in lexical env.
2888 Handle closures.
2889 (Ffunctionp): Move from subr.el.
2890 (Ffuncall): Handle closures.
2891 (apply_lambda): Remove `eval_flags'.
2892 (funcall_lambda): Handle closures and new byte-code-functions.
2893 (Fspecial_variable_p): New function.
2894 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2895 but without exporting it to Lisp.
2896
2897 * doc.c (Fdocumentation, store_function_docstring):
2898 * data.c (Finteractive_form): Handle closures.
2899
2900 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2901 interactive spec.
2902
2903 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2904 New byte-codes.
2905 (exec_byte_code): New function extracted from Fbyte_code to handle new
2906 calling convention for byte-code-functions. Add new byte-codes.
2907
2908 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2909
2910 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2911
2912 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2913
2914 * xdisp.c (redisplay_internal): Fix prototype.
2915
2916 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2917
2918 * xdisp.c (SCROLL_LIMIT): New macro.
2919 (try_scrolling): Use it when setting scroll_limit.
2920 Limit scrolling to 100 screen lines.
2921 (redisplay_window): Even when falling back on "recentering",
2922 position point in the window according to scroll-conservatively,
2923 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2924
2925 (try_scrolling): When point is above the window, allow searching
2926 as far as scroll_max, or one screenful, to compute vertical
2927 distance from PT to the scroll margin position. This prevents
2928 try_scrolling from unnecessarily failing when
2929 scroll-conservatively is set to a value slightly larger than the
2930 window height. Clean up the case of PT below the margin at bottom
2931 of window: scroll_max can no longer be INT_MAX. When aggressive
2932 scrolling is in use, don't let point enter the opposite scroll
2933 margin as result of the scroll.
2934 (syms_of_xdisp) <scroll-conservatively>: Document the
2935 threshold of 100 lines for never-recentering scrolling.
2936
2937 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2938
2939 * dispextern.h (move_it_by_lines):
2940 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2941 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2942 (message_log_check_duplicate): Remove parameters `prev_bol' and
2943 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2944 (redisplay_internal): Remove parameter `preserve_echo_area',
2945 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2946
2947 * indent.c (Fvertical_motion):
2948 * window.c (window_scroll_pixel_based, Frecenter):
2949 Don't pass `need_y_p' to `move_it_by_lines'.
2950
2951 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2952
2953 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2954 steal a few bits to be more compact.
2955 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2956 Remove unneeded casts.
2957
2958 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2959
2960 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2961
2962 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2963 binding" message (bug#7967).
2964
2965 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2966
2967 Fix more problems found by GCC 4.6.0's static checks.
2968
2969 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2970 Remove unused local var.
2971
2972 * editfns.c (Fmessage_box): Remove unused local var.
2973
2974 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2975 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2976 Omit unused local vars.
2977 * window.c (shrink_windows): Omit unused local var.
2978 * menu.c (digest_single_submenu): Omit unused local var.
2979 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2980 Omit unused local var.
2981
2982 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2983 Don't assume string length fits in int.
2984 (keyremap_step, read_key_sequence): Use size_t for sizes.
2985 (read_key_sequence): Don't check last_real_key_start redundantly.
2986
2987 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2988 instead of alloca (Bug#8344).
2989
2990 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2991 (Fbacktrace_frame): Don't assume nframes fits in int.
2992
2993 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2994
2995 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2996 concerns.
2997
2998 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2999
3000 * cm.c (calccost): Turn while-do into do-while, for clarity.
3001
3002 * keyboard.c (syms_of_keyboard): Use the same style as later
3003 in this function when indexing through an array. This also
3004 works around GCC bug 48267.
3005
3006 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3007
3008 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3009
3010 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3011 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3012
3013 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3014 This avoids undefined behavior on integer overflow, and is a bit
3015 more convenient anyway since it is compared to a size_t variable.
3016
3017 Variadic C functions now count arguments with size_t, not int.
3018 This avoids an unnecessary limitation on 64-bit machines, which
3019 caused (substring ...) to crash on large vectors (Bug#8344).
3020 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3021 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3022 All variadic functions and their callers changed accordingly.
3023 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3024 * data.c (arith_driver, float_arith_driver): Likewise.
3025 * editfns.c (general_insert_function): Likewise.
3026 * eval.c (struct backtrace.nargs, interactive_p)
3027 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3028 (funcall_lambda, mark_backtrace): Likewise.
3029 * fns.c (concat): Likewise.
3030 * frame.c (x_set_frame_parameters): Likewise.
3031 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3032 0 if not found, not -1. All callers changed.
3033
3034 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3035 (stack_copy_size): Now size_t, not int.
3036 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3037
3038 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3039
3040 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3041 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3042 All callers changed.
3043
3044 * lisp.h (multibyte_char_to_unibyte):
3045 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3046 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3047 * character.h (CHAR_TO_BYTE8):
3048 * cmds.c (internal_self_insert):
3049 * editfns.c (general_insert_function):
3050 * keymap.c (push_key_description):
3051 * search.c (Freplace_match):
3052 * xdisp.c (message_dolog, set_message_1): All callers changed.
3053
3054 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3055
3056 * keyboard.c (safe_run_hook_funcall): New function.
3057 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3058 don't set the hook to nil, but remove the offending function instead.
3059 (Qcommand_hook_internal): Remove, unused.
3060 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3061 Vcommand_hook_internal.
3062
3063 * eval.c (enum run_hooks_condition): Remove.
3064 (funcall_nil, funcall_not): New functions.
3065 (run_hook_with_args): Call each function through a `funcall' argument.
3066 Remove `cond' argument, now redundant.
3067 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3068 (Frun_hook_with_args_until_failure): Adjust accordingly.
3069 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3070
3071 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3072
3073 * dispextern.h (string_buffer_position): Remove declaration.
3074
3075 * print.c (strout): Remove parameter `multibyte', unused since
3076 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3077
3078 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3079 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3080 All callers changed.
3081
3082 * w32.c (_wsa_errlist): Use braces for struct initializers.
3083
3084 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3085 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3086 All callers changed.
3087 (string_buffer_position): Likewise. Also, make static (it's never
3088 used outside xdisp.c).
3089 (cursor_row_p): Remove parameter `w', unused since
3090 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3091 (decode_mode_spec): Remove parameter `precision', introduced during
3092 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3093 All callers changed.
3094
3095 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3096
3097 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3098
3099 2011-03-27 Anders Lindgren <andlind@gmail.com>
3100
3101 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3102 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3103 (ns_update_auto_hide_menu_bar): New functions.
3104 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3105 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3106 ns_constrain_all_frames.
3107 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3108 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3109
3110 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3111
3112 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3113
3114 2011-03-27 Glenn Morris <rgm@gnu.org>
3115
3116 * syssignal.h: Replace RETSIGTYPE with void.
3117 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3118 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3119 Replace SIGTYPE with void everywhere.
3120 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3121 * s/template.h (SIGTYPE): Remove commented out definition.
3122
3123 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3124
3125 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3126 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3127
3128 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3129
3130 * w32.c (read_unc_volume): Use parameter `henum', instead of
3131 global variable `wget_enum_handle'.
3132
3133 * keymap.c (describe_vector): Remove parameters `indices' and
3134 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3135 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3136
3137 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3138
3139 * keyboard.c (timer_check): Remove parameter `do_it_now',
3140 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3141 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3142 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3143
3144 * keyboard.c (read_char):
3145 * w32menu.c (w32_menu_display_help):
3146 * xmenu.c (show_help_event, menu_help_callback):
3147 Adjust calls to `show_help_echo'.
3148
3149 * gtkutil.c (xg_maybe_add_timer):
3150 * keyboard.c (readable_events):
3151 * process.c (wait_reading_process_output):
3152 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3153
3154 * insdel.c (adjust_markers_gap_motion):
3155 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3156 (gap_left, gap_right): Don't call it.
3157
3158 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3159
3160 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3161 incurred during fontification.
3162
3163 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3164
3165 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3166 (DEFVAR_PER_BUFFER): Don't pass it.
3167
3168 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3169 (scrolling_window): Don't pass it.
3170
3171 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3172
3173 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3174
3175 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3176 and `suffix'.
3177 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3178 of variables specific to SELinux and computation of `encoded_absname'.
3179
3180 * image.c (XPutPixel): Remove unused variable `height'.
3181
3182 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3183
3184 * unexw32.c (get_section_info): Remove unused variable `section'.
3185
3186 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3187 (system_process_attributes): Remove unused variable `sess'.
3188 (sys_read): Remove unused variable `err'.
3189
3190 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3191 (w32_wnd_proc): Remove unused variable `isdead'.
3192 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3193 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3194 (x_create_tip_frame): Remove unused variable `tem'.
3195
3196 * w32inevt.c (w32_console_read_socket):
3197 Remove unused variable `no_events'.
3198
3199 * w32term.c (x_draw_composite_glyph_string_foreground):
3200 Remove unused variable `width'.
3201
3202 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3203
3204 * w32term.c (x_set_glyph_string_clipping):
3205 Don't pass uninitialized region to CombineRgn.
3206
3207 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3208
3209 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3210 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3211 (Fx_close_connection): Remove unused variable `i'.
3212
3213 * w32font.c (w32font_draw): Return number of glyphs.
3214 (w32font_open_internal): Remove unused variable `i'.
3215 (w32font_driver): Add missing initializer.
3216
3217 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3218 (fill_in_menu): Remove unused variable `items_added'.
3219
3220 * w32term.c (last_mouse_press_frame): Remove static global variable.
3221 (w32_clip_to_row): Remove unused variable `f'.
3222 (x_delete_terminal): Remove unused variable `i'.
3223
3224 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3225 (NOTHING): Remove unused static global variable.
3226 (uniscribe_check_otf): Remove unused variable `table'.
3227 (uniscribe_font_driver): Add missing initializers.
3228
3229 2011-03-23 Julien Danjou <julien@danjou.info>
3230
3231 * term.c (Fsuspend_tty, Fresume_tty):
3232 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3233 * window.c (temp_output_buffer_show):
3234 * insdel.c (signal_before_change):
3235 * frame.c (Fhandle_switch_frame):
3236 * fileio.c (Fdo_auto_save):
3237 * emacs.c (Fkill_emacs):
3238 * editfns.c (save_excursion_restore):
3239 * cmds.c (internal_self_insert):
3240 * callint.c (Fcall_interactively):
3241 * buffer.c (Fkill_all_local_variables):
3242 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3243 Use Frun_hooks.
3244 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3245 unconditionnaly since it does the check itself.
3246
3247 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3248
3249 Fix more problems found by GCC 4.5.2's static checks.
3250
3251 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3252 the first time through the loop, since we know p0 < p1 then.
3253 This also avoids a gcc -Wstrict-overflow warning.
3254
3255 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3256 leading to a memory leak, possible in functions like
3257 load_charset_map_from_file that can allocate an unbounded number
3258 of objects (Bug#8318).
3259
3260 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3261 that could (at least in theory) be that large.
3262
3263 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3264 This is less likely to overflow, and avoids undefined behavior if
3265 overflow does occur. All callers changed. Use strtoul to scan
3266 for the unsigned long integer.
3267 (pint2hrstr): Simplify and tune code slightly.
3268 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3269
3270 * scroll.c (do_scrolling): Work around GCC bug 48228.
3271 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3272
3273 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3274 This also avoids a warning with gcc -Wstrict-overflow.
3275 (validate_x_resource_name): Simplify count usage.
3276 This also avoids a warning with gcc -Wstrict-overflow.
3277
3278 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3279 fail (Bug#8306).
3280
3281 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3282
3283 * process.c (Fmake_network_process): Use socklen_t, not int,
3284 where POSIX says socklen_t is required in portable programs.
3285 This fixes a porting bug on hosts like 64-bit HP-UX, where
3286 socklen_t is wider than int (Bug#8277).
3287 (Fmake_network_process, server_accept_connection):
3288 (wait_reading_process_output, read_process_output):
3289 Likewise.
3290
3291 * process.c: Rename or move locals to avoid shadowing.
3292 (list_processes_1, Fmake_network_process):
3293 (read_process_output_error_handler, exec_sentinel_error_handler):
3294 Rename or move locals.
3295 (Fmake_network_process): Define label "retry_connect" only if needed.
3296 (Fnetwork_interface_info): Fix pointer signedness.
3297 (process_send_signal): Add cast to avoid pointer signedness problem.
3298 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3299 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3300
3301 Make tparam.h and terminfo.c consistent.
3302 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3303 Include tparam.h instead, since it declares them.
3304 * cm.h (PC): Remove extern decl; tparam.h now does this.
3305 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3306 * terminfo.c: Include tparam.h, to check interfaces.
3307 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3308 (tparam): Adjust signature to match interface in tparam.h;
3309 this removes some undefined behavior. Check that outstring and len
3310 are zero, which they always are with Emacs.
3311 * tparam.h (PC, BC, UP): New extern decls.
3312
3313 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3314 (xftfont_open): Rename locals to avoid shadowing.
3315
3316 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3317 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3318 (OTF_TAG_SYM): Omit macro if not needed.
3319 (ftfont_list): Remove unused local.
3320 (get_adstyle_property, ftfont_pattern_entity):
3321 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3322 Rename locals to avoid shadowing.
3323
3324 * xfont.c (xfont_list_family): Mark var as initialized.
3325
3326 * xml.c (make_dom): Now static.
3327
3328 * composite.c (composition_compute_stop_pos): Rename local to
3329 avoid shadowing.
3330 (composition_reseat_it): Remove unused locals.
3331 (find_automatic_composition, composition_adjust_point): Likewise.
3332 (composition_update_it): Mark var as initialized.
3333 (find_automatic_composition): Mark vars as initialized,
3334 with a FIXME (Bug#8290).
3335
3336 character.h: Rename locals to avoid shadowing.
3337 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3338 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3339 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3340 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3341 to avoid shadowing.
3342
3343 * textprop.c (property_change_between_p): Remove; unused.
3344
3345 * intervals.c (interval_start_pos): Now static.
3346
3347 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3348
3349 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3350 Rename locals to avoid shadowing.
3351
3352 * sound.c (wav_play, au_play, Fplay_sound_internal):
3353 Fix pointer signedness.
3354 (alsa_choose_format): Remove unused local var.
3355 (wav_play): Initialize a variable to 0, to prevent undefined
3356 behavior (Bug#8278).
3357
3358 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3359
3360 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3361
3362 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3363 clobbering (Bug#8298).
3364 * sysdep.c (sys_subshell): Likewise.
3365 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3366
3367 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3368 This should get cleaned up, so that child_setup has the
3369 same signature on all platforms.
3370
3371 * callproc.c (call_process_cleanup): Now static.
3372 (relocate_fd): Rename locals to avoid shadowing.
3373
3374 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3375
3376 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3377 not to be necessary, and produces flickering.
3378
3379 2011-03-20 Glenn Morris <rgm@gnu.org>
3380
3381 * config.in: Remove file.
3382
3383 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3384
3385 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3386 are now in src/globals.h.
3387 (syms_of_minibuf): Remove spurious & from previous change.
3388
3389 2011-03-20 Leo <sdl.web@gmail.com>
3390
3391 * minibuf.c (completing-read-function): New variable.
3392 (completing-read-default): Rename from completing-read.
3393 (completing-read): Call completing-read-function.
3394
3395 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3396
3397 * xfaces.c (Fx_load_color_file):
3398 Read color file from absolute filename (bug#8250).
3399
3400 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3401
3402 * makefile.w32-in: Update dependencies.
3403
3404 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3405
3406 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3407
3408 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3409
3410 Fix more problems found by GCC 4.5.2's static checks.
3411
3412 * process.c (make_serial_process_unwind, send_process_trap):
3413 (sigchld_handler): Now static.
3414
3415 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3416 That way, the code declares only the vars that it needs.
3417 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3418 * s/cygwin.h (PTY_ITERATION): Likewise.
3419 * s/darwin.h (PTY_ITERATION): Likewise.
3420 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3421
3422 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3423 * process.c (allocate_pty): Don't declare stb unless it's needed.
3424
3425 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3426 (CONSTANTLIM): Remove; unused.
3427 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3428 Define only if needed.
3429
3430 * unexelf.c (unexec): Name an expression,
3431 to avoid gcc -Wbad-function-cast warning.
3432 Use a different way to cause a compilation error if anyone uses
3433 n rather than nn, a way that does not involve shadowing.
3434 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3435
3436 * deps.mk (unexalpha.o): Remove; unused.
3437
3438 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3439 * unexec.h: New file.
3440 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3441 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3442 Depend on unexec.h.
3443 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3444 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3445 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3446 Change as necessary to match prototype in unexec.h.
3447
3448 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3449 shadowing.
3450 (back_comment, skip_chars): Mark vars as initialized.
3451
3452 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3453 Rename locals to avoid shadowing.
3454
3455 * lread.c (read1): Rewrite so as not to use empty "else".
3456 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3457
3458 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3459
3460 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3461 warning when compiling print.c.
3462
3463 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3464 instead of using an uninitialized var.
3465 (font_sort_entities): Mark var as initialized.
3466
3467 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3468
3469 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3470 pointers to constants.
3471 (font_parse_fcname): Remove unused vars.
3472 (font_delete_unmatched): Now static.
3473 (font_get_spec): Remove; unused.
3474 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3475 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3476 Rename or move locals to avoid shadowing.
3477
3478 * fns.c (require_nesting_list, require_unwind): Now static.
3479 (Ffillarray): Rename locals to avoid shadowing.
3480
3481 * floatfns.c (domain_error2): Define only if needed.
3482 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3483
3484 * alloc.c (mark_backtrace): Move decl from here ...
3485 * lisp.h: ... to here, so that it can be checked.
3486
3487 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3488 (Fdefvar): Rewrite so as not to use empty "else".
3489 (lisp_indirect_variable): Name an expression,
3490 to avoid gcc -Wbad-function-cast warning.
3491 (Fdefvar): Rename locals to avoid shadowing.
3492
3493 * callint.c (quotify_arg, quotify_args): Now static.
3494 (Fcall_interactively): Rename locals to avoid shadowing.
3495 Use const pointer when appropriate.
3496
3497 * lisp.h (get_system_name, get_operating_system_release):
3498 Move decls here, to check interfaces.
3499 * process.c (get_operating_system_release): Move decl to lisp.h.
3500 * xrdb.c (get_system_name): Likewise.
3501 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3502 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3503 some of which prompt warnings from gcc -Wbad-function-cast.
3504 (Fformat_time_string, Fencode_time, Finsert_char):
3505 (Ftranslate_region_internal, Fformat):
3506 Rename or remove local vars to avoid shadowing.
3507 (Ftranslate_region_internal): Mark var as initialized.
3508
3509 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3510 avoid shadowing.
3511
3512 * lisp.h (eassert): Check that the argument compiles, even if
3513 ENABLE_CHECKING is not defined.
3514
3515 * data.c (Findirect_variable): Name an expression, to avoid
3516 gcc -Wbad-function-cast warning.
3517 (default_value, arithcompare, arith_driver, arith_error): Now static.
3518 (store_symval_forwarding): Rename local to avoid shadowing.
3519 (Fmake_variable_buffer_local, Fmake_local_variable):
3520 Mark variables as initialized.
3521 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3522
3523 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
3524 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3525 Rename locals to avoid shadowing.
3526 (mark_stack): Move local variables into the #ifdef region where
3527 they're used.
3528 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3529 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3530 needed otherwise.
3531 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3532 (GC_STRING_CHARS): Remove; not used.
3533 (Fmemory_limit): Cast sbrk's returned value to char *.
3534
3535 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3536 avoids undefined behavior in theory.
3537
3538 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3539
3540 Use functions, not macros, for up- and down-casing (Bug#8254).
3541 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3542 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3543 to use the following functions instead of these macros.
3544 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3545 EMACS_INT, since callers assume the returned value fits in int.
3546 (upcase1): Likewise, for UPCASE_TABLE.
3547 (uppercasep, lowercasep, upcase): New static inline functions.
3548 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
3549 the race-condition problem in the old DOWNCASE.
3550
3551 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3552 Rename locals to avoid shadowing.
3553 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
3554 (regex_compile, re_search_2, re_match_2_internal):
3555 Remove unused local vars.
3556 (FREE_VAR): Rewrite so as not to use empty "else",
3557 which gcc can warn about.
3558 (regex_compile, re_match_2_internal): Mark locals as initialized.
3559 (RETALLOC_IF): Define only if needed.
3560 (WORDCHAR_P): Likewise. This one is never needed, but is used
3561 only in a comment talking about a compiler bug, so put inside
3562 the #if 0 of that comment.
3563 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3564 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3565 Remove; unused.
3566
3567 * search.c (boyer_moore): Rename locals to avoid shadowing.
3568 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3569 (PREV_CHAR_BOUNDARY): Likewise.
3570
3571 * search.c (simple_search): Remove unused var.
3572
3573 * dired.c (compile_pattern): Move decl from here ...
3574 * lisp.h: ... to here, so that it can be checked.
3575 (struct re_registers): New forward decl.
3576
3577 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3578
3579 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3580 All uses changed.
3581 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3582 Rename locals to avoid shadowing.
3583 (Fvertical_motion): Mark locals as initialized.
3584
3585 * casefiddle.c (casify_object, casify_region): Now static.
3586 (casify_region): Mark local as initialized.
3587
3588 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3589
3590 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3591 New macros, so that the caller can use some names other than
3592 gcpro1, gcpro2, etc.
3593 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3594 of the new macros.
3595 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3596 argument, for consistency with GCPRO2_VAR, etc: it is now the
3597 prefix of the variable, not the variable itself. All uses
3598 changed.
3599 * dired.c (directory_files_internal, file_name_completion):
3600 Rename locals to avoid shadowing.
3601
3602 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3603 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3604 dired.c's scmp function, had undefined behavior.
3605 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3606 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3607 * buffer.h: ... to here, because these macros use current_buffer,
3608 and the new implementation with inline functions needs to have
3609 current_buffer in scope now, rather than later when the macros
3610 are used.
3611 (downcase, upcase1): New static inline functions.
3612 (DOWNCASE, UPCASE1): Reimplement using these functions.
3613 This avoids undefined behavior in expressions like
3614 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3615 from race conditions in accessing the global variables
3616 case_temp1 and case_temp2.
3617 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3618 * lisp.h (case_temp1, case_temp2): Remove their decls.
3619 * character.h (ASCII_CHAR_P): Move from here ...
3620 * lisp.h: ... to here, so that the inline functions mentioned
3621 above can use them.
3622
3623 * dired.c (directory_files_internal_unwind): Now static.
3624
3625 * fileio.c (file_name_as_directory, directory_file_name):
3626 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3627 Now static.
3628 (file_name_as_directory): Use const pointers when appropriate.
3629 (Fexpand_file_name): Likewise. In particular, newdir might
3630 point at constant storage, so make it a const pointer.
3631 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
3632 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3633 signedness issues.
3634 (Fset_file_times, Finsert_file_contents, auto_save_error):
3635 Rename locals to avoid shadowing.
3636
3637 * minibuf.c (choose_minibuf_frame_1): Now static.
3638 (Ftry_completion, Fall_completions): Rename or remove locals
3639 to avoid shadowing.
3640
3641 * marker.c (bytepos_to_charpos): Remove; unused.
3642
3643 * lisp.h (verify_bytepos, count_markers): New decls,
3644 so that gcc does not warn that these functions aren't declared.
3645
3646 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3647 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
3648 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
3649 (copy_text): Remove unused local var.
3650
3651 * filelock.c (within_one_second): Now static.
3652 (lock_file_1): Rename local to avoid shadowing.
3653
3654 * buffer.c (fix_overlays_before): Mark locals as initialized.
3655 (fix_start_end_in_overlays): Likewise. This function should be
3656 simplified by using pointers-to-pointers, but that's a different
3657 matter.
3658 (switch_to_buffer_1): Now static.
3659 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3660 (report_overlay_modification): Rename locals to avoid shadowing.
3661
3662 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
3663 Fix pointer signedness issue.
3664 (sys_subshell): Mark local as volatile if checking for lint,
3665 to suppress a gcc -Wclobbered warning that does not seem to be right.
3666 (MAXPATHLEN): Define only if needed.
3667
3668 * process.c (serial_open, serial_configure): Move decls from here ...
3669 * systty.h: ... to here, so that they can be checked.
3670
3671 * fns.c (get_random, seed_random): Move extern decls from here ...
3672 * lisp.h: ... to here, so that they can be checked.
3673
3674 * sysdep.c (reset_io): Now static.
3675 (wait_for_termination_signal): Remove; unused.
3676
3677 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3678 (copy_keymap_item, append_key, push_text_char_description):
3679 Now static.
3680 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
3681 (DENSE_TABLE_SIZE): Remove; unused.
3682 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3683 (describe_map_tree):
3684 Rename locals to avoid shadowing.
3685
3686 * keyboard.c: Declare functions static if they are not used elsewhere.
3687 (echo_char, echo_dash, cmd_error, top_level_2):
3688 (poll_for_input, handle_async_input): Now static.
3689 (read_char, kbd_buffer_get_event, make_lispy_position):
3690 (make_lispy_event, make_lispy_movement, apply_modifiers):
3691 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3692 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3693 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
3694 (read_key_sequence, read_char): Mark locals as initialized.
3695 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
3696
3697 * keyboard.h (make_ctrl_char): New decl.
3698 (mark_kboards): Move decl here ...
3699 * alloc.c (mark_kboards): ... from here.
3700
3701 * lisp.h (force_auto_save_soon): New decl.
3702
3703 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3704 (DEFINE_DUMMY_FUNCTION): New macro.
3705 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3706 Use it.
3707 (main): Add casts to avoid warnings
3708 if GCC considers string literals to be constants.
3709
3710 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3711
3712 * dbusbind.c: Pointer signedness fixes.
3713 (xd_signature, xd_append_arg, xd_initialize):
3714 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3715 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3716 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3717 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3718
3719 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3720 if GCC considers string literals to be constants.
3721 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3722
3723 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3724
3725 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3726 (print_preprocess, print_object): New macro to fix last change.
3727
3728 * print.c (print_preprocess): Don't forget font objects.
3729
3730 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
3731
3732 * emacs.c (USAGE3): Doc fixes.
3733
3734 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3735
3736 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3737 structure.
3738
3739 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3740
3741 * lisp.h (VWindow_system, Qfile_name_history):
3742 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3743 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3744 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3745
3746 * w32select.c: Don't #include "keyboard.h".
3747 (run_protected): Add extern declaration for waiting_for_input.
3748
3749 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3750 * w32console.c (detect_input_pending, read_input_pending)
3751 (encode_terminal_code):
3752 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3753 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3754 (w32_system_caret_y, Qfile_name_history):
3755 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3756 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3757 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3758 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3759 * w32proc.c (Qlocal, report_file_error):
3760 * w32term.c (Vwindow_system, updating_frame):
3761 * w32uniscribe.c (initialized, uniscribe_font_driver):
3762 Remove unneeded extern declarations.
3763
3764 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3765
3766 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3767
3768 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3769
3770 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3771 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3772 These macros can no longer be used for assignment.
3773
3774 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3775 Assign struct members directly, instead of using BUF_BEGV etc.
3776 (record_buffer_markers, fetch_buffer_markers): New functions for
3777 recording and fetching special buffer markers.
3778 (set_buffer_internal_1, set_buffer_temp): Use them.
3779
3780 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3781
3782 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3783
3784 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3785 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3786
3787 * xdisp.c (hscroll_window_tree):
3788 (reconsider_clip_changes): Use PT instead of BUF_PT.
3789
3790 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3791
3792 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3793 $(EMACS_ROOT)/lib/intprops.h.
3794
3795 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3796
3797 Fix more problems found by GCC 4.5.2's static checks.
3798
3799 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3800 to unsigned char * to avoid compiler diagnostic.
3801 (xg_free_frame_widgets): Make it clear that a local variable is
3802 needed only if USE_GTK_TOOLTIP.
3803 (gdk_window_get_screen): Make it clear that this macro is needed
3804 only if USE_GTK_TOOLTIP.
3805 (int_gtk_range_get_value): New function, which avoids a diagnostic
3806 from gcc -Wbad-function-cast.
3807 (xg_set_toolkit_scroll_bar_thumb): Use it.
3808 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3809 diagnostic from gcc -Wbad-function-cast.
3810 (get_utf8_string, xg_get_file_with_chooser):
3811 Rename locals to avoid shadowing.
3812 (create_dialog): Move locals to avoid shadowing.
3813
3814 * xgselect.c (xg_select): Remove unused var.
3815
3816 * image.c (four_corners_best): Mark locals as initialized.
3817 (gif_load): Initialize transparent_p to zero (Bug#8238).
3818 Mark another local as initialized.
3819 (my_png_error, my_error_exit): Mark with NO_RETURN.
3820
3821 * image.c (clear_image_cache): Now static.
3822 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3823 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3824 (x_edge_detection): Remove unnecessary cast that
3825 gcc -Wbad-function-cast diagnoses.
3826 (gif_load): Fix pointer signedness.
3827 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3828 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3829
3830 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3831
3832 Improve quality of tests for time stamp overflow.
3833 For example, without this patch (encode-time 0 0 0 1 1
3834 1152921504606846976) returns the obviously-bogus value (-948597
3835 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3836 reports time overflow. See
3837 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3838 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3839 * editfns.c: Include limits.h and intprops.h.
3840 (TIME_T_MIN, TIME_T_MAX): New macros.
3841 (time_overflow): Move earlier, to before first use.
3842 (hi_time, lo_time): New functions, for an accurate test for
3843 out-of-range times.
3844 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3845 (Fget_internal_run_time): Don't assume time_t fits in int.
3846 (make_time): Use list2 instead of Fcons twice.
3847 (Fdecode_time): More accurate test for out-of-range times.
3848 (check_tm_member): New function.
3849 (Fencode_time): Use it, to test for out-of-range times.
3850 (lisp_time_argument): Don't rely on undefined left-shift and
3851 right-shift behavior when checking for time stamp overflow.
3852
3853 * editfns.c (time_overflow): New function, refactoring common code.
3854 (Fformat_time_string, Fdecode_time, Fencode_time):
3855 (Fcurrent_time_string): Use it.
3856
3857 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3858 * dired.c (make_time): Move to ...
3859 * editfns.c (make_time): ... here.
3860 * systime.h: Note the move.
3861
3862 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3863
3864 * fringe.c (update_window_fringes): Remove unused variables.
3865
3866 * unexmacosx.c (copy_data_segment): Also copy __got section.
3867 (Bug#8223)
3868
3869 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3870
3871 * termcap.c [MSDOS]: Include "msdos.h".
3872 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3873 Constify `char *' arguments and their references according to
3874 prototypes in tparam.h.
3875
3876 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3877
3878 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3879 Adapt all references accordingly.
3880
3881 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3882
3883 2011-03-11 Tom Tromey <tromey@redhat.com>
3884
3885 * buffer.c (syms_of_buffer): Remove obsolete comment.
3886
3887 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3888
3889 * termhooks.h (encode_terminal_code): Declare prototype.
3890
3891 * msdos.c (encode_terminal_code): Don't declare prototype.
3892
3893 * term.c (encode_terminal_code): Now external again, used by
3894 w32console.c and msdos.c.
3895
3896 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3897 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3898
3899 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3900
3901 Fix some minor problems found by GCC 4.5.2's static checks.
3902
3903 * fringe.c (update_window_fringes): Mark locals as initialized
3904 (Bug#8227).
3905 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3906
3907 * alloc.c (mark_fringe_data): Move decl from here ...
3908 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3909 to check its interface.
3910 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3911
3912 * fontset.c (free_realized_fontset): Now static.
3913 (Fset_fontset_font): Rename local to avoid shadowing.
3914 (fontset_font): Mark local as initialized.
3915 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3916
3917 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3918
3919 * xselect.c (x_disown_buffer_selections): Remove; not used.
3920 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3921 (x_own_selection, Fx_disown_selection_internal): Rename locals
3922 to avoid shadowing.
3923 (x_handle_dnd_message): Remove local to avoid shadowing.
3924
3925 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3926 so that the caller can use some name other than gcpro1.
3927 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3928 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3929 (Fx_backspace_delete_keys_p):
3930 Use them to avoid shadowing, and rename vars to avoid shadowing.
3931 (x_decode_color, x_set_name, x_window): Now static.
3932 (Fx_create_frame): Add braces to silence GCC warning.
3933 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3934 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3935 Remove unused locals.
3936 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3937 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3938 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3939 macros.
3940
3941 * xterm.h (x_mouse_leave): New decl.
3942
3943 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3944 Remove unused functions.
3945 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3946 (x_calc_absolute_position): Now static.
3947 (XTread_socket): Don't define label "out" unless it's used.
3948 Don't declare local "event" unless it's used.
3949 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3950 unless they are used.
3951 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3952 (x_fatal_error_signal): Remove; not used.
3953 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3954 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3955 (x_error_catcher, x_connection_closed, x_error_handler):
3956 (x_error_quitter, xembed_send_message, x_iconify_frame):
3957 (my_log_handler): Rename locals to avoid shadowing.
3958 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3959 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3960
3961 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3962 Rename or move locals to avoid shadowing.
3963 (tty_defined_color, merge_face_heights): Now static.
3964 (free_realized_faces_for_fontset): Remove; not used.
3965 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3966 does not deduce is never used uninitialized.
3967 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3968 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3969
3970 * terminal.c (store_terminal_param): Now static.
3971
3972 * xmenu.c (menu_highlight_callback): Now static.
3973 (set_frame_menubar): Remove unused local.
3974 (xmenu_show): Rename parameter to avoid shadowing.
3975 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3976 since they might point to immutable storage.
3977 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3978 since it's unused otherwise.
3979
3980 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3981 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3982 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3983 avoids a gcc -Wuninitialized diagnostic.
3984 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3985 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3986 does not deduce are never used uninitialized.
3987
3988 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3989
3990 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3991 * window.c (window_loop, size_window):
3992 (run_window_configuration_change_hook, enlarge_window): Likewise.
3993
3994 * window.c (display_buffer): Now static.
3995 (size_window): Mark variables that gcc -Wuninitialized
3996 does not deduce are never used uninitialized.
3997 * window.h (check_all_windows): New decl, to forestall
3998 gcc -Wmissing-prototypes diagnostic.
3999 * dispextern.h (bidi_dump_cached_states): Likewise.
4000
4001 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4002 shadowing.
4003 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4004 Include <limits.h>.
4005 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4006 and to avoid gcc -Wuninitialized warning.
4007 (load_charset_map): Mark variables that gcc -Wuninitialized
4008 does not deduce are never used uninitialized.
4009 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4010
4011 * coding.c (coding_set_source, coding_set_destination):
4012 Use "else { /* comment */ }" rather than "else /* comment */;"
4013 for clarity, and to avoid gcc -Wempty-body warning.
4014 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4015 a block, when the outer 'i' will do.
4016 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4017 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4018 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4019 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4020 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4021 Rename locals to avoid shadowing.
4022 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4023 * coding.c (emacs_mule_char, encode_invocation_designation):
4024 Now static, since they're not used elsewhere.
4025 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4026 (decode_coding_object, encode_coding_object, detect_coding_system):
4027 (decode_coding_emacs_mule): Mark variables that gcc
4028 -Wuninitialized does not deduce are never used uninitialized.
4029 (detect_coding_iso_2022): Initialize a local variable that might
4030 be used uninitialized. Leave a FIXME because it's not clear that
4031 this initialization is needed. (Bug#8211)
4032 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4033 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4034 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4035 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4036 Remove unused macros.
4037
4038 * category.c (hash_get_category_set): Remove unused local var.
4039 (copy_category_table): Now static, since it's not used elsewhere.
4040 * character.c (string_count_byte8): Likewise.
4041
4042 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4043 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4044
4045 * chartab.c (copy_sub_char_table): Now static, since it's not used
4046 elsewhere.
4047 (sub_char_table_ref_and_range, char_table_ref_and_range):
4048 Rename locals to avoid shadowing.
4049 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4050
4051 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4052 (BIDI_BOB): Remove unused macro.
4053
4054 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4055 deduce are never used uninitialized.
4056 * term.c (encode_terminal_code): Likewise.
4057
4058 * term.c (encode_terminal_code): Now static. Remove unused local.
4059
4060 * tparam.h: New file.
4061 * term.c, tparam.h: Include it.
4062 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4063 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4064 Move these decls to tparam.h, and make them agree with what
4065 is actually in tparam.c. The previous trick of using incompatible
4066 decls in different modules does not conform to the C standard.
4067 All callers of tparam changed to use tparam's actual API.
4068 * tparam.c (tparam1, tparam, tgoto):
4069 Use const pointers where appropriate.
4070
4071 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4072 * cm.h (struct cm): Likewise.
4073 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4074 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4075 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4076 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4077 (turn_on_face, init_tty): Likewise.
4078 * termchar.h (struct tty_display_info): Likewise.
4079
4080 * term.c (term_mouse_position): Rename local to avoid shadowing.
4081
4082 * alloc.c (mark_ttys): Move decl from here ...
4083 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4084
4085 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4086
4087 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4088
4089 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4090
4091 * search.c (compile_pattern_1): Remove argument regp, unused since
4092 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4093 (compile_pattern): Don't pass it.
4094
4095 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4096
4097 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4098 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4099 for ! HAVE_GTK3.
4100 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4101
4102 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4103
4104 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4105 gdk_window_get_screen, gdk_window_get_geometry,
4106 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4107 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4108 (xg_get_pixbuf_from_pixmap): New function.
4109 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4110 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4111 Call xg_get_pixbuf_from_pixmap instead of
4112 gdk_pixbuf_get_from_drawable.
4113 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4114 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4115 (xg_check_special_colors): Use GtkStyleContext and its functions
4116 for HAVE_GTK3.
4117 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4118 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4119 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4120 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4121 Call gtk_widget_get_preferred_size.
4122 (xg_frame_resized): gdk_window_get_geometry only takes 5
4123 parameters.
4124 (xg_win_to_widget, xg_event_is_for_menubar):
4125 Call gdk_x11_window_lookup_for_display.
4126 (xg_set_widget_bg): New function.
4127 (delete_cb): New function.
4128 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4129 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4130 (xg_set_background_color): Call xg_set_widget_bg.
4131 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4132 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4133 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4134 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4135 if ! HAVE_GTK3.
4136 (update_frame_tool_bar): Call gtk_widget_hide.
4137 (xg_initialize): Use GDK_KEY_g.
4138
4139 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4140 if ! HAVE_GTK3
4141 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4142
4143 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4144 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4145 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4146
4147 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4148
4149 * w32xfns.c (select_palette): Check success of RealizePalette against
4150 GDI_ERROR, not zero.
4151
4152 See ChangeLog.11 for earlier changes.
4153
4154 ;; Local Variables:
4155 ;; coding: utf-8
4156 ;; End:
4157
4158 Copyright (C) 2011 Free Software Foundation, Inc.
4159
4160 This file is part of GNU Emacs.
4161
4162 GNU Emacs is free software: you can redistribute it and/or modify
4163 it under the terms of the GNU General Public License as published by
4164 the Free Software Foundation, either version 3 of the License, or
4165 (at your option) any later version.
4166
4167 GNU Emacs is distributed in the hope that it will be useful,
4168 but WITHOUT ANY WARRANTY; without even the implied warranty of
4169 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4170 GNU General Public License for more details.
4171
4172 You should have received a copy of the GNU General Public License
4173 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.