1 2013-07-19 Paul Eggert <eggert@cs.ucla.edu>
3 Fix some minor file descriptor leaks and related glitches.
4 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
5 (create_lock_file): Use write, not emacs_write.
6 * image.c (slurp_file, png_load_body):
7 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
8 (server_accept_connection):
9 Don't leak an fd on memory allocation failure.
10 * image.c (slurp_file): Add a cheap heuristic for growing files.
11 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
12 as that's what the other routines do. Maybe input need not be
13 blocked at all, but it's better to be consistent.
14 Avoid undefined behavior when strlen is zero.
16 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
17 (NSTATICS): Now a constant; doesn't need to be a macro.
19 2013-07-19 Richard Stallman <rms@gnu.org>
21 * coding.c (decode_coding_utf_8): Add simple loop for fast
22 processing of ASCII characters.
24 2013-07-19 Paul Eggert <eggert@cs.ucla.edu>
26 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
28 2013-07-19 Eli Zaretskii <eliz@gnu.org>
30 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
31 unportable 'struct x_display_info'.
32 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
35 2013-07-19 Paul Eggert <eggert@cs.ucla.edu>
37 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
38 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
40 (system_process_attributes): Prefer plain char to unsigned char
41 when either will do. Clean up properly if interrupted or if
42 memory allocations fail. Don't assume sscanf succeeds. Remove
43 no-longer-needed workaround to stop GCC from whining. Read
44 command-line once, instead of multiple times. Check read status a
47 Fix obscure porting bug with varargs functions.
48 The code assumed that int is treated like ptrdiff_t in a vararg
49 function, which is not a portable assumption. There was a similar
50 -- though these days less likely -- porting problem with various
51 assumptions that pointers of different types all smell the same as
52 far as vararg functions is conserved. To make this problem less
53 likely in the future, redo the API to use varargs functions.
54 * alloc.c (make_save_value): Remove this vararg function.
55 All uses changed to ...
56 (make_save_int_int_int, make_save_obj_obj_obj_obj)
57 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
59 (make_save_ptr): Rename from make_save_pointer, for consistency with
60 the above. Define only on platforms that need it. All uses changed.
62 2013-07-18 Paul Eggert <eggert@cs.ucla.edu>
64 * keyboard.c: Try to fix typos in previous change.
65 (DISPLAY_LIST_INFO): New macro.
66 (kbd_buffer_get_event): Do not access members that are not present
67 in X11. Revert inadvertent change of "!=" to "=".
69 2013-07-18 Juanma Barranquero <lekktu@gmail.com>
71 * keyboard.c (kbd_buffer_get_event):
72 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
73 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
75 2013-07-18 Paul Eggert <eggert@cs.ucla.edu>
77 * filelock.c: Fix unlikely file descriptor leaks.
78 (get_boot_time_1): Rework to avoid using emacs_open.
79 This doesn't actually fix a leak, but is better anyway.
80 (read_lock_data): Use read, not emacs_read.
82 * doc.c: Fix minor memory and file descriptor leaks.
83 * doc.c (get_doc_string): Fix memory leak when doc file absent.
84 (get_doc_string, Fsnarf_documentation):
85 Fix file descriptor leak on error.
87 * term.c: Fix minor fdopen-related file descriptor leaks.
88 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
89 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
91 * charset.c: Fix file descriptor leaks and errno issues.
93 (load_charset_map_from_file): Don't leak file descriptor on error.
94 Use plain record_xmalloc since the allocation is larger than
95 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
97 * eval.c (record_unwind_protect_nothing):
98 * fileio.c (fclose_unwind):
100 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
101 The replacement doesn't block input, but that no longer seems
104 2013-07-17 Paul Eggert <eggert@cs.ucla.edu>
106 * lread.c: Fix file descriptor leaks and errno issues.
107 (Fload): Close some races that leaked fds or streams when 'load'
109 (Fload, openp): Report error number of last nontrivial failure to open.
110 ENOENT counts as trivial.
111 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
113 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
114 now that the function is always called with a nonnegative arg.
115 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
116 All uses replaced with ...
117 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
119 A few more minor file errno-reporting bugs.
120 * callproc.c (Fcall_process):
121 * doc.c (Fsnarf_documentation):
122 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
123 * process.c (set_socket_option):
124 Don't let a constructor trash errno.
125 * doc.c: Include <errno.h>.
127 2013-07-16 Juanma Barranquero <lekktu@gmail.com>
129 * w32fns.c (unwind_create_tip_frame): Fix declaration.
131 2013-07-16 Paul Eggert <eggert@cs.ucla.edu>
133 Fix w32 bug with call-process-region (Bug#14885).
134 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
135 to Fcall_process when the input is empty. This simplifies the
136 code a bit. It makes no difference on POSIXish platforms but
137 apparently it fixes a bug on w32.
139 Fix bug where insert-file-contents closes a file twice. (Bug#14839).
140 * fileio.c (close_file_unwind): Don't close if FD is negative;
141 this can happen when unwinding a zapped file descriptor.
142 (Finsert_file_contents): Unwind-protect the fd before the point marker,
143 in case Emacs runs out of memory between the two unwind-protects.
144 Don't trash errno when closing FD.
145 Zap the FD in the specpdl when closing it, instead of deferring
146 the removal of the unwind-protect; this fixes a bug where a child
147 function unwinds the stack past us.
149 New unwind-protect flavors to better type-check C callbacks.
150 This also lessens the need to write wrappers for callbacks,
151 and the need for make_save_pointer.
152 * alloca.c (free_save_value):
153 * atimer.c (run_all_atimers):
155 * alloc.c (safe_alloca_unwind):
156 * atimer.c (unwind_stop_other_atimers):
157 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
158 * menu.c (cleanup_popup_menu) [HAVE_NS]:
159 * minibuf.c (choose_minibuf_frame_1):
160 * process.c (make_serial_process_unwind):
161 * xdisp.h (pop_message_unwind):
162 * xselect.c (queue_selection_requests_unwind):
163 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
164 * alloca.c (record_xmalloc):
165 Prefer record_unwind_protect_ptr to record_unwind_protect with
167 * alloca.c (Fgarbage_collect):
168 Prefer record_unwind_protect_void to passing a dummy.
169 * buffer.c (restore_buffer):
170 * window.c (restore_window_configuration):
171 * xfns.c, w32fns.c (do_unwind_create_frame)
172 New wrapper. All record-unwind uses of wrappee changed.
173 * buffer.c (set_buffer_if_live):
174 * callproc.c (call_process_cleanup, delete_temp_file):
175 * coding.c (code_conversion_restore):
176 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
177 * editfns.c (save_excursion_restore)
178 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
179 (save_restriction_restore):
180 * eval.c (restore_stack_limits, un_autoload):
181 * fns.c (require_unwind):
182 * keyboard.c (recursive_edit_unwind, tracking_off):
183 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
184 * macros.c (pop_kbd_macro, restore_menu_items):
185 * nsfns.m (unwind_create_frame):
186 * print.c (print_unwind):
187 * process.c (start_process_unwind):
188 * search.c (unwind_set_match_data):
189 * window.c (select_window_norecord, select_frame_norecord):
190 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
191 (fast_set_selected_frame):
192 * xfns.c, w32fns.c (unwind_create_tip_frame):
193 Return void, not a dummy Lisp_Object. All uses changed.
194 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
195 * callproc.c (call_process_kill):
196 * fileio.c (restore_point_unwind, decide_coding_unwind)
197 (build_annotations_unwind):
198 * insdel.c (Fcombine_after_change_execute_1):
199 * keyboard.c (read_char_help_form_unwind):
200 * menu.c (unuse_menu_items):
201 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
202 * sound.c (sound_cleanup):
203 * xdisp.c (unwind_redisplay):
204 * xfns.c (clean_up_dialog):
205 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
206 Accept no args and return void, instead of accepting and returning
207 a dummy Lisp_Object. All uses changed.
208 * cygw32.c (fchdir_unwind):
209 * fileio.c (close_file_unwind):
210 * keyboard.c (restore_kboard_configuration):
211 * lread.c (readevalllop_1):
212 * process.c (wait_reading_process_output_unwind):
213 Accept int and return void, rather than accepting an Emacs integer
214 and returning a dummy object. In some cases this fixes an
215 unlikely bug when the corresponding int is outside Emacs integer
216 range. All uses changed.
217 * dired.c (directory_files_internal_unwind):
218 * fileio.c (do_auto_save_unwind):
219 * gtkutil.c (pop_down_dialog):
220 * insdel.c (reset_var_on_error):
221 * lread.c (load_unwind):
222 * xfns.c (clean_up_file_dialog):
223 * xmenu.c, nsmenu.m (pop_down_menu):
224 * xmenu.c (cleanup_widget_value_tree):
225 * xselect.c (wait_for_property_change_unwind):
226 Accept pointer and return void, rather than accepting an Emacs
227 save value encapsulating the pointer and returning a dummy object.
229 * editfns.c (Fformat): Update the saved pointer directly via
230 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
231 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
232 (unwind_body): New function.
233 (record_unwind_protect): First arg is now a function returning void,
234 not a dummy Lisp_Object.
235 (record_unwind_protect_ptr, record_unwind_protect_int)
236 (record_unwind_protect_void): New functions.
237 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
238 * fileio.c (struct auto_save_unwind): New type.
239 (do_auto_save_unwind): Use it.
240 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
241 * insdel.c (struct rvoe_arg): New type.
242 (reset_var_on_error): Use it.
243 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
245 (specbinding_func): Remove; there are now several such functions.
246 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
247 (set_unwind_protect_ptr): New function.
248 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
250 Be simpler and more consistent about reporting I/O errors.
251 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
252 Say "Read error" and "Write error", rather than "I/O error", or
253 "IO error reading", or "IO error writing", when a read or write
255 * process.c (Fmake_network_process, wait_reading_process_output)
256 (send_process, Fprocess_send_eof, wait_reading_process_output):
257 Capitalize diagnostics consistently. Put "failed foo" at the
258 start of the diagnostic, so that we don't capitalize the
259 function name "foo". Consistently say "failed" for such
261 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
262 All callers changed. This is so it can use report_file_error.
263 * sysdep.c (serial_open, serial_configure): Capitalize I/O
264 diagnostics consistently as above.
266 * fileio.c (report_file_errno): Fix errno reporting bug.
267 If the file name is neither null nor a pair, package it up as a
268 singleton list. All callers changed, both to this function and to
269 report_file_error. This fixes a bug where the memory allocator
270 invoked by list1 set errno so that the immediately following
271 report_file_error reported the wrong errno value.
273 Fix minor problems found by --enable-gcc-warnings.
274 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
275 * keyboard.c (kbd_buffer_get_event): Remove unused local.
277 2013-07-16 Jan Djärv <jan.h.d@swipnet.se>
279 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
280 Set event->arg to Qt if switch-event shall be generated.
281 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
283 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
285 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
288 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
289 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
290 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
291 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
292 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
293 and there is a focused frame.
294 (head_table): Add focus-in and focus-out.
295 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
296 bind to handle-focus-in/out.
298 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
299 (Fhandle_switch_frame): Call Fhandle_focus_in.
300 (syms_of_frame): defsubr handle-focus-in/out.
302 2013-07-16 Paul Eggert <eggert@cs.ucla.edu>
304 Fix porting bug to older POSIXish platforms (Bug#14862).
305 * sysdep.c (emacs_pipe): New function, that implements
306 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
307 This should port better to CentOS 5 and to Mac OS X 10.6.
308 All calls to pipe2 changed.
310 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
311 This makes the code easier to read and the executable a bit smaller.
312 Do not replace all calls to Fcons that happen to create lists,
313 just calls that are intended to create lists. For example, when
314 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
315 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
316 Similarly for list2 through list5.
317 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
318 * bytecode.c (exec_byte_code):
319 * callint.c (quotify_arg, Fcall_interactively):
320 * callproc.c (Fcall_process, create_temp_file):
321 * charset.c (load_charset_map_from_file)
322 (Fdefine_charset_internal, init_charset):
323 * coding.c (get_translation_table, detect_coding_system)
324 (Fcheck_coding_systems_region)
325 (Fset_terminal_coding_system_internal)
326 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
327 * composite.c (update_compositions, Ffind_composition_internal):
328 * dired.c (directory_files_internal, file_name_completion)
330 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
331 * doc.c (Fsnarf_documentation):
332 * editfns.c (Fmessage_box):
334 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
335 (Feval, eval_sub, Ffuncall, apply_lambda):
336 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
337 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
338 (Fset_file_times, Finsert_file_contents)
339 (Fchoose_write_coding_system, Fwrite_region):
340 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
341 * font.c (font_registry_charsets, font_parse_fcname)
342 (font_prepare_cache, font_update_drivers, Flist_fonts):
343 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
344 * frame.c (make_frame, Fmake_terminal_frame)
345 (x_set_frame_parameters, x_report_frame_params)
346 (x_default_parameter, Fx_parse_geometry):
347 * ftfont.c (syms_of_ftfont):
348 * image.c (gif_load):
349 * keyboard.c (command_loop_1):
350 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
351 (Fcopy_keymap, append_key, Fcurrent_active_maps)
352 (Fminor_mode_key_binding, accessible_keymaps_1)
353 (Faccessible_keymaps, Fwhere_is_internal):
354 * lread.c (read_emacs_mule_char):
355 * menu.c (find_and_return_menu_selection):
356 * minibuf.c (get_minibuffer):
357 * nsfns.m (Fns_perform_service):
358 * nsfont.m (ns_script_to_charset):
359 * nsmenu.m (ns_popup_dialog):
360 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
361 (Fx_own_selection_internal):
362 * nsterm.m (append2):
363 * print.c (Fredirect_debugging_output)
364 (print_prune_string_charset):
365 * process.c (Fdelete_process, Fprocess_contact)
366 (Fformat_network_address, set_socket_option)
367 (read_and_dispose_of_process_output, write_queue_push)
368 (send_process, exec_sentinel):
369 * sound.c (Fplay_sound_internal):
370 * textprop.c (validate_plist, add_properties)
371 (Fput_text_property, Fadd_face_text_property)
372 (copy_text_properties, text_property_list, syms_of_textprop):
373 * unexaix.c (report_error):
374 * unexcoff.c (report_error):
375 * unexsol.c (unexec):
376 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
377 (Fformat_mode_line, syms_of_xdisp):
378 * xfaces.c (set_font_frame_param)
379 (Finternal_lisp_face_attribute_values)
380 (Finternal_merge_in_global_face, syms_of_xfaces):
381 * xfns.c (x_default_scroll_bar_color_parameter)
382 (x_default_font_parameter, x_create_tip_frame):
383 * xfont.c (xfont_supported_scripts):
384 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
385 (menu_help_callback, xmenu_show):
387 * xterm.c (set_wm_state):
388 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
389 and similarly for list2 through list5.
391 2013-07-15 Paul Eggert <eggert@cs.ucla.edu>
393 * callproc.c (Fcall_process_region): Fix minor race and tune.
394 (create_temp_file): New function, with the temp-file-creation part
395 of the old Fcall_process_region. Use Fcopy_sequence to create the
396 temp file name, rather than alloca + build_string, for simplicity.
397 Don't bother to block input around the temp file creation;
398 shouldn't be needed. Simplify use of mktemp. Use
399 record_unwind_protect immediately after creating the temp file;
400 this closes an unlikely race where the temp file was not removed.
401 Use memcpy rather than an open-coded loop.
402 (Fcall_process_region): Use the new function. If the input is
403 empty, redirect from /dev/null rather than from a newly created
404 empty temp file; this avoids unnecessary file system traffic.
406 2013-07-14 Paul Eggert <eggert@cs.ucla.edu>
408 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
409 Simplify by making this case like the other two. This is a bit
410 slower on obsolete hosts, but the extra complexity isn't worth it.
412 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
413 * process.c (create_process) [!DOS_NT]:
414 Remove now-unnecessary calls to emacs_close.
416 2013-07-13 Eli Zaretskii <eliz@gnu.org>
418 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
419 returning early. (Bug#14850)
421 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
422 and inhibit-iso-escape-detection attributes of 'undecided'.
425 2013-07-13 Paul Eggert <eggert@cs.ucla.edu>
427 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
428 Reported by Herbert J. Skuhra in
429 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
431 Don't lose top specpdl entry when memory is exhausted.
432 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
433 specpdl overflow here, to simplify callers; all callers changed.
434 Always reserve an unused entry at the stack top; this avoids
435 losing the top entry's information when memory is exhausted.
437 2013-07-12 Paul Eggert <eggert@cs.ucla.edu>
439 Clean up errno reporting and fix some errno-reporting bugs.
440 * callproc.c (Fcall_process):
441 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
442 * process.c (create_process, Fmake_network_process):
443 * unexaix.c (report_error):
444 * unexcoff.c (report_error):
445 Be more careful about reporting the errno of failed operations.
446 The code previously reported the wrong errno sometimes.
447 Also, prefer report_file_errno to setting errno + report_file_error.
448 (Fcall_process): Look at openp return value rather than at path,
449 as that's a bit faster and clearer when there's a numeric predicate.
450 * fileio.c (report_file_errno): New function, with most of the
451 old contents of report_file_error.
452 (report_file_error): Use it.
453 (Ffile_exists_p, Ffile_accessible_directory_p):
454 Set errno to 0 when it is junk.
455 * fileio.c (Faccess_file):
456 * image.c (x_create_bitmap_from_file):
457 Use faccessat rather than opening the file, to avoid the hassle of
458 having a file descriptor open.
459 * lisp.h (report_file_errno): New decl.
460 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
463 * process.c (create_process, wait_reading_process_output) [AIX]:
464 Remove obsolete SIGHUP-related code, as Emacs no longer disables
465 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
466 a multithreaded environment anyway).
467 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
469 2013-07-12 Andreas Schwab <schwab@linux-m68k.org>
471 * image.c (x_find_image_file): Don't close a remote file handle.
473 2013-07-12 Paul Eggert <eggert@cs.ucla.edu>
475 Fix races with threads and file descriptors.
476 * callproc.c (Fcall_process_region):
477 * dired.c (open_directory):
478 * emacs.c (main, Fdaemon_initialized):
479 * image.c (x_find_image_file):
480 * inotify.c (Finotify_rm_watch):
481 * lread.c (Flocate_file_internal):
482 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
483 * term.c (term_mouse_moveto, init_tty):
484 * termcap.c (tgetent):
485 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
486 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
487 * unexhp9k800.c, unexmacosx.c (unexec):
488 * callproc.c (Fcall_process_region):
489 Use emacs_close, not close.
490 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
491 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
492 and posix_close function on current platforms (which all lack them).
493 (emacs_close): Use it. This should fix the races on GNU/Linux and
494 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
495 and it should avoid closing random victim file descriptors on
498 2013-07-11 Paul Eggert <eggert@cs.ucla.edu>
500 * inotify.c (uninitialized): Remove. All uses replaced by -1.
501 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
504 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
505 This is for .gdbinit xbacktrace.
507 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
508 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
509 (emacs_set_tty): Now static.
510 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
511 * term.c (tty_capable_p, tty_default_color_capabilities)
512 (get_tty_terminal, term_mouse_movement)
513 (handle_one_term_event, init_tty, maybe_fatal):
514 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
515 (tgetent, scan_file, name_match, compare_contin):
516 * terminal.c (get_terminal):
517 Use bool for boolean.
518 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
519 Prefer char to unsigned char if either will do.
520 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
521 (tty_write_glyphs): Prefer int to unsigned.
522 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
524 * termcap.c (tprint, main) [TEST]: Remove non-working test.
526 2013-07-10 Paul Eggert <eggert@cs.ucla.edu>
529 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
530 (B__dummy__): New dummy symbol, to pacify C89.
531 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
532 they can't grok varargs macros.
533 * dispnew.c (add_window_display_history)
534 (add_frame_display_history):
535 * print.c (print_object):
536 * xdisp.c (debug_method_add):
537 Use %p printf format only for void pointers.
538 * emacs.c (usage_message): New constant, replacing ...
539 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
540 (main): Adjust to usage reorg.
541 * fns.c (syms_of_fns):
542 * profiler.c (syms_of_profiler):
543 Don't use non-constant struct initializers.
544 * gnutls.h (gnutls_initstage_t):
545 * lisp.h (enum Lisp_Fwd_Type):
546 * lread.c (lisp_file_lexically_bound_p):
547 * xsettings.c (anonymous enum):
548 Remove trailing comma.
549 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
550 * lisp.h (ENUM_BF): Use unsigned if pedantic.
551 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
553 * regex.c (const_re_char): New type, to pacify strict C89.
554 All uses of 'const re_char' replaced to use it.
555 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
556 with glibc when strict C89. This change is imported from gnulib.
558 (_Restrict_arr_): Rename from __restrict_arr, similarly.
559 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
560 Omit GNU_LINUX implementation, since it requires long long.
561 * xterm.c (x_draw_underwave):
562 Do not assume the traditional order of struct's members.
563 (x_term_init): Rewrite to avoid the need for non-constant structure
566 Syntax cleanup, mostly replacing macros with functions.
567 ` This removes the need for the syntax_temp hack.
568 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
569 * syntax.c (SYNTAX_INLINE): New macro.
570 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
571 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
572 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
573 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
574 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
575 (SYNTAX_COMEND_FIRST): Now functions, not macros.
576 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
577 Now constants, not macros.
578 (syntax_temp) [!__GNUC__]: Remove.
579 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
580 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
581 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
582 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
583 Move here from syntax.h; now functions, not macros. Except for the
584 last function, these are static since only syntax.c uses them.
585 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
586 All uses changed. Now a function, not a macro; use this fact
587 to simplify the code.
588 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
589 compiler bugs; no longer relevant.
590 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
591 (SYNTAX_INLINE): New macro.
592 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
593 for the new functions. Use bool for boolean member.
594 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
595 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
596 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
597 (SETUP_BUFFER_SYNTAX_TABLE):
598 Now extern inline functions, not macros.
599 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
600 Remove; all uses replaced by implementation.
601 (syntax_temp) [!__GNUC__]: Remove decl.
602 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
604 2013-07-10 Jan Djärv <jan.h.d@swipnet.se>
606 * emacs.c (main): Fix syntax error.
608 2013-07-10 Paul Eggert <eggert@cs.ucla.edu>
610 Timestamp fixes for undo (Bug#14824).
611 * atimer.c (schedule_atimer):
612 * fileio.c (Ffile_newer_than_file_p):
613 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
614 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
615 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
616 (syms_of_fileio): Remove Sclear_visited_file_name.
617 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
618 file doesn't exist; this avoids an ambiguity with negative timestamps.
619 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
620 * systime.h (make_emacs_time, invalid_emacs_time):
621 Don't assume struct timespec layout; POSIX doesn't guarantee it.
622 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
623 * undo.c (record_first_change): Push (visited-file-modtime) onto
624 undo list rather than reimplementing it by hand, incorrectly.
626 2013-07-09 Ken Brown <kbrown@cornell.edu>
628 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
630 2013-07-09 Juanma Barranquero <lekktu@gmail.com>
632 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
634 2013-07-09 Paul Eggert <eggert@cs.ucla.edu>
636 Handle errno and exit status a bit more carefully.
637 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
638 number into an exit status. Instead, use EXIT_CANCELED.
639 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
640 * callproc.c (relocate_fd):
641 * emacs.c (close_output_streams, main):
642 * process.c (create_process):
643 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
644 Use emacs_perror for simplicity.
645 * callproc.c (relocate_fd, main):
646 * sysdep.c (sys_subshell):
647 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
648 (shut_down_emacs): Use emacs_write, not write.
649 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
650 * fileio.c (Fcopy_file, e_write):
651 * nsterm.m (ns_select):
652 * process.c (send_process):
653 * sound.c (vox_write):
654 Use emacs_write_sig, not emacs_write.
655 * lisp.h (emacs_write_sig, emacs_perror): New decls.
656 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
658 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
660 (emacs_full_write): New function.
661 (emacs_write): Rewrite to use it.
662 (emacswrite_sig, emacs_perror): New functions.
663 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
665 2013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change).
667 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
668 on NS even if it is present. Pixmap on NS is a void*.
670 2013-07-07 Paul Eggert <eggert@cs.ucla.edu>
672 Port to Ubuntu 10 (Bug#14803).
673 Problem reported by T.V. Raman.
674 * process.c (close_on_exec, accept4, process_socket):
675 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
677 2013-07-07 Eli Zaretskii <eliz@gnu.org>
679 * w32.c (sys_dup): Declare prototype.
683 * callproc.c [WINDOWSNT]: Include sys/socket.h.
685 2013-07-07 Paul Eggert <eggert@cs.ucla.edu>
687 Make file descriptors close-on-exec when possible (Bug#14803).
688 This simplifies Emacs a bit, since it no longer needs to worry
689 about closing file descriptors by hand in some cases.
690 It also fixes some unlikely races. Not all such races, as
691 libraries often open files internally without setting
692 close-on-exec, but it's an improvement.
693 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
694 * callproc.c (Fcall_process) [!MSDOS]:
695 * emacs.c (main) [!DOS_NT]:
696 * nsterm.m (ns_term_init):
697 * process.c (create_process):
698 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
699 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
700 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
701 Prefer mkostemp with O_CLOEXEC to mkstemp.
702 * callproc.c (relocate_fd) [!WINDOWSNT]:
703 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
704 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
706 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
707 Make the resulting file descriptor close-on-exec.
708 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
709 * lread.c (load_descriptor_list, load_descriptor_unwind):
710 Remove; no longer needed. All uses removed.
711 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
712 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
714 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
715 (Fmake_network_process, Fnetwork_interface_list):
716 (Fnetwork_interface_info, server_accept_connection):
717 Make newly-created socket close-on-exec.
718 * sysdep.c (emacs_open, emacs_fopen):
719 Make new-created descriptor close-on-exec.
720 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
721 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
723 2013-07-07 Jan Djärv <jan.h.d@swipnet.se>
725 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
728 2013-07-07 Paul Eggert <eggert@cs.ucla.edu>
730 Fix openp errno handling.
731 * callproc.c (Fcall_process): Preserve openp errno around close.
732 * lread.c (openp): Set errno when returning -1, as some callers
735 2013-07-06 Jan Djärv <jan.h.d@swipnet.se>
737 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
739 * nsterm.h (NSSavePanel): Update comment.
740 (NSAPP_DATA2_RUNFILEDIALOG): Define.
741 (ns_run_file_dialog): Declare.
743 * nsfns.m: Remove panelOK.
745 (ns_run_file_dialog): New function.
746 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
747 event loop, so file dialog is popped up by ns_run_file_dialog, called
748 by sendEvent (Bug#14578).
749 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
751 2013-07-06 Eli Zaretskii <eliz@gnu.org>
753 * xdisp.c (default_line_pixel_height): New function.
754 (pos_visible_p, move_it_vertically_backward, try_scrolling)
755 (try_cursor_movement, redisplay_window, try_window)
756 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
758 * window.c (window_scroll_pixel_based): use
759 default_line_pixel_height.
761 * dispextern.h (default_line_pixel_height): Add prototype.
763 * frame.c (x_set_line_spacing): Accept a float value for
764 line-spacing parameter, per the documentation.
766 * data.c (Fmultibyte_string_p): Doc fix.
768 2013-07-05 Paul Eggert <eggert@cs.ucla.edu>
770 Use emacs_open more consistently when opening files.
771 This handles EINTR more consistently now, and makes it easier
772 to introduce other uniform changes to file descriptor handling.
773 * src/systdio.h: New file.
774 * src/buffer.c (mmap_init):
775 * cygw32.c (chdir_to_default_directory):
776 * dispnew.c (Fopen_termscript):
777 * emacs.c (Fdaemon_initialized):
778 * fileio.c (Fdo_auto_save):
779 * image.c (slurp_file, png_load_body, jpeg_load_body):
780 * keyboard.c (Fopen_dribble_file):
782 * print.c (Fredirect_debugging_output):
783 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
784 * termcap.c (tgetent):
785 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
786 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
787 * w32term.c (w32_initialize) [CYGWIN]:
788 * xfaces.c (Fx_load_color_file):
789 Use emacs_open instead of plain open, and emacs_fopen instead of
791 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
792 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
793 * callproc.c (default_output_mode): New constant.
794 (Fcall_process): Use it to call emacs_open instead of plain creat.
795 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
796 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
797 (emacs_fopen): New function.
798 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
799 Include <lisp.h>, for emacs_open.
800 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
802 Remove duplicate #include directives.
803 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
805 Don't include stdio.h twice.
806 * buffer.c [USE_MMAP_FOR_BUFFERS]:
807 Don't include sys/types.h or stdio.h twice.
808 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
809 * lread.c: Don't include coding.h twice.
810 * nsfont.m: Don't include frame.h twice.
811 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
812 * ralloc.c: Don't include <unistd.h> twice.
813 * xdisp.c: Don't include font.h twice.
814 * xterm.c: Don't include fontset.h twice.
815 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
817 2013-07-04 Paul Eggert <eggert@cs.ucla.edu>
819 Scale ImageMagick images more carefully.
820 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
821 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
822 Be more careful about avoiding undefined behavior after
823 integer overflow and division by zero.
825 2013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
827 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
828 (syms_of_w32fns): DEFSYM them.
829 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
830 (CCHDEVICENAME): Define macros if not defined.
831 (struct MONITOR_INFO_EX): New struct.
832 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
833 (enum_display_monitors_fn): New variable.
834 (globals_of_w32fns): Initialize it.
835 (Fx_display_pixel_width, Fx_display_pixel_height)
836 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
837 multi-monitor setups in docstrings.
838 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
839 screen size by primary monitor's millimeter per pixel.
840 (w32_monitor_enum, w32_display_monitor_attributes_list)
841 (w32_display_monitor_attributes_list_fallback)
842 (Fw32_display_monitor_attributes_list): New functions.
843 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
845 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
847 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
849 2013-07-04 Michael Albinus <michael.albinus@gmx.de>
851 * fileio.c (Qfile_notify_error): New error symbol.
853 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
854 * inotify.c (inotify_callback, symbol_to_inotifymask)
855 (Finotify_add_watch, Finotify_rm_watch): Use it.
856 (inotifyevent_to_event): Exchange order of cookie and file name.
857 (Finotify_add_watch): Adapt docstring.
859 * lisp.h (Qfile_notify_error): Declare.
861 2013-07-04 Paul Eggert <eggert@cs.ucla.edu>
863 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
864 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
865 Do not clear _malloc_thread_enabled_p, undoing the previous change,
866 which did not work (see <http://bugs.gnu.org/14569#307>).
867 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
868 && (!noninteractive || initialized)). This attempts to thread
869 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
871 2013-07-04 Juanma Barranquero <lekktu@gmail.com>
873 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
874 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
876 2013-07-04 Paul Eggert <eggert@cs.ucla.edu>
878 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
879 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
880 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
881 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
883 2013-07-02 Paul Eggert <eggert@cs.ucla.edu>
885 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
886 Define to __sys_siglist.
888 2013-07-02 Eli Zaretskii <eliz@gnu.org>
890 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
891 word-wrap, so that overflow-newline-into-fringe would work in
892 visual-line-mode. (Bug#2749)
893 (move_it_in_display_line_to): When the last scanned display
894 element fits exactly on the display line, and
895 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
896 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
897 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
898 finding buffer position that corresponds to pixel coordinates,
899 e.g. in buffer_posn_from_coords.
901 2013-07-02 Jan Djärv <jan.h.d@swipnet.se>
903 * process.c (handle_child_signal): Call catch_child_signal if
906 2013-07-02 Paul Eggert <eggert@cs.ucla.edu>
908 Don't convert function pointers to void * and back.
909 It isn't portable C, and it's easy enough to avoid.
910 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
911 (make_save_value): Add support for SAVE_FUNCPOINTER.
912 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
913 * print.c (print_object):
914 Distinguish function from object pointers.
915 * lisp.h (SAVE_FUNCPOINTER): New constant.
916 (SAVE_SLOT_BITS): Adjust to it.
917 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
918 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
919 (voidfuncptr): New typedef.
920 (struct Lisp_Save_Value): New member data[0].funcpointer.
921 (XSAVE_FUNCPOINTER): New function.
923 Simplify buildobj processing.
924 * Makefile.in (buildobj.h): Make it a sequence of strings each
925 followed by comma, rather than a single string. Put it into a
926 .tmp file in case there's an error while generating it.
927 (gl-stamp): Use .tmp for temp files.
928 (mostlyclean): Clean .tmp files.
929 * doc.c (buildobj): Move to just the routine that needs it.
930 It's now an array of strings, so processing is simpler.
932 2013-07-01 Paul Eggert <eggert@cs.ucla.edu>
934 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
935 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
936 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
937 Invoke malloc_enable_thread even when not interactive.
938 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
939 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
940 in this case, since the underlying bug has now been fixed.
942 2013-07-01 Juanma Barranquero <lekktu@gmail.com>
944 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
945 unlinking it (bug#14691).
947 2013-06-30 Michal Nazarewicz <mina86@mina86.com>
949 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
950 before checking whether buffer is modified. This lets
951 `kill-buffer-query-functions' cancel killing of the buffer or save
952 its content before `kill-buffer' asks user the "Buffer %s
953 modified; kill anyway?" question.
955 2013-06-30 Jan Djärv <jan.h.d@swipnet.se>
957 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
958 Let the super performKeyEquivalent deal with them (Bug#14747).
960 2013-06-30 Paul Eggert <eggert@cs.ucla.edu>
962 * widget.c (resize_cb): Remove unused local.
964 Do not use GTK 3 if it exists but cannot be compiled.
965 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
966 * xterm.c (x_error_handler) [!USE_GTK]:
969 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
971 2013-06-30 Eli Zaretskii <eliz@gnu.org>
973 * intervals.c (get_local_map): Instead of aborting, clip POSITION
974 to the valid range of values. (Bug#14753)
976 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
977 when moving point by using the current glyph matrix. This avoids
978 the need to force redisplay when this function is called in a
981 2013-06-29 Paul Eggert <eggert@cs.ucla.edu>
983 Fix minor problems found by static checking.
984 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
985 Redo the latter's body to sidestep GCC parenthesization warnings.
986 (setup_coding_system, detect_coding, detect_coding_system): Use them.
987 * coding.c (detect_coding, detect_coding_system):
988 * coding.h (struct undecided_spec):
989 Use bool for boolean.
990 * image.c (QCmax_width, QCmax_height): Now static.
991 * xdisp.c (Fmove_point_visually): Remove unused local.
993 2013-06-29 Eli Zaretskii <eliz@gnu.org>
995 * xdisp.c (Fmove_point_visually): New function.
997 2013-06-28 Kenichi Handa <handa@gnu.org>
999 * coding.h (define_coding_undecided_arg_index): New enum.
1000 (coding_attr_index): New members
1001 coding_attr_undecided_inhibit_null_byte_detection,
1002 coding_attr_undecided_inhibit_iso_escape_detection,
1003 coding_attr_undecided_prefer_utf_8.
1004 (undecided_spec): New struct.
1005 (struct coding_system): New member `undecided' of the member
1008 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
1009 (detect_coding): Likewise.
1010 (detect_coding_system): Likewise.
1011 (Fdefine_coding_system_internal): New coding system properties
1012 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
1014 (syms_of_coding): Adjust for coding_arg_undecided_max.
1016 2013-06-28 Paul Eggert <eggert@cs.ucla.edu>
1018 * image.c (x_from_xcolors): Remove unused local.
1020 2013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1022 Defer image data transfer between X client and server until actual
1025 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
1028 * image.c (Destroy_Image): Remove.
1029 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
1030 `mask_p', and `colors_p'. All uses changed.
1031 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
1032 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
1033 New macros for `flags' arg to x_clear_image_1.
1034 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
1035 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
1036 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
1037 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
1038 (image_get_x_image, image_unget_x_image): New functions or macros.
1039 (image_background, image_background_transparent, x_to_xcolors)
1040 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
1041 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
1042 instead of Destroy_Image.
1043 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
1044 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
1045 (png_load_body, jpeg_load_body, tiff_load, gif_load)
1046 (imagemagick_load_image, svg_load_image): Use them instead of
1047 x_create_x_image_and_pixmap, and x_put_x_image followed by
1048 x_destroy_x_image, respectively.
1049 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
1050 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
1051 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
1052 background_transparent fields.
1053 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
1054 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
1056 2013-06-27 Paul Eggert <eggert@cs.ucla.edu>
1058 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
1059 This mostly consists of undoing recent changes.
1060 * callproc.c (Fcall_process):
1061 * process.c (create_process):
1062 Do not worry about catching SIGCHLD here, undoing previous change.
1063 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
1064 * process.c, process.h (catch_child_signal):
1065 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
1066 * process.c (catch_child_handler): Don't worry about being called
1067 lazily and do not assume caller has blocked SIGCHLD, undoing
1068 previous change. Move first-time stuff back to
1069 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
1070 tickle glib, as that causes Cygwin bootstrap to fail. Do not
1071 set lib_child_handler if it's already initialized, which may
1072 help avoid problems on GNUStep.
1074 2013-06-23 Paul Eggert <eggert@cs.ucla.edu>
1076 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
1077 * callproc.c (Fcall_process):
1078 * process.c (create_process):
1079 Make sure SIGCHLD is caught before we fork,
1080 since Emacs startup no arranges to catch SIGCHLD.
1081 * process.c (lib_child_handler): Initialize to null, not to
1083 (catch_child_signal): Allow self to be called lazily.
1084 Do nothing if it's already been called.
1085 Assume caller has blocked SIGCHLD (all callers do now).
1086 * emacs.c (main): Do not catch SIGCHLD here; defer it until
1087 just before it's really needed.
1088 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
1089 since it hasn't been caught yet.
1091 2013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
1093 * image.c (compute_image_size): New function to implement
1094 :max-width and :max-height.
1095 (imagemagick_load_image): Use it.
1097 2013-06-23 Paul Eggert <eggert@cs.ucla.edu>
1099 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
1100 * callproc.c, process.h (block_child_signal, unblock_child_signal):
1102 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
1103 * process.c (catch_child_signal): Block SIGCHLD while futzing with
1104 the SIGCHLD handler, since the code is not atomic and (due to glib)
1105 signals may be arriving now.
1106 * sysdep.c (init_signals): Do not catch child signals here;
1107 'main' now does that later, at a safer time.
1109 2013-06-22 Paul Eggert <eggert@cs.ucla.edu>
1111 Clean up SIGCHLD handling a bit (Bug#14569).
1112 * process.c, process.h (catch_child_signal):
1113 Now always extern, even if !NS_IMPL_GNUSTEP.
1114 * process.c (catch_child_signal): Move glib tickler here from
1115 init_process_emacs, so that it's done earlier in Emacs
1116 initialization. Also move the noninteractive && !initialized
1117 check here from init_process_emacs. This is all a bit cleaner for
1118 GNUish platforms, and I hope it works around the Cygwin bug.
1119 * sysdep.c (init_signals): Invoke catch_child_signal here, so
1120 that glib signal handling is tickled before glib creates threads.
1122 * process.c (wait_reading_process_output): Avoid int overflow
1123 when reading more than 2 GiB total from a process.
1125 2013-06-21 Paul Eggert <eggert@cs.ucla.edu>
1127 * process.c (create_process): Handle a couple more cases,
1128 i.e., work even if new_argv and wait_child_setup[i] are cached.
1129 Use Fcall_process's style for volatile vars.
1131 2013-06-21 Andreas Schwab <schwab@linux-m68k.org>
1133 * process.c (create_process): Mark PROCESS volatile.
1135 2013-06-21 Paul Eggert <eggert@cs.ucla.edu>
1137 Use C99-style flexible array members if available.
1138 This avoids some subtle aliasing issues, which typically
1139 aren't a problem with GCC but may be a problem elsewhere.
1140 * alloc.c (sdata): New typedef, replacing the old struct sdata.
1141 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
1142 In either case, it uses a flexible array member rather than
1143 the old struct hack. All uses changed.
1144 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
1145 Adjust to sdata reorganization.
1146 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
1147 Use offsetof (struct, flex_array_member), not sizeof (struct), as
1148 that ports better to pre-C99 non-GCC.
1149 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
1150 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
1151 as the latter has changed.
1152 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
1153 and port better to pre-C99 GCC.
1154 * image.c (struct xpm_cached_color):
1155 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
1156 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
1157 Use FLEXIBLE_ARRAY_MEMBER.
1158 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
1159 Move decl to top level so it gets checked against implementation.
1160 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
1161 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
1163 2013-06-20 Paul Eggert <eggert@cs.ucla.edu>
1165 * syntax.c: Integer cleanups.
1166 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
1167 All uses that need 0-or-2 changed to:
1168 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
1169 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
1170 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
1171 (char_quoted, prev_char_comend_first, back_comment)
1172 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
1173 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
1174 Use bool for boolean.
1175 (update_syntax_table, skip_chars, skip_syntaxes):
1176 Prefer int to unsigned when either will do.
1177 (back_comment): Return boolean success flag, like forw_comment,
1178 instead of positive-or-minus-1 (which might have overflowed int anyway).
1179 Don't stuff ptrdiff_t into int.
1180 (syntax_spec_code, syntax_code_spec): Now const.
1181 (Fmatching_paren, scan_lists, scan_sexps_forward):
1182 Use enum syntaxcode for syntax code.
1183 (Fmatching_paren): Check that arg is a character, not just an integer.
1184 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
1185 (Finternal_describe_syntax_value): Omit no-longer-needed
1187 (skip_chars): Use char, not unsigned char, when the distinction
1189 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
1190 * bytecode.c (exec_byte_code):
1191 * syntax.c (syntax_spec_code, Fchar_syntax)
1192 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
1194 * syntax.h (SYNTAX_WITH_FLAGS):
1195 Omit unnecessary casts.
1197 2013-06-20 Eli Zaretskii <eliz@gnu.org>
1199 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
1200 line dimensions here, to avoid race conditions with the main
1201 thread. (Bug#14062, bug#14630, bug#14669)
1203 * w32term.c (w32_draw_window_cursor): Compute the header line and
1204 mode line dimensions here.
1205 <w32_system_caret_window, w32_system_caret_hdr_height>:
1206 <w32_system_caret_mode_height>: New variables.
1208 * w32term.h: Declare them.
1210 2013-06-20 Paul Eggert <eggert@cs.ucla.edu>
1212 * alloc.c (die): Move "assertion failed" string here ...
1213 * lisp.h (eassert): ... from here. Also, suppress evaluation of
1214 COND when SUPPRESS_CHECKING. This shrinks the executable text
1215 size by 0.8% to 2.2% when configured with --enable-checking,
1216 depending on optimization flags (GCC 4.8.1 x86-64).
1218 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
1220 2013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
1222 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
1223 base is 2; this is more accurate.
1225 2013-06-19 Juanma Barranquero <lekktu@gmail.com>
1227 * sound.c (string_default): Move to !WINDOWSNT section.
1228 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
1230 2013-06-19 Paul Eggert <eggert@cs.ucla.edu>
1232 * sound.c: Integer cleanups.
1233 Remove unnecessary forward decls.
1234 (struct sound_device): The 'file' member is now a Lisp_Object, not
1235 a char *, so that we needn't invoke alloca on a huge size.
1236 (Fplay_sound_internal): Adjust to this.
1237 (string_default): New function.
1238 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
1239 Use it to adjust to the struct sound_device change.
1240 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
1241 (be2hs) [0]: Remove.
1243 * syntax.c (skip_chars): Don't use uninitialized storage
1244 when searching a multibyte buffer for characters that are not in a
1245 unibyte string that contains non-ASCII characters.
1247 2013-06-18 Jan Djärv <jan.h.d@swipnet.se>
1249 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
1250 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
1252 2013-06-18 Paul Eggert <eggert@cs.ucla.edu>
1254 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
1256 2013-06-18 Kenichi Handa <handa@gnu.org>
1258 * font.c (Ffont_spec): Signal an error for an invalid font name
1261 2013-06-18 Paul Eggert <eggert@cs.ucla.edu>
1263 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
1264 In particular this ports to 32-bit sparc Sun cc.
1265 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
1266 array with a dummy element at specpdl[-1], so that its address can
1268 (unbind_to): Do not copy the binding; not needed, now that we
1269 copy old_value in the one place where the copy is needed.
1270 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
1271 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
1272 (union specbinding): Rename from struct specbinding. Redo layout
1273 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
1274 which is not portable. With Sun C 5.12 32-bit sparc, the
1275 declaration causes nargs to be an unsigned bitfield, a behavior
1276 that the C standard allows; but Emacs wants nargs to be signed.
1277 The overall type is now a union of structures rather than a
1278 structure of union of structures, and the 'kind' member is now a
1279 bitfield, so that the overall type doesn't grow. All uses changed.
1280 * process.c (Fmake_serial_process): Remove unnecessary initialization.
1282 2013-06-17 Paul Eggert <eggert@cs.ucla.edu>
1284 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
1285 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
1287 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
1289 2013-06-17 Eli Zaretskii <eliz@gnu.org>
1291 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
1292 unless we know that the window w's frame is a frame object.
1293 Another attempt at solving bug#14062 and bug#14630.
1295 2013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
1297 * textprop.c (property_set_type): New enum.
1298 (add_properties): Allow appending/prepending text properties.
1299 (add_text_properties_1): Factored out of Fadd_text_properties.
1300 (Fadd_text_properties): Move all the code into
1301 add_text_properties_1.
1302 (Fadd_face_text_property): New function that calls
1303 add_text_properties_1.
1305 2013-06-17 Paul Eggert <eggert@cs.ucla.edu>
1307 Move functions from lisp.h to individual modules when possible.
1308 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
1309 * alloc.c (XFLOAT_INIT, set_symbol_name):
1310 * buffer.c (CHECK_OVERLAY):
1311 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
1312 (set_char_table_parent):
1313 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
1314 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
1315 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
1316 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
1318 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
1319 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
1320 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
1321 (backtrace_args, backtrace_debug_on_exit):
1322 * floatfns.c (CHECK_FLOAT):
1323 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
1324 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
1325 (set_hash_hash, set_hash_hash_slot, set_hash_index)
1326 (set_hash_index_slot):
1327 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
1328 * marker.c (CHECK_MARKER):
1329 * textprop.c (CHECK_STRING_OR_BUFFER):
1330 * window.c (CHECK_WINDOW_CONFIGURATION):
1331 Move here from lisp.h, and make these functions static rather than
1333 * buffer.c (Qoverlayp):
1335 * fns.c (Qhash_table_p):
1336 * window.c (Qwindow_configuration_p):
1338 * lisp.h: Remove the abovementioned defns and decls.
1340 Use functions, not macros, for XINT etc. (Bug#11935).
1341 In lisp.h, prefer functions to function-like macros, and
1342 constants to object-like macros, when either will do. This:
1343 . simplifies use, as there's no more need to worry about
1344 arguments' side effects being evaluated multiple times.
1345 . makes the code easier to debug on some platforms.
1346 However, when using gcc -O0, keep using function-like macros
1347 for a few critical operations, for performance reasons.
1348 This sort of thing isn't needed with gcc -Og, but -Og
1349 is a GCC 4.8 feature and isn't widely-enough available yet.
1350 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
1351 Remove enum lsb_bits; no longer needed.
1352 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
1353 * buffer.c (Qoverlap):
1355 * fns.c (Qhash_table_p):
1356 Now extern, so lisp.h can use these symbols.
1357 * dispextern.h: Include character.h, for MAX_CHAR etc.
1358 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
1359 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
1360 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
1361 (GLYPH_CODE_P): Move here from lisp.h.
1362 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
1363 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
1364 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
1365 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
1366 XUNTAG now returns void *.
1367 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
1368 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
1369 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
1370 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
1371 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
1372 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
1373 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
1374 (lisp_h_XPNTR, lisp_h_XSYMBOL):
1375 New macros, renamed from their sans-lisp_h_ counterparts.
1376 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
1377 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
1378 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
1379 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
1380 If compiling via GCC without optimization, define these as macros
1381 in addition to inline functions.
1382 To disable this, compile with -DINLINING=0.
1383 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
1384 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
1385 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
1386 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
1387 (INTMASK, VALMASK): Now macros, since static values cannot be
1388 accessed from extern inline functions.
1389 (VALMASK): Also a constant, for benefit of old GDB.
1390 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
1391 is INTEGERP, which can fold it in.
1392 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
1393 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
1394 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
1395 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
1396 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
1397 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
1398 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
1399 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
1400 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
1401 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
1402 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
1403 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
1404 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
1405 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
1406 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
1407 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
1408 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
1409 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
1410 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
1411 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
1412 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
1413 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
1414 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
1415 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
1416 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
1417 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
1418 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
1419 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
1420 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
1421 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
1422 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
1423 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
1424 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
1426 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
1427 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
1428 (VALMASK): Define in one place rather than in two, merging the
1429 USE_LSB_TAG parts; this is simpler.
1430 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
1431 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
1432 Move up, to avoid use before definition.
1433 Also include "globals.h" earlier, for the same reason.
1434 (make_natnum): New function.
1435 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
1436 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
1437 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
1438 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
1439 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
1440 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
1441 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
1442 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
1443 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
1444 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
1445 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
1446 (Qwindow_configuration_p, Qimage): New forward declarations.
1447 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
1448 (STRING_COPYIN): Remove; unused.
1449 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
1450 (xcar_addr, xcdr_addr): New functions. All uses changed.
1451 (IEEE_FLOATING_POINT): Now a constant, not a macro.
1452 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
1453 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
1454 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
1455 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
1456 (TYPE_RANGED_INTEGERP): Simplify.
1457 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
1458 (setlocale, fixup_locale, synchronize_system_messages_locale)
1459 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
1460 Now empty functions, not macros.
1461 (functionp): Return bool, not int.
1462 * window.c (Qwindow_configuration_p): Now extern,
1463 so window.h can use it.
1464 * window.h (Qwindowp): Move decl back to lisp.h.
1466 2013-06-15 Eli Zaretskii <eliz@gnu.org>
1468 * xdisp.c (Fline_pixel_height): New function, required for solving
1471 2013-06-15 Paul Eggert <eggert@cs.ucla.edu>
1473 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
1475 2013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
1477 * lread.c (syms_of_lread):
1478 * fns.c (Fprovide): Adjust to new format of after-load-alist.
1480 2013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
1482 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
1484 2013-06-12 Xue Fuqiao <xfq.free@gmail.com>
1486 * fileio.c (expand_file_name): Doc fix.
1488 2013-06-11 Paul Eggert <eggert@cs.ucla.edu>
1490 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
1491 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
1492 Wait for self, not for 0. This can't hurt on GNU or similar
1493 system, and may help with Cygwin.
1495 * keyboard.c: Don't use PROP (...) as an lvalue.
1496 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
1497 Use set_prop (A, B), not PROP (A) = B.
1499 2013-06-10 Eli Zaretskii <eliz@gnu.org>
1501 * xdisp.c (get_it_property): Use it->window instead of generating
1502 a Lisp object from it->w.
1504 2013-06-09 Eli Zaretskii <eliz@gnu.org>
1506 * xdisp.c (get_it_property): If it->object is a buffer, pass to
1507 get-char-property the window that is being rendered, instead of
1508 the buffer, to support window-specific overlays. (Bug#14575)
1509 (compute_display_string_pos): When W is NULL, use the current
1510 buffer as the object to pass to get-char-property.
1511 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
1512 pointer member of the bidi iterator, since no window is pertinent
1515 2013-06-08 Eli Zaretskii <eliz@gnu.org>
1517 * bidi.c (bidi_fetch_char): Accept additional argument, the window
1518 being displayed, and pass it to compute_display_string_pos.
1519 (bidi_level_of_next_char, bidi_resolve_explicit_1)
1520 (bidi_paragraph_init): All callers changed.
1522 * xdisp.c (init_from_display_pos, init_iterator)
1523 (handle_single_display_spec, next_overlay_string)
1524 (get_overlay_strings_1, reseat_1, reseat_to_string)
1525 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
1526 Set bidi_it.w member from it->w.
1527 (compute_display_string_pos): Accept additional argument, the
1528 window being displayed, and pass it to Fget_char_property.
1531 * dispextern.h (struct bidi_it): New member w, the window being
1533 (compute_display_string_pos): Adjust prototype.
1535 2013-06-08 Jan Djärv <jan.h.d@swipnet.se>
1537 * xgselect.c: Remove unneeded include xterm.h.
1539 * process.c (wait_reading_process_output): Check for NS before GLIB.
1540 GLIB may be linked in due to rsvg, but ns_select must be called.
1542 * xgselect.c (xg_select): Remove call to window_system_available
1543 and g_main_context_pending at the top, so Gdk events (i.e. file
1544 notify) are processed when Emacs is started with -nw.
1546 2013-06-07 Eli Zaretskii <eliz@gnu.org>
1548 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
1549 (ctagsfiles3): New variable, includes only *.m files.
1550 (TAGS): Use an explicit language name in the regular expressions,
1551 to avoid transformation of '/SOMETHING' by MSYS to
1552 'c:\MSYS\SOMETHING'.
1554 2013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
1556 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
1558 2013-06-06 Eli Zaretskii <eliz@gnu.org>
1560 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
1561 still need to set the mouse pointer shape and activate help-echo.
1564 2013-06-06 Paul Eggert <eggert@cs.ucla.edu>
1566 A few porting etc. fixes for the new file monitor code.
1567 See the thread containing
1568 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
1569 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
1570 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
1571 (dir_monitor_callback, Fgfile_rm_watch):
1572 Use assq_no_quit instead of Fassoc, for speed.
1573 (dir_monitor_callback, Fgfile_rm_watch):
1574 eassert that the monitor is a fixnum.
1575 (dir_monitor_callback): No need for CDR_SAFE.
1576 Simplify building of lisp with alternative tails.
1577 (Fgfile_add_watch, Fgfile_rm_watch):
1578 Do not assume glib functions set errno reliably on failure.
1579 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
1580 and signal an error otherwise.
1581 (Fgfile_rm_watch): Prefer CONSP to !NILP.
1582 Use Fdelq instead of Fdelete, for speed.
1584 2013-06-05 Eli Zaretskii <eliz@gnu.org>
1586 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
1587 don't insist on being invoked on a highlighted tool-bar button.
1588 Avoids losing tool-bar functionality when mouse-highlight is nil.
1589 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
1590 Don't highlight when mouse-highlight is nil.
1591 (note_mouse_highlight): When mouse-highlight is nil, don't return
1592 right away; instead, run tool-bar and mode-line highlight
1593 subroutine, clear any existing highlight, and revert the mouse
1594 pointer to its default shape. (Bug#14558)
1596 2013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
1598 * lisp.mk (lisp): Add prog-mode.el.
1600 2013-06-05 Paul Eggert <eggert@cs.ucla.edu>
1602 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
1603 * process.c (dummy_handler): New function.
1604 (lib_child_handler): New static var.
1605 (handle_child_signal): Invoke it.
1606 (catch_child_signal): If a library has set up a signal handler,
1607 save it into lib_child_handler.
1608 (init_process_emacs): If using glib and not on Windows, tickle glib's
1609 child-handling code so that it initializes its private SIGCHLD handler.
1610 * syssignal.h (SA_SIGINFO): Default to 0.
1611 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
1612 31; it should no longer be needed now.
1614 2013-06-05 Michael Albinus <michael.albinus@gmx.de>
1616 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
1618 * gfilenotify.c (globals_of_gfilenotify): New function.
1619 (syms_of_gfilenotify): Move global initialization there.
1621 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
1623 2013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
1625 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
1626 * keyboard.c (menu_bar_items, tool_bar_items):
1627 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
1628 not override local keymaps any more.
1630 2013-06-04 Eli Zaretskii <eliz@gnu.org>
1632 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
1634 2013-06-03 Eli Zaretskii <eliz@gnu.org>
1636 * w32console.c (initialize_w32_display): Return the dimensions of
1637 the console window via 2 additional arguments, not via the current
1638 frame. This avoids crashes due to overrunning the bounds of
1639 frame's decode_mode_spec_buffer, which is not resized following
1640 the change of the frame dimensions from the initial 10x10.
1642 * w32term.h (w32_initialize_display_info): Adjust prototype.
1644 * term.c (init_tty): Take dimensions of the frame from the values
1645 returned by initialize_w32_display.
1647 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
1648 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
1649 (LIBES): Add $(GFILENOTIFY_LIBS).
1651 * w32inevt.c (handle_file_notifications): Add dummy implementation
1652 for !HAVE_W32NOTIFY.
1654 * w32term.c: Wrap code with HAVE_W32NOTIFY.
1656 2013-06-03 Jan Djärv <jan.h.d@swipnet.se>
1658 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
1660 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
1662 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
1664 2013-06-03 Paul Eggert <eggert@cs.ucla.edu>
1666 Fix minor problems found by static checking.
1667 * data.c (pure_write_error):
1668 Use xsignal2, not Fsignal, as Fsignal might return.
1669 * eval.c (set_backtrace_debug_on_exit): Now static.
1670 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
1671 No longer inline. EXTERN_INLINE is needed only for functions
1672 defined in .h files. Reindent function header as per GNU style.
1673 (backtrace_p, backtrace_top, backtrace_next):
1674 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
1675 compiler or linker. Add extern decls to pacify gcc -Wall.
1676 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
1678 * frame.c (free_monitors): Define only on platforms that need it.
1679 * nsterm.m (ns_term_init):
1680 * process.c (catch_child_signal):
1681 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
1682 defined on all porting targets these days.
1683 * process.c, process.h (catch_child_signal):
1684 Make it extern only if NS_IMPL_GNUSTEP is defined.
1686 2013-06-03 Eli Zaretskii <eliz@gnu.org>
1688 * w32.c (gettimeofday): Make the signature identical to prototype
1689 in nt/inc/sys/time.h.
1691 2013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
1693 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
1696 * keyboard.c (safe_run_hooks_error): Improve error message.
1698 * data.c (pure_write_error): Add `object' argument.
1699 * puresize.h (CHECK_IMPURE): Use it.
1701 2013-06-03 Michael Albinus <michael.albinus@gmx.de>
1703 * Makefile.in (NOTIFY_OBJ): New variable.
1704 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
1706 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
1707 Call syms_of_gfilenotify.
1709 * gfilenotify.c: New file.
1711 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
1712 and Qfile_w32notify.
1713 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
1714 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
1716 * lisp.h: Declare syms_of_gfilenotify.
1718 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
1720 2013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
1722 Merge the specpdl and backtrace stacks. Make the structure of the
1723 specpdl entries more obvious via a tagged union of structs.
1724 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
1725 (enum specbind_tag): New enum.
1726 (struct specbinding): Make it a tagged union of structs.
1727 Add a case for backtrace records.
1728 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
1729 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
1730 (backtrace_debug_on_exit): New accessors.
1731 (struct backtrace): Remove.
1732 (struct catchtag): Remove backlist field.
1733 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1735 (Flocal_variable_p): Speed up the common case where the binding is
1737 * eval.c (backtrace_list): Remove.
1738 (set_specpdl_symbol, set_specpdl_old_value): Remove.
1739 (set_backtrace_args, set_backtrace_nargs)
1740 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
1741 (backtrace_next): New functions.
1742 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
1743 (unwind_to_catch, internal_lisp_condition_case)
1744 (internal_condition_case, internal_condition_case_1)
1745 (internal_condition_case_2, internal_condition_case_n): Don't bother
1746 with backtrace_list any more.
1747 (Fsignal): Adjust to new backtrace format.
1748 (grow_specpdl): Move up.
1749 (record_in_backtrace): New function.
1750 (eval_sub, Ffuncall): Use it.
1751 (apply_lambda): Adjust to new backtrace format.
1752 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
1754 (specbind): Adjust to new specpdl format. Simplify.
1755 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
1756 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
1758 (mark_backtrace): Remove.
1759 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
1760 * xdisp.c (redisplay_internal): Use record_in_backtrace.
1761 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
1763 * profiler.c (record_backtrace): Use get_backtrace.
1764 (handle_profiler_signal): Use backtrace_top_function.
1765 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
1768 2013-06-02 Jan Djärv <jan.h.d@swipnet.se>
1770 * process.h (catch_child_signal): Declare.
1772 * process.c (catch_child_signal): New function.
1773 (init_process_emacs): Call it.
1775 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
1776 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
1778 (x_set_cursor_type): Remove declaration.
1779 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
1780 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
1781 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
1782 (ns_get_color): Use F suffix on float.
1783 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
1784 (ns_get_rgb_color): Remove.
1785 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
1786 (note_mouse_movement): x and y are CGFloat.
1787 (ns_draw_fringe_bitmap): Remove unused rowY.
1788 Change #if to COCOA && >= 10_6.
1789 (ns_draw_window_cursor): Remove unused overspill.
1790 (ns_draw_underwave): width and x are EamcsCGFloat.
1791 (ns_draw_box): thickness is CGFloat.
1792 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
1793 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
1794 if not in main thread.
1795 (ns_get_pending_menu_title, ns_check_menu_open)
1796 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
1797 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
1798 (sendFromMainThread:): New method.
1799 (changeFont:): size is CGFloat.
1800 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
1801 Disable warning about permanent text.
1802 (characterIndexForPoint:): Adjust return type depending on GNUStep
1804 (mouseDown:): delta is CGFloat.
1805 (updateFrameSize): Remove unised variable f.
1806 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
1807 Cast float to EmacsCGFloat.
1808 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
1809 also to -1 when restoring.
1810 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
1811 inside NS_IMPL_COCOA.
1812 (toggleFullScreen:): Put call to toggleFullScreen inside
1813 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
1814 (setPosition:portion:whole:): por is CGFloat.
1815 (getMouseMotionPart:window:x:y:): Add F suffix to float.
1816 (mouseDown:): Use CGFloat.
1817 (mouseDragged:): Remove unised variable edge.
1818 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
1820 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
1822 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
1823 when NS_IMPL_GNUSTEP.
1824 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
1825 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
1826 (EmacsToolbar): Add clearAll. Add tag argument to
1827 addDisplayItemWithImage.
1828 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
1830 * nsselect.m (ns_get_local_selection): Remove unused variable type.
1832 * nsmenu.m (ns_update_menubar): Make static.
1833 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
1834 (fillWithWidgetValue:): Add cast to SEL for setAction.
1835 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
1836 (update_frame_tool_bar): Update code for GNUStep.
1837 (clearAll): New method.
1838 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
1839 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
1840 Move identifierToItem setObject and activeIdentifiers addObject before
1841 call to insertItemWithItemIdentifier.
1842 (validateVisibleItems): Fix indentation.
1843 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
1844 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
1845 UtilityWindow to aStyle, remove call to setStyleMask.
1847 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
1849 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
1850 (ns_charset_covers, ns_get_covering_families, nsfont_open):
1851 Use F suffix on floats.
1852 (ns_char_width): Returns CGFloat.
1853 (ns_ascii_average_width): w is CGFloat instead of float.
1854 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
1856 (ns_glyph_metrics): CGFloat instead of float.
1858 * nsfns.m (x_set_foreground_color, x_set_background_color):
1860 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
1861 remove unused variables.
1862 (Fns_read_file_name): Keep track if panel is for save.
1863 Use ns_filename_from_panel/ns_directory_from_panel.
1864 (Fns_list_services): delegate only used for COCOA.
1865 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
1866 Just return the input if GNUStep.
1867 (x_screen_planes): Remove.
1868 (Fxw_color_values): Use EmacsCGFloat
1869 (Fns_display_monitor_attributes_list): Only get screen number for
1871 (getDirectory, getFilename): Remove from EmacsOpenPanel and
1873 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
1874 ns_directory_from_panel.
1876 2013-06-01 Paul Eggert <eggert@cs.ucla.edu>
1878 * process.c (handle_child_signal): Also use WCONTINUED.
1879 This is so that list-processes doesn't mistakenly list the process
1880 as stopped, when the process has actually been continued and is
1883 2013-05-31 Paul Eggert <eggert@cs.ucla.edu>
1885 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
1886 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
1887 not already configured.
1889 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
1891 2013-05-29 Eli Zaretskii <eliz@gnu.org>
1893 * Makefile.in (mostlyclean): Remove *.res files.
1895 2013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
1897 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
1898 a buffer (bug#8447).
1900 2013-05-27 Eli Zaretskii <eliz@gnu.org>
1902 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
1903 display vector, and we backtrack, handle the case that the
1904 previous character position is also displayed from a display
1905 vector or covered by a display string or image. (Bug#14476)
1907 2013-05-25 Jan Djärv <jan.h.d@swipnet.se>
1909 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
1910 (struct MonitorInfo, free_monitors): Remove.
1911 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
1912 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
1913 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
1916 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
1917 (struct MonitorInfo, free_monitors): Remove.
1918 (ns_screen_name): Make static.
1919 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
1920 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
1923 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
1924 (struct MonitorInfo): New struct.
1925 (free_monitors, make_monitor_attribute_list): Declare.
1927 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
1929 (free_monitors, make_monitor_attribute_list): New functions.
1930 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
1933 2013-05-25 Xue Fuqiao <xfq.free@gmail.com>
1935 * callproc.c (call_process): Refine the doc string. (Bug#14045)
1937 2013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
1939 * keyboard.c: Apply keyboard decoding only to events that come directly
1940 from the tty, not from unread-command-events (bug#14368).
1941 (read_event_from_main_queue): New function, extracted from read_char).
1942 (read_decoded_char): Remove.
1943 (read_decoded_event_from_main_queue): New function to replace it.
1944 (read_char): Use it.
1945 (read_key_sequence): Use read_char rather than read_decoded_char.
1947 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
1949 2013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
1951 * casetab.c (init_casetab_once): Fix last change (bug#14424).
1953 2013-05-22 Kenichi Handa <handa@gnu.org>
1955 The following changes are to fix the setting of
1956 buffer-file-coding-system on, for instance, C-x RET c unix RET
1957 _FILE_OF_DOS_EOL_TYPE_ RET.
1959 * coding.h (struct coding_system): New member detected_utf8_chars.
1961 * coding.c (detect_coding_utf_8): Count characters and check EOL
1962 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
1964 (setup_coding_system): Do not initialize coding->head_ascii.
1965 (check_ascii): Do not set coding->eol_seen but update it. Do not
1966 call adjust_coding_eol_type here.
1967 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
1968 If the eol-type of CODING is already specified, adjust the eol type
1969 of the found coding-system.
1970 (decode_coding_gap): Cancel previous change. Utilize the
1971 character numbers counted by detect_coding_utf_8. Fix detection
1974 2013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
1976 * search.c (looking_at_1): Only set last_thing_searched if the match
1977 changed the match-data (bug#14281).
1979 2013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
1981 * xdisp.c (reseat_at_previous_visible_line_start):
1982 Already declared in dispextern.h, so remove it here.
1983 (move_it_vertically_backward): Likewise.
1985 2013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1987 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
1988 (Fx_display_pixel_width, Fx_display_pixel_height)
1989 (Fx_display_mm_width, Fx_display_mm_height):
1990 Mention `display-monitor-attributes-list' in docstrings.
1992 * nsfns.m (ns_get_screen): Remove function. All uses removed.
1993 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
1994 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
1995 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
1996 (Fx_display_backing_store, Fx_display_visual_class)
1997 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
1998 (Fx_display_grayscale_p, Fx_display_pixel_width)
1999 (Fx_display_pixel_height, Fx_display_planes)
2000 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
2001 (Fx_display_screens): Don't confuse X11 screens with NS screens.
2002 (Fx_display_mm_width, Fx_display_mm_height)
2003 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
2004 height for all physical monitors as in X11.
2006 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
2007 Return pixel width or height for all physical monitors as in X11.
2009 2013-05-18 Paul Eggert <eggert@cs.ucla.edu>
2011 Port --enable-gcc-warnings to clang.
2012 * bytecode.c (exec_byte_code):
2014 Redo diagnostic pragmas to pacify clang, too.
2015 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
2016 * editfns.c (Fencode_time):
2017 * fileio.c (file_accessible_directory_p):
2018 * font.c (font_unparse_xlfd):
2019 Use '&"string"[index]' instead of '"string" + (index)'.
2020 * undo.c (user_error): Remove; unused.
2022 2013-05-16 Eli Zaretskii <eliz@gnu.org>
2024 * insdel.c (insert_1_both): Document the arguments, instead of
2025 referring to insert_1, which no longer exists.
2027 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
2028 some window, increment windows_or_buffers_changed, so that
2029 *Messages* display in that window is updated. (Bug#14408)
2031 * w32.c: Include epaths.h.
2032 (init_environment): Use cmdproxy.exe without leading directories.
2033 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
2035 (gettimeofday): Adjust signature and return value to Posix
2038 * unexw32.c (open_output_file): Delete the existing emacs.exe
2039 before creating it, to break the hard link to the versioned
2042 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
2043 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
2044 (FIRSTFILE_OBJ): New variables.
2045 (W32_RES): Rename to EMACSRES. All users changed.
2046 (base_obj): Use $(CM_OBJ).
2047 (ALLOBJS): Use $(FIRSTFILE_OBJ).
2048 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
2049 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
2050 $(W32_RES_LINK) before $(LIBES).
2051 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
2053 2013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2055 * makefile.w32-in (DOC): Use just "DOC".
2057 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
2059 * process.c: Export default filters and sentinels to Elisp.
2060 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
2062 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
2063 (Fset_process_sentinel, Fformat_network_address):
2064 Default to them instead of nil.
2065 (server_accept_connection): Sentinels can't be nil any more.
2066 (read_and_dispose_of_process_output): New function, extracted from
2067 read_process_output.
2068 (read_process_output): Use it; filters can't be nil.
2069 (Finternal_default_process_filter): New function, extracted from
2070 read_process_output.
2071 (exec_sentinel_unwind): Remove function.
2072 (exec_sentinel): Don't zilch sentinel while running.
2073 (status_notify): Sentinels can't be nil.
2074 (Finternal_default_process_sentinel): New function extracted from
2076 (setup_process_coding_systems): Default filter is not nil any more.
2077 (syms_of_process): Export new Elisp functions and initialize
2079 * lisp.h (make_lisp_proc): New function.
2081 2013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2083 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
2085 2013-05-14 Eli Zaretskii <eliz@gnu.org>
2087 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
2088 unless we know that the window w is a leaf window.
2089 Another attempt at solving bug#14062.
2091 2013-05-14 Jan Djärv <jan.h.d@swipnet.se>
2093 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
2096 2013-05-12 Paul Eggert <eggert@cs.ucla.edu>
2098 * image.c (gif_load): Check that subimages fit (Bug#14345).
2100 2013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
2102 * lread.c (skip_dyn_eof): New function.
2103 (read1): Use it to skip the end of a file in response to #@00.
2105 * doc.c (get_doc_string): Slightly relax the sanity checking.
2107 2013-05-09 Jan Djärv <jan.h.d@swipnet.se>
2109 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
2110 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
2111 (MonitorInfo): New struct.
2112 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
2113 (Fns_display_monitor_attributes_list): New functions.
2114 (display-usable-bounds): Remove.
2115 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
2118 2013-05-09 Paul Eggert <eggert@cs.ucla.edu>
2120 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
2121 (GTK_CHECK_VERSION): New macro, if not already defined.
2122 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
2123 replaced by GTK_CHECK_VERSION.
2125 2013-05-08 Paul Eggert <eggert@cs.ucla.edu>
2127 * xterm.h (GTK_PREREQ): New macro.
2128 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
2129 to use this macro instead, for consistency and clarity.
2131 2013-05-08 Eli Zaretskii <eliz@gnu.org>
2133 * xdisp.c (row_for_charpos_p): New function, with code of
2134 cursor_row_p, but accepts an additional argument CHARPOS instead
2135 of using a hardcoded PT.
2136 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
2137 (row_containing_pos): Call row_for_charpos_p instead of partially
2138 doing the same. Fixes cursor positioning under longlines-mode
2139 when longlines-show-effect includes more than one newline, when
2140 moving the cursor vertically up.
2142 2013-05-08 Juanma Barranquero <lekktu@gmail.com>
2144 * makefile.w32-in (ACL_H): New macro.
2145 ($(BLD)/fileio.$(O)): Update dependencies.
2147 2013-05-07 Paul Eggert <eggert@cs.ucla.edu>
2149 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
2150 * Makefile.in (LIB_ACL): New macro.
2151 (LIBACL_LIBS): Remove.
2152 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
2153 * fileio.c: Include <acl.h>.
2154 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
2155 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
2157 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
2160 * unexelf.c: Don't assume ElfW (Half) fits in int.
2161 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
2162 when dealing with ElfW (Half) values, since they can exceed 2**31
2163 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
2164 (entry_address): Omit unused NUM arg. All uses changed.
2166 2013-05-07 Juri Linkov <juri@jurta.org>
2168 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
2169 to the string converted from number with `Fnumber_to_string'.
2172 2013-05-07 Paul Eggert <eggert@cs.ucla.edu>
2174 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
2175 This fixes a problem introduced by my previous change.
2177 2013-05-07 Glenn Morris <rgm@gnu.org>
2179 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
2181 2013-05-07 Jan Djärv <jan.h.d@swipnet.se>
2183 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
2185 2013-05-07 Paul Eggert <eggert@cs.ucla.edu>
2187 Static checking by GCC 4.8.0.
2188 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
2189 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
2190 (x_get_monitor_attributes_fallback)
2191 (x_get_monitor_attributes_xinerama)
2192 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
2193 Define only if USE_GTK.
2194 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
2195 (x_get_monitor_attributes_fallback): Omit unused locals.
2196 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
2197 Use double, not float, to avoid mixed-mode floating point arithmetic.
2199 2013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2200 Jan Djärv <jan.h.d@swipnet.se>
2202 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
2203 (XINERAMA_CFLAGS): New macros.
2204 (ALL_CFLAGS, LIBES): Use them.
2206 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
2207 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
2208 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
2209 (syms_of_xfns): DEFSYM them.
2210 (struct MonitorInfo): New struct.
2211 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
2212 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
2213 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
2214 (x_get_monitor_attributes_xinerama): New functions.
2215 (Fx_display_monitor_attributes_list): New primitive.
2216 (syms_of_xfns): Defsubr it.
2218 * xterm.h (x_display_info): Add Xatom_net_workarea and
2219 Xatom_net_current_desktop.
2221 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
2222 and dpyinfo->Xatom_net_current_desktop.
2224 2013-05-06 Eli Zaretskii <eliz@gnu.org>
2226 * xdisp.c (pos_visible_p): Use the special code for finding the
2227 beginning of a display property or overlay for any "replacing"
2228 display property, not just for display strings. This solves
2229 incorrect reporting of position by posn-at-point. (Bug#14241)
2231 2013-05-06 Paul Eggert <eggert@cs.ucla.edu>
2233 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
2234 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
2235 Verify that ElfW (Half) fits in int.
2236 (fatal): Use same signature as lisp.h.
2237 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
2238 configure and build with -DUNEXELF_DEBUG without worrying about
2239 other modules that use DEBUG.
2240 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
2241 possibly-wide integers now uses it instead of plain fprintf.
2242 (entry_address): New function, which avoids problems with 32-bit
2243 overflow on 64-bit hosts.
2244 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
2245 (round_up): Don't assume the remainder fits in int.
2246 (find_section): Use bool for boolean. Simplify debug code.
2247 (unexec): Don't assume file sizes fit in int or size_t.
2248 Omit unnecessary trailing newline in 'fatal' format.
2249 Use strerror rather than outputting decimal error number.
2250 Remove unused code when emacs is not defined;
2251 this file relies on Emacs now.
2252 Don't assume e_phnum and e_shnum are positive.
2254 * regex.c: Fix problems when DEBUG is defined.
2255 (extract_number, extract_number_and_incr): Define regardless of
2256 whether DEBUG is defined; that's simpler and makes the code less
2257 likely to go stale in the normal case when DEBUG is not defined.
2258 Return int rather than taking an int * arg. All callers changed.
2259 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
2260 Remove, replacing with ...
2261 (DEBUG_PRINT): New macro. All callers changed.
2262 (DEBUG_COMPILES_ARGUMENTS): New macro.
2263 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
2264 (print_compiled_pattern, print_double_string) [DEBUG]:
2265 Use prototype rather than old-style definition.
2266 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
2267 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
2268 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
2269 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
2270 Don't assume ptrdiff_t, size_t, and long are the same width as int.
2271 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
2272 This matters only when DEBUG is defined.
2274 2013-05-05 Eli Zaretskii <eliz@gnu.org>
2276 * xdisp.c (set_iterator_to_next): Set the
2277 ignore_overlay_strings_at_pos_p flag only if we are _really_
2278 iterating over an overlay string, as indicated by the
2279 current.overlay_string_index member. (Bug#14306)
2281 2013-05-05 Jan Djärv <jan.h.d@swipnet.se>
2283 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
2284 to where it is used, to avoid autorelease issues (Bug#14050).
2286 2013-05-05 Paul Eggert <eggert@cs.ucla.edu>
2288 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
2289 * fileio.c (syms_of_fileio): Implement this.
2290 * filelock.c (create_lock_file): If symbolic links don't work, so
2291 we use a regular file as a lock file, do not fsync the lock file;
2294 2013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2296 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
2297 (syms_of_minibuf): Adjust accodingly.
2299 * callint.c (Fcall_interactively): Adjust calls accordingly.
2301 2013-05-04 Eli Zaretskii <eliz@gnu.org>
2303 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
2304 w->contents is a buffer before computing everything else.
2305 Use parentheses to disambiguate last part of the condition.
2307 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
2308 assertion violations. (Bug#14062)
2310 2013-05-01 David Reitter <david.reitter@gmail.com>
2312 * nsfns.m (ns_tooltip): Initialize.
2314 2013-04-28 Eli Zaretskii <eliz@gnu.org>
2316 * coding.c (decode_coding_gap): Don't remove the character before
2317 a newline unless it's a CR character. (Bug#14287)
2319 2013-04-28 Dan Nicolaescu <dann@gnu.org>
2321 * dispextern.h (struct face): Move enum face_underline_type
2322 earlier so that bitfields can be in the same word.
2324 2013-04-28 Jan Djärv <jan.h.d@swipnet.se>
2326 * nsfns.m (handlePanelKeys): New function.
2327 (EmacsOpenPanel:performKeyEquivalent:)
2328 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
2329 arrows/function/control and copy/paste keys (Bug#14296).
2331 2013-04-27 Juri Linkov <juri@jurta.org>
2333 * callint.c (Fcall_interactively): Call `Qread_number' for
2334 interactive code letter `n' instead of using duplicate code.
2337 2013-04-27 Paul Eggert <eggert@cs.ucla.edu>
2339 * systime.h (make_timeval): Declare as 'const'.
2341 2013-04-27 Kenichi Handa <handa@gnu.org>
2343 * font.c (font_open_entity): Always open a font of manageable
2346 2013-04-26 Paul Eggert <eggert@cs.ucla.edu>
2348 Port better to AIX (Bug#14258).
2349 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
2352 2013-04-24 Kenichi Handa <handa@gnu.org>
2354 * coding.c (decode_coding_iso_2022): When an invalid escape
2355 sequence is encountered, reset the invocation and designation
2356 status to the safest one.
2358 2013-04-22 Paul Eggert <eggert@cs.ucla.edu>
2360 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
2361 Without this fix, "make distclean" leaves stamp-h1 behind.
2363 2013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
2365 * w32fns.c (w32_fullscreen_rect): New function to compute the
2366 window rectangle for the given fullscreen mode.
2367 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
2368 longer tunes the window size. This keeps the window's edges flush
2369 with the screen and allows the taskbar to hide itself in fullboth.
2371 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
2372 window decorations and uses the entire screen.
2374 * w32term.h (w32_fullscreen_rect) Add prototype.
2375 (struct w32_output): Replace normal_width, normal_height,
2376 normal_top, and normal_left members with a single normal_placement
2378 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
2380 (FRAME_NORMAL_PLACEMENT): New macro.
2382 2013-04-16 Juanma Barranquero <lekktu@gmail.com>
2384 * minibuf.c (Ftest_completion): Silence compiler warning.
2386 2013-04-15 Eli Zaretskii <eliz@gnu.org>
2388 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
2391 * frame.h (WINDOW_FRAME): Protect macro and its argument with
2394 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
2395 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
2396 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
2397 parentheses where appropriate.
2399 2013-04-14 Paul Eggert <eggert@cs.ucla.edu>
2401 * keyboard.c (timer_start_idle): Remove no-longer-used local.
2403 2013-04-14 Eli Zaretskii <eliz@gnu.org>
2405 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
2406 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
2407 Mention in the doc string that setting these variables takes
2408 effect only after a call to set-window-buffer. (Bug#14200)
2410 2013-04-13 Eli Zaretskii <eliz@gnu.org>
2412 * indent.c (Fvertical_motion): Don't consider display strings on
2413 overlay strings as display strings on the buffer position we
2414 started from. This prevents vertical cursor motion from jumping
2415 more than one line when there's an overlay string with a display
2416 property at end of line.
2417 Reported by Karl Chen <Karl.Chen@quarl.org> in
2418 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
2420 2013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
2422 * window.c (select_window): `record_buffer' even if window is
2423 already selected (bug#14191).
2425 2013-04-11 Eli Zaretskii <eliz@gnu.org>
2427 * window.c (Fwindow_end): Test more flags, including the buffer's
2428 last_overlay_modified flag, to determine whether the window's
2429 display is really up-to-date. Prevents the function from
2430 returning a stale value. (Bug#14170)
2431 (Fwindow_line_height): Fix the test for up-to-date-ness of the
2434 2013-04-10 Eli Zaretskii <eliz@gnu.org>
2436 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
2437 garbaged only if it is not already the top frame on its TTY.
2438 This prevents flickering due to constant redrawing of TTY frames when
2439 there are GUI frames open in the same session. (Bug#13864)
2441 2013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
2443 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
2444 of marking the idle timers directly.
2446 2013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
2448 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
2451 2013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
2453 * window.c (select_window): Don't record_buffer while the invariant is
2454 temporarily broken (bug#14161).
2456 * fns.c (Fdelq): Don't assume !NILP => CONSP.
2458 2013-04-07 Eli Zaretskii <eliz@gnu.org>
2460 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
2462 2013-04-07 Romain Francoise <romain@orebokech.com>
2464 Ignore additional platform-specific ACL errors (Bug#13702).
2465 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
2466 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
2468 2013-03-31 Jan Djärv <jan.h.d@swipnet.se>
2470 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
2473 2013-04-07 Paul Eggert <eggert@cs.ucla.edu>
2475 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
2476 This bug was introduced by my 2013-02-25 change that simplified
2477 data_start configuration. Without this change, on GNU/Linux
2478 an Emacs configured with --enable-profiling fails immediately
2479 due to a profiler signal.
2480 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
2481 with these flags. On platforms where special flags are needed
2482 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
2483 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
2484 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
2486 2013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
2488 Get rid of some platform-specific functions examining window
2489 system and its capabilities. This is a partial rework of the
2491 * lisp.h (have_menus_p): Remove prototype. This function is
2492 replaced with platform-independent window_system_available.
2493 (check_window_system): Move to...
2494 * frame.h (decode_window_system_frame, window_system_available):
2495 ...here, add new prototypes.
2496 * frame.c (window_system_available, decode_window_system_frame):
2498 (check_window_system): Platform-independent now.
2499 * xterm.h (x_in_use): Remove declaration.
2501 * w32term.h (check_x_frame):
2502 * nsterm.h (check_x_frame): Remove prototypes. This function
2503 is replaced with platform-independent decode_window_system_frame.
2504 * msdos.c (have_menus_p): Remove.
2505 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
2506 Remove platform-specific functions. Use check_window_system,
2507 decode_window_system_frame and check_ns_display_info where
2508 appropriate. Minor style and comment tweaks.
2509 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
2510 (check_x_frame): Likewise.
2511 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
2513 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
2514 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
2515 * xmenu.c, xselect.c: All related users changed.
2517 2013-04-03 Kenichi Handa <handa@gnu.org>
2519 The following changes is to optimize the code for reading UTF-8
2522 * coding.c (check_ascii): Rename from detect_ascii. Return value
2523 changed. Check EOL format. Do not call adjust_coding_eol_type
2525 (check_utf_8): New function.
2526 (adjust_coding_eol_type): Do nothing if already adjusted.
2527 (detect_coding): Compare the return value of check_ascii with
2528 coding->src_bytes. Call adjust_coding_eol_type if necessary.
2529 (decode_coding_gap): Optimize for valid UTF-8.
2531 2013-03-21 Kenichi Handa <handa@gnu.org>
2533 * coding.c (syms_of_coding): Cancel previous change.
2535 * insdel.c (insert_from_gap): Fix previous change.
2537 2013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
2539 Consistently use platform-specific function to detect window system.
2540 * lisp.h (check_window_system): New prototype. This function is
2541 going to replace check_x, check_w32 and check_ns.
2542 (have_menus_p): Mention msdos.c in comment.
2543 * fontset.c (check_window_system_func): Remove. Adjust all users.
2544 * fontset.h (check_window_system_func): Remove prototype.
2545 * nsterm.h (check_ns):
2546 * xterm.h (check_x):
2547 * w32term.h (check_w32): Likewise.
2548 * menu.c (Fx_popup_menu): Use check_window_system.
2549 * msdos.c (check_window_system): Define for MS-DOS.
2550 * nsfns.m (check_window_system): Define for NS. Adjust all users.
2551 * w32fns.c (check_window_system): Likewise for MS-Windows.
2552 * xfns.c (check_window_system): Likewise for X.
2553 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
2554 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
2556 2013-04-02 Paul Eggert <eggert@cs.ucla.edu>
2558 Prefer < to > in range checks such as 0 <= i && i < N.
2559 This makes it easier to visualize quantities on a number line.
2560 This patch doesn't apply to all such range checks,
2561 only to the range checks affected by the 2013-03-24 change.
2562 This patch reverts most of the 2013-03-24 change.
2563 * alloc.c (xpalloc, Fgarbage_collect):
2564 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
2565 * character.c (string_escape_byte8):
2566 * charset.c (read_hex):
2567 * data.c (cons_to_unsigned):
2568 * dispnew.c (update_frame_1):
2569 * doc.c (Fsubstitute_command_keys):
2570 * doprnt.c (doprnt):
2571 * editfns.c (hi_time, decode_time_components):
2572 * fileio.c (file_offset):
2573 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
2574 * font.c (font_intern_prop):
2575 * frame.c (x_set_alpha):
2576 * gtkutil.c (get_utf8_string):
2577 * indent.c (check_display_width):
2578 * keymap.c (Fkey_description):
2579 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
2581 * minibuf.c (read_minibuf_noninteractive):
2582 * process.c (wait_reading_process_output):
2583 * search.c (Freplace_match):
2584 * window.c (get_phys_cursor_glyph):
2585 * xdisp.c (redisplay_internal):
2586 * xsmfns.c (smc_save_yourself_CB):
2587 Prefer < to > for range checks.
2588 * dispnew.c (sit_for): Don't mishandle NaNs.
2589 This fixes a bug introduced in the 2013-03-24 change.
2590 * editfns.c (decode_time_components): Don't hoist comparison.
2591 This fixes another bug introduced in the 2013-03-24 change.
2593 2013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
2595 * frame.h (struct frame): Drop scroll_bottom_vpos
2596 member becaue all real users are dead long ago.
2597 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
2598 * xdisp.c (redisplay_internal): Adjust user.
2600 2013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
2602 * nsmenu.m (showAtX:Y:for:): setLevel to
2603 NSPopUpMenuWindowLevel (Bug#13998).
2605 2013-03-30 Jan Djärv <jan.h.d@swipnet.se>
2607 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
2608 (ns_check_pending_open_menu): Declare.
2610 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
2611 (x_activate_menubar): Update the menu with title that matches
2612 ns_get_pending_menu_title, and call
2613 ns_check_pending_openmenu (Bug#12698).
2614 (menuWillOpen:): New method.
2615 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
2617 * nsterm.m (menu_will_open_state, menu_mouse_point)
2618 (menu_pending_title): New varaibles.
2619 (ns_get_pending_menu_title, ns_check_menu_open)
2620 (ns_check_pending_open_menu): New functions.
2622 2013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
2624 * indent.c (current_column_bol_cache): Remove leftover which is not
2625 used in Fmove_to_column any more.
2626 (current_column, scan_for_column): Adjust users.
2627 * keyboard.c (last_point_position_buffer, last_point_position_window):
2628 Remove leftovers which are not used for recording undo any more.
2629 (command_loop_1, syms_of_keyboard): Adjust users.
2630 * xdisp.c (last_max_ascent): Remove leftover which is not used in
2631 redisplay_window any more.
2632 (move_it_to): Adjust user.
2634 2013-03-29 Juanma Barranquero <lekktu@gmail.com>
2636 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
2637 Update dependencies.
2639 2013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2641 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
2642 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
2645 2013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
2647 * window.h (struct window): Replace hchild, vchild and buffer slots
2648 with the only contents slot. This is possible because each valid
2649 window may have either the child window (in vertical or horizontal
2650 combination) or buffer to display (for the leaf window). Using that,
2651 a lof of operations to traverse and/or change window hierarchies may
2652 be simplified. New member horizontal is used to distinguish between
2653 horizontal and vertical combinations of internal windows.
2654 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
2655 (WINDOW_VERTICAL_COMBINATION_P): New macros.
2656 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
2657 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
2658 Use contents slot, not buffer, where appropriate.
2659 (wset_combination): New function.
2660 (wset_buffer): Add eassert.
2661 (Fframe_first_window): Simplify the loop reaching first window.
2662 (Fwindow_buffer): Use WINDOW_LEAF_P.
2663 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
2664 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
2665 (unshow_buffer): Convert initial debugging check to eassert.
2666 (replace_window, recombine_windows, Fdelete_other_windows_internal)
2667 (make_parent_window, window_resize_check, window_resize_apply)
2668 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
2669 (Fset_window_configuration, delete_all_child_windows, save_window_save):
2670 Adjust to match struct window changes.
2671 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
2672 (mark_window_cursors_off, count_windows, get_leaf_windows)
2673 (foreach_window_1): Simplify the loop.
2674 * alloc.c (mark_object): Do not check for the leaf window because
2675 internal windows has no glyph matrices anyway.
2676 * dispnew.c (clear_window_matrices, showing_window_margins_p)
2677 (allocate_matrices_for_window_redisplay, fake_current_matrices)
2678 (allocate_matrices_for_frame_redisplay, free_window_matrices)
2679 (build_frame_matrix_from_window_tree, mirror_make_current)
2680 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
2681 (update_window_tree, set_window_update_flags): Simplify the loop.
2682 (sync_window_with_frame_matrix_rows): Enforce live window.
2683 Use contents slot, not buffer, where appropriate.
2684 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
2685 and WINDOW_HORIZONTAL_COMBINATION_P.
2686 (make_frame_visible_1): Simplify the loop.
2687 Use contents slot, not buffer, where appropriate.
2688 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
2689 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
2690 (expose_window_tree): Likewise.
2691 Use contents slot, not buffer, where appropriate.
2692 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
2693 to avoid deleted windows. Use contents slot instead of buffer.
2694 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
2695 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
2696 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
2697 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
2699 2013-03-28 Eli Zaretskii <eliz@gnu.org>
2701 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
2702 identify the reasons for assertion violations in bug#14062 and
2704 (Fx_show_tip): Fix compilation error under
2705 "--enable-check-lisp-object-type". (Bug#14073)
2707 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
2708 Reported by <rzl24ozi@gmail.com>.
2710 2013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
2712 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
2714 (unwind_with_echo_area_buffer): ...to restore it here.
2715 This is needed to ensure that...
2716 (redisplay_window): ...both window markers are valid here,
2717 which is verified by eassert.
2718 * editfns.c (save_excursion_save): Do not assume that
2719 selected_window always displays the buffer.
2720 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
2723 2013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
2725 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
2728 2013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
2730 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
2732 2013-03-27 Eli Zaretskii <eliz@gnu.org>
2734 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
2735 since MinGW's w32api headers do. This avoids compiler warnings.
2737 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
2740 2013-03-26 Eli Zaretskii <eliz@gnu.org>
2742 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
2744 2013-03-26 Jan Djärv <jan.h.d@swipnet.se>
2746 * gtkutil.c (style_changed_cb): Check if frame is live and an
2747 X frame (Bug#14038).
2749 2013-03-26 Eli Zaretskii <eliz@gnu.org>
2751 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
2752 Define only for _WIN32_WINNT less than 0x0500.
2753 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
2755 Move inclusion of time.h before sys/time.h, so that MinGW64 could
2756 see its own definitions of 'struct timeval' and 'struct timezone'.
2758 Fix incompatibilities between MinGW.org and MinGW64 headers.
2759 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
2761 * w32.c (REPARSE_DATA_BUFFER): Guard with
2762 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
2764 2013-03-25 Jan Djärv <jan.h.d@swipnet.se>
2766 * xterm.c: Include X11/XKBlib.h
2767 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
2769 2013-03-24 Andreas Schwab <schwab@linux-m68k.org>
2771 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
2773 * blockinput.h (input_blocked_p): Likewise.
2774 * bytecode.c (exec_byte_code): Likewise.
2775 * callproc.c (call_process_kill, call_process_cleanup)
2776 (Fcall_process): Likewise.
2777 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
2778 (Fccl_execute_on_string): Likewise.
2779 * character.c (string_escape_byte8): Likewise.
2780 * charset.c (read_hex): Likewise.
2781 * cm.c (calccost): Likewise.
2782 * data.c (cons_to_unsigned): Likewise.
2783 * dired.c (directory_files_internal, file_name_completion):
2785 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
2786 (sit_for): Likewise.
2787 * doc.c (Fsubstitute_command_keys): Likewise.
2788 * doprnt.c (doprnt): Likewise.
2789 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
2790 * emacsgtkfixed.c: Likewise.
2791 * fileio.c (file_offset, Fwrite_region): Likewise.
2792 * floatfns.c (Fexpt, fmod_float): Likewise.
2793 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
2795 * font.c (font_intern_prop): Likewise.
2796 * frame.c (x_set_alpha): Likewise.
2797 * gtkutil.c (get_utf8_string): Likewise.
2798 * indent.c (check_display_width): Likewise.
2799 * intervals.c (create_root_interval, rotate_right, rotate_left)
2800 (split_interval_right, split_interval_left)
2801 (adjust_intervals_for_insertion, delete_node)
2802 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2803 (merge_interval_right, merge_interval_left, copy_intervals)
2804 (set_intervals_multibyte_1): Likewise.
2805 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
2806 * keymap.c (Fkey_description): Likewise.
2807 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
2808 * lread.c (openp, read_integer, read1, string_to_number):
2810 * menu.c (ensure_menu_items): Likewise.
2811 * minibuf.c (read_minibuf_noninteractive): Likewise.
2812 * print.c (printchar, strout): Likewise.
2813 * process.c (create_process, Faccept_process_output)
2814 (wait_reading_process_output, read_process_output, send_process)
2815 (wait_reading_process_output): Likewise.
2816 * profiler.c (make_log, handle_profiler_signal): Likewise.
2817 * regex.c (re_exec): Likewise.
2818 * regex.h: Likewise.
2819 * search.c (looking_at_1, Freplace_match): Likewise.
2820 * sysdep.c (get_child_status, procfs_ttyname)
2821 (procfs_get_total_memory): Likewise.
2822 * systime.h (EMACS_TIME_VALID_P): Likewise.
2823 * term.c (dissociate_if_controlling_tty): Likewise.
2824 * window.c (get_phys_cursor_glyph): Likewise.
2825 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
2826 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
2828 * xfns.c (Fx_window_property): Likewise.
2829 * xmenu.c (set_frame_menubar): Likewise.
2830 * xselect.c (x_get_window_property, x_handle_dnd_message):
2832 * xsmfns.c (smc_save_yourself_CB): Likewise.
2833 * xterm.c (x_scroll_bar_set_handle): Likewise.
2835 2013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
2837 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
2838 to be optional or nil. Adjust comment and convert it to docstring.
2839 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
2840 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
2842 2013-03-24 Paul Eggert <eggert@cs.ucla.edu>
2844 Static checking by GCC 4.8-20130319.
2845 * image.c (gif_load): Assume pass < 3 to pacify GCC.
2846 * process.c (Fset_process_datagram_address)
2847 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
2848 * xdisp.c (get_char_face_and_encoding):
2849 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
2850 (get_glyph_face_and_encoding): Prepare face before possibly using it.
2851 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
2853 2013-03-24 Ken Brown <kbrown@cornell.edu>
2855 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
2856 fix compilation on 64-bit Cygwin, where underscores are not
2857 automatically prepended.
2859 * w32term.c (w32_initialize): Silence compiler warning.
2861 2013-03-23 Eli Zaretskii <eliz@gnu.org>
2863 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
2864 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
2865 variables, to save and restore frame dimensions.
2866 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
2867 after returning from a 'fullscreen' configuration.
2868 use SendMessage instead of PostMessage to send the SC_RESTORE message,
2869 to avoid races between the main thread and the input thread.
2871 * w32term.h (struct w32_output): New members normal_width,
2872 normal_height, normal_top, normal_left, and prev_fsmode.
2873 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
2874 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
2877 * w32term.c (w32fullscreen_hook): Record last value of the frame's
2878 'fullscreen' parameter. Always record previous width and height
2879 of the frame, except when switching out of maximized modes, so
2880 that they could be restored correctly, instead of resetting to the
2881 default frame dimensions. Send SC_RESTORE command to the frame,
2882 unless we are going to send SC_MAXIMIZE, to restore the frame
2883 resize hints in the mouse pointer shown by the window manager.
2886 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
2888 * lisp.h (get_frame_param): Adjust conditions for prototype
2891 2013-03-22 Ken Brown <kbrown@cornell.edu>
2893 * unexcw.c: Drop unneeded inclusion of w32common.h.
2894 (report_sheap_usage): Declare.
2895 (read_exe_header): Add magic numbers for x86_64.
2896 (fixup_executable): Fix printf format specifier for unsigned long
2899 2013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
2901 * frame.h (struct frame): Put menu_bar_window under #ifdef
2902 because this member is not needed when X toolkit is in use.
2903 (fset_menu_bar_window):
2904 * dispnew.c (clear_current_matrices, clear_desired_matrices)
2905 (free_glyphs, update_frame):
2906 * xdisp.c (expose_frame): Likewise.
2907 (display_menu_bar): Likewise. Remove redundant eassert.
2908 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
2911 2013-03-21 Paul Eggert <eggert@cs.ucla.edu>
2913 Use functions and constants to manipulate Lisp_Save_Value objects.
2914 This replaces code that used macros and strings and token-pasting.
2915 The change makes the C source a bit easier to follow,
2916 and shrinks the Emacs executable a bit.
2917 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
2918 (make_save_value): Change 1st arg from string to enum. All callers
2921 (mark_object): Use if, not #if, for GC_MARK_STACK.
2922 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
2923 (XSAVE_OBJECT): Now functions, not macros.
2924 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
2925 the constant was never used.
2926 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
2927 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
2928 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
2929 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
2931 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
2932 type3 with a single member save_type. All uses changed.
2933 (save_type, set_save_pointer, set_save_integer): New functions.
2934 * print.c (PRINTX): Remove.
2936 * alloc.c: Remove redundant static declarations.
2938 2013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
2940 * window.h (struct window): Convert left_col, top_line, total_lines
2941 and total_cols from Lisp_Objects to integers. Adjust comments.
2942 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
2944 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
2945 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
2946 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
2947 Adjust users where appropriate.
2949 2013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
2951 * frame.h (struct frame): Drop resx and resy because the same data is
2952 available from window system-specific output context. Adjust users.
2953 (default_pixels_per_inch_x, default_pixels_per_inch_y):
2954 New functions to provide defaults when no window system available.
2955 (FRAME_RES_X, FRAME_RES_Y): New macros.
2956 (NUMVAL): Move from xdisp.c.
2957 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
2958 (Ffont_face_attributes, Fopen_font):
2959 * image.c (gs_load):
2960 * w32font.c (fill_in_logfont):
2961 * xdisp.c (calc_pixel_width_or_height):
2962 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
2963 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
2965 2013-03-20 Kenichi Handa <handa@gnu.org>
2967 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
2968 to 1 (temporary workaround until a bug related to ASCII
2969 optimization is fixed).
2971 2013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
2973 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
2974 Signal error if window is not internal. Adjust docstring.
2975 (delete_all_child_windows): Use combination_limit to save the buffer.
2976 (Fset_window_configuration): Adjust accordingly.
2977 * print.c (syms_of_print): Initialize debugging output not here...
2978 (init_print_once): ...but in a new function here.
2979 * lisp.h (init_print_once): Add prototype.
2980 * emacs.c (main): Add call to init_print_once. Adjust comments.
2982 2013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
2984 * window.c (window_resize_check, window_resize_apply)
2985 (window_from_coordinates, recombine_windows, set_window_buffer)
2986 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
2987 (Fsplit_window_internal, Fdelete_window_internal)
2988 (freeze_window_starts): Use bool for booleans.
2989 * window.h (window_frame_coordinates, resize_frame_windows)
2990 (freeze_window_starts, set_window_buffer): Adjust prototypes.
2992 2013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
2994 * dispnew.c (bitch_at_user): Use `user-error'.
2996 2013-03-17 Ken Brown <kbrown@cornell.edu>
2998 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
2999 as return type of image_background. (Bug#13981)
3000 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
3002 2013-03-16 Jan Djärv <jan.h.d@swipnet.se>
3004 * nsterm.m (updateFrameSize:): Change resize increments if needed.
3005 (ns_select): Don't return with result uninitialized.
3007 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
3010 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
3012 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
3013 directories. If filename is nil, get directory name (Bug#13932).
3014 Use getFilename and getDirectory.
3015 (getFilename, getDirectory): New methods for EmacsSavePanel and
3017 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
3019 2013-03-15 Paul Eggert <eggert@cs.ucla.edu>
3021 * coding.c (decode_coding_gap): Fix typo caught by static checking.
3023 2013-03-15 Kenichi Handa <handa@gnu.org>
3025 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
3026 (adjust_after_replace): Make it back to static. Delete the third
3027 arg text_at_gap_tail. Cancel the code for handling it.
3029 * coding.h (struct coding_system): New member eol_seen.
3031 * coding.c (detect_ascii): New function.
3032 (detect_coding): Set coding->head_ascii and coding->eol_seen only
3033 when the source bytes are actually scanned. On detecting for
3034 coding_category_utf_8_auto, call detect_ascii instead of scanning
3035 source bytes directly.
3036 (produce_chars): Call insert_from_gap with the new arg 0.
3037 (encode_coding): Likewise.
3038 (decode_coding_gap): Control ASCII optimization by the variable
3039 disable_ascii_optimization instead of #ifndef .. #endif.
3040 Deccode EOL format according to coding->eol_seen.
3041 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
3044 * lisp.h (adjust_after_replace): Cancel externing it.
3045 (insert_from_gap): Adjust prototype.
3047 2013-03-15 Eli Zaretskii <eliz@gnu.org>
3049 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
3050 FULLSCREEN_MAXIMIZED. (Bug#13935)
3052 2013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
3054 * region-cache.c (find_cache_boundary, move_cache_gap)
3055 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
3056 Simplify debugging check and convert to eassert. Adjust comment.
3057 (pp_cache): Put under ENABLE_CHECKING.
3059 2013-03-14 Eli Zaretskii <eliz@gnu.org>
3061 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
3062 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
3064 (w32fullscreen_hook): If the frame is visible, reset
3065 f->want_fullscreen flag after changing the frame size. If the
3066 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
3069 2013-03-13 Daniel Colascione <dancol@dancol.org>
3071 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
3072 too so that these builds can use Cygwin's file conversion
3073 functions. (We've been building and linking cygw32.o all along
3074 and just not using it.)
3076 2013-03-13 Paul Eggert <eggert@cs.ucla.edu>
3078 File synchronization fixes (Bug#13944).
3079 * Makefile.in (LIB_FDATASYNC): New macro.
3081 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
3082 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
3083 Don't worry about HAVE_FSYNC, since a substitute fsync is
3084 available if the system lacks one.
3085 (Fwrite_regin): Retry fsync if interrupted.
3087 2013-03-13 Eli Zaretskii <eliz@gnu.org>
3089 * w32term.c (w32_read_socket): If the Emacs frame is being
3090 activated, call w32fullscreen_hook, to make sure the new frame
3091 dimensions are in effect. (Bug#13937)
3093 2013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
3095 * xdisp.c (init_iterator): Simplify because both character and byte
3096 positions are either specified or -1. Add eassert. Adjust comment.
3097 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
3098 character and byte positions can be obtained from marker.
3100 2013-03-13 Paul Eggert <eggert@cs.ucla.edu>
3102 Static checking by Sun C 5.12.
3103 * alloc.c (buffer_memory_full) [REL_ALLOC]:
3104 * bytecode.c (exec_byte_code):
3105 * dispnew.c (init_display):
3107 * fileio.c (Fsubstitute_in_file_name):
3108 * keyboard.c (Fevent_convert_list):
3109 * keymap.c (Fsingle_key_description):
3110 * term.c (maybe_fatal, fatal):
3111 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
3112 * xsmfns.c (Fhandle_save_session):
3113 Omit unreachable code.
3114 * keymap.c (map_keymap_char_table_item): Cast void * to
3115 a function pointer type; the C Standard requires this.
3117 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
3118 Include <sys/param.h> unconditionally, as that works elsewhere and
3119 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
3120 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
3123 See ChangeLog.12 for earlier changes.
3129 Copyright (C) 2011-2013 Free Software Foundation, Inc.
3131 This file is part of GNU Emacs.
3133 GNU Emacs is free software: you can redistribute it and/or modify
3134 it under the terms of the GNU General Public License as published by
3135 the Free Software Foundation, either version 3 of the License, or
3136 (at your option) any later version.
3138 GNU Emacs is distributed in the hope that it will be useful,
3139 but WITHOUT ANY WARRANTY; without even the implied warranty of
3140 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3141 GNU General Public License for more details.
3143 You should have received a copy of the GNU General Public License
3144 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.