* xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
[bpt/emacs.git] / src / ChangeLog
1 2011-05-12 Paul Eggert <eggert@cs.ucla.edu>
2
3 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4 that always fit in int. Use a sentinel instead of a counter, to
5 avoid a temp and to allay GCC's concerns about possible int overflow.
6
7 * menu.c (grow_menu_items): Check for int overflow.
8
9 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10
11 2011-05-11 Paul Eggert <eggert@cs.ucla.edu>
12
13 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
14 Before, the code was not consistent. These values cannot exceed
15 2**31 - 1 so there's no need to make them unsigned.
16 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
17 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
18 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
19 as modifiers.
20 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
21
22 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
23 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
24 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
25 presumably because the widths might not match.
26
27 * window.c (size_window): Avoid needless test at loop start.
28
29 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
30
31 * image.c (Finit_image_library): Return t for built-in image types,
32 like pbm and xbm. (Bug#8640)
33
34 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
35
36 * w32menu.c (set_frame_menubar): Fix submenu allocation.
37
38 2011-05-07 Eli Zaretskii <eliz@gnu.org>
39
40 * w32console.c (Fset_screen_color): Doc fix.
41 (Fget_screen_color): New function.
42 (syms_of_ntterm): Defsubr it.
43
44 * callproc.c (call_process_cleanup): Don't close and unlink the
45 temporary file if Fcall_process didn't create it in the first
46 place.
47 (Fcall_process): Don't create tempfile if stdout of the child
48 process will be redirected to a file specified with `:file'.
49 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
50 cue to call_process_cleanup not to close that handle.
51
52 2011-05-07 Ben Key <bkey76@gmail.com>
53
54 * makefile.w32-in: The bootstrap-temacs rule now makes use of
55 one of two shell specific rules, either bootstrap-temacs-CMD or
56 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
57 to the previous implementation of the bootstrap-temacs rule.
58 The bootstrap-temacs-CMD rule is similar to the previous
59 implementation of the bootstrap-temacs rule except that it
60 makes use of the ESC_CFLAGS variable instead of the CFLAGS
61 variable.
62
63 These changes, along with some changes to nt/configure.bat,
64 nt/gmake.defs, and nt/nmake.defs, are required to extend my
65 earlier fix to add support for --cflags and --ldflags options
66 that include quotes so that it works whether make uses cmd or
67 sh as the shell.
68
69 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
70
71 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
72 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
73 is a constant.
74 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
75 a string. Handle both cases.
76 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
77 (Fdbus_register_method): Use Qinvalid_function.
78
79 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
80
81 * makefile.w32-in: Update dependencies.
82 (LISP_H): Add inttypes.h and stdin.h.
83 (PROCESS_H): Add unistd.h.
84
85 2011-05-06 Eli Zaretskii <eliz@gnu.org>
86
87 * lread.c: Include limits.h (fixes the MS-Windows build broken by
88 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
89
90 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
91
92 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
93
94 * term.c (vfatal): Remove stray call to va_end.
95 It's not needed and the C Standard doesn't allow it here anyway.
96
97 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
98 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
99
100 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
101 bytes.
102
103 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
104
105 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
106
107 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
108
109 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
110
111 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
112
113 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
114 * charset.c (Fdefine_charset_internal): Don't initialize
115 charset.code_space[15]. The value was garbage, on hosts with
116 32-bit int (Bug#8600).
117
118 * lread.c (read_integer): Be more consistent with string-to-number.
119 Use string_to_number to do the actual conversion; this avoids
120 rounding errors and fixes some other screwups. Without this fix,
121 for example, #x1fffffffffffffff was misread as -2305843009213693952.
122 (digit_to_number): Move earlier, for benefit of read_integer.
123 Return -1 if the digit is out of range for the base, -2 if it is
124 not a digit in any supported base. (Bug#8602)
125
126 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
127
128 * dispnew.c (scrolling_window): Return 1 if we scrolled,
129 to match comment at start of function. This also removes a
130 GCC warning about overflow in a 32+64-bit port.
131
132 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
133
134 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
135 Reported by Stefan Monnier in
136 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
137 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages): Use
138 SYMBOLP-guarded XSYMBOL, not XPNTR.
139
140 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
141 (EMACS_UINTPTR): Likewise, with uintptr_t.
142
143 * lisp.h: Prefer 64-bit EMACS_INT if available.
144 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
145 on 32-bit hosts that have 64-bit int, so that they can access
146 large files.
147 However, temporarily disable this change unless the temporary
148 symbol WIDE_EMACS_INT is defined.
149
150 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
151
152 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
153 This removes an assumption that EMACS_INT and long are the same
154 width as pointers. The assumption is true for Emacs porting targets
155 now, but we want to make other targets possible.
156 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
157 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
158 In the rest of the code, change types of integers that hold casted
159 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
160 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
161 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
162 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
163 No need to cast type when ORing.
164 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
165 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
166 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
167 assume EMACS_INT is the same width as char *.
168 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
169 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
170 Remove no-longer-needed casts.
171 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
172 (xg_tool_bar_help_callback, xg_make_tool_item):
173 Use EMACS_INTPTR to hold an integer
174 that will be cast to void *; this can avoid a GCC warning
175 if EMACS_INT is not the same width as void *.
176 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
177 * xdisp.c (display_echo_area_1, resize_mini_window_1):
178 (current_message_1, set_message_1):
179 Use a local to convert to proper width without a cast.
180 * xmenu.c (dialog_selection_callback): Likewise.
181
182 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
183 Also, don't assume VALBITS / RAND_BITS is less than 5,
184 and don't rely on undefined behavior when shifting a 1 left into
185 the sign bit.
186 * lisp.h (get_random): Change signature to match.
187
188 * lread.c (hash_string): Use size_t, not int, for hash computation.
189 Normally we prefer signed values; but hashing is special, because
190 it's better to use unsigned division on hash table sizes so that
191 the remainder is nonnegative. Also, size_t is the natural width
192 for hashing into memory. The previous code used 'int', which doesn't
193 retain enough info to hash well into very large tables.
194 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
195
196 * dbusbind.c: Don't possibly lose pointer info when converting.
197 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
198 Use XPNTR rather than XHASH, so that the high-order bits of
199 the pointer aren't lost when converting through void *.
200
201 * eval.c (Fautoload): Don't double-shift a pointer.
202
203 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
204
205 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
206
207 * gnutls.c (DEF_GNUTLS_FN):
208 * image.c (DEF_IMGLIB_FN): Make function pointers static.
209
210 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
211
212 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
213 marker. (Bug#8610)
214
215 2011-05-05 Eli Zaretskii <eliz@gnu.org>
216
217 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
218 New version that can reserve upto 2GB of heap space.
219
220 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
221
222 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
223
224 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
225
226 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
227 `gnutls_certificate_set_x509_key_file'.
228
229 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
230
231 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
232 Update dependencies.
233
234 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
235
236 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
237 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
238 Remove unused parameter `fildes'.
239 * process.c (read_process_output, send_process): Don't pass it.
240
241 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
242
243 Fix previous change: the library cache is defined in w32.c.
244 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
245 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
246
247 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
248
249 Implement dynamic loading of GnuTLS on Windows.
250
251 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
252 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
253 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
254 Declare.
255
256 * gnutls.c (Qgnutls_dll): Define.
257 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
258 (gnutls_*): Declare function pointers.
259 (init_gnutls_functions): New function to initialize function pointers.
260 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
261 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
262 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
263 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
264 (emacs_gnutls_write, emacs_gnutls_read)
265 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
266 (Fgnutls_available_p): New function.
267 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
268 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
269 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
270
271 * image.c: Include w32.h.
272 (Vimage_type_cache): Delete.
273 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
274 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
275 (w32_delayed_load): Move to w32.c.
276
277 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
278
279 * w32.c (QCloaded_from, Vlibrary_cache): Define.
280 (w32_delayed_load): Move from image.c. When loading a library, record
281 its filename in the :loaded-from property of the library id.
282 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
283 Initialize and staticpro them.
284 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
285
286 * process.c: Include lisp.h before w32.h, not after.
287 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
288 instead of gnutls_record_check_pending.
289
290 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
291
292 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
293
294 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
295 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
296 as passed in.
297
298 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
299
300 * xterm.c (x_set_frame_alpha): Do not set property on anything
301 else than FRAME_X_OUTER_WINDOW (Bug#8608).
302
303 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
304
305 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
306
307 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
308
309 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
310 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
311 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
312 (gnutls_global_initialized, Qgnutls_bootprop_priority)
313 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
314 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
315 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
316 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
317 (Qgnutls_bootprop_callbacks_verify): Make static.
318
319 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
320
321 * callproc.c: Indentation fixup.
322
323 * sysdep.c (wait_for_termination_1): Make static.
324 (wait_for_termination, interruptible_wait_for_termination): Move
325 after wait_for_termination_1.
326
327 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
328
329 * sysdep.c (interruptible_wait_for_termination): New function
330 which is like wait_for_termination, but allows keyboard
331 interruptions.
332
333 * callproc.c (Fcall_process): Add (:file "file") as an option for
334 the STDOUT buffer.
335 (Fcall_process_region): Ditto.
336
337 2011-04-30 Eli Zaretskii <eliz@gnu.org>
338
339 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
340 rather than `XVECTOR (FOO)->size'.
341
342 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
343 inttypes.h, as a gnulib replacement is used if it not available in
344 system headers.
345
346 2011-04-21 Eli Zaretskii <eliz@gnu.org>
347
348 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
349 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
350 of MOST_POSITIVE_FIXNUM. (Bug#8528)
351
352 * coding.c (coding_alloc_by_realloc): Error out if destination
353 will grow beyond MOST_POSITIVE_FIXNUM.
354 (decode_coding_emacs_mule): Abort if there isn't enough place in
355 charbuf for the composition carryover bytes. Reserve an extra
356 space for up to 2 characters produced in a loop.
357 (decode_coding_iso_2022): Abort if there isn't enough place in
358 charbuf for the composition carryover bytes.
359
360 2011-04-21 Eli Zaretskii <eliz@gnu.org>
361
362 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
363 aborting when %lld or %lll format is passed.
364 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
365 %llo or %llx format is passed. (Bug#8545)
366
367 * window.c (window_scroll_line_based): Use a marker instead of
368 simple variables to record original value of point. (Bug#7952)
369
370 * doprnt.c (doprnt): Fix the case where a multibyte sequence
371 produced by %s or %c overflows available buffer space. (Bug#8545)
372
373 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
374
375 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
376 (SIZE_MAX): Move defn after all includes, as they might #define it.
377
378 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
379
380 * w32.c (init_environment): Warn about defaulting HOME to C:\.
381
382 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
383
384 * keyboard.c (Qdelayed_warnings_hook): Define.
385 (command_loop_1): Run `delayed-warnings-hook'
386 if Vdelayed_warnings_list is non-nil.
387 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
388 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
389
390 2011-04-28 Eli Zaretskii <eliz@gnu.org>
391
392 * doprnt.c (doprnt): Don't return value smaller than the buffer
393 size if the message was truncated. (Bug#8545).
394
395 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
396
397 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
398 (Fx_window_property): #if-0 the whole functions, not just the bodies.
399
400 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
401
402 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
403
404 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
405
406 * makefile.w32-in: Update dependencies.
407
408 2011-04-27 Eli Zaretskii <eliz@gnu.org>
409
410 Improve `doprnt' and its usage. (Bug#8545)
411 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
412 `format_end'. Remove support for %l as a conversion specifier.
413 Don't use xrealloc. Improve diagnostics when the %l size modifier
414 is used. Update the commentary.
415
416 * eval.c (verror): Simplify calculation of size_t.
417
418 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
419 messages.
420
421 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
422
423 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
424 change.
425
426 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
427
428 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
429 This makes this file independent of the recent pseudovector change.
430
431 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
432
433 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
434
435 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
436 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
437 Remove unused local.
438 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
439
440 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
441 GCC 4.6.0 optimizes based on type-based alias analysis. For
442 example, if b is of type struct buffer * and v of type struct
443 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
444 != &v->size, and therefore "v->size = 1; b->size = 2; return
445 v->size;" must therefore return 1. This assumption is incorrect
446 for Emacs, since it type-puns struct Lisp_Vector * with many other
447 types. To fix this problem, this patch adds a new type struct
448 vectorlike_header that documents the constraints on layout of vectors
449 and pseudovectors, and helps optimizing compilers not get fooled
450 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
451 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
452 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
453 the size member.
454 (XSETPVECTYPE): Rewrite in terms of new macro.
455 (XSETPVECTYPESIZE): New macro, specifying both type and size.
456 This is a bit clearer, and further avoids the possibility of
457 undesirable aliasing.
458 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
459 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
460 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
461 since Lisp_Subr is a special case (no "next" field).
462 (ASIZE): Now uses header.size rather than size. All
463 previous uses of XVECTOR (foo)->size replaced to use this macro,
464 to avoid the hassle of writing XVECTOR (foo)->header.size.
465 (struct vectorlike_header): New type.
466 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
467 object, to help avoid aliasing.
468 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
469 (SUBRP): Likewise, since Lisp_Subr is a special case.
470 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
471 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
472 (struct Lisp_Hash_Table): Combine first two members into a single
473 struct vectorlike_header member. All uses of "size" and "next" members
474 changed to be "header.size" and "header.next".
475 * buffer.h (struct buffer): Likewise.
476 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
477 * frame.h (struct frame): Likewise.
478 * process.h (struct Lisp_Process): Likewise.
479 * termhooks.h (struct terminal): Likewise.
480 * window.c (struct save_window_data, struct saved_window): Likewise.
481 * window.h (struct window): Likewise.
482 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
483 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
484 * buffer.c (init_buffer_once): Likewise.
485 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
486 special case.
487 * process.c (Fformat_network_address): Use local var for size,
488 for brevity.
489
490 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
491
492 Make the Lisp reader and string-to-float more consistent (Bug#8525)
493 * data.c (atof): Remove decl; no longer used or needed.
494 (digit_to_number): Move to lread.c.
495 (Fstring_to_number): Use new string_to_number function, to be
496 consistent with how the Lisp reader treats infinities and NaNs.
497 Do not assume that floating-point numbers represent EMACS_INT
498 without losing information; this is not true on most 64-bit hosts.
499 Avoid double-rounding errors, by insisting on integers when
500 parsing non-base-10 numbers, as the documentation specifies.
501 * lisp.h (string_to_number): New decl, replacing ...
502 (isfloat_string): Remove.
503 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
504 (read1): Do not accept +. and -. as integers; this
505 appears to have been a coding error. Similarly, do not accept
506 strings like +-1e0 as floating point numbers. Do not report
507 overflow for integer overflows unless the base is not 10 which
508 means we have no simple and reliable way to continue.
509 Break out the floating-point parsing into a new
510 function string_to_number, so that Fstring_to_number parses
511 floating point numbers consistently with the Lisp reader.
512 (digit_to_number): Moved here from data.c. Make it static inline.
513 (E_CHAR, EXP_INT): Remove, replacing with ...
514 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
515 (string_to_number): New function, replacing isfloat_string.
516 This function checks for valid syntax and produces the resulting
517 Lisp float number too. Rework it so that string-to-number
518 no longer mishandles examples like "1.0e+". Use strtoumax,
519 so that overflow for non-base-10 numbers is reported only when
520 there's no portable and simple way to convert to floating point.
521
522 * textprop.c (set_text_properties_1): Rewrite for clarity,
523 and to avoid GCC warning about integer overflow.
524
525 * intervals.h (struct interval): Use EMACS_INT for members
526 where EMACS_UINT might cause problems. See
527 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
528 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
529 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
530 All uses changed.
531 (offset_intervals): Tell GCC not to worry about length overflow
532 when negating a negative length.
533
534 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
535 (overrun_check_free): Likewise.
536
537 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
538 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
539 word size.
540
541 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
542 (gnutls_make_error): Rename local to avoid shadowing.
543 (gnutls_emacs_global_deinit): ifdef out; not used.
544 (Fgnutls_boot): Use const for pointer to readonly storage.
545 Comment out unused local. Fix pointer signedness problems.
546
547 * lread.c (openp): Don't stuff size_t into an 'int'.
548 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
549 about possible signed overflow.
550
551 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
552 (GDK_KEY_g): Don't define if already defined.
553 (xg_prepare_tooltip): Avoid pointer signedness problem.
554 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
555
556 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
557 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
558
559 * xfns.c (Fx_window_property): Simplify a bit,
560 to make a bit faster and to avoid GCC 4.6.0 warning.
561 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
562
563 * fns.c (internal_equal): Don't assume size_t fits in int.
564
565 * alloc.c (compact_small_strings): Tighten assertion a little.
566
567 Replace pEd with more-general pI, and fix some printf arg casts.
568 * lisp.h (pI): New macro, generalizing old pEd macro to other
569 conversion specifiers. For example, use "...%"pI"d..." rather
570 than "...%"pEd"...".
571 (pEd): Remove. All uses replaced with similar uses of pI.
572 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
573 * alloc.c (check_pure_size): Don't overflow by converting size to int.
574 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
575 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
576 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
577 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
578 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
579 64-bit hosts.
580 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
581 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
582 * print.c (safe_debug_print, print_object): Likewise.
583 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
584 to int.
585 Use pI instead of if-then-else-abort. Use %p to avoid casts,
586 avoiding the 0 flag, which is not portable.
587 * process.c (Fmake_network_process): Use pI to avoid cast.
588 * region-cache.c (pp_cache): Likewise.
589 * xdisp.c (decode_mode_spec): Likewise.
590 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
591 behavior on 64-bit hosts with printf arg.
592 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
593 (x_stop_queuing_selection_requests): Likewise.
594 (x_get_window_property): Don't truncate byte count to an 'int'
595 when tracing.
596
597 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
598 here, since it parses constructs like leading '-' and spaces,
599 which are not wanted; and it overflows with large numbers.
600 Instead, simply match F[0-9]+, which is what is wanted anyway.
601
602 * alloc.c: Remove unportable assumptions about struct layout.
603 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
604 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
605 (allocate_vectorlike, make_pure_vector): Use the new macros,
606 plus offsetof, to remove unportable assumptions about struct layout.
607 These assumptions hold on all porting targets that I know of, but
608 they are not guaranteed, they're easy to remove, and removing them
609 makes further changes easier.
610
611 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
612 This doesn't fix a bug but makes the code clearer.
613 (string_overrun_cookie): Now const. Use initializers that
614 don't formally overflow signed char, to avoid warnings.
615 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
616 can cause Emacs to crash when string overrun checking is enabled.
617 (allocate_buffer): Don't assume sizeof (struct buffer) is a
618 multiple of sizeof (EMACS_INT); it need not be, if
619 alignof(EMACS_INT) < sizeof (EMACS_INT).
620 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
621
622 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
623
624 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
625
626 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
627
628 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
629 supposed to be handshaking. (Bug#8556)
630 Reported by Paul Eggert <eggert@cs.ucla.edu>.
631
632 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
633
634 * lisp.h (Qdebug): List symbol.
635 * eval.c (Qdebug): Restore global linkage.
636 * keyboard.c (debug-on-event): New variable.
637 (handle_user_signal): Break into debugger when debug-on-event
638 matches the current signal symbol.
639
640 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
641
642 * alloc.c (check_sblock, check_string_bytes)
643 (check_string_free_list): Convert to standard C.
644
645 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
646
647 * w32.c (emacs_gnutls_push): Fix typo.
648
649 2011-04-25 Eli Zaretskii <eliz@gnu.org>
650
651 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
652 "cast to pointer from integer of different size".
653
654 Improve doprnt and its use in verror. (Bug#8545)
655 * doprnt.c (doprnt): Document the set of format control sequences
656 supported by the function. Use SAFE_ALLOCA instead of always
657 using `alloca'.
658
659 * eval.c (verror): Don't limit the buffer size at size_max-1, that
660 is one byte too soon. Don't use xrealloc; instead xfree and
661 xmalloc anew.
662
663 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
664
665 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
666 callbacks stage.
667
668 * gnutls.c: Renamed global_initialized to
669 gnutls_global_initialized. Added internals for the
670 :verify-hostname-error, :verify-error, and :verify-flags
671 parameters of `gnutls-boot' and documented those parameters in the
672 docstring. Start callback support.
673 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
674 unless a fatal error occured. Call gnutls_alert_send_appropriate
675 on error. Return error code.
676 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
677 (emacs_gnutls_read): Likewise.
678 (Fgnutls_boot): Return handshake error code.
679 (emacs_gnutls_handle_error): New function.
680 (wsaerror_to_errno): Likewise.
681
682 * w32.h (emacs_gnutls_pull): Add prototype.
683 (emacs_gnutls_push): Likewise.
684
685 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
686 (emacs_gnutls_push): Likewise.
687
688 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
689
690 * process.c (wait_reading_process_output): Check if GnuTLS
691 buffered some data internally if no FDs are set for TLS
692 connections.
693
694 * makefile.w32-in (OBJ2): Add gnutls.$(O).
695 (LIBS): Link to USER_LIBS.
696 ($(BLD)/gnutls.$(0)): New target.
697
698 2011-04-24 Eli Zaretskii <eliz@gnu.org>
699
700 * xdisp.c (handle_single_display_spec): Rename the
701 display_replaced_before_p argument into display_replaced_p, to
702 make it consistent with the commentary. Fix typos in the
703 commentary.
704
705 * textprop.c (syms_of_textprop): Remove dead code.
706 (copy_text_properties): Delete obsolete commentary about an
707 interface that was deleted long ago. Fix typos in the description
708 of arguments.
709
710 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
711 to changes in oldXMenu/XMenu.h from 2011-04-16.
712 <menu_help_message, prev_menu_help_message>: Constify.
713 (IT_menu_make_room): menu->help_text is now `const char **';
714 adjust.
715
716 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
717 to changes in oldXMenu/XMenu.h from 2011-04-16.
718 (struct XMenu): Declare `help_text' `const char **'.
719
720 * xfaces.c <Qunspecified>: Make extern again.
721
722 * syntax.c: Include sys/types.h before including regex.h, as
723 required by Posix.
724
725 * doc.c (get_doc_string): Improve the format passed to `error'.
726
727 * doprnt.c (doprnt): Improve commentary.
728
729 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
730
731 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
732 them with etags.
733
734 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
735 changes in globals.h immediately force recompilation.
736 (TAGS): Depend on $(CURDIR)/m/intel386.h and
737 $(CURDIR)/s/ms-w32.h.
738 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
739
740 * character.c (Fchar_direction): Function deleted.
741 (syms_of_character): Don't defsubr it.
742 <char-direction-table>: Deleted.
743
744 2011-04-23 Eli Zaretskii <eliz@gnu.org>
745
746 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
747 * doprnt.c: Include limits.h.
748 (SIZE_MAX): New macro.
749 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
750 local variables are now size_t instead of int or unsigned.
751 Improve overflow protection. Support `l' modifier for integer
752 conversions. Support %l conversion. Don't assume an EMACS_INT
753 argument for integer conversions and for %c.
754
755 * lisp.h (doprnt): Restore prototype.
756
757 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
758 $(SRC)/character.h.
759
760 * Makefile.in (base_obj): Add back doprnt.o.
761
762 * deps.mk (doprnt.o): Add back prerequisites.
763 (callint.o): Depend on character.h.
764
765 * eval.c (internal_lisp_condition_case): Include the handler
766 representation in the error message.
767 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
768 when breaking from the loop.
769
770 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
771
772 * callint.c (Fcall_interactively): When displaying error message
773 about invalid control letter, pass the character's codepoint, not
774 a pointer to its multibyte form. Improve display of the character
775 in octal and display also its hex code.
776
777 * character.c (char_string): Use %x to display the (unsigned)
778 codepoint of an invalid character, to avoid displaying a bogus
779 negative value.
780
781 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
782 `error', not SYMBOL_NAME itself.
783
784 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
785 character arguments to `error'.
786
787 * charset.c (check_iso_charset_parameter): Fix incorrect argument
788 to `error' in error message about FINAL_CHAR argument. Make sure
789 FINAL_CHAR is a character, and use %c when it is passed as
790 argument to `error'.
791
792 2011-04-23 Eli Zaretskii <eliz@gnu.org>
793
794 * s/ms-w32.h (localtime): Redirect to sys_localtime.
795
796 * w32.c: Include <time.h>.
797 (sys_localtime): New function.
798
799 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
800
801 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
802
803 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
804
805 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
806
807 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
808 zombies (Bug#8467).
809
810 2011-04-19 Eli Zaretskii <eliz@gnu.org>
811
812 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
813 gl_state.e_property when gl_state.object is Qt.
814
815 * insdel.c (make_gap_larger): Remove limitation of buffer size
816 to <= INT_MAX.
817
818 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
819
820 * xdisp.c (lookup_glyphless_char_display)
821 (produce_glyphless_glyph): Handle cons cell entry in
822 glyphless-char-display.
823 (Vglyphless_char_display): Document it.
824
825 * term.c (produce_glyphless_glyph): Handle cons cell entry in
826 glyphless-char-display.
827
828 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
829
830 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
831
832 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
833
834 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
835 definition for no-X builds.
836
837 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
838
839 Static checks with GCC 4.6.0 and non-default toolkits.
840
841 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
842
843 * process.c (keyboard_bit_set): Define only if SIGIO.
844 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
845 (send_process): Repair possible setjmp clobbering.
846
847 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
848
849 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
850
851 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
852
853 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
854 Define only if needed.
855
856 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
857 by pacifying GCC about it. Maybe it's time to retire it?
858 * xfaces.c (USG, __TIMEVAL__): Likewise.
859
860 * dispextern.h (struct redisplay_interface): Rename param
861 to avoid shadowing.
862 * termhooks.h (struct terminal): Likewise.
863 * xterm.c (xembed_send_message): Likewise.
864
865 * insdel.c (make_gap_smaller): Define only if
866 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
867
868 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
869 it.
870
871 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
872 so that we aren't warned about unused symbols.
873
874 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
875
876 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
877
878 * xfns.c (x_real_positions): Mark locals as initialized.
879
880 * xmenu.c (xmenu_show): Don't use uninitialized vars.
881
882 * xterm.c: Fix problems found by static analysis with other toolkits.
883 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
884 (x_dispatch_event): Declare static if USE_GTK, and
885 define if USE_GTK || USE_X_TOOLKIT.
886 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
887 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
888 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
889 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
890
891 * xmenu.c (menu_help_callback): Pointer type fixes.
892 Use const pointers when pointing at readonly data. Avoid pointer
893 signedness clashes.
894 (FALSE): Remove unused macro.
895 (update_frame_menubar): Remove unused decl.
896
897 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
898
899 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
900 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
901 (single_menu_item): Rename local to avoid shadowing.
902
903 * keyboard.c (make_lispy_event): Remove unused local var.
904
905 * frame.c, frame.h (x_get_resource_string): Bring this back, but
906 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
907
908 * bitmaps: Change bitmaps from unsigned char back to the X11
909 compatible char. Avoid the old compiler warnings about
910 out-of-range initializers by using, for example, '\xab' rather
911 than 0xab.
912
913 * xgselect.c (xgselect_initialize): Check vs interface
914 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
915
916 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
917
918 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
919 to read-only memory.
920
921 * fns.c (vector): Remove; this old hack is no longer needed.
922
923 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
924 Remove unused var.
925 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
926
927 * xrdb.c (x_load_resources): Omit unused local.
928
929 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
930 (x_window): Rename locals to avoid shadowing.
931 (USG): Use the kludged USG macro, to pacify gcc.
932
933 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
934 (x_term_init): Remove local to avoid shadowing.
935
936 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
937
938 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
939 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
940
941 2011-04-16 Eli Zaretskii <eliz@gnu.org>
942
943 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
944
945 Fix regex.c, syntax.c and friends for buffers > 2GB.
946 * syntax.h (struct gl_state_s): Declare character position members
947 EMACS_INT.
948
949 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
950
951 * textprop.c (verify_interval_modification, interval_of): Declare
952 arguments EMACS_INT.
953
954 * intervals.c (adjust_intervals_for_insertion): Declare arguments
955 EMACS_INT.
956
957 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
958
959 * indent.c (Fvertical_motion): Local variable it_start is now
960 EMACS_INT.
961
962 * regex.c (re_match, re_match_2, re_match_2_internal)
963 (bcmp_translate, regcomp, regexec, print_double_string)
964 (group_in_compile_stack, re_search, re_search_2, regex_compile)
965 (re_compile_pattern, re_exec): Declare arguments and local
966 variables `size_t' and `ssize_t' and return values `regoff_t', as
967 appropriate.
968 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
969 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
970 <compile_stack_type>: `size' and `avail' are now `size_t'.
971
972 * regex.h <regoff_t>: Use ssize_t, not int.
973 (re_search, re_search_2, re_match, re_match_2): Arguments that
974 specify buffer/string position and length are now ssize_t and
975 size_t. Return type is regoff_t.
976
977 2011-04-16 Ben Key <bkey76@gmail.com>
978
979 * nsfont.m: Fixed bugs in ns_get_family and
980 ns_descriptor_to_entity that were caused by using free to
981 deallocate memory blocks that were allocated by xmalloc (via
982 xstrdup). This caused Emacs to crash when compiled with
983 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
984 --enable-checking=xmallocoverrun). xfree is now used to
985 deallocate these memory blocks.
986
987 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
988
989 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
990
991 emacs_write: Accept and return EMACS_INT for sizes.
992 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
993 et seq.
994 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
995 Accept and return EMACS_INT.
996 (emacs_gnutls_write): Return the number of bytes written on
997 partial writes.
998 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
999 (emacs_read, emacs_write): Remove check for negative size, as the
1000 Emacs source code has been audited now.
1001 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1002 (emacs_read, emacs_write): Use it.
1003 * process.c (send_process): Adjust to the new signatures of
1004 emacs_write and emacs_gnutls_write. Do not attempt to store
1005 a byte offset into an 'int'; it might overflow.
1006 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1007
1008 * sound.c: Don't assume sizes fit in 'int'.
1009 (struct sound_device.period_size, alsa_period_size):
1010 Return EMACS_INT, not int.
1011 (struct sound_device.write, vox_write, alsa_write):
1012 Accept EMACS_INT, not int.
1013 (wav_play, au_play): Use EMACS_INT to store sizes and to
1014 record read return values.
1015
1016 2011-04-15 Ben Key <bkey76@gmail.com>
1017
1018 * keyboard.c (Qundefined): Don't declare static since it is used
1019 in nsfns.m.
1020 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1021 static since they are used in nsfont.m.
1022
1023 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1024
1025 * process.c (Qprocessp): Don't declare static.
1026 * lisp.h (Qprocessp): Declare again.
1027
1028 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
1029
1030 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1031
1032 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1033
1034 Improve C-level modularity by making more things 'static'.
1035
1036 Don't publish debugger-only interfaces to other modules.
1037 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1038 (verify_bytepos, count_markers): Move decls to the only modules
1039 that need them.
1040 * region-cache.h (pp_cache): Likewise.
1041 * window.h (check_all_windows): Likewise.
1042 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1043
1044 * sysdep.c (croak): Now static, if
1045 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1046 * syssignal.h (croak): Declare only if not static.
1047
1048 * alloc.c (refill_memory_reserve): Now static if
1049 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1050 * lisp.h (refill_memory_reserve): Declare only if not static.
1051
1052 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1053 Define only if USE_LUCID.
1054
1055 * xrdb.c (x_customization_string, x_rm_string): Now static.
1056
1057 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1058 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1059
1060 * xdisp.c (draw_row_with_mouse_face): Now static.
1061 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1062
1063 * window.h (check_all_windows): Mark externally visible.
1064
1065 * window.c (window_deletion_count): Now static.
1066
1067 * undo.c: Make symbols static if they're not exported.
1068 (last_undo_buffer, last_boundary_position, pending_boundary):
1069 Now static.
1070
1071 * textprop.c (interval_insert_behind_hooks): Now static.
1072 (interval_insert_in_front_hooks): Likewise.
1073
1074 * term.c: Make symbols static if they're not exported.
1075 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1076 (max_frame_lines, tty_set_terminal_modes):
1077 (tty_reset_terminal_modes, tty_turn_off_highlight):
1078 (get_tty_terminal): Now static.
1079 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1080 * termhooks.h (term_mouse_moveto): Do not declare if
1081 HAVE_WINDOW_SYSTEM.
1082 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1083 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1084
1085 * sysdep.c: Make symbols static if they're not exported.
1086 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1087 Now static.
1088 (sigprocmask_set, full_mask): Remove; unused.
1089 (wait_debugging): Mark as visible.
1090 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1091 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1092
1093 * syntax.c (syntax_temp): Define only if !__GNUC__.
1094
1095 * sound.c (current_sound_device, current_sound): Now static.
1096
1097 * search.c (searchbufs, searchbuf_head): Now static.
1098
1099 * scroll.c (scroll_cost): Remove; unused.
1100 * dispextern.h (scroll_cost): Remove decl.
1101
1102 * region-cache.h (pp_cache): Mark as externally visible.
1103
1104 * process.c: Make symbols static if they're not exported.
1105 (process_tick, update_tick, create_process, chan_process):
1106 (Vprocess_alist, proc_buffered_char, datagram_access):
1107 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1108 (deactivate_process): Mark defn as static, as well as decl.
1109 * lisp.h (create_process): Remove decl.
1110 * process.h (chan_process, Vprocess_alist): Remove decls.
1111
1112 * print.c: Make symbols static if they're not exported.
1113 (print_depth, new_backquote_output, being_printed, print_buffer):
1114 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1115 (print_interval, print_number_index, initial_stderr_stream):
1116 Now static.
1117 * lisp.h (Fprinc): Remove decl.
1118 (debug_output_compilation_hack): Mark as externally visible.
1119
1120 * sysdep.c (croak): Move decl from here to syssignal.h.
1121 * syssignal.h (croak): Put it here, so the API can be checked when
1122 'croak' is called from dissociate_if_controlling_tty.
1123
1124 * minibuf.c: Make symbols static if they're not exported.
1125 (minibuf_save_list, choose_minibuf_frame): Now static.
1126 * lisp.h (choose_minibuf_frame): Remove decl.
1127
1128 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1129
1130 * lread.c: Make symbols static if they're not exported.
1131 (read_objects, initial_obarray, oblookup_last_bucket_number):
1132 Now static.
1133 (make_symbol): Remove; unused.
1134 * lisp.h (initial_obarray, make_symbol): Remove decls.
1135
1136 * keyboard.c: Make symbols static if they're not exported.
1137 (single_kboard, recent_keys_index, total_keys, recent_keys):
1138 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1139 (this_single_command_key_start, echoing, last_auto_save):
1140 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1141 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1142 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1143 (Vlispy_mouse_stem, double_click_count):
1144 Now static.
1145 (force_auto_save_soon): Define only if SIGDANGER.
1146 (ignore_mouse_drag_p): Now static if
1147 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1148 (print_help): Remove; unused.
1149 (stop_character, last_timer_event): Mark as externally visible.
1150 * keyboard.h (ignore_mouse_drag_p): Declare only if
1151 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1152 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1153 * lisp.h (echoing): Remove decl.
1154 (force_auto_save_soon): Declare only if SIGDANGER.
1155 * xdisp.c (redisplay_window): Simplify code, to make it more
1156 obvious that ignore_mouse_drag_p is not accessed if !defined
1157 USE_GTK && !defined HAVE_NS.
1158
1159 * intervals.c: Make symbols static if they're not exported.
1160 (merge_properties_sticky, merge_interval_right, delete_interval):
1161 Now static.
1162 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1163
1164 * insdel.c: Make symbols static if they're not exported.
1165 However, leave prepare_to_modify_buffer alone. It's never
1166 called from outside this function, but that appears to be a bug.
1167 (combine_after_change_list, combine_after_change_buffer):
1168 (adjust_after_replace, signal_before_change): Now static.
1169 (adjust_after_replace_noundo): Remove; unused.
1170 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
1171 (signal_before_change): Remove decls.
1172
1173 * indent.c (val_compute_motion, val_vmotion): Now static.
1174
1175 * image.c: Make symbols static if they're not exported.
1176 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1177 if USE_GTK.
1178 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1179 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1180
1181 * fringe.c (standard_bitmaps): Now static.
1182 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1183
1184 * frame.c: Make symbols static if they're not exported.
1185 (x_report_frame_params, make_terminal_frame): Now static.
1186 (get_frame_param): Now static, unless HAVE_NS.
1187 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1188 (x_get_resource_string): Remove; not used.
1189 * frame.h (make_terminal_frame, x_report_frame_params):
1190 (x_get_resource_string); Remove decls.
1191 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1192 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1193
1194 * font.c, fontset.c: Make symbols static if they're not exported.
1195 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1196 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1197 * font.c (font_close_object): Now static.
1198 * font.h (font_close_object): Remove.
1199 * fontset.c (FONTSET_OBJLIST): Remove.
1200 (free_realized_fontset) #if-0 the body, which does nothing.
1201 (face_suitable_for_char_p): #if-0, as it's never called.
1202 * fontset.h (face_suitable_for_char_p): Remove decl.
1203 * xfaces.c (face_at_string_position): Use
1204 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1205 since 0 is always ASCII.
1206
1207 * fns.c (weak_hash_tables): Now static.
1208
1209 * fileio.c: Make symbols static if they're not exported.
1210 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1211 (Vwrite_region_annotation_buffers): Now static.
1212
1213 * eval.c: Make symbols static if they're not exported.
1214 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1215 * lisp.h (backtrace_list): Remove decl.
1216
1217 * emacs.c: Make symbols static if they're not exported.
1218 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1219 (fatal_error_code, fatal_error_signal_hook, standard_args):
1220 Now static.
1221 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1222 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1223 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1224 * lisp.h (fatal_error_signal_hook): Remove decl.
1225 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1226
1227 * editfns.c: Move a (normally-unused) function to its only use.
1228 * editfns.c, lisp.h (get_operating_system_release): Remove.
1229 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1230 worth the hassle of breaking this out.
1231
1232 * xterm.c: Make symbols static if they're not exported.
1233 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1234 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1235 (x_destroy_window, x_delete_display):
1236 Now static.
1237 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1238 (x_mouse_leave): Remove; unused.
1239 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1240 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1241 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1242 Remove decls.
1243 (x_mouse_leave): Declare only if WINDOWSNT.
1244 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1245 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1246 USE_X_TOOLKIT.
1247
1248 * ftxfont.c: Make symbols static if they're not exported.
1249 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1250 HAVE_FREETYPE.
1251 * font.h (ftxfont_driver): Likewise.
1252
1253 * xfns.c: Make symbols static if they're not exported.
1254 (x_last_font_name, x_display_info_for_name):
1255 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1256 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1257 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1258 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1259 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1260 (last_show_tip_args): Now static.
1261 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1262 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1263 (x_screen_planes): Remove; unused.
1264 * dispextern.h (x_screen_planes): Remove decl.
1265
1266 * dispnew.c: Make symbols static if they're not exported.
1267 * dispextern.h (redraw_garbaged_frames, scrolling):
1268 (increment_row_positions): Remove.
1269 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1270 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1271 Now static.
1272 (redraw_garbaged_frames): Remove; unused.
1273
1274 * xfaces.c: Make symbols static if they're not exported.
1275 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1276 Remove decls.
1277 * xterm.h (defined_color): Remove decls.
1278 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1279 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1280 (menu_face_changed_default, defined_color, free_realized_face):
1281 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1282 (ascii_face_of_lisp_face): Remove; unused.
1283
1284 * xdisp.c: Make symbols static if they're not exported.
1285 * dispextern.h (scratch_glyph_row, window_box_edges):
1286 (glyph_to_pixel_coords, set_cursor_from_row):
1287 (get_next_display_element, set_iterator_to_next):
1288 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1289 (show_mouse_face): Remove decls
1290 * frame.h (message_buf_print): Likewise.
1291 * lisp.h (pop_message, set_message, check_point_in_composition):
1292 Likewise.
1293 * xterm.h (set_vertical_scroll_bar): Likewise.
1294 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1295 (message_buf_print, scratch_glyph_row, displayed_buffer):
1296 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1297 (get_next_display_element, show_mouse_face, window_box_edges):
1298 (frame_to_window_pixel_xy, check_point_in_composition):
1299 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1300 (glyph_to_pixel_coords): Remove; unused.
1301
1302 * dired.c (file_name_completion): Now static.
1303
1304 * dbusbind.c (xd_in_read_queued_messages): Now static.
1305
1306 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1307 * data.c (circular_list_error): Remove.
1308
1309 * commands.h (last_point_position, last_point_position_buffer):
1310 (last_point_position_window): Remove decls.
1311 * keyboard.c: Make these variables static.
1312
1313 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
1314 decls.
1315 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1316 (iso_code_class, detect_coding, code_convert_region): Now static.
1317 (encode_coding_gap): Remove; unused.
1318
1319 * chartab.c (chartab_chars, chartab_bits): Now static.
1320
1321 * charset.h (charset_iso_8859_1): Remove decl.
1322 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1323 Now static.
1324
1325 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1326 * ccl.c (Vccl_program_table): Now static.
1327 (check_ccl_update): Remove; unused.
1328
1329 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1330 * category.h: ... from here.
1331 * category.c (check_category_table, set_category_set): Now static.
1332
1333 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1334 * lisp.h: Remove these decls.
1335
1336 * buffer.c (buffer_count): Remove unused var.
1337
1338 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1339 so that it's not optimized away.
1340 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1341 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1342 exported only to the debugger.
1343
1344 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1345 * atimer.h (run_all_atimers): Removed; not exported.
1346
1347 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1348 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1349 was inaccessible from Lisp.
1350 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1351 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1352
1353 alloc.c: Import and export fewer symbols, and remove unused items.
1354 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1355 is defined.
1356 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1357 it's not optimized away by whole-program optimization.
1358 (message_enable_multibyte, free_misc): Remove.
1359 (catchlist, handlerlist, mark_backtrace):
1360 Declare only if BYTE_MARK_STACK.
1361 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1362 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1363 (message_enable_multibyte): Remove decl.
1364 (free_misc, interval_free_list, float_block, float_block_index):
1365 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1366 (cons_free_list, last_marked_index):
1367 Now static.
1368 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1369 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1370 (mark_backtrace): Define only if BYTE_MARK_STACK.
1371 * xdisp.c (message_enable_multibyte): Now static.
1372
1373 Declare Lisp_Object Q* variables to be 'static' if not exported.
1374 This makes it easier for human readers (and static analyzers)
1375 to see whether these variables are used from other modules.
1376 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1377 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1378 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1379 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1380 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1381 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1382 * xmenu.c, xselect.c:
1383 Declare Q* vars static if they are not used in other modules.
1384 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1385 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1386 Remove decls of unexported vars.
1387 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1388
1389 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1390
1391 Make Emacs functions such as Fatom 'static' by default.
1392 This makes it easier for human readers (and static analyzers)
1393 to see whether these functions can be called from other modules.
1394 DEFUN now defines a static function. To make the function external
1395 so that it can be used in other C modules, use the new macro DEFUE.
1396 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1397 (Finit_image_library):
1398 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1399 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1400 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1401 Remove decls, since these functions are now static.
1402 (Funintern, Fget_internal_run_time): New decls, since these functions
1403 were already external.
1404
1405 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1406 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1407 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1408 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1409 * keyboard.c, keymap.c, lread.c:
1410 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1411 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1412 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1413 Mark functions with DEFUE instead of DEFUN,
1414 if they are used in other modules.
1415 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1416 decls for now-static functions.
1417 * buffer.h (Fdelete_overlay): Remove decl.
1418 * callproc.c (Fgetenv_internal): Mark as internal.
1419 * composite.c (Fremove_list_of_text_properties): Remove decl.
1420 (Fcomposition_get_gstring): New forward static decl.
1421 * composite.h (Fcomposite_get_gstring): Remove decl.
1422 * dired.c (Ffile_attributes): New forward static decl.
1423 * doc.c (Fdocumntation_property): New forward static decl.
1424 * eval.c (Ffetch_bytecode): New forward static decl.
1425 (Funintern): Remove extern decl; now in .h file where it belongs.
1426 * fileio.c (Fmake_symbolic_link): New forward static decl.
1427 * image.c (Finit_image_library): New forward static decl.
1428 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1429 * intervals.h (Fprevious_property_change):
1430 (Fremove_list_of_text_properties): Remove decls.
1431 * keyboard.c (Fthis_command_keys): Remove decl.
1432 (Fcommand_execute): New forward static decl.
1433 * keymap.c (Flookup_key): New forward static decl.
1434 (Fcopy_keymap): Now static.
1435 * keymap.h (Flookup_key): Remove decl.
1436 * process.c (Fget_process): New forward static decl.
1437 (Fprocess_datagram_address): Mark as internal.
1438 * syntax.c (Fsyntax_table_p): New forward static decl.
1439 (skip_chars): Remove duplicate decl.
1440 * textprop.c (Fprevious_property_change): New forward static decl.
1441 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1442 Now internal.
1443 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1444 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1445
1446 * editfns.c (Fformat): Remove unreachable code.
1447
1448 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1449
1450 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1451 change. (Bug#8496)
1452
1453 2011-04-13 Eli Zaretskii <eliz@gnu.org>
1454
1455 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1456 when at ZV. (Bug#8487)
1457
1458 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1459
1460 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1461 (Bug#8437)
1462 * keyboard.c (parse_tool_bar_item): Likewise.
1463 * sound.c (sound_cleanup, alsa_close): Likewise.
1464 * termcap.c (tgetent): Likewise.
1465 * xfns.c (x_default_font_parameter): Likewise.
1466 * xsettings.c (read_and_apply_settings): Likewise.
1467
1468 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1469 (overrun_check_free): Protoize.
1470
1471 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1472
1473 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1474 since callers should never pass a negative size.
1475 Change the signature to match that of plain 'read' and 'write'; see
1476 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1477 * lisp.h: Update prototypes of emacs_write and emacs_read.
1478
1479 2011-04-11 Eli Zaretskii <eliz@gnu.org>
1480
1481 * xdisp.c (redisplay_window): Don't try to determine the character
1482 position of the scroll margin if the window start point w->startp
1483 is outside the buffer's accessible region. (Bug#8468)
1484
1485 2011-04-10 Eli Zaretskii <eliz@gnu.org>
1486
1487 Fix write-region and its subroutines for buffers > 2GB.
1488 * fileio.c (a_write, e_write): Modify declaration of arguments and
1489 local variables to support buffers larger than 2GB.
1490 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1491
1492 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1493 argument, local variables, and return value.
1494
1495 * lisp.h: Update prototypes of emacs_write and emacs_read.
1496
1497 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1498
1499 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
1500
1501 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1502
1503 Fix more problems found by GCC 4.6.0's static checks.
1504
1505 * xdisp.c (vmessage): Use a better test for character truncation.
1506
1507 * charset.c (load_charset_map): <, not <=, for optimization,
1508 and to avoid potential problems with integer overflow.
1509 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
1510 * casetab.c (set_identity, shuffle): Likewise.
1511 * editfns.c (Fformat): Likewise.
1512 * syntax.c (skip_chars): Likewise.
1513
1514 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1515 This also lets GCC 4.6.0 generate slightly better loop code.
1516
1517 * callint.c (Fcall_interactively): <, not <=, for optimization.
1518 (Fcall_interactively): Count the number of arguments produced,
1519 not the number of arguments given. This is simpler and lets GCC
1520 4.6.0 generate slightly better code.
1521
1522 * ftfont.c: Distingish more carefully between FcChar8 and char.
1523 The previous code passed unsigned char * to a functions like
1524 strlen and xstrcasecmp that expect char *, which does not
1525 conform to the C standard.
1526 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1527 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1528 char * when the C standard requires it.
1529
1530 * keyboard.c (read_char): Remove unused var.
1531
1532 * eval.c: Port to Windows vsnprintf (Bug#8435).
1533 Include <limits.h>.
1534 (SIZE_MAX): Define if the headers do not.
1535 (verror): Do not give up if vsnprintf returns a negative count.
1536 Instead, grow the buffer. This ports to Windows vsnprintf, which
1537 does not conform to C99. Problem reported by Eli Zaretskii.
1538 Also, simplify the allocation scheme, by avoiding the need for
1539 calling realloc, and removing the ALLOCATED variable.
1540
1541 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1542
1543 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1544 But keep the doprint source code for now, as we might revamp it
1545 and use it again (Bug#8435).
1546 * lisp.h (doprnt): Remove.
1547 * Makefile.in (base_obj): Remove doprnt.o.
1548 * deps.mk (doprnt.o): Remove.
1549
1550 error: Print 32- and 64-bit integers portably (Bug#8435).
1551 Without this change, on typical 64-bit hosts error ("...%d...", N)
1552 was used to print both 32- and 64-bit integers N, which relied on
1553 undefined behavior.
1554 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1555 New macro.
1556 * lisp.h (error, verror): Mark as printf-like functions.
1557 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1558 Report overflow in size calculations when allocating printf buffer.
1559 Do not truncate output string at its first null byte.
1560 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1561 Truncate the output at a character boundary, since vsnprintf does not
1562 do that.
1563 * charset.c (check_iso_charset_parameter): Convert internal
1564 character to string before calling 'error', since %c now has the
1565 printf meaning.
1566 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1567 overflow when computing char to be passed to 'error'. Do not
1568 pass Lisp_Object to 'error'; pass the integer instead.
1569 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1570 formatted with plain %d.
1571
1572 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1573
1574 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1575
1576 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1577
1578 * xterm.c (x_catch_errors): Remove duplicate declaration.
1579
1580 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1581
1582 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1583
1584 2011-04-10 Jim Meyering <meyering@redhat.com>
1585
1586 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1587 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1588 return ssize_t not "int", and use size_t as the buffer length.
1589 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1590 * gnutls.h: Update declarations.
1591 * process.c (read_process_output): Use ssize_t, to match.
1592 (send_process): Likewise.
1593
1594 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1595
1596 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1597
1598 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1599
1600 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1601 unsigned char, to match FcChar8 type definition.
1602
1603 * xterm.c (handle_one_xevent):
1604 * xmenu.c (create_and_show_popup_menu):
1605 * xselect.c (x_decline_selection_request)
1606 (x_reply_selection_request): Avoid type-punned deref of X events.
1607
1608 2011-04-09 Eli Zaretskii <eliz@gnu.org>
1609
1610 Fix some uses of `int' instead of EMACS_INT.
1611 * search.c (string_match_1, fast_string_match)
1612 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1613 (scan_buffer, find_next_newline_no_quit)
1614 (find_before_next_newline, search_command, Freplace_match)
1615 (Fmatch_data): Make some `int' variables be EMACS_INT.
1616
1617 * xdisp.c (display_count_lines): 3rd argument and return value now
1618 EMACS_INT. All callers changed.
1619 (pint2hrstr): Last argument is now EMACS_INT.
1620
1621 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1622 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1623 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1624 (decode_coding_utf_16, decode_coding_emacs_mule)
1625 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1626 (decode_coding_ccl, decode_coding_charset)
1627 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1628 (decode_coding_iso_2022, decode_coding_emacs_mule)
1629 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1630 <char_offset, last_offset>: Declare EMACS_INT.
1631 (encode_coding_utf_8, encode_coding_utf_16)
1632 (encode_coding_emacs_mule, encode_invocation_designation)
1633 (encode_designation_at_bol, encode_coding_iso_2022)
1634 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1635 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1636 Declare EMACS_INT.
1637 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1638 (encode_invocation_designation): Last argument P_NCHARS is now
1639 EMACS_INT.
1640 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1641 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1642
1643 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1644 All users changed.
1645
1646 * ccl.c (Fccl_execute_on_string): Declare some variables
1647 EMACS_INT.
1648
1649 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
1650
1651 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1652
1653 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1654
1655 * process.c (Fformat_network_address): Doc fix.
1656
1657 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1658
1659 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1660
1661 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
1662
1663 * keyboard.c (read_char): Call Lisp function help-form-show,
1664 instead of using internal_with_output_to_temp_buffer.
1665 (Qhelp_form_show): New var.
1666 (syms_of_keyboard): Use DEFSYM macro.
1667
1668 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1669
1670 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1671
1672 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
1673
1674 * process.c (Flist_processes): Removed to Lisp.
1675 (list_processes_1): Deleted.
1676
1677 2011-04-06 Eli Zaretskii <eliz@gnu.org>
1678
1679 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1680
1681 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1682
1683 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
1684
1685 Fix more problems found by GCC 4.6.0's static checks.
1686
1687 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1688
1689 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1690
1691 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1692
1693 * xdisp.c (vmessage): Mark as a printf-like function.
1694
1695 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1696
1697 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1698
1699 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1700 printf-like functions.
1701 (tiff_load): Add casts to remove these marks before passing them
1702 to system-supplied API.
1703
1704 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1705
1706 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1707 This avoids several warnings with gcc -Wstrict-overflow.
1708 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1709 directly, rather than having caller test rule sign. This avoids
1710 some unnecessary tests.
1711 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1712 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1713 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
1714
1715 * xfont.c (xfont_text_extents): Remove var that was set but not used.
1716 (xfont_open): Avoid unnecessary tests.
1717
1718 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1719
1720 * composite.h, composite.c (composition_gstring_put_cache):
1721 Use EMACS_INT, not int, for length.
1722
1723 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1724 breaking out part of COMPOSITION_DECODE_RULE.
1725 (COMPOSITION_DECODE_RULE): Use it.
1726 * composite.c (get_composition_id): Remove unused local vars,
1727 by using the new macro.
1728
1729 * textprop.c (set_text_properties_1): Change while to do-while,
1730 since the condition is always true at first.
1731
1732 * intervals.c (graft_intervals_into_buffer): Mark var as used.
1733 (interval_deletion_adjustment): Return unsigned value.
1734 All uses changed.
1735
1736 * process.c (list_processes_1, create_pty, read_process_output):
1737 (exec_sentinel): Remove vars that were set but not used.
1738 (create_pty): Remove unnecessary "volatile"s.
1739 (Fnetwork_interface_info): Avoid possibility of int overflow.
1740 (read_process_output): Do adaptive read buffering even if carryover.
1741 (read_process_output): Simplify nbytes computation if buffered.
1742
1743 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1744
1745 * syntax.c (scan_words): Remove var that was set but not used.
1746 (update_syntax_table): Use unsigned instead of int.
1747
1748 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
1749 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
1750 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
1751
1752 * print.c (print_error_message): Avoid int overflow.
1753
1754 * font.c (font_list_entities): Redo for clarity,
1755 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1756
1757 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
1758 (font_score): Avoid potential overflow in diff calculation.
1759
1760 * fns.c (substring_both): Remove var that is set but not used.
1761 (sxhash): Redo loop for clarity and to avoid wraparound warning.
1762
1763 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1764
1765 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1766 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1767 can always succeed if overflow has undefined behavior.
1768
1769 * search.c (boyer_moore, wordify): Remove vars set but not used.
1770 (wordify): Omit three unnecessary tests.
1771
1772 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1773 All callers changed. This avoids the need for an unused var.
1774
1775 * casefiddle.c (casify_region): Remove var that is set but not used.
1776
1777 * dired.c (file_name_completion): Remove var that is set but not used.
1778
1779 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1780
1781 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
1782 (Finsert_file_contents): Remove unnecessary code checking fd.
1783
1784 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1785 Check for integer overflow on size calculations.
1786
1787 * buffer.c (Fprevious_overlay_change): Remove var that is set
1788 but not used.
1789
1790 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1791 Remove vars that are set but not used.
1792 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
1793 (timer_check_2): Mark vars as initialized.
1794
1795 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1796
1797 * image.c (lookup_image): Remove var that is set but not used.
1798 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
1799
1800 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1801 that are set but not used.
1802
1803 * xfns.c (make_invisible_cursor): Don't return garbage
1804 if XCreateBitmapFromData fails (Bug#8410).
1805
1806 * xselect.c (x_get_local_selection, x_handle_property_notify):
1807 Remove vars that are set but not used.
1808
1809 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
1810 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
1811
1812 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1813 Remove var that is set but not used.
1814 (scroll_bar_windows_size): Now size_t, not int.
1815 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1816 Check for overflow.
1817
1818 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1819 (map_tty_color) [!defined MSDOS]: Likewise.
1820
1821 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1822
1823 * coding.c: Remove vars that are set but not used.
1824 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1825 All callers changed.
1826 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1827 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1828 (decode_coding_charset): Remove vars that are set but not used.
1829
1830 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1831 that is set but not used.
1832
1833 * print.c (print_object): Remove var that is set but not used.
1834
1835 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
1836 The gnulib version avoids calling malloc in the usual case,
1837 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1838 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1839 * filelock.c (current_lock_owner): Likewise.
1840 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1841 * sysdep.c: Include allocator.h, careadlinkat.h.
1842 (emacs_no_realloc_allocator): New static constant.
1843 (emacs_readlink): New function.
1844 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1845 ../lib/careadlinkat.h.
1846
1847 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1848
1849 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1850 first non-nil return value).
1851
1852 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1853
1854 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1855 if not defined (Bug#8403).
1856
1857 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1858
1859 * xdisp.c (display_count_lines): Remove parameter `start',
1860 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1861 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1862 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1863 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1864 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1865 and thereabouts. All callers changed.
1866 (get_per_char_metric): Remove parameter `f', unused since
1867 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1868
1869 2011-04-02 Jim Meyering <meyering@redhat.com>
1870
1871 do not dereference NULL upon failed strdup
1872 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1873 (ns_get_family): Likewise.
1874
1875 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1876
1877 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1878
1879 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1880
1881 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1882 later (Bug#8403).
1883
1884 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1885
1886 Add lexical binding.
1887
1888 * window.c (Ftemp_output_buffer_show): New fun.
1889 (Fsave_window_excursion):
1890 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1891
1892 * lread.c (lisp_file_lexically_bound_p): New function.
1893 (Fload): Bind Qlexical_binding.
1894 (readevalloop): Remove `evalfun' arg.
1895 Bind Qinternal_interpreter_environment.
1896 (Feval_buffer): Bind Qlexical_binding.
1897 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1898 Mark as dynamic.
1899 (syms_of_lread): Declare `lexical-binding'.
1900
1901 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1902
1903 * keyboard.c (eval_dyn): New fun.
1904 (menu_item_eval_property): Use it.
1905
1906 * image.c (parse_image_spec): Use Ffunctionp.
1907
1908 * fns.c (concat, mapcar1): Accept byte-code-functions.
1909
1910 * eval.c (Fsetq): Handle lexical vars.
1911 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1912 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1913 (FletX, Flet): Obey lexical binding.
1914 (Fcommandp): Handle closures.
1915 (Feval): New `lexical' arg.
1916 (eval_sub): New function extracted from Feval. Use it almost
1917 everywhere where Feval was used. Look up vars in lexical env.
1918 Handle closures.
1919 (Ffunctionp): Move from subr.el.
1920 (Ffuncall): Handle closures.
1921 (apply_lambda): Remove `eval_flags'.
1922 (funcall_lambda): Handle closures and new byte-code-functions.
1923 (Fspecial_variable_p): New function.
1924 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1925 but without exporting it to Lisp.
1926
1927 * doc.c (Fdocumentation, store_function_docstring):
1928 * data.c (Finteractive_form): Handle closures.
1929
1930 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1931 interactive spec.
1932
1933 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1934 byte-codes.
1935 (exec_byte_code): New function extracted from Fbyte_code to handle new
1936 calling convention for byte-code-functions. Add new byte-codes.
1937
1938 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
1939
1940 * alloc.c (Fmake_symbol): Init new `declared_special' field.
1941
1942 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1943
1944 * xdisp.c (redisplay_internal): Fix prototype.
1945
1946 2011-03-31 Eli Zaretskii <eliz@gnu.org>
1947
1948 * xdisp.c (SCROLL_LIMIT): New macro.
1949 (try_scrolling): Use it when setting scroll_limit. Limit
1950 scrolling to 100 screen lines.
1951 (redisplay_window): Even when falling back on "recentering",
1952 position point in the window according to scroll-conservatively,
1953 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1954
1955 (try_scrolling): When point is above the window, allow searching
1956 as far as scroll_max, or one screenful, to compute vertical
1957 distance from PT to the scroll margin position. This prevents
1958 try_scrolling from unnecessarily failing when
1959 scroll-conservatively is set to a value slightly larger than the
1960 window height. Clean up the case of PT below the margin at bottom
1961 of window: scroll_max can no longer be INT_MAX. When aggressive
1962 scrolling is in use, don't let point enter the opposite scroll
1963 margin as result of the scroll.
1964 (syms_of_xdisp) <scroll-conservatively>: Document the
1965 threshold of 100 lines for never-recentering scrolling.
1966
1967 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1968
1969 * dispextern.h (move_it_by_lines):
1970 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1971 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1972 (message_log_check_duplicate): Remove parameters `prev_bol' and
1973 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1974 (redisplay_internal): Remove parameter `preserve_echo_area',
1975 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1976
1977 * indent.c (Fvertical_motion):
1978 * window.c (window_scroll_pixel_based, Frecenter):
1979 Don't pass `need_y_p' to `move_it_by_lines'.
1980
1981 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1982
1983 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1984 steal a few bits to be more compact.
1985 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1986 Remove unneeded casts.
1987
1988 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1989
1990 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1991
1992 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1993 binding" message (bug#7967).
1994
1995 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1996
1997 Fix more problems found by GCC 4.6.0's static checks.
1998
1999 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2000 Remove unused local var.
2001
2002 * editfns.c (Fmessage_box): Remove unused local var.
2003
2004 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2005 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2006 Omit unused local vars.
2007 * window.c (shrink_windows): Omit unused local var.
2008 * menu.c (digest_single_submenu): Omit unused local var.
2009 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2010 Omit unused local var.
2011
2012 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2013 Don't assume string length fits in int.
2014 (keyremap_step, read_key_sequence): Use size_t for sizes.
2015 (read_key_sequence): Don't check last_real_key_start redundantly.
2016
2017 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2018 instead of alloca (Bug#8344).
2019
2020 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2021 (Fbacktrace_frame): Don't assume nframes fits in int.
2022
2023 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2024
2025 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2026 concerns.
2027
2028 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2029
2030 * cm.c (calccost): Turn while-do into do-while, for clarity.
2031
2032 * keyboard.c (syms_of_keyboard): Use the same style as later
2033 in this function when indexing through an array. This also
2034 works around GCC bug 48267.
2035
2036 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2037
2038 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2039
2040 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2041 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2042
2043 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2044 This avoids undefined behavior on integer overflow, and is a bit
2045 more convenient anyway since it is compared to a size_t variable.
2046
2047 Variadic C functions now count arguments with size_t, not int.
2048 This avoids an unnecessary limitation on 64-bit machines, which
2049 caused (substring ...) to crash on large vectors (Bug#8344).
2050 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2051 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
2052 All variadic functions and their callers changed accordingly.
2053 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2054 * data.c (arith_driver, float_arith_driver): Likewise.
2055 * editfns.c (general_insert_function): Likewise.
2056 * eval.c (struct backtrace.nargs, interactive_p)
2057 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2058 (funcall_lambda, mark_backtrace): Likewise.
2059 * fns.c (concat): Likewise.
2060 * frame.c (x_set_frame_parameters): Likewise.
2061 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2062 0 if not found, not -1. All callers changed.
2063
2064 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2065 (stack_copy_size): Now size_t, not int.
2066 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2067
2068 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2069
2070 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2071 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2072 All callers changed.
2073
2074 * lisp.h (multibyte_char_to_unibyte):
2075 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2076 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2077 * character.h (CHAR_TO_BYTE8):
2078 * cmds.c (internal_self_insert):
2079 * editfns.c (general_insert_function):
2080 * keymap.c (push_key_description):
2081 * search.c (Freplace_match):
2082 * xdisp.c (message_dolog, set_message_1): All callers changed.
2083
2084 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2085
2086 * keyboard.c (safe_run_hook_funcall): New function.
2087 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2088 don't set the hook to nil, but remove the offending function instead.
2089 (Qcommand_hook_internal): Remove, unused.
2090 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2091 Vcommand_hook_internal.
2092
2093 * eval.c (enum run_hooks_condition): Remove.
2094 (funcall_nil, funcall_not): New functions.
2095 (run_hook_with_args): Call each function through a `funcall' argument.
2096 Remove `cond' argument, now redundant.
2097 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2098 (Frun_hook_with_args_until_failure): Adjust accordingly.
2099 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2100
2101 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2102
2103 * dispextern.h (string_buffer_position): Remove declaration.
2104
2105 * print.c (strout): Remove parameter `multibyte', unused since
2106 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2107
2108 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2109 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2110 All callers changed.
2111
2112 * w32.c (_wsa_errlist): Use braces for struct initializers.
2113
2114 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2115 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2116 All callers changed.
2117 (string_buffer_position): Likewise. Also, make static (it's never
2118 used outside xdisp.c).
2119 (cursor_row_p): Remove parameter `w', unused since
2120 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2121 (decode_mode_spec): Remove parameter `precision', introduced during
2122 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2123 All callers changed.
2124
2125 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2126
2127 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2128
2129 2011-03-27 Anders Lindgren <andlind@gmail.com>
2130
2131 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2132 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2133 (ns_update_auto_hide_menu_bar): New functions.
2134 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2135 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2136 ns_constrain_all_frames.
2137 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2138 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2139
2140 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2141
2142 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2143
2144 2011-03-27 Glenn Morris <rgm@gnu.org>
2145
2146 * syssignal.h: Replace RETSIGTYPE with void.
2147 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2148 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2149 Replace SIGTYPE with void everywhere.
2150 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2151 * s/template.h (SIGTYPE): Remove commented out definition.
2152
2153 2011-03-26 Eli Zaretskii <eliz@gnu.org>
2154
2155 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2156 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2157
2158 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
2159
2160 * w32.c (read_unc_volume): Use parameter `henum', instead of
2161 global variable `wget_enum_handle'.
2162
2163 * keymap.c (describe_vector): Remove parameters `indices' and
2164 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2165 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2166
2167 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2168
2169 * keyboard.c (timer_check): Remove parameter `do_it_now',
2170 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2171 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2172 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2173
2174 * keyboard.c (read_char):
2175 * w32menu.c (w32_menu_display_help):
2176 * xmenu.c (show_help_event, menu_help_callback):
2177 Adjust calls to `show_help_echo'.
2178
2179 * gtkutil.c (xg_maybe_add_timer):
2180 * keyboard.c (readable_events):
2181 * process.c (wait_reading_process_output):
2182 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2183
2184 * insdel.c (adjust_markers_gap_motion):
2185 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2186 (gap_left, gap_right): Don't call it.
2187
2188 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
2189
2190 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2191 incurred during fontification.
2192
2193 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2194
2195 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2196 (DEFVAR_PER_BUFFER): Don't pass it.
2197
2198 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2199 (scrolling_window): Don't pass it.
2200
2201 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2202
2203 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2204
2205 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2206 and `suffix'.
2207 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2208 of variables specific to SELinux and computation of `encoded_absname'.
2209
2210 * image.c (XPutPixel): Remove unused variable `height'.
2211
2212 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2213
2214 * unexw32.c (get_section_info): Remove unused variable `section'.
2215
2216 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2217 (system_process_attributes): Remove unused variable `sess'.
2218 (sys_read): Remove unused variable `err'.
2219
2220 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2221 (w32_wnd_proc): Remove unused variable `isdead'.
2222 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2223 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2224 (x_create_tip_frame): Remove unused variable `tem'.
2225
2226 * w32inevt.c (w32_console_read_socket):
2227 Remove unused variable `no_events'.
2228
2229 * w32term.c (x_draw_composite_glyph_string_foreground):
2230 Remove unused variable `width'.
2231
2232 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
2233
2234 * w32term.c (x_set_glyph_string_clipping):
2235 Don't pass uninitialized region to CombineRgn.
2236
2237 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
2238
2239 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2240 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2241 (Fx_close_connection): Remove unused variable `i'.
2242
2243 * w32font.c (w32font_draw): Return number of glyphs.
2244 (w32font_open_internal): Remove unused variable `i'.
2245 (w32font_driver): Add missing initializer.
2246
2247 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2248 (fill_in_menu): Remove unused variable `items_added'.
2249
2250 * w32term.c (last_mouse_press_frame): Remove static global variable.
2251 (w32_clip_to_row): Remove unused variable `f'.
2252 (x_delete_terminal): Remove unused variable `i'.
2253
2254 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2255 (NOTHING): Remove unused static global variable.
2256 (uniscribe_check_otf): Remove unused variable `table'.
2257 (uniscribe_font_driver): Add missing initializers.
2258
2259 2011-03-23 Julien Danjou <julien@danjou.info>
2260
2261 * term.c (Fsuspend_tty, Fresume_tty):
2262 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2263 * window.c (temp_output_buffer_show):
2264 * insdel.c (signal_before_change):
2265 * frame.c (Fhandle_switch_frame):
2266 * fileio.c (Fdo_auto_save):
2267 * emacs.c (Fkill_emacs):
2268 * editfns.c (save_excursion_restore):
2269 * cmds.c (internal_self_insert):
2270 * callint.c (Fcall_interactively):
2271 * buffer.c (Fkill_all_local_variables):
2272 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2273 Use Frun_hooks.
2274 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
2275 unconditionnaly since it does the check itself.
2276
2277 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
2278
2279 Fix more problems found by GCC 4.5.2's static checks.
2280
2281 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2282 the first time through the loop, since we know p0 < p1 then.
2283 This also avoids a gcc -Wstrict-overflow warning.
2284
2285 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2286 leading to a memory leak, possible in functions like
2287 load_charset_map_from_file that can allocate an unbounded number
2288 of objects (Bug#8318).
2289
2290 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2291 that could (at least in theory) be that large.
2292
2293 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2294 This is less likely to overflow, and avoids undefined behavior if
2295 overflow does occur. All callers changed. Use strtoul to scan
2296 for the unsigned long integer.
2297 (pint2hrstr): Simplify and tune code slightly.
2298 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
2299
2300 * scroll.c (do_scrolling): Work around GCC bug 48228.
2301 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2302
2303 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2304 This also avoids a warning with gcc -Wstrict-overflow.
2305 (validate_x_resource_name): Simplify count usage.
2306 This also avoids a warning with gcc -Wstrict-overflow.
2307
2308 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2309 fail (Bug#8306).
2310
2311 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
2312
2313 * process.c (Fmake_network_process): Use socklen_t, not int,
2314 where POSIX says socklen_t is required in portable programs.
2315 This fixes a porting bug on hosts like 64-bit HP-UX, where
2316 socklen_t is wider than int (Bug#8277).
2317 (Fmake_network_process, server_accept_connection):
2318 (wait_reading_process_output, read_process_output):
2319 Likewise.
2320
2321 * process.c: Rename or move locals to avoid shadowing.
2322 (list_processes_1, Fmake_network_process):
2323 (read_process_output_error_handler, exec_sentinel_error_handler):
2324 Rename or move locals.
2325 (Fmake_network_process): Define label "retry_connect" only if needed.
2326 (Fnetwork_interface_info): Fix pointer signedness.
2327 (process_send_signal): Add cast to avoid pointer signedness problem.
2328 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
2329 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
2330
2331 Make tparam.h and terminfo.c consistent.
2332 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2333 Include tparam.h instead, since it declares them.
2334 * cm.h (PC): Remove extern decl; tparam.h now does this.
2335 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2336 * terminfo.c: Include tparam.h, to check interfaces.
2337 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2338 (tparam): Adjust signature to match interface in tparam.h;
2339 this removes some undefined behavior. Check that outstring and len
2340 are zero, which they always are with Emacs.
2341 * tparam.h (PC, BC, UP): New extern decls.
2342
2343 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
2344 (xftfont_open): Rename locals to avoid shadowing.
2345
2346 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
2347 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2348 (OTF_TAG_SYM): Omit macro if not needed.
2349 (ftfont_list): Remove unused local.
2350 (get_adstyle_property, ftfont_pattern_entity):
2351 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2352 Rename locals to avoid shadowing.
2353
2354 * xfont.c (xfont_list_family): Mark var as initialized.
2355
2356 * xml.c (make_dom): Now static.
2357
2358 * composite.c (composition_compute_stop_pos): Rename local to
2359 avoid shadowing.
2360 (composition_reseat_it): Remove unused locals.
2361 (find_automatic_composition, composition_adjust_point): Likewise.
2362 (composition_update_it): Mark var as initialized.
2363 (find_automatic_composition): Mark vars as initialized,
2364 with a FIXME (Bug#8290).
2365
2366 character.h: Rename locals to avoid shadowing.
2367 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2368 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2369 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2370 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2371 to avoid shadowing.
2372
2373 * textprop.c (property_change_between_p): Remove; unused.
2374
2375 * intervals.c (interval_start_pos): Now static.
2376
2377 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2378
2379 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2380 Rename locals to avoid shadowing.
2381
2382 * sound.c (wav_play, au_play, Fplay_sound_internal):
2383 Fix pointer signedness.
2384 (alsa_choose_format): Remove unused local var.
2385 (wav_play): Initialize a variable to 0, to prevent undefined
2386 behavior (Bug#8278).
2387
2388 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2389
2390 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2391
2392 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2393 clobbering (Bug#8298).
2394 * sysdep.c (sys_subshell): Likewise.
2395 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
2396
2397 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2398 This should get cleaned up, so that child_setup has the
2399 same signature on all platforms.
2400
2401 * callproc.c (call_process_cleanup): Now static.
2402 (relocate_fd): Rename locals to avoid shadowing.
2403
2404 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
2405
2406 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2407 not to be necessary, and produces flickering.
2408
2409 2011-03-20 Glenn Morris <rgm@gnu.org>
2410
2411 * config.in: Remove file.
2412
2413 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
2414
2415 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2416 are now in src/globals.h.
2417 (syms_of_minibuf): Remove spurious & from previous change.
2418
2419 2011-03-20 Leo <sdl.web@gmail.com>
2420
2421 * minibuf.c (completing-read-function): New variable.
2422 (completing-read-default): Rename from completing-read.
2423 (completing-read): Call completing-read-function.
2424
2425 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2426
2427 * xfaces.c (Fx_load_color_file):
2428 Read color file from absolute filename (bug#8250).
2429
2430 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2431
2432 * makefile.w32-in: Update dependencies.
2433
2434 2011-03-17 Eli Zaretskii <eliz@gnu.org>
2435
2436 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2437
2438 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2439
2440 Fix more problems found by GCC 4.5.2's static checks.
2441
2442 * process.c (make_serial_process_unwind, send_process_trap):
2443 (sigchld_handler): Now static.
2444
2445 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2446 That way, the code declares only the vars that it needs.
2447 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2448 * s/cygwin.h (PTY_ITERATION): Likewise.
2449 * s/darwin.h (PTY_ITERATION): Likewise.
2450 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2451
2452 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2453 * process.c (allocate_pty): Don't declare stb unless it's needed.
2454
2455 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
2456 (CONSTANTLIM): Remove; unused.
2457 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2458 Define only if needed.
2459
2460 * unexelf.c (unexec): Name an expression,
2461 to avoid gcc -Wbad-function-cast warning.
2462 Use a different way to cause a compilation error if anyone uses
2463 n rather than nn, a way that does not involve shadowing.
2464 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
2465
2466 * deps.mk (unexalpha.o): Remove; unused.
2467
2468 New file unexec.h, the (simple) interface for unexec (Bug#8267).
2469 * unexec.h: New file.
2470 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2471 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2472 Depend on unexec.h.
2473 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2474 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2475 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
2476 Change as necessary to match prototype in unexec.h.
2477
2478 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2479 shadowing.
2480 (back_comment, skip_chars): Mark vars as initialized.
2481
2482 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2483 Rename locals to avoid shadowing.
2484
2485 * lread.c (read1): Rewrite so as not to use empty "else".
2486 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
2487
2488 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2489
2490 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2491 warning when compiling print.c.
2492
2493 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2494 instead of using an uninitialized var.
2495 (font_sort_entities): Mark var as initialized.
2496
2497 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2498
2499 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2500 pointers to constants.
2501 (font_parse_fcname): Remove unused vars.
2502 (font_delete_unmatched): Now static.
2503 (font_get_spec): Remove; unused.
2504 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2505 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2506 Rename or move locals to avoid shadowing.
2507
2508 * fns.c (require_nesting_list, require_unwind): Now static.
2509 (Ffillarray): Rename locals to avoid shadowing.
2510
2511 * floatfns.c (domain_error2): Define only if needed.
2512 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
2513
2514 * alloc.c (mark_backtrace): Move decl from here ...
2515 * lisp.h: ... to here, so that it can be checked.
2516
2517 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
2518 (Fdefvar): Rewrite so as not to use empty "else".
2519 (lisp_indirect_variable): Name an expression,
2520 to avoid gcc -Wbad-function-cast warning.
2521 (Fdefvar): Rename locals to avoid shadowing.
2522
2523 * callint.c (quotify_arg, quotify_args): Now static.
2524 (Fcall_interactively): Rename locals to avoid shadowing.
2525 Use const pointer when appropriate.
2526
2527 * lisp.h (get_system_name, get_operating_system_release):
2528 Move decls here, to check interfaces.
2529 * process.c (get_operating_system_release): Move decl to lisp.h.
2530 * xrdb.c (get_system_name): Likewise.
2531 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2532 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2533 some of which prompt warnings from gcc -Wbad-function-cast.
2534 (Fformat_time_string, Fencode_time, Finsert_char):
2535 (Ftranslate_region_internal, Fformat):
2536 Rename or remove local vars to avoid shadowing.
2537 (Ftranslate_region_internal): Mark var as initialized.
2538
2539 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2540 avoid shadowing.
2541
2542 * lisp.h (eassert): Check that the argument compiles, even if
2543 ENABLE_CHECKING is not defined.
2544
2545 * data.c (Findirect_variable): Name an expression, to avoid
2546 gcc -Wbad-function-cast warning.
2547 (default_value, arithcompare, arith_driver, arith_error): Now static.
2548 (store_symval_forwarding): Rename local to avoid shadowing.
2549 (Fmake_variable_buffer_local, Fmake_local_variable):
2550 Mark variables as initialized.
2551 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
2552
2553 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
2554 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2555 Rename locals to avoid shadowing.
2556 (mark_stack): Move local variables into the #ifdef region where
2557 they're used.
2558 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2559 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2560 needed otherwise.
2561 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2562 (GC_STRING_CHARS): Remove; not used.
2563 (Fmemory_limit): Cast sbrk's returned value to char *.
2564
2565 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2566 avoids undefined behavior in theory.
2567
2568 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2569
2570 Use functions, not macros, for up- and down-casing (Bug#8254).
2571 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2572 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2573 to use the following functions instead of these macros.
2574 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2575 EMACS_INT, since callers assume the returned value fits in int.
2576 (upcase1): Likewise, for UPCASE_TABLE.
2577 (uppercasep, lowercasep, upcase): New static inline functions.
2578 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
2579 the race-condition problem in the old DOWNCASE.
2580
2581 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2582 Rename locals to avoid shadowing.
2583 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
2584 (regex_compile, re_search_2, re_match_2_internal):
2585 Remove unused local vars.
2586 (FREE_VAR): Rewrite so as not to use empty "else",
2587 which gcc can warn about.
2588 (regex_compile, re_match_2_internal): Mark locals as initialized.
2589 (RETALLOC_IF): Define only if needed.
2590 (WORDCHAR_P): Likewise. This one is never needed, but is used
2591 only in a comment talking about a compiler bug, so put inside
2592 the #if 0 of that comment.
2593 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2594 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2595 Remove; unused.
2596
2597 * search.c (boyer_moore): Rename locals to avoid shadowing.
2598 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2599 (PREV_CHAR_BOUNDARY): Likewise.
2600
2601 * search.c (simple_search): Remove unused var.
2602
2603 * dired.c (compile_pattern): Move decl from here ...
2604 * lisp.h: ... to here, so that it can be checked.
2605 (struct re_registers): New forward decl.
2606
2607 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2608
2609 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2610 All uses changed.
2611 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2612 Rename locals to avoid shadowing.
2613 (Fvertical_motion): Mark locals as initialized.
2614
2615 * casefiddle.c (casify_object, casify_region): Now static.
2616 (casify_region): Mark local as initialized.
2617
2618 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2619
2620 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2621 New macros, so that the caller can use some names other than
2622 gcpro1, gcpro2, etc.
2623 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2624 of the new macros.
2625 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2626 argument, for consistency with GCPRO2_VAR, etc: it is now the
2627 prefix of the variable, not the variable itself. All uses
2628 changed.
2629 * dired.c (directory_files_internal, file_name_completion):
2630 Rename locals to avoid shadowing.
2631
2632 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2633 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2634 dired.c's scmp function, had undefined behavior.
2635 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2636 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2637 * buffer.h: ... to here, because these macros use current_buffer,
2638 and the new implementation with inline functions needs to have
2639 current_buffer in scope now, rather than later when the macros
2640 are used.
2641 (downcase, upcase1): New static inline functions.
2642 (DOWNCASE, UPCASE1): Reimplement using these functions.
2643 This avoids undefined behavior in expressions like
2644 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2645 from race conditions in accessing the global variables
2646 case_temp1 and case_temp2.
2647 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2648 * lisp.h (case_temp1, case_temp2): Remove their decls.
2649 * character.h (ASCII_CHAR_P): Move from here ...
2650 * lisp.h: ... to here, so that the inline functions mentioned
2651 above can use them.
2652
2653 * dired.c (directory_files_internal_unwind): Now static.
2654
2655 * fileio.c (file_name_as_directory, directory_file_name):
2656 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2657 Now static.
2658 (file_name_as_directory): Use const pointers when appropriate.
2659 (Fexpand_file_name): Likewise. In particular, newdir might
2660 point at constant storage, so make it a const pointer.
2661 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
2662 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2663 signedness issues.
2664 (Fset_file_times, Finsert_file_contents, auto_save_error):
2665 Rename locals to avoid shadowing.
2666
2667 * minibuf.c (choose_minibuf_frame_1): Now static.
2668 (Ftry_completion, Fall_completions): Rename or remove locals
2669 to avoid shadowing.
2670
2671 * marker.c (bytepos_to_charpos): Remove; unused.
2672
2673 * lisp.h (verify_bytepos, count_markers): New decls,
2674 so that gcc does not warn that these functions aren't declared.
2675
2676 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2677 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
2678 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
2679 (copy_text): Remove unused local var.
2680
2681 * filelock.c (within_one_second): Now static.
2682 (lock_file_1): Rename local to avoid shadowing.
2683
2684 * buffer.c (fix_overlays_before): Mark locals as initialized.
2685 (fix_start_end_in_overlays): Likewise. This function should be
2686 simplified by using pointers-to-pointers, but that's a different
2687 matter.
2688 (switch_to_buffer_1): Now static.
2689 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2690 (report_overlay_modification): Rename locals to avoid shadowing.
2691
2692 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
2693 Fix pointer signedness issue.
2694 (sys_subshell): Mark local as volatile if checking for lint,
2695 to suppress a gcc -Wclobbered warning that does not seem to be right.
2696 (MAXPATHLEN): Define only if needed.
2697
2698 * process.c (serial_open, serial_configure): Move decls from here ...
2699 * systty.h: ... to here, so that they can be checked.
2700
2701 * fns.c (get_random, seed_random): Move extern decls from here ...
2702 * lisp.h: ... to here, so that they can be checked.
2703
2704 * sysdep.c (reset_io): Now static.
2705 (wait_for_termination_signal): Remove; unused.
2706
2707 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2708 (copy_keymap_item, append_key, push_text_char_description):
2709 Now static.
2710 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
2711 (DENSE_TABLE_SIZE): Remove; unused.
2712 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2713 (describe_map_tree):
2714 Rename locals to avoid shadowing.
2715
2716 * keyboard.c: Declare functions static if they are not used elsewhere.
2717 (echo_char, echo_dash, cmd_error, top_level_2):
2718 (poll_for_input, handle_async_input): Now static.
2719 (read_char, kbd_buffer_get_event, make_lispy_position):
2720 (make_lispy_event, make_lispy_movement, apply_modifiers):
2721 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2722 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2723 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
2724 (read_key_sequence, read_char): Mark locals as initialized.
2725 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2726
2727 * keyboard.h (make_ctrl_char): New decl.
2728 (mark_kboards): Move decl here ...
2729 * alloc.c (mark_kboards): ... from here.
2730
2731 * lisp.h (force_auto_save_soon): New decl.
2732
2733 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
2734 (DEFINE_DUMMY_FUNCTION): New macro.
2735 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2736 Use it.
2737 (main): Add casts to avoid warnings
2738 if GCC considers string literals to be constants.
2739
2740 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2741
2742 * dbusbind.c: Pointer signedness fixes.
2743 (xd_signature, xd_append_arg, xd_initialize):
2744 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2745 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2746 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2747 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2748
2749 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2750 if GCC considers string literals to be constants.
2751 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
2752
2753 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2754
2755 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2756 (print_preprocess, print_object): New macro to fix last change.
2757
2758 * print.c (print_preprocess): Don't forget font objects.
2759
2760 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
2761
2762 * emacs.c (USAGE3): Doc fixes.
2763
2764 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2765
2766 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2767 structure.
2768
2769 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
2770
2771 * lisp.h (VWindow_system, Qfile_name_history):
2772 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2773 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2774 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2775
2776 * w32select.c: Don't #include "keyboard.h".
2777 (run_protected): Add extern declaration for waiting_for_input.
2778
2779 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2780 * w32console.c (detect_input_pending, read_input_pending)
2781 (encode_terminal_code):
2782 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2783 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2784 (w32_system_caret_y, Qfile_name_history):
2785 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2786 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2787 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2788 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2789 * w32proc.c (Qlocal, report_file_error):
2790 * w32term.c (Vwindow_system, updating_frame):
2791 * w32uniscribe.c (initialized, uniscribe_font_driver):
2792 Remove unneeded extern declarations.
2793
2794 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
2795
2796 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2797
2798 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
2799
2800 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2801 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2802 These macros can no longer be used for assignment.
2803
2804 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2805 Assign struct members directly, instead of using BUF_BEGV etc.
2806 (record_buffer_markers, fetch_buffer_markers): New functions for
2807 recording and fetching special buffer markers.
2808 (set_buffer_internal_1, set_buffer_temp): Use them.
2809
2810 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2811
2812 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2813
2814 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2815 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2816
2817 * xdisp.c (hscroll_window_tree):
2818 (reconsider_clip_changes): Use PT instead of BUF_PT.
2819
2820 2011-03-13 Eli Zaretskii <eliz@gnu.org>
2821
2822 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2823 $(EMACS_ROOT)/lib/intprops.h.
2824
2825 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2826
2827 Fix more problems found by GCC 4.5.2's static checks.
2828
2829 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2830 to unsigned char * to avoid compiler diagnostic.
2831 (xg_free_frame_widgets): Make it clear that a local variable is
2832 needed only if USE_GTK_TOOLTIP.
2833 (gdk_window_get_screen): Make it clear that this macro is needed
2834 only if USE_GTK_TOOLTIP.
2835 (int_gtk_range_get_value): New function, which avoids a diagnostic
2836 from gcc -Wbad-function-cast.
2837 (xg_set_toolkit_scroll_bar_thumb): Use it.
2838 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2839 diagnostic from gcc -Wbad-function-cast.
2840 (get_utf8_string, xg_get_file_with_chooser):
2841 Rename locals to avoid shadowing.
2842 (create_dialog): Move locals to avoid shadowing.
2843
2844 * xgselect.c (xg_select): Remove unused var.
2845
2846 * image.c (four_corners_best): Mark locals as initialized.
2847 (gif_load): Initialize transparent_p to zero (Bug#8238).
2848 Mark another local as initialized.
2849 (my_png_error, my_error_exit): Mark with NO_RETURN.
2850
2851 * image.c (clear_image_cache): Now static.
2852 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
2853 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
2854 (x_edge_detection): Remove unnecessary cast that
2855 gcc -Wbad-function-cast diagnoses.
2856 (gif_load): Fix pointer signedness.
2857 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2858 (jpeg_load, gif_load): Rename locals to avoid shadowing.
2859
2860 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
2861
2862 Improve quality of tests for time stamp overflow.
2863 For example, without this patch (encode-time 0 0 0 1 1
2864 1152921504606846976) returns the obviously-bogus value (-948597
2865 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2866 reports time overflow. See
2867 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
2868 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2869 * editfns.c: Include limits.h and intprops.h.
2870 (TIME_T_MIN, TIME_T_MAX): New macros.
2871 (time_overflow): Move earlier, to before first use.
2872 (hi_time, lo_time): New functions, for an accurate test for
2873 out-of-range times.
2874 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2875 (Fget_internal_run_time): Don't assume time_t fits in int.
2876 (make_time): Use list2 instead of Fcons twice.
2877 (Fdecode_time): More accurate test for out-of-range times.
2878 (check_tm_member): New function.
2879 (Fencode_time): Use it, to test for out-of-range times.
2880 (lisp_time_argument): Don't rely on undefined left-shift and
2881 right-shift behavior when checking for time stamp overflow.
2882
2883 * editfns.c (time_overflow): New function, refactoring common code.
2884 (Fformat_time_string, Fdecode_time, Fencode_time):
2885 (Fcurrent_time_string): Use it.
2886
2887 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2888 * dired.c (make_time): Move to ...
2889 * editfns.c (make_time): ... here.
2890 * systime.h: Note the move.
2891
2892 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2893
2894 * fringe.c (update_window_fringes): Remove unused variables.
2895
2896 * unexmacosx.c (copy_data_segment): Also copy __got section.
2897 (Bug#8223)
2898
2899 2011-03-12 Eli Zaretskii <eliz@gnu.org>
2900
2901 * termcap.c [MSDOS]: Include "msdos.h".
2902 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2903 Constify `char *' arguments and their references according to
2904 prototypes in tparam.h.
2905
2906 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
2907
2908 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2909 Adapt all references accordingly.
2910
2911 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2912
2913 2011-03-11 Tom Tromey <tromey@redhat.com>
2914
2915 * buffer.c (syms_of_buffer): Remove obsolete comment.
2916
2917 2011-03-11 Eli Zaretskii <eliz@gnu.org>
2918
2919 * termhooks.h (encode_terminal_code): Declare prototype.
2920
2921 * msdos.c (encode_terminal_code): Don't declare prototype.
2922
2923 * term.c (encode_terminal_code): Now external again, used by
2924 w32console.c and msdos.c.
2925
2926 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2927 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
2928
2929 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
2930
2931 Fix some minor problems found by GCC 4.5.2's static checks.
2932
2933 * fringe.c (update_window_fringes): Mark locals as initialized
2934 (Bug#8227).
2935 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
2936
2937 * alloc.c (mark_fringe_data): Move decl from here ...
2938 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2939 to check its interface.
2940 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2941
2942 * fontset.c (free_realized_fontset): Now static.
2943 (Fset_fontset_font): Rename local to avoid shadowing.
2944 (fontset_font): Mark local as initialized.
2945 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
2946
2947 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2948
2949 * xselect.c (x_disown_buffer_selections): Remove; not used.
2950 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
2951 (x_own_selection, Fx_disown_selection_internal): Rename locals
2952 to avoid shadowing.
2953 (x_handle_dnd_message): Remove local to avoid shadowing.
2954
2955 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2956 so that the caller can use some name other than gcpro1.
2957 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
2958 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2959 (Fx_backspace_delete_keys_p):
2960 Use them to avoid shadowing, and rename vars to avoid shadowing.
2961 (x_decode_color, x_set_name, x_window): Now static.
2962 (Fx_create_frame): Add braces to silence GCC warning.
2963 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
2964 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2965 Remove unused locals.
2966 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2967 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2968 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2969 macros.
2970
2971 * xterm.h (x_mouse_leave): New decl.
2972
2973 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2974 Remove unused functions.
2975 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2976 (x_calc_absolute_position): Now static.
2977 (XTread_socket): Don't define label "out" unless it's used.
2978 Don't declare local "event" unless it's used.
2979 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2980 unless they are used.
2981 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2982 (x_fatal_error_signal): Remove; not used.
2983 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2984 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2985 (x_error_catcher, x_connection_closed, x_error_handler):
2986 (x_error_quitter, xembed_send_message, x_iconify_frame):
2987 (my_log_handler): Rename locals to avoid shadowing.
2988 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2989 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
2990
2991 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2992 Rename or move locals to avoid shadowing.
2993 (tty_defined_color, merge_face_heights): Now static.
2994 (free_realized_faces_for_fontset): Remove; not used.
2995 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2996 does not deduce is never used uninitialized.
2997 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2998 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
2999
3000 * terminal.c (store_terminal_param): Now static.
3001
3002 * xmenu.c (menu_highlight_callback): Now static.
3003 (set_frame_menubar): Remove unused local.
3004 (xmenu_show): Rename parameter to avoid shadowing.
3005 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3006 since they might point to immutable storage.
3007 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3008 since it's unused otherwise.
3009
3010 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3011 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3012 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3013 avoids a gcc -Wuninitialized diagnostic.
3014 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3015 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3016 does not deduce are never used uninitialized.
3017
3018 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3019
3020 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3021 * window.c (window_loop, size_window):
3022 (run_window_configuration_change_hook, enlarge_window): Likewise.
3023
3024 * window.c (display_buffer): Now static.
3025 (size_window): Mark variables that gcc -Wuninitialized
3026 does not deduce are never used uninitialized.
3027 * window.h (check_all_windows): New decl, to forestall
3028 gcc -Wmissing-prototypes diagnostic.
3029 * dispextern.h (bidi_dump_cached_states): Likewise.
3030
3031 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3032 shadowing.
3033 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3034 Include <limits.h>.
3035 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3036 and to avoid gcc -Wuninitialized warning.
3037 (load_charset_map): Mark variables that gcc -Wuninitialized
3038 does not deduce are never used uninitialized.
3039 (load_charset): Abort instead of using uninitialized var (Bug#8229).
3040
3041 * coding.c (coding_set_source, coding_set_destination):
3042 Use "else { /* comment */ }" rather than "else /* comment */;"
3043 for clarity, and to avoid gcc -Wempty-body warning.
3044 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3045 a block, when the outer 'i' will do.
3046 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3047 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3048 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3049 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3050 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3051 Rename locals to avoid shadowing.
3052 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
3053 * coding.c (emacs_mule_char, encode_invocation_designation):
3054 Now static, since they're not used elsewhere.
3055 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
3056 (decode_coding_object, encode_coding_object, detect_coding_system):
3057 (decode_coding_emacs_mule): Mark variables that gcc
3058 -Wuninitialized does not deduce are never used uninitialized.
3059 (detect_coding_iso_2022): Initialize a local variable that might
3060 be used uninitialized. Leave a FIXME because it's not clear that
3061 this initialization is needed. (Bug#8211)
3062 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3063 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3064 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3065 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3066 Remove unused macros.
3067
3068 * category.c (hash_get_category_set): Remove unused local var.
3069 (copy_category_table): Now static, since it's not used elsewhere.
3070 * character.c (string_count_byte8): Likewise.
3071
3072 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3073 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3074
3075 * chartab.c (copy_sub_char_table): Now static, since it's not used
3076 elsewhere.
3077 (sub_char_table_ref_and_range, char_table_ref_and_range):
3078 Rename locals to avoid shadowing.
3079 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
3080
3081 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
3082 (BIDI_BOB): Remove unused macro.
3083
3084 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3085 deduce are never used uninitialized.
3086 * term.c (encode_terminal_code): Likewise.
3087
3088 * term.c (encode_terminal_code): Now static. Remove unused local.
3089
3090 * tparam.h: New file.
3091 * term.c, tparam.h: Include it.
3092 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3093 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3094 Move these decls to tparam.h, and make them agree with what
3095 is actually in tparam.c. The previous trick of using incompatible
3096 decls in different modules does not conform to the C standard.
3097 All callers of tparam changed to use tparam's actual API.
3098 * tparam.c (tparam1, tparam, tgoto):
3099 Use const pointers where appropriate.
3100
3101 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3102 * cm.h (struct cm): Likewise.
3103 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3104 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3105 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3106 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3107 (turn_on_face, init_tty): Likewise.
3108 * termchar.h (struct tty_display_info): Likewise.
3109
3110 * term.c (term_mouse_position): Rename local to avoid shadowing.
3111
3112 * alloc.c (mark_ttys): Move decl from here ...
3113 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3114
3115 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3116
3117 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3118
3119 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
3120
3121 * search.c (compile_pattern_1): Remove argument regp, unused since
3122 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3123 (compile_pattern): Don't pass it.
3124
3125 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3126
3127 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3128 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3129 for ! HAVE_GTK3.
3130 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3131
3132 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3133
3134 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3135 gdk_window_get_screen, gdk_window_get_geometry,
3136 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3137 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3138 (xg_get_pixbuf_from_pixmap): New function.
3139 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3140 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3141 Call xg_get_pixbuf_from_pixmap instead of
3142 gdk_pixbuf_get_from_drawable.
3143 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3144 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3145 (xg_check_special_colors): Use GtkStyleContext and its functions
3146 for HAVE_GTK3.
3147 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3148 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3149 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
3150 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3151 Call gtk_widget_get_preferred_size.
3152 (xg_frame_resized): gdk_window_get_geometry only takes 5
3153 parameters.
3154 (xg_win_to_widget, xg_event_is_for_menubar):
3155 Call gdk_x11_window_lookup_for_display.
3156 (xg_set_widget_bg): New function.
3157 (delete_cb): New function.
3158 (xg_create_frame_widgets): Connect delete-event to delete_cb.
3159 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3160 (xg_set_background_color): Call xg_set_widget_bg.
3161 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3162 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3163 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3164 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3165 if ! HAVE_GTK3.
3166 (update_frame_tool_bar): Call gtk_widget_hide.
3167 (xg_initialize): Use GDK_KEY_g.
3168
3169 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3170 if ! HAVE_GTK3
3171 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3172
3173 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3174 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3175 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3176
3177 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
3178
3179 * w32xfns.c (select_palette): Check success of RealizePalette against
3180 GDI_ERROR, not zero.
3181
3182 See ChangeLog.11 for earlier changes.
3183
3184 ;; Local Variables:
3185 ;; coding: utf-8
3186 ;; End:
3187
3188 Copyright (C) 2011 Free Software Foundation, Inc.
3189
3190 This file is part of GNU Emacs.
3191
3192 GNU Emacs is free software: you can redistribute it and/or modify
3193 it under the terms of the GNU General Public License as published by
3194 the Free Software Foundation, either version 3 of the License, or
3195 (at your option) any later version.
3196
3197 GNU Emacs is distributed in the hope that it will be useful,
3198 but WITHOUT ANY WARRANTY; without even the implied warranty of
3199 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3200 GNU General Public License for more details.
3201
3202 You should have received a copy of the GNU General Public License
3203 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.