1 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3 Improve hashing quality when configured --with-wide-int.
4 * fns.c (hash_string): New function, taken from sxhash_string.
5 Do not discard information about ASCII character case; this
6 discarding is no longer needed.
7 (sxhash-string): Use it. Change sig to match it. Caller changed.
9 * lread.c (hash_string): Remove, since we now use fns.c's version.
10 The fns.c version returns a wider integer if --with-wide-int is
11 specified, so this should help the quality of the hashing a bit.
13 2011-07-07 Paul Eggert <eggert@cs.ucla.edu>
15 * emacs.c: Integer overflow minor fix.
16 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
17 Define only if GNU_LINUX.
18 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
20 * dispnew.c: Integer signedness and overflow fixes.
21 Remove unnecessary forward decls, that were a maintenance hassle.
22 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
24 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
25 (scrolling_window): Use ptrdiff_t, not int, for byte count.
26 (prepare_desired_row, line_draw_cost):
27 Use int, not unsigned, where either works.
28 (save_current_matrix, restore_current_matrix):
29 Use ptrdiff_t, not size_t, where either works.
30 (init_display): Check for overflow more accurately, and without
31 relying on undefined behavior.
33 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
34 Remove, replacing with the new symbols in lisp.h. All uses changed.
35 * fileio.c (make_temp_name):
36 * filelock.c (lock_file_1, lock_file):
37 * xdisp.c (message_dolog):
38 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
40 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
41 replacing the pWIDE etc. symbols removed from editfns.c.
43 * keyboard.h (num_input_events): Now uintmax_t.
44 This is (very slightly) less likely to mess up due to wraparound.
47 * buffer.c: Integer signedness fixes.
48 (alloc_buffer_text, enlarge_buffer_text):
49 Use ptrdiff_t rather than size_t when either will do, as we prefer
52 * bidi.c: Integer signedness and overflow fixes.
53 (bidi_cache_idx, bidi_cache_last_idx, bidi_cache_fetch_state)
54 (bidi_cache_search, bidi_cache_find_level_change)
55 (bidi_cache_iterator_state, bidi_cache_find, bidi_find_other_level_edge)
56 (bidi_dump_cached_states):
57 Don't arbitrarily limit cache indexes to int; use ptrdiff_t instead.
58 (bidi_cache_size): Use ptrdiff_t rather than size_t, as we prefer
60 (elsz): Make it a (signed) constant.
61 (bidi_cache_iterator_state): Check for size-calculation overflow.
63 * alloc.c: Integer signedness and overflow fixes.
64 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
65 (__malloc_size_t): Default to size_t, not to int.
66 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
67 (Fgarbage_collect, mark_object_loop_halt, mark_object):
68 Prefer ptrdiff_t to size_t when either would do, as we prefer
70 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
71 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
72 Now const. Initialize with values that are in range even if char
74 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
75 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
76 These functions do the right thing with sizes > 2**32.
77 (check_depth): Now ptrdiff_t, not int.
78 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
79 Adjust to new way of storing sizes. Check for size overflow bugs
81 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
82 slightly wrong anyway, as it missed one instance of
83 XMALLOC_OVERRUN_CHECK_OVERHEAD.
84 (refill_memory_reserve): Omit needless cast to size_t.
85 (mark_object_loop_halt): Mark as externally visible.
87 * xselect.c: Integer signedness and overflow fixes.
88 (Fx_register_dnd_atom, x_handle_dnd_message):
89 Use ptrdiff_t, not size_t, since we prefer signed.
90 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
91 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
92 x_dnd_atoms_size and x_dnd_atoms_length.
94 * doprnt.c: Prefer signed to unsigned when either works.
99 Use ptrdiff_t, not size_t, when using or implementing doprnt,
100 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
101 prefer signed arithmetic to avoid comparison confusion.
102 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
105 Assume freestanding C89 headers, string.h, stdlib.h.
106 * data.c, doprnt.c, floatfns.c, print.c:
107 Include float.h unconditionally.
108 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
109 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
110 * regex.c: Likewise for stddef.h, string.h.
111 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
112 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
113 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
114 (STDC_HEADERS): Remove obsolete defines.
115 * sysdep.c: Include limits.h unconditionally.
117 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
119 Assume support for memcmp, memcpy, memmove, memset.
120 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
121 * regex.c (memcmp, memcpy):
122 Remove; we assume C89 now.
124 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
125 (__malloc_safe_bcopy): Remove; no longer needed.
127 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
128 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
129 well either way, and we prefer signed to unsigned.
131 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
133 Remove unportable assumption about struct layout (Bug#8884).
134 * alloc.c (mark_buffer):
135 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
136 (clone_per_buffer_values): Don't assume that
137 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
138 This isn't true in general, and it's particularly not true
139 if Emacs is configured with --with-wide-int.
140 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
141 New macros, used in the buffer.c change.
143 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
145 * xsettings.c: Use both GConf and GSettings if both are available.
146 (store_config_changed_event): Add comment.
147 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
148 (store_tool_bar_style_changed): New functions.
149 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
150 (struct xsettings): Move font inside HAVE_XFT.
151 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
152 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
153 Move inside HAVE_XFT.
154 (something_changed_gsettingsCB): Renamed from something_changedCB.
155 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
157 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
158 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
159 (something_changed_gconfCB): Renamed from something_changedCB.
160 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
161 (parse_settings): Move check for font inside HAVE_XFT.
162 (read_settings, apply_xft_settings): Add comment.
163 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
164 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
165 call store_font_name_changed.
166 (xft_settings_event): Add comment.
167 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
168 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
169 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
170 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
171 (xsettings_initialize): Call init_gsettings last.
172 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
175 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
177 Random fixes. E.g., (random) never returned negative values.
178 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
179 subseconds part to the entropy, as that's a bit more random.
180 Prefer signed to unsigned, since the signedness doesn't matter and
181 in general we prefer signed. When given a limit, use a
182 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
183 latter isn't right if USE_2_TAGS_FOR_INTS.
184 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
185 not 0..VALMASK. Don't discard "excess" bits that random () returns.
187 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
189 * textprop.c (text_property_stickiness):
190 Obey Vtext_property_default_nonsticky.
191 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
192 * w32fns.c (syms_of_w32fns):
193 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
195 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
197 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
198 This is more efficient than Ffile_directory_p and avoids a minor race.
200 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
202 * buffer.c (Foverlay_put): Say what the return value is
205 * fileio.c (barf_or_query_if_file_exists): Check first if the file
206 is a directory before asking whether to use the file name
208 (barf_or_query_if_file_exists): Make the "File is a directory"
209 error be more correct.
211 * fns.c (Frequire): Remove the mention of the .gz files, since
212 that's installation-specific, but keep the mention of
215 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
217 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
218 Report string overflow if the output is too long.
220 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
222 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
223 (syms_of_gnutls): Remove duplicate DEFSYM for
224 Qgnutls_bootprop_verify_hostname_error, an error for
225 Qgnutls_bootprop_verify_error (which is no longer used).
227 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
228 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
229 Also (re)move comments that are misplaced or no longer relevant.
231 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
233 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
235 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
237 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
238 and background color parameters if they have been changed.
240 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
242 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
244 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
246 * xsettings.c (SYSTEM_FONT): Define only when used.
247 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
249 * keymap.c (access_keymap_1): Now static.
251 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
253 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
254 leave any prefix arg for the up event (Bug#1586).
256 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
258 * lread.c (syms_of_lread): Mention single symbols defined by
259 `defvar' or `defconst' (bug#7154).
261 * fns.c (Frequire): Mention .el.gz files (bug#7314).
262 (Frequire): Mention get-load-suffixes.
264 2011-07-02 Martin Rudalics <rudalics@gmx.at>
266 * window.h (window): Remove clone_number slot.
267 * window.c (Fwindow_clone_number, Fset_window_clone_number):
269 (make_parent_window, make_window, saved_window)
270 (Fset_window_configuration, save_window_save): Don't deal with
272 * buffer.c (Qclone_number): Remove declaration.
273 (sort_overlays, overlay_strings): Don't deal with clone numbers.
275 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
277 Add multiple inheritance to keymaps.
278 * keymap.c (Fmake_composed_keymap): New function.
279 (Fset_keymap_parent): Simplify.
280 (fix_submap_inheritance): Remove.
281 (access_keymap_1): New function extracted from access_keymap to handle
282 embedded parents and handle lists of maps.
283 (access_keymap): Use it.
284 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
285 (Fcopy_keymap): Handle embedded parents.
286 (Fcommand_remapping, define_as_prefix): Simplify.
287 (Fkey_binding): Simplify.
288 (syms_of_keymap): Move minibuffer-local-completion-map,
289 minibuffer-local-filename-completion-map,
290 minibuffer-local-must-match-map, and
291 minibuffer-local-filename-must-match-map to Elisp.
292 (syms_of_keymap): Defsubr make-composed-keymap.
293 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
294 (parse_menu_item): Trivial simplification.
296 2011-07-01 Glenn Morris <rgm@gnu.org>
298 * Makefile.in (SETTINGS_LIBS): Fix typo.
300 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
302 * coding.c (Fencode_coding_string): Record the last coding system
303 used, as the function doc string says (bug#8738).
305 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
307 * xsettings.c (store_monospaced_changed): Take new font as arg and
308 check for change against current_mono_font.
309 (EMACS_TYPE_SETTINGS): Remove this and related defines.
310 (emacs_settings_constructor, emacs_settings_get_property)
311 (emacs_settings_set_property, emacs_settings_class_init)
312 (emacs_settings_init, gsettings_obj): Remove.
313 (something_changedCB): New function for HAVE_GSETTINGS.
314 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
315 with value as argument.
316 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
317 g_settings_new (Bug#8967). Do not create gsettings_obj.
318 Remove calls to g_settings_bind. Connect something_changedCB to
321 * xgselect.c: Add defined (HAVE_GSETTINGS).
322 (xgselect_initialize): Ditto.
324 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
325 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
328 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
330 * eval.c (struct backtrace): Simplify and port the data structure.
331 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
332 signed bit field, as this assumption is not portable and it makes
333 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
334 "char debug_on_exit : 1" as this is not portable either; instead,
335 use the portable "unsigned int debug_on_exit : 1". Remove unused
336 member evalargs. Remove obsolete comments about cc bombing out.
338 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
340 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
341 Let HAVE_GSETTINGS override HAVE_GCONF.
342 (store_monospaced_changed): New function.
343 (EMACS_SETTINGS): A new type derived from GObject to handle
344 GSettings notifications.
345 (emacs_settings_constructor, emacs_settings_get_property)
346 (emacs_settings_set_property, emacs_settings_class_init):
348 (gsettings_client, gsettings_obj): New variables.
349 (GSETTINGS_SCHEMA): New define.
350 (something_changedCB): Call store_monospaced_changed.
351 (init_gsettings): New function.
352 (xsettings_initialize): Call init_gsettings.
353 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
356 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
359 2011-06-29 Martin Rudalics <rudalics@gmx.at>
361 * window.c (resize_root_window, grow_mini_window)
362 (shrink_mini_window): Rename Qresize_root_window to
363 Qwindow_resize_root_window and Qresize_root_window_vertically to
364 Qwindow_resize_root_window_vertically.
366 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
368 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
370 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
372 * makefile.w32-in: Redesign dependencies so they reflect more
373 clearly which files are directly included by each source file,
374 and not through other includes.
376 2011-06-27 Martin Rudalics <rudalics@gmx.at>
378 * buffer.c (Qclone_number): Declare static and DEFSYM it.
379 (sort_overlays, overlay_strings): When an overlay's clone number
380 matches the window's clone number process the overlay even if
381 the overlay's window property doesn't match the current window.
383 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
384 (Fwindow_hchild): Rename to Fwindow_left_child.
385 (Fwindow_next): Rename to Fwindow_next_sibling.
386 (Fwindow_prev): Rename to Fwindow_prev_sibling.
387 (resize_window_check): Rename to window_resize_check.
388 (resize_window_apply): Rename to window_resize_apply.
389 (Fresize_window_apply): Rename to Fwindow_resize_apply.
390 (Fdelete_other_windows_internal, resize_frame_windows)
391 (Fsplit_window_internal, Fdelete_window_internal)
392 (grow_mini_window, shrink_mini_window)
393 (Fresize_mini_window_internal): Fix callers accordingly.
395 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
397 * emacsgtkfixed.h: State that this is only used with Gtk+3.
398 (emacs_fixed_set_min_size): Remove.
399 (emacs_fixed_new): Take frame as argument.
401 * emacsgtkfixed.c: State that this is only used with Gtk+3.
402 (_EmacsFixedPrivate): Remove minwidth/height.
404 (emacs_fixed_init): Initialize priv->f.
405 (get_parent_class, emacs_fixed_set_min_size): Remove.
406 (emacs_fixed_new): Set priv->f to argument.
407 (emacs_fixed_get_preferred_width)
408 (emacs_fixed_get_preferred_height): Use min_width/height from
409 frames size_hint to set minimum and natural (Bug#8919).
410 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
411 and use min_width/height from frames size_hint to set
412 min_width/height (Bug#8919).
414 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
415 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
418 2011-06-26 Eli Zaretskii <eliz@gnu.org>
420 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
421 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
424 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
426 * process.c (wait_reading_process_output): Bypass select if
427 waiting for a cell while ignoring keyboard input, and input is
428 pending. Suggested by Jan Djärv (Bug#8869).
430 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
432 Use gnulib's dup2 module instead of rolling our own.
433 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
435 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
437 * dispnew.c (scrolling_window): Before scrolling, turn off a
438 mouse-highlight in the window being scrolled.
440 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
442 Move DEFSYM to lisp.h and use everywhere.
444 * character.h (DEFSYM): Move declaration...
445 * lisp.h (DEFSYM): ...here.
451 * w32select.c: Don't include character.h.
453 * alloc.c (syms_of_alloc):
454 * buffer.c (syms_of_buffer):
455 * bytecode.c (syms_of_bytecode):
456 * callint.c (syms_of_callint):
457 * casefiddle.c (syms_of_casefiddle):
458 * casetab.c (init_casetab_once):
459 * category.c (init_category_once, syms_of_category):
460 * ccl.c (syms_of_ccl):
461 * cmds.c (syms_of_cmds):
462 * composite.c (syms_of_composite):
463 * dbusbind.c (syms_of_dbusbind):
464 * dired.c (syms_of_dired):
465 * dispnew.c (syms_of_display):
466 * doc.c (syms_of_doc):
467 * editfns.c (syms_of_editfns):
468 * emacs.c (syms_of_emacs):
469 * eval.c (syms_of_eval):
470 * fileio.c (syms_of_fileio):
471 * fns.c (syms_of_fns):
472 * frame.c (syms_of_frame):
473 * fringe.c (syms_of_fringe):
474 * insdel.c (syms_of_insdel):
475 * keymap.c (syms_of_keymap):
476 * lread.c (init_obarray, syms_of_lread):
477 * macros.c (syms_of_macros):
478 * msdos.c (syms_of_msdos):
479 * print.c (syms_of_print):
480 * process.c (syms_of_process):
481 * search.c (syms_of_search):
482 * sound.c (syms_of_sound):
483 * syntax.c (init_syntax_once, syms_of_syntax):
484 * terminal.c (syms_of_terminal):
485 * textprop.c (syms_of_textprop):
486 * undo.c (syms_of_undo):
487 * w32.c (globals_of_w32):
488 * window.c (syms_of_window):
489 * xdisp.c (syms_of_xdisp):
490 * xfaces.c (syms_of_xfaces):
491 * xfns.c (syms_of_xfns):
492 * xmenu.c (syms_of_xmenu):
493 * xsettings.c (syms_of_xsettings):
494 * xterm.c (syms_of_xterm): Use DEFSYM.
496 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
498 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
500 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
502 Integer and buffer overflow fixes (Bug#8873).
504 * print.c (printchar, strout): Check for string overflow.
505 (PRINTPREPARE, printchar, strout):
506 Don't set size unless allocation succeeds.
508 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
509 for sizes. Check for string overflow more accurately.
510 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
512 * macros.c: Integer and buffer overflow fixes.
513 * keyboard.h (struct keyboard.kbd_macro_bufsize):
514 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
515 Use ptrdiff_t, not int, for sizes.
516 Don't increment bufsize until after realloc succeeds.
517 Check for size-calculation overflow.
518 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
520 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
522 * lread.c: Integer overflow fixes.
523 (read_integer): Radix is now EMACS_INT, not int,
524 to improve quality of diagnostics for out-of-range radices.
525 Calculate buffer size correctly for out-of-range radices.
526 (read1): Check for integer overflow in radices, and in
528 (read_escape): Avoid int overflow.
529 (Fload, openp, read_buffer_size, read1)
530 (substitute_object_recurse, read_vector, read_list, map_obarray):
531 Use ptrdiff_t, not int, for sizes.
532 (read1): Use EMACS_INT, not int, for sizes.
533 Check for size overflow.
535 * image.c (cache_image): Check for size arithmetic overflow.
537 * lread.c: Integer overflow issues.
538 (saved_doc_string_size, saved_doc_string_length)
539 (prev_saved_doc_string_size, prev_saved_doc_string_length):
540 Now ptrdiff_t, not int.
541 (read1): Don't assume doc string length fits in int. Check for
542 out-of-range doc string lengths.
543 (read_list): Don't assume file position fits in int.
544 (read_escape): Check for hex character overflow.
546 2011-06-22 Leo Liu <sdl.web@gmail.com>
548 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
549 Move to minibuffer.el.
551 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
553 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
554 The following patches are for when GLYPH_DEBUG && !XASSERT.
555 * dispextern.h (trace_redisplay_p, dump_glyph_string):
556 * dispnew.c (flush_stdout):
557 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
558 Mark as externally visible.
559 * dispnew.c (check_window_matrix_pointers): Now static.
560 * dispnew.c (window_to_frame_vpos):
561 * xfns.c (unwind_create_frame):
562 * xterm.c (x_check_font): Remove unused local.
563 * scroll.c (CHECK_BOUNDS):
564 * xfaces.c (cache_fache): Rename local to avoid shadowing.
565 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
566 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
567 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
568 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
570 (debug_method_add): Use va_list and vsprintf rather than relying
571 on undefined behavior with wrong number of arguments.
572 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
573 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
574 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
575 since we're not interested in debugging glyphs with old libraries.
576 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
577 GCC 4.6.0's static checking.
579 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
581 Integer overflow and signedness fixes (Bug#8873).
582 A few related buffer overrun fixes, too.
584 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
586 * dispextern.h (struct face.stipple):
587 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
588 (x_bitmap_mask, x_allocate_bitmap_record)
589 (x_create_bitmap_from_data, x_create_bitmap_from_file)
590 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
591 (x_create_bitmap_from_xpm_data):
592 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
593 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
595 * xfaces.c (load_pixmap):
596 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
597 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
598 (.bitmaps_last, struct x_output.icon_bitmap):
599 Use ptrdiff_t, not int, for bitmap indexes.
600 (x_allocate_bitmap_record): Check for size overflow.
601 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
603 Use ptrdiff_t, not int, for overlay counts.
604 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
605 * editfns.c (overlays_around, get_pos_property):
606 * textprop.c (get_char_property_and_overlay):
607 * xdisp.c (next_overlay_change, note_mouse_highlight):
608 * xfaces.c (face_at_buffer_position):
609 * buffer.c (OVERLAY_COUNT_MAX): New macro.
610 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
611 (Fnext_overlay_change, Fprevious_overlay_change)
612 (mouse_face_overlay_overlaps, Foverlays_in):
613 Use ptrdiff_t, not int, for sizes.
614 (overlays_at, overlays_in): Check for size-calculation overflow.
616 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
618 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
619 (x_session_initialize): Do not assume string length fits in int.
621 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
622 This is unlikely, but can occur if DPI is outlandish.
624 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
625 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
627 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
628 * xrdb.c (magic_file_p, search_magic_path):
629 Omit last arg SUFFIX; it was always 0. All callers changed.
630 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
632 * xfont.c (xfont_match): Avoid need for strlen.
634 * xfns.c: Don't assume strlen fits in int.
635 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
637 * xdisp.c (message_log_check_duplicate): Return intmax_t,
638 not unsigned long, as we prefer signed integers. All callers changed.
639 Detect integer overflow in repeat count.
640 (message_dolog): Don't assume print length fits in 39 bytes.
641 (display_mode_element): Don't assume strlen fits in int.
643 * termcap.c: Don't assume sizes fit in int and never overflow.
644 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
645 (gobble_line): Check for size-calculation overflow.
647 * minibuf.c (Fread_buffer):
648 * lread.c (intern, intern_c_string):
649 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
650 Don't assume string length fits in int.
652 * keyboard.c (parse_tool_bar_item):
653 * gtkutil.c (style_changed_cb): Avoid need for strlen.
655 * font.c: Don't assume string length fits in int.
656 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
657 Use ptrdiff_t, not int.
658 (font_intern_prop): Don't assume string length fits in int.
659 Don't assume integer property fits in fixnum.
660 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
662 * filelock.c: Fix some buffer overrun and integer overflow issues.
663 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
664 Reformulate so as not to need the command string.
665 Invoke gzip -cd rather than gunzip, as it's more portable.
666 (lock_info_type, lock_file_1, lock_file):
667 Don't assume pid_t and time_t fit in unsigned long.
668 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
669 (current_lock_owner): Prefer signed type for sizes.
670 Use memcpy, not strncpy, where memcpy is what is really wanted.
671 Don't assume (via atoi) that time_t and pid_t fit in int.
672 Check for time_t and/or pid_t out of range, e.g., via a network share.
673 Don't alloca where an auto var works fine.
675 * fileio.c: Fix some integer overflow issues.
676 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
677 Don't assume string length fits in int.
678 (directory_file_name): Don't assume string length fits in long.
679 (make_temp_name): Don't assume pid fits in int, or that its print
680 length is less than 20.
682 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
684 * coding.c (make_subsidiaries): Don't assume string length fits in int.
686 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
688 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
689 We prefer signed integers, even for size calculations.
691 * emacs.c: Don't assume string length fits in 'int'.
692 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
693 (main): Don't invoke strlen when not needed.
695 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
696 (XD_DEBUG_MESSAGE): Don't waste a byte.
698 * callproc.c (getenv_internal_1, getenv_internal)
700 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
702 * lread.c (invalid_syntax): Omit length argument.
703 All uses changed. This doesn't fix a bug, but it simplifies the
704 code away from its former Hollerith-constant appearance, and it's
705 one less 'int' to worry about when looking at integer-overflow issues.
706 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
708 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
709 This didn't break anything, but it didn't help either.
710 It's confusing to put a bogus integer in a place where the actual
711 value does not matter.
712 (LIST_END_P): Remove unused macro and its bogus comment.
713 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
715 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
716 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
718 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
719 We prefer signed types, and the value cannot exceed the EMACS_INT
720 range anyway (because otherwise the length would not be representable).
721 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
722 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
723 This avoids a GCC warning when WIDE_EMACS_INT.
725 * indent.c (sane_tab_width): New function.
726 (current_column, scan_for_column, Findent_to, position_indentation)
727 (compute_motion): Use it. This is just for clarity.
728 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
730 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
732 * lisp.h (lint_assume): New macro.
733 * composite.c (composition_gstring_put_cache):
734 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
736 * editfns.c, insdel.c:
737 Omit unnecessary forward decls, to simplify future changes.
739 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
741 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
743 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
744 Use much-faster test for byte-length change.
745 Don't assume string byte-length fits in 'int'.
746 Check that character arg fits in 'int'.
747 (mapcar1): Declare byte as byte, for clarity.
749 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
751 * fns.c (concat): Catch string overflow earlier.
752 Do not rely on integer wraparound.
754 * dispextern.h (struct it.overlay_strings_charpos)
755 (struct it.selective): Now EMACS_INT, not int.
756 * xdisp.c (forward_to_next_line_start)
757 (back_to_previous_visible_line_start)
758 (reseat_at_next_visible_line_start, next_element_from_buffer):
759 Don't arbitrarily truncate the value of 'selective' to int.
761 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
763 * composite.c: Don't truncate sizes to 'int'.
764 (composition_gstring_p, composition_reseat_it)
765 (composition_adjust_point): Use EMACS_INT, not int.
766 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
767 not EMACS_UINT, for indexes.
769 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
771 * buffer.c: Include <verify.h>.
772 (struct sortvec.priority, struct sortstr.priority):
773 Now EMACS_INT, not int.
774 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
775 (struct sortstr.size, record_overlay_string)
776 (struct sortstrlist.size, struct sortlist.used):
777 Don't truncate size to int.
778 (record_overlay_string): Check for size-calculation overflow.
779 (init_buffer_once): Check at compile-time, not run-time.
781 2011-06-22 Jim Meyering <meyering@redhat.com>
783 Don't leak an XBM-image-sized buffer
784 * image.c (xbm_load): Free the image buffer after using it.
786 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
789 * composite.c (find_automatic_composition): Omit needless 'return 0;'
790 that Sun C diagnosed.
791 * fns.c (secure_hash): Fix pointer signedness issue.
792 * intervals.c (static_offset_intervals): New function.
793 (offset_intervals): Use it.
795 2011-06-21 Leo Liu <sdl.web@gmail.com>
798 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
801 * fns.c (secure_hash): Rename from crypto_hash_function and change
802 the first arg to accept symbols.
803 (Fsecure_hash): New primitive.
804 (syms_of_fns): New symbols.
806 2011-06-20 Deniz Dogan <deniz@dogan.se>
808 * process.c (Fset_process_buffer): Clarify return value in
811 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
813 * dispnew.c (add_window_display_history): Use BVAR.
815 * xdisp.c (debug_method_add): Use BVAR.
816 (check_window_end, dump_glyph_matrix, dump_glyph)
817 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
819 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
822 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
823 check till after the cache is created in init_frame_faces.
825 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
827 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
829 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
831 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
832 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
833 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
835 Improve buffer-overflow checking (Bug#8873).
836 * fileio.c (Finsert_file_contents):
837 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
838 Remove the old (too-loose) buffer overflow checks.
839 They weren't needed, since make_gap checks for buffer overflow.
840 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
841 The old code merely checked for Emacs fixnum overflow, and relied
842 on undefined (wraparound) behavior. The new code avoids undefined
843 behavior, and also checks for ptrdiff_t and/or size_t overflow.
845 * editfns.c (Finsert_char): Don't dump core with very negative counts.
846 Tune. Don't use wider integers than needed. Don't use alloca.
847 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
849 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
851 * insdel.c, lisp.h (buffer_overflow): New function.
852 (insert_from_buffer_1, replace_range, replace_range_2):
853 * insdel.c (make_gap_larger):
854 * editfns.c (Finsert_char):
855 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
857 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
859 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
861 Integer overflow and signedness fixes (Bug#8873).
863 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
864 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
866 * fileio.c: Don't assume EMACS_INT fits in off_t.
867 (emacs_lseek): New static function.
868 (Finsert_file_contents, Fwrite_region): Use it.
869 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
871 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
873 * fns.c: Don't overflow int when computing a list length.
874 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
875 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
876 truncation on 64-bit hosts. Check for QUIT every
877 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
878 faster and is responsive enough.
879 (Flength): Report an error instead of overflowing an integer.
880 (Fsafe_length): Return a float if the value is not representable
881 as a fixnum. This shouldn't happen except in contrived situations.
882 (Fnthcdr, Fsort): Don't assume list length fits in int.
883 (Fcopy_sequence): Don't assume vector length fits in int.
885 * alloc.c: Check that resized vectors' lengths fit in fixnums.
886 (header_size, word_size): New constants.
887 (allocate_vectorlike): Don't check size overflow here.
888 (allocate_vector): Check it here instead, since this is the only
889 caller of allocate_vectorlike that could cause overflow.
890 Check that the new vector's length is representable as a fixnum.
892 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
893 The previous code was bogus. For example, next_almost_prime (32)
894 returned 39, which is undesirable as it is a multiple of 3; and
895 next_almost_prime (24) returned 25, which is a multiple of 5 so
896 why was the code bothering to check for multiples of 7?
898 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
900 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
902 Variadic C functions now count arguments with ptrdiff_t.
903 This partly undoes my 2011-03-30 change, which replaced int with size_t.
904 Back then I didn't know that the Emacs coding style prefers signed int.
905 Also, in the meantime I found a few more instances where arguments
906 were being counted with int, which may truncate counts on 64-bit
907 machines, or EMACS_INT, which may be unnecessarily wide.
908 * lisp.h (struct Lisp_Subr.function.aMANY)
909 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
910 Arg counts are now ptrdiff_t, not size_t.
911 All variadic functions and their callers changed accordingly.
912 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
913 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
914 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
915 * callint.c (Fcall_interactively): Check arg count for overflow,
916 to avoid potential buffer overrun. Use signed char, not 'int',
917 for 'varies' array, so that we needn't bother to check its size
918 calculation for overflow.
919 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
920 * eval.c (apply_lambda):
921 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
922 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
923 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
925 * callint.c (Fcall_interactively): Don't use index var as event count.
927 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
928 * mem-limits.h (SIZE): Remove; no longer used.
930 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
932 Remove unnecessary casts.
933 * xterm.c (x_term_init):
934 * xfns.c (x_set_border_pixel):
935 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
936 These aren't needed now that we assume ANSI C.
938 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
939 It's more likely to cause problems (due to unsigned overflow)
942 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
944 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
946 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
948 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
950 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
952 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
954 GLYPH_CODE_FACE returns EMACS_INT, not int.
955 * dispextern.h (merge_faces):
956 * xfaces.c (merge_faces):
957 * xdisp.c (get_next_display_element, next_element_from_display_vector):
958 Don't assume EMACS_INT fits in int.
960 * character.h (CHAR_VALID_P): Remove unused parameter.
961 * fontset.c, lisp.h, xdisp.c: All uses changed.
963 * editfns.c (Ftranslate_region_internal): Omit redundant test.
965 * fns.c (concat): Minor tuning based on overflow analysis.
966 This doesn't fix any bugs. Use int to hold character, instead
967 of constantly refetching from Emacs object. Use XFASTINT, not
968 XINT, for value known to be a character. Don't bother comparing
969 a single byte to 0400, as it's always less.
971 * floatfns.c (Fexpt):
972 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
974 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
977 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
979 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
980 Without this fix, on a 64-bit host (aset S 0 4294967386) would
981 incorrectly succeed when S was a string, because 4294967386 was
982 truncated before it was used.
984 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
985 Otherwise, an out-of-range integer could cause undefined behavior
988 * composite.c: Use int, not EMACS_INT, for characters.
989 (fill_gstring_body, composition_compute_stop_pos): Use int, not
990 EMACS_INT, for values that are known to be in character range.
991 This doesn't fix any bugs but is the usual style inside Emacs and
992 may generate better code on 32-bit machines.
994 Make sure a 64-bit char is never passed to ENCODE_CHAR.
995 This is for reasons similar to the recent CHAR_STRING fix.
996 * charset.c (Fencode_char): Check that character arg is actually
997 a character. Pass an int to ENCODE_CHAR.
998 * charset.h (ENCODE_CHAR): Verify that the character argument is no
999 wider than 'int', as a compile-time check to prevent future regressions
1002 * character.c (char_string): Remove unnecessary casts.
1004 Make sure a 64-bit char is never passed to CHAR_STRING.
1005 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1006 by silently ignoring the top 32 bits, allowing some values
1007 that were far too large to be valid characters.
1008 * character.h: Include <verify.h>.
1009 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1010 arguments are no wider than unsigned, as a compile-time check
1011 to prevent future regressions in this area.
1013 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1014 (Fsubst_char_in_region):
1016 * xdisp.c (decode_mode_spec_coding):
1017 Adjust to CHAR_STRING's new requirement.
1018 * editfns.c (Finsert_char, Fsubst_char_in_region):
1019 * fns.c (concat): Check that character args are actually
1020 characters. Without this test, these functions did the wrong
1021 thing with wildly out-of-range values on 64-bit hosts.
1023 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1024 These casts should not be needed on 32-bit hosts, either.
1025 * keyboard.c (read_char):
1026 * lread.c (Fload): Remove casts to unsigned.
1028 * lisp.h (UNSIGNED_CMP): New macro.
1029 This fixes comparison bugs on 64-bit hosts.
1030 (ASCII_CHAR_P): Use it.
1031 * casefiddle.c (casify_object):
1032 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1033 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1034 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1035 * dispextern.h (FACE_FROM_ID):
1036 * keyboard.c (read_char): Use UNSIGNED_CMP.
1038 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1039 not to EMACS_INT, to avoid GCC warning.
1041 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1043 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1044 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1045 isn't needed on 32-bit machines.
1047 * buffer.c (Fgenerate_new_buffer_name):
1048 Use EMACS_INT for count, not int.
1049 (advance_to_char_boundary): Return EMACS_INT, not int.
1051 * data.c (Qcompiled_function): Now static.
1053 * window.c (window_body_lines): Now static.
1055 * image.c (gif_load): Rename local to avoid shadowing.
1057 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1058 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1059 * alloc.c (make_save_value): Integer argument is now of type
1061 (mark_object): Use ptrdiff_t, not int.
1062 * lisp.h (pD): New macro.
1063 * print.c (print_object): Use it.
1065 * alloc.c: Use EMACS_INT, not int, to count objects.
1066 (total_conses, total_markers, total_symbols, total_vector_size)
1067 (total_free_conses, total_free_markers, total_free_symbols)
1068 (total_free_floats, total_floats, total_free_intervals)
1069 (total_intervals, total_strings, total_free_strings):
1070 Now EMACS_INT, not int. All uses changed.
1071 (Fgarbage_collect): Compute overall total using a double, so that
1072 integer overflow is less likely to be a problem. Check for overflow
1073 when converting back to an integer.
1074 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1075 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1076 These were 'int' variables that could overflow on 64-bit hosts;
1077 they were never used, so remove them instead of repairing them.
1078 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1079 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1080 Previously, this ceilinged at INT_MAX, but that doesn't work on
1082 (allocate_pseudovector): Don't use EMACS_INT when int would do.
1084 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1085 (allocate_vectorlike): Check for ptrdiff_t overflow.
1086 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1087 when a (possibly-narrower) signed value would do just as well.
1088 We prefer using signed arithmetic, to avoid comparison confusion.
1090 * alloc.c: Catch some string size overflows that we were missing.
1091 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1092 for convenience in STRING_BYTES_MAX.
1093 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1094 The definition here is exact; the one in lisp.h was approximate.
1095 (allocate_string_data): Check for string overflow. This catches
1096 some instances we weren't catching before. Also, it catches
1097 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1098 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1099 and ptrdiff_t and EMACS_INT are both 64 bits.
1101 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1102 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1103 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1105 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1107 * alloc.c (Fmake_string): Check for out-of-range init.
1109 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1111 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1113 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1115 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1116 xg_get_default_scrollbar_width.
1118 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1119 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1120 (style_changed_cb): Call update_theme_scrollbar_width and call
1121 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1122 all frames (Bug#8505).
1123 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1124 Call gtk_window_set_resizable if HAVE_GTK3.
1125 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1126 and height if HAVE_GTK3 (Bug#8505).
1127 (scroll_bar_width_for_theme): New variable.
1128 (update_theme_scrollbar_width): New function.
1129 (xg_get_default_scrollbar_width): Move code to
1130 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1131 (xg_initialize): Call update_theme_scrollbar_width.
1133 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1135 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1137 2011-06-12 Martin Rudalics <rudalics@gmx.at>
1139 * frame.c (make_frame): Call other_buffer_safely instead of
1142 * window.c (temp_output_buffer_show): Call display_buffer with
1143 second argument Vtemp_buffer_show_specifiers and reset latter
1144 immediately after the call.
1145 (Vtemp_buffer_show_specifiers): New variable.
1146 (auto_window_vscroll_p, next_screen_context_lines)
1147 (Vscroll_preserve_screen_position): Remove leading asterisks from
1150 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
1152 Fix minor problems found by GCC 4.6.0 static checking.
1153 * buffer.c (Qclone_number): Remove for now, as it's unused.
1154 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1155 (record_buffer): Remove unused local.
1156 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1157 (set_frame_buffer_list): Remove; unused.
1158 * frame.h (other_visible_frames): Remove decl.
1159 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1160 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1161 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1163 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1164 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1165 Define only if HAVE_GPM.
1166 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1167 (update_hints_inhibit): Remove; never set. All uses removed.
1168 * widgetprv.h (emacsFrameClassRec): Remove decl.
1169 * window.c (delete_deletable_window): Now returns void, since it
1170 wasn't returning anything.
1171 (compare_window_configurations): Remove unused locals.
1172 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1173 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
1174 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1175 the same widths as pointers. This follows up on the 2011-05-06 patch.
1176 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1177 * xterm.h: Likewise.
1178 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1180 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
1182 * makefile.w32-in: Update dependencies.
1183 (LISP_H): Add lib/intprops.h.
1185 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1187 * image.c (gif_load): Add animation frame delay to the metadata.
1188 (syms_of_image): Use DEFSYM. New symbol `delay'.
1190 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1192 * window.c (delete_deletable_window): Re-add.
1193 (Fset_window_configuration): Rewrite to handle dead buffers and
1194 consequently deletable windows.
1195 (window_tree, Fwindow_tree): Remove. Supply functionality in
1197 (compare_window_configurations): Simplify code.
1199 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1201 * image.c (imagemagick_load_image): Fix type mismatch.
1202 (Fimagemagick_types): Likewise.
1204 * window.h (replace_buffer_in_windows): Declare.
1206 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1208 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1209 Qclone_number. Remove external declaration of Qdelete_window.
1210 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1212 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1213 Qbuffer_list_update_hook if allowed.
1214 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1215 buffer list implementation.
1216 (other_buffer_safely): New function.
1217 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1218 calls to replace_buffer_in_windows and
1219 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1221 (record_buffer): Inhibit quitting and rewrite using quittable
1222 functions. Run Qbuffer_list_update_hook if allowed.
1223 (Frecord_buffer, Funrecord_buffer): New functions.
1224 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1225 switch-to-buffer to window.el.
1226 (bury-buffer): Move to window.el.
1227 (Vbuffer_list_update_hook): New variable.
1229 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1232 * window.h (resize_frame_windows): Move up in code.
1233 (Fwindow_frame): Remove EXFUN.
1234 (replace_buffer_in_all_windows): Remove prototype.
1235 (replace_buffer_in_windows_safely): Add prototype.
1237 * window.c: Declare Qdelete_window static again. Move down
1238 declaration of select_count.
1239 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1240 (Fother_window): Move to window.el.
1241 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1242 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1243 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1245 (replace_buffer_in_windows): Implement by calling
1246 Qreplace_buffer_in_windows.
1247 (replace_buffer_in_all_windows): Remove with some functionality
1248 moved into replace_buffer_in_windows_safely.
1249 (replace_buffer_in_windows_safely): New function.
1250 (select_window_norecord, select_frame_norecord): Move in front
1251 of run_window_configuration_change_hook. Remove now obsolete
1253 (Fset_window_buffer): Rewrite doc-string. Call
1254 Qrecord_window_buffer.
1255 (keys_of_window): Move binding for other-window to window.el.
1257 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1259 * dispextern.h (struct image): Replace data member, whose int_val
1260 and ptr_val fields were not used by anything, with a single
1263 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1264 (gif_clear_image, gif_load, imagemagick_load_image)
1265 (gs_clear_image, gs_load): Callers changed.
1267 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1269 * buffer.h: Include <time.h>, for time_t.
1270 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1272 Fix minor problems found by static checking.
1274 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1276 Make identifiers static if they are not used in other modules.
1277 * data.c (Qcompiled_function, Qframe, Qvector):
1278 * image.c (QimageMagick, Qsvg):
1279 * minibuf.c (Qmetadata):
1280 * window.c (resize_window_check, resize_root_window): Now static.
1281 * window.h (resize_window_check, resize_root_window): Remove decls.
1283 * window.c (window_deletion_count, delete_deletable_window):
1285 (window_body_lines): Now static.
1286 (Fdelete_other_windows_internal): Mark vars as initialized.
1287 Make sure 'resize_failed' is initialized.
1288 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1289 (resize_window_apply): Remove unused local.
1290 * window.h (delete_deletable_window): Remove decl.
1292 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
1293 (imagemagick_load_image): Fix pointer signedness problem by changing
1294 last arg from unsigned char * to char *. All uses changed.
1295 Also, fix a local for similar reasons.
1296 Remove unused locals. Remove locals to avoid shadowing.
1297 (fn_rsvg_handle_free): Remove; unused.
1298 (svg_load, svg_load_image): Fix pointer signedness problem.
1299 (imagemagick_load_image): Don't use garbage pointer image_wand.
1301 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1303 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
1305 * image.c (gif_load): Fix omitted cast error introduced by
1308 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1310 * window.h (resize_proportionally, orig_total_lines)
1311 (orig_top_line): Remove from window structure.
1312 (set_window_height, set_window_width, change_window_heights)
1313 (Fdelete_window): Remove prototypes.
1314 (resize_frame_windows): Remove duplicate declaration.
1316 2011-06-10 Eli Zaretskii <eliz@gnu.org>
1318 * window.h (resize_frame_windows, resize_window_check)
1319 (delete_deletable_window, resize_root_window)
1320 (resize_frame_windows): Declare prototypes.
1322 * window.c (resize_window_apply): Make definition be "static" to
1323 match the prototype.
1325 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1327 * window.c: Remove declarations of Qwindow_size_fixed,
1328 window_min_size_1, window_min_size_2, window_min_size,
1329 size_window, window_fixed_size_p, enlarge_window, delete_window.
1330 Remove static from declaration of Qdelete_window, it's
1331 temporarily needed by Fbury_buffer.
1332 (replace_window): Don't assign orig_top_line and
1334 (Fdelete_window, delete_window): Remove. Window deletion is
1335 handled by window.el.
1336 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1337 Fdelete_window calls with calls to Qdelete_window.
1338 (Fdelete_other_windows): Remove. Deleting other windows is
1339 handled by window.el.
1340 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1341 handled in window.el.
1342 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1343 Window minimum sizes are handled in window.el.
1344 (shrink_windows, size_window, set_window_height)
1345 (set_window_width, change_window_heights, window_height)
1346 (window_width, CURBEG, CURSIZE, enlarge_window)
1347 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1348 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1349 handled in window.el.
1350 (make_dummy_parent): Rename to make_parent_window and give it a
1351 second argument horflag.
1352 (make_window): Don't set resize_proportionally any more.
1353 (Fsplit_window): Remove. Windows are split in window.el.
1354 (save_restore_action, save_restore_orig_size)
1355 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1356 Resize mini windows in window.el.
1357 (grow_mini_window, shrink_mini_window): Implement by calling
1358 Qresize_root_window_vertically, resize_window_check and
1359 resize_window_apply.
1360 (saved_window, Fset_window_configuration, save_window_save): Do
1361 not handle orig_top_line, orig_total_lines, and
1362 resize_proportionally.
1363 (window_min_height, window_min_width): Move to window.el.
1364 (keys_of_window): Move bindings for delete-other-windows,
1365 split-window, delete-window and enlarge-window to window.el.
1367 * buffer.c: Temporarily extern Qdelete_window.
1368 (Fbury_buffer): Temporarily call Qdelete_window instead of
1369 Fdelete_window (Fbury_buffer will move to window.el soon).
1371 * frame.c (set_menu_bar_lines_1): Remove code handling
1372 orig_top_line and orig_total_lines.
1374 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1375 set_window_height but set heights directly.
1376 (change_frame_size_1): Use resize_frame_windows.
1378 * xdisp.c (init_xdisp): Don't use set_window_height but set
1381 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1382 resize_frame_windows instead of change_window_heights and run
1383 run_window_configuration_change_hook.
1385 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1386 instead of change_window_heights and run
1387 run_window_configuration_change_hook.
1389 2011-06-09 Martin Rudalics <rudalics@gmx.at>
1391 * window.c (replace_window): Rename second argument REPLACEMENT to
1392 NEW. New third argument SETFLAG. Rewrite.
1393 (delete_window, make_dummy_parent): Call replace_window with
1395 (window_list_1): Move down in code.
1396 (run_window_configuration_change_hook): Move set_buffer part
1397 before select_frame_norecord part in order to unwind correctly.
1398 Rename count1 to count.
1399 (recombine_windows, delete_deletable_window, resize_root_window)
1400 (Fdelete_other_windows_internal)
1401 (Frun_window_configuration_change_hook, make_parent_window)
1402 (resize_window_check, resize_window_apply, Fresize_window_apply)
1403 (resize_frame_windows, Fsplit_window_internal)
1404 (Fdelete_window_internal, Fresize_mini_window_internal): New
1406 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1408 2011-06-08 Martin Rudalics <rudalics@gmx.at>
1410 * window.h (window): Add some new members to window structure -
1411 normal_lines, normal_cols, new_total, new_normal, clone_number,
1412 splits, nest, prev_buffers, next_buffers.
1413 (WINDOW_TOTAL_SIZE): Move here from window.c.
1414 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1416 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1418 (make_dummy_parent): Set new members of windows structure.
1419 (make_window): Move down in code. Handle new members of window
1421 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1422 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1423 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1424 (Fset_window_prev_buffers, Fwindow_next_buffers)
1425 (Fset_window_next_buffers, Fset_window_clone_number): New
1427 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1428 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1430 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1431 Argument WINDOW can be now internal window too.
1432 (Fwindow_use_time): Move up in code.
1433 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1435 (Fset_window_configuration, saved_window)
1436 (Fcurrent_window_configuration, save_window_save): Handle new
1437 members of window structure.
1438 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1439 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1440 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1441 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1442 Qget_mru_window, Qresize_root_window,
1443 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1444 Qauto_buffer_name; staticpro them.
1446 2011-06-07 Martin Rudalics <rudalics@gmx.at>
1448 * window.c (Fwindow_total_size, Fwindow_left_column)
1449 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1450 (Fwindow_list_1): New functions.
1451 (window_box_text_cols): Replace with window_body_cols.
1452 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1453 window_body_cols instead of window_box_text_cols.
1454 (delete_window, Fset_window_configuration): Call
1455 delete_all_subwindows with window as argument.
1456 (delete_all_subwindows): Take a window as argument and not a
1458 (window_loop): Remove handling of GET_LRU_WINDOW and
1460 (Fget_lru_window, Fget_largest_window): Move to window.el.
1462 * window.h: Extern window_body_cols instead of
1463 window_box_text_cols. delete_all_subwindows now takes a
1464 Lisp_Object as argument.
1466 * indent.c (compute_motion, Fcompute_motion): Use
1467 window_body_cols instead of window_box_text_cols.
1469 * frame.c (delete_frame): Call delete_all_subwindows with root
1472 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1474 * fns.c (Fputhash): Document return value.
1476 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
1478 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1480 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1482 Cons<->int and similar integer overflow fixes (Bug#8794).
1484 Check for overflow when converting integer to cons and back.
1485 * charset.c (Fdefine_charset_internal, Fdecode_char):
1486 Use cons_to_unsigned to catch overflow.
1487 (Fencode_char): Use INTEGER_TO_CONS.
1488 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1489 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1490 * data.c (long_to_cons, cons_to_long): Remove.
1491 (cons_to_unsigned, cons_to_signed): New functions.
1492 These signal an error for invalid or out-of-range values.
1493 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1494 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1495 * font.c (Ffont_variation_glyphs):
1496 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1497 * lisp.h: Include <intprops.h>.
1498 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1499 (cons_to_signed, cons_to_unsigned): New decls.
1500 (long_to_cons, cons_to_long): Remove decls.
1501 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1502 (Fprimitive_undo): Use CONS_TO_INTEGER.
1503 * xfns.c (Fx_window_property): Likewise.
1504 * xselect.c: Include <limits.h>.
1505 (x_own_selection, selection_data_to_lisp_data):
1506 Use INTEGER_TO_CONS.
1507 (x_handle_selection_request, x_handle_selection_clear)
1508 (x_get_foreign_selection, Fx_disown_selection_internal)
1509 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1510 (lisp_data_to_selection_data): Use cons_to_unsigned.
1511 (x_fill_property_data): Use cons_to_signed.
1512 Report values out of range.
1514 Check for buffer and string overflow more precisely.
1515 * buffer.h (BUF_BYTES_MAX): New macro.
1516 * lisp.h (STRING_BYTES_MAX): New macro.
1517 * alloc.c (Fmake_string):
1518 * character.c (string_escape_byte8):
1519 * coding.c (coding_alloc_by_realloc):
1520 * doprnt.c (doprnt):
1521 * editfns.c (Fformat):
1523 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1524 since they may not be the same number.
1525 * editfns.c (Finsert_char):
1526 * fileio.c (Finsert_file_contents):
1527 Likewise for BUF_BYTES_MAX.
1529 * image.c: Use ptrdiff_t, not int, for sizes.
1530 (slurp_file): Switch from int to ptrdiff_t.
1532 (slurp_file): Check that file size fits in both size_t (for
1533 malloc) and ptrdiff_t (for sanity and safety).
1535 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1536 if b->modtime has its maximal value.
1538 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1540 Don't assume time_t can fit into int.
1541 * buffer.h (struct buffer.modtime): Now time_t, not int.
1542 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1543 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1545 Minor fixes for signed vs unsigned integers.
1546 * character.h (MAYBE_UNIFY_CHAR):
1547 * charset.c (maybe_unify_char):
1548 * keyboard.c (read_char, reorder_modifiers):
1549 XINT -> XFASTINT, since the integer must be nonnegative.
1550 * ftfont.c (ftfont_spec_pattern):
1551 * keymap.c (access_keymap, silly_event_symbol_error):
1552 XUINT -> XFASTINT, since the integer must be nonnegative.
1553 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1554 since it makes no difference and we prefer signed.
1555 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1556 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1559 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1561 * window.h (Fwindow_frame): Declare.
1563 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1565 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1566 (SPARE_MEMORY): Always define.
1567 (LARGE_REQUEST): Remove.
1568 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1570 2011-06-06 Martin Rudalics <rudalics@gmx.at>
1572 * lisp.h: Move EXFUNS for Fframe_root_window,
1573 Fframe_first_window and Fset_frame_selected_window to window.h.
1575 * window.h: Move EXFUNS for Fframe_root_window,
1576 Fframe_first_window and Fset_frame_selected_window here from
1579 * frame.c (Fwindow_frame, Fframe_first_window)
1580 (Fframe_root_window, Fframe_selected_window)
1581 (Fset_frame_selected_window): Move to window.c.
1582 (Factive_minibuffer_window): Move to minibuf.c.
1583 (Fother_visible_frames_p): New function.
1585 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1587 * window.c (decode_window, decode_any_window): Move up in code.
1588 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1589 (inhibit_frame_unsplittable): Remove unused variable.
1590 (Fwindow_buffer): Move up and rewrite doc-string.
1591 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1592 (Fwindow_prev): New functions.
1593 (Fwindow_frame): Move here from frame.c. Accept any window as
1595 (Fframe_root_window, Fframe_first_window)
1596 (Fframe_selected_window): Move here from frame.c. Accept frame
1597 or arbitrary window as argument. Update doc-strings.
1598 (Fminibuffer_window): Move up in code.
1599 (Fwindow_minibuffer_p): Move up in code and simplify.
1600 (Fset_frame_selected_window): Move here from frame.c.
1602 (Fselected_window, select_window, Fselect_window): Move up in
1603 code. Minor doc-string fixes.
1605 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1607 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1608 Do not assume that spare memory exists; that assumption is valid
1609 only if SYSTEM_MALLOC.
1610 (LARGE_REQUEST): New macro, so that the issue of large requests
1611 is separated from the issue of spare memory.
1613 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1615 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1618 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1620 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1623 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1625 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1627 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1629 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1630 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1632 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
1634 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1636 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
1638 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1639 (x_clipboard_manager_save): Add return value.
1640 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1642 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1643 Obey Vx_select_enable_clipboard_manager. Catch errors in
1644 x_clipboard_manager_save (Bug#8779).
1645 (Vx_select_enable_clipboard_manager): New variable.
1646 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
1648 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
1650 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1652 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1654 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1655 in the current matrix if keep_current_p is non-zero.
1657 2011-06-04 Eli Zaretskii <eliz@gnu.org>
1659 * bidi.c (bidi_level_of_next_char): Fix last change.
1661 2011-06-03 Eli Zaretskii <eliz@gnu.org>
1663 Support bidi reordering of text covered by display properties.
1665 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1666 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1667 (bidi_cache_search, bidi_cache_iterator_state)
1668 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1669 (bidi_level_of_next_char, bidi_move_to_visually_next):
1670 Support character positions inside a run of characters covered by a
1672 (bidi_paragraph_init, bidi_resolve_explicit_1)
1673 (bidi_level_of_next_char): Call bidi_fetch_char and
1674 bidi_fetch_char_advance instead of FETCH_CHAR and
1676 (bidi_init_it): Initialize new members.
1677 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1679 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1680 instead of using explicit *_CHAR codes.
1681 (bidi_resolve_explicit, bidi_resolve_weak):
1682 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
1683 bidirectional text is supported only in multibyte buffers.
1684 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1685 it to initialize the frame_window_p member of struct bidi_it.
1686 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1687 (bidi_resolve_explicit, bidi_resolve_weak)
1688 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1689 bidi_it->nchars is non-positive.
1690 (bidi_level_of_next_char): Don't try to lookup the cache for the
1691 next/previous character if nothing is cached there yet, or if we
1692 were just reseat()'ed to a new position.
1694 * xdisp.c (set_cursor_from_row): Set start and stop points
1695 according to the row's direction when priming the loop that looks
1696 for the glyph on which to display cursor.
1697 (single_display_spec_intangible_p): Function deleted.
1698 (display_prop_intangible_p): Reimplement to call
1699 handle_display_spec instead of single_display_spec_intangible_p.
1700 Accept 3 additional arguments needed by handle_display_spec.
1701 This fixes incorrect cursor motion across display property with complex
1702 values: lists, `(when COND...)' forms, etc.
1703 (single_display_spec_string_p): Support property values that are
1704 lists with the argument STRING its top-level element.
1705 (display_prop_string_p): Fix the condition for processing a
1706 property that is a list to be consistent with handle_display_spec.
1707 (handle_display_spec): New function, refactored from the
1708 last portion of handle_display_prop.
1709 (compute_display_string_pos): Accept additional argument
1710 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1711 value of a `display' property is a "replacing spec".
1712 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1713 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1714 the display property, but just return a value indicating whether
1715 the display property will replace the characters it covers.
1716 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1717 frame_window_p members of struct bidi_it.
1718 (compute_display_string_pos, compute_display_string_end):
1720 (push_it): Accept second argument POSITION, where pop_it should
1721 jump to continue iteration.
1722 (reseat_1): Initialize bidi_it.disp_pos.
1724 * keyboard.c (adjust_point_for_property): Adjust the call to
1725 display_prop_intangible_p to its new signature.
1727 * dispextern.h (struct bidi_it): New member frame_window_p.
1728 (bidi_init_it): Update prototypes.
1729 (display_prop_intangible_p): Update prototype.
1730 (compute_display_string_pos, compute_display_string_end):
1732 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1735 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1737 Malloc failure behavior now depends on size of allocation.
1738 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1739 * lisp.h: Change signatures accordingly.
1740 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1741 All callers changed. (Bug#8762)
1743 * gnutls.c: Use Emacs's memory allocators.
1744 Without this change, the gnutls library would invoke malloc etc.
1745 directly, which causes problems on non-SYNC_INPUT hosts, and which
1746 runs afoul of improving memory_full behavior. (Bug#8761)
1747 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1748 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1749 xfree instead of the default malloc, realloc, free.
1750 (Fgnutls_boot): No need to check for memory allocation failure,
1751 since xmalloc does that for us.
1753 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1754 * category.c (hash_get_category_set):
1755 * ccl.c (ccl_driver):
1756 * charset.c (Fdefine_charset_internal):
1757 * charset.h (struct charset.hash_index):
1758 * composite.c (get_composition_id, gstring_lookup_cache)
1759 (composition_gstring_put_cache):
1760 * composite.h (struct composition.hash_index):
1761 * dispextern.h (struct image.hash):
1762 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1763 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1764 (hashfn_equal, hashfn_user_defined, make_hash_table)
1765 (maybe_resize_hash_table, hash_lookup, hash_put)
1766 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1767 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1768 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1769 * image.c (make_image, search_image_cache, lookup_image)
1770 (xpm_put_color_table_h):
1771 * lisp.h (struct Lisp_Hash_Table):
1772 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1773 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1774 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1775 * alloc.c (allocate_vectorlike):
1776 Check for overflow in vector size calculations.
1777 * ccl.c (ccl_driver):
1778 Check for overflow when converting EMACS_INT to int.
1779 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1780 need to be updated by these changes.
1781 * fns.c (make_hash_table, maybe_resize_hash_table):
1782 Check for integer overflow with large hash tables.
1783 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1784 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1785 (SXHASH_REDUCE): New macro.
1786 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1787 Use it instead of discarding useful hash info with large hash values.
1788 (sxhash_float): New function.
1789 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1790 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1791 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1792 Rewrite to use FIXNUM_BITS, as this simplifies things.
1793 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1794 Adjust signatures to match updated version of code.
1795 (consing_since_gc): Now EMACS_INT, since a single hash table can
1796 use more than INT_MAX bytes.
1798 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1800 Make it possible to build with GCC-4.6+ -O2 -flto.
1802 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1804 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1806 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1807 Call minibuffer-inactive-mode.
1809 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1811 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1812 Update dependencies.
1814 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1816 * data.c (init_data): Remove code for UTS, this system is not
1819 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1821 Don't force ./temacs to start in terminal mode.
1823 * frame.c (make_initial_frame): Initialize faces in all cases, not
1824 only when CANNOT_DUMP is defined.
1825 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1827 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1829 * dispnew.c (add_window_display_history): Use const for the string
1830 pointer. Remove declaration, not needed.
1832 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1834 Use 'inline', not 'INLINE'.
1835 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1836 * alloc.c, fontset.c (INLINE): Remove.
1837 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1838 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1839 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1840 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1841 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1843 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1845 Make it possible to run ./temacs.
1847 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1848 syms_of_callproc does the same thing. Remove test for
1849 "initialized", do it in the caller.
1850 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1852 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1854 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1855 (read_minibuf): Use get_minibuffer.
1856 (syms_of_minibuf): Use DEFSYM.
1857 (Qmetadata): New var.
1858 * data.c (Qbuffer): Don't make it static.
1859 (syms_of_data): Use DEFSYM.
1861 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1863 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1864 (CCL_CODE_MIN): New macro.
1866 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1868 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1870 * eval.c (Qdebug): Now static.
1871 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1872 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1873 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1875 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1877 * image.c: Various fixes to ImageMagick code comments.
1878 (Fimagemagick_types): Doc fix.
1880 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1882 Minor fixes prompted by GCC 4.6.0 warnings.
1884 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1886 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1887 (x_clipboard_manager_save_all): Move extern decl to ...
1888 * xterm.h: ... here, so that it can be checked for consistency.
1890 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1892 * xselect.c (x_clipboard_manager_save_frame)
1893 (x_clipboard_manager_save_all): New functions.
1894 (Fx_clipboard_manager_save): Lisp function deleted.
1896 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1897 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1899 * xterm.h: Update prototype.
1901 2011-05-28 William Xu <william.xwl@gmail.com>
1903 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1906 2011-05-28 Jim Meyering <meyering@redhat.com>
1908 Avoid a sign-extension bug in crypto_hash_function.
1909 * fns.c (to_uchar): Define.
1910 (crypto_hash_function): Use it to convert some newly-signed
1911 variables to unsigned, to avoid sign-extension bugs. For example,
1912 without this change, (md5 "truc") would evaluate to
1913 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1914 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1915 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1917 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1919 Integer overflow fixes.
1921 * dbusbind.c: Serial number integer overflow fixes.
1922 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1923 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1924 to hold a serial number that is too large for a fixnum.
1925 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1926 Check for serial numbers out of range. Decode any serial number
1927 that was so large that it became a float. (Bug#8722)
1929 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1930 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1931 Use XFASTINT rather than XUINT when numbers are nonnegative.
1932 (xd_append_arg, Fdbus_method_return_internal):
1933 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1934 arguments, check that Lisp number is nonnegative, rather than
1935 silently wrapping negative numbers around. (Bug#8722)
1936 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1939 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1941 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1943 ccl: add integer overflow checks
1944 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1945 (IN_INT_RANGE): New macros.
1946 (ccl_driver): Use them to check for integer overflow when
1947 decoding a CCL program. Many of the new checks are whether XINT (x)
1948 fits in int; it doesn't always, on 64-bit hosts. The new version
1949 doesn't catch all possible integer overflows, but it's an
1950 improvement. (Bug#8719)
1952 * alloc.c (make_event_array): Use XINT, not XUINT.
1953 There's no need for unsigned here.
1955 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1956 This follows up to the 2011-05-06 change that substituted uintptr_t
1957 for EMACS_INT. This case wasn't caught back then.
1959 Rework Fformat to avoid integer overflow issues.
1960 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1961 now (part of C89). Include <verify.h>.
1962 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1963 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1964 (Fformat): Avoid the prepass trying to compute sizes; it was only
1965 approximate and thus did not catch overflow reliably. Instead, walk
1966 through the format just once, formatting and computing sizes as we go,
1967 checking for integer overflow at every step, and allocating a larger
1968 buffer as needed. Keep track separately whether the format is
1969 multibyte. Keep only the most-recently calculated precision, rather
1970 than them all. Record whether each argument has been converted to
1971 string. Use EMACS_INT, not int, for byte and char and arg counts.
1972 Support field widths and precisions larger than INT_MAX. Avoid
1973 sprintf's undefined behavior with conversion specifications such as %#d
1974 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1975 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1976 formatting out-of-range floating point numbers with int
1979 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1981 * data.c: Avoid integer truncation in expressions involving floats.
1982 * data.c: Include <intprops.h>.
1983 (arith_driver): When there's an integer overflow in an expression
1984 involving floating point, convert the integers to floating point
1985 so that the resulting value does not suffer from catastrophic
1986 integer truncation. For example, on a 64-bit host (* 4
1987 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1988 Do not rely on undefined behavior after integer overflow.
1990 merge count_size_as_multibyte, parse_str_to_multibyte
1991 * character.c, character.h (count_size_as_multibyte):
1992 Rename from parse_str_to_multibyte; all uses changed.
1993 Check for integer overflow.
1994 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1995 since it's now a duplicate of the other. This is more of
1996 a character than a buffer op, so better that it's in character.c.
1997 * fns.c, print.c: Adjust to above changes.
1999 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2001 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2003 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2005 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2006 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2007 (x_clipboard_manager_save): Now static.
2008 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2010 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2011 (crypto_hash_function): Now static.
2012 Fix pointer signedness problems. Avoid unnecessary initializations.
2014 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2016 * termhooks.h (Vselection_alist): Make it terminal-local.
2018 * terminal.c (create_terminal): Initialize it.
2020 * xselect.c: Support for clipboard managers.
2021 (Vselection_alist): Move to termhooks.h as terminal-local var.
2022 (LOCAL_SELECTION): New macro.
2023 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2024 (symbol_to_x_atom): Remove gratuitous arg.
2025 (x_handle_selection_request, lisp_data_to_selection_data)
2026 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2027 (x_own_selection, x_get_local_selection, x_convert_selection):
2028 New arg, specifying work frame. Use terminal-local Vselection_alist.
2029 (some_frame_on_display): Delete unused function.
2030 (Fx_own_selection_internal, Fx_get_selection_internal)
2031 (Fx_disown_selection_internal, Fx_selection_owner_p)
2032 (Fx_selection_exists_p): New optional frame arg.
2033 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2034 (x_handle_selection_clear): Don't treat other terminals with the
2035 same keyboard specially. Use the terminal-local Vselection_alist.
2036 (x_clear_frame_selections): Use Frun_hook_with_args.
2038 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2040 * xterm.h: Add support for those atoms.
2042 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2044 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2045 (converted_selections, conversion_fail_tag): New global variables.
2046 (x_selection_request_lisp_error): Free the above.
2047 (x_get_local_selection): Remove unnecessary code.
2048 (x_reply_selection_request): Args changed; handle arbitrary array
2049 of converted selections stored in converted_selections.
2050 Separate the XChangeProperty and SelectionNotify steps.
2051 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2052 (x_convert_selection): New function.
2053 (x_handle_selection_event): Simplify.
2054 (x_get_foreign_selection): Don't ignore incoming requests while
2055 waiting for an answer; this will fail when we implement
2056 SAVE_TARGETS, and seems unnecessary anyway.
2057 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2058 (Vx_sent_selection_functions): Doc fix.
2060 2011-05-26 Leo Liu <sdl.web@gmail.com>
2062 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2064 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2066 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2068 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2069 for fringe update if it has periodic bitmap.
2070 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2071 and fringe_bitmap_periodic_p.
2073 * fringe.c (get_fringe_bitmap_data): New function.
2074 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2075 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2076 row. Mark glyph row for fringe update if periodicity changed.
2078 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2079 for fringe update unless it has periodic bitmap.
2081 2011-05-25 Kenichi Handa <handa@m17n.org>
2083 * xdisp.c (get_next_display_element): Set correct it->face_id for
2084 a static composition.
2086 2011-05-24 Leo Liu <sdl.web@gmail.com>
2089 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2091 * fns.c (crypto_hash_function, Fsha1): New function.
2092 (Fmd5): Use crypto_hash_function.
2093 (syms_of_fns): Add Ssha1.
2095 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2097 * gnutls.c: Remove unused macros.
2098 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2099 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2100 Remove macros that are defined and never used.
2101 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2103 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2105 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2106 (Fx_get_selection_internal): Minor cleanup.
2107 (Fx_own_selection_internal): Rename arguments for consistency with
2110 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2112 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2114 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2116 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2118 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2120 * dispnew.c (scrolling_window): Don't exclude the case that the
2121 last enabled row in the desired matrix touches the bottom boundary.
2123 2011-05-21 Glenn Morris <rgm@gnu.org>
2125 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2126 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2127 and add some more files.
2129 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2131 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2132 report_file_error introduced by the change from 2011-05-07.
2134 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2136 * systime.h (Time): Define only if emacs is defined.
2137 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2138 where the include path doesn't have X11/X.h by default. See
2139 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2141 2011-05-20 Kenichi Handa <handa@m17n.org>
2143 * composite.c (find_automatic_composition): Fix previous change.
2145 2011-05-20 Glenn Morris <rgm@gnu.org>
2147 * lisp.mk: New file, split from Makefile.in.
2148 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2149 (shortlisp): Remove.
2150 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2152 2011-05-19 Glenn Morris <rgm@gnu.org>
2154 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2155 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2156 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2157 (lisp): Set the order to that of loadup.el.
2158 (shortlisp): Make it a copy of $lisp.
2159 (SOME_MACHINE_LISP): Remove.
2160 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2161 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2163 2011-05-18 Kenichi Handa <handa@m17n.org>
2165 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2166 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2167 (find_automatic_composition): Mostly rewrite for efficiency.
2169 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
2171 * makefile.w32-in: Update dependencies.
2173 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2175 * menu.c: Include limits.h (fixes the MS-Windows build broken by
2176 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
2178 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
2180 Fix some integer overflow issues, such as string length overflow.
2182 * insdel.c (count_size_as_multibyte): Check for string overflow.
2184 * character.c (lisp_string_width): Check for string overflow.
2185 Use EMACS_INT, not int, for string indexes and lengths; in
2186 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2187 the resulting string length overflows an EMACS_INT; instead,
2188 report a string overflow if no precision given. When checking for
2189 precision exhaustion, use a check that cannot possibly have
2190 integer overflow. (Bug#8675)
2191 * character.h (lisp_string_width): Adjust to new signature.
2193 * alloc.c (string_overflow): New function.
2194 (Fmake_string): Use it. This doesn't change behavior, but saves
2195 a few bytes and will simplify future changes.
2196 * character.c (string_escape_byte8): Likewise.
2197 * lisp.h (string_overflow): New decl.
2199 Fixups, following up to the user-interface timestamp change.
2200 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2201 for UI timestamps, instead of unsigned long.
2202 * msdos.c (mouse_get_pos): Likewise.
2203 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
2204 * w32gui.h (Time): Define by including "systime.h" rather than by
2205 declaring it ourselves. (Bug#8664)
2207 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2208 * image.c (clear_image_cache): Likewise.
2210 * term.c (term_mouse_position): Don't assume time_t wraparound.
2212 Be more systematic about user-interface timestamps.
2213 Before, the code sometimes used 'Time', sometimes 'unsigned long',
2214 and sometimes 'EMACS_UINT', to represent these timestamps.
2215 This change causes it to use 'Time' uniformly, as that's what X uses.
2216 This makes the code easier to follow, and makes it easier to catch
2217 integer overflow bugs such as Bug#8664.
2218 * frame.c (Fmouse_position, Fmouse_pixel_position):
2219 Use Time, not unsigned long, for user-interface timestamps.
2220 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2221 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2222 * keyboard.h (last_event_timestamp): Likewise.
2223 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2224 * menu.h (xmenu_show): Likewise.
2225 * term.c (term_mouse_position): Likewise.
2226 * termhooks.h (struct input_event.timestamp): Likewise.
2227 (struct terminal.mouse_position_hook): Likewise.
2228 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2229 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2230 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2231 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2233 * menu.h, termhooks.h: Include "systime.h", for Time.
2235 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2236 Don't assume that the difference between two unsigned long values
2237 can fit into an integer. At this point, we know button_down_time
2238 <= event->timestamp, so the difference must be nonnegative, so
2239 there's no need to cast the result if double-click-time is
2240 nonnegative, as it should be; check that it's nonnegative, just in
2241 case. This bug is triggered when events are more than 2**31 ms
2242 apart (about 25 days). (Bug#8664)
2244 * xselect.c (last_event_timestamp): Remove duplicate decl.
2245 (x_own_selection): Remove needless cast to unsigned long.
2247 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2248 that always fit in int. Use a sentinel instead of a counter, to
2249 avoid a temp and to allay GCC's concerns about possible int overflow.
2250 * frame.h (struct frame): Use int for menu_bar_items_used
2251 instead of EMACS_INT, since it always fits in int.
2253 * menu.c (grow_menu_items): Check for int overflow.
2255 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2257 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2258 Before, the code was not consistent. These values cannot exceed
2259 2**31 - 1 so there's no need to make them unsigned.
2260 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2261 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2262 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2264 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2266 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2267 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2268 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2269 presumably because the widths might not match.
2271 * window.c (size_window): Avoid needless test at loop start.
2273 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2275 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2277 2011-05-12 Drew Adams <drew.adams@oracle.com>
2279 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2281 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2283 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2284 `width' to `bar_area_x' and `bar_area_width', respectively.
2285 (x_scroll_run): Take account of fringe background extension.
2287 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2288 Rename local vars `left' and `width' to `bar_area_x' and
2289 `bar_area_width', respectively.
2290 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2291 background extension.
2293 2011-05-10 Jim Meyering <meyering@redhat.com>
2295 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2297 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
2299 * image.c (Finit_image_library): Return t for built-in image types,
2300 like pbm and xbm. (Bug#8640)
2302 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2304 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2306 2011-05-07 Eli Zaretskii <eliz@gnu.org>
2308 * w32console.c (Fset_screen_color): Doc fix.
2309 (Fget_screen_color): New function.
2310 (syms_of_ntterm): Defsubr it.
2312 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2313 unlink the temporary file if Fcall_process didn't create it in the
2315 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2316 child process will be redirected to a file specified with `:file'.
2317 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2318 cue to call_process_cleanup not to close that handle.
2320 2011-05-07 Ben Key <bkey76@gmail.com>
2322 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2323 one of two shell specific rules, either bootstrap-temacs-CMD or
2324 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2325 to the previous implementation of the bootstrap-temacs rule.
2326 The bootstrap-temacs-CMD rule is similar to the previous
2327 implementation of the bootstrap-temacs rule except that it
2328 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2331 These changes, along with some changes to nt/configure.bat,
2332 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2333 earlier fix to add support for --cflags and --ldflags options
2334 that include quotes so that it works whether make uses cmd or
2337 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
2339 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2340 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2342 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2343 a string. Handle both cases.
2344 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2345 (Fdbus_register_method): Use Qinvalid_function.
2347 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2349 * makefile.w32-in: Update dependencies.
2350 (LISP_H): Add inttypes.h and stdin.h.
2351 (PROCESS_H): Add unistd.h.
2353 2011-05-06 Eli Zaretskii <eliz@gnu.org>
2355 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2356 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2358 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
2360 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2362 * term.c (vfatal): Remove stray call to va_end.
2363 It's not needed and the C Standard doesn't allow it here anyway.
2365 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2366 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2368 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2371 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2373 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2375 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2377 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2379 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2381 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2382 * charset.c (Fdefine_charset_internal): Don't initialize
2383 charset.code_space[15]. The value was garbage, on hosts with
2384 32-bit int (Bug#8600).
2386 * lread.c (read_integer): Be more consistent with string-to-number.
2387 Use string_to_number to do the actual conversion; this avoids
2388 rounding errors and fixes some other screwups. Without this fix,
2389 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2390 (digit_to_number): Move earlier, for benefit of read_integer.
2391 Return -1 if the digit is out of range for the base, -2 if it is
2392 not a digit in any supported base. (Bug#8602)
2394 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2396 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2397 to match comment at start of function. This also removes a
2398 GCC warning about overflow in a 32+64-bit port.
2400 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2402 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2403 Reported by Stefan Monnier in
2404 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2405 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2406 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2408 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2409 (EMACS_UINTPTR): Likewise, with uintptr_t.
2411 * lisp.h: Prefer 64-bit EMACS_INT if available.
2412 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2413 on 32-bit hosts that have 64-bit int, so that they can access
2415 However, temporarily disable this change unless the temporary
2416 symbol WIDE_EMACS_INT is defined.
2418 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2420 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2421 This removes an assumption that EMACS_INT and long are the same
2422 width as pointers. The assumption is true for Emacs porting targets
2423 now, but we want to make other targets possible.
2424 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2425 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2426 In the rest of the code, change types of integers that hold casted
2427 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2428 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2429 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2430 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2431 No need to cast type when ORing.
2432 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2433 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2434 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2435 assume EMACS_INT is the same width as char *.
2436 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2437 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2438 Remove no-longer-needed casts.
2439 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2440 (xg_tool_bar_help_callback, xg_make_tool_item):
2441 Use EMACS_INTPTR to hold an integer
2442 that will be cast to void *; this can avoid a GCC warning
2443 if EMACS_INT is not the same width as void *.
2444 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2445 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2446 (current_message_1, set_message_1):
2447 Use a local to convert to proper width without a cast.
2448 * xmenu.c (dialog_selection_callback): Likewise.
2450 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2451 Also, don't assume VALBITS / RAND_BITS is less than 5,
2452 and don't rely on undefined behavior when shifting a 1 left into
2454 * lisp.h (get_random): Change signature to match.
2456 * lread.c (hash_string): Use size_t, not int, for hash computation.
2457 Normally we prefer signed values; but hashing is special, because
2458 it's better to use unsigned division on hash table sizes so that
2459 the remainder is nonnegative. Also, size_t is the natural width
2460 for hashing into memory. The previous code used 'int', which doesn't
2461 retain enough info to hash well into very large tables.
2462 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2464 * dbusbind.c: Don't possibly lose pointer info when converting.
2465 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2466 Use XPNTR rather than XHASH, so that the high-order bits of
2467 the pointer aren't lost when converting through void *.
2469 * eval.c (Fautoload): Don't double-shift a pointer.
2471 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2473 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2475 * gnutls.c (DEF_GNUTLS_FN):
2476 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2478 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2480 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2483 2011-05-05 Eli Zaretskii <eliz@gnu.org>
2485 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2486 New version that can reserve upto 2GB of heap space.
2488 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
2490 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2492 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2494 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2495 `gnutls_certificate_set_x509_key_file'.
2497 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
2499 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2500 Update dependencies.
2502 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2504 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2505 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2506 Remove unused parameter `fildes'.
2507 * process.c (read_process_output, send_process): Don't pass it.
2509 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2511 Fix previous change: the library cache is defined in w32.c.
2512 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2513 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2515 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2517 Implement dynamic loading of GnuTLS on Windows.
2519 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2520 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2521 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2524 * gnutls.c (Qgnutls_dll): Define.
2525 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2526 (gnutls_*): Declare function pointers.
2527 (init_gnutls_functions): New function to initialize function pointers.
2528 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2529 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2530 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2531 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2532 (emacs_gnutls_write, emacs_gnutls_read)
2533 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2534 (Fgnutls_available_p): New function.
2535 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2536 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2537 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2539 * image.c: Include w32.h.
2540 (Vimage_type_cache): Delete.
2541 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2542 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2543 (w32_delayed_load): Move to w32.c.
2545 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2547 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2548 (w32_delayed_load): Move from image.c. When loading a library, record
2549 its filename in the :loaded-from property of the library id.
2550 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2551 Initialize and staticpro them.
2552 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2554 * process.c: Include lisp.h before w32.h, not after.
2555 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2556 instead of gnutls_record_check_pending.
2558 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2560 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2562 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2563 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2566 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2568 * xterm.c (x_set_frame_alpha): Do not set property on anything
2569 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2571 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2573 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2575 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2577 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2578 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2579 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2580 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2581 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2582 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2583 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2584 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2585 (Qgnutls_bootprop_callbacks_verify): Make static.
2587 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2589 * callproc.c: Indentation fixup.
2591 * sysdep.c (wait_for_termination_1): Make static.
2592 (wait_for_termination, interruptible_wait_for_termination):
2593 Move after wait_for_termination_1.
2595 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2597 * sysdep.c (interruptible_wait_for_termination): New function
2598 which is like wait_for_termination, but allows keyboard
2601 * callproc.c (Fcall_process): Add (:file "file") as an option for
2603 (Fcall_process_region): Ditto.
2605 2011-04-30 Eli Zaretskii <eliz@gnu.org>
2607 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2608 rather than `XVECTOR (FOO)->size'.
2610 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2611 inttypes.h, as a gnulib replacement is used if it not available in
2614 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2616 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2617 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2618 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2620 * coding.c (coding_alloc_by_realloc): Error out if destination
2621 will grow beyond MOST_POSITIVE_FIXNUM.
2622 (decode_coding_emacs_mule): Abort if there isn't enough place in
2623 charbuf for the composition carryover bytes. Reserve an extra
2624 space for up to 2 characters produced in a loop.
2625 (decode_coding_iso_2022): Abort if there isn't enough place in
2626 charbuf for the composition carryover bytes.
2628 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2630 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2631 aborting when %lld or %lll format is passed.
2632 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2633 %llo or %llx format is passed. (Bug#8545)
2635 * window.c (window_scroll_line_based): Use a marker instead of
2636 simple variables to record original value of point. (Bug#7952)
2638 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2639 produced by %s or %c overflows available buffer space. (Bug#8545)
2641 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2643 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
2644 (SIZE_MAX): Move defn after all includes, as they might #define it.
2646 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2648 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2650 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2652 * keyboard.c (Qdelayed_warnings_hook): Define.
2653 (command_loop_1): Run `delayed-warnings-hook'
2654 if Vdelayed_warnings_list is non-nil.
2655 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2656 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2658 2011-04-28 Eli Zaretskii <eliz@gnu.org>
2660 * doprnt.c (doprnt): Don't return value smaller than the buffer
2661 size if the message was truncated. (Bug#8545).
2663 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2665 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2666 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2668 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2670 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2672 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
2674 * makefile.w32-in: Update dependencies.
2676 2011-04-27 Eli Zaretskii <eliz@gnu.org>
2678 Improve `doprnt' and its usage. (Bug#8545)
2679 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2680 `format_end'. Remove support for %l as a conversion specifier.
2681 Don't use xrealloc. Improve diagnostics when the %l size modifier
2682 is used. Update the commentary.
2684 * eval.c (verror): Simplify calculation of size_t.
2686 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2689 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2691 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2694 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2696 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2697 This makes this file independent of the recent pseudovector change.
2699 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2701 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2703 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2704 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2705 Remove unused local.
2706 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2708 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2709 GCC 4.6.0 optimizes based on type-based alias analysis.
2710 For example, if b is of type struct buffer * and v of type struct
2711 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2712 != &v->size, and therefore "v->size = 1; b->size = 2; return
2713 v->size;" must therefore return 1. This assumption is incorrect
2714 for Emacs, since it type-puns struct Lisp_Vector * with many other
2715 types. To fix this problem, this patch adds a new type struct
2716 vectorlike_header that documents the constraints on layout of vectors
2717 and pseudovectors, and helps optimizing compilers not get fooled
2718 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2719 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2720 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2722 (XSETPVECTYPE): Rewrite in terms of new macro.
2723 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2724 This is a bit clearer, and further avoids the possibility of
2725 undesirable aliasing.
2726 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2727 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2728 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2729 since Lisp_Subr is a special case (no "next" field).
2730 (ASIZE): Now uses header.size rather than size.
2731 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2732 to avoid the hassle of writing XVECTOR (foo)->header.size.
2733 (struct vectorlike_header): New type.
2734 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2735 object, to help avoid aliasing.
2736 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2737 (SUBRP): Likewise, since Lisp_Subr is a special case.
2738 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2739 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2740 (struct Lisp_Hash_Table): Combine first two members into a single
2741 struct vectorlike_header member. All uses of "size" and "next" members
2742 changed to be "header.size" and "header.next".
2743 * buffer.h (struct buffer): Likewise.
2744 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2745 * frame.h (struct frame): Likewise.
2746 * process.h (struct Lisp_Process): Likewise.
2747 * termhooks.h (struct terminal): Likewise.
2748 * window.c (struct save_window_data, struct saved_window): Likewise.
2749 * window.h (struct window): Likewise.
2750 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2751 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2752 * buffer.c (init_buffer_once): Likewise.
2753 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2755 * process.c (Fformat_network_address): Use local var for size,
2758 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2760 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2761 * data.c (atof): Remove decl; no longer used or needed.
2762 (digit_to_number): Move to lread.c.
2763 (Fstring_to_number): Use new string_to_number function, to be
2764 consistent with how the Lisp reader treats infinities and NaNs.
2765 Do not assume that floating-point numbers represent EMACS_INT
2766 without losing information; this is not true on most 64-bit hosts.
2767 Avoid double-rounding errors, by insisting on integers when
2768 parsing non-base-10 numbers, as the documentation specifies.
2769 * lisp.h (string_to_number): New decl, replacing ...
2770 (isfloat_string): Remove.
2771 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2772 (read1): Do not accept +. and -. as integers; this
2773 appears to have been a coding error. Similarly, do not accept
2774 strings like +-1e0 as floating point numbers. Do not report
2775 overflow for integer overflows unless the base is not 10 which
2776 means we have no simple and reliable way to continue.
2777 Break out the floating-point parsing into a new
2778 function string_to_number, so that Fstring_to_number parses
2779 floating point numbers consistently with the Lisp reader.
2780 (digit_to_number): Move here from data.c. Make it static inline.
2781 (E_CHAR, EXP_INT): Remove, replacing with ...
2782 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2783 (string_to_number): New function, replacing isfloat_string.
2784 This function checks for valid syntax and produces the resulting
2785 Lisp float number too. Rework it so that string-to-number
2786 no longer mishandles examples like "1.0e+". Use strtoumax,
2787 so that overflow for non-base-10 numbers is reported only when
2788 there's no portable and simple way to convert to floating point.
2790 * textprop.c (set_text_properties_1): Rewrite for clarity,
2791 and to avoid GCC warning about integer overflow.
2793 * intervals.h (struct interval): Use EMACS_INT for members
2794 where EMACS_UINT might cause problems. See
2795 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2796 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2797 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2799 (offset_intervals): Tell GCC not to worry about length overflow
2800 when negating a negative length.
2802 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2803 (overrun_check_free): Likewise.
2805 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2806 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2809 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2810 (gnutls_make_error): Rename local to avoid shadowing.
2811 (gnutls_emacs_global_deinit): ifdef out; not used.
2812 (Fgnutls_boot): Use const for pointer to readonly storage.
2813 Comment out unused local. Fix pointer signedness problems.
2815 * lread.c (openp): Don't stuff size_t into an 'int'.
2816 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2817 about possible signed overflow.
2819 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2820 (GDK_KEY_g): Don't define if already defined.
2821 (xg_prepare_tooltip): Avoid pointer signedness problem.
2822 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2824 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2825 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2827 * xfns.c (Fx_window_property): Simplify a bit,
2828 to make a bit faster and to avoid GCC 4.6.0 warning.
2829 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2831 * fns.c (internal_equal): Don't assume size_t fits in int.
2833 * alloc.c (compact_small_strings): Tighten assertion a little.
2835 Replace pEd with more-general pI, and fix some printf arg casts.
2836 * lisp.h (pI): New macro, generalizing old pEd macro to other
2837 conversion specifiers. For example, use "...%"pI"d..." rather
2838 than "...%"pEd"...".
2839 (pEd): Remove. All uses replaced with similar uses of pI.
2840 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2841 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2842 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2843 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2844 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2845 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2846 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2848 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2849 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2850 * print.c (safe_debug_print, print_object): Likewise.
2851 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2853 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2854 avoiding the 0 flag, which is not portable.
2855 * process.c (Fmake_network_process): Use pI to avoid cast.
2856 * region-cache.c (pp_cache): Likewise.
2857 * xdisp.c (decode_mode_spec): Likewise.
2858 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2859 behavior on 64-bit hosts with printf arg.
2860 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2861 (x_stop_queuing_selection_requests): Likewise.
2862 (x_get_window_property): Don't truncate byte count to an 'int'
2865 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2866 here, since it parses constructs like leading '-' and spaces,
2867 which are not wanted; and it overflows with large numbers.
2868 Instead, simply match F[0-9]+, which is what is wanted anyway.
2870 * alloc.c: Remove unportable assumptions about struct layout.
2871 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2872 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2873 (allocate_vectorlike, make_pure_vector): Use the new macros,
2874 plus offsetof, to remove unportable assumptions about struct layout.
2875 These assumptions hold on all porting targets that I know of, but
2876 they are not guaranteed, they're easy to remove, and removing them
2877 makes further changes easier.
2879 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2880 This doesn't fix a bug but makes the code clearer.
2881 (string_overrun_cookie): Now const. Use initializers that
2882 don't formally overflow signed char, to avoid warnings.
2883 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2884 can cause Emacs to crash when string overrun checking is enabled.
2885 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2886 multiple of sizeof (EMACS_INT); it need not be, if
2887 alignof(EMACS_INT) < sizeof (EMACS_INT).
2888 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2890 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2892 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2894 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2896 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2897 supposed to be handshaking. (Bug#8556)
2898 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2900 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2902 * lisp.h (Qdebug): List symbol.
2903 * eval.c (Qdebug): Restore global linkage.
2904 * keyboard.c (debug-on-event): New variable.
2905 (handle_user_signal): Break into debugger when debug-on-event
2906 matches the current signal symbol.
2908 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2910 * alloc.c (check_sblock, check_string_bytes)
2911 (check_string_free_list): Convert to standard C.
2913 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2915 * w32.c (emacs_gnutls_push): Fix typo.
2917 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2919 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2920 "cast to pointer from integer of different size".
2922 Improve doprnt and its use in verror. (Bug#8545)
2923 * doprnt.c (doprnt): Document the set of format control sequences
2924 supported by the function. Use SAFE_ALLOCA instead of always
2927 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2928 is one byte too soon. Don't use xrealloc; instead xfree and
2931 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2933 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2936 * gnutls.c: Renamed global_initialized to
2937 gnutls_global_initialized. Added internals for the
2938 :verify-hostname-error, :verify-error, and :verify-flags
2939 parameters of `gnutls-boot' and documented those parameters in the
2940 docstring. Start callback support.
2941 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2942 unless a fatal error occurred. Call gnutls_alert_send_appropriate
2943 on error. Return error code.
2944 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2945 (emacs_gnutls_read): Likewise.
2946 (Fgnutls_boot): Return handshake error code.
2947 (emacs_gnutls_handle_error): New function.
2948 (wsaerror_to_errno): Likewise.
2950 * w32.h (emacs_gnutls_pull): Add prototype.
2951 (emacs_gnutls_push): Likewise.
2953 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2954 (emacs_gnutls_push): Likewise.
2956 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2958 * process.c (wait_reading_process_output): Check if GnuTLS
2959 buffered some data internally if no FDs are set for TLS
2962 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2963 (LIBS): Link to USER_LIBS.
2964 ($(BLD)/gnutls.$(0)): New target.
2966 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2968 * xdisp.c (handle_single_display_spec): Rename the
2969 display_replaced_before_p argument into display_replaced_p, to
2970 make it consistent with the commentary. Fix typos in the
2973 * textprop.c (syms_of_textprop): Remove dead code.
2974 (copy_text_properties): Delete obsolete commentary about an
2975 interface that was deleted long ago. Fix typos in the description
2978 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2979 to changes in oldXMenu/XMenu.h from 2011-04-16.
2980 <menu_help_message, prev_menu_help_message>: Constify.
2981 (IT_menu_make_room): menu->help_text is now `const char **';
2984 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2985 to changes in oldXMenu/XMenu.h from 2011-04-16.
2986 (struct XMenu): Declare `help_text' `const char **'.
2988 * xfaces.c <Qunspecified>: Make extern again.
2990 * syntax.c: Include sys/types.h before including regex.h, as
2993 * doc.c (get_doc_string): Improve the format passed to `error'.
2995 * doprnt.c (doprnt): Improve commentary.
2997 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2999 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3002 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3003 changes in globals.h immediately force recompilation.
3004 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3005 $(CURDIR)/s/ms-w32.h.
3006 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3008 * character.c (Fchar_direction): Function deleted.
3009 (syms_of_character): Don't defsubr it.
3010 <char-direction-table>: Deleted.
3012 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3014 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3015 * doprnt.c: Include limits.h.
3016 (SIZE_MAX): New macro.
3017 (doprnt): Return a size_t value. 2nd arg is now size_t.
3018 Many local variables are now size_t instead of int or unsigned.
3019 Improve overflow protection. Support `l' modifier for integer
3020 conversions. Support %l conversion. Don't assume an EMACS_INT
3021 argument for integer conversions and for %c.
3023 * lisp.h (doprnt): Restore prototype.
3025 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3028 * Makefile.in (base_obj): Add back doprnt.o.
3030 * deps.mk (doprnt.o): Add back prerequisites.
3031 (callint.o): Depend on character.h.
3033 * eval.c (internal_lisp_condition_case): Include the handler
3034 representation in the error message.
3035 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3036 when breaking from the loop.
3038 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3040 * callint.c (Fcall_interactively): When displaying error message
3041 about invalid control letter, pass the character's codepoint, not
3042 a pointer to its multibyte form. Improve display of the character
3043 in octal and display also its hex code.
3045 * character.c (char_string): Use %x to display the (unsigned)
3046 codepoint of an invalid character, to avoid displaying a bogus
3049 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3050 `error', not SYMBOL_NAME itself.
3052 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3053 character arguments to `error'.
3055 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3056 to `error' in error message about FINAL_CHAR argument. Make sure
3057 FINAL_CHAR is a character, and use %c when it is passed as
3058 argument to `error'.
3060 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3062 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3064 * w32.c: Include <time.h>.
3065 (sys_localtime): New function.
3067 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
3069 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3071 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3073 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3075 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3078 2011-04-19 Eli Zaretskii <eliz@gnu.org>
3080 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3081 gl_state.e_property when gl_state.object is Qt.
3083 * insdel.c (make_gap_larger): Remove limitation of buffer size
3086 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
3088 * xdisp.c (lookup_glyphless_char_display)
3089 (produce_glyphless_glyph): Handle cons cell entry in
3090 glyphless-char-display.
3091 (Vglyphless_char_display): Document it.
3093 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3094 glyphless-char-display.
3096 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
3098 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3100 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3102 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3103 definition for no-X builds.
3105 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3107 Static checks with GCC 4.6.0 and non-default toolkits.
3109 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3111 * process.c (keyboard_bit_set): Define only if SIGIO.
3112 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3113 (send_process): Repair possible setjmp clobbering.
3115 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3117 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3119 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3121 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3122 Define only if needed.
3124 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3125 by pacifying GCC about it. Maybe it's time to retire it?
3126 * xfaces.c (USG, __TIMEVAL__): Likewise.
3128 * dispextern.h (struct redisplay_interface): Rename param
3130 * termhooks.h (struct terminal): Likewise.
3131 * xterm.c (xembed_send_message): Likewise.
3133 * insdel.c (make_gap_smaller): Define only if
3134 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3136 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3139 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3140 so that we aren't warned about unused symbols.
3142 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3144 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
3146 * xfns.c (x_real_positions): Mark locals as initialized.
3148 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3150 * xterm.c: Fix problems found by static analysis with other toolkits.
3151 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
3152 (x_dispatch_event): Declare static if USE_GTK, and
3153 define if USE_GTK || USE_X_TOOLKIT.
3154 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
3155 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
3156 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3157 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
3159 * xmenu.c (menu_help_callback): Pointer type fixes.
3160 Use const pointers when pointing at readonly data. Avoid pointer
3162 (FALSE): Remove unused macro.
3163 (update_frame_menubar): Remove unused decl.
3165 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3167 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3168 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3169 (single_menu_item): Rename local to avoid shadowing.
3171 * keyboard.c (make_lispy_event): Remove unused local var.
3173 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3174 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3176 * bitmaps: Change bitmaps from unsigned char back to the X11
3177 compatible char. Avoid the old compiler warnings about
3178 out-of-range initializers by using, for example, '\xab' rather
3181 * xgselect.c (xgselect_initialize): Check vs interface
3182 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3184 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3186 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3187 to read-only memory.
3189 * fns.c (vector): Remove; this old hack is no longer needed.
3191 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
3193 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
3195 * xrdb.c (x_load_resources): Omit unused local.
3197 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
3198 (x_window): Rename locals to avoid shadowing.
3199 (USG): Use the kludged USG macro, to pacify gcc.
3201 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
3202 (x_term_init): Remove local to avoid shadowing.
3204 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
3206 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3207 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3209 2011-04-16 Eli Zaretskii <eliz@gnu.org>
3211 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3213 Fix regex.c, syntax.c and friends for buffers > 2GB.
3214 * syntax.h (struct gl_state_s): Declare character position members
3217 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3219 * textprop.c (verify_interval_modification, interval_of):
3220 Declare arguments EMACS_INT.
3222 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3225 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3227 * indent.c (Fvertical_motion): Local variable it_start is now
3230 * regex.c (re_match, re_match_2, re_match_2_internal)
3231 (bcmp_translate, regcomp, regexec, print_double_string)
3232 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3233 (re_compile_pattern, re_exec): Declare arguments and local
3234 variables `size_t' and `ssize_t' and return values `regoff_t', as
3236 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3237 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3238 <compile_stack_type>: `size' and `avail' are now `size_t'.
3240 * regex.h <regoff_t>: Use ssize_t, not int.
3241 (re_search, re_search_2, re_match, re_match_2): Arguments that
3242 specify buffer/string position and length are now ssize_t and
3243 size_t. Return type is regoff_t.
3245 2011-04-16 Ben Key <bkey76@gmail.com>
3247 * nsfont.m: Fixed bugs in ns_get_family and
3248 ns_descriptor_to_entity that were caused by using free to
3249 deallocate memory blocks that were allocated by xmalloc (via
3250 xstrdup). This caused Emacs to crash when compiled with
3251 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3252 --enable-checking=xmallocoverrun). xfree is now used to
3253 deallocate these memory blocks.
3255 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3257 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3259 emacs_write: Accept and return EMACS_INT for sizes.
3260 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3262 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3263 Accept and return EMACS_INT.
3264 (emacs_gnutls_write): Return the number of bytes written on
3266 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
3267 (emacs_read, emacs_write): Remove check for negative size, as the
3268 Emacs source code has been audited now.
3269 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3270 (emacs_read, emacs_write): Use it.
3271 * process.c (send_process): Adjust to the new signatures of
3272 emacs_write and emacs_gnutls_write. Do not attempt to store
3273 a byte offset into an 'int'; it might overflow.
3274 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
3276 * sound.c: Don't assume sizes fit in 'int'.
3277 (struct sound_device.period_size, alsa_period_size):
3278 Return EMACS_INT, not int.
3279 (struct sound_device.write, vox_write, alsa_write):
3280 Accept EMACS_INT, not int.
3281 (wav_play, au_play): Use EMACS_INT to store sizes and to
3282 record read return values.
3284 2011-04-15 Ben Key <bkey76@gmail.com>
3286 * keyboard.c (Qundefined): Don't declare static since it is used
3288 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3289 static since they are used in nsfont.m.
3291 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3293 * process.c (Qprocessp): Don't declare static.
3294 * lisp.h (Qprocessp): Declare again.
3296 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
3298 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3300 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3302 Improve C-level modularity by making more things 'static'.
3304 Don't publish debugger-only interfaces to other modules.
3305 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3306 (verify_bytepos, count_markers): Move decls to the only modules
3308 * region-cache.h (pp_cache): Likewise.
3309 * window.h (check_all_windows): Likewise.
3310 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3312 * sysdep.c (croak): Now static, if
3313 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3314 * syssignal.h (croak): Declare only if not static.
3316 * alloc.c (refill_memory_reserve): Now static if
3317 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3318 * lisp.h (refill_memory_reserve): Declare only if not static.
3320 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3321 Define only if USE_LUCID.
3323 * xrdb.c (x_customization_string, x_rm_string): Now static.
3325 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3326 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3328 * xdisp.c (draw_row_with_mouse_face): Now static.
3329 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3331 * window.h (check_all_windows): Mark externally visible.
3333 * window.c (window_deletion_count): Now static.
3335 * undo.c: Make symbols static if they're not exported.
3336 (last_undo_buffer, last_boundary_position, pending_boundary):
3339 * textprop.c (interval_insert_behind_hooks): Now static.
3340 (interval_insert_in_front_hooks): Likewise.
3342 * term.c: Make symbols static if they're not exported.
3343 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3344 (max_frame_lines, tty_set_terminal_modes):
3345 (tty_reset_terminal_modes, tty_turn_off_highlight):
3346 (get_tty_terminal): Now static.
3347 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3348 * termhooks.h (term_mouse_moveto): Do not declare if
3350 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3351 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3353 * sysdep.c: Make symbols static if they're not exported.
3354 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3356 (sigprocmask_set, full_mask): Remove; unused.
3357 (wait_debugging): Mark as visible.
3358 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3359 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3361 * syntax.c (syntax_temp): Define only if !__GNUC__.
3363 * sound.c (current_sound_device, current_sound): Now static.
3365 * search.c (searchbufs, searchbuf_head): Now static.
3367 * scroll.c (scroll_cost): Remove; unused.
3368 * dispextern.h (scroll_cost): Remove decl.
3370 * region-cache.h (pp_cache): Mark as externally visible.
3372 * process.c: Make symbols static if they're not exported.
3373 (process_tick, update_tick, create_process, chan_process):
3374 (Vprocess_alist, proc_buffered_char, datagram_access):
3375 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3376 (deactivate_process): Mark defn as static, as well as decl.
3377 * lisp.h (create_process): Remove decl.
3378 * process.h (chan_process, Vprocess_alist): Remove decls.
3380 * print.c: Make symbols static if they're not exported.
3381 (print_depth, new_backquote_output, being_printed, print_buffer):
3382 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3383 (print_interval, print_number_index, initial_stderr_stream):
3385 * lisp.h (Fprinc): Remove decl.
3386 (debug_output_compilation_hack): Mark as externally visible.
3388 * sysdep.c (croak): Move decl from here to syssignal.h.
3389 * syssignal.h (croak): Put it here, so the API can be checked when
3390 'croak' is called from dissociate_if_controlling_tty.
3392 * minibuf.c: Make symbols static if they're not exported.
3393 (minibuf_save_list, choose_minibuf_frame): Now static.
3394 * lisp.h (choose_minibuf_frame): Remove decl.
3396 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3398 * lread.c: Make symbols static if they're not exported.
3399 (read_objects, initial_obarray, oblookup_last_bucket_number):
3401 (make_symbol): Remove; unused.
3402 * lisp.h (initial_obarray, make_symbol): Remove decls.
3404 * keyboard.c: Make symbols static if they're not exported.
3405 (single_kboard, recent_keys_index, total_keys, recent_keys):
3406 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3407 (this_single_command_key_start, echoing, last_auto_save):
3408 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3409 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3410 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3411 (Vlispy_mouse_stem, double_click_count):
3413 (force_auto_save_soon): Define only if SIGDANGER.
3414 (ignore_mouse_drag_p): Now static if
3415 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3416 (print_help): Remove; unused.
3417 (stop_character, last_timer_event): Mark as externally visible.
3418 * keyboard.h (ignore_mouse_drag_p): Declare only if
3419 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3420 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3421 * lisp.h (echoing): Remove decl.
3422 (force_auto_save_soon): Declare only if SIGDANGER.
3423 * xdisp.c (redisplay_window): Simplify code, to make it more
3424 obvious that ignore_mouse_drag_p is not accessed if !defined
3425 USE_GTK && !defined HAVE_NS.
3427 * intervals.c: Make symbols static if they're not exported.
3428 (merge_properties_sticky, merge_interval_right, delete_interval):
3430 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3432 * insdel.c: Make symbols static if they're not exported.
3433 However, leave prepare_to_modify_buffer alone. It's never
3434 called from outside this function, but that appears to be a bug.
3435 (combine_after_change_list, combine_after_change_buffer):
3436 (adjust_after_replace, signal_before_change): Now static.
3437 (adjust_after_replace_noundo): Remove; unused.
3438 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3439 (signal_before_change): Remove decls.
3441 * indent.c (val_compute_motion, val_vmotion): Now static.
3443 * image.c: Make symbols static if they're not exported.
3444 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3446 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3447 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3449 * fringe.c (standard_bitmaps): Now static.
3450 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3452 * frame.c: Make symbols static if they're not exported.
3453 (x_report_frame_params, make_terminal_frame): Now static.
3454 (get_frame_param): Now static, unless HAVE_NS.
3455 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3456 (x_get_resource_string): Remove; not used.
3457 * frame.h (make_terminal_frame, x_report_frame_params):
3458 (x_get_resource_string); Remove decls.
3459 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3460 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3462 * font.c, fontset.c: Make symbols static if they're not exported.
3463 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3464 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3465 * font.c (font_close_object): Now static.
3466 * font.h (font_close_object): Remove.
3467 * fontset.c (FONTSET_OBJLIST): Remove.
3468 (free_realized_fontset) #if-0 the body, which does nothing.
3469 (face_suitable_for_char_p): #if-0, as it's never called.
3470 * fontset.h (face_suitable_for_char_p): Remove decl.
3471 * xfaces.c (face_at_string_position):
3472 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
3473 since 0 is always ASCII.
3475 * fns.c (weak_hash_tables): Now static.
3477 * fileio.c: Make symbols static if they're not exported.
3478 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3479 (Vwrite_region_annotation_buffers): Now static.
3481 * eval.c: Make symbols static if they're not exported.
3482 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3483 * lisp.h (backtrace_list): Remove decl.
3485 * emacs.c: Make symbols static if they're not exported.
3486 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3487 (fatal_error_code, fatal_error_signal_hook, standard_args):
3489 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3490 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3491 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3492 * lisp.h (fatal_error_signal_hook): Remove decl.
3493 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3495 * editfns.c: Move a (normally-unused) function to its only use.
3496 * editfns.c, lisp.h (get_operating_system_release): Remove.
3497 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3498 worth the hassle of breaking this out.
3500 * xterm.c: Make symbols static if they're not exported.
3501 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3502 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3503 (x_destroy_window, x_delete_display):
3505 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3506 (x_mouse_leave): Remove; unused.
3507 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3508 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3509 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3511 (x_mouse_leave): Declare only if WINDOWSNT.
3512 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3513 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3516 * ftxfont.c: Make symbols static if they're not exported.
3517 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3519 * font.h (ftxfont_driver): Likewise.
3521 * xfns.c: Make symbols static if they're not exported.
3522 (x_last_font_name, x_display_info_for_name):
3523 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3524 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3525 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3526 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3527 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3528 (last_show_tip_args): Now static.
3529 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3530 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3531 (x_screen_planes): Remove; unused.
3532 * dispextern.h (x_screen_planes): Remove decl.
3534 * dispnew.c: Make symbols static if they're not exported.
3535 * dispextern.h (redraw_garbaged_frames, scrolling):
3536 (increment_row_positions): Remove.
3537 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3538 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3540 (redraw_garbaged_frames): Remove; unused.
3542 * xfaces.c: Make symbols static if they're not exported.
3543 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3545 * xterm.h (defined_color): Remove decls.
3546 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3547 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3548 (menu_face_changed_default, defined_color, free_realized_face):
3549 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3550 (ascii_face_of_lisp_face): Remove; unused.
3552 * xdisp.c: Make symbols static if they're not exported.
3553 * dispextern.h (scratch_glyph_row, window_box_edges):
3554 (glyph_to_pixel_coords, set_cursor_from_row):
3555 (get_next_display_element, set_iterator_to_next):
3556 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3557 (show_mouse_face): Remove decls
3558 * frame.h (message_buf_print): Likewise.
3559 * lisp.h (pop_message, set_message, check_point_in_composition):
3561 * xterm.h (set_vertical_scroll_bar): Likewise.
3562 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3563 (message_buf_print, scratch_glyph_row, displayed_buffer):
3564 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3565 (get_next_display_element, show_mouse_face, window_box_edges):
3566 (frame_to_window_pixel_xy, check_point_in_composition):
3567 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3568 (glyph_to_pixel_coords): Remove; unused.
3570 * dired.c (file_name_completion): Now static.
3572 * dbusbind.c (xd_in_read_queued_messages): Now static.
3574 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3575 * data.c (circular_list_error): Remove.
3577 * commands.h (last_point_position, last_point_position_buffer):
3578 (last_point_position_window): Remove decls.
3579 * keyboard.c: Make these variables static.
3581 * coding.h (coding, code_convert_region, encode_coding_gap):
3583 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3584 (iso_code_class, detect_coding, code_convert_region): Now static.
3585 (encode_coding_gap): Remove; unused.
3587 * chartab.c (chartab_chars, chartab_bits): Now static.
3589 * charset.h (charset_iso_8859_1): Remove decl.
3590 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3593 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3594 * ccl.c (Vccl_program_table): Now static.
3595 (check_ccl_update): Remove; unused.
3597 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3598 * category.h: ... from here.
3599 * category.c (check_category_table, set_category_set): Now static.
3601 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3602 * lisp.h: Remove these decls.
3604 * buffer.c (buffer_count): Remove unused var.
3606 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3607 so that it's not optimized away.
3608 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3609 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3610 exported only to the debugger.
3612 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
3613 * atimer.h (run_all_atimers): Remove; not exported.
3615 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3616 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3617 was inaccessible from Lisp.
3618 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3619 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3621 alloc.c: Import and export fewer symbols, and remove unused items.
3622 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3624 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3625 it's not optimized away by whole-program optimization.
3626 (message_enable_multibyte, free_misc): Remove.
3627 (catchlist, handlerlist, mark_backtrace):
3628 Declare only if BYTE_MARK_STACK.
3629 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3630 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3631 (message_enable_multibyte): Remove decl.
3632 (free_misc, interval_free_list, float_block, float_block_index):
3633 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3634 (cons_free_list, last_marked_index):
3636 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3637 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3638 (mark_backtrace): Define only if BYTE_MARK_STACK.
3639 * xdisp.c (message_enable_multibyte): Now static.
3641 Declare Lisp_Object Q* variables to be 'static' if not exported.
3642 This makes it easier for human readers (and static analyzers)
3643 to see whether these variables are used from other modules.
3644 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3645 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3646 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3647 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3648 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3649 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3650 * xmenu.c, xselect.c:
3651 Declare Q* vars static if they are not used in other modules.
3652 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3653 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3654 Remove decls of unexported vars.
3655 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3657 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3659 Make Emacs functions such as Fatom 'static' by default.
3660 This makes it easier for human readers (and static analyzers)
3661 to see whether these functions can be called from other modules.
3662 DEFUN now defines a static function. To make the function external
3663 so that it can be used in other C modules, use the new macro DEFUE.
3664 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3665 (Finit_image_library):
3666 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3667 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3668 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3669 Remove decls, since these functions are now static.
3670 (Funintern, Fget_internal_run_time): New decls, since these functions
3671 were already external.
3673 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3674 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3675 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3676 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3677 * keyboard.c, keymap.c, lread.c:
3678 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3679 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3680 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3681 Mark functions with DEFUE instead of DEFUN,
3682 if they are used in other modules.
3683 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3684 decls for now-static functions.
3685 * buffer.h (Fdelete_overlay): Remove decl.
3686 * callproc.c (Fgetenv_internal): Mark as internal.
3687 * composite.c (Fremove_list_of_text_properties): Remove decl.
3688 (Fcomposition_get_gstring): New forward static decl.
3689 * composite.h (Fcomposite_get_gstring): Remove decl.
3690 * dired.c (Ffile_attributes): New forward static decl.
3691 * doc.c (Fdocumntation_property): New forward static decl.
3692 * eval.c (Ffetch_bytecode): New forward static decl.
3693 (Funintern): Remove extern decl; now in .h file where it belongs.
3694 * fileio.c (Fmake_symbolic_link): New forward static decl.
3695 * image.c (Finit_image_library): New forward static decl.
3696 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3697 * intervals.h (Fprevious_property_change):
3698 (Fremove_list_of_text_properties): Remove decls.
3699 * keyboard.c (Fthis_command_keys): Remove decl.
3700 (Fcommand_execute): New forward static decl.
3701 * keymap.c (Flookup_key): New forward static decl.
3702 (Fcopy_keymap): Now static.
3703 * keymap.h (Flookup_key): Remove decl.
3704 * process.c (Fget_process): New forward static decl.
3705 (Fprocess_datagram_address): Mark as internal.
3706 * syntax.c (Fsyntax_table_p): New forward static decl.
3707 (skip_chars): Remove duplicate decl.
3708 * textprop.c (Fprevious_property_change): New forward static decl.
3709 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3711 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3712 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3714 * editfns.c (Fformat): Remove unreachable code.
3716 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3718 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3721 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3723 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3724 when at ZV. (Bug#8487)
3726 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3728 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3730 * keyboard.c (parse_tool_bar_item): Likewise.
3731 * sound.c (sound_cleanup, alsa_close): Likewise.
3732 * termcap.c (tgetent): Likewise.
3733 * xfns.c (x_default_font_parameter): Likewise.
3734 * xsettings.c (read_and_apply_settings): Likewise.
3736 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3737 (overrun_check_free): Protoize.
3739 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3741 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3742 since callers should never pass a negative size.
3743 Change the signature to match that of plain 'read' and 'write'; see
3744 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3745 * lisp.h: Update prototypes of emacs_write and emacs_read.
3747 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3749 * xdisp.c (redisplay_window): Don't try to determine the character
3750 position of the scroll margin if the window start point w->startp
3751 is outside the buffer's accessible region. (Bug#8468)
3753 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3755 Fix write-region and its subroutines for buffers > 2GB.
3756 * fileio.c (a_write, e_write): Modify declaration of arguments and
3757 local variables to support buffers larger than 2GB.
3758 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3760 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3761 argument, local variables, and return value.
3763 * lisp.h: Update prototypes of emacs_write and emacs_read.
3765 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3767 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3769 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3771 Fix more problems found by GCC 4.6.0's static checks.
3773 * xdisp.c (vmessage): Use a better test for character truncation.
3775 * charset.c (load_charset_map): <, not <=, for optimization,
3776 and to avoid potential problems with integer overflow.
3777 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3778 * casetab.c (set_identity, shuffle): Likewise.
3779 * editfns.c (Fformat): Likewise.
3780 * syntax.c (skip_chars): Likewise.
3782 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3783 This also lets GCC 4.6.0 generate slightly better loop code.
3785 * callint.c (Fcall_interactively): <, not <=, for optimization.
3786 (Fcall_interactively): Count the number of arguments produced,
3787 not the number of arguments given. This is simpler and lets GCC
3788 4.6.0 generate slightly better code.
3790 * ftfont.c: Distingish more carefully between FcChar8 and char.
3791 The previous code passed unsigned char * to a functions like
3792 strlen and xstrcasecmp that expect char *, which does not
3793 conform to the C standard.
3794 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3795 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3796 char * when the C standard requires it.
3798 * keyboard.c (read_char): Remove unused var.
3800 * eval.c: Port to Windows vsnprintf (Bug#8435).
3802 (SIZE_MAX): Define if the headers do not.
3803 (verror): Do not give up if vsnprintf returns a negative count.
3804 Instead, grow the buffer. This ports to Windows vsnprintf, which
3805 does not conform to C99. Problem reported by Eli Zaretskii.
3806 Also, simplify the allocation scheme, by avoiding the need for
3807 calling realloc, and removing the ALLOCATED variable.
3809 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3811 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3812 But keep the doprint source code for now, as we might revamp it
3813 and use it again (Bug#8435).
3814 * lisp.h (doprnt): Remove.
3815 * Makefile.in (base_obj): Remove doprnt.o.
3816 * deps.mk (doprnt.o): Remove.
3818 error: Print 32- and 64-bit integers portably (Bug#8435).
3819 Without this change, on typical 64-bit hosts error ("...%d...", N)
3820 was used to print both 32- and 64-bit integers N, which relied on
3822 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3824 * lisp.h (error, verror): Mark as printf-like functions.
3825 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3826 Report overflow in size calculations when allocating printf buffer.
3827 Do not truncate output string at its first null byte.
3828 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3829 Truncate the output at a character boundary, since vsnprintf does not
3831 * charset.c (check_iso_charset_parameter): Convert internal
3832 character to string before calling 'error', since %c now has the
3834 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3835 overflow when computing char to be passed to 'error'. Do not
3836 pass Lisp_Object to 'error'; pass the integer instead.
3837 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3838 formatted with plain %d.
3840 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3842 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3844 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3846 * xterm.c (x_catch_errors): Remove duplicate declaration.
3848 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3850 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3852 2011-04-10 Jim Meyering <meyering@redhat.com>
3854 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3855 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3856 return ssize_t not "int", and use size_t as the buffer length.
3857 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3858 * gnutls.h: Update declarations.
3859 * process.c (read_process_output): Use ssize_t, to match.
3860 (send_process): Likewise.
3862 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3864 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3866 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3868 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3869 Use unsigned char, to match FcChar8 type definition.
3871 * xterm.c (handle_one_xevent):
3872 * xmenu.c (create_and_show_popup_menu):
3873 * xselect.c (x_decline_selection_request)
3874 (x_reply_selection_request): Avoid type-punned deref of X events.
3876 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3878 Fix some uses of `int' instead of EMACS_INT.
3879 * search.c (string_match_1, fast_string_match)
3880 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3881 (scan_buffer, find_next_newline_no_quit)
3882 (find_before_next_newline, search_command, Freplace_match)
3883 (Fmatch_data): Make some `int' variables be EMACS_INT.
3885 * xdisp.c (display_count_lines): 3rd argument and return value now
3886 EMACS_INT. All callers changed.
3887 (pint2hrstr): Last argument is now EMACS_INT.
3889 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3890 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3891 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3892 (decode_coding_utf_16, decode_coding_emacs_mule)
3893 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3894 (decode_coding_ccl, decode_coding_charset)
3895 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3896 (decode_coding_iso_2022, decode_coding_emacs_mule)
3897 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3898 <char_offset, last_offset>: Declare EMACS_INT.
3899 (encode_coding_utf_8, encode_coding_utf_16)
3900 (encode_coding_emacs_mule, encode_invocation_designation)
3901 (encode_designation_at_bol, encode_coding_iso_2022)
3902 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3903 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3905 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3906 (encode_invocation_designation): Last argument P_NCHARS is now
3908 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3909 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3911 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3914 * ccl.c (Fccl_execute_on_string): Declare some variables
3917 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3919 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3921 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3923 * process.c (Fformat_network_address): Doc fix.
3925 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3927 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3929 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3931 * keyboard.c (read_char): Call Lisp function help-form-show,
3932 instead of using internal_with_output_to_temp_buffer.
3933 (Qhelp_form_show): New var.
3934 (syms_of_keyboard): Use DEFSYM macro.
3936 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3938 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3940 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3942 * process.c (Flist_processes): Remove to Lisp.
3943 (list_processes_1): Delete.
3945 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3947 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3949 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3951 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3953 Fix more problems found by GCC 4.6.0's static checks.
3955 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3957 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3959 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3961 * xdisp.c (vmessage): Mark as a printf-like function.
3963 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3965 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3967 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3968 printf-like functions.
3969 (tiff_load): Add casts to remove these marks before passing them
3970 to system-supplied API.
3972 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3974 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3975 This avoids several warnings with gcc -Wstrict-overflow.
3976 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3977 directly, rather than having caller test rule sign. This avoids
3978 some unnecessary tests.
3979 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3980 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3981 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3983 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3984 (xfont_open): Avoid unnecessary tests.
3986 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3988 * composite.h, composite.c (composition_gstring_put_cache):
3989 Use EMACS_INT, not int, for length.
3991 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3992 breaking out part of COMPOSITION_DECODE_RULE.
3993 (COMPOSITION_DECODE_RULE): Use it.
3994 * composite.c (get_composition_id): Remove unused local vars,
3995 by using the new macro.
3997 * textprop.c (set_text_properties_1): Change while to do-while,
3998 since the condition is always true at first.
4000 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4001 (interval_deletion_adjustment): Return unsigned value.
4004 * process.c (list_processes_1, create_pty, read_process_output):
4005 (exec_sentinel): Remove vars that were set but not used.
4006 (create_pty): Remove unnecessary "volatile"s.
4007 (Fnetwork_interface_info): Avoid possibility of int overflow.
4008 (read_process_output): Do adaptive read buffering even if carryover.
4009 (read_process_output): Simplify nbytes computation if buffered.
4011 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4013 * syntax.c (scan_words): Remove var that was set but not used.
4014 (update_syntax_table): Use unsigned instead of int.
4016 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4017 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4018 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4020 * print.c (print_error_message): Avoid int overflow.
4022 * font.c (font_list_entities): Redo for clarity,
4023 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4025 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4026 (font_score): Avoid potential overflow in diff calculation.
4028 * fns.c (substring_both): Remove var that is set but not used.
4029 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4031 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4033 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4034 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4035 can always succeed if overflow has undefined behavior.
4037 * search.c (boyer_moore, wordify): Remove vars set but not used.
4038 (wordify): Omit three unnecessary tests.
4040 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4041 All callers changed. This avoids the need for an unused var.
4043 * casefiddle.c (casify_region): Remove var that is set but not used.
4045 * dired.c (file_name_completion): Remove var that is set but not used.
4047 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4049 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4050 (Finsert_file_contents): Remove unnecessary code checking fd.
4052 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4053 Check for integer overflow on size calculations.
4055 * buffer.c (Fprevious_overlay_change): Remove var that is set
4058 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4059 Remove vars that are set but not used.
4060 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4061 (timer_check_2): Mark vars as initialized.
4063 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4065 * image.c (lookup_image): Remove var that is set but not used.
4066 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4068 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4069 that are set but not used.
4071 * xfns.c (make_invisible_cursor): Don't return garbage
4072 if XCreateBitmapFromData fails (Bug#8410).
4074 * xselect.c (x_get_local_selection, x_handle_property_notify):
4075 Remove vars that are set but not used.
4077 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4078 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4080 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4081 Remove var that is set but not used.
4082 (scroll_bar_windows_size): Now size_t, not int.
4083 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4086 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4087 (map_tty_color) [!defined MSDOS]: Likewise.
4089 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4091 * coding.c: Remove vars that are set but not used.
4092 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4093 All callers changed.
4094 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4095 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4096 (decode_coding_charset): Remove vars that are set but not used.
4098 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4099 that is set but not used.
4101 * print.c (print_object): Remove var that is set but not used.
4103 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4104 The gnulib version avoids calling malloc in the usual case,
4105 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4106 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4107 * filelock.c (current_lock_owner): Likewise.
4108 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4109 * sysdep.c: Include allocator.h, careadlinkat.h.
4110 (emacs_no_realloc_allocator): New static constant.
4111 (emacs_readlink): New function.
4112 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4113 ../lib/careadlinkat.h.
4115 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4117 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4118 first non-nil return value).
4120 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4122 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4123 if not defined (Bug#8403).
4125 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4127 * xdisp.c (display_count_lines): Remove parameter `start',
4128 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4129 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4130 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4131 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4132 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4133 and thereabouts. All callers changed.
4134 (get_per_char_metric): Remove parameter `f', unused since
4135 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4137 2011-04-02 Jim Meyering <meyering@redhat.com>
4139 do not dereference NULL upon failed strdup
4140 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4141 (ns_get_family): Likewise.
4143 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4145 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4147 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4149 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4152 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4154 Add lexical binding.
4156 * window.c (Ftemp_output_buffer_show): New fun.
4157 (Fsave_window_excursion):
4158 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4160 * lread.c (lisp_file_lexically_bound_p): New function.
4161 (Fload): Bind Qlexical_binding.
4162 (readevalloop): Remove `evalfun' arg.
4163 Bind Qinternal_interpreter_environment.
4164 (Feval_buffer): Bind Qlexical_binding.
4165 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4167 (syms_of_lread): Declare `lexical-binding'.
4169 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4171 * keyboard.c (eval_dyn): New fun.
4172 (menu_item_eval_property): Use it.
4174 * image.c (parse_image_spec): Use Ffunctionp.
4176 * fns.c (concat, mapcar1): Accept byte-code-functions.
4178 * eval.c (Fsetq): Handle lexical vars.
4179 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4180 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4181 (FletX, Flet): Obey lexical binding.
4182 (Fcommandp): Handle closures.
4183 (Feval): New `lexical' arg.
4184 (eval_sub): New function extracted from Feval. Use it almost
4185 everywhere where Feval was used. Look up vars in lexical env.
4187 (Ffunctionp): Move from subr.el.
4188 (Ffuncall): Handle closures.
4189 (apply_lambda): Remove `eval_flags'.
4190 (funcall_lambda): Handle closures and new byte-code-functions.
4191 (Fspecial_variable_p): New function.
4192 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4193 but without exporting it to Lisp.
4195 * doc.c (Fdocumentation, store_function_docstring):
4196 * data.c (Finteractive_form): Handle closures.
4198 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4201 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4203 (exec_byte_code): New function extracted from Fbyte_code to handle new
4204 calling convention for byte-code-functions. Add new byte-codes.
4206 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
4208 * alloc.c (Fmake_symbol): Init new `declared_special' field.
4210 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4212 * xdisp.c (redisplay_internal): Fix prototype.
4214 2011-03-31 Eli Zaretskii <eliz@gnu.org>
4216 * xdisp.c (SCROLL_LIMIT): New macro.
4217 (try_scrolling): Use it when setting scroll_limit.
4218 Limit scrolling to 100 screen lines.
4219 (redisplay_window): Even when falling back on "recentering",
4220 position point in the window according to scroll-conservatively,
4221 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4223 (try_scrolling): When point is above the window, allow searching
4224 as far as scroll_max, or one screenful, to compute vertical
4225 distance from PT to the scroll margin position. This prevents
4226 try_scrolling from unnecessarily failing when
4227 scroll-conservatively is set to a value slightly larger than the
4228 window height. Clean up the case of PT below the margin at bottom
4229 of window: scroll_max can no longer be INT_MAX. When aggressive
4230 scrolling is in use, don't let point enter the opposite scroll
4231 margin as result of the scroll.
4232 (syms_of_xdisp) <scroll-conservatively>: Document the
4233 threshold of 100 lines for never-recentering scrolling.
4235 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4237 * dispextern.h (move_it_by_lines):
4238 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4239 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4240 (message_log_check_duplicate): Remove parameters `prev_bol' and
4241 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4242 (redisplay_internal): Remove parameter `preserve_echo_area',
4243 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4245 * indent.c (Fvertical_motion):
4246 * window.c (window_scroll_pixel_based, Frecenter):
4247 Don't pass `need_y_p' to `move_it_by_lines'.
4249 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4251 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4252 steal a few bits to be more compact.
4253 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4254 Remove unneeded casts.
4256 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4258 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4260 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4261 binding" message (bug#7967).
4263 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4265 Fix more problems found by GCC 4.6.0's static checks.
4267 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4268 Remove unused local var.
4270 * editfns.c (Fmessage_box): Remove unused local var.
4272 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4273 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4274 Omit unused local vars.
4275 * window.c (shrink_windows): Omit unused local var.
4276 * menu.c (digest_single_submenu): Omit unused local var.
4277 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4278 Omit unused local var.
4280 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4281 Don't assume string length fits in int.
4282 (keyremap_step, read_key_sequence): Use size_t for sizes.
4283 (read_key_sequence): Don't check last_real_key_start redundantly.
4285 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4286 instead of alloca (Bug#8344).
4288 * eval.c (Fbacktrace): Don't assume nargs fits in int.
4289 (Fbacktrace_frame): Don't assume nframes fits in int.
4291 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4293 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4296 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4298 * cm.c (calccost): Turn while-do into do-while, for clarity.
4300 * keyboard.c (syms_of_keyboard): Use the same style as later
4301 in this function when indexing through an array. This also
4302 works around GCC bug 48267.
4304 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4306 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4308 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4309 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4311 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4312 This avoids undefined behavior on integer overflow, and is a bit
4313 more convenient anyway since it is compared to a size_t variable.
4315 Variadic C functions now count arguments with size_t, not int.
4316 This avoids an unnecessary limitation on 64-bit machines, which
4317 caused (substring ...) to crash on large vectors (Bug#8344).
4318 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4319 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
4320 All variadic functions and their callers changed accordingly.
4321 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4322 * data.c (arith_driver, float_arith_driver): Likewise.
4323 * editfns.c (general_insert_function): Likewise.
4324 * eval.c (struct backtrace.nargs, interactive_p)
4325 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4326 (funcall_lambda, mark_backtrace): Likewise.
4327 * fns.c (concat): Likewise.
4328 * frame.c (x_set_frame_parameters): Likewise.
4329 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4330 0 if not found, not -1. All callers changed.
4332 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4333 (stack_copy_size): Now size_t, not int.
4334 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4336 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4338 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4339 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4340 All callers changed.
4342 * lisp.h (multibyte_char_to_unibyte):
4343 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4344 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4345 * character.h (CHAR_TO_BYTE8):
4346 * cmds.c (internal_self_insert):
4347 * editfns.c (general_insert_function):
4348 * keymap.c (push_key_description):
4349 * search.c (Freplace_match):
4350 * xdisp.c (message_dolog, set_message_1): All callers changed.
4352 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4354 * keyboard.c (safe_run_hook_funcall): New function.
4355 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4356 don't set the hook to nil, but remove the offending function instead.
4357 (Qcommand_hook_internal): Remove, unused.
4358 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4359 Vcommand_hook_internal.
4361 * eval.c (enum run_hooks_condition): Remove.
4362 (funcall_nil, funcall_not): New functions.
4363 (run_hook_with_args): Call each function through a `funcall' argument.
4364 Remove `cond' argument, now redundant.
4365 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4366 (Frun_hook_with_args_until_failure): Adjust accordingly.
4367 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4369 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4371 * dispextern.h (string_buffer_position): Remove declaration.
4373 * print.c (strout): Remove parameter `multibyte', unused since
4374 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4376 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4377 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4378 All callers changed.
4380 * w32.c (_wsa_errlist): Use braces for struct initializers.
4382 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4383 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4384 All callers changed.
4385 (string_buffer_position): Likewise. Also, make static (it's never
4386 used outside xdisp.c).
4387 (cursor_row_p): Remove parameter `w', unused since
4388 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4389 (decode_mode_spec): Remove parameter `precision', introduced during
4390 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4391 All callers changed.
4393 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4395 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4397 2011-03-27 Anders Lindgren <andlind@gmail.com>
4399 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4400 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4401 (ns_update_auto_hide_menu_bar): New functions.
4402 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4403 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4404 ns_constrain_all_frames.
4405 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4406 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4408 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4410 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4412 2011-03-27 Glenn Morris <rgm@gnu.org>
4414 * syssignal.h: Replace RETSIGTYPE with void.
4415 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4416 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4417 Replace SIGTYPE with void everywhere.
4418 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4419 * s/template.h (SIGTYPE): Remove commented out definition.
4421 2011-03-26 Eli Zaretskii <eliz@gnu.org>
4423 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4424 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4426 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
4428 * w32.c (read_unc_volume): Use parameter `henum', instead of
4429 global variable `wget_enum_handle'.
4431 * keymap.c (describe_vector): Remove parameters `indices' and
4432 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4433 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4435 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4437 * keyboard.c (timer_check): Remove parameter `do_it_now',
4438 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4439 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4440 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4442 * keyboard.c (read_char):
4443 * w32menu.c (w32_menu_display_help):
4444 * xmenu.c (show_help_event, menu_help_callback):
4445 Adjust calls to `show_help_echo'.
4447 * gtkutil.c (xg_maybe_add_timer):
4448 * keyboard.c (readable_events):
4449 * process.c (wait_reading_process_output):
4450 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4452 * insdel.c (adjust_markers_gap_motion):
4453 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4454 (gap_left, gap_right): Don't call it.
4456 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
4458 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4459 incurred during fontification.
4461 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4463 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4464 (DEFVAR_PER_BUFFER): Don't pass it.
4466 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4467 (scrolling_window): Don't pass it.
4469 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4471 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4473 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4475 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4476 of variables specific to SELinux and computation of `encoded_absname'.
4478 * image.c (XPutPixel): Remove unused variable `height'.
4480 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4482 * unexw32.c (get_section_info): Remove unused variable `section'.
4484 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4485 (system_process_attributes): Remove unused variable `sess'.
4486 (sys_read): Remove unused variable `err'.
4488 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4489 (w32_wnd_proc): Remove unused variable `isdead'.
4490 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4491 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4492 (x_create_tip_frame): Remove unused variable `tem'.
4494 * w32inevt.c (w32_console_read_socket):
4495 Remove unused variable `no_events'.
4497 * w32term.c (x_draw_composite_glyph_string_foreground):
4498 Remove unused variable `width'.
4500 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
4502 * w32term.c (x_set_glyph_string_clipping):
4503 Don't pass uninitialized region to CombineRgn.
4505 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
4507 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4508 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4509 (Fx_close_connection): Remove unused variable `i'.
4511 * w32font.c (w32font_draw): Return number of glyphs.
4512 (w32font_open_internal): Remove unused variable `i'.
4513 (w32font_driver): Add missing initializer.
4515 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4516 (fill_in_menu): Remove unused variable `items_added'.
4518 * w32term.c (last_mouse_press_frame): Remove static global variable.
4519 (w32_clip_to_row): Remove unused variable `f'.
4520 (x_delete_terminal): Remove unused variable `i'.
4522 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4523 (NOTHING): Remove unused static global variable.
4524 (uniscribe_check_otf): Remove unused variable `table'.
4525 (uniscribe_font_driver): Add missing initializers.
4527 2011-03-23 Julien Danjou <julien@danjou.info>
4529 * term.c (Fsuspend_tty, Fresume_tty):
4530 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4531 * window.c (temp_output_buffer_show):
4532 * insdel.c (signal_before_change):
4533 * frame.c (Fhandle_switch_frame):
4534 * fileio.c (Fdo_auto_save):
4535 * emacs.c (Fkill_emacs):
4536 * editfns.c (save_excursion_restore):
4537 * cmds.c (internal_self_insert):
4538 * callint.c (Fcall_interactively):
4539 * buffer.c (Fkill_all_local_variables):
4540 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4542 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
4543 unconditionnaly since it does the check itself.
4545 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
4547 Fix more problems found by GCC 4.5.2's static checks.
4549 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4550 the first time through the loop, since we know p0 < p1 then.
4551 This also avoids a gcc -Wstrict-overflow warning.
4553 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4554 leading to a memory leak, possible in functions like
4555 load_charset_map_from_file that can allocate an unbounded number
4556 of objects (Bug#8318).
4558 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4559 that could (at least in theory) be that large.
4561 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4562 This is less likely to overflow, and avoids undefined behavior if
4563 overflow does occur. All callers changed. Use strtoul to scan
4564 for the unsigned long integer.
4565 (pint2hrstr): Simplify and tune code slightly.
4566 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
4568 * scroll.c (do_scrolling): Work around GCC bug 48228.
4569 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4571 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4572 This also avoids a warning with gcc -Wstrict-overflow.
4573 (validate_x_resource_name): Simplify count usage.
4574 This also avoids a warning with gcc -Wstrict-overflow.
4576 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4579 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
4581 * process.c (Fmake_network_process): Use socklen_t, not int,
4582 where POSIX says socklen_t is required in portable programs.
4583 This fixes a porting bug on hosts like 64-bit HP-UX, where
4584 socklen_t is wider than int (Bug#8277).
4585 (Fmake_network_process, server_accept_connection):
4586 (wait_reading_process_output, read_process_output):
4589 * process.c: Rename or move locals to avoid shadowing.
4590 (list_processes_1, Fmake_network_process):
4591 (read_process_output_error_handler, exec_sentinel_error_handler):
4592 Rename or move locals.
4593 (Fmake_network_process): Define label "retry_connect" only if needed.
4594 (Fnetwork_interface_info): Fix pointer signedness.
4595 (process_send_signal): Add cast to avoid pointer signedness problem.
4596 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
4597 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
4599 Make tparam.h and terminfo.c consistent.
4600 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4601 Include tparam.h instead, since it declares them.
4602 * cm.h (PC): Remove extern decl; tparam.h now does this.
4603 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4604 * terminfo.c: Include tparam.h, to check interfaces.
4605 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4606 (tparam): Adjust signature to match interface in tparam.h;
4607 this removes some undefined behavior. Check that outstring and len
4608 are zero, which they always are with Emacs.
4609 * tparam.h (PC, BC, UP): New extern decls.
4611 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
4612 (xftfont_open): Rename locals to avoid shadowing.
4614 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
4615 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4616 (OTF_TAG_SYM): Omit macro if not needed.
4617 (ftfont_list): Remove unused local.
4618 (get_adstyle_property, ftfont_pattern_entity):
4619 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4620 Rename locals to avoid shadowing.
4622 * xfont.c (xfont_list_family): Mark var as initialized.
4624 * xml.c (make_dom): Now static.
4626 * composite.c (composition_compute_stop_pos): Rename local to
4628 (composition_reseat_it): Remove unused locals.
4629 (find_automatic_composition, composition_adjust_point): Likewise.
4630 (composition_update_it): Mark var as initialized.
4631 (find_automatic_composition): Mark vars as initialized,
4632 with a FIXME (Bug#8290).
4634 character.h: Rename locals to avoid shadowing.
4635 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4636 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4637 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4638 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4641 * textprop.c (property_change_between_p): Remove; unused.
4643 * intervals.c (interval_start_pos): Now static.
4645 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4647 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4648 Rename locals to avoid shadowing.
4650 * sound.c (wav_play, au_play, Fplay_sound_internal):
4651 Fix pointer signedness.
4652 (alsa_choose_format): Remove unused local var.
4653 (wav_play): Initialize a variable to 0, to prevent undefined
4654 behavior (Bug#8278).
4656 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4658 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4660 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4661 clobbering (Bug#8298).
4662 * sysdep.c (sys_subshell): Likewise.
4663 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
4665 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4666 This should get cleaned up, so that child_setup has the
4667 same signature on all platforms.
4669 * callproc.c (call_process_cleanup): Now static.
4670 (relocate_fd): Rename locals to avoid shadowing.
4672 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
4674 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4675 not to be necessary, and produces flickering.
4677 2011-03-20 Glenn Morris <rgm@gnu.org>
4679 * config.in: Remove file.
4681 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
4683 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4684 are now in src/globals.h.
4685 (syms_of_minibuf): Remove spurious & from previous change.
4687 2011-03-20 Leo <sdl.web@gmail.com>
4689 * minibuf.c (completing-read-function): New variable.
4690 (completing-read-default): Rename from completing-read.
4691 (completing-read): Call completing-read-function.
4693 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4695 * xfaces.c (Fx_load_color_file):
4696 Read color file from absolute filename (bug#8250).
4698 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4700 * makefile.w32-in: Update dependencies.
4702 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4704 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4706 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4708 Fix more problems found by GCC 4.5.2's static checks.
4710 * process.c (make_serial_process_unwind, send_process_trap):
4711 (sigchld_handler): Now static.
4713 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4714 That way, the code declares only the vars that it needs.
4715 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4716 * s/cygwin.h (PTY_ITERATION): Likewise.
4717 * s/darwin.h (PTY_ITERATION): Likewise.
4718 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4720 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4721 * process.c (allocate_pty): Don't declare stb unless it's needed.
4723 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4724 (CONSTANTLIM): Remove; unused.
4725 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4726 Define only if needed.
4728 * unexelf.c (unexec): Name an expression,
4729 to avoid gcc -Wbad-function-cast warning.
4730 Use a different way to cause a compilation error if anyone uses
4731 n rather than nn, a way that does not involve shadowing.
4732 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4734 * deps.mk (unexalpha.o): Remove; unused.
4736 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4737 * unexec.h: New file.
4738 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4739 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4741 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4742 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4743 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4744 Change as necessary to match prototype in unexec.h.
4746 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4748 (back_comment, skip_chars): Mark vars as initialized.
4750 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4751 Rename locals to avoid shadowing.
4753 * lread.c (read1): Rewrite so as not to use empty "else".
4754 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4756 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4758 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4759 warning when compiling print.c.
4761 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4762 instead of using an uninitialized var.
4763 (font_sort_entities): Mark var as initialized.
4765 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4767 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4768 pointers to constants.
4769 (font_parse_fcname): Remove unused vars.
4770 (font_delete_unmatched): Now static.
4771 (font_get_spec): Remove; unused.
4772 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4773 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4774 Rename or move locals to avoid shadowing.
4776 * fns.c (require_nesting_list, require_unwind): Now static.
4777 (Ffillarray): Rename locals to avoid shadowing.
4779 * floatfns.c (domain_error2): Define only if needed.
4780 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4782 * alloc.c (mark_backtrace): Move decl from here ...
4783 * lisp.h: ... to here, so that it can be checked.
4785 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4786 (Fdefvar): Rewrite so as not to use empty "else".
4787 (lisp_indirect_variable): Name an expression,
4788 to avoid gcc -Wbad-function-cast warning.
4789 (Fdefvar): Rename locals to avoid shadowing.
4791 * callint.c (quotify_arg, quotify_args): Now static.
4792 (Fcall_interactively): Rename locals to avoid shadowing.
4793 Use const pointer when appropriate.
4795 * lisp.h (get_system_name, get_operating_system_release):
4796 Move decls here, to check interfaces.
4797 * process.c (get_operating_system_release): Move decl to lisp.h.
4798 * xrdb.c (get_system_name): Likewise.
4799 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4800 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4801 some of which prompt warnings from gcc -Wbad-function-cast.
4802 (Fformat_time_string, Fencode_time, Finsert_char):
4803 (Ftranslate_region_internal, Fformat):
4804 Rename or remove local vars to avoid shadowing.
4805 (Ftranslate_region_internal): Mark var as initialized.
4807 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4810 * lisp.h (eassert): Check that the argument compiles, even if
4811 ENABLE_CHECKING is not defined.
4813 * data.c (Findirect_variable): Name an expression, to avoid
4814 gcc -Wbad-function-cast warning.
4815 (default_value, arithcompare, arith_driver, arith_error): Now static.
4816 (store_symval_forwarding): Rename local to avoid shadowing.
4817 (Fmake_variable_buffer_local, Fmake_local_variable):
4818 Mark variables as initialized.
4819 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4821 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4822 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4823 Rename locals to avoid shadowing.
4824 (mark_stack): Move local variables into the #ifdef region where
4826 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4827 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4829 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4830 (GC_STRING_CHARS): Remove; not used.
4831 (Fmemory_limit): Cast sbrk's returned value to char *.
4833 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4834 avoids undefined behavior in theory.
4836 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4838 Use functions, not macros, for up- and down-casing (Bug#8254).
4839 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4840 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4841 to use the following functions instead of these macros.
4842 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4843 EMACS_INT, since callers assume the returned value fits in int.
4844 (upcase1): Likewise, for UPCASE_TABLE.
4845 (uppercasep, lowercasep, upcase): New static inline functions.
4846 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4847 the race-condition problem in the old DOWNCASE.
4849 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4850 Rename locals to avoid shadowing.
4851 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4852 (regex_compile, re_search_2, re_match_2_internal):
4853 Remove unused local vars.
4854 (FREE_VAR): Rewrite so as not to use empty "else",
4855 which gcc can warn about.
4856 (regex_compile, re_match_2_internal): Mark locals as initialized.
4857 (RETALLOC_IF): Define only if needed.
4858 (WORDCHAR_P): Likewise. This one is never needed, but is used
4859 only in a comment talking about a compiler bug, so put inside
4860 the #if 0 of that comment.
4861 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4862 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4865 * search.c (boyer_moore): Rename locals to avoid shadowing.
4866 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4867 (PREV_CHAR_BOUNDARY): Likewise.
4869 * search.c (simple_search): Remove unused var.
4871 * dired.c (compile_pattern): Move decl from here ...
4872 * lisp.h: ... to here, so that it can be checked.
4873 (struct re_registers): New forward decl.
4875 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4877 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4879 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4880 Rename locals to avoid shadowing.
4881 (Fvertical_motion): Mark locals as initialized.
4883 * casefiddle.c (casify_object, casify_region): Now static.
4884 (casify_region): Mark local as initialized.
4886 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4888 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4889 New macros, so that the caller can use some names other than
4890 gcpro1, gcpro2, etc.
4891 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4893 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4894 argument, for consistency with GCPRO2_VAR, etc: it is now the
4895 prefix of the variable, not the variable itself. All uses
4897 * dired.c (directory_files_internal, file_name_completion):
4898 Rename locals to avoid shadowing.
4900 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4901 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4902 dired.c's scmp function, had undefined behavior.
4903 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4904 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4905 * buffer.h: ... to here, because these macros use current_buffer,
4906 and the new implementation with inline functions needs to have
4907 current_buffer in scope now, rather than later when the macros
4909 (downcase, upcase1): New static inline functions.
4910 (DOWNCASE, UPCASE1): Reimplement using these functions.
4911 This avoids undefined behavior in expressions like
4912 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4913 from race conditions in accessing the global variables
4914 case_temp1 and case_temp2.
4915 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4916 * lisp.h (case_temp1, case_temp2): Remove their decls.
4917 * character.h (ASCII_CHAR_P): Move from here ...
4918 * lisp.h: ... to here, so that the inline functions mentioned
4921 * dired.c (directory_files_internal_unwind): Now static.
4923 * fileio.c (file_name_as_directory, directory_file_name):
4924 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4926 (file_name_as_directory): Use const pointers when appropriate.
4927 (Fexpand_file_name): Likewise. In particular, newdir might
4928 point at constant storage, so make it a const pointer.
4929 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4930 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4932 (Fset_file_times, Finsert_file_contents, auto_save_error):
4933 Rename locals to avoid shadowing.
4935 * minibuf.c (choose_minibuf_frame_1): Now static.
4936 (Ftry_completion, Fall_completions): Rename or remove locals
4939 * marker.c (bytepos_to_charpos): Remove; unused.
4941 * lisp.h (verify_bytepos, count_markers): New decls,
4942 so that gcc does not warn that these functions aren't declared.
4944 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4945 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4946 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4947 (copy_text): Remove unused local var.
4949 * filelock.c (within_one_second): Now static.
4950 (lock_file_1): Rename local to avoid shadowing.
4952 * buffer.c (fix_overlays_before): Mark locals as initialized.
4953 (fix_start_end_in_overlays): Likewise. This function should be
4954 simplified by using pointers-to-pointers, but that's a different
4956 (switch_to_buffer_1): Now static.
4957 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4958 (report_overlay_modification): Rename locals to avoid shadowing.
4960 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4961 Fix pointer signedness issue.
4962 (sys_subshell): Mark local as volatile if checking for lint,
4963 to suppress a gcc -Wclobbered warning that does not seem to be right.
4964 (MAXPATHLEN): Define only if needed.
4966 * process.c (serial_open, serial_configure): Move decls from here ...
4967 * systty.h: ... to here, so that they can be checked.
4969 * fns.c (get_random, seed_random): Move extern decls from here ...
4970 * lisp.h: ... to here, so that they can be checked.
4972 * sysdep.c (reset_io): Now static.
4973 (wait_for_termination_signal): Remove; unused.
4975 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4976 (copy_keymap_item, append_key, push_text_char_description):
4978 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4979 (DENSE_TABLE_SIZE): Remove; unused.
4980 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4981 (describe_map_tree):
4982 Rename locals to avoid shadowing.
4984 * keyboard.c: Declare functions static if they are not used elsewhere.
4985 (echo_char, echo_dash, cmd_error, top_level_2):
4986 (poll_for_input, handle_async_input): Now static.
4987 (read_char, kbd_buffer_get_event, make_lispy_position):
4988 (make_lispy_event, make_lispy_movement, apply_modifiers):
4989 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4990 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4991 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4992 (read_key_sequence, read_char): Mark locals as initialized.
4993 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4995 * keyboard.h (make_ctrl_char): New decl.
4996 (mark_kboards): Move decl here ...
4997 * alloc.c (mark_kboards): ... from here.
4999 * lisp.h (force_auto_save_soon): New decl.
5001 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5002 (DEFINE_DUMMY_FUNCTION): New macro.
5003 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5005 (main): Add casts to avoid warnings
5006 if GCC considers string literals to be constants.
5008 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5010 * dbusbind.c: Pointer signedness fixes.
5011 (xd_signature, xd_append_arg, xd_initialize):
5012 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5013 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5014 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5015 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5017 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5018 if GCC considers string literals to be constants.
5019 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5021 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5023 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5024 (print_preprocess, print_object): New macro to fix last change.
5026 * print.c (print_preprocess): Don't forget font objects.
5028 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5030 * emacs.c (USAGE3): Doc fixes.
5032 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5034 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5037 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5039 * lisp.h (VWindow_system, Qfile_name_history):
5040 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5041 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5042 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5044 * w32select.c: Don't #include "keyboard.h".
5045 (run_protected): Add extern declaration for waiting_for_input.
5047 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5048 * w32console.c (detect_input_pending, read_input_pending)
5049 (encode_terminal_code):
5050 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5051 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5052 (w32_system_caret_y, Qfile_name_history):
5053 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5054 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5055 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5056 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5057 * w32proc.c (Qlocal, report_file_error):
5058 * w32term.c (Vwindow_system, updating_frame):
5059 * w32uniscribe.c (initialized, uniscribe_font_driver):
5060 Remove unneeded extern declarations.
5062 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5064 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5066 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
5068 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5069 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5070 These macros can no longer be used for assignment.
5072 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5073 Assign struct members directly, instead of using BUF_BEGV etc.
5074 (record_buffer_markers, fetch_buffer_markers): New functions for
5075 recording and fetching special buffer markers.
5076 (set_buffer_internal_1, set_buffer_temp): Use them.
5078 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5080 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5082 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5083 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5085 * xdisp.c (hscroll_window_tree):
5086 (reconsider_clip_changes): Use PT instead of BUF_PT.
5088 2011-03-13 Eli Zaretskii <eliz@gnu.org>
5090 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5091 $(EMACS_ROOT)/lib/intprops.h.
5093 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5095 Fix more problems found by GCC 4.5.2's static checks.
5097 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5098 to unsigned char * to avoid compiler diagnostic.
5099 (xg_free_frame_widgets): Make it clear that a local variable is
5100 needed only if USE_GTK_TOOLTIP.
5101 (gdk_window_get_screen): Make it clear that this macro is needed
5102 only if USE_GTK_TOOLTIP.
5103 (int_gtk_range_get_value): New function, which avoids a diagnostic
5104 from gcc -Wbad-function-cast.
5105 (xg_set_toolkit_scroll_bar_thumb): Use it.
5106 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5107 diagnostic from gcc -Wbad-function-cast.
5108 (get_utf8_string, xg_get_file_with_chooser):
5109 Rename locals to avoid shadowing.
5110 (create_dialog): Move locals to avoid shadowing.
5112 * xgselect.c (xg_select): Remove unused var.
5114 * image.c (four_corners_best): Mark locals as initialized.
5115 (gif_load): Initialize transparent_p to zero (Bug#8238).
5116 Mark another local as initialized.
5117 (my_png_error, my_error_exit): Mark with NO_RETURN.
5119 * image.c (clear_image_cache): Now static.
5120 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5121 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5122 (x_edge_detection): Remove unnecessary cast that
5123 gcc -Wbad-function-cast diagnoses.
5124 (gif_load): Fix pointer signedness.
5125 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5126 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5128 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5130 Improve quality of tests for time stamp overflow.
5131 For example, without this patch (encode-time 0 0 0 1 1
5132 1152921504606846976) returns the obviously-bogus value (-948597
5133 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5134 reports time overflow. See
5135 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5136 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5137 * editfns.c: Include limits.h and intprops.h.
5138 (TIME_T_MIN, TIME_T_MAX): New macros.
5139 (time_overflow): Move earlier, to before first use.
5140 (hi_time, lo_time): New functions, for an accurate test for
5142 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5143 (Fget_internal_run_time): Don't assume time_t fits in int.
5144 (make_time): Use list2 instead of Fcons twice.
5145 (Fdecode_time): More accurate test for out-of-range times.
5146 (check_tm_member): New function.
5147 (Fencode_time): Use it, to test for out-of-range times.
5148 (lisp_time_argument): Don't rely on undefined left-shift and
5149 right-shift behavior when checking for time stamp overflow.
5151 * editfns.c (time_overflow): New function, refactoring common code.
5152 (Fformat_time_string, Fdecode_time, Fencode_time):
5153 (Fcurrent_time_string): Use it.
5155 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5156 * dired.c (make_time): Move to ...
5157 * editfns.c (make_time): ... here.
5158 * systime.h: Note the move.
5160 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5162 * fringe.c (update_window_fringes): Remove unused variables.
5164 * unexmacosx.c (copy_data_segment): Also copy __got section.
5167 2011-03-12 Eli Zaretskii <eliz@gnu.org>
5169 * termcap.c [MSDOS]: Include "msdos.h".
5170 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5171 Constify `char *' arguments and their references according to
5172 prototypes in tparam.h.
5174 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
5176 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5177 Adapt all references accordingly.
5179 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5181 2011-03-11 Tom Tromey <tromey@redhat.com>
5183 * buffer.c (syms_of_buffer): Remove obsolete comment.
5185 2011-03-11 Eli Zaretskii <eliz@gnu.org>
5187 * termhooks.h (encode_terminal_code): Declare prototype.
5189 * msdos.c (encode_terminal_code): Don't declare prototype.
5191 * term.c (encode_terminal_code): Now external again, used by
5192 w32console.c and msdos.c.
5194 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5195 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
5197 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
5199 Fix some minor problems found by GCC 4.5.2's static checks.
5201 * fringe.c (update_window_fringes): Mark locals as initialized
5203 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
5205 * alloc.c (mark_fringe_data): Move decl from here ...
5206 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5207 to check its interface.
5208 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5210 * fontset.c (free_realized_fontset): Now static.
5211 (Fset_fontset_font): Rename local to avoid shadowing.
5212 (fontset_font): Mark local as initialized.
5213 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
5215 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5217 * xselect.c (x_disown_buffer_selections): Remove; not used.
5218 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
5219 (x_own_selection, Fx_disown_selection_internal): Rename locals
5221 (x_handle_dnd_message): Remove local to avoid shadowing.
5223 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5224 so that the caller can use some name other than gcpro1.
5225 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
5226 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5227 (Fx_backspace_delete_keys_p):
5228 Use them to avoid shadowing, and rename vars to avoid shadowing.
5229 (x_decode_color, x_set_name, x_window): Now static.
5230 (Fx_create_frame): Add braces to silence GCC warning.
5231 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
5232 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5233 Remove unused locals.
5234 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5235 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5236 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5239 * xterm.h (x_mouse_leave): New decl.
5241 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5242 Remove unused functions.
5243 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5244 (x_calc_absolute_position): Now static.
5245 (XTread_socket): Don't define label "out" unless it's used.
5246 Don't declare local "event" unless it's used.
5247 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5248 unless they are used.
5249 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5250 (x_fatal_error_signal): Remove; not used.
5251 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5252 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5253 (x_error_catcher, x_connection_closed, x_error_handler):
5254 (x_error_quitter, xembed_send_message, x_iconify_frame):
5255 (my_log_handler): Rename locals to avoid shadowing.
5256 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
5257 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
5259 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5260 Rename or move locals to avoid shadowing.
5261 (tty_defined_color, merge_face_heights): Now static.
5262 (free_realized_faces_for_fontset): Remove; not used.
5263 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5264 does not deduce is never used uninitialized.
5265 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5266 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
5268 * terminal.c (store_terminal_param): Now static.
5270 * xmenu.c (menu_highlight_callback): Now static.
5271 (set_frame_menubar): Remove unused local.
5272 (xmenu_show): Rename parameter to avoid shadowing.
5273 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5274 since they might point to immutable storage.
5275 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5276 since it's unused otherwise.
5278 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
5279 Add a FIXME, since the code still doesn't look right. (Bug#8215)
5280 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5281 avoids a gcc -Wuninitialized diagnostic.
5282 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
5283 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5284 does not deduce are never used uninitialized.
5286 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5288 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
5289 * window.c (window_loop, size_window):
5290 (run_window_configuration_change_hook, enlarge_window): Likewise.
5292 * window.c (display_buffer): Now static.
5293 (size_window): Mark variables that gcc -Wuninitialized
5294 does not deduce are never used uninitialized.
5295 * window.h (check_all_windows): New decl, to forestall
5296 gcc -Wmissing-prototypes diagnostic.
5297 * dispextern.h (bidi_dump_cached_states): Likewise.
5299 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5301 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
5303 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5304 and to avoid gcc -Wuninitialized warning.
5305 (load_charset_map): Mark variables that gcc -Wuninitialized
5306 does not deduce are never used uninitialized.
5307 (load_charset): Abort instead of using uninitialized var (Bug#8229).
5309 * coding.c (coding_set_source, coding_set_destination):
5310 Use "else { /* comment */ }" rather than "else /* comment */;"
5311 for clarity, and to avoid gcc -Wempty-body warning.
5312 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5313 a block, when the outer 'i' will do.
5314 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5315 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5316 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5317 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5318 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5319 Rename locals to avoid shadowing.
5320 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
5321 * coding.c (emacs_mule_char, encode_invocation_designation):
5322 Now static, since they're not used elsewhere.
5323 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
5324 (decode_coding_object, encode_coding_object, detect_coding_system):
5325 (decode_coding_emacs_mule): Mark variables that gcc
5326 -Wuninitialized does not deduce are never used uninitialized.
5327 (detect_coding_iso_2022): Initialize a local variable that might
5328 be used uninitialized. Leave a FIXME because it's not clear that
5329 this initialization is needed. (Bug#8211)
5330 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5331 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5332 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5333 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5334 Remove unused macros.
5336 * category.c (hash_get_category_set): Remove unused local var.
5337 (copy_category_table): Now static, since it's not used elsewhere.
5338 * character.c (string_count_byte8): Likewise.
5340 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5341 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5343 * chartab.c (copy_sub_char_table): Now static, since it's not used
5345 (sub_char_table_ref_and_range, char_table_ref_and_range):
5346 Rename locals to avoid shadowing.
5347 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
5349 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
5350 (BIDI_BOB): Remove unused macro.
5352 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5353 deduce are never used uninitialized.
5354 * term.c (encode_terminal_code): Likewise.
5356 * term.c (encode_terminal_code): Now static. Remove unused local.
5358 * tparam.h: New file.
5359 * term.c, tparam.h: Include it.
5360 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5361 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5362 Move these decls to tparam.h, and make them agree with what
5363 is actually in tparam.c. The previous trick of using incompatible
5364 decls in different modules does not conform to the C standard.
5365 All callers of tparam changed to use tparam's actual API.
5366 * tparam.c (tparam1, tparam, tgoto):
5367 Use const pointers where appropriate.
5369 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5370 * cm.h (struct cm): Likewise.
5371 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5372 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5373 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5374 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5375 (turn_on_face, init_tty): Likewise.
5376 * termchar.h (struct tty_display_info): Likewise.
5378 * term.c (term_mouse_position): Rename local to avoid shadowing.
5380 * alloc.c (mark_ttys): Move decl from here ...
5381 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5383 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5385 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5387 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
5389 * search.c (compile_pattern_1): Remove argument regp, unused since
5390 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5391 (compile_pattern): Don't pass it.
5393 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5395 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5396 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5398 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5400 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5402 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5403 gdk_window_get_screen, gdk_window_get_geometry,
5404 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5405 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5406 (xg_get_pixbuf_from_pixmap): New function.
5407 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5408 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5409 Call xg_get_pixbuf_from_pixmap instead of
5410 gdk_pixbuf_get_from_drawable.
5411 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5412 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5413 (xg_check_special_colors): Use GtkStyleContext and its functions
5415 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5416 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5417 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5418 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5419 Call gtk_widget_get_preferred_size.
5420 (xg_frame_resized): gdk_window_get_geometry only takes 5
5422 (xg_win_to_widget, xg_event_is_for_menubar):
5423 Call gdk_x11_window_lookup_for_display.
5424 (xg_set_widget_bg): New function.
5425 (delete_cb): New function.
5426 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5427 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5428 (xg_set_background_color): Call xg_set_widget_bg.
5429 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5430 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5431 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5432 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5434 (update_frame_tool_bar): Call gtk_widget_hide.
5435 (xg_initialize): Use GDK_KEY_g.
5437 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5439 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5441 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5442 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5443 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5445 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
5447 * w32xfns.c (select_palette): Check success of RealizePalette against
5448 GDI_ERROR, not zero.
5450 See ChangeLog.11 for earlier changes.
5456 Copyright (C) 2011 Free Software Foundation, Inc.
5458 This file is part of GNU Emacs.
5460 GNU Emacs is free software: you can redistribute it and/or modify
5461 it under the terms of the GNU General Public License as published by
5462 the Free Software Foundation, either version 3 of the License, or
5463 (at your option) any later version.
5465 GNU Emacs is distributed in the hope that it will be useful,
5466 but WITHOUT ANY WARRANTY; without even the implied warranty of
5467 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5468 GNU General Public License for more details.
5470 You should have received a copy of the GNU General Public License
5471 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.