Merge from trunk.
[bpt/emacs.git] / src / ChangeLog
1 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2
3 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4 (syms_of_gnutls): Remove duplicate DEFSYM for
5 Qgnutls_bootprop_verify_hostname_error, an error for
6 Qgnutls_bootprop_verify_error (which is no longer used).
7
8 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
10 Also (re)move comments that are misplaced or no longer relevant.
11
12 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
13
14 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
15
16 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
17
18 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
19 and background color parameters if they have been changed.
20
21 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
22
23 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
24
25 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
26
27 * xsettings.c (SYSTEM_FONT): Define only when used.
28 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
29
30 * keymap.c (access_keymap_1): Now static.
31
32 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
33
34 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
35 leave any prefix arg for the up event (Bug#1586).
36
37 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
38
39 * lread.c (syms_of_lread): Mention single symbols defined by
40 `defvar' or `defconst' (bug#7154).
41
42 * fns.c (Frequire): Mention .el.gz files (bug#7314).
43 (Frequire): Mention get-load-suffixes.
44
45 2011-07-02 Martin Rudalics <rudalics@gmx.at>
46
47 * window.h (window): Remove clone_number slot.
48 * window.c (Fwindow_clone_number, Fset_window_clone_number):
49 Remove.
50 (make_parent_window, make_window, saved_window)
51 (Fset_window_configuration, save_window_save): Don't deal with
52 clone numbers.
53 * buffer.c (Qclone_number): Remove declaration.
54 (sort_overlays, overlay_strings): Don't deal with clone numbers.
55
56 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
57
58 Add multiple inheritance to keymaps.
59 * keymap.c (Fmake_composed_keymap): New function.
60 (Fset_keymap_parent): Simplify.
61 (fix_submap_inheritance): Remove.
62 (access_keymap_1): New function extracted from access_keymap to handle
63 embedded parents and handle lists of maps.
64 (access_keymap): Use it.
65 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
66 (Fcopy_keymap): Handle embedded parents.
67 (Fcommand_remapping, define_as_prefix): Simplify.
68 (Fkey_binding): Simplify.
69 (syms_of_keymap): Move minibuffer-local-completion-map,
70 minibuffer-local-filename-completion-map,
71 minibuffer-local-must-match-map, and
72 minibuffer-local-filename-must-match-map to Elisp.
73 (syms_of_keymap): Defsubr make-composed-keymap.
74 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
75 (parse_menu_item): Trivial simplification.
76
77 2011-07-01 Glenn Morris <rgm@gnu.org>
78
79 * Makefile.in (SETTINGS_LIBS): Fix typo.
80
81 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
82
83 * coding.c (Fencode_coding_string): Record the last coding system
84 used, as the function doc string says (bug#8738).
85
86 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
87
88 * xsettings.c (store_monospaced_changed): Take new font as arg and
89 check for change against current_mono_font.
90 (EMACS_TYPE_SETTINGS): Remove this and related defines.
91 (emacs_settings_constructor, emacs_settings_get_property)
92 (emacs_settings_set_property, emacs_settings_class_init)
93 (emacs_settings_init, gsettings_obj): Remove.
94 (something_changedCB): New function for HAVE_GSETTINGS.
95 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
96 with value as argument.
97 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
98 g_settings_new (Bug#8967). Do not create gsettings_obj.
99 Remove calls to g_settings_bind. Connect something_changedCB to
100 "changed".
101
102 * xgselect.c: Add defined (HAVE_GSETTINGS).
103 (xgselect_initialize): Ditto.
104
105 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
106 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
107 xg_select.
108
109 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
110
111 * eval.c (struct backtrace): Simplify and port the data structure.
112 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
113 signed bit field, as this assumption is not portable and it makes
114 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
115 "char debug_on_exit : 1" as this is not portable either; instead,
116 use the portable "unsigned int debug_on_exit : 1". Remove unused
117 member evalargs. Remove obsolete comments about cc bombing out.
118
119 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
120
121 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
122 Let HAVE_GSETTINGS override HAVE_GCONF.
123 (store_monospaced_changed): New function.
124 (EMACS_SETTINGS): A new type derived from GObject to handle
125 GSettings notifications.
126 (emacs_settings_constructor, emacs_settings_get_property)
127 (emacs_settings_set_property, emacs_settings_class_init):
128 New functions.
129 (gsettings_client, gsettings_obj): New variables.
130 (GSETTINGS_SCHEMA): New define.
131 (something_changedCB): Call store_monospaced_changed.
132 (init_gsettings): New function.
133 (xsettings_initialize): Call init_gsettings.
134 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
135 to NULL.
136
137 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
138 GCONF_CFLAGS/LIBS.
139
140 2011-06-29 Martin Rudalics <rudalics@gmx.at>
141
142 * window.c (resize_root_window, grow_mini_window)
143 (shrink_mini_window): Rename Qresize_root_window to
144 Qwindow_resize_root_window and Qresize_root_window_vertically to
145 Qwindow_resize_root_window_vertically.
146
147 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
148
149 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
150
151 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
152
153 * makefile.w32-in: Redesign dependencies so they reflect more
154 clearly which files are directly included by each source file,
155 and not through other includes.
156
157 2011-06-27 Martin Rudalics <rudalics@gmx.at>
158
159 * buffer.c (Qclone_number): Declare static and DEFSYM it.
160 (sort_overlays, overlay_strings): When an overlay's clone number
161 matches the window's clone number process the overlay even if
162 the overlay's window property doesn't match the current window.
163
164 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
165 (Fwindow_hchild): Rename to Fwindow_left_child.
166 (Fwindow_next): Rename to Fwindow_next_sibling.
167 (Fwindow_prev): Rename to Fwindow_prev_sibling.
168 (resize_window_check): Rename to window_resize_check.
169 (resize_window_apply): Rename to window_resize_apply.
170 (Fresize_window_apply): Rename to Fwindow_resize_apply.
171 (Fdelete_other_windows_internal, resize_frame_windows)
172 (Fsplit_window_internal, Fdelete_window_internal)
173 (grow_mini_window, shrink_mini_window)
174 (Fresize_mini_window_internal): Fix callers accordingly.
175
176 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
177
178 * emacsgtkfixed.h: State that this is only used with Gtk+3.
179 (emacs_fixed_set_min_size): Remove.
180 (emacs_fixed_new): Take frame as argument.
181
182 * emacsgtkfixed.c: State that this is only used with Gtk+3.
183 (_EmacsFixedPrivate): Remove minwidth/height.
184 Add struct frame *f.
185 (emacs_fixed_init): Initialize priv->f.
186 (get_parent_class, emacs_fixed_set_min_size): Remove.
187 (emacs_fixed_new): Set priv->f to argument.
188 (emacs_fixed_get_preferred_width)
189 (emacs_fixed_get_preferred_height): Use min_width/height from
190 frames size_hint to set minimum and natural (Bug#8919).
191 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
192 and use min_width/height from frames size_hint to set
193 min_width/height (Bug#8919).
194
195 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
196 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size. Fix
197 indentation.
198
199 2011-06-26 Eli Zaretskii <eliz@gnu.org>
200
201 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
202 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
203 called at ZV.
204
205 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
206
207 * process.c (wait_reading_process_output): Bypass select if
208 waiting for a cell while ignoring keyboard input, and input is
209 pending. Suggested by Jan Djärv (Bug#8869).
210
211 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
212
213 Use gnulib's dup2 module instead of rolling our own.
214 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
215
216 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
217
218 * dispnew.c (scrolling_window): Before scrolling, turn off a
219 mouse-highlight in the window being scrolled.
220
221 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
222
223 Move DEFSYM to lisp.h and use everywhere.
224
225 * character.h (DEFSYM): Move declaration...
226 * lisp.h (DEFSYM): ...here.
227
228 * gnutls.c:
229 * minibuf.c:
230 * w32menu.c:
231 * w32proc.c:
232 * w32select.c: Don't include character.h.
233
234 * alloc.c (syms_of_alloc):
235 * buffer.c (syms_of_buffer):
236 * bytecode.c (syms_of_bytecode):
237 * callint.c (syms_of_callint):
238 * casefiddle.c (syms_of_casefiddle):
239 * casetab.c (init_casetab_once):
240 * category.c (init_category_once, syms_of_category):
241 * ccl.c (syms_of_ccl):
242 * cmds.c (syms_of_cmds):
243 * composite.c (syms_of_composite):
244 * dbusbind.c (syms_of_dbusbind):
245 * dired.c (syms_of_dired):
246 * dispnew.c (syms_of_display):
247 * doc.c (syms_of_doc):
248 * editfns.c (syms_of_editfns):
249 * emacs.c (syms_of_emacs):
250 * eval.c (syms_of_eval):
251 * fileio.c (syms_of_fileio):
252 * fns.c (syms_of_fns):
253 * frame.c (syms_of_frame):
254 * fringe.c (syms_of_fringe):
255 * insdel.c (syms_of_insdel):
256 * keymap.c (syms_of_keymap):
257 * lread.c (init_obarray, syms_of_lread):
258 * macros.c (syms_of_macros):
259 * msdos.c (syms_of_msdos):
260 * print.c (syms_of_print):
261 * process.c (syms_of_process):
262 * search.c (syms_of_search):
263 * sound.c (syms_of_sound):
264 * syntax.c (init_syntax_once, syms_of_syntax):
265 * terminal.c (syms_of_terminal):
266 * textprop.c (syms_of_textprop):
267 * undo.c (syms_of_undo):
268 * w32.c (globals_of_w32):
269 * window.c (syms_of_window):
270 * xdisp.c (syms_of_xdisp):
271 * xfaces.c (syms_of_xfaces):
272 * xfns.c (syms_of_xfns):
273 * xmenu.c (syms_of_xmenu):
274 * xsettings.c (syms_of_xsettings):
275 * xterm.c (syms_of_xterm): Use DEFSYM.
276
277 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
278
279 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
280
281 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
282
283 Integer and buffer overflow fixes (Bug#8873).
284
285 * print.c (printchar, strout): Check for string overflow.
286 (PRINTPREPARE, printchar, strout):
287 Don't set size unless allocation succeeds.
288
289 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
290 for sizes. Check for string overflow more accurately.
291 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
292
293 * macros.c: Integer and buffer overflow fixes.
294 * keyboard.h (struct keyboard.kbd_macro_bufsize):
295 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
296 Use ptrdiff_t, not int, for sizes.
297 Don't increment bufsize until after realloc succeeds.
298 Check for size-calculation overflow.
299 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
300
301 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
302
303 * lread.c: Integer overflow fixes.
304 (read_integer): Radix is now EMACS_INT, not int,
305 to improve quality of diagnostics for out-of-range radices.
306 Calculate buffer size correctly for out-of-range radices.
307 (read1): Check for integer overflow in radices, and in
308 read-circle numbers.
309 (read_escape): Avoid int overflow.
310 (Fload, openp, read_buffer_size, read1)
311 (substitute_object_recurse, read_vector, read_list, map_obarray):
312 Use ptrdiff_t, not int, for sizes.
313 (read1): Use EMACS_INT, not int, for sizes.
314 Check for size overflow.
315
316 * image.c (cache_image): Check for size arithmetic overflow.
317
318 * lread.c: Integer overflow issues.
319 (saved_doc_string_size, saved_doc_string_length)
320 (prev_saved_doc_string_size, prev_saved_doc_string_length):
321 Now ptrdiff_t, not int.
322 (read1): Don't assume doc string length fits in int. Check for
323 out-of-range doc string lengths.
324 (read_list): Don't assume file position fits in int.
325 (read_escape): Check for hex character overflow.
326
327 2011-06-22 Leo Liu <sdl.web@gmail.com>
328
329 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
330 Move to minibuffer.el.
331
332 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
333
334 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
335 The following patches are for when GLYPH_DEBUG && !XASSERT.
336 * dispextern.h (trace_redisplay_p, dump_glyph_string):
337 * dispnew.c (flush_stdout):
338 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
339 Mark as externally visible.
340 * dispnew.c (check_window_matrix_pointers): Now static.
341 * dispnew.c (window_to_frame_vpos):
342 * xfns.c (unwind_create_frame):
343 * xterm.c (x_check_font): Remove unused local.
344 * scroll.c (CHECK_BOUNDS):
345 * xfaces.c (cache_fache): Rename local to avoid shadowing.
346 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
347 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
348 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
349 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
350 Now static.
351 (debug_method_add): Use va_list and vsprintf rather than relying
352 on undefined behavior with wrong number of arguments.
353 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
354 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
355 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
356 since we're not interested in debugging glyphs with old libraries.
357 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
358 GCC 4.6.0's static checking.
359
360 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
361
362 Integer overflow and signedness fixes (Bug#8873).
363 A few related buffer overrun fixes, too.
364
365 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
366
367 * dispextern.h (struct face.stipple):
368 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
369 (x_bitmap_mask, x_allocate_bitmap_record)
370 (x_create_bitmap_from_data, x_create_bitmap_from_file)
371 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
372 (x_create_bitmap_from_xpm_data):
373 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
374 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
375 (.bitmaps_last):
376 * xfaces.c (load_pixmap):
377 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
378 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
379 (.bitmaps_last, struct x_output.icon_bitmap):
380 Use ptrdiff_t, not int, for bitmap indexes.
381 (x_allocate_bitmap_record): Check for size overflow.
382 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
383
384 Use ptrdiff_t, not int, for overlay counts.
385 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
386 * editfns.c (overlays_around, get_pos_property):
387 * textprop.c (get_char_property_and_overlay):
388 * xdisp.c (next_overlay_change, note_mouse_highlight):
389 * xfaces.c (face_at_buffer_position):
390 * buffer.c (OVERLAY_COUNT_MAX): New macro.
391 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
392 (Fnext_overlay_change, Fprevious_overlay_change)
393 (mouse_face_overlay_overlaps, Foverlays_in):
394 Use ptrdiff_t, not int, for sizes.
395 (overlays_at, overlays_in): Check for size-calculation overflow.
396
397 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
398
399 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
400 (x_session_initialize): Do not assume string length fits in int.
401
402 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
403 This is unlikely, but can occur if DPI is outlandish.
404
405 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
406 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
407
408 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
409 * xrdb.c (magic_file_p, search_magic_path):
410 Omit last arg SUFFIX; it was always 0. All callers changed.
411 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
412
413 * xfont.c (xfont_match): Avoid need for strlen.
414
415 * xfns.c: Don't assume strlen fits in int.
416 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
417
418 * xdisp.c (message_log_check_duplicate): Return intmax_t,
419 not unsigned long, as we prefer signed integers. All callers changed.
420 Detect integer overflow in repeat count.
421 (message_dolog): Don't assume print length fits in 39 bytes.
422 (display_mode_element): Don't assume strlen fits in int.
423
424 * termcap.c: Don't assume sizes fit in int and never overflow.
425 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
426 (gobble_line): Check for size-calculation overflow.
427
428 * minibuf.c (Fread_buffer):
429 * lread.c (intern, intern_c_string):
430 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
431 Don't assume string length fits in int.
432
433 * keyboard.c (parse_tool_bar_item):
434 * gtkutil.c (style_changed_cb): Avoid need for strlen.
435
436 * font.c: Don't assume string length fits in int.
437 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
438 Use ptrdiff_t, not int.
439 (font_intern_prop): Don't assume string length fits in int.
440 Don't assume integer property fits in fixnum.
441 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
442
443 * filelock.c: Fix some buffer overrun and integer overflow issues.
444 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
445 Reformulate so as not to need the command string.
446 Invoke gzip -cd rather than gunzip, as it's more portable.
447 (lock_info_type, lock_file_1, lock_file):
448 Don't assume pid_t and time_t fit in unsigned long.
449 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
450 (current_lock_owner): Prefer signed type for sizes.
451 Use memcpy, not strncpy, where memcpy is what is really wanted.
452 Don't assume (via atoi) that time_t and pid_t fit in int.
453 Check for time_t and/or pid_t out of range, e.g., via a network share.
454 Don't alloca where an auto var works fine.
455
456 * fileio.c: Fix some integer overflow issues.
457 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
458 Don't assume string length fits in int.
459 (directory_file_name): Don't assume string length fits in long.
460 (make_temp_name): Don't assume pid fits in int, or that its print
461 length is less than 20.
462
463 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
464
465 * coding.c (make_subsidiaries): Don't assume string length fits in int.
466
467 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
468
469 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
470 We prefer signed integers, even for size calculations.
471
472 * emacs.c: Don't assume string length fits in 'int'.
473 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
474 (main): Don't invoke strlen when not needed.
475
476 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
477 (XD_DEBUG_MESSAGE): Don't waste a byte.
478
479 * callproc.c (getenv_internal_1, getenv_internal)
480 (Fgetenv_internal):
481 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
482
483 * lread.c (invalid_syntax): Omit length argument.
484 All uses changed. This doesn't fix a bug, but it simplifies the
485 code away from its former Hollerith-constant appearance, and it's
486 one less 'int' to worry about when looking at integer-overflow issues.
487 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
488
489 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
490 This didn't break anything, but it didn't help either.
491 It's confusing to put a bogus integer in a place where the actual
492 value does not matter.
493 (LIST_END_P): Remove unused macro and its bogus comment.
494 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
495
496 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
497 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
498 implementation.
499 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
500 We prefer signed types, and the value cannot exceed the EMACS_INT
501 range anyway (because otherwise the length would not be representable).
502 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
503 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
504 This avoids a GCC warning when WIDE_EMACS_INT.
505
506 * indent.c (sane_tab_width): New function.
507 (current_column, scan_for_column, Findent_to, position_indentation)
508 (compute_motion): Use it. This is just for clarity.
509 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
510
511 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
512
513 * lisp.h (lint_assume): New macro.
514 * composite.c (composition_gstring_put_cache):
515 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
516
517 * editfns.c, insdel.c:
518 Omit unnecessary forward decls, to simplify future changes.
519
520 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
521
522 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
523
524 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
525 Use much-faster test for byte-length change.
526 Don't assume string byte-length fits in 'int'.
527 Check that character arg fits in 'int'.
528 (mapcar1): Declare byte as byte, for clarity.
529
530 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
531
532 * fns.c (concat): Catch string overflow earlier.
533 Do not rely on integer wraparound.
534
535 * dispextern.h (struct it.overlay_strings_charpos)
536 (struct it.selective): Now EMACS_INT, not int.
537 * xdisp.c (forward_to_next_line_start)
538 (back_to_previous_visible_line_start)
539 (reseat_at_next_visible_line_start, next_element_from_buffer):
540 Don't arbitrarily truncate the value of 'selective' to int.
541
542 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
543
544 * composite.c: Don't truncate sizes to 'int'.
545 (composition_gstring_p, composition_reseat_it)
546 (composition_adjust_point): Use EMACS_INT, not int.
547 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
548 not EMACS_UINT, for indexes.
549
550 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
551
552 * buffer.c: Include <verify.h>.
553 (struct sortvec.priority, struct sortstr.priority):
554 Now EMACS_INT, not int.
555 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
556 (struct sortstr.size, record_overlay_string)
557 (struct sortstrlist.size, struct sortlist.used):
558 Don't truncate size to int.
559 (record_overlay_string): Check for size-calculation overflow.
560 (init_buffer_once): Check at compile-time, not run-time.
561
562 2011-06-22 Jim Meyering <meyering@redhat.com>
563
564 Don't leak an XBM-image-sized buffer
565 * image.c (xbm_load): Free the image buffer after using it.
566
567 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
568
569 Port to Sun C.
570 * composite.c (find_automatic_composition): Omit needless 'return 0;'
571 that Sun C diagnosed.
572 * fns.c (secure_hash): Fix pointer signedness issue.
573 * intervals.c (static_offset_intervals): New function.
574 (offset_intervals): Use it.
575
576 2011-06-21 Leo Liu <sdl.web@gmail.com>
577
578 * deps.mk (fns.o):
579 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
580 sha512.h.
581
582 * fns.c (secure_hash): Rename from crypto_hash_function and change
583 the first arg to accept symbols.
584 (Fsecure_hash): New primitive.
585 (syms_of_fns): New symbols.
586
587 2011-06-20 Deniz Dogan <deniz@dogan.se>
588
589 * process.c (Fset_process_buffer): Clarify return value in
590 docstring.
591
592 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
593
594 * dispnew.c (add_window_display_history): Use BVAR.
595
596 * xdisp.c (debug_method_add): Use BVAR.
597 (check_window_end, dump_glyph_matrix, dump_glyph)
598 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
599
600 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
601 Likewise.
602
603 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
604 check till after the cache is created in init_frame_faces.
605
606 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
607
608 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
609
610 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
611
612 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
613 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
614 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
615
616 Improve buffer-overflow checking (Bug#8873).
617 * fileio.c (Finsert_file_contents):
618 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
619 Remove the old (too-loose) buffer overflow checks.
620 They weren't needed, since make_gap checks for buffer overflow.
621 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
622 The old code merely checked for Emacs fixnum overflow, and relied
623 on undefined (wraparound) behavior. The new code avoids undefined
624 behavior, and also checks for ptrdiff_t and/or size_t overflow.
625
626 * editfns.c (Finsert_char): Don't dump core with very negative counts.
627 Tune. Don't use wider integers than needed. Don't use alloca.
628 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
629
630 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
631
632 * insdel.c, lisp.h (buffer_overflow): New function.
633 (insert_from_buffer_1, replace_range, replace_range_2):
634 * insdel.c (make_gap_larger):
635 * editfns.c (Finsert_char):
636 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
637
638 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
639
640 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
641
642 Integer overflow and signedness fixes (Bug#8873).
643
644 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
645 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
646
647 * fileio.c: Don't assume EMACS_INT fits in off_t.
648 (emacs_lseek): New static function.
649 (Finsert_file_contents, Fwrite_region): Use it.
650 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
651
652 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
653
654 * fns.c: Don't overflow int when computing a list length.
655 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
656 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
657 truncation on 64-bit hosts. Check for QUIT every
658 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
659 faster and is responsive enough.
660 (Flength): Report an error instead of overflowing an integer.
661 (Fsafe_length): Return a float if the value is not representable
662 as a fixnum. This shouldn't happen except in contrived situations.
663 (Fnthcdr, Fsort): Don't assume list length fits in int.
664 (Fcopy_sequence): Don't assume vector length fits in int.
665
666 * alloc.c: Check that resized vectors' lengths fit in fixnums.
667 (header_size, word_size): New constants.
668 (allocate_vectorlike): Don't check size overflow here.
669 (allocate_vector): Check it here instead, since this is the only
670 caller of allocate_vectorlike that could cause overflow.
671 Check that the new vector's length is representable as a fixnum.
672
673 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
674 The previous code was bogus. For example, next_almost_prime (32)
675 returned 39, which is undesirable as it is a multiple of 3; and
676 next_almost_prime (24) returned 25, which is a multiple of 5 so
677 why was the code bothering to check for multiples of 7?
678
679 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
680
681 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
682
683 Variadic C functions now count arguments with ptrdiff_t.
684 This partly undoes my 2011-03-30 change, which replaced int with size_t.
685 Back then I didn't know that the Emacs coding style prefers signed int.
686 Also, in the meantime I found a few more instances where arguments
687 were being counted with int, which may truncate counts on 64-bit
688 machines, or EMACS_INT, which may be unnecessarily wide.
689 * lisp.h (struct Lisp_Subr.function.aMANY)
690 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
691 Arg counts are now ptrdiff_t, not size_t.
692 All variadic functions and their callers changed accordingly.
693 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
694 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
695 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
696 * callint.c (Fcall_interactively): Check arg count for overflow,
697 to avoid potential buffer overrun. Use signed char, not 'int',
698 for 'varies' array, so that we needn't bother to check its size
699 calculation for overflow.
700 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
701 * eval.c (apply_lambda):
702 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
703 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
704 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
705
706 * callint.c (Fcall_interactively): Don't use index var as event count.
707
708 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
709 * mem-limits.h (SIZE): Remove; no longer used.
710
711 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
712
713 Remove unnecessary casts.
714 * xterm.c (x_term_init):
715 * xfns.c (x_set_border_pixel):
716 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
717 These aren't needed now that we assume ANSI C.
718
719 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
720 It's more likely to cause problems (due to unsigned overflow)
721 than to cure them.
722
723 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
724
725 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
726
727 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
728
729 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
730
731 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
732
733 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
734
735 GLYPH_CODE_FACE returns EMACS_INT, not int.
736 * dispextern.h (merge_faces):
737 * xfaces.c (merge_faces):
738 * xdisp.c (get_next_display_element, next_element_from_display_vector):
739 Don't assume EMACS_INT fits in int.
740
741 * character.h (CHAR_VALID_P): Remove unused parameter.
742 * fontset.c, lisp.h, xdisp.c: All uses changed.
743
744 * editfns.c (Ftranslate_region_internal): Omit redundant test.
745
746 * fns.c (concat): Minor tuning based on overflow analysis.
747 This doesn't fix any bugs. Use int to hold character, instead
748 of constantly refetching from Emacs object. Use XFASTINT, not
749 XINT, for value known to be a character. Don't bother comparing
750 a single byte to 0400, as it's always less.
751
752 * floatfns.c (Fexpt):
753 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
754
755 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
756 for characters.
757
758 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
759
760 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
761 Without this fix, on a 64-bit host (aset S 0 4294967386) would
762 incorrectly succeed when S was a string, because 4294967386 was
763 truncated before it was used.
764
765 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
766 Otherwise, an out-of-range integer could cause undefined behavior
767 on a 64-bit host.
768
769 * composite.c: Use int, not EMACS_INT, for characters.
770 (fill_gstring_body, composition_compute_stop_pos): Use int, not
771 EMACS_INT, for values that are known to be in character range.
772 This doesn't fix any bugs but is the usual style inside Emacs and
773 may generate better code on 32-bit machines.
774
775 Make sure a 64-bit char is never passed to ENCODE_CHAR.
776 This is for reasons similar to the recent CHAR_STRING fix.
777 * charset.c (Fencode_char): Check that character arg is actually
778 a character. Pass an int to ENCODE_CHAR.
779 * charset.h (ENCODE_CHAR): Verify that the character argument is no
780 wider than 'int', as a compile-time check to prevent future regressions
781 in this area.
782
783 * character.c (char_string): Remove unnecessary casts.
784
785 Make sure a 64-bit char is never passed to CHAR_STRING.
786 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
787 by silently ignoring the top 32 bits, allowing some values
788 that were far too large to be valid characters.
789 * character.h: Include <verify.h>.
790 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
791 arguments are no wider than unsigned, as a compile-time check
792 to prevent future regressions in this area.
793 * data.c (Faset):
794 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
795 (Fsubst_char_in_region):
796 * fns.c (concat):
797 * xdisp.c (decode_mode_spec_coding):
798 Adjust to CHAR_STRING's new requirement.
799 * editfns.c (Finsert_char, Fsubst_char_in_region):
800 * fns.c (concat): Check that character args are actually
801 characters. Without this test, these functions did the wrong
802 thing with wildly out-of-range values on 64-bit hosts.
803
804 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
805 These casts should not be needed on 32-bit hosts, either.
806 * keyboard.c (read_char):
807 * lread.c (Fload): Remove casts to unsigned.
808
809 * lisp.h (UNSIGNED_CMP): New macro.
810 This fixes comparison bugs on 64-bit hosts.
811 (ASCII_CHAR_P): Use it.
812 * casefiddle.c (casify_object):
813 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
814 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
815 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
816 * dispextern.h (FACE_FROM_ID):
817 * keyboard.c (read_char): Use UNSIGNED_CMP.
818
819 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
820 not to EMACS_INT, to avoid GCC warning.
821
822 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
823
824 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
825 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
826 isn't needed on 32-bit machines.
827
828 * buffer.c (Fgenerate_new_buffer_name):
829 Use EMACS_INT for count, not int.
830 (advance_to_char_boundary): Return EMACS_INT, not int.
831
832 * data.c (Qcompiled_function): Now static.
833
834 * window.c (window_body_lines): Now static.
835
836 * image.c (gif_load): Rename local to avoid shadowing.
837
838 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
839 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
840 * alloc.c (make_save_value): Integer argument is now of type
841 ptrdiff_t, not int.
842 (mark_object): Use ptrdiff_t, not int.
843 * lisp.h (pD): New macro.
844 * print.c (print_object): Use it.
845
846 * alloc.c: Use EMACS_INT, not int, to count objects.
847 (total_conses, total_markers, total_symbols, total_vector_size)
848 (total_free_conses, total_free_markers, total_free_symbols)
849 (total_free_floats, total_floats, total_free_intervals)
850 (total_intervals, total_strings, total_free_strings):
851 Now EMACS_INT, not int. All uses changed.
852 (Fgarbage_collect): Compute overall total using a double, so that
853 integer overflow is less likely to be a problem. Check for overflow
854 when converting back to an integer.
855 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
856 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
857 These were 'int' variables that could overflow on 64-bit hosts;
858 they were never used, so remove them instead of repairing them.
859 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
860 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
861 Previously, this ceilinged at INT_MAX, but that doesn't work on
862 64-bit machines.
863 (allocate_pseudovector): Don't use EMACS_INT when int would do.
864
865 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
866 (allocate_vectorlike): Check for ptrdiff_t overflow.
867 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
868 when a (possibly-narrower) signed value would do just as well.
869 We prefer using signed arithmetic, to avoid comparison confusion.
870
871 * alloc.c: Catch some string size overflows that we were missing.
872 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
873 for convenience in STRING_BYTES_MAX.
874 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
875 The definition here is exact; the one in lisp.h was approximate.
876 (allocate_string_data): Check for string overflow. This catches
877 some instances we weren't catching before. Also, it catches
878 size_t overflow on (unusual) hosts where SIZE_MAX <= min
879 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
880 and ptrdiff_t and EMACS_INT are both 64 bits.
881
882 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
883 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
884 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
885
886 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
887
888 * alloc.c (Fmake_string): Check for out-of-range init.
889
890 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
891
892 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
893
894 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
895
896 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
897 xg_get_default_scrollbar_width.
898
899 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
900 (int_gtk_range_get_value): Move to the scroll bar part of the file.
901 (style_changed_cb): Call update_theme_scrollbar_width and call
902 x_set_scroll_bar_default_width and xg_frame_set_char_size for
903 all frames (Bug#8505).
904 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
905 Call gtk_window_set_resizable if HAVE_GTK3.
906 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
907 and height if HAVE_GTK3 (Bug#8505).
908 (scroll_bar_width_for_theme): New variable.
909 (update_theme_scrollbar_width): New function.
910 (xg_get_default_scrollbar_width): Move code to
911 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
912 (xg_initialize): Call update_theme_scrollbar_width.
913
914 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
915
916 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
917
918 2011-06-12 Martin Rudalics <rudalics@gmx.at>
919
920 * frame.c (make_frame): Call other_buffer_safely instead of
921 other_buffer.
922
923 * window.c (temp_output_buffer_show): Call display_buffer with
924 second argument Vtemp_buffer_show_specifiers and reset latter
925 immediately after the call.
926 (Vtemp_buffer_show_specifiers): New variable.
927 (auto_window_vscroll_p, next_screen_context_lines)
928 (Vscroll_preserve_screen_position): Remove leading asterisks from
929 doc-strings.
930
931 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
932
933 Fix minor problems found by GCC 4.6.0 static checking.
934 * buffer.c (Qclone_number): Remove for now, as it's unused.
935 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
936 (record_buffer): Remove unused local.
937 * frame.c (other_visible_frames, frame_buffer_list): Now static.
938 (set_frame_buffer_list): Remove; unused.
939 * frame.h (other_visible_frames): Remove decl.
940 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
941 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
942 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
943 if HAVE_GPM.
944 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
945 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
946 Define only if HAVE_GPM.
947 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
948 (update_hints_inhibit): Remove; never set. All uses removed.
949 * widgetprv.h (emacsFrameClassRec): Remove decl.
950 * window.c (delete_deletable_window): Now returns void, since it
951 wasn't returning anything.
952 (compare_window_configurations): Remove unused locals.
953 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
954 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
955 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
956 the same widths as pointers. This follows up on the 2011-05-06 patch.
957 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
958 * xterm.h: Likewise.
959 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
960
961 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
962
963 * makefile.w32-in: Update dependencies.
964 (LISP_H): Add lib/intprops.h.
965
966 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
967
968 * image.c (gif_load): Add animation frame delay to the metadata.
969 (syms_of_image): Use DEFSYM. New symbol `delay'.
970
971 2011-06-11 Martin Rudalics <rudalics@gmx.at>
972
973 * window.c (delete_deletable_window): Re-add.
974 (Fset_window_configuration): Rewrite to handle dead buffers and
975 consequently deletable windows.
976 (window_tree, Fwindow_tree): Remove. Supply functionality in
977 window.el.
978 (compare_window_configurations): Simplify code.
979
980 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
981
982 * image.c (imagemagick_load_image): Fix type mismatch.
983 (Fimagemagick_types): Likewise.
984
985 * window.h (replace_buffer_in_windows): Declare.
986
987 2011-06-11 Martin Rudalics <rudalics@gmx.at>
988
989 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
990 Qclone_number. Remove external declaration of Qdelete_window.
991 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
992 code.
993 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
994 Qbuffer_list_update_hook if allowed.
995 (Fother_buffer): Rewrite doc-string. Major rewrite for new
996 buffer list implementation.
997 (other_buffer_safely): New function.
998 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
999 calls to replace_buffer_in_windows and
1000 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1001 if allowed.
1002 (record_buffer): Inhibit quitting and rewrite using quittable
1003 functions. Run Qbuffer_list_update_hook if allowed.
1004 (Frecord_buffer, Funrecord_buffer): New functions.
1005 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1006 switch-to-buffer to window.el.
1007 (bury-buffer): Move to window.el.
1008 (Vbuffer_list_update_hook): New variable.
1009
1010 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1011 section.
1012
1013 * window.h (resize_frame_windows): Move up in code.
1014 (Fwindow_frame): Remove EXFUN.
1015 (replace_buffer_in_all_windows): Remove prototype.
1016 (replace_buffer_in_windows_safely): Add prototype.
1017
1018 * window.c: Declare Qdelete_window static again. Move down
1019 declaration of select_count.
1020 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1021 (Fother_window): Move to window.el.
1022 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1023 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1024 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1025 window.el.
1026 (replace_buffer_in_windows): Implement by calling
1027 Qreplace_buffer_in_windows.
1028 (replace_buffer_in_all_windows): Remove with some functionality
1029 moved into replace_buffer_in_windows_safely.
1030 (replace_buffer_in_windows_safely): New function.
1031 (select_window_norecord, select_frame_norecord): Move in front
1032 of run_window_configuration_change_hook. Remove now obsolete
1033 declarations.
1034 (Fset_window_buffer): Rewrite doc-string. Call
1035 Qrecord_window_buffer.
1036 (keys_of_window): Move binding for other-window to window.el.
1037
1038 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1039
1040 * dispextern.h (struct image): Replace data member, whose int_val
1041 and ptr_val fields were not used by anything, with a single
1042 lisp_val object.
1043
1044 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1045 (gif_clear_image, gif_load, imagemagick_load_image)
1046 (gs_clear_image, gs_load): Callers changed.
1047
1048 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1049
1050 * buffer.h: Include <time.h>, for time_t.
1051 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1052
1053 Fix minor problems found by static checking.
1054
1055 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1056
1057 Make identifiers static if they are not used in other modules.
1058 * data.c (Qcompiled_function, Qframe, Qvector):
1059 * image.c (QimageMagick, Qsvg):
1060 * minibuf.c (Qmetadata):
1061 * window.c (resize_window_check, resize_root_window): Now static.
1062 * window.h (resize_window_check, resize_root_window): Remove decls.
1063
1064 * window.c (window_deletion_count, delete_deletable_window):
1065 Remove; unused.
1066 (window_body_lines): Now static.
1067 (Fdelete_other_windows_internal): Mark vars as initialized.
1068 Make sure 'resize_failed' is initialized.
1069 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1070 (resize_window_apply): Remove unused local.
1071 * window.h (delete_deletable_window): Remove decl.
1072
1073 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
1074 (imagemagick_load_image): Fix pointer signedness problem by changing
1075 last arg from unsigned char * to char *. All uses changed.
1076 Also, fix a local for similar reasons.
1077 Remove unused locals. Remove locals to avoid shadowing.
1078 (fn_rsvg_handle_free): Remove; unused.
1079 (svg_load, svg_load_image): Fix pointer signedness problem.
1080 (imagemagick_load_image): Don't use garbage pointer image_wand.
1081
1082 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1083
1084 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
1085
1086 * image.c (gif_load): Fix omitted cast error introduced by
1087 2011-06-06 change.
1088
1089 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1090
1091 * window.h (resize_proportionally, orig_total_lines)
1092 (orig_top_line): Remove from window structure.
1093 (set_window_height, set_window_width, change_window_heights)
1094 (Fdelete_window): Remove prototypes.
1095 (resize_frame_windows): Remove duplicate declaration.
1096
1097 2011-06-10 Eli Zaretskii <eliz@gnu.org>
1098
1099 * window.h (resize_frame_windows, resize_window_check)
1100 (delete_deletable_window, resize_root_window)
1101 (resize_frame_windows): Declare prototypes.
1102
1103 * window.c (resize_window_apply): Make definition be "static" to
1104 match the prototype.
1105
1106 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1107
1108 * window.c: Remove declarations of Qwindow_size_fixed,
1109 window_min_size_1, window_min_size_2, window_min_size,
1110 size_window, window_fixed_size_p, enlarge_window, delete_window.
1111 Remove static from declaration of Qdelete_window, it's
1112 temporarily needed by Fbury_buffer.
1113 (replace_window): Don't assign orig_top_line and
1114 orig_total_lines.
1115 (Fdelete_window, delete_window): Remove. Window deletion is
1116 handled by window.el.
1117 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1118 Fdelete_window calls with calls to Qdelete_window.
1119 (Fdelete_other_windows): Remove. Deleting other windows is
1120 handled by window.el.
1121 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1122 handled in window.el.
1123 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1124 Window minimum sizes are handled in window.el.
1125 (shrink_windows, size_window, set_window_height)
1126 (set_window_width, change_window_heights, window_height)
1127 (window_width, CURBEG, CURSIZE, enlarge_window)
1128 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1129 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1130 handled in window.el.
1131 (make_dummy_parent): Rename to make_parent_window and give it a
1132 second argument horflag.
1133 (make_window): Don't set resize_proportionally any more.
1134 (Fsplit_window): Remove. Windows are split in window.el.
1135 (save_restore_action, save_restore_orig_size)
1136 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1137 Resize mini windows in window.el.
1138 (grow_mini_window, shrink_mini_window): Implement by calling
1139 Qresize_root_window_vertically, resize_window_check and
1140 resize_window_apply.
1141 (saved_window, Fset_window_configuration, save_window_save): Do
1142 not handle orig_top_line, orig_total_lines, and
1143 resize_proportionally.
1144 (window_min_height, window_min_width): Move to window.el.
1145 (keys_of_window): Move bindings for delete-other-windows,
1146 split-window, delete-window and enlarge-window to window.el.
1147
1148 * buffer.c: Temporarily extern Qdelete_window.
1149 (Fbury_buffer): Temporarily call Qdelete_window instead of
1150 Fdelete_window (Fbury_buffer will move to window.el soon).
1151
1152 * frame.c (set_menu_bar_lines_1): Remove code handling
1153 orig_top_line and orig_total_lines.
1154
1155 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1156 set_window_height but set heights directly.
1157 (change_frame_size_1): Use resize_frame_windows.
1158
1159 * xdisp.c (init_xdisp): Don't use set_window_height but set
1160 heights directly.
1161
1162 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1163 resize_frame_windows instead of change_window_heights and run
1164 run_window_configuration_change_hook.
1165
1166 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1167 instead of change_window_heights and run
1168 run_window_configuration_change_hook.
1169
1170 2011-06-09 Martin Rudalics <rudalics@gmx.at>
1171
1172 * window.c (replace_window): Rename second argument REPLACEMENT to
1173 NEW. New third argument SETFLAG. Rewrite.
1174 (delete_window, make_dummy_parent): Call replace_window with
1175 third argument 1.
1176 (window_list_1): Move down in code.
1177 (run_window_configuration_change_hook): Move set_buffer part
1178 before select_frame_norecord part in order to unwind correctly.
1179 Rename count1 to count.
1180 (recombine_windows, delete_deletable_window, resize_root_window)
1181 (Fdelete_other_windows_internal)
1182 (Frun_window_configuration_change_hook, make_parent_window)
1183 (resize_window_check, resize_window_apply, Fresize_window_apply)
1184 (resize_frame_windows, Fsplit_window_internal)
1185 (Fdelete_window_internal, Fresize_mini_window_internal): New
1186 functions.
1187 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1188
1189 2011-06-08 Martin Rudalics <rudalics@gmx.at>
1190
1191 * window.h (window): Add some new members to window structure -
1192 normal_lines, normal_cols, new_total, new_normal, clone_number,
1193 splits, nest, prev_buffers, next_buffers.
1194 (WINDOW_TOTAL_SIZE): Move here from window.c.
1195 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1196
1197 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1198 Remove.
1199 (make_dummy_parent): Set new members of windows structure.
1200 (make_window): Move down in code. Handle new members of window
1201 structure.
1202 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1203 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1204 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1205 (Fset_window_prev_buffers, Fwindow_next_buffers)
1206 (Fset_window_next_buffers, Fset_window_clone_number): New
1207 functions.
1208 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1209 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1210 Doc-string fixes.
1211 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1212 Argument WINDOW can be now internal window too.
1213 (Fwindow_use_time): Move up in code.
1214 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1215 Rewrite doc-string.
1216 (Fset_window_configuration, saved_window)
1217 (Fcurrent_window_configuration, save_window_save): Handle new
1218 members of window structure.
1219 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1220 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1221 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1222 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1223 Qget_mru_window, Qresize_root_window,
1224 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1225 Qauto_buffer_name; staticpro them.
1226
1227 2011-06-07 Martin Rudalics <rudalics@gmx.at>
1228
1229 * window.c (Fwindow_total_size, Fwindow_left_column)
1230 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1231 (Fwindow_list_1): New functions.
1232 (window_box_text_cols): Replace with window_body_cols.
1233 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1234 window_body_cols instead of window_box_text_cols.
1235 (delete_window, Fset_window_configuration): Call
1236 delete_all_subwindows with window as argument.
1237 (delete_all_subwindows): Take a window as argument and not a
1238 structure. Rewrite.
1239 (window_loop): Remove handling of GET_LRU_WINDOW and
1240 GET_LARGEST_WINDOW.
1241 (Fget_lru_window, Fget_largest_window): Move to window.el.
1242
1243 * window.h: Extern window_body_cols instead of
1244 window_box_text_cols. delete_all_subwindows now takes a
1245 Lisp_Object as argument.
1246
1247 * indent.c (compute_motion, Fcompute_motion): Use
1248 window_body_cols instead of window_box_text_cols.
1249
1250 * frame.c (delete_frame): Call delete_all_subwindows with root
1251 window as argument.
1252
1253 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1254
1255 * fns.c (Fputhash): Document return value.
1256
1257 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
1258
1259 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1260
1261 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1262
1263 Cons<->int and similar integer overflow fixes (Bug#8794).
1264
1265 Check for overflow when converting integer to cons and back.
1266 * charset.c (Fdefine_charset_internal, Fdecode_char):
1267 Use cons_to_unsigned to catch overflow.
1268 (Fencode_char): Use INTEGER_TO_CONS.
1269 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1270 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1271 * data.c (long_to_cons, cons_to_long): Remove.
1272 (cons_to_unsigned, cons_to_signed): New functions.
1273 These signal an error for invalid or out-of-range values.
1274 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1275 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1276 * font.c (Ffont_variation_glyphs):
1277 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1278 * lisp.h: Include <intprops.h>.
1279 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1280 (cons_to_signed, cons_to_unsigned): New decls.
1281 (long_to_cons, cons_to_long): Remove decls.
1282 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1283 (Fprimitive_undo): Use CONS_TO_INTEGER.
1284 * xfns.c (Fx_window_property): Likewise.
1285 * xselect.c: Include <limits.h>.
1286 (x_own_selection, selection_data_to_lisp_data):
1287 Use INTEGER_TO_CONS.
1288 (x_handle_selection_request, x_handle_selection_clear)
1289 (x_get_foreign_selection, Fx_disown_selection_internal)
1290 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1291 (lisp_data_to_selection_data): Use cons_to_unsigned.
1292 (x_fill_property_data): Use cons_to_signed.
1293 Report values out of range.
1294
1295 Check for buffer and string overflow more precisely.
1296 * buffer.h (BUF_BYTES_MAX): New macro.
1297 * lisp.h (STRING_BYTES_MAX): New macro.
1298 * alloc.c (Fmake_string):
1299 * character.c (string_escape_byte8):
1300 * coding.c (coding_alloc_by_realloc):
1301 * doprnt.c (doprnt):
1302 * editfns.c (Fformat):
1303 * eval.c (verror):
1304 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1305 since they may not be the same number.
1306 * editfns.c (Finsert_char):
1307 * fileio.c (Finsert_file_contents):
1308 Likewise for BUF_BYTES_MAX.
1309
1310 * image.c: Use ptrdiff_t, not int, for sizes.
1311 (slurp_file): Switch from int to ptrdiff_t.
1312 All uses changed.
1313 (slurp_file): Check that file size fits in both size_t (for
1314 malloc) and ptrdiff_t (for sanity and safety).
1315
1316 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1317 if b->modtime has its maximal value.
1318
1319 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1320
1321 Don't assume time_t can fit into int.
1322 * buffer.h (struct buffer.modtime): Now time_t, not int.
1323 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1324 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1325
1326 Minor fixes for signed vs unsigned integers.
1327 * character.h (MAYBE_UNIFY_CHAR):
1328 * charset.c (maybe_unify_char):
1329 * keyboard.c (read_char, reorder_modifiers):
1330 XINT -> XFASTINT, since the integer must be nonnegative.
1331 * ftfont.c (ftfont_spec_pattern):
1332 * keymap.c (access_keymap, silly_event_symbol_error):
1333 XUINT -> XFASTINT, since the integer must be nonnegative.
1334 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1335 since it makes no difference and we prefer signed.
1336 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1337 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1338 nonnegative.
1339
1340 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1341
1342 * window.h (Fwindow_frame): Declare.
1343
1344 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1345
1346 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1347 (SPARE_MEMORY): Always define.
1348 (LARGE_REQUEST): Remove.
1349 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1350
1351 2011-06-06 Martin Rudalics <rudalics@gmx.at>
1352
1353 * lisp.h: Move EXFUNS for Fframe_root_window,
1354 Fframe_first_window and Fset_frame_selected_window to window.h.
1355
1356 * window.h: Move EXFUNS for Fframe_root_window,
1357 Fframe_first_window and Fset_frame_selected_window here from
1358 lisp.h.
1359
1360 * frame.c (Fwindow_frame, Fframe_first_window)
1361 (Fframe_root_window, Fframe_selected_window)
1362 (Fset_frame_selected_window): Move to window.c.
1363 (Factive_minibuffer_window): Move to minibuf.c.
1364 (Fother_visible_frames_p): New function.
1365
1366 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1367
1368 * window.c (decode_window, decode_any_window): Move up in code.
1369 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1370 (inhibit_frame_unsplittable): Remove unused variable.
1371 (Fwindow_buffer): Move up and rewrite doc-string.
1372 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1373 (Fwindow_prev): New functions.
1374 (Fwindow_frame): Move here from frame.c. Accept any window as
1375 argument.
1376 (Fframe_root_window, Fframe_first_window)
1377 (Fframe_selected_window): Move here from frame.c. Accept frame
1378 or arbitrary window as argument. Update doc-strings.
1379 (Fminibuffer_window): Move up in code.
1380 (Fwindow_minibuffer_p): Move up in code and simplify.
1381 (Fset_frame_selected_window): Move here from frame.c.
1382 Marginal rewrite.
1383 (Fselected_window, select_window, Fselect_window): Move up in
1384 code. Minor doc-string fixes.
1385
1386 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1387
1388 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1389 Do not assume that spare memory exists; that assumption is valid
1390 only if SYSTEM_MALLOC.
1391 (LARGE_REQUEST): New macro, so that the issue of large requests
1392 is separated from the issue of spare memory.
1393
1394 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1395
1396 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1397 format. (Bug#8806)
1398
1399 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1400
1401 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1402 before statements.
1403
1404 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1405
1406 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1407
1408 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1409
1410 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1411 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1412
1413 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
1414
1415 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1416
1417 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
1418
1419 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1420 (x_clipboard_manager_save): Add return value.
1421 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1422 New error handlers.
1423 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1424 Obey Vx_select_enable_clipboard_manager. Catch errors in
1425 x_clipboard_manager_save (Bug#8779).
1426 (Vx_select_enable_clipboard_manager): New variable.
1427 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
1428
1429 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
1430
1431 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1432
1433 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1434
1435 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1436 in the current matrix if keep_current_p is non-zero.
1437
1438 2011-06-04 Eli Zaretskii <eliz@gnu.org>
1439
1440 * bidi.c (bidi_level_of_next_char): Fix last change.
1441
1442 2011-06-03 Eli Zaretskii <eliz@gnu.org>
1443
1444 Support bidi reordering of text covered by display properties.
1445
1446 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1447 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1448 (bidi_cache_search, bidi_cache_iterator_state)
1449 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1450 (bidi_level_of_next_char, bidi_move_to_visually_next):
1451 Support character positions inside a run of characters covered by a
1452 display string.
1453 (bidi_paragraph_init, bidi_resolve_explicit_1)
1454 (bidi_level_of_next_char): Call bidi_fetch_char and
1455 bidi_fetch_char_advance instead of FETCH_CHAR and
1456 FETCH_CHAR_ADVANCE.
1457 (bidi_init_it): Initialize new members.
1458 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1459 definitions.
1460 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1461 instead of using explicit *_CHAR codes.
1462 (bidi_resolve_explicit, bidi_resolve_weak):
1463 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
1464 bidirectional text is supported only in multibyte buffers.
1465 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1466 it to initialize the frame_window_p member of struct bidi_it.
1467 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1468 (bidi_resolve_explicit, bidi_resolve_weak)
1469 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1470 bidi_it->nchars is non-positive.
1471 (bidi_level_of_next_char): Don't try to lookup the cache for the
1472 next/previous character if nothing is cached there yet, or if we
1473 were just reseat()'ed to a new position.
1474
1475 * xdisp.c (set_cursor_from_row): Set start and stop points
1476 according to the row's direction when priming the loop that looks
1477 for the glyph on which to display cursor.
1478 (single_display_spec_intangible_p): Function deleted.
1479 (display_prop_intangible_p): Reimplement to call
1480 handle_display_spec instead of single_display_spec_intangible_p.
1481 Accept 3 additional arguments needed by handle_display_spec.
1482 This fixes incorrect cursor motion across display property with complex
1483 values: lists, `(when COND...)' forms, etc.
1484 (single_display_spec_string_p): Support property values that are
1485 lists with the argument STRING its top-level element.
1486 (display_prop_string_p): Fix the condition for processing a
1487 property that is a list to be consistent with handle_display_spec.
1488 (handle_display_spec): New function, refactored from the
1489 last portion of handle_display_prop.
1490 (compute_display_string_pos): Accept additional argument
1491 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1492 value of a `display' property is a "replacing spec".
1493 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1494 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1495 the display property, but just return a value indicating whether
1496 the display property will replace the characters it covers.
1497 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1498 frame_window_p members of struct bidi_it.
1499 (compute_display_string_pos, compute_display_string_end):
1500 New functions.
1501 (push_it): Accept second argument POSITION, where pop_it should
1502 jump to continue iteration.
1503 (reseat_1): Initialize bidi_it.disp_pos.
1504
1505 * keyboard.c (adjust_point_for_property): Adjust the call to
1506 display_prop_intangible_p to its new signature.
1507
1508 * dispextern.h (struct bidi_it): New member frame_window_p.
1509 (bidi_init_it): Update prototypes.
1510 (display_prop_intangible_p): Update prototype.
1511 (compute_display_string_pos, compute_display_string_end):
1512 Declare prototypes.
1513 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1514 EMACS_INT.
1515
1516 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1517
1518 Malloc failure behavior now depends on size of allocation.
1519 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1520 * lisp.h: Change signatures accordingly.
1521 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1522 All callers changed. (Bug#8762)
1523
1524 * gnutls.c: Use Emacs's memory allocators.
1525 Without this change, the gnutls library would invoke malloc etc.
1526 directly, which causes problems on non-SYNC_INPUT hosts, and which
1527 runs afoul of improving memory_full behavior. (Bug#8761)
1528 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1529 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1530 xfree instead of the default malloc, realloc, free.
1531 (Fgnutls_boot): No need to check for memory allocation failure,
1532 since xmalloc does that for us.
1533
1534 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1535 * category.c (hash_get_category_set):
1536 * ccl.c (ccl_driver):
1537 * charset.c (Fdefine_charset_internal):
1538 * charset.h (struct charset.hash_index):
1539 * composite.c (get_composition_id, gstring_lookup_cache)
1540 (composition_gstring_put_cache):
1541 * composite.h (struct composition.hash_index):
1542 * dispextern.h (struct image.hash):
1543 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1544 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1545 (hashfn_equal, hashfn_user_defined, make_hash_table)
1546 (maybe_resize_hash_table, hash_lookup, hash_put)
1547 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1548 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1549 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1550 * image.c (make_image, search_image_cache, lookup_image)
1551 (xpm_put_color_table_h):
1552 * lisp.h (struct Lisp_Hash_Table):
1553 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1554 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1555 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1556 * alloc.c (allocate_vectorlike):
1557 Check for overflow in vector size calculations.
1558 * ccl.c (ccl_driver):
1559 Check for overflow when converting EMACS_INT to int.
1560 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1561 need to be updated by these changes.
1562 * fns.c (make_hash_table, maybe_resize_hash_table):
1563 Check for integer overflow with large hash tables.
1564 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1565 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1566 (SXHASH_REDUCE): New macro.
1567 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1568 Use it instead of discarding useful hash info with large hash values.
1569 (sxhash_float): New function.
1570 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1571 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1572 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1573 Rewrite to use FIXNUM_BITS, as this simplifies things.
1574 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1575 Adjust signatures to match updated version of code.
1576 (consing_since_gc): Now EMACS_INT, since a single hash table can
1577 use more than INT_MAX bytes.
1578
1579 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1580
1581 Make it possible to build with GCC-4.6+ -O2 -flto.
1582
1583 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1584
1585 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1586
1587 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1588 Call minibuffer-inactive-mode.
1589
1590 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1591
1592 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1593 Update dependencies.
1594
1595 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1596
1597 * data.c (init_data): Remove code for UTS, this system is not
1598 supported anymore.
1599
1600 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1601
1602 Don't force ./temacs to start in terminal mode.
1603
1604 * frame.c (make_initial_frame): Initialize faces in all cases, not
1605 only when CANNOT_DUMP is defined.
1606 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1607
1608 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1609
1610 * dispnew.c (add_window_display_history): Use const for the string
1611 pointer. Remove declaration, not needed.
1612
1613 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1614
1615 Use 'inline', not 'INLINE'.
1616 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1617 * alloc.c, fontset.c (INLINE): Remove.
1618 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1619 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1620 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1621 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1622 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1623
1624 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1625
1626 Make it possible to run ./temacs.
1627
1628 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1629 syms_of_callproc does the same thing. Remove test for
1630 "initialized", do it in the caller.
1631 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1632
1633 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1634
1635 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1636 (read_minibuf): Use get_minibuffer.
1637 (syms_of_minibuf): Use DEFSYM.
1638 (Qmetadata): New var.
1639 * data.c (Qbuffer): Don't make it static.
1640 (syms_of_data): Use DEFSYM.
1641
1642 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1643
1644 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1645 (CCL_CODE_MIN): New macro.
1646
1647 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1648
1649 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1650
1651 * eval.c (Qdebug): Now static.
1652 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1653 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1654 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1655
1656 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1657
1658 * image.c: Various fixes to ImageMagick code comments.
1659 (Fimagemagick_types): Doc fix.
1660
1661 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1662
1663 Minor fixes prompted by GCC 4.6.0 warnings.
1664
1665 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1666
1667 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1668 (x_clipboard_manager_save_all): Move extern decl to ...
1669 * xterm.h: ... here, so that it can be checked for consistency.
1670
1671 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1672
1673 * xselect.c (x_clipboard_manager_save_frame)
1674 (x_clipboard_manager_save_all): New functions.
1675 (Fx_clipboard_manager_save): Lisp function deleted.
1676
1677 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1678 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1679
1680 * xterm.h: Update prototype.
1681
1682 2011-05-28 William Xu <william.xwl@gmail.com>
1683
1684 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1685 exiting (Bug#8239).
1686
1687 2011-05-28 Jim Meyering <meyering@redhat.com>
1688
1689 Avoid a sign-extension bug in crypto_hash_function.
1690 * fns.c (to_uchar): Define.
1691 (crypto_hash_function): Use it to convert some newly-signed
1692 variables to unsigned, to avoid sign-extension bugs. For example,
1693 without this change, (md5 "truc") would evaluate to
1694 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1695 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1696 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1697
1698 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1699
1700 Integer overflow fixes.
1701
1702 * dbusbind.c: Serial number integer overflow fixes.
1703 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1704 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1705 to hold a serial number that is too large for a fixnum.
1706 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1707 Check for serial numbers out of range. Decode any serial number
1708 that was so large that it became a float. (Bug#8722)
1709
1710 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1711 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1712 Use XFASTINT rather than XUINT when numbers are nonnegative.
1713 (xd_append_arg, Fdbus_method_return_internal):
1714 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1715 arguments, check that Lisp number is nonnegative, rather than
1716 silently wrapping negative numbers around. (Bug#8722)
1717 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1718 (Bug#8722)
1719
1720 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1721
1722 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1723
1724 ccl: add integer overflow checks
1725 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1726 (IN_INT_RANGE): New macros.
1727 (ccl_driver): Use them to check for integer overflow when
1728 decoding a CCL program. Many of the new checks are whether XINT (x)
1729 fits in int; it doesn't always, on 64-bit hosts. The new version
1730 doesn't catch all possible integer overflows, but it's an
1731 improvement. (Bug#8719)
1732
1733 * alloc.c (make_event_array): Use XINT, not XUINT.
1734 There's no need for unsigned here.
1735
1736 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1737 This follows up to the 2011-05-06 change that substituted uintptr_t
1738 for EMACS_INT. This case wasn't caught back then.
1739
1740 Rework Fformat to avoid integer overflow issues.
1741 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1742 now (part of C89). Include <verify.h>.
1743 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1744 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1745 (Fformat): Avoid the prepass trying to compute sizes; it was only
1746 approximate and thus did not catch overflow reliably. Instead, walk
1747 through the format just once, formatting and computing sizes as we go,
1748 checking for integer overflow at every step, and allocating a larger
1749 buffer as needed. Keep track separately whether the format is
1750 multibyte. Keep only the most-recently calculated precision, rather
1751 than them all. Record whether each argument has been converted to
1752 string. Use EMACS_INT, not int, for byte and char and arg counts.
1753 Support field widths and precisions larger than INT_MAX. Avoid
1754 sprintf's undefined behavior with conversion specifications such as %#d
1755 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1756 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1757 formatting out-of-range floating point numbers with int
1758 formats. (Bug#8668)
1759
1760 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1761
1762 * data.c: Avoid integer truncation in expressions involving floats.
1763 * data.c: Include <intprops.h>.
1764 (arith_driver): When there's an integer overflow in an expression
1765 involving floating point, convert the integers to floating point
1766 so that the resulting value does not suffer from catastrophic
1767 integer truncation. For example, on a 64-bit host (* 4
1768 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1769 Do not rely on undefined behavior after integer overflow.
1770
1771 merge count_size_as_multibyte, parse_str_to_multibyte
1772 * character.c, character.h (count_size_as_multibyte):
1773 Rename from parse_str_to_multibyte; all uses changed.
1774 Check for integer overflow.
1775 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1776 since it's now a duplicate of the other. This is more of
1777 a character than a buffer op, so better that it's in character.c.
1778 * fns.c, print.c: Adjust to above changes.
1779
1780 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1781
1782 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1783
1784 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1785
1786 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1787 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1788 (x_clipboard_manager_save): Now static.
1789 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1790
1791 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1792 (crypto_hash_function): Now static.
1793 Fix pointer signedness problems. Avoid unnecessary initializations.
1794
1795 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1796
1797 * termhooks.h (Vselection_alist): Make it terminal-local.
1798
1799 * terminal.c (create_terminal): Initialize it.
1800
1801 * xselect.c: Support for clipboard managers.
1802 (Vselection_alist): Move to termhooks.h as terminal-local var.
1803 (LOCAL_SELECTION): New macro.
1804 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1805 (symbol_to_x_atom): Remove gratuitous arg.
1806 (x_handle_selection_request, lisp_data_to_selection_data)
1807 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1808 (x_own_selection, x_get_local_selection, x_convert_selection):
1809 New arg, specifying work frame. Use terminal-local Vselection_alist.
1810 (some_frame_on_display): Delete unused function.
1811 (Fx_own_selection_internal, Fx_get_selection_internal)
1812 (Fx_disown_selection_internal, Fx_selection_owner_p)
1813 (Fx_selection_exists_p): New optional frame arg.
1814 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1815 (x_handle_selection_clear): Don't treat other terminals with the
1816 same keyboard specially. Use the terminal-local Vselection_alist.
1817 (x_clear_frame_selections): Use Frun_hook_with_args.
1818
1819 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1820
1821 * xterm.h: Add support for those atoms.
1822
1823 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1824
1825 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1826 (converted_selections, conversion_fail_tag): New global variables.
1827 (x_selection_request_lisp_error): Free the above.
1828 (x_get_local_selection): Remove unnecessary code.
1829 (x_reply_selection_request): Args changed; handle arbitrary array
1830 of converted selections stored in converted_selections.
1831 Separate the XChangeProperty and SelectionNotify steps.
1832 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1833 (x_convert_selection): New function.
1834 (x_handle_selection_event): Simplify.
1835 (x_get_foreign_selection): Don't ignore incoming requests while
1836 waiting for an answer; this will fail when we implement
1837 SAVE_TARGETS, and seems unnecessary anyway.
1838 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1839 (Vx_sent_selection_functions): Doc fix.
1840
1841 2011-05-26 Leo Liu <sdl.web@gmail.com>
1842
1843 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1844
1845 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1846
1847 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1848
1849 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1850 for fringe update if it has periodic bitmap.
1851 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1852 and fringe_bitmap_periodic_p.
1853
1854 * fringe.c (get_fringe_bitmap_data): New function.
1855 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1856 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1857 row. Mark glyph row for fringe update if periodicity changed.
1858
1859 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1860 for fringe update unless it has periodic bitmap.
1861
1862 2011-05-25 Kenichi Handa <handa@m17n.org>
1863
1864 * xdisp.c (get_next_display_element): Set correct it->face_id for
1865 a static composition.
1866
1867 2011-05-24 Leo Liu <sdl.web@gmail.com>
1868
1869 * deps.mk (fns.o):
1870 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1871
1872 * fns.c (crypto_hash_function, Fsha1): New function.
1873 (Fmd5): Use crypto_hash_function.
1874 (syms_of_fns): Add Ssha1.
1875
1876 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1877
1878 * gnutls.c: Remove unused macros.
1879 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1880 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1881 Remove macros that are defined and never used.
1882 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1883
1884 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1885
1886 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1887 (Fx_get_selection_internal): Minor cleanup.
1888 (Fx_own_selection_internal): Rename arguments for consistency with
1889 select.el.
1890
1891 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1892
1893 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1894
1895 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1896
1897 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1898
1899 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1900
1901 * dispnew.c (scrolling_window): Don't exclude the case that the
1902 last enabled row in the desired matrix touches the bottom boundary.
1903
1904 2011-05-21 Glenn Morris <rgm@gnu.org>
1905
1906 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1907 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1908 and add some more files.
1909
1910 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1911
1912 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1913 report_file_error introduced by the change from 2011-05-07.
1914
1915 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1916
1917 * systime.h (Time): Define only if emacs is defined.
1918 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1919 where the include path doesn't have X11/X.h by default. See
1920 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1921
1922 2011-05-20 Kenichi Handa <handa@m17n.org>
1923
1924 * composite.c (find_automatic_composition): Fix previous change.
1925
1926 2011-05-20 Glenn Morris <rgm@gnu.org>
1927
1928 * lisp.mk: New file, split from Makefile.in.
1929 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1930 (shortlisp): Remove.
1931 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1932
1933 2011-05-19 Glenn Morris <rgm@gnu.org>
1934
1935 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1936 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1937 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1938 (lisp): Set the order to that of loadup.el.
1939 (shortlisp): Make it a copy of $lisp.
1940 (SOME_MACHINE_LISP): Remove.
1941 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1942 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1943
1944 2011-05-18 Kenichi Handa <handa@m17n.org>
1945
1946 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1947 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1948 (find_automatic_composition): Mostly rewrite for efficiency.
1949
1950 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1951
1952 * makefile.w32-in: Update dependencies.
1953
1954 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1955
1956 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1957 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
1958
1959 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1960
1961 Fix some integer overflow issues, such as string length overflow.
1962
1963 * insdel.c (count_size_as_multibyte): Check for string overflow.
1964
1965 * character.c (lisp_string_width): Check for string overflow.
1966 Use EMACS_INT, not int, for string indexes and lengths; in
1967 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1968 the resulting string length overflows an EMACS_INT; instead,
1969 report a string overflow if no precision given. When checking for
1970 precision exhaustion, use a check that cannot possibly have
1971 integer overflow. (Bug#8675)
1972 * character.h (lisp_string_width): Adjust to new signature.
1973
1974 * alloc.c (string_overflow): New function.
1975 (Fmake_string): Use it. This doesn't change behavior, but saves
1976 a few bytes and will simplify future changes.
1977 * character.c (string_escape_byte8): Likewise.
1978 * lisp.h (string_overflow): New decl.
1979
1980 Fixups, following up to the user-interface timestamp change.
1981 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1982 for UI timestamps, instead of unsigned long.
1983 * msdos.c (mouse_get_pos): Likewise.
1984 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1985 * w32gui.h (Time): Define by including "systime.h" rather than by
1986 declaring it ourselves. (Bug#8664)
1987
1988 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1989 * image.c (clear_image_cache): Likewise.
1990
1991 * term.c (term_mouse_position): Don't assume time_t wraparound.
1992
1993 Be more systematic about user-interface timestamps.
1994 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1995 and sometimes 'EMACS_UINT', to represent these timestamps.
1996 This change causes it to use 'Time' uniformly, as that's what X uses.
1997 This makes the code easier to follow, and makes it easier to catch
1998 integer overflow bugs such as Bug#8664.
1999 * frame.c (Fmouse_position, Fmouse_pixel_position):
2000 Use Time, not unsigned long, for user-interface timestamps.
2001 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2002 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2003 * keyboard.h (last_event_timestamp): Likewise.
2004 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2005 * menu.h (xmenu_show): Likewise.
2006 * term.c (term_mouse_position): Likewise.
2007 * termhooks.h (struct input_event.timestamp): Likewise.
2008 (struct terminal.mouse_position_hook): Likewise.
2009 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2010 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2011 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2012 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2013 what it was before.
2014 * menu.h, termhooks.h: Include "systime.h", for Time.
2015
2016 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2017 Don't assume that the difference between two unsigned long values
2018 can fit into an integer. At this point, we know button_down_time
2019 <= event->timestamp, so the difference must be nonnegative, so
2020 there's no need to cast the result if double-click-time is
2021 nonnegative, as it should be; check that it's nonnegative, just in
2022 case. This bug is triggered when events are more than 2**31 ms
2023 apart (about 25 days). (Bug#8664)
2024
2025 * xselect.c (last_event_timestamp): Remove duplicate decl.
2026 (x_own_selection): Remove needless cast to unsigned long.
2027
2028 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2029 that always fit in int. Use a sentinel instead of a counter, to
2030 avoid a temp and to allay GCC's concerns about possible int overflow.
2031 * frame.h (struct frame): Use int for menu_bar_items_used
2032 instead of EMACS_INT, since it always fits in int.
2033
2034 * menu.c (grow_menu_items): Check for int overflow.
2035
2036 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2037
2038 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2039 Before, the code was not consistent. These values cannot exceed
2040 2**31 - 1 so there's no need to make them unsigned.
2041 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2042 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2043 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2044 as modifiers.
2045 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2046
2047 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2048 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2049 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2050 presumably because the widths might not match.
2051
2052 * window.c (size_window): Avoid needless test at loop start.
2053
2054 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2055
2056 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2057
2058 2011-05-12 Drew Adams <drew.adams@oracle.com>
2059
2060 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2061
2062 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2063
2064 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2065 `width' to `bar_area_x' and `bar_area_width', respectively.
2066 (x_scroll_run): Take account of fringe background extension.
2067
2068 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2069 Rename local vars `left' and `width' to `bar_area_x' and
2070 `bar_area_width', respectively.
2071 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2072 background extension.
2073
2074 2011-05-10 Jim Meyering <meyering@redhat.com>
2075
2076 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2077
2078 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
2079
2080 * image.c (Finit_image_library): Return t for built-in image types,
2081 like pbm and xbm. (Bug#8640)
2082
2083 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2084
2085 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2086
2087 2011-05-07 Eli Zaretskii <eliz@gnu.org>
2088
2089 * w32console.c (Fset_screen_color): Doc fix.
2090 (Fget_screen_color): New function.
2091 (syms_of_ntterm): Defsubr it.
2092
2093 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2094 unlink the temporary file if Fcall_process didn't create it in the
2095 first place.
2096 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2097 child process will be redirected to a file specified with `:file'.
2098 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2099 cue to call_process_cleanup not to close that handle.
2100
2101 2011-05-07 Ben Key <bkey76@gmail.com>
2102
2103 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2104 one of two shell specific rules, either bootstrap-temacs-CMD or
2105 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2106 to the previous implementation of the bootstrap-temacs rule.
2107 The bootstrap-temacs-CMD rule is similar to the previous
2108 implementation of the bootstrap-temacs rule except that it
2109 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2110 variable.
2111
2112 These changes, along with some changes to nt/configure.bat,
2113 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2114 earlier fix to add support for --cflags and --ldflags options
2115 that include quotes so that it works whether make uses cmd or
2116 sh as the shell.
2117
2118 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
2119
2120 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2121 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2122 is a constant.
2123 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2124 a string. Handle both cases.
2125 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2126 (Fdbus_register_method): Use Qinvalid_function.
2127
2128 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2129
2130 * makefile.w32-in: Update dependencies.
2131 (LISP_H): Add inttypes.h and stdin.h.
2132 (PROCESS_H): Add unistd.h.
2133
2134 2011-05-06 Eli Zaretskii <eliz@gnu.org>
2135
2136 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2137 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2138
2139 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
2140
2141 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2142
2143 * term.c (vfatal): Remove stray call to va_end.
2144 It's not needed and the C Standard doesn't allow it here anyway.
2145
2146 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2147 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2148
2149 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2150 bytes.
2151
2152 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2153
2154 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2155
2156 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2157
2158 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2159
2160 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2161
2162 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2163 * charset.c (Fdefine_charset_internal): Don't initialize
2164 charset.code_space[15]. The value was garbage, on hosts with
2165 32-bit int (Bug#8600).
2166
2167 * lread.c (read_integer): Be more consistent with string-to-number.
2168 Use string_to_number to do the actual conversion; this avoids
2169 rounding errors and fixes some other screwups. Without this fix,
2170 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2171 (digit_to_number): Move earlier, for benefit of read_integer.
2172 Return -1 if the digit is out of range for the base, -2 if it is
2173 not a digit in any supported base. (Bug#8602)
2174
2175 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2176
2177 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2178 to match comment at start of function. This also removes a
2179 GCC warning about overflow in a 32+64-bit port.
2180
2181 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2182
2183 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2184 Reported by Stefan Monnier in
2185 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2186 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2187 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2188
2189 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2190 (EMACS_UINTPTR): Likewise, with uintptr_t.
2191
2192 * lisp.h: Prefer 64-bit EMACS_INT if available.
2193 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2194 on 32-bit hosts that have 64-bit int, so that they can access
2195 large files.
2196 However, temporarily disable this change unless the temporary
2197 symbol WIDE_EMACS_INT is defined.
2198
2199 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2200
2201 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2202 This removes an assumption that EMACS_INT and long are the same
2203 width as pointers. The assumption is true for Emacs porting targets
2204 now, but we want to make other targets possible.
2205 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2206 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2207 In the rest of the code, change types of integers that hold casted
2208 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2209 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2210 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2211 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2212 No need to cast type when ORing.
2213 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2214 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2215 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2216 assume EMACS_INT is the same width as char *.
2217 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2218 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2219 Remove no-longer-needed casts.
2220 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2221 (xg_tool_bar_help_callback, xg_make_tool_item):
2222 Use EMACS_INTPTR to hold an integer
2223 that will be cast to void *; this can avoid a GCC warning
2224 if EMACS_INT is not the same width as void *.
2225 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2226 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2227 (current_message_1, set_message_1):
2228 Use a local to convert to proper width without a cast.
2229 * xmenu.c (dialog_selection_callback): Likewise.
2230
2231 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2232 Also, don't assume VALBITS / RAND_BITS is less than 5,
2233 and don't rely on undefined behavior when shifting a 1 left into
2234 the sign bit.
2235 * lisp.h (get_random): Change signature to match.
2236
2237 * lread.c (hash_string): Use size_t, not int, for hash computation.
2238 Normally we prefer signed values; but hashing is special, because
2239 it's better to use unsigned division on hash table sizes so that
2240 the remainder is nonnegative. Also, size_t is the natural width
2241 for hashing into memory. The previous code used 'int', which doesn't
2242 retain enough info to hash well into very large tables.
2243 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2244
2245 * dbusbind.c: Don't possibly lose pointer info when converting.
2246 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2247 Use XPNTR rather than XHASH, so that the high-order bits of
2248 the pointer aren't lost when converting through void *.
2249
2250 * eval.c (Fautoload): Don't double-shift a pointer.
2251
2252 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2253
2254 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2255
2256 * gnutls.c (DEF_GNUTLS_FN):
2257 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2258
2259 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2260
2261 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2262 marker. (Bug#8610)
2263
2264 2011-05-05 Eli Zaretskii <eliz@gnu.org>
2265
2266 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2267 New version that can reserve upto 2GB of heap space.
2268
2269 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
2270
2271 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2272
2273 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2274
2275 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2276 `gnutls_certificate_set_x509_key_file'.
2277
2278 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
2279
2280 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2281 Update dependencies.
2282
2283 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2284
2285 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2286 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2287 Remove unused parameter `fildes'.
2288 * process.c (read_process_output, send_process): Don't pass it.
2289
2290 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2291
2292 Fix previous change: the library cache is defined in w32.c.
2293 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2294 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2295
2296 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2297
2298 Implement dynamic loading of GnuTLS on Windows.
2299
2300 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2301 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2302 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2303 Declare.
2304
2305 * gnutls.c (Qgnutls_dll): Define.
2306 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2307 (gnutls_*): Declare function pointers.
2308 (init_gnutls_functions): New function to initialize function pointers.
2309 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2310 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2311 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2312 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2313 (emacs_gnutls_write, emacs_gnutls_read)
2314 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2315 (Fgnutls_available_p): New function.
2316 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2317 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2318 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2319
2320 * image.c: Include w32.h.
2321 (Vimage_type_cache): Delete.
2322 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2323 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2324 (w32_delayed_load): Move to w32.c.
2325
2326 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2327
2328 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2329 (w32_delayed_load): Move from image.c. When loading a library, record
2330 its filename in the :loaded-from property of the library id.
2331 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2332 Initialize and staticpro them.
2333 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2334
2335 * process.c: Include lisp.h before w32.h, not after.
2336 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2337 instead of gnutls_record_check_pending.
2338
2339 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2340
2341 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2342
2343 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2344 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2345 as passed in.
2346
2347 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2348
2349 * xterm.c (x_set_frame_alpha): Do not set property on anything
2350 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2351
2352 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2353
2354 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2355
2356 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2357
2358 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2359 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2360 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2361 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2362 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2363 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2364 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2365 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2366 (Qgnutls_bootprop_callbacks_verify): Make static.
2367
2368 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2369
2370 * callproc.c: Indentation fixup.
2371
2372 * sysdep.c (wait_for_termination_1): Make static.
2373 (wait_for_termination, interruptible_wait_for_termination):
2374 Move after wait_for_termination_1.
2375
2376 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2377
2378 * sysdep.c (interruptible_wait_for_termination): New function
2379 which is like wait_for_termination, but allows keyboard
2380 interruptions.
2381
2382 * callproc.c (Fcall_process): Add (:file "file") as an option for
2383 the STDOUT buffer.
2384 (Fcall_process_region): Ditto.
2385
2386 2011-04-30 Eli Zaretskii <eliz@gnu.org>
2387
2388 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2389 rather than `XVECTOR (FOO)->size'.
2390
2391 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2392 inttypes.h, as a gnulib replacement is used if it not available in
2393 system headers.
2394
2395 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2396
2397 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2398 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2399 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2400
2401 * coding.c (coding_alloc_by_realloc): Error out if destination
2402 will grow beyond MOST_POSITIVE_FIXNUM.
2403 (decode_coding_emacs_mule): Abort if there isn't enough place in
2404 charbuf for the composition carryover bytes. Reserve an extra
2405 space for up to 2 characters produced in a loop.
2406 (decode_coding_iso_2022): Abort if there isn't enough place in
2407 charbuf for the composition carryover bytes.
2408
2409 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2410
2411 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2412 aborting when %lld or %lll format is passed.
2413 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2414 %llo or %llx format is passed. (Bug#8545)
2415
2416 * window.c (window_scroll_line_based): Use a marker instead of
2417 simple variables to record original value of point. (Bug#7952)
2418
2419 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2420 produced by %s or %c overflows available buffer space. (Bug#8545)
2421
2422 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2423
2424 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
2425 (SIZE_MAX): Move defn after all includes, as they might #define it.
2426
2427 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2428
2429 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2430
2431 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2432
2433 * keyboard.c (Qdelayed_warnings_hook): Define.
2434 (command_loop_1): Run `delayed-warnings-hook'
2435 if Vdelayed_warnings_list is non-nil.
2436 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2437 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2438
2439 2011-04-28 Eli Zaretskii <eliz@gnu.org>
2440
2441 * doprnt.c (doprnt): Don't return value smaller than the buffer
2442 size if the message was truncated. (Bug#8545).
2443
2444 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2445
2446 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2447 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2448
2449 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2450
2451 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2452
2453 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
2454
2455 * makefile.w32-in: Update dependencies.
2456
2457 2011-04-27 Eli Zaretskii <eliz@gnu.org>
2458
2459 Improve `doprnt' and its usage. (Bug#8545)
2460 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2461 `format_end'. Remove support for %l as a conversion specifier.
2462 Don't use xrealloc. Improve diagnostics when the %l size modifier
2463 is used. Update the commentary.
2464
2465 * eval.c (verror): Simplify calculation of size_t.
2466
2467 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2468 messages.
2469
2470 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2471
2472 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2473 change.
2474
2475 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2476
2477 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2478 This makes this file independent of the recent pseudovector change.
2479
2480 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2481
2482 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2483
2484 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2485 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2486 Remove unused local.
2487 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2488
2489 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2490 GCC 4.6.0 optimizes based on type-based alias analysis.
2491 For example, if b is of type struct buffer * and v of type struct
2492 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2493 != &v->size, and therefore "v->size = 1; b->size = 2; return
2494 v->size;" must therefore return 1. This assumption is incorrect
2495 for Emacs, since it type-puns struct Lisp_Vector * with many other
2496 types. To fix this problem, this patch adds a new type struct
2497 vectorlike_header that documents the constraints on layout of vectors
2498 and pseudovectors, and helps optimizing compilers not get fooled
2499 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2500 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2501 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2502 the size member.
2503 (XSETPVECTYPE): Rewrite in terms of new macro.
2504 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2505 This is a bit clearer, and further avoids the possibility of
2506 undesirable aliasing.
2507 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2508 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2509 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2510 since Lisp_Subr is a special case (no "next" field).
2511 (ASIZE): Now uses header.size rather than size.
2512 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2513 to avoid the hassle of writing XVECTOR (foo)->header.size.
2514 (struct vectorlike_header): New type.
2515 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2516 object, to help avoid aliasing.
2517 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2518 (SUBRP): Likewise, since Lisp_Subr is a special case.
2519 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2520 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2521 (struct Lisp_Hash_Table): Combine first two members into a single
2522 struct vectorlike_header member. All uses of "size" and "next" members
2523 changed to be "header.size" and "header.next".
2524 * buffer.h (struct buffer): Likewise.
2525 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2526 * frame.h (struct frame): Likewise.
2527 * process.h (struct Lisp_Process): Likewise.
2528 * termhooks.h (struct terminal): Likewise.
2529 * window.c (struct save_window_data, struct saved_window): Likewise.
2530 * window.h (struct window): Likewise.
2531 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2532 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2533 * buffer.c (init_buffer_once): Likewise.
2534 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2535 special case.
2536 * process.c (Fformat_network_address): Use local var for size,
2537 for brevity.
2538
2539 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2540
2541 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2542 * data.c (atof): Remove decl; no longer used or needed.
2543 (digit_to_number): Move to lread.c.
2544 (Fstring_to_number): Use new string_to_number function, to be
2545 consistent with how the Lisp reader treats infinities and NaNs.
2546 Do not assume that floating-point numbers represent EMACS_INT
2547 without losing information; this is not true on most 64-bit hosts.
2548 Avoid double-rounding errors, by insisting on integers when
2549 parsing non-base-10 numbers, as the documentation specifies.
2550 * lisp.h (string_to_number): New decl, replacing ...
2551 (isfloat_string): Remove.
2552 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2553 (read1): Do not accept +. and -. as integers; this
2554 appears to have been a coding error. Similarly, do not accept
2555 strings like +-1e0 as floating point numbers. Do not report
2556 overflow for integer overflows unless the base is not 10 which
2557 means we have no simple and reliable way to continue.
2558 Break out the floating-point parsing into a new
2559 function string_to_number, so that Fstring_to_number parses
2560 floating point numbers consistently with the Lisp reader.
2561 (digit_to_number): Move here from data.c. Make it static inline.
2562 (E_CHAR, EXP_INT): Remove, replacing with ...
2563 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2564 (string_to_number): New function, replacing isfloat_string.
2565 This function checks for valid syntax and produces the resulting
2566 Lisp float number too. Rework it so that string-to-number
2567 no longer mishandles examples like "1.0e+". Use strtoumax,
2568 so that overflow for non-base-10 numbers is reported only when
2569 there's no portable and simple way to convert to floating point.
2570
2571 * textprop.c (set_text_properties_1): Rewrite for clarity,
2572 and to avoid GCC warning about integer overflow.
2573
2574 * intervals.h (struct interval): Use EMACS_INT for members
2575 where EMACS_UINT might cause problems. See
2576 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2577 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2578 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2579 All uses changed.
2580 (offset_intervals): Tell GCC not to worry about length overflow
2581 when negating a negative length.
2582
2583 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2584 (overrun_check_free): Likewise.
2585
2586 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2587 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2588 word size.
2589
2590 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2591 (gnutls_make_error): Rename local to avoid shadowing.
2592 (gnutls_emacs_global_deinit): ifdef out; not used.
2593 (Fgnutls_boot): Use const for pointer to readonly storage.
2594 Comment out unused local. Fix pointer signedness problems.
2595
2596 * lread.c (openp): Don't stuff size_t into an 'int'.
2597 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2598 about possible signed overflow.
2599
2600 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2601 (GDK_KEY_g): Don't define if already defined.
2602 (xg_prepare_tooltip): Avoid pointer signedness problem.
2603 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2604
2605 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2606 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2607
2608 * xfns.c (Fx_window_property): Simplify a bit,
2609 to make a bit faster and to avoid GCC 4.6.0 warning.
2610 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2611
2612 * fns.c (internal_equal): Don't assume size_t fits in int.
2613
2614 * alloc.c (compact_small_strings): Tighten assertion a little.
2615
2616 Replace pEd with more-general pI, and fix some printf arg casts.
2617 * lisp.h (pI): New macro, generalizing old pEd macro to other
2618 conversion specifiers. For example, use "...%"pI"d..." rather
2619 than "...%"pEd"...".
2620 (pEd): Remove. All uses replaced with similar uses of pI.
2621 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2622 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2623 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2624 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2625 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2626 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2627 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2628 64-bit hosts.
2629 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2630 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2631 * print.c (safe_debug_print, print_object): Likewise.
2632 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2633 to int.
2634 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2635 avoiding the 0 flag, which is not portable.
2636 * process.c (Fmake_network_process): Use pI to avoid cast.
2637 * region-cache.c (pp_cache): Likewise.
2638 * xdisp.c (decode_mode_spec): Likewise.
2639 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2640 behavior on 64-bit hosts with printf arg.
2641 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2642 (x_stop_queuing_selection_requests): Likewise.
2643 (x_get_window_property): Don't truncate byte count to an 'int'
2644 when tracing.
2645
2646 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2647 here, since it parses constructs like leading '-' and spaces,
2648 which are not wanted; and it overflows with large numbers.
2649 Instead, simply match F[0-9]+, which is what is wanted anyway.
2650
2651 * alloc.c: Remove unportable assumptions about struct layout.
2652 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2653 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2654 (allocate_vectorlike, make_pure_vector): Use the new macros,
2655 plus offsetof, to remove unportable assumptions about struct layout.
2656 These assumptions hold on all porting targets that I know of, but
2657 they are not guaranteed, they're easy to remove, and removing them
2658 makes further changes easier.
2659
2660 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2661 This doesn't fix a bug but makes the code clearer.
2662 (string_overrun_cookie): Now const. Use initializers that
2663 don't formally overflow signed char, to avoid warnings.
2664 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2665 can cause Emacs to crash when string overrun checking is enabled.
2666 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2667 multiple of sizeof (EMACS_INT); it need not be, if
2668 alignof(EMACS_INT) < sizeof (EMACS_INT).
2669 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2670
2671 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2672
2673 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2674
2675 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2676
2677 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2678 supposed to be handshaking. (Bug#8556)
2679 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2680
2681 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2682
2683 * lisp.h (Qdebug): List symbol.
2684 * eval.c (Qdebug): Restore global linkage.
2685 * keyboard.c (debug-on-event): New variable.
2686 (handle_user_signal): Break into debugger when debug-on-event
2687 matches the current signal symbol.
2688
2689 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2690
2691 * alloc.c (check_sblock, check_string_bytes)
2692 (check_string_free_list): Convert to standard C.
2693
2694 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2695
2696 * w32.c (emacs_gnutls_push): Fix typo.
2697
2698 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2699
2700 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2701 "cast to pointer from integer of different size".
2702
2703 Improve doprnt and its use in verror. (Bug#8545)
2704 * doprnt.c (doprnt): Document the set of format control sequences
2705 supported by the function. Use SAFE_ALLOCA instead of always
2706 using `alloca'.
2707
2708 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2709 is one byte too soon. Don't use xrealloc; instead xfree and
2710 xmalloc anew.
2711
2712 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2713
2714 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2715 callbacks stage.
2716
2717 * gnutls.c: Renamed global_initialized to
2718 gnutls_global_initialized. Added internals for the
2719 :verify-hostname-error, :verify-error, and :verify-flags
2720 parameters of `gnutls-boot' and documented those parameters in the
2721 docstring. Start callback support.
2722 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2723 unless a fatal error occured. Call gnutls_alert_send_appropriate
2724 on error. Return error code.
2725 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2726 (emacs_gnutls_read): Likewise.
2727 (Fgnutls_boot): Return handshake error code.
2728 (emacs_gnutls_handle_error): New function.
2729 (wsaerror_to_errno): Likewise.
2730
2731 * w32.h (emacs_gnutls_pull): Add prototype.
2732 (emacs_gnutls_push): Likewise.
2733
2734 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2735 (emacs_gnutls_push): Likewise.
2736
2737 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2738
2739 * process.c (wait_reading_process_output): Check if GnuTLS
2740 buffered some data internally if no FDs are set for TLS
2741 connections.
2742
2743 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2744 (LIBS): Link to USER_LIBS.
2745 ($(BLD)/gnutls.$(0)): New target.
2746
2747 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2748
2749 * xdisp.c (handle_single_display_spec): Rename the
2750 display_replaced_before_p argument into display_replaced_p, to
2751 make it consistent with the commentary. Fix typos in the
2752 commentary.
2753
2754 * textprop.c (syms_of_textprop): Remove dead code.
2755 (copy_text_properties): Delete obsolete commentary about an
2756 interface that was deleted long ago. Fix typos in the description
2757 of arguments.
2758
2759 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2760 to changes in oldXMenu/XMenu.h from 2011-04-16.
2761 <menu_help_message, prev_menu_help_message>: Constify.
2762 (IT_menu_make_room): menu->help_text is now `const char **';
2763 adjust.
2764
2765 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2766 to changes in oldXMenu/XMenu.h from 2011-04-16.
2767 (struct XMenu): Declare `help_text' `const char **'.
2768
2769 * xfaces.c <Qunspecified>: Make extern again.
2770
2771 * syntax.c: Include sys/types.h before including regex.h, as
2772 required by Posix.
2773
2774 * doc.c (get_doc_string): Improve the format passed to `error'.
2775
2776 * doprnt.c (doprnt): Improve commentary.
2777
2778 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2779
2780 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2781 them with etags.
2782
2783 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2784 changes in globals.h immediately force recompilation.
2785 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2786 $(CURDIR)/s/ms-w32.h.
2787 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2788
2789 * character.c (Fchar_direction): Function deleted.
2790 (syms_of_character): Don't defsubr it.
2791 <char-direction-table>: Deleted.
2792
2793 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2794
2795 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2796 * doprnt.c: Include limits.h.
2797 (SIZE_MAX): New macro.
2798 (doprnt): Return a size_t value. 2nd arg is now size_t.
2799 Many local variables are now size_t instead of int or unsigned.
2800 Improve overflow protection. Support `l' modifier for integer
2801 conversions. Support %l conversion. Don't assume an EMACS_INT
2802 argument for integer conversions and for %c.
2803
2804 * lisp.h (doprnt): Restore prototype.
2805
2806 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2807 $(SRC)/character.h.
2808
2809 * Makefile.in (base_obj): Add back doprnt.o.
2810
2811 * deps.mk (doprnt.o): Add back prerequisites.
2812 (callint.o): Depend on character.h.
2813
2814 * eval.c (internal_lisp_condition_case): Include the handler
2815 representation in the error message.
2816 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2817 when breaking from the loop.
2818
2819 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2820
2821 * callint.c (Fcall_interactively): When displaying error message
2822 about invalid control letter, pass the character's codepoint, not
2823 a pointer to its multibyte form. Improve display of the character
2824 in octal and display also its hex code.
2825
2826 * character.c (char_string): Use %x to display the (unsigned)
2827 codepoint of an invalid character, to avoid displaying a bogus
2828 negative value.
2829
2830 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2831 `error', not SYMBOL_NAME itself.
2832
2833 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2834 character arguments to `error'.
2835
2836 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2837 to `error' in error message about FINAL_CHAR argument. Make sure
2838 FINAL_CHAR is a character, and use %c when it is passed as
2839 argument to `error'.
2840
2841 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2842
2843 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2844
2845 * w32.c: Include <time.h>.
2846 (sys_localtime): New function.
2847
2848 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2849
2850 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2851
2852 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2853
2854 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2855
2856 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2857 zombies (Bug#8467).
2858
2859 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2860
2861 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2862 gl_state.e_property when gl_state.object is Qt.
2863
2864 * insdel.c (make_gap_larger): Remove limitation of buffer size
2865 to <= INT_MAX.
2866
2867 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2868
2869 * xdisp.c (lookup_glyphless_char_display)
2870 (produce_glyphless_glyph): Handle cons cell entry in
2871 glyphless-char-display.
2872 (Vglyphless_char_display): Document it.
2873
2874 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2875 glyphless-char-display.
2876
2877 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2878
2879 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2880
2881 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2882
2883 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2884 definition for no-X builds.
2885
2886 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2887
2888 Static checks with GCC 4.6.0 and non-default toolkits.
2889
2890 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2891
2892 * process.c (keyboard_bit_set): Define only if SIGIO.
2893 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2894 (send_process): Repair possible setjmp clobbering.
2895
2896 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2897
2898 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2899
2900 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2901
2902 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2903 Define only if needed.
2904
2905 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2906 by pacifying GCC about it. Maybe it's time to retire it?
2907 * xfaces.c (USG, __TIMEVAL__): Likewise.
2908
2909 * dispextern.h (struct redisplay_interface): Rename param
2910 to avoid shadowing.
2911 * termhooks.h (struct terminal): Likewise.
2912 * xterm.c (xembed_send_message): Likewise.
2913
2914 * insdel.c (make_gap_smaller): Define only if
2915 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2916
2917 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2918 it.
2919
2920 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2921 so that we aren't warned about unused symbols.
2922
2923 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2924
2925 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2926
2927 * xfns.c (x_real_positions): Mark locals as initialized.
2928
2929 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2930
2931 * xterm.c: Fix problems found by static analysis with other toolkits.
2932 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2933 (x_dispatch_event): Declare static if USE_GTK, and
2934 define if USE_GTK || USE_X_TOOLKIT.
2935 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2936 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2937 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2938 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2939
2940 * xmenu.c (menu_help_callback): Pointer type fixes.
2941 Use const pointers when pointing at readonly data. Avoid pointer
2942 signedness clashes.
2943 (FALSE): Remove unused macro.
2944 (update_frame_menubar): Remove unused decl.
2945
2946 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2947
2948 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2949 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2950 (single_menu_item): Rename local to avoid shadowing.
2951
2952 * keyboard.c (make_lispy_event): Remove unused local var.
2953
2954 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2955 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2956
2957 * bitmaps: Change bitmaps from unsigned char back to the X11
2958 compatible char. Avoid the old compiler warnings about
2959 out-of-range initializers by using, for example, '\xab' rather
2960 than 0xab.
2961
2962 * xgselect.c (xgselect_initialize): Check vs interface
2963 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2964
2965 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2966
2967 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2968 to read-only memory.
2969
2970 * fns.c (vector): Remove; this old hack is no longer needed.
2971
2972 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2973 Remove unused var.
2974 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2975
2976 * xrdb.c (x_load_resources): Omit unused local.
2977
2978 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2979 (x_window): Rename locals to avoid shadowing.
2980 (USG): Use the kludged USG macro, to pacify gcc.
2981
2982 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2983 (x_term_init): Remove local to avoid shadowing.
2984
2985 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2986
2987 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2988 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2989
2990 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2991
2992 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2993
2994 Fix regex.c, syntax.c and friends for buffers > 2GB.
2995 * syntax.h (struct gl_state_s): Declare character position members
2996 EMACS_INT.
2997
2998 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2999
3000 * textprop.c (verify_interval_modification, interval_of):
3001 Declare arguments EMACS_INT.
3002
3003 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3004 EMACS_INT.
3005
3006 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3007
3008 * indent.c (Fvertical_motion): Local variable it_start is now
3009 EMACS_INT.
3010
3011 * regex.c (re_match, re_match_2, re_match_2_internal)
3012 (bcmp_translate, regcomp, regexec, print_double_string)
3013 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3014 (re_compile_pattern, re_exec): Declare arguments and local
3015 variables `size_t' and `ssize_t' and return values `regoff_t', as
3016 appropriate.
3017 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3018 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3019 <compile_stack_type>: `size' and `avail' are now `size_t'.
3020
3021 * regex.h <regoff_t>: Use ssize_t, not int.
3022 (re_search, re_search_2, re_match, re_match_2): Arguments that
3023 specify buffer/string position and length are now ssize_t and
3024 size_t. Return type is regoff_t.
3025
3026 2011-04-16 Ben Key <bkey76@gmail.com>
3027
3028 * nsfont.m: Fixed bugs in ns_get_family and
3029 ns_descriptor_to_entity that were caused by using free to
3030 deallocate memory blocks that were allocated by xmalloc (via
3031 xstrdup). This caused Emacs to crash when compiled with
3032 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3033 --enable-checking=xmallocoverrun). xfree is now used to
3034 deallocate these memory blocks.
3035
3036 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3037
3038 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3039
3040 emacs_write: Accept and return EMACS_INT for sizes.
3041 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3042 et seq.
3043 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3044 Accept and return EMACS_INT.
3045 (emacs_gnutls_write): Return the number of bytes written on
3046 partial writes.
3047 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
3048 (emacs_read, emacs_write): Remove check for negative size, as the
3049 Emacs source code has been audited now.
3050 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3051 (emacs_read, emacs_write): Use it.
3052 * process.c (send_process): Adjust to the new signatures of
3053 emacs_write and emacs_gnutls_write. Do not attempt to store
3054 a byte offset into an 'int'; it might overflow.
3055 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
3056
3057 * sound.c: Don't assume sizes fit in 'int'.
3058 (struct sound_device.period_size, alsa_period_size):
3059 Return EMACS_INT, not int.
3060 (struct sound_device.write, vox_write, alsa_write):
3061 Accept EMACS_INT, not int.
3062 (wav_play, au_play): Use EMACS_INT to store sizes and to
3063 record read return values.
3064
3065 2011-04-15 Ben Key <bkey76@gmail.com>
3066
3067 * keyboard.c (Qundefined): Don't declare static since it is used
3068 in nsfns.m.
3069 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3070 static since they are used in nsfont.m.
3071
3072 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3073
3074 * process.c (Qprocessp): Don't declare static.
3075 * lisp.h (Qprocessp): Declare again.
3076
3077 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
3078
3079 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3080
3081 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3082
3083 Improve C-level modularity by making more things 'static'.
3084
3085 Don't publish debugger-only interfaces to other modules.
3086 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3087 (verify_bytepos, count_markers): Move decls to the only modules
3088 that need them.
3089 * region-cache.h (pp_cache): Likewise.
3090 * window.h (check_all_windows): Likewise.
3091 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3092
3093 * sysdep.c (croak): Now static, if
3094 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3095 * syssignal.h (croak): Declare only if not static.
3096
3097 * alloc.c (refill_memory_reserve): Now static if
3098 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3099 * lisp.h (refill_memory_reserve): Declare only if not static.
3100
3101 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3102 Define only if USE_LUCID.
3103
3104 * xrdb.c (x_customization_string, x_rm_string): Now static.
3105
3106 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3107 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3108
3109 * xdisp.c (draw_row_with_mouse_face): Now static.
3110 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3111
3112 * window.h (check_all_windows): Mark externally visible.
3113
3114 * window.c (window_deletion_count): Now static.
3115
3116 * undo.c: Make symbols static if they're not exported.
3117 (last_undo_buffer, last_boundary_position, pending_boundary):
3118 Now static.
3119
3120 * textprop.c (interval_insert_behind_hooks): Now static.
3121 (interval_insert_in_front_hooks): Likewise.
3122
3123 * term.c: Make symbols static if they're not exported.
3124 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3125 (max_frame_lines, tty_set_terminal_modes):
3126 (tty_reset_terminal_modes, tty_turn_off_highlight):
3127 (get_tty_terminal): Now static.
3128 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3129 * termhooks.h (term_mouse_moveto): Do not declare if
3130 HAVE_WINDOW_SYSTEM.
3131 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3132 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3133
3134 * sysdep.c: Make symbols static if they're not exported.
3135 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3136 Now static.
3137 (sigprocmask_set, full_mask): Remove; unused.
3138 (wait_debugging): Mark as visible.
3139 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3140 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3141
3142 * syntax.c (syntax_temp): Define only if !__GNUC__.
3143
3144 * sound.c (current_sound_device, current_sound): Now static.
3145
3146 * search.c (searchbufs, searchbuf_head): Now static.
3147
3148 * scroll.c (scroll_cost): Remove; unused.
3149 * dispextern.h (scroll_cost): Remove decl.
3150
3151 * region-cache.h (pp_cache): Mark as externally visible.
3152
3153 * process.c: Make symbols static if they're not exported.
3154 (process_tick, update_tick, create_process, chan_process):
3155 (Vprocess_alist, proc_buffered_char, datagram_access):
3156 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3157 (deactivate_process): Mark defn as static, as well as decl.
3158 * lisp.h (create_process): Remove decl.
3159 * process.h (chan_process, Vprocess_alist): Remove decls.
3160
3161 * print.c: Make symbols static if they're not exported.
3162 (print_depth, new_backquote_output, being_printed, print_buffer):
3163 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3164 (print_interval, print_number_index, initial_stderr_stream):
3165 Now static.
3166 * lisp.h (Fprinc): Remove decl.
3167 (debug_output_compilation_hack): Mark as externally visible.
3168
3169 * sysdep.c (croak): Move decl from here to syssignal.h.
3170 * syssignal.h (croak): Put it here, so the API can be checked when
3171 'croak' is called from dissociate_if_controlling_tty.
3172
3173 * minibuf.c: Make symbols static if they're not exported.
3174 (minibuf_save_list, choose_minibuf_frame): Now static.
3175 * lisp.h (choose_minibuf_frame): Remove decl.
3176
3177 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3178
3179 * lread.c: Make symbols static if they're not exported.
3180 (read_objects, initial_obarray, oblookup_last_bucket_number):
3181 Now static.
3182 (make_symbol): Remove; unused.
3183 * lisp.h (initial_obarray, make_symbol): Remove decls.
3184
3185 * keyboard.c: Make symbols static if they're not exported.
3186 (single_kboard, recent_keys_index, total_keys, recent_keys):
3187 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3188 (this_single_command_key_start, echoing, last_auto_save):
3189 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3190 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3191 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3192 (Vlispy_mouse_stem, double_click_count):
3193 Now static.
3194 (force_auto_save_soon): Define only if SIGDANGER.
3195 (ignore_mouse_drag_p): Now static if
3196 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3197 (print_help): Remove; unused.
3198 (stop_character, last_timer_event): Mark as externally visible.
3199 * keyboard.h (ignore_mouse_drag_p): Declare only if
3200 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3201 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3202 * lisp.h (echoing): Remove decl.
3203 (force_auto_save_soon): Declare only if SIGDANGER.
3204 * xdisp.c (redisplay_window): Simplify code, to make it more
3205 obvious that ignore_mouse_drag_p is not accessed if !defined
3206 USE_GTK && !defined HAVE_NS.
3207
3208 * intervals.c: Make symbols static if they're not exported.
3209 (merge_properties_sticky, merge_interval_right, delete_interval):
3210 Now static.
3211 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3212
3213 * insdel.c: Make symbols static if they're not exported.
3214 However, leave prepare_to_modify_buffer alone. It's never
3215 called from outside this function, but that appears to be a bug.
3216 (combine_after_change_list, combine_after_change_buffer):
3217 (adjust_after_replace, signal_before_change): Now static.
3218 (adjust_after_replace_noundo): Remove; unused.
3219 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3220 (signal_before_change): Remove decls.
3221
3222 * indent.c (val_compute_motion, val_vmotion): Now static.
3223
3224 * image.c: Make symbols static if they're not exported.
3225 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3226 if USE_GTK.
3227 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3228 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3229
3230 * fringe.c (standard_bitmaps): Now static.
3231 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3232
3233 * frame.c: Make symbols static if they're not exported.
3234 (x_report_frame_params, make_terminal_frame): Now static.
3235 (get_frame_param): Now static, unless HAVE_NS.
3236 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3237 (x_get_resource_string): Remove; not used.
3238 * frame.h (make_terminal_frame, x_report_frame_params):
3239 (x_get_resource_string); Remove decls.
3240 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3241 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3242
3243 * font.c, fontset.c: Make symbols static if they're not exported.
3244 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3245 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3246 * font.c (font_close_object): Now static.
3247 * font.h (font_close_object): Remove.
3248 * fontset.c (FONTSET_OBJLIST): Remove.
3249 (free_realized_fontset) #if-0 the body, which does nothing.
3250 (face_suitable_for_char_p): #if-0, as it's never called.
3251 * fontset.h (face_suitable_for_char_p): Remove decl.
3252 * xfaces.c (face_at_string_position):
3253 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
3254 since 0 is always ASCII.
3255
3256 * fns.c (weak_hash_tables): Now static.
3257
3258 * fileio.c: Make symbols static if they're not exported.
3259 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3260 (Vwrite_region_annotation_buffers): Now static.
3261
3262 * eval.c: Make symbols static if they're not exported.
3263 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3264 * lisp.h (backtrace_list): Remove decl.
3265
3266 * emacs.c: Make symbols static if they're not exported.
3267 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3268 (fatal_error_code, fatal_error_signal_hook, standard_args):
3269 Now static.
3270 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3271 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3272 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3273 * lisp.h (fatal_error_signal_hook): Remove decl.
3274 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3275
3276 * editfns.c: Move a (normally-unused) function to its only use.
3277 * editfns.c, lisp.h (get_operating_system_release): Remove.
3278 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3279 worth the hassle of breaking this out.
3280
3281 * xterm.c: Make symbols static if they're not exported.
3282 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3283 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3284 (x_destroy_window, x_delete_display):
3285 Now static.
3286 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3287 (x_mouse_leave): Remove; unused.
3288 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3289 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3290 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3291 Remove decls.
3292 (x_mouse_leave): Declare only if WINDOWSNT.
3293 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3294 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3295 USE_X_TOOLKIT.
3296
3297 * ftxfont.c: Make symbols static if they're not exported.
3298 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3299 HAVE_FREETYPE.
3300 * font.h (ftxfont_driver): Likewise.
3301
3302 * xfns.c: Make symbols static if they're not exported.
3303 (x_last_font_name, x_display_info_for_name):
3304 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3305 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3306 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3307 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3308 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3309 (last_show_tip_args): Now static.
3310 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3311 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3312 (x_screen_planes): Remove; unused.
3313 * dispextern.h (x_screen_planes): Remove decl.
3314
3315 * dispnew.c: Make symbols static if they're not exported.
3316 * dispextern.h (redraw_garbaged_frames, scrolling):
3317 (increment_row_positions): Remove.
3318 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3319 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3320 Now static.
3321 (redraw_garbaged_frames): Remove; unused.
3322
3323 * xfaces.c: Make symbols static if they're not exported.
3324 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3325 Remove decls.
3326 * xterm.h (defined_color): Remove decls.
3327 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3328 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3329 (menu_face_changed_default, defined_color, free_realized_face):
3330 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3331 (ascii_face_of_lisp_face): Remove; unused.
3332
3333 * xdisp.c: Make symbols static if they're not exported.
3334 * dispextern.h (scratch_glyph_row, window_box_edges):
3335 (glyph_to_pixel_coords, set_cursor_from_row):
3336 (get_next_display_element, set_iterator_to_next):
3337 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3338 (show_mouse_face): Remove decls
3339 * frame.h (message_buf_print): Likewise.
3340 * lisp.h (pop_message, set_message, check_point_in_composition):
3341 Likewise.
3342 * xterm.h (set_vertical_scroll_bar): Likewise.
3343 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3344 (message_buf_print, scratch_glyph_row, displayed_buffer):
3345 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3346 (get_next_display_element, show_mouse_face, window_box_edges):
3347 (frame_to_window_pixel_xy, check_point_in_composition):
3348 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3349 (glyph_to_pixel_coords): Remove; unused.
3350
3351 * dired.c (file_name_completion): Now static.
3352
3353 * dbusbind.c (xd_in_read_queued_messages): Now static.
3354
3355 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3356 * data.c (circular_list_error): Remove.
3357
3358 * commands.h (last_point_position, last_point_position_buffer):
3359 (last_point_position_window): Remove decls.
3360 * keyboard.c: Make these variables static.
3361
3362 * coding.h (coding, code_convert_region, encode_coding_gap):
3363 Remove decls.
3364 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3365 (iso_code_class, detect_coding, code_convert_region): Now static.
3366 (encode_coding_gap): Remove; unused.
3367
3368 * chartab.c (chartab_chars, chartab_bits): Now static.
3369
3370 * charset.h (charset_iso_8859_1): Remove decl.
3371 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3372 Now static.
3373
3374 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3375 * ccl.c (Vccl_program_table): Now static.
3376 (check_ccl_update): Remove; unused.
3377
3378 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3379 * category.h: ... from here.
3380 * category.c (check_category_table, set_category_set): Now static.
3381
3382 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3383 * lisp.h: Remove these decls.
3384
3385 * buffer.c (buffer_count): Remove unused var.
3386
3387 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3388 so that it's not optimized away.
3389 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3390 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3391 exported only to the debugger.
3392
3393 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
3394 * atimer.h (run_all_atimers): Remove; not exported.
3395
3396 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3397 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3398 was inaccessible from Lisp.
3399 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3400 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3401
3402 alloc.c: Import and export fewer symbols, and remove unused items.
3403 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3404 is defined.
3405 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3406 it's not optimized away by whole-program optimization.
3407 (message_enable_multibyte, free_misc): Remove.
3408 (catchlist, handlerlist, mark_backtrace):
3409 Declare only if BYTE_MARK_STACK.
3410 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3411 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3412 (message_enable_multibyte): Remove decl.
3413 (free_misc, interval_free_list, float_block, float_block_index):
3414 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3415 (cons_free_list, last_marked_index):
3416 Now static.
3417 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3418 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3419 (mark_backtrace): Define only if BYTE_MARK_STACK.
3420 * xdisp.c (message_enable_multibyte): Now static.
3421
3422 Declare Lisp_Object Q* variables to be 'static' if not exported.
3423 This makes it easier for human readers (and static analyzers)
3424 to see whether these variables are used from other modules.
3425 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3426 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3427 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3428 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3429 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3430 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3431 * xmenu.c, xselect.c:
3432 Declare Q* vars static if they are not used in other modules.
3433 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3434 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3435 Remove decls of unexported vars.
3436 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3437
3438 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3439
3440 Make Emacs functions such as Fatom 'static' by default.
3441 This makes it easier for human readers (and static analyzers)
3442 to see whether these functions can be called from other modules.
3443 DEFUN now defines a static function. To make the function external
3444 so that it can be used in other C modules, use the new macro DEFUE.
3445 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3446 (Finit_image_library):
3447 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3448 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3449 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3450 Remove decls, since these functions are now static.
3451 (Funintern, Fget_internal_run_time): New decls, since these functions
3452 were already external.
3453
3454 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3455 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3456 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3457 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3458 * keyboard.c, keymap.c, lread.c:
3459 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3460 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3461 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3462 Mark functions with DEFUE instead of DEFUN,
3463 if they are used in other modules.
3464 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3465 decls for now-static functions.
3466 * buffer.h (Fdelete_overlay): Remove decl.
3467 * callproc.c (Fgetenv_internal): Mark as internal.
3468 * composite.c (Fremove_list_of_text_properties): Remove decl.
3469 (Fcomposition_get_gstring): New forward static decl.
3470 * composite.h (Fcomposite_get_gstring): Remove decl.
3471 * dired.c (Ffile_attributes): New forward static decl.
3472 * doc.c (Fdocumntation_property): New forward static decl.
3473 * eval.c (Ffetch_bytecode): New forward static decl.
3474 (Funintern): Remove extern decl; now in .h file where it belongs.
3475 * fileio.c (Fmake_symbolic_link): New forward static decl.
3476 * image.c (Finit_image_library): New forward static decl.
3477 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3478 * intervals.h (Fprevious_property_change):
3479 (Fremove_list_of_text_properties): Remove decls.
3480 * keyboard.c (Fthis_command_keys): Remove decl.
3481 (Fcommand_execute): New forward static decl.
3482 * keymap.c (Flookup_key): New forward static decl.
3483 (Fcopy_keymap): Now static.
3484 * keymap.h (Flookup_key): Remove decl.
3485 * process.c (Fget_process): New forward static decl.
3486 (Fprocess_datagram_address): Mark as internal.
3487 * syntax.c (Fsyntax_table_p): New forward static decl.
3488 (skip_chars): Remove duplicate decl.
3489 * textprop.c (Fprevious_property_change): New forward static decl.
3490 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3491 Now internal.
3492 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3493 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3494
3495 * editfns.c (Fformat): Remove unreachable code.
3496
3497 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3498
3499 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3500 change. (Bug#8496)
3501
3502 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3503
3504 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3505 when at ZV. (Bug#8487)
3506
3507 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3508
3509 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3510 (Bug#8437)
3511 * keyboard.c (parse_tool_bar_item): Likewise.
3512 * sound.c (sound_cleanup, alsa_close): Likewise.
3513 * termcap.c (tgetent): Likewise.
3514 * xfns.c (x_default_font_parameter): Likewise.
3515 * xsettings.c (read_and_apply_settings): Likewise.
3516
3517 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3518 (overrun_check_free): Protoize.
3519
3520 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3521
3522 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3523 since callers should never pass a negative size.
3524 Change the signature to match that of plain 'read' and 'write'; see
3525 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3526 * lisp.h: Update prototypes of emacs_write and emacs_read.
3527
3528 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3529
3530 * xdisp.c (redisplay_window): Don't try to determine the character
3531 position of the scroll margin if the window start point w->startp
3532 is outside the buffer's accessible region. (Bug#8468)
3533
3534 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3535
3536 Fix write-region and its subroutines for buffers > 2GB.
3537 * fileio.c (a_write, e_write): Modify declaration of arguments and
3538 local variables to support buffers larger than 2GB.
3539 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3540
3541 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3542 argument, local variables, and return value.
3543
3544 * lisp.h: Update prototypes of emacs_write and emacs_read.
3545
3546 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3547
3548 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3549
3550 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3551
3552 Fix more problems found by GCC 4.6.0's static checks.
3553
3554 * xdisp.c (vmessage): Use a better test for character truncation.
3555
3556 * charset.c (load_charset_map): <, not <=, for optimization,
3557 and to avoid potential problems with integer overflow.
3558 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3559 * casetab.c (set_identity, shuffle): Likewise.
3560 * editfns.c (Fformat): Likewise.
3561 * syntax.c (skip_chars): Likewise.
3562
3563 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3564 This also lets GCC 4.6.0 generate slightly better loop code.
3565
3566 * callint.c (Fcall_interactively): <, not <=, for optimization.
3567 (Fcall_interactively): Count the number of arguments produced,
3568 not the number of arguments given. This is simpler and lets GCC
3569 4.6.0 generate slightly better code.
3570
3571 * ftfont.c: Distingish more carefully between FcChar8 and char.
3572 The previous code passed unsigned char * to a functions like
3573 strlen and xstrcasecmp that expect char *, which does not
3574 conform to the C standard.
3575 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3576 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3577 char * when the C standard requires it.
3578
3579 * keyboard.c (read_char): Remove unused var.
3580
3581 * eval.c: Port to Windows vsnprintf (Bug#8435).
3582 Include <limits.h>.
3583 (SIZE_MAX): Define if the headers do not.
3584 (verror): Do not give up if vsnprintf returns a negative count.
3585 Instead, grow the buffer. This ports to Windows vsnprintf, which
3586 does not conform to C99. Problem reported by Eli Zaretskii.
3587 Also, simplify the allocation scheme, by avoiding the need for
3588 calling realloc, and removing the ALLOCATED variable.
3589
3590 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3591
3592 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3593 But keep the doprint source code for now, as we might revamp it
3594 and use it again (Bug#8435).
3595 * lisp.h (doprnt): Remove.
3596 * Makefile.in (base_obj): Remove doprnt.o.
3597 * deps.mk (doprnt.o): Remove.
3598
3599 error: Print 32- and 64-bit integers portably (Bug#8435).
3600 Without this change, on typical 64-bit hosts error ("...%d...", N)
3601 was used to print both 32- and 64-bit integers N, which relied on
3602 undefined behavior.
3603 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3604 New macro.
3605 * lisp.h (error, verror): Mark as printf-like functions.
3606 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3607 Report overflow in size calculations when allocating printf buffer.
3608 Do not truncate output string at its first null byte.
3609 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3610 Truncate the output at a character boundary, since vsnprintf does not
3611 do that.
3612 * charset.c (check_iso_charset_parameter): Convert internal
3613 character to string before calling 'error', since %c now has the
3614 printf meaning.
3615 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3616 overflow when computing char to be passed to 'error'. Do not
3617 pass Lisp_Object to 'error'; pass the integer instead.
3618 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3619 formatted with plain %d.
3620
3621 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3622
3623 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3624
3625 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3626
3627 * xterm.c (x_catch_errors): Remove duplicate declaration.
3628
3629 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3630
3631 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3632
3633 2011-04-10 Jim Meyering <meyering@redhat.com>
3634
3635 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3636 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3637 return ssize_t not "int", and use size_t as the buffer length.
3638 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3639 * gnutls.h: Update declarations.
3640 * process.c (read_process_output): Use ssize_t, to match.
3641 (send_process): Likewise.
3642
3643 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3644
3645 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3646
3647 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3648
3649 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3650 Use unsigned char, to match FcChar8 type definition.
3651
3652 * xterm.c (handle_one_xevent):
3653 * xmenu.c (create_and_show_popup_menu):
3654 * xselect.c (x_decline_selection_request)
3655 (x_reply_selection_request): Avoid type-punned deref of X events.
3656
3657 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3658
3659 Fix some uses of `int' instead of EMACS_INT.
3660 * search.c (string_match_1, fast_string_match)
3661 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3662 (scan_buffer, find_next_newline_no_quit)
3663 (find_before_next_newline, search_command, Freplace_match)
3664 (Fmatch_data): Make some `int' variables be EMACS_INT.
3665
3666 * xdisp.c (display_count_lines): 3rd argument and return value now
3667 EMACS_INT. All callers changed.
3668 (pint2hrstr): Last argument is now EMACS_INT.
3669
3670 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3671 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3672 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3673 (decode_coding_utf_16, decode_coding_emacs_mule)
3674 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3675 (decode_coding_ccl, decode_coding_charset)
3676 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3677 (decode_coding_iso_2022, decode_coding_emacs_mule)
3678 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3679 <char_offset, last_offset>: Declare EMACS_INT.
3680 (encode_coding_utf_8, encode_coding_utf_16)
3681 (encode_coding_emacs_mule, encode_invocation_designation)
3682 (encode_designation_at_bol, encode_coding_iso_2022)
3683 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3684 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3685 Declare EMACS_INT.
3686 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3687 (encode_invocation_designation): Last argument P_NCHARS is now
3688 EMACS_INT.
3689 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3690 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3691
3692 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3693 All users changed.
3694
3695 * ccl.c (Fccl_execute_on_string): Declare some variables
3696 EMACS_INT.
3697
3698 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3699
3700 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3701
3702 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3703
3704 * process.c (Fformat_network_address): Doc fix.
3705
3706 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3707
3708 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3709
3710 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3711
3712 * keyboard.c (read_char): Call Lisp function help-form-show,
3713 instead of using internal_with_output_to_temp_buffer.
3714 (Qhelp_form_show): New var.
3715 (syms_of_keyboard): Use DEFSYM macro.
3716
3717 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3718
3719 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3720
3721 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3722
3723 * process.c (Flist_processes): Remove to Lisp.
3724 (list_processes_1): Delete.
3725
3726 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3727
3728 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3729
3730 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3731
3732 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3733
3734 Fix more problems found by GCC 4.6.0's static checks.
3735
3736 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3737
3738 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3739
3740 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3741
3742 * xdisp.c (vmessage): Mark as a printf-like function.
3743
3744 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3745
3746 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3747
3748 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3749 printf-like functions.
3750 (tiff_load): Add casts to remove these marks before passing them
3751 to system-supplied API.
3752
3753 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3754
3755 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3756 This avoids several warnings with gcc -Wstrict-overflow.
3757 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3758 directly, rather than having caller test rule sign. This avoids
3759 some unnecessary tests.
3760 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3761 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3762 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3763
3764 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3765 (xfont_open): Avoid unnecessary tests.
3766
3767 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3768
3769 * composite.h, composite.c (composition_gstring_put_cache):
3770 Use EMACS_INT, not int, for length.
3771
3772 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3773 breaking out part of COMPOSITION_DECODE_RULE.
3774 (COMPOSITION_DECODE_RULE): Use it.
3775 * composite.c (get_composition_id): Remove unused local vars,
3776 by using the new macro.
3777
3778 * textprop.c (set_text_properties_1): Change while to do-while,
3779 since the condition is always true at first.
3780
3781 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3782 (interval_deletion_adjustment): Return unsigned value.
3783 All uses changed.
3784
3785 * process.c (list_processes_1, create_pty, read_process_output):
3786 (exec_sentinel): Remove vars that were set but not used.
3787 (create_pty): Remove unnecessary "volatile"s.
3788 (Fnetwork_interface_info): Avoid possibility of int overflow.
3789 (read_process_output): Do adaptive read buffering even if carryover.
3790 (read_process_output): Simplify nbytes computation if buffered.
3791
3792 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3793
3794 * syntax.c (scan_words): Remove var that was set but not used.
3795 (update_syntax_table): Use unsigned instead of int.
3796
3797 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3798 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3799 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3800
3801 * print.c (print_error_message): Avoid int overflow.
3802
3803 * font.c (font_list_entities): Redo for clarity,
3804 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3805
3806 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3807 (font_score): Avoid potential overflow in diff calculation.
3808
3809 * fns.c (substring_both): Remove var that is set but not used.
3810 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3811
3812 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3813
3814 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3815 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3816 can always succeed if overflow has undefined behavior.
3817
3818 * search.c (boyer_moore, wordify): Remove vars set but not used.
3819 (wordify): Omit three unnecessary tests.
3820
3821 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3822 All callers changed. This avoids the need for an unused var.
3823
3824 * casefiddle.c (casify_region): Remove var that is set but not used.
3825
3826 * dired.c (file_name_completion): Remove var that is set but not used.
3827
3828 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3829
3830 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3831 (Finsert_file_contents): Remove unnecessary code checking fd.
3832
3833 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3834 Check for integer overflow on size calculations.
3835
3836 * buffer.c (Fprevious_overlay_change): Remove var that is set
3837 but not used.
3838
3839 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3840 Remove vars that are set but not used.
3841 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3842 (timer_check_2): Mark vars as initialized.
3843
3844 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3845
3846 * image.c (lookup_image): Remove var that is set but not used.
3847 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3848
3849 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3850 that are set but not used.
3851
3852 * xfns.c (make_invisible_cursor): Don't return garbage
3853 if XCreateBitmapFromData fails (Bug#8410).
3854
3855 * xselect.c (x_get_local_selection, x_handle_property_notify):
3856 Remove vars that are set but not used.
3857
3858 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3859 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3860
3861 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3862 Remove var that is set but not used.
3863 (scroll_bar_windows_size): Now size_t, not int.
3864 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3865 Check for overflow.
3866
3867 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3868 (map_tty_color) [!defined MSDOS]: Likewise.
3869
3870 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3871
3872 * coding.c: Remove vars that are set but not used.
3873 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3874 All callers changed.
3875 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3876 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3877 (decode_coding_charset): Remove vars that are set but not used.
3878
3879 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3880 that is set but not used.
3881
3882 * print.c (print_object): Remove var that is set but not used.
3883
3884 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3885 The gnulib version avoids calling malloc in the usual case,
3886 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3887 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3888 * filelock.c (current_lock_owner): Likewise.
3889 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3890 * sysdep.c: Include allocator.h, careadlinkat.h.
3891 (emacs_no_realloc_allocator): New static constant.
3892 (emacs_readlink): New function.
3893 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3894 ../lib/careadlinkat.h.
3895
3896 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3897
3898 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3899 first non-nil return value).
3900
3901 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3902
3903 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3904 if not defined (Bug#8403).
3905
3906 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3907
3908 * xdisp.c (display_count_lines): Remove parameter `start',
3909 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3910 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3911 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3912 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3913 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3914 and thereabouts. All callers changed.
3915 (get_per_char_metric): Remove parameter `f', unused since
3916 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3917
3918 2011-04-02 Jim Meyering <meyering@redhat.com>
3919
3920 do not dereference NULL upon failed strdup
3921 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3922 (ns_get_family): Likewise.
3923
3924 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3925
3926 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3927
3928 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3929
3930 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3931 later (Bug#8403).
3932
3933 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3934
3935 Add lexical binding.
3936
3937 * window.c (Ftemp_output_buffer_show): New fun.
3938 (Fsave_window_excursion):
3939 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3940
3941 * lread.c (lisp_file_lexically_bound_p): New function.
3942 (Fload): Bind Qlexical_binding.
3943 (readevalloop): Remove `evalfun' arg.
3944 Bind Qinternal_interpreter_environment.
3945 (Feval_buffer): Bind Qlexical_binding.
3946 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3947 Mark as dynamic.
3948 (syms_of_lread): Declare `lexical-binding'.
3949
3950 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3951
3952 * keyboard.c (eval_dyn): New fun.
3953 (menu_item_eval_property): Use it.
3954
3955 * image.c (parse_image_spec): Use Ffunctionp.
3956
3957 * fns.c (concat, mapcar1): Accept byte-code-functions.
3958
3959 * eval.c (Fsetq): Handle lexical vars.
3960 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3961 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3962 (FletX, Flet): Obey lexical binding.
3963 (Fcommandp): Handle closures.
3964 (Feval): New `lexical' arg.
3965 (eval_sub): New function extracted from Feval. Use it almost
3966 everywhere where Feval was used. Look up vars in lexical env.
3967 Handle closures.
3968 (Ffunctionp): Move from subr.el.
3969 (Ffuncall): Handle closures.
3970 (apply_lambda): Remove `eval_flags'.
3971 (funcall_lambda): Handle closures and new byte-code-functions.
3972 (Fspecial_variable_p): New function.
3973 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3974 but without exporting it to Lisp.
3975
3976 * doc.c (Fdocumentation, store_function_docstring):
3977 * data.c (Finteractive_form): Handle closures.
3978
3979 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3980 interactive spec.
3981
3982 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3983 New byte-codes.
3984 (exec_byte_code): New function extracted from Fbyte_code to handle new
3985 calling convention for byte-code-functions. Add new byte-codes.
3986
3987 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3988
3989 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3990
3991 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3992
3993 * xdisp.c (redisplay_internal): Fix prototype.
3994
3995 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3996
3997 * xdisp.c (SCROLL_LIMIT): New macro.
3998 (try_scrolling): Use it when setting scroll_limit.
3999 Limit scrolling to 100 screen lines.
4000 (redisplay_window): Even when falling back on "recentering",
4001 position point in the window according to scroll-conservatively,
4002 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4003
4004 (try_scrolling): When point is above the window, allow searching
4005 as far as scroll_max, or one screenful, to compute vertical
4006 distance from PT to the scroll margin position. This prevents
4007 try_scrolling from unnecessarily failing when
4008 scroll-conservatively is set to a value slightly larger than the
4009 window height. Clean up the case of PT below the margin at bottom
4010 of window: scroll_max can no longer be INT_MAX. When aggressive
4011 scrolling is in use, don't let point enter the opposite scroll
4012 margin as result of the scroll.
4013 (syms_of_xdisp) <scroll-conservatively>: Document the
4014 threshold of 100 lines for never-recentering scrolling.
4015
4016 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4017
4018 * dispextern.h (move_it_by_lines):
4019 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4020 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4021 (message_log_check_duplicate): Remove parameters `prev_bol' and
4022 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4023 (redisplay_internal): Remove parameter `preserve_echo_area',
4024 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4025
4026 * indent.c (Fvertical_motion):
4027 * window.c (window_scroll_pixel_based, Frecenter):
4028 Don't pass `need_y_p' to `move_it_by_lines'.
4029
4030 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4031
4032 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4033 steal a few bits to be more compact.
4034 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4035 Remove unneeded casts.
4036
4037 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4038
4039 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4040
4041 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4042 binding" message (bug#7967).
4043
4044 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4045
4046 Fix more problems found by GCC 4.6.0's static checks.
4047
4048 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4049 Remove unused local var.
4050
4051 * editfns.c (Fmessage_box): Remove unused local var.
4052
4053 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4054 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4055 Omit unused local vars.
4056 * window.c (shrink_windows): Omit unused local var.
4057 * menu.c (digest_single_submenu): Omit unused local var.
4058 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4059 Omit unused local var.
4060
4061 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4062 Don't assume string length fits in int.
4063 (keyremap_step, read_key_sequence): Use size_t for sizes.
4064 (read_key_sequence): Don't check last_real_key_start redundantly.
4065
4066 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4067 instead of alloca (Bug#8344).
4068
4069 * eval.c (Fbacktrace): Don't assume nargs fits in int.
4070 (Fbacktrace_frame): Don't assume nframes fits in int.
4071
4072 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4073
4074 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4075 concerns.
4076
4077 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4078
4079 * cm.c (calccost): Turn while-do into do-while, for clarity.
4080
4081 * keyboard.c (syms_of_keyboard): Use the same style as later
4082 in this function when indexing through an array. This also
4083 works around GCC bug 48267.
4084
4085 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4086
4087 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4088
4089 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4090 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4091
4092 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4093 This avoids undefined behavior on integer overflow, and is a bit
4094 more convenient anyway since it is compared to a size_t variable.
4095
4096 Variadic C functions now count arguments with size_t, not int.
4097 This avoids an unnecessary limitation on 64-bit machines, which
4098 caused (substring ...) to crash on large vectors (Bug#8344).
4099 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4100 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
4101 All variadic functions and their callers changed accordingly.
4102 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4103 * data.c (arith_driver, float_arith_driver): Likewise.
4104 * editfns.c (general_insert_function): Likewise.
4105 * eval.c (struct backtrace.nargs, interactive_p)
4106 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4107 (funcall_lambda, mark_backtrace): Likewise.
4108 * fns.c (concat): Likewise.
4109 * frame.c (x_set_frame_parameters): Likewise.
4110 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4111 0 if not found, not -1. All callers changed.
4112
4113 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4114 (stack_copy_size): Now size_t, not int.
4115 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4116
4117 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4118
4119 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4120 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4121 All callers changed.
4122
4123 * lisp.h (multibyte_char_to_unibyte):
4124 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4125 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4126 * character.h (CHAR_TO_BYTE8):
4127 * cmds.c (internal_self_insert):
4128 * editfns.c (general_insert_function):
4129 * keymap.c (push_key_description):
4130 * search.c (Freplace_match):
4131 * xdisp.c (message_dolog, set_message_1): All callers changed.
4132
4133 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4134
4135 * keyboard.c (safe_run_hook_funcall): New function.
4136 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4137 don't set the hook to nil, but remove the offending function instead.
4138 (Qcommand_hook_internal): Remove, unused.
4139 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4140 Vcommand_hook_internal.
4141
4142 * eval.c (enum run_hooks_condition): Remove.
4143 (funcall_nil, funcall_not): New functions.
4144 (run_hook_with_args): Call each function through a `funcall' argument.
4145 Remove `cond' argument, now redundant.
4146 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4147 (Frun_hook_with_args_until_failure): Adjust accordingly.
4148 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4149
4150 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4151
4152 * dispextern.h (string_buffer_position): Remove declaration.
4153
4154 * print.c (strout): Remove parameter `multibyte', unused since
4155 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4156
4157 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4158 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4159 All callers changed.
4160
4161 * w32.c (_wsa_errlist): Use braces for struct initializers.
4162
4163 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4164 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4165 All callers changed.
4166 (string_buffer_position): Likewise. Also, make static (it's never
4167 used outside xdisp.c).
4168 (cursor_row_p): Remove parameter `w', unused since
4169 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4170 (decode_mode_spec): Remove parameter `precision', introduced during
4171 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4172 All callers changed.
4173
4174 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4175
4176 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4177
4178 2011-03-27 Anders Lindgren <andlind@gmail.com>
4179
4180 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4181 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4182 (ns_update_auto_hide_menu_bar): New functions.
4183 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4184 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4185 ns_constrain_all_frames.
4186 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4187 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4188
4189 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4190
4191 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4192
4193 2011-03-27 Glenn Morris <rgm@gnu.org>
4194
4195 * syssignal.h: Replace RETSIGTYPE with void.
4196 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4197 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4198 Replace SIGTYPE with void everywhere.
4199 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4200 * s/template.h (SIGTYPE): Remove commented out definition.
4201
4202 2011-03-26 Eli Zaretskii <eliz@gnu.org>
4203
4204 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4205 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4206
4207 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
4208
4209 * w32.c (read_unc_volume): Use parameter `henum', instead of
4210 global variable `wget_enum_handle'.
4211
4212 * keymap.c (describe_vector): Remove parameters `indices' and
4213 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4214 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4215
4216 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4217
4218 * keyboard.c (timer_check): Remove parameter `do_it_now',
4219 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4220 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4221 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4222
4223 * keyboard.c (read_char):
4224 * w32menu.c (w32_menu_display_help):
4225 * xmenu.c (show_help_event, menu_help_callback):
4226 Adjust calls to `show_help_echo'.
4227
4228 * gtkutil.c (xg_maybe_add_timer):
4229 * keyboard.c (readable_events):
4230 * process.c (wait_reading_process_output):
4231 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4232
4233 * insdel.c (adjust_markers_gap_motion):
4234 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4235 (gap_left, gap_right): Don't call it.
4236
4237 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
4238
4239 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4240 incurred during fontification.
4241
4242 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4243
4244 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4245 (DEFVAR_PER_BUFFER): Don't pass it.
4246
4247 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4248 (scrolling_window): Don't pass it.
4249
4250 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4251
4252 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4253
4254 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4255 and `suffix'.
4256 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4257 of variables specific to SELinux and computation of `encoded_absname'.
4258
4259 * image.c (XPutPixel): Remove unused variable `height'.
4260
4261 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4262
4263 * unexw32.c (get_section_info): Remove unused variable `section'.
4264
4265 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4266 (system_process_attributes): Remove unused variable `sess'.
4267 (sys_read): Remove unused variable `err'.
4268
4269 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4270 (w32_wnd_proc): Remove unused variable `isdead'.
4271 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4272 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4273 (x_create_tip_frame): Remove unused variable `tem'.
4274
4275 * w32inevt.c (w32_console_read_socket):
4276 Remove unused variable `no_events'.
4277
4278 * w32term.c (x_draw_composite_glyph_string_foreground):
4279 Remove unused variable `width'.
4280
4281 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
4282
4283 * w32term.c (x_set_glyph_string_clipping):
4284 Don't pass uninitialized region to CombineRgn.
4285
4286 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
4287
4288 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4289 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4290 (Fx_close_connection): Remove unused variable `i'.
4291
4292 * w32font.c (w32font_draw): Return number of glyphs.
4293 (w32font_open_internal): Remove unused variable `i'.
4294 (w32font_driver): Add missing initializer.
4295
4296 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4297 (fill_in_menu): Remove unused variable `items_added'.
4298
4299 * w32term.c (last_mouse_press_frame): Remove static global variable.
4300 (w32_clip_to_row): Remove unused variable `f'.
4301 (x_delete_terminal): Remove unused variable `i'.
4302
4303 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4304 (NOTHING): Remove unused static global variable.
4305 (uniscribe_check_otf): Remove unused variable `table'.
4306 (uniscribe_font_driver): Add missing initializers.
4307
4308 2011-03-23 Julien Danjou <julien@danjou.info>
4309
4310 * term.c (Fsuspend_tty, Fresume_tty):
4311 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4312 * window.c (temp_output_buffer_show):
4313 * insdel.c (signal_before_change):
4314 * frame.c (Fhandle_switch_frame):
4315 * fileio.c (Fdo_auto_save):
4316 * emacs.c (Fkill_emacs):
4317 * editfns.c (save_excursion_restore):
4318 * cmds.c (internal_self_insert):
4319 * callint.c (Fcall_interactively):
4320 * buffer.c (Fkill_all_local_variables):
4321 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4322 Use Frun_hooks.
4323 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
4324 unconditionnaly since it does the check itself.
4325
4326 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
4327
4328 Fix more problems found by GCC 4.5.2's static checks.
4329
4330 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4331 the first time through the loop, since we know p0 < p1 then.
4332 This also avoids a gcc -Wstrict-overflow warning.
4333
4334 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4335 leading to a memory leak, possible in functions like
4336 load_charset_map_from_file that can allocate an unbounded number
4337 of objects (Bug#8318).
4338
4339 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4340 that could (at least in theory) be that large.
4341
4342 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4343 This is less likely to overflow, and avoids undefined behavior if
4344 overflow does occur. All callers changed. Use strtoul to scan
4345 for the unsigned long integer.
4346 (pint2hrstr): Simplify and tune code slightly.
4347 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
4348
4349 * scroll.c (do_scrolling): Work around GCC bug 48228.
4350 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4351
4352 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4353 This also avoids a warning with gcc -Wstrict-overflow.
4354 (validate_x_resource_name): Simplify count usage.
4355 This also avoids a warning with gcc -Wstrict-overflow.
4356
4357 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4358 fail (Bug#8306).
4359
4360 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
4361
4362 * process.c (Fmake_network_process): Use socklen_t, not int,
4363 where POSIX says socklen_t is required in portable programs.
4364 This fixes a porting bug on hosts like 64-bit HP-UX, where
4365 socklen_t is wider than int (Bug#8277).
4366 (Fmake_network_process, server_accept_connection):
4367 (wait_reading_process_output, read_process_output):
4368 Likewise.
4369
4370 * process.c: Rename or move locals to avoid shadowing.
4371 (list_processes_1, Fmake_network_process):
4372 (read_process_output_error_handler, exec_sentinel_error_handler):
4373 Rename or move locals.
4374 (Fmake_network_process): Define label "retry_connect" only if needed.
4375 (Fnetwork_interface_info): Fix pointer signedness.
4376 (process_send_signal): Add cast to avoid pointer signedness problem.
4377 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
4378 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
4379
4380 Make tparam.h and terminfo.c consistent.
4381 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4382 Include tparam.h instead, since it declares them.
4383 * cm.h (PC): Remove extern decl; tparam.h now does this.
4384 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4385 * terminfo.c: Include tparam.h, to check interfaces.
4386 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4387 (tparam): Adjust signature to match interface in tparam.h;
4388 this removes some undefined behavior. Check that outstring and len
4389 are zero, which they always are with Emacs.
4390 * tparam.h (PC, BC, UP): New extern decls.
4391
4392 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
4393 (xftfont_open): Rename locals to avoid shadowing.
4394
4395 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
4396 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4397 (OTF_TAG_SYM): Omit macro if not needed.
4398 (ftfont_list): Remove unused local.
4399 (get_adstyle_property, ftfont_pattern_entity):
4400 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4401 Rename locals to avoid shadowing.
4402
4403 * xfont.c (xfont_list_family): Mark var as initialized.
4404
4405 * xml.c (make_dom): Now static.
4406
4407 * composite.c (composition_compute_stop_pos): Rename local to
4408 avoid shadowing.
4409 (composition_reseat_it): Remove unused locals.
4410 (find_automatic_composition, composition_adjust_point): Likewise.
4411 (composition_update_it): Mark var as initialized.
4412 (find_automatic_composition): Mark vars as initialized,
4413 with a FIXME (Bug#8290).
4414
4415 character.h: Rename locals to avoid shadowing.
4416 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4417 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4418 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4419 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4420 to avoid shadowing.
4421
4422 * textprop.c (property_change_between_p): Remove; unused.
4423
4424 * intervals.c (interval_start_pos): Now static.
4425
4426 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4427
4428 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4429 Rename locals to avoid shadowing.
4430
4431 * sound.c (wav_play, au_play, Fplay_sound_internal):
4432 Fix pointer signedness.
4433 (alsa_choose_format): Remove unused local var.
4434 (wav_play): Initialize a variable to 0, to prevent undefined
4435 behavior (Bug#8278).
4436
4437 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4438
4439 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4440
4441 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4442 clobbering (Bug#8298).
4443 * sysdep.c (sys_subshell): Likewise.
4444 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
4445
4446 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4447 This should get cleaned up, so that child_setup has the
4448 same signature on all platforms.
4449
4450 * callproc.c (call_process_cleanup): Now static.
4451 (relocate_fd): Rename locals to avoid shadowing.
4452
4453 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
4454
4455 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4456 not to be necessary, and produces flickering.
4457
4458 2011-03-20 Glenn Morris <rgm@gnu.org>
4459
4460 * config.in: Remove file.
4461
4462 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
4463
4464 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4465 are now in src/globals.h.
4466 (syms_of_minibuf): Remove spurious & from previous change.
4467
4468 2011-03-20 Leo <sdl.web@gmail.com>
4469
4470 * minibuf.c (completing-read-function): New variable.
4471 (completing-read-default): Rename from completing-read.
4472 (completing-read): Call completing-read-function.
4473
4474 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4475
4476 * xfaces.c (Fx_load_color_file):
4477 Read color file from absolute filename (bug#8250).
4478
4479 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4480
4481 * makefile.w32-in: Update dependencies.
4482
4483 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4484
4485 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4486
4487 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4488
4489 Fix more problems found by GCC 4.5.2's static checks.
4490
4491 * process.c (make_serial_process_unwind, send_process_trap):
4492 (sigchld_handler): Now static.
4493
4494 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4495 That way, the code declares only the vars that it needs.
4496 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4497 * s/cygwin.h (PTY_ITERATION): Likewise.
4498 * s/darwin.h (PTY_ITERATION): Likewise.
4499 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4500
4501 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4502 * process.c (allocate_pty): Don't declare stb unless it's needed.
4503
4504 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4505 (CONSTANTLIM): Remove; unused.
4506 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4507 Define only if needed.
4508
4509 * unexelf.c (unexec): Name an expression,
4510 to avoid gcc -Wbad-function-cast warning.
4511 Use a different way to cause a compilation error if anyone uses
4512 n rather than nn, a way that does not involve shadowing.
4513 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4514
4515 * deps.mk (unexalpha.o): Remove; unused.
4516
4517 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4518 * unexec.h: New file.
4519 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4520 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4521 Depend on unexec.h.
4522 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4523 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4524 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4525 Change as necessary to match prototype in unexec.h.
4526
4527 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4528 shadowing.
4529 (back_comment, skip_chars): Mark vars as initialized.
4530
4531 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4532 Rename locals to avoid shadowing.
4533
4534 * lread.c (read1): Rewrite so as not to use empty "else".
4535 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4536
4537 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4538
4539 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4540 warning when compiling print.c.
4541
4542 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4543 instead of using an uninitialized var.
4544 (font_sort_entities): Mark var as initialized.
4545
4546 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4547
4548 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4549 pointers to constants.
4550 (font_parse_fcname): Remove unused vars.
4551 (font_delete_unmatched): Now static.
4552 (font_get_spec): Remove; unused.
4553 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4554 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4555 Rename or move locals to avoid shadowing.
4556
4557 * fns.c (require_nesting_list, require_unwind): Now static.
4558 (Ffillarray): Rename locals to avoid shadowing.
4559
4560 * floatfns.c (domain_error2): Define only if needed.
4561 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4562
4563 * alloc.c (mark_backtrace): Move decl from here ...
4564 * lisp.h: ... to here, so that it can be checked.
4565
4566 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4567 (Fdefvar): Rewrite so as not to use empty "else".
4568 (lisp_indirect_variable): Name an expression,
4569 to avoid gcc -Wbad-function-cast warning.
4570 (Fdefvar): Rename locals to avoid shadowing.
4571
4572 * callint.c (quotify_arg, quotify_args): Now static.
4573 (Fcall_interactively): Rename locals to avoid shadowing.
4574 Use const pointer when appropriate.
4575
4576 * lisp.h (get_system_name, get_operating_system_release):
4577 Move decls here, to check interfaces.
4578 * process.c (get_operating_system_release): Move decl to lisp.h.
4579 * xrdb.c (get_system_name): Likewise.
4580 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4581 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4582 some of which prompt warnings from gcc -Wbad-function-cast.
4583 (Fformat_time_string, Fencode_time, Finsert_char):
4584 (Ftranslate_region_internal, Fformat):
4585 Rename or remove local vars to avoid shadowing.
4586 (Ftranslate_region_internal): Mark var as initialized.
4587
4588 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4589 avoid shadowing.
4590
4591 * lisp.h (eassert): Check that the argument compiles, even if
4592 ENABLE_CHECKING is not defined.
4593
4594 * data.c (Findirect_variable): Name an expression, to avoid
4595 gcc -Wbad-function-cast warning.
4596 (default_value, arithcompare, arith_driver, arith_error): Now static.
4597 (store_symval_forwarding): Rename local to avoid shadowing.
4598 (Fmake_variable_buffer_local, Fmake_local_variable):
4599 Mark variables as initialized.
4600 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4601
4602 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4603 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4604 Rename locals to avoid shadowing.
4605 (mark_stack): Move local variables into the #ifdef region where
4606 they're used.
4607 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4608 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4609 needed otherwise.
4610 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4611 (GC_STRING_CHARS): Remove; not used.
4612 (Fmemory_limit): Cast sbrk's returned value to char *.
4613
4614 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4615 avoids undefined behavior in theory.
4616
4617 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4618
4619 Use functions, not macros, for up- and down-casing (Bug#8254).
4620 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4621 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4622 to use the following functions instead of these macros.
4623 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4624 EMACS_INT, since callers assume the returned value fits in int.
4625 (upcase1): Likewise, for UPCASE_TABLE.
4626 (uppercasep, lowercasep, upcase): New static inline functions.
4627 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4628 the race-condition problem in the old DOWNCASE.
4629
4630 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4631 Rename locals to avoid shadowing.
4632 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4633 (regex_compile, re_search_2, re_match_2_internal):
4634 Remove unused local vars.
4635 (FREE_VAR): Rewrite so as not to use empty "else",
4636 which gcc can warn about.
4637 (regex_compile, re_match_2_internal): Mark locals as initialized.
4638 (RETALLOC_IF): Define only if needed.
4639 (WORDCHAR_P): Likewise. This one is never needed, but is used
4640 only in a comment talking about a compiler bug, so put inside
4641 the #if 0 of that comment.
4642 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4643 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4644 Remove; unused.
4645
4646 * search.c (boyer_moore): Rename locals to avoid shadowing.
4647 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4648 (PREV_CHAR_BOUNDARY): Likewise.
4649
4650 * search.c (simple_search): Remove unused var.
4651
4652 * dired.c (compile_pattern): Move decl from here ...
4653 * lisp.h: ... to here, so that it can be checked.
4654 (struct re_registers): New forward decl.
4655
4656 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4657
4658 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4659 All uses changed.
4660 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4661 Rename locals to avoid shadowing.
4662 (Fvertical_motion): Mark locals as initialized.
4663
4664 * casefiddle.c (casify_object, casify_region): Now static.
4665 (casify_region): Mark local as initialized.
4666
4667 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4668
4669 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4670 New macros, so that the caller can use some names other than
4671 gcpro1, gcpro2, etc.
4672 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4673 of the new macros.
4674 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4675 argument, for consistency with GCPRO2_VAR, etc: it is now the
4676 prefix of the variable, not the variable itself. All uses
4677 changed.
4678 * dired.c (directory_files_internal, file_name_completion):
4679 Rename locals to avoid shadowing.
4680
4681 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4682 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4683 dired.c's scmp function, had undefined behavior.
4684 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4685 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4686 * buffer.h: ... to here, because these macros use current_buffer,
4687 and the new implementation with inline functions needs to have
4688 current_buffer in scope now, rather than later when the macros
4689 are used.
4690 (downcase, upcase1): New static inline functions.
4691 (DOWNCASE, UPCASE1): Reimplement using these functions.
4692 This avoids undefined behavior in expressions like
4693 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4694 from race conditions in accessing the global variables
4695 case_temp1 and case_temp2.
4696 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4697 * lisp.h (case_temp1, case_temp2): Remove their decls.
4698 * character.h (ASCII_CHAR_P): Move from here ...
4699 * lisp.h: ... to here, so that the inline functions mentioned
4700 above can use them.
4701
4702 * dired.c (directory_files_internal_unwind): Now static.
4703
4704 * fileio.c (file_name_as_directory, directory_file_name):
4705 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4706 Now static.
4707 (file_name_as_directory): Use const pointers when appropriate.
4708 (Fexpand_file_name): Likewise. In particular, newdir might
4709 point at constant storage, so make it a const pointer.
4710 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4711 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4712 signedness issues.
4713 (Fset_file_times, Finsert_file_contents, auto_save_error):
4714 Rename locals to avoid shadowing.
4715
4716 * minibuf.c (choose_minibuf_frame_1): Now static.
4717 (Ftry_completion, Fall_completions): Rename or remove locals
4718 to avoid shadowing.
4719
4720 * marker.c (bytepos_to_charpos): Remove; unused.
4721
4722 * lisp.h (verify_bytepos, count_markers): New decls,
4723 so that gcc does not warn that these functions aren't declared.
4724
4725 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4726 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4727 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4728 (copy_text): Remove unused local var.
4729
4730 * filelock.c (within_one_second): Now static.
4731 (lock_file_1): Rename local to avoid shadowing.
4732
4733 * buffer.c (fix_overlays_before): Mark locals as initialized.
4734 (fix_start_end_in_overlays): Likewise. This function should be
4735 simplified by using pointers-to-pointers, but that's a different
4736 matter.
4737 (switch_to_buffer_1): Now static.
4738 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4739 (report_overlay_modification): Rename locals to avoid shadowing.
4740
4741 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4742 Fix pointer signedness issue.
4743 (sys_subshell): Mark local as volatile if checking for lint,
4744 to suppress a gcc -Wclobbered warning that does not seem to be right.
4745 (MAXPATHLEN): Define only if needed.
4746
4747 * process.c (serial_open, serial_configure): Move decls from here ...
4748 * systty.h: ... to here, so that they can be checked.
4749
4750 * fns.c (get_random, seed_random): Move extern decls from here ...
4751 * lisp.h: ... to here, so that they can be checked.
4752
4753 * sysdep.c (reset_io): Now static.
4754 (wait_for_termination_signal): Remove; unused.
4755
4756 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4757 (copy_keymap_item, append_key, push_text_char_description):
4758 Now static.
4759 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4760 (DENSE_TABLE_SIZE): Remove; unused.
4761 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4762 (describe_map_tree):
4763 Rename locals to avoid shadowing.
4764
4765 * keyboard.c: Declare functions static if they are not used elsewhere.
4766 (echo_char, echo_dash, cmd_error, top_level_2):
4767 (poll_for_input, handle_async_input): Now static.
4768 (read_char, kbd_buffer_get_event, make_lispy_position):
4769 (make_lispy_event, make_lispy_movement, apply_modifiers):
4770 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4771 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4772 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4773 (read_key_sequence, read_char): Mark locals as initialized.
4774 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4775
4776 * keyboard.h (make_ctrl_char): New decl.
4777 (mark_kboards): Move decl here ...
4778 * alloc.c (mark_kboards): ... from here.
4779
4780 * lisp.h (force_auto_save_soon): New decl.
4781
4782 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4783 (DEFINE_DUMMY_FUNCTION): New macro.
4784 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4785 Use it.
4786 (main): Add casts to avoid warnings
4787 if GCC considers string literals to be constants.
4788
4789 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4790
4791 * dbusbind.c: Pointer signedness fixes.
4792 (xd_signature, xd_append_arg, xd_initialize):
4793 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4794 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4795 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4796 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4797
4798 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4799 if GCC considers string literals to be constants.
4800 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4801
4802 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4803
4804 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4805 (print_preprocess, print_object): New macro to fix last change.
4806
4807 * print.c (print_preprocess): Don't forget font objects.
4808
4809 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4810
4811 * emacs.c (USAGE3): Doc fixes.
4812
4813 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4814
4815 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4816 structure.
4817
4818 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4819
4820 * lisp.h (VWindow_system, Qfile_name_history):
4821 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4822 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4823 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4824
4825 * w32select.c: Don't #include "keyboard.h".
4826 (run_protected): Add extern declaration for waiting_for_input.
4827
4828 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4829 * w32console.c (detect_input_pending, read_input_pending)
4830 (encode_terminal_code):
4831 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4832 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4833 (w32_system_caret_y, Qfile_name_history):
4834 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4835 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4836 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4837 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4838 * w32proc.c (Qlocal, report_file_error):
4839 * w32term.c (Vwindow_system, updating_frame):
4840 * w32uniscribe.c (initialized, uniscribe_font_driver):
4841 Remove unneeded extern declarations.
4842
4843 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4844
4845 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4846
4847 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4848
4849 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4850 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4851 These macros can no longer be used for assignment.
4852
4853 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4854 Assign struct members directly, instead of using BUF_BEGV etc.
4855 (record_buffer_markers, fetch_buffer_markers): New functions for
4856 recording and fetching special buffer markers.
4857 (set_buffer_internal_1, set_buffer_temp): Use them.
4858
4859 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4860
4861 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4862
4863 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4864 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4865
4866 * xdisp.c (hscroll_window_tree):
4867 (reconsider_clip_changes): Use PT instead of BUF_PT.
4868
4869 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4870
4871 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4872 $(EMACS_ROOT)/lib/intprops.h.
4873
4874 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4875
4876 Fix more problems found by GCC 4.5.2's static checks.
4877
4878 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4879 to unsigned char * to avoid compiler diagnostic.
4880 (xg_free_frame_widgets): Make it clear that a local variable is
4881 needed only if USE_GTK_TOOLTIP.
4882 (gdk_window_get_screen): Make it clear that this macro is needed
4883 only if USE_GTK_TOOLTIP.
4884 (int_gtk_range_get_value): New function, which avoids a diagnostic
4885 from gcc -Wbad-function-cast.
4886 (xg_set_toolkit_scroll_bar_thumb): Use it.
4887 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4888 diagnostic from gcc -Wbad-function-cast.
4889 (get_utf8_string, xg_get_file_with_chooser):
4890 Rename locals to avoid shadowing.
4891 (create_dialog): Move locals to avoid shadowing.
4892
4893 * xgselect.c (xg_select): Remove unused var.
4894
4895 * image.c (four_corners_best): Mark locals as initialized.
4896 (gif_load): Initialize transparent_p to zero (Bug#8238).
4897 Mark another local as initialized.
4898 (my_png_error, my_error_exit): Mark with NO_RETURN.
4899
4900 * image.c (clear_image_cache): Now static.
4901 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4902 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4903 (x_edge_detection): Remove unnecessary cast that
4904 gcc -Wbad-function-cast diagnoses.
4905 (gif_load): Fix pointer signedness.
4906 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4907 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4908
4909 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4910
4911 Improve quality of tests for time stamp overflow.
4912 For example, without this patch (encode-time 0 0 0 1 1
4913 1152921504606846976) returns the obviously-bogus value (-948597
4914 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4915 reports time overflow. See
4916 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4917 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4918 * editfns.c: Include limits.h and intprops.h.
4919 (TIME_T_MIN, TIME_T_MAX): New macros.
4920 (time_overflow): Move earlier, to before first use.
4921 (hi_time, lo_time): New functions, for an accurate test for
4922 out-of-range times.
4923 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4924 (Fget_internal_run_time): Don't assume time_t fits in int.
4925 (make_time): Use list2 instead of Fcons twice.
4926 (Fdecode_time): More accurate test for out-of-range times.
4927 (check_tm_member): New function.
4928 (Fencode_time): Use it, to test for out-of-range times.
4929 (lisp_time_argument): Don't rely on undefined left-shift and
4930 right-shift behavior when checking for time stamp overflow.
4931
4932 * editfns.c (time_overflow): New function, refactoring common code.
4933 (Fformat_time_string, Fdecode_time, Fencode_time):
4934 (Fcurrent_time_string): Use it.
4935
4936 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4937 * dired.c (make_time): Move to ...
4938 * editfns.c (make_time): ... here.
4939 * systime.h: Note the move.
4940
4941 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4942
4943 * fringe.c (update_window_fringes): Remove unused variables.
4944
4945 * unexmacosx.c (copy_data_segment): Also copy __got section.
4946 (Bug#8223)
4947
4948 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4949
4950 * termcap.c [MSDOS]: Include "msdos.h".
4951 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4952 Constify `char *' arguments and their references according to
4953 prototypes in tparam.h.
4954
4955 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4956
4957 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4958 Adapt all references accordingly.
4959
4960 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4961
4962 2011-03-11 Tom Tromey <tromey@redhat.com>
4963
4964 * buffer.c (syms_of_buffer): Remove obsolete comment.
4965
4966 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4967
4968 * termhooks.h (encode_terminal_code): Declare prototype.
4969
4970 * msdos.c (encode_terminal_code): Don't declare prototype.
4971
4972 * term.c (encode_terminal_code): Now external again, used by
4973 w32console.c and msdos.c.
4974
4975 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4976 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4977
4978 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4979
4980 Fix some minor problems found by GCC 4.5.2's static checks.
4981
4982 * fringe.c (update_window_fringes): Mark locals as initialized
4983 (Bug#8227).
4984 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4985
4986 * alloc.c (mark_fringe_data): Move decl from here ...
4987 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4988 to check its interface.
4989 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4990
4991 * fontset.c (free_realized_fontset): Now static.
4992 (Fset_fontset_font): Rename local to avoid shadowing.
4993 (fontset_font): Mark local as initialized.
4994 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4995
4996 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4997
4998 * xselect.c (x_disown_buffer_selections): Remove; not used.
4999 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
5000 (x_own_selection, Fx_disown_selection_internal): Rename locals
5001 to avoid shadowing.
5002 (x_handle_dnd_message): Remove local to avoid shadowing.
5003
5004 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5005 so that the caller can use some name other than gcpro1.
5006 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
5007 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5008 (Fx_backspace_delete_keys_p):
5009 Use them to avoid shadowing, and rename vars to avoid shadowing.
5010 (x_decode_color, x_set_name, x_window): Now static.
5011 (Fx_create_frame): Add braces to silence GCC warning.
5012 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
5013 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5014 Remove unused locals.
5015 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5016 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5017 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5018 macros.
5019
5020 * xterm.h (x_mouse_leave): New decl.
5021
5022 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5023 Remove unused functions.
5024 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5025 (x_calc_absolute_position): Now static.
5026 (XTread_socket): Don't define label "out" unless it's used.
5027 Don't declare local "event" unless it's used.
5028 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5029 unless they are used.
5030 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5031 (x_fatal_error_signal): Remove; not used.
5032 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5033 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5034 (x_error_catcher, x_connection_closed, x_error_handler):
5035 (x_error_quitter, xembed_send_message, x_iconify_frame):
5036 (my_log_handler): Rename locals to avoid shadowing.
5037 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
5038 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
5039
5040 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5041 Rename or move locals to avoid shadowing.
5042 (tty_defined_color, merge_face_heights): Now static.
5043 (free_realized_faces_for_fontset): Remove; not used.
5044 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5045 does not deduce is never used uninitialized.
5046 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5047 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
5048
5049 * terminal.c (store_terminal_param): Now static.
5050
5051 * xmenu.c (menu_highlight_callback): Now static.
5052 (set_frame_menubar): Remove unused local.
5053 (xmenu_show): Rename parameter to avoid shadowing.
5054 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5055 since they might point to immutable storage.
5056 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5057 since it's unused otherwise.
5058
5059 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
5060 Add a FIXME, since the code still doesn't look right. (Bug#8215)
5061 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5062 avoids a gcc -Wuninitialized diagnostic.
5063 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
5064 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5065 does not deduce are never used uninitialized.
5066
5067 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5068
5069 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
5070 * window.c (window_loop, size_window):
5071 (run_window_configuration_change_hook, enlarge_window): Likewise.
5072
5073 * window.c (display_buffer): Now static.
5074 (size_window): Mark variables that gcc -Wuninitialized
5075 does not deduce are never used uninitialized.
5076 * window.h (check_all_windows): New decl, to forestall
5077 gcc -Wmissing-prototypes diagnostic.
5078 * dispextern.h (bidi_dump_cached_states): Likewise.
5079
5080 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5081 shadowing.
5082 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
5083 Include <limits.h>.
5084 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5085 and to avoid gcc -Wuninitialized warning.
5086 (load_charset_map): Mark variables that gcc -Wuninitialized
5087 does not deduce are never used uninitialized.
5088 (load_charset): Abort instead of using uninitialized var (Bug#8229).
5089
5090 * coding.c (coding_set_source, coding_set_destination):
5091 Use "else { /* comment */ }" rather than "else /* comment */;"
5092 for clarity, and to avoid gcc -Wempty-body warning.
5093 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5094 a block, when the outer 'i' will do.
5095 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5096 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5097 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5098 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5099 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5100 Rename locals to avoid shadowing.
5101 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
5102 * coding.c (emacs_mule_char, encode_invocation_designation):
5103 Now static, since they're not used elsewhere.
5104 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
5105 (decode_coding_object, encode_coding_object, detect_coding_system):
5106 (decode_coding_emacs_mule): Mark variables that gcc
5107 -Wuninitialized does not deduce are never used uninitialized.
5108 (detect_coding_iso_2022): Initialize a local variable that might
5109 be used uninitialized. Leave a FIXME because it's not clear that
5110 this initialization is needed. (Bug#8211)
5111 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5112 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5113 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5114 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5115 Remove unused macros.
5116
5117 * category.c (hash_get_category_set): Remove unused local var.
5118 (copy_category_table): Now static, since it's not used elsewhere.
5119 * character.c (string_count_byte8): Likewise.
5120
5121 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5122 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5123
5124 * chartab.c (copy_sub_char_table): Now static, since it's not used
5125 elsewhere.
5126 (sub_char_table_ref_and_range, char_table_ref_and_range):
5127 Rename locals to avoid shadowing.
5128 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
5129
5130 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
5131 (BIDI_BOB): Remove unused macro.
5132
5133 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5134 deduce are never used uninitialized.
5135 * term.c (encode_terminal_code): Likewise.
5136
5137 * term.c (encode_terminal_code): Now static. Remove unused local.
5138
5139 * tparam.h: New file.
5140 * term.c, tparam.h: Include it.
5141 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5142 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5143 Move these decls to tparam.h, and make them agree with what
5144 is actually in tparam.c. The previous trick of using incompatible
5145 decls in different modules does not conform to the C standard.
5146 All callers of tparam changed to use tparam's actual API.
5147 * tparam.c (tparam1, tparam, tgoto):
5148 Use const pointers where appropriate.
5149
5150 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5151 * cm.h (struct cm): Likewise.
5152 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5153 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5154 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5155 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5156 (turn_on_face, init_tty): Likewise.
5157 * termchar.h (struct tty_display_info): Likewise.
5158
5159 * term.c (term_mouse_position): Rename local to avoid shadowing.
5160
5161 * alloc.c (mark_ttys): Move decl from here ...
5162 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5163
5164 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5165
5166 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5167
5168 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
5169
5170 * search.c (compile_pattern_1): Remove argument regp, unused since
5171 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5172 (compile_pattern): Don't pass it.
5173
5174 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5175
5176 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5177 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5178 for ! HAVE_GTK3.
5179 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5180
5181 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5182
5183 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5184 gdk_window_get_screen, gdk_window_get_geometry,
5185 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5186 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5187 (xg_get_pixbuf_from_pixmap): New function.
5188 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5189 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5190 Call xg_get_pixbuf_from_pixmap instead of
5191 gdk_pixbuf_get_from_drawable.
5192 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5193 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5194 (xg_check_special_colors): Use GtkStyleContext and its functions
5195 for HAVE_GTK3.
5196 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5197 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5198 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5199 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5200 Call gtk_widget_get_preferred_size.
5201 (xg_frame_resized): gdk_window_get_geometry only takes 5
5202 parameters.
5203 (xg_win_to_widget, xg_event_is_for_menubar):
5204 Call gdk_x11_window_lookup_for_display.
5205 (xg_set_widget_bg): New function.
5206 (delete_cb): New function.
5207 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5208 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5209 (xg_set_background_color): Call xg_set_widget_bg.
5210 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5211 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5212 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5213 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5214 if ! HAVE_GTK3.
5215 (update_frame_tool_bar): Call gtk_widget_hide.
5216 (xg_initialize): Use GDK_KEY_g.
5217
5218 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5219 if ! HAVE_GTK3
5220 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5221
5222 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5223 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5224 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5225
5226 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
5227
5228 * w32xfns.c (select_palette): Check success of RealizePalette against
5229 GDI_ERROR, not zero.
5230
5231 See ChangeLog.11 for earlier changes.
5232
5233 ;; Local Variables:
5234 ;; coding: utf-8
5235 ;; End:
5236
5237 Copyright (C) 2011 Free Software Foundation, Inc.
5238
5239 This file is part of GNU Emacs.
5240
5241 GNU Emacs is free software: you can redistribute it and/or modify
5242 it under the terms of the GNU General Public License as published by
5243 the Free Software Foundation, either version 3 of the License, or
5244 (at your option) any later version.
5245
5246 GNU Emacs is distributed in the hope that it will be useful,
5247 but WITHOUT ANY WARRANTY; without even the implied warranty of
5248 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5249 GNU General Public License for more details.
5250
5251 You should have received a copy of the GNU General Public License
5252 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.