Reduce x-selection-timeout to 5s, and add a message for clipboard manager saving.
[bpt/emacs.git] / src / ChangeLog
1 2012-02-25 Chong Yidong <cyd@gnu.org>
2
3 * xselect.c (Fx_selection_exists_p): Doc fix.
4 (x_clipboard_manager_save_all): Print an informative message
5 before saving to clipboard manager.
6
7 2012-02-24 Chong Yidong <cyd@gnu.org>
8
9 * keyboard.c (process_special_events): Handle all X selection
10 requests in kbd_buffer, not just the next one (Bug#8869).
11
12 2012-02-23 Chong Yidong <cyd@gnu.org>
13
14 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
15 call when setting menu-bar-lines and tool-bar-lines parameters.
16 (unwind_create_frame_1): New helper function.
17
18 * window.c (inhibit_window_configuration_change_hook): New var.
19 (run_window_configuration_change_hook): Obey it.
20 (syms_of_window): Initialize it.
21
22 2012-02-22 Chong Yidong <cyd@gnu.org>
23
24 * xterm.c (x_draw_image_relief): Add missing type check for
25 Vtool_bar_button_margin (Bug#10743).
26
27 2012-02-21 Chong Yidong <cyd@gnu.org>
28
29 * fileio.c (Vfile_name_handler_alist): Doc fix.
30
31 * buffer.c (Fget_file_buffer): Protect against invalid file
32 handler return value.
33
34 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
35
36 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
37 when computing $valmask.
38
39 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
40 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
41 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
42 It's useless in that case, and it can cause problems on hosts
43 that allocate halves of EMACS_INT values separately.
44 Reported by Dan Horák. Diagnosed by Andreas Schwab in
45 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
46 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
47 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
48 it avoids undefined behavior on hosts where shifting right by more
49 than the word width has undefined behavior.
50
51 2012-02-19 Chong Yidong <cyd@gnu.org>
52
53 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
54 (Funhandled_file_name_directory, Ffile_name_as_directory)
55 (Fdirectory_file_name, Fexpand_file_name)
56 (Fsubstitute_in_file_name): Protect against invalid file handler
57 return values (Bug#10845).
58
59 2012-02-18 Eli Zaretskii <eliz@gnu.org>
60
61 * .gdbinit (pitx): Fix incorrect references to fields of the
62 iterator stack.
63
64 2012-02-17 Chong Yidong <cyd@gnu.org>
65
66 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
67
68 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
69
70 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
71 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
72
73 2012-02-15 Chong Yidong <cyd@gnu.org>
74
75 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
76 marked as special. Also, starting docstrings with * is obsolete.
77
78 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
79
80 * gnutls.c (emacs_gnutls_write): Fix last change.
81
82 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
83
84 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
85 send_process.
86
87 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
88
89 * keymap.c (Fsingle_key_description): Handle char ranges.
90
91 2012-02-12 Chong Yidong <cyd@gnu.org>
92
93 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
94 as that creates a dangerous corner case.
95
96 * window.c (Fdelete_window_internal): Invalidate the mouse
97 highlight (Bug#9904).
98
99 2012-02-12 Glenn Morris <rgm@gnu.org>
100
101 * xselect.c (Fx_own_selection_internal)
102 (Fx_get_selection_internal, Fx_disown_selection_internal)
103 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
104 * nsselect.m (Fx_own_selection_internal)
105 (Fx_disown_selection_internal, Fx_selection_exists_p)
106 (Fx_selection_owner_p, Fx_get_selection_internal):
107 Sync docs and argument specs with the xselect.c versions.
108
109 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
110
111 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
112
113 2012-02-11 Eli Zaretskii <eliz@gnu.org>
114
115 * w32select.c (Fx_selection_exists_p): Sync doc string and
116 argument list with xselect.c. (Bug#10783)
117
118 * w16select.c (Fx_selection_exists_p): Sync doc string and
119 argument list with xselect.c. (Bug#10783)
120
121 2012-02-10 Glenn Morris <rgm@gnu.org>
122
123 * fns.c (Fsecure_hash): Doc fix.
124
125 2012-02-09 Kenichi Handa <handa@m17n.org>
126
127 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
128
129 2012-02-07 Chong Yidong <cyd@gnu.org>
130
131 * buffer.c (Fbuffer_local_variables)
132 (buffer_lisp_local_variables): Handle unbound vars correctly;
133 don't let Qunbound leak into Lisp.
134
135 2012-02-07 Glenn Morris <rgm@gnu.org>
136
137 * image.c (Fimagemagick_types): Doc fix.
138
139 * image.c (imagemagick-render-type): Change it from a lisp object
140 to an integer. Move the doc here from the lisp manual.
141 Treat all values not equal to 0 the same.
142
143 2012-02-06 Chong Yidong <cyd@gnu.org>
144
145 * doc.c (store_function_docstring): Avoid applying docstring of
146 alias to base function (Bug#2603).
147
148 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
149
150 * .gdbinit (pp1, pv1): Remove redundant defines.
151 (pr): Use pp.
152
153 2012-02-04 Chong Yidong <cyd@gnu.org>
154
155 * nsterm.m: Declare a global (Bug#10694).
156
157 2012-02-04 Eli Zaretskii <eliz@gnu.org>
158
159 * w32.c (get_emacs_configuration_options): Include
160 --enable-checking, if specified, in the return value.
161
162 2012-02-04 Martin Rudalics <rudalics@gmx.at>
163
164 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
165 after rounding frame sizes. (Bug#9723)
166
167 2012-02-04 Eli Zaretskii <eliz@gnu.org>
168
169 * keyboard.c (adjust_point_for_property): Don't position point
170 before BEGV. (Bug#10696)
171
172 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
173
174 Handle overflow when computing char display width (Bug#9496).
175 * character.c (char_width): Return EMACS_INT, not int.
176 (char_width, c_string_width): Check for overflow when
177 computing the width; this is possible now that individual
178 characters can have unbounded width. Problem introduced
179 by merge from Emacs 23 on 2012-01-19.
180
181 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
182
183 * dbusbind.c (Fdbus_register_method): Mention the return value
184 :ignore in the docstring.
185
186 2012-02-02 Glenn Morris <rgm@gnu.org>
187
188 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
189
190 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
191 Unconditionally set to t. (Bug#10673)
192 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
193 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
194 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
195
196 2012-02-02 Kenichi Handa <handa@m17n.org>
197
198 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
199 0, do not call append_composite_glyph.
200
201 2012-02-02 Kenichi Handa <handa@m17n.org>
202
203 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
204 NULL (Bug#6988).
205 (x_produce_glyphs): If the component of a composition is a null
206 string, set it->pixel_width to 1 to avoid zero-width glyph.
207
208 2012-02-01 Eli Zaretskii <eliz@gnu.org>
209
210 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
211 first 2 arguments are identical. This makes inserting large
212 output from a subprocess an order of magnitude faster on
213 MS-Windows, where all sbrk'ed memory is always contiguous.
214
215 2012-01-31 Glenn Morris <rgm@gnu.org>
216
217 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
218 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
219 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
220
221 2012-01-29 Glenn Morris <rgm@gnu.org>
222
223 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
224
225 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
226
227 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
228
229 2012-01-28 Chong Yidong <cyd@gnu.org>
230
231 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
232
233 2012-01-26 Chong Yidong <cyd@gnu.org>
234
235 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
236
237 * search.c (Fsearch_forward, Fsearch_backward): Document negative
238 repeat counts (Bug#10507).
239
240 2012-01-26 Glenn Morris <rgm@gnu.org>
241
242 * lread.c (syms_of_lread): Doc fix.
243
244 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
245
246 * coding.c (encode_designation_at_bol): Change return value to
247 EMACS_INT.
248
249 2012-01-25 Chong Yidong <cyd@gnu.org>
250
251 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
252
253 2012-01-21 Chong Yidong <cyd@gnu.org>
254
255 * floatfns.c (Fcopysign): Make the second argument non-optional,
256 since nil is not allowed anyway.
257
258 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
259
260 * process.c (read_process_output): Use p instead of XPROCESS (proc).
261 (send_process): Likewise.
262
263 2012-01-19 Martin Rudalics <rudalics@gmx.at>
264
265 * window.c (save_window_save, Fcurrent_window_configuration)
266 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
267 doc-strings.
268
269 2012-01-19 Kenichi Handa <handa@m17n.org>
270
271 * character.c (char_width): New function.
272 (Fchar_width, c_string_width, lisp_string_width):
273 Use char_width (Bug#9496).
274
275 2012-01-16 Martin Rudalics <rudalics@gmx.at>
276
277 * window.c (Vwindow_persistent_parameters): New variable.
278 (Fset_window_configuration, save_window_save): Handle persistent
279 window parameters.
280
281 2012-01-14 Eli Zaretskii <eliz@gnu.org>
282
283 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
284 thrashing the stack of the thread. (Bug#9087)
285
286 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
287
288 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
289
290 2012-01-11 Eli Zaretskii <eliz@gnu.org>
291
292 * xdisp.c (rows_from_pos_range): Handle the case where the
293 highlight ends on a newline. (Bug#10464)
294 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
295 he end column for display of highlight that ends on a newline
296 before a R2L line.
297
298 2012-01-11 Glenn Morris <rgm@gnu.org>
299
300 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
301 from load-path also when installation-directory is nil. (Bug#10208)
302
303 2012-01-10 Glenn Morris <rgm@gnu.org>
304
305 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
306
307 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
308 Update template values to be closer to their typical values these days.
309
310 2012-01-09 Eli Zaretskii <eliz@gnu.org>
311
312 * xdisp.c (rows_from_pos_range): Accept additional argument
313 DISP_STRING, and accept any glyph in a row whose object is that
314 string as eligible for mouse highlight. Fixes mouse highlight of
315 display strings from overlays. (Bug#10464)
316
317 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
318
319 emacs: fix an auto-save permissions race condition (Bug#10400)
320 * fileio.c (auto_saving_dir_umask): New static var.
321 (Fmake_directory_internal): Use it.
322 (do_auto_save_make_dir): Set it, instead of invoking chmod after
323 creating the directory. The old code temporarily assigns
324 too-generous permissions to the directory.
325 (do_auto_save_eh): Clear it.
326 (Fdo_auto_save): Catch all errors, not just file errors, so
327 that the var is always cleared.
328
329 2012-01-07 Eli Zaretskii <eliz@gnu.org>
330
331 * search.c (scan_buffer): Pass character positions to
332 know_region_cache, not byte positions. (Bug#6540)
333
334 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
335
336 * w32.c (sys_rename): Report EXDEV when rename of a directory
337 fails because the target is on another logical disk. (Bug#10284)
338
339 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
340
341 * xterm.c (x_embed_request_focus): New function.
342
343 * xterm.h: Add prototype.
344
345 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
346
347 2012-01-05 Glenn Morris <rgm@gnu.org>
348
349 * emacs.c (emacs_copyright): Update short copyright year to 2012.
350
351 2012-01-01 Eli Zaretskii <eliz@gnu.org>
352
353 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
354 Load gnutls_transport_set_lowat only if GnuTLS version is below
355 2.11.1.
356 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
357 GnuTLS versions below 2.11.1.
358
359 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
360
361 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
362 to the doc string advising against its use for altering the way
363 windows are scrolled.
364
365 2011-12-28 Kenichi Handa <handa@m17n.org>
366
367 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
368 coding-system ASCII compatible only when it does not produce BOM
369 on encoding (Bug#10383).
370
371 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
372
373 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
374 can scroll.
375 (create_and_show_popup_menu): Always use menu_position_func for
376 Gtk3 (Bug#10361).
377
378 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
379
380 * callint.c (Fcall_interactively): Don't truncate prompt string.
381
382 2011-12-23 Eli Zaretskii <eliz@gnu.org>
383
384 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
385 property that ends at ZV, so that the bidi iteration could be
386 resumed from there (after widening). (Bug#10360)
387
388 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
389
390 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
391
392 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
393
394 * nsterm.m (x_free_frame_resources):
395 Release f->output_data.ns->miniimage.
396 (ns_index_color): Fix indentation. Do not retain
397 color_table->colors[i].
398
399 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
400 before returning.
401
402 * nsfns.m (x_set_background_color): Assign return value from
403 ns_index_color to face-background instead of NSColor*.
404 (ns_implicitly_set_icon_type): Fix indentation.
405 Change assignment in for loop to comparison.
406
407 * emacs.c (ns_pool): New variable.
408 (main): Assign ns_pool.
409 (Fkill_emacs): Call ns_release_autorelease_pool.
410
411 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
412 autorelease fdesc, release fdAttrs and tdict.
413 (ns_get_covering_families): Release charset.
414 (ns_findfonts): Release NSFontDescriptor created with new.
415 (ns_uni_to_glyphs): Fix indentation.
416 (setString): Release attrStr before assigning new value.
417
418 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
419
420 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
421 and NS_IMPL_COCOA.
422 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
423 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
424
425 2011-12-18 David Reitter <reitter@cmu.edu>
426
427 * nsterm.m (ns_term_init): Subscribe for notifications
428 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
429 to method trackingNotification in EmacsMenu.
430
431 * nsmenu.m (trackingMenu): New variable.
432 (trackingNotification): New method (from Aquamacs).
433 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
434 from Aquamacs (Bug#7030).
435
436 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
437
438 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
439 (symbol_to_nsstring): Fix indentation.
440 (ns_symbol_to_pb): New function.
441 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
442 (Fns_rotate_cut_buffers_internal): Removed.
443 (Fns_store_selection_internal): Renamed from
444 Fns_store_cut_buffer_internal.
445 (ns_get_foreign_selection, Fx_own_selection_internal)
446 (Fx_disown_selection_internal, Fx_selection_exists_p)
447 (Fns_get_selection_internal, Fns_store_selection_internal):
448 Use ns_symbol_to_pb and check if return value is nil.
449 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
450 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
451 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
452 renamed to Sns_store_selection_internal.
453 (ns_handle_selection_request): Move code to Fx_own_selection_internal
454 and remove this function.
455 (ns_handle_selection_clear): Remove, never used.
456 (Fx_own_selection_internal): Move code from ns_handle_selection_request
457 here.
458
459 2011-12-17 Ken Brown <kbrown@cornell.edu>
460
461 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
462 GID is unknown (Bug#10257).
463
464 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
465
466 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
467 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
468 which caused a build failure on GNU/Linux IA-64. This problem was
469 introduced by my 2011-10-07 patch.
470
471 2011-12-15 Juri Linkov <juri@jurta.org>
472
473 * image.c (imagemagick_error): New function. (Bug#10112)
474 (imagemagick_load_image): Comment out `MagickSetResolution' call.
475 Use `imagemagick_error' where ImageMagick functions return
476 `MagickFalse'.
477 (Fimagemagick_types): Add `Fnreverse' to return the list in the
478 proper order.
479
480 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
481
482 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
483 fill background (Bug#8992).
484
485 2011-12-13 Martin Rudalics <rudalics@gmx.at>
486
487 * window.c (Vwindow_combination_resize)
488 (Vwindow_combination_limit): Use t instead of non-nil in
489 doc-strings.
490 (Vrecenter_redisplay): Add first sentence of doc-string on
491 separate line.
492 (Frecenter): Fix doc-string typo.
493
494 2011-12-11 Kenichi Handa <handa@m17n.org>
495
496 * coding.c (Funencodable_char_position): Pay attention to the
497 buffer text relocation (Bug#9389).
498
499 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
500
501 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
502 gtk_init (Bug#10100).
503
504 2011-12-10 Eli Zaretskii <eliz@gnu.org>
505
506 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
507 IT->string is nil. (Bug#10263)
508
509 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
510
511 * nsterm.h (x_free_frame_resources): Declare.
512
513 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
514 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
515
516 * nsterm.h (ns_get_defaults_value): Declare.
517
518 * nsterm.m (ns_default): Call ns_get_defaults_value.
519
520 2011-12-09 Eli Zaretskii <eliz@gnu.org>
521
522 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
523 (Bug#10170)
524
525 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
526
527 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
528 that where the value of an _OBJC_* symbol points to is in the .bss
529 section (Bug#10240).
530
531 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
532
533 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
534 after the loop to call ccl_driver at least once (Bug#8619).
535
536 2011-12-08 Kenichi Handa <handa@m17n.org>
537
538 * ftfont.c (get_adstyle_property): Fix previous change
539 (Bug#10233).
540
541 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
542
543 * w32.c (init_environment): If no_site_lisp, remove site-lisp
544 dirs from the default value of EMACSLOADPATH (bug#10208).
545
546 2011-12-07 Glenn Morris <rgm@gnu.org>
547
548 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
549 installation and source directories as well. (Bug#10208)
550
551 2011-12-06 Chong Yidong <cyd@gnu.org>
552
553 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
554
555 2011-12-06 Glenn Morris <rgm@gnu.org>
556
557 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
558 as an error, not just -1. (Bug#10217)
559
560 2011-12-05 Chong Yidong <cyd@gnu.org>
561
562 * keyboard.c (process_special_events): New function.
563 (swallow_events, Finput_pending_p): Use it (Bug#10195).
564
565 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
566
567 * coding.c (encode_designation_at_bol): Don't use uninitialized
568 local variable (Bug#9318).
569
570 2011-12-05 Kenichi Handa <handa@m17n.org>
571
572 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
573 return Qnil (Bug#8046, Bug#10193).
574
575 2011-12-05 Kenichi Handa <handa@m17n.org>
576
577 * coding.c (encode_designation_at_bol): New args charbuf_end and
578 dst. Return the number of produced bytes. Callers changed.
579 (coding_set_source): Return how many bytes coding->source was
580 relocated.
581 (coding_set_destination): Return how many bytes
582 coding->destination was relocated.
583 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
584 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
585
586 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
587
588 * coding.c (CODING_CHAR_CHARSET_P): New macro.
589 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
590 macro (Bug#9318).
591
592 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
593
594 The following changes are to fix Bug#9318.
595
596 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
597 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
598 (encode_coding_iso_2022, encode_coding_sjis)
599 (encode_coding_big5, encode_coding_charset): Use the above macros.
600
601 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
602
603 * lisp.h (process_quit_flag): Fix external declaration.
604
605 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
606
607 Don't macro-inline non-performance-critical code.
608 * eval.c (process_quit_flag): New function.
609 * lisp.h (QUIT): Use it.
610
611 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
612
613 * nsfns.m (get_geometry_from_preferences): New function.
614 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
615
616 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
617
618 * emacs.c (Qkill_emacs): Define.
619 (syms_of_emacs): Initialize it.
620 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
621 Qquit_flag to `kill-emacs' instead.
622 (quit_throw_to_read_char): Add parameter `from_signal'.
623 All callers changed. Call Fkill_emacs if requested and safe.
624 * lisp.h (QUIT): Call Fkill_emacs if requested.
625
626 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
627
628 * widget.c (update_wm_hints): Return if wmshell is null.
629 (widget_update_wm_size_hints): New function.
630
631 * widget.h (widget_update_wm_size_hints): Declare.
632
633 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
634 widget_update_wm_size_hints (Bug#10104).
635
636 2011-12-03 Eli Zaretskii <eliz@gnu.org>
637
638 * xdisp.c (handle_invisible_prop): If the invisible text ends just
639 before a newline, prepare the bidi iterator for consuming the
640 newline, and keep the current paragraph direction. (Bug#10183)
641 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
642
643 2011-12-02 Juri Linkov <juri@jurta.org>
644
645 * search.c (Fword_search_regexp): New Lisp function created from
646 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
647 (Fword_search_backward, Fword_search_forward)
648 (Fword_search_backward_lax, Fword_search_forward_lax):
649 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
650 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
651
652 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
653
654 * fileio.c (Finsert_file_contents): Move after-change-function call
655 to before the "handled:" label, since all "goto handled" appear in
656 cases where the *-change-functions have already been properly called
657 (bug#10117).
658
659 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
660
661 * keyboard.c (interrupt_signal): Don't call kill-emacs when
662 waiting for input. (Bug#10169)
663
664 2011-11-30 Eli Zaretskii <eliz@gnu.org>
665
666 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
667 verifies glyph row's hash code--we have just reallocated the
668 glyphs, so their contents can be complete garbage. (Bug#10164)
669
670 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
671
672 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
673
674 2011-11-30 Eli Zaretskii <eliz@gnu.org>
675
676 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
677 attributes are tested _before_ calling verify_row_hash, to protect
678 against GCC re-ordering of the tests. (Bug#10164)
679
680 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
681
682 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
683
684 * xterm.c (handle_one_xevent): Only set async_visible and friends
685 if net_wm_state_hidden_seen is non-zero (Bug#10002)
686 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
687 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
688
689 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
690
691 Remove GCPRO-related macros that exist only to avoid shadowing locals.
692 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
693 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
694 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
695 All uses changed to use GCPRO1 etc.
696 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
697 Revert to old implementation (i.e., before 2011-03-11).
698
699 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
700
701 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
702 of scroll runs so as to avoid assigning disabled bogus rows and
703 unnecessary graphics copy operations.
704
705 2011-11-27 Eli Zaretskii <eliz@gnu.org>
706
707 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
708 (snprintf) [_MSC_VER]: Redirect to _snprintf.
709 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
710 (malloc, free, realloc, calloc): Redirect to e_* only when
711 compiling Emacs.
712
713 * lisp.h (GCTYPEBITS): Move before first use.
714 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
715 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
716 this macro definition.
717
718 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
719 _MSC_VER.
720
721 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
722
723 * gtkutil.c (xg_create_frame_widgets):
724 Call gtk_window_set_has_resize_grip (FALSE) if that function is
725 present with Gtk+ 2.0.
726
727 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
728
729 * fileio.c (Finsert_file_contents): Undo previous change; see
730 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
731
732 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
733
734 Rename locals to avoid shadowing.
735 * fileio.c (Finsert_file_contents):
736 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
737 * process.c (wait_reading_process_output):
738 Rename inner 'proc' to 'p' to avoid shadowing.
739 Indent for consistency with usual Emacs style.
740
741 2011-11-25 Eli Zaretskii <eliz@gnu.org>
742
743 * xdisp.c (redisplay_window): If cursor row is not fully visible
744 after recentering, and scroll-conservatively is set to a large
745 number, scroll window by a few more lines to make the cursor fully
746 visible and out of scroll-margin. (Bug#10105)
747 (start_display): Don't move to the next line if the display should
748 start at a newline that is part of a display vector or an overlay
749 string. (Bug#10119)
750
751 2011-11-24 Juri Linkov <juri@jurta.org>
752
753 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
754 after the `MagickPingImage' call. (Bug#10112)
755
756 2011-11-23 Chong Yidong <cyd@gnu.org>
757
758 * window.c (Fcoordinates_in_window_p): Accept only live windows.
759
760 2011-11-23 Martin Rudalics <rudalics@gmx.at>
761
762 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
763 making another buffer current. (Bug#10114)
764
765 2011-11-23 Glenn Morris <rgm@gnu.org>
766
767 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
768
769 2011-11-23 Chong Yidong <cyd@gnu.org>
770
771 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
772 using it (Bug#5984).
773
774 2011-11-22 Eli Zaretskii <eliz@gnu.org>
775
776 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
777 and header-lines, as they don't have one computed for them.
778 (Bug#10098)
779
780 * .gdbinit (prow): Make displayed values more self-explaining.
781 Add row's hash code.
782
783 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
784
785 * process.c (wait_reading_process_output): Fix asynchrounous
786 GnuTLS socket handling on some versions of the GnuTLS library.
787 (wait_reading_process_output): Add comment and URL.
788
789 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
790
791 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
792
793 2011-11-21 Chong Yidong <cyd@gnu.org>
794
795 * window.c (Fnext_window, Fprevious_window): Doc fix.
796
797 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
798
799 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
800
801 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
802
803 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
804
805 2011-11-20 Martin Rudalics <rudalics@gmx.at>
806
807 * window.c (Fset_window_combination_limit): Rename argument
808 STATUS to LIMIT.
809 (Vwindow_combination_limit): Remove "status" from doc-string.
810
811 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
812
813 * m/ibms390.h: Remove.
814 * m/ibms390x.h: Don't include "ibms390.h".
815
816 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
817
818 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
819 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
820
821 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
822
823 * casetab.c (Fset_case_table):
824 * charset.c (Fcharset_after): Fix typos.
825
826 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
827
828 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
829 Otherwise, valgrind does not work on some platforms.
830 Problem reported by Andreas Schwab in
831 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
832 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
833 is set, removing the need for VIRT_ADDRESS_VARIES.
834 (PURE_P): Use a more-efficient implementation that needs just one
835 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
836 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
837 to 4 (xorl, subq, cmpq, setbe).
838 * alloc.c (pure): Always extern now, since that's the
839 VIRT_ADDR_VARIES behavior.
840 (PURE_POINTER_P): Use a single comparison, not two, for
841 consistency with the new puresize.h.
842 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
843 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
844 Remove VIRT_ADDR_VARIES no longer needed.
845
846 2011-11-19 Eli Zaretskii <eliz@gnu.org>
847
848 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
849 (erase_phys_cursor, update_window_cursor, show_mouse_face)
850 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
851 behave as if the cursor position were at the window margin.
852
853 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
854 and the cursor position is out of bounds, behave as if the cursor
855 position were at the window margin. (Bug#10075)
856
857 2011-11-18 Chong Yidong <cyd@gnu.org>
858
859 * window.c (Fwindow_combination_limit): Make first argument
860 non-optional, since it is meaningless for live windows like the
861 selected window.
862
863 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
864
865 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
866
867 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
868
869 * intervals.c: Fix grafting over the whole buffer (bug#10071).
870 (graft_intervals_into_buffer): Simplify.
871
872 2011-11-18 Eli Zaretskii <eliz@gnu.org>
873
874 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
875 hash values of the two rows.
876 (copy_row_except_pointers): Preserve the used[] arrays and the
877 hash values of the two rows. (Bug#10035)
878 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
879
880 * xdisp.c (row_hash): New function, body extracted from
881 compute_line_metrics.
882 (compute_line_metrics): Call row_hash, instead of computing the
883 hash code inline.
884
885 * dispnew.c (verify_row_hash): Call row_hash for computing the
886 hash code of a row, instead of duplicating code from xdisp.c.
887
888 * dispextern.h (row_hash): Add prototype.
889
890 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
891
892 * frame.c (delete_frame): Don't delete the terminal when the last
893 X frame is closed if emacs is built with GTK toolkit.
894
895 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
896
897 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
898
899 2011-11-17 Martin Rudalics <rudalics@gmx.at>
900
901 * window.c (Vwindow_splits): Rename to
902 Vwindow_combination_resize. Suggested by Juri Linkov.
903 (Fsplit_window_internal): Use Vwindow_combination_resize instead
904 of Vwindow_splits.
905
906 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
907
908 * nsfns.m (Fns_font_name):
909 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
910
911 2011-11-16 Martin Rudalics <rudalics@gmx.at>
912
913 * window.h (window): Rename slot "nest" to "combination_limit".
914 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
915 (Fset_window_nest): Rename to Fset_window_combination_limit.
916 (Vwindow_nest): Rename to Vwindow_combination_limit.
917 (recombine_windows, make_parent_window, make_window)
918 (Fsplit_window_internal, saved_window)
919 (Fset_window_configuration, save_window_save): Rename all
920 occurrences of window_nest to window_combination_limit.
921
922 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
923
924 * image.c (imagemagick_load_image): Fix typo.
925
926 2011-11-14 Eli Zaretskii <eliz@gnu.org>
927
928 * xdisp.c (display_line): Move the call to
929 highlight_trailing_whitespace before the call to
930 compute_line_metrics, since the latter needs to see the final
931 faces of all the glyphs to compute ROW's hash value.
932 Fixes assertion violations in row_equal_p. (Bug#10035)
933
934 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
935
936 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
937 just return (bug#10044).
938
939 2011-11-12 Eli Zaretskii <eliz@gnu.org>
940
941 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
942 with user-defined heap size. Bump the default size of the temacs
943 heap to 27MB, to avoid memory warning when running temacs.
944 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
945
946 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
947 current_matrix and desired_matrix. (Bug#9990)
948 (verify_row_hash) [XASSERTS]: New function.
949 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
950 that the hash value of glyph rows is correct.
951
952 2011-11-12 Martin Rudalics <rudalics@gmx.at>
953
954 * window.h (window): Remove splits slot.
955 * window.c (Fwindow_splits, Fset_window_splits): Remove.
956 (Fdelete_other_windows_internal, make_parent_window)
957 (make_window, Fsplit_window_internal, Fdelete_window_internal)
958 (Fset_window_configuration, save_window_save): Don't deal with
959 split status of windows.
960 (saved_window): Remove splits slot.
961 (Vwindow_splits): Rewrite doc-string.
962
963 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
964
965 * xfns.c (unwind_create_frame):
966 * nsfns.m (unwind_create_frame):
967 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
968 Vframe_list (Bug#9999).
969
970 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
971
972 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
973
974 2011-11-11 Kenichi Handa <handa@m17n.org>
975
976 * callproc.c (Fcall_process): Set the member dst_multibyte of
977 process_coding.
978
979 2011-11-11 Johan Bockgård <bojohan@gnu.org>
980
981 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
982 avoid a crash (bug#9496).
983
984 2011-11-09 Chong Yidong <cyd@gnu.org>
985
986 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
987 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
988
989 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
990
991 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
992
993 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
994
995 Avoid some portability problems by eschewing 'extern inline' functions.
996 The trivial performance wins aren't worth the portability hassles; see
997 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
998 et seq.
999 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1000 (window_box_width, window_box_left, window_box_left_offset)
1001 (window_box_right, window_box_right_offset): Undo previous change,
1002 by removing the "extern"s.
1003 * intervals.c (adjust_intervals_for_insertion)
1004 (adjust_intervals_for_deletion): Undo previous change,
1005 making these static again.
1006 (offset_intervals, temp_set_point_both, temp_set_point)
1007 (copy_intervals_to_string): No longer inline.
1008 * xdisp.c (window_text_bottom_y, window_box_width)
1009 (window_box_height, window_box_left_offset)
1010 (window_box_right_offset, window_box_left, window_box_right)
1011 (window_box): No longer inline.
1012
1013 2011-11-08 Chong Yidong <cyd@gnu.org>
1014
1015 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1016 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1017 Signal an error if not a live window.
1018 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1019 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1020
1021 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1022
1023 * lisp.h (syms_of_abbrev): Remove declaration.
1024 Reported by CHENG Gao <chenggao@royau.me>.
1025
1026 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1027
1028 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1029 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1030 of temacs in GUI mode.
1031
1032 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1033
1034 * window.h: Declare delete_all_child_windows instead of
1035 delete_all_subwindows.
1036 * window.c (Fwindow_nest, Fset_window_nest)
1037 (Fset_window_new_total, Fset_window_new_normal)
1038 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1039 (delete_all_subwindows): Rename to delete_all_child_windows.
1040 (Fdelete_other_windows_internal, Fset_window_configuration):
1041 Call delete_all_child_windows instead of delete_all_subwindows.
1042 * frame.c (delete_frame): Call delete_all_child_windows instead
1043 of delete_all_subwindows.
1044
1045 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1046
1047 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1048 This is also needed for porting to any host where GC_MARK_STACK is
1049 not GC_MAKE_GCPROS_NOOPS.
1050 (which_symbols): Use it.
1051
1052 2011-11-07 Kenichi Handa <handa@m17n.org>
1053
1054 * coding.c (coding_set_destination): Check coding->src_pos only
1055 when coding->src_object is a buffer (bug#9910).
1056
1057 * process.c (send_process): Set the member src_multibyte of coding
1058 to 0 (bug#9911) when sending a unibyte text.
1059
1060 * callproc.c (Fcall_process): Set the member src_multibyte of
1061 process_coding to 0 (bug#9912).
1062
1063 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1064
1065 * xmenu.c (cleanup_widget_value_tree): New function.
1066 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1067 calling free_menubar_widget_value_tree directly (Bug#9830).
1068
1069 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1070
1071 Fix some portability problems with 'inline'.
1072 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1073 (window_box_width, window_box_left, window_box_left_offset)
1074 (window_box_right, window_box_right_offset): Declare extern.
1075 Otherwise, these inline functions do not conform to C99 and
1076 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1077 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1078 * intervals.c (adjust_intervals_for_insertion)
1079 (adjust_intervals_for_deletion): Now extern, because otherwise the
1080 extern inline functions 'offset_intervals' couldn't refer to it.
1081 (static_offset_intervals): Remove.
1082 (offset_intervals): Rewrite using the old contents of
1083 static_offset_intervals. The old version didn't conform to C99
1084 because an extern inline function contained a reference to an
1085 identifier with static linkage.
1086
1087 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1088
1089 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1090 GC.
1091
1092 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1093
1094 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1095 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1096 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1097 return Qleft_to_right.
1098
1099 2011-11-06 Chong Yidong <cyd@gnu.org>
1100
1101 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1102 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1103 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1104 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1105 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1106 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1107 (Fwindow_vscroll): Doc fix.
1108 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1109 argument, since it makes no sense to pass a live window and for
1110 consistency with window-child.
1111
1112 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1113
1114 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1115 support MSVC.
1116
1117 2011-11-05 Jason Rumney <jasonr@gnu.org>
1118
1119 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1120 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1121 fonts (Bug#6029).
1122 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1123 bitwise arithmetic preventing use of unicode-sip and non-truetype
1124 opentype fonts.
1125
1126 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1127
1128 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1129 "emacs"-only part.
1130
1131 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1132 initialization code to keep similarity to xfns.c after changes
1133 from 2011-11-05.
1134
1135 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1136
1137 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1138 (unwind_create_frame): New function (Bug#9943).
1139 (Fx_create_frame): Restructure code to be more similar to the one in
1140 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1141 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1142 Move terminal->reference_count++ just before making the frame official
1143 (Bug#9943).
1144
1145 * nsterm.m (x_free_frame_resources): New function.
1146 (x_destroy_window): Move code to x_free_frame_resources.
1147
1148 * xfns.c (unwind_create_frame): Fix comment.
1149 (Fx_create_frame, x_create_tip_frame):
1150 Move terminal->reference_count++ just before making the frame
1151 official. Move initialization of image_cache_refcount and
1152 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1153
1154 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1155
1156 Support MSVC build with newer versions of Visual Studio.
1157 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1158 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1159 nt/gmake.defs.
1160
1161 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1162 which are not supported by MSVC.
1163 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1164 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1165 bitfields.
1166 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1167 types in bitfields.
1168 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1169
1170 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1171
1172 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1173
1174 Support MSVC build with newer versions of Visual Studio.
1175 * w32.c: Don't include w32api.h for MSVC.
1176 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1177
1178 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1179 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1180 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1181 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1182 e_* cousins.
1183 (alloca) [_MSC_VER]: Define to _alloca.
1184
1185 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1186
1187 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1188
1189 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1190
1191 * xdisp.c (note_mouse_highlight): If either of
1192 previous/next-single-property-change returns nil, treat that as
1193 the beginning or the end of the buffer. (Bug#9955)
1194
1195 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1196
1197 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1198 label is not null (Bug#9951).
1199 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1200 may be NULL.
1201
1202 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1203
1204 * window.c (Fwindow_body_size): Mention in the doc string that the
1205 return value is in frame's canonical units. (Bug#9949)
1206
1207 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1208
1209 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1210
1211 * w32fns.c (unwind_create_frame): If needed, free the glyph
1212 matrices of the partially constructed frame. (Bug#9943)
1213 * xfns.c (unwind_create_frame): Likewise.
1214
1215 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1216
1217 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1218 Don't stop backward scan on the continuation glyph, even though
1219 its CHARPOS is positive.
1220 (mouse_face_from_buffer_pos, note_mouse_highlight):
1221 Rename cover_string to disp_string.
1222
1223 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1224
1225 * window.c (temp_output_buffer_show): Don't use
1226 Vtemp_buffer_show_specifiers.
1227 (Vtemp_buffer_show_specifiers): Remove unused variable.
1228
1229 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1230
1231 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1232 past the beginning of the current glyph matrix.
1233
1234 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1235
1236 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1237 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1238 HAVE_GTK3 (Bug#9869).
1239
1240 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1241 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1242
1243 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1244
1245 * xterm.c: Declare x_handle_net_wm_state to return int.
1246 (handle_one_xevent): Check if we are iconified but don't have
1247 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1248 (get_current_wm_state): Return non-zero if not hidden,
1249 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1250 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1251 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1252 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1253
1254 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1255
1256 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1257 so that this new function doesn't get optimized away by a
1258 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1259
1260 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1261
1262 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1263
1264 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1265
1266 Fix the `xbytecode' command.
1267 * .gdbinit (xprintbytestr): New command.
1268 (xwhichsymbols): Rename from `which'; all callers changed.
1269 (xbytecode): Print the byte-code string as well.
1270
1271 2011-10-29 Kim Storm <storm@cua.dk>
1272
1273 * alloc.c (which_symbols): New function.
1274
1275 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1276
1277 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1278 line. (Bug#9903)
1279
1280 2011-10-29 Glenn Morris <rgm@gnu.org>
1281
1282 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1283 Not clear what it was for, and it causes various bugs. (Bug#9839)
1284
1285 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1286
1287 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1288 possible random value that matches one of those tested as
1289 condition to clear the mouse face.
1290
1291 2011-10-28 Chong Yidong <cyd@gnu.org>
1292
1293 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1294
1295 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1296
1297 * window.c (make_window): Initialize phys_cursor_on_p.
1298
1299 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1300
1301 * lisp.h (struct Lisp_Symbol): Update comments.
1302
1303 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1304
1305 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1306
1307 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1308
1309 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1310 <oslsachem@gmail.com> for helping to debug this.
1311
1312 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1313 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1314 (g_b_init_get_glyph_outline_w): New static variables.
1315 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1316 (GetGlyphOutlineW_Proc): New typedefs.
1317 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1318 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1319 New functions.
1320 (w32font_open_internal, compute_metrics):
1321 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1322 instead of calling the "wide" APIs directly.
1323
1324 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1325
1326 * w32.h (syms_of_w32font): Add prototype.
1327
1328 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1329
1330 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1331 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1332 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1333 (Fmove_to_window_line): Doc fix.
1334
1335 2011-10-27 Chong Yidong <cyd@gnu.org>
1336
1337 * process.c (make_process): Set gnutls_state to NULL.
1338
1339 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1340 non-NULL, regardless of GNUTLS_INITSTAGE.
1341 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1342 an error. Set process slots as soon as we allocate them.
1343
1344 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1345
1346 2011-10-27 Chong Yidong <cyd@gnu.org>
1347
1348 * gnutls.c (emacs_gnutls_deinit): New function.
1349 Deallocate credentials structures as well as calling gnutls_deinit.
1350 (Fgnutls_deinit, Fgnutls_boot): Use it.
1351
1352 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1353 (deactivate_process): Call emacs_gnutls_deinit.
1354
1355 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1356
1357 * image.c (x_create_x_image_and_pixmap):
1358 * w32.c (sys_rename, w32_delayed_load):
1359 * w32font.c (fill_in_logfont):
1360 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1361
1362 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1363
1364 * w32fns.c (w32_default_color_map): New function,
1365 extracted from Fw32_default_color_map.
1366 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1367
1368 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1369
1370 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1371
1372 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1373
1374 * keyboard.c (test_undefined): New function (bug#9751).
1375 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1376
1377 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1378
1379 * sysdep.c (init_sys_modes): Fix the check for the controlling
1380 terminal (Bug#6649).
1381
1382 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1383
1384 * dispextern.h (struct bidi_it): New member next_en_type.
1385
1386 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1387 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1388 current character, check also for next_en_type being WEAK_EN.
1389 (bidi_resolve_weak): Don't enter the expensive loop if the current
1390 position is before next_en_pos. Record the bidi type of the first
1391 non-ET, non-BN character we find, in addition to its position.
1392 (bidi_level_of_next_char): Invalidate next_en_type when
1393 next_en_pos is over-stepped.
1394
1395 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1396
1397 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1398 * editfns.c: Rewrite current-time-zone so that it invokes
1399 the equivalent of (format-time-string "%Z") to get the time zone name.
1400 This fixes a bug when the time zone name contains characters that
1401 need converting from the system time locale to Emacs internal format.
1402 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1403 that patch fixed format-time-string to do the conversion, but
1404 I forgot to fix current-time-zone.
1405 (format_time_string): New function, containing most of
1406 what Fformat_time_string used to contain.
1407 (Fformat_time_string): Rewrite in terms of format_time_string.
1408 This doesn't change this function's behavior.
1409 (current-time-zone): Rewrite to use format_time_string.
1410 This fixes the bug reported by Michael Schierl in
1411 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1412 Jason Rumney's 2007-06-07 change worked around this bug, but
1413 didn't fix it.
1414 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1415
1416 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1417
1418 * xdisp.c (start_display): If the character at POS is displayed
1419 via a display vector, reset IT->current.dpvec_index to zero.
1420 (try_window_reusing_current_matrix): If a line ends in a display
1421 vector or the next line starts in a display vector, continue
1422 redrawing the window even though the character position of
1423 start_row was reached.
1424 (Bug#9771, part 2)
1425
1426 2011-10-18 Chong Yidong <cyd@gnu.org>
1427
1428 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1429 with nobreak-char-display too.
1430
1431 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1432
1433 Fix part 3 of bug#9771.
1434 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1435 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1436 non-neutral characters if the current character is a paragraph
1437 separator (a.k.a. Newline). This avoids running the same
1438 expensive loop twice, once when we consume the preceding newline
1439 and the other time when the line actually needs to be displayed.
1440 Avoid the loop when we see neutrals on the base embedding level
1441 following a character whose directionality is the same as the
1442 paragraph's. This avoids running the expensive loop when a line
1443 ends in a long sequence of neutrals, like control characters.
1444 Add assertion against STRONG_AL type. Slightly rearrange code
1445 that determines the type of a neutral given the first non-neutral
1446 that follows it.
1447 (bidi_level_of_next_char): Set next_en_pos to zero when
1448 invalidating its info.
1449
1450 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1451
1452 * xdisp.c (push_display_prop): Determine whether to record string
1453 or buffer position by IT->string, not by IT->method. Allow
1454 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1455 (move_it_vertically_backward): Don't look for character position
1456 immediately after the newline when in a continuation line.
1457 (Bug#9771, part 1)
1458
1459 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1460
1461 * window.c (coordinates_in_window): Rewrite and delabelize
1462 vertical border check. (Bug#5357) (Bug#9618)
1463
1464 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1465
1466 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1467 errors in XSetWindowBorder (bug#9310).
1468
1469 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1470
1471 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1472 avoid crash when xmalloc overrun checking is enabled.
1473
1474 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1475
1476 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1477 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1478 cursor motion with <left> and <right> arrow keys.
1479
1480 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1481 some callers set that themselves.
1482
1483 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1484
1485 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1486 display string and the previous row comes from the same string and
1487 is empty. (Bug#9739) (Bug#9738)
1488
1489 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1490
1491 * doc.c (get_doc_string): Encode file name (bug#9735).
1492
1493 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1494
1495 * bidi.c (bidi_level_of_next_char):
1496 * xdisp.c (get_visually_first_element): Remove old incorrect
1497 comments regarding the Unicode Line Separator character.
1498
1499 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1500
1501 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1502
1503 * alloc.c (Fgc_status): Do not access beyond zombies array
1504 boundary if nzombies > MAX_ZOMBIES.
1505 * alloc.c (dump_zombies): Add missing format specifier.
1506
1507 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1508
1509 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1510 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1511
1512 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1513 Some packages use them to denote characters with modifiers.
1514
1515 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1516
1517 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1518 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1519 matching a pp-number. Rename parameter var to var1.
1520
1521 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1522
1523 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1524
1525 2011-10-08 Glenn Morris <rgm@gnu.org>
1526
1527 * callint.c (Fcall_interactively): Give a more explicit error for the
1528 'c' case with a non-character input. (Bug#8479)
1529
1530 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1531
1532 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1533 lines.
1534 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1535 lines that are hscrolled on the left.
1536
1537 * dispnew.c (buffer_posn_from_coords): Account for a possible
1538 presence of header-line. (Bug#4426)
1539
1540 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1541
1542 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1543 Don't advertise functionality which we discourage or doesn't work.
1544
1545 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1546
1547 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1548 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1549 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1550 this makes Emacs dump core during garbage collection on rare
1551 occasions. sizeof is obviously inferior to offsetof here, so
1552 stick with offsetof.
1553 (GC_POINTER_ALIGNMENT): New macro.
1554 (mark_memory): Omit 3rd (offset) arg; caller changed.
1555 Don't assume EMACS_INT alignment is the same as pointer alignment.
1556
1557 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1558
1559 * keyboard.c (read_key_sequence_remapped): New var.
1560 (read_key_sequence): Compute remapping in the right buffer.
1561 (command_loop_1): Use read_key_sequence's remapping directly.
1562
1563 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1564
1565 * dired.c (file_name_completion): Don't expand file name.
1566 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1567 before checking file name handler.
1568
1569 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1570 they've been requested explicitly (bug#9591).
1571
1572 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1573
1574 * keymap.c (Fsingle_key_description): Use make_specified_string
1575 instead of build_string to build string from push_key_description.
1576 (Bug#5193)
1577
1578 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1579
1580 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1581 This fixes a Y2038 bug on 64-bit hosts.
1582 * buffer.c (reset_buffer):
1583 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1584 (Fclear_buffer_auto_save_failure):
1585 Use 0, not -1, to represent an unset failure time, since time_t
1586 might not be signed.
1587
1588 Remove dependency on glibc malloc internals.
1589 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1590 Move back here from lisp.h, but with their new implementations.
1591 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1592 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1593 * charset.c (charset_table_init): New static var.
1594 (syms_of_charset): Use it instead of xmalloc. This removes a
1595 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1596 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1597 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1598 Move back to alloc.c.
1599 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1600 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1601
1602 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1603
1604 * nsterm.m (windowDidResize): Call x_set_window_size only when
1605 ns_in_resize is true. Otherwise set pixelwidth/height and
1606 call change_frame_size (Bug#9628).
1607
1608 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1609
1610 Port --enable-checking=all to Fedora 14 x86-64.
1611 * charset.c (syms_of_charset): Also account for glibc malloc's
1612 internal overhead when calculating the initial malloc maximum.
1613
1614 Port --enable-checking=all to Fedora 14 x86.
1615 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1616 Move to lisp.h.
1617 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1618 (overrun_check_realloc, overrun_check_free):
1619 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1620 That way, xmalloc returns a properly-aligned pointer even if
1621 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1622 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1623 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1624 into account when calculating the initial malloc maximum.
1625 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1626 Move here from alloc.c, so that charset.c can use it too.
1627 Properly align; the old code wasn't right for common 32-bit hosts
1628 when configured with --enable-checking=all.
1629 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1630 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1631
1632 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1633
1634 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1635 use EDOM.
1636
1637 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1638
1639 * xdisp.c (compute_display_string_end): If there's no display
1640 string at CHARPOS, return -1.
1641
1642 * bidi.c (bidi_fetch_char): When compute_display_string_end
1643 returns a negative value, treat the character as a normal
1644 character not covered by a display string. (Bug#9624)
1645
1646 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1647
1648 * lread.c (Fread_from_string): Fix typo in docstring.
1649
1650 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1651
1652 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1653 newline, reseat the iterator instead of bidi-iterating there one
1654 character at a time. (Bug#9610)
1655 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1656 TO_CHARPOS if the bidi iterator is at base embedding level.
1657
1658 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1659
1660 * lread.c (readevalloop): Use correct code for NBSP.
1661 (read1): Likewise. (Bug#9608)
1662
1663 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1664
1665 * dbusbind.c (Fdbus_register_signal): When service is not
1666 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1667
1668 2011-09-25 Glenn Morris <rgm@gnu.org>
1669
1670 * buffer.c (truncate-lines): Doc fix.
1671
1672 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1673
1674 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1675 (Fset_window_next_buffers): Doc fix.
1676
1677 2011-09-24 Glenn Morris <rgm@gnu.org>
1678
1679 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1680
1681 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1682
1683 Fix minor problems found by static checking.
1684 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1685 * indent.c (Fvertical_motion): Fix == vs = typo.
1686
1687 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1688
1689 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1690 Default value is now t. Doc fix.
1691
1692 * indent.c (Fvertical_motion): Compute and apply the overshoot
1693 logic when moving up, not only when moving down. Fix the
1694 confusing name and values of the it_overshoot_expected variable;
1695 logic changes accordingly. (Bug#9254) (Bug#9549)
1696
1697 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1698 CHARPOS is covered by a display string which includes newlines.
1699 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1700 is covered by a display string with embedded newlines.
1701
1702 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1703
1704 * dbusbind.c (Fdbus_register_signal): Add match rule to
1705 Vdbus_registered_objects_table. (Bug#9581)
1706 (Fdbus_register_method, Vdbus_registered_objects_table):
1707 Fix docstring.
1708
1709 2011-09-24 Jim Meyering <meyering@redhat.com>
1710
1711 do not ignore write error for any output size
1712 The previous change was incomplete.
1713 While it makes emacs --batch detect the vast majority of stdout
1714 write failures, errors were still ignored whenever the output size is
1715 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1716 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1717 && echo FAIL: ignored write error
1718 FAIL: ignored write error
1719 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1720 && echo FAIL: ignored write error
1721 FAIL: ignored write error
1722 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1723
1724 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1725
1726 * emacs.c (Fkill_emacs): In noninteractive mode exit
1727 non-successfully if a write error occurred on stdout. (Bug#9574)
1728
1729 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1730
1731 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1732 the xassert test.
1733
1734 * dispextern.h (struct it): Update the comment documenting what
1735 can it->OBJECT be.
1736
1737 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1738
1739 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1740 a display string, extend search for cursor position to end of row.
1741 (find_row_edges): If the row ends in a newline from a display
1742 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1743 Handle the case of a display string with multiple newlines.
1744 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1745 non-empty line. Fixes confusing cursor motion with arrow keys at
1746 the beginning of a line that starts with whitespace.
1747
1748 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1749
1750 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1751 (bug#9493).
1752
1753 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1754
1755 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1756 boolean (Bug#9154).
1757
1758 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1759
1760 * xdisp.c (display_line): Record maximum and minimum buffer
1761 positions even if no glyphs were produced (e.g., by a zero-width
1762 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1763 buffer positions that will be removed from the glyph row because
1764 they don't fit.
1765 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1766 column is beyond frame width: don't subtract 1 "pixel" when
1767 computing width of the stretch.
1768 (reseat_at_next_visible_line_start): Undo the change made on
1769 2011-09-17 that saved paragraph information and restored it after
1770 the call to `reseat'. (Bug#9545)
1771
1772 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1773
1774 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1775 and turn window cursor on if cleared (Bug#9415).
1776
1777 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1778
1779 * search.c (boyer_moore): Take unibyte characters from pattern
1780 literally. (Bug#9458)
1781
1782 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1783
1784 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1785
1786 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1787
1788 Fix minor problem found by static checking.
1789 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1790 initialized, to pacify gcc -Wuninitialized.
1791
1792 * fileio.c: Report proper errno when syscall falls.
1793 (Finsert_file_contents): Save and restore errno,
1794 so that report_file_error outputs the correct diagnostic.
1795 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1796
1797 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1798
1799 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1800
1801 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1802
1803 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1804 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1805
1806 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1807
1808 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1809 about the current paragraph and restore it after the call to reseat.
1810
1811 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1812 (bidi_find_paragraph_start): Search back for paragraph beginning
1813 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1814 (bidi_move_to_visually_next): Only trigger paragraph-related
1815 computations when the last character is a newline or at EOB, not
1816 just any NEUTRAL_B. (Bug#9470)
1817
1818 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1819 truncated lines if point is covered by a display string. (Bug#9524)
1820
1821 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1822
1823 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1824 (cons_to_x_long): New function.
1825 (lisp_data_to_selection_data): Use it. Correct the test for
1826 short-versus-long data; it was negated. Break out of vector
1827 loop, for efficiency, when a long datum is discovered.
1828
1829 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1830
1831 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1832
1833 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1834
1835 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1836 GCC PR/17406) by declaring this function with external scope.
1837
1838 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1839
1840 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1841 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1842
1843 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1844
1845 * editfns.c (Fformat): Correctly handle text properties on "%%".
1846
1847 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1848
1849 * xterm.c (x_draw_composite_glyph_string_foreground):
1850 * w32term.c (x_draw_composite_glyph_string_foreground):
1851 * term.c (encode_terminal_code):
1852 * composite.c (composition_update_it, get_composition_id):
1853 * xdisp.c (get_next_display_element)
1854 (fill_composite_glyph_string): Add comments about special meaning
1855 of TAB characters in a composition.
1856
1857 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1858
1859 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1860 This occurs when processing a multibyte format.
1861 Problem reported by Wolfgang Jenker.
1862
1863 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1864
1865 * xdisp.c (try_cursor_movement): Only check for exact match if
1866 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1867
1868 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1869
1870 Remove unused external symbols.
1871 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1872 * xdisp.c (calc_pixel_width_or_height): Now static.
1873 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1874 * indent.c (check_display_width):
1875 * w32term.c: Fix comment to match code.
1876 * xterm.c, xterm.h (x_catching_errors): Remove.
1877
1878 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1879
1880 * xselect.c: Use signed conversions more consistently (Bug#9498).
1881 (selection_data_to_lisp_data): Assume incoming selection data are
1882 signed integers, not unsigned. This is to be consistent with
1883 outgoing selection data, which was modified to use signed integers
1884 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1885 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1886 expects long, not unsigned long.
1887
1888 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1889
1890 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1891 computation of loop end. Reported by Johan Bockgård
1892 <bojohan@gnu.org>.
1893
1894 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1895
1896 * frame.c (Fother_visible_frames_p): Function deleted.
1897
1898 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1899
1900 * indent.c (compute_motion): Process display vector front to back
1901 rather than the other way around. (Bug#2496)
1902
1903 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1904
1905 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1906
1907 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1908
1909 * minibuf.c (Fread_from_minibuffer): Doc fix.
1910
1911 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1912
1913 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1914 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1915
1916 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1917
1918 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1919 value for non-existent files.
1920
1921 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1922
1923 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1924 set its "size" to -1. This will set the modtime_size field of
1925 the corresponding buffer to -1, which is what
1926 verify-visited-file-modtime expects for files that do not exist.
1927 (Bug#9139)
1928
1929 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1930
1931 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1932 here ...
1933 * lisp.h: ... from here. push_key_description is no longer
1934 defined in keyboard.c, so its declaration should not be in
1935 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1936 logically belongs with push_key_description.
1937
1938 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1939
1940 * buffer.h: Include <sys/types.h> instead of <time.h>.
1941 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1942 Problem reported by Herbert J. Skuhra.
1943
1944 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1945
1946 * xml.c (parse_region): Make the parsing work for
1947 non-comment-starting XML files again (bug#9144).
1948
1949 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1950
1951 * image.c (gif_load): Fix calculation of bottom and right corner.
1952 (Bug#9468)
1953
1954 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1955
1956 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1957 redisplay in small windows.
1958
1959 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1960
1961 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1962
1963 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1964
1965 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1966 Operate on live windows only.
1967
1968 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1969
1970 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1971
1972 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1973
1974 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1975 only under bidi iteration.
1976
1977 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1978
1979 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1980
1981 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1982
1983 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1984 Without this fix, the command to link temacs failed due to an
1985 undefined symbol __builtin_isnan. This is because
1986 /usr/include/iso/math_c99.h #defines isnan(x) to
1987 __builtin_isnan(x), but the bundled gcc, which identifies itself
1988 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1989 a __builtin_isnan.
1990 * floatfns.c (isnan): #undef, and then #define to a clone of
1991 what's in data.c.
1992 (Fisnan): Always define, since it's always available now.
1993 (syms_of_floatfns): Always define isnan at the Lisp level.
1994
1995 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1996
1997 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1998
1999 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2000
2001 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2002 The previous code assumed that file offsets (off_t values) fit in
2003 EMACS_INT variables, which is not true on typical 32-bit hosts.
2004 The code messed up by falsely reporting buffer overflow in cases
2005 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2006 when "big" contains more than 2**29 bytes, even though this
2007 inserts just one byte and does not overflow the buffer.
2008 (Finsert_file_contents): Store file offsets as off_t
2009 values, not as EMACS_INT values. Check for overflow when
2010 converting between EMACS_INT and off_t. When checking for
2011 buffer overflow or for overlap, take the offsets into account.
2012 Don't use EMACS_INT for small values where int suffices.
2013 When checking for overlap, fix a typo: ZV was used where
2014 ZV_BYTE was intended.
2015 (Fwrite_region): Don't assume off_t fits into 'long'.
2016 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2017
2018 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2019
2020 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2021
2022 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2023
2024 sprintf-related integer and memory overflow issues (Bug#9412).
2025
2026 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2027 (esprintf, exprintf, evxprintf): New functions.
2028 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2029 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2030 (modify_event_symbol): Do not assume that the length of
2031 name_alist_or_stem is safe to alloca and fits in int.
2032 (Fexecute_extended_command): Likewise for function name and binding.
2033 (Frecursion_depth): Wrap around reliably on integer overflow.
2034 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2035 since some callers pass EMACS_INT values.
2036 (Fsingle_key_description): Don't crash if symbol name contains more
2037 than MAX_ALLOCA bytes.
2038 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2039 (get_minibuffer): Arg is now EMACS_INT, not int.
2040 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2041 (esprintf, exprintf, evxprintf): New decls.
2042 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2043
2044 * dbusbind.c (signature_cat): New function.
2045 (xd_signature, Fdbus_register_signal):
2046 Do not overrun buffer; instead, report string overflow.
2047
2048 * dispnew.c (add_window_display_history): Don't overrun buffer.
2049 Truncate instead; this is OK since it's just a log.
2050
2051 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2052 even if the time zone offset is outlandishly large.
2053 Don't mishandle offset == INT_MIN.
2054
2055 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2056 when creating daemon; the previous buffer-overflow check was incorrect.
2057
2058 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2059 which has the guts of the old verror function.
2060
2061 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2062 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2063
2064 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2065 (font_unparse_xlfd): Don't blindly alloca long strings.
2066 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2067 fits in int, when using sprintf. Use single snprintf to count
2068 length of string rather than counting it via multiple sprintfs;
2069 that's simpler and more reliable.
2070 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2071 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2072 sprintf, in case result does not fit in int.
2073
2074 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2075 (fontset_from_font): Print it.
2076
2077 * frame.c (tty_frame_count): Now printmax_t, not int.
2078 (make_terminal_frame, set_term_frame_name): Print it.
2079 (x_report_frame_params): In X, window IDs are unsigned long,
2080 not signed long, so print them as unsigned.
2081 (validate_x_resource_name): Check for implausibly long names,
2082 and don't assume name length fits in 'int'.
2083 (x_get_resource_string): Don't blindly alloca invocation name;
2084 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2085 not fit in int.
2086
2087 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2088 (xg_check_special_colors, xg_set_geometry):
2089 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2090
2091 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2092 Use esprintf, not sprintf, in case result does not fit in int.
2093
2094 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2095 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2096 it as a large positive number.
2097 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2098 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2099
2100 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2101 in case result does not fit in int.
2102
2103 * print.c (float_to_string): Detect width overflow more reliably.
2104 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2105 buffer overrun. Don't assume list length fits in 'int'. Treat
2106 print length of 0 as 0, not as infinity; to be consistent with other
2107 uses of print length in this function. Don't overflow print length
2108 index. Don't assume hash table size fits in 'long', or that
2109 vectorlike size fits in 'unsigned long'.
2110
2111 * process.c (make_process): Use printmax_t, not int, to format
2112 process-name gensyms.
2113
2114 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2115
2116 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2117 to avoid potential buffer overrun.
2118
2119 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2120 if X resource line is longer than 512 bytes.
2121
2122 * xfns.c (x_window): Make sprintf buffer a bit bigger
2123 to avoid potential buffer overrun.
2124
2125 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2126
2127 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2128
2129 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2130
2131 Integer overflow fixes for scrolling, etc.
2132 Without these, Emacs silently mishandles large integers sometimes.
2133 For example, "C-u 4294967297 M-x recenter" was treated as if
2134 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2135
2136 * xdisp.c (try_window_id): Check Emacs fixnum range before
2137 converting to 'int'.
2138
2139 * window.c (window_scroll_line_based, Frecenter):
2140 Check that an Emacs fixnum is in range before assigning it to 'int'.
2141 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2142 values converted from Emacs fixnums.
2143 (Frecenter): Don't wrap around a line count if it is out of 'int'
2144 range; instead, treat it as an extreme value.
2145 (Fset_window_configuration, compare_window_configurations):
2146 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2147
2148 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2149 that can exceed INT_MAX. Check that EMACS_INT value is in range
2150 before assigning it to the (possibly-narrower) index.
2151 (match_limit): Don't assume that a fixnum can fit in 'int'.
2152
2153 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2154 exceed INT_MAX.
2155
2156 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2157 (Fvertical_motion): Don't wrap around LINES values that don't fit
2158 in 'int'. Instead, treat them as extreme values. This is good
2159 enough for windows, which can't have more than INT_MAX lines anyway.
2160
2161 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2162
2163 * Require libxml/parser.h to avoid compilation warning.
2164
2165 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2166
2167 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2168 since this reportedly can destroy thread storage.
2169
2170 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2171
2172 * syntax.c (find_defun_start): Update all cache variables if
2173 exiting early (Bug#9401).
2174
2175 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2176
2177 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2178
2179 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2180 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2181 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2182
2183 * term.c (tty_append_glyph): New function.
2184 (produce_stretch_glyph): Static function and its prototype deleted.
2185
2186 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2187 Add prototypes.
2188
2189 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2190
2191 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2192 when checking :margin (Bug#9390).
2193 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2194 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2195 so that the name doesn't mislead. All uses changed.
2196
2197 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2198
2199 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2200 set_tty_hooks.
2201
2202 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2203
2204 * xdisp.c (move_it_to): Don't bail out early when reaching
2205 position beyond to_charpos, if we are scanning backwards.
2206 (move_it_vertically_backward): When DY == 0, make sure we get to
2207 the first character in the line after the newline.
2208
2209 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2210
2211 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2212 (ccl_driver): Do not generate an out-of-range pointer.
2213 (Fccl_execute_on_string): Remove unnecessary check for
2214 integer overflow, noted by Stefan Monnier in
2215 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2216 Remove a FIXME that didn't need fixing.
2217 Simplify the newly-introduced buffer reallocation code.
2218
2219 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2220
2221 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2222
2223 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2224
2225 Integer and memory overflow issues (Bug#9196).
2226
2227 * doc.c (get_doc_string): Rework so that
2228 get_doc_string_buffer_size is the actual buffer size, rather than
2229 being 1 less than the actual buffer size; this makes xpalloc more
2230 convenient.
2231
2232 * image.c (x_allocate_bitmap_record, cache_image):
2233 * xselect.c (Fx_register_dnd_atom):
2234 Simplify previous changes by using xpalloc.
2235
2236 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2237 since either will do and ptrdiff_t is convenient with xpalloc.
2238
2239 * charset.c (charset_table_size)
2240 (struct charset_sort_data.priority): Now ptrdiff_t.
2241 (charset_compare): Don't overflow if priorities differ greatly.
2242 (Fsort_charsets): Don't assume list length fits in int.
2243 Check for size-calculation overflow when allocating sort data.
2244 (syms_of_charset): Allocate an initial charset table that is
2245 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2246
2247 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2248
2249 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2250 The actual value is always <= INT_MAX, and leaving it unsigned made
2251 overflow checking harder.
2252
2253 * dispextern.h (struct glyph_matrix.rows_allocated)
2254 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2255 with xpalloc. The values are still always <= INT_MAX.
2256
2257 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2258
2259 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2260 (SAFE_NALLOCA): New macro.
2261
2262 * region-cache.c (struct boundary.pos, find_cache_boundary)
2263 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2264 (set_cache_region, invalidate_region_cache)
2265 (revalidate_region_cache, know_region_cache, region_cache_forward)
2266 (region_cache_backward, pp_cache):
2267 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2268 so that ptrdiff_t * can be passed to xpalloc.
2269 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2270 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2271 (pp_cache): Don't assume cache_len fits in int.
2272 * region-cache.h: Adjust extern decls to match.
2273
2274 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2275 EMACS_INT, since either will do, for xpalloc.
2276
2277 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2278 (xnmalloc, xnrealloc, xpalloc): New functions.
2279
2280 * bidi.c (bidi_shelve_header_size): New constant.
2281 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2282 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2283
2284 * bidi.c (bidi_cache_shrink):
2285 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2286 (overlay_strings):
2287 Don't update size of array until after memory allocation succeeds,
2288 because xmalloc/xrealloc may not return.
2289 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2290 now that we have proper integer overflow checking.
2291 (record_overlay_string, overlay_strings): Catch overflows when
2292 calculating size of overlay_str_buf.
2293
2294 * callproc.c (Fcall_process): Check for size overflow when
2295 calculating size of args2.
2296 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2297 Normally we prefer signed values, but sticking with ptrdiff_t would
2298 require adding more-complicated checks.
2299
2300 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2301 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2302 Redo buffer-overflow calculations to avoid integer overflow.
2303 Add a FIXME comment where memory seems to be over-allocated.
2304
2305 * character.c (Fstring): Check for size-calculation overflow.
2306
2307 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2308 unnecessary integer overflow. Check for size overflow.
2309 (encode_coding_object): Don't update size until xmalloc succeeds.
2310
2311 * composite.c (get_composition_id): Check for overflow in glyph
2312 length calculations.
2313
2314 Integer and memory overflow fixes for display code.
2315 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2316 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2317 (scrolling_window): Check for overflow in size calculations.
2318 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2319 Don't assume glyph table len fits in int.
2320 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2321 (row_table_size): Now ptrdiff_t, not int.
2322 (scrolling_window): Avoid overflow in size calculations.
2323 Don't update size until allocation succeeds.
2324 * fns.c (concat): Check for overflow in size calculations.
2325 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2326 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2327 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2328
2329 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2330 (get_doc_string): Check for size calculation overflow.
2331 Don't update size until allocation succeeds.
2332 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2333 EMACS_INT, where ptrdiff_t will do.
2334 (Fsubstitute_command_keys): Check for string overflow.
2335
2336 * editfns.c (set_time_zone_rule): Don't assume environment length
2337 fits in int.
2338 (message_length): Now ptrdiff_t, not int.
2339 (Fmessage_box): Don't update size until allocation succeeds.
2340 Don't assume message length fits in int.
2341 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2342
2343 * emacs.c (main): Do not reallocate argv, since there is a null at
2344 the end that can be overwritten, and this way there's no need to
2345 worry about size-calculation overflow.
2346 (sort_args): Check for size-calculation overflow.
2347
2348 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2349 alloc succeeds.
2350 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2351
2352 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2353 (x_set_scroll_bar_width, x_figure_window_size):
2354 Check for integer overflow.
2355 (x_set_alpha): Do not assume XINT fits in int.
2356
2357 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2358 This is for the members text_lines, text_cols, total_lines, total_cols,
2359 where the system imposes an 'int' limit.
2360
2361 * fringe.c (Fdefine_fringe_bitmap):
2362 Don't update size until alloc works.
2363
2364 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2365 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2366
2367 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2368 Check for size-calculation overflow.
2369 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2370 do, as we prefer signed integers.
2371 (id_to_widget.max_size, id_to_widget.used)
2372 (xg_store_widget_in_map, xg_remove_widget_from_map)
2373 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2374 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2375 Use and return ptrdiff_t, not int.
2376 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2377 * gtkutil.h: Change prototypes to match the above.
2378
2379 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2380 are duplicate now that they've been promoted to lisp.h.
2381 (x_allocate_bitmap_record, x_alloc_image_color)
2382 (make_image_cache, cache_image, xpm_load):
2383 Don't update size until alloc is done.
2384 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2385 (x_detect_edges):
2386 Check for size calculation overflow.
2387 (ct_colors_allocated_max): New constant.
2388 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2389 overflow.
2390
2391 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2392 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2393 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2394 Use ptrdiff_t, not int, to count maps.
2395 (read_char_minibuf_menu_prompt): Check for overflow in size
2396 calculations. Don't update size until allocation succeeds.
2397 Redo calculations to avoid overflow.
2398 * keyboard.h: Change prototypes to match the above.
2399
2400 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2401 to count maps.
2402 (current_minor_maps): Check for size calculation overflow.
2403 * keymap.h: Change prototypes to match the above.
2404
2405 * lread.c (read1, init_obarray): Don't update size until alloc done.
2406
2407 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2408 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2409
2410 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2411 Now ptrdiff_t, not int.
2412 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2413 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2414
2415 * process.c (Fnetwork_interface_list): Check for overflow
2416 in size calculation.
2417
2418 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2419
2420 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2421 overflow. Don't bother calling xmalloc when xrealloc will do.
2422
2423 * search.c (Freplace_match): Check for size calculation overflow.
2424 (Fset_match_data): Don't assume list lengths fit in 'int'.
2425
2426 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2427 for command line length. Do not attempt to address one before the
2428 beginning of an array, as that's not portable.
2429
2430 * term.c (max_frame_lines): Remove; unused.
2431 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2432 not int.
2433 (encode_terminal_code, calculate_costs): Check for size
2434 calculation overflow.
2435 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2436 table lengths and related sizes. Don't update size until alloc
2437 done. Redo calculations to avoid overflow.
2438 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2439
2440 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2441 subtracting pointers.
2442 (gobble_line): Check for overflow more carefully. Don't update size
2443 until alloc done.
2444
2445 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2446 Don't update size until alloc done.
2447 Redo size calculations to avoid overflow.
2448 Check for size calculation overflow.
2449 (main) [DEBUG]: Fix typo in invoking tparam1.
2450
2451 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2452 Use ptrdiff_t, not int, for sizes.
2453 (store_mode_line_noprop_char): Don't update size until alloc done.
2454
2455 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2456 Use ptrdiff_t, not int, for sizes.
2457 (Finternal_make_lisp_face, cache_face):
2458 Check for size calculation overflow.
2459 (cache_face): Treat size calculation overflows as if they were
2460 memory exhaustion (the usual treatment), rather than aborting.
2461
2462 * xfns.c (x_encode_text, x_set_name_internal)
2463 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2464 sizes, since they can exceed INT_MAX in size. Check for size
2465 calculation overflow.
2466
2467 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2468 (xg_select): Check for size calculation overflow.
2469 Don't update size until alloc done.
2470
2471 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2472 as sprintf is limited to int lengths.
2473
2474 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2475 (X_LONG_MIN): New macros.
2476 Use them to make the following changes clearer.
2477 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2478 This change doesn't affect the value now, but it may help remind
2479 future maintainers not to raise the value too much later.
2480 (SELECTION_QUANTUM): Remove, replacing with ...
2481 (selection_quantum): ... new function, which avoids overflow.
2482 All uses changed.
2483 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2484 assumption that selection length fits in 'int'.
2485 (x_reply_selection_request, x_handle_selection_request)
2486 (x_get_window_property, receive_incremental_selection)
2487 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2488 (lisp_data_to_selection_data, clean_local_selection_data):
2489 Use ptrdiff_t, not int, to record length of selection.
2490 (x_reply_selection_request, x_get_window_property)
2491 (receive_incremental_selection, x_property_data_to_lisp):
2492 Redo calculations to avoid overflow.
2493 (x_reply_selection_request): When sending hint, ceiling it at
2494 X_LONG_MAX rather than relying on wraparound overflow to send
2495 something.
2496 (x_get_window_property, receive_incremental_selection)
2497 (lisp_data_to_selection_data, x_property_data_to_lisp):
2498 Check for size-calculation overflow.
2499 (x_get_window_property, receive_incremental_selection)
2500 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2501 Don't store size until memory allocation succeeds.
2502 (x_get_window_property): Plug memory leak on memory exhaustion.
2503 Don't double-block input; malloc is safe here. Don't assume 2**34
2504 - 4 fits in unsigned long. Add an xassert to check
2505 XGetWindowProperty overflow. Be more careful about overflow
2506 calculations, and distinguish size from memory overflow better.
2507 (receive_incremental_selection): When tracing, don't assume
2508 unsigned int is less than INT_MAX.
2509 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2510 harmful) conversions of unsigned short to int.
2511 (lisp_data_to_selection_data): Don't assume that integers
2512 in the range -65535 through -1 fit in an X unsigned short.
2513 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2514 result parameters unless successful. Rely on cons_to_unsigned
2515 to report problems with elements; the old code wasn't right anyway.
2516 (x_check_property_data): Check for int overflow; we cannot use
2517 a wider type due to X limits.
2518 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2519
2520 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2521
2522 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2523 (x_term_init): Check for size calculation overflow.
2524 (x_color_cells): Don't store size until memory allocation succeeds.
2525 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2526 Don't assume alloca size is less than MAX_ALLOCA.
2527 (x_term_init): Don't assume length fits in int (sprintf is limited
2528 to int size).
2529
2530 Use ptrdiff_t for composition IDs.
2531 * character.c (lisp_string_width):
2532 * composite.c (composition_table_size, n_compositions)
2533 (get_composition_id, composition_gstring_from_id):
2534 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2535 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2536 * window.c (Frecenter):
2537 Use ptrdiff_t, not int, for composition IDs.
2538 * composite.c (get_composition_id): Check for integer overflow.
2539 * composite.h: Adjust prototypes to match the above changes.
2540
2541 Use ptrdiff_t for hash table indexes.
2542 * category.c (hash_get_category_set):
2543 * ccl.c (ccl_driver):
2544 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2545 * coding.c (coding_system_charset_list, detect_coding_system):
2546 * coding.h (struct coding_system.id):
2547 * composite.c (get_composition_id, gstring_lookup_cache):
2548 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2549 * image.c (xpm_get_color_table_h):
2550 * lisp.h (hash_lookup, hash_put):
2551 * minibuf.c (Ftest_completion):
2552 Use ptrdiff_t for hash table indexes, not int (which is too
2553 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2554 32-bit --with-wide-int hosts).
2555
2556 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2557 Add a FIXME comment about memory leaks.
2558 (syms_of_charset): Don't assume xmalloc returns.
2559
2560 Don't assume that stated character widths fit in int.
2561 * character.c (Fchar_width, c_string_width, lisp_string_width):
2562 * character.h (CHAR_WIDTH):
2563 * indent.c (MULTIBYTE_BYTES_WIDTH):
2564 Use sanitize_char_width to avoid undefined and/or bad behavior
2565 with outlandish widths.
2566 * character.h (sanitize_tab_width): Rename from sanitize_width,
2567 now that we have two such functions. All uses changed.
2568 (sanitize_char_width): New inline function.
2569
2570 Don't assume that tab-width fits in int.
2571 * character.h (sanitize_width): New inline function.
2572 (SANE_TAB_WIDTH): New macro.
2573 (ASCII_CHAR_WIDTH): Use it.
2574 * indent.c (sane_tab_width): Remove. All uses replaced by
2575 SANE_TAB_WIDTH (current_buffer).
2576 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2577
2578 * fileio.c: Integer overflow issues with file modes.
2579 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2580
2581 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2582 Remove unreachable code.
2583 (read_hex, load_charset_map_from_file): Check for integer overflow.
2584
2585 * xterm.c: Don't go over XClientMessageEvent limit.
2586 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2587 (x_send_scroll_bar_event): Likewise. Check that the size does not
2588 exceed limits imposed by XClientMessageEvent, as well as the usual
2589 ptrdiff_t and size_t limits.
2590
2591 * keyboard.c: Overflow, signedness and related fixes.
2592 (make_lispy_movement): Use same integer type in forward decl
2593 that is used in the definition.
2594 (read_key_sequence, keyremap_step):
2595 Change bufsize argument back to int, undoing my 2011-03-30 change.
2596 We prefer signed types, and int is wide enough here.
2597 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2598 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2599 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2600 length, not size_t. Use ptrdiff_t for index, not int.
2601 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2602 possibility of integer overflow.
2603
2604 Overflow, signedness and related fixes for images.
2605
2606 * dispextern.h (struct it.stack[0].u.image.image_id)
2607 (struct_it.image_id, struct image.id, struct image_cache.size)
2608 (struct image_cache.used, struct image_cache.ref_count):
2609 * gtkutil.c (update_frame_tool_bar):
2610 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2611 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2612 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2613 * nsmenu.m (update_frame_tool_bar):
2614 * xdisp.c (calc_pixel_width_or_height):
2615 * xfns.c (image_cache_refcount):
2616 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2617 on typical 64-bit hosts.
2618
2619 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2620 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2621 Omit unnecessary casts to int.
2622 (parse_image_spec): Check that integers fall into 'int' range
2623 when the callers expect that.
2624 (image_ascent): Redo ascent calculation to avoid int overflow.
2625 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2626 (lookup_image): Remove unnecessary tests.
2627 (xbm_image_p): Locals are now of int, not EMACS_INT,
2628 since parse_image_check makes sure they fit into int.
2629 (png_load, gif_load, svg_load_image):
2630 Prefer int to unsigned where either will do.
2631 (tiff_handler): New function, combining the cores of the
2632 old tiff_error_handler and tiff_warning_handler.
2633 This function is rewritten to use vsnprintf and thereby avoid
2634 stack buffer overflows. It uses only the features of vsnprintf
2635 that are common to both POSIX and native Microsoft.
2636 (tiff_error_handler, tiff_warning_handler): Use it.
2637 (tiff_load, gif_load, imagemagick_load_image):
2638 Don't assume :index value fits in 'int'.
2639 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2640 (imagemagick_load_image): Check that crop parameters fit into
2641 the integer types that MagickCropImage accepts. Don't assume
2642 Vimagemagick_render_type has a nonnegative value. Don't assume
2643 size_t fits in 'long'.
2644 (gs_load): Use printmax_t to print the widest integers possible.
2645 Check for integer overflow when computing image height and width.
2646
2647 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2648
2649 * xdisp.c (redisplay_window): Don't force window start if point
2650 will be invisible in the resulting window. (Bug#9324)
2651
2652 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2653
2654 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2655 the display spec is of the form `(space ...)'.
2656 (handle_display_spec): Return the value returned by
2657 handle_single_display_spec, not just 1 or zero.
2658 (handle_single_display_spec): If the display spec is of the form
2659 `(space ...)', and specifies display in the text area, return 2
2660 rather than 1.
2661 (try_cursor_movement): Check for the need to scroll more
2662 accurately, and prefer exact match for point under bidi.
2663 Don't advance `row' beyond the last row of the window.
2664
2665 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2666 into disp_prop; all users changed.
2667
2668 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2669 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2670 for the text covered by the display property.
2671
2672 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2673
2674 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2675 Change return value to nil.
2676 (Frecord_buffer): Delete unused function.
2677
2678 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2679
2680 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2681 buffers, return left-to-right.
2682 (set_cursor_from_row): Consider candidate row a win if its glyph
2683 represents a newline and point is on that newline. Fixes cursor
2684 positioning on the newline at EOL of R2L text within L2R
2685 paragraph, and vice versa.
2686 (try_cursor_movement): Check continued rows, in addition to
2687 continuation rows. Fixes unwarranted scroll when point enters a
2688 continued line of R2L text within an L2R paragraph, or vice versa.
2689 (cursor_row_p): Consider the case of point being equal to
2690 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2691 from the end of a short line to the beginning of a continued line
2692 of R2L text within L2R paragraph.
2693 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2694 composed characters.
2695
2696 * bidi.c (bidi_check_type): Use xassert.
2697 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2698 members.
2699
2700 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2701
2702 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2703 a character.
2704
2705 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2706
2707 * nsfont.m (ns_otf_to_script): Fix typo.
2708
2709 2011-08-22 Kenichi Handa <handa@m17n.org>
2710
2711 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2712 extra slot even if the purpose is char-code-property-table.
2713
2714 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2715
2716 * xdisp.c (redisplay_window): When computing centering_position,
2717 account for the height of the header line. (Bug#8874)
2718
2719 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2720 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2721 candidate is selected by the mouse, and that candidate has a
2722 composed character under the mouse.
2723
2724 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2725 coordinates reported by pos-visible-in-window-p for a composed
2726 character in column zero.
2727
2728 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2729
2730 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2731
2732 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2733
2734 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2735 consider it a hit if to_charpos is anywhere in the range of the
2736 composed buffer positions.
2737
2738 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2739
2740 * image.c (gif_load): Don't assume that each subimage has the same
2741 dimensions as the base image. Handle disposal method that is
2742 "undefined" by the gif spec (Bug#9335).
2743
2744 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2745
2746 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2747 (Fcondition_case): Document `debug' symbol in error handler.
2748
2749 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2750
2751 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2752 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2753 from an Org mode buffer to a Speedbar frame.
2754
2755 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2756 a composition, take its buffer position from IT->cmp_it.charpos.
2757 Fixes cursor positioning at the beginning of a line that begins
2758 with a composed character.
2759
2760 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2761
2762 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2763 character bidirectional type, use STRONG_L instead. Fixes crashes
2764 in a buffer produced by `describe-categories'.
2765
2766 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2767 members before the level stack, so they would be saved and
2768 restored when copying iterator state. Fixes incorrect reordering
2769 around TABs covered by display properties.
2770
2771 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2772
2773 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2774
2775 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2776
2777 * eval.c (internal_condition_case, internal_condition_case_1)
2778 (internal_condition_case_2, internal_condition_case_n):
2779 Remove unnecessary aborts (Bug#9081).
2780
2781 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2782
2783 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2784 has no `load' handler, try opening the file locally. (Bug#9311)
2785
2786 2011-08-16 Ken Brown <kbrown@cornell.edu>
2787
2788 * gmalloc.c: Expand comment.
2789
2790 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2791
2792 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2793 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2794
2795 2011-08-16 Ken Brown <kbrown@cornell.edu>
2796
2797 Fix memory allocation problems in Cygwin build (Bug#9273).
2798
2799 * unexcw.c ( __malloc_initialized): Declare external variable.
2800 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2801
2802 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2803 New variables.
2804 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2805 dumped emacs.
2806 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2807 in the static heap.
2808 [CYGWIN] (special_realloc): New function.
2809 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2810 requests to realloc storage in the static heap.
2811
2812 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2813
2814 * bidi.c (bidi_initialize): Remove unused local.
2815
2816 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2817
2818 * bidimirror.h:
2819 * biditype.h: Remove file.
2820 * makefile.w32-in ($(BLD)/bidi.$(O)):
2821 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2822
2823 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2824
2825 * chartab.c: Improve commentary for the uniprop_table API.
2826
2827 * bidi.c (bidi_paragraph_init): Support zero value of
2828 bidi_ignore_explicit_marks_for_paragraph_level.
2829 (bidi_initialize): Use uniprop_table instead of including
2830 biditype.h and bidimirror.h.
2831
2832 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2833 coordinates of the iterator when restoring from ppos_it.
2834 (Bug#9296)
2835
2836 2011-08-14 Kenichi Handa <handa@m17n.org>
2837
2838 * process.c (create_process): Call setup_process_coding_systems
2839 after the pid of the process is set to -1 (Bug#8162).
2840
2841 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2842
2843 * xdisp.c (move_it_in_display_line_to): Don't invoke
2844 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2845 ppos_it. Fixes vertical cursor motion when line beginning is
2846 covered by an image. (Bug#9296)
2847
2848 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2849
2850 * nsterm.h (ns_run_ascript): Declare.
2851 (NSAPP_DATA2_RUNASSCRIPT): Define.
2852
2853 * nsfns.m (as_script, as_result, as_status): New static variables.
2854 (ns_run_ascript): New function.
2855 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2856 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2857 the event loop. Get status from as_status (Bug#7276).
2858
2859 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2860 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2861 the event loop (Bug#7276).
2862
2863 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2864
2865 * gnutls.c (QCgnutls_bootprop_priority)
2866 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2867 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2868 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2869 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2870 (QCgnutls_bootprop_verify_hostname_error)
2871 (QCgnutls_bootprop_callbacks_verify): Rename from
2872 Qgnutls_bootprop_..., all uses changed.
2873
2874 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2875 uses changed.
2876
2877 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2878
2879 * xfaces.c (Qframe_set_background_mode): Now static.
2880 * dispextern.h (Qframe_set_background_mode): Remove decl.
2881
2882 * process.c (Fnetwork_interface_info): Declare local only if needed.
2883
2884 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2885
2886 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2887 (Fnetwork_interface_list): Allocate in increments of bytes instead
2888 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2889 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2890 sockaddr.
2891 (struct ifflag_def): notrailers is smart on OSX.
2892 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2893 Get hardware address with getifaddrs if available.
2894
2895 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2896
2897 * xdisp.c (iterate_out_of_display_property): xassert that
2898 IT->position is set to within IT->object's boundaries. Break from
2899 the loop as soon as EOB is reached; avoids infloops in redisplay
2900 when IT->position is set up wrongly due to some bug.
2901 Set IT->current to match the bidi iterator unconditionally.
2902 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2903 entry. Force push_it to save on the stack the current
2904 buffer/string position, to be restored by pop_it. Fix flags in
2905 the iterator structure wrt the object coming from a display
2906 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2907 properties. (Bug#9284)
2908
2909 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2910
2911 * fontset.c (fontset_get_font_group): Add proper type checks.
2912 (Bug#9172)
2913
2914 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2915
2916 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2917 and LC_VERSION_MIN_MACOSX.
2918 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2919 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2920
2921 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2922
2923 * xdisp.c (forward_to_next_line_start): Allow to use the
2924 no-display-properties-and-no-overlays under bidi display.
2925 Set disp_pos in the bidi iterator to avoid searches for display
2926 properties and overlays.
2927
2928 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2929
2930 * editfns.c (Fset_time_zone_rule): Document relationship with the
2931 setenv function.
2932
2933 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2934 the font entity extracted from the cache (Bug#8109).
2935
2936 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2937
2938 * composite.c (autocmp_chars): Don't reset point. That is done by
2939 restore_point_unwind (Bug#5984).
2940
2941 2011-08-07 Juri Linkov <juri@jurta.org>
2942
2943 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2944 to show the arg `TIME' instead of `TIMEVAL'.
2945
2946 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2947
2948 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2949 display property strides EOL and includes a newline, as in
2950 longlines-mode. (Bug#9254)
2951 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2952 word-wrap under bidirectional display. (Bug#9224)
2953
2954 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2955 is non-zero, even if the data buffer is NULL. Fixes a crash in
2956 vertical-motion with longlines-mode. (Bug#9254)
2957
2958 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2959
2960 * bidi.c <bidi_cache_total_alloc>: Now static.
2961 (bidi_initialize): Initialize bidi_cache_total_alloc.
2962
2963 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2964 cache. (Bug#9221)
2965
2966 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2967 amount allocated this far in `bidi_cache_total_alloc'.
2968 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2969 non-zero, only free the data buffer without restoring the cache
2970 contents. All callers changed.
2971
2972 * dispextern.h (bidi_unshelve_cache): Update prototype.
2973
2974 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2975 (move_it_in_display_line, move_it_to)
2976 (move_it_vertically_backward, move_it_by_lines): Replace the call
2977 to xfree to an equivalent call to bidi_unshelve_cache.
2978 (move_it_in_display_line_to): Fix logic of returning
2979 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2980
2981 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2982
2983 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2984 came from a string character with a `cursor' property. (Bug#9229)
2985
2986 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2987
2988 * Makefile.in (LIB_PTHREAD): New variable.
2989 (LIBES): Add LIB_PTHREAD (Bug#9216).
2990
2991 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2992 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2993
2994 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2995
2996 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2997
2998 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2999
3000 * xterm.c (x_find_topmost_parent): New function.
3001 (x_set_frame_alpha): Find topmost parent window with
3002 x_find_topmost_parent and set the property there also (bug#9181).
3003 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3004
3005 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3006
3007 * callproc.c (Fcall_process): Avoid vfork clobbering
3008 the local vars buffer, coding_systems, current_dir.
3009
3010 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3011
3012 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3013
3014 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3015
3016 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3017 so that it is not optimized away.
3018
3019 * xdisp.c (compute_display_string_pos): Remove unused local.
3020
3021 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3022
3023 Fix slow cursor motion and scrolling in large buffers with
3024 selective display, like Org Mode buffers. (Bug#9218)
3025
3026 * dispextern.h (struct bidi_it): New member disp_prop_p.
3027
3028 * xdisp.c: Remove one-slot cache of display string positions.
3029 (compute_display_string_pos): Accept an additional argument
3030 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3031 for a display string or property. If found, set DISP_PROP_P
3032 non-zero.
3033
3034 * bidi.c (bidi_fetch_char): Accept an additional argument
3035 DISP_PROP_P, and pass it to compute_display_string_pos.
3036 Only handle text covered by a display string if DISP_PROP_P is returned
3037 non-zero. All callers of bidi_fetch_char changed.
3038
3039 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3040
3041 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3042
3043 2010-12-03 Don March <don@ohspite.net>
3044
3045 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3046 last character M-[char] is translated to ESC [char] (bug#7541).
3047
3048 2011-08-02 Kenichi Handa <handa@m17n.org>
3049
3050 * lisp.h (uniprop_table): Extern it.
3051
3052 * chartab.c (uniprop_table): Make it non-static.
3053
3054 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3055
3056 * xdisp.c (forward_to_next_line_start): Accept additional argument
3057 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3058 on the newline.
3059 (reseat_at_next_visible_line_start): Use the bidi iterator state
3060 returned by forward_to_next_line_start to restore the state of
3061 it->bidi_it after backing up to previous newline. (Bug#9212)
3062
3063 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3064
3065 * regex.c (re_comp): Protoize.
3066 (re_exec): Fix return type.
3067 (regexec): Fix type of `ret'. (Bug#9203)
3068
3069 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3070
3071 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3072 This is needed if max-image-size is a floating-point number.
3073
3074 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3075
3076 * print.c (print_object): Print empty symbol as ##.
3077
3078 * lread.c (read1): Read ## as empty symbol.
3079
3080 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3081
3082 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3083 setting frame foreground color (Bug#9175).
3084 (x_set_background_color): Likewise.
3085
3086 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3087 contents (Bug#9176).
3088 (EmacsTooltip -init): Remove bezels and add shadows to
3089 tooltip windows.
3090
3091 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3092 or scroll bar (Bug#8470).
3093
3094 * nsfont.m (nsfont_open): Remove assignment to voffset and
3095 unnecessary vars hshink, expand, hd, full_height, min_height.
3096 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3097
3098 * nsterm.h (nsfont_info): Remove voffset field.
3099
3100 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3101
3102 Implement strike-through and overline on NextStep (Bug#8863).
3103
3104 * nsfont.m (nsfont_open): Use underline position provided by font,
3105 instead of hard-coded value of 2.
3106 (nsfont_draw): Call ns_draw_text_decoration instead.
3107
3108 * nsterm.h: Add declaration for ns_draw_text_decoration.
3109
3110 * nsterm.m (ns_draw_text_decoration): New function for drawing
3111 underline, overline, and strike-through.
3112 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3113 ns_draw_text_decoration. Change treatment of cursor drawing to
3114 accommodate underlining, etc.
3115
3116 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3117
3118 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3119 default.
3120
3121 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3122
3123 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3124 Without this fix, if a signal arrives just after memory fills up,
3125 'malloc' might be invoked reentrantly.
3126
3127 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3128 In other words, assume that every image size is allowed, on non-X
3129 hosts. This assumption is probably wrong, but it lets Emacs compile.
3130
3131 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3132
3133 * regex.c (re_iswctype): Convert return values to boolean.
3134
3135 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3136
3137 * xdisp.c (compute_display_string_pos): Don't use cached display
3138 string position if the buffer had its restriction changed.
3139 (Bug#9184)
3140
3141 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3142
3143 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3144
3145 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3146
3147 Integer signedness and overflow and related fixes. (Bug#9079)
3148
3149 * bidi.c: Integer size and overflow fixes.
3150 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3151 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3152 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3153 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3154 (bidi_find_other_level_edge):
3155 Use ptrdiff_t instead of EMACS_INT where either will do.
3156 This works better on 32-bit hosts configured --with-wide-int.
3157 (bidi_cache_ensure_space): Check for size-calculation overflow.
3158 Use % rather than repeated addition, for better worst-case speed.
3159 Don't set bidi_cache_size until after xrealloc returns, because it
3160 might not return.
3161 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3162 (bidi_cache_ensure_space): Also check that the bidi cache size
3163 does not exceed that of the largest Lisp string or buffer. See Eli
3164 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3165
3166 * alloc.c (__malloc_size_t): Remove.
3167 All uses replaced by size_t. See Andreas Schwab's note
3168 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3169
3170 * image.c: Improve checking for integer overflow.
3171 (check_image_size): Assume that f is nonnull, since
3172 it is always nonnull in practice. This is one less thing to
3173 worry about when checking for integer overflow later.
3174 (x_check_image_size): New function, which checks for integer
3175 overflow issues inside X.
3176 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3177 This removes the need for a memory_full check.
3178 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3179 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3180 (xbm_read_bitmap_data): Change locals back to 'int', since
3181 their values must fit in 'int'.
3182 (xpm_load_image, png_load, tiff_load):
3183 Invoke x_create_x_image_and_pixmap earlier,
3184 to avoid much needless work if the image is too large.
3185 (tiff_load): Treat overly large images as if
3186 x_create_x_image_and_pixmap failed, not as malloc failures.
3187 (gs_load): Use x_check_image_size.
3188
3189 * gtkutil.c: Omit integer casts.
3190 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3191 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3192
3193 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3194
3195 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3196 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3197 would wrongly return t on a 64-bit host.
3198
3199 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3200 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3201 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3202 and therefore cause GCC to emit a bogus diagnostic in some cases.
3203
3204 * image.c: Integer signedness and overflow and related fixes.
3205 This is not an exhaustive set of fixes, but it's time to
3206 record what I've got.
3207 (lookup_pixel_color, check_image_size): Remove redundant decls.
3208 (check_image_size): Don't assume that arbitrary EMACS_INT values
3209 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3210 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3211 (tiff_load, imagemagick_load_image):
3212 Check for overflow in size calculations.
3213 (x_create_x_image_and_pixmap): Remove unnecessary test for
3214 xmalloc returning NULL; that can't happen.
3215 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3216 (xpm_color_bucket): Use better integer hashing function.
3217 (xpm_cache_color): Don't possibly over-allocate memory.
3218 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3219 (gif_memory_source):
3220 Use ptrdiff_t, not int or size_t, to record sizes.
3221 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3222 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3223 either works, as we prefer signed integers.
3224 (tiff_read_from_memory, tiff_write_from_memory):
3225 Return tsize_t, not size_t, since that's what the TIFF API wants.
3226 (tiff_read_from_memory): Don't fail simply because the read would
3227 go past EOF; instead, return a short read.
3228 (tiff_load): Omit no-longer-needed casts.
3229 (Fimagemagick_types): Don't assume size fits into 'int'.
3230
3231 Improve hashing quality when configured --with-wide-int.
3232 * fns.c (hash_string): New function, taken from sxhash_string.
3233 Do not discard information about ASCII character case; this
3234 discarding is no longer needed.
3235 (sxhash-string): Use it. Change sig to match it. Caller changed.
3236 * lisp.h: Declare it.
3237 * lread.c (hash_string): Remove, since we now use fns.c's version.
3238 The fns.c version returns a wider integer if --with-wide-int is
3239 specified, so this should help the quality of the hashing a bit.
3240
3241 * emacs.c: Integer overflow minor fix.
3242 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3243 Define only if GNU_LINUX.
3244 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3245
3246 * dispnew.c: Integer signedness and overflow fixes.
3247 Remove unnecessary forward decls, that were a maintenance hassle.
3248 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3249 All uses changed.
3250 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3251 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3252 (prepare_desired_row, line_draw_cost):
3253 Use int, not unsigned, where either works.
3254 (save_current_matrix, restore_current_matrix):
3255 Use ptrdiff_t, not size_t, where either works.
3256 (init_display): Check for overflow more accurately, and without
3257 relying on undefined behavior.
3258
3259 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3260 Remove, replacing with the new symbols in lisp.h. All uses changed.
3261 * fileio.c (make_temp_name):
3262 * filelock.c (lock_file_1, lock_file):
3263 * xdisp.c (message_dolog):
3264 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3265 Use pMd etc. instead.
3266 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3267 replacing the pWIDE etc. symbols removed from editfns.c.
3268
3269 * keyboard.h (num_input_events): Now uintmax_t.
3270 This is (very slightly) less likely to mess up due to wraparound.
3271 All uses changed.
3272
3273 * buffer.c: Integer signedness fixes.
3274 (alloc_buffer_text, enlarge_buffer_text):
3275 Use ptrdiff_t rather than size_t when either will do, as we prefer
3276 signed integers.
3277
3278 * alloc.c: Integer signedness and overflow fixes.
3279 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3280 (__malloc_size_t): Default to size_t, not to int.
3281 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3282 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3283 Prefer ptrdiff_t to size_t when either would do, as we prefer
3284 signed integers.
3285 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3286 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3287 Now const. Initialize with values that are in range even if char
3288 is signed.
3289 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3290 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3291 These functions do the right thing with sizes > 2**32.
3292 (check_depth): Now ptrdiff_t, not int.
3293 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3294 Adjust to new way of storing sizes. Check for size overflow bugs
3295 in rest of code.
3296 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3297 slightly wrong anyway, as it missed one instance of
3298 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3299 (refill_memory_reserve): Omit needless cast to size_t.
3300 (mark_object_loop_halt): Mark as externally visible.
3301
3302 * xselect.c: Integer signedness and overflow fixes.
3303 (Fx_register_dnd_atom, x_handle_dnd_message):
3304 Use ptrdiff_t, not size_t, since we prefer signed.
3305 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3306 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3307 x_dnd_atoms_size and x_dnd_atoms_length.
3308
3309 * doprnt.c: Prefer signed to unsigned when either works.
3310 * eval.c (verror):
3311 * doprnt.c (doprnt):
3312 * lisp.h (doprnt):
3313 * xdisp.c (vmessage):
3314 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3315 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3316 prefer signed arithmetic to avoid comparison confusion.
3317 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3318 but is a bit tricky.
3319
3320 Assume freestanding C89 headers, string.h, stdlib.h.
3321 * data.c, doprnt.c, floatfns.c, print.c:
3322 Include float.h unconditionally.
3323 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3324 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3325 * regex.c: Likewise for stddef.h, string.h.
3326 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3327 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3328 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3329 (STDC_HEADERS): Remove obsolete defines.
3330 * sysdep.c: Include limits.h unconditionally.
3331
3332 Assume support for memcmp, memcpy, memmove, memset.
3333 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3334 * regex.c (memcmp, memcpy):
3335 Remove; we assume C89 now.
3336
3337 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3338 (__malloc_safe_bcopy): Remove; no longer needed.
3339
3340 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3341 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3342 well either way, and we prefer signed to unsigned.
3343
3344 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3345
3346 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3347 closes the connection while we're reading (bug#9182).
3348
3349 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3350
3351 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3352 are specified (Bug#9168).
3353
3354 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3355
3356 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3357 Found by GCC static checking and --with-wide-int on a 32-bit host.
3358
3359 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3360
3361 * xdisp.c (compute_display_string_pos): Fix logic of caching
3362 previous display string position. Initialize cached_prev_pos to
3363 -1. Fixes slow-down at the beginning of a buffer.
3364
3365 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3366
3367 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3368 for attrs[LFACE_FONTSET_INDEX].
3369
3370 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3371
3372 * xml.c (parse_region): Remove unused local
3373 that was recently introduced.
3374
3375 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3376
3377 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3378 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3379
3380 * xdisp.c (move_it_in_display_line_to): Record the best matching
3381 position for TO_CHARPOS while scanning the line, and restore it on
3382 exit if none of the characters scanned was an exact match.
3383 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3384 when exact match is impossible due to invisible text, and the
3385 lines are truncated.
3386
3387 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3388
3389 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3390 for OSX >= 10.7.
3391
3392 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3393
3394 Fix a significant slow-down of cursor motion with C-n, C-p,
3395 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3396 auto-repeat under bidi redisplay in fontified buffers.
3397 * xdisp.c (compute_stop_pos_backwards): New function.
3398 (next_element_from_buffer): Call compute_stop_pos_backwards to
3399 find a suitable prev_stop when we find ourselves before
3400 base_level_stop.
3401 (reseat): Don't look for prev_stop, as that could mean a very long
3402 run.
3403 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3404 <cached_disp_overlay_modiff>: Cache for last found display string
3405 position.
3406 (compute_display_string_pos): Return the cached position if asked
3407 about the same buffer in the same area of character positions, and
3408 the buffer wasn't changed since the time the display string
3409 position was cached.
3410
3411 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3412
3413 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3414 is an integer, which is important for empty lines. (Bug#9149)
3415
3416 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3417
3418 * frame.c (Fmodify_frame_parameters): In tty case, update the
3419 default face if necessary (Bug#4238).
3420
3421 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3422
3423 * editfns.c (Fstring_to_char): No need to explain what a character
3424 is in the docstring (Bug#6576).
3425
3426 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3427
3428 * xml.c (parse_region): Make sure we always return a tree.
3429
3430 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3431
3432 * xml.c (parse_region): If a document contains only comments,
3433 return that, too.
3434
3435 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3436
3437 * xml.c (make_dom): Return comments, too.
3438
3439 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3440
3441 Port to OpenBSD.
3442 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3443 and the surrounding thread.
3444 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3445 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3446 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3447 timer goes off.
3448 * s/openbsd.h (BROKEN_SIGIO): Define.
3449 * unexelf.c (unexec) [__OpenBSD__]:
3450 Don't update the .mdebug section of the Alpha COFF symbol table.
3451
3452 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3453
3454 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3455 (bug#8460).
3456
3457 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3458
3459 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3460 This fixes some race conditions on the permissions of any newly
3461 created file.
3462
3463 * alloc.c (valid_pointer_p): Use pipe, not open.
3464 This fixes some permissions issues when debugging.
3465
3466 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3467 If fchown fails to set both uid and gid, try to set just gid,
3468 as that is sometimes allowed. Adjust the file's mode to eliminate
3469 setuid or setgid bits that are inappropriate if fchown fails.
3470
3471 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3472
3473 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3474 to compare Lisp_Objects.
3475 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3476 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3477 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3478
3479 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3480
3481 * lread.c (read_integer): Unread even EOF character.
3482 (read1): Likewise. Properly record start position of symbol.
3483
3484 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3485 symbol character follows.
3486
3487 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3488
3489 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3490 This works around a problem with the previous change to Fcopy_file.
3491 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3492 and without this change, GCC might complain about discarding
3493 fchown's return value.
3494
3495 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3496
3497 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3498
3499 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3500
3501 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3502
3503 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3504
3505 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3506 it's used from the C level.
3507
3508 * process.c: Use the same condition for POLL_FOR_INPUT in both
3509 keyboard.c and process.c (bug#1858).
3510
3511 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3512
3513 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3514 (Fgnutls_boot): Use it.
3515
3516 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3517
3518 * doc.c (Fsubstitute_command_keys): Revert last change.
3519
3520 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3521
3522 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3523 quotes the next character, and doesn't affect other longer
3524 sequences (bug#8935).
3525
3526 * lread.c (syms_of_lread): Clarify that is isn't only
3527 `eval-buffer' and `eval-defun' that's affected by
3528 `lexical-binding' (bug#8460).
3529
3530 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3531
3532 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3533 bidi redisplay when a line includes both an image and is truncated.
3534
3535 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3536
3537 Fix minor problems found by static checking.
3538 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3539 (elsz): Now a signed constant, not a size_t var. We prefer signed
3540 types to unsigned, to avoid integer comparison confusion. Without
3541 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3542 "cannot optimize loop, the loop counter may overflow", a symptom
3543 of the confusion.
3544 * indent.c (Fvertical_motion): Mark locals as initialized.
3545 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3546
3547 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3548
3549 * search.c (Fre_search_backward): Mention `case-fold-search' in
3550 all the re_search_* functions (bug#8138).
3551
3552 * keyboard.c (Fopen_dribble_file): Document when the file is
3553 closed (bug#8056).
3554
3555 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3556
3557 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3558 bidi_cache_idx.
3559
3560 Support bidi reordering of display and overlay strings.
3561 * xdisp.c (compute_display_string_pos)
3562 (compute_display_string_end): Accept additional argument STRING.
3563 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3564 (reseat_to_string): Initialize bidi_it->string.s and
3565 bidi_it->string.schars.
3566 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3567 NULL (avoids a crash in bidi_paragraph_init).
3568 Initialize itb.string.lstring.
3569 (init_iterator): Call bidi_init_it only of a valid
3570 buffer position was specified. Initialize paragraph_embedding to
3571 L2R.
3572 (reseat_to_string): Initialize the bidi iterator.
3573 (display_string): If we need to ignore text properties of
3574 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3575 original value of -1 will not work with bidi.)
3576 (compute_display_string_pos): First arg is now struct
3577 `text_pos *'; all callers changed. Support display properties on
3578 Lisp strings.
3579 (compute_display_string_end): Support display properties on Lisp
3580 strings.
3581 (init_iterator, reseat_1, reseat_to_string): Initialize the
3582 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3583 when iterating on a string not from display properties).
3584 (compute_display_string_pos, compute_display_string_end):
3585 Fix calculation of the object to scan. Fixes an error when using
3586 arrow keys.
3587 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3588 base_level_stop; instead, set base_level_stop to BEGV.
3589 Fixes crashes in vertical-motion.
3590 (next_element_from_buffer): Improve commentary for when
3591 the iterator is before prev_stop.
3592 (init_iterator): Initialize bidi_p from the default value of
3593 bidi-display-reordering, not from buffer-local value. Use the
3594 buffer-local value only if initializing for buffer iteration.
3595 (handle_invisible_prop): Support invisible properties on strings
3596 that are being bidi-reordered.
3597 (set_iterator_to_next): Support bidi reordering of C strings and
3598 Lisp strings.
3599 (next_element_from_string): Support bidi reordering of Lisp
3600 strings.
3601 (handle_stop_backwards): Support Lisp strings as well.
3602 (display_string): Support display of R2L glyph rows.
3603 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3604 (init_iterator): Don't initialize it->bidi_p for strings
3605 here.
3606 (reseat_to_string): Initialize it->bidi_p for strings here.
3607 (next_element_from_string, next_element_from_c_string)
3608 (next_element_from_buffer): Add xassert's for correspondence
3609 between IT's object being iterated and it->bidi_it.string
3610 structure.
3611 (face_before_or_after_it_pos): Support bidi iteration.
3612 (next_element_from_c_string): Handle the case of the first string
3613 character that is not the first one in the visual order.
3614 (get_visually_first_element): New function, refactored from common
3615 parts of next_element_from_buffer, next_element_from_string, and
3616 next_element_from_c_string.
3617 (tool_bar_lines_needed, redisplay_tool_bar)
3618 (display_menu_bar): Force left-to-right direction. Add a FIXME
3619 comment for making that be controlled by a user option.
3620 (push_it, pop_it): Save and restore the state of the
3621 bidi iterator. Save and restore the bidi_p flag.
3622 (pop_it): Iterate out of display property for string iteration as
3623 well.
3624 (iterate_out_of_display_property): Support iteration over strings.
3625 (handle_single_display_spec): Set up it->bidi_it for iteration
3626 over a display string, and call bidi_init_it.
3627 (handle_single_display_spec, next_overlay_string)
3628 (get_overlay_strings_1, push_display_prop): Set up the bidi
3629 iterator for displaying display or overlay strings.
3630 (forward_to_next_line_start): Don't use the shortcut if
3631 bidi-iterating.
3632 (back_to_previous_visible_line_start): If handle_display_prop
3633 pushed the iterator stack, restore the internal state of the bidi
3634 iterator by calling bidi_pop_it same number of times.
3635 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3636 and we are bidi-iterating, don't decrement the iterator position;
3637 instead, set the first_elt flag in the bidi iterator, to produce
3638 the same effect.
3639 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3640 (push_display_prop): xassert that we are iterating a buffer.
3641 (push_it, pop_it): Save and restore paragraph_embedding member.
3642 (handle_single_display_spec, next_overlay_string)
3643 (get_overlay_strings_1, reseat_1, reseat_to_string)
3644 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3645 correctly. Don't assume unibyte strings are not bidi-reordered.
3646 (compute_display_string_pos)
3647 (compute_display_string_end): Fix handling the case of C string.
3648 (push_it, pop_it): Save and restore from_disp_prop_p.
3649 (handle_single_display_spec, push_display_prop): Set the
3650 from_disp_prop_p flag.
3651 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3652 (pop_it): Call iterate_out_of_display_property only if we are
3653 popping after iteration over a string that came from a display
3654 property. Fix a typo in popping stretch info. Add an assertion
3655 for verifying that the iterator position is in sync with the bidi
3656 iterator.
3657 (handle_single_display_spec, get_overlay_strings_1)
3658 (push_display_prop): Fix initialization of paragraph direction for
3659 string when that of the parent object is not yet determined.
3660 (reseat_1): Call bidi_init_it to resync the bidi
3661 iterator with IT's position. (Bug#7616)
3662 (find_row_edges): If ROW->start.pos gives position
3663 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3664 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3665 Reset the from_disp_prop_p flag.
3666 (SAVE_IT, RESTORE_IT): New macros.
3667 (pos_visible_p, face_before_or_after_it_pos)
3668 (back_to_previous_visible_line_start)
3669 (move_it_in_display_line_to, move_it_in_display_line)
3670 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3671 (try_scrolling, redisplay_window, display_line): Use them when
3672 saving a temporary copy of the iterator and restoring it back.
3673 (back_to_previous_visible_line_start, reseat_1)
3674 (init_iterator): Empty the bidi cache "stack".
3675 (move_it_in_display_line_to): If iterator ended up at
3676 EOL, but we never saw any buffer positions smaller than
3677 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3678 motion in bidi-reordered lines.
3679 (move_it_in_display_line_to): Record prev_method and prev_pos
3680 immediately before the call to set_iterator_to_next. Fixes cursor
3681 motion in bidi-reordered lines with stretch glyphs and strings
3682 displayed in margins. (Bug#8133) (Bug#8867)
3683 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3684 TO_CHARPOS.
3685 (pos_visible_p): Support positions in bidi-reordered lines.
3686 Save and restore bidi cache.
3687
3688 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3689 (bidi_paragraph_info): Delete unused struct.
3690 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3691 (bidi_cache_start): New variable.
3692 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3693 to zero.
3694 (bidi_cache_fetch_state, bidi_cache_search)
3695 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3696 (bidi_cache_find, bidi_peek_at_next_level)
3697 (bidi_level_of_next_char, bidi_find_other_level_edge)
3698 (bidi_move_to_visually_next): Compare cache index with
3699 bidi_cache_start rather than with zero.
3700 (bidi_fetch_char): Accept new argument STRING; all callers
3701 changed. Support iteration over a string. Support strings with
3702 display properties. Support unibyte strings. Fix the type of
3703 `len' according to what STRING_CHAR_AND_LENGTH expects.
3704 (bidi_paragraph_init, bidi_resolve_explicit_1)
3705 (bidi_resolve_explicit, bidi_resolve_weak)
3706 (bidi_level_of_next_char, bidi_move_to_visually_next):
3707 Support iteration over a string.
3708 (bidi_set_sor_type, bidi_resolve_explicit_1)
3709 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3710 can now be zero (for strings); special values 0 and -1 were
3711 changed to -1 and -2, respectively.
3712 (bidi_char_at_pos): New function.
3713 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3714 Call it instead of FETCH_MULTIBYTE_CHAR.
3715 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3716 initialized to valid values.
3717 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3718 values.
3719 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3720 the test for valid cached positions. Fix the logic for looking up
3721 the sentinel state in the cache. GCPRO the Lisp string we are
3722 iterating.
3723 (bidi_push_it, bidi_pop_it): New functions.
3724 (bidi_initialize): Initialize the bidi cache start stack pointer.
3725 (bidi_cache_ensure_space): New function, refactored from part of
3726 bidi_cache_iterator_state. Don't assume the required size is just
3727 one BIDI_CACHE_CHUNK away.
3728 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3729 (bidi_count_bytes, bidi_char_at_pos): New functions.
3730 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3731 always valid if bidi_cache_idx is valid.
3732 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3733 is valid if it's going to be used.
3734 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3735 (bidi_cache_fetch_state, bidi_cache_search)
3736 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3737 (bidi_cache_iterator_state, bidi_cache_find)
3738 (bidi_find_other_level_edge, bidi_cache_start_stack):
3739 All variables related to cache indices are now EMACS_INT.
3740
3741 * dispextern.h (struct bidi_string_data): New structure.
3742 (struct bidi_it): New member `string'. Make flag members be 1-bit
3743 fields, and put them last in the struct.
3744 (compute_display_string_pos, compute_display_string_end):
3745 Update prototypes.
3746 (bidi_push_it, bidi_pop_it): Add prototypes.
3747 (struct iterator_stack_entry): New members bidi_p,
3748 paragraph_embedding, and from_disp_prop_p.
3749 (struct it): Member bidi_p is now a bit field 1 bit wide.
3750 (bidi_shelve_cache, bidi_unshelve_cache):
3751 Declare prototypes.
3752
3753 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3754 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3755 and vector-like objects.
3756
3757 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3758 cache around display iteration.
3759
3760 * window.c (Fwindow_end, window_scroll_pixel_based)
3761 (displayed_window_lines, Frecenter): Save and restore the bidi
3762 cache around display iteration.
3763
3764 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3765
3766 * editfns.c (Fdelete_region): Clarify the use of the named
3767 parameters (bug#6788).
3768
3769 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3770
3771 * indent.c (Fvertical_motion): Set and restore w->pointm when
3772 saving and restoring the window's buffer (Bug#9006).
3773
3774 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3775
3776 * editfns.c (Fstring_to_char): Clarify just what is returned
3777 (bug#6576). Text by Eli Zaretskii.
3778
3779 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3780
3781 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3782
3783 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3784
3785 * buffer.c (mmap_find): Fix a typo.
3786
3787 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3788
3789 Fix execution of x selection hooks.
3790 * xselect.c (Qx_lost_selection_functions)
3791 (Qx_sent_selection_functions): New vars.
3792 (syms_of_xselect): DEFSYM them.
3793 (x_handle_selection_request): Pass Qx_sent_selection_functions
3794 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3795 (x_handle_selection_clear,x_clear_frame_selections):
3796 Pass Qx_lost_selection_functions rather than
3797 Vx_lost_selection_functions to Frun_hook_with_args.
3798
3799 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3800
3801 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3802 The old code sometimes used this field without initializing it.
3803
3804 * alloc.c (gc_sweep): Don't read past end of array.
3805 In theory, the old code could also have corrupted Emacs internals,
3806 though it'd be very unlikely.
3807
3808 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3809
3810 * character.c (Fcharacterp): Don't advertise optional ignored
3811 argument. (Bug#4026)
3812
3813 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3814
3815 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3816 key" (bug#4257).
3817
3818 * window.c (Fset_window_start): Doc fix (bug#4199).
3819 (Fset_window_hscroll): Ditto.
3820
3821 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3822
3823 Fix minor new problems caught by GCC 4.6.1.
3824 * term.c (init_tty): Remove unused local.
3825 * xsettings.c (store_monospaced_changed): Define this function only
3826 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3827 not used otherwise.
3828
3829 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3830
3831 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3832
3833 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3834
3835 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3836 are the mini-buffer and the echo area (bug#3320).
3837
3838 * term.c (init_tty): Remove support for supdup, c10 and perq
3839 terminals, which are no longer supported (bug#1482).
3840
3841 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3842
3843 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3844
3845 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3846
3847 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3848 for non-popups (Bug#3642).
3849
3850 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3851
3852 * alloc.c (reset_malloc_hooks): Protoize.
3853 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3854 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3855 * cm.c (losecursor): Likewise.
3856 * data.c (fmod): Likewise.
3857 * dispnew.c (swap_glyphs_in_rows): Likewise.
3858 * emacs.c (memory_warning_signal): Likewise.
3859 * floatfns.c (float_error): Likewise.
3860 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3861 (otf_open, font_otf_capability, generate_otf_features)
3862 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3863 Likewise.
3864 * image.c (pbm_read_file): Likewise.
3865 * indent.c (string_display_width): Likewise.
3866 * intervals.c (check_for_interval, search_for_interval)
3867 (inc_interval_count, count_intervals, root_interval)
3868 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3869 * lread.c (defalias): Likewise.
3870 * ralloc.c (r_alloc_check): Likewise.
3871 * regex.c (set_image_of_range_1, set_image_of_range)
3872 (regex_grow_registers): Likewise.
3873 * sysdep.c (strerror): Likewise.
3874 * termcap.c (valid_filename_p, tprint, main): Likewise.
3875 * tparam.c (main): Likewise.
3876 * unexhp9k800.c (run_time_remap, save_data_space)
3877 (update_file_ptrs, read_header, write_header, calculate_checksum)
3878 (copy_file, copy_rest, display_header): Likewise.
3879 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3880 Likewise.
3881 * xdisp.c (check_it): Likewise.
3882 * xfaces.c (register_color, unregister_color, unregister_colors):
3883 Likewise.
3884 * xfns.c (print_fontset_result): Likewise.
3885 * xrdb.c (member, fatal, main): Likewise.
3886
3887 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3888
3889 Fix minor problems found by static checking (Bug#9031).
3890 * chartab.c (char_table_set_range, map_sub_char_table):
3891 Remove unused locals.
3892 (uniprop_table): Now static.
3893 * composite.c (_work_char): Remove unused static var.
3894
3895 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3896
3897 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3898
3899 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3900
3901 * gtkutil.c (qttip_cb): Remove code without function.
3902
3903 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3904
3905 * w32.c (pthread_sigmask): New stub.
3906
3907 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3908
3909 Use pthread_sigmask, not sigprocmask (Bug#9010).
3910 sigprocmask is portable only for single-threaded applications, and
3911 Emacs can be multi-threaded when it uses GTK.
3912 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3913 (LIBES): Use it.
3914 * callproc.c (Fcall_process):
3915 * process.c (create_process):
3916 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3917 Use pthread_sigmask, not sigprocmask.
3918
3919 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3920
3921 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3922 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3923 wrong (Bug#8591).
3924
3925 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3926
3927 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3928 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3929 (xg_hide_tooltip): Fix comment.
3930
3931 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3932 in registerServicesMenuSendTypes.
3933 (validRequestorForSendType): Don't check ns_return_types.
3934
3935 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3936 ns_return_type.
3937
3938 2011-07-08 Jason Rumney <jasonr@gnu.org>
3939
3940 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3941 SH_SHOW for hidden windows (Bug#5482).
3942
3943 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3944 frame struct members of non-existent frames (Bug#6284).
3945
3946 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3947
3948 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3949 variable firstTime not needed on OSX >= 10.6.
3950 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3951 >= 10.5. Use setKnobProportion, setDoubleValue.
3952
3953 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3954 (MAC_OS_X_VERSION_10_5): Define if not defined.
3955 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3956 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3957 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3958
3959 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3960 cString and lossyCString on OSX >= 10.4
3961
3962 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3963 sizeToFit on OSX >= 10.2.
3964
3965 * nsimage.m (allocInitFromFile): Don't use deprecated method
3966 bestRepresentationForDevice on OSX >= 10.6.
3967
3968 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3969 to avoid warning.
3970
3971 * emacs.c: Declare unexec_init_emacs_zone.
3972
3973 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3974
3975 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3976
3977 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3978 on svcsMenu (Bug#8842).
3979
3980 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3981 ns_return_types.
3982 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3983
3984 * nsterm.m (QUTF8_STRING): Declare.
3985 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3986 (validRequestorForSendType): Return type is (id).
3987 Change indexOfObjectIdenticalTo to indexOfObject.
3988 Check if we have local selection before returning self (Bug#8842).
3989 (writeSelectionToPasteboard): Put local selection into paste board
3990 if we have a local selection (Bug#8842).
3991 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3992
3993 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3994 (ns_get_local_selection): Declare.
3995
3996 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3997
3998 * keymap.c (describe_map_tree): Don't insert a double newline at
3999 the end of the buffer (bug#1169) and return whether we inserted
4000 something.
4001
4002 * callint.c (Fcall_interactively): Change "reading args" to
4003 "providing args" to try to clarify what it does (bug#1010).
4004
4005 2011-07-07 Kenichi Handa <handa@m17n.org>
4006
4007 * composite.c (composition_compute_stop_pos): Ignore a static
4008 composition starting before CHARPOS (Bug#8915).
4009
4010 * xdisp.c (handle_composition_prop): Likewise.
4011
4012 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4013
4014 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4015 (Bug#9015)
4016
4017 2011-07-07 Kenichi Handa <handa@m17n.org>
4018
4019 * character.h (unicode_category_t): New enum type.
4020
4021 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4022 (Qchar_code_property_table): New variable.
4023 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4024 (UNIPROP_COMPRESSED_FORM_P): New macros.
4025 (char_table_ascii): Uncompress the compressed values.
4026 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4027 Uncompress the compressed values.
4028 (sub_char_table_ref_and_range): Likewise.
4029 (char_table_ref_and_range): Uncompress the compressed values.
4030 (sub_char_table_set): New arg is_uniprop. Callers changed.
4031 Uncompress the compressed values.
4032 (sub_char_table_set_range): Args changed. Callers changed.
4033 (char_table_set_range): Adjuted for the above change.
4034 (map_sub_char_table): Delete args default_val and parent. Add arg
4035 top. Give decoded values to a Lisp function.
4036 (map_char_table): Adjust for the above change. Give decoded
4037 values to a Lisp function. Gcpro more variables.
4038 (uniprop_table_uncompress)
4039 (uniprop_decode_value_run_length): New functions.
4040 (uniprop_decoder, uniprop_decoder_count): New variables.
4041 (uniprop_get_decoder, uniprop_encode_value_character)
4042 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4043 New functions.
4044 (uniprop_encoder, uniprop_encoder_count): New variables.
4045 (uniprop_get_encoder, uniprop_table)
4046 (Funicode_property_table_internal, Fget_unicode_property_internal)
4047 (Fput_unicode_property_internal): New functions.
4048 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4049 Sunicode_property_table_internal, Sget_unicode_property_internal,
4050 and Sput_unicode_property_internal. Defvar_lisp
4051 char-code-property-alist.
4052
4053 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4054 Vunicode_category_table.
4055
4056 * font.c (font_range): Adjust for the change of
4057 Vunicode_category_table.
4058
4059 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4060
4061 * m/iris4d.h: Remove file, move contents ...
4062 * s/irix6-5.h: ... here.
4063
4064 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4065
4066 Remove unportable assumption about struct layout (Bug#8884).
4067 * alloc.c (mark_buffer):
4068 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4069 (clone_per_buffer_values): Don't assume that
4070 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4071 This isn't true in general, and it's particularly not true
4072 if Emacs is configured with --with-wide-int.
4073 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4074 New macros, used in the buffer.c change.
4075
4076 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4077
4078 * xsettings.c: Use both GConf and GSettings if both are available.
4079 (store_config_changed_event): Add comment.
4080 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4081 (store_tool_bar_style_changed): New functions.
4082 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4083 (struct xsettings): Move font inside HAVE_XFT.
4084 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4085 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4086 Move inside HAVE_XFT.
4087 (something_changed_gsettingsCB): Rename from something_changedCB.
4088 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4089 also.
4090 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4091 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4092 (something_changed_gconfCB): Rename from something_changedCB.
4093 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4094 (parse_settings): Move check for font inside HAVE_XFT.
4095 (read_settings, apply_xft_settings): Add comment.
4096 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4097 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4098 call store_font_name_changed.
4099 (xft_settings_event): Add comment.
4100 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4101 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4102 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4103 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4104 (xsettings_initialize): Call init_gsettings last.
4105 (xsettings_get_system_font, xsettings_get_system_normal_font):
4106 Add comment.
4107
4108 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4109
4110 Random fixes. E.g., (random) never returned negative values.
4111 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4112 subseconds part to the entropy, as that's a bit more random.
4113 Prefer signed to unsigned, since the signedness doesn't matter and
4114 in general we prefer signed. When given a limit, use a
4115 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4116 latter isn't right if USE_2_TAGS_FOR_INTS.
4117 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4118 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4119
4120 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4121
4122 * textprop.c (text_property_stickiness):
4123 Obey Vtext_property_default_nonsticky.
4124 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4125 * w32fns.c (syms_of_w32fns):
4126 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4127
4128 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4129
4130 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4131 This is more efficient than Ffile_directory_p and avoids a minor race.
4132
4133 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4134
4135 * buffer.c (Foverlay_put): Say what the return value is
4136 (bug#7835).
4137
4138 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4139 is a directory before asking whether to use the file name
4140 (bug#7564).
4141 (barf_or_query_if_file_exists): Make the "File is a directory"
4142 error be more correct.
4143
4144 * fns.c (Frequire): Remove the mention of the .gz files, since
4145 that's installation-specific, but keep the mention of
4146 `get-load-suffixes'.
4147
4148 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4149
4150 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4151 Report string overflow if the output is too long.
4152
4153 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4154
4155 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4156 (syms_of_gnutls): Remove duplicate DEFSYM for
4157 Qgnutls_bootprop_verify_hostname_error, an error for
4158 Qgnutls_bootprop_verify_error (which is no longer used).
4159
4160 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4161 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4162 Also (re)move comments that are misplaced or no longer relevant.
4163
4164 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4165
4166 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4167
4168 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4169
4170 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4171 and background color parameters if they have been changed.
4172
4173 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4174
4175 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4176
4177 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4178
4179 * xsettings.c (SYSTEM_FONT): Define only when used.
4180 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4181
4182 * keymap.c (access_keymap_1): Now static.
4183
4184 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4185
4186 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4187 leave any prefix arg for the up event (Bug#1586).
4188
4189 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4190
4191 * lread.c (syms_of_lread): Mention single symbols defined by
4192 `defvar' or `defconst' (bug#7154).
4193
4194 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4195 (Frequire): Mention get-load-suffixes.
4196
4197 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4198
4199 * window.h (window): Remove clone_number slot.
4200 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4201 Remove.
4202 (make_parent_window, make_window, saved_window)
4203 (Fset_window_configuration, save_window_save): Don't deal with
4204 clone numbers.
4205 * buffer.c (Qclone_number): Remove declaration.
4206 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4207
4208 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4209
4210 Add multiple inheritance to keymaps.
4211 * keymap.c (Fmake_composed_keymap): New function.
4212 (Fset_keymap_parent): Simplify.
4213 (fix_submap_inheritance): Remove.
4214 (access_keymap_1): New function extracted from access_keymap to handle
4215 embedded parents and handle lists of maps.
4216 (access_keymap): Use it.
4217 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4218 (Fcopy_keymap): Handle embedded parents.
4219 (Fcommand_remapping, define_as_prefix): Simplify.
4220 (Fkey_binding): Simplify.
4221 (syms_of_keymap): Move minibuffer-local-completion-map,
4222 minibuffer-local-filename-completion-map,
4223 minibuffer-local-must-match-map, and
4224 minibuffer-local-filename-must-match-map to Elisp.
4225 (syms_of_keymap): Defsubr make-composed-keymap.
4226 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4227 (parse_menu_item): Trivial simplification.
4228
4229 2011-07-01 Glenn Morris <rgm@gnu.org>
4230
4231 * Makefile.in (SETTINGS_LIBS): Fix typo.
4232
4233 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4234
4235 * coding.c (Fencode_coding_string): Record the last coding system
4236 used, as the function doc string says (bug#8738).
4237
4238 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4239
4240 * xsettings.c (store_monospaced_changed): Take new font as arg and
4241 check for change against current_mono_font.
4242 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4243 (emacs_settings_constructor, emacs_settings_get_property)
4244 (emacs_settings_set_property, emacs_settings_class_init)
4245 (emacs_settings_init, gsettings_obj): Remove.
4246 (something_changedCB): New function for HAVE_GSETTINGS.
4247 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4248 with value as argument.
4249 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4250 g_settings_new (Bug#8967). Do not create gsettings_obj.
4251 Remove calls to g_settings_bind. Connect something_changedCB to
4252 "changed".
4253
4254 * xgselect.c: Add defined (HAVE_GSETTINGS).
4255 (xgselect_initialize): Ditto.
4256
4257 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4258 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4259 xg_select.
4260
4261 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4262
4263 * eval.c (struct backtrace): Simplify and port the data structure.
4264 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4265 signed bit field, as this assumption is not portable and it makes
4266 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4267 "char debug_on_exit : 1" as this is not portable either; instead,
4268 use the portable "unsigned int debug_on_exit : 1". Remove unused
4269 member evalargs. Remove obsolete comments about cc bombing out.
4270
4271 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4272
4273 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4274 Let HAVE_GSETTINGS override HAVE_GCONF.
4275 (store_monospaced_changed): New function.
4276 (EMACS_SETTINGS): A new type derived from GObject to handle
4277 GSettings notifications.
4278 (emacs_settings_constructor, emacs_settings_get_property)
4279 (emacs_settings_set_property, emacs_settings_class_init):
4280 New functions.
4281 (gsettings_client, gsettings_obj): New variables.
4282 (GSETTINGS_SCHEMA): New define.
4283 (something_changedCB): Call store_monospaced_changed.
4284 (init_gsettings): New function.
4285 (xsettings_initialize): Call init_gsettings.
4286 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4287 to NULL.
4288
4289 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4290 GCONF_CFLAGS/LIBS.
4291
4292 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4293
4294 * window.c (resize_root_window, grow_mini_window)
4295 (shrink_mini_window): Rename Qresize_root_window to
4296 Qwindow_resize_root_window and Qresize_root_window_vertically to
4297 Qwindow_resize_root_window_vertically.
4298
4299 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4300
4301 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4302
4303 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4304
4305 * makefile.w32-in: Redesign dependencies so they reflect more
4306 clearly which files are directly included by each source file,
4307 and not through other includes.
4308
4309 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4310
4311 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4312 (sort_overlays, overlay_strings): When an overlay's clone number
4313 matches the window's clone number process the overlay even if
4314 the overlay's window property doesn't match the current window.
4315
4316 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4317 (Fwindow_hchild): Rename to Fwindow_left_child.
4318 (Fwindow_next): Rename to Fwindow_next_sibling.
4319 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4320 (resize_window_check): Rename to window_resize_check.
4321 (resize_window_apply): Rename to window_resize_apply.
4322 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4323 (Fdelete_other_windows_internal, resize_frame_windows)
4324 (Fsplit_window_internal, Fdelete_window_internal)
4325 (grow_mini_window, shrink_mini_window)
4326 (Fresize_mini_window_internal): Fix callers accordingly.
4327
4328 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4329
4330 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4331 (emacs_fixed_set_min_size): Remove.
4332 (emacs_fixed_new): Take frame as argument.
4333
4334 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4335 (_EmacsFixedPrivate): Remove minwidth/height.
4336 Add struct frame *f.
4337 (emacs_fixed_init): Initialize priv->f.
4338 (get_parent_class, emacs_fixed_set_min_size): Remove.
4339 (emacs_fixed_new): Set priv->f to argument.
4340 (emacs_fixed_get_preferred_width)
4341 (emacs_fixed_get_preferred_height): Use min_width/height from
4342 frames size_hint to set minimum and natural (Bug#8919).
4343 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4344 and use min_width/height from frames size_hint to set
4345 min_width/height (Bug#8919).
4346
4347 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4348 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4349 Fix indentation.
4350
4351 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4352
4353 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4354 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4355 called at ZV.
4356
4357 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4358
4359 * process.c (wait_reading_process_output): Bypass select if
4360 waiting for a cell while ignoring keyboard input, and input is
4361 pending. Suggested by Jan Djärv (Bug#8869).
4362
4363 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4364
4365 Use gnulib's dup2 module instead of rolling our own.
4366 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4367
4368 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4369
4370 * dispnew.c (scrolling_window): Before scrolling, turn off a
4371 mouse-highlight in the window being scrolled.
4372
4373 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4374
4375 Move DEFSYM to lisp.h and use everywhere.
4376
4377 * character.h (DEFSYM): Move declaration...
4378 * lisp.h (DEFSYM): ...here.
4379
4380 * gnutls.c:
4381 * minibuf.c:
4382 * w32menu.c:
4383 * w32proc.c:
4384 * w32select.c: Don't include character.h.
4385
4386 * alloc.c (syms_of_alloc):
4387 * buffer.c (syms_of_buffer):
4388 * bytecode.c (syms_of_bytecode):
4389 * callint.c (syms_of_callint):
4390 * casefiddle.c (syms_of_casefiddle):
4391 * casetab.c (init_casetab_once):
4392 * category.c (init_category_once, syms_of_category):
4393 * ccl.c (syms_of_ccl):
4394 * cmds.c (syms_of_cmds):
4395 * composite.c (syms_of_composite):
4396 * dbusbind.c (syms_of_dbusbind):
4397 * dired.c (syms_of_dired):
4398 * dispnew.c (syms_of_display):
4399 * doc.c (syms_of_doc):
4400 * editfns.c (syms_of_editfns):
4401 * emacs.c (syms_of_emacs):
4402 * eval.c (syms_of_eval):
4403 * fileio.c (syms_of_fileio):
4404 * fns.c (syms_of_fns):
4405 * frame.c (syms_of_frame):
4406 * fringe.c (syms_of_fringe):
4407 * insdel.c (syms_of_insdel):
4408 * keymap.c (syms_of_keymap):
4409 * lread.c (init_obarray, syms_of_lread):
4410 * macros.c (syms_of_macros):
4411 * msdos.c (syms_of_msdos):
4412 * print.c (syms_of_print):
4413 * process.c (syms_of_process):
4414 * search.c (syms_of_search):
4415 * sound.c (syms_of_sound):
4416 * syntax.c (init_syntax_once, syms_of_syntax):
4417 * terminal.c (syms_of_terminal):
4418 * textprop.c (syms_of_textprop):
4419 * undo.c (syms_of_undo):
4420 * w32.c (globals_of_w32):
4421 * window.c (syms_of_window):
4422 * xdisp.c (syms_of_xdisp):
4423 * xfaces.c (syms_of_xfaces):
4424 * xfns.c (syms_of_xfns):
4425 * xmenu.c (syms_of_xmenu):
4426 * xsettings.c (syms_of_xsettings):
4427 * xterm.c (syms_of_xterm): Use DEFSYM.
4428
4429 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4430
4431 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4432
4433 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4434
4435 Integer and buffer overflow fixes (Bug#8873).
4436
4437 * print.c (printchar, strout): Check for string overflow.
4438 (PRINTPREPARE, printchar, strout):
4439 Don't set size unless allocation succeeds.
4440
4441 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4442 for sizes. Check for string overflow more accurately.
4443 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4444
4445 * macros.c: Integer and buffer overflow fixes.
4446 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4447 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4448 Use ptrdiff_t, not int, for sizes.
4449 Don't increment bufsize until after realloc succeeds.
4450 Check for size-calculation overflow.
4451 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4452
4453 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4454
4455 * lread.c: Integer overflow fixes.
4456 (read_integer): Radix is now EMACS_INT, not int,
4457 to improve quality of diagnostics for out-of-range radices.
4458 Calculate buffer size correctly for out-of-range radices.
4459 (read1): Check for integer overflow in radices, and in
4460 read-circle numbers.
4461 (read_escape): Avoid int overflow.
4462 (Fload, openp, read_buffer_size, read1)
4463 (substitute_object_recurse, read_vector, read_list, map_obarray):
4464 Use ptrdiff_t, not int, for sizes.
4465 (read1): Use EMACS_INT, not int, for sizes.
4466 Check for size overflow.
4467
4468 * image.c (cache_image): Check for size arithmetic overflow.
4469
4470 * lread.c: Integer overflow issues.
4471 (saved_doc_string_size, saved_doc_string_length)
4472 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4473 Now ptrdiff_t, not int.
4474 (read1): Don't assume doc string length fits in int. Check for
4475 out-of-range doc string lengths.
4476 (read_list): Don't assume file position fits in int.
4477 (read_escape): Check for hex character overflow.
4478
4479 2011-06-22 Leo Liu <sdl.web@gmail.com>
4480
4481 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4482 Move to minibuffer.el.
4483
4484 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4485
4486 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4487 The following patches are for when GLYPH_DEBUG && !XASSERT.
4488 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4489 * dispnew.c (flush_stdout):
4490 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4491 Mark as externally visible.
4492 * dispnew.c (check_window_matrix_pointers): Now static.
4493 * dispnew.c (window_to_frame_vpos):
4494 * xfns.c (unwind_create_frame):
4495 * xterm.c (x_check_font): Remove unused local.
4496 * scroll.c (CHECK_BOUNDS):
4497 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4498 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4499 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4500 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4501 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4502 Now static.
4503 (debug_method_add): Use va_list and vsprintf rather than relying
4504 on undefined behavior with wrong number of arguments.
4505 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4506 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4507 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4508 since we're not interested in debugging glyphs with old libraries.
4509 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4510 GCC 4.6.0's static checking.
4511
4512 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4513
4514 Integer overflow and signedness fixes (Bug#8873).
4515 A few related buffer overrun fixes, too.
4516
4517 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4518
4519 * dispextern.h (struct face.stipple):
4520 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4521 (x_bitmap_mask, x_allocate_bitmap_record)
4522 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4523 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4524 (x_create_bitmap_from_xpm_data):
4525 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4526 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4527 (.bitmaps_last):
4528 * xfaces.c (load_pixmap):
4529 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4530 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4531 (.bitmaps_last, struct x_output.icon_bitmap):
4532 Use ptrdiff_t, not int, for bitmap indexes.
4533 (x_allocate_bitmap_record): Check for size overflow.
4534 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4535
4536 Use ptrdiff_t, not int, for overlay counts.
4537 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4538 * editfns.c (overlays_around, get_pos_property):
4539 * textprop.c (get_char_property_and_overlay):
4540 * xdisp.c (next_overlay_change, note_mouse_highlight):
4541 * xfaces.c (face_at_buffer_position):
4542 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4543 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4544 (Fnext_overlay_change, Fprevious_overlay_change)
4545 (mouse_face_overlay_overlaps, Foverlays_in):
4546 Use ptrdiff_t, not int, for sizes.
4547 (overlays_at, overlays_in): Check for size-calculation overflow.
4548
4549 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4550
4551 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4552 (x_session_initialize): Do not assume string length fits in int.
4553
4554 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4555 This is unlikely, but can occur if DPI is outlandish.
4556
4557 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4558 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4559
4560 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4561 * xrdb.c (magic_file_p, search_magic_path):
4562 Omit last arg SUFFIX; it was always 0. All callers changed.
4563 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4564
4565 * xfont.c (xfont_match): Avoid need for strlen.
4566
4567 * xfns.c: Don't assume strlen fits in int.
4568 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4569
4570 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4571 not unsigned long, as we prefer signed integers. All callers changed.
4572 Detect integer overflow in repeat count.
4573 (message_dolog): Don't assume print length fits in 39 bytes.
4574 (display_mode_element): Don't assume strlen fits in int.
4575
4576 * termcap.c: Don't assume sizes fit in int and never overflow.
4577 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4578 (gobble_line): Check for size-calculation overflow.
4579
4580 * minibuf.c (Fread_buffer):
4581 * lread.c (intern, intern_c_string):
4582 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4583 Don't assume string length fits in int.
4584
4585 * keyboard.c (parse_tool_bar_item):
4586 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4587
4588 * font.c: Don't assume string length fits in int.
4589 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4590 Use ptrdiff_t, not int.
4591 (font_intern_prop): Don't assume string length fits in int.
4592 Don't assume integer property fits in fixnum.
4593 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4594
4595 * filelock.c: Fix some buffer overrun and integer overflow issues.
4596 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4597 Reformulate so as not to need the command string.
4598 Invoke gzip -cd rather than gunzip, as it's more portable.
4599 (lock_info_type, lock_file_1, lock_file):
4600 Don't assume pid_t and time_t fit in unsigned long.
4601 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4602 (current_lock_owner): Prefer signed type for sizes.
4603 Use memcpy, not strncpy, where memcpy is what is really wanted.
4604 Don't assume (via atoi) that time_t and pid_t fit in int.
4605 Check for time_t and/or pid_t out of range, e.g., via a network share.
4606 Don't alloca where an auto var works fine.
4607
4608 * fileio.c: Fix some integer overflow issues.
4609 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4610 Don't assume string length fits in int.
4611 (directory_file_name): Don't assume string length fits in long.
4612 (make_temp_name): Don't assume pid fits in int, or that its print
4613 length is less than 20.
4614
4615 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4616
4617 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4618
4619 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4620
4621 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4622 We prefer signed integers, even for size calculations.
4623
4624 * emacs.c: Don't assume string length fits in 'int'.
4625 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4626 (main): Don't invoke strlen when not needed.
4627
4628 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4629 (XD_DEBUG_MESSAGE): Don't waste a byte.
4630
4631 * callproc.c (getenv_internal_1, getenv_internal)
4632 (Fgetenv_internal):
4633 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4634
4635 * lread.c (invalid_syntax): Omit length argument.
4636 All uses changed. This doesn't fix a bug, but it simplifies the
4637 code away from its former Hollerith-constant appearance, and it's
4638 one less 'int' to worry about when looking at integer-overflow issues.
4639 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4640
4641 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4642 This didn't break anything, but it didn't help either.
4643 It's confusing to put a bogus integer in a place where the actual
4644 value does not matter.
4645 (LIST_END_P): Remove unused macro and its bogus comment.
4646 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4647
4648 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4649 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4650 implementation.
4651 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4652 We prefer signed types, and the value cannot exceed the EMACS_INT
4653 range anyway (because otherwise the length would not be representable).
4654 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4655 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4656 This avoids a GCC warning when WIDE_EMACS_INT.
4657
4658 * indent.c (sane_tab_width): New function.
4659 (current_column, scan_for_column, Findent_to, position_indentation)
4660 (compute_motion): Use it. This is just for clarity.
4661 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4662
4663 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4664
4665 * lisp.h (lint_assume): New macro.
4666 * composite.c (composition_gstring_put_cache):
4667 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4668
4669 * editfns.c, insdel.c:
4670 Omit unnecessary forward decls, to simplify future changes.
4671
4672 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4673
4674 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4675
4676 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4677 Use much-faster test for byte-length change.
4678 Don't assume string byte-length fits in 'int'.
4679 Check that character arg fits in 'int'.
4680 (mapcar1): Declare byte as byte, for clarity.
4681
4682 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4683
4684 * fns.c (concat): Catch string overflow earlier.
4685 Do not rely on integer wraparound.
4686
4687 * dispextern.h (struct it.overlay_strings_charpos)
4688 (struct it.selective): Now EMACS_INT, not int.
4689 * xdisp.c (forward_to_next_line_start)
4690 (back_to_previous_visible_line_start)
4691 (reseat_at_next_visible_line_start, next_element_from_buffer):
4692 Don't arbitrarily truncate the value of 'selective' to int.
4693
4694 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4695
4696 * composite.c: Don't truncate sizes to 'int'.
4697 (composition_gstring_p, composition_reseat_it)
4698 (composition_adjust_point): Use EMACS_INT, not int.
4699 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4700 not EMACS_UINT, for indexes.
4701
4702 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4703
4704 * buffer.c: Include <verify.h>.
4705 (struct sortvec.priority, struct sortstr.priority):
4706 Now EMACS_INT, not int.
4707 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4708 (struct sortstr.size, record_overlay_string)
4709 (struct sortstrlist.size, struct sortlist.used):
4710 Don't truncate size to int.
4711 (record_overlay_string): Check for size-calculation overflow.
4712 (init_buffer_once): Check at compile-time, not run-time.
4713
4714 2011-06-22 Jim Meyering <meyering@redhat.com>
4715
4716 Don't leak an XBM-image-sized buffer
4717 * image.c (xbm_load): Free the image buffer after using it.
4718
4719 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4720
4721 Port to Sun C.
4722 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4723 that Sun C diagnosed.
4724 * fns.c (secure_hash): Fix pointer signedness issue.
4725 * intervals.c (static_offset_intervals): New function.
4726 (offset_intervals): Use it.
4727
4728 2011-06-21 Leo Liu <sdl.web@gmail.com>
4729
4730 * deps.mk (fns.o):
4731 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4732 sha512.h.
4733
4734 * fns.c (secure_hash): Rename from crypto_hash_function and change
4735 the first arg to accept symbols.
4736 (Fsecure_hash): New primitive.
4737 (syms_of_fns): New symbols.
4738
4739 2011-06-20 Deniz Dogan <deniz@dogan.se>
4740
4741 * process.c (Fset_process_buffer): Clarify return value in
4742 docstring.
4743
4744 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4745
4746 * dispnew.c (add_window_display_history): Use BVAR.
4747
4748 * xdisp.c (debug_method_add): Use BVAR.
4749 (check_window_end, dump_glyph_matrix, dump_glyph)
4750 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4751
4752 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4753 Likewise.
4754
4755 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4756 check till after the cache is created in init_frame_faces.
4757
4758 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4759
4760 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4761
4762 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4763
4764 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4765 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4766 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4767
4768 Improve buffer-overflow checking (Bug#8873).
4769 * fileio.c (Finsert_file_contents):
4770 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4771 Remove the old (too-loose) buffer overflow checks.
4772 They weren't needed, since make_gap checks for buffer overflow.
4773 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4774 The old code merely checked for Emacs fixnum overflow, and relied
4775 on undefined (wraparound) behavior. The new code avoids undefined
4776 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4777
4778 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4779 Tune. Don't use wider integers than needed. Don't use alloca.
4780 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4781
4782 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4783
4784 * insdel.c, lisp.h (buffer_overflow): New function.
4785 (insert_from_buffer_1, replace_range, replace_range_2):
4786 * insdel.c (make_gap_larger):
4787 * editfns.c (Finsert_char):
4788 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4789
4790 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4791
4792 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4793
4794 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4795
4796 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4797 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4798
4799 * fileio.c: Don't assume EMACS_INT fits in off_t.
4800 (emacs_lseek): New static function.
4801 (Finsert_file_contents, Fwrite_region): Use it.
4802 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4803
4804 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4805
4806 * fns.c: Don't overflow int when computing a list length.
4807 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4808 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4809 truncation on 64-bit hosts. Check for QUIT every
4810 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4811 faster and is responsive enough.
4812 (Flength): Report an error instead of overflowing an integer.
4813 (Fsafe_length): Return a float if the value is not representable
4814 as a fixnum. This shouldn't happen except in contrived situations.
4815 (Fnthcdr, Fsort): Don't assume list length fits in int.
4816 (Fcopy_sequence): Don't assume vector length fits in int.
4817
4818 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4819 (header_size, word_size): New constants.
4820 (allocate_vectorlike): Don't check size overflow here.
4821 (allocate_vector): Check it here instead, since this is the only
4822 caller of allocate_vectorlike that could cause overflow.
4823 Check that the new vector's length is representable as a fixnum.
4824
4825 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4826 The previous code was bogus. For example, next_almost_prime (32)
4827 returned 39, which is undesirable as it is a multiple of 3; and
4828 next_almost_prime (24) returned 25, which is a multiple of 5 so
4829 why was the code bothering to check for multiples of 7?
4830
4831 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4832
4833 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4834
4835 Variadic C functions now count arguments with ptrdiff_t.
4836 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4837 Back then I didn't know that the Emacs coding style prefers signed int.
4838 Also, in the meantime I found a few more instances where arguments
4839 were being counted with int, which may truncate counts on 64-bit
4840 machines, or EMACS_INT, which may be unnecessarily wide.
4841 * lisp.h (struct Lisp_Subr.function.aMANY)
4842 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4843 Arg counts are now ptrdiff_t, not size_t.
4844 All variadic functions and their callers changed accordingly.
4845 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4846 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4847 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4848 * callint.c (Fcall_interactively): Check arg count for overflow,
4849 to avoid potential buffer overrun. Use signed char, not 'int',
4850 for 'varies' array, so that we needn't bother to check its size
4851 calculation for overflow.
4852 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4853 * eval.c (apply_lambda):
4854 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4855 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4856 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4857
4858 * callint.c (Fcall_interactively): Don't use index var as event count.
4859
4860 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4861 * mem-limits.h (SIZE): Remove; no longer used.
4862
4863 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4864
4865 Remove unnecessary casts.
4866 * xterm.c (x_term_init):
4867 * xfns.c (x_set_border_pixel):
4868 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4869 These aren't needed now that we assume ANSI C.
4870
4871 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4872 It's more likely to cause problems (due to unsigned overflow)
4873 than to cure them.
4874
4875 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4876
4877 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4878
4879 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4880
4881 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4882
4883 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4884
4885 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4886
4887 GLYPH_CODE_FACE returns EMACS_INT, not int.
4888 * dispextern.h (merge_faces):
4889 * xfaces.c (merge_faces):
4890 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4891 Don't assume EMACS_INT fits in int.
4892
4893 * character.h (CHAR_VALID_P): Remove unused parameter.
4894 * fontset.c, lisp.h, xdisp.c: All uses changed.
4895
4896 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4897
4898 * fns.c (concat): Minor tuning based on overflow analysis.
4899 This doesn't fix any bugs. Use int to hold character, instead
4900 of constantly refetching from Emacs object. Use XFASTINT, not
4901 XINT, for value known to be a character. Don't bother comparing
4902 a single byte to 0400, as it's always less.
4903
4904 * floatfns.c (Fexpt):
4905 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4906
4907 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4908 for characters.
4909
4910 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4911
4912 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4913 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4914 incorrectly succeed when S was a string, because 4294967386 was
4915 truncated before it was used.
4916
4917 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4918 Otherwise, an out-of-range integer could cause undefined behavior
4919 on a 64-bit host.
4920
4921 * composite.c: Use int, not EMACS_INT, for characters.
4922 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4923 EMACS_INT, for values that are known to be in character range.
4924 This doesn't fix any bugs but is the usual style inside Emacs and
4925 may generate better code on 32-bit machines.
4926
4927 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4928 This is for reasons similar to the recent CHAR_STRING fix.
4929 * charset.c (Fencode_char): Check that character arg is actually
4930 a character. Pass an int to ENCODE_CHAR.
4931 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4932 wider than 'int', as a compile-time check to prevent future regressions
4933 in this area.
4934
4935 * character.c (char_string): Remove unnecessary casts.
4936
4937 Make sure a 64-bit char is never passed to CHAR_STRING.
4938 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4939 by silently ignoring the top 32 bits, allowing some values
4940 that were far too large to be valid characters.
4941 * character.h: Include <verify.h>.
4942 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4943 arguments are no wider than unsigned, as a compile-time check
4944 to prevent future regressions in this area.
4945 * data.c (Faset):
4946 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4947 (Fsubst_char_in_region):
4948 * fns.c (concat):
4949 * xdisp.c (decode_mode_spec_coding):
4950 Adjust to CHAR_STRING's new requirement.
4951 * editfns.c (Finsert_char, Fsubst_char_in_region):
4952 * fns.c (concat): Check that character args are actually
4953 characters. Without this test, these functions did the wrong
4954 thing with wildly out-of-range values on 64-bit hosts.
4955
4956 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4957 These casts should not be needed on 32-bit hosts, either.
4958 * keyboard.c (read_char):
4959 * lread.c (Fload): Remove casts to unsigned.
4960
4961 * lisp.h (UNSIGNED_CMP): New macro.
4962 This fixes comparison bugs on 64-bit hosts.
4963 (ASCII_CHAR_P): Use it.
4964 * casefiddle.c (casify_object):
4965 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4966 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4967 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4968 * dispextern.h (FACE_FROM_ID):
4969 * keyboard.c (read_char): Use UNSIGNED_CMP.
4970
4971 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4972 not to EMACS_INT, to avoid GCC warning.
4973
4974 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4975
4976 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4977 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4978 isn't needed on 32-bit machines.
4979
4980 * buffer.c (Fgenerate_new_buffer_name):
4981 Use EMACS_INT for count, not int.
4982 (advance_to_char_boundary): Return EMACS_INT, not int.
4983
4984 * data.c (Qcompiled_function): Now static.
4985
4986 * window.c (window_body_lines): Now static.
4987
4988 * image.c (gif_load): Rename local to avoid shadowing.
4989
4990 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4991 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4992 * alloc.c (make_save_value): Integer argument is now of type
4993 ptrdiff_t, not int.
4994 (mark_object): Use ptrdiff_t, not int.
4995 * lisp.h (pD): New macro.
4996 * print.c (print_object): Use it.
4997
4998 * alloc.c: Use EMACS_INT, not int, to count objects.
4999 (total_conses, total_markers, total_symbols, total_vector_size)
5000 (total_free_conses, total_free_markers, total_free_symbols)
5001 (total_free_floats, total_floats, total_free_intervals)
5002 (total_intervals, total_strings, total_free_strings):
5003 Now EMACS_INT, not int. All uses changed.
5004 (Fgarbage_collect): Compute overall total using a double, so that
5005 integer overflow is less likely to be a problem. Check for overflow
5006 when converting back to an integer.
5007 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5008 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5009 These were 'int' variables that could overflow on 64-bit hosts;
5010 they were never used, so remove them instead of repairing them.
5011 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5012 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5013 Previously, this ceilinged at INT_MAX, but that doesn't work on
5014 64-bit machines.
5015 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5016
5017 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5018 (allocate_vectorlike): Check for ptrdiff_t overflow.
5019 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5020 when a (possibly-narrower) signed value would do just as well.
5021 We prefer using signed arithmetic, to avoid comparison confusion.
5022
5023 * alloc.c: Catch some string size overflows that we were missing.
5024 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5025 for convenience in STRING_BYTES_MAX.
5026 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5027 The definition here is exact; the one in lisp.h was approximate.
5028 (allocate_string_data): Check for string overflow. This catches
5029 some instances we weren't catching before. Also, it catches
5030 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5031 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5032 and ptrdiff_t and EMACS_INT are both 64 bits.
5033
5034 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5035 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5036 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5037
5038 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5039
5040 * alloc.c (Fmake_string): Check for out-of-range init.
5041
5042 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5043
5044 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5045
5046 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5047
5048 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5049 xg_get_default_scrollbar_width.
5050
5051 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5052 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5053 (style_changed_cb): Call update_theme_scrollbar_width and call
5054 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5055 all frames (Bug#8505).
5056 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5057 Call gtk_window_set_resizable if HAVE_GTK3.
5058 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5059 and height if HAVE_GTK3 (Bug#8505).
5060 (scroll_bar_width_for_theme): New variable.
5061 (update_theme_scrollbar_width): New function.
5062 (xg_get_default_scrollbar_width): Move code to
5063 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5064 (xg_initialize): Call update_theme_scrollbar_width.
5065
5066 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5067
5068 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5069
5070 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5071
5072 * frame.c (make_frame): Call other_buffer_safely instead of
5073 other_buffer.
5074
5075 * window.c (temp_output_buffer_show): Call display_buffer with
5076 second argument Vtemp_buffer_show_specifiers and reset latter
5077 immediately after the call.
5078 (Vtemp_buffer_show_specifiers): New variable.
5079 (auto_window_vscroll_p, next_screen_context_lines)
5080 (Vscroll_preserve_screen_position): Remove leading asterisks from
5081 doc-strings.
5082
5083 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5084
5085 Fix minor problems found by GCC 4.6.0 static checking.
5086 * buffer.c (Qclone_number): Remove for now, as it's unused.
5087 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5088 (record_buffer): Remove unused local.
5089 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5090 (set_frame_buffer_list): Remove; unused.
5091 * frame.h (other_visible_frames): Remove decl.
5092 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5093 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5094 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5095 if HAVE_GPM.
5096 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5097 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5098 Define only if HAVE_GPM.
5099 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5100 (update_hints_inhibit): Remove; never set. All uses removed.
5101 * widgetprv.h (emacsFrameClassRec): Remove decl.
5102 * window.c (delete_deletable_window): Now returns void, since it
5103 wasn't returning anything.
5104 (compare_window_configurations): Remove unused locals.
5105 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5106 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5107 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5108 the same widths as pointers. This follows up on the 2011-05-06 patch.
5109 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5110 * xterm.h: Likewise.
5111 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5112
5113 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5114
5115 * makefile.w32-in: Update dependencies.
5116 (LISP_H): Add lib/intprops.h.
5117
5118 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5119
5120 * image.c (gif_load): Add animation frame delay to the metadata.
5121 (syms_of_image): Use DEFSYM. New symbol `delay'.
5122
5123 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5124
5125 * window.c (delete_deletable_window): Re-add.
5126 (Fset_window_configuration): Rewrite to handle dead buffers and
5127 consequently deletable windows.
5128 (window_tree, Fwindow_tree): Remove. Supply functionality in
5129 window.el.
5130 (compare_window_configurations): Simplify code.
5131
5132 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5133
5134 * image.c (imagemagick_load_image): Fix type mismatch.
5135 (Fimagemagick_types): Likewise.
5136
5137 * window.h (replace_buffer_in_windows): Declare.
5138
5139 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5140
5141 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5142 Qclone_number. Remove external declaration of Qdelete_window.
5143 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5144 code.
5145 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5146 Run Qbuffer_list_update_hook if allowed.
5147 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5148 buffer list implementation.
5149 (other_buffer_safely): New function.
5150 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5151 calls to replace_buffer_in_windows and
5152 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5153 if allowed.
5154 (record_buffer): Inhibit quitting and rewrite using quittable
5155 functions. Run Qbuffer_list_update_hook if allowed.
5156 (Frecord_buffer, Funrecord_buffer): New functions.
5157 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5158 Move switch-to-buffer to window.el.
5159 (bury-buffer): Move to window.el.
5160 (Vbuffer_list_update_hook): New variable.
5161
5162 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5163 section.
5164
5165 * window.h (resize_frame_windows): Move up in code.
5166 (Fwindow_frame): Remove EXFUN.
5167 (replace_buffer_in_all_windows): Remove prototype.
5168 (replace_buffer_in_windows_safely): Add prototype.
5169
5170 * window.c: Declare Qdelete_window static again. Move down
5171 declaration of select_count.
5172 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5173 (Fother_window): Move to window.el.
5174 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5175 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5176 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5177 window.el.
5178 (replace_buffer_in_windows): Implement by calling
5179 Qreplace_buffer_in_windows.
5180 (replace_buffer_in_all_windows): Remove with some functionality
5181 moved into replace_buffer_in_windows_safely.
5182 (replace_buffer_in_windows_safely): New function.
5183 (select_window_norecord, select_frame_norecord): Move in front
5184 of run_window_configuration_change_hook. Remove now obsolete
5185 declarations.
5186 (Fset_window_buffer): Rewrite doc-string.
5187 Call Qrecord_window_buffer.
5188 (keys_of_window): Move binding for other-window to window.el.
5189
5190 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5191
5192 * dispextern.h (struct image): Replace data member, whose int_val
5193 and ptr_val fields were not used by anything, with a single
5194 lisp_val object.
5195
5196 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5197 (gif_clear_image, gif_load, imagemagick_load_image)
5198 (gs_clear_image, gs_load): Callers changed.
5199
5200 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5201
5202 * buffer.h: Include <time.h>, for time_t.
5203 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5204
5205 Fix minor problems found by static checking.
5206
5207 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5208
5209 Make identifiers static if they are not used in other modules.
5210 * data.c (Qcompiled_function, Qframe, Qvector):
5211 * image.c (QimageMagick, Qsvg):
5212 * minibuf.c (Qmetadata):
5213 * window.c (resize_window_check, resize_root_window): Now static.
5214 * window.h (resize_window_check, resize_root_window): Remove decls.
5215
5216 * window.c (window_deletion_count, delete_deletable_window):
5217 Remove; unused.
5218 (window_body_lines): Now static.
5219 (Fdelete_other_windows_internal): Mark vars as initialized.
5220 Make sure 'resize_failed' is initialized.
5221 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5222 (resize_window_apply): Remove unused local.
5223 * window.h (delete_deletable_window): Remove decl.
5224
5225 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5226 (imagemagick_load_image): Fix pointer signedness problem by changing
5227 last arg from unsigned char * to char *. All uses changed.
5228 Also, fix a local for similar reasons.
5229 Remove unused locals. Remove locals to avoid shadowing.
5230 (fn_rsvg_handle_free): Remove; unused.
5231 (svg_load, svg_load_image): Fix pointer signedness problem.
5232 (imagemagick_load_image): Don't use garbage pointer image_wand.
5233
5234 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5235
5236 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5237
5238 * image.c (gif_load): Fix omitted cast error introduced by
5239 2011-06-06 change.
5240
5241 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5242
5243 * window.h (resize_proportionally, orig_total_lines)
5244 (orig_top_line): Remove from window structure.
5245 (set_window_height, set_window_width, change_window_heights)
5246 (Fdelete_window): Remove prototypes.
5247 (resize_frame_windows): Remove duplicate declaration.
5248
5249 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5250
5251 * window.h (resize_frame_windows, resize_window_check)
5252 (delete_deletable_window, resize_root_window)
5253 (resize_frame_windows): Declare prototypes.
5254
5255 * window.c (resize_window_apply): Make definition be "static" to
5256 match the prototype.
5257
5258 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5259
5260 * window.c: Remove declarations of Qwindow_size_fixed,
5261 window_min_size_1, window_min_size_2, window_min_size,
5262 size_window, window_fixed_size_p, enlarge_window, delete_window.
5263 Remove static from declaration of Qdelete_window, it's
5264 temporarily needed by Fbury_buffer.
5265 (replace_window): Don't assign orig_top_line and
5266 orig_total_lines.
5267 (Fdelete_window, delete_window): Remove. Window deletion is
5268 handled by window.el.
5269 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5270 Replace Fdelete_window calls with calls to Qdelete_window.
5271 (Fdelete_other_windows): Remove. Deleting other windows is
5272 handled by window.el.
5273 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5274 handled in window.el.
5275 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5276 Window minimum sizes are handled in window.el.
5277 (shrink_windows, size_window, set_window_height)
5278 (set_window_width, change_window_heights, window_height)
5279 (window_width, CURBEG, CURSIZE, enlarge_window)
5280 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5281 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5282 handled in window.el.
5283 (make_dummy_parent): Rename to make_parent_window and give it a
5284 second argument horflag.
5285 (make_window): Don't set resize_proportionally any more.
5286 (Fsplit_window): Remove. Windows are split in window.el.
5287 (save_restore_action, save_restore_orig_size)
5288 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5289 Resize mini windows in window.el.
5290 (grow_mini_window, shrink_mini_window): Implement by calling
5291 Qresize_root_window_vertically, resize_window_check and
5292 resize_window_apply.
5293 (saved_window, Fset_window_configuration, save_window_save):
5294 Do not handle orig_top_line, orig_total_lines, and
5295 resize_proportionally.
5296 (window_min_height, window_min_width): Move to window.el.
5297 (keys_of_window): Move bindings for delete-other-windows,
5298 split-window, delete-window and enlarge-window to window.el.
5299
5300 * buffer.c: Temporarily extern Qdelete_window.
5301 (Fbury_buffer): Temporarily call Qdelete_window instead of
5302 Fdelete_window (Fbury_buffer will move to window.el soon).
5303
5304 * frame.c (set_menu_bar_lines_1): Remove code handling
5305 orig_top_line and orig_total_lines.
5306
5307 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5308 set_window_height but set heights directly.
5309 (change_frame_size_1): Use resize_frame_windows.
5310
5311 * xdisp.c (init_xdisp): Don't use set_window_height but set
5312 heights directly.
5313
5314 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5315 Use resize_frame_windows instead of change_window_heights and run
5316 run_window_configuration_change_hook.
5317
5318 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5319 instead of change_window_heights and run
5320 run_window_configuration_change_hook.
5321
5322 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5323
5324 * window.c (replace_window): Rename second argument REPLACEMENT to
5325 NEW. New third argument SETFLAG. Rewrite.
5326 (delete_window, make_dummy_parent): Call replace_window with
5327 third argument 1.
5328 (window_list_1): Move down in code.
5329 (run_window_configuration_change_hook): Move set_buffer part
5330 before select_frame_norecord part in order to unwind correctly.
5331 Rename count1 to count.
5332 (recombine_windows, delete_deletable_window, resize_root_window)
5333 (Fdelete_other_windows_internal)
5334 (Frun_window_configuration_change_hook, make_parent_window)
5335 (resize_window_check, resize_window_apply, Fresize_window_apply)
5336 (resize_frame_windows, Fsplit_window_internal)
5337 (Fdelete_window_internal, Fresize_mini_window_internal):
5338 New functions.
5339 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5340
5341 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5342
5343 * window.h (window): Add some new members to window structure -
5344 normal_lines, normal_cols, new_total, new_normal, clone_number,
5345 splits, nest, prev_buffers, next_buffers.
5346 (WINDOW_TOTAL_SIZE): Move here from window.c.
5347 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5348
5349 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5350 Remove.
5351 (make_dummy_parent): Set new members of windows structure.
5352 (make_window): Move down in code. Handle new members of window
5353 structure.
5354 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5355 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5356 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5357 (Fset_window_prev_buffers, Fwindow_next_buffers)
5358 (Fset_window_next_buffers, Fset_window_clone_number):
5359 New functions.
5360 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5361 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5362 Doc-string fixes.
5363 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5364 Argument WINDOW can be now internal window too.
5365 (Fwindow_use_time): Move up in code.
5366 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5367 Rewrite doc-string.
5368 (Fset_window_configuration, saved_window)
5369 (Fcurrent_window_configuration, save_window_save): Handle new
5370 members of window structure.
5371 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5372 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5373 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5374 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5375 Qget_mru_window, Qresize_root_window,
5376 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5377 Qauto_buffer_name; staticpro them.
5378
5379 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5380
5381 * window.c (Fwindow_total_size, Fwindow_left_column)
5382 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5383 (Fwindow_list_1): New functions.
5384 (window_box_text_cols): Replace with window_body_cols.
5385 (Fwindow_width, Fscroll_left, Fscroll_right):
5386 Use window_body_cols instead of window_box_text_cols.
5387 (delete_window, Fset_window_configuration):
5388 Call delete_all_subwindows with window as argument.
5389 (delete_all_subwindows): Take a window as argument and not a
5390 structure. Rewrite.
5391 (window_loop): Remove handling of GET_LRU_WINDOW and
5392 GET_LARGEST_WINDOW.
5393 (Fget_lru_window, Fget_largest_window): Move to window.el.
5394
5395 * window.h: Extern window_body_cols instead of
5396 window_box_text_cols. delete_all_subwindows now takes a
5397 Lisp_Object as argument.
5398
5399 * indent.c (compute_motion, Fcompute_motion):
5400 Use window_body_cols instead of window_box_text_cols.
5401
5402 * frame.c (delete_frame): Call delete_all_subwindows with root
5403 window as argument.
5404
5405 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5406
5407 * fns.c (Fputhash): Document return value.
5408
5409 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5410
5411 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5412
5413 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5414
5415 Cons<->int and similar integer overflow fixes (Bug#8794).
5416
5417 Check for overflow when converting integer to cons and back.
5418 * charset.c (Fdefine_charset_internal, Fdecode_char):
5419 Use cons_to_unsigned to catch overflow.
5420 (Fencode_char): Use INTEGER_TO_CONS.
5421 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5422 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5423 * data.c (long_to_cons, cons_to_long): Remove.
5424 (cons_to_unsigned, cons_to_signed): New functions.
5425 These signal an error for invalid or out-of-range values.
5426 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5427 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5428 * font.c (Ffont_variation_glyphs):
5429 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5430 * lisp.h: Include <intprops.h>.
5431 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5432 (cons_to_signed, cons_to_unsigned): New decls.
5433 (long_to_cons, cons_to_long): Remove decls.
5434 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5435 (Fprimitive_undo): Use CONS_TO_INTEGER.
5436 * xfns.c (Fx_window_property): Likewise.
5437 * xselect.c: Include <limits.h>.
5438 (x_own_selection, selection_data_to_lisp_data):
5439 Use INTEGER_TO_CONS.
5440 (x_handle_selection_request, x_handle_selection_clear)
5441 (x_get_foreign_selection, Fx_disown_selection_internal)
5442 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5443 (lisp_data_to_selection_data): Use cons_to_unsigned.
5444 (x_fill_property_data): Use cons_to_signed.
5445 Report values out of range.
5446
5447 Check for buffer and string overflow more precisely.
5448 * buffer.h (BUF_BYTES_MAX): New macro.
5449 * lisp.h (STRING_BYTES_MAX): New macro.
5450 * alloc.c (Fmake_string):
5451 * character.c (string_escape_byte8):
5452 * coding.c (coding_alloc_by_realloc):
5453 * doprnt.c (doprnt):
5454 * editfns.c (Fformat):
5455 * eval.c (verror):
5456 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5457 since they may not be the same number.
5458 * editfns.c (Finsert_char):
5459 * fileio.c (Finsert_file_contents):
5460 Likewise for BUF_BYTES_MAX.
5461
5462 * image.c: Use ptrdiff_t, not int, for sizes.
5463 (slurp_file): Switch from int to ptrdiff_t.
5464 All uses changed.
5465 (slurp_file): Check that file size fits in both size_t (for
5466 malloc) and ptrdiff_t (for sanity and safety).
5467
5468 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5469 if b->modtime has its maximal value.
5470
5471 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5472
5473 Don't assume time_t can fit into int.
5474 * buffer.h (struct buffer.modtime): Now time_t, not int.
5475 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5476 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5477
5478 Minor fixes for signed vs unsigned integers.
5479 * character.h (MAYBE_UNIFY_CHAR):
5480 * charset.c (maybe_unify_char):
5481 * keyboard.c (read_char, reorder_modifiers):
5482 XINT -> XFASTINT, since the integer must be nonnegative.
5483 * ftfont.c (ftfont_spec_pattern):
5484 * keymap.c (access_keymap, silly_event_symbol_error):
5485 XUINT -> XFASTINT, since the integer must be nonnegative.
5486 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5487 since it makes no difference and we prefer signed.
5488 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5489 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5490 nonnegative.
5491
5492 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5493
5494 * window.h (Fwindow_frame): Declare.
5495
5496 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5497
5498 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5499 (SPARE_MEMORY): Always define.
5500 (LARGE_REQUEST): Remove.
5501 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5502
5503 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5504
5505 * lisp.h: Move EXFUNS for Fframe_root_window,
5506 Fframe_first_window and Fset_frame_selected_window to window.h.
5507
5508 * window.h: Move EXFUNS for Fframe_root_window,
5509 Fframe_first_window and Fset_frame_selected_window here from
5510 lisp.h.
5511
5512 * frame.c (Fwindow_frame, Fframe_first_window)
5513 (Fframe_root_window, Fframe_selected_window)
5514 (Fset_frame_selected_window): Move to window.c.
5515 (Factive_minibuffer_window): Move to minibuf.c.
5516 (Fother_visible_frames_p): New function.
5517
5518 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5519
5520 * window.c (decode_window, decode_any_window): Move up in code.
5521 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5522 (inhibit_frame_unsplittable): Remove unused variable.
5523 (Fwindow_buffer): Move up and rewrite doc-string.
5524 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5525 (Fwindow_prev): New functions.
5526 (Fwindow_frame): Move here from frame.c. Accept any window as
5527 argument.
5528 (Fframe_root_window, Fframe_first_window)
5529 (Fframe_selected_window): Move here from frame.c. Accept frame
5530 or arbitrary window as argument. Update doc-strings.
5531 (Fminibuffer_window): Move up in code.
5532 (Fwindow_minibuffer_p): Move up in code and simplify.
5533 (Fset_frame_selected_window): Move here from frame.c.
5534 Marginal rewrite.
5535 (Fselected_window, select_window, Fselect_window): Move up in
5536 code. Minor doc-string fixes.
5537
5538 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5539
5540 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5541 Do not assume that spare memory exists; that assumption is valid
5542 only if SYSTEM_MALLOC.
5543 (LARGE_REQUEST): New macro, so that the issue of large requests
5544 is separated from the issue of spare memory.
5545
5546 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5547
5548 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5549 format. (Bug#8806)
5550
5551 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5552
5553 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5554 before statements.
5555
5556 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5557
5558 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5559
5560 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5561
5562 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5563 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5564
5565 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5566
5567 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5568
5569 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5570
5571 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5572 (x_clipboard_manager_save): Add return value.
5573 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5574 New error handlers.
5575 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5576 Obey Vx_select_enable_clipboard_manager. Catch errors in
5577 x_clipboard_manager_save (Bug#8779).
5578 (Vx_select_enable_clipboard_manager): New variable.
5579 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5580
5581 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5582
5583 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5584
5585 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5586
5587 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5588 in the current matrix if keep_current_p is non-zero.
5589
5590 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5591
5592 * bidi.c (bidi_level_of_next_char): Fix last change.
5593
5594 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5595
5596 Support bidi reordering of text covered by display properties.
5597
5598 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5599 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5600 (bidi_cache_search, bidi_cache_iterator_state)
5601 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5602 (bidi_level_of_next_char, bidi_move_to_visually_next):
5603 Support character positions inside a run of characters covered by a
5604 display string.
5605 (bidi_paragraph_init, bidi_resolve_explicit_1)
5606 (bidi_level_of_next_char): Call bidi_fetch_char and
5607 bidi_fetch_char_advance instead of FETCH_CHAR and
5608 FETCH_CHAR_ADVANCE.
5609 (bidi_init_it): Initialize new members.
5610 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5611 definitions.
5612 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5613 instead of using explicit *_CHAR codes.
5614 (bidi_resolve_explicit, bidi_resolve_weak):
5615 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5616 bidirectional text is supported only in multibyte buffers.
5617 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5618 it to initialize the frame_window_p member of struct bidi_it.
5619 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5620 (bidi_resolve_explicit, bidi_resolve_weak)
5621 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5622 bidi_it->nchars is non-positive.
5623 (bidi_level_of_next_char): Don't try to lookup the cache for the
5624 next/previous character if nothing is cached there yet, or if we
5625 were just reseat()'ed to a new position.
5626
5627 * xdisp.c (set_cursor_from_row): Set start and stop points
5628 according to the row's direction when priming the loop that looks
5629 for the glyph on which to display cursor.
5630 (single_display_spec_intangible_p): Function deleted.
5631 (display_prop_intangible_p): Reimplement to call
5632 handle_display_spec instead of single_display_spec_intangible_p.
5633 Accept 3 additional arguments needed by handle_display_spec.
5634 This fixes incorrect cursor motion across display property with complex
5635 values: lists, `(when COND...)' forms, etc.
5636 (single_display_spec_string_p): Support property values that are
5637 lists with the argument STRING its top-level element.
5638 (display_prop_string_p): Fix the condition for processing a
5639 property that is a list to be consistent with handle_display_spec.
5640 (handle_display_spec): New function, refactored from the
5641 last portion of handle_display_prop.
5642 (compute_display_string_pos): Accept additional argument
5643 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5644 value of a `display' property is a "replacing spec".
5645 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5646 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5647 the display property, but just return a value indicating whether
5648 the display property will replace the characters it covers.
5649 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5650 frame_window_p members of struct bidi_it.
5651 (compute_display_string_pos, compute_display_string_end):
5652 New functions.
5653 (push_it): Accept second argument POSITION, where pop_it should
5654 jump to continue iteration.
5655 (reseat_1): Initialize bidi_it.disp_pos.
5656
5657 * keyboard.c (adjust_point_for_property): Adjust the call to
5658 display_prop_intangible_p to its new signature.
5659
5660 * dispextern.h (struct bidi_it): New member frame_window_p.
5661 (bidi_init_it): Update prototypes.
5662 (display_prop_intangible_p): Update prototype.
5663 (compute_display_string_pos, compute_display_string_end):
5664 Declare prototypes.
5665 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5666 EMACS_INT.
5667
5668 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5669
5670 Malloc failure behavior now depends on size of allocation.
5671 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5672 * lisp.h: Change signatures accordingly.
5673 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5674 All callers changed. (Bug#8762)
5675
5676 * gnutls.c: Use Emacs's memory allocators.
5677 Without this change, the gnutls library would invoke malloc etc.
5678 directly, which causes problems on non-SYNC_INPUT hosts, and which
5679 runs afoul of improving memory_full behavior. (Bug#8761)
5680 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5681 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5682 xfree instead of the default malloc, realloc, free.
5683 (Fgnutls_boot): No need to check for memory allocation failure,
5684 since xmalloc does that for us.
5685
5686 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5687 * category.c (hash_get_category_set):
5688 * ccl.c (ccl_driver):
5689 * charset.c (Fdefine_charset_internal):
5690 * charset.h (struct charset.hash_index):
5691 * composite.c (get_composition_id, gstring_lookup_cache)
5692 (composition_gstring_put_cache):
5693 * composite.h (struct composition.hash_index):
5694 * dispextern.h (struct image.hash):
5695 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5696 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5697 (hashfn_equal, hashfn_user_defined, make_hash_table)
5698 (maybe_resize_hash_table, hash_lookup, hash_put)
5699 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5700 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5701 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5702 * image.c (make_image, search_image_cache, lookup_image)
5703 (xpm_put_color_table_h):
5704 * lisp.h (struct Lisp_Hash_Table):
5705 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5706 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5707 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5708 * alloc.c (allocate_vectorlike):
5709 Check for overflow in vector size calculations.
5710 * ccl.c (ccl_driver):
5711 Check for overflow when converting EMACS_INT to int.
5712 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5713 need to be updated by these changes.
5714 * fns.c (make_hash_table, maybe_resize_hash_table):
5715 Check for integer overflow with large hash tables.
5716 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5717 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5718 (SXHASH_REDUCE): New macro.
5719 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5720 Use it instead of discarding useful hash info with large hash values.
5721 (sxhash_float): New function.
5722 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5723 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5724 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5725 Rewrite to use FIXNUM_BITS, as this simplifies things.
5726 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5727 Adjust signatures to match updated version of code.
5728 (consing_since_gc): Now EMACS_INT, since a single hash table can
5729 use more than INT_MAX bytes.
5730
5731 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5732
5733 Make it possible to build with GCC-4.6+ -O2 -flto.
5734
5735 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5736
5737 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5738
5739 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5740 Call minibuffer-inactive-mode.
5741
5742 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5743
5744 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5745 Update dependencies.
5746
5747 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5748
5749 * data.c (init_data): Remove code for UTS, this system is not
5750 supported anymore.
5751
5752 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5753
5754 Don't force ./temacs to start in terminal mode.
5755
5756 * frame.c (make_initial_frame): Initialize faces in all cases, not
5757 only when CANNOT_DUMP is defined.
5758 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5759
5760 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5761
5762 * dispnew.c (add_window_display_history): Use const for the string
5763 pointer. Remove declaration, not needed.
5764
5765 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5766
5767 Use 'inline', not 'INLINE'.
5768 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5769 * alloc.c, fontset.c (INLINE): Remove.
5770 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5771 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5772 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5773 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5774 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5775
5776 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5777
5778 Make it possible to run ./temacs.
5779
5780 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5781 syms_of_callproc does the same thing. Remove test for
5782 "initialized", do it in the caller.
5783 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5784
5785 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5786
5787 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5788 (read_minibuf): Use get_minibuffer.
5789 (syms_of_minibuf): Use DEFSYM.
5790 (Qmetadata): New var.
5791 * data.c (Qbuffer): Don't make it static.
5792 (syms_of_data): Use DEFSYM.
5793
5794 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5795
5796 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5797 (CCL_CODE_MIN): New macro.
5798
5799 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5800
5801 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5802
5803 * eval.c (Qdebug): Now static.
5804 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5805 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5806 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5807
5808 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5809
5810 * image.c: Various fixes to ImageMagick code comments.
5811 (Fimagemagick_types): Doc fix.
5812
5813 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5814
5815 Minor fixes prompted by GCC 4.6.0 warnings.
5816
5817 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5818
5819 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5820 (x_clipboard_manager_save_all): Move extern decl to ...
5821 * xterm.h: ... here, so that it can be checked for consistency.
5822
5823 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5824
5825 * xselect.c (x_clipboard_manager_save_frame)
5826 (x_clipboard_manager_save_all): New functions.
5827 (Fx_clipboard_manager_save): Lisp function deleted.
5828
5829 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5830 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5831
5832 * xterm.h: Update prototype.
5833
5834 2011-05-28 William Xu <william.xwl@gmail.com>
5835
5836 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5837 exiting (Bug#8239).
5838
5839 2011-05-28 Jim Meyering <meyering@redhat.com>
5840
5841 Avoid a sign-extension bug in crypto_hash_function.
5842 * fns.c (to_uchar): Define.
5843 (crypto_hash_function): Use it to convert some newly-signed
5844 variables to unsigned, to avoid sign-extension bugs. For example,
5845 without this change, (md5 "truc") would evaluate to
5846 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5847 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5848 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5849
5850 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5851
5852 Integer overflow fixes.
5853
5854 * dbusbind.c: Serial number integer overflow fixes.
5855 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5856 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5857 to hold a serial number that is too large for a fixnum.
5858 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5859 Check for serial numbers out of range. Decode any serial number
5860 that was so large that it became a float. (Bug#8722)
5861
5862 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5863 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5864 Use XFASTINT rather than XUINT when numbers are nonnegative.
5865 (xd_append_arg, Fdbus_method_return_internal):
5866 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5867 arguments, check that Lisp number is nonnegative, rather than
5868 silently wrapping negative numbers around. (Bug#8722)
5869 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5870 (Bug#8722)
5871
5872 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5873
5874 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5875
5876 ccl: Add integer overflow checks.
5877 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5878 (IN_INT_RANGE): New macros.
5879 (ccl_driver): Use them to check for integer overflow when
5880 decoding a CCL program. Many of the new checks are whether XINT (x)
5881 fits in int; it doesn't always, on 64-bit hosts. The new version
5882 doesn't catch all possible integer overflows, but it's an
5883 improvement. (Bug#8719)
5884
5885 * alloc.c (make_event_array): Use XINT, not XUINT.
5886 There's no need for unsigned here.
5887
5888 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5889 This follows up to the 2011-05-06 change that substituted uintptr_t
5890 for EMACS_INT. This case wasn't caught back then.
5891
5892 Rework Fformat to avoid integer overflow issues.
5893 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5894 now (part of C89). Include <verify.h>.
5895 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5896 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5897 (Fformat): Avoid the prepass trying to compute sizes; it was only
5898 approximate and thus did not catch overflow reliably. Instead, walk
5899 through the format just once, formatting and computing sizes as we go,
5900 checking for integer overflow at every step, and allocating a larger
5901 buffer as needed. Keep track separately whether the format is
5902 multibyte. Keep only the most-recently calculated precision, rather
5903 than them all. Record whether each argument has been converted to
5904 string. Use EMACS_INT, not int, for byte and char and arg counts.
5905 Support field widths and precisions larger than INT_MAX. Avoid
5906 sprintf's undefined behavior with conversion specifications such as %#d
5907 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5908 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5909 formatting out-of-range floating point numbers with int
5910 formats. (Bug#8668)
5911
5912 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5913
5914 * data.c: Avoid integer truncation in expressions involving floats.
5915 * data.c: Include <intprops.h>.
5916 (arith_driver): When there's an integer overflow in an expression
5917 involving floating point, convert the integers to floating point
5918 so that the resulting value does not suffer from catastrophic
5919 integer truncation. For example, on a 64-bit host (* 4
5920 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5921 Do not rely on undefined behavior after integer overflow.
5922
5923 merge count_size_as_multibyte, parse_str_to_multibyte
5924 * character.c, character.h (count_size_as_multibyte):
5925 Rename from parse_str_to_multibyte; all uses changed.
5926 Check for integer overflow.
5927 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5928 since it's now a duplicate of the other. This is more of
5929 a character than a buffer op, so better that it's in character.c.
5930 * fns.c, print.c: Adjust to above changes.
5931
5932 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5933
5934 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5935
5936 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5937
5938 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5939 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5940 (x_clipboard_manager_save): Now static.
5941 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5942
5943 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5944 (crypto_hash_function): Now static.
5945 Fix pointer signedness problems. Avoid unnecessary initializations.
5946
5947 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5948
5949 * termhooks.h (Vselection_alist): Make it terminal-local.
5950
5951 * terminal.c (create_terminal): Initialize it.
5952
5953 * xselect.c: Support for clipboard managers.
5954 (Vselection_alist): Move to termhooks.h as terminal-local var.
5955 (LOCAL_SELECTION): New macro.
5956 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5957 (symbol_to_x_atom): Remove gratuitous arg.
5958 (x_handle_selection_request, lisp_data_to_selection_data)
5959 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5960 (x_own_selection, x_get_local_selection, x_convert_selection):
5961 New arg, specifying work frame. Use terminal-local Vselection_alist.
5962 (some_frame_on_display): Delete unused function.
5963 (Fx_own_selection_internal, Fx_get_selection_internal)
5964 (Fx_disown_selection_internal, Fx_selection_owner_p)
5965 (Fx_selection_exists_p): New optional frame arg.
5966 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5967 (x_handle_selection_clear): Don't treat other terminals with the
5968 same keyboard specially. Use the terminal-local Vselection_alist.
5969 (x_clear_frame_selections): Use Frun_hook_with_args.
5970
5971 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5972
5973 * xterm.h: Add support for those atoms.
5974
5975 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5976
5977 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5978 (converted_selections, conversion_fail_tag): New global variables.
5979 (x_selection_request_lisp_error): Free the above.
5980 (x_get_local_selection): Remove unnecessary code.
5981 (x_reply_selection_request): Args changed; handle arbitrary array
5982 of converted selections stored in converted_selections.
5983 Separate the XChangeProperty and SelectionNotify steps.
5984 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5985 (x_convert_selection): New function.
5986 (x_handle_selection_event): Simplify.
5987 (x_get_foreign_selection): Don't ignore incoming requests while
5988 waiting for an answer; this will fail when we implement
5989 SAVE_TARGETS, and seems unnecessary anyway.
5990 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5991 (Vx_sent_selection_functions): Doc fix.
5992
5993 2011-05-26 Leo Liu <sdl.web@gmail.com>
5994
5995 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5996
5997 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5998
5999 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6000
6001 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6002 for fringe update if it has periodic bitmap.
6003 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6004 and fringe_bitmap_periodic_p.
6005
6006 * fringe.c (get_fringe_bitmap_data): New function.
6007 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6008 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6009 row. Mark glyph row for fringe update if periodicity changed.
6010
6011 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6012 for fringe update unless it has periodic bitmap.
6013
6014 2011-05-25 Kenichi Handa <handa@m17n.org>
6015
6016 * xdisp.c (get_next_display_element): Set correct it->face_id for
6017 a static composition.
6018
6019 2011-05-24 Leo Liu <sdl.web@gmail.com>
6020
6021 * deps.mk (fns.o):
6022 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6023
6024 * fns.c (crypto_hash_function, Fsha1): New function.
6025 (Fmd5): Use crypto_hash_function.
6026 (syms_of_fns): Add Ssha1.
6027
6028 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6029
6030 * gnutls.c: Remove unused macros.
6031 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6032 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6033 Remove macros that are defined and never used.
6034 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6035
6036 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6037
6038 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6039 (Fx_get_selection_internal): Minor cleanup.
6040 (Fx_own_selection_internal): Rename arguments for consistency with
6041 select.el.
6042
6043 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6044
6045 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6046
6047 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6048
6049 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6050
6051 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6052
6053 * dispnew.c (scrolling_window): Don't exclude the case that the
6054 last enabled row in the desired matrix touches the bottom boundary.
6055
6056 2011-05-21 Glenn Morris <rgm@gnu.org>
6057
6058 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6059 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6060 and add some more files.
6061
6062 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6063
6064 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6065 report_file_error introduced by the change from 2011-05-07.
6066
6067 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6068
6069 * systime.h (Time): Define only if emacs is defined.
6070 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6071 where the include path doesn't have X11/X.h by default. See
6072 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6073
6074 2011-05-20 Kenichi Handa <handa@m17n.org>
6075
6076 * composite.c (find_automatic_composition): Fix previous change.
6077
6078 2011-05-20 Glenn Morris <rgm@gnu.org>
6079
6080 * lisp.mk: New file, split from Makefile.in.
6081 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6082 (shortlisp): Remove.
6083 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6084
6085 2011-05-19 Glenn Morris <rgm@gnu.org>
6086
6087 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6088 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6089 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6090 (lisp): Set the order to that of loadup.el.
6091 (shortlisp): Make it a copy of $lisp.
6092 (SOME_MACHINE_LISP): Remove.
6093 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6094 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6095
6096 2011-05-18 Kenichi Handa <handa@m17n.org>
6097
6098 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6099 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6100 (find_automatic_composition): Mostly rewrite for efficiency.
6101
6102 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6103
6104 * makefile.w32-in: Update dependencies.
6105
6106 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6107
6108 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6109 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6110
6111 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6112
6113 Fix some integer overflow issues, such as string length overflow.
6114
6115 * insdel.c (count_size_as_multibyte): Check for string overflow.
6116
6117 * character.c (lisp_string_width): Check for string overflow.
6118 Use EMACS_INT, not int, for string indexes and lengths; in
6119 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6120 the resulting string length overflows an EMACS_INT; instead,
6121 report a string overflow if no precision given. When checking for
6122 precision exhaustion, use a check that cannot possibly have
6123 integer overflow. (Bug#8675)
6124 * character.h (lisp_string_width): Adjust to new signature.
6125
6126 * alloc.c (string_overflow): New function.
6127 (Fmake_string): Use it. This doesn't change behavior, but saves
6128 a few bytes and will simplify future changes.
6129 * character.c (string_escape_byte8): Likewise.
6130 * lisp.h (string_overflow): New decl.
6131
6132 Fixups, following up to the user-interface timestamp change.
6133 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6134 for UI timestamps, instead of unsigned long.
6135 * msdos.c (mouse_get_pos): Likewise.
6136 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6137 * w32gui.h (Time): Define by including "systime.h" rather than by
6138 declaring it ourselves. (Bug#8664)
6139
6140 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6141 * image.c (clear_image_cache): Likewise.
6142
6143 * term.c (term_mouse_position): Don't assume time_t wraparound.
6144
6145 Be more systematic about user-interface timestamps.
6146 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6147 and sometimes 'EMACS_UINT', to represent these timestamps.
6148 This change causes it to use 'Time' uniformly, as that's what X uses.
6149 This makes the code easier to follow, and makes it easier to catch
6150 integer overflow bugs such as Bug#8664.
6151 * frame.c (Fmouse_position, Fmouse_pixel_position):
6152 Use Time, not unsigned long, for user-interface timestamps.
6153 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6154 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6155 * keyboard.h (last_event_timestamp): Likewise.
6156 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6157 * menu.h (xmenu_show): Likewise.
6158 * term.c (term_mouse_position): Likewise.
6159 * termhooks.h (struct input_event.timestamp): Likewise.
6160 (struct terminal.mouse_position_hook): Likewise.
6161 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6162 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6163 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6164 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6165 what it was before.
6166 * menu.h, termhooks.h: Include "systime.h", for Time.
6167
6168 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6169 Don't assume that the difference between two unsigned long values
6170 can fit into an integer. At this point, we know button_down_time
6171 <= event->timestamp, so the difference must be nonnegative, so
6172 there's no need to cast the result if double-click-time is
6173 nonnegative, as it should be; check that it's nonnegative, just in
6174 case. This bug is triggered when events are more than 2**31 ms
6175 apart (about 25 days). (Bug#8664)
6176
6177 * xselect.c (last_event_timestamp): Remove duplicate decl.
6178 (x_own_selection): Remove needless cast to unsigned long.
6179
6180 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6181 that always fit in int. Use a sentinel instead of a counter, to
6182 avoid a temp and to allay GCC's concerns about possible int overflow.
6183 * frame.h (struct frame): Use int for menu_bar_items_used
6184 instead of EMACS_INT, since it always fits in int.
6185
6186 * menu.c (grow_menu_items): Check for int overflow.
6187
6188 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6189
6190 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6191 Before, the code was not consistent. These values cannot exceed
6192 2**31 - 1 so there's no need to make them unsigned.
6193 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6194 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6195 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6196 as modifiers.
6197 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6198
6199 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6200 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6201 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6202 presumably because the widths might not match.
6203
6204 * window.c (size_window): Avoid needless test at loop start.
6205
6206 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6207
6208 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6209
6210 2011-05-12 Drew Adams <drew.adams@oracle.com>
6211
6212 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6213
6214 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6215
6216 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6217 `width' to `bar_area_x' and `bar_area_width', respectively.
6218 (x_scroll_run): Take account of fringe background extension.
6219
6220 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6221 Rename local vars `left' and `width' to `bar_area_x' and
6222 `bar_area_width', respectively.
6223 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6224 background extension.
6225
6226 2011-05-10 Jim Meyering <meyering@redhat.com>
6227
6228 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6229
6230 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6231
6232 * image.c (Finit_image_library): Return t for built-in image types,
6233 like pbm and xbm. (Bug#8640)
6234
6235 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6236
6237 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6238
6239 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6240
6241 * w32console.c (Fset_screen_color): Doc fix.
6242 (Fget_screen_color): New function.
6243 (syms_of_ntterm): Defsubr it.
6244
6245 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6246 unlink the temporary file if Fcall_process didn't create it in the
6247 first place.
6248 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6249 child process will be redirected to a file specified with `:file'.
6250 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6251 cue to call_process_cleanup not to close that handle.
6252
6253 2011-05-07 Ben Key <bkey76@gmail.com>
6254
6255 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6256 one of two shell specific rules, either bootstrap-temacs-CMD or
6257 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6258 to the previous implementation of the bootstrap-temacs rule.
6259 The bootstrap-temacs-CMD rule is similar to the previous
6260 implementation of the bootstrap-temacs rule except that it
6261 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6262 variable.
6263
6264 These changes, along with some changes to nt/configure.bat,
6265 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6266 earlier fix to add support for --cflags and --ldflags options
6267 that include quotes so that it works whether make uses cmd or
6268 sh as the shell.
6269
6270 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6271
6272 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6273 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6274 is a constant.
6275 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6276 a string. Handle both cases.
6277 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6278 (Fdbus_register_method): Use Qinvalid_function.
6279
6280 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6281
6282 * makefile.w32-in: Update dependencies.
6283 (LISP_H): Add inttypes.h and stdin.h.
6284 (PROCESS_H): Add unistd.h.
6285
6286 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6287
6288 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6289 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6290
6291 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6292
6293 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6294
6295 * term.c (vfatal): Remove stray call to va_end.
6296 It's not needed and the C Standard doesn't allow it here anyway.
6297
6298 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6299 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6300
6301 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6302 bytes.
6303
6304 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6305
6306 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6307
6308 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6309
6310 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6311
6312 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6313
6314 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6315 * charset.c (Fdefine_charset_internal): Don't initialize
6316 charset.code_space[15]. The value was garbage, on hosts with
6317 32-bit int (Bug#8600).
6318
6319 * lread.c (read_integer): Be more consistent with string-to-number.
6320 Use string_to_number to do the actual conversion; this avoids
6321 rounding errors and fixes some other screwups. Without this fix,
6322 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6323 (digit_to_number): Move earlier, for benefit of read_integer.
6324 Return -1 if the digit is out of range for the base, -2 if it is
6325 not a digit in any supported base. (Bug#8602)
6326
6327 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6328
6329 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6330 to match comment at start of function. This also removes a
6331 GCC warning about overflow in a 32+64-bit port.
6332
6333 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6334
6335 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6336 Reported by Stefan Monnier in
6337 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6338 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6339 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6340
6341 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6342 (EMACS_UINTPTR): Likewise, with uintptr_t.
6343
6344 * lisp.h: Prefer 64-bit EMACS_INT if available.
6345 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6346 on 32-bit hosts that have 64-bit int, so that they can access
6347 large files.
6348 However, temporarily disable this change unless the temporary
6349 symbol WIDE_EMACS_INT is defined.
6350
6351 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6352
6353 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6354 This removes an assumption that EMACS_INT and long are the same
6355 width as pointers. The assumption is true for Emacs porting targets
6356 now, but we want to make other targets possible.
6357 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6358 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6359 In the rest of the code, change types of integers that hold casted
6360 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6361 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6362 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6363 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6364 No need to cast type when ORing.
6365 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6366 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6367 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6368 assume EMACS_INT is the same width as char *.
6369 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6370 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6371 Remove no-longer-needed casts.
6372 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6373 (xg_tool_bar_help_callback, xg_make_tool_item):
6374 Use EMACS_INTPTR to hold an integer
6375 that will be cast to void *; this can avoid a GCC warning
6376 if EMACS_INT is not the same width as void *.
6377 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6378 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6379 (current_message_1, set_message_1):
6380 Use a local to convert to proper width without a cast.
6381 * xmenu.c (dialog_selection_callback): Likewise.
6382
6383 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6384 Also, don't assume VALBITS / RAND_BITS is less than 5,
6385 and don't rely on undefined behavior when shifting a 1 left into
6386 the sign bit.
6387 * lisp.h (get_random): Change signature to match.
6388
6389 * lread.c (hash_string): Use size_t, not int, for hash computation.
6390 Normally we prefer signed values; but hashing is special, because
6391 it's better to use unsigned division on hash table sizes so that
6392 the remainder is nonnegative. Also, size_t is the natural width
6393 for hashing into memory. The previous code used 'int', which doesn't
6394 retain enough info to hash well into very large tables.
6395 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6396
6397 * dbusbind.c: Don't possibly lose pointer info when converting.
6398 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6399 Use XPNTR rather than XHASH, so that the high-order bits of
6400 the pointer aren't lost when converting through void *.
6401
6402 * eval.c (Fautoload): Don't double-shift a pointer.
6403
6404 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6405
6406 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6407
6408 * gnutls.c (DEF_GNUTLS_FN):
6409 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6410
6411 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6412
6413 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6414 marker. (Bug#8610)
6415
6416 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6417
6418 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6419 New version that can reserve upto 2GB of heap space.
6420
6421 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6422
6423 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6424
6425 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6426
6427 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6428 `gnutls_certificate_set_x509_key_file'.
6429
6430 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6431
6432 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6433 Update dependencies.
6434
6435 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6436
6437 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6438 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6439 Remove unused parameter `fildes'.
6440 * process.c (read_process_output, send_process): Don't pass it.
6441
6442 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6443
6444 Fix previous change: the library cache is defined in w32.c.
6445 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6446 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6447
6448 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6449
6450 Implement dynamic loading of GnuTLS on Windows.
6451
6452 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6453 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6454 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6455 Declare.
6456
6457 * gnutls.c (Qgnutls_dll): Define.
6458 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6459 (gnutls_*): Declare function pointers.
6460 (init_gnutls_functions): New function to initialize function pointers.
6461 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6462 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6463 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6464 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6465 (emacs_gnutls_write, emacs_gnutls_read)
6466 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6467 (Fgnutls_available_p): New function.
6468 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6469 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6470 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6471
6472 * image.c: Include w32.h.
6473 (Vimage_type_cache): Delete.
6474 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6475 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6476 (w32_delayed_load): Move to w32.c.
6477
6478 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6479
6480 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6481 (w32_delayed_load): Move from image.c. When loading a library, record
6482 its filename in the :loaded-from property of the library id.
6483 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6484 Initialize and staticpro them.
6485 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6486
6487 * process.c: Include lisp.h before w32.h, not after.
6488 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6489 instead of gnutls_record_check_pending.
6490
6491 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6492
6493 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6494
6495 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6496 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6497 as passed in.
6498
6499 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6500
6501 * xterm.c (x_set_frame_alpha): Do not set property on anything
6502 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6503
6504 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6505
6506 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6507
6508 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6509
6510 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6511 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6512 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6513 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6514 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6515 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6516 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6517 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6518 (Qgnutls_bootprop_callbacks_verify): Make static.
6519
6520 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6521
6522 * callproc.c: Indentation fixup.
6523
6524 * sysdep.c (wait_for_termination_1): Make static.
6525 (wait_for_termination, interruptible_wait_for_termination):
6526 Move after wait_for_termination_1.
6527
6528 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6529
6530 * sysdep.c (interruptible_wait_for_termination): New function
6531 which is like wait_for_termination, but allows keyboard
6532 interruptions.
6533
6534 * callproc.c (Fcall_process): Add (:file "file") as an option for
6535 the STDOUT buffer.
6536 (Fcall_process_region): Ditto.
6537
6538 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6539
6540 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6541 rather than `XVECTOR (FOO)->size'.
6542
6543 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6544 inttypes.h, as a gnulib replacement is used if it not available in
6545 system headers.
6546
6547 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6548
6549 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6550 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6551 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6552
6553 * coding.c (coding_alloc_by_realloc): Error out if destination
6554 will grow beyond MOST_POSITIVE_FIXNUM.
6555 (decode_coding_emacs_mule): Abort if there isn't enough place in
6556 charbuf for the composition carryover bytes. Reserve an extra
6557 space for up to 2 characters produced in a loop.
6558 (decode_coding_iso_2022): Abort if there isn't enough place in
6559 charbuf for the composition carryover bytes.
6560
6561 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6562
6563 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6564 aborting when %lld or %lll format is passed.
6565 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6566 %llo or %llx format is passed. (Bug#8545)
6567
6568 * window.c (window_scroll_line_based): Use a marker instead of
6569 simple variables to record original value of point. (Bug#7952)
6570
6571 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6572 produced by %s or %c overflows available buffer space. (Bug#8545)
6573
6574 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6575
6576 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6577 (SIZE_MAX): Move defn after all includes, as they might #define it.
6578
6579 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6580
6581 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6582
6583 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6584
6585 * keyboard.c (Qdelayed_warnings_hook): Define.
6586 (command_loop_1): Run `delayed-warnings-hook'
6587 if Vdelayed_warnings_list is non-nil.
6588 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6589 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6590
6591 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6592
6593 * doprnt.c (doprnt): Don't return value smaller than the buffer
6594 size if the message was truncated. (Bug#8545).
6595
6596 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6597
6598 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6599 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6600
6601 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6602
6603 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6604
6605 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6606
6607 * makefile.w32-in: Update dependencies.
6608
6609 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6610
6611 Improve `doprnt' and its usage. (Bug#8545)
6612 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6613 `format_end'. Remove support for %l as a conversion specifier.
6614 Don't use xrealloc. Improve diagnostics when the %l size modifier
6615 is used. Update the commentary.
6616
6617 * eval.c (verror): Simplify calculation of size_t.
6618
6619 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6620 messages.
6621
6622 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6623
6624 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6625 change.
6626
6627 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6628
6629 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6630 This makes this file independent of the recent pseudovector change.
6631
6632 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6633
6634 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6635
6636 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6637 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6638 Remove unused local.
6639 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6640
6641 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6642 GCC 4.6.0 optimizes based on type-based alias analysis.
6643 For example, if b is of type struct buffer * and v of type struct
6644 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6645 != &v->size, and therefore "v->size = 1; b->size = 2; return
6646 v->size;" must therefore return 1. This assumption is incorrect
6647 for Emacs, since it type-puns struct Lisp_Vector * with many other
6648 types. To fix this problem, this patch adds a new type struct
6649 vectorlike_header that documents the constraints on layout of vectors
6650 and pseudovectors, and helps optimizing compilers not get fooled
6651 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6652 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6653 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6654 the size member.
6655 (XSETPVECTYPE): Rewrite in terms of new macro.
6656 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6657 This is a bit clearer, and further avoids the possibility of
6658 undesirable aliasing.
6659 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6660 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6661 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6662 since Lisp_Subr is a special case (no "next" field).
6663 (ASIZE): Now uses header.size rather than size.
6664 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6665 to avoid the hassle of writing XVECTOR (foo)->header.size.
6666 (struct vectorlike_header): New type.
6667 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6668 object, to help avoid aliasing.
6669 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6670 (SUBRP): Likewise, since Lisp_Subr is a special case.
6671 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6672 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6673 (struct Lisp_Hash_Table): Combine first two members into a single
6674 struct vectorlike_header member. All uses of "size" and "next" members
6675 changed to be "header.size" and "header.next".
6676 * buffer.h (struct buffer): Likewise.
6677 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6678 * frame.h (struct frame): Likewise.
6679 * process.h (struct Lisp_Process): Likewise.
6680 * termhooks.h (struct terminal): Likewise.
6681 * window.c (struct save_window_data, struct saved_window): Likewise.
6682 * window.h (struct window): Likewise.
6683 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6684 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6685 * buffer.c (init_buffer_once): Likewise.
6686 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6687 special case.
6688 * process.c (Fformat_network_address): Use local var for size,
6689 for brevity.
6690
6691 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6692
6693 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6694 * data.c (atof): Remove decl; no longer used or needed.
6695 (digit_to_number): Move to lread.c.
6696 (Fstring_to_number): Use new string_to_number function, to be
6697 consistent with how the Lisp reader treats infinities and NaNs.
6698 Do not assume that floating-point numbers represent EMACS_INT
6699 without losing information; this is not true on most 64-bit hosts.
6700 Avoid double-rounding errors, by insisting on integers when
6701 parsing non-base-10 numbers, as the documentation specifies.
6702 * lisp.h (string_to_number): New decl, replacing ...
6703 (isfloat_string): Remove.
6704 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6705 (read1): Do not accept +. and -. as integers; this
6706 appears to have been a coding error. Similarly, do not accept
6707 strings like +-1e0 as floating point numbers. Do not report
6708 overflow for integer overflows unless the base is not 10 which
6709 means we have no simple and reliable way to continue.
6710 Break out the floating-point parsing into a new
6711 function string_to_number, so that Fstring_to_number parses
6712 floating point numbers consistently with the Lisp reader.
6713 (digit_to_number): Move here from data.c. Make it static inline.
6714 (E_CHAR, EXP_INT): Remove, replacing with ...
6715 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6716 (string_to_number): New function, replacing isfloat_string.
6717 This function checks for valid syntax and produces the resulting
6718 Lisp float number too. Rework it so that string-to-number
6719 no longer mishandles examples like "1.0e+". Use strtoumax,
6720 so that overflow for non-base-10 numbers is reported only when
6721 there's no portable and simple way to convert to floating point.
6722
6723 * textprop.c (set_text_properties_1): Rewrite for clarity,
6724 and to avoid GCC warning about integer overflow.
6725
6726 * intervals.h (struct interval): Use EMACS_INT for members
6727 where EMACS_UINT might cause problems. See
6728 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6729 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6730 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6731 All uses changed.
6732 (offset_intervals): Tell GCC not to worry about length overflow
6733 when negating a negative length.
6734
6735 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6736 (overrun_check_free): Likewise.
6737
6738 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6739 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6740 word size.
6741
6742 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6743 (gnutls_make_error): Rename local to avoid shadowing.
6744 (gnutls_emacs_global_deinit): ifdef out; not used.
6745 (Fgnutls_boot): Use const for pointer to readonly storage.
6746 Comment out unused local. Fix pointer signedness problems.
6747
6748 * lread.c (openp): Don't stuff size_t into an 'int'.
6749 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6750 about possible signed overflow.
6751
6752 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6753 (GDK_KEY_g): Don't define if already defined.
6754 (xg_prepare_tooltip): Avoid pointer signedness problem.
6755 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6756
6757 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6758 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6759
6760 * xfns.c (Fx_window_property): Simplify a bit,
6761 to make a bit faster and to avoid GCC 4.6.0 warning.
6762 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6763
6764 * fns.c (internal_equal): Don't assume size_t fits in int.
6765
6766 * alloc.c (compact_small_strings): Tighten assertion a little.
6767
6768 Replace pEd with more-general pI, and fix some printf arg casts.
6769 * lisp.h (pI): New macro, generalizing old pEd macro to other
6770 conversion specifiers. For example, use "...%"pI"d..." rather
6771 than "...%"pEd"...".
6772 (pEd): Remove. All uses replaced with similar uses of pI.
6773 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
6774 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6775 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6776 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6777 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6778 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6779 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6780 64-bit hosts.
6781 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6782 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6783 * print.c (safe_debug_print, print_object): Likewise.
6784 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6785 to int.
6786 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6787 avoiding the 0 flag, which is not portable.
6788 * process.c (Fmake_network_process): Use pI to avoid cast.
6789 * region-cache.c (pp_cache): Likewise.
6790 * xdisp.c (decode_mode_spec): Likewise.
6791 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6792 behavior on 64-bit hosts with printf arg.
6793 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6794 (x_stop_queuing_selection_requests): Likewise.
6795 (x_get_window_property): Don't truncate byte count to an 'int'
6796 when tracing.
6797
6798 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6799 here, since it parses constructs like leading '-' and spaces,
6800 which are not wanted; and it overflows with large numbers.
6801 Instead, simply match F[0-9]+, which is what is wanted anyway.
6802
6803 * alloc.c: Remove unportable assumptions about struct layout.
6804 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6805 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6806 (allocate_vectorlike, make_pure_vector): Use the new macros,
6807 plus offsetof, to remove unportable assumptions about struct layout.
6808 These assumptions hold on all porting targets that I know of, but
6809 they are not guaranteed, they're easy to remove, and removing them
6810 makes further changes easier.
6811
6812 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6813 This doesn't fix a bug but makes the code clearer.
6814 (string_overrun_cookie): Now const. Use initializers that
6815 don't formally overflow signed char, to avoid warnings.
6816 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6817 can cause Emacs to crash when string overrun checking is enabled.
6818 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6819 multiple of sizeof (EMACS_INT); it need not be, if
6820 alignof(EMACS_INT) < sizeof (EMACS_INT).
6821 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6822
6823 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6824
6825 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6826
6827 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6828
6829 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6830 supposed to be handshaking. (Bug#8556)
6831 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6832
6833 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6834
6835 * lisp.h (Qdebug): List symbol.
6836 * eval.c (Qdebug): Restore global linkage.
6837 * keyboard.c (debug-on-event): New variable.
6838 (handle_user_signal): Break into debugger when debug-on-event
6839 matches the current signal symbol.
6840
6841 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6842
6843 * alloc.c (check_sblock, check_string_bytes)
6844 (check_string_free_list): Convert to standard C.
6845
6846 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6847
6848 * w32.c (emacs_gnutls_push): Fix typo.
6849
6850 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6851
6852 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6853 "cast to pointer from integer of different size".
6854
6855 Improve doprnt and its use in verror. (Bug#8545)
6856 * doprnt.c (doprnt): Document the set of format control sequences
6857 supported by the function. Use SAFE_ALLOCA instead of always
6858 using `alloca'.
6859
6860 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6861 is one byte too soon. Don't use xrealloc; instead xfree and
6862 xmalloc anew.
6863
6864 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6865
6866 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6867 callbacks stage.
6868
6869 * gnutls.c: Renamed global_initialized to
6870 gnutls_global_initialized. Added internals for the
6871 :verify-hostname-error, :verify-error, and :verify-flags
6872 parameters of `gnutls-boot' and documented those parameters in the
6873 docstring. Start callback support.
6874 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6875 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6876 on error. Return error code.
6877 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6878 (emacs_gnutls_read): Likewise.
6879 (Fgnutls_boot): Return handshake error code.
6880 (emacs_gnutls_handle_error): New function.
6881 (wsaerror_to_errno): Likewise.
6882
6883 * w32.h (emacs_gnutls_pull): Add prototype.
6884 (emacs_gnutls_push): Likewise.
6885
6886 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6887 (emacs_gnutls_push): Likewise.
6888
6889 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6890
6891 * process.c (wait_reading_process_output): Check if GnuTLS
6892 buffered some data internally if no FDs are set for TLS
6893 connections.
6894
6895 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6896 (LIBS): Link to USER_LIBS.
6897 ($(BLD)/gnutls.$(0)): New target.
6898
6899 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6900
6901 * xdisp.c (handle_single_display_spec): Rename the
6902 display_replaced_before_p argument into display_replaced_p, to
6903 make it consistent with the commentary. Fix typos in the
6904 commentary.
6905
6906 * textprop.c (syms_of_textprop): Remove dead code.
6907 (copy_text_properties): Delete obsolete commentary about an
6908 interface that was deleted long ago. Fix typos in the description
6909 of arguments.
6910
6911 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6912 to changes in oldXMenu/XMenu.h from 2011-04-16.
6913 <menu_help_message, prev_menu_help_message>: Constify.
6914 (IT_menu_make_room): menu->help_text is now `const char **';
6915 adjust.
6916
6917 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6918 to changes in oldXMenu/XMenu.h from 2011-04-16.
6919 (struct XMenu): Declare `help_text' `const char **'.
6920
6921 * xfaces.c <Qunspecified>: Make extern again.
6922
6923 * syntax.c: Include sys/types.h before including regex.h, as
6924 required by Posix.
6925
6926 * doc.c (get_doc_string): Improve the format passed to `error'.
6927
6928 * doprnt.c (doprnt): Improve commentary.
6929
6930 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6931
6932 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6933 them with etags.
6934
6935 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6936 changes in globals.h immediately force recompilation.
6937 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6938 $(CURDIR)/s/ms-w32.h.
6939 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6940
6941 * character.c (Fchar_direction): Function deleted.
6942 (syms_of_character): Don't defsubr it.
6943 <char-direction-table>: Deleted.
6944
6945 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6946
6947 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6948 * doprnt.c: Include limits.h.
6949 (SIZE_MAX): New macro.
6950 (doprnt): Return a size_t value. 2nd arg is now size_t.
6951 Many local variables are now size_t instead of int or unsigned.
6952 Improve overflow protection. Support `l' modifier for integer
6953 conversions. Support %l conversion. Don't assume an EMACS_INT
6954 argument for integer conversions and for %c.
6955
6956 * lisp.h (doprnt): Restore prototype.
6957
6958 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6959 $(SRC)/character.h.
6960
6961 * Makefile.in (base_obj): Add back doprnt.o.
6962
6963 * deps.mk (doprnt.o): Add back prerequisites.
6964 (callint.o): Depend on character.h.
6965
6966 * eval.c (internal_lisp_condition_case): Include the handler
6967 representation in the error message.
6968 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6969 when breaking from the loop.
6970
6971 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6972
6973 * callint.c (Fcall_interactively): When displaying error message
6974 about invalid control letter, pass the character's codepoint, not
6975 a pointer to its multibyte form. Improve display of the character
6976 in octal and display also its hex code.
6977
6978 * character.c (char_string): Use %x to display the (unsigned)
6979 codepoint of an invalid character, to avoid displaying a bogus
6980 negative value.
6981
6982 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6983 `error', not SYMBOL_NAME itself.
6984
6985 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6986 character arguments to `error'.
6987
6988 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6989 to `error' in error message about FINAL_CHAR argument. Make sure
6990 FINAL_CHAR is a character, and use %c when it is passed as
6991 argument to `error'.
6992
6993 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6994
6995 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6996
6997 * w32.c: Include <time.h>.
6998 (sys_localtime): New function.
6999
7000 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7001
7002 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7003
7004 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7005
7006 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7007
7008 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7009 zombies (Bug#8467).
7010
7011 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7012
7013 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7014 gl_state.e_property when gl_state.object is Qt.
7015
7016 * insdel.c (make_gap_larger): Remove limitation of buffer size
7017 to <= INT_MAX.
7018
7019 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7020
7021 * xdisp.c (lookup_glyphless_char_display)
7022 (produce_glyphless_glyph): Handle cons cell entry in
7023 glyphless-char-display.
7024 (Vglyphless_char_display): Document it.
7025
7026 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7027 glyphless-char-display.
7028
7029 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7030
7031 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7032
7033 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7034
7035 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7036 definition for no-X builds.
7037
7038 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7039
7040 Static checks with GCC 4.6.0 and non-default toolkits.
7041
7042 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7043
7044 * process.c (keyboard_bit_set): Define only if SIGIO.
7045 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7046 (send_process): Repair possible setjmp clobbering.
7047
7048 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7049
7050 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7051
7052 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7053
7054 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7055 Define only if needed.
7056
7057 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7058 by pacifying GCC about it. Maybe it's time to retire it?
7059 * xfaces.c (USG, __TIMEVAL__): Likewise.
7060
7061 * dispextern.h (struct redisplay_interface): Rename param
7062 to avoid shadowing.
7063 * termhooks.h (struct terminal): Likewise.
7064 * xterm.c (xembed_send_message): Likewise.
7065
7066 * insdel.c (make_gap_smaller): Define only if
7067 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7068
7069 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7070 it.
7071
7072 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7073 so that we aren't warned about unused symbols.
7074
7075 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7076
7077 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7078
7079 * xfns.c (x_real_positions): Mark locals as initialized.
7080
7081 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7082
7083 * xterm.c: Fix problems found by static analysis with other toolkits.
7084 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7085 (x_dispatch_event): Declare static if USE_GTK, and
7086 define if USE_GTK || USE_X_TOOLKIT.
7087 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7088 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7089 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7090 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7091
7092 * xmenu.c (menu_help_callback): Pointer type fixes.
7093 Use const pointers when pointing at readonly data. Avoid pointer
7094 signedness clashes.
7095 (FALSE): Remove unused macro.
7096 (update_frame_menubar): Remove unused decl.
7097
7098 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7099
7100 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7101 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7102 (single_menu_item): Rename local to avoid shadowing.
7103
7104 * keyboard.c (make_lispy_event): Remove unused local var.
7105
7106 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7107 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7108
7109 * bitmaps: Change bitmaps from unsigned char back to the X11
7110 compatible char. Avoid the old compiler warnings about
7111 out-of-range initializers by using, for example, '\xab' rather
7112 than 0xab.
7113
7114 * xgselect.c (xgselect_initialize): Check vs interface
7115 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7116
7117 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7118
7119 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7120 to read-only memory.
7121
7122 * fns.c (vector): Remove; this old hack is no longer needed.
7123
7124 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7125 Remove unused var.
7126 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7127
7128 * xrdb.c (x_load_resources): Omit unused local.
7129
7130 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7131 (x_window): Rename locals to avoid shadowing.
7132 (USG): Use the kludged USG macro, to pacify gcc.
7133
7134 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7135 (x_term_init): Remove local to avoid shadowing.
7136
7137 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7138
7139 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7140 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7141
7142 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7143
7144 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7145
7146 Fix regex.c, syntax.c and friends for buffers > 2GB.
7147 * syntax.h (struct gl_state_s): Declare character position members
7148 EMACS_INT.
7149
7150 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7151
7152 * textprop.c (verify_interval_modification, interval_of):
7153 Declare arguments EMACS_INT.
7154
7155 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7156 EMACS_INT.
7157
7158 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7159
7160 * indent.c (Fvertical_motion): Local variable it_start is now
7161 EMACS_INT.
7162
7163 * regex.c (re_match, re_match_2, re_match_2_internal)
7164 (bcmp_translate, regcomp, regexec, print_double_string)
7165 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7166 (re_compile_pattern, re_exec): Declare arguments and local
7167 variables `size_t' and `ssize_t' and return values `regoff_t', as
7168 appropriate.
7169 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7170 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7171 <compile_stack_type>: `size' and `avail' are now `size_t'.
7172
7173 * regex.h <regoff_t>: Use ssize_t, not int.
7174 (re_search, re_search_2, re_match, re_match_2): Arguments that
7175 specify buffer/string position and length are now ssize_t and
7176 size_t. Return type is regoff_t.
7177
7178 2011-04-16 Ben Key <bkey76@gmail.com>
7179
7180 * nsfont.m: Fixed bugs in ns_get_family and
7181 ns_descriptor_to_entity that were caused by using free to
7182 deallocate memory blocks that were allocated by xmalloc (via
7183 xstrdup). This caused Emacs to crash when compiled with
7184 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7185 --enable-checking=xmallocoverrun). xfree is now used to
7186 deallocate these memory blocks.
7187
7188 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7189
7190 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7191
7192 emacs_write: Accept and return EMACS_INT for sizes.
7193 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7194 et seq.
7195 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7196 Accept and return EMACS_INT.
7197 (emacs_gnutls_write): Return the number of bytes written on
7198 partial writes.
7199 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7200 (emacs_read, emacs_write): Remove check for negative size, as the
7201 Emacs source code has been audited now.
7202 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7203 (emacs_read, emacs_write): Use it.
7204 * process.c (send_process): Adjust to the new signatures of
7205 emacs_write and emacs_gnutls_write. Do not attempt to store
7206 a byte offset into an 'int'; it might overflow.
7207 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7208
7209 * sound.c: Don't assume sizes fit in 'int'.
7210 (struct sound_device.period_size, alsa_period_size):
7211 Return EMACS_INT, not int.
7212 (struct sound_device.write, vox_write, alsa_write):
7213 Accept EMACS_INT, not int.
7214 (wav_play, au_play): Use EMACS_INT to store sizes and to
7215 record read return values.
7216
7217 2011-04-15 Ben Key <bkey76@gmail.com>
7218
7219 * keyboard.c (Qundefined): Don't declare static since it is used
7220 in nsfns.m.
7221 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7222 static since they are used in nsfont.m.
7223
7224 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7225
7226 * process.c (Qprocessp): Don't declare static.
7227 * lisp.h (Qprocessp): Declare again.
7228
7229 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7230
7231 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7232
7233 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7234
7235 Improve C-level modularity by making more things 'static'.
7236
7237 Don't publish debugger-only interfaces to other modules.
7238 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7239 (verify_bytepos, count_markers): Move decls to the only modules
7240 that need them.
7241 * region-cache.h (pp_cache): Likewise.
7242 * window.h (check_all_windows): Likewise.
7243 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7244
7245 * sysdep.c (croak): Now static, if
7246 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7247 * syssignal.h (croak): Declare only if not static.
7248
7249 * alloc.c (refill_memory_reserve): Now static if
7250 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7251 * lisp.h (refill_memory_reserve): Declare only if not static.
7252
7253 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7254 Define only if USE_LUCID.
7255
7256 * xrdb.c (x_customization_string, x_rm_string): Now static.
7257
7258 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7259 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7260
7261 * xdisp.c (draw_row_with_mouse_face): Now static.
7262 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7263
7264 * window.h (check_all_windows): Mark externally visible.
7265
7266 * window.c (window_deletion_count): Now static.
7267
7268 * undo.c: Make symbols static if they're not exported.
7269 (last_undo_buffer, last_boundary_position, pending_boundary):
7270 Now static.
7271
7272 * textprop.c (interval_insert_behind_hooks): Now static.
7273 (interval_insert_in_front_hooks): Likewise.
7274
7275 * term.c: Make symbols static if they're not exported.
7276 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7277 (max_frame_lines, tty_set_terminal_modes):
7278 (tty_reset_terminal_modes, tty_turn_off_highlight):
7279 (get_tty_terminal): Now static.
7280 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7281 * termhooks.h (term_mouse_moveto): Do not declare if
7282 HAVE_WINDOW_SYSTEM.
7283 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7284 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7285
7286 * sysdep.c: Make symbols static if they're not exported.
7287 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7288 Now static.
7289 (sigprocmask_set, full_mask): Remove; unused.
7290 (wait_debugging): Mark as visible.
7291 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7292 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7293
7294 * syntax.c (syntax_temp): Define only if !__GNUC__.
7295
7296 * sound.c (current_sound_device, current_sound): Now static.
7297
7298 * search.c (searchbufs, searchbuf_head): Now static.
7299
7300 * scroll.c (scroll_cost): Remove; unused.
7301 * dispextern.h (scroll_cost): Remove decl.
7302
7303 * region-cache.h (pp_cache): Mark as externally visible.
7304
7305 * process.c: Make symbols static if they're not exported.
7306 (process_tick, update_tick, create_process, chan_process):
7307 (Vprocess_alist, proc_buffered_char, datagram_access):
7308 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7309 (deactivate_process): Mark defn as static, as well as decl.
7310 * lisp.h (create_process): Remove decl.
7311 * process.h (chan_process, Vprocess_alist): Remove decls.
7312
7313 * print.c: Make symbols static if they're not exported.
7314 (print_depth, new_backquote_output, being_printed, print_buffer):
7315 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7316 (print_interval, print_number_index, initial_stderr_stream):
7317 Now static.
7318 * lisp.h (Fprinc): Remove decl.
7319 (debug_output_compilation_hack): Mark as externally visible.
7320
7321 * sysdep.c (croak): Move decl from here to syssignal.h.
7322 * syssignal.h (croak): Put it here, so the API can be checked when
7323 'croak' is called from dissociate_if_controlling_tty.
7324
7325 * minibuf.c: Make symbols static if they're not exported.
7326 (minibuf_save_list, choose_minibuf_frame): Now static.
7327 * lisp.h (choose_minibuf_frame): Remove decl.
7328
7329 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7330
7331 * lread.c: Make symbols static if they're not exported.
7332 (read_objects, initial_obarray, oblookup_last_bucket_number):
7333 Now static.
7334 (make_symbol): Remove; unused.
7335 * lisp.h (initial_obarray, make_symbol): Remove decls.
7336
7337 * keyboard.c: Make symbols static if they're not exported.
7338 (single_kboard, recent_keys_index, total_keys, recent_keys):
7339 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7340 (this_single_command_key_start, echoing, last_auto_save):
7341 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7342 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7343 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7344 (Vlispy_mouse_stem, double_click_count):
7345 Now static.
7346 (force_auto_save_soon): Define only if SIGDANGER.
7347 (ignore_mouse_drag_p): Now static if
7348 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7349 (print_help): Remove; unused.
7350 (stop_character, last_timer_event): Mark as externally visible.
7351 * keyboard.h (ignore_mouse_drag_p): Declare only if
7352 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7353 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7354 * lisp.h (echoing): Remove decl.
7355 (force_auto_save_soon): Declare only if SIGDANGER.
7356 * xdisp.c (redisplay_window): Simplify code, to make it more
7357 obvious that ignore_mouse_drag_p is not accessed if !defined
7358 USE_GTK && !defined HAVE_NS.
7359
7360 * intervals.c: Make symbols static if they're not exported.
7361 (merge_properties_sticky, merge_interval_right, delete_interval):
7362 Now static.
7363 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7364
7365 * insdel.c: Make symbols static if they're not exported.
7366 However, leave prepare_to_modify_buffer alone. It's never
7367 called from outside this function, but that appears to be a bug.
7368 (combine_after_change_list, combine_after_change_buffer):
7369 (adjust_after_replace, signal_before_change): Now static.
7370 (adjust_after_replace_noundo): Remove; unused.
7371 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7372 (signal_before_change): Remove decls.
7373
7374 * indent.c (val_compute_motion, val_vmotion): Now static.
7375
7376 * image.c: Make symbols static if they're not exported.
7377 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7378 if USE_GTK.
7379 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7380 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7381
7382 * fringe.c (standard_bitmaps): Now static.
7383 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7384
7385 * frame.c: Make symbols static if they're not exported.
7386 (x_report_frame_params, make_terminal_frame): Now static.
7387 (get_frame_param): Now static, unless HAVE_NS.
7388 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7389 (x_get_resource_string): Remove; not used.
7390 * frame.h (make_terminal_frame, x_report_frame_params):
7391 (x_get_resource_string); Remove decls.
7392 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7393 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7394
7395 * font.c, fontset.c: Make symbols static if they're not exported.
7396 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7397 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7398 * font.c (font_close_object): Now static.
7399 * font.h (font_close_object): Remove.
7400 * fontset.c (FONTSET_OBJLIST): Remove.
7401 (free_realized_fontset) #if-0 the body, which does nothing.
7402 (face_suitable_for_char_p): #if-0, as it's never called.
7403 * fontset.h (face_suitable_for_char_p): Remove decl.
7404 * xfaces.c (face_at_string_position):
7405 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7406 since 0 is always ASCII.
7407
7408 * fns.c (weak_hash_tables): Now static.
7409
7410 * fileio.c: Make symbols static if they're not exported.
7411 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7412 (Vwrite_region_annotation_buffers): Now static.
7413
7414 * eval.c: Make symbols static if they're not exported.
7415 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7416 * lisp.h (backtrace_list): Remove decl.
7417
7418 * emacs.c: Make symbols static if they're not exported.
7419 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7420 (fatal_error_code, fatal_error_signal_hook, standard_args):
7421 Now static.
7422 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7423 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7424 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7425 * lisp.h (fatal_error_signal_hook): Remove decl.
7426 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7427
7428 * editfns.c: Move a (normally-unused) function to its only use.
7429 * editfns.c, lisp.h (get_operating_system_release): Remove.
7430 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7431 worth the hassle of breaking this out.
7432
7433 * xterm.c: Make symbols static if they're not exported.
7434 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7435 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7436 (x_destroy_window, x_delete_display):
7437 Now static.
7438 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7439 (x_mouse_leave): Remove; unused.
7440 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7441 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7442 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7443 Remove decls.
7444 (x_mouse_leave): Declare only if WINDOWSNT.
7445 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7446 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7447 USE_X_TOOLKIT.
7448
7449 * ftxfont.c: Make symbols static if they're not exported.
7450 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7451 HAVE_FREETYPE.
7452 * font.h (ftxfont_driver): Likewise.
7453
7454 * xfns.c: Make symbols static if they're not exported.
7455 (x_last_font_name, x_display_info_for_name):
7456 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7457 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7458 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7459 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7460 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7461 (last_show_tip_args): Now static.
7462 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7463 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7464 (x_screen_planes): Remove; unused.
7465 * dispextern.h (x_screen_planes): Remove decl.
7466
7467 * dispnew.c: Make symbols static if they're not exported.
7468 * dispextern.h (redraw_garbaged_frames, scrolling):
7469 (increment_row_positions): Remove.
7470 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7471 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7472 Now static.
7473 (redraw_garbaged_frames): Remove; unused.
7474
7475 * xfaces.c: Make symbols static if they're not exported.
7476 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7477 Remove decls.
7478 * xterm.h (defined_color): Remove decls.
7479 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7480 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7481 (menu_face_changed_default, defined_color, free_realized_face):
7482 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7483 (ascii_face_of_lisp_face): Remove; unused.
7484
7485 * xdisp.c: Make symbols static if they're not exported.
7486 * dispextern.h (scratch_glyph_row, window_box_edges):
7487 (glyph_to_pixel_coords, set_cursor_from_row):
7488 (get_next_display_element, set_iterator_to_next):
7489 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7490 (show_mouse_face): Remove decls
7491 * frame.h (message_buf_print): Likewise.
7492 * lisp.h (pop_message, set_message, check_point_in_composition):
7493 Likewise.
7494 * xterm.h (set_vertical_scroll_bar): Likewise.
7495 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7496 (message_buf_print, scratch_glyph_row, displayed_buffer):
7497 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7498 (get_next_display_element, show_mouse_face, window_box_edges):
7499 (frame_to_window_pixel_xy, check_point_in_composition):
7500 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7501 (glyph_to_pixel_coords): Remove; unused.
7502
7503 * dired.c (file_name_completion): Now static.
7504
7505 * dbusbind.c (xd_in_read_queued_messages): Now static.
7506
7507 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7508 * data.c (circular_list_error): Remove.
7509
7510 * commands.h (last_point_position, last_point_position_buffer):
7511 (last_point_position_window): Remove decls.
7512 * keyboard.c: Make these variables static.
7513
7514 * coding.h (coding, code_convert_region, encode_coding_gap):
7515 Remove decls.
7516 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7517 (iso_code_class, detect_coding, code_convert_region): Now static.
7518 (encode_coding_gap): Remove; unused.
7519
7520 * chartab.c (chartab_chars, chartab_bits): Now static.
7521
7522 * charset.h (charset_iso_8859_1): Remove decl.
7523 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7524 Now static.
7525
7526 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7527 * ccl.c (Vccl_program_table): Now static.
7528 (check_ccl_update): Remove; unused.
7529
7530 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7531 * category.h: ... from here.
7532 * category.c (check_category_table, set_category_set): Now static.
7533
7534 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7535 * lisp.h: Remove these decls.
7536
7537 * buffer.c (buffer_count): Remove unused var.
7538
7539 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7540 so that it's not optimized away.
7541 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7542 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7543 exported only to the debugger.
7544
7545 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7546 * atimer.h (run_all_atimers): Remove; not exported.
7547
7548 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7549 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7550 was inaccessible from Lisp.
7551 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7552 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7553
7554 alloc.c: Import and export fewer symbols, and remove unused items.
7555 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7556 is defined.
7557 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7558 it's not optimized away by whole-program optimization.
7559 (message_enable_multibyte, free_misc): Remove.
7560 (catchlist, handlerlist, mark_backtrace):
7561 Declare only if BYTE_MARK_STACK.
7562 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7563 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7564 (message_enable_multibyte): Remove decl.
7565 (free_misc, interval_free_list, float_block, float_block_index):
7566 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7567 (cons_free_list, last_marked_index):
7568 Now static.
7569 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7570 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7571 (mark_backtrace): Define only if BYTE_MARK_STACK.
7572 * xdisp.c (message_enable_multibyte): Now static.
7573
7574 Declare Lisp_Object Q* variables to be 'static' if not exported.
7575 This makes it easier for human readers (and static analyzers)
7576 to see whether these variables are used from other modules.
7577 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7578 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7579 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7580 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7581 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7582 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7583 * xmenu.c, xselect.c:
7584 Declare Q* vars static if they are not used in other modules.
7585 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7586 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7587 Remove decls of unexported vars.
7588 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7589
7590 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7591
7592 Make Emacs functions such as Fatom 'static' by default.
7593 This makes it easier for human readers (and static analyzers)
7594 to see whether these functions can be called from other modules.
7595 DEFUN now defines a static function. To make the function external
7596 so that it can be used in other C modules, use the new macro DEFUE.
7597 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7598 (Finit_image_library):
7599 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7600 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7601 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7602 Remove decls, since these functions are now static.
7603 (Funintern, Fget_internal_run_time): New decls, since these functions
7604 were already external.
7605
7606 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7607 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7608 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7609 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7610 * keyboard.c, keymap.c, lread.c:
7611 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7612 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7613 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7614 Mark functions with DEFUE instead of DEFUN,
7615 if they are used in other modules.
7616 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7617 decls for now-static functions.
7618 * buffer.h (Fdelete_overlay): Remove decl.
7619 * callproc.c (Fgetenv_internal): Mark as internal.
7620 * composite.c (Fremove_list_of_text_properties): Remove decl.
7621 (Fcomposition_get_gstring): New forward static decl.
7622 * composite.h (Fcomposite_get_gstring): Remove decl.
7623 * dired.c (Ffile_attributes): New forward static decl.
7624 * doc.c (Fdocumntation_property): New forward static decl.
7625 * eval.c (Ffetch_bytecode): New forward static decl.
7626 (Funintern): Remove extern decl; now in .h file where it belongs.
7627 * fileio.c (Fmake_symbolic_link): New forward static decl.
7628 * image.c (Finit_image_library): New forward static decl.
7629 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7630 * intervals.h (Fprevious_property_change):
7631 (Fremove_list_of_text_properties): Remove decls.
7632 * keyboard.c (Fthis_command_keys): Remove decl.
7633 (Fcommand_execute): New forward static decl.
7634 * keymap.c (Flookup_key): New forward static decl.
7635 (Fcopy_keymap): Now static.
7636 * keymap.h (Flookup_key): Remove decl.
7637 * process.c (Fget_process): New forward static decl.
7638 (Fprocess_datagram_address): Mark as internal.
7639 * syntax.c (Fsyntax_table_p): New forward static decl.
7640 (skip_chars): Remove duplicate decl.
7641 * textprop.c (Fprevious_property_change): New forward static decl.
7642 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7643 Now internal.
7644 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7645 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7646
7647 * editfns.c (Fformat): Remove unreachable code.
7648
7649 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7650
7651 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7652 change. (Bug#8496)
7653
7654 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7655
7656 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7657 when at ZV. (Bug#8487)
7658
7659 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7660
7661 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7662 (Bug#8437)
7663 * keyboard.c (parse_tool_bar_item): Likewise.
7664 * sound.c (sound_cleanup, alsa_close): Likewise.
7665 * termcap.c (tgetent): Likewise.
7666 * xfns.c (x_default_font_parameter): Likewise.
7667 * xsettings.c (read_and_apply_settings): Likewise.
7668
7669 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7670 (overrun_check_free): Protoize.
7671
7672 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7673
7674 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7675 since callers should never pass a negative size.
7676 Change the signature to match that of plain 'read' and 'write'; see
7677 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7678 * lisp.h: Update prototypes of emacs_write and emacs_read.
7679
7680 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7681
7682 * xdisp.c (redisplay_window): Don't try to determine the character
7683 position of the scroll margin if the window start point w->startp
7684 is outside the buffer's accessible region. (Bug#8468)
7685
7686 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7687
7688 Fix write-region and its subroutines for buffers > 2GB.
7689 * fileio.c (a_write, e_write): Modify declaration of arguments and
7690 local variables to support buffers larger than 2GB.
7691 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7692
7693 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7694 argument, local variables, and return value.
7695
7696 * lisp.h: Update prototypes of emacs_write and emacs_read.
7697
7698 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7699
7700 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7701
7702 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7703
7704 Fix more problems found by GCC 4.6.0's static checks.
7705
7706 * xdisp.c (vmessage): Use a better test for character truncation.
7707
7708 * charset.c (load_charset_map): <, not <=, for optimization,
7709 and to avoid potential problems with integer overflow.
7710 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7711 * casetab.c (set_identity, shuffle): Likewise.
7712 * editfns.c (Fformat): Likewise.
7713 * syntax.c (skip_chars): Likewise.
7714
7715 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7716 This also lets GCC 4.6.0 generate slightly better loop code.
7717
7718 * callint.c (Fcall_interactively): <, not <=, for optimization.
7719 (Fcall_interactively): Count the number of arguments produced,
7720 not the number of arguments given. This is simpler and lets GCC
7721 4.6.0 generate slightly better code.
7722
7723 * ftfont.c: Distingish more carefully between FcChar8 and char.
7724 The previous code passed unsigned char * to a functions like
7725 strlen and xstrcasecmp that expect char *, which does not
7726 conform to the C standard.
7727 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7728 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7729 char * when the C standard requires it.
7730
7731 * keyboard.c (read_char): Remove unused var.
7732
7733 * eval.c: Port to Windows vsnprintf (Bug#8435).
7734 Include <limits.h>.
7735 (SIZE_MAX): Define if the headers do not.
7736 (verror): Do not give up if vsnprintf returns a negative count.
7737 Instead, grow the buffer. This ports to Windows vsnprintf, which
7738 does not conform to C99. Problem reported by Eli Zaretskii.
7739 Also, simplify the allocation scheme, by avoiding the need for
7740 calling realloc, and removing the ALLOCATED variable.
7741
7742 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7743
7744 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7745 But keep the doprint source code for now, as we might revamp it
7746 and use it again (Bug#8435).
7747 * lisp.h (doprnt): Remove.
7748 * Makefile.in (base_obj): Remove doprnt.o.
7749 * deps.mk (doprnt.o): Remove.
7750
7751 error: Print 32- and 64-bit integers portably (Bug#8435).
7752 Without this change, on typical 64-bit hosts error ("...%d...", N)
7753 was used to print both 32- and 64-bit integers N, which relied on
7754 undefined behavior.
7755 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
7756 * lisp.h (error, verror): Mark as printf-like functions.
7757 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7758 Report overflow in size calculations when allocating printf buffer.
7759 Do not truncate output string at its first null byte.
7760 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7761 Truncate the output at a character boundary, since vsnprintf does not
7762 do that.
7763 * charset.c (check_iso_charset_parameter): Convert internal
7764 character to string before calling 'error', since %c now has the
7765 printf meaning.
7766 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7767 overflow when computing char to be passed to 'error'. Do not
7768 pass Lisp_Object to 'error'; pass the integer instead.
7769 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7770 formatted with plain %d.
7771
7772 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7773
7774 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7775
7776 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7777
7778 * xterm.c (x_catch_errors): Remove duplicate declaration.
7779
7780 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7781
7782 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7783
7784 2011-04-10 Jim Meyering <meyering@redhat.com>
7785
7786 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7787 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7788 return ssize_t not "int", and use size_t as the buffer length.
7789 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7790 * gnutls.h: Update declarations.
7791 * process.c (read_process_output): Use ssize_t, to match.
7792 (send_process): Likewise.
7793
7794 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7795
7796 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7797
7798 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7799
7800 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7801 Use unsigned char, to match FcChar8 type definition.
7802
7803 * xterm.c (handle_one_xevent):
7804 * xmenu.c (create_and_show_popup_menu):
7805 * xselect.c (x_decline_selection_request)
7806 (x_reply_selection_request): Avoid type-punned deref of X events.
7807
7808 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7809
7810 Fix some uses of `int' instead of EMACS_INT.
7811 * search.c (string_match_1, fast_string_match)
7812 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7813 (scan_buffer, find_next_newline_no_quit)
7814 (find_before_next_newline, search_command, Freplace_match)
7815 (Fmatch_data): Make some `int' variables be EMACS_INT.
7816
7817 * xdisp.c (display_count_lines): 3rd argument and return value now
7818 EMACS_INT. All callers changed.
7819 (pint2hrstr): Last argument is now EMACS_INT.
7820
7821 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7822 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7823 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7824 (decode_coding_utf_16, decode_coding_emacs_mule)
7825 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7826 (decode_coding_ccl, decode_coding_charset)
7827 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7828 (decode_coding_iso_2022, decode_coding_emacs_mule)
7829 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7830 <char_offset, last_offset>: Declare EMACS_INT.
7831 (encode_coding_utf_8, encode_coding_utf_16)
7832 (encode_coding_emacs_mule, encode_invocation_designation)
7833 (encode_designation_at_bol, encode_coding_iso_2022)
7834 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7835 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7836 Declare EMACS_INT.
7837 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7838 (encode_invocation_designation): Last argument P_NCHARS is now
7839 EMACS_INT.
7840 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7841 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7842
7843 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7844 All users changed.
7845
7846 * ccl.c (Fccl_execute_on_string): Declare some variables
7847 EMACS_INT.
7848
7849 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7850
7851 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7852
7853 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7854
7855 * process.c (Fformat_network_address): Doc fix.
7856
7857 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7858
7859 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7860
7861 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7862
7863 * keyboard.c (read_char): Call Lisp function help-form-show,
7864 instead of using internal_with_output_to_temp_buffer.
7865 (Qhelp_form_show): New var.
7866 (syms_of_keyboard): Use DEFSYM macro.
7867
7868 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7869
7870 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7871
7872 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7873
7874 * process.c (Flist_processes): Remove to Lisp.
7875 (list_processes_1): Delete.
7876
7877 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7878
7879 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7880
7881 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7882
7883 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7884
7885 Fix more problems found by GCC 4.6.0's static checks.
7886
7887 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7888
7889 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7890
7891 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7892
7893 * xdisp.c (vmessage): Mark as a printf-like function.
7894
7895 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7896
7897 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7898
7899 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7900 printf-like functions.
7901 (tiff_load): Add casts to remove these marks before passing them
7902 to system-supplied API.
7903
7904 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7905
7906 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7907 This avoids several warnings with gcc -Wstrict-overflow.
7908 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7909 directly, rather than having caller test rule sign. This avoids
7910 some unnecessary tests.
7911 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7912 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7913 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7914
7915 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7916 (xfont_open): Avoid unnecessary tests.
7917
7918 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7919
7920 * composite.h, composite.c (composition_gstring_put_cache):
7921 Use EMACS_INT, not int, for length.
7922
7923 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7924 breaking out part of COMPOSITION_DECODE_RULE.
7925 (COMPOSITION_DECODE_RULE): Use it.
7926 * composite.c (get_composition_id): Remove unused local vars,
7927 by using the new macro.
7928
7929 * textprop.c (set_text_properties_1): Change while to do-while,
7930 since the condition is always true at first.
7931
7932 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7933 (interval_deletion_adjustment): Return unsigned value.
7934 All uses changed.
7935
7936 * process.c (list_processes_1, create_pty, read_process_output):
7937 (exec_sentinel): Remove vars that were set but not used.
7938 (create_pty): Remove unnecessary "volatile"s.
7939 (Fnetwork_interface_info): Avoid possibility of int overflow.
7940 (read_process_output): Do adaptive read buffering even if carryover.
7941 (read_process_output): Simplify nbytes computation if buffered.
7942
7943 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7944
7945 * syntax.c (scan_words): Remove var that was set but not used.
7946 (update_syntax_table): Use unsigned instead of int.
7947
7948 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7949 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7950 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7951
7952 * print.c (print_error_message): Avoid int overflow.
7953
7954 * font.c (font_list_entities): Redo for clarity,
7955 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7956
7957 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7958 (font_score): Avoid potential overflow in diff calculation.
7959
7960 * fns.c (substring_both): Remove var that is set but not used.
7961 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7962
7963 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7964
7965 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7966 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7967 can always succeed if overflow has undefined behavior.
7968
7969 * search.c (boyer_moore, wordify): Remove vars set but not used.
7970 (wordify): Omit three unnecessary tests.
7971
7972 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7973 All callers changed. This avoids the need for an unused var.
7974
7975 * casefiddle.c (casify_region): Remove var that is set but not used.
7976
7977 * dired.c (file_name_completion): Remove var that is set but not used.
7978
7979 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7980
7981 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7982 (Finsert_file_contents): Remove unnecessary code checking fd.
7983
7984 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7985 Check for integer overflow on size calculations.
7986
7987 * buffer.c (Fprevious_overlay_change): Remove var that is set
7988 but not used.
7989
7990 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7991 Remove vars that are set but not used.
7992 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7993 (timer_check_2): Mark vars as initialized.
7994
7995 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7996
7997 * image.c (lookup_image): Remove var that is set but not used.
7998 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7999
8000 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8001 that are set but not used.
8002
8003 * xfns.c (make_invisible_cursor): Don't return garbage
8004 if XCreateBitmapFromData fails (Bug#8410).
8005
8006 * xselect.c (x_get_local_selection, x_handle_property_notify):
8007 Remove vars that are set but not used.
8008
8009 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8010 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8011
8012 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8013 Remove var that is set but not used.
8014 (scroll_bar_windows_size): Now size_t, not int.
8015 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8016 Check for overflow.
8017
8018 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8019 (map_tty_color) [!defined MSDOS]: Likewise.
8020
8021 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8022
8023 * coding.c: Remove vars that are set but not used.
8024 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8025 All callers changed.
8026 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8027 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8028 (decode_coding_charset): Remove vars that are set but not used.
8029
8030 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8031 that is set but not used.
8032
8033 * print.c (print_object): Remove var that is set but not used.
8034
8035 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8036 The gnulib version avoids calling malloc in the usual case,
8037 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8038 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8039 * filelock.c (current_lock_owner): Likewise.
8040 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8041 * sysdep.c: Include allocator.h, careadlinkat.h.
8042 (emacs_no_realloc_allocator): New static constant.
8043 (emacs_readlink): New function.
8044 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8045 ../lib/careadlinkat.h.
8046
8047 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8048
8049 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8050 first non-nil return value).
8051
8052 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8053
8054 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8055 if not defined (Bug#8403).
8056
8057 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8058
8059 * xdisp.c (display_count_lines): Remove parameter `start',
8060 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8061 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8062 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8063 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8064 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8065 and thereabouts. All callers changed.
8066 (get_per_char_metric): Remove parameter `f', unused since
8067 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8068
8069 2011-04-02 Jim Meyering <meyering@redhat.com>
8070
8071 do not dereference NULL upon failed strdup
8072 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8073 (ns_get_family): Likewise.
8074
8075 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8076
8077 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8078
8079 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8080
8081 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8082 later (Bug#8403).
8083
8084 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8085
8086 Add lexical binding.
8087
8088 * window.c (Ftemp_output_buffer_show): New fun.
8089 (Fsave_window_excursion):
8090 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8091
8092 * lread.c (lisp_file_lexically_bound_p): New function.
8093 (Fload): Bind Qlexical_binding.
8094 (readevalloop): Remove `evalfun' arg.
8095 Bind Qinternal_interpreter_environment.
8096 (Feval_buffer): Bind Qlexical_binding.
8097 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8098 Mark as dynamic.
8099 (syms_of_lread): Declare `lexical-binding'.
8100
8101 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8102
8103 * keyboard.c (eval_dyn): New fun.
8104 (menu_item_eval_property): Use it.
8105
8106 * image.c (parse_image_spec): Use Ffunctionp.
8107
8108 * fns.c (concat, mapcar1): Accept byte-code-functions.
8109
8110 * eval.c (Fsetq): Handle lexical vars.
8111 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8112 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8113 (FletX, Flet): Obey lexical binding.
8114 (Fcommandp): Handle closures.
8115 (Feval): New `lexical' arg.
8116 (eval_sub): New function extracted from Feval. Use it almost
8117 everywhere where Feval was used. Look up vars in lexical env.
8118 Handle closures.
8119 (Ffunctionp): Move from subr.el.
8120 (Ffuncall): Handle closures.
8121 (apply_lambda): Remove `eval_flags'.
8122 (funcall_lambda): Handle closures and new byte-code-functions.
8123 (Fspecial_variable_p): New function.
8124 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8125 but without exporting it to Lisp.
8126
8127 * doc.c (Fdocumentation, store_function_docstring):
8128 * data.c (Finteractive_form): Handle closures.
8129
8130 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8131 interactive spec.
8132
8133 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8134 New byte-codes.
8135 (exec_byte_code): New function extracted from Fbyte_code to handle new
8136 calling convention for byte-code-functions. Add new byte-codes.
8137
8138 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8139
8140 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8141
8142 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8143
8144 * xdisp.c (redisplay_internal): Fix prototype.
8145
8146 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8147
8148 * xdisp.c (SCROLL_LIMIT): New macro.
8149 (try_scrolling): Use it when setting scroll_limit.
8150 Limit scrolling to 100 screen lines.
8151 (redisplay_window): Even when falling back on "recentering",
8152 position point in the window according to scroll-conservatively,
8153 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8154
8155 (try_scrolling): When point is above the window, allow searching
8156 as far as scroll_max, or one screenful, to compute vertical
8157 distance from PT to the scroll margin position. This prevents
8158 try_scrolling from unnecessarily failing when
8159 scroll-conservatively is set to a value slightly larger than the
8160 window height. Clean up the case of PT below the margin at bottom
8161 of window: scroll_max can no longer be INT_MAX. When aggressive
8162 scrolling is in use, don't let point enter the opposite scroll
8163 margin as result of the scroll.
8164 (syms_of_xdisp) <scroll-conservatively>: Document the
8165 threshold of 100 lines for never-recentering scrolling.
8166
8167 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8168
8169 * dispextern.h (move_it_by_lines):
8170 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8171 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8172 (message_log_check_duplicate): Remove parameters `prev_bol' and
8173 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8174 (redisplay_internal): Remove parameter `preserve_echo_area',
8175 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8176
8177 * indent.c (Fvertical_motion):
8178 * window.c (window_scroll_pixel_based, Frecenter):
8179 Don't pass `need_y_p' to `move_it_by_lines'.
8180
8181 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8182
8183 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8184 steal a few bits to be more compact.
8185 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8186 Remove unneeded casts.
8187
8188 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8189
8190 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8191
8192 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8193 binding" message (bug#7967).
8194
8195 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8196
8197 Fix more problems found by GCC 4.6.0's static checks.
8198
8199 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8200 Remove unused local var.
8201
8202 * editfns.c (Fmessage_box): Remove unused local var.
8203
8204 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8205 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8206 Omit unused local vars.
8207 * window.c (shrink_windows): Omit unused local var.
8208 * menu.c (digest_single_submenu): Omit unused local var.
8209 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8210 Omit unused local var.
8211
8212 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8213 Don't assume string length fits in int.
8214 (keyremap_step, read_key_sequence): Use size_t for sizes.
8215 (read_key_sequence): Don't check last_real_key_start redundantly.
8216
8217 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8218 instead of alloca (Bug#8344).
8219
8220 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8221 (Fbacktrace_frame): Don't assume nframes fits in int.
8222
8223 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8224
8225 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8226 concerns.
8227
8228 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8229
8230 * cm.c (calccost): Turn while-do into do-while, for clarity.
8231
8232 * keyboard.c (syms_of_keyboard): Use the same style as later
8233 in this function when indexing through an array. This also
8234 works around GCC bug 48267.
8235
8236 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8237
8238 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8239
8240 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8241 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8242
8243 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8244 This avoids undefined behavior on integer overflow, and is a bit
8245 more convenient anyway since it is compared to a size_t variable.
8246
8247 Variadic C functions now count arguments with size_t, not int.
8248 This avoids an unnecessary limitation on 64-bit machines, which
8249 caused (substring ...) to crash on large vectors (Bug#8344).
8250 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8251 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8252 All variadic functions and their callers changed accordingly.
8253 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8254 * data.c (arith_driver, float_arith_driver): Likewise.
8255 * editfns.c (general_insert_function): Likewise.
8256 * eval.c (struct backtrace.nargs, interactive_p)
8257 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8258 (funcall_lambda, mark_backtrace): Likewise.
8259 * fns.c (concat): Likewise.
8260 * frame.c (x_set_frame_parameters): Likewise.
8261 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8262 0 if not found, not -1. All callers changed.
8263
8264 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8265 (stack_copy_size): Now size_t, not int.
8266 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8267
8268 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8269
8270 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8271 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8272 All callers changed.
8273
8274 * lisp.h (multibyte_char_to_unibyte):
8275 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8276 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8277 * character.h (CHAR_TO_BYTE8):
8278 * cmds.c (internal_self_insert):
8279 * editfns.c (general_insert_function):
8280 * keymap.c (push_key_description):
8281 * search.c (Freplace_match):
8282 * xdisp.c (message_dolog, set_message_1): All callers changed.
8283
8284 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8285
8286 * keyboard.c (safe_run_hook_funcall): New function.
8287 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8288 don't set the hook to nil, but remove the offending function instead.
8289 (Qcommand_hook_internal): Remove, unused.
8290 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8291 Vcommand_hook_internal.
8292
8293 * eval.c (enum run_hooks_condition): Remove.
8294 (funcall_nil, funcall_not): New functions.
8295 (run_hook_with_args): Call each function through a `funcall' argument.
8296 Remove `cond' argument, now redundant.
8297 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8298 (Frun_hook_with_args_until_failure): Adjust accordingly.
8299 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8300
8301 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8302
8303 * dispextern.h (string_buffer_position): Remove declaration.
8304
8305 * print.c (strout): Remove parameter `multibyte', unused since
8306 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8307
8308 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8309 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8310 All callers changed.
8311
8312 * w32.c (_wsa_errlist): Use braces for struct initializers.
8313
8314 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8315 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8316 All callers changed.
8317 (string_buffer_position): Likewise. Also, make static (it's never
8318 used outside xdisp.c).
8319 (cursor_row_p): Remove parameter `w', unused since
8320 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8321 (decode_mode_spec): Remove parameter `precision', introduced during
8322 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8323 All callers changed.
8324
8325 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8326
8327 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8328
8329 2011-03-27 Anders Lindgren <andlind@gmail.com>
8330
8331 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8332 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8333 (ns_update_auto_hide_menu_bar): New functions.
8334 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8335 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8336 ns_constrain_all_frames.
8337 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8338 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8339
8340 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8341
8342 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8343
8344 2011-03-27 Glenn Morris <rgm@gnu.org>
8345
8346 * syssignal.h: Replace RETSIGTYPE with void.
8347 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8348 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8349 Replace SIGTYPE with void everywhere.
8350 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8351 * s/template.h (SIGTYPE): Remove commented out definition.
8352
8353 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8354
8355 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8356 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8357
8358 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8359
8360 * w32.c (read_unc_volume): Use parameter `henum', instead of
8361 global variable `wget_enum_handle'.
8362
8363 * keymap.c (describe_vector): Remove parameters `indices' and
8364 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8365 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8366
8367 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8368
8369 * keyboard.c (timer_check): Remove parameter `do_it_now',
8370 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8371 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8372 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8373
8374 * keyboard.c (read_char):
8375 * w32menu.c (w32_menu_display_help):
8376 * xmenu.c (show_help_event, menu_help_callback):
8377 Adjust calls to `show_help_echo'.
8378
8379 * gtkutil.c (xg_maybe_add_timer):
8380 * keyboard.c (readable_events):
8381 * process.c (wait_reading_process_output):
8382 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8383
8384 * insdel.c (adjust_markers_gap_motion):
8385 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8386 (gap_left, gap_right): Don't call it.
8387
8388 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8389
8390 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8391 incurred during fontification.
8392
8393 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8394
8395 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8396 (DEFVAR_PER_BUFFER): Don't pass it.
8397
8398 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8399 (scrolling_window): Don't pass it.
8400
8401 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8402
8403 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8404
8405 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8406 and `suffix'.
8407 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8408 of variables specific to SELinux and computation of `encoded_absname'.
8409
8410 * image.c (XPutPixel): Remove unused variable `height'.
8411
8412 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8413
8414 * unexw32.c (get_section_info): Remove unused variable `section'.
8415
8416 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8417 (system_process_attributes): Remove unused variable `sess'.
8418 (sys_read): Remove unused variable `err'.
8419
8420 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8421 (w32_wnd_proc): Remove unused variable `isdead'.
8422 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8423 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8424 (x_create_tip_frame): Remove unused variable `tem'.
8425
8426 * w32inevt.c (w32_console_read_socket):
8427 Remove unused variable `no_events'.
8428
8429 * w32term.c (x_draw_composite_glyph_string_foreground):
8430 Remove unused variable `width'.
8431
8432 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8433
8434 * w32term.c (x_set_glyph_string_clipping):
8435 Don't pass uninitialized region to CombineRgn.
8436
8437 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8438
8439 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8440 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8441 (Fx_close_connection): Remove unused variable `i'.
8442
8443 * w32font.c (w32font_draw): Return number of glyphs.
8444 (w32font_open_internal): Remove unused variable `i'.
8445 (w32font_driver): Add missing initializer.
8446
8447 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8448 (fill_in_menu): Remove unused variable `items_added'.
8449
8450 * w32term.c (last_mouse_press_frame): Remove static global variable.
8451 (w32_clip_to_row): Remove unused variable `f'.
8452 (x_delete_terminal): Remove unused variable `i'.
8453
8454 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8455 (NOTHING): Remove unused static global variable.
8456 (uniscribe_check_otf): Remove unused variable `table'.
8457 (uniscribe_font_driver): Add missing initializers.
8458
8459 2011-03-23 Julien Danjou <julien@danjou.info>
8460
8461 * term.c (Fsuspend_tty, Fresume_tty):
8462 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8463 * window.c (temp_output_buffer_show):
8464 * insdel.c (signal_before_change):
8465 * frame.c (Fhandle_switch_frame):
8466 * fileio.c (Fdo_auto_save):
8467 * emacs.c (Fkill_emacs):
8468 * editfns.c (save_excursion_restore):
8469 * cmds.c (internal_self_insert):
8470 * callint.c (Fcall_interactively):
8471 * buffer.c (Fkill_all_local_variables):
8472 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8473 Use Frun_hooks.
8474 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8475 unconditionally since it does the check itself.
8476
8477 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8478
8479 Fix more problems found by GCC 4.5.2's static checks.
8480
8481 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8482 the first time through the loop, since we know p0 < p1 then.
8483 This also avoids a gcc -Wstrict-overflow warning.
8484
8485 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8486 leading to a memory leak, possible in functions like
8487 load_charset_map_from_file that can allocate an unbounded number
8488 of objects (Bug#8318).
8489
8490 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8491 that could (at least in theory) be that large.
8492
8493 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8494 This is less likely to overflow, and avoids undefined behavior if
8495 overflow does occur. All callers changed. Use strtoul to scan
8496 for the unsigned long integer.
8497 (pint2hrstr): Simplify and tune code slightly.
8498 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8499
8500 * scroll.c (do_scrolling): Work around GCC bug 48228.
8501 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8502
8503 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8504 This also avoids a warning with gcc -Wstrict-overflow.
8505 (validate_x_resource_name): Simplify count usage.
8506 This also avoids a warning with gcc -Wstrict-overflow.
8507
8508 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8509 fail (Bug#8306).
8510
8511 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8512
8513 * process.c (Fmake_network_process): Use socklen_t, not int,
8514 where POSIX says socklen_t is required in portable programs.
8515 This fixes a porting bug on hosts like 64-bit HP-UX, where
8516 socklen_t is wider than int (Bug#8277).
8517 (Fmake_network_process, server_accept_connection):
8518 (wait_reading_process_output, read_process_output):
8519 Likewise.
8520
8521 * process.c: Rename or move locals to avoid shadowing.
8522 (list_processes_1, Fmake_network_process):
8523 (read_process_output_error_handler, exec_sentinel_error_handler):
8524 Rename or move locals.
8525 (Fmake_network_process): Define label "retry_connect" only if needed.
8526 (Fnetwork_interface_info): Fix pointer signedness.
8527 (process_send_signal): Add cast to avoid pointer signedness problem.
8528 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8529 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8530
8531 Make tparam.h and terminfo.c consistent.
8532 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8533 Include tparam.h instead, since it declares them.
8534 * cm.h (PC): Remove extern decl; tparam.h now does this.
8535 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8536 * terminfo.c: Include tparam.h, to check interfaces.
8537 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8538 (tparam): Adjust signature to match interface in tparam.h;
8539 this removes some undefined behavior. Check that outstring and len
8540 are zero, which they always are with Emacs.
8541 * tparam.h (PC, BC, UP): New extern decls.
8542
8543 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8544 (xftfont_open): Rename locals to avoid shadowing.
8545
8546 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8547 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8548 (OTF_TAG_SYM): Omit macro if not needed.
8549 (ftfont_list): Remove unused local.
8550 (get_adstyle_property, ftfont_pattern_entity):
8551 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8552 Rename locals to avoid shadowing.
8553
8554 * xfont.c (xfont_list_family): Mark var as initialized.
8555
8556 * xml.c (make_dom): Now static.
8557
8558 * composite.c (composition_compute_stop_pos): Rename local to
8559 avoid shadowing.
8560 (composition_reseat_it): Remove unused locals.
8561 (find_automatic_composition, composition_adjust_point): Likewise.
8562 (composition_update_it): Mark var as initialized.
8563 (find_automatic_composition): Mark vars as initialized,
8564 with a FIXME (Bug#8290).
8565
8566 character.h: Rename locals to avoid shadowing.
8567 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8568 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8569 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8570 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8571 to avoid shadowing.
8572
8573 * textprop.c (property_change_between_p): Remove; unused.
8574
8575 * intervals.c (interval_start_pos): Now static.
8576
8577 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8578
8579 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8580 Rename locals to avoid shadowing.
8581
8582 * sound.c (wav_play, au_play, Fplay_sound_internal):
8583 Fix pointer signedness.
8584 (alsa_choose_format): Remove unused local var.
8585 (wav_play): Initialize a variable to 0, to prevent undefined
8586 behavior (Bug#8278).
8587
8588 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8589
8590 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8591
8592 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8593 clobbering (Bug#8298).
8594 * sysdep.c (sys_subshell): Likewise.
8595 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8596
8597 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8598 This should get cleaned up, so that child_setup has the
8599 same signature on all platforms.
8600
8601 * callproc.c (call_process_cleanup): Now static.
8602 (relocate_fd): Rename locals to avoid shadowing.
8603
8604 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8605
8606 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8607 not to be necessary, and produces flickering.
8608
8609 2011-03-20 Glenn Morris <rgm@gnu.org>
8610
8611 * config.in: Remove file.
8612
8613 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8614
8615 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8616 are now in src/globals.h.
8617 (syms_of_minibuf): Remove spurious & from previous change.
8618
8619 2011-03-20 Leo Liu <sdl.web@gmail.com>
8620
8621 * minibuf.c (completing-read-function): New variable.
8622 (completing-read-default): Rename from completing-read.
8623 (completing-read): Call completing-read-function.
8624
8625 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8626
8627 * xfaces.c (Fx_load_color_file):
8628 Read color file from absolute filename (bug#8250).
8629
8630 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8631
8632 * makefile.w32-in: Update dependencies.
8633
8634 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8635
8636 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8637
8638 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8639
8640 Fix more problems found by GCC 4.5.2's static checks.
8641
8642 * process.c (make_serial_process_unwind, send_process_trap):
8643 (sigchld_handler): Now static.
8644
8645 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8646 That way, the code declares only the vars that it needs.
8647 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8648 * s/cygwin.h (PTY_ITERATION): Likewise.
8649 * s/darwin.h (PTY_ITERATION): Likewise.
8650 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8651
8652 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8653 * process.c (allocate_pty): Don't declare stb unless it's needed.
8654
8655 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8656 (CONSTANTLIM): Remove; unused.
8657 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8658 Define only if needed.
8659
8660 * unexelf.c (unexec): Name an expression,
8661 to avoid gcc -Wbad-function-cast warning.
8662 Use a different way to cause a compilation error if anyone uses
8663 n rather than nn, a way that does not involve shadowing.
8664 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8665
8666 * deps.mk (unexalpha.o): Remove; unused.
8667
8668 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8669 * unexec.h: New file.
8670 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8671 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8672 Depend on unexec.h.
8673 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8674 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8675 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8676 Change as necessary to match prototype in unexec.h.
8677
8678 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8679 shadowing.
8680 (back_comment, skip_chars): Mark vars as initialized.
8681
8682 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8683 Rename locals to avoid shadowing.
8684
8685 * lread.c (read1): Rewrite so as not to use empty "else".
8686 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8687
8688 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8689
8690 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8691 warning when compiling print.c.
8692
8693 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8694 instead of using an uninitialized var.
8695 (font_sort_entities): Mark var as initialized.
8696
8697 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8698
8699 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8700 pointers to constants.
8701 (font_parse_fcname): Remove unused vars.
8702 (font_delete_unmatched): Now static.
8703 (font_get_spec): Remove; unused.
8704 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8705 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8706 Rename or move locals to avoid shadowing.
8707
8708 * fns.c (require_nesting_list, require_unwind): Now static.
8709 (Ffillarray): Rename locals to avoid shadowing.
8710
8711 * floatfns.c (domain_error2): Define only if needed.
8712 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8713
8714 * alloc.c (mark_backtrace): Move decl from here ...
8715 * lisp.h: ... to here, so that it can be checked.
8716
8717 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8718 (Fdefvar): Rewrite so as not to use empty "else".
8719 (lisp_indirect_variable): Name an expression,
8720 to avoid gcc -Wbad-function-cast warning.
8721 (Fdefvar): Rename locals to avoid shadowing.
8722
8723 * callint.c (quotify_arg, quotify_args): Now static.
8724 (Fcall_interactively): Rename locals to avoid shadowing.
8725 Use const pointer when appropriate.
8726
8727 * lisp.h (get_system_name, get_operating_system_release):
8728 Move decls here, to check interfaces.
8729 * process.c (get_operating_system_release): Move decl to lisp.h.
8730 * xrdb.c (get_system_name): Likewise.
8731 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8732 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8733 some of which prompt warnings from gcc -Wbad-function-cast.
8734 (Fformat_time_string, Fencode_time, Finsert_char):
8735 (Ftranslate_region_internal, Fformat):
8736 Rename or remove local vars to avoid shadowing.
8737 (Ftranslate_region_internal): Mark var as initialized.
8738
8739 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8740 avoid shadowing.
8741
8742 * lisp.h (eassert): Check that the argument compiles, even if
8743 ENABLE_CHECKING is not defined.
8744
8745 * data.c (Findirect_variable): Name an expression, to avoid
8746 gcc -Wbad-function-cast warning.
8747 (default_value, arithcompare, arith_driver, arith_error): Now static.
8748 (store_symval_forwarding): Rename local to avoid shadowing.
8749 (Fmake_variable_buffer_local, Fmake_local_variable):
8750 Mark variables as initialized.
8751 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8752
8753 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8754 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8755 Rename locals to avoid shadowing.
8756 (mark_stack): Move local variables into the #ifdef region where
8757 they're used.
8758 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8759 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8760 needed otherwise.
8761 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8762 (GC_STRING_CHARS): Remove; not used.
8763 (Fmemory_limit): Cast sbrk's returned value to char *.
8764
8765 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8766 avoids undefined behavior in theory.
8767
8768 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8769
8770 Use functions, not macros, for up- and down-casing (Bug#8254).
8771 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8772 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8773 to use the following functions instead of these macros.
8774 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8775 EMACS_INT, since callers assume the returned value fits in int.
8776 (upcase1): Likewise, for UPCASE_TABLE.
8777 (uppercasep, lowercasep, upcase): New static inline functions.
8778 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8779 the race-condition problem in the old DOWNCASE.
8780
8781 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8782 Rename locals to avoid shadowing.
8783 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8784 (regex_compile, re_search_2, re_match_2_internal):
8785 Remove unused local vars.
8786 (FREE_VAR): Rewrite so as not to use empty "else",
8787 which gcc can warn about.
8788 (regex_compile, re_match_2_internal): Mark locals as initialized.
8789 (RETALLOC_IF): Define only if needed.
8790 (WORDCHAR_P): Likewise. This one is never needed, but is used
8791 only in a comment talking about a compiler bug, so put inside
8792 the #if 0 of that comment.
8793 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8794 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8795 Remove; unused.
8796
8797 * search.c (boyer_moore): Rename locals to avoid shadowing.
8798 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8799 (PREV_CHAR_BOUNDARY): Likewise.
8800
8801 * search.c (simple_search): Remove unused var.
8802
8803 * dired.c (compile_pattern): Move decl from here ...
8804 * lisp.h: ... to here, so that it can be checked.
8805 (struct re_registers): New forward decl.
8806
8807 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8808
8809 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8810 All uses changed.
8811 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8812 Rename locals to avoid shadowing.
8813 (Fvertical_motion): Mark locals as initialized.
8814
8815 * casefiddle.c (casify_object, casify_region): Now static.
8816 (casify_region): Mark local as initialized.
8817
8818 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8819
8820 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8821 New macros, so that the caller can use some names other than
8822 gcpro1, gcpro2, etc.
8823 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8824 of the new macros.
8825 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8826 argument, for consistency with GCPRO2_VAR, etc: it is now the
8827 prefix of the variable, not the variable itself. All uses
8828 changed.
8829 * dired.c (directory_files_internal, file_name_completion):
8830 Rename locals to avoid shadowing.
8831
8832 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8833 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8834 dired.c's scmp function, had undefined behavior.
8835 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8836 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8837 * buffer.h: ... to here, because these macros use current_buffer,
8838 and the new implementation with inline functions needs to have
8839 current_buffer in scope now, rather than later when the macros
8840 are used.
8841 (downcase, upcase1): New static inline functions.
8842 (DOWNCASE, UPCASE1): Reimplement using these functions.
8843 This avoids undefined behavior in expressions like
8844 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8845 from race conditions in accessing the global variables
8846 case_temp1 and case_temp2.
8847 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8848 * lisp.h (case_temp1, case_temp2): Remove their decls.
8849 * character.h (ASCII_CHAR_P): Move from here ...
8850 * lisp.h: ... to here, so that the inline functions mentioned
8851 above can use them.
8852
8853 * dired.c (directory_files_internal_unwind): Now static.
8854
8855 * fileio.c (file_name_as_directory, directory_file_name):
8856 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8857 Now static.
8858 (file_name_as_directory): Use const pointers when appropriate.
8859 (Fexpand_file_name): Likewise. In particular, newdir might
8860 point at constant storage, so make it a const pointer.
8861 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8862 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8863 signedness issues.
8864 (Fset_file_times, Finsert_file_contents, auto_save_error):
8865 Rename locals to avoid shadowing.
8866
8867 * minibuf.c (choose_minibuf_frame_1): Now static.
8868 (Ftry_completion, Fall_completions): Rename or remove locals
8869 to avoid shadowing.
8870
8871 * marker.c (bytepos_to_charpos): Remove; unused.
8872
8873 * lisp.h (verify_bytepos, count_markers): New decls,
8874 so that gcc does not warn that these functions aren't declared.
8875
8876 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8877 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8878 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8879 (copy_text): Remove unused local var.
8880
8881 * filelock.c (within_one_second): Now static.
8882 (lock_file_1): Rename local to avoid shadowing.
8883
8884 * buffer.c (fix_overlays_before): Mark locals as initialized.
8885 (fix_start_end_in_overlays): Likewise. This function should be
8886 simplified by using pointers-to-pointers, but that's a different
8887 matter.
8888 (switch_to_buffer_1): Now static.
8889 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8890 (report_overlay_modification): Rename locals to avoid shadowing.
8891
8892 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8893 Fix pointer signedness issue.
8894 (sys_subshell): Mark local as volatile if checking for lint,
8895 to suppress a gcc -Wclobbered warning that does not seem to be right.
8896 (MAXPATHLEN): Define only if needed.
8897
8898 * process.c (serial_open, serial_configure): Move decls from here ...
8899 * systty.h: ... to here, so that they can be checked.
8900
8901 * fns.c (get_random, seed_random): Move extern decls from here ...
8902 * lisp.h: ... to here, so that they can be checked.
8903
8904 * sysdep.c (reset_io): Now static.
8905 (wait_for_termination_signal): Remove; unused.
8906
8907 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8908 (copy_keymap_item, append_key, push_text_char_description):
8909 Now static.
8910 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8911 (DENSE_TABLE_SIZE): Remove; unused.
8912 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8913 (describe_map_tree):
8914 Rename locals to avoid shadowing.
8915
8916 * keyboard.c: Declare functions static if they are not used elsewhere.
8917 (echo_char, echo_dash, cmd_error, top_level_2):
8918 (poll_for_input, handle_async_input): Now static.
8919 (read_char, kbd_buffer_get_event, make_lispy_position):
8920 (make_lispy_event, make_lispy_movement, apply_modifiers):
8921 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8922 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8923 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8924 (read_key_sequence, read_char): Mark locals as initialized.
8925 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8926
8927 * keyboard.h (make_ctrl_char): New decl.
8928 (mark_kboards): Move decl here ...
8929 * alloc.c (mark_kboards): ... from here.
8930
8931 * lisp.h (force_auto_save_soon): New decl.
8932
8933 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8934 (DEFINE_DUMMY_FUNCTION): New macro.
8935 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8936 Use it.
8937 (main): Add casts to avoid warnings
8938 if GCC considers string literals to be constants.
8939
8940 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8941
8942 * dbusbind.c: Pointer signedness fixes.
8943 (xd_signature, xd_append_arg, xd_initialize):
8944 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8945 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8946 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8947 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8948
8949 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8950 if GCC considers string literals to be constants.
8951 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8952
8953 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8954
8955 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8956 (print_preprocess, print_object): New macro to fix last change.
8957
8958 * print.c (print_preprocess): Don't forget font objects.
8959
8960 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8961
8962 * emacs.c (USAGE3): Doc fixes.
8963
8964 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8965
8966 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8967 structure.
8968
8969 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8970
8971 * lisp.h (VWindow_system, Qfile_name_history):
8972 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8973 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8974 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8975
8976 * w32select.c: Don't #include "keyboard.h".
8977 (run_protected): Add extern declaration for waiting_for_input.
8978
8979 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8980 * w32console.c (detect_input_pending, read_input_pending)
8981 (encode_terminal_code):
8982 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8983 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8984 (w32_system_caret_y, Qfile_name_history):
8985 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8986 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8987 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8988 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8989 * w32proc.c (Qlocal, report_file_error):
8990 * w32term.c (Vwindow_system, updating_frame):
8991 * w32uniscribe.c (initialized, uniscribe_font_driver):
8992 Remove unneeded extern declarations.
8993
8994 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8995
8996 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8997
8998 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8999
9000 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9001 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9002 These macros can no longer be used for assignment.
9003
9004 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9005 Assign struct members directly, instead of using BUF_BEGV etc.
9006 (record_buffer_markers, fetch_buffer_markers): New functions for
9007 recording and fetching special buffer markers.
9008 (set_buffer_internal_1, set_buffer_temp): Use them.
9009
9010 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9011
9012 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9013
9014 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9015 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9016
9017 * xdisp.c (hscroll_window_tree):
9018 (reconsider_clip_changes): Use PT instead of BUF_PT.
9019
9020 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9021
9022 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9023 $(EMACS_ROOT)/lib/intprops.h.
9024
9025 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9026
9027 Fix more problems found by GCC 4.5.2's static checks.
9028
9029 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9030 to unsigned char * to avoid compiler diagnostic.
9031 (xg_free_frame_widgets): Make it clear that a local variable is
9032 needed only if USE_GTK_TOOLTIP.
9033 (gdk_window_get_screen): Make it clear that this macro is needed
9034 only if USE_GTK_TOOLTIP.
9035 (int_gtk_range_get_value): New function, which avoids a diagnostic
9036 from gcc -Wbad-function-cast.
9037 (xg_set_toolkit_scroll_bar_thumb): Use it.
9038 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9039 diagnostic from gcc -Wbad-function-cast.
9040 (get_utf8_string, xg_get_file_with_chooser):
9041 Rename locals to avoid shadowing.
9042 (create_dialog): Move locals to avoid shadowing.
9043
9044 * xgselect.c (xg_select): Remove unused var.
9045
9046 * image.c (four_corners_best): Mark locals as initialized.
9047 (gif_load): Initialize transparent_p to zero (Bug#8238).
9048 Mark another local as initialized.
9049 (my_png_error, my_error_exit): Mark with NO_RETURN.
9050
9051 * image.c (clear_image_cache): Now static.
9052 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9053 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9054 (x_edge_detection): Remove unnecessary cast that
9055 gcc -Wbad-function-cast diagnoses.
9056 (gif_load): Fix pointer signedness.
9057 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9058 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9059
9060 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9061
9062 Improve quality of tests for time stamp overflow.
9063 For example, without this patch (encode-time 0 0 0 1 1
9064 1152921504606846976) returns the obviously-bogus value (-948597
9065 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9066 reports time overflow. See
9067 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9068 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9069 * editfns.c: Include limits.h and intprops.h.
9070 (TIME_T_MIN, TIME_T_MAX): New macros.
9071 (time_overflow): Move earlier, to before first use.
9072 (hi_time, lo_time): New functions, for an accurate test for
9073 out-of-range times.
9074 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9075 (Fget_internal_run_time): Don't assume time_t fits in int.
9076 (make_time): Use list2 instead of Fcons twice.
9077 (Fdecode_time): More accurate test for out-of-range times.
9078 (check_tm_member): New function.
9079 (Fencode_time): Use it, to test for out-of-range times.
9080 (lisp_time_argument): Don't rely on undefined left-shift and
9081 right-shift behavior when checking for time stamp overflow.
9082
9083 * editfns.c (time_overflow): New function, refactoring common code.
9084 (Fformat_time_string, Fdecode_time, Fencode_time):
9085 (Fcurrent_time_string): Use it.
9086
9087 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9088 * dired.c (make_time): Move to ...
9089 * editfns.c (make_time): ... here.
9090 * systime.h: Note the move.
9091
9092 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9093
9094 * fringe.c (update_window_fringes): Remove unused variables.
9095
9096 * unexmacosx.c (copy_data_segment): Also copy __got section.
9097 (Bug#8223)
9098
9099 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9100
9101 * termcap.c [MSDOS]: Include "msdos.h".
9102 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9103 Constify `char *' arguments and their references according to
9104 prototypes in tparam.h.
9105
9106 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9107
9108 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9109 Adapt all references accordingly.
9110
9111 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9112
9113 2011-03-11 Tom Tromey <tromey@redhat.com>
9114
9115 * buffer.c (syms_of_buffer): Remove obsolete comment.
9116
9117 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9118
9119 * termhooks.h (encode_terminal_code): Declare prototype.
9120
9121 * msdos.c (encode_terminal_code): Don't declare prototype.
9122
9123 * term.c (encode_terminal_code): Now external again, used by
9124 w32console.c and msdos.c.
9125
9126 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9127 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9128
9129 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9130
9131 Fix some minor problems found by GCC 4.5.2's static checks.
9132
9133 * fringe.c (update_window_fringes): Mark locals as initialized
9134 (Bug#8227).
9135 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9136
9137 * alloc.c (mark_fringe_data): Move decl from here ...
9138 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9139 to check its interface.
9140 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9141
9142 * fontset.c (free_realized_fontset): Now static.
9143 (Fset_fontset_font): Rename local to avoid shadowing.
9144 (fontset_font): Mark local as initialized.
9145 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9146
9147 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9148
9149 * xselect.c (x_disown_buffer_selections): Remove; not used.
9150 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9151 (x_own_selection, Fx_disown_selection_internal): Rename locals
9152 to avoid shadowing.
9153 (x_handle_dnd_message): Remove local to avoid shadowing.
9154
9155 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9156 so that the caller can use some name other than gcpro1.
9157 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9158 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9159 (Fx_backspace_delete_keys_p):
9160 Use them to avoid shadowing, and rename vars to avoid shadowing.
9161 (x_decode_color, x_set_name, x_window): Now static.
9162 (Fx_create_frame): Add braces to silence GCC warning.
9163 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9164 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9165 Remove unused locals.
9166 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9167 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9168 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9169 macros.
9170
9171 * xterm.h (x_mouse_leave): New decl.
9172
9173 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9174 Remove unused functions.
9175 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9176 (x_calc_absolute_position): Now static.
9177 (XTread_socket): Don't define label "out" unless it's used.
9178 Don't declare local "event" unless it's used.
9179 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9180 unless they are used.
9181 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9182 (x_fatal_error_signal): Remove; not used.
9183 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9184 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9185 (x_error_catcher, x_connection_closed, x_error_handler):
9186 (x_error_quitter, xembed_send_message, x_iconify_frame):
9187 (my_log_handler): Rename locals to avoid shadowing.
9188 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9189 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9190
9191 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9192 Rename or move locals to avoid shadowing.
9193 (tty_defined_color, merge_face_heights): Now static.
9194 (free_realized_faces_for_fontset): Remove; not used.
9195 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9196 does not deduce is never used uninitialized.
9197 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9198 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9199
9200 * terminal.c (store_terminal_param): Now static.
9201
9202 * xmenu.c (menu_highlight_callback): Now static.
9203 (set_frame_menubar): Remove unused local.
9204 (xmenu_show): Rename parameter to avoid shadowing.
9205 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9206 since they might point to immutable storage.
9207 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9208 since it's unused otherwise.
9209
9210 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9211 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9212 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9213 avoids a gcc -Wuninitialized diagnostic.
9214 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9215 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9216 does not deduce are never used uninitialized.
9217
9218 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9219
9220 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9221 * window.c (window_loop, size_window):
9222 (run_window_configuration_change_hook, enlarge_window): Likewise.
9223
9224 * window.c (display_buffer): Now static.
9225 (size_window): Mark variables that gcc -Wuninitialized
9226 does not deduce are never used uninitialized.
9227 * window.h (check_all_windows): New decl, to forestall
9228 gcc -Wmissing-prototypes diagnostic.
9229 * dispextern.h (bidi_dump_cached_states): Likewise.
9230
9231 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9232 shadowing.
9233 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9234 Include <limits.h>.
9235 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9236 and to avoid gcc -Wuninitialized warning.
9237 (load_charset_map): Mark variables that gcc -Wuninitialized
9238 does not deduce are never used uninitialized.
9239 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9240
9241 * coding.c (coding_set_source, coding_set_destination):
9242 Use "else { /* comment */ }" rather than "else /* comment */;"
9243 for clarity, and to avoid gcc -Wempty-body warning.
9244 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9245 a block, when the outer 'i' will do.
9246 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9247 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9248 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9249 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9250 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9251 Rename locals to avoid shadowing.
9252 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9253 * coding.c (emacs_mule_char, encode_invocation_designation):
9254 Now static, since they're not used elsewhere.
9255 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9256 (decode_coding_object, encode_coding_object, detect_coding_system):
9257 (decode_coding_emacs_mule): Mark variables that gcc
9258 -Wuninitialized does not deduce are never used uninitialized.
9259 (detect_coding_iso_2022): Initialize a local variable that might
9260 be used uninitialized. Leave a FIXME because it's not clear that
9261 this initialization is needed. (Bug#8211)
9262 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9263 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9264 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9265 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9266 Remove unused macros.
9267
9268 * category.c (hash_get_category_set): Remove unused local var.
9269 (copy_category_table): Now static, since it's not used elsewhere.
9270 * character.c (string_count_byte8): Likewise.
9271
9272 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9273 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9274
9275 * chartab.c (copy_sub_char_table): Now static, since it's not used
9276 elsewhere.
9277 (sub_char_table_ref_and_range, char_table_ref_and_range):
9278 Rename locals to avoid shadowing.
9279 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9280
9281 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9282 (BIDI_BOB): Remove unused macro.
9283
9284 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9285 deduce are never used uninitialized.
9286 * term.c (encode_terminal_code): Likewise.
9287
9288 * term.c (encode_terminal_code): Now static. Remove unused local.
9289
9290 * tparam.h: New file.
9291 * term.c, tparam.h: Include it.
9292 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9293 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9294 Move these decls to tparam.h, and make them agree with what
9295 is actually in tparam.c. The previous trick of using incompatible
9296 decls in different modules does not conform to the C standard.
9297 All callers of tparam changed to use tparam's actual API.
9298 * tparam.c (tparam1, tparam, tgoto):
9299 Use const pointers where appropriate.
9300
9301 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9302 * cm.h (struct cm): Likewise.
9303 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9304 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9305 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9306 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9307 (turn_on_face, init_tty): Likewise.
9308 * termchar.h (struct tty_display_info): Likewise.
9309
9310 * term.c (term_mouse_position): Rename local to avoid shadowing.
9311
9312 * alloc.c (mark_ttys): Move decl from here ...
9313 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9314
9315 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9316
9317 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9318
9319 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9320
9321 * search.c (compile_pattern_1): Remove argument regp, unused since
9322 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9323 (compile_pattern): Don't pass it.
9324
9325 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9326
9327 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9328 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9329 for ! HAVE_GTK3.
9330 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9331
9332 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9333
9334 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9335 gdk_window_get_screen, gdk_window_get_geometry,
9336 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9337 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9338 (xg_get_pixbuf_from_pixmap): New function.
9339 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9340 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9341 Call xg_get_pixbuf_from_pixmap instead of
9342 gdk_pixbuf_get_from_drawable.
9343 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9344 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9345 (xg_check_special_colors): Use GtkStyleContext and its functions
9346 for HAVE_GTK3.
9347 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9348 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9349 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9350 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9351 Call gtk_widget_get_preferred_size.
9352 (xg_frame_resized): gdk_window_get_geometry only takes 5
9353 parameters.
9354 (xg_win_to_widget, xg_event_is_for_menubar):
9355 Call gdk_x11_window_lookup_for_display.
9356 (xg_set_widget_bg): New function.
9357 (delete_cb): New function.
9358 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9359 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9360 (xg_set_background_color): Call xg_set_widget_bg.
9361 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9362 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9363 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9364 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9365 if ! HAVE_GTK3.
9366 (update_frame_tool_bar): Call gtk_widget_hide.
9367 (xg_initialize): Use GDK_KEY_g.
9368
9369 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9370 if ! HAVE_GTK3
9371 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9372
9373 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9374 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9375 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9376
9377 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9378
9379 * w32xfns.c (select_palette): Check success of RealizePalette against
9380 GDI_ERROR, not zero.
9381
9382 See ChangeLog.11 for earlier changes.
9383
9384 ;; Local Variables:
9385 ;; coding: utf-8
9386 ;; End:
9387
9388 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9389
9390 This file is part of GNU Emacs.
9391
9392 GNU Emacs is free software: you can redistribute it and/or modify
9393 it under the terms of the GNU General Public License as published by
9394 the Free Software Foundation, either version 3 of the License, or
9395 (at your option) any later version.
9396
9397 GNU Emacs is distributed in the hope that it will be useful,
9398 but WITHOUT ANY WARRANTY; without even the implied warranty of
9399 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9400 GNU General Public License for more details.
9401
9402 You should have received a copy of the GNU General Public License
9403 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.