1 2011-10-30 Jan Djärv <jan.h.d@swipnet.se>
3 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
8 * xterm.c: Declare x_handle_net_wm_state to return int.
9 (handle_one_xevent): Check if we are iconified but don't have
10 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
11 (get_current_wm_state): Return non-zero if not hidden,
12 check for _NET_WM_STATE_HIDDEN (Bug#9893).
13 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
14 (x_handle_net_wm_state): Return what get_current_wm_state returns.
15 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
17 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
19 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
20 so that this new function doesn't get optimized away by a
21 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
23 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
25 * frame.h (MOUSE_HL_INFO): Remove excess parens.
27 2011-10-29 Eli Zaretskii <eliz@gnu.org>
29 Fix the `xbytecode' command.
30 * .gdbinit (xprintbytestr): New command.
31 (xwhichsymbols): Renamed from `which'; all callers changed.
32 (xbytecode): Print the byte-code string as well.
34 2011-10-29 Kim Storm <storm@cua.dk>
36 * alloc.c (which_symbols): New function.
38 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
40 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
43 2011-10-29 Glenn Morris <rgm@gnu.org>
45 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
46 Not clear what it was for, and it causes various bugs. (Bug#9839)
48 2011-10-28 Eli Zaretskii <eliz@gnu.org>
50 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
51 possible random value that matches one of those tested as
52 condition to clear the mouse face.
54 2011-10-28 Chong Yidong <cyd@gnu.org>
56 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
58 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
60 * window.c (make_window): Initialize phys_cursor_on_p.
62 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
64 * lisp.h (struct Lisp_Symbol): Update comments.
66 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
68 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
70 2011-10-28 Eli Zaretskii <eliz@gnu.org>
72 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
73 <oslsachem@gmail.com> for helping to debug this.
75 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
76 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
77 (g_b_init_get_glyph_outline_w): New static variables.
78 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
79 (GetGlyphOutlineW_Proc): New typedefs.
80 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
81 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
83 (w32font_open_internal, compute_metrics):
84 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
85 instead of calling the "wide" APIs directly.
87 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
89 * w32.h (syms_of_w32font): Add prototype.
91 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
93 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
94 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
95 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
96 (Fmove_to_window_line): Doc fix.
98 2011-10-27 Chong Yidong <cyd@gnu.org>
100 * process.c (make_process): Set gnutls_state to NULL.
102 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
103 non-NULL, regardless of GNUTLS_INITSTAGE.
104 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
105 an error. Set process slots as soon as we allocate them.
107 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
109 2011-10-27 Chong Yidong <cyd@gnu.org>
111 * gnutls.c (emacs_gnutls_deinit): New function.
112 Deallocate credentials structures as well as calling gnutls_deinit.
113 (Fgnutls_deinit, Fgnutls_boot): Use it.
115 * process.c (make_process): Initialize GnuTLS credentials to NULL.
116 (deactivate_process): Call emacs_gnutls_deinit.
118 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
120 * image.c (x_create_x_image_and_pixmap):
121 * w32.c (sys_rename, w32_delayed_load):
122 * w32font.c (fill_in_logfont):
123 * w32reg.c (x_get_string_resource): Silence compiler warnings.
125 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
127 * w32fns.c (w32_default_color_map): New function,
128 extracted from Fw32_default_color_map.
129 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
131 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
133 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
135 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
137 * keyboard.c (test_undefined): New function (bug#9751).
138 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
140 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
142 * sysdep.c (init_sys_modes): Fix the check for the controlling
145 2011-10-20 Eli Zaretskii <eliz@gnu.org>
147 * dispextern.h (struct bidi_it): New member next_en_type.
149 * bidi.c (bidi_line_init): Initialize the next_en_type member.
150 (bidi_resolve_explicit_1): When next_en_pos is valid for the
151 current character, check also for next_en_type being WEAK_EN.
152 (bidi_resolve_weak): Don't enter the expensive loop if the current
153 position is before next_en_pos. Record the bidi type of the first
154 non-ET, non-BN character we find, in addition to its position.
155 (bidi_level_of_next_char): Invalidate next_en_type when
156 next_en_pos is over-stepped.
158 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
160 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
161 * editfns.c: Rewrite current-time-zone so that it invokes
162 the equivalent of (format-time-string "%Z") to get the time zone name.
163 This fixes a bug when the time zone name contains characters that
164 need converting from the system time locale to Emacs internal format.
165 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
166 that patch fixed format-time-string to do the conversion, but
167 I forgot to fix current-time-zone.
168 (format_time_string): New function, containing most of
169 what Fformat_time_string used to contain.
170 (Fformat_time_string): Rewrite in terms of format_time_string.
171 This doesn't change this function's behavior.
172 (current-time-zone): Rewrite to use format_time_string.
173 This fixes the bug reported by Michael Schierl in
174 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
175 Jason Rumney's 2007-06-07 change worked around this bug, but
177 * systime.h (tzname, timezone): Remove no-longer-used declarations.
179 2011-10-19 Eli Zaretskii <eliz@gnu.org>
181 * xdisp.c (start_display): If the character at POS is displayed
182 via a display vector, reset IT->current.dpvec_index to zero.
183 (try_window_reusing_current_matrix): If a line ends in a display
184 vector or the next line starts in a display vector, continue
185 redrawing the window even though the character position of
186 start_row was reached.
189 2011-10-18 Chong Yidong <cyd@gnu.org>
191 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
192 with nobreak-char-display too.
194 2011-10-18 Eli Zaretskii <eliz@gnu.org>
196 Fix part 3 of bug#9771.
197 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
198 (bidi_resolve_neutral): Don't enter the expensive loop looking for
199 non-neutral characters if the current character is a paragraph
200 separator (a.k.a. Newline). This avoids running the same
201 expensive loop twice, once when we consume the preceding newline
202 and the other time when the line actually needs to be displayed.
203 Avoid the loop when we see neutrals on the base embedding level
204 following a character whose directionality is the same as the
205 paragraph's. This avoids running the expensive loop when a line
206 ends in a long sequence of neutrals, like control characters.
207 Add assertion against STRONG_AL type. Slightly rearrange code
208 that determines the type of a neutral given the first non-neutral
210 (bidi_level_of_next_char): Set next_en_pos to zero when
211 invalidating its info.
213 2011-10-17 Eli Zaretskii <eliz@gnu.org>
215 * xdisp.c (push_display_prop): Determine whether to record string
216 or buffer position by IT->string, not by IT->method. Allow
217 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
218 (move_it_vertically_backward): Don't look for character position
219 immediately after the newline when in a continuation line.
222 2011-10-15 Martin Rudalics <rudalics@gmx.at>
224 * window.c (coordinates_in_window): Rewrite and delabelize
225 vertical border check. (Bug#5357) (Bug#9618)
227 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
229 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
230 errors in XSetWindowBorder (bug#9310).
232 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
234 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
235 avoid crash when xmalloc overrun checking is enabled.
237 2011-10-13 Eli Zaretskii <eliz@gnu.org>
239 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
240 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
241 cursor motion with <left> and <right> arrow keys.
243 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
244 some callers set that themselves.
246 2011-10-12 Eli Zaretskii <eliz@gnu.org>
248 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
249 display string and the previous row comes from the same string and
250 is empty. (Bug#9739) (Bug#9738)
252 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
254 * doc.c (get_doc_string): Encode file name (bug#9735).
256 2011-10-12 Eli Zaretskii <eliz@gnu.org>
258 * bidi.c (bidi_level_of_next_char):
259 * xdisp.c (get_visually_first_element): Remove old incorrect
260 comments regarding the Unicode Line Separator character.
262 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
264 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
266 * alloc.c (Fgc_status): Do not access beyond zombies array
267 boundary if nzombies > MAX_ZOMBIES.
268 * alloc.c (dump_zombies): Add missing format specifier.
270 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
272 * xdisp.c (set_cursor_from_row): Simplify conditionals,
273 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
275 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
276 Some packages use them to denote characters with modifiers.
278 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
280 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
281 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
282 matching a pp-number. Rename parameter var to var1.
284 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
286 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
288 2011-10-08 Glenn Morris <rgm@gnu.org>
290 * callint.c (Fcall_interactively): Give a more explicit error for the
291 'c' case with a non-character input. (Bug#8479)
293 2011-10-08 Eli Zaretskii <eliz@gnu.org>
295 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
297 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
298 lines that are hscrolled on the left.
300 * dispnew.c (buffer_posn_from_coords): Account for a possible
301 presence of header-line. (Bug#4426)
303 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
305 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
306 Don't advertise functionality which we discourage or doesn't work.
308 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
310 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
311 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
312 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
313 this makes Emacs dump core during garbage collection on rare
314 occasions. sizeof is obviously inferior to offsetof here, so
316 (GC_POINTER_ALIGNMENT): New macro.
317 (mark_memory): Omit 3rd (offset) arg; caller changed.
318 Don't assume EMACS_INT alignment is the same as pointer alignment.
320 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
322 * keyboard.c (read_key_sequence_remapped): New var.
323 (read_key_sequence): Compute remapping in the right buffer.
324 (command_loop_1): Use read_key_sequence's remapping directly.
326 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
328 * dired.c (file_name_completion): Don't expand file name.
329 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
330 before checking file name handler.
332 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
333 they've been requested explicitly (bug#9591).
335 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
337 * keymap.c (Fsingle_key_description): Use make_specified_string
338 instead of build_string to build string from push_key_description.
341 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
343 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
344 This fixes a Y2038 bug on 64-bit hosts.
345 * buffer.c (reset_buffer):
346 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
347 (Fclear_buffer_auto_save_failure):
348 Use 0, not -1, to represent an unset failure time, since time_t
351 Remove dependency on glibc malloc internals.
352 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
353 Move back here from lisp.h, but with their new implementations.
354 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
355 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
356 * charset.c (charset_table_init): New static var.
357 (syms_of_charset): Use it instead of xmalloc. This removes a
358 dependency on glibc malloc internals. See Eli Zaretskii's comment in
359 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
360 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
361 Move back to alloc.c.
362 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
363 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
365 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
367 * nsterm.m (windowDidResize): Call x_set_window_size only when
368 ns_in_resize is true. Otherwise set pixelwidth/height and
369 call change_frame_size (Bug#9628).
371 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
373 Port --enable-checking=all to Fedora 14 x86-64.
374 * charset.c (syms_of_charset): Also account for glibc malloc's
375 internal overhead when calculating the initial malloc maximum.
377 Port --enable-checking=all to Fedora 14 x86.
378 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
380 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
381 (overrun_check_realloc, overrun_check_free):
382 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
383 That way, xmalloc returns a properly-aligned pointer even if
384 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
385 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
386 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
387 into account when calculating the initial malloc maximum.
388 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
389 Move here from alloc.c, so that charset.c can use it too.
390 Properly align; the old code wasn't right for common 32-bit hosts
391 when configured with --enable-checking=all.
392 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
393 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
395 2011-09-29 Eli Zaretskii <eliz@gnu.org>
397 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
400 2011-09-28 Eli Zaretskii <eliz@gnu.org>
402 * xdisp.c (compute_display_string_end): If there's no display
403 string at CHARPOS, return -1.
405 * bidi.c (bidi_fetch_char): When compute_display_string_end
406 returns a negative value, treat the character as a normal
407 character not covered by a display string. (Bug#9624)
409 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
411 * lread.c (Fread_from_string): Fix typo in docstring.
413 2011-09-27 Eli Zaretskii <eliz@gnu.org>
415 * xdisp.c (handle_invisible_prop): If invisible text ends on a
416 newline, reseat the iterator instead of bidi-iterating there one
417 character at a time. (Bug#9610)
418 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
419 TO_CHARPOS if the bidi iterator is at base embedding level.
421 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
423 * lread.c (readevalloop): Use correct code for NBSP.
424 (read1): Likewise. (Bug#9608)
426 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
428 * dbusbind.c (Fdbus_register_signal): When service is not
429 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
431 2011-09-25 Glenn Morris <rgm@gnu.org>
433 * buffer.c (truncate-lines): Doc fix.
435 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
437 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
438 (Fset_window_next_buffers): Doc fix.
440 2011-09-24 Glenn Morris <rgm@gnu.org>
442 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
444 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
446 Fix minor problems found by static checking.
447 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
448 * indent.c (Fvertical_motion): Fix == vs = typo.
450 2011-09-24 Eli Zaretskii <eliz@gnu.org>
452 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
453 Default value is now t. Doc fix.
455 * indent.c (Fvertical_motion): Compute and apply the overshoot
456 logic when moving up, not only when moving down. Fix the
457 confusing name and values of the it_overshoot_expected variable;
458 logic changes accordingly. (Bug#9254) (Bug#9549)
460 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
461 CHARPOS is covered by a display string which includes newlines.
462 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
463 is covered by a display string with embedded newlines.
465 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
467 * dbusbind.c (Fdbus_register_signal): Add match rule to
468 Vdbus_registered_objects_table. (Bug#9581)
469 (Fdbus_register_method, Vdbus_registered_objects_table):
472 2011-09-24 Jim Meyering <meyering@redhat.com>
474 do not ignore write error for any output size
475 The previous change was incomplete.
476 While it makes emacs --batch detect the vast majority of stdout
477 write failures, errors were still ignored whenever the output size is
478 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
479 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
480 && echo FAIL: ignored write error
481 FAIL: ignored write error
482 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
483 && echo FAIL: ignored write error
484 FAIL: ignored write error
485 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
487 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
489 * emacs.c (Fkill_emacs): In noninteractive mode exit
490 non-successfully if a write error occurred on stdout. (Bug#9574)
492 2011-09-21 Eli Zaretskii <eliz@gnu.org>
494 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
497 * dispextern.h (struct it): Update the comment documenting what
500 2011-09-20 Eli Zaretskii <eliz@gnu.org>
502 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
503 a display string, extend search for cursor position to end of row.
504 (find_row_edges): If the row ends in a newline from a display
505 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
506 Handle the case of a display string with multiple newlines.
507 (Fcurrent_bidi_paragraph_direction): Fix search for previous
508 non-empty line. Fixes confusing cursor motion with arrow keys at
509 the beginning of a line that starts with whitespace.
511 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
513 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
516 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
518 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
521 2011-09-18 Eli Zaretskii <eliz@gnu.org>
523 * xdisp.c (display_line): Record maximum and minimum buffer
524 positions even if no glyphs were produced (e.g., by a zero-width
525 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
526 buffer positions that will be removed from the glyph row because
528 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
529 column is beyond frame width: don't subtract 1 "pixel" when
530 computing width of the stretch.
531 (reseat_at_next_visible_line_start): Undo the change made on
532 2011-09-17 that saved paragraph information and restored it after
533 the call to `reseat'. (Bug#9545)
535 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
537 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
538 and turn window cursor on if cleared (Bug#9415).
540 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
542 * search.c (boyer_moore): Take unibyte characters from pattern
543 literally. (Bug#9458)
545 2011-09-18 Eli Zaretskii <eliz@gnu.org>
547 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
549 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
551 Fix minor problem found by static checking.
552 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
553 initialized, to pacify gcc -Wuninitialized.
555 * fileio.c: Report proper errno when syscall falls.
556 (Finsert_file_contents): Save and restore errno,
557 so that report_file_error outputs the correct diagnostic.
558 (Fwrite_region) [CLASH_DETECTION]: Likewise.
560 2011-09-18 Eli Zaretskii <eliz@gnu.org>
562 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
564 2011-09-17 Eli Zaretskii <eliz@gnu.org>
566 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
567 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
569 2011-09-17 Eli Zaretskii <eliz@gnu.org>
571 * xdisp.c (reseat_at_next_visible_line_start): Keep information
572 about the current paragraph and restore it after the call to reseat.
574 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
575 (bidi_find_paragraph_start): Search back for paragraph beginning
576 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
577 (bidi_move_to_visually_next): Only trigger paragraph-related
578 computations when the last character is a newline or at EOB, not
579 just any NEUTRAL_B. (Bug#9470)
581 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
582 truncated lines if point is covered by a display string. (Bug#9524)
584 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
586 * xselect.c: Relax test for outgoing X longs (Bug#9498).
587 (cons_to_x_long): New function.
588 (lisp_data_to_selection_data): Use it. Correct the test for
589 short-versus-long data; it was negated. Break out of vector
590 loop, for efficiency, when a long datum is discovered.
592 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
594 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
596 2011-09-16 Eli Zaretskii <eliz@gnu.org>
598 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
599 GCC PR/17406) by declaring this function with external scope.
601 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
603 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
604 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
606 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
608 * editfns.c (Fformat): Correctly handle text properties on "%%".
610 2011-09-15 Eli Zaretskii <eliz@gnu.org>
612 * xterm.c (x_draw_composite_glyph_string_foreground):
613 * w32term.c (x_draw_composite_glyph_string_foreground):
614 * term.c (encode_terminal_code):
615 * composite.c (composition_update_it, get_composition_id):
616 * xdisp.c (get_next_display_element)
617 (fill_composite_glyph_string): Add comments about special meaning
618 of TAB characters in a composition.
620 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
622 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
623 This occurs when processing a multibyte format.
624 Problem reported by Wolfgang Jenker.
626 2011-09-15 Johan Bockgård <bojohan@gnu.org>
628 * xdisp.c (try_cursor_movement): Only check for exact match if
629 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
631 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
633 Remove unused external symbols.
634 * dispextern.h (calc_pixel_width_or_height): Remove decl.
635 * xdisp.c (calc_pixel_width_or_height): Now static.
636 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
637 * indent.c (check_display_width):
638 * w32term.c: Fix comment to match code.
639 * xterm.c, xterm.h (x_catching_errors): Remove.
641 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
643 * xselect.c: Use signed conversions more consistently (Bug#9498).
644 (selection_data_to_lisp_data): Assume incoming selection data are
645 signed integers, not unsigned. This is to be consistent with
646 outgoing selection data, which was modified to use signed integers
647 in as part of the fix to Bug#9196 in response to Jan D.'s comment
648 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
649 expects long, not unsigned long.
651 2011-09-14 Eli Zaretskii <eliz@gnu.org>
653 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
654 computation of loop end. Reported by Johan Bockgård
657 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
659 * frame.c (Fother_visible_frames_p): Function deleted.
661 2011-09-12 Eli Zaretskii <eliz@gnu.org>
663 * indent.c (compute_motion): Process display vector front to back
664 rather than the other way around. (Bug#2496)
666 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
668 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
670 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
672 * minibuf.c (Fread_from_minibuffer): Doc fix.
674 2011-09-11 Eli Zaretskii <eliz@gnu.org>
676 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
677 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
679 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
681 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
682 value for non-existent files.
684 2011-09-11 Eli Zaretskii <eliz@gnu.org>
686 * fileio.c (Finsert_file_contents): If the file cannot be opened,
687 set its "size" to -1. This will set the modtime_size field of
688 the corresponding buffer to -1, which is what
689 verify-visited-file-modtime expects for files that do not exist.
692 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
694 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
696 * lisp.h: ... from here. push_key_description is no longer
697 defined in keyboard.c, so its declaration should not be in
698 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
699 logically belongs with push_key_description.
701 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
703 * buffer.h: Include <sys/types.h> instead of <time.h>.
704 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
705 Problem reported by Herbert J. Skuhra.
707 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
709 * xml.c (parse_region): Make the parsing work for
710 non-comment-starting XML files again (bug#9144).
712 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
714 * image.c (gif_load): Fix calculation of bottom and right corner.
717 2011-09-10 Eli Zaretskii <eliz@gnu.org>
719 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
720 redisplay in small windows.
722 2011-09-09 Eli Zaretskii <eliz@gnu.org>
724 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
726 2011-09-08 Martin Rudalics <rudalics@gmx.at>
728 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
729 Operate on live windows only.
731 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
733 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
735 2011-09-07 Eli Zaretskii <eliz@gnu.org>
737 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
738 only under bidi iteration.
740 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
742 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
744 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
746 isnan: Fix porting problem to Solaris 10 with bundled gcc.
747 Without this fix, the command to link temacs failed due to an
748 undefined symbol __builtin_isnan. This is because
749 /usr/include/iso/math_c99.h #defines isnan(x) to
750 __builtin_isnan(x), but the bundled gcc, which identifies itself
751 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
753 * floatfns.c (isnan): #undef, and then #define to a clone of
755 (Fisnan): Always define, since it's always available now.
756 (syms_of_floatfns): Always define isnan at the Lisp level.
758 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
760 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
762 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
764 * fileio.c: Fix bugs with large file offsets (Bug#9428).
765 The previous code assumed that file offsets (off_t values) fit in
766 EMACS_INT variables, which is not true on typical 32-bit hosts.
767 The code messed up by falsely reporting buffer overflow in cases
768 such as (insert-file-contents "big" nil 1 2) into an empty buffer
769 when "big" contains more than 2**29 bytes, even though this
770 inserts just one byte and does not overflow the buffer.
771 (Finsert_file_contents): Store file offsets as off_t
772 values, not as EMACS_INT values. Check for overflow when
773 converting between EMACS_INT and off_t. When checking for
774 buffer overflow or for overlap, take the offsets into account.
775 Don't use EMACS_INT for small values where int suffices.
776 When checking for overlap, fix a typo: ZV was used where
777 ZV_BYTE was intended.
778 (Fwrite_region): Don't assume off_t fits into 'long'.
779 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
781 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
783 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
785 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
787 sprintf-related integer and memory overflow issues (Bug#9412).
789 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
790 (esprintf, exprintf, evxprintf): New functions.
791 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
792 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
793 (modify_event_symbol): Do not assume that the length of
794 name_alist_or_stem is safe to alloca and fits in int.
795 (Fexecute_extended_command): Likewise for function name and binding.
796 (Frecursion_depth): Wrap around reliably on integer overflow.
797 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
798 since some callers pass EMACS_INT values.
799 (Fsingle_key_description): Don't crash if symbol name contains more
800 than MAX_ALLOCA bytes.
801 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
802 (get_minibuffer): Arg is now EMACS_INT, not int.
803 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
804 (esprintf, exprintf, evxprintf): New decls.
805 * window.h (command_loop_level, minibuf_level): Reflect API changes.
807 * dbusbind.c (signature_cat): New function.
808 (xd_signature, Fdbus_register_signal):
809 Do not overrun buffer; instead, report string overflow.
811 * dispnew.c (add_window_display_history): Don't overrun buffer.
812 Truncate instead; this is OK since it's just a log.
814 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
815 even if the time zone offset is outlandishly large.
816 Don't mishandle offset == INT_MIN.
818 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
819 when creating daemon; the previous buffer-overflow check was incorrect.
821 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
822 which has the guts of the old verror function.
824 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
825 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
827 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
828 (font_unparse_xlfd): Don't blindly alloca long strings.
829 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
830 fits in int, when using sprintf. Use single snprintf to count
831 length of string rather than counting it via multiple sprintfs;
832 that's simpler and more reliable.
833 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
834 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
835 sprintf, in case result does not fit in int.
837 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
838 (fontset_from_font): Print it.
840 * frame.c (tty_frame_count): Now printmax_t, not int.
841 (make_terminal_frame, set_term_frame_name): Print it.
842 (x_report_frame_params): In X, window IDs are unsigned long,
843 not signed long, so print them as unsigned.
844 (validate_x_resource_name): Check for implausibly long names,
845 and don't assume name length fits in 'int'.
846 (x_get_resource_string): Don't blindly alloca invocation name;
847 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
850 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
851 (xg_check_special_colors, xg_set_geometry):
852 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
854 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
855 Use esprintf, not sprintf, in case result does not fit in int.
857 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
858 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
859 it as a large positive number.
860 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
861 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
863 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
864 in case result does not fit in int.
866 * print.c (float_to_string): Detect width overflow more reliably.
867 (print_object): Make sprintf buffer a bit bigger, to avoid potential
868 buffer overrun. Don't assume list length fits in 'int'. Treat
869 print length of 0 as 0, not as infinity; to be consistent with other
870 uses of print length in this function. Don't overflow print length
871 index. Don't assume hash table size fits in 'long', or that
872 vectorlike size fits in 'unsigned long'.
874 * process.c (make_process): Use printmax_t, not int, to format
875 process-name gensyms.
877 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
879 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
880 to avoid potential buffer overrun.
882 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
883 if X resource line is longer than 512 bytes.
885 * xfns.c (x_window): Make sprintf buffer a bit bigger
886 to avoid potential buffer overrun.
888 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
890 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
892 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
894 Integer overflow fixes for scrolling, etc.
895 Without these, Emacs silently mishandles large integers sometimes.
896 For example, "C-u 4294967297 M-x recenter" was treated as if
897 it were "C-u 1 M-x recenter" on a typical 64-bit host.
899 * xdisp.c (try_window_id): Check Emacs fixnum range before
902 * window.c (window_scroll_line_based, Frecenter):
903 Check that an Emacs fixnum is in range before assigning it to 'int'.
904 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
905 values converted from Emacs fixnums.
906 (Frecenter): Don't wrap around a line count if it is out of 'int'
907 range; instead, treat it as an extreme value.
908 (Fset_window_configuration, compare_window_configurations):
909 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
911 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
912 that can exceed INT_MAX. Check that EMACS_INT value is in range
913 before assigning it to the (possibly-narrower) index.
914 (match_limit): Don't assume that a fixnum can fit in 'int'.
916 * print.c (print_object): Use ptrdiff_t, not int, for index that can
919 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
920 (Fvertical_motion): Don't wrap around LINES values that don't fit
921 in 'int'. Instead, treat them as extreme values. This is good
922 enough for windows, which can't have more than INT_MAX lines anyway.
924 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
926 * Require libxml/parser.h to avoid compilation warning.
928 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
930 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
931 since this reportedly can destroy thread storage.
933 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
935 * syntax.c (find_defun_start): Update all cache variables if
936 exiting early (Bug#9401).
938 2011-08-30 Eli Zaretskii <eliz@gnu.org>
940 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
942 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
943 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
944 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
946 * term.c (tty_append_glyph): New function.
947 (produce_stretch_glyph): Static function and its prototype deleted.
949 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
952 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
954 * image.c (parse_image_spec): Check for nonnegative, not for positive,
955 when checking :margin (Bug#9390).
956 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
957 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
958 so that the name doesn't mislead. All uses changed.
960 2011-08-28 Johan Bockgård <bojohan@gnu.org>
962 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
965 2011-08-27 Eli Zaretskii <eliz@gnu.org>
967 * xdisp.c (move_it_to): Don't bail out early when reaching
968 position beyond to_charpos, if we are scanning backwards.
969 (move_it_vertically_backward): When DY == 0, make sure we get to
970 the first character in the line after the newline.
972 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
974 * ccl.c: Improve and simplify overflow checking (Bug#9196).
975 (ccl_driver): Do not generate an out-of-range pointer.
976 (Fccl_execute_on_string): Remove unnecessary check for
977 integer overflow, noted by Stefan Monnier in
978 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
979 Remove a FIXME that didn't need fixing.
980 Simplify the newly-introduced buffer reallocation code.
982 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
984 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
986 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
988 Integer and memory overflow issues (Bug#9196).
990 * doc.c (get_doc_string): Rework so that
991 get_doc_string_buffer_size is the actual buffer size, rather than
992 being 1 less than the actual buffer size; this makes xpalloc more
995 * image.c (x_allocate_bitmap_record, cache_image):
996 * xselect.c (Fx_register_dnd_atom):
997 Simplify previous changes by using xpalloc.
999 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1000 since either will do and ptrdiff_t is convenient with xpalloc.
1002 * charset.c (charset_table_size)
1003 (struct charset_sort_data.priority): Now ptrdiff_t.
1004 (charset_compare): Don't overflow if priorities differ greatly.
1005 (Fsort_charsets): Don't assume list length fits in int.
1006 Check for size-calculation overflow when allocating sort data.
1007 (syms_of_charset): Allocate an initial charset table that is
1008 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1010 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1012 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1013 The actual value is always <= INT_MAX, and leaving it unsigned made
1014 overflow checking harder.
1016 * dispextern.h (struct glyph_matrix.rows_allocated)
1017 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1018 with xpalloc. The values are still always <= INT_MAX.
1020 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1022 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1023 (SAFE_NALLOCA): New macro.
1025 * region-cache.c (struct boundary.pos, find_cache_boundary)
1026 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1027 (set_cache_region, invalidate_region_cache)
1028 (revalidate_region_cache, know_region_cache, region_cache_forward)
1029 (region_cache_backward, pp_cache):
1030 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1031 so that ptrdiff_t * can be passed to xpalloc.
1032 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1033 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1034 (pp_cache): Don't assume cache_len fits in int.
1035 * region-cache.h: Adjust extern decls to match.
1037 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1038 EMACS_INT, since either will do, for xpalloc.
1040 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1041 (xnmalloc, xnrealloc, xpalloc): New functions.
1043 * bidi.c (bidi_shelve_header_size): New constant.
1044 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1045 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1047 * bidi.c (bidi_cache_shrink):
1048 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1050 Don't update size of array until after memory allocation succeeds,
1051 because xmalloc/xrealloc may not return.
1052 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1053 now that we have proper integer overflow checking.
1054 (record_overlay_string, overlay_strings): Catch overflows when
1055 calculating size of overlay_str_buf.
1057 * callproc.c (Fcall_process): Check for size overflow when
1058 calculating size of args2.
1059 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1060 Normally we prefer signed values, but sticking with ptrdiff_t would
1061 require adding more-complicated checks.
1063 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1064 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1065 Redo buffer-overflow calculations to avoid integer overflow.
1066 Add a FIXME comment where memory seems to be over-allocated.
1068 * character.c (Fstring): Check for size-calculation overflow.
1070 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1071 unnecessary integer overflow. Check for size overflow.
1072 (encode_coding_object): Don't update size until xmalloc succeeds.
1074 * composite.c (get_composition_id): Check for overflow in glyph
1075 length calculations.
1077 Integer and memory overflow fixes for display code.
1078 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1079 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1080 (scrolling_window): Check for overflow in size calculations.
1081 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1082 Don't assume glyph table len fits in int.
1083 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1084 (row_table_size): Now ptrdiff_t, not int.
1085 (scrolling_window): Avoid overflow in size calculations.
1086 Don't update size until allocation succeeds.
1087 * fns.c (concat): Check for overflow in size calculations.
1088 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1089 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1090 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1092 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1093 (get_doc_string): Check for size calculation overflow.
1094 Don't update size until allocation succeeds.
1095 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1096 EMACS_INT, where ptrdiff_t will do.
1097 (Fsubstitute_command_keys): Check for string overflow.
1099 * editfns.c (set_time_zone_rule): Don't assume environment length
1101 (message_length): Now ptrdiff_t, not int.
1102 (Fmessage_box): Don't update size until allocation succeeds.
1103 Don't assume message length fits in int.
1104 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1106 * emacs.c (main): Do not reallocate argv, since there is a null at
1107 the end that can be overwritten, and this way there's no need to
1108 worry about size-calculation overflow.
1109 (sort_args): Check for size-calculation overflow.
1111 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1113 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1115 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1116 (x_set_scroll_bar_width, x_figure_window_size):
1117 Check for integer overflow.
1118 (x_set_alpha): Do not assume XINT fits in int.
1120 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1121 This is for the members text_lines, text_cols, total_lines, total_cols,
1122 where the system imposes an 'int' limit.
1124 * fringe.c (Fdefine_fringe_bitmap):
1125 Don't update size until alloc works.
1127 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1128 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1130 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1131 Check for size-calculation overflow.
1132 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1133 do, as we prefer signed integers.
1134 (id_to_widget.max_size, id_to_widget.used)
1135 (xg_store_widget_in_map, xg_remove_widget_from_map)
1136 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1137 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1138 Use and return ptrdiff_t, not int.
1139 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1140 * gtkutil.h: Change prototypes to match the above.
1142 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1143 are duplicate now that they've been promoted to lisp.h.
1144 (x_allocate_bitmap_record, x_alloc_image_color)
1145 (make_image_cache, cache_image, xpm_load):
1146 Don't update size until alloc is done.
1147 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1149 Check for size calculation overflow.
1150 (ct_colors_allocated_max): New constant.
1151 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1154 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1155 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1156 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1157 Use ptrdiff_t, not int, to count maps.
1158 (read_char_minibuf_menu_prompt): Check for overflow in size
1159 calculations. Don't update size until allocation succeeds.
1160 Redo calculations to avoid overflow.
1161 * keyboard.h: Change prototypes to match the above.
1163 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1165 (current_minor_maps): Check for size calculation overflow.
1166 * keymap.h: Change prototypes to match the above.
1168 * lread.c (read1, init_obarray): Don't update size until alloc done.
1170 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1171 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1173 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1174 Now ptrdiff_t, not int.
1175 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1176 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1178 * process.c (Fnetwork_interface_list): Check for overflow
1179 in size calculation.
1181 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1183 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1184 overflow. Don't bother calling xmalloc when xrealloc will do.
1186 * search.c (Freplace_match): Check for size calculation overflow.
1187 (Fset_match_data): Don't assume list lengths fit in 'int'.
1189 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1190 for command line length. Do not attempt to address one before the
1191 beginning of an array, as that's not portable.
1193 * term.c (max_frame_lines): Remove; unused.
1194 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1196 (encode_terminal_code, calculate_costs): Check for size
1197 calculation overflow.
1198 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1199 table lengths and related sizes. Don't update size until alloc
1200 done. Redo calculations to avoid overflow.
1201 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1203 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1204 subtracting pointers.
1205 (gobble_line): Check for overflow more carefully. Don't update size
1208 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1209 Don't update size until alloc done.
1210 Redo size calculations to avoid overflow.
1211 Check for size calculation overflow.
1212 (main) [DEBUG]: Fix typo in invoking tparam1.
1214 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1215 Use ptrdiff_t, not int, for sizes.
1216 (store_mode_line_noprop_char): Don't update size until alloc done.
1218 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1219 Use ptrdiff_t, not int, for sizes.
1220 (Finternal_make_lisp_face, cache_face):
1221 Check for size calculation overflow.
1222 (cache_face): Treat size calculation overflows as if they were
1223 memory exhaustion (the usual treatment), rather than aborting.
1225 * xfns.c (x_encode_text, x_set_name_internal)
1226 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1227 sizes, since they can exceed INT_MAX in size. Check for size
1228 calculation overflow.
1230 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1231 (xg_select): Check for size calculation overflow.
1232 Don't update size until alloc done.
1234 * xrdb.c (get_environ_db): Don't assume path length fits in int,
1235 as sprintf is limited to int lengths.
1237 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1238 (X_LONG_MIN): New macros.
1239 Use them to make the following changes clearer.
1240 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1241 This change doesn't affect the value now, but it may help remind
1242 future maintainers not to raise the value too much later.
1243 (SELECTION_QUANTUM): Remove, replacing with ...
1244 (selection_quantum): ... new function, which avoids overflow.
1246 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1247 assumption that selection length fits in 'int'.
1248 (x_reply_selection_request, x_handle_selection_request)
1249 (x_get_window_property, receive_incremental_selection)
1250 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1251 (lisp_data_to_selection_data, clean_local_selection_data):
1252 Use ptrdiff_t, not int, to record length of selection.
1253 (x_reply_selection_request, x_get_window_property)
1254 (receive_incremental_selection, x_property_data_to_lisp):
1255 Redo calculations to avoid overflow.
1256 (x_reply_selection_request): When sending hint, ceiling it at
1257 X_LONG_MAX rather than relying on wraparound overflow to send
1259 (x_get_window_property, receive_incremental_selection)
1260 (lisp_data_to_selection_data, x_property_data_to_lisp):
1261 Check for size-calculation overflow.
1262 (x_get_window_property, receive_incremental_selection)
1263 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1264 Don't store size until memory allocation succeeds.
1265 (x_get_window_property): Plug memory leak on memory exhaustion.
1266 Don't double-block input; malloc is safe here. Don't assume 2**34
1267 - 4 fits in unsigned long. Add an xassert to check
1268 XGetWindowProperty overflow. Be more careful about overflow
1269 calculations, and distinguish size from memory overflow better.
1270 (receive_incremental_selection): When tracing, don't assume
1271 unsigned int is less than INT_MAX.
1272 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1273 harmful) conversions of unsigned short to int.
1274 (lisp_data_to_selection_data): Don't assume that integers
1275 in the range -65535 through -1 fit in an X unsigned short.
1276 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1277 result parameters unless successful. Rely on cons_to_unsigned
1278 to report problems with elements; the old code wasn't right anyway.
1279 (x_check_property_data): Check for int overflow; we cannot use
1280 a wider type due to X limits.
1281 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1283 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
1285 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1286 (x_term_init): Check for size calculation overflow.
1287 (x_color_cells): Don't store size until memory allocation succeeds.
1288 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1289 Don't assume alloca size is less than MAX_ALLOCA.
1290 (x_term_init): Don't assume length fits in int (sprintf is limited
1293 Use ptrdiff_t for composition IDs.
1294 * character.c (lisp_string_width):
1295 * composite.c (composition_table_size, n_compositions)
1296 (get_composition_id, composition_gstring_from_id):
1297 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1298 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1299 * window.c (Frecenter):
1300 Use ptrdiff_t, not int, for composition IDs.
1301 * composite.c (get_composition_id): Check for integer overflow.
1302 * composite.h: Adjust prototypes to match the above changes.
1304 Use ptrdiff_t for hash table indexes.
1305 * category.c (hash_get_category_set):
1306 * ccl.c (ccl_driver):
1307 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1308 * coding.c (coding_system_charset_list, detect_coding_system):
1309 * coding.h (struct coding_system.id):
1310 * composite.c (get_composition_id, gstring_lookup_cache):
1311 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1312 * image.c (xpm_get_color_table_h):
1313 * lisp.h (hash_lookup, hash_put):
1314 * minibuf.c (Ftest_completion):
1315 Use ptrdiff_t for hash table indexes, not int (which is too
1316 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1317 32-bit --with-wide-int hosts).
1319 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1320 Add a FIXME comment about memory leaks.
1321 (syms_of_charset): Don't assume xmalloc returns.
1323 Don't assume that stated character widths fit in int.
1324 * character.c (Fchar_width, c_string_width, lisp_string_width):
1325 * character.h (CHAR_WIDTH):
1326 * indent.c (MULTIBYTE_BYTES_WIDTH):
1327 Use sanitize_char_width to avoid undefined and/or bad behavior
1328 with outlandish widths.
1329 * character.h (sanitize_tab_width): Rename from sanitize_width,
1330 now that we have two such functions. All uses changed.
1331 (sanitize_char_width): New inline function.
1333 Don't assume that tab-width fits in int.
1334 * character.h (sanitize_width): New inline function.
1335 (SANE_TAB_WIDTH): New macro.
1336 (ASCII_CHAR_WIDTH): Use it.
1337 * indent.c (sane_tab_width): Remove. All uses replaced by
1338 SANE_TAB_WIDTH (current_buffer).
1339 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1341 * fileio.c: Integer overflow issues with file modes.
1342 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1344 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1345 Remove unreachable code.
1346 (read_hex, load_charset_map_from_file): Check for integer overflow.
1348 * xterm.c: don't go over XClientMessageEvent limit
1349 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1350 (x_send_scroll_bar_event): Likewise. Check that the size does not
1351 exceed limits imposed by XClientMessageEvent, as well as the usual
1352 ptrdiff_t and size_t limits.
1354 * keyboard.c: Overflow, signedness and related fixes.
1355 (make_lispy_movement): Use same integer type in forward decl
1356 that is used in the definition.
1357 (read_key_sequence, keyremap_step):
1358 Change bufsize argument back to int, undoing my 2011-03-30 change.
1359 We prefer signed types, and int is wide enough here.
1360 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1361 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1362 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1363 length, not size_t. Use ptrdiff_t for index, not int.
1364 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1365 possibility of integer overflow.
1367 Overflow, signedness and related fixes for images.
1369 * dispextern.h (struct it.stack[0].u.image.image_id)
1370 (struct_it.image_id, struct image.id, struct image_cache.size)
1371 (struct image_cache.used, struct image_cache.ref_count):
1372 * gtkutil.c (update_frame_tool_bar):
1373 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1374 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1375 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1376 * nsmenu.m (update_frame_tool_bar):
1377 * xdisp.c (calc_pixel_width_or_height):
1378 * xfns.c (image_cache_refcount):
1379 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1380 on typical 64-bit hosts.
1382 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1383 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1384 Omit unnecessary casts to int.
1385 (parse_image_spec): Check that integers fall into 'int' range
1386 when the callers expect that.
1387 (image_ascent): Redo ascent calculation to avoid int overflow.
1388 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1389 (lookup_image): Remove unnecessary tests.
1390 (xbm_image_p): Locals are now of int, not EMACS_INT,
1391 since parse_image_check makes sure they fit into int.
1392 (png_load, gif_load, svg_load_image):
1393 Prefer int to unsigned where either will do.
1394 (tiff_handler): New function, combining the cores of the
1395 old tiff_error_handler and tiff_warning_handler.
1396 This function is rewritten to use vsnprintf and thereby avoid
1397 stack buffer overflows. It uses only the features of vsnprintf
1398 that are common to both POSIX and native Microsoft.
1399 (tiff_error_handler, tiff_warning_handler): Use it.
1400 (tiff_load, gif_load, imagemagick_load_image):
1401 Don't assume :index value fits in 'int'.
1402 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1403 (imagemagick_load_image): Check that crop parameters fit into
1404 the integer types that MagickCropImage accepts. Don't assume
1405 Vimagemagick_render_type has a nonnegative value. Don't assume
1406 size_t fits in 'long'.
1407 (gs_load): Use printmax_t to print the widest integers possible.
1408 Check for integer overflow when computing image height and width.
1410 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1412 * xdisp.c (redisplay_window): Don't force window start if point
1413 will be invisible in the resulting window. (Bug#9324)
1415 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1417 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1418 the display spec is of the form `(space ...)'.
1419 (handle_display_spec): Return the value returned by
1420 handle_single_display_spec, not just 1 or zero.
1421 (handle_single_display_spec): If the display spec is of the form
1422 `(space ...)', and specifies display in the text area, return 2
1424 (try_cursor_movement): Check for the need to scroll more
1425 accurately, and prefer exact match for point under bidi.
1426 Don't advance `row' beyond the last row of the window.
1428 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1429 into disp_prop; all users changed.
1431 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1432 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1433 for the text covered by the display property.
1435 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1437 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1438 Change return value to nil.
1439 (Frecord_buffer): Delete unused function.
1441 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1443 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1444 buffers, return left-to-right.
1445 (set_cursor_from_row): Consider candidate row a win if its glyph
1446 represents a newline and point is on that newline. Fixes cursor
1447 positioning on the newline at EOL of R2L text within L2R
1448 paragraph, and vice versa.
1449 (try_cursor_movement): Check continued rows, in addition to
1450 continuation rows. Fixes unwarranted scroll when point enters a
1451 continued line of R2L text within an L2R paragraph, or vice versa.
1452 (cursor_row_p): Consider the case of point being equal to
1453 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1454 from the end of a short line to the beginning of a continued line
1455 of R2L text within L2R paragraph.
1456 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1457 composed characters.
1459 * bidi.c (bidi_check_type): Use xassert.
1460 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1463 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1465 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1468 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1470 * nsfont.m (ns_otf_to_script): Fix typo.
1472 2011-08-22 Kenichi Handa <handa@m17n.org>
1474 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1475 extra slot even if the purpose is char-code-property-table.
1477 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1479 * xdisp.c (redisplay_window): When computing centering_position,
1480 account for the height of the header line. (Bug#8874)
1482 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1483 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1484 candidate is selected by the mouse, and that candidate has a
1485 composed character under the mouse.
1487 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1488 coordinates reported by pos-visible-in-window-p for a composed
1489 character in column zero.
1491 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1493 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1495 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1497 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1498 consider it a hit if to_charpos is anywhere in the range of the
1499 composed buffer positions.
1501 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1503 * image.c (gif_load): Don't assume that each subimage has the same
1504 dimensions as the base image. Handle disposal method that is
1505 "undefined" by the gif spec (Bug#9335).
1507 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1509 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1510 (Fcondition_case): Document `debug' symbol in error handler.
1512 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1514 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1515 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1516 from an Org mode buffer to a Speedbar frame.
1518 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1519 a composition, take its buffer position from IT->cmp_it.charpos.
1520 Fixes cursor positioning at the beginning of a line that begins
1521 with a composed character.
1523 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1525 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1526 character bidirectional type, use STRONG_L instead. Fixes crashes
1527 in a buffer produced by `describe-categories'.
1529 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1530 members before the level stack, so they would be saved and
1531 restored when copying iterator state. Fixes incorrect reordering
1532 around TABs covered by display properties.
1534 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1536 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
1538 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1540 * eval.c (internal_condition_case, internal_condition_case_1)
1541 (internal_condition_case_2, internal_condition_case_n):
1542 Remove unnecessary aborts (Bug#9081).
1544 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1546 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1547 has no `load' handler, try opening the file locally. (Bug#9311)
1549 2011-08-16 Ken Brown <kbrown@cornell.edu>
1551 * gmalloc.c: Expand comment.
1553 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1555 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1556 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1558 2011-08-16 Ken Brown <kbrown@cornell.edu>
1560 Fix memory allocation problems in Cygwin build (Bug#9273).
1562 * unexcw.c ( __malloc_initialized): Declare external variable.
1563 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1565 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1567 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1569 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1571 [CYGWIN] (special_realloc): New function.
1572 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1573 requests to realloc storage in the static heap.
1575 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1577 * bidi.c (bidi_initialize): Remove unused local.
1579 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1582 * biditype.h: Remove file.
1583 * makefile.w32-in ($(BLD)/bidi.$(O)):
1584 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
1586 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1588 * chartab.c: Improve commentary for the uniprop_table API.
1590 * bidi.c (bidi_paragraph_init): Support zero value of
1591 bidi_ignore_explicit_marks_for_paragraph_level.
1592 (bidi_initialize): Use uniprop_table instead of including
1593 biditype.h and bidimirror.h.
1595 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1596 coordinates of the iterator when restoring from ppos_it.
1599 2011-08-14 Kenichi Handa <handa@m17n.org>
1601 * process.c (create_process): Call setup_process_coding_systems
1602 after the pid of the process is set to -1 (Bug#8162).
1604 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1606 * xdisp.c (move_it_in_display_line_to): Don't invoke
1607 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1608 ppos_it. Fixes vertical cursor motion when line beginning is
1609 covered by an image. (Bug#9296)
1611 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1613 * nsterm.h (ns_run_ascript): Declare.
1614 (NSAPP_DATA2_RUNASSCRIPT): Define.
1616 * nsfns.m (as_script, as_result, as_status): New static variables.
1617 (ns_run_ascript): New function.
1618 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1619 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1620 the event loop. Get status from as_status (Bug#7276).
1622 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1623 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1624 the event loop (Bug#7276).
1626 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1628 * gnutls.c (QCgnutls_bootprop_priority)
1629 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1630 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1631 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1632 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1633 (QCgnutls_bootprop_verify_hostname_error)
1634 (QCgnutls_bootprop_callbacks_verify): Rename from
1635 Qgnutls_bootprop_..., all uses changed.
1637 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1640 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1642 * xfaces.c (Qframe_set_background_mode): Now static.
1643 * dispextern.h (Qframe_set_background_mode): Remove decl.
1645 * process.c (Fnetwork_interface_info): Declare local only if needed.
1647 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1649 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1650 (Fnetwork_interface_list): Allocate in increments of bytes instead
1651 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1652 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1654 (struct ifflag_def): notrailers is smart on OSX.
1655 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1656 Get hardware address with getifaddrs if available.
1658 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1660 * xdisp.c (iterate_out_of_display_property): xassert that
1661 IT->position is set to within IT->object's boundaries. Break from
1662 the loop as soon as EOB is reached; avoids infloops in redisplay
1663 when IT->position is set up wrongly due to some bug.
1664 Set IT->current to match the bidi iterator unconditionally.
1665 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1666 entry. Force push_it to save on the stack the current
1667 buffer/string position, to be restored by pop_it. Fix flags in
1668 the iterator structure wrt the object coming from a display
1669 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1670 properties. (Bug#9284)
1672 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1674 * fontset.c (fontset_get_font_group): Add proper type checks.
1677 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1679 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1680 and LC_VERSION_MIN_MACOSX.
1681 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1682 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1684 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1686 * xdisp.c (forward_to_next_line_start): Allow to use the
1687 no-display-properties-and-no-overlays under bidi display.
1688 Set disp_pos in the bidi iterator to avoid searches for display
1689 properties and overlays.
1691 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1693 * editfns.c (Fset_time_zone_rule): Document relationship with the
1696 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1697 the font entity extracted from the cache (Bug#8109).
1699 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1701 * composite.c (autocmp_chars): Don't reset point. That is done by
1702 restore_point_unwind (Bug#5984).
1704 2011-08-07 Juri Linkov <juri@jurta.org>
1706 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1707 to show the arg `TIME' instead of `TIMEVAL'.
1709 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1711 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1712 display property strides EOL and includes a newline, as in
1713 longlines-mode. (Bug#9254)
1714 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1715 word-wrap under bidirectional display. (Bug#9224)
1717 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1718 is non-zero, even if the data buffer is NULL. Fixes a crash in
1719 vertical-motion with longlines-mode. (Bug#9254)
1721 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1723 * bidi.c <bidi_cache_total_alloc>: Now static.
1724 (bidi_initialize): Initialize bidi_cache_total_alloc.
1726 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1729 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1730 amount allocated this far in `bidi_cache_total_alloc'.
1731 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1732 non-zero, only free the data buffer without restoring the cache
1733 contents. All callers changed.
1735 * dispextern.h (bidi_unshelve_cache): Update prototype.
1737 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1738 (move_it_in_display_line, move_it_to)
1739 (move_it_vertically_backward, move_it_by_lines): Replace the call
1740 to xfree to an equivalent call to bidi_unshelve_cache.
1741 (move_it_in_display_line_to): Fix logic of returning
1742 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1744 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1746 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1747 came from a string character with a `cursor' property. (Bug#9229)
1749 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1751 * Makefile.in (LIB_PTHREAD): New variable.
1752 (LIBES): Add LIB_PTHREAD (Bug#9216).
1754 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1755 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1757 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1759 * regex.c (re_iswctype): Remove some redundant boolean conversions.
1761 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1763 * xterm.c (x_find_topmost_parent): New function.
1764 (x_set_frame_alpha): Find topmost parent window with
1765 x_find_topmost_parent and set the property there also (bug#9181).
1766 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1768 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1770 * callproc.c (Fcall_process): Avoid vfork clobbering
1771 the local vars buffer, coding_systems, current_dir.
1773 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1775 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1777 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1779 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1780 so that it is not optimized away.
1782 * xdisp.c (compute_display_string_pos): Remove unused local.
1784 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1786 Fix slow cursor motion and scrolling in large buffers with
1787 selective display, like Org Mode buffers. (Bug#9218)
1789 * dispextern.h (struct bidi_it): New member disp_prop_p.
1791 * xdisp.c: Remove one-slot cache of display string positions.
1792 (compute_display_string_pos): Accept an additional argument
1793 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1794 for a display string or property. If found, set DISP_PROP_P
1797 * bidi.c (bidi_fetch_char): Accept an additional argument
1798 DISP_PROP_P, and pass it to compute_display_string_pos.
1799 Only handle text covered by a display string if DISP_PROP_P is returned
1800 non-zero. All callers of bidi_fetch_char changed.
1802 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1804 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1806 2010-12-03 Don March <don@ohspite.net>
1808 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1809 last character M-[char] is translated to ESC [char] (bug#7541).
1811 2011-08-02 Kenichi Handa <handa@m17n.org>
1813 * lisp.h (uniprop_table): Extern it.
1815 * chartab.c (uniprop_table): Make it non-static.
1817 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1819 * xdisp.c (forward_to_next_line_start): Accept additional argument
1820 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1822 (reseat_at_next_visible_line_start): Use the bidi iterator state
1823 returned by forward_to_next_line_start to restore the state of
1824 it->bidi_it after backing up to previous newline. (Bug#9212)
1826 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1828 * regex.c (re_comp): Protoize.
1829 (re_exec): Fix return type.
1830 (regexec): Fix type of `ret'. (Bug#9203)
1832 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1834 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1835 This is needed if max-image-size is a floating-point number.
1837 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1839 * print.c (print_object): Print empty symbol as ##.
1841 * lread.c (read1): Read ## as empty symbol.
1843 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1845 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1846 setting frame foreground color (Bug#9175).
1847 (x_set_background_color): Likewise.
1849 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1850 contents (Bug#9176).
1851 (EmacsTooltip -init): Remove bezels and add shadows to
1854 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1855 or scroll bar (Bug#8470).
1857 * nsfont.m (nsfont_open): Remove assignment to voffset and
1858 unnecessary vars hshink, expand, hd, full_height, min_height.
1859 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1861 * nsterm.h (nsfont_info): Remove voffset field.
1863 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1865 Implement strike-through and overline on NextStep (Bug#8863).
1867 * nsfont.m (nsfont_open): Use underline position provided by font,
1868 instead of hard-coded value of 2.
1869 (nsfont_draw): Call ns_draw_text_decoration instead.
1871 * nsterm.h: Add declaration for ns_draw_text_decoration.
1873 * nsterm.m (ns_draw_text_decoration): New function for drawing
1874 underline, overline, and strike-through.
1875 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1876 ns_draw_text_decoration. Change treatment of cursor drawing to
1877 accommodate underlining, etc.
1879 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1881 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1884 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1886 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1887 Without this fix, if a signal arrives just after memory fills up,
1888 'malloc' might be invoked reentrantly.
1890 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1891 In other words, assume that every image size is allowed, on non-X
1892 hosts. This assumption is probably wrong, but it lets Emacs compile.
1894 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1896 * regex.c (re_iswctype): Convert return values to boolean.
1898 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1900 * xdisp.c (compute_display_string_pos): Don't use cached display
1901 string position if the buffer had its restriction changed.
1904 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1906 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1908 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1910 Integer signedness and overflow and related fixes. (Bug#9079)
1912 * bidi.c: Integer size and overflow fixes.
1913 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1914 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1915 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1916 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1917 (bidi_find_other_level_edge):
1918 Use ptrdiff_t instead of EMACS_INT where either will do.
1919 This works better on 32-bit hosts configured --with-wide-int.
1920 (bidi_cache_ensure_space): Check for size-calculation overflow.
1921 Use % rather than repeated addition, for better worst-case speed.
1922 Don't set bidi_cache_size until after xrealloc returns, because it
1924 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1925 (bidi_cache_ensure_space): Also check that the bidi cache size
1926 does not exceed that of the largest Lisp string or buffer. See Eli
1927 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1929 * alloc.c (__malloc_size_t): Remove.
1930 All uses replaced by size_t. See Andreas Schwab's note
1931 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1933 * image.c: Improve checking for integer overflow.
1934 (check_image_size): Assume that f is nonnull, since
1935 it is always nonnull in practice. This is one less thing to
1936 worry about when checking for integer overflow later.
1937 (x_check_image_size): New function, which checks for integer
1938 overflow issues inside X.
1939 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1940 This removes the need for a memory_full check.
1941 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1942 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1943 (xbm_read_bitmap_data): Change locals back to 'int', since
1944 their values must fit in 'int'.
1945 (xpm_load_image, png_load, tiff_load):
1946 Invoke x_create_x_image_and_pixmap earlier,
1947 to avoid much needless work if the image is too large.
1948 (tiff_load): Treat overly large images as if
1949 x_create_x_image_and_pixmap failed, not as malloc failures.
1950 (gs_load): Use x_check_image_size.
1952 * gtkutil.c: Omit integer casts.
1953 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1954 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1956 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1958 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1959 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1960 would wrongly return t on a 64-bit host.
1962 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1963 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1964 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1965 and therefore cause GCC to emit a bogus diagnostic in some cases.
1967 * image.c: Integer signedness and overflow and related fixes.
1968 This is not an exhaustive set of fixes, but it's time to
1969 record what I've got.
1970 (lookup_pixel_color, check_image_size): Remove redundant decls.
1971 (check_image_size): Don't assume that arbitrary EMACS_INT values
1972 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1973 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1974 (tiff_load, imagemagick_load_image):
1975 Check for overflow in size calculations.
1976 (x_create_x_image_and_pixmap): Remove unnecessary test for
1977 xmalloc returning NULL; that can't happen.
1978 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1979 (xpm_color_bucket): Use better integer hashing function.
1980 (xpm_cache_color): Don't possibly over-allocate memory.
1981 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1982 (gif_memory_source):
1983 Use ptrdiff_t, not int or size_t, to record sizes.
1984 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1985 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1986 either works, as we prefer signed integers.
1987 (tiff_read_from_memory, tiff_write_from_memory):
1988 Return tsize_t, not size_t, since that's what the TIFF API wants.
1989 (tiff_read_from_memory): Don't fail simply because the read would
1990 go past EOF; instead, return a short read.
1991 (tiff_load): Omit no-longer-needed casts.
1992 (Fimagemagick_types): Don't assume size fits into 'int'.
1994 Improve hashing quality when configured --with-wide-int.
1995 * fns.c (hash_string): New function, taken from sxhash_string.
1996 Do not discard information about ASCII character case; this
1997 discarding is no longer needed.
1998 (sxhash-string): Use it. Change sig to match it. Caller changed.
1999 * lisp.h: Declare it.
2000 * lread.c (hash_string): Remove, since we now use fns.c's version.
2001 The fns.c version returns a wider integer if --with-wide-int is
2002 specified, so this should help the quality of the hashing a bit.
2004 * emacs.c: Integer overflow minor fix.
2005 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2006 Define only if GNU_LINUX.
2007 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2009 * dispnew.c: Integer signedness and overflow fixes.
2010 Remove unnecessary forward decls, that were a maintenance hassle.
2011 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2013 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2014 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2015 (prepare_desired_row, line_draw_cost):
2016 Use int, not unsigned, where either works.
2017 (save_current_matrix, restore_current_matrix):
2018 Use ptrdiff_t, not size_t, where either works.
2019 (init_display): Check for overflow more accurately, and without
2020 relying on undefined behavior.
2022 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2023 Remove, replacing with the new symbols in lisp.h. All uses changed.
2024 * fileio.c (make_temp_name):
2025 * filelock.c (lock_file_1, lock_file):
2026 * xdisp.c (message_dolog):
2027 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2028 Use pMd etc. instead.
2029 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2030 replacing the pWIDE etc. symbols removed from editfns.c.
2032 * keyboard.h (num_input_events): Now uintmax_t.
2033 This is (very slightly) less likely to mess up due to wraparound.
2036 * buffer.c: Integer signedness fixes.
2037 (alloc_buffer_text, enlarge_buffer_text):
2038 Use ptrdiff_t rather than size_t when either will do, as we prefer
2041 * alloc.c: Integer signedness and overflow fixes.
2042 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2043 (__malloc_size_t): Default to size_t, not to int.
2044 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2045 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2046 Prefer ptrdiff_t to size_t when either would do, as we prefer
2048 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2049 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2050 Now const. Initialize with values that are in range even if char
2052 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2053 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2054 These functions do the right thing with sizes > 2**32.
2055 (check_depth): Now ptrdiff_t, not int.
2056 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2057 Adjust to new way of storing sizes. Check for size overflow bugs
2059 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2060 slightly wrong anyway, as it missed one instance of
2061 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2062 (refill_memory_reserve): Omit needless cast to size_t.
2063 (mark_object_loop_halt): Mark as externally visible.
2065 * xselect.c: Integer signedness and overflow fixes.
2066 (Fx_register_dnd_atom, x_handle_dnd_message):
2067 Use ptrdiff_t, not size_t, since we prefer signed.
2068 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2069 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2070 x_dnd_atoms_size and x_dnd_atoms_length.
2072 * doprnt.c: Prefer signed to unsigned when either works.
2074 * doprnt.c (doprnt):
2076 * xdisp.c (vmessage):
2077 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2078 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2079 prefer signed arithmetic to avoid comparison confusion.
2080 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2081 but is a bit tricky.
2083 Assume freestanding C89 headers, string.h, stdlib.h.
2084 * data.c, doprnt.c, floatfns.c, print.c:
2085 Include float.h unconditionally.
2086 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2087 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2088 * regex.c: Likewise for stddef.h, string.h.
2089 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2090 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2091 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2092 (STDC_HEADERS): Remove obsolete defines.
2093 * sysdep.c: Include limits.h unconditionally.
2095 Assume support for memcmp, memcpy, memmove, memset.
2096 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2097 * regex.c (memcmp, memcpy):
2098 Remove; we assume C89 now.
2100 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2101 (__malloc_safe_bcopy): Remove; no longer needed.
2103 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
2104 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2105 well either way, and we prefer signed to unsigned.
2107 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2109 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2110 closes the connection while we're reading (bug#9182).
2112 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
2114 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2115 are specified (Bug#9168).
2117 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2119 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2120 Found by GCC static checking and --with-wide-int on a 32-bit host.
2122 2011-07-25 Eli Zaretskii <eliz@gnu.org>
2124 * xdisp.c (compute_display_string_pos): Fix logic of caching
2125 previous display string position. Initialize cached_prev_pos to
2126 -1. Fixes slow-down at the beginning of a buffer.
2128 2011-07-24 Eli Zaretskii <eliz@gnu.org>
2130 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2131 for attrs[LFACE_FONTSET_INDEX].
2133 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2135 * xml.c (parse_region): Remove unused local
2136 that was recently introduced.
2138 2011-07-23 Eli Zaretskii <eliz@gnu.org>
2140 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2141 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2143 * xdisp.c (move_it_in_display_line_to): Record the best matching
2144 position for TO_CHARPOS while scanning the line, and restore it on
2145 exit if none of the characters scanned was an exact match.
2146 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
2147 when exact match is impossible due to invisible text, and the
2148 lines are truncated.
2150 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2152 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2155 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2157 Fix a significant slow-down of cursor motion with C-n, C-p,
2158 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2159 auto-repeat under bidi redisplay in fontified buffers.
2160 * xdisp.c (compute_stop_pos_backwards): New function.
2161 (next_element_from_buffer): Call compute_stop_pos_backwards to
2162 find a suitable prev_stop when we find ourselves before
2164 (reseat): Don't look for prev_stop, as that could mean a very long
2166 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2167 <cached_disp_overlay_modiff>: Cache for last found display string
2169 (compute_display_string_pos): Return the cached position if asked
2170 about the same buffer in the same area of character positions, and
2171 the buffer wasn't changed since the time the display string
2172 position was cached.
2174 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2176 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2177 is an integer, which is important for empty lines. (Bug#9149)
2179 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
2181 * frame.c (Fmodify_frame_parameters): In tty case, update the
2182 default face if necessary (Bug#4238).
2184 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
2186 * editfns.c (Fstring_to_char): No need to explain what a character
2187 is in the docstring (Bug#6576).
2189 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2191 * xml.c (parse_region): Make sure we always return a tree.
2193 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2195 * xml.c (parse_region): If a document contains only comments,
2198 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2200 * xml.c (make_dom): Return comments, too.
2202 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2205 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2206 and the surrounding thread.
2207 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2208 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2209 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2211 * s/openbsd.h (BROKEN_SIGIO): Define.
2212 * unexelf.c (unexec) [__OpenBSD__]:
2213 Don't update the .mdebug section of the Alpha COFF symbol table.
2215 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2217 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2220 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2222 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2223 This fixes some race conditions on the permissions of any newly
2226 * alloc.c (valid_pointer_p): Use pipe, not open.
2227 This fixes some permissions issues when debugging.
2229 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2230 If fchown fails to set both uid and gid, try to set just gid,
2231 as that is sometimes allowed. Adjust the file's mode to eliminate
2232 setuid or setgid bits that are inappropriate if fchown fails.
2234 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2236 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2237 to compare Lisp_Objects.
2238 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2239 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2240 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2242 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2244 * lread.c (read_integer): Unread even EOF character.
2245 (read1): Likewise. Properly record start position of symbol.
2247 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2248 symbol character follows.
2250 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2252 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2253 This works around a problem with the previous change to Fcopy_file.
2254 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2255 and without this change, GCC might complain about discarding
2256 fchown's return value.
2258 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2260 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2262 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2264 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2266 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2268 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2269 it's used from the C level.
2271 * process.c: Use the same condition for POLL_FOR_INPUT in both
2272 keyboard.c and process.c (bug#1858).
2274 2011-07-09 Lawrence Mitchell <wence@gmx.li>
2276 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2277 (Fgnutls_boot): Use it.
2279 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2281 * doc.c (Fsubstitute_command_keys): Revert last change.
2283 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2285 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2286 quotes the next character, and doesn't affect other longer
2287 sequences (bug#8935).
2289 * lread.c (syms_of_lread): Clarify that is isn't only
2290 `eval-buffer' and `eval-defun' that's affected by
2291 `lexical-binding' (bug#8460).
2293 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2295 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2296 bidi redisplay when a line includes both an image and is truncated.
2298 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2300 Fix minor problems found by static checking.
2301 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2302 (elsz): Now a signed constant, not a size_t var. We prefer signed
2303 types to unsigned, to avoid integer comparison confusion. Without
2304 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2305 "cannot optimize loop, the loop counter may overflow", a symptom
2307 * indent.c (Fvertical_motion): Mark locals as initialized.
2308 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2310 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2312 * search.c (Fre_search_backward): Mention `case-fold-search' in
2313 all the re_search_* functions (bug#8138).
2315 * keyboard.c (Fopen_dribble_file): Document when the file is
2318 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2320 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2323 Support bidi reordering of display and overlay strings.
2324 * xdisp.c (compute_display_string_pos)
2325 (compute_display_string_end): Accept additional argument STRING.
2326 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2327 (reseat_to_string): Initialize bidi_it->string.s and
2328 bidi_it->string.schars.
2329 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2330 NULL (avoids a crash in bidi_paragraph_init).
2331 Initialize itb.string.lstring.
2332 (init_iterator): Call bidi_init_it only of a valid
2333 buffer position was specified. Initialize paragraph_embedding to
2335 (reseat_to_string): Initialize the bidi iterator.
2336 (display_string): If we need to ignore text properties of
2337 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2338 original value of -1 will not work with bidi.)
2339 (compute_display_string_pos): First arg is now struct
2340 `text_pos *'; all callers changed. Support display properties on
2342 (compute_display_string_end): Support display properties on Lisp
2344 (init_iterator, reseat_1, reseat_to_string): Initialize the
2345 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2346 when iterating on a string not from display properties).
2347 (compute_display_string_pos, compute_display_string_end):
2348 Fix calculation of the object to scan. Fixes an error when using
2350 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2351 base_level_stop; instead, set base_level_stop to BEGV.
2352 Fixes crashes in vertical-motion.
2353 (next_element_from_buffer): Improve commentary for when
2354 the iterator is before prev_stop.
2355 (init_iterator): Initialize bidi_p from the default value of
2356 bidi-display-reordering, not from buffer-local value. Use the
2357 buffer-local value only if initializing for buffer iteration.
2358 (handle_invisible_prop): Support invisible properties on strings
2359 that are being bidi-reordered.
2360 (set_iterator_to_next): Support bidi reordering of C strings and
2362 (next_element_from_string): Support bidi reordering of Lisp
2364 (handle_stop_backwards): Support Lisp strings as well.
2365 (display_string): Support display of R2L glyph rows.
2366 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2367 (init_iterator): Don't initialize it->bidi_p for strings
2369 (reseat_to_string): Initialize it->bidi_p for strings here.
2370 (next_element_from_string, next_element_from_c_string)
2371 (next_element_from_buffer): Add xassert's for correspondence
2372 between IT's object being iterated and it->bidi_it.string
2374 (face_before_or_after_it_pos): Support bidi iteration.
2375 (next_element_from_c_string): Handle the case of the first string
2376 character that is not the first one in the visual order.
2377 (get_visually_first_element): New function, refactored from common
2378 parts of next_element_from_buffer, next_element_from_string, and
2379 next_element_from_c_string.
2380 (tool_bar_lines_needed, redisplay_tool_bar)
2381 (display_menu_bar): Force left-to-right direction. Add a FIXME
2382 comment for making that be controlled by a user option.
2383 (push_it, pop_it): Save and restore the state of the
2384 bidi iterator. Save and restore the bidi_p flag.
2385 (pop_it): Iterate out of display property for string iteration as
2387 (iterate_out_of_display_property): Support iteration over strings.
2388 (handle_single_display_spec): Set up it->bidi_it for iteration
2389 over a display string, and call bidi_init_it.
2390 (handle_single_display_spec, next_overlay_string)
2391 (get_overlay_strings_1, push_display_prop): Set up the bidi
2392 iterator for displaying display or overlay strings.
2393 (forward_to_next_line_start): Don't use the shortcut if
2395 (back_to_previous_visible_line_start): If handle_display_prop
2396 pushed the iterator stack, restore the internal state of the bidi
2397 iterator by calling bidi_pop_it same number of times.
2398 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2399 and we are bidi-iterating, don't decrement the iterator position;
2400 instead, set the first_elt flag in the bidi iterator, to produce
2402 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2403 (push_display_prop): xassert that we are iterating a buffer.
2404 (push_it, pop_it): Save and restore paragraph_embedding member.
2405 (handle_single_display_spec, next_overlay_string)
2406 (get_overlay_strings_1, reseat_1, reseat_to_string)
2407 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2408 correctly. Don't assume unibyte strings are not bidi-reordered.
2409 (compute_display_string_pos)
2410 (compute_display_string_end): Fix handling the case of C string.
2411 (push_it, pop_it): Save and restore from_disp_prop_p.
2412 (handle_single_display_spec, push_display_prop): Set the
2413 from_disp_prop_p flag.
2414 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2415 (pop_it): Call iterate_out_of_display_property only if we are
2416 popping after iteration over a string that came from a display
2417 property. Fix a typo in popping stretch info. Add an assertion
2418 for verifying that the iterator position is in sync with the bidi
2420 (handle_single_display_spec, get_overlay_strings_1)
2421 (push_display_prop): Fix initialization of paragraph direction for
2422 string when that of the parent object is not yet determined.
2423 (reseat_1): Call bidi_init_it to resync the bidi
2424 iterator with IT's position. (Bug#7616)
2425 (find_row_edges): If ROW->start.pos gives position
2426 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2427 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2428 Reset the from_disp_prop_p flag.
2429 (SAVE_IT, RESTORE_IT): New macros.
2430 (pos_visible_p, face_before_or_after_it_pos)
2431 (back_to_previous_visible_line_start)
2432 (move_it_in_display_line_to, move_it_in_display_line)
2433 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2434 (try_scrolling, redisplay_window, display_line): Use them when
2435 saving a temporary copy of the iterator and restoring it back.
2436 (back_to_previous_visible_line_start, reseat_1)
2437 (init_iterator): Empty the bidi cache "stack".
2438 (move_it_in_display_line_to): If iterator ended up at
2439 EOL, but we never saw any buffer positions smaller than
2440 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2441 motion in bidi-reordered lines.
2442 (move_it_in_display_line_to): Record prev_method and prev_pos
2443 immediately before the call to set_iterator_to_next. Fixes cursor
2444 motion in bidi-reordered lines with stretch glyphs and strings
2445 displayed in margins. (Bug#8133) (Bug#8867)
2446 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2448 (pos_visible_p): Support positions in bidi-reordered lines.
2449 Save and restore bidi cache.
2451 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2452 (bidi_paragraph_info): Delete unused struct.
2453 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2454 (bidi_cache_start): New variable.
2455 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2457 (bidi_cache_fetch_state, bidi_cache_search)
2458 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2459 (bidi_cache_find, bidi_peek_at_next_level)
2460 (bidi_level_of_next_char, bidi_find_other_level_edge)
2461 (bidi_move_to_visually_next): Compare cache index with
2462 bidi_cache_start rather than with zero.
2463 (bidi_fetch_char): Accept new argument STRING; all callers
2464 changed. Support iteration over a string. Support strings with
2465 display properties. Support unibyte strings. Fix the type of
2466 `len' according to what STRING_CHAR_AND_LENGTH expects.
2467 (bidi_paragraph_init, bidi_resolve_explicit_1)
2468 (bidi_resolve_explicit, bidi_resolve_weak)
2469 (bidi_level_of_next_char, bidi_move_to_visually_next):
2470 Support iteration over a string.
2471 (bidi_set_sor_type, bidi_resolve_explicit_1)
2472 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2473 can now be zero (for strings); special values 0 and -1 were
2474 changed to -1 and -2, respectively.
2475 (bidi_char_at_pos): New function.
2476 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2477 Call it instead of FETCH_MULTIBYTE_CHAR.
2478 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2479 initialized to valid values.
2480 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2482 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2483 the test for valid cached positions. Fix the logic for looking up
2484 the sentinel state in the cache. GCPRO the Lisp string we are
2486 (bidi_push_it, bidi_pop_it): New functions.
2487 (bidi_initialize): Initialize the bidi cache start stack pointer.
2488 (bidi_cache_ensure_space): New function, refactored from part of
2489 bidi_cache_iterator_state. Don't assume the required size is just
2490 one BIDI_CACHE_CHUNK away.
2491 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2492 (bidi_count_bytes, bidi_char_at_pos): New functions.
2493 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2494 always valid if bidi_cache_idx is valid.
2495 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2496 is valid if it's going to be used.
2497 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2498 (bidi_cache_fetch_state, bidi_cache_search)
2499 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2500 (bidi_cache_iterator_state, bidi_cache_find)
2501 (bidi_find_other_level_edge, bidi_cache_start_stack):
2502 All variables related to cache indices are now EMACS_INT.
2504 * dispextern.h (struct bidi_string_data): New structure.
2505 (struct bidi_it): New member `string'. Make flag members be 1-bit
2506 fields, and put them last in the struct.
2507 (compute_display_string_pos, compute_display_string_end):
2509 (bidi_push_it, bidi_pop_it): Add prototypes.
2510 (struct iterator_stack_entry): New members bidi_p,
2511 paragraph_embedding, and from_disp_prop_p.
2512 (struct it): Member bidi_p is now a bit field 1 bit wide.
2513 (bidi_shelve_cache, bidi_unshelve_cache):
2516 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2517 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2518 and vector-like objects.
2520 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2521 cache around display iteration.
2523 * window.c (Fwindow_end, window_scroll_pixel_based)
2524 (displayed_window_lines, Frecenter): Save and restore the bidi
2525 cache around display iteration.
2527 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2529 * editfns.c (Fdelete_region): Clarify the use of the named
2530 parameters (bug#6788).
2532 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2534 * indent.c (Fvertical_motion): Set and restore w->pointm when
2535 saving and restoring the window's buffer (Bug#9006).
2537 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2539 * editfns.c (Fstring_to_char): Clarify just what is returned
2540 (bug#6576). Text by Eli Zaretskii.
2542 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2544 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2546 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2548 * buffer.c (mmap_find): Fix a typo.
2550 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2552 Fix execution of x selection hooks.
2553 * xselect.c (Qx_lost_selection_functions)
2554 (Qx_sent_selection_functions): New vars.
2555 (syms_of_xselect): DEFSYM them.
2556 (x_handle_selection_request): Pass Qx_sent_selection_functions
2557 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2558 (x_handle_selection_clear,x_clear_frame_selections):
2559 Pass Qx_lost_selection_functions rather than
2560 Vx_lost_selection_functions to Frun_hook_with_args.
2562 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2564 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2565 The old code sometimes used this field without initializing it.
2567 * alloc.c (gc_sweep): Don't read past end of array.
2568 In theory, the old code could also have corrupted Emacs internals,
2569 though it'd be very unlikely.
2571 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2573 * character.c (Fcharacterp): Don't advertise optional ignored
2574 argument. (Bug#4026)
2576 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2578 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2581 * window.c (Fset_window_start): Doc fix (bug#4199).
2582 (Fset_window_hscroll): Ditto.
2584 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2586 Fix minor new problems caught by GCC 4.6.1.
2587 * term.c (init_tty): Remove unused local.
2588 * xsettings.c (store_monospaced_changed): Define this function only
2589 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2592 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2594 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2596 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2598 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2599 are the mini-buffer and the echo area (bug#3320).
2601 * term.c (init_tty): Remove support for supdup, c10 and perq
2602 terminals, which are no longer supported (bug#1482).
2604 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2606 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2608 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2610 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2611 for non-popups (Bug#3642).
2613 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2615 * alloc.c (reset_malloc_hooks): Protoize.
2616 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2617 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2618 * cm.c (losecursor): Likewise.
2619 * data.c (fmod): Likewise.
2620 * dispnew.c (swap_glyphs_in_rows): Likewise.
2621 * emacs.c (memory_warning_signal): Likewise.
2622 * floatfns.c (float_error): Likewise.
2623 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2624 (otf_open, font_otf_capability, generate_otf_features)
2625 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2627 * image.c (pbm_read_file): Likewise.
2628 * indent.c (string_display_width): Likewise.
2629 * intervals.c (check_for_interval, search_for_interval)
2630 (inc_interval_count, count_intervals, root_interval)
2631 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2632 * lread.c (defalias): Likewise.
2633 * ralloc.c (r_alloc_check): Likewise.
2634 * regex.c (set_image_of_range_1, set_image_of_range)
2635 (regex_grow_registers): Likewise.
2636 * sysdep.c (strerror): Likewise.
2637 * termcap.c (valid_filename_p, tprint, main): Likewise.
2638 * tparam.c (main): Likewise.
2639 * unexhp9k800.c (run_time_remap, save_data_space)
2640 (update_file_ptrs, read_header, write_header, calculate_checksum)
2641 (copy_file, copy_rest, display_header): Likewise.
2642 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2644 * xdisp.c (check_it): Likewise.
2645 * xfaces.c (register_color, unregister_color, unregister_colors):
2647 * xfns.c (print_fontset_result): Likewise.
2648 * xrdb.c (member, fatal, main): Likewise.
2650 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2652 Fix minor problems found by static checking (Bug#9031).
2653 * chartab.c (char_table_set_range, map_sub_char_table):
2654 Remove unused locals.
2655 (uniprop_table): Now static.
2656 * composite.c (_work_char): Remove unused static var.
2658 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2660 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2662 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2664 * gtkutil.c (qttip_cb): Remove code without function.
2666 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2668 * w32.c (pthread_sigmask): New stub.
2670 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2672 Use pthread_sigmask, not sigprocmask (Bug#9010).
2673 sigprocmask is portable only for single-threaded applications, and
2674 Emacs can be multi-threaded when it uses GTK.
2675 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2677 * callproc.c (Fcall_process):
2678 * process.c (create_process):
2679 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2680 Use pthread_sigmask, not sigprocmask.
2682 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2684 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2685 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2688 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2690 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2691 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2692 (xg_hide_tooltip): Fix comment.
2694 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2695 in registerServicesMenuSendTypes.
2696 (validRequestorForSendType): Don't check ns_return_types.
2698 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2701 2011-07-08 Jason Rumney <jasonr@gnu.org>
2703 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2704 frame struct members of non-existent frames (Bug#6284).
2706 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2708 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2709 variable firstTime not needed on OSX >= 10.6.
2710 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2711 >= 10.5. Use setKnobProportion, setDoubleValue.
2713 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2714 (MAC_OS_X_VERSION_10_5): Define if not defined.
2715 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2716 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2717 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2719 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2720 cString and lossyCString on OSX >= 10.4
2722 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2723 sizeToFit on OSX >= 10.2.
2725 * nsimage.m (allocInitFromFile): Don't use deprecated method
2726 bestRepresentationForDevice on OSX >= 10.6.
2728 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2731 * emacs.c: Declare unexec_init_emacs_zone.
2733 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2735 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2737 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2738 on svcsMenu (Bug#8842).
2740 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2742 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2744 * nsterm.m (QUTF8_STRING): Declare.
2745 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2746 (validRequestorForSendType): Return type is (id).
2747 Change indexOfObjectIdenticalTo to indexOfObject.
2748 Check if we have local selection before returning self (Bug#8842).
2749 (writeSelectionToPasteboard): Put local selection into paste board
2750 if we have a local selection (Bug#8842).
2751 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2753 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2754 (ns_get_local_selection): Declare.
2756 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2758 * keymap.c (describe_map_tree): Don't insert a double newline at
2759 the end of the buffer (bug#1169) and return whether we inserted
2762 * callint.c (Fcall_interactively): Change "reading args" to
2763 "providing args" to try to clarify what it does (bug#1010).
2765 2011-07-07 Kenichi Handa <handa@m17n.org>
2767 * composite.c (composition_compute_stop_pos): Ignore a static
2768 composition starting before CHARPOS (Bug#8915).
2770 * xdisp.c (handle_composition_prop): Likewise.
2772 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2774 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2777 2011-07-07 Kenichi Handa <handa@m17n.org>
2779 * character.h (unicode_category_t): New enum type.
2781 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2782 (Qchar_code_property_table): New variable.
2783 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2784 (UNIPROP_COMPRESSED_FORM_P): New macros.
2785 (char_table_ascii): Uncompress the compressed values.
2786 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2787 Uncompress the compressed values.
2788 (sub_char_table_ref_and_range): Likewise.
2789 (char_table_ref_and_range): Uncompress the compressed values.
2790 (sub_char_table_set): New arg is_uniprop. Callers changed.
2791 Uncompress the compressed values.
2792 (sub_char_table_set_range): Args changed. Callers changed.
2793 (char_table_set_range): Adjuted for the above change.
2794 (map_sub_char_table): Delete args default_val and parent. Add arg
2795 top. Give decoded values to a Lisp function.
2796 (map_char_table): Adjust for the above change. Give decoded
2797 values to a Lisp function. Gcpro more variables.
2798 (uniprop_table_uncompress)
2799 (uniprop_decode_value_run_length): New functions.
2800 (uniprop_decoder, uniprop_decoder_count): New variables.
2801 (uniprop_get_decoder, uniprop_encode_value_character)
2802 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2804 (uniprop_encoder, uniprop_encoder_count): New variables.
2805 (uniprop_get_encoder, uniprop_table)
2806 (Funicode_property_table_internal, Fget_unicode_property_internal)
2807 (Fput_unicode_property_internal): New functions.
2808 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2809 Sunicode_property_table_internal, Sget_unicode_property_internal,
2810 and Sput_unicode_property_internal. Defvar_lisp
2811 char-code-property-alist.
2813 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2814 Vunicode_category_table.
2816 * font.c (font_range): Adjust for the change of
2817 Vunicode_category_table.
2819 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2821 * m/iris4d.h: Remove file, move contents ...
2822 * s/irix6-5.h: ... here.
2824 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2826 Remove unportable assumption about struct layout (Bug#8884).
2827 * alloc.c (mark_buffer):
2828 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2829 (clone_per_buffer_values): Don't assume that
2830 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2831 This isn't true in general, and it's particularly not true
2832 if Emacs is configured with --with-wide-int.
2833 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2834 New macros, used in the buffer.c change.
2836 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2838 * xsettings.c: Use both GConf and GSettings if both are available.
2839 (store_config_changed_event): Add comment.
2840 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2841 (store_tool_bar_style_changed): New functions.
2842 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2843 (struct xsettings): Move font inside HAVE_XFT.
2844 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2845 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2846 Move inside HAVE_XFT.
2847 (something_changed_gsettingsCB): Rename from something_changedCB.
2848 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2850 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2851 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2852 (something_changed_gconfCB): Rename from something_changedCB.
2853 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2854 (parse_settings): Move check for font inside HAVE_XFT.
2855 (read_settings, apply_xft_settings): Add comment.
2856 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2857 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2858 call store_font_name_changed.
2859 (xft_settings_event): Add comment.
2860 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2861 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2862 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2863 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2864 (xsettings_initialize): Call init_gsettings last.
2865 (xsettings_get_system_font, xsettings_get_system_normal_font):
2868 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2870 Random fixes. E.g., (random) never returned negative values.
2871 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2872 subseconds part to the entropy, as that's a bit more random.
2873 Prefer signed to unsigned, since the signedness doesn't matter and
2874 in general we prefer signed. When given a limit, use a
2875 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2876 latter isn't right if USE_2_TAGS_FOR_INTS.
2877 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2878 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2880 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2882 * textprop.c (text_property_stickiness):
2883 Obey Vtext_property_default_nonsticky.
2884 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2885 * w32fns.c (syms_of_w32fns):
2886 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2888 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2890 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2891 This is more efficient than Ffile_directory_p and avoids a minor race.
2893 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2895 * buffer.c (Foverlay_put): Say what the return value is
2898 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2899 is a directory before asking whether to use the file name
2901 (barf_or_query_if_file_exists): Make the "File is a directory"
2902 error be more correct.
2904 * fns.c (Frequire): Remove the mention of the .gz files, since
2905 that's installation-specific, but keep the mention of
2906 `get-load-suffixes'.
2908 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2910 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2911 Report string overflow if the output is too long.
2913 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2915 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2916 (syms_of_gnutls): Remove duplicate DEFSYM for
2917 Qgnutls_bootprop_verify_hostname_error, an error for
2918 Qgnutls_bootprop_verify_error (which is no longer used).
2920 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2921 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2922 Also (re)move comments that are misplaced or no longer relevant.
2924 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2926 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2928 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2930 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2931 and background color parameters if they have been changed.
2933 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2935 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2937 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2939 * xsettings.c (SYSTEM_FONT): Define only when used.
2940 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2942 * keymap.c (access_keymap_1): Now static.
2944 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2946 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2947 leave any prefix arg for the up event (Bug#1586).
2949 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2951 * lread.c (syms_of_lread): Mention single symbols defined by
2952 `defvar' or `defconst' (bug#7154).
2954 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2955 (Frequire): Mention get-load-suffixes.
2957 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2959 * window.h (window): Remove clone_number slot.
2960 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2962 (make_parent_window, make_window, saved_window)
2963 (Fset_window_configuration, save_window_save): Don't deal with
2965 * buffer.c (Qclone_number): Remove declaration.
2966 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2968 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2970 Add multiple inheritance to keymaps.
2971 * keymap.c (Fmake_composed_keymap): New function.
2972 (Fset_keymap_parent): Simplify.
2973 (fix_submap_inheritance): Remove.
2974 (access_keymap_1): New function extracted from access_keymap to handle
2975 embedded parents and handle lists of maps.
2976 (access_keymap): Use it.
2977 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2978 (Fcopy_keymap): Handle embedded parents.
2979 (Fcommand_remapping, define_as_prefix): Simplify.
2980 (Fkey_binding): Simplify.
2981 (syms_of_keymap): Move minibuffer-local-completion-map,
2982 minibuffer-local-filename-completion-map,
2983 minibuffer-local-must-match-map, and
2984 minibuffer-local-filename-must-match-map to Elisp.
2985 (syms_of_keymap): Defsubr make-composed-keymap.
2986 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2987 (parse_menu_item): Trivial simplification.
2989 2011-07-01 Glenn Morris <rgm@gnu.org>
2991 * Makefile.in (SETTINGS_LIBS): Fix typo.
2993 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2995 * coding.c (Fencode_coding_string): Record the last coding system
2996 used, as the function doc string says (bug#8738).
2998 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3000 * xsettings.c (store_monospaced_changed): Take new font as arg and
3001 check for change against current_mono_font.
3002 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3003 (emacs_settings_constructor, emacs_settings_get_property)
3004 (emacs_settings_set_property, emacs_settings_class_init)
3005 (emacs_settings_init, gsettings_obj): Remove.
3006 (something_changedCB): New function for HAVE_GSETTINGS.
3007 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3008 with value as argument.
3009 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3010 g_settings_new (Bug#8967). Do not create gsettings_obj.
3011 Remove calls to g_settings_bind. Connect something_changedCB to
3014 * xgselect.c: Add defined (HAVE_GSETTINGS).
3015 (xgselect_initialize): Ditto.
3017 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3018 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3021 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3023 * eval.c (struct backtrace): Simplify and port the data structure.
3024 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3025 signed bit field, as this assumption is not portable and it makes
3026 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3027 "char debug_on_exit : 1" as this is not portable either; instead,
3028 use the portable "unsigned int debug_on_exit : 1". Remove unused
3029 member evalargs. Remove obsolete comments about cc bombing out.
3031 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3033 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3034 Let HAVE_GSETTINGS override HAVE_GCONF.
3035 (store_monospaced_changed): New function.
3036 (EMACS_SETTINGS): A new type derived from GObject to handle
3037 GSettings notifications.
3038 (emacs_settings_constructor, emacs_settings_get_property)
3039 (emacs_settings_set_property, emacs_settings_class_init):
3041 (gsettings_client, gsettings_obj): New variables.
3042 (GSETTINGS_SCHEMA): New define.
3043 (something_changedCB): Call store_monospaced_changed.
3044 (init_gsettings): New function.
3045 (xsettings_initialize): Call init_gsettings.
3046 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3049 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3052 2011-06-29 Martin Rudalics <rudalics@gmx.at>
3054 * window.c (resize_root_window, grow_mini_window)
3055 (shrink_mini_window): Rename Qresize_root_window to
3056 Qwindow_resize_root_window and Qresize_root_window_vertically to
3057 Qwindow_resize_root_window_vertically.
3059 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3061 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3063 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
3065 * makefile.w32-in: Redesign dependencies so they reflect more
3066 clearly which files are directly included by each source file,
3067 and not through other includes.
3069 2011-06-27 Martin Rudalics <rudalics@gmx.at>
3071 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3072 (sort_overlays, overlay_strings): When an overlay's clone number
3073 matches the window's clone number process the overlay even if
3074 the overlay's window property doesn't match the current window.
3076 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3077 (Fwindow_hchild): Rename to Fwindow_left_child.
3078 (Fwindow_next): Rename to Fwindow_next_sibling.
3079 (Fwindow_prev): Rename to Fwindow_prev_sibling.
3080 (resize_window_check): Rename to window_resize_check.
3081 (resize_window_apply): Rename to window_resize_apply.
3082 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3083 (Fdelete_other_windows_internal, resize_frame_windows)
3084 (Fsplit_window_internal, Fdelete_window_internal)
3085 (grow_mini_window, shrink_mini_window)
3086 (Fresize_mini_window_internal): Fix callers accordingly.
3088 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3090 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3091 (emacs_fixed_set_min_size): Remove.
3092 (emacs_fixed_new): Take frame as argument.
3094 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3095 (_EmacsFixedPrivate): Remove minwidth/height.
3096 Add struct frame *f.
3097 (emacs_fixed_init): Initialize priv->f.
3098 (get_parent_class, emacs_fixed_set_min_size): Remove.
3099 (emacs_fixed_new): Set priv->f to argument.
3100 (emacs_fixed_get_preferred_width)
3101 (emacs_fixed_get_preferred_height): Use min_width/height from
3102 frames size_hint to set minimum and natural (Bug#8919).
3103 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3104 and use min_width/height from frames size_hint to set
3105 min_width/height (Bug#8919).
3107 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
3108 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3111 2011-06-26 Eli Zaretskii <eliz@gnu.org>
3113 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3114 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3117 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
3119 * process.c (wait_reading_process_output): Bypass select if
3120 waiting for a cell while ignoring keyboard input, and input is
3121 pending. Suggested by Jan Djärv (Bug#8869).
3123 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3125 Use gnulib's dup2 module instead of rolling our own.
3126 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3128 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3130 * dispnew.c (scrolling_window): Before scrolling, turn off a
3131 mouse-highlight in the window being scrolled.
3133 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
3135 Move DEFSYM to lisp.h and use everywhere.
3137 * character.h (DEFSYM): Move declaration...
3138 * lisp.h (DEFSYM): ...here.
3144 * w32select.c: Don't include character.h.
3146 * alloc.c (syms_of_alloc):
3147 * buffer.c (syms_of_buffer):
3148 * bytecode.c (syms_of_bytecode):
3149 * callint.c (syms_of_callint):
3150 * casefiddle.c (syms_of_casefiddle):
3151 * casetab.c (init_casetab_once):
3152 * category.c (init_category_once, syms_of_category):
3153 * ccl.c (syms_of_ccl):
3154 * cmds.c (syms_of_cmds):
3155 * composite.c (syms_of_composite):
3156 * dbusbind.c (syms_of_dbusbind):
3157 * dired.c (syms_of_dired):
3158 * dispnew.c (syms_of_display):
3159 * doc.c (syms_of_doc):
3160 * editfns.c (syms_of_editfns):
3161 * emacs.c (syms_of_emacs):
3162 * eval.c (syms_of_eval):
3163 * fileio.c (syms_of_fileio):
3164 * fns.c (syms_of_fns):
3165 * frame.c (syms_of_frame):
3166 * fringe.c (syms_of_fringe):
3167 * insdel.c (syms_of_insdel):
3168 * keymap.c (syms_of_keymap):
3169 * lread.c (init_obarray, syms_of_lread):
3170 * macros.c (syms_of_macros):
3171 * msdos.c (syms_of_msdos):
3172 * print.c (syms_of_print):
3173 * process.c (syms_of_process):
3174 * search.c (syms_of_search):
3175 * sound.c (syms_of_sound):
3176 * syntax.c (init_syntax_once, syms_of_syntax):
3177 * terminal.c (syms_of_terminal):
3178 * textprop.c (syms_of_textprop):
3179 * undo.c (syms_of_undo):
3180 * w32.c (globals_of_w32):
3181 * window.c (syms_of_window):
3182 * xdisp.c (syms_of_xdisp):
3183 * xfaces.c (syms_of_xfaces):
3184 * xfns.c (syms_of_xfns):
3185 * xmenu.c (syms_of_xmenu):
3186 * xsettings.c (syms_of_xsettings):
3187 * xterm.c (syms_of_xterm): Use DEFSYM.
3189 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3191 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
3193 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3195 Integer and buffer overflow fixes (Bug#8873).
3197 * print.c (printchar, strout): Check for string overflow.
3198 (PRINTPREPARE, printchar, strout):
3199 Don't set size unless allocation succeeds.
3201 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3202 for sizes. Check for string overflow more accurately.
3203 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3205 * macros.c: Integer and buffer overflow fixes.
3206 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3207 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3208 Use ptrdiff_t, not int, for sizes.
3209 Don't increment bufsize until after realloc succeeds.
3210 Check for size-calculation overflow.
3211 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3213 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3215 * lread.c: Integer overflow fixes.
3216 (read_integer): Radix is now EMACS_INT, not int,
3217 to improve quality of diagnostics for out-of-range radices.
3218 Calculate buffer size correctly for out-of-range radices.
3219 (read1): Check for integer overflow in radices, and in
3220 read-circle numbers.
3221 (read_escape): Avoid int overflow.
3222 (Fload, openp, read_buffer_size, read1)
3223 (substitute_object_recurse, read_vector, read_list, map_obarray):
3224 Use ptrdiff_t, not int, for sizes.
3225 (read1): Use EMACS_INT, not int, for sizes.
3226 Check for size overflow.
3228 * image.c (cache_image): Check for size arithmetic overflow.
3230 * lread.c: Integer overflow issues.
3231 (saved_doc_string_size, saved_doc_string_length)
3232 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3233 Now ptrdiff_t, not int.
3234 (read1): Don't assume doc string length fits in int. Check for
3235 out-of-range doc string lengths.
3236 (read_list): Don't assume file position fits in int.
3237 (read_escape): Check for hex character overflow.
3239 2011-06-22 Leo Liu <sdl.web@gmail.com>
3241 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3242 Move to minibuffer.el.
3244 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3246 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
3247 The following patches are for when GLYPH_DEBUG && !XASSERT.
3248 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3249 * dispnew.c (flush_stdout):
3250 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3251 Mark as externally visible.
3252 * dispnew.c (check_window_matrix_pointers): Now static.
3253 * dispnew.c (window_to_frame_vpos):
3254 * xfns.c (unwind_create_frame):
3255 * xterm.c (x_check_font): Remove unused local.
3256 * scroll.c (CHECK_BOUNDS):
3257 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3258 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3259 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3260 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3261 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3263 (debug_method_add): Use va_list and vsprintf rather than relying
3264 on undefined behavior with wrong number of arguments.
3265 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3266 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3267 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3268 since we're not interested in debugging glyphs with old libraries.
3269 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3270 GCC 4.6.0's static checking.
3272 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3274 Integer overflow and signedness fixes (Bug#8873).
3275 A few related buffer overrun fixes, too.
3277 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3279 * dispextern.h (struct face.stipple):
3280 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3281 (x_bitmap_mask, x_allocate_bitmap_record)
3282 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3283 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3284 (x_create_bitmap_from_xpm_data):
3285 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3286 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3288 * xfaces.c (load_pixmap):
3289 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3290 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3291 (.bitmaps_last, struct x_output.icon_bitmap):
3292 Use ptrdiff_t, not int, for bitmap indexes.
3293 (x_allocate_bitmap_record): Check for size overflow.
3294 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3296 Use ptrdiff_t, not int, for overlay counts.
3297 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3298 * editfns.c (overlays_around, get_pos_property):
3299 * textprop.c (get_char_property_and_overlay):
3300 * xdisp.c (next_overlay_change, note_mouse_highlight):
3301 * xfaces.c (face_at_buffer_position):
3302 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3303 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3304 (Fnext_overlay_change, Fprevious_overlay_change)
3305 (mouse_face_overlay_overlaps, Foverlays_in):
3306 Use ptrdiff_t, not int, for sizes.
3307 (overlays_at, overlays_in): Check for size-calculation overflow.
3309 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3311 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3312 (x_session_initialize): Do not assume string length fits in int.
3314 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3315 This is unlikely, but can occur if DPI is outlandish.
3317 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3318 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3320 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3321 * xrdb.c (magic_file_p, search_magic_path):
3322 Omit last arg SUFFIX; it was always 0. All callers changed.
3323 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3325 * xfont.c (xfont_match): Avoid need for strlen.
3327 * xfns.c: Don't assume strlen fits in int.
3328 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3330 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3331 not unsigned long, as we prefer signed integers. All callers changed.
3332 Detect integer overflow in repeat count.
3333 (message_dolog): Don't assume print length fits in 39 bytes.
3334 (display_mode_element): Don't assume strlen fits in int.
3336 * termcap.c: Don't assume sizes fit in int and never overflow.
3337 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3338 (gobble_line): Check for size-calculation overflow.
3340 * minibuf.c (Fread_buffer):
3341 * lread.c (intern, intern_c_string):
3342 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3343 Don't assume string length fits in int.
3345 * keyboard.c (parse_tool_bar_item):
3346 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3348 * font.c: Don't assume string length fits in int.
3349 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3350 Use ptrdiff_t, not int.
3351 (font_intern_prop): Don't assume string length fits in int.
3352 Don't assume integer property fits in fixnum.
3353 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3355 * filelock.c: Fix some buffer overrun and integer overflow issues.
3356 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3357 Reformulate so as not to need the command string.
3358 Invoke gzip -cd rather than gunzip, as it's more portable.
3359 (lock_info_type, lock_file_1, lock_file):
3360 Don't assume pid_t and time_t fit in unsigned long.
3361 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3362 (current_lock_owner): Prefer signed type for sizes.
3363 Use memcpy, not strncpy, where memcpy is what is really wanted.
3364 Don't assume (via atoi) that time_t and pid_t fit in int.
3365 Check for time_t and/or pid_t out of range, e.g., via a network share.
3366 Don't alloca where an auto var works fine.
3368 * fileio.c: Fix some integer overflow issues.
3369 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3370 Don't assume string length fits in int.
3371 (directory_file_name): Don't assume string length fits in long.
3372 (make_temp_name): Don't assume pid fits in int, or that its print
3373 length is less than 20.
3375 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3377 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3379 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3381 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3382 We prefer signed integers, even for size calculations.
3384 * emacs.c: Don't assume string length fits in 'int'.
3385 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3386 (main): Don't invoke strlen when not needed.
3388 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3389 (XD_DEBUG_MESSAGE): Don't waste a byte.
3391 * callproc.c (getenv_internal_1, getenv_internal)
3393 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3395 * lread.c (invalid_syntax): Omit length argument.
3396 All uses changed. This doesn't fix a bug, but it simplifies the
3397 code away from its former Hollerith-constant appearance, and it's
3398 one less 'int' to worry about when looking at integer-overflow issues.
3399 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3401 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3402 This didn't break anything, but it didn't help either.
3403 It's confusing to put a bogus integer in a place where the actual
3404 value does not matter.
3405 (LIST_END_P): Remove unused macro and its bogus comment.
3406 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3408 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3409 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3411 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3412 We prefer signed types, and the value cannot exceed the EMACS_INT
3413 range anyway (because otherwise the length would not be representable).
3414 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3415 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3416 This avoids a GCC warning when WIDE_EMACS_INT.
3418 * indent.c (sane_tab_width): New function.
3419 (current_column, scan_for_column, Findent_to, position_indentation)
3420 (compute_motion): Use it. This is just for clarity.
3421 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3423 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3425 * lisp.h (lint_assume): New macro.
3426 * composite.c (composition_gstring_put_cache):
3427 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3429 * editfns.c, insdel.c:
3430 Omit unnecessary forward decls, to simplify future changes.
3432 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3434 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3436 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3437 Use much-faster test for byte-length change.
3438 Don't assume string byte-length fits in 'int'.
3439 Check that character arg fits in 'int'.
3440 (mapcar1): Declare byte as byte, for clarity.
3442 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3444 * fns.c (concat): Catch string overflow earlier.
3445 Do not rely on integer wraparound.
3447 * dispextern.h (struct it.overlay_strings_charpos)
3448 (struct it.selective): Now EMACS_INT, not int.
3449 * xdisp.c (forward_to_next_line_start)
3450 (back_to_previous_visible_line_start)
3451 (reseat_at_next_visible_line_start, next_element_from_buffer):
3452 Don't arbitrarily truncate the value of 'selective' to int.
3454 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3456 * composite.c: Don't truncate sizes to 'int'.
3457 (composition_gstring_p, composition_reseat_it)
3458 (composition_adjust_point): Use EMACS_INT, not int.
3459 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3460 not EMACS_UINT, for indexes.
3462 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3464 * buffer.c: Include <verify.h>.
3465 (struct sortvec.priority, struct sortstr.priority):
3466 Now EMACS_INT, not int.
3467 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3468 (struct sortstr.size, record_overlay_string)
3469 (struct sortstrlist.size, struct sortlist.used):
3470 Don't truncate size to int.
3471 (record_overlay_string): Check for size-calculation overflow.
3472 (init_buffer_once): Check at compile-time, not run-time.
3474 2011-06-22 Jim Meyering <meyering@redhat.com>
3476 Don't leak an XBM-image-sized buffer
3477 * image.c (xbm_load): Free the image buffer after using it.
3479 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3482 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3483 that Sun C diagnosed.
3484 * fns.c (secure_hash): Fix pointer signedness issue.
3485 * intervals.c (static_offset_intervals): New function.
3486 (offset_intervals): Use it.
3488 2011-06-21 Leo Liu <sdl.web@gmail.com>
3491 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3494 * fns.c (secure_hash): Rename from crypto_hash_function and change
3495 the first arg to accept symbols.
3496 (Fsecure_hash): New primitive.
3497 (syms_of_fns): New symbols.
3499 2011-06-20 Deniz Dogan <deniz@dogan.se>
3501 * process.c (Fset_process_buffer): Clarify return value in
3504 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3506 * dispnew.c (add_window_display_history): Use BVAR.
3508 * xdisp.c (debug_method_add): Use BVAR.
3509 (check_window_end, dump_glyph_matrix, dump_glyph)
3510 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3512 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3515 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3516 check till after the cache is created in init_frame_faces.
3518 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3520 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3522 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3524 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3525 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3526 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3528 Improve buffer-overflow checking (Bug#8873).
3529 * fileio.c (Finsert_file_contents):
3530 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3531 Remove the old (too-loose) buffer overflow checks.
3532 They weren't needed, since make_gap checks for buffer overflow.
3533 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3534 The old code merely checked for Emacs fixnum overflow, and relied
3535 on undefined (wraparound) behavior. The new code avoids undefined
3536 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3538 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3539 Tune. Don't use wider integers than needed. Don't use alloca.
3540 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3542 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3544 * insdel.c, lisp.h (buffer_overflow): New function.
3545 (insert_from_buffer_1, replace_range, replace_range_2):
3546 * insdel.c (make_gap_larger):
3547 * editfns.c (Finsert_char):
3548 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3550 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3552 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3554 Integer overflow and signedness fixes (Bug#8873).
3556 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3557 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3559 * fileio.c: Don't assume EMACS_INT fits in off_t.
3560 (emacs_lseek): New static function.
3561 (Finsert_file_contents, Fwrite_region): Use it.
3562 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3564 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3566 * fns.c: Don't overflow int when computing a list length.
3567 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3568 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3569 truncation on 64-bit hosts. Check for QUIT every
3570 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3571 faster and is responsive enough.
3572 (Flength): Report an error instead of overflowing an integer.
3573 (Fsafe_length): Return a float if the value is not representable
3574 as a fixnum. This shouldn't happen except in contrived situations.
3575 (Fnthcdr, Fsort): Don't assume list length fits in int.
3576 (Fcopy_sequence): Don't assume vector length fits in int.
3578 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3579 (header_size, word_size): New constants.
3580 (allocate_vectorlike): Don't check size overflow here.
3581 (allocate_vector): Check it here instead, since this is the only
3582 caller of allocate_vectorlike that could cause overflow.
3583 Check that the new vector's length is representable as a fixnum.
3585 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3586 The previous code was bogus. For example, next_almost_prime (32)
3587 returned 39, which is undesirable as it is a multiple of 3; and
3588 next_almost_prime (24) returned 25, which is a multiple of 5 so
3589 why was the code bothering to check for multiples of 7?
3591 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3593 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3595 Variadic C functions now count arguments with ptrdiff_t.
3596 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3597 Back then I didn't know that the Emacs coding style prefers signed int.
3598 Also, in the meantime I found a few more instances where arguments
3599 were being counted with int, which may truncate counts on 64-bit
3600 machines, or EMACS_INT, which may be unnecessarily wide.
3601 * lisp.h (struct Lisp_Subr.function.aMANY)
3602 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3603 Arg counts are now ptrdiff_t, not size_t.
3604 All variadic functions and their callers changed accordingly.
3605 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3606 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3607 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3608 * callint.c (Fcall_interactively): Check arg count for overflow,
3609 to avoid potential buffer overrun. Use signed char, not 'int',
3610 for 'varies' array, so that we needn't bother to check its size
3611 calculation for overflow.
3612 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3613 * eval.c (apply_lambda):
3614 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3615 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3616 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3618 * callint.c (Fcall_interactively): Don't use index var as event count.
3620 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3621 * mem-limits.h (SIZE): Remove; no longer used.
3623 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3625 Remove unnecessary casts.
3626 * xterm.c (x_term_init):
3627 * xfns.c (x_set_border_pixel):
3628 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3629 These aren't needed now that we assume ANSI C.
3631 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3632 It's more likely to cause problems (due to unsigned overflow)
3635 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3637 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3639 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3641 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3643 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3645 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3647 GLYPH_CODE_FACE returns EMACS_INT, not int.
3648 * dispextern.h (merge_faces):
3649 * xfaces.c (merge_faces):
3650 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3651 Don't assume EMACS_INT fits in int.
3653 * character.h (CHAR_VALID_P): Remove unused parameter.
3654 * fontset.c, lisp.h, xdisp.c: All uses changed.
3656 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3658 * fns.c (concat): Minor tuning based on overflow analysis.
3659 This doesn't fix any bugs. Use int to hold character, instead
3660 of constantly refetching from Emacs object. Use XFASTINT, not
3661 XINT, for value known to be a character. Don't bother comparing
3662 a single byte to 0400, as it's always less.
3664 * floatfns.c (Fexpt):
3665 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3667 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3670 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3672 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3673 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3674 incorrectly succeed when S was a string, because 4294967386 was
3675 truncated before it was used.
3677 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3678 Otherwise, an out-of-range integer could cause undefined behavior
3681 * composite.c: Use int, not EMACS_INT, for characters.
3682 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3683 EMACS_INT, for values that are known to be in character range.
3684 This doesn't fix any bugs but is the usual style inside Emacs and
3685 may generate better code on 32-bit machines.
3687 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3688 This is for reasons similar to the recent CHAR_STRING fix.
3689 * charset.c (Fencode_char): Check that character arg is actually
3690 a character. Pass an int to ENCODE_CHAR.
3691 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3692 wider than 'int', as a compile-time check to prevent future regressions
3695 * character.c (char_string): Remove unnecessary casts.
3697 Make sure a 64-bit char is never passed to CHAR_STRING.
3698 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3699 by silently ignoring the top 32 bits, allowing some values
3700 that were far too large to be valid characters.
3701 * character.h: Include <verify.h>.
3702 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3703 arguments are no wider than unsigned, as a compile-time check
3704 to prevent future regressions in this area.
3706 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3707 (Fsubst_char_in_region):
3709 * xdisp.c (decode_mode_spec_coding):
3710 Adjust to CHAR_STRING's new requirement.
3711 * editfns.c (Finsert_char, Fsubst_char_in_region):
3712 * fns.c (concat): Check that character args are actually
3713 characters. Without this test, these functions did the wrong
3714 thing with wildly out-of-range values on 64-bit hosts.
3716 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3717 These casts should not be needed on 32-bit hosts, either.
3718 * keyboard.c (read_char):
3719 * lread.c (Fload): Remove casts to unsigned.
3721 * lisp.h (UNSIGNED_CMP): New macro.
3722 This fixes comparison bugs on 64-bit hosts.
3723 (ASCII_CHAR_P): Use it.
3724 * casefiddle.c (casify_object):
3725 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3726 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3727 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3728 * dispextern.h (FACE_FROM_ID):
3729 * keyboard.c (read_char): Use UNSIGNED_CMP.
3731 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3732 not to EMACS_INT, to avoid GCC warning.
3734 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3736 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3737 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3738 isn't needed on 32-bit machines.
3740 * buffer.c (Fgenerate_new_buffer_name):
3741 Use EMACS_INT for count, not int.
3742 (advance_to_char_boundary): Return EMACS_INT, not int.
3744 * data.c (Qcompiled_function): Now static.
3746 * window.c (window_body_lines): Now static.
3748 * image.c (gif_load): Rename local to avoid shadowing.
3750 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3751 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3752 * alloc.c (make_save_value): Integer argument is now of type
3754 (mark_object): Use ptrdiff_t, not int.
3755 * lisp.h (pD): New macro.
3756 * print.c (print_object): Use it.
3758 * alloc.c: Use EMACS_INT, not int, to count objects.
3759 (total_conses, total_markers, total_symbols, total_vector_size)
3760 (total_free_conses, total_free_markers, total_free_symbols)
3761 (total_free_floats, total_floats, total_free_intervals)
3762 (total_intervals, total_strings, total_free_strings):
3763 Now EMACS_INT, not int. All uses changed.
3764 (Fgarbage_collect): Compute overall total using a double, so that
3765 integer overflow is less likely to be a problem. Check for overflow
3766 when converting back to an integer.
3767 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3768 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3769 These were 'int' variables that could overflow on 64-bit hosts;
3770 they were never used, so remove them instead of repairing them.
3771 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3772 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3773 Previously, this ceilinged at INT_MAX, but that doesn't work on
3775 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3777 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3778 (allocate_vectorlike): Check for ptrdiff_t overflow.
3779 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3780 when a (possibly-narrower) signed value would do just as well.
3781 We prefer using signed arithmetic, to avoid comparison confusion.
3783 * alloc.c: Catch some string size overflows that we were missing.
3784 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3785 for convenience in STRING_BYTES_MAX.
3786 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3787 The definition here is exact; the one in lisp.h was approximate.
3788 (allocate_string_data): Check for string overflow. This catches
3789 some instances we weren't catching before. Also, it catches
3790 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3791 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3792 and ptrdiff_t and EMACS_INT are both 64 bits.
3794 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3795 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3796 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3798 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3800 * alloc.c (Fmake_string): Check for out-of-range init.
3802 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3804 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3806 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3808 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3809 xg_get_default_scrollbar_width.
3811 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3812 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3813 (style_changed_cb): Call update_theme_scrollbar_width and call
3814 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3815 all frames (Bug#8505).
3816 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3817 Call gtk_window_set_resizable if HAVE_GTK3.
3818 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3819 and height if HAVE_GTK3 (Bug#8505).
3820 (scroll_bar_width_for_theme): New variable.
3821 (update_theme_scrollbar_width): New function.
3822 (xg_get_default_scrollbar_width): Move code to
3823 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3824 (xg_initialize): Call update_theme_scrollbar_width.
3826 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3828 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3830 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3832 * frame.c (make_frame): Call other_buffer_safely instead of
3835 * window.c (temp_output_buffer_show): Call display_buffer with
3836 second argument Vtemp_buffer_show_specifiers and reset latter
3837 immediately after the call.
3838 (Vtemp_buffer_show_specifiers): New variable.
3839 (auto_window_vscroll_p, next_screen_context_lines)
3840 (Vscroll_preserve_screen_position): Remove leading asterisks from
3843 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3845 Fix minor problems found by GCC 4.6.0 static checking.
3846 * buffer.c (Qclone_number): Remove for now, as it's unused.
3847 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3848 (record_buffer): Remove unused local.
3849 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3850 (set_frame_buffer_list): Remove; unused.
3851 * frame.h (other_visible_frames): Remove decl.
3852 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3853 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3854 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3856 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3857 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3858 Define only if HAVE_GPM.
3859 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3860 (update_hints_inhibit): Remove; never set. All uses removed.
3861 * widgetprv.h (emacsFrameClassRec): Remove decl.
3862 * window.c (delete_deletable_window): Now returns void, since it
3863 wasn't returning anything.
3864 (compare_window_configurations): Remove unused locals.
3865 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3866 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3867 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3868 the same widths as pointers. This follows up on the 2011-05-06 patch.
3869 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3870 * xterm.h: Likewise.
3871 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3873 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3875 * makefile.w32-in: Update dependencies.
3876 (LISP_H): Add lib/intprops.h.
3878 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3880 * image.c (gif_load): Add animation frame delay to the metadata.
3881 (syms_of_image): Use DEFSYM. New symbol `delay'.
3883 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3885 * window.c (delete_deletable_window): Re-add.
3886 (Fset_window_configuration): Rewrite to handle dead buffers and
3887 consequently deletable windows.
3888 (window_tree, Fwindow_tree): Remove. Supply functionality in
3890 (compare_window_configurations): Simplify code.
3892 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3894 * image.c (imagemagick_load_image): Fix type mismatch.
3895 (Fimagemagick_types): Likewise.
3897 * window.h (replace_buffer_in_windows): Declare.
3899 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3901 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3902 Qclone_number. Remove external declaration of Qdelete_window.
3903 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3905 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3906 Run Qbuffer_list_update_hook if allowed.
3907 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3908 buffer list implementation.
3909 (other_buffer_safely): New function.
3910 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3911 calls to replace_buffer_in_windows and
3912 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3914 (record_buffer): Inhibit quitting and rewrite using quittable
3915 functions. Run Qbuffer_list_update_hook if allowed.
3916 (Frecord_buffer, Funrecord_buffer): New functions.
3917 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3918 Move switch-to-buffer to window.el.
3919 (bury-buffer): Move to window.el.
3920 (Vbuffer_list_update_hook): New variable.
3922 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3925 * window.h (resize_frame_windows): Move up in code.
3926 (Fwindow_frame): Remove EXFUN.
3927 (replace_buffer_in_all_windows): Remove prototype.
3928 (replace_buffer_in_windows_safely): Add prototype.
3930 * window.c: Declare Qdelete_window static again. Move down
3931 declaration of select_count.
3932 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3933 (Fother_window): Move to window.el.
3934 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3935 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3936 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3938 (replace_buffer_in_windows): Implement by calling
3939 Qreplace_buffer_in_windows.
3940 (replace_buffer_in_all_windows): Remove with some functionality
3941 moved into replace_buffer_in_windows_safely.
3942 (replace_buffer_in_windows_safely): New function.
3943 (select_window_norecord, select_frame_norecord): Move in front
3944 of run_window_configuration_change_hook. Remove now obsolete
3946 (Fset_window_buffer): Rewrite doc-string.
3947 Call Qrecord_window_buffer.
3948 (keys_of_window): Move binding for other-window to window.el.
3950 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3952 * dispextern.h (struct image): Replace data member, whose int_val
3953 and ptr_val fields were not used by anything, with a single
3956 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3957 (gif_clear_image, gif_load, imagemagick_load_image)
3958 (gs_clear_image, gs_load): Callers changed.
3960 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3962 * buffer.h: Include <time.h>, for time_t.
3963 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3965 Fix minor problems found by static checking.
3967 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3969 Make identifiers static if they are not used in other modules.
3970 * data.c (Qcompiled_function, Qframe, Qvector):
3971 * image.c (QimageMagick, Qsvg):
3972 * minibuf.c (Qmetadata):
3973 * window.c (resize_window_check, resize_root_window): Now static.
3974 * window.h (resize_window_check, resize_root_window): Remove decls.
3976 * window.c (window_deletion_count, delete_deletable_window):
3978 (window_body_lines): Now static.
3979 (Fdelete_other_windows_internal): Mark vars as initialized.
3980 Make sure 'resize_failed' is initialized.
3981 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3982 (resize_window_apply): Remove unused local.
3983 * window.h (delete_deletable_window): Remove decl.
3985 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3986 (imagemagick_load_image): Fix pointer signedness problem by changing
3987 last arg from unsigned char * to char *. All uses changed.
3988 Also, fix a local for similar reasons.
3989 Remove unused locals. Remove locals to avoid shadowing.
3990 (fn_rsvg_handle_free): Remove; unused.
3991 (svg_load, svg_load_image): Fix pointer signedness problem.
3992 (imagemagick_load_image): Don't use garbage pointer image_wand.
3994 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3996 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3998 * image.c (gif_load): Fix omitted cast error introduced by
4001 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4003 * window.h (resize_proportionally, orig_total_lines)
4004 (orig_top_line): Remove from window structure.
4005 (set_window_height, set_window_width, change_window_heights)
4006 (Fdelete_window): Remove prototypes.
4007 (resize_frame_windows): Remove duplicate declaration.
4009 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4011 * window.h (resize_frame_windows, resize_window_check)
4012 (delete_deletable_window, resize_root_window)
4013 (resize_frame_windows): Declare prototypes.
4015 * window.c (resize_window_apply): Make definition be "static" to
4016 match the prototype.
4018 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4020 * window.c: Remove declarations of Qwindow_size_fixed,
4021 window_min_size_1, window_min_size_2, window_min_size,
4022 size_window, window_fixed_size_p, enlarge_window, delete_window.
4023 Remove static from declaration of Qdelete_window, it's
4024 temporarily needed by Fbury_buffer.
4025 (replace_window): Don't assign orig_top_line and
4027 (Fdelete_window, delete_window): Remove. Window deletion is
4028 handled by window.el.
4029 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4030 Replace Fdelete_window calls with calls to Qdelete_window.
4031 (Fdelete_other_windows): Remove. Deleting other windows is
4032 handled by window.el.
4033 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4034 handled in window.el.
4035 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4036 Window minimum sizes are handled in window.el.
4037 (shrink_windows, size_window, set_window_height)
4038 (set_window_width, change_window_heights, window_height)
4039 (window_width, CURBEG, CURSIZE, enlarge_window)
4040 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4041 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4042 handled in window.el.
4043 (make_dummy_parent): Rename to make_parent_window and give it a
4044 second argument horflag.
4045 (make_window): Don't set resize_proportionally any more.
4046 (Fsplit_window): Remove. Windows are split in window.el.
4047 (save_restore_action, save_restore_orig_size)
4048 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4049 Resize mini windows in window.el.
4050 (grow_mini_window, shrink_mini_window): Implement by calling
4051 Qresize_root_window_vertically, resize_window_check and
4052 resize_window_apply.
4053 (saved_window, Fset_window_configuration, save_window_save):
4054 Do not handle orig_top_line, orig_total_lines, and
4055 resize_proportionally.
4056 (window_min_height, window_min_width): Move to window.el.
4057 (keys_of_window): Move bindings for delete-other-windows,
4058 split-window, delete-window and enlarge-window to window.el.
4060 * buffer.c: Temporarily extern Qdelete_window.
4061 (Fbury_buffer): Temporarily call Qdelete_window instead of
4062 Fdelete_window (Fbury_buffer will move to window.el soon).
4064 * frame.c (set_menu_bar_lines_1): Remove code handling
4065 orig_top_line and orig_total_lines.
4067 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4068 set_window_height but set heights directly.
4069 (change_frame_size_1): Use resize_frame_windows.
4071 * xdisp.c (init_xdisp): Don't use set_window_height but set
4074 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4075 Use resize_frame_windows instead of change_window_heights and run
4076 run_window_configuration_change_hook.
4078 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4079 instead of change_window_heights and run
4080 run_window_configuration_change_hook.
4082 2011-06-09 Martin Rudalics <rudalics@gmx.at>
4084 * window.c (replace_window): Rename second argument REPLACEMENT to
4085 NEW. New third argument SETFLAG. Rewrite.
4086 (delete_window, make_dummy_parent): Call replace_window with
4088 (window_list_1): Move down in code.
4089 (run_window_configuration_change_hook): Move set_buffer part
4090 before select_frame_norecord part in order to unwind correctly.
4091 Rename count1 to count.
4092 (recombine_windows, delete_deletable_window, resize_root_window)
4093 (Fdelete_other_windows_internal)
4094 (Frun_window_configuration_change_hook, make_parent_window)
4095 (resize_window_check, resize_window_apply, Fresize_window_apply)
4096 (resize_frame_windows, Fsplit_window_internal)
4097 (Fdelete_window_internal, Fresize_mini_window_internal):
4099 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4101 2011-06-08 Martin Rudalics <rudalics@gmx.at>
4103 * window.h (window): Add some new members to window structure -
4104 normal_lines, normal_cols, new_total, new_normal, clone_number,
4105 splits, nest, prev_buffers, next_buffers.
4106 (WINDOW_TOTAL_SIZE): Move here from window.c.
4107 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
4109 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4111 (make_dummy_parent): Set new members of windows structure.
4112 (make_window): Move down in code. Handle new members of window
4114 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4115 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4116 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4117 (Fset_window_prev_buffers, Fwindow_next_buffers)
4118 (Fset_window_next_buffers, Fset_window_clone_number):
4120 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4121 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4123 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4124 Argument WINDOW can be now internal window too.
4125 (Fwindow_use_time): Move up in code.
4126 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4128 (Fset_window_configuration, saved_window)
4129 (Fcurrent_window_configuration, save_window_save): Handle new
4130 members of window structure.
4131 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4132 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4133 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4134 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4135 Qget_mru_window, Qresize_root_window,
4136 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4137 Qauto_buffer_name; staticpro them.
4139 2011-06-07 Martin Rudalics <rudalics@gmx.at>
4141 * window.c (Fwindow_total_size, Fwindow_left_column)
4142 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4143 (Fwindow_list_1): New functions.
4144 (window_box_text_cols): Replace with window_body_cols.
4145 (Fwindow_width, Fscroll_left, Fscroll_right):
4146 Use window_body_cols instead of window_box_text_cols.
4147 (delete_window, Fset_window_configuration):
4148 Call delete_all_subwindows with window as argument.
4149 (delete_all_subwindows): Take a window as argument and not a
4151 (window_loop): Remove handling of GET_LRU_WINDOW and
4153 (Fget_lru_window, Fget_largest_window): Move to window.el.
4155 * window.h: Extern window_body_cols instead of
4156 window_box_text_cols. delete_all_subwindows now takes a
4157 Lisp_Object as argument.
4159 * indent.c (compute_motion, Fcompute_motion):
4160 Use window_body_cols instead of window_box_text_cols.
4162 * frame.c (delete_frame): Call delete_all_subwindows with root
4165 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4167 * fns.c (Fputhash): Document return value.
4169 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
4171 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4173 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4175 Cons<->int and similar integer overflow fixes (Bug#8794).
4177 Check for overflow when converting integer to cons and back.
4178 * charset.c (Fdefine_charset_internal, Fdecode_char):
4179 Use cons_to_unsigned to catch overflow.
4180 (Fencode_char): Use INTEGER_TO_CONS.
4181 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4182 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4183 * data.c (long_to_cons, cons_to_long): Remove.
4184 (cons_to_unsigned, cons_to_signed): New functions.
4185 These signal an error for invalid or out-of-range values.
4186 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4187 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4188 * font.c (Ffont_variation_glyphs):
4189 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4190 * lisp.h: Include <intprops.h>.
4191 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4192 (cons_to_signed, cons_to_unsigned): New decls.
4193 (long_to_cons, cons_to_long): Remove decls.
4194 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4195 (Fprimitive_undo): Use CONS_TO_INTEGER.
4196 * xfns.c (Fx_window_property): Likewise.
4197 * xselect.c: Include <limits.h>.
4198 (x_own_selection, selection_data_to_lisp_data):
4199 Use INTEGER_TO_CONS.
4200 (x_handle_selection_request, x_handle_selection_clear)
4201 (x_get_foreign_selection, Fx_disown_selection_internal)
4202 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4203 (lisp_data_to_selection_data): Use cons_to_unsigned.
4204 (x_fill_property_data): Use cons_to_signed.
4205 Report values out of range.
4207 Check for buffer and string overflow more precisely.
4208 * buffer.h (BUF_BYTES_MAX): New macro.
4209 * lisp.h (STRING_BYTES_MAX): New macro.
4210 * alloc.c (Fmake_string):
4211 * character.c (string_escape_byte8):
4212 * coding.c (coding_alloc_by_realloc):
4213 * doprnt.c (doprnt):
4214 * editfns.c (Fformat):
4216 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4217 since they may not be the same number.
4218 * editfns.c (Finsert_char):
4219 * fileio.c (Finsert_file_contents):
4220 Likewise for BUF_BYTES_MAX.
4222 * image.c: Use ptrdiff_t, not int, for sizes.
4223 (slurp_file): Switch from int to ptrdiff_t.
4225 (slurp_file): Check that file size fits in both size_t (for
4226 malloc) and ptrdiff_t (for sanity and safety).
4228 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4229 if b->modtime has its maximal value.
4231 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4233 Don't assume time_t can fit into int.
4234 * buffer.h (struct buffer.modtime): Now time_t, not int.
4235 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4236 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4238 Minor fixes for signed vs unsigned integers.
4239 * character.h (MAYBE_UNIFY_CHAR):
4240 * charset.c (maybe_unify_char):
4241 * keyboard.c (read_char, reorder_modifiers):
4242 XINT -> XFASTINT, since the integer must be nonnegative.
4243 * ftfont.c (ftfont_spec_pattern):
4244 * keymap.c (access_keymap, silly_event_symbol_error):
4245 XUINT -> XFASTINT, since the integer must be nonnegative.
4246 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4247 since it makes no difference and we prefer signed.
4248 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4249 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4252 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4254 * window.h (Fwindow_frame): Declare.
4256 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4258 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4259 (SPARE_MEMORY): Always define.
4260 (LARGE_REQUEST): Remove.
4261 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4263 2011-06-06 Martin Rudalics <rudalics@gmx.at>
4265 * lisp.h: Move EXFUNS for Fframe_root_window,
4266 Fframe_first_window and Fset_frame_selected_window to window.h.
4268 * window.h: Move EXFUNS for Fframe_root_window,
4269 Fframe_first_window and Fset_frame_selected_window here from
4272 * frame.c (Fwindow_frame, Fframe_first_window)
4273 (Fframe_root_window, Fframe_selected_window)
4274 (Fset_frame_selected_window): Move to window.c.
4275 (Factive_minibuffer_window): Move to minibuf.c.
4276 (Fother_visible_frames_p): New function.
4278 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4280 * window.c (decode_window, decode_any_window): Move up in code.
4281 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4282 (inhibit_frame_unsplittable): Remove unused variable.
4283 (Fwindow_buffer): Move up and rewrite doc-string.
4284 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4285 (Fwindow_prev): New functions.
4286 (Fwindow_frame): Move here from frame.c. Accept any window as
4288 (Fframe_root_window, Fframe_first_window)
4289 (Fframe_selected_window): Move here from frame.c. Accept frame
4290 or arbitrary window as argument. Update doc-strings.
4291 (Fminibuffer_window): Move up in code.
4292 (Fwindow_minibuffer_p): Move up in code and simplify.
4293 (Fset_frame_selected_window): Move here from frame.c.
4295 (Fselected_window, select_window, Fselect_window): Move up in
4296 code. Minor doc-string fixes.
4298 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4300 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4301 Do not assume that spare memory exists; that assumption is valid
4302 only if SYSTEM_MALLOC.
4303 (LARGE_REQUEST): New macro, so that the issue of large requests
4304 is separated from the issue of spare memory.
4306 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4308 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4311 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4313 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4316 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4318 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4320 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4322 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4323 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4325 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4327 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4329 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4331 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4332 (x_clipboard_manager_save): Add return value.
4333 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4335 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4336 Obey Vx_select_enable_clipboard_manager. Catch errors in
4337 x_clipboard_manager_save (Bug#8779).
4338 (Vx_select_enable_clipboard_manager): New variable.
4339 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4341 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4343 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4345 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4347 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4348 in the current matrix if keep_current_p is non-zero.
4350 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4352 * bidi.c (bidi_level_of_next_char): Fix last change.
4354 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4356 Support bidi reordering of text covered by display properties.
4358 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4359 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4360 (bidi_cache_search, bidi_cache_iterator_state)
4361 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4362 (bidi_level_of_next_char, bidi_move_to_visually_next):
4363 Support character positions inside a run of characters covered by a
4365 (bidi_paragraph_init, bidi_resolve_explicit_1)
4366 (bidi_level_of_next_char): Call bidi_fetch_char and
4367 bidi_fetch_char_advance instead of FETCH_CHAR and
4369 (bidi_init_it): Initialize new members.
4370 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4372 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4373 instead of using explicit *_CHAR codes.
4374 (bidi_resolve_explicit, bidi_resolve_weak):
4375 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4376 bidirectional text is supported only in multibyte buffers.
4377 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4378 it to initialize the frame_window_p member of struct bidi_it.
4379 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4380 (bidi_resolve_explicit, bidi_resolve_weak)
4381 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4382 bidi_it->nchars is non-positive.
4383 (bidi_level_of_next_char): Don't try to lookup the cache for the
4384 next/previous character if nothing is cached there yet, or if we
4385 were just reseat()'ed to a new position.
4387 * xdisp.c (set_cursor_from_row): Set start and stop points
4388 according to the row's direction when priming the loop that looks
4389 for the glyph on which to display cursor.
4390 (single_display_spec_intangible_p): Function deleted.
4391 (display_prop_intangible_p): Reimplement to call
4392 handle_display_spec instead of single_display_spec_intangible_p.
4393 Accept 3 additional arguments needed by handle_display_spec.
4394 This fixes incorrect cursor motion across display property with complex
4395 values: lists, `(when COND...)' forms, etc.
4396 (single_display_spec_string_p): Support property values that are
4397 lists with the argument STRING its top-level element.
4398 (display_prop_string_p): Fix the condition for processing a
4399 property that is a list to be consistent with handle_display_spec.
4400 (handle_display_spec): New function, refactored from the
4401 last portion of handle_display_prop.
4402 (compute_display_string_pos): Accept additional argument
4403 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4404 value of a `display' property is a "replacing spec".
4405 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4406 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4407 the display property, but just return a value indicating whether
4408 the display property will replace the characters it covers.
4409 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4410 frame_window_p members of struct bidi_it.
4411 (compute_display_string_pos, compute_display_string_end):
4413 (push_it): Accept second argument POSITION, where pop_it should
4414 jump to continue iteration.
4415 (reseat_1): Initialize bidi_it.disp_pos.
4417 * keyboard.c (adjust_point_for_property): Adjust the call to
4418 display_prop_intangible_p to its new signature.
4420 * dispextern.h (struct bidi_it): New member frame_window_p.
4421 (bidi_init_it): Update prototypes.
4422 (display_prop_intangible_p): Update prototype.
4423 (compute_display_string_pos, compute_display_string_end):
4425 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4428 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4430 Malloc failure behavior now depends on size of allocation.
4431 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4432 * lisp.h: Change signatures accordingly.
4433 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4434 All callers changed. (Bug#8762)
4436 * gnutls.c: Use Emacs's memory allocators.
4437 Without this change, the gnutls library would invoke malloc etc.
4438 directly, which causes problems on non-SYNC_INPUT hosts, and which
4439 runs afoul of improving memory_full behavior. (Bug#8761)
4440 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4441 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4442 xfree instead of the default malloc, realloc, free.
4443 (Fgnutls_boot): No need to check for memory allocation failure,
4444 since xmalloc does that for us.
4446 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4447 * category.c (hash_get_category_set):
4448 * ccl.c (ccl_driver):
4449 * charset.c (Fdefine_charset_internal):
4450 * charset.h (struct charset.hash_index):
4451 * composite.c (get_composition_id, gstring_lookup_cache)
4452 (composition_gstring_put_cache):
4453 * composite.h (struct composition.hash_index):
4454 * dispextern.h (struct image.hash):
4455 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4456 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4457 (hashfn_equal, hashfn_user_defined, make_hash_table)
4458 (maybe_resize_hash_table, hash_lookup, hash_put)
4459 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4460 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4461 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4462 * image.c (make_image, search_image_cache, lookup_image)
4463 (xpm_put_color_table_h):
4464 * lisp.h (struct Lisp_Hash_Table):
4465 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4466 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4467 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4468 * alloc.c (allocate_vectorlike):
4469 Check for overflow in vector size calculations.
4470 * ccl.c (ccl_driver):
4471 Check for overflow when converting EMACS_INT to int.
4472 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4473 need to be updated by these changes.
4474 * fns.c (make_hash_table, maybe_resize_hash_table):
4475 Check for integer overflow with large hash tables.
4476 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4477 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4478 (SXHASH_REDUCE): New macro.
4479 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4480 Use it instead of discarding useful hash info with large hash values.
4481 (sxhash_float): New function.
4482 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4483 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4484 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4485 Rewrite to use FIXNUM_BITS, as this simplifies things.
4486 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4487 Adjust signatures to match updated version of code.
4488 (consing_since_gc): Now EMACS_INT, since a single hash table can
4489 use more than INT_MAX bytes.
4491 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4493 Make it possible to build with GCC-4.6+ -O2 -flto.
4495 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4497 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4499 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4500 Call minibuffer-inactive-mode.
4502 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4504 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4505 Update dependencies.
4507 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4509 * data.c (init_data): Remove code for UTS, this system is not
4512 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4514 Don't force ./temacs to start in terminal mode.
4516 * frame.c (make_initial_frame): Initialize faces in all cases, not
4517 only when CANNOT_DUMP is defined.
4518 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4520 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4522 * dispnew.c (add_window_display_history): Use const for the string
4523 pointer. Remove declaration, not needed.
4525 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4527 Use 'inline', not 'INLINE'.
4528 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4529 * alloc.c, fontset.c (INLINE): Remove.
4530 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4531 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4532 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4533 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4534 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4536 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4538 Make it possible to run ./temacs.
4540 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4541 syms_of_callproc does the same thing. Remove test for
4542 "initialized", do it in the caller.
4543 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4545 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4547 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4548 (read_minibuf): Use get_minibuffer.
4549 (syms_of_minibuf): Use DEFSYM.
4550 (Qmetadata): New var.
4551 * data.c (Qbuffer): Don't make it static.
4552 (syms_of_data): Use DEFSYM.
4554 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4556 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4557 (CCL_CODE_MIN): New macro.
4559 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4561 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4563 * eval.c (Qdebug): Now static.
4564 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4565 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4566 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4568 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4570 * image.c: Various fixes to ImageMagick code comments.
4571 (Fimagemagick_types): Doc fix.
4573 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4575 Minor fixes prompted by GCC 4.6.0 warnings.
4577 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4579 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4580 (x_clipboard_manager_save_all): Move extern decl to ...
4581 * xterm.h: ... here, so that it can be checked for consistency.
4583 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4585 * xselect.c (x_clipboard_manager_save_frame)
4586 (x_clipboard_manager_save_all): New functions.
4587 (Fx_clipboard_manager_save): Lisp function deleted.
4589 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4590 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4592 * xterm.h: Update prototype.
4594 2011-05-28 William Xu <william.xwl@gmail.com>
4596 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4599 2011-05-28 Jim Meyering <meyering@redhat.com>
4601 Avoid a sign-extension bug in crypto_hash_function.
4602 * fns.c (to_uchar): Define.
4603 (crypto_hash_function): Use it to convert some newly-signed
4604 variables to unsigned, to avoid sign-extension bugs. For example,
4605 without this change, (md5 "truc") would evaluate to
4606 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4607 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4608 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4610 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4612 Integer overflow fixes.
4614 * dbusbind.c: Serial number integer overflow fixes.
4615 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4616 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4617 to hold a serial number that is too large for a fixnum.
4618 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4619 Check for serial numbers out of range. Decode any serial number
4620 that was so large that it became a float. (Bug#8722)
4622 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4623 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4624 Use XFASTINT rather than XUINT when numbers are nonnegative.
4625 (xd_append_arg, Fdbus_method_return_internal):
4626 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4627 arguments, check that Lisp number is nonnegative, rather than
4628 silently wrapping negative numbers around. (Bug#8722)
4629 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4632 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4634 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4636 ccl: add integer overflow checks
4637 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4638 (IN_INT_RANGE): New macros.
4639 (ccl_driver): Use them to check for integer overflow when
4640 decoding a CCL program. Many of the new checks are whether XINT (x)
4641 fits in int; it doesn't always, on 64-bit hosts. The new version
4642 doesn't catch all possible integer overflows, but it's an
4643 improvement. (Bug#8719)
4645 * alloc.c (make_event_array): Use XINT, not XUINT.
4646 There's no need for unsigned here.
4648 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4649 This follows up to the 2011-05-06 change that substituted uintptr_t
4650 for EMACS_INT. This case wasn't caught back then.
4652 Rework Fformat to avoid integer overflow issues.
4653 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4654 now (part of C89). Include <verify.h>.
4655 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4656 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4657 (Fformat): Avoid the prepass trying to compute sizes; it was only
4658 approximate and thus did not catch overflow reliably. Instead, walk
4659 through the format just once, formatting and computing sizes as we go,
4660 checking for integer overflow at every step, and allocating a larger
4661 buffer as needed. Keep track separately whether the format is
4662 multibyte. Keep only the most-recently calculated precision, rather
4663 than them all. Record whether each argument has been converted to
4664 string. Use EMACS_INT, not int, for byte and char and arg counts.
4665 Support field widths and precisions larger than INT_MAX. Avoid
4666 sprintf's undefined behavior with conversion specifications such as %#d
4667 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4668 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4669 formatting out-of-range floating point numbers with int
4672 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4674 * data.c: Avoid integer truncation in expressions involving floats.
4675 * data.c: Include <intprops.h>.
4676 (arith_driver): When there's an integer overflow in an expression
4677 involving floating point, convert the integers to floating point
4678 so that the resulting value does not suffer from catastrophic
4679 integer truncation. For example, on a 64-bit host (* 4
4680 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4681 Do not rely on undefined behavior after integer overflow.
4683 merge count_size_as_multibyte, parse_str_to_multibyte
4684 * character.c, character.h (count_size_as_multibyte):
4685 Rename from parse_str_to_multibyte; all uses changed.
4686 Check for integer overflow.
4687 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4688 since it's now a duplicate of the other. This is more of
4689 a character than a buffer op, so better that it's in character.c.
4690 * fns.c, print.c: Adjust to above changes.
4692 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4694 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4696 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4698 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4699 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4700 (x_clipboard_manager_save): Now static.
4701 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4703 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4704 (crypto_hash_function): Now static.
4705 Fix pointer signedness problems. Avoid unnecessary initializations.
4707 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4709 * termhooks.h (Vselection_alist): Make it terminal-local.
4711 * terminal.c (create_terminal): Initialize it.
4713 * xselect.c: Support for clipboard managers.
4714 (Vselection_alist): Move to termhooks.h as terminal-local var.
4715 (LOCAL_SELECTION): New macro.
4716 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4717 (symbol_to_x_atom): Remove gratuitous arg.
4718 (x_handle_selection_request, lisp_data_to_selection_data)
4719 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4720 (x_own_selection, x_get_local_selection, x_convert_selection):
4721 New arg, specifying work frame. Use terminal-local Vselection_alist.
4722 (some_frame_on_display): Delete unused function.
4723 (Fx_own_selection_internal, Fx_get_selection_internal)
4724 (Fx_disown_selection_internal, Fx_selection_owner_p)
4725 (Fx_selection_exists_p): New optional frame arg.
4726 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4727 (x_handle_selection_clear): Don't treat other terminals with the
4728 same keyboard specially. Use the terminal-local Vselection_alist.
4729 (x_clear_frame_selections): Use Frun_hook_with_args.
4731 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4733 * xterm.h: Add support for those atoms.
4735 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4737 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4738 (converted_selections, conversion_fail_tag): New global variables.
4739 (x_selection_request_lisp_error): Free the above.
4740 (x_get_local_selection): Remove unnecessary code.
4741 (x_reply_selection_request): Args changed; handle arbitrary array
4742 of converted selections stored in converted_selections.
4743 Separate the XChangeProperty and SelectionNotify steps.
4744 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4745 (x_convert_selection): New function.
4746 (x_handle_selection_event): Simplify.
4747 (x_get_foreign_selection): Don't ignore incoming requests while
4748 waiting for an answer; this will fail when we implement
4749 SAVE_TARGETS, and seems unnecessary anyway.
4750 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4751 (Vx_sent_selection_functions): Doc fix.
4753 2011-05-26 Leo Liu <sdl.web@gmail.com>
4755 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4757 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4759 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4761 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4762 for fringe update if it has periodic bitmap.
4763 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4764 and fringe_bitmap_periodic_p.
4766 * fringe.c (get_fringe_bitmap_data): New function.
4767 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4768 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4769 row. Mark glyph row for fringe update if periodicity changed.
4771 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4772 for fringe update unless it has periodic bitmap.
4774 2011-05-25 Kenichi Handa <handa@m17n.org>
4776 * xdisp.c (get_next_display_element): Set correct it->face_id for
4777 a static composition.
4779 2011-05-24 Leo Liu <sdl.web@gmail.com>
4782 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4784 * fns.c (crypto_hash_function, Fsha1): New function.
4785 (Fmd5): Use crypto_hash_function.
4786 (syms_of_fns): Add Ssha1.
4788 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4790 * gnutls.c: Remove unused macros.
4791 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4792 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4793 Remove macros that are defined and never used.
4794 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4796 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4798 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4799 (Fx_get_selection_internal): Minor cleanup.
4800 (Fx_own_selection_internal): Rename arguments for consistency with
4803 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4805 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4807 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4809 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4811 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4813 * dispnew.c (scrolling_window): Don't exclude the case that the
4814 last enabled row in the desired matrix touches the bottom boundary.
4816 2011-05-21 Glenn Morris <rgm@gnu.org>
4818 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4819 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4820 and add some more files.
4822 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4824 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4825 report_file_error introduced by the change from 2011-05-07.
4827 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4829 * systime.h (Time): Define only if emacs is defined.
4830 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4831 where the include path doesn't have X11/X.h by default. See
4832 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4834 2011-05-20 Kenichi Handa <handa@m17n.org>
4836 * composite.c (find_automatic_composition): Fix previous change.
4838 2011-05-20 Glenn Morris <rgm@gnu.org>
4840 * lisp.mk: New file, split from Makefile.in.
4841 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4842 (shortlisp): Remove.
4843 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4845 2011-05-19 Glenn Morris <rgm@gnu.org>
4847 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4848 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4849 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4850 (lisp): Set the order to that of loadup.el.
4851 (shortlisp): Make it a copy of $lisp.
4852 (SOME_MACHINE_LISP): Remove.
4853 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4854 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4856 2011-05-18 Kenichi Handa <handa@m17n.org>
4858 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4859 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4860 (find_automatic_composition): Mostly rewrite for efficiency.
4862 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4864 * makefile.w32-in: Update dependencies.
4866 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4868 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4869 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4871 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4873 Fix some integer overflow issues, such as string length overflow.
4875 * insdel.c (count_size_as_multibyte): Check for string overflow.
4877 * character.c (lisp_string_width): Check for string overflow.
4878 Use EMACS_INT, not int, for string indexes and lengths; in
4879 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4880 the resulting string length overflows an EMACS_INT; instead,
4881 report a string overflow if no precision given. When checking for
4882 precision exhaustion, use a check that cannot possibly have
4883 integer overflow. (Bug#8675)
4884 * character.h (lisp_string_width): Adjust to new signature.
4886 * alloc.c (string_overflow): New function.
4887 (Fmake_string): Use it. This doesn't change behavior, but saves
4888 a few bytes and will simplify future changes.
4889 * character.c (string_escape_byte8): Likewise.
4890 * lisp.h (string_overflow): New decl.
4892 Fixups, following up to the user-interface timestamp change.
4893 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4894 for UI timestamps, instead of unsigned long.
4895 * msdos.c (mouse_get_pos): Likewise.
4896 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4897 * w32gui.h (Time): Define by including "systime.h" rather than by
4898 declaring it ourselves. (Bug#8664)
4900 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4901 * image.c (clear_image_cache): Likewise.
4903 * term.c (term_mouse_position): Don't assume time_t wraparound.
4905 Be more systematic about user-interface timestamps.
4906 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4907 and sometimes 'EMACS_UINT', to represent these timestamps.
4908 This change causes it to use 'Time' uniformly, as that's what X uses.
4909 This makes the code easier to follow, and makes it easier to catch
4910 integer overflow bugs such as Bug#8664.
4911 * frame.c (Fmouse_position, Fmouse_pixel_position):
4912 Use Time, not unsigned long, for user-interface timestamps.
4913 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4914 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4915 * keyboard.h (last_event_timestamp): Likewise.
4916 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4917 * menu.h (xmenu_show): Likewise.
4918 * term.c (term_mouse_position): Likewise.
4919 * termhooks.h (struct input_event.timestamp): Likewise.
4920 (struct terminal.mouse_position_hook): Likewise.
4921 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4922 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4923 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4924 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4926 * menu.h, termhooks.h: Include "systime.h", for Time.
4928 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4929 Don't assume that the difference between two unsigned long values
4930 can fit into an integer. At this point, we know button_down_time
4931 <= event->timestamp, so the difference must be nonnegative, so
4932 there's no need to cast the result if double-click-time is
4933 nonnegative, as it should be; check that it's nonnegative, just in
4934 case. This bug is triggered when events are more than 2**31 ms
4935 apart (about 25 days). (Bug#8664)
4937 * xselect.c (last_event_timestamp): Remove duplicate decl.
4938 (x_own_selection): Remove needless cast to unsigned long.
4940 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4941 that always fit in int. Use a sentinel instead of a counter, to
4942 avoid a temp and to allay GCC's concerns about possible int overflow.
4943 * frame.h (struct frame): Use int for menu_bar_items_used
4944 instead of EMACS_INT, since it always fits in int.
4946 * menu.c (grow_menu_items): Check for int overflow.
4948 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4950 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4951 Before, the code was not consistent. These values cannot exceed
4952 2**31 - 1 so there's no need to make them unsigned.
4953 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4954 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4955 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4957 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4959 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4960 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4961 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4962 presumably because the widths might not match.
4964 * window.c (size_window): Avoid needless test at loop start.
4966 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4968 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4970 2011-05-12 Drew Adams <drew.adams@oracle.com>
4972 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4974 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4976 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4977 `width' to `bar_area_x' and `bar_area_width', respectively.
4978 (x_scroll_run): Take account of fringe background extension.
4980 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4981 Rename local vars `left' and `width' to `bar_area_x' and
4982 `bar_area_width', respectively.
4983 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4984 background extension.
4986 2011-05-10 Jim Meyering <meyering@redhat.com>
4988 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4990 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4992 * image.c (Finit_image_library): Return t for built-in image types,
4993 like pbm and xbm. (Bug#8640)
4995 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4997 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4999 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5001 * w32console.c (Fset_screen_color): Doc fix.
5002 (Fget_screen_color): New function.
5003 (syms_of_ntterm): Defsubr it.
5005 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5006 unlink the temporary file if Fcall_process didn't create it in the
5008 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5009 child process will be redirected to a file specified with `:file'.
5010 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5011 cue to call_process_cleanup not to close that handle.
5013 2011-05-07 Ben Key <bkey76@gmail.com>
5015 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5016 one of two shell specific rules, either bootstrap-temacs-CMD or
5017 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5018 to the previous implementation of the bootstrap-temacs rule.
5019 The bootstrap-temacs-CMD rule is similar to the previous
5020 implementation of the bootstrap-temacs rule except that it
5021 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5024 These changes, along with some changes to nt/configure.bat,
5025 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5026 earlier fix to add support for --cflags and --ldflags options
5027 that include quotes so that it works whether make uses cmd or
5030 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5032 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5033 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5035 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5036 a string. Handle both cases.
5037 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5038 (Fdbus_register_method): Use Qinvalid_function.
5040 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5042 * makefile.w32-in: Update dependencies.
5043 (LISP_H): Add inttypes.h and stdin.h.
5044 (PROCESS_H): Add unistd.h.
5046 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5048 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5049 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5051 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5053 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5055 * term.c (vfatal): Remove stray call to va_end.
5056 It's not needed and the C Standard doesn't allow it here anyway.
5058 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5059 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5061 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5064 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5066 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5068 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5070 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5072 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5074 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5075 * charset.c (Fdefine_charset_internal): Don't initialize
5076 charset.code_space[15]. The value was garbage, on hosts with
5077 32-bit int (Bug#8600).
5079 * lread.c (read_integer): Be more consistent with string-to-number.
5080 Use string_to_number to do the actual conversion; this avoids
5081 rounding errors and fixes some other screwups. Without this fix,
5082 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5083 (digit_to_number): Move earlier, for benefit of read_integer.
5084 Return -1 if the digit is out of range for the base, -2 if it is
5085 not a digit in any supported base. (Bug#8602)
5087 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5089 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5090 to match comment at start of function. This also removes a
5091 GCC warning about overflow in a 32+64-bit port.
5093 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5095 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5096 Reported by Stefan Monnier in
5097 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
5098 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5099 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
5101 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5102 (EMACS_UINTPTR): Likewise, with uintptr_t.
5104 * lisp.h: Prefer 64-bit EMACS_INT if available.
5105 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5106 on 32-bit hosts that have 64-bit int, so that they can access
5108 However, temporarily disable this change unless the temporary
5109 symbol WIDE_EMACS_INT is defined.
5111 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5113 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5114 This removes an assumption that EMACS_INT and long are the same
5115 width as pointers. The assumption is true for Emacs porting targets
5116 now, but we want to make other targets possible.
5117 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5118 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5119 In the rest of the code, change types of integers that hold casted
5120 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5121 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5122 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5123 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5124 No need to cast type when ORing.
5125 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5126 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5127 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5128 assume EMACS_INT is the same width as char *.
5129 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5130 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5131 Remove no-longer-needed casts.
5132 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5133 (xg_tool_bar_help_callback, xg_make_tool_item):
5134 Use EMACS_INTPTR to hold an integer
5135 that will be cast to void *; this can avoid a GCC warning
5136 if EMACS_INT is not the same width as void *.
5137 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5138 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5139 (current_message_1, set_message_1):
5140 Use a local to convert to proper width without a cast.
5141 * xmenu.c (dialog_selection_callback): Likewise.
5143 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5144 Also, don't assume VALBITS / RAND_BITS is less than 5,
5145 and don't rely on undefined behavior when shifting a 1 left into
5147 * lisp.h (get_random): Change signature to match.
5149 * lread.c (hash_string): Use size_t, not int, for hash computation.
5150 Normally we prefer signed values; but hashing is special, because
5151 it's better to use unsigned division on hash table sizes so that
5152 the remainder is nonnegative. Also, size_t is the natural width
5153 for hashing into memory. The previous code used 'int', which doesn't
5154 retain enough info to hash well into very large tables.
5155 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5157 * dbusbind.c: Don't possibly lose pointer info when converting.
5158 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5159 Use XPNTR rather than XHASH, so that the high-order bits of
5160 the pointer aren't lost when converting through void *.
5162 * eval.c (Fautoload): Don't double-shift a pointer.
5164 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5166 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5168 * gnutls.c (DEF_GNUTLS_FN):
5169 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5171 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5173 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5176 2011-05-05 Eli Zaretskii <eliz@gnu.org>
5178 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5179 New version that can reserve upto 2GB of heap space.
5181 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
5183 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5185 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5187 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5188 `gnutls_certificate_set_x509_key_file'.
5190 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
5192 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5193 Update dependencies.
5195 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5197 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5198 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5199 Remove unused parameter `fildes'.
5200 * process.c (read_process_output, send_process): Don't pass it.
5202 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5204 Fix previous change: the library cache is defined in w32.c.
5205 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5206 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5208 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5210 Implement dynamic loading of GnuTLS on Windows.
5212 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5213 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5214 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5217 * gnutls.c (Qgnutls_dll): Define.
5218 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5219 (gnutls_*): Declare function pointers.
5220 (init_gnutls_functions): New function to initialize function pointers.
5221 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5222 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5223 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5224 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5225 (emacs_gnutls_write, emacs_gnutls_read)
5226 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5227 (Fgnutls_available_p): New function.
5228 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5229 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5230 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5232 * image.c: Include w32.h.
5233 (Vimage_type_cache): Delete.
5234 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5235 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5236 (w32_delayed_load): Move to w32.c.
5238 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5240 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5241 (w32_delayed_load): Move from image.c. When loading a library, record
5242 its filename in the :loaded-from property of the library id.
5243 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5244 Initialize and staticpro them.
5245 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5247 * process.c: Include lisp.h before w32.h, not after.
5248 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5249 instead of gnutls_record_check_pending.
5251 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5253 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5255 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5256 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5259 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5261 * xterm.c (x_set_frame_alpha): Do not set property on anything
5262 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5264 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5266 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5268 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5270 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5271 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5272 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5273 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5274 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5275 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5276 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5277 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5278 (Qgnutls_bootprop_callbacks_verify): Make static.
5280 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5282 * callproc.c: Indentation fixup.
5284 * sysdep.c (wait_for_termination_1): Make static.
5285 (wait_for_termination, interruptible_wait_for_termination):
5286 Move after wait_for_termination_1.
5288 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5290 * sysdep.c (interruptible_wait_for_termination): New function
5291 which is like wait_for_termination, but allows keyboard
5294 * callproc.c (Fcall_process): Add (:file "file") as an option for
5296 (Fcall_process_region): Ditto.
5298 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5300 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5301 rather than `XVECTOR (FOO)->size'.
5303 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5304 inttypes.h, as a gnulib replacement is used if it not available in
5307 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5309 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5310 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5311 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5313 * coding.c (coding_alloc_by_realloc): Error out if destination
5314 will grow beyond MOST_POSITIVE_FIXNUM.
5315 (decode_coding_emacs_mule): Abort if there isn't enough place in
5316 charbuf for the composition carryover bytes. Reserve an extra
5317 space for up to 2 characters produced in a loop.
5318 (decode_coding_iso_2022): Abort if there isn't enough place in
5319 charbuf for the composition carryover bytes.
5321 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5323 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5324 aborting when %lld or %lll format is passed.
5325 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5326 %llo or %llx format is passed. (Bug#8545)
5328 * window.c (window_scroll_line_based): Use a marker instead of
5329 simple variables to record original value of point. (Bug#7952)
5331 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5332 produced by %s or %c overflows available buffer space. (Bug#8545)
5334 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5336 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5337 (SIZE_MAX): Move defn after all includes, as they might #define it.
5339 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5341 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5343 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5345 * keyboard.c (Qdelayed_warnings_hook): Define.
5346 (command_loop_1): Run `delayed-warnings-hook'
5347 if Vdelayed_warnings_list is non-nil.
5348 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5349 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5351 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5353 * doprnt.c (doprnt): Don't return value smaller than the buffer
5354 size if the message was truncated. (Bug#8545).
5356 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5358 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5359 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5361 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5363 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5365 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5367 * makefile.w32-in: Update dependencies.
5369 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5371 Improve `doprnt' and its usage. (Bug#8545)
5372 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5373 `format_end'. Remove support for %l as a conversion specifier.
5374 Don't use xrealloc. Improve diagnostics when the %l size modifier
5375 is used. Update the commentary.
5377 * eval.c (verror): Simplify calculation of size_t.
5379 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5382 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5384 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5387 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5389 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5390 This makes this file independent of the recent pseudovector change.
5392 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5394 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5396 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5397 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5398 Remove unused local.
5399 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5401 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5402 GCC 4.6.0 optimizes based on type-based alias analysis.
5403 For example, if b is of type struct buffer * and v of type struct
5404 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5405 != &v->size, and therefore "v->size = 1; b->size = 2; return
5406 v->size;" must therefore return 1. This assumption is incorrect
5407 for Emacs, since it type-puns struct Lisp_Vector * with many other
5408 types. To fix this problem, this patch adds a new type struct
5409 vectorlike_header that documents the constraints on layout of vectors
5410 and pseudovectors, and helps optimizing compilers not get fooled
5411 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5412 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5413 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5415 (XSETPVECTYPE): Rewrite in terms of new macro.
5416 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5417 This is a bit clearer, and further avoids the possibility of
5418 undesirable aliasing.
5419 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5420 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5421 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5422 since Lisp_Subr is a special case (no "next" field).
5423 (ASIZE): Now uses header.size rather than size.
5424 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5425 to avoid the hassle of writing XVECTOR (foo)->header.size.
5426 (struct vectorlike_header): New type.
5427 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5428 object, to help avoid aliasing.
5429 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5430 (SUBRP): Likewise, since Lisp_Subr is a special case.
5431 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5432 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5433 (struct Lisp_Hash_Table): Combine first two members into a single
5434 struct vectorlike_header member. All uses of "size" and "next" members
5435 changed to be "header.size" and "header.next".
5436 * buffer.h (struct buffer): Likewise.
5437 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5438 * frame.h (struct frame): Likewise.
5439 * process.h (struct Lisp_Process): Likewise.
5440 * termhooks.h (struct terminal): Likewise.
5441 * window.c (struct save_window_data, struct saved_window): Likewise.
5442 * window.h (struct window): Likewise.
5443 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5444 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5445 * buffer.c (init_buffer_once): Likewise.
5446 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5448 * process.c (Fformat_network_address): Use local var for size,
5451 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5453 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5454 * data.c (atof): Remove decl; no longer used or needed.
5455 (digit_to_number): Move to lread.c.
5456 (Fstring_to_number): Use new string_to_number function, to be
5457 consistent with how the Lisp reader treats infinities and NaNs.
5458 Do not assume that floating-point numbers represent EMACS_INT
5459 without losing information; this is not true on most 64-bit hosts.
5460 Avoid double-rounding errors, by insisting on integers when
5461 parsing non-base-10 numbers, as the documentation specifies.
5462 * lisp.h (string_to_number): New decl, replacing ...
5463 (isfloat_string): Remove.
5464 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5465 (read1): Do not accept +. and -. as integers; this
5466 appears to have been a coding error. Similarly, do not accept
5467 strings like +-1e0 as floating point numbers. Do not report
5468 overflow for integer overflows unless the base is not 10 which
5469 means we have no simple and reliable way to continue.
5470 Break out the floating-point parsing into a new
5471 function string_to_number, so that Fstring_to_number parses
5472 floating point numbers consistently with the Lisp reader.
5473 (digit_to_number): Move here from data.c. Make it static inline.
5474 (E_CHAR, EXP_INT): Remove, replacing with ...
5475 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5476 (string_to_number): New function, replacing isfloat_string.
5477 This function checks for valid syntax and produces the resulting
5478 Lisp float number too. Rework it so that string-to-number
5479 no longer mishandles examples like "1.0e+". Use strtoumax,
5480 so that overflow for non-base-10 numbers is reported only when
5481 there's no portable and simple way to convert to floating point.
5483 * textprop.c (set_text_properties_1): Rewrite for clarity,
5484 and to avoid GCC warning about integer overflow.
5486 * intervals.h (struct interval): Use EMACS_INT for members
5487 where EMACS_UINT might cause problems. See
5488 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5489 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5490 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5492 (offset_intervals): Tell GCC not to worry about length overflow
5493 when negating a negative length.
5495 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5496 (overrun_check_free): Likewise.
5498 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5499 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5502 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5503 (gnutls_make_error): Rename local to avoid shadowing.
5504 (gnutls_emacs_global_deinit): ifdef out; not used.
5505 (Fgnutls_boot): Use const for pointer to readonly storage.
5506 Comment out unused local. Fix pointer signedness problems.
5508 * lread.c (openp): Don't stuff size_t into an 'int'.
5509 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5510 about possible signed overflow.
5512 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5513 (GDK_KEY_g): Don't define if already defined.
5514 (xg_prepare_tooltip): Avoid pointer signedness problem.
5515 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5517 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5518 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5520 * xfns.c (Fx_window_property): Simplify a bit,
5521 to make a bit faster and to avoid GCC 4.6.0 warning.
5522 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5524 * fns.c (internal_equal): Don't assume size_t fits in int.
5526 * alloc.c (compact_small_strings): Tighten assertion a little.
5528 Replace pEd with more-general pI, and fix some printf arg casts.
5529 * lisp.h (pI): New macro, generalizing old pEd macro to other
5530 conversion specifiers. For example, use "...%"pI"d..." rather
5531 than "...%"pEd"...".
5532 (pEd): Remove. All uses replaced with similar uses of pI.
5533 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5534 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5535 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5536 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5537 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5538 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5539 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5541 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5542 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5543 * print.c (safe_debug_print, print_object): Likewise.
5544 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5546 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5547 avoiding the 0 flag, which is not portable.
5548 * process.c (Fmake_network_process): Use pI to avoid cast.
5549 * region-cache.c (pp_cache): Likewise.
5550 * xdisp.c (decode_mode_spec): Likewise.
5551 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5552 behavior on 64-bit hosts with printf arg.
5553 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5554 (x_stop_queuing_selection_requests): Likewise.
5555 (x_get_window_property): Don't truncate byte count to an 'int'
5558 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5559 here, since it parses constructs like leading '-' and spaces,
5560 which are not wanted; and it overflows with large numbers.
5561 Instead, simply match F[0-9]+, which is what is wanted anyway.
5563 * alloc.c: Remove unportable assumptions about struct layout.
5564 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5565 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5566 (allocate_vectorlike, make_pure_vector): Use the new macros,
5567 plus offsetof, to remove unportable assumptions about struct layout.
5568 These assumptions hold on all porting targets that I know of, but
5569 they are not guaranteed, they're easy to remove, and removing them
5570 makes further changes easier.
5572 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5573 This doesn't fix a bug but makes the code clearer.
5574 (string_overrun_cookie): Now const. Use initializers that
5575 don't formally overflow signed char, to avoid warnings.
5576 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5577 can cause Emacs to crash when string overrun checking is enabled.
5578 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5579 multiple of sizeof (EMACS_INT); it need not be, if
5580 alignof(EMACS_INT) < sizeof (EMACS_INT).
5581 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5583 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5585 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5587 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5589 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5590 supposed to be handshaking. (Bug#8556)
5591 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5593 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5595 * lisp.h (Qdebug): List symbol.
5596 * eval.c (Qdebug): Restore global linkage.
5597 * keyboard.c (debug-on-event): New variable.
5598 (handle_user_signal): Break into debugger when debug-on-event
5599 matches the current signal symbol.
5601 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5603 * alloc.c (check_sblock, check_string_bytes)
5604 (check_string_free_list): Convert to standard C.
5606 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5608 * w32.c (emacs_gnutls_push): Fix typo.
5610 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5612 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5613 "cast to pointer from integer of different size".
5615 Improve doprnt and its use in verror. (Bug#8545)
5616 * doprnt.c (doprnt): Document the set of format control sequences
5617 supported by the function. Use SAFE_ALLOCA instead of always
5620 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5621 is one byte too soon. Don't use xrealloc; instead xfree and
5624 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5626 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5629 * gnutls.c: Renamed global_initialized to
5630 gnutls_global_initialized. Added internals for the
5631 :verify-hostname-error, :verify-error, and :verify-flags
5632 parameters of `gnutls-boot' and documented those parameters in the
5633 docstring. Start callback support.
5634 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5635 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5636 on error. Return error code.
5637 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5638 (emacs_gnutls_read): Likewise.
5639 (Fgnutls_boot): Return handshake error code.
5640 (emacs_gnutls_handle_error): New function.
5641 (wsaerror_to_errno): Likewise.
5643 * w32.h (emacs_gnutls_pull): Add prototype.
5644 (emacs_gnutls_push): Likewise.
5646 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5647 (emacs_gnutls_push): Likewise.
5649 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5651 * process.c (wait_reading_process_output): Check if GnuTLS
5652 buffered some data internally if no FDs are set for TLS
5655 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5656 (LIBS): Link to USER_LIBS.
5657 ($(BLD)/gnutls.$(0)): New target.
5659 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5661 * xdisp.c (handle_single_display_spec): Rename the
5662 display_replaced_before_p argument into display_replaced_p, to
5663 make it consistent with the commentary. Fix typos in the
5666 * textprop.c (syms_of_textprop): Remove dead code.
5667 (copy_text_properties): Delete obsolete commentary about an
5668 interface that was deleted long ago. Fix typos in the description
5671 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5672 to changes in oldXMenu/XMenu.h from 2011-04-16.
5673 <menu_help_message, prev_menu_help_message>: Constify.
5674 (IT_menu_make_room): menu->help_text is now `const char **';
5677 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5678 to changes in oldXMenu/XMenu.h from 2011-04-16.
5679 (struct XMenu): Declare `help_text' `const char **'.
5681 * xfaces.c <Qunspecified>: Make extern again.
5683 * syntax.c: Include sys/types.h before including regex.h, as
5686 * doc.c (get_doc_string): Improve the format passed to `error'.
5688 * doprnt.c (doprnt): Improve commentary.
5690 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5692 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5695 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5696 changes in globals.h immediately force recompilation.
5697 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5698 $(CURDIR)/s/ms-w32.h.
5699 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5701 * character.c (Fchar_direction): Function deleted.
5702 (syms_of_character): Don't defsubr it.
5703 <char-direction-table>: Deleted.
5705 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5707 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5708 * doprnt.c: Include limits.h.
5709 (SIZE_MAX): New macro.
5710 (doprnt): Return a size_t value. 2nd arg is now size_t.
5711 Many local variables are now size_t instead of int or unsigned.
5712 Improve overflow protection. Support `l' modifier for integer
5713 conversions. Support %l conversion. Don't assume an EMACS_INT
5714 argument for integer conversions and for %c.
5716 * lisp.h (doprnt): Restore prototype.
5718 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5721 * Makefile.in (base_obj): Add back doprnt.o.
5723 * deps.mk (doprnt.o): Add back prerequisites.
5724 (callint.o): Depend on character.h.
5726 * eval.c (internal_lisp_condition_case): Include the handler
5727 representation in the error message.
5728 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5729 when breaking from the loop.
5731 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5733 * callint.c (Fcall_interactively): When displaying error message
5734 about invalid control letter, pass the character's codepoint, not
5735 a pointer to its multibyte form. Improve display of the character
5736 in octal and display also its hex code.
5738 * character.c (char_string): Use %x to display the (unsigned)
5739 codepoint of an invalid character, to avoid displaying a bogus
5742 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5743 `error', not SYMBOL_NAME itself.
5745 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5746 character arguments to `error'.
5748 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5749 to `error' in error message about FINAL_CHAR argument. Make sure
5750 FINAL_CHAR is a character, and use %c when it is passed as
5751 argument to `error'.
5753 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5755 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5757 * w32.c: Include <time.h>.
5758 (sys_localtime): New function.
5760 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5762 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5764 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5766 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5768 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5771 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5773 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5774 gl_state.e_property when gl_state.object is Qt.
5776 * insdel.c (make_gap_larger): Remove limitation of buffer size
5779 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5781 * xdisp.c (lookup_glyphless_char_display)
5782 (produce_glyphless_glyph): Handle cons cell entry in
5783 glyphless-char-display.
5784 (Vglyphless_char_display): Document it.
5786 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5787 glyphless-char-display.
5789 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5791 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5793 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5795 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5796 definition for no-X builds.
5798 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5800 Static checks with GCC 4.6.0 and non-default toolkits.
5802 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5804 * process.c (keyboard_bit_set): Define only if SIGIO.
5805 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5806 (send_process): Repair possible setjmp clobbering.
5808 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5810 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5812 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5814 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5815 Define only if needed.
5817 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5818 by pacifying GCC about it. Maybe it's time to retire it?
5819 * xfaces.c (USG, __TIMEVAL__): Likewise.
5821 * dispextern.h (struct redisplay_interface): Rename param
5823 * termhooks.h (struct terminal): Likewise.
5824 * xterm.c (xembed_send_message): Likewise.
5826 * insdel.c (make_gap_smaller): Define only if
5827 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5829 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5832 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5833 so that we aren't warned about unused symbols.
5835 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5837 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5839 * xfns.c (x_real_positions): Mark locals as initialized.
5841 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5843 * xterm.c: Fix problems found by static analysis with other toolkits.
5844 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5845 (x_dispatch_event): Declare static if USE_GTK, and
5846 define if USE_GTK || USE_X_TOOLKIT.
5847 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5848 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5849 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5850 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5852 * xmenu.c (menu_help_callback): Pointer type fixes.
5853 Use const pointers when pointing at readonly data. Avoid pointer
5855 (FALSE): Remove unused macro.
5856 (update_frame_menubar): Remove unused decl.
5858 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5860 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5861 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5862 (single_menu_item): Rename local to avoid shadowing.
5864 * keyboard.c (make_lispy_event): Remove unused local var.
5866 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5867 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5869 * bitmaps: Change bitmaps from unsigned char back to the X11
5870 compatible char. Avoid the old compiler warnings about
5871 out-of-range initializers by using, for example, '\xab' rather
5874 * xgselect.c (xgselect_initialize): Check vs interface
5875 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5877 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5879 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5880 to read-only memory.
5882 * fns.c (vector): Remove; this old hack is no longer needed.
5884 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5886 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5888 * xrdb.c (x_load_resources): Omit unused local.
5890 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5891 (x_window): Rename locals to avoid shadowing.
5892 (USG): Use the kludged USG macro, to pacify gcc.
5894 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5895 (x_term_init): Remove local to avoid shadowing.
5897 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5899 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5900 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5902 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5904 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5906 Fix regex.c, syntax.c and friends for buffers > 2GB.
5907 * syntax.h (struct gl_state_s): Declare character position members
5910 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5912 * textprop.c (verify_interval_modification, interval_of):
5913 Declare arguments EMACS_INT.
5915 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5918 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5920 * indent.c (Fvertical_motion): Local variable it_start is now
5923 * regex.c (re_match, re_match_2, re_match_2_internal)
5924 (bcmp_translate, regcomp, regexec, print_double_string)
5925 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5926 (re_compile_pattern, re_exec): Declare arguments and local
5927 variables `size_t' and `ssize_t' and return values `regoff_t', as
5929 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5930 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5931 <compile_stack_type>: `size' and `avail' are now `size_t'.
5933 * regex.h <regoff_t>: Use ssize_t, not int.
5934 (re_search, re_search_2, re_match, re_match_2): Arguments that
5935 specify buffer/string position and length are now ssize_t and
5936 size_t. Return type is regoff_t.
5938 2011-04-16 Ben Key <bkey76@gmail.com>
5940 * nsfont.m: Fixed bugs in ns_get_family and
5941 ns_descriptor_to_entity that were caused by using free to
5942 deallocate memory blocks that were allocated by xmalloc (via
5943 xstrdup). This caused Emacs to crash when compiled with
5944 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5945 --enable-checking=xmallocoverrun). xfree is now used to
5946 deallocate these memory blocks.
5948 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5950 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5952 emacs_write: Accept and return EMACS_INT for sizes.
5953 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5955 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5956 Accept and return EMACS_INT.
5957 (emacs_gnutls_write): Return the number of bytes written on
5959 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5960 (emacs_read, emacs_write): Remove check for negative size, as the
5961 Emacs source code has been audited now.
5962 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5963 (emacs_read, emacs_write): Use it.
5964 * process.c (send_process): Adjust to the new signatures of
5965 emacs_write and emacs_gnutls_write. Do not attempt to store
5966 a byte offset into an 'int'; it might overflow.
5967 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5969 * sound.c: Don't assume sizes fit in 'int'.
5970 (struct sound_device.period_size, alsa_period_size):
5971 Return EMACS_INT, not int.
5972 (struct sound_device.write, vox_write, alsa_write):
5973 Accept EMACS_INT, not int.
5974 (wav_play, au_play): Use EMACS_INT to store sizes and to
5975 record read return values.
5977 2011-04-15 Ben Key <bkey76@gmail.com>
5979 * keyboard.c (Qundefined): Don't declare static since it is used
5981 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5982 static since they are used in nsfont.m.
5984 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5986 * process.c (Qprocessp): Don't declare static.
5987 * lisp.h (Qprocessp): Declare again.
5989 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5991 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5993 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5995 Improve C-level modularity by making more things 'static'.
5997 Don't publish debugger-only interfaces to other modules.
5998 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5999 (verify_bytepos, count_markers): Move decls to the only modules
6001 * region-cache.h (pp_cache): Likewise.
6002 * window.h (check_all_windows): Likewise.
6003 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6005 * sysdep.c (croak): Now static, if
6006 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6007 * syssignal.h (croak): Declare only if not static.
6009 * alloc.c (refill_memory_reserve): Now static if
6010 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6011 * lisp.h (refill_memory_reserve): Declare only if not static.
6013 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6014 Define only if USE_LUCID.
6016 * xrdb.c (x_customization_string, x_rm_string): Now static.
6018 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6019 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6021 * xdisp.c (draw_row_with_mouse_face): Now static.
6022 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6024 * window.h (check_all_windows): Mark externally visible.
6026 * window.c (window_deletion_count): Now static.
6028 * undo.c: Make symbols static if they're not exported.
6029 (last_undo_buffer, last_boundary_position, pending_boundary):
6032 * textprop.c (interval_insert_behind_hooks): Now static.
6033 (interval_insert_in_front_hooks): Likewise.
6035 * term.c: Make symbols static if they're not exported.
6036 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6037 (max_frame_lines, tty_set_terminal_modes):
6038 (tty_reset_terminal_modes, tty_turn_off_highlight):
6039 (get_tty_terminal): Now static.
6040 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6041 * termhooks.h (term_mouse_moveto): Do not declare if
6043 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6044 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6046 * sysdep.c: Make symbols static if they're not exported.
6047 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6049 (sigprocmask_set, full_mask): Remove; unused.
6050 (wait_debugging): Mark as visible.
6051 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6052 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6054 * syntax.c (syntax_temp): Define only if !__GNUC__.
6056 * sound.c (current_sound_device, current_sound): Now static.
6058 * search.c (searchbufs, searchbuf_head): Now static.
6060 * scroll.c (scroll_cost): Remove; unused.
6061 * dispextern.h (scroll_cost): Remove decl.
6063 * region-cache.h (pp_cache): Mark as externally visible.
6065 * process.c: Make symbols static if they're not exported.
6066 (process_tick, update_tick, create_process, chan_process):
6067 (Vprocess_alist, proc_buffered_char, datagram_access):
6068 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6069 (deactivate_process): Mark defn as static, as well as decl.
6070 * lisp.h (create_process): Remove decl.
6071 * process.h (chan_process, Vprocess_alist): Remove decls.
6073 * print.c: Make symbols static if they're not exported.
6074 (print_depth, new_backquote_output, being_printed, print_buffer):
6075 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6076 (print_interval, print_number_index, initial_stderr_stream):
6078 * lisp.h (Fprinc): Remove decl.
6079 (debug_output_compilation_hack): Mark as externally visible.
6081 * sysdep.c (croak): Move decl from here to syssignal.h.
6082 * syssignal.h (croak): Put it here, so the API can be checked when
6083 'croak' is called from dissociate_if_controlling_tty.
6085 * minibuf.c: Make symbols static if they're not exported.
6086 (minibuf_save_list, choose_minibuf_frame): Now static.
6087 * lisp.h (choose_minibuf_frame): Remove decl.
6089 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6091 * lread.c: Make symbols static if they're not exported.
6092 (read_objects, initial_obarray, oblookup_last_bucket_number):
6094 (make_symbol): Remove; unused.
6095 * lisp.h (initial_obarray, make_symbol): Remove decls.
6097 * keyboard.c: Make symbols static if they're not exported.
6098 (single_kboard, recent_keys_index, total_keys, recent_keys):
6099 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6100 (this_single_command_key_start, echoing, last_auto_save):
6101 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6102 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6103 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6104 (Vlispy_mouse_stem, double_click_count):
6106 (force_auto_save_soon): Define only if SIGDANGER.
6107 (ignore_mouse_drag_p): Now static if
6108 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6109 (print_help): Remove; unused.
6110 (stop_character, last_timer_event): Mark as externally visible.
6111 * keyboard.h (ignore_mouse_drag_p): Declare only if
6112 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6113 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6114 * lisp.h (echoing): Remove decl.
6115 (force_auto_save_soon): Declare only if SIGDANGER.
6116 * xdisp.c (redisplay_window): Simplify code, to make it more
6117 obvious that ignore_mouse_drag_p is not accessed if !defined
6118 USE_GTK && !defined HAVE_NS.
6120 * intervals.c: Make symbols static if they're not exported.
6121 (merge_properties_sticky, merge_interval_right, delete_interval):
6123 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6125 * insdel.c: Make symbols static if they're not exported.
6126 However, leave prepare_to_modify_buffer alone. It's never
6127 called from outside this function, but that appears to be a bug.
6128 (combine_after_change_list, combine_after_change_buffer):
6129 (adjust_after_replace, signal_before_change): Now static.
6130 (adjust_after_replace_noundo): Remove; unused.
6131 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
6132 (signal_before_change): Remove decls.
6134 * indent.c (val_compute_motion, val_vmotion): Now static.
6136 * image.c: Make symbols static if they're not exported.
6137 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6139 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6140 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6142 * fringe.c (standard_bitmaps): Now static.
6143 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6145 * frame.c: Make symbols static if they're not exported.
6146 (x_report_frame_params, make_terminal_frame): Now static.
6147 (get_frame_param): Now static, unless HAVE_NS.
6148 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6149 (x_get_resource_string): Remove; not used.
6150 * frame.h (make_terminal_frame, x_report_frame_params):
6151 (x_get_resource_string); Remove decls.
6152 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6153 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6155 * font.c, fontset.c: Make symbols static if they're not exported.
6156 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6157 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6158 * font.c (font_close_object): Now static.
6159 * font.h (font_close_object): Remove.
6160 * fontset.c (FONTSET_OBJLIST): Remove.
6161 (free_realized_fontset) #if-0 the body, which does nothing.
6162 (face_suitable_for_char_p): #if-0, as it's never called.
6163 * fontset.h (face_suitable_for_char_p): Remove decl.
6164 * xfaces.c (face_at_string_position):
6165 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
6166 since 0 is always ASCII.
6168 * fns.c (weak_hash_tables): Now static.
6170 * fileio.c: Make symbols static if they're not exported.
6171 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6172 (Vwrite_region_annotation_buffers): Now static.
6174 * eval.c: Make symbols static if they're not exported.
6175 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6176 * lisp.h (backtrace_list): Remove decl.
6178 * emacs.c: Make symbols static if they're not exported.
6179 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6180 (fatal_error_code, fatal_error_signal_hook, standard_args):
6182 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6183 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6184 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6185 * lisp.h (fatal_error_signal_hook): Remove decl.
6186 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6188 * editfns.c: Move a (normally-unused) function to its only use.
6189 * editfns.c, lisp.h (get_operating_system_release): Remove.
6190 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6191 worth the hassle of breaking this out.
6193 * xterm.c: Make symbols static if they're not exported.
6194 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6195 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6196 (x_destroy_window, x_delete_display):
6198 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6199 (x_mouse_leave): Remove; unused.
6200 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6201 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6202 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6204 (x_mouse_leave): Declare only if WINDOWSNT.
6205 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6206 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6209 * ftxfont.c: Make symbols static if they're not exported.
6210 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6212 * font.h (ftxfont_driver): Likewise.
6214 * xfns.c: Make symbols static if they're not exported.
6215 (x_last_font_name, x_display_info_for_name):
6216 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6217 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6218 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6219 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6220 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6221 (last_show_tip_args): Now static.
6222 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6223 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6224 (x_screen_planes): Remove; unused.
6225 * dispextern.h (x_screen_planes): Remove decl.
6227 * dispnew.c: Make symbols static if they're not exported.
6228 * dispextern.h (redraw_garbaged_frames, scrolling):
6229 (increment_row_positions): Remove.
6230 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6231 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6233 (redraw_garbaged_frames): Remove; unused.
6235 * xfaces.c: Make symbols static if they're not exported.
6236 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6238 * xterm.h (defined_color): Remove decls.
6239 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6240 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6241 (menu_face_changed_default, defined_color, free_realized_face):
6242 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6243 (ascii_face_of_lisp_face): Remove; unused.
6245 * xdisp.c: Make symbols static if they're not exported.
6246 * dispextern.h (scratch_glyph_row, window_box_edges):
6247 (glyph_to_pixel_coords, set_cursor_from_row):
6248 (get_next_display_element, set_iterator_to_next):
6249 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6250 (show_mouse_face): Remove decls
6251 * frame.h (message_buf_print): Likewise.
6252 * lisp.h (pop_message, set_message, check_point_in_composition):
6254 * xterm.h (set_vertical_scroll_bar): Likewise.
6255 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6256 (message_buf_print, scratch_glyph_row, displayed_buffer):
6257 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6258 (get_next_display_element, show_mouse_face, window_box_edges):
6259 (frame_to_window_pixel_xy, check_point_in_composition):
6260 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6261 (glyph_to_pixel_coords): Remove; unused.
6263 * dired.c (file_name_completion): Now static.
6265 * dbusbind.c (xd_in_read_queued_messages): Now static.
6267 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6268 * data.c (circular_list_error): Remove.
6270 * commands.h (last_point_position, last_point_position_buffer):
6271 (last_point_position_window): Remove decls.
6272 * keyboard.c: Make these variables static.
6274 * coding.h (coding, code_convert_region, encode_coding_gap):
6276 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6277 (iso_code_class, detect_coding, code_convert_region): Now static.
6278 (encode_coding_gap): Remove; unused.
6280 * chartab.c (chartab_chars, chartab_bits): Now static.
6282 * charset.h (charset_iso_8859_1): Remove decl.
6283 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6286 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6287 * ccl.c (Vccl_program_table): Now static.
6288 (check_ccl_update): Remove; unused.
6290 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6291 * category.h: ... from here.
6292 * category.c (check_category_table, set_category_set): Now static.
6294 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6295 * lisp.h: Remove these decls.
6297 * buffer.c (buffer_count): Remove unused var.
6299 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6300 so that it's not optimized away.
6301 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6302 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6303 exported only to the debugger.
6305 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6306 * atimer.h (run_all_atimers): Remove; not exported.
6308 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6309 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6310 was inaccessible from Lisp.
6311 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6312 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6314 alloc.c: Import and export fewer symbols, and remove unused items.
6315 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6317 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6318 it's not optimized away by whole-program optimization.
6319 (message_enable_multibyte, free_misc): Remove.
6320 (catchlist, handlerlist, mark_backtrace):
6321 Declare only if BYTE_MARK_STACK.
6322 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6323 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6324 (message_enable_multibyte): Remove decl.
6325 (free_misc, interval_free_list, float_block, float_block_index):
6326 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6327 (cons_free_list, last_marked_index):
6329 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6330 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6331 (mark_backtrace): Define only if BYTE_MARK_STACK.
6332 * xdisp.c (message_enable_multibyte): Now static.
6334 Declare Lisp_Object Q* variables to be 'static' if not exported.
6335 This makes it easier for human readers (and static analyzers)
6336 to see whether these variables are used from other modules.
6337 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6338 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6339 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6340 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6341 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6342 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6343 * xmenu.c, xselect.c:
6344 Declare Q* vars static if they are not used in other modules.
6345 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6346 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6347 Remove decls of unexported vars.
6348 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6350 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6352 Make Emacs functions such as Fatom 'static' by default.
6353 This makes it easier for human readers (and static analyzers)
6354 to see whether these functions can be called from other modules.
6355 DEFUN now defines a static function. To make the function external
6356 so that it can be used in other C modules, use the new macro DEFUE.
6357 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6358 (Finit_image_library):
6359 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6360 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6361 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6362 Remove decls, since these functions are now static.
6363 (Funintern, Fget_internal_run_time): New decls, since these functions
6364 were already external.
6366 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6367 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6368 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6369 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6370 * keyboard.c, keymap.c, lread.c:
6371 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6372 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6373 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6374 Mark functions with DEFUE instead of DEFUN,
6375 if they are used in other modules.
6376 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6377 decls for now-static functions.
6378 * buffer.h (Fdelete_overlay): Remove decl.
6379 * callproc.c (Fgetenv_internal): Mark as internal.
6380 * composite.c (Fremove_list_of_text_properties): Remove decl.
6381 (Fcomposition_get_gstring): New forward static decl.
6382 * composite.h (Fcomposite_get_gstring): Remove decl.
6383 * dired.c (Ffile_attributes): New forward static decl.
6384 * doc.c (Fdocumntation_property): New forward static decl.
6385 * eval.c (Ffetch_bytecode): New forward static decl.
6386 (Funintern): Remove extern decl; now in .h file where it belongs.
6387 * fileio.c (Fmake_symbolic_link): New forward static decl.
6388 * image.c (Finit_image_library): New forward static decl.
6389 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6390 * intervals.h (Fprevious_property_change):
6391 (Fremove_list_of_text_properties): Remove decls.
6392 * keyboard.c (Fthis_command_keys): Remove decl.
6393 (Fcommand_execute): New forward static decl.
6394 * keymap.c (Flookup_key): New forward static decl.
6395 (Fcopy_keymap): Now static.
6396 * keymap.h (Flookup_key): Remove decl.
6397 * process.c (Fget_process): New forward static decl.
6398 (Fprocess_datagram_address): Mark as internal.
6399 * syntax.c (Fsyntax_table_p): New forward static decl.
6400 (skip_chars): Remove duplicate decl.
6401 * textprop.c (Fprevious_property_change): New forward static decl.
6402 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6404 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6405 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6407 * editfns.c (Fformat): Remove unreachable code.
6409 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6411 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6414 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6416 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6417 when at ZV. (Bug#8487)
6419 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6421 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6423 * keyboard.c (parse_tool_bar_item): Likewise.
6424 * sound.c (sound_cleanup, alsa_close): Likewise.
6425 * termcap.c (tgetent): Likewise.
6426 * xfns.c (x_default_font_parameter): Likewise.
6427 * xsettings.c (read_and_apply_settings): Likewise.
6429 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6430 (overrun_check_free): Protoize.
6432 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6434 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6435 since callers should never pass a negative size.
6436 Change the signature to match that of plain 'read' and 'write'; see
6437 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6438 * lisp.h: Update prototypes of emacs_write and emacs_read.
6440 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6442 * xdisp.c (redisplay_window): Don't try to determine the character
6443 position of the scroll margin if the window start point w->startp
6444 is outside the buffer's accessible region. (Bug#8468)
6446 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6448 Fix write-region and its subroutines for buffers > 2GB.
6449 * fileio.c (a_write, e_write): Modify declaration of arguments and
6450 local variables to support buffers larger than 2GB.
6451 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6453 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6454 argument, local variables, and return value.
6456 * lisp.h: Update prototypes of emacs_write and emacs_read.
6458 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6460 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6462 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6464 Fix more problems found by GCC 4.6.0's static checks.
6466 * xdisp.c (vmessage): Use a better test for character truncation.
6468 * charset.c (load_charset_map): <, not <=, for optimization,
6469 and to avoid potential problems with integer overflow.
6470 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6471 * casetab.c (set_identity, shuffle): Likewise.
6472 * editfns.c (Fformat): Likewise.
6473 * syntax.c (skip_chars): Likewise.
6475 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6476 This also lets GCC 4.6.0 generate slightly better loop code.
6478 * callint.c (Fcall_interactively): <, not <=, for optimization.
6479 (Fcall_interactively): Count the number of arguments produced,
6480 not the number of arguments given. This is simpler and lets GCC
6481 4.6.0 generate slightly better code.
6483 * ftfont.c: Distingish more carefully between FcChar8 and char.
6484 The previous code passed unsigned char * to a functions like
6485 strlen and xstrcasecmp that expect char *, which does not
6486 conform to the C standard.
6487 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6488 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6489 char * when the C standard requires it.
6491 * keyboard.c (read_char): Remove unused var.
6493 * eval.c: Port to Windows vsnprintf (Bug#8435).
6495 (SIZE_MAX): Define if the headers do not.
6496 (verror): Do not give up if vsnprintf returns a negative count.
6497 Instead, grow the buffer. This ports to Windows vsnprintf, which
6498 does not conform to C99. Problem reported by Eli Zaretskii.
6499 Also, simplify the allocation scheme, by avoiding the need for
6500 calling realloc, and removing the ALLOCATED variable.
6502 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6504 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6505 But keep the doprint source code for now, as we might revamp it
6506 and use it again (Bug#8435).
6507 * lisp.h (doprnt): Remove.
6508 * Makefile.in (base_obj): Remove doprnt.o.
6509 * deps.mk (doprnt.o): Remove.
6511 error: Print 32- and 64-bit integers portably (Bug#8435).
6512 Without this change, on typical 64-bit hosts error ("...%d...", N)
6513 was used to print both 32- and 64-bit integers N, which relied on
6515 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6517 * lisp.h (error, verror): Mark as printf-like functions.
6518 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6519 Report overflow in size calculations when allocating printf buffer.
6520 Do not truncate output string at its first null byte.
6521 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6522 Truncate the output at a character boundary, since vsnprintf does not
6524 * charset.c (check_iso_charset_parameter): Convert internal
6525 character to string before calling 'error', since %c now has the
6527 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6528 overflow when computing char to be passed to 'error'. Do not
6529 pass Lisp_Object to 'error'; pass the integer instead.
6530 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6531 formatted with plain %d.
6533 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6535 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6537 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6539 * xterm.c (x_catch_errors): Remove duplicate declaration.
6541 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6543 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6545 2011-04-10 Jim Meyering <meyering@redhat.com>
6547 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6548 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6549 return ssize_t not "int", and use size_t as the buffer length.
6550 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6551 * gnutls.h: Update declarations.
6552 * process.c (read_process_output): Use ssize_t, to match.
6553 (send_process): Likewise.
6555 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6557 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6559 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6561 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6562 Use unsigned char, to match FcChar8 type definition.
6564 * xterm.c (handle_one_xevent):
6565 * xmenu.c (create_and_show_popup_menu):
6566 * xselect.c (x_decline_selection_request)
6567 (x_reply_selection_request): Avoid type-punned deref of X events.
6569 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6571 Fix some uses of `int' instead of EMACS_INT.
6572 * search.c (string_match_1, fast_string_match)
6573 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6574 (scan_buffer, find_next_newline_no_quit)
6575 (find_before_next_newline, search_command, Freplace_match)
6576 (Fmatch_data): Make some `int' variables be EMACS_INT.
6578 * xdisp.c (display_count_lines): 3rd argument and return value now
6579 EMACS_INT. All callers changed.
6580 (pint2hrstr): Last argument is now EMACS_INT.
6582 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6583 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6584 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6585 (decode_coding_utf_16, decode_coding_emacs_mule)
6586 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6587 (decode_coding_ccl, decode_coding_charset)
6588 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6589 (decode_coding_iso_2022, decode_coding_emacs_mule)
6590 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6591 <char_offset, last_offset>: Declare EMACS_INT.
6592 (encode_coding_utf_8, encode_coding_utf_16)
6593 (encode_coding_emacs_mule, encode_invocation_designation)
6594 (encode_designation_at_bol, encode_coding_iso_2022)
6595 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6596 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6598 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6599 (encode_invocation_designation): Last argument P_NCHARS is now
6601 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6602 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6604 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6607 * ccl.c (Fccl_execute_on_string): Declare some variables
6610 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6612 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6614 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6616 * process.c (Fformat_network_address): Doc fix.
6618 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6620 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6622 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6624 * keyboard.c (read_char): Call Lisp function help-form-show,
6625 instead of using internal_with_output_to_temp_buffer.
6626 (Qhelp_form_show): New var.
6627 (syms_of_keyboard): Use DEFSYM macro.
6629 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6631 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6633 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6635 * process.c (Flist_processes): Remove to Lisp.
6636 (list_processes_1): Delete.
6638 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6640 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6642 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6644 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6646 Fix more problems found by GCC 4.6.0's static checks.
6648 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6650 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6652 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6654 * xdisp.c (vmessage): Mark as a printf-like function.
6656 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6658 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6660 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6661 printf-like functions.
6662 (tiff_load): Add casts to remove these marks before passing them
6663 to system-supplied API.
6665 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6667 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6668 This avoids several warnings with gcc -Wstrict-overflow.
6669 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6670 directly, rather than having caller test rule sign. This avoids
6671 some unnecessary tests.
6672 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6673 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6674 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6676 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6677 (xfont_open): Avoid unnecessary tests.
6679 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6681 * composite.h, composite.c (composition_gstring_put_cache):
6682 Use EMACS_INT, not int, for length.
6684 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6685 breaking out part of COMPOSITION_DECODE_RULE.
6686 (COMPOSITION_DECODE_RULE): Use it.
6687 * composite.c (get_composition_id): Remove unused local vars,
6688 by using the new macro.
6690 * textprop.c (set_text_properties_1): Change while to do-while,
6691 since the condition is always true at first.
6693 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6694 (interval_deletion_adjustment): Return unsigned value.
6697 * process.c (list_processes_1, create_pty, read_process_output):
6698 (exec_sentinel): Remove vars that were set but not used.
6699 (create_pty): Remove unnecessary "volatile"s.
6700 (Fnetwork_interface_info): Avoid possibility of int overflow.
6701 (read_process_output): Do adaptive read buffering even if carryover.
6702 (read_process_output): Simplify nbytes computation if buffered.
6704 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6706 * syntax.c (scan_words): Remove var that was set but not used.
6707 (update_syntax_table): Use unsigned instead of int.
6709 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6710 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6711 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6713 * print.c (print_error_message): Avoid int overflow.
6715 * font.c (font_list_entities): Redo for clarity,
6716 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6718 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6719 (font_score): Avoid potential overflow in diff calculation.
6721 * fns.c (substring_both): Remove var that is set but not used.
6722 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6724 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6726 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6727 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6728 can always succeed if overflow has undefined behavior.
6730 * search.c (boyer_moore, wordify): Remove vars set but not used.
6731 (wordify): Omit three unnecessary tests.
6733 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6734 All callers changed. This avoids the need for an unused var.
6736 * casefiddle.c (casify_region): Remove var that is set but not used.
6738 * dired.c (file_name_completion): Remove var that is set but not used.
6740 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6742 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6743 (Finsert_file_contents): Remove unnecessary code checking fd.
6745 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6746 Check for integer overflow on size calculations.
6748 * buffer.c (Fprevious_overlay_change): Remove var that is set
6751 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6752 Remove vars that are set but not used.
6753 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6754 (timer_check_2): Mark vars as initialized.
6756 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6758 * image.c (lookup_image): Remove var that is set but not used.
6759 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6761 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6762 that are set but not used.
6764 * xfns.c (make_invisible_cursor): Don't return garbage
6765 if XCreateBitmapFromData fails (Bug#8410).
6767 * xselect.c (x_get_local_selection, x_handle_property_notify):
6768 Remove vars that are set but not used.
6770 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6771 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6773 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6774 Remove var that is set but not used.
6775 (scroll_bar_windows_size): Now size_t, not int.
6776 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6779 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6780 (map_tty_color) [!defined MSDOS]: Likewise.
6782 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6784 * coding.c: Remove vars that are set but not used.
6785 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6786 All callers changed.
6787 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6788 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6789 (decode_coding_charset): Remove vars that are set but not used.
6791 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6792 that is set but not used.
6794 * print.c (print_object): Remove var that is set but not used.
6796 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6797 The gnulib version avoids calling malloc in the usual case,
6798 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6799 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6800 * filelock.c (current_lock_owner): Likewise.
6801 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6802 * sysdep.c: Include allocator.h, careadlinkat.h.
6803 (emacs_no_realloc_allocator): New static constant.
6804 (emacs_readlink): New function.
6805 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6806 ../lib/careadlinkat.h.
6808 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6810 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6811 first non-nil return value).
6813 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6815 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6816 if not defined (Bug#8403).
6818 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6820 * xdisp.c (display_count_lines): Remove parameter `start',
6821 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6822 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6823 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6824 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6825 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6826 and thereabouts. All callers changed.
6827 (get_per_char_metric): Remove parameter `f', unused since
6828 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6830 2011-04-02 Jim Meyering <meyering@redhat.com>
6832 do not dereference NULL upon failed strdup
6833 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6834 (ns_get_family): Likewise.
6836 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6838 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6840 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6842 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6845 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6847 Add lexical binding.
6849 * window.c (Ftemp_output_buffer_show): New fun.
6850 (Fsave_window_excursion):
6851 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6853 * lread.c (lisp_file_lexically_bound_p): New function.
6854 (Fload): Bind Qlexical_binding.
6855 (readevalloop): Remove `evalfun' arg.
6856 Bind Qinternal_interpreter_environment.
6857 (Feval_buffer): Bind Qlexical_binding.
6858 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6860 (syms_of_lread): Declare `lexical-binding'.
6862 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6864 * keyboard.c (eval_dyn): New fun.
6865 (menu_item_eval_property): Use it.
6867 * image.c (parse_image_spec): Use Ffunctionp.
6869 * fns.c (concat, mapcar1): Accept byte-code-functions.
6871 * eval.c (Fsetq): Handle lexical vars.
6872 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6873 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6874 (FletX, Flet): Obey lexical binding.
6875 (Fcommandp): Handle closures.
6876 (Feval): New `lexical' arg.
6877 (eval_sub): New function extracted from Feval. Use it almost
6878 everywhere where Feval was used. Look up vars in lexical env.
6880 (Ffunctionp): Move from subr.el.
6881 (Ffuncall): Handle closures.
6882 (apply_lambda): Remove `eval_flags'.
6883 (funcall_lambda): Handle closures and new byte-code-functions.
6884 (Fspecial_variable_p): New function.
6885 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6886 but without exporting it to Lisp.
6888 * doc.c (Fdocumentation, store_function_docstring):
6889 * data.c (Finteractive_form): Handle closures.
6891 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6894 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6896 (exec_byte_code): New function extracted from Fbyte_code to handle new
6897 calling convention for byte-code-functions. Add new byte-codes.
6899 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6901 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6903 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6905 * xdisp.c (redisplay_internal): Fix prototype.
6907 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6909 * xdisp.c (SCROLL_LIMIT): New macro.
6910 (try_scrolling): Use it when setting scroll_limit.
6911 Limit scrolling to 100 screen lines.
6912 (redisplay_window): Even when falling back on "recentering",
6913 position point in the window according to scroll-conservatively,
6914 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6916 (try_scrolling): When point is above the window, allow searching
6917 as far as scroll_max, or one screenful, to compute vertical
6918 distance from PT to the scroll margin position. This prevents
6919 try_scrolling from unnecessarily failing when
6920 scroll-conservatively is set to a value slightly larger than the
6921 window height. Clean up the case of PT below the margin at bottom
6922 of window: scroll_max can no longer be INT_MAX. When aggressive
6923 scrolling is in use, don't let point enter the opposite scroll
6924 margin as result of the scroll.
6925 (syms_of_xdisp) <scroll-conservatively>: Document the
6926 threshold of 100 lines for never-recentering scrolling.
6928 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6930 * dispextern.h (move_it_by_lines):
6931 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6932 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6933 (message_log_check_duplicate): Remove parameters `prev_bol' and
6934 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6935 (redisplay_internal): Remove parameter `preserve_echo_area',
6936 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6938 * indent.c (Fvertical_motion):
6939 * window.c (window_scroll_pixel_based, Frecenter):
6940 Don't pass `need_y_p' to `move_it_by_lines'.
6942 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6944 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6945 steal a few bits to be more compact.
6946 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6947 Remove unneeded casts.
6949 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6951 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6953 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6954 binding" message (bug#7967).
6956 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6958 Fix more problems found by GCC 4.6.0's static checks.
6960 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6961 Remove unused local var.
6963 * editfns.c (Fmessage_box): Remove unused local var.
6965 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6966 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6967 Omit unused local vars.
6968 * window.c (shrink_windows): Omit unused local var.
6969 * menu.c (digest_single_submenu): Omit unused local var.
6970 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6971 Omit unused local var.
6973 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6974 Don't assume string length fits in int.
6975 (keyremap_step, read_key_sequence): Use size_t for sizes.
6976 (read_key_sequence): Don't check last_real_key_start redundantly.
6978 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6979 instead of alloca (Bug#8344).
6981 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6982 (Fbacktrace_frame): Don't assume nframes fits in int.
6984 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6986 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6989 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6991 * cm.c (calccost): Turn while-do into do-while, for clarity.
6993 * keyboard.c (syms_of_keyboard): Use the same style as later
6994 in this function when indexing through an array. This also
6995 works around GCC bug 48267.
6997 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6999 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7001 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7002 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7004 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7005 This avoids undefined behavior on integer overflow, and is a bit
7006 more convenient anyway since it is compared to a size_t variable.
7008 Variadic C functions now count arguments with size_t, not int.
7009 This avoids an unnecessary limitation on 64-bit machines, which
7010 caused (substring ...) to crash on large vectors (Bug#8344).
7011 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7012 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7013 All variadic functions and their callers changed accordingly.
7014 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7015 * data.c (arith_driver, float_arith_driver): Likewise.
7016 * editfns.c (general_insert_function): Likewise.
7017 * eval.c (struct backtrace.nargs, interactive_p)
7018 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7019 (funcall_lambda, mark_backtrace): Likewise.
7020 * fns.c (concat): Likewise.
7021 * frame.c (x_set_frame_parameters): Likewise.
7022 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7023 0 if not found, not -1. All callers changed.
7025 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7026 (stack_copy_size): Now size_t, not int.
7027 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7029 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7031 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7032 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7033 All callers changed.
7035 * lisp.h (multibyte_char_to_unibyte):
7036 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7037 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7038 * character.h (CHAR_TO_BYTE8):
7039 * cmds.c (internal_self_insert):
7040 * editfns.c (general_insert_function):
7041 * keymap.c (push_key_description):
7042 * search.c (Freplace_match):
7043 * xdisp.c (message_dolog, set_message_1): All callers changed.
7045 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7047 * keyboard.c (safe_run_hook_funcall): New function.
7048 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7049 don't set the hook to nil, but remove the offending function instead.
7050 (Qcommand_hook_internal): Remove, unused.
7051 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7052 Vcommand_hook_internal.
7054 * eval.c (enum run_hooks_condition): Remove.
7055 (funcall_nil, funcall_not): New functions.
7056 (run_hook_with_args): Call each function through a `funcall' argument.
7057 Remove `cond' argument, now redundant.
7058 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7059 (Frun_hook_with_args_until_failure): Adjust accordingly.
7060 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7062 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7064 * dispextern.h (string_buffer_position): Remove declaration.
7066 * print.c (strout): Remove parameter `multibyte', unused since
7067 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7069 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7070 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7071 All callers changed.
7073 * w32.c (_wsa_errlist): Use braces for struct initializers.
7075 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7076 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7077 All callers changed.
7078 (string_buffer_position): Likewise. Also, make static (it's never
7079 used outside xdisp.c).
7080 (cursor_row_p): Remove parameter `w', unused since
7081 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7082 (decode_mode_spec): Remove parameter `precision', introduced during
7083 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7084 All callers changed.
7086 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7088 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7090 2011-03-27 Anders Lindgren <andlind@gmail.com>
7092 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7093 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7094 (ns_update_auto_hide_menu_bar): New functions.
7095 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7096 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7097 ns_constrain_all_frames.
7098 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7099 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7101 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7103 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7105 2011-03-27 Glenn Morris <rgm@gnu.org>
7107 * syssignal.h: Replace RETSIGTYPE with void.
7108 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7109 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7110 Replace SIGTYPE with void everywhere.
7111 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7112 * s/template.h (SIGTYPE): Remove commented out definition.
7114 2011-03-26 Eli Zaretskii <eliz@gnu.org>
7116 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7117 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7119 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
7121 * w32.c (read_unc_volume): Use parameter `henum', instead of
7122 global variable `wget_enum_handle'.
7124 * keymap.c (describe_vector): Remove parameters `indices' and
7125 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7126 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7128 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7130 * keyboard.c (timer_check): Remove parameter `do_it_now',
7131 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7132 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7133 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7135 * keyboard.c (read_char):
7136 * w32menu.c (w32_menu_display_help):
7137 * xmenu.c (show_help_event, menu_help_callback):
7138 Adjust calls to `show_help_echo'.
7140 * gtkutil.c (xg_maybe_add_timer):
7141 * keyboard.c (readable_events):
7142 * process.c (wait_reading_process_output):
7143 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7145 * insdel.c (adjust_markers_gap_motion):
7146 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7147 (gap_left, gap_right): Don't call it.
7149 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
7151 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7152 incurred during fontification.
7154 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7156 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7157 (DEFVAR_PER_BUFFER): Don't pass it.
7159 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7160 (scrolling_window): Don't pass it.
7162 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7164 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7166 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7168 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7169 of variables specific to SELinux and computation of `encoded_absname'.
7171 * image.c (XPutPixel): Remove unused variable `height'.
7173 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7175 * unexw32.c (get_section_info): Remove unused variable `section'.
7177 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7178 (system_process_attributes): Remove unused variable `sess'.
7179 (sys_read): Remove unused variable `err'.
7181 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7182 (w32_wnd_proc): Remove unused variable `isdead'.
7183 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7184 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7185 (x_create_tip_frame): Remove unused variable `tem'.
7187 * w32inevt.c (w32_console_read_socket):
7188 Remove unused variable `no_events'.
7190 * w32term.c (x_draw_composite_glyph_string_foreground):
7191 Remove unused variable `width'.
7193 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
7195 * w32term.c (x_set_glyph_string_clipping):
7196 Don't pass uninitialized region to CombineRgn.
7198 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
7200 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7201 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7202 (Fx_close_connection): Remove unused variable `i'.
7204 * w32font.c (w32font_draw): Return number of glyphs.
7205 (w32font_open_internal): Remove unused variable `i'.
7206 (w32font_driver): Add missing initializer.
7208 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7209 (fill_in_menu): Remove unused variable `items_added'.
7211 * w32term.c (last_mouse_press_frame): Remove static global variable.
7212 (w32_clip_to_row): Remove unused variable `f'.
7213 (x_delete_terminal): Remove unused variable `i'.
7215 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7216 (NOTHING): Remove unused static global variable.
7217 (uniscribe_check_otf): Remove unused variable `table'.
7218 (uniscribe_font_driver): Add missing initializers.
7220 2011-03-23 Julien Danjou <julien@danjou.info>
7222 * term.c (Fsuspend_tty, Fresume_tty):
7223 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7224 * window.c (temp_output_buffer_show):
7225 * insdel.c (signal_before_change):
7226 * frame.c (Fhandle_switch_frame):
7227 * fileio.c (Fdo_auto_save):
7228 * emacs.c (Fkill_emacs):
7229 * editfns.c (save_excursion_restore):
7230 * cmds.c (internal_self_insert):
7231 * callint.c (Fcall_interactively):
7232 * buffer.c (Fkill_all_local_variables):
7233 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7235 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
7236 unconditionnaly since it does the check itself.
7238 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
7240 Fix more problems found by GCC 4.5.2's static checks.
7242 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7243 the first time through the loop, since we know p0 < p1 then.
7244 This also avoids a gcc -Wstrict-overflow warning.
7246 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7247 leading to a memory leak, possible in functions like
7248 load_charset_map_from_file that can allocate an unbounded number
7249 of objects (Bug#8318).
7251 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7252 that could (at least in theory) be that large.
7254 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7255 This is less likely to overflow, and avoids undefined behavior if
7256 overflow does occur. All callers changed. Use strtoul to scan
7257 for the unsigned long integer.
7258 (pint2hrstr): Simplify and tune code slightly.
7259 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7261 * scroll.c (do_scrolling): Work around GCC bug 48228.
7262 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7264 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7265 This also avoids a warning with gcc -Wstrict-overflow.
7266 (validate_x_resource_name): Simplify count usage.
7267 This also avoids a warning with gcc -Wstrict-overflow.
7269 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7272 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7274 * process.c (Fmake_network_process): Use socklen_t, not int,
7275 where POSIX says socklen_t is required in portable programs.
7276 This fixes a porting bug on hosts like 64-bit HP-UX, where
7277 socklen_t is wider than int (Bug#8277).
7278 (Fmake_network_process, server_accept_connection):
7279 (wait_reading_process_output, read_process_output):
7282 * process.c: Rename or move locals to avoid shadowing.
7283 (list_processes_1, Fmake_network_process):
7284 (read_process_output_error_handler, exec_sentinel_error_handler):
7285 Rename or move locals.
7286 (Fmake_network_process): Define label "retry_connect" only if needed.
7287 (Fnetwork_interface_info): Fix pointer signedness.
7288 (process_send_signal): Add cast to avoid pointer signedness problem.
7289 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7290 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7292 Make tparam.h and terminfo.c consistent.
7293 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7294 Include tparam.h instead, since it declares them.
7295 * cm.h (PC): Remove extern decl; tparam.h now does this.
7296 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7297 * terminfo.c: Include tparam.h, to check interfaces.
7298 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7299 (tparam): Adjust signature to match interface in tparam.h;
7300 this removes some undefined behavior. Check that outstring and len
7301 are zero, which they always are with Emacs.
7302 * tparam.h (PC, BC, UP): New extern decls.
7304 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7305 (xftfont_open): Rename locals to avoid shadowing.
7307 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7308 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7309 (OTF_TAG_SYM): Omit macro if not needed.
7310 (ftfont_list): Remove unused local.
7311 (get_adstyle_property, ftfont_pattern_entity):
7312 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7313 Rename locals to avoid shadowing.
7315 * xfont.c (xfont_list_family): Mark var as initialized.
7317 * xml.c (make_dom): Now static.
7319 * composite.c (composition_compute_stop_pos): Rename local to
7321 (composition_reseat_it): Remove unused locals.
7322 (find_automatic_composition, composition_adjust_point): Likewise.
7323 (composition_update_it): Mark var as initialized.
7324 (find_automatic_composition): Mark vars as initialized,
7325 with a FIXME (Bug#8290).
7327 character.h: Rename locals to avoid shadowing.
7328 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7329 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7330 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7331 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7334 * textprop.c (property_change_between_p): Remove; unused.
7336 * intervals.c (interval_start_pos): Now static.
7338 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7340 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7341 Rename locals to avoid shadowing.
7343 * sound.c (wav_play, au_play, Fplay_sound_internal):
7344 Fix pointer signedness.
7345 (alsa_choose_format): Remove unused local var.
7346 (wav_play): Initialize a variable to 0, to prevent undefined
7347 behavior (Bug#8278).
7349 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7351 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7353 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7354 clobbering (Bug#8298).
7355 * sysdep.c (sys_subshell): Likewise.
7356 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7358 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7359 This should get cleaned up, so that child_setup has the
7360 same signature on all platforms.
7362 * callproc.c (call_process_cleanup): Now static.
7363 (relocate_fd): Rename locals to avoid shadowing.
7365 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7367 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7368 not to be necessary, and produces flickering.
7370 2011-03-20 Glenn Morris <rgm@gnu.org>
7372 * config.in: Remove file.
7374 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7376 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7377 are now in src/globals.h.
7378 (syms_of_minibuf): Remove spurious & from previous change.
7380 2011-03-20 Leo <sdl.web@gmail.com>
7382 * minibuf.c (completing-read-function): New variable.
7383 (completing-read-default): Rename from completing-read.
7384 (completing-read): Call completing-read-function.
7386 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7388 * xfaces.c (Fx_load_color_file):
7389 Read color file from absolute filename (bug#8250).
7391 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7393 * makefile.w32-in: Update dependencies.
7395 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7397 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7399 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7401 Fix more problems found by GCC 4.5.2's static checks.
7403 * process.c (make_serial_process_unwind, send_process_trap):
7404 (sigchld_handler): Now static.
7406 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7407 That way, the code declares only the vars that it needs.
7408 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7409 * s/cygwin.h (PTY_ITERATION): Likewise.
7410 * s/darwin.h (PTY_ITERATION): Likewise.
7411 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7413 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7414 * process.c (allocate_pty): Don't declare stb unless it's needed.
7416 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7417 (CONSTANTLIM): Remove; unused.
7418 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7419 Define only if needed.
7421 * unexelf.c (unexec): Name an expression,
7422 to avoid gcc -Wbad-function-cast warning.
7423 Use a different way to cause a compilation error if anyone uses
7424 n rather than nn, a way that does not involve shadowing.
7425 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7427 * deps.mk (unexalpha.o): Remove; unused.
7429 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7430 * unexec.h: New file.
7431 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7432 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7434 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7435 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7436 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7437 Change as necessary to match prototype in unexec.h.
7439 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7441 (back_comment, skip_chars): Mark vars as initialized.
7443 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7444 Rename locals to avoid shadowing.
7446 * lread.c (read1): Rewrite so as not to use empty "else".
7447 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7449 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7451 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7452 warning when compiling print.c.
7454 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7455 instead of using an uninitialized var.
7456 (font_sort_entities): Mark var as initialized.
7458 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7460 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7461 pointers to constants.
7462 (font_parse_fcname): Remove unused vars.
7463 (font_delete_unmatched): Now static.
7464 (font_get_spec): Remove; unused.
7465 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7466 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7467 Rename or move locals to avoid shadowing.
7469 * fns.c (require_nesting_list, require_unwind): Now static.
7470 (Ffillarray): Rename locals to avoid shadowing.
7472 * floatfns.c (domain_error2): Define only if needed.
7473 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7475 * alloc.c (mark_backtrace): Move decl from here ...
7476 * lisp.h: ... to here, so that it can be checked.
7478 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7479 (Fdefvar): Rewrite so as not to use empty "else".
7480 (lisp_indirect_variable): Name an expression,
7481 to avoid gcc -Wbad-function-cast warning.
7482 (Fdefvar): Rename locals to avoid shadowing.
7484 * callint.c (quotify_arg, quotify_args): Now static.
7485 (Fcall_interactively): Rename locals to avoid shadowing.
7486 Use const pointer when appropriate.
7488 * lisp.h (get_system_name, get_operating_system_release):
7489 Move decls here, to check interfaces.
7490 * process.c (get_operating_system_release): Move decl to lisp.h.
7491 * xrdb.c (get_system_name): Likewise.
7492 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7493 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7494 some of which prompt warnings from gcc -Wbad-function-cast.
7495 (Fformat_time_string, Fencode_time, Finsert_char):
7496 (Ftranslate_region_internal, Fformat):
7497 Rename or remove local vars to avoid shadowing.
7498 (Ftranslate_region_internal): Mark var as initialized.
7500 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7503 * lisp.h (eassert): Check that the argument compiles, even if
7504 ENABLE_CHECKING is not defined.
7506 * data.c (Findirect_variable): Name an expression, to avoid
7507 gcc -Wbad-function-cast warning.
7508 (default_value, arithcompare, arith_driver, arith_error): Now static.
7509 (store_symval_forwarding): Rename local to avoid shadowing.
7510 (Fmake_variable_buffer_local, Fmake_local_variable):
7511 Mark variables as initialized.
7512 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7514 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7515 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7516 Rename locals to avoid shadowing.
7517 (mark_stack): Move local variables into the #ifdef region where
7519 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7520 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7522 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7523 (GC_STRING_CHARS): Remove; not used.
7524 (Fmemory_limit): Cast sbrk's returned value to char *.
7526 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7527 avoids undefined behavior in theory.
7529 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7531 Use functions, not macros, for up- and down-casing (Bug#8254).
7532 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7533 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7534 to use the following functions instead of these macros.
7535 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7536 EMACS_INT, since callers assume the returned value fits in int.
7537 (upcase1): Likewise, for UPCASE_TABLE.
7538 (uppercasep, lowercasep, upcase): New static inline functions.
7539 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7540 the race-condition problem in the old DOWNCASE.
7542 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7543 Rename locals to avoid shadowing.
7544 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7545 (regex_compile, re_search_2, re_match_2_internal):
7546 Remove unused local vars.
7547 (FREE_VAR): Rewrite so as not to use empty "else",
7548 which gcc can warn about.
7549 (regex_compile, re_match_2_internal): Mark locals as initialized.
7550 (RETALLOC_IF): Define only if needed.
7551 (WORDCHAR_P): Likewise. This one is never needed, but is used
7552 only in a comment talking about a compiler bug, so put inside
7553 the #if 0 of that comment.
7554 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7555 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7558 * search.c (boyer_moore): Rename locals to avoid shadowing.
7559 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7560 (PREV_CHAR_BOUNDARY): Likewise.
7562 * search.c (simple_search): Remove unused var.
7564 * dired.c (compile_pattern): Move decl from here ...
7565 * lisp.h: ... to here, so that it can be checked.
7566 (struct re_registers): New forward decl.
7568 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7570 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7572 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7573 Rename locals to avoid shadowing.
7574 (Fvertical_motion): Mark locals as initialized.
7576 * casefiddle.c (casify_object, casify_region): Now static.
7577 (casify_region): Mark local as initialized.
7579 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7581 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7582 New macros, so that the caller can use some names other than
7583 gcpro1, gcpro2, etc.
7584 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7586 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7587 argument, for consistency with GCPRO2_VAR, etc: it is now the
7588 prefix of the variable, not the variable itself. All uses
7590 * dired.c (directory_files_internal, file_name_completion):
7591 Rename locals to avoid shadowing.
7593 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7594 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7595 dired.c's scmp function, had undefined behavior.
7596 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7597 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7598 * buffer.h: ... to here, because these macros use current_buffer,
7599 and the new implementation with inline functions needs to have
7600 current_buffer in scope now, rather than later when the macros
7602 (downcase, upcase1): New static inline functions.
7603 (DOWNCASE, UPCASE1): Reimplement using these functions.
7604 This avoids undefined behavior in expressions like
7605 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7606 from race conditions in accessing the global variables
7607 case_temp1 and case_temp2.
7608 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7609 * lisp.h (case_temp1, case_temp2): Remove their decls.
7610 * character.h (ASCII_CHAR_P): Move from here ...
7611 * lisp.h: ... to here, so that the inline functions mentioned
7614 * dired.c (directory_files_internal_unwind): Now static.
7616 * fileio.c (file_name_as_directory, directory_file_name):
7617 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7619 (file_name_as_directory): Use const pointers when appropriate.
7620 (Fexpand_file_name): Likewise. In particular, newdir might
7621 point at constant storage, so make it a const pointer.
7622 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7623 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7625 (Fset_file_times, Finsert_file_contents, auto_save_error):
7626 Rename locals to avoid shadowing.
7628 * minibuf.c (choose_minibuf_frame_1): Now static.
7629 (Ftry_completion, Fall_completions): Rename or remove locals
7632 * marker.c (bytepos_to_charpos): Remove; unused.
7634 * lisp.h (verify_bytepos, count_markers): New decls,
7635 so that gcc does not warn that these functions aren't declared.
7637 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7638 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7639 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7640 (copy_text): Remove unused local var.
7642 * filelock.c (within_one_second): Now static.
7643 (lock_file_1): Rename local to avoid shadowing.
7645 * buffer.c (fix_overlays_before): Mark locals as initialized.
7646 (fix_start_end_in_overlays): Likewise. This function should be
7647 simplified by using pointers-to-pointers, but that's a different
7649 (switch_to_buffer_1): Now static.
7650 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7651 (report_overlay_modification): Rename locals to avoid shadowing.
7653 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7654 Fix pointer signedness issue.
7655 (sys_subshell): Mark local as volatile if checking for lint,
7656 to suppress a gcc -Wclobbered warning that does not seem to be right.
7657 (MAXPATHLEN): Define only if needed.
7659 * process.c (serial_open, serial_configure): Move decls from here ...
7660 * systty.h: ... to here, so that they can be checked.
7662 * fns.c (get_random, seed_random): Move extern decls from here ...
7663 * lisp.h: ... to here, so that they can be checked.
7665 * sysdep.c (reset_io): Now static.
7666 (wait_for_termination_signal): Remove; unused.
7668 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7669 (copy_keymap_item, append_key, push_text_char_description):
7671 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7672 (DENSE_TABLE_SIZE): Remove; unused.
7673 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7674 (describe_map_tree):
7675 Rename locals to avoid shadowing.
7677 * keyboard.c: Declare functions static if they are not used elsewhere.
7678 (echo_char, echo_dash, cmd_error, top_level_2):
7679 (poll_for_input, handle_async_input): Now static.
7680 (read_char, kbd_buffer_get_event, make_lispy_position):
7681 (make_lispy_event, make_lispy_movement, apply_modifiers):
7682 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7683 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7684 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7685 (read_key_sequence, read_char): Mark locals as initialized.
7686 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7688 * keyboard.h (make_ctrl_char): New decl.
7689 (mark_kboards): Move decl here ...
7690 * alloc.c (mark_kboards): ... from here.
7692 * lisp.h (force_auto_save_soon): New decl.
7694 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7695 (DEFINE_DUMMY_FUNCTION): New macro.
7696 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7698 (main): Add casts to avoid warnings
7699 if GCC considers string literals to be constants.
7701 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7703 * dbusbind.c: Pointer signedness fixes.
7704 (xd_signature, xd_append_arg, xd_initialize):
7705 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7706 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7707 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7708 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7710 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7711 if GCC considers string literals to be constants.
7712 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7714 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7716 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7717 (print_preprocess, print_object): New macro to fix last change.
7719 * print.c (print_preprocess): Don't forget font objects.
7721 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7723 * emacs.c (USAGE3): Doc fixes.
7725 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7727 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7730 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7732 * lisp.h (VWindow_system, Qfile_name_history):
7733 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7734 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7735 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7737 * w32select.c: Don't #include "keyboard.h".
7738 (run_protected): Add extern declaration for waiting_for_input.
7740 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7741 * w32console.c (detect_input_pending, read_input_pending)
7742 (encode_terminal_code):
7743 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7744 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7745 (w32_system_caret_y, Qfile_name_history):
7746 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7747 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7748 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7749 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7750 * w32proc.c (Qlocal, report_file_error):
7751 * w32term.c (Vwindow_system, updating_frame):
7752 * w32uniscribe.c (initialized, uniscribe_font_driver):
7753 Remove unneeded extern declarations.
7755 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7757 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7759 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7761 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7762 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7763 These macros can no longer be used for assignment.
7765 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7766 Assign struct members directly, instead of using BUF_BEGV etc.
7767 (record_buffer_markers, fetch_buffer_markers): New functions for
7768 recording and fetching special buffer markers.
7769 (set_buffer_internal_1, set_buffer_temp): Use them.
7771 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7773 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7775 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7776 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7778 * xdisp.c (hscroll_window_tree):
7779 (reconsider_clip_changes): Use PT instead of BUF_PT.
7781 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7783 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7784 $(EMACS_ROOT)/lib/intprops.h.
7786 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7788 Fix more problems found by GCC 4.5.2's static checks.
7790 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7791 to unsigned char * to avoid compiler diagnostic.
7792 (xg_free_frame_widgets): Make it clear that a local variable is
7793 needed only if USE_GTK_TOOLTIP.
7794 (gdk_window_get_screen): Make it clear that this macro is needed
7795 only if USE_GTK_TOOLTIP.
7796 (int_gtk_range_get_value): New function, which avoids a diagnostic
7797 from gcc -Wbad-function-cast.
7798 (xg_set_toolkit_scroll_bar_thumb): Use it.
7799 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7800 diagnostic from gcc -Wbad-function-cast.
7801 (get_utf8_string, xg_get_file_with_chooser):
7802 Rename locals to avoid shadowing.
7803 (create_dialog): Move locals to avoid shadowing.
7805 * xgselect.c (xg_select): Remove unused var.
7807 * image.c (four_corners_best): Mark locals as initialized.
7808 (gif_load): Initialize transparent_p to zero (Bug#8238).
7809 Mark another local as initialized.
7810 (my_png_error, my_error_exit): Mark with NO_RETURN.
7812 * image.c (clear_image_cache): Now static.
7813 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7814 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7815 (x_edge_detection): Remove unnecessary cast that
7816 gcc -Wbad-function-cast diagnoses.
7817 (gif_load): Fix pointer signedness.
7818 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7819 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7821 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7823 Improve quality of tests for time stamp overflow.
7824 For example, without this patch (encode-time 0 0 0 1 1
7825 1152921504606846976) returns the obviously-bogus value (-948597
7826 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7827 reports time overflow. See
7828 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7829 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7830 * editfns.c: Include limits.h and intprops.h.
7831 (TIME_T_MIN, TIME_T_MAX): New macros.
7832 (time_overflow): Move earlier, to before first use.
7833 (hi_time, lo_time): New functions, for an accurate test for
7835 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7836 (Fget_internal_run_time): Don't assume time_t fits in int.
7837 (make_time): Use list2 instead of Fcons twice.
7838 (Fdecode_time): More accurate test for out-of-range times.
7839 (check_tm_member): New function.
7840 (Fencode_time): Use it, to test for out-of-range times.
7841 (lisp_time_argument): Don't rely on undefined left-shift and
7842 right-shift behavior when checking for time stamp overflow.
7844 * editfns.c (time_overflow): New function, refactoring common code.
7845 (Fformat_time_string, Fdecode_time, Fencode_time):
7846 (Fcurrent_time_string): Use it.
7848 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7849 * dired.c (make_time): Move to ...
7850 * editfns.c (make_time): ... here.
7851 * systime.h: Note the move.
7853 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7855 * fringe.c (update_window_fringes): Remove unused variables.
7857 * unexmacosx.c (copy_data_segment): Also copy __got section.
7860 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7862 * termcap.c [MSDOS]: Include "msdos.h".
7863 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7864 Constify `char *' arguments and their references according to
7865 prototypes in tparam.h.
7867 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7869 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7870 Adapt all references accordingly.
7872 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7874 2011-03-11 Tom Tromey <tromey@redhat.com>
7876 * buffer.c (syms_of_buffer): Remove obsolete comment.
7878 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7880 * termhooks.h (encode_terminal_code): Declare prototype.
7882 * msdos.c (encode_terminal_code): Don't declare prototype.
7884 * term.c (encode_terminal_code): Now external again, used by
7885 w32console.c and msdos.c.
7887 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7888 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7890 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7892 Fix some minor problems found by GCC 4.5.2's static checks.
7894 * fringe.c (update_window_fringes): Mark locals as initialized
7896 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7898 * alloc.c (mark_fringe_data): Move decl from here ...
7899 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7900 to check its interface.
7901 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7903 * fontset.c (free_realized_fontset): Now static.
7904 (Fset_fontset_font): Rename local to avoid shadowing.
7905 (fontset_font): Mark local as initialized.
7906 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7908 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7910 * xselect.c (x_disown_buffer_selections): Remove; not used.
7911 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7912 (x_own_selection, Fx_disown_selection_internal): Rename locals
7914 (x_handle_dnd_message): Remove local to avoid shadowing.
7916 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7917 so that the caller can use some name other than gcpro1.
7918 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7919 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7920 (Fx_backspace_delete_keys_p):
7921 Use them to avoid shadowing, and rename vars to avoid shadowing.
7922 (x_decode_color, x_set_name, x_window): Now static.
7923 (Fx_create_frame): Add braces to silence GCC warning.
7924 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7925 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7926 Remove unused locals.
7927 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7928 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7929 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7932 * xterm.h (x_mouse_leave): New decl.
7934 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7935 Remove unused functions.
7936 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7937 (x_calc_absolute_position): Now static.
7938 (XTread_socket): Don't define label "out" unless it's used.
7939 Don't declare local "event" unless it's used.
7940 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7941 unless they are used.
7942 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7943 (x_fatal_error_signal): Remove; not used.
7944 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7945 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7946 (x_error_catcher, x_connection_closed, x_error_handler):
7947 (x_error_quitter, xembed_send_message, x_iconify_frame):
7948 (my_log_handler): Rename locals to avoid shadowing.
7949 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7950 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7952 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7953 Rename or move locals to avoid shadowing.
7954 (tty_defined_color, merge_face_heights): Now static.
7955 (free_realized_faces_for_fontset): Remove; not used.
7956 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7957 does not deduce is never used uninitialized.
7958 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7959 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7961 * terminal.c (store_terminal_param): Now static.
7963 * xmenu.c (menu_highlight_callback): Now static.
7964 (set_frame_menubar): Remove unused local.
7965 (xmenu_show): Rename parameter to avoid shadowing.
7966 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7967 since they might point to immutable storage.
7968 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7969 since it's unused otherwise.
7971 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7972 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7973 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7974 avoids a gcc -Wuninitialized diagnostic.
7975 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7976 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7977 does not deduce are never used uninitialized.
7979 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7981 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7982 * window.c (window_loop, size_window):
7983 (run_window_configuration_change_hook, enlarge_window): Likewise.
7985 * window.c (display_buffer): Now static.
7986 (size_window): Mark variables that gcc -Wuninitialized
7987 does not deduce are never used uninitialized.
7988 * window.h (check_all_windows): New decl, to forestall
7989 gcc -Wmissing-prototypes diagnostic.
7990 * dispextern.h (bidi_dump_cached_states): Likewise.
7992 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7994 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7996 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7997 and to avoid gcc -Wuninitialized warning.
7998 (load_charset_map): Mark variables that gcc -Wuninitialized
7999 does not deduce are never used uninitialized.
8000 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8002 * coding.c (coding_set_source, coding_set_destination):
8003 Use "else { /* comment */ }" rather than "else /* comment */;"
8004 for clarity, and to avoid gcc -Wempty-body warning.
8005 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8006 a block, when the outer 'i' will do.
8007 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8008 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8009 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8010 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8011 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8012 Rename locals to avoid shadowing.
8013 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8014 * coding.c (emacs_mule_char, encode_invocation_designation):
8015 Now static, since they're not used elsewhere.
8016 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8017 (decode_coding_object, encode_coding_object, detect_coding_system):
8018 (decode_coding_emacs_mule): Mark variables that gcc
8019 -Wuninitialized does not deduce are never used uninitialized.
8020 (detect_coding_iso_2022): Initialize a local variable that might
8021 be used uninitialized. Leave a FIXME because it's not clear that
8022 this initialization is needed. (Bug#8211)
8023 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8024 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8025 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8026 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8027 Remove unused macros.
8029 * category.c (hash_get_category_set): Remove unused local var.
8030 (copy_category_table): Now static, since it's not used elsewhere.
8031 * character.c (string_count_byte8): Likewise.
8033 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8034 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8036 * chartab.c (copy_sub_char_table): Now static, since it's not used
8038 (sub_char_table_ref_and_range, char_table_ref_and_range):
8039 Rename locals to avoid shadowing.
8040 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8042 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8043 (BIDI_BOB): Remove unused macro.
8045 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8046 deduce are never used uninitialized.
8047 * term.c (encode_terminal_code): Likewise.
8049 * term.c (encode_terminal_code): Now static. Remove unused local.
8051 * tparam.h: New file.
8052 * term.c, tparam.h: Include it.
8053 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8054 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8055 Move these decls to tparam.h, and make them agree with what
8056 is actually in tparam.c. The previous trick of using incompatible
8057 decls in different modules does not conform to the C standard.
8058 All callers of tparam changed to use tparam's actual API.
8059 * tparam.c (tparam1, tparam, tgoto):
8060 Use const pointers where appropriate.
8062 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8063 * cm.h (struct cm): Likewise.
8064 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8065 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8066 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8067 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8068 (turn_on_face, init_tty): Likewise.
8069 * termchar.h (struct tty_display_info): Likewise.
8071 * term.c (term_mouse_position): Rename local to avoid shadowing.
8073 * alloc.c (mark_ttys): Move decl from here ...
8074 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8076 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8078 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8080 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
8082 * search.c (compile_pattern_1): Remove argument regp, unused since
8083 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8084 (compile_pattern): Don't pass it.
8086 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8088 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8089 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8091 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8093 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8095 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8096 gdk_window_get_screen, gdk_window_get_geometry,
8097 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8098 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8099 (xg_get_pixbuf_from_pixmap): New function.
8100 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8101 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8102 Call xg_get_pixbuf_from_pixmap instead of
8103 gdk_pixbuf_get_from_drawable.
8104 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8105 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8106 (xg_check_special_colors): Use GtkStyleContext and its functions
8108 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8109 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8110 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
8111 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8112 Call gtk_widget_get_preferred_size.
8113 (xg_frame_resized): gdk_window_get_geometry only takes 5
8115 (xg_win_to_widget, xg_event_is_for_menubar):
8116 Call gdk_x11_window_lookup_for_display.
8117 (xg_set_widget_bg): New function.
8118 (delete_cb): New function.
8119 (xg_create_frame_widgets): Connect delete-event to delete_cb.
8120 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8121 (xg_set_background_color): Call xg_set_widget_bg.
8122 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8123 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8124 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8125 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8127 (update_frame_tool_bar): Call gtk_widget_hide.
8128 (xg_initialize): Use GDK_KEY_g.
8130 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8132 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8134 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8135 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8136 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8138 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
8140 * w32xfns.c (select_palette): Check success of RealizePalette against
8141 GDI_ERROR, not zero.
8143 See ChangeLog.11 for earlier changes.
8149 Copyright (C) 2011 Free Software Foundation, Inc.
8151 This file is part of GNU Emacs.
8153 GNU Emacs is free software: you can redistribute it and/or modify
8154 it under the terms of the GNU General Public License as published by
8155 the Free Software Foundation, either version 3 of the License, or
8156 (at your option) any later version.
8158 GNU Emacs is distributed in the hope that it will be useful,
8159 but WITHOUT ANY WARRANTY; without even the implied warranty of
8160 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8161 GNU General Public License for more details.
8163 You should have received a copy of the GNU General Public License
8164 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.