1 2012-07-10 Tom Tromey <tromey@redhat.com>
3 * bytecode.c (BYTE_CODE_THREADED): New macro.
4 (BYTE_CODES): New macro. Replaces all old byte-code defines.
5 (enum byte_code_op): New type.
6 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
7 (exec_byte_code): Use them. Use token threading when applicable.
9 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
11 Optimize pure C strings initialization.
12 * lisp.h (make_pure_string): Fix prototype.
13 (build_pure_c_string): New function, defined as static inline. This
14 provides a better opportunity to optimize away calls to strlen when
15 the function is called with compile-time constant argument.
16 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
17 argument, adjust users accordingly. Use build_pure_c_string where
19 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
20 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
21 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
23 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
25 Avoid calls to strlen in miscellaneous functions.
26 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
27 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
28 * lread.c (openp): Likewise.
30 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
32 Avoid calls to strlen in path processing functions.
33 * fileio.c (file_name_as_directory): Add comment. Change to add
34 srclen argument and return the length of result. Adjust users
36 (directory_file_name): Fix comment. Change to add srclen argument,
37 swap 1st and 2nd arguments to obey the common convention. Adjust
39 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
41 2012-07-10 Glenn Morris <rgm@gnu.org>
43 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
44 Move PENDING_OUTPUT_COUNT definition to configure.
46 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
47 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
48 * s/gnu.h (DATA_START): Move definitions to configure.
50 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
51 We include usg5-4-common.h, which defines them both.
53 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
54 O_RDONLY already includes it).
56 Stop ns builds setting the EMACSLOADPATH environment variable.
57 * nsterm.m (ns_load_path): Rename from ns_init_paths.
58 Now it does not set EMACSLOADPATH, just returns the load-path string.
59 * nsterm.h: Update accordingly.
60 * lread.c [HAVE_NS]: Include nsterm.h.
61 (init_lread) [HAVE_NS]: Use ns_load_path.
62 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
64 2012-07-09 Glenn Morris <rgm@gnu.org>
66 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
67 since the included bsd-common.h does so.
69 Stop ns builds setting the EMACSPATH environment variable.
70 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
71 (ns_init_paths): Do not set EMACSPATH.
72 * nsterm.h (ns_exec_path): Add it.
73 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
76 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
78 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
80 * process.c (wait_reading_process_output): 'waitchannels' was unset
81 when read_kbd || !NILP (wait_for_cell); fix this.
83 Add GCC-style 'const' attribute to functions that can use it.
84 * character.h (char_resolve_modifier_mask):
85 * keyboard.h (make_ctrl_char):
86 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
87 (init_character_once, next_almost_prime, init_fns, init_image)
88 (flush_pending_output, init_sound):
89 * mem-limits.h (start_of_data):
90 * menu.h (finish_menu_items):
92 * emacs.c (DEFINE_DUMMY_FUNCTION):
93 Declare the dummy function with ATTRIBUTE_CONST.
94 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
95 Add decls with ATTRIBUTE_CONST.
97 Minor improvements to make_formatted_string.
98 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
99 where int is good enough, as vsprintf returns an int.
100 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
102 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
104 Use make_formatted_string to avoid double length calculation.
105 * lisp.h (make_formatted_string): New prototype.
106 * alloc.c (make_formatted_string): New function.
107 * buffer.c (Fgenerate_new_buffer_name): Use it.
108 * dbus.c (syms_of_dbusbind): Likewise.
109 * editfns.c (Fcurrent_time_zone): Likewise.
110 * filelock.c (get_boot_time): Likewise.
111 * frame.c (make_terminal_frame, set_term_frame_name)
112 (x_report_frame_params): Likewise.
113 * image.c (gs_load): Likewise.
114 * minibuf.c (get_minibuffer): Likewise.
115 * msdos.c (dos_set_window_size): Likewise.
116 * process.c (make_process): Likewise.
117 * xdisp.c (ensure_echo_area_buffers): Likewise.
118 * xsettings.c (apply_xft_settings): Likewise.
120 2012-07-09 Glenn Morris <rgm@gnu.org>
122 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
123 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
124 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
125 * nsterm.h (ns_etc_directory): Add it.
126 * callproc.c [HAVE_NS]: Include nsterm.h.
127 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
129 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
131 Move marker debugging code under MARKER_DEBUG.
132 * marker.c (MARKER_DEBUG): Move marker debugging code under
133 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
134 for bootstrap with --enable-checking (~3x slowdown reported
135 by Juanma Barranquero <lekktu@gmail.com>).
136 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
138 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
140 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
141 See <http://bugs.gnu.org/11825#29>.
143 2012-07-08 Eli Zaretskii <eliz@gnu.org>
145 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
146 has no font, use the frame's font. (Bug#11813)
147 (display_line): Add commentary about displaying truncation glyphs
149 (produce_special_glyphs): Move here from term.c.
151 * term.c (produce_special_glyphs): Move to xdisp.c.
153 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
156 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
158 * xdisp.c (display_line): Avoid warning about implicit declaration
161 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
163 * lisp.h: Remove empty conditional.
165 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
167 * lread.c (load_path_check): Now static.
169 Fix some minor --with-ns problems found by static checking.
170 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
171 (x_set_font) [!HAVE_X_WINDOWS]:
172 * image.c (xpm_load_image) [HAVE_NS]:
173 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
174 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
176 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
177 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
178 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
179 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
180 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
181 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
182 Fix pointer signedness problem.
183 * xfaces.c (FRAME_X_FONT_TABLE):
184 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
186 2012-07-07 Glenn Morris <rgm@gnu.org>
188 * lread.c (load_path_check): New function, split from init_lread.
189 (init_lread): Reorganize. Motivation:
190 If EMACSLOADPATH is set, check/warn about that rather than the
191 defaults, which we are not going to use. Hence we can remove
192 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
193 Don't warn if site-lisp directories are missing.
194 If not installed, start from a blank load-path, since
195 PATH_LOADSEARCH refers to the eventual installation directories.
197 2012-07-07 Eli Zaretskii <eliz@gnu.org>
199 Support truncation and continuation glyphs on GUI frames, when
200 fringes are disabled. (Bug#11832)
201 * xdisp.c (init_iterator): Get dimensions of truncation and
202 continuation glyphs even if on GUI frames. Adjust
203 it->last_visible_x on GUI frames when the left or right fringes,
205 (start_display, move_it_in_display_line_to): Handle the case of a
206 GUI frame without a fringe to display continuation or truncation
208 (insert_left_trunc_glyphs): Support GUI frames: make sure
209 truncation glyphs overwrite enough glyphs from the current line to
210 have sufficient space in pixels.
211 (display_line): Support truncation and continuation glyphs on GUI
212 frames. If some spare pixels are left on the line after inserting
213 the truncation glyphs, fill that space with a stretch glyph of a
214 suitably computed width.
216 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
217 produce_glyphs, to support GUI sessions.
219 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
221 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
223 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
225 Do not require float-time's arg to fit in time_t (Bug#11825).
226 This works better on hosts where time_t is unsigned, and where
227 float-time is applied to the (negative) difference between two times.
228 * editfns.c (decode_time_components): Last arg is now double *,
229 not int *, and means to store all the result as a double, without
230 worrying about whether the seconds part fits in time_t.
232 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
234 (Ffloat_time): Do not fail merely because the specified time falls
235 outside of time_t range.
237 2012-07-07 Glenn Morris <rgm@gnu.org>
239 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
240 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
241 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
243 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
245 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
248 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
250 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
252 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
253 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
254 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
255 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
256 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
257 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
259 * xfont.c (compare_font_names): Redo to omit the need for casts.
261 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
263 * xfns.c (Fx_change_window_property): Doc fix.
264 * w32fns.c (Fx_change_window_property): Doc fix.
266 * w32fns.c (Fx_window_property): Accept the same arguments as the
267 X Windows version. Doc fix.
268 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
270 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
271 Eli Zaretskii <eliz@gnu.org>
273 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
274 Windows-specific code from nt/config.nt moved here.
275 Obsolete settings removed.
277 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
279 * process.c: Avoid unnecessary calls to gettime.
280 (wait_reading_process_output): Don't get the time of day
281 when gobbling data immediately and not waiting, as there's no need
282 for it in that case. This removes a FIXME.
284 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
286 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
287 is defined (Bug#11768).
289 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
291 Fix marker debugging code.
292 * marker.c (byte_char_debug_check): Do not perform the check
293 if buffer is not multibyte.
294 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
295 Call byte_char_debug_check with correct arguments.
297 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
299 Compile marker debugging code only if ENABLE_CHECKING is defined.
300 * marker.c (byte_char_debug_check, count_markers):
301 Use only if ENABLE_CHECKING is defined.
302 (byte_debug_flag): Remove.
303 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
304 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
306 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
308 Avoid code repetition in marker-related functions.
309 * marker.c (attach_marker): New function.
310 (Fset_marker, set_marker_restricted, set_marker_both)
311 (set_marker_restricted_both): Use it.
312 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
313 Consistently rename charno to charpos.
314 (marker_position): Add eassert.
315 (marker_byte_position): Convert to eassert.
317 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
319 Simplify list operations in unchain_overlay and unchain_marker.
320 * buffer.c (unchain_overlay): Simplify. Add comment.
321 * marker.c (unchain_marker): Simplify. Fix comments.
323 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
325 Introduce fast path for the widely used marker operation.
326 * alloc.c (build_marker): New function.
327 * lisp.h (build_marker): New prototype.
328 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
329 * composite.c (autocmp_chars): Likewise.
330 * editfns.c (buildmark): Remove.
331 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
332 (save_restriction_save): Use build_marker.
333 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
334 * window.c (save_window_save): Likewise.
336 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
338 Do not use Fdelete_overlay in delete_all_overlays
339 to avoid redundant calls to unchain_overlay.
340 * buffer.c (drop_overlay): New function.
341 (delete_all_overlays, Fdelete_overlay): Use it.
342 * minibuf.c (get_minibuffer): Fix comment.
344 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
346 Port to OpenBSD 5.1 amd64.
347 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
348 This is needed for OpenBSD, and should be harmless on all BSD systems.
349 Also, include <sys/sysctl.h>, as it should be available on all
350 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
351 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
352 use p_pid member, not kp_proc.pid.
354 2012-07-06 Glenn Morris <rgm@gnu.org>
356 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
358 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
360 More xmalloc and related cleanup.
361 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
362 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
363 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
364 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
365 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
366 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
367 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
368 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
369 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
371 Omit needless casts involving void * pointers and allocation.
372 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
373 as the former is more robust if P's type is changed.
374 Prefer xzalloc to xmalloc + memset 0.
375 Simplify malloc-or-realloc to realloc.
376 Don't worry about xmalloc returning a null pointer.
377 Prefer xstrdup to xmalloc + strcpy.
378 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
380 * keyboard.c (apply_modifiers_uncached): Prefer local array to
381 alloca of a constant.
383 2012-07-05 Eli Zaretskii <eliz@gnu.org>
385 * xdisp.c (display_line): Fix horizontal pixel coordinates when
386 hscroll is larger than the line width. Fixes long and futile
387 looping inside extend_face_to_end_of_line (on a TTY) producing
388 glyphs that are not needed and thrown away.
390 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
392 * marker.c (set_marker_restricted_both): Simplify by using
395 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
397 * editfns.c (region_limit): Simplify by using clip_to_bounds.
399 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
401 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
402 not defined (Bug#11768).
403 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
404 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
405 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
406 followed by gtk_box_set_homogeneous (Bug#11768).
407 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
408 (update_theme_scrollbar_width, xg_create_scroll_bar):
409 Use gtk_scrollbar_new (Bug#11768).
410 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
411 (is_box_type): New function (Bug#11768).
412 (xg_tool_item_stale_p): Call is_box_type.
413 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
414 with default display (Bug#11768).
416 2012-07-05 Eli Zaretskii <eliz@gnu.org>
418 * xdisp.c (window_hscroll_limited): New function.
419 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
420 coordinates when window's hscroll is set to insanely large
423 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
425 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
426 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
428 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
431 * lisp.h (xzalloc): New prototype. Omit needless casts.
432 * alloc.c (xzalloc): New function. Omit needless casts.
433 * charset.c: Omit needless casts. Convert all calls to
434 xmalloc with following memset to xzalloc.
435 * dispnew.c: Likewise.
436 * fringe.c: Likewise.
440 * w32fns.c: Likewise.
441 * w32font.c: Likewise.
442 * w32term.c: Likewise.
443 * xfaces.c: Likewise.
446 * atimer.c: Omit needless casts.
447 * buffer.c: Likewise.
448 * callproc.c: Likewise.
450 * coding.c: Likewise.
451 * composite.c: Likewise.
453 * doprnt.c: Likewise.
454 * editfns.c: Likewise.
457 * filelock.c: Likewise.
459 * gtkutil.c: Likewise.
460 * keyboard.c: Likewise.
463 * minibuf.c: Likewise.
466 * process.c: Likewise.
467 * region-cache.c: Likewise.
468 * search.c: Likewise.
469 * sysdep.c: Likewise.
470 * termcap.c: Likewise.
471 * terminal.c: Likewise.
472 * tparam.c: Likewise.
473 * w16select.c: Likewise.
475 * w32reg.c: Likewise.
476 * w32select.c: Likewise.
477 * w32uniscribe.c: Likewise.
478 * widget.c: Likewise.
482 * xselect.c: Likewise.
484 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
486 * fileio.c (time_error_value): Check the right error number.
487 Problem reported by Troels Nielsen in
488 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
490 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
492 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
493 This should be fixed in a better way; see Eli Zaretskii in
494 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
495 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
497 * fileio.c (time_error_value): Rename from special_mtime.
498 The old name's problems were noted by Eli Zaretskii in
499 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
501 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
502 This variable's comment says Emacs needs at least one GDB-visible
503 symbol of type enum pvec_type, to work around GDB problems.
504 The symbol's value doesn't matter.
506 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
507 that causes compilation to fail on pre-C99 compilers.
509 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
511 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
512 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
514 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
516 * buffer.c (init_buffer_once): Fix initialization of
517 headers for buffer_defaults and buffer_local_symbols.
518 Reported by Juanma Barranquero <lekktu@gmail.com>.
520 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
522 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
523 * lisp.h (enum pvec_type): Use fewer bits.
524 (PSEUDOVECTOR_SIZE_BITS): New constant.
525 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
526 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
528 (PSEUDOVECTOR_TYPEP): New macro.
529 (TYPED_PSEUDOVECTORP): Use it.
530 * fns.c (internal_equal): Adapt code to extract pvectype.
531 * emacs.c (gdb_pvec_type): Update type.
532 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
533 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
534 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
535 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
536 (sweep_vectors): Use it. Use local var `total_bytes' instead of
537 abusing vector->header.next.nbytes.
538 (live_vector_p): Use PVEC_TYPE.
539 (mark_object): Adapt code to extract pvectype. Use switch.
541 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
543 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
544 Tighten new eassert a bit.
546 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
548 Fix compilation with --enable-gcc-warnings and -O1
550 * doprnt.c (doprnt): Change type of tem to int, initialize
551 to avoid compiler warning. Add eassert.
552 * search.c (simple_search): Initialize match_byte to avoid
553 compiler warning. Add eassert.
555 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
557 Avoid weird behavior with large horizontal scrolls.
558 Without this change, for example, large hscroll values would
559 mess up Emacs's display on Fedora 15 x86, presumably due to
560 overflows in int calculations in the display code.
561 Also, if buffers had long lines, Emacs would freeze.
562 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
563 (set_window_hscroll): New function, containing the old guts of
564 Fset_window_hscroll. Return the clipped value.
565 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
566 This avoids the need to check against PTRDIFF_MAX.
568 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
570 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
572 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
574 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
576 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
577 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
578 since GCC 4.4.6 issues a bogus warning for them.
580 Fix bugs in file timestamp newness comparisons.
581 * fileio.c (Ffile_newer_than_file_p):
582 * lread.c (Fload): Use full timestamp resolution of files,
583 not just the 1-second resolution, so that files that are only
584 slightly newer still count as newer.
585 * fileio.c (Ffile_newer_than_file_p): Don't assume file
586 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
588 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
590 * fileio.c: Improve handling of file time marker. (Bug#11852)
591 (special_mtime): New function.
592 (Finsert_file_contents, Fverify_visited_file_modtime):
593 Use it to set special mtime values consistently.
595 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
597 * fileio.c (Finsert_file_contents): Properly handle st_mtime
598 marker for non-existing file. (Bug#11852)
600 2012-07-03 Glenn Morris <rgm@gnu.org>
602 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
603 and did not make it into globals.h).
605 2012-07-03 Tom Tromey <tromey@redhat.com>
607 * window.c (Fset_window_margins, Fset_window_fringes)
608 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
609 * textprop.c (Fprevious_property_change): No longer static.
610 * syntax.c (Fsyntax_table_p): No longer static.
611 * process.c (Fget_process, Fprocess_datagram_address): No longer
613 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
614 * keyboard.c (Fcommand_execute): No longer static.
616 * insdel.c (Fcombine_after_change_execute): No longer static.
617 * image.c (Finit_image_library): No longer static.
618 * fileio.c (Fmake_symbolic_link): No longer static.
619 * eval.c (Ffetch_bytecode): No longer static.
620 * editfns.c (Fuser_full_name): No longer static.
621 * doc.c (Fdocumentation_property, Fsnarf_documentation):
623 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
625 * dired.c (Ffile_attributes): No longer static.
626 * composite.c (Fcomposition_get_gstring): No longer static.
627 * callproc.c (Fgetenv_internal): No longer static.
629 * ccl.h: Remove EXFUNs.
630 * buffer.h: Remove EXFUNs.
631 * dispextern.h: Remove EXFUNs.
632 * intervals.h: Remove EXFUNs.
633 * fontset.h: Remove EXFUN.
634 * font.h: Remove EXFUNs.
635 * dosfns.c (system_process_attributes): Remove EXFUN.
636 * keymap.h: Remove EXFUNs.
637 * lisp.h: Remove EXFUNs.
638 * w32term.h: Remove EXFUNs.
639 * window.h: Remove EXFUNs.
640 * xsettings.h: Remove EXFUN.
641 * xterm.h: Remove EXFUN.
643 2012-07-03 Glenn Morris <rgm@gnu.org>
645 * lisp.h (Frandom): Make it visible to C.
646 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
647 buffer for invisible buffers. (Bug#1229)
649 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
651 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
652 values which aren't power of 2.
653 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
654 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
657 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
659 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
661 * alloc.c (mark_object): Revert part of last patch to use `switch'.
663 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
665 * alloc.c (allocate_vector_block): Remove redundant
666 calls to mallopt if DOUG_LEA_MALLOC is defined.
667 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
668 avoid calls to mallopt if zero_vector is returned.
670 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
672 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
673 is enabled, avoid dereferencing NULL current_sblock if
676 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
678 Cleanup basic buffer management.
679 * buffer.h (struct buffer): Change layout to use generic vector
680 marking code. Fix some comments. Change type of 'clip_changed'
681 to bitfield. Remove unused #ifndef old.
682 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
683 (GET_OVERLAYS_AT): Fix indentation.
684 (for_each_per_buffer_object_at): New macro.
685 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
686 (Fbuffer_local_variables): Use it.
687 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
688 * alloc.c (allocate_buffer): Adjust to match new layout of
689 struct buffer. Fix comment.
690 (mark_overlay): New function.
691 (mark_buffer): Use it. Use mark_vectorlike to mark normal
692 Lisp area of struct buffer.
693 (mark_object): Use it. Adjust marking of misc objects
694 and related comments.
696 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
698 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
699 wrapper that is not needed because the wrapped code is a no-op (zero
700 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
701 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
703 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
705 * alloc.c (mark_buffer): Simplify. Remove prototype.
706 (mark_object): Add comment. Reorganize marking of vector-like
707 objects. Use CHECK_LIVE for all vector-like objects except buffers
708 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
709 redundant calls to mark_vectorlike for bool vectors.
711 2012-06-30 Glenn Morris <rgm@gnu.org>
713 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
715 * epaths.in (PATH_SITELOADSEARCH): New.
716 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
717 This is rather than relying on --enable-locallisppath elements
718 having "site-lisp" in their names. (Bug#10208#25, 11658)
720 2012-06-30 Eli Zaretskii <eliz@gnu.org>
722 * w32proc.c (sys_select): Accept and ignore one more argument.
724 * w32.c (emacs_gnutls_pull): Call select with one more argument.
726 * sysselect.h [DOS_NT]: Don't include sys/select.h.
727 (pselect) [!MS_DOS]: Redirect to sys_select.
729 * sysdep.c: Don't include dos.h and dosfns.h.
731 * process.c (sys_select):
732 * msdos.c (sys_select): Accept one more argument and ignore it.
734 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
735 adapt data types and code to that.
738 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
739 which clashes with the gnulib function of the same name.
741 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
743 * font.c (font_style_to_value, font_style_symbolic)
744 (font_prop_validate_style): Add type checks for values in
747 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
749 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
752 2012-06-29 Eli Zaretskii <eliz@gnu.org>
754 * xdisp.c (try_window_id): Undo last change.
756 * w32.c (getwd): Adjust commentary about startup_dir.
757 (init_environment): Always call sys_access, even in non-MSVC
758 builds. Don't chdir to the directory of the Emacs executable.
759 This undoes code from 1997 which was justified by the need to
760 "avoid conflicts when removing and renaming directories". But its
761 downside was that every relative file name was being interpreted
762 relative to the directory of the Emacs executable, which can never
763 be TRT. In particular, it broke sys_access when called with
765 (sys_access): Map GetLastError to errno.
767 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
769 * window.h (struct window): Change type of 'fringes_outside_margins'
770 to bitfield. Fix comment. Adjust users accordingly.
771 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
773 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
776 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
778 * gnutls.c (emacs_gnutls_handshake):
779 Add QUIT to make the loop interruptible.
781 2012-06-29 Glenn Morris <rgm@gnu.org>
783 * charset.c (init_charset): Make lack of etc/charsets fatal.
785 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
787 * editfns.c (region_limit): Fix type mismatch.
789 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
791 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
792 undefined. Convert from xassert to eassert.
793 * nsmenu.m: Convert from xassert to eassert.
794 * nsterm.m: Likewise.
796 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
798 * editfns.c (region_limit): Clip to narrowing (bug#11770).
800 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
802 Avoid integer overflow on scroll-left and scroll-right.
803 * window.c (HSCROLL_MAX): New macro.
804 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
805 overflow when requested scroll falls outside ptrdiff_t range.
807 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
809 * window.h (struct window): Change type of 'hscroll',
810 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
811 'last_modified' and 'last_overlay_modified' to EMACS_INT.
812 Adjust users accordingly.
813 * xdisp.c (try_cursor_movement): Replace type check with eassert.
814 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
815 from EMACS_INT to ptrdiff_t.
816 (make_window): Omit redundant initialization.
818 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
820 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
822 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
824 * window.h (struct window): Change type of 'use_time' and
825 'sequence_number' from Lisp_Object to int.
826 * frame.c (make_frame): Adjust users accordingly.
827 * print.c (print_object): Likewise.
828 * window.c (select_window, Fwindow_use_time, make_parent_window)
829 (make_window): Likewise.
831 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
833 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
834 enabled with --enable-checking=[all,glyphs] configure option.
835 Fix GLYPH_DEBUG usage assuming that it may be undefined,
836 adjust comments accordingly.
837 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
838 undefined, adjust comments accordingly.
840 * scroll.c: Likewise.
841 * w32fns.c: Likewise.
842 * w32term.c: Likewise.
844 * xfaces.c: Likewise.
848 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
850 Generalize run-time debugging checks.
851 * dispextern.h (XASSERTS): Remove.
852 * fontset.c (xassert): Remove.
853 Convert from xassert to eassert.
854 * alloc.c: Convert from xassert to eassert.
856 * dispnew.c: Likewise.
858 * fringe.c: Likewise.
859 * ftfont.c: Likewise.
860 * gtkutil.c: Likewise.
862 * keyboard.c: Likewise.
864 * process.c: Likewise.
865 * scroll.c: Likewise.
868 * w32console.c: Likewise.
869 * w32fns.c: Likewise.
870 * w32term.c: Likewise.
871 * window.c: Likewise.
873 * xfaces.c: Likewise.
875 * xselect.c: Likewise.
878 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
880 * fns.c (maybe_resize_hash_table): Output message when growing the
883 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
885 * alloc.c (allocate_string_data): Remove dead code.
886 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
887 avoid GCC warning about unused macro.
889 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
891 * alloc.c (allocate_string): Omit intervals initialization.
892 * alloc.c (make_uninit_multibyte_string): Initialize intervals
893 as in make_pure_string and make_pure_c_string.
895 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
897 * alloc.c (allocate_string): Fix last change.
899 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
901 * alloc.c (allocate_string): Remove two redundant calls
902 to memset, add explicit initialization where appropriate.
904 2012-06-27 Glenn Morris <rgm@gnu.org>
906 * lisp.mk (lisp): Remove paths.elc.
908 2012-06-27 Chong Yidong <cyd@gnu.org>
910 * doc.c (Fsubstitute_command_keys): Fix punctuation.
912 2012-06-26 John Wiegley <johnw@newartisans.com>
914 * unexmacosx.c (copy_data_segment): Add two section names used
915 on Mac OS X Lion: __mod_init_func and __mod_term_func.
917 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
918 when building with Clang.
920 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
922 * eval.c (Fapply): Allow calling it with a single argument.
924 2012-06-26 Eli Zaretskii <eliz@gnu.org>
926 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
927 _stricmp and _strnicmp.
928 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
930 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
932 * alloc.c (allocate_window): Zero out non-Lisp part of newly
934 (allocate_process): Likewise for new process.
935 (allocate_terminal): Change to use offsetof.
936 (allocate_frame): Likewise.
937 * frame.c (make_frame): Omit redundant initialization.
938 * window.c (make_parent_window): Use memset.
939 (make_window): Omit redundant initialization.
940 * process.c (make_process): Omit redundant initialization.
941 * terminal.c (create_terminal): Likewise.
943 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
945 * term.c (delete_tty): Remove redundant call to memset.
947 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
949 * alloc.c: Remove build_string.
950 * lisp.h: Define build_string as static inline. This provides
951 a better opportunity to optimize away calls to strlen when the
952 function is called with compile-time constant argument.
953 * image.c (imagemagick_error): Convert to build_string.
954 * w32proc.c (sys_spawnve): Likewise.
955 * xterm.c (x_term_init): Likewise.
957 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
959 Use sprintf return value instead of invoking strlen on result.
960 In the old days this wasn't portable, since some sprintf
961 implementations returned char *. But they died out years ago and
962 Emacs already assumes sprintf returns int.
963 Similarly for float_to_string.
964 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
965 * ccl.c (ccl_driver):
966 * character.c (string_escape_byte8):
967 * data.c (Fnumber_to_string):
969 * print.c (print_object):
970 * xdisp.c (message_dolog):
971 * xfns.c (syms_of_xfns):
972 Use sprintf or float_to_string result to avoid need to call strlen.
973 * data.c (Fnumber_to_string):
974 Use make_unibyte_string, since the string must be ASCII.
975 * lisp.h, print.c (float_to_string): Now returns int length.
976 * term.c (produce_glyphless_glyph):
977 Use sprintf result rather than recomputing it.
979 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
980 * Makefile.in (ALL_CFLAGS):
981 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
982 * gmalloc.c, regex.c: Include <config.h> unconditionally.
984 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
986 * dispextern.h (xstrcasecmp): Define to library function
987 strcasecmp if available.
988 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
990 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
992 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
993 Avoid comma operator.
994 * menu.c (push_submenu_start, push_submenu_end)
995 (push_left_right_boundary, push_menu_pane): Likewise.
996 * msdos.c (dos_rawgetc): Likewise.
998 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1000 * xfns.c (xic_create_fontsetname): Remove redundant calls
1003 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1005 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1006 sprintf already null-terminates its output.
1008 * xfns.c (x_window): Remove redundant cast.
1010 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1012 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1013 `const char *' to `char *' to avoid compiler warning.
1015 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1017 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1018 instead of truncating it to 63 (admittedly a generous limit).
1020 * process.c: Fix spelling and caps in comments.
1022 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1024 * emacs.c (setpgrp): Remove definition, unused.
1025 * sysdep.c (setpgrp): Remove definition, not used in this file.
1027 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
1029 * makefile.w32-in: Update dependencies.
1031 2012-06-24 Eli Zaretskii <eliz@gnu.org>
1033 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1034 (SYSTIME_H): Add nt/inc/sys/time.h.
1036 * systime.h [WINDOWSNT]: Include sys/time.h.
1038 * s/ms-w32.h (struct timespec): Definition moved from
1039 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1041 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1043 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1044 * buffer.h (buffer_slot_type_mismatch):
1045 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1046 * eval.c (unwind_to_catch):
1047 * image.c (my_png_error, my_error_exit):
1048 * keyboard.c (quit_throw_to_read_char, user_error)
1049 (Fexit_recursive_edit, Fabort_recursive_edit):
1050 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1051 (wrong_type_argument, buffer_overflow, __executable_start)
1052 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1053 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1054 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1056 (child_setup) [!DOS_NT]:
1057 * lread.c (end_of_file_error, invalid_syntax):
1058 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1059 * puresize.h (pure_write_error):
1060 * search.c (matcher_overflow):
1061 * sound.c (sound_perror, alsa_sound_perror):
1062 * sysdep.c, syssignal.h (croak):
1063 * term.c (maybe_fatal, vfatal):
1064 * textprop.c (text_read_only):
1065 * undo.c (user_error):
1066 * unexmacosx.c (unexec_error):
1067 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1068 Use _Noreturn rather than NO_RETURN.
1069 No need for separate decl merely because of _Noreturn.
1070 * sound.c (sound_warning, parse_sound):
1071 Remove unnecessary forward decls.
1073 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1075 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1076 * lisp.h (WAIT_READING_MAX): New macro.
1077 * dispnew.c (Fsleep_for, sit_for):
1078 * keyboard.c (kbd_buffer_get_event):
1079 * process.c (Faccept_process_output):
1080 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1081 This improves on the previous patch, which introduced a bug
1082 when time_t is unsigned and as wide as intmax_t.
1083 See <http://bugs.gnu.org/9000#51>.
1085 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1087 * dispnew.c (sit_for, Fsleep_for):
1088 * keyboard.c (kbd_buffer_get_event):
1089 * process.c (Faccept_process_output): Avoid compiler warnings when
1090 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1092 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
1094 * makefile.w32-in: Update dependencies.
1096 * w32.c (ltime): Add return type and declare static.
1097 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1099 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1101 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1102 Privately reported by Herbert J. Skuhra.
1103 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1105 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1106 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1108 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1110 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1111 last argument of make_unibyte_string.
1113 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1114 language ID in the event parameters.
1116 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1117 event.code, not the obscure "character set ID".
1119 2012-06-23 Chong Yidong <cyd@gnu.org>
1121 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1123 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1125 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1126 * w32.c (fdutimens): New function.
1128 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1130 * s/ms-w32.h (pselect): Redirect to sys_select.
1132 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1134 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1135 in the logic of incrementing and decrementing the value of
1136 use_relocatable_buffers.
1138 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1140 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1141 Privately reported by Herbert J. Skuhra.
1142 [__FreeBSD__]: Remove "*/" typo after "#include".
1143 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1144 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1145 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1146 Don't assume EMACS_TIME and struct timeval are the same type.
1148 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1150 Support higher-resolution time stamps (Bug#9000).
1151 The time stamps are only nanosecond-resolution at the C level,
1152 since that's the best that any real-world system supports now.
1153 But they are picosecond-resolution at the Lisp level, as that's
1154 easy, and leaves room for future OS improvements.
1156 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1159 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1160 Don't get current time unless it's needed.
1162 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1163 now provides it if it's absent.
1164 (start_atimer): Port to higher-res time stamps.
1165 Check for time stamp overflow. Don't get current time more
1166 often than is needed.
1168 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1169 Include systime.h, not time.h.
1170 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1172 * dired.c: Include stat-time.h.
1173 (Ffile-attributes): File times now have higher resolution.
1175 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1176 (struct image): Timestamp now has higher resolution.
1178 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1179 has at least microseconds now. All uses removed.
1180 (update_frame, update_single_window, update_window, update_frame_1)
1181 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1183 * editfns.c (time_overflow): Now extern.
1184 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1185 (float-time, Fformat_time_string, Fcurrent_time_string)
1186 (Fcurrent_time_zone): Accept and generate higher-resolution
1188 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1189 (decode_time_components, lisp_seconds_argument): New functions.
1190 (make_time): Now static.
1191 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1192 Report an error if the time is invalid, rather than having the caller
1195 * fileio.c: Include <stat-time.h>
1196 (Fcopy_file): Copy higher-resolution time stamps.
1197 Prefer to set the time stamp via a file descriptor if that works.
1198 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1199 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1200 (Fvisited_file_modtime, Fset_visited_file_modtime):
1201 Support higher-resolution time stamps.
1203 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1205 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1207 * image.c (prepare_image_for_display, clear_image_cache)
1208 (lookup_image): Port to higer-resolution time stamps.
1210 * keyboard.c (start_polling, bind_polling_period):
1211 Check for time stamp overflow.
1212 (read_char, kbd_buffer_get_event, timer_start_idle)
1213 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1214 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1215 Port to higher-resolution time stamps. Do not assume time_t is signed.
1216 (decode_timer): New function. Timers are now vectors of length 9,
1217 not 8, to accommodate the picosecond component.
1218 (timer_check_2): Use it.
1220 * nsterm.m (select_timeout, timeval_subtract): Remove.
1221 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1222 as they're a bit more accurate and handle overflow better.
1223 (ns_select): Change prototype to be compatible with pselect.
1224 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1225 * nsterm.h (ns_select): Adjust prototype.
1227 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1228 us-resolution time stamps.
1229 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1231 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1233 * lisp.h (time_overflow): New decl.
1234 (wait_reading_process_output): First arg is now intmax_t, not int,
1235 to accommodate larger waits.
1237 * process.h (struct Lisp_Process.read_output_delay):
1238 Now counts nanoseconds, not microseconds.
1239 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1241 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1242 (wait_reading_process_output):
1243 Port to ns-resolution time stamps.
1244 (Faccept_process_output, wait_reading_process_output):
1245 Check for time stamp overflow. Do not assume time_t is signed.
1246 (select_wrapper): Remove; we now use pselect.
1247 (Fprocess_attributes): Now generates ns-resolution time stamps.
1249 * sysdep.c: Include utimens.h. Don't include utime.h
1250 or worry about struct utimbuf; gnulib does that for us now.
1251 (gettimeofday): Remove; gnulib provides a substitute.
1252 (make_timeval): New function.
1253 (set_file_times): Now sets ns-resolution time stamps.
1254 New arg FD; all uses changed.
1255 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1256 (system_process_attributes):
1257 Now returns ns-resolution time stamp. All uses changed.
1258 Check for time stamp overflow.
1260 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1261 provides a substitute now.
1263 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1264 since it guarantees struct timespec.
1265 (EMACS_TIME): Now struct timespec, so that we can support
1266 ns-resolution time stamps.
1267 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1268 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1269 (EMACS_USECS): Remove.
1270 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1271 so multiply the arg by 1000 before storing it.
1272 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1274 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1275 Port to ns-resolution time stamps.
1276 (EMACS_TIME_NEG_P): Remove; replaced by....
1277 (EMACS_TIME_SIGN): New macro.
1278 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1279 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1280 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1281 (make_timeval, make_lisp_time, decode_time_components): New decls.
1282 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1283 that it mishandled time_t overflow. You can't compare by subtracting!
1284 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1285 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1287 * term.c: Include <sys/time.h>.
1288 (timeval_to_Time): New function, for proper overflow wraparound.
1289 (term_mouse_position, term_mouse_click): Use it.
1291 * undo.c (record_first_change): Support higher-resolution time stamps
1293 (Fprimitive_undo): Use them when restoring time stamps.
1295 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1296 (w32_get_internal_run_time):
1297 Port to higher-resolution Emacs time stamps.
1298 (ltime): Now accepts single 64-bit integer, as that's more convenient
1301 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1303 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1304 for compatibility with pselect. Support ns-resolution time stamps.
1306 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1308 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1309 Check for time stamp overflow, and support ns-resolution time stamps.
1311 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1312 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1313 (timeval_subtract): Remove; no longer needed.
1314 (XTflash, XTring_bell, x_wait_for_event):
1315 Port to ns-resolution time stamps. Don't assume time_t is signed.
1317 2012-06-22 Chong Yidong <cyd@gnu.org>
1319 * xdisp.c (x_consider_frame_title): Revert last change.
1321 2012-06-22 Eli Zaretskii <eliz@gnu.org>
1323 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1324 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1325 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1326 staticidx goes up to 1597 out of 1600 = 0x640.)
1328 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1330 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1331 Otherwise, the umask might be mistakenly 0 while handling input signals.
1333 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1335 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1337 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1339 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1340 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1341 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1342 access to `contents' member of Lisp_Vector objects with AREF and ASET
1345 2012-06-19 Chong Yidong <cyd@gnu.org>
1347 * frame.c (delete_frame): When selecting a frame on a different
1348 text terminal, do not alter the terminal's top-frame.
1350 * xdisp.c (format_mode_line_unwind_data): Record the target
1351 frame's selected window and its terminal's top-frame.
1352 (unwind_format_mode_line): Restore them.
1353 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1355 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1356 since tty frames can be explicitly named.
1357 (prepare_menu_bars): Likewise.
1359 * term.c (Ftty_top_frame): New function.
1361 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1363 Port byte-code-meter to modern targets.
1364 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1365 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
1366 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
1367 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1368 (METER_1, METER_2): Simplify.
1370 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1372 * data.c (Fdefalias): Return `symbol' (bug#11686).
1374 2012-06-18 Martin Rudalics <rudalics@gmx.at>
1376 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1377 gets killed during executing of this function (Bug#11665).
1378 Try to always return Qt when the buffer has been actually killed.
1379 (Vkill_buffer_query_functions): In doc-string say that functions
1380 run by this hook should not change the current buffer.
1382 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1384 Fix recently-introduced process.c problems found by static checking.
1385 * process.c (write_queue_push, write_queue_pop, send_process):
1386 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1387 (write_queue_pop): Fix pointer signedness problem.
1388 (send_process): Remove unused local.
1390 2012-06-17 Chong Yidong <cyd@gnu.org>
1392 * xdisp.c (redisplay_internal): No need to redisplay terminal
1393 frames that are not on top.
1395 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
1397 * process.c (make_process): Initialize write_queue.
1398 (write_queue_push, write_queue_pop): New functions.
1399 (send_process): Use them to maintain correct ordering of process
1402 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1404 * lisp.h (eassert): Assume C89 or later.
1405 This removes the need for CHECK.
1406 (CHECK): Remove. Its comments about always evaluating its
1407 argument were confusing, as 'eassert' typically does not evaluate
1410 * coding.c (produce_chars): Use ptrdiff_t, not int.
1412 * xterm.c (x_draw_underwave): Check for integer overflow.
1413 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1415 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
1417 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1418 referenced (Bug#11583).
1420 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1422 Implement wave-style variant of underlining.
1423 * dispextern.h (face_underline_type): New enum.
1424 (face): Add field for underline type.
1425 * nsterm.m (ns_draw_underwave): New function.
1426 (ns_draw_text_decoration): Use it.
1427 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1429 (x_draw_glyph_string): Use them.
1430 * xfaces.c (Qline, Qwave): New Lisp objects.
1431 (check_lface_attrs, merge_face_ref)
1432 (Finternal_set_lisp_face_attribute, realize_x_face):
1433 Handle wave-style underline face attributes.
1434 * xterm.c (x_draw_underwave): New function.
1435 (x_draw_glyph_string): Use it.
1437 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
1439 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1440 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1441 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1442 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1443 ($(BLD)/w32select.$(O)): Update dependencies.
1445 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1447 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1448 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1449 * character.c (_fetch_multibyte_char_p): Remove.
1450 * alloc.c: Include "character.h" before "buffer.h".
1452 * buffer.c: Likewise.
1453 * bytecode.c: Likewise.
1454 * callint.c: Likewise.
1455 * callproc.c: Likewise.
1456 * casefiddle.c: Likewise.
1457 * casetab.c: Likewise.
1458 * category.c: Likewise.
1460 * coding.c: Likewise.
1461 * composite.c: Likewise.
1462 * dired.c: Likewise.
1463 * dispnew.c: Likewise.
1465 * dosfns.c: Likewise.
1466 * editfns.c: Likewise.
1467 * emacs.c: Likewise.
1468 * fileio.c: Likewise.
1469 * filelock.c: Likewise.
1471 * fontset.c: Likewise.
1472 * fringe.c: Likewise.
1473 * indent.c: Likewise.
1474 * insdel.c: Likewise.
1475 * intervals.c: Likewise.
1476 * keyboard.c: Likewise.
1477 * keymap.c: Likewise.
1478 * lread.c: Likewise.
1479 * macros.c: Likewise.
1480 * marker.c: Likewise.
1481 * minibuf.c: Likewise.
1482 * nsfns.m: Likewise.
1483 * nsmenu.m: Likewise.
1484 * print.c: Likewise.
1485 * process.c: Likewise.
1486 * regex.c: Likewise.
1487 * region-cache.c: Likewise.
1488 * search.c: Likewise.
1489 * syntax.c: Likewise.
1491 * textprop.c: Likewise.
1493 * unexsol.c: Likewise.
1494 * w16select.c: Likewise.
1495 * w32fns.c: Likewise.
1496 * w32menu.c: Likewise.
1497 * window.c: Likewise.
1498 * xdisp.c: Likewise.
1500 * xmenu.c: Likewise.
1502 * xselect.c: Likewise.
1504 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1506 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1507 If all the glyphs of the glyph row came from strings, and we have no
1508 cursor positioning clues, put the cursor on the first glyph of the
1510 (handle_face_prop): Use chunk-relative overlay string index when
1511 indexing into it->string_overlays array. (Bug#11653)
1512 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1513 the rightmost. (Bug#11720)
1515 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1517 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1518 (CATEGORY_MEMBER): Enforce 1/0 value.
1519 * category.c (_temp_category_set): Remove.
1521 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1523 * window.c (Fdelete_other_windows_internal)
1524 (Fdelete_window_internal): Don't access frame's mouse highlight
1525 info of the initial frame. (Bug#11677)
1527 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1529 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1530 Assume USE_2_TAGS_FOR_INTS.
1531 (xreload): Adjust $tagmask width to match recent lisp.h change.
1533 Simplify lisp.h in minor ways that should not affect code.
1534 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1535 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1536 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1537 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1538 (INTTYPEBITS): New macro, for clarity.
1539 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1540 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1541 Simplify now that USE_LSB_TAG is always defined.
1542 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1543 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1545 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
1547 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1549 2012-06-13 Glenn Morris <rgm@gnu.org>
1551 * s/bsd-common.h (BSD4_3):
1552 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1554 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1556 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1559 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1561 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
1562 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1563 * alloc.c (widen_to_Lisp_Object): Remove.
1564 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1565 * frame.c (delete_frame): Remove outdated comment.
1566 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1567 USE_LISP_UNION_TYPE.
1568 (Fw32_unregister_hot_key): Likewise.
1569 (Fw32_toggle_lock_key): Likewise.
1570 * w32menu.c (add_menu_item): Likewise.
1571 (w32_menu_display_help): Use XIL instead of checking
1572 USE_LISP_UNION_TYPE.
1573 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1574 (init_heap): Likewise.
1575 * w32term.c (w32_read_socket): Update comment.
1577 2012-06-13 Glenn Morris <rgm@gnu.org>
1579 * s/usg5-4-common.h, src/s/unixware.h:
1580 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1582 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1584 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1586 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1587 * alloc.c (make_number) [!defined make_number]:
1588 Remove, as lisp.h always defines this now.
1589 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1590 (roundup_size): Verify that it is a power of 2.
1591 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1592 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1593 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1594 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1595 USE_LSB_TAG now is always defined to be either 0 or 1.
1597 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1598 code works fine either way, and efficiency is not a concern here,
1599 as the union type is for debugging, not for production.
1600 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1601 Use an inline function on all platforms when using the union type,
1602 since this is simpler and 'static inline' can be used portably
1604 (LISP_INITIALLY_ZERO): New macro.
1605 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1606 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1608 2012-06-12 Glenn Morris <rgm@gnu.org>
1610 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1612 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
1614 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1615 Move BROKEN_SIGIO to configure.
1617 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1618 Move NO_TERMIO to configure.
1620 2012-06-12 Chong Yidong <cyd@gnu.org>
1622 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1623 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1624 MagickExportImagePixels is undefined.
1626 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1628 * image.c (imagemagick_load_image): Remove unused label.
1630 2012-06-11 Glenn Morris <rgm@gnu.org>
1632 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1633 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1634 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1635 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1637 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1639 * alloc.c (make_byte_code): New function.
1640 (Fmake_byte_code): Use it. Don't purify here.
1641 * lread.c (read1): Use it as well to avoid extra allocation.
1643 2012-06-11 Chong Yidong <cyd@gnu.org>
1645 * image.c (imagemagick_load_image): Implement transparency.
1647 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1649 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1650 account for preceding backslashes. (Bug#11663)
1652 2012-06-09 Chong Yidong <cyd@gnu.org>
1654 * term.c: Support italics in capable terminals (Bug#9652).
1655 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1656 (turn_on_face): Output using TS_enter_italic_mode if available.
1657 Don't handle unused blinking and alt-charset cases.
1658 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1659 and tty_alt_charset_p cases.
1660 (tty_capable_p, init_tty): Support italics.
1662 * termchar.h (struct tty_display_info): Add field for italics.
1663 Remove unused blink field.
1665 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1668 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1669 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1670 tty_alt_charset_p. Add tty_italic_p.
1672 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
1674 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1675 dbus_type_is_basic if available.
1676 (xd_extract_signed, xd_extract_unsigned): Rename from
1677 extract_signed and extract_unsigned, respectively. Adapt callers.
1679 2012-06-09 Chong Yidong <cyd@gnu.org>
1681 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1683 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1686 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1688 * xdisp.c (vmessage): Treat frame message as multibyte.
1689 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1690 would generate the diagnostic "Making \302\247 buffer-local while
1693 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1695 * dispnew.c (showing_window_margins_p): Undo last change, which
1696 was done due to an inadvertent commit.
1697 (adjust_frame_glyphs_for_frame_redisplay): Do call
1698 showing_window_margins_p.
1700 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1702 * eval.c (Fmake_var_non_special): New primitive.
1703 (syms_of_eval): Defsubr it.
1704 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1706 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
1708 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1709 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1711 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1713 * alloc.c (allocate_vectorlike): Fix last change.
1715 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1717 Block-based vector allocation of small vectors.
1718 * lisp.h (struct vectorlike_header): New field `nbytes',
1719 adjust comment accordingly.
1720 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1721 to denote vector blocks. Adjust users (live_vector_p,
1722 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1723 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1724 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1725 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1726 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1727 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1728 (roundup_size): New constant.
1729 (struct vector_block): New data type.
1730 (vector_blocks, vector_free_lists, zero_vector): New variables.
1731 (all_vectors): Rename to `large_vectors'.
1732 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1733 (sweep_vectors): New functions.
1734 (allocate_vectorlike): Return `zero_vector' as the only vector of
1735 0 items. Allocate new vector from block if vector size is less than
1736 or equal to VBLOCK_BYTES_MAX.
1737 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1738 (init_alloc_once): Add call to init_vectors.
1740 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1742 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1744 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1746 * doprnt.c (doprnt): Truncate multibyte char correctly.
1747 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1748 would mishandle a string argument "Xc" if X was a multibyte
1749 character of length 2: it would truncate after X's first byte
1750 rather than including all of X.
1752 2012-06-06 Chong Yidong <cyd@gnu.org>
1754 * buffer.c (word_wrap): Doc fix.
1756 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1758 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1760 2012-06-03 Glenn Morris <rgm@gnu.org>
1762 * xdisp.c (tool-bar-style): Doc fix.
1764 2012-06-03 Ulrich Müller <ulm@gentoo.org>
1766 * Makefile.in (PAXCTL): Define.
1767 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1768 binary via PaX flags if the paxctl utility is available.
1769 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1770 Restore PaX flags to their default. (Bug#11398)
1772 2012-06-03 Chong Yidong <cyd@gnu.org>
1774 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1777 2012-06-03 Chong Yidong <cyd@gnu.org>
1779 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1780 (note_mode_line_or_margin_highlight): If there is no help echo,
1781 use mode-line-default-help-echo. Handle the case where the mouse
1782 position is past the end of the mode line string.
1784 * buffer.c (buffer_local_value_1): New function, split from
1785 Fbuffer_local_value; can return Qunbound.
1786 (Fbuffer_local_value): Use it.
1787 (Vmode_line_format): Docstring tweaks.
1789 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1791 * sysdep.c (system_process_attributes): Improve comment.
1793 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1795 * keyboard.c: Export real-this-command to Elisp.
1796 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1797 and DEFVAR it. Update all users.
1799 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1801 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1803 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1804 Convert pctcpu and pctmem to Lisp float properly.
1805 Let the compiler fold better, as 100.0/0x8000 is exact.
1807 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1809 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1812 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1814 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1816 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1818 For a 'struct window', replace some Lisp_Object fields to
1819 bitfields where appropriate, remove unused fields.
1820 * window.h (struct window): Remove unused 'last_mark_x' and
1821 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1822 change it's type from Lisp_Object to bitfield.
1823 Change type of 'force_start', 'optional_new_start',
1824 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1825 fields from Lisp_Object to bitfield. Adjust users accordingly.
1827 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1829 Pacify gcc -Wdouble-precision when using Xaw.
1830 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1831 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1832 Use 'float' consistently, rather than 'float' in most places
1833 and 'double' in a couple of places.
1835 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1837 * xdisp.c (handle_stop): Detect whether we have overlay strings
1838 loaded by testing it->current.overlay_string_index to be
1839 non-negative, instead of checking whether n_overlay_strings is
1840 positive. (Bug#11587)
1842 2012-05-31 Chong Yidong <cyd@gnu.org>
1844 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1846 * doc.c (Fsubstitute_command_keys): Doc fix.
1848 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1850 * search.c (search_buffer): Remove calls to
1851 r_alloc_inhibit_buffer_relocation, as it is now called by
1852 maybe_unify_char, which was the cause of relocation of buffer text
1855 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1857 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1858 for the duration of call to load_charset, to avoid problems with
1859 callers of maybe_unify_char that access buffer text through C
1862 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1863 decrement the inhibition flag, instead of just setting or
1866 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1868 Remove obsolete '#define static' cruft.
1869 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1870 This #undef was "temporary" in 2000; it is no longer needed
1871 now that '#define static' has gone away.
1872 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1873 (gray_bitmap_bits): Remove; no longer needed.
1874 All uses replaced with definiens.
1875 * xterm.c: Include "bitmaps/gray.xbm".
1877 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1879 Clean up __executable_start, monstartup when --enable-profiling.
1880 The following changes affect the code only when profiling.
1881 * dispnew.c (__executable_start): Rename from safe_bcopy.
1882 Define only on platforms that need it.
1883 * emacs.c: Include <sys/gmon.h> when profiling.
1884 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1885 (__executable_start): Remove decl, since lisp.h does it now.
1886 (safe_bcopy): Remove decl; no longer has that name.
1887 (main): Coalesce #if into single bit of code, for simplicity.
1888 Cast pointers to uintptr_t, since standard libraries want integers
1890 * lisp.h (__executable_start): New decl.
1892 2012-05-31 Glenn Morris <rgm@gnu.org>
1894 * image.c (Fimagemagick_types): Doc fix.
1896 2012-05-30 Jim Meyering <meyering@redhat.com>
1898 * callproc.c (Fcall_process_region): Include directory component
1899 in mkstemp error message (Bug#11586).
1901 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1903 * alloc.c, lisp.h (make_pure_vector): Now static.
1905 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1907 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1908 Move to byte-run.el.
1909 (Fautoload): Do the hash-doc more carefully.
1910 * data.c (Fdefalias): Purify definition, except for keymaps.
1911 (Qdefun): Move from eval.c.
1912 * lisp.h (Qdefun): Remove.
1913 * lread.c (read1): Tiny simplification.
1915 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
1917 Do not create empty overlays with the evaporate property (Bug#9642).
1918 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1919 Bug#9642, but explicitly check that the buffer the overlay would
1920 be moved to is live and rearrange lines to make sure that errors
1921 will not put the overlay in an inconsistent state.
1922 (Fdelete_overlay): Cosmetics.
1924 2012-05-28 Eli Zaretskii <eliz@gnu.org>
1926 * w32term.c (my_bring_window_to_top): New function.
1927 (x_raise_frame): Use handle returned by DeferWindowPos, which
1928 could be different from the original one.
1929 Call my_bring_window_to_top instead of my_set_foreground_window.
1932 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1933 by calling BringWindowToTop.
1935 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1936 (WM_EMACS_END): Increase by one.
1938 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1940 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1941 This avoids undefined behavior that might cause the eassert
1942 to not catch an out-of-range value.
1944 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
1946 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1947 Update dependencies.
1949 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1951 * bidi.c (bidi_mirror_char): Fix last change.
1953 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1955 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1956 when referring to sectname field in printf format.
1958 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1960 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1961 Only r_alloc_inhibit_buffer_relocation needed to be added;
1962 the others were already declared.
1964 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1965 before checking whether it's out of range. Put the check inside
1967 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1969 2012-05-27 Ken Brown <kbrown@cornell.edu>
1971 * callproc.c (Fcall_process): Restore a line that was accidentally
1972 commented out in the 2011-02-13 change (bug#11547).
1974 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1976 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1977 defined on ralloc.c.
1979 * buffer.c [REL_ALLOC]: Remove prototypes of
1980 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1981 they are now on lisp.h.
1983 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1985 * search.c (search_buffer): Use it to inhibit relocation of buffer
1986 text while re_search_2 is doing its job, because re_search_2 is
1987 passed C pointers to buffer text. (Bug#11519)
1989 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1992 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1993 state after an additional call to move_it_in_display_line_to, keep
1994 the values of it->max_ascent and it->max_descent found for the
1996 (pos_visible_p): Revert the comparison against bottom_y to what it
1997 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2000 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2002 Fix coding-related core dumps with gcc -ftrapv.
2003 The code was computing A - B, where A and B are pointers, and B is
2004 random garbage. This can lead to core dumps on platforms that
2005 have special pointer registers, and it also leads to core dumps on
2006 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2007 A - B only when B is initialized properly.
2008 * coding.c (coding_set_source, coding_set_destination): Return void.
2009 (coding_change_source, coding_change_destinations): New functions,
2010 with the old behaviors of coding_set_source and coding_set_destination.
2011 All callers that need an offset changed to use these new functions.
2013 2012-05-26 Glenn Morris <rgm@gnu.org>
2015 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2017 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2019 Extend mouse support on W32 text-mode console.
2020 * xdisp.c (draw_row_with_mouse_face):
2021 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
2023 * w32console.c: Include window.h.
2024 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2026 (initialize_w32_display): Initialize mouse-highlight data.
2028 * w32inevt.c: Include termchar.h and window.h.
2029 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2030 moves, call note_mouse_highlight. If help_echo changed, call
2031 gen_help_event to produce help-echo message in the echo area.
2032 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2035 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2037 * lread.c (read1): Simplify slightly to avoid an overflow warning
2038 with GCC 4.7.0 on x86-64.
2040 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2042 * bidi.c (bidi_mirror_char): Revert last change: an int is
2043 definitely wide enough here.
2045 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
2047 Fix integer width and related bugs (Bug#9874).
2048 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
2049 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2050 (string_bytes, check_sblock, allocate_string_data):
2051 (compact_small_strings, Fmake_bool_vector, make_string)
2052 (make_unibyte_string, make_multibyte_string)
2053 (make_string_from_bytes, make_specified_string)
2054 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2055 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2057 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2058 (allocate_pseudovector):
2059 Use int, not EMACS_INT, where int is wide enough.
2060 (inhibit_garbage_collection, Fgarbage_collect):
2061 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2062 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2063 int might not be wide enough.
2064 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2065 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2066 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2067 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2068 (bidi_level_of_next_char, bidi_move_to_visually_next):
2069 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2070 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2071 (Fkill_buffer, Fset_buffer_major_mode)
2072 (advance_to_char_boundary, Fbuffer_swap_text)
2073 (Fset_buffer_multibyte, overlays_at, overlays_in)
2074 (overlay_touches_p, struct sortvec, record_overlay_string)
2075 (overlay_strings, recenter_overlay_lists)
2076 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2077 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2078 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2079 (Foverlay_recenter, last_overlay_modification_hooks_used)
2080 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2081 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2082 (validate_region): Omit unnecessary test for b <= e,
2083 since that's guaranteed by the previous test.
2084 (adjust_overlays_for_delete): Avoid pos + length overflow.
2085 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2086 (report_overlay_modification):
2087 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2088 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2089 Omit pointer cast, which isn't needed anyway, and doesn't work
2090 after the EMACS_INT -> ptrdiff_t change.
2091 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
2092 * buffer.h: Adjust decls to match defn changes elsewhere.
2093 (struct buffer_text, struct buffer):
2094 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2095 Use EMACS_INT, not int, where int might not be wide enough.
2096 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2097 not int, to avoid needless 32-bit limit on 64-bit hosts.
2098 (exec_byte_code): Use tighter memory-full test, one that checks
2099 for alloca overflow. Don't compute the address of the object just
2100 before an array, as that's not portable. Use EMACS_INT, not
2101 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
2102 * callint.c (Fcall_interactively):
2103 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2104 * callproc.c (call_process_kill, Fcall_process):
2105 Don't assume pid_t fits into an Emacs fixnum.
2106 (call_process_cleanup, Fcall_process, child_setup):
2107 Don't assume pid_t fits into int.
2108 (call_process_cleanup, Fcall_process, delete_temp_file)
2109 (Fcall_process_region):
2110 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2111 (Fcall_process): Simplify handling of volatile integers.
2112 Use int, not EMACS_INT, where int will do.
2113 * casefiddle.c (casify_object, casify_region, operate_on_word)
2114 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2115 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2116 (casify_object): Avoid integer overflow when overallocating buffer.
2117 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
2118 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
2119 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2120 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2121 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2122 integers are now checked earlier. All uses replaced with XINT.
2124 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2125 For CCL_MapSingle, check that content and value are in int range.
2126 (ccl_driver, Fregister_code_conversion_map):
2127 Check that Vcode_version_map_vector is a vector.
2128 (resolve_symbol_ccl_program): Check that vector header is in range.
2129 Always copy the vector, so that we can check its contents reliably
2130 now rather than having to recheck each instruction as it's being
2131 executed. Check that vector words fit in 'int'.
2132 (ccl_get_compiled_code, Fregister_ccl_program)
2133 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2134 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2135 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2136 contents are in range.
2137 (Fccl_execute_on_string): Check that status is in range.
2138 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2139 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2140 Accept and return EMACS_INT, not int, because callers can pass values
2142 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2143 (multibyte_chars_in_text, parse_str_as_multibyte)
2144 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2145 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2146 (string_escape_byte8, Fget_byte):
2147 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2148 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
2149 avoid mishandling large integers.
2150 * character.h: Adjust decls to match defn changes elsewhere.
2151 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2152 (Ffind_charset_region):
2153 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2154 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2155 (load_charset_map_from_vector, Fdefine_charset_internal):
2156 Don't assume fixnum fits in int.
2157 (load_charset_map_from_vector, Fmap_charset_chars):
2158 Remove now-unnecessary CHECK_NATNUMs.
2159 (Fdefine_charset_internal): Check ranges here, more carefully.
2160 Don't rely on undefined behavior with signed left shift overflow.
2161 Don't assume unsigned int fits into fixnum, or that fixnum fits
2162 into unsigned int. Don't require max_code to be a valid fixnum;
2163 that's not true for gb10830 4-byte on a 32-bit host. Allow
2164 invalid_code to be a cons, for the same reason. Require code_offset
2165 to be a character. Avoid int overflow if max_char is close
2167 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2168 this is intended anyway and avoids some undefined behavior.
2169 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2170 INDEX_TO_CODE_POINT, as that's what it expects.
2171 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
2172 * charset.h (DECODE_CHAR): Return int, not unsigned;
2173 this is what was intended anyway, and it avoids undefined behavior.
2174 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2175 integer-overflow issues.
2176 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2177 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2178 where the argument is EMACS_INT, and this behavior is not intended.
2179 * chartab.c (Fmake_char_table, Fset_char_table_range)
2180 (uniprop_get_decoder, uniprop_get_encoder):
2181 Don't assume fixnum fits in int.
2182 * cmds.c (move_point): New function, that does the gist of
2183 Fforward_char and Fbackward_char, but does so while checking
2184 for integer overflow more accurately.
2185 (Fforward_char, Fbackward_char): Use it.
2186 (Fforward_line, Fend_of_line, internal_self_insert)
2187 (internal_self_insert):
2188 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2189 Fix a FIXME, by checking for integer overflow when calculating
2190 target_clm and actual_clm.
2191 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
2192 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
2193 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2194 (coding_alloc_by_making_gap, alloc_destination)
2195 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2196 (encode_coding_utf_16, detect_coding_emacs_mule)
2197 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2198 (detect_coding_iso_2022, decode_coding_iso_2022)
2199 (encode_invocation_designation, encode_designation_at_bol)
2200 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2201 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2202 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2203 (encode_coding_ccl, encode_coding_raw_text)
2204 (detect_coding_charset, decode_coding_charset)
2205 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2206 (produce_composition, produce_charset, produce_annotation)
2207 (decode_coding, handle_composition_annotation)
2208 (handle_charset_annotation, consume_chars, decode_coding_gap)
2209 (decode_coding_object, encode_coding_object, detect_coding_system)
2210 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2211 (code_convert_region, code_convert_string)
2212 (Fdefine_coding_system_internal)
2213 (coding_set_source, coding_set_destination):
2214 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2215 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2216 (Fdefine_coding_system_internal):
2217 Don't assume fixnums fit in int.
2218 (decode_coding_gap, decode_coding_object, encode_coding_object)
2219 (Fread_coding_system, Fdetect_coding_region)
2220 (Funencodable_char_position, Fcheck_coding_systems_region)
2221 (get_translation, handle_composition_annotation, consume_chars):
2222 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2223 (consume_chars): Rewrite to not calculate an address outside buffer.
2224 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
2225 Don't access memory outside of the args array.
2226 (Fdefine_coding_system_internal): Check for charset-id overflow.
2227 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2228 result of ENCODE_CHAR.
2229 * coding.h: Adjust decls to match defn changes elsewhere.
2230 (struct coding_system):
2231 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2232 * composite.c (get_composition_id, find_composition)
2233 (run_composition_function, update_compositions)
2234 (compose_text, composition_gstring_put_cache)
2235 (composition_gstring_p, composition_gstring_width)
2236 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2237 (composition_compute_stop_pos, composition_reseat_it)
2238 (composition_update_it, struct position_record)
2239 (find_automatic_composition, composition_adjust_point)
2240 (Fcomposition_get_gstring, Ffind_composition_internal):
2241 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2242 (update_compositions):
2243 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2244 * composite.h: Adjust decls to match defn changes elsewhere.
2245 (struct composition):
2246 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2247 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2248 Do not attempt to compute the address of the object just before a
2249 buffer; this is not portable.
2251 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2252 (Faset): Use int, not EMACS_INT, where int is wide enough.
2253 (Fstring_to_number): Don't assume fixnums fit in int.
2254 (Frem): Don't assume arg is nonnegative.
2255 * dbusbind.c (xd_append_arg): Check for integers out of range.
2256 (Fdbus_call_method): Don't overflow the timeout int.
2257 (extract_signed, extract_unsigned): New functions.
2258 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2259 (xd_get_connection_references): Return ptrdiff_t, not int.
2261 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2262 (xd_read_message_1):
2263 Use int, not unsigned, where the dbus API uses int.
2264 (Fdbus_message_internal): Don't overflow mtype.
2265 (syms_of_dbusbind): Allocate right-sized buffer for integers.
2266 * dired.c (directory_files_internal, file_name_completion, scmp)
2267 (file_name_completion_stat):
2268 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2269 (file_name_completion): Don't overflow matchcount.
2270 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2271 * dispextern.h: Adjust decls to match defn changes elsewhere.
2272 (struct text_pos, struct glyph, struct bidi_saved_info)
2273 (struct bidi_string_data, struct bidi_it, struct composition_it)
2275 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2276 (struct display_pos, struct composition_it, struct it):
2277 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2278 * dispnew.c (increment_matrix_positions)
2279 (increment_row_positions, mode_line_string)
2280 (marginal_area_string):
2281 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2282 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
2283 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2284 (duration_to_sec_usec): New function, to check for overflow better.
2285 (Fsleep_for, sit_for): Use it.
2286 * doc.c (get_doc_string, store_function_docstring):
2287 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2288 (get_doc_string, Fsnarf_documentation):
2289 Use int, not EMACS_INT, where int is wide enough.
2291 Use SAFE_ALLOCA, not alloca.
2292 Check for overflow when converting EMACS_INT to off_t.
2293 * doprnt.c (doprnt):
2294 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2295 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2296 Don't assume uid_t fits into fixnum.
2297 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2298 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2299 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2300 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2301 (general_insert_function)
2302 (Finsert_char, make_buffer_string, make_buffer_string_both)
2303 (update_buffer_properties, Fbuffer_substring)
2304 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2305 (Fsubst_char_in_region, check_translation)
2306 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2307 (transpose_markers, Ftranspose_regions):
2308 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2309 (clip_to_bounds): Move to lisp.h as an inline function).
2310 (Fconstrain_to_field): Don't assume integers are nonnegative.
2311 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2312 (Fsubst_char_in_region, Fsave_restriction):
2313 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2314 (Femacs_pid): Don't assume pid_t fits into fixnum.
2315 (lo_time): Use int, not EMACS_INT, when int suffices.
2316 (lisp_time_argument): Check for usec out of range.
2317 (Fencode_time): Don't assume fixnum fits in int.
2318 (Fuser_login_name, Fuser_full_name): Signal an error
2319 if a uid argument is out of range, rather than relying on
2321 (Fformat_time_string): Remove now-unnecessary check.
2322 lisp_time_argument checks for out-of-range usec now.
2323 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
2324 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2325 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2326 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2327 (init_cmdargs, Fdump_emacs):
2328 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2329 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2330 the bottom (typically) 32 bits of the fixnum.
2331 * eval.c (specpdl_size, call_debugger):
2332 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2333 (when_entered_debugger, Fbacktrace_debug):
2334 Don't assume fixnum can fit in int.
2335 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2336 the object just before a buffer; this is not portable.
2337 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2338 (grow_specpdl, unbind_to):
2339 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2340 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2341 (grow_specpdl): Simplify allocation by using xpalloc.
2342 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
2343 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2344 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2345 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2346 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2348 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2349 (Fcopy_file, non_regular_nbytes, read_non_regular)
2350 (Finsert_file_contents):
2351 Use int, not EMACS_INT, where int is wide enough.
2352 (READ_BUF_SIZE): Verify that it fits in int.
2353 (Finsert_file_contents): Check that counts are in proper range,
2354 rather than assuming fixnums fit into ptrdiff_t etc.
2355 Don't assume fixnums fit into int.
2356 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
2357 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2358 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
2359 (string_char_to_byte, string_byte_to_char)
2360 (string_make_multibyte, string_to_multibyte)
2361 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2362 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2363 (substring_both, Fdelete, internal_equal, Ffillarray)
2364 (Fclear_string, mapcar1)
2365 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2366 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2367 (larger_vector, make_hash_table, maybe_resize_hash_table)
2368 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2369 (Fmaphash, secure_hash):
2370 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2371 (concat): Check for string index and length overflow.
2372 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2374 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2375 (larger_vector): New API (vec, incr_min, size_max) replaces old
2376 one (vec, new_size, init). This catches size overflow.
2377 INIT was removed because it was always Qnil.
2378 All callers changed.
2379 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2380 the upper bound on a hash table index size.
2381 (make_hash_table, maybe_resize_hash_table): Use it.
2382 (secure_hash): Computer start_byte and end_byte only after
2383 they're known to be in ptrdiff_t range.
2384 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2385 (Ffont_get_glyphs, Ffont_at):
2386 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2387 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2388 (Flist_fonts, Fopen_font):
2389 Don't assume fixnum can fit in int.
2390 (check_gstring): Don't assume index can fit in int.
2391 (font_match_p): Check that fixnum is a character, not a nonnegative
2392 fixnum, since the later code needs to stuff it into an int.
2393 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2394 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2395 conversion overflow issues.
2396 (Fopen_font): Check for integer out of range.
2397 (Ffont_get_glyphs): Don't assume index can fit in int.
2398 * font.h: Adjust decls to match defn changes elsewhere.
2399 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2401 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2402 printmax_t, where ptrdiff_t is wide enough.
2403 (Finternal_char_font):
2404 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2405 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2406 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2407 (Fset_frame_position, x_set_frame_parameters)
2408 (x_set_line_spacing, x_set_border_width)
2409 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2410 Check that fixnums are in proper range for system types.
2411 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2412 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2413 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2414 Use SAFE_ALLOCA_LISP, not alloca.
2415 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2416 intptr_t is wide enough.
2417 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2418 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2419 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2420 Check for fixnum out of range.
2421 * ftfont.c (ftfont_list): Don't assume index fits in int.
2422 Check that fixnums are in proper range for system types.
2423 (ftfont_shape_by_flt):
2424 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2425 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2426 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2427 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2428 Check that fixnums are in proper range for system types.
2429 * gnutls.h: Adjust decls to match defn changes elsewhere.
2430 * gtkutil.c (xg_dialog_run):
2431 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2432 (update_frame_tool_bar):
2433 Check that fixnums are in proper range for system types.
2434 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
2435 (lookup_image): Check that fixnums are in range for system types.
2436 * indent.c (last_known_column, last_known_column_point):
2437 (current_column_bol_cache):
2438 (skip_invisible, current_column, check_display_width):
2439 (check_display_width, scan_for_column, current_column_1)
2440 (Findent_to, Fcurrent_indentation, position_indentation)
2441 (indented_beyond_p, Fmove_to_column, compute_motion):
2442 (Fcompute_motion, Fvertical_motion):
2443 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2444 (last_known_column_modified): Use EMACS_INT, not int.
2445 (check_display_width):
2447 Check that fixnums and floats are in proper range for system types.
2448 (compute_motion): Don't assume index or fixnum fits in int.
2449 (compute_motion, Fcompute_motion):
2450 Use int, not EMACS_INT, when it is wide enough.
2451 (vmotion): Omit local var start_hpos that is always 0; that way
2452 we don't need to worry about overflow in expressions involving it.
2453 * indent.h: Adjust decls to match defn changes elsewhere.
2455 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2456 Use int, not EMACS_INT, where int is wide enough.
2457 Remove unused members ovstring_chars_done and tab_offset;
2459 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2460 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2461 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2462 (make_gap, copy_text, insert, insert_and_inherit)
2463 (insert_before_markers, insert_before_markers_and_inherit)
2464 (insert_1, count_combining_before, count_combining_after)
2465 (insert_1_both, insert_from_string)
2466 (insert_from_string_before_markers, insert_from_string_1)
2467 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2468 (adjust_after_replace, adjust_after_insert, replace_range)
2469 (replace_range_2, del_range, del_range_1, del_range_byte)
2470 (del_range_both, del_range_2, modify_region)
2471 (prepare_to_modify_buffer, signal_before_change)
2472 (signal_after_change, Fcombine_after_change_execute):
2473 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2474 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2475 (balance_an_interval, split_interval_right, split_interval_left)
2476 (find_interval, next_interval, update_interval)
2477 (adjust_intervals_for_insertion, delete_node, delete_interval)
2478 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2479 (static_offset_intervals, offset_intervals)
2480 (merge_interval_right, merge_interval_left, make_new_interval)
2481 (graft_intervals_into_buffer, temp_set_point_both)
2482 (temp_set_point, set_point, adjust_for_invis_intang)
2483 (set_point_both, move_if_not_intangible, get_property_and_range)
2484 (get_local_map, copy_intervals, copy_intervals_to_string)
2485 (compare_string_intervals, set_intervals_multibyte_1):
2486 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2487 * intervals.h: Adjust decls to match defn changes elsewhere.
2489 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2490 * keyboard.c (this_command_key_count, this_single_command_key_start)
2491 (before_command_key_count, before_command_echo_length, echo_now)
2492 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2493 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2494 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2495 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2496 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2497 (last_non_minibuf_size, last_point_position, echo_truncate)
2498 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2499 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2500 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2501 (stuff_buffered_input):
2502 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2503 (last_auto_save, command_loop_1, read_char):
2504 Use EMACS_INT, not int, to avoid integer overflow.
2505 (record_char): Avoid overflow in total_keys computation.
2506 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2507 * keyboard.h: Adjust decls to match defn changes elsewhere.
2508 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2509 (Fkey_description, Fdescribe_vector, Flookup_key):
2510 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2511 (click_position): New function, to check that positions are in range.
2512 (Fcurrent_active_maps):
2514 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2515 (Faccessible_keymaps, Fkey_description):
2516 (preferred_sequence_p):
2517 Don't assume fixnum can fit into int.
2518 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2519 Check for integer overflow in size calculations.
2520 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2521 avoid mishandling large integers.
2522 * lisp.h: Adjust decls to match defn changes elsewhere.
2523 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2524 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2525 (struct Lisp_Marker):
2526 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2527 (clip_to_bounds): Now an inline function, moved here from editfns.c.
2528 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2529 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2530 All callers changed.
2531 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2532 Assume the arg has valid form, since it always does.
2533 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2534 unsigned integer system type.
2535 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2536 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2537 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2538 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2539 (duration_to_sec_usec): New decl.
2540 * lread.c (read_from_string_index, read_from_string_index_byte)
2541 (read_from_string_limit, readchar, unreadchar, openp)
2542 (read_internal_start, read1, oblookup):
2543 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2544 (Fload, readevalloop, Feval_buffer, Feval_region):
2545 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2546 (openp): Check for out-of-range argument to 'access'.
2547 (read1): Use int, not EMACS_INT, where int is wide enough.
2548 Don't assume fixnum fits into int.
2549 Fix off-by-one error that can read outside a buffer.
2550 (read_filtered_event): Use duration_to_sec_usec
2551 to do proper overflow checking on durations.
2552 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2553 in size calculation.
2554 (Fexecute_kbd_macro):
2555 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2556 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2557 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2558 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2559 (set_marker_both, set_marker_restricted_both, marker_position)
2560 (marker_byte_position, Fbuffer_has_markers_at):
2561 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2562 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
2563 * menu.c (ensure_menu_items): Rename from grow_menu_items.
2564 It now merely ensures that the menu is large enough, without
2565 necessarily growing it, as this avoids some integer overflow issues.
2566 All callers changed.
2567 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2568 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2569 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2570 Use SAFE_ALLOCA_LISP, not alloca.
2571 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2572 to EMACS_INT. Check that fixnums are in proper range for system types.
2573 * minibuf.c (minibuf_prompt_width, string_to_object)
2574 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2575 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2576 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2577 (get_minibuffer, read_minibuf_unwind):
2578 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2579 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2580 this simplifies overflow checking. All callers changed.
2581 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2583 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2584 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2585 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2586 Check that fixnums are in proper range for system types.
2587 (Fx_create_frame, Fx_show_tip):
2588 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2589 * nsfont.m (ns_findfonts, nsfont_list_family):
2590 Don't assume fixnum fits in long.
2591 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2592 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2593 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2595 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
2596 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2597 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2598 (PRINTDECLARE, PRINTPREPARE):
2599 (strout, print_string):
2600 (print, print_preprocess, print_check_string_charset_prop)
2602 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2604 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2605 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2606 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
2607 (printchar, strout): Use xpalloc to catch size calculation overflow.
2608 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
2609 (print_error_message): Use SAFE_ALLOCA, not alloca.
2610 (print_object): Use int, not EMACS_INT, where int is wide enough.
2611 (print_depth, new_backquote_output, print_number_index):
2612 Use ptrdiff_t, not int, where int might not be wide enough.
2613 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2614 (Fset_process_window_size, Fformat_network_address)
2615 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
2617 Check that fixnums are in proper range for system types.
2618 (Fsignal_process): Simplify by avoiding a goto.
2619 Check for process-ids out of pid_t range rather than relying on
2621 (process_tick, update_tick): Use EMACS_INT, not int.
2622 (Fformat_network_address, read_process_output, send_process)
2623 (Fprocess_send_region, status_notify):
2624 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2625 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2626 (wait_reading_process_output, read_process_output, exec_sentinel):
2627 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2628 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2629 (Faccept_process_output): Use duration_to_sec_usec to do proper
2630 overflow checking on durations.
2631 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2632 Don't assume pid_t fits in int.
2633 * process.h (struct Lisp_Process): Members tick and update_tick
2634 are now of type EMACS_INT, not int.
2635 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2636 configured --with-wide-int.
2637 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2638 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2639 * search.c (looking_at_1, string_match_1):
2640 (fast_string_match, fast_c_string_match_ignore_case)
2641 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2642 (scan_newline, find_before_next_newline, search_command)
2643 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2644 (set_search_regs, wordify):
2647 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2648 (string_match_1, search_buffer, set_search_regs):
2650 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2651 (wordify): Check for overflow in size calculation.
2652 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2653 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2654 Check that fixnums are in proper range for system types.
2655 * sound.c (struct sound_device)
2656 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2657 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2658 (Fplay_sound_internal):
2659 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2660 * syntax.c (struct lisp_parse_state, find_start_modiff)
2661 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2662 (Fparse_partial_sexp):
2663 Don't assume fixnums can fit in int.
2664 (struct lisp_parse_state, find_start_pos, find_start_value)
2665 (find_start_value_byte, find_start_begv)
2666 (update_syntax_table, char_quoted, dec_bytepos)
2667 (find_defun_start, prev_char_comend_first, back_comment):
2668 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2669 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2670 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2671 (Finternal_describe_syntax_value): Check that match_lisp is a
2672 character, not an integer, since the code stuffs it into int.
2673 (scan_words, scan_sexps_forward):
2674 Check that fixnums are in proper range for system types.
2676 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2677 (scan_sexps_forward):
2678 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2679 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2680 * syntax.h: Adjust decls to match defn changes elsewhere.
2681 (struct gl_state_s):
2682 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2683 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2684 MOST_POSITIVE_FIXNUM.
2685 * sysdep.c (wait_for_termination_1, wait_for_termination)
2686 (interruptible_wait_for_termination, mkdir):
2687 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2688 (emacs_read, emacs_write):
2689 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2690 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2691 and double all fit in int.
2692 * term.c (set_tty_color_mode):
2693 Check that fixnums are in proper range for system types.
2694 * termhooks.h (struct input_event):
2695 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2696 * textprop.c (validate_interval_range, interval_of)
2697 (Fadd_text_properties, set_text_properties_1)
2698 (Fremove_text_properties, Fremove_list_of_text_properties)
2699 (Ftext_property_any, Ftext_property_not_all)
2700 (copy_text_properties, text_property_list, extend_property_ranges)
2701 (verify_interval_modification):
2702 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2703 (Fnext_single_char_property_change)
2704 (Fprevious_single_char_property_change):
2705 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2706 (copy_text_properties):
2707 Check for integer overflow in index calculation.
2708 * undo.c (last_boundary_position, record_point, record_insert)
2709 (record_delete, record_marker_adjustment, record_change)
2710 (record_property_change):
2711 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2712 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2713 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2714 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2715 (Fx_hide_tip, Fx_file_dialog):
2716 * w32menu.c (set_frame_menubar):
2717 Use ptrdiff_t, not int, for consistency with rest of code.
2718 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2719 (select_window, Fdelete_other_windows_internal)
2720 (window_scroll_pixel_based, window_scroll_line_based)
2721 (Frecenter, Fset_window_configuration):
2722 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2723 (Fset_window_hscroll, run_window_configuration_change_hook)
2724 (set_window_buffer, temp_output_buffer_show, scroll_command)
2725 (Fscroll_other_window, Frecenter):
2726 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2727 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2728 Don't assume fixnum fits in int.
2729 (Fset_window_scroll_bars):
2730 Check that fixnums are in proper range for system types.
2731 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2732 (string_pos, c_string_pos, number_of_chars, init_iterator)
2733 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2734 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2735 (compute_display_string_end, handle_face_prop)
2736 (face_before_or_after_it_pos, handle_invisible_prop)
2737 (handle_display_prop, handle_display_spec, handle_single_display_spec)
2738 (display_prop_intangible_p, string_buffer_position_lim)
2739 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2740 (get_overlay_strings_1, get_overlay_strings)
2741 (iterate_out_of_display_property, forward_to_next_line_start)
2742 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2743 (get_next_display_element, set_iterator_to_next)
2744 (get_visually_first_element, compute_stop_pos_backwards)
2745 (handle_stop_backwards, next_element_from_buffer)
2746 (move_it_in_display_line_to, move_it_in_display_line)
2747 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2748 (add_to_log, message_dolog, message_log_check_duplicate)
2749 (message2, message2_nolog, message3, message3_nolog
2750 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2751 (current_message_1, truncate_echo_area, truncate_message_1)
2752 (set_message, set_message_1, store_mode_line_noprop)
2753 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2754 (text_outside_line_unchanged_p, check_point_in_composition)
2755 (reconsider_clip_changes)
2756 (redisplay_internal, set_cursor_from_row, try_scrolling)
2757 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2758 (redisplay_window, find_last_unchanged_at_beg_row)
2759 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2760 (trailing_whitespace_p, find_row_edges, display_line)
2761 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2762 (display_mode_element, store_mode_line_string)
2763 (pint2str, pint2hrstr, decode_mode_spec)
2764 (display_count_lines, display_string, draw_glyphs)
2765 (x_produce_glyphs, x_insert_glyphs)
2766 (rows_from_pos_range, mouse_face_from_buffer_pos)
2767 (fast_find_string_pos, mouse_face_from_string_pos)
2768 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2769 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2770 (safe_call, init_from_display_pos, handle_fontified_prop)
2771 (handle_single_display_spec, load_overlay_strings)
2772 (with_echo_area_buffer, setup_echo_area_for_printing)
2773 (display_echo_area, echo_area_display)
2774 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2775 (update_tool_bar, hscroll_window_tree, redisplay_internal)
2776 (redisplay_window, dump_glyph_row, display_mode_line)
2777 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
2778 (handle_display_spec, display_prop_string_p):
2779 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2780 (handle_single_display_spec, build_desired_tool_bar_string)
2781 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2782 (get_specified_cursor_type):
2783 Check that fixnums are in proper range for system types.
2784 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2785 (Flookup_image_map):
2786 Don't assume fixnums fit in int.
2787 (compare_overlay_entries):
2788 Avoid mishandling comparisons due to subtraction overflow.
2789 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2790 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2791 (handle_tool_bar_click):
2792 Use int, not unsigned, since we prefer signed and the signedness
2793 doesn't matter here.
2794 (get_next_display_element, next_element_from_display_vector):
2795 Use int, not EMACS_INT, when int is wide enough.
2796 (start_hourglass): Use duration_to_sec_usec to do proper
2797 overflow checking on durations.
2798 * xfaces.c (Fbitmap_spec_p):
2799 Check that fixnums are in proper range for system types.
2800 (compare_fonts_by_sort_order):
2801 Avoid mishandling comparisons due to subtraction overflow.
2802 (Fx_family_fonts, realize_basic_faces):
2803 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2805 Don't assume fixnum fits in int.
2806 Use SAFE_ALLOCA_LISP, not alloca.
2807 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2808 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2809 (face_at_buffer_position, face_for_overlay_string)
2810 (face_at_string_position):
2811 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2812 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2813 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2815 Check that fixnums are in proper range for system types.
2816 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2817 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2818 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2819 (Fx_change_window_property): Don't assume fixnums fit in int.
2820 * xfont.c (xfont_chars_supported):
2821 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2822 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2823 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2824 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2825 * xml.c (parse_region):
2826 * xrdb.c (magic_file_p):
2827 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2828 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2829 (x_get_local_selection, x_reply_selection_request)
2830 (x_handle_selection_request, wait_for_property_change):
2831 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2832 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2833 short is wide enough.
2834 (x_send_client_event): Don't assume fixnum fits in int.
2835 * xterm.c (x_x_to_emacs_modifiers):
2836 Don't assume EMACS_INT overflows nicely into int.
2837 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2839 (handle_one_xevent): NATNUMP can eval its arg twice.
2840 (x_connection_closed):
2841 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2842 * xterm.h: Adjust decls to match defn changes elsewhere.
2843 (struct scroll_bar): Use struct vectorlike_header
2844 rather than rolling our own approximation.
2845 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2847 2012-05-25 Glenn Morris <rgm@gnu.org>
2849 * lisp.mk (lisp): Update for more files being compiled now.
2851 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2853 * lread.c: Remove `read_pure' which makes no difference.
2854 (read_pure): Remove var.
2855 (unreadpure): Remove function.
2856 (readevalloop): Don't call read_list with -1 flag.
2857 (read1, read_vector): Don't test read_pure any more.
2858 (read_list): Simplify.
2860 * fileio.c, character.h: Minor style tweaks.
2862 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2864 * window.h (clip_changed): Remove useless declaration.
2866 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
2868 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2869 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2871 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2874 This directory predates autoconf and is no longer needed nowadays.
2875 Move its few remaining bits of functionality to where they're needed.
2876 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2877 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2878 * m/template.h: Remove.
2879 * Makefile.in (M_FILE): Remove. All uses removed.
2880 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2881 * lisp.h (USE_LSB_TAG):
2882 * mem-limits.h (EXCEEDS_LISP_PTR):
2883 Use VAL_MAX, not VALBITS, in #if.
2884 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2885 (EMACS_UINT): Define unconditionally now.
2886 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2887 (BITS_PER_EMACS_INT): New constants, replacing
2888 what used to be in config.h, but not useful in #if.
2889 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2890 define them any more.
2891 (VAL_MAX): New macro.
2893 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2894 BITS_PER_EMACS_INT, in #if.
2895 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2896 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2897 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2898 * s/ms-w32.h (DATA_START):
2899 Move here from removed file m/intel386.h.
2900 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2901 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2903 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2905 Assume C89 or later.
2906 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2907 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2909 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2910 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2911 * textprop.c, tparam.c (NULL): Remove.
2912 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2913 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2914 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2915 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2916 * xterm.c (input_signal_count): Assume volatile works.
2918 2012-05-21 Ken Brown <kbrown@cornell.edu>
2920 * xgselect.c (xg_select): Fix first argument in call to 'select'
2923 2012-05-20 Ken Brown <kbrown@cornell.edu>
2925 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
2926 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
2928 2012-05-19 Ken Brown <kbrown@cornell.edu>
2930 * xfns.c (x_in_use): Remove `static' qualifier.
2931 * xterm.h (x_in_use): Declare.
2932 * xgselect.c: Include xterm.h.
2933 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2934 and `display_arg' (bug#9754).
2936 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2938 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2940 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2941 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2943 2012-05-18 Eli Zaretskii <eliz@gnu.org>
2945 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2947 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2948 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
2950 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2951 reference to image_cache->refcount.
2952 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2954 2012-05-17 Juri Linkov <juri@jurta.org>
2956 * search.c (Fword_search_regexp, Fword_search_backward)
2957 (Fword_search_forward, Fword_search_backward_lax)
2958 (Fword_search_forward_lax): Move functions to isearch.el
2959 (bug#10145, bug#11381).
2961 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2963 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2965 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2967 * lread.c (init_obarray): Declare Qt and Qnil as special.
2969 2012-05-14 Glenn Morris <rgm@gnu.org>
2971 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
2972 Put "libexec" before "bin", for the sake of init_callproc_1.
2974 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2976 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2978 * unexaix.c: Port to more-recent AIX compilers.
2979 (report_error, report_error_1, make_hdr, copy_sym)
2980 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2981 Make arguments const char *, not char *, to avoid violations of C
2982 standard and to fix some AIX warnings reported by Gilles Pion.
2984 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2986 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2987 already have overlays loaded.
2988 (handle_single_display_spec): Before returning without displaying
2989 fringe bitmap, synchronize the bidi iterator with the main display
2990 iterator, by calling iterate_out_of_display_property.
2991 (iterate_out_of_display_property): Detect buffer iteration by
2992 testing that it->string is a Lisp string.
2993 (get_next_display_element): When the current object is exhausted,
2994 and there's something on it->stack, call set_iterator_to_next to
2995 proceed with what's on the stack, instead of returning zero.
2996 (set_iterator_to_next): If called at the end of a Lisp string,
2997 proceed to consider_string_end without incrementing string
2998 position. Don't increment display vector index past the end of
2999 the display vector. (Bug#11417)
3000 (pos_visible_p): Don't report a position visible when move_it_to
3001 stopped at the last line of window, which happens to be scanned
3002 backwards by the bidi iteration. (Bug#11464)
3004 2012-05-14 Eli Zaretskii <eliz@gnu.org>
3006 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3007 and right-margin display specs even if the spec is invalid or we
3008 are on a TTY, and thus unable to display on the fringes.
3009 That's because the text with the property will not be displayed anyway,
3010 so we need to signal to the caller that this is a "replacing"
3011 display spec. This fixes display when the spec is invalid or we
3014 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3016 * unexaix.c (make_hdr): Fix typo in prototype.
3017 This bug broke the build on AIX. Problem reported by Gilles Pion.
3019 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
3021 * keyboard.c (kbd_buffer_get_event): Read special events also in
3022 batch mode. (Bug#11415)
3024 2012-05-12 Glenn Morris <rgm@gnu.org>
3026 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3028 2012-05-12 Eli Zaretskii <eliz@gnu.org>
3030 * lisp.mk (lisp): Add newcomment.elc.
3032 2012-05-12 Glenn Morris <rgm@gnu.org>
3034 * Makefile.in (MKDIR_P): New, set by configure.
3035 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3037 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3039 Remove unused function hourglass_started.
3040 * dispextern.h (hourglass_started):
3041 * w32fns.c (hourglass_started):
3042 * xdisp.c (hourglass_started): Remove.
3044 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
3046 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3047 Update dependencies.
3049 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3051 * xgselect.c (xg_select): Put maxfds+1 into a var.
3052 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3054 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3056 2012-05-10 Dave Abrahams <dave@boostpro.com>
3058 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3059 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3061 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
3063 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3064 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3065 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3066 Initialize xd_registered_buses.
3068 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3070 Untag more efficiently if USE_LSB_TAG.
3071 This is based on a proposal by YAMAMOTO Mitsuharu in
3072 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3073 For an admittedly artificial (nth 8000 longlist) benchmark on
3074 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3075 Emacs's overall text size by 1%.
3076 * lisp.h (XUNTAG): New macro.
3077 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3078 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3079 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3080 * eval.c (Fautoload):
3081 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3082 * frame.h (XFRAME): Use XUNTAG.
3084 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3085 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3086 Remove unportable assumptions about print widths of types like
3088 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3089 intptr_t when converting between pointer and integer, to avoid GCC
3090 warnings about wrong width.
3092 2012-05-09 Eli Zaretskii <eliz@gnu.org>
3094 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3095 stack for each reader_thread, instead of defaulting to 8MB
3096 determined by the linker. This avoids failures in creating
3097 subprocesses on Windows 7, see the discussion in this thread:
3098 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3100 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3102 Fix up display of the *Minibuf-0* buffer in the mini window.
3103 * keyboard.c (read_char): Don't clear the echo area if there's no
3105 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
3106 contents of *Minibuf-0*) if there's no message displayed in its stead.
3108 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
3110 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3113 2012-05-06 Chong Yidong <cyd@gnu.org>
3115 * lisp.mk (lisp): Update.
3117 2012-05-05 Jim Meyering <meyering@redhat.com>
3119 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3121 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3123 * data.c (PUT_ERROR): New macro.
3124 (syms_of_data): Use it. Add new error type `user-error'.
3125 * undo.c (user_error): New function.
3126 (Fprimitive_undo): Use it.
3127 * print.c (print_error_message): Adjust print style for `user-error'.
3128 * keyboard.c (user_error): New function.
3129 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3131 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3133 Do not limit current-time-string to years 1000..9999.
3134 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3135 (Fcurrent_time_string): Support any year that is supported by the
3136 underlying localtime representation. Don't use asctime, as it
3137 has undefined behavior for years outside the range -999..9999.
3139 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3141 Fix race conditions involving setenv, gmtime, localtime, asctime.
3142 Without this fix, interrupts could mess up code that uses these
3143 nonreentrant functions, since setting TZ invalidates existing
3144 tm_zone or tzname values, and since most of these functions return
3145 pointers to static storage.
3146 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3147 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3148 Grow the critical sections to include not just invoking
3149 localtime/gmtime, but also accessing these functions' results
3150 including their tm_zone values if any, and any related TZ setting.
3151 (format_time_string): Last arg is now struct tm *, not struct tm **,
3152 so that the struct tm is saved in the critical section.
3153 All callers changed. Simplify allocation of initial buffer, partly
3154 motivated by the fact that memory allocation needs to be outside
3155 the critical section.
3157 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3159 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3160 with RESET_INTERVAL.
3162 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3163 Remove duplicated buffer name initialization.
3165 2012-05-02 Jim Meyering <jim@meyering.net>
3167 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3169 * xfns.c (x_window): Use xstrdup (Bug#11375).
3171 2012-05-02 Eli Zaretskii <eliz@gnu.org>
3173 * xdisp.c (pos_visible_p): If already at a newline from the
3174 display string before the 'while' loop, don't walk back the glyphs
3175 from it3.glyph_row. Solves assertion violation when the display
3176 string begins with a newline (egg.el). (Bug#11367)
3178 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3180 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3183 2012-05-01 Glenn Morris <rgm@gnu.org>
3185 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3186 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3187 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3188 All were removed before 23.1.
3190 * dispnew.c: Remove HAVE_LIBNCURSES test;
3191 it is always true on relevant platforms.
3193 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3194 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3196 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3198 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3200 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3201 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3204 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3206 Do not avoid creating empty evaporating overlays (Bug#9642).
3207 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3208 That is, do not delete an evaporating overlay if it becomes
3209 empty after its bounds are adjusted to fit within its buffer.
3210 This fix caused other problems, and I'm reverting it until we get
3211 to the bottom of them.
3213 2012-04-27 Chong Yidong <cyd@gnu.org>
3215 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3217 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3219 * xdisp.c (pos_visible_p): If the window start position is beyond
3220 ZV, start the display from buffer beginning. Prevents assertion
3221 violation in init_iterator when the minibuffer window is scrolled
3224 * window.c (window_scroll_pixel_based): Likewise.
3226 2012-04-27 Chong Yidong <cyd@gnu.org>
3228 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3230 2012-04-27 Glenn Morris <rgm@gnu.org>
3232 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3233 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3235 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3237 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3238 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
3240 2012-04-26 Eli Zaretskii <eliz@gnu.org>
3242 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3243 display element, check also the underlying string or buffer
3244 character. (Bug#11341)
3246 * w32menu.c: Include w32heap.h.
3247 (add_menu_item): If the call to AppendMenuW (via
3248 unicode_append_menu) fails, disable Unicode menus only if we are
3249 running on Windows 9X/Me.
3251 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3253 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3254 (xgetint): Add missing shift for LSB tags.
3256 2012-04-24 Martin Rudalics <rudalics@gmx.at>
3258 * keyboard.c (read_char): Don't wipe echo area for select window
3259 events: These might get delayed via `mouse-autoselect-window'
3262 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
3264 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3265 manipulation of :loaded-from data.
3267 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
3269 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3270 now a cons (bug#11311).
3272 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3274 Do not create empty overlays with the evaporate property (Bug#9642).
3275 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3276 if it becomes empty after its bounds are adjusted to fit within
3277 its buffer. Without this fix, in a nonempty buffer (let ((o
3278 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3279 yields an empty overlay that has the evaporate property, which is
3280 not supposed to happen.
3282 Fix minor GTK3 problems found by static checking.
3283 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3284 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3285 (struct _EmacsFixedClass, emacs_fixed_get_type):
3286 Move decls here from emacsgtkfixed.h, since they needn't be public.
3287 (emacs_fixed_get_type): Now static.
3288 (emacs_fixed_class_init): Omit unused local.
3289 (emacs_fixed_child_type): Remove; unused.
3290 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3291 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3292 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3293 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3294 (EMACS_FIXED_GET_CLASS): Remove; unused.
3295 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3297 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3298 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3300 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3302 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
3303 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
3304 (__malloc_size_t, __malloc_ptrdiff_t):
3305 Remove. All uses removed, replaced by the definiens if needed,
3306 since we can assume C89 or better now.
3307 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3308 (protect_malloc_state, align, get_contiguous_space)
3309 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3310 (malloc_atfork_handler_child, malloc_enable_thread)
3311 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3312 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3313 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3314 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3315 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3316 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3317 Define using prototypes, not old style.
3318 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3319 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3320 (align): Don't assume that signed integer overflow wraps around.
3321 Omit unused local var.
3322 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3323 (_free_internal_nolock, memalign, mallochook, reallochook):
3324 Omit no-longer-needed casts.
3325 (valloc): Use getpagesize, not __getpagesize.
3326 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3327 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3329 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3331 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
3333 Move functions from C to Lisp. Make non-blocking method calls
3334 the default. Implement further D-Bus standard interfaces.
3336 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3337 (QCdbus_request_name_allow_replacement)
3338 (QCdbus_request_name_replace_existing)
3339 (QCdbus_request_name_do_not_queue)
3340 (QCdbus_request_name_reply_primary_owner)
3341 (QCdbus_request_name_reply_in_queue)
3342 (QCdbus_request_name_reply_exists)
3343 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3344 (QCdbus_registered_serial, QCdbus_registered_method)
3345 (QCdbus_registered_signal): New Lisp objects.
3346 (XD_DEBUG_MESSAGE): Use sizeof.
3347 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3348 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3349 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3350 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3351 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3352 (xd_signature, xd_append_arg): Allow float for integer types.
3353 (xd_get_connection_references): New function.
3354 (xd_get_connection_address): Rename from xd_initialize.
3355 Return cached address.
3356 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3357 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3359 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
3360 Return number of refcounts.
3361 (Fdbus_get_unique_name): Make stronger parameter check.
3362 (Fdbus_message_internal): New defun.
3363 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3364 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3365 (Fdbus_send_signal, Fdbus_register_service)
3366 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3367 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3368 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3369 (Vdbus_compiled_version, Vdbus_runtime_version)
3370 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3371 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3372 (Vdbus_message_type_signal): New defvars.
3373 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3376 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3378 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3379 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3380 Do not assume ptrdiff_t is the same width as 'int'.
3382 * alloc.c: Handle unusual debugging option combinations.
3383 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3384 since the two debugging options are incompatible.
3385 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3387 (mem_init, mem_insert, mem_insert_fixup):
3388 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3389 (NEED_MEM_INSERT): Remove; no longer needed.
3391 2012-04-22 Leo Liu <sdl.web@gmail.com>
3393 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3395 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3397 * sysdep.c [__FreeBSD__]: Minor cleanups.
3398 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3399 Use Emacs indenting style more consistently. Avoid some casts.
3400 Use 'double' consistently rather than mixing 'float' and 'double'.
3402 2012-04-21 Eduard Wiebe <usenet@pusto.de>
3404 * sysdep.c (list_system_processes, system_process_attributes):
3405 Add implementation for FreeBSD (Bug#5243).
3407 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3409 * lisp.mk (lisp): Update.
3411 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3413 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3414 It is never used otherwise.
3416 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3418 * print.c (print_preprocess): Only check print_depth if print-circle
3420 (print_object): Check for cycles even when print-circle is nil and
3421 print-gensym is t, but only check print_depth if print-circle is nil.
3423 2012-04-20 Chong Yidong <cyd@gnu.org>
3425 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3426 set the status to "failed" and ensure that sentinel is run.
3428 2012-04-20 Glenn Morris <rgm@gnu.org>
3430 * process.c (Fset_process_inherit_coding_system_flag)
3431 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
3432 (Fmake_network_process, Fmake_serial_process): Doc fix.
3434 2012-04-20 Eli Zaretskii <eliz@gnu.org>
3436 * xdisp.c (string_buffer_position_lim): Limit starting position to
3438 (set_cursor_from_row): If called for a mode-line or header-line
3439 row, return zero immediately.
3440 (try_cursor_movement): If inside continuation line, don't back up
3441 farther than the first row after the header line, if any.
3442 Don't consider the header-line row as "partially visible", even if
3443 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3445 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3447 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3450 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
3451 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
3453 configure: new option --enable-gcc-warnings (Bug#11207)
3454 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3455 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3456 (ALL_CFLAGS): Use new macros rather than old.
3457 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3458 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3459 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3460 -Wunused-result, -Wunused-variable. This should go away once
3461 the Emacs and Gnulib regex code is merged.
3462 (xmalloc, xrealloc): Now static.
3464 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3466 * dired.c (Fsystem_groups): Remove unused local.
3468 2012-04-17 Glenn Morris <rgm@gnu.org>
3470 * dired.c (Fsystem_users): Doc fix.
3472 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3474 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3475 (syms_of_dired): Add them.
3477 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3479 Fix minor alloc.c problems found by static checking.
3480 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3481 New extern decls, to avoid calling undeclared functions.
3482 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3483 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3484 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3485 (NEED_MEM_INSERT): New macro.
3486 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
3487 Remove one incorrect comment and fix another.
3489 Fix minor ralloc.c problems found by static checking.
3490 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3491 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3492 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3493 (r_alloc_sbrk): Now static.
3495 Improve ralloc.c interface checking.
3496 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3497 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3498 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3499 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3500 [REL_ALLOC]: ... to here, to check interface.
3501 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3502 Remove decls. This fixes an "It stinks!".
3504 * alloc.c (which_symbols): Fix alignment issue / type clash.
3506 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3508 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3509 (struct Lisp_Misc_Any): Likewise.
3510 (struct Lisp_Free): Likewise.
3511 * alloc.c (union aligned_Lisp_Symbol): Define.
3512 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3513 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3514 (union aligned_Lisp_Misc): Define.
3515 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3516 aligned_Lisp_Misc instead of union Lisp_Misc.
3517 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
3519 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3521 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3522 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3523 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3524 * s/netbsd.h, s/sol2-6.h:
3525 Remove definition of GC_MARK_STACK, since the default now works.
3526 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3527 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3528 no longer the default.
3529 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3531 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3533 * lread.c (lisp_file_lexically_bound_p):
3534 Fix hang at ";-*-\n" (bug#11238).
3536 2012-04-14 Eli Zaretskii <eliz@gnu.org>
3538 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3539 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3541 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3543 * nsterm.m (constrainFrameRect): Always constrain when there is only
3544 one screen (Bug#10962).
3546 2012-04-13 Ken Brown <kbrown@cornell.edu>
3548 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3550 2012-04-13 Reuben Thomas <rrt@sc3d.org>
3552 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3554 2012-04-11 Daniel Colascione <dancol@dancol.org>
3556 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3557 against is gone. It's better to use vfork now so that when Cygwin
3558 gains a new, working vfork, we use it automatically (bug#10398).
3560 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3562 * window.c (save_window_save): Obey window-point-insertion-type.
3564 2012-04-11 Glenn Morris <rgm@gnu.org>
3566 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3568 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3570 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3572 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
3574 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3575 (force_quit_count): New var.
3576 (handle_interrupt): Use it.
3578 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
3580 * w32.c (w32_delayed_load): Record the full path of the library
3581 being loaded (bug#10424).
3583 2012-04-09 Glenn Morris <rgm@gnu.org>
3585 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3586 not just in the obarray, before snarfing them. (Bug#11036)
3588 * Makefile.in ($(leimdir)/leim-list.el):
3589 Pass EMACS rather than BUILT_EMACS.
3591 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3593 * process.c (make_process):
3594 * process.h: Add integer `gnutls_handshakes_tried' member to
3597 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3598 Add convenience `GNUTLS_LOG2i' macro.
3600 * gnutls.c (gnutls_log_function2i): Convenience log function.
3601 (emacs_gnutls_read): Use new log functions,
3602 `gnutls_handshakes_tried' process member, and
3603 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3604 attempts per process (connection).
3606 2012-04-09 Chong Yidong <cyd@gnu.org>
3608 * eval.c (Fuser_variable_p, user_variable_p_eh)
3609 (lisp_indirect_variable): Functions deleted.
3610 (Fdefvar): Caller changed.
3612 * callint.c (Finteractive, Fcall_interactively):
3613 * minibuf.c (Fread_variable): Callers changed.
3615 2012-04-09 Eli Zaretskii <eliz@gnu.org>
3617 * xdisp.c (set_cursor_from_row): If the display string appears in
3618 the buffer at position that is closer to point than the position
3619 after the display string, display the cursor on the first glyph of
3620 the display string. Fixes cursor display when a 'display' text
3621 property immediately follows invisible text. (Bug#11094)
3623 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3625 composite.c: use 'double' consistently
3626 * composite.c (get_composition_id): Use 'double' consistently
3627 instead of converting 'float' to 'double' and vice versa; this is
3628 easier to understand and avoids a GCC warning.
3630 2012-04-09 Glenn Morris <rgm@gnu.org>
3632 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3633 preparation for dumping it with emacs. (Bug#4789)
3634 (leimdir): New variable.
3635 ($(leimdir)/leim-list.el): New rule.
3636 (emacs$(EXEEXT)): Depend on leim-list.el.
3638 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3639 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3640 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3642 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3644 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3647 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
3649 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3650 Remove unused local variable.
3652 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3654 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3655 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3656 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3657 objects, as mark_maybe_pointer will catch them otherwise.
3658 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3659 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3661 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3663 Fix typo that broke non-Windows builds.
3664 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3666 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3668 Support building on MS-Windows with libxml2.
3670 * makefile.w32-in (OBJ2): Add xml.$(O).
3671 (GLOBAL_SOURCES): Add xml.c.
3672 ($(BLD)/xml.$(O)): New dependency list.
3674 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3675 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3676 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3677 [!WINDOWSNT]: New macros.
3678 (init_libxml2_functions, libxml2_loaded_p): New functions.
3679 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3680 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3681 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3682 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3684 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3685 Call init_libxml2_functions before calling libxml2 functions.
3686 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3688 * emacs.c: Don't include libxml/parser.h.
3689 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3690 xmlCleanupParser directly.
3692 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3694 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3696 * indent.c (Fvertical_motion): If there is a display string at
3697 point, use it.vpos to compute how many lines to backtrack after
3698 move_it_to point. (Bug#11133)
3700 2012-04-06 Eli Zaretskii <eliz@gnu.org>
3702 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3703 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3704 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3705 macros related to unification of CJK characters. For the details,
3706 see the discussion following the message here:
3707 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3709 2012-04-04 Chong Yidong <cyd@gnu.org>
3711 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3713 2012-04-01 Eli Zaretskii <eliz@gnu.org>
3715 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3716 instead of alloca. (Bug#11138)
3718 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3720 * w32menu.c (is_simple_dialog): Properly check lisp types.
3723 2012-03-31 Eli Zaretskii <eliz@gnu.org>
3725 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3726 position we get to after a call to move_it_to fails the
3727 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3728 only if we wind up in a string from display property. (Bug#11063)
3730 * window.c (Fdelete_other_windows_internal): Invalidate the row
3731 and column information about mouse highlight, so that redisplay
3732 restores it after reallocating the glyph matrices. (Bug#7464)
3734 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3735 string comes from a `display' text property, use the buffer
3736 position of that property as if we actually saw that position in
3738 (move_it_by_lines): Remove the assertion that
3739 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3740 violated when there's a before-string at the beginning of a line.
3743 2012-03-30 Eli Zaretskii <eliz@gnu.org>
3745 * xdisp.c (append_space_for_newline): If the default face was
3746 remapped, use the remapped face for the appended newline.
3747 (extend_face_to_end_of_line): Use the remapped default face for
3748 extending the face to the end of the line.
3749 (display_line): Call extend_face_to_end_of_line when the default
3750 face was remapped. (Bug#11068)
3752 2012-03-29 Eli Zaretskii <eliz@gnu.org>
3754 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3756 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3758 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3760 2012-03-27 Glenn Morris <rgm@gnu.org>
3762 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3765 2012-03-26 Kenichi Handa <handa@m17n.org>
3767 * dispextern.h (struct glyph): Fix previous change. Change the
3768 bit length of glyphless.ch to 25 (Bug#11082).
3770 2012-03-26 Chong Yidong <cyd@gnu.org>
3772 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3773 (command_loop_1): Use it; inhibit selection update for
3774 handle-select-window too (Bug#8996).
3776 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3778 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
3780 2012-03-25 Kenichi Handa <handa@m17n.org>
3782 * dispextern.h (struct glyph): Change the bit length of
3783 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3785 2012-03-24 Eli Zaretskii <eliz@gnu.org>
3787 * s/ms-w32.h (tzname): Include time.h before redirecting to
3788 _tzname. Fixes the MSVC build. (Bug#9960)
3790 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3792 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3795 * xterm.c (XTread_socket): Only modify handling_signal if
3796 !SYNC_INPUT. (Bug#11080)
3798 2012-03-23 Eli Zaretskii <eliz@gnu.org>
3800 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3801 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3802 when fetching a multibyte character consumes more bytes than
3803 CHAR_BYTES returns, due to unification of CJK characters in
3804 string_char. (Bug#11073)
3806 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3808 * process.c (wait_reading_process_output): Handle pty disconnect
3809 by refraining from sending oneself a SIGCHLD (bug#10933).
3811 2012-03-22 Chong Yidong <cyd@gnu.org>
3813 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3815 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
3816 Mark string as coming from a prefix property.
3817 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3818 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3820 2012-03-21 Chong Yidong <cyd@gnu.org>
3822 * xfaces.c (Vface_remapping_alist): Doc fix.
3824 2012-03-20 Eli Zaretskii <eliz@gnu.org>
3826 * w32proc.c (Fw32_set_console_codepage)
3827 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3830 2012-03-20 Chong Yidong <cyd@gnu.org>
3832 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3833 to reflect default non-nil value of redisplay-dont-pause.
3835 2012-03-19 Kenichi Handa <handa@m17n.org>
3837 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3838 it fit in a valid range (Bug#11003).
3840 2012-03-18 Eli Zaretskii <eliz@gnu.org>
3842 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3843 that is not from display property, accept the row as a "cursor
3844 row" if one of the string's character has a non-nil `cursor'
3845 property. Fixes cursor positioning when there are newlines in
3846 overlay strings, e.g. in icomplete.el. (Bug#11035)
3848 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3850 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3852 2012-03-12 Chong Yidong <cyd@gnu.org>
3854 * eval.c (inhibit_lisp_code): Rename from
3855 inhibit_window_configuration_change_hook; move from window.c.
3857 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3858 * window.c (run_window_configuration_change_hook)
3859 (syms_of_window): Callers changed.
3861 2012-03-11 Chong Yidong <cyd@gnu.org>
3863 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3865 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3867 2012-03-10 Chong Yidong <cyd@gnu.org>
3869 * frame.c (other_visible_frames): Don't assume the selected frame
3870 is visible (Bug#10955).
3872 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3874 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3876 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3878 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3879 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3882 2012-03-03 Glenn Morris <rgm@gnu.org>
3884 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
3886 2012-03-02 Eli Zaretskii <eliz@gnu.org>
3888 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3889 position past the first glyph_row that ends at ZV. (Bug#10902)
3890 (redisplay_window, next_element_from_string): Fix typos in
3892 (redisplay_window): Pass to move_it_vertically the margin in
3893 pixels, not in screen lines.
3895 2012-03-02 Glenn Morris <rgm@gnu.org>
3897 * buffer.c (buffer-list-update-hook): Doc fix.
3899 2012-02-29 Eli Zaretskii <eliz@gnu.org>
3901 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3902 push_it before setting up the iterator for the first overlay
3903 string, even if we have an empty string loaded.
3904 (next_overlay_string): If there's an empty string on the iterator
3905 stack, pop the stack. (Bug#10903)
3907 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3909 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3910 Suggested by Stefan Monnier in
3911 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3912 * alloc.c (widen_to_Lisp_Object): New static function.
3913 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3914 and widening them to Lisp_Objects. This would work even if
3915 USE_LSB_TAG is defined and wide integers are used, which might
3916 happen in a future version of Emacs.
3918 2012-02-25 Chong Yidong <cyd@gnu.org>
3920 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3923 * xselect.c (Fx_selection_exists_p): Doc fix.
3924 (x_clipboard_manager_save_all): Print an informative message
3925 before saving to clipboard manager.
3927 2012-02-24 Chong Yidong <cyd@gnu.org>
3929 * keyboard.c (process_special_events): Handle all X selection
3930 requests in kbd_buffer, not just the next one (Bug#8869).
3932 2012-02-23 Chong Yidong <cyd@gnu.org>
3934 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3935 call when setting menu-bar-lines and tool-bar-lines parameters.
3936 (unwind_create_frame_1): New helper function.
3938 * window.c (inhibit_window_configuration_change_hook): New var.
3939 (run_window_configuration_change_hook): Obey it.
3940 (syms_of_window): Initialize it.
3942 2012-02-22 Chong Yidong <cyd@gnu.org>
3944 * xterm.c (x_draw_image_relief): Add missing type check for
3945 Vtool_bar_button_margin (Bug#10743).
3947 2012-02-21 Chong Yidong <cyd@gnu.org>
3949 * fileio.c (Vfile_name_handler_alist): Doc fix.
3951 * buffer.c (Fget_file_buffer): Protect against invalid file
3952 handler return value.
3954 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3956 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3957 when computing $valmask.
3959 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3960 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3961 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3962 It's useless in that case, and it can cause problems on hosts
3963 that allocate halves of EMACS_INT values separately.
3964 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3965 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3966 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3967 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3968 it avoids undefined behavior on hosts where shifting right by more
3969 than the word width has undefined behavior.
3971 2012-02-19 Chong Yidong <cyd@gnu.org>
3973 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3974 (Funhandled_file_name_directory, Ffile_name_as_directory)
3975 (Fdirectory_file_name, Fexpand_file_name)
3976 (Fsubstitute_in_file_name): Protect against invalid file handler
3977 return values (Bug#10845).
3979 2012-02-18 Eli Zaretskii <eliz@gnu.org>
3981 * .gdbinit (pitx): Fix incorrect references to fields of the
3984 2012-02-17 Chong Yidong <cyd@gnu.org>
3986 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3988 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3990 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3991 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3993 2012-02-15 Chong Yidong <cyd@gnu.org>
3995 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3996 marked as special. Also, starting docstrings with * is obsolete.
3998 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4000 * gnutls.c (emacs_gnutls_write): Fix last change.
4002 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4004 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4007 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4009 * keymap.c (Fsingle_key_description): Handle char ranges.
4011 2012-02-12 Chong Yidong <cyd@gnu.org>
4013 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4014 as that creates a dangerous corner case.
4016 * window.c (Fdelete_window_internal): Invalidate the mouse
4017 highlight (Bug#9904).
4019 2012-02-12 Glenn Morris <rgm@gnu.org>
4021 * xselect.c (Fx_own_selection_internal)
4022 (Fx_get_selection_internal, Fx_disown_selection_internal)
4023 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4024 * nsselect.m (Fx_own_selection_internal)
4025 (Fx_disown_selection_internal, Fx_selection_exists_p)
4026 (Fx_selection_owner_p, Fx_get_selection_internal):
4027 Sync docs and argument specs with the xselect.c versions.
4029 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4031 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4033 2012-02-11 Eli Zaretskii <eliz@gnu.org>
4035 * w32select.c (Fx_selection_exists_p): Sync doc string and
4036 argument list with xselect.c. (Bug#10783)
4038 * w16select.c (Fx_selection_exists_p): Sync doc string and
4039 argument list with xselect.c. (Bug#10783)
4041 2012-02-10 Glenn Morris <rgm@gnu.org>
4043 * fns.c (Fsecure_hash): Doc fix.
4045 2012-02-09 Kenichi Handa <handa@m17n.org>
4047 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4049 2012-02-07 Chong Yidong <cyd@gnu.org>
4051 * buffer.c (Fbuffer_local_variables)
4052 (buffer_lisp_local_variables): Handle unbound vars correctly;
4053 don't let Qunbound leak into Lisp.
4055 2012-02-07 Glenn Morris <rgm@gnu.org>
4057 * image.c (Fimagemagick_types): Doc fix.
4059 * image.c (imagemagick-render-type): Change it from a lisp object
4060 to an integer. Move the doc here from the lisp manual.
4061 Treat all values not equal to 0 the same.
4063 2012-02-06 Chong Yidong <cyd@gnu.org>
4065 * doc.c (store_function_docstring): Avoid applying docstring of
4066 alias to base function (Bug#2603).
4068 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4070 * .gdbinit (pp1, pv1): Remove redundant defines.
4073 2012-02-04 Chong Yidong <cyd@gnu.org>
4075 * nsterm.m: Declare a global (Bug#10694).
4077 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4079 * w32.c (get_emacs_configuration_options):
4080 Include --enable-checking, if specified, in the return value.
4082 2012-02-04 Martin Rudalics <rudalics@gmx.at>
4084 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4085 after rounding frame sizes. (Bug#9723)
4087 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4089 * keyboard.c (adjust_point_for_property): Don't position point
4090 before BEGV. (Bug#10696)
4092 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4094 Handle overflow when computing char display width (Bug#9496).
4095 * character.c (char_width): Return EMACS_INT, not int.
4096 (char_width, c_string_width): Check for overflow when
4097 computing the width; this is possible now that individual
4098 characters can have unbounded width. Problem introduced
4099 by merge from Emacs 23 on 2012-01-19.
4101 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
4103 * dbusbind.c (Fdbus_register_method): Mention the return value
4104 :ignore in the docstring.
4106 2012-02-02 Glenn Morris <rgm@gnu.org>
4108 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4110 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4111 Unconditionally set to t. (Bug#10673)
4112 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4113 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4114 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4116 2012-02-02 Kenichi Handa <handa@m17n.org>
4118 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4119 0, do not call append_composite_glyph.
4121 2012-02-02 Kenichi Handa <handa@m17n.org>
4123 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4125 (x_produce_glyphs): If the component of a composition is a null
4126 string, set it->pixel_width to 1 to avoid zero-width glyph.
4128 2012-02-01 Eli Zaretskii <eliz@gnu.org>
4130 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4131 first 2 arguments are identical. This makes inserting large
4132 output from a subprocess an order of magnitude faster on
4133 MS-Windows, where all sbrk'ed memory is always contiguous.
4135 2012-01-31 Glenn Morris <rgm@gnu.org>
4137 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4138 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4139 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4141 2012-01-29 Glenn Morris <rgm@gnu.org>
4143 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4145 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4147 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4149 2012-01-28 Chong Yidong <cyd@gnu.org>
4151 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4153 2012-01-26 Chong Yidong <cyd@gnu.org>
4155 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4157 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4158 repeat counts (Bug#10507).
4160 2012-01-26 Glenn Morris <rgm@gnu.org>
4162 * lread.c (syms_of_lread): Doc fix.
4164 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4166 * coding.c (encode_designation_at_bol): Change return value to
4169 2012-01-25 Chong Yidong <cyd@gnu.org>
4171 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4173 2012-01-21 Chong Yidong <cyd@gnu.org>
4175 * floatfns.c (Fcopysign): Make the second argument non-optional,
4176 since nil is not allowed anyway.
4178 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4180 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4181 (send_process): Likewise.
4183 2012-01-19 Martin Rudalics <rudalics@gmx.at>
4185 * window.c (save_window_save, Fcurrent_window_configuration)
4186 (Vwindow_persistent_parameters): Do not use Qstate.
4187 Rewrite doc-strings.
4189 2012-01-19 Kenichi Handa <handa@m17n.org>
4191 * character.c (char_width): New function.
4192 (Fchar_width, c_string_width, lisp_string_width):
4193 Use char_width (Bug#9496).
4195 2012-01-16 Martin Rudalics <rudalics@gmx.at>
4197 * window.c (Vwindow_persistent_parameters): New variable.
4198 (Fset_window_configuration, save_window_save): Handle persistent
4201 2012-01-14 Eli Zaretskii <eliz@gnu.org>
4203 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4204 thrashing the stack of the thread. (Bug#9087)
4206 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4208 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4210 2012-01-11 Eli Zaretskii <eliz@gnu.org>
4212 * xdisp.c (rows_from_pos_range): Handle the case where the
4213 highlight ends on a newline. (Bug#10464)
4214 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4215 he end column for display of highlight that ends on a newline
4218 2012-01-11 Glenn Morris <rgm@gnu.org>
4220 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4221 from load-path also when installation-directory is nil. (Bug#10208)
4223 2012-01-10 Glenn Morris <rgm@gnu.org>
4225 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4227 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4228 Update template values to be closer to their typical values these days.
4230 2012-01-09 Eli Zaretskii <eliz@gnu.org>
4232 * xdisp.c (rows_from_pos_range): Accept additional argument
4233 DISP_STRING, and accept any glyph in a row whose object is that
4234 string as eligible for mouse highlight. Fixes mouse highlight of
4235 display strings from overlays. (Bug#10464)
4237 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
4239 emacs: fix an auto-save permissions race condition (Bug#10400)
4240 * fileio.c (auto_saving_dir_umask): New static var.
4241 (Fmake_directory_internal): Use it.
4242 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4243 creating the directory. The old code temporarily assigns
4244 too-generous permissions to the directory.
4245 (do_auto_save_eh): Clear it.
4246 (Fdo_auto_save): Catch all errors, not just file errors, so
4247 that the var is always cleared.
4249 2012-01-07 Eli Zaretskii <eliz@gnu.org>
4251 * search.c (scan_buffer): Pass character positions to
4252 know_region_cache, not byte positions. (Bug#6540)
4254 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
4256 * w32.c (sys_rename): Report EXDEV when rename of a directory
4257 fails because the target is on another logical disk. (Bug#10284)
4259 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4261 * xterm.c (x_embed_request_focus): New function.
4263 * xterm.h: Add prototype.
4265 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4267 2012-01-05 Glenn Morris <rgm@gnu.org>
4269 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4271 2012-01-01 Eli Zaretskii <eliz@gnu.org>
4273 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4274 Load gnutls_transport_set_lowat only if GnuTLS version is below
4276 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4277 GnuTLS versions below 2.11.1.
4279 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4281 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4282 to the doc string advising against its use for altering the way
4283 windows are scrolled.
4285 2011-12-28 Kenichi Handa <handa@m17n.org>
4287 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4288 coding-system ASCII compatible only when it does not produce BOM
4289 on encoding (Bug#10383).
4291 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4293 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4295 (create_and_show_popup_menu): Always use menu_position_func for
4298 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4300 * callint.c (Fcall_interactively): Don't truncate prompt string.
4302 2011-12-23 Eli Zaretskii <eliz@gnu.org>
4304 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4305 property that ends at ZV, so that the bidi iteration could be
4306 resumed from there (after widening). (Bug#10360)
4308 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4310 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4312 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4314 * nsterm.m (x_free_frame_resources):
4315 Release f->output_data.ns->miniimage.
4316 (ns_index_color): Fix indentation. Do not retain
4317 color_table->colors[i].
4319 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4322 * nsfns.m (x_set_background_color): Assign return value from
4323 ns_index_color to face-background instead of NSColor*.
4324 (ns_implicitly_set_icon_type): Fix indentation.
4325 Change assignment in for loop to comparison.
4327 * emacs.c (ns_pool): New variable.
4328 (main): Assign ns_pool.
4329 (Fkill_emacs): Call ns_release_autorelease_pool.
4331 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4332 autorelease fdesc, release fdAttrs and tdict.
4333 (ns_get_covering_families): Release charset.
4334 (ns_findfonts): Release NSFontDescriptor created with new.
4335 (ns_uni_to_glyphs): Fix indentation.
4336 (setString): Release attrStr before assigning new value.
4338 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4340 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4342 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4343 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4345 2011-12-18 David Reitter <reitter@cmu.edu>
4347 * nsterm.m (ns_term_init): Subscribe for notifications
4348 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4349 to method trackingNotification in EmacsMenu.
4351 * nsmenu.m (trackingMenu): New variable.
4352 (trackingNotification): New method (from Aquamacs).
4353 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
4354 from Aquamacs (Bug#7030).
4356 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4358 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4359 (symbol_to_nsstring): Fix indentation.
4360 (ns_symbol_to_pb): New function.
4361 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4362 (Fns_rotate_cut_buffers_internal): Remove.
4363 (Fns_store_selection_internal): Rename from
4364 Fns_store_cut_buffer_internal.
4365 (ns_get_foreign_selection, Fx_own_selection_internal)
4366 (Fx_disown_selection_internal, Fx_selection_exists_p)
4367 (Fns_get_selection_internal, Fns_store_selection_internal):
4368 Use ns_symbol_to_pb and check if return value is nil.
4369 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4370 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
4371 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4372 renamed to Sns_store_selection_internal.
4373 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4374 and remove this function.
4375 (ns_handle_selection_clear): Remove, never used.
4376 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4379 2011-12-17 Ken Brown <kbrown@cornell.edu>
4381 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4382 GID is unknown (Bug#10257).
4384 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4386 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4387 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4388 which caused a build failure on GNU/Linux IA-64. This problem was
4389 introduced by my 2011-10-07 patch.
4391 2011-12-15 Juri Linkov <juri@jurta.org>
4393 * image.c (imagemagick_error): New function. (Bug#10112)
4394 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4395 Use `imagemagick_error' where ImageMagick functions return
4397 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4400 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4402 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4403 fill background (Bug#8992).
4405 2011-12-13 Martin Rudalics <rudalics@gmx.at>
4407 * window.c (Vwindow_combination_resize)
4408 (Vwindow_combination_limit): Use t instead of non-nil in
4410 (Vrecenter_redisplay): Add first sentence of doc-string on
4412 (Frecenter): Fix doc-string typo.
4414 2011-12-11 Kenichi Handa <handa@m17n.org>
4416 * coding.c (Funencodable_char_position): Pay attention to the
4417 buffer text relocation (Bug#9389).
4419 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4421 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4422 gtk_init (Bug#10100).
4424 2011-12-10 Eli Zaretskii <eliz@gnu.org>
4426 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4427 IT->string is nil. (Bug#10263)
4429 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4431 * nsterm.h (x_free_frame_resources): Declare.
4433 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4434 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4436 * nsterm.h (ns_get_defaults_value): Declare.
4438 * nsterm.m (ns_default): Call ns_get_defaults_value.
4440 2011-12-09 Eli Zaretskii <eliz@gnu.org>
4442 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4445 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4447 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4448 that where the value of an _OBJC_* symbol points to is in the .bss
4449 section (Bug#10240).
4451 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4453 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
4454 after the loop to call ccl_driver at least once (Bug#8619).
4456 2011-12-08 Kenichi Handa <handa@m17n.org>
4458 * ftfont.c (get_adstyle_property): Fix previous change
4461 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
4463 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4464 dirs from the default value of EMACSLOADPATH (bug#10208).
4466 2011-12-07 Glenn Morris <rgm@gnu.org>
4468 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4469 installation and source directories as well. (Bug#10208)
4471 2011-12-06 Chong Yidong <cyd@gnu.org>
4473 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4475 2011-12-06 Glenn Morris <rgm@gnu.org>
4477 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4478 as an error, not just -1. (Bug#10217)
4480 2011-12-05 Chong Yidong <cyd@gnu.org>
4482 * keyboard.c (process_special_events): New function.
4483 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4485 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4487 * coding.c (encode_designation_at_bol): Don't use uninitialized
4488 local variable (Bug#9318).
4490 2011-12-05 Kenichi Handa <handa@m17n.org>
4492 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4493 return Qnil (Bug#8046, Bug#10193).
4495 2011-12-05 Kenichi Handa <handa@m17n.org>
4497 * coding.c (encode_designation_at_bol): New args charbuf_end and
4498 dst. Return the number of produced bytes. Callers changed.
4499 (coding_set_source): Return how many bytes coding->source was
4501 (coding_set_destination): Return how many bytes
4502 coding->destination was relocated.
4503 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
4504 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
4506 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4508 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4509 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4512 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4514 The following changes are to fix Bug#9318.
4516 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
4517 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4518 (encode_coding_iso_2022, encode_coding_sjis)
4519 (encode_coding_big5, encode_coding_charset): Use the above macros.
4521 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
4523 * lisp.h (process_quit_flag): Fix external declaration.
4525 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4527 Don't macro-inline non-performance-critical code.
4528 * eval.c (process_quit_flag): New function.
4529 * lisp.h (QUIT): Use it.
4531 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4533 * nsfns.m (get_geometry_from_preferences): New function.
4534 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4536 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4538 * emacs.c (Qkill_emacs): Define.
4539 (syms_of_emacs): Initialize it.
4540 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4541 Qquit_flag to `kill-emacs' instead.
4542 (quit_throw_to_read_char): Add parameter `from_signal'.
4543 All callers changed. Call Fkill_emacs if requested and safe.
4544 * lisp.h (QUIT): Call Fkill_emacs if requested.
4546 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4548 * widget.c (update_wm_hints): Return if wmshell is null.
4549 (widget_update_wm_size_hints): New function.
4551 * widget.h (widget_update_wm_size_hints): Declare.
4553 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4554 widget_update_wm_size_hints (Bug#10104).
4556 2011-12-03 Eli Zaretskii <eliz@gnu.org>
4558 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4559 before a newline, prepare the bidi iterator for consuming the
4560 newline, and keep the current paragraph direction. (Bug#10183)
4561 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
4563 2011-12-02 Juri Linkov <juri@jurta.org>
4565 * search.c (Fword_search_regexp): New Lisp function created from
4566 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4567 (Fword_search_backward, Fword_search_forward)
4568 (Fword_search_backward_lax, Fword_search_forward_lax):
4569 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4570 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4572 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4574 * fileio.c (Finsert_file_contents): Move after-change-function call
4575 to before the "handled:" label, since all "goto handled" appear in
4576 cases where the *-change-functions have already been properly called
4579 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4581 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4582 waiting for input. (Bug#10169)
4584 2011-11-30 Eli Zaretskii <eliz@gnu.org>
4586 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4587 verifies glyph row's hash code--we have just reallocated the
4588 glyphs, so their contents can be complete garbage. (Bug#10164)
4590 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
4592 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4594 2011-11-30 Eli Zaretskii <eliz@gnu.org>
4596 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4597 attributes are tested _before_ calling verify_row_hash, to protect
4598 against GCC re-ordering of the tests. (Bug#10164)
4600 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4602 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4604 * xterm.c (handle_one_xevent): Only set async_visible and friends
4605 if net_wm_state_hidden_seen is non-zero (Bug#10002)
4606 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
4607 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4609 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4611 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4612 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4613 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4614 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4615 All uses changed to use GCPRO1 etc.
4616 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4617 Revert to old implementation (i.e., before 2011-03-11).
4619 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4621 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4622 of scroll runs so as to avoid assigning disabled bogus rows and
4623 unnecessary graphics copy operations.
4625 2011-11-27 Eli Zaretskii <eliz@gnu.org>
4627 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4628 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4629 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4630 (malloc, free, realloc, calloc): Redirect to e_* only when
4633 * lisp.h (GCTYPEBITS): Move before first use.
4634 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4635 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4636 this macro definition.
4638 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4641 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4643 * gtkutil.c (xg_create_frame_widgets):
4644 Call gtk_window_set_has_resize_grip (FALSE) if that function is
4645 present with Gtk+ 2.0.
4647 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4649 * fileio.c (Finsert_file_contents): Undo previous change; see
4650 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4652 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4654 Rename locals to avoid shadowing.
4655 * fileio.c (Finsert_file_contents):
4656 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4657 * process.c (wait_reading_process_output):
4658 Rename inner 'proc' to 'p' to avoid shadowing.
4659 Indent for consistency with usual Emacs style.
4661 2011-11-25 Eli Zaretskii <eliz@gnu.org>
4663 * xdisp.c (redisplay_window): If cursor row is not fully visible
4664 after recentering, and scroll-conservatively is set to a large
4665 number, scroll window by a few more lines to make the cursor fully
4666 visible and out of scroll-margin. (Bug#10105)
4667 (start_display): Don't move to the next line if the display should
4668 start at a newline that is part of a display vector or an overlay
4671 2011-11-24 Juri Linkov <juri@jurta.org>
4673 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4674 after the `MagickPingImage' call. (Bug#10112)
4676 2011-11-23 Chong Yidong <cyd@gnu.org>
4678 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4680 2011-11-23 Martin Rudalics <rudalics@gmx.at>
4682 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4683 making another buffer current. (Bug#10114)
4685 2011-11-23 Glenn Morris <rgm@gnu.org>
4687 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4689 2011-11-23 Chong Yidong <cyd@gnu.org>
4691 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4692 using it (Bug#5984).
4694 2011-11-22 Eli Zaretskii <eliz@gnu.org>
4696 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4697 and header-lines, as they don't have one computed for them.
4700 * .gdbinit (prow): Make displayed values more self-explaining.
4701 Add row's hash code.
4703 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4705 * process.c (wait_reading_process_output): Fix asynchrounous
4706 GnuTLS socket handling on some versions of the GnuTLS library.
4707 (wait_reading_process_output): Add comment and URL.
4709 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4711 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4713 2011-11-21 Chong Yidong <cyd@gnu.org>
4715 * window.c (Fnext_window, Fprevious_window): Doc fix.
4717 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4719 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4721 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4723 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4725 2011-11-20 Martin Rudalics <rudalics@gmx.at>
4727 * window.c (Fset_window_combination_limit): Rename argument
4729 (Vwindow_combination_limit): Remove "status" from doc-string.
4731 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4733 * m/ibms390.h: Remove.
4734 * m/ibms390x.h: Don't include "ibms390.h".
4736 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4738 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4739 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4741 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4743 * casetab.c (Fset_case_table):
4744 * charset.c (Fcharset_after): Fix typos.
4746 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
4748 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4749 Otherwise, valgrind does not work on some platforms.
4750 Problem reported by Andreas Schwab in
4751 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4752 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4753 is set, removing the need for VIRT_ADDRESS_VARIES.
4754 (PURE_P): Use a more-efficient implementation that needs just one
4755 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4756 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4757 to 4 (xorl, subq, cmpq, setbe).
4758 * alloc.c (pure): Always extern now, since that's the
4759 VIRT_ADDR_VARIES behavior.
4760 (PURE_POINTER_P): Use a single comparison, not two, for
4761 consistency with the new puresize.h.
4762 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4763 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4764 Remove VIRT_ADDR_VARIES no longer needed.
4766 2011-11-19 Eli Zaretskii <eliz@gnu.org>
4768 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4769 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4770 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4771 behave as if the cursor position were at the window margin.
4773 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4774 and the cursor position is out of bounds, behave as if the cursor
4775 position were at the window margin. (Bug#10075)
4777 2011-11-18 Chong Yidong <cyd@gnu.org>
4779 * window.c (Fwindow_combination_limit): Make first argument
4780 non-optional, since it is meaningless for live windows like the
4783 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4785 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4787 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4789 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4790 (graft_intervals_into_buffer): Simplify.
4792 2011-11-18 Eli Zaretskii <eliz@gnu.org>
4794 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4795 hash values of the two rows.
4796 (copy_row_except_pointers): Preserve the used[] arrays and the
4797 hash values of the two rows. (Bug#10035)
4798 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
4800 * xdisp.c (row_hash): New function, body extracted from
4801 compute_line_metrics.
4802 (compute_line_metrics): Call row_hash, instead of computing the
4805 * dispnew.c (verify_row_hash): Call row_hash for computing the
4806 hash code of a row, instead of duplicating code from xdisp.c.
4808 * dispextern.h (row_hash): Add prototype.
4810 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4812 * frame.c (delete_frame): Don't delete the terminal when the last
4813 X frame is closed if emacs is built with GTK toolkit.
4815 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
4817 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4819 2011-11-17 Martin Rudalics <rudalics@gmx.at>
4821 * window.c (Vwindow_splits): Rename to
4822 Vwindow_combination_resize. Suggested by Juri Linkov.
4823 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4826 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
4828 * nsfns.m (Fns_font_name):
4829 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
4831 2011-11-16 Martin Rudalics <rudalics@gmx.at>
4833 * window.h (window): Rename slot "nest" to "combination_limit".
4834 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4835 (Fset_window_nest): Rename to Fset_window_combination_limit.
4836 (Vwindow_nest): Rename to Vwindow_combination_limit.
4837 (recombine_windows, make_parent_window, make_window)
4838 (Fsplit_window_internal, saved_window)
4839 (Fset_window_configuration, save_window_save): Rename all
4840 occurrences of window_nest to window_combination_limit.
4842 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
4844 * image.c (imagemagick_load_image): Fix typo.
4846 2011-11-14 Eli Zaretskii <eliz@gnu.org>
4848 * xdisp.c (display_line): Move the call to
4849 highlight_trailing_whitespace before the call to
4850 compute_line_metrics, since the latter needs to see the final
4851 faces of all the glyphs to compute ROW's hash value.
4852 Fixes assertion violations in row_equal_p. (Bug#10035)
4854 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
4856 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4857 just return (bug#10044).
4859 2011-11-12 Eli Zaretskii <eliz@gnu.org>
4861 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4862 with user-defined heap size. Bump the default size of the temacs
4863 heap to 27MB, to avoid memory warning when running temacs.
4864 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4866 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4867 current_matrix and desired_matrix. (Bug#9990)
4868 (verify_row_hash) [XASSERTS]: New function.
4869 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4870 that the hash value of glyph rows is correct.
4872 2011-11-12 Martin Rudalics <rudalics@gmx.at>
4874 * window.h (window): Remove splits slot.
4875 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4876 (Fdelete_other_windows_internal, make_parent_window)
4877 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4878 (Fset_window_configuration, save_window_save): Don't deal with
4879 split status of windows.
4880 (saved_window): Remove splits slot.
4881 (Vwindow_splits): Rewrite doc-string.
4883 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4885 * xfns.c (unwind_create_frame):
4886 * nsfns.m (unwind_create_frame):
4887 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4888 Vframe_list (Bug#9999).
4890 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4892 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
4894 2011-11-11 Kenichi Handa <handa@m17n.org>
4896 * callproc.c (Fcall_process): Set the member dst_multibyte of
4899 2011-11-11 Johan Bockgård <bojohan@gnu.org>
4901 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4902 avoid a crash (bug#9496).
4904 2011-11-09 Chong Yidong <cyd@gnu.org>
4906 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4907 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4909 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4911 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4913 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4915 Avoid some portability problems by eschewing 'extern inline' functions.
4916 The trivial performance wins aren't worth the portability hassles; see
4917 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4919 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4920 (window_box_width, window_box_left, window_box_left_offset)
4921 (window_box_right, window_box_right_offset): Undo previous change,
4922 by removing the "extern"s.
4923 * intervals.c (adjust_intervals_for_insertion)
4924 (adjust_intervals_for_deletion): Undo previous change,
4925 making these static again.
4926 (offset_intervals, temp_set_point_both, temp_set_point)
4927 (copy_intervals_to_string): No longer inline.
4928 * xdisp.c (window_text_bottom_y, window_box_width)
4929 (window_box_height, window_box_left_offset)
4930 (window_box_right_offset, window_box_left, window_box_right)
4931 (window_box): No longer inline.
4933 2011-11-08 Chong Yidong <cyd@gnu.org>
4935 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
4936 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4937 Signal an error if not a live window.
4938 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4939 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4941 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
4943 * lisp.h (syms_of_abbrev): Remove declaration.
4944 Reported by CHENG Gao <chenggao@royau.me>.
4946 2011-11-07 Eli Zaretskii <eliz@gnu.org>
4948 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4949 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4950 of temacs in GUI mode.
4952 2011-11-07 Martin Rudalics <rudalics@gmx.at>
4954 * window.h: Declare delete_all_child_windows instead of
4955 delete_all_subwindows.
4956 * window.c (Fwindow_nest, Fset_window_nest)
4957 (Fset_window_new_total, Fset_window_new_normal)
4958 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4959 (delete_all_subwindows): Rename to delete_all_child_windows.
4960 (Fdelete_other_windows_internal, Fset_window_configuration):
4961 Call delete_all_child_windows instead of delete_all_subwindows.
4962 * frame.c (delete_frame): Call delete_all_child_windows instead
4963 of delete_all_subwindows.
4965 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4967 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4968 This is also needed for porting to any host where GC_MARK_STACK is
4969 not GC_MAKE_GCPROS_NOOPS.
4970 (which_symbols): Use it.
4972 2011-11-07 Kenichi Handa <handa@m17n.org>
4974 * coding.c (coding_set_destination): Check coding->src_pos only
4975 when coding->src_object is a buffer (bug#9910).
4977 * process.c (send_process): Set the member src_multibyte of coding
4978 to 0 (bug#9911) when sending a unibyte text.
4980 * callproc.c (Fcall_process): Set the member src_multibyte of
4981 process_coding to 0 (bug#9912).
4983 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4985 * xmenu.c (cleanup_widget_value_tree): New function.
4986 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4987 calling free_menubar_widget_value_tree directly (Bug#9830).
4989 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4991 Fix some portability problems with 'inline'.
4992 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4993 (window_box_width, window_box_left, window_box_left_offset)
4994 (window_box_right, window_box_right_offset): Declare extern.
4995 Otherwise, these inline functions do not conform to C99 and
4996 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4997 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4998 * intervals.c (adjust_intervals_for_insertion)
4999 (adjust_intervals_for_deletion): Now extern, because otherwise the
5000 extern inline functions 'offset_intervals' couldn't refer to it.
5001 (static_offset_intervals): Remove.
5002 (offset_intervals): Rewrite using the old contents of
5003 static_offset_intervals. The old version didn't conform to C99
5004 because an extern inline function contained a reference to an
5005 identifier with static linkage.
5007 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5009 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5012 2011-11-06 Eli Zaretskii <eliz@gnu.org>
5014 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5015 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5016 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5017 return Qleft_to_right.
5019 2011-11-06 Chong Yidong <cyd@gnu.org>
5021 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5022 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5023 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5024 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5025 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5026 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5027 (Fwindow_vscroll): Doc fix.
5028 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5029 argument, since it makes no sense to pass a live window and for
5030 consistency with window-child.
5032 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5034 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5037 2011-11-05 Jason Rumney <jasonr@gnu.org>
5039 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5040 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5042 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5043 bitwise arithmetic preventing use of unicode-sip and non-truetype
5046 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5048 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5051 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5052 initialization code to keep similarity to xfns.c after changes
5055 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5057 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5058 (unwind_create_frame): New function (Bug#9943).
5059 (Fx_create_frame): Restructure code to be more similar to the one in
5060 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5061 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5062 Move terminal->reference_count++ just before making the frame official
5065 * nsterm.m (x_free_frame_resources): New function.
5066 (x_destroy_window): Move code to x_free_frame_resources.
5068 * xfns.c (unwind_create_frame): Fix comment.
5069 (Fx_create_frame, x_create_tip_frame):
5070 Move terminal->reference_count++ just before making the frame
5071 official. Move initialization of image_cache_refcount and
5072 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5074 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5076 Support MSVC build with newer versions of Visual Studio.
5077 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5078 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5081 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5082 which are not supported by MSVC.
5083 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5084 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5086 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5088 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5090 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5092 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
5094 Support MSVC build with newer versions of Visual Studio.
5095 * w32.c: Don't include w32api.h for MSVC.
5096 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5098 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5099 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5100 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5101 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5103 (alloca) [_MSC_VER]: Define to _alloca.
5105 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5107 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5109 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5111 * xdisp.c (note_mouse_highlight): If either of
5112 previous/next-single-property-change returns nil, treat that as
5113 the beginning or the end of the buffer. (Bug#9955)
5115 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5117 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
5118 label is not null (Bug#9951).
5119 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5122 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5124 * window.c (Fwindow_body_size): Mention in the doc string that the
5125 return value is in frame's canonical units. (Bug#9949)
5127 2011-11-03 Eli Zaretskii <eliz@gnu.org>
5129 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5131 * w32fns.c (unwind_create_frame): If needed, free the glyph
5132 matrices of the partially constructed frame. (Bug#9943)
5133 * xfns.c (unwind_create_frame): Likewise.
5135 2011-11-01 Eli Zaretskii <eliz@gnu.org>
5137 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5138 Don't stop backward scan on the continuation glyph, even though
5139 its CHARPOS is positive.
5140 (mouse_face_from_buffer_pos, note_mouse_highlight):
5141 Rename cover_string to disp_string.
5143 2011-11-01 Martin Rudalics <rudalics@gmx.at>
5145 * window.c (temp_output_buffer_show): Don't use
5146 Vtemp_buffer_show_specifiers.
5147 (Vtemp_buffer_show_specifiers): Remove unused variable.
5149 2011-10-30 Eli Zaretskii <eliz@gnu.org>
5151 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5152 past the beginning of the current glyph matrix.
5154 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
5156 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5157 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5158 HAVE_GTK3 (Bug#9869).
5160 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5161 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5163 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5165 * xterm.c: Declare x_handle_net_wm_state to return int.
5166 (handle_one_xevent): Check if we are iconified but don't have
5167 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5168 (get_current_wm_state): Return non-zero if not hidden,
5169 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5170 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5171 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5172 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5174 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5176 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5177 so that this new function doesn't get optimized away by a
5178 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5180 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5182 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5184 2011-10-29 Eli Zaretskii <eliz@gnu.org>
5186 Fix the `xbytecode' command.
5187 * .gdbinit (xprintbytestr): New command.
5188 (xwhichsymbols): Rename from `which'; all callers changed.
5189 (xbytecode): Print the byte-code string as well.
5191 2011-10-29 Kim Storm <storm@cua.dk>
5193 * alloc.c (which_symbols): New function.
5195 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5197 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5200 2011-10-29 Glenn Morris <rgm@gnu.org>
5202 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5203 Not clear what it was for, and it causes various bugs. (Bug#9839)
5205 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5207 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5208 possible random value that matches one of those tested as
5209 condition to clear the mouse face.
5211 2011-10-28 Chong Yidong <cyd@gnu.org>
5213 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5215 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5217 * window.c (make_window): Initialize phys_cursor_on_p.
5219 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5221 * lisp.h (struct Lisp_Symbol): Update comments.
5223 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
5225 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5227 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5229 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5230 <oslsachem@gmail.com> for helping to debug this.
5232 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5233 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5234 (g_b_init_get_glyph_outline_w): New static variables.
5235 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5236 (GetGlyphOutlineW_Proc): New typedefs.
5237 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
5238 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5240 (w32font_open_internal, compute_metrics):
5241 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
5242 instead of calling the "wide" APIs directly.
5244 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5246 * w32.h (syms_of_w32font): Add prototype.
5248 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5250 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5251 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5252 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5253 (Fmove_to_window_line): Doc fix.
5255 2011-10-27 Chong Yidong <cyd@gnu.org>
5257 * process.c (make_process): Set gnutls_state to NULL.
5259 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5260 non-NULL, regardless of GNUTLS_INITSTAGE.
5261 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5262 an error. Set process slots as soon as we allocate them.
5264 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5266 2011-10-27 Chong Yidong <cyd@gnu.org>
5268 * gnutls.c (emacs_gnutls_deinit): New function.
5269 Deallocate credentials structures as well as calling gnutls_deinit.
5270 (Fgnutls_deinit, Fgnutls_boot): Use it.
5272 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5273 (deactivate_process): Call emacs_gnutls_deinit.
5275 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5277 * image.c (x_create_x_image_and_pixmap):
5278 * w32.c (sys_rename, w32_delayed_load):
5279 * w32font.c (fill_in_logfont):
5280 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5282 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
5284 * w32fns.c (w32_default_color_map): New function,
5285 extracted from Fw32_default_color_map.
5286 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5288 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5290 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5292 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5294 * keyboard.c (test_undefined): New function (bug#9751).
5295 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5297 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5299 * sysdep.c (init_sys_modes): Fix the check for the controlling
5300 terminal (Bug#6649).
5302 2011-10-20 Eli Zaretskii <eliz@gnu.org>
5304 * dispextern.h (struct bidi_it): New member next_en_type.
5306 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5307 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5308 current character, check also for next_en_type being WEAK_EN.
5309 (bidi_resolve_weak): Don't enter the expensive loop if the current
5310 position is before next_en_pos. Record the bidi type of the first
5311 non-ET, non-BN character we find, in addition to its position.
5312 (bidi_level_of_next_char): Invalidate next_en_type when
5313 next_en_pos is over-stepped.
5315 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5317 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5318 * editfns.c: Rewrite current-time-zone so that it invokes
5319 the equivalent of (format-time-string "%Z") to get the time zone name.
5320 This fixes a bug when the time zone name contains characters that
5321 need converting from the system time locale to Emacs internal format.
5322 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5323 that patch fixed format-time-string to do the conversion, but
5324 I forgot to fix current-time-zone.
5325 (format_time_string): New function, containing most of
5326 what Fformat_time_string used to contain.
5327 (Fformat_time_string): Rewrite in terms of format_time_string.
5328 This doesn't change this function's behavior.
5329 (current-time-zone): Rewrite to use format_time_string.
5330 This fixes the bug reported by Michael Schierl in
5331 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5332 Jason Rumney's 2007-06-07 change worked around this bug, but
5334 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5336 2011-10-19 Eli Zaretskii <eliz@gnu.org>
5338 * xdisp.c (start_display): If the character at POS is displayed
5339 via a display vector, reset IT->current.dpvec_index to zero.
5340 (try_window_reusing_current_matrix): If a line ends in a display
5341 vector or the next line starts in a display vector, continue
5342 redrawing the window even though the character position of
5343 start_row was reached.
5346 2011-10-18 Chong Yidong <cyd@gnu.org>
5348 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5349 with nobreak-char-display too.
5351 2011-10-18 Eli Zaretskii <eliz@gnu.org>
5353 Fix part 3 of bug#9771.
5354 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5355 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5356 non-neutral characters if the current character is a paragraph
5357 separator (a.k.a. Newline). This avoids running the same
5358 expensive loop twice, once when we consume the preceding newline
5359 and the other time when the line actually needs to be displayed.
5360 Avoid the loop when we see neutrals on the base embedding level
5361 following a character whose directionality is the same as the
5362 paragraph's. This avoids running the expensive loop when a line
5363 ends in a long sequence of neutrals, like control characters.
5364 Add assertion against STRONG_AL type. Slightly rearrange code
5365 that determines the type of a neutral given the first non-neutral
5367 (bidi_level_of_next_char): Set next_en_pos to zero when
5368 invalidating its info.
5370 2011-10-17 Eli Zaretskii <eliz@gnu.org>
5372 * xdisp.c (push_display_prop): Determine whether to record string
5373 or buffer position by IT->string, not by IT->method. Allow
5374 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
5375 (move_it_vertically_backward): Don't look for character position
5376 immediately after the newline when in a continuation line.
5379 2011-10-15 Martin Rudalics <rudalics@gmx.at>
5381 * window.c (coordinates_in_window): Rewrite and delabelize
5382 vertical border check. (Bug#5357) (Bug#9618)
5384 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5386 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5387 errors in XSetWindowBorder (bug#9310).
5389 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5391 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5392 avoid crash when xmalloc overrun checking is enabled.
5394 2011-10-13 Eli Zaretskii <eliz@gnu.org>
5396 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5397 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5398 cursor motion with <left> and <right> arrow keys.
5400 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5401 some callers set that themselves.
5403 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5405 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5406 display string and the previous row comes from the same string and
5407 is empty. (Bug#9739) (Bug#9738)
5409 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5411 * doc.c (get_doc_string): Encode file name (bug#9735).
5413 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5415 * bidi.c (bidi_level_of_next_char):
5416 * xdisp.c (get_visually_first_element): Remove old incorrect
5417 comments regarding the Unicode Line Separator character.
5419 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5421 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5423 * alloc.c (Fgc_status): Do not access beyond zombies array
5424 boundary if nzombies > MAX_ZOMBIES.
5425 * alloc.c (dump_zombies): Add missing format specifier.
5427 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5429 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5430 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5432 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5433 Some packages use them to denote characters with modifiers.
5435 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5437 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5438 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5439 matching a pp-number. Rename parameter var to var1.
5441 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5443 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5445 2011-10-08 Glenn Morris <rgm@gnu.org>
5447 * callint.c (Fcall_interactively): Give a more explicit error for the
5448 'c' case with a non-character input. (Bug#8479)
5450 2011-10-08 Eli Zaretskii <eliz@gnu.org>
5452 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5454 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5455 lines that are hscrolled on the left.
5457 * dispnew.c (buffer_posn_from_coords): Account for a possible
5458 presence of header-line. (Bug#4426)
5460 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5462 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5463 Don't advertise functionality which we discourage or doesn't work.
5465 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5467 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5468 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5469 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5470 this makes Emacs dump core during garbage collection on rare
5471 occasions. sizeof is obviously inferior to offsetof here, so
5472 stick with offsetof.
5473 (GC_POINTER_ALIGNMENT): New macro.
5474 (mark_memory): Omit 3rd (offset) arg; caller changed.
5475 Don't assume EMACS_INT alignment is the same as pointer alignment.
5477 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5479 * keyboard.c (read_key_sequence_remapped): New var.
5480 (read_key_sequence): Compute remapping in the right buffer.
5481 (command_loop_1): Use read_key_sequence's remapping directly.
5483 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5485 * dired.c (file_name_completion): Don't expand file name.
5486 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5487 before checking file name handler.
5489 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5490 they've been requested explicitly (bug#9591).
5492 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
5494 * keymap.c (Fsingle_key_description): Use make_specified_string
5495 instead of build_string to build string from push_key_description.
5498 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5500 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5501 This fixes a Y2038 bug on 64-bit hosts.
5502 * buffer.c (reset_buffer):
5503 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5504 (Fclear_buffer_auto_save_failure):
5505 Use 0, not -1, to represent an unset failure time, since time_t
5506 might not be signed.
5508 Remove dependency on glibc malloc internals.
5509 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5510 Move back here from lisp.h, but with their new implementations.
5511 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5512 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5513 * charset.c (charset_table_init): New static var.
5514 (syms_of_charset): Use it instead of xmalloc. This removes a
5515 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5516 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5517 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5518 Move back to alloc.c.
5519 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5520 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5522 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5524 * nsterm.m (windowDidResize): Call x_set_window_size only when
5525 ns_in_resize is true. Otherwise set pixelwidth/height and
5526 call change_frame_size (Bug#9628).
5528 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5530 Port --enable-checking=all to Fedora 14 x86-64.
5531 * charset.c (syms_of_charset): Also account for glibc malloc's
5532 internal overhead when calculating the initial malloc maximum.
5534 Port --enable-checking=all to Fedora 14 x86.
5535 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5537 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5538 (overrun_check_realloc, overrun_check_free):
5539 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5540 That way, xmalloc returns a properly-aligned pointer even if
5541 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5542 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5543 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5544 into account when calculating the initial malloc maximum.
5545 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5546 Move here from alloc.c, so that charset.c can use it too.
5547 Properly align; the old code wasn't right for common 32-bit hosts
5548 when configured with --enable-checking=all.
5549 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5550 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5552 2011-09-29 Eli Zaretskii <eliz@gnu.org>
5554 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
5557 2011-09-28 Eli Zaretskii <eliz@gnu.org>
5559 * xdisp.c (compute_display_string_end): If there's no display
5560 string at CHARPOS, return -1.
5562 * bidi.c (bidi_fetch_char): When compute_display_string_end
5563 returns a negative value, treat the character as a normal
5564 character not covered by a display string. (Bug#9624)
5566 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
5568 * lread.c (Fread_from_string): Fix typo in docstring.
5570 2011-09-27 Eli Zaretskii <eliz@gnu.org>
5572 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5573 newline, reseat the iterator instead of bidi-iterating there one
5574 character at a time. (Bug#9610)
5575 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5576 TO_CHARPOS if the bidi iterator is at base embedding level.
5578 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5580 * lread.c (readevalloop): Use correct code for NBSP.
5581 (read1): Likewise. (Bug#9608)
5583 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
5585 * dbusbind.c (Fdbus_register_signal): When service is not
5586 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5588 2011-09-25 Glenn Morris <rgm@gnu.org>
5590 * buffer.c (truncate-lines): Doc fix.
5592 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
5594 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5595 (Fset_window_next_buffers): Doc fix.
5597 2011-09-24 Glenn Morris <rgm@gnu.org>
5599 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5601 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5603 Fix minor problems found by static checking.
5604 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
5605 * indent.c (Fvertical_motion): Fix == vs = typo.
5607 2011-09-24 Eli Zaretskii <eliz@gnu.org>
5609 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5610 Default value is now t. Doc fix.
5612 * indent.c (Fvertical_motion): Compute and apply the overshoot
5613 logic when moving up, not only when moving down. Fix the
5614 confusing name and values of the it_overshoot_expected variable;
5615 logic changes accordingly. (Bug#9254) (Bug#9549)
5617 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5618 CHARPOS is covered by a display string which includes newlines.
5619 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5620 is covered by a display string with embedded newlines.
5622 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
5624 * dbusbind.c (Fdbus_register_signal): Add match rule to
5625 Vdbus_registered_objects_table. (Bug#9581)
5626 (Fdbus_register_method, Vdbus_registered_objects_table):
5629 2011-09-24 Jim Meyering <meyering@redhat.com>
5631 do not ignore write error for any output size
5632 The previous change was incomplete.
5633 While it makes emacs --batch detect the vast majority of stdout
5634 write failures, errors were still ignored whenever the output size is
5635 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5636 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5637 && echo FAIL: ignored write error
5638 FAIL: ignored write error
5639 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5640 && echo FAIL: ignored write error
5641 FAIL: ignored write error
5642 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5644 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5646 * emacs.c (Fkill_emacs): In noninteractive mode exit
5647 non-successfully if a write error occurred on stdout. (Bug#9574)
5649 2011-09-21 Eli Zaretskii <eliz@gnu.org>
5651 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5654 * dispextern.h (struct it): Update the comment documenting what
5657 2011-09-20 Eli Zaretskii <eliz@gnu.org>
5659 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5660 a display string, extend search for cursor position to end of row.
5661 (find_row_edges): If the row ends in a newline from a display
5662 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5663 Handle the case of a display string with multiple newlines.
5664 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5665 non-empty line. Fixes confusing cursor motion with arrow keys at
5666 the beginning of a line that starts with whitespace.
5668 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5670 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5673 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
5675 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5678 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5680 * xdisp.c (display_line): Record maximum and minimum buffer
5681 positions even if no glyphs were produced (e.g., by a zero-width
5682 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5683 buffer positions that will be removed from the glyph row because
5685 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5686 column is beyond frame width: don't subtract 1 "pixel" when
5687 computing width of the stretch.
5688 (reseat_at_next_visible_line_start): Undo the change made on
5689 2011-09-17 that saved paragraph information and restored it after
5690 the call to `reseat'. (Bug#9545)
5692 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5694 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5695 and turn window cursor on if cleared (Bug#9415).
5697 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
5699 * search.c (boyer_moore): Take unibyte characters from pattern
5700 literally. (Bug#9458)
5702 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5704 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5706 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5708 Fix minor problem found by static checking.
5709 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5710 initialized, to pacify gcc -Wuninitialized.
5712 * fileio.c: Report proper errno when syscall falls.
5713 (Finsert_file_contents): Save and restore errno,
5714 so that report_file_error outputs the correct diagnostic.
5715 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5717 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5719 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5721 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5723 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5724 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5726 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5728 * xdisp.c (reseat_at_next_visible_line_start): Keep information
5729 about the current paragraph and restore it after the call to reseat.
5731 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5732 (bidi_find_paragraph_start): Search back for paragraph beginning
5733 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5734 (bidi_move_to_visually_next): Only trigger paragraph-related
5735 computations when the last character is a newline or at EOB, not
5736 just any NEUTRAL_B. (Bug#9470)
5738 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5739 truncated lines if point is covered by a display string. (Bug#9524)
5741 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5743 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5744 (cons_to_x_long): New function.
5745 (lisp_data_to_selection_data): Use it. Correct the test for
5746 short-versus-long data; it was negated. Break out of vector
5747 loop, for efficiency, when a long datum is discovered.
5749 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5751 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5753 2011-09-16 Eli Zaretskii <eliz@gnu.org>
5755 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5756 GCC PR/17406) by declaring this function with external scope.
5758 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5760 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5761 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5763 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5765 * editfns.c (Fformat): Correctly handle text properties on "%%".
5767 2011-09-15 Eli Zaretskii <eliz@gnu.org>
5769 * xterm.c (x_draw_composite_glyph_string_foreground):
5770 * w32term.c (x_draw_composite_glyph_string_foreground):
5771 * term.c (encode_terminal_code):
5772 * composite.c (composition_update_it, get_composition_id):
5773 * xdisp.c (get_next_display_element)
5774 (fill_composite_glyph_string): Add comments about special meaning
5775 of TAB characters in a composition.
5777 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5779 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
5780 This occurs when processing a multibyte format.
5781 Problem reported by Wolfgang Jenker.
5783 2011-09-15 Johan Bockgård <bojohan@gnu.org>
5785 * xdisp.c (try_cursor_movement): Only check for exact match if
5786 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5788 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5790 Remove unused external symbols.
5791 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5792 * xdisp.c (calc_pixel_width_or_height): Now static.
5793 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5794 * indent.c (check_display_width):
5795 * w32term.c: Fix comment to match code.
5796 * xterm.c, xterm.h (x_catching_errors): Remove.
5798 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5800 * xselect.c: Use signed conversions more consistently (Bug#9498).
5801 (selection_data_to_lisp_data): Assume incoming selection data are
5802 signed integers, not unsigned. This is to be consistent with
5803 outgoing selection data, which was modified to use signed integers
5804 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5805 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5806 expects long, not unsigned long.
5808 2011-09-14 Eli Zaretskii <eliz@gnu.org>
5810 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5811 computation of loop end. Reported by Johan Bockgård
5814 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
5816 * frame.c (Fother_visible_frames_p): Function deleted.
5818 2011-09-12 Eli Zaretskii <eliz@gnu.org>
5820 * indent.c (compute_motion): Process display vector front to back
5821 rather than the other way around. (Bug#2496)
5823 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5825 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5827 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
5829 * minibuf.c (Fread_from_minibuffer): Doc fix.
5831 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5833 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5834 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5836 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5838 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5839 value for non-existent files.
5841 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5843 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5844 set its "size" to -1. This will set the modtime_size field of
5845 the corresponding buffer to -1, which is what
5846 verify-visited-file-modtime expects for files that do not exist.
5849 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5851 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5853 * lisp.h: ... from here. push_key_description is no longer
5854 defined in keyboard.c, so its declaration should not be in
5855 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5856 logically belongs with push_key_description.
5858 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5860 * buffer.h: Include <sys/types.h> instead of <time.h>.
5861 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5862 Problem reported by Herbert J. Skuhra.
5864 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5866 * xml.c (parse_region): Make the parsing work for
5867 non-comment-starting XML files again (bug#9144).
5869 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5871 * image.c (gif_load): Fix calculation of bottom and right corner.
5874 2011-09-10 Eli Zaretskii <eliz@gnu.org>
5876 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5877 redisplay in small windows.
5879 2011-09-09 Eli Zaretskii <eliz@gnu.org>
5881 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5883 2011-09-08 Martin Rudalics <rudalics@gmx.at>
5885 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5886 Operate on live windows only.
5888 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
5890 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5892 2011-09-07 Eli Zaretskii <eliz@gnu.org>
5894 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5895 only under bidi iteration.
5897 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5899 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5901 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5903 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5904 Without this fix, the command to link temacs failed due to an
5905 undefined symbol __builtin_isnan. This is because
5906 /usr/include/iso/math_c99.h #defines isnan(x) to
5907 __builtin_isnan(x), but the bundled gcc, which identifies itself
5908 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5910 * floatfns.c (isnan): #undef, and then #define to a clone of
5912 (Fisnan): Always define, since it's always available now.
5913 (syms_of_floatfns): Always define isnan at the Lisp level.
5915 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5917 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5919 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5921 * fileio.c: Fix bugs with large file offsets (Bug#9428).
5922 The previous code assumed that file offsets (off_t values) fit in
5923 EMACS_INT variables, which is not true on typical 32-bit hosts.
5924 The code messed up by falsely reporting buffer overflow in cases
5925 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5926 when "big" contains more than 2**29 bytes, even though this
5927 inserts just one byte and does not overflow the buffer.
5928 (Finsert_file_contents): Store file offsets as off_t
5929 values, not as EMACS_INT values. Check for overflow when
5930 converting between EMACS_INT and off_t. When checking for
5931 buffer overflow or for overlap, take the offsets into account.
5932 Don't use EMACS_INT for small values where int suffices.
5933 When checking for overlap, fix a typo: ZV was used where
5934 ZV_BYTE was intended.
5935 (Fwrite_region): Don't assume off_t fits into 'long'.
5936 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5938 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
5940 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5942 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5944 sprintf-related integer and memory overflow issues (Bug#9412).
5946 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
5947 (esprintf, exprintf, evxprintf): New functions.
5948 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
5949 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
5950 (modify_event_symbol): Do not assume that the length of
5951 name_alist_or_stem is safe to alloca and fits in int.
5952 (Fexecute_extended_command): Likewise for function name and binding.
5953 (Frecursion_depth): Wrap around reliably on integer overflow.
5954 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5955 since some callers pass EMACS_INT values.
5956 (Fsingle_key_description): Don't crash if symbol name contains more
5957 than MAX_ALLOCA bytes.
5958 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5959 (get_minibuffer): Arg is now EMACS_INT, not int.
5960 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
5961 (esprintf, exprintf, evxprintf): New decls.
5962 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5964 * dbusbind.c (signature_cat): New function.
5965 (xd_signature, Fdbus_register_signal):
5966 Do not overrun buffer; instead, report string overflow.
5968 * dispnew.c (add_window_display_history): Don't overrun buffer.
5969 Truncate instead; this is OK since it's just a log.
5971 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5972 even if the time zone offset is outlandishly large.
5973 Don't mishandle offset == INT_MIN.
5975 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5976 when creating daemon; the previous buffer-overflow check was incorrect.
5978 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5979 which has the guts of the old verror function.
5981 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5982 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5984 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5985 (font_unparse_xlfd): Don't blindly alloca long strings.
5986 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
5987 fits in int, when using sprintf. Use single snprintf to count
5988 length of string rather than counting it via multiple sprintfs;
5989 that's simpler and more reliable.
5990 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5991 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5992 sprintf, in case result does not fit in int.
5994 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5995 (fontset_from_font): Print it.
5997 * frame.c (tty_frame_count): Now printmax_t, not int.
5998 (make_terminal_frame, set_term_frame_name): Print it.
5999 (x_report_frame_params): In X, window IDs are unsigned long,
6000 not signed long, so print them as unsigned.
6001 (validate_x_resource_name): Check for implausibly long names,
6002 and don't assume name length fits in 'int'.
6003 (x_get_resource_string): Don't blindly alloca invocation name;
6004 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6007 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6008 (xg_check_special_colors, xg_set_geometry):
6009 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6011 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6012 Use esprintf, not sprintf, in case result does not fit in int.
6014 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6015 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6016 it as a large positive number.
6017 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6018 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6020 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6021 in case result does not fit in int.
6023 * print.c (float_to_string): Detect width overflow more reliably.
6024 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6025 buffer overrun. Don't assume list length fits in 'int'. Treat
6026 print length of 0 as 0, not as infinity; to be consistent with other
6027 uses of print length in this function. Don't overflow print length
6028 index. Don't assume hash table size fits in 'long', or that
6029 vectorlike size fits in 'unsigned long'.
6031 * process.c (make_process): Use printmax_t, not int, to format
6032 process-name gensyms.
6034 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6036 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6037 to avoid potential buffer overrun.
6039 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6040 if X resource line is longer than 512 bytes.
6042 * xfns.c (x_window): Make sprintf buffer a bit bigger
6043 to avoid potential buffer overrun.
6045 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6047 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6049 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6051 Integer overflow fixes for scrolling, etc.
6052 Without these, Emacs silently mishandles large integers sometimes.
6053 For example, "C-u 4294967297 M-x recenter" was treated as if
6054 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6056 * xdisp.c (try_window_id): Check Emacs fixnum range before
6057 converting to 'int'.
6059 * window.c (window_scroll_line_based, Frecenter):
6060 Check that an Emacs fixnum is in range before assigning it to 'int'.
6061 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6062 values converted from Emacs fixnums.
6063 (Frecenter): Don't wrap around a line count if it is out of 'int'
6064 range; instead, treat it as an extreme value.
6065 (Fset_window_configuration, compare_window_configurations):
6066 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6068 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6069 that can exceed INT_MAX. Check that EMACS_INT value is in range
6070 before assigning it to the (possibly-narrower) index.
6071 (match_limit): Don't assume that a fixnum can fit in 'int'.
6073 * print.c (print_object): Use ptrdiff_t, not int, for index that can
6076 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
6077 (Fvertical_motion): Don't wrap around LINES values that don't fit
6078 in 'int'. Instead, treat them as extreme values. This is good
6079 enough for windows, which can't have more than INT_MAX lines anyway.
6081 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6083 * Require libxml/parser.h to avoid compilation warning.
6085 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6087 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6088 since this reportedly can destroy thread storage.
6090 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
6092 * syntax.c (find_defun_start): Update all cache variables if
6093 exiting early (Bug#9401).
6095 2011-08-30 Eli Zaretskii <eliz@gnu.org>
6097 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6099 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6100 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6101 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6103 * term.c (tty_append_glyph): New function.
6104 (produce_stretch_glyph): Static function and its prototype deleted.
6106 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6109 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6111 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6112 when checking :margin (Bug#9390).
6113 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
6114 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
6115 so that the name doesn't mislead. All uses changed.
6117 2011-08-28 Johan Bockgård <bojohan@gnu.org>
6119 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6122 2011-08-27 Eli Zaretskii <eliz@gnu.org>
6124 * xdisp.c (move_it_to): Don't bail out early when reaching
6125 position beyond to_charpos, if we are scanning backwards.
6126 (move_it_vertically_backward): When DY == 0, make sure we get to
6127 the first character in the line after the newline.
6129 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6131 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6132 (ccl_driver): Do not generate an out-of-range pointer.
6133 (Fccl_execute_on_string): Remove unnecessary check for
6134 integer overflow, noted by Stefan Monnier in
6135 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6136 Remove a FIXME that didn't need fixing.
6137 Simplify the newly-introduced buffer reallocation code.
6139 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
6141 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6143 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
6145 Integer and memory overflow issues (Bug#9196).
6147 * doc.c (get_doc_string): Rework so that
6148 get_doc_string_buffer_size is the actual buffer size, rather than
6149 being 1 less than the actual buffer size; this makes xpalloc more
6152 * image.c (x_allocate_bitmap_record, cache_image):
6153 * xselect.c (Fx_register_dnd_atom):
6154 Simplify previous changes by using xpalloc.
6156 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6157 since either will do and ptrdiff_t is convenient with xpalloc.
6159 * charset.c (charset_table_size)
6160 (struct charset_sort_data.priority): Now ptrdiff_t.
6161 (charset_compare): Don't overflow if priorities differ greatly.
6162 (Fsort_charsets): Don't assume list length fits in int.
6163 Check for size-calculation overflow when allocating sort data.
6164 (syms_of_charset): Allocate an initial charset table that is
6165 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6167 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6169 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6170 The actual value is always <= INT_MAX, and leaving it unsigned made
6171 overflow checking harder.
6173 * dispextern.h (struct glyph_matrix.rows_allocated)
6174 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6175 with xpalloc. The values are still always <= INT_MAX.
6177 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6179 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6180 (SAFE_NALLOCA): New macro.
6182 * region-cache.c (struct boundary.pos, find_cache_boundary)
6183 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6184 (set_cache_region, invalidate_region_cache)
6185 (revalidate_region_cache, know_region_cache, region_cache_forward)
6186 (region_cache_backward, pp_cache):
6187 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6188 so that ptrdiff_t * can be passed to xpalloc.
6189 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6190 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6191 (pp_cache): Don't assume cache_len fits in int.
6192 * region-cache.h: Adjust extern decls to match.
6194 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6195 EMACS_INT, since either will do, for xpalloc.
6197 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6198 (xnmalloc, xnrealloc, xpalloc): New functions.
6200 * bidi.c (bidi_shelve_header_size): New constant.
6201 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6202 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6204 * bidi.c (bidi_cache_shrink):
6205 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6207 Don't update size of array until after memory allocation succeeds,
6208 because xmalloc/xrealloc may not return.
6209 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6210 now that we have proper integer overflow checking.
6211 (record_overlay_string, overlay_strings): Catch overflows when
6212 calculating size of overlay_str_buf.
6214 * callproc.c (Fcall_process): Check for size overflow when
6215 calculating size of args2.
6216 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6217 Normally we prefer signed values, but sticking with ptrdiff_t would
6218 require adding more-complicated checks.
6220 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6221 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6222 Redo buffer-overflow calculations to avoid integer overflow.
6223 Add a FIXME comment where memory seems to be over-allocated.
6225 * character.c (Fstring): Check for size-calculation overflow.
6227 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6228 unnecessary integer overflow. Check for size overflow.
6229 (encode_coding_object): Don't update size until xmalloc succeeds.
6231 * composite.c (get_composition_id): Check for overflow in glyph
6232 length calculations.
6234 Integer and memory overflow fixes for display code.
6235 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6236 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6237 (scrolling_window): Check for overflow in size calculations.
6238 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6239 Don't assume glyph table len fits in int.
6240 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6241 (row_table_size): Now ptrdiff_t, not int.
6242 (scrolling_window): Avoid overflow in size calculations.
6243 Don't update size until allocation succeeds.
6244 * fns.c (concat): Check for overflow in size calculations.
6245 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6246 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6247 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6249 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6250 (get_doc_string): Check for size calculation overflow.
6251 Don't update size until allocation succeeds.
6252 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6253 EMACS_INT, where ptrdiff_t will do.
6254 (Fsubstitute_command_keys): Check for string overflow.
6256 * editfns.c (set_time_zone_rule): Don't assume environment length
6258 (message_length): Now ptrdiff_t, not int.
6259 (Fmessage_box): Don't update size until allocation succeeds.
6260 Don't assume message length fits in int.
6261 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6263 * emacs.c (main): Do not reallocate argv, since there is a null at
6264 the end that can be overwritten, and this way there's no need to
6265 worry about size-calculation overflow.
6266 (sort_args): Check for size-calculation overflow.
6268 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6270 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6272 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6273 (x_set_scroll_bar_width, x_figure_window_size):
6274 Check for integer overflow.
6275 (x_set_alpha): Do not assume XINT fits in int.
6277 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6278 This is for the members text_lines, text_cols, total_lines, total_cols,
6279 where the system imposes an 'int' limit.
6281 * fringe.c (Fdefine_fringe_bitmap):
6282 Don't update size until alloc works.
6284 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6285 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6287 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6288 Check for size-calculation overflow.
6289 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6290 do, as we prefer signed integers.
6291 (id_to_widget.max_size, id_to_widget.used)
6292 (xg_store_widget_in_map, xg_remove_widget_from_map)
6293 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6294 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6295 Use and return ptrdiff_t, not int.
6296 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6297 * gtkutil.h: Change prototypes to match the above.
6299 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6300 are duplicate now that they've been promoted to lisp.h.
6301 (x_allocate_bitmap_record, x_alloc_image_color)
6302 (make_image_cache, cache_image, xpm_load):
6303 Don't update size until alloc is done.
6304 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6306 Check for size calculation overflow.
6307 (ct_colors_allocated_max): New constant.
6308 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6311 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6312 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6313 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6314 Use ptrdiff_t, not int, to count maps.
6315 (read_char_minibuf_menu_prompt): Check for overflow in size
6316 calculations. Don't update size until allocation succeeds.
6317 Redo calculations to avoid overflow.
6318 * keyboard.h: Change prototypes to match the above.
6320 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6322 (current_minor_maps): Check for size calculation overflow.
6323 * keymap.h: Change prototypes to match the above.
6325 * lread.c (read1, init_obarray): Don't update size until alloc done.
6327 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6328 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6330 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6331 Now ptrdiff_t, not int.
6332 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6333 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6335 * process.c (Fnetwork_interface_list): Check for overflow
6336 in size calculation.
6338 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6340 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6341 overflow. Don't bother calling xmalloc when xrealloc will do.
6343 * search.c (Freplace_match): Check for size calculation overflow.
6344 (Fset_match_data): Don't assume list lengths fit in 'int'.
6346 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6347 for command line length. Do not attempt to address one before the
6348 beginning of an array, as that's not portable.
6350 * term.c (max_frame_lines): Remove; unused.
6351 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6353 (encode_terminal_code, calculate_costs): Check for size
6354 calculation overflow.
6355 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6356 table lengths and related sizes. Don't update size until alloc
6357 done. Redo calculations to avoid overflow.
6358 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6360 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6361 subtracting pointers.
6362 (gobble_line): Check for overflow more carefully. Don't update size
6365 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6366 Don't update size until alloc done.
6367 Redo size calculations to avoid overflow.
6368 Check for size calculation overflow.
6369 (main) [DEBUG]: Fix typo in invoking tparam1.
6371 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6372 Use ptrdiff_t, not int, for sizes.
6373 (store_mode_line_noprop_char): Don't update size until alloc done.
6375 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6376 Use ptrdiff_t, not int, for sizes.
6377 (Finternal_make_lisp_face, cache_face):
6378 Check for size calculation overflow.
6379 (cache_face): Treat size calculation overflows as if they were
6380 memory exhaustion (the usual treatment), rather than aborting.
6382 * xfns.c (x_encode_text, x_set_name_internal)
6383 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6384 sizes, since they can exceed INT_MAX in size. Check for size
6385 calculation overflow.
6387 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6388 (xg_select): Check for size calculation overflow.
6389 Don't update size until alloc done.
6391 * xrdb.c (get_environ_db): Don't assume path length fits in int,
6392 as sprintf is limited to int lengths.
6394 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6395 (X_LONG_MIN): New macros.
6396 Use them to make the following changes clearer.
6397 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6398 This change doesn't affect the value now, but it may help remind
6399 future maintainers not to raise the value too much later.
6400 (SELECTION_QUANTUM): Remove, replacing with ...
6401 (selection_quantum): ... new function, which avoids overflow.
6403 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6404 assumption that selection length fits in 'int'.
6405 (x_reply_selection_request, x_handle_selection_request)
6406 (x_get_window_property, receive_incremental_selection)
6407 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6408 (lisp_data_to_selection_data, clean_local_selection_data):
6409 Use ptrdiff_t, not int, to record length of selection.
6410 (x_reply_selection_request, x_get_window_property)
6411 (receive_incremental_selection, x_property_data_to_lisp):
6412 Redo calculations to avoid overflow.
6413 (x_reply_selection_request): When sending hint, ceiling it at
6414 X_LONG_MAX rather than relying on wraparound overflow to send
6416 (x_get_window_property, receive_incremental_selection)
6417 (lisp_data_to_selection_data, x_property_data_to_lisp):
6418 Check for size-calculation overflow.
6419 (x_get_window_property, receive_incremental_selection)
6420 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6421 Don't store size until memory allocation succeeds.
6422 (x_get_window_property): Plug memory leak on memory exhaustion.
6423 Don't double-block input; malloc is safe here. Don't assume 2**34
6424 - 4 fits in unsigned long. Add an xassert to check
6425 XGetWindowProperty overflow. Be more careful about overflow
6426 calculations, and distinguish size from memory overflow better.
6427 (receive_incremental_selection): When tracing, don't assume
6428 unsigned int is less than INT_MAX.
6429 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6430 harmful) conversions of unsigned short to int.
6431 (lisp_data_to_selection_data): Don't assume that integers
6432 in the range -65535 through -1 fit in an X unsigned short.
6433 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6434 result parameters unless successful. Rely on cons_to_unsigned
6435 to report problems with elements; the old code wasn't right anyway.
6436 (x_check_property_data): Check for int overflow; we cannot use
6437 a wider type due to X limits.
6438 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6440 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
6442 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6443 (x_term_init): Check for size calculation overflow.
6444 (x_color_cells): Don't store size until memory allocation succeeds.
6445 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
6446 Don't assume alloca size is less than MAX_ALLOCA.
6447 (x_term_init): Don't assume length fits in int (sprintf is limited
6450 Use ptrdiff_t for composition IDs.
6451 * character.c (lisp_string_width):
6452 * composite.c (composition_table_size, n_compositions)
6453 (get_composition_id, composition_gstring_from_id):
6454 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6455 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6456 * window.c (Frecenter):
6457 Use ptrdiff_t, not int, for composition IDs.
6458 * composite.c (get_composition_id): Check for integer overflow.
6459 * composite.h: Adjust prototypes to match the above changes.
6461 Use ptrdiff_t for hash table indexes.
6462 * category.c (hash_get_category_set):
6463 * ccl.c (ccl_driver):
6464 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6465 * coding.c (coding_system_charset_list, detect_coding_system):
6466 * coding.h (struct coding_system.id):
6467 * composite.c (get_composition_id, gstring_lookup_cache):
6468 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6469 * image.c (xpm_get_color_table_h):
6470 * lisp.h (hash_lookup, hash_put):
6471 * minibuf.c (Ftest_completion):
6472 Use ptrdiff_t for hash table indexes, not int (which is too
6473 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6474 32-bit --with-wide-int hosts).
6476 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6477 Add a FIXME comment about memory leaks.
6478 (syms_of_charset): Don't assume xmalloc returns.
6480 Don't assume that stated character widths fit in int.
6481 * character.c (Fchar_width, c_string_width, lisp_string_width):
6482 * character.h (CHAR_WIDTH):
6483 * indent.c (MULTIBYTE_BYTES_WIDTH):
6484 Use sanitize_char_width to avoid undefined and/or bad behavior
6485 with outlandish widths.
6486 * character.h (sanitize_tab_width): Rename from sanitize_width,
6487 now that we have two such functions. All uses changed.
6488 (sanitize_char_width): New inline function.
6490 Don't assume that tab-width fits in int.
6491 * character.h (sanitize_width): New inline function.
6492 (SANE_TAB_WIDTH): New macro.
6493 (ASCII_CHAR_WIDTH): Use it.
6494 * indent.c (sane_tab_width): Remove. All uses replaced by
6495 SANE_TAB_WIDTH (current_buffer).
6496 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6498 * fileio.c: Integer overflow issues with file modes.
6499 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6501 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6502 Remove unreachable code.
6503 (read_hex, load_charset_map_from_file): Check for integer overflow.
6505 * xterm.c: Don't go over XClientMessageEvent limit.
6506 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6507 (x_send_scroll_bar_event): Likewise. Check that the size does not
6508 exceed limits imposed by XClientMessageEvent, as well as the usual
6509 ptrdiff_t and size_t limits.
6511 * keyboard.c: Overflow, signedness and related fixes.
6512 (make_lispy_movement): Use same integer type in forward decl
6513 that is used in the definition.
6514 (read_key_sequence, keyremap_step):
6515 Change bufsize argument back to int, undoing my 2011-03-30 change.
6516 We prefer signed types, and int is wide enough here.
6517 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6518 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6519 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6520 length, not size_t. Use ptrdiff_t for index, not int.
6521 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6522 possibility of integer overflow.
6524 Overflow, signedness and related fixes for images.
6526 * dispextern.h (struct it.stack[0].u.image.image_id)
6527 (struct_it.image_id, struct image.id, struct image_cache.size)
6528 (struct image_cache.used, struct image_cache.ref_count):
6529 * gtkutil.c (update_frame_tool_bar):
6530 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6531 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6532 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6533 * nsmenu.m (update_frame_tool_bar):
6534 * xdisp.c (calc_pixel_width_or_height):
6535 * xfns.c (image_cache_refcount):
6536 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6537 on typical 64-bit hosts.
6539 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6540 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6541 Omit unnecessary casts to int.
6542 (parse_image_spec): Check that integers fall into 'int' range
6543 when the callers expect that.
6544 (image_ascent): Redo ascent calculation to avoid int overflow.
6545 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6546 (lookup_image): Remove unnecessary tests.
6547 (xbm_image_p): Locals are now of int, not EMACS_INT,
6548 since parse_image_check makes sure they fit into int.
6549 (png_load, gif_load, svg_load_image):
6550 Prefer int to unsigned where either will do.
6551 (tiff_handler): New function, combining the cores of the
6552 old tiff_error_handler and tiff_warning_handler.
6553 This function is rewritten to use vsnprintf and thereby avoid
6554 stack buffer overflows. It uses only the features of vsnprintf
6555 that are common to both POSIX and native Microsoft.
6556 (tiff_error_handler, tiff_warning_handler): Use it.
6557 (tiff_load, gif_load, imagemagick_load_image):
6558 Don't assume :index value fits in 'int'.
6559 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6560 (imagemagick_load_image): Check that crop parameters fit into
6561 the integer types that MagickCropImage accepts. Don't assume
6562 Vimagemagick_render_type has a nonnegative value. Don't assume
6563 size_t fits in 'long'.
6564 (gs_load): Use printmax_t to print the widest integers possible.
6565 Check for integer overflow when computing image height and width.
6567 2011-08-26 Eli Zaretskii <eliz@gnu.org>
6569 * xdisp.c (redisplay_window): Don't force window start if point
6570 will be invisible in the resulting window. (Bug#9324)
6572 2011-08-25 Eli Zaretskii <eliz@gnu.org>
6574 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6575 the display spec is of the form `(space ...)'.
6576 (handle_display_spec): Return the value returned by
6577 handle_single_display_spec, not just 1 or zero.
6578 (handle_single_display_spec): If the display spec is of the form
6579 `(space ...)', and specifies display in the text area, return 2
6581 (try_cursor_movement): Check for the need to scroll more
6582 accurately, and prefer exact match for point under bidi.
6583 Don't advance `row' beyond the last row of the window.
6585 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6586 into disp_prop; all users changed.
6588 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6589 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6590 for the text covered by the display property.
6592 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
6594 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6595 Change return value to nil.
6596 (Frecord_buffer): Delete unused function.
6598 2011-08-24 Eli Zaretskii <eliz@gnu.org>
6600 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6601 buffers, return left-to-right.
6602 (set_cursor_from_row): Consider candidate row a win if its glyph
6603 represents a newline and point is on that newline. Fixes cursor
6604 positioning on the newline at EOL of R2L text within L2R
6605 paragraph, and vice versa.
6606 (try_cursor_movement): Check continued rows, in addition to
6607 continuation rows. Fixes unwarranted scroll when point enters a
6608 continued line of R2L text within an L2R paragraph, or vice versa.
6609 (cursor_row_p): Consider the case of point being equal to
6610 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6611 from the end of a short line to the beginning of a continued line
6612 of R2L text within L2R paragraph.
6613 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6614 composed characters.
6616 * bidi.c (bidi_check_type): Use xassert.
6617 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6620 2011-08-23 Eli Zaretskii <eliz@gnu.org>
6622 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6625 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
6627 * nsfont.m (ns_otf_to_script): Fix typo.
6629 2011-08-22 Kenichi Handa <handa@m17n.org>
6631 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6632 extra slot even if the purpose is char-code-property-table.
6634 2011-08-23 Eli Zaretskii <eliz@gnu.org>
6636 * xdisp.c (redisplay_window): When computing centering_position,
6637 account for the height of the header line. (Bug#8874)
6639 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6640 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6641 candidate is selected by the mouse, and that candidate has a
6642 composed character under the mouse.
6644 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6645 coordinates reported by pos-visible-in-window-p for a composed
6646 character in column zero.
6648 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6650 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6652 2011-08-22 Eli Zaretskii <eliz@gnu.org>
6654 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6655 consider it a hit if to_charpos is anywhere in the range of the
6656 composed buffer positions.
6658 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
6660 * image.c (gif_load): Don't assume that each subimage has the same
6661 dimensions as the base image. Handle disposal method that is
6662 "undefined" by the gif spec (Bug#9335).
6664 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
6666 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
6667 (Fcondition_case): Document `debug' symbol in error handler.
6669 2011-08-19 Eli Zaretskii <eliz@gnu.org>
6671 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6672 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6673 from an Org mode buffer to a Speedbar frame.
6675 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6676 a composition, take its buffer position from IT->cmp_it.charpos.
6677 Fixes cursor positioning at the beginning of a line that begins
6678 with a composed character.
6680 2011-08-18 Eli Zaretskii <eliz@gnu.org>
6682 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6683 character bidirectional type, use STRONG_L instead. Fixes crashes
6684 in a buffer produced by `describe-categories'.
6686 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6687 members before the level stack, so they would be saved and
6688 restored when copying iterator state. Fixes incorrect reordering
6689 around TABs covered by display properties.
6691 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6693 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
6695 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
6697 * eval.c (internal_condition_case, internal_condition_case_1)
6698 (internal_condition_case_2, internal_condition_case_n):
6699 Remove unnecessary aborts (Bug#9081).
6701 2011-08-17 Eli Zaretskii <eliz@gnu.org>
6703 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6704 has no `load' handler, try opening the file locally. (Bug#9311)
6706 2011-08-16 Ken Brown <kbrown@cornell.edu>
6708 * gmalloc.c: Expand comment.
6710 2011-08-16 Eli Zaretskii <eliz@gnu.org>
6712 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6713 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6715 2011-08-16 Ken Brown <kbrown@cornell.edu>
6717 Fix memory allocation problems in Cygwin build (Bug#9273).
6719 * unexcw.c ( __malloc_initialized): Declare external variable.
6720 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6722 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6724 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6726 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6728 [CYGWIN] (special_realloc): New function.
6729 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6730 requests to realloc storage in the static heap.
6732 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6734 * bidi.c (bidi_initialize): Remove unused local.
6736 2011-08-15 Eli Zaretskii <eliz@gnu.org>
6739 * biditype.h: Remove file.
6740 * makefile.w32-in ($(BLD)/bidi.$(O)):
6741 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
6743 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6745 * chartab.c: Improve commentary for the uniprop_table API.
6747 * bidi.c (bidi_paragraph_init): Support zero value of
6748 bidi_ignore_explicit_marks_for_paragraph_level.
6749 (bidi_initialize): Use uniprop_table instead of including
6750 biditype.h and bidimirror.h.
6752 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6753 coordinates of the iterator when restoring from ppos_it.
6756 2011-08-14 Kenichi Handa <handa@m17n.org>
6758 * process.c (create_process): Call setup_process_coding_systems
6759 after the pid of the process is set to -1 (Bug#8162).
6761 2011-08-14 Eli Zaretskii <eliz@gnu.org>
6763 * xdisp.c (move_it_in_display_line_to): Don't invoke
6764 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6765 ppos_it. Fixes vertical cursor motion when line beginning is
6766 covered by an image. (Bug#9296)
6768 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6770 * nsterm.h (ns_run_ascript): Declare.
6771 (NSAPP_DATA2_RUNASSCRIPT): Define.
6773 * nsfns.m (as_script, as_result, as_status): New static variables.
6774 (ns_run_ascript): New function.
6775 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
6776 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6777 the event loop. Get status from as_status (Bug#7276).
6779 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6780 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6781 the event loop (Bug#7276).
6783 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6785 * gnutls.c (QCgnutls_bootprop_priority)
6786 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6787 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6788 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6789 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6790 (QCgnutls_bootprop_verify_hostname_error)
6791 (QCgnutls_bootprop_callbacks_verify): Rename from
6792 Qgnutls_bootprop_..., all uses changed.
6794 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6797 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6799 * xfaces.c (Qframe_set_background_mode): Now static.
6800 * dispextern.h (Qframe_set_background_mode): Remove decl.
6802 * process.c (Fnetwork_interface_info): Declare local only if needed.
6804 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6806 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6807 (Fnetwork_interface_list): Allocate in increments of bytes instead
6808 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6809 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6811 (struct ifflag_def): notrailers is smart on OSX.
6812 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6813 Get hardware address with getifaddrs if available.
6815 2011-08-12 Eli Zaretskii <eliz@gnu.org>
6817 * xdisp.c (iterate_out_of_display_property): xassert that
6818 IT->position is set to within IT->object's boundaries. Break from
6819 the loop as soon as EOB is reached; avoids infloops in redisplay
6820 when IT->position is set up wrongly due to some bug.
6821 Set IT->current to match the bidi iterator unconditionally.
6822 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6823 entry. Force push_it to save on the stack the current
6824 buffer/string position, to be restored by pop_it. Fix flags in
6825 the iterator structure wrt the object coming from a display
6826 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6827 properties. (Bug#9284)
6829 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
6831 * fontset.c (fontset_get_font_group): Add proper type checks.
6834 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6836 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6837 and LC_VERSION_MIN_MACOSX.
6838 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6839 (dump_it) [LC_FUNCTION_STARTS]: Use it.
6841 2011-08-08 Eli Zaretskii <eliz@gnu.org>
6843 * xdisp.c (forward_to_next_line_start): Allow to use the
6844 no-display-properties-and-no-overlays under bidi display.
6845 Set disp_pos in the bidi iterator to avoid searches for display
6846 properties and overlays.
6848 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
6850 * editfns.c (Fset_time_zone_rule): Document relationship with the
6853 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6854 the font entity extracted from the cache (Bug#8109).
6856 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
6858 * composite.c (autocmp_chars): Don't reset point. That is done by
6859 restore_point_unwind (Bug#5984).
6861 2011-08-07 Juri Linkov <juri@jurta.org>
6863 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6864 to show the arg `TIME' instead of `TIMEVAL'.
6866 2011-08-06 Eli Zaretskii <eliz@gnu.org>
6868 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6869 display property strides EOL and includes a newline, as in
6870 longlines-mode. (Bug#9254)
6871 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6872 word-wrap under bidirectional display. (Bug#9224)
6874 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6875 is non-zero, even if the data buffer is NULL. Fixes a crash in
6876 vertical-motion with longlines-mode. (Bug#9254)
6878 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6880 * bidi.c <bidi_cache_total_alloc>: Now static.
6881 (bidi_initialize): Initialize bidi_cache_total_alloc.
6883 * xdisp.c (display_line): Release buffer allocated for shelved bidi
6886 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6887 amount allocated this far in `bidi_cache_total_alloc'.
6888 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6889 non-zero, only free the data buffer without restoring the cache
6890 contents. All callers changed.
6892 * dispextern.h (bidi_unshelve_cache): Update prototype.
6894 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6895 (move_it_in_display_line, move_it_to)
6896 (move_it_vertically_backward, move_it_by_lines): Replace the call
6897 to xfree to an equivalent call to bidi_unshelve_cache.
6898 (move_it_in_display_line_to): Fix logic of returning
6899 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
6901 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6903 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6904 came from a string character with a `cursor' property. (Bug#9229)
6906 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6908 * Makefile.in (LIB_PTHREAD): New variable.
6909 (LIBES): Add LIB_PTHREAD (Bug#9216).
6911 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6912 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6914 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6916 * regex.c (re_iswctype): Remove some redundant boolean conversions.
6918 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6920 * xterm.c (x_find_topmost_parent): New function.
6921 (x_set_frame_alpha): Find topmost parent window with
6922 x_find_topmost_parent and set the property there also (bug#9181).
6923 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6925 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6927 * callproc.c (Fcall_process): Avoid vfork clobbering
6928 the local vars buffer, coding_systems, current_dir.
6930 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6932 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6934 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6936 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6937 so that it is not optimized away.
6939 * xdisp.c (compute_display_string_pos): Remove unused local.
6941 2011-08-02 Eli Zaretskii <eliz@gnu.org>
6943 Fix slow cursor motion and scrolling in large buffers with
6944 selective display, like Org Mode buffers. (Bug#9218)
6946 * dispextern.h (struct bidi_it): New member disp_prop_p.
6948 * xdisp.c: Remove one-slot cache of display string positions.
6949 (compute_display_string_pos): Accept an additional argument
6950 DISP_PROP_P; callers changed. Scan at most 5K characters forward
6951 for a display string or property. If found, set DISP_PROP_P
6954 * bidi.c (bidi_fetch_char): Accept an additional argument
6955 DISP_PROP_P, and pass it to compute_display_string_pos.
6956 Only handle text covered by a display string if DISP_PROP_P is returned
6957 non-zero. All callers of bidi_fetch_char changed.
6959 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6961 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6963 2010-12-03 Don March <don@ohspite.net>
6965 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6966 last character M-[char] is translated to ESC [char] (bug#7541).
6968 2011-08-02 Kenichi Handa <handa@m17n.org>
6970 * lisp.h (uniprop_table): Extern it.
6972 * chartab.c (uniprop_table): Make it non-static.
6974 2011-08-01 Eli Zaretskii <eliz@gnu.org>
6976 * xdisp.c (forward_to_next_line_start): Accept additional argument
6977 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6979 (reseat_at_next_visible_line_start): Use the bidi iterator state
6980 returned by forward_to_next_line_start to restore the state of
6981 it->bidi_it after backing up to previous newline. (Bug#9212)
6983 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6985 * regex.c (re_comp): Protoize.
6986 (re_exec): Fix return type.
6987 (regexec): Fix type of `ret'. (Bug#9203)
6989 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6991 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6992 This is needed if max-image-size is a floating-point number.
6994 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6996 * print.c (print_object): Print empty symbol as ##.
6998 * lread.c (read1): Read ## as empty symbol.
7000 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7002 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7003 setting frame foreground color (Bug#9175).
7004 (x_set_background_color): Likewise.
7006 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7007 contents (Bug#9176).
7008 (EmacsTooltip -init): Remove bezels and add shadows to
7011 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7012 or scroll bar (Bug#8470).
7014 * nsfont.m (nsfont_open): Remove assignment to voffset and
7015 unnecessary vars hshink, expand, hd, full_height, min_height.
7016 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7018 * nsterm.h (nsfont_info): Remove voffset field.
7020 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7022 Implement strike-through and overline on NextStep (Bug#8863).
7024 * nsfont.m (nsfont_open): Use underline position provided by font,
7025 instead of hard-coded value of 2.
7026 (nsfont_draw): Call ns_draw_text_decoration instead.
7028 * nsterm.h: Add declaration for ns_draw_text_decoration.
7030 * nsterm.m (ns_draw_text_decoration): New function for drawing
7031 underline, overline, and strike-through.
7032 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7033 ns_draw_text_decoration. Change treatment of cursor drawing to
7034 accommodate underlining, etc.
7036 2011-07-28 Eli Zaretskii <eliz@gnu.org>
7038 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7041 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7043 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7044 Without this fix, if a signal arrives just after memory fills up,
7045 'malloc' might be invoked reentrantly.
7047 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7048 In other words, assume that every image size is allowed, on non-X
7049 hosts. This assumption is probably wrong, but it lets Emacs compile.
7051 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7053 * regex.c (re_iswctype): Convert return values to boolean.
7055 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7057 * xdisp.c (compute_display_string_pos): Don't use cached display
7058 string position if the buffer had its restriction changed.
7061 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7063 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7065 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7067 Integer signedness and overflow and related fixes. (Bug#9079)
7069 * bidi.c: Integer size and overflow fixes.
7070 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7071 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7072 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7073 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7074 (bidi_find_other_level_edge):
7075 Use ptrdiff_t instead of EMACS_INT where either will do.
7076 This works better on 32-bit hosts configured --with-wide-int.
7077 (bidi_cache_ensure_space): Check for size-calculation overflow.
7078 Use % rather than repeated addition, for better worst-case speed.
7079 Don't set bidi_cache_size until after xrealloc returns, because it
7081 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
7082 (bidi_cache_ensure_space): Also check that the bidi cache size
7083 does not exceed that of the largest Lisp string or buffer. See Eli
7084 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
7086 * alloc.c (__malloc_size_t): Remove.
7087 All uses replaced by size_t. See Andreas Schwab's note
7088 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7090 * image.c: Improve checking for integer overflow.
7091 (check_image_size): Assume that f is nonnull, since
7092 it is always nonnull in practice. This is one less thing to
7093 worry about when checking for integer overflow later.
7094 (x_check_image_size): New function, which checks for integer
7095 overflow issues inside X.
7096 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7097 This removes the need for a memory_full check.
7098 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7099 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7100 (xbm_read_bitmap_data): Change locals back to 'int', since
7101 their values must fit in 'int'.
7102 (xpm_load_image, png_load, tiff_load):
7103 Invoke x_create_x_image_and_pixmap earlier,
7104 to avoid much needless work if the image is too large.
7105 (tiff_load): Treat overly large images as if
7106 x_create_x_image_and_pixmap failed, not as malloc failures.
7107 (gs_load): Use x_check_image_size.
7109 * gtkutil.c: Omit integer casts.
7110 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7111 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7113 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7115 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7116 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7117 would wrongly return t on a 64-bit host.
7119 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7120 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7121 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7122 and therefore cause GCC to emit a bogus diagnostic in some cases.
7124 * image.c: Integer signedness and overflow and related fixes.
7125 This is not an exhaustive set of fixes, but it's time to
7126 record what I've got.
7127 (lookup_pixel_color, check_image_size): Remove redundant decls.
7128 (check_image_size): Don't assume that arbitrary EMACS_INT values
7129 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7130 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7131 (tiff_load, imagemagick_load_image):
7132 Check for overflow in size calculations.
7133 (x_create_x_image_and_pixmap): Remove unnecessary test for
7134 xmalloc returning NULL; that can't happen.
7135 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7136 (xpm_color_bucket): Use better integer hashing function.
7137 (xpm_cache_color): Don't possibly over-allocate memory.
7138 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7139 (gif_memory_source):
7140 Use ptrdiff_t, not int or size_t, to record sizes.
7141 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7142 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7143 either works, as we prefer signed integers.
7144 (tiff_read_from_memory, tiff_write_from_memory):
7145 Return tsize_t, not size_t, since that's what the TIFF API wants.
7146 (tiff_read_from_memory): Don't fail simply because the read would
7147 go past EOF; instead, return a short read.
7148 (tiff_load): Omit no-longer-needed casts.
7149 (Fimagemagick_types): Don't assume size fits into 'int'.
7151 Improve hashing quality when configured --with-wide-int.
7152 * fns.c (hash_string): New function, taken from sxhash_string.
7153 Do not discard information about ASCII character case; this
7154 discarding is no longer needed.
7155 (sxhash-string): Use it. Change sig to match it. Caller changed.
7156 * lisp.h: Declare it.
7157 * lread.c (hash_string): Remove, since we now use fns.c's version.
7158 The fns.c version returns a wider integer if --with-wide-int is
7159 specified, so this should help the quality of the hashing a bit.
7161 * emacs.c: Integer overflow minor fix.
7162 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7163 Define only if GNU_LINUX.
7164 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7166 * dispnew.c: Integer signedness and overflow fixes.
7167 Remove unnecessary forward decls, that were a maintenance hassle.
7168 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7170 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7171 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7172 (prepare_desired_row, line_draw_cost):
7173 Use int, not unsigned, where either works.
7174 (save_current_matrix, restore_current_matrix):
7175 Use ptrdiff_t, not size_t, where either works.
7176 (init_display): Check for overflow more accurately, and without
7177 relying on undefined behavior.
7179 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7180 Remove, replacing with the new symbols in lisp.h. All uses changed.
7181 * fileio.c (make_temp_name):
7182 * filelock.c (lock_file_1, lock_file):
7183 * xdisp.c (message_dolog):
7184 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7185 Use pMd etc. instead.
7186 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7187 replacing the pWIDE etc. symbols removed from editfns.c.
7189 * keyboard.h (num_input_events): Now uintmax_t.
7190 This is (very slightly) less likely to mess up due to wraparound.
7193 * buffer.c: Integer signedness fixes.
7194 (alloc_buffer_text, enlarge_buffer_text):
7195 Use ptrdiff_t rather than size_t when either will do, as we prefer
7198 * alloc.c: Integer signedness and overflow fixes.
7199 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7200 (__malloc_size_t): Default to size_t, not to int.
7201 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7202 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7203 Prefer ptrdiff_t to size_t when either would do, as we prefer
7205 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7206 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7207 Now const. Initialize with values that are in range even if char
7209 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7210 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7211 These functions do the right thing with sizes > 2**32.
7212 (check_depth): Now ptrdiff_t, not int.
7213 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7214 Adjust to new way of storing sizes. Check for size overflow bugs
7216 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7217 slightly wrong anyway, as it missed one instance of
7218 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7219 (refill_memory_reserve): Omit needless cast to size_t.
7220 (mark_object_loop_halt): Mark as externally visible.
7222 * xselect.c: Integer signedness and overflow fixes.
7223 (Fx_register_dnd_atom, x_handle_dnd_message):
7224 Use ptrdiff_t, not size_t, since we prefer signed.
7225 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7226 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7227 x_dnd_atoms_size and x_dnd_atoms_length.
7229 * doprnt.c: Prefer signed to unsigned when either works.
7231 * doprnt.c (doprnt):
7233 * xdisp.c (vmessage):
7234 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7235 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7236 prefer signed arithmetic to avoid comparison confusion.
7237 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7238 but is a bit tricky.
7240 Assume freestanding C89 headers, string.h, stdlib.h.
7241 * data.c, doprnt.c, floatfns.c, print.c:
7242 Include float.h unconditionally.
7243 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7244 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7245 * regex.c: Likewise for stddef.h, string.h.
7246 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7247 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7248 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7249 (STDC_HEADERS): Remove obsolete defines.
7250 * sysdep.c: Include limits.h unconditionally.
7252 Assume support for memcmp, memcpy, memmove, memset.
7253 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7254 * regex.c (memcmp, memcpy):
7255 Remove; we assume C89 now.
7257 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7258 (__malloc_safe_bcopy): Remove; no longer needed.
7260 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
7261 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7262 well either way, and we prefer signed to unsigned.
7264 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7266 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7267 closes the connection while we're reading (bug#9182).
7269 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
7271 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7272 are specified (Bug#9168).
7274 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7276 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7277 Found by GCC static checking and --with-wide-int on a 32-bit host.
7279 2011-07-25 Eli Zaretskii <eliz@gnu.org>
7281 * xdisp.c (compute_display_string_pos): Fix logic of caching
7282 previous display string position. Initialize cached_prev_pos to
7283 -1. Fixes slow-down at the beginning of a buffer.
7285 2011-07-24 Eli Zaretskii <eliz@gnu.org>
7287 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7288 for attrs[LFACE_FONTSET_INDEX].
7290 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7292 * xml.c (parse_region): Remove unused local
7293 that was recently introduced.
7295 2011-07-23 Eli Zaretskii <eliz@gnu.org>
7297 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7298 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7300 * xdisp.c (move_it_in_display_line_to): Record the best matching
7301 position for TO_CHARPOS while scanning the line, and restore it on
7302 exit if none of the characters scanned was an exact match.
7303 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
7304 when exact match is impossible due to invisible text, and the
7305 lines are truncated.
7307 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7309 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7312 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7314 Fix a significant slow-down of cursor motion with C-n, C-p,
7315 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7316 auto-repeat under bidi redisplay in fontified buffers.
7317 * xdisp.c (compute_stop_pos_backwards): New function.
7318 (next_element_from_buffer): Call compute_stop_pos_backwards to
7319 find a suitable prev_stop when we find ourselves before
7321 (reseat): Don't look for prev_stop, as that could mean a very long
7323 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7324 <cached_disp_overlay_modiff>: Cache for last found display string
7326 (compute_display_string_pos): Return the cached position if asked
7327 about the same buffer in the same area of character positions, and
7328 the buffer wasn't changed since the time the display string
7329 position was cached.
7331 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7333 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7334 is an integer, which is important for empty lines. (Bug#9149)
7336 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
7338 * frame.c (Fmodify_frame_parameters): In tty case, update the
7339 default face if necessary (Bug#4238).
7341 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
7343 * editfns.c (Fstring_to_char): No need to explain what a character
7344 is in the docstring (Bug#6576).
7346 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7348 * xml.c (parse_region): Make sure we always return a tree.
7350 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7352 * xml.c (parse_region): If a document contains only comments,
7355 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7357 * xml.c (make_dom): Return comments, too.
7359 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7362 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7363 and the surrounding thread.
7364 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7365 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7366 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7368 * s/openbsd.h (BROKEN_SIGIO): Define.
7369 * unexelf.c (unexec) [__OpenBSD__]:
7370 Don't update the .mdebug section of the Alpha COFF symbol table.
7372 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7374 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7377 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7379 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7380 This fixes some race conditions on the permissions of any newly
7383 * alloc.c (valid_pointer_p): Use pipe, not open.
7384 This fixes some permissions issues when debugging.
7386 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7387 If fchown fails to set both uid and gid, try to set just gid,
7388 as that is sometimes allowed. Adjust the file's mode to eliminate
7389 setuid or setgid bits that are inappropriate if fchown fails.
7391 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7393 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7394 to compare Lisp_Objects.
7395 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7396 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7397 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7399 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7401 * lread.c (read_integer): Unread even EOF character.
7402 (read1): Likewise. Properly record start position of symbol.
7404 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7405 symbol character follows.
7407 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7409 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7410 This works around a problem with the previous change to Fcopy_file.
7411 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7412 and without this change, GCC might complain about discarding
7413 fchown's return value.
7415 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
7417 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7419 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7421 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7423 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7425 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7426 it's used from the C level.
7428 * process.c: Use the same condition for POLL_FOR_INPUT in both
7429 keyboard.c and process.c (bug#1858).
7431 2011-07-09 Lawrence Mitchell <wence@gmx.li>
7433 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7434 (Fgnutls_boot): Use it.
7436 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7438 * doc.c (Fsubstitute_command_keys): Revert last change.
7440 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7442 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7443 quotes the next character, and doesn't affect other longer
7444 sequences (bug#8935).
7446 * lread.c (syms_of_lread): Clarify that is isn't only
7447 `eval-buffer' and `eval-defun' that's affected by
7448 `lexical-binding' (bug#8460).
7450 2011-07-15 Eli Zaretskii <eliz@gnu.org>
7452 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
7453 bidi redisplay when a line includes both an image and is truncated.
7455 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7457 Fix minor problems found by static checking.
7458 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7459 (elsz): Now a signed constant, not a size_t var. We prefer signed
7460 types to unsigned, to avoid integer comparison confusion. Without
7461 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7462 "cannot optimize loop, the loop counter may overflow", a symptom
7464 * indent.c (Fvertical_motion): Mark locals as initialized.
7465 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7467 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7469 * search.c (Fre_search_backward): Mention `case-fold-search' in
7470 all the re_search_* functions (bug#8138).
7472 * keyboard.c (Fopen_dribble_file): Document when the file is
7475 2011-07-14 Eli Zaretskii <eliz@gnu.org>
7477 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7480 Support bidi reordering of display and overlay strings.
7481 * xdisp.c (compute_display_string_pos)
7482 (compute_display_string_end): Accept additional argument STRING.
7483 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7484 (reseat_to_string): Initialize bidi_it->string.s and
7485 bidi_it->string.schars.
7486 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
7487 NULL (avoids a crash in bidi_paragraph_init).
7488 Initialize itb.string.lstring.
7489 (init_iterator): Call bidi_init_it only of a valid
7490 buffer position was specified. Initialize paragraph_embedding to
7492 (reseat_to_string): Initialize the bidi iterator.
7493 (display_string): If we need to ignore text properties of
7494 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7495 original value of -1 will not work with bidi.)
7496 (compute_display_string_pos): First arg is now struct
7497 `text_pos *'; all callers changed. Support display properties on
7499 (compute_display_string_end): Support display properties on Lisp
7501 (init_iterator, reseat_1, reseat_to_string): Initialize the
7502 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7503 when iterating on a string not from display properties).
7504 (compute_display_string_pos, compute_display_string_end):
7505 Fix calculation of the object to scan. Fixes an error when using
7507 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
7508 base_level_stop; instead, set base_level_stop to BEGV.
7509 Fixes crashes in vertical-motion.
7510 (next_element_from_buffer): Improve commentary for when
7511 the iterator is before prev_stop.
7512 (init_iterator): Initialize bidi_p from the default value of
7513 bidi-display-reordering, not from buffer-local value. Use the
7514 buffer-local value only if initializing for buffer iteration.
7515 (handle_invisible_prop): Support invisible properties on strings
7516 that are being bidi-reordered.
7517 (set_iterator_to_next): Support bidi reordering of C strings and
7519 (next_element_from_string): Support bidi reordering of Lisp
7521 (handle_stop_backwards): Support Lisp strings as well.
7522 (display_string): Support display of R2L glyph rows.
7523 Use IT_STRING_CHARPOS when displaying from a Lisp string.
7524 (init_iterator): Don't initialize it->bidi_p for strings
7526 (reseat_to_string): Initialize it->bidi_p for strings here.
7527 (next_element_from_string, next_element_from_c_string)
7528 (next_element_from_buffer): Add xassert's for correspondence
7529 between IT's object being iterated and it->bidi_it.string
7531 (face_before_or_after_it_pos): Support bidi iteration.
7532 (next_element_from_c_string): Handle the case of the first string
7533 character that is not the first one in the visual order.
7534 (get_visually_first_element): New function, refactored from common
7535 parts of next_element_from_buffer, next_element_from_string, and
7536 next_element_from_c_string.
7537 (tool_bar_lines_needed, redisplay_tool_bar)
7538 (display_menu_bar): Force left-to-right direction. Add a FIXME
7539 comment for making that be controlled by a user option.
7540 (push_it, pop_it): Save and restore the state of the
7541 bidi iterator. Save and restore the bidi_p flag.
7542 (pop_it): Iterate out of display property for string iteration as
7544 (iterate_out_of_display_property): Support iteration over strings.
7545 (handle_single_display_spec): Set up it->bidi_it for iteration
7546 over a display string, and call bidi_init_it.
7547 (handle_single_display_spec, next_overlay_string)
7548 (get_overlay_strings_1, push_display_prop): Set up the bidi
7549 iterator for displaying display or overlay strings.
7550 (forward_to_next_line_start): Don't use the shortcut if
7552 (back_to_previous_visible_line_start): If handle_display_prop
7553 pushed the iterator stack, restore the internal state of the bidi
7554 iterator by calling bidi_pop_it same number of times.
7555 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7556 and we are bidi-iterating, don't decrement the iterator position;
7557 instead, set the first_elt flag in the bidi iterator, to produce
7559 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7560 (push_display_prop): xassert that we are iterating a buffer.
7561 (push_it, pop_it): Save and restore paragraph_embedding member.
7562 (handle_single_display_spec, next_overlay_string)
7563 (get_overlay_strings_1, reseat_1, reseat_to_string)
7564 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7565 correctly. Don't assume unibyte strings are not bidi-reordered.
7566 (compute_display_string_pos)
7567 (compute_display_string_end): Fix handling the case of C string.
7568 (push_it, pop_it): Save and restore from_disp_prop_p.
7569 (handle_single_display_spec, push_display_prop): Set the
7570 from_disp_prop_p flag.
7571 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7572 (pop_it): Call iterate_out_of_display_property only if we are
7573 popping after iteration over a string that came from a display
7574 property. Fix a typo in popping stretch info. Add an assertion
7575 for verifying that the iterator position is in sync with the bidi
7577 (handle_single_display_spec, get_overlay_strings_1)
7578 (push_display_prop): Fix initialization of paragraph direction for
7579 string when that of the parent object is not yet determined.
7580 (reseat_1): Call bidi_init_it to resync the bidi
7581 iterator with IT's position. (Bug#7616)
7582 (find_row_edges): If ROW->start.pos gives position
7583 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7584 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7585 Reset the from_disp_prop_p flag.
7586 (SAVE_IT, RESTORE_IT): New macros.
7587 (pos_visible_p, face_before_or_after_it_pos)
7588 (back_to_previous_visible_line_start)
7589 (move_it_in_display_line_to, move_it_in_display_line)
7590 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7591 (try_scrolling, redisplay_window, display_line): Use them when
7592 saving a temporary copy of the iterator and restoring it back.
7593 (back_to_previous_visible_line_start, reseat_1)
7594 (init_iterator): Empty the bidi cache "stack".
7595 (move_it_in_display_line_to): If iterator ended up at
7596 EOL, but we never saw any buffer positions smaller than
7597 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7598 motion in bidi-reordered lines.
7599 (move_it_in_display_line_to): Record prev_method and prev_pos
7600 immediately before the call to set_iterator_to_next. Fixes cursor
7601 motion in bidi-reordered lines with stretch glyphs and strings
7602 displayed in margins. (Bug#8133) (Bug#8867)
7603 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7605 (pos_visible_p): Support positions in bidi-reordered lines.
7606 Save and restore bidi cache.
7608 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7609 (bidi_paragraph_info): Delete unused struct.
7610 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7611 (bidi_cache_start): New variable.
7612 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7614 (bidi_cache_fetch_state, bidi_cache_search)
7615 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7616 (bidi_cache_find, bidi_peek_at_next_level)
7617 (bidi_level_of_next_char, bidi_find_other_level_edge)
7618 (bidi_move_to_visually_next): Compare cache index with
7619 bidi_cache_start rather than with zero.
7620 (bidi_fetch_char): Accept new argument STRING; all callers
7621 changed. Support iteration over a string. Support strings with
7622 display properties. Support unibyte strings. Fix the type of
7623 `len' according to what STRING_CHAR_AND_LENGTH expects.
7624 (bidi_paragraph_init, bidi_resolve_explicit_1)
7625 (bidi_resolve_explicit, bidi_resolve_weak)
7626 (bidi_level_of_next_char, bidi_move_to_visually_next):
7627 Support iteration over a string.
7628 (bidi_set_sor_type, bidi_resolve_explicit_1)
7629 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7630 can now be zero (for strings); special values 0 and -1 were
7631 changed to -1 and -2, respectively.
7632 (bidi_char_at_pos): New function.
7633 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7634 Call it instead of FETCH_MULTIBYTE_CHAR.
7635 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7636 initialized to valid values.
7637 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7639 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7640 the test for valid cached positions. Fix the logic for looking up
7641 the sentinel state in the cache. GCPRO the Lisp string we are
7643 (bidi_push_it, bidi_pop_it): New functions.
7644 (bidi_initialize): Initialize the bidi cache start stack pointer.
7645 (bidi_cache_ensure_space): New function, refactored from part of
7646 bidi_cache_iterator_state. Don't assume the required size is just
7647 one BIDI_CACHE_CHUNK away.
7648 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7649 (bidi_count_bytes, bidi_char_at_pos): New functions.
7650 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7651 always valid if bidi_cache_idx is valid.
7652 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7653 is valid if it's going to be used.
7654 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7655 (bidi_cache_fetch_state, bidi_cache_search)
7656 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7657 (bidi_cache_iterator_state, bidi_cache_find)
7658 (bidi_find_other_level_edge, bidi_cache_start_stack):
7659 All variables related to cache indices are now EMACS_INT.
7661 * dispextern.h (struct bidi_string_data): New structure.
7662 (struct bidi_it): New member `string'. Make flag members be 1-bit
7663 fields, and put them last in the struct.
7664 (compute_display_string_pos, compute_display_string_end):
7666 (bidi_push_it, bidi_pop_it): Add prototypes.
7667 (struct iterator_stack_entry): New members bidi_p,
7668 paragraph_embedding, and from_disp_prop_p.
7669 (struct it): Member bidi_p is now a bit field 1 bit wide.
7670 (bidi_shelve_cache, bidi_unshelve_cache):
7673 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7674 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7675 and vector-like objects.
7677 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7678 cache around display iteration.
7680 * window.c (Fwindow_end, window_scroll_pixel_based)
7681 (displayed_window_lines, Frecenter): Save and restore the bidi
7682 cache around display iteration.
7684 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7686 * editfns.c (Fdelete_region): Clarify the use of the named
7687 parameters (bug#6788).
7689 2011-07-14 Martin Rudalics <rudalics@gmx.at>
7691 * indent.c (Fvertical_motion): Set and restore w->pointm when
7692 saving and restoring the window's buffer (Bug#9006).
7694 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7696 * editfns.c (Fstring_to_char): Clarify just what is returned
7697 (bug#6576). Text by Eli Zaretskii.
7699 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
7701 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7703 2011-07-13 Eli Zaretskii <eliz@gnu.org>
7705 * buffer.c (mmap_find): Fix a typo.
7707 2011-07-13 Johan Bockgård <bojohan@gnu.org>
7709 Fix execution of x selection hooks.
7710 * xselect.c (Qx_lost_selection_functions)
7711 (Qx_sent_selection_functions): New vars.
7712 (syms_of_xselect): DEFSYM them.
7713 (x_handle_selection_request): Pass Qx_sent_selection_functions
7714 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7715 (x_handle_selection_clear,x_clear_frame_selections):
7716 Pass Qx_lost_selection_functions rather than
7717 Vx_lost_selection_functions to Frun_hook_with_args.
7719 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7721 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
7722 The old code sometimes used this field without initializing it.
7724 * alloc.c (gc_sweep): Don't read past end of array.
7725 In theory, the old code could also have corrupted Emacs internals,
7726 though it'd be very unlikely.
7728 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7730 * character.c (Fcharacterp): Don't advertise optional ignored
7731 argument. (Bug#4026)
7733 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7735 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7738 * window.c (Fset_window_start): Doc fix (bug#4199).
7739 (Fset_window_hscroll): Ditto.
7741 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7743 Fix minor new problems caught by GCC 4.6.1.
7744 * term.c (init_tty): Remove unused local.
7745 * xsettings.c (store_monospaced_changed): Define this function only
7746 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
7749 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
7751 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7753 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7755 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7756 are the mini-buffer and the echo area (bug#3320).
7758 * term.c (init_tty): Remove support for supdup, c10 and perq
7759 terminals, which are no longer supported (bug#1482).
7761 2011-07-10 Johan Bockgård <bojohan@gnu.org>
7763 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7765 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7767 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7768 for non-popups (Bug#3642).
7770 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7772 * alloc.c (reset_malloc_hooks): Protoize.
7773 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
7774 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7775 * cm.c (losecursor): Likewise.
7776 * data.c (fmod): Likewise.
7777 * dispnew.c (swap_glyphs_in_rows): Likewise.
7778 * emacs.c (memory_warning_signal): Likewise.
7779 * floatfns.c (float_error): Likewise.
7780 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7781 (otf_open, font_otf_capability, generate_otf_features)
7782 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7784 * image.c (pbm_read_file): Likewise.
7785 * indent.c (string_display_width): Likewise.
7786 * intervals.c (check_for_interval, search_for_interval)
7787 (inc_interval_count, count_intervals, root_interval)
7788 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7789 * lread.c (defalias): Likewise.
7790 * ralloc.c (r_alloc_check): Likewise.
7791 * regex.c (set_image_of_range_1, set_image_of_range)
7792 (regex_grow_registers): Likewise.
7793 * sysdep.c (strerror): Likewise.
7794 * termcap.c (valid_filename_p, tprint, main): Likewise.
7795 * tparam.c (main): Likewise.
7796 * unexhp9k800.c (run_time_remap, save_data_space)
7797 (update_file_ptrs, read_header, write_header, calculate_checksum)
7798 (copy_file, copy_rest, display_header): Likewise.
7799 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7801 * xdisp.c (check_it): Likewise.
7802 * xfaces.c (register_color, unregister_color, unregister_colors):
7804 * xfns.c (print_fontset_result): Likewise.
7805 * xrdb.c (member, fatal, main): Likewise.
7807 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7809 Fix minor problems found by static checking (Bug#9031).
7810 * chartab.c (char_table_set_range, map_sub_char_table):
7811 Remove unused locals.
7812 (uniprop_table): Now static.
7813 * composite.c (_work_char): Remove unused static var.
7815 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
7817 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7819 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7821 * gtkutil.c (qttip_cb): Remove code without function.
7823 2011-07-09 Eli Zaretskii <eliz@gnu.org>
7825 * w32.c (pthread_sigmask): New stub.
7827 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
7829 Use pthread_sigmask, not sigprocmask (Bug#9010).
7830 sigprocmask is portable only for single-threaded applications, and
7831 Emacs can be multi-threaded when it uses GTK.
7832 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7834 * callproc.c (Fcall_process):
7835 * process.c (create_process):
7836 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7837 Use pthread_sigmask, not sigprocmask.
7839 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7841 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7842 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7845 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7847 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7848 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7849 (xg_hide_tooltip): Fix comment.
7851 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7852 in registerServicesMenuSendTypes.
7853 (validRequestorForSendType): Don't check ns_return_types.
7855 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7858 2011-07-08 Jason Rumney <jasonr@gnu.org>
7860 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7861 SH_SHOW for hidden windows (Bug#5482).
7863 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7864 frame struct members of non-existent frames (Bug#6284).
7866 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7868 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7869 variable firstTime not needed on OSX >= 10.6.
7870 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7871 >= 10.5. Use setKnobProportion, setDoubleValue.
7873 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7874 (MAC_OS_X_VERSION_10_5): Define if not defined.
7875 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7876 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7877 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7879 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7880 cString and lossyCString on OSX >= 10.4.
7882 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
7883 sizeToFit on OSX >= 10.2.
7885 * nsimage.m (allocInitFromFile): Don't use deprecated method
7886 bestRepresentationForDevice on OSX >= 10.6.
7888 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7891 * emacs.c: Declare unexec_init_emacs_zone.
7893 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7895 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7897 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7898 on svcsMenu (Bug#8842).
7900 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7902 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7904 * nsterm.m (QUTF8_STRING): Declare.
7905 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7906 (validRequestorForSendType): Return type is (id).
7907 Change indexOfObjectIdenticalTo to indexOfObject.
7908 Check if we have local selection before returning self (Bug#8842).
7909 (writeSelectionToPasteboard): Put local selection into paste board
7910 if we have a local selection (Bug#8842).
7911 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7913 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7914 (ns_get_local_selection): Declare.
7916 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7918 * keymap.c (describe_map_tree): Don't insert a double newline at
7919 the end of the buffer (bug#1169) and return whether we inserted
7922 * callint.c (Fcall_interactively): Change "reading args" to
7923 "providing args" to try to clarify what it does (bug#1010).
7925 2011-07-07 Kenichi Handa <handa@m17n.org>
7927 * composite.c (composition_compute_stop_pos): Ignore a static
7928 composition starting before CHARPOS (Bug#8915).
7930 * xdisp.c (handle_composition_prop): Likewise.
7932 2011-07-07 Eli Zaretskii <eliz@gnu.org>
7934 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7937 2011-07-07 Kenichi Handa <handa@m17n.org>
7939 * character.h (unicode_category_t): New enum type.
7941 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7942 (Qchar_code_property_table): New variable.
7943 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7944 (UNIPROP_COMPRESSED_FORM_P): New macros.
7945 (char_table_ascii): Uncompress the compressed values.
7946 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7947 Uncompress the compressed values.
7948 (sub_char_table_ref_and_range): Likewise.
7949 (char_table_ref_and_range): Uncompress the compressed values.
7950 (sub_char_table_set): New arg is_uniprop. Callers changed.
7951 Uncompress the compressed values.
7952 (sub_char_table_set_range): Args changed. Callers changed.
7953 (char_table_set_range): Adjuted for the above change.
7954 (map_sub_char_table): Delete args default_val and parent. Add arg
7955 top. Give decoded values to a Lisp function.
7956 (map_char_table): Adjust for the above change. Give decoded
7957 values to a Lisp function. Gcpro more variables.
7958 (uniprop_table_uncompress)
7959 (uniprop_decode_value_run_length): New functions.
7960 (uniprop_decoder, uniprop_decoder_count): New variables.
7961 (uniprop_get_decoder, uniprop_encode_value_character)
7962 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7964 (uniprop_encoder, uniprop_encoder_count): New variables.
7965 (uniprop_get_encoder, uniprop_table)
7966 (Funicode_property_table_internal, Fget_unicode_property_internal)
7967 (Fput_unicode_property_internal): New functions.
7968 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7969 Sunicode_property_table_internal, Sget_unicode_property_internal,
7970 and Sput_unicode_property_internal. Defvar_lisp
7971 char-code-property-alist.
7973 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
7974 Vunicode_category_table.
7976 * font.c (font_range): Adjust for the change of
7977 Vunicode_category_table.
7979 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7981 * m/iris4d.h: Remove file, move contents ...
7982 * s/irix6-5.h: ... here.
7984 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7986 Remove unportable assumption about struct layout (Bug#8884).
7987 * alloc.c (mark_buffer):
7988 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7989 (clone_per_buffer_values): Don't assume that
7990 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7991 This isn't true in general, and it's particularly not true
7992 if Emacs is configured with --with-wide-int.
7993 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7994 New macros, used in the buffer.c change.
7996 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7998 * xsettings.c: Use both GConf and GSettings if both are available.
7999 (store_config_changed_event): Add comment.
8000 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8001 (store_tool_bar_style_changed): New functions.
8002 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
8003 (struct xsettings): Move font inside HAVE_XFT.
8004 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
8005 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
8006 Move inside HAVE_XFT.
8007 (something_changed_gsettingsCB): Rename from something_changedCB.
8008 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8010 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
8011 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
8012 (something_changed_gconfCB): Rename from something_changedCB.
8013 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8014 (parse_settings): Move check for font inside HAVE_XFT.
8015 (read_settings, apply_xft_settings): Add comment.
8016 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8017 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8018 call store_font_name_changed.
8019 (xft_settings_event): Add comment.
8020 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8021 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8022 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8023 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8024 (xsettings_initialize): Call init_gsettings last.
8025 (xsettings_get_system_font, xsettings_get_system_normal_font):
8028 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8030 Random fixes. E.g., (random) never returned negative values.
8031 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8032 subseconds part to the entropy, as that's a bit more random.
8033 Prefer signed to unsigned, since the signedness doesn't matter and
8034 in general we prefer signed. When given a limit, use a
8035 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8036 latter isn't right if USE_2_TAGS_FOR_INTS.
8037 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8038 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8040 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8042 * textprop.c (text_property_stickiness):
8043 Obey Vtext_property_default_nonsticky.
8044 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8045 * w32fns.c (syms_of_w32fns):
8046 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8048 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8050 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8051 This is more efficient than Ffile_directory_p and avoids a minor race.
8053 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8055 * buffer.c (Foverlay_put): Say what the return value is
8058 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8059 is a directory before asking whether to use the file name
8061 (barf_or_query_if_file_exists): Make the "File is a directory"
8062 error be more correct.
8064 * fns.c (Frequire): Remove the mention of the .gz files, since
8065 that's installation-specific, but keep the mention of
8066 `get-load-suffixes'.
8068 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8070 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8071 Report string overflow if the output is too long.
8073 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
8075 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8076 (syms_of_gnutls): Remove duplicate DEFSYM for
8077 Qgnutls_bootprop_verify_hostname_error, an error for
8078 Qgnutls_bootprop_verify_error (which is no longer used).
8080 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8081 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8082 Also (re)move comments that are misplaced or no longer relevant.
8084 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8086 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8088 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
8090 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8091 and background color parameters if they have been changed.
8093 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8095 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8097 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8099 * xsettings.c (SYSTEM_FONT): Define only when used.
8100 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8102 * keymap.c (access_keymap_1): Now static.
8104 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
8106 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8107 leave any prefix arg for the up event (Bug#1586).
8109 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8111 * lread.c (syms_of_lread): Mention single symbols defined by
8112 `defvar' or `defconst' (bug#7154).
8114 * fns.c (Frequire): Mention .el.gz files (bug#7314).
8115 (Frequire): Mention get-load-suffixes.
8117 2011-07-02 Martin Rudalics <rudalics@gmx.at>
8119 * window.h (window): Remove clone_number slot.
8120 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8122 (make_parent_window, make_window, saved_window)
8123 (Fset_window_configuration, save_window_save): Don't deal with
8125 * buffer.c (Qclone_number): Remove declaration.
8126 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8128 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8130 Add multiple inheritance to keymaps.
8131 * keymap.c (Fmake_composed_keymap): New function.
8132 (Fset_keymap_parent): Simplify.
8133 (fix_submap_inheritance): Remove.
8134 (access_keymap_1): New function extracted from access_keymap to handle
8135 embedded parents and handle lists of maps.
8136 (access_keymap): Use it.
8137 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8138 (Fcopy_keymap): Handle embedded parents.
8139 (Fcommand_remapping, define_as_prefix): Simplify.
8140 (Fkey_binding): Simplify.
8141 (syms_of_keymap): Move minibuffer-local-completion-map,
8142 minibuffer-local-filename-completion-map,
8143 minibuffer-local-must-match-map, and
8144 minibuffer-local-filename-must-match-map to Elisp.
8145 (syms_of_keymap): Defsubr make-composed-keymap.
8146 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8147 (parse_menu_item): Trivial simplification.
8149 2011-07-01 Glenn Morris <rgm@gnu.org>
8151 * Makefile.in (SETTINGS_LIBS): Fix typo.
8153 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8155 * coding.c (Fencode_coding_string): Record the last coding system
8156 used, as the function doc string says (bug#8738).
8158 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8160 * xsettings.c (store_monospaced_changed): Take new font as arg and
8161 check for change against current_mono_font.
8162 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8163 (emacs_settings_constructor, emacs_settings_get_property)
8164 (emacs_settings_set_property, emacs_settings_class_init)
8165 (emacs_settings_init, gsettings_obj): Remove.
8166 (something_changedCB): New function for HAVE_GSETTINGS.
8167 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8168 with value as argument.
8169 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8170 g_settings_new (Bug#8967). Do not create gsettings_obj.
8171 Remove calls to g_settings_bind. Connect something_changedCB to
8174 * xgselect.c: Add defined (HAVE_GSETTINGS).
8175 (xgselect_initialize): Ditto.
8177 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8178 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8181 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8183 * eval.c (struct backtrace): Simplify and port the data structure.
8184 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8185 signed bit field, as this assumption is not portable and it makes
8186 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8187 "char debug_on_exit : 1" as this is not portable either; instead,
8188 use the portable "unsigned int debug_on_exit : 1". Remove unused
8189 member evalargs. Remove obsolete comments about cc bombing out.
8191 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8193 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
8194 Let HAVE_GSETTINGS override HAVE_GCONF.
8195 (store_monospaced_changed): New function.
8196 (EMACS_SETTINGS): A new type derived from GObject to handle
8197 GSettings notifications.
8198 (emacs_settings_constructor, emacs_settings_get_property)
8199 (emacs_settings_set_property, emacs_settings_class_init):
8201 (gsettings_client, gsettings_obj): New variables.
8202 (GSETTINGS_SCHEMA): New define.
8203 (something_changedCB): Call store_monospaced_changed.
8204 (init_gsettings): New function.
8205 (xsettings_initialize): Call init_gsettings.
8206 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8209 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
8212 2011-06-29 Martin Rudalics <rudalics@gmx.at>
8214 * window.c (resize_root_window, grow_mini_window)
8215 (shrink_mini_window): Rename Qresize_root_window to
8216 Qwindow_resize_root_window and Qresize_root_window_vertically to
8217 Qwindow_resize_root_window_vertically.
8219 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8221 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8223 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
8225 * makefile.w32-in: Redesign dependencies so they reflect more
8226 clearly which files are directly included by each source file,
8227 and not through other includes.
8229 2011-06-27 Martin Rudalics <rudalics@gmx.at>
8231 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8232 (sort_overlays, overlay_strings): When an overlay's clone number
8233 matches the window's clone number process the overlay even if
8234 the overlay's window property doesn't match the current window.
8236 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8237 (Fwindow_hchild): Rename to Fwindow_left_child.
8238 (Fwindow_next): Rename to Fwindow_next_sibling.
8239 (Fwindow_prev): Rename to Fwindow_prev_sibling.
8240 (resize_window_check): Rename to window_resize_check.
8241 (resize_window_apply): Rename to window_resize_apply.
8242 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8243 (Fdelete_other_windows_internal, resize_frame_windows)
8244 (Fsplit_window_internal, Fdelete_window_internal)
8245 (grow_mini_window, shrink_mini_window)
8246 (Fresize_mini_window_internal): Fix callers accordingly.
8248 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8250 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8251 (emacs_fixed_set_min_size): Remove.
8252 (emacs_fixed_new): Take frame as argument.
8254 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8255 (_EmacsFixedPrivate): Remove minwidth/height.
8256 Add struct frame *f.
8257 (emacs_fixed_init): Initialize priv->f.
8258 (get_parent_class, emacs_fixed_set_min_size): Remove.
8259 (emacs_fixed_new): Set priv->f to argument.
8260 (emacs_fixed_get_preferred_width)
8261 (emacs_fixed_get_preferred_height): Use min_width/height from
8262 frames size_hint to set minimum and natural (Bug#8919).
8263 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8264 and use min_width/height from frames size_hint to set
8265 min_width/height (Bug#8919).
8267 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
8268 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8271 2011-06-26 Eli Zaretskii <eliz@gnu.org>
8273 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8274 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8277 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
8279 * process.c (wait_reading_process_output): Bypass select if
8280 waiting for a cell while ignoring keyboard input, and input is
8281 pending. Suggested by Jan Djärv (Bug#8869).
8283 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8285 Use gnulib's dup2 module instead of rolling our own.
8286 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8288 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8290 * dispnew.c (scrolling_window): Before scrolling, turn off a
8291 mouse-highlight in the window being scrolled.
8293 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
8295 Move DEFSYM to lisp.h and use everywhere.
8297 * character.h (DEFSYM): Move declaration...
8298 * lisp.h (DEFSYM): ...here.
8304 * w32select.c: Don't include character.h.
8306 * alloc.c (syms_of_alloc):
8307 * buffer.c (syms_of_buffer):
8308 * bytecode.c (syms_of_bytecode):
8309 * callint.c (syms_of_callint):
8310 * casefiddle.c (syms_of_casefiddle):
8311 * casetab.c (init_casetab_once):
8312 * category.c (init_category_once, syms_of_category):
8313 * ccl.c (syms_of_ccl):
8314 * cmds.c (syms_of_cmds):
8315 * composite.c (syms_of_composite):
8316 * dbusbind.c (syms_of_dbusbind):
8317 * dired.c (syms_of_dired):
8318 * dispnew.c (syms_of_display):
8319 * doc.c (syms_of_doc):
8320 * editfns.c (syms_of_editfns):
8321 * emacs.c (syms_of_emacs):
8322 * eval.c (syms_of_eval):
8323 * fileio.c (syms_of_fileio):
8324 * fns.c (syms_of_fns):
8325 * frame.c (syms_of_frame):
8326 * fringe.c (syms_of_fringe):
8327 * insdel.c (syms_of_insdel):
8328 * keymap.c (syms_of_keymap):
8329 * lread.c (init_obarray, syms_of_lread):
8330 * macros.c (syms_of_macros):
8331 * msdos.c (syms_of_msdos):
8332 * print.c (syms_of_print):
8333 * process.c (syms_of_process):
8334 * search.c (syms_of_search):
8335 * sound.c (syms_of_sound):
8336 * syntax.c (init_syntax_once, syms_of_syntax):
8337 * terminal.c (syms_of_terminal):
8338 * textprop.c (syms_of_textprop):
8339 * undo.c (syms_of_undo):
8340 * w32.c (globals_of_w32):
8341 * window.c (syms_of_window):
8342 * xdisp.c (syms_of_xdisp):
8343 * xfaces.c (syms_of_xfaces):
8344 * xfns.c (syms_of_xfns):
8345 * xmenu.c (syms_of_xmenu):
8346 * xsettings.c (syms_of_xsettings):
8347 * xterm.c (syms_of_xterm): Use DEFSYM.
8349 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8351 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
8353 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8355 Integer and buffer overflow fixes (Bug#8873).
8357 * print.c (printchar, strout): Check for string overflow.
8358 (PRINTPREPARE, printchar, strout):
8359 Don't set size unless allocation succeeds.
8361 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8362 for sizes. Check for string overflow more accurately.
8363 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8365 * macros.c: Integer and buffer overflow fixes.
8366 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8367 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8368 Use ptrdiff_t, not int, for sizes.
8369 Don't increment bufsize until after realloc succeeds.
8370 Check for size-calculation overflow.
8371 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8373 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8375 * lread.c: Integer overflow fixes.
8376 (read_integer): Radix is now EMACS_INT, not int,
8377 to improve quality of diagnostics for out-of-range radices.
8378 Calculate buffer size correctly for out-of-range radices.
8379 (read1): Check for integer overflow in radices, and in
8380 read-circle numbers.
8381 (read_escape): Avoid int overflow.
8382 (Fload, openp, read_buffer_size, read1)
8383 (substitute_object_recurse, read_vector, read_list, map_obarray):
8384 Use ptrdiff_t, not int, for sizes.
8385 (read1): Use EMACS_INT, not int, for sizes.
8386 Check for size overflow.
8388 * image.c (cache_image): Check for size arithmetic overflow.
8390 * lread.c: Integer overflow issues.
8391 (saved_doc_string_size, saved_doc_string_length)
8392 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8393 Now ptrdiff_t, not int.
8394 (read1): Don't assume doc string length fits in int. Check for
8395 out-of-range doc string lengths.
8396 (read_list): Don't assume file position fits in int.
8397 (read_escape): Check for hex character overflow.
8399 2011-06-22 Leo Liu <sdl.web@gmail.com>
8401 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8402 Move to minibuffer.el.
8404 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8406 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
8407 The following patches are for when GLYPH_DEBUG && !XASSERT.
8408 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8409 * dispnew.c (flush_stdout):
8410 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8411 Mark as externally visible.
8412 * dispnew.c (check_window_matrix_pointers): Now static.
8413 * dispnew.c (window_to_frame_vpos):
8414 * xfns.c (unwind_create_frame):
8415 * xterm.c (x_check_font): Remove unused local.
8416 * scroll.c (CHECK_BOUNDS):
8417 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8418 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8419 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8420 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8421 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8423 (debug_method_add): Use va_list and vsprintf rather than relying
8424 on undefined behavior with wrong number of arguments.
8425 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8426 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8427 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8428 since we're not interested in debugging glyphs with old libraries.
8429 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8430 GCC 4.6.0's static checking.
8432 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8434 Integer overflow and signedness fixes (Bug#8873).
8435 A few related buffer overrun fixes, too.
8437 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8439 * dispextern.h (struct face.stipple):
8440 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8441 (x_bitmap_mask, x_allocate_bitmap_record)
8442 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8443 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8444 (x_create_bitmap_from_xpm_data):
8445 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8446 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8448 * xfaces.c (load_pixmap):
8449 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8450 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8451 (.bitmaps_last, struct x_output.icon_bitmap):
8452 Use ptrdiff_t, not int, for bitmap indexes.
8453 (x_allocate_bitmap_record): Check for size overflow.
8454 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8456 Use ptrdiff_t, not int, for overlay counts.
8457 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8458 * editfns.c (overlays_around, get_pos_property):
8459 * textprop.c (get_char_property_and_overlay):
8460 * xdisp.c (next_overlay_change, note_mouse_highlight):
8461 * xfaces.c (face_at_buffer_position):
8462 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8463 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8464 (Fnext_overlay_change, Fprevious_overlay_change)
8465 (mouse_face_overlay_overlaps, Foverlays_in):
8466 Use ptrdiff_t, not int, for sizes.
8467 (overlays_at, overlays_in): Check for size-calculation overflow.
8469 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8471 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8472 (x_session_initialize): Do not assume string length fits in int.
8474 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8475 This is unlikely, but can occur if DPI is outlandish.
8477 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
8478 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8480 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8481 * xrdb.c (magic_file_p, search_magic_path):
8482 Omit last arg SUFFIX; it was always 0. All callers changed.
8483 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8485 * xfont.c (xfont_match): Avoid need for strlen.
8487 * xfns.c: Don't assume strlen fits in int.
8488 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8490 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8491 not unsigned long, as we prefer signed integers. All callers changed.
8492 Detect integer overflow in repeat count.
8493 (message_dolog): Don't assume print length fits in 39 bytes.
8494 (display_mode_element): Don't assume strlen fits in int.
8496 * termcap.c: Don't assume sizes fit in int and never overflow.
8497 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8498 (gobble_line): Check for size-calculation overflow.
8500 * minibuf.c (Fread_buffer):
8501 * lread.c (intern, intern_c_string):
8502 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8503 Don't assume string length fits in int.
8505 * keyboard.c (parse_tool_bar_item):
8506 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8508 * font.c: Don't assume string length fits in int.
8509 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8510 Use ptrdiff_t, not int.
8511 (font_intern_prop): Don't assume string length fits in int.
8512 Don't assume integer property fits in fixnum.
8513 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
8515 * filelock.c: Fix some buffer overrun and integer overflow issues.
8516 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
8517 Reformulate so as not to need the command string.
8518 Invoke gzip -cd rather than gunzip, as it's more portable.
8519 (lock_info_type, lock_file_1, lock_file):
8520 Don't assume pid_t and time_t fit in unsigned long.
8521 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8522 (current_lock_owner): Prefer signed type for sizes.
8523 Use memcpy, not strncpy, where memcpy is what is really wanted.
8524 Don't assume (via atoi) that time_t and pid_t fit in int.
8525 Check for time_t and/or pid_t out of range, e.g., via a network share.
8526 Don't alloca where an auto var works fine.
8528 * fileio.c: Fix some integer overflow issues.
8529 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8530 Don't assume string length fits in int.
8531 (directory_file_name): Don't assume string length fits in long.
8532 (make_temp_name): Don't assume pid fits in int, or that its print
8533 length is less than 20.
8535 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8537 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8539 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8541 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8542 We prefer signed integers, even for size calculations.
8544 * emacs.c: Don't assume string length fits in 'int'.
8545 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8546 (main): Don't invoke strlen when not needed.
8548 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8549 (XD_DEBUG_MESSAGE): Don't waste a byte.
8551 * callproc.c (getenv_internal_1, getenv_internal)
8553 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8555 * lread.c (invalid_syntax): Omit length argument.
8556 All uses changed. This doesn't fix a bug, but it simplifies the
8557 code away from its former Hollerith-constant appearance, and it's
8558 one less 'int' to worry about when looking at integer-overflow issues.
8559 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
8561 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8562 This didn't break anything, but it didn't help either.
8563 It's confusing to put a bogus integer in a place where the actual
8564 value does not matter.
8565 (LIST_END_P): Remove unused macro and its bogus comment.
8566 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
8568 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8569 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8571 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8572 We prefer signed types, and the value cannot exceed the EMACS_INT
8573 range anyway (because otherwise the length would not be representable).
8574 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8575 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8576 This avoids a GCC warning when WIDE_EMACS_INT.
8578 * indent.c (sane_tab_width): New function.
8579 (current_column, scan_for_column, Findent_to, position_indentation)
8580 (compute_motion): Use it. This is just for clarity.
8581 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
8583 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
8585 * lisp.h (lint_assume): New macro.
8586 * composite.c (composition_gstring_put_cache):
8587 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8589 * editfns.c, insdel.c:
8590 Omit unnecessary forward decls, to simplify future changes.
8592 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8594 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8596 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
8597 Use much-faster test for byte-length change.
8598 Don't assume string byte-length fits in 'int'.
8599 Check that character arg fits in 'int'.
8600 (mapcar1): Declare byte as byte, for clarity.
8602 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8604 * fns.c (concat): Catch string overflow earlier.
8605 Do not rely on integer wraparound.
8607 * dispextern.h (struct it.overlay_strings_charpos)
8608 (struct it.selective): Now EMACS_INT, not int.
8609 * xdisp.c (forward_to_next_line_start)
8610 (back_to_previous_visible_line_start)
8611 (reseat_at_next_visible_line_start, next_element_from_buffer):
8612 Don't arbitrarily truncate the value of 'selective' to int.
8614 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8616 * composite.c: Don't truncate sizes to 'int'.
8617 (composition_gstring_p, composition_reseat_it)
8618 (composition_adjust_point): Use EMACS_INT, not int.
8619 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8620 not EMACS_UINT, for indexes.
8622 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8624 * buffer.c: Include <verify.h>.
8625 (struct sortvec.priority, struct sortstr.priority):
8626 Now EMACS_INT, not int.
8627 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
8628 (struct sortstr.size, record_overlay_string)
8629 (struct sortstrlist.size, struct sortlist.used):
8630 Don't truncate size to int.
8631 (record_overlay_string): Check for size-calculation overflow.
8632 (init_buffer_once): Check at compile-time, not run-time.
8634 2011-06-22 Jim Meyering <meyering@redhat.com>
8636 Don't leak an XBM-image-sized buffer
8637 * image.c (xbm_load): Free the image buffer after using it.
8639 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8642 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8643 that Sun C diagnosed.
8644 * fns.c (secure_hash): Fix pointer signedness issue.
8645 * intervals.c (static_offset_intervals): New function.
8646 (offset_intervals): Use it.
8648 2011-06-21 Leo Liu <sdl.web@gmail.com>
8651 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8654 * fns.c (secure_hash): Rename from crypto_hash_function and change
8655 the first arg to accept symbols.
8656 (Fsecure_hash): New primitive.
8657 (syms_of_fns): New symbols.
8659 2011-06-20 Deniz Dogan <deniz@dogan.se>
8661 * process.c (Fset_process_buffer): Clarify return value in
8664 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
8666 * dispnew.c (add_window_display_history): Use BVAR.
8668 * xdisp.c (debug_method_add): Use BVAR.
8669 (check_window_end, dump_glyph_matrix, dump_glyph)
8670 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8672 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8675 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8676 check till after the cache is created in init_frame_faces.
8678 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8680 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8682 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8684 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8685 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8686 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8688 Improve buffer-overflow checking (Bug#8873).
8689 * fileio.c (Finsert_file_contents):
8690 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8691 Remove the old (too-loose) buffer overflow checks.
8692 They weren't needed, since make_gap checks for buffer overflow.
8693 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8694 The old code merely checked for Emacs fixnum overflow, and relied
8695 on undefined (wraparound) behavior. The new code avoids undefined
8696 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8698 * editfns.c (Finsert_char): Don't dump core with very negative counts.
8699 Tune. Don't use wider integers than needed. Don't use alloca.
8700 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
8702 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8704 * insdel.c, lisp.h (buffer_overflow): New function.
8705 (insert_from_buffer_1, replace_range, replace_range_2):
8706 * insdel.c (make_gap_larger):
8707 * editfns.c (Finsert_char):
8708 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8710 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8712 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8714 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
8716 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8717 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8719 * fileio.c: Don't assume EMACS_INT fits in off_t.
8720 (emacs_lseek): New static function.
8721 (Finsert_file_contents, Fwrite_region): Use it.
8722 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8724 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8726 * fns.c: Don't overflow int when computing a list length.
8727 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8728 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8729 truncation on 64-bit hosts. Check for QUIT every
8730 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8731 faster and is responsive enough.
8732 (Flength): Report an error instead of overflowing an integer.
8733 (Fsafe_length): Return a float if the value is not representable
8734 as a fixnum. This shouldn't happen except in contrived situations.
8735 (Fnthcdr, Fsort): Don't assume list length fits in int.
8736 (Fcopy_sequence): Don't assume vector length fits in int.
8738 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8739 (header_size, word_size): New constants.
8740 (allocate_vectorlike): Don't check size overflow here.
8741 (allocate_vector): Check it here instead, since this is the only
8742 caller of allocate_vectorlike that could cause overflow.
8743 Check that the new vector's length is representable as a fixnum.
8745 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8746 The previous code was bogus. For example, next_almost_prime (32)
8747 returned 39, which is undesirable as it is a multiple of 3; and
8748 next_almost_prime (24) returned 25, which is a multiple of 5 so
8749 why was the code bothering to check for multiples of 7?
8751 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8753 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8755 Variadic C functions now count arguments with ptrdiff_t.
8756 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8757 Back then I didn't know that the Emacs coding style prefers signed int.
8758 Also, in the meantime I found a few more instances where arguments
8759 were being counted with int, which may truncate counts on 64-bit
8760 machines, or EMACS_INT, which may be unnecessarily wide.
8761 * lisp.h (struct Lisp_Subr.function.aMANY)
8762 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8763 Arg counts are now ptrdiff_t, not size_t.
8764 All variadic functions and their callers changed accordingly.
8765 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8766 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8767 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8768 * callint.c (Fcall_interactively): Check arg count for overflow,
8769 to avoid potential buffer overrun. Use signed char, not 'int',
8770 for 'varies' array, so that we needn't bother to check its size
8771 calculation for overflow.
8772 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8773 * eval.c (apply_lambda):
8774 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8775 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8776 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8778 * callint.c (Fcall_interactively): Don't use index var as event count.
8780 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8781 * mem-limits.h (SIZE): Remove; no longer used.
8783 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
8785 Remove unnecessary casts.
8786 * xterm.c (x_term_init):
8787 * xfns.c (x_set_border_pixel):
8788 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8789 These aren't needed now that we assume ANSI C.
8791 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8792 It's more likely to cause problems (due to unsigned overflow)
8795 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8797 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8799 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8801 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8803 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8805 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8807 GLYPH_CODE_FACE returns EMACS_INT, not int.
8808 * dispextern.h (merge_faces):
8809 * xfaces.c (merge_faces):
8810 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8811 Don't assume EMACS_INT fits in int.
8813 * character.h (CHAR_VALID_P): Remove unused parameter.
8814 * fontset.c, lisp.h, xdisp.c: All uses changed.
8816 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8818 * fns.c (concat): Minor tuning based on overflow analysis.
8819 This doesn't fix any bugs. Use int to hold character, instead
8820 of constantly refetching from Emacs object. Use XFASTINT, not
8821 XINT, for value known to be a character. Don't bother comparing
8822 a single byte to 0400, as it's always less.
8824 * floatfns.c (Fexpt):
8825 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8827 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8830 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8832 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8833 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8834 incorrectly succeed when S was a string, because 4294967386 was
8835 truncated before it was used.
8837 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8838 Otherwise, an out-of-range integer could cause undefined behavior
8841 * composite.c: Use int, not EMACS_INT, for characters.
8842 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8843 EMACS_INT, for values that are known to be in character range.
8844 This doesn't fix any bugs but is the usual style inside Emacs and
8845 may generate better code on 32-bit machines.
8847 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8848 This is for reasons similar to the recent CHAR_STRING fix.
8849 * charset.c (Fencode_char): Check that character arg is actually
8850 a character. Pass an int to ENCODE_CHAR.
8851 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8852 wider than 'int', as a compile-time check to prevent future regressions
8855 * character.c (char_string): Remove unnecessary casts.
8857 Make sure a 64-bit char is never passed to CHAR_STRING.
8858 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8859 by silently ignoring the top 32 bits, allowing some values
8860 that were far too large to be valid characters.
8861 * character.h: Include <verify.h>.
8862 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8863 arguments are no wider than unsigned, as a compile-time check
8864 to prevent future regressions in this area.
8866 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
8867 (Fsubst_char_in_region):
8869 * xdisp.c (decode_mode_spec_coding):
8870 Adjust to CHAR_STRING's new requirement.
8871 * editfns.c (Finsert_char, Fsubst_char_in_region):
8872 * fns.c (concat): Check that character args are actually
8873 characters. Without this test, these functions did the wrong
8874 thing with wildly out-of-range values on 64-bit hosts.
8876 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8877 These casts should not be needed on 32-bit hosts, either.
8878 * keyboard.c (read_char):
8879 * lread.c (Fload): Remove casts to unsigned.
8881 * lisp.h (UNSIGNED_CMP): New macro.
8882 This fixes comparison bugs on 64-bit hosts.
8883 (ASCII_CHAR_P): Use it.
8884 * casefiddle.c (casify_object):
8885 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
8886 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8887 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8888 * dispextern.h (FACE_FROM_ID):
8889 * keyboard.c (read_char): Use UNSIGNED_CMP.
8891 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8892 not to EMACS_INT, to avoid GCC warning.
8894 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8896 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8897 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8898 isn't needed on 32-bit machines.
8900 * buffer.c (Fgenerate_new_buffer_name):
8901 Use EMACS_INT for count, not int.
8902 (advance_to_char_boundary): Return EMACS_INT, not int.
8904 * data.c (Qcompiled_function): Now static.
8906 * window.c (window_body_lines): Now static.
8908 * image.c (gif_load): Rename local to avoid shadowing.
8910 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8911 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8912 * alloc.c (make_save_value): Integer argument is now of type
8914 (mark_object): Use ptrdiff_t, not int.
8915 * lisp.h (pD): New macro.
8916 * print.c (print_object): Use it.
8918 * alloc.c: Use EMACS_INT, not int, to count objects.
8919 (total_conses, total_markers, total_symbols, total_vector_size)
8920 (total_free_conses, total_free_markers, total_free_symbols)
8921 (total_free_floats, total_floats, total_free_intervals)
8922 (total_intervals, total_strings, total_free_strings):
8923 Now EMACS_INT, not int. All uses changed.
8924 (Fgarbage_collect): Compute overall total using a double, so that
8925 integer overflow is less likely to be a problem. Check for overflow
8926 when converting back to an integer.
8927 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8928 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8929 These were 'int' variables that could overflow on 64-bit hosts;
8930 they were never used, so remove them instead of repairing them.
8931 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
8932 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8933 Previously, this ceilinged at INT_MAX, but that doesn't work on
8935 (allocate_pseudovector): Don't use EMACS_INT when int would do.
8937 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
8938 (allocate_vectorlike): Check for ptrdiff_t overflow.
8939 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8940 when a (possibly-narrower) signed value would do just as well.
8941 We prefer using signed arithmetic, to avoid comparison confusion.
8943 * alloc.c: Catch some string size overflows that we were missing.
8944 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8945 for convenience in STRING_BYTES_MAX.
8946 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8947 The definition here is exact; the one in lisp.h was approximate.
8948 (allocate_string_data): Check for string overflow. This catches
8949 some instances we weren't catching before. Also, it catches
8950 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8951 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8952 and ptrdiff_t and EMACS_INT are both 64 bits.
8954 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8955 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
8956 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
8958 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8960 * alloc.c (Fmake_string): Check for out-of-range init.
8962 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8964 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8966 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8968 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8969 xg_get_default_scrollbar_width.
8971 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8972 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8973 (style_changed_cb): Call update_theme_scrollbar_width and call
8974 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8975 all frames (Bug#8505).
8976 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8977 Call gtk_window_set_resizable if HAVE_GTK3.
8978 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8979 and height if HAVE_GTK3 (Bug#8505).
8980 (scroll_bar_width_for_theme): New variable.
8981 (update_theme_scrollbar_width): New function.
8982 (xg_get_default_scrollbar_width): Move code to
8983 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8984 (xg_initialize): Call update_theme_scrollbar_width.
8986 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8988 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8990 2011-06-12 Martin Rudalics <rudalics@gmx.at>
8992 * frame.c (make_frame): Call other_buffer_safely instead of
8995 * window.c (temp_output_buffer_show): Call display_buffer with
8996 second argument Vtemp_buffer_show_specifiers and reset latter
8997 immediately after the call.
8998 (Vtemp_buffer_show_specifiers): New variable.
8999 (auto_window_vscroll_p, next_screen_context_lines)
9000 (Vscroll_preserve_screen_position): Remove leading asterisks from
9003 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
9005 Fix minor problems found by GCC 4.6.0 static checking.
9006 * buffer.c (Qclone_number): Remove for now, as it's unused.
9007 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9008 (record_buffer): Remove unused local.
9009 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9010 (set_frame_buffer_list): Remove; unused.
9011 * frame.h (other_visible_frames): Remove decl.
9012 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9013 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9014 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9016 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9017 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9018 Define only if HAVE_GPM.
9019 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9020 (update_hints_inhibit): Remove; never set. All uses removed.
9021 * widgetprv.h (emacsFrameClassRec): Remove decl.
9022 * window.c (delete_deletable_window): Now returns void, since it
9023 wasn't returning anything.
9024 (compare_window_configurations): Remove unused locals.
9025 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9026 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
9027 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9028 the same widths as pointers. This follows up on the 2011-05-06 patch.
9029 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9030 * xterm.h: Likewise.
9031 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9033 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
9035 * makefile.w32-in: Update dependencies.
9036 (LISP_H): Add lib/intprops.h.
9038 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9040 * image.c (gif_load): Add animation frame delay to the metadata.
9041 (syms_of_image): Use DEFSYM. New symbol `delay'.
9043 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9045 * window.c (delete_deletable_window): Re-add.
9046 (Fset_window_configuration): Rewrite to handle dead buffers and
9047 consequently deletable windows.
9048 (window_tree, Fwindow_tree): Remove. Supply functionality in
9050 (compare_window_configurations): Simplify code.
9052 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9054 * image.c (imagemagick_load_image): Fix type mismatch.
9055 (Fimagemagick_types): Likewise.
9057 * window.h (replace_buffer_in_windows): Declare.
9059 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9061 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9062 Qclone_number. Remove external declaration of Qdelete_window.
9063 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9065 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9066 Run Qbuffer_list_update_hook if allowed.
9067 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9068 buffer list implementation.
9069 (other_buffer_safely): New function.
9070 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9071 calls to replace_buffer_in_windows and
9072 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9074 (record_buffer): Inhibit quitting and rewrite using quittable
9075 functions. Run Qbuffer_list_update_hook if allowed.
9076 (Frecord_buffer, Funrecord_buffer): New functions.
9077 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9078 Move switch-to-buffer to window.el.
9079 (bury-buffer): Move to window.el.
9080 (Vbuffer_list_update_hook): New variable.
9082 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9085 * window.h (resize_frame_windows): Move up in code.
9086 (Fwindow_frame): Remove EXFUN.
9087 (replace_buffer_in_all_windows): Remove prototype.
9088 (replace_buffer_in_windows_safely): Add prototype.
9090 * window.c: Declare Qdelete_window static again. Move down
9091 declaration of select_count.
9092 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9093 (Fother_window): Move to window.el.
9094 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9095 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9096 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9098 (replace_buffer_in_windows): Implement by calling
9099 Qreplace_buffer_in_windows.
9100 (replace_buffer_in_all_windows): Remove with some functionality
9101 moved into replace_buffer_in_windows_safely.
9102 (replace_buffer_in_windows_safely): New function.
9103 (select_window_norecord, select_frame_norecord): Move in front
9104 of run_window_configuration_change_hook. Remove now obsolete
9106 (Fset_window_buffer): Rewrite doc-string.
9107 Call Qrecord_window_buffer.
9108 (keys_of_window): Move binding for other-window to window.el.
9110 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9112 * dispextern.h (struct image): Replace data member, whose int_val
9113 and ptr_val fields were not used by anything, with a single
9116 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9117 (gif_clear_image, gif_load, imagemagick_load_image)
9118 (gs_clear_image, gs_load): Callers changed.
9120 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9122 * buffer.h: Include <time.h>, for time_t.
9123 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9125 Fix minor problems found by static checking.
9127 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9129 Make identifiers static if they are not used in other modules.
9130 * data.c (Qcompiled_function, Qframe, Qvector):
9131 * image.c (QimageMagick, Qsvg):
9132 * minibuf.c (Qmetadata):
9133 * window.c (resize_window_check, resize_root_window): Now static.
9134 * window.h (resize_window_check, resize_root_window): Remove decls.
9136 * window.c (window_deletion_count, delete_deletable_window):
9138 (window_body_lines): Now static.
9139 (Fdelete_other_windows_internal): Mark vars as initialized.
9140 Make sure 'resize_failed' is initialized.
9141 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9142 (resize_window_apply): Remove unused local.
9143 * window.h (delete_deletable_window): Remove decl.
9145 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
9146 (imagemagick_load_image): Fix pointer signedness problem by changing
9147 last arg from unsigned char * to char *. All uses changed.
9148 Also, fix a local for similar reasons.
9149 Remove unused locals. Remove locals to avoid shadowing.
9150 (fn_rsvg_handle_free): Remove; unused.
9151 (svg_load, svg_load_image): Fix pointer signedness problem.
9152 (imagemagick_load_image): Don't use garbage pointer image_wand.
9154 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9156 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
9158 * image.c (gif_load): Fix omitted cast error introduced by
9161 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9163 * window.h (resize_proportionally, orig_total_lines)
9164 (orig_top_line): Remove from window structure.
9165 (set_window_height, set_window_width, change_window_heights)
9166 (Fdelete_window): Remove prototypes.
9167 (resize_frame_windows): Remove duplicate declaration.
9169 2011-06-10 Eli Zaretskii <eliz@gnu.org>
9171 * window.h (resize_frame_windows, resize_window_check)
9172 (delete_deletable_window, resize_root_window)
9173 (resize_frame_windows): Declare prototypes.
9175 * window.c (resize_window_apply): Make definition be "static" to
9176 match the prototype.
9178 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9180 * window.c: Remove declarations of Qwindow_size_fixed,
9181 window_min_size_1, window_min_size_2, window_min_size,
9182 size_window, window_fixed_size_p, enlarge_window, delete_window.
9183 Remove static from declaration of Qdelete_window, it's
9184 temporarily needed by Fbury_buffer.
9185 (replace_window): Don't assign orig_top_line and
9187 (Fdelete_window, delete_window): Remove. Window deletion is
9188 handled by window.el.
9189 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9190 Replace Fdelete_window calls with calls to Qdelete_window.
9191 (Fdelete_other_windows): Remove. Deleting other windows is
9192 handled by window.el.
9193 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9194 handled in window.el.
9195 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9196 Window minimum sizes are handled in window.el.
9197 (shrink_windows, size_window, set_window_height)
9198 (set_window_width, change_window_heights, window_height)
9199 (window_width, CURBEG, CURSIZE, enlarge_window)
9200 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9201 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9202 handled in window.el.
9203 (make_dummy_parent): Rename to make_parent_window and give it a
9204 second argument horflag.
9205 (make_window): Don't set resize_proportionally any more.
9206 (Fsplit_window): Remove. Windows are split in window.el.
9207 (save_restore_action, save_restore_orig_size)
9208 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9209 Resize mini windows in window.el.
9210 (grow_mini_window, shrink_mini_window): Implement by calling
9211 Qresize_root_window_vertically, resize_window_check and
9212 resize_window_apply.
9213 (saved_window, Fset_window_configuration, save_window_save):
9214 Do not handle orig_top_line, orig_total_lines, and
9215 resize_proportionally.
9216 (window_min_height, window_min_width): Move to window.el.
9217 (keys_of_window): Move bindings for delete-other-windows,
9218 split-window, delete-window and enlarge-window to window.el.
9220 * buffer.c: Temporarily extern Qdelete_window.
9221 (Fbury_buffer): Temporarily call Qdelete_window instead of
9222 Fdelete_window (Fbury_buffer will move to window.el soon).
9224 * frame.c (set_menu_bar_lines_1): Remove code handling
9225 orig_top_line and orig_total_lines.
9227 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9228 set_window_height but set heights directly.
9229 (change_frame_size_1): Use resize_frame_windows.
9231 * xdisp.c (init_xdisp): Don't use set_window_height but set
9234 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9235 Use resize_frame_windows instead of change_window_heights and run
9236 run_window_configuration_change_hook.
9238 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9239 instead of change_window_heights and run
9240 run_window_configuration_change_hook.
9242 2011-06-09 Martin Rudalics <rudalics@gmx.at>
9244 * window.c (replace_window): Rename second argument REPLACEMENT to
9245 NEW. New third argument SETFLAG. Rewrite.
9246 (delete_window, make_dummy_parent): Call replace_window with
9248 (window_list_1): Move down in code.
9249 (run_window_configuration_change_hook): Move set_buffer part
9250 before select_frame_norecord part in order to unwind correctly.
9251 Rename count1 to count.
9252 (recombine_windows, delete_deletable_window, resize_root_window)
9253 (Fdelete_other_windows_internal)
9254 (Frun_window_configuration_change_hook, make_parent_window)
9255 (resize_window_check, resize_window_apply, Fresize_window_apply)
9256 (resize_frame_windows, Fsplit_window_internal)
9257 (Fdelete_window_internal, Fresize_mini_window_internal):
9259 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9261 2011-06-08 Martin Rudalics <rudalics@gmx.at>
9263 * window.h (window): Add some new members to window structure -
9264 normal_lines, normal_cols, new_total, new_normal, clone_number,
9265 splits, nest, prev_buffers, next_buffers.
9266 (WINDOW_TOTAL_SIZE): Move here from window.c.
9267 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
9269 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9271 (make_dummy_parent): Set new members of windows structure.
9272 (make_window): Move down in code. Handle new members of window
9274 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9275 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9276 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9277 (Fset_window_prev_buffers, Fwindow_next_buffers)
9278 (Fset_window_next_buffers, Fset_window_clone_number):
9280 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9281 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9283 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9284 Argument WINDOW can be now internal window too.
9285 (Fwindow_use_time): Move up in code.
9286 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9288 (Fset_window_configuration, saved_window)
9289 (Fcurrent_window_configuration, save_window_save): Handle new
9290 members of window structure.
9291 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9292 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9293 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9294 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9295 Qget_mru_window, Qresize_root_window,
9296 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9297 Qauto_buffer_name; staticpro them.
9299 2011-06-07 Martin Rudalics <rudalics@gmx.at>
9301 * window.c (Fwindow_total_size, Fwindow_left_column)
9302 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9303 (Fwindow_list_1): New functions.
9304 (window_box_text_cols): Replace with window_body_cols.
9305 (Fwindow_width, Fscroll_left, Fscroll_right):
9306 Use window_body_cols instead of window_box_text_cols.
9307 (delete_window, Fset_window_configuration):
9308 Call delete_all_subwindows with window as argument.
9309 (delete_all_subwindows): Take a window as argument and not a
9311 (window_loop): Remove handling of GET_LRU_WINDOW and
9313 (Fget_lru_window, Fget_largest_window): Move to window.el.
9315 * window.h: Extern window_body_cols instead of
9316 window_box_text_cols. delete_all_subwindows now takes a
9317 Lisp_Object as argument.
9319 * indent.c (compute_motion, Fcompute_motion):
9320 Use window_body_cols instead of window_box_text_cols.
9322 * frame.c (delete_frame): Call delete_all_subwindows with root
9325 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9327 * fns.c (Fputhash): Document return value.
9329 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
9331 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9333 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9335 Cons<->int and similar integer overflow fixes (Bug#8794).
9337 Check for overflow when converting integer to cons and back.
9338 * charset.c (Fdefine_charset_internal, Fdecode_char):
9339 Use cons_to_unsigned to catch overflow.
9340 (Fencode_char): Use INTEGER_TO_CONS.
9341 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9342 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9343 * data.c (long_to_cons, cons_to_long): Remove.
9344 (cons_to_unsigned, cons_to_signed): New functions.
9345 These signal an error for invalid or out-of-range values.
9346 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9347 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9348 * font.c (Ffont_variation_glyphs):
9349 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9350 * lisp.h: Include <intprops.h>.
9351 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9352 (cons_to_signed, cons_to_unsigned): New decls.
9353 (long_to_cons, cons_to_long): Remove decls.
9354 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9355 (Fprimitive_undo): Use CONS_TO_INTEGER.
9356 * xfns.c (Fx_window_property): Likewise.
9357 * xselect.c: Include <limits.h>.
9358 (x_own_selection, selection_data_to_lisp_data):
9359 Use INTEGER_TO_CONS.
9360 (x_handle_selection_request, x_handle_selection_clear)
9361 (x_get_foreign_selection, Fx_disown_selection_internal)
9362 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9363 (lisp_data_to_selection_data): Use cons_to_unsigned.
9364 (x_fill_property_data): Use cons_to_signed.
9365 Report values out of range.
9367 Check for buffer and string overflow more precisely.
9368 * buffer.h (BUF_BYTES_MAX): New macro.
9369 * lisp.h (STRING_BYTES_MAX): New macro.
9370 * alloc.c (Fmake_string):
9371 * character.c (string_escape_byte8):
9372 * coding.c (coding_alloc_by_realloc):
9373 * doprnt.c (doprnt):
9374 * editfns.c (Fformat):
9376 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9377 since they may not be the same number.
9378 * editfns.c (Finsert_char):
9379 * fileio.c (Finsert_file_contents):
9380 Likewise for BUF_BYTES_MAX.
9382 * image.c: Use ptrdiff_t, not int, for sizes.
9383 (slurp_file): Switch from int to ptrdiff_t.
9385 (slurp_file): Check that file size fits in both size_t (for
9386 malloc) and ptrdiff_t (for sanity and safety).
9388 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9389 if b->modtime has its maximal value.
9391 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9393 Don't assume time_t can fit into int.
9394 * buffer.h (struct buffer.modtime): Now time_t, not int.
9395 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9396 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9398 Minor fixes for signed vs unsigned integers.
9399 * character.h (MAYBE_UNIFY_CHAR):
9400 * charset.c (maybe_unify_char):
9401 * keyboard.c (read_char, reorder_modifiers):
9402 XINT -> XFASTINT, since the integer must be nonnegative.
9403 * ftfont.c (ftfont_spec_pattern):
9404 * keymap.c (access_keymap, silly_event_symbol_error):
9405 XUINT -> XFASTINT, since the integer must be nonnegative.
9406 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9407 since it makes no difference and we prefer signed.
9408 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9409 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9412 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9414 * window.h (Fwindow_frame): Declare.
9416 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9418 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9419 (SPARE_MEMORY): Always define.
9420 (LARGE_REQUEST): Remove.
9421 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9423 2011-06-06 Martin Rudalics <rudalics@gmx.at>
9425 * lisp.h: Move EXFUNS for Fframe_root_window,
9426 Fframe_first_window and Fset_frame_selected_window to window.h.
9428 * window.h: Move EXFUNS for Fframe_root_window,
9429 Fframe_first_window and Fset_frame_selected_window here from
9432 * frame.c (Fwindow_frame, Fframe_first_window)
9433 (Fframe_root_window, Fframe_selected_window)
9434 (Fset_frame_selected_window): Move to window.c.
9435 (Factive_minibuffer_window): Move to minibuf.c.
9436 (Fother_visible_frames_p): New function.
9438 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9440 * window.c (decode_window, decode_any_window): Move up in code.
9441 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9442 (inhibit_frame_unsplittable): Remove unused variable.
9443 (Fwindow_buffer): Move up and rewrite doc-string.
9444 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9445 (Fwindow_prev): New functions.
9446 (Fwindow_frame): Move here from frame.c. Accept any window as
9448 (Fframe_root_window, Fframe_first_window)
9449 (Fframe_selected_window): Move here from frame.c. Accept frame
9450 or arbitrary window as argument. Update doc-strings.
9451 (Fminibuffer_window): Move up in code.
9452 (Fwindow_minibuffer_p): Move up in code and simplify.
9453 (Fset_frame_selected_window): Move here from frame.c.
9455 (Fselected_window, select_window, Fselect_window): Move up in
9456 code. Minor doc-string fixes.
9458 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9460 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9461 Do not assume that spare memory exists; that assumption is valid
9462 only if SYSTEM_MALLOC.
9463 (LARGE_REQUEST): New macro, so that the issue of large requests
9464 is separated from the issue of spare memory.
9466 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9468 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9471 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9473 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9476 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9478 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9480 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9482 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9483 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9485 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
9487 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9489 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
9491 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9492 (x_clipboard_manager_save): Add return value.
9493 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9495 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9496 Obey Vx_select_enable_clipboard_manager. Catch errors in
9497 x_clipboard_manager_save (Bug#8779).
9498 (Vx_select_enable_clipboard_manager): New variable.
9499 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
9501 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
9503 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9505 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9507 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9508 in the current matrix if keep_current_p is non-zero.
9510 2011-06-04 Eli Zaretskii <eliz@gnu.org>
9512 * bidi.c (bidi_level_of_next_char): Fix last change.
9514 2011-06-03 Eli Zaretskii <eliz@gnu.org>
9516 Support bidi reordering of text covered by display properties.
9518 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9519 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9520 (bidi_cache_search, bidi_cache_iterator_state)
9521 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
9522 (bidi_level_of_next_char, bidi_move_to_visually_next):
9523 Support character positions inside a run of characters covered by a
9525 (bidi_paragraph_init, bidi_resolve_explicit_1)
9526 (bidi_level_of_next_char): Call bidi_fetch_char and
9527 bidi_fetch_char_advance instead of FETCH_CHAR and
9529 (bidi_init_it): Initialize new members.
9530 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9532 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9533 instead of using explicit *_CHAR codes.
9534 (bidi_resolve_explicit, bidi_resolve_weak):
9535 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
9536 bidirectional text is supported only in multibyte buffers.
9537 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9538 it to initialize the frame_window_p member of struct bidi_it.
9539 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9540 (bidi_resolve_explicit, bidi_resolve_weak)
9541 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9542 bidi_it->nchars is non-positive.
9543 (bidi_level_of_next_char): Don't try to lookup the cache for the
9544 next/previous character if nothing is cached there yet, or if we
9545 were just reseat()'ed to a new position.
9547 * xdisp.c (set_cursor_from_row): Set start and stop points
9548 according to the row's direction when priming the loop that looks
9549 for the glyph on which to display cursor.
9550 (single_display_spec_intangible_p): Function deleted.
9551 (display_prop_intangible_p): Reimplement to call
9552 handle_display_spec instead of single_display_spec_intangible_p.
9553 Accept 3 additional arguments needed by handle_display_spec.
9554 This fixes incorrect cursor motion across display property with complex
9555 values: lists, `(when COND...)' forms, etc.
9556 (single_display_spec_string_p): Support property values that are
9557 lists with the argument STRING its top-level element.
9558 (display_prop_string_p): Fix the condition for processing a
9559 property that is a list to be consistent with handle_display_spec.
9560 (handle_display_spec): New function, refactored from the
9561 last portion of handle_display_prop.
9562 (compute_display_string_pos): Accept additional argument
9563 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9564 value of a `display' property is a "replacing spec".
9565 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9566 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9567 the display property, but just return a value indicating whether
9568 the display property will replace the characters it covers.
9569 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9570 frame_window_p members of struct bidi_it.
9571 (compute_display_string_pos, compute_display_string_end):
9573 (push_it): Accept second argument POSITION, where pop_it should
9574 jump to continue iteration.
9575 (reseat_1): Initialize bidi_it.disp_pos.
9577 * keyboard.c (adjust_point_for_property): Adjust the call to
9578 display_prop_intangible_p to its new signature.
9580 * dispextern.h (struct bidi_it): New member frame_window_p.
9581 (bidi_init_it): Update prototypes.
9582 (display_prop_intangible_p): Update prototype.
9583 (compute_display_string_pos, compute_display_string_end):
9585 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9588 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
9590 Malloc failure behavior now depends on size of allocation.
9591 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9592 * lisp.h: Change signatures accordingly.
9593 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9594 All callers changed. (Bug#8762)
9596 * gnutls.c: Use Emacs's memory allocators.
9597 Without this change, the gnutls library would invoke malloc etc.
9598 directly, which causes problems on non-SYNC_INPUT hosts, and which
9599 runs afoul of improving memory_full behavior. (Bug#8761)
9600 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9601 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9602 xfree instead of the default malloc, realloc, free.
9603 (Fgnutls_boot): No need to check for memory allocation failure,
9604 since xmalloc does that for us.
9606 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
9607 * category.c (hash_get_category_set):
9608 * ccl.c (ccl_driver):
9609 * charset.c (Fdefine_charset_internal):
9610 * charset.h (struct charset.hash_index):
9611 * composite.c (get_composition_id, gstring_lookup_cache)
9612 (composition_gstring_put_cache):
9613 * composite.h (struct composition.hash_index):
9614 * dispextern.h (struct image.hash):
9615 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9616 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9617 (hashfn_equal, hashfn_user_defined, make_hash_table)
9618 (maybe_resize_hash_table, hash_lookup, hash_put)
9619 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9620 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9621 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9622 * image.c (make_image, search_image_cache, lookup_image)
9623 (xpm_put_color_table_h):
9624 * lisp.h (struct Lisp_Hash_Table):
9625 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
9626 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
9627 for hashes and hash indexes, instead of 'unsigned' and 'int'.
9628 * alloc.c (allocate_vectorlike):
9629 Check for overflow in vector size calculations.
9630 * ccl.c (ccl_driver):
9631 Check for overflow when converting EMACS_INT to int.
9632 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9633 need to be updated by these changes.
9634 * fns.c (make_hash_table, maybe_resize_hash_table):
9635 Check for integer overflow with large hash tables.
9636 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9637 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9638 (SXHASH_REDUCE): New macro.
9639 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9640 Use it instead of discarding useful hash info with large hash values.
9641 (sxhash_float): New function.
9642 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9643 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
9644 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9645 Rewrite to use FIXNUM_BITS, as this simplifies things.
9646 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9647 Adjust signatures to match updated version of code.
9648 (consing_since_gc): Now EMACS_INT, since a single hash table can
9649 use more than INT_MAX bytes.
9651 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9653 Make it possible to build with GCC-4.6+ -O2 -flto.
9655 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9657 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9659 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9660 Call minibuffer-inactive-mode.
9662 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
9664 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9665 Update dependencies.
9667 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9669 * data.c (init_data): Remove code for UTS, this system is not
9672 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9674 Don't force ./temacs to start in terminal mode.
9676 * frame.c (make_initial_frame): Initialize faces in all cases, not
9677 only when CANNOT_DUMP is defined.
9678 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9680 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9682 * dispnew.c (add_window_display_history): Use const for the string
9683 pointer. Remove declaration, not needed.
9685 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9687 Use 'inline', not 'INLINE'.
9688 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
9689 * alloc.c, fontset.c (INLINE): Remove.
9690 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9691 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9692 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9693 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9694 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9696 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9698 Make it possible to run ./temacs.
9700 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9701 syms_of_callproc does the same thing. Remove test for
9702 "initialized", do it in the caller.
9703 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9705 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9707 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9708 (read_minibuf): Use get_minibuffer.
9709 (syms_of_minibuf): Use DEFSYM.
9710 (Qmetadata): New var.
9711 * data.c (Qbuffer): Don't make it static.
9712 (syms_of_data): Use DEFSYM.
9714 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9716 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9717 (CCL_CODE_MIN): New macro.
9719 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9721 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9723 * eval.c (Qdebug): Now static.
9724 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9725 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9726 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9728 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9730 * image.c: Various fixes to ImageMagick code comments.
9731 (Fimagemagick_types): Doc fix.
9733 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9735 Minor fixes prompted by GCC 4.6.0 warnings.
9737 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9739 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9740 (x_clipboard_manager_save_all): Move extern decl to ...
9741 * xterm.h: ... here, so that it can be checked for consistency.
9743 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9745 * xselect.c (x_clipboard_manager_save_frame)
9746 (x_clipboard_manager_save_all): New functions.
9747 (Fx_clipboard_manager_save): Lisp function deleted.
9749 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9750 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9752 * xterm.h: Update prototype.
9754 2011-05-28 William Xu <william.xwl@gmail.com>
9756 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9759 2011-05-28 Jim Meyering <meyering@redhat.com>
9761 Avoid a sign-extension bug in crypto_hash_function.
9762 * fns.c (to_uchar): Define.
9763 (crypto_hash_function): Use it to convert some newly-signed
9764 variables to unsigned, to avoid sign-extension bugs. For example,
9765 without this change, (md5 "truc") would evaluate to
9766 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9767 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
9768 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
9770 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9772 Integer overflow fixes.
9774 * dbusbind.c: Serial number integer overflow fixes.
9775 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
9776 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9777 to hold a serial number that is too large for a fixnum.
9778 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9779 Check for serial numbers out of range. Decode any serial number
9780 that was so large that it became a float. (Bug#8722)
9782 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9783 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9784 Use XFASTINT rather than XUINT when numbers are nonnegative.
9785 (xd_append_arg, Fdbus_method_return_internal):
9786 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9787 arguments, check that Lisp number is nonnegative, rather than
9788 silently wrapping negative numbers around. (Bug#8722)
9789 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
9792 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9794 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9796 ccl: Add integer overflow checks.
9797 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9798 (IN_INT_RANGE): New macros.
9799 (ccl_driver): Use them to check for integer overflow when
9800 decoding a CCL program. Many of the new checks are whether XINT (x)
9801 fits in int; it doesn't always, on 64-bit hosts. The new version
9802 doesn't catch all possible integer overflows, but it's an
9803 improvement. (Bug#8719)
9805 * alloc.c (make_event_array): Use XINT, not XUINT.
9806 There's no need for unsigned here.
9808 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9809 This follows up to the 2011-05-06 change that substituted uintptr_t
9810 for EMACS_INT. This case wasn't caught back then.
9812 Rework Fformat to avoid integer overflow issues.
9813 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9814 now (part of C89). Include <verify.h>.
9815 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9816 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9817 (Fformat): Avoid the prepass trying to compute sizes; it was only
9818 approximate and thus did not catch overflow reliably. Instead, walk
9819 through the format just once, formatting and computing sizes as we go,
9820 checking for integer overflow at every step, and allocating a larger
9821 buffer as needed. Keep track separately whether the format is
9822 multibyte. Keep only the most-recently calculated precision, rather
9823 than them all. Record whether each argument has been converted to
9824 string. Use EMACS_INT, not int, for byte and char and arg counts.
9825 Support field widths and precisions larger than INT_MAX. Avoid
9826 sprintf's undefined behavior with conversion specifications such as %#d
9827 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9828 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9829 formatting out-of-range floating point numbers with int
9832 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9834 * data.c: Avoid integer truncation in expressions involving floats.
9835 * data.c: Include <intprops.h>.
9836 (arith_driver): When there's an integer overflow in an expression
9837 involving floating point, convert the integers to floating point
9838 so that the resulting value does not suffer from catastrophic
9839 integer truncation. For example, on a 64-bit host (* 4
9840 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9841 Do not rely on undefined behavior after integer overflow.
9843 merge count_size_as_multibyte, parse_str_to_multibyte
9844 * character.c, character.h (count_size_as_multibyte):
9845 Rename from parse_str_to_multibyte; all uses changed.
9846 Check for integer overflow.
9847 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9848 since it's now a duplicate of the other. This is more of
9849 a character than a buffer op, so better that it's in character.c.
9850 * fns.c, print.c: Adjust to above changes.
9852 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9854 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9856 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9858 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9859 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9860 (x_clipboard_manager_save): Now static.
9861 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9863 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9864 (crypto_hash_function): Now static.
9865 Fix pointer signedness problems. Avoid unnecessary initializations.
9867 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
9869 * termhooks.h (Vselection_alist): Make it terminal-local.
9871 * terminal.c (create_terminal): Initialize it.
9873 * xselect.c: Support for clipboard managers.
9874 (Vselection_alist): Move to termhooks.h as terminal-local var.
9875 (LOCAL_SELECTION): New macro.
9876 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9877 (symbol_to_x_atom): Remove gratuitous arg.
9878 (x_handle_selection_request, lisp_data_to_selection_data)
9879 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
9880 (x_own_selection, x_get_local_selection, x_convert_selection):
9881 New arg, specifying work frame. Use terminal-local Vselection_alist.
9882 (some_frame_on_display): Delete unused function.
9883 (Fx_own_selection_internal, Fx_get_selection_internal)
9884 (Fx_disown_selection_internal, Fx_selection_owner_p)
9885 (Fx_selection_exists_p): New optional frame arg.
9886 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9887 (x_handle_selection_clear): Don't treat other terminals with the
9888 same keyboard specially. Use the terminal-local Vselection_alist.
9889 (x_clear_frame_selections): Use Frun_hook_with_args.
9891 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9893 * xterm.h: Add support for those atoms.
9895 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
9897 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9898 (converted_selections, conversion_fail_tag): New global variables.
9899 (x_selection_request_lisp_error): Free the above.
9900 (x_get_local_selection): Remove unnecessary code.
9901 (x_reply_selection_request): Args changed; handle arbitrary array
9902 of converted selections stored in converted_selections.
9903 Separate the XChangeProperty and SelectionNotify steps.
9904 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9905 (x_convert_selection): New function.
9906 (x_handle_selection_event): Simplify.
9907 (x_get_foreign_selection): Don't ignore incoming requests while
9908 waiting for an answer; this will fail when we implement
9909 SAVE_TARGETS, and seems unnecessary anyway.
9910 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9911 (Vx_sent_selection_functions): Doc fix.
9913 2011-05-26 Leo Liu <sdl.web@gmail.com>
9915 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9917 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9919 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9921 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9922 for fringe update if it has periodic bitmap.
9923 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
9924 and fringe_bitmap_periodic_p.
9926 * fringe.c (get_fringe_bitmap_data): New function.
9927 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9928 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9929 row. Mark glyph row for fringe update if periodicity changed.
9931 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9932 for fringe update unless it has periodic bitmap.
9934 2011-05-25 Kenichi Handa <handa@m17n.org>
9936 * xdisp.c (get_next_display_element): Set correct it->face_id for
9937 a static composition.
9939 2011-05-24 Leo Liu <sdl.web@gmail.com>
9942 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9944 * fns.c (crypto_hash_function, Fsha1): New function.
9945 (Fmd5): Use crypto_hash_function.
9946 (syms_of_fns): Add Ssha1.
9948 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9950 * gnutls.c: Remove unused macros.
9951 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9952 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9953 Remove macros that are defined and never used.
9954 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9956 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9958 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9959 (Fx_get_selection_internal): Minor cleanup.
9960 (Fx_own_selection_internal): Rename arguments for consistency with
9963 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9965 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9967 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9969 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9971 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9973 * dispnew.c (scrolling_window): Don't exclude the case that the
9974 last enabled row in the desired matrix touches the bottom boundary.
9976 2011-05-21 Glenn Morris <rgm@gnu.org>
9978 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
9979 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9980 and add some more files.
9982 2011-05-20 Eli Zaretskii <eliz@gnu.org>
9984 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9985 report_file_error introduced by the change from 2011-05-07.
9987 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9989 * systime.h (Time): Define only if emacs is defined.
9990 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9991 where the include path doesn't have X11/X.h by default. See
9992 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9994 2011-05-20 Kenichi Handa <handa@m17n.org>
9996 * composite.c (find_automatic_composition): Fix previous change.
9998 2011-05-20 Glenn Morris <rgm@gnu.org>
10000 * lisp.mk: New file, split from Makefile.in.
10001 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10002 (shortlisp): Remove.
10003 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10005 2011-05-19 Glenn Morris <rgm@gnu.org>
10007 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10008 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10009 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10010 (lisp): Set the order to that of loadup.el.
10011 (shortlisp): Make it a copy of $lisp.
10012 (SOME_MACHINE_LISP): Remove.
10013 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10014 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10016 2011-05-18 Kenichi Handa <handa@m17n.org>
10018 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10019 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10020 (find_automatic_composition): Mostly rewrite for efficiency.
10022 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
10024 * makefile.w32-in: Update dependencies.
10026 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10028 * menu.c: Include limits.h (fixes the MS-Windows build broken by
10029 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
10031 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
10033 Fix some integer overflow issues, such as string length overflow.
10035 * insdel.c (count_size_as_multibyte): Check for string overflow.
10037 * character.c (lisp_string_width): Check for string overflow.
10038 Use EMACS_INT, not int, for string indexes and lengths; in
10039 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10040 the resulting string length overflows an EMACS_INT; instead,
10041 report a string overflow if no precision given. When checking for
10042 precision exhaustion, use a check that cannot possibly have
10043 integer overflow. (Bug#8675)
10044 * character.h (lisp_string_width): Adjust to new signature.
10046 * alloc.c (string_overflow): New function.
10047 (Fmake_string): Use it. This doesn't change behavior, but saves
10048 a few bytes and will simplify future changes.
10049 * character.c (string_escape_byte8): Likewise.
10050 * lisp.h (string_overflow): New decl.
10052 Fixups, following up to the user-interface timestamp change.
10053 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10054 for UI timestamps, instead of unsigned long.
10055 * msdos.c (mouse_get_pos): Likewise.
10056 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
10057 * w32gui.h (Time): Define by including "systime.h" rather than by
10058 declaring it ourselves. (Bug#8664)
10060 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10061 * image.c (clear_image_cache): Likewise.
10063 * term.c (term_mouse_position): Don't assume time_t wraparound.
10065 Be more systematic about user-interface timestamps.
10066 Before, the code sometimes used 'Time', sometimes 'unsigned long',
10067 and sometimes 'EMACS_UINT', to represent these timestamps.
10068 This change causes it to use 'Time' uniformly, as that's what X uses.
10069 This makes the code easier to follow, and makes it easier to catch
10070 integer overflow bugs such as Bug#8664.
10071 * frame.c (Fmouse_position, Fmouse_pixel_position):
10072 Use Time, not unsigned long, for user-interface timestamps.
10073 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10074 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10075 * keyboard.h (last_event_timestamp): Likewise.
10076 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10077 * menu.h (xmenu_show): Likewise.
10078 * term.c (term_mouse_position): Likewise.
10079 * termhooks.h (struct input_event.timestamp): Likewise.
10080 (struct terminal.mouse_position_hook): Likewise.
10081 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10082 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10083 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10084 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10085 what it was before.
10086 * menu.h, termhooks.h: Include "systime.h", for Time.
10088 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10089 Don't assume that the difference between two unsigned long values
10090 can fit into an integer. At this point, we know button_down_time
10091 <= event->timestamp, so the difference must be nonnegative, so
10092 there's no need to cast the result if double-click-time is
10093 nonnegative, as it should be; check that it's nonnegative, just in
10094 case. This bug is triggered when events are more than 2**31 ms
10095 apart (about 25 days). (Bug#8664)
10097 * xselect.c (last_event_timestamp): Remove duplicate decl.
10098 (x_own_selection): Remove needless cast to unsigned long.
10100 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10101 that always fit in int. Use a sentinel instead of a counter, to
10102 avoid a temp and to allay GCC's concerns about possible int overflow.
10103 * frame.h (struct frame): Use int for menu_bar_items_used
10104 instead of EMACS_INT, since it always fits in int.
10106 * menu.c (grow_menu_items): Check for int overflow.
10108 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10110 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10111 Before, the code was not consistent. These values cannot exceed
10112 2**31 - 1 so there's no need to make them unsigned.
10113 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10114 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10115 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10117 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10119 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10120 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10121 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10122 presumably because the widths might not match.
10124 * window.c (size_window): Avoid needless test at loop start.
10126 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10128 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10130 2011-05-12 Drew Adams <drew.adams@oracle.com>
10132 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10134 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10136 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10137 `width' to `bar_area_x' and `bar_area_width', respectively.
10138 (x_scroll_run): Take account of fringe background extension.
10140 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10141 Rename local vars `left' and `width' to `bar_area_x' and
10142 `bar_area_width', respectively.
10143 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10144 background extension.
10146 2011-05-10 Jim Meyering <meyering@redhat.com>
10148 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10150 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
10152 * image.c (Finit_image_library): Return t for built-in image types,
10153 like pbm and xbm. (Bug#8640)
10155 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10157 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10159 2011-05-07 Eli Zaretskii <eliz@gnu.org>
10161 * w32console.c (Fset_screen_color): Doc fix.
10162 (Fget_screen_color): New function.
10163 (syms_of_ntterm): Defsubr it.
10165 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10166 unlink the temporary file if Fcall_process didn't create it in the
10168 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10169 child process will be redirected to a file specified with `:file'.
10170 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10171 cue to call_process_cleanup not to close that handle.
10173 2011-05-07 Ben Key <bkey76@gmail.com>
10175 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10176 one of two shell specific rules, either bootstrap-temacs-CMD or
10177 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10178 to the previous implementation of the bootstrap-temacs rule.
10179 The bootstrap-temacs-CMD rule is similar to the previous
10180 implementation of the bootstrap-temacs rule except that it
10181 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10184 These changes, along with some changes to nt/configure.bat,
10185 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10186 earlier fix to add support for --cflags and --ldflags options
10187 that include quotes so that it works whether make uses cmd or
10190 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
10192 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10193 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10195 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10196 a string. Handle both cases.
10197 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10198 (Fdbus_register_method): Use Qinvalid_function.
10200 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10202 * makefile.w32-in: Update dependencies.
10203 (LISP_H): Add inttypes.h and stdin.h.
10204 (PROCESS_H): Add unistd.h.
10206 2011-05-06 Eli Zaretskii <eliz@gnu.org>
10208 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10209 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10211 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
10213 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10215 * term.c (vfatal): Remove stray call to va_end.
10216 It's not needed and the C Standard doesn't allow it here anyway.
10218 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10219 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10221 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10224 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10226 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10228 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10230 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10232 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10234 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10235 * charset.c (Fdefine_charset_internal): Don't initialize
10236 charset.code_space[15]. The value was garbage, on hosts with
10237 32-bit int (Bug#8600).
10239 * lread.c (read_integer): Be more consistent with string-to-number.
10240 Use string_to_number to do the actual conversion; this avoids
10241 rounding errors and fixes some other screwups. Without this fix,
10242 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10243 (digit_to_number): Move earlier, for benefit of read_integer.
10244 Return -1 if the digit is out of range for the base, -2 if it is
10245 not a digit in any supported base. (Bug#8602)
10247 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10249 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10250 to match comment at start of function. This also removes a
10251 GCC warning about overflow in a 32+64-bit port.
10253 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10255 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10256 Reported by Stefan Monnier in
10257 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
10258 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10259 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
10261 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10262 (EMACS_UINTPTR): Likewise, with uintptr_t.
10264 * lisp.h: Prefer 64-bit EMACS_INT if available.
10265 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10266 on 32-bit hosts that have 64-bit int, so that they can access
10268 However, temporarily disable this change unless the temporary
10269 symbol WIDE_EMACS_INT is defined.
10271 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10273 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10274 This removes an assumption that EMACS_INT and long are the same
10275 width as pointers. The assumption is true for Emacs porting targets
10276 now, but we want to make other targets possible.
10277 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10278 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10279 In the rest of the code, change types of integers that hold casted
10280 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10281 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10282 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10283 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10284 No need to cast type when ORing.
10285 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10286 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10287 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10288 assume EMACS_INT is the same width as char *.
10289 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10290 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10291 Remove no-longer-needed casts.
10292 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10293 (xg_tool_bar_help_callback, xg_make_tool_item):
10294 Use EMACS_INTPTR to hold an integer
10295 that will be cast to void *; this can avoid a GCC warning
10296 if EMACS_INT is not the same width as void *.
10297 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10298 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10299 (current_message_1, set_message_1):
10300 Use a local to convert to proper width without a cast.
10301 * xmenu.c (dialog_selection_callback): Likewise.
10303 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10304 Also, don't assume VALBITS / RAND_BITS is less than 5,
10305 and don't rely on undefined behavior when shifting a 1 left into
10307 * lisp.h (get_random): Change signature to match.
10309 * lread.c (hash_string): Use size_t, not int, for hash computation.
10310 Normally we prefer signed values; but hashing is special, because
10311 it's better to use unsigned division on hash table sizes so that
10312 the remainder is nonnegative. Also, size_t is the natural width
10313 for hashing into memory. The previous code used 'int', which doesn't
10314 retain enough info to hash well into very large tables.
10315 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10317 * dbusbind.c: Don't possibly lose pointer info when converting.
10318 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10319 Use XPNTR rather than XHASH, so that the high-order bits of
10320 the pointer aren't lost when converting through void *.
10322 * eval.c (Fautoload): Don't double-shift a pointer.
10324 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10326 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10328 * gnutls.c (DEF_GNUTLS_FN):
10329 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10331 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10333 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10336 2011-05-05 Eli Zaretskii <eliz@gnu.org>
10338 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10339 New version that can reserve upto 2GB of heap space.
10341 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
10343 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10345 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10347 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10348 `gnutls_certificate_set_x509_key_file'.
10350 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
10352 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10353 Update dependencies.
10355 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10357 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10358 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10359 Remove unused parameter `fildes'.
10360 * process.c (read_process_output, send_process): Don't pass it.
10362 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10364 Fix previous change: the library cache is defined in w32.c.
10365 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10366 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10368 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10370 Implement dynamic loading of GnuTLS on Windows.
10372 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10373 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10374 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10377 * gnutls.c (Qgnutls_dll): Define.
10378 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10379 (gnutls_*): Declare function pointers.
10380 (init_gnutls_functions): New function to initialize function pointers.
10381 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10382 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10383 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10384 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10385 (emacs_gnutls_write, emacs_gnutls_read)
10386 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10387 (Fgnutls_available_p): New function.
10388 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10389 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10390 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10392 * image.c: Include w32.h.
10393 (Vimage_type_cache): Delete.
10394 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10395 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10396 (w32_delayed_load): Move to w32.c.
10398 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10400 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10401 (w32_delayed_load): Move from image.c. When loading a library, record
10402 its filename in the :loaded-from property of the library id.
10403 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10404 Initialize and staticpro them.
10405 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10407 * process.c: Include lisp.h before w32.h, not after.
10408 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10409 instead of gnutls_record_check_pending.
10411 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10413 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10415 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10416 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10419 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10421 * xterm.c (x_set_frame_alpha): Do not set property on anything
10422 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10424 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10426 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10428 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10430 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10431 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10432 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10433 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10434 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10435 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10436 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10437 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10438 (Qgnutls_bootprop_callbacks_verify): Make static.
10440 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10442 * callproc.c: Indentation fixup.
10444 * sysdep.c (wait_for_termination_1): Make static.
10445 (wait_for_termination, interruptible_wait_for_termination):
10446 Move after wait_for_termination_1.
10448 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10450 * sysdep.c (interruptible_wait_for_termination): New function
10451 which is like wait_for_termination, but allows keyboard
10454 * callproc.c (Fcall_process): Add (:file "file") as an option for
10456 (Fcall_process_region): Ditto.
10458 2011-04-30 Eli Zaretskii <eliz@gnu.org>
10460 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10461 rather than `XVECTOR (FOO)->size'.
10463 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10464 inttypes.h, as a gnulib replacement is used if it not available in
10467 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10469 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10470 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10471 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10473 * coding.c (coding_alloc_by_realloc): Error out if destination
10474 will grow beyond MOST_POSITIVE_FIXNUM.
10475 (decode_coding_emacs_mule): Abort if there isn't enough place in
10476 charbuf for the composition carryover bytes. Reserve an extra
10477 space for up to 2 characters produced in a loop.
10478 (decode_coding_iso_2022): Abort if there isn't enough place in
10479 charbuf for the composition carryover bytes.
10481 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10483 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10484 aborting when %lld or %lll format is passed.
10485 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10486 %llo or %llx format is passed. (Bug#8545)
10488 * window.c (window_scroll_line_based): Use a marker instead of
10489 simple variables to record original value of point. (Bug#7952)
10491 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10492 produced by %s or %c overflows available buffer space. (Bug#8545)
10494 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10496 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
10497 (SIZE_MAX): Move defn after all includes, as they might #define it.
10499 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10501 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10503 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10505 * keyboard.c (Qdelayed_warnings_hook): Define.
10506 (command_loop_1): Run `delayed-warnings-hook'
10507 if Vdelayed_warnings_list is non-nil.
10508 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10509 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10511 2011-04-28 Eli Zaretskii <eliz@gnu.org>
10513 * doprnt.c (doprnt): Don't return value smaller than the buffer
10514 size if the message was truncated. (Bug#8545).
10516 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10518 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10519 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10521 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10523 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10525 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
10527 * makefile.w32-in: Update dependencies.
10529 2011-04-27 Eli Zaretskii <eliz@gnu.org>
10531 Improve `doprnt' and its usage. (Bug#8545)
10532 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10533 `format_end'. Remove support for %l as a conversion specifier.
10534 Don't use xrealloc. Improve diagnostics when the %l size modifier
10535 is used. Update the commentary.
10537 * eval.c (verror): Simplify calculation of size_t.
10539 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10542 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10544 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10547 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10549 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10550 This makes this file independent of the recent pseudovector change.
10552 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
10554 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10556 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
10557 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
10558 Remove unused local.
10559 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
10561 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
10562 GCC 4.6.0 optimizes based on type-based alias analysis.
10563 For example, if b is of type struct buffer * and v of type struct
10564 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10565 != &v->size, and therefore "v->size = 1; b->size = 2; return
10566 v->size;" must therefore return 1. This assumption is incorrect
10567 for Emacs, since it type-puns struct Lisp_Vector * with many other
10568 types. To fix this problem, this patch adds a new type struct
10569 vectorlike_header that documents the constraints on layout of vectors
10570 and pseudovectors, and helps optimizing compilers not get fooled
10571 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10572 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
10573 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10575 (XSETPVECTYPE): Rewrite in terms of new macro.
10576 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10577 This is a bit clearer, and further avoids the possibility of
10578 undesirable aliasing.
10579 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
10580 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
10581 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10582 since Lisp_Subr is a special case (no "next" field).
10583 (ASIZE): Now uses header.size rather than size.
10584 All previous uses of XVECTOR (foo)->size replaced to use this macro,
10585 to avoid the hassle of writing XVECTOR (foo)->header.size.
10586 (struct vectorlike_header): New type.
10587 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10588 object, to help avoid aliasing.
10589 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10590 (SUBRP): Likewise, since Lisp_Subr is a special case.
10591 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10592 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10593 (struct Lisp_Hash_Table): Combine first two members into a single
10594 struct vectorlike_header member. All uses of "size" and "next" members
10595 changed to be "header.size" and "header.next".
10596 * buffer.h (struct buffer): Likewise.
10597 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10598 * frame.h (struct frame): Likewise.
10599 * process.h (struct Lisp_Process): Likewise.
10600 * termhooks.h (struct terminal): Likewise.
10601 * window.c (struct save_window_data, struct saved_window): Likewise.
10602 * window.h (struct window): Likewise.
10603 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10604 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10605 * buffer.c (init_buffer_once): Likewise.
10606 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10608 * process.c (Fformat_network_address): Use local var for size,
10611 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10613 Make the Lisp reader and string-to-float more consistent (Bug#8525)
10614 * data.c (atof): Remove decl; no longer used or needed.
10615 (digit_to_number): Move to lread.c.
10616 (Fstring_to_number): Use new string_to_number function, to be
10617 consistent with how the Lisp reader treats infinities and NaNs.
10618 Do not assume that floating-point numbers represent EMACS_INT
10619 without losing information; this is not true on most 64-bit hosts.
10620 Avoid double-rounding errors, by insisting on integers when
10621 parsing non-base-10 numbers, as the documentation specifies.
10622 * lisp.h (string_to_number): New decl, replacing ...
10623 (isfloat_string): Remove.
10624 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
10625 (read1): Do not accept +. and -. as integers; this
10626 appears to have been a coding error. Similarly, do not accept
10627 strings like +-1e0 as floating point numbers. Do not report
10628 overflow for integer overflows unless the base is not 10 which
10629 means we have no simple and reliable way to continue.
10630 Break out the floating-point parsing into a new
10631 function string_to_number, so that Fstring_to_number parses
10632 floating point numbers consistently with the Lisp reader.
10633 (digit_to_number): Move here from data.c. Make it static inline.
10634 (E_CHAR, EXP_INT): Remove, replacing with ...
10635 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10636 (string_to_number): New function, replacing isfloat_string.
10637 This function checks for valid syntax and produces the resulting
10638 Lisp float number too. Rework it so that string-to-number
10639 no longer mishandles examples like "1.0e+". Use strtoumax,
10640 so that overflow for non-base-10 numbers is reported only when
10641 there's no portable and simple way to convert to floating point.
10643 * textprop.c (set_text_properties_1): Rewrite for clarity,
10644 and to avoid GCC warning about integer overflow.
10646 * intervals.h (struct interval): Use EMACS_INT for members
10647 where EMACS_UINT might cause problems. See
10648 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10649 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10650 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10652 (offset_intervals): Tell GCC not to worry about length overflow
10653 when negating a negative length.
10655 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10656 (overrun_check_free): Likewise.
10658 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10659 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10662 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10663 (gnutls_make_error): Rename local to avoid shadowing.
10664 (gnutls_emacs_global_deinit): ifdef out; not used.
10665 (Fgnutls_boot): Use const for pointer to readonly storage.
10666 Comment out unused local. Fix pointer signedness problems.
10668 * lread.c (openp): Don't stuff size_t into an 'int'.
10669 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10670 about possible signed overflow.
10672 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10673 (GDK_KEY_g): Don't define if already defined.
10674 (xg_prepare_tooltip): Avoid pointer signedness problem.
10675 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10677 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10678 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10680 * xfns.c (Fx_window_property): Simplify a bit,
10681 to make a bit faster and to avoid GCC 4.6.0 warning.
10682 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10684 * fns.c (internal_equal): Don't assume size_t fits in int.
10686 * alloc.c (compact_small_strings): Tighten assertion a little.
10688 Replace pEd with more-general pI, and fix some printf arg casts.
10689 * lisp.h (pI): New macro, generalizing old pEd macro to other
10690 conversion specifiers. For example, use "...%"pI"d..." rather
10691 than "...%"pEd"...".
10692 (pEd): Remove. All uses replaced with similar uses of pI.
10693 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
10694 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10695 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10696 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10697 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10698 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10699 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10701 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10702 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10703 * print.c (safe_debug_print, print_object): Likewise.
10704 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10706 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10707 avoiding the 0 flag, which is not portable.
10708 * process.c (Fmake_network_process): Use pI to avoid cast.
10709 * region-cache.c (pp_cache): Likewise.
10710 * xdisp.c (decode_mode_spec): Likewise.
10711 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10712 behavior on 64-bit hosts with printf arg.
10713 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
10714 (x_stop_queuing_selection_requests): Likewise.
10715 (x_get_window_property): Don't truncate byte count to an 'int'
10718 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10719 here, since it parses constructs like leading '-' and spaces,
10720 which are not wanted; and it overflows with large numbers.
10721 Instead, simply match F[0-9]+, which is what is wanted anyway.
10723 * alloc.c: Remove unportable assumptions about struct layout.
10724 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10725 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10726 (allocate_vectorlike, make_pure_vector): Use the new macros,
10727 plus offsetof, to remove unportable assumptions about struct layout.
10728 These assumptions hold on all porting targets that I know of, but
10729 they are not guaranteed, they're easy to remove, and removing them
10730 makes further changes easier.
10732 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10733 This doesn't fix a bug but makes the code clearer.
10734 (string_overrun_cookie): Now const. Use initializers that
10735 don't formally overflow signed char, to avoid warnings.
10736 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10737 can cause Emacs to crash when string overrun checking is enabled.
10738 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10739 multiple of sizeof (EMACS_INT); it need not be, if
10740 alignof(EMACS_INT) < sizeof (EMACS_INT).
10741 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
10743 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
10745 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10747 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10749 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
10750 supposed to be handshaking. (Bug#8556)
10751 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10753 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
10755 * lisp.h (Qdebug): List symbol.
10756 * eval.c (Qdebug): Restore global linkage.
10757 * keyboard.c (debug-on-event): New variable.
10758 (handle_user_signal): Break into debugger when debug-on-event
10759 matches the current signal symbol.
10761 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10763 * alloc.c (check_sblock, check_string_bytes)
10764 (check_string_free_list): Convert to standard C.
10766 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10768 * w32.c (emacs_gnutls_push): Fix typo.
10770 2011-04-25 Eli Zaretskii <eliz@gnu.org>
10772 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10773 "cast to pointer from integer of different size".
10775 Improve doprnt and its use in verror. (Bug#8545)
10776 * doprnt.c (doprnt): Document the set of format control sequences
10777 supported by the function. Use SAFE_ALLOCA instead of always
10780 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10781 is one byte too soon. Don't use xrealloc; instead xfree and
10784 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10786 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10789 * gnutls.c: Renamed global_initialized to
10790 gnutls_global_initialized. Added internals for the
10791 :verify-hostname-error, :verify-error, and :verify-flags
10792 parameters of `gnutls-boot' and documented those parameters in the
10793 docstring. Start callback support.
10794 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10795 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10796 on error. Return error code.
10797 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10798 (emacs_gnutls_read): Likewise.
10799 (Fgnutls_boot): Return handshake error code.
10800 (emacs_gnutls_handle_error): New function.
10801 (wsaerror_to_errno): Likewise.
10803 * w32.h (emacs_gnutls_pull): Add prototype.
10804 (emacs_gnutls_push): Likewise.
10806 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10807 (emacs_gnutls_push): Likewise.
10809 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10811 * process.c (wait_reading_process_output): Check if GnuTLS
10812 buffered some data internally if no FDs are set for TLS
10815 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10816 (LIBS): Link to USER_LIBS.
10817 ($(BLD)/gnutls.$(0)): New target.
10819 2011-04-24 Eli Zaretskii <eliz@gnu.org>
10821 * xdisp.c (handle_single_display_spec): Rename the
10822 display_replaced_before_p argument into display_replaced_p, to
10823 make it consistent with the commentary. Fix typos in the
10826 * textprop.c (syms_of_textprop): Remove dead code.
10827 (copy_text_properties): Delete obsolete commentary about an
10828 interface that was deleted long ago. Fix typos in the description
10831 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10832 to changes in oldXMenu/XMenu.h from 2011-04-16.
10833 <menu_help_message, prev_menu_help_message>: Constify.
10834 (IT_menu_make_room): menu->help_text is now `const char **';
10837 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10838 to changes in oldXMenu/XMenu.h from 2011-04-16.
10839 (struct XMenu): Declare `help_text' `const char **'.
10841 * xfaces.c <Qunspecified>: Make extern again.
10843 * syntax.c: Include sys/types.h before including regex.h, as
10846 * doc.c (get_doc_string): Improve the format passed to `error'.
10848 * doprnt.c (doprnt): Improve commentary.
10850 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10852 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10855 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10856 changes in globals.h immediately force recompilation.
10857 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10858 $(CURDIR)/s/ms-w32.h.
10859 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
10861 * character.c (Fchar_direction): Function deleted.
10862 (syms_of_character): Don't defsubr it.
10863 <char-direction-table>: Deleted.
10865 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10867 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10868 * doprnt.c: Include limits.h.
10869 (SIZE_MAX): New macro.
10870 (doprnt): Return a size_t value. 2nd arg is now size_t.
10871 Many local variables are now size_t instead of int or unsigned.
10872 Improve overflow protection. Support `l' modifier for integer
10873 conversions. Support %l conversion. Don't assume an EMACS_INT
10874 argument for integer conversions and for %c.
10876 * lisp.h (doprnt): Restore prototype.
10878 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10879 $(SRC)/character.h.
10881 * Makefile.in (base_obj): Add back doprnt.o.
10883 * deps.mk (doprnt.o): Add back prerequisites.
10884 (callint.o): Depend on character.h.
10886 * eval.c (internal_lisp_condition_case): Include the handler
10887 representation in the error message.
10888 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10889 when breaking from the loop.
10891 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10893 * callint.c (Fcall_interactively): When displaying error message
10894 about invalid control letter, pass the character's codepoint, not
10895 a pointer to its multibyte form. Improve display of the character
10896 in octal and display also its hex code.
10898 * character.c (char_string): Use %x to display the (unsigned)
10899 codepoint of an invalid character, to avoid displaying a bogus
10902 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10903 `error', not SYMBOL_NAME itself.
10905 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10906 character arguments to `error'.
10908 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10909 to `error' in error message about FINAL_CHAR argument. Make sure
10910 FINAL_CHAR is a character, and use %c when it is passed as
10911 argument to `error'.
10913 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10915 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10917 * w32.c: Include <time.h>.
10918 (sys_localtime): New function.
10920 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
10922 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10924 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
10926 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
10928 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10929 zombies (Bug#8467).
10931 2011-04-19 Eli Zaretskii <eliz@gnu.org>
10933 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10934 gl_state.e_property when gl_state.object is Qt.
10936 * insdel.c (make_gap_larger): Remove limitation of buffer size
10939 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
10941 * xdisp.c (lookup_glyphless_char_display)
10942 (produce_glyphless_glyph): Handle cons cell entry in
10943 glyphless-char-display.
10944 (Vglyphless_char_display): Document it.
10946 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10947 glyphless-char-display.
10949 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
10951 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10953 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10955 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10956 definition for no-X builds.
10958 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
10960 Static checks with GCC 4.6.0 and non-default toolkits.
10962 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10964 * process.c (keyboard_bit_set): Define only if SIGIO.
10965 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10966 (send_process): Repair possible setjmp clobbering.
10968 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10970 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10972 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10974 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10975 Define only if needed.
10977 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10978 by pacifying GCC about it. Maybe it's time to retire it?
10979 * xfaces.c (USG, __TIMEVAL__): Likewise.
10981 * dispextern.h (struct redisplay_interface): Rename param
10982 to avoid shadowing.
10983 * termhooks.h (struct terminal): Likewise.
10984 * xterm.c (xembed_send_message): Likewise.
10986 * insdel.c (make_gap_smaller): Define only if
10987 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10989 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10992 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10993 so that we aren't warned about unused symbols.
10995 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10997 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
10999 * xfns.c (x_real_positions): Mark locals as initialized.
11001 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11003 * xterm.c: Fix problems found by static analysis with other toolkits.
11004 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
11005 (x_dispatch_event): Declare static if USE_GTK, and
11006 define if USE_GTK || USE_X_TOOLKIT.
11007 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
11008 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
11009 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11010 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
11012 * xmenu.c (menu_help_callback): Pointer type fixes.
11013 Use const pointers when pointing at readonly data. Avoid pointer
11014 signedness clashes.
11015 (FALSE): Remove unused macro.
11016 (update_frame_menubar): Remove unused decl.
11018 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11020 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11021 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11022 (single_menu_item): Rename local to avoid shadowing.
11024 * keyboard.c (make_lispy_event): Remove unused local var.
11026 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11027 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11029 * bitmaps: Change bitmaps from unsigned char back to the X11
11030 compatible char. Avoid the old compiler warnings about
11031 out-of-range initializers by using, for example, '\xab' rather
11034 * xgselect.c (xgselect_initialize): Check vs interface
11035 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11037 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11039 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11040 to read-only memory.
11042 * fns.c (vector): Remove; this old hack is no longer needed.
11044 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
11046 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
11048 * xrdb.c (x_load_resources): Omit unused local.
11050 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
11051 (x_window): Rename locals to avoid shadowing.
11052 (USG): Use the kludged USG macro, to pacify gcc.
11054 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
11055 (x_term_init): Remove local to avoid shadowing.
11057 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
11059 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11060 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11062 2011-04-16 Eli Zaretskii <eliz@gnu.org>
11064 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11066 Fix regex.c, syntax.c and friends for buffers > 2GB.
11067 * syntax.h (struct gl_state_s): Declare character position members
11070 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11072 * textprop.c (verify_interval_modification, interval_of):
11073 Declare arguments EMACS_INT.
11075 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11078 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11080 * indent.c (Fvertical_motion): Local variable it_start is now
11083 * regex.c (re_match, re_match_2, re_match_2_internal)
11084 (bcmp_translate, regcomp, regexec, print_double_string)
11085 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11086 (re_compile_pattern, re_exec): Declare arguments and local
11087 variables `size_t' and `ssize_t' and return values `regoff_t', as
11089 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11090 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11091 <compile_stack_type>: `size' and `avail' are now `size_t'.
11093 * regex.h <regoff_t>: Use ssize_t, not int.
11094 (re_search, re_search_2, re_match, re_match_2): Arguments that
11095 specify buffer/string position and length are now ssize_t and
11096 size_t. Return type is regoff_t.
11098 2011-04-16 Ben Key <bkey76@gmail.com>
11100 * nsfont.m: Fixed bugs in ns_get_family and
11101 ns_descriptor_to_entity that were caused by using free to
11102 deallocate memory blocks that were allocated by xmalloc (via
11103 xstrdup). This caused Emacs to crash when compiled with
11104 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11105 --enable-checking=xmallocoverrun). xfree is now used to
11106 deallocate these memory blocks.
11108 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
11110 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11112 emacs_write: Accept and return EMACS_INT for sizes.
11113 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11115 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11116 Accept and return EMACS_INT.
11117 (emacs_gnutls_write): Return the number of bytes written on
11119 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
11120 (emacs_read, emacs_write): Remove check for negative size, as the
11121 Emacs source code has been audited now.
11122 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11123 (emacs_read, emacs_write): Use it.
11124 * process.c (send_process): Adjust to the new signatures of
11125 emacs_write and emacs_gnutls_write. Do not attempt to store
11126 a byte offset into an 'int'; it might overflow.
11127 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
11129 * sound.c: Don't assume sizes fit in 'int'.
11130 (struct sound_device.period_size, alsa_period_size):
11131 Return EMACS_INT, not int.
11132 (struct sound_device.write, vox_write, alsa_write):
11133 Accept EMACS_INT, not int.
11134 (wav_play, au_play): Use EMACS_INT to store sizes and to
11135 record read return values.
11137 2011-04-15 Ben Key <bkey76@gmail.com>
11139 * keyboard.c (Qundefined): Don't declare static since it is used
11141 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11142 static since they are used in nsfont.m.
11144 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11146 * process.c (Qprocessp): Don't declare static.
11147 * lisp.h (Qprocessp): Declare again.
11149 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
11151 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11153 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11155 Improve C-level modularity by making more things 'static'.
11157 Don't publish debugger-only interfaces to other modules.
11158 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11159 (verify_bytepos, count_markers): Move decls to the only modules
11161 * region-cache.h (pp_cache): Likewise.
11162 * window.h (check_all_windows): Likewise.
11163 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11165 * sysdep.c (croak): Now static, if
11166 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11167 * syssignal.h (croak): Declare only if not static.
11169 * alloc.c (refill_memory_reserve): Now static if
11170 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11171 * lisp.h (refill_memory_reserve): Declare only if not static.
11173 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11174 Define only if USE_LUCID.
11176 * xrdb.c (x_customization_string, x_rm_string): Now static.
11178 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11179 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11181 * xdisp.c (draw_row_with_mouse_face): Now static.
11182 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11184 * window.h (check_all_windows): Mark externally visible.
11186 * window.c (window_deletion_count): Now static.
11188 * undo.c: Make symbols static if they're not exported.
11189 (last_undo_buffer, last_boundary_position, pending_boundary):
11192 * textprop.c (interval_insert_behind_hooks): Now static.
11193 (interval_insert_in_front_hooks): Likewise.
11195 * term.c: Make symbols static if they're not exported.
11196 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11197 (max_frame_lines, tty_set_terminal_modes):
11198 (tty_reset_terminal_modes, tty_turn_off_highlight):
11199 (get_tty_terminal): Now static.
11200 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11201 * termhooks.h (term_mouse_moveto): Do not declare if
11202 HAVE_WINDOW_SYSTEM.
11203 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11204 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11206 * sysdep.c: Make symbols static if they're not exported.
11207 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11209 (sigprocmask_set, full_mask): Remove; unused.
11210 (wait_debugging): Mark as visible.
11211 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11212 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11214 * syntax.c (syntax_temp): Define only if !__GNUC__.
11216 * sound.c (current_sound_device, current_sound): Now static.
11218 * search.c (searchbufs, searchbuf_head): Now static.
11220 * scroll.c (scroll_cost): Remove; unused.
11221 * dispextern.h (scroll_cost): Remove decl.
11223 * region-cache.h (pp_cache): Mark as externally visible.
11225 * process.c: Make symbols static if they're not exported.
11226 (process_tick, update_tick, create_process, chan_process):
11227 (Vprocess_alist, proc_buffered_char, datagram_access):
11228 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11229 (deactivate_process): Mark defn as static, as well as decl.
11230 * lisp.h (create_process): Remove decl.
11231 * process.h (chan_process, Vprocess_alist): Remove decls.
11233 * print.c: Make symbols static if they're not exported.
11234 (print_depth, new_backquote_output, being_printed, print_buffer):
11235 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11236 (print_interval, print_number_index, initial_stderr_stream):
11238 * lisp.h (Fprinc): Remove decl.
11239 (debug_output_compilation_hack): Mark as externally visible.
11241 * sysdep.c (croak): Move decl from here to syssignal.h.
11242 * syssignal.h (croak): Put it here, so the API can be checked when
11243 'croak' is called from dissociate_if_controlling_tty.
11245 * minibuf.c: Make symbols static if they're not exported.
11246 (minibuf_save_list, choose_minibuf_frame): Now static.
11247 * lisp.h (choose_minibuf_frame): Remove decl.
11249 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11251 * lread.c: Make symbols static if they're not exported.
11252 (read_objects, initial_obarray, oblookup_last_bucket_number):
11254 (make_symbol): Remove; unused.
11255 * lisp.h (initial_obarray, make_symbol): Remove decls.
11257 * keyboard.c: Make symbols static if they're not exported.
11258 (single_kboard, recent_keys_index, total_keys, recent_keys):
11259 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11260 (this_single_command_key_start, echoing, last_auto_save):
11261 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11262 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11263 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11264 (Vlispy_mouse_stem, double_click_count):
11266 (force_auto_save_soon): Define only if SIGDANGER.
11267 (ignore_mouse_drag_p): Now static if
11268 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11269 (print_help): Remove; unused.
11270 (stop_character, last_timer_event): Mark as externally visible.
11271 * keyboard.h (ignore_mouse_drag_p): Declare only if
11272 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11273 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11274 * lisp.h (echoing): Remove decl.
11275 (force_auto_save_soon): Declare only if SIGDANGER.
11276 * xdisp.c (redisplay_window): Simplify code, to make it more
11277 obvious that ignore_mouse_drag_p is not accessed if !defined
11278 USE_GTK && !defined HAVE_NS.
11280 * intervals.c: Make symbols static if they're not exported.
11281 (merge_properties_sticky, merge_interval_right, delete_interval):
11283 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11285 * insdel.c: Make symbols static if they're not exported.
11286 However, leave prepare_to_modify_buffer alone. It's never
11287 called from outside this function, but that appears to be a bug.
11288 (combine_after_change_list, combine_after_change_buffer):
11289 (adjust_after_replace, signal_before_change): Now static.
11290 (adjust_after_replace_noundo): Remove; unused.
11291 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
11292 (signal_before_change): Remove decls.
11294 * indent.c (val_compute_motion, val_vmotion): Now static.
11296 * image.c: Make symbols static if they're not exported.
11297 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11299 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11300 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11302 * fringe.c (standard_bitmaps): Now static.
11303 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11305 * frame.c: Make symbols static if they're not exported.
11306 (x_report_frame_params, make_terminal_frame): Now static.
11307 (get_frame_param): Now static, unless HAVE_NS.
11308 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11309 (x_get_resource_string): Remove; not used.
11310 * frame.h (make_terminal_frame, x_report_frame_params):
11311 (x_get_resource_string); Remove decls.
11312 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11313 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11315 * font.c, fontset.c: Make symbols static if they're not exported.
11316 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11317 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11318 * font.c (font_close_object): Now static.
11319 * font.h (font_close_object): Remove.
11320 * fontset.c (FONTSET_OBJLIST): Remove.
11321 (free_realized_fontset) #if-0 the body, which does nothing.
11322 (face_suitable_for_char_p): #if-0, as it's never called.
11323 * fontset.h (face_suitable_for_char_p): Remove decl.
11324 * xfaces.c (face_at_string_position):
11325 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
11326 since 0 is always ASCII.
11328 * fns.c (weak_hash_tables): Now static.
11330 * fileio.c: Make symbols static if they're not exported.
11331 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11332 (Vwrite_region_annotation_buffers): Now static.
11334 * eval.c: Make symbols static if they're not exported.
11335 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11336 * lisp.h (backtrace_list): Remove decl.
11338 * emacs.c: Make symbols static if they're not exported.
11339 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11340 (fatal_error_code, fatal_error_signal_hook, standard_args):
11342 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11343 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11344 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11345 * lisp.h (fatal_error_signal_hook): Remove decl.
11346 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11348 * editfns.c: Move a (normally-unused) function to its only use.
11349 * editfns.c, lisp.h (get_operating_system_release): Remove.
11350 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11351 worth the hassle of breaking this out.
11353 * xterm.c: Make symbols static if they're not exported.
11354 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11355 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11356 (x_destroy_window, x_delete_display):
11358 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11359 (x_mouse_leave): Remove; unused.
11360 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11361 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11362 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11364 (x_mouse_leave): Declare only if WINDOWSNT.
11365 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11366 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11369 * ftxfont.c: Make symbols static if they're not exported.
11370 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11372 * font.h (ftxfont_driver): Likewise.
11374 * xfns.c: Make symbols static if they're not exported.
11375 (x_last_font_name, x_display_info_for_name):
11376 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11377 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11378 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11379 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11380 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11381 (last_show_tip_args): Now static.
11382 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11383 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11384 (x_screen_planes): Remove; unused.
11385 * dispextern.h (x_screen_planes): Remove decl.
11387 * dispnew.c: Make symbols static if they're not exported.
11388 * dispextern.h (redraw_garbaged_frames, scrolling):
11389 (increment_row_positions): Remove.
11390 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11391 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11393 (redraw_garbaged_frames): Remove; unused.
11395 * xfaces.c: Make symbols static if they're not exported.
11396 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11398 * xterm.h (defined_color): Remove decls.
11399 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11400 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11401 (menu_face_changed_default, defined_color, free_realized_face):
11402 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11403 (ascii_face_of_lisp_face): Remove; unused.
11405 * xdisp.c: Make symbols static if they're not exported.
11406 * dispextern.h (scratch_glyph_row, window_box_edges):
11407 (glyph_to_pixel_coords, set_cursor_from_row):
11408 (get_next_display_element, set_iterator_to_next):
11409 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11410 (show_mouse_face): Remove decls
11411 * frame.h (message_buf_print): Likewise.
11412 * lisp.h (pop_message, set_message, check_point_in_composition):
11414 * xterm.h (set_vertical_scroll_bar): Likewise.
11415 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11416 (message_buf_print, scratch_glyph_row, displayed_buffer):
11417 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11418 (get_next_display_element, show_mouse_face, window_box_edges):
11419 (frame_to_window_pixel_xy, check_point_in_composition):
11420 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11421 (glyph_to_pixel_coords): Remove; unused.
11423 * dired.c (file_name_completion): Now static.
11425 * dbusbind.c (xd_in_read_queued_messages): Now static.
11427 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11428 * data.c (circular_list_error): Remove.
11430 * commands.h (last_point_position, last_point_position_buffer):
11431 (last_point_position_window): Remove decls.
11432 * keyboard.c: Make these variables static.
11434 * coding.h (coding, code_convert_region, encode_coding_gap):
11436 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11437 (iso_code_class, detect_coding, code_convert_region): Now static.
11438 (encode_coding_gap): Remove; unused.
11440 * chartab.c (chartab_chars, chartab_bits): Now static.
11442 * charset.h (charset_iso_8859_1): Remove decl.
11443 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11446 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11447 * ccl.c (Vccl_program_table): Now static.
11448 (check_ccl_update): Remove; unused.
11450 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11451 * category.h: ... from here.
11452 * category.c (check_category_table, set_category_set): Now static.
11454 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11455 * lisp.h: Remove these decls.
11457 * buffer.c (buffer_count): Remove unused var.
11459 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11460 so that it's not optimized away.
11461 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11462 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11463 exported only to the debugger.
11465 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
11466 * atimer.h (run_all_atimers): Remove; not exported.
11468 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11469 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11470 was inaccessible from Lisp.
11471 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11472 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11474 alloc.c: Import and export fewer symbols, and remove unused items.
11475 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11477 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11478 it's not optimized away by whole-program optimization.
11479 (message_enable_multibyte, free_misc): Remove.
11480 (catchlist, handlerlist, mark_backtrace):
11481 Declare only if BYTE_MARK_STACK.
11482 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11483 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11484 (message_enable_multibyte): Remove decl.
11485 (free_misc, interval_free_list, float_block, float_block_index):
11486 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11487 (cons_free_list, last_marked_index):
11489 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11490 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11491 (mark_backtrace): Define only if BYTE_MARK_STACK.
11492 * xdisp.c (message_enable_multibyte): Now static.
11494 Declare Lisp_Object Q* variables to be 'static' if not exported.
11495 This makes it easier for human readers (and static analyzers)
11496 to see whether these variables are used from other modules.
11497 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11498 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11499 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11500 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11501 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11502 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11503 * xmenu.c, xselect.c:
11504 Declare Q* vars static if they are not used in other modules.
11505 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11506 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11507 Remove decls of unexported vars.
11508 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11510 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11512 Make Emacs functions such as Fatom 'static' by default.
11513 This makes it easier for human readers (and static analyzers)
11514 to see whether these functions can be called from other modules.
11515 DEFUN now defines a static function. To make the function external
11516 so that it can be used in other C modules, use the new macro DEFUE.
11517 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11518 (Finit_image_library):
11519 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11520 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11521 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11522 Remove decls, since these functions are now static.
11523 (Funintern, Fget_internal_run_time): New decls, since these functions
11524 were already external.
11526 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11527 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11528 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11529 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11530 * keyboard.c, keymap.c, lread.c:
11531 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11532 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11533 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11534 Mark functions with DEFUE instead of DEFUN,
11535 if they are used in other modules.
11536 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11537 decls for now-static functions.
11538 * buffer.h (Fdelete_overlay): Remove decl.
11539 * callproc.c (Fgetenv_internal): Mark as internal.
11540 * composite.c (Fremove_list_of_text_properties): Remove decl.
11541 (Fcomposition_get_gstring): New forward static decl.
11542 * composite.h (Fcomposite_get_gstring): Remove decl.
11543 * dired.c (Ffile_attributes): New forward static decl.
11544 * doc.c (Fdocumntation_property): New forward static decl.
11545 * eval.c (Ffetch_bytecode): New forward static decl.
11546 (Funintern): Remove extern decl; now in .h file where it belongs.
11547 * fileio.c (Fmake_symbolic_link): New forward static decl.
11548 * image.c (Finit_image_library): New forward static decl.
11549 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11550 * intervals.h (Fprevious_property_change):
11551 (Fremove_list_of_text_properties): Remove decls.
11552 * keyboard.c (Fthis_command_keys): Remove decl.
11553 (Fcommand_execute): New forward static decl.
11554 * keymap.c (Flookup_key): New forward static decl.
11555 (Fcopy_keymap): Now static.
11556 * keymap.h (Flookup_key): Remove decl.
11557 * process.c (Fget_process): New forward static decl.
11558 (Fprocess_datagram_address): Mark as internal.
11559 * syntax.c (Fsyntax_table_p): New forward static decl.
11560 (skip_chars): Remove duplicate decl.
11561 * textprop.c (Fprevious_property_change): New forward static decl.
11562 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11564 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11565 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11567 * editfns.c (Fformat): Remove unreachable code.
11569 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11571 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11574 2011-04-13 Eli Zaretskii <eliz@gnu.org>
11576 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11577 when at ZV. (Bug#8487)
11579 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11581 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11583 * keyboard.c (parse_tool_bar_item): Likewise.
11584 * sound.c (sound_cleanup, alsa_close): Likewise.
11585 * termcap.c (tgetent): Likewise.
11586 * xfns.c (x_default_font_parameter): Likewise.
11587 * xsettings.c (read_and_apply_settings): Likewise.
11589 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11590 (overrun_check_free): Protoize.
11592 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11594 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11595 since callers should never pass a negative size.
11596 Change the signature to match that of plain 'read' and 'write'; see
11597 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11598 * lisp.h: Update prototypes of emacs_write and emacs_read.
11600 2011-04-11 Eli Zaretskii <eliz@gnu.org>
11602 * xdisp.c (redisplay_window): Don't try to determine the character
11603 position of the scroll margin if the window start point w->startp
11604 is outside the buffer's accessible region. (Bug#8468)
11606 2011-04-10 Eli Zaretskii <eliz@gnu.org>
11608 Fix write-region and its subroutines for buffers > 2GB.
11609 * fileio.c (a_write, e_write): Modify declaration of arguments and
11610 local variables to support buffers larger than 2GB.
11611 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11613 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11614 argument, local variables, and return value.
11616 * lisp.h: Update prototypes of emacs_write and emacs_read.
11618 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11620 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
11622 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11624 Fix more problems found by GCC 4.6.0's static checks.
11626 * xdisp.c (vmessage): Use a better test for character truncation.
11628 * charset.c (load_charset_map): <, not <=, for optimization,
11629 and to avoid potential problems with integer overflow.
11630 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
11631 * casetab.c (set_identity, shuffle): Likewise.
11632 * editfns.c (Fformat): Likewise.
11633 * syntax.c (skip_chars): Likewise.
11635 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11636 This also lets GCC 4.6.0 generate slightly better loop code.
11638 * callint.c (Fcall_interactively): <, not <=, for optimization.
11639 (Fcall_interactively): Count the number of arguments produced,
11640 not the number of arguments given. This is simpler and lets GCC
11641 4.6.0 generate slightly better code.
11643 * ftfont.c: Distingish more carefully between FcChar8 and char.
11644 The previous code passed unsigned char * to a functions like
11645 strlen and xstrcasecmp that expect char *, which does not
11646 conform to the C standard.
11647 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11648 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11649 char * when the C standard requires it.
11651 * keyboard.c (read_char): Remove unused var.
11653 * eval.c: Port to Windows vsnprintf (Bug#8435).
11654 Include <limits.h>.
11655 (SIZE_MAX): Define if the headers do not.
11656 (verror): Do not give up if vsnprintf returns a negative count.
11657 Instead, grow the buffer. This ports to Windows vsnprintf, which
11658 does not conform to C99. Problem reported by Eli Zaretskii.
11659 Also, simplify the allocation scheme, by avoiding the need for
11660 calling realloc, and removing the ALLOCATED variable.
11662 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11664 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11665 But keep the doprint source code for now, as we might revamp it
11666 and use it again (Bug#8435).
11667 * lisp.h (doprnt): Remove.
11668 * Makefile.in (base_obj): Remove doprnt.o.
11669 * deps.mk (doprnt.o): Remove.
11671 error: Print 32- and 64-bit integers portably (Bug#8435).
11672 Without this change, on typical 64-bit hosts error ("...%d...", N)
11673 was used to print both 32- and 64-bit integers N, which relied on
11674 undefined behavior.
11675 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
11676 * lisp.h (error, verror): Mark as printf-like functions.
11677 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11678 Report overflow in size calculations when allocating printf buffer.
11679 Do not truncate output string at its first null byte.
11680 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11681 Truncate the output at a character boundary, since vsnprintf does not
11683 * charset.c (check_iso_charset_parameter): Convert internal
11684 character to string before calling 'error', since %c now has the
11686 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11687 overflow when computing char to be passed to 'error'. Do not
11688 pass Lisp_Object to 'error'; pass the integer instead.
11689 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11690 formatted with plain %d.
11692 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11694 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11696 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11698 * xterm.c (x_catch_errors): Remove duplicate declaration.
11700 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11702 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11704 2011-04-10 Jim Meyering <meyering@redhat.com>
11706 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11707 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11708 return ssize_t not "int", and use size_t as the buffer length.
11709 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11710 * gnutls.h: Update declarations.
11711 * process.c (read_process_output): Use ssize_t, to match.
11712 (send_process): Likewise.
11714 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11716 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11718 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11720 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11721 Use unsigned char, to match FcChar8 type definition.
11723 * xterm.c (handle_one_xevent):
11724 * xmenu.c (create_and_show_popup_menu):
11725 * xselect.c (x_decline_selection_request)
11726 (x_reply_selection_request): Avoid type-punned deref of X events.
11728 2011-04-09 Eli Zaretskii <eliz@gnu.org>
11730 Fix some uses of `int' instead of EMACS_INT.
11731 * search.c (string_match_1, fast_string_match)
11732 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11733 (scan_buffer, find_next_newline_no_quit)
11734 (find_before_next_newline, search_command, Freplace_match)
11735 (Fmatch_data): Make some `int' variables be EMACS_INT.
11737 * xdisp.c (display_count_lines): 3rd argument and return value now
11738 EMACS_INT. All callers changed.
11739 (pint2hrstr): Last argument is now EMACS_INT.
11741 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11742 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11743 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11744 (decode_coding_utf_16, decode_coding_emacs_mule)
11745 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11746 (decode_coding_ccl, decode_coding_charset)
11747 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11748 (decode_coding_iso_2022, decode_coding_emacs_mule)
11749 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11750 <char_offset, last_offset>: Declare EMACS_INT.
11751 (encode_coding_utf_8, encode_coding_utf_16)
11752 (encode_coding_emacs_mule, encode_invocation_designation)
11753 (encode_designation_at_bol, encode_coding_iso_2022)
11754 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11755 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11757 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11758 (encode_invocation_designation): Last argument P_NCHARS is now
11760 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11761 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11763 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11766 * ccl.c (Fccl_execute_on_string): Declare some variables
11769 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
11771 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11773 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11775 * process.c (Fformat_network_address): Doc fix.
11777 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11779 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
11781 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
11783 * keyboard.c (read_char): Call Lisp function help-form-show,
11784 instead of using internal_with_output_to_temp_buffer.
11785 (Qhelp_form_show): New var.
11786 (syms_of_keyboard): Use DEFSYM macro.
11788 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11790 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11792 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
11794 * process.c (Flist_processes): Remove to Lisp.
11795 (list_processes_1): Delete.
11797 2011-04-06 Eli Zaretskii <eliz@gnu.org>
11799 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11801 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11803 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
11805 Fix more problems found by GCC 4.6.0's static checks.
11807 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11809 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11811 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
11813 * xdisp.c (vmessage): Mark as a printf-like function.
11815 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11817 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11819 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11820 printf-like functions.
11821 (tiff_load): Add casts to remove these marks before passing them
11822 to system-supplied API.
11824 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11826 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11827 This avoids several warnings with gcc -Wstrict-overflow.
11828 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11829 directly, rather than having caller test rule sign. This avoids
11830 some unnecessary tests.
11831 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11832 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11833 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
11835 * xfont.c (xfont_text_extents): Remove var that was set but not used.
11836 (xfont_open): Avoid unnecessary tests.
11838 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11840 * composite.h, composite.c (composition_gstring_put_cache):
11841 Use EMACS_INT, not int, for length.
11843 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11844 breaking out part of COMPOSITION_DECODE_RULE.
11845 (COMPOSITION_DECODE_RULE): Use it.
11846 * composite.c (get_composition_id): Remove unused local vars,
11847 by using the new macro.
11849 * textprop.c (set_text_properties_1): Change while to do-while,
11850 since the condition is always true at first.
11852 * intervals.c (graft_intervals_into_buffer): Mark var as used.
11853 (interval_deletion_adjustment): Return unsigned value.
11856 * process.c (list_processes_1, create_pty, read_process_output):
11857 (exec_sentinel): Remove vars that were set but not used.
11858 (create_pty): Remove unnecessary "volatile"s.
11859 (Fnetwork_interface_info): Avoid possibility of int overflow.
11860 (read_process_output): Do adaptive read buffering even if carryover.
11861 (read_process_output): Simplify nbytes computation if buffered.
11863 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11865 * syntax.c (scan_words): Remove var that was set but not used.
11866 (update_syntax_table): Use unsigned instead of int.
11868 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
11869 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
11870 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
11872 * print.c (print_error_message): Avoid int overflow.
11874 * font.c (font_list_entities): Redo for clarity,
11875 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11877 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
11878 (font_score): Avoid potential overflow in diff calculation.
11880 * fns.c (substring_both): Remove var that is set but not used.
11881 (sxhash): Redo loop for clarity and to avoid wraparound warning.
11883 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11885 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11886 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11887 can always succeed if overflow has undefined behavior.
11889 * search.c (boyer_moore, wordify): Remove vars set but not used.
11890 (wordify): Omit three unnecessary tests.
11892 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11893 All callers changed. This avoids the need for an unused var.
11895 * casefiddle.c (casify_region): Remove var that is set but not used.
11897 * dired.c (file_name_completion): Remove var that is set but not used.
11899 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11901 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
11902 (Finsert_file_contents): Remove unnecessary code checking fd.
11904 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11905 Check for integer overflow on size calculations.
11907 * buffer.c (Fprevious_overlay_change): Remove var that is set
11910 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11911 Remove vars that are set but not used.
11912 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
11913 (timer_check_2): Mark vars as initialized.
11915 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11917 * image.c (lookup_image): Remove var that is set but not used.
11918 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
11920 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11921 that are set but not used.
11923 * xfns.c (make_invisible_cursor): Don't return garbage
11924 if XCreateBitmapFromData fails (Bug#8410).
11926 * xselect.c (x_get_local_selection, x_handle_property_notify):
11927 Remove vars that are set but not used.
11929 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
11930 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
11932 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11933 Remove var that is set but not used.
11934 (scroll_bar_windows_size): Now size_t, not int.
11935 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11936 Check for overflow.
11938 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11939 (map_tty_color) [!defined MSDOS]: Likewise.
11941 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11943 * coding.c: Remove vars that are set but not used.
11944 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11945 All callers changed.
11946 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11947 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11948 (decode_coding_charset): Remove vars that are set but not used.
11950 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11951 that is set but not used.
11953 * print.c (print_object): Remove var that is set but not used.
11955 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
11956 The gnulib version avoids calling malloc in the usual case,
11957 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11958 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11959 * filelock.c (current_lock_owner): Likewise.
11960 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11961 * sysdep.c: Include allocator.h, careadlinkat.h.
11962 (emacs_no_realloc_allocator): New static constant.
11963 (emacs_readlink): New function.
11964 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11965 ../lib/careadlinkat.h.
11967 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11969 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11970 first non-nil return value).
11972 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11974 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11975 if not defined (Bug#8403).
11977 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11979 * xdisp.c (display_count_lines): Remove parameter `start',
11980 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11981 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11982 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11983 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11984 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11985 and thereabouts. All callers changed.
11986 (get_per_char_metric): Remove parameter `f', unused since
11987 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11989 2011-04-02 Jim Meyering <meyering@redhat.com>
11991 do not dereference NULL upon failed strdup
11992 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11993 (ns_get_family): Likewise.
11995 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11997 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11999 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12001 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12004 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12006 Add lexical binding.
12008 * window.c (Ftemp_output_buffer_show): New fun.
12009 (Fsave_window_excursion):
12010 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12012 * lread.c (lisp_file_lexically_bound_p): New function.
12013 (Fload): Bind Qlexical_binding.
12014 (readevalloop): Remove `evalfun' arg.
12015 Bind Qinternal_interpreter_environment.
12016 (Feval_buffer): Bind Qlexical_binding.
12017 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12019 (syms_of_lread): Declare `lexical-binding'.
12021 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12023 * keyboard.c (eval_dyn): New fun.
12024 (menu_item_eval_property): Use it.
12026 * image.c (parse_image_spec): Use Ffunctionp.
12028 * fns.c (concat, mapcar1): Accept byte-code-functions.
12030 * eval.c (Fsetq): Handle lexical vars.
12031 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12032 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12033 (FletX, Flet): Obey lexical binding.
12034 (Fcommandp): Handle closures.
12035 (Feval): New `lexical' arg.
12036 (eval_sub): New function extracted from Feval. Use it almost
12037 everywhere where Feval was used. Look up vars in lexical env.
12039 (Ffunctionp): Move from subr.el.
12040 (Ffuncall): Handle closures.
12041 (apply_lambda): Remove `eval_flags'.
12042 (funcall_lambda): Handle closures and new byte-code-functions.
12043 (Fspecial_variable_p): New function.
12044 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12045 but without exporting it to Lisp.
12047 * doc.c (Fdocumentation, store_function_docstring):
12048 * data.c (Finteractive_form): Handle closures.
12050 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12053 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12055 (exec_byte_code): New function extracted from Fbyte_code to handle new
12056 calling convention for byte-code-functions. Add new byte-codes.
12058 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
12060 * alloc.c (Fmake_symbol): Init new `declared_special' field.
12062 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12064 * xdisp.c (redisplay_internal): Fix prototype.
12066 2011-03-31 Eli Zaretskii <eliz@gnu.org>
12068 * xdisp.c (SCROLL_LIMIT): New macro.
12069 (try_scrolling): Use it when setting scroll_limit.
12070 Limit scrolling to 100 screen lines.
12071 (redisplay_window): Even when falling back on "recentering",
12072 position point in the window according to scroll-conservatively,
12073 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12075 (try_scrolling): When point is above the window, allow searching
12076 as far as scroll_max, or one screenful, to compute vertical
12077 distance from PT to the scroll margin position. This prevents
12078 try_scrolling from unnecessarily failing when
12079 scroll-conservatively is set to a value slightly larger than the
12080 window height. Clean up the case of PT below the margin at bottom
12081 of window: scroll_max can no longer be INT_MAX. When aggressive
12082 scrolling is in use, don't let point enter the opposite scroll
12083 margin as result of the scroll.
12084 (syms_of_xdisp) <scroll-conservatively>: Document the
12085 threshold of 100 lines for never-recentering scrolling.
12087 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12089 * dispextern.h (move_it_by_lines):
12090 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12091 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12092 (message_log_check_duplicate): Remove parameters `prev_bol' and
12093 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12094 (redisplay_internal): Remove parameter `preserve_echo_area',
12095 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12097 * indent.c (Fvertical_motion):
12098 * window.c (window_scroll_pixel_based, Frecenter):
12099 Don't pass `need_y_p' to `move_it_by_lines'.
12101 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12103 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12104 steal a few bits to be more compact.
12105 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12106 Remove unneeded casts.
12108 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12110 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12112 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12113 binding" message (bug#7967).
12115 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12117 Fix more problems found by GCC 4.6.0's static checks.
12119 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12120 Remove unused local var.
12122 * editfns.c (Fmessage_box): Remove unused local var.
12124 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12125 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12126 Omit unused local vars.
12127 * window.c (shrink_windows): Omit unused local var.
12128 * menu.c (digest_single_submenu): Omit unused local var.
12129 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12130 Omit unused local var.
12132 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12133 Don't assume string length fits in int.
12134 (keyremap_step, read_key_sequence): Use size_t for sizes.
12135 (read_key_sequence): Don't check last_real_key_start redundantly.
12137 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12138 instead of alloca (Bug#8344).
12140 * eval.c (Fbacktrace): Don't assume nargs fits in int.
12141 (Fbacktrace_frame): Don't assume nframes fits in int.
12143 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12145 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12148 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12150 * cm.c (calccost): Turn while-do into do-while, for clarity.
12152 * keyboard.c (syms_of_keyboard): Use the same style as later
12153 in this function when indexing through an array. This also
12154 works around GCC bug 48267.
12156 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12158 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12160 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12161 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12163 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12164 This avoids undefined behavior on integer overflow, and is a bit
12165 more convenient anyway since it is compared to a size_t variable.
12167 Variadic C functions now count arguments with size_t, not int.
12168 This avoids an unnecessary limitation on 64-bit machines, which
12169 caused (substring ...) to crash on large vectors (Bug#8344).
12170 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12171 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
12172 All variadic functions and their callers changed accordingly.
12173 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12174 * data.c (arith_driver, float_arith_driver): Likewise.
12175 * editfns.c (general_insert_function): Likewise.
12176 * eval.c (struct backtrace.nargs, interactive_p)
12177 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12178 (funcall_lambda, mark_backtrace): Likewise.
12179 * fns.c (concat): Likewise.
12180 * frame.c (x_set_frame_parameters): Likewise.
12181 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12182 0 if not found, not -1. All callers changed.
12184 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12185 (stack_copy_size): Now size_t, not int.
12186 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12188 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12190 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12191 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12192 All callers changed.
12194 * lisp.h (multibyte_char_to_unibyte):
12195 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12196 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12197 * character.h (CHAR_TO_BYTE8):
12198 * cmds.c (internal_self_insert):
12199 * editfns.c (general_insert_function):
12200 * keymap.c (push_key_description):
12201 * search.c (Freplace_match):
12202 * xdisp.c (message_dolog, set_message_1): All callers changed.
12204 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12206 * keyboard.c (safe_run_hook_funcall): New function.
12207 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12208 don't set the hook to nil, but remove the offending function instead.
12209 (Qcommand_hook_internal): Remove, unused.
12210 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12211 Vcommand_hook_internal.
12213 * eval.c (enum run_hooks_condition): Remove.
12214 (funcall_nil, funcall_not): New functions.
12215 (run_hook_with_args): Call each function through a `funcall' argument.
12216 Remove `cond' argument, now redundant.
12217 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12218 (Frun_hook_with_args_until_failure): Adjust accordingly.
12219 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12221 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12223 * dispextern.h (string_buffer_position): Remove declaration.
12225 * print.c (strout): Remove parameter `multibyte', unused since
12226 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12228 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12229 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12230 All callers changed.
12232 * w32.c (_wsa_errlist): Use braces for struct initializers.
12234 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12235 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12236 All callers changed.
12237 (string_buffer_position): Likewise. Also, make static (it's never
12238 used outside xdisp.c).
12239 (cursor_row_p): Remove parameter `w', unused since
12240 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12241 (decode_mode_spec): Remove parameter `precision', introduced during
12242 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12243 All callers changed.
12245 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12247 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12249 2011-03-27 Anders Lindgren <andlind@gmail.com>
12251 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12252 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12253 (ns_update_auto_hide_menu_bar): New functions.
12254 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12255 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12256 ns_constrain_all_frames.
12257 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12258 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12260 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12262 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12264 2011-03-27 Glenn Morris <rgm@gnu.org>
12266 * syssignal.h: Replace RETSIGTYPE with void.
12267 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12268 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12269 Replace SIGTYPE with void everywhere.
12270 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12271 * s/template.h (SIGTYPE): Remove commented out definition.
12273 2011-03-26 Eli Zaretskii <eliz@gnu.org>
12275 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12276 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12278 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
12280 * w32.c (read_unc_volume): Use parameter `henum', instead of
12281 global variable `wget_enum_handle'.
12283 * keymap.c (describe_vector): Remove parameters `indices' and
12284 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12285 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12287 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12289 * keyboard.c (timer_check): Remove parameter `do_it_now',
12290 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12291 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12292 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12294 * keyboard.c (read_char):
12295 * w32menu.c (w32_menu_display_help):
12296 * xmenu.c (show_help_event, menu_help_callback):
12297 Adjust calls to `show_help_echo'.
12299 * gtkutil.c (xg_maybe_add_timer):
12300 * keyboard.c (readable_events):
12301 * process.c (wait_reading_process_output):
12302 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12304 * insdel.c (adjust_markers_gap_motion):
12305 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12306 (gap_left, gap_right): Don't call it.
12308 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
12310 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12311 incurred during fontification.
12313 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12315 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12316 (DEFVAR_PER_BUFFER): Don't pass it.
12318 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12319 (scrolling_window): Don't pass it.
12321 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12323 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12325 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12327 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12328 of variables specific to SELinux and computation of `encoded_absname'.
12330 * image.c (XPutPixel): Remove unused variable `height'.
12332 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12334 * unexw32.c (get_section_info): Remove unused variable `section'.
12336 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12337 (system_process_attributes): Remove unused variable `sess'.
12338 (sys_read): Remove unused variable `err'.
12340 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12341 (w32_wnd_proc): Remove unused variable `isdead'.
12342 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12343 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12344 (x_create_tip_frame): Remove unused variable `tem'.
12346 * w32inevt.c (w32_console_read_socket):
12347 Remove unused variable `no_events'.
12349 * w32term.c (x_draw_composite_glyph_string_foreground):
12350 Remove unused variable `width'.
12352 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
12354 * w32term.c (x_set_glyph_string_clipping):
12355 Don't pass uninitialized region to CombineRgn.
12357 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
12359 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12360 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12361 (Fx_close_connection): Remove unused variable `i'.
12363 * w32font.c (w32font_draw): Return number of glyphs.
12364 (w32font_open_internal): Remove unused variable `i'.
12365 (w32font_driver): Add missing initializer.
12367 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12368 (fill_in_menu): Remove unused variable `items_added'.
12370 * w32term.c (last_mouse_press_frame): Remove static global variable.
12371 (w32_clip_to_row): Remove unused variable `f'.
12372 (x_delete_terminal): Remove unused variable `i'.
12374 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12375 (NOTHING): Remove unused static global variable.
12376 (uniscribe_check_otf): Remove unused variable `table'.
12377 (uniscribe_font_driver): Add missing initializers.
12379 2011-03-23 Julien Danjou <julien@danjou.info>
12381 * term.c (Fsuspend_tty, Fresume_tty):
12382 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12383 * window.c (temp_output_buffer_show):
12384 * insdel.c (signal_before_change):
12385 * frame.c (Fhandle_switch_frame):
12386 * fileio.c (Fdo_auto_save):
12387 * emacs.c (Fkill_emacs):
12388 * editfns.c (save_excursion_restore):
12389 * cmds.c (internal_self_insert):
12390 * callint.c (Fcall_interactively):
12391 * buffer.c (Fkill_all_local_variables):
12392 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12394 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
12395 unconditionally since it does the check itself.
12397 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
12399 Fix more problems found by GCC 4.5.2's static checks.
12401 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12402 the first time through the loop, since we know p0 < p1 then.
12403 This also avoids a gcc -Wstrict-overflow warning.
12405 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12406 leading to a memory leak, possible in functions like
12407 load_charset_map_from_file that can allocate an unbounded number
12408 of objects (Bug#8318).
12410 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12411 that could (at least in theory) be that large.
12413 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12414 This is less likely to overflow, and avoids undefined behavior if
12415 overflow does occur. All callers changed. Use strtoul to scan
12416 for the unsigned long integer.
12417 (pint2hrstr): Simplify and tune code slightly.
12418 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
12420 * scroll.c (do_scrolling): Work around GCC bug 48228.
12421 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12423 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12424 This also avoids a warning with gcc -Wstrict-overflow.
12425 (validate_x_resource_name): Simplify count usage.
12426 This also avoids a warning with gcc -Wstrict-overflow.
12428 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12431 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
12433 * process.c (Fmake_network_process): Use socklen_t, not int,
12434 where POSIX says socklen_t is required in portable programs.
12435 This fixes a porting bug on hosts like 64-bit HP-UX, where
12436 socklen_t is wider than int (Bug#8277).
12437 (Fmake_network_process, server_accept_connection):
12438 (wait_reading_process_output, read_process_output):
12441 * process.c: Rename or move locals to avoid shadowing.
12442 (list_processes_1, Fmake_network_process):
12443 (read_process_output_error_handler, exec_sentinel_error_handler):
12444 Rename or move locals.
12445 (Fmake_network_process): Define label "retry_connect" only if needed.
12446 (Fnetwork_interface_info): Fix pointer signedness.
12447 (process_send_signal): Add cast to avoid pointer signedness problem.
12448 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
12449 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
12451 Make tparam.h and terminfo.c consistent.
12452 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12453 Include tparam.h instead, since it declares them.
12454 * cm.h (PC): Remove extern decl; tparam.h now does this.
12455 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12456 * terminfo.c: Include tparam.h, to check interfaces.
12457 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12458 (tparam): Adjust signature to match interface in tparam.h;
12459 this removes some undefined behavior. Check that outstring and len
12460 are zero, which they always are with Emacs.
12461 * tparam.h (PC, BC, UP): New extern decls.
12463 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
12464 (xftfont_open): Rename locals to avoid shadowing.
12466 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
12467 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12468 (OTF_TAG_SYM): Omit macro if not needed.
12469 (ftfont_list): Remove unused local.
12470 (get_adstyle_property, ftfont_pattern_entity):
12471 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12472 Rename locals to avoid shadowing.
12474 * xfont.c (xfont_list_family): Mark var as initialized.
12476 * xml.c (make_dom): Now static.
12478 * composite.c (composition_compute_stop_pos): Rename local to
12480 (composition_reseat_it): Remove unused locals.
12481 (find_automatic_composition, composition_adjust_point): Likewise.
12482 (composition_update_it): Mark var as initialized.
12483 (find_automatic_composition): Mark vars as initialized,
12484 with a FIXME (Bug#8290).
12486 character.h: Rename locals to avoid shadowing.
12487 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12488 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12489 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12490 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12491 to avoid shadowing.
12493 * textprop.c (property_change_between_p): Remove; unused.
12495 * intervals.c (interval_start_pos): Now static.
12497 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12499 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12500 Rename locals to avoid shadowing.
12502 * sound.c (wav_play, au_play, Fplay_sound_internal):
12503 Fix pointer signedness.
12504 (alsa_choose_format): Remove unused local var.
12505 (wav_play): Initialize a variable to 0, to prevent undefined
12506 behavior (Bug#8278).
12508 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12510 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12512 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12513 clobbering (Bug#8298).
12514 * sysdep.c (sys_subshell): Likewise.
12515 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
12517 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12518 This should get cleaned up, so that child_setup has the
12519 same signature on all platforms.
12521 * callproc.c (call_process_cleanup): Now static.
12522 (relocate_fd): Rename locals to avoid shadowing.
12524 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
12526 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12527 not to be necessary, and produces flickering.
12529 2011-03-20 Glenn Morris <rgm@gnu.org>
12531 * config.in: Remove file.
12533 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
12535 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12536 are now in src/globals.h.
12537 (syms_of_minibuf): Remove spurious & from previous change.
12539 2011-03-20 Leo Liu <sdl.web@gmail.com>
12541 * minibuf.c (completing-read-function): New variable.
12542 (completing-read-default): Rename from completing-read.
12543 (completing-read): Call completing-read-function.
12545 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
12547 * xfaces.c (Fx_load_color_file):
12548 Read color file from absolute filename (bug#8250).
12550 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
12552 * makefile.w32-in: Update dependencies.
12554 2011-03-17 Eli Zaretskii <eliz@gnu.org>
12556 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12558 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12560 Fix more problems found by GCC 4.5.2's static checks.
12562 * process.c (make_serial_process_unwind, send_process_trap):
12563 (sigchld_handler): Now static.
12565 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12566 That way, the code declares only the vars that it needs.
12567 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12568 * s/cygwin.h (PTY_ITERATION): Likewise.
12569 * s/darwin.h (PTY_ITERATION): Likewise.
12570 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12572 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12573 * process.c (allocate_pty): Don't declare stb unless it's needed.
12575 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
12576 (CONSTANTLIM): Remove; unused.
12577 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12578 Define only if needed.
12580 * unexelf.c (unexec): Name an expression,
12581 to avoid gcc -Wbad-function-cast warning.
12582 Use a different way to cause a compilation error if anyone uses
12583 n rather than nn, a way that does not involve shadowing.
12584 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
12586 * deps.mk (unexalpha.o): Remove; unused.
12588 New file unexec.h, the (simple) interface for unexec (Bug#8267).
12589 * unexec.h: New file.
12590 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12591 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12592 Depend on unexec.h.
12593 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12594 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12595 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
12596 Change as necessary to match prototype in unexec.h.
12598 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12600 (back_comment, skip_chars): Mark vars as initialized.
12602 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12603 Rename locals to avoid shadowing.
12605 * lread.c (read1): Rewrite so as not to use empty "else".
12606 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
12608 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12610 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12611 warning when compiling print.c.
12613 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12614 instead of using an uninitialized var.
12615 (font_sort_entities): Mark var as initialized.
12617 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12619 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12620 pointers to constants.
12621 (font_parse_fcname): Remove unused vars.
12622 (font_delete_unmatched): Now static.
12623 (font_get_spec): Remove; unused.
12624 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12625 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12626 Rename or move locals to avoid shadowing.
12628 * fns.c (require_nesting_list, require_unwind): Now static.
12629 (Ffillarray): Rename locals to avoid shadowing.
12631 * floatfns.c (domain_error2): Define only if needed.
12632 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
12634 * alloc.c (mark_backtrace): Move decl from here ...
12635 * lisp.h: ... to here, so that it can be checked.
12637 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
12638 (Fdefvar): Rewrite so as not to use empty "else".
12639 (lisp_indirect_variable): Name an expression,
12640 to avoid gcc -Wbad-function-cast warning.
12641 (Fdefvar): Rename locals to avoid shadowing.
12643 * callint.c (quotify_arg, quotify_args): Now static.
12644 (Fcall_interactively): Rename locals to avoid shadowing.
12645 Use const pointer when appropriate.
12647 * lisp.h (get_system_name, get_operating_system_release):
12648 Move decls here, to check interfaces.
12649 * process.c (get_operating_system_release): Move decl to lisp.h.
12650 * xrdb.c (get_system_name): Likewise.
12651 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12652 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12653 some of which prompt warnings from gcc -Wbad-function-cast.
12654 (Fformat_time_string, Fencode_time, Finsert_char):
12655 (Ftranslate_region_internal, Fformat):
12656 Rename or remove local vars to avoid shadowing.
12657 (Ftranslate_region_internal): Mark var as initialized.
12659 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12662 * lisp.h (eassert): Check that the argument compiles, even if
12663 ENABLE_CHECKING is not defined.
12665 * data.c (Findirect_variable): Name an expression, to avoid
12666 gcc -Wbad-function-cast warning.
12667 (default_value, arithcompare, arith_driver, arith_error): Now static.
12668 (store_symval_forwarding): Rename local to avoid shadowing.
12669 (Fmake_variable_buffer_local, Fmake_local_variable):
12670 Mark variables as initialized.
12671 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
12673 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
12674 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12675 Rename locals to avoid shadowing.
12676 (mark_stack): Move local variables into the #ifdef region where
12678 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12679 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12681 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12682 (GC_STRING_CHARS): Remove; not used.
12683 (Fmemory_limit): Cast sbrk's returned value to char *.
12685 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12686 avoids undefined behavior in theory.
12688 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12690 Use functions, not macros, for up- and down-casing (Bug#8254).
12691 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12692 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12693 to use the following functions instead of these macros.
12694 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12695 EMACS_INT, since callers assume the returned value fits in int.
12696 (upcase1): Likewise, for UPCASE_TABLE.
12697 (uppercasep, lowercasep, upcase): New static inline functions.
12698 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
12699 the race-condition problem in the old DOWNCASE.
12701 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12702 Rename locals to avoid shadowing.
12703 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
12704 (regex_compile, re_search_2, re_match_2_internal):
12705 Remove unused local vars.
12706 (FREE_VAR): Rewrite so as not to use empty "else",
12707 which gcc can warn about.
12708 (regex_compile, re_match_2_internal): Mark locals as initialized.
12709 (RETALLOC_IF): Define only if needed.
12710 (WORDCHAR_P): Likewise. This one is never needed, but is used
12711 only in a comment talking about a compiler bug, so put inside
12712 the #if 0 of that comment.
12713 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12714 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12717 * search.c (boyer_moore): Rename locals to avoid shadowing.
12718 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12719 (PREV_CHAR_BOUNDARY): Likewise.
12721 * search.c (simple_search): Remove unused var.
12723 * dired.c (compile_pattern): Move decl from here ...
12724 * lisp.h: ... to here, so that it can be checked.
12725 (struct re_registers): New forward decl.
12727 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12729 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12731 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12732 Rename locals to avoid shadowing.
12733 (Fvertical_motion): Mark locals as initialized.
12735 * casefiddle.c (casify_object, casify_region): Now static.
12736 (casify_region): Mark local as initialized.
12738 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12740 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12741 New macros, so that the caller can use some names other than
12742 gcpro1, gcpro2, etc.
12743 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12745 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12746 argument, for consistency with GCPRO2_VAR, etc: it is now the
12747 prefix of the variable, not the variable itself. All uses
12749 * dired.c (directory_files_internal, file_name_completion):
12750 Rename locals to avoid shadowing.
12752 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12753 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12754 dired.c's scmp function, had undefined behavior.
12755 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12756 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12757 * buffer.h: ... to here, because these macros use current_buffer,
12758 and the new implementation with inline functions needs to have
12759 current_buffer in scope now, rather than later when the macros
12761 (downcase, upcase1): New static inline functions.
12762 (DOWNCASE, UPCASE1): Reimplement using these functions.
12763 This avoids undefined behavior in expressions like
12764 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12765 from race conditions in accessing the global variables
12766 case_temp1 and case_temp2.
12767 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12768 * lisp.h (case_temp1, case_temp2): Remove their decls.
12769 * character.h (ASCII_CHAR_P): Move from here ...
12770 * lisp.h: ... to here, so that the inline functions mentioned
12771 above can use them.
12773 * dired.c (directory_files_internal_unwind): Now static.
12775 * fileio.c (file_name_as_directory, directory_file_name):
12776 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12778 (file_name_as_directory): Use const pointers when appropriate.
12779 (Fexpand_file_name): Likewise. In particular, newdir might
12780 point at constant storage, so make it a const pointer.
12781 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
12782 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12784 (Fset_file_times, Finsert_file_contents, auto_save_error):
12785 Rename locals to avoid shadowing.
12787 * minibuf.c (choose_minibuf_frame_1): Now static.
12788 (Ftry_completion, Fall_completions): Rename or remove locals
12789 to avoid shadowing.
12791 * marker.c (bytepos_to_charpos): Remove; unused.
12793 * lisp.h (verify_bytepos, count_markers): New decls,
12794 so that gcc does not warn that these functions aren't declared.
12796 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12797 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
12798 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
12799 (copy_text): Remove unused local var.
12801 * filelock.c (within_one_second): Now static.
12802 (lock_file_1): Rename local to avoid shadowing.
12804 * buffer.c (fix_overlays_before): Mark locals as initialized.
12805 (fix_start_end_in_overlays): Likewise. This function should be
12806 simplified by using pointers-to-pointers, but that's a different
12808 (switch_to_buffer_1): Now static.
12809 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12810 (report_overlay_modification): Rename locals to avoid shadowing.
12812 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
12813 Fix pointer signedness issue.
12814 (sys_subshell): Mark local as volatile if checking for lint,
12815 to suppress a gcc -Wclobbered warning that does not seem to be right.
12816 (MAXPATHLEN): Define only if needed.
12818 * process.c (serial_open, serial_configure): Move decls from here ...
12819 * systty.h: ... to here, so that they can be checked.
12821 * fns.c (get_random, seed_random): Move extern decls from here ...
12822 * lisp.h: ... to here, so that they can be checked.
12824 * sysdep.c (reset_io): Now static.
12825 (wait_for_termination_signal): Remove; unused.
12827 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12828 (copy_keymap_item, append_key, push_text_char_description):
12830 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
12831 (DENSE_TABLE_SIZE): Remove; unused.
12832 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12833 (describe_map_tree):
12834 Rename locals to avoid shadowing.
12836 * keyboard.c: Declare functions static if they are not used elsewhere.
12837 (echo_char, echo_dash, cmd_error, top_level_2):
12838 (poll_for_input, handle_async_input): Now static.
12839 (read_char, kbd_buffer_get_event, make_lispy_position):
12840 (make_lispy_event, make_lispy_movement, apply_modifiers):
12841 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12842 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12843 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
12844 (read_key_sequence, read_char): Mark locals as initialized.
12845 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
12847 * keyboard.h (make_ctrl_char): New decl.
12848 (mark_kboards): Move decl here ...
12849 * alloc.c (mark_kboards): ... from here.
12851 * lisp.h (force_auto_save_soon): New decl.
12853 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
12854 (DEFINE_DUMMY_FUNCTION): New macro.
12855 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12857 (main): Add casts to avoid warnings
12858 if GCC considers string literals to be constants.
12860 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12862 * dbusbind.c: Pointer signedness fixes.
12863 (xd_signature, xd_append_arg, xd_initialize):
12864 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12865 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12866 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12867 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12869 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12870 if GCC considers string literals to be constants.
12871 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
12873 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12875 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12876 (print_preprocess, print_object): New macro to fix last change.
12878 * print.c (print_preprocess): Don't forget font objects.
12880 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
12882 * emacs.c (USAGE3): Doc fixes.
12884 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12886 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12889 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
12891 * lisp.h (VWindow_system, Qfile_name_history):
12892 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12893 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12894 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12896 * w32select.c: Don't #include "keyboard.h".
12897 (run_protected): Add extern declaration for waiting_for_input.
12899 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12900 * w32console.c (detect_input_pending, read_input_pending)
12901 (encode_terminal_code):
12902 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12903 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12904 (w32_system_caret_y, Qfile_name_history):
12905 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12906 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12907 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12908 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12909 * w32proc.c (Qlocal, report_file_error):
12910 * w32term.c (Vwindow_system, updating_frame):
12911 * w32uniscribe.c (initialized, uniscribe_font_driver):
12912 Remove unneeded extern declarations.
12914 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
12916 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
12918 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
12920 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12921 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12922 These macros can no longer be used for assignment.
12924 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12925 Assign struct members directly, instead of using BUF_BEGV etc.
12926 (record_buffer_markers, fetch_buffer_markers): New functions for
12927 recording and fetching special buffer markers.
12928 (set_buffer_internal_1, set_buffer_temp): Use them.
12930 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12932 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12934 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12935 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12937 * xdisp.c (hscroll_window_tree):
12938 (reconsider_clip_changes): Use PT instead of BUF_PT.
12940 2011-03-13 Eli Zaretskii <eliz@gnu.org>
12942 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12943 $(EMACS_ROOT)/lib/intprops.h.
12945 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12947 Fix more problems found by GCC 4.5.2's static checks.
12949 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12950 to unsigned char * to avoid compiler diagnostic.
12951 (xg_free_frame_widgets): Make it clear that a local variable is
12952 needed only if USE_GTK_TOOLTIP.
12953 (gdk_window_get_screen): Make it clear that this macro is needed
12954 only if USE_GTK_TOOLTIP.
12955 (int_gtk_range_get_value): New function, which avoids a diagnostic
12956 from gcc -Wbad-function-cast.
12957 (xg_set_toolkit_scroll_bar_thumb): Use it.
12958 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12959 diagnostic from gcc -Wbad-function-cast.
12960 (get_utf8_string, xg_get_file_with_chooser):
12961 Rename locals to avoid shadowing.
12962 (create_dialog): Move locals to avoid shadowing.
12964 * xgselect.c (xg_select): Remove unused var.
12966 * image.c (four_corners_best): Mark locals as initialized.
12967 (gif_load): Initialize transparent_p to zero (Bug#8238).
12968 Mark another local as initialized.
12969 (my_png_error, my_error_exit): Mark with NO_RETURN.
12971 * image.c (clear_image_cache): Now static.
12972 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
12973 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
12974 (x_edge_detection): Remove unnecessary cast that
12975 gcc -Wbad-function-cast diagnoses.
12976 (gif_load): Fix pointer signedness.
12977 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12978 (jpeg_load, gif_load): Rename locals to avoid shadowing.
12980 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
12982 Improve quality of tests for time stamp overflow.
12983 For example, without this patch (encode-time 0 0 0 1 1
12984 1152921504606846976) returns the obviously-bogus value (-948597
12985 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12986 reports time overflow. See
12987 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
12988 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12989 * editfns.c: Include limits.h and intprops.h.
12990 (TIME_T_MIN, TIME_T_MAX): New macros.
12991 (time_overflow): Move earlier, to before first use.
12992 (hi_time, lo_time): New functions, for an accurate test for
12993 out-of-range times.
12994 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12995 (Fget_internal_run_time): Don't assume time_t fits in int.
12996 (make_time): Use list2 instead of Fcons twice.
12997 (Fdecode_time): More accurate test for out-of-range times.
12998 (check_tm_member): New function.
12999 (Fencode_time): Use it, to test for out-of-range times.
13000 (lisp_time_argument): Don't rely on undefined left-shift and
13001 right-shift behavior when checking for time stamp overflow.
13003 * editfns.c (time_overflow): New function, refactoring common code.
13004 (Fformat_time_string, Fdecode_time, Fencode_time):
13005 (Fcurrent_time_string): Use it.
13007 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13008 * dired.c (make_time): Move to ...
13009 * editfns.c (make_time): ... here.
13010 * systime.h: Note the move.
13012 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
13014 * fringe.c (update_window_fringes): Remove unused variables.
13016 * unexmacosx.c (copy_data_segment): Also copy __got section.
13019 2011-03-12 Eli Zaretskii <eliz@gnu.org>
13021 * termcap.c [MSDOS]: Include "msdos.h".
13022 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13023 Constify `char *' arguments and their references according to
13024 prototypes in tparam.h.
13026 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
13028 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13029 Adapt all references accordingly.
13031 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13033 2011-03-11 Tom Tromey <tromey@redhat.com>
13035 * buffer.c (syms_of_buffer): Remove obsolete comment.
13037 2011-03-11 Eli Zaretskii <eliz@gnu.org>
13039 * termhooks.h (encode_terminal_code): Declare prototype.
13041 * msdos.c (encode_terminal_code): Don't declare prototype.
13043 * term.c (encode_terminal_code): Now external again, used by
13044 w32console.c and msdos.c.
13046 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13047 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
13049 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
13051 Fix some minor problems found by GCC 4.5.2's static checks.
13053 * fringe.c (update_window_fringes): Mark locals as initialized
13055 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
13057 * alloc.c (mark_fringe_data): Move decl from here ...
13058 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13059 to check its interface.
13060 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13062 * fontset.c (free_realized_fontset): Now static.
13063 (Fset_fontset_font): Rename local to avoid shadowing.
13064 (fontset_font): Mark local as initialized.
13065 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
13067 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13069 * xselect.c (x_disown_buffer_selections): Remove; not used.
13070 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
13071 (x_own_selection, Fx_disown_selection_internal): Rename locals
13072 to avoid shadowing.
13073 (x_handle_dnd_message): Remove local to avoid shadowing.
13075 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13076 so that the caller can use some name other than gcpro1.
13077 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
13078 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13079 (Fx_backspace_delete_keys_p):
13080 Use them to avoid shadowing, and rename vars to avoid shadowing.
13081 (x_decode_color, x_set_name, x_window): Now static.
13082 (Fx_create_frame): Add braces to silence GCC warning.
13083 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
13084 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13085 Remove unused locals.
13086 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13087 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13088 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13091 * xterm.h (x_mouse_leave): New decl.
13093 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13094 Remove unused functions.
13095 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13096 (x_calc_absolute_position): Now static.
13097 (XTread_socket): Don't define label "out" unless it's used.
13098 Don't declare local "event" unless it's used.
13099 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13100 unless they are used.
13101 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13102 (x_fatal_error_signal): Remove; not used.
13103 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13104 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13105 (x_error_catcher, x_connection_closed, x_error_handler):
13106 (x_error_quitter, xembed_send_message, x_iconify_frame):
13107 (my_log_handler): Rename locals to avoid shadowing.
13108 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
13109 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
13111 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13112 Rename or move locals to avoid shadowing.
13113 (tty_defined_color, merge_face_heights): Now static.
13114 (free_realized_faces_for_fontset): Remove; not used.
13115 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13116 does not deduce is never used uninitialized.
13117 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13118 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
13120 * terminal.c (store_terminal_param): Now static.
13122 * xmenu.c (menu_highlight_callback): Now static.
13123 (set_frame_menubar): Remove unused local.
13124 (xmenu_show): Rename parameter to avoid shadowing.
13125 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13126 since they might point to immutable storage.
13127 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13128 since it's unused otherwise.
13130 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
13131 Add a FIXME, since the code still doesn't look right. (Bug#8215)
13132 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13133 avoids a gcc -Wuninitialized diagnostic.
13134 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
13135 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13136 does not deduce are never used uninitialized.
13138 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13140 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
13141 * window.c (window_loop, size_window):
13142 (run_window_configuration_change_hook, enlarge_window): Likewise.
13144 * window.c (display_buffer): Now static.
13145 (size_window): Mark variables that gcc -Wuninitialized
13146 does not deduce are never used uninitialized.
13147 * window.h (check_all_windows): New decl, to forestall
13148 gcc -Wmissing-prototypes diagnostic.
13149 * dispextern.h (bidi_dump_cached_states): Likewise.
13151 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13153 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
13154 Include <limits.h>.
13155 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13156 and to avoid gcc -Wuninitialized warning.
13157 (load_charset_map): Mark variables that gcc -Wuninitialized
13158 does not deduce are never used uninitialized.
13159 (load_charset): Abort instead of using uninitialized var (Bug#8229).
13161 * coding.c (coding_set_source, coding_set_destination):
13162 Use "else { /* comment */ }" rather than "else /* comment */;"
13163 for clarity, and to avoid gcc -Wempty-body warning.
13164 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13165 a block, when the outer 'i' will do.
13166 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13167 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13168 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13169 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13170 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13171 Rename locals to avoid shadowing.
13172 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
13173 * coding.c (emacs_mule_char, encode_invocation_designation):
13174 Now static, since they're not used elsewhere.
13175 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
13176 (decode_coding_object, encode_coding_object, detect_coding_system):
13177 (decode_coding_emacs_mule): Mark variables that gcc
13178 -Wuninitialized does not deduce are never used uninitialized.
13179 (detect_coding_iso_2022): Initialize a local variable that might
13180 be used uninitialized. Leave a FIXME because it's not clear that
13181 this initialization is needed. (Bug#8211)
13182 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13183 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13184 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13185 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13186 Remove unused macros.
13188 * category.c (hash_get_category_set): Remove unused local var.
13189 (copy_category_table): Now static, since it's not used elsewhere.
13190 * character.c (string_count_byte8): Likewise.
13192 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13193 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13195 * chartab.c (copy_sub_char_table): Now static, since it's not used
13197 (sub_char_table_ref_and_range, char_table_ref_and_range):
13198 Rename locals to avoid shadowing.
13199 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
13201 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
13202 (BIDI_BOB): Remove unused macro.
13204 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13205 deduce are never used uninitialized.
13206 * term.c (encode_terminal_code): Likewise.
13208 * term.c (encode_terminal_code): Now static. Remove unused local.
13210 * tparam.h: New file.
13211 * term.c, tparam.h: Include it.
13212 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13213 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13214 Move these decls to tparam.h, and make them agree with what
13215 is actually in tparam.c. The previous trick of using incompatible
13216 decls in different modules does not conform to the C standard.
13217 All callers of tparam changed to use tparam's actual API.
13218 * tparam.c (tparam1, tparam, tgoto):
13219 Use const pointers where appropriate.
13221 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13222 * cm.h (struct cm): Likewise.
13223 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13224 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13225 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13226 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13227 (turn_on_face, init_tty): Likewise.
13228 * termchar.h (struct tty_display_info): Likewise.
13230 * term.c (term_mouse_position): Rename local to avoid shadowing.
13232 * alloc.c (mark_ttys): Move decl from here ...
13233 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13235 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13237 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13239 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
13241 * search.c (compile_pattern_1): Remove argument regp, unused since
13242 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13243 (compile_pattern): Don't pass it.
13245 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13247 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13248 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13250 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13252 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13254 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13255 gdk_window_get_screen, gdk_window_get_geometry,
13256 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13257 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13258 (xg_get_pixbuf_from_pixmap): New function.
13259 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13260 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13261 Call xg_get_pixbuf_from_pixmap instead of
13262 gdk_pixbuf_get_from_drawable.
13263 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13264 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13265 (xg_check_special_colors): Use GtkStyleContext and its functions
13267 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13268 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13269 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
13270 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13271 Call gtk_widget_get_preferred_size.
13272 (xg_frame_resized): gdk_window_get_geometry only takes 5
13274 (xg_win_to_widget, xg_event_is_for_menubar):
13275 Call gdk_x11_window_lookup_for_display.
13276 (xg_set_widget_bg): New function.
13277 (delete_cb): New function.
13278 (xg_create_frame_widgets): Connect delete-event to delete_cb.
13279 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
13280 (xg_set_background_color): Call xg_set_widget_bg.
13281 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13282 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13283 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13284 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13286 (update_frame_tool_bar): Call gtk_widget_hide.
13287 (xg_initialize): Use GDK_KEY_g.
13289 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13291 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13293 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13294 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13295 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13297 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
13299 * w32xfns.c (select_palette): Check success of RealizePalette against
13300 GDI_ERROR, not zero.
13302 See ChangeLog.11 for earlier changes.
13304 ;; Local Variables:
13308 Copyright (C) 2011-2012 Free Software Foundation, Inc.
13310 This file is part of GNU Emacs.
13312 GNU Emacs is free software: you can redistribute it and/or modify
13313 it under the terms of the GNU General Public License as published by
13314 the Free Software Foundation, either version 3 of the License, or
13315 (at your option) any later version.
13317 GNU Emacs is distributed in the hope that it will be useful,
13318 but WITHOUT ANY WARRANTY; without even the implied warranty of
13319 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13320 GNU General Public License for more details.
13322 You should have received a copy of the GNU General Public License
13323 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.