1 2011-06-03 Paul Eggert <eggert@cs.ucla.edu>
3 Minor fixes for signed vs unsigned integers.
4 * character.h (MAYBE_UNIFY_CHAR):
5 * charset.c (maybe_unify_char):
6 * keyboard.c (read_char, reorder_modifiers):
7 XINT -> XFASTINT, since the integer must be nonnegative.
8 * ftfont.c (ftfont_spec_pattern):
9 * keymap.c (access_keymap, silly_event_symbol_error):
10 XUINT -> XFASTINT, since the integer must be nonnegative.
11 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
12 since it makes no difference and we prefer signed.
13 * keyboard.c (record_char): Use XUINT when all the neighbors do.
14 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
17 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
19 Malloc failure behavior now depends on size of allocation.
20 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
21 * lisp.h: Change signatures accordingly.
22 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
23 All callers changed. (Bug#8762)
25 * gnutls.c: Use Emacs's memory allocators.
26 Without this change, the gnutls library would invoke malloc etc.
27 directly, which causes problems on non-SYNC_INPUT hosts, and which
28 runs afoul of improving memory_full behavior. (Bug#8761)
29 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
30 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
31 xfree instead of the default malloc, realloc, free.
32 (Fgnutls_boot): No need to check for memory allocation failure,
33 since xmalloc does that for us.
35 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
36 * category.c (hash_get_category_set):
38 * charset.c (Fdefine_charset_internal):
39 * charset.h (struct charset.hash_index):
40 * composite.c (get_composition_id, gstring_lookup_cache)
41 (composition_gstring_put_cache):
42 * composite.h (struct composition.hash_index):
43 * dispextern.h (struct image.hash):
44 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
45 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
46 (hashfn_equal, hashfn_user_defined, make_hash_table)
47 (maybe_resize_hash_table, hash_lookup, hash_put)
48 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
49 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
50 (Fsxhash, Fgethash, Fputhash, Fmaphash):
51 * image.c (make_image, search_image_cache, lookup_image)
52 (xpm_put_color_table_h):
53 * lisp.h (struct Lisp_Hash_Table):
54 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
55 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
56 for hashes and hash indexes, instead of 'unsigned' and 'int'.
57 * alloc.c (allocate_vectorlike):
58 Check for overflow in vector size calculations.
60 Check for overflow when converting EMACS_INT to int.
61 * fns.c, image.c: Remove unnecessary static decls that would otherwise
62 need to be updated by these changes.
63 * fns.c (make_hash_table, maybe_resize_hash_table):
64 Check for integer overflow with large hash tables.
65 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
66 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
67 (SXHASH_REDUCE): New macro.
68 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
69 Use it instead of discarding useful hash info with large hash values.
70 (sxhash_float): New function.
71 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
72 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
73 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
74 Rewrite to use FIXNUM_BITS, as this simplifies things.
75 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
76 Adjust signatures to match updated version of code.
77 (consing_since_gc): Now EMACS_INT, since a single hash table can
78 use more than INT_MAX bytes.
80 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
82 Make it possible to build with GCC-4.6+ -O2 -flto.
84 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
86 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
88 * minibuf.c (get_minibuffer, read_minibuf_unwind):
89 Call minibuffer-inactive-mode.
91 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
93 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
96 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
98 * data.c (init_data): Remove code for UTS, this system is not
101 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
103 Don't force ./temacs to start in terminal mode.
105 * frame.c (make_initial_frame): Initialize faces in all cases, not
106 only when CANNOT_DUMP is defined.
107 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
109 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
111 * dispnew.c (add_window_display_history): Use const for the string
112 pointer. Remove declaration, not needed.
114 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
116 Use 'inline', not 'INLINE'.
117 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
118 * alloc.c, fontset.c (INLINE): Remove.
119 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
120 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
121 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
122 * gmalloc.c (register_heapinfo): Use inline unconditionally.
123 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
125 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
127 Make it possible to run ./temacs.
129 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
130 syms_of_callproc does the same thing. Remove test for
131 "initialized", do it in the caller.
132 * emacs.c (main): Avoid calling set_initial_environment when dumping.
134 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
136 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
137 (read_minibuf): Use get_minibuffer.
138 (syms_of_minibuf): Use DEFSYM.
139 (Qmetadata): New var.
140 * data.c (Qbuffer): Don't make it static.
141 (syms_of_data): Use DEFSYM.
143 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
145 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
146 (CCL_CODE_MIN): New macro.
148 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
150 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
152 * eval.c (Qdebug): Now static.
153 * lisp.h (Qdebug): Remove decl. This reverts a part of the
154 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
155 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
157 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
159 * image.c: Various fixes to ImageMagick code comments.
160 (Fimagemagick_types): Doc fix.
162 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
164 Minor fixes prompted by GCC 4.6.0 warnings.
166 * xselect.c (converted_selections, conversion_fail_tag): Now static.
168 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
169 (x_clipboard_manager_save_all): Move extern decl to ...
170 * xterm.h: ... here, so that it can be checked for consistency.
172 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
174 * xselect.c (x_clipboard_manager_save_frame)
175 (x_clipboard_manager_save_all): New functions.
176 (Fx_clipboard_manager_save): Lisp function deleted.
178 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
179 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
181 * xterm.h: Update prototype.
183 2011-05-28 William Xu <william.xwl@gmail.com>
185 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
188 2011-05-28 Jim Meyering <meyering@redhat.com>
190 Avoid a sign-extension bug in crypto_hash_function.
191 * fns.c (to_uchar): Define.
192 (crypto_hash_function): Use it to convert some newly-signed
193 variables to unsigned, to avoid sign-extension bugs. For example,
194 without this change, (md5 "truc") would evaluate to
195 45723a2aff78ff4fff7fff1114760e62 rather than the expected
196 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
197 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
199 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
201 Integer overflow fixes.
203 * dbusbind.c: Serial number integer overflow fixes.
204 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
205 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
206 to hold a serial number that is too large for a fixnum.
207 (Fdbus_method_return_internal, Fdbus_method_error_internal):
208 Check for serial numbers out of range. Decode any serial number
209 that was so large that it became a float. (Bug#8722)
211 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
212 (Fdbus_call_method, Fdbus_call_method_asynchronously):
213 Use XFASTINT rather than XUINT when numbers are nonnegative.
214 (xd_append_arg, Fdbus_method_return_internal):
215 (Fdbus_method_error_internal): Likewise. Also, for unsigned
216 arguments, check that Lisp number is nonnegative, rather than
217 silently wrapping negative numbers around. (Bug#8722)
218 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
221 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
223 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
225 ccl: add integer overflow checks
226 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
227 (IN_INT_RANGE): New macros.
228 (ccl_driver): Use them to check for integer overflow when
229 decoding a CCL program. Many of the new checks are whether XINT (x)
230 fits in int; it doesn't always, on 64-bit hosts. The new version
231 doesn't catch all possible integer overflows, but it's an
232 improvement. (Bug#8719)
234 * alloc.c (make_event_array): Use XINT, not XUINT.
235 There's no need for unsigned here.
237 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
238 This follows up to the 2011-05-06 change that substituted uintptr_t
239 for EMACS_INT. This case wasn't caught back then.
241 Rework Fformat to avoid integer overflow issues.
242 * editfns.c: Include <float.h> unconditionally, as it's everywhere
243 now (part of C89). Include <verify.h>.
244 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
245 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
246 (Fformat): Avoid the prepass trying to compute sizes; it was only
247 approximate and thus did not catch overflow reliably. Instead, walk
248 through the format just once, formatting and computing sizes as we go,
249 checking for integer overflow at every step, and allocating a larger
250 buffer as needed. Keep track separately whether the format is
251 multibyte. Keep only the most-recently calculated precision, rather
252 than them all. Record whether each argument has been converted to
253 string. Use EMACS_INT, not int, for byte and char and arg counts.
254 Support field widths and precisions larger than INT_MAX. Avoid
255 sprintf's undefined behavior with conversion specifications such as %#d
256 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
257 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
258 formatting out-of-range floating point numbers with int
261 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
263 * data.c: Avoid integer truncation in expressions involving floats.
264 * data.c: Include <intprops.h>.
265 (arith_driver): When there's an integer overflow in an expression
266 involving floating point, convert the integers to floating point
267 so that the resulting value does not suffer from catastrophic
268 integer truncation. For example, on a 64-bit host (* 4
269 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
270 Do not rely on undefined behavior after integer overflow.
272 merge count_size_as_multibyte, parse_str_to_multibyte
273 * character.c, character.h (count_size_as_multibyte):
274 Rename from parse_str_to_multibyte; all uses changed.
275 Check for integer overflow.
276 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
277 since it's now a duplicate of the other. This is more of
278 a character than a buffer op, so better that it's in character.c.
279 * fns.c, print.c: Adjust to above changes.
281 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
283 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
285 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
287 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
288 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
289 (x_clipboard_manager_save): Now static.
290 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
292 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
293 (crypto_hash_function): Now static.
294 Fix pointer signedness problems. Avoid unnecessary initializations.
296 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
298 * termhooks.h (Vselection_alist): Make it terminal-local.
300 * terminal.c (create_terminal): Initialize it.
302 * xselect.c: Support for clipboard managers.
303 (Vselection_alist): Move to termhooks.h as terminal-local var.
304 (LOCAL_SELECTION): New macro.
305 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
306 (symbol_to_x_atom): Remove gratuitous arg.
307 (x_handle_selection_request, lisp_data_to_selection_data)
308 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
309 (x_own_selection, x_get_local_selection, x_convert_selection):
310 New arg, specifying work frame. Use terminal-local Vselection_alist.
311 (some_frame_on_display): Delete unused function.
312 (Fx_own_selection_internal, Fx_get_selection_internal)
313 (Fx_disown_selection_internal, Fx_selection_owner_p)
314 (Fx_selection_exists_p): New optional frame arg.
315 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
316 (x_handle_selection_clear): Don't treat other terminals with the
317 same keyboard specially. Use the terminal-local Vselection_alist.
318 (x_clear_frame_selections): Use Frun_hook_with_args.
320 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
322 * xterm.h: Add support for those atoms.
324 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
326 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
327 (converted_selections, conversion_fail_tag): New global variables.
328 (x_selection_request_lisp_error): Free the above.
329 (x_get_local_selection): Remove unnecessary code.
330 (x_reply_selection_request): Args changed; handle arbitrary array
331 of converted selections stored in converted_selections.
332 Separate the XChangeProperty and SelectionNotify steps.
333 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
334 (x_convert_selection): New function.
335 (x_handle_selection_event): Simplify.
336 (x_get_foreign_selection): Don't ignore incoming requests while
337 waiting for an answer; this will fail when we implement
338 SAVE_TARGETS, and seems unnecessary anyway.
339 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
340 (Vx_sent_selection_functions): Doc fix.
342 2011-05-26 Leo Liu <sdl.web@gmail.com>
344 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
346 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
348 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
350 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
351 for fringe update if it has periodic bitmap.
352 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
353 and fringe_bitmap_periodic_p.
355 * fringe.c (get_fringe_bitmap_data): New function.
356 (draw_fringe_bitmap_1, update_window_fringes): Use it.
357 (update_window_fringes): Record periodicity of fringe bitmap in glyph
358 row. Mark glyph row for fringe update if periodicity changed.
360 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
361 for fringe update unless it has periodic bitmap.
363 2011-05-25 Kenichi Handa <handa@m17n.org>
365 * xdisp.c (get_next_display_element): Set correct it->face_id for
366 a static composition.
368 2011-05-24 Leo Liu <sdl.web@gmail.com>
371 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
373 * fns.c (crypto_hash_function, Fsha1): New function.
374 (Fmd5): Use crypto_hash_function.
375 (syms_of_fns): Add Ssha1.
377 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
379 * gnutls.c: Remove unused macros.
380 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
381 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
382 Remove macros that are defined and never used.
383 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
385 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
387 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
388 (Fx_get_selection_internal): Minor cleanup.
389 (Fx_own_selection_internal): Rename arguments for consistency with
392 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
394 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
396 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
398 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
400 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
402 * dispnew.c (scrolling_window): Don't exclude the case that the
403 last enabled row in the desired matrix touches the bottom boundary.
405 2011-05-21 Glenn Morris <rgm@gnu.org>
407 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
408 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
409 and add some more files.
411 2011-05-20 Eli Zaretskii <eliz@gnu.org>
413 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
414 report_file_error introduced by the change from 2011-05-07.
416 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
418 * systime.h (Time): Define only if emacs is defined.
419 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
420 where the include path doesn't have X11/X.h by default. See
421 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
423 2011-05-20 Kenichi Handa <handa@m17n.org>
425 * composite.c (find_automatic_composition): Fix previous change.
427 2011-05-20 Glenn Morris <rgm@gnu.org>
429 * lisp.mk: New file, split from Makefile.in.
430 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
432 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
434 2011-05-19 Glenn Morris <rgm@gnu.org>
436 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
437 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
438 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
439 (lisp): Set the order to that of loadup.el.
440 (shortlisp): Make it a copy of $lisp.
441 (SOME_MACHINE_LISP): Remove.
442 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
443 Use just $shortlisp, not $SOME_MACHINE_LISP too.
445 2011-05-18 Kenichi Handa <handa@m17n.org>
447 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
448 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
449 (find_automatic_composition): Mostly rewrite for efficiency.
451 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
453 * makefile.w32-in: Update dependencies.
455 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
457 * menu.c: Include limits.h (fixes the MS-Windows build broken by
460 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
462 Fix some integer overflow issues, such as string length overflow.
464 * insdel.c (count_size_as_multibyte): Check for string overflow.
466 * character.c (lisp_string_width): Check for string overflow.
467 Use EMACS_INT, not int, for string indexes and lengths; in
468 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
469 the resulting string length overflows an EMACS_INT; instead,
470 report a string overflow if no precision given. When checking for
471 precision exhaustion, use a check that cannot possibly have
472 integer overflow. (Bug#8675)
473 * character.h (lisp_string_width): Adjust to new signature.
475 * alloc.c (string_overflow): New function.
476 (Fmake_string): Use it. This doesn't change behavior, but saves
477 a few bytes and will simplify future changes.
478 * character.c (string_escape_byte8): Likewise.
479 * lisp.h (string_overflow): New decl.
481 Fixups, following up to the user-interface timestamp change.
482 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
483 for UI timestamps, instead of unsigned long.
484 * msdos.c (mouse_get_pos): Likewise.
485 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
486 * w32gui.h (Time): Define by including "systime.h" rather than by
487 declaring it ourselves. (Bug#8664)
489 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
490 * image.c (clear_image_cache): Likewise.
492 * term.c (term_mouse_position): Don't assume time_t wraparound.
494 Be more systematic about user-interface timestamps.
495 Before, the code sometimes used 'Time', sometimes 'unsigned long',
496 and sometimes 'EMACS_UINT', to represent these timestamps.
497 This change causes it to use 'Time' uniformly, as that's what X uses.
498 This makes the code easier to follow, and makes it easier to catch
499 integer overflow bugs such as Bug#8664.
500 * frame.c (Fmouse_position, Fmouse_pixel_position):
501 Use Time, not unsigned long, for user-interface timestamps.
502 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
503 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
504 * keyboard.h (last_event_timestamp): Likewise.
505 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
506 * menu.h (xmenu_show): Likewise.
507 * term.c (term_mouse_position): Likewise.
508 * termhooks.h (struct input_event.timestamp): Likewise.
509 (struct terminal.mouse_position_hook): Likewise.
510 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
511 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
512 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
513 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
515 * menu.h, termhooks.h: Include "systime.h", for Time.
517 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
518 Don't assume that the difference between two unsigned long values
519 can fit into an integer. At this point, we know button_down_time
520 <= event->timestamp, so the difference must be nonnegative, so
521 there's no need to cast the result if double-click-time is
522 nonnegative, as it should be; check that it's nonnegative, just in
523 case. This bug is triggered when events are more than 2**31 ms
524 apart (about 25 days). (Bug#8664)
526 * xselect.c (last_event_timestamp): Remove duplicate decl.
527 (x_own_selection): Remove needless cast to unsigned long.
529 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
530 that always fit in int. Use a sentinel instead of a counter, to
531 avoid a temp and to allay GCC's concerns about possible int overflow.
532 * frame.h (struct frame): Use int for menu_bar_items_used
533 instead of EMACS_INT, since it always fits in int.
535 * menu.c (grow_menu_items): Check for int overflow.
537 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
539 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
540 Before, the code was not consistent. These values cannot exceed
541 2**31 - 1 so there's no need to make them unsigned.
542 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
543 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
544 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
546 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
548 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
549 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
550 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
551 presumably because the widths might not match.
553 * window.c (size_window): Avoid needless test at loop start.
555 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
557 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
559 2011-05-12 Drew Adams <drew.adams@oracle.com>
561 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
563 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
565 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
566 `width' to `bar_area_x' and `bar_area_width', respectively.
567 (x_scroll_run): Take account of fringe background extension.
569 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
570 Rename local vars `left' and `width' to `bar_area_x' and
571 `bar_area_width', respectively.
572 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
573 background extension.
575 2011-05-10 Jim Meyering <meyering@redhat.com>
577 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
579 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
581 * image.c (Finit_image_library): Return t for built-in image types,
582 like pbm and xbm. (Bug#8640)
584 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
586 * w32menu.c (set_frame_menubar): Fix submenu allocation.
588 2011-05-07 Eli Zaretskii <eliz@gnu.org>
590 * w32console.c (Fset_screen_color): Doc fix.
591 (Fget_screen_color): New function.
592 (syms_of_ntterm): Defsubr it.
594 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
595 unlink the temporary file if Fcall_process didn't create it in the
597 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
598 child process will be redirected to a file specified with `:file'.
599 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
600 cue to call_process_cleanup not to close that handle.
602 2011-05-07 Ben Key <bkey76@gmail.com>
604 * makefile.w32-in: The bootstrap-temacs rule now makes use of
605 one of two shell specific rules, either bootstrap-temacs-CMD or
606 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
607 to the previous implementation of the bootstrap-temacs rule.
608 The bootstrap-temacs-CMD rule is similar to the previous
609 implementation of the bootstrap-temacs rule except that it
610 makes use of the ESC_CFLAGS variable instead of the CFLAGS
613 These changes, along with some changes to nt/configure.bat,
614 nt/gmake.defs, and nt/nmake.defs, are required to extend my
615 earlier fix to add support for --cflags and --ldflags options
616 that include quotes so that it works whether make uses cmd or
619 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
621 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
622 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
624 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
625 a string. Handle both cases.
626 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
627 (Fdbus_register_method): Use Qinvalid_function.
629 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
631 * makefile.w32-in: Update dependencies.
632 (LISP_H): Add inttypes.h and stdin.h.
633 (PROCESS_H): Add unistd.h.
635 2011-05-06 Eli Zaretskii <eliz@gnu.org>
637 * lread.c: Include limits.h (fixes the MS-Windows build broken by
638 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
640 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
642 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
644 * term.c (vfatal): Remove stray call to va_end.
645 It's not needed and the C Standard doesn't allow it here anyway.
647 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
648 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
650 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
653 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
655 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
657 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
659 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
661 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
663 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
664 * charset.c (Fdefine_charset_internal): Don't initialize
665 charset.code_space[15]. The value was garbage, on hosts with
666 32-bit int (Bug#8600).
668 * lread.c (read_integer): Be more consistent with string-to-number.
669 Use string_to_number to do the actual conversion; this avoids
670 rounding errors and fixes some other screwups. Without this fix,
671 for example, #x1fffffffffffffff was misread as -2305843009213693952.
672 (digit_to_number): Move earlier, for benefit of read_integer.
673 Return -1 if the digit is out of range for the base, -2 if it is
674 not a digit in any supported base. (Bug#8602)
676 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
678 * dispnew.c (scrolling_window): Return 1 if we scrolled,
679 to match comment at start of function. This also removes a
680 GCC warning about overflow in a 32+64-bit port.
682 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
684 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
685 Reported by Stefan Monnier in
686 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
687 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
688 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
690 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
691 (EMACS_UINTPTR): Likewise, with uintptr_t.
693 * lisp.h: Prefer 64-bit EMACS_INT if available.
694 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
695 on 32-bit hosts that have 64-bit int, so that they can access
697 However, temporarily disable this change unless the temporary
698 symbol WIDE_EMACS_INT is defined.
700 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
702 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
703 This removes an assumption that EMACS_INT and long are the same
704 width as pointers. The assumption is true for Emacs porting targets
705 now, but we want to make other targets possible.
706 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
707 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
708 In the rest of the code, change types of integers that hold casted
709 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
710 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
711 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
712 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
713 No need to cast type when ORing.
714 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
715 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
716 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
717 assume EMACS_INT is the same width as char *.
718 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
719 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
720 Remove no-longer-needed casts.
721 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
722 (xg_tool_bar_help_callback, xg_make_tool_item):
723 Use EMACS_INTPTR to hold an integer
724 that will be cast to void *; this can avoid a GCC warning
725 if EMACS_INT is not the same width as void *.
726 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
727 * xdisp.c (display_echo_area_1, resize_mini_window_1):
728 (current_message_1, set_message_1):
729 Use a local to convert to proper width without a cast.
730 * xmenu.c (dialog_selection_callback): Likewise.
732 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
733 Also, don't assume VALBITS / RAND_BITS is less than 5,
734 and don't rely on undefined behavior when shifting a 1 left into
736 * lisp.h (get_random): Change signature to match.
738 * lread.c (hash_string): Use size_t, not int, for hash computation.
739 Normally we prefer signed values; but hashing is special, because
740 it's better to use unsigned division on hash table sizes so that
741 the remainder is nonnegative. Also, size_t is the natural width
742 for hashing into memory. The previous code used 'int', which doesn't
743 retain enough info to hash well into very large tables.
744 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
746 * dbusbind.c: Don't possibly lose pointer info when converting.
747 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
748 Use XPNTR rather than XHASH, so that the high-order bits of
749 the pointer aren't lost when converting through void *.
751 * eval.c (Fautoload): Don't double-shift a pointer.
753 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
755 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
757 * gnutls.c (DEF_GNUTLS_FN):
758 * image.c (DEF_IMGLIB_FN): Make function pointers static.
760 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
762 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
765 2011-05-05 Eli Zaretskii <eliz@gnu.org>
767 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
768 New version that can reserve upto 2GB of heap space.
770 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
772 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
774 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
776 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
777 `gnutls_certificate_set_x509_key_file'.
779 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
781 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
784 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
786 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
787 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
788 Remove unused parameter `fildes'.
789 * process.c (read_process_output, send_process): Don't pass it.
791 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
793 Fix previous change: the library cache is defined in w32.c.
794 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
795 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
797 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
799 Implement dynamic loading of GnuTLS on Windows.
801 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
802 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
803 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
806 * gnutls.c (Qgnutls_dll): Define.
807 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
808 (gnutls_*): Declare function pointers.
809 (init_gnutls_functions): New function to initialize function pointers.
810 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
811 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
812 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
813 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
814 (emacs_gnutls_write, emacs_gnutls_read)
815 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
816 (Fgnutls_available_p): New function.
817 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
818 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
819 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
821 * image.c: Include w32.h.
822 (Vimage_type_cache): Delete.
823 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
824 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
825 (w32_delayed_load): Move to w32.c.
827 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
829 * w32.c (QCloaded_from, Vlibrary_cache): Define.
830 (w32_delayed_load): Move from image.c. When loading a library, record
831 its filename in the :loaded-from property of the library id.
832 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
833 Initialize and staticpro them.
834 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
836 * process.c: Include lisp.h before w32.h, not after.
837 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
838 instead of gnutls_record_check_pending.
840 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
842 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
844 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
845 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
848 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
850 * xterm.c (x_set_frame_alpha): Do not set property on anything
851 else than FRAME_X_OUTER_WINDOW (Bug#8608).
853 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
855 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
857 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
859 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
860 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
861 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
862 (gnutls_global_initialized, Qgnutls_bootprop_priority)
863 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
864 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
865 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
866 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
867 (Qgnutls_bootprop_callbacks_verify): Make static.
869 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
871 * callproc.c: Indentation fixup.
873 * sysdep.c (wait_for_termination_1): Make static.
874 (wait_for_termination, interruptible_wait_for_termination):
875 Move after wait_for_termination_1.
877 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
879 * sysdep.c (interruptible_wait_for_termination): New function
880 which is like wait_for_termination, but allows keyboard
883 * callproc.c (Fcall_process): Add (:file "file") as an option for
885 (Fcall_process_region): Ditto.
887 2011-04-30 Eli Zaretskii <eliz@gnu.org>
889 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
890 rather than `XVECTOR (FOO)->size'.
892 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
893 inttypes.h, as a gnulib replacement is used if it not available in
896 2011-04-21 Eli Zaretskii <eliz@gnu.org>
898 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
899 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
900 of MOST_POSITIVE_FIXNUM. (Bug#8528)
902 * coding.c (coding_alloc_by_realloc): Error out if destination
903 will grow beyond MOST_POSITIVE_FIXNUM.
904 (decode_coding_emacs_mule): Abort if there isn't enough place in
905 charbuf for the composition carryover bytes. Reserve an extra
906 space for up to 2 characters produced in a loop.
907 (decode_coding_iso_2022): Abort if there isn't enough place in
908 charbuf for the composition carryover bytes.
910 2011-04-21 Eli Zaretskii <eliz@gnu.org>
912 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
913 aborting when %lld or %lll format is passed.
914 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
915 %llo or %llx format is passed. (Bug#8545)
917 * window.c (window_scroll_line_based): Use a marker instead of
918 simple variables to record original value of point. (Bug#7952)
920 * doprnt.c (doprnt): Fix the case where a multibyte sequence
921 produced by %s or %c overflows available buffer space. (Bug#8545)
923 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
925 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
926 (SIZE_MAX): Move defn after all includes, as they might #define it.
928 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
930 * w32.c (init_environment): Warn about defaulting HOME to C:\.
932 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
934 * keyboard.c (Qdelayed_warnings_hook): Define.
935 (command_loop_1): Run `delayed-warnings-hook'
936 if Vdelayed_warnings_list is non-nil.
937 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
938 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
940 2011-04-28 Eli Zaretskii <eliz@gnu.org>
942 * doprnt.c (doprnt): Don't return value smaller than the buffer
943 size if the message was truncated. (Bug#8545).
945 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
947 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
948 (Fx_window_property): #if-0 the whole functions, not just the bodies.
950 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
952 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
954 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
956 * makefile.w32-in: Update dependencies.
958 2011-04-27 Eli Zaretskii <eliz@gnu.org>
960 Improve `doprnt' and its usage. (Bug#8545)
961 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
962 `format_end'. Remove support for %l as a conversion specifier.
963 Don't use xrealloc. Improve diagnostics when the %l size modifier
964 is used. Update the commentary.
966 * eval.c (verror): Simplify calculation of size_t.
968 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
971 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
973 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
976 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
978 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
979 This makes this file independent of the recent pseudovector change.
981 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
983 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
985 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
986 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
988 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
990 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
991 GCC 4.6.0 optimizes based on type-based alias analysis.
992 For example, if b is of type struct buffer * and v of type struct
993 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
994 != &v->size, and therefore "v->size = 1; b->size = 2; return
995 v->size;" must therefore return 1. This assumption is incorrect
996 for Emacs, since it type-puns struct Lisp_Vector * with many other
997 types. To fix this problem, this patch adds a new type struct
998 vectorlike_header that documents the constraints on layout of vectors
999 and pseudovectors, and helps optimizing compilers not get fooled
1000 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1001 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1002 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1004 (XSETPVECTYPE): Rewrite in terms of new macro.
1005 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1006 This is a bit clearer, and further avoids the possibility of
1007 undesirable aliasing.
1008 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1009 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1010 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1011 since Lisp_Subr is a special case (no "next" field).
1012 (ASIZE): Now uses header.size rather than size.
1013 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1014 to avoid the hassle of writing XVECTOR (foo)->header.size.
1015 (struct vectorlike_header): New type.
1016 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1017 object, to help avoid aliasing.
1018 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1019 (SUBRP): Likewise, since Lisp_Subr is a special case.
1020 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1021 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1022 (struct Lisp_Hash_Table): Combine first two members into a single
1023 struct vectorlike_header member. All uses of "size" and "next" members
1024 changed to be "header.size" and "header.next".
1025 * buffer.h (struct buffer): Likewise.
1026 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1027 * frame.h (struct frame): Likewise.
1028 * process.h (struct Lisp_Process): Likewise.
1029 * termhooks.h (struct terminal): Likewise.
1030 * window.c (struct save_window_data, struct saved_window): Likewise.
1031 * window.h (struct window): Likewise.
1032 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1033 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1034 * buffer.c (init_buffer_once): Likewise.
1035 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1037 * process.c (Fformat_network_address): Use local var for size,
1040 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1042 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1043 * data.c (atof): Remove decl; no longer used or needed.
1044 (digit_to_number): Move to lread.c.
1045 (Fstring_to_number): Use new string_to_number function, to be
1046 consistent with how the Lisp reader treats infinities and NaNs.
1047 Do not assume that floating-point numbers represent EMACS_INT
1048 without losing information; this is not true on most 64-bit hosts.
1049 Avoid double-rounding errors, by insisting on integers when
1050 parsing non-base-10 numbers, as the documentation specifies.
1051 * lisp.h (string_to_number): New decl, replacing ...
1052 (isfloat_string): Remove.
1053 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1054 (read1): Do not accept +. and -. as integers; this
1055 appears to have been a coding error. Similarly, do not accept
1056 strings like +-1e0 as floating point numbers. Do not report
1057 overflow for integer overflows unless the base is not 10 which
1058 means we have no simple and reliable way to continue.
1059 Break out the floating-point parsing into a new
1060 function string_to_number, so that Fstring_to_number parses
1061 floating point numbers consistently with the Lisp reader.
1062 (digit_to_number): Move here from data.c. Make it static inline.
1063 (E_CHAR, EXP_INT): Remove, replacing with ...
1064 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1065 (string_to_number): New function, replacing isfloat_string.
1066 This function checks for valid syntax and produces the resulting
1067 Lisp float number too. Rework it so that string-to-number
1068 no longer mishandles examples like "1.0e+". Use strtoumax,
1069 so that overflow for non-base-10 numbers is reported only when
1070 there's no portable and simple way to convert to floating point.
1072 * textprop.c (set_text_properties_1): Rewrite for clarity,
1073 and to avoid GCC warning about integer overflow.
1075 * intervals.h (struct interval): Use EMACS_INT for members
1076 where EMACS_UINT might cause problems. See
1077 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1078 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1079 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1081 (offset_intervals): Tell GCC not to worry about length overflow
1082 when negating a negative length.
1084 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1085 (overrun_check_free): Likewise.
1087 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1088 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1091 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1092 (gnutls_make_error): Rename local to avoid shadowing.
1093 (gnutls_emacs_global_deinit): ifdef out; not used.
1094 (Fgnutls_boot): Use const for pointer to readonly storage.
1095 Comment out unused local. Fix pointer signedness problems.
1097 * lread.c (openp): Don't stuff size_t into an 'int'.
1098 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1099 about possible signed overflow.
1101 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1102 (GDK_KEY_g): Don't define if already defined.
1103 (xg_prepare_tooltip): Avoid pointer signedness problem.
1104 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1106 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1107 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1109 * xfns.c (Fx_window_property): Simplify a bit,
1110 to make a bit faster and to avoid GCC 4.6.0 warning.
1111 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1113 * fns.c (internal_equal): Don't assume size_t fits in int.
1115 * alloc.c (compact_small_strings): Tighten assertion a little.
1117 Replace pEd with more-general pI, and fix some printf arg casts.
1118 * lisp.h (pI): New macro, generalizing old pEd macro to other
1119 conversion specifiers. For example, use "...%"pI"d..." rather
1120 than "...%"pEd"...".
1121 (pEd): Remove. All uses replaced with similar uses of pI.
1122 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1123 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1124 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1125 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1126 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1127 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1128 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1130 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1131 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1132 * print.c (safe_debug_print, print_object): Likewise.
1133 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1135 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1136 avoiding the 0 flag, which is not portable.
1137 * process.c (Fmake_network_process): Use pI to avoid cast.
1138 * region-cache.c (pp_cache): Likewise.
1139 * xdisp.c (decode_mode_spec): Likewise.
1140 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1141 behavior on 64-bit hosts with printf arg.
1142 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
1143 (x_stop_queuing_selection_requests): Likewise.
1144 (x_get_window_property): Don't truncate byte count to an 'int'
1147 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1148 here, since it parses constructs like leading '-' and spaces,
1149 which are not wanted; and it overflows with large numbers.
1150 Instead, simply match F[0-9]+, which is what is wanted anyway.
1152 * alloc.c: Remove unportable assumptions about struct layout.
1153 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1154 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1155 (allocate_vectorlike, make_pure_vector): Use the new macros,
1156 plus offsetof, to remove unportable assumptions about struct layout.
1157 These assumptions hold on all porting targets that I know of, but
1158 they are not guaranteed, they're easy to remove, and removing them
1159 makes further changes easier.
1161 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1162 This doesn't fix a bug but makes the code clearer.
1163 (string_overrun_cookie): Now const. Use initializers that
1164 don't formally overflow signed char, to avoid warnings.
1165 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1166 can cause Emacs to crash when string overrun checking is enabled.
1167 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1168 multiple of sizeof (EMACS_INT); it need not be, if
1169 alignof(EMACS_INT) < sizeof (EMACS_INT).
1170 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1172 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1174 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1176 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1178 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1179 supposed to be handshaking. (Bug#8556)
1180 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1182 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1184 * lisp.h (Qdebug): List symbol.
1185 * eval.c (Qdebug): Restore global linkage.
1186 * keyboard.c (debug-on-event): New variable.
1187 (handle_user_signal): Break into debugger when debug-on-event
1188 matches the current signal symbol.
1190 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1192 * alloc.c (check_sblock, check_string_bytes)
1193 (check_string_free_list): Convert to standard C.
1195 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1197 * w32.c (emacs_gnutls_push): Fix typo.
1199 2011-04-25 Eli Zaretskii <eliz@gnu.org>
1201 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1202 "cast to pointer from integer of different size".
1204 Improve doprnt and its use in verror. (Bug#8545)
1205 * doprnt.c (doprnt): Document the set of format control sequences
1206 supported by the function. Use SAFE_ALLOCA instead of always
1209 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1210 is one byte too soon. Don't use xrealloc; instead xfree and
1213 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1215 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1218 * gnutls.c: Renamed global_initialized to
1219 gnutls_global_initialized. Added internals for the
1220 :verify-hostname-error, :verify-error, and :verify-flags
1221 parameters of `gnutls-boot' and documented those parameters in the
1222 docstring. Start callback support.
1223 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1224 unless a fatal error occured. Call gnutls_alert_send_appropriate
1225 on error. Return error code.
1226 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1227 (emacs_gnutls_read): Likewise.
1228 (Fgnutls_boot): Return handshake error code.
1229 (emacs_gnutls_handle_error): New function.
1230 (wsaerror_to_errno): Likewise.
1232 * w32.h (emacs_gnutls_pull): Add prototype.
1233 (emacs_gnutls_push): Likewise.
1235 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1236 (emacs_gnutls_push): Likewise.
1238 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1240 * process.c (wait_reading_process_output): Check if GnuTLS
1241 buffered some data internally if no FDs are set for TLS
1244 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1245 (LIBS): Link to USER_LIBS.
1246 ($(BLD)/gnutls.$(0)): New target.
1248 2011-04-24 Eli Zaretskii <eliz@gnu.org>
1250 * xdisp.c (handle_single_display_spec): Rename the
1251 display_replaced_before_p argument into display_replaced_p, to
1252 make it consistent with the commentary. Fix typos in the
1255 * textprop.c (syms_of_textprop): Remove dead code.
1256 (copy_text_properties): Delete obsolete commentary about an
1257 interface that was deleted long ago. Fix typos in the description
1260 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1261 to changes in oldXMenu/XMenu.h from 2011-04-16.
1262 <menu_help_message, prev_menu_help_message>: Constify.
1263 (IT_menu_make_room): menu->help_text is now `const char **';
1266 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1267 to changes in oldXMenu/XMenu.h from 2011-04-16.
1268 (struct XMenu): Declare `help_text' `const char **'.
1270 * xfaces.c <Qunspecified>: Make extern again.
1272 * syntax.c: Include sys/types.h before including regex.h, as
1275 * doc.c (get_doc_string): Improve the format passed to `error'.
1277 * doprnt.c (doprnt): Improve commentary.
1279 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1281 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1284 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1285 changes in globals.h immediately force recompilation.
1286 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1287 $(CURDIR)/s/ms-w32.h.
1288 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1290 * character.c (Fchar_direction): Function deleted.
1291 (syms_of_character): Don't defsubr it.
1292 <char-direction-table>: Deleted.
1294 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1296 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1297 * doprnt.c: Include limits.h.
1298 (SIZE_MAX): New macro.
1299 (doprnt): Return a size_t value. 2nd arg is now size_t.
1300 Many local variables are now size_t instead of int or unsigned.
1301 Improve overflow protection. Support `l' modifier for integer
1302 conversions. Support %l conversion. Don't assume an EMACS_INT
1303 argument for integer conversions and for %c.
1305 * lisp.h (doprnt): Restore prototype.
1307 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1310 * Makefile.in (base_obj): Add back doprnt.o.
1312 * deps.mk (doprnt.o): Add back prerequisites.
1313 (callint.o): Depend on character.h.
1315 * eval.c (internal_lisp_condition_case): Include the handler
1316 representation in the error message.
1317 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1318 when breaking from the loop.
1320 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1322 * callint.c (Fcall_interactively): When displaying error message
1323 about invalid control letter, pass the character's codepoint, not
1324 a pointer to its multibyte form. Improve display of the character
1325 in octal and display also its hex code.
1327 * character.c (char_string): Use %x to display the (unsigned)
1328 codepoint of an invalid character, to avoid displaying a bogus
1331 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1332 `error', not SYMBOL_NAME itself.
1334 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1335 character arguments to `error'.
1337 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1338 to `error' in error message about FINAL_CHAR argument. Make sure
1339 FINAL_CHAR is a character, and use %c when it is passed as
1340 argument to `error'.
1342 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1344 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1346 * w32.c: Include <time.h>.
1347 (sys_localtime): New function.
1349 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1351 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1353 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1355 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1357 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1360 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1362 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1363 gl_state.e_property when gl_state.object is Qt.
1365 * insdel.c (make_gap_larger): Remove limitation of buffer size
1368 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1370 * xdisp.c (lookup_glyphless_char_display)
1371 (produce_glyphless_glyph): Handle cons cell entry in
1372 glyphless-char-display.
1373 (Vglyphless_char_display): Document it.
1375 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1376 glyphless-char-display.
1378 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
1380 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1382 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1384 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1385 definition for no-X builds.
1387 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1389 Static checks with GCC 4.6.0 and non-default toolkits.
1391 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1393 * process.c (keyboard_bit_set): Define only if SIGIO.
1394 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1395 (send_process): Repair possible setjmp clobbering.
1397 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1399 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1401 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1403 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1404 Define only if needed.
1406 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1407 by pacifying GCC about it. Maybe it's time to retire it?
1408 * xfaces.c (USG, __TIMEVAL__): Likewise.
1410 * dispextern.h (struct redisplay_interface): Rename param
1412 * termhooks.h (struct terminal): Likewise.
1413 * xterm.c (xembed_send_message): Likewise.
1415 * insdel.c (make_gap_smaller): Define only if
1416 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1418 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1421 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1422 so that we aren't warned about unused symbols.
1424 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1426 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1428 * xfns.c (x_real_positions): Mark locals as initialized.
1430 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1432 * xterm.c: Fix problems found by static analysis with other toolkits.
1433 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1434 (x_dispatch_event): Declare static if USE_GTK, and
1435 define if USE_GTK || USE_X_TOOLKIT.
1436 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1437 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1438 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1439 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1441 * xmenu.c (menu_help_callback): Pointer type fixes.
1442 Use const pointers when pointing at readonly data. Avoid pointer
1444 (FALSE): Remove unused macro.
1445 (update_frame_menubar): Remove unused decl.
1447 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1449 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1450 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1451 (single_menu_item): Rename local to avoid shadowing.
1453 * keyboard.c (make_lispy_event): Remove unused local var.
1455 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1456 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1458 * bitmaps: Change bitmaps from unsigned char back to the X11
1459 compatible char. Avoid the old compiler warnings about
1460 out-of-range initializers by using, for example, '\xab' rather
1463 * xgselect.c (xgselect_initialize): Check vs interface
1464 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1466 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1468 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1469 to read-only memory.
1471 * fns.c (vector): Remove; this old hack is no longer needed.
1473 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1475 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1477 * xrdb.c (x_load_resources): Omit unused local.
1479 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1480 (x_window): Rename locals to avoid shadowing.
1481 (USG): Use the kludged USG macro, to pacify gcc.
1483 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1484 (x_term_init): Remove local to avoid shadowing.
1486 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1488 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1489 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1491 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1493 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1495 Fix regex.c, syntax.c and friends for buffers > 2GB.
1496 * syntax.h (struct gl_state_s): Declare character position members
1499 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1501 * textprop.c (verify_interval_modification, interval_of):
1502 Declare arguments EMACS_INT.
1504 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1507 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1509 * indent.c (Fvertical_motion): Local variable it_start is now
1512 * regex.c (re_match, re_match_2, re_match_2_internal)
1513 (bcmp_translate, regcomp, regexec, print_double_string)
1514 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1515 (re_compile_pattern, re_exec): Declare arguments and local
1516 variables `size_t' and `ssize_t' and return values `regoff_t', as
1518 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1519 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1520 <compile_stack_type>: `size' and `avail' are now `size_t'.
1522 * regex.h <regoff_t>: Use ssize_t, not int.
1523 (re_search, re_search_2, re_match, re_match_2): Arguments that
1524 specify buffer/string position and length are now ssize_t and
1525 size_t. Return type is regoff_t.
1527 2011-04-16 Ben Key <bkey76@gmail.com>
1529 * nsfont.m: Fixed bugs in ns_get_family and
1530 ns_descriptor_to_entity that were caused by using free to
1531 deallocate memory blocks that were allocated by xmalloc (via
1532 xstrdup). This caused Emacs to crash when compiled with
1533 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1534 --enable-checking=xmallocoverrun). xfree is now used to
1535 deallocate these memory blocks.
1537 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1539 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1541 emacs_write: Accept and return EMACS_INT for sizes.
1542 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1544 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1545 Accept and return EMACS_INT.
1546 (emacs_gnutls_write): Return the number of bytes written on
1548 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1549 (emacs_read, emacs_write): Remove check for negative size, as the
1550 Emacs source code has been audited now.
1551 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1552 (emacs_read, emacs_write): Use it.
1553 * process.c (send_process): Adjust to the new signatures of
1554 emacs_write and emacs_gnutls_write. Do not attempt to store
1555 a byte offset into an 'int'; it might overflow.
1556 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1558 * sound.c: Don't assume sizes fit in 'int'.
1559 (struct sound_device.period_size, alsa_period_size):
1560 Return EMACS_INT, not int.
1561 (struct sound_device.write, vox_write, alsa_write):
1562 Accept EMACS_INT, not int.
1563 (wav_play, au_play): Use EMACS_INT to store sizes and to
1564 record read return values.
1566 2011-04-15 Ben Key <bkey76@gmail.com>
1568 * keyboard.c (Qundefined): Don't declare static since it is used
1570 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1571 static since they are used in nsfont.m.
1573 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1575 * process.c (Qprocessp): Don't declare static.
1576 * lisp.h (Qprocessp): Declare again.
1578 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
1580 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1582 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1584 Improve C-level modularity by making more things 'static'.
1586 Don't publish debugger-only interfaces to other modules.
1587 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1588 (verify_bytepos, count_markers): Move decls to the only modules
1590 * region-cache.h (pp_cache): Likewise.
1591 * window.h (check_all_windows): Likewise.
1592 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1594 * sysdep.c (croak): Now static, if
1595 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1596 * syssignal.h (croak): Declare only if not static.
1598 * alloc.c (refill_memory_reserve): Now static if
1599 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1600 * lisp.h (refill_memory_reserve): Declare only if not static.
1602 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1603 Define only if USE_LUCID.
1605 * xrdb.c (x_customization_string, x_rm_string): Now static.
1607 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1608 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1610 * xdisp.c (draw_row_with_mouse_face): Now static.
1611 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1613 * window.h (check_all_windows): Mark externally visible.
1615 * window.c (window_deletion_count): Now static.
1617 * undo.c: Make symbols static if they're not exported.
1618 (last_undo_buffer, last_boundary_position, pending_boundary):
1621 * textprop.c (interval_insert_behind_hooks): Now static.
1622 (interval_insert_in_front_hooks): Likewise.
1624 * term.c: Make symbols static if they're not exported.
1625 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1626 (max_frame_lines, tty_set_terminal_modes):
1627 (tty_reset_terminal_modes, tty_turn_off_highlight):
1628 (get_tty_terminal): Now static.
1629 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1630 * termhooks.h (term_mouse_moveto): Do not declare if
1632 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1633 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1635 * sysdep.c: Make symbols static if they're not exported.
1636 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1638 (sigprocmask_set, full_mask): Remove; unused.
1639 (wait_debugging): Mark as visible.
1640 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1641 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1643 * syntax.c (syntax_temp): Define only if !__GNUC__.
1645 * sound.c (current_sound_device, current_sound): Now static.
1647 * search.c (searchbufs, searchbuf_head): Now static.
1649 * scroll.c (scroll_cost): Remove; unused.
1650 * dispextern.h (scroll_cost): Remove decl.
1652 * region-cache.h (pp_cache): Mark as externally visible.
1654 * process.c: Make symbols static if they're not exported.
1655 (process_tick, update_tick, create_process, chan_process):
1656 (Vprocess_alist, proc_buffered_char, datagram_access):
1657 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1658 (deactivate_process): Mark defn as static, as well as decl.
1659 * lisp.h (create_process): Remove decl.
1660 * process.h (chan_process, Vprocess_alist): Remove decls.
1662 * print.c: Make symbols static if they're not exported.
1663 (print_depth, new_backquote_output, being_printed, print_buffer):
1664 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1665 (print_interval, print_number_index, initial_stderr_stream):
1667 * lisp.h (Fprinc): Remove decl.
1668 (debug_output_compilation_hack): Mark as externally visible.
1670 * sysdep.c (croak): Move decl from here to syssignal.h.
1671 * syssignal.h (croak): Put it here, so the API can be checked when
1672 'croak' is called from dissociate_if_controlling_tty.
1674 * minibuf.c: Make symbols static if they're not exported.
1675 (minibuf_save_list, choose_minibuf_frame): Now static.
1676 * lisp.h (choose_minibuf_frame): Remove decl.
1678 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1680 * lread.c: Make symbols static if they're not exported.
1681 (read_objects, initial_obarray, oblookup_last_bucket_number):
1683 (make_symbol): Remove; unused.
1684 * lisp.h (initial_obarray, make_symbol): Remove decls.
1686 * keyboard.c: Make symbols static if they're not exported.
1687 (single_kboard, recent_keys_index, total_keys, recent_keys):
1688 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1689 (this_single_command_key_start, echoing, last_auto_save):
1690 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1691 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1692 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1693 (Vlispy_mouse_stem, double_click_count):
1695 (force_auto_save_soon): Define only if SIGDANGER.
1696 (ignore_mouse_drag_p): Now static if
1697 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1698 (print_help): Remove; unused.
1699 (stop_character, last_timer_event): Mark as externally visible.
1700 * keyboard.h (ignore_mouse_drag_p): Declare only if
1701 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1702 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1703 * lisp.h (echoing): Remove decl.
1704 (force_auto_save_soon): Declare only if SIGDANGER.
1705 * xdisp.c (redisplay_window): Simplify code, to make it more
1706 obvious that ignore_mouse_drag_p is not accessed if !defined
1707 USE_GTK && !defined HAVE_NS.
1709 * intervals.c: Make symbols static if they're not exported.
1710 (merge_properties_sticky, merge_interval_right, delete_interval):
1712 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1714 * insdel.c: Make symbols static if they're not exported.
1715 However, leave prepare_to_modify_buffer alone. It's never
1716 called from outside this function, but that appears to be a bug.
1717 (combine_after_change_list, combine_after_change_buffer):
1718 (adjust_after_replace, signal_before_change): Now static.
1719 (adjust_after_replace_noundo): Remove; unused.
1720 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
1721 (signal_before_change): Remove decls.
1723 * indent.c (val_compute_motion, val_vmotion): Now static.
1725 * image.c: Make symbols static if they're not exported.
1726 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1728 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1729 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1731 * fringe.c (standard_bitmaps): Now static.
1732 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1734 * frame.c: Make symbols static if they're not exported.
1735 (x_report_frame_params, make_terminal_frame): Now static.
1736 (get_frame_param): Now static, unless HAVE_NS.
1737 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1738 (x_get_resource_string): Remove; not used.
1739 * frame.h (make_terminal_frame, x_report_frame_params):
1740 (x_get_resource_string); Remove decls.
1741 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1742 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1744 * font.c, fontset.c: Make symbols static if they're not exported.
1745 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1746 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1747 * font.c (font_close_object): Now static.
1748 * font.h (font_close_object): Remove.
1749 * fontset.c (FONTSET_OBJLIST): Remove.
1750 (free_realized_fontset) #if-0 the body, which does nothing.
1751 (face_suitable_for_char_p): #if-0, as it's never called.
1752 * fontset.h (face_suitable_for_char_p): Remove decl.
1753 * xfaces.c (face_at_string_position):
1754 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1755 since 0 is always ASCII.
1757 * fns.c (weak_hash_tables): Now static.
1759 * fileio.c: Make symbols static if they're not exported.
1760 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1761 (Vwrite_region_annotation_buffers): Now static.
1763 * eval.c: Make symbols static if they're not exported.
1764 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1765 * lisp.h (backtrace_list): Remove decl.
1767 * emacs.c: Make symbols static if they're not exported.
1768 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1769 (fatal_error_code, fatal_error_signal_hook, standard_args):
1771 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1772 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1773 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1774 * lisp.h (fatal_error_signal_hook): Remove decl.
1775 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1777 * editfns.c: Move a (normally-unused) function to its only use.
1778 * editfns.c, lisp.h (get_operating_system_release): Remove.
1779 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1780 worth the hassle of breaking this out.
1782 * xterm.c: Make symbols static if they're not exported.
1783 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1784 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1785 (x_destroy_window, x_delete_display):
1787 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1788 (x_mouse_leave): Remove; unused.
1789 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1790 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1791 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1793 (x_mouse_leave): Declare only if WINDOWSNT.
1794 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1795 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1798 * ftxfont.c: Make symbols static if they're not exported.
1799 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1801 * font.h (ftxfont_driver): Likewise.
1803 * xfns.c: Make symbols static if they're not exported.
1804 (x_last_font_name, x_display_info_for_name):
1805 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1806 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1807 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1808 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1809 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1810 (last_show_tip_args): Now static.
1811 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1812 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1813 (x_screen_planes): Remove; unused.
1814 * dispextern.h (x_screen_planes): Remove decl.
1816 * dispnew.c: Make symbols static if they're not exported.
1817 * dispextern.h (redraw_garbaged_frames, scrolling):
1818 (increment_row_positions): Remove.
1819 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1820 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1822 (redraw_garbaged_frames): Remove; unused.
1824 * xfaces.c: Make symbols static if they're not exported.
1825 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1827 * xterm.h (defined_color): Remove decls.
1828 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1829 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1830 (menu_face_changed_default, defined_color, free_realized_face):
1831 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1832 (ascii_face_of_lisp_face): Remove; unused.
1834 * xdisp.c: Make symbols static if they're not exported.
1835 * dispextern.h (scratch_glyph_row, window_box_edges):
1836 (glyph_to_pixel_coords, set_cursor_from_row):
1837 (get_next_display_element, set_iterator_to_next):
1838 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1839 (show_mouse_face): Remove decls
1840 * frame.h (message_buf_print): Likewise.
1841 * lisp.h (pop_message, set_message, check_point_in_composition):
1843 * xterm.h (set_vertical_scroll_bar): Likewise.
1844 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1845 (message_buf_print, scratch_glyph_row, displayed_buffer):
1846 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1847 (get_next_display_element, show_mouse_face, window_box_edges):
1848 (frame_to_window_pixel_xy, check_point_in_composition):
1849 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1850 (glyph_to_pixel_coords): Remove; unused.
1852 * dired.c (file_name_completion): Now static.
1854 * dbusbind.c (xd_in_read_queued_messages): Now static.
1856 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1857 * data.c (circular_list_error): Remove.
1859 * commands.h (last_point_position, last_point_position_buffer):
1860 (last_point_position_window): Remove decls.
1861 * keyboard.c: Make these variables static.
1863 * coding.h (coding, code_convert_region, encode_coding_gap):
1865 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1866 (iso_code_class, detect_coding, code_convert_region): Now static.
1867 (encode_coding_gap): Remove; unused.
1869 * chartab.c (chartab_chars, chartab_bits): Now static.
1871 * charset.h (charset_iso_8859_1): Remove decl.
1872 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1875 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1876 * ccl.c (Vccl_program_table): Now static.
1877 (check_ccl_update): Remove; unused.
1879 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1880 * category.h: ... from here.
1881 * category.c (check_category_table, set_category_set): Now static.
1883 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1884 * lisp.h: Remove these decls.
1886 * buffer.c (buffer_count): Remove unused var.
1888 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1889 so that it's not optimized away.
1890 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1891 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1892 exported only to the debugger.
1894 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1895 * atimer.h (run_all_atimers): Remove; not exported.
1897 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1898 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1899 was inaccessible from Lisp.
1900 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1901 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1903 alloc.c: Import and export fewer symbols, and remove unused items.
1904 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1906 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1907 it's not optimized away by whole-program optimization.
1908 (message_enable_multibyte, free_misc): Remove.
1909 (catchlist, handlerlist, mark_backtrace):
1910 Declare only if BYTE_MARK_STACK.
1911 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1912 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1913 (message_enable_multibyte): Remove decl.
1914 (free_misc, interval_free_list, float_block, float_block_index):
1915 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1916 (cons_free_list, last_marked_index):
1918 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1919 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1920 (mark_backtrace): Define only if BYTE_MARK_STACK.
1921 * xdisp.c (message_enable_multibyte): Now static.
1923 Declare Lisp_Object Q* variables to be 'static' if not exported.
1924 This makes it easier for human readers (and static analyzers)
1925 to see whether these variables are used from other modules.
1926 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1927 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1928 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1929 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1930 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1931 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1932 * xmenu.c, xselect.c:
1933 Declare Q* vars static if they are not used in other modules.
1934 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1935 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1936 Remove decls of unexported vars.
1937 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1939 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1941 Make Emacs functions such as Fatom 'static' by default.
1942 This makes it easier for human readers (and static analyzers)
1943 to see whether these functions can be called from other modules.
1944 DEFUN now defines a static function. To make the function external
1945 so that it can be used in other C modules, use the new macro DEFUE.
1946 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1947 (Finit_image_library):
1948 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1949 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1950 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1951 Remove decls, since these functions are now static.
1952 (Funintern, Fget_internal_run_time): New decls, since these functions
1953 were already external.
1955 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1956 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1957 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1958 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1959 * keyboard.c, keymap.c, lread.c:
1960 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1961 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1962 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1963 Mark functions with DEFUE instead of DEFUN,
1964 if they are used in other modules.
1965 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1966 decls for now-static functions.
1967 * buffer.h (Fdelete_overlay): Remove decl.
1968 * callproc.c (Fgetenv_internal): Mark as internal.
1969 * composite.c (Fremove_list_of_text_properties): Remove decl.
1970 (Fcomposition_get_gstring): New forward static decl.
1971 * composite.h (Fcomposite_get_gstring): Remove decl.
1972 * dired.c (Ffile_attributes): New forward static decl.
1973 * doc.c (Fdocumntation_property): New forward static decl.
1974 * eval.c (Ffetch_bytecode): New forward static decl.
1975 (Funintern): Remove extern decl; now in .h file where it belongs.
1976 * fileio.c (Fmake_symbolic_link): New forward static decl.
1977 * image.c (Finit_image_library): New forward static decl.
1978 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1979 * intervals.h (Fprevious_property_change):
1980 (Fremove_list_of_text_properties): Remove decls.
1981 * keyboard.c (Fthis_command_keys): Remove decl.
1982 (Fcommand_execute): New forward static decl.
1983 * keymap.c (Flookup_key): New forward static decl.
1984 (Fcopy_keymap): Now static.
1985 * keymap.h (Flookup_key): Remove decl.
1986 * process.c (Fget_process): New forward static decl.
1987 (Fprocess_datagram_address): Mark as internal.
1988 * syntax.c (Fsyntax_table_p): New forward static decl.
1989 (skip_chars): Remove duplicate decl.
1990 * textprop.c (Fprevious_property_change): New forward static decl.
1991 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1993 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1994 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1996 * editfns.c (Fformat): Remove unreachable code.
1998 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2000 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2003 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2005 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2006 when at ZV. (Bug#8487)
2008 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2010 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2012 * keyboard.c (parse_tool_bar_item): Likewise.
2013 * sound.c (sound_cleanup, alsa_close): Likewise.
2014 * termcap.c (tgetent): Likewise.
2015 * xfns.c (x_default_font_parameter): Likewise.
2016 * xsettings.c (read_and_apply_settings): Likewise.
2018 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2019 (overrun_check_free): Protoize.
2021 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2023 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2024 since callers should never pass a negative size.
2025 Change the signature to match that of plain 'read' and 'write'; see
2026 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2027 * lisp.h: Update prototypes of emacs_write and emacs_read.
2029 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2031 * xdisp.c (redisplay_window): Don't try to determine the character
2032 position of the scroll margin if the window start point w->startp
2033 is outside the buffer's accessible region. (Bug#8468)
2035 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2037 Fix write-region and its subroutines for buffers > 2GB.
2038 * fileio.c (a_write, e_write): Modify declaration of arguments and
2039 local variables to support buffers larger than 2GB.
2040 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2042 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2043 argument, local variables, and return value.
2045 * lisp.h: Update prototypes of emacs_write and emacs_read.
2047 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2049 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2051 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2053 Fix more problems found by GCC 4.6.0's static checks.
2055 * xdisp.c (vmessage): Use a better test for character truncation.
2057 * charset.c (load_charset_map): <, not <=, for optimization,
2058 and to avoid potential problems with integer overflow.
2059 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2060 * casetab.c (set_identity, shuffle): Likewise.
2061 * editfns.c (Fformat): Likewise.
2062 * syntax.c (skip_chars): Likewise.
2064 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2065 This also lets GCC 4.6.0 generate slightly better loop code.
2067 * callint.c (Fcall_interactively): <, not <=, for optimization.
2068 (Fcall_interactively): Count the number of arguments produced,
2069 not the number of arguments given. This is simpler and lets GCC
2070 4.6.0 generate slightly better code.
2072 * ftfont.c: Distingish more carefully between FcChar8 and char.
2073 The previous code passed unsigned char * to a functions like
2074 strlen and xstrcasecmp that expect char *, which does not
2075 conform to the C standard.
2076 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2077 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2078 char * when the C standard requires it.
2080 * keyboard.c (read_char): Remove unused var.
2082 * eval.c: Port to Windows vsnprintf (Bug#8435).
2084 (SIZE_MAX): Define if the headers do not.
2085 (verror): Do not give up if vsnprintf returns a negative count.
2086 Instead, grow the buffer. This ports to Windows vsnprintf, which
2087 does not conform to C99. Problem reported by Eli Zaretskii.
2088 Also, simplify the allocation scheme, by avoiding the need for
2089 calling realloc, and removing the ALLOCATED variable.
2091 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2093 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2094 But keep the doprint source code for now, as we might revamp it
2095 and use it again (Bug#8435).
2096 * lisp.h (doprnt): Remove.
2097 * Makefile.in (base_obj): Remove doprnt.o.
2098 * deps.mk (doprnt.o): Remove.
2100 error: Print 32- and 64-bit integers portably (Bug#8435).
2101 Without this change, on typical 64-bit hosts error ("...%d...", N)
2102 was used to print both 32- and 64-bit integers N, which relied on
2104 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2106 * lisp.h (error, verror): Mark as printf-like functions.
2107 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2108 Report overflow in size calculations when allocating printf buffer.
2109 Do not truncate output string at its first null byte.
2110 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2111 Truncate the output at a character boundary, since vsnprintf does not
2113 * charset.c (check_iso_charset_parameter): Convert internal
2114 character to string before calling 'error', since %c now has the
2116 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2117 overflow when computing char to be passed to 'error'. Do not
2118 pass Lisp_Object to 'error'; pass the integer instead.
2119 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2120 formatted with plain %d.
2122 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2124 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2126 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2128 * xterm.c (x_catch_errors): Remove duplicate declaration.
2130 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2132 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2134 2011-04-10 Jim Meyering <meyering@redhat.com>
2136 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2137 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2138 return ssize_t not "int", and use size_t as the buffer length.
2139 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2140 * gnutls.h: Update declarations.
2141 * process.c (read_process_output): Use ssize_t, to match.
2142 (send_process): Likewise.
2144 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2146 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2148 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2150 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2151 Use unsigned char, to match FcChar8 type definition.
2153 * xterm.c (handle_one_xevent):
2154 * xmenu.c (create_and_show_popup_menu):
2155 * xselect.c (x_decline_selection_request)
2156 (x_reply_selection_request): Avoid type-punned deref of X events.
2158 2011-04-09 Eli Zaretskii <eliz@gnu.org>
2160 Fix some uses of `int' instead of EMACS_INT.
2161 * search.c (string_match_1, fast_string_match)
2162 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2163 (scan_buffer, find_next_newline_no_quit)
2164 (find_before_next_newline, search_command, Freplace_match)
2165 (Fmatch_data): Make some `int' variables be EMACS_INT.
2167 * xdisp.c (display_count_lines): 3rd argument and return value now
2168 EMACS_INT. All callers changed.
2169 (pint2hrstr): Last argument is now EMACS_INT.
2171 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2172 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2173 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2174 (decode_coding_utf_16, decode_coding_emacs_mule)
2175 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2176 (decode_coding_ccl, decode_coding_charset)
2177 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2178 (decode_coding_iso_2022, decode_coding_emacs_mule)
2179 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2180 <char_offset, last_offset>: Declare EMACS_INT.
2181 (encode_coding_utf_8, encode_coding_utf_16)
2182 (encode_coding_emacs_mule, encode_invocation_designation)
2183 (encode_designation_at_bol, encode_coding_iso_2022)
2184 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2185 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2187 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2188 (encode_invocation_designation): Last argument P_NCHARS is now
2190 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2191 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2193 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2196 * ccl.c (Fccl_execute_on_string): Declare some variables
2199 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2201 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2203 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2205 * process.c (Fformat_network_address): Doc fix.
2207 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2209 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2211 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
2213 * keyboard.c (read_char): Call Lisp function help-form-show,
2214 instead of using internal_with_output_to_temp_buffer.
2215 (Qhelp_form_show): New var.
2216 (syms_of_keyboard): Use DEFSYM macro.
2218 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2220 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2222 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
2224 * process.c (Flist_processes): Remove to Lisp.
2225 (list_processes_1): Delete.
2227 2011-04-06 Eli Zaretskii <eliz@gnu.org>
2229 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2231 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2233 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
2235 Fix more problems found by GCC 4.6.0's static checks.
2237 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2239 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2241 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
2243 * xdisp.c (vmessage): Mark as a printf-like function.
2245 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2247 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2249 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2250 printf-like functions.
2251 (tiff_load): Add casts to remove these marks before passing them
2252 to system-supplied API.
2254 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2256 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2257 This avoids several warnings with gcc -Wstrict-overflow.
2258 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2259 directly, rather than having caller test rule sign. This avoids
2260 some unnecessary tests.
2261 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2262 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2263 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
2265 * xfont.c (xfont_text_extents): Remove var that was set but not used.
2266 (xfont_open): Avoid unnecessary tests.
2268 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2270 * composite.h, composite.c (composition_gstring_put_cache):
2271 Use EMACS_INT, not int, for length.
2273 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2274 breaking out part of COMPOSITION_DECODE_RULE.
2275 (COMPOSITION_DECODE_RULE): Use it.
2276 * composite.c (get_composition_id): Remove unused local vars,
2277 by using the new macro.
2279 * textprop.c (set_text_properties_1): Change while to do-while,
2280 since the condition is always true at first.
2282 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2283 (interval_deletion_adjustment): Return unsigned value.
2286 * process.c (list_processes_1, create_pty, read_process_output):
2287 (exec_sentinel): Remove vars that were set but not used.
2288 (create_pty): Remove unnecessary "volatile"s.
2289 (Fnetwork_interface_info): Avoid possibility of int overflow.
2290 (read_process_output): Do adaptive read buffering even if carryover.
2291 (read_process_output): Simplify nbytes computation if buffered.
2293 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2295 * syntax.c (scan_words): Remove var that was set but not used.
2296 (update_syntax_table): Use unsigned instead of int.
2298 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2299 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2300 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2302 * print.c (print_error_message): Avoid int overflow.
2304 * font.c (font_list_entities): Redo for clarity,
2305 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2307 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2308 (font_score): Avoid potential overflow in diff calculation.
2310 * fns.c (substring_both): Remove var that is set but not used.
2311 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2313 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2315 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2316 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2317 can always succeed if overflow has undefined behavior.
2319 * search.c (boyer_moore, wordify): Remove vars set but not used.
2320 (wordify): Omit three unnecessary tests.
2322 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2323 All callers changed. This avoids the need for an unused var.
2325 * casefiddle.c (casify_region): Remove var that is set but not used.
2327 * dired.c (file_name_completion): Remove var that is set but not used.
2329 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2331 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2332 (Finsert_file_contents): Remove unnecessary code checking fd.
2334 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2335 Check for integer overflow on size calculations.
2337 * buffer.c (Fprevious_overlay_change): Remove var that is set
2340 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2341 Remove vars that are set but not used.
2342 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2343 (timer_check_2): Mark vars as initialized.
2345 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2347 * image.c (lookup_image): Remove var that is set but not used.
2348 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2350 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2351 that are set but not used.
2353 * xfns.c (make_invisible_cursor): Don't return garbage
2354 if XCreateBitmapFromData fails (Bug#8410).
2356 * xselect.c (x_get_local_selection, x_handle_property_notify):
2357 Remove vars that are set but not used.
2359 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2360 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2362 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2363 Remove var that is set but not used.
2364 (scroll_bar_windows_size): Now size_t, not int.
2365 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2368 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2369 (map_tty_color) [!defined MSDOS]: Likewise.
2371 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2373 * coding.c: Remove vars that are set but not used.
2374 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2375 All callers changed.
2376 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2377 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2378 (decode_coding_charset): Remove vars that are set but not used.
2380 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2381 that is set but not used.
2383 * print.c (print_object): Remove var that is set but not used.
2385 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2386 The gnulib version avoids calling malloc in the usual case,
2387 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2388 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2389 * filelock.c (current_lock_owner): Likewise.
2390 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2391 * sysdep.c: Include allocator.h, careadlinkat.h.
2392 (emacs_no_realloc_allocator): New static constant.
2393 (emacs_readlink): New function.
2394 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2395 ../lib/careadlinkat.h.
2397 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2399 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2400 first non-nil return value).
2402 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2404 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2405 if not defined (Bug#8403).
2407 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2409 * xdisp.c (display_count_lines): Remove parameter `start',
2410 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2411 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2412 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2413 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2414 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2415 and thereabouts. All callers changed.
2416 (get_per_char_metric): Remove parameter `f', unused since
2417 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2419 2011-04-02 Jim Meyering <meyering@redhat.com>
2421 do not dereference NULL upon failed strdup
2422 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2423 (ns_get_family): Likewise.
2425 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2427 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2429 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2431 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2434 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2436 Add lexical binding.
2438 * window.c (Ftemp_output_buffer_show): New fun.
2439 (Fsave_window_excursion):
2440 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2442 * lread.c (lisp_file_lexically_bound_p): New function.
2443 (Fload): Bind Qlexical_binding.
2444 (readevalloop): Remove `evalfun' arg.
2445 Bind Qinternal_interpreter_environment.
2446 (Feval_buffer): Bind Qlexical_binding.
2447 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2449 (syms_of_lread): Declare `lexical-binding'.
2451 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2453 * keyboard.c (eval_dyn): New fun.
2454 (menu_item_eval_property): Use it.
2456 * image.c (parse_image_spec): Use Ffunctionp.
2458 * fns.c (concat, mapcar1): Accept byte-code-functions.
2460 * eval.c (Fsetq): Handle lexical vars.
2461 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2462 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2463 (FletX, Flet): Obey lexical binding.
2464 (Fcommandp): Handle closures.
2465 (Feval): New `lexical' arg.
2466 (eval_sub): New function extracted from Feval. Use it almost
2467 everywhere where Feval was used. Look up vars in lexical env.
2469 (Ffunctionp): Move from subr.el.
2470 (Ffuncall): Handle closures.
2471 (apply_lambda): Remove `eval_flags'.
2472 (funcall_lambda): Handle closures and new byte-code-functions.
2473 (Fspecial_variable_p): New function.
2474 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2475 but without exporting it to Lisp.
2477 * doc.c (Fdocumentation, store_function_docstring):
2478 * data.c (Finteractive_form): Handle closures.
2480 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2483 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2485 (exec_byte_code): New function extracted from Fbyte_code to handle new
2486 calling convention for byte-code-functions. Add new byte-codes.
2488 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2490 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2492 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2494 * xdisp.c (redisplay_internal): Fix prototype.
2496 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2498 * xdisp.c (SCROLL_LIMIT): New macro.
2499 (try_scrolling): Use it when setting scroll_limit.
2500 Limit scrolling to 100 screen lines.
2501 (redisplay_window): Even when falling back on "recentering",
2502 position point in the window according to scroll-conservatively,
2503 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2505 (try_scrolling): When point is above the window, allow searching
2506 as far as scroll_max, or one screenful, to compute vertical
2507 distance from PT to the scroll margin position. This prevents
2508 try_scrolling from unnecessarily failing when
2509 scroll-conservatively is set to a value slightly larger than the
2510 window height. Clean up the case of PT below the margin at bottom
2511 of window: scroll_max can no longer be INT_MAX. When aggressive
2512 scrolling is in use, don't let point enter the opposite scroll
2513 margin as result of the scroll.
2514 (syms_of_xdisp) <scroll-conservatively>: Document the
2515 threshold of 100 lines for never-recentering scrolling.
2517 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2519 * dispextern.h (move_it_by_lines):
2520 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2521 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2522 (message_log_check_duplicate): Remove parameters `prev_bol' and
2523 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2524 (redisplay_internal): Remove parameter `preserve_echo_area',
2525 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2527 * indent.c (Fvertical_motion):
2528 * window.c (window_scroll_pixel_based, Frecenter):
2529 Don't pass `need_y_p' to `move_it_by_lines'.
2531 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2533 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2534 steal a few bits to be more compact.
2535 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2536 Remove unneeded casts.
2538 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2540 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2542 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2543 binding" message (bug#7967).
2545 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2547 Fix more problems found by GCC 4.6.0's static checks.
2549 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2550 Remove unused local var.
2552 * editfns.c (Fmessage_box): Remove unused local var.
2554 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2555 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2556 Omit unused local vars.
2557 * window.c (shrink_windows): Omit unused local var.
2558 * menu.c (digest_single_submenu): Omit unused local var.
2559 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2560 Omit unused local var.
2562 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2563 Don't assume string length fits in int.
2564 (keyremap_step, read_key_sequence): Use size_t for sizes.
2565 (read_key_sequence): Don't check last_real_key_start redundantly.
2567 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2568 instead of alloca (Bug#8344).
2570 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2571 (Fbacktrace_frame): Don't assume nframes fits in int.
2573 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2575 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2578 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2580 * cm.c (calccost): Turn while-do into do-while, for clarity.
2582 * keyboard.c (syms_of_keyboard): Use the same style as later
2583 in this function when indexing through an array. This also
2584 works around GCC bug 48267.
2586 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2588 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2590 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2591 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2593 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2594 This avoids undefined behavior on integer overflow, and is a bit
2595 more convenient anyway since it is compared to a size_t variable.
2597 Variadic C functions now count arguments with size_t, not int.
2598 This avoids an unnecessary limitation on 64-bit machines, which
2599 caused (substring ...) to crash on large vectors (Bug#8344).
2600 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2601 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
2602 All variadic functions and their callers changed accordingly.
2603 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2604 * data.c (arith_driver, float_arith_driver): Likewise.
2605 * editfns.c (general_insert_function): Likewise.
2606 * eval.c (struct backtrace.nargs, interactive_p)
2607 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2608 (funcall_lambda, mark_backtrace): Likewise.
2609 * fns.c (concat): Likewise.
2610 * frame.c (x_set_frame_parameters): Likewise.
2611 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2612 0 if not found, not -1. All callers changed.
2614 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2615 (stack_copy_size): Now size_t, not int.
2616 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2618 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2620 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2621 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2622 All callers changed.
2624 * lisp.h (multibyte_char_to_unibyte):
2625 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2626 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2627 * character.h (CHAR_TO_BYTE8):
2628 * cmds.c (internal_self_insert):
2629 * editfns.c (general_insert_function):
2630 * keymap.c (push_key_description):
2631 * search.c (Freplace_match):
2632 * xdisp.c (message_dolog, set_message_1): All callers changed.
2634 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2636 * keyboard.c (safe_run_hook_funcall): New function.
2637 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2638 don't set the hook to nil, but remove the offending function instead.
2639 (Qcommand_hook_internal): Remove, unused.
2640 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2641 Vcommand_hook_internal.
2643 * eval.c (enum run_hooks_condition): Remove.
2644 (funcall_nil, funcall_not): New functions.
2645 (run_hook_with_args): Call each function through a `funcall' argument.
2646 Remove `cond' argument, now redundant.
2647 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2648 (Frun_hook_with_args_until_failure): Adjust accordingly.
2649 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2651 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2653 * dispextern.h (string_buffer_position): Remove declaration.
2655 * print.c (strout): Remove parameter `multibyte', unused since
2656 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2658 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2659 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2660 All callers changed.
2662 * w32.c (_wsa_errlist): Use braces for struct initializers.
2664 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2665 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2666 All callers changed.
2667 (string_buffer_position): Likewise. Also, make static (it's never
2668 used outside xdisp.c).
2669 (cursor_row_p): Remove parameter `w', unused since
2670 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2671 (decode_mode_spec): Remove parameter `precision', introduced during
2672 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2673 All callers changed.
2675 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2677 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2679 2011-03-27 Anders Lindgren <andlind@gmail.com>
2681 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2682 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2683 (ns_update_auto_hide_menu_bar): New functions.
2684 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2685 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2686 ns_constrain_all_frames.
2687 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2688 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2690 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2692 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2694 2011-03-27 Glenn Morris <rgm@gnu.org>
2696 * syssignal.h: Replace RETSIGTYPE with void.
2697 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2698 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2699 Replace SIGTYPE with void everywhere.
2700 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2701 * s/template.h (SIGTYPE): Remove commented out definition.
2703 2011-03-26 Eli Zaretskii <eliz@gnu.org>
2705 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2706 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2708 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
2710 * w32.c (read_unc_volume): Use parameter `henum', instead of
2711 global variable `wget_enum_handle'.
2713 * keymap.c (describe_vector): Remove parameters `indices' and
2714 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2715 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2717 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2719 * keyboard.c (timer_check): Remove parameter `do_it_now',
2720 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2721 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2722 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2724 * keyboard.c (read_char):
2725 * w32menu.c (w32_menu_display_help):
2726 * xmenu.c (show_help_event, menu_help_callback):
2727 Adjust calls to `show_help_echo'.
2729 * gtkutil.c (xg_maybe_add_timer):
2730 * keyboard.c (readable_events):
2731 * process.c (wait_reading_process_output):
2732 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2734 * insdel.c (adjust_markers_gap_motion):
2735 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2736 (gap_left, gap_right): Don't call it.
2738 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
2740 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2741 incurred during fontification.
2743 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2745 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2746 (DEFVAR_PER_BUFFER): Don't pass it.
2748 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2749 (scrolling_window): Don't pass it.
2751 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2753 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2755 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2757 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2758 of variables specific to SELinux and computation of `encoded_absname'.
2760 * image.c (XPutPixel): Remove unused variable `height'.
2762 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2764 * unexw32.c (get_section_info): Remove unused variable `section'.
2766 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2767 (system_process_attributes): Remove unused variable `sess'.
2768 (sys_read): Remove unused variable `err'.
2770 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2771 (w32_wnd_proc): Remove unused variable `isdead'.
2772 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2773 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2774 (x_create_tip_frame): Remove unused variable `tem'.
2776 * w32inevt.c (w32_console_read_socket):
2777 Remove unused variable `no_events'.
2779 * w32term.c (x_draw_composite_glyph_string_foreground):
2780 Remove unused variable `width'.
2782 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
2784 * w32term.c (x_set_glyph_string_clipping):
2785 Don't pass uninitialized region to CombineRgn.
2787 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
2789 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2790 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2791 (Fx_close_connection): Remove unused variable `i'.
2793 * w32font.c (w32font_draw): Return number of glyphs.
2794 (w32font_open_internal): Remove unused variable `i'.
2795 (w32font_driver): Add missing initializer.
2797 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2798 (fill_in_menu): Remove unused variable `items_added'.
2800 * w32term.c (last_mouse_press_frame): Remove static global variable.
2801 (w32_clip_to_row): Remove unused variable `f'.
2802 (x_delete_terminal): Remove unused variable `i'.
2804 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2805 (NOTHING): Remove unused static global variable.
2806 (uniscribe_check_otf): Remove unused variable `table'.
2807 (uniscribe_font_driver): Add missing initializers.
2809 2011-03-23 Julien Danjou <julien@danjou.info>
2811 * term.c (Fsuspend_tty, Fresume_tty):
2812 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2813 * window.c (temp_output_buffer_show):
2814 * insdel.c (signal_before_change):
2815 * frame.c (Fhandle_switch_frame):
2816 * fileio.c (Fdo_auto_save):
2817 * emacs.c (Fkill_emacs):
2818 * editfns.c (save_excursion_restore):
2819 * cmds.c (internal_self_insert):
2820 * callint.c (Fcall_interactively):
2821 * buffer.c (Fkill_all_local_variables):
2822 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2824 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
2825 unconditionnaly since it does the check itself.
2827 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
2829 Fix more problems found by GCC 4.5.2's static checks.
2831 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2832 the first time through the loop, since we know p0 < p1 then.
2833 This also avoids a gcc -Wstrict-overflow warning.
2835 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2836 leading to a memory leak, possible in functions like
2837 load_charset_map_from_file that can allocate an unbounded number
2838 of objects (Bug#8318).
2840 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2841 that could (at least in theory) be that large.
2843 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2844 This is less likely to overflow, and avoids undefined behavior if
2845 overflow does occur. All callers changed. Use strtoul to scan
2846 for the unsigned long integer.
2847 (pint2hrstr): Simplify and tune code slightly.
2848 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
2850 * scroll.c (do_scrolling): Work around GCC bug 48228.
2851 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2853 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2854 This also avoids a warning with gcc -Wstrict-overflow.
2855 (validate_x_resource_name): Simplify count usage.
2856 This also avoids a warning with gcc -Wstrict-overflow.
2858 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2861 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
2863 * process.c (Fmake_network_process): Use socklen_t, not int,
2864 where POSIX says socklen_t is required in portable programs.
2865 This fixes a porting bug on hosts like 64-bit HP-UX, where
2866 socklen_t is wider than int (Bug#8277).
2867 (Fmake_network_process, server_accept_connection):
2868 (wait_reading_process_output, read_process_output):
2871 * process.c: Rename or move locals to avoid shadowing.
2872 (list_processes_1, Fmake_network_process):
2873 (read_process_output_error_handler, exec_sentinel_error_handler):
2874 Rename or move locals.
2875 (Fmake_network_process): Define label "retry_connect" only if needed.
2876 (Fnetwork_interface_info): Fix pointer signedness.
2877 (process_send_signal): Add cast to avoid pointer signedness problem.
2878 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
2879 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
2881 Make tparam.h and terminfo.c consistent.
2882 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2883 Include tparam.h instead, since it declares them.
2884 * cm.h (PC): Remove extern decl; tparam.h now does this.
2885 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2886 * terminfo.c: Include tparam.h, to check interfaces.
2887 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2888 (tparam): Adjust signature to match interface in tparam.h;
2889 this removes some undefined behavior. Check that outstring and len
2890 are zero, which they always are with Emacs.
2891 * tparam.h (PC, BC, UP): New extern decls.
2893 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
2894 (xftfont_open): Rename locals to avoid shadowing.
2896 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
2897 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2898 (OTF_TAG_SYM): Omit macro if not needed.
2899 (ftfont_list): Remove unused local.
2900 (get_adstyle_property, ftfont_pattern_entity):
2901 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2902 Rename locals to avoid shadowing.
2904 * xfont.c (xfont_list_family): Mark var as initialized.
2906 * xml.c (make_dom): Now static.
2908 * composite.c (composition_compute_stop_pos): Rename local to
2910 (composition_reseat_it): Remove unused locals.
2911 (find_automatic_composition, composition_adjust_point): Likewise.
2912 (composition_update_it): Mark var as initialized.
2913 (find_automatic_composition): Mark vars as initialized,
2914 with a FIXME (Bug#8290).
2916 character.h: Rename locals to avoid shadowing.
2917 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2918 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2919 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2920 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2923 * textprop.c (property_change_between_p): Remove; unused.
2925 * intervals.c (interval_start_pos): Now static.
2927 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2929 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2930 Rename locals to avoid shadowing.
2932 * sound.c (wav_play, au_play, Fplay_sound_internal):
2933 Fix pointer signedness.
2934 (alsa_choose_format): Remove unused local var.
2935 (wav_play): Initialize a variable to 0, to prevent undefined
2936 behavior (Bug#8278).
2938 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2940 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2942 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2943 clobbering (Bug#8298).
2944 * sysdep.c (sys_subshell): Likewise.
2945 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
2947 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2948 This should get cleaned up, so that child_setup has the
2949 same signature on all platforms.
2951 * callproc.c (call_process_cleanup): Now static.
2952 (relocate_fd): Rename locals to avoid shadowing.
2954 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
2956 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2957 not to be necessary, and produces flickering.
2959 2011-03-20 Glenn Morris <rgm@gnu.org>
2961 * config.in: Remove file.
2963 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
2965 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2966 are now in src/globals.h.
2967 (syms_of_minibuf): Remove spurious & from previous change.
2969 2011-03-20 Leo <sdl.web@gmail.com>
2971 * minibuf.c (completing-read-function): New variable.
2972 (completing-read-default): Rename from completing-read.
2973 (completing-read): Call completing-read-function.
2975 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2977 * xfaces.c (Fx_load_color_file):
2978 Read color file from absolute filename (bug#8250).
2980 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2982 * makefile.w32-in: Update dependencies.
2984 2011-03-17 Eli Zaretskii <eliz@gnu.org>
2986 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2988 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2990 Fix more problems found by GCC 4.5.2's static checks.
2992 * process.c (make_serial_process_unwind, send_process_trap):
2993 (sigchld_handler): Now static.
2995 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2996 That way, the code declares only the vars that it needs.
2997 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2998 * s/cygwin.h (PTY_ITERATION): Likewise.
2999 * s/darwin.h (PTY_ITERATION): Likewise.
3000 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3002 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3003 * process.c (allocate_pty): Don't declare stb unless it's needed.
3005 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3006 (CONSTANTLIM): Remove; unused.
3007 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3008 Define only if needed.
3010 * unexelf.c (unexec): Name an expression,
3011 to avoid gcc -Wbad-function-cast warning.
3012 Use a different way to cause a compilation error if anyone uses
3013 n rather than nn, a way that does not involve shadowing.
3014 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3016 * deps.mk (unexalpha.o): Remove; unused.
3018 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3019 * unexec.h: New file.
3020 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3021 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3023 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3024 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3025 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3026 Change as necessary to match prototype in unexec.h.
3028 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3030 (back_comment, skip_chars): Mark vars as initialized.
3032 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3033 Rename locals to avoid shadowing.
3035 * lread.c (read1): Rewrite so as not to use empty "else".
3036 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3038 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3040 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3041 warning when compiling print.c.
3043 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3044 instead of using an uninitialized var.
3045 (font_sort_entities): Mark var as initialized.
3047 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3049 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3050 pointers to constants.
3051 (font_parse_fcname): Remove unused vars.
3052 (font_delete_unmatched): Now static.
3053 (font_get_spec): Remove; unused.
3054 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3055 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3056 Rename or move locals to avoid shadowing.
3058 * fns.c (require_nesting_list, require_unwind): Now static.
3059 (Ffillarray): Rename locals to avoid shadowing.
3061 * floatfns.c (domain_error2): Define only if needed.
3062 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3064 * alloc.c (mark_backtrace): Move decl from here ...
3065 * lisp.h: ... to here, so that it can be checked.
3067 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3068 (Fdefvar): Rewrite so as not to use empty "else".
3069 (lisp_indirect_variable): Name an expression,
3070 to avoid gcc -Wbad-function-cast warning.
3071 (Fdefvar): Rename locals to avoid shadowing.
3073 * callint.c (quotify_arg, quotify_args): Now static.
3074 (Fcall_interactively): Rename locals to avoid shadowing.
3075 Use const pointer when appropriate.
3077 * lisp.h (get_system_name, get_operating_system_release):
3078 Move decls here, to check interfaces.
3079 * process.c (get_operating_system_release): Move decl to lisp.h.
3080 * xrdb.c (get_system_name): Likewise.
3081 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3082 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3083 some of which prompt warnings from gcc -Wbad-function-cast.
3084 (Fformat_time_string, Fencode_time, Finsert_char):
3085 (Ftranslate_region_internal, Fformat):
3086 Rename or remove local vars to avoid shadowing.
3087 (Ftranslate_region_internal): Mark var as initialized.
3089 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3092 * lisp.h (eassert): Check that the argument compiles, even if
3093 ENABLE_CHECKING is not defined.
3095 * data.c (Findirect_variable): Name an expression, to avoid
3096 gcc -Wbad-function-cast warning.
3097 (default_value, arithcompare, arith_driver, arith_error): Now static.
3098 (store_symval_forwarding): Rename local to avoid shadowing.
3099 (Fmake_variable_buffer_local, Fmake_local_variable):
3100 Mark variables as initialized.
3101 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3103 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
3104 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3105 Rename locals to avoid shadowing.
3106 (mark_stack): Move local variables into the #ifdef region where
3108 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3109 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3111 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3112 (GC_STRING_CHARS): Remove; not used.
3113 (Fmemory_limit): Cast sbrk's returned value to char *.
3115 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3116 avoids undefined behavior in theory.
3118 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3120 Use functions, not macros, for up- and down-casing (Bug#8254).
3121 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3122 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3123 to use the following functions instead of these macros.
3124 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3125 EMACS_INT, since callers assume the returned value fits in int.
3126 (upcase1): Likewise, for UPCASE_TABLE.
3127 (uppercasep, lowercasep, upcase): New static inline functions.
3128 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
3129 the race-condition problem in the old DOWNCASE.
3131 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3132 Rename locals to avoid shadowing.
3133 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
3134 (regex_compile, re_search_2, re_match_2_internal):
3135 Remove unused local vars.
3136 (FREE_VAR): Rewrite so as not to use empty "else",
3137 which gcc can warn about.
3138 (regex_compile, re_match_2_internal): Mark locals as initialized.
3139 (RETALLOC_IF): Define only if needed.
3140 (WORDCHAR_P): Likewise. This one is never needed, but is used
3141 only in a comment talking about a compiler bug, so put inside
3142 the #if 0 of that comment.
3143 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3144 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3147 * search.c (boyer_moore): Rename locals to avoid shadowing.
3148 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3149 (PREV_CHAR_BOUNDARY): Likewise.
3151 * search.c (simple_search): Remove unused var.
3153 * dired.c (compile_pattern): Move decl from here ...
3154 * lisp.h: ... to here, so that it can be checked.
3155 (struct re_registers): New forward decl.
3157 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3159 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3161 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3162 Rename locals to avoid shadowing.
3163 (Fvertical_motion): Mark locals as initialized.
3165 * casefiddle.c (casify_object, casify_region): Now static.
3166 (casify_region): Mark local as initialized.
3168 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3170 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3171 New macros, so that the caller can use some names other than
3172 gcpro1, gcpro2, etc.
3173 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3175 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3176 argument, for consistency with GCPRO2_VAR, etc: it is now the
3177 prefix of the variable, not the variable itself. All uses
3179 * dired.c (directory_files_internal, file_name_completion):
3180 Rename locals to avoid shadowing.
3182 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3183 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3184 dired.c's scmp function, had undefined behavior.
3185 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3186 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3187 * buffer.h: ... to here, because these macros use current_buffer,
3188 and the new implementation with inline functions needs to have
3189 current_buffer in scope now, rather than later when the macros
3191 (downcase, upcase1): New static inline functions.
3192 (DOWNCASE, UPCASE1): Reimplement using these functions.
3193 This avoids undefined behavior in expressions like
3194 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3195 from race conditions in accessing the global variables
3196 case_temp1 and case_temp2.
3197 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3198 * lisp.h (case_temp1, case_temp2): Remove their decls.
3199 * character.h (ASCII_CHAR_P): Move from here ...
3200 * lisp.h: ... to here, so that the inline functions mentioned
3203 * dired.c (directory_files_internal_unwind): Now static.
3205 * fileio.c (file_name_as_directory, directory_file_name):
3206 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3208 (file_name_as_directory): Use const pointers when appropriate.
3209 (Fexpand_file_name): Likewise. In particular, newdir might
3210 point at constant storage, so make it a const pointer.
3211 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
3212 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3214 (Fset_file_times, Finsert_file_contents, auto_save_error):
3215 Rename locals to avoid shadowing.
3217 * minibuf.c (choose_minibuf_frame_1): Now static.
3218 (Ftry_completion, Fall_completions): Rename or remove locals
3221 * marker.c (bytepos_to_charpos): Remove; unused.
3223 * lisp.h (verify_bytepos, count_markers): New decls,
3224 so that gcc does not warn that these functions aren't declared.
3226 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3227 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
3228 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
3229 (copy_text): Remove unused local var.
3231 * filelock.c (within_one_second): Now static.
3232 (lock_file_1): Rename local to avoid shadowing.
3234 * buffer.c (fix_overlays_before): Mark locals as initialized.
3235 (fix_start_end_in_overlays): Likewise. This function should be
3236 simplified by using pointers-to-pointers, but that's a different
3238 (switch_to_buffer_1): Now static.
3239 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3240 (report_overlay_modification): Rename locals to avoid shadowing.
3242 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
3243 Fix pointer signedness issue.
3244 (sys_subshell): Mark local as volatile if checking for lint,
3245 to suppress a gcc -Wclobbered warning that does not seem to be right.
3246 (MAXPATHLEN): Define only if needed.
3248 * process.c (serial_open, serial_configure): Move decls from here ...
3249 * systty.h: ... to here, so that they can be checked.
3251 * fns.c (get_random, seed_random): Move extern decls from here ...
3252 * lisp.h: ... to here, so that they can be checked.
3254 * sysdep.c (reset_io): Now static.
3255 (wait_for_termination_signal): Remove; unused.
3257 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3258 (copy_keymap_item, append_key, push_text_char_description):
3260 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
3261 (DENSE_TABLE_SIZE): Remove; unused.
3262 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3263 (describe_map_tree):
3264 Rename locals to avoid shadowing.
3266 * keyboard.c: Declare functions static if they are not used elsewhere.
3267 (echo_char, echo_dash, cmd_error, top_level_2):
3268 (poll_for_input, handle_async_input): Now static.
3269 (read_char, kbd_buffer_get_event, make_lispy_position):
3270 (make_lispy_event, make_lispy_movement, apply_modifiers):
3271 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3272 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3273 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
3274 (read_key_sequence, read_char): Mark locals as initialized.
3275 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
3277 * keyboard.h (make_ctrl_char): New decl.
3278 (mark_kboards): Move decl here ...
3279 * alloc.c (mark_kboards): ... from here.
3281 * lisp.h (force_auto_save_soon): New decl.
3283 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3284 (DEFINE_DUMMY_FUNCTION): New macro.
3285 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3287 (main): Add casts to avoid warnings
3288 if GCC considers string literals to be constants.
3290 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3292 * dbusbind.c: Pointer signedness fixes.
3293 (xd_signature, xd_append_arg, xd_initialize):
3294 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3295 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3296 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3297 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3299 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3300 if GCC considers string literals to be constants.
3301 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3303 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3305 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3306 (print_preprocess, print_object): New macro to fix last change.
3308 * print.c (print_preprocess): Don't forget font objects.
3310 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
3312 * emacs.c (USAGE3): Doc fixes.
3314 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3316 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3319 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3321 * lisp.h (VWindow_system, Qfile_name_history):
3322 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3323 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3324 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3326 * w32select.c: Don't #include "keyboard.h".
3327 (run_protected): Add extern declaration for waiting_for_input.
3329 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3330 * w32console.c (detect_input_pending, read_input_pending)
3331 (encode_terminal_code):
3332 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3333 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3334 (w32_system_caret_y, Qfile_name_history):
3335 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3336 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3337 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3338 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3339 * w32proc.c (Qlocal, report_file_error):
3340 * w32term.c (Vwindow_system, updating_frame):
3341 * w32uniscribe.c (initialized, uniscribe_font_driver):
3342 Remove unneeded extern declarations.
3344 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3346 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3348 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3350 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3351 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3352 These macros can no longer be used for assignment.
3354 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3355 Assign struct members directly, instead of using BUF_BEGV etc.
3356 (record_buffer_markers, fetch_buffer_markers): New functions for
3357 recording and fetching special buffer markers.
3358 (set_buffer_internal_1, set_buffer_temp): Use them.
3360 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3362 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3364 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3365 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3367 * xdisp.c (hscroll_window_tree):
3368 (reconsider_clip_changes): Use PT instead of BUF_PT.
3370 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3372 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3373 $(EMACS_ROOT)/lib/intprops.h.
3375 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3377 Fix more problems found by GCC 4.5.2's static checks.
3379 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3380 to unsigned char * to avoid compiler diagnostic.
3381 (xg_free_frame_widgets): Make it clear that a local variable is
3382 needed only if USE_GTK_TOOLTIP.
3383 (gdk_window_get_screen): Make it clear that this macro is needed
3384 only if USE_GTK_TOOLTIP.
3385 (int_gtk_range_get_value): New function, which avoids a diagnostic
3386 from gcc -Wbad-function-cast.
3387 (xg_set_toolkit_scroll_bar_thumb): Use it.
3388 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3389 diagnostic from gcc -Wbad-function-cast.
3390 (get_utf8_string, xg_get_file_with_chooser):
3391 Rename locals to avoid shadowing.
3392 (create_dialog): Move locals to avoid shadowing.
3394 * xgselect.c (xg_select): Remove unused var.
3396 * image.c (four_corners_best): Mark locals as initialized.
3397 (gif_load): Initialize transparent_p to zero (Bug#8238).
3398 Mark another local as initialized.
3399 (my_png_error, my_error_exit): Mark with NO_RETURN.
3401 * image.c (clear_image_cache): Now static.
3402 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3403 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3404 (x_edge_detection): Remove unnecessary cast that
3405 gcc -Wbad-function-cast diagnoses.
3406 (gif_load): Fix pointer signedness.
3407 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3408 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3410 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3412 Improve quality of tests for time stamp overflow.
3413 For example, without this patch (encode-time 0 0 0 1 1
3414 1152921504606846976) returns the obviously-bogus value (-948597
3415 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3416 reports time overflow. See
3417 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3418 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3419 * editfns.c: Include limits.h and intprops.h.
3420 (TIME_T_MIN, TIME_T_MAX): New macros.
3421 (time_overflow): Move earlier, to before first use.
3422 (hi_time, lo_time): New functions, for an accurate test for
3424 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3425 (Fget_internal_run_time): Don't assume time_t fits in int.
3426 (make_time): Use list2 instead of Fcons twice.
3427 (Fdecode_time): More accurate test for out-of-range times.
3428 (check_tm_member): New function.
3429 (Fencode_time): Use it, to test for out-of-range times.
3430 (lisp_time_argument): Don't rely on undefined left-shift and
3431 right-shift behavior when checking for time stamp overflow.
3433 * editfns.c (time_overflow): New function, refactoring common code.
3434 (Fformat_time_string, Fdecode_time, Fencode_time):
3435 (Fcurrent_time_string): Use it.
3437 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3438 * dired.c (make_time): Move to ...
3439 * editfns.c (make_time): ... here.
3440 * systime.h: Note the move.
3442 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3444 * fringe.c (update_window_fringes): Remove unused variables.
3446 * unexmacosx.c (copy_data_segment): Also copy __got section.
3449 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3451 * termcap.c [MSDOS]: Include "msdos.h".
3452 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3453 Constify `char *' arguments and their references according to
3454 prototypes in tparam.h.
3456 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3458 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3459 Adapt all references accordingly.
3461 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3463 2011-03-11 Tom Tromey <tromey@redhat.com>
3465 * buffer.c (syms_of_buffer): Remove obsolete comment.
3467 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3469 * termhooks.h (encode_terminal_code): Declare prototype.
3471 * msdos.c (encode_terminal_code): Don't declare prototype.
3473 * term.c (encode_terminal_code): Now external again, used by
3474 w32console.c and msdos.c.
3476 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3477 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3479 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3481 Fix some minor problems found by GCC 4.5.2's static checks.
3483 * fringe.c (update_window_fringes): Mark locals as initialized
3485 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3487 * alloc.c (mark_fringe_data): Move decl from here ...
3488 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3489 to check its interface.
3490 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3492 * fontset.c (free_realized_fontset): Now static.
3493 (Fset_fontset_font): Rename local to avoid shadowing.
3494 (fontset_font): Mark local as initialized.
3495 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3497 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3499 * xselect.c (x_disown_buffer_selections): Remove; not used.
3500 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3501 (x_own_selection, Fx_disown_selection_internal): Rename locals
3503 (x_handle_dnd_message): Remove local to avoid shadowing.
3505 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3506 so that the caller can use some name other than gcpro1.
3507 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3508 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3509 (Fx_backspace_delete_keys_p):
3510 Use them to avoid shadowing, and rename vars to avoid shadowing.
3511 (x_decode_color, x_set_name, x_window): Now static.
3512 (Fx_create_frame): Add braces to silence GCC warning.
3513 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3514 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3515 Remove unused locals.
3516 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3517 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3518 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3521 * xterm.h (x_mouse_leave): New decl.
3523 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3524 Remove unused functions.
3525 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3526 (x_calc_absolute_position): Now static.
3527 (XTread_socket): Don't define label "out" unless it's used.
3528 Don't declare local "event" unless it's used.
3529 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3530 unless they are used.
3531 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3532 (x_fatal_error_signal): Remove; not used.
3533 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3534 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3535 (x_error_catcher, x_connection_closed, x_error_handler):
3536 (x_error_quitter, xembed_send_message, x_iconify_frame):
3537 (my_log_handler): Rename locals to avoid shadowing.
3538 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3539 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3541 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3542 Rename or move locals to avoid shadowing.
3543 (tty_defined_color, merge_face_heights): Now static.
3544 (free_realized_faces_for_fontset): Remove; not used.
3545 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3546 does not deduce is never used uninitialized.
3547 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3548 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3550 * terminal.c (store_terminal_param): Now static.
3552 * xmenu.c (menu_highlight_callback): Now static.
3553 (set_frame_menubar): Remove unused local.
3554 (xmenu_show): Rename parameter to avoid shadowing.
3555 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3556 since they might point to immutable storage.
3557 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3558 since it's unused otherwise.
3560 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3561 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3562 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3563 avoids a gcc -Wuninitialized diagnostic.
3564 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3565 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3566 does not deduce are never used uninitialized.
3568 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3570 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3571 * window.c (window_loop, size_window):
3572 (run_window_configuration_change_hook, enlarge_window): Likewise.
3574 * window.c (display_buffer): Now static.
3575 (size_window): Mark variables that gcc -Wuninitialized
3576 does not deduce are never used uninitialized.
3577 * window.h (check_all_windows): New decl, to forestall
3578 gcc -Wmissing-prototypes diagnostic.
3579 * dispextern.h (bidi_dump_cached_states): Likewise.
3581 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3583 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3585 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3586 and to avoid gcc -Wuninitialized warning.
3587 (load_charset_map): Mark variables that gcc -Wuninitialized
3588 does not deduce are never used uninitialized.
3589 (load_charset): Abort instead of using uninitialized var (Bug#8229).
3591 * coding.c (coding_set_source, coding_set_destination):
3592 Use "else { /* comment */ }" rather than "else /* comment */;"
3593 for clarity, and to avoid gcc -Wempty-body warning.
3594 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3595 a block, when the outer 'i' will do.
3596 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3597 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3598 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3599 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3600 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3601 Rename locals to avoid shadowing.
3602 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
3603 * coding.c (emacs_mule_char, encode_invocation_designation):
3604 Now static, since they're not used elsewhere.
3605 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
3606 (decode_coding_object, encode_coding_object, detect_coding_system):
3607 (decode_coding_emacs_mule): Mark variables that gcc
3608 -Wuninitialized does not deduce are never used uninitialized.
3609 (detect_coding_iso_2022): Initialize a local variable that might
3610 be used uninitialized. Leave a FIXME because it's not clear that
3611 this initialization is needed. (Bug#8211)
3612 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3613 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3614 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3615 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3616 Remove unused macros.
3618 * category.c (hash_get_category_set): Remove unused local var.
3619 (copy_category_table): Now static, since it's not used elsewhere.
3620 * character.c (string_count_byte8): Likewise.
3622 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3623 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3625 * chartab.c (copy_sub_char_table): Now static, since it's not used
3627 (sub_char_table_ref_and_range, char_table_ref_and_range):
3628 Rename locals to avoid shadowing.
3629 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
3631 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
3632 (BIDI_BOB): Remove unused macro.
3634 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3635 deduce are never used uninitialized.
3636 * term.c (encode_terminal_code): Likewise.
3638 * term.c (encode_terminal_code): Now static. Remove unused local.
3640 * tparam.h: New file.
3641 * term.c, tparam.h: Include it.
3642 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3643 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3644 Move these decls to tparam.h, and make them agree with what
3645 is actually in tparam.c. The previous trick of using incompatible
3646 decls in different modules does not conform to the C standard.
3647 All callers of tparam changed to use tparam's actual API.
3648 * tparam.c (tparam1, tparam, tgoto):
3649 Use const pointers where appropriate.
3651 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3652 * cm.h (struct cm): Likewise.
3653 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3654 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3655 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3656 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3657 (turn_on_face, init_tty): Likewise.
3658 * termchar.h (struct tty_display_info): Likewise.
3660 * term.c (term_mouse_position): Rename local to avoid shadowing.
3662 * alloc.c (mark_ttys): Move decl from here ...
3663 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3665 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3667 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3669 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
3671 * search.c (compile_pattern_1): Remove argument regp, unused since
3672 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3673 (compile_pattern): Don't pass it.
3675 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3677 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3678 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3680 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3682 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3684 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3685 gdk_window_get_screen, gdk_window_get_geometry,
3686 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3687 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3688 (xg_get_pixbuf_from_pixmap): New function.
3689 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3690 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3691 Call xg_get_pixbuf_from_pixmap instead of
3692 gdk_pixbuf_get_from_drawable.
3693 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3694 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3695 (xg_check_special_colors): Use GtkStyleContext and its functions
3697 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3698 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3699 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
3700 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3701 Call gtk_widget_get_preferred_size.
3702 (xg_frame_resized): gdk_window_get_geometry only takes 5
3704 (xg_win_to_widget, xg_event_is_for_menubar):
3705 Call gdk_x11_window_lookup_for_display.
3706 (xg_set_widget_bg): New function.
3707 (delete_cb): New function.
3708 (xg_create_frame_widgets): Connect delete-event to delete_cb.
3709 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3710 (xg_set_background_color): Call xg_set_widget_bg.
3711 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3712 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3713 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3714 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3716 (update_frame_tool_bar): Call gtk_widget_hide.
3717 (xg_initialize): Use GDK_KEY_g.
3719 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3721 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3723 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3724 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3725 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3727 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
3729 * w32xfns.c (select_palette): Check success of RealizePalette against
3730 GDI_ERROR, not zero.
3732 See ChangeLog.11 for earlier changes.
3738 Copyright (C) 2011 Free Software Foundation, Inc.
3740 This file is part of GNU Emacs.
3742 GNU Emacs is free software: you can redistribute it and/or modify
3743 it under the terms of the GNU General Public License as published by
3744 the Free Software Foundation, either version 3 of the License, or
3745 (at your option) any later version.
3747 GNU Emacs is distributed in the hope that it will be useful,
3748 but WITHOUT ANY WARRANTY; without even the implied warranty of
3749 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3750 GNU General Public License for more details.
3752 You should have received a copy of the GNU General Public License
3753 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.