* xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
[bpt/emacs.git] / src / ChangeLog
1 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2
3 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4
5 * process.c (keyboard_bit_set): Define only if SIGIO.
6 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7 (send_process): Repair possible setjmp clobbering.
8
9 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10
11 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12
13 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
14
15 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
16 Define only if needed.
17
18 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
19 by pacifying GCC about it. Maybe it's time to retire it?
20 * xfaces.c (USG, __TIMEVAL__): Likewise.
21
22 * dispextern.h (struct redisplay_interface): Rename param
23 to avoid shadowing.
24 * termhooks.h (struct terminal): Likewise.
25 * xterm.c (xembed_send_message): Likewise.
26
27 * insdel.c (make_gap_smaller): Define only if
28 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
29
30 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
31 it.
32
33 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
34 so that we aren't warned about unused symbols.
35
36 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
37
38 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
39
40 * xfns.c (x_real_positions): Mark locals as initialized.
41
42 * xmenu.c (xmenu_show): Don't use uninitialized vars.
43
44 * xterm.c: Fix problems found by static analysis with other toolkits.
45 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
46 (x_dispatch_event): Declare static if USE_GTK, and
47 define if USE_GTK || USE_X_TOOLKIT.
48 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
49 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
50 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only if
51 defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
52
53 * xmenu.c (menu_help_callback): Pointer type fixes.
54 Use const pointers when pointing at readonly data. Avoid pointer
55 signedness clashes.
56 (FALSE): Remove unused macro.
57 (update_frame_menubar): Remove unused decl.
58
59 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
60
61 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
62 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
63 (single_menu_item): Rename local to avoid shadowing.
64
65 * keyboard.c (make_lispy_event): Remove unused local var.
66
67 * frame.c, frame.h (x_get_resource_string): Bring this back, but
68 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
69
70 * bitmaps: Change bitmaps from unsigned char back to the X11
71 compatible char. Avoid the old compiler warnings about
72 out-of-range initializers by using, for example, '\xab' rather
73 than 0xab.
74
75 * xgselect.c (xgselect_initialize): Check vs interface
76 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
77
78 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
79
80 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
81 to read-only memory.
82
83 * fns.c (vector): Remove; this old hack is no longer needed.
84
85 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
86 Remove unused var.
87 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
88
89 * xrdb.c (x_load_resources): Omit unused local.
90
91 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
92 (x_window): Rename locals to avoid shadowing.
93 (USG): Use the kludged USG macro, to pacify gcc.
94
95 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
96 (x_term_init): Remove local to avoid shadowing.
97
98 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
99
100 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
101 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
102
103 2011-04-16 Eli Zaretskii <eliz@gnu.org>
104
105 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
106
107 Fix regex.c, syntax.c and friends for buffers > 2GB.
108 * syntax.h (struct gl_state_s): Declare character position members
109 EMACS_INT.
110
111 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
112
113 * textprop.c (verify_interval_modification, interval_of): Declare
114 arguments EMACS_INT.
115
116 * intervals.c (adjust_intervals_for_insertion): Declare arguments
117 EMACS_INT.
118
119 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
120
121 * indent.c (Fvertical_motion): Local variable it_start is now
122 EMACS_INT.
123
124 * regex.c (re_match, re_match_2, re_match_2_internal)
125 (bcmp_translate, regcomp, regexec, print_double_string)
126 (group_in_compile_stack, re_search, re_search_2, regex_compile)
127 (re_compile_pattern, re_exec): Declare arguments and local
128 variables `size_t' and `ssize_t' and return values `regoff_t', as
129 appropriate.
130 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
131 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
132 <compile_stack_type>: `size' and `avail' are now `size_t'.
133
134 * regex.h <regoff_t>: Use ssize_t, not int.
135 (re_search, re_search_2, re_match, re_match_2): Arguments that
136 specify buffer/string position and length are now ssize_t and
137 size_t. Return type is regoff_t.
138
139 2011-04-16 Ben Key <bkey76@gmail.com>
140
141 * nsfont.m: Fixed bugs in ns_get_family and
142 ns_descriptor_to_entity that were caused by using free to
143 deallocate memory blocks that were allocated by xmalloc (via
144 xstrdup). This caused Emacs to crash when compiled with
145 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
146 --enable-checking=xmallocoverrun). xfree is now used to
147 deallocate these memory blocks.
148
149 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
150
151 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
152
153 emacs_write: Accept and return EMACS_INT for sizes.
154 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
155 et seq.
156 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
157 Accept and return EMACS_INT.
158 (emacs_gnutls_write): Return the number of bytes written on
159 partial writes.
160 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
161 (emacs_read, emacs_write): Remove check for negative size, as the
162 Emacs source code has been audited now.
163 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
164 (emacs_read, emacs_write): Use it.
165 * process.c (send_process): Adjust to the new signatures of
166 emacs_write and emacs_gnutls_write. Do not attempt to store
167 a byte offset into an 'int'; it might overflow.
168 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
169
170 * sound.c: Don't assume sizes fit in 'int'.
171 (struct sound_device.period_size, alsa_period_size):
172 Return EMACS_INT, not int.
173 (struct sound_device.write, vox_write, alsa_write):
174 Accept EMACS_INT, not int.
175 (wav_play, au_play): Use EMACS_INT to store sizes and to
176 record read return values.
177
178 2011-04-15 Ben Key <bkey76@gmail.com>
179
180 * keyboard.c (Qundefined): Don't declare static since it is used
181 in nsfns.m.
182 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
183 static since they are used in nsfont.m.
184
185 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
186
187 * process.c (Qprocessp): Don't declare static.
188 * lisp.h (Qprocessp): Declare again.
189
190 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
191
192 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
193
194 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
195
196 Improve C-level modularity by making more things 'static'.
197
198 Don't publish debugger-only interfaces to other modules.
199 * lisp.h (safe_debug_print, debug_output_compilation_hack):
200 (verify_bytepos, count_markers): Move decls to the only modules
201 that need them.
202 * region-cache.h (pp_cache): Likewise.
203 * window.h (check_all_windows): Likewise.
204 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
205
206 * sysdep.c (croak): Now static, if
207 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
208 * syssignal.h (croak): Declare only if not static.
209
210 * alloc.c (refill_memory_reserve): Now static if
211 !defined REL_ALLOC || defined SYSTEM_MALLOC.
212 * lisp.h (refill_memory_reserve): Declare only if not static.
213
214 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
215 Define only if USE_LUCID.
216
217 * xrdb.c (x_customization_string, x_rm_string): Now static.
218
219 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
220 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
221
222 * xdisp.c (draw_row_with_mouse_face): Now static.
223 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
224
225 * window.h (check_all_windows): Mark externally visible.
226
227 * window.c (window_deletion_count): Now static.
228
229 * undo.c: Make symbols static if they're not exported.
230 (last_undo_buffer, last_boundary_position, pending_boundary):
231 Now static.
232
233 * textprop.c (interval_insert_behind_hooks): Now static.
234 (interval_insert_in_front_hooks): Likewise.
235
236 * term.c: Make symbols static if they're not exported.
237 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
238 (max_frame_lines, tty_set_terminal_modes):
239 (tty_reset_terminal_modes, tty_turn_off_highlight):
240 (get_tty_terminal): Now static.
241 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
242 * termhooks.h (term_mouse_moveto): Do not declare if
243 HAVE_WINDOW_SYSTEM.
244 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
245 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
246
247 * sysdep.c: Make symbols static if they're not exported.
248 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
249 Now static.
250 (sigprocmask_set, full_mask): Remove; unused.
251 (wait_debugging): Mark as visible.
252 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
253 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
254
255 * syntax.c (syntax_temp): Define only if !__GNUC__.
256
257 * sound.c (current_sound_device, current_sound): Now static.
258
259 * search.c (searchbufs, searchbuf_head): Now static.
260
261 * scroll.c (scroll_cost): Remove; unused.
262 * dispextern.h (scroll_cost): Remove decl.
263
264 * region-cache.h (pp_cache): Mark as externally visible.
265
266 * process.c: Make symbols static if they're not exported.
267 (process_tick, update_tick, create_process, chan_process):
268 (Vprocess_alist, proc_buffered_char, datagram_access):
269 (fd_callback_data, send_process_frame, process_sent_to): Now static.
270 (deactivate_process): Mark defn as static, as well as decl.
271 * lisp.h (create_process): Remove decl.
272 * process.h (chan_process, Vprocess_alist): Remove decls.
273
274 * print.c: Make symbols static if they're not exported.
275 (print_depth, new_backquote_output, being_printed, print_buffer):
276 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
277 (print_interval, print_number_index, initial_stderr_stream):
278 Now static.
279 * lisp.h (Fprinc): Remove decl.
280 (debug_output_compilation_hack): Mark as externally visible.
281
282 * sysdep.c (croak): Move decl from here to syssignal.h.
283 * syssignal.h (croak): Put it here, so the API can be checked when
284 'croak' is called from dissociate_if_controlling_tty.
285
286 * minibuf.c: Make symbols static if they're not exported.
287 (minibuf_save_list, choose_minibuf_frame): Now static.
288 * lisp.h (choose_minibuf_frame): Remove decl.
289
290 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
291
292 * lread.c: Make symbols static if they're not exported.
293 (read_objects, initial_obarray, oblookup_last_bucket_number):
294 Now static.
295 (make_symbol): Remove; unused.
296 * lisp.h (initial_obarray, make_symbol): Remove decls.
297
298 * keyboard.c: Make symbols static if they're not exported.
299 (single_kboard, recent_keys_index, total_keys, recent_keys):
300 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
301 (this_single_command_key_start, echoing, last_auto_save):
302 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
303 (command_loop, echo_now, keyboard_init_hook, help_char_p):
304 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
305 (Vlispy_mouse_stem, double_click_count):
306 Now static.
307 (force_auto_save_soon): Define only if SIGDANGER.
308 (ignore_mouse_drag_p): Now static if
309 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
310 (print_help): Remove; unused.
311 (stop_character, last_timer_event): Mark as externally visible.
312 * keyboard.h (ignore_mouse_drag_p): Declare only if
313 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
314 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
315 * lisp.h (echoing): Remove decl.
316 (force_auto_save_soon): Declare only if SIGDANGER.
317 * xdisp.c (redisplay_window): Simplify code, to make it more
318 obvious that ignore_mouse_drag_p is not accessed if !defined
319 USE_GTK && !defined HAVE_NS.
320
321 * intervals.c: Make symbols static if they're not exported.
322 (merge_properties_sticky, merge_interval_right, delete_interval):
323 Now static.
324 * intervals.h (merge_interval_right, delete_interval): Remove decls.
325
326 * insdel.c: Make symbols static if they're not exported.
327 However, leave prepare_to_modify_buffer alone. It's never
328 called from outside this function, but that appears to be a bug.
329 (combine_after_change_list, combine_after_change_buffer):
330 (adjust_after_replace, signal_before_change): Now static.
331 (adjust_after_replace_noundo): Remove; unused.
332 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
333 (signal_before_change): Remove decls.
334
335 * indent.c (val_compute_motion, val_vmotion): Now static.
336
337 * image.c: Make symbols static if they're not exported.
338 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
339 if USE_GTK.
340 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
341 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
342
343 * fringe.c (standard_bitmaps): Now static.
344 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
345
346 * frame.c: Make symbols static if they're not exported.
347 (x_report_frame_params, make_terminal_frame): Now static.
348 (get_frame_param): Now static, unless HAVE_NS.
349 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
350 (x_get_resource_string): Remove; not used.
351 * frame.h (make_terminal_frame, x_report_frame_params):
352 (x_get_resource_string); Remove decls.
353 (x_fullscreen_adjust): Declare only if WINDOWSNT.
354 * lisp.h (get_frame_param): Declare only if HAVE_NS.
355
356 * font.c, fontset.c: Make symbols static if they're not exported.
357 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
358 (FACE_SUITABLE_FOR_CHAR_P): Use it.
359 * font.c (font_close_object): Now static.
360 * font.h (font_close_object): Remove.
361 * fontset.c (FONTSET_OBJLIST): Remove.
362 (free_realized_fontset) #if-0 the body, which does nothing.
363 (face_suitable_for_char_p): #if-0, as it's never called.
364 * fontset.h (face_suitable_for_char_p): Remove decl.
365 * xfaces.c (face_at_string_position): Use
366 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
367 since 0 is always ASCII.
368
369 * fns.c (weak_hash_tables): Now static.
370
371 * fileio.c: Make symbols static if they're not exported.
372 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
373 (Vwrite_region_annotation_buffers): Now static.
374
375 * eval.c: Make symbols static if they're not exported.
376 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
377 * lisp.h (backtrace_list): Remove decl.
378
379 * emacs.c: Make symbols static if they're not exported.
380 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
381 (fatal_error_code, fatal_error_signal_hook, standard_args):
382 Now static.
383 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
384 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
385 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
386 * lisp.h (fatal_error_signal_hook): Remove decl.
387 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
388
389 * editfns.c: Move a (normally-unused) function to its only use.
390 * editfns.c, lisp.h (get_operating_system_release): Remove.
391 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
392 worth the hassle of breaking this out.
393
394 * xterm.c: Make symbols static if they're not exported.
395 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
396 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
397 (x_destroy_window, x_delete_display):
398 Now static.
399 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
400 (x_mouse_leave): Remove; unused.
401 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
402 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
403 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
404 Remove decls.
405 (x_mouse_leave): Declare only if WINDOWSNT.
406 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
407 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
408 USE_X_TOOLKIT.
409
410 * ftxfont.c: Make symbols static if they're not exported.
411 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
412 HAVE_FREETYPE.
413 * font.h (ftxfont_driver): Likewise.
414
415 * xfns.c: Make symbols static if they're not exported.
416 (x_last_font_name, x_display_info_for_name):
417 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
418 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
419 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
420 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
421 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
422 (last_show_tip_args): Now static.
423 (xic_defaut_fontset, xic_create_fontsetname): Define only if
424 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
425 (x_screen_planes): Remove; unused.
426 * dispextern.h (x_screen_planes): Remove decl.
427
428 * dispnew.c: Make symbols static if they're not exported.
429 * dispextern.h (redraw_garbaged_frames, scrolling):
430 (increment_row_positions): Remove.
431 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
432 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
433 Now static.
434 (redraw_garbaged_frames): Remove; unused.
435
436 * xfaces.c: Make symbols static if they're not exported.
437 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
438 Remove decls.
439 * xterm.h (defined_color): Remove decls.
440 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
441 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
442 (menu_face_changed_default, defined_color, free_realized_face):
443 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
444 (ascii_face_of_lisp_face): Remove; unused.
445
446 * xdisp.c: Make symbols static if they're not exported.
447 * dispextern.h (scratch_glyph_row, window_box_edges):
448 (glyph_to_pixel_coords, set_cursor_from_row):
449 (get_next_display_element, set_iterator_to_next):
450 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
451 (show_mouse_face): Remove decls
452 * frame.h (message_buf_print): Likewise.
453 * lisp.h (pop_message, set_message, check_point_in_composition):
454 Likewise.
455 * xterm.h (set_vertical_scroll_bar): Likewise.
456 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
457 (message_buf_print, scratch_glyph_row, displayed_buffer):
458 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
459 (get_next_display_element, show_mouse_face, window_box_edges):
460 (frame_to_window_pixel_xy, check_point_in_composition):
461 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
462 (glyph_to_pixel_coords): Remove; unused.
463
464 * dired.c (file_name_completion): Now static.
465
466 * dbusbind.c (xd_in_read_queued_messages): Now static.
467
468 * lisp.h (circular_list_error, FOREACH): Remove; unused.
469 * data.c (circular_list_error): Remove.
470
471 * commands.h (last_point_position, last_point_position_buffer):
472 (last_point_position_window): Remove decls.
473 * keyboard.c: Make these variables static.
474
475 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
476 decls.
477 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
478 (iso_code_class, detect_coding, code_convert_region): Now static.
479 (encode_coding_gap): Remove; unused.
480
481 * chartab.c (chartab_chars, chartab_bits): Now static.
482
483 * charset.h (charset_iso_8859_1): Remove decl.
484 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
485 Now static.
486
487 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
488 * ccl.c (Vccl_program_table): Now static.
489 (check_ccl_update): Remove; unused.
490
491 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
492 * category.h: ... from here.
493 * category.c (check_category_table, set_category_set): Now static.
494
495 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
496 * lisp.h: Remove these decls.
497
498 * buffer.c (buffer_count): Remove unused var.
499
500 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
501 so that it's not optimized away.
502 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
503 * dispextern.h (bidi_dump_cached_states): Remove, since it's
504 exported only to the debugger.
505
506 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
507 * atimer.h (run_all_atimers): Removed; not exported.
508
509 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
510 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
511 was inaccessible from Lisp.
512 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
513 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
514
515 alloc.c: Import and export fewer symbols, and remove unused items.
516 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
517 is defined.
518 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
519 it's not optimized away by whole-program optimization.
520 (message_enable_multibyte, free_misc): Remove.
521 (catchlist, handlerlist, mark_backtrace):
522 Declare only if BYTE_MARK_STACK.
523 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
524 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
525 (message_enable_multibyte): Remove decl.
526 (free_misc, interval_free_list, float_block, float_block_index):
527 (n_float_blocks, float_free_list, cons_block, cons_block_index):
528 (cons_free_list, last_marked_index):
529 Now static.
530 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
531 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
532 (mark_backtrace): Define only if BYTE_MARK_STACK.
533 * xdisp.c (message_enable_multibyte): Now static.
534
535 Declare Lisp_Object Q* variables to be 'static' if not exproted.
536 This makes it easier for human readers (and static analyzers)
537 to see whether these variables are used from other modules.
538 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
539 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
540 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
541 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
542 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
543 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
544 * xmenu.c, xselect.c:
545 Declare Q* vars static if they are not used in other modules.
546 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
547 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
548 Remove decls of unexported vars.
549 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
550
551 * lisp.h (DEFINE_FUNC): Make sname 'static'.
552
553 Make Emacs functions such as Fatom 'static' by default.
554 This makes it easier for human readers (and static analyzers)
555 to see whether these functions can be called from other modules.
556 DEFUN now defines a static function. To make the function external
557 so that it can be used in other C modules, use the new macro DEFUE.
558 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
559 (Finit_image_library):
560 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
561 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
562 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
563 Remove decls, since these functions are now static.
564 (Funintern, Fget_internal_run_time): New decls, since these functions
565 were already external.
566
567 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
568 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
569 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
570 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
571 * keyboard.c, keymap.c, lread.c:
572 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
573 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
574 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
575 Mark functions with DEFUE instead of DEFUN,
576 if they are used in other modules.
577 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
578 decls for now-static functions.
579 * buffer.h (Fdelete_overlay): Remove decl.
580 * callproc.c (Fgetenv_internal): Mark as internal.
581 * composite.c (Fremove_list_of_text_properties): Remove decl.
582 (Fcomposition_get_gstring): New forward static decl.
583 * composite.h (Fcomposite_get_gstring): Remove decl.
584 * dired.c (Ffile_attributes): New forward static decl.
585 * doc.c (Fdocumntation_property): New forward static decl.
586 * eval.c (Ffetch_bytecode): New forward static decl.
587 (Funintern): Remove extern decl; now in .h file where it belongs.
588 * fileio.c (Fmake_symbolic_link): New forward static decl.
589 * image.c (Finit_image_library): New forward static decl.
590 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
591 * intervals.h (Fprevious_property_change):
592 (Fremove_list_of_text_properties): Remove decls.
593 * keyboard.c (Fthis_command_keys): Remove decl.
594 (Fcommand_execute): New forward static decl.
595 * keymap.c (Flookup_key): New forward static decl.
596 (Fcopy_keymap): Now static.
597 * keymap.h (Flookup_key): Remove decl.
598 * process.c (Fget_process): New forward static decl.
599 (Fprocess_datagram_address): Mark as internal.
600 * syntax.c (Fsyntax_table_p): New forward static decl.
601 (skip_chars): Remove duplicate decl.
602 * textprop.c (Fprevious_property_change): New forward static decl.
603 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
604 Now internal.
605 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
606 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
607
608 * editfns.c (Fformat): Remove unreachable code.
609
610 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
611
612 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
613 change. (Bug#8496)
614
615 2011-04-13 Eli Zaretskii <eliz@gnu.org>
616
617 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
618 when at ZV. (Bug#8487)
619
620 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
621
622 * charset.c (Fclear_charset_maps): Use xfree instead of free.
623 (Bug#8437)
624 * keyboard.c (parse_tool_bar_item): Likewise.
625 * sound.c (sound_cleanup, alsa_close): Likewise.
626 * termcap.c (tgetent): Likewise.
627 * xfns.c (x_default_font_parameter): Likewise.
628 * xsettings.c (read_and_apply_settings): Likewise.
629
630 * alloc.c (overrun_check_malloc, overrun_check_realloc)
631 (overrun_check_free): Protoize.
632
633 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
634
635 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
636 since callers should never pass a negative size.
637 Change the signature to match that of plain 'read' and 'write'; see
638 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
639 * lisp.h: Update prototypes of emacs_write and emacs_read.
640
641 2011-04-11 Eli Zaretskii <eliz@gnu.org>
642
643 * xdisp.c (redisplay_window): Don't try to determine the character
644 position of the scroll margin if the window start point w->startp
645 is outside the buffer's accessible region. (Bug#8468)
646
647 2011-04-10 Eli Zaretskii <eliz@gnu.org>
648
649 Fix write-region and its subroutines for buffers > 2GB.
650 * fileio.c (a_write, e_write): Modify declaration of arguments and
651 local variables to support buffers larger than 2GB.
652 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
653
654 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
655 argument, local variables, and return value.
656
657 * lisp.h: Update prototypes of emacs_write and emacs_read.
658
659 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
660
661 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
662
663 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
664
665 Fix more problems found by GCC 4.6.0's static checks.
666
667 * xdisp.c (vmessage): Use a better test for character truncation.
668
669 * charset.c (load_charset_map): <, not <=, for optimization,
670 and to avoid potential problems with integer overflow.
671 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
672 * casetab.c (set_identity, shuffle): Likewise.
673 * editfns.c (Fformat): Likewise.
674 * syntax.c (skip_chars): Likewise.
675
676 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
677 This also lets GCC 4.6.0 generate slightly better loop code.
678
679 * callint.c (Fcall_interactively): <, not <=, for optimization.
680 (Fcall_interactively): Count the number of arguments produced,
681 not the number of arguments given. This is simpler and lets GCC
682 4.6.0 generate slightly better code.
683
684 * ftfont.c: Distingish more carefully between FcChar8 and char.
685 The previous code passed unsigned char * to a functions like
686 strlen and xstrcasecmp that expect char *, which does not
687 conform to the C standard.
688 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
689 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
690 char * when the C standard requires it.
691
692 * keyboard.c (read_char): Remove unused var.
693
694 * eval.c: Port to Windows vsnprintf (Bug#8435).
695 Include <limits.h>.
696 (SIZE_MAX): Define if the headers do not.
697 (verror): Do not give up if vsnprintf returns a negative count.
698 Instead, grow the buffer. This ports to Windows vsnprintf, which
699 does not conform to C99. Problem reported by Eli Zaretskii.
700 Also, simplify the allocation scheme, by avoiding the need for
701 calling realloc, and removing the ALLOCATED variable.
702
703 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
704
705 Remove invocations of doprnt, as Emacs now uses vsnprintf.
706 But keep the doprint source code for now, as we might revamp it
707 and use it again (Bug#8435).
708 * lisp.h (doprnt): Remove.
709 * Makefile.in (base_obj): Remove doprnt.o.
710 * deps.mk (doprnt.o): Remove.
711
712 error: Print 32- and 64-bit integers portably (Bug#8435).
713 Without this change, on typical 64-bit hosts error ("...%d...", N)
714 was used to print both 32- and 64-bit integers N, which relied on
715 undefined behavior.
716 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
717 New macro.
718 * lisp.h (error, verror): Mark as printf-like functions.
719 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
720 Report overflow in size calculations when allocating printf buffer.
721 Do not truncate output string at its first null byte.
722 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
723 Truncate the output at a character boundary, since vsnprintf does not
724 do that.
725 * charset.c (check_iso_charset_parameter): Convert internal
726 character to string before calling 'error', since %c now has the
727 printf meaning.
728 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
729 overflow when computing char to be passed to 'error'. Do not
730 pass Lisp_Object to 'error'; pass the integer instead.
731 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
732 formatted with plain %d.
733
734 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
735
736 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
737
738 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
739
740 * xterm.c (x_catch_errors): Remove duplicate declaration.
741
742 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
743
744 * xdisp.c, lisp.h (message_nolog): Remove; unused.
745
746 2011-04-10 Jim Meyering <meyering@redhat.com>
747
748 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
749 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
750 return ssize_t not "int", and use size_t as the buffer length.
751 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
752 * gnutls.h: Update declarations.
753 * process.c (read_process_output): Use ssize_t, to match.
754 (send_process): Likewise.
755
756 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
757
758 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
759
760 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
761
762 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
763 unsigned char, to match FcChar8 type definition.
764
765 * xterm.c (handle_one_xevent):
766 * xmenu.c (create_and_show_popup_menu):
767 * xselect.c (x_decline_selection_request)
768 (x_reply_selection_request): Avoid type-punned deref of X events.
769
770 2011-04-09 Eli Zaretskii <eliz@gnu.org>
771
772 Fix some uses of `int' instead of EMACS_INT.
773 * search.c (string_match_1, fast_string_match)
774 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
775 (scan_buffer, find_next_newline_no_quit)
776 (find_before_next_newline, search_command, Freplace_match)
777 (Fmatch_data): Make some `int' variables be EMACS_INT.
778
779 * xdisp.c (display_count_lines): 3rd argument and return value now
780 EMACS_INT. All callers changed.
781 (pint2hrstr): Last argument is now EMACS_INT.
782
783 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
784 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
785 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
786 (decode_coding_utf_16, decode_coding_emacs_mule)
787 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
788 (decode_coding_ccl, decode_coding_charset)
789 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
790 (decode_coding_iso_2022, decode_coding_emacs_mule)
791 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
792 <char_offset, last_offset>: Declare EMACS_INT.
793 (encode_coding_utf_8, encode_coding_utf_16)
794 (encode_coding_emacs_mule, encode_invocation_designation)
795 (encode_designation_at_bol, encode_coding_iso_2022)
796 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
797 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
798 Declare EMACS_INT.
799 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
800 (encode_invocation_designation): Last argument P_NCHARS is now
801 EMACS_INT.
802 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
803 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
804
805 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
806 All users changed.
807
808 * ccl.c (Fccl_execute_on_string): Declare some variables
809 EMACS_INT.
810
811 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
812
813 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
814
815 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
816
817 * process.c (Fformat_network_address): Doc fix.
818
819 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
820
821 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
822
823 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
824
825 * keyboard.c (read_char): Call Lisp function help-form-show,
826 instead of using internal_with_output_to_temp_buffer.
827 (Qhelp_form_show): New var.
828 (syms_of_keyboard): Use DEFSYM macro.
829
830 * print.c (internal_with_output_to_temp_buffer): Function deleted.
831
832 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
833
834 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
835
836 * process.c (Flist_processes): Removed to Lisp.
837 (list_processes_1): Deleted.
838
839 2011-04-06 Eli Zaretskii <eliz@gnu.org>
840
841 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
842
843 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
844
845 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
846
847 Fix more problems found by GCC 4.6.0's static checks.
848
849 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
850
851 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
852
853 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
854
855 * xdisp.c (vmessage): Mark as a printf-like function.
856
857 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
858
859 * sound.c (sound_warning): Don't crash if arg contains a printf format.
860
861 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
862 printf-like functions.
863 (tiff_load): Add casts to remove these marks before passing them
864 to system-supplied API.
865
866 * eval.c (Fsignal): Remove excess argument to 'fatal'.
867
868 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
869 This avoids several warnings with gcc -Wstrict-overflow.
870 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
871 directly, rather than having caller test rule sign. This avoids
872 some unnecessary tests.
873 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
874 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
875 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
876
877 * xfont.c (xfont_text_extents): Remove var that was set but not used.
878 (xfont_open): Avoid unnecessary tests.
879
880 * composite.c (composition_gstring_put_cache): Use unsigned integer.
881
882 * composite.h, composite.c (composition_gstring_put_cache):
883 Use EMACS_INT, not int, for length.
884
885 * composite.h (COMPOSITION_DECODE_REFS): New macro,
886 breaking out part of COMPOSITION_DECODE_RULE.
887 (COMPOSITION_DECODE_RULE): Use it.
888 * composite.c (get_composition_id): Remove unused local vars,
889 by using the new macro.
890
891 * textprop.c (set_text_properties_1): Change while to do-while,
892 since the condition is always true at first.
893
894 * intervals.c (graft_intervals_into_buffer): Mark var as used.
895 (interval_deletion_adjustment): Return unsigned value.
896 All uses changed.
897
898 * process.c (list_processes_1, create_pty, read_process_output):
899 (exec_sentinel): Remove vars that were set but not used.
900 (create_pty): Remove unnecessary "volatile"s.
901 (Fnetwork_interface_info): Avoid possibility of int overflow.
902 (read_process_output): Do adaptive read buffering even if carryover.
903 (read_process_output): Simplify nbytes computation if buffered.
904
905 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
906
907 * syntax.c (scan_words): Remove var that was set but not used.
908 (update_syntax_table): Use unsigned instead of int.
909
910 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
911 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
912 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
913
914 * print.c (print_error_message): Avoid int overflow.
915
916 * font.c (font_list_entities): Redo for clarity,
917 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
918
919 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
920 (font_score): Avoid potential overflow in diff calculation.
921
922 * fns.c (substring_both): Remove var that is set but not used.
923 (sxhash): Redo loop for clarity and to avoid wraparound warning.
924
925 * eval.c (funcall_lambda): Rename local to avoid shadowing.
926
927 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
928 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
929 can always succeed if overflow has undefined behavior.
930
931 * search.c (boyer_moore, wordify): Remove vars set but not used.
932 (wordify): Omit three unnecessary tests.
933
934 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
935 All callers changed. This avoids the need for an unused var.
936
937 * casefiddle.c (casify_region): Remove var that is set but not used.
938
939 * dired.c (file_name_completion): Remove var that is set but not used.
940
941 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
942
943 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
944 (Finsert_file_contents): Remove unnecessary code checking fd.
945
946 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
947 Check for integer overflow on size calculations.
948
949 * buffer.c (Fprevious_overlay_change): Remove var that is set
950 but not used.
951
952 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
953 Remove vars that are set but not used.
954 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
955 (timer_check_2): Mark vars as initialized.
956
957 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
958
959 * image.c (lookup_image): Remove var that is set but not used.
960 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
961
962 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
963 that are set but not used.
964
965 * xfns.c (make_invisible_cursor): Don't return garbage
966 if XCreateBitmapFromData fails (Bug#8410).
967
968 * xselect.c (x_get_local_selection, x_handle_property_notify):
969 Remove vars that are set but not used.
970
971 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
972 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
973
974 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
975 Remove var that is set but not used.
976 (scroll_bar_windows_size): Now size_t, not int.
977 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
978 Check for overflow.
979
980 * xfaces.c (realize_named_face): Remove vars that are set but not used.
981 (map_tty_color) [!defined MSDOS]: Likewise.
982
983 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
984
985 * coding.c: Remove vars that are set but not used.
986 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
987 All callers changed.
988 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
989 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
990 (decode_coding_charset): Remove vars that are set but not used.
991
992 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
993 that is set but not used.
994
995 * print.c (print_object): Remove var that is set but not used.
996
997 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
998 The gnulib version avoids calling malloc in the usual case,
999 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1000 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1001 * filelock.c (current_lock_owner): Likewise.
1002 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1003 * sysdep.c: Include allocator.h, careadlinkat.h.
1004 (emacs_no_realloc_allocator): New static constant.
1005 (emacs_readlink): New function.
1006 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1007 ../lib/careadlinkat.h.
1008
1009 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1010
1011 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1012 first non-nil return value).
1013
1014 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1015
1016 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1017 if not defined (Bug#8403).
1018
1019 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1020
1021 * xdisp.c (display_count_lines): Remove parameter `start',
1022 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1023 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1024 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1025 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1026 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1027 and thereabouts. All callers changed.
1028 (get_per_char_metric): Remove parameter `f', unused since
1029 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1030
1031 2011-04-02 Jim Meyering <meyering@redhat.com>
1032
1033 do not dereference NULL upon failed strdup
1034 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1035 (ns_get_family): Likewise.
1036
1037 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1038
1039 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1040
1041 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1042
1043 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1044 later (Bug#8403).
1045
1046 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1047
1048 Add lexical binding.
1049
1050 * window.c (Ftemp_output_buffer_show): New fun.
1051 (Fsave_window_excursion):
1052 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1053
1054 * lread.c (lisp_file_lexically_bound_p): New function.
1055 (Fload): Bind Qlexical_binding.
1056 (readevalloop): Remove `evalfun' arg.
1057 Bind Qinternal_interpreter_environment.
1058 (Feval_buffer): Bind Qlexical_binding.
1059 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1060 Mark as dynamic.
1061 (syms_of_lread): Declare `lexical-binding'.
1062
1063 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1064
1065 * keyboard.c (eval_dyn): New fun.
1066 (menu_item_eval_property): Use it.
1067
1068 * image.c (parse_image_spec): Use Ffunctionp.
1069
1070 * fns.c (concat, mapcar1): Accept byte-code-functions.
1071
1072 * eval.c (Fsetq): Handle lexical vars.
1073 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1074 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1075 (FletX, Flet): Obey lexical binding.
1076 (Fcommandp): Handle closures.
1077 (Feval): New `lexical' arg.
1078 (eval_sub): New function extracted from Feval. Use it almost
1079 everywhere where Feval was used. Look up vars in lexical env.
1080 Handle closures.
1081 (Ffunctionp): Move from subr.el.
1082 (Ffuncall): Handle closures.
1083 (apply_lambda): Remove `eval_flags'.
1084 (funcall_lambda): Handle closures and new byte-code-functions.
1085 (Fspecial_variable_p): New function.
1086 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1087 but without exporting it to Lisp.
1088
1089 * doc.c (Fdocumentation, store_function_docstring):
1090 * data.c (Finteractive_form): Handle closures.
1091
1092 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1093 interactive spec.
1094
1095 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1096 byte-codes.
1097 (exec_byte_code): New function extracted from Fbyte_code to handle new
1098 calling convention for byte-code-functions. Add new byte-codes.
1099
1100 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
1101
1102 * alloc.c (Fmake_symbol): Init new `declared_special' field.
1103
1104 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1105
1106 * xdisp.c (redisplay_internal): Fix prototype.
1107
1108 2011-03-31 Eli Zaretskii <eliz@gnu.org>
1109
1110 * xdisp.c (SCROLL_LIMIT): New macro.
1111 (try_scrolling): Use it when setting scroll_limit. Limit
1112 scrolling to 100 screen lines.
1113 (redisplay_window): Even when falling back on "recentering",
1114 position point in the window according to scroll-conservatively,
1115 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1116
1117 (try_scrolling): When point is above the window, allow searching
1118 as far as scroll_max, or one screenful, to compute vertical
1119 distance from PT to the scroll margin position. This prevents
1120 try_scrolling from unnecessarily failing when
1121 scroll-conservatively is set to a value slightly larger than the
1122 window height. Clean up the case of PT below the margin at bottom
1123 of window: scroll_max can no longer be INT_MAX. When aggressive
1124 scrolling is in use, don't let point enter the opposite scroll
1125 margin as result of the scroll.
1126 (syms_of_xdisp) <scroll-conservatively>: Document the
1127 threshold of 100 lines for never-recentering scrolling.
1128
1129 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1130
1131 * dispextern.h (move_it_by_lines):
1132 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1133 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1134 (message_log_check_duplicate): Remove parameters `prev_bol' and
1135 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1136 (redisplay_internal): Remove parameter `preserve_echo_area',
1137 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1138
1139 * indent.c (Fvertical_motion):
1140 * window.c (window_scroll_pixel_based, Frecenter):
1141 Don't pass `need_y_p' to `move_it_by_lines'.
1142
1143 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1144
1145 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1146 steal a few bits to be more compact.
1147 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1148 Remove unneeded casts.
1149
1150 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1151
1152 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1153
1154 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1155 binding" message (bug#7967).
1156
1157 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1158
1159 Fix more problems found by GCC 4.6.0's static checks.
1160
1161 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1162 Remove unused local var.
1163
1164 * editfns.c (Fmessage_box): Remove unused local var.
1165
1166 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1167 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1168 Omit unused local vars.
1169 * window.c (shrink_windows): Omit unused local var.
1170 * menu.c (digest_single_submenu): Omit unused local var.
1171 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1172 Omit unused local var.
1173
1174 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1175 Don't assume string length fits in int.
1176 (keyremap_step, read_key_sequence): Use size_t for sizes.
1177 (read_key_sequence): Don't check last_real_key_start redundantly.
1178
1179 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1180 instead of alloca (Bug#8344).
1181
1182 * eval.c (Fbacktrace): Don't assume nargs fits in int.
1183 (Fbacktrace_frame): Don't assume nframes fits in int.
1184
1185 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1186
1187 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1188 concerns.
1189
1190 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1191
1192 * cm.c (calccost): Turn while-do into do-while, for clarity.
1193
1194 * keyboard.c (syms_of_keyboard): Use the same style as later
1195 in this function when indexing through an array. This also
1196 works around GCC bug 48267.
1197
1198 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1199
1200 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1201
1202 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1203 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1204
1205 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1206 This avoids undefined behavior on integer overflow, and is a bit
1207 more convenient anyway since it is compared to a size_t variable.
1208
1209 Variadic C functions now count arguments with size_t, not int.
1210 This avoids an unnecessary limitation on 64-bit machines, which
1211 caused (substring ...) to crash on large vectors (Bug#8344).
1212 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1213 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
1214 All variadic functions and their callers changed accordingly.
1215 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1216 * data.c (arith_driver, float_arith_driver): Likewise.
1217 * editfns.c (general_insert_function): Likewise.
1218 * eval.c (struct backtrace.nargs, interactive_p)
1219 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1220 (funcall_lambda, mark_backtrace): Likewise.
1221 * fns.c (concat): Likewise.
1222 * frame.c (x_set_frame_parameters): Likewise.
1223 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1224 0 if not found, not -1. All callers changed.
1225
1226 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1227 (stack_copy_size): Now size_t, not int.
1228 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1229
1230 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1231
1232 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1233 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1234 All callers changed.
1235
1236 * lisp.h (multibyte_char_to_unibyte):
1237 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1238 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1239 * character.h (CHAR_TO_BYTE8):
1240 * cmds.c (internal_self_insert):
1241 * editfns.c (general_insert_function):
1242 * keymap.c (push_key_description):
1243 * search.c (Freplace_match):
1244 * xdisp.c (message_dolog, set_message_1): All callers changed.
1245
1246 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1247
1248 * keyboard.c (safe_run_hook_funcall): New function.
1249 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1250 don't set the hook to nil, but remove the offending function instead.
1251 (Qcommand_hook_internal): Remove, unused.
1252 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1253 Vcommand_hook_internal.
1254
1255 * eval.c (enum run_hooks_condition): Remove.
1256 (funcall_nil, funcall_not): New functions.
1257 (run_hook_with_args): Call each function through a `funcall' argument.
1258 Remove `cond' argument, now redundant.
1259 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1260 (Frun_hook_with_args_until_failure): Adjust accordingly.
1261 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1262
1263 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1264
1265 * dispextern.h (string_buffer_position): Remove declaration.
1266
1267 * print.c (strout): Remove parameter `multibyte', unused since
1268 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1269
1270 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1271 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1272 All callers changed.
1273
1274 * w32.c (_wsa_errlist): Use braces for struct initializers.
1275
1276 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1277 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1278 All callers changed.
1279 (string_buffer_position): Likewise. Also, make static (it's never
1280 used outside xdisp.c).
1281 (cursor_row_p): Remove parameter `w', unused since
1282 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1283 (decode_mode_spec): Remove parameter `precision', introduced during
1284 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1285 All callers changed.
1286
1287 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1288
1289 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1290
1291 2011-03-27 Anders Lindgren <andlind@gmail.com>
1292
1293 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1294 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1295 (ns_update_auto_hide_menu_bar): New functions.
1296 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1297 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1298 ns_constrain_all_frames.
1299 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1300 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1301
1302 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1303
1304 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1305
1306 2011-03-27 Glenn Morris <rgm@gnu.org>
1307
1308 * syssignal.h: Replace RETSIGTYPE with void.
1309 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1310 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1311 Replace SIGTYPE with void everywhere.
1312 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1313 * s/template.h (SIGTYPE): Remove commented out definition.
1314
1315 2011-03-26 Eli Zaretskii <eliz@gnu.org>
1316
1317 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1318 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1319
1320 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
1321
1322 * w32.c (read_unc_volume): Use parameter `henum', instead of
1323 global variable `wget_enum_handle'.
1324
1325 * keymap.c (describe_vector): Remove parameters `indices' and
1326 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1327 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1328
1329 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1330
1331 * keyboard.c (timer_check): Remove parameter `do_it_now',
1332 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1333 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1334 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1335
1336 * keyboard.c (read_char):
1337 * w32menu.c (w32_menu_display_help):
1338 * xmenu.c (show_help_event, menu_help_callback):
1339 Adjust calls to `show_help_echo'.
1340
1341 * gtkutil.c (xg_maybe_add_timer):
1342 * keyboard.c (readable_events):
1343 * process.c (wait_reading_process_output):
1344 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1345
1346 * insdel.c (adjust_markers_gap_motion):
1347 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1348 (gap_left, gap_right): Don't call it.
1349
1350 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
1351
1352 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1353 incurred during fontification.
1354
1355 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1356
1357 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1358 (DEFVAR_PER_BUFFER): Don't pass it.
1359
1360 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1361 (scrolling_window): Don't pass it.
1362
1363 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1364
1365 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1366
1367 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1368 and `suffix'.
1369 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1370 of variables specific to SELinux and computation of `encoded_absname'.
1371
1372 * image.c (XPutPixel): Remove unused variable `height'.
1373
1374 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1375
1376 * unexw32.c (get_section_info): Remove unused variable `section'.
1377
1378 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1379 (system_process_attributes): Remove unused variable `sess'.
1380 (sys_read): Remove unused variable `err'.
1381
1382 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1383 (w32_wnd_proc): Remove unused variable `isdead'.
1384 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1385 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1386 (x_create_tip_frame): Remove unused variable `tem'.
1387
1388 * w32inevt.c (w32_console_read_socket):
1389 Remove unused variable `no_events'.
1390
1391 * w32term.c (x_draw_composite_glyph_string_foreground):
1392 Remove unused variable `width'.
1393
1394 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
1395
1396 * w32term.c (x_set_glyph_string_clipping):
1397 Don't pass uninitialized region to CombineRgn.
1398
1399 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
1400
1401 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1402 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1403 (Fx_close_connection): Remove unused variable `i'.
1404
1405 * w32font.c (w32font_draw): Return number of glyphs.
1406 (w32font_open_internal): Remove unused variable `i'.
1407 (w32font_driver): Add missing initializer.
1408
1409 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1410 (fill_in_menu): Remove unused variable `items_added'.
1411
1412 * w32term.c (last_mouse_press_frame): Remove static global variable.
1413 (w32_clip_to_row): Remove unused variable `f'.
1414 (x_delete_terminal): Remove unused variable `i'.
1415
1416 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1417 (NOTHING): Remove unused static global variable.
1418 (uniscribe_check_otf): Remove unused variable `table'.
1419 (uniscribe_font_driver): Add missing initializers.
1420
1421 2011-03-23 Julien Danjou <julien@danjou.info>
1422
1423 * term.c (Fsuspend_tty, Fresume_tty):
1424 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1425 * window.c (temp_output_buffer_show):
1426 * insdel.c (signal_before_change):
1427 * frame.c (Fhandle_switch_frame):
1428 * fileio.c (Fdo_auto_save):
1429 * emacs.c (Fkill_emacs):
1430 * editfns.c (save_excursion_restore):
1431 * cmds.c (internal_self_insert):
1432 * callint.c (Fcall_interactively):
1433 * buffer.c (Fkill_all_local_variables):
1434 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1435 Use Frun_hooks.
1436 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
1437 unconditionnaly since it does the check itself.
1438
1439 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
1440
1441 Fix more problems found by GCC 4.5.2's static checks.
1442
1443 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1444 the first time through the loop, since we know p0 < p1 then.
1445 This also avoids a gcc -Wstrict-overflow warning.
1446
1447 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1448 leading to a memory leak, possible in functions like
1449 load_charset_map_from_file that can allocate an unbounded number
1450 of objects (Bug#8318).
1451
1452 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1453 that could (at least in theory) be that large.
1454
1455 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1456 This is less likely to overflow, and avoids undefined behavior if
1457 overflow does occur. All callers changed. Use strtoul to scan
1458 for the unsigned long integer.
1459 (pint2hrstr): Simplify and tune code slightly.
1460 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
1461
1462 * scroll.c (do_scrolling): Work around GCC bug 48228.
1463 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1464
1465 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1466 This also avoids a warning with gcc -Wstrict-overflow.
1467 (validate_x_resource_name): Simplify count usage.
1468 This also avoids a warning with gcc -Wstrict-overflow.
1469
1470 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1471 fail (Bug#8306).
1472
1473 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
1474
1475 * process.c (Fmake_network_process): Use socklen_t, not int,
1476 where POSIX says socklen_t is required in portable programs.
1477 This fixes a porting bug on hosts like 64-bit HP-UX, where
1478 socklen_t is wider than int (Bug#8277).
1479 (Fmake_network_process, server_accept_connection):
1480 (wait_reading_process_output, read_process_output):
1481 Likewise.
1482
1483 * process.c: Rename or move locals to avoid shadowing.
1484 (list_processes_1, Fmake_network_process):
1485 (read_process_output_error_handler, exec_sentinel_error_handler):
1486 Rename or move locals.
1487 (Fmake_network_process): Define label "retry_connect" only if needed.
1488 (Fnetwork_interface_info): Fix pointer signedness.
1489 (process_send_signal): Add cast to avoid pointer signedness problem.
1490 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
1491 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
1492
1493 Make tparam.h and terminfo.c consistent.
1494 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1495 Include tparam.h instead, since it declares them.
1496 * cm.h (PC): Remove extern decl; tparam.h now does this.
1497 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1498 * terminfo.c: Include tparam.h, to check interfaces.
1499 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1500 (tparam): Adjust signature to match interface in tparam.h;
1501 this removes some undefined behavior. Check that outstring and len
1502 are zero, which they always are with Emacs.
1503 * tparam.h (PC, BC, UP): New extern decls.
1504
1505 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
1506 (xftfont_open): Rename locals to avoid shadowing.
1507
1508 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
1509 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1510 (OTF_TAG_SYM): Omit macro if not needed.
1511 (ftfont_list): Remove unused local.
1512 (get_adstyle_property, ftfont_pattern_entity):
1513 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1514 Rename locals to avoid shadowing.
1515
1516 * xfont.c (xfont_list_family): Mark var as initialized.
1517
1518 * xml.c (make_dom): Now static.
1519
1520 * composite.c (composition_compute_stop_pos): Rename local to
1521 avoid shadowing.
1522 (composition_reseat_it): Remove unused locals.
1523 (find_automatic_composition, composition_adjust_point): Likewise.
1524 (composition_update_it): Mark var as initialized.
1525 (find_automatic_composition): Mark vars as initialized,
1526 with a FIXME (Bug#8290).
1527
1528 character.h: Rename locals to avoid shadowing.
1529 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1530 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1531 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1532 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1533 to avoid shadowing.
1534
1535 * textprop.c (property_change_between_p): Remove; unused.
1536
1537 * intervals.c (interval_start_pos): Now static.
1538
1539 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1540
1541 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1542 Rename locals to avoid shadowing.
1543
1544 * sound.c (wav_play, au_play, Fplay_sound_internal):
1545 Fix pointer signedness.
1546 (alsa_choose_format): Remove unused local var.
1547 (wav_play): Initialize a variable to 0, to prevent undefined
1548 behavior (Bug#8278).
1549
1550 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1551
1552 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1553
1554 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1555 clobbering (Bug#8298).
1556 * sysdep.c (sys_subshell): Likewise.
1557 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
1558
1559 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1560 This should get cleaned up, so that child_setup has the
1561 same signature on all platforms.
1562
1563 * callproc.c (call_process_cleanup): Now static.
1564 (relocate_fd): Rename locals to avoid shadowing.
1565
1566 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
1567
1568 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1569 not to be necessary, and produces flickering.
1570
1571 2011-03-20 Glenn Morris <rgm@gnu.org>
1572
1573 * config.in: Remove file.
1574
1575 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
1576
1577 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1578 are now in src/globals.h.
1579 (syms_of_minibuf): Remove spurious & from previous change.
1580
1581 2011-03-20 Leo <sdl.web@gmail.com>
1582
1583 * minibuf.c (completing-read-function): New variable.
1584 (completing-read-default): Rename from completing-read.
1585 (completing-read): Call completing-read-function.
1586
1587 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
1588
1589 * xfaces.c (Fx_load_color_file):
1590 Read color file from absolute filename (bug#8250).
1591
1592 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
1593
1594 * makefile.w32-in: Update dependencies.
1595
1596 2011-03-17 Eli Zaretskii <eliz@gnu.org>
1597
1598 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1599
1600 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1601
1602 Fix more problems found by GCC 4.5.2's static checks.
1603
1604 * process.c (make_serial_process_unwind, send_process_trap):
1605 (sigchld_handler): Now static.
1606
1607 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1608 That way, the code declares only the vars that it needs.
1609 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1610 * s/cygwin.h (PTY_ITERATION): Likewise.
1611 * s/darwin.h (PTY_ITERATION): Likewise.
1612 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1613
1614 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1615 * process.c (allocate_pty): Don't declare stb unless it's needed.
1616
1617 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
1618 (CONSTANTLIM): Remove; unused.
1619 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1620 Define only if needed.
1621
1622 * unexelf.c (unexec): Name an expression,
1623 to avoid gcc -Wbad-function-cast warning.
1624 Use a different way to cause a compilation error if anyone uses
1625 n rather than nn, a way that does not involve shadowing.
1626 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
1627
1628 * deps.mk (unexalpha.o): Remove; unused.
1629
1630 New file unexec.h, the (simple) interface for unexec (Bug#8267).
1631 * unexec.h: New file.
1632 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1633 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1634 Depend on unexec.h.
1635 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1636 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1637 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
1638 Change as necessary to match prototype in unexec.h.
1639
1640 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1641 shadowing.
1642 (back_comment, skip_chars): Mark vars as initialized.
1643
1644 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1645 Rename locals to avoid shadowing.
1646
1647 * lread.c (read1): Rewrite so as not to use empty "else".
1648 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
1649
1650 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1651
1652 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1653 warning when compiling print.c.
1654
1655 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1656 instead of using an uninitialized var.
1657 (font_sort_entities): Mark var as initialized.
1658
1659 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1660
1661 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1662 pointers to constants.
1663 (font_parse_fcname): Remove unused vars.
1664 (font_delete_unmatched): Now static.
1665 (font_get_spec): Remove; unused.
1666 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1667 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1668 Rename or move locals to avoid shadowing.
1669
1670 * fns.c (require_nesting_list, require_unwind): Now static.
1671 (Ffillarray): Rename locals to avoid shadowing.
1672
1673 * floatfns.c (domain_error2): Define only if needed.
1674 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1675
1676 * alloc.c (mark_backtrace): Move decl from here ...
1677 * lisp.h: ... to here, so that it can be checked.
1678
1679 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
1680 (Fdefvar): Rewrite so as not to use empty "else".
1681 (lisp_indirect_variable): Name an expression,
1682 to avoid gcc -Wbad-function-cast warning.
1683 (Fdefvar): Rename locals to avoid shadowing.
1684
1685 * callint.c (quotify_arg, quotify_args): Now static.
1686 (Fcall_interactively): Rename locals to avoid shadowing.
1687 Use const pointer when appropriate.
1688
1689 * lisp.h (get_system_name, get_operating_system_release):
1690 Move decls here, to check interfaces.
1691 * process.c (get_operating_system_release): Move decl to lisp.h.
1692 * xrdb.c (get_system_name): Likewise.
1693 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1694 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1695 some of which prompt warnings from gcc -Wbad-function-cast.
1696 (Fformat_time_string, Fencode_time, Finsert_char):
1697 (Ftranslate_region_internal, Fformat):
1698 Rename or remove local vars to avoid shadowing.
1699 (Ftranslate_region_internal): Mark var as initialized.
1700
1701 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1702 avoid shadowing.
1703
1704 * lisp.h (eassert): Check that the argument compiles, even if
1705 ENABLE_CHECKING is not defined.
1706
1707 * data.c (Findirect_variable): Name an expression, to avoid
1708 gcc -Wbad-function-cast warning.
1709 (default_value, arithcompare, arith_driver, arith_error): Now static.
1710 (store_symval_forwarding): Rename local to avoid shadowing.
1711 (Fmake_variable_buffer_local, Fmake_local_variable):
1712 Mark variables as initialized.
1713 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
1714
1715 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
1716 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1717 Rename locals to avoid shadowing.
1718 (mark_stack): Move local variables into the #ifdef region where
1719 they're used.
1720 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1721 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1722 needed otherwise.
1723 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1724 (GC_STRING_CHARS): Remove; not used.
1725 (Fmemory_limit): Cast sbrk's returned value to char *.
1726
1727 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1728 avoids undefined behavior in theory.
1729
1730 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1731
1732 Use functions, not macros, for up- and down-casing (Bug#8254).
1733 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1734 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1735 to use the following functions instead of these macros.
1736 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1737 EMACS_INT, since callers assume the returned value fits in int.
1738 (upcase1): Likewise, for UPCASE_TABLE.
1739 (uppercasep, lowercasep, upcase): New static inline functions.
1740 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
1741 the race-condition problem in the old DOWNCASE.
1742
1743 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1744 Rename locals to avoid shadowing.
1745 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
1746 (regex_compile, re_search_2, re_match_2_internal):
1747 Remove unused local vars.
1748 (FREE_VAR): Rewrite so as not to use empty "else",
1749 which gcc can warn about.
1750 (regex_compile, re_match_2_internal): Mark locals as initialized.
1751 (RETALLOC_IF): Define only if needed.
1752 (WORDCHAR_P): Likewise. This one is never needed, but is used
1753 only in a comment talking about a compiler bug, so put inside
1754 the #if 0 of that comment.
1755 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1756 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1757 Remove; unused.
1758
1759 * search.c (boyer_moore): Rename locals to avoid shadowing.
1760 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1761 (PREV_CHAR_BOUNDARY): Likewise.
1762
1763 * search.c (simple_search): Remove unused var.
1764
1765 * dired.c (compile_pattern): Move decl from here ...
1766 * lisp.h: ... to here, so that it can be checked.
1767 (struct re_registers): New forward decl.
1768
1769 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1770
1771 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1772 All uses changed.
1773 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1774 Rename locals to avoid shadowing.
1775 (Fvertical_motion): Mark locals as initialized.
1776
1777 * casefiddle.c (casify_object, casify_region): Now static.
1778 (casify_region): Mark local as initialized.
1779
1780 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1781
1782 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1783 New macros, so that the caller can use some names other than
1784 gcpro1, gcpro2, etc.
1785 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1786 of the new macros.
1787 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1788 argument, for consistency with GCPRO2_VAR, etc: it is now the
1789 prefix of the variable, not the variable itself. All uses
1790 changed.
1791 * dired.c (directory_files_internal, file_name_completion):
1792 Rename locals to avoid shadowing.
1793
1794 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1795 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1796 dired.c's scmp function, had undefined behavior.
1797 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1798 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1799 * buffer.h: ... to here, because these macros use current_buffer,
1800 and the new implementation with inline functions needs to have
1801 current_buffer in scope now, rather than later when the macros
1802 are used.
1803 (downcase, upcase1): New static inline functions.
1804 (DOWNCASE, UPCASE1): Reimplement using these functions.
1805 This avoids undefined behavior in expressions like
1806 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1807 from race conditions in accessing the global variables
1808 case_temp1 and case_temp2.
1809 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1810 * lisp.h (case_temp1, case_temp2): Remove their decls.
1811 * character.h (ASCII_CHAR_P): Move from here ...
1812 * lisp.h: ... to here, so that the inline functions mentioned
1813 above can use them.
1814
1815 * dired.c (directory_files_internal_unwind): Now static.
1816
1817 * fileio.c (file_name_as_directory, directory_file_name):
1818 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1819 Now static.
1820 (file_name_as_directory): Use const pointers when appropriate.
1821 (Fexpand_file_name): Likewise. In particular, newdir might
1822 point at constant storage, so make it a const pointer.
1823 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
1824 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1825 signedness issues.
1826 (Fset_file_times, Finsert_file_contents, auto_save_error):
1827 Rename locals to avoid shadowing.
1828
1829 * minibuf.c (choose_minibuf_frame_1): Now static.
1830 (Ftry_completion, Fall_completions): Rename or remove locals
1831 to avoid shadowing.
1832
1833 * marker.c (bytepos_to_charpos): Remove; unused.
1834
1835 * lisp.h (verify_bytepos, count_markers): New decls,
1836 so that gcc does not warn that these functions aren't declared.
1837
1838 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1839 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
1840 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
1841 (copy_text): Remove unused local var.
1842
1843 * filelock.c (within_one_second): Now static.
1844 (lock_file_1): Rename local to avoid shadowing.
1845
1846 * buffer.c (fix_overlays_before): Mark locals as initialized.
1847 (fix_start_end_in_overlays): Likewise. This function should be
1848 simplified by using pointers-to-pointers, but that's a different
1849 matter.
1850 (switch_to_buffer_1): Now static.
1851 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1852 (report_overlay_modification): Rename locals to avoid shadowing.
1853
1854 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
1855 Fix pointer signedness issue.
1856 (sys_subshell): Mark local as volatile if checking for lint,
1857 to suppress a gcc -Wclobbered warning that does not seem to be right.
1858 (MAXPATHLEN): Define only if needed.
1859
1860 * process.c (serial_open, serial_configure): Move decls from here ...
1861 * systty.h: ... to here, so that they can be checked.
1862
1863 * fns.c (get_random, seed_random): Move extern decls from here ...
1864 * lisp.h: ... to here, so that they can be checked.
1865
1866 * sysdep.c (reset_io): Now static.
1867 (wait_for_termination_signal): Remove; unused.
1868
1869 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1870 (copy_keymap_item, append_key, push_text_char_description):
1871 Now static.
1872 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
1873 (DENSE_TABLE_SIZE): Remove; unused.
1874 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1875 (describe_map_tree):
1876 Rename locals to avoid shadowing.
1877
1878 * keyboard.c: Declare functions static if they are not used elsewhere.
1879 (echo_char, echo_dash, cmd_error, top_level_2):
1880 (poll_for_input, handle_async_input): Now static.
1881 (read_char, kbd_buffer_get_event, make_lispy_position):
1882 (make_lispy_event, make_lispy_movement, apply_modifiers):
1883 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1884 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1885 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
1886 (read_key_sequence, read_char): Mark locals as initialized.
1887 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
1888
1889 * keyboard.h (make_ctrl_char): New decl.
1890 (mark_kboards): Move decl here ...
1891 * alloc.c (mark_kboards): ... from here.
1892
1893 * lisp.h (force_auto_save_soon): New decl.
1894
1895 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
1896 (DEFINE_DUMMY_FUNCTION): New macro.
1897 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1898 Use it.
1899 (main): Add casts to avoid warnings
1900 if GCC considers string literals to be constants.
1901
1902 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1903
1904 * dbusbind.c: Pointer signedness fixes.
1905 (xd_signature, xd_append_arg, xd_initialize):
1906 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1907 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1908 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1909 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1910
1911 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1912 if GCC considers string literals to be constants.
1913 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
1914
1915 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1916
1917 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1918 (print_preprocess, print_object): New macro to fix last change.
1919
1920 * print.c (print_preprocess): Don't forget font objects.
1921
1922 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
1923
1924 * emacs.c (USAGE3): Doc fixes.
1925
1926 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1927
1928 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1929 structure.
1930
1931 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
1932
1933 * lisp.h (VWindow_system, Qfile_name_history):
1934 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1935 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1936 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1937
1938 * w32select.c: Don't #include "keyboard.h".
1939 (run_protected): Add extern declaration for waiting_for_input.
1940
1941 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1942 * w32console.c (detect_input_pending, read_input_pending)
1943 (encode_terminal_code):
1944 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1945 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1946 (w32_system_caret_y, Qfile_name_history):
1947 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1948 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1949 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1950 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1951 * w32proc.c (Qlocal, report_file_error):
1952 * w32term.c (Vwindow_system, updating_frame):
1953 * w32uniscribe.c (initialized, uniscribe_font_driver):
1954 Remove unneeded extern declarations.
1955
1956 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
1957
1958 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
1959
1960 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
1961
1962 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1963 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1964 These macros can no longer be used for assignment.
1965
1966 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1967 Assign struct members directly, instead of using BUF_BEGV etc.
1968 (record_buffer_markers, fetch_buffer_markers): New functions for
1969 recording and fetching special buffer markers.
1970 (set_buffer_internal_1, set_buffer_temp): Use them.
1971
1972 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1973
1974 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1975
1976 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1977 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1978
1979 * xdisp.c (hscroll_window_tree):
1980 (reconsider_clip_changes): Use PT instead of BUF_PT.
1981
1982 2011-03-13 Eli Zaretskii <eliz@gnu.org>
1983
1984 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1985 $(EMACS_ROOT)/lib/intprops.h.
1986
1987 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1988
1989 Fix more problems found by GCC 4.5.2's static checks.
1990
1991 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1992 to unsigned char * to avoid compiler diagnostic.
1993 (xg_free_frame_widgets): Make it clear that a local variable is
1994 needed only if USE_GTK_TOOLTIP.
1995 (gdk_window_get_screen): Make it clear that this macro is needed
1996 only if USE_GTK_TOOLTIP.
1997 (int_gtk_range_get_value): New function, which avoids a diagnostic
1998 from gcc -Wbad-function-cast.
1999 (xg_set_toolkit_scroll_bar_thumb): Use it.
2000 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2001 diagnostic from gcc -Wbad-function-cast.
2002 (get_utf8_string, xg_get_file_with_chooser):
2003 Rename locals to avoid shadowing.
2004 (create_dialog): Move locals to avoid shadowing.
2005
2006 * xgselect.c (xg_select): Remove unused var.
2007
2008 * image.c (four_corners_best): Mark locals as initialized.
2009 (gif_load): Initialize transparent_p to zero (Bug#8238).
2010 Mark another local as initialized.
2011 (my_png_error, my_error_exit): Mark with NO_RETURN.
2012
2013 * image.c (clear_image_cache): Now static.
2014 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
2015 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
2016 (x_edge_detection): Remove unnecessary cast that
2017 gcc -Wbad-function-cast diagnoses.
2018 (gif_load): Fix pointer signedness.
2019 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2020 (jpeg_load, gif_load): Rename locals to avoid shadowing.
2021
2022 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
2023
2024 Improve quality of tests for time stamp overflow.
2025 For example, without this patch (encode-time 0 0 0 1 1
2026 1152921504606846976) returns the obviously-bogus value (-948597
2027 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2028 reports time overflow. See
2029 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
2030 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2031 * editfns.c: Include limits.h and intprops.h.
2032 (TIME_T_MIN, TIME_T_MAX): New macros.
2033 (time_overflow): Move earlier, to before first use.
2034 (hi_time, lo_time): New functions, for an accurate test for
2035 out-of-range times.
2036 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2037 (Fget_internal_run_time): Don't assume time_t fits in int.
2038 (make_time): Use list2 instead of Fcons twice.
2039 (Fdecode_time): More accurate test for out-of-range times.
2040 (check_tm_member): New function.
2041 (Fencode_time): Use it, to test for out-of-range times.
2042 (lisp_time_argument): Don't rely on undefined left-shift and
2043 right-shift behavior when checking for time stamp overflow.
2044
2045 * editfns.c (time_overflow): New function, refactoring common code.
2046 (Fformat_time_string, Fdecode_time, Fencode_time):
2047 (Fcurrent_time_string): Use it.
2048
2049 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2050 * dired.c (make_time): Move to ...
2051 * editfns.c (make_time): ... here.
2052 * systime.h: Note the move.
2053
2054 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2055
2056 * fringe.c (update_window_fringes): Remove unused variables.
2057
2058 * unexmacosx.c (copy_data_segment): Also copy __got section.
2059 (Bug#8223)
2060
2061 2011-03-12 Eli Zaretskii <eliz@gnu.org>
2062
2063 * termcap.c [MSDOS]: Include "msdos.h".
2064 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2065 Constify `char *' arguments and their references according to
2066 prototypes in tparam.h.
2067
2068 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
2069
2070 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2071 Adapt all references accordingly.
2072
2073 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2074
2075 2011-03-11 Tom Tromey <tromey@redhat.com>
2076
2077 * buffer.c (syms_of_buffer): Remove obsolete comment.
2078
2079 2011-03-11 Eli Zaretskii <eliz@gnu.org>
2080
2081 * termhooks.h (encode_terminal_code): Declare prototype.
2082
2083 * msdos.c (encode_terminal_code): Don't declare prototype.
2084
2085 * term.c (encode_terminal_code): Now external again, used by
2086 w32console.c and msdos.c.
2087
2088 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2089 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
2090
2091 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
2092
2093 Fix some minor problems found by GCC 4.5.2's static checks.
2094
2095 * fringe.c (update_window_fringes): Mark locals as initialized
2096 (Bug#8227).
2097 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
2098
2099 * alloc.c (mark_fringe_data): Move decl from here ...
2100 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2101 to check its interface.
2102 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2103
2104 * fontset.c (free_realized_fontset): Now static.
2105 (Fset_fontset_font): Rename local to avoid shadowing.
2106 (fontset_font): Mark local as initialized.
2107 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
2108
2109 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2110
2111 * xselect.c (x_disown_buffer_selections): Remove; not used.
2112 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
2113 (x_own_selection, Fx_disown_selection_internal): Rename locals
2114 to avoid shadowing.
2115 (x_handle_dnd_message): Remove local to avoid shadowing.
2116
2117 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2118 so that the caller can use some name other than gcpro1.
2119 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
2120 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2121 (Fx_backspace_delete_keys_p):
2122 Use them to avoid shadowing, and rename vars to avoid shadowing.
2123 (x_decode_color, x_set_name, x_window): Now static.
2124 (Fx_create_frame): Add braces to silence GCC warning.
2125 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
2126 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2127 Remove unused locals.
2128 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2129 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2130 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2131 macros.
2132
2133 * xterm.h (x_mouse_leave): New decl.
2134
2135 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2136 Remove unused functions.
2137 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2138 (x_calc_absolute_position): Now static.
2139 (XTread_socket): Don't define label "out" unless it's used.
2140 Don't declare local "event" unless it's used.
2141 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2142 unless they are used.
2143 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2144 (x_fatal_error_signal): Remove; not used.
2145 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2146 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2147 (x_error_catcher, x_connection_closed, x_error_handler):
2148 (x_error_quitter, xembed_send_message, x_iconify_frame):
2149 (my_log_handler): Rename locals to avoid shadowing.
2150 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2151 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
2152
2153 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2154 Rename or move locals to avoid shadowing.
2155 (tty_defined_color, merge_face_heights): Now static.
2156 (free_realized_faces_for_fontset): Remove; not used.
2157 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2158 does not deduce is never used uninitialized.
2159 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2160 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
2161
2162 * terminal.c (store_terminal_param): Now static.
2163
2164 * xmenu.c (menu_highlight_callback): Now static.
2165 (set_frame_menubar): Remove unused local.
2166 (xmenu_show): Rename parameter to avoid shadowing.
2167 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2168 since they might point to immutable storage.
2169 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2170 since it's unused otherwise.
2171
2172 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
2173 Add a FIXME, since the code still doesn't look right. (Bug#8215)
2174 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2175 avoids a gcc -Wuninitialized diagnostic.
2176 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
2177 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2178 does not deduce are never used uninitialized.
2179
2180 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2181
2182 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
2183 * window.c (window_loop, size_window):
2184 (run_window_configuration_change_hook, enlarge_window): Likewise.
2185
2186 * window.c (display_buffer): Now static.
2187 (size_window): Mark variables that gcc -Wuninitialized
2188 does not deduce are never used uninitialized.
2189 * window.h (check_all_windows): New decl, to forestall
2190 gcc -Wmissing-prototypes diagnostic.
2191 * dispextern.h (bidi_dump_cached_states): Likewise.
2192
2193 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2194 shadowing.
2195 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
2196 Include <limits.h>.
2197 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2198 and to avoid gcc -Wuninitialized warning.
2199 (load_charset_map): Mark variables that gcc -Wuninitialized
2200 does not deduce are never used uninitialized.
2201 (load_charset): Abort instead of using uninitialized var (Bug#8229).
2202
2203 * coding.c (coding_set_source, coding_set_destination):
2204 Use "else { /* comment */ }" rather than "else /* comment */;"
2205 for clarity, and to avoid gcc -Wempty-body warning.
2206 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2207 a block, when the outer 'i' will do.
2208 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2209 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2210 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2211 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2212 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2213 Rename locals to avoid shadowing.
2214 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
2215 * coding.c (emacs_mule_char, encode_invocation_designation):
2216 Now static, since they're not used elsewhere.
2217 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
2218 (decode_coding_object, encode_coding_object, detect_coding_system):
2219 (decode_coding_emacs_mule): Mark variables that gcc
2220 -Wuninitialized does not deduce are never used uninitialized.
2221 (detect_coding_iso_2022): Initialize a local variable that might
2222 be used uninitialized. Leave a FIXME because it's not clear that
2223 this initialization is needed. (Bug#8211)
2224 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2225 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2226 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2227 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2228 Remove unused macros.
2229
2230 * category.c (hash_get_category_set): Remove unused local var.
2231 (copy_category_table): Now static, since it's not used elsewhere.
2232 * character.c (string_count_byte8): Likewise.
2233
2234 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2235 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2236
2237 * chartab.c (copy_sub_char_table): Now static, since it's not used
2238 elsewhere.
2239 (sub_char_table_ref_and_range, char_table_ref_and_range):
2240 Rename locals to avoid shadowing.
2241 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
2242
2243 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
2244 (BIDI_BOB): Remove unused macro.
2245
2246 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2247 deduce are never used uninitialized.
2248 * term.c (encode_terminal_code): Likewise.
2249
2250 * term.c (encode_terminal_code): Now static. Remove unused local.
2251
2252 * tparam.h: New file.
2253 * term.c, tparam.h: Include it.
2254 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2255 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2256 Move these decls to tparam.h, and make them agree with what
2257 is actually in tparam.c. The previous trick of using incompatible
2258 decls in different modules does not conform to the C standard.
2259 All callers of tparam changed to use tparam's actual API.
2260 * tparam.c (tparam1, tparam, tgoto):
2261 Use const pointers where appropriate.
2262
2263 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2264 * cm.h (struct cm): Likewise.
2265 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2266 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2267 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2268 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2269 (turn_on_face, init_tty): Likewise.
2270 * termchar.h (struct tty_display_info): Likewise.
2271
2272 * term.c (term_mouse_position): Rename local to avoid shadowing.
2273
2274 * alloc.c (mark_ttys): Move decl from here ...
2275 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2276
2277 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2278
2279 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2280
2281 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
2282
2283 * search.c (compile_pattern_1): Remove argument regp, unused since
2284 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2285 (compile_pattern): Don't pass it.
2286
2287 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2288
2289 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2290 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2291 for ! HAVE_GTK3.
2292 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2293
2294 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2295
2296 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2297 gdk_window_get_screen, gdk_window_get_geometry,
2298 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2299 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2300 (xg_get_pixbuf_from_pixmap): New function.
2301 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2302 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2303 Call xg_get_pixbuf_from_pixmap instead of
2304 gdk_pixbuf_get_from_drawable.
2305 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2306 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2307 (xg_check_special_colors): Use GtkStyleContext and its functions
2308 for HAVE_GTK3.
2309 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2310 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2311 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
2312 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2313 Call gtk_widget_get_preferred_size.
2314 (xg_frame_resized): gdk_window_get_geometry only takes 5
2315 parameters.
2316 (xg_win_to_widget, xg_event_is_for_menubar):
2317 Call gdk_x11_window_lookup_for_display.
2318 (xg_set_widget_bg): New function.
2319 (delete_cb): New function.
2320 (xg_create_frame_widgets): connect delete-event to delete_cb.
2321 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2322 (xg_set_background_color): Call xg_set_widget_bg.
2323 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2324 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2325 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2326 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2327 if ! HAVE_GTK3.
2328 (update_frame_tool_bar): Call gtk_widget_hide.
2329 (xg_initialize): Use GDK_KEY_g.
2330
2331 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2332 if ! HAVE_GTK3
2333 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2334
2335 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2336 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2337 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2338
2339 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
2340
2341 * w32xfns.c (select_palette): Check success of RealizePalette against
2342 GDI_ERROR, not zero.
2343
2344 See ChangeLog.11 for earlier changes.
2345
2346 ;; Local Variables:
2347 ;; coding: utf-8
2348 ;; End:
2349
2350 Copyright (C) 2011 Free Software Foundation, Inc.
2351
2352 This file is part of GNU Emacs.
2353
2354 GNU Emacs is free software: you can redistribute it and/or modify
2355 it under the terms of the GNU General Public License as published by
2356 the Free Software Foundation, either version 3 of the License, or
2357 (at your option) any later version.
2358
2359 GNU Emacs is distributed in the hope that it will be useful,
2360 but WITHOUT ANY WARRANTY; without even the implied warranty of
2361 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2362 GNU General Public License for more details.
2363
2364 You should have received a copy of the GNU General Public License
2365 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.