* lread.c (read1, init_obarray): Don't update size until alloc done.
[bpt/emacs.git] / src / ChangeLog
1 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
2
3 * lread.c (read1, init_obarray): Don't update size until alloc done.
4
5 * keymap.c: Integer overflow fixes.
6 (cmm_size, current_minor_maps): Use ptrdiff_t, not int, to count maps.
7 (current_minor_maps): Check for size calculation overflow.
8 * keymap.h: Change prototypes to match the above.
9
10 * keyboard.c: Integer and memory overflow fixes.
11 (read_char, menu_bar_items, tool_bar_items, read_char_x_menu_prompt)
12 (read_char_minibuf_menu_width, read_char_minibuf_menu_prompt)
13 (follow_key, read_key_sequence): Use ptrdiff_t, not int, to count maps.
14 (read_char_minibuf_menu_prompt): Check for overflow in size
15 calculations. Don't update size until allocation succeeds. Redo
16 calculations to avoid overflow.
17 * keyboard.h: Change prototypes to match the above.
18
19 * image.c: Integer and memory overflow fixes.
20 (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these are duplicate
21 now that they've been promoted to lisp.h.
22 (x_allocate_bitmap_record, x_alloc_image_color)
23 (make_image_cache, cache_image, xpm_load):
24 Don't update size until alloc is done.
25 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
26 (x_detect_edges):
27 Check for size calculation overflow.
28 (ct_colors_allocated_max): New constant.
29 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
30 overflow.
31
32 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
33
34 * gtkutil.c: Integer overflow fixes.
35 (get_utf8_string, xg_store_widget_in_map):
36 Check for size-calculation overflow.
37 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
38 do, as we prefer signed integers.
39 (id_to_widget.max_size, id_to_widget.used)
40 (xg_store_widget_in_map, xg_remove_widget_from_map)
41 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
42 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
43 Use and return ptrdiff_t, not int.
44 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
45 * gtkutil.h: Change prototypes to match the above.
46
47 * ftfont.c: Check for size overflow.
48 (ftfont_get_open_type_spec, setup_otf_gstring, ftfont_shape_by_flt):
49 Check for integer overflow in size calculations.
50
51 * fringe.c (Fdefine_fringe_bitmap): Don't update size until alloc works.
52
53 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
54 This is for the members text_lines, text_cols, total_lines, total_cols,
55 where the system imposes an 'int' limit.
56
57 * frame.c: Integer overflow fixes.
58 (set_menu_bar_lines, x_set_frame_parameters, x_set_scroll_bar_width)
59 (x_figure_window_size): Check for integer overflow.
60 (x_set_alpha): Do not assume XINT fits in int.
61
62 * eval.c: Integer and memory overflow fixes.
63 (init_eval_once, grow_specpdl): Don't update size until alloc succeeds.
64 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
65
66 * emacs.c (main, sort_args): Check for size-calculation overflow.
67
68 * editfns.c: Integer and memory overflow fixes.
69 (set_time_zone_rule): Don't assume environment length fits in int.
70 (message_length): Now ptrdiff_t, not int.
71 (Fmessage_box): Don't update size until allocation succeeds.
72 Don't assume message length fits in int.
73 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
74
75 * doc.c: Integer and memory overflow fixes.
76 (get_doc_string_buffer_size): Now ptrdiff_t, not int.
77 (get_doc_string): Check for size calculation overflow.
78 Don't update size until allocation succeeds.
79 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
80 EMACS_INT, where ptrdiff_t will do.
81 (Fsubstitute_command_keys): Check for string overflow.
82
83 Integer and memory overflow fixes for display code.
84 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
85 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool, scrolling_window):
86 Check for overflow in size calculations.
87 (line_draw_cost, realloc_glyph_pool, add_row_entry):
88 Don't assume glyph table len fits in int.
89 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
90 (row_table_size): Now ptrdiff_t, not int.
91 (scrolling_window): Avoid overflow in size calculations.
92 Don't update size until allocation succeeds.
93 * fns.c (concat): Check for overflow in size calculations.
94 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
95 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
96 (NEXT_ALMOST_PRIME_LIMIT): New constant.
97
98 * composite.c: Integer overflow fixes.
99 (get_composition_id): Check for overflow in glyph length calculations.
100
101 * coding.c: Integer and memory overflow fixes.
102 (produce_chars): Redo buffer-overflow calculations to avoid
103 unnecessary integer overflow. Check for size overflow.
104 (encode_coding_object): Don't update size until xmalloc succeeds.
105
106 * character.c (Fstring): Check for size-calculation overflow.
107
108 * ccl.c: Integer and memory overflow fixes.
109 (Fccl_execute_on_string): Check for memory overflow.
110 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
111 Redo buffer-overflow calculations to avoid integer overflow.
112
113 * callproc.c (child_setup): Don't assume strlen fits in int.
114
115 * buffer.c: Memory overflow fixes.
116 (overlays_at, overlays_in, record_overlay_string, overlay_strings):
117 Don't update size of array until after memory allocation succeeds,
118 because xmalloc/xrealloc may not return.
119
120 * bidi.c: Integer overflow fix.
121 (bidi_shelve_header_size): New constant.
122 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
123 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
124
125 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
126
127 Use ptrdiff_t for composition IDs.
128 * character.c (lisp_string_width):
129 * composite.c (composition_table_size, n_compositions)
130 (get_composition_id, composition_gstring_from_id):
131 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
132 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
133 * window.c (Frecenter):
134 Use ptrdiff_t, not int, for composition IDs.
135 * composite.c (get_composition_id): Check for integer overflow.
136 * composite.h: Adjust prototypes to match the above changes.
137
138 Use ptrdiff_t for hash table indexes.
139 * category.c (hash_get_category_set):
140 * ccl.c (ccl_driver):
141 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
142 * coding.c (coding_system_charset_list, detect_coding_system):
143 * coding.h (struct coding_system.id):
144 * composite.c (get_composition_id, gstring_lookup_cache):
145 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
146 * image.c (xpm_get_color_table_h):
147 * lisp.h (hash_lookup, hash_put):
148 * minibuf.c (Ftest_completion):
149 Use ptrdiff_t for hash table indexes, not int (which is too
150 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
151 32-bit --with-wide-int hosts).
152
153 * charset.c (Fdefine_charset_internal): Check for integer overflow.
154 Add a FIXME comment about memory leaks.
155 (syms_of_charset): Don't assume xmalloc returns.
156
157 Don't assume that stated character widths fit in int.
158 * character.c (Fchar_width, c_string_width, lisp_string_width):
159 * character.h (CHAR_WIDTH):
160 * indent.c (MULTIBYTE_BYTES_WIDTH):
161 Use sanitize_char_width to avoid undefined and/or bad behavior
162 with outlandish widths.
163 * character.h (sanitize_tab_width): Renamed from sanitize_width,
164 now that we have two such functions. All uses changed.
165 (sanitize_char_width): New inline function.
166
167 Don't assume that tab-width fits in int.
168 * character.h (sanitize_width): New inline function.
169 (SANE_TAB_WIDTH): New macro.
170 (ASCII_CHAR_WIDTH): Use it.
171 * indent.c (sane_tab_width): Remove. All uses replaced by
172 SANE_TAB_WIDTH (current_buffer).
173 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
174
175 * fileio.c: Integer overflow issues with file modes.
176 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
177
178 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
179 Remove unreachable code.
180 (read_hex, load_charset_map_from_file): Check for integer overflow.
181
182 * xterm.c: don't go over XClientMessageEvent limit
183 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
184 (x_send_scroll_bar_event): Likewise. Check that the size does not
185 exceed limits imposed by XClientMessageEvent, as well as the usual
186 ptrdiff_t and size_t limits.
187
188 * keyboard.c: Overflow, signedness and related fixes.
189 (make_lispy_movement): Use same integer type in forward decl
190 that is used in the definition.
191 (read_key_sequence, keyremap_step):
192 Change bufsize argument back to int, undoing my 2011-03-30 change.
193 We prefer signed types, and int is wide enough here.
194 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
195 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
196 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
197 length, not size_t. Use ptrdiff_t for index, not int.
198 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
199 possibility of integer overflow.
200
201 Overflow, signedness and related fixes for images.
202
203 * dispextern.h (struct it.stack[0].u.image.image_id)
204 (struct_it.image_id, struct image.id, struct image_cache.size)
205 (struct image_cache.used, struct image_cache.ref_count):
206 * gtkutil.c (update_frame_tool_bar):
207 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
208 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
209 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
210 * nsmenu.m (update_frame_tool_bar):
211 * xdisp.c (calc_pixel_width_or_height):
212 * xfns.c (image_cache_refcount):
213 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
214 on typical 64-bit hosts.
215
216 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
217 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
218 Omit unnecessary casts to int.
219 (parse_image_spec): Check that integers fall into 'int' range
220 when the callers expect that.
221 (image_ascent): Redo ascent calculation to avoid int overflow.
222 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
223 (lookup_image): Remove unnecessary tests.
224 (xbm_image_p): Locals are now of int, not EMACS_INT,
225 since parse_image_check makes sure they fit into int.
226 (png_load, gif_load, svg_load_image):
227 Prefer int to unsigned where either will do.
228 (tiff_handler): New function, combining the cores of the
229 old tiff_error_handler and tiff_warning_handler. This
230 function is rewritten to use vsnprintf and thereby avoid
231 stack buffer overflows. It uses only the features of vsnprintf
232 that are common to both POSIX and native Microsoft.
233 (tiff_error_handler, tiff_warning_handler): Use it.
234 (tiff_load, gif_load, imagemagick_load_image):
235 Don't assume :index value fits in 'int'.
236 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
237 (imagemagick_load_image): Check that crop parameters fit into
238 the integer types that MagickCropImage accepts. Don't assume
239 Vimagemagick_render_type has a nonnegative value. Don't assume
240 size_t fits in 'long'.
241 (gs_load): Use printmax_t to print the widest integers possible.
242 Check for integer overflow when computing image height and width.
243
244 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
245
246 Integer signedness and overflow and related fixes. (Bug#9079)
247
248 * bidi.c: Integer size and overflow fixes.
249 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
250 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
251 (bidi_cache_find_level_change, bidi_cache_ensure_space)
252 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
253 (bidi_find_other_level_edge):
254 Use ptrdiff_t instead of EMACS_INT where either will do.
255 This works better on 32-bit hosts configured --with-wide-int.
256 (bidi_cache_ensure_space): Check for size-calculation overflow.
257 Use % rather than repeated addition, for better worst-case speed.
258 Don't set bidi_cache_size until after xrealloc returns, because it
259 might not return.
260 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
261 (bidi_cache_ensure_space): Also check that the bidi cache size
262 does not exceed that of the largest Lisp string or buffer. See Eli
263 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
264
265 * alloc.c (__malloc_size_t): Remove.
266 All uses replaced by size_t. See Andreas Schwab's note
267 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
268
269 * image.c: Improve checking for integer overflow.
270 (check_image_size): Assume that f is nonnull, since
271 it is always nonnull in practice. This is one less thing to
272 worry about when checking for integer overflow later.
273 (x_check_image_size): New function, which checks for integer
274 overflow issues inside X.
275 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
276 This removes the need for a memory_full check.
277 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
278 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
279 (xbm_read_bitmap_data): Change locals back to 'int', since
280 their values must fit in 'int'.
281 (xpm_load_image, png_load, tiff_load):
282 Invoke x_create_x_image_and_pixmap earlier,
283 to avoid much needless work if the image is too large.
284 (tiff_load): Treat overly large images as if
285 x_create_x_image_and_pixmap failed, not as malloc failures.
286 (gs_load): Use x_check_image_size.
287
288 * gtkutil.c: Omit integer casts.
289 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
290 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
291
292 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
293
294 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
295 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
296 would wrongly return t on a 64-bit host.
297
298 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
299 The plain *_OVERFLOW macros run afoul of GCC bug 49705
300 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
301 and therefore cause GCC to emit a bogus diagnostic in some cases.
302
303 * image.c: Integer signedness and overflow and related fixes.
304 This is not an exhaustive set of fixes, but it's time to
305 record what I've got.
306 (lookup_pixel_color, check_image_size): Remove redundant decls.
307 (check_image_size): Don't assume that arbitrary EMACS_INT values
308 fit in 'int', or that arbitrary 'double' values fit in 'int'.
309 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
310 (tiff_load, imagemagick_load_image):
311 Check for overflow in size calculations.
312 (x_create_x_image_and_pixmap): Remove unnecessary test for
313 xmalloc returning NULL; that can't happen.
314 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
315 (xpm_color_bucket): Use better integer hashing function.
316 (xpm_cache_color): Don't possibly over-allocate memory.
317 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
318 (gif_memory_source):
319 Use ptrdiff_t, not int or size_t, to record sizes.
320 (png_load): Don't assume values greater than 2**31 fit in 'int'.
321 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
322 either works, as we prefer signed integers.
323 (tiff_read_from_memory, tiff_write_from_memory):
324 Return tsize_t, not size_t, since that's what the TIFF API wants.
325 (tiff_read_from_memory): Don't fail simply because the read would
326 go past EOF; instead, return a short read.
327 (tiff_load): Omit no-longer-needed casts.
328 (Fimagemagick_types): Don't assume size fits into 'int'.
329
330 Improve hashing quality when configured --with-wide-int.
331 * fns.c (hash_string): New function, taken from sxhash_string.
332 Do not discard information about ASCII character case; this
333 discarding is no longer needed.
334 (sxhash-string): Use it. Change sig to match it. Caller changed.
335 * lisp.h: Declare it.
336 * lread.c (hash_string): Remove, since we now use fns.c's version.
337 The fns.c version returns a wider integer if --with-wide-int is
338 specified, so this should help the quality of the hashing a bit.
339
340 * emacs.c: Integer overflow minor fix.
341 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
342 Define only if GNU_LINUX.
343 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
344
345 * dispnew.c: Integer signedness and overflow fixes.
346 Remove unnecessary forward decls, that were a maintenance hassle.
347 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
348 All uses changed.
349 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
350 (scrolling_window): Use ptrdiff_t, not int, for byte count.
351 (prepare_desired_row, line_draw_cost):
352 Use int, not unsigned, where either works.
353 (save_current_matrix, restore_current_matrix):
354 Use ptrdiff_t, not size_t, where either works.
355 (init_display): Check for overflow more accurately, and without
356 relying on undefined behavior.
357
358 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
359 Remove, replacing with the new symbols in lisp.h. All uses changed.
360 * fileio.c (make_temp_name):
361 * filelock.c (lock_file_1, lock_file):
362 * xdisp.c (message_dolog):
363 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
364 Use pMd etc. instead.
365 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
366 replacing the pWIDE etc. symbols removed from editfns.c.
367
368 * keyboard.h (num_input_events): Now uintmax_t.
369 This is (very slightly) less likely to mess up due to wraparound.
370 All uses changed.
371
372 * buffer.c: Integer signedness fixes.
373 (alloc_buffer_text, enlarge_buffer_text):
374 Use ptrdiff_t rather than size_t when either will do, as we prefer
375 signed integers.
376
377 * alloc.c: Integer signedness and overflow fixes.
378 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
379 (__malloc_size_t): Default to size_t, not to int.
380 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
381 (Fgarbage_collect, mark_object_loop_halt, mark_object):
382 Prefer ptrdiff_t to size_t when either would do, as we prefer
383 signed integers.
384 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
385 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
386 Now const. Initialize with values that are in range even if char
387 is signed.
388 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
389 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
390 These functions do the right thing with sizes > 2**32.
391 (check_depth): Now ptrdiff_t, not int.
392 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
393 Adjust to new way of storing sizes. Check for size overflow bugs
394 in rest of code.
395 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
396 slightly wrong anyway, as it missed one instance of
397 XMALLOC_OVERRUN_CHECK_OVERHEAD.
398 (refill_memory_reserve): Omit needless cast to size_t.
399 (mark_object_loop_halt): Mark as externally visible.
400
401 * xselect.c: Integer signedness and overflow fixes.
402 (Fx_register_dnd_atom, x_handle_dnd_message):
403 Use ptrdiff_t, not size_t, since we prefer signed.
404 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
405 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
406 x_dnd_atoms_size and x_dnd_atoms_length.
407
408 * doprnt.c: Prefer signed to unsigned when either works.
409 * eval.c (verror):
410 * doprnt.c (doprnt):
411 * lisp.h (doprnt):
412 * xdisp.c (vmessage):
413 Use ptrdiff_t, not size_t, when using or implementing doprnt,
414 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
415 prefer signed arithmetic to avoid comparison confusion.
416 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
417 but is a bit tricky.
418
419 Assume freestanding C89 headers, string.h, stdlib.h.
420 * data.c, doprnt.c, floatfns.c, print.c:
421 Include float.h unconditionally.
422 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
423 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
424 * regex.c: Likewise for stddef.h, string.h.
425 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
426 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
427 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
428 (STDC_HEADERS): Remove obsolete defines.
429 * sysdep.c: Include limits.h unconditionally.
430
431 Assume support for memcmp, memcpy, memmove, memset.
432 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
433 * regex.c (memcmp, memcpy):
434 Remove; we assume C89 now.
435
436 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
437 (__malloc_safe_bcopy): Remove; no longer needed.
438
439 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
440 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
441 well either way, and we prefer signed to unsigned.
442
443 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
444
445 Port to OpenBSD.
446 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
447 and the surrounding thread.
448 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
449 rather than fgets, and retry after EINTR. Otherwise, 'emacs
450 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
451 timer goes off.
452 * s/openbsd.h (BROKEN_SIGIO): Define.
453 * unexelf.c (unexec) [__OpenBSD__]:
454 Don't update the .mdebug section of the Alpha COFF symbol table.
455
456 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
457
458 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
459 (bug#8460).
460
461 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
462
463 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
464 This fixes some race conditions on the permissions of any newly
465 created file.
466
467 * alloc.c (valid_pointer_p): Use pipe, not open.
468 This fixes some permissions issues when debugging.
469
470 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
471 If fchown fails to set both uid and gid, try to set just gid,
472 as that is sometimes allowed. Adjust the file's mode to eliminate
473 setuid or setgid bits that are inappropriate if fchown fails.
474
475 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
476
477 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
478 to compare Lisp_Objects.
479 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
480 global_gnutls_log_level, don't mistake it for a Lisp_Object.
481 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
482
483 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
484
485 * lread.c (read_integer): Unread even EOF character.
486 (read1): Likewise. Properly record start position of symbol.
487
488 * lread.c (read1): Read `#:' as empty uninterned symbol if no
489 symbol character follows.
490
491 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
492
493 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
494 This works around a problem with the previous change to Fcopy_file.
495 Recent glibc declares fchown with __attribute__((warn_unused_result)),
496 and without this change, GCC might complain about discarding
497 fchown's return value.
498
499 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
500
501 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
502
503 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
504
505 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
506
507 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
508
509 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
510 it's used from the C level.
511
512 * process.c: Use the same condition for POLL_FOR_INPUT in both
513 keyboard.c and process.c (bug#1858).
514
515 2011-07-09 Lawrence Mitchell <wence@gmx.li>
516
517 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
518 (Fgnutls_boot): Use it.
519
520 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
521
522 * doc.c (Fsubstitute_command_keys): Revert last change.
523
524 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
525
526 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
527 quotes the next character, and doesn't affect other longer
528 sequences (bug#8935).
529
530 * lread.c (syms_of_lread): Clarify that is isn't only
531 `eval-buffer' and `eval-defun' that's affected by
532 `lexical-binding' (bug#8460).
533
534 2011-07-15 Eli Zaretskii <eliz@gnu.org>
535
536 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
537 bidi redisplay when a line includes both an image and is
538 truncated.
539
540 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
541
542 Fix minor problems found by static checking.
543 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
544 (elsz): Now a signed constant, not a size_t var. We prefer signed
545 types to unsigned, to avoid integer comparison confusion. Without
546 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
547 "cannot optimize loop, the loop counter may overflow", a symptom
548 of the confusion.
549 * indent.c (Fvertical_motion): Mark locals as initialized.
550 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
551
552 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
553
554 * search.c (Fre_search_backward): Mention `case-fold-search' in
555 all the re_search_* functions (bug#8138).
556
557 * keyboard.c (Fopen_dribble_file): Document when the file is
558 closed (bug#8056).
559
560 2011-07-14 Eli Zaretskii <eliz@gnu.org>
561
562 * bidi.c (bidi_dump_cached_states): Fix format of displaying
563 bidi_cache_idx.
564
565 Support bidi reordering of display and overlay strings.
566 * xdisp.c (compute_display_string_pos)
567 (compute_display_string_end): Accept additional argument STRING.
568 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
569 (reseat_to_string): Initialize bidi_it->string.s and
570 bidi_it->string.schars.
571 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
572 NULL (avoids a crash in bidi_paragraph_init). Initialize
573 itb.string.lstring.
574 (init_iterator): Call bidi_init_it only of a valid
575 buffer position was specified. Initialize paragraph_embedding to
576 L2R.
577 (reseat_to_string): Initialize the bidi iterator.
578 (display_string): If we need to ignore text properties of
579 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
580 original value of -1 will not work with bidi.)
581 (compute_display_string_pos): First arg is now struct
582 `text_pos *'; all callers changed. Support display properties on
583 Lisp strings.
584 (compute_display_string_end): Support display properties on Lisp
585 strings.
586 (init_iterator, reseat_1, reseat_to_string): Initialize the
587 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
588 when iterating on a string not from display properties).
589 (compute_display_string_pos, compute_display_string_end): Fix
590 calculation of the object to scan. Fixes an error when using
591 arrow keys.
592 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
593 base_level_stop; instead, set base_level_stop to BEGV. Fixes
594 crashes in vertical-motion.
595 (next_element_from_buffer): Improve commentary for when
596 the iterator is before prev_stop.
597 (init_iterator): Initialize bidi_p from the default value of
598 bidi-display-reordering, not from buffer-local value. Use the
599 buffer-local value only if initializing for buffer iteration.
600 (handle_invisible_prop): Support invisible properties on strings
601 that are being bidi-reordered.
602 (set_iterator_to_next): Support bidi reordering of C strings and
603 Lisp strings.
604 (next_element_from_string): Support bidi reordering of Lisp
605 strings.
606 (handle_stop_backwards): Support Lisp strings as well.
607 (display_string): Support display of R2L glyph rows. Use
608 IT_STRING_CHARPOS when displaying from a Lisp string.
609 (init_iterator): Don't initialize it->bidi_p for strings
610 here.
611 (reseat_to_string): Initialize it->bidi_p for strings here.
612 (next_element_from_string, next_element_from_c_string)
613 (next_element_from_buffer): Add xassert's for correspondence
614 between IT's object being iterated and it->bidi_it.string
615 structure.
616 (face_before_or_after_it_pos): Support bidi iteration.
617 (next_element_from_c_string): Handle the case of the first string
618 character that is not the first one in the visual order.
619 (get_visually_first_element): New function, refactored from common
620 parts of next_element_from_buffer, next_element_from_string, and
621 next_element_from_c_string.
622 (tool_bar_lines_needed, redisplay_tool_bar)
623 (display_menu_bar): Force left-to-right direction. Add a FIXME
624 comment for making that be controlled by a user option.
625 (push_it, pop_it): Save and restore the state of the
626 bidi iterator. Save and restore the bidi_p flag.
627 (pop_it): Iterate out of display property for string iteration as
628 well.
629 (iterate_out_of_display_property): Support iteration over strings.
630 (handle_single_display_spec): Set up it->bidi_it for iteration
631 over a display string, and call bidi_init_it.
632 (handle_single_display_spec, next_overlay_string)
633 (get_overlay_strings_1, push_display_prop): Set up the bidi
634 iterator for displaying display or overlay strings.
635 (forward_to_next_line_start): Don't use the shortcut if
636 bidi-iterating.
637 (back_to_previous_visible_line_start): If handle_display_prop
638 pushed the iterator stack, restore the internal state of the bidi
639 iterator by calling bidi_pop_it same number of times.
640 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
641 and we are bidi-iterating, don't decrement the iterator position;
642 instead, set the first_elt flag in the bidi iterator, to produce
643 the same effect.
644 (reseat_1): Remove redundant setting of string_from_display_prop_p.
645 (push_display_prop): xassert that we are iterating a buffer.
646 (push_it, pop_it): Save and restore paragraph_embedding member.
647 (handle_single_display_spec, next_overlay_string)
648 (get_overlay_strings_1, reseat_1, reseat_to_string)
649 (push_display_prop): Set up the `unibyte' member of bidi_it.string
650 correctly. Don't assume unibyte strings are not bidi-reordered.
651 (compute_display_string_pos)
652 (compute_display_string_end): Fix handling the case of C string.
653 (push_it, pop_it): Save and restore from_disp_prop_p.
654 (handle_single_display_spec, push_display_prop): Set the
655 from_disp_prop_p flag.
656 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
657 (pop_it): Call iterate_out_of_display_property only if we are
658 popping after iteration over a string that came from a display
659 property. Fix a typo in popping stretch info. Add an assertion
660 for verifying that the iterator position is in sync with the bidi
661 iterator.
662 (handle_single_display_spec, get_overlay_strings_1)
663 (push_display_prop): Fix initialization of paragraph direction for
664 string when that of the parent object is not yet determined.
665 (reseat_1): Call bidi_init_it to resync the bidi
666 iterator with IT's position. (Bug#7616)
667 (find_row_edges): If ROW->start.pos gives position
668 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
669 (handle_stop, back_to_previous_visible_line_start, reseat_1):
670 Reset the from_disp_prop_p flag.
671 (SAVE_IT, RESTORE_IT): New macros.
672 (pos_visible_p, face_before_or_after_it_pos)
673 (back_to_previous_visible_line_start)
674 (move_it_in_display_line_to, move_it_in_display_line)
675 (move_it_to, move_it_vertically_backward, move_it_by_lines)
676 (try_scrolling, redisplay_window, display_line): Use them when
677 saving a temporary copy of the iterator and restoring it back.
678 (back_to_previous_visible_line_start, reseat_1)
679 (init_iterator): Empty the bidi cache "stack".
680 (move_it_in_display_line_to): If iterator ended up at
681 EOL, but we never saw any buffer positions smaller than
682 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
683 motion in bidi-reordered lines.
684 (move_it_in_display_line_to): Record prev_method and prev_pos
685 immediately before the call to set_iterator_to_next. Fixes cursor
686 motion in bidi-reordered lines with stretch glyphs and strings
687 displayed in margins. (Bug#8133) (Bug#8867)
688 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
689 TO_CHARPOS.
690 (pos_visible_p): Support positions in bidi-reordered lines. Save
691 and restore bidi cache.
692
693 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
694 (bidi_paragraph_info): Delete unused struct.
695 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
696 (bidi_cache_start): New variable.
697 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
698 to zero.
699 (bidi_cache_fetch_state, bidi_cache_search)
700 (bidi_cache_find_level_change, bidi_cache_iterator_state)
701 (bidi_cache_find, bidi_peek_at_next_level)
702 (bidi_level_of_next_char, bidi_find_other_level_edge)
703 (bidi_move_to_visually_next): Compare cache index with
704 bidi_cache_start rather than with zero.
705 (bidi_fetch_char): Accept new argument STRING; all callers
706 changed. Support iteration over a string. Support strings with
707 display properties. Support unibyte strings. Fix the type of
708 `len' according to what STRING_CHAR_AND_LENGTH expects.
709 (bidi_paragraph_init, bidi_resolve_explicit_1)
710 (bidi_resolve_explicit, bidi_resolve_weak)
711 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
712 iteration over a string.
713 (bidi_set_sor_type, bidi_resolve_explicit_1)
714 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
715 can now be zero (for strings); special values 0 and -1 were
716 changed to -1 and -2, respectively.
717 (bidi_char_at_pos): New function.
718 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
719 Call it instead of FETCH_MULTIBYTE_CHAR.
720 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
721 initialized to valid values.
722 (bidi_init_it): Don't initialize charpos and bytepos with invalid
723 values.
724 (bidi_level_of_next_char): Allow the sentinel "position" to pass
725 the test for valid cached positions. Fix the logic for looking up
726 the sentinel state in the cache. GCPRO the Lisp string we are
727 iterating.
728 (bidi_push_it, bidi_pop_it): New functions.
729 (bidi_initialize): Initialize the bidi cache start stack pointer.
730 (bidi_cache_ensure_space): New function, refactored from part of
731 bidi_cache_iterator_state. Don't assume the required size is just
732 one BIDI_CACHE_CHUNK away.
733 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
734 (bidi_count_bytes, bidi_char_at_pos): New functions.
735 (bidi_cache_search): Don't assume bidi_cache_last_idx is
736 always valid if bidi_cache_idx is valid.
737 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
738 is valid if it's going to be used.
739 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
740 (bidi_cache_fetch_state, bidi_cache_search)
741 (bidi_cache_find_level_change, bidi_cache_ensure_space)
742 (bidi_cache_iterator_state, bidi_cache_find)
743 (bidi_find_other_level_edge, bidi_cache_start_stack): All
744 variables related to cache indices are now EMACS_INT.
745
746 * dispextern.h (struct bidi_string_data): New structure.
747 (struct bidi_it): New member `string'. Make flag members be 1-bit
748 fields, and put them last in the struct.
749 (compute_display_string_pos, compute_display_string_end): Update
750 prototypes.
751 (bidi_push_it, bidi_pop_it): Add prototypes.
752 (struct iterator_stack_entry): New members bidi_p,
753 paragraph_embedding, and from_disp_prop_p.
754 (struct it): Member bidi_p is now a bit field 1 bit wide.
755 (bidi_shelve_cache, bidi_unshelve_cache): Declare
756 prototypes.
757
758 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
759 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
760 and vector-like objects.
761
762 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
763 cache around display iteration.
764
765 * window.c (Fwindow_end, window_scroll_pixel_based)
766 (displayed_window_lines, Frecenter): Save and restore the bidi
767 cache around display iteration.
768
769 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
770
771 * editfns.c (Fdelete_region): Clarify the use of the named
772 parameters (bug#6788).
773
774 2011-07-14 Martin Rudalics <rudalics@gmx.at>
775
776 * indent.c (Fvertical_motion): Set and restore w->pointm when
777 saving and restoring the window's buffer (Bug#9006).
778
779 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
780
781 * editfns.c (Fstring_to_char): Clarify just what is returned
782 (bug#6576). Text by Eli Zaretskii.
783
784 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
785
786 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
787
788 2011-07-13 Eli Zaretskii <eliz@gnu.org>
789
790 * buffer.c (mmap_find): Fix a typo.
791
792 2011-07-13 Johan Bockgård <bojohan@gnu.org>
793
794 Fix execution of x selection hooks.
795 * xselect.c (Qx_lost_selection_functions)
796 (Qx_sent_selection_functions): New vars.
797 (syms_of_xselect): DEFSYM them.
798 (x_handle_selection_request): Pass Qx_sent_selection_functions
799 rather than Vx_sent_selection_functions to Frun_hook_with_args.
800 (x_handle_selection_clear,x_clear_frame_selections):
801 Pass Qx_lost_selection_functions rather than
802 Vx_lost_selection_functions to Frun_hook_with_args.
803
804 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
805
806 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
807 The old code sometimes used this field without initializing it.
808
809 * alloc.c (gc_sweep): Don't read past end of array.
810 In theory, the old code could also have corrupted Emacs internals,
811 though it'd be very unlikely.
812
813 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
814
815 * character.c (Fcharacterp): Don't advertise optional ignored
816 argument. (Bug#4026)
817
818 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
819
820 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
821 key" (bug#4257).
822
823 * window.c (Fset_window_start): Doc fix (bug#4199).
824 (Fset_window_hscroll): Ditto.
825
826 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
827
828 Fix minor new problems caught by GCC 4.6.1.
829 * term.c (init_tty): Remove unused local.
830 * xsettings.c (store_monospaced_changed): Define this function only
831 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
832 not used otherwise.
833
834 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
835
836 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
837
838 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
839
840 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
841 are the mini-buffer and the echo area (bug#3320).
842
843 * term.c (init_tty): Remove support for supdup, c10 and perq
844 terminals, which are no longer supported (bug#1482).
845
846 2011-07-10 Johan Bockgård <bojohan@gnu.org>
847
848 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
849
850 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
851
852 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
853 for non-popups (Bug#3642).
854
855 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
856
857 * alloc.c (reset_malloc_hooks): Protoize.
858 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
859 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
860 * cm.c (losecursor): Likewise.
861 * data.c (fmod): Likewise.
862 * dispnew.c (swap_glyphs_in_rows): Likewise.
863 * emacs.c (memory_warning_signal): Likewise.
864 * floatfns.c (float_error): Likewise.
865 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
866 (otf_open, font_otf_capability, generate_otf_features)
867 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
868 Likewise.
869 * image.c (pbm_read_file): Likewise.
870 * indent.c (string_display_width): Likewise.
871 * intervals.c (check_for_interval, search_for_interval)
872 (inc_interval_count, count_intervals, root_interval)
873 (adjust_intervals_for_insertion, make_new_interval): Likewise.
874 * lread.c (defalias): Likewise.
875 * ralloc.c (r_alloc_check): Likewise.
876 * regex.c (set_image_of_range_1, set_image_of_range)
877 (regex_grow_registers): Likewise.
878 * sysdep.c (strerror): Likewise.
879 * termcap.c (valid_filename_p, tprint, main): Likewise.
880 * tparam.c (main): Likewise.
881 * unexhp9k800.c (run_time_remap, save_data_space)
882 (update_file_ptrs, read_header, write_header, calculate_checksum)
883 (copy_file, copy_rest, display_header): Likewise.
884 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
885 Likewise.
886 * xdisp.c (check_it): Likewise.
887 * xfaces.c (register_color, unregister_color, unregister_colors):
888 Likewise.
889 * xfns.c (print_fontset_result): Likewise.
890 * xrdb.c (member, fatal, main): Likewise.
891
892 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
893
894 Fix minor problems found by static checking (Bug#9031).
895 * chartab.c (char_table_set_range, map_sub_char_table):
896 Remove unused locals.
897 (uniprop_table): Now static.
898 * composite.c (_work_char): Remove unused static var.
899
900 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
901
902 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
903
904 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
905
906 * gtkutil.c (qttip_cb): Remove code without function.
907
908 2011-07-09 Eli Zaretskii <eliz@gnu.org>
909
910 * w32.c (pthread_sigmask): New stub.
911
912 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
913
914 Use pthread_sigmask, not sigprocmask (Bug#9010).
915 sigprocmask is portable only for single-threaded applications, and
916 Emacs can be multi-threaded when it uses GTK.
917 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
918 (LIBES): Use it.
919 * callproc.c (Fcall_process):
920 * process.c (create_process):
921 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
922 Use pthread_sigmask, not sigprocmask.
923
924 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
925
926 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
927 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
928 wrong (Bug#8591).
929
930 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
931
932 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
933 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
934 (xg_hide_tooltip): Fix comment.
935
936 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
937 in registerServicesMenuSendTypes.
938 (validRequestorForSendType): Don't check ns_return_types.
939
940 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
941 ns_return_type.
942
943 2011-07-08 Jason Rumney <jasonr@gnu.org>
944
945 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
946 frame struct members of non-existent frames (Bug#6284).
947
948 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
949
950 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
951 variable firstTime not needed on OSX >= 10.6.
952 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
953 >= 10.5. Use setKnobProportion, setDoubleValue.
954
955 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
956 (MAC_OS_X_VERSION_10_5): Define if not defined.
957 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
958 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
959 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
960
961 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
962 cString and lossyCString on OSX >= 10.4
963
964 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
965 sizeToFit on OSX >= 10.2.
966
967 * nsimage.m (allocInitFromFile): Don't use deprecated method
968 bestRepresentationForDevice on OSX >= 10.6.
969
970 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
971 to avoid warning.
972
973 * emacs.c: Declare unexec_init_emacs_zone.
974
975 * nsgui.h: Fix compiler warning about gnulib redefining verify.
976
977 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
978
979 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
980 on svcsMenu (Bug#8842).
981
982 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
983 ns_return_types.
984 (Fns_list_services): Just return Qnil on 10.6, code not working there.
985
986 * nsterm.m (QUTF8_STRING): Declare.
987 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
988 (validRequestorForSendType): Return type is (id).
989 Change indexOfObjectIdenticalTo to indexOfObject.
990 Check if we have local selection before returning self (Bug#8842).
991 (writeSelectionToPasteboard): Put local selection into paste board
992 if we have a local selection (Bug#8842).
993 (syms_of_nsterm): DEFSYM QUTF8_STRING.
994
995 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
996 (ns_get_local_selection): Declare.
997
998 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
999
1000 * keymap.c (describe_map_tree): Don't insert a double newline at
1001 the end of the buffer (bug#1169) and return whether we inserted
1002 something.
1003
1004 * callint.c (Fcall_interactively): Change "reading args" to
1005 "providing args" to try to clarify what it does (bug#1010).
1006
1007 2011-07-07 Kenichi Handa <handa@m17n.org>
1008
1009 * composite.c (composition_compute_stop_pos): Ignore a static
1010 composition starting before CHARPOS (Bug#8915).
1011
1012 * xdisp.c (handle_composition_prop): Likewise.
1013
1014 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1015
1016 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1017 (Bug#9015)
1018
1019 2011-07-07 Kenichi Handa <handa@m17n.org>
1020
1021 * character.h (unicode_category_t): New enum type.
1022
1023 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1024 (Qchar_code_property_table): New variable.
1025 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1026 (UNIPROP_COMPRESSED_FORM_P): New macros.
1027 (char_table_ascii): Uncompress the compressed values.
1028 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1029 Uncompress the compressed values.
1030 (sub_char_table_ref_and_range): Likewise.
1031 (char_table_ref_and_range): Uncompress the compressed values.
1032 (sub_char_table_set): New arg is_uniprop. Callers changed.
1033 Uncompress the compressed values.
1034 (sub_char_table_set_range): Args changed. Callers changed.
1035 (char_table_set_range): Adjuted for the above change.
1036 (map_sub_char_table): Delete args default_val and parent. Add arg
1037 top. Give decoded values to a Lisp function.
1038 (map_char_table): Adjusted for the above change. Give decoded
1039 values to a Lisp function. Gcpro more variables.
1040 (uniprop_table_uncompress)
1041 (uniprop_decode_value_run_length): New functions.
1042 (uniprop_decoder, uniprop_decoder_count): New variables.
1043 (uniprop_get_decoder, uniprop_encode_value_character)
1044 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1045 New functions.
1046 (uniprop_encoder, uniprop_encoder_count): New variables.
1047 (uniprop_get_encoder, uniprop_table)
1048 (Funicode_property_table_internal, Fget_unicode_property_internal)
1049 (Fput_unicode_property_internal): New functions.
1050 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1051 Sunicode_property_table_internal, Sget_unicode_property_internal,
1052 and Sput_unicode_property_internal. Defvar_lisp
1053 char-code-property-alist.
1054
1055 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
1056 Vunicode_category_table.
1057
1058 * font.c (font_range): Adjusted for the change of
1059 Vunicode_category_table.
1060
1061 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1062
1063 * m/iris4d.h: Remove file, move contents ...
1064 * s/irix6-5.h: ... here.
1065
1066 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1067
1068 Remove unportable assumption about struct layout (Bug#8884).
1069 * alloc.c (mark_buffer):
1070 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1071 (clone_per_buffer_values): Don't assume that
1072 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1073 This isn't true in general, and it's particularly not true
1074 if Emacs is configured with --with-wide-int.
1075 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1076 New macros, used in the buffer.c change.
1077
1078 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1079
1080 * xsettings.c: Use both GConf and GSettings if both are available.
1081 (store_config_changed_event): Add comment.
1082 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1083 (store_tool_bar_style_changed): New functions.
1084 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1085 (struct xsettings): Move font inside HAVE_XFT.
1086 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1087 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
1088 Move inside HAVE_XFT.
1089 (something_changed_gsettingsCB): Renamed from something_changedCB.
1090 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1091 also.
1092 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1093 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1094 (something_changed_gconfCB): Renamed from something_changedCB.
1095 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1096 (parse_settings): Move check for font inside HAVE_XFT.
1097 (read_settings, apply_xft_settings): Add comment.
1098 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1099 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1100 call store_font_name_changed.
1101 (xft_settings_event): Add comment.
1102 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1103 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1104 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1105 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1106 (xsettings_initialize): Call init_gsettings last.
1107 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
1108 comment.
1109
1110 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1111
1112 Random fixes. E.g., (random) never returned negative values.
1113 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1114 subseconds part to the entropy, as that's a bit more random.
1115 Prefer signed to unsigned, since the signedness doesn't matter and
1116 in general we prefer signed. When given a limit, use a
1117 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1118 latter isn't right if USE_2_TAGS_FOR_INTS.
1119 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1120 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1121
1122 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1123
1124 * textprop.c (text_property_stickiness):
1125 Obey Vtext_property_default_nonsticky.
1126 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1127 * w32fns.c (syms_of_w32fns):
1128 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1129
1130 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1131
1132 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1133 This is more efficient than Ffile_directory_p and avoids a minor race.
1134
1135 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1136
1137 * buffer.c (Foverlay_put): Say what the return value is
1138 (bug#7835).
1139
1140 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1141 is a directory before asking whether to use the file name
1142 (bug#7564).
1143 (barf_or_query_if_file_exists): Make the "File is a directory"
1144 error be more correct.
1145
1146 * fns.c (Frequire): Remove the mention of the .gz files, since
1147 that's installation-specific, but keep the mention of
1148 `get-load-suffixes'.
1149
1150 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1151
1152 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1153 Report string overflow if the output is too long.
1154
1155 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1156
1157 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1158 (syms_of_gnutls): Remove duplicate DEFSYM for
1159 Qgnutls_bootprop_verify_hostname_error, an error for
1160 Qgnutls_bootprop_verify_error (which is no longer used).
1161
1162 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1163 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1164 Also (re)move comments that are misplaced or no longer relevant.
1165
1166 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1167
1168 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1169
1170 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1171
1172 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1173 and background color parameters if they have been changed.
1174
1175 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1176
1177 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1178
1179 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1180
1181 * xsettings.c (SYSTEM_FONT): Define only when used.
1182 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1183
1184 * keymap.c (access_keymap_1): Now static.
1185
1186 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1187
1188 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1189 leave any prefix arg for the up event (Bug#1586).
1190
1191 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1192
1193 * lread.c (syms_of_lread): Mention single symbols defined by
1194 `defvar' or `defconst' (bug#7154).
1195
1196 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1197 (Frequire): Mention get-load-suffixes.
1198
1199 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1200
1201 * window.h (window): Remove clone_number slot.
1202 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1203 Remove.
1204 (make_parent_window, make_window, saved_window)
1205 (Fset_window_configuration, save_window_save): Don't deal with
1206 clone numbers.
1207 * buffer.c (Qclone_number): Remove declaration.
1208 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1209
1210 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1211
1212 Add multiple inheritance to keymaps.
1213 * keymap.c (Fmake_composed_keymap): New function.
1214 (Fset_keymap_parent): Simplify.
1215 (fix_submap_inheritance): Remove.
1216 (access_keymap_1): New function extracted from access_keymap to handle
1217 embedded parents and handle lists of maps.
1218 (access_keymap): Use it.
1219 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1220 (Fcopy_keymap): Handle embedded parents.
1221 (Fcommand_remapping, define_as_prefix): Simplify.
1222 (Fkey_binding): Simplify.
1223 (syms_of_keymap): Move minibuffer-local-completion-map,
1224 minibuffer-local-filename-completion-map,
1225 minibuffer-local-must-match-map, and
1226 minibuffer-local-filename-must-match-map to Elisp.
1227 (syms_of_keymap): Defsubr make-composed-keymap.
1228 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1229 (parse_menu_item): Trivial simplification.
1230
1231 2011-07-01 Glenn Morris <rgm@gnu.org>
1232
1233 * Makefile.in (SETTINGS_LIBS): Fix typo.
1234
1235 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1236
1237 * coding.c (Fencode_coding_string): Record the last coding system
1238 used, as the function doc string says (bug#8738).
1239
1240 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1241
1242 * xsettings.c (store_monospaced_changed): Take new font as arg and
1243 check for change against current_mono_font.
1244 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1245 (emacs_settings_constructor, emacs_settings_get_property)
1246 (emacs_settings_set_property, emacs_settings_class_init)
1247 (emacs_settings_init, gsettings_obj): Remove.
1248 (something_changedCB): New function for HAVE_GSETTINGS.
1249 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1250 with value as argument.
1251 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1252 g_settings_new (Bug#8967). Do not create gsettings_obj.
1253 Remove calls to g_settings_bind. Connect something_changedCB to
1254 "changed".
1255
1256 * xgselect.c: Add defined (HAVE_GSETTINGS).
1257 (xgselect_initialize): Ditto.
1258
1259 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1260 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1261 xg_select.
1262
1263 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1264
1265 * eval.c (struct backtrace): Simplify and port the data structure.
1266 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1267 signed bit field, as this assumption is not portable and it makes
1268 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1269 "char debug_on_exit : 1" as this is not portable either; instead,
1270 use the portable "unsigned int debug_on_exit : 1". Remove unused
1271 member evalargs. Remove obsolete comments about cc bombing out.
1272
1273 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1274
1275 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1276 Let HAVE_GSETTINGS override HAVE_GCONF.
1277 (store_monospaced_changed): New function.
1278 (EMACS_SETTINGS): A new type derived from GObject to handle
1279 GSettings notifications.
1280 (emacs_settings_constructor, emacs_settings_get_property)
1281 (emacs_settings_set_property, emacs_settings_class_init):
1282 New functions.
1283 (gsettings_client, gsettings_obj): New variables.
1284 (GSETTINGS_SCHEMA): New define.
1285 (something_changedCB): Call store_monospaced_changed.
1286 (init_gsettings): New function.
1287 (xsettings_initialize): Call init_gsettings.
1288 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1289 to NULL.
1290
1291 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1292 GCONF_CFLAGS/LIBS.
1293
1294 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1295
1296 * window.c (resize_root_window, grow_mini_window)
1297 (shrink_mini_window): Rename Qresize_root_window to
1298 Qwindow_resize_root_window and Qresize_root_window_vertically to
1299 Qwindow_resize_root_window_vertically.
1300
1301 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1302
1303 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1304
1305 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1306
1307 * makefile.w32-in: Redesign dependencies so they reflect more
1308 clearly which files are directly included by each source file,
1309 and not through other includes.
1310
1311 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1312
1313 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1314 (sort_overlays, overlay_strings): When an overlay's clone number
1315 matches the window's clone number process the overlay even if
1316 the overlay's window property doesn't match the current window.
1317
1318 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1319 (Fwindow_hchild): Rename to Fwindow_left_child.
1320 (Fwindow_next): Rename to Fwindow_next_sibling.
1321 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1322 (resize_window_check): Rename to window_resize_check.
1323 (resize_window_apply): Rename to window_resize_apply.
1324 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1325 (Fdelete_other_windows_internal, resize_frame_windows)
1326 (Fsplit_window_internal, Fdelete_window_internal)
1327 (grow_mini_window, shrink_mini_window)
1328 (Fresize_mini_window_internal): Fix callers accordingly.
1329
1330 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1331
1332 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1333 (emacs_fixed_set_min_size): Remove.
1334 (emacs_fixed_new): Take frame as argument.
1335
1336 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1337 (_EmacsFixedPrivate): Remove minwidth/height.
1338 Add struct frame *f.
1339 (emacs_fixed_init): Initialize priv->f.
1340 (get_parent_class, emacs_fixed_set_min_size): Remove.
1341 (emacs_fixed_new): Set priv->f to argument.
1342 (emacs_fixed_get_preferred_width)
1343 (emacs_fixed_get_preferred_height): Use min_width/height from
1344 frames size_hint to set minimum and natural (Bug#8919).
1345 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1346 and use min_width/height from frames size_hint to set
1347 min_width/height (Bug#8919).
1348
1349 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1350 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1351 Fix indentation.
1352
1353 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1354
1355 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1356 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1357 called at ZV.
1358
1359 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1360
1361 * process.c (wait_reading_process_output): Bypass select if
1362 waiting for a cell while ignoring keyboard input, and input is
1363 pending. Suggested by Jan Djärv (Bug#8869).
1364
1365 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1366
1367 Use gnulib's dup2 module instead of rolling our own.
1368 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1369
1370 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1371
1372 * dispnew.c (scrolling_window): Before scrolling, turn off a
1373 mouse-highlight in the window being scrolled.
1374
1375 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1376
1377 Move DEFSYM to lisp.h and use everywhere.
1378
1379 * character.h (DEFSYM): Move declaration...
1380 * lisp.h (DEFSYM): ...here.
1381
1382 * gnutls.c:
1383 * minibuf.c:
1384 * w32menu.c:
1385 * w32proc.c:
1386 * w32select.c: Don't include character.h.
1387
1388 * alloc.c (syms_of_alloc):
1389 * buffer.c (syms_of_buffer):
1390 * bytecode.c (syms_of_bytecode):
1391 * callint.c (syms_of_callint):
1392 * casefiddle.c (syms_of_casefiddle):
1393 * casetab.c (init_casetab_once):
1394 * category.c (init_category_once, syms_of_category):
1395 * ccl.c (syms_of_ccl):
1396 * cmds.c (syms_of_cmds):
1397 * composite.c (syms_of_composite):
1398 * dbusbind.c (syms_of_dbusbind):
1399 * dired.c (syms_of_dired):
1400 * dispnew.c (syms_of_display):
1401 * doc.c (syms_of_doc):
1402 * editfns.c (syms_of_editfns):
1403 * emacs.c (syms_of_emacs):
1404 * eval.c (syms_of_eval):
1405 * fileio.c (syms_of_fileio):
1406 * fns.c (syms_of_fns):
1407 * frame.c (syms_of_frame):
1408 * fringe.c (syms_of_fringe):
1409 * insdel.c (syms_of_insdel):
1410 * keymap.c (syms_of_keymap):
1411 * lread.c (init_obarray, syms_of_lread):
1412 * macros.c (syms_of_macros):
1413 * msdos.c (syms_of_msdos):
1414 * print.c (syms_of_print):
1415 * process.c (syms_of_process):
1416 * search.c (syms_of_search):
1417 * sound.c (syms_of_sound):
1418 * syntax.c (init_syntax_once, syms_of_syntax):
1419 * terminal.c (syms_of_terminal):
1420 * textprop.c (syms_of_textprop):
1421 * undo.c (syms_of_undo):
1422 * w32.c (globals_of_w32):
1423 * window.c (syms_of_window):
1424 * xdisp.c (syms_of_xdisp):
1425 * xfaces.c (syms_of_xfaces):
1426 * xfns.c (syms_of_xfns):
1427 * xmenu.c (syms_of_xmenu):
1428 * xsettings.c (syms_of_xsettings):
1429 * xterm.c (syms_of_xterm): Use DEFSYM.
1430
1431 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1432
1433 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1434
1435 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1436
1437 Integer and buffer overflow fixes (Bug#8873).
1438
1439 * print.c (printchar, strout): Check for string overflow.
1440 (PRINTPREPARE, printchar, strout):
1441 Don't set size unless allocation succeeds.
1442
1443 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1444 for sizes. Check for string overflow more accurately.
1445 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1446
1447 * macros.c: Integer and buffer overflow fixes.
1448 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1449 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1450 Use ptrdiff_t, not int, for sizes.
1451 Don't increment bufsize until after realloc succeeds.
1452 Check for size-calculation overflow.
1453 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1454
1455 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1456
1457 * lread.c: Integer overflow fixes.
1458 (read_integer): Radix is now EMACS_INT, not int,
1459 to improve quality of diagnostics for out-of-range radices.
1460 Calculate buffer size correctly for out-of-range radices.
1461 (read1): Check for integer overflow in radices, and in
1462 read-circle numbers.
1463 (read_escape): Avoid int overflow.
1464 (Fload, openp, read_buffer_size, read1)
1465 (substitute_object_recurse, read_vector, read_list, map_obarray):
1466 Use ptrdiff_t, not int, for sizes.
1467 (read1): Use EMACS_INT, not int, for sizes.
1468 Check for size overflow.
1469
1470 * image.c (cache_image): Check for size arithmetic overflow.
1471
1472 * lread.c: Integer overflow issues.
1473 (saved_doc_string_size, saved_doc_string_length)
1474 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1475 Now ptrdiff_t, not int.
1476 (read1): Don't assume doc string length fits in int. Check for
1477 out-of-range doc string lengths.
1478 (read_list): Don't assume file position fits in int.
1479 (read_escape): Check for hex character overflow.
1480
1481 2011-06-22 Leo Liu <sdl.web@gmail.com>
1482
1483 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1484 Move to minibuffer.el.
1485
1486 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1487
1488 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1489 The following patches are for when GLYPH_DEBUG && !XASSERT.
1490 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1491 * dispnew.c (flush_stdout):
1492 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1493 Mark as externally visible.
1494 * dispnew.c (check_window_matrix_pointers): Now static.
1495 * dispnew.c (window_to_frame_vpos):
1496 * xfns.c (unwind_create_frame):
1497 * xterm.c (x_check_font): Remove unused local.
1498 * scroll.c (CHECK_BOUNDS):
1499 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1500 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1501 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1502 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1503 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1504 Now static.
1505 (debug_method_add): Use va_list and vsprintf rather than relying
1506 on undefined behavior with wrong number of arguments.
1507 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1508 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1509 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1510 since we're not interested in debugging glyphs with old libraries.
1511 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1512 GCC 4.6.0's static checking.
1513
1514 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1515
1516 Integer overflow and signedness fixes (Bug#8873).
1517 A few related buffer overrun fixes, too.
1518
1519 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1520
1521 * dispextern.h (struct face.stipple):
1522 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1523 (x_bitmap_mask, x_allocate_bitmap_record)
1524 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1525 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1526 (x_create_bitmap_from_xpm_data):
1527 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1528 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1529 (.bitmaps_last):
1530 * xfaces.c (load_pixmap):
1531 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1532 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1533 (.bitmaps_last, struct x_output.icon_bitmap):
1534 Use ptrdiff_t, not int, for bitmap indexes.
1535 (x_allocate_bitmap_record): Check for size overflow.
1536 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1537
1538 Use ptrdiff_t, not int, for overlay counts.
1539 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1540 * editfns.c (overlays_around, get_pos_property):
1541 * textprop.c (get_char_property_and_overlay):
1542 * xdisp.c (next_overlay_change, note_mouse_highlight):
1543 * xfaces.c (face_at_buffer_position):
1544 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1545 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1546 (Fnext_overlay_change, Fprevious_overlay_change)
1547 (mouse_face_overlay_overlaps, Foverlays_in):
1548 Use ptrdiff_t, not int, for sizes.
1549 (overlays_at, overlays_in): Check for size-calculation overflow.
1550
1551 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1552
1553 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1554 (x_session_initialize): Do not assume string length fits in int.
1555
1556 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1557 This is unlikely, but can occur if DPI is outlandish.
1558
1559 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1560 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1561
1562 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1563 * xrdb.c (magic_file_p, search_magic_path):
1564 Omit last arg SUFFIX; it was always 0. All callers changed.
1565 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1566
1567 * xfont.c (xfont_match): Avoid need for strlen.
1568
1569 * xfns.c: Don't assume strlen fits in int.
1570 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1571
1572 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1573 not unsigned long, as we prefer signed integers. All callers changed.
1574 Detect integer overflow in repeat count.
1575 (message_dolog): Don't assume print length fits in 39 bytes.
1576 (display_mode_element): Don't assume strlen fits in int.
1577
1578 * termcap.c: Don't assume sizes fit in int and never overflow.
1579 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1580 (gobble_line): Check for size-calculation overflow.
1581
1582 * minibuf.c (Fread_buffer):
1583 * lread.c (intern, intern_c_string):
1584 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1585 Don't assume string length fits in int.
1586
1587 * keyboard.c (parse_tool_bar_item):
1588 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1589
1590 * font.c: Don't assume string length fits in int.
1591 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1592 Use ptrdiff_t, not int.
1593 (font_intern_prop): Don't assume string length fits in int.
1594 Don't assume integer property fits in fixnum.
1595 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1596
1597 * filelock.c: Fix some buffer overrun and integer overflow issues.
1598 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1599 Reformulate so as not to need the command string.
1600 Invoke gzip -cd rather than gunzip, as it's more portable.
1601 (lock_info_type, lock_file_1, lock_file):
1602 Don't assume pid_t and time_t fit in unsigned long.
1603 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1604 (current_lock_owner): Prefer signed type for sizes.
1605 Use memcpy, not strncpy, where memcpy is what is really wanted.
1606 Don't assume (via atoi) that time_t and pid_t fit in int.
1607 Check for time_t and/or pid_t out of range, e.g., via a network share.
1608 Don't alloca where an auto var works fine.
1609
1610 * fileio.c: Fix some integer overflow issues.
1611 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1612 Don't assume string length fits in int.
1613 (directory_file_name): Don't assume string length fits in long.
1614 (make_temp_name): Don't assume pid fits in int, or that its print
1615 length is less than 20.
1616
1617 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1618
1619 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1620
1621 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1622
1623 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1624 We prefer signed integers, even for size calculations.
1625
1626 * emacs.c: Don't assume string length fits in 'int'.
1627 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1628 (main): Don't invoke strlen when not needed.
1629
1630 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1631 (XD_DEBUG_MESSAGE): Don't waste a byte.
1632
1633 * callproc.c (getenv_internal_1, getenv_internal)
1634 (Fgetenv_internal):
1635 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1636
1637 * lread.c (invalid_syntax): Omit length argument.
1638 All uses changed. This doesn't fix a bug, but it simplifies the
1639 code away from its former Hollerith-constant appearance, and it's
1640 one less 'int' to worry about when looking at integer-overflow issues.
1641 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1642
1643 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1644 This didn't break anything, but it didn't help either.
1645 It's confusing to put a bogus integer in a place where the actual
1646 value does not matter.
1647 (LIST_END_P): Remove unused macro and its bogus comment.
1648 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1649
1650 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1651 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1652 implementation.
1653 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1654 We prefer signed types, and the value cannot exceed the EMACS_INT
1655 range anyway (because otherwise the length would not be representable).
1656 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1657 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1658 This avoids a GCC warning when WIDE_EMACS_INT.
1659
1660 * indent.c (sane_tab_width): New function.
1661 (current_column, scan_for_column, Findent_to, position_indentation)
1662 (compute_motion): Use it. This is just for clarity.
1663 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1664
1665 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1666
1667 * lisp.h (lint_assume): New macro.
1668 * composite.c (composition_gstring_put_cache):
1669 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1670
1671 * editfns.c, insdel.c:
1672 Omit unnecessary forward decls, to simplify future changes.
1673
1674 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1675
1676 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1677
1678 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1679 Use much-faster test for byte-length change.
1680 Don't assume string byte-length fits in 'int'.
1681 Check that character arg fits in 'int'.
1682 (mapcar1): Declare byte as byte, for clarity.
1683
1684 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1685
1686 * fns.c (concat): Catch string overflow earlier.
1687 Do not rely on integer wraparound.
1688
1689 * dispextern.h (struct it.overlay_strings_charpos)
1690 (struct it.selective): Now EMACS_INT, not int.
1691 * xdisp.c (forward_to_next_line_start)
1692 (back_to_previous_visible_line_start)
1693 (reseat_at_next_visible_line_start, next_element_from_buffer):
1694 Don't arbitrarily truncate the value of 'selective' to int.
1695
1696 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1697
1698 * composite.c: Don't truncate sizes to 'int'.
1699 (composition_gstring_p, composition_reseat_it)
1700 (composition_adjust_point): Use EMACS_INT, not int.
1701 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1702 not EMACS_UINT, for indexes.
1703
1704 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1705
1706 * buffer.c: Include <verify.h>.
1707 (struct sortvec.priority, struct sortstr.priority):
1708 Now EMACS_INT, not int.
1709 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1710 (struct sortstr.size, record_overlay_string)
1711 (struct sortstrlist.size, struct sortlist.used):
1712 Don't truncate size to int.
1713 (record_overlay_string): Check for size-calculation overflow.
1714 (init_buffer_once): Check at compile-time, not run-time.
1715
1716 2011-06-22 Jim Meyering <meyering@redhat.com>
1717
1718 Don't leak an XBM-image-sized buffer
1719 * image.c (xbm_load): Free the image buffer after using it.
1720
1721 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1722
1723 Port to Sun C.
1724 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1725 that Sun C diagnosed.
1726 * fns.c (secure_hash): Fix pointer signedness issue.
1727 * intervals.c (static_offset_intervals): New function.
1728 (offset_intervals): Use it.
1729
1730 2011-06-21 Leo Liu <sdl.web@gmail.com>
1731
1732 * deps.mk (fns.o):
1733 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1734 sha512.h.
1735
1736 * fns.c (secure_hash): Rename from crypto_hash_function and change
1737 the first arg to accept symbols.
1738 (Fsecure_hash): New primitive.
1739 (syms_of_fns): New symbols.
1740
1741 2011-06-20 Deniz Dogan <deniz@dogan.se>
1742
1743 * process.c (Fset_process_buffer): Clarify return value in
1744 docstring.
1745
1746 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1747
1748 * dispnew.c (add_window_display_history): Use BVAR.
1749
1750 * xdisp.c (debug_method_add): Use BVAR.
1751 (check_window_end, dump_glyph_matrix, dump_glyph)
1752 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1753
1754 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1755 Likewise.
1756
1757 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1758 check till after the cache is created in init_frame_faces.
1759
1760 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1761
1762 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1763
1764 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1765
1766 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1767 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1768 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1769
1770 Improve buffer-overflow checking (Bug#8873).
1771 * fileio.c (Finsert_file_contents):
1772 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1773 Remove the old (too-loose) buffer overflow checks.
1774 They weren't needed, since make_gap checks for buffer overflow.
1775 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1776 The old code merely checked for Emacs fixnum overflow, and relied
1777 on undefined (wraparound) behavior. The new code avoids undefined
1778 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1779
1780 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1781 Tune. Don't use wider integers than needed. Don't use alloca.
1782 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1783
1784 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1785
1786 * insdel.c, lisp.h (buffer_overflow): New function.
1787 (insert_from_buffer_1, replace_range, replace_range_2):
1788 * insdel.c (make_gap_larger):
1789 * editfns.c (Finsert_char):
1790 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1791
1792 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1793
1794 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1795
1796 Integer overflow and signedness fixes (Bug#8873).
1797
1798 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1799 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1800
1801 * fileio.c: Don't assume EMACS_INT fits in off_t.
1802 (emacs_lseek): New static function.
1803 (Finsert_file_contents, Fwrite_region): Use it.
1804 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1805
1806 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1807
1808 * fns.c: Don't overflow int when computing a list length.
1809 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1810 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1811 truncation on 64-bit hosts. Check for QUIT every
1812 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1813 faster and is responsive enough.
1814 (Flength): Report an error instead of overflowing an integer.
1815 (Fsafe_length): Return a float if the value is not representable
1816 as a fixnum. This shouldn't happen except in contrived situations.
1817 (Fnthcdr, Fsort): Don't assume list length fits in int.
1818 (Fcopy_sequence): Don't assume vector length fits in int.
1819
1820 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1821 (header_size, word_size): New constants.
1822 (allocate_vectorlike): Don't check size overflow here.
1823 (allocate_vector): Check it here instead, since this is the only
1824 caller of allocate_vectorlike that could cause overflow.
1825 Check that the new vector's length is representable as a fixnum.
1826
1827 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1828 The previous code was bogus. For example, next_almost_prime (32)
1829 returned 39, which is undesirable as it is a multiple of 3; and
1830 next_almost_prime (24) returned 25, which is a multiple of 5 so
1831 why was the code bothering to check for multiples of 7?
1832
1833 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1834
1835 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1836
1837 Variadic C functions now count arguments with ptrdiff_t.
1838 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1839 Back then I didn't know that the Emacs coding style prefers signed int.
1840 Also, in the meantime I found a few more instances where arguments
1841 were being counted with int, which may truncate counts on 64-bit
1842 machines, or EMACS_INT, which may be unnecessarily wide.
1843 * lisp.h (struct Lisp_Subr.function.aMANY)
1844 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1845 Arg counts are now ptrdiff_t, not size_t.
1846 All variadic functions and their callers changed accordingly.
1847 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1848 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1849 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1850 * callint.c (Fcall_interactively): Check arg count for overflow,
1851 to avoid potential buffer overrun. Use signed char, not 'int',
1852 for 'varies' array, so that we needn't bother to check its size
1853 calculation for overflow.
1854 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1855 * eval.c (apply_lambda):
1856 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1857 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1858 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1859
1860 * callint.c (Fcall_interactively): Don't use index var as event count.
1861
1862 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1863 * mem-limits.h (SIZE): Remove; no longer used.
1864
1865 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1866
1867 Remove unnecessary casts.
1868 * xterm.c (x_term_init):
1869 * xfns.c (x_set_border_pixel):
1870 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1871 These aren't needed now that we assume ANSI C.
1872
1873 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1874 It's more likely to cause problems (due to unsigned overflow)
1875 than to cure them.
1876
1877 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1878
1879 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1880
1881 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1882
1883 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1884
1885 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1886
1887 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1888
1889 GLYPH_CODE_FACE returns EMACS_INT, not int.
1890 * dispextern.h (merge_faces):
1891 * xfaces.c (merge_faces):
1892 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1893 Don't assume EMACS_INT fits in int.
1894
1895 * character.h (CHAR_VALID_P): Remove unused parameter.
1896 * fontset.c, lisp.h, xdisp.c: All uses changed.
1897
1898 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1899
1900 * fns.c (concat): Minor tuning based on overflow analysis.
1901 This doesn't fix any bugs. Use int to hold character, instead
1902 of constantly refetching from Emacs object. Use XFASTINT, not
1903 XINT, for value known to be a character. Don't bother comparing
1904 a single byte to 0400, as it's always less.
1905
1906 * floatfns.c (Fexpt):
1907 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1908
1909 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1910 for characters.
1911
1912 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1913
1914 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1915 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1916 incorrectly succeed when S was a string, because 4294967386 was
1917 truncated before it was used.
1918
1919 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1920 Otherwise, an out-of-range integer could cause undefined behavior
1921 on a 64-bit host.
1922
1923 * composite.c: Use int, not EMACS_INT, for characters.
1924 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1925 EMACS_INT, for values that are known to be in character range.
1926 This doesn't fix any bugs but is the usual style inside Emacs and
1927 may generate better code on 32-bit machines.
1928
1929 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1930 This is for reasons similar to the recent CHAR_STRING fix.
1931 * charset.c (Fencode_char): Check that character arg is actually
1932 a character. Pass an int to ENCODE_CHAR.
1933 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1934 wider than 'int', as a compile-time check to prevent future regressions
1935 in this area.
1936
1937 * character.c (char_string): Remove unnecessary casts.
1938
1939 Make sure a 64-bit char is never passed to CHAR_STRING.
1940 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1941 by silently ignoring the top 32 bits, allowing some values
1942 that were far too large to be valid characters.
1943 * character.h: Include <verify.h>.
1944 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1945 arguments are no wider than unsigned, as a compile-time check
1946 to prevent future regressions in this area.
1947 * data.c (Faset):
1948 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1949 (Fsubst_char_in_region):
1950 * fns.c (concat):
1951 * xdisp.c (decode_mode_spec_coding):
1952 Adjust to CHAR_STRING's new requirement.
1953 * editfns.c (Finsert_char, Fsubst_char_in_region):
1954 * fns.c (concat): Check that character args are actually
1955 characters. Without this test, these functions did the wrong
1956 thing with wildly out-of-range values on 64-bit hosts.
1957
1958 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1959 These casts should not be needed on 32-bit hosts, either.
1960 * keyboard.c (read_char):
1961 * lread.c (Fload): Remove casts to unsigned.
1962
1963 * lisp.h (UNSIGNED_CMP): New macro.
1964 This fixes comparison bugs on 64-bit hosts.
1965 (ASCII_CHAR_P): Use it.
1966 * casefiddle.c (casify_object):
1967 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1968 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1969 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1970 * dispextern.h (FACE_FROM_ID):
1971 * keyboard.c (read_char): Use UNSIGNED_CMP.
1972
1973 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1974 not to EMACS_INT, to avoid GCC warning.
1975
1976 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1977
1978 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1979 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1980 isn't needed on 32-bit machines.
1981
1982 * buffer.c (Fgenerate_new_buffer_name):
1983 Use EMACS_INT for count, not int.
1984 (advance_to_char_boundary): Return EMACS_INT, not int.
1985
1986 * data.c (Qcompiled_function): Now static.
1987
1988 * window.c (window_body_lines): Now static.
1989
1990 * image.c (gif_load): Rename local to avoid shadowing.
1991
1992 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1993 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1994 * alloc.c (make_save_value): Integer argument is now of type
1995 ptrdiff_t, not int.
1996 (mark_object): Use ptrdiff_t, not int.
1997 * lisp.h (pD): New macro.
1998 * print.c (print_object): Use it.
1999
2000 * alloc.c: Use EMACS_INT, not int, to count objects.
2001 (total_conses, total_markers, total_symbols, total_vector_size)
2002 (total_free_conses, total_free_markers, total_free_symbols)
2003 (total_free_floats, total_floats, total_free_intervals)
2004 (total_intervals, total_strings, total_free_strings):
2005 Now EMACS_INT, not int. All uses changed.
2006 (Fgarbage_collect): Compute overall total using a double, so that
2007 integer overflow is less likely to be a problem. Check for overflow
2008 when converting back to an integer.
2009 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2010 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2011 These were 'int' variables that could overflow on 64-bit hosts;
2012 they were never used, so remove them instead of repairing them.
2013 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2014 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2015 Previously, this ceilinged at INT_MAX, but that doesn't work on
2016 64-bit machines.
2017 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2018
2019 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2020 (allocate_vectorlike): Check for ptrdiff_t overflow.
2021 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2022 when a (possibly-narrower) signed value would do just as well.
2023 We prefer using signed arithmetic, to avoid comparison confusion.
2024
2025 * alloc.c: Catch some string size overflows that we were missing.
2026 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2027 for convenience in STRING_BYTES_MAX.
2028 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2029 The definition here is exact; the one in lisp.h was approximate.
2030 (allocate_string_data): Check for string overflow. This catches
2031 some instances we weren't catching before. Also, it catches
2032 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2033 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2034 and ptrdiff_t and EMACS_INT are both 64 bits.
2035
2036 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2037 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2038 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
2039
2040 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2041
2042 * alloc.c (Fmake_string): Check for out-of-range init.
2043
2044 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2045
2046 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2047
2048 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2049
2050 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2051 xg_get_default_scrollbar_width.
2052
2053 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2054 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2055 (style_changed_cb): Call update_theme_scrollbar_width and call
2056 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2057 all frames (Bug#8505).
2058 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2059 Call gtk_window_set_resizable if HAVE_GTK3.
2060 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2061 and height if HAVE_GTK3 (Bug#8505).
2062 (scroll_bar_width_for_theme): New variable.
2063 (update_theme_scrollbar_width): New function.
2064 (xg_get_default_scrollbar_width): Move code to
2065 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2066 (xg_initialize): Call update_theme_scrollbar_width.
2067
2068 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2069
2070 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2071
2072 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2073
2074 * frame.c (make_frame): Call other_buffer_safely instead of
2075 other_buffer.
2076
2077 * window.c (temp_output_buffer_show): Call display_buffer with
2078 second argument Vtemp_buffer_show_specifiers and reset latter
2079 immediately after the call.
2080 (Vtemp_buffer_show_specifiers): New variable.
2081 (auto_window_vscroll_p, next_screen_context_lines)
2082 (Vscroll_preserve_screen_position): Remove leading asterisks from
2083 doc-strings.
2084
2085 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2086
2087 Fix minor problems found by GCC 4.6.0 static checking.
2088 * buffer.c (Qclone_number): Remove for now, as it's unused.
2089 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2090 (record_buffer): Remove unused local.
2091 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2092 (set_frame_buffer_list): Remove; unused.
2093 * frame.h (other_visible_frames): Remove decl.
2094 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2095 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2096 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2097 if HAVE_GPM.
2098 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2099 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2100 Define only if HAVE_GPM.
2101 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2102 (update_hints_inhibit): Remove; never set. All uses removed.
2103 * widgetprv.h (emacsFrameClassRec): Remove decl.
2104 * window.c (delete_deletable_window): Now returns void, since it
2105 wasn't returning anything.
2106 (compare_window_configurations): Remove unused locals.
2107 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2108 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2109 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2110 the same widths as pointers. This follows up on the 2011-05-06 patch.
2111 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2112 * xterm.h: Likewise.
2113 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2114
2115 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2116
2117 * makefile.w32-in: Update dependencies.
2118 (LISP_H): Add lib/intprops.h.
2119
2120 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2121
2122 * image.c (gif_load): Add animation frame delay to the metadata.
2123 (syms_of_image): Use DEFSYM. New symbol `delay'.
2124
2125 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2126
2127 * window.c (delete_deletable_window): Re-add.
2128 (Fset_window_configuration): Rewrite to handle dead buffers and
2129 consequently deletable windows.
2130 (window_tree, Fwindow_tree): Remove. Supply functionality in
2131 window.el.
2132 (compare_window_configurations): Simplify code.
2133
2134 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2135
2136 * image.c (imagemagick_load_image): Fix type mismatch.
2137 (Fimagemagick_types): Likewise.
2138
2139 * window.h (replace_buffer_in_windows): Declare.
2140
2141 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2142
2143 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2144 Qclone_number. Remove external declaration of Qdelete_window.
2145 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2146 code.
2147 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
2148 Qbuffer_list_update_hook if allowed.
2149 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2150 buffer list implementation.
2151 (other_buffer_safely): New function.
2152 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2153 calls to replace_buffer_in_windows and
2154 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2155 if allowed.
2156 (record_buffer): Inhibit quitting and rewrite using quittable
2157 functions. Run Qbuffer_list_update_hook if allowed.
2158 (Frecord_buffer, Funrecord_buffer): New functions.
2159 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
2160 switch-to-buffer to window.el.
2161 (bury-buffer): Move to window.el.
2162 (Vbuffer_list_update_hook): New variable.
2163
2164 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2165 section.
2166
2167 * window.h (resize_frame_windows): Move up in code.
2168 (Fwindow_frame): Remove EXFUN.
2169 (replace_buffer_in_all_windows): Remove prototype.
2170 (replace_buffer_in_windows_safely): Add prototype.
2171
2172 * window.c: Declare Qdelete_window static again. Move down
2173 declaration of select_count.
2174 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2175 (Fother_window): Move to window.el.
2176 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2177 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2178 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2179 window.el.
2180 (replace_buffer_in_windows): Implement by calling
2181 Qreplace_buffer_in_windows.
2182 (replace_buffer_in_all_windows): Remove with some functionality
2183 moved into replace_buffer_in_windows_safely.
2184 (replace_buffer_in_windows_safely): New function.
2185 (select_window_norecord, select_frame_norecord): Move in front
2186 of run_window_configuration_change_hook. Remove now obsolete
2187 declarations.
2188 (Fset_window_buffer): Rewrite doc-string. Call
2189 Qrecord_window_buffer.
2190 (keys_of_window): Move binding for other-window to window.el.
2191
2192 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2193
2194 * dispextern.h (struct image): Replace data member, whose int_val
2195 and ptr_val fields were not used by anything, with a single
2196 lisp_val object.
2197
2198 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2199 (gif_clear_image, gif_load, imagemagick_load_image)
2200 (gs_clear_image, gs_load): Callers changed.
2201
2202 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2203
2204 * buffer.h: Include <time.h>, for time_t.
2205 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2206
2207 Fix minor problems found by static checking.
2208
2209 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2210
2211 Make identifiers static if they are not used in other modules.
2212 * data.c (Qcompiled_function, Qframe, Qvector):
2213 * image.c (QimageMagick, Qsvg):
2214 * minibuf.c (Qmetadata):
2215 * window.c (resize_window_check, resize_root_window): Now static.
2216 * window.h (resize_window_check, resize_root_window): Remove decls.
2217
2218 * window.c (window_deletion_count, delete_deletable_window):
2219 Remove; unused.
2220 (window_body_lines): Now static.
2221 (Fdelete_other_windows_internal): Mark vars as initialized.
2222 Make sure 'resize_failed' is initialized.
2223 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2224 (resize_window_apply): Remove unused local.
2225 * window.h (delete_deletable_window): Remove decl.
2226
2227 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2228 (imagemagick_load_image): Fix pointer signedness problem by changing
2229 last arg from unsigned char * to char *. All uses changed.
2230 Also, fix a local for similar reasons.
2231 Remove unused locals. Remove locals to avoid shadowing.
2232 (fn_rsvg_handle_free): Remove; unused.
2233 (svg_load, svg_load_image): Fix pointer signedness problem.
2234 (imagemagick_load_image): Don't use garbage pointer image_wand.
2235
2236 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2237
2238 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2239
2240 * image.c (gif_load): Fix omitted cast error introduced by
2241 2011-06-06 change.
2242
2243 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2244
2245 * window.h (resize_proportionally, orig_total_lines)
2246 (orig_top_line): Remove from window structure.
2247 (set_window_height, set_window_width, change_window_heights)
2248 (Fdelete_window): Remove prototypes.
2249 (resize_frame_windows): Remove duplicate declaration.
2250
2251 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2252
2253 * window.h (resize_frame_windows, resize_window_check)
2254 (delete_deletable_window, resize_root_window)
2255 (resize_frame_windows): Declare prototypes.
2256
2257 * window.c (resize_window_apply): Make definition be "static" to
2258 match the prototype.
2259
2260 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2261
2262 * window.c: Remove declarations of Qwindow_size_fixed,
2263 window_min_size_1, window_min_size_2, window_min_size,
2264 size_window, window_fixed_size_p, enlarge_window, delete_window.
2265 Remove static from declaration of Qdelete_window, it's
2266 temporarily needed by Fbury_buffer.
2267 (replace_window): Don't assign orig_top_line and
2268 orig_total_lines.
2269 (Fdelete_window, delete_window): Remove. Window deletion is
2270 handled by window.el.
2271 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2272 Fdelete_window calls with calls to Qdelete_window.
2273 (Fdelete_other_windows): Remove. Deleting other windows is
2274 handled by window.el.
2275 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2276 handled in window.el.
2277 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2278 Window minimum sizes are handled in window.el.
2279 (shrink_windows, size_window, set_window_height)
2280 (set_window_width, change_window_heights, window_height)
2281 (window_width, CURBEG, CURSIZE, enlarge_window)
2282 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2283 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2284 handled in window.el.
2285 (make_dummy_parent): Rename to make_parent_window and give it a
2286 second argument horflag.
2287 (make_window): Don't set resize_proportionally any more.
2288 (Fsplit_window): Remove. Windows are split in window.el.
2289 (save_restore_action, save_restore_orig_size)
2290 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2291 Resize mini windows in window.el.
2292 (grow_mini_window, shrink_mini_window): Implement by calling
2293 Qresize_root_window_vertically, resize_window_check and
2294 resize_window_apply.
2295 (saved_window, Fset_window_configuration, save_window_save): Do
2296 not handle orig_top_line, orig_total_lines, and
2297 resize_proportionally.
2298 (window_min_height, window_min_width): Move to window.el.
2299 (keys_of_window): Move bindings for delete-other-windows,
2300 split-window, delete-window and enlarge-window to window.el.
2301
2302 * buffer.c: Temporarily extern Qdelete_window.
2303 (Fbury_buffer): Temporarily call Qdelete_window instead of
2304 Fdelete_window (Fbury_buffer will move to window.el soon).
2305
2306 * frame.c (set_menu_bar_lines_1): Remove code handling
2307 orig_top_line and orig_total_lines.
2308
2309 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2310 set_window_height but set heights directly.
2311 (change_frame_size_1): Use resize_frame_windows.
2312
2313 * xdisp.c (init_xdisp): Don't use set_window_height but set
2314 heights directly.
2315
2316 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2317 resize_frame_windows instead of change_window_heights and run
2318 run_window_configuration_change_hook.
2319
2320 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2321 instead of change_window_heights and run
2322 run_window_configuration_change_hook.
2323
2324 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2325
2326 * window.c (replace_window): Rename second argument REPLACEMENT to
2327 NEW. New third argument SETFLAG. Rewrite.
2328 (delete_window, make_dummy_parent): Call replace_window with
2329 third argument 1.
2330 (window_list_1): Move down in code.
2331 (run_window_configuration_change_hook): Move set_buffer part
2332 before select_frame_norecord part in order to unwind correctly.
2333 Rename count1 to count.
2334 (recombine_windows, delete_deletable_window, resize_root_window)
2335 (Fdelete_other_windows_internal)
2336 (Frun_window_configuration_change_hook, make_parent_window)
2337 (resize_window_check, resize_window_apply, Fresize_window_apply)
2338 (resize_frame_windows, Fsplit_window_internal)
2339 (Fdelete_window_internal, Fresize_mini_window_internal): New
2340 functions.
2341 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2342
2343 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2344
2345 * window.h (window): Add some new members to window structure -
2346 normal_lines, normal_cols, new_total, new_normal, clone_number,
2347 splits, nest, prev_buffers, next_buffers.
2348 (WINDOW_TOTAL_SIZE): Move here from window.c.
2349 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2350
2351 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2352 Remove.
2353 (make_dummy_parent): Set new members of windows structure.
2354 (make_window): Move down in code. Handle new members of window
2355 structure.
2356 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2357 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2358 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2359 (Fset_window_prev_buffers, Fwindow_next_buffers)
2360 (Fset_window_next_buffers, Fset_window_clone_number): New
2361 functions.
2362 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2363 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2364 Doc-string fixes.
2365 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2366 Argument WINDOW can be now internal window too.
2367 (Fwindow_use_time): Move up in code.
2368 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2369 Rewrite doc-string.
2370 (Fset_window_configuration, saved_window)
2371 (Fcurrent_window_configuration, save_window_save): Handle new
2372 members of window structure.
2373 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2374 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2375 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2376 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2377 Qget_mru_window, Qresize_root_window,
2378 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2379 Qauto_buffer_name; staticpro them.
2380
2381 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2382
2383 * window.c (Fwindow_total_size, Fwindow_left_column)
2384 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2385 (Fwindow_list_1): New functions.
2386 (window_box_text_cols): Replace with window_body_cols.
2387 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2388 window_body_cols instead of window_box_text_cols.
2389 (delete_window, Fset_window_configuration): Call
2390 delete_all_subwindows with window as argument.
2391 (delete_all_subwindows): Take a window as argument and not a
2392 structure. Rewrite.
2393 (window_loop): Remove handling of GET_LRU_WINDOW and
2394 GET_LARGEST_WINDOW.
2395 (Fget_lru_window, Fget_largest_window): Move to window.el.
2396
2397 * window.h: Extern window_body_cols instead of
2398 window_box_text_cols. delete_all_subwindows now takes a
2399 Lisp_Object as argument.
2400
2401 * indent.c (compute_motion, Fcompute_motion): Use
2402 window_body_cols instead of window_box_text_cols.
2403
2404 * frame.c (delete_frame): Call delete_all_subwindows with root
2405 window as argument.
2406
2407 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2408
2409 * fns.c (Fputhash): Document return value.
2410
2411 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2412
2413 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2414
2415 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2416
2417 Cons<->int and similar integer overflow fixes (Bug#8794).
2418
2419 Check for overflow when converting integer to cons and back.
2420 * charset.c (Fdefine_charset_internal, Fdecode_char):
2421 Use cons_to_unsigned to catch overflow.
2422 (Fencode_char): Use INTEGER_TO_CONS.
2423 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2424 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2425 * data.c (long_to_cons, cons_to_long): Remove.
2426 (cons_to_unsigned, cons_to_signed): New functions.
2427 These signal an error for invalid or out-of-range values.
2428 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2429 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2430 * font.c (Ffont_variation_glyphs):
2431 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2432 * lisp.h: Include <intprops.h>.
2433 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2434 (cons_to_signed, cons_to_unsigned): New decls.
2435 (long_to_cons, cons_to_long): Remove decls.
2436 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2437 (Fprimitive_undo): Use CONS_TO_INTEGER.
2438 * xfns.c (Fx_window_property): Likewise.
2439 * xselect.c: Include <limits.h>.
2440 (x_own_selection, selection_data_to_lisp_data):
2441 Use INTEGER_TO_CONS.
2442 (x_handle_selection_request, x_handle_selection_clear)
2443 (x_get_foreign_selection, Fx_disown_selection_internal)
2444 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2445 (lisp_data_to_selection_data): Use cons_to_unsigned.
2446 (x_fill_property_data): Use cons_to_signed.
2447 Report values out of range.
2448
2449 Check for buffer and string overflow more precisely.
2450 * buffer.h (BUF_BYTES_MAX): New macro.
2451 * lisp.h (STRING_BYTES_MAX): New macro.
2452 * alloc.c (Fmake_string):
2453 * character.c (string_escape_byte8):
2454 * coding.c (coding_alloc_by_realloc):
2455 * doprnt.c (doprnt):
2456 * editfns.c (Fformat):
2457 * eval.c (verror):
2458 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2459 since they may not be the same number.
2460 * editfns.c (Finsert_char):
2461 * fileio.c (Finsert_file_contents):
2462 Likewise for BUF_BYTES_MAX.
2463
2464 * image.c: Use ptrdiff_t, not int, for sizes.
2465 (slurp_file): Switch from int to ptrdiff_t.
2466 All uses changed.
2467 (slurp_file): Check that file size fits in both size_t (for
2468 malloc) and ptrdiff_t (for sanity and safety).
2469
2470 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2471 if b->modtime has its maximal value.
2472
2473 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2474
2475 Don't assume time_t can fit into int.
2476 * buffer.h (struct buffer.modtime): Now time_t, not int.
2477 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2478 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2479
2480 Minor fixes for signed vs unsigned integers.
2481 * character.h (MAYBE_UNIFY_CHAR):
2482 * charset.c (maybe_unify_char):
2483 * keyboard.c (read_char, reorder_modifiers):
2484 XINT -> XFASTINT, since the integer must be nonnegative.
2485 * ftfont.c (ftfont_spec_pattern):
2486 * keymap.c (access_keymap, silly_event_symbol_error):
2487 XUINT -> XFASTINT, since the integer must be nonnegative.
2488 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2489 since it makes no difference and we prefer signed.
2490 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2491 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2492 nonnegative.
2493
2494 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2495
2496 * window.h (Fwindow_frame): Declare.
2497
2498 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2499
2500 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2501 (SPARE_MEMORY): Always define.
2502 (LARGE_REQUEST): Remove.
2503 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2504
2505 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2506
2507 * lisp.h: Move EXFUNS for Fframe_root_window,
2508 Fframe_first_window and Fset_frame_selected_window to window.h.
2509
2510 * window.h: Move EXFUNS for Fframe_root_window,
2511 Fframe_first_window and Fset_frame_selected_window here from
2512 lisp.h.
2513
2514 * frame.c (Fwindow_frame, Fframe_first_window)
2515 (Fframe_root_window, Fframe_selected_window)
2516 (Fset_frame_selected_window): Move to window.c.
2517 (Factive_minibuffer_window): Move to minibuf.c.
2518 (Fother_visible_frames_p): New function.
2519
2520 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2521
2522 * window.c (decode_window, decode_any_window): Move up in code.
2523 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2524 (inhibit_frame_unsplittable): Remove unused variable.
2525 (Fwindow_buffer): Move up and rewrite doc-string.
2526 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2527 (Fwindow_prev): New functions.
2528 (Fwindow_frame): Move here from frame.c. Accept any window as
2529 argument.
2530 (Fframe_root_window, Fframe_first_window)
2531 (Fframe_selected_window): Move here from frame.c. Accept frame
2532 or arbitrary window as argument. Update doc-strings.
2533 (Fminibuffer_window): Move up in code.
2534 (Fwindow_minibuffer_p): Move up in code and simplify.
2535 (Fset_frame_selected_window): Move here from frame.c.
2536 Marginal rewrite.
2537 (Fselected_window, select_window, Fselect_window): Move up in
2538 code. Minor doc-string fixes.
2539
2540 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2541
2542 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2543 Do not assume that spare memory exists; that assumption is valid
2544 only if SYSTEM_MALLOC.
2545 (LARGE_REQUEST): New macro, so that the issue of large requests
2546 is separated from the issue of spare memory.
2547
2548 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2549
2550 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2551 format. (Bug#8806)
2552
2553 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2554
2555 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2556 before statements.
2557
2558 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2559
2560 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2561
2562 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2563
2564 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2565 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2566
2567 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2568
2569 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2570
2571 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2572
2573 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2574 (x_clipboard_manager_save): Add return value.
2575 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2576 New error handlers.
2577 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2578 Obey Vx_select_enable_clipboard_manager. Catch errors in
2579 x_clipboard_manager_save (Bug#8779).
2580 (Vx_select_enable_clipboard_manager): New variable.
2581 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2582
2583 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2584
2585 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2586
2587 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2588
2589 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2590 in the current matrix if keep_current_p is non-zero.
2591
2592 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2593
2594 * bidi.c (bidi_level_of_next_char): Fix last change.
2595
2596 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2597
2598 Support bidi reordering of text covered by display properties.
2599
2600 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2601 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2602 (bidi_cache_search, bidi_cache_iterator_state)
2603 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2604 (bidi_level_of_next_char, bidi_move_to_visually_next):
2605 Support character positions inside a run of characters covered by a
2606 display string.
2607 (bidi_paragraph_init, bidi_resolve_explicit_1)
2608 (bidi_level_of_next_char): Call bidi_fetch_char and
2609 bidi_fetch_char_advance instead of FETCH_CHAR and
2610 FETCH_CHAR_ADVANCE.
2611 (bidi_init_it): Initialize new members.
2612 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2613 definitions.
2614 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2615 instead of using explicit *_CHAR codes.
2616 (bidi_resolve_explicit, bidi_resolve_weak):
2617 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2618 bidirectional text is supported only in multibyte buffers.
2619 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2620 it to initialize the frame_window_p member of struct bidi_it.
2621 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2622 (bidi_resolve_explicit, bidi_resolve_weak)
2623 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2624 bidi_it->nchars is non-positive.
2625 (bidi_level_of_next_char): Don't try to lookup the cache for the
2626 next/previous character if nothing is cached there yet, or if we
2627 were just reseat()'ed to a new position.
2628
2629 * xdisp.c (set_cursor_from_row): Set start and stop points
2630 according to the row's direction when priming the loop that looks
2631 for the glyph on which to display cursor.
2632 (single_display_spec_intangible_p): Function deleted.
2633 (display_prop_intangible_p): Reimplement to call
2634 handle_display_spec instead of single_display_spec_intangible_p.
2635 Accept 3 additional arguments needed by handle_display_spec.
2636 This fixes incorrect cursor motion across display property with complex
2637 values: lists, `(when COND...)' forms, etc.
2638 (single_display_spec_string_p): Support property values that are
2639 lists with the argument STRING its top-level element.
2640 (display_prop_string_p): Fix the condition for processing a
2641 property that is a list to be consistent with handle_display_spec.
2642 (handle_display_spec): New function, refactored from the
2643 last portion of handle_display_prop.
2644 (compute_display_string_pos): Accept additional argument
2645 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2646 value of a `display' property is a "replacing spec".
2647 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2648 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2649 the display property, but just return a value indicating whether
2650 the display property will replace the characters it covers.
2651 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2652 frame_window_p members of struct bidi_it.
2653 (compute_display_string_pos, compute_display_string_end):
2654 New functions.
2655 (push_it): Accept second argument POSITION, where pop_it should
2656 jump to continue iteration.
2657 (reseat_1): Initialize bidi_it.disp_pos.
2658
2659 * keyboard.c (adjust_point_for_property): Adjust the call to
2660 display_prop_intangible_p to its new signature.
2661
2662 * dispextern.h (struct bidi_it): New member frame_window_p.
2663 (bidi_init_it): Update prototypes.
2664 (display_prop_intangible_p): Update prototype.
2665 (compute_display_string_pos, compute_display_string_end):
2666 Declare prototypes.
2667 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2668 EMACS_INT.
2669
2670 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2671
2672 Malloc failure behavior now depends on size of allocation.
2673 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2674 * lisp.h: Change signatures accordingly.
2675 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2676 All callers changed. (Bug#8762)
2677
2678 * gnutls.c: Use Emacs's memory allocators.
2679 Without this change, the gnutls library would invoke malloc etc.
2680 directly, which causes problems on non-SYNC_INPUT hosts, and which
2681 runs afoul of improving memory_full behavior. (Bug#8761)
2682 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2683 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2684 xfree instead of the default malloc, realloc, free.
2685 (Fgnutls_boot): No need to check for memory allocation failure,
2686 since xmalloc does that for us.
2687
2688 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2689 * category.c (hash_get_category_set):
2690 * ccl.c (ccl_driver):
2691 * charset.c (Fdefine_charset_internal):
2692 * charset.h (struct charset.hash_index):
2693 * composite.c (get_composition_id, gstring_lookup_cache)
2694 (composition_gstring_put_cache):
2695 * composite.h (struct composition.hash_index):
2696 * dispextern.h (struct image.hash):
2697 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2698 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2699 (hashfn_equal, hashfn_user_defined, make_hash_table)
2700 (maybe_resize_hash_table, hash_lookup, hash_put)
2701 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2702 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2703 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2704 * image.c (make_image, search_image_cache, lookup_image)
2705 (xpm_put_color_table_h):
2706 * lisp.h (struct Lisp_Hash_Table):
2707 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2708 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2709 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2710 * alloc.c (allocate_vectorlike):
2711 Check for overflow in vector size calculations.
2712 * ccl.c (ccl_driver):
2713 Check for overflow when converting EMACS_INT to int.
2714 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2715 need to be updated by these changes.
2716 * fns.c (make_hash_table, maybe_resize_hash_table):
2717 Check for integer overflow with large hash tables.
2718 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2719 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2720 (SXHASH_REDUCE): New macro.
2721 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2722 Use it instead of discarding useful hash info with large hash values.
2723 (sxhash_float): New function.
2724 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2725 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2726 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2727 Rewrite to use FIXNUM_BITS, as this simplifies things.
2728 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2729 Adjust signatures to match updated version of code.
2730 (consing_since_gc): Now EMACS_INT, since a single hash table can
2731 use more than INT_MAX bytes.
2732
2733 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2734
2735 Make it possible to build with GCC-4.6+ -O2 -flto.
2736
2737 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2738
2739 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2740
2741 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2742 Call minibuffer-inactive-mode.
2743
2744 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2745
2746 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2747 Update dependencies.
2748
2749 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2750
2751 * data.c (init_data): Remove code for UTS, this system is not
2752 supported anymore.
2753
2754 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2755
2756 Don't force ./temacs to start in terminal mode.
2757
2758 * frame.c (make_initial_frame): Initialize faces in all cases, not
2759 only when CANNOT_DUMP is defined.
2760 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2761
2762 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2763
2764 * dispnew.c (add_window_display_history): Use const for the string
2765 pointer. Remove declaration, not needed.
2766
2767 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2768
2769 Use 'inline', not 'INLINE'.
2770 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2771 * alloc.c, fontset.c (INLINE): Remove.
2772 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2773 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2774 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2775 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2776 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2777
2778 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2779
2780 Make it possible to run ./temacs.
2781
2782 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2783 syms_of_callproc does the same thing. Remove test for
2784 "initialized", do it in the caller.
2785 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2786
2787 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2788
2789 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2790 (read_minibuf): Use get_minibuffer.
2791 (syms_of_minibuf): Use DEFSYM.
2792 (Qmetadata): New var.
2793 * data.c (Qbuffer): Don't make it static.
2794 (syms_of_data): Use DEFSYM.
2795
2796 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2797
2798 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2799 (CCL_CODE_MIN): New macro.
2800
2801 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2802
2803 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2804
2805 * eval.c (Qdebug): Now static.
2806 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2807 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2808 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2809
2810 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2811
2812 * image.c: Various fixes to ImageMagick code comments.
2813 (Fimagemagick_types): Doc fix.
2814
2815 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2816
2817 Minor fixes prompted by GCC 4.6.0 warnings.
2818
2819 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2820
2821 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2822 (x_clipboard_manager_save_all): Move extern decl to ...
2823 * xterm.h: ... here, so that it can be checked for consistency.
2824
2825 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2826
2827 * xselect.c (x_clipboard_manager_save_frame)
2828 (x_clipboard_manager_save_all): New functions.
2829 (Fx_clipboard_manager_save): Lisp function deleted.
2830
2831 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2832 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2833
2834 * xterm.h: Update prototype.
2835
2836 2011-05-28 William Xu <william.xwl@gmail.com>
2837
2838 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2839 exiting (Bug#8239).
2840
2841 2011-05-28 Jim Meyering <meyering@redhat.com>
2842
2843 Avoid a sign-extension bug in crypto_hash_function.
2844 * fns.c (to_uchar): Define.
2845 (crypto_hash_function): Use it to convert some newly-signed
2846 variables to unsigned, to avoid sign-extension bugs. For example,
2847 without this change, (md5 "truc") would evaluate to
2848 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2849 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2850 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2851
2852 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2853
2854 Integer overflow fixes.
2855
2856 * dbusbind.c: Serial number integer overflow fixes.
2857 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2858 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2859 to hold a serial number that is too large for a fixnum.
2860 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2861 Check for serial numbers out of range. Decode any serial number
2862 that was so large that it became a float. (Bug#8722)
2863
2864 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2865 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2866 Use XFASTINT rather than XUINT when numbers are nonnegative.
2867 (xd_append_arg, Fdbus_method_return_internal):
2868 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2869 arguments, check that Lisp number is nonnegative, rather than
2870 silently wrapping negative numbers around. (Bug#8722)
2871 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2872 (Bug#8722)
2873
2874 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2875
2876 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2877
2878 ccl: add integer overflow checks
2879 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2880 (IN_INT_RANGE): New macros.
2881 (ccl_driver): Use them to check for integer overflow when
2882 decoding a CCL program. Many of the new checks are whether XINT (x)
2883 fits in int; it doesn't always, on 64-bit hosts. The new version
2884 doesn't catch all possible integer overflows, but it's an
2885 improvement. (Bug#8719)
2886
2887 * alloc.c (make_event_array): Use XINT, not XUINT.
2888 There's no need for unsigned here.
2889
2890 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2891 This follows up to the 2011-05-06 change that substituted uintptr_t
2892 for EMACS_INT. This case wasn't caught back then.
2893
2894 Rework Fformat to avoid integer overflow issues.
2895 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2896 now (part of C89). Include <verify.h>.
2897 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2898 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2899 (Fformat): Avoid the prepass trying to compute sizes; it was only
2900 approximate and thus did not catch overflow reliably. Instead, walk
2901 through the format just once, formatting and computing sizes as we go,
2902 checking for integer overflow at every step, and allocating a larger
2903 buffer as needed. Keep track separately whether the format is
2904 multibyte. Keep only the most-recently calculated precision, rather
2905 than them all. Record whether each argument has been converted to
2906 string. Use EMACS_INT, not int, for byte and char and arg counts.
2907 Support field widths and precisions larger than INT_MAX. Avoid
2908 sprintf's undefined behavior with conversion specifications such as %#d
2909 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2910 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2911 formatting out-of-range floating point numbers with int
2912 formats. (Bug#8668)
2913
2914 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2915
2916 * data.c: Avoid integer truncation in expressions involving floats.
2917 * data.c: Include <intprops.h>.
2918 (arith_driver): When there's an integer overflow in an expression
2919 involving floating point, convert the integers to floating point
2920 so that the resulting value does not suffer from catastrophic
2921 integer truncation. For example, on a 64-bit host (* 4
2922 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2923 Do not rely on undefined behavior after integer overflow.
2924
2925 merge count_size_as_multibyte, parse_str_to_multibyte
2926 * character.c, character.h (count_size_as_multibyte):
2927 Rename from parse_str_to_multibyte; all uses changed.
2928 Check for integer overflow.
2929 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2930 since it's now a duplicate of the other. This is more of
2931 a character than a buffer op, so better that it's in character.c.
2932 * fns.c, print.c: Adjust to above changes.
2933
2934 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2935
2936 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2937
2938 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2939
2940 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2941 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2942 (x_clipboard_manager_save): Now static.
2943 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2944
2945 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2946 (crypto_hash_function): Now static.
2947 Fix pointer signedness problems. Avoid unnecessary initializations.
2948
2949 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2950
2951 * termhooks.h (Vselection_alist): Make it terminal-local.
2952
2953 * terminal.c (create_terminal): Initialize it.
2954
2955 * xselect.c: Support for clipboard managers.
2956 (Vselection_alist): Move to termhooks.h as terminal-local var.
2957 (LOCAL_SELECTION): New macro.
2958 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2959 (symbol_to_x_atom): Remove gratuitous arg.
2960 (x_handle_selection_request, lisp_data_to_selection_data)
2961 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2962 (x_own_selection, x_get_local_selection, x_convert_selection):
2963 New arg, specifying work frame. Use terminal-local Vselection_alist.
2964 (some_frame_on_display): Delete unused function.
2965 (Fx_own_selection_internal, Fx_get_selection_internal)
2966 (Fx_disown_selection_internal, Fx_selection_owner_p)
2967 (Fx_selection_exists_p): New optional frame arg.
2968 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2969 (x_handle_selection_clear): Don't treat other terminals with the
2970 same keyboard specially. Use the terminal-local Vselection_alist.
2971 (x_clear_frame_selections): Use Frun_hook_with_args.
2972
2973 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2974
2975 * xterm.h: Add support for those atoms.
2976
2977 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2978
2979 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2980 (converted_selections, conversion_fail_tag): New global variables.
2981 (x_selection_request_lisp_error): Free the above.
2982 (x_get_local_selection): Remove unnecessary code.
2983 (x_reply_selection_request): Args changed; handle arbitrary array
2984 of converted selections stored in converted_selections.
2985 Separate the XChangeProperty and SelectionNotify steps.
2986 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2987 (x_convert_selection): New function.
2988 (x_handle_selection_event): Simplify.
2989 (x_get_foreign_selection): Don't ignore incoming requests while
2990 waiting for an answer; this will fail when we implement
2991 SAVE_TARGETS, and seems unnecessary anyway.
2992 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2993 (Vx_sent_selection_functions): Doc fix.
2994
2995 2011-05-26 Leo Liu <sdl.web@gmail.com>
2996
2997 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2998
2999 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3000
3001 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3002
3003 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3004 for fringe update if it has periodic bitmap.
3005 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3006 and fringe_bitmap_periodic_p.
3007
3008 * fringe.c (get_fringe_bitmap_data): New function.
3009 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3010 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3011 row. Mark glyph row for fringe update if periodicity changed.
3012
3013 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3014 for fringe update unless it has periodic bitmap.
3015
3016 2011-05-25 Kenichi Handa <handa@m17n.org>
3017
3018 * xdisp.c (get_next_display_element): Set correct it->face_id for
3019 a static composition.
3020
3021 2011-05-24 Leo Liu <sdl.web@gmail.com>
3022
3023 * deps.mk (fns.o):
3024 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3025
3026 * fns.c (crypto_hash_function, Fsha1): New function.
3027 (Fmd5): Use crypto_hash_function.
3028 (syms_of_fns): Add Ssha1.
3029
3030 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3031
3032 * gnutls.c: Remove unused macros.
3033 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3034 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3035 Remove macros that are defined and never used.
3036 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3037
3038 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3039
3040 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3041 (Fx_get_selection_internal): Minor cleanup.
3042 (Fx_own_selection_internal): Rename arguments for consistency with
3043 select.el.
3044
3045 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3046
3047 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3048
3049 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3050
3051 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3052
3053 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3054
3055 * dispnew.c (scrolling_window): Don't exclude the case that the
3056 last enabled row in the desired matrix touches the bottom boundary.
3057
3058 2011-05-21 Glenn Morris <rgm@gnu.org>
3059
3060 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3061 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3062 and add some more files.
3063
3064 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3065
3066 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3067 report_file_error introduced by the change from 2011-05-07.
3068
3069 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3070
3071 * systime.h (Time): Define only if emacs is defined.
3072 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3073 where the include path doesn't have X11/X.h by default. See
3074 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3075
3076 2011-05-20 Kenichi Handa <handa@m17n.org>
3077
3078 * composite.c (find_automatic_composition): Fix previous change.
3079
3080 2011-05-20 Glenn Morris <rgm@gnu.org>
3081
3082 * lisp.mk: New file, split from Makefile.in.
3083 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3084 (shortlisp): Remove.
3085 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3086
3087 2011-05-19 Glenn Morris <rgm@gnu.org>
3088
3089 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3090 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3091 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3092 (lisp): Set the order to that of loadup.el.
3093 (shortlisp): Make it a copy of $lisp.
3094 (SOME_MACHINE_LISP): Remove.
3095 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3096 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3097
3098 2011-05-18 Kenichi Handa <handa@m17n.org>
3099
3100 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3101 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3102 (find_automatic_composition): Mostly rewrite for efficiency.
3103
3104 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3105
3106 * makefile.w32-in: Update dependencies.
3107
3108 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3109
3110 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3111 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3112
3113 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3114
3115 Fix some integer overflow issues, such as string length overflow.
3116
3117 * insdel.c (count_size_as_multibyte): Check for string overflow.
3118
3119 * character.c (lisp_string_width): Check for string overflow.
3120 Use EMACS_INT, not int, for string indexes and lengths; in
3121 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3122 the resulting string length overflows an EMACS_INT; instead,
3123 report a string overflow if no precision given. When checking for
3124 precision exhaustion, use a check that cannot possibly have
3125 integer overflow. (Bug#8675)
3126 * character.h (lisp_string_width): Adjust to new signature.
3127
3128 * alloc.c (string_overflow): New function.
3129 (Fmake_string): Use it. This doesn't change behavior, but saves
3130 a few bytes and will simplify future changes.
3131 * character.c (string_escape_byte8): Likewise.
3132 * lisp.h (string_overflow): New decl.
3133
3134 Fixups, following up to the user-interface timestamp change.
3135 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3136 for UI timestamps, instead of unsigned long.
3137 * msdos.c (mouse_get_pos): Likewise.
3138 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3139 * w32gui.h (Time): Define by including "systime.h" rather than by
3140 declaring it ourselves. (Bug#8664)
3141
3142 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3143 * image.c (clear_image_cache): Likewise.
3144
3145 * term.c (term_mouse_position): Don't assume time_t wraparound.
3146
3147 Be more systematic about user-interface timestamps.
3148 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3149 and sometimes 'EMACS_UINT', to represent these timestamps.
3150 This change causes it to use 'Time' uniformly, as that's what X uses.
3151 This makes the code easier to follow, and makes it easier to catch
3152 integer overflow bugs such as Bug#8664.
3153 * frame.c (Fmouse_position, Fmouse_pixel_position):
3154 Use Time, not unsigned long, for user-interface timestamps.
3155 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3156 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3157 * keyboard.h (last_event_timestamp): Likewise.
3158 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3159 * menu.h (xmenu_show): Likewise.
3160 * term.c (term_mouse_position): Likewise.
3161 * termhooks.h (struct input_event.timestamp): Likewise.
3162 (struct terminal.mouse_position_hook): Likewise.
3163 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3164 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3165 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3166 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3167 what it was before.
3168 * menu.h, termhooks.h: Include "systime.h", for Time.
3169
3170 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3171 Don't assume that the difference between two unsigned long values
3172 can fit into an integer. At this point, we know button_down_time
3173 <= event->timestamp, so the difference must be nonnegative, so
3174 there's no need to cast the result if double-click-time is
3175 nonnegative, as it should be; check that it's nonnegative, just in
3176 case. This bug is triggered when events are more than 2**31 ms
3177 apart (about 25 days). (Bug#8664)
3178
3179 * xselect.c (last_event_timestamp): Remove duplicate decl.
3180 (x_own_selection): Remove needless cast to unsigned long.
3181
3182 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3183 that always fit in int. Use a sentinel instead of a counter, to
3184 avoid a temp and to allay GCC's concerns about possible int overflow.
3185 * frame.h (struct frame): Use int for menu_bar_items_used
3186 instead of EMACS_INT, since it always fits in int.
3187
3188 * menu.c (grow_menu_items): Check for int overflow.
3189
3190 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3191
3192 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3193 Before, the code was not consistent. These values cannot exceed
3194 2**31 - 1 so there's no need to make them unsigned.
3195 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3196 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3197 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3198 as modifiers.
3199 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3200
3201 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3202 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3203 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3204 presumably because the widths might not match.
3205
3206 * window.c (size_window): Avoid needless test at loop start.
3207
3208 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3209
3210 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3211
3212 2011-05-12 Drew Adams <drew.adams@oracle.com>
3213
3214 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3215
3216 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3217
3218 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3219 `width' to `bar_area_x' and `bar_area_width', respectively.
3220 (x_scroll_run): Take account of fringe background extension.
3221
3222 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3223 Rename local vars `left' and `width' to `bar_area_x' and
3224 `bar_area_width', respectively.
3225 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3226 background extension.
3227
3228 2011-05-10 Jim Meyering <meyering@redhat.com>
3229
3230 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3231
3232 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3233
3234 * image.c (Finit_image_library): Return t for built-in image types,
3235 like pbm and xbm. (Bug#8640)
3236
3237 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3238
3239 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3240
3241 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3242
3243 * w32console.c (Fset_screen_color): Doc fix.
3244 (Fget_screen_color): New function.
3245 (syms_of_ntterm): Defsubr it.
3246
3247 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3248 unlink the temporary file if Fcall_process didn't create it in the
3249 first place.
3250 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3251 child process will be redirected to a file specified with `:file'.
3252 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3253 cue to call_process_cleanup not to close that handle.
3254
3255 2011-05-07 Ben Key <bkey76@gmail.com>
3256
3257 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3258 one of two shell specific rules, either bootstrap-temacs-CMD or
3259 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3260 to the previous implementation of the bootstrap-temacs rule.
3261 The bootstrap-temacs-CMD rule is similar to the previous
3262 implementation of the bootstrap-temacs rule except that it
3263 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3264 variable.
3265
3266 These changes, along with some changes to nt/configure.bat,
3267 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3268 earlier fix to add support for --cflags and --ldflags options
3269 that include quotes so that it works whether make uses cmd or
3270 sh as the shell.
3271
3272 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3273
3274 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3275 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3276 is a constant.
3277 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3278 a string. Handle both cases.
3279 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3280 (Fdbus_register_method): Use Qinvalid_function.
3281
3282 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3283
3284 * makefile.w32-in: Update dependencies.
3285 (LISP_H): Add inttypes.h and stdin.h.
3286 (PROCESS_H): Add unistd.h.
3287
3288 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3289
3290 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3291 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3292
3293 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3294
3295 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3296
3297 * term.c (vfatal): Remove stray call to va_end.
3298 It's not needed and the C Standard doesn't allow it here anyway.
3299
3300 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3301 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3302
3303 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3304 bytes.
3305
3306 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3307
3308 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3309
3310 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3311
3312 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3313
3314 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3315
3316 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3317 * charset.c (Fdefine_charset_internal): Don't initialize
3318 charset.code_space[15]. The value was garbage, on hosts with
3319 32-bit int (Bug#8600).
3320
3321 * lread.c (read_integer): Be more consistent with string-to-number.
3322 Use string_to_number to do the actual conversion; this avoids
3323 rounding errors and fixes some other screwups. Without this fix,
3324 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3325 (digit_to_number): Move earlier, for benefit of read_integer.
3326 Return -1 if the digit is out of range for the base, -2 if it is
3327 not a digit in any supported base. (Bug#8602)
3328
3329 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3330
3331 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3332 to match comment at start of function. This also removes a
3333 GCC warning about overflow in a 32+64-bit port.
3334
3335 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3336
3337 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3338 Reported by Stefan Monnier in
3339 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3340 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3341 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3342
3343 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3344 (EMACS_UINTPTR): Likewise, with uintptr_t.
3345
3346 * lisp.h: Prefer 64-bit EMACS_INT if available.
3347 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3348 on 32-bit hosts that have 64-bit int, so that they can access
3349 large files.
3350 However, temporarily disable this change unless the temporary
3351 symbol WIDE_EMACS_INT is defined.
3352
3353 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3354
3355 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3356 This removes an assumption that EMACS_INT and long are the same
3357 width as pointers. The assumption is true for Emacs porting targets
3358 now, but we want to make other targets possible.
3359 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3360 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3361 In the rest of the code, change types of integers that hold casted
3362 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3363 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3364 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3365 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3366 No need to cast type when ORing.
3367 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3368 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3369 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3370 assume EMACS_INT is the same width as char *.
3371 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3372 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3373 Remove no-longer-needed casts.
3374 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3375 (xg_tool_bar_help_callback, xg_make_tool_item):
3376 Use EMACS_INTPTR to hold an integer
3377 that will be cast to void *; this can avoid a GCC warning
3378 if EMACS_INT is not the same width as void *.
3379 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3380 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3381 (current_message_1, set_message_1):
3382 Use a local to convert to proper width without a cast.
3383 * xmenu.c (dialog_selection_callback): Likewise.
3384
3385 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3386 Also, don't assume VALBITS / RAND_BITS is less than 5,
3387 and don't rely on undefined behavior when shifting a 1 left into
3388 the sign bit.
3389 * lisp.h (get_random): Change signature to match.
3390
3391 * lread.c (hash_string): Use size_t, not int, for hash computation.
3392 Normally we prefer signed values; but hashing is special, because
3393 it's better to use unsigned division on hash table sizes so that
3394 the remainder is nonnegative. Also, size_t is the natural width
3395 for hashing into memory. The previous code used 'int', which doesn't
3396 retain enough info to hash well into very large tables.
3397 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3398
3399 * dbusbind.c: Don't possibly lose pointer info when converting.
3400 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3401 Use XPNTR rather than XHASH, so that the high-order bits of
3402 the pointer aren't lost when converting through void *.
3403
3404 * eval.c (Fautoload): Don't double-shift a pointer.
3405
3406 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3407
3408 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3409
3410 * gnutls.c (DEF_GNUTLS_FN):
3411 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3412
3413 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3414
3415 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3416 marker. (Bug#8610)
3417
3418 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3419
3420 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3421 New version that can reserve upto 2GB of heap space.
3422
3423 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3424
3425 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3426
3427 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3428
3429 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3430 `gnutls_certificate_set_x509_key_file'.
3431
3432 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3433
3434 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3435 Update dependencies.
3436
3437 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3438
3439 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3440 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3441 Remove unused parameter `fildes'.
3442 * process.c (read_process_output, send_process): Don't pass it.
3443
3444 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3445
3446 Fix previous change: the library cache is defined in w32.c.
3447 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3448 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3449
3450 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3451
3452 Implement dynamic loading of GnuTLS on Windows.
3453
3454 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3455 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3456 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3457 Declare.
3458
3459 * gnutls.c (Qgnutls_dll): Define.
3460 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3461 (gnutls_*): Declare function pointers.
3462 (init_gnutls_functions): New function to initialize function pointers.
3463 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3464 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3465 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3466 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3467 (emacs_gnutls_write, emacs_gnutls_read)
3468 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3469 (Fgnutls_available_p): New function.
3470 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3471 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3472 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3473
3474 * image.c: Include w32.h.
3475 (Vimage_type_cache): Delete.
3476 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3477 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3478 (w32_delayed_load): Move to w32.c.
3479
3480 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3481
3482 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3483 (w32_delayed_load): Move from image.c. When loading a library, record
3484 its filename in the :loaded-from property of the library id.
3485 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3486 Initialize and staticpro them.
3487 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3488
3489 * process.c: Include lisp.h before w32.h, not after.
3490 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3491 instead of gnutls_record_check_pending.
3492
3493 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3494
3495 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3496
3497 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3498 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3499 as passed in.
3500
3501 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3502
3503 * xterm.c (x_set_frame_alpha): Do not set property on anything
3504 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3505
3506 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3507
3508 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3509
3510 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3511
3512 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3513 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3514 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3515 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3516 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3517 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3518 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3519 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3520 (Qgnutls_bootprop_callbacks_verify): Make static.
3521
3522 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3523
3524 * callproc.c: Indentation fixup.
3525
3526 * sysdep.c (wait_for_termination_1): Make static.
3527 (wait_for_termination, interruptible_wait_for_termination):
3528 Move after wait_for_termination_1.
3529
3530 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3531
3532 * sysdep.c (interruptible_wait_for_termination): New function
3533 which is like wait_for_termination, but allows keyboard
3534 interruptions.
3535
3536 * callproc.c (Fcall_process): Add (:file "file") as an option for
3537 the STDOUT buffer.
3538 (Fcall_process_region): Ditto.
3539
3540 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3541
3542 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3543 rather than `XVECTOR (FOO)->size'.
3544
3545 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3546 inttypes.h, as a gnulib replacement is used if it not available in
3547 system headers.
3548
3549 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3550
3551 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3552 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3553 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3554
3555 * coding.c (coding_alloc_by_realloc): Error out if destination
3556 will grow beyond MOST_POSITIVE_FIXNUM.
3557 (decode_coding_emacs_mule): Abort if there isn't enough place in
3558 charbuf for the composition carryover bytes. Reserve an extra
3559 space for up to 2 characters produced in a loop.
3560 (decode_coding_iso_2022): Abort if there isn't enough place in
3561 charbuf for the composition carryover bytes.
3562
3563 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3564
3565 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3566 aborting when %lld or %lll format is passed.
3567 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3568 %llo or %llx format is passed. (Bug#8545)
3569
3570 * window.c (window_scroll_line_based): Use a marker instead of
3571 simple variables to record original value of point. (Bug#7952)
3572
3573 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3574 produced by %s or %c overflows available buffer space. (Bug#8545)
3575
3576 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3577
3578 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3579 (SIZE_MAX): Move defn after all includes, as they might #define it.
3580
3581 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3582
3583 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3584
3585 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3586
3587 * keyboard.c (Qdelayed_warnings_hook): Define.
3588 (command_loop_1): Run `delayed-warnings-hook'
3589 if Vdelayed_warnings_list is non-nil.
3590 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3591 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3592
3593 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3594
3595 * doprnt.c (doprnt): Don't return value smaller than the buffer
3596 size if the message was truncated. (Bug#8545).
3597
3598 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3599
3600 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3601 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3602
3603 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3604
3605 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3606
3607 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3608
3609 * makefile.w32-in: Update dependencies.
3610
3611 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3612
3613 Improve `doprnt' and its usage. (Bug#8545)
3614 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3615 `format_end'. Remove support for %l as a conversion specifier.
3616 Don't use xrealloc. Improve diagnostics when the %l size modifier
3617 is used. Update the commentary.
3618
3619 * eval.c (verror): Simplify calculation of size_t.
3620
3621 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3622 messages.
3623
3624 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3625
3626 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3627 change.
3628
3629 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3630
3631 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3632 This makes this file independent of the recent pseudovector change.
3633
3634 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3635
3636 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3637
3638 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3639 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3640 Remove unused local.
3641 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3642
3643 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3644 GCC 4.6.0 optimizes based on type-based alias analysis.
3645 For example, if b is of type struct buffer * and v of type struct
3646 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3647 != &v->size, and therefore "v->size = 1; b->size = 2; return
3648 v->size;" must therefore return 1. This assumption is incorrect
3649 for Emacs, since it type-puns struct Lisp_Vector * with many other
3650 types. To fix this problem, this patch adds a new type struct
3651 vectorlike_header that documents the constraints on layout of vectors
3652 and pseudovectors, and helps optimizing compilers not get fooled
3653 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3654 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3655 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3656 the size member.
3657 (XSETPVECTYPE): Rewrite in terms of new macro.
3658 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3659 This is a bit clearer, and further avoids the possibility of
3660 undesirable aliasing.
3661 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3662 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3663 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3664 since Lisp_Subr is a special case (no "next" field).
3665 (ASIZE): Now uses header.size rather than size.
3666 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3667 to avoid the hassle of writing XVECTOR (foo)->header.size.
3668 (struct vectorlike_header): New type.
3669 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3670 object, to help avoid aliasing.
3671 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3672 (SUBRP): Likewise, since Lisp_Subr is a special case.
3673 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3674 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3675 (struct Lisp_Hash_Table): Combine first two members into a single
3676 struct vectorlike_header member. All uses of "size" and "next" members
3677 changed to be "header.size" and "header.next".
3678 * buffer.h (struct buffer): Likewise.
3679 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3680 * frame.h (struct frame): Likewise.
3681 * process.h (struct Lisp_Process): Likewise.
3682 * termhooks.h (struct terminal): Likewise.
3683 * window.c (struct save_window_data, struct saved_window): Likewise.
3684 * window.h (struct window): Likewise.
3685 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3686 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3687 * buffer.c (init_buffer_once): Likewise.
3688 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3689 special case.
3690 * process.c (Fformat_network_address): Use local var for size,
3691 for brevity.
3692
3693 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3694
3695 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3696 * data.c (atof): Remove decl; no longer used or needed.
3697 (digit_to_number): Move to lread.c.
3698 (Fstring_to_number): Use new string_to_number function, to be
3699 consistent with how the Lisp reader treats infinities and NaNs.
3700 Do not assume that floating-point numbers represent EMACS_INT
3701 without losing information; this is not true on most 64-bit hosts.
3702 Avoid double-rounding errors, by insisting on integers when
3703 parsing non-base-10 numbers, as the documentation specifies.
3704 * lisp.h (string_to_number): New decl, replacing ...
3705 (isfloat_string): Remove.
3706 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3707 (read1): Do not accept +. and -. as integers; this
3708 appears to have been a coding error. Similarly, do not accept
3709 strings like +-1e0 as floating point numbers. Do not report
3710 overflow for integer overflows unless the base is not 10 which
3711 means we have no simple and reliable way to continue.
3712 Break out the floating-point parsing into a new
3713 function string_to_number, so that Fstring_to_number parses
3714 floating point numbers consistently with the Lisp reader.
3715 (digit_to_number): Move here from data.c. Make it static inline.
3716 (E_CHAR, EXP_INT): Remove, replacing with ...
3717 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3718 (string_to_number): New function, replacing isfloat_string.
3719 This function checks for valid syntax and produces the resulting
3720 Lisp float number too. Rework it so that string-to-number
3721 no longer mishandles examples like "1.0e+". Use strtoumax,
3722 so that overflow for non-base-10 numbers is reported only when
3723 there's no portable and simple way to convert to floating point.
3724
3725 * textprop.c (set_text_properties_1): Rewrite for clarity,
3726 and to avoid GCC warning about integer overflow.
3727
3728 * intervals.h (struct interval): Use EMACS_INT for members
3729 where EMACS_UINT might cause problems. See
3730 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3731 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3732 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3733 All uses changed.
3734 (offset_intervals): Tell GCC not to worry about length overflow
3735 when negating a negative length.
3736
3737 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3738 (overrun_check_free): Likewise.
3739
3740 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3741 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3742 word size.
3743
3744 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3745 (gnutls_make_error): Rename local to avoid shadowing.
3746 (gnutls_emacs_global_deinit): ifdef out; not used.
3747 (Fgnutls_boot): Use const for pointer to readonly storage.
3748 Comment out unused local. Fix pointer signedness problems.
3749
3750 * lread.c (openp): Don't stuff size_t into an 'int'.
3751 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3752 about possible signed overflow.
3753
3754 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3755 (GDK_KEY_g): Don't define if already defined.
3756 (xg_prepare_tooltip): Avoid pointer signedness problem.
3757 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3758
3759 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3760 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3761
3762 * xfns.c (Fx_window_property): Simplify a bit,
3763 to make a bit faster and to avoid GCC 4.6.0 warning.
3764 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3765
3766 * fns.c (internal_equal): Don't assume size_t fits in int.
3767
3768 * alloc.c (compact_small_strings): Tighten assertion a little.
3769
3770 Replace pEd with more-general pI, and fix some printf arg casts.
3771 * lisp.h (pI): New macro, generalizing old pEd macro to other
3772 conversion specifiers. For example, use "...%"pI"d..." rather
3773 than "...%"pEd"...".
3774 (pEd): Remove. All uses replaced with similar uses of pI.
3775 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3776 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3777 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3778 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3779 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3780 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3781 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3782 64-bit hosts.
3783 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3784 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3785 * print.c (safe_debug_print, print_object): Likewise.
3786 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3787 to int.
3788 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3789 avoiding the 0 flag, which is not portable.
3790 * process.c (Fmake_network_process): Use pI to avoid cast.
3791 * region-cache.c (pp_cache): Likewise.
3792 * xdisp.c (decode_mode_spec): Likewise.
3793 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3794 behavior on 64-bit hosts with printf arg.
3795 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3796 (x_stop_queuing_selection_requests): Likewise.
3797 (x_get_window_property): Don't truncate byte count to an 'int'
3798 when tracing.
3799
3800 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3801 here, since it parses constructs like leading '-' and spaces,
3802 which are not wanted; and it overflows with large numbers.
3803 Instead, simply match F[0-9]+, which is what is wanted anyway.
3804
3805 * alloc.c: Remove unportable assumptions about struct layout.
3806 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3807 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3808 (allocate_vectorlike, make_pure_vector): Use the new macros,
3809 plus offsetof, to remove unportable assumptions about struct layout.
3810 These assumptions hold on all porting targets that I know of, but
3811 they are not guaranteed, they're easy to remove, and removing them
3812 makes further changes easier.
3813
3814 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3815 This doesn't fix a bug but makes the code clearer.
3816 (string_overrun_cookie): Now const. Use initializers that
3817 don't formally overflow signed char, to avoid warnings.
3818 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3819 can cause Emacs to crash when string overrun checking is enabled.
3820 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3821 multiple of sizeof (EMACS_INT); it need not be, if
3822 alignof(EMACS_INT) < sizeof (EMACS_INT).
3823 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3824
3825 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3826
3827 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3828
3829 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3830
3831 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3832 supposed to be handshaking. (Bug#8556)
3833 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3834
3835 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3836
3837 * lisp.h (Qdebug): List symbol.
3838 * eval.c (Qdebug): Restore global linkage.
3839 * keyboard.c (debug-on-event): New variable.
3840 (handle_user_signal): Break into debugger when debug-on-event
3841 matches the current signal symbol.
3842
3843 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3844
3845 * alloc.c (check_sblock, check_string_bytes)
3846 (check_string_free_list): Convert to standard C.
3847
3848 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3849
3850 * w32.c (emacs_gnutls_push): Fix typo.
3851
3852 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3853
3854 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3855 "cast to pointer from integer of different size".
3856
3857 Improve doprnt and its use in verror. (Bug#8545)
3858 * doprnt.c (doprnt): Document the set of format control sequences
3859 supported by the function. Use SAFE_ALLOCA instead of always
3860 using `alloca'.
3861
3862 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3863 is one byte too soon. Don't use xrealloc; instead xfree and
3864 xmalloc anew.
3865
3866 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3867
3868 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3869 callbacks stage.
3870
3871 * gnutls.c: Renamed global_initialized to
3872 gnutls_global_initialized. Added internals for the
3873 :verify-hostname-error, :verify-error, and :verify-flags
3874 parameters of `gnutls-boot' and documented those parameters in the
3875 docstring. Start callback support.
3876 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3877 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3878 on error. Return error code.
3879 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3880 (emacs_gnutls_read): Likewise.
3881 (Fgnutls_boot): Return handshake error code.
3882 (emacs_gnutls_handle_error): New function.
3883 (wsaerror_to_errno): Likewise.
3884
3885 * w32.h (emacs_gnutls_pull): Add prototype.
3886 (emacs_gnutls_push): Likewise.
3887
3888 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3889 (emacs_gnutls_push): Likewise.
3890
3891 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3892
3893 * process.c (wait_reading_process_output): Check if GnuTLS
3894 buffered some data internally if no FDs are set for TLS
3895 connections.
3896
3897 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3898 (LIBS): Link to USER_LIBS.
3899 ($(BLD)/gnutls.$(0)): New target.
3900
3901 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3902
3903 * xdisp.c (handle_single_display_spec): Rename the
3904 display_replaced_before_p argument into display_replaced_p, to
3905 make it consistent with the commentary. Fix typos in the
3906 commentary.
3907
3908 * textprop.c (syms_of_textprop): Remove dead code.
3909 (copy_text_properties): Delete obsolete commentary about an
3910 interface that was deleted long ago. Fix typos in the description
3911 of arguments.
3912
3913 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3914 to changes in oldXMenu/XMenu.h from 2011-04-16.
3915 <menu_help_message, prev_menu_help_message>: Constify.
3916 (IT_menu_make_room): menu->help_text is now `const char **';
3917 adjust.
3918
3919 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3920 to changes in oldXMenu/XMenu.h from 2011-04-16.
3921 (struct XMenu): Declare `help_text' `const char **'.
3922
3923 * xfaces.c <Qunspecified>: Make extern again.
3924
3925 * syntax.c: Include sys/types.h before including regex.h, as
3926 required by Posix.
3927
3928 * doc.c (get_doc_string): Improve the format passed to `error'.
3929
3930 * doprnt.c (doprnt): Improve commentary.
3931
3932 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3933
3934 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3935 them with etags.
3936
3937 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3938 changes in globals.h immediately force recompilation.
3939 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3940 $(CURDIR)/s/ms-w32.h.
3941 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3942
3943 * character.c (Fchar_direction): Function deleted.
3944 (syms_of_character): Don't defsubr it.
3945 <char-direction-table>: Deleted.
3946
3947 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3948
3949 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3950 * doprnt.c: Include limits.h.
3951 (SIZE_MAX): New macro.
3952 (doprnt): Return a size_t value. 2nd arg is now size_t.
3953 Many local variables are now size_t instead of int or unsigned.
3954 Improve overflow protection. Support `l' modifier for integer
3955 conversions. Support %l conversion. Don't assume an EMACS_INT
3956 argument for integer conversions and for %c.
3957
3958 * lisp.h (doprnt): Restore prototype.
3959
3960 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3961 $(SRC)/character.h.
3962
3963 * Makefile.in (base_obj): Add back doprnt.o.
3964
3965 * deps.mk (doprnt.o): Add back prerequisites.
3966 (callint.o): Depend on character.h.
3967
3968 * eval.c (internal_lisp_condition_case): Include the handler
3969 representation in the error message.
3970 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3971 when breaking from the loop.
3972
3973 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3974
3975 * callint.c (Fcall_interactively): When displaying error message
3976 about invalid control letter, pass the character's codepoint, not
3977 a pointer to its multibyte form. Improve display of the character
3978 in octal and display also its hex code.
3979
3980 * character.c (char_string): Use %x to display the (unsigned)
3981 codepoint of an invalid character, to avoid displaying a bogus
3982 negative value.
3983
3984 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3985 `error', not SYMBOL_NAME itself.
3986
3987 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3988 character arguments to `error'.
3989
3990 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3991 to `error' in error message about FINAL_CHAR argument. Make sure
3992 FINAL_CHAR is a character, and use %c when it is passed as
3993 argument to `error'.
3994
3995 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3996
3997 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3998
3999 * w32.c: Include <time.h>.
4000 (sys_localtime): New function.
4001
4002 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4003
4004 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4005
4006 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4007
4008 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4009
4010 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4011 zombies (Bug#8467).
4012
4013 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4014
4015 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4016 gl_state.e_property when gl_state.object is Qt.
4017
4018 * insdel.c (make_gap_larger): Remove limitation of buffer size
4019 to <= INT_MAX.
4020
4021 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4022
4023 * xdisp.c (lookup_glyphless_char_display)
4024 (produce_glyphless_glyph): Handle cons cell entry in
4025 glyphless-char-display.
4026 (Vglyphless_char_display): Document it.
4027
4028 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4029 glyphless-char-display.
4030
4031 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4032
4033 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4034
4035 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4036
4037 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4038 definition for no-X builds.
4039
4040 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4041
4042 Static checks with GCC 4.6.0 and non-default toolkits.
4043
4044 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4045
4046 * process.c (keyboard_bit_set): Define only if SIGIO.
4047 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4048 (send_process): Repair possible setjmp clobbering.
4049
4050 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4051
4052 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4053
4054 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4055
4056 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4057 Define only if needed.
4058
4059 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4060 by pacifying GCC about it. Maybe it's time to retire it?
4061 * xfaces.c (USG, __TIMEVAL__): Likewise.
4062
4063 * dispextern.h (struct redisplay_interface): Rename param
4064 to avoid shadowing.
4065 * termhooks.h (struct terminal): Likewise.
4066 * xterm.c (xembed_send_message): Likewise.
4067
4068 * insdel.c (make_gap_smaller): Define only if
4069 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4070
4071 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4072 it.
4073
4074 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4075 so that we aren't warned about unused symbols.
4076
4077 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4078
4079 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4080
4081 * xfns.c (x_real_positions): Mark locals as initialized.
4082
4083 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4084
4085 * xterm.c: Fix problems found by static analysis with other toolkits.
4086 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4087 (x_dispatch_event): Declare static if USE_GTK, and
4088 define if USE_GTK || USE_X_TOOLKIT.
4089 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4090 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4091 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4092 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4093
4094 * xmenu.c (menu_help_callback): Pointer type fixes.
4095 Use const pointers when pointing at readonly data. Avoid pointer
4096 signedness clashes.
4097 (FALSE): Remove unused macro.
4098 (update_frame_menubar): Remove unused decl.
4099
4100 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4101
4102 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4103 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4104 (single_menu_item): Rename local to avoid shadowing.
4105
4106 * keyboard.c (make_lispy_event): Remove unused local var.
4107
4108 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4109 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4110
4111 * bitmaps: Change bitmaps from unsigned char back to the X11
4112 compatible char. Avoid the old compiler warnings about
4113 out-of-range initializers by using, for example, '\xab' rather
4114 than 0xab.
4115
4116 * xgselect.c (xgselect_initialize): Check vs interface
4117 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4118
4119 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4120
4121 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4122 to read-only memory.
4123
4124 * fns.c (vector): Remove; this old hack is no longer needed.
4125
4126 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4127 Remove unused var.
4128 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4129
4130 * xrdb.c (x_load_resources): Omit unused local.
4131
4132 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4133 (x_window): Rename locals to avoid shadowing.
4134 (USG): Use the kludged USG macro, to pacify gcc.
4135
4136 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4137 (x_term_init): Remove local to avoid shadowing.
4138
4139 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4140
4141 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4142 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4143
4144 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4145
4146 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4147
4148 Fix regex.c, syntax.c and friends for buffers > 2GB.
4149 * syntax.h (struct gl_state_s): Declare character position members
4150 EMACS_INT.
4151
4152 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4153
4154 * textprop.c (verify_interval_modification, interval_of):
4155 Declare arguments EMACS_INT.
4156
4157 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4158 EMACS_INT.
4159
4160 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4161
4162 * indent.c (Fvertical_motion): Local variable it_start is now
4163 EMACS_INT.
4164
4165 * regex.c (re_match, re_match_2, re_match_2_internal)
4166 (bcmp_translate, regcomp, regexec, print_double_string)
4167 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4168 (re_compile_pattern, re_exec): Declare arguments and local
4169 variables `size_t' and `ssize_t' and return values `regoff_t', as
4170 appropriate.
4171 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4172 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4173 <compile_stack_type>: `size' and `avail' are now `size_t'.
4174
4175 * regex.h <regoff_t>: Use ssize_t, not int.
4176 (re_search, re_search_2, re_match, re_match_2): Arguments that
4177 specify buffer/string position and length are now ssize_t and
4178 size_t. Return type is regoff_t.
4179
4180 2011-04-16 Ben Key <bkey76@gmail.com>
4181
4182 * nsfont.m: Fixed bugs in ns_get_family and
4183 ns_descriptor_to_entity that were caused by using free to
4184 deallocate memory blocks that were allocated by xmalloc (via
4185 xstrdup). This caused Emacs to crash when compiled with
4186 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4187 --enable-checking=xmallocoverrun). xfree is now used to
4188 deallocate these memory blocks.
4189
4190 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4191
4192 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4193
4194 emacs_write: Accept and return EMACS_INT for sizes.
4195 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4196 et seq.
4197 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4198 Accept and return EMACS_INT.
4199 (emacs_gnutls_write): Return the number of bytes written on
4200 partial writes.
4201 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4202 (emacs_read, emacs_write): Remove check for negative size, as the
4203 Emacs source code has been audited now.
4204 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4205 (emacs_read, emacs_write): Use it.
4206 * process.c (send_process): Adjust to the new signatures of
4207 emacs_write and emacs_gnutls_write. Do not attempt to store
4208 a byte offset into an 'int'; it might overflow.
4209 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4210
4211 * sound.c: Don't assume sizes fit in 'int'.
4212 (struct sound_device.period_size, alsa_period_size):
4213 Return EMACS_INT, not int.
4214 (struct sound_device.write, vox_write, alsa_write):
4215 Accept EMACS_INT, not int.
4216 (wav_play, au_play): Use EMACS_INT to store sizes and to
4217 record read return values.
4218
4219 2011-04-15 Ben Key <bkey76@gmail.com>
4220
4221 * keyboard.c (Qundefined): Don't declare static since it is used
4222 in nsfns.m.
4223 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4224 static since they are used in nsfont.m.
4225
4226 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4227
4228 * process.c (Qprocessp): Don't declare static.
4229 * lisp.h (Qprocessp): Declare again.
4230
4231 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4232
4233 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4234
4235 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4236
4237 Improve C-level modularity by making more things 'static'.
4238
4239 Don't publish debugger-only interfaces to other modules.
4240 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4241 (verify_bytepos, count_markers): Move decls to the only modules
4242 that need them.
4243 * region-cache.h (pp_cache): Likewise.
4244 * window.h (check_all_windows): Likewise.
4245 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4246
4247 * sysdep.c (croak): Now static, if
4248 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4249 * syssignal.h (croak): Declare only if not static.
4250
4251 * alloc.c (refill_memory_reserve): Now static if
4252 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4253 * lisp.h (refill_memory_reserve): Declare only if not static.
4254
4255 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4256 Define only if USE_LUCID.
4257
4258 * xrdb.c (x_customization_string, x_rm_string): Now static.
4259
4260 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4261 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4262
4263 * xdisp.c (draw_row_with_mouse_face): Now static.
4264 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4265
4266 * window.h (check_all_windows): Mark externally visible.
4267
4268 * window.c (window_deletion_count): Now static.
4269
4270 * undo.c: Make symbols static if they're not exported.
4271 (last_undo_buffer, last_boundary_position, pending_boundary):
4272 Now static.
4273
4274 * textprop.c (interval_insert_behind_hooks): Now static.
4275 (interval_insert_in_front_hooks): Likewise.
4276
4277 * term.c: Make symbols static if they're not exported.
4278 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4279 (max_frame_lines, tty_set_terminal_modes):
4280 (tty_reset_terminal_modes, tty_turn_off_highlight):
4281 (get_tty_terminal): Now static.
4282 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4283 * termhooks.h (term_mouse_moveto): Do not declare if
4284 HAVE_WINDOW_SYSTEM.
4285 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4286 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4287
4288 * sysdep.c: Make symbols static if they're not exported.
4289 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4290 Now static.
4291 (sigprocmask_set, full_mask): Remove; unused.
4292 (wait_debugging): Mark as visible.
4293 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4294 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4295
4296 * syntax.c (syntax_temp): Define only if !__GNUC__.
4297
4298 * sound.c (current_sound_device, current_sound): Now static.
4299
4300 * search.c (searchbufs, searchbuf_head): Now static.
4301
4302 * scroll.c (scroll_cost): Remove; unused.
4303 * dispextern.h (scroll_cost): Remove decl.
4304
4305 * region-cache.h (pp_cache): Mark as externally visible.
4306
4307 * process.c: Make symbols static if they're not exported.
4308 (process_tick, update_tick, create_process, chan_process):
4309 (Vprocess_alist, proc_buffered_char, datagram_access):
4310 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4311 (deactivate_process): Mark defn as static, as well as decl.
4312 * lisp.h (create_process): Remove decl.
4313 * process.h (chan_process, Vprocess_alist): Remove decls.
4314
4315 * print.c: Make symbols static if they're not exported.
4316 (print_depth, new_backquote_output, being_printed, print_buffer):
4317 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4318 (print_interval, print_number_index, initial_stderr_stream):
4319 Now static.
4320 * lisp.h (Fprinc): Remove decl.
4321 (debug_output_compilation_hack): Mark as externally visible.
4322
4323 * sysdep.c (croak): Move decl from here to syssignal.h.
4324 * syssignal.h (croak): Put it here, so the API can be checked when
4325 'croak' is called from dissociate_if_controlling_tty.
4326
4327 * minibuf.c: Make symbols static if they're not exported.
4328 (minibuf_save_list, choose_minibuf_frame): Now static.
4329 * lisp.h (choose_minibuf_frame): Remove decl.
4330
4331 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4332
4333 * lread.c: Make symbols static if they're not exported.
4334 (read_objects, initial_obarray, oblookup_last_bucket_number):
4335 Now static.
4336 (make_symbol): Remove; unused.
4337 * lisp.h (initial_obarray, make_symbol): Remove decls.
4338
4339 * keyboard.c: Make symbols static if they're not exported.
4340 (single_kboard, recent_keys_index, total_keys, recent_keys):
4341 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4342 (this_single_command_key_start, echoing, last_auto_save):
4343 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4344 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4345 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4346 (Vlispy_mouse_stem, double_click_count):
4347 Now static.
4348 (force_auto_save_soon): Define only if SIGDANGER.
4349 (ignore_mouse_drag_p): Now static if
4350 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4351 (print_help): Remove; unused.
4352 (stop_character, last_timer_event): Mark as externally visible.
4353 * keyboard.h (ignore_mouse_drag_p): Declare only if
4354 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4355 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4356 * lisp.h (echoing): Remove decl.
4357 (force_auto_save_soon): Declare only if SIGDANGER.
4358 * xdisp.c (redisplay_window): Simplify code, to make it more
4359 obvious that ignore_mouse_drag_p is not accessed if !defined
4360 USE_GTK && !defined HAVE_NS.
4361
4362 * intervals.c: Make symbols static if they're not exported.
4363 (merge_properties_sticky, merge_interval_right, delete_interval):
4364 Now static.
4365 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4366
4367 * insdel.c: Make symbols static if they're not exported.
4368 However, leave prepare_to_modify_buffer alone. It's never
4369 called from outside this function, but that appears to be a bug.
4370 (combine_after_change_list, combine_after_change_buffer):
4371 (adjust_after_replace, signal_before_change): Now static.
4372 (adjust_after_replace_noundo): Remove; unused.
4373 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4374 (signal_before_change): Remove decls.
4375
4376 * indent.c (val_compute_motion, val_vmotion): Now static.
4377
4378 * image.c: Make symbols static if they're not exported.
4379 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4380 if USE_GTK.
4381 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4382 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4383
4384 * fringe.c (standard_bitmaps): Now static.
4385 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4386
4387 * frame.c: Make symbols static if they're not exported.
4388 (x_report_frame_params, make_terminal_frame): Now static.
4389 (get_frame_param): Now static, unless HAVE_NS.
4390 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4391 (x_get_resource_string): Remove; not used.
4392 * frame.h (make_terminal_frame, x_report_frame_params):
4393 (x_get_resource_string); Remove decls.
4394 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4395 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4396
4397 * font.c, fontset.c: Make symbols static if they're not exported.
4398 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4399 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4400 * font.c (font_close_object): Now static.
4401 * font.h (font_close_object): Remove.
4402 * fontset.c (FONTSET_OBJLIST): Remove.
4403 (free_realized_fontset) #if-0 the body, which does nothing.
4404 (face_suitable_for_char_p): #if-0, as it's never called.
4405 * fontset.h (face_suitable_for_char_p): Remove decl.
4406 * xfaces.c (face_at_string_position):
4407 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4408 since 0 is always ASCII.
4409
4410 * fns.c (weak_hash_tables): Now static.
4411
4412 * fileio.c: Make symbols static if they're not exported.
4413 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4414 (Vwrite_region_annotation_buffers): Now static.
4415
4416 * eval.c: Make symbols static if they're not exported.
4417 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4418 * lisp.h (backtrace_list): Remove decl.
4419
4420 * emacs.c: Make symbols static if they're not exported.
4421 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4422 (fatal_error_code, fatal_error_signal_hook, standard_args):
4423 Now static.
4424 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4425 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4426 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4427 * lisp.h (fatal_error_signal_hook): Remove decl.
4428 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4429
4430 * editfns.c: Move a (normally-unused) function to its only use.
4431 * editfns.c, lisp.h (get_operating_system_release): Remove.
4432 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4433 worth the hassle of breaking this out.
4434
4435 * xterm.c: Make symbols static if they're not exported.
4436 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4437 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4438 (x_destroy_window, x_delete_display):
4439 Now static.
4440 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4441 (x_mouse_leave): Remove; unused.
4442 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4443 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4444 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4445 Remove decls.
4446 (x_mouse_leave): Declare only if WINDOWSNT.
4447 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4448 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4449 USE_X_TOOLKIT.
4450
4451 * ftxfont.c: Make symbols static if they're not exported.
4452 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4453 HAVE_FREETYPE.
4454 * font.h (ftxfont_driver): Likewise.
4455
4456 * xfns.c: Make symbols static if they're not exported.
4457 (x_last_font_name, x_display_info_for_name):
4458 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4459 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4460 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4461 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4462 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4463 (last_show_tip_args): Now static.
4464 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4465 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4466 (x_screen_planes): Remove; unused.
4467 * dispextern.h (x_screen_planes): Remove decl.
4468
4469 * dispnew.c: Make symbols static if they're not exported.
4470 * dispextern.h (redraw_garbaged_frames, scrolling):
4471 (increment_row_positions): Remove.
4472 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4473 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4474 Now static.
4475 (redraw_garbaged_frames): Remove; unused.
4476
4477 * xfaces.c: Make symbols static if they're not exported.
4478 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4479 Remove decls.
4480 * xterm.h (defined_color): Remove decls.
4481 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4482 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4483 (menu_face_changed_default, defined_color, free_realized_face):
4484 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4485 (ascii_face_of_lisp_face): Remove; unused.
4486
4487 * xdisp.c: Make symbols static if they're not exported.
4488 * dispextern.h (scratch_glyph_row, window_box_edges):
4489 (glyph_to_pixel_coords, set_cursor_from_row):
4490 (get_next_display_element, set_iterator_to_next):
4491 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4492 (show_mouse_face): Remove decls
4493 * frame.h (message_buf_print): Likewise.
4494 * lisp.h (pop_message, set_message, check_point_in_composition):
4495 Likewise.
4496 * xterm.h (set_vertical_scroll_bar): Likewise.
4497 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4498 (message_buf_print, scratch_glyph_row, displayed_buffer):
4499 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4500 (get_next_display_element, show_mouse_face, window_box_edges):
4501 (frame_to_window_pixel_xy, check_point_in_composition):
4502 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4503 (glyph_to_pixel_coords): Remove; unused.
4504
4505 * dired.c (file_name_completion): Now static.
4506
4507 * dbusbind.c (xd_in_read_queued_messages): Now static.
4508
4509 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4510 * data.c (circular_list_error): Remove.
4511
4512 * commands.h (last_point_position, last_point_position_buffer):
4513 (last_point_position_window): Remove decls.
4514 * keyboard.c: Make these variables static.
4515
4516 * coding.h (coding, code_convert_region, encode_coding_gap):
4517 Remove decls.
4518 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4519 (iso_code_class, detect_coding, code_convert_region): Now static.
4520 (encode_coding_gap): Remove; unused.
4521
4522 * chartab.c (chartab_chars, chartab_bits): Now static.
4523
4524 * charset.h (charset_iso_8859_1): Remove decl.
4525 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4526 Now static.
4527
4528 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4529 * ccl.c (Vccl_program_table): Now static.
4530 (check_ccl_update): Remove; unused.
4531
4532 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4533 * category.h: ... from here.
4534 * category.c (check_category_table, set_category_set): Now static.
4535
4536 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4537 * lisp.h: Remove these decls.
4538
4539 * buffer.c (buffer_count): Remove unused var.
4540
4541 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4542 so that it's not optimized away.
4543 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4544 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4545 exported only to the debugger.
4546
4547 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4548 * atimer.h (run_all_atimers): Remove; not exported.
4549
4550 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4551 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4552 was inaccessible from Lisp.
4553 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4554 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4555
4556 alloc.c: Import and export fewer symbols, and remove unused items.
4557 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4558 is defined.
4559 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4560 it's not optimized away by whole-program optimization.
4561 (message_enable_multibyte, free_misc): Remove.
4562 (catchlist, handlerlist, mark_backtrace):
4563 Declare only if BYTE_MARK_STACK.
4564 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4565 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4566 (message_enable_multibyte): Remove decl.
4567 (free_misc, interval_free_list, float_block, float_block_index):
4568 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4569 (cons_free_list, last_marked_index):
4570 Now static.
4571 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4572 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4573 (mark_backtrace): Define only if BYTE_MARK_STACK.
4574 * xdisp.c (message_enable_multibyte): Now static.
4575
4576 Declare Lisp_Object Q* variables to be 'static' if not exported.
4577 This makes it easier for human readers (and static analyzers)
4578 to see whether these variables are used from other modules.
4579 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4580 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4581 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4582 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4583 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4584 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4585 * xmenu.c, xselect.c:
4586 Declare Q* vars static if they are not used in other modules.
4587 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4588 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4589 Remove decls of unexported vars.
4590 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4591
4592 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4593
4594 Make Emacs functions such as Fatom 'static' by default.
4595 This makes it easier for human readers (and static analyzers)
4596 to see whether these functions can be called from other modules.
4597 DEFUN now defines a static function. To make the function external
4598 so that it can be used in other C modules, use the new macro DEFUE.
4599 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4600 (Finit_image_library):
4601 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4602 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4603 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4604 Remove decls, since these functions are now static.
4605 (Funintern, Fget_internal_run_time): New decls, since these functions
4606 were already external.
4607
4608 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4609 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4610 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4611 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4612 * keyboard.c, keymap.c, lread.c:
4613 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4614 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4615 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4616 Mark functions with DEFUE instead of DEFUN,
4617 if they are used in other modules.
4618 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4619 decls for now-static functions.
4620 * buffer.h (Fdelete_overlay): Remove decl.
4621 * callproc.c (Fgetenv_internal): Mark as internal.
4622 * composite.c (Fremove_list_of_text_properties): Remove decl.
4623 (Fcomposition_get_gstring): New forward static decl.
4624 * composite.h (Fcomposite_get_gstring): Remove decl.
4625 * dired.c (Ffile_attributes): New forward static decl.
4626 * doc.c (Fdocumntation_property): New forward static decl.
4627 * eval.c (Ffetch_bytecode): New forward static decl.
4628 (Funintern): Remove extern decl; now in .h file where it belongs.
4629 * fileio.c (Fmake_symbolic_link): New forward static decl.
4630 * image.c (Finit_image_library): New forward static decl.
4631 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4632 * intervals.h (Fprevious_property_change):
4633 (Fremove_list_of_text_properties): Remove decls.
4634 * keyboard.c (Fthis_command_keys): Remove decl.
4635 (Fcommand_execute): New forward static decl.
4636 * keymap.c (Flookup_key): New forward static decl.
4637 (Fcopy_keymap): Now static.
4638 * keymap.h (Flookup_key): Remove decl.
4639 * process.c (Fget_process): New forward static decl.
4640 (Fprocess_datagram_address): Mark as internal.
4641 * syntax.c (Fsyntax_table_p): New forward static decl.
4642 (skip_chars): Remove duplicate decl.
4643 * textprop.c (Fprevious_property_change): New forward static decl.
4644 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4645 Now internal.
4646 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4647 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4648
4649 * editfns.c (Fformat): Remove unreachable code.
4650
4651 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4652
4653 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4654 change. (Bug#8496)
4655
4656 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4657
4658 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4659 when at ZV. (Bug#8487)
4660
4661 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4662
4663 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4664 (Bug#8437)
4665 * keyboard.c (parse_tool_bar_item): Likewise.
4666 * sound.c (sound_cleanup, alsa_close): Likewise.
4667 * termcap.c (tgetent): Likewise.
4668 * xfns.c (x_default_font_parameter): Likewise.
4669 * xsettings.c (read_and_apply_settings): Likewise.
4670
4671 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4672 (overrun_check_free): Protoize.
4673
4674 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4675
4676 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4677 since callers should never pass a negative size.
4678 Change the signature to match that of plain 'read' and 'write'; see
4679 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4680 * lisp.h: Update prototypes of emacs_write and emacs_read.
4681
4682 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4683
4684 * xdisp.c (redisplay_window): Don't try to determine the character
4685 position of the scroll margin if the window start point w->startp
4686 is outside the buffer's accessible region. (Bug#8468)
4687
4688 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4689
4690 Fix write-region and its subroutines for buffers > 2GB.
4691 * fileio.c (a_write, e_write): Modify declaration of arguments and
4692 local variables to support buffers larger than 2GB.
4693 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4694
4695 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4696 argument, local variables, and return value.
4697
4698 * lisp.h: Update prototypes of emacs_write and emacs_read.
4699
4700 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4701
4702 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4703
4704 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4705
4706 Fix more problems found by GCC 4.6.0's static checks.
4707
4708 * xdisp.c (vmessage): Use a better test for character truncation.
4709
4710 * charset.c (load_charset_map): <, not <=, for optimization,
4711 and to avoid potential problems with integer overflow.
4712 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4713 * casetab.c (set_identity, shuffle): Likewise.
4714 * editfns.c (Fformat): Likewise.
4715 * syntax.c (skip_chars): Likewise.
4716
4717 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4718 This also lets GCC 4.6.0 generate slightly better loop code.
4719
4720 * callint.c (Fcall_interactively): <, not <=, for optimization.
4721 (Fcall_interactively): Count the number of arguments produced,
4722 not the number of arguments given. This is simpler and lets GCC
4723 4.6.0 generate slightly better code.
4724
4725 * ftfont.c: Distingish more carefully between FcChar8 and char.
4726 The previous code passed unsigned char * to a functions like
4727 strlen and xstrcasecmp that expect char *, which does not
4728 conform to the C standard.
4729 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4730 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4731 char * when the C standard requires it.
4732
4733 * keyboard.c (read_char): Remove unused var.
4734
4735 * eval.c: Port to Windows vsnprintf (Bug#8435).
4736 Include <limits.h>.
4737 (SIZE_MAX): Define if the headers do not.
4738 (verror): Do not give up if vsnprintf returns a negative count.
4739 Instead, grow the buffer. This ports to Windows vsnprintf, which
4740 does not conform to C99. Problem reported by Eli Zaretskii.
4741 Also, simplify the allocation scheme, by avoiding the need for
4742 calling realloc, and removing the ALLOCATED variable.
4743
4744 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4745
4746 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4747 But keep the doprint source code for now, as we might revamp it
4748 and use it again (Bug#8435).
4749 * lisp.h (doprnt): Remove.
4750 * Makefile.in (base_obj): Remove doprnt.o.
4751 * deps.mk (doprnt.o): Remove.
4752
4753 error: Print 32- and 64-bit integers portably (Bug#8435).
4754 Without this change, on typical 64-bit hosts error ("...%d...", N)
4755 was used to print both 32- and 64-bit integers N, which relied on
4756 undefined behavior.
4757 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4758 New macro.
4759 * lisp.h (error, verror): Mark as printf-like functions.
4760 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4761 Report overflow in size calculations when allocating printf buffer.
4762 Do not truncate output string at its first null byte.
4763 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4764 Truncate the output at a character boundary, since vsnprintf does not
4765 do that.
4766 * charset.c (check_iso_charset_parameter): Convert internal
4767 character to string before calling 'error', since %c now has the
4768 printf meaning.
4769 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4770 overflow when computing char to be passed to 'error'. Do not
4771 pass Lisp_Object to 'error'; pass the integer instead.
4772 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4773 formatted with plain %d.
4774
4775 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4776
4777 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4778
4779 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4780
4781 * xterm.c (x_catch_errors): Remove duplicate declaration.
4782
4783 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4784
4785 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4786
4787 2011-04-10 Jim Meyering <meyering@redhat.com>
4788
4789 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4790 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4791 return ssize_t not "int", and use size_t as the buffer length.
4792 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4793 * gnutls.h: Update declarations.
4794 * process.c (read_process_output): Use ssize_t, to match.
4795 (send_process): Likewise.
4796
4797 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4798
4799 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4800
4801 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4802
4803 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4804 Use unsigned char, to match FcChar8 type definition.
4805
4806 * xterm.c (handle_one_xevent):
4807 * xmenu.c (create_and_show_popup_menu):
4808 * xselect.c (x_decline_selection_request)
4809 (x_reply_selection_request): Avoid type-punned deref of X events.
4810
4811 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4812
4813 Fix some uses of `int' instead of EMACS_INT.
4814 * search.c (string_match_1, fast_string_match)
4815 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4816 (scan_buffer, find_next_newline_no_quit)
4817 (find_before_next_newline, search_command, Freplace_match)
4818 (Fmatch_data): Make some `int' variables be EMACS_INT.
4819
4820 * xdisp.c (display_count_lines): 3rd argument and return value now
4821 EMACS_INT. All callers changed.
4822 (pint2hrstr): Last argument is now EMACS_INT.
4823
4824 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4825 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4826 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4827 (decode_coding_utf_16, decode_coding_emacs_mule)
4828 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4829 (decode_coding_ccl, decode_coding_charset)
4830 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4831 (decode_coding_iso_2022, decode_coding_emacs_mule)
4832 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4833 <char_offset, last_offset>: Declare EMACS_INT.
4834 (encode_coding_utf_8, encode_coding_utf_16)
4835 (encode_coding_emacs_mule, encode_invocation_designation)
4836 (encode_designation_at_bol, encode_coding_iso_2022)
4837 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4838 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4839 Declare EMACS_INT.
4840 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4841 (encode_invocation_designation): Last argument P_NCHARS is now
4842 EMACS_INT.
4843 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4844 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4845
4846 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4847 All users changed.
4848
4849 * ccl.c (Fccl_execute_on_string): Declare some variables
4850 EMACS_INT.
4851
4852 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4853
4854 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4855
4856 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4857
4858 * process.c (Fformat_network_address): Doc fix.
4859
4860 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4861
4862 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4863
4864 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4865
4866 * keyboard.c (read_char): Call Lisp function help-form-show,
4867 instead of using internal_with_output_to_temp_buffer.
4868 (Qhelp_form_show): New var.
4869 (syms_of_keyboard): Use DEFSYM macro.
4870
4871 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4872
4873 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4874
4875 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4876
4877 * process.c (Flist_processes): Remove to Lisp.
4878 (list_processes_1): Delete.
4879
4880 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4881
4882 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4883
4884 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4885
4886 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4887
4888 Fix more problems found by GCC 4.6.0's static checks.
4889
4890 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4891
4892 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4893
4894 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4895
4896 * xdisp.c (vmessage): Mark as a printf-like function.
4897
4898 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4899
4900 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4901
4902 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4903 printf-like functions.
4904 (tiff_load): Add casts to remove these marks before passing them
4905 to system-supplied API.
4906
4907 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4908
4909 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4910 This avoids several warnings with gcc -Wstrict-overflow.
4911 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4912 directly, rather than having caller test rule sign. This avoids
4913 some unnecessary tests.
4914 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4915 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4916 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4917
4918 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4919 (xfont_open): Avoid unnecessary tests.
4920
4921 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4922
4923 * composite.h, composite.c (composition_gstring_put_cache):
4924 Use EMACS_INT, not int, for length.
4925
4926 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4927 breaking out part of COMPOSITION_DECODE_RULE.
4928 (COMPOSITION_DECODE_RULE): Use it.
4929 * composite.c (get_composition_id): Remove unused local vars,
4930 by using the new macro.
4931
4932 * textprop.c (set_text_properties_1): Change while to do-while,
4933 since the condition is always true at first.
4934
4935 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4936 (interval_deletion_adjustment): Return unsigned value.
4937 All uses changed.
4938
4939 * process.c (list_processes_1, create_pty, read_process_output):
4940 (exec_sentinel): Remove vars that were set but not used.
4941 (create_pty): Remove unnecessary "volatile"s.
4942 (Fnetwork_interface_info): Avoid possibility of int overflow.
4943 (read_process_output): Do adaptive read buffering even if carryover.
4944 (read_process_output): Simplify nbytes computation if buffered.
4945
4946 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4947
4948 * syntax.c (scan_words): Remove var that was set but not used.
4949 (update_syntax_table): Use unsigned instead of int.
4950
4951 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4952 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4953 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4954
4955 * print.c (print_error_message): Avoid int overflow.
4956
4957 * font.c (font_list_entities): Redo for clarity,
4958 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4959
4960 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4961 (font_score): Avoid potential overflow in diff calculation.
4962
4963 * fns.c (substring_both): Remove var that is set but not used.
4964 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4965
4966 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4967
4968 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4969 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4970 can always succeed if overflow has undefined behavior.
4971
4972 * search.c (boyer_moore, wordify): Remove vars set but not used.
4973 (wordify): Omit three unnecessary tests.
4974
4975 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4976 All callers changed. This avoids the need for an unused var.
4977
4978 * casefiddle.c (casify_region): Remove var that is set but not used.
4979
4980 * dired.c (file_name_completion): Remove var that is set but not used.
4981
4982 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4983
4984 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4985 (Finsert_file_contents): Remove unnecessary code checking fd.
4986
4987 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4988 Check for integer overflow on size calculations.
4989
4990 * buffer.c (Fprevious_overlay_change): Remove var that is set
4991 but not used.
4992
4993 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4994 Remove vars that are set but not used.
4995 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4996 (timer_check_2): Mark vars as initialized.
4997
4998 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4999
5000 * image.c (lookup_image): Remove var that is set but not used.
5001 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5002
5003 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5004 that are set but not used.
5005
5006 * xfns.c (make_invisible_cursor): Don't return garbage
5007 if XCreateBitmapFromData fails (Bug#8410).
5008
5009 * xselect.c (x_get_local_selection, x_handle_property_notify):
5010 Remove vars that are set but not used.
5011
5012 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5013 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5014
5015 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5016 Remove var that is set but not used.
5017 (scroll_bar_windows_size): Now size_t, not int.
5018 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5019 Check for overflow.
5020
5021 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5022 (map_tty_color) [!defined MSDOS]: Likewise.
5023
5024 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5025
5026 * coding.c: Remove vars that are set but not used.
5027 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5028 All callers changed.
5029 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5030 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5031 (decode_coding_charset): Remove vars that are set but not used.
5032
5033 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5034 that is set but not used.
5035
5036 * print.c (print_object): Remove var that is set but not used.
5037
5038 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5039 The gnulib version avoids calling malloc in the usual case,
5040 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5041 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5042 * filelock.c (current_lock_owner): Likewise.
5043 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5044 * sysdep.c: Include allocator.h, careadlinkat.h.
5045 (emacs_no_realloc_allocator): New static constant.
5046 (emacs_readlink): New function.
5047 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5048 ../lib/careadlinkat.h.
5049
5050 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5051
5052 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5053 first non-nil return value).
5054
5055 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5056
5057 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5058 if not defined (Bug#8403).
5059
5060 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5061
5062 * xdisp.c (display_count_lines): Remove parameter `start',
5063 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5064 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5065 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5066 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5067 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5068 and thereabouts. All callers changed.
5069 (get_per_char_metric): Remove parameter `f', unused since
5070 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5071
5072 2011-04-02 Jim Meyering <meyering@redhat.com>
5073
5074 do not dereference NULL upon failed strdup
5075 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5076 (ns_get_family): Likewise.
5077
5078 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5079
5080 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5081
5082 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5083
5084 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5085 later (Bug#8403).
5086
5087 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5088
5089 Add lexical binding.
5090
5091 * window.c (Ftemp_output_buffer_show): New fun.
5092 (Fsave_window_excursion):
5093 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5094
5095 * lread.c (lisp_file_lexically_bound_p): New function.
5096 (Fload): Bind Qlexical_binding.
5097 (readevalloop): Remove `evalfun' arg.
5098 Bind Qinternal_interpreter_environment.
5099 (Feval_buffer): Bind Qlexical_binding.
5100 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5101 Mark as dynamic.
5102 (syms_of_lread): Declare `lexical-binding'.
5103
5104 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5105
5106 * keyboard.c (eval_dyn): New fun.
5107 (menu_item_eval_property): Use it.
5108
5109 * image.c (parse_image_spec): Use Ffunctionp.
5110
5111 * fns.c (concat, mapcar1): Accept byte-code-functions.
5112
5113 * eval.c (Fsetq): Handle lexical vars.
5114 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5115 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5116 (FletX, Flet): Obey lexical binding.
5117 (Fcommandp): Handle closures.
5118 (Feval): New `lexical' arg.
5119 (eval_sub): New function extracted from Feval. Use it almost
5120 everywhere where Feval was used. Look up vars in lexical env.
5121 Handle closures.
5122 (Ffunctionp): Move from subr.el.
5123 (Ffuncall): Handle closures.
5124 (apply_lambda): Remove `eval_flags'.
5125 (funcall_lambda): Handle closures and new byte-code-functions.
5126 (Fspecial_variable_p): New function.
5127 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5128 but without exporting it to Lisp.
5129
5130 * doc.c (Fdocumentation, store_function_docstring):
5131 * data.c (Finteractive_form): Handle closures.
5132
5133 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5134 interactive spec.
5135
5136 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5137 New byte-codes.
5138 (exec_byte_code): New function extracted from Fbyte_code to handle new
5139 calling convention for byte-code-functions. Add new byte-codes.
5140
5141 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5142
5143 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5144
5145 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5146
5147 * xdisp.c (redisplay_internal): Fix prototype.
5148
5149 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5150
5151 * xdisp.c (SCROLL_LIMIT): New macro.
5152 (try_scrolling): Use it when setting scroll_limit.
5153 Limit scrolling to 100 screen lines.
5154 (redisplay_window): Even when falling back on "recentering",
5155 position point in the window according to scroll-conservatively,
5156 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5157
5158 (try_scrolling): When point is above the window, allow searching
5159 as far as scroll_max, or one screenful, to compute vertical
5160 distance from PT to the scroll margin position. This prevents
5161 try_scrolling from unnecessarily failing when
5162 scroll-conservatively is set to a value slightly larger than the
5163 window height. Clean up the case of PT below the margin at bottom
5164 of window: scroll_max can no longer be INT_MAX. When aggressive
5165 scrolling is in use, don't let point enter the opposite scroll
5166 margin as result of the scroll.
5167 (syms_of_xdisp) <scroll-conservatively>: Document the
5168 threshold of 100 lines for never-recentering scrolling.
5169
5170 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5171
5172 * dispextern.h (move_it_by_lines):
5173 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5174 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5175 (message_log_check_duplicate): Remove parameters `prev_bol' and
5176 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5177 (redisplay_internal): Remove parameter `preserve_echo_area',
5178 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5179
5180 * indent.c (Fvertical_motion):
5181 * window.c (window_scroll_pixel_based, Frecenter):
5182 Don't pass `need_y_p' to `move_it_by_lines'.
5183
5184 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5185
5186 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5187 steal a few bits to be more compact.
5188 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5189 Remove unneeded casts.
5190
5191 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5192
5193 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5194
5195 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5196 binding" message (bug#7967).
5197
5198 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5199
5200 Fix more problems found by GCC 4.6.0's static checks.
5201
5202 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5203 Remove unused local var.
5204
5205 * editfns.c (Fmessage_box): Remove unused local var.
5206
5207 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5208 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5209 Omit unused local vars.
5210 * window.c (shrink_windows): Omit unused local var.
5211 * menu.c (digest_single_submenu): Omit unused local var.
5212 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5213 Omit unused local var.
5214
5215 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5216 Don't assume string length fits in int.
5217 (keyremap_step, read_key_sequence): Use size_t for sizes.
5218 (read_key_sequence): Don't check last_real_key_start redundantly.
5219
5220 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5221 instead of alloca (Bug#8344).
5222
5223 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5224 (Fbacktrace_frame): Don't assume nframes fits in int.
5225
5226 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5227
5228 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5229 concerns.
5230
5231 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5232
5233 * cm.c (calccost): Turn while-do into do-while, for clarity.
5234
5235 * keyboard.c (syms_of_keyboard): Use the same style as later
5236 in this function when indexing through an array. This also
5237 works around GCC bug 48267.
5238
5239 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5240
5241 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5242
5243 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5244 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5245
5246 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5247 This avoids undefined behavior on integer overflow, and is a bit
5248 more convenient anyway since it is compared to a size_t variable.
5249
5250 Variadic C functions now count arguments with size_t, not int.
5251 This avoids an unnecessary limitation on 64-bit machines, which
5252 caused (substring ...) to crash on large vectors (Bug#8344).
5253 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5254 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5255 All variadic functions and their callers changed accordingly.
5256 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5257 * data.c (arith_driver, float_arith_driver): Likewise.
5258 * editfns.c (general_insert_function): Likewise.
5259 * eval.c (struct backtrace.nargs, interactive_p)
5260 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5261 (funcall_lambda, mark_backtrace): Likewise.
5262 * fns.c (concat): Likewise.
5263 * frame.c (x_set_frame_parameters): Likewise.
5264 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5265 0 if not found, not -1. All callers changed.
5266
5267 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5268 (stack_copy_size): Now size_t, not int.
5269 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5270
5271 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5272
5273 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5274 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5275 All callers changed.
5276
5277 * lisp.h (multibyte_char_to_unibyte):
5278 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5279 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5280 * character.h (CHAR_TO_BYTE8):
5281 * cmds.c (internal_self_insert):
5282 * editfns.c (general_insert_function):
5283 * keymap.c (push_key_description):
5284 * search.c (Freplace_match):
5285 * xdisp.c (message_dolog, set_message_1): All callers changed.
5286
5287 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5288
5289 * keyboard.c (safe_run_hook_funcall): New function.
5290 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5291 don't set the hook to nil, but remove the offending function instead.
5292 (Qcommand_hook_internal): Remove, unused.
5293 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5294 Vcommand_hook_internal.
5295
5296 * eval.c (enum run_hooks_condition): Remove.
5297 (funcall_nil, funcall_not): New functions.
5298 (run_hook_with_args): Call each function through a `funcall' argument.
5299 Remove `cond' argument, now redundant.
5300 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5301 (Frun_hook_with_args_until_failure): Adjust accordingly.
5302 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5303
5304 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5305
5306 * dispextern.h (string_buffer_position): Remove declaration.
5307
5308 * print.c (strout): Remove parameter `multibyte', unused since
5309 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5310
5311 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5312 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5313 All callers changed.
5314
5315 * w32.c (_wsa_errlist): Use braces for struct initializers.
5316
5317 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5318 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5319 All callers changed.
5320 (string_buffer_position): Likewise. Also, make static (it's never
5321 used outside xdisp.c).
5322 (cursor_row_p): Remove parameter `w', unused since
5323 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5324 (decode_mode_spec): Remove parameter `precision', introduced during
5325 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5326 All callers changed.
5327
5328 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5329
5330 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5331
5332 2011-03-27 Anders Lindgren <andlind@gmail.com>
5333
5334 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5335 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5336 (ns_update_auto_hide_menu_bar): New functions.
5337 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5338 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5339 ns_constrain_all_frames.
5340 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5341 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5342
5343 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5344
5345 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5346
5347 2011-03-27 Glenn Morris <rgm@gnu.org>
5348
5349 * syssignal.h: Replace RETSIGTYPE with void.
5350 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5351 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5352 Replace SIGTYPE with void everywhere.
5353 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5354 * s/template.h (SIGTYPE): Remove commented out definition.
5355
5356 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5357
5358 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5359 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5360
5361 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5362
5363 * w32.c (read_unc_volume): Use parameter `henum', instead of
5364 global variable `wget_enum_handle'.
5365
5366 * keymap.c (describe_vector): Remove parameters `indices' and
5367 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5368 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5369
5370 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5371
5372 * keyboard.c (timer_check): Remove parameter `do_it_now',
5373 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5374 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5375 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5376
5377 * keyboard.c (read_char):
5378 * w32menu.c (w32_menu_display_help):
5379 * xmenu.c (show_help_event, menu_help_callback):
5380 Adjust calls to `show_help_echo'.
5381
5382 * gtkutil.c (xg_maybe_add_timer):
5383 * keyboard.c (readable_events):
5384 * process.c (wait_reading_process_output):
5385 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5386
5387 * insdel.c (adjust_markers_gap_motion):
5388 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5389 (gap_left, gap_right): Don't call it.
5390
5391 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5392
5393 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5394 incurred during fontification.
5395
5396 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5397
5398 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5399 (DEFVAR_PER_BUFFER): Don't pass it.
5400
5401 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5402 (scrolling_window): Don't pass it.
5403
5404 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5405
5406 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5407
5408 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5409 and `suffix'.
5410 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5411 of variables specific to SELinux and computation of `encoded_absname'.
5412
5413 * image.c (XPutPixel): Remove unused variable `height'.
5414
5415 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5416
5417 * unexw32.c (get_section_info): Remove unused variable `section'.
5418
5419 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5420 (system_process_attributes): Remove unused variable `sess'.
5421 (sys_read): Remove unused variable `err'.
5422
5423 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5424 (w32_wnd_proc): Remove unused variable `isdead'.
5425 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5426 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5427 (x_create_tip_frame): Remove unused variable `tem'.
5428
5429 * w32inevt.c (w32_console_read_socket):
5430 Remove unused variable `no_events'.
5431
5432 * w32term.c (x_draw_composite_glyph_string_foreground):
5433 Remove unused variable `width'.
5434
5435 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5436
5437 * w32term.c (x_set_glyph_string_clipping):
5438 Don't pass uninitialized region to CombineRgn.
5439
5440 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5441
5442 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5443 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5444 (Fx_close_connection): Remove unused variable `i'.
5445
5446 * w32font.c (w32font_draw): Return number of glyphs.
5447 (w32font_open_internal): Remove unused variable `i'.
5448 (w32font_driver): Add missing initializer.
5449
5450 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5451 (fill_in_menu): Remove unused variable `items_added'.
5452
5453 * w32term.c (last_mouse_press_frame): Remove static global variable.
5454 (w32_clip_to_row): Remove unused variable `f'.
5455 (x_delete_terminal): Remove unused variable `i'.
5456
5457 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5458 (NOTHING): Remove unused static global variable.
5459 (uniscribe_check_otf): Remove unused variable `table'.
5460 (uniscribe_font_driver): Add missing initializers.
5461
5462 2011-03-23 Julien Danjou <julien@danjou.info>
5463
5464 * term.c (Fsuspend_tty, Fresume_tty):
5465 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5466 * window.c (temp_output_buffer_show):
5467 * insdel.c (signal_before_change):
5468 * frame.c (Fhandle_switch_frame):
5469 * fileio.c (Fdo_auto_save):
5470 * emacs.c (Fkill_emacs):
5471 * editfns.c (save_excursion_restore):
5472 * cmds.c (internal_self_insert):
5473 * callint.c (Fcall_interactively):
5474 * buffer.c (Fkill_all_local_variables):
5475 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5476 Use Frun_hooks.
5477 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5478 unconditionnaly since it does the check itself.
5479
5480 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5481
5482 Fix more problems found by GCC 4.5.2's static checks.
5483
5484 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5485 the first time through the loop, since we know p0 < p1 then.
5486 This also avoids a gcc -Wstrict-overflow warning.
5487
5488 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5489 leading to a memory leak, possible in functions like
5490 load_charset_map_from_file that can allocate an unbounded number
5491 of objects (Bug#8318).
5492
5493 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5494 that could (at least in theory) be that large.
5495
5496 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5497 This is less likely to overflow, and avoids undefined behavior if
5498 overflow does occur. All callers changed. Use strtoul to scan
5499 for the unsigned long integer.
5500 (pint2hrstr): Simplify and tune code slightly.
5501 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5502
5503 * scroll.c (do_scrolling): Work around GCC bug 48228.
5504 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5505
5506 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5507 This also avoids a warning with gcc -Wstrict-overflow.
5508 (validate_x_resource_name): Simplify count usage.
5509 This also avoids a warning with gcc -Wstrict-overflow.
5510
5511 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5512 fail (Bug#8306).
5513
5514 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5515
5516 * process.c (Fmake_network_process): Use socklen_t, not int,
5517 where POSIX says socklen_t is required in portable programs.
5518 This fixes a porting bug on hosts like 64-bit HP-UX, where
5519 socklen_t is wider than int (Bug#8277).
5520 (Fmake_network_process, server_accept_connection):
5521 (wait_reading_process_output, read_process_output):
5522 Likewise.
5523
5524 * process.c: Rename or move locals to avoid shadowing.
5525 (list_processes_1, Fmake_network_process):
5526 (read_process_output_error_handler, exec_sentinel_error_handler):
5527 Rename or move locals.
5528 (Fmake_network_process): Define label "retry_connect" only if needed.
5529 (Fnetwork_interface_info): Fix pointer signedness.
5530 (process_send_signal): Add cast to avoid pointer signedness problem.
5531 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5532 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5533
5534 Make tparam.h and terminfo.c consistent.
5535 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5536 Include tparam.h instead, since it declares them.
5537 * cm.h (PC): Remove extern decl; tparam.h now does this.
5538 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5539 * terminfo.c: Include tparam.h, to check interfaces.
5540 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5541 (tparam): Adjust signature to match interface in tparam.h;
5542 this removes some undefined behavior. Check that outstring and len
5543 are zero, which they always are with Emacs.
5544 * tparam.h (PC, BC, UP): New extern decls.
5545
5546 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5547 (xftfont_open): Rename locals to avoid shadowing.
5548
5549 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5550 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5551 (OTF_TAG_SYM): Omit macro if not needed.
5552 (ftfont_list): Remove unused local.
5553 (get_adstyle_property, ftfont_pattern_entity):
5554 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5555 Rename locals to avoid shadowing.
5556
5557 * xfont.c (xfont_list_family): Mark var as initialized.
5558
5559 * xml.c (make_dom): Now static.
5560
5561 * composite.c (composition_compute_stop_pos): Rename local to
5562 avoid shadowing.
5563 (composition_reseat_it): Remove unused locals.
5564 (find_automatic_composition, composition_adjust_point): Likewise.
5565 (composition_update_it): Mark var as initialized.
5566 (find_automatic_composition): Mark vars as initialized,
5567 with a FIXME (Bug#8290).
5568
5569 character.h: Rename locals to avoid shadowing.
5570 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5571 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5572 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5573 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5574 to avoid shadowing.
5575
5576 * textprop.c (property_change_between_p): Remove; unused.
5577
5578 * intervals.c (interval_start_pos): Now static.
5579
5580 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5581
5582 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5583 Rename locals to avoid shadowing.
5584
5585 * sound.c (wav_play, au_play, Fplay_sound_internal):
5586 Fix pointer signedness.
5587 (alsa_choose_format): Remove unused local var.
5588 (wav_play): Initialize a variable to 0, to prevent undefined
5589 behavior (Bug#8278).
5590
5591 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5592
5593 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5594
5595 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5596 clobbering (Bug#8298).
5597 * sysdep.c (sys_subshell): Likewise.
5598 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5599
5600 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5601 This should get cleaned up, so that child_setup has the
5602 same signature on all platforms.
5603
5604 * callproc.c (call_process_cleanup): Now static.
5605 (relocate_fd): Rename locals to avoid shadowing.
5606
5607 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5608
5609 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5610 not to be necessary, and produces flickering.
5611
5612 2011-03-20 Glenn Morris <rgm@gnu.org>
5613
5614 * config.in: Remove file.
5615
5616 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5617
5618 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5619 are now in src/globals.h.
5620 (syms_of_minibuf): Remove spurious & from previous change.
5621
5622 2011-03-20 Leo <sdl.web@gmail.com>
5623
5624 * minibuf.c (completing-read-function): New variable.
5625 (completing-read-default): Rename from completing-read.
5626 (completing-read): Call completing-read-function.
5627
5628 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5629
5630 * xfaces.c (Fx_load_color_file):
5631 Read color file from absolute filename (bug#8250).
5632
5633 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5634
5635 * makefile.w32-in: Update dependencies.
5636
5637 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5638
5639 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5640
5641 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5642
5643 Fix more problems found by GCC 4.5.2's static checks.
5644
5645 * process.c (make_serial_process_unwind, send_process_trap):
5646 (sigchld_handler): Now static.
5647
5648 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5649 That way, the code declares only the vars that it needs.
5650 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5651 * s/cygwin.h (PTY_ITERATION): Likewise.
5652 * s/darwin.h (PTY_ITERATION): Likewise.
5653 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5654
5655 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5656 * process.c (allocate_pty): Don't declare stb unless it's needed.
5657
5658 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5659 (CONSTANTLIM): Remove; unused.
5660 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5661 Define only if needed.
5662
5663 * unexelf.c (unexec): Name an expression,
5664 to avoid gcc -Wbad-function-cast warning.
5665 Use a different way to cause a compilation error if anyone uses
5666 n rather than nn, a way that does not involve shadowing.
5667 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5668
5669 * deps.mk (unexalpha.o): Remove; unused.
5670
5671 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5672 * unexec.h: New file.
5673 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5674 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5675 Depend on unexec.h.
5676 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5677 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5678 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5679 Change as necessary to match prototype in unexec.h.
5680
5681 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5682 shadowing.
5683 (back_comment, skip_chars): Mark vars as initialized.
5684
5685 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5686 Rename locals to avoid shadowing.
5687
5688 * lread.c (read1): Rewrite so as not to use empty "else".
5689 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5690
5691 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5692
5693 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5694 warning when compiling print.c.
5695
5696 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5697 instead of using an uninitialized var.
5698 (font_sort_entities): Mark var as initialized.
5699
5700 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5701
5702 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5703 pointers to constants.
5704 (font_parse_fcname): Remove unused vars.
5705 (font_delete_unmatched): Now static.
5706 (font_get_spec): Remove; unused.
5707 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5708 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5709 Rename or move locals to avoid shadowing.
5710
5711 * fns.c (require_nesting_list, require_unwind): Now static.
5712 (Ffillarray): Rename locals to avoid shadowing.
5713
5714 * floatfns.c (domain_error2): Define only if needed.
5715 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5716
5717 * alloc.c (mark_backtrace): Move decl from here ...
5718 * lisp.h: ... to here, so that it can be checked.
5719
5720 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5721 (Fdefvar): Rewrite so as not to use empty "else".
5722 (lisp_indirect_variable): Name an expression,
5723 to avoid gcc -Wbad-function-cast warning.
5724 (Fdefvar): Rename locals to avoid shadowing.
5725
5726 * callint.c (quotify_arg, quotify_args): Now static.
5727 (Fcall_interactively): Rename locals to avoid shadowing.
5728 Use const pointer when appropriate.
5729
5730 * lisp.h (get_system_name, get_operating_system_release):
5731 Move decls here, to check interfaces.
5732 * process.c (get_operating_system_release): Move decl to lisp.h.
5733 * xrdb.c (get_system_name): Likewise.
5734 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5735 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5736 some of which prompt warnings from gcc -Wbad-function-cast.
5737 (Fformat_time_string, Fencode_time, Finsert_char):
5738 (Ftranslate_region_internal, Fformat):
5739 Rename or remove local vars to avoid shadowing.
5740 (Ftranslate_region_internal): Mark var as initialized.
5741
5742 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5743 avoid shadowing.
5744
5745 * lisp.h (eassert): Check that the argument compiles, even if
5746 ENABLE_CHECKING is not defined.
5747
5748 * data.c (Findirect_variable): Name an expression, to avoid
5749 gcc -Wbad-function-cast warning.
5750 (default_value, arithcompare, arith_driver, arith_error): Now static.
5751 (store_symval_forwarding): Rename local to avoid shadowing.
5752 (Fmake_variable_buffer_local, Fmake_local_variable):
5753 Mark variables as initialized.
5754 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5755
5756 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5757 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5758 Rename locals to avoid shadowing.
5759 (mark_stack): Move local variables into the #ifdef region where
5760 they're used.
5761 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5762 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5763 needed otherwise.
5764 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5765 (GC_STRING_CHARS): Remove; not used.
5766 (Fmemory_limit): Cast sbrk's returned value to char *.
5767
5768 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5769 avoids undefined behavior in theory.
5770
5771 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5772
5773 Use functions, not macros, for up- and down-casing (Bug#8254).
5774 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5775 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5776 to use the following functions instead of these macros.
5777 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5778 EMACS_INT, since callers assume the returned value fits in int.
5779 (upcase1): Likewise, for UPCASE_TABLE.
5780 (uppercasep, lowercasep, upcase): New static inline functions.
5781 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5782 the race-condition problem in the old DOWNCASE.
5783
5784 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5785 Rename locals to avoid shadowing.
5786 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5787 (regex_compile, re_search_2, re_match_2_internal):
5788 Remove unused local vars.
5789 (FREE_VAR): Rewrite so as not to use empty "else",
5790 which gcc can warn about.
5791 (regex_compile, re_match_2_internal): Mark locals as initialized.
5792 (RETALLOC_IF): Define only if needed.
5793 (WORDCHAR_P): Likewise. This one is never needed, but is used
5794 only in a comment talking about a compiler bug, so put inside
5795 the #if 0 of that comment.
5796 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5797 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5798 Remove; unused.
5799
5800 * search.c (boyer_moore): Rename locals to avoid shadowing.
5801 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5802 (PREV_CHAR_BOUNDARY): Likewise.
5803
5804 * search.c (simple_search): Remove unused var.
5805
5806 * dired.c (compile_pattern): Move decl from here ...
5807 * lisp.h: ... to here, so that it can be checked.
5808 (struct re_registers): New forward decl.
5809
5810 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5811
5812 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5813 All uses changed.
5814 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5815 Rename locals to avoid shadowing.
5816 (Fvertical_motion): Mark locals as initialized.
5817
5818 * casefiddle.c (casify_object, casify_region): Now static.
5819 (casify_region): Mark local as initialized.
5820
5821 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5822
5823 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5824 New macros, so that the caller can use some names other than
5825 gcpro1, gcpro2, etc.
5826 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5827 of the new macros.
5828 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5829 argument, for consistency with GCPRO2_VAR, etc: it is now the
5830 prefix of the variable, not the variable itself. All uses
5831 changed.
5832 * dired.c (directory_files_internal, file_name_completion):
5833 Rename locals to avoid shadowing.
5834
5835 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5836 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5837 dired.c's scmp function, had undefined behavior.
5838 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5839 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5840 * buffer.h: ... to here, because these macros use current_buffer,
5841 and the new implementation with inline functions needs to have
5842 current_buffer in scope now, rather than later when the macros
5843 are used.
5844 (downcase, upcase1): New static inline functions.
5845 (DOWNCASE, UPCASE1): Reimplement using these functions.
5846 This avoids undefined behavior in expressions like
5847 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5848 from race conditions in accessing the global variables
5849 case_temp1 and case_temp2.
5850 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5851 * lisp.h (case_temp1, case_temp2): Remove their decls.
5852 * character.h (ASCII_CHAR_P): Move from here ...
5853 * lisp.h: ... to here, so that the inline functions mentioned
5854 above can use them.
5855
5856 * dired.c (directory_files_internal_unwind): Now static.
5857
5858 * fileio.c (file_name_as_directory, directory_file_name):
5859 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5860 Now static.
5861 (file_name_as_directory): Use const pointers when appropriate.
5862 (Fexpand_file_name): Likewise. In particular, newdir might
5863 point at constant storage, so make it a const pointer.
5864 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5865 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5866 signedness issues.
5867 (Fset_file_times, Finsert_file_contents, auto_save_error):
5868 Rename locals to avoid shadowing.
5869
5870 * minibuf.c (choose_minibuf_frame_1): Now static.
5871 (Ftry_completion, Fall_completions): Rename or remove locals
5872 to avoid shadowing.
5873
5874 * marker.c (bytepos_to_charpos): Remove; unused.
5875
5876 * lisp.h (verify_bytepos, count_markers): New decls,
5877 so that gcc does not warn that these functions aren't declared.
5878
5879 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5880 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5881 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5882 (copy_text): Remove unused local var.
5883
5884 * filelock.c (within_one_second): Now static.
5885 (lock_file_1): Rename local to avoid shadowing.
5886
5887 * buffer.c (fix_overlays_before): Mark locals as initialized.
5888 (fix_start_end_in_overlays): Likewise. This function should be
5889 simplified by using pointers-to-pointers, but that's a different
5890 matter.
5891 (switch_to_buffer_1): Now static.
5892 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5893 (report_overlay_modification): Rename locals to avoid shadowing.
5894
5895 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5896 Fix pointer signedness issue.
5897 (sys_subshell): Mark local as volatile if checking for lint,
5898 to suppress a gcc -Wclobbered warning that does not seem to be right.
5899 (MAXPATHLEN): Define only if needed.
5900
5901 * process.c (serial_open, serial_configure): Move decls from here ...
5902 * systty.h: ... to here, so that they can be checked.
5903
5904 * fns.c (get_random, seed_random): Move extern decls from here ...
5905 * lisp.h: ... to here, so that they can be checked.
5906
5907 * sysdep.c (reset_io): Now static.
5908 (wait_for_termination_signal): Remove; unused.
5909
5910 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5911 (copy_keymap_item, append_key, push_text_char_description):
5912 Now static.
5913 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5914 (DENSE_TABLE_SIZE): Remove; unused.
5915 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5916 (describe_map_tree):
5917 Rename locals to avoid shadowing.
5918
5919 * keyboard.c: Declare functions static if they are not used elsewhere.
5920 (echo_char, echo_dash, cmd_error, top_level_2):
5921 (poll_for_input, handle_async_input): Now static.
5922 (read_char, kbd_buffer_get_event, make_lispy_position):
5923 (make_lispy_event, make_lispy_movement, apply_modifiers):
5924 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5925 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5926 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5927 (read_key_sequence, read_char): Mark locals as initialized.
5928 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5929
5930 * keyboard.h (make_ctrl_char): New decl.
5931 (mark_kboards): Move decl here ...
5932 * alloc.c (mark_kboards): ... from here.
5933
5934 * lisp.h (force_auto_save_soon): New decl.
5935
5936 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5937 (DEFINE_DUMMY_FUNCTION): New macro.
5938 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5939 Use it.
5940 (main): Add casts to avoid warnings
5941 if GCC considers string literals to be constants.
5942
5943 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5944
5945 * dbusbind.c: Pointer signedness fixes.
5946 (xd_signature, xd_append_arg, xd_initialize):
5947 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5948 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5949 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5950 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5951
5952 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5953 if GCC considers string literals to be constants.
5954 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5955
5956 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5957
5958 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5959 (print_preprocess, print_object): New macro to fix last change.
5960
5961 * print.c (print_preprocess): Don't forget font objects.
5962
5963 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5964
5965 * emacs.c (USAGE3): Doc fixes.
5966
5967 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5968
5969 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5970 structure.
5971
5972 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5973
5974 * lisp.h (VWindow_system, Qfile_name_history):
5975 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5976 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5977 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5978
5979 * w32select.c: Don't #include "keyboard.h".
5980 (run_protected): Add extern declaration for waiting_for_input.
5981
5982 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5983 * w32console.c (detect_input_pending, read_input_pending)
5984 (encode_terminal_code):
5985 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5986 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5987 (w32_system_caret_y, Qfile_name_history):
5988 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5989 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5990 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5991 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5992 * w32proc.c (Qlocal, report_file_error):
5993 * w32term.c (Vwindow_system, updating_frame):
5994 * w32uniscribe.c (initialized, uniscribe_font_driver):
5995 Remove unneeded extern declarations.
5996
5997 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5998
5999 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6000
6001 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6002
6003 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6004 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6005 These macros can no longer be used for assignment.
6006
6007 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6008 Assign struct members directly, instead of using BUF_BEGV etc.
6009 (record_buffer_markers, fetch_buffer_markers): New functions for
6010 recording and fetching special buffer markers.
6011 (set_buffer_internal_1, set_buffer_temp): Use them.
6012
6013 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6014
6015 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6016
6017 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6018 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6019
6020 * xdisp.c (hscroll_window_tree):
6021 (reconsider_clip_changes): Use PT instead of BUF_PT.
6022
6023 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6024
6025 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6026 $(EMACS_ROOT)/lib/intprops.h.
6027
6028 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6029
6030 Fix more problems found by GCC 4.5.2's static checks.
6031
6032 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6033 to unsigned char * to avoid compiler diagnostic.
6034 (xg_free_frame_widgets): Make it clear that a local variable is
6035 needed only if USE_GTK_TOOLTIP.
6036 (gdk_window_get_screen): Make it clear that this macro is needed
6037 only if USE_GTK_TOOLTIP.
6038 (int_gtk_range_get_value): New function, which avoids a diagnostic
6039 from gcc -Wbad-function-cast.
6040 (xg_set_toolkit_scroll_bar_thumb): Use it.
6041 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6042 diagnostic from gcc -Wbad-function-cast.
6043 (get_utf8_string, xg_get_file_with_chooser):
6044 Rename locals to avoid shadowing.
6045 (create_dialog): Move locals to avoid shadowing.
6046
6047 * xgselect.c (xg_select): Remove unused var.
6048
6049 * image.c (four_corners_best): Mark locals as initialized.
6050 (gif_load): Initialize transparent_p to zero (Bug#8238).
6051 Mark another local as initialized.
6052 (my_png_error, my_error_exit): Mark with NO_RETURN.
6053
6054 * image.c (clear_image_cache): Now static.
6055 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6056 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6057 (x_edge_detection): Remove unnecessary cast that
6058 gcc -Wbad-function-cast diagnoses.
6059 (gif_load): Fix pointer signedness.
6060 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6061 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6062
6063 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6064
6065 Improve quality of tests for time stamp overflow.
6066 For example, without this patch (encode-time 0 0 0 1 1
6067 1152921504606846976) returns the obviously-bogus value (-948597
6068 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6069 reports time overflow. See
6070 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6071 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6072 * editfns.c: Include limits.h and intprops.h.
6073 (TIME_T_MIN, TIME_T_MAX): New macros.
6074 (time_overflow): Move earlier, to before first use.
6075 (hi_time, lo_time): New functions, for an accurate test for
6076 out-of-range times.
6077 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6078 (Fget_internal_run_time): Don't assume time_t fits in int.
6079 (make_time): Use list2 instead of Fcons twice.
6080 (Fdecode_time): More accurate test for out-of-range times.
6081 (check_tm_member): New function.
6082 (Fencode_time): Use it, to test for out-of-range times.
6083 (lisp_time_argument): Don't rely on undefined left-shift and
6084 right-shift behavior when checking for time stamp overflow.
6085
6086 * editfns.c (time_overflow): New function, refactoring common code.
6087 (Fformat_time_string, Fdecode_time, Fencode_time):
6088 (Fcurrent_time_string): Use it.
6089
6090 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6091 * dired.c (make_time): Move to ...
6092 * editfns.c (make_time): ... here.
6093 * systime.h: Note the move.
6094
6095 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6096
6097 * fringe.c (update_window_fringes): Remove unused variables.
6098
6099 * unexmacosx.c (copy_data_segment): Also copy __got section.
6100 (Bug#8223)
6101
6102 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6103
6104 * termcap.c [MSDOS]: Include "msdos.h".
6105 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6106 Constify `char *' arguments and their references according to
6107 prototypes in tparam.h.
6108
6109 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6110
6111 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6112 Adapt all references accordingly.
6113
6114 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6115
6116 2011-03-11 Tom Tromey <tromey@redhat.com>
6117
6118 * buffer.c (syms_of_buffer): Remove obsolete comment.
6119
6120 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6121
6122 * termhooks.h (encode_terminal_code): Declare prototype.
6123
6124 * msdos.c (encode_terminal_code): Don't declare prototype.
6125
6126 * term.c (encode_terminal_code): Now external again, used by
6127 w32console.c and msdos.c.
6128
6129 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6130 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6131
6132 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6133
6134 Fix some minor problems found by GCC 4.5.2's static checks.
6135
6136 * fringe.c (update_window_fringes): Mark locals as initialized
6137 (Bug#8227).
6138 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6139
6140 * alloc.c (mark_fringe_data): Move decl from here ...
6141 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6142 to check its interface.
6143 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6144
6145 * fontset.c (free_realized_fontset): Now static.
6146 (Fset_fontset_font): Rename local to avoid shadowing.
6147 (fontset_font): Mark local as initialized.
6148 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6149
6150 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6151
6152 * xselect.c (x_disown_buffer_selections): Remove; not used.
6153 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6154 (x_own_selection, Fx_disown_selection_internal): Rename locals
6155 to avoid shadowing.
6156 (x_handle_dnd_message): Remove local to avoid shadowing.
6157
6158 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6159 so that the caller can use some name other than gcpro1.
6160 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6161 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6162 (Fx_backspace_delete_keys_p):
6163 Use them to avoid shadowing, and rename vars to avoid shadowing.
6164 (x_decode_color, x_set_name, x_window): Now static.
6165 (Fx_create_frame): Add braces to silence GCC warning.
6166 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6167 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6168 Remove unused locals.
6169 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6170 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6171 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6172 macros.
6173
6174 * xterm.h (x_mouse_leave): New decl.
6175
6176 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6177 Remove unused functions.
6178 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6179 (x_calc_absolute_position): Now static.
6180 (XTread_socket): Don't define label "out" unless it's used.
6181 Don't declare local "event" unless it's used.
6182 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6183 unless they are used.
6184 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6185 (x_fatal_error_signal): Remove; not used.
6186 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6187 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6188 (x_error_catcher, x_connection_closed, x_error_handler):
6189 (x_error_quitter, xembed_send_message, x_iconify_frame):
6190 (my_log_handler): Rename locals to avoid shadowing.
6191 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6192 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6193
6194 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6195 Rename or move locals to avoid shadowing.
6196 (tty_defined_color, merge_face_heights): Now static.
6197 (free_realized_faces_for_fontset): Remove; not used.
6198 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6199 does not deduce is never used uninitialized.
6200 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6201 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6202
6203 * terminal.c (store_terminal_param): Now static.
6204
6205 * xmenu.c (menu_highlight_callback): Now static.
6206 (set_frame_menubar): Remove unused local.
6207 (xmenu_show): Rename parameter to avoid shadowing.
6208 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6209 since they might point to immutable storage.
6210 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6211 since it's unused otherwise.
6212
6213 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6214 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6215 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6216 avoids a gcc -Wuninitialized diagnostic.
6217 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6218 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6219 does not deduce are never used uninitialized.
6220
6221 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6222
6223 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6224 * window.c (window_loop, size_window):
6225 (run_window_configuration_change_hook, enlarge_window): Likewise.
6226
6227 * window.c (display_buffer): Now static.
6228 (size_window): Mark variables that gcc -Wuninitialized
6229 does not deduce are never used uninitialized.
6230 * window.h (check_all_windows): New decl, to forestall
6231 gcc -Wmissing-prototypes diagnostic.
6232 * dispextern.h (bidi_dump_cached_states): Likewise.
6233
6234 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6235 shadowing.
6236 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6237 Include <limits.h>.
6238 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6239 and to avoid gcc -Wuninitialized warning.
6240 (load_charset_map): Mark variables that gcc -Wuninitialized
6241 does not deduce are never used uninitialized.
6242 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6243
6244 * coding.c (coding_set_source, coding_set_destination):
6245 Use "else { /* comment */ }" rather than "else /* comment */;"
6246 for clarity, and to avoid gcc -Wempty-body warning.
6247 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6248 a block, when the outer 'i' will do.
6249 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6250 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6251 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6252 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6253 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6254 Rename locals to avoid shadowing.
6255 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6256 * coding.c (emacs_mule_char, encode_invocation_designation):
6257 Now static, since they're not used elsewhere.
6258 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6259 (decode_coding_object, encode_coding_object, detect_coding_system):
6260 (decode_coding_emacs_mule): Mark variables that gcc
6261 -Wuninitialized does not deduce are never used uninitialized.
6262 (detect_coding_iso_2022): Initialize a local variable that might
6263 be used uninitialized. Leave a FIXME because it's not clear that
6264 this initialization is needed. (Bug#8211)
6265 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6266 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6267 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6268 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6269 Remove unused macros.
6270
6271 * category.c (hash_get_category_set): Remove unused local var.
6272 (copy_category_table): Now static, since it's not used elsewhere.
6273 * character.c (string_count_byte8): Likewise.
6274
6275 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6276 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6277
6278 * chartab.c (copy_sub_char_table): Now static, since it's not used
6279 elsewhere.
6280 (sub_char_table_ref_and_range, char_table_ref_and_range):
6281 Rename locals to avoid shadowing.
6282 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6283
6284 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6285 (BIDI_BOB): Remove unused macro.
6286
6287 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6288 deduce are never used uninitialized.
6289 * term.c (encode_terminal_code): Likewise.
6290
6291 * term.c (encode_terminal_code): Now static. Remove unused local.
6292
6293 * tparam.h: New file.
6294 * term.c, tparam.h: Include it.
6295 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6296 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6297 Move these decls to tparam.h, and make them agree with what
6298 is actually in tparam.c. The previous trick of using incompatible
6299 decls in different modules does not conform to the C standard.
6300 All callers of tparam changed to use tparam's actual API.
6301 * tparam.c (tparam1, tparam, tgoto):
6302 Use const pointers where appropriate.
6303
6304 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6305 * cm.h (struct cm): Likewise.
6306 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6307 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6308 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6309 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6310 (turn_on_face, init_tty): Likewise.
6311 * termchar.h (struct tty_display_info): Likewise.
6312
6313 * term.c (term_mouse_position): Rename local to avoid shadowing.
6314
6315 * alloc.c (mark_ttys): Move decl from here ...
6316 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6317
6318 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6319
6320 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6321
6322 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6323
6324 * search.c (compile_pattern_1): Remove argument regp, unused since
6325 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6326 (compile_pattern): Don't pass it.
6327
6328 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6329
6330 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6331 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6332 for ! HAVE_GTK3.
6333 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6334
6335 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6336
6337 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6338 gdk_window_get_screen, gdk_window_get_geometry,
6339 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6340 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6341 (xg_get_pixbuf_from_pixmap): New function.
6342 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6343 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6344 Call xg_get_pixbuf_from_pixmap instead of
6345 gdk_pixbuf_get_from_drawable.
6346 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6347 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6348 (xg_check_special_colors): Use GtkStyleContext and its functions
6349 for HAVE_GTK3.
6350 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6351 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6352 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6353 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6354 Call gtk_widget_get_preferred_size.
6355 (xg_frame_resized): gdk_window_get_geometry only takes 5
6356 parameters.
6357 (xg_win_to_widget, xg_event_is_for_menubar):
6358 Call gdk_x11_window_lookup_for_display.
6359 (xg_set_widget_bg): New function.
6360 (delete_cb): New function.
6361 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6362 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6363 (xg_set_background_color): Call xg_set_widget_bg.
6364 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6365 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6366 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6367 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6368 if ! HAVE_GTK3.
6369 (update_frame_tool_bar): Call gtk_widget_hide.
6370 (xg_initialize): Use GDK_KEY_g.
6371
6372 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6373 if ! HAVE_GTK3
6374 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6375
6376 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6377 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6378 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6379
6380 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6381
6382 * w32xfns.c (select_palette): Check success of RealizePalette against
6383 GDI_ERROR, not zero.
6384
6385 See ChangeLog.11 for earlier changes.
6386
6387 ;; Local Variables:
6388 ;; coding: utf-8
6389 ;; End:
6390
6391 Copyright (C) 2011 Free Software Foundation, Inc.
6392
6393 This file is part of GNU Emacs.
6394
6395 GNU Emacs is free software: you can redistribute it and/or modify
6396 it under the terms of the GNU General Public License as published by
6397 the Free Software Foundation, either version 3 of the License, or
6398 (at your option) any later version.
6399
6400 GNU Emacs is distributed in the hope that it will be useful,
6401 but WITHOUT ANY WARRANTY; without even the implied warranty of
6402 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6403 GNU General Public License for more details.
6404
6405 You should have received a copy of the GNU General Public License
6406 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.