1 2012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
3 Explicitly free restriction data that are not needed anymore.
4 * editfns.c (save_restriction_restore): Free restriction data.
6 2012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
8 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
9 add argument, tune behavior, and adjust all callers.
11 2012-07-25 Paul Eggert <eggert@cs.ucla.edu>
13 Use typedef for EMACS_INT, EMACS_UINT.
14 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
15 than macros. This simplifies debugging in the usual case, since
16 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
17 and it allows expressions involving EMACS_INT casts.
18 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
20 2012-07-25 Jan Djärv <jan.h.d@swipnet.se>
22 * nsterm.m (ns_read_socket): Return early if there is a modal
25 2012-07-25 Martin Rudalics <rudalics@gmx.at>
27 * frame.c (Fredirect_frame_focus): In doc-string don't mention
28 that FOCUS-FRAME can be omitted.
30 2012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
32 Adjust buffer text indirection counters at the end of Fkill_buffer.
33 * buffer.c (Fkill_buffer): Adjust indirection counters when the
34 buffer is definitely dead. This should really fix an issue reported
35 by Christoph Scholtes again. (Bug#12007).
36 (init_buffer_once): Initialize indirection counters of
37 buffer_defaults and buffer_local_symbols (for sanity and safety).
39 2012-07-24 Eli Zaretskii <eliz@gnu.org>
41 * xdisp.c (init_iterator): Don't compute dimensions of truncation
42 and continuation glyphs on tooltip frames, leave them at zero.
43 Avoids continued lines in tooltips. (Bug#11832)
45 2012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
47 Simplify copy_overlay.
48 * buffer.c (copy_overlay): Simplify. Use build_marker.
49 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
51 2012-07-23 Eli Zaretskii <eliz@gnu.org>
53 * print.c (print_object): Don't crash when a frame's name is nil
54 or invalid. (Bug#12025)
56 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
57 it signals an error when a tooltip frame is being created.
59 2012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
61 Cleanup miscellaneous objects allocation and initialization.
62 * alloc.c (allocate_misc): Change to static. Add argument to
63 specify the subtype. Adjust comment and users.
64 (build_overlay): New function.
65 * buffer.c (copy_overlays, Fmake_overlay): Use it.
66 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
67 (allocate_misc): Remove prototype.
68 (build_overlay): Add prototype.
70 2012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
72 Swap buffer text indirection counters in Fbuffer_swap_text.
73 * buffer.c (Fbuffer_swap_text): Swap indirections too.
74 This avoids crash reported by Christoph Scholtes at
75 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
77 2012-07-22 Jan Djärv <jan.h.d@swipnet.se>
79 * nsmenu.m (Popdown_data): New struct.
80 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
82 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
83 (initWithContentRect): Make imgView and contentView non-static
84 and autorelease them. Also autorelease img and matrix (Bug#12005).
85 (dealloc): Remove (Bug#12005).
87 2012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
89 Adjust consing_since_gc when objects are explicitly freed.
90 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
91 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
92 (free_cons, free_misc): Subtract object size from consing_since_gc.
94 2012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
96 Simplify and cleanup markers positioning code.
97 * marker.c (attach_marker): More useful eassert.
98 (live_buffer, set_marker_internal): New function.
99 (Fset_marker, set_marker_restricted): Use set_marker_internal.
100 (set_marker_both, set_marker_restricted_both): Use live_buffer.
102 2012-07-22 Paul Eggert <eggert@cs.ucla.edu>
104 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
105 as it's limited by the amount of memory, not by INT_MAX.
107 2012-07-21 Eli Zaretskii <eliz@gnu.org>
109 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
110 in special-event-map. See the discussion at
111 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
114 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
115 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
116 Fabrice Popineau <fabrice.popineau@supelec.fr>.
118 2012-07-21 Jan Djärv <jan.h.d@swipnet.se>
120 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
121 (conversationIdentifier): Return value is NSInteger.
122 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
124 2012-07-21 Chong Yidong <cyd@gnu.org>
126 * window.c (decode_any_window): Signal an error if the window is
127 on a dead frame (Bug#11984).
129 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
131 Add indirection counting to speed up Fkill_buffer.
132 * buffer.h (struct buffer): New member.
133 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
134 (Fmake_indirect_buffer): Set indirection counter to -1, increment
135 base buffer indirection counter.
136 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
137 (Fkill_buffer): Adjust indirection counters as needed, don't walk
138 through buffer list if indirection counter is 0.
140 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
142 Extend the value returned by Fgarbage_collect with heap statistics.
143 * alloc.c (Qheap): New symbol.
144 (syms_of_alloc): DEFSYM it.
145 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
146 (Fmemory_free): Remove.
147 (syms_of_alloc): Don't defsubr it.
148 * buffer.c (Fcompact_buffer): Remove.
149 (syms_of_buffer): Don't defsubr it.
151 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
153 Make maybe_gc inline.
154 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
155 * lisp.h (consing_since_gc, gc_relative_threshold)
156 (memory_full_cons_threshold): Revert declaration.
157 (maybe_gc): Remove prototype, define as inline.
158 * alloc.c: Remove old commented-out code.
159 (consing_since_gc, gc_relative_threshold)
160 (memory_full_cons_threshold): Revert to global.
163 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
165 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
166 * lisp.h (build_unibyte_string): New function.
167 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
168 * sysdep.c, w32fns.c, xfns.c: Use it.
169 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
170 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
171 Adjust users accordingly.
172 * font.h (font_open_by_name): Adjust prototype.
174 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
176 Cleanup calls to Fgarbage_collect.
177 * lisp.h (maybe_gc): New prototype.
178 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
180 * alloc.c (maybe_gc): New function.
181 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
183 * bytecode.c (MAYBE_GC): Use maybe_gc.
184 * eval.c (eval_sub, Ffuncall): Likewise.
185 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
186 to avoid dependency from auto-save feature.
188 2012-07-19 Paul Eggert <eggert@cs.ucla.edu>
190 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
191 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
192 'for_each_per_buffer_object_at'.
193 All uses changed. It's better to use upper-case for macros that
194 cannot be implemented as functions, to give the reader a clue
195 that they're special.
197 2012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
199 * alloc.c (Fgarbage_collect): Tweak docstring.
201 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
203 Tweak the value returned from Fgarbage_collect again.
204 * alloc.c (Fgarbage_collect): New return value, as confirmed in
205 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
206 Adjust documentation.
207 (total_vector_bytes): Rename to total_vector_slots, adjust
209 (total_free_vector_bytes): Rename to total_free_vector_slots,
211 (Qstring_bytes, Qvector_slots): New symbols.
212 (syms_of_alloc): DEFSYM them.
214 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
216 Buffer compaction primitive which may be used from Lisp.
217 * buffer.c (compact_buffer, Fcompact_buffer): New function.
218 (syms_of_buffer): Register Fcompact_buffer.
219 * alloc.c (Fgarbage_collect): Use compact_buffer.
220 * buffer.h (compact_buffer): New prototype.
221 (struct buffer_text): New member.
223 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
225 New macro to iterate over all buffers, miscellaneous cleanups.
226 * lisp.h (all_buffers): Remove declaration.
227 * buffer.h (all_buffers): Add declaration, with comment.
228 (for_each_buffer): New macro.
229 * alloc.c (Fgarbage_collect, mark_object): Use it.
230 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
231 (init_buffer): Likewise.
232 * data.c (Fset_default): Likewise.
233 * coding.c (code_conversion_restore): Remove redundant check
235 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
237 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
239 Fix bug that created negative-length intervals.
240 * intervals.c (merge_interval_right, merge_interval_left):
241 Do not zero out this interval if it is absorbed by its children,
242 as this interval's total length doesn't change in that case. See
243 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
245 2012-07-18 Paul Eggert <eggert@cs.ucla.edu>
247 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
248 when invoking (make-bool-vector N t) and N is a positive
249 multiple of 8 -- the last 8 bits were mistakenly cleared.
251 Remove some struct layout assumptions in bool vectors.
252 * alloc.c (bool_header_size): New constant.
253 (header_size, word_size): Move earlier, as they're now used earlier.
254 Use 'word_size' in a few more places, where it's appropriate.
255 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
256 padding before the data member of a bool vector.
257 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
258 than doing the check by hand with an abort ().
260 2012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
262 * eval.c (Fdefvar): Don't check constants since we only set the var if
263 it's not yet defined anyway (bug#11904).
265 * lisp.h (last_undo_boundary): Declare new var.
266 * keyboard.c (command_loop_1): Set it.
267 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
268 were auto-added by the command loop (bug#11774).
270 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
272 * w32font.c (Qsymbol): Remove local definition.
273 (syms_of_w32font): Don't DEFSYM it.
275 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
277 Fix sweep_vectors to handle large bool vectors correctly.
278 * alloc.c (sweep_vectors): Account total_vector_bytes for
279 bool vectors larger than VBLOCK_BYTES_MAX.
281 2012-07-18 Chong Yidong <cyd@gnu.org>
283 * frame.c (x_set_frame_parameters): Revert bogus change introduced
284 in 2012-05-25 commit by Paul Eggert (Bug#11738).
286 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
288 Return more descriptive data from Fgarbage_collect.
289 Suggested by Stefan Monnier in
290 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
291 * alloc.c (bounded_number): New function.
292 (total_buffers, total_vectors): New variable.
293 (total_string_size): Rename to total_string_bytes, adjust users.
294 (total_vector_size): Rename to total_vector_bytes, adjust users.
295 (sweep_vectors): Account total_vectors and total_vector_bytes.
296 (Fgarbage_collect): New return value. Adjust documentation.
297 (gc_sweep): Account total_buffers.
298 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
299 (VECTOR_SIZE): Remove.
300 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
301 (Qinterval, Qmisc): New symbols.
302 (syms_of_data): Initialize them.
303 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
304 (Qcons, Qbuffer): New declarations.
306 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
308 * alloc.c (Fmemory_free): Account for memory-free's own storage.
309 Round up, not down. Improve doc.
311 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
313 Restore old code in allocate_string_data to avoid Faset breakage.
314 Reported by Julien Danjou <julien@danjou.info> in
315 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
316 * alloc.c (allocate_string_data): Restore old code with minor
317 adjustments, fix comment to explain this subtle issue.
319 2012-07-17 Eli Zaretskii <eliz@gnu.org>
321 Remove FILE_SYSTEM_CASE.
322 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
324 * fileio.c (FILE_SYSTEM_CASE): Don't define.
325 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
326 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
327 call-process-region passes it through expand-file-name.
329 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
331 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
333 Fix crash when creating indirect buffer (Bug#11917)
334 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
335 Don't handle unbound variables specially if non-zero.
336 (Fbuffer_local_variables): Pass zero.
337 (clone_per_buffer_values): Pass non-zero.
339 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
341 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
342 to make the loop interruptible.
344 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
346 * gnutls.c (emacs_gnutls_handshake): Only retry if
347 GNUTLS_E_INTERRUPTED.
349 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
351 Cleanup and convert miscellaneous checks to eassert.
352 * alloc.c (mark_interval): Fix comment, partially rephrase
353 old comment from intervals.h (see below).
354 * intervals.c (find_interval, adjust_intervals_for_insertion)
355 (delete_interval, adjust_intervals_for_deletion)
356 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
358 (adjust_intervals_for_insertion, make_new_interval):
359 Remove obsolete and unused code.
360 * intervals.h (struct interval): Remove obsolete comment.
361 * textprotp.c (erase_properties): Remove unused code.
362 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
363 (Fremove_list_of_text_properties): Convert to eassert.
365 2012-07-17 Chong Yidong <cyd@gnu.org>
367 * editfns.c (Finsert_char): Doc fix.
369 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
371 Fix previous change to make Fmemory_free always accurate.
372 * alloc.c (make_interval): Update total_free_intervals.
373 (make_float): Likewise for total_free_floats.
374 (free_cons, Fcons): Likewise for total_free_conses.
375 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
376 Likewise for total_free_vector_bytes.
377 (Fmake_symbol): Likewise for total_free_symbols.
378 (bytes_free): Remove.
380 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
382 Simple free memory accounting feature.
383 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
384 (sweep_vectors): Accumulate size of free vectors.
385 (Fgarbage_collect): Setup bytes_free.
386 (Fmemory_free): New function.
387 (syms_of_alloc): Register it.
389 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
391 Cleanup overlays checking.
392 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
393 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
394 eassert and OVERLAYP.
395 (sort_overlays): Change to use OVERLAYP.
397 2012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
399 * editfns.c (Finsert_char): Make it interactive, and make the
400 second arg optional. Copy interactive spec and docstring from
403 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
405 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
406 Unlike the other wrapped functions, fabs has an unspecified
409 2012-07-16 Jan Djärv <jan.h.d@swipnet.se>
411 * nsterm.m (keyDown): Interpret flags without left/right bits
412 as the left key (Bug#11670).
414 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
416 Remove empty and useless init functions.
417 * lisp.h (init_character_once, init_fns, init_image)
418 (init_filelock, init_sound): Remove prototype.
419 * character.c (init_character_once): Remove.
420 * filelock.c (init_filelock): Likewise.
421 * fns.c (init_fns): Likewise.
422 * image.c (init_image): Likewise.
423 * sound.c (init_sound): Likewise.
424 * emacs.c (main): Adjust accordingly.
426 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
428 * gtkutil.h: Tiny cleanups.
429 (use_old_gtk_file_dialog): Remove useless declaration.
430 (xg_uses_old_file_dialog): Add suggested const attribute.
432 2012-07-15 Eli Zaretskii <eliz@gnu.org>
434 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
435 (bidi_paragraph_init): Use it to limit search forward for a strong
436 directional character in abnormally large paragraphs full of
437 neutral or weak characters. (Bug#11943)
439 2012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
441 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
442 the toolbar (Bug#9451).
443 (xg_make_tool_item): Give the widget event box a transparent
446 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
448 Cleanup basic allocation variables and functions.
449 * alloc.c (ignore_warnings, init_intervals, init_float)
450 (init_cons, init_symbol, init_marker): Remove.
451 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
452 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
453 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
454 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
455 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
456 (staticidx, init_alloc_once, init_strings, free_ablock):
457 Remove redundant initialization.
458 * fns.c (init_weak_hash_tables): Remove.
459 * lisp.h (init_weak_hash_tables): Remove prototype.
461 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
463 Use zero_vector where appropriate.
464 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
466 * lisp.h (zero_vector): New declaration.
467 * font.c (null_vector): Remove.
468 (syms_of_font): Remove initialization and staticpro.
469 (font_list_entities, font_find_for_lface): Change to use zero_vector.
470 * keymap.c (Faccessible_keymaps): Likewise.
472 2012-07-15 Leo Liu <sdl.web@gmail.com>
474 * fringe.c: Fix typo in comments.
476 2012-07-14 Leo Liu <sdl.web@gmail.com>
478 * fringe.c: Add a new bitmap exclamation-mark.
480 2012-07-14 Eli Zaretskii <eliz@gnu.org>
482 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
484 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
485 (HAVE_MENUS): Don't define, defined by editing config.in with
487 (GMALLOC_INHIBIT_VALLOC): Don't define.
488 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
490 2012-07-14 Juanma Barranquero <lekktu@gmail.com>
492 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
494 2012-07-14 Glenn Morris <rgm@gnu.org>
496 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
497 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
498 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
500 2012-07-13 Glenn Morris <rgm@gnu.org>
502 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
504 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
505 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
507 2012-07-13 Jan Djärv <jan.h.d@swipnet.se>
509 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
510 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
511 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
512 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
514 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
515 as boolean expression.
516 (x_set_window_size): Remove unused variable toolbar.
517 (ns_get_color_default, ns_mod_to_lisp): Remove.
518 (ns_mouse_position): Remove unused variables xchar and ychar.
519 (ns_compute_glyph_string_overhangs): Remove unused variable face.
520 (ns_set_vertical_scroll_bar): Remove unused variable count.
521 (ns_delete_terminal): Remove unused variable i.
522 (ns_term_init): Remove unused variables r, g and b.
523 (mouseDown): Remove unused variable window.
524 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
525 (initFrameFromEmacs): Remove unused variable vbextra.
526 (mouseEntered): Remove unused variables p and dpyinfo.
527 (mouseExited): Remove unused variables p and r.
528 (ns_define_frame_cursor, ns_clear_frame_area)
529 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
530 (menuDown): Assign [sender tag] to variable and cast the variable.
532 * nsterm.h (menuDown): Add id as type to argument sender.
533 (ns_display_info_for_name): Add Lisp_Object argument.
534 (ns_term_init): Add Lisp_Object argument.
535 (ns_map_event_to_object): Add void argument.
536 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
537 prototype with arguments and only declare if __OBJC__.
538 (nxatoms_of_nsselect): Add void argument.
539 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
540 (ns_alloc_autorelease_pool): Add void argument.
541 (ns_release_autorelease_pool): Add void* argument.
542 (ns_get_defaults_value): Add const char* argument.
544 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
545 (initFromContents): Use SSDATA where appropriate.
546 (ns_update_menubar): Add braces to ambigous if-else.
547 (initWithTitle): Put () around assignment in if statement.
548 (ns_menu_show): Remove unused variables window and keymap.
549 (update_frame_tool_bar): Remove unused variable selected_p.
550 (initWithContentRect): Remove unused variable this_cmd_name.
552 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
554 (setXBMColor): Remove unused variable len.
555 (setPixmapData): Put () around assignment in loop statement.
557 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
558 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
560 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
561 around assignment in loop statement.
562 (nsfont_open): Remove unused variable i.
563 (nsfont_open): Remove unused variable len.
564 (nsfont_draw): Remove unused variable cs.
566 * nsfns.m (x_set_icon_name, ns_set_name_internal)
567 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
568 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
569 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
570 (Fns_font_name, Fns_perform_service)
571 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
572 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
573 (ns_set_name): Remove unused variable view.
574 (x_set_menu_bar_lines): Remove unused variable olines.
575 (x_set_tool_bar_lines): Remove unused variable root_window.
576 (Fns_list_colors): Put () around assignment in while statement.
577 (Fns_perform_service): Remove unused variable len.
578 (Fns_display_usable_bounds): Remove unused variable top.
579 (syms_of_nsfns): Remove unused variable i.
581 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
584 2012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
586 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
587 and free it with DestroyExceptionInfo (Bug#11558).
589 2012-07-13 Juanma Barranquero <lekktu@gmail.com>
591 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
592 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
593 Set here, not in nt/config.nt.
595 2012-07-13 Eli Zaretskii <eliz@gnu.org>
597 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
598 cursor overflow into the last glyph on display line when the right
599 fringe is off. (Bug#11832)
601 2012-07-13 Paul Eggert <eggert@cs.ucla.edu>
603 * xdisp.c (produce_special_glyphs): Now static.
604 * dispextern.h (produce_special_glyphs): Remove decl.
606 2012-07-13 Glenn Morris <rgm@gnu.org>
608 * s/bsd-common, s/cygwin.h: Remove empty files.
609 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
611 * s/usg5-4-common.h (USG, USG5):
612 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
613 * s/sol2-6.h (SOLARIS2):
614 * s/irix6-5.h (IRIX6_5):
615 * s/hpux10-20.h (USG, USG5, HPUX):
616 * s/gnu-linux.h (USG, GNU_LINUX):
617 * s/freebsd.h (BSD_SYSTEM):
618 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
619 * s/cygwin.h (CYGWIN):
620 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
621 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
623 2012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
625 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
627 2012-07-13 Glenn Morris <rgm@gnu.org>
629 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
631 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
633 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
634 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
636 2012-07-12 Glenn Morris <rgm@gnu.org>
638 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
640 * process.c (init_process_emacs): Rename from init_process.
641 The old name is also the name of a Mach system call.
642 * lisp.h, emacs.c: Update for this name change.
643 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
646 2012-07-12 Eli Zaretskii <eliz@gnu.org>
648 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
649 memmove call that removes glyphs covered by the left truncation
650 glyph. Improve commentary.
651 (display_line): Fix display of continuation glyphs on GUI frames
652 when the right fringe is turned off and variable-size fonts are
653 used in the window. Move the code that appends a stretch glyph to
654 produce_special_glyphs, so that it could be used for truncation
655 and continuation glyphs alike.
656 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
657 glyph of a suitably computed width, to align the special glyphs at
658 the window margin. Code moved from display_line. (Bug#11832)
660 2012-07-12 Glenn Morris <rgm@gnu.org>
662 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
664 * s/gnu-linux.h, s/hpux10-20.h:
665 Do not unconditionally define HAVE_XRMSETDATABASE.
667 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
669 2012-07-12 Paul Eggert <eggert@cs.ucla.edu>
671 Fix typos that broke OS X build.
672 Reported by Randal L. Schwartz in
673 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
674 * nsterm.m (ns_timeout): Add missing local decl.
675 (ns_get_color): snprintf -> sprintf, to fix typo.
677 2012-07-12 Glenn Morris <rgm@gnu.org>
679 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
680 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
681 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
682 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
684 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
685 Move PTY_OPEN to configure.
687 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
688 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
689 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
691 2012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
693 Use empty_unibyte_string where applicable.
694 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
695 * lread.c (read1): Likewise.
696 * xsettings.c (syms_of_xsettings): Likewise.
698 2012-07-12 Glenn Morris <rgm@gnu.org>
700 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
701 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
702 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
703 * s/hpux10-20.h (RUN_TIME_REMAP):
704 * s/bsd-common.h (TABDLY): Move to configure.
706 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
708 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
710 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
711 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
713 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
715 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
716 * s/template.h: Move NARROWPROTO to configure.
718 2012-07-11 Glenn Morris <rgm@gnu.org>
720 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
721 unused since 2011-01-17 change to systty.h.
723 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
724 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
725 Move HAVE_PTYS and HAVE_SOCKETS to configure.
727 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
729 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
731 2012-07-11 Glenn Morris <rgm@gnu.org>
733 * s/darwin.h, s/gnu-linux.h, s/template.h:
734 Move INTERRUPT_INPUT to configure.
736 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
738 Minor adjustments to interning code.
739 * lisp.h (intern, intern_c_string): Redefine as static inline
740 wrappers for intern_1 and intern_c_string_1, respectively.
741 (intern_1, intern_c_string_1): Rename prototypes.
742 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
744 * font.c (font_intern_prop): Likewise. Adjust comment.
745 * w32font.c (intern_font_name): Likewise.
747 2012-07-11 Andreas Schwab <schwab@linux-m68k.org>
749 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
751 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
752 of Fcar/Fcdr if possible.
753 * font.c (check_otf_features): Likewise.
754 * fontset.c (Fnew_fontset): Likewise.
755 * gnutls.c (Fgnutls_boot): Likewise.
756 * minibuf.c (read_minibuf): Likewise.
757 * msdos.c (IT_set_frame_parameters): Likewise.
758 * xmenu.c (Fx_popup_dialog): Likewise.
759 * w32menu.c (Fx_popup_dialog): Likewise.
761 2012-07-11 Glenn Morris <rgm@gnu.org>
763 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
764 since nothing has defined it on these platforms.
766 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
767 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
769 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
770 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
771 Move CLASH_DETECTION to configure.
773 * s/gnu.h: Remove file, which is now empty.
775 * s/gnu.h, s/gnu-linux.h:
776 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
778 2012-07-11 John Wiegley <johnw@newartisans.com>
780 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
781 function attribute, so we only use it if it exists in the
784 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
786 Avoid call to strlen in fast_c_string_match_ignore_case.
787 * search.c (fast_c_string_match_ignore_case): Change to use
788 length argument. Adjust users accordingly.
789 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
791 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
794 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
795 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
798 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
801 * s/hpux10-20.h (HAVE_PERROR): Remove.
802 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
803 Remove dummy definition, as this problem was obsolete long ago.
806 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
808 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
810 Avoid calls to strlen in font processing functions.
811 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
812 (font_open_by_name): Change to use length argument. Adjust
814 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
816 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
817 Change to return ptrdiff_t.
818 (xfont_list_pattern, xfont_match): Use length returned by
819 xfont_decode_coding_xlfd.
820 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
822 2012-07-11 Glenn Morris <rgm@gnu.org>
824 * s/darwin.h, s/freebsd.h, s/netbsd.h:
825 Move DONT_REOPEN_PTY to configure.
827 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
828 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
830 2012-07-10 Paul Eggert <eggert@cs.ucla.edu>
832 Remove "#define unix" that is no longer needed (Bug#11905).
833 * s/aix4-2.h (unix): Remove; no longer needed.
835 EMACS_TIME simplification (Bug#11875).
836 This replaces macros (which typically do not work in GDB)
837 with functions, typedefs and enums, making the code easier to debug.
838 The functional style also makes code easier to read and maintain.
839 * systime.h: Include <sys/time.h> on all hosts, not just if
840 WINDOWSNT, since 'struct timeval' is needed in general.
841 (EMACS_TIME): Now a typedef, not a macro.
842 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
844 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
845 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
846 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
847 (EMACS_TIME_LE): Now functions, not macros.
848 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
849 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
850 which are not functions. All uses rewritten to use:
851 (make_emacs_time): New function.
852 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
853 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
854 not functions. All uses rewritten to use the following, respectively:
855 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
856 (add_emacs_time, sub_emacs_time): New functions.
857 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
858 * fileio.c (Fcopy_file):
859 * xterm.c (XTflash): Get the current time closer to when it's used.
860 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
862 * bytecode.c (targets): Suppress -Woverride-init warnings.
864 Simplify by avoiding confusing use of strncpy etc.
865 * doc.c (Fsnarf_documentation):
866 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
867 * frame.c (Fmake_terminal_frame):
868 * gtkutil.c (get_utf8_string):
870 * nsmenu.m (ns_update_menubar):
871 * regex.c (regerror):
872 Prefer memcpy to strncpy and strncat when either will do.
873 * fileio.c (Fsubstitute_in_file_name):
874 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
875 (menu_separator_name_p):
876 * nsmenu.m (ns_update_menubar):
877 Prefer memcmp to strncmp when either will do.
878 * nsterm.m: Include <ftoastr.h>.
880 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
881 Prefer snprintf to strncpy.
882 * nsterm.m (ns_term_init):
883 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
884 * nsterm.m (ns_term_init):
885 Avoid the need for strncpy, by using build_string or
886 make_unibyte_string directly. Use dtoastr, not snprintf.
887 * process.c (Fmake_network_process): Diagnose service names that
888 are too long, rather than silently truncating them or creating
889 non-null-terminated names.
890 (Fnetwork_interface_info): Likewise, for interface names.
891 * sysdep.c (system_process_attributes) [GNU_LINUX]:
892 Prefer sprintf to strncat.
893 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
894 Prefer vsnprintf to vsprintf + strncpy.
896 2012-07-10 Glenn Morris <rgm@gnu.org>
898 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
899 Clarify fallback case.
901 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
903 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
904 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
905 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
906 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
907 where argument type is known to be a Lisp_Cons.
909 2012-07-10 Tom Tromey <tromey@redhat.com>
911 * bytecode.c (BYTE_CODE_THREADED): New macro.
912 (BYTE_CODES): New macro. Replaces all old byte-code defines.
913 (enum byte_code_op): New type.
914 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
915 (exec_byte_code): Use them. Use token threading when applicable.
917 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
919 Optimize pure C strings initialization.
920 * lisp.h (make_pure_string): Fix prototype.
921 (build_pure_c_string): New function, defined as static inline. This
922 provides a better opportunity to optimize away calls to strlen when
923 the function is called with compile-time constant argument.
924 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
925 argument, adjust users accordingly. Use build_pure_c_string where
927 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
928 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
929 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
931 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
933 Avoid calls to strlen in miscellaneous functions.
934 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
935 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
936 * lread.c (openp): Likewise.
938 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
940 Avoid calls to strlen in path processing functions.
941 * fileio.c (file_name_as_directory): Add comment. Change to add
942 srclen argument and return the length of result. Adjust users
944 (directory_file_name): Fix comment. Change to add srclen argument,
945 swap 1st and 2nd arguments to obey the common convention. Adjust
947 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
949 2012-07-10 Glenn Morris <rgm@gnu.org>
951 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
952 Move PENDING_OUTPUT_COUNT definition to configure.
954 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
955 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
956 * s/gnu.h (DATA_START): Move definitions to configure.
958 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
959 We include usg5-4-common.h, which defines them both.
961 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
962 O_RDONLY already includes it).
964 Stop ns builds setting the EMACSLOADPATH environment variable.
965 * nsterm.m (ns_load_path): Rename from ns_init_paths.
966 Now it does not set EMACSLOADPATH, just returns the load-path string.
967 * nsterm.h: Update accordingly.
968 * lread.c [HAVE_NS]: Include nsterm.h.
969 (init_lread) [HAVE_NS]: Use ns_load_path.
970 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
972 2012-07-09 Glenn Morris <rgm@gnu.org>
974 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
975 since the included bsd-common.h does so.
977 Stop ns builds setting the EMACSPATH environment variable.
978 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
979 (ns_init_paths): Do not set EMACSPATH.
980 * nsterm.h (ns_exec_path): Add it.
981 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
984 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
986 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
988 * process.c (wait_reading_process_output): 'waitchannels' was unset
989 when read_kbd || !NILP (wait_for_cell); fix this.
991 Add GCC-style 'const' attribute to functions that can use it.
992 * character.h (char_resolve_modifier_mask):
993 * keyboard.h (make_ctrl_char):
994 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
995 (init_character_once, next_almost_prime, init_fns, init_image)
996 (flush_pending_output, init_sound):
997 * mem-limits.h (start_of_data):
998 * menu.h (finish_menu_items):
1000 * emacs.c (DEFINE_DUMMY_FUNCTION):
1001 Declare the dummy function with ATTRIBUTE_CONST.
1002 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1003 Add decls with ATTRIBUTE_CONST.
1005 Minor improvements to make_formatted_string.
1006 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1007 where int is good enough, as vsprintf returns an int.
1008 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1010 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1012 Use make_formatted_string to avoid double length calculation.
1013 * lisp.h (make_formatted_string): New prototype.
1014 * alloc.c (make_formatted_string): New function.
1015 * buffer.c (Fgenerate_new_buffer_name): Use it.
1016 * dbus.c (syms_of_dbusbind): Likewise.
1017 * editfns.c (Fcurrent_time_zone): Likewise.
1018 * filelock.c (get_boot_time): Likewise.
1019 * frame.c (make_terminal_frame, set_term_frame_name)
1020 (x_report_frame_params): Likewise.
1021 * image.c (gs_load): Likewise.
1022 * minibuf.c (get_minibuffer): Likewise.
1023 * msdos.c (dos_set_window_size): Likewise.
1024 * process.c (make_process): Likewise.
1025 * xdisp.c (ensure_echo_area_buffers): Likewise.
1026 * xsettings.c (apply_xft_settings): Likewise.
1028 2012-07-09 Glenn Morris <rgm@gnu.org>
1030 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1031 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1032 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1033 * nsterm.h (ns_etc_directory): Add it.
1034 * callproc.c [HAVE_NS]: Include nsterm.h.
1035 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1037 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1039 Move marker debugging code under MARKER_DEBUG.
1040 * marker.c (MARKER_DEBUG): Move marker debugging code under
1041 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1042 for bootstrap with --enable-checking (~3x slowdown reported
1043 by Juanma Barranquero <lekktu@gmail.com>).
1044 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1046 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1048 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1049 See <http://bugs.gnu.org/11825#29>.
1051 2012-07-08 Eli Zaretskii <eliz@gnu.org>
1053 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1054 has no font, use the frame's font. (Bug#11813)
1055 (display_line): Add commentary about displaying truncation glyphs
1057 (produce_special_glyphs): Move here from term.c.
1059 * term.c (produce_special_glyphs): Move to xdisp.c.
1061 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1064 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1066 * xdisp.c (display_line): Avoid warning about implicit declaration
1069 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1071 * lisp.h: Remove empty conditional.
1073 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1075 * lread.c (load_path_check): Now static.
1077 Fix some minor --with-ns problems found by static checking.
1078 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1079 (x_set_font) [!HAVE_X_WINDOWS]:
1080 * image.c (xpm_load_image) [HAVE_NS]:
1081 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1082 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1083 Remove unused local.
1084 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1085 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1086 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1087 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1088 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1089 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1090 Fix pointer signedness problem.
1091 * xfaces.c (FRAME_X_FONT_TABLE):
1092 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1094 2012-07-07 Glenn Morris <rgm@gnu.org>
1096 * lread.c (load_path_check): New function, split from init_lread.
1097 (init_lread): Reorganize. Motivation:
1098 If EMACSLOADPATH is set, check/warn about that rather than the
1099 defaults, which we are not going to use. Hence we can remove
1100 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1101 Don't warn if site-lisp directories are missing.
1102 If not installed, start from a blank load-path, since
1103 PATH_LOADSEARCH refers to the eventual installation directories.
1105 2012-07-07 Eli Zaretskii <eliz@gnu.org>
1107 Support truncation and continuation glyphs on GUI frames, when
1108 fringes are disabled. (Bug#11832)
1109 * xdisp.c (init_iterator): Get dimensions of truncation and
1110 continuation glyphs even if on GUI frames. Adjust
1111 it->last_visible_x on GUI frames when the left or right fringes,
1112 or both, are absent.
1113 (start_display, move_it_in_display_line_to): Handle the case of a
1114 GUI frame without a fringe to display continuation or truncation
1116 (insert_left_trunc_glyphs): Support GUI frames: make sure
1117 truncation glyphs overwrite enough glyphs from the current line to
1118 have sufficient space in pixels.
1119 (display_line): Support truncation and continuation glyphs on GUI
1120 frames. If some spare pixels are left on the line after inserting
1121 the truncation glyphs, fill that space with a stretch glyph of a
1122 suitably computed width.
1124 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1125 produce_glyphs, to support GUI sessions.
1127 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1129 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1131 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1133 Do not require float-time's arg to fit in time_t (Bug#11825).
1134 This works better on hosts where time_t is unsigned, and where
1135 float-time is applied to the (negative) difference between two times.
1136 * editfns.c (decode_time_components): Last arg is now double *,
1137 not int *, and means to store all the result as a double, without
1138 worrying about whether the seconds part fits in time_t.
1139 All callers changed.
1140 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1141 All callers changed.
1142 (Ffloat_time): Do not fail merely because the specified time falls
1143 outside of time_t range.
1145 2012-07-07 Glenn Morris <rgm@gnu.org>
1147 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1148 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1149 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1151 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
1153 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1154 Update dependencies.
1156 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1158 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1160 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1161 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1162 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1163 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1164 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1165 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1167 * xfont.c (compare_font_names): Redo to omit the need for casts.
1169 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1171 * xfns.c (Fx_change_window_property): Doc fix.
1172 * w32fns.c (Fx_change_window_property): Doc fix.
1174 * w32fns.c (Fx_window_property): Accept the same arguments as the
1175 X Windows version. Doc fix.
1176 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1178 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
1179 Eli Zaretskii <eliz@gnu.org>
1181 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1182 Windows-specific code from nt/config.nt moved here.
1183 Obsolete settings removed.
1185 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1187 * process.c: Avoid unnecessary calls to gettime.
1188 (wait_reading_process_output): Don't get the time of day
1189 when gobbling data immediately and not waiting, as there's no need
1190 for it in that case. This removes a FIXME.
1192 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1194 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1195 is defined (Bug#11768).
1197 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1199 Fix marker debugging code.
1200 * marker.c (byte_char_debug_check): Do not perform the check
1201 if buffer is not multibyte.
1202 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1203 Call byte_char_debug_check with correct arguments.
1205 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1207 Compile marker debugging code only if ENABLE_CHECKING is defined.
1208 * marker.c (byte_char_debug_check, count_markers):
1209 Use only if ENABLE_CHECKING is defined.
1210 (byte_debug_flag): Remove.
1211 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1212 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1214 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1216 Avoid code repetition in marker-related functions.
1217 * marker.c (attach_marker): New function.
1218 (Fset_marker, set_marker_restricted, set_marker_both)
1219 (set_marker_restricted_both): Use it.
1220 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1221 Consistently rename charno to charpos.
1222 (marker_position): Add eassert.
1223 (marker_byte_position): Convert to eassert.
1225 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1227 Simplify list operations in unchain_overlay and unchain_marker.
1228 * buffer.c (unchain_overlay): Simplify. Add comment.
1229 * marker.c (unchain_marker): Simplify. Fix comments.
1231 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1233 Introduce fast path for the widely used marker operation.
1234 * alloc.c (build_marker): New function.
1235 * lisp.h (build_marker): New prototype.
1236 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1237 * composite.c (autocmp_chars): Likewise.
1238 * editfns.c (buildmark): Remove.
1239 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1240 (save_restriction_save): Use build_marker.
1241 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1242 * window.c (save_window_save): Likewise.
1244 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1246 Do not use Fdelete_overlay in delete_all_overlays
1247 to avoid redundant calls to unchain_overlay.
1248 * buffer.c (drop_overlay): New function.
1249 (delete_all_overlays, Fdelete_overlay): Use it.
1250 * minibuf.c (get_minibuffer): Fix comment.
1252 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1254 Port to OpenBSD 5.1 amd64.
1255 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1256 This is needed for OpenBSD, and should be harmless on all BSD systems.
1257 Also, include <sys/sysctl.h>, as it should be available on all
1258 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1259 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1260 use p_pid member, not kp_proc.pid.
1262 2012-07-06 Glenn Morris <rgm@gnu.org>
1264 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1266 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1268 More xmalloc and related cleanup.
1269 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1270 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1271 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1272 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1273 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1274 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1275 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1276 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1277 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1279 Omit needless casts involving void * pointers and allocation.
1280 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1281 as the former is more robust if P's type is changed.
1282 Prefer xzalloc to xmalloc + memset 0.
1283 Simplify malloc-or-realloc to realloc.
1284 Don't worry about xmalloc returning a null pointer.
1285 Prefer xstrdup to xmalloc + strcpy.
1286 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1288 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1289 alloca of a constant.
1291 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1293 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1294 hscroll is larger than the line width. Fixes long and futile
1295 looping inside extend_face_to_end_of_line (on a TTY) producing
1296 glyphs that are not needed and thrown away.
1298 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1300 * marker.c (set_marker_restricted_both): Simplify by using
1303 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1305 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1307 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1309 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1310 not defined (Bug#11768).
1311 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1312 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1313 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1314 followed by gtk_box_set_homogeneous (Bug#11768).
1315 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
1316 (update_theme_scrollbar_width, xg_create_scroll_bar):
1317 Use gtk_scrollbar_new (Bug#11768).
1318 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1319 (is_box_type): New function (Bug#11768).
1320 (xg_tool_item_stale_p): Call is_box_type.
1321 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
1322 with default display (Bug#11768).
1324 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1326 * xdisp.c (window_hscroll_limited): New function.
1327 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1328 coordinates when window's hscroll is set to insanely large
1331 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
1333 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1334 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1336 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1339 * lisp.h (xzalloc): New prototype. Omit needless casts.
1340 * alloc.c (xzalloc): New function. Omit needless casts.
1341 * charset.c: Omit needless casts. Convert all calls to
1342 xmalloc with following memset to xzalloc.
1343 * dispnew.c: Likewise.
1344 * fringe.c: Likewise.
1345 * image.c: Likewise.
1346 * sound.c: Likewise.
1348 * w32fns.c: Likewise.
1349 * w32font.c: Likewise.
1350 * w32term.c: Likewise.
1351 * xfaces.c: Likewise.
1353 * xterm.c: Likewise.
1354 * atimer.c: Omit needless casts.
1355 * buffer.c: Likewise.
1356 * callproc.c: Likewise.
1358 * coding.c: Likewise.
1359 * composite.c: Likewise.
1361 * doprnt.c: Likewise.
1362 * editfns.c: Likewise.
1363 * emacs.c: Likewise.
1365 * filelock.c: Likewise.
1367 * gtkutil.c: Likewise.
1368 * keyboard.c: Likewise.
1370 * lread.c: Likewise.
1371 * minibuf.c: Likewise.
1372 * msdos.c: Likewise.
1373 * print.c: Likewise.
1374 * process.c: Likewise.
1375 * region-cache.c: Likewise.
1376 * search.c: Likewise.
1377 * sysdep.c: Likewise.
1378 * termcap.c: Likewise.
1379 * terminal.c: Likewise.
1380 * tparam.c: Likewise.
1381 * w16select.c: Likewise.
1383 * w32reg.c: Likewise.
1384 * w32select.c: Likewise.
1385 * w32uniscribe.c: Likewise.
1386 * widget.c: Likewise.
1387 * xdisp.c: Likewise.
1388 * xmenu.c: Likewise.
1390 * xselect.c: Likewise.
1392 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1394 * fileio.c (time_error_value): Check the right error number.
1395 Problem reported by Troels Nielsen in
1396 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1398 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1400 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1401 This should be fixed in a better way; see Eli Zaretskii in
1402 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1403 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1405 * fileio.c (time_error_value): Rename from special_mtime.
1406 The old name's problems were noted by Eli Zaretskii in
1407 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1409 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1410 This variable's comment says Emacs needs at least one GDB-visible
1411 symbol of type enum pvec_type, to work around GDB problems.
1412 The symbol's value doesn't matter.
1414 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1415 that causes compilation to fail on pre-C99 compilers.
1417 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
1419 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1420 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1422 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1424 * buffer.c (init_buffer_once): Fix initialization of
1425 headers for buffer_defaults and buffer_local_symbols.
1426 Reported by Juanma Barranquero <lekktu@gmail.com>.
1428 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1430 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1431 * lisp.h (enum pvec_type): Use fewer bits.
1432 (PSEUDOVECTOR_SIZE_BITS): New constant.
1433 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1434 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1435 change in pvec_type.
1436 (PSEUDOVECTOR_TYPEP): New macro.
1437 (TYPED_PSEUDOVECTORP): Use it.
1438 * fns.c (internal_equal): Adapt code to extract pvectype.
1439 * emacs.c (gdb_pvec_type): Update type.
1440 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1441 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1442 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1443 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1444 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1445 abusing vector->header.next.nbytes.
1446 (live_vector_p): Use PVEC_TYPE.
1447 (mark_object): Adapt code to extract pvectype. Use switch.
1449 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1451 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1452 Tighten new eassert a bit.
1454 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1456 Fix compilation with --enable-gcc-warnings and -O1
1458 * doprnt.c (doprnt): Change type of tem to int, initialize
1459 to avoid compiler warning. Add eassert.
1460 * search.c (simple_search): Initialize match_byte to avoid
1461 compiler warning. Add eassert.
1463 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1465 Avoid weird behavior with large horizontal scrolls.
1466 Without this change, for example, large hscroll values would
1467 mess up Emacs's display on Fedora 15 x86, presumably due to
1468 overflows in int calculations in the display code.
1469 Also, if buffers had long lines, Emacs would freeze.
1470 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1471 (set_window_hscroll): New function, containing the old guts of
1472 Fset_window_hscroll. Return the clipped value.
1473 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1474 This avoids the need to check against PTRDIFF_MAX.
1476 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1478 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1480 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1482 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1484 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1485 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1486 since GCC 4.4.6 issues a bogus warning for them.
1488 Fix bugs in file timestamp newness comparisons.
1489 * fileio.c (Ffile_newer_than_file_p):
1490 * lread.c (Fload): Use full timestamp resolution of files,
1491 not just the 1-second resolution, so that files that are only
1492 slightly newer still count as newer.
1493 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1494 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1496 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1498 * fileio.c: Improve handling of file time marker. (Bug#11852)
1499 (special_mtime): New function.
1500 (Finsert_file_contents, Fverify_visited_file_modtime):
1501 Use it to set special mtime values consistently.
1503 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1505 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1506 marker for non-existing file. (Bug#11852)
1508 2012-07-03 Glenn Morris <rgm@gnu.org>
1510 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1511 and did not make it into globals.h).
1513 2012-07-03 Tom Tromey <tromey@redhat.com>
1515 * window.c (Fset_window_margins, Fset_window_fringes)
1516 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1517 * textprop.c (Fprevious_property_change): No longer static.
1518 * syntax.c (Fsyntax_table_p): No longer static.
1519 * process.c (Fget_process, Fprocess_datagram_address): No longer
1521 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1522 * keyboard.c (Fcommand_execute): No longer static.
1524 * insdel.c (Fcombine_after_change_execute): No longer static.
1525 * image.c (Finit_image_library): No longer static.
1526 * fileio.c (Fmake_symbolic_link): No longer static.
1527 * eval.c (Ffetch_bytecode): No longer static.
1528 * editfns.c (Fuser_full_name): No longer static.
1529 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1531 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1533 * dired.c (Ffile_attributes): No longer static.
1534 * composite.c (Fcomposition_get_gstring): No longer static.
1535 * callproc.c (Fgetenv_internal): No longer static.
1537 * ccl.h: Remove EXFUNs.
1538 * buffer.h: Remove EXFUNs.
1539 * dispextern.h: Remove EXFUNs.
1540 * intervals.h: Remove EXFUNs.
1541 * fontset.h: Remove EXFUN.
1542 * font.h: Remove EXFUNs.
1543 * dosfns.c (system_process_attributes): Remove EXFUN.
1544 * keymap.h: Remove EXFUNs.
1545 * lisp.h: Remove EXFUNs.
1546 * w32term.h: Remove EXFUNs.
1547 * window.h: Remove EXFUNs.
1548 * xsettings.h: Remove EXFUN.
1549 * xterm.h: Remove EXFUN.
1551 2012-07-03 Glenn Morris <rgm@gnu.org>
1553 * lisp.h (Frandom): Make it visible to C.
1554 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1555 buffer for invisible buffers. (Bug#1229)
1557 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1559 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1560 values which aren't power of 2.
1561 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1562 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1565 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1567 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1569 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1571 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1573 * alloc.c (allocate_vector_block): Remove redundant
1574 calls to mallopt if DOUG_LEA_MALLOC is defined.
1575 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1576 avoid calls to mallopt if zero_vector is returned.
1578 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1580 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1581 is enabled, avoid dereferencing NULL current_sblock if
1584 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1586 Cleanup basic buffer management.
1587 * buffer.h (struct buffer): Change layout to use generic vector
1588 marking code. Fix some comments. Change type of 'clip_changed'
1589 to bitfield. Remove unused #ifndef old.
1590 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1591 (GET_OVERLAYS_AT): Fix indentation.
1592 (for_each_per_buffer_object_at): New macro.
1593 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1594 (Fbuffer_local_variables): Use it.
1595 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1596 * alloc.c (allocate_buffer): Adjust to match new layout of
1597 struct buffer. Fix comment.
1598 (mark_overlay): New function.
1599 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1600 Lisp area of struct buffer.
1601 (mark_object): Use it. Adjust marking of misc objects
1602 and related comments.
1604 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1606 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1607 wrapper that is not needed because the wrapped code is a no-op (zero
1608 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1609 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1611 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1613 * alloc.c (mark_buffer): Simplify. Remove prototype.
1614 (mark_object): Add comment. Reorganize marking of vector-like
1615 objects. Use CHECK_LIVE for all vector-like objects except buffers
1616 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1617 redundant calls to mark_vectorlike for bool vectors.
1619 2012-06-30 Glenn Morris <rgm@gnu.org>
1621 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1623 * epaths.in (PATH_SITELOADSEARCH): New.
1624 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1625 This is rather than relying on --enable-locallisppath elements
1626 having "site-lisp" in their names. (Bug#10208#25, 11658)
1628 2012-06-30 Eli Zaretskii <eliz@gnu.org>
1630 * w32proc.c (sys_select): Accept and ignore one more argument.
1632 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1634 * sysselect.h [DOS_NT]: Don't include sys/select.h.
1635 (pselect) [!MS_DOS]: Redirect to sys_select.
1637 * sysdep.c: Don't include dos.h and dosfns.h.
1639 * process.c (sys_select):
1640 * msdos.c (sys_select): Accept one more argument and ignore it.
1642 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1643 adapt data types and code to that.
1646 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1647 which clashes with the gnulib function of the same name.
1649 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1651 * font.c (font_style_to_value, font_style_symbolic)
1652 (font_prop_validate_style): Add type checks for values in
1655 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1657 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1660 2012-06-29 Eli Zaretskii <eliz@gnu.org>
1662 * xdisp.c (try_window_id): Undo last change.
1664 * w32.c (getwd): Adjust commentary about startup_dir.
1665 (init_environment): Always call sys_access, even in non-MSVC
1666 builds. Don't chdir to the directory of the Emacs executable.
1667 This undoes code from 1997 which was justified by the need to
1668 "avoid conflicts when removing and renaming directories". But its
1669 downside was that every relative file name was being interpreted
1670 relative to the directory of the Emacs executable, which can never
1671 be TRT. In particular, it broke sys_access when called with
1672 relative file names.
1673 (sys_access): Map GetLastError to errno.
1675 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1677 * window.h (struct window): Change type of 'fringes_outside_margins'
1678 to bitfield. Fix comment. Adjust users accordingly.
1679 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
1681 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1684 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
1686 * gnutls.c (emacs_gnutls_handshake):
1687 Add QUIT to make the loop interruptible.
1689 2012-06-29 Glenn Morris <rgm@gnu.org>
1691 * charset.c (init_charset): Make lack of etc/charsets fatal.
1693 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1695 * editfns.c (region_limit): Fix type mismatch.
1697 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1699 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1700 undefined. Convert from xassert to eassert.
1701 * nsmenu.m: Convert from xassert to eassert.
1702 * nsterm.m: Likewise.
1704 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1706 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1708 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1710 Avoid integer overflow on scroll-left and scroll-right.
1711 * window.c (HSCROLL_MAX): New macro.
1712 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1713 overflow when requested scroll falls outside ptrdiff_t range.
1715 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1717 * window.h (struct window): Change type of 'hscroll',
1718 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1719 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1720 Adjust users accordingly.
1721 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1722 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1723 from EMACS_INT to ptrdiff_t.
1724 (make_window): Omit redundant initialization.
1726 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
1728 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1730 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1732 * window.h (struct window): Change type of 'use_time' and
1733 'sequence_number' from Lisp_Object to int.
1734 * frame.c (make_frame): Adjust users accordingly.
1735 * print.c (print_object): Likewise.
1736 * window.c (select_window, Fwindow_use_time, make_parent_window)
1737 (make_window): Likewise.
1739 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1741 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1742 enabled with --enable-checking=[all,glyphs] configure option.
1743 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1744 adjust comments accordingly.
1745 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1746 undefined, adjust comments accordingly.
1747 * image.c: Likewise.
1748 * scroll.c: Likewise.
1749 * w32fns.c: Likewise.
1750 * w32term.c: Likewise.
1751 * xdisp.c: Likewise.
1752 * xfaces.c: Likewise.
1754 * xterm.c: Likewise.
1756 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1758 Generalize run-time debugging checks.
1759 * dispextern.h (XASSERTS): Remove.
1760 * fontset.c (xassert): Remove.
1761 Convert from xassert to eassert.
1762 * alloc.c: Convert from xassert to eassert.
1764 * dispnew.c: Likewise.
1766 * fringe.c: Likewise.
1767 * ftfont.c: Likewise.
1768 * gtkutil.c: Likewise.
1769 * image.c: Likewise.
1770 * keyboard.c: Likewise.
1772 * process.c: Likewise.
1773 * scroll.c: Likewise.
1774 * sound.c: Likewise.
1776 * w32console.c: Likewise.
1777 * w32fns.c: Likewise.
1778 * w32term.c: Likewise.
1779 * window.c: Likewise.
1780 * xdisp.c: Likewise.
1781 * xfaces.c: Likewise.
1783 * xselect.c: Likewise.
1784 * xterm.c: Likewise.
1786 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1788 * fns.c (maybe_resize_hash_table): Output message when growing the
1791 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1793 * alloc.c (allocate_string_data): Remove dead code.
1794 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1795 avoid GCC warning about unused macro.
1797 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1799 * alloc.c (allocate_string): Omit intervals initialization.
1800 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1801 as in make_pure_string and make_pure_c_string.
1803 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1805 * alloc.c (allocate_string): Fix last change.
1807 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1809 * alloc.c (allocate_string): Remove two redundant calls
1810 to memset, add explicit initialization where appropriate.
1812 2012-06-27 Glenn Morris <rgm@gnu.org>
1814 * lisp.mk (lisp): Remove paths.elc.
1816 2012-06-27 Chong Yidong <cyd@gnu.org>
1818 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1820 2012-06-26 John Wiegley <johnw@newartisans.com>
1822 * unexmacosx.c (copy_data_segment): Add two section names used
1823 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1825 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1826 when building with Clang.
1828 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1830 * eval.c (Fapply): Allow calling it with a single argument.
1832 2012-06-26 Eli Zaretskii <eliz@gnu.org>
1834 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1835 _stricmp and _strnicmp.
1836 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1838 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1840 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1842 (allocate_process): Likewise for new process.
1843 (allocate_terminal): Change to use offsetof.
1844 (allocate_frame): Likewise.
1845 * frame.c (make_frame): Omit redundant initialization.
1846 * window.c (make_parent_window): Use memset.
1847 (make_window): Omit redundant initialization.
1848 * process.c (make_process): Omit redundant initialization.
1849 * terminal.c (create_terminal): Likewise.
1851 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1853 * term.c (delete_tty): Remove redundant call to memset.
1855 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1857 * alloc.c: Remove build_string.
1858 * lisp.h: Define build_string as static inline. This provides
1859 a better opportunity to optimize away calls to strlen when the
1860 function is called with compile-time constant argument.
1861 * image.c (imagemagick_error): Convert to build_string.
1862 * w32proc.c (sys_spawnve): Likewise.
1863 * xterm.c (x_term_init): Likewise.
1865 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1867 Use sprintf return value instead of invoking strlen on result.
1868 In the old days this wasn't portable, since some sprintf
1869 implementations returned char *. But they died out years ago and
1870 Emacs already assumes sprintf returns int.
1871 Similarly for float_to_string.
1872 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1873 * ccl.c (ccl_driver):
1874 * character.c (string_escape_byte8):
1875 * data.c (Fnumber_to_string):
1876 * doprnt.c (doprnt):
1877 * print.c (print_object):
1878 * xdisp.c (message_dolog):
1879 * xfns.c (syms_of_xfns):
1880 Use sprintf or float_to_string result to avoid need to call strlen.
1881 * data.c (Fnumber_to_string):
1882 Use make_unibyte_string, since the string must be ASCII.
1883 * lisp.h, print.c (float_to_string): Now returns int length.
1884 * term.c (produce_glyphless_glyph):
1885 Use sprintf result rather than recomputing it.
1887 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1888 * Makefile.in (ALL_CFLAGS):
1889 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1890 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1892 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1894 * dispextern.h (xstrcasecmp): Define to library function
1895 strcasecmp if available.
1896 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1898 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1900 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1901 Avoid comma operator.
1902 * menu.c (push_submenu_start, push_submenu_end)
1903 (push_left_right_boundary, push_menu_pane): Likewise.
1904 * msdos.c (dos_rawgetc): Likewise.
1906 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1908 * xfns.c (xic_create_fontsetname): Remove redundant calls
1911 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1913 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1914 sprintf already null-terminates its output.
1916 * xfns.c (x_window): Remove redundant cast.
1918 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1920 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1921 `const char *' to `char *' to avoid compiler warning.
1923 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1925 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1926 instead of truncating it to 63 (admittedly a generous limit).
1928 * process.c: Fix spelling and caps in comments.
1930 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1932 * emacs.c (setpgrp): Remove definition, unused.
1933 * sysdep.c (setpgrp): Remove definition, not used in this file.
1935 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
1937 * makefile.w32-in: Update dependencies.
1939 2012-06-24 Eli Zaretskii <eliz@gnu.org>
1941 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1942 (SYSTIME_H): Add nt/inc/sys/time.h.
1944 * systime.h [WINDOWSNT]: Include sys/time.h.
1946 * s/ms-w32.h (struct timespec): Definition moved from
1947 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1949 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1951 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1952 * buffer.h (buffer_slot_type_mismatch):
1953 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1954 * eval.c (unwind_to_catch):
1955 * image.c (my_png_error, my_error_exit):
1956 * keyboard.c (quit_throw_to_read_char, user_error)
1957 (Fexit_recursive_edit, Fabort_recursive_edit):
1958 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1959 (wrong_type_argument, buffer_overflow, __executable_start)
1960 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1961 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1962 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1964 (child_setup) [!DOS_NT]:
1965 * lread.c (end_of_file_error, invalid_syntax):
1966 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1967 * puresize.h (pure_write_error):
1968 * search.c (matcher_overflow):
1969 * sound.c (sound_perror, alsa_sound_perror):
1970 * sysdep.c, syssignal.h (croak):
1971 * term.c (maybe_fatal, vfatal):
1972 * textprop.c (text_read_only):
1973 * undo.c (user_error):
1974 * unexmacosx.c (unexec_error):
1975 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1976 Use _Noreturn rather than NO_RETURN.
1977 No need for separate decl merely because of _Noreturn.
1978 * sound.c (sound_warning, parse_sound):
1979 Remove unnecessary forward decls.
1981 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1983 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1984 * lisp.h (WAIT_READING_MAX): New macro.
1985 * dispnew.c (Fsleep_for, sit_for):
1986 * keyboard.c (kbd_buffer_get_event):
1987 * process.c (Faccept_process_output):
1988 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1989 This improves on the previous patch, which introduced a bug
1990 when time_t is unsigned and as wide as intmax_t.
1991 See <http://bugs.gnu.org/9000#51>.
1993 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1995 * dispnew.c (sit_for, Fsleep_for):
1996 * keyboard.c (kbd_buffer_get_event):
1997 * process.c (Faccept_process_output): Avoid compiler warnings when
1998 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2000 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
2002 * makefile.w32-in: Update dependencies.
2004 * w32.c (ltime): Add return type and declare static.
2005 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2007 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2009 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2010 Privately reported by Herbert J. Skuhra.
2011 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2013 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2014 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2016 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2018 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2019 last argument of make_unibyte_string.
2021 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2022 language ID in the event parameters.
2024 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2025 event.code, not the obscure "character set ID".
2027 2012-06-23 Chong Yidong <cyd@gnu.org>
2029 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2031 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2033 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2034 * w32.c (fdutimens): New function.
2036 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2038 * s/ms-w32.h (pselect): Redirect to sys_select.
2040 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2042 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2043 in the logic of incrementing and decrementing the value of
2044 use_relocatable_buffers.
2046 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2048 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2049 Privately reported by Herbert J. Skuhra.
2050 [__FreeBSD__]: Remove "*/" typo after "#include".
2051 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2052 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2053 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2054 Don't assume EMACS_TIME and struct timeval are the same type.
2056 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2058 Support higher-resolution time stamps (Bug#9000).
2059 The time stamps are only nanosecond-resolution at the C level,
2060 since that's the best that any real-world system supports now.
2061 But they are picosecond-resolution at the Lisp level, as that's
2062 easy, and leaves room for future OS improvements.
2064 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2067 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2068 Don't get current time unless it's needed.
2070 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2071 now provides it if it's absent.
2072 (start_atimer): Port to higher-res time stamps.
2073 Check for time stamp overflow. Don't get current time more
2074 often than is needed.
2076 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2077 Include systime.h, not time.h.
2078 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2080 * dired.c: Include stat-time.h.
2081 (Ffile-attributes): File times now have higher resolution.
2083 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2084 (struct image): Timestamp now has higher resolution.
2086 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2087 has at least microseconds now. All uses removed.
2088 (update_frame, update_single_window, update_window, update_frame_1)
2089 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2091 * editfns.c (time_overflow): Now extern.
2092 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2093 (float-time, Fformat_time_string, Fcurrent_time_string)
2094 (Fcurrent_time_zone): Accept and generate higher-resolution
2096 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2097 (decode_time_components, lisp_seconds_argument): New functions.
2098 (make_time): Now static.
2099 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2100 Report an error if the time is invalid, rather than having the caller
2103 * fileio.c: Include <stat-time.h>
2104 (Fcopy_file): Copy higher-resolution time stamps.
2105 Prefer to set the time stamp via a file descriptor if that works.
2106 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2107 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2108 (Fvisited_file_modtime, Fset_visited_file_modtime):
2109 Support higher-resolution time stamps.
2111 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2113 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2115 * image.c (prepare_image_for_display, clear_image_cache)
2116 (lookup_image): Port to higer-resolution time stamps.
2118 * keyboard.c (start_polling, bind_polling_period):
2119 Check for time stamp overflow.
2120 (read_char, kbd_buffer_get_event, timer_start_idle)
2121 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2122 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2123 Port to higher-resolution time stamps. Do not assume time_t is signed.
2124 (decode_timer): New function. Timers are now vectors of length 9,
2125 not 8, to accommodate the picosecond component.
2126 (timer_check_2): Use it.
2128 * nsterm.m (select_timeout, timeval_subtract): Remove.
2129 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2130 as they're a bit more accurate and handle overflow better.
2131 (ns_select): Change prototype to be compatible with pselect.
2132 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2133 * nsterm.h (ns_select): Adjust prototype.
2135 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2136 us-resolution time stamps.
2137 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2139 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2141 * lisp.h (time_overflow): New decl.
2142 (wait_reading_process_output): First arg is now intmax_t, not int,
2143 to accommodate larger waits.
2145 * process.h (struct Lisp_Process.read_output_delay):
2146 Now counts nanoseconds, not microseconds.
2147 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2149 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2150 (wait_reading_process_output):
2151 Port to ns-resolution time stamps.
2152 (Faccept_process_output, wait_reading_process_output):
2153 Check for time stamp overflow. Do not assume time_t is signed.
2154 (select_wrapper): Remove; we now use pselect.
2155 (Fprocess_attributes): Now generates ns-resolution time stamps.
2157 * sysdep.c: Include utimens.h. Don't include utime.h
2158 or worry about struct utimbuf; gnulib does that for us now.
2159 (gettimeofday): Remove; gnulib provides a substitute.
2160 (make_timeval): New function.
2161 (set_file_times): Now sets ns-resolution time stamps.
2162 New arg FD; all uses changed.
2163 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2164 (system_process_attributes):
2165 Now returns ns-resolution time stamp. All uses changed.
2166 Check for time stamp overflow.
2168 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2169 provides a substitute now.
2171 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2172 since it guarantees struct timespec.
2173 (EMACS_TIME): Now struct timespec, so that we can support
2174 ns-resolution time stamps.
2175 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2176 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2177 (EMACS_USECS): Remove.
2178 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2179 so multiply the arg by 1000 before storing it.
2180 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2182 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2183 Port to ns-resolution time stamps.
2184 (EMACS_TIME_NEG_P): Remove; replaced by....
2185 (EMACS_TIME_SIGN): New macro.
2186 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2187 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2188 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2189 (make_timeval, make_lisp_time, decode_time_components): New decls.
2190 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2191 that it mishandled time_t overflow. You can't compare by subtracting!
2192 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2193 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2195 * term.c: Include <sys/time.h>.
2196 (timeval_to_Time): New function, for proper overflow wraparound.
2197 (term_mouse_position, term_mouse_click): Use it.
2199 * undo.c (record_first_change): Support higher-resolution time stamps
2201 (Fprimitive_undo): Use them when restoring time stamps.
2203 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2204 (w32_get_internal_run_time):
2205 Port to higher-resolution Emacs time stamps.
2206 (ltime): Now accepts single 64-bit integer, as that's more convenient
2209 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2211 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2212 for compatibility with pselect. Support ns-resolution time stamps.
2214 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2216 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2217 Check for time stamp overflow, and support ns-resolution time stamps.
2219 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2220 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2221 (timeval_subtract): Remove; no longer needed.
2222 (XTflash, XTring_bell, x_wait_for_event):
2223 Port to ns-resolution time stamps. Don't assume time_t is signed.
2225 2012-06-22 Chong Yidong <cyd@gnu.org>
2227 * xdisp.c (x_consider_frame_title): Revert last change.
2229 2012-06-22 Eli Zaretskii <eliz@gnu.org>
2231 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2232 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2233 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2234 staticidx goes up to 1597 out of 1600 = 0x640.)
2236 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2238 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2239 Otherwise, the umask might be mistakenly 0 while handling input signals.
2241 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2243 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2245 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2247 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2248 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2249 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2250 access to `contents' member of Lisp_Vector objects with AREF and ASET
2253 2012-06-19 Chong Yidong <cyd@gnu.org>
2255 * frame.c (delete_frame): When selecting a frame on a different
2256 text terminal, do not alter the terminal's top-frame.
2258 * xdisp.c (format_mode_line_unwind_data): Record the target
2259 frame's selected window and its terminal's top-frame.
2260 (unwind_format_mode_line): Restore them.
2261 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2263 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2264 since tty frames can be explicitly named.
2265 (prepare_menu_bars): Likewise.
2267 * term.c (Ftty_top_frame): New function.
2269 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2271 Port byte-code-meter to modern targets.
2272 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2273 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
2274 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
2275 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2276 (METER_1, METER_2): Simplify.
2278 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2280 * data.c (Fdefalias): Return `symbol' (bug#11686).
2282 2012-06-18 Martin Rudalics <rudalics@gmx.at>
2284 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
2285 gets killed during executing of this function (Bug#11665).
2286 Try to always return Qt when the buffer has been actually killed.
2287 (Vkill_buffer_query_functions): In doc-string say that functions
2288 run by this hook should not change the current buffer.
2290 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2292 Fix recently-introduced process.c problems found by static checking.
2293 * process.c (write_queue_push, write_queue_pop, send_process):
2294 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2295 (write_queue_pop): Fix pointer signedness problem.
2296 (send_process): Remove unused local.
2298 2012-06-17 Chong Yidong <cyd@gnu.org>
2300 * xdisp.c (redisplay_internal): No need to redisplay terminal
2301 frames that are not on top.
2303 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
2305 * process.c (make_process): Initialize write_queue.
2306 (write_queue_push, write_queue_pop): New functions.
2307 (send_process): Use them to maintain correct ordering of process
2310 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2312 * lisp.h (eassert): Assume C89 or later.
2313 This removes the need for CHECK.
2314 (CHECK): Remove. Its comments about always evaluating its
2315 argument were confusing, as 'eassert' typically does not evaluate
2318 * coding.c (produce_chars): Use ptrdiff_t, not int.
2320 * xterm.c (x_draw_underwave): Check for integer overflow.
2321 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2323 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
2325 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2326 referenced (Bug#11583).
2328 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2330 Implement wave-style variant of underlining.
2331 * dispextern.h (face_underline_type): New enum.
2332 (face): Add field for underline type.
2333 * nsterm.m (ns_draw_underwave): New function.
2334 (ns_draw_text_decoration): Use it.
2335 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2337 (x_draw_glyph_string): Use them.
2338 * xfaces.c (Qline, Qwave): New Lisp objects.
2339 (check_lface_attrs, merge_face_ref)
2340 (Finternal_set_lisp_face_attribute, realize_x_face):
2341 Handle wave-style underline face attributes.
2342 * xterm.c (x_draw_underwave): New function.
2343 (x_draw_glyph_string): Use it.
2345 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
2347 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2348 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2349 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2350 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2351 ($(BLD)/w32select.$(O)): Update dependencies.
2353 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2355 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2356 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2357 * character.c (_fetch_multibyte_char_p): Remove.
2358 * alloc.c: Include "character.h" before "buffer.h".
2360 * buffer.c: Likewise.
2361 * bytecode.c: Likewise.
2362 * callint.c: Likewise.
2363 * callproc.c: Likewise.
2364 * casefiddle.c: Likewise.
2365 * casetab.c: Likewise.
2366 * category.c: Likewise.
2368 * coding.c: Likewise.
2369 * composite.c: Likewise.
2370 * dired.c: Likewise.
2371 * dispnew.c: Likewise.
2373 * dosfns.c: Likewise.
2374 * editfns.c: Likewise.
2375 * emacs.c: Likewise.
2376 * fileio.c: Likewise.
2377 * filelock.c: Likewise.
2379 * fontset.c: Likewise.
2380 * fringe.c: Likewise.
2381 * indent.c: Likewise.
2382 * insdel.c: Likewise.
2383 * intervals.c: Likewise.
2384 * keyboard.c: Likewise.
2385 * keymap.c: Likewise.
2386 * lread.c: Likewise.
2387 * macros.c: Likewise.
2388 * marker.c: Likewise.
2389 * minibuf.c: Likewise.
2390 * nsfns.m: Likewise.
2391 * nsmenu.m: Likewise.
2392 * print.c: Likewise.
2393 * process.c: Likewise.
2394 * regex.c: Likewise.
2395 * region-cache.c: Likewise.
2396 * search.c: Likewise.
2397 * syntax.c: Likewise.
2399 * textprop.c: Likewise.
2401 * unexsol.c: Likewise.
2402 * w16select.c: Likewise.
2403 * w32fns.c: Likewise.
2404 * w32menu.c: Likewise.
2405 * window.c: Likewise.
2406 * xdisp.c: Likewise.
2408 * xmenu.c: Likewise.
2410 * xselect.c: Likewise.
2412 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2414 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2415 If all the glyphs of the glyph row came from strings, and we have no
2416 cursor positioning clues, put the cursor on the first glyph of the
2418 (handle_face_prop): Use chunk-relative overlay string index when
2419 indexing into it->string_overlays array. (Bug#11653)
2420 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2421 the rightmost. (Bug#11720)
2423 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2425 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2426 (CATEGORY_MEMBER): Enforce 1/0 value.
2427 * category.c (_temp_category_set): Remove.
2429 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2431 * window.c (Fdelete_other_windows_internal)
2432 (Fdelete_window_internal): Don't access frame's mouse highlight
2433 info of the initial frame. (Bug#11677)
2435 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2437 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2438 Assume USE_2_TAGS_FOR_INTS.
2439 (xreload): Adjust $tagmask width to match recent lisp.h change.
2441 Simplify lisp.h in minor ways that should not affect code.
2442 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2443 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2444 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2445 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2446 (INTTYPEBITS): New macro, for clarity.
2447 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
2448 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2449 Simplify now that USE_LSB_TAG is always defined.
2450 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2451 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2453 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
2455 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2457 2012-06-13 Glenn Morris <rgm@gnu.org>
2459 * s/bsd-common.h (BSD4_3):
2460 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2462 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2464 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2467 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2469 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
2470 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
2471 * alloc.c (widen_to_Lisp_Object): Remove.
2472 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2473 * frame.c (delete_frame): Remove outdated comment.
2474 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2475 USE_LISP_UNION_TYPE.
2476 (Fw32_unregister_hot_key): Likewise.
2477 (Fw32_toggle_lock_key): Likewise.
2478 * w32menu.c (add_menu_item): Likewise.
2479 (w32_menu_display_help): Use XIL instead of checking
2480 USE_LISP_UNION_TYPE.
2481 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2482 (init_heap): Likewise.
2483 * w32term.c (w32_read_socket): Update comment.
2485 2012-06-13 Glenn Morris <rgm@gnu.org>
2487 * s/usg5-4-common.h, src/s/unixware.h:
2488 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2490 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2492 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2494 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2495 * alloc.c (make_number) [!defined make_number]:
2496 Remove, as lisp.h always defines this now.
2497 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2498 (roundup_size): Verify that it is a power of 2.
2499 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2500 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2501 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2502 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2503 USE_LSB_TAG now is always defined to be either 0 or 1.
2505 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2506 code works fine either way, and efficiency is not a concern here,
2507 as the union type is for debugging, not for production.
2508 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2509 Use an inline function on all platforms when using the union type,
2510 since this is simpler and 'static inline' can be used portably
2512 (LISP_INITIALLY_ZERO): New macro.
2513 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2514 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2516 2012-06-12 Glenn Morris <rgm@gnu.org>
2518 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2520 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
2522 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2523 Move BROKEN_SIGIO to configure.
2525 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2526 Move NO_TERMIO to configure.
2528 2012-06-12 Chong Yidong <cyd@gnu.org>
2530 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2531 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2532 MagickExportImagePixels is undefined.
2534 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2536 * image.c (imagemagick_load_image): Remove unused label.
2538 2012-06-11 Glenn Morris <rgm@gnu.org>
2540 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2541 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2542 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2543 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2545 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2547 * alloc.c (make_byte_code): New function.
2548 (Fmake_byte_code): Use it. Don't purify here.
2549 * lread.c (read1): Use it as well to avoid extra allocation.
2551 2012-06-11 Chong Yidong <cyd@gnu.org>
2553 * image.c (imagemagick_load_image): Implement transparency.
2555 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2557 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2558 account for preceding backslashes. (Bug#11663)
2560 2012-06-09 Chong Yidong <cyd@gnu.org>
2562 * term.c: Support italics in capable terminals (Bug#9652).
2563 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2564 (turn_on_face): Output using TS_enter_italic_mode if available.
2565 Don't handle unused blinking and alt-charset cases.
2566 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2567 and tty_alt_charset_p cases.
2568 (tty_capable_p, init_tty): Support italics.
2570 * termchar.h (struct tty_display_info): Add field for italics.
2571 Remove unused blink field.
2573 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2576 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2577 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2578 tty_alt_charset_p. Add tty_italic_p.
2580 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
2582 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2583 dbus_type_is_basic if available.
2584 (xd_extract_signed, xd_extract_unsigned): Rename from
2585 extract_signed and extract_unsigned, respectively. Adapt callers.
2587 2012-06-09 Chong Yidong <cyd@gnu.org>
2589 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2591 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2594 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2596 * xdisp.c (vmessage): Treat frame message as multibyte.
2597 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2598 would generate the diagnostic "Making \302\247 buffer-local while
2601 2012-06-08 Eli Zaretskii <eliz@gnu.org>
2603 * dispnew.c (showing_window_margins_p): Undo last change, which
2604 was done due to an inadvertent commit.
2605 (adjust_frame_glyphs_for_frame_redisplay): Do call
2606 showing_window_margins_p.
2608 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2610 * eval.c (Fmake_var_non_special): New primitive.
2611 (syms_of_eval): Defsubr it.
2612 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2614 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
2616 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2617 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2619 2012-06-08 Eli Zaretskii <eliz@gnu.org>
2621 * alloc.c (allocate_vectorlike): Fix last change.
2623 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2625 Block-based vector allocation of small vectors.
2626 * lisp.h (struct vectorlike_header): New field `nbytes',
2627 adjust comment accordingly.
2628 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2629 to denote vector blocks. Adjust users (live_vector_p,
2630 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2631 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2632 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2633 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2634 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2635 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2636 (roundup_size): New constant.
2637 (struct vector_block): New data type.
2638 (vector_blocks, vector_free_lists, zero_vector): New variables.
2639 (all_vectors): Rename to `large_vectors'.
2640 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2641 (sweep_vectors): New functions.
2642 (allocate_vectorlike): Return `zero_vector' as the only vector of
2643 0 items. Allocate new vector from block if vector size is less than
2644 or equal to VBLOCK_BYTES_MAX.
2645 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2646 (init_alloc_once): Add call to init_vectors.
2648 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2650 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2652 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2654 * doprnt.c (doprnt): Truncate multibyte char correctly.
2655 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2656 would mishandle a string argument "Xc" if X was a multibyte
2657 character of length 2: it would truncate after X's first byte
2658 rather than including all of X.
2660 2012-06-06 Chong Yidong <cyd@gnu.org>
2662 * buffer.c (word_wrap): Doc fix.
2664 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2666 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2668 2012-06-03 Glenn Morris <rgm@gnu.org>
2670 * xdisp.c (tool-bar-style): Doc fix.
2672 2012-06-03 Ulrich Müller <ulm@gentoo.org>
2674 * Makefile.in (PAXCTL): Define.
2675 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2676 binary via PaX flags if the paxctl utility is available.
2677 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2678 Restore PaX flags to their default. (Bug#11398)
2680 2012-06-03 Chong Yidong <cyd@gnu.org>
2682 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2685 2012-06-03 Chong Yidong <cyd@gnu.org>
2687 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2688 (note_mode_line_or_margin_highlight): If there is no help echo,
2689 use mode-line-default-help-echo. Handle the case where the mouse
2690 position is past the end of the mode line string.
2692 * buffer.c (buffer_local_value_1): New function, split from
2693 Fbuffer_local_value; can return Qunbound.
2694 (Fbuffer_local_value): Use it.
2695 (Vmode_line_format): Docstring tweaks.
2697 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2699 * sysdep.c (system_process_attributes): Improve comment.
2701 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2703 * keyboard.c: Export real-this-command to Elisp.
2704 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2705 and DEFVAR it. Update all users.
2707 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2709 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2711 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2712 Convert pctcpu and pctmem to Lisp float properly.
2713 Let the compiler fold better, as 100.0/0x8000 is exact.
2715 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2717 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2720 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2722 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2724 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2726 For a 'struct window', replace some Lisp_Object fields to
2727 bitfields where appropriate, remove unused fields.
2728 * window.h (struct window): Remove unused 'last_mark_x' and
2729 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2730 change it's type from Lisp_Object to bitfield.
2731 Change type of 'force_start', 'optional_new_start',
2732 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2733 fields from Lisp_Object to bitfield. Adjust users accordingly.
2735 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2737 Pacify gcc -Wdouble-precision when using Xaw.
2738 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2739 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2740 Use 'float' consistently, rather than 'float' in most places
2741 and 'double' in a couple of places.
2743 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2745 * xdisp.c (handle_stop): Detect whether we have overlay strings
2746 loaded by testing it->current.overlay_string_index to be
2747 non-negative, instead of checking whether n_overlay_strings is
2748 positive. (Bug#11587)
2750 2012-05-31 Chong Yidong <cyd@gnu.org>
2752 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2754 * doc.c (Fsubstitute_command_keys): Doc fix.
2756 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2758 * search.c (search_buffer): Remove calls to
2759 r_alloc_inhibit_buffer_relocation, as it is now called by
2760 maybe_unify_char, which was the cause of relocation of buffer text
2763 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2765 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2766 for the duration of call to load_charset, to avoid problems with
2767 callers of maybe_unify_char that access buffer text through C
2770 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2771 decrement the inhibition flag, instead of just setting or
2774 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2776 Remove obsolete '#define static' cruft.
2777 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2778 This #undef was "temporary" in 2000; it is no longer needed
2779 now that '#define static' has gone away.
2780 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2781 (gray_bitmap_bits): Remove; no longer needed.
2782 All uses replaced with definiens.
2783 * xterm.c: Include "bitmaps/gray.xbm".
2785 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2787 Clean up __executable_start, monstartup when --enable-profiling.
2788 The following changes affect the code only when profiling.
2789 * dispnew.c (__executable_start): Rename from safe_bcopy.
2790 Define only on platforms that need it.
2791 * emacs.c: Include <sys/gmon.h> when profiling.
2792 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2793 (__executable_start): Remove decl, since lisp.h does it now.
2794 (safe_bcopy): Remove decl; no longer has that name.
2795 (main): Coalesce #if into single bit of code, for simplicity.
2796 Cast pointers to uintptr_t, since standard libraries want integers
2798 * lisp.h (__executable_start): New decl.
2800 2012-05-31 Glenn Morris <rgm@gnu.org>
2802 * image.c (Fimagemagick_types): Doc fix.
2804 2012-05-30 Jim Meyering <meyering@redhat.com>
2806 * callproc.c (Fcall_process_region): Include directory component
2807 in mkstemp error message (Bug#11586).
2809 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2811 * alloc.c, lisp.h (make_pure_vector): Now static.
2813 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2815 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2816 Move to byte-run.el.
2817 (Fautoload): Do the hash-doc more carefully.
2818 * data.c (Fdefalias): Purify definition, except for keymaps.
2819 (Qdefun): Move from eval.c.
2820 * lisp.h (Qdefun): Remove.
2821 * lread.c (read1): Tiny simplification.
2823 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
2825 Do not create empty overlays with the evaporate property (Bug#9642).
2826 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2827 Bug#9642, but explicitly check that the buffer the overlay would
2828 be moved to is live and rearrange lines to make sure that errors
2829 will not put the overlay in an inconsistent state.
2830 (Fdelete_overlay): Cosmetics.
2832 2012-05-28 Eli Zaretskii <eliz@gnu.org>
2834 * w32term.c (my_bring_window_to_top): New function.
2835 (x_raise_frame): Use handle returned by DeferWindowPos, which
2836 could be different from the original one.
2837 Call my_bring_window_to_top instead of my_set_foreground_window.
2840 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2841 by calling BringWindowToTop.
2843 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2844 (WM_EMACS_END): Increase by one.
2846 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2848 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2849 This avoids undefined behavior that might cause the eassert
2850 to not catch an out-of-range value.
2852 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
2854 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2855 Update dependencies.
2857 2012-05-27 Eli Zaretskii <eliz@gnu.org>
2859 * bidi.c (bidi_mirror_char): Fix last change.
2861 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2863 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2864 when referring to sectname field in printf format.
2866 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2868 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2869 Only r_alloc_inhibit_buffer_relocation needed to be added;
2870 the others were already declared.
2872 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2873 before checking whether it's out of range. Put the check inside
2875 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2877 2012-05-27 Ken Brown <kbrown@cornell.edu>
2879 * callproc.c (Fcall_process): Restore a line that was accidentally
2880 commented out in the 2011-02-13 change (bug#11547).
2882 2012-05-27 Eli Zaretskii <eliz@gnu.org>
2884 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2885 defined on ralloc.c.
2887 * buffer.c [REL_ALLOC]: Remove prototypes of
2888 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2889 they are now on lisp.h.
2891 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2893 * search.c (search_buffer): Use it to inhibit relocation of buffer
2894 text while re_search_2 is doing its job, because re_search_2 is
2895 passed C pointers to buffer text. (Bug#11519)
2897 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2900 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2901 state after an additional call to move_it_in_display_line_to, keep
2902 the values of it->max_ascent and it->max_descent found for the
2904 (pos_visible_p): Revert the comparison against bottom_y to what it
2905 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2908 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2910 Fix coding-related core dumps with gcc -ftrapv.
2911 The code was computing A - B, where A and B are pointers, and B is
2912 random garbage. This can lead to core dumps on platforms that
2913 have special pointer registers, and it also leads to core dumps on
2914 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2915 A - B only when B is initialized properly.
2916 * coding.c (coding_set_source, coding_set_destination): Return void.
2917 (coding_change_source, coding_change_destinations): New functions,
2918 with the old behaviors of coding_set_source and coding_set_destination.
2919 All callers that need an offset changed to use these new functions.
2921 2012-05-26 Glenn Morris <rgm@gnu.org>
2923 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2925 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2927 Extend mouse support on W32 text-mode console.
2928 * xdisp.c (draw_row_with_mouse_face):
2929 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
2931 * w32console.c: Include window.h.
2932 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2934 (initialize_w32_display): Initialize mouse-highlight data.
2936 * w32inevt.c: Include termchar.h and window.h.
2937 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2938 moves, call note_mouse_highlight. If help_echo changed, call
2939 gen_help_event to produce help-echo message in the echo area.
2940 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2943 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2945 * lread.c (read1): Simplify slightly to avoid an overflow warning
2946 with GCC 4.7.0 on x86-64.
2948 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2950 * bidi.c (bidi_mirror_char): Revert last change: an int is
2951 definitely wide enough here.
2953 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
2955 Fix integer width and related bugs (Bug#9874).
2956 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
2957 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2958 (string_bytes, check_sblock, allocate_string_data):
2959 (compact_small_strings, Fmake_bool_vector, make_string)
2960 (make_unibyte_string, make_multibyte_string)
2961 (make_string_from_bytes, make_specified_string)
2962 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2963 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2965 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2966 (allocate_pseudovector):
2967 Use int, not EMACS_INT, where int is wide enough.
2968 (inhibit_garbage_collection, Fgarbage_collect):
2969 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2970 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2971 int might not be wide enough.
2972 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2973 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2974 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2975 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2976 (bidi_level_of_next_char, bidi_move_to_visually_next):
2977 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2978 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2979 (Fkill_buffer, Fset_buffer_major_mode)
2980 (advance_to_char_boundary, Fbuffer_swap_text)
2981 (Fset_buffer_multibyte, overlays_at, overlays_in)
2982 (overlay_touches_p, struct sortvec, record_overlay_string)
2983 (overlay_strings, recenter_overlay_lists)
2984 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2985 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2986 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2987 (Foverlay_recenter, last_overlay_modification_hooks_used)
2988 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2989 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2990 (validate_region): Omit unnecessary test for b <= e,
2991 since that's guaranteed by the previous test.
2992 (adjust_overlays_for_delete): Avoid pos + length overflow.
2993 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2994 (report_overlay_modification):
2995 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2996 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2997 Omit pointer cast, which isn't needed anyway, and doesn't work
2998 after the EMACS_INT -> ptrdiff_t change.
2999 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
3000 * buffer.h: Adjust decls to match defn changes elsewhere.
3001 (struct buffer_text, struct buffer):
3002 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3003 Use EMACS_INT, not int, where int might not be wide enough.
3004 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3005 not int, to avoid needless 32-bit limit on 64-bit hosts.
3006 (exec_byte_code): Use tighter memory-full test, one that checks
3007 for alloca overflow. Don't compute the address of the object just
3008 before an array, as that's not portable. Use EMACS_INT, not
3009 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
3010 * callint.c (Fcall_interactively):
3011 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3012 * callproc.c (call_process_kill, Fcall_process):
3013 Don't assume pid_t fits into an Emacs fixnum.
3014 (call_process_cleanup, Fcall_process, child_setup):
3015 Don't assume pid_t fits into int.
3016 (call_process_cleanup, Fcall_process, delete_temp_file)
3017 (Fcall_process_region):
3018 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3019 (Fcall_process): Simplify handling of volatile integers.
3020 Use int, not EMACS_INT, where int will do.
3021 * casefiddle.c (casify_object, casify_region, operate_on_word)
3022 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3023 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3024 (casify_object): Avoid integer overflow when overallocating buffer.
3025 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
3026 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
3027 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3028 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3029 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3030 integers are now checked earlier. All uses replaced with XINT.
3032 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3033 For CCL_MapSingle, check that content and value are in int range.
3034 (ccl_driver, Fregister_code_conversion_map):
3035 Check that Vcode_version_map_vector is a vector.
3036 (resolve_symbol_ccl_program): Check that vector header is in range.
3037 Always copy the vector, so that we can check its contents reliably
3038 now rather than having to recheck each instruction as it's being
3039 executed. Check that vector words fit in 'int'.
3040 (ccl_get_compiled_code, Fregister_ccl_program)
3041 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3042 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3043 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3044 contents are in range.
3045 (Fccl_execute_on_string): Check that status is in range.
3046 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3047 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3048 Accept and return EMACS_INT, not int, because callers can pass values
3050 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3051 (multibyte_chars_in_text, parse_str_as_multibyte)
3052 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3053 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3054 (string_escape_byte8, Fget_byte):
3055 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3056 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
3057 avoid mishandling large integers.
3058 * character.h: Adjust decls to match defn changes elsewhere.
3059 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3060 (Ffind_charset_region):
3061 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3062 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3063 (load_charset_map_from_vector, Fdefine_charset_internal):
3064 Don't assume fixnum fits in int.
3065 (load_charset_map_from_vector, Fmap_charset_chars):
3066 Remove now-unnecessary CHECK_NATNUMs.
3067 (Fdefine_charset_internal): Check ranges here, more carefully.
3068 Don't rely on undefined behavior with signed left shift overflow.
3069 Don't assume unsigned int fits into fixnum, or that fixnum fits
3070 into unsigned int. Don't require max_code to be a valid fixnum;
3071 that's not true for gb10830 4-byte on a 32-bit host. Allow
3072 invalid_code to be a cons, for the same reason. Require code_offset
3073 to be a character. Avoid int overflow if max_char is close
3075 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3076 this is intended anyway and avoids some undefined behavior.
3077 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3078 INDEX_TO_CODE_POINT, as that's what it expects.
3079 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
3080 * charset.h (DECODE_CHAR): Return int, not unsigned;
3081 this is what was intended anyway, and it avoids undefined behavior.
3082 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3083 integer-overflow issues.
3084 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3085 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3086 where the argument is EMACS_INT, and this behavior is not intended.
3087 * chartab.c (Fmake_char_table, Fset_char_table_range)
3088 (uniprop_get_decoder, uniprop_get_encoder):
3089 Don't assume fixnum fits in int.
3090 * cmds.c (move_point): New function, that does the gist of
3091 Fforward_char and Fbackward_char, but does so while checking
3092 for integer overflow more accurately.
3093 (Fforward_char, Fbackward_char): Use it.
3094 (Fforward_line, Fend_of_line, internal_self_insert)
3095 (internal_self_insert):
3096 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3097 Fix a FIXME, by checking for integer overflow when calculating
3098 target_clm and actual_clm.
3099 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
3100 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
3101 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3102 (coding_alloc_by_making_gap, alloc_destination)
3103 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3104 (encode_coding_utf_16, detect_coding_emacs_mule)
3105 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3106 (detect_coding_iso_2022, decode_coding_iso_2022)
3107 (encode_invocation_designation, encode_designation_at_bol)
3108 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3109 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3110 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3111 (encode_coding_ccl, encode_coding_raw_text)
3112 (detect_coding_charset, decode_coding_charset)
3113 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3114 (produce_composition, produce_charset, produce_annotation)
3115 (decode_coding, handle_composition_annotation)
3116 (handle_charset_annotation, consume_chars, decode_coding_gap)
3117 (decode_coding_object, encode_coding_object, detect_coding_system)
3118 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3119 (code_convert_region, code_convert_string)
3120 (Fdefine_coding_system_internal)
3121 (coding_set_source, coding_set_destination):
3122 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3123 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3124 (Fdefine_coding_system_internal):
3125 Don't assume fixnums fit in int.
3126 (decode_coding_gap, decode_coding_object, encode_coding_object)
3127 (Fread_coding_system, Fdetect_coding_region)
3128 (Funencodable_char_position, Fcheck_coding_systems_region)
3129 (get_translation, handle_composition_annotation, consume_chars):
3130 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3131 (consume_chars): Rewrite to not calculate an address outside buffer.
3132 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
3133 Don't access memory outside of the args array.
3134 (Fdefine_coding_system_internal): Check for charset-id overflow.
3135 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3136 result of ENCODE_CHAR.
3137 * coding.h: Adjust decls to match defn changes elsewhere.
3138 (struct coding_system):
3139 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3140 * composite.c (get_composition_id, find_composition)
3141 (run_composition_function, update_compositions)
3142 (compose_text, composition_gstring_put_cache)
3143 (composition_gstring_p, composition_gstring_width)
3144 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3145 (composition_compute_stop_pos, composition_reseat_it)
3146 (composition_update_it, struct position_record)
3147 (find_automatic_composition, composition_adjust_point)
3148 (Fcomposition_get_gstring, Ffind_composition_internal):
3149 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3150 (update_compositions):
3151 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3152 * composite.h: Adjust decls to match defn changes elsewhere.
3153 (struct composition):
3154 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3155 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3156 Do not attempt to compute the address of the object just before a
3157 buffer; this is not portable.
3159 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3160 (Faset): Use int, not EMACS_INT, where int is wide enough.
3161 (Fstring_to_number): Don't assume fixnums fit in int.
3162 (Frem): Don't assume arg is nonnegative.
3163 * dbusbind.c (xd_append_arg): Check for integers out of range.
3164 (Fdbus_call_method): Don't overflow the timeout int.
3165 (extract_signed, extract_unsigned): New functions.
3166 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3167 (xd_get_connection_references): Return ptrdiff_t, not int.
3169 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3170 (xd_read_message_1):
3171 Use int, not unsigned, where the dbus API uses int.
3172 (Fdbus_message_internal): Don't overflow mtype.
3173 (syms_of_dbusbind): Allocate right-sized buffer for integers.
3174 * dired.c (directory_files_internal, file_name_completion, scmp)
3175 (file_name_completion_stat):
3176 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3177 (file_name_completion): Don't overflow matchcount.
3178 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3179 * dispextern.h: Adjust decls to match defn changes elsewhere.
3180 (struct text_pos, struct glyph, struct bidi_saved_info)
3181 (struct bidi_string_data, struct bidi_it, struct composition_it)
3183 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3184 (struct display_pos, struct composition_it, struct it):
3185 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3186 * dispnew.c (increment_matrix_positions)
3187 (increment_row_positions, mode_line_string)
3188 (marginal_area_string):
3189 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3190 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
3191 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3192 (duration_to_sec_usec): New function, to check for overflow better.
3193 (Fsleep_for, sit_for): Use it.
3194 * doc.c (get_doc_string, store_function_docstring):
3195 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3196 (get_doc_string, Fsnarf_documentation):
3197 Use int, not EMACS_INT, where int is wide enough.
3199 Use SAFE_ALLOCA, not alloca.
3200 Check for overflow when converting EMACS_INT to off_t.
3201 * doprnt.c (doprnt):
3202 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3203 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3204 Don't assume uid_t fits into fixnum.
3205 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3206 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3207 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3208 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3209 (general_insert_function)
3210 (Finsert_char, make_buffer_string, make_buffer_string_both)
3211 (update_buffer_properties, Fbuffer_substring)
3212 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3213 (Fsubst_char_in_region, check_translation)
3214 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3215 (transpose_markers, Ftranspose_regions):
3216 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3217 (clip_to_bounds): Move to lisp.h as an inline function).
3218 (Fconstrain_to_field): Don't assume integers are nonnegative.
3219 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3220 (Fsubst_char_in_region, Fsave_restriction):
3221 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3222 (Femacs_pid): Don't assume pid_t fits into fixnum.
3223 (lo_time): Use int, not EMACS_INT, when int suffices.
3224 (lisp_time_argument): Check for usec out of range.
3225 (Fencode_time): Don't assume fixnum fits in int.
3226 (Fuser_login_name, Fuser_full_name): Signal an error
3227 if a uid argument is out of range, rather than relying on
3229 (Fformat_time_string): Remove now-unnecessary check.
3230 lisp_time_argument checks for out-of-range usec now.
3231 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
3232 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3233 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3234 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3235 (init_cmdargs, Fdump_emacs):
3236 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3237 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3238 the bottom (typically) 32 bits of the fixnum.
3239 * eval.c (specpdl_size, call_debugger):
3240 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3241 (when_entered_debugger, Fbacktrace_debug):
3242 Don't assume fixnum can fit in int.
3243 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3244 the object just before a buffer; this is not portable.
3245 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3246 (grow_specpdl, unbind_to):
3247 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3248 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3249 (grow_specpdl): Simplify allocation by using xpalloc.
3250 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
3251 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3252 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3253 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3254 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3256 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3257 (Fcopy_file, non_regular_nbytes, read_non_regular)
3258 (Finsert_file_contents):
3259 Use int, not EMACS_INT, where int is wide enough.
3260 (READ_BUF_SIZE): Verify that it fits in int.
3261 (Finsert_file_contents): Check that counts are in proper range,
3262 rather than assuming fixnums fit into ptrdiff_t etc.
3263 Don't assume fixnums fit into int.
3264 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
3265 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3266 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
3267 (string_char_to_byte, string_byte_to_char)
3268 (string_make_multibyte, string_to_multibyte)
3269 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3270 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3271 (substring_both, Fdelete, internal_equal, Ffillarray)
3272 (Fclear_string, mapcar1)
3273 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3274 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3275 (larger_vector, make_hash_table, maybe_resize_hash_table)
3276 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3277 (Fmaphash, secure_hash):
3278 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3279 (concat): Check for string index and length overflow.
3280 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3282 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3283 (larger_vector): New API (vec, incr_min, size_max) replaces old
3284 one (vec, new_size, init). This catches size overflow.
3285 INIT was removed because it was always Qnil.
3286 All callers changed.
3287 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3288 the upper bound on a hash table index size.
3289 (make_hash_table, maybe_resize_hash_table): Use it.
3290 (secure_hash): Computer start_byte and end_byte only after
3291 they're known to be in ptrdiff_t range.
3292 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3293 (Ffont_get_glyphs, Ffont_at):
3294 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3295 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3296 (Flist_fonts, Fopen_font):
3297 Don't assume fixnum can fit in int.
3298 (check_gstring): Don't assume index can fit in int.
3299 (font_match_p): Check that fixnum is a character, not a nonnegative
3300 fixnum, since the later code needs to stuff it into an int.
3301 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3302 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3303 conversion overflow issues.
3304 (Fopen_font): Check for integer out of range.
3305 (Ffont_get_glyphs): Don't assume index can fit in int.
3306 * font.h: Adjust decls to match defn changes elsewhere.
3307 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3309 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3310 printmax_t, where ptrdiff_t is wide enough.
3311 (Finternal_char_font):
3312 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3313 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3314 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3315 (Fset_frame_position, x_set_frame_parameters)
3316 (x_set_line_spacing, x_set_border_width)
3317 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3318 Check that fixnums are in proper range for system types.
3319 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3320 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3321 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3322 Use SAFE_ALLOCA_LISP, not alloca.
3323 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3324 intptr_t is wide enough.
3325 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3326 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3327 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3328 Check for fixnum out of range.
3329 * ftfont.c (ftfont_list): Don't assume index fits in int.
3330 Check that fixnums are in proper range for system types.
3331 (ftfont_shape_by_flt):
3332 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3333 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3334 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3335 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3336 Check that fixnums are in proper range for system types.
3337 * gnutls.h: Adjust decls to match defn changes elsewhere.
3338 * gtkutil.c (xg_dialog_run):
3339 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3340 (update_frame_tool_bar):
3341 Check that fixnums are in proper range for system types.
3342 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
3343 (lookup_image): Check that fixnums are in range for system types.
3344 * indent.c (last_known_column, last_known_column_point):
3345 (current_column_bol_cache):
3346 (skip_invisible, current_column, check_display_width):
3347 (check_display_width, scan_for_column, current_column_1)
3348 (Findent_to, Fcurrent_indentation, position_indentation)
3349 (indented_beyond_p, Fmove_to_column, compute_motion):
3350 (Fcompute_motion, Fvertical_motion):
3351 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3352 (last_known_column_modified): Use EMACS_INT, not int.
3353 (check_display_width):
3355 Check that fixnums and floats are in proper range for system types.
3356 (compute_motion): Don't assume index or fixnum fits in int.
3357 (compute_motion, Fcompute_motion):
3358 Use int, not EMACS_INT, when it is wide enough.
3359 (vmotion): Omit local var start_hpos that is always 0; that way
3360 we don't need to worry about overflow in expressions involving it.
3361 * indent.h: Adjust decls to match defn changes elsewhere.
3363 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3364 Use int, not EMACS_INT, where int is wide enough.
3365 Remove unused members ovstring_chars_done and tab_offset;
3367 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3368 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3369 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3370 (make_gap, copy_text, insert, insert_and_inherit)
3371 (insert_before_markers, insert_before_markers_and_inherit)
3372 (insert_1, count_combining_before, count_combining_after)
3373 (insert_1_both, insert_from_string)
3374 (insert_from_string_before_markers, insert_from_string_1)
3375 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3376 (adjust_after_replace, adjust_after_insert, replace_range)
3377 (replace_range_2, del_range, del_range_1, del_range_byte)
3378 (del_range_both, del_range_2, modify_region)
3379 (prepare_to_modify_buffer, signal_before_change)
3380 (signal_after_change, Fcombine_after_change_execute):
3381 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3382 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3383 (balance_an_interval, split_interval_right, split_interval_left)
3384 (find_interval, next_interval, update_interval)
3385 (adjust_intervals_for_insertion, delete_node, delete_interval)
3386 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3387 (static_offset_intervals, offset_intervals)
3388 (merge_interval_right, merge_interval_left, make_new_interval)
3389 (graft_intervals_into_buffer, temp_set_point_both)
3390 (temp_set_point, set_point, adjust_for_invis_intang)
3391 (set_point_both, move_if_not_intangible, get_property_and_range)
3392 (get_local_map, copy_intervals, copy_intervals_to_string)
3393 (compare_string_intervals, set_intervals_multibyte_1):
3394 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3395 * intervals.h: Adjust decls to match defn changes elsewhere.
3397 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3398 * keyboard.c (this_command_key_count, this_single_command_key_start)
3399 (before_command_key_count, before_command_echo_length, echo_now)
3400 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3401 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3402 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3403 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3404 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3405 (last_non_minibuf_size, last_point_position, echo_truncate)
3406 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3407 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3408 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3409 (stuff_buffered_input):
3410 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3411 (last_auto_save, command_loop_1, read_char):
3412 Use EMACS_INT, not int, to avoid integer overflow.
3413 (record_char): Avoid overflow in total_keys computation.
3414 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3415 * keyboard.h: Adjust decls to match defn changes elsewhere.
3416 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3417 (Fkey_description, Fdescribe_vector, Flookup_key):
3418 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3419 (click_position): New function, to check that positions are in range.
3420 (Fcurrent_active_maps):
3422 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3423 (Faccessible_keymaps, Fkey_description):
3424 (preferred_sequence_p):
3425 Don't assume fixnum can fit into int.
3426 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3427 Check for integer overflow in size calculations.
3428 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3429 avoid mishandling large integers.
3430 * lisp.h: Adjust decls to match defn changes elsewhere.
3431 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3432 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3433 (struct Lisp_Marker):
3434 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3435 (clip_to_bounds): Now an inline function, moved here from editfns.c.
3436 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3437 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3438 All callers changed.
3439 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3440 Assume the arg has valid form, since it always does.
3441 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3442 unsigned integer system type.
3443 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3444 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3445 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3446 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3447 (duration_to_sec_usec): New decl.
3448 * lread.c (read_from_string_index, read_from_string_index_byte)
3449 (read_from_string_limit, readchar, unreadchar, openp)
3450 (read_internal_start, read1, oblookup):
3451 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3452 (Fload, readevalloop, Feval_buffer, Feval_region):
3453 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3454 (openp): Check for out-of-range argument to 'access'.
3455 (read1): Use int, not EMACS_INT, where int is wide enough.
3456 Don't assume fixnum fits into int.
3457 Fix off-by-one error that can read outside a buffer.
3458 (read_filtered_event): Use duration_to_sec_usec
3459 to do proper overflow checking on durations.
3460 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3461 in size calculation.
3462 (Fexecute_kbd_macro):
3463 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3464 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3465 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3466 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3467 (set_marker_both, set_marker_restricted_both, marker_position)
3468 (marker_byte_position, Fbuffer_has_markers_at):
3469 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3470 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
3471 * menu.c (ensure_menu_items): Rename from grow_menu_items.
3472 It now merely ensures that the menu is large enough, without
3473 necessarily growing it, as this avoids some integer overflow issues.
3474 All callers changed.
3475 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3476 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3477 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3478 Use SAFE_ALLOCA_LISP, not alloca.
3479 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3480 to EMACS_INT. Check that fixnums are in proper range for system types.
3481 * minibuf.c (minibuf_prompt_width, string_to_object)
3482 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3483 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3484 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3485 (get_minibuffer, read_minibuf_unwind):
3486 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3487 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3488 this simplifies overflow checking. All callers changed.
3489 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3491 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3492 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3493 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3494 Check that fixnums are in proper range for system types.
3495 (Fx_create_frame, Fx_show_tip):
3496 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3497 * nsfont.m (ns_findfonts, nsfont_list_family):
3498 Don't assume fixnum fits in long.
3499 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3500 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3501 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3503 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
3504 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3505 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3506 (PRINTDECLARE, PRINTPREPARE):
3507 (strout, print_string):
3508 (print, print_preprocess, print_check_string_charset_prop)
3510 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3512 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3513 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3514 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
3515 (printchar, strout): Use xpalloc to catch size calculation overflow.
3516 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
3517 (print_error_message): Use SAFE_ALLOCA, not alloca.
3518 (print_object): Use int, not EMACS_INT, where int is wide enough.
3519 (print_depth, new_backquote_output, print_number_index):
3520 Use ptrdiff_t, not int, where int might not be wide enough.
3521 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3522 (Fset_process_window_size, Fformat_network_address)
3523 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
3525 Check that fixnums are in proper range for system types.
3526 (Fsignal_process): Simplify by avoiding a goto.
3527 Check for process-ids out of pid_t range rather than relying on
3529 (process_tick, update_tick): Use EMACS_INT, not int.
3530 (Fformat_network_address, read_process_output, send_process)
3531 (Fprocess_send_region, status_notify):
3532 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3533 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3534 (wait_reading_process_output, read_process_output, exec_sentinel):
3535 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3536 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3537 (Faccept_process_output): Use duration_to_sec_usec to do proper
3538 overflow checking on durations.
3539 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3540 Don't assume pid_t fits in int.
3541 * process.h (struct Lisp_Process): Members tick and update_tick
3542 are now of type EMACS_INT, not int.
3543 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3544 configured --with-wide-int.
3545 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3546 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3547 * search.c (looking_at_1, string_match_1):
3548 (fast_string_match, fast_c_string_match_ignore_case)
3549 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3550 (scan_newline, find_before_next_newline, search_command)
3551 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3552 (set_search_regs, wordify):
3555 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3556 (string_match_1, search_buffer, set_search_regs):
3558 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3559 (wordify): Check for overflow in size calculation.
3560 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3561 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3562 Check that fixnums are in proper range for system types.
3563 * sound.c (struct sound_device)
3564 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3565 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3566 (Fplay_sound_internal):
3567 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3568 * syntax.c (struct lisp_parse_state, find_start_modiff)
3569 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3570 (Fparse_partial_sexp):
3571 Don't assume fixnums can fit in int.
3572 (struct lisp_parse_state, find_start_pos, find_start_value)
3573 (find_start_value_byte, find_start_begv)
3574 (update_syntax_table, char_quoted, dec_bytepos)
3575 (find_defun_start, prev_char_comend_first, back_comment):
3576 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3577 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3578 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3579 (Finternal_describe_syntax_value): Check that match_lisp is a
3580 character, not an integer, since the code stuffs it into int.
3581 (scan_words, scan_sexps_forward):
3582 Check that fixnums are in proper range for system types.
3584 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3585 (scan_sexps_forward):
3586 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3587 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3588 * syntax.h: Adjust decls to match defn changes elsewhere.
3589 (struct gl_state_s):
3590 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3591 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3592 MOST_POSITIVE_FIXNUM.
3593 * sysdep.c (wait_for_termination_1, wait_for_termination)
3594 (interruptible_wait_for_termination, mkdir):
3595 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3596 (emacs_read, emacs_write):
3597 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3598 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3599 and double all fit in int.
3600 * term.c (set_tty_color_mode):
3601 Check that fixnums are in proper range for system types.
3602 * termhooks.h (struct input_event):
3603 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3604 * textprop.c (validate_interval_range, interval_of)
3605 (Fadd_text_properties, set_text_properties_1)
3606 (Fremove_text_properties, Fremove_list_of_text_properties)
3607 (Ftext_property_any, Ftext_property_not_all)
3608 (copy_text_properties, text_property_list, extend_property_ranges)
3609 (verify_interval_modification):
3610 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3611 (Fnext_single_char_property_change)
3612 (Fprevious_single_char_property_change):
3613 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3614 (copy_text_properties):
3615 Check for integer overflow in index calculation.
3616 * undo.c (last_boundary_position, record_point, record_insert)
3617 (record_delete, record_marker_adjustment, record_change)
3618 (record_property_change):
3619 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3620 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3621 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3622 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3623 (Fx_hide_tip, Fx_file_dialog):
3624 * w32menu.c (set_frame_menubar):
3625 Use ptrdiff_t, not int, for consistency with rest of code.
3626 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3627 (select_window, Fdelete_other_windows_internal)
3628 (window_scroll_pixel_based, window_scroll_line_based)
3629 (Frecenter, Fset_window_configuration):
3630 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3631 (Fset_window_hscroll, run_window_configuration_change_hook)
3632 (set_window_buffer, temp_output_buffer_show, scroll_command)
3633 (Fscroll_other_window, Frecenter):
3634 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3635 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3636 Don't assume fixnum fits in int.
3637 (Fset_window_scroll_bars):
3638 Check that fixnums are in proper range for system types.
3639 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3640 (string_pos, c_string_pos, number_of_chars, init_iterator)
3641 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3642 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3643 (compute_display_string_end, handle_face_prop)
3644 (face_before_or_after_it_pos, handle_invisible_prop)
3645 (handle_display_prop, handle_display_spec, handle_single_display_spec)
3646 (display_prop_intangible_p, string_buffer_position_lim)
3647 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3648 (get_overlay_strings_1, get_overlay_strings)
3649 (iterate_out_of_display_property, forward_to_next_line_start)
3650 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3651 (get_next_display_element, set_iterator_to_next)
3652 (get_visually_first_element, compute_stop_pos_backwards)
3653 (handle_stop_backwards, next_element_from_buffer)
3654 (move_it_in_display_line_to, move_it_in_display_line)
3655 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3656 (add_to_log, message_dolog, message_log_check_duplicate)
3657 (message2, message2_nolog, message3, message3_nolog
3658 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3659 (current_message_1, truncate_echo_area, truncate_message_1)
3660 (set_message, set_message_1, store_mode_line_noprop)
3661 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3662 (text_outside_line_unchanged_p, check_point_in_composition)
3663 (reconsider_clip_changes)
3664 (redisplay_internal, set_cursor_from_row, try_scrolling)
3665 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3666 (redisplay_window, find_last_unchanged_at_beg_row)
3667 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3668 (trailing_whitespace_p, find_row_edges, display_line)
3669 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3670 (display_mode_element, store_mode_line_string)
3671 (pint2str, pint2hrstr, decode_mode_spec)
3672 (display_count_lines, display_string, draw_glyphs)
3673 (x_produce_glyphs, x_insert_glyphs)
3674 (rows_from_pos_range, mouse_face_from_buffer_pos)
3675 (fast_find_string_pos, mouse_face_from_string_pos)
3676 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3677 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3678 (safe_call, init_from_display_pos, handle_fontified_prop)
3679 (handle_single_display_spec, load_overlay_strings)
3680 (with_echo_area_buffer, setup_echo_area_for_printing)
3681 (display_echo_area, echo_area_display)
3682 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3683 (update_tool_bar, hscroll_window_tree, redisplay_internal)
3684 (redisplay_window, dump_glyph_row, display_mode_line)
3685 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
3686 (handle_display_spec, display_prop_string_p):
3687 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3688 (handle_single_display_spec, build_desired_tool_bar_string)
3689 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3690 (get_specified_cursor_type):
3691 Check that fixnums are in proper range for system types.
3692 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3693 (Flookup_image_map):
3694 Don't assume fixnums fit in int.
3695 (compare_overlay_entries):
3696 Avoid mishandling comparisons due to subtraction overflow.
3697 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3698 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3699 (handle_tool_bar_click):
3700 Use int, not unsigned, since we prefer signed and the signedness
3701 doesn't matter here.
3702 (get_next_display_element, next_element_from_display_vector):
3703 Use int, not EMACS_INT, when int is wide enough.
3704 (start_hourglass): Use duration_to_sec_usec to do proper
3705 overflow checking on durations.
3706 * xfaces.c (Fbitmap_spec_p):
3707 Check that fixnums are in proper range for system types.
3708 (compare_fonts_by_sort_order):
3709 Avoid mishandling comparisons due to subtraction overflow.
3710 (Fx_family_fonts, realize_basic_faces):
3711 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3713 Don't assume fixnum fits in int.
3714 Use SAFE_ALLOCA_LISP, not alloca.
3715 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3716 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3717 (face_at_buffer_position, face_for_overlay_string)
3718 (face_at_string_position):
3719 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3720 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3721 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3723 Check that fixnums are in proper range for system types.
3724 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3725 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3726 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3727 (Fx_change_window_property): Don't assume fixnums fit in int.
3728 * xfont.c (xfont_chars_supported):
3729 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3730 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3731 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3732 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3733 * xml.c (parse_region):
3734 * xrdb.c (magic_file_p):
3735 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3736 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3737 (x_get_local_selection, x_reply_selection_request)
3738 (x_handle_selection_request, wait_for_property_change):
3739 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3740 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3741 short is wide enough.
3742 (x_send_client_event): Don't assume fixnum fits in int.
3743 * xterm.c (x_x_to_emacs_modifiers):
3744 Don't assume EMACS_INT overflows nicely into int.
3745 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3747 (handle_one_xevent): NATNUMP can eval its arg twice.
3748 (x_connection_closed):
3749 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3750 * xterm.h: Adjust decls to match defn changes elsewhere.
3751 (struct scroll_bar): Use struct vectorlike_header
3752 rather than rolling our own approximation.
3753 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3755 2012-05-25 Glenn Morris <rgm@gnu.org>
3757 * lisp.mk (lisp): Update for more files being compiled now.
3759 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3761 * lread.c: Remove `read_pure' which makes no difference.
3762 (read_pure): Remove var.
3763 (unreadpure): Remove function.
3764 (readevalloop): Don't call read_list with -1 flag.
3765 (read1, read_vector): Don't test read_pure any more.
3766 (read_list): Simplify.
3768 * fileio.c, character.h: Minor style tweaks.
3770 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3772 * window.h (clip_changed): Remove useless declaration.
3774 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
3776 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3777 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3779 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3782 This directory predates autoconf and is no longer needed nowadays.
3783 Move its few remaining bits of functionality to where they're needed.
3784 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3785 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3786 * m/template.h: Remove.
3787 * Makefile.in (M_FILE): Remove. All uses removed.
3788 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3789 * lisp.h (USE_LSB_TAG):
3790 * mem-limits.h (EXCEEDS_LISP_PTR):
3791 Use VAL_MAX, not VALBITS, in #if.
3792 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3793 (EMACS_UINT): Define unconditionally now.
3794 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3795 (BITS_PER_EMACS_INT): New constants, replacing
3796 what used to be in config.h, but not useful in #if.
3797 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3798 define them any more.
3799 (VAL_MAX): New macro.
3801 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3802 BITS_PER_EMACS_INT, in #if.
3803 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3804 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3805 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3806 * s/ms-w32.h (DATA_START):
3807 Move here from removed file m/intel386.h.
3808 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3809 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3811 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3813 Assume C89 or later.
3814 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3815 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3817 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3818 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3819 * textprop.c, tparam.c (NULL): Remove.
3820 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3821 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3822 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3823 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3824 * xterm.c (input_signal_count): Assume volatile works.
3826 2012-05-21 Ken Brown <kbrown@cornell.edu>
3828 * xgselect.c (xg_select): Fix first argument in call to 'select'
3831 2012-05-20 Ken Brown <kbrown@cornell.edu>
3833 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
3834 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
3836 2012-05-19 Ken Brown <kbrown@cornell.edu>
3838 * xfns.c (x_in_use): Remove `static' qualifier.
3839 * xterm.h (x_in_use): Declare.
3840 * xgselect.c: Include xterm.h.
3841 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3842 and `display_arg' (bug#9754).
3844 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3846 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3848 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3849 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3851 2012-05-18 Eli Zaretskii <eliz@gnu.org>
3853 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3855 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
3856 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
3858 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3859 reference to image_cache->refcount.
3860 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3862 2012-05-17 Juri Linkov <juri@jurta.org>
3864 * search.c (Fword_search_regexp, Fword_search_backward)
3865 (Fword_search_forward, Fword_search_backward_lax)
3866 (Fword_search_forward_lax): Move functions to isearch.el
3867 (bug#10145, bug#11381).
3869 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3871 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3873 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3875 * lread.c (init_obarray): Declare Qt and Qnil as special.
3877 2012-05-14 Glenn Morris <rgm@gnu.org>
3879 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
3880 Put "libexec" before "bin", for the sake of init_callproc_1.
3882 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3884 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3886 * unexaix.c: Port to more-recent AIX compilers.
3887 (report_error, report_error_1, make_hdr, copy_sym)
3888 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3889 Make arguments const char *, not char *, to avoid violations of C
3890 standard and to fix some AIX warnings reported by Gilles Pion.
3892 2012-05-14 Eli Zaretskii <eliz@gnu.org>
3894 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3895 already have overlays loaded.
3896 (handle_single_display_spec): Before returning without displaying
3897 fringe bitmap, synchronize the bidi iterator with the main display
3898 iterator, by calling iterate_out_of_display_property.
3899 (iterate_out_of_display_property): Detect buffer iteration by
3900 testing that it->string is a Lisp string.
3901 (get_next_display_element): When the current object is exhausted,
3902 and there's something on it->stack, call set_iterator_to_next to
3903 proceed with what's on the stack, instead of returning zero.
3904 (set_iterator_to_next): If called at the end of a Lisp string,
3905 proceed to consider_string_end without incrementing string
3906 position. Don't increment display vector index past the end of
3907 the display vector. (Bug#11417)
3908 (pos_visible_p): Don't report a position visible when move_it_to
3909 stopped at the last line of window, which happens to be scanned
3910 backwards by the bidi iteration. (Bug#11464)
3912 2012-05-14 Eli Zaretskii <eliz@gnu.org>
3914 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3915 and right-margin display specs even if the spec is invalid or we
3916 are on a TTY, and thus unable to display on the fringes.
3917 That's because the text with the property will not be displayed anyway,
3918 so we need to signal to the caller that this is a "replacing"
3919 display spec. This fixes display when the spec is invalid or we
3922 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3924 * unexaix.c (make_hdr): Fix typo in prototype.
3925 This bug broke the build on AIX. Problem reported by Gilles Pion.
3927 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
3929 * keyboard.c (kbd_buffer_get_event): Read special events also in
3930 batch mode. (Bug#11415)
3932 2012-05-12 Glenn Morris <rgm@gnu.org>
3934 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3936 2012-05-12 Eli Zaretskii <eliz@gnu.org>
3938 * lisp.mk (lisp): Add newcomment.elc.
3940 2012-05-12 Glenn Morris <rgm@gnu.org>
3942 * Makefile.in (MKDIR_P): New, set by configure.
3943 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3945 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3947 Remove unused function hourglass_started.
3948 * dispextern.h (hourglass_started):
3949 * w32fns.c (hourglass_started):
3950 * xdisp.c (hourglass_started): Remove.
3952 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
3954 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3955 Update dependencies.
3957 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3959 * xgselect.c (xg_select): Put maxfds+1 into a var.
3960 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3962 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3964 2012-05-10 Dave Abrahams <dave@boostpro.com>
3966 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3967 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3969 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
3971 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3972 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3973 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3974 Initialize xd_registered_buses.
3976 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3978 Untag more efficiently if USE_LSB_TAG.
3979 This is based on a proposal by YAMAMOTO Mitsuharu in
3980 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3981 For an admittedly artificial (nth 8000 longlist) benchmark on
3982 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3983 Emacs's overall text size by 1%.
3984 * lisp.h (XUNTAG): New macro.
3985 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3986 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3987 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3988 * eval.c (Fautoload):
3989 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3990 * frame.h (XFRAME): Use XUNTAG.
3992 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3993 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3994 Remove unportable assumptions about print widths of types like
3996 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3997 intptr_t when converting between pointer and integer, to avoid GCC
3998 warnings about wrong width.
4000 2012-05-09 Eli Zaretskii <eliz@gnu.org>
4002 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4003 stack for each reader_thread, instead of defaulting to 8MB
4004 determined by the linker. This avoids failures in creating
4005 subprocesses on Windows 7, see the discussion in this thread:
4006 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4008 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4010 Fix up display of the *Minibuf-0* buffer in the mini window.
4011 * keyboard.c (read_char): Don't clear the echo area if there's no
4013 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
4014 contents of *Minibuf-0*) if there's no message displayed in its stead.
4016 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
4018 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4021 2012-05-06 Chong Yidong <cyd@gnu.org>
4023 * lisp.mk (lisp): Update.
4025 2012-05-05 Jim Meyering <meyering@redhat.com>
4027 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4029 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4031 * data.c (PUT_ERROR): New macro.
4032 (syms_of_data): Use it. Add new error type `user-error'.
4033 * undo.c (user_error): New function.
4034 (Fprimitive_undo): Use it.
4035 * print.c (print_error_message): Adjust print style for `user-error'.
4036 * keyboard.c (user_error): New function.
4037 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4039 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4041 Do not limit current-time-string to years 1000..9999.
4042 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4043 (Fcurrent_time_string): Support any year that is supported by the
4044 underlying localtime representation. Don't use asctime, as it
4045 has undefined behavior for years outside the range -999..9999.
4047 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4049 Fix race conditions involving setenv, gmtime, localtime, asctime.
4050 Without this fix, interrupts could mess up code that uses these
4051 nonreentrant functions, since setting TZ invalidates existing
4052 tm_zone or tzname values, and since most of these functions return
4053 pointers to static storage.
4054 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4055 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4056 Grow the critical sections to include not just invoking
4057 localtime/gmtime, but also accessing these functions' results
4058 including their tm_zone values if any, and any related TZ setting.
4059 (format_time_string): Last arg is now struct tm *, not struct tm **,
4060 so that the struct tm is saved in the critical section.
4061 All callers changed. Simplify allocation of initial buffer, partly
4062 motivated by the fact that memory allocation needs to be outside
4063 the critical section.
4065 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4067 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4068 with RESET_INTERVAL.
4070 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4071 Remove duplicated buffer name initialization.
4073 2012-05-02 Jim Meyering <jim@meyering.net>
4075 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4077 * xfns.c (x_window): Use xstrdup (Bug#11375).
4079 2012-05-02 Eli Zaretskii <eliz@gnu.org>
4081 * xdisp.c (pos_visible_p): If already at a newline from the
4082 display string before the 'while' loop, don't walk back the glyphs
4083 from it3.glyph_row. Solves assertion violation when the display
4084 string begins with a newline (egg.el). (Bug#11367)
4086 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4088 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4091 2012-05-01 Glenn Morris <rgm@gnu.org>
4093 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4094 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4095 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4096 All were removed before 23.1.
4098 * dispnew.c: Remove HAVE_LIBNCURSES test;
4099 it is always true on relevant platforms.
4101 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4102 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4104 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4106 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4108 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4109 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4112 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4114 Do not avoid creating empty evaporating overlays (Bug#9642).
4115 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4116 That is, do not delete an evaporating overlay if it becomes
4117 empty after its bounds are adjusted to fit within its buffer.
4118 This fix caused other problems, and I'm reverting it until we get
4119 to the bottom of them.
4121 2012-04-27 Chong Yidong <cyd@gnu.org>
4123 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4125 2012-04-27 Eli Zaretskii <eliz@gnu.org>
4127 * xdisp.c (pos_visible_p): If the window start position is beyond
4128 ZV, start the display from buffer beginning. Prevents assertion
4129 violation in init_iterator when the minibuffer window is scrolled
4132 * window.c (window_scroll_pixel_based): Likewise.
4134 2012-04-27 Chong Yidong <cyd@gnu.org>
4136 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4138 2012-04-27 Glenn Morris <rgm@gnu.org>
4140 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4141 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4143 2012-04-27 Eli Zaretskii <eliz@gnu.org>
4145 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4146 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
4148 2012-04-26 Eli Zaretskii <eliz@gnu.org>
4150 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4151 display element, check also the underlying string or buffer
4152 character. (Bug#11341)
4154 * w32menu.c: Include w32heap.h.
4155 (add_menu_item): If the call to AppendMenuW (via
4156 unicode_append_menu) fails, disable Unicode menus only if we are
4157 running on Windows 9X/Me.
4159 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4161 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4162 (xgetint): Add missing shift for LSB tags.
4164 2012-04-24 Martin Rudalics <rudalics@gmx.at>
4166 * keyboard.c (read_char): Don't wipe echo area for select window
4167 events: These might get delayed via `mouse-autoselect-window'
4170 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
4172 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4173 manipulation of :loaded-from data.
4175 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
4177 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4178 now a cons (bug#11311).
4180 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4182 Do not create empty overlays with the evaporate property (Bug#9642).
4183 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4184 if it becomes empty after its bounds are adjusted to fit within
4185 its buffer. Without this fix, in a nonempty buffer (let ((o
4186 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4187 yields an empty overlay that has the evaporate property, which is
4188 not supposed to happen.
4190 Fix minor GTK3 problems found by static checking.
4191 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4192 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4193 (struct _EmacsFixedClass, emacs_fixed_get_type):
4194 Move decls here from emacsgtkfixed.h, since they needn't be public.
4195 (emacs_fixed_get_type): Now static.
4196 (emacs_fixed_class_init): Omit unused local.
4197 (emacs_fixed_child_type): Remove; unused.
4198 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4199 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4200 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4201 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4202 (EMACS_FIXED_GET_CLASS): Remove; unused.
4203 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4205 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4206 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4208 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4210 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
4211 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
4212 (__malloc_size_t, __malloc_ptrdiff_t):
4213 Remove. All uses removed, replaced by the definiens if needed,
4214 since we can assume C89 or better now.
4215 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4216 (protect_malloc_state, align, get_contiguous_space)
4217 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4218 (malloc_atfork_handler_child, malloc_enable_thread)
4219 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4220 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4221 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4222 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4223 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4224 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4225 Define using prototypes, not old style.
4226 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4227 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4228 (align): Don't assume that signed integer overflow wraps around.
4229 Omit unused local var.
4230 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4231 (_free_internal_nolock, memalign, mallochook, reallochook):
4232 Omit no-longer-needed casts.
4233 (valloc): Use getpagesize, not __getpagesize.
4234 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4235 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4237 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4239 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
4241 Move functions from C to Lisp. Make non-blocking method calls
4242 the default. Implement further D-Bus standard interfaces.
4244 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4245 (QCdbus_request_name_allow_replacement)
4246 (QCdbus_request_name_replace_existing)
4247 (QCdbus_request_name_do_not_queue)
4248 (QCdbus_request_name_reply_primary_owner)
4249 (QCdbus_request_name_reply_in_queue)
4250 (QCdbus_request_name_reply_exists)
4251 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4252 (QCdbus_registered_serial, QCdbus_registered_method)
4253 (QCdbus_registered_signal): New Lisp objects.
4254 (XD_DEBUG_MESSAGE): Use sizeof.
4255 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4256 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4257 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4258 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4259 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4260 (xd_signature, xd_append_arg): Allow float for integer types.
4261 (xd_get_connection_references): New function.
4262 (xd_get_connection_address): Rename from xd_initialize.
4263 Return cached address.
4264 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4265 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4267 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
4268 Return number of refcounts.
4269 (Fdbus_get_unique_name): Make stronger parameter check.
4270 (Fdbus_message_internal): New defun.
4271 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4272 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4273 (Fdbus_send_signal, Fdbus_register_service)
4274 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4275 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4276 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4277 (Vdbus_compiled_version, Vdbus_runtime_version)
4278 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4279 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4280 (Vdbus_message_type_signal): New defvars.
4281 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4284 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4286 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4287 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4288 Do not assume ptrdiff_t is the same width as 'int'.
4290 * alloc.c: Handle unusual debugging option combinations.
4291 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4292 since the two debugging options are incompatible.
4293 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4295 (mem_init, mem_insert, mem_insert_fixup):
4296 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4297 (NEED_MEM_INSERT): Remove; no longer needed.
4299 2012-04-22 Leo Liu <sdl.web@gmail.com>
4301 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4303 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4305 * sysdep.c [__FreeBSD__]: Minor cleanups.
4306 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4307 Use Emacs indenting style more consistently. Avoid some casts.
4308 Use 'double' consistently rather than mixing 'float' and 'double'.
4310 2012-04-21 Eduard Wiebe <usenet@pusto.de>
4312 * sysdep.c (list_system_processes, system_process_attributes):
4313 Add implementation for FreeBSD (Bug#5243).
4315 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4317 * lisp.mk (lisp): Update.
4319 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4321 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4322 It is never used otherwise.
4324 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4326 * print.c (print_preprocess): Only check print_depth if print-circle
4328 (print_object): Check for cycles even when print-circle is nil and
4329 print-gensym is t, but only check print_depth if print-circle is nil.
4331 2012-04-20 Chong Yidong <cyd@gnu.org>
4333 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4334 set the status to "failed" and ensure that sentinel is run.
4336 2012-04-20 Glenn Morris <rgm@gnu.org>
4338 * process.c (Fset_process_inherit_coding_system_flag)
4339 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4340 (Fmake_network_process, Fmake_serial_process): Doc fix.
4342 2012-04-20 Eli Zaretskii <eliz@gnu.org>
4344 * xdisp.c (string_buffer_position_lim): Limit starting position to
4346 (set_cursor_from_row): If called for a mode-line or header-line
4347 row, return zero immediately.
4348 (try_cursor_movement): If inside continuation line, don't back up
4349 farther than the first row after the header line, if any.
4350 Don't consider the header-line row as "partially visible", even if
4351 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4353 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4355 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4358 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
4359 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
4361 configure: new option --enable-gcc-warnings (Bug#11207)
4362 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4363 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4364 (ALL_CFLAGS): Use new macros rather than old.
4365 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4366 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4367 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4368 -Wunused-result, -Wunused-variable. This should go away once
4369 the Emacs and Gnulib regex code is merged.
4370 (xmalloc, xrealloc): Now static.
4372 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4374 * dired.c (Fsystem_groups): Remove unused local.
4376 2012-04-17 Glenn Morris <rgm@gnu.org>
4378 * dired.c (Fsystem_users): Doc fix.
4380 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4382 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4383 (syms_of_dired): Add them.
4385 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4387 Fix minor alloc.c problems found by static checking.
4388 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4389 New extern decls, to avoid calling undeclared functions.
4390 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4391 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4392 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4393 (NEED_MEM_INSERT): New macro.
4394 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4395 Remove one incorrect comment and fix another.
4397 Fix minor ralloc.c problems found by static checking.
4398 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4399 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4400 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4401 (r_alloc_sbrk): Now static.
4403 Improve ralloc.c interface checking.
4404 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4405 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4406 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4407 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4408 [REL_ALLOC]: ... to here, to check interface.
4409 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4410 Remove decls. This fixes an "It stinks!".
4412 * alloc.c (which_symbols): Fix alignment issue / type clash.
4414 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4416 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4417 (struct Lisp_Misc_Any): Likewise.
4418 (struct Lisp_Free): Likewise.
4419 * alloc.c (union aligned_Lisp_Symbol): Define.
4420 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4421 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4422 (union aligned_Lisp_Misc): Define.
4423 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4424 aligned_Lisp_Misc instead of union Lisp_Misc.
4425 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
4427 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4429 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4430 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4431 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4432 * s/netbsd.h, s/sol2-6.h:
4433 Remove definition of GC_MARK_STACK, since the default now works.
4434 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4435 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4436 no longer the default.
4437 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4439 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4441 * lread.c (lisp_file_lexically_bound_p):
4442 Fix hang at ";-*-\n" (bug#11238).
4444 2012-04-14 Eli Zaretskii <eliz@gnu.org>
4446 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4447 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4449 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4451 * nsterm.m (constrainFrameRect): Always constrain when there is only
4452 one screen (Bug#10962).
4454 2012-04-13 Ken Brown <kbrown@cornell.edu>
4456 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4458 2012-04-13 Reuben Thomas <rrt@sc3d.org>
4460 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4462 2012-04-11 Daniel Colascione <dancol@dancol.org>
4464 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4465 against is gone. It's better to use vfork now so that when Cygwin
4466 gains a new, working vfork, we use it automatically (bug#10398).
4468 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4470 * window.c (save_window_save): Obey window-point-insertion-type.
4472 2012-04-11 Glenn Morris <rgm@gnu.org>
4474 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4476 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4478 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4480 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
4482 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4483 (force_quit_count): New var.
4484 (handle_interrupt): Use it.
4486 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
4488 * w32.c (w32_delayed_load): Record the full path of the library
4489 being loaded (bug#10424).
4491 2012-04-09 Glenn Morris <rgm@gnu.org>
4493 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4494 not just in the obarray, before snarfing them. (Bug#11036)
4496 * Makefile.in ($(leimdir)/leim-list.el):
4497 Pass EMACS rather than BUILT_EMACS.
4499 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4501 * process.c (make_process):
4502 * process.h: Add integer `gnutls_handshakes_tried' member to
4505 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4506 Add convenience `GNUTLS_LOG2i' macro.
4508 * gnutls.c (gnutls_log_function2i): Convenience log function.
4509 (emacs_gnutls_read): Use new log functions,
4510 `gnutls_handshakes_tried' process member, and
4511 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4512 attempts per process (connection).
4514 2012-04-09 Chong Yidong <cyd@gnu.org>
4516 * eval.c (Fuser_variable_p, user_variable_p_eh)
4517 (lisp_indirect_variable): Functions deleted.
4518 (Fdefvar): Caller changed.
4520 * callint.c (Finteractive, Fcall_interactively):
4521 * minibuf.c (Fread_variable): Callers changed.
4523 2012-04-09 Eli Zaretskii <eliz@gnu.org>
4525 * xdisp.c (set_cursor_from_row): If the display string appears in
4526 the buffer at position that is closer to point than the position
4527 after the display string, display the cursor on the first glyph of
4528 the display string. Fixes cursor display when a 'display' text
4529 property immediately follows invisible text. (Bug#11094)
4531 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4533 composite.c: use 'double' consistently
4534 * composite.c (get_composition_id): Use 'double' consistently
4535 instead of converting 'float' to 'double' and vice versa; this is
4536 easier to understand and avoids a GCC warning.
4538 2012-04-09 Glenn Morris <rgm@gnu.org>
4540 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4541 preparation for dumping it with emacs. (Bug#4789)
4542 (leimdir): New variable.
4543 ($(leimdir)/leim-list.el): New rule.
4544 (emacs$(EXEEXT)): Depend on leim-list.el.
4546 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4547 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4548 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4550 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4552 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4555 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
4557 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4558 Remove unused local variable.
4560 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4562 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4563 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4564 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4565 objects, as mark_maybe_pointer will catch them otherwise.
4566 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4567 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4569 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4571 Fix typo that broke non-Windows builds.
4572 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4574 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4576 Support building on MS-Windows with libxml2.
4578 * makefile.w32-in (OBJ2): Add xml.$(O).
4579 (GLOBAL_SOURCES): Add xml.c.
4580 ($(BLD)/xml.$(O)): New dependency list.
4582 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4583 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4584 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4585 [!WINDOWSNT]: New macros.
4586 (init_libxml2_functions, libxml2_loaded_p): New functions.
4587 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4588 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4589 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4590 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4592 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4593 Call init_libxml2_functions before calling libxml2 functions.
4594 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4596 * emacs.c: Don't include libxml/parser.h.
4597 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4598 xmlCleanupParser directly.
4600 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4602 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4604 * indent.c (Fvertical_motion): If there is a display string at
4605 point, use it.vpos to compute how many lines to backtrack after
4606 move_it_to point. (Bug#11133)
4608 2012-04-06 Eli Zaretskii <eliz@gnu.org>
4610 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4611 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4612 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4613 macros related to unification of CJK characters. For the details,
4614 see the discussion following the message here:
4615 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4617 2012-04-04 Chong Yidong <cyd@gnu.org>
4619 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4621 2012-04-01 Eli Zaretskii <eliz@gnu.org>
4623 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4624 instead of alloca. (Bug#11138)
4626 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4628 * w32menu.c (is_simple_dialog): Properly check lisp types.
4631 2012-03-31 Eli Zaretskii <eliz@gnu.org>
4633 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4634 position we get to after a call to move_it_to fails the
4635 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4636 only if we wind up in a string from display property. (Bug#11063)
4638 * window.c (Fdelete_other_windows_internal): Invalidate the row
4639 and column information about mouse highlight, so that redisplay
4640 restores it after reallocating the glyph matrices. (Bug#7464)
4642 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4643 string comes from a `display' text property, use the buffer
4644 position of that property as if we actually saw that position in
4646 (move_it_by_lines): Remove the assertion that
4647 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4648 violated when there's a before-string at the beginning of a line.
4651 2012-03-30 Eli Zaretskii <eliz@gnu.org>
4653 * xdisp.c (append_space_for_newline): If the default face was
4654 remapped, use the remapped face for the appended newline.
4655 (extend_face_to_end_of_line): Use the remapped default face for
4656 extending the face to the end of the line.
4657 (display_line): Call extend_face_to_end_of_line when the default
4658 face was remapped. (Bug#11068)
4660 2012-03-29 Eli Zaretskii <eliz@gnu.org>
4662 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4664 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4666 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4668 2012-03-27 Glenn Morris <rgm@gnu.org>
4670 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4673 2012-03-26 Kenichi Handa <handa@m17n.org>
4675 * dispextern.h (struct glyph): Fix previous change. Change the
4676 bit length of glyphless.ch to 25 (Bug#11082).
4678 2012-03-26 Chong Yidong <cyd@gnu.org>
4680 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4681 (command_loop_1): Use it; inhibit selection update for
4682 handle-select-window too (Bug#8996).
4684 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4686 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
4688 2012-03-25 Kenichi Handa <handa@m17n.org>
4690 * dispextern.h (struct glyph): Change the bit length of
4691 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4693 2012-03-24 Eli Zaretskii <eliz@gnu.org>
4695 * s/ms-w32.h (tzname): Include time.h before redirecting to
4696 _tzname. Fixes the MSVC build. (Bug#9960)
4698 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4700 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4703 * xterm.c (XTread_socket): Only modify handling_signal if
4704 !SYNC_INPUT. (Bug#11080)
4706 2012-03-23 Eli Zaretskii <eliz@gnu.org>
4708 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4709 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4710 when fetching a multibyte character consumes more bytes than
4711 CHAR_BYTES returns, due to unification of CJK characters in
4712 string_char. (Bug#11073)
4714 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4716 * process.c (wait_reading_process_output): Handle pty disconnect
4717 by refraining from sending oneself a SIGCHLD (bug#10933).
4719 2012-03-22 Chong Yidong <cyd@gnu.org>
4721 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4723 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
4724 Mark string as coming from a prefix property.
4725 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4726 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4728 2012-03-21 Chong Yidong <cyd@gnu.org>
4730 * xfaces.c (Vface_remapping_alist): Doc fix.
4732 2012-03-20 Eli Zaretskii <eliz@gnu.org>
4734 * w32proc.c (Fw32_set_console_codepage)
4735 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4738 2012-03-20 Chong Yidong <cyd@gnu.org>
4740 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4741 to reflect default non-nil value of redisplay-dont-pause.
4743 2012-03-19 Kenichi Handa <handa@m17n.org>
4745 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4746 it fit in a valid range (Bug#11003).
4748 2012-03-18 Eli Zaretskii <eliz@gnu.org>
4750 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4751 that is not from display property, accept the row as a "cursor
4752 row" if one of the string's character has a non-nil `cursor'
4753 property. Fixes cursor positioning when there are newlines in
4754 overlay strings, e.g. in icomplete.el. (Bug#11035)
4756 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4758 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4760 2012-03-12 Chong Yidong <cyd@gnu.org>
4762 * eval.c (inhibit_lisp_code): Rename from
4763 inhibit_window_configuration_change_hook; move from window.c.
4765 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4766 * window.c (run_window_configuration_change_hook)
4767 (syms_of_window): Callers changed.
4769 2012-03-11 Chong Yidong <cyd@gnu.org>
4771 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4773 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4775 2012-03-10 Chong Yidong <cyd@gnu.org>
4777 * frame.c (other_visible_frames): Don't assume the selected frame
4778 is visible (Bug#10955).
4780 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4782 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4784 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4786 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4787 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4790 2012-03-03 Glenn Morris <rgm@gnu.org>
4792 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
4794 2012-03-02 Eli Zaretskii <eliz@gnu.org>
4796 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4797 position past the first glyph_row that ends at ZV. (Bug#10902)
4798 (redisplay_window, next_element_from_string): Fix typos in
4800 (redisplay_window): Pass to move_it_vertically the margin in
4801 pixels, not in screen lines.
4803 2012-03-02 Glenn Morris <rgm@gnu.org>
4805 * buffer.c (buffer-list-update-hook): Doc fix.
4807 2012-02-29 Eli Zaretskii <eliz@gnu.org>
4809 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4810 push_it before setting up the iterator for the first overlay
4811 string, even if we have an empty string loaded.
4812 (next_overlay_string): If there's an empty string on the iterator
4813 stack, pop the stack. (Bug#10903)
4815 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4817 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4818 Suggested by Stefan Monnier in
4819 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4820 * alloc.c (widen_to_Lisp_Object): New static function.
4821 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4822 and widening them to Lisp_Objects. This would work even if
4823 USE_LSB_TAG is defined and wide integers are used, which might
4824 happen in a future version of Emacs.
4826 2012-02-25 Chong Yidong <cyd@gnu.org>
4828 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4831 * xselect.c (Fx_selection_exists_p): Doc fix.
4832 (x_clipboard_manager_save_all): Print an informative message
4833 before saving to clipboard manager.
4835 2012-02-24 Chong Yidong <cyd@gnu.org>
4837 * keyboard.c (process_special_events): Handle all X selection
4838 requests in kbd_buffer, not just the next one (Bug#8869).
4840 2012-02-23 Chong Yidong <cyd@gnu.org>
4842 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4843 call when setting menu-bar-lines and tool-bar-lines parameters.
4844 (unwind_create_frame_1): New helper function.
4846 * window.c (inhibit_window_configuration_change_hook): New var.
4847 (run_window_configuration_change_hook): Obey it.
4848 (syms_of_window): Initialize it.
4850 2012-02-22 Chong Yidong <cyd@gnu.org>
4852 * xterm.c (x_draw_image_relief): Add missing type check for
4853 Vtool_bar_button_margin (Bug#10743).
4855 2012-02-21 Chong Yidong <cyd@gnu.org>
4857 * fileio.c (Vfile_name_handler_alist): Doc fix.
4859 * buffer.c (Fget_file_buffer): Protect against invalid file
4860 handler return value.
4862 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4864 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4865 when computing $valmask.
4867 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4868 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4869 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4870 It's useless in that case, and it can cause problems on hosts
4871 that allocate halves of EMACS_INT values separately.
4872 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4873 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4874 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4875 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4876 it avoids undefined behavior on hosts where shifting right by more
4877 than the word width has undefined behavior.
4879 2012-02-19 Chong Yidong <cyd@gnu.org>
4881 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4882 (Funhandled_file_name_directory, Ffile_name_as_directory)
4883 (Fdirectory_file_name, Fexpand_file_name)
4884 (Fsubstitute_in_file_name): Protect against invalid file handler
4885 return values (Bug#10845).
4887 2012-02-18 Eli Zaretskii <eliz@gnu.org>
4889 * .gdbinit (pitx): Fix incorrect references to fields of the
4892 2012-02-17 Chong Yidong <cyd@gnu.org>
4894 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4896 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4898 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4899 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4901 2012-02-15 Chong Yidong <cyd@gnu.org>
4903 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4904 marked as special. Also, starting docstrings with * is obsolete.
4906 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4908 * gnutls.c (emacs_gnutls_write): Fix last change.
4910 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4912 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4915 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4917 * keymap.c (Fsingle_key_description): Handle char ranges.
4919 2012-02-12 Chong Yidong <cyd@gnu.org>
4921 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4922 as that creates a dangerous corner case.
4924 * window.c (Fdelete_window_internal): Invalidate the mouse
4925 highlight (Bug#9904).
4927 2012-02-12 Glenn Morris <rgm@gnu.org>
4929 * xselect.c (Fx_own_selection_internal)
4930 (Fx_get_selection_internal, Fx_disown_selection_internal)
4931 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4932 * nsselect.m (Fx_own_selection_internal)
4933 (Fx_disown_selection_internal, Fx_selection_exists_p)
4934 (Fx_selection_owner_p, Fx_get_selection_internal):
4935 Sync docs and argument specs with the xselect.c versions.
4937 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4939 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4941 2012-02-11 Eli Zaretskii <eliz@gnu.org>
4943 * w32select.c (Fx_selection_exists_p): Sync doc string and
4944 argument list with xselect.c. (Bug#10783)
4946 * w16select.c (Fx_selection_exists_p): Sync doc string and
4947 argument list with xselect.c. (Bug#10783)
4949 2012-02-10 Glenn Morris <rgm@gnu.org>
4951 * fns.c (Fsecure_hash): Doc fix.
4953 2012-02-09 Kenichi Handa <handa@m17n.org>
4955 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4957 2012-02-07 Chong Yidong <cyd@gnu.org>
4959 * buffer.c (Fbuffer_local_variables)
4960 (buffer_lisp_local_variables): Handle unbound vars correctly;
4961 don't let Qunbound leak into Lisp.
4963 2012-02-07 Glenn Morris <rgm@gnu.org>
4965 * image.c (Fimagemagick_types): Doc fix.
4967 * image.c (imagemagick-render-type): Change it from a lisp object
4968 to an integer. Move the doc here from the lisp manual.
4969 Treat all values not equal to 0 the same.
4971 2012-02-06 Chong Yidong <cyd@gnu.org>
4973 * doc.c (store_function_docstring): Avoid applying docstring of
4974 alias to base function (Bug#2603).
4976 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4978 * .gdbinit (pp1, pv1): Remove redundant defines.
4981 2012-02-04 Chong Yidong <cyd@gnu.org>
4983 * nsterm.m: Declare a global (Bug#10694).
4985 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4987 * w32.c (get_emacs_configuration_options):
4988 Include --enable-checking, if specified, in the return value.
4990 2012-02-04 Martin Rudalics <rudalics@gmx.at>
4992 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4993 after rounding frame sizes. (Bug#9723)
4995 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4997 * keyboard.c (adjust_point_for_property): Don't position point
4998 before BEGV. (Bug#10696)
5000 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5002 Handle overflow when computing char display width (Bug#9496).
5003 * character.c (char_width): Return EMACS_INT, not int.
5004 (char_width, c_string_width): Check for overflow when
5005 computing the width; this is possible now that individual
5006 characters can have unbounded width. Problem introduced
5007 by merge from Emacs 23 on 2012-01-19.
5009 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
5011 * dbusbind.c (Fdbus_register_method): Mention the return value
5012 :ignore in the docstring.
5014 2012-02-02 Glenn Morris <rgm@gnu.org>
5016 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5018 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5019 Unconditionally set to t. (Bug#10673)
5020 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5021 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5022 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5024 2012-02-02 Kenichi Handa <handa@m17n.org>
5026 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5027 0, do not call append_composite_glyph.
5029 2012-02-02 Kenichi Handa <handa@m17n.org>
5031 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5033 (x_produce_glyphs): If the component of a composition is a null
5034 string, set it->pixel_width to 1 to avoid zero-width glyph.
5036 2012-02-01 Eli Zaretskii <eliz@gnu.org>
5038 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5039 first 2 arguments are identical. This makes inserting large
5040 output from a subprocess an order of magnitude faster on
5041 MS-Windows, where all sbrk'ed memory is always contiguous.
5043 2012-01-31 Glenn Morris <rgm@gnu.org>
5045 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5046 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5047 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5049 2012-01-29 Glenn Morris <rgm@gnu.org>
5051 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5053 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5055 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5057 2012-01-28 Chong Yidong <cyd@gnu.org>
5059 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5061 2012-01-26 Chong Yidong <cyd@gnu.org>
5063 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5065 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5066 repeat counts (Bug#10507).
5068 2012-01-26 Glenn Morris <rgm@gnu.org>
5070 * lread.c (syms_of_lread): Doc fix.
5072 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5074 * coding.c (encode_designation_at_bol): Change return value to
5077 2012-01-25 Chong Yidong <cyd@gnu.org>
5079 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5081 2012-01-21 Chong Yidong <cyd@gnu.org>
5083 * floatfns.c (Fcopysign): Make the second argument non-optional,
5084 since nil is not allowed anyway.
5086 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5088 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5089 (send_process): Likewise.
5091 2012-01-19 Martin Rudalics <rudalics@gmx.at>
5093 * window.c (save_window_save, Fcurrent_window_configuration)
5094 (Vwindow_persistent_parameters): Do not use Qstate.
5095 Rewrite doc-strings.
5097 2012-01-19 Kenichi Handa <handa@m17n.org>
5099 * character.c (char_width): New function.
5100 (Fchar_width, c_string_width, lisp_string_width):
5101 Use char_width (Bug#9496).
5103 2012-01-16 Martin Rudalics <rudalics@gmx.at>
5105 * window.c (Vwindow_persistent_parameters): New variable.
5106 (Fset_window_configuration, save_window_save): Handle persistent
5109 2012-01-14 Eli Zaretskii <eliz@gnu.org>
5111 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5112 thrashing the stack of the thread. (Bug#9087)
5114 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5116 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5118 2012-01-11 Eli Zaretskii <eliz@gnu.org>
5120 * xdisp.c (rows_from_pos_range): Handle the case where the
5121 highlight ends on a newline. (Bug#10464)
5122 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5123 he end column for display of highlight that ends on a newline
5126 2012-01-11 Glenn Morris <rgm@gnu.org>
5128 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5129 from load-path also when installation-directory is nil. (Bug#10208)
5131 2012-01-10 Glenn Morris <rgm@gnu.org>
5133 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5135 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5136 Update template values to be closer to their typical values these days.
5138 2012-01-09 Eli Zaretskii <eliz@gnu.org>
5140 * xdisp.c (rows_from_pos_range): Accept additional argument
5141 DISP_STRING, and accept any glyph in a row whose object is that
5142 string as eligible for mouse highlight. Fixes mouse highlight of
5143 display strings from overlays. (Bug#10464)
5145 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
5147 emacs: fix an auto-save permissions race condition (Bug#10400)
5148 * fileio.c (auto_saving_dir_umask): New static var.
5149 (Fmake_directory_internal): Use it.
5150 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5151 creating the directory. The old code temporarily assigns
5152 too-generous permissions to the directory.
5153 (do_auto_save_eh): Clear it.
5154 (Fdo_auto_save): Catch all errors, not just file errors, so
5155 that the var is always cleared.
5157 2012-01-07 Eli Zaretskii <eliz@gnu.org>
5159 * search.c (scan_buffer): Pass character positions to
5160 know_region_cache, not byte positions. (Bug#6540)
5162 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
5164 * w32.c (sys_rename): Report EXDEV when rename of a directory
5165 fails because the target is on another logical disk. (Bug#10284)
5167 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5169 * xterm.c (x_embed_request_focus): New function.
5171 * xterm.h: Add prototype.
5173 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5175 2012-01-05 Glenn Morris <rgm@gnu.org>
5177 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5179 2012-01-01 Eli Zaretskii <eliz@gnu.org>
5181 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5182 Load gnutls_transport_set_lowat only if GnuTLS version is below
5184 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5185 GnuTLS versions below 2.11.1.
5187 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5189 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5190 to the doc string advising against its use for altering the way
5191 windows are scrolled.
5193 2011-12-28 Kenichi Handa <handa@m17n.org>
5195 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5196 coding-system ASCII compatible only when it does not produce BOM
5197 on encoding (Bug#10383).
5199 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5201 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5203 (create_and_show_popup_menu): Always use menu_position_func for
5206 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5208 * callint.c (Fcall_interactively): Don't truncate prompt string.
5210 2011-12-23 Eli Zaretskii <eliz@gnu.org>
5212 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5213 property that ends at ZV, so that the bidi iteration could be
5214 resumed from there (after widening). (Bug#10360)
5216 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5218 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5220 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5222 * nsterm.m (x_free_frame_resources):
5223 Release f->output_data.ns->miniimage.
5224 (ns_index_color): Fix indentation. Do not retain
5225 color_table->colors[i].
5227 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5230 * nsfns.m (x_set_background_color): Assign return value from
5231 ns_index_color to face-background instead of NSColor*.
5232 (ns_implicitly_set_icon_type): Fix indentation.
5233 Change assignment in for loop to comparison.
5235 * emacs.c (ns_pool): New variable.
5236 (main): Assign ns_pool.
5237 (Fkill_emacs): Call ns_release_autorelease_pool.
5239 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5240 autorelease fdesc, release fdAttrs and tdict.
5241 (ns_get_covering_families): Release charset.
5242 (ns_findfonts): Release NSFontDescriptor created with new.
5243 (ns_uni_to_glyphs): Fix indentation.
5244 (setString): Release attrStr before assigning new value.
5246 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5248 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5250 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5251 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5253 2011-12-18 David Reitter <reitter@cmu.edu>
5255 * nsterm.m (ns_term_init): Subscribe for notifications
5256 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5257 to method trackingNotification in EmacsMenu.
5259 * nsmenu.m (trackingMenu): New variable.
5260 (trackingNotification): New method (from Aquamacs).
5261 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
5262 from Aquamacs (Bug#7030).
5264 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5266 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5267 (symbol_to_nsstring): Fix indentation.
5268 (ns_symbol_to_pb): New function.
5269 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5270 (Fns_rotate_cut_buffers_internal): Remove.
5271 (Fns_store_selection_internal): Rename from
5272 Fns_store_cut_buffer_internal.
5273 (ns_get_foreign_selection, Fx_own_selection_internal)
5274 (Fx_disown_selection_internal, Fx_selection_exists_p)
5275 (Fns_get_selection_internal, Fns_store_selection_internal):
5276 Use ns_symbol_to_pb and check if return value is nil.
5277 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5278 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
5279 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5280 renamed to Sns_store_selection_internal.
5281 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5282 and remove this function.
5283 (ns_handle_selection_clear): Remove, never used.
5284 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5287 2011-12-17 Ken Brown <kbrown@cornell.edu>
5289 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5290 GID is unknown (Bug#10257).
5292 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5294 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5295 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5296 which caused a build failure on GNU/Linux IA-64. This problem was
5297 introduced by my 2011-10-07 patch.
5299 2011-12-15 Juri Linkov <juri@jurta.org>
5301 * image.c (imagemagick_error): New function. (Bug#10112)
5302 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5303 Use `imagemagick_error' where ImageMagick functions return
5305 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5308 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5310 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5311 fill background (Bug#8992).
5313 2011-12-13 Martin Rudalics <rudalics@gmx.at>
5315 * window.c (Vwindow_combination_resize)
5316 (Vwindow_combination_limit): Use t instead of non-nil in
5318 (Vrecenter_redisplay): Add first sentence of doc-string on
5320 (Frecenter): Fix doc-string typo.
5322 2011-12-11 Kenichi Handa <handa@m17n.org>
5324 * coding.c (Funencodable_char_position): Pay attention to the
5325 buffer text relocation (Bug#9389).
5327 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5329 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5330 gtk_init (Bug#10100).
5332 2011-12-10 Eli Zaretskii <eliz@gnu.org>
5334 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5335 IT->string is nil. (Bug#10263)
5337 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5339 * nsterm.h (x_free_frame_resources): Declare.
5341 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5342 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5344 * nsterm.h (ns_get_defaults_value): Declare.
5346 * nsterm.m (ns_default): Call ns_get_defaults_value.
5348 2011-12-09 Eli Zaretskii <eliz@gnu.org>
5350 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5353 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5355 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5356 that where the value of an _OBJC_* symbol points to is in the .bss
5357 section (Bug#10240).
5359 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5361 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
5362 after the loop to call ccl_driver at least once (Bug#8619).
5364 2011-12-08 Kenichi Handa <handa@m17n.org>
5366 * ftfont.c (get_adstyle_property): Fix previous change
5369 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
5371 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5372 dirs from the default value of EMACSLOADPATH (bug#10208).
5374 2011-12-07 Glenn Morris <rgm@gnu.org>
5376 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5377 installation and source directories as well. (Bug#10208)
5379 2011-12-06 Chong Yidong <cyd@gnu.org>
5381 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5383 2011-12-06 Glenn Morris <rgm@gnu.org>
5385 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5386 as an error, not just -1. (Bug#10217)
5388 2011-12-05 Chong Yidong <cyd@gnu.org>
5390 * keyboard.c (process_special_events): New function.
5391 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5393 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5395 * coding.c (encode_designation_at_bol): Don't use uninitialized
5396 local variable (Bug#9318).
5398 2011-12-05 Kenichi Handa <handa@m17n.org>
5400 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5401 return Qnil (Bug#8046, Bug#10193).
5403 2011-12-05 Kenichi Handa <handa@m17n.org>
5405 * coding.c (encode_designation_at_bol): New args charbuf_end and
5406 dst. Return the number of produced bytes. Callers changed.
5407 (coding_set_source): Return how many bytes coding->source was
5409 (coding_set_destination): Return how many bytes
5410 coding->destination was relocated.
5411 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
5412 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5414 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5416 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5417 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5420 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5422 The following changes are to fix Bug#9318.
5424 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5425 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5426 (encode_coding_iso_2022, encode_coding_sjis)
5427 (encode_coding_big5, encode_coding_charset): Use the above macros.
5429 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
5431 * lisp.h (process_quit_flag): Fix external declaration.
5433 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5435 Don't macro-inline non-performance-critical code.
5436 * eval.c (process_quit_flag): New function.
5437 * lisp.h (QUIT): Use it.
5439 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5441 * nsfns.m (get_geometry_from_preferences): New function.
5442 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5444 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5446 * emacs.c (Qkill_emacs): Define.
5447 (syms_of_emacs): Initialize it.
5448 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5449 Qquit_flag to `kill-emacs' instead.
5450 (quit_throw_to_read_char): Add parameter `from_signal'.
5451 All callers changed. Call Fkill_emacs if requested and safe.
5452 * lisp.h (QUIT): Call Fkill_emacs if requested.
5454 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5456 * widget.c (update_wm_hints): Return if wmshell is null.
5457 (widget_update_wm_size_hints): New function.
5459 * widget.h (widget_update_wm_size_hints): Declare.
5461 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5462 widget_update_wm_size_hints (Bug#10104).
5464 2011-12-03 Eli Zaretskii <eliz@gnu.org>
5466 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5467 before a newline, prepare the bidi iterator for consuming the
5468 newline, and keep the current paragraph direction. (Bug#10183)
5469 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
5471 2011-12-02 Juri Linkov <juri@jurta.org>
5473 * search.c (Fword_search_regexp): New Lisp function created from
5474 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5475 (Fword_search_backward, Fword_search_forward)
5476 (Fword_search_backward_lax, Fword_search_forward_lax):
5477 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5478 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5480 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5482 * fileio.c (Finsert_file_contents): Move after-change-function call
5483 to before the "handled:" label, since all "goto handled" appear in
5484 cases where the *-change-functions have already been properly called
5487 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5489 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5490 waiting for input. (Bug#10169)
5492 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5494 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5495 verifies glyph row's hash code--we have just reallocated the
5496 glyphs, so their contents can be complete garbage. (Bug#10164)
5498 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
5500 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5502 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5504 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5505 attributes are tested _before_ calling verify_row_hash, to protect
5506 against GCC re-ordering of the tests. (Bug#10164)
5508 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5510 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5512 * xterm.c (handle_one_xevent): Only set async_visible and friends
5513 if net_wm_state_hidden_seen is non-zero (Bug#10002)
5514 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
5515 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5517 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5519 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5520 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5521 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5522 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5523 All uses changed to use GCPRO1 etc.
5524 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5525 Revert to old implementation (i.e., before 2011-03-11).
5527 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5529 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5530 of scroll runs so as to avoid assigning disabled bogus rows and
5531 unnecessary graphics copy operations.
5533 2011-11-27 Eli Zaretskii <eliz@gnu.org>
5535 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5536 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5537 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5538 (malloc, free, realloc, calloc): Redirect to e_* only when
5541 * lisp.h (GCTYPEBITS): Move before first use.
5542 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5543 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5544 this macro definition.
5546 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5549 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5551 * gtkutil.c (xg_create_frame_widgets):
5552 Call gtk_window_set_has_resize_grip (FALSE) if that function is
5553 present with Gtk+ 2.0.
5555 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5557 * fileio.c (Finsert_file_contents): Undo previous change; see
5558 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5560 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5562 Rename locals to avoid shadowing.
5563 * fileio.c (Finsert_file_contents):
5564 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5565 * process.c (wait_reading_process_output):
5566 Rename inner 'proc' to 'p' to avoid shadowing.
5567 Indent for consistency with usual Emacs style.
5569 2011-11-25 Eli Zaretskii <eliz@gnu.org>
5571 * xdisp.c (redisplay_window): If cursor row is not fully visible
5572 after recentering, and scroll-conservatively is set to a large
5573 number, scroll window by a few more lines to make the cursor fully
5574 visible and out of scroll-margin. (Bug#10105)
5575 (start_display): Don't move to the next line if the display should
5576 start at a newline that is part of a display vector or an overlay
5579 2011-11-24 Juri Linkov <juri@jurta.org>
5581 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5582 after the `MagickPingImage' call. (Bug#10112)
5584 2011-11-23 Chong Yidong <cyd@gnu.org>
5586 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5588 2011-11-23 Martin Rudalics <rudalics@gmx.at>
5590 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5591 making another buffer current. (Bug#10114)
5593 2011-11-23 Glenn Morris <rgm@gnu.org>
5595 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5597 2011-11-23 Chong Yidong <cyd@gnu.org>
5599 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5600 using it (Bug#5984).
5602 2011-11-22 Eli Zaretskii <eliz@gnu.org>
5604 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5605 and header-lines, as they don't have one computed for them.
5608 * .gdbinit (prow): Make displayed values more self-explaining.
5609 Add row's hash code.
5611 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5613 * process.c (wait_reading_process_output): Fix asynchrounous
5614 GnuTLS socket handling on some versions of the GnuTLS library.
5615 (wait_reading_process_output): Add comment and URL.
5617 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5619 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5621 2011-11-21 Chong Yidong <cyd@gnu.org>
5623 * window.c (Fnext_window, Fprevious_window): Doc fix.
5625 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5627 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5629 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
5631 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5633 2011-11-20 Martin Rudalics <rudalics@gmx.at>
5635 * window.c (Fset_window_combination_limit): Rename argument
5637 (Vwindow_combination_limit): Remove "status" from doc-string.
5639 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5641 * m/ibms390.h: Remove.
5642 * m/ibms390x.h: Don't include "ibms390.h".
5644 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5646 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5647 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5649 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
5651 * casetab.c (Fset_case_table):
5652 * charset.c (Fcharset_after): Fix typos.
5654 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
5656 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5657 Otherwise, valgrind does not work on some platforms.
5658 Problem reported by Andreas Schwab in
5659 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5660 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5661 is set, removing the need for VIRT_ADDRESS_VARIES.
5662 (PURE_P): Use a more-efficient implementation that needs just one
5663 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5664 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5665 to 4 (xorl, subq, cmpq, setbe).
5666 * alloc.c (pure): Always extern now, since that's the
5667 VIRT_ADDR_VARIES behavior.
5668 (PURE_POINTER_P): Use a single comparison, not two, for
5669 consistency with the new puresize.h.
5670 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5671 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5672 Remove VIRT_ADDR_VARIES no longer needed.
5674 2011-11-19 Eli Zaretskii <eliz@gnu.org>
5676 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5677 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5678 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5679 behave as if the cursor position were at the window margin.
5681 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5682 and the cursor position is out of bounds, behave as if the cursor
5683 position were at the window margin. (Bug#10075)
5685 2011-11-18 Chong Yidong <cyd@gnu.org>
5687 * window.c (Fwindow_combination_limit): Make first argument
5688 non-optional, since it is meaningless for live windows like the
5691 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5693 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5695 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5697 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5698 (graft_intervals_into_buffer): Simplify.
5700 2011-11-18 Eli Zaretskii <eliz@gnu.org>
5702 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5703 hash values of the two rows.
5704 (copy_row_except_pointers): Preserve the used[] arrays and the
5705 hash values of the two rows. (Bug#10035)
5706 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
5708 * xdisp.c (row_hash): New function, body extracted from
5709 compute_line_metrics.
5710 (compute_line_metrics): Call row_hash, instead of computing the
5713 * dispnew.c (verify_row_hash): Call row_hash for computing the
5714 hash code of a row, instead of duplicating code from xdisp.c.
5716 * dispextern.h (row_hash): Add prototype.
5718 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5720 * frame.c (delete_frame): Don't delete the terminal when the last
5721 X frame is closed if emacs is built with GTK toolkit.
5723 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
5725 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5727 2011-11-17 Martin Rudalics <rudalics@gmx.at>
5729 * window.c (Vwindow_splits): Rename to
5730 Vwindow_combination_resize. Suggested by Juri Linkov.
5731 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5734 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
5736 * nsfns.m (Fns_font_name):
5737 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
5739 2011-11-16 Martin Rudalics <rudalics@gmx.at>
5741 * window.h (window): Rename slot "nest" to "combination_limit".
5742 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5743 (Fset_window_nest): Rename to Fset_window_combination_limit.
5744 (Vwindow_nest): Rename to Vwindow_combination_limit.
5745 (recombine_windows, make_parent_window, make_window)
5746 (Fsplit_window_internal, saved_window)
5747 (Fset_window_configuration, save_window_save): Rename all
5748 occurrences of window_nest to window_combination_limit.
5750 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
5752 * image.c (imagemagick_load_image): Fix typo.
5754 2011-11-14 Eli Zaretskii <eliz@gnu.org>
5756 * xdisp.c (display_line): Move the call to
5757 highlight_trailing_whitespace before the call to
5758 compute_line_metrics, since the latter needs to see the final
5759 faces of all the glyphs to compute ROW's hash value.
5760 Fixes assertion violations in row_equal_p. (Bug#10035)
5762 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
5764 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5765 just return (bug#10044).
5767 2011-11-12 Eli Zaretskii <eliz@gnu.org>
5769 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5770 with user-defined heap size. Bump the default size of the temacs
5771 heap to 27MB, to avoid memory warning when running temacs.
5772 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5774 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5775 current_matrix and desired_matrix. (Bug#9990)
5776 (verify_row_hash) [XASSERTS]: New function.
5777 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5778 that the hash value of glyph rows is correct.
5780 2011-11-12 Martin Rudalics <rudalics@gmx.at>
5782 * window.h (window): Remove splits slot.
5783 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5784 (Fdelete_other_windows_internal, make_parent_window)
5785 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5786 (Fset_window_configuration, save_window_save): Don't deal with
5787 split status of windows.
5788 (saved_window): Remove splits slot.
5789 (Vwindow_splits): Rewrite doc-string.
5791 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5793 * xfns.c (unwind_create_frame):
5794 * nsfns.m (unwind_create_frame):
5795 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5796 Vframe_list (Bug#9999).
5798 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5800 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
5802 2011-11-11 Kenichi Handa <handa@m17n.org>
5804 * callproc.c (Fcall_process): Set the member dst_multibyte of
5807 2011-11-11 Johan Bockgård <bojohan@gnu.org>
5809 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5810 avoid a crash (bug#9496).
5812 2011-11-09 Chong Yidong <cyd@gnu.org>
5814 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5815 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5817 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5819 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5821 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5823 Avoid some portability problems by eschewing 'extern inline' functions.
5824 The trivial performance wins aren't worth the portability hassles; see
5825 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5827 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5828 (window_box_width, window_box_left, window_box_left_offset)
5829 (window_box_right, window_box_right_offset): Undo previous change,
5830 by removing the "extern"s.
5831 * intervals.c (adjust_intervals_for_insertion)
5832 (adjust_intervals_for_deletion): Undo previous change,
5833 making these static again.
5834 (offset_intervals, temp_set_point_both, temp_set_point)
5835 (copy_intervals_to_string): No longer inline.
5836 * xdisp.c (window_text_bottom_y, window_box_width)
5837 (window_box_height, window_box_left_offset)
5838 (window_box_right_offset, window_box_left, window_box_right)
5839 (window_box): No longer inline.
5841 2011-11-08 Chong Yidong <cyd@gnu.org>
5843 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
5844 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5845 Signal an error if not a live window.
5846 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5847 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5849 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
5851 * lisp.h (syms_of_abbrev): Remove declaration.
5852 Reported by CHENG Gao <chenggao@royau.me>.
5854 2011-11-07 Eli Zaretskii <eliz@gnu.org>
5856 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5857 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5858 of temacs in GUI mode.
5860 2011-11-07 Martin Rudalics <rudalics@gmx.at>
5862 * window.h: Declare delete_all_child_windows instead of
5863 delete_all_subwindows.
5864 * window.c (Fwindow_nest, Fset_window_nest)
5865 (Fset_window_new_total, Fset_window_new_normal)
5866 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5867 (delete_all_subwindows): Rename to delete_all_child_windows.
5868 (Fdelete_other_windows_internal, Fset_window_configuration):
5869 Call delete_all_child_windows instead of delete_all_subwindows.
5870 * frame.c (delete_frame): Call delete_all_child_windows instead
5871 of delete_all_subwindows.
5873 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5875 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5876 This is also needed for porting to any host where GC_MARK_STACK is
5877 not GC_MAKE_GCPROS_NOOPS.
5878 (which_symbols): Use it.
5880 2011-11-07 Kenichi Handa <handa@m17n.org>
5882 * coding.c (coding_set_destination): Check coding->src_pos only
5883 when coding->src_object is a buffer (bug#9910).
5885 * process.c (send_process): Set the member src_multibyte of coding
5886 to 0 (bug#9911) when sending a unibyte text.
5888 * callproc.c (Fcall_process): Set the member src_multibyte of
5889 process_coding to 0 (bug#9912).
5891 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5893 * xmenu.c (cleanup_widget_value_tree): New function.
5894 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5895 calling free_menubar_widget_value_tree directly (Bug#9830).
5897 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5899 Fix some portability problems with 'inline'.
5900 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5901 (window_box_width, window_box_left, window_box_left_offset)
5902 (window_box_right, window_box_right_offset): Declare extern.
5903 Otherwise, these inline functions do not conform to C99 and
5904 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5905 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5906 * intervals.c (adjust_intervals_for_insertion)
5907 (adjust_intervals_for_deletion): Now extern, because otherwise the
5908 extern inline functions 'offset_intervals' couldn't refer to it.
5909 (static_offset_intervals): Remove.
5910 (offset_intervals): Rewrite using the old contents of
5911 static_offset_intervals. The old version didn't conform to C99
5912 because an extern inline function contained a reference to an
5913 identifier with static linkage.
5915 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5917 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5920 2011-11-06 Eli Zaretskii <eliz@gnu.org>
5922 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5923 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5924 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5925 return Qleft_to_right.
5927 2011-11-06 Chong Yidong <cyd@gnu.org>
5929 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5930 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5931 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5932 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5933 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5934 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5935 (Fwindow_vscroll): Doc fix.
5936 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5937 argument, since it makes no sense to pass a live window and for
5938 consistency with window-child.
5940 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5942 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5945 2011-11-05 Jason Rumney <jasonr@gnu.org>
5947 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5948 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5950 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5951 bitwise arithmetic preventing use of unicode-sip and non-truetype
5954 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5956 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5959 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5960 initialization code to keep similarity to xfns.c after changes
5963 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5965 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5966 (unwind_create_frame): New function (Bug#9943).
5967 (Fx_create_frame): Restructure code to be more similar to the one in
5968 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5969 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5970 Move terminal->reference_count++ just before making the frame official
5973 * nsterm.m (x_free_frame_resources): New function.
5974 (x_destroy_window): Move code to x_free_frame_resources.
5976 * xfns.c (unwind_create_frame): Fix comment.
5977 (Fx_create_frame, x_create_tip_frame):
5978 Move terminal->reference_count++ just before making the frame
5979 official. Move initialization of image_cache_refcount and
5980 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5982 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5984 Support MSVC build with newer versions of Visual Studio.
5985 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5986 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5989 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5990 which are not supported by MSVC.
5991 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5992 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5994 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5996 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5998 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6000 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
6002 Support MSVC build with newer versions of Visual Studio.
6003 * w32.c: Don't include w32api.h for MSVC.
6004 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6006 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6007 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6008 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6009 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6011 (alloca) [_MSC_VER]: Define to _alloca.
6013 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6015 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6017 2011-11-04 Eli Zaretskii <eliz@gnu.org>
6019 * xdisp.c (note_mouse_highlight): If either of
6020 previous/next-single-property-change returns nil, treat that as
6021 the beginning or the end of the buffer. (Bug#9955)
6023 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6025 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
6026 label is not null (Bug#9951).
6027 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6030 2011-11-04 Eli Zaretskii <eliz@gnu.org>
6032 * window.c (Fwindow_body_size): Mention in the doc string that the
6033 return value is in frame's canonical units. (Bug#9949)
6035 2011-11-03 Eli Zaretskii <eliz@gnu.org>
6037 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6039 * w32fns.c (unwind_create_frame): If needed, free the glyph
6040 matrices of the partially constructed frame. (Bug#9943)
6041 * xfns.c (unwind_create_frame): Likewise.
6043 2011-11-01 Eli Zaretskii <eliz@gnu.org>
6045 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6046 Don't stop backward scan on the continuation glyph, even though
6047 its CHARPOS is positive.
6048 (mouse_face_from_buffer_pos, note_mouse_highlight):
6049 Rename cover_string to disp_string.
6051 2011-11-01 Martin Rudalics <rudalics@gmx.at>
6053 * window.c (temp_output_buffer_show): Don't use
6054 Vtemp_buffer_show_specifiers.
6055 (Vtemp_buffer_show_specifiers): Remove unused variable.
6057 2011-10-30 Eli Zaretskii <eliz@gnu.org>
6059 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6060 past the beginning of the current glyph matrix.
6062 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6064 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6065 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6066 HAVE_GTK3 (Bug#9869).
6068 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6069 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6071 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6073 * xterm.c: Declare x_handle_net_wm_state to return int.
6074 (handle_one_xevent): Check if we are iconified but don't have
6075 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6076 (get_current_wm_state): Return non-zero if not hidden,
6077 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6078 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6079 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6080 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6082 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6084 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6085 so that this new function doesn't get optimized away by a
6086 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6088 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6090 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6092 2011-10-29 Eli Zaretskii <eliz@gnu.org>
6094 Fix the `xbytecode' command.
6095 * .gdbinit (xprintbytestr): New command.
6096 (xwhichsymbols): Rename from `which'; all callers changed.
6097 (xbytecode): Print the byte-code string as well.
6099 2011-10-29 Kim Storm <storm@cua.dk>
6101 * alloc.c (which_symbols): New function.
6103 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6105 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6108 2011-10-29 Glenn Morris <rgm@gnu.org>
6110 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6111 Not clear what it was for, and it causes various bugs. (Bug#9839)
6113 2011-10-28 Eli Zaretskii <eliz@gnu.org>
6115 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6116 possible random value that matches one of those tested as
6117 condition to clear the mouse face.
6119 2011-10-28 Chong Yidong <cyd@gnu.org>
6121 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6123 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6125 * window.c (make_window): Initialize phys_cursor_on_p.
6127 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6129 * lisp.h (struct Lisp_Symbol): Update comments.
6131 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
6133 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6135 2011-10-28 Eli Zaretskii <eliz@gnu.org>
6137 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6138 <oslsachem@gmail.com> for helping to debug this.
6140 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6141 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6142 (g_b_init_get_glyph_outline_w): New static variables.
6143 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6144 (GetGlyphOutlineW_Proc): New typedefs.
6145 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
6146 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6148 (w32font_open_internal, compute_metrics):
6149 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
6150 instead of calling the "wide" APIs directly.
6152 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6154 * w32.h (syms_of_w32font): Add prototype.
6156 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
6158 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6159 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6160 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6161 (Fmove_to_window_line): Doc fix.
6163 2011-10-27 Chong Yidong <cyd@gnu.org>
6165 * process.c (make_process): Set gnutls_state to NULL.
6167 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6168 non-NULL, regardless of GNUTLS_INITSTAGE.
6169 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6170 an error. Set process slots as soon as we allocate them.
6172 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6174 2011-10-27 Chong Yidong <cyd@gnu.org>
6176 * gnutls.c (emacs_gnutls_deinit): New function.
6177 Deallocate credentials structures as well as calling gnutls_deinit.
6178 (Fgnutls_deinit, Fgnutls_boot): Use it.
6180 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6181 (deactivate_process): Call emacs_gnutls_deinit.
6183 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
6185 * image.c (x_create_x_image_and_pixmap):
6186 * w32.c (sys_rename, w32_delayed_load):
6187 * w32font.c (fill_in_logfont):
6188 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6190 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
6192 * w32fns.c (w32_default_color_map): New function,
6193 extracted from Fw32_default_color_map.
6194 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
6196 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6198 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6200 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6202 * keyboard.c (test_undefined): New function (bug#9751).
6203 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6205 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6207 * sysdep.c (init_sys_modes): Fix the check for the controlling
6208 terminal (Bug#6649).
6210 2011-10-20 Eli Zaretskii <eliz@gnu.org>
6212 * dispextern.h (struct bidi_it): New member next_en_type.
6214 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6215 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6216 current character, check also for next_en_type being WEAK_EN.
6217 (bidi_resolve_weak): Don't enter the expensive loop if the current
6218 position is before next_en_pos. Record the bidi type of the first
6219 non-ET, non-BN character we find, in addition to its position.
6220 (bidi_level_of_next_char): Invalidate next_en_type when
6221 next_en_pos is over-stepped.
6223 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6225 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6226 * editfns.c: Rewrite current-time-zone so that it invokes
6227 the equivalent of (format-time-string "%Z") to get the time zone name.
6228 This fixes a bug when the time zone name contains characters that
6229 need converting from the system time locale to Emacs internal format.
6230 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6231 that patch fixed format-time-string to do the conversion, but
6232 I forgot to fix current-time-zone.
6233 (format_time_string): New function, containing most of
6234 what Fformat_time_string used to contain.
6235 (Fformat_time_string): Rewrite in terms of format_time_string.
6236 This doesn't change this function's behavior.
6237 (current-time-zone): Rewrite to use format_time_string.
6238 This fixes the bug reported by Michael Schierl in
6239 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6240 Jason Rumney's 2007-06-07 change worked around this bug, but
6242 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6244 2011-10-19 Eli Zaretskii <eliz@gnu.org>
6246 * xdisp.c (start_display): If the character at POS is displayed
6247 via a display vector, reset IT->current.dpvec_index to zero.
6248 (try_window_reusing_current_matrix): If a line ends in a display
6249 vector or the next line starts in a display vector, continue
6250 redrawing the window even though the character position of
6251 start_row was reached.
6254 2011-10-18 Chong Yidong <cyd@gnu.org>
6256 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6257 with nobreak-char-display too.
6259 2011-10-18 Eli Zaretskii <eliz@gnu.org>
6261 Fix part 3 of bug#9771.
6262 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6263 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6264 non-neutral characters if the current character is a paragraph
6265 separator (a.k.a. Newline). This avoids running the same
6266 expensive loop twice, once when we consume the preceding newline
6267 and the other time when the line actually needs to be displayed.
6268 Avoid the loop when we see neutrals on the base embedding level
6269 following a character whose directionality is the same as the
6270 paragraph's. This avoids running the expensive loop when a line
6271 ends in a long sequence of neutrals, like control characters.
6272 Add assertion against STRONG_AL type. Slightly rearrange code
6273 that determines the type of a neutral given the first non-neutral
6275 (bidi_level_of_next_char): Set next_en_pos to zero when
6276 invalidating its info.
6278 2011-10-17 Eli Zaretskii <eliz@gnu.org>
6280 * xdisp.c (push_display_prop): Determine whether to record string
6281 or buffer position by IT->string, not by IT->method. Allow
6282 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
6283 (move_it_vertically_backward): Don't look for character position
6284 immediately after the newline when in a continuation line.
6287 2011-10-15 Martin Rudalics <rudalics@gmx.at>
6289 * window.c (coordinates_in_window): Rewrite and delabelize
6290 vertical border check. (Bug#5357) (Bug#9618)
6292 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6294 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6295 errors in XSetWindowBorder (bug#9310).
6297 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6299 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6300 avoid crash when xmalloc overrun checking is enabled.
6302 2011-10-13 Eli Zaretskii <eliz@gnu.org>
6304 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6305 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6306 cursor motion with <left> and <right> arrow keys.
6308 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6309 some callers set that themselves.
6311 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6313 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6314 display string and the previous row comes from the same string and
6315 is empty. (Bug#9739) (Bug#9738)
6317 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6319 * doc.c (get_doc_string): Encode file name (bug#9735).
6321 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6323 * bidi.c (bidi_level_of_next_char):
6324 * xdisp.c (get_visually_first_element): Remove old incorrect
6325 comments regarding the Unicode Line Separator character.
6327 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6329 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6331 * alloc.c (Fgc_status): Do not access beyond zombies array
6332 boundary if nzombies > MAX_ZOMBIES.
6333 * alloc.c (dump_zombies): Add missing format specifier.
6335 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6337 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6338 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6340 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6341 Some packages use them to denote characters with modifiers.
6343 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6345 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6346 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6347 matching a pp-number. Rename parameter var to var1.
6349 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6351 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6353 2011-10-08 Glenn Morris <rgm@gnu.org>
6355 * callint.c (Fcall_interactively): Give a more explicit error for the
6356 'c' case with a non-character input. (Bug#8479)
6358 2011-10-08 Eli Zaretskii <eliz@gnu.org>
6360 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6362 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6363 lines that are hscrolled on the left.
6365 * dispnew.c (buffer_posn_from_coords): Account for a possible
6366 presence of header-line. (Bug#4426)
6368 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6370 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6371 Don't advertise functionality which we discourage or doesn't work.
6373 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6375 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6376 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6377 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6378 this makes Emacs dump core during garbage collection on rare
6379 occasions. sizeof is obviously inferior to offsetof here, so
6380 stick with offsetof.
6381 (GC_POINTER_ALIGNMENT): New macro.
6382 (mark_memory): Omit 3rd (offset) arg; caller changed.
6383 Don't assume EMACS_INT alignment is the same as pointer alignment.
6385 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6387 * keyboard.c (read_key_sequence_remapped): New var.
6388 (read_key_sequence): Compute remapping in the right buffer.
6389 (command_loop_1): Use read_key_sequence's remapping directly.
6391 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6393 * dired.c (file_name_completion): Don't expand file name.
6394 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6395 before checking file name handler.
6397 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6398 they've been requested explicitly (bug#9591).
6400 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
6402 * keymap.c (Fsingle_key_description): Use make_specified_string
6403 instead of build_string to build string from push_key_description.
6406 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6408 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6409 This fixes a Y2038 bug on 64-bit hosts.
6410 * buffer.c (reset_buffer):
6411 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6412 (Fclear_buffer_auto_save_failure):
6413 Use 0, not -1, to represent an unset failure time, since time_t
6414 might not be signed.
6416 Remove dependency on glibc malloc internals.
6417 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6418 Move back here from lisp.h, but with their new implementations.
6419 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6420 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6421 * charset.c (charset_table_init): New static var.
6422 (syms_of_charset): Use it instead of xmalloc. This removes a
6423 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6424 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6425 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6426 Move back to alloc.c.
6427 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6428 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6430 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6432 * nsterm.m (windowDidResize): Call x_set_window_size only when
6433 ns_in_resize is true. Otherwise set pixelwidth/height and
6434 call change_frame_size (Bug#9628).
6436 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6438 Port --enable-checking=all to Fedora 14 x86-64.
6439 * charset.c (syms_of_charset): Also account for glibc malloc's
6440 internal overhead when calculating the initial malloc maximum.
6442 Port --enable-checking=all to Fedora 14 x86.
6443 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6445 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6446 (overrun_check_realloc, overrun_check_free):
6447 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6448 That way, xmalloc returns a properly-aligned pointer even if
6449 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6450 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6451 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6452 into account when calculating the initial malloc maximum.
6453 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6454 Move here from alloc.c, so that charset.c can use it too.
6455 Properly align; the old code wasn't right for common 32-bit hosts
6456 when configured with --enable-checking=all.
6457 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6458 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6460 2011-09-29 Eli Zaretskii <eliz@gnu.org>
6462 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
6465 2011-09-28 Eli Zaretskii <eliz@gnu.org>
6467 * xdisp.c (compute_display_string_end): If there's no display
6468 string at CHARPOS, return -1.
6470 * bidi.c (bidi_fetch_char): When compute_display_string_end
6471 returns a negative value, treat the character as a normal
6472 character not covered by a display string. (Bug#9624)
6474 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
6476 * lread.c (Fread_from_string): Fix typo in docstring.
6478 2011-09-27 Eli Zaretskii <eliz@gnu.org>
6480 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6481 newline, reseat the iterator instead of bidi-iterating there one
6482 character at a time. (Bug#9610)
6483 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6484 TO_CHARPOS if the bidi iterator is at base embedding level.
6486 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6488 * lread.c (readevalloop): Use correct code for NBSP.
6489 (read1): Likewise. (Bug#9608)
6491 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
6493 * dbusbind.c (Fdbus_register_signal): When service is not
6494 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6496 2011-09-25 Glenn Morris <rgm@gnu.org>
6498 * buffer.c (truncate-lines): Doc fix.
6500 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
6502 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6503 (Fset_window_next_buffers): Doc fix.
6505 2011-09-24 Glenn Morris <rgm@gnu.org>
6507 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6509 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6511 Fix minor problems found by static checking.
6512 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
6513 * indent.c (Fvertical_motion): Fix == vs = typo.
6515 2011-09-24 Eli Zaretskii <eliz@gnu.org>
6517 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6518 Default value is now t. Doc fix.
6520 * indent.c (Fvertical_motion): Compute and apply the overshoot
6521 logic when moving up, not only when moving down. Fix the
6522 confusing name and values of the it_overshoot_expected variable;
6523 logic changes accordingly. (Bug#9254) (Bug#9549)
6525 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6526 CHARPOS is covered by a display string which includes newlines.
6527 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6528 is covered by a display string with embedded newlines.
6530 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
6532 * dbusbind.c (Fdbus_register_signal): Add match rule to
6533 Vdbus_registered_objects_table. (Bug#9581)
6534 (Fdbus_register_method, Vdbus_registered_objects_table):
6537 2011-09-24 Jim Meyering <meyering@redhat.com>
6539 do not ignore write error for any output size
6540 The previous change was incomplete.
6541 While it makes emacs --batch detect the vast majority of stdout
6542 write failures, errors were still ignored whenever the output size is
6543 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6544 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6545 && echo FAIL: ignored write error
6546 FAIL: ignored write error
6547 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6548 && echo FAIL: ignored write error
6549 FAIL: ignored write error
6550 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6552 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6554 * emacs.c (Fkill_emacs): In noninteractive mode exit
6555 non-successfully if a write error occurred on stdout. (Bug#9574)
6557 2011-09-21 Eli Zaretskii <eliz@gnu.org>
6559 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6562 * dispextern.h (struct it): Update the comment documenting what
6565 2011-09-20 Eli Zaretskii <eliz@gnu.org>
6567 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6568 a display string, extend search for cursor position to end of row.
6569 (find_row_edges): If the row ends in a newline from a display
6570 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6571 Handle the case of a display string with multiple newlines.
6572 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6573 non-empty line. Fixes confusing cursor motion with arrow keys at
6574 the beginning of a line that starts with whitespace.
6576 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6578 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6581 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
6583 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6586 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6588 * xdisp.c (display_line): Record maximum and minimum buffer
6589 positions even if no glyphs were produced (e.g., by a zero-width
6590 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6591 buffer positions that will be removed from the glyph row because
6593 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6594 column is beyond frame width: don't subtract 1 "pixel" when
6595 computing width of the stretch.
6596 (reseat_at_next_visible_line_start): Undo the change made on
6597 2011-09-17 that saved paragraph information and restored it after
6598 the call to `reseat'. (Bug#9545)
6600 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6602 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6603 and turn window cursor on if cleared (Bug#9415).
6605 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
6607 * search.c (boyer_moore): Take unibyte characters from pattern
6608 literally. (Bug#9458)
6610 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6612 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6614 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6616 Fix minor problem found by static checking.
6617 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6618 initialized, to pacify gcc -Wuninitialized.
6620 * fileio.c: Report proper errno when syscall falls.
6621 (Finsert_file_contents): Save and restore errno,
6622 so that report_file_error outputs the correct diagnostic.
6623 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6625 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6627 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6629 2011-09-17 Eli Zaretskii <eliz@gnu.org>
6631 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6632 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6634 2011-09-17 Eli Zaretskii <eliz@gnu.org>
6636 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6637 about the current paragraph and restore it after the call to reseat.
6639 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6640 (bidi_find_paragraph_start): Search back for paragraph beginning
6641 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6642 (bidi_move_to_visually_next): Only trigger paragraph-related
6643 computations when the last character is a newline or at EOB, not
6644 just any NEUTRAL_B. (Bug#9470)
6646 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6647 truncated lines if point is covered by a display string. (Bug#9524)
6649 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6651 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6652 (cons_to_x_long): New function.
6653 (lisp_data_to_selection_data): Use it. Correct the test for
6654 short-versus-long data; it was negated. Break out of vector
6655 loop, for efficiency, when a long datum is discovered.
6657 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6659 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6661 2011-09-16 Eli Zaretskii <eliz@gnu.org>
6663 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6664 GCC PR/17406) by declaring this function with external scope.
6666 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6668 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6669 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6671 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6673 * editfns.c (Fformat): Correctly handle text properties on "%%".
6675 2011-09-15 Eli Zaretskii <eliz@gnu.org>
6677 * xterm.c (x_draw_composite_glyph_string_foreground):
6678 * w32term.c (x_draw_composite_glyph_string_foreground):
6679 * term.c (encode_terminal_code):
6680 * composite.c (composition_update_it, get_composition_id):
6681 * xdisp.c (get_next_display_element)
6682 (fill_composite_glyph_string): Add comments about special meaning
6683 of TAB characters in a composition.
6685 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6687 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
6688 This occurs when processing a multibyte format.
6689 Problem reported by Wolfgang Jenker.
6691 2011-09-15 Johan Bockgård <bojohan@gnu.org>
6693 * xdisp.c (try_cursor_movement): Only check for exact match if
6694 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6696 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6698 Remove unused external symbols.
6699 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6700 * xdisp.c (calc_pixel_width_or_height): Now static.
6701 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6702 * indent.c (check_display_width):
6703 * w32term.c: Fix comment to match code.
6704 * xterm.c, xterm.h (x_catching_errors): Remove.
6706 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6708 * xselect.c: Use signed conversions more consistently (Bug#9498).
6709 (selection_data_to_lisp_data): Assume incoming selection data are
6710 signed integers, not unsigned. This is to be consistent with
6711 outgoing selection data, which was modified to use signed integers
6712 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6713 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6714 expects long, not unsigned long.
6716 2011-09-14 Eli Zaretskii <eliz@gnu.org>
6718 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6719 computation of loop end. Reported by Johan Bockgård
6722 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
6724 * frame.c (Fother_visible_frames_p): Function deleted.
6726 2011-09-12 Eli Zaretskii <eliz@gnu.org>
6728 * indent.c (compute_motion): Process display vector front to back
6729 rather than the other way around. (Bug#2496)
6731 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6733 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6735 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
6737 * minibuf.c (Fread_from_minibuffer): Doc fix.
6739 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6741 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6742 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6744 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6746 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6747 value for non-existent files.
6749 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6751 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6752 set its "size" to -1. This will set the modtime_size field of
6753 the corresponding buffer to -1, which is what
6754 verify-visited-file-modtime expects for files that do not exist.
6757 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6759 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6761 * lisp.h: ... from here. push_key_description is no longer
6762 defined in keyboard.c, so its declaration should not be in
6763 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6764 logically belongs with push_key_description.
6766 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6768 * buffer.h: Include <sys/types.h> instead of <time.h>.
6769 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6770 Problem reported by Herbert J. Skuhra.
6772 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6774 * xml.c (parse_region): Make the parsing work for
6775 non-comment-starting XML files again (bug#9144).
6777 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6779 * image.c (gif_load): Fix calculation of bottom and right corner.
6782 2011-09-10 Eli Zaretskii <eliz@gnu.org>
6784 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6785 redisplay in small windows.
6787 2011-09-09 Eli Zaretskii <eliz@gnu.org>
6789 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6791 2011-09-08 Martin Rudalics <rudalics@gmx.at>
6793 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6794 Operate on live windows only.
6796 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
6798 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6800 2011-09-07 Eli Zaretskii <eliz@gnu.org>
6802 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6803 only under bidi iteration.
6805 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6807 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6809 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6811 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6812 Without this fix, the command to link temacs failed due to an
6813 undefined symbol __builtin_isnan. This is because
6814 /usr/include/iso/math_c99.h #defines isnan(x) to
6815 __builtin_isnan(x), but the bundled gcc, which identifies itself
6816 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6818 * floatfns.c (isnan): #undef, and then #define to a clone of
6820 (Fisnan): Always define, since it's always available now.
6821 (syms_of_floatfns): Always define isnan at the Lisp level.
6823 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6825 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6827 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6829 * fileio.c: Fix bugs with large file offsets (Bug#9428).
6830 The previous code assumed that file offsets (off_t values) fit in
6831 EMACS_INT variables, which is not true on typical 32-bit hosts.
6832 The code messed up by falsely reporting buffer overflow in cases
6833 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6834 when "big" contains more than 2**29 bytes, even though this
6835 inserts just one byte and does not overflow the buffer.
6836 (Finsert_file_contents): Store file offsets as off_t
6837 values, not as EMACS_INT values. Check for overflow when
6838 converting between EMACS_INT and off_t. When checking for
6839 buffer overflow or for overlap, take the offsets into account.
6840 Don't use EMACS_INT for small values where int suffices.
6841 When checking for overlap, fix a typo: ZV was used where
6842 ZV_BYTE was intended.
6843 (Fwrite_region): Don't assume off_t fits into 'long'.
6844 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6846 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
6848 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6850 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6852 sprintf-related integer and memory overflow issues (Bug#9412).
6854 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
6855 (esprintf, exprintf, evxprintf): New functions.
6856 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6857 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
6858 (modify_event_symbol): Do not assume that the length of
6859 name_alist_or_stem is safe to alloca and fits in int.
6860 (Fexecute_extended_command): Likewise for function name and binding.
6861 (Frecursion_depth): Wrap around reliably on integer overflow.
6862 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6863 since some callers pass EMACS_INT values.
6864 (Fsingle_key_description): Don't crash if symbol name contains more
6865 than MAX_ALLOCA bytes.
6866 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6867 (get_minibuffer): Arg is now EMACS_INT, not int.
6868 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
6869 (esprintf, exprintf, evxprintf): New decls.
6870 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6872 * dbusbind.c (signature_cat): New function.
6873 (xd_signature, Fdbus_register_signal):
6874 Do not overrun buffer; instead, report string overflow.
6876 * dispnew.c (add_window_display_history): Don't overrun buffer.
6877 Truncate instead; this is OK since it's just a log.
6879 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6880 even if the time zone offset is outlandishly large.
6881 Don't mishandle offset == INT_MIN.
6883 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6884 when creating daemon; the previous buffer-overflow check was incorrect.
6886 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6887 which has the guts of the old verror function.
6889 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6890 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6892 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6893 (font_unparse_xlfd): Don't blindly alloca long strings.
6894 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
6895 fits in int, when using sprintf. Use single snprintf to count
6896 length of string rather than counting it via multiple sprintfs;
6897 that's simpler and more reliable.
6898 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6899 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6900 sprintf, in case result does not fit in int.
6902 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6903 (fontset_from_font): Print it.
6905 * frame.c (tty_frame_count): Now printmax_t, not int.
6906 (make_terminal_frame, set_term_frame_name): Print it.
6907 (x_report_frame_params): In X, window IDs are unsigned long,
6908 not signed long, so print them as unsigned.
6909 (validate_x_resource_name): Check for implausibly long names,
6910 and don't assume name length fits in 'int'.
6911 (x_get_resource_string): Don't blindly alloca invocation name;
6912 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6915 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6916 (xg_check_special_colors, xg_set_geometry):
6917 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6919 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6920 Use esprintf, not sprintf, in case result does not fit in int.
6922 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6923 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6924 it as a large positive number.
6925 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6926 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6928 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6929 in case result does not fit in int.
6931 * print.c (float_to_string): Detect width overflow more reliably.
6932 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6933 buffer overrun. Don't assume list length fits in 'int'. Treat
6934 print length of 0 as 0, not as infinity; to be consistent with other
6935 uses of print length in this function. Don't overflow print length
6936 index. Don't assume hash table size fits in 'long', or that
6937 vectorlike size fits in 'unsigned long'.
6939 * process.c (make_process): Use printmax_t, not int, to format
6940 process-name gensyms.
6942 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6944 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6945 to avoid potential buffer overrun.
6947 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6948 if X resource line is longer than 512 bytes.
6950 * xfns.c (x_window): Make sprintf buffer a bit bigger
6951 to avoid potential buffer overrun.
6953 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6955 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6957 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6959 Integer overflow fixes for scrolling, etc.
6960 Without these, Emacs silently mishandles large integers sometimes.
6961 For example, "C-u 4294967297 M-x recenter" was treated as if
6962 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6964 * xdisp.c (try_window_id): Check Emacs fixnum range before
6965 converting to 'int'.
6967 * window.c (window_scroll_line_based, Frecenter):
6968 Check that an Emacs fixnum is in range before assigning it to 'int'.
6969 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6970 values converted from Emacs fixnums.
6971 (Frecenter): Don't wrap around a line count if it is out of 'int'
6972 range; instead, treat it as an extreme value.
6973 (Fset_window_configuration, compare_window_configurations):
6974 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6976 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6977 that can exceed INT_MAX. Check that EMACS_INT value is in range
6978 before assigning it to the (possibly-narrower) index.
6979 (match_limit): Don't assume that a fixnum can fit in 'int'.
6981 * print.c (print_object): Use ptrdiff_t, not int, for index that can
6984 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
6985 (Fvertical_motion): Don't wrap around LINES values that don't fit
6986 in 'int'. Instead, treat them as extreme values. This is good
6987 enough for windows, which can't have more than INT_MAX lines anyway.
6989 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6991 * Require libxml/parser.h to avoid compilation warning.
6993 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6995 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6996 since this reportedly can destroy thread storage.
6998 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
7000 * syntax.c (find_defun_start): Update all cache variables if
7001 exiting early (Bug#9401).
7003 2011-08-30 Eli Zaretskii <eliz@gnu.org>
7005 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7007 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7008 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7009 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7011 * term.c (tty_append_glyph): New function.
7012 (produce_stretch_glyph): Static function and its prototype deleted.
7014 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7017 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7019 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7020 when checking :margin (Bug#9390).
7021 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
7022 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
7023 so that the name doesn't mislead. All uses changed.
7025 2011-08-28 Johan Bockgård <bojohan@gnu.org>
7027 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7030 2011-08-27 Eli Zaretskii <eliz@gnu.org>
7032 * xdisp.c (move_it_to): Don't bail out early when reaching
7033 position beyond to_charpos, if we are scanning backwards.
7034 (move_it_vertically_backward): When DY == 0, make sure we get to
7035 the first character in the line after the newline.
7037 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7039 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7040 (ccl_driver): Do not generate an out-of-range pointer.
7041 (Fccl_execute_on_string): Remove unnecessary check for
7042 integer overflow, noted by Stefan Monnier in
7043 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7044 Remove a FIXME that didn't need fixing.
7045 Simplify the newly-introduced buffer reallocation code.
7047 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
7049 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7051 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
7053 Integer and memory overflow issues (Bug#9196).
7055 * doc.c (get_doc_string): Rework so that
7056 get_doc_string_buffer_size is the actual buffer size, rather than
7057 being 1 less than the actual buffer size; this makes xpalloc more
7060 * image.c (x_allocate_bitmap_record, cache_image):
7061 * xselect.c (Fx_register_dnd_atom):
7062 Simplify previous changes by using xpalloc.
7064 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7065 since either will do and ptrdiff_t is convenient with xpalloc.
7067 * charset.c (charset_table_size)
7068 (struct charset_sort_data.priority): Now ptrdiff_t.
7069 (charset_compare): Don't overflow if priorities differ greatly.
7070 (Fsort_charsets): Don't assume list length fits in int.
7071 Check for size-calculation overflow when allocating sort data.
7072 (syms_of_charset): Allocate an initial charset table that is
7073 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7075 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7077 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7078 The actual value is always <= INT_MAX, and leaving it unsigned made
7079 overflow checking harder.
7081 * dispextern.h (struct glyph_matrix.rows_allocated)
7082 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7083 with xpalloc. The values are still always <= INT_MAX.
7085 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7087 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7088 (SAFE_NALLOCA): New macro.
7090 * region-cache.c (struct boundary.pos, find_cache_boundary)
7091 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7092 (set_cache_region, invalidate_region_cache)
7093 (revalidate_region_cache, know_region_cache, region_cache_forward)
7094 (region_cache_backward, pp_cache):
7095 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7096 so that ptrdiff_t * can be passed to xpalloc.
7097 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7098 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7099 (pp_cache): Don't assume cache_len fits in int.
7100 * region-cache.h: Adjust extern decls to match.
7102 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7103 EMACS_INT, since either will do, for xpalloc.
7105 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7106 (xnmalloc, xnrealloc, xpalloc): New functions.
7108 * bidi.c (bidi_shelve_header_size): New constant.
7109 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7110 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7112 * bidi.c (bidi_cache_shrink):
7113 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7115 Don't update size of array until after memory allocation succeeds,
7116 because xmalloc/xrealloc may not return.
7117 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7118 now that we have proper integer overflow checking.
7119 (record_overlay_string, overlay_strings): Catch overflows when
7120 calculating size of overlay_str_buf.
7122 * callproc.c (Fcall_process): Check for size overflow when
7123 calculating size of args2.
7124 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7125 Normally we prefer signed values, but sticking with ptrdiff_t would
7126 require adding more-complicated checks.
7128 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7129 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7130 Redo buffer-overflow calculations to avoid integer overflow.
7131 Add a FIXME comment where memory seems to be over-allocated.
7133 * character.c (Fstring): Check for size-calculation overflow.
7135 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7136 unnecessary integer overflow. Check for size overflow.
7137 (encode_coding_object): Don't update size until xmalloc succeeds.
7139 * composite.c (get_composition_id): Check for overflow in glyph
7140 length calculations.
7142 Integer and memory overflow fixes for display code.
7143 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7144 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7145 (scrolling_window): Check for overflow in size calculations.
7146 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7147 Don't assume glyph table len fits in int.
7148 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7149 (row_table_size): Now ptrdiff_t, not int.
7150 (scrolling_window): Avoid overflow in size calculations.
7151 Don't update size until allocation succeeds.
7152 * fns.c (concat): Check for overflow in size calculations.
7153 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7154 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7155 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7157 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7158 (get_doc_string): Check for size calculation overflow.
7159 Don't update size until allocation succeeds.
7160 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7161 EMACS_INT, where ptrdiff_t will do.
7162 (Fsubstitute_command_keys): Check for string overflow.
7164 * editfns.c (set_time_zone_rule): Don't assume environment length
7166 (message_length): Now ptrdiff_t, not int.
7167 (Fmessage_box): Don't update size until allocation succeeds.
7168 Don't assume message length fits in int.
7169 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7171 * emacs.c (main): Do not reallocate argv, since there is a null at
7172 the end that can be overwritten, and this way there's no need to
7173 worry about size-calculation overflow.
7174 (sort_args): Check for size-calculation overflow.
7176 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7178 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7180 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7181 (x_set_scroll_bar_width, x_figure_window_size):
7182 Check for integer overflow.
7183 (x_set_alpha): Do not assume XINT fits in int.
7185 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7186 This is for the members text_lines, text_cols, total_lines, total_cols,
7187 where the system imposes an 'int' limit.
7189 * fringe.c (Fdefine_fringe_bitmap):
7190 Don't update size until alloc works.
7192 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7193 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7195 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7196 Check for size-calculation overflow.
7197 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7198 do, as we prefer signed integers.
7199 (id_to_widget.max_size, id_to_widget.used)
7200 (xg_store_widget_in_map, xg_remove_widget_from_map)
7201 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7202 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7203 Use and return ptrdiff_t, not int.
7204 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7205 * gtkutil.h: Change prototypes to match the above.
7207 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7208 are duplicate now that they've been promoted to lisp.h.
7209 (x_allocate_bitmap_record, x_alloc_image_color)
7210 (make_image_cache, cache_image, xpm_load):
7211 Don't update size until alloc is done.
7212 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7214 Check for size calculation overflow.
7215 (ct_colors_allocated_max): New constant.
7216 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7219 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7220 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7221 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7222 Use ptrdiff_t, not int, to count maps.
7223 (read_char_minibuf_menu_prompt): Check for overflow in size
7224 calculations. Don't update size until allocation succeeds.
7225 Redo calculations to avoid overflow.
7226 * keyboard.h: Change prototypes to match the above.
7228 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7230 (current_minor_maps): Check for size calculation overflow.
7231 * keymap.h: Change prototypes to match the above.
7233 * lread.c (read1, init_obarray): Don't update size until alloc done.
7235 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7236 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7238 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7239 Now ptrdiff_t, not int.
7240 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7241 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7243 * process.c (Fnetwork_interface_list): Check for overflow
7244 in size calculation.
7246 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7248 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7249 overflow. Don't bother calling xmalloc when xrealloc will do.
7251 * search.c (Freplace_match): Check for size calculation overflow.
7252 (Fset_match_data): Don't assume list lengths fit in 'int'.
7254 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7255 for command line length. Do not attempt to address one before the
7256 beginning of an array, as that's not portable.
7258 * term.c (max_frame_lines): Remove; unused.
7259 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7261 (encode_terminal_code, calculate_costs): Check for size
7262 calculation overflow.
7263 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7264 table lengths and related sizes. Don't update size until alloc
7265 done. Redo calculations to avoid overflow.
7266 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7268 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7269 subtracting pointers.
7270 (gobble_line): Check for overflow more carefully. Don't update size
7273 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7274 Don't update size until alloc done.
7275 Redo size calculations to avoid overflow.
7276 Check for size calculation overflow.
7277 (main) [DEBUG]: Fix typo in invoking tparam1.
7279 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7280 Use ptrdiff_t, not int, for sizes.
7281 (store_mode_line_noprop_char): Don't update size until alloc done.
7283 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7284 Use ptrdiff_t, not int, for sizes.
7285 (Finternal_make_lisp_face, cache_face):
7286 Check for size calculation overflow.
7287 (cache_face): Treat size calculation overflows as if they were
7288 memory exhaustion (the usual treatment), rather than aborting.
7290 * xfns.c (x_encode_text, x_set_name_internal)
7291 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7292 sizes, since they can exceed INT_MAX in size. Check for size
7293 calculation overflow.
7295 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7296 (xg_select): Check for size calculation overflow.
7297 Don't update size until alloc done.
7299 * xrdb.c (get_environ_db): Don't assume path length fits in int,
7300 as sprintf is limited to int lengths.
7302 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7303 (X_LONG_MIN): New macros.
7304 Use them to make the following changes clearer.
7305 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7306 This change doesn't affect the value now, but it may help remind
7307 future maintainers not to raise the value too much later.
7308 (SELECTION_QUANTUM): Remove, replacing with ...
7309 (selection_quantum): ... new function, which avoids overflow.
7311 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7312 assumption that selection length fits in 'int'.
7313 (x_reply_selection_request, x_handle_selection_request)
7314 (x_get_window_property, receive_incremental_selection)
7315 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7316 (lisp_data_to_selection_data, clean_local_selection_data):
7317 Use ptrdiff_t, not int, to record length of selection.
7318 (x_reply_selection_request, x_get_window_property)
7319 (receive_incremental_selection, x_property_data_to_lisp):
7320 Redo calculations to avoid overflow.
7321 (x_reply_selection_request): When sending hint, ceiling it at
7322 X_LONG_MAX rather than relying on wraparound overflow to send
7324 (x_get_window_property, receive_incremental_selection)
7325 (lisp_data_to_selection_data, x_property_data_to_lisp):
7326 Check for size-calculation overflow.
7327 (x_get_window_property, receive_incremental_selection)
7328 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7329 Don't store size until memory allocation succeeds.
7330 (x_get_window_property): Plug memory leak on memory exhaustion.
7331 Don't double-block input; malloc is safe here. Don't assume 2**34
7332 - 4 fits in unsigned long. Add an xassert to check
7333 XGetWindowProperty overflow. Be more careful about overflow
7334 calculations, and distinguish size from memory overflow better.
7335 (receive_incremental_selection): When tracing, don't assume
7336 unsigned int is less than INT_MAX.
7337 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7338 harmful) conversions of unsigned short to int.
7339 (lisp_data_to_selection_data): Don't assume that integers
7340 in the range -65535 through -1 fit in an X unsigned short.
7341 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7342 result parameters unless successful. Rely on cons_to_unsigned
7343 to report problems with elements; the old code wasn't right anyway.
7344 (x_check_property_data): Check for int overflow; we cannot use
7345 a wider type due to X limits.
7346 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7348 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
7350 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7351 (x_term_init): Check for size calculation overflow.
7352 (x_color_cells): Don't store size until memory allocation succeeds.
7353 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
7354 Don't assume alloca size is less than MAX_ALLOCA.
7355 (x_term_init): Don't assume length fits in int (sprintf is limited
7358 Use ptrdiff_t for composition IDs.
7359 * character.c (lisp_string_width):
7360 * composite.c (composition_table_size, n_compositions)
7361 (get_composition_id, composition_gstring_from_id):
7362 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7363 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7364 * window.c (Frecenter):
7365 Use ptrdiff_t, not int, for composition IDs.
7366 * composite.c (get_composition_id): Check for integer overflow.
7367 * composite.h: Adjust prototypes to match the above changes.
7369 Use ptrdiff_t for hash table indexes.
7370 * category.c (hash_get_category_set):
7371 * ccl.c (ccl_driver):
7372 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7373 * coding.c (coding_system_charset_list, detect_coding_system):
7374 * coding.h (struct coding_system.id):
7375 * composite.c (get_composition_id, gstring_lookup_cache):
7376 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7377 * image.c (xpm_get_color_table_h):
7378 * lisp.h (hash_lookup, hash_put):
7379 * minibuf.c (Ftest_completion):
7380 Use ptrdiff_t for hash table indexes, not int (which is too
7381 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7382 32-bit --with-wide-int hosts).
7384 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7385 Add a FIXME comment about memory leaks.
7386 (syms_of_charset): Don't assume xmalloc returns.
7388 Don't assume that stated character widths fit in int.
7389 * character.c (Fchar_width, c_string_width, lisp_string_width):
7390 * character.h (CHAR_WIDTH):
7391 * indent.c (MULTIBYTE_BYTES_WIDTH):
7392 Use sanitize_char_width to avoid undefined and/or bad behavior
7393 with outlandish widths.
7394 * character.h (sanitize_tab_width): Rename from sanitize_width,
7395 now that we have two such functions. All uses changed.
7396 (sanitize_char_width): New inline function.
7398 Don't assume that tab-width fits in int.
7399 * character.h (sanitize_width): New inline function.
7400 (SANE_TAB_WIDTH): New macro.
7401 (ASCII_CHAR_WIDTH): Use it.
7402 * indent.c (sane_tab_width): Remove. All uses replaced by
7403 SANE_TAB_WIDTH (current_buffer).
7404 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7406 * fileio.c: Integer overflow issues with file modes.
7407 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7409 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7410 Remove unreachable code.
7411 (read_hex, load_charset_map_from_file): Check for integer overflow.
7413 * xterm.c: Don't go over XClientMessageEvent limit.
7414 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7415 (x_send_scroll_bar_event): Likewise. Check that the size does not
7416 exceed limits imposed by XClientMessageEvent, as well as the usual
7417 ptrdiff_t and size_t limits.
7419 * keyboard.c: Overflow, signedness and related fixes.
7420 (make_lispy_movement): Use same integer type in forward decl
7421 that is used in the definition.
7422 (read_key_sequence, keyremap_step):
7423 Change bufsize argument back to int, undoing my 2011-03-30 change.
7424 We prefer signed types, and int is wide enough here.
7425 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7426 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7427 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7428 length, not size_t. Use ptrdiff_t for index, not int.
7429 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7430 possibility of integer overflow.
7432 Overflow, signedness and related fixes for images.
7434 * dispextern.h (struct it.stack[0].u.image.image_id)
7435 (struct_it.image_id, struct image.id, struct image_cache.size)
7436 (struct image_cache.used, struct image_cache.ref_count):
7437 * gtkutil.c (update_frame_tool_bar):
7438 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7439 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7440 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7441 * nsmenu.m (update_frame_tool_bar):
7442 * xdisp.c (calc_pixel_width_or_height):
7443 * xfns.c (image_cache_refcount):
7444 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7445 on typical 64-bit hosts.
7447 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7448 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7449 Omit unnecessary casts to int.
7450 (parse_image_spec): Check that integers fall into 'int' range
7451 when the callers expect that.
7452 (image_ascent): Redo ascent calculation to avoid int overflow.
7453 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7454 (lookup_image): Remove unnecessary tests.
7455 (xbm_image_p): Locals are now of int, not EMACS_INT,
7456 since parse_image_check makes sure they fit into int.
7457 (png_load, gif_load, svg_load_image):
7458 Prefer int to unsigned where either will do.
7459 (tiff_handler): New function, combining the cores of the
7460 old tiff_error_handler and tiff_warning_handler.
7461 This function is rewritten to use vsnprintf and thereby avoid
7462 stack buffer overflows. It uses only the features of vsnprintf
7463 that are common to both POSIX and native Microsoft.
7464 (tiff_error_handler, tiff_warning_handler): Use it.
7465 (tiff_load, gif_load, imagemagick_load_image):
7466 Don't assume :index value fits in 'int'.
7467 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7468 (imagemagick_load_image): Check that crop parameters fit into
7469 the integer types that MagickCropImage accepts. Don't assume
7470 Vimagemagick_render_type has a nonnegative value. Don't assume
7471 size_t fits in 'long'.
7472 (gs_load): Use printmax_t to print the widest integers possible.
7473 Check for integer overflow when computing image height and width.
7475 2011-08-26 Eli Zaretskii <eliz@gnu.org>
7477 * xdisp.c (redisplay_window): Don't force window start if point
7478 will be invisible in the resulting window. (Bug#9324)
7480 2011-08-25 Eli Zaretskii <eliz@gnu.org>
7482 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7483 the display spec is of the form `(space ...)'.
7484 (handle_display_spec): Return the value returned by
7485 handle_single_display_spec, not just 1 or zero.
7486 (handle_single_display_spec): If the display spec is of the form
7487 `(space ...)', and specifies display in the text area, return 2
7489 (try_cursor_movement): Check for the need to scroll more
7490 accurately, and prefer exact match for point under bidi.
7491 Don't advance `row' beyond the last row of the window.
7493 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7494 into disp_prop; all users changed.
7496 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7497 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7498 for the text covered by the display property.
7500 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
7502 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7503 Change return value to nil.
7504 (Frecord_buffer): Delete unused function.
7506 2011-08-24 Eli Zaretskii <eliz@gnu.org>
7508 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7509 buffers, return left-to-right.
7510 (set_cursor_from_row): Consider candidate row a win if its glyph
7511 represents a newline and point is on that newline. Fixes cursor
7512 positioning on the newline at EOL of R2L text within L2R
7513 paragraph, and vice versa.
7514 (try_cursor_movement): Check continued rows, in addition to
7515 continuation rows. Fixes unwarranted scroll when point enters a
7516 continued line of R2L text within an L2R paragraph, or vice versa.
7517 (cursor_row_p): Consider the case of point being equal to
7518 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7519 from the end of a short line to the beginning of a continued line
7520 of R2L text within L2R paragraph.
7521 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7522 composed characters.
7524 * bidi.c (bidi_check_type): Use xassert.
7525 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7528 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7530 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7533 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
7535 * nsfont.m (ns_otf_to_script): Fix typo.
7537 2011-08-22 Kenichi Handa <handa@m17n.org>
7539 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7540 extra slot even if the purpose is char-code-property-table.
7542 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7544 * xdisp.c (redisplay_window): When computing centering_position,
7545 account for the height of the header line. (Bug#8874)
7547 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7548 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7549 candidate is selected by the mouse, and that candidate has a
7550 composed character under the mouse.
7552 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7553 coordinates reported by pos-visible-in-window-p for a composed
7554 character in column zero.
7556 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7558 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7560 2011-08-22 Eli Zaretskii <eliz@gnu.org>
7562 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7563 consider it a hit if to_charpos is anywhere in the range of the
7564 composed buffer positions.
7566 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
7568 * image.c (gif_load): Don't assume that each subimage has the same
7569 dimensions as the base image. Handle disposal method that is
7570 "undefined" by the gif spec (Bug#9335).
7572 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
7574 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
7575 (Fcondition_case): Document `debug' symbol in error handler.
7577 2011-08-19 Eli Zaretskii <eliz@gnu.org>
7579 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7580 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7581 from an Org mode buffer to a Speedbar frame.
7583 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7584 a composition, take its buffer position from IT->cmp_it.charpos.
7585 Fixes cursor positioning at the beginning of a line that begins
7586 with a composed character.
7588 2011-08-18 Eli Zaretskii <eliz@gnu.org>
7590 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7591 character bidirectional type, use STRONG_L instead. Fixes crashes
7592 in a buffer produced by `describe-categories'.
7594 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7595 members before the level stack, so they would be saved and
7596 restored when copying iterator state. Fixes incorrect reordering
7597 around TABs covered by display properties.
7599 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7601 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
7603 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
7605 * eval.c (internal_condition_case, internal_condition_case_1)
7606 (internal_condition_case_2, internal_condition_case_n):
7607 Remove unnecessary aborts (Bug#9081).
7609 2011-08-17 Eli Zaretskii <eliz@gnu.org>
7611 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7612 has no `load' handler, try opening the file locally. (Bug#9311)
7614 2011-08-16 Ken Brown <kbrown@cornell.edu>
7616 * gmalloc.c: Expand comment.
7618 2011-08-16 Eli Zaretskii <eliz@gnu.org>
7620 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7621 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7623 2011-08-16 Ken Brown <kbrown@cornell.edu>
7625 Fix memory allocation problems in Cygwin build (Bug#9273).
7627 * unexcw.c ( __malloc_initialized): Declare external variable.
7628 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7630 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7632 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7634 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7636 [CYGWIN] (special_realloc): New function.
7637 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7638 requests to realloc storage in the static heap.
7640 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7642 * bidi.c (bidi_initialize): Remove unused local.
7644 2011-08-15 Eli Zaretskii <eliz@gnu.org>
7647 * biditype.h: Remove file.
7648 * makefile.w32-in ($(BLD)/bidi.$(O)):
7649 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
7651 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7653 * chartab.c: Improve commentary for the uniprop_table API.
7655 * bidi.c (bidi_paragraph_init): Support zero value of
7656 bidi_ignore_explicit_marks_for_paragraph_level.
7657 (bidi_initialize): Use uniprop_table instead of including
7658 biditype.h and bidimirror.h.
7660 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7661 coordinates of the iterator when restoring from ppos_it.
7664 2011-08-14 Kenichi Handa <handa@m17n.org>
7666 * process.c (create_process): Call setup_process_coding_systems
7667 after the pid of the process is set to -1 (Bug#8162).
7669 2011-08-14 Eli Zaretskii <eliz@gnu.org>
7671 * xdisp.c (move_it_in_display_line_to): Don't invoke
7672 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7673 ppos_it. Fixes vertical cursor motion when line beginning is
7674 covered by an image. (Bug#9296)
7676 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7678 * nsterm.h (ns_run_ascript): Declare.
7679 (NSAPP_DATA2_RUNASSCRIPT): Define.
7681 * nsfns.m (as_script, as_result, as_status): New static variables.
7682 (ns_run_ascript): New function.
7683 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
7684 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7685 the event loop. Get status from as_status (Bug#7276).
7687 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7688 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7689 the event loop (Bug#7276).
7691 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7693 * gnutls.c (QCgnutls_bootprop_priority)
7694 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7695 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7696 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7697 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7698 (QCgnutls_bootprop_verify_hostname_error)
7699 (QCgnutls_bootprop_callbacks_verify): Rename from
7700 Qgnutls_bootprop_..., all uses changed.
7702 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7705 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7707 * xfaces.c (Qframe_set_background_mode): Now static.
7708 * dispextern.h (Qframe_set_background_mode): Remove decl.
7710 * process.c (Fnetwork_interface_info): Declare local only if needed.
7712 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7714 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7715 (Fnetwork_interface_list): Allocate in increments of bytes instead
7716 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7717 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7719 (struct ifflag_def): notrailers is smart on OSX.
7720 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7721 Get hardware address with getifaddrs if available.
7723 2011-08-12 Eli Zaretskii <eliz@gnu.org>
7725 * xdisp.c (iterate_out_of_display_property): xassert that
7726 IT->position is set to within IT->object's boundaries. Break from
7727 the loop as soon as EOB is reached; avoids infloops in redisplay
7728 when IT->position is set up wrongly due to some bug.
7729 Set IT->current to match the bidi iterator unconditionally.
7730 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7731 entry. Force push_it to save on the stack the current
7732 buffer/string position, to be restored by pop_it. Fix flags in
7733 the iterator structure wrt the object coming from a display
7734 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7735 properties. (Bug#9284)
7737 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
7739 * fontset.c (fontset_get_font_group): Add proper type checks.
7742 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7744 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7745 and LC_VERSION_MIN_MACOSX.
7746 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7747 (dump_it) [LC_FUNCTION_STARTS]: Use it.
7749 2011-08-08 Eli Zaretskii <eliz@gnu.org>
7751 * xdisp.c (forward_to_next_line_start): Allow to use the
7752 no-display-properties-and-no-overlays under bidi display.
7753 Set disp_pos in the bidi iterator to avoid searches for display
7754 properties and overlays.
7756 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
7758 * editfns.c (Fset_time_zone_rule): Document relationship with the
7761 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7762 the font entity extracted from the cache (Bug#8109).
7764 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
7766 * composite.c (autocmp_chars): Don't reset point. That is done by
7767 restore_point_unwind (Bug#5984).
7769 2011-08-07 Juri Linkov <juri@jurta.org>
7771 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7772 to show the arg `TIME' instead of `TIMEVAL'.
7774 2011-08-06 Eli Zaretskii <eliz@gnu.org>
7776 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7777 display property strides EOL and includes a newline, as in
7778 longlines-mode. (Bug#9254)
7779 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7780 word-wrap under bidirectional display. (Bug#9224)
7782 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7783 is non-zero, even if the data buffer is NULL. Fixes a crash in
7784 vertical-motion with longlines-mode. (Bug#9254)
7786 2011-08-05 Eli Zaretskii <eliz@gnu.org>
7788 * bidi.c <bidi_cache_total_alloc>: Now static.
7789 (bidi_initialize): Initialize bidi_cache_total_alloc.
7791 * xdisp.c (display_line): Release buffer allocated for shelved bidi
7794 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7795 amount allocated this far in `bidi_cache_total_alloc'.
7796 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7797 non-zero, only free the data buffer without restoring the cache
7798 contents. All callers changed.
7800 * dispextern.h (bidi_unshelve_cache): Update prototype.
7802 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7803 (move_it_in_display_line, move_it_to)
7804 (move_it_vertically_backward, move_it_by_lines): Replace the call
7805 to xfree to an equivalent call to bidi_unshelve_cache.
7806 (move_it_in_display_line_to): Fix logic of returning
7807 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
7809 2011-08-05 Eli Zaretskii <eliz@gnu.org>
7811 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7812 came from a string character with a `cursor' property. (Bug#9229)
7814 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7816 * Makefile.in (LIB_PTHREAD): New variable.
7817 (LIBES): Add LIB_PTHREAD (Bug#9216).
7819 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7820 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7822 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7824 * regex.c (re_iswctype): Remove some redundant boolean conversions.
7826 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7828 * xterm.c (x_find_topmost_parent): New function.
7829 (x_set_frame_alpha): Find topmost parent window with
7830 x_find_topmost_parent and set the property there also (bug#9181).
7831 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7833 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7835 * callproc.c (Fcall_process): Avoid vfork clobbering
7836 the local vars buffer, coding_systems, current_dir.
7838 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7840 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7842 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7844 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7845 so that it is not optimized away.
7847 * xdisp.c (compute_display_string_pos): Remove unused local.
7849 2011-08-02 Eli Zaretskii <eliz@gnu.org>
7851 Fix slow cursor motion and scrolling in large buffers with
7852 selective display, like Org Mode buffers. (Bug#9218)
7854 * dispextern.h (struct bidi_it): New member disp_prop_p.
7856 * xdisp.c: Remove one-slot cache of display string positions.
7857 (compute_display_string_pos): Accept an additional argument
7858 DISP_PROP_P; callers changed. Scan at most 5K characters forward
7859 for a display string or property. If found, set DISP_PROP_P
7862 * bidi.c (bidi_fetch_char): Accept an additional argument
7863 DISP_PROP_P, and pass it to compute_display_string_pos.
7864 Only handle text covered by a display string if DISP_PROP_P is returned
7865 non-zero. All callers of bidi_fetch_char changed.
7867 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7869 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7871 2010-12-03 Don March <don@ohspite.net>
7873 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7874 last character M-[char] is translated to ESC [char] (bug#7541).
7876 2011-08-02 Kenichi Handa <handa@m17n.org>
7878 * lisp.h (uniprop_table): Extern it.
7880 * chartab.c (uniprop_table): Make it non-static.
7882 2011-08-01 Eli Zaretskii <eliz@gnu.org>
7884 * xdisp.c (forward_to_next_line_start): Accept additional argument
7885 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7887 (reseat_at_next_visible_line_start): Use the bidi iterator state
7888 returned by forward_to_next_line_start to restore the state of
7889 it->bidi_it after backing up to previous newline. (Bug#9212)
7891 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7893 * regex.c (re_comp): Protoize.
7894 (re_exec): Fix return type.
7895 (regexec): Fix type of `ret'. (Bug#9203)
7897 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7899 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7900 This is needed if max-image-size is a floating-point number.
7902 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7904 * print.c (print_object): Print empty symbol as ##.
7906 * lread.c (read1): Read ## as empty symbol.
7908 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7910 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7911 setting frame foreground color (Bug#9175).
7912 (x_set_background_color): Likewise.
7914 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7915 contents (Bug#9176).
7916 (EmacsTooltip -init): Remove bezels and add shadows to
7919 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7920 or scroll bar (Bug#8470).
7922 * nsfont.m (nsfont_open): Remove assignment to voffset and
7923 unnecessary vars hshink, expand, hd, full_height, min_height.
7924 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7926 * nsterm.h (nsfont_info): Remove voffset field.
7928 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7930 Implement strike-through and overline on NextStep (Bug#8863).
7932 * nsfont.m (nsfont_open): Use underline position provided by font,
7933 instead of hard-coded value of 2.
7934 (nsfont_draw): Call ns_draw_text_decoration instead.
7936 * nsterm.h: Add declaration for ns_draw_text_decoration.
7938 * nsterm.m (ns_draw_text_decoration): New function for drawing
7939 underline, overline, and strike-through.
7940 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7941 ns_draw_text_decoration. Change treatment of cursor drawing to
7942 accommodate underlining, etc.
7944 2011-07-28 Eli Zaretskii <eliz@gnu.org>
7946 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7949 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7951 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7952 Without this fix, if a signal arrives just after memory fills up,
7953 'malloc' might be invoked reentrantly.
7955 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7956 In other words, assume that every image size is allowed, on non-X
7957 hosts. This assumption is probably wrong, but it lets Emacs compile.
7959 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7961 * regex.c (re_iswctype): Convert return values to boolean.
7963 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7965 * xdisp.c (compute_display_string_pos): Don't use cached display
7966 string position if the buffer had its restriction changed.
7969 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7971 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7973 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7975 Integer signedness and overflow and related fixes. (Bug#9079)
7977 * bidi.c: Integer size and overflow fixes.
7978 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7979 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7980 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7981 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7982 (bidi_find_other_level_edge):
7983 Use ptrdiff_t instead of EMACS_INT where either will do.
7984 This works better on 32-bit hosts configured --with-wide-int.
7985 (bidi_cache_ensure_space): Check for size-calculation overflow.
7986 Use % rather than repeated addition, for better worst-case speed.
7987 Don't set bidi_cache_size until after xrealloc returns, because it
7989 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
7990 (bidi_cache_ensure_space): Also check that the bidi cache size
7991 does not exceed that of the largest Lisp string or buffer. See Eli
7992 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
7994 * alloc.c (__malloc_size_t): Remove.
7995 All uses replaced by size_t. See Andreas Schwab's note
7996 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7998 * image.c: Improve checking for integer overflow.
7999 (check_image_size): Assume that f is nonnull, since
8000 it is always nonnull in practice. This is one less thing to
8001 worry about when checking for integer overflow later.
8002 (x_check_image_size): New function, which checks for integer
8003 overflow issues inside X.
8004 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8005 This removes the need for a memory_full check.
8006 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8007 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8008 (xbm_read_bitmap_data): Change locals back to 'int', since
8009 their values must fit in 'int'.
8010 (xpm_load_image, png_load, tiff_load):
8011 Invoke x_create_x_image_and_pixmap earlier,
8012 to avoid much needless work if the image is too large.
8013 (tiff_load): Treat overly large images as if
8014 x_create_x_image_and_pixmap failed, not as malloc failures.
8015 (gs_load): Use x_check_image_size.
8017 * gtkutil.c: Omit integer casts.
8018 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8019 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8021 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8023 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8024 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8025 would wrongly return t on a 64-bit host.
8027 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8028 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8029 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8030 and therefore cause GCC to emit a bogus diagnostic in some cases.
8032 * image.c: Integer signedness and overflow and related fixes.
8033 This is not an exhaustive set of fixes, but it's time to
8034 record what I've got.
8035 (lookup_pixel_color, check_image_size): Remove redundant decls.
8036 (check_image_size): Don't assume that arbitrary EMACS_INT values
8037 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8038 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8039 (tiff_load, imagemagick_load_image):
8040 Check for overflow in size calculations.
8041 (x_create_x_image_and_pixmap): Remove unnecessary test for
8042 xmalloc returning NULL; that can't happen.
8043 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8044 (xpm_color_bucket): Use better integer hashing function.
8045 (xpm_cache_color): Don't possibly over-allocate memory.
8046 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8047 (gif_memory_source):
8048 Use ptrdiff_t, not int or size_t, to record sizes.
8049 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8050 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8051 either works, as we prefer signed integers.
8052 (tiff_read_from_memory, tiff_write_from_memory):
8053 Return tsize_t, not size_t, since that's what the TIFF API wants.
8054 (tiff_read_from_memory): Don't fail simply because the read would
8055 go past EOF; instead, return a short read.
8056 (tiff_load): Omit no-longer-needed casts.
8057 (Fimagemagick_types): Don't assume size fits into 'int'.
8059 Improve hashing quality when configured --with-wide-int.
8060 * fns.c (hash_string): New function, taken from sxhash_string.
8061 Do not discard information about ASCII character case; this
8062 discarding is no longer needed.
8063 (sxhash-string): Use it. Change sig to match it. Caller changed.
8064 * lisp.h: Declare it.
8065 * lread.c (hash_string): Remove, since we now use fns.c's version.
8066 The fns.c version returns a wider integer if --with-wide-int is
8067 specified, so this should help the quality of the hashing a bit.
8069 * emacs.c: Integer overflow minor fix.
8070 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8071 Define only if GNU_LINUX.
8072 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8074 * dispnew.c: Integer signedness and overflow fixes.
8075 Remove unnecessary forward decls, that were a maintenance hassle.
8076 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8078 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8079 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8080 (prepare_desired_row, line_draw_cost):
8081 Use int, not unsigned, where either works.
8082 (save_current_matrix, restore_current_matrix):
8083 Use ptrdiff_t, not size_t, where either works.
8084 (init_display): Check for overflow more accurately, and without
8085 relying on undefined behavior.
8087 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8088 Remove, replacing with the new symbols in lisp.h. All uses changed.
8089 * fileio.c (make_temp_name):
8090 * filelock.c (lock_file_1, lock_file):
8091 * xdisp.c (message_dolog):
8092 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8093 Use pMd etc. instead.
8094 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8095 replacing the pWIDE etc. symbols removed from editfns.c.
8097 * keyboard.h (num_input_events): Now uintmax_t.
8098 This is (very slightly) less likely to mess up due to wraparound.
8101 * buffer.c: Integer signedness fixes.
8102 (alloc_buffer_text, enlarge_buffer_text):
8103 Use ptrdiff_t rather than size_t when either will do, as we prefer
8106 * alloc.c: Integer signedness and overflow fixes.
8107 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8108 (__malloc_size_t): Default to size_t, not to int.
8109 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8110 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8111 Prefer ptrdiff_t to size_t when either would do, as we prefer
8113 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8114 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8115 Now const. Initialize with values that are in range even if char
8117 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8118 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8119 These functions do the right thing with sizes > 2**32.
8120 (check_depth): Now ptrdiff_t, not int.
8121 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8122 Adjust to new way of storing sizes. Check for size overflow bugs
8124 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8125 slightly wrong anyway, as it missed one instance of
8126 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8127 (refill_memory_reserve): Omit needless cast to size_t.
8128 (mark_object_loop_halt): Mark as externally visible.
8130 * xselect.c: Integer signedness and overflow fixes.
8131 (Fx_register_dnd_atom, x_handle_dnd_message):
8132 Use ptrdiff_t, not size_t, since we prefer signed.
8133 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8134 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8135 x_dnd_atoms_size and x_dnd_atoms_length.
8137 * doprnt.c: Prefer signed to unsigned when either works.
8139 * doprnt.c (doprnt):
8141 * xdisp.c (vmessage):
8142 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8143 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8144 prefer signed arithmetic to avoid comparison confusion.
8145 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8146 but is a bit tricky.
8148 Assume freestanding C89 headers, string.h, stdlib.h.
8149 * data.c, doprnt.c, floatfns.c, print.c:
8150 Include float.h unconditionally.
8151 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8152 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8153 * regex.c: Likewise for stddef.h, string.h.
8154 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8155 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8156 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8157 (STDC_HEADERS): Remove obsolete defines.
8158 * sysdep.c: Include limits.h unconditionally.
8160 Assume support for memcmp, memcpy, memmove, memset.
8161 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8162 * regex.c (memcmp, memcpy):
8163 Remove; we assume C89 now.
8165 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8166 (__malloc_safe_bcopy): Remove; no longer needed.
8168 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
8169 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8170 well either way, and we prefer signed to unsigned.
8172 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8174 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8175 closes the connection while we're reading (bug#9182).
8177 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
8179 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8180 are specified (Bug#9168).
8182 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8184 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8185 Found by GCC static checking and --with-wide-int on a 32-bit host.
8187 2011-07-25 Eli Zaretskii <eliz@gnu.org>
8189 * xdisp.c (compute_display_string_pos): Fix logic of caching
8190 previous display string position. Initialize cached_prev_pos to
8191 -1. Fixes slow-down at the beginning of a buffer.
8193 2011-07-24 Eli Zaretskii <eliz@gnu.org>
8195 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8196 for attrs[LFACE_FONTSET_INDEX].
8198 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8200 * xml.c (parse_region): Remove unused local
8201 that was recently introduced.
8203 2011-07-23 Eli Zaretskii <eliz@gnu.org>
8205 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8206 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8208 * xdisp.c (move_it_in_display_line_to): Record the best matching
8209 position for TO_CHARPOS while scanning the line, and restore it on
8210 exit if none of the characters scanned was an exact match.
8211 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
8212 when exact match is impossible due to invisible text, and the
8213 lines are truncated.
8215 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8217 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8220 2011-07-22 Eli Zaretskii <eliz@gnu.org>
8222 Fix a significant slow-down of cursor motion with C-n, C-p,
8223 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8224 auto-repeat under bidi redisplay in fontified buffers.
8225 * xdisp.c (compute_stop_pos_backwards): New function.
8226 (next_element_from_buffer): Call compute_stop_pos_backwards to
8227 find a suitable prev_stop when we find ourselves before
8229 (reseat): Don't look for prev_stop, as that could mean a very long
8231 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8232 <cached_disp_overlay_modiff>: Cache for last found display string
8234 (compute_display_string_pos): Return the cached position if asked
8235 about the same buffer in the same area of character positions, and
8236 the buffer wasn't changed since the time the display string
8237 position was cached.
8239 2011-07-22 Eli Zaretskii <eliz@gnu.org>
8241 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8242 is an integer, which is important for empty lines. (Bug#9149)
8244 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
8246 * frame.c (Fmodify_frame_parameters): In tty case, update the
8247 default face if necessary (Bug#4238).
8249 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
8251 * editfns.c (Fstring_to_char): No need to explain what a character
8252 is in the docstring (Bug#6576).
8254 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8256 * xml.c (parse_region): Make sure we always return a tree.
8258 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8260 * xml.c (parse_region): If a document contains only comments,
8263 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8265 * xml.c (make_dom): Return comments, too.
8267 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8270 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8271 and the surrounding thread.
8272 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8273 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8274 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8276 * s/openbsd.h (BROKEN_SIGIO): Define.
8277 * unexelf.c (unexec) [__OpenBSD__]:
8278 Don't update the .mdebug section of the Alpha COFF symbol table.
8280 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8282 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8285 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8287 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8288 This fixes some race conditions on the permissions of any newly
8291 * alloc.c (valid_pointer_p): Use pipe, not open.
8292 This fixes some permissions issues when debugging.
8294 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8295 If fchown fails to set both uid and gid, try to set just gid,
8296 as that is sometimes allowed. Adjust the file's mode to eliminate
8297 setuid or setgid bits that are inappropriate if fchown fails.
8299 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8301 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8302 to compare Lisp_Objects.
8303 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8304 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8305 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8307 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8309 * lread.c (read_integer): Unread even EOF character.
8310 (read1): Likewise. Properly record start position of symbol.
8312 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8313 symbol character follows.
8315 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8317 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8318 This works around a problem with the previous change to Fcopy_file.
8319 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8320 and without this change, GCC might complain about discarding
8321 fchown's return value.
8323 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
8325 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8327 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8329 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8331 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8333 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8334 it's used from the C level.
8336 * process.c: Use the same condition for POLL_FOR_INPUT in both
8337 keyboard.c and process.c (bug#1858).
8339 2011-07-09 Lawrence Mitchell <wence@gmx.li>
8341 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8342 (Fgnutls_boot): Use it.
8344 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8346 * doc.c (Fsubstitute_command_keys): Revert last change.
8348 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8350 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8351 quotes the next character, and doesn't affect other longer
8352 sequences (bug#8935).
8354 * lread.c (syms_of_lread): Clarify that is isn't only
8355 `eval-buffer' and `eval-defun' that's affected by
8356 `lexical-binding' (bug#8460).
8358 2011-07-15 Eli Zaretskii <eliz@gnu.org>
8360 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
8361 bidi redisplay when a line includes both an image and is truncated.
8363 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8365 Fix minor problems found by static checking.
8366 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8367 (elsz): Now a signed constant, not a size_t var. We prefer signed
8368 types to unsigned, to avoid integer comparison confusion. Without
8369 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8370 "cannot optimize loop, the loop counter may overflow", a symptom
8372 * indent.c (Fvertical_motion): Mark locals as initialized.
8373 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8375 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8377 * search.c (Fre_search_backward): Mention `case-fold-search' in
8378 all the re_search_* functions (bug#8138).
8380 * keyboard.c (Fopen_dribble_file): Document when the file is
8383 2011-07-14 Eli Zaretskii <eliz@gnu.org>
8385 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8388 Support bidi reordering of display and overlay strings.
8389 * xdisp.c (compute_display_string_pos)
8390 (compute_display_string_end): Accept additional argument STRING.
8391 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8392 (reseat_to_string): Initialize bidi_it->string.s and
8393 bidi_it->string.schars.
8394 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
8395 NULL (avoids a crash in bidi_paragraph_init).
8396 Initialize itb.string.lstring.
8397 (init_iterator): Call bidi_init_it only of a valid
8398 buffer position was specified. Initialize paragraph_embedding to
8400 (reseat_to_string): Initialize the bidi iterator.
8401 (display_string): If we need to ignore text properties of
8402 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8403 original value of -1 will not work with bidi.)
8404 (compute_display_string_pos): First arg is now struct
8405 `text_pos *'; all callers changed. Support display properties on
8407 (compute_display_string_end): Support display properties on Lisp
8409 (init_iterator, reseat_1, reseat_to_string): Initialize the
8410 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8411 when iterating on a string not from display properties).
8412 (compute_display_string_pos, compute_display_string_end):
8413 Fix calculation of the object to scan. Fixes an error when using
8415 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
8416 base_level_stop; instead, set base_level_stop to BEGV.
8417 Fixes crashes in vertical-motion.
8418 (next_element_from_buffer): Improve commentary for when
8419 the iterator is before prev_stop.
8420 (init_iterator): Initialize bidi_p from the default value of
8421 bidi-display-reordering, not from buffer-local value. Use the
8422 buffer-local value only if initializing for buffer iteration.
8423 (handle_invisible_prop): Support invisible properties on strings
8424 that are being bidi-reordered.
8425 (set_iterator_to_next): Support bidi reordering of C strings and
8427 (next_element_from_string): Support bidi reordering of Lisp
8429 (handle_stop_backwards): Support Lisp strings as well.
8430 (display_string): Support display of R2L glyph rows.
8431 Use IT_STRING_CHARPOS when displaying from a Lisp string.
8432 (init_iterator): Don't initialize it->bidi_p for strings
8434 (reseat_to_string): Initialize it->bidi_p for strings here.
8435 (next_element_from_string, next_element_from_c_string)
8436 (next_element_from_buffer): Add xassert's for correspondence
8437 between IT's object being iterated and it->bidi_it.string
8439 (face_before_or_after_it_pos): Support bidi iteration.
8440 (next_element_from_c_string): Handle the case of the first string
8441 character that is not the first one in the visual order.
8442 (get_visually_first_element): New function, refactored from common
8443 parts of next_element_from_buffer, next_element_from_string, and
8444 next_element_from_c_string.
8445 (tool_bar_lines_needed, redisplay_tool_bar)
8446 (display_menu_bar): Force left-to-right direction. Add a FIXME
8447 comment for making that be controlled by a user option.
8448 (push_it, pop_it): Save and restore the state of the
8449 bidi iterator. Save and restore the bidi_p flag.
8450 (pop_it): Iterate out of display property for string iteration as
8452 (iterate_out_of_display_property): Support iteration over strings.
8453 (handle_single_display_spec): Set up it->bidi_it for iteration
8454 over a display string, and call bidi_init_it.
8455 (handle_single_display_spec, next_overlay_string)
8456 (get_overlay_strings_1, push_display_prop): Set up the bidi
8457 iterator for displaying display or overlay strings.
8458 (forward_to_next_line_start): Don't use the shortcut if
8460 (back_to_previous_visible_line_start): If handle_display_prop
8461 pushed the iterator stack, restore the internal state of the bidi
8462 iterator by calling bidi_pop_it same number of times.
8463 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8464 and we are bidi-iterating, don't decrement the iterator position;
8465 instead, set the first_elt flag in the bidi iterator, to produce
8467 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8468 (push_display_prop): xassert that we are iterating a buffer.
8469 (push_it, pop_it): Save and restore paragraph_embedding member.
8470 (handle_single_display_spec, next_overlay_string)
8471 (get_overlay_strings_1, reseat_1, reseat_to_string)
8472 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8473 correctly. Don't assume unibyte strings are not bidi-reordered.
8474 (compute_display_string_pos)
8475 (compute_display_string_end): Fix handling the case of C string.
8476 (push_it, pop_it): Save and restore from_disp_prop_p.
8477 (handle_single_display_spec, push_display_prop): Set the
8478 from_disp_prop_p flag.
8479 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8480 (pop_it): Call iterate_out_of_display_property only if we are
8481 popping after iteration over a string that came from a display
8482 property. Fix a typo in popping stretch info. Add an assertion
8483 for verifying that the iterator position is in sync with the bidi
8485 (handle_single_display_spec, get_overlay_strings_1)
8486 (push_display_prop): Fix initialization of paragraph direction for
8487 string when that of the parent object is not yet determined.
8488 (reseat_1): Call bidi_init_it to resync the bidi
8489 iterator with IT's position. (Bug#7616)
8490 (find_row_edges): If ROW->start.pos gives position
8491 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8492 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8493 Reset the from_disp_prop_p flag.
8494 (SAVE_IT, RESTORE_IT): New macros.
8495 (pos_visible_p, face_before_or_after_it_pos)
8496 (back_to_previous_visible_line_start)
8497 (move_it_in_display_line_to, move_it_in_display_line)
8498 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8499 (try_scrolling, redisplay_window, display_line): Use them when
8500 saving a temporary copy of the iterator and restoring it back.
8501 (back_to_previous_visible_line_start, reseat_1)
8502 (init_iterator): Empty the bidi cache "stack".
8503 (move_it_in_display_line_to): If iterator ended up at
8504 EOL, but we never saw any buffer positions smaller than
8505 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8506 motion in bidi-reordered lines.
8507 (move_it_in_display_line_to): Record prev_method and prev_pos
8508 immediately before the call to set_iterator_to_next. Fixes cursor
8509 motion in bidi-reordered lines with stretch glyphs and strings
8510 displayed in margins. (Bug#8133) (Bug#8867)
8511 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8513 (pos_visible_p): Support positions in bidi-reordered lines.
8514 Save and restore bidi cache.
8516 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8517 (bidi_paragraph_info): Delete unused struct.
8518 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8519 (bidi_cache_start): New variable.
8520 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8522 (bidi_cache_fetch_state, bidi_cache_search)
8523 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8524 (bidi_cache_find, bidi_peek_at_next_level)
8525 (bidi_level_of_next_char, bidi_find_other_level_edge)
8526 (bidi_move_to_visually_next): Compare cache index with
8527 bidi_cache_start rather than with zero.
8528 (bidi_fetch_char): Accept new argument STRING; all callers
8529 changed. Support iteration over a string. Support strings with
8530 display properties. Support unibyte strings. Fix the type of
8531 `len' according to what STRING_CHAR_AND_LENGTH expects.
8532 (bidi_paragraph_init, bidi_resolve_explicit_1)
8533 (bidi_resolve_explicit, bidi_resolve_weak)
8534 (bidi_level_of_next_char, bidi_move_to_visually_next):
8535 Support iteration over a string.
8536 (bidi_set_sor_type, bidi_resolve_explicit_1)
8537 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8538 can now be zero (for strings); special values 0 and -1 were
8539 changed to -1 and -2, respectively.
8540 (bidi_char_at_pos): New function.
8541 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8542 Call it instead of FETCH_MULTIBYTE_CHAR.
8543 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8544 initialized to valid values.
8545 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8547 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8548 the test for valid cached positions. Fix the logic for looking up
8549 the sentinel state in the cache. GCPRO the Lisp string we are
8551 (bidi_push_it, bidi_pop_it): New functions.
8552 (bidi_initialize): Initialize the bidi cache start stack pointer.
8553 (bidi_cache_ensure_space): New function, refactored from part of
8554 bidi_cache_iterator_state. Don't assume the required size is just
8555 one BIDI_CACHE_CHUNK away.
8556 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8557 (bidi_count_bytes, bidi_char_at_pos): New functions.
8558 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8559 always valid if bidi_cache_idx is valid.
8560 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8561 is valid if it's going to be used.
8562 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8563 (bidi_cache_fetch_state, bidi_cache_search)
8564 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8565 (bidi_cache_iterator_state, bidi_cache_find)
8566 (bidi_find_other_level_edge, bidi_cache_start_stack):
8567 All variables related to cache indices are now EMACS_INT.
8569 * dispextern.h (struct bidi_string_data): New structure.
8570 (struct bidi_it): New member `string'. Make flag members be 1-bit
8571 fields, and put them last in the struct.
8572 (compute_display_string_pos, compute_display_string_end):
8574 (bidi_push_it, bidi_pop_it): Add prototypes.
8575 (struct iterator_stack_entry): New members bidi_p,
8576 paragraph_embedding, and from_disp_prop_p.
8577 (struct it): Member bidi_p is now a bit field 1 bit wide.
8578 (bidi_shelve_cache, bidi_unshelve_cache):
8581 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8582 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8583 and vector-like objects.
8585 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8586 cache around display iteration.
8588 * window.c (Fwindow_end, window_scroll_pixel_based)
8589 (displayed_window_lines, Frecenter): Save and restore the bidi
8590 cache around display iteration.
8592 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8594 * editfns.c (Fdelete_region): Clarify the use of the named
8595 parameters (bug#6788).
8597 2011-07-14 Martin Rudalics <rudalics@gmx.at>
8599 * indent.c (Fvertical_motion): Set and restore w->pointm when
8600 saving and restoring the window's buffer (Bug#9006).
8602 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8604 * editfns.c (Fstring_to_char): Clarify just what is returned
8605 (bug#6576). Text by Eli Zaretskii.
8607 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
8609 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8611 2011-07-13 Eli Zaretskii <eliz@gnu.org>
8613 * buffer.c (mmap_find): Fix a typo.
8615 2011-07-13 Johan Bockgård <bojohan@gnu.org>
8617 Fix execution of x selection hooks.
8618 * xselect.c (Qx_lost_selection_functions)
8619 (Qx_sent_selection_functions): New vars.
8620 (syms_of_xselect): DEFSYM them.
8621 (x_handle_selection_request): Pass Qx_sent_selection_functions
8622 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8623 (x_handle_selection_clear,x_clear_frame_selections):
8624 Pass Qx_lost_selection_functions rather than
8625 Vx_lost_selection_functions to Frun_hook_with_args.
8627 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8629 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
8630 The old code sometimes used this field without initializing it.
8632 * alloc.c (gc_sweep): Don't read past end of array.
8633 In theory, the old code could also have corrupted Emacs internals,
8634 though it'd be very unlikely.
8636 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8638 * character.c (Fcharacterp): Don't advertise optional ignored
8639 argument. (Bug#4026)
8641 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8643 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8646 * window.c (Fset_window_start): Doc fix (bug#4199).
8647 (Fset_window_hscroll): Ditto.
8649 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8651 Fix minor new problems caught by GCC 4.6.1.
8652 * term.c (init_tty): Remove unused local.
8653 * xsettings.c (store_monospaced_changed): Define this function only
8654 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
8657 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
8659 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8661 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8663 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8664 are the mini-buffer and the echo area (bug#3320).
8666 * term.c (init_tty): Remove support for supdup, c10 and perq
8667 terminals, which are no longer supported (bug#1482).
8669 2011-07-10 Johan Bockgård <bojohan@gnu.org>
8671 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8673 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8675 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8676 for non-popups (Bug#3642).
8678 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8680 * alloc.c (reset_malloc_hooks): Protoize.
8681 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
8682 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8683 * cm.c (losecursor): Likewise.
8684 * data.c (fmod): Likewise.
8685 * dispnew.c (swap_glyphs_in_rows): Likewise.
8686 * emacs.c (memory_warning_signal): Likewise.
8687 * floatfns.c (float_error): Likewise.
8688 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8689 (otf_open, font_otf_capability, generate_otf_features)
8690 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8692 * image.c (pbm_read_file): Likewise.
8693 * indent.c (string_display_width): Likewise.
8694 * intervals.c (check_for_interval, search_for_interval)
8695 (inc_interval_count, count_intervals, root_interval)
8696 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8697 * lread.c (defalias): Likewise.
8698 * ralloc.c (r_alloc_check): Likewise.
8699 * regex.c (set_image_of_range_1, set_image_of_range)
8700 (regex_grow_registers): Likewise.
8701 * sysdep.c (strerror): Likewise.
8702 * termcap.c (valid_filename_p, tprint, main): Likewise.
8703 * tparam.c (main): Likewise.
8704 * unexhp9k800.c (run_time_remap, save_data_space)
8705 (update_file_ptrs, read_header, write_header, calculate_checksum)
8706 (copy_file, copy_rest, display_header): Likewise.
8707 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8709 * xdisp.c (check_it): Likewise.
8710 * xfaces.c (register_color, unregister_color, unregister_colors):
8712 * xfns.c (print_fontset_result): Likewise.
8713 * xrdb.c (member, fatal, main): Likewise.
8715 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8717 Fix minor problems found by static checking (Bug#9031).
8718 * chartab.c (char_table_set_range, map_sub_char_table):
8719 Remove unused locals.
8720 (uniprop_table): Now static.
8721 * composite.c (_work_char): Remove unused static var.
8723 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
8725 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8727 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8729 * gtkutil.c (qttip_cb): Remove code without function.
8731 2011-07-09 Eli Zaretskii <eliz@gnu.org>
8733 * w32.c (pthread_sigmask): New stub.
8735 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
8737 Use pthread_sigmask, not sigprocmask (Bug#9010).
8738 sigprocmask is portable only for single-threaded applications, and
8739 Emacs can be multi-threaded when it uses GTK.
8740 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8742 * callproc.c (Fcall_process):
8743 * process.c (create_process):
8744 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8745 Use pthread_sigmask, not sigprocmask.
8747 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8749 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8750 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8753 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8755 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8756 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8757 (xg_hide_tooltip): Fix comment.
8759 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8760 in registerServicesMenuSendTypes.
8761 (validRequestorForSendType): Don't check ns_return_types.
8763 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8766 2011-07-08 Jason Rumney <jasonr@gnu.org>
8768 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8769 SH_SHOW for hidden windows (Bug#5482).
8771 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8772 frame struct members of non-existent frames (Bug#6284).
8774 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8776 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8777 variable firstTime not needed on OSX >= 10.6.
8778 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8779 >= 10.5. Use setKnobProportion, setDoubleValue.
8781 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8782 (MAC_OS_X_VERSION_10_5): Define if not defined.
8783 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8784 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8785 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8787 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
8788 cString and lossyCString on OSX >= 10.4.
8790 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
8791 sizeToFit on OSX >= 10.2.
8793 * nsimage.m (allocInitFromFile): Don't use deprecated method
8794 bestRepresentationForDevice on OSX >= 10.6.
8796 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8799 * emacs.c: Declare unexec_init_emacs_zone.
8801 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8803 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8805 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8806 on svcsMenu (Bug#8842).
8808 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8810 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8812 * nsterm.m (QUTF8_STRING): Declare.
8813 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8814 (validRequestorForSendType): Return type is (id).
8815 Change indexOfObjectIdenticalTo to indexOfObject.
8816 Check if we have local selection before returning self (Bug#8842).
8817 (writeSelectionToPasteboard): Put local selection into paste board
8818 if we have a local selection (Bug#8842).
8819 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8821 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8822 (ns_get_local_selection): Declare.
8824 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8826 * keymap.c (describe_map_tree): Don't insert a double newline at
8827 the end of the buffer (bug#1169) and return whether we inserted
8830 * callint.c (Fcall_interactively): Change "reading args" to
8831 "providing args" to try to clarify what it does (bug#1010).
8833 2011-07-07 Kenichi Handa <handa@m17n.org>
8835 * composite.c (composition_compute_stop_pos): Ignore a static
8836 composition starting before CHARPOS (Bug#8915).
8838 * xdisp.c (handle_composition_prop): Likewise.
8840 2011-07-07 Eli Zaretskii <eliz@gnu.org>
8842 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8845 2011-07-07 Kenichi Handa <handa@m17n.org>
8847 * character.h (unicode_category_t): New enum type.
8849 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8850 (Qchar_code_property_table): New variable.
8851 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8852 (UNIPROP_COMPRESSED_FORM_P): New macros.
8853 (char_table_ascii): Uncompress the compressed values.
8854 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8855 Uncompress the compressed values.
8856 (sub_char_table_ref_and_range): Likewise.
8857 (char_table_ref_and_range): Uncompress the compressed values.
8858 (sub_char_table_set): New arg is_uniprop. Callers changed.
8859 Uncompress the compressed values.
8860 (sub_char_table_set_range): Args changed. Callers changed.
8861 (char_table_set_range): Adjuted for the above change.
8862 (map_sub_char_table): Delete args default_val and parent. Add arg
8863 top. Give decoded values to a Lisp function.
8864 (map_char_table): Adjust for the above change. Give decoded
8865 values to a Lisp function. Gcpro more variables.
8866 (uniprop_table_uncompress)
8867 (uniprop_decode_value_run_length): New functions.
8868 (uniprop_decoder, uniprop_decoder_count): New variables.
8869 (uniprop_get_decoder, uniprop_encode_value_character)
8870 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8872 (uniprop_encoder, uniprop_encoder_count): New variables.
8873 (uniprop_get_encoder, uniprop_table)
8874 (Funicode_property_table_internal, Fget_unicode_property_internal)
8875 (Fput_unicode_property_internal): New functions.
8876 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8877 Sunicode_property_table_internal, Sget_unicode_property_internal,
8878 and Sput_unicode_property_internal. Defvar_lisp
8879 char-code-property-alist.
8881 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
8882 Vunicode_category_table.
8884 * font.c (font_range): Adjust for the change of
8885 Vunicode_category_table.
8887 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8889 * m/iris4d.h: Remove file, move contents ...
8890 * s/irix6-5.h: ... here.
8892 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8894 Remove unportable assumption about struct layout (Bug#8884).
8895 * alloc.c (mark_buffer):
8896 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8897 (clone_per_buffer_values): Don't assume that
8898 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8899 This isn't true in general, and it's particularly not true
8900 if Emacs is configured with --with-wide-int.
8901 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8902 New macros, used in the buffer.c change.
8904 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8906 * xsettings.c: Use both GConf and GSettings if both are available.
8907 (store_config_changed_event): Add comment.
8908 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8909 (store_tool_bar_style_changed): New functions.
8910 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
8911 (struct xsettings): Move font inside HAVE_XFT.
8912 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
8913 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
8914 Move inside HAVE_XFT.
8915 (something_changed_gsettingsCB): Rename from something_changedCB.
8916 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8918 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
8919 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
8920 (something_changed_gconfCB): Rename from something_changedCB.
8921 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8922 (parse_settings): Move check for font inside HAVE_XFT.
8923 (read_settings, apply_xft_settings): Add comment.
8924 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8925 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8926 call store_font_name_changed.
8927 (xft_settings_event): Add comment.
8928 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8929 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8930 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8931 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8932 (xsettings_initialize): Call init_gsettings last.
8933 (xsettings_get_system_font, xsettings_get_system_normal_font):
8936 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8938 Random fixes. E.g., (random) never returned negative values.
8939 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8940 subseconds part to the entropy, as that's a bit more random.
8941 Prefer signed to unsigned, since the signedness doesn't matter and
8942 in general we prefer signed. When given a limit, use a
8943 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8944 latter isn't right if USE_2_TAGS_FOR_INTS.
8945 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8946 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8948 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8950 * textprop.c (text_property_stickiness):
8951 Obey Vtext_property_default_nonsticky.
8952 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8953 * w32fns.c (syms_of_w32fns):
8954 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8956 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8958 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8959 This is more efficient than Ffile_directory_p and avoids a minor race.
8961 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8963 * buffer.c (Foverlay_put): Say what the return value is
8966 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8967 is a directory before asking whether to use the file name
8969 (barf_or_query_if_file_exists): Make the "File is a directory"
8970 error be more correct.
8972 * fns.c (Frequire): Remove the mention of the .gz files, since
8973 that's installation-specific, but keep the mention of
8974 `get-load-suffixes'.
8976 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8978 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8979 Report string overflow if the output is too long.
8981 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
8983 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8984 (syms_of_gnutls): Remove duplicate DEFSYM for
8985 Qgnutls_bootprop_verify_hostname_error, an error for
8986 Qgnutls_bootprop_verify_error (which is no longer used).
8988 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8989 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8990 Also (re)move comments that are misplaced or no longer relevant.
8992 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8994 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8996 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
8998 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8999 and background color parameters if they have been changed.
9001 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9003 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9005 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9007 * xsettings.c (SYSTEM_FONT): Define only when used.
9008 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9010 * keymap.c (access_keymap_1): Now static.
9012 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
9014 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9015 leave any prefix arg for the up event (Bug#1586).
9017 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9019 * lread.c (syms_of_lread): Mention single symbols defined by
9020 `defvar' or `defconst' (bug#7154).
9022 * fns.c (Frequire): Mention .el.gz files (bug#7314).
9023 (Frequire): Mention get-load-suffixes.
9025 2011-07-02 Martin Rudalics <rudalics@gmx.at>
9027 * window.h (window): Remove clone_number slot.
9028 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9030 (make_parent_window, make_window, saved_window)
9031 (Fset_window_configuration, save_window_save): Don't deal with
9033 * buffer.c (Qclone_number): Remove declaration.
9034 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9036 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9038 Add multiple inheritance to keymaps.
9039 * keymap.c (Fmake_composed_keymap): New function.
9040 (Fset_keymap_parent): Simplify.
9041 (fix_submap_inheritance): Remove.
9042 (access_keymap_1): New function extracted from access_keymap to handle
9043 embedded parents and handle lists of maps.
9044 (access_keymap): Use it.
9045 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9046 (Fcopy_keymap): Handle embedded parents.
9047 (Fcommand_remapping, define_as_prefix): Simplify.
9048 (Fkey_binding): Simplify.
9049 (syms_of_keymap): Move minibuffer-local-completion-map,
9050 minibuffer-local-filename-completion-map,
9051 minibuffer-local-must-match-map, and
9052 minibuffer-local-filename-must-match-map to Elisp.
9053 (syms_of_keymap): Defsubr make-composed-keymap.
9054 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9055 (parse_menu_item): Trivial simplification.
9057 2011-07-01 Glenn Morris <rgm@gnu.org>
9059 * Makefile.in (SETTINGS_LIBS): Fix typo.
9061 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9063 * coding.c (Fencode_coding_string): Record the last coding system
9064 used, as the function doc string says (bug#8738).
9066 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9068 * xsettings.c (store_monospaced_changed): Take new font as arg and
9069 check for change against current_mono_font.
9070 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9071 (emacs_settings_constructor, emacs_settings_get_property)
9072 (emacs_settings_set_property, emacs_settings_class_init)
9073 (emacs_settings_init, gsettings_obj): Remove.
9074 (something_changedCB): New function for HAVE_GSETTINGS.
9075 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9076 with value as argument.
9077 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9078 g_settings_new (Bug#8967). Do not create gsettings_obj.
9079 Remove calls to g_settings_bind. Connect something_changedCB to
9082 * xgselect.c: Add defined (HAVE_GSETTINGS).
9083 (xgselect_initialize): Ditto.
9085 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9086 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9089 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9091 * eval.c (struct backtrace): Simplify and port the data structure.
9092 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9093 signed bit field, as this assumption is not portable and it makes
9094 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9095 "char debug_on_exit : 1" as this is not portable either; instead,
9096 use the portable "unsigned int debug_on_exit : 1". Remove unused
9097 member evalargs. Remove obsolete comments about cc bombing out.
9099 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9101 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9102 Let HAVE_GSETTINGS override HAVE_GCONF.
9103 (store_monospaced_changed): New function.
9104 (EMACS_SETTINGS): A new type derived from GObject to handle
9105 GSettings notifications.
9106 (emacs_settings_constructor, emacs_settings_get_property)
9107 (emacs_settings_set_property, emacs_settings_class_init):
9109 (gsettings_client, gsettings_obj): New variables.
9110 (GSETTINGS_SCHEMA): New define.
9111 (something_changedCB): Call store_monospaced_changed.
9112 (init_gsettings): New function.
9113 (xsettings_initialize): Call init_gsettings.
9114 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9117 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9120 2011-06-29 Martin Rudalics <rudalics@gmx.at>
9122 * window.c (resize_root_window, grow_mini_window)
9123 (shrink_mini_window): Rename Qresize_root_window to
9124 Qwindow_resize_root_window and Qresize_root_window_vertically to
9125 Qwindow_resize_root_window_vertically.
9127 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9129 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9131 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
9133 * makefile.w32-in: Redesign dependencies so they reflect more
9134 clearly which files are directly included by each source file,
9135 and not through other includes.
9137 2011-06-27 Martin Rudalics <rudalics@gmx.at>
9139 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9140 (sort_overlays, overlay_strings): When an overlay's clone number
9141 matches the window's clone number process the overlay even if
9142 the overlay's window property doesn't match the current window.
9144 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9145 (Fwindow_hchild): Rename to Fwindow_left_child.
9146 (Fwindow_next): Rename to Fwindow_next_sibling.
9147 (Fwindow_prev): Rename to Fwindow_prev_sibling.
9148 (resize_window_check): Rename to window_resize_check.
9149 (resize_window_apply): Rename to window_resize_apply.
9150 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9151 (Fdelete_other_windows_internal, resize_frame_windows)
9152 (Fsplit_window_internal, Fdelete_window_internal)
9153 (grow_mini_window, shrink_mini_window)
9154 (Fresize_mini_window_internal): Fix callers accordingly.
9156 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9158 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9159 (emacs_fixed_set_min_size): Remove.
9160 (emacs_fixed_new): Take frame as argument.
9162 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9163 (_EmacsFixedPrivate): Remove minwidth/height.
9164 Add struct frame *f.
9165 (emacs_fixed_init): Initialize priv->f.
9166 (get_parent_class, emacs_fixed_set_min_size): Remove.
9167 (emacs_fixed_new): Set priv->f to argument.
9168 (emacs_fixed_get_preferred_width)
9169 (emacs_fixed_get_preferred_height): Use min_width/height from
9170 frames size_hint to set minimum and natural (Bug#8919).
9171 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9172 and use min_width/height from frames size_hint to set
9173 min_width/height (Bug#8919).
9175 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9176 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9179 2011-06-26 Eli Zaretskii <eliz@gnu.org>
9181 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9182 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9185 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
9187 * process.c (wait_reading_process_output): Bypass select if
9188 waiting for a cell while ignoring keyboard input, and input is
9189 pending. Suggested by Jan Djärv (Bug#8869).
9191 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9193 Use gnulib's dup2 module instead of rolling our own.
9194 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9196 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9198 * dispnew.c (scrolling_window): Before scrolling, turn off a
9199 mouse-highlight in the window being scrolled.
9201 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
9203 Move DEFSYM to lisp.h and use everywhere.
9205 * character.h (DEFSYM): Move declaration...
9206 * lisp.h (DEFSYM): ...here.
9212 * w32select.c: Don't include character.h.
9214 * alloc.c (syms_of_alloc):
9215 * buffer.c (syms_of_buffer):
9216 * bytecode.c (syms_of_bytecode):
9217 * callint.c (syms_of_callint):
9218 * casefiddle.c (syms_of_casefiddle):
9219 * casetab.c (init_casetab_once):
9220 * category.c (init_category_once, syms_of_category):
9221 * ccl.c (syms_of_ccl):
9222 * cmds.c (syms_of_cmds):
9223 * composite.c (syms_of_composite):
9224 * dbusbind.c (syms_of_dbusbind):
9225 * dired.c (syms_of_dired):
9226 * dispnew.c (syms_of_display):
9227 * doc.c (syms_of_doc):
9228 * editfns.c (syms_of_editfns):
9229 * emacs.c (syms_of_emacs):
9230 * eval.c (syms_of_eval):
9231 * fileio.c (syms_of_fileio):
9232 * fns.c (syms_of_fns):
9233 * frame.c (syms_of_frame):
9234 * fringe.c (syms_of_fringe):
9235 * insdel.c (syms_of_insdel):
9236 * keymap.c (syms_of_keymap):
9237 * lread.c (init_obarray, syms_of_lread):
9238 * macros.c (syms_of_macros):
9239 * msdos.c (syms_of_msdos):
9240 * print.c (syms_of_print):
9241 * process.c (syms_of_process):
9242 * search.c (syms_of_search):
9243 * sound.c (syms_of_sound):
9244 * syntax.c (init_syntax_once, syms_of_syntax):
9245 * terminal.c (syms_of_terminal):
9246 * textprop.c (syms_of_textprop):
9247 * undo.c (syms_of_undo):
9248 * w32.c (globals_of_w32):
9249 * window.c (syms_of_window):
9250 * xdisp.c (syms_of_xdisp):
9251 * xfaces.c (syms_of_xfaces):
9252 * xfns.c (syms_of_xfns):
9253 * xmenu.c (syms_of_xmenu):
9254 * xsettings.c (syms_of_xsettings):
9255 * xterm.c (syms_of_xterm): Use DEFSYM.
9257 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9259 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
9261 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9263 Integer and buffer overflow fixes (Bug#8873).
9265 * print.c (printchar, strout): Check for string overflow.
9266 (PRINTPREPARE, printchar, strout):
9267 Don't set size unless allocation succeeds.
9269 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9270 for sizes. Check for string overflow more accurately.
9271 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9273 * macros.c: Integer and buffer overflow fixes.
9274 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9275 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9276 Use ptrdiff_t, not int, for sizes.
9277 Don't increment bufsize until after realloc succeeds.
9278 Check for size-calculation overflow.
9279 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9281 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9283 * lread.c: Integer overflow fixes.
9284 (read_integer): Radix is now EMACS_INT, not int,
9285 to improve quality of diagnostics for out-of-range radices.
9286 Calculate buffer size correctly for out-of-range radices.
9287 (read1): Check for integer overflow in radices, and in
9288 read-circle numbers.
9289 (read_escape): Avoid int overflow.
9290 (Fload, openp, read_buffer_size, read1)
9291 (substitute_object_recurse, read_vector, read_list, map_obarray):
9292 Use ptrdiff_t, not int, for sizes.
9293 (read1): Use EMACS_INT, not int, for sizes.
9294 Check for size overflow.
9296 * image.c (cache_image): Check for size arithmetic overflow.
9298 * lread.c: Integer overflow issues.
9299 (saved_doc_string_size, saved_doc_string_length)
9300 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9301 Now ptrdiff_t, not int.
9302 (read1): Don't assume doc string length fits in int. Check for
9303 out-of-range doc string lengths.
9304 (read_list): Don't assume file position fits in int.
9305 (read_escape): Check for hex character overflow.
9307 2011-06-22 Leo Liu <sdl.web@gmail.com>
9309 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9310 Move to minibuffer.el.
9312 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9314 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
9315 The following patches are for when GLYPH_DEBUG && !XASSERT.
9316 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9317 * dispnew.c (flush_stdout):
9318 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9319 Mark as externally visible.
9320 * dispnew.c (check_window_matrix_pointers): Now static.
9321 * dispnew.c (window_to_frame_vpos):
9322 * xfns.c (unwind_create_frame):
9323 * xterm.c (x_check_font): Remove unused local.
9324 * scroll.c (CHECK_BOUNDS):
9325 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9326 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9327 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9328 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9329 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9331 (debug_method_add): Use va_list and vsprintf rather than relying
9332 on undefined behavior with wrong number of arguments.
9333 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9334 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9335 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9336 since we're not interested in debugging glyphs with old libraries.
9337 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9338 GCC 4.6.0's static checking.
9340 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9342 Integer overflow and signedness fixes (Bug#8873).
9343 A few related buffer overrun fixes, too.
9345 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9347 * dispextern.h (struct face.stipple):
9348 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9349 (x_bitmap_mask, x_allocate_bitmap_record)
9350 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9351 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9352 (x_create_bitmap_from_xpm_data):
9353 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9354 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9356 * xfaces.c (load_pixmap):
9357 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9358 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9359 (.bitmaps_last, struct x_output.icon_bitmap):
9360 Use ptrdiff_t, not int, for bitmap indexes.
9361 (x_allocate_bitmap_record): Check for size overflow.
9362 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9364 Use ptrdiff_t, not int, for overlay counts.
9365 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9366 * editfns.c (overlays_around, get_pos_property):
9367 * textprop.c (get_char_property_and_overlay):
9368 * xdisp.c (next_overlay_change, note_mouse_highlight):
9369 * xfaces.c (face_at_buffer_position):
9370 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9371 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9372 (Fnext_overlay_change, Fprevious_overlay_change)
9373 (mouse_face_overlay_overlaps, Foverlays_in):
9374 Use ptrdiff_t, not int, for sizes.
9375 (overlays_at, overlays_in): Check for size-calculation overflow.
9377 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9379 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9380 (x_session_initialize): Do not assume string length fits in int.
9382 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9383 This is unlikely, but can occur if DPI is outlandish.
9385 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
9386 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9388 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9389 * xrdb.c (magic_file_p, search_magic_path):
9390 Omit last arg SUFFIX; it was always 0. All callers changed.
9391 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9393 * xfont.c (xfont_match): Avoid need for strlen.
9395 * xfns.c: Don't assume strlen fits in int.
9396 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9398 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9399 not unsigned long, as we prefer signed integers. All callers changed.
9400 Detect integer overflow in repeat count.
9401 (message_dolog): Don't assume print length fits in 39 bytes.
9402 (display_mode_element): Don't assume strlen fits in int.
9404 * termcap.c: Don't assume sizes fit in int and never overflow.
9405 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9406 (gobble_line): Check for size-calculation overflow.
9408 * minibuf.c (Fread_buffer):
9409 * lread.c (intern, intern_c_string):
9410 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9411 Don't assume string length fits in int.
9413 * keyboard.c (parse_tool_bar_item):
9414 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9416 * font.c: Don't assume string length fits in int.
9417 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9418 Use ptrdiff_t, not int.
9419 (font_intern_prop): Don't assume string length fits in int.
9420 Don't assume integer property fits in fixnum.
9421 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
9423 * filelock.c: Fix some buffer overrun and integer overflow issues.
9424 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
9425 Reformulate so as not to need the command string.
9426 Invoke gzip -cd rather than gunzip, as it's more portable.
9427 (lock_info_type, lock_file_1, lock_file):
9428 Don't assume pid_t and time_t fit in unsigned long.
9429 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9430 (current_lock_owner): Prefer signed type for sizes.
9431 Use memcpy, not strncpy, where memcpy is what is really wanted.
9432 Don't assume (via atoi) that time_t and pid_t fit in int.
9433 Check for time_t and/or pid_t out of range, e.g., via a network share.
9434 Don't alloca where an auto var works fine.
9436 * fileio.c: Fix some integer overflow issues.
9437 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9438 Don't assume string length fits in int.
9439 (directory_file_name): Don't assume string length fits in long.
9440 (make_temp_name): Don't assume pid fits in int, or that its print
9441 length is less than 20.
9443 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9445 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9447 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9449 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9450 We prefer signed integers, even for size calculations.
9452 * emacs.c: Don't assume string length fits in 'int'.
9453 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9454 (main): Don't invoke strlen when not needed.
9456 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9457 (XD_DEBUG_MESSAGE): Don't waste a byte.
9459 * callproc.c (getenv_internal_1, getenv_internal)
9461 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9463 * lread.c (invalid_syntax): Omit length argument.
9464 All uses changed. This doesn't fix a bug, but it simplifies the
9465 code away from its former Hollerith-constant appearance, and it's
9466 one less 'int' to worry about when looking at integer-overflow issues.
9467 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
9469 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9470 This didn't break anything, but it didn't help either.
9471 It's confusing to put a bogus integer in a place where the actual
9472 value does not matter.
9473 (LIST_END_P): Remove unused macro and its bogus comment.
9474 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
9476 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9477 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9479 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9480 We prefer signed types, and the value cannot exceed the EMACS_INT
9481 range anyway (because otherwise the length would not be representable).
9482 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9483 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9484 This avoids a GCC warning when WIDE_EMACS_INT.
9486 * indent.c (sane_tab_width): New function.
9487 (current_column, scan_for_column, Findent_to, position_indentation)
9488 (compute_motion): Use it. This is just for clarity.
9489 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
9491 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
9493 * lisp.h (lint_assume): New macro.
9494 * composite.c (composition_gstring_put_cache):
9495 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9497 * editfns.c, insdel.c:
9498 Omit unnecessary forward decls, to simplify future changes.
9500 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9502 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9504 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
9505 Use much-faster test for byte-length change.
9506 Don't assume string byte-length fits in 'int'.
9507 Check that character arg fits in 'int'.
9508 (mapcar1): Declare byte as byte, for clarity.
9510 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9512 * fns.c (concat): Catch string overflow earlier.
9513 Do not rely on integer wraparound.
9515 * dispextern.h (struct it.overlay_strings_charpos)
9516 (struct it.selective): Now EMACS_INT, not int.
9517 * xdisp.c (forward_to_next_line_start)
9518 (back_to_previous_visible_line_start)
9519 (reseat_at_next_visible_line_start, next_element_from_buffer):
9520 Don't arbitrarily truncate the value of 'selective' to int.
9522 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9524 * composite.c: Don't truncate sizes to 'int'.
9525 (composition_gstring_p, composition_reseat_it)
9526 (composition_adjust_point): Use EMACS_INT, not int.
9527 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9528 not EMACS_UINT, for indexes.
9530 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9532 * buffer.c: Include <verify.h>.
9533 (struct sortvec.priority, struct sortstr.priority):
9534 Now EMACS_INT, not int.
9535 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
9536 (struct sortstr.size, record_overlay_string)
9537 (struct sortstrlist.size, struct sortlist.used):
9538 Don't truncate size to int.
9539 (record_overlay_string): Check for size-calculation overflow.
9540 (init_buffer_once): Check at compile-time, not run-time.
9542 2011-06-22 Jim Meyering <meyering@redhat.com>
9544 Don't leak an XBM-image-sized buffer
9545 * image.c (xbm_load): Free the image buffer after using it.
9547 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9550 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9551 that Sun C diagnosed.
9552 * fns.c (secure_hash): Fix pointer signedness issue.
9553 * intervals.c (static_offset_intervals): New function.
9554 (offset_intervals): Use it.
9556 2011-06-21 Leo Liu <sdl.web@gmail.com>
9559 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9562 * fns.c (secure_hash): Rename from crypto_hash_function and change
9563 the first arg to accept symbols.
9564 (Fsecure_hash): New primitive.
9565 (syms_of_fns): New symbols.
9567 2011-06-20 Deniz Dogan <deniz@dogan.se>
9569 * process.c (Fset_process_buffer): Clarify return value in
9572 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
9574 * dispnew.c (add_window_display_history): Use BVAR.
9576 * xdisp.c (debug_method_add): Use BVAR.
9577 (check_window_end, dump_glyph_matrix, dump_glyph)
9578 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9580 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9583 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9584 check till after the cache is created in init_frame_faces.
9586 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9588 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9590 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9592 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9593 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9594 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9596 Improve buffer-overflow checking (Bug#8873).
9597 * fileio.c (Finsert_file_contents):
9598 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9599 Remove the old (too-loose) buffer overflow checks.
9600 They weren't needed, since make_gap checks for buffer overflow.
9601 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9602 The old code merely checked for Emacs fixnum overflow, and relied
9603 on undefined (wraparound) behavior. The new code avoids undefined
9604 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9606 * editfns.c (Finsert_char): Don't dump core with very negative counts.
9607 Tune. Don't use wider integers than needed. Don't use alloca.
9608 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
9610 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9612 * insdel.c, lisp.h (buffer_overflow): New function.
9613 (insert_from_buffer_1, replace_range, replace_range_2):
9614 * insdel.c (make_gap_larger):
9615 * editfns.c (Finsert_char):
9616 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9618 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9620 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9622 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
9624 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9625 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9627 * fileio.c: Don't assume EMACS_INT fits in off_t.
9628 (emacs_lseek): New static function.
9629 (Finsert_file_contents, Fwrite_region): Use it.
9630 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9632 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9634 * fns.c: Don't overflow int when computing a list length.
9635 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9636 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9637 truncation on 64-bit hosts. Check for QUIT every
9638 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9639 faster and is responsive enough.
9640 (Flength): Report an error instead of overflowing an integer.
9641 (Fsafe_length): Return a float if the value is not representable
9642 as a fixnum. This shouldn't happen except in contrived situations.
9643 (Fnthcdr, Fsort): Don't assume list length fits in int.
9644 (Fcopy_sequence): Don't assume vector length fits in int.
9646 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9647 (header_size, word_size): New constants.
9648 (allocate_vectorlike): Don't check size overflow here.
9649 (allocate_vector): Check it here instead, since this is the only
9650 caller of allocate_vectorlike that could cause overflow.
9651 Check that the new vector's length is representable as a fixnum.
9653 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9654 The previous code was bogus. For example, next_almost_prime (32)
9655 returned 39, which is undesirable as it is a multiple of 3; and
9656 next_almost_prime (24) returned 25, which is a multiple of 5 so
9657 why was the code bothering to check for multiples of 7?
9659 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9661 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9663 Variadic C functions now count arguments with ptrdiff_t.
9664 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9665 Back then I didn't know that the Emacs coding style prefers signed int.
9666 Also, in the meantime I found a few more instances where arguments
9667 were being counted with int, which may truncate counts on 64-bit
9668 machines, or EMACS_INT, which may be unnecessarily wide.
9669 * lisp.h (struct Lisp_Subr.function.aMANY)
9670 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9671 Arg counts are now ptrdiff_t, not size_t.
9672 All variadic functions and their callers changed accordingly.
9673 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9674 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9675 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9676 * callint.c (Fcall_interactively): Check arg count for overflow,
9677 to avoid potential buffer overrun. Use signed char, not 'int',
9678 for 'varies' array, so that we needn't bother to check its size
9679 calculation for overflow.
9680 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9681 * eval.c (apply_lambda):
9682 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9683 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9684 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9686 * callint.c (Fcall_interactively): Don't use index var as event count.
9688 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9689 * mem-limits.h (SIZE): Remove; no longer used.
9691 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
9693 Remove unnecessary casts.
9694 * xterm.c (x_term_init):
9695 * xfns.c (x_set_border_pixel):
9696 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9697 These aren't needed now that we assume ANSI C.
9699 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9700 It's more likely to cause problems (due to unsigned overflow)
9703 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9705 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9707 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9709 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9711 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9713 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9715 GLYPH_CODE_FACE returns EMACS_INT, not int.
9716 * dispextern.h (merge_faces):
9717 * xfaces.c (merge_faces):
9718 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9719 Don't assume EMACS_INT fits in int.
9721 * character.h (CHAR_VALID_P): Remove unused parameter.
9722 * fontset.c, lisp.h, xdisp.c: All uses changed.
9724 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9726 * fns.c (concat): Minor tuning based on overflow analysis.
9727 This doesn't fix any bugs. Use int to hold character, instead
9728 of constantly refetching from Emacs object. Use XFASTINT, not
9729 XINT, for value known to be a character. Don't bother comparing
9730 a single byte to 0400, as it's always less.
9732 * floatfns.c (Fexpt):
9733 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9735 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9738 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9740 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9741 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9742 incorrectly succeed when S was a string, because 4294967386 was
9743 truncated before it was used.
9745 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9746 Otherwise, an out-of-range integer could cause undefined behavior
9749 * composite.c: Use int, not EMACS_INT, for characters.
9750 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9751 EMACS_INT, for values that are known to be in character range.
9752 This doesn't fix any bugs but is the usual style inside Emacs and
9753 may generate better code on 32-bit machines.
9755 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9756 This is for reasons similar to the recent CHAR_STRING fix.
9757 * charset.c (Fencode_char): Check that character arg is actually
9758 a character. Pass an int to ENCODE_CHAR.
9759 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9760 wider than 'int', as a compile-time check to prevent future regressions
9763 * character.c (char_string): Remove unnecessary casts.
9765 Make sure a 64-bit char is never passed to CHAR_STRING.
9766 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9767 by silently ignoring the top 32 bits, allowing some values
9768 that were far too large to be valid characters.
9769 * character.h: Include <verify.h>.
9770 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9771 arguments are no wider than unsigned, as a compile-time check
9772 to prevent future regressions in this area.
9774 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
9775 (Fsubst_char_in_region):
9777 * xdisp.c (decode_mode_spec_coding):
9778 Adjust to CHAR_STRING's new requirement.
9779 * editfns.c (Finsert_char, Fsubst_char_in_region):
9780 * fns.c (concat): Check that character args are actually
9781 characters. Without this test, these functions did the wrong
9782 thing with wildly out-of-range values on 64-bit hosts.
9784 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9785 These casts should not be needed on 32-bit hosts, either.
9786 * keyboard.c (read_char):
9787 * lread.c (Fload): Remove casts to unsigned.
9789 * lisp.h (UNSIGNED_CMP): New macro.
9790 This fixes comparison bugs on 64-bit hosts.
9791 (ASCII_CHAR_P): Use it.
9792 * casefiddle.c (casify_object):
9793 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
9794 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9795 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9796 * dispextern.h (FACE_FROM_ID):
9797 * keyboard.c (read_char): Use UNSIGNED_CMP.
9799 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9800 not to EMACS_INT, to avoid GCC warning.
9802 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9804 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9805 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9806 isn't needed on 32-bit machines.
9808 * buffer.c (Fgenerate_new_buffer_name):
9809 Use EMACS_INT for count, not int.
9810 (advance_to_char_boundary): Return EMACS_INT, not int.
9812 * data.c (Qcompiled_function): Now static.
9814 * window.c (window_body_lines): Now static.
9816 * image.c (gif_load): Rename local to avoid shadowing.
9818 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9819 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9820 * alloc.c (make_save_value): Integer argument is now of type
9822 (mark_object): Use ptrdiff_t, not int.
9823 * lisp.h (pD): New macro.
9824 * print.c (print_object): Use it.
9826 * alloc.c: Use EMACS_INT, not int, to count objects.
9827 (total_conses, total_markers, total_symbols, total_vector_size)
9828 (total_free_conses, total_free_markers, total_free_symbols)
9829 (total_free_floats, total_floats, total_free_intervals)
9830 (total_intervals, total_strings, total_free_strings):
9831 Now EMACS_INT, not int. All uses changed.
9832 (Fgarbage_collect): Compute overall total using a double, so that
9833 integer overflow is less likely to be a problem. Check for overflow
9834 when converting back to an integer.
9835 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9836 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9837 These were 'int' variables that could overflow on 64-bit hosts;
9838 they were never used, so remove them instead of repairing them.
9839 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
9840 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9841 Previously, this ceilinged at INT_MAX, but that doesn't work on
9843 (allocate_pseudovector): Don't use EMACS_INT when int would do.
9845 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
9846 (allocate_vectorlike): Check for ptrdiff_t overflow.
9847 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9848 when a (possibly-narrower) signed value would do just as well.
9849 We prefer using signed arithmetic, to avoid comparison confusion.
9851 * alloc.c: Catch some string size overflows that we were missing.
9852 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9853 for convenience in STRING_BYTES_MAX.
9854 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9855 The definition here is exact; the one in lisp.h was approximate.
9856 (allocate_string_data): Check for string overflow. This catches
9857 some instances we weren't catching before. Also, it catches
9858 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9859 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9860 and ptrdiff_t and EMACS_INT are both 64 bits.
9862 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9863 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
9864 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
9866 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9868 * alloc.c (Fmake_string): Check for out-of-range init.
9870 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9872 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9874 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9876 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9877 xg_get_default_scrollbar_width.
9879 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9880 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9881 (style_changed_cb): Call update_theme_scrollbar_width and call
9882 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9883 all frames (Bug#8505).
9884 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9885 Call gtk_window_set_resizable if HAVE_GTK3.
9886 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9887 and height if HAVE_GTK3 (Bug#8505).
9888 (scroll_bar_width_for_theme): New variable.
9889 (update_theme_scrollbar_width): New function.
9890 (xg_get_default_scrollbar_width): Move code to
9891 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9892 (xg_initialize): Call update_theme_scrollbar_width.
9894 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9896 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9898 2011-06-12 Martin Rudalics <rudalics@gmx.at>
9900 * frame.c (make_frame): Call other_buffer_safely instead of
9903 * window.c (temp_output_buffer_show): Call display_buffer with
9904 second argument Vtemp_buffer_show_specifiers and reset latter
9905 immediately after the call.
9906 (Vtemp_buffer_show_specifiers): New variable.
9907 (auto_window_vscroll_p, next_screen_context_lines)
9908 (Vscroll_preserve_screen_position): Remove leading asterisks from
9911 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
9913 Fix minor problems found by GCC 4.6.0 static checking.
9914 * buffer.c (Qclone_number): Remove for now, as it's unused.
9915 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9916 (record_buffer): Remove unused local.
9917 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9918 (set_frame_buffer_list): Remove; unused.
9919 * frame.h (other_visible_frames): Remove decl.
9920 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9921 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9922 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9924 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9925 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9926 Define only if HAVE_GPM.
9927 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9928 (update_hints_inhibit): Remove; never set. All uses removed.
9929 * widgetprv.h (emacsFrameClassRec): Remove decl.
9930 * window.c (delete_deletable_window): Now returns void, since it
9931 wasn't returning anything.
9932 (compare_window_configurations): Remove unused locals.
9933 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9934 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
9935 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9936 the same widths as pointers. This follows up on the 2011-05-06 patch.
9937 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9938 * xterm.h: Likewise.
9939 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9941 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
9943 * makefile.w32-in: Update dependencies.
9944 (LISP_H): Add lib/intprops.h.
9946 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9948 * image.c (gif_load): Add animation frame delay to the metadata.
9949 (syms_of_image): Use DEFSYM. New symbol `delay'.
9951 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9953 * window.c (delete_deletable_window): Re-add.
9954 (Fset_window_configuration): Rewrite to handle dead buffers and
9955 consequently deletable windows.
9956 (window_tree, Fwindow_tree): Remove. Supply functionality in
9958 (compare_window_configurations): Simplify code.
9960 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9962 * image.c (imagemagick_load_image): Fix type mismatch.
9963 (Fimagemagick_types): Likewise.
9965 * window.h (replace_buffer_in_windows): Declare.
9967 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9969 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9970 Qclone_number. Remove external declaration of Qdelete_window.
9971 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9973 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9974 Run Qbuffer_list_update_hook if allowed.
9975 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9976 buffer list implementation.
9977 (other_buffer_safely): New function.
9978 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9979 calls to replace_buffer_in_windows and
9980 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9982 (record_buffer): Inhibit quitting and rewrite using quittable
9983 functions. Run Qbuffer_list_update_hook if allowed.
9984 (Frecord_buffer, Funrecord_buffer): New functions.
9985 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9986 Move switch-to-buffer to window.el.
9987 (bury-buffer): Move to window.el.
9988 (Vbuffer_list_update_hook): New variable.
9990 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9993 * window.h (resize_frame_windows): Move up in code.
9994 (Fwindow_frame): Remove EXFUN.
9995 (replace_buffer_in_all_windows): Remove prototype.
9996 (replace_buffer_in_windows_safely): Add prototype.
9998 * window.c: Declare Qdelete_window static again. Move down
9999 declaration of select_count.
10000 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10001 (Fother_window): Move to window.el.
10002 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10003 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10004 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10006 (replace_buffer_in_windows): Implement by calling
10007 Qreplace_buffer_in_windows.
10008 (replace_buffer_in_all_windows): Remove with some functionality
10009 moved into replace_buffer_in_windows_safely.
10010 (replace_buffer_in_windows_safely): New function.
10011 (select_window_norecord, select_frame_norecord): Move in front
10012 of run_window_configuration_change_hook. Remove now obsolete
10014 (Fset_window_buffer): Rewrite doc-string.
10015 Call Qrecord_window_buffer.
10016 (keys_of_window): Move binding for other-window to window.el.
10018 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
10020 * dispextern.h (struct image): Replace data member, whose int_val
10021 and ptr_val fields were not used by anything, with a single
10024 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10025 (gif_clear_image, gif_load, imagemagick_load_image)
10026 (gs_clear_image, gs_load): Callers changed.
10028 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10030 * buffer.h: Include <time.h>, for time_t.
10031 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10033 Fix minor problems found by static checking.
10035 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10037 Make identifiers static if they are not used in other modules.
10038 * data.c (Qcompiled_function, Qframe, Qvector):
10039 * image.c (QimageMagick, Qsvg):
10040 * minibuf.c (Qmetadata):
10041 * window.c (resize_window_check, resize_root_window): Now static.
10042 * window.h (resize_window_check, resize_root_window): Remove decls.
10044 * window.c (window_deletion_count, delete_deletable_window):
10046 (window_body_lines): Now static.
10047 (Fdelete_other_windows_internal): Mark vars as initialized.
10048 Make sure 'resize_failed' is initialized.
10049 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10050 (resize_window_apply): Remove unused local.
10051 * window.h (delete_deletable_window): Remove decl.
10053 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
10054 (imagemagick_load_image): Fix pointer signedness problem by changing
10055 last arg from unsigned char * to char *. All uses changed.
10056 Also, fix a local for similar reasons.
10057 Remove unused locals. Remove locals to avoid shadowing.
10058 (fn_rsvg_handle_free): Remove; unused.
10059 (svg_load, svg_load_image): Fix pointer signedness problem.
10060 (imagemagick_load_image): Don't use garbage pointer image_wand.
10062 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10064 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
10066 * image.c (gif_load): Fix omitted cast error introduced by
10069 2011-06-10 Martin Rudalics <rudalics@gmx.at>
10071 * window.h (resize_proportionally, orig_total_lines)
10072 (orig_top_line): Remove from window structure.
10073 (set_window_height, set_window_width, change_window_heights)
10074 (Fdelete_window): Remove prototypes.
10075 (resize_frame_windows): Remove duplicate declaration.
10077 2011-06-10 Eli Zaretskii <eliz@gnu.org>
10079 * window.h (resize_frame_windows, resize_window_check)
10080 (delete_deletable_window, resize_root_window)
10081 (resize_frame_windows): Declare prototypes.
10083 * window.c (resize_window_apply): Make definition be "static" to
10084 match the prototype.
10086 2011-06-10 Martin Rudalics <rudalics@gmx.at>
10088 * window.c: Remove declarations of Qwindow_size_fixed,
10089 window_min_size_1, window_min_size_2, window_min_size,
10090 size_window, window_fixed_size_p, enlarge_window, delete_window.
10091 Remove static from declaration of Qdelete_window, it's
10092 temporarily needed by Fbury_buffer.
10093 (replace_window): Don't assign orig_top_line and
10095 (Fdelete_window, delete_window): Remove. Window deletion is
10096 handled by window.el.
10097 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10098 Replace Fdelete_window calls with calls to Qdelete_window.
10099 (Fdelete_other_windows): Remove. Deleting other windows is
10100 handled by window.el.
10101 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10102 handled in window.el.
10103 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10104 Window minimum sizes are handled in window.el.
10105 (shrink_windows, size_window, set_window_height)
10106 (set_window_width, change_window_heights, window_height)
10107 (window_width, CURBEG, CURSIZE, enlarge_window)
10108 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10109 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10110 handled in window.el.
10111 (make_dummy_parent): Rename to make_parent_window and give it a
10112 second argument horflag.
10113 (make_window): Don't set resize_proportionally any more.
10114 (Fsplit_window): Remove. Windows are split in window.el.
10115 (save_restore_action, save_restore_orig_size)
10116 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10117 Resize mini windows in window.el.
10118 (grow_mini_window, shrink_mini_window): Implement by calling
10119 Qresize_root_window_vertically, resize_window_check and
10120 resize_window_apply.
10121 (saved_window, Fset_window_configuration, save_window_save):
10122 Do not handle orig_top_line, orig_total_lines, and
10123 resize_proportionally.
10124 (window_min_height, window_min_width): Move to window.el.
10125 (keys_of_window): Move bindings for delete-other-windows,
10126 split-window, delete-window and enlarge-window to window.el.
10128 * buffer.c: Temporarily extern Qdelete_window.
10129 (Fbury_buffer): Temporarily call Qdelete_window instead of
10130 Fdelete_window (Fbury_buffer will move to window.el soon).
10132 * frame.c (set_menu_bar_lines_1): Remove code handling
10133 orig_top_line and orig_total_lines.
10135 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10136 set_window_height but set heights directly.
10137 (change_frame_size_1): Use resize_frame_windows.
10139 * xdisp.c (init_xdisp): Don't use set_window_height but set
10142 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10143 Use resize_frame_windows instead of change_window_heights and run
10144 run_window_configuration_change_hook.
10146 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10147 instead of change_window_heights and run
10148 run_window_configuration_change_hook.
10150 2011-06-09 Martin Rudalics <rudalics@gmx.at>
10152 * window.c (replace_window): Rename second argument REPLACEMENT to
10153 NEW. New third argument SETFLAG. Rewrite.
10154 (delete_window, make_dummy_parent): Call replace_window with
10156 (window_list_1): Move down in code.
10157 (run_window_configuration_change_hook): Move set_buffer part
10158 before select_frame_norecord part in order to unwind correctly.
10159 Rename count1 to count.
10160 (recombine_windows, delete_deletable_window, resize_root_window)
10161 (Fdelete_other_windows_internal)
10162 (Frun_window_configuration_change_hook, make_parent_window)
10163 (resize_window_check, resize_window_apply, Fresize_window_apply)
10164 (resize_frame_windows, Fsplit_window_internal)
10165 (Fdelete_window_internal, Fresize_mini_window_internal):
10167 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10169 2011-06-08 Martin Rudalics <rudalics@gmx.at>
10171 * window.h (window): Add some new members to window structure -
10172 normal_lines, normal_cols, new_total, new_normal, clone_number,
10173 splits, nest, prev_buffers, next_buffers.
10174 (WINDOW_TOTAL_SIZE): Move here from window.c.
10175 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
10177 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10179 (make_dummy_parent): Set new members of windows structure.
10180 (make_window): Move down in code. Handle new members of window
10182 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10183 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10184 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10185 (Fset_window_prev_buffers, Fwindow_next_buffers)
10186 (Fset_window_next_buffers, Fset_window_clone_number):
10188 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10189 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10191 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10192 Argument WINDOW can be now internal window too.
10193 (Fwindow_use_time): Move up in code.
10194 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10195 Rewrite doc-string.
10196 (Fset_window_configuration, saved_window)
10197 (Fcurrent_window_configuration, save_window_save): Handle new
10198 members of window structure.
10199 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10200 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10201 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10202 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10203 Qget_mru_window, Qresize_root_window,
10204 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10205 Qauto_buffer_name; staticpro them.
10207 2011-06-07 Martin Rudalics <rudalics@gmx.at>
10209 * window.c (Fwindow_total_size, Fwindow_left_column)
10210 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10211 (Fwindow_list_1): New functions.
10212 (window_box_text_cols): Replace with window_body_cols.
10213 (Fwindow_width, Fscroll_left, Fscroll_right):
10214 Use window_body_cols instead of window_box_text_cols.
10215 (delete_window, Fset_window_configuration):
10216 Call delete_all_subwindows with window as argument.
10217 (delete_all_subwindows): Take a window as argument and not a
10218 structure. Rewrite.
10219 (window_loop): Remove handling of GET_LRU_WINDOW and
10220 GET_LARGEST_WINDOW.
10221 (Fget_lru_window, Fget_largest_window): Move to window.el.
10223 * window.h: Extern window_body_cols instead of
10224 window_box_text_cols. delete_all_subwindows now takes a
10225 Lisp_Object as argument.
10227 * indent.c (compute_motion, Fcompute_motion):
10228 Use window_body_cols instead of window_box_text_cols.
10230 * frame.c (delete_frame): Call delete_all_subwindows with root
10231 window as argument.
10233 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10235 * fns.c (Fputhash): Document return value.
10237 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
10239 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10241 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10243 Cons<->int and similar integer overflow fixes (Bug#8794).
10245 Check for overflow when converting integer to cons and back.
10246 * charset.c (Fdefine_charset_internal, Fdecode_char):
10247 Use cons_to_unsigned to catch overflow.
10248 (Fencode_char): Use INTEGER_TO_CONS.
10249 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10250 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10251 * data.c (long_to_cons, cons_to_long): Remove.
10252 (cons_to_unsigned, cons_to_signed): New functions.
10253 These signal an error for invalid or out-of-range values.
10254 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10255 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10256 * font.c (Ffont_variation_glyphs):
10257 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10258 * lisp.h: Include <intprops.h>.
10259 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10260 (cons_to_signed, cons_to_unsigned): New decls.
10261 (long_to_cons, cons_to_long): Remove decls.
10262 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10263 (Fprimitive_undo): Use CONS_TO_INTEGER.
10264 * xfns.c (Fx_window_property): Likewise.
10265 * xselect.c: Include <limits.h>.
10266 (x_own_selection, selection_data_to_lisp_data):
10267 Use INTEGER_TO_CONS.
10268 (x_handle_selection_request, x_handle_selection_clear)
10269 (x_get_foreign_selection, Fx_disown_selection_internal)
10270 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10271 (lisp_data_to_selection_data): Use cons_to_unsigned.
10272 (x_fill_property_data): Use cons_to_signed.
10273 Report values out of range.
10275 Check for buffer and string overflow more precisely.
10276 * buffer.h (BUF_BYTES_MAX): New macro.
10277 * lisp.h (STRING_BYTES_MAX): New macro.
10278 * alloc.c (Fmake_string):
10279 * character.c (string_escape_byte8):
10280 * coding.c (coding_alloc_by_realloc):
10281 * doprnt.c (doprnt):
10282 * editfns.c (Fformat):
10284 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10285 since they may not be the same number.
10286 * editfns.c (Finsert_char):
10287 * fileio.c (Finsert_file_contents):
10288 Likewise for BUF_BYTES_MAX.
10290 * image.c: Use ptrdiff_t, not int, for sizes.
10291 (slurp_file): Switch from int to ptrdiff_t.
10293 (slurp_file): Check that file size fits in both size_t (for
10294 malloc) and ptrdiff_t (for sanity and safety).
10296 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10297 if b->modtime has its maximal value.
10299 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10301 Don't assume time_t can fit into int.
10302 * buffer.h (struct buffer.modtime): Now time_t, not int.
10303 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10304 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10306 Minor fixes for signed vs unsigned integers.
10307 * character.h (MAYBE_UNIFY_CHAR):
10308 * charset.c (maybe_unify_char):
10309 * keyboard.c (read_char, reorder_modifiers):
10310 XINT -> XFASTINT, since the integer must be nonnegative.
10311 * ftfont.c (ftfont_spec_pattern):
10312 * keymap.c (access_keymap, silly_event_symbol_error):
10313 XUINT -> XFASTINT, since the integer must be nonnegative.
10314 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10315 since it makes no difference and we prefer signed.
10316 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10317 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10320 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10322 * window.h (Fwindow_frame): Declare.
10324 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10326 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10327 (SPARE_MEMORY): Always define.
10328 (LARGE_REQUEST): Remove.
10329 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10331 2011-06-06 Martin Rudalics <rudalics@gmx.at>
10333 * lisp.h: Move EXFUNS for Fframe_root_window,
10334 Fframe_first_window and Fset_frame_selected_window to window.h.
10336 * window.h: Move EXFUNS for Fframe_root_window,
10337 Fframe_first_window and Fset_frame_selected_window here from
10340 * frame.c (Fwindow_frame, Fframe_first_window)
10341 (Fframe_root_window, Fframe_selected_window)
10342 (Fset_frame_selected_window): Move to window.c.
10343 (Factive_minibuffer_window): Move to minibuf.c.
10344 (Fother_visible_frames_p): New function.
10346 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10348 * window.c (decode_window, decode_any_window): Move up in code.
10349 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10350 (inhibit_frame_unsplittable): Remove unused variable.
10351 (Fwindow_buffer): Move up and rewrite doc-string.
10352 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10353 (Fwindow_prev): New functions.
10354 (Fwindow_frame): Move here from frame.c. Accept any window as
10356 (Fframe_root_window, Fframe_first_window)
10357 (Fframe_selected_window): Move here from frame.c. Accept frame
10358 or arbitrary window as argument. Update doc-strings.
10359 (Fminibuffer_window): Move up in code.
10360 (Fwindow_minibuffer_p): Move up in code and simplify.
10361 (Fset_frame_selected_window): Move here from frame.c.
10363 (Fselected_window, select_window, Fselect_window): Move up in
10364 code. Minor doc-string fixes.
10366 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10368 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10369 Do not assume that spare memory exists; that assumption is valid
10370 only if SYSTEM_MALLOC.
10371 (LARGE_REQUEST): New macro, so that the issue of large requests
10372 is separated from the issue of spare memory.
10374 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10376 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10379 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10381 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10384 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10386 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10388 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10390 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10391 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10393 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
10395 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10397 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
10399 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10400 (x_clipboard_manager_save): Add return value.
10401 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10402 New error handlers.
10403 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10404 Obey Vx_select_enable_clipboard_manager. Catch errors in
10405 x_clipboard_manager_save (Bug#8779).
10406 (Vx_select_enable_clipboard_manager): New variable.
10407 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
10409 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
10411 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10413 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10415 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10416 in the current matrix if keep_current_p is non-zero.
10418 2011-06-04 Eli Zaretskii <eliz@gnu.org>
10420 * bidi.c (bidi_level_of_next_char): Fix last change.
10422 2011-06-03 Eli Zaretskii <eliz@gnu.org>
10424 Support bidi reordering of text covered by display properties.
10426 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10427 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10428 (bidi_cache_search, bidi_cache_iterator_state)
10429 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
10430 (bidi_level_of_next_char, bidi_move_to_visually_next):
10431 Support character positions inside a run of characters covered by a
10433 (bidi_paragraph_init, bidi_resolve_explicit_1)
10434 (bidi_level_of_next_char): Call bidi_fetch_char and
10435 bidi_fetch_char_advance instead of FETCH_CHAR and
10436 FETCH_CHAR_ADVANCE.
10437 (bidi_init_it): Initialize new members.
10438 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10440 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10441 instead of using explicit *_CHAR codes.
10442 (bidi_resolve_explicit, bidi_resolve_weak):
10443 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
10444 bidirectional text is supported only in multibyte buffers.
10445 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10446 it to initialize the frame_window_p member of struct bidi_it.
10447 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10448 (bidi_resolve_explicit, bidi_resolve_weak)
10449 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10450 bidi_it->nchars is non-positive.
10451 (bidi_level_of_next_char): Don't try to lookup the cache for the
10452 next/previous character if nothing is cached there yet, or if we
10453 were just reseat()'ed to a new position.
10455 * xdisp.c (set_cursor_from_row): Set start and stop points
10456 according to the row's direction when priming the loop that looks
10457 for the glyph on which to display cursor.
10458 (single_display_spec_intangible_p): Function deleted.
10459 (display_prop_intangible_p): Reimplement to call
10460 handle_display_spec instead of single_display_spec_intangible_p.
10461 Accept 3 additional arguments needed by handle_display_spec.
10462 This fixes incorrect cursor motion across display property with complex
10463 values: lists, `(when COND...)' forms, etc.
10464 (single_display_spec_string_p): Support property values that are
10465 lists with the argument STRING its top-level element.
10466 (display_prop_string_p): Fix the condition for processing a
10467 property that is a list to be consistent with handle_display_spec.
10468 (handle_display_spec): New function, refactored from the
10469 last portion of handle_display_prop.
10470 (compute_display_string_pos): Accept additional argument
10471 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10472 value of a `display' property is a "replacing spec".
10473 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10474 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10475 the display property, but just return a value indicating whether
10476 the display property will replace the characters it covers.
10477 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10478 frame_window_p members of struct bidi_it.
10479 (compute_display_string_pos, compute_display_string_end):
10481 (push_it): Accept second argument POSITION, where pop_it should
10482 jump to continue iteration.
10483 (reseat_1): Initialize bidi_it.disp_pos.
10485 * keyboard.c (adjust_point_for_property): Adjust the call to
10486 display_prop_intangible_p to its new signature.
10488 * dispextern.h (struct bidi_it): New member frame_window_p.
10489 (bidi_init_it): Update prototypes.
10490 (display_prop_intangible_p): Update prototype.
10491 (compute_display_string_pos, compute_display_string_end):
10492 Declare prototypes.
10493 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10496 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
10498 Malloc failure behavior now depends on size of allocation.
10499 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10500 * lisp.h: Change signatures accordingly.
10501 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10502 All callers changed. (Bug#8762)
10504 * gnutls.c: Use Emacs's memory allocators.
10505 Without this change, the gnutls library would invoke malloc etc.
10506 directly, which causes problems on non-SYNC_INPUT hosts, and which
10507 runs afoul of improving memory_full behavior. (Bug#8761)
10508 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10509 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10510 xfree instead of the default malloc, realloc, free.
10511 (Fgnutls_boot): No need to check for memory allocation failure,
10512 since xmalloc does that for us.
10514 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
10515 * category.c (hash_get_category_set):
10516 * ccl.c (ccl_driver):
10517 * charset.c (Fdefine_charset_internal):
10518 * charset.h (struct charset.hash_index):
10519 * composite.c (get_composition_id, gstring_lookup_cache)
10520 (composition_gstring_put_cache):
10521 * composite.h (struct composition.hash_index):
10522 * dispextern.h (struct image.hash):
10523 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10524 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10525 (hashfn_equal, hashfn_user_defined, make_hash_table)
10526 (maybe_resize_hash_table, hash_lookup, hash_put)
10527 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10528 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10529 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10530 * image.c (make_image, search_image_cache, lookup_image)
10531 (xpm_put_color_table_h):
10532 * lisp.h (struct Lisp_Hash_Table):
10533 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
10534 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
10535 for hashes and hash indexes, instead of 'unsigned' and 'int'.
10536 * alloc.c (allocate_vectorlike):
10537 Check for overflow in vector size calculations.
10538 * ccl.c (ccl_driver):
10539 Check for overflow when converting EMACS_INT to int.
10540 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10541 need to be updated by these changes.
10542 * fns.c (make_hash_table, maybe_resize_hash_table):
10543 Check for integer overflow with large hash tables.
10544 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10545 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10546 (SXHASH_REDUCE): New macro.
10547 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10548 Use it instead of discarding useful hash info with large hash values.
10549 (sxhash_float): New function.
10550 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10551 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
10552 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10553 Rewrite to use FIXNUM_BITS, as this simplifies things.
10554 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10555 Adjust signatures to match updated version of code.
10556 (consing_since_gc): Now EMACS_INT, since a single hash table can
10557 use more than INT_MAX bytes.
10559 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10561 Make it possible to build with GCC-4.6+ -O2 -flto.
10563 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10565 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10567 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10568 Call minibuffer-inactive-mode.
10570 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
10572 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10573 Update dependencies.
10575 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10577 * data.c (init_data): Remove code for UTS, this system is not
10580 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10582 Don't force ./temacs to start in terminal mode.
10584 * frame.c (make_initial_frame): Initialize faces in all cases, not
10585 only when CANNOT_DUMP is defined.
10586 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10588 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10590 * dispnew.c (add_window_display_history): Use const for the string
10591 pointer. Remove declaration, not needed.
10593 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10595 Use 'inline', not 'INLINE'.
10596 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
10597 * alloc.c, fontset.c (INLINE): Remove.
10598 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10599 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10600 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10601 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10602 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10604 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10606 Make it possible to run ./temacs.
10608 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10609 syms_of_callproc does the same thing. Remove test for
10610 "initialized", do it in the caller.
10611 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10613 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10615 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10616 (read_minibuf): Use get_minibuffer.
10617 (syms_of_minibuf): Use DEFSYM.
10618 (Qmetadata): New var.
10619 * data.c (Qbuffer): Don't make it static.
10620 (syms_of_data): Use DEFSYM.
10622 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10624 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10625 (CCL_CODE_MIN): New macro.
10627 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10629 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10631 * eval.c (Qdebug): Now static.
10632 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10633 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10634 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10636 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
10638 * image.c: Various fixes to ImageMagick code comments.
10639 (Fimagemagick_types): Doc fix.
10641 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10643 Minor fixes prompted by GCC 4.6.0 warnings.
10645 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10647 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10648 (x_clipboard_manager_save_all): Move extern decl to ...
10649 * xterm.h: ... here, so that it can be checked for consistency.
10651 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
10653 * xselect.c (x_clipboard_manager_save_frame)
10654 (x_clipboard_manager_save_all): New functions.
10655 (Fx_clipboard_manager_save): Lisp function deleted.
10657 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10658 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10660 * xterm.h: Update prototype.
10662 2011-05-28 William Xu <william.xwl@gmail.com>
10664 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10665 exiting (Bug#8239).
10667 2011-05-28 Jim Meyering <meyering@redhat.com>
10669 Avoid a sign-extension bug in crypto_hash_function.
10670 * fns.c (to_uchar): Define.
10671 (crypto_hash_function): Use it to convert some newly-signed
10672 variables to unsigned, to avoid sign-extension bugs. For example,
10673 without this change, (md5 "truc") would evaluate to
10674 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10675 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
10676 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
10678 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10680 Integer overflow fixes.
10682 * dbusbind.c: Serial number integer overflow fixes.
10683 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
10684 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10685 to hold a serial number that is too large for a fixnum.
10686 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10687 Check for serial numbers out of range. Decode any serial number
10688 that was so large that it became a float. (Bug#8722)
10690 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10691 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10692 Use XFASTINT rather than XUINT when numbers are nonnegative.
10693 (xd_append_arg, Fdbus_method_return_internal):
10694 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10695 arguments, check that Lisp number is nonnegative, rather than
10696 silently wrapping negative numbers around. (Bug#8722)
10697 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
10700 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10702 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10704 ccl: Add integer overflow checks.
10705 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10706 (IN_INT_RANGE): New macros.
10707 (ccl_driver): Use them to check for integer overflow when
10708 decoding a CCL program. Many of the new checks are whether XINT (x)
10709 fits in int; it doesn't always, on 64-bit hosts. The new version
10710 doesn't catch all possible integer overflows, but it's an
10711 improvement. (Bug#8719)
10713 * alloc.c (make_event_array): Use XINT, not XUINT.
10714 There's no need for unsigned here.
10716 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10717 This follows up to the 2011-05-06 change that substituted uintptr_t
10718 for EMACS_INT. This case wasn't caught back then.
10720 Rework Fformat to avoid integer overflow issues.
10721 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10722 now (part of C89). Include <verify.h>.
10723 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10724 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10725 (Fformat): Avoid the prepass trying to compute sizes; it was only
10726 approximate and thus did not catch overflow reliably. Instead, walk
10727 through the format just once, formatting and computing sizes as we go,
10728 checking for integer overflow at every step, and allocating a larger
10729 buffer as needed. Keep track separately whether the format is
10730 multibyte. Keep only the most-recently calculated precision, rather
10731 than them all. Record whether each argument has been converted to
10732 string. Use EMACS_INT, not int, for byte and char and arg counts.
10733 Support field widths and precisions larger than INT_MAX. Avoid
10734 sprintf's undefined behavior with conversion specifications such as %#d
10735 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10736 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10737 formatting out-of-range floating point numbers with int
10738 formats. (Bug#8668)
10740 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10742 * data.c: Avoid integer truncation in expressions involving floats.
10743 * data.c: Include <intprops.h>.
10744 (arith_driver): When there's an integer overflow in an expression
10745 involving floating point, convert the integers to floating point
10746 so that the resulting value does not suffer from catastrophic
10747 integer truncation. For example, on a 64-bit host (* 4
10748 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10749 Do not rely on undefined behavior after integer overflow.
10751 merge count_size_as_multibyte, parse_str_to_multibyte
10752 * character.c, character.h (count_size_as_multibyte):
10753 Rename from parse_str_to_multibyte; all uses changed.
10754 Check for integer overflow.
10755 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10756 since it's now a duplicate of the other. This is more of
10757 a character than a buffer op, so better that it's in character.c.
10758 * fns.c, print.c: Adjust to above changes.
10760 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10762 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10764 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10766 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10767 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10768 (x_clipboard_manager_save): Now static.
10769 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10771 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10772 (crypto_hash_function): Now static.
10773 Fix pointer signedness problems. Avoid unnecessary initializations.
10775 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
10777 * termhooks.h (Vselection_alist): Make it terminal-local.
10779 * terminal.c (create_terminal): Initialize it.
10781 * xselect.c: Support for clipboard managers.
10782 (Vselection_alist): Move to termhooks.h as terminal-local var.
10783 (LOCAL_SELECTION): New macro.
10784 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10785 (symbol_to_x_atom): Remove gratuitous arg.
10786 (x_handle_selection_request, lisp_data_to_selection_data)
10787 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
10788 (x_own_selection, x_get_local_selection, x_convert_selection):
10789 New arg, specifying work frame. Use terminal-local Vselection_alist.
10790 (some_frame_on_display): Delete unused function.
10791 (Fx_own_selection_internal, Fx_get_selection_internal)
10792 (Fx_disown_selection_internal, Fx_selection_owner_p)
10793 (Fx_selection_exists_p): New optional frame arg.
10794 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10795 (x_handle_selection_clear): Don't treat other terminals with the
10796 same keyboard specially. Use the terminal-local Vselection_alist.
10797 (x_clear_frame_selections): Use Frun_hook_with_args.
10799 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10801 * xterm.h: Add support for those atoms.
10803 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
10805 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10806 (converted_selections, conversion_fail_tag): New global variables.
10807 (x_selection_request_lisp_error): Free the above.
10808 (x_get_local_selection): Remove unnecessary code.
10809 (x_reply_selection_request): Args changed; handle arbitrary array
10810 of converted selections stored in converted_selections.
10811 Separate the XChangeProperty and SelectionNotify steps.
10812 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10813 (x_convert_selection): New function.
10814 (x_handle_selection_event): Simplify.
10815 (x_get_foreign_selection): Don't ignore incoming requests while
10816 waiting for an answer; this will fail when we implement
10817 SAVE_TARGETS, and seems unnecessary anyway.
10818 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10819 (Vx_sent_selection_functions): Doc fix.
10821 2011-05-26 Leo Liu <sdl.web@gmail.com>
10823 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10825 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10827 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10829 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10830 for fringe update if it has periodic bitmap.
10831 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
10832 and fringe_bitmap_periodic_p.
10834 * fringe.c (get_fringe_bitmap_data): New function.
10835 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10836 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10837 row. Mark glyph row for fringe update if periodicity changed.
10839 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10840 for fringe update unless it has periodic bitmap.
10842 2011-05-25 Kenichi Handa <handa@m17n.org>
10844 * xdisp.c (get_next_display_element): Set correct it->face_id for
10845 a static composition.
10847 2011-05-24 Leo Liu <sdl.web@gmail.com>
10850 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10852 * fns.c (crypto_hash_function, Fsha1): New function.
10853 (Fmd5): Use crypto_hash_function.
10854 (syms_of_fns): Add Ssha1.
10856 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10858 * gnutls.c: Remove unused macros.
10859 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10860 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10861 Remove macros that are defined and never used.
10862 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10864 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
10866 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10867 (Fx_get_selection_internal): Minor cleanup.
10868 (Fx_own_selection_internal): Rename arguments for consistency with
10871 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10873 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10875 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
10877 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10879 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10881 * dispnew.c (scrolling_window): Don't exclude the case that the
10882 last enabled row in the desired matrix touches the bottom boundary.
10884 2011-05-21 Glenn Morris <rgm@gnu.org>
10886 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
10887 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10888 and add some more files.
10890 2011-05-20 Eli Zaretskii <eliz@gnu.org>
10892 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10893 report_file_error introduced by the change from 2011-05-07.
10895 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10897 * systime.h (Time): Define only if emacs is defined.
10898 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10899 where the include path doesn't have X11/X.h by default. See
10900 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10902 2011-05-20 Kenichi Handa <handa@m17n.org>
10904 * composite.c (find_automatic_composition): Fix previous change.
10906 2011-05-20 Glenn Morris <rgm@gnu.org>
10908 * lisp.mk: New file, split from Makefile.in.
10909 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10910 (shortlisp): Remove.
10911 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10913 2011-05-19 Glenn Morris <rgm@gnu.org>
10915 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10916 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10917 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10918 (lisp): Set the order to that of loadup.el.
10919 (shortlisp): Make it a copy of $lisp.
10920 (SOME_MACHINE_LISP): Remove.
10921 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10922 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10924 2011-05-18 Kenichi Handa <handa@m17n.org>
10926 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10927 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10928 (find_automatic_composition): Mostly rewrite for efficiency.
10930 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
10932 * makefile.w32-in: Update dependencies.
10934 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10936 * menu.c: Include limits.h (fixes the MS-Windows build broken by
10937 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
10939 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
10941 Fix some integer overflow issues, such as string length overflow.
10943 * insdel.c (count_size_as_multibyte): Check for string overflow.
10945 * character.c (lisp_string_width): Check for string overflow.
10946 Use EMACS_INT, not int, for string indexes and lengths; in
10947 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10948 the resulting string length overflows an EMACS_INT; instead,
10949 report a string overflow if no precision given. When checking for
10950 precision exhaustion, use a check that cannot possibly have
10951 integer overflow. (Bug#8675)
10952 * character.h (lisp_string_width): Adjust to new signature.
10954 * alloc.c (string_overflow): New function.
10955 (Fmake_string): Use it. This doesn't change behavior, but saves
10956 a few bytes and will simplify future changes.
10957 * character.c (string_escape_byte8): Likewise.
10958 * lisp.h (string_overflow): New decl.
10960 Fixups, following up to the user-interface timestamp change.
10961 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10962 for UI timestamps, instead of unsigned long.
10963 * msdos.c (mouse_get_pos): Likewise.
10964 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
10965 * w32gui.h (Time): Define by including "systime.h" rather than by
10966 declaring it ourselves. (Bug#8664)
10968 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10969 * image.c (clear_image_cache): Likewise.
10971 * term.c (term_mouse_position): Don't assume time_t wraparound.
10973 Be more systematic about user-interface timestamps.
10974 Before, the code sometimes used 'Time', sometimes 'unsigned long',
10975 and sometimes 'EMACS_UINT', to represent these timestamps.
10976 This change causes it to use 'Time' uniformly, as that's what X uses.
10977 This makes the code easier to follow, and makes it easier to catch
10978 integer overflow bugs such as Bug#8664.
10979 * frame.c (Fmouse_position, Fmouse_pixel_position):
10980 Use Time, not unsigned long, for user-interface timestamps.
10981 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10982 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10983 * keyboard.h (last_event_timestamp): Likewise.
10984 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10985 * menu.h (xmenu_show): Likewise.
10986 * term.c (term_mouse_position): Likewise.
10987 * termhooks.h (struct input_event.timestamp): Likewise.
10988 (struct terminal.mouse_position_hook): Likewise.
10989 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10990 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10991 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10992 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10993 what it was before.
10994 * menu.h, termhooks.h: Include "systime.h", for Time.
10996 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10997 Don't assume that the difference between two unsigned long values
10998 can fit into an integer. At this point, we know button_down_time
10999 <= event->timestamp, so the difference must be nonnegative, so
11000 there's no need to cast the result if double-click-time is
11001 nonnegative, as it should be; check that it's nonnegative, just in
11002 case. This bug is triggered when events are more than 2**31 ms
11003 apart (about 25 days). (Bug#8664)
11005 * xselect.c (last_event_timestamp): Remove duplicate decl.
11006 (x_own_selection): Remove needless cast to unsigned long.
11008 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11009 that always fit in int. Use a sentinel instead of a counter, to
11010 avoid a temp and to allay GCC's concerns about possible int overflow.
11011 * frame.h (struct frame): Use int for menu_bar_items_used
11012 instead of EMACS_INT, since it always fits in int.
11014 * menu.c (grow_menu_items): Check for int overflow.
11016 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11018 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11019 Before, the code was not consistent. These values cannot exceed
11020 2**31 - 1 so there's no need to make them unsigned.
11021 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11022 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11023 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11025 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11027 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11028 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11029 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11030 presumably because the widths might not match.
11032 * window.c (size_window): Avoid needless test at loop start.
11034 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11036 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11038 2011-05-12 Drew Adams <drew.adams@oracle.com>
11040 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11042 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11044 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11045 `width' to `bar_area_x' and `bar_area_width', respectively.
11046 (x_scroll_run): Take account of fringe background extension.
11048 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11049 Rename local vars `left' and `width' to `bar_area_x' and
11050 `bar_area_width', respectively.
11051 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11052 background extension.
11054 2011-05-10 Jim Meyering <meyering@redhat.com>
11056 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11058 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
11060 * image.c (Finit_image_library): Return t for built-in image types,
11061 like pbm and xbm. (Bug#8640)
11063 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11065 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11067 2011-05-07 Eli Zaretskii <eliz@gnu.org>
11069 * w32console.c (Fset_screen_color): Doc fix.
11070 (Fget_screen_color): New function.
11071 (syms_of_ntterm): Defsubr it.
11073 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11074 unlink the temporary file if Fcall_process didn't create it in the
11076 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11077 child process will be redirected to a file specified with `:file'.
11078 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11079 cue to call_process_cleanup not to close that handle.
11081 2011-05-07 Ben Key <bkey76@gmail.com>
11083 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11084 one of two shell specific rules, either bootstrap-temacs-CMD or
11085 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11086 to the previous implementation of the bootstrap-temacs rule.
11087 The bootstrap-temacs-CMD rule is similar to the previous
11088 implementation of the bootstrap-temacs rule except that it
11089 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11092 These changes, along with some changes to nt/configure.bat,
11093 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11094 earlier fix to add support for --cflags and --ldflags options
11095 that include quotes so that it works whether make uses cmd or
11098 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
11100 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11101 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11103 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11104 a string. Handle both cases.
11105 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11106 (Fdbus_register_method): Use Qinvalid_function.
11108 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
11110 * makefile.w32-in: Update dependencies.
11111 (LISP_H): Add inttypes.h and stdin.h.
11112 (PROCESS_H): Add unistd.h.
11114 2011-05-06 Eli Zaretskii <eliz@gnu.org>
11116 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11117 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11119 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
11121 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11123 * term.c (vfatal): Remove stray call to va_end.
11124 It's not needed and the C Standard doesn't allow it here anyway.
11126 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11127 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11129 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11132 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11134 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11136 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11138 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11140 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11142 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11143 * charset.c (Fdefine_charset_internal): Don't initialize
11144 charset.code_space[15]. The value was garbage, on hosts with
11145 32-bit int (Bug#8600).
11147 * lread.c (read_integer): Be more consistent with string-to-number.
11148 Use string_to_number to do the actual conversion; this avoids
11149 rounding errors and fixes some other screwups. Without this fix,
11150 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11151 (digit_to_number): Move earlier, for benefit of read_integer.
11152 Return -1 if the digit is out of range for the base, -2 if it is
11153 not a digit in any supported base. (Bug#8602)
11155 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11157 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11158 to match comment at start of function. This also removes a
11159 GCC warning about overflow in a 32+64-bit port.
11161 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11163 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11164 Reported by Stefan Monnier in
11165 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
11166 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11167 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
11169 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11170 (EMACS_UINTPTR): Likewise, with uintptr_t.
11172 * lisp.h: Prefer 64-bit EMACS_INT if available.
11173 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11174 on 32-bit hosts that have 64-bit int, so that they can access
11176 However, temporarily disable this change unless the temporary
11177 symbol WIDE_EMACS_INT is defined.
11179 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11181 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11182 This removes an assumption that EMACS_INT and long are the same
11183 width as pointers. The assumption is true for Emacs porting targets
11184 now, but we want to make other targets possible.
11185 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11186 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11187 In the rest of the code, change types of integers that hold casted
11188 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11189 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11190 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11191 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11192 No need to cast type when ORing.
11193 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11194 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11195 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11196 assume EMACS_INT is the same width as char *.
11197 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11198 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11199 Remove no-longer-needed casts.
11200 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11201 (xg_tool_bar_help_callback, xg_make_tool_item):
11202 Use EMACS_INTPTR to hold an integer
11203 that will be cast to void *; this can avoid a GCC warning
11204 if EMACS_INT is not the same width as void *.
11205 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11206 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11207 (current_message_1, set_message_1):
11208 Use a local to convert to proper width without a cast.
11209 * xmenu.c (dialog_selection_callback): Likewise.
11211 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11212 Also, don't assume VALBITS / RAND_BITS is less than 5,
11213 and don't rely on undefined behavior when shifting a 1 left into
11215 * lisp.h (get_random): Change signature to match.
11217 * lread.c (hash_string): Use size_t, not int, for hash computation.
11218 Normally we prefer signed values; but hashing is special, because
11219 it's better to use unsigned division on hash table sizes so that
11220 the remainder is nonnegative. Also, size_t is the natural width
11221 for hashing into memory. The previous code used 'int', which doesn't
11222 retain enough info to hash well into very large tables.
11223 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11225 * dbusbind.c: Don't possibly lose pointer info when converting.
11226 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11227 Use XPNTR rather than XHASH, so that the high-order bits of
11228 the pointer aren't lost when converting through void *.
11230 * eval.c (Fautoload): Don't double-shift a pointer.
11232 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11234 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
11236 * gnutls.c (DEF_GNUTLS_FN):
11237 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11239 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11241 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11244 2011-05-05 Eli Zaretskii <eliz@gnu.org>
11246 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11247 New version that can reserve upto 2GB of heap space.
11249 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
11251 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11253 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11255 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11256 `gnutls_certificate_set_x509_key_file'.
11258 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
11260 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11261 Update dependencies.
11263 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11265 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11266 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11267 Remove unused parameter `fildes'.
11268 * process.c (read_process_output, send_process): Don't pass it.
11270 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11272 Fix previous change: the library cache is defined in w32.c.
11273 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11274 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11276 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11278 Implement dynamic loading of GnuTLS on Windows.
11280 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11281 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11282 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11285 * gnutls.c (Qgnutls_dll): Define.
11286 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11287 (gnutls_*): Declare function pointers.
11288 (init_gnutls_functions): New function to initialize function pointers.
11289 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11290 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11291 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11292 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11293 (emacs_gnutls_write, emacs_gnutls_read)
11294 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11295 (Fgnutls_available_p): New function.
11296 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11297 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11298 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11300 * image.c: Include w32.h.
11301 (Vimage_type_cache): Delete.
11302 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11303 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11304 (w32_delayed_load): Move to w32.c.
11306 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11308 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11309 (w32_delayed_load): Move from image.c. When loading a library, record
11310 its filename in the :loaded-from property of the library id.
11311 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11312 Initialize and staticpro them.
11313 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11315 * process.c: Include lisp.h before w32.h, not after.
11316 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11317 instead of gnutls_record_check_pending.
11319 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11321 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11323 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11324 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11327 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11329 * xterm.c (x_set_frame_alpha): Do not set property on anything
11330 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11332 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11334 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11336 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11338 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11339 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11340 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11341 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11342 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11343 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11344 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11345 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11346 (Qgnutls_bootprop_callbacks_verify): Make static.
11348 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11350 * callproc.c: Indentation fixup.
11352 * sysdep.c (wait_for_termination_1): Make static.
11353 (wait_for_termination, interruptible_wait_for_termination):
11354 Move after wait_for_termination_1.
11356 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11358 * sysdep.c (interruptible_wait_for_termination): New function
11359 which is like wait_for_termination, but allows keyboard
11362 * callproc.c (Fcall_process): Add (:file "file") as an option for
11364 (Fcall_process_region): Ditto.
11366 2011-04-30 Eli Zaretskii <eliz@gnu.org>
11368 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11369 rather than `XVECTOR (FOO)->size'.
11371 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11372 inttypes.h, as a gnulib replacement is used if it not available in
11375 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11377 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11378 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11379 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11381 * coding.c (coding_alloc_by_realloc): Error out if destination
11382 will grow beyond MOST_POSITIVE_FIXNUM.
11383 (decode_coding_emacs_mule): Abort if there isn't enough place in
11384 charbuf for the composition carryover bytes. Reserve an extra
11385 space for up to 2 characters produced in a loop.
11386 (decode_coding_iso_2022): Abort if there isn't enough place in
11387 charbuf for the composition carryover bytes.
11389 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11391 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11392 aborting when %lld or %lll format is passed.
11393 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11394 %llo or %llx format is passed. (Bug#8545)
11396 * window.c (window_scroll_line_based): Use a marker instead of
11397 simple variables to record original value of point. (Bug#7952)
11399 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11400 produced by %s or %c overflows available buffer space. (Bug#8545)
11402 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11404 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
11405 (SIZE_MAX): Move defn after all includes, as they might #define it.
11407 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11409 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11411 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11413 * keyboard.c (Qdelayed_warnings_hook): Define.
11414 (command_loop_1): Run `delayed-warnings-hook'
11415 if Vdelayed_warnings_list is non-nil.
11416 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11417 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11419 2011-04-28 Eli Zaretskii <eliz@gnu.org>
11421 * doprnt.c (doprnt): Don't return value smaller than the buffer
11422 size if the message was truncated. (Bug#8545).
11424 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11426 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11427 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11429 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11431 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11433 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
11435 * makefile.w32-in: Update dependencies.
11437 2011-04-27 Eli Zaretskii <eliz@gnu.org>
11439 Improve `doprnt' and its usage. (Bug#8545)
11440 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11441 `format_end'. Remove support for %l as a conversion specifier.
11442 Don't use xrealloc. Improve diagnostics when the %l size modifier
11443 is used. Update the commentary.
11445 * eval.c (verror): Simplify calculation of size_t.
11447 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11450 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11452 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11455 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11457 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11458 This makes this file independent of the recent pseudovector change.
11460 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
11462 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11464 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
11465 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
11466 Remove unused local.
11467 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
11469 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
11470 GCC 4.6.0 optimizes based on type-based alias analysis.
11471 For example, if b is of type struct buffer * and v of type struct
11472 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11473 != &v->size, and therefore "v->size = 1; b->size = 2; return
11474 v->size;" must therefore return 1. This assumption is incorrect
11475 for Emacs, since it type-puns struct Lisp_Vector * with many other
11476 types. To fix this problem, this patch adds a new type struct
11477 vectorlike_header that documents the constraints on layout of vectors
11478 and pseudovectors, and helps optimizing compilers not get fooled
11479 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11480 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
11481 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11483 (XSETPVECTYPE): Rewrite in terms of new macro.
11484 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11485 This is a bit clearer, and further avoids the possibility of
11486 undesirable aliasing.
11487 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
11488 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
11489 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11490 since Lisp_Subr is a special case (no "next" field).
11491 (ASIZE): Now uses header.size rather than size.
11492 All previous uses of XVECTOR (foo)->size replaced to use this macro,
11493 to avoid the hassle of writing XVECTOR (foo)->header.size.
11494 (struct vectorlike_header): New type.
11495 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11496 object, to help avoid aliasing.
11497 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11498 (SUBRP): Likewise, since Lisp_Subr is a special case.
11499 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11500 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11501 (struct Lisp_Hash_Table): Combine first two members into a single
11502 struct vectorlike_header member. All uses of "size" and "next" members
11503 changed to be "header.size" and "header.next".
11504 * buffer.h (struct buffer): Likewise.
11505 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11506 * frame.h (struct frame): Likewise.
11507 * process.h (struct Lisp_Process): Likewise.
11508 * termhooks.h (struct terminal): Likewise.
11509 * window.c (struct save_window_data, struct saved_window): Likewise.
11510 * window.h (struct window): Likewise.
11511 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11512 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11513 * buffer.c (init_buffer_once): Likewise.
11514 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11516 * process.c (Fformat_network_address): Use local var for size,
11519 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11521 Make the Lisp reader and string-to-float more consistent (Bug#8525)
11522 * data.c (atof): Remove decl; no longer used or needed.
11523 (digit_to_number): Move to lread.c.
11524 (Fstring_to_number): Use new string_to_number function, to be
11525 consistent with how the Lisp reader treats infinities and NaNs.
11526 Do not assume that floating-point numbers represent EMACS_INT
11527 without losing information; this is not true on most 64-bit hosts.
11528 Avoid double-rounding errors, by insisting on integers when
11529 parsing non-base-10 numbers, as the documentation specifies.
11530 * lisp.h (string_to_number): New decl, replacing ...
11531 (isfloat_string): Remove.
11532 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
11533 (read1): Do not accept +. and -. as integers; this
11534 appears to have been a coding error. Similarly, do not accept
11535 strings like +-1e0 as floating point numbers. Do not report
11536 overflow for integer overflows unless the base is not 10 which
11537 means we have no simple and reliable way to continue.
11538 Break out the floating-point parsing into a new
11539 function string_to_number, so that Fstring_to_number parses
11540 floating point numbers consistently with the Lisp reader.
11541 (digit_to_number): Move here from data.c. Make it static inline.
11542 (E_CHAR, EXP_INT): Remove, replacing with ...
11543 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11544 (string_to_number): New function, replacing isfloat_string.
11545 This function checks for valid syntax and produces the resulting
11546 Lisp float number too. Rework it so that string-to-number
11547 no longer mishandles examples like "1.0e+". Use strtoumax,
11548 so that overflow for non-base-10 numbers is reported only when
11549 there's no portable and simple way to convert to floating point.
11551 * textprop.c (set_text_properties_1): Rewrite for clarity,
11552 and to avoid GCC warning about integer overflow.
11554 * intervals.h (struct interval): Use EMACS_INT for members
11555 where EMACS_UINT might cause problems. See
11556 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11557 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11558 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11560 (offset_intervals): Tell GCC not to worry about length overflow
11561 when negating a negative length.
11563 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11564 (overrun_check_free): Likewise.
11566 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11567 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11570 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11571 (gnutls_make_error): Rename local to avoid shadowing.
11572 (gnutls_emacs_global_deinit): ifdef out; not used.
11573 (Fgnutls_boot): Use const for pointer to readonly storage.
11574 Comment out unused local. Fix pointer signedness problems.
11576 * lread.c (openp): Don't stuff size_t into an 'int'.
11577 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11578 about possible signed overflow.
11580 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11581 (GDK_KEY_g): Don't define if already defined.
11582 (xg_prepare_tooltip): Avoid pointer signedness problem.
11583 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11585 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11586 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11588 * xfns.c (Fx_window_property): Simplify a bit,
11589 to make a bit faster and to avoid GCC 4.6.0 warning.
11590 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11592 * fns.c (internal_equal): Don't assume size_t fits in int.
11594 * alloc.c (compact_small_strings): Tighten assertion a little.
11596 Replace pEd with more-general pI, and fix some printf arg casts.
11597 * lisp.h (pI): New macro, generalizing old pEd macro to other
11598 conversion specifiers. For example, use "...%"pI"d..." rather
11599 than "...%"pEd"...".
11600 (pEd): Remove. All uses replaced with similar uses of pI.
11601 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
11602 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11603 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11604 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11605 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11606 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11607 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11609 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11610 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11611 * print.c (safe_debug_print, print_object): Likewise.
11612 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11614 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11615 avoiding the 0 flag, which is not portable.
11616 * process.c (Fmake_network_process): Use pI to avoid cast.
11617 * region-cache.c (pp_cache): Likewise.
11618 * xdisp.c (decode_mode_spec): Likewise.
11619 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11620 behavior on 64-bit hosts with printf arg.
11621 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
11622 (x_stop_queuing_selection_requests): Likewise.
11623 (x_get_window_property): Don't truncate byte count to an 'int'
11626 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11627 here, since it parses constructs like leading '-' and spaces,
11628 which are not wanted; and it overflows with large numbers.
11629 Instead, simply match F[0-9]+, which is what is wanted anyway.
11631 * alloc.c: Remove unportable assumptions about struct layout.
11632 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11633 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11634 (allocate_vectorlike, make_pure_vector): Use the new macros,
11635 plus offsetof, to remove unportable assumptions about struct layout.
11636 These assumptions hold on all porting targets that I know of, but
11637 they are not guaranteed, they're easy to remove, and removing them
11638 makes further changes easier.
11640 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11641 This doesn't fix a bug but makes the code clearer.
11642 (string_overrun_cookie): Now const. Use initializers that
11643 don't formally overflow signed char, to avoid warnings.
11644 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11645 can cause Emacs to crash when string overrun checking is enabled.
11646 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11647 multiple of sizeof (EMACS_INT); it need not be, if
11648 alignof(EMACS_INT) < sizeof (EMACS_INT).
11649 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
11651 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
11653 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11655 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11657 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
11658 supposed to be handshaking. (Bug#8556)
11659 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11661 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
11663 * lisp.h (Qdebug): List symbol.
11664 * eval.c (Qdebug): Restore global linkage.
11665 * keyboard.c (debug-on-event): New variable.
11666 (handle_user_signal): Break into debugger when debug-on-event
11667 matches the current signal symbol.
11669 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11671 * alloc.c (check_sblock, check_string_bytes)
11672 (check_string_free_list): Convert to standard C.
11674 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11676 * w32.c (emacs_gnutls_push): Fix typo.
11678 2011-04-25 Eli Zaretskii <eliz@gnu.org>
11680 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11681 "cast to pointer from integer of different size".
11683 Improve doprnt and its use in verror. (Bug#8545)
11684 * doprnt.c (doprnt): Document the set of format control sequences
11685 supported by the function. Use SAFE_ALLOCA instead of always
11688 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11689 is one byte too soon. Don't use xrealloc; instead xfree and
11692 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11694 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11697 * gnutls.c: Renamed global_initialized to
11698 gnutls_global_initialized. Added internals for the
11699 :verify-hostname-error, :verify-error, and :verify-flags
11700 parameters of `gnutls-boot' and documented those parameters in the
11701 docstring. Start callback support.
11702 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11703 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11704 on error. Return error code.
11705 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11706 (emacs_gnutls_read): Likewise.
11707 (Fgnutls_boot): Return handshake error code.
11708 (emacs_gnutls_handle_error): New function.
11709 (wsaerror_to_errno): Likewise.
11711 * w32.h (emacs_gnutls_pull): Add prototype.
11712 (emacs_gnutls_push): Likewise.
11714 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11715 (emacs_gnutls_push): Likewise.
11717 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11719 * process.c (wait_reading_process_output): Check if GnuTLS
11720 buffered some data internally if no FDs are set for TLS
11723 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11724 (LIBS): Link to USER_LIBS.
11725 ($(BLD)/gnutls.$(0)): New target.
11727 2011-04-24 Eli Zaretskii <eliz@gnu.org>
11729 * xdisp.c (handle_single_display_spec): Rename the
11730 display_replaced_before_p argument into display_replaced_p, to
11731 make it consistent with the commentary. Fix typos in the
11734 * textprop.c (syms_of_textprop): Remove dead code.
11735 (copy_text_properties): Delete obsolete commentary about an
11736 interface that was deleted long ago. Fix typos in the description
11739 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11740 to changes in oldXMenu/XMenu.h from 2011-04-16.
11741 <menu_help_message, prev_menu_help_message>: Constify.
11742 (IT_menu_make_room): menu->help_text is now `const char **';
11745 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11746 to changes in oldXMenu/XMenu.h from 2011-04-16.
11747 (struct XMenu): Declare `help_text' `const char **'.
11749 * xfaces.c <Qunspecified>: Make extern again.
11751 * syntax.c: Include sys/types.h before including regex.h, as
11754 * doc.c (get_doc_string): Improve the format passed to `error'.
11756 * doprnt.c (doprnt): Improve commentary.
11758 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11760 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11763 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11764 changes in globals.h immediately force recompilation.
11765 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11766 $(CURDIR)/s/ms-w32.h.
11767 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
11769 * character.c (Fchar_direction): Function deleted.
11770 (syms_of_character): Don't defsubr it.
11771 <char-direction-table>: Deleted.
11773 2011-04-23 Eli Zaretskii <eliz@gnu.org>
11775 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11776 * doprnt.c: Include limits.h.
11777 (SIZE_MAX): New macro.
11778 (doprnt): Return a size_t value. 2nd arg is now size_t.
11779 Many local variables are now size_t instead of int or unsigned.
11780 Improve overflow protection. Support `l' modifier for integer
11781 conversions. Support %l conversion. Don't assume an EMACS_INT
11782 argument for integer conversions and for %c.
11784 * lisp.h (doprnt): Restore prototype.
11786 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11787 $(SRC)/character.h.
11789 * Makefile.in (base_obj): Add back doprnt.o.
11791 * deps.mk (doprnt.o): Add back prerequisites.
11792 (callint.o): Depend on character.h.
11794 * eval.c (internal_lisp_condition_case): Include the handler
11795 representation in the error message.
11796 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11797 when breaking from the loop.
11799 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11801 * callint.c (Fcall_interactively): When displaying error message
11802 about invalid control letter, pass the character's codepoint, not
11803 a pointer to its multibyte form. Improve display of the character
11804 in octal and display also its hex code.
11806 * character.c (char_string): Use %x to display the (unsigned)
11807 codepoint of an invalid character, to avoid displaying a bogus
11810 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11811 `error', not SYMBOL_NAME itself.
11813 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11814 character arguments to `error'.
11816 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11817 to `error' in error message about FINAL_CHAR argument. Make sure
11818 FINAL_CHAR is a character, and use %c when it is passed as
11819 argument to `error'.
11821 2011-04-23 Eli Zaretskii <eliz@gnu.org>
11823 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11825 * w32.c: Include <time.h>.
11826 (sys_localtime): New function.
11828 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
11830 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11832 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
11834 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
11836 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11837 zombies (Bug#8467).
11839 2011-04-19 Eli Zaretskii <eliz@gnu.org>
11841 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11842 gl_state.e_property when gl_state.object is Qt.
11844 * insdel.c (make_gap_larger): Remove limitation of buffer size
11847 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
11849 * xdisp.c (lookup_glyphless_char_display)
11850 (produce_glyphless_glyph): Handle cons cell entry in
11851 glyphless-char-display.
11852 (Vglyphless_char_display): Document it.
11854 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11855 glyphless-char-display.
11857 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
11859 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11861 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11863 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11864 definition for no-X builds.
11866 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
11868 Static checks with GCC 4.6.0 and non-default toolkits.
11870 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11872 * process.c (keyboard_bit_set): Define only if SIGIO.
11873 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11874 (send_process): Repair possible setjmp clobbering.
11876 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11878 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11880 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11882 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11883 Define only if needed.
11885 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11886 by pacifying GCC about it. Maybe it's time to retire it?
11887 * xfaces.c (USG, __TIMEVAL__): Likewise.
11889 * dispextern.h (struct redisplay_interface): Rename param
11890 to avoid shadowing.
11891 * termhooks.h (struct terminal): Likewise.
11892 * xterm.c (xembed_send_message): Likewise.
11894 * insdel.c (make_gap_smaller): Define only if
11895 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11897 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11900 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11901 so that we aren't warned about unused symbols.
11903 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11905 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
11907 * xfns.c (x_real_positions): Mark locals as initialized.
11909 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11911 * xterm.c: Fix problems found by static analysis with other toolkits.
11912 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
11913 (x_dispatch_event): Declare static if USE_GTK, and
11914 define if USE_GTK || USE_X_TOOLKIT.
11915 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
11916 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
11917 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11918 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
11920 * xmenu.c (menu_help_callback): Pointer type fixes.
11921 Use const pointers when pointing at readonly data. Avoid pointer
11922 signedness clashes.
11923 (FALSE): Remove unused macro.
11924 (update_frame_menubar): Remove unused decl.
11926 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11928 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11929 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11930 (single_menu_item): Rename local to avoid shadowing.
11932 * keyboard.c (make_lispy_event): Remove unused local var.
11934 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11935 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11937 * bitmaps: Change bitmaps from unsigned char back to the X11
11938 compatible char. Avoid the old compiler warnings about
11939 out-of-range initializers by using, for example, '\xab' rather
11942 * xgselect.c (xgselect_initialize): Check vs interface
11943 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11945 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11947 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11948 to read-only memory.
11950 * fns.c (vector): Remove; this old hack is no longer needed.
11952 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
11954 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
11956 * xrdb.c (x_load_resources): Omit unused local.
11958 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
11959 (x_window): Rename locals to avoid shadowing.
11960 (USG): Use the kludged USG macro, to pacify gcc.
11962 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
11963 (x_term_init): Remove local to avoid shadowing.
11965 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
11967 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11968 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11970 2011-04-16 Eli Zaretskii <eliz@gnu.org>
11972 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11974 Fix regex.c, syntax.c and friends for buffers > 2GB.
11975 * syntax.h (struct gl_state_s): Declare character position members
11978 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11980 * textprop.c (verify_interval_modification, interval_of):
11981 Declare arguments EMACS_INT.
11983 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11986 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11988 * indent.c (Fvertical_motion): Local variable it_start is now
11991 * regex.c (re_match, re_match_2, re_match_2_internal)
11992 (bcmp_translate, regcomp, regexec, print_double_string)
11993 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11994 (re_compile_pattern, re_exec): Declare arguments and local
11995 variables `size_t' and `ssize_t' and return values `regoff_t', as
11997 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11998 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11999 <compile_stack_type>: `size' and `avail' are now `size_t'.
12001 * regex.h <regoff_t>: Use ssize_t, not int.
12002 (re_search, re_search_2, re_match, re_match_2): Arguments that
12003 specify buffer/string position and length are now ssize_t and
12004 size_t. Return type is regoff_t.
12006 2011-04-16 Ben Key <bkey76@gmail.com>
12008 * nsfont.m: Fixed bugs in ns_get_family and
12009 ns_descriptor_to_entity that were caused by using free to
12010 deallocate memory blocks that were allocated by xmalloc (via
12011 xstrdup). This caused Emacs to crash when compiled with
12012 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12013 --enable-checking=xmallocoverrun). xfree is now used to
12014 deallocate these memory blocks.
12016 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
12018 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12020 emacs_write: Accept and return EMACS_INT for sizes.
12021 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12023 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12024 Accept and return EMACS_INT.
12025 (emacs_gnutls_write): Return the number of bytes written on
12027 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
12028 (emacs_read, emacs_write): Remove check for negative size, as the
12029 Emacs source code has been audited now.
12030 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12031 (emacs_read, emacs_write): Use it.
12032 * process.c (send_process): Adjust to the new signatures of
12033 emacs_write and emacs_gnutls_write. Do not attempt to store
12034 a byte offset into an 'int'; it might overflow.
12035 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
12037 * sound.c: Don't assume sizes fit in 'int'.
12038 (struct sound_device.period_size, alsa_period_size):
12039 Return EMACS_INT, not int.
12040 (struct sound_device.write, vox_write, alsa_write):
12041 Accept EMACS_INT, not int.
12042 (wav_play, au_play): Use EMACS_INT to store sizes and to
12043 record read return values.
12045 2011-04-15 Ben Key <bkey76@gmail.com>
12047 * keyboard.c (Qundefined): Don't declare static since it is used
12049 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12050 static since they are used in nsfont.m.
12052 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12054 * process.c (Qprocessp): Don't declare static.
12055 * lisp.h (Qprocessp): Declare again.
12057 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
12059 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12061 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12063 Improve C-level modularity by making more things 'static'.
12065 Don't publish debugger-only interfaces to other modules.
12066 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12067 (verify_bytepos, count_markers): Move decls to the only modules
12069 * region-cache.h (pp_cache): Likewise.
12070 * window.h (check_all_windows): Likewise.
12071 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12073 * sysdep.c (croak): Now static, if
12074 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12075 * syssignal.h (croak): Declare only if not static.
12077 * alloc.c (refill_memory_reserve): Now static if
12078 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12079 * lisp.h (refill_memory_reserve): Declare only if not static.
12081 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12082 Define only if USE_LUCID.
12084 * xrdb.c (x_customization_string, x_rm_string): Now static.
12086 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12087 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12089 * xdisp.c (draw_row_with_mouse_face): Now static.
12090 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12092 * window.h (check_all_windows): Mark externally visible.
12094 * window.c (window_deletion_count): Now static.
12096 * undo.c: Make symbols static if they're not exported.
12097 (last_undo_buffer, last_boundary_position, pending_boundary):
12100 * textprop.c (interval_insert_behind_hooks): Now static.
12101 (interval_insert_in_front_hooks): Likewise.
12103 * term.c: Make symbols static if they're not exported.
12104 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12105 (max_frame_lines, tty_set_terminal_modes):
12106 (tty_reset_terminal_modes, tty_turn_off_highlight):
12107 (get_tty_terminal): Now static.
12108 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12109 * termhooks.h (term_mouse_moveto): Do not declare if
12110 HAVE_WINDOW_SYSTEM.
12111 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12112 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12114 * sysdep.c: Make symbols static if they're not exported.
12115 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12117 (sigprocmask_set, full_mask): Remove; unused.
12118 (wait_debugging): Mark as visible.
12119 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12120 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12122 * syntax.c (syntax_temp): Define only if !__GNUC__.
12124 * sound.c (current_sound_device, current_sound): Now static.
12126 * search.c (searchbufs, searchbuf_head): Now static.
12128 * scroll.c (scroll_cost): Remove; unused.
12129 * dispextern.h (scroll_cost): Remove decl.
12131 * region-cache.h (pp_cache): Mark as externally visible.
12133 * process.c: Make symbols static if they're not exported.
12134 (process_tick, update_tick, create_process, chan_process):
12135 (Vprocess_alist, proc_buffered_char, datagram_access):
12136 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12137 (deactivate_process): Mark defn as static, as well as decl.
12138 * lisp.h (create_process): Remove decl.
12139 * process.h (chan_process, Vprocess_alist): Remove decls.
12141 * print.c: Make symbols static if they're not exported.
12142 (print_depth, new_backquote_output, being_printed, print_buffer):
12143 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12144 (print_interval, print_number_index, initial_stderr_stream):
12146 * lisp.h (Fprinc): Remove decl.
12147 (debug_output_compilation_hack): Mark as externally visible.
12149 * sysdep.c (croak): Move decl from here to syssignal.h.
12150 * syssignal.h (croak): Put it here, so the API can be checked when
12151 'croak' is called from dissociate_if_controlling_tty.
12153 * minibuf.c: Make symbols static if they're not exported.
12154 (minibuf_save_list, choose_minibuf_frame): Now static.
12155 * lisp.h (choose_minibuf_frame): Remove decl.
12157 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12159 * lread.c: Make symbols static if they're not exported.
12160 (read_objects, initial_obarray, oblookup_last_bucket_number):
12162 (make_symbol): Remove; unused.
12163 * lisp.h (initial_obarray, make_symbol): Remove decls.
12165 * keyboard.c: Make symbols static if they're not exported.
12166 (single_kboard, recent_keys_index, total_keys, recent_keys):
12167 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12168 (this_single_command_key_start, echoing, last_auto_save):
12169 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12170 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12171 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12172 (Vlispy_mouse_stem, double_click_count):
12174 (force_auto_save_soon): Define only if SIGDANGER.
12175 (ignore_mouse_drag_p): Now static if
12176 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12177 (print_help): Remove; unused.
12178 (stop_character, last_timer_event): Mark as externally visible.
12179 * keyboard.h (ignore_mouse_drag_p): Declare only if
12180 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12181 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12182 * lisp.h (echoing): Remove decl.
12183 (force_auto_save_soon): Declare only if SIGDANGER.
12184 * xdisp.c (redisplay_window): Simplify code, to make it more
12185 obvious that ignore_mouse_drag_p is not accessed if !defined
12186 USE_GTK && !defined HAVE_NS.
12188 * intervals.c: Make symbols static if they're not exported.
12189 (merge_properties_sticky, merge_interval_right, delete_interval):
12191 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12193 * insdel.c: Make symbols static if they're not exported.
12194 However, leave prepare_to_modify_buffer alone. It's never
12195 called from outside this function, but that appears to be a bug.
12196 (combine_after_change_list, combine_after_change_buffer):
12197 (adjust_after_replace, signal_before_change): Now static.
12198 (adjust_after_replace_noundo): Remove; unused.
12199 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
12200 (signal_before_change): Remove decls.
12202 * indent.c (val_compute_motion, val_vmotion): Now static.
12204 * image.c: Make symbols static if they're not exported.
12205 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12207 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12208 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12210 * fringe.c (standard_bitmaps): Now static.
12211 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12213 * frame.c: Make symbols static if they're not exported.
12214 (x_report_frame_params, make_terminal_frame): Now static.
12215 (get_frame_param): Now static, unless HAVE_NS.
12216 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12217 (x_get_resource_string): Remove; not used.
12218 * frame.h (make_terminal_frame, x_report_frame_params):
12219 (x_get_resource_string); Remove decls.
12220 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12221 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12223 * font.c, fontset.c: Make symbols static if they're not exported.
12224 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12225 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12226 * font.c (font_close_object): Now static.
12227 * font.h (font_close_object): Remove.
12228 * fontset.c (FONTSET_OBJLIST): Remove.
12229 (free_realized_fontset) #if-0 the body, which does nothing.
12230 (face_suitable_for_char_p): #if-0, as it's never called.
12231 * fontset.h (face_suitable_for_char_p): Remove decl.
12232 * xfaces.c (face_at_string_position):
12233 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
12234 since 0 is always ASCII.
12236 * fns.c (weak_hash_tables): Now static.
12238 * fileio.c: Make symbols static if they're not exported.
12239 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12240 (Vwrite_region_annotation_buffers): Now static.
12242 * eval.c: Make symbols static if they're not exported.
12243 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12244 * lisp.h (backtrace_list): Remove decl.
12246 * emacs.c: Make symbols static if they're not exported.
12247 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12248 (fatal_error_code, fatal_error_signal_hook, standard_args):
12250 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12251 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12252 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12253 * lisp.h (fatal_error_signal_hook): Remove decl.
12254 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12256 * editfns.c: Move a (normally-unused) function to its only use.
12257 * editfns.c, lisp.h (get_operating_system_release): Remove.
12258 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12259 worth the hassle of breaking this out.
12261 * xterm.c: Make symbols static if they're not exported.
12262 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12263 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12264 (x_destroy_window, x_delete_display):
12266 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12267 (x_mouse_leave): Remove; unused.
12268 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12269 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12270 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12272 (x_mouse_leave): Declare only if WINDOWSNT.
12273 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12274 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12277 * ftxfont.c: Make symbols static if they're not exported.
12278 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12280 * font.h (ftxfont_driver): Likewise.
12282 * xfns.c: Make symbols static if they're not exported.
12283 (x_last_font_name, x_display_info_for_name):
12284 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12285 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12286 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12287 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12288 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12289 (last_show_tip_args): Now static.
12290 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12291 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12292 (x_screen_planes): Remove; unused.
12293 * dispextern.h (x_screen_planes): Remove decl.
12295 * dispnew.c: Make symbols static if they're not exported.
12296 * dispextern.h (redraw_garbaged_frames, scrolling):
12297 (increment_row_positions): Remove.
12298 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12299 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12301 (redraw_garbaged_frames): Remove; unused.
12303 * xfaces.c: Make symbols static if they're not exported.
12304 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12306 * xterm.h (defined_color): Remove decls.
12307 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12308 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12309 (menu_face_changed_default, defined_color, free_realized_face):
12310 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12311 (ascii_face_of_lisp_face): Remove; unused.
12313 * xdisp.c: Make symbols static if they're not exported.
12314 * dispextern.h (scratch_glyph_row, window_box_edges):
12315 (glyph_to_pixel_coords, set_cursor_from_row):
12316 (get_next_display_element, set_iterator_to_next):
12317 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12318 (show_mouse_face): Remove decls
12319 * frame.h (message_buf_print): Likewise.
12320 * lisp.h (pop_message, set_message, check_point_in_composition):
12322 * xterm.h (set_vertical_scroll_bar): Likewise.
12323 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12324 (message_buf_print, scratch_glyph_row, displayed_buffer):
12325 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12326 (get_next_display_element, show_mouse_face, window_box_edges):
12327 (frame_to_window_pixel_xy, check_point_in_composition):
12328 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12329 (glyph_to_pixel_coords): Remove; unused.
12331 * dired.c (file_name_completion): Now static.
12333 * dbusbind.c (xd_in_read_queued_messages): Now static.
12335 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12336 * data.c (circular_list_error): Remove.
12338 * commands.h (last_point_position, last_point_position_buffer):
12339 (last_point_position_window): Remove decls.
12340 * keyboard.c: Make these variables static.
12342 * coding.h (coding, code_convert_region, encode_coding_gap):
12344 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12345 (iso_code_class, detect_coding, code_convert_region): Now static.
12346 (encode_coding_gap): Remove; unused.
12348 * chartab.c (chartab_chars, chartab_bits): Now static.
12350 * charset.h (charset_iso_8859_1): Remove decl.
12351 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12354 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12355 * ccl.c (Vccl_program_table): Now static.
12356 (check_ccl_update): Remove; unused.
12358 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12359 * category.h: ... from here.
12360 * category.c (check_category_table, set_category_set): Now static.
12362 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12363 * lisp.h: Remove these decls.
12365 * buffer.c (buffer_count): Remove unused var.
12367 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12368 so that it's not optimized away.
12369 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12370 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12371 exported only to the debugger.
12373 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
12374 * atimer.h (run_all_atimers): Remove; not exported.
12376 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12377 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12378 was inaccessible from Lisp.
12379 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12380 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12382 alloc.c: Import and export fewer symbols, and remove unused items.
12383 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12385 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12386 it's not optimized away by whole-program optimization.
12387 (message_enable_multibyte, free_misc): Remove.
12388 (catchlist, handlerlist, mark_backtrace):
12389 Declare only if BYTE_MARK_STACK.
12390 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12391 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12392 (message_enable_multibyte): Remove decl.
12393 (free_misc, interval_free_list, float_block, float_block_index):
12394 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12395 (cons_free_list, last_marked_index):
12397 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12398 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12399 (mark_backtrace): Define only if BYTE_MARK_STACK.
12400 * xdisp.c (message_enable_multibyte): Now static.
12402 Declare Lisp_Object Q* variables to be 'static' if not exported.
12403 This makes it easier for human readers (and static analyzers)
12404 to see whether these variables are used from other modules.
12405 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12406 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12407 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12408 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12409 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12410 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12411 * xmenu.c, xselect.c:
12412 Declare Q* vars static if they are not used in other modules.
12413 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12414 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12415 Remove decls of unexported vars.
12416 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12418 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12420 Make Emacs functions such as Fatom 'static' by default.
12421 This makes it easier for human readers (and static analyzers)
12422 to see whether these functions can be called from other modules.
12423 DEFUN now defines a static function. To make the function external
12424 so that it can be used in other C modules, use the new macro DEFUE.
12425 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12426 (Finit_image_library):
12427 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12428 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12429 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12430 Remove decls, since these functions are now static.
12431 (Funintern, Fget_internal_run_time): New decls, since these functions
12432 were already external.
12434 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12435 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12436 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12437 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12438 * keyboard.c, keymap.c, lread.c:
12439 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12440 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12441 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12442 Mark functions with DEFUE instead of DEFUN,
12443 if they are used in other modules.
12444 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12445 decls for now-static functions.
12446 * buffer.h (Fdelete_overlay): Remove decl.
12447 * callproc.c (Fgetenv_internal): Mark as internal.
12448 * composite.c (Fremove_list_of_text_properties): Remove decl.
12449 (Fcomposition_get_gstring): New forward static decl.
12450 * composite.h (Fcomposite_get_gstring): Remove decl.
12451 * dired.c (Ffile_attributes): New forward static decl.
12452 * doc.c (Fdocumntation_property): New forward static decl.
12453 * eval.c (Ffetch_bytecode): New forward static decl.
12454 (Funintern): Remove extern decl; now in .h file where it belongs.
12455 * fileio.c (Fmake_symbolic_link): New forward static decl.
12456 * image.c (Finit_image_library): New forward static decl.
12457 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12458 * intervals.h (Fprevious_property_change):
12459 (Fremove_list_of_text_properties): Remove decls.
12460 * keyboard.c (Fthis_command_keys): Remove decl.
12461 (Fcommand_execute): New forward static decl.
12462 * keymap.c (Flookup_key): New forward static decl.
12463 (Fcopy_keymap): Now static.
12464 * keymap.h (Flookup_key): Remove decl.
12465 * process.c (Fget_process): New forward static decl.
12466 (Fprocess_datagram_address): Mark as internal.
12467 * syntax.c (Fsyntax_table_p): New forward static decl.
12468 (skip_chars): Remove duplicate decl.
12469 * textprop.c (Fprevious_property_change): New forward static decl.
12470 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12472 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12473 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12475 * editfns.c (Fformat): Remove unreachable code.
12477 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12479 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12482 2011-04-13 Eli Zaretskii <eliz@gnu.org>
12484 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12485 when at ZV. (Bug#8487)
12487 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12489 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12491 * keyboard.c (parse_tool_bar_item): Likewise.
12492 * sound.c (sound_cleanup, alsa_close): Likewise.
12493 * termcap.c (tgetent): Likewise.
12494 * xfns.c (x_default_font_parameter): Likewise.
12495 * xsettings.c (read_and_apply_settings): Likewise.
12497 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12498 (overrun_check_free): Protoize.
12500 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12502 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12503 since callers should never pass a negative size.
12504 Change the signature to match that of plain 'read' and 'write'; see
12505 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12506 * lisp.h: Update prototypes of emacs_write and emacs_read.
12508 2011-04-11 Eli Zaretskii <eliz@gnu.org>
12510 * xdisp.c (redisplay_window): Don't try to determine the character
12511 position of the scroll margin if the window start point w->startp
12512 is outside the buffer's accessible region. (Bug#8468)
12514 2011-04-10 Eli Zaretskii <eliz@gnu.org>
12516 Fix write-region and its subroutines for buffers > 2GB.
12517 * fileio.c (a_write, e_write): Modify declaration of arguments and
12518 local variables to support buffers larger than 2GB.
12519 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12521 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12522 argument, local variables, and return value.
12524 * lisp.h: Update prototypes of emacs_write and emacs_read.
12526 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12528 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
12530 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12532 Fix more problems found by GCC 4.6.0's static checks.
12534 * xdisp.c (vmessage): Use a better test for character truncation.
12536 * charset.c (load_charset_map): <, not <=, for optimization,
12537 and to avoid potential problems with integer overflow.
12538 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
12539 * casetab.c (set_identity, shuffle): Likewise.
12540 * editfns.c (Fformat): Likewise.
12541 * syntax.c (skip_chars): Likewise.
12543 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12544 This also lets GCC 4.6.0 generate slightly better loop code.
12546 * callint.c (Fcall_interactively): <, not <=, for optimization.
12547 (Fcall_interactively): Count the number of arguments produced,
12548 not the number of arguments given. This is simpler and lets GCC
12549 4.6.0 generate slightly better code.
12551 * ftfont.c: Distingish more carefully between FcChar8 and char.
12552 The previous code passed unsigned char * to a functions like
12553 strlen and xstrcasecmp that expect char *, which does not
12554 conform to the C standard.
12555 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12556 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12557 char * when the C standard requires it.
12559 * keyboard.c (read_char): Remove unused var.
12561 * eval.c: Port to Windows vsnprintf (Bug#8435).
12562 Include <limits.h>.
12563 (SIZE_MAX): Define if the headers do not.
12564 (verror): Do not give up if vsnprintf returns a negative count.
12565 Instead, grow the buffer. This ports to Windows vsnprintf, which
12566 does not conform to C99. Problem reported by Eli Zaretskii.
12567 Also, simplify the allocation scheme, by avoiding the need for
12568 calling realloc, and removing the ALLOCATED variable.
12570 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12572 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12573 But keep the doprint source code for now, as we might revamp it
12574 and use it again (Bug#8435).
12575 * lisp.h (doprnt): Remove.
12576 * Makefile.in (base_obj): Remove doprnt.o.
12577 * deps.mk (doprnt.o): Remove.
12579 error: Print 32- and 64-bit integers portably (Bug#8435).
12580 Without this change, on typical 64-bit hosts error ("...%d...", N)
12581 was used to print both 32- and 64-bit integers N, which relied on
12582 undefined behavior.
12583 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
12584 * lisp.h (error, verror): Mark as printf-like functions.
12585 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12586 Report overflow in size calculations when allocating printf buffer.
12587 Do not truncate output string at its first null byte.
12588 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12589 Truncate the output at a character boundary, since vsnprintf does not
12591 * charset.c (check_iso_charset_parameter): Convert internal
12592 character to string before calling 'error', since %c now has the
12594 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12595 overflow when computing char to be passed to 'error'. Do not
12596 pass Lisp_Object to 'error'; pass the integer instead.
12597 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12598 formatted with plain %d.
12600 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12602 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12604 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12606 * xterm.c (x_catch_errors): Remove duplicate declaration.
12608 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12610 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12612 2011-04-10 Jim Meyering <meyering@redhat.com>
12614 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12615 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12616 return ssize_t not "int", and use size_t as the buffer length.
12617 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12618 * gnutls.h: Update declarations.
12619 * process.c (read_process_output): Use ssize_t, to match.
12620 (send_process): Likewise.
12622 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
12624 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12626 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
12628 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12629 Use unsigned char, to match FcChar8 type definition.
12631 * xterm.c (handle_one_xevent):
12632 * xmenu.c (create_and_show_popup_menu):
12633 * xselect.c (x_decline_selection_request)
12634 (x_reply_selection_request): Avoid type-punned deref of X events.
12636 2011-04-09 Eli Zaretskii <eliz@gnu.org>
12638 Fix some uses of `int' instead of EMACS_INT.
12639 * search.c (string_match_1, fast_string_match)
12640 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12641 (scan_buffer, find_next_newline_no_quit)
12642 (find_before_next_newline, search_command, Freplace_match)
12643 (Fmatch_data): Make some `int' variables be EMACS_INT.
12645 * xdisp.c (display_count_lines): 3rd argument and return value now
12646 EMACS_INT. All callers changed.
12647 (pint2hrstr): Last argument is now EMACS_INT.
12649 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12650 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12651 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12652 (decode_coding_utf_16, decode_coding_emacs_mule)
12653 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12654 (decode_coding_ccl, decode_coding_charset)
12655 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12656 (decode_coding_iso_2022, decode_coding_emacs_mule)
12657 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12658 <char_offset, last_offset>: Declare EMACS_INT.
12659 (encode_coding_utf_8, encode_coding_utf_16)
12660 (encode_coding_emacs_mule, encode_invocation_designation)
12661 (encode_designation_at_bol, encode_coding_iso_2022)
12662 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12663 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12665 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12666 (encode_invocation_designation): Last argument P_NCHARS is now
12668 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12669 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12671 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12674 * ccl.c (Fccl_execute_on_string): Declare some variables
12677 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
12679 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12681 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12683 * process.c (Fformat_network_address): Doc fix.
12685 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12687 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
12689 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
12691 * keyboard.c (read_char): Call Lisp function help-form-show,
12692 instead of using internal_with_output_to_temp_buffer.
12693 (Qhelp_form_show): New var.
12694 (syms_of_keyboard): Use DEFSYM macro.
12696 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12698 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12700 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
12702 * process.c (Flist_processes): Remove to Lisp.
12703 (list_processes_1): Delete.
12705 2011-04-06 Eli Zaretskii <eliz@gnu.org>
12707 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12709 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12711 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
12713 Fix more problems found by GCC 4.6.0's static checks.
12715 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12717 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12719 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
12721 * xdisp.c (vmessage): Mark as a printf-like function.
12723 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12725 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12727 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12728 printf-like functions.
12729 (tiff_load): Add casts to remove these marks before passing them
12730 to system-supplied API.
12732 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12734 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12735 This avoids several warnings with gcc -Wstrict-overflow.
12736 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12737 directly, rather than having caller test rule sign. This avoids
12738 some unnecessary tests.
12739 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12740 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12741 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
12743 * xfont.c (xfont_text_extents): Remove var that was set but not used.
12744 (xfont_open): Avoid unnecessary tests.
12746 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12748 * composite.h, composite.c (composition_gstring_put_cache):
12749 Use EMACS_INT, not int, for length.
12751 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12752 breaking out part of COMPOSITION_DECODE_RULE.
12753 (COMPOSITION_DECODE_RULE): Use it.
12754 * composite.c (get_composition_id): Remove unused local vars,
12755 by using the new macro.
12757 * textprop.c (set_text_properties_1): Change while to do-while,
12758 since the condition is always true at first.
12760 * intervals.c (graft_intervals_into_buffer): Mark var as used.
12761 (interval_deletion_adjustment): Return unsigned value.
12764 * process.c (list_processes_1, create_pty, read_process_output):
12765 (exec_sentinel): Remove vars that were set but not used.
12766 (create_pty): Remove unnecessary "volatile"s.
12767 (Fnetwork_interface_info): Avoid possibility of int overflow.
12768 (read_process_output): Do adaptive read buffering even if carryover.
12769 (read_process_output): Simplify nbytes computation if buffered.
12771 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12773 * syntax.c (scan_words): Remove var that was set but not used.
12774 (update_syntax_table): Use unsigned instead of int.
12776 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
12777 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
12778 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
12780 * print.c (print_error_message): Avoid int overflow.
12782 * font.c (font_list_entities): Redo for clarity,
12783 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12785 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
12786 (font_score): Avoid potential overflow in diff calculation.
12788 * fns.c (substring_both): Remove var that is set but not used.
12789 (sxhash): Redo loop for clarity and to avoid wraparound warning.
12791 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12793 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12794 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12795 can always succeed if overflow has undefined behavior.
12797 * search.c (boyer_moore, wordify): Remove vars set but not used.
12798 (wordify): Omit three unnecessary tests.
12800 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12801 All callers changed. This avoids the need for an unused var.
12803 * casefiddle.c (casify_region): Remove var that is set but not used.
12805 * dired.c (file_name_completion): Remove var that is set but not used.
12807 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12809 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
12810 (Finsert_file_contents): Remove unnecessary code checking fd.
12812 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12813 Check for integer overflow on size calculations.
12815 * buffer.c (Fprevious_overlay_change): Remove var that is set
12818 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12819 Remove vars that are set but not used.
12820 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
12821 (timer_check_2): Mark vars as initialized.
12823 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12825 * image.c (lookup_image): Remove var that is set but not used.
12826 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
12828 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12829 that are set but not used.
12831 * xfns.c (make_invisible_cursor): Don't return garbage
12832 if XCreateBitmapFromData fails (Bug#8410).
12834 * xselect.c (x_get_local_selection, x_handle_property_notify):
12835 Remove vars that are set but not used.
12837 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
12838 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
12840 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12841 Remove var that is set but not used.
12842 (scroll_bar_windows_size): Now size_t, not int.
12843 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12844 Check for overflow.
12846 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12847 (map_tty_color) [!defined MSDOS]: Likewise.
12849 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12851 * coding.c: Remove vars that are set but not used.
12852 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12853 All callers changed.
12854 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12855 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12856 (decode_coding_charset): Remove vars that are set but not used.
12858 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12859 that is set but not used.
12861 * print.c (print_object): Remove var that is set but not used.
12863 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
12864 The gnulib version avoids calling malloc in the usual case,
12865 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12866 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12867 * filelock.c (current_lock_owner): Likewise.
12868 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12869 * sysdep.c: Include allocator.h, careadlinkat.h.
12870 (emacs_no_realloc_allocator): New static constant.
12871 (emacs_readlink): New function.
12872 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12873 ../lib/careadlinkat.h.
12875 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12877 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12878 first non-nil return value).
12880 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12882 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12883 if not defined (Bug#8403).
12885 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
12887 * xdisp.c (display_count_lines): Remove parameter `start',
12888 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12889 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12890 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12891 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12892 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12893 and thereabouts. All callers changed.
12894 (get_per_char_metric): Remove parameter `f', unused since
12895 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12897 2011-04-02 Jim Meyering <meyering@redhat.com>
12899 do not dereference NULL upon failed strdup
12900 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12901 (ns_get_family): Likewise.
12903 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
12905 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12907 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12909 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12912 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12914 Add lexical binding.
12916 * window.c (Ftemp_output_buffer_show): New fun.
12917 (Fsave_window_excursion):
12918 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12920 * lread.c (lisp_file_lexically_bound_p): New function.
12921 (Fload): Bind Qlexical_binding.
12922 (readevalloop): Remove `evalfun' arg.
12923 Bind Qinternal_interpreter_environment.
12924 (Feval_buffer): Bind Qlexical_binding.
12925 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12927 (syms_of_lread): Declare `lexical-binding'.
12929 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12931 * keyboard.c (eval_dyn): New fun.
12932 (menu_item_eval_property): Use it.
12934 * image.c (parse_image_spec): Use Ffunctionp.
12936 * fns.c (concat, mapcar1): Accept byte-code-functions.
12938 * eval.c (Fsetq): Handle lexical vars.
12939 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12940 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12941 (FletX, Flet): Obey lexical binding.
12942 (Fcommandp): Handle closures.
12943 (Feval): New `lexical' arg.
12944 (eval_sub): New function extracted from Feval. Use it almost
12945 everywhere where Feval was used. Look up vars in lexical env.
12947 (Ffunctionp): Move from subr.el.
12948 (Ffuncall): Handle closures.
12949 (apply_lambda): Remove `eval_flags'.
12950 (funcall_lambda): Handle closures and new byte-code-functions.
12951 (Fspecial_variable_p): New function.
12952 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12953 but without exporting it to Lisp.
12955 * doc.c (Fdocumentation, store_function_docstring):
12956 * data.c (Finteractive_form): Handle closures.
12958 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12961 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12963 (exec_byte_code): New function extracted from Fbyte_code to handle new
12964 calling convention for byte-code-functions. Add new byte-codes.
12966 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
12968 * alloc.c (Fmake_symbol): Init new `declared_special' field.
12970 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12972 * xdisp.c (redisplay_internal): Fix prototype.
12974 2011-03-31 Eli Zaretskii <eliz@gnu.org>
12976 * xdisp.c (SCROLL_LIMIT): New macro.
12977 (try_scrolling): Use it when setting scroll_limit.
12978 Limit scrolling to 100 screen lines.
12979 (redisplay_window): Even when falling back on "recentering",
12980 position point in the window according to scroll-conservatively,
12981 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12983 (try_scrolling): When point is above the window, allow searching
12984 as far as scroll_max, or one screenful, to compute vertical
12985 distance from PT to the scroll margin position. This prevents
12986 try_scrolling from unnecessarily failing when
12987 scroll-conservatively is set to a value slightly larger than the
12988 window height. Clean up the case of PT below the margin at bottom
12989 of window: scroll_max can no longer be INT_MAX. When aggressive
12990 scrolling is in use, don't let point enter the opposite scroll
12991 margin as result of the scroll.
12992 (syms_of_xdisp) <scroll-conservatively>: Document the
12993 threshold of 100 lines for never-recentering scrolling.
12995 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12997 * dispextern.h (move_it_by_lines):
12998 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12999 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13000 (message_log_check_duplicate): Remove parameters `prev_bol' and
13001 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13002 (redisplay_internal): Remove parameter `preserve_echo_area',
13003 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13005 * indent.c (Fvertical_motion):
13006 * window.c (window_scroll_pixel_based, Frecenter):
13007 Don't pass `need_y_p' to `move_it_by_lines'.
13009 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13011 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13012 steal a few bits to be more compact.
13013 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13014 Remove unneeded casts.
13016 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13018 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13020 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13021 binding" message (bug#7967).
13023 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13025 Fix more problems found by GCC 4.6.0's static checks.
13027 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13028 Remove unused local var.
13030 * editfns.c (Fmessage_box): Remove unused local var.
13032 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13033 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13034 Omit unused local vars.
13035 * window.c (shrink_windows): Omit unused local var.
13036 * menu.c (digest_single_submenu): Omit unused local var.
13037 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13038 Omit unused local var.
13040 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13041 Don't assume string length fits in int.
13042 (keyremap_step, read_key_sequence): Use size_t for sizes.
13043 (read_key_sequence): Don't check last_real_key_start redundantly.
13045 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13046 instead of alloca (Bug#8344).
13048 * eval.c (Fbacktrace): Don't assume nargs fits in int.
13049 (Fbacktrace_frame): Don't assume nframes fits in int.
13051 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13053 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13056 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13058 * cm.c (calccost): Turn while-do into do-while, for clarity.
13060 * keyboard.c (syms_of_keyboard): Use the same style as later
13061 in this function when indexing through an array. This also
13062 works around GCC bug 48267.
13064 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13066 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13068 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13069 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13071 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13072 This avoids undefined behavior on integer overflow, and is a bit
13073 more convenient anyway since it is compared to a size_t variable.
13075 Variadic C functions now count arguments with size_t, not int.
13076 This avoids an unnecessary limitation on 64-bit machines, which
13077 caused (substring ...) to crash on large vectors (Bug#8344).
13078 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13079 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
13080 All variadic functions and their callers changed accordingly.
13081 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13082 * data.c (arith_driver, float_arith_driver): Likewise.
13083 * editfns.c (general_insert_function): Likewise.
13084 * eval.c (struct backtrace.nargs, interactive_p)
13085 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13086 (funcall_lambda, mark_backtrace): Likewise.
13087 * fns.c (concat): Likewise.
13088 * frame.c (x_set_frame_parameters): Likewise.
13089 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13090 0 if not found, not -1. All callers changed.
13092 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13093 (stack_copy_size): Now size_t, not int.
13094 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13096 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
13098 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13099 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13100 All callers changed.
13102 * lisp.h (multibyte_char_to_unibyte):
13103 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13104 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13105 * character.h (CHAR_TO_BYTE8):
13106 * cmds.c (internal_self_insert):
13107 * editfns.c (general_insert_function):
13108 * keymap.c (push_key_description):
13109 * search.c (Freplace_match):
13110 * xdisp.c (message_dolog, set_message_1): All callers changed.
13112 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13114 * keyboard.c (safe_run_hook_funcall): New function.
13115 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13116 don't set the hook to nil, but remove the offending function instead.
13117 (Qcommand_hook_internal): Remove, unused.
13118 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13119 Vcommand_hook_internal.
13121 * eval.c (enum run_hooks_condition): Remove.
13122 (funcall_nil, funcall_not): New functions.
13123 (run_hook_with_args): Call each function through a `funcall' argument.
13124 Remove `cond' argument, now redundant.
13125 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13126 (Frun_hook_with_args_until_failure): Adjust accordingly.
13127 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13129 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
13131 * dispextern.h (string_buffer_position): Remove declaration.
13133 * print.c (strout): Remove parameter `multibyte', unused since
13134 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13136 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13137 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13138 All callers changed.
13140 * w32.c (_wsa_errlist): Use braces for struct initializers.
13142 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13143 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13144 All callers changed.
13145 (string_buffer_position): Likewise. Also, make static (it's never
13146 used outside xdisp.c).
13147 (cursor_row_p): Remove parameter `w', unused since
13148 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13149 (decode_mode_spec): Remove parameter `precision', introduced during
13150 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13151 All callers changed.
13153 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13155 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13157 2011-03-27 Anders Lindgren <andlind@gmail.com>
13159 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13160 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13161 (ns_update_auto_hide_menu_bar): New functions.
13162 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13163 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13164 ns_constrain_all_frames.
13165 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13166 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13168 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13170 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13172 2011-03-27 Glenn Morris <rgm@gnu.org>
13174 * syssignal.h: Replace RETSIGTYPE with void.
13175 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13176 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13177 Replace SIGTYPE with void everywhere.
13178 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13179 * s/template.h (SIGTYPE): Remove commented out definition.
13181 2011-03-26 Eli Zaretskii <eliz@gnu.org>
13183 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13184 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13186 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
13188 * w32.c (read_unc_volume): Use parameter `henum', instead of
13189 global variable `wget_enum_handle'.
13191 * keymap.c (describe_vector): Remove parameters `indices' and
13192 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13193 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13195 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13197 * keyboard.c (timer_check): Remove parameter `do_it_now',
13198 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13199 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13200 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13202 * keyboard.c (read_char):
13203 * w32menu.c (w32_menu_display_help):
13204 * xmenu.c (show_help_event, menu_help_callback):
13205 Adjust calls to `show_help_echo'.
13207 * gtkutil.c (xg_maybe_add_timer):
13208 * keyboard.c (readable_events):
13209 * process.c (wait_reading_process_output):
13210 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13212 * insdel.c (adjust_markers_gap_motion):
13213 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13214 (gap_left, gap_right): Don't call it.
13216 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
13218 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13219 incurred during fontification.
13221 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
13223 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13224 (DEFVAR_PER_BUFFER): Don't pass it.
13226 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13227 (scrolling_window): Don't pass it.
13229 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
13231 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13233 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13235 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13236 of variables specific to SELinux and computation of `encoded_absname'.
13238 * image.c (XPutPixel): Remove unused variable `height'.
13240 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13242 * unexw32.c (get_section_info): Remove unused variable `section'.
13244 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13245 (system_process_attributes): Remove unused variable `sess'.
13246 (sys_read): Remove unused variable `err'.
13248 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13249 (w32_wnd_proc): Remove unused variable `isdead'.
13250 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13251 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13252 (x_create_tip_frame): Remove unused variable `tem'.
13254 * w32inevt.c (w32_console_read_socket):
13255 Remove unused variable `no_events'.
13257 * w32term.c (x_draw_composite_glyph_string_foreground):
13258 Remove unused variable `width'.
13260 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
13262 * w32term.c (x_set_glyph_string_clipping):
13263 Don't pass uninitialized region to CombineRgn.
13265 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
13267 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13268 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13269 (Fx_close_connection): Remove unused variable `i'.
13271 * w32font.c (w32font_draw): Return number of glyphs.
13272 (w32font_open_internal): Remove unused variable `i'.
13273 (w32font_driver): Add missing initializer.
13275 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13276 (fill_in_menu): Remove unused variable `items_added'.
13278 * w32term.c (last_mouse_press_frame): Remove static global variable.
13279 (w32_clip_to_row): Remove unused variable `f'.
13280 (x_delete_terminal): Remove unused variable `i'.
13282 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13283 (NOTHING): Remove unused static global variable.
13284 (uniscribe_check_otf): Remove unused variable `table'.
13285 (uniscribe_font_driver): Add missing initializers.
13287 2011-03-23 Julien Danjou <julien@danjou.info>
13289 * term.c (Fsuspend_tty, Fresume_tty):
13290 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13291 * window.c (temp_output_buffer_show):
13292 * insdel.c (signal_before_change):
13293 * frame.c (Fhandle_switch_frame):
13294 * fileio.c (Fdo_auto_save):
13295 * emacs.c (Fkill_emacs):
13296 * editfns.c (save_excursion_restore):
13297 * cmds.c (internal_self_insert):
13298 * callint.c (Fcall_interactively):
13299 * buffer.c (Fkill_all_local_variables):
13300 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13302 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
13303 unconditionally since it does the check itself.
13305 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
13307 Fix more problems found by GCC 4.5.2's static checks.
13309 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13310 the first time through the loop, since we know p0 < p1 then.
13311 This also avoids a gcc -Wstrict-overflow warning.
13313 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13314 leading to a memory leak, possible in functions like
13315 load_charset_map_from_file that can allocate an unbounded number
13316 of objects (Bug#8318).
13318 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13319 that could (at least in theory) be that large.
13321 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13322 This is less likely to overflow, and avoids undefined behavior if
13323 overflow does occur. All callers changed. Use strtoul to scan
13324 for the unsigned long integer.
13325 (pint2hrstr): Simplify and tune code slightly.
13326 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
13328 * scroll.c (do_scrolling): Work around GCC bug 48228.
13329 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13331 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13332 This also avoids a warning with gcc -Wstrict-overflow.
13333 (validate_x_resource_name): Simplify count usage.
13334 This also avoids a warning with gcc -Wstrict-overflow.
13336 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13339 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
13341 * process.c (Fmake_network_process): Use socklen_t, not int,
13342 where POSIX says socklen_t is required in portable programs.
13343 This fixes a porting bug on hosts like 64-bit HP-UX, where
13344 socklen_t is wider than int (Bug#8277).
13345 (Fmake_network_process, server_accept_connection):
13346 (wait_reading_process_output, read_process_output):
13349 * process.c: Rename or move locals to avoid shadowing.
13350 (list_processes_1, Fmake_network_process):
13351 (read_process_output_error_handler, exec_sentinel_error_handler):
13352 Rename or move locals.
13353 (Fmake_network_process): Define label "retry_connect" only if needed.
13354 (Fnetwork_interface_info): Fix pointer signedness.
13355 (process_send_signal): Add cast to avoid pointer signedness problem.
13356 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
13357 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
13359 Make tparam.h and terminfo.c consistent.
13360 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13361 Include tparam.h instead, since it declares them.
13362 * cm.h (PC): Remove extern decl; tparam.h now does this.
13363 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13364 * terminfo.c: Include tparam.h, to check interfaces.
13365 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13366 (tparam): Adjust signature to match interface in tparam.h;
13367 this removes some undefined behavior. Check that outstring and len
13368 are zero, which they always are with Emacs.
13369 * tparam.h (PC, BC, UP): New extern decls.
13371 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
13372 (xftfont_open): Rename locals to avoid shadowing.
13374 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
13375 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13376 (OTF_TAG_SYM): Omit macro if not needed.
13377 (ftfont_list): Remove unused local.
13378 (get_adstyle_property, ftfont_pattern_entity):
13379 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13380 Rename locals to avoid shadowing.
13382 * xfont.c (xfont_list_family): Mark var as initialized.
13384 * xml.c (make_dom): Now static.
13386 * composite.c (composition_compute_stop_pos): Rename local to
13388 (composition_reseat_it): Remove unused locals.
13389 (find_automatic_composition, composition_adjust_point): Likewise.
13390 (composition_update_it): Mark var as initialized.
13391 (find_automatic_composition): Mark vars as initialized,
13392 with a FIXME (Bug#8290).
13394 character.h: Rename locals to avoid shadowing.
13395 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13396 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13397 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13398 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13399 to avoid shadowing.
13401 * textprop.c (property_change_between_p): Remove; unused.
13403 * intervals.c (interval_start_pos): Now static.
13405 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13407 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13408 Rename locals to avoid shadowing.
13410 * sound.c (wav_play, au_play, Fplay_sound_internal):
13411 Fix pointer signedness.
13412 (alsa_choose_format): Remove unused local var.
13413 (wav_play): Initialize a variable to 0, to prevent undefined
13414 behavior (Bug#8278).
13416 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13418 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13420 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13421 clobbering (Bug#8298).
13422 * sysdep.c (sys_subshell): Likewise.
13423 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
13425 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13426 This should get cleaned up, so that child_setup has the
13427 same signature on all platforms.
13429 * callproc.c (call_process_cleanup): Now static.
13430 (relocate_fd): Rename locals to avoid shadowing.
13432 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
13434 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13435 not to be necessary, and produces flickering.
13437 2011-03-20 Glenn Morris <rgm@gnu.org>
13439 * config.in: Remove file.
13441 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
13443 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13444 are now in src/globals.h.
13445 (syms_of_minibuf): Remove spurious & from previous change.
13447 2011-03-20 Leo Liu <sdl.web@gmail.com>
13449 * minibuf.c (completing-read-function): New variable.
13450 (completing-read-default): Rename from completing-read.
13451 (completing-read): Call completing-read-function.
13453 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13455 * xfaces.c (Fx_load_color_file):
13456 Read color file from absolute filename (bug#8250).
13458 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13460 * makefile.w32-in: Update dependencies.
13462 2011-03-17 Eli Zaretskii <eliz@gnu.org>
13464 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13466 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13468 Fix more problems found by GCC 4.5.2's static checks.
13470 * process.c (make_serial_process_unwind, send_process_trap):
13471 (sigchld_handler): Now static.
13473 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13474 That way, the code declares only the vars that it needs.
13475 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13476 * s/cygwin.h (PTY_ITERATION): Likewise.
13477 * s/darwin.h (PTY_ITERATION): Likewise.
13478 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13480 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13481 * process.c (allocate_pty): Don't declare stb unless it's needed.
13483 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
13484 (CONSTANTLIM): Remove; unused.
13485 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13486 Define only if needed.
13488 * unexelf.c (unexec): Name an expression,
13489 to avoid gcc -Wbad-function-cast warning.
13490 Use a different way to cause a compilation error if anyone uses
13491 n rather than nn, a way that does not involve shadowing.
13492 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
13494 * deps.mk (unexalpha.o): Remove; unused.
13496 New file unexec.h, the (simple) interface for unexec (Bug#8267).
13497 * unexec.h: New file.
13498 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13499 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13500 Depend on unexec.h.
13501 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13502 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13503 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
13504 Change as necessary to match prototype in unexec.h.
13506 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13508 (back_comment, skip_chars): Mark vars as initialized.
13510 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13511 Rename locals to avoid shadowing.
13513 * lread.c (read1): Rewrite so as not to use empty "else".
13514 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
13516 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13518 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13519 warning when compiling print.c.
13521 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13522 instead of using an uninitialized var.
13523 (font_sort_entities): Mark var as initialized.
13525 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13527 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13528 pointers to constants.
13529 (font_parse_fcname): Remove unused vars.
13530 (font_delete_unmatched): Now static.
13531 (font_get_spec): Remove; unused.
13532 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13533 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13534 Rename or move locals to avoid shadowing.
13536 * fns.c (require_nesting_list, require_unwind): Now static.
13537 (Ffillarray): Rename locals to avoid shadowing.
13539 * floatfns.c (domain_error2): Define only if needed.
13540 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
13542 * alloc.c (mark_backtrace): Move decl from here ...
13543 * lisp.h: ... to here, so that it can be checked.
13545 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
13546 (Fdefvar): Rewrite so as not to use empty "else".
13547 (lisp_indirect_variable): Name an expression,
13548 to avoid gcc -Wbad-function-cast warning.
13549 (Fdefvar): Rename locals to avoid shadowing.
13551 * callint.c (quotify_arg, quotify_args): Now static.
13552 (Fcall_interactively): Rename locals to avoid shadowing.
13553 Use const pointer when appropriate.
13555 * lisp.h (get_system_name, get_operating_system_release):
13556 Move decls here, to check interfaces.
13557 * process.c (get_operating_system_release): Move decl to lisp.h.
13558 * xrdb.c (get_system_name): Likewise.
13559 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13560 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13561 some of which prompt warnings from gcc -Wbad-function-cast.
13562 (Fformat_time_string, Fencode_time, Finsert_char):
13563 (Ftranslate_region_internal, Fformat):
13564 Rename or remove local vars to avoid shadowing.
13565 (Ftranslate_region_internal): Mark var as initialized.
13567 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13570 * lisp.h (eassert): Check that the argument compiles, even if
13571 ENABLE_CHECKING is not defined.
13573 * data.c (Findirect_variable): Name an expression, to avoid
13574 gcc -Wbad-function-cast warning.
13575 (default_value, arithcompare, arith_driver, arith_error): Now static.
13576 (store_symval_forwarding): Rename local to avoid shadowing.
13577 (Fmake_variable_buffer_local, Fmake_local_variable):
13578 Mark variables as initialized.
13579 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
13581 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
13582 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13583 Rename locals to avoid shadowing.
13584 (mark_stack): Move local variables into the #ifdef region where
13586 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13587 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13589 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13590 (GC_STRING_CHARS): Remove; not used.
13591 (Fmemory_limit): Cast sbrk's returned value to char *.
13593 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13594 avoids undefined behavior in theory.
13596 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13598 Use functions, not macros, for up- and down-casing (Bug#8254).
13599 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13600 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13601 to use the following functions instead of these macros.
13602 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13603 EMACS_INT, since callers assume the returned value fits in int.
13604 (upcase1): Likewise, for UPCASE_TABLE.
13605 (uppercasep, lowercasep, upcase): New static inline functions.
13606 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
13607 the race-condition problem in the old DOWNCASE.
13609 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13610 Rename locals to avoid shadowing.
13611 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
13612 (regex_compile, re_search_2, re_match_2_internal):
13613 Remove unused local vars.
13614 (FREE_VAR): Rewrite so as not to use empty "else",
13615 which gcc can warn about.
13616 (regex_compile, re_match_2_internal): Mark locals as initialized.
13617 (RETALLOC_IF): Define only if needed.
13618 (WORDCHAR_P): Likewise. This one is never needed, but is used
13619 only in a comment talking about a compiler bug, so put inside
13620 the #if 0 of that comment.
13621 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13622 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13625 * search.c (boyer_moore): Rename locals to avoid shadowing.
13626 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13627 (PREV_CHAR_BOUNDARY): Likewise.
13629 * search.c (simple_search): Remove unused var.
13631 * dired.c (compile_pattern): Move decl from here ...
13632 * lisp.h: ... to here, so that it can be checked.
13633 (struct re_registers): New forward decl.
13635 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13637 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13639 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13640 Rename locals to avoid shadowing.
13641 (Fvertical_motion): Mark locals as initialized.
13643 * casefiddle.c (casify_object, casify_region): Now static.
13644 (casify_region): Mark local as initialized.
13646 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13648 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13649 New macros, so that the caller can use some names other than
13650 gcpro1, gcpro2, etc.
13651 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13653 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13654 argument, for consistency with GCPRO2_VAR, etc: it is now the
13655 prefix of the variable, not the variable itself. All uses
13657 * dired.c (directory_files_internal, file_name_completion):
13658 Rename locals to avoid shadowing.
13660 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13661 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13662 dired.c's scmp function, had undefined behavior.
13663 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13664 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13665 * buffer.h: ... to here, because these macros use current_buffer,
13666 and the new implementation with inline functions needs to have
13667 current_buffer in scope now, rather than later when the macros
13669 (downcase, upcase1): New static inline functions.
13670 (DOWNCASE, UPCASE1): Reimplement using these functions.
13671 This avoids undefined behavior in expressions like
13672 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13673 from race conditions in accessing the global variables
13674 case_temp1 and case_temp2.
13675 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13676 * lisp.h (case_temp1, case_temp2): Remove their decls.
13677 * character.h (ASCII_CHAR_P): Move from here ...
13678 * lisp.h: ... to here, so that the inline functions mentioned
13679 above can use them.
13681 * dired.c (directory_files_internal_unwind): Now static.
13683 * fileio.c (file_name_as_directory, directory_file_name):
13684 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13686 (file_name_as_directory): Use const pointers when appropriate.
13687 (Fexpand_file_name): Likewise. In particular, newdir might
13688 point at constant storage, so make it a const pointer.
13689 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
13690 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13692 (Fset_file_times, Finsert_file_contents, auto_save_error):
13693 Rename locals to avoid shadowing.
13695 * minibuf.c (choose_minibuf_frame_1): Now static.
13696 (Ftry_completion, Fall_completions): Rename or remove locals
13697 to avoid shadowing.
13699 * marker.c (bytepos_to_charpos): Remove; unused.
13701 * lisp.h (verify_bytepos, count_markers): New decls,
13702 so that gcc does not warn that these functions aren't declared.
13704 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13705 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
13706 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
13707 (copy_text): Remove unused local var.
13709 * filelock.c (within_one_second): Now static.
13710 (lock_file_1): Rename local to avoid shadowing.
13712 * buffer.c (fix_overlays_before): Mark locals as initialized.
13713 (fix_start_end_in_overlays): Likewise. This function should be
13714 simplified by using pointers-to-pointers, but that's a different
13716 (switch_to_buffer_1): Now static.
13717 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13718 (report_overlay_modification): Rename locals to avoid shadowing.
13720 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
13721 Fix pointer signedness issue.
13722 (sys_subshell): Mark local as volatile if checking for lint,
13723 to suppress a gcc -Wclobbered warning that does not seem to be right.
13724 (MAXPATHLEN): Define only if needed.
13726 * process.c (serial_open, serial_configure): Move decls from here ...
13727 * systty.h: ... to here, so that they can be checked.
13729 * fns.c (get_random, seed_random): Move extern decls from here ...
13730 * lisp.h: ... to here, so that they can be checked.
13732 * sysdep.c (reset_io): Now static.
13733 (wait_for_termination_signal): Remove; unused.
13735 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13736 (copy_keymap_item, append_key, push_text_char_description):
13738 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
13739 (DENSE_TABLE_SIZE): Remove; unused.
13740 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13741 (describe_map_tree):
13742 Rename locals to avoid shadowing.
13744 * keyboard.c: Declare functions static if they are not used elsewhere.
13745 (echo_char, echo_dash, cmd_error, top_level_2):
13746 (poll_for_input, handle_async_input): Now static.
13747 (read_char, kbd_buffer_get_event, make_lispy_position):
13748 (make_lispy_event, make_lispy_movement, apply_modifiers):
13749 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13750 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13751 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
13752 (read_key_sequence, read_char): Mark locals as initialized.
13753 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
13755 * keyboard.h (make_ctrl_char): New decl.
13756 (mark_kboards): Move decl here ...
13757 * alloc.c (mark_kboards): ... from here.
13759 * lisp.h (force_auto_save_soon): New decl.
13761 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
13762 (DEFINE_DUMMY_FUNCTION): New macro.
13763 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13765 (main): Add casts to avoid warnings
13766 if GCC considers string literals to be constants.
13768 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13770 * dbusbind.c: Pointer signedness fixes.
13771 (xd_signature, xd_append_arg, xd_initialize):
13772 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13773 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13774 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13775 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13777 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13778 if GCC considers string literals to be constants.
13779 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
13781 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13783 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13784 (print_preprocess, print_object): New macro to fix last change.
13786 * print.c (print_preprocess): Don't forget font objects.
13788 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
13790 * emacs.c (USAGE3): Doc fixes.
13792 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13794 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13797 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
13799 * lisp.h (VWindow_system, Qfile_name_history):
13800 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13801 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13802 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13804 * w32select.c: Don't #include "keyboard.h".
13805 (run_protected): Add extern declaration for waiting_for_input.
13807 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13808 * w32console.c (detect_input_pending, read_input_pending)
13809 (encode_terminal_code):
13810 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13811 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13812 (w32_system_caret_y, Qfile_name_history):
13813 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13814 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13815 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13816 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13817 * w32proc.c (Qlocal, report_file_error):
13818 * w32term.c (Vwindow_system, updating_frame):
13819 * w32uniscribe.c (initialized, uniscribe_font_driver):
13820 Remove unneeded extern declarations.
13822 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
13824 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
13826 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
13828 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13829 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13830 These macros can no longer be used for assignment.
13832 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13833 Assign struct members directly, instead of using BUF_BEGV etc.
13834 (record_buffer_markers, fetch_buffer_markers): New functions for
13835 recording and fetching special buffer markers.
13836 (set_buffer_internal_1, set_buffer_temp): Use them.
13838 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13840 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13842 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13843 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13845 * xdisp.c (hscroll_window_tree):
13846 (reconsider_clip_changes): Use PT instead of BUF_PT.
13848 2011-03-13 Eli Zaretskii <eliz@gnu.org>
13850 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13851 $(EMACS_ROOT)/lib/intprops.h.
13853 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13855 Fix more problems found by GCC 4.5.2's static checks.
13857 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13858 to unsigned char * to avoid compiler diagnostic.
13859 (xg_free_frame_widgets): Make it clear that a local variable is
13860 needed only if USE_GTK_TOOLTIP.
13861 (gdk_window_get_screen): Make it clear that this macro is needed
13862 only if USE_GTK_TOOLTIP.
13863 (int_gtk_range_get_value): New function, which avoids a diagnostic
13864 from gcc -Wbad-function-cast.
13865 (xg_set_toolkit_scroll_bar_thumb): Use it.
13866 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13867 diagnostic from gcc -Wbad-function-cast.
13868 (get_utf8_string, xg_get_file_with_chooser):
13869 Rename locals to avoid shadowing.
13870 (create_dialog): Move locals to avoid shadowing.
13872 * xgselect.c (xg_select): Remove unused var.
13874 * image.c (four_corners_best): Mark locals as initialized.
13875 (gif_load): Initialize transparent_p to zero (Bug#8238).
13876 Mark another local as initialized.
13877 (my_png_error, my_error_exit): Mark with NO_RETURN.
13879 * image.c (clear_image_cache): Now static.
13880 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
13881 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
13882 (x_edge_detection): Remove unnecessary cast that
13883 gcc -Wbad-function-cast diagnoses.
13884 (gif_load): Fix pointer signedness.
13885 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13886 (jpeg_load, gif_load): Rename locals to avoid shadowing.
13888 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
13890 Improve quality of tests for time stamp overflow.
13891 For example, without this patch (encode-time 0 0 0 1 1
13892 1152921504606846976) returns the obviously-bogus value (-948597
13893 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13894 reports time overflow. See
13895 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
13896 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13897 * editfns.c: Include limits.h and intprops.h.
13898 (TIME_T_MIN, TIME_T_MAX): New macros.
13899 (time_overflow): Move earlier, to before first use.
13900 (hi_time, lo_time): New functions, for an accurate test for
13901 out-of-range times.
13902 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13903 (Fget_internal_run_time): Don't assume time_t fits in int.
13904 (make_time): Use list2 instead of Fcons twice.
13905 (Fdecode_time): More accurate test for out-of-range times.
13906 (check_tm_member): New function.
13907 (Fencode_time): Use it, to test for out-of-range times.
13908 (lisp_time_argument): Don't rely on undefined left-shift and
13909 right-shift behavior when checking for time stamp overflow.
13911 * editfns.c (time_overflow): New function, refactoring common code.
13912 (Fformat_time_string, Fdecode_time, Fencode_time):
13913 (Fcurrent_time_string): Use it.
13915 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13916 * dired.c (make_time): Move to ...
13917 * editfns.c (make_time): ... here.
13918 * systime.h: Note the move.
13920 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
13922 * fringe.c (update_window_fringes): Remove unused variables.
13924 * unexmacosx.c (copy_data_segment): Also copy __got section.
13927 2011-03-12 Eli Zaretskii <eliz@gnu.org>
13929 * termcap.c [MSDOS]: Include "msdos.h".
13930 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13931 Constify `char *' arguments and their references according to
13932 prototypes in tparam.h.
13934 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
13936 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13937 Adapt all references accordingly.
13939 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13941 2011-03-11 Tom Tromey <tromey@redhat.com>
13943 * buffer.c (syms_of_buffer): Remove obsolete comment.
13945 2011-03-11 Eli Zaretskii <eliz@gnu.org>
13947 * termhooks.h (encode_terminal_code): Declare prototype.
13949 * msdos.c (encode_terminal_code): Don't declare prototype.
13951 * term.c (encode_terminal_code): Now external again, used by
13952 w32console.c and msdos.c.
13954 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13955 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
13957 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
13959 Fix some minor problems found by GCC 4.5.2's static checks.
13961 * fringe.c (update_window_fringes): Mark locals as initialized
13963 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
13965 * alloc.c (mark_fringe_data): Move decl from here ...
13966 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13967 to check its interface.
13968 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13970 * fontset.c (free_realized_fontset): Now static.
13971 (Fset_fontset_font): Rename local to avoid shadowing.
13972 (fontset_font): Mark local as initialized.
13973 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
13975 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13977 * xselect.c (x_disown_buffer_selections): Remove; not used.
13978 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
13979 (x_own_selection, Fx_disown_selection_internal): Rename locals
13980 to avoid shadowing.
13981 (x_handle_dnd_message): Remove local to avoid shadowing.
13983 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13984 so that the caller can use some name other than gcpro1.
13985 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
13986 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13987 (Fx_backspace_delete_keys_p):
13988 Use them to avoid shadowing, and rename vars to avoid shadowing.
13989 (x_decode_color, x_set_name, x_window): Now static.
13990 (Fx_create_frame): Add braces to silence GCC warning.
13991 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
13992 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13993 Remove unused locals.
13994 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13995 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13996 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13999 * xterm.h (x_mouse_leave): New decl.
14001 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14002 Remove unused functions.
14003 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14004 (x_calc_absolute_position): Now static.
14005 (XTread_socket): Don't define label "out" unless it's used.
14006 Don't declare local "event" unless it's used.
14007 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14008 unless they are used.
14009 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14010 (x_fatal_error_signal): Remove; not used.
14011 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14012 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14013 (x_error_catcher, x_connection_closed, x_error_handler):
14014 (x_error_quitter, xembed_send_message, x_iconify_frame):
14015 (my_log_handler): Rename locals to avoid shadowing.
14016 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
14017 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
14019 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14020 Rename or move locals to avoid shadowing.
14021 (tty_defined_color, merge_face_heights): Now static.
14022 (free_realized_faces_for_fontset): Remove; not used.
14023 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14024 does not deduce is never used uninitialized.
14025 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14026 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
14028 * terminal.c (store_terminal_param): Now static.
14030 * xmenu.c (menu_highlight_callback): Now static.
14031 (set_frame_menubar): Remove unused local.
14032 (xmenu_show): Rename parameter to avoid shadowing.
14033 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14034 since they might point to immutable storage.
14035 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14036 since it's unused otherwise.
14038 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
14039 Add a FIXME, since the code still doesn't look right. (Bug#8215)
14040 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14041 avoids a gcc -Wuninitialized diagnostic.
14042 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
14043 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14044 does not deduce are never used uninitialized.
14046 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14048 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
14049 * window.c (window_loop, size_window):
14050 (run_window_configuration_change_hook, enlarge_window): Likewise.
14052 * window.c (display_buffer): Now static.
14053 (size_window): Mark variables that gcc -Wuninitialized
14054 does not deduce are never used uninitialized.
14055 * window.h (check_all_windows): New decl, to forestall
14056 gcc -Wmissing-prototypes diagnostic.
14057 * dispextern.h (bidi_dump_cached_states): Likewise.
14059 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14061 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
14062 Include <limits.h>.
14063 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14064 and to avoid gcc -Wuninitialized warning.
14065 (load_charset_map): Mark variables that gcc -Wuninitialized
14066 does not deduce are never used uninitialized.
14067 (load_charset): Abort instead of using uninitialized var (Bug#8229).
14069 * coding.c (coding_set_source, coding_set_destination):
14070 Use "else { /* comment */ }" rather than "else /* comment */;"
14071 for clarity, and to avoid gcc -Wempty-body warning.
14072 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14073 a block, when the outer 'i' will do.
14074 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14075 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14076 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14077 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14078 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14079 Rename locals to avoid shadowing.
14080 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
14081 * coding.c (emacs_mule_char, encode_invocation_designation):
14082 Now static, since they're not used elsewhere.
14083 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
14084 (decode_coding_object, encode_coding_object, detect_coding_system):
14085 (decode_coding_emacs_mule): Mark variables that gcc
14086 -Wuninitialized does not deduce are never used uninitialized.
14087 (detect_coding_iso_2022): Initialize a local variable that might
14088 be used uninitialized. Leave a FIXME because it's not clear that
14089 this initialization is needed. (Bug#8211)
14090 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14091 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14092 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14093 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14094 Remove unused macros.
14096 * category.c (hash_get_category_set): Remove unused local var.
14097 (copy_category_table): Now static, since it's not used elsewhere.
14098 * character.c (string_count_byte8): Likewise.
14100 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14101 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14103 * chartab.c (copy_sub_char_table): Now static, since it's not used
14105 (sub_char_table_ref_and_range, char_table_ref_and_range):
14106 Rename locals to avoid shadowing.
14107 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
14109 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
14110 (BIDI_BOB): Remove unused macro.
14112 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14113 deduce are never used uninitialized.
14114 * term.c (encode_terminal_code): Likewise.
14116 * term.c (encode_terminal_code): Now static. Remove unused local.
14118 * tparam.h: New file.
14119 * term.c, tparam.h: Include it.
14120 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14121 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14122 Move these decls to tparam.h, and make them agree with what
14123 is actually in tparam.c. The previous trick of using incompatible
14124 decls in different modules does not conform to the C standard.
14125 All callers of tparam changed to use tparam's actual API.
14126 * tparam.c (tparam1, tparam, tgoto):
14127 Use const pointers where appropriate.
14129 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14130 * cm.h (struct cm): Likewise.
14131 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14132 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14133 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14134 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14135 (turn_on_face, init_tty): Likewise.
14136 * termchar.h (struct tty_display_info): Likewise.
14138 * term.c (term_mouse_position): Rename local to avoid shadowing.
14140 * alloc.c (mark_ttys): Move decl from here ...
14141 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14143 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14145 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14147 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
14149 * search.c (compile_pattern_1): Remove argument regp, unused since
14150 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14151 (compile_pattern): Don't pass it.
14153 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14155 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14156 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14158 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14160 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14162 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14163 gdk_window_get_screen, gdk_window_get_geometry,
14164 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14165 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14166 (xg_get_pixbuf_from_pixmap): New function.
14167 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14168 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14169 Call xg_get_pixbuf_from_pixmap instead of
14170 gdk_pixbuf_get_from_drawable.
14171 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14172 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14173 (xg_check_special_colors): Use GtkStyleContext and its functions
14175 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14176 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14177 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
14178 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14179 Call gtk_widget_get_preferred_size.
14180 (xg_frame_resized): gdk_window_get_geometry only takes 5
14182 (xg_win_to_widget, xg_event_is_for_menubar):
14183 Call gdk_x11_window_lookup_for_display.
14184 (xg_set_widget_bg): New function.
14185 (delete_cb): New function.
14186 (xg_create_frame_widgets): Connect delete-event to delete_cb.
14187 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
14188 (xg_set_background_color): Call xg_set_widget_bg.
14189 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14190 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14191 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14192 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14194 (update_frame_tool_bar): Call gtk_widget_hide.
14195 (xg_initialize): Use GDK_KEY_g.
14197 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14199 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14201 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14202 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14203 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14205 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
14207 * w32xfns.c (select_palette): Check success of RealizePalette against
14208 GDI_ERROR, not zero.
14210 See ChangeLog.11 for earlier changes.
14212 ;; Local Variables:
14216 Copyright (C) 2011-2012 Free Software Foundation, Inc.
14218 This file is part of GNU Emacs.
14220 GNU Emacs is free software: you can redistribute it and/or modify
14221 it under the terms of the GNU General Public License as published by
14222 the Free Software Foundation, either version 3 of the License, or
14223 (at your option) any later version.
14225 GNU Emacs is distributed in the hope that it will be useful,
14226 but WITHOUT ANY WARRANTY; without even the implied warranty of
14227 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14228 GNU General Public License for more details.
14230 You should have received a copy of the GNU General Public License
14231 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.