Fix bug #9221 with resource allocation under word-wrap.
[bpt/emacs.git] / src / ChangeLog
1 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2
3 *xdisp.c (display_line): Release buffer allocated for shelved bidi
4 cache. (Bug#9221)
5
6 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7 amount allocated this far in `bidi_cache_total_alloc'.
8 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
9 non-zero, only free the data buffer without restoring the cache
10 contents. All callers changed.
11
12 * dispextern.h (bidi_unshelve_cache): Update prototype.
13
14 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
15 (move_it_in_display_line, move_it_to)
16 (move_it_vertically_backward, move_it_by_lines): Replace the call
17 to xfree to an equivalent call to bidi_unshelve_cache.
18 (move_it_in_display_line_to): Fix logic of returning
19 MOVE_POS_MATCH_OR_ZV in the bidi case.
20
21 2011-07-24 Eli Zaretskii <eliz@gnu.org>
22
23 * xdisp.c (compute_display_string_pos): Fix logic of caching
24 previous display string position. Initialize cached_prev_pos to
25 -1. Fixes slow-down at the beginning of a buffer.
26
27 2011-07-23 Eli Zaretskii <eliz@gnu.org>
28
29 * xdisp.c (move_it_in_display_line_to): Record the best matching
30 position for TO_CHARPOS while scanning the line, and restore it on
31 exit if none of the characters scanned was an exact match. Fixes
32 vertical-motion and pos-visible-in-window-p when exact match is
33 impossible due to invisible text, and the lines are truncated.
34
35 2011-07-22 Eli Zaretskii <eliz@gnu.org>
36
37 * xdisp.c (compute_stop_pos_backwards): New function.
38 (handle_stop_backwards): Revert last change.
39 (next_element_from_buffer): Call compute_stop_pos_backwards to
40 find a suitable prev_stop when we find ourselves before
41 base_level_stop. Remove the funky search for 1000 character
42 positions back.
43
44 2011-07-19 Eli Zaretskii <eliz@gnu.org>
45
46 Fix a significant slow-down of vertical-motion when leaning on C-n
47 or C-p in a fontified buffer.
48 * xdisp.c (reseat): Don't look for prev_stop, as that could mean a
49 very long run.
50 (next_element_from_buffer): When iterator oversteps prev_pos
51 backwards, don't search for a new prev_stop more than 1000
52 characters back.
53 (handle_stop_backwards): Don't assume that CHARPOS is necessarily
54 a stop_pos.
55 (compute_display_string_pos): Check also BUF_OVERLAY_MODIFF for a
56 match, when testing the cached display string position for
57 applicability.
58
59 2011-07-16 Eli Zaretskii <eliz@gnu.org>
60
61 * xdisp.c <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>:
62 Cache for last found display string position.
63 (compute_display_string_pos): Return the cached position if asked
64 about the same buffer.
65
66 2011-07-14 Eli Zaretskii <eliz@gnu.org>
67
68 * bidi.c (bidi_cache_fetch_state, bidi_cache_search)
69 (bidi_cache_find_level_change, bidi_cache_ensure_space)
70 (bidi_cache_iterator_state, bidi_cache_find)
71 (bidi_find_other_level_edge, bidi_cache_start_stack): All
72 variables related to cache indices are now EMACS_INT.
73
74 2011-07-09 Eli Zaretskii <eliz@gnu.org>
75
76 * bidi.c (bidi_fetch_char): Fix the type of `len' according to
77 what STRING_CHAR_AND_LENGTH expects.
78
79 * xdisp.c (move_it_in_display_line_to): Record prev_method and
80 prev_pos immediately before the call to set_iterator_to_next.
81 Fixes cursor motion in bidi-reordered lines with stretch glyphs
82 and strings displayed in margins. (Bug#8133) (Bug#8867)
83 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
84 TO_CHARPOS.
85 (pos_visible_p): Support positions in bidi-reordered lines. Save
86 and restore bidi cache.
87
88 2011-07-08 Eli Zaretskii <eliz@gnu.org>
89
90 * xdisp.c (move_it_in_display_line_to): If iterator ended up at
91 EOL, but we never saw any buffer positions smaller than
92 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
93 motion in bidi-reordered lines.
94
95 2011-07-07 Eli Zaretskii <eliz@gnu.org>
96
97 * xdisp.c (find_row_edges): If ROW->start.pos gives position
98 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
99
100 2011-07-05 Eli Zaretskii <eliz@gnu.org>
101
102 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
103 cache around display iteration.
104
105 * window.c (Fwindow_end, window_scroll_pixel_based)
106 (displayed_window_lines, Frecenter): Save and restore the bidi
107 cache around display iteration.
108
109 * bidi.c (bidi_unshelve_cache): Ensure we have enough space before
110 restoring the shelved cache.
111 (bidi_cache_ensure_space): Don't assume the required size is just
112 one BIDI_CACHE_CHUNK away.
113
114 * xdisp.c (back_to_previous_visible_line_start, reseat_1)
115 (init_iterator): Empty the bidi cache "stack".
116
117 2011-07-03 Eli Zaretskii <eliz@gnu.org>
118
119 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): New functions.
120
121 * dispextern.h (bidi_shelve_cache, bidi_unshelve_cache): Declare
122 prototypes.
123
124 * xdisp.c (SAVE_IT, RESTORE_IT): New macros.
125 (pos_visible_p, face_before_or_after_it_pos)
126 (back_to_previous_visible_line_start)
127 (move_it_in_display_line_to, move_it_in_display_line)
128 (move_it_to, move_it_vertically_backward, move_it_by_lines)
129 (try_scrolling, redisplay_window, display_line): Use them when
130 saving a temporary copy of the iterator and restoring it back.
131
132 2011-07-02 Eli Zaretskii <eliz@gnu.org>
133
134 * xdisp.c (reseat_1): Call bidi_init_it to resync the bidi
135 iterator with IT's position. (Bug#7616)
136 (handle_stop, back_to_previous_visible_line_start, reseat_1):
137 Reset the from_disp_prop_p flag.
138
139 * bidi.c (bidi_cache_search): Don't assume bidi_cache_last_idx is
140 always valid if bidi_cache_idx is valid.
141 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
142 is valid if it's going to be used.
143
144 * dispextern.h (struct iterator_stack_entry, struct it): New
145 member from_disp_prop_p.
146
147 * xdisp.c (push_it, pop_it): Save and restore from_disp_prop_p.
148 (handle_single_display_spec, push_display_prop): Set the
149 from_disp_prop_p flag.
150 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
151 (pop_it): Call iterate_out_of_display_property only if we are
152 popping after iteration over a string that came from a display
153 property. Fix a typo in popping stretch info. Add an assertion
154 for verifying that the iterator position is in sync with the bidi
155 iterator.
156 (handle_single_display_spec, get_overlay_strings_1)
157 (push_display_prop): Fix initialization of paragraph direction for
158 string when that of the parent object is not yet determined.
159
160 2011-07-01 Eli Zaretskii <eliz@gnu.org>
161
162 * dispextern.h (struct bidi_string_data): New member `unibyte'.
163
164 * xdisp.c (handle_single_display_spec, next_overlay_string)
165 (get_overlay_strings_1, reseat_1, reseat_to_string)
166 (push_display_prop): Set up the `unibyte' member of bidi_it.string
167 correctly. Don't assume unibyte strings are not bidi-reordered.
168 (compute_display_string_pos)
169 (compute_display_string_end): Fix handling the case of C string.
170
171 * bidi.c (bidi_count_bytes, bidi_char_at_pos): Accept an
172 additional argument UNIBYTE, and support unibyte strings. All
173 callers changed.
174 (bidi_fetch_char): Support unibyte strings.
175
176 2011-06-25 Eli Zaretskii <eliz@gnu.org>
177
178 * xdisp.c (set_iterator_to_next, get_visually_first_element): Use
179 it->bidi_it.string.schars rather than it->string_nchars when
180 testing whether we're beyond string end, because string_nchars is
181 zero for strings that come from overlays and display properties.
182
183 * bidi.c (bidi_cache_iterator_state): Fix a bug with testing
184 character positions against the cached range, when we use a
185 stacked cache.
186
187 * xdisp.c (push_it, pop_it): Save and restore it.
188
189 * dispextern.h (struct iterator_stack_entry): New member
190 paragraph_embedding.
191
192 * xdisp.c (handle_single_display_spec, next_overlay_string)
193 (get_overlay_strings_1, push_display_prop): Set up the bidi
194 iterator for displaying display or overlay strings.
195 (forward_to_next_line_start): Don't use the shortcut if
196 bidi-iterating.
197 (back_to_previous_visible_line_start): If handle_display_prop
198 pushed the iterator stack, restore the internal state of the bidi
199 iterator by calling bidi_pop_it same number of times.
200 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
201 and we are bidi-iterating, don't decrement the iterator position;
202 instead, set the first_elt flag in the bidi iterator, to produce
203 the same effect.
204 (reseat_1): Remove redundant setting of string_from_display_prop_p.
205 (push_display_prop): xassert that we are iterating a buffer.
206
207 * bidi.c (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
208
209 2011-06-24 Eli Zaretskii <eliz@gnu.org>
210
211 * xdisp.c (push_it, pop_it): Save and restore the state of the
212 bidi iterator. Save and restore the bidi_p flag.
213 (pop_it): Iterate out of display property for string iteration as
214 well.
215 (iterate_out_of_display_property): Support iteration over strings.
216 (handle_single_display_spec): Set up it->bidi_it for iteration
217 over a display string, and call bidi_init_it.
218
219 * dispextern.h (struct iterator_stack_entry): New member bidi_p.
220 (struct it): Member bidi_p is now a bit field 1 bit wide.
221
222 2011-06-23 Eli Zaretskii <eliz@gnu.org>
223
224 * dispextern.h (bidi_push_it, bidi_pop_it): Add prototypes.
225
226 * bidi.c (bidi_push_it, bidi_pop_it): New functions.
227 (bidi_initialize): Initialize the bidi cache start stack pointer.
228 (bidi_cache_ensure_space): New function, refactored from part of
229 bidi_cache_iterator_state.
230
231 2011-06-18 Eli Zaretskii <eliz@gnu.org>
232
233 * xdisp.c (tool_bar_lines_needed, redisplay_tool_bar)
234 (display_menu_bar): Force left-to-right direction. Add a FIXME
235 comment for making that be controlled by a user option.
236
237 * bidi.c (bidi_move_to_visually_next): GCPRO the Lisp string we
238 are iterating.
239
240 * term.c (produce_glyphs): Add IT_GLYPHLESS to the values of
241 it->what accepted by the xassert. Fixes a gratuitous crash in an
242 Emacs built with -DXASSERTS.
243
244 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
245 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
246 and vector-like objects.
247
248 * xdisp.c (face_before_or_after_it_pos): Support bidi iteration.
249 (next_element_from_c_string): Handle the case of the first string
250 character that is not the first one in the visual order.
251 (get_visually_first_element): New function, refactored from common
252 parts of next_element_from_buffer, next_element_from_string, and
253 next_element_from_c_string.
254
255 2011-06-16 Eli Zaretskii <eliz@gnu.org>
256
257 * xdisp.c (init_iterator): Don't initialize it->bidi_p for strings
258 here.
259 (reseat_to_string): Initialize it->bidi_p for strings here.
260 (next_element_from_string, next_element_from_c_string)
261 (next_element_from_buffer): Add xassert's for correspondence
262 between IT's object being iterated and it->bidi_it.string
263 structure.
264
265 * bidi.c (bidi_level_of_next_char): Fix the logic for looking up
266 the sentinel state in the cache.
267
268 2011-06-13 Eli Zaretskii <eliz@gnu.org>
269
270 * xdisp.c (compute_display_string_pos)
271 (compute_display_string_end, reseat_to_string): Don't assume
272 it->bidi_it.string.s always points to string.lstring's data.
273
274 * bidi.c (bidi_fetch_char, bidi_paragraph_init)
275 (bidi_resolve_explicit_1, bidi_resolve_explicit)
276 (bidi_resolve_weak, bidi_level_of_next_char): Don't assume
277 string.s always points to string.lstring's data.
278
279 2011-06-11 Eli Zaretskii <eliz@gnu.org>
280
281 * xdisp.c (set_iterator_to_next): Advance string position
282 correctly when padding it with blanks.
283
284 2011-06-11 Eli Zaretskii <eliz@gnu.org>
285
286 * xdisp.c (next_element_from_buffer): Improve commentary for when
287 the iterator is before prev_stop.
288 (init_iterator): Initialize bidi_p from the default value of
289 bidi-display-reordering, not from buffer-local value. Use the
290 buffer-local value only if initializing for buffer iteration.
291 (handle_invisible_prop): Support invisible properties on strings
292 that are being bidi-reordered.
293 (reseat_to_string): Enable bidi-related code.
294 (set_iterator_to_next): Support bidi reordering of C strings and
295 Lisp strings.
296 (next_element_from_string): Support bidi reordering of Lisp
297 strings.
298 (handle_stop_backwards): Support Lisp strings as well.
299 (display_mode_line, display_mode_element): Temporarily force L2R
300 paragraph direction.
301 (display_string): Support display of R2L glyph rows. Use
302 IT_STRING_CHARPOS when displaying from a Lisp string.
303
304 2011-06-10 Eli Zaretskii <eliz@gnu.org>
305
306 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
307 itb.string.lstring.
308 (compute_display_string_pos, compute_display_string_end):
309 Fix calculation of the object to scan. Fixes an error when using
310 arrow keys.
311 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
312 base_level_stop; instead, set base_level_stop to BEGV. Fixes
313 crashes in vertical-motion.
314
315 2011-06-09 Eli Zaretskii <eliz@gnu.org>
316
317 * xdisp.c (compute_display_string_pos): First arg is now struct
318 `text_pos *'; all callers changed. Support display properties on
319 Lisp strings.
320 (compute_display_string_end): Support display properties on Lisp
321 strings.
322 (init_iterator, reseat_1, reseat_to_string): Initialize the
323 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
324 when iterating on a string not from display properties).
325
326 * bidi.c (bidi_fetch_char): Support strings with display
327 properties.
328
329 * dispextern.h (struct bidi_string_data): New member bufpos.
330 (compute_display_string_pos): Update prototype.
331
332 2011-06-09 Eli Zaretskii <eliz@gnu.org>
333
334 * bidi.c (bidi_level_of_next_char): Allow the sentinel "position"
335 to pass the test for valid cached positions.
336
337 * xdisp.c (init_iterator): Call bidi_init_it only of a valid
338 buffer position was specified. Initialize paragraph_embedding to
339 L2R.
340 (reseat_to_string): Initialize the bidi iterator (for now ifdef'ed
341 out).
342 (display_string): If we need to ignore text properties of
343 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
344 original value of -1 will not work with bidi.)
345
346 * dispextern.h (struct bidi_string_data): New member lstring.
347
348 2011-06-09 Eli Zaretskii <eliz@gnu.org>
349
350 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
351 itb.string.s to NULL (avoids a crash in bidi_paragraph_init).
352
353 2011-06-08 Eli Zaretskii <eliz@gnu.org>
354
355 * bidi.c (bidi_paragraph_info): Delete unused struct.
356 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
357 (bidi_cache_start): New variable.
358 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
359 to zero.
360 (bidi_cache_fetch_state, bidi_cache_search)
361 (bidi_cache_find_level_change, bidi_cache_iterator_state)
362 (bidi_cache_find, bidi_peek_at_next_level)
363 (bidi_level_of_next_char, bidi_find_other_level_edge)
364 (bidi_move_to_visually_next): Compare cache index with
365 bidi_cache_start rather than with zero.
366 (bidi_fetch_char): Accept new argument STRING; all callers
367 changed. Support iteration over a string.
368 (bidi_paragraph_init, bidi_resolve_explicit_1)
369 (bidi_resolve_explicit, bidi_resolve_weak)
370 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
371 iteration over a string.
372 (bidi_set_sor_type, bidi_resolve_explicit_1)
373 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
374 can now be zero (for strings); special values 0 and -1 were
375 changed to -1 and -2, respectively.
376 (bidi_char_at_pos): New function.
377 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
378 Call it instead of FETCH_MULTIBYTE_CHAR.
379 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
380 initialized to valid values.
381 (bidi_init_it): Don't initialize charpos and bytepos with invalid
382 values.
383
384 * xdisp.c (compute_display_string_pos)
385 (compute_display_string_end): Accept additional argument STRING.
386 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
387 (reseat_to_string): Initialize bidi_it->string.s and
388 bidi_it->string.schars.
389
390 * dispextern.h (struct bidi_string_data): New structure.
391 (struct bidi_it): New member `string'. Make flag members be 1-bit
392 fields, and put them last in the struct.
393 (compute_display_string_pos, compute_display_string_end): Update
394 prototypes.
395
396 2011-06-04 Eli Zaretskii <eliz@gnu.org>
397
398 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
399
400 2011-06-03 Eli Zaretskii <eliz@gnu.org>
401
402 * bidi.c (bidi_fetch_char_advance): Remove unused and
403 unimplemented function.
404
405 2011-05-28 Eli Zaretskii <eliz@gnu.org>
406
407 * xdisp.c (set_cursor_from_row): Set start and stop points
408 according to the row's direction when priming the loop that looks
409 for the glyph on which to display cursor.
410 (single_display_spec_intangible_p): Function deleted.
411 (display_prop_intangible_p): Reimplement to call
412 handle_display_spec instead of single_display_spec_intangible_p.
413 Accept 3 additional arguments needed by handle_display_spec. This
414 fixes incorrect cursor motion across display property with complex
415 values: lists, `(when COND...)' forms, etc.
416 (single_display_spec_string_p): Support property values that are
417 lists with the argument STRING its top-level element.
418 (display_prop_string_p): Fix the condition for processing a
419 property that is a list to be consistent with handle_display_spec.
420
421 * keyboard.c (adjust_point_for_property): Adjust the call to
422 display_prop_intangible_p to its new signature.
423
424 * dispextern.h (display_prop_intangible_p): Adjust prototype.
425
426 2011-05-21 Eli Zaretskii <eliz@gnu.org>
427
428 * xdisp.c (handle_display_spec): New function, refactored from the
429 last portion of handle_display_prop.
430 (compute_display_string_pos): Accept additional argument
431 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
432 value of a `display' property is a "replacing spec".
433 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
434 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
435 the display property, but just return a value indicating whether
436 the display property will replace the characters it covers.
437 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
438 frame_window_p members of struct bidi_it.
439
440 * bidi.c (bidi_fetch_char): Accept additional argument
441 FRAME_WINDOW_P and pass it to compute_display_string_pos. All
442 callers changed.
443 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
444 it to initialize the frame_window_p member of struct bidi_it.
445
446 * dispextern.h (struct bidi_it): New member frame_window_p.
447 (bidi_init_it, compute_display_string_pos): Update prototypes.
448
449 2011-05-14 Eli Zaretskii <eliz@gnu.org>
450
451 * xdisp.c (compute_display_string_pos): Non-trivial implementation.
452 (compute_display_string_end): New function.
453 (push_it): Accept second argument POSITION, where pop_it should
454 jump to continue iteration.
455
456 * dispextern.h (compute_display_string_end): Declare prototype.
457
458 * bidi.c (bidi_resolve_explicit_1): Use ZV for disp_pos.
459 (bidi_fetch_char): Implement support for runs of characters
460 covered by display strings.
461
462 * bidi.c (bidi_fetch_char): Accept also character position
463 corresponding to BYTEPOS. DISP_POS is now a character position,
464 not a byte position. All callers changed.
465 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
466 (bidi_resolve_explicit, bidi_resolve_weak)
467 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
468 bidi_it->nchars is non-positive.
469 (bidi_level_of_next_char): Don't try to lookup the cache for the
470 next/previous character if nothing is cached there yet, or if we
471 were just reseat()'ed to a new position.
472 (bidi_paragraph_init, bidi_resolve_explicit_1)
473 (bidi_level_of_next_char): Fix arguments in the calls to
474 bidi_fetch_char.
475
476 2011-05-10 Eli Zaretskii <eliz@gnu.org>
477
478 * xdisp.c (compute_display_string_pos): New function.
479 (reseat_1): Initialize bidi_it.disp_pos.
480
481 * bidi.c (bidi_copy_it): Use offsetof.
482 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
483 (bidi_cache_search, bidi_cache_iterator_state)
484 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
485 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
486 character positions inside a run of characters covered by a
487 display string.
488 (bidi_paragraph_init, bidi_resolve_explicit_1)
489 (bidi_level_of_next_char): Call bidi_fetch_char and
490 bidi_fetch_char_advance instead of FETCH_CHAR and
491 FETCH_CHAR_ADVANCE.
492 (bidi_init_it): Initialize new members.
493 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
494 definitions.
495 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
496 instead of using explicit *_CHAR codes.
497 (bidi_resolve_explicit, bidi_resolve_weak): Use
498 FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
499 bidirectional text is supported only in multibyte buffers.
500
501 * dispextern.h (struct bidi_it): New members nchars and disp_pos.
502 ch_len is now EMACS_INT.
503 (compute_display_string_pos): Declare prototype.
504
505 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
506
507 * w32menu.c (set_frame_menubar): Fix submenu allocation.
508
509 2011-05-07 Eli Zaretskii <eliz@gnu.org>
510
511 * w32console.c (Fset_screen_color): Doc fix.
512 (Fget_screen_color): New function.
513 (syms_of_ntterm): Defsubr it.
514
515 * callproc.c (call_process_cleanup): Don't close and unlink the
516 temporary file if Fcall_process didn't create it in the first
517 place.
518 (Fcall_process): Don't create tempfile if stdout of the child
519 process will be redirected to a file specified with `:file'.
520 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
521 cue to call_process_cleanup not to close that handle.
522
523 2011-05-07 Ben Key <bkey76@gmail.com>
524
525 * makefile.w32-in: The bootstrap-temacs rule now makes use of
526 one of two shell specific rules, either bootstrap-temacs-CMD or
527 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
528 to the previous implementation of the bootstrap-temacs rule.
529 The bootstrap-temacs-CMD rule is similar to the previous
530 implementation of the bootstrap-temacs rule except that it
531 makes use of the ESC_CFLAGS variable instead of the CFLAGS
532 variable.
533
534 These changes, along with some changes to nt/configure.bat,
535 nt/gmake.defs, and nt/nmake.defs, are required to extend my
536 earlier fix to add support for --cflags and --ldflags options
537 that include quotes so that it works whether make uses cmd or
538 sh as the shell.
539
540 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
541
542 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
543 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
544 is a constant.
545 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
546 a string. Handle both cases.
547 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
548 (Fdbus_register_method): Use Qinvalid_function.
549
550 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
551
552 * makefile.w32-in: Update dependencies.
553 (LISP_H): Add inttypes.h and stdin.h.
554 (PROCESS_H): Add unistd.h.
555
556 2011-05-06 Eli Zaretskii <eliz@gnu.org>
557
558 * lread.c: Include limits.h (fixes the MS-Windows build broken by
559 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
560
561 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
562
563 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
564
565 * term.c (vfatal): Remove stray call to va_end.
566 It's not needed and the C Standard doesn't allow it here anyway.
567
568 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
569 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
570
571 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
572 bytes.
573
574 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
575
576 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
577
578 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
579
580 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
581
582 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
583
584 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
585 * charset.c (Fdefine_charset_internal): Don't initialize
586 charset.code_space[15]. The value was garbage, on hosts with
587 32-bit int (Bug#8600).
588
589 * lread.c (read_integer): Be more consistent with string-to-number.
590 Use string_to_number to do the actual conversion; this avoids
591 rounding errors and fixes some other screwups. Without this fix,
592 for example, #x1fffffffffffffff was misread as -2305843009213693952.
593 (digit_to_number): Move earlier, for benefit of read_integer.
594 Return -1 if the digit is out of range for the base, -2 if it is
595 not a digit in any supported base. (Bug#8602)
596
597 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
598
599 * dispnew.c (scrolling_window): Return 1 if we scrolled,
600 to match comment at start of function. This also removes a
601 GCC warning about overflow in a 32+64-bit port.
602
603 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
604
605 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
606 Reported by Stefan Monnier in
607 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
608 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages): Use
609 SYMBOLP-guarded XSYMBOL, not XPNTR.
610
611 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
612 (EMACS_UINTPTR): Likewise, with uintptr_t.
613
614 * lisp.h: Prefer 64-bit EMACS_INT if available.
615 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
616 on 32-bit hosts that have 64-bit int, so that they can access
617 large files.
618 However, temporarily disable this change unless the temporary
619 symbol WIDE_EMACS_INT is defined.
620
621 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
622
623 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
624 This removes an assumption that EMACS_INT and long are the same
625 width as pointers. The assumption is true for Emacs porting targets
626 now, but we want to make other targets possible.
627 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
628 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
629 In the rest of the code, change types of integers that hold casted
630 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
631 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
632 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
633 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
634 No need to cast type when ORing.
635 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
636 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
637 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
638 assume EMACS_INT is the same width as char *.
639 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
640 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
641 Remove no-longer-needed casts.
642 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
643 (xg_tool_bar_help_callback, xg_make_tool_item):
644 Use EMACS_INTPTR to hold an integer
645 that will be cast to void *; this can avoid a GCC warning
646 if EMACS_INT is not the same width as void *.
647 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
648 * xdisp.c (display_echo_area_1, resize_mini_window_1):
649 (current_message_1, set_message_1):
650 Use a local to convert to proper width without a cast.
651 * xmenu.c (dialog_selection_callback): Likewise.
652
653 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
654 Also, don't assume VALBITS / RAND_BITS is less than 5,
655 and don't rely on undefined behavior when shifting a 1 left into
656 the sign bit.
657 * lisp.h (get_random): Change signature to match.
658
659 * lread.c (hash_string): Use size_t, not int, for hash computation.
660 Normally we prefer signed values; but hashing is special, because
661 it's better to use unsigned division on hash table sizes so that
662 the remainder is nonnegative. Also, size_t is the natural width
663 for hashing into memory. The previous code used 'int', which doesn't
664 retain enough info to hash well into very large tables.
665 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
666
667 * dbusbind.c: Don't possibly lose pointer info when converting.
668 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
669 Use XPNTR rather than XHASH, so that the high-order bits of
670 the pointer aren't lost when converting through void *.
671
672 * eval.c (Fautoload): Don't double-shift a pointer.
673
674 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
675
676 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
677
678 * gnutls.c (DEF_GNUTLS_FN):
679 * image.c (DEF_IMGLIB_FN): Make function pointers static.
680
681 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
682
683 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
684 marker. (Bug#8610)
685
686 2011-05-05 Eli Zaretskii <eliz@gnu.org>
687
688 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
689 New version that can reserve upto 2GB of heap space.
690
691 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
692
693 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
694
695 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
696
697 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
698 `gnutls_certificate_set_x509_key_file'.
699
700 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
701
702 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
703 Update dependencies.
704
705 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
706
707 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
708 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
709 Remove unused parameter `fildes'.
710 * process.c (read_process_output, send_process): Don't pass it.
711
712 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
713
714 Fix previous change: the library cache is defined in w32.c.
715 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
716 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
717
718 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
719
720 Implement dynamic loading of GnuTLS on Windows.
721
722 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
723 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
724 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
725 Declare.
726
727 * gnutls.c (Qgnutls_dll): Define.
728 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
729 (gnutls_*): Declare function pointers.
730 (init_gnutls_functions): New function to initialize function pointers.
731 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
732 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
733 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
734 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
735 (emacs_gnutls_write, emacs_gnutls_read)
736 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
737 (Fgnutls_available_p): New function.
738 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
739 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
740 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
741
742 * image.c: Include w32.h.
743 (Vimage_type_cache): Delete.
744 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
745 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
746 (w32_delayed_load): Move to w32.c.
747
748 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
749
750 * w32.c (QCloaded_from, Vlibrary_cache): Define.
751 (w32_delayed_load): Move from image.c. When loading a library, record
752 its filename in the :loaded-from property of the library id.
753 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
754 Initialize and staticpro them.
755 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
756
757 * process.c: Include lisp.h before w32.h, not after.
758 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
759 instead of gnutls_record_check_pending.
760
761 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
762
763 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
764
765 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
766 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
767 as passed in.
768
769 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
770
771 * xterm.c (x_set_frame_alpha): Do not set property on anything
772 else than FRAME_X_OUTER_WINDOW (Bug#8608).
773
774 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
775
776 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
777
778 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
779
780 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
781 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
782 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
783 (gnutls_global_initialized, Qgnutls_bootprop_priority)
784 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
785 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
786 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
787 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
788 (Qgnutls_bootprop_callbacks_verify): Make static.
789
790 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
791
792 * callproc.c: Indentation fixup.
793
794 * sysdep.c (wait_for_termination_1): Make static.
795 (wait_for_termination, interruptible_wait_for_termination): Move
796 after wait_for_termination_1.
797
798 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
799
800 * sysdep.c (interruptible_wait_for_termination): New function
801 which is like wait_for_termination, but allows keyboard
802 interruptions.
803
804 * callproc.c (Fcall_process): Add (:file "file") as an option for
805 the STDOUT buffer.
806 (Fcall_process_region): Ditto.
807
808 2011-04-30 Eli Zaretskii <eliz@gnu.org>
809
810 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
811 rather than `XVECTOR (FOO)->size'.
812
813 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
814 inttypes.h, as a gnulib replacement is used if it not available in
815 system headers.
816
817 2011-04-21 Eli Zaretskii <eliz@gnu.org>
818
819 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
820 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
821 of MOST_POSITIVE_FIXNUM. (Bug#8528)
822
823 * coding.c (coding_alloc_by_realloc): Error out if destination
824 will grow beyond MOST_POSITIVE_FIXNUM.
825 (decode_coding_emacs_mule): Abort if there isn't enough place in
826 charbuf for the composition carryover bytes. Reserve an extra
827 space for up to 2 characters produced in a loop.
828 (decode_coding_iso_2022): Abort if there isn't enough place in
829 charbuf for the composition carryover bytes.
830
831 2011-04-21 Eli Zaretskii <eliz@gnu.org>
832
833 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
834 aborting when %lld or %lll format is passed.
835 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
836 %llo or %llx format is passed. (Bug#8545)
837
838 * window.c (window_scroll_line_based): Use a marker instead of
839 simple variables to record original value of point. (Bug#7952)
840
841 * doprnt.c (doprnt): Fix the case where a multibyte sequence
842 produced by %s or %c overflows available buffer space. (Bug#8545)
843
844 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
845
846 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
847 (SIZE_MAX): Move defn after all includes, as they might #define it.
848
849 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
850
851 * w32.c (init_environment): Warn about defaulting HOME to C:\.
852
853 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
854
855 * keyboard.c (Qdelayed_warnings_hook): Define.
856 (command_loop_1): Run `delayed-warnings-hook'
857 if Vdelayed_warnings_list is non-nil.
858 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
859 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
860
861 2011-04-28 Eli Zaretskii <eliz@gnu.org>
862
863 * doprnt.c (doprnt): Don't return value smaller than the buffer
864 size if the message was truncated. (Bug#8545).
865
866 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
867
868 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
869 (Fx_window_property): #if-0 the whole functions, not just the bodies.
870
871 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
872
873 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
874
875 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
876
877 * makefile.w32-in: Update dependencies.
878
879 2011-04-27 Eli Zaretskii <eliz@gnu.org>
880
881 Improve `doprnt' and its usage. (Bug#8545)
882 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
883 `format_end'. Remove support for %l as a conversion specifier.
884 Don't use xrealloc. Improve diagnostics when the %l size modifier
885 is used. Update the commentary.
886
887 * eval.c (verror): Simplify calculation of size_t.
888
889 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
890 messages.
891
892 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
893
894 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
895 change.
896
897 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
898
899 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
900 This makes this file independent of the recent pseudovector change.
901
902 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
903
904 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
905
906 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
907 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
908 Remove unused local.
909 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
910
911 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
912 GCC 4.6.0 optimizes based on type-based alias analysis. For
913 example, if b is of type struct buffer * and v of type struct
914 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
915 != &v->size, and therefore "v->size = 1; b->size = 2; return
916 v->size;" must therefore return 1. This assumption is incorrect
917 for Emacs, since it type-puns struct Lisp_Vector * with many other
918 types. To fix this problem, this patch adds a new type struct
919 vectorlike_header that documents the constraints on layout of vectors
920 and pseudovectors, and helps optimizing compilers not get fooled
921 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
922 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
923 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
924 the size member.
925 (XSETPVECTYPE): Rewrite in terms of new macro.
926 (XSETPVECTYPESIZE): New macro, specifying both type and size.
927 This is a bit clearer, and further avoids the possibility of
928 undesirable aliasing.
929 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
930 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
931 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
932 since Lisp_Subr is a special case (no "next" field).
933 (ASIZE): Now uses header.size rather than size. All
934 previous uses of XVECTOR (foo)->size replaced to use this macro,
935 to avoid the hassle of writing XVECTOR (foo)->header.size.
936 (struct vectorlike_header): New type.
937 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
938 object, to help avoid aliasing.
939 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
940 (SUBRP): Likewise, since Lisp_Subr is a special case.
941 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
942 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
943 (struct Lisp_Hash_Table): Combine first two members into a single
944 struct vectorlike_header member. All uses of "size" and "next" members
945 changed to be "header.size" and "header.next".
946 * buffer.h (struct buffer): Likewise.
947 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
948 * frame.h (struct frame): Likewise.
949 * process.h (struct Lisp_Process): Likewise.
950 * termhooks.h (struct terminal): Likewise.
951 * window.c (struct save_window_data, struct saved_window): Likewise.
952 * window.h (struct window): Likewise.
953 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
954 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
955 * buffer.c (init_buffer_once): Likewise.
956 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
957 special case.
958 * process.c (Fformat_network_address): Use local var for size,
959 for brevity.
960
961 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
962
963 Make the Lisp reader and string-to-float more consistent (Bug#8525)
964 * data.c (atof): Remove decl; no longer used or needed.
965 (digit_to_number): Move to lread.c.
966 (Fstring_to_number): Use new string_to_number function, to be
967 consistent with how the Lisp reader treats infinities and NaNs.
968 Do not assume that floating-point numbers represent EMACS_INT
969 without losing information; this is not true on most 64-bit hosts.
970 Avoid double-rounding errors, by insisting on integers when
971 parsing non-base-10 numbers, as the documentation specifies.
972 * lisp.h (string_to_number): New decl, replacing ...
973 (isfloat_string): Remove.
974 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
975 (read1): Do not accept +. and -. as integers; this
976 appears to have been a coding error. Similarly, do not accept
977 strings like +-1e0 as floating point numbers. Do not report
978 overflow for integer overflows unless the base is not 10 which
979 means we have no simple and reliable way to continue.
980 Break out the floating-point parsing into a new
981 function string_to_number, so that Fstring_to_number parses
982 floating point numbers consistently with the Lisp reader.
983 (digit_to_number): Moved here from data.c. Make it static inline.
984 (E_CHAR, EXP_INT): Remove, replacing with ...
985 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
986 (string_to_number): New function, replacing isfloat_string.
987 This function checks for valid syntax and produces the resulting
988 Lisp float number too. Rework it so that string-to-number
989 no longer mishandles examples like "1.0e+". Use strtoumax,
990 so that overflow for non-base-10 numbers is reported only when
991 there's no portable and simple way to convert to floating point.
992
993 * textprop.c (set_text_properties_1): Rewrite for clarity,
994 and to avoid GCC warning about integer overflow.
995
996 * intervals.h (struct interval): Use EMACS_INT for members
997 where EMACS_UINT might cause problems. See
998 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
999 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1000 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1001 All uses changed.
1002 (offset_intervals): Tell GCC not to worry about length overflow
1003 when negating a negative length.
1004
1005 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1006 (overrun_check_free): Likewise.
1007
1008 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1009 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1010 word size.
1011
1012 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1013 (gnutls_make_error): Rename local to avoid shadowing.
1014 (gnutls_emacs_global_deinit): ifdef out; not used.
1015 (Fgnutls_boot): Use const for pointer to readonly storage.
1016 Comment out unused local. Fix pointer signedness problems.
1017
1018 * lread.c (openp): Don't stuff size_t into an 'int'.
1019 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1020 about possible signed overflow.
1021
1022 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1023 (GDK_KEY_g): Don't define if already defined.
1024 (xg_prepare_tooltip): Avoid pointer signedness problem.
1025 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1026
1027 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1028 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1029
1030 * xfns.c (Fx_window_property): Simplify a bit,
1031 to make a bit faster and to avoid GCC 4.6.0 warning.
1032 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1033
1034 * fns.c (internal_equal): Don't assume size_t fits in int.
1035
1036 * alloc.c (compact_small_strings): Tighten assertion a little.
1037
1038 Replace pEd with more-general pI, and fix some printf arg casts.
1039 * lisp.h (pI): New macro, generalizing old pEd macro to other
1040 conversion specifiers. For example, use "...%"pI"d..." rather
1041 than "...%"pEd"...".
1042 (pEd): Remove. All uses replaced with similar uses of pI.
1043 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1044 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1045 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1046 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1047 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1048 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1049 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1050 64-bit hosts.
1051 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1052 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1053 * print.c (safe_debug_print, print_object): Likewise.
1054 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1055 to int.
1056 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1057 avoiding the 0 flag, which is not portable.
1058 * process.c (Fmake_network_process): Use pI to avoid cast.
1059 * region-cache.c (pp_cache): Likewise.
1060 * xdisp.c (decode_mode_spec): Likewise.
1061 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1062 behavior on 64-bit hosts with printf arg.
1063 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
1064 (x_stop_queuing_selection_requests): Likewise.
1065 (x_get_window_property): Don't truncate byte count to an 'int'
1066 when tracing.
1067
1068 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1069 here, since it parses constructs like leading '-' and spaces,
1070 which are not wanted; and it overflows with large numbers.
1071 Instead, simply match F[0-9]+, which is what is wanted anyway.
1072
1073 * alloc.c: Remove unportable assumptions about struct layout.
1074 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1075 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1076 (allocate_vectorlike, make_pure_vector): Use the new macros,
1077 plus offsetof, to remove unportable assumptions about struct layout.
1078 These assumptions hold on all porting targets that I know of, but
1079 they are not guaranteed, they're easy to remove, and removing them
1080 makes further changes easier.
1081
1082 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1083 This doesn't fix a bug but makes the code clearer.
1084 (string_overrun_cookie): Now const. Use initializers that
1085 don't formally overflow signed char, to avoid warnings.
1086 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1087 can cause Emacs to crash when string overrun checking is enabled.
1088 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1089 multiple of sizeof (EMACS_INT); it need not be, if
1090 alignof(EMACS_INT) < sizeof (EMACS_INT).
1091 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1092
1093 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1094
1095 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1096
1097 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1098
1099 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1100 supposed to be handshaking. (Bug#8556)
1101 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1102
1103 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1104
1105 * lisp.h (Qdebug): List symbol.
1106 * eval.c (Qdebug): Restore global linkage.
1107 * keyboard.c (debug-on-event): New variable.
1108 (handle_user_signal): Break into debugger when debug-on-event
1109 matches the current signal symbol.
1110
1111 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1112
1113 * alloc.c (check_sblock, check_string_bytes)
1114 (check_string_free_list): Convert to standard C.
1115
1116 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1117
1118 * w32.c (emacs_gnutls_push): Fix typo.
1119
1120 2011-04-25 Eli Zaretskii <eliz@gnu.org>
1121
1122 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1123 "cast to pointer from integer of different size".
1124
1125 Improve doprnt and its use in verror. (Bug#8545)
1126 * doprnt.c (doprnt): Document the set of format control sequences
1127 supported by the function. Use SAFE_ALLOCA instead of always
1128 using `alloca'.
1129
1130 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1131 is one byte too soon. Don't use xrealloc; instead xfree and
1132 xmalloc anew.
1133
1134 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1135
1136 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1137 callbacks stage.
1138
1139 * gnutls.c: Renamed global_initialized to
1140 gnutls_global_initialized. Added internals for the
1141 :verify-hostname-error, :verify-error, and :verify-flags
1142 parameters of `gnutls-boot' and documented those parameters in the
1143 docstring. Start callback support.
1144 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1145 unless a fatal error occured. Call gnutls_alert_send_appropriate
1146 on error. Return error code.
1147 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1148 (emacs_gnutls_read): Likewise.
1149 (Fgnutls_boot): Return handshake error code.
1150 (emacs_gnutls_handle_error): New function.
1151 (wsaerror_to_errno): Likewise.
1152
1153 * w32.h (emacs_gnutls_pull): Add prototype.
1154 (emacs_gnutls_push): Likewise.
1155
1156 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1157 (emacs_gnutls_push): Likewise.
1158
1159 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1160
1161 * process.c (wait_reading_process_output): Check if GnuTLS
1162 buffered some data internally if no FDs are set for TLS
1163 connections.
1164
1165 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1166 (LIBS): Link to USER_LIBS.
1167 ($(BLD)/gnutls.$(0)): New target.
1168
1169 2011-04-24 Eli Zaretskii <eliz@gnu.org>
1170
1171 * xdisp.c (handle_single_display_spec): Rename the
1172 display_replaced_before_p argument into display_replaced_p, to
1173 make it consistent with the commentary. Fix typos in the
1174 commentary.
1175
1176 * textprop.c (syms_of_textprop): Remove dead code.
1177 (copy_text_properties): Delete obsolete commentary about an
1178 interface that was deleted long ago. Fix typos in the description
1179 of arguments.
1180
1181 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1182 to changes in oldXMenu/XMenu.h from 2011-04-16.
1183 <menu_help_message, prev_menu_help_message>: Constify.
1184 (IT_menu_make_room): menu->help_text is now `const char **';
1185 adjust.
1186
1187 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1188 to changes in oldXMenu/XMenu.h from 2011-04-16.
1189 (struct XMenu): Declare `help_text' `const char **'.
1190
1191 * xfaces.c <Qunspecified>: Make extern again.
1192
1193 * syntax.c: Include sys/types.h before including regex.h, as
1194 required by Posix.
1195
1196 * doc.c (get_doc_string): Improve the format passed to `error'.
1197
1198 * doprnt.c (doprnt): Improve commentary.
1199
1200 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1201
1202 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1203 them with etags.
1204
1205 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1206 changes in globals.h immediately force recompilation.
1207 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1208 $(CURDIR)/s/ms-w32.h.
1209 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1210
1211 * character.c (Fchar_direction): Function deleted.
1212 (syms_of_character): Don't defsubr it.
1213 <char-direction-table>: Deleted.
1214
1215 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1216
1217 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1218 * doprnt.c: Include limits.h.
1219 (SIZE_MAX): New macro.
1220 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
1221 local variables are now size_t instead of int or unsigned.
1222 Improve overflow protection. Support `l' modifier for integer
1223 conversions. Support %l conversion. Don't assume an EMACS_INT
1224 argument for integer conversions and for %c.
1225
1226 * lisp.h (doprnt): Restore prototype.
1227
1228 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1229 $(SRC)/character.h.
1230
1231 * Makefile.in (base_obj): Add back doprnt.o.
1232
1233 * deps.mk (doprnt.o): Add back prerequisites.
1234 (callint.o): Depend on character.h.
1235
1236 * eval.c (internal_lisp_condition_case): Include the handler
1237 representation in the error message.
1238 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1239 when breaking from the loop.
1240
1241 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1242
1243 * callint.c (Fcall_interactively): When displaying error message
1244 about invalid control letter, pass the character's codepoint, not
1245 a pointer to its multibyte form. Improve display of the character
1246 in octal and display also its hex code.
1247
1248 * character.c (char_string): Use %x to display the (unsigned)
1249 codepoint of an invalid character, to avoid displaying a bogus
1250 negative value.
1251
1252 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1253 `error', not SYMBOL_NAME itself.
1254
1255 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1256 character arguments to `error'.
1257
1258 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1259 to `error' in error message about FINAL_CHAR argument. Make sure
1260 FINAL_CHAR is a character, and use %c when it is passed as
1261 argument to `error'.
1262
1263 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1264
1265 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1266
1267 * w32.c: Include <time.h>.
1268 (sys_localtime): New function.
1269
1270 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1271
1272 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1273
1274 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1275
1276 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1277
1278 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1279 zombies (Bug#8467).
1280
1281 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1282
1283 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1284 gl_state.e_property when gl_state.object is Qt.
1285
1286 * insdel.c (make_gap_larger): Remove limitation of buffer size
1287 to <= INT_MAX.
1288
1289 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1290
1291 * xdisp.c (lookup_glyphless_char_display)
1292 (produce_glyphless_glyph): Handle cons cell entry in
1293 glyphless-char-display.
1294 (Vglyphless_char_display): Document it.
1295
1296 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1297 glyphless-char-display.
1298
1299 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
1300
1301 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1302
1303 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1304
1305 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1306 definition for no-X builds.
1307
1308 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1309
1310 Static checks with GCC 4.6.0 and non-default toolkits.
1311
1312 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1313
1314 * process.c (keyboard_bit_set): Define only if SIGIO.
1315 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1316 (send_process): Repair possible setjmp clobbering.
1317
1318 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1319
1320 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1321
1322 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1323
1324 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1325 Define only if needed.
1326
1327 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1328 by pacifying GCC about it. Maybe it's time to retire it?
1329 * xfaces.c (USG, __TIMEVAL__): Likewise.
1330
1331 * dispextern.h (struct redisplay_interface): Rename param
1332 to avoid shadowing.
1333 * termhooks.h (struct terminal): Likewise.
1334 * xterm.c (xembed_send_message): Likewise.
1335
1336 * insdel.c (make_gap_smaller): Define only if
1337 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1338
1339 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1340 it.
1341
1342 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1343 so that we aren't warned about unused symbols.
1344
1345 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1346
1347 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1348
1349 * xfns.c (x_real_positions): Mark locals as initialized.
1350
1351 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1352
1353 * xterm.c: Fix problems found by static analysis with other toolkits.
1354 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1355 (x_dispatch_event): Declare static if USE_GTK, and
1356 define if USE_GTK || USE_X_TOOLKIT.
1357 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1358 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1359 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1360 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1361
1362 * xmenu.c (menu_help_callback): Pointer type fixes.
1363 Use const pointers when pointing at readonly data. Avoid pointer
1364 signedness clashes.
1365 (FALSE): Remove unused macro.
1366 (update_frame_menubar): Remove unused decl.
1367
1368 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1369
1370 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1371 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1372 (single_menu_item): Rename local to avoid shadowing.
1373
1374 * keyboard.c (make_lispy_event): Remove unused local var.
1375
1376 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1377 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1378
1379 * bitmaps: Change bitmaps from unsigned char back to the X11
1380 compatible char. Avoid the old compiler warnings about
1381 out-of-range initializers by using, for example, '\xab' rather
1382 than 0xab.
1383
1384 * xgselect.c (xgselect_initialize): Check vs interface
1385 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1386
1387 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1388
1389 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1390 to read-only memory.
1391
1392 * fns.c (vector): Remove; this old hack is no longer needed.
1393
1394 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1395 Remove unused var.
1396 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1397
1398 * xrdb.c (x_load_resources): Omit unused local.
1399
1400 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1401 (x_window): Rename locals to avoid shadowing.
1402 (USG): Use the kludged USG macro, to pacify gcc.
1403
1404 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1405 (x_term_init): Remove local to avoid shadowing.
1406
1407 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1408
1409 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1410 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1411
1412 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1413
1414 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1415
1416 Fix regex.c, syntax.c and friends for buffers > 2GB.
1417 * syntax.h (struct gl_state_s): Declare character position members
1418 EMACS_INT.
1419
1420 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1421
1422 * textprop.c (verify_interval_modification, interval_of): Declare
1423 arguments EMACS_INT.
1424
1425 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1426 EMACS_INT.
1427
1428 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1429
1430 * indent.c (Fvertical_motion): Local variable it_start is now
1431 EMACS_INT.
1432
1433 * regex.c (re_match, re_match_2, re_match_2_internal)
1434 (bcmp_translate, regcomp, regexec, print_double_string)
1435 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1436 (re_compile_pattern, re_exec): Declare arguments and local
1437 variables `size_t' and `ssize_t' and return values `regoff_t', as
1438 appropriate.
1439 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1440 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1441 <compile_stack_type>: `size' and `avail' are now `size_t'.
1442
1443 * regex.h <regoff_t>: Use ssize_t, not int.
1444 (re_search, re_search_2, re_match, re_match_2): Arguments that
1445 specify buffer/string position and length are now ssize_t and
1446 size_t. Return type is regoff_t.
1447
1448 2011-04-16 Ben Key <bkey76@gmail.com>
1449
1450 * nsfont.m: Fixed bugs in ns_get_family and
1451 ns_descriptor_to_entity that were caused by using free to
1452 deallocate memory blocks that were allocated by xmalloc (via
1453 xstrdup). This caused Emacs to crash when compiled with
1454 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1455 --enable-checking=xmallocoverrun). xfree is now used to
1456 deallocate these memory blocks.
1457
1458 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1459
1460 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1461
1462 emacs_write: Accept and return EMACS_INT for sizes.
1463 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1464 et seq.
1465 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1466 Accept and return EMACS_INT.
1467 (emacs_gnutls_write): Return the number of bytes written on
1468 partial writes.
1469 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1470 (emacs_read, emacs_write): Remove check for negative size, as the
1471 Emacs source code has been audited now.
1472 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1473 (emacs_read, emacs_write): Use it.
1474 * process.c (send_process): Adjust to the new signatures of
1475 emacs_write and emacs_gnutls_write. Do not attempt to store
1476 a byte offset into an 'int'; it might overflow.
1477 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1478
1479 * sound.c: Don't assume sizes fit in 'int'.
1480 (struct sound_device.period_size, alsa_period_size):
1481 Return EMACS_INT, not int.
1482 (struct sound_device.write, vox_write, alsa_write):
1483 Accept EMACS_INT, not int.
1484 (wav_play, au_play): Use EMACS_INT to store sizes and to
1485 record read return values.
1486
1487 2011-04-15 Ben Key <bkey76@gmail.com>
1488
1489 * keyboard.c (Qundefined): Don't declare static since it is used
1490 in nsfns.m.
1491 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1492 static since they are used in nsfont.m.
1493
1494 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1495
1496 * process.c (Qprocessp): Don't declare static.
1497 * lisp.h (Qprocessp): Declare again.
1498
1499 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
1500
1501 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1502
1503 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1504
1505 Improve C-level modularity by making more things 'static'.
1506
1507 Don't publish debugger-only interfaces to other modules.
1508 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1509 (verify_bytepos, count_markers): Move decls to the only modules
1510 that need them.
1511 * region-cache.h (pp_cache): Likewise.
1512 * window.h (check_all_windows): Likewise.
1513 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1514
1515 * sysdep.c (croak): Now static, if
1516 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1517 * syssignal.h (croak): Declare only if not static.
1518
1519 * alloc.c (refill_memory_reserve): Now static if
1520 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1521 * lisp.h (refill_memory_reserve): Declare only if not static.
1522
1523 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1524 Define only if USE_LUCID.
1525
1526 * xrdb.c (x_customization_string, x_rm_string): Now static.
1527
1528 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1529 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1530
1531 * xdisp.c (draw_row_with_mouse_face): Now static.
1532 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1533
1534 * window.h (check_all_windows): Mark externally visible.
1535
1536 * window.c (window_deletion_count): Now static.
1537
1538 * undo.c: Make symbols static if they're not exported.
1539 (last_undo_buffer, last_boundary_position, pending_boundary):
1540 Now static.
1541
1542 * textprop.c (interval_insert_behind_hooks): Now static.
1543 (interval_insert_in_front_hooks): Likewise.
1544
1545 * term.c: Make symbols static if they're not exported.
1546 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1547 (max_frame_lines, tty_set_terminal_modes):
1548 (tty_reset_terminal_modes, tty_turn_off_highlight):
1549 (get_tty_terminal): Now static.
1550 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1551 * termhooks.h (term_mouse_moveto): Do not declare if
1552 HAVE_WINDOW_SYSTEM.
1553 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1554 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1555
1556 * sysdep.c: Make symbols static if they're not exported.
1557 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1558 Now static.
1559 (sigprocmask_set, full_mask): Remove; unused.
1560 (wait_debugging): Mark as visible.
1561 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1562 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1563
1564 * syntax.c (syntax_temp): Define only if !__GNUC__.
1565
1566 * sound.c (current_sound_device, current_sound): Now static.
1567
1568 * search.c (searchbufs, searchbuf_head): Now static.
1569
1570 * scroll.c (scroll_cost): Remove; unused.
1571 * dispextern.h (scroll_cost): Remove decl.
1572
1573 * region-cache.h (pp_cache): Mark as externally visible.
1574
1575 * process.c: Make symbols static if they're not exported.
1576 (process_tick, update_tick, create_process, chan_process):
1577 (Vprocess_alist, proc_buffered_char, datagram_access):
1578 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1579 (deactivate_process): Mark defn as static, as well as decl.
1580 * lisp.h (create_process): Remove decl.
1581 * process.h (chan_process, Vprocess_alist): Remove decls.
1582
1583 * print.c: Make symbols static if they're not exported.
1584 (print_depth, new_backquote_output, being_printed, print_buffer):
1585 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1586 (print_interval, print_number_index, initial_stderr_stream):
1587 Now static.
1588 * lisp.h (Fprinc): Remove decl.
1589 (debug_output_compilation_hack): Mark as externally visible.
1590
1591 * sysdep.c (croak): Move decl from here to syssignal.h.
1592 * syssignal.h (croak): Put it here, so the API can be checked when
1593 'croak' is called from dissociate_if_controlling_tty.
1594
1595 * minibuf.c: Make symbols static if they're not exported.
1596 (minibuf_save_list, choose_minibuf_frame): Now static.
1597 * lisp.h (choose_minibuf_frame): Remove decl.
1598
1599 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1600
1601 * lread.c: Make symbols static if they're not exported.
1602 (read_objects, initial_obarray, oblookup_last_bucket_number):
1603 Now static.
1604 (make_symbol): Remove; unused.
1605 * lisp.h (initial_obarray, make_symbol): Remove decls.
1606
1607 * keyboard.c: Make symbols static if they're not exported.
1608 (single_kboard, recent_keys_index, total_keys, recent_keys):
1609 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1610 (this_single_command_key_start, echoing, last_auto_save):
1611 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1612 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1613 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1614 (Vlispy_mouse_stem, double_click_count):
1615 Now static.
1616 (force_auto_save_soon): Define only if SIGDANGER.
1617 (ignore_mouse_drag_p): Now static if
1618 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1619 (print_help): Remove; unused.
1620 (stop_character, last_timer_event): Mark as externally visible.
1621 * keyboard.h (ignore_mouse_drag_p): Declare only if
1622 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1623 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1624 * lisp.h (echoing): Remove decl.
1625 (force_auto_save_soon): Declare only if SIGDANGER.
1626 * xdisp.c (redisplay_window): Simplify code, to make it more
1627 obvious that ignore_mouse_drag_p is not accessed if !defined
1628 USE_GTK && !defined HAVE_NS.
1629
1630 * intervals.c: Make symbols static if they're not exported.
1631 (merge_properties_sticky, merge_interval_right, delete_interval):
1632 Now static.
1633 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1634
1635 * insdel.c: Make symbols static if they're not exported.
1636 However, leave prepare_to_modify_buffer alone. It's never
1637 called from outside this function, but that appears to be a bug.
1638 (combine_after_change_list, combine_after_change_buffer):
1639 (adjust_after_replace, signal_before_change): Now static.
1640 (adjust_after_replace_noundo): Remove; unused.
1641 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
1642 (signal_before_change): Remove decls.
1643
1644 * indent.c (val_compute_motion, val_vmotion): Now static.
1645
1646 * image.c: Make symbols static if they're not exported.
1647 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1648 if USE_GTK.
1649 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1650 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1651
1652 * fringe.c (standard_bitmaps): Now static.
1653 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1654
1655 * frame.c: Make symbols static if they're not exported.
1656 (x_report_frame_params, make_terminal_frame): Now static.
1657 (get_frame_param): Now static, unless HAVE_NS.
1658 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1659 (x_get_resource_string): Remove; not used.
1660 * frame.h (make_terminal_frame, x_report_frame_params):
1661 (x_get_resource_string); Remove decls.
1662 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1663 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1664
1665 * font.c, fontset.c: Make symbols static if they're not exported.
1666 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1667 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1668 * font.c (font_close_object): Now static.
1669 * font.h (font_close_object): Remove.
1670 * fontset.c (FONTSET_OBJLIST): Remove.
1671 (free_realized_fontset) #if-0 the body, which does nothing.
1672 (face_suitable_for_char_p): #if-0, as it's never called.
1673 * fontset.h (face_suitable_for_char_p): Remove decl.
1674 * xfaces.c (face_at_string_position): Use
1675 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1676 since 0 is always ASCII.
1677
1678 * fns.c (weak_hash_tables): Now static.
1679
1680 * fileio.c: Make symbols static if they're not exported.
1681 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1682 (Vwrite_region_annotation_buffers): Now static.
1683
1684 * eval.c: Make symbols static if they're not exported.
1685 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1686 * lisp.h (backtrace_list): Remove decl.
1687
1688 * emacs.c: Make symbols static if they're not exported.
1689 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1690 (fatal_error_code, fatal_error_signal_hook, standard_args):
1691 Now static.
1692 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1693 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1694 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1695 * lisp.h (fatal_error_signal_hook): Remove decl.
1696 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1697
1698 * editfns.c: Move a (normally-unused) function to its only use.
1699 * editfns.c, lisp.h (get_operating_system_release): Remove.
1700 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1701 worth the hassle of breaking this out.
1702
1703 * xterm.c: Make symbols static if they're not exported.
1704 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1705 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1706 (x_destroy_window, x_delete_display):
1707 Now static.
1708 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1709 (x_mouse_leave): Remove; unused.
1710 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1711 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1712 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1713 Remove decls.
1714 (x_mouse_leave): Declare only if WINDOWSNT.
1715 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1716 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1717 USE_X_TOOLKIT.
1718
1719 * ftxfont.c: Make symbols static if they're not exported.
1720 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1721 HAVE_FREETYPE.
1722 * font.h (ftxfont_driver): Likewise.
1723
1724 * xfns.c: Make symbols static if they're not exported.
1725 (x_last_font_name, x_display_info_for_name):
1726 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1727 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1728 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1729 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1730 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1731 (last_show_tip_args): Now static.
1732 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1733 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1734 (x_screen_planes): Remove; unused.
1735 * dispextern.h (x_screen_planes): Remove decl.
1736
1737 * dispnew.c: Make symbols static if they're not exported.
1738 * dispextern.h (redraw_garbaged_frames, scrolling):
1739 (increment_row_positions): Remove.
1740 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1741 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1742 Now static.
1743 (redraw_garbaged_frames): Remove; unused.
1744
1745 * xfaces.c: Make symbols static if they're not exported.
1746 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1747 Remove decls.
1748 * xterm.h (defined_color): Remove decls.
1749 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1750 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1751 (menu_face_changed_default, defined_color, free_realized_face):
1752 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1753 (ascii_face_of_lisp_face): Remove; unused.
1754
1755 * xdisp.c: Make symbols static if they're not exported.
1756 * dispextern.h (scratch_glyph_row, window_box_edges):
1757 (glyph_to_pixel_coords, set_cursor_from_row):
1758 (get_next_display_element, set_iterator_to_next):
1759 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1760 (show_mouse_face): Remove decls
1761 * frame.h (message_buf_print): Likewise.
1762 * lisp.h (pop_message, set_message, check_point_in_composition):
1763 Likewise.
1764 * xterm.h (set_vertical_scroll_bar): Likewise.
1765 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1766 (message_buf_print, scratch_glyph_row, displayed_buffer):
1767 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1768 (get_next_display_element, show_mouse_face, window_box_edges):
1769 (frame_to_window_pixel_xy, check_point_in_composition):
1770 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1771 (glyph_to_pixel_coords): Remove; unused.
1772
1773 * dired.c (file_name_completion): Now static.
1774
1775 * dbusbind.c (xd_in_read_queued_messages): Now static.
1776
1777 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1778 * data.c (circular_list_error): Remove.
1779
1780 * commands.h (last_point_position, last_point_position_buffer):
1781 (last_point_position_window): Remove decls.
1782 * keyboard.c: Make these variables static.
1783
1784 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
1785 decls.
1786 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1787 (iso_code_class, detect_coding, code_convert_region): Now static.
1788 (encode_coding_gap): Remove; unused.
1789
1790 * chartab.c (chartab_chars, chartab_bits): Now static.
1791
1792 * charset.h (charset_iso_8859_1): Remove decl.
1793 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1794 Now static.
1795
1796 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1797 * ccl.c (Vccl_program_table): Now static.
1798 (check_ccl_update): Remove; unused.
1799
1800 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1801 * category.h: ... from here.
1802 * category.c (check_category_table, set_category_set): Now static.
1803
1804 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1805 * lisp.h: Remove these decls.
1806
1807 * buffer.c (buffer_count): Remove unused var.
1808
1809 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1810 so that it's not optimized away.
1811 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1812 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1813 exported only to the debugger.
1814
1815 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1816 * atimer.h (run_all_atimers): Removed; not exported.
1817
1818 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1819 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1820 was inaccessible from Lisp.
1821 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1822 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1823
1824 alloc.c: Import and export fewer symbols, and remove unused items.
1825 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1826 is defined.
1827 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1828 it's not optimized away by whole-program optimization.
1829 (message_enable_multibyte, free_misc): Remove.
1830 (catchlist, handlerlist, mark_backtrace):
1831 Declare only if BYTE_MARK_STACK.
1832 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1833 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1834 (message_enable_multibyte): Remove decl.
1835 (free_misc, interval_free_list, float_block, float_block_index):
1836 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1837 (cons_free_list, last_marked_index):
1838 Now static.
1839 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1840 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1841 (mark_backtrace): Define only if BYTE_MARK_STACK.
1842 * xdisp.c (message_enable_multibyte): Now static.
1843
1844 Declare Lisp_Object Q* variables to be 'static' if not exported.
1845 This makes it easier for human readers (and static analyzers)
1846 to see whether these variables are used from other modules.
1847 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1848 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1849 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1850 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1851 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1852 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1853 * xmenu.c, xselect.c:
1854 Declare Q* vars static if they are not used in other modules.
1855 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1856 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1857 Remove decls of unexported vars.
1858 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1859
1860 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1861
1862 Make Emacs functions such as Fatom 'static' by default.
1863 This makes it easier for human readers (and static analyzers)
1864 to see whether these functions can be called from other modules.
1865 DEFUN now defines a static function. To make the function external
1866 so that it can be used in other C modules, use the new macro DEFUE.
1867 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1868 (Finit_image_library):
1869 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1870 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1871 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1872 Remove decls, since these functions are now static.
1873 (Funintern, Fget_internal_run_time): New decls, since these functions
1874 were already external.
1875
1876 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1877 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1878 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1879 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1880 * keyboard.c, keymap.c, lread.c:
1881 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1882 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1883 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1884 Mark functions with DEFUE instead of DEFUN,
1885 if they are used in other modules.
1886 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1887 decls for now-static functions.
1888 * buffer.h (Fdelete_overlay): Remove decl.
1889 * callproc.c (Fgetenv_internal): Mark as internal.
1890 * composite.c (Fremove_list_of_text_properties): Remove decl.
1891 (Fcomposition_get_gstring): New forward static decl.
1892 * composite.h (Fcomposite_get_gstring): Remove decl.
1893 * dired.c (Ffile_attributes): New forward static decl.
1894 * doc.c (Fdocumntation_property): New forward static decl.
1895 * eval.c (Ffetch_bytecode): New forward static decl.
1896 (Funintern): Remove extern decl; now in .h file where it belongs.
1897 * fileio.c (Fmake_symbolic_link): New forward static decl.
1898 * image.c (Finit_image_library): New forward static decl.
1899 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1900 * intervals.h (Fprevious_property_change):
1901 (Fremove_list_of_text_properties): Remove decls.
1902 * keyboard.c (Fthis_command_keys): Remove decl.
1903 (Fcommand_execute): New forward static decl.
1904 * keymap.c (Flookup_key): New forward static decl.
1905 (Fcopy_keymap): Now static.
1906 * keymap.h (Flookup_key): Remove decl.
1907 * process.c (Fget_process): New forward static decl.
1908 (Fprocess_datagram_address): Mark as internal.
1909 * syntax.c (Fsyntax_table_p): New forward static decl.
1910 (skip_chars): Remove duplicate decl.
1911 * textprop.c (Fprevious_property_change): New forward static decl.
1912 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1913 Now internal.
1914 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1915 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1916
1917 * editfns.c (Fformat): Remove unreachable code.
1918
1919 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1920
1921 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1922 change. (Bug#8496)
1923
1924 2011-04-13 Eli Zaretskii <eliz@gnu.org>
1925
1926 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1927 when at ZV. (Bug#8487)
1928
1929 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1930
1931 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1932 (Bug#8437)
1933 * keyboard.c (parse_tool_bar_item): Likewise.
1934 * sound.c (sound_cleanup, alsa_close): Likewise.
1935 * termcap.c (tgetent): Likewise.
1936 * xfns.c (x_default_font_parameter): Likewise.
1937 * xsettings.c (read_and_apply_settings): Likewise.
1938
1939 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1940 (overrun_check_free): Protoize.
1941
1942 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1943
1944 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1945 since callers should never pass a negative size.
1946 Change the signature to match that of plain 'read' and 'write'; see
1947 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1948 * lisp.h: Update prototypes of emacs_write and emacs_read.
1949
1950 2011-04-11 Eli Zaretskii <eliz@gnu.org>
1951
1952 * xdisp.c (redisplay_window): Don't try to determine the character
1953 position of the scroll margin if the window start point w->startp
1954 is outside the buffer's accessible region. (Bug#8468)
1955
1956 2011-04-10 Eli Zaretskii <eliz@gnu.org>
1957
1958 Fix write-region and its subroutines for buffers > 2GB.
1959 * fileio.c (a_write, e_write): Modify declaration of arguments and
1960 local variables to support buffers larger than 2GB.
1961 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1962
1963 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1964 argument, local variables, and return value.
1965
1966 * lisp.h: Update prototypes of emacs_write and emacs_read.
1967
1968 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1969
1970 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
1971
1972 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1973
1974 Fix more problems found by GCC 4.6.0's static checks.
1975
1976 * xdisp.c (vmessage): Use a better test for character truncation.
1977
1978 * charset.c (load_charset_map): <, not <=, for optimization,
1979 and to avoid potential problems with integer overflow.
1980 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
1981 * casetab.c (set_identity, shuffle): Likewise.
1982 * editfns.c (Fformat): Likewise.
1983 * syntax.c (skip_chars): Likewise.
1984
1985 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1986 This also lets GCC 4.6.0 generate slightly better loop code.
1987
1988 * callint.c (Fcall_interactively): <, not <=, for optimization.
1989 (Fcall_interactively): Count the number of arguments produced,
1990 not the number of arguments given. This is simpler and lets GCC
1991 4.6.0 generate slightly better code.
1992
1993 * ftfont.c: Distingish more carefully between FcChar8 and char.
1994 The previous code passed unsigned char * to a functions like
1995 strlen and xstrcasecmp that expect char *, which does not
1996 conform to the C standard.
1997 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1998 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1999 char * when the C standard requires it.
2000
2001 * keyboard.c (read_char): Remove unused var.
2002
2003 * eval.c: Port to Windows vsnprintf (Bug#8435).
2004 Include <limits.h>.
2005 (SIZE_MAX): Define if the headers do not.
2006 (verror): Do not give up if vsnprintf returns a negative count.
2007 Instead, grow the buffer. This ports to Windows vsnprintf, which
2008 does not conform to C99. Problem reported by Eli Zaretskii.
2009 Also, simplify the allocation scheme, by avoiding the need for
2010 calling realloc, and removing the ALLOCATED variable.
2011
2012 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2013
2014 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2015 But keep the doprint source code for now, as we might revamp it
2016 and use it again (Bug#8435).
2017 * lisp.h (doprnt): Remove.
2018 * Makefile.in (base_obj): Remove doprnt.o.
2019 * deps.mk (doprnt.o): Remove.
2020
2021 error: Print 32- and 64-bit integers portably (Bug#8435).
2022 Without this change, on typical 64-bit hosts error ("...%d...", N)
2023 was used to print both 32- and 64-bit integers N, which relied on
2024 undefined behavior.
2025 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2026 New macro.
2027 * lisp.h (error, verror): Mark as printf-like functions.
2028 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2029 Report overflow in size calculations when allocating printf buffer.
2030 Do not truncate output string at its first null byte.
2031 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2032 Truncate the output at a character boundary, since vsnprintf does not
2033 do that.
2034 * charset.c (check_iso_charset_parameter): Convert internal
2035 character to string before calling 'error', since %c now has the
2036 printf meaning.
2037 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2038 overflow when computing char to be passed to 'error'. Do not
2039 pass Lisp_Object to 'error'; pass the integer instead.
2040 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2041 formatted with plain %d.
2042
2043 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2044
2045 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2046
2047 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2048
2049 * xterm.c (x_catch_errors): Remove duplicate declaration.
2050
2051 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2052
2053 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2054
2055 2011-04-10 Jim Meyering <meyering@redhat.com>
2056
2057 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2058 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2059 return ssize_t not "int", and use size_t as the buffer length.
2060 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2061 * gnutls.h: Update declarations.
2062 * process.c (read_process_output): Use ssize_t, to match.
2063 (send_process): Likewise.
2064
2065 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2066
2067 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2068
2069 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2070
2071 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
2072 unsigned char, to match FcChar8 type definition.
2073
2074 * xterm.c (handle_one_xevent):
2075 * xmenu.c (create_and_show_popup_menu):
2076 * xselect.c (x_decline_selection_request)
2077 (x_reply_selection_request): Avoid type-punned deref of X events.
2078
2079 2011-04-09 Eli Zaretskii <eliz@gnu.org>
2080
2081 Fix some uses of `int' instead of EMACS_INT.
2082 * search.c (string_match_1, fast_string_match)
2083 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2084 (scan_buffer, find_next_newline_no_quit)
2085 (find_before_next_newline, search_command, Freplace_match)
2086 (Fmatch_data): Make some `int' variables be EMACS_INT.
2087
2088 * xdisp.c (display_count_lines): 3rd argument and return value now
2089 EMACS_INT. All callers changed.
2090 (pint2hrstr): Last argument is now EMACS_INT.
2091
2092 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2093 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2094 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2095 (decode_coding_utf_16, decode_coding_emacs_mule)
2096 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2097 (decode_coding_ccl, decode_coding_charset)
2098 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2099 (decode_coding_iso_2022, decode_coding_emacs_mule)
2100 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2101 <char_offset, last_offset>: Declare EMACS_INT.
2102 (encode_coding_utf_8, encode_coding_utf_16)
2103 (encode_coding_emacs_mule, encode_invocation_designation)
2104 (encode_designation_at_bol, encode_coding_iso_2022)
2105 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2106 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2107 Declare EMACS_INT.
2108 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2109 (encode_invocation_designation): Last argument P_NCHARS is now
2110 EMACS_INT.
2111 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2112 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2113
2114 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2115 All users changed.
2116
2117 * ccl.c (Fccl_execute_on_string): Declare some variables
2118 EMACS_INT.
2119
2120 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2121
2122 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2123
2124 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2125
2126 * process.c (Fformat_network_address): Doc fix.
2127
2128 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2129
2130 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2131
2132 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
2133
2134 * keyboard.c (read_char): Call Lisp function help-form-show,
2135 instead of using internal_with_output_to_temp_buffer.
2136 (Qhelp_form_show): New var.
2137 (syms_of_keyboard): Use DEFSYM macro.
2138
2139 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2140
2141 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2142
2143 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
2144
2145 * process.c (Flist_processes): Removed to Lisp.
2146 (list_processes_1): Deleted.
2147
2148 2011-04-06 Eli Zaretskii <eliz@gnu.org>
2149
2150 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2151
2152 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2153
2154 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
2155
2156 Fix more problems found by GCC 4.6.0's static checks.
2157
2158 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2159
2160 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2161
2162 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
2163
2164 * xdisp.c (vmessage): Mark as a printf-like function.
2165
2166 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2167
2168 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2169
2170 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2171 printf-like functions.
2172 (tiff_load): Add casts to remove these marks before passing them
2173 to system-supplied API.
2174
2175 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2176
2177 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2178 This avoids several warnings with gcc -Wstrict-overflow.
2179 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2180 directly, rather than having caller test rule sign. This avoids
2181 some unnecessary tests.
2182 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2183 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2184 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
2185
2186 * xfont.c (xfont_text_extents): Remove var that was set but not used.
2187 (xfont_open): Avoid unnecessary tests.
2188
2189 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2190
2191 * composite.h, composite.c (composition_gstring_put_cache):
2192 Use EMACS_INT, not int, for length.
2193
2194 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2195 breaking out part of COMPOSITION_DECODE_RULE.
2196 (COMPOSITION_DECODE_RULE): Use it.
2197 * composite.c (get_composition_id): Remove unused local vars,
2198 by using the new macro.
2199
2200 * textprop.c (set_text_properties_1): Change while to do-while,
2201 since the condition is always true at first.
2202
2203 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2204 (interval_deletion_adjustment): Return unsigned value.
2205 All uses changed.
2206
2207 * process.c (list_processes_1, create_pty, read_process_output):
2208 (exec_sentinel): Remove vars that were set but not used.
2209 (create_pty): Remove unnecessary "volatile"s.
2210 (Fnetwork_interface_info): Avoid possibility of int overflow.
2211 (read_process_output): Do adaptive read buffering even if carryover.
2212 (read_process_output): Simplify nbytes computation if buffered.
2213
2214 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2215
2216 * syntax.c (scan_words): Remove var that was set but not used.
2217 (update_syntax_table): Use unsigned instead of int.
2218
2219 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2220 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2221 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2222
2223 * print.c (print_error_message): Avoid int overflow.
2224
2225 * font.c (font_list_entities): Redo for clarity,
2226 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2227
2228 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2229 (font_score): Avoid potential overflow in diff calculation.
2230
2231 * fns.c (substring_both): Remove var that is set but not used.
2232 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2233
2234 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2235
2236 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2237 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2238 can always succeed if overflow has undefined behavior.
2239
2240 * search.c (boyer_moore, wordify): Remove vars set but not used.
2241 (wordify): Omit three unnecessary tests.
2242
2243 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2244 All callers changed. This avoids the need for an unused var.
2245
2246 * casefiddle.c (casify_region): Remove var that is set but not used.
2247
2248 * dired.c (file_name_completion): Remove var that is set but not used.
2249
2250 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2251
2252 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2253 (Finsert_file_contents): Remove unnecessary code checking fd.
2254
2255 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2256 Check for integer overflow on size calculations.
2257
2258 * buffer.c (Fprevious_overlay_change): Remove var that is set
2259 but not used.
2260
2261 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2262 Remove vars that are set but not used.
2263 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2264 (timer_check_2): Mark vars as initialized.
2265
2266 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2267
2268 * image.c (lookup_image): Remove var that is set but not used.
2269 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2270
2271 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2272 that are set but not used.
2273
2274 * xfns.c (make_invisible_cursor): Don't return garbage
2275 if XCreateBitmapFromData fails (Bug#8410).
2276
2277 * xselect.c (x_get_local_selection, x_handle_property_notify):
2278 Remove vars that are set but not used.
2279
2280 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2281 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2282
2283 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2284 Remove var that is set but not used.
2285 (scroll_bar_windows_size): Now size_t, not int.
2286 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2287 Check for overflow.
2288
2289 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2290 (map_tty_color) [!defined MSDOS]: Likewise.
2291
2292 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2293
2294 * coding.c: Remove vars that are set but not used.
2295 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2296 All callers changed.
2297 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2298 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2299 (decode_coding_charset): Remove vars that are set but not used.
2300
2301 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2302 that is set but not used.
2303
2304 * print.c (print_object): Remove var that is set but not used.
2305
2306 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2307 The gnulib version avoids calling malloc in the usual case,
2308 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2309 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2310 * filelock.c (current_lock_owner): Likewise.
2311 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2312 * sysdep.c: Include allocator.h, careadlinkat.h.
2313 (emacs_no_realloc_allocator): New static constant.
2314 (emacs_readlink): New function.
2315 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2316 ../lib/careadlinkat.h.
2317
2318 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2319
2320 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2321 first non-nil return value).
2322
2323 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2324
2325 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2326 if not defined (Bug#8403).
2327
2328 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2329
2330 * xdisp.c (display_count_lines): Remove parameter `start',
2331 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2332 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2333 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2334 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2335 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2336 and thereabouts. All callers changed.
2337 (get_per_char_metric): Remove parameter `f', unused since
2338 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2339
2340 2011-04-02 Jim Meyering <meyering@redhat.com>
2341
2342 do not dereference NULL upon failed strdup
2343 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2344 (ns_get_family): Likewise.
2345
2346 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2347
2348 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2349
2350 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2351
2352 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2353 later (Bug#8403).
2354
2355 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2356
2357 Add lexical binding.
2358
2359 * window.c (Ftemp_output_buffer_show): New fun.
2360 (Fsave_window_excursion):
2361 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2362
2363 * lread.c (lisp_file_lexically_bound_p): New function.
2364 (Fload): Bind Qlexical_binding.
2365 (readevalloop): Remove `evalfun' arg.
2366 Bind Qinternal_interpreter_environment.
2367 (Feval_buffer): Bind Qlexical_binding.
2368 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2369 Mark as dynamic.
2370 (syms_of_lread): Declare `lexical-binding'.
2371
2372 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2373
2374 * keyboard.c (eval_dyn): New fun.
2375 (menu_item_eval_property): Use it.
2376
2377 * image.c (parse_image_spec): Use Ffunctionp.
2378
2379 * fns.c (concat, mapcar1): Accept byte-code-functions.
2380
2381 * eval.c (Fsetq): Handle lexical vars.
2382 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2383 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2384 (FletX, Flet): Obey lexical binding.
2385 (Fcommandp): Handle closures.
2386 (Feval): New `lexical' arg.
2387 (eval_sub): New function extracted from Feval. Use it almost
2388 everywhere where Feval was used. Look up vars in lexical env.
2389 Handle closures.
2390 (Ffunctionp): Move from subr.el.
2391 (Ffuncall): Handle closures.
2392 (apply_lambda): Remove `eval_flags'.
2393 (funcall_lambda): Handle closures and new byte-code-functions.
2394 (Fspecial_variable_p): New function.
2395 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2396 but without exporting it to Lisp.
2397
2398 * doc.c (Fdocumentation, store_function_docstring):
2399 * data.c (Finteractive_form): Handle closures.
2400
2401 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2402 interactive spec.
2403
2404 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
2405 byte-codes.
2406 (exec_byte_code): New function extracted from Fbyte_code to handle new
2407 calling convention for byte-code-functions. Add new byte-codes.
2408
2409 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2410
2411 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2412
2413 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2414
2415 * xdisp.c (redisplay_internal): Fix prototype.
2416
2417 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2418
2419 * xdisp.c (SCROLL_LIMIT): New macro.
2420 (try_scrolling): Use it when setting scroll_limit. Limit
2421 scrolling to 100 screen lines.
2422 (redisplay_window): Even when falling back on "recentering",
2423 position point in the window according to scroll-conservatively,
2424 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2425
2426 (try_scrolling): When point is above the window, allow searching
2427 as far as scroll_max, or one screenful, to compute vertical
2428 distance from PT to the scroll margin position. This prevents
2429 try_scrolling from unnecessarily failing when
2430 scroll-conservatively is set to a value slightly larger than the
2431 window height. Clean up the case of PT below the margin at bottom
2432 of window: scroll_max can no longer be INT_MAX. When aggressive
2433 scrolling is in use, don't let point enter the opposite scroll
2434 margin as result of the scroll.
2435 (syms_of_xdisp) <scroll-conservatively>: Document the
2436 threshold of 100 lines for never-recentering scrolling.
2437
2438 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2439
2440 * dispextern.h (move_it_by_lines):
2441 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2442 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2443 (message_log_check_duplicate): Remove parameters `prev_bol' and
2444 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2445 (redisplay_internal): Remove parameter `preserve_echo_area',
2446 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2447
2448 * indent.c (Fvertical_motion):
2449 * window.c (window_scroll_pixel_based, Frecenter):
2450 Don't pass `need_y_p' to `move_it_by_lines'.
2451
2452 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2453
2454 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2455 steal a few bits to be more compact.
2456 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2457 Remove unneeded casts.
2458
2459 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2460
2461 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2462
2463 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2464 binding" message (bug#7967).
2465
2466 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2467
2468 Fix more problems found by GCC 4.6.0's static checks.
2469
2470 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2471 Remove unused local var.
2472
2473 * editfns.c (Fmessage_box): Remove unused local var.
2474
2475 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2476 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2477 Omit unused local vars.
2478 * window.c (shrink_windows): Omit unused local var.
2479 * menu.c (digest_single_submenu): Omit unused local var.
2480 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2481 Omit unused local var.
2482
2483 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2484 Don't assume string length fits in int.
2485 (keyremap_step, read_key_sequence): Use size_t for sizes.
2486 (read_key_sequence): Don't check last_real_key_start redundantly.
2487
2488 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2489 instead of alloca (Bug#8344).
2490
2491 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2492 (Fbacktrace_frame): Don't assume nframes fits in int.
2493
2494 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2495
2496 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2497 concerns.
2498
2499 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2500
2501 * cm.c (calccost): Turn while-do into do-while, for clarity.
2502
2503 * keyboard.c (syms_of_keyboard): Use the same style as later
2504 in this function when indexing through an array. This also
2505 works around GCC bug 48267.
2506
2507 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2508
2509 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2510
2511 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2512 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2513
2514 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2515 This avoids undefined behavior on integer overflow, and is a bit
2516 more convenient anyway since it is compared to a size_t variable.
2517
2518 Variadic C functions now count arguments with size_t, not int.
2519 This avoids an unnecessary limitation on 64-bit machines, which
2520 caused (substring ...) to crash on large vectors (Bug#8344).
2521 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2522 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
2523 All variadic functions and their callers changed accordingly.
2524 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2525 * data.c (arith_driver, float_arith_driver): Likewise.
2526 * editfns.c (general_insert_function): Likewise.
2527 * eval.c (struct backtrace.nargs, interactive_p)
2528 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2529 (funcall_lambda, mark_backtrace): Likewise.
2530 * fns.c (concat): Likewise.
2531 * frame.c (x_set_frame_parameters): Likewise.
2532 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2533 0 if not found, not -1. All callers changed.
2534
2535 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2536 (stack_copy_size): Now size_t, not int.
2537 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2538
2539 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2540
2541 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2542 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2543 All callers changed.
2544
2545 * lisp.h (multibyte_char_to_unibyte):
2546 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2547 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2548 * character.h (CHAR_TO_BYTE8):
2549 * cmds.c (internal_self_insert):
2550 * editfns.c (general_insert_function):
2551 * keymap.c (push_key_description):
2552 * search.c (Freplace_match):
2553 * xdisp.c (message_dolog, set_message_1): All callers changed.
2554
2555 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2556
2557 * keyboard.c (safe_run_hook_funcall): New function.
2558 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2559 don't set the hook to nil, but remove the offending function instead.
2560 (Qcommand_hook_internal): Remove, unused.
2561 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2562 Vcommand_hook_internal.
2563
2564 * eval.c (enum run_hooks_condition): Remove.
2565 (funcall_nil, funcall_not): New functions.
2566 (run_hook_with_args): Call each function through a `funcall' argument.
2567 Remove `cond' argument, now redundant.
2568 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2569 (Frun_hook_with_args_until_failure): Adjust accordingly.
2570 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2571
2572 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2573
2574 * dispextern.h (string_buffer_position): Remove declaration.
2575
2576 * print.c (strout): Remove parameter `multibyte', unused since
2577 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2578
2579 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2580 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2581 All callers changed.
2582
2583 * w32.c (_wsa_errlist): Use braces for struct initializers.
2584
2585 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2586 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2587 All callers changed.
2588 (string_buffer_position): Likewise. Also, make static (it's never
2589 used outside xdisp.c).
2590 (cursor_row_p): Remove parameter `w', unused since
2591 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2592 (decode_mode_spec): Remove parameter `precision', introduced during
2593 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2594 All callers changed.
2595
2596 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2597
2598 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2599
2600 2011-03-27 Anders Lindgren <andlind@gmail.com>
2601
2602 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2603 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2604 (ns_update_auto_hide_menu_bar): New functions.
2605 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2606 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2607 ns_constrain_all_frames.
2608 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2609 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2610
2611 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2612
2613 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2614
2615 2011-03-27 Glenn Morris <rgm@gnu.org>
2616
2617 * syssignal.h: Replace RETSIGTYPE with void.
2618 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2619 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2620 Replace SIGTYPE with void everywhere.
2621 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2622 * s/template.h (SIGTYPE): Remove commented out definition.
2623
2624 2011-03-26 Eli Zaretskii <eliz@gnu.org>
2625
2626 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2627 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2628
2629 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
2630
2631 * w32.c (read_unc_volume): Use parameter `henum', instead of
2632 global variable `wget_enum_handle'.
2633
2634 * keymap.c (describe_vector): Remove parameters `indices' and
2635 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2636 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2637
2638 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2639
2640 * keyboard.c (timer_check): Remove parameter `do_it_now',
2641 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2642 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2643 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2644
2645 * keyboard.c (read_char):
2646 * w32menu.c (w32_menu_display_help):
2647 * xmenu.c (show_help_event, menu_help_callback):
2648 Adjust calls to `show_help_echo'.
2649
2650 * gtkutil.c (xg_maybe_add_timer):
2651 * keyboard.c (readable_events):
2652 * process.c (wait_reading_process_output):
2653 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2654
2655 * insdel.c (adjust_markers_gap_motion):
2656 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2657 (gap_left, gap_right): Don't call it.
2658
2659 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
2660
2661 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2662 incurred during fontification.
2663
2664 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2665
2666 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2667 (DEFVAR_PER_BUFFER): Don't pass it.
2668
2669 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2670 (scrolling_window): Don't pass it.
2671
2672 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2673
2674 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2675
2676 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2677 and `suffix'.
2678 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2679 of variables specific to SELinux and computation of `encoded_absname'.
2680
2681 * image.c (XPutPixel): Remove unused variable `height'.
2682
2683 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2684
2685 * unexw32.c (get_section_info): Remove unused variable `section'.
2686
2687 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2688 (system_process_attributes): Remove unused variable `sess'.
2689 (sys_read): Remove unused variable `err'.
2690
2691 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2692 (w32_wnd_proc): Remove unused variable `isdead'.
2693 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2694 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2695 (x_create_tip_frame): Remove unused variable `tem'.
2696
2697 * w32inevt.c (w32_console_read_socket):
2698 Remove unused variable `no_events'.
2699
2700 * w32term.c (x_draw_composite_glyph_string_foreground):
2701 Remove unused variable `width'.
2702
2703 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
2704
2705 * w32term.c (x_set_glyph_string_clipping):
2706 Don't pass uninitialized region to CombineRgn.
2707
2708 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
2709
2710 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2711 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2712 (Fx_close_connection): Remove unused variable `i'.
2713
2714 * w32font.c (w32font_draw): Return number of glyphs.
2715 (w32font_open_internal): Remove unused variable `i'.
2716 (w32font_driver): Add missing initializer.
2717
2718 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2719 (fill_in_menu): Remove unused variable `items_added'.
2720
2721 * w32term.c (last_mouse_press_frame): Remove static global variable.
2722 (w32_clip_to_row): Remove unused variable `f'.
2723 (x_delete_terminal): Remove unused variable `i'.
2724
2725 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2726 (NOTHING): Remove unused static global variable.
2727 (uniscribe_check_otf): Remove unused variable `table'.
2728 (uniscribe_font_driver): Add missing initializers.
2729
2730 2011-03-23 Julien Danjou <julien@danjou.info>
2731
2732 * term.c (Fsuspend_tty, Fresume_tty):
2733 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2734 * window.c (temp_output_buffer_show):
2735 * insdel.c (signal_before_change):
2736 * frame.c (Fhandle_switch_frame):
2737 * fileio.c (Fdo_auto_save):
2738 * emacs.c (Fkill_emacs):
2739 * editfns.c (save_excursion_restore):
2740 * cmds.c (internal_self_insert):
2741 * callint.c (Fcall_interactively):
2742 * buffer.c (Fkill_all_local_variables):
2743 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2744 Use Frun_hooks.
2745 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
2746 unconditionnaly since it does the check itself.
2747
2748 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
2749
2750 Fix more problems found by GCC 4.5.2's static checks.
2751
2752 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2753 the first time through the loop, since we know p0 < p1 then.
2754 This also avoids a gcc -Wstrict-overflow warning.
2755
2756 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2757 leading to a memory leak, possible in functions like
2758 load_charset_map_from_file that can allocate an unbounded number
2759 of objects (Bug#8318).
2760
2761 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2762 that could (at least in theory) be that large.
2763
2764 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2765 This is less likely to overflow, and avoids undefined behavior if
2766 overflow does occur. All callers changed. Use strtoul to scan
2767 for the unsigned long integer.
2768 (pint2hrstr): Simplify and tune code slightly.
2769 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
2770
2771 * scroll.c (do_scrolling): Work around GCC bug 48228.
2772 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2773
2774 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2775 This also avoids a warning with gcc -Wstrict-overflow.
2776 (validate_x_resource_name): Simplify count usage.
2777 This also avoids a warning with gcc -Wstrict-overflow.
2778
2779 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2780 fail (Bug#8306).
2781
2782 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
2783
2784 * process.c (Fmake_network_process): Use socklen_t, not int,
2785 where POSIX says socklen_t is required in portable programs.
2786 This fixes a porting bug on hosts like 64-bit HP-UX, where
2787 socklen_t is wider than int (Bug#8277).
2788 (Fmake_network_process, server_accept_connection):
2789 (wait_reading_process_output, read_process_output):
2790 Likewise.
2791
2792 * process.c: Rename or move locals to avoid shadowing.
2793 (list_processes_1, Fmake_network_process):
2794 (read_process_output_error_handler, exec_sentinel_error_handler):
2795 Rename or move locals.
2796 (Fmake_network_process): Define label "retry_connect" only if needed.
2797 (Fnetwork_interface_info): Fix pointer signedness.
2798 (process_send_signal): Add cast to avoid pointer signedness problem.
2799 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
2800 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
2801
2802 Make tparam.h and terminfo.c consistent.
2803 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2804 Include tparam.h instead, since it declares them.
2805 * cm.h (PC): Remove extern decl; tparam.h now does this.
2806 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2807 * terminfo.c: Include tparam.h, to check interfaces.
2808 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2809 (tparam): Adjust signature to match interface in tparam.h;
2810 this removes some undefined behavior. Check that outstring and len
2811 are zero, which they always are with Emacs.
2812 * tparam.h (PC, BC, UP): New extern decls.
2813
2814 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
2815 (xftfont_open): Rename locals to avoid shadowing.
2816
2817 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
2818 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2819 (OTF_TAG_SYM): Omit macro if not needed.
2820 (ftfont_list): Remove unused local.
2821 (get_adstyle_property, ftfont_pattern_entity):
2822 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2823 Rename locals to avoid shadowing.
2824
2825 * xfont.c (xfont_list_family): Mark var as initialized.
2826
2827 * xml.c (make_dom): Now static.
2828
2829 * composite.c (composition_compute_stop_pos): Rename local to
2830 avoid shadowing.
2831 (composition_reseat_it): Remove unused locals.
2832 (find_automatic_composition, composition_adjust_point): Likewise.
2833 (composition_update_it): Mark var as initialized.
2834 (find_automatic_composition): Mark vars as initialized,
2835 with a FIXME (Bug#8290).
2836
2837 character.h: Rename locals to avoid shadowing.
2838 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2839 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2840 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2841 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2842 to avoid shadowing.
2843
2844 * textprop.c (property_change_between_p): Remove; unused.
2845
2846 * intervals.c (interval_start_pos): Now static.
2847
2848 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2849
2850 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2851 Rename locals to avoid shadowing.
2852
2853 * sound.c (wav_play, au_play, Fplay_sound_internal):
2854 Fix pointer signedness.
2855 (alsa_choose_format): Remove unused local var.
2856 (wav_play): Initialize a variable to 0, to prevent undefined
2857 behavior (Bug#8278).
2858
2859 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2860
2861 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2862
2863 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2864 clobbering (Bug#8298).
2865 * sysdep.c (sys_subshell): Likewise.
2866 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
2867
2868 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2869 This should get cleaned up, so that child_setup has the
2870 same signature on all platforms.
2871
2872 * callproc.c (call_process_cleanup): Now static.
2873 (relocate_fd): Rename locals to avoid shadowing.
2874
2875 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
2876
2877 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2878 not to be necessary, and produces flickering.
2879
2880 2011-03-20 Glenn Morris <rgm@gnu.org>
2881
2882 * config.in: Remove file.
2883
2884 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
2885
2886 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2887 are now in src/globals.h.
2888 (syms_of_minibuf): Remove spurious & from previous change.
2889
2890 2011-03-20 Leo <sdl.web@gmail.com>
2891
2892 * minibuf.c (completing-read-function): New variable.
2893 (completing-read-default): Rename from completing-read.
2894 (completing-read): Call completing-read-function.
2895
2896 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2897
2898 * xfaces.c (Fx_load_color_file):
2899 Read color file from absolute filename (bug#8250).
2900
2901 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2902
2903 * makefile.w32-in: Update dependencies.
2904
2905 2011-03-17 Eli Zaretskii <eliz@gnu.org>
2906
2907 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2908
2909 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2910
2911 Fix more problems found by GCC 4.5.2's static checks.
2912
2913 * process.c (make_serial_process_unwind, send_process_trap):
2914 (sigchld_handler): Now static.
2915
2916 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2917 That way, the code declares only the vars that it needs.
2918 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2919 * s/cygwin.h (PTY_ITERATION): Likewise.
2920 * s/darwin.h (PTY_ITERATION): Likewise.
2921 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2922
2923 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2924 * process.c (allocate_pty): Don't declare stb unless it's needed.
2925
2926 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
2927 (CONSTANTLIM): Remove; unused.
2928 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2929 Define only if needed.
2930
2931 * unexelf.c (unexec): Name an expression,
2932 to avoid gcc -Wbad-function-cast warning.
2933 Use a different way to cause a compilation error if anyone uses
2934 n rather than nn, a way that does not involve shadowing.
2935 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
2936
2937 * deps.mk (unexalpha.o): Remove; unused.
2938
2939 New file unexec.h, the (simple) interface for unexec (Bug#8267).
2940 * unexec.h: New file.
2941 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2942 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2943 Depend on unexec.h.
2944 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2945 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2946 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
2947 Change as necessary to match prototype in unexec.h.
2948
2949 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2950 shadowing.
2951 (back_comment, skip_chars): Mark vars as initialized.
2952
2953 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2954 Rename locals to avoid shadowing.
2955
2956 * lread.c (read1): Rewrite so as not to use empty "else".
2957 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
2958
2959 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2960
2961 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2962 warning when compiling print.c.
2963
2964 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2965 instead of using an uninitialized var.
2966 (font_sort_entities): Mark var as initialized.
2967
2968 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2969
2970 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2971 pointers to constants.
2972 (font_parse_fcname): Remove unused vars.
2973 (font_delete_unmatched): Now static.
2974 (font_get_spec): Remove; unused.
2975 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2976 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2977 Rename or move locals to avoid shadowing.
2978
2979 * fns.c (require_nesting_list, require_unwind): Now static.
2980 (Ffillarray): Rename locals to avoid shadowing.
2981
2982 * floatfns.c (domain_error2): Define only if needed.
2983 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
2984
2985 * alloc.c (mark_backtrace): Move decl from here ...
2986 * lisp.h: ... to here, so that it can be checked.
2987
2988 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
2989 (Fdefvar): Rewrite so as not to use empty "else".
2990 (lisp_indirect_variable): Name an expression,
2991 to avoid gcc -Wbad-function-cast warning.
2992 (Fdefvar): Rename locals to avoid shadowing.
2993
2994 * callint.c (quotify_arg, quotify_args): Now static.
2995 (Fcall_interactively): Rename locals to avoid shadowing.
2996 Use const pointer when appropriate.
2997
2998 * lisp.h (get_system_name, get_operating_system_release):
2999 Move decls here, to check interfaces.
3000 * process.c (get_operating_system_release): Move decl to lisp.h.
3001 * xrdb.c (get_system_name): Likewise.
3002 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3003 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3004 some of which prompt warnings from gcc -Wbad-function-cast.
3005 (Fformat_time_string, Fencode_time, Finsert_char):
3006 (Ftranslate_region_internal, Fformat):
3007 Rename or remove local vars to avoid shadowing.
3008 (Ftranslate_region_internal): Mark var as initialized.
3009
3010 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3011 avoid shadowing.
3012
3013 * lisp.h (eassert): Check that the argument compiles, even if
3014 ENABLE_CHECKING is not defined.
3015
3016 * data.c (Findirect_variable): Name an expression, to avoid
3017 gcc -Wbad-function-cast warning.
3018 (default_value, arithcompare, arith_driver, arith_error): Now static.
3019 (store_symval_forwarding): Rename local to avoid shadowing.
3020 (Fmake_variable_buffer_local, Fmake_local_variable):
3021 Mark variables as initialized.
3022 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3023
3024 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
3025 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3026 Rename locals to avoid shadowing.
3027 (mark_stack): Move local variables into the #ifdef region where
3028 they're used.
3029 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3030 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3031 needed otherwise.
3032 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3033 (GC_STRING_CHARS): Remove; not used.
3034 (Fmemory_limit): Cast sbrk's returned value to char *.
3035
3036 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3037 avoids undefined behavior in theory.
3038
3039 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3040
3041 Use functions, not macros, for up- and down-casing (Bug#8254).
3042 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3043 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3044 to use the following functions instead of these macros.
3045 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3046 EMACS_INT, since callers assume the returned value fits in int.
3047 (upcase1): Likewise, for UPCASE_TABLE.
3048 (uppercasep, lowercasep, upcase): New static inline functions.
3049 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
3050 the race-condition problem in the old DOWNCASE.
3051
3052 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3053 Rename locals to avoid shadowing.
3054 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
3055 (regex_compile, re_search_2, re_match_2_internal):
3056 Remove unused local vars.
3057 (FREE_VAR): Rewrite so as not to use empty "else",
3058 which gcc can warn about.
3059 (regex_compile, re_match_2_internal): Mark locals as initialized.
3060 (RETALLOC_IF): Define only if needed.
3061 (WORDCHAR_P): Likewise. This one is never needed, but is used
3062 only in a comment talking about a compiler bug, so put inside
3063 the #if 0 of that comment.
3064 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3065 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3066 Remove; unused.
3067
3068 * search.c (boyer_moore): Rename locals to avoid shadowing.
3069 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3070 (PREV_CHAR_BOUNDARY): Likewise.
3071
3072 * search.c (simple_search): Remove unused var.
3073
3074 * dired.c (compile_pattern): Move decl from here ...
3075 * lisp.h: ... to here, so that it can be checked.
3076 (struct re_registers): New forward decl.
3077
3078 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3079
3080 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3081 All uses changed.
3082 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3083 Rename locals to avoid shadowing.
3084 (Fvertical_motion): Mark locals as initialized.
3085
3086 * casefiddle.c (casify_object, casify_region): Now static.
3087 (casify_region): Mark local as initialized.
3088
3089 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3090
3091 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3092 New macros, so that the caller can use some names other than
3093 gcpro1, gcpro2, etc.
3094 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3095 of the new macros.
3096 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3097 argument, for consistency with GCPRO2_VAR, etc: it is now the
3098 prefix of the variable, not the variable itself. All uses
3099 changed.
3100 * dired.c (directory_files_internal, file_name_completion):
3101 Rename locals to avoid shadowing.
3102
3103 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3104 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3105 dired.c's scmp function, had undefined behavior.
3106 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3107 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3108 * buffer.h: ... to here, because these macros use current_buffer,
3109 and the new implementation with inline functions needs to have
3110 current_buffer in scope now, rather than later when the macros
3111 are used.
3112 (downcase, upcase1): New static inline functions.
3113 (DOWNCASE, UPCASE1): Reimplement using these functions.
3114 This avoids undefined behavior in expressions like
3115 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3116 from race conditions in accessing the global variables
3117 case_temp1 and case_temp2.
3118 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3119 * lisp.h (case_temp1, case_temp2): Remove their decls.
3120 * character.h (ASCII_CHAR_P): Move from here ...
3121 * lisp.h: ... to here, so that the inline functions mentioned
3122 above can use them.
3123
3124 * dired.c (directory_files_internal_unwind): Now static.
3125
3126 * fileio.c (file_name_as_directory, directory_file_name):
3127 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3128 Now static.
3129 (file_name_as_directory): Use const pointers when appropriate.
3130 (Fexpand_file_name): Likewise. In particular, newdir might
3131 point at constant storage, so make it a const pointer.
3132 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
3133 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3134 signedness issues.
3135 (Fset_file_times, Finsert_file_contents, auto_save_error):
3136 Rename locals to avoid shadowing.
3137
3138 * minibuf.c (choose_minibuf_frame_1): Now static.
3139 (Ftry_completion, Fall_completions): Rename or remove locals
3140 to avoid shadowing.
3141
3142 * marker.c (bytepos_to_charpos): Remove; unused.
3143
3144 * lisp.h (verify_bytepos, count_markers): New decls,
3145 so that gcc does not warn that these functions aren't declared.
3146
3147 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3148 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
3149 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
3150 (copy_text): Remove unused local var.
3151
3152 * filelock.c (within_one_second): Now static.
3153 (lock_file_1): Rename local to avoid shadowing.
3154
3155 * buffer.c (fix_overlays_before): Mark locals as initialized.
3156 (fix_start_end_in_overlays): Likewise. This function should be
3157 simplified by using pointers-to-pointers, but that's a different
3158 matter.
3159 (switch_to_buffer_1): Now static.
3160 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3161 (report_overlay_modification): Rename locals to avoid shadowing.
3162
3163 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
3164 Fix pointer signedness issue.
3165 (sys_subshell): Mark local as volatile if checking for lint,
3166 to suppress a gcc -Wclobbered warning that does not seem to be right.
3167 (MAXPATHLEN): Define only if needed.
3168
3169 * process.c (serial_open, serial_configure): Move decls from here ...
3170 * systty.h: ... to here, so that they can be checked.
3171
3172 * fns.c (get_random, seed_random): Move extern decls from here ...
3173 * lisp.h: ... to here, so that they can be checked.
3174
3175 * sysdep.c (reset_io): Now static.
3176 (wait_for_termination_signal): Remove; unused.
3177
3178 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3179 (copy_keymap_item, append_key, push_text_char_description):
3180 Now static.
3181 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
3182 (DENSE_TABLE_SIZE): Remove; unused.
3183 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3184 (describe_map_tree):
3185 Rename locals to avoid shadowing.
3186
3187 * keyboard.c: Declare functions static if they are not used elsewhere.
3188 (echo_char, echo_dash, cmd_error, top_level_2):
3189 (poll_for_input, handle_async_input): Now static.
3190 (read_char, kbd_buffer_get_event, make_lispy_position):
3191 (make_lispy_event, make_lispy_movement, apply_modifiers):
3192 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3193 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3194 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
3195 (read_key_sequence, read_char): Mark locals as initialized.
3196 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
3197
3198 * keyboard.h (make_ctrl_char): New decl.
3199 (mark_kboards): Move decl here ...
3200 * alloc.c (mark_kboards): ... from here.
3201
3202 * lisp.h (force_auto_save_soon): New decl.
3203
3204 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3205 (DEFINE_DUMMY_FUNCTION): New macro.
3206 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3207 Use it.
3208 (main): Add casts to avoid warnings
3209 if GCC considers string literals to be constants.
3210
3211 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3212
3213 * dbusbind.c: Pointer signedness fixes.
3214 (xd_signature, xd_append_arg, xd_initialize):
3215 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3216 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3217 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3218 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3219
3220 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3221 if GCC considers string literals to be constants.
3222 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3223
3224 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3225
3226 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3227 (print_preprocess, print_object): New macro to fix last change.
3228
3229 * print.c (print_preprocess): Don't forget font objects.
3230
3231 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
3232
3233 * emacs.c (USAGE3): Doc fixes.
3234
3235 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3236
3237 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3238 structure.
3239
3240 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3241
3242 * lisp.h (VWindow_system, Qfile_name_history):
3243 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3244 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3245 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3246
3247 * w32select.c: Don't #include "keyboard.h".
3248 (run_protected): Add extern declaration for waiting_for_input.
3249
3250 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3251 * w32console.c (detect_input_pending, read_input_pending)
3252 (encode_terminal_code):
3253 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3254 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3255 (w32_system_caret_y, Qfile_name_history):
3256 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3257 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3258 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3259 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3260 * w32proc.c (Qlocal, report_file_error):
3261 * w32term.c (Vwindow_system, updating_frame):
3262 * w32uniscribe.c (initialized, uniscribe_font_driver):
3263 Remove unneeded extern declarations.
3264
3265 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3266
3267 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3268
3269 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3270
3271 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3272 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3273 These macros can no longer be used for assignment.
3274
3275 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3276 Assign struct members directly, instead of using BUF_BEGV etc.
3277 (record_buffer_markers, fetch_buffer_markers): New functions for
3278 recording and fetching special buffer markers.
3279 (set_buffer_internal_1, set_buffer_temp): Use them.
3280
3281 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3282
3283 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3284
3285 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3286 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3287
3288 * xdisp.c (hscroll_window_tree):
3289 (reconsider_clip_changes): Use PT instead of BUF_PT.
3290
3291 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3292
3293 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3294 $(EMACS_ROOT)/lib/intprops.h.
3295
3296 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3297
3298 Fix more problems found by GCC 4.5.2's static checks.
3299
3300 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3301 to unsigned char * to avoid compiler diagnostic.
3302 (xg_free_frame_widgets): Make it clear that a local variable is
3303 needed only if USE_GTK_TOOLTIP.
3304 (gdk_window_get_screen): Make it clear that this macro is needed
3305 only if USE_GTK_TOOLTIP.
3306 (int_gtk_range_get_value): New function, which avoids a diagnostic
3307 from gcc -Wbad-function-cast.
3308 (xg_set_toolkit_scroll_bar_thumb): Use it.
3309 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3310 diagnostic from gcc -Wbad-function-cast.
3311 (get_utf8_string, xg_get_file_with_chooser):
3312 Rename locals to avoid shadowing.
3313 (create_dialog): Move locals to avoid shadowing.
3314
3315 * xgselect.c (xg_select): Remove unused var.
3316
3317 * image.c (four_corners_best): Mark locals as initialized.
3318 (gif_load): Initialize transparent_p to zero (Bug#8238).
3319 Mark another local as initialized.
3320 (my_png_error, my_error_exit): Mark with NO_RETURN.
3321
3322 * image.c (clear_image_cache): Now static.
3323 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3324 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3325 (x_edge_detection): Remove unnecessary cast that
3326 gcc -Wbad-function-cast diagnoses.
3327 (gif_load): Fix pointer signedness.
3328 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3329 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3330
3331 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3332
3333 Improve quality of tests for time stamp overflow.
3334 For example, without this patch (encode-time 0 0 0 1 1
3335 1152921504606846976) returns the obviously-bogus value (-948597
3336 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3337 reports time overflow. See
3338 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3339 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3340 * editfns.c: Include limits.h and intprops.h.
3341 (TIME_T_MIN, TIME_T_MAX): New macros.
3342 (time_overflow): Move earlier, to before first use.
3343 (hi_time, lo_time): New functions, for an accurate test for
3344 out-of-range times.
3345 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3346 (Fget_internal_run_time): Don't assume time_t fits in int.
3347 (make_time): Use list2 instead of Fcons twice.
3348 (Fdecode_time): More accurate test for out-of-range times.
3349 (check_tm_member): New function.
3350 (Fencode_time): Use it, to test for out-of-range times.
3351 (lisp_time_argument): Don't rely on undefined left-shift and
3352 right-shift behavior when checking for time stamp overflow.
3353
3354 * editfns.c (time_overflow): New function, refactoring common code.
3355 (Fformat_time_string, Fdecode_time, Fencode_time):
3356 (Fcurrent_time_string): Use it.
3357
3358 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3359 * dired.c (make_time): Move to ...
3360 * editfns.c (make_time): ... here.
3361 * systime.h: Note the move.
3362
3363 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3364
3365 * fringe.c (update_window_fringes): Remove unused variables.
3366
3367 * unexmacosx.c (copy_data_segment): Also copy __got section.
3368 (Bug#8223)
3369
3370 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3371
3372 * termcap.c [MSDOS]: Include "msdos.h".
3373 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3374 Constify `char *' arguments and their references according to
3375 prototypes in tparam.h.
3376
3377 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3378
3379 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3380 Adapt all references accordingly.
3381
3382 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3383
3384 2011-03-11 Tom Tromey <tromey@redhat.com>
3385
3386 * buffer.c (syms_of_buffer): Remove obsolete comment.
3387
3388 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3389
3390 * termhooks.h (encode_terminal_code): Declare prototype.
3391
3392 * msdos.c (encode_terminal_code): Don't declare prototype.
3393
3394 * term.c (encode_terminal_code): Now external again, used by
3395 w32console.c and msdos.c.
3396
3397 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3398 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3399
3400 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3401
3402 Fix some minor problems found by GCC 4.5.2's static checks.
3403
3404 * fringe.c (update_window_fringes): Mark locals as initialized
3405 (Bug#8227).
3406 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3407
3408 * alloc.c (mark_fringe_data): Move decl from here ...
3409 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3410 to check its interface.
3411 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3412
3413 * fontset.c (free_realized_fontset): Now static.
3414 (Fset_fontset_font): Rename local to avoid shadowing.
3415 (fontset_font): Mark local as initialized.
3416 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3417
3418 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3419
3420 * xselect.c (x_disown_buffer_selections): Remove; not used.
3421 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3422 (x_own_selection, Fx_disown_selection_internal): Rename locals
3423 to avoid shadowing.
3424 (x_handle_dnd_message): Remove local to avoid shadowing.
3425
3426 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3427 so that the caller can use some name other than gcpro1.
3428 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3429 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3430 (Fx_backspace_delete_keys_p):
3431 Use them to avoid shadowing, and rename vars to avoid shadowing.
3432 (x_decode_color, x_set_name, x_window): Now static.
3433 (Fx_create_frame): Add braces to silence GCC warning.
3434 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3435 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3436 Remove unused locals.
3437 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3438 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3439 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3440 macros.
3441
3442 * xterm.h (x_mouse_leave): New decl.
3443
3444 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3445 Remove unused functions.
3446 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3447 (x_calc_absolute_position): Now static.
3448 (XTread_socket): Don't define label "out" unless it's used.
3449 Don't declare local "event" unless it's used.
3450 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3451 unless they are used.
3452 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3453 (x_fatal_error_signal): Remove; not used.
3454 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3455 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3456 (x_error_catcher, x_connection_closed, x_error_handler):
3457 (x_error_quitter, xembed_send_message, x_iconify_frame):
3458 (my_log_handler): Rename locals to avoid shadowing.
3459 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3460 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3461
3462 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3463 Rename or move locals to avoid shadowing.
3464 (tty_defined_color, merge_face_heights): Now static.
3465 (free_realized_faces_for_fontset): Remove; not used.
3466 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3467 does not deduce is never used uninitialized.
3468 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3469 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3470
3471 * terminal.c (store_terminal_param): Now static.
3472
3473 * xmenu.c (menu_highlight_callback): Now static.
3474 (set_frame_menubar): Remove unused local.
3475 (xmenu_show): Rename parameter to avoid shadowing.
3476 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3477 since they might point to immutable storage.
3478 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3479 since it's unused otherwise.
3480
3481 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3482 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3483 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3484 avoids a gcc -Wuninitialized diagnostic.
3485 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3486 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3487 does not deduce are never used uninitialized.
3488
3489 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3490
3491 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3492 * window.c (window_loop, size_window):
3493 (run_window_configuration_change_hook, enlarge_window): Likewise.
3494
3495 * window.c (display_buffer): Now static.
3496 (size_window): Mark variables that gcc -Wuninitialized
3497 does not deduce are never used uninitialized.
3498 * window.h (check_all_windows): New decl, to forestall
3499 gcc -Wmissing-prototypes diagnostic.
3500 * dispextern.h (bidi_dump_cached_states): Likewise.
3501
3502 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3503 shadowing.
3504 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3505 Include <limits.h>.
3506 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3507 and to avoid gcc -Wuninitialized warning.
3508 (load_charset_map): Mark variables that gcc -Wuninitialized
3509 does not deduce are never used uninitialized.
3510 (load_charset): Abort instead of using uninitialized var (Bug#8229).
3511
3512 * coding.c (coding_set_source, coding_set_destination):
3513 Use "else { /* comment */ }" rather than "else /* comment */;"
3514 for clarity, and to avoid gcc -Wempty-body warning.
3515 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3516 a block, when the outer 'i' will do.
3517 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3518 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3519 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3520 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3521 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3522 Rename locals to avoid shadowing.
3523 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
3524 * coding.c (emacs_mule_char, encode_invocation_designation):
3525 Now static, since they're not used elsewhere.
3526 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
3527 (decode_coding_object, encode_coding_object, detect_coding_system):
3528 (decode_coding_emacs_mule): Mark variables that gcc
3529 -Wuninitialized does not deduce are never used uninitialized.
3530 (detect_coding_iso_2022): Initialize a local variable that might
3531 be used uninitialized. Leave a FIXME because it's not clear that
3532 this initialization is needed. (Bug#8211)
3533 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3534 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3535 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3536 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3537 Remove unused macros.
3538
3539 * category.c (hash_get_category_set): Remove unused local var.
3540 (copy_category_table): Now static, since it's not used elsewhere.
3541 * character.c (string_count_byte8): Likewise.
3542
3543 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3544 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3545
3546 * chartab.c (copy_sub_char_table): Now static, since it's not used
3547 elsewhere.
3548 (sub_char_table_ref_and_range, char_table_ref_and_range):
3549 Rename locals to avoid shadowing.
3550 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
3551
3552 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
3553 (BIDI_BOB): Remove unused macro.
3554
3555 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3556 deduce are never used uninitialized.
3557 * term.c (encode_terminal_code): Likewise.
3558
3559 * term.c (encode_terminal_code): Now static. Remove unused local.
3560
3561 * tparam.h: New file.
3562 * term.c, tparam.h: Include it.
3563 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3564 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3565 Move these decls to tparam.h, and make them agree with what
3566 is actually in tparam.c. The previous trick of using incompatible
3567 decls in different modules does not conform to the C standard.
3568 All callers of tparam changed to use tparam's actual API.
3569 * tparam.c (tparam1, tparam, tgoto):
3570 Use const pointers where appropriate.
3571
3572 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3573 * cm.h (struct cm): Likewise.
3574 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3575 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3576 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3577 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3578 (turn_on_face, init_tty): Likewise.
3579 * termchar.h (struct tty_display_info): Likewise.
3580
3581 * term.c (term_mouse_position): Rename local to avoid shadowing.
3582
3583 * alloc.c (mark_ttys): Move decl from here ...
3584 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3585
3586 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3587
3588 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3589
3590 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
3591
3592 * search.c (compile_pattern_1): Remove argument regp, unused since
3593 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3594 (compile_pattern): Don't pass it.
3595
3596 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3597
3598 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3599 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3600 for ! HAVE_GTK3.
3601 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3602
3603 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3604
3605 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3606 gdk_window_get_screen, gdk_window_get_geometry,
3607 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3608 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3609 (xg_get_pixbuf_from_pixmap): New function.
3610 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3611 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3612 Call xg_get_pixbuf_from_pixmap instead of
3613 gdk_pixbuf_get_from_drawable.
3614 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3615 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3616 (xg_check_special_colors): Use GtkStyleContext and its functions
3617 for HAVE_GTK3.
3618 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3619 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3620 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
3621 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3622 Call gtk_widget_get_preferred_size.
3623 (xg_frame_resized): gdk_window_get_geometry only takes 5
3624 parameters.
3625 (xg_win_to_widget, xg_event_is_for_menubar):
3626 Call gdk_x11_window_lookup_for_display.
3627 (xg_set_widget_bg): New function.
3628 (delete_cb): New function.
3629 (xg_create_frame_widgets): Connect delete-event to delete_cb.
3630 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3631 (xg_set_background_color): Call xg_set_widget_bg.
3632 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3633 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3634 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3635 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3636 if ! HAVE_GTK3.
3637 (update_frame_tool_bar): Call gtk_widget_hide.
3638 (xg_initialize): Use GDK_KEY_g.
3639
3640 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3641 if ! HAVE_GTK3
3642 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3643
3644 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3645 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3646 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3647
3648 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
3649
3650 * w32xfns.c (select_palette): Check success of RealizePalette against
3651 GDI_ERROR, not zero.
3652
3653 See ChangeLog.11 for earlier changes.
3654
3655 ;; Local Variables:
3656 ;; coding: utf-8
3657 ;; End:
3658
3659 Copyright (C) 2011 Free Software Foundation, Inc.
3660
3661 This file is part of GNU Emacs.
3662
3663 GNU Emacs is free software: you can redistribute it and/or modify
3664 it under the terms of the GNU General Public License as published by
3665 the Free Software Foundation, either version 3 of the License, or
3666 (at your option) any later version.
3667
3668 GNU Emacs is distributed in the hope that it will be useful,
3669 but WITHOUT ANY WARRANTY; without even the implied warranty of
3670 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3671 GNU General Public License for more details.
3672
3673 You should have received a copy of the GNU General Public License
3674 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.