Fix bug #9311 with loading on MS-Windows .elc files in root directories.
[bpt/emacs.git] / src / ChangeLog
1 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2
3 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
4 has no `load' handler, try opening the file locally. (Bug#9311)
5
6 2011-08-16 Ken Brown <kbrown@cornell.edu>
7
8 * gmalloc.c: Expand comment.
9
10 2011-08-16 Eli Zaretskii <eliz@gnu.org>
11
12 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
13 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
14
15 2011-08-16 Ken Brown <kbrown@cornell.edu>
16
17 Fix memory allocation problems in Cygwin build (Bug#9273).
18
19 * unexcw.c ( __malloc_initialized): Declare external variable.
20 (fixup_executable): Force the dumped emacs to reinitialize malloc.
21
22 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo): New
23 variables.
24 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
25 dumped emacs.
26 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
27 in the static heap.
28 [CYGWIN] (special_realloc): New function.
29 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
30 requests to realloc storage in the static heap.
31
32 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
33
34 * bidi.c (bidi_initialize): Remove unused local.
35
36 2011-08-15 Eli Zaretskii <eliz@gnu.org>
37
38 * biditype.h: File removed.
39
40 * bidimirror.h: File removed.
41
42 * deps.mk (bidi.o): Remove biditype.h and
43 bidimirror.h.
44
45 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
46 bidimirror.h.
47
48 * dispextern.h: Fix a typo in the comment to bidi_type_t.
49
50 * chartab.c: Improve commentary for the uniprop_table API.
51
52 * bidi.c (bidi_paragraph_init): Support zero value of
53 bidi_ignore_explicit_marks_for_paragraph_level.
54 (bidi_initialize): Use uniprop_table instead of including
55 biditype.h and bidimirror.h.
56
57 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
58 coordinates of the iterator when restoring from ppos_it.
59 (Bug#9296)
60
61 2011-08-14 Kenichi Handa <handa@m17n.org>
62
63 * process.c (create_process): Call setup_process_coding_systems
64 after the pid of the process is set to -1.
65
66 2011-08-14 Eli Zaretskii <eliz@gnu.org>
67
68 * xdisp.c (move_it_in_display_line_to): Don't invoke
69 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
70 ppos_it. Fixes vertical cursor motion when line beginning is
71 covered by an image. (Bug#9296)
72
73 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
74
75 * nsterm.h (ns_run_ascript): Declare.
76 (NSAPP_DATA2_RUNASSCRIPT): Define.
77
78 * nsfns.m (as_script, as_result, as_status): New static variables.
79 (ns_run_ascript): New function.
80 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
81 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
82 the event loop. Get status from as_status (Bug#7276).
83
84 * nsterm.m (sendEvent): If event is NSApplicationDefined and
85 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
86 the event loop (Bug#7276).
87
88 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
89
90 * gnutls.c (QCgnutls_bootprop_priority)
91 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
92 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
93 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
94 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
95 (QCgnutls_bootprop_verify_hostname_error)
96 (QCgnutls_bootprop_callbacks_verify): Rename from
97 Qgnutls_bootprop_..., all uses changed.
98
99 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
100 uses changed.
101
102 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
103
104 * xfaces.c (Qframe_set_background_mode): Now static.
105 * dispextern.h (Qframe_set_background_mode): Remove decl.
106
107 * process.c (Fnetwork_interface_info): Declare local only if needed.
108
109 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
110
111 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
112 (Fnetwork_interface_list): Allocate in increments of bytes instead
113 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
114 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
115 sockaddr.
116 (struct ifflag_def): notrailers is smart on OSX.
117 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
118 Get hardware address with getifaddrs if available.
119
120 2011-08-12 Eli Zaretskii <eliz@gnu.org>
121
122 * xdisp.c (iterate_out_of_display_property): xassert that
123 IT->position is set to within IT->object's boundaries. Break from
124 the loop as soon as EOB is reached; avoids infloops in redisplay
125 when IT->position is set up wrongly due to some bug. Set
126 IT->current to match the bidi iterator unconditionally.
127 (push_display_prop): Allow GET_FROM_STRING as IT->method on
128 entry. Force push_it to save on the stack the current
129 buffer/string position, to be restored by pop_it. Fix flags in
130 the iterator structure wrt the object coming from a display
131 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
132 properties. (Bug#9284)
133
134 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
135
136 * fontset.c (fontset_get_font_group): Add proper type checks.
137 (Bug#9172)
138
139 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
140
141 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
142 and LC_VERSION_MIN_MACOSX.
143 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
144 (dump_it) [LC_FUNCTION_STARTS]: Use it.
145
146 2011-08-08 Eli Zaretskii <eliz@gnu.org>
147
148 * xdisp.c (forward_to_next_line_start): Allow to use the
149 no-display-properties-and-no-overlays under bidi display. Set
150 disp_pos in the bidi iterator to avoid searches for display
151 properties and overlays.
152
153 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
154
155 * editfns.c (Fset_time_zone_rule): Document relationship with the
156 setenv function.
157
158 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
159 the font entity extracted from the cache (Bug#8109).
160
161 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
162
163 * composite.c (autocmp_chars): Don't reset point. That is done by
164 restore_point_unwind (Bug#5984).
165
166 2011-08-07 Juri Linkov <juri@jurta.org>
167
168 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
169 to show the arg `TIME' instead of `TIMEVAL'.
170
171 2011-08-06 Eli Zaretskii <eliz@gnu.org>
172
173 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
174 display property strides EOL and includes a newline, as in
175 longlines-mode. (Bug#9254)
176 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
177 word-wrap under bidirectional display. (Bug#9224)
178
179 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
180 is non-zero, even if the data buffer is NULL. Fixes a crash in
181 vertical-motion with longlines-mode. (Bug#9254)
182
183 2011-08-05 Eli Zaretskii <eliz@gnu.org>
184
185 * bidi.c <bidi_cache_total_alloc>: Now static.
186 (bidi_initialize): Initialize bidi_cache_total_alloc.
187
188 *xdisp.c (display_line): Release buffer allocated for shelved bidi
189 cache. (Bug#9221)
190
191 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
192 amount allocated this far in `bidi_cache_total_alloc'.
193 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
194 non-zero, only free the data buffer without restoring the cache
195 contents. All callers changed.
196
197 * dispextern.h (bidi_unshelve_cache): Update prototype.
198
199 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
200 (move_it_in_display_line, move_it_to)
201 (move_it_vertically_backward, move_it_by_lines): Replace the call
202 to xfree to an equivalent call to bidi_unshelve_cache.
203 (move_it_in_display_line_to): Fix logic of returning
204 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
205
206 2011-08-05 Eli Zaretskii <eliz@gnu.org>
207
208 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
209 came from a string character with a `cursor' property. (Bug#9229)
210
211 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
212
213 * Makefile.in (LIB_PTHREAD): New variable.
214 (LIBES): Add LIB_PTHREAD (Bug#9216).
215
216 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
217 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
218
219 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
220
221 * regex.c (re_iswctype): Remove some redundant boolean
222 conversions.
223
224 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
225
226 * xterm.c (x_find_topmost_parent): New function.
227 (x_set_frame_alpha): Find topmost parent window with
228 x_find_topmost_parent and set the property there also (bug#9181).
229 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
230
231 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
232
233 * callproc.c (Fcall_process): Avoid vfork clobbering
234 the local vars buffer, coding_systems, current_dir.
235
236 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
237
238 * keymap.c (Fmake_composed_keymap): Move to subr.el.
239
240 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
241
242 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
243 so that it is not optimized away.
244
245 * xdisp.c (compute_display_string_pos): Remove unused local.
246
247 2011-08-02 Eli Zaretskii <eliz@gnu.org>
248
249 Fix slow cursor motion and scrolling in large buffers with
250 selective display, like Org Mode buffers. (Bug#9218)
251
252 * dispextern.h (struct bidi_it): New member disp_prop_p.
253
254 * xdisp.c: Remove one-slot cache of display string positions.
255 (compute_display_string_pos): Accept an additional argument
256 DISP_PROP_P; callers changed. Scan at most 5K characters forward
257 for a display string or property. If found, set DISP_PROP_P
258 non-zero.
259
260 * bidi.c (bidi_fetch_char): Accept an additional argument
261 DISP_PROP_P, and pass it to compute_display_string_pos.
262 Only handle text covered by a display string if DISP_PROP_P is returned
263 non-zero. All callers of bidi_fetch_char changed.
264
265 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
266
267 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
268
269 2010-12-03 Don March <don@ohspite.net>
270
271 * keymap.c (Fdefine_key): Fix non-prefix key error message when
272 last character M-[char] is translated to ESC [char] (bug#7541).
273
274 2011-08-02 Kenichi Handa <handa@m17n.org>
275
276 * lisp.h (uniprop_table): Extern it.
277
278 * chartab.c (uniprop_table): Make it non-static.
279
280 2011-08-01 Eli Zaretskii <eliz@gnu.org>
281
282 * xdisp.c (forward_to_next_line_start): Accept additional argument
283 BIDI_IT_PREV, and store into it the state of the bidi iterator had
284 on the newline.
285 (reseat_at_next_visible_line_start): Use the bidi iterator state
286 returned by forward_to_next_line_start to restore the state of
287 it->bidi_it after backing up to previous newline. (Bug#9212)
288
289 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
290
291 * regex.c (re_comp): Protoize.
292 (re_exec): Fix return type.
293 (regexec): Fix type of `ret'. (Bug#9203)
294
295 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
296
297 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
298 This is needed if max-image-size is a floating-point number.
299
300 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
301
302 * print.c (print_object): Print empty symbol as ##.
303
304 * lread.c (read1): Read ## as empty symbol.
305
306 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
307
308 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
309 setting frame foreground color (Bug#9175).
310 (x_set_background_color): Likewise.
311
312 * nsmenu.m (-setText): Size tooltip dimensions precisely to
313 contents (Bug#9176).
314 (EmacsTooltip -init): Remove bezels and add shadows to
315 tooltip windows.
316
317 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
318 or scroll bar (Bug#8470).
319
320 * nsfont.m (nsfont_open): Remove assignment to voffset and
321 unnecessary vars hshink, expand, hd, full_height, min_height.
322 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
323
324 * nsterm.h (nsfont_info): Remove voffset field.
325
326 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
327
328 Implement strike-through and overline on NextStep (Bug#8863).
329
330 * nsfont.m (nsfont_open): Use underline position provided by font,
331 instead of hard-coded value of 2.
332 (nsfont_draw): Call ns_draw_text_decoration instead.
333
334 * nsterm.h: Add declaration for ns_draw_text_decoration.
335
336 * nsterm.m (ns_draw_text_decoration): New function for drawing
337 underline, overline, and strike-through.
338 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
339 ns_draw_text_decoration. Change treatment of cursor drawing to
340 accomodate underlining, etc.
341
342 2011-07-28 Eli Zaretskii <eliz@gnu.org>
343
344 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
345 default.
346
347 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
348
349 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
350 Without this fix, if a signal arrives just after memory fills up,
351 'malloc' might be invoked reentrantly.
352
353 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
354 In other words, assume that every image size is allowed, on non-X
355 hosts. This assumption is probably wrong, but it lets Emacs compile.
356
357 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
358
359 * regex.c (re_iswctype): Convert return values to boolean.
360
361 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
362
363 * xdisp.c (compute_display_string_pos): Don't use cached display
364 string position if the buffer had its restriction changed.
365 (Bug#9184)
366
367 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
368
369 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
370
371 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
372
373 Integer signedness and overflow and related fixes. (Bug#9079)
374
375 * bidi.c: Integer size and overflow fixes.
376 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
377 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
378 (bidi_cache_find_level_change, bidi_cache_ensure_space)
379 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
380 (bidi_find_other_level_edge):
381 Use ptrdiff_t instead of EMACS_INT where either will do.
382 This works better on 32-bit hosts configured --with-wide-int.
383 (bidi_cache_ensure_space): Check for size-calculation overflow.
384 Use % rather than repeated addition, for better worst-case speed.
385 Don't set bidi_cache_size until after xrealloc returns, because it
386 might not return.
387 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
388 (bidi_cache_ensure_space): Also check that the bidi cache size
389 does not exceed that of the largest Lisp string or buffer. See Eli
390 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
391
392 * alloc.c (__malloc_size_t): Remove.
393 All uses replaced by size_t. See Andreas Schwab's note
394 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
395
396 * image.c: Improve checking for integer overflow.
397 (check_image_size): Assume that f is nonnull, since
398 it is always nonnull in practice. This is one less thing to
399 worry about when checking for integer overflow later.
400 (x_check_image_size): New function, which checks for integer
401 overflow issues inside X.
402 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
403 This removes the need for a memory_full check.
404 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
405 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
406 (xbm_read_bitmap_data): Change locals back to 'int', since
407 their values must fit in 'int'.
408 (xpm_load_image, png_load, tiff_load):
409 Invoke x_create_x_image_and_pixmap earlier,
410 to avoid much needless work if the image is too large.
411 (tiff_load): Treat overly large images as if
412 x_create_x_image_and_pixmap failed, not as malloc failures.
413 (gs_load): Use x_check_image_size.
414
415 * gtkutil.c: Omit integer casts.
416 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
417 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
418
419 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
420
421 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
422 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
423 would wrongly return t on a 64-bit host.
424
425 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
426 The plain *_OVERFLOW macros run afoul of GCC bug 49705
427 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
428 and therefore cause GCC to emit a bogus diagnostic in some cases.
429
430 * image.c: Integer signedness and overflow and related fixes.
431 This is not an exhaustive set of fixes, but it's time to
432 record what I've got.
433 (lookup_pixel_color, check_image_size): Remove redundant decls.
434 (check_image_size): Don't assume that arbitrary EMACS_INT values
435 fit in 'int', or that arbitrary 'double' values fit in 'int'.
436 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
437 (tiff_load, imagemagick_load_image):
438 Check for overflow in size calculations.
439 (x_create_x_image_and_pixmap): Remove unnecessary test for
440 xmalloc returning NULL; that can't happen.
441 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
442 (xpm_color_bucket): Use better integer hashing function.
443 (xpm_cache_color): Don't possibly over-allocate memory.
444 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
445 (gif_memory_source):
446 Use ptrdiff_t, not int or size_t, to record sizes.
447 (png_load): Don't assume values greater than 2**31 fit in 'int'.
448 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
449 either works, as we prefer signed integers.
450 (tiff_read_from_memory, tiff_write_from_memory):
451 Return tsize_t, not size_t, since that's what the TIFF API wants.
452 (tiff_read_from_memory): Don't fail simply because the read would
453 go past EOF; instead, return a short read.
454 (tiff_load): Omit no-longer-needed casts.
455 (Fimagemagick_types): Don't assume size fits into 'int'.
456
457 Improve hashing quality when configured --with-wide-int.
458 * fns.c (hash_string): New function, taken from sxhash_string.
459 Do not discard information about ASCII character case; this
460 discarding is no longer needed.
461 (sxhash-string): Use it. Change sig to match it. Caller changed.
462 * lisp.h: Declare it.
463 * lread.c (hash_string): Remove, since we now use fns.c's version.
464 The fns.c version returns a wider integer if --with-wide-int is
465 specified, so this should help the quality of the hashing a bit.
466
467 * emacs.c: Integer overflow minor fix.
468 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
469 Define only if GNU_LINUX.
470 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
471
472 * dispnew.c: Integer signedness and overflow fixes.
473 Remove unnecessary forward decls, that were a maintenance hassle.
474 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
475 All uses changed.
476 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
477 (scrolling_window): Use ptrdiff_t, not int, for byte count.
478 (prepare_desired_row, line_draw_cost):
479 Use int, not unsigned, where either works.
480 (save_current_matrix, restore_current_matrix):
481 Use ptrdiff_t, not size_t, where either works.
482 (init_display): Check for overflow more accurately, and without
483 relying on undefined behavior.
484
485 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
486 Remove, replacing with the new symbols in lisp.h. All uses changed.
487 * fileio.c (make_temp_name):
488 * filelock.c (lock_file_1, lock_file):
489 * xdisp.c (message_dolog):
490 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
491 Use pMd etc. instead.
492 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
493 replacing the pWIDE etc. symbols removed from editfns.c.
494
495 * keyboard.h (num_input_events): Now uintmax_t.
496 This is (very slightly) less likely to mess up due to wraparound.
497 All uses changed.
498
499 * buffer.c: Integer signedness fixes.
500 (alloc_buffer_text, enlarge_buffer_text):
501 Use ptrdiff_t rather than size_t when either will do, as we prefer
502 signed integers.
503
504 * alloc.c: Integer signedness and overflow fixes.
505 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
506 (__malloc_size_t): Default to size_t, not to int.
507 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
508 (Fgarbage_collect, mark_object_loop_halt, mark_object):
509 Prefer ptrdiff_t to size_t when either would do, as we prefer
510 signed integers.
511 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
512 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
513 Now const. Initialize with values that are in range even if char
514 is signed.
515 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
516 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
517 These functions do the right thing with sizes > 2**32.
518 (check_depth): Now ptrdiff_t, not int.
519 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
520 Adjust to new way of storing sizes. Check for size overflow bugs
521 in rest of code.
522 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
523 slightly wrong anyway, as it missed one instance of
524 XMALLOC_OVERRUN_CHECK_OVERHEAD.
525 (refill_memory_reserve): Omit needless cast to size_t.
526 (mark_object_loop_halt): Mark as externally visible.
527
528 * xselect.c: Integer signedness and overflow fixes.
529 (Fx_register_dnd_atom, x_handle_dnd_message):
530 Use ptrdiff_t, not size_t, since we prefer signed.
531 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
532 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
533 x_dnd_atoms_size and x_dnd_atoms_length.
534
535 * doprnt.c: Prefer signed to unsigned when either works.
536 * eval.c (verror):
537 * doprnt.c (doprnt):
538 * lisp.h (doprnt):
539 * xdisp.c (vmessage):
540 Use ptrdiff_t, not size_t, when using or implementing doprnt,
541 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
542 prefer signed arithmetic to avoid comparison confusion.
543 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
544 but is a bit tricky.
545
546 Assume freestanding C89 headers, string.h, stdlib.h.
547 * data.c, doprnt.c, floatfns.c, print.c:
548 Include float.h unconditionally.
549 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
550 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
551 * regex.c: Likewise for stddef.h, string.h.
552 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
553 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
554 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
555 (STDC_HEADERS): Remove obsolete defines.
556 * sysdep.c: Include limits.h unconditionally.
557
558 Assume support for memcmp, memcpy, memmove, memset.
559 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
560 * regex.c (memcmp, memcpy):
561 Remove; we assume C89 now.
562
563 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
564 (__malloc_safe_bcopy): Remove; no longer needed.
565
566 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
567 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
568 well either way, and we prefer signed to unsigned.
569
570 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
571
572 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
573 closes the connection while we're reading (bug#9182).
574
575 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
576
577 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
578 are specified (Bug#9168).
579
580 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
581
582 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
583 Found by GCC static checking and --with-wide-int on a 32-bit host.
584
585 2011-07-25 Eli Zaretskii <eliz@gnu.org>
586
587 * xdisp.c (compute_display_string_pos): Fix logic of caching
588 previous display string position. Initialize cached_prev_pos to
589 -1. Fixes slow-down at the beginning of a buffer.
590
591 2011-07-24 Eli Zaretskii <eliz@gnu.org>
592
593 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
594 for attrs[LFACE_FONTSET_INDEX].
595
596 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
597
598 * xml.c (parse_region): Remove unused local
599 that was recently introduced.
600
601 2011-07-23 Eli Zaretskii <eliz@gnu.org>
602
603 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
604 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
605
606 * xdisp.c (move_it_in_display_line_to): Record the best matching
607 position for TO_CHARPOS while scanning the line, and restore it on
608 exit if none of the characters scanned was an exact match.
609 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
610 when exact match is impossible due to invisible text, and the
611 lines are truncated.
612
613 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
614
615 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
616 for OSX >= 10.7.
617
618 2011-07-22 Eli Zaretskii <eliz@gnu.org>
619
620 Fix a significant slow-down of cursor motion with C-n, C-p,
621 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
622 auto-repeat under bidi redisplay in fontified buffers.
623 * xdisp.c (compute_stop_pos_backwards): New function.
624 (next_element_from_buffer): Call compute_stop_pos_backwards to
625 find a suitable prev_stop when we find ourselves before
626 base_level_stop.
627 (reseat): Don't look for prev_stop, as that could mean a very long
628 run.
629 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
630 <cached_disp_overlay_modiff>: Cache for last found display string
631 position.
632 (compute_display_string_pos): Return the cached position if asked
633 about the same buffer in the same area of character positions, and
634 the buffer wasn't changed since the time the display string
635 position was cached.
636
637 2011-07-22 Eli Zaretskii <eliz@gnu.org>
638
639 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
640 is an integer, which is important for empty lines. (Bug#9149)
641
642 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
643
644 * frame.c (Fmodify_frame_parameters): In tty case, update the
645 default face if necessary (Bug#4238).
646
647 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
648
649 * editfns.c (Fstring_to_char): No need to explain what a character
650 is in the docstring (Bug#6576).
651
652 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
653
654 * xml.c (parse_region): Make sure we always return a tree.
655
656 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
657
658 * xml.c (parse_region): If a document contains only comments,
659 return that, too.
660
661 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
662
663 * xml.c (make_dom): Return comments, too.
664
665 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
666
667 Port to OpenBSD.
668 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
669 and the surrounding thread.
670 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
671 rather than fgets, and retry after EINTR. Otherwise, 'emacs
672 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
673 timer goes off.
674 * s/openbsd.h (BROKEN_SIGIO): Define.
675 * unexelf.c (unexec) [__OpenBSD__]:
676 Don't update the .mdebug section of the Alpha COFF symbol table.
677
678 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
679
680 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
681 (bug#8460).
682
683 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
684
685 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
686 This fixes some race conditions on the permissions of any newly
687 created file.
688
689 * alloc.c (valid_pointer_p): Use pipe, not open.
690 This fixes some permissions issues when debugging.
691
692 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
693 If fchown fails to set both uid and gid, try to set just gid,
694 as that is sometimes allowed. Adjust the file's mode to eliminate
695 setuid or setgid bits that are inappropriate if fchown fails.
696
697 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
698
699 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
700 to compare Lisp_Objects.
701 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
702 global_gnutls_log_level, don't mistake it for a Lisp_Object.
703 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
704
705 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
706
707 * lread.c (read_integer): Unread even EOF character.
708 (read1): Likewise. Properly record start position of symbol.
709
710 * lread.c (read1): Read `#:' as empty uninterned symbol if no
711 symbol character follows.
712
713 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
714
715 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
716 This works around a problem with the previous change to Fcopy_file.
717 Recent glibc declares fchown with __attribute__((warn_unused_result)),
718 and without this change, GCC might complain about discarding
719 fchown's return value.
720
721 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
722
723 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
724
725 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
726
727 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
728
729 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
730
731 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
732 it's used from the C level.
733
734 * process.c: Use the same condition for POLL_FOR_INPUT in both
735 keyboard.c and process.c (bug#1858).
736
737 2011-07-09 Lawrence Mitchell <wence@gmx.li>
738
739 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
740 (Fgnutls_boot): Use it.
741
742 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
743
744 * doc.c (Fsubstitute_command_keys): Revert last change.
745
746 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
747
748 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
749 quotes the next character, and doesn't affect other longer
750 sequences (bug#8935).
751
752 * lread.c (syms_of_lread): Clarify that is isn't only
753 `eval-buffer' and `eval-defun' that's affected by
754 `lexical-binding' (bug#8460).
755
756 2011-07-15 Eli Zaretskii <eliz@gnu.org>
757
758 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
759 bidi redisplay when a line includes both an image and is
760 truncated.
761
762 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
763
764 Fix minor problems found by static checking.
765 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
766 (elsz): Now a signed constant, not a size_t var. We prefer signed
767 types to unsigned, to avoid integer comparison confusion. Without
768 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
769 "cannot optimize loop, the loop counter may overflow", a symptom
770 of the confusion.
771 * indent.c (Fvertical_motion): Mark locals as initialized.
772 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
773
774 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
775
776 * search.c (Fre_search_backward): Mention `case-fold-search' in
777 all the re_search_* functions (bug#8138).
778
779 * keyboard.c (Fopen_dribble_file): Document when the file is
780 closed (bug#8056).
781
782 2011-07-14 Eli Zaretskii <eliz@gnu.org>
783
784 * bidi.c (bidi_dump_cached_states): Fix format of displaying
785 bidi_cache_idx.
786
787 Support bidi reordering of display and overlay strings.
788 * xdisp.c (compute_display_string_pos)
789 (compute_display_string_end): Accept additional argument STRING.
790 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
791 (reseat_to_string): Initialize bidi_it->string.s and
792 bidi_it->string.schars.
793 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
794 NULL (avoids a crash in bidi_paragraph_init).
795 Initialize itb.string.lstring.
796 (init_iterator): Call bidi_init_it only of a valid
797 buffer position was specified. Initialize paragraph_embedding to
798 L2R.
799 (reseat_to_string): Initialize the bidi iterator.
800 (display_string): If we need to ignore text properties of
801 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
802 original value of -1 will not work with bidi.)
803 (compute_display_string_pos): First arg is now struct
804 `text_pos *'; all callers changed. Support display properties on
805 Lisp strings.
806 (compute_display_string_end): Support display properties on Lisp
807 strings.
808 (init_iterator, reseat_1, reseat_to_string): Initialize the
809 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
810 when iterating on a string not from display properties).
811 (compute_display_string_pos, compute_display_string_end):
812 Fix calculation of the object to scan. Fixes an error when using
813 arrow keys.
814 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
815 base_level_stop; instead, set base_level_stop to BEGV.
816 Fixes crashes in vertical-motion.
817 (next_element_from_buffer): Improve commentary for when
818 the iterator is before prev_stop.
819 (init_iterator): Initialize bidi_p from the default value of
820 bidi-display-reordering, not from buffer-local value. Use the
821 buffer-local value only if initializing for buffer iteration.
822 (handle_invisible_prop): Support invisible properties on strings
823 that are being bidi-reordered.
824 (set_iterator_to_next): Support bidi reordering of C strings and
825 Lisp strings.
826 (next_element_from_string): Support bidi reordering of Lisp
827 strings.
828 (handle_stop_backwards): Support Lisp strings as well.
829 (display_string): Support display of R2L glyph rows.
830 Use IT_STRING_CHARPOS when displaying from a Lisp string.
831 (init_iterator): Don't initialize it->bidi_p for strings
832 here.
833 (reseat_to_string): Initialize it->bidi_p for strings here.
834 (next_element_from_string, next_element_from_c_string)
835 (next_element_from_buffer): Add xassert's for correspondence
836 between IT's object being iterated and it->bidi_it.string
837 structure.
838 (face_before_or_after_it_pos): Support bidi iteration.
839 (next_element_from_c_string): Handle the case of the first string
840 character that is not the first one in the visual order.
841 (get_visually_first_element): New function, refactored from common
842 parts of next_element_from_buffer, next_element_from_string, and
843 next_element_from_c_string.
844 (tool_bar_lines_needed, redisplay_tool_bar)
845 (display_menu_bar): Force left-to-right direction. Add a FIXME
846 comment for making that be controlled by a user option.
847 (push_it, pop_it): Save and restore the state of the
848 bidi iterator. Save and restore the bidi_p flag.
849 (pop_it): Iterate out of display property for string iteration as
850 well.
851 (iterate_out_of_display_property): Support iteration over strings.
852 (handle_single_display_spec): Set up it->bidi_it for iteration
853 over a display string, and call bidi_init_it.
854 (handle_single_display_spec, next_overlay_string)
855 (get_overlay_strings_1, push_display_prop): Set up the bidi
856 iterator for displaying display or overlay strings.
857 (forward_to_next_line_start): Don't use the shortcut if
858 bidi-iterating.
859 (back_to_previous_visible_line_start): If handle_display_prop
860 pushed the iterator stack, restore the internal state of the bidi
861 iterator by calling bidi_pop_it same number of times.
862 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
863 and we are bidi-iterating, don't decrement the iterator position;
864 instead, set the first_elt flag in the bidi iterator, to produce
865 the same effect.
866 (reseat_1): Remove redundant setting of string_from_display_prop_p.
867 (push_display_prop): xassert that we are iterating a buffer.
868 (push_it, pop_it): Save and restore paragraph_embedding member.
869 (handle_single_display_spec, next_overlay_string)
870 (get_overlay_strings_1, reseat_1, reseat_to_string)
871 (push_display_prop): Set up the `unibyte' member of bidi_it.string
872 correctly. Don't assume unibyte strings are not bidi-reordered.
873 (compute_display_string_pos)
874 (compute_display_string_end): Fix handling the case of C string.
875 (push_it, pop_it): Save and restore from_disp_prop_p.
876 (handle_single_display_spec, push_display_prop): Set the
877 from_disp_prop_p flag.
878 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
879 (pop_it): Call iterate_out_of_display_property only if we are
880 popping after iteration over a string that came from a display
881 property. Fix a typo in popping stretch info. Add an assertion
882 for verifying that the iterator position is in sync with the bidi
883 iterator.
884 (handle_single_display_spec, get_overlay_strings_1)
885 (push_display_prop): Fix initialization of paragraph direction for
886 string when that of the parent object is not yet determined.
887 (reseat_1): Call bidi_init_it to resync the bidi
888 iterator with IT's position. (Bug#7616)
889 (find_row_edges): If ROW->start.pos gives position
890 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
891 (handle_stop, back_to_previous_visible_line_start, reseat_1):
892 Reset the from_disp_prop_p flag.
893 (SAVE_IT, RESTORE_IT): New macros.
894 (pos_visible_p, face_before_or_after_it_pos)
895 (back_to_previous_visible_line_start)
896 (move_it_in_display_line_to, move_it_in_display_line)
897 (move_it_to, move_it_vertically_backward, move_it_by_lines)
898 (try_scrolling, redisplay_window, display_line): Use them when
899 saving a temporary copy of the iterator and restoring it back.
900 (back_to_previous_visible_line_start, reseat_1)
901 (init_iterator): Empty the bidi cache "stack".
902 (move_it_in_display_line_to): If iterator ended up at
903 EOL, but we never saw any buffer positions smaller than
904 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
905 motion in bidi-reordered lines.
906 (move_it_in_display_line_to): Record prev_method and prev_pos
907 immediately before the call to set_iterator_to_next. Fixes cursor
908 motion in bidi-reordered lines with stretch glyphs and strings
909 displayed in margins. (Bug#8133) (Bug#8867)
910 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
911 TO_CHARPOS.
912 (pos_visible_p): Support positions in bidi-reordered lines.
913 Save and restore bidi cache.
914
915 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
916 (bidi_paragraph_info): Delete unused struct.
917 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
918 (bidi_cache_start): New variable.
919 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
920 to zero.
921 (bidi_cache_fetch_state, bidi_cache_search)
922 (bidi_cache_find_level_change, bidi_cache_iterator_state)
923 (bidi_cache_find, bidi_peek_at_next_level)
924 (bidi_level_of_next_char, bidi_find_other_level_edge)
925 (bidi_move_to_visually_next): Compare cache index with
926 bidi_cache_start rather than with zero.
927 (bidi_fetch_char): Accept new argument STRING; all callers
928 changed. Support iteration over a string. Support strings with
929 display properties. Support unibyte strings. Fix the type of
930 `len' according to what STRING_CHAR_AND_LENGTH expects.
931 (bidi_paragraph_init, bidi_resolve_explicit_1)
932 (bidi_resolve_explicit, bidi_resolve_weak)
933 (bidi_level_of_next_char, bidi_move_to_visually_next):
934 Support iteration over a string.
935 (bidi_set_sor_type, bidi_resolve_explicit_1)
936 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
937 can now be zero (for strings); special values 0 and -1 were
938 changed to -1 and -2, respectively.
939 (bidi_char_at_pos): New function.
940 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
941 Call it instead of FETCH_MULTIBYTE_CHAR.
942 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
943 initialized to valid values.
944 (bidi_init_it): Don't initialize charpos and bytepos with invalid
945 values.
946 (bidi_level_of_next_char): Allow the sentinel "position" to pass
947 the test for valid cached positions. Fix the logic for looking up
948 the sentinel state in the cache. GCPRO the Lisp string we are
949 iterating.
950 (bidi_push_it, bidi_pop_it): New functions.
951 (bidi_initialize): Initialize the bidi cache start stack pointer.
952 (bidi_cache_ensure_space): New function, refactored from part of
953 bidi_cache_iterator_state. Don't assume the required size is just
954 one BIDI_CACHE_CHUNK away.
955 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
956 (bidi_count_bytes, bidi_char_at_pos): New functions.
957 (bidi_cache_search): Don't assume bidi_cache_last_idx is
958 always valid if bidi_cache_idx is valid.
959 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
960 is valid if it's going to be used.
961 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
962 (bidi_cache_fetch_state, bidi_cache_search)
963 (bidi_cache_find_level_change, bidi_cache_ensure_space)
964 (bidi_cache_iterator_state, bidi_cache_find)
965 (bidi_find_other_level_edge, bidi_cache_start_stack):
966 All variables related to cache indices are now EMACS_INT.
967
968 * dispextern.h (struct bidi_string_data): New structure.
969 (struct bidi_it): New member `string'. Make flag members be 1-bit
970 fields, and put them last in the struct.
971 (compute_display_string_pos, compute_display_string_end):
972 Update prototypes.
973 (bidi_push_it, bidi_pop_it): Add prototypes.
974 (struct iterator_stack_entry): New members bidi_p,
975 paragraph_embedding, and from_disp_prop_p.
976 (struct it): Member bidi_p is now a bit field 1 bit wide.
977 (bidi_shelve_cache, bidi_unshelve_cache):
978 Declare prototypes.
979
980 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
981 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
982 and vector-like objects.
983
984 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
985 cache around display iteration.
986
987 * window.c (Fwindow_end, window_scroll_pixel_based)
988 (displayed_window_lines, Frecenter): Save and restore the bidi
989 cache around display iteration.
990
991 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
992
993 * editfns.c (Fdelete_region): Clarify the use of the named
994 parameters (bug#6788).
995
996 2011-07-14 Martin Rudalics <rudalics@gmx.at>
997
998 * indent.c (Fvertical_motion): Set and restore w->pointm when
999 saving and restoring the window's buffer (Bug#9006).
1000
1001 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1002
1003 * editfns.c (Fstring_to_char): Clarify just what is returned
1004 (bug#6576). Text by Eli Zaretskii.
1005
1006 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1007
1008 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1009
1010 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1011
1012 * buffer.c (mmap_find): Fix a typo.
1013
1014 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1015
1016 Fix execution of x selection hooks.
1017 * xselect.c (Qx_lost_selection_functions)
1018 (Qx_sent_selection_functions): New vars.
1019 (syms_of_xselect): DEFSYM them.
1020 (x_handle_selection_request): Pass Qx_sent_selection_functions
1021 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1022 (x_handle_selection_clear,x_clear_frame_selections):
1023 Pass Qx_lost_selection_functions rather than
1024 Vx_lost_selection_functions to Frun_hook_with_args.
1025
1026 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1027
1028 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1029 The old code sometimes used this field without initializing it.
1030
1031 * alloc.c (gc_sweep): Don't read past end of array.
1032 In theory, the old code could also have corrupted Emacs internals,
1033 though it'd be very unlikely.
1034
1035 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1036
1037 * character.c (Fcharacterp): Don't advertise optional ignored
1038 argument. (Bug#4026)
1039
1040 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1041
1042 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1043 key" (bug#4257).
1044
1045 * window.c (Fset_window_start): Doc fix (bug#4199).
1046 (Fset_window_hscroll): Ditto.
1047
1048 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1049
1050 Fix minor new problems caught by GCC 4.6.1.
1051 * term.c (init_tty): Remove unused local.
1052 * xsettings.c (store_monospaced_changed): Define this function only
1053 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1054 not used otherwise.
1055
1056 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1057
1058 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1059
1060 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1061
1062 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1063 are the mini-buffer and the echo area (bug#3320).
1064
1065 * term.c (init_tty): Remove support for supdup, c10 and perq
1066 terminals, which are no longer supported (bug#1482).
1067
1068 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1069
1070 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1071
1072 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1073
1074 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1075 for non-popups (Bug#3642).
1076
1077 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1078
1079 * alloc.c (reset_malloc_hooks): Protoize.
1080 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1081 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1082 * cm.c (losecursor): Likewise.
1083 * data.c (fmod): Likewise.
1084 * dispnew.c (swap_glyphs_in_rows): Likewise.
1085 * emacs.c (memory_warning_signal): Likewise.
1086 * floatfns.c (float_error): Likewise.
1087 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1088 (otf_open, font_otf_capability, generate_otf_features)
1089 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1090 Likewise.
1091 * image.c (pbm_read_file): Likewise.
1092 * indent.c (string_display_width): Likewise.
1093 * intervals.c (check_for_interval, search_for_interval)
1094 (inc_interval_count, count_intervals, root_interval)
1095 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1096 * lread.c (defalias): Likewise.
1097 * ralloc.c (r_alloc_check): Likewise.
1098 * regex.c (set_image_of_range_1, set_image_of_range)
1099 (regex_grow_registers): Likewise.
1100 * sysdep.c (strerror): Likewise.
1101 * termcap.c (valid_filename_p, tprint, main): Likewise.
1102 * tparam.c (main): Likewise.
1103 * unexhp9k800.c (run_time_remap, save_data_space)
1104 (update_file_ptrs, read_header, write_header, calculate_checksum)
1105 (copy_file, copy_rest, display_header): Likewise.
1106 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1107 Likewise.
1108 * xdisp.c (check_it): Likewise.
1109 * xfaces.c (register_color, unregister_color, unregister_colors):
1110 Likewise.
1111 * xfns.c (print_fontset_result): Likewise.
1112 * xrdb.c (member, fatal, main): Likewise.
1113
1114 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1115
1116 Fix minor problems found by static checking (Bug#9031).
1117 * chartab.c (char_table_set_range, map_sub_char_table):
1118 Remove unused locals.
1119 (uniprop_table): Now static.
1120 * composite.c (_work_char): Remove unused static var.
1121
1122 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1123
1124 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1125
1126 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1127
1128 * gtkutil.c (qttip_cb): Remove code without function.
1129
1130 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1131
1132 * w32.c (pthread_sigmask): New stub.
1133
1134 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1135
1136 Use pthread_sigmask, not sigprocmask (Bug#9010).
1137 sigprocmask is portable only for single-threaded applications, and
1138 Emacs can be multi-threaded when it uses GTK.
1139 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1140 (LIBES): Use it.
1141 * callproc.c (Fcall_process):
1142 * process.c (create_process):
1143 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1144 Use pthread_sigmask, not sigprocmask.
1145
1146 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1147
1148 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1149 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1150 wrong (Bug#8591).
1151
1152 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1153
1154 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1155 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1156 (xg_hide_tooltip): Fix comment.
1157
1158 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1159 in registerServicesMenuSendTypes.
1160 (validRequestorForSendType): Don't check ns_return_types.
1161
1162 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1163 ns_return_type.
1164
1165 2011-07-08 Jason Rumney <jasonr@gnu.org>
1166
1167 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1168 frame struct members of non-existent frames (Bug#6284).
1169
1170 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1171
1172 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1173 variable firstTime not needed on OSX >= 10.6.
1174 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1175 >= 10.5. Use setKnobProportion, setDoubleValue.
1176
1177 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1178 (MAC_OS_X_VERSION_10_5): Define if not defined.
1179 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1180 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1181 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1182
1183 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1184 cString and lossyCString on OSX >= 10.4
1185
1186 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1187 sizeToFit on OSX >= 10.2.
1188
1189 * nsimage.m (allocInitFromFile): Don't use deprecated method
1190 bestRepresentationForDevice on OSX >= 10.6.
1191
1192 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1193 to avoid warning.
1194
1195 * emacs.c: Declare unexec_init_emacs_zone.
1196
1197 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1198
1199 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1200
1201 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1202 on svcsMenu (Bug#8842).
1203
1204 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1205 ns_return_types.
1206 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1207
1208 * nsterm.m (QUTF8_STRING): Declare.
1209 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1210 (validRequestorForSendType): Return type is (id).
1211 Change indexOfObjectIdenticalTo to indexOfObject.
1212 Check if we have local selection before returning self (Bug#8842).
1213 (writeSelectionToPasteboard): Put local selection into paste board
1214 if we have a local selection (Bug#8842).
1215 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1216
1217 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1218 (ns_get_local_selection): Declare.
1219
1220 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1221
1222 * keymap.c (describe_map_tree): Don't insert a double newline at
1223 the end of the buffer (bug#1169) and return whether we inserted
1224 something.
1225
1226 * callint.c (Fcall_interactively): Change "reading args" to
1227 "providing args" to try to clarify what it does (bug#1010).
1228
1229 2011-07-07 Kenichi Handa <handa@m17n.org>
1230
1231 * composite.c (composition_compute_stop_pos): Ignore a static
1232 composition starting before CHARPOS (Bug#8915).
1233
1234 * xdisp.c (handle_composition_prop): Likewise.
1235
1236 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1237
1238 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1239 (Bug#9015)
1240
1241 2011-07-07 Kenichi Handa <handa@m17n.org>
1242
1243 * character.h (unicode_category_t): New enum type.
1244
1245 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1246 (Qchar_code_property_table): New variable.
1247 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1248 (UNIPROP_COMPRESSED_FORM_P): New macros.
1249 (char_table_ascii): Uncompress the compressed values.
1250 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1251 Uncompress the compressed values.
1252 (sub_char_table_ref_and_range): Likewise.
1253 (char_table_ref_and_range): Uncompress the compressed values.
1254 (sub_char_table_set): New arg is_uniprop. Callers changed.
1255 Uncompress the compressed values.
1256 (sub_char_table_set_range): Args changed. Callers changed.
1257 (char_table_set_range): Adjuted for the above change.
1258 (map_sub_char_table): Delete args default_val and parent. Add arg
1259 top. Give decoded values to a Lisp function.
1260 (map_char_table): Adjust for the above change. Give decoded
1261 values to a Lisp function. Gcpro more variables.
1262 (uniprop_table_uncompress)
1263 (uniprop_decode_value_run_length): New functions.
1264 (uniprop_decoder, uniprop_decoder_count): New variables.
1265 (uniprop_get_decoder, uniprop_encode_value_character)
1266 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1267 New functions.
1268 (uniprop_encoder, uniprop_encoder_count): New variables.
1269 (uniprop_get_encoder, uniprop_table)
1270 (Funicode_property_table_internal, Fget_unicode_property_internal)
1271 (Fput_unicode_property_internal): New functions.
1272 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1273 Sunicode_property_table_internal, Sget_unicode_property_internal,
1274 and Sput_unicode_property_internal. Defvar_lisp
1275 char-code-property-alist.
1276
1277 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1278 Vunicode_category_table.
1279
1280 * font.c (font_range): Adjust for the change of
1281 Vunicode_category_table.
1282
1283 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1284
1285 * m/iris4d.h: Remove file, move contents ...
1286 * s/irix6-5.h: ... here.
1287
1288 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1289
1290 Remove unportable assumption about struct layout (Bug#8884).
1291 * alloc.c (mark_buffer):
1292 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1293 (clone_per_buffer_values): Don't assume that
1294 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1295 This isn't true in general, and it's particularly not true
1296 if Emacs is configured with --with-wide-int.
1297 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1298 New macros, used in the buffer.c change.
1299
1300 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1301
1302 * xsettings.c: Use both GConf and GSettings if both are available.
1303 (store_config_changed_event): Add comment.
1304 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1305 (store_tool_bar_style_changed): New functions.
1306 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1307 (struct xsettings): Move font inside HAVE_XFT.
1308 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1309 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
1310 Move inside HAVE_XFT.
1311 (something_changed_gsettingsCB): Rename from something_changedCB.
1312 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1313 also.
1314 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1315 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1316 (something_changed_gconfCB): Rename from something_changedCB.
1317 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1318 (parse_settings): Move check for font inside HAVE_XFT.
1319 (read_settings, apply_xft_settings): Add comment.
1320 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1321 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1322 call store_font_name_changed.
1323 (xft_settings_event): Add comment.
1324 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1325 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1326 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1327 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1328 (xsettings_initialize): Call init_gsettings last.
1329 (xsettings_get_system_font, xsettings_get_system_normal_font):
1330 Add comment.
1331
1332 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1333
1334 Random fixes. E.g., (random) never returned negative values.
1335 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1336 subseconds part to the entropy, as that's a bit more random.
1337 Prefer signed to unsigned, since the signedness doesn't matter and
1338 in general we prefer signed. When given a limit, use a
1339 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1340 latter isn't right if USE_2_TAGS_FOR_INTS.
1341 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1342 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1343
1344 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1345
1346 * textprop.c (text_property_stickiness):
1347 Obey Vtext_property_default_nonsticky.
1348 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1349 * w32fns.c (syms_of_w32fns):
1350 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1351
1352 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1353
1354 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1355 This is more efficient than Ffile_directory_p and avoids a minor race.
1356
1357 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1358
1359 * buffer.c (Foverlay_put): Say what the return value is
1360 (bug#7835).
1361
1362 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1363 is a directory before asking whether to use the file name
1364 (bug#7564).
1365 (barf_or_query_if_file_exists): Make the "File is a directory"
1366 error be more correct.
1367
1368 * fns.c (Frequire): Remove the mention of the .gz files, since
1369 that's installation-specific, but keep the mention of
1370 `get-load-suffixes'.
1371
1372 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1373
1374 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1375 Report string overflow if the output is too long.
1376
1377 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1378
1379 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1380 (syms_of_gnutls): Remove duplicate DEFSYM for
1381 Qgnutls_bootprop_verify_hostname_error, an error for
1382 Qgnutls_bootprop_verify_error (which is no longer used).
1383
1384 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1385 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1386 Also (re)move comments that are misplaced or no longer relevant.
1387
1388 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1389
1390 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1391
1392 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1393
1394 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1395 and background color parameters if they have been changed.
1396
1397 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1398
1399 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1400
1401 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1402
1403 * xsettings.c (SYSTEM_FONT): Define only when used.
1404 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1405
1406 * keymap.c (access_keymap_1): Now static.
1407
1408 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1409
1410 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1411 leave any prefix arg for the up event (Bug#1586).
1412
1413 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1414
1415 * lread.c (syms_of_lread): Mention single symbols defined by
1416 `defvar' or `defconst' (bug#7154).
1417
1418 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1419 (Frequire): Mention get-load-suffixes.
1420
1421 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1422
1423 * window.h (window): Remove clone_number slot.
1424 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1425 Remove.
1426 (make_parent_window, make_window, saved_window)
1427 (Fset_window_configuration, save_window_save): Don't deal with
1428 clone numbers.
1429 * buffer.c (Qclone_number): Remove declaration.
1430 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1431
1432 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1433
1434 Add multiple inheritance to keymaps.
1435 * keymap.c (Fmake_composed_keymap): New function.
1436 (Fset_keymap_parent): Simplify.
1437 (fix_submap_inheritance): Remove.
1438 (access_keymap_1): New function extracted from access_keymap to handle
1439 embedded parents and handle lists of maps.
1440 (access_keymap): Use it.
1441 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1442 (Fcopy_keymap): Handle embedded parents.
1443 (Fcommand_remapping, define_as_prefix): Simplify.
1444 (Fkey_binding): Simplify.
1445 (syms_of_keymap): Move minibuffer-local-completion-map,
1446 minibuffer-local-filename-completion-map,
1447 minibuffer-local-must-match-map, and
1448 minibuffer-local-filename-must-match-map to Elisp.
1449 (syms_of_keymap): Defsubr make-composed-keymap.
1450 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1451 (parse_menu_item): Trivial simplification.
1452
1453 2011-07-01 Glenn Morris <rgm@gnu.org>
1454
1455 * Makefile.in (SETTINGS_LIBS): Fix typo.
1456
1457 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1458
1459 * coding.c (Fencode_coding_string): Record the last coding system
1460 used, as the function doc string says (bug#8738).
1461
1462 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1463
1464 * xsettings.c (store_monospaced_changed): Take new font as arg and
1465 check for change against current_mono_font.
1466 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1467 (emacs_settings_constructor, emacs_settings_get_property)
1468 (emacs_settings_set_property, emacs_settings_class_init)
1469 (emacs_settings_init, gsettings_obj): Remove.
1470 (something_changedCB): New function for HAVE_GSETTINGS.
1471 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1472 with value as argument.
1473 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1474 g_settings_new (Bug#8967). Do not create gsettings_obj.
1475 Remove calls to g_settings_bind. Connect something_changedCB to
1476 "changed".
1477
1478 * xgselect.c: Add defined (HAVE_GSETTINGS).
1479 (xgselect_initialize): Ditto.
1480
1481 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1482 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1483 xg_select.
1484
1485 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1486
1487 * eval.c (struct backtrace): Simplify and port the data structure.
1488 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1489 signed bit field, as this assumption is not portable and it makes
1490 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1491 "char debug_on_exit : 1" as this is not portable either; instead,
1492 use the portable "unsigned int debug_on_exit : 1". Remove unused
1493 member evalargs. Remove obsolete comments about cc bombing out.
1494
1495 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1496
1497 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1498 Let HAVE_GSETTINGS override HAVE_GCONF.
1499 (store_monospaced_changed): New function.
1500 (EMACS_SETTINGS): A new type derived from GObject to handle
1501 GSettings notifications.
1502 (emacs_settings_constructor, emacs_settings_get_property)
1503 (emacs_settings_set_property, emacs_settings_class_init):
1504 New functions.
1505 (gsettings_client, gsettings_obj): New variables.
1506 (GSETTINGS_SCHEMA): New define.
1507 (something_changedCB): Call store_monospaced_changed.
1508 (init_gsettings): New function.
1509 (xsettings_initialize): Call init_gsettings.
1510 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1511 to NULL.
1512
1513 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
1514 GCONF_CFLAGS/LIBS.
1515
1516 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1517
1518 * window.c (resize_root_window, grow_mini_window)
1519 (shrink_mini_window): Rename Qresize_root_window to
1520 Qwindow_resize_root_window and Qresize_root_window_vertically to
1521 Qwindow_resize_root_window_vertically.
1522
1523 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1524
1525 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1526
1527 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1528
1529 * makefile.w32-in: Redesign dependencies so they reflect more
1530 clearly which files are directly included by each source file,
1531 and not through other includes.
1532
1533 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1534
1535 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1536 (sort_overlays, overlay_strings): When an overlay's clone number
1537 matches the window's clone number process the overlay even if
1538 the overlay's window property doesn't match the current window.
1539
1540 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1541 (Fwindow_hchild): Rename to Fwindow_left_child.
1542 (Fwindow_next): Rename to Fwindow_next_sibling.
1543 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1544 (resize_window_check): Rename to window_resize_check.
1545 (resize_window_apply): Rename to window_resize_apply.
1546 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1547 (Fdelete_other_windows_internal, resize_frame_windows)
1548 (Fsplit_window_internal, Fdelete_window_internal)
1549 (grow_mini_window, shrink_mini_window)
1550 (Fresize_mini_window_internal): Fix callers accordingly.
1551
1552 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1553
1554 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1555 (emacs_fixed_set_min_size): Remove.
1556 (emacs_fixed_new): Take frame as argument.
1557
1558 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1559 (_EmacsFixedPrivate): Remove minwidth/height.
1560 Add struct frame *f.
1561 (emacs_fixed_init): Initialize priv->f.
1562 (get_parent_class, emacs_fixed_set_min_size): Remove.
1563 (emacs_fixed_new): Set priv->f to argument.
1564 (emacs_fixed_get_preferred_width)
1565 (emacs_fixed_get_preferred_height): Use min_width/height from
1566 frames size_hint to set minimum and natural (Bug#8919).
1567 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1568 and use min_width/height from frames size_hint to set
1569 min_width/height (Bug#8919).
1570
1571 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1572 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1573 Fix indentation.
1574
1575 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1576
1577 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1578 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1579 called at ZV.
1580
1581 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1582
1583 * process.c (wait_reading_process_output): Bypass select if
1584 waiting for a cell while ignoring keyboard input, and input is
1585 pending. Suggested by Jan Djärv (Bug#8869).
1586
1587 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1588
1589 Use gnulib's dup2 module instead of rolling our own.
1590 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1591
1592 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1593
1594 * dispnew.c (scrolling_window): Before scrolling, turn off a
1595 mouse-highlight in the window being scrolled.
1596
1597 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1598
1599 Move DEFSYM to lisp.h and use everywhere.
1600
1601 * character.h (DEFSYM): Move declaration...
1602 * lisp.h (DEFSYM): ...here.
1603
1604 * gnutls.c:
1605 * minibuf.c:
1606 * w32menu.c:
1607 * w32proc.c:
1608 * w32select.c: Don't include character.h.
1609
1610 * alloc.c (syms_of_alloc):
1611 * buffer.c (syms_of_buffer):
1612 * bytecode.c (syms_of_bytecode):
1613 * callint.c (syms_of_callint):
1614 * casefiddle.c (syms_of_casefiddle):
1615 * casetab.c (init_casetab_once):
1616 * category.c (init_category_once, syms_of_category):
1617 * ccl.c (syms_of_ccl):
1618 * cmds.c (syms_of_cmds):
1619 * composite.c (syms_of_composite):
1620 * dbusbind.c (syms_of_dbusbind):
1621 * dired.c (syms_of_dired):
1622 * dispnew.c (syms_of_display):
1623 * doc.c (syms_of_doc):
1624 * editfns.c (syms_of_editfns):
1625 * emacs.c (syms_of_emacs):
1626 * eval.c (syms_of_eval):
1627 * fileio.c (syms_of_fileio):
1628 * fns.c (syms_of_fns):
1629 * frame.c (syms_of_frame):
1630 * fringe.c (syms_of_fringe):
1631 * insdel.c (syms_of_insdel):
1632 * keymap.c (syms_of_keymap):
1633 * lread.c (init_obarray, syms_of_lread):
1634 * macros.c (syms_of_macros):
1635 * msdos.c (syms_of_msdos):
1636 * print.c (syms_of_print):
1637 * process.c (syms_of_process):
1638 * search.c (syms_of_search):
1639 * sound.c (syms_of_sound):
1640 * syntax.c (init_syntax_once, syms_of_syntax):
1641 * terminal.c (syms_of_terminal):
1642 * textprop.c (syms_of_textprop):
1643 * undo.c (syms_of_undo):
1644 * w32.c (globals_of_w32):
1645 * window.c (syms_of_window):
1646 * xdisp.c (syms_of_xdisp):
1647 * xfaces.c (syms_of_xfaces):
1648 * xfns.c (syms_of_xfns):
1649 * xmenu.c (syms_of_xmenu):
1650 * xsettings.c (syms_of_xsettings):
1651 * xterm.c (syms_of_xterm): Use DEFSYM.
1652
1653 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1654
1655 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1656
1657 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1658
1659 Integer and buffer overflow fixes (Bug#8873).
1660
1661 * print.c (printchar, strout): Check for string overflow.
1662 (PRINTPREPARE, printchar, strout):
1663 Don't set size unless allocation succeeds.
1664
1665 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1666 for sizes. Check for string overflow more accurately.
1667 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1668
1669 * macros.c: Integer and buffer overflow fixes.
1670 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1671 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1672 Use ptrdiff_t, not int, for sizes.
1673 Don't increment bufsize until after realloc succeeds.
1674 Check for size-calculation overflow.
1675 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1676
1677 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1678
1679 * lread.c: Integer overflow fixes.
1680 (read_integer): Radix is now EMACS_INT, not int,
1681 to improve quality of diagnostics for out-of-range radices.
1682 Calculate buffer size correctly for out-of-range radices.
1683 (read1): Check for integer overflow in radices, and in
1684 read-circle numbers.
1685 (read_escape): Avoid int overflow.
1686 (Fload, openp, read_buffer_size, read1)
1687 (substitute_object_recurse, read_vector, read_list, map_obarray):
1688 Use ptrdiff_t, not int, for sizes.
1689 (read1): Use EMACS_INT, not int, for sizes.
1690 Check for size overflow.
1691
1692 * image.c (cache_image): Check for size arithmetic overflow.
1693
1694 * lread.c: Integer overflow issues.
1695 (saved_doc_string_size, saved_doc_string_length)
1696 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1697 Now ptrdiff_t, not int.
1698 (read1): Don't assume doc string length fits in int. Check for
1699 out-of-range doc string lengths.
1700 (read_list): Don't assume file position fits in int.
1701 (read_escape): Check for hex character overflow.
1702
1703 2011-06-22 Leo Liu <sdl.web@gmail.com>
1704
1705 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1706 Move to minibuffer.el.
1707
1708 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1709
1710 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1711 The following patches are for when GLYPH_DEBUG && !XASSERT.
1712 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1713 * dispnew.c (flush_stdout):
1714 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1715 Mark as externally visible.
1716 * dispnew.c (check_window_matrix_pointers): Now static.
1717 * dispnew.c (window_to_frame_vpos):
1718 * xfns.c (unwind_create_frame):
1719 * xterm.c (x_check_font): Remove unused local.
1720 * scroll.c (CHECK_BOUNDS):
1721 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1722 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1723 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1724 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1725 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1726 Now static.
1727 (debug_method_add): Use va_list and vsprintf rather than relying
1728 on undefined behavior with wrong number of arguments.
1729 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1730 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1731 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1732 since we're not interested in debugging glyphs with old libraries.
1733 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1734 GCC 4.6.0's static checking.
1735
1736 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1737
1738 Integer overflow and signedness fixes (Bug#8873).
1739 A few related buffer overrun fixes, too.
1740
1741 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1742
1743 * dispextern.h (struct face.stipple):
1744 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1745 (x_bitmap_mask, x_allocate_bitmap_record)
1746 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1747 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1748 (x_create_bitmap_from_xpm_data):
1749 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1750 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1751 (.bitmaps_last):
1752 * xfaces.c (load_pixmap):
1753 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1754 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1755 (.bitmaps_last, struct x_output.icon_bitmap):
1756 Use ptrdiff_t, not int, for bitmap indexes.
1757 (x_allocate_bitmap_record): Check for size overflow.
1758 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1759
1760 Use ptrdiff_t, not int, for overlay counts.
1761 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1762 * editfns.c (overlays_around, get_pos_property):
1763 * textprop.c (get_char_property_and_overlay):
1764 * xdisp.c (next_overlay_change, note_mouse_highlight):
1765 * xfaces.c (face_at_buffer_position):
1766 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1767 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1768 (Fnext_overlay_change, Fprevious_overlay_change)
1769 (mouse_face_overlay_overlaps, Foverlays_in):
1770 Use ptrdiff_t, not int, for sizes.
1771 (overlays_at, overlays_in): Check for size-calculation overflow.
1772
1773 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1774
1775 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1776 (x_session_initialize): Do not assume string length fits in int.
1777
1778 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1779 This is unlikely, but can occur if DPI is outlandish.
1780
1781 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1782 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1783
1784 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1785 * xrdb.c (magic_file_p, search_magic_path):
1786 Omit last arg SUFFIX; it was always 0. All callers changed.
1787 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1788
1789 * xfont.c (xfont_match): Avoid need for strlen.
1790
1791 * xfns.c: Don't assume strlen fits in int.
1792 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1793
1794 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1795 not unsigned long, as we prefer signed integers. All callers changed.
1796 Detect integer overflow in repeat count.
1797 (message_dolog): Don't assume print length fits in 39 bytes.
1798 (display_mode_element): Don't assume strlen fits in int.
1799
1800 * termcap.c: Don't assume sizes fit in int and never overflow.
1801 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1802 (gobble_line): Check for size-calculation overflow.
1803
1804 * minibuf.c (Fread_buffer):
1805 * lread.c (intern, intern_c_string):
1806 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1807 Don't assume string length fits in int.
1808
1809 * keyboard.c (parse_tool_bar_item):
1810 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1811
1812 * font.c: Don't assume string length fits in int.
1813 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1814 Use ptrdiff_t, not int.
1815 (font_intern_prop): Don't assume string length fits in int.
1816 Don't assume integer property fits in fixnum.
1817 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1818
1819 * filelock.c: Fix some buffer overrun and integer overflow issues.
1820 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1821 Reformulate so as not to need the command string.
1822 Invoke gzip -cd rather than gunzip, as it's more portable.
1823 (lock_info_type, lock_file_1, lock_file):
1824 Don't assume pid_t and time_t fit in unsigned long.
1825 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1826 (current_lock_owner): Prefer signed type for sizes.
1827 Use memcpy, not strncpy, where memcpy is what is really wanted.
1828 Don't assume (via atoi) that time_t and pid_t fit in int.
1829 Check for time_t and/or pid_t out of range, e.g., via a network share.
1830 Don't alloca where an auto var works fine.
1831
1832 * fileio.c: Fix some integer overflow issues.
1833 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1834 Don't assume string length fits in int.
1835 (directory_file_name): Don't assume string length fits in long.
1836 (make_temp_name): Don't assume pid fits in int, or that its print
1837 length is less than 20.
1838
1839 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1840
1841 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1842
1843 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1844
1845 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1846 We prefer signed integers, even for size calculations.
1847
1848 * emacs.c: Don't assume string length fits in 'int'.
1849 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1850 (main): Don't invoke strlen when not needed.
1851
1852 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1853 (XD_DEBUG_MESSAGE): Don't waste a byte.
1854
1855 * callproc.c (getenv_internal_1, getenv_internal)
1856 (Fgetenv_internal):
1857 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1858
1859 * lread.c (invalid_syntax): Omit length argument.
1860 All uses changed. This doesn't fix a bug, but it simplifies the
1861 code away from its former Hollerith-constant appearance, and it's
1862 one less 'int' to worry about when looking at integer-overflow issues.
1863 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1864
1865 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1866 This didn't break anything, but it didn't help either.
1867 It's confusing to put a bogus integer in a place where the actual
1868 value does not matter.
1869 (LIST_END_P): Remove unused macro and its bogus comment.
1870 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1871
1872 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1873 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1874 implementation.
1875 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1876 We prefer signed types, and the value cannot exceed the EMACS_INT
1877 range anyway (because otherwise the length would not be representable).
1878 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1879 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1880 This avoids a GCC warning when WIDE_EMACS_INT.
1881
1882 * indent.c (sane_tab_width): New function.
1883 (current_column, scan_for_column, Findent_to, position_indentation)
1884 (compute_motion): Use it. This is just for clarity.
1885 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1886
1887 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1888
1889 * lisp.h (lint_assume): New macro.
1890 * composite.c (composition_gstring_put_cache):
1891 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1892
1893 * editfns.c, insdel.c:
1894 Omit unnecessary forward decls, to simplify future changes.
1895
1896 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1897
1898 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1899
1900 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1901 Use much-faster test for byte-length change.
1902 Don't assume string byte-length fits in 'int'.
1903 Check that character arg fits in 'int'.
1904 (mapcar1): Declare byte as byte, for clarity.
1905
1906 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1907
1908 * fns.c (concat): Catch string overflow earlier.
1909 Do not rely on integer wraparound.
1910
1911 * dispextern.h (struct it.overlay_strings_charpos)
1912 (struct it.selective): Now EMACS_INT, not int.
1913 * xdisp.c (forward_to_next_line_start)
1914 (back_to_previous_visible_line_start)
1915 (reseat_at_next_visible_line_start, next_element_from_buffer):
1916 Don't arbitrarily truncate the value of 'selective' to int.
1917
1918 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1919
1920 * composite.c: Don't truncate sizes to 'int'.
1921 (composition_gstring_p, composition_reseat_it)
1922 (composition_adjust_point): Use EMACS_INT, not int.
1923 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1924 not EMACS_UINT, for indexes.
1925
1926 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1927
1928 * buffer.c: Include <verify.h>.
1929 (struct sortvec.priority, struct sortstr.priority):
1930 Now EMACS_INT, not int.
1931 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1932 (struct sortstr.size, record_overlay_string)
1933 (struct sortstrlist.size, struct sortlist.used):
1934 Don't truncate size to int.
1935 (record_overlay_string): Check for size-calculation overflow.
1936 (init_buffer_once): Check at compile-time, not run-time.
1937
1938 2011-06-22 Jim Meyering <meyering@redhat.com>
1939
1940 Don't leak an XBM-image-sized buffer
1941 * image.c (xbm_load): Free the image buffer after using it.
1942
1943 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1944
1945 Port to Sun C.
1946 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1947 that Sun C diagnosed.
1948 * fns.c (secure_hash): Fix pointer signedness issue.
1949 * intervals.c (static_offset_intervals): New function.
1950 (offset_intervals): Use it.
1951
1952 2011-06-21 Leo Liu <sdl.web@gmail.com>
1953
1954 * deps.mk (fns.o):
1955 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1956 sha512.h.
1957
1958 * fns.c (secure_hash): Rename from crypto_hash_function and change
1959 the first arg to accept symbols.
1960 (Fsecure_hash): New primitive.
1961 (syms_of_fns): New symbols.
1962
1963 2011-06-20 Deniz Dogan <deniz@dogan.se>
1964
1965 * process.c (Fset_process_buffer): Clarify return value in
1966 docstring.
1967
1968 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1969
1970 * dispnew.c (add_window_display_history): Use BVAR.
1971
1972 * xdisp.c (debug_method_add): Use BVAR.
1973 (check_window_end, dump_glyph_matrix, dump_glyph)
1974 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1975
1976 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1977 Likewise.
1978
1979 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1980 check till after the cache is created in init_frame_faces.
1981
1982 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1983
1984 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1985
1986 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1987
1988 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1989 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1990 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1991
1992 Improve buffer-overflow checking (Bug#8873).
1993 * fileio.c (Finsert_file_contents):
1994 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1995 Remove the old (too-loose) buffer overflow checks.
1996 They weren't needed, since make_gap checks for buffer overflow.
1997 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1998 The old code merely checked for Emacs fixnum overflow, and relied
1999 on undefined (wraparound) behavior. The new code avoids undefined
2000 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2001
2002 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2003 Tune. Don't use wider integers than needed. Don't use alloca.
2004 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2005
2006 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2007
2008 * insdel.c, lisp.h (buffer_overflow): New function.
2009 (insert_from_buffer_1, replace_range, replace_range_2):
2010 * insdel.c (make_gap_larger):
2011 * editfns.c (Finsert_char):
2012 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2013
2014 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2015
2016 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2017
2018 Integer overflow and signedness fixes (Bug#8873).
2019
2020 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2021 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2022
2023 * fileio.c: Don't assume EMACS_INT fits in off_t.
2024 (emacs_lseek): New static function.
2025 (Finsert_file_contents, Fwrite_region): Use it.
2026 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2027
2028 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2029
2030 * fns.c: Don't overflow int when computing a list length.
2031 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2032 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2033 truncation on 64-bit hosts. Check for QUIT every
2034 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2035 faster and is responsive enough.
2036 (Flength): Report an error instead of overflowing an integer.
2037 (Fsafe_length): Return a float if the value is not representable
2038 as a fixnum. This shouldn't happen except in contrived situations.
2039 (Fnthcdr, Fsort): Don't assume list length fits in int.
2040 (Fcopy_sequence): Don't assume vector length fits in int.
2041
2042 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2043 (header_size, word_size): New constants.
2044 (allocate_vectorlike): Don't check size overflow here.
2045 (allocate_vector): Check it here instead, since this is the only
2046 caller of allocate_vectorlike that could cause overflow.
2047 Check that the new vector's length is representable as a fixnum.
2048
2049 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2050 The previous code was bogus. For example, next_almost_prime (32)
2051 returned 39, which is undesirable as it is a multiple of 3; and
2052 next_almost_prime (24) returned 25, which is a multiple of 5 so
2053 why was the code bothering to check for multiples of 7?
2054
2055 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2056
2057 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2058
2059 Variadic C functions now count arguments with ptrdiff_t.
2060 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2061 Back then I didn't know that the Emacs coding style prefers signed int.
2062 Also, in the meantime I found a few more instances where arguments
2063 were being counted with int, which may truncate counts on 64-bit
2064 machines, or EMACS_INT, which may be unnecessarily wide.
2065 * lisp.h (struct Lisp_Subr.function.aMANY)
2066 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2067 Arg counts are now ptrdiff_t, not size_t.
2068 All variadic functions and their callers changed accordingly.
2069 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2070 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2071 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2072 * callint.c (Fcall_interactively): Check arg count for overflow,
2073 to avoid potential buffer overrun. Use signed char, not 'int',
2074 for 'varies' array, so that we needn't bother to check its size
2075 calculation for overflow.
2076 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2077 * eval.c (apply_lambda):
2078 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2079 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2080 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2081
2082 * callint.c (Fcall_interactively): Don't use index var as event count.
2083
2084 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2085 * mem-limits.h (SIZE): Remove; no longer used.
2086
2087 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2088
2089 Remove unnecessary casts.
2090 * xterm.c (x_term_init):
2091 * xfns.c (x_set_border_pixel):
2092 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2093 These aren't needed now that we assume ANSI C.
2094
2095 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2096 It's more likely to cause problems (due to unsigned overflow)
2097 than to cure them.
2098
2099 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2100
2101 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2102
2103 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2104
2105 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2106
2107 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2108
2109 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2110
2111 GLYPH_CODE_FACE returns EMACS_INT, not int.
2112 * dispextern.h (merge_faces):
2113 * xfaces.c (merge_faces):
2114 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2115 Don't assume EMACS_INT fits in int.
2116
2117 * character.h (CHAR_VALID_P): Remove unused parameter.
2118 * fontset.c, lisp.h, xdisp.c: All uses changed.
2119
2120 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2121
2122 * fns.c (concat): Minor tuning based on overflow analysis.
2123 This doesn't fix any bugs. Use int to hold character, instead
2124 of constantly refetching from Emacs object. Use XFASTINT, not
2125 XINT, for value known to be a character. Don't bother comparing
2126 a single byte to 0400, as it's always less.
2127
2128 * floatfns.c (Fexpt):
2129 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2130
2131 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2132 for characters.
2133
2134 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2135
2136 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2137 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2138 incorrectly succeed when S was a string, because 4294967386 was
2139 truncated before it was used.
2140
2141 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2142 Otherwise, an out-of-range integer could cause undefined behavior
2143 on a 64-bit host.
2144
2145 * composite.c: Use int, not EMACS_INT, for characters.
2146 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2147 EMACS_INT, for values that are known to be in character range.
2148 This doesn't fix any bugs but is the usual style inside Emacs and
2149 may generate better code on 32-bit machines.
2150
2151 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2152 This is for reasons similar to the recent CHAR_STRING fix.
2153 * charset.c (Fencode_char): Check that character arg is actually
2154 a character. Pass an int to ENCODE_CHAR.
2155 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2156 wider than 'int', as a compile-time check to prevent future regressions
2157 in this area.
2158
2159 * character.c (char_string): Remove unnecessary casts.
2160
2161 Make sure a 64-bit char is never passed to CHAR_STRING.
2162 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2163 by silently ignoring the top 32 bits, allowing some values
2164 that were far too large to be valid characters.
2165 * character.h: Include <verify.h>.
2166 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2167 arguments are no wider than unsigned, as a compile-time check
2168 to prevent future regressions in this area.
2169 * data.c (Faset):
2170 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2171 (Fsubst_char_in_region):
2172 * fns.c (concat):
2173 * xdisp.c (decode_mode_spec_coding):
2174 Adjust to CHAR_STRING's new requirement.
2175 * editfns.c (Finsert_char, Fsubst_char_in_region):
2176 * fns.c (concat): Check that character args are actually
2177 characters. Without this test, these functions did the wrong
2178 thing with wildly out-of-range values on 64-bit hosts.
2179
2180 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2181 These casts should not be needed on 32-bit hosts, either.
2182 * keyboard.c (read_char):
2183 * lread.c (Fload): Remove casts to unsigned.
2184
2185 * lisp.h (UNSIGNED_CMP): New macro.
2186 This fixes comparison bugs on 64-bit hosts.
2187 (ASCII_CHAR_P): Use it.
2188 * casefiddle.c (casify_object):
2189 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2190 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2191 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2192 * dispextern.h (FACE_FROM_ID):
2193 * keyboard.c (read_char): Use UNSIGNED_CMP.
2194
2195 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2196 not to EMACS_INT, to avoid GCC warning.
2197
2198 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2199
2200 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2201 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2202 isn't needed on 32-bit machines.
2203
2204 * buffer.c (Fgenerate_new_buffer_name):
2205 Use EMACS_INT for count, not int.
2206 (advance_to_char_boundary): Return EMACS_INT, not int.
2207
2208 * data.c (Qcompiled_function): Now static.
2209
2210 * window.c (window_body_lines): Now static.
2211
2212 * image.c (gif_load): Rename local to avoid shadowing.
2213
2214 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2215 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2216 * alloc.c (make_save_value): Integer argument is now of type
2217 ptrdiff_t, not int.
2218 (mark_object): Use ptrdiff_t, not int.
2219 * lisp.h (pD): New macro.
2220 * print.c (print_object): Use it.
2221
2222 * alloc.c: Use EMACS_INT, not int, to count objects.
2223 (total_conses, total_markers, total_symbols, total_vector_size)
2224 (total_free_conses, total_free_markers, total_free_symbols)
2225 (total_free_floats, total_floats, total_free_intervals)
2226 (total_intervals, total_strings, total_free_strings):
2227 Now EMACS_INT, not int. All uses changed.
2228 (Fgarbage_collect): Compute overall total using a double, so that
2229 integer overflow is less likely to be a problem. Check for overflow
2230 when converting back to an integer.
2231 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2232 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2233 These were 'int' variables that could overflow on 64-bit hosts;
2234 they were never used, so remove them instead of repairing them.
2235 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2236 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2237 Previously, this ceilinged at INT_MAX, but that doesn't work on
2238 64-bit machines.
2239 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2240
2241 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2242 (allocate_vectorlike): Check for ptrdiff_t overflow.
2243 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2244 when a (possibly-narrower) signed value would do just as well.
2245 We prefer using signed arithmetic, to avoid comparison confusion.
2246
2247 * alloc.c: Catch some string size overflows that we were missing.
2248 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2249 for convenience in STRING_BYTES_MAX.
2250 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2251 The definition here is exact; the one in lisp.h was approximate.
2252 (allocate_string_data): Check for string overflow. This catches
2253 some instances we weren't catching before. Also, it catches
2254 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2255 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2256 and ptrdiff_t and EMACS_INT are both 64 bits.
2257
2258 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2259 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2260 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2261
2262 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2263
2264 * alloc.c (Fmake_string): Check for out-of-range init.
2265
2266 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2267
2268 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2269
2270 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2271
2272 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2273 xg_get_default_scrollbar_width.
2274
2275 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2276 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2277 (style_changed_cb): Call update_theme_scrollbar_width and call
2278 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2279 all frames (Bug#8505).
2280 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2281 Call gtk_window_set_resizable if HAVE_GTK3.
2282 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2283 and height if HAVE_GTK3 (Bug#8505).
2284 (scroll_bar_width_for_theme): New variable.
2285 (update_theme_scrollbar_width): New function.
2286 (xg_get_default_scrollbar_width): Move code to
2287 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2288 (xg_initialize): Call update_theme_scrollbar_width.
2289
2290 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2291
2292 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2293
2294 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2295
2296 * frame.c (make_frame): Call other_buffer_safely instead of
2297 other_buffer.
2298
2299 * window.c (temp_output_buffer_show): Call display_buffer with
2300 second argument Vtemp_buffer_show_specifiers and reset latter
2301 immediately after the call.
2302 (Vtemp_buffer_show_specifiers): New variable.
2303 (auto_window_vscroll_p, next_screen_context_lines)
2304 (Vscroll_preserve_screen_position): Remove leading asterisks from
2305 doc-strings.
2306
2307 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2308
2309 Fix minor problems found by GCC 4.6.0 static checking.
2310 * buffer.c (Qclone_number): Remove for now, as it's unused.
2311 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2312 (record_buffer): Remove unused local.
2313 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2314 (set_frame_buffer_list): Remove; unused.
2315 * frame.h (other_visible_frames): Remove decl.
2316 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2317 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2318 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2319 if HAVE_GPM.
2320 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2321 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2322 Define only if HAVE_GPM.
2323 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2324 (update_hints_inhibit): Remove; never set. All uses removed.
2325 * widgetprv.h (emacsFrameClassRec): Remove decl.
2326 * window.c (delete_deletable_window): Now returns void, since it
2327 wasn't returning anything.
2328 (compare_window_configurations): Remove unused locals.
2329 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2330 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2331 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2332 the same widths as pointers. This follows up on the 2011-05-06 patch.
2333 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2334 * xterm.h: Likewise.
2335 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2336
2337 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2338
2339 * makefile.w32-in: Update dependencies.
2340 (LISP_H): Add lib/intprops.h.
2341
2342 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2343
2344 * image.c (gif_load): Add animation frame delay to the metadata.
2345 (syms_of_image): Use DEFSYM. New symbol `delay'.
2346
2347 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2348
2349 * window.c (delete_deletable_window): Re-add.
2350 (Fset_window_configuration): Rewrite to handle dead buffers and
2351 consequently deletable windows.
2352 (window_tree, Fwindow_tree): Remove. Supply functionality in
2353 window.el.
2354 (compare_window_configurations): Simplify code.
2355
2356 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2357
2358 * image.c (imagemagick_load_image): Fix type mismatch.
2359 (Fimagemagick_types): Likewise.
2360
2361 * window.h (replace_buffer_in_windows): Declare.
2362
2363 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2364
2365 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2366 Qclone_number. Remove external declaration of Qdelete_window.
2367 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2368 code.
2369 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2370 Run Qbuffer_list_update_hook if allowed.
2371 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2372 buffer list implementation.
2373 (other_buffer_safely): New function.
2374 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2375 calls to replace_buffer_in_windows and
2376 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2377 if allowed.
2378 (record_buffer): Inhibit quitting and rewrite using quittable
2379 functions. Run Qbuffer_list_update_hook if allowed.
2380 (Frecord_buffer, Funrecord_buffer): New functions.
2381 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2382 Move switch-to-buffer to window.el.
2383 (bury-buffer): Move to window.el.
2384 (Vbuffer_list_update_hook): New variable.
2385
2386 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2387 section.
2388
2389 * window.h (resize_frame_windows): Move up in code.
2390 (Fwindow_frame): Remove EXFUN.
2391 (replace_buffer_in_all_windows): Remove prototype.
2392 (replace_buffer_in_windows_safely): Add prototype.
2393
2394 * window.c: Declare Qdelete_window static again. Move down
2395 declaration of select_count.
2396 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2397 (Fother_window): Move to window.el.
2398 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2399 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2400 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2401 window.el.
2402 (replace_buffer_in_windows): Implement by calling
2403 Qreplace_buffer_in_windows.
2404 (replace_buffer_in_all_windows): Remove with some functionality
2405 moved into replace_buffer_in_windows_safely.
2406 (replace_buffer_in_windows_safely): New function.
2407 (select_window_norecord, select_frame_norecord): Move in front
2408 of run_window_configuration_change_hook. Remove now obsolete
2409 declarations.
2410 (Fset_window_buffer): Rewrite doc-string.
2411 Call Qrecord_window_buffer.
2412 (keys_of_window): Move binding for other-window to window.el.
2413
2414 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2415
2416 * dispextern.h (struct image): Replace data member, whose int_val
2417 and ptr_val fields were not used by anything, with a single
2418 lisp_val object.
2419
2420 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2421 (gif_clear_image, gif_load, imagemagick_load_image)
2422 (gs_clear_image, gs_load): Callers changed.
2423
2424 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2425
2426 * buffer.h: Include <time.h>, for time_t.
2427 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2428
2429 Fix minor problems found by static checking.
2430
2431 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2432
2433 Make identifiers static if they are not used in other modules.
2434 * data.c (Qcompiled_function, Qframe, Qvector):
2435 * image.c (QimageMagick, Qsvg):
2436 * minibuf.c (Qmetadata):
2437 * window.c (resize_window_check, resize_root_window): Now static.
2438 * window.h (resize_window_check, resize_root_window): Remove decls.
2439
2440 * window.c (window_deletion_count, delete_deletable_window):
2441 Remove; unused.
2442 (window_body_lines): Now static.
2443 (Fdelete_other_windows_internal): Mark vars as initialized.
2444 Make sure 'resize_failed' is initialized.
2445 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2446 (resize_window_apply): Remove unused local.
2447 * window.h (delete_deletable_window): Remove decl.
2448
2449 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2450 (imagemagick_load_image): Fix pointer signedness problem by changing
2451 last arg from unsigned char * to char *. All uses changed.
2452 Also, fix a local for similar reasons.
2453 Remove unused locals. Remove locals to avoid shadowing.
2454 (fn_rsvg_handle_free): Remove; unused.
2455 (svg_load, svg_load_image): Fix pointer signedness problem.
2456 (imagemagick_load_image): Don't use garbage pointer image_wand.
2457
2458 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2459
2460 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2461
2462 * image.c (gif_load): Fix omitted cast error introduced by
2463 2011-06-06 change.
2464
2465 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2466
2467 * window.h (resize_proportionally, orig_total_lines)
2468 (orig_top_line): Remove from window structure.
2469 (set_window_height, set_window_width, change_window_heights)
2470 (Fdelete_window): Remove prototypes.
2471 (resize_frame_windows): Remove duplicate declaration.
2472
2473 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2474
2475 * window.h (resize_frame_windows, resize_window_check)
2476 (delete_deletable_window, resize_root_window)
2477 (resize_frame_windows): Declare prototypes.
2478
2479 * window.c (resize_window_apply): Make definition be "static" to
2480 match the prototype.
2481
2482 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2483
2484 * window.c: Remove declarations of Qwindow_size_fixed,
2485 window_min_size_1, window_min_size_2, window_min_size,
2486 size_window, window_fixed_size_p, enlarge_window, delete_window.
2487 Remove static from declaration of Qdelete_window, it's
2488 temporarily needed by Fbury_buffer.
2489 (replace_window): Don't assign orig_top_line and
2490 orig_total_lines.
2491 (Fdelete_window, delete_window): Remove. Window deletion is
2492 handled by window.el.
2493 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2494 Replace Fdelete_window calls with calls to Qdelete_window.
2495 (Fdelete_other_windows): Remove. Deleting other windows is
2496 handled by window.el.
2497 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2498 handled in window.el.
2499 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2500 Window minimum sizes are handled in window.el.
2501 (shrink_windows, size_window, set_window_height)
2502 (set_window_width, change_window_heights, window_height)
2503 (window_width, CURBEG, CURSIZE, enlarge_window)
2504 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2505 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2506 handled in window.el.
2507 (make_dummy_parent): Rename to make_parent_window and give it a
2508 second argument horflag.
2509 (make_window): Don't set resize_proportionally any more.
2510 (Fsplit_window): Remove. Windows are split in window.el.
2511 (save_restore_action, save_restore_orig_size)
2512 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2513 Resize mini windows in window.el.
2514 (grow_mini_window, shrink_mini_window): Implement by calling
2515 Qresize_root_window_vertically, resize_window_check and
2516 resize_window_apply.
2517 (saved_window, Fset_window_configuration, save_window_save):
2518 Do not handle orig_top_line, orig_total_lines, and
2519 resize_proportionally.
2520 (window_min_height, window_min_width): Move to window.el.
2521 (keys_of_window): Move bindings for delete-other-windows,
2522 split-window, delete-window and enlarge-window to window.el.
2523
2524 * buffer.c: Temporarily extern Qdelete_window.
2525 (Fbury_buffer): Temporarily call Qdelete_window instead of
2526 Fdelete_window (Fbury_buffer will move to window.el soon).
2527
2528 * frame.c (set_menu_bar_lines_1): Remove code handling
2529 orig_top_line and orig_total_lines.
2530
2531 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2532 set_window_height but set heights directly.
2533 (change_frame_size_1): Use resize_frame_windows.
2534
2535 * xdisp.c (init_xdisp): Don't use set_window_height but set
2536 heights directly.
2537
2538 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2539 Use resize_frame_windows instead of change_window_heights and run
2540 run_window_configuration_change_hook.
2541
2542 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2543 instead of change_window_heights and run
2544 run_window_configuration_change_hook.
2545
2546 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2547
2548 * window.c (replace_window): Rename second argument REPLACEMENT to
2549 NEW. New third argument SETFLAG. Rewrite.
2550 (delete_window, make_dummy_parent): Call replace_window with
2551 third argument 1.
2552 (window_list_1): Move down in code.
2553 (run_window_configuration_change_hook): Move set_buffer part
2554 before select_frame_norecord part in order to unwind correctly.
2555 Rename count1 to count.
2556 (recombine_windows, delete_deletable_window, resize_root_window)
2557 (Fdelete_other_windows_internal)
2558 (Frun_window_configuration_change_hook, make_parent_window)
2559 (resize_window_check, resize_window_apply, Fresize_window_apply)
2560 (resize_frame_windows, Fsplit_window_internal)
2561 (Fdelete_window_internal, Fresize_mini_window_internal):
2562 New functions.
2563 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2564
2565 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2566
2567 * window.h (window): Add some new members to window structure -
2568 normal_lines, normal_cols, new_total, new_normal, clone_number,
2569 splits, nest, prev_buffers, next_buffers.
2570 (WINDOW_TOTAL_SIZE): Move here from window.c.
2571 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2572
2573 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2574 Remove.
2575 (make_dummy_parent): Set new members of windows structure.
2576 (make_window): Move down in code. Handle new members of window
2577 structure.
2578 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2579 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2580 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2581 (Fset_window_prev_buffers, Fwindow_next_buffers)
2582 (Fset_window_next_buffers, Fset_window_clone_number):
2583 New functions.
2584 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2585 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2586 Doc-string fixes.
2587 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2588 Argument WINDOW can be now internal window too.
2589 (Fwindow_use_time): Move up in code.
2590 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2591 Rewrite doc-string.
2592 (Fset_window_configuration, saved_window)
2593 (Fcurrent_window_configuration, save_window_save): Handle new
2594 members of window structure.
2595 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2596 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2597 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2598 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2599 Qget_mru_window, Qresize_root_window,
2600 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2601 Qauto_buffer_name; staticpro them.
2602
2603 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2604
2605 * window.c (Fwindow_total_size, Fwindow_left_column)
2606 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2607 (Fwindow_list_1): New functions.
2608 (window_box_text_cols): Replace with window_body_cols.
2609 (Fwindow_width, Fscroll_left, Fscroll_right):
2610 Use window_body_cols instead of window_box_text_cols.
2611 (delete_window, Fset_window_configuration):
2612 Call delete_all_subwindows with window as argument.
2613 (delete_all_subwindows): Take a window as argument and not a
2614 structure. Rewrite.
2615 (window_loop): Remove handling of GET_LRU_WINDOW and
2616 GET_LARGEST_WINDOW.
2617 (Fget_lru_window, Fget_largest_window): Move to window.el.
2618
2619 * window.h: Extern window_body_cols instead of
2620 window_box_text_cols. delete_all_subwindows now takes a
2621 Lisp_Object as argument.
2622
2623 * indent.c (compute_motion, Fcompute_motion):
2624 Use window_body_cols instead of window_box_text_cols.
2625
2626 * frame.c (delete_frame): Call delete_all_subwindows with root
2627 window as argument.
2628
2629 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2630
2631 * fns.c (Fputhash): Document return value.
2632
2633 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2634
2635 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2636
2637 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2638
2639 Cons<->int and similar integer overflow fixes (Bug#8794).
2640
2641 Check for overflow when converting integer to cons and back.
2642 * charset.c (Fdefine_charset_internal, Fdecode_char):
2643 Use cons_to_unsigned to catch overflow.
2644 (Fencode_char): Use INTEGER_TO_CONS.
2645 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2646 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2647 * data.c (long_to_cons, cons_to_long): Remove.
2648 (cons_to_unsigned, cons_to_signed): New functions.
2649 These signal an error for invalid or out-of-range values.
2650 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2651 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2652 * font.c (Ffont_variation_glyphs):
2653 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2654 * lisp.h: Include <intprops.h>.
2655 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2656 (cons_to_signed, cons_to_unsigned): New decls.
2657 (long_to_cons, cons_to_long): Remove decls.
2658 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2659 (Fprimitive_undo): Use CONS_TO_INTEGER.
2660 * xfns.c (Fx_window_property): Likewise.
2661 * xselect.c: Include <limits.h>.
2662 (x_own_selection, selection_data_to_lisp_data):
2663 Use INTEGER_TO_CONS.
2664 (x_handle_selection_request, x_handle_selection_clear)
2665 (x_get_foreign_selection, Fx_disown_selection_internal)
2666 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2667 (lisp_data_to_selection_data): Use cons_to_unsigned.
2668 (x_fill_property_data): Use cons_to_signed.
2669 Report values out of range.
2670
2671 Check for buffer and string overflow more precisely.
2672 * buffer.h (BUF_BYTES_MAX): New macro.
2673 * lisp.h (STRING_BYTES_MAX): New macro.
2674 * alloc.c (Fmake_string):
2675 * character.c (string_escape_byte8):
2676 * coding.c (coding_alloc_by_realloc):
2677 * doprnt.c (doprnt):
2678 * editfns.c (Fformat):
2679 * eval.c (verror):
2680 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2681 since they may not be the same number.
2682 * editfns.c (Finsert_char):
2683 * fileio.c (Finsert_file_contents):
2684 Likewise for BUF_BYTES_MAX.
2685
2686 * image.c: Use ptrdiff_t, not int, for sizes.
2687 (slurp_file): Switch from int to ptrdiff_t.
2688 All uses changed.
2689 (slurp_file): Check that file size fits in both size_t (for
2690 malloc) and ptrdiff_t (for sanity and safety).
2691
2692 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2693 if b->modtime has its maximal value.
2694
2695 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2696
2697 Don't assume time_t can fit into int.
2698 * buffer.h (struct buffer.modtime): Now time_t, not int.
2699 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2700 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2701
2702 Minor fixes for signed vs unsigned integers.
2703 * character.h (MAYBE_UNIFY_CHAR):
2704 * charset.c (maybe_unify_char):
2705 * keyboard.c (read_char, reorder_modifiers):
2706 XINT -> XFASTINT, since the integer must be nonnegative.
2707 * ftfont.c (ftfont_spec_pattern):
2708 * keymap.c (access_keymap, silly_event_symbol_error):
2709 XUINT -> XFASTINT, since the integer must be nonnegative.
2710 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2711 since it makes no difference and we prefer signed.
2712 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2713 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2714 nonnegative.
2715
2716 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2717
2718 * window.h (Fwindow_frame): Declare.
2719
2720 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2721
2722 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2723 (SPARE_MEMORY): Always define.
2724 (LARGE_REQUEST): Remove.
2725 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2726
2727 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2728
2729 * lisp.h: Move EXFUNS for Fframe_root_window,
2730 Fframe_first_window and Fset_frame_selected_window to window.h.
2731
2732 * window.h: Move EXFUNS for Fframe_root_window,
2733 Fframe_first_window and Fset_frame_selected_window here from
2734 lisp.h.
2735
2736 * frame.c (Fwindow_frame, Fframe_first_window)
2737 (Fframe_root_window, Fframe_selected_window)
2738 (Fset_frame_selected_window): Move to window.c.
2739 (Factive_minibuffer_window): Move to minibuf.c.
2740 (Fother_visible_frames_p): New function.
2741
2742 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2743
2744 * window.c (decode_window, decode_any_window): Move up in code.
2745 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2746 (inhibit_frame_unsplittable): Remove unused variable.
2747 (Fwindow_buffer): Move up and rewrite doc-string.
2748 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2749 (Fwindow_prev): New functions.
2750 (Fwindow_frame): Move here from frame.c. Accept any window as
2751 argument.
2752 (Fframe_root_window, Fframe_first_window)
2753 (Fframe_selected_window): Move here from frame.c. Accept frame
2754 or arbitrary window as argument. Update doc-strings.
2755 (Fminibuffer_window): Move up in code.
2756 (Fwindow_minibuffer_p): Move up in code and simplify.
2757 (Fset_frame_selected_window): Move here from frame.c.
2758 Marginal rewrite.
2759 (Fselected_window, select_window, Fselect_window): Move up in
2760 code. Minor doc-string fixes.
2761
2762 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2763
2764 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2765 Do not assume that spare memory exists; that assumption is valid
2766 only if SYSTEM_MALLOC.
2767 (LARGE_REQUEST): New macro, so that the issue of large requests
2768 is separated from the issue of spare memory.
2769
2770 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2771
2772 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2773 format. (Bug#8806)
2774
2775 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2776
2777 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2778 before statements.
2779
2780 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2781
2782 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2783
2784 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2785
2786 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2787 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2788
2789 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2790
2791 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2792
2793 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2794
2795 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2796 (x_clipboard_manager_save): Add return value.
2797 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2798 New error handlers.
2799 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2800 Obey Vx_select_enable_clipboard_manager. Catch errors in
2801 x_clipboard_manager_save (Bug#8779).
2802 (Vx_select_enable_clipboard_manager): New variable.
2803 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2804
2805 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2806
2807 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2808
2809 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2810
2811 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2812 in the current matrix if keep_current_p is non-zero.
2813
2814 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2815
2816 * bidi.c (bidi_level_of_next_char): Fix last change.
2817
2818 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2819
2820 Support bidi reordering of text covered by display properties.
2821
2822 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2823 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2824 (bidi_cache_search, bidi_cache_iterator_state)
2825 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2826 (bidi_level_of_next_char, bidi_move_to_visually_next):
2827 Support character positions inside a run of characters covered by a
2828 display string.
2829 (bidi_paragraph_init, bidi_resolve_explicit_1)
2830 (bidi_level_of_next_char): Call bidi_fetch_char and
2831 bidi_fetch_char_advance instead of FETCH_CHAR and
2832 FETCH_CHAR_ADVANCE.
2833 (bidi_init_it): Initialize new members.
2834 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2835 definitions.
2836 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2837 instead of using explicit *_CHAR codes.
2838 (bidi_resolve_explicit, bidi_resolve_weak):
2839 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2840 bidirectional text is supported only in multibyte buffers.
2841 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2842 it to initialize the frame_window_p member of struct bidi_it.
2843 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2844 (bidi_resolve_explicit, bidi_resolve_weak)
2845 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2846 bidi_it->nchars is non-positive.
2847 (bidi_level_of_next_char): Don't try to lookup the cache for the
2848 next/previous character if nothing is cached there yet, or if we
2849 were just reseat()'ed to a new position.
2850
2851 * xdisp.c (set_cursor_from_row): Set start and stop points
2852 according to the row's direction when priming the loop that looks
2853 for the glyph on which to display cursor.
2854 (single_display_spec_intangible_p): Function deleted.
2855 (display_prop_intangible_p): Reimplement to call
2856 handle_display_spec instead of single_display_spec_intangible_p.
2857 Accept 3 additional arguments needed by handle_display_spec.
2858 This fixes incorrect cursor motion across display property with complex
2859 values: lists, `(when COND...)' forms, etc.
2860 (single_display_spec_string_p): Support property values that are
2861 lists with the argument STRING its top-level element.
2862 (display_prop_string_p): Fix the condition for processing a
2863 property that is a list to be consistent with handle_display_spec.
2864 (handle_display_spec): New function, refactored from the
2865 last portion of handle_display_prop.
2866 (compute_display_string_pos): Accept additional argument
2867 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2868 value of a `display' property is a "replacing spec".
2869 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2870 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2871 the display property, but just return a value indicating whether
2872 the display property will replace the characters it covers.
2873 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2874 frame_window_p members of struct bidi_it.
2875 (compute_display_string_pos, compute_display_string_end):
2876 New functions.
2877 (push_it): Accept second argument POSITION, where pop_it should
2878 jump to continue iteration.
2879 (reseat_1): Initialize bidi_it.disp_pos.
2880
2881 * keyboard.c (adjust_point_for_property): Adjust the call to
2882 display_prop_intangible_p to its new signature.
2883
2884 * dispextern.h (struct bidi_it): New member frame_window_p.
2885 (bidi_init_it): Update prototypes.
2886 (display_prop_intangible_p): Update prototype.
2887 (compute_display_string_pos, compute_display_string_end):
2888 Declare prototypes.
2889 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2890 EMACS_INT.
2891
2892 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2893
2894 Malloc failure behavior now depends on size of allocation.
2895 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2896 * lisp.h: Change signatures accordingly.
2897 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2898 All callers changed. (Bug#8762)
2899
2900 * gnutls.c: Use Emacs's memory allocators.
2901 Without this change, the gnutls library would invoke malloc etc.
2902 directly, which causes problems on non-SYNC_INPUT hosts, and which
2903 runs afoul of improving memory_full behavior. (Bug#8761)
2904 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2905 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2906 xfree instead of the default malloc, realloc, free.
2907 (Fgnutls_boot): No need to check for memory allocation failure,
2908 since xmalloc does that for us.
2909
2910 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2911 * category.c (hash_get_category_set):
2912 * ccl.c (ccl_driver):
2913 * charset.c (Fdefine_charset_internal):
2914 * charset.h (struct charset.hash_index):
2915 * composite.c (get_composition_id, gstring_lookup_cache)
2916 (composition_gstring_put_cache):
2917 * composite.h (struct composition.hash_index):
2918 * dispextern.h (struct image.hash):
2919 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2920 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2921 (hashfn_equal, hashfn_user_defined, make_hash_table)
2922 (maybe_resize_hash_table, hash_lookup, hash_put)
2923 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2924 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2925 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2926 * image.c (make_image, search_image_cache, lookup_image)
2927 (xpm_put_color_table_h):
2928 * lisp.h (struct Lisp_Hash_Table):
2929 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2930 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2931 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2932 * alloc.c (allocate_vectorlike):
2933 Check for overflow in vector size calculations.
2934 * ccl.c (ccl_driver):
2935 Check for overflow when converting EMACS_INT to int.
2936 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2937 need to be updated by these changes.
2938 * fns.c (make_hash_table, maybe_resize_hash_table):
2939 Check for integer overflow with large hash tables.
2940 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2941 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2942 (SXHASH_REDUCE): New macro.
2943 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2944 Use it instead of discarding useful hash info with large hash values.
2945 (sxhash_float): New function.
2946 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2947 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2948 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2949 Rewrite to use FIXNUM_BITS, as this simplifies things.
2950 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2951 Adjust signatures to match updated version of code.
2952 (consing_since_gc): Now EMACS_INT, since a single hash table can
2953 use more than INT_MAX bytes.
2954
2955 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2956
2957 Make it possible to build with GCC-4.6+ -O2 -flto.
2958
2959 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2960
2961 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2962
2963 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2964 Call minibuffer-inactive-mode.
2965
2966 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2967
2968 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2969 Update dependencies.
2970
2971 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2972
2973 * data.c (init_data): Remove code for UTS, this system is not
2974 supported anymore.
2975
2976 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2977
2978 Don't force ./temacs to start in terminal mode.
2979
2980 * frame.c (make_initial_frame): Initialize faces in all cases, not
2981 only when CANNOT_DUMP is defined.
2982 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2983
2984 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2985
2986 * dispnew.c (add_window_display_history): Use const for the string
2987 pointer. Remove declaration, not needed.
2988
2989 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2990
2991 Use 'inline', not 'INLINE'.
2992 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2993 * alloc.c, fontset.c (INLINE): Remove.
2994 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2995 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2996 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2997 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2998 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2999
3000 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3001
3002 Make it possible to run ./temacs.
3003
3004 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3005 syms_of_callproc does the same thing. Remove test for
3006 "initialized", do it in the caller.
3007 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3008
3009 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3010
3011 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3012 (read_minibuf): Use get_minibuffer.
3013 (syms_of_minibuf): Use DEFSYM.
3014 (Qmetadata): New var.
3015 * data.c (Qbuffer): Don't make it static.
3016 (syms_of_data): Use DEFSYM.
3017
3018 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3019
3020 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3021 (CCL_CODE_MIN): New macro.
3022
3023 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3024
3025 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3026
3027 * eval.c (Qdebug): Now static.
3028 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3029 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3030 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3031
3032 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3033
3034 * image.c: Various fixes to ImageMagick code comments.
3035 (Fimagemagick_types): Doc fix.
3036
3037 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3038
3039 Minor fixes prompted by GCC 4.6.0 warnings.
3040
3041 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3042
3043 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3044 (x_clipboard_manager_save_all): Move extern decl to ...
3045 * xterm.h: ... here, so that it can be checked for consistency.
3046
3047 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3048
3049 * xselect.c (x_clipboard_manager_save_frame)
3050 (x_clipboard_manager_save_all): New functions.
3051 (Fx_clipboard_manager_save): Lisp function deleted.
3052
3053 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3054 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3055
3056 * xterm.h: Update prototype.
3057
3058 2011-05-28 William Xu <william.xwl@gmail.com>
3059
3060 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3061 exiting (Bug#8239).
3062
3063 2011-05-28 Jim Meyering <meyering@redhat.com>
3064
3065 Avoid a sign-extension bug in crypto_hash_function.
3066 * fns.c (to_uchar): Define.
3067 (crypto_hash_function): Use it to convert some newly-signed
3068 variables to unsigned, to avoid sign-extension bugs. For example,
3069 without this change, (md5 "truc") would evaluate to
3070 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3071 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3072 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3073
3074 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3075
3076 Integer overflow fixes.
3077
3078 * dbusbind.c: Serial number integer overflow fixes.
3079 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3080 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3081 to hold a serial number that is too large for a fixnum.
3082 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3083 Check for serial numbers out of range. Decode any serial number
3084 that was so large that it became a float. (Bug#8722)
3085
3086 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3087 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3088 Use XFASTINT rather than XUINT when numbers are nonnegative.
3089 (xd_append_arg, Fdbus_method_return_internal):
3090 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3091 arguments, check that Lisp number is nonnegative, rather than
3092 silently wrapping negative numbers around. (Bug#8722)
3093 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3094 (Bug#8722)
3095
3096 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3097
3098 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3099
3100 ccl: add integer overflow checks
3101 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3102 (IN_INT_RANGE): New macros.
3103 (ccl_driver): Use them to check for integer overflow when
3104 decoding a CCL program. Many of the new checks are whether XINT (x)
3105 fits in int; it doesn't always, on 64-bit hosts. The new version
3106 doesn't catch all possible integer overflows, but it's an
3107 improvement. (Bug#8719)
3108
3109 * alloc.c (make_event_array): Use XINT, not XUINT.
3110 There's no need for unsigned here.
3111
3112 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3113 This follows up to the 2011-05-06 change that substituted uintptr_t
3114 for EMACS_INT. This case wasn't caught back then.
3115
3116 Rework Fformat to avoid integer overflow issues.
3117 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3118 now (part of C89). Include <verify.h>.
3119 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3120 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3121 (Fformat): Avoid the prepass trying to compute sizes; it was only
3122 approximate and thus did not catch overflow reliably. Instead, walk
3123 through the format just once, formatting and computing sizes as we go,
3124 checking for integer overflow at every step, and allocating a larger
3125 buffer as needed. Keep track separately whether the format is
3126 multibyte. Keep only the most-recently calculated precision, rather
3127 than them all. Record whether each argument has been converted to
3128 string. Use EMACS_INT, not int, for byte and char and arg counts.
3129 Support field widths and precisions larger than INT_MAX. Avoid
3130 sprintf's undefined behavior with conversion specifications such as %#d
3131 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3132 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3133 formatting out-of-range floating point numbers with int
3134 formats. (Bug#8668)
3135
3136 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3137
3138 * data.c: Avoid integer truncation in expressions involving floats.
3139 * data.c: Include <intprops.h>.
3140 (arith_driver): When there's an integer overflow in an expression
3141 involving floating point, convert the integers to floating point
3142 so that the resulting value does not suffer from catastrophic
3143 integer truncation. For example, on a 64-bit host (* 4
3144 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3145 Do not rely on undefined behavior after integer overflow.
3146
3147 merge count_size_as_multibyte, parse_str_to_multibyte
3148 * character.c, character.h (count_size_as_multibyte):
3149 Rename from parse_str_to_multibyte; all uses changed.
3150 Check for integer overflow.
3151 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3152 since it's now a duplicate of the other. This is more of
3153 a character than a buffer op, so better that it's in character.c.
3154 * fns.c, print.c: Adjust to above changes.
3155
3156 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3157
3158 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3159
3160 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3161
3162 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3163 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3164 (x_clipboard_manager_save): Now static.
3165 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3166
3167 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3168 (crypto_hash_function): Now static.
3169 Fix pointer signedness problems. Avoid unnecessary initializations.
3170
3171 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3172
3173 * termhooks.h (Vselection_alist): Make it terminal-local.
3174
3175 * terminal.c (create_terminal): Initialize it.
3176
3177 * xselect.c: Support for clipboard managers.
3178 (Vselection_alist): Move to termhooks.h as terminal-local var.
3179 (LOCAL_SELECTION): New macro.
3180 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3181 (symbol_to_x_atom): Remove gratuitous arg.
3182 (x_handle_selection_request, lisp_data_to_selection_data)
3183 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3184 (x_own_selection, x_get_local_selection, x_convert_selection):
3185 New arg, specifying work frame. Use terminal-local Vselection_alist.
3186 (some_frame_on_display): Delete unused function.
3187 (Fx_own_selection_internal, Fx_get_selection_internal)
3188 (Fx_disown_selection_internal, Fx_selection_owner_p)
3189 (Fx_selection_exists_p): New optional frame arg.
3190 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3191 (x_handle_selection_clear): Don't treat other terminals with the
3192 same keyboard specially. Use the terminal-local Vselection_alist.
3193 (x_clear_frame_selections): Use Frun_hook_with_args.
3194
3195 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3196
3197 * xterm.h: Add support for those atoms.
3198
3199 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3200
3201 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3202 (converted_selections, conversion_fail_tag): New global variables.
3203 (x_selection_request_lisp_error): Free the above.
3204 (x_get_local_selection): Remove unnecessary code.
3205 (x_reply_selection_request): Args changed; handle arbitrary array
3206 of converted selections stored in converted_selections.
3207 Separate the XChangeProperty and SelectionNotify steps.
3208 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3209 (x_convert_selection): New function.
3210 (x_handle_selection_event): Simplify.
3211 (x_get_foreign_selection): Don't ignore incoming requests while
3212 waiting for an answer; this will fail when we implement
3213 SAVE_TARGETS, and seems unnecessary anyway.
3214 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3215 (Vx_sent_selection_functions): Doc fix.
3216
3217 2011-05-26 Leo Liu <sdl.web@gmail.com>
3218
3219 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3220
3221 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3222
3223 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3224
3225 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3226 for fringe update if it has periodic bitmap.
3227 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3228 and fringe_bitmap_periodic_p.
3229
3230 * fringe.c (get_fringe_bitmap_data): New function.
3231 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3232 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3233 row. Mark glyph row for fringe update if periodicity changed.
3234
3235 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3236 for fringe update unless it has periodic bitmap.
3237
3238 2011-05-25 Kenichi Handa <handa@m17n.org>
3239
3240 * xdisp.c (get_next_display_element): Set correct it->face_id for
3241 a static composition.
3242
3243 2011-05-24 Leo Liu <sdl.web@gmail.com>
3244
3245 * deps.mk (fns.o):
3246 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3247
3248 * fns.c (crypto_hash_function, Fsha1): New function.
3249 (Fmd5): Use crypto_hash_function.
3250 (syms_of_fns): Add Ssha1.
3251
3252 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3253
3254 * gnutls.c: Remove unused macros.
3255 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3256 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3257 Remove macros that are defined and never used.
3258 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3259
3260 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3261
3262 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3263 (Fx_get_selection_internal): Minor cleanup.
3264 (Fx_own_selection_internal): Rename arguments for consistency with
3265 select.el.
3266
3267 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3268
3269 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3270
3271 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3272
3273 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3274
3275 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3276
3277 * dispnew.c (scrolling_window): Don't exclude the case that the
3278 last enabled row in the desired matrix touches the bottom boundary.
3279
3280 2011-05-21 Glenn Morris <rgm@gnu.org>
3281
3282 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3283 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3284 and add some more files.
3285
3286 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3287
3288 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3289 report_file_error introduced by the change from 2011-05-07.
3290
3291 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3292
3293 * systime.h (Time): Define only if emacs is defined.
3294 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3295 where the include path doesn't have X11/X.h by default. See
3296 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3297
3298 2011-05-20 Kenichi Handa <handa@m17n.org>
3299
3300 * composite.c (find_automatic_composition): Fix previous change.
3301
3302 2011-05-20 Glenn Morris <rgm@gnu.org>
3303
3304 * lisp.mk: New file, split from Makefile.in.
3305 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3306 (shortlisp): Remove.
3307 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3308
3309 2011-05-19 Glenn Morris <rgm@gnu.org>
3310
3311 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3312 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3313 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3314 (lisp): Set the order to that of loadup.el.
3315 (shortlisp): Make it a copy of $lisp.
3316 (SOME_MACHINE_LISP): Remove.
3317 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3318 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3319
3320 2011-05-18 Kenichi Handa <handa@m17n.org>
3321
3322 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3323 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3324 (find_automatic_composition): Mostly rewrite for efficiency.
3325
3326 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3327
3328 * makefile.w32-in: Update dependencies.
3329
3330 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3331
3332 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3333 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3334
3335 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3336
3337 Fix some integer overflow issues, such as string length overflow.
3338
3339 * insdel.c (count_size_as_multibyte): Check for string overflow.
3340
3341 * character.c (lisp_string_width): Check for string overflow.
3342 Use EMACS_INT, not int, for string indexes and lengths; in
3343 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3344 the resulting string length overflows an EMACS_INT; instead,
3345 report a string overflow if no precision given. When checking for
3346 precision exhaustion, use a check that cannot possibly have
3347 integer overflow. (Bug#8675)
3348 * character.h (lisp_string_width): Adjust to new signature.
3349
3350 * alloc.c (string_overflow): New function.
3351 (Fmake_string): Use it. This doesn't change behavior, but saves
3352 a few bytes and will simplify future changes.
3353 * character.c (string_escape_byte8): Likewise.
3354 * lisp.h (string_overflow): New decl.
3355
3356 Fixups, following up to the user-interface timestamp change.
3357 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3358 for UI timestamps, instead of unsigned long.
3359 * msdos.c (mouse_get_pos): Likewise.
3360 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3361 * w32gui.h (Time): Define by including "systime.h" rather than by
3362 declaring it ourselves. (Bug#8664)
3363
3364 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3365 * image.c (clear_image_cache): Likewise.
3366
3367 * term.c (term_mouse_position): Don't assume time_t wraparound.
3368
3369 Be more systematic about user-interface timestamps.
3370 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3371 and sometimes 'EMACS_UINT', to represent these timestamps.
3372 This change causes it to use 'Time' uniformly, as that's what X uses.
3373 This makes the code easier to follow, and makes it easier to catch
3374 integer overflow bugs such as Bug#8664.
3375 * frame.c (Fmouse_position, Fmouse_pixel_position):
3376 Use Time, not unsigned long, for user-interface timestamps.
3377 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3378 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3379 * keyboard.h (last_event_timestamp): Likewise.
3380 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3381 * menu.h (xmenu_show): Likewise.
3382 * term.c (term_mouse_position): Likewise.
3383 * termhooks.h (struct input_event.timestamp): Likewise.
3384 (struct terminal.mouse_position_hook): Likewise.
3385 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3386 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3387 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3388 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3389 what it was before.
3390 * menu.h, termhooks.h: Include "systime.h", for Time.
3391
3392 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3393 Don't assume that the difference between two unsigned long values
3394 can fit into an integer. At this point, we know button_down_time
3395 <= event->timestamp, so the difference must be nonnegative, so
3396 there's no need to cast the result if double-click-time is
3397 nonnegative, as it should be; check that it's nonnegative, just in
3398 case. This bug is triggered when events are more than 2**31 ms
3399 apart (about 25 days). (Bug#8664)
3400
3401 * xselect.c (last_event_timestamp): Remove duplicate decl.
3402 (x_own_selection): Remove needless cast to unsigned long.
3403
3404 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3405 that always fit in int. Use a sentinel instead of a counter, to
3406 avoid a temp and to allay GCC's concerns about possible int overflow.
3407 * frame.h (struct frame): Use int for menu_bar_items_used
3408 instead of EMACS_INT, since it always fits in int.
3409
3410 * menu.c (grow_menu_items): Check for int overflow.
3411
3412 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3413
3414 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3415 Before, the code was not consistent. These values cannot exceed
3416 2**31 - 1 so there's no need to make them unsigned.
3417 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3418 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3419 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3420 as modifiers.
3421 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3422
3423 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3424 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3425 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3426 presumably because the widths might not match.
3427
3428 * window.c (size_window): Avoid needless test at loop start.
3429
3430 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3431
3432 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3433
3434 2011-05-12 Drew Adams <drew.adams@oracle.com>
3435
3436 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3437
3438 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3439
3440 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3441 `width' to `bar_area_x' and `bar_area_width', respectively.
3442 (x_scroll_run): Take account of fringe background extension.
3443
3444 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3445 Rename local vars `left' and `width' to `bar_area_x' and
3446 `bar_area_width', respectively.
3447 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3448 background extension.
3449
3450 2011-05-10 Jim Meyering <meyering@redhat.com>
3451
3452 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3453
3454 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3455
3456 * image.c (Finit_image_library): Return t for built-in image types,
3457 like pbm and xbm. (Bug#8640)
3458
3459 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3460
3461 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3462
3463 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3464
3465 * w32console.c (Fset_screen_color): Doc fix.
3466 (Fget_screen_color): New function.
3467 (syms_of_ntterm): Defsubr it.
3468
3469 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3470 unlink the temporary file if Fcall_process didn't create it in the
3471 first place.
3472 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3473 child process will be redirected to a file specified with `:file'.
3474 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3475 cue to call_process_cleanup not to close that handle.
3476
3477 2011-05-07 Ben Key <bkey76@gmail.com>
3478
3479 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3480 one of two shell specific rules, either bootstrap-temacs-CMD or
3481 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3482 to the previous implementation of the bootstrap-temacs rule.
3483 The bootstrap-temacs-CMD rule is similar to the previous
3484 implementation of the bootstrap-temacs rule except that it
3485 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3486 variable.
3487
3488 These changes, along with some changes to nt/configure.bat,
3489 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3490 earlier fix to add support for --cflags and --ldflags options
3491 that include quotes so that it works whether make uses cmd or
3492 sh as the shell.
3493
3494 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3495
3496 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3497 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3498 is a constant.
3499 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3500 a string. Handle both cases.
3501 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3502 (Fdbus_register_method): Use Qinvalid_function.
3503
3504 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3505
3506 * makefile.w32-in: Update dependencies.
3507 (LISP_H): Add inttypes.h and stdin.h.
3508 (PROCESS_H): Add unistd.h.
3509
3510 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3511
3512 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3513 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3514
3515 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3516
3517 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3518
3519 * term.c (vfatal): Remove stray call to va_end.
3520 It's not needed and the C Standard doesn't allow it here anyway.
3521
3522 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3523 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3524
3525 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3526 bytes.
3527
3528 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3529
3530 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3531
3532 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3533
3534 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3535
3536 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3537
3538 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3539 * charset.c (Fdefine_charset_internal): Don't initialize
3540 charset.code_space[15]. The value was garbage, on hosts with
3541 32-bit int (Bug#8600).
3542
3543 * lread.c (read_integer): Be more consistent with string-to-number.
3544 Use string_to_number to do the actual conversion; this avoids
3545 rounding errors and fixes some other screwups. Without this fix,
3546 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3547 (digit_to_number): Move earlier, for benefit of read_integer.
3548 Return -1 if the digit is out of range for the base, -2 if it is
3549 not a digit in any supported base. (Bug#8602)
3550
3551 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3552
3553 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3554 to match comment at start of function. This also removes a
3555 GCC warning about overflow in a 32+64-bit port.
3556
3557 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3558
3559 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3560 Reported by Stefan Monnier in
3561 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3562 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3563 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3564
3565 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3566 (EMACS_UINTPTR): Likewise, with uintptr_t.
3567
3568 * lisp.h: Prefer 64-bit EMACS_INT if available.
3569 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3570 on 32-bit hosts that have 64-bit int, so that they can access
3571 large files.
3572 However, temporarily disable this change unless the temporary
3573 symbol WIDE_EMACS_INT is defined.
3574
3575 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3576
3577 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3578 This removes an assumption that EMACS_INT and long are the same
3579 width as pointers. The assumption is true for Emacs porting targets
3580 now, but we want to make other targets possible.
3581 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3582 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3583 In the rest of the code, change types of integers that hold casted
3584 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3585 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3586 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3587 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3588 No need to cast type when ORing.
3589 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3590 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3591 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3592 assume EMACS_INT is the same width as char *.
3593 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3594 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3595 Remove no-longer-needed casts.
3596 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3597 (xg_tool_bar_help_callback, xg_make_tool_item):
3598 Use EMACS_INTPTR to hold an integer
3599 that will be cast to void *; this can avoid a GCC warning
3600 if EMACS_INT is not the same width as void *.
3601 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3602 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3603 (current_message_1, set_message_1):
3604 Use a local to convert to proper width without a cast.
3605 * xmenu.c (dialog_selection_callback): Likewise.
3606
3607 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3608 Also, don't assume VALBITS / RAND_BITS is less than 5,
3609 and don't rely on undefined behavior when shifting a 1 left into
3610 the sign bit.
3611 * lisp.h (get_random): Change signature to match.
3612
3613 * lread.c (hash_string): Use size_t, not int, for hash computation.
3614 Normally we prefer signed values; but hashing is special, because
3615 it's better to use unsigned division on hash table sizes so that
3616 the remainder is nonnegative. Also, size_t is the natural width
3617 for hashing into memory. The previous code used 'int', which doesn't
3618 retain enough info to hash well into very large tables.
3619 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3620
3621 * dbusbind.c: Don't possibly lose pointer info when converting.
3622 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3623 Use XPNTR rather than XHASH, so that the high-order bits of
3624 the pointer aren't lost when converting through void *.
3625
3626 * eval.c (Fautoload): Don't double-shift a pointer.
3627
3628 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3629
3630 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3631
3632 * gnutls.c (DEF_GNUTLS_FN):
3633 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3634
3635 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3636
3637 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3638 marker. (Bug#8610)
3639
3640 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3641
3642 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3643 New version that can reserve upto 2GB of heap space.
3644
3645 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3646
3647 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3648
3649 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3650
3651 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3652 `gnutls_certificate_set_x509_key_file'.
3653
3654 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3655
3656 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3657 Update dependencies.
3658
3659 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3660
3661 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3662 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3663 Remove unused parameter `fildes'.
3664 * process.c (read_process_output, send_process): Don't pass it.
3665
3666 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3667
3668 Fix previous change: the library cache is defined in w32.c.
3669 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3670 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3671
3672 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3673
3674 Implement dynamic loading of GnuTLS on Windows.
3675
3676 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3677 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3678 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3679 Declare.
3680
3681 * gnutls.c (Qgnutls_dll): Define.
3682 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3683 (gnutls_*): Declare function pointers.
3684 (init_gnutls_functions): New function to initialize function pointers.
3685 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3686 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3687 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3688 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3689 (emacs_gnutls_write, emacs_gnutls_read)
3690 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3691 (Fgnutls_available_p): New function.
3692 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3693 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3694 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3695
3696 * image.c: Include w32.h.
3697 (Vimage_type_cache): Delete.
3698 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3699 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3700 (w32_delayed_load): Move to w32.c.
3701
3702 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3703
3704 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3705 (w32_delayed_load): Move from image.c. When loading a library, record
3706 its filename in the :loaded-from property of the library id.
3707 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3708 Initialize and staticpro them.
3709 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3710
3711 * process.c: Include lisp.h before w32.h, not after.
3712 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3713 instead of gnutls_record_check_pending.
3714
3715 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3716
3717 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3718
3719 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3720 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3721 as passed in.
3722
3723 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3724
3725 * xterm.c (x_set_frame_alpha): Do not set property on anything
3726 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3727
3728 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3729
3730 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3731
3732 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3733
3734 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3735 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3736 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3737 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3738 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3739 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3740 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3741 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3742 (Qgnutls_bootprop_callbacks_verify): Make static.
3743
3744 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3745
3746 * callproc.c: Indentation fixup.
3747
3748 * sysdep.c (wait_for_termination_1): Make static.
3749 (wait_for_termination, interruptible_wait_for_termination):
3750 Move after wait_for_termination_1.
3751
3752 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3753
3754 * sysdep.c (interruptible_wait_for_termination): New function
3755 which is like wait_for_termination, but allows keyboard
3756 interruptions.
3757
3758 * callproc.c (Fcall_process): Add (:file "file") as an option for
3759 the STDOUT buffer.
3760 (Fcall_process_region): Ditto.
3761
3762 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3763
3764 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3765 rather than `XVECTOR (FOO)->size'.
3766
3767 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3768 inttypes.h, as a gnulib replacement is used if it not available in
3769 system headers.
3770
3771 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3772
3773 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3774 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3775 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3776
3777 * coding.c (coding_alloc_by_realloc): Error out if destination
3778 will grow beyond MOST_POSITIVE_FIXNUM.
3779 (decode_coding_emacs_mule): Abort if there isn't enough place in
3780 charbuf for the composition carryover bytes. Reserve an extra
3781 space for up to 2 characters produced in a loop.
3782 (decode_coding_iso_2022): Abort if there isn't enough place in
3783 charbuf for the composition carryover bytes.
3784
3785 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3786
3787 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3788 aborting when %lld or %lll format is passed.
3789 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3790 %llo or %llx format is passed. (Bug#8545)
3791
3792 * window.c (window_scroll_line_based): Use a marker instead of
3793 simple variables to record original value of point. (Bug#7952)
3794
3795 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3796 produced by %s or %c overflows available buffer space. (Bug#8545)
3797
3798 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3799
3800 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3801 (SIZE_MAX): Move defn after all includes, as they might #define it.
3802
3803 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3804
3805 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3806
3807 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3808
3809 * keyboard.c (Qdelayed_warnings_hook): Define.
3810 (command_loop_1): Run `delayed-warnings-hook'
3811 if Vdelayed_warnings_list is non-nil.
3812 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3813 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3814
3815 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3816
3817 * doprnt.c (doprnt): Don't return value smaller than the buffer
3818 size if the message was truncated. (Bug#8545).
3819
3820 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3821
3822 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3823 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3824
3825 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3826
3827 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3828
3829 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3830
3831 * makefile.w32-in: Update dependencies.
3832
3833 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3834
3835 Improve `doprnt' and its usage. (Bug#8545)
3836 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3837 `format_end'. Remove support for %l as a conversion specifier.
3838 Don't use xrealloc. Improve diagnostics when the %l size modifier
3839 is used. Update the commentary.
3840
3841 * eval.c (verror): Simplify calculation of size_t.
3842
3843 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3844 messages.
3845
3846 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3847
3848 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3849 change.
3850
3851 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3852
3853 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3854 This makes this file independent of the recent pseudovector change.
3855
3856 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3857
3858 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3859
3860 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3861 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3862 Remove unused local.
3863 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3864
3865 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3866 GCC 4.6.0 optimizes based on type-based alias analysis.
3867 For example, if b is of type struct buffer * and v of type struct
3868 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3869 != &v->size, and therefore "v->size = 1; b->size = 2; return
3870 v->size;" must therefore return 1. This assumption is incorrect
3871 for Emacs, since it type-puns struct Lisp_Vector * with many other
3872 types. To fix this problem, this patch adds a new type struct
3873 vectorlike_header that documents the constraints on layout of vectors
3874 and pseudovectors, and helps optimizing compilers not get fooled
3875 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3876 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3877 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3878 the size member.
3879 (XSETPVECTYPE): Rewrite in terms of new macro.
3880 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3881 This is a bit clearer, and further avoids the possibility of
3882 undesirable aliasing.
3883 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3884 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3885 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3886 since Lisp_Subr is a special case (no "next" field).
3887 (ASIZE): Now uses header.size rather than size.
3888 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3889 to avoid the hassle of writing XVECTOR (foo)->header.size.
3890 (struct vectorlike_header): New type.
3891 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3892 object, to help avoid aliasing.
3893 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3894 (SUBRP): Likewise, since Lisp_Subr is a special case.
3895 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3896 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3897 (struct Lisp_Hash_Table): Combine first two members into a single
3898 struct vectorlike_header member. All uses of "size" and "next" members
3899 changed to be "header.size" and "header.next".
3900 * buffer.h (struct buffer): Likewise.
3901 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3902 * frame.h (struct frame): Likewise.
3903 * process.h (struct Lisp_Process): Likewise.
3904 * termhooks.h (struct terminal): Likewise.
3905 * window.c (struct save_window_data, struct saved_window): Likewise.
3906 * window.h (struct window): Likewise.
3907 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3908 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3909 * buffer.c (init_buffer_once): Likewise.
3910 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3911 special case.
3912 * process.c (Fformat_network_address): Use local var for size,
3913 for brevity.
3914
3915 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3916
3917 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3918 * data.c (atof): Remove decl; no longer used or needed.
3919 (digit_to_number): Move to lread.c.
3920 (Fstring_to_number): Use new string_to_number function, to be
3921 consistent with how the Lisp reader treats infinities and NaNs.
3922 Do not assume that floating-point numbers represent EMACS_INT
3923 without losing information; this is not true on most 64-bit hosts.
3924 Avoid double-rounding errors, by insisting on integers when
3925 parsing non-base-10 numbers, as the documentation specifies.
3926 * lisp.h (string_to_number): New decl, replacing ...
3927 (isfloat_string): Remove.
3928 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3929 (read1): Do not accept +. and -. as integers; this
3930 appears to have been a coding error. Similarly, do not accept
3931 strings like +-1e0 as floating point numbers. Do not report
3932 overflow for integer overflows unless the base is not 10 which
3933 means we have no simple and reliable way to continue.
3934 Break out the floating-point parsing into a new
3935 function string_to_number, so that Fstring_to_number parses
3936 floating point numbers consistently with the Lisp reader.
3937 (digit_to_number): Move here from data.c. Make it static inline.
3938 (E_CHAR, EXP_INT): Remove, replacing with ...
3939 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3940 (string_to_number): New function, replacing isfloat_string.
3941 This function checks for valid syntax and produces the resulting
3942 Lisp float number too. Rework it so that string-to-number
3943 no longer mishandles examples like "1.0e+". Use strtoumax,
3944 so that overflow for non-base-10 numbers is reported only when
3945 there's no portable and simple way to convert to floating point.
3946
3947 * textprop.c (set_text_properties_1): Rewrite for clarity,
3948 and to avoid GCC warning about integer overflow.
3949
3950 * intervals.h (struct interval): Use EMACS_INT for members
3951 where EMACS_UINT might cause problems. See
3952 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3953 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3954 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3955 All uses changed.
3956 (offset_intervals): Tell GCC not to worry about length overflow
3957 when negating a negative length.
3958
3959 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3960 (overrun_check_free): Likewise.
3961
3962 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3963 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3964 word size.
3965
3966 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3967 (gnutls_make_error): Rename local to avoid shadowing.
3968 (gnutls_emacs_global_deinit): ifdef out; not used.
3969 (Fgnutls_boot): Use const for pointer to readonly storage.
3970 Comment out unused local. Fix pointer signedness problems.
3971
3972 * lread.c (openp): Don't stuff size_t into an 'int'.
3973 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3974 about possible signed overflow.
3975
3976 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3977 (GDK_KEY_g): Don't define if already defined.
3978 (xg_prepare_tooltip): Avoid pointer signedness problem.
3979 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3980
3981 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3982 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3983
3984 * xfns.c (Fx_window_property): Simplify a bit,
3985 to make a bit faster and to avoid GCC 4.6.0 warning.
3986 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3987
3988 * fns.c (internal_equal): Don't assume size_t fits in int.
3989
3990 * alloc.c (compact_small_strings): Tighten assertion a little.
3991
3992 Replace pEd with more-general pI, and fix some printf arg casts.
3993 * lisp.h (pI): New macro, generalizing old pEd macro to other
3994 conversion specifiers. For example, use "...%"pI"d..." rather
3995 than "...%"pEd"...".
3996 (pEd): Remove. All uses replaced with similar uses of pI.
3997 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3998 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3999 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4000 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4001 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4002 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4003 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4004 64-bit hosts.
4005 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4006 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4007 * print.c (safe_debug_print, print_object): Likewise.
4008 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4009 to int.
4010 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4011 avoiding the 0 flag, which is not portable.
4012 * process.c (Fmake_network_process): Use pI to avoid cast.
4013 * region-cache.c (pp_cache): Likewise.
4014 * xdisp.c (decode_mode_spec): Likewise.
4015 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4016 behavior on 64-bit hosts with printf arg.
4017 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4018 (x_stop_queuing_selection_requests): Likewise.
4019 (x_get_window_property): Don't truncate byte count to an 'int'
4020 when tracing.
4021
4022 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4023 here, since it parses constructs like leading '-' and spaces,
4024 which are not wanted; and it overflows with large numbers.
4025 Instead, simply match F[0-9]+, which is what is wanted anyway.
4026
4027 * alloc.c: Remove unportable assumptions about struct layout.
4028 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4029 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4030 (allocate_vectorlike, make_pure_vector): Use the new macros,
4031 plus offsetof, to remove unportable assumptions about struct layout.
4032 These assumptions hold on all porting targets that I know of, but
4033 they are not guaranteed, they're easy to remove, and removing them
4034 makes further changes easier.
4035
4036 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4037 This doesn't fix a bug but makes the code clearer.
4038 (string_overrun_cookie): Now const. Use initializers that
4039 don't formally overflow signed char, to avoid warnings.
4040 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4041 can cause Emacs to crash when string overrun checking is enabled.
4042 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4043 multiple of sizeof (EMACS_INT); it need not be, if
4044 alignof(EMACS_INT) < sizeof (EMACS_INT).
4045 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4046
4047 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4048
4049 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4050
4051 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4052
4053 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4054 supposed to be handshaking. (Bug#8556)
4055 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4056
4057 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4058
4059 * lisp.h (Qdebug): List symbol.
4060 * eval.c (Qdebug): Restore global linkage.
4061 * keyboard.c (debug-on-event): New variable.
4062 (handle_user_signal): Break into debugger when debug-on-event
4063 matches the current signal symbol.
4064
4065 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4066
4067 * alloc.c (check_sblock, check_string_bytes)
4068 (check_string_free_list): Convert to standard C.
4069
4070 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4071
4072 * w32.c (emacs_gnutls_push): Fix typo.
4073
4074 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4075
4076 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4077 "cast to pointer from integer of different size".
4078
4079 Improve doprnt and its use in verror. (Bug#8545)
4080 * doprnt.c (doprnt): Document the set of format control sequences
4081 supported by the function. Use SAFE_ALLOCA instead of always
4082 using `alloca'.
4083
4084 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4085 is one byte too soon. Don't use xrealloc; instead xfree and
4086 xmalloc anew.
4087
4088 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4089
4090 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4091 callbacks stage.
4092
4093 * gnutls.c: Renamed global_initialized to
4094 gnutls_global_initialized. Added internals for the
4095 :verify-hostname-error, :verify-error, and :verify-flags
4096 parameters of `gnutls-boot' and documented those parameters in the
4097 docstring. Start callback support.
4098 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4099 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4100 on error. Return error code.
4101 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4102 (emacs_gnutls_read): Likewise.
4103 (Fgnutls_boot): Return handshake error code.
4104 (emacs_gnutls_handle_error): New function.
4105 (wsaerror_to_errno): Likewise.
4106
4107 * w32.h (emacs_gnutls_pull): Add prototype.
4108 (emacs_gnutls_push): Likewise.
4109
4110 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4111 (emacs_gnutls_push): Likewise.
4112
4113 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4114
4115 * process.c (wait_reading_process_output): Check if GnuTLS
4116 buffered some data internally if no FDs are set for TLS
4117 connections.
4118
4119 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4120 (LIBS): Link to USER_LIBS.
4121 ($(BLD)/gnutls.$(0)): New target.
4122
4123 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4124
4125 * xdisp.c (handle_single_display_spec): Rename the
4126 display_replaced_before_p argument into display_replaced_p, to
4127 make it consistent with the commentary. Fix typos in the
4128 commentary.
4129
4130 * textprop.c (syms_of_textprop): Remove dead code.
4131 (copy_text_properties): Delete obsolete commentary about an
4132 interface that was deleted long ago. Fix typos in the description
4133 of arguments.
4134
4135 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4136 to changes in oldXMenu/XMenu.h from 2011-04-16.
4137 <menu_help_message, prev_menu_help_message>: Constify.
4138 (IT_menu_make_room): menu->help_text is now `const char **';
4139 adjust.
4140
4141 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4142 to changes in oldXMenu/XMenu.h from 2011-04-16.
4143 (struct XMenu): Declare `help_text' `const char **'.
4144
4145 * xfaces.c <Qunspecified>: Make extern again.
4146
4147 * syntax.c: Include sys/types.h before including regex.h, as
4148 required by Posix.
4149
4150 * doc.c (get_doc_string): Improve the format passed to `error'.
4151
4152 * doprnt.c (doprnt): Improve commentary.
4153
4154 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4155
4156 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4157 them with etags.
4158
4159 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4160 changes in globals.h immediately force recompilation.
4161 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4162 $(CURDIR)/s/ms-w32.h.
4163 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4164
4165 * character.c (Fchar_direction): Function deleted.
4166 (syms_of_character): Don't defsubr it.
4167 <char-direction-table>: Deleted.
4168
4169 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4170
4171 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4172 * doprnt.c: Include limits.h.
4173 (SIZE_MAX): New macro.
4174 (doprnt): Return a size_t value. 2nd arg is now size_t.
4175 Many local variables are now size_t instead of int or unsigned.
4176 Improve overflow protection. Support `l' modifier for integer
4177 conversions. Support %l conversion. Don't assume an EMACS_INT
4178 argument for integer conversions and for %c.
4179
4180 * lisp.h (doprnt): Restore prototype.
4181
4182 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4183 $(SRC)/character.h.
4184
4185 * Makefile.in (base_obj): Add back doprnt.o.
4186
4187 * deps.mk (doprnt.o): Add back prerequisites.
4188 (callint.o): Depend on character.h.
4189
4190 * eval.c (internal_lisp_condition_case): Include the handler
4191 representation in the error message.
4192 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4193 when breaking from the loop.
4194
4195 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4196
4197 * callint.c (Fcall_interactively): When displaying error message
4198 about invalid control letter, pass the character's codepoint, not
4199 a pointer to its multibyte form. Improve display of the character
4200 in octal and display also its hex code.
4201
4202 * character.c (char_string): Use %x to display the (unsigned)
4203 codepoint of an invalid character, to avoid displaying a bogus
4204 negative value.
4205
4206 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4207 `error', not SYMBOL_NAME itself.
4208
4209 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4210 character arguments to `error'.
4211
4212 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4213 to `error' in error message about FINAL_CHAR argument. Make sure
4214 FINAL_CHAR is a character, and use %c when it is passed as
4215 argument to `error'.
4216
4217 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4218
4219 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4220
4221 * w32.c: Include <time.h>.
4222 (sys_localtime): New function.
4223
4224 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4225
4226 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4227
4228 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4229
4230 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4231
4232 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4233 zombies (Bug#8467).
4234
4235 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4236
4237 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4238 gl_state.e_property when gl_state.object is Qt.
4239
4240 * insdel.c (make_gap_larger): Remove limitation of buffer size
4241 to <= INT_MAX.
4242
4243 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4244
4245 * xdisp.c (lookup_glyphless_char_display)
4246 (produce_glyphless_glyph): Handle cons cell entry in
4247 glyphless-char-display.
4248 (Vglyphless_char_display): Document it.
4249
4250 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4251 glyphless-char-display.
4252
4253 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4254
4255 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4256
4257 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4258
4259 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4260 definition for no-X builds.
4261
4262 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4263
4264 Static checks with GCC 4.6.0 and non-default toolkits.
4265
4266 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4267
4268 * process.c (keyboard_bit_set): Define only if SIGIO.
4269 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4270 (send_process): Repair possible setjmp clobbering.
4271
4272 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4273
4274 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4275
4276 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4277
4278 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4279 Define only if needed.
4280
4281 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4282 by pacifying GCC about it. Maybe it's time to retire it?
4283 * xfaces.c (USG, __TIMEVAL__): Likewise.
4284
4285 * dispextern.h (struct redisplay_interface): Rename param
4286 to avoid shadowing.
4287 * termhooks.h (struct terminal): Likewise.
4288 * xterm.c (xembed_send_message): Likewise.
4289
4290 * insdel.c (make_gap_smaller): Define only if
4291 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4292
4293 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4294 it.
4295
4296 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4297 so that we aren't warned about unused symbols.
4298
4299 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4300
4301 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4302
4303 * xfns.c (x_real_positions): Mark locals as initialized.
4304
4305 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4306
4307 * xterm.c: Fix problems found by static analysis with other toolkits.
4308 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4309 (x_dispatch_event): Declare static if USE_GTK, and
4310 define if USE_GTK || USE_X_TOOLKIT.
4311 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4312 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4313 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4314 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4315
4316 * xmenu.c (menu_help_callback): Pointer type fixes.
4317 Use const pointers when pointing at readonly data. Avoid pointer
4318 signedness clashes.
4319 (FALSE): Remove unused macro.
4320 (update_frame_menubar): Remove unused decl.
4321
4322 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4323
4324 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4325 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4326 (single_menu_item): Rename local to avoid shadowing.
4327
4328 * keyboard.c (make_lispy_event): Remove unused local var.
4329
4330 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4331 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4332
4333 * bitmaps: Change bitmaps from unsigned char back to the X11
4334 compatible char. Avoid the old compiler warnings about
4335 out-of-range initializers by using, for example, '\xab' rather
4336 than 0xab.
4337
4338 * xgselect.c (xgselect_initialize): Check vs interface
4339 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4340
4341 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4342
4343 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4344 to read-only memory.
4345
4346 * fns.c (vector): Remove; this old hack is no longer needed.
4347
4348 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4349 Remove unused var.
4350 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4351
4352 * xrdb.c (x_load_resources): Omit unused local.
4353
4354 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4355 (x_window): Rename locals to avoid shadowing.
4356 (USG): Use the kludged USG macro, to pacify gcc.
4357
4358 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4359 (x_term_init): Remove local to avoid shadowing.
4360
4361 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4362
4363 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4364 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4365
4366 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4367
4368 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4369
4370 Fix regex.c, syntax.c and friends for buffers > 2GB.
4371 * syntax.h (struct gl_state_s): Declare character position members
4372 EMACS_INT.
4373
4374 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4375
4376 * textprop.c (verify_interval_modification, interval_of):
4377 Declare arguments EMACS_INT.
4378
4379 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4380 EMACS_INT.
4381
4382 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4383
4384 * indent.c (Fvertical_motion): Local variable it_start is now
4385 EMACS_INT.
4386
4387 * regex.c (re_match, re_match_2, re_match_2_internal)
4388 (bcmp_translate, regcomp, regexec, print_double_string)
4389 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4390 (re_compile_pattern, re_exec): Declare arguments and local
4391 variables `size_t' and `ssize_t' and return values `regoff_t', as
4392 appropriate.
4393 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4394 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4395 <compile_stack_type>: `size' and `avail' are now `size_t'.
4396
4397 * regex.h <regoff_t>: Use ssize_t, not int.
4398 (re_search, re_search_2, re_match, re_match_2): Arguments that
4399 specify buffer/string position and length are now ssize_t and
4400 size_t. Return type is regoff_t.
4401
4402 2011-04-16 Ben Key <bkey76@gmail.com>
4403
4404 * nsfont.m: Fixed bugs in ns_get_family and
4405 ns_descriptor_to_entity that were caused by using free to
4406 deallocate memory blocks that were allocated by xmalloc (via
4407 xstrdup). This caused Emacs to crash when compiled with
4408 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4409 --enable-checking=xmallocoverrun). xfree is now used to
4410 deallocate these memory blocks.
4411
4412 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4413
4414 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4415
4416 emacs_write: Accept and return EMACS_INT for sizes.
4417 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4418 et seq.
4419 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4420 Accept and return EMACS_INT.
4421 (emacs_gnutls_write): Return the number of bytes written on
4422 partial writes.
4423 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4424 (emacs_read, emacs_write): Remove check for negative size, as the
4425 Emacs source code has been audited now.
4426 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4427 (emacs_read, emacs_write): Use it.
4428 * process.c (send_process): Adjust to the new signatures of
4429 emacs_write and emacs_gnutls_write. Do not attempt to store
4430 a byte offset into an 'int'; it might overflow.
4431 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4432
4433 * sound.c: Don't assume sizes fit in 'int'.
4434 (struct sound_device.period_size, alsa_period_size):
4435 Return EMACS_INT, not int.
4436 (struct sound_device.write, vox_write, alsa_write):
4437 Accept EMACS_INT, not int.
4438 (wav_play, au_play): Use EMACS_INT to store sizes and to
4439 record read return values.
4440
4441 2011-04-15 Ben Key <bkey76@gmail.com>
4442
4443 * keyboard.c (Qundefined): Don't declare static since it is used
4444 in nsfns.m.
4445 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4446 static since they are used in nsfont.m.
4447
4448 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4449
4450 * process.c (Qprocessp): Don't declare static.
4451 * lisp.h (Qprocessp): Declare again.
4452
4453 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4454
4455 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4456
4457 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4458
4459 Improve C-level modularity by making more things 'static'.
4460
4461 Don't publish debugger-only interfaces to other modules.
4462 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4463 (verify_bytepos, count_markers): Move decls to the only modules
4464 that need them.
4465 * region-cache.h (pp_cache): Likewise.
4466 * window.h (check_all_windows): Likewise.
4467 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4468
4469 * sysdep.c (croak): Now static, if
4470 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4471 * syssignal.h (croak): Declare only if not static.
4472
4473 * alloc.c (refill_memory_reserve): Now static if
4474 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4475 * lisp.h (refill_memory_reserve): Declare only if not static.
4476
4477 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4478 Define only if USE_LUCID.
4479
4480 * xrdb.c (x_customization_string, x_rm_string): Now static.
4481
4482 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4483 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4484
4485 * xdisp.c (draw_row_with_mouse_face): Now static.
4486 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4487
4488 * window.h (check_all_windows): Mark externally visible.
4489
4490 * window.c (window_deletion_count): Now static.
4491
4492 * undo.c: Make symbols static if they're not exported.
4493 (last_undo_buffer, last_boundary_position, pending_boundary):
4494 Now static.
4495
4496 * textprop.c (interval_insert_behind_hooks): Now static.
4497 (interval_insert_in_front_hooks): Likewise.
4498
4499 * term.c: Make symbols static if they're not exported.
4500 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4501 (max_frame_lines, tty_set_terminal_modes):
4502 (tty_reset_terminal_modes, tty_turn_off_highlight):
4503 (get_tty_terminal): Now static.
4504 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4505 * termhooks.h (term_mouse_moveto): Do not declare if
4506 HAVE_WINDOW_SYSTEM.
4507 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4508 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4509
4510 * sysdep.c: Make symbols static if they're not exported.
4511 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4512 Now static.
4513 (sigprocmask_set, full_mask): Remove; unused.
4514 (wait_debugging): Mark as visible.
4515 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4516 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4517
4518 * syntax.c (syntax_temp): Define only if !__GNUC__.
4519
4520 * sound.c (current_sound_device, current_sound): Now static.
4521
4522 * search.c (searchbufs, searchbuf_head): Now static.
4523
4524 * scroll.c (scroll_cost): Remove; unused.
4525 * dispextern.h (scroll_cost): Remove decl.
4526
4527 * region-cache.h (pp_cache): Mark as externally visible.
4528
4529 * process.c: Make symbols static if they're not exported.
4530 (process_tick, update_tick, create_process, chan_process):
4531 (Vprocess_alist, proc_buffered_char, datagram_access):
4532 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4533 (deactivate_process): Mark defn as static, as well as decl.
4534 * lisp.h (create_process): Remove decl.
4535 * process.h (chan_process, Vprocess_alist): Remove decls.
4536
4537 * print.c: Make symbols static if they're not exported.
4538 (print_depth, new_backquote_output, being_printed, print_buffer):
4539 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4540 (print_interval, print_number_index, initial_stderr_stream):
4541 Now static.
4542 * lisp.h (Fprinc): Remove decl.
4543 (debug_output_compilation_hack): Mark as externally visible.
4544
4545 * sysdep.c (croak): Move decl from here to syssignal.h.
4546 * syssignal.h (croak): Put it here, so the API can be checked when
4547 'croak' is called from dissociate_if_controlling_tty.
4548
4549 * minibuf.c: Make symbols static if they're not exported.
4550 (minibuf_save_list, choose_minibuf_frame): Now static.
4551 * lisp.h (choose_minibuf_frame): Remove decl.
4552
4553 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4554
4555 * lread.c: Make symbols static if they're not exported.
4556 (read_objects, initial_obarray, oblookup_last_bucket_number):
4557 Now static.
4558 (make_symbol): Remove; unused.
4559 * lisp.h (initial_obarray, make_symbol): Remove decls.
4560
4561 * keyboard.c: Make symbols static if they're not exported.
4562 (single_kboard, recent_keys_index, total_keys, recent_keys):
4563 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4564 (this_single_command_key_start, echoing, last_auto_save):
4565 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4566 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4567 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4568 (Vlispy_mouse_stem, double_click_count):
4569 Now static.
4570 (force_auto_save_soon): Define only if SIGDANGER.
4571 (ignore_mouse_drag_p): Now static if
4572 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4573 (print_help): Remove; unused.
4574 (stop_character, last_timer_event): Mark as externally visible.
4575 * keyboard.h (ignore_mouse_drag_p): Declare only if
4576 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4577 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4578 * lisp.h (echoing): Remove decl.
4579 (force_auto_save_soon): Declare only if SIGDANGER.
4580 * xdisp.c (redisplay_window): Simplify code, to make it more
4581 obvious that ignore_mouse_drag_p is not accessed if !defined
4582 USE_GTK && !defined HAVE_NS.
4583
4584 * intervals.c: Make symbols static if they're not exported.
4585 (merge_properties_sticky, merge_interval_right, delete_interval):
4586 Now static.
4587 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4588
4589 * insdel.c: Make symbols static if they're not exported.
4590 However, leave prepare_to_modify_buffer alone. It's never
4591 called from outside this function, but that appears to be a bug.
4592 (combine_after_change_list, combine_after_change_buffer):
4593 (adjust_after_replace, signal_before_change): Now static.
4594 (adjust_after_replace_noundo): Remove; unused.
4595 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4596 (signal_before_change): Remove decls.
4597
4598 * indent.c (val_compute_motion, val_vmotion): Now static.
4599
4600 * image.c: Make symbols static if they're not exported.
4601 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4602 if USE_GTK.
4603 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4604 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4605
4606 * fringe.c (standard_bitmaps): Now static.
4607 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4608
4609 * frame.c: Make symbols static if they're not exported.
4610 (x_report_frame_params, make_terminal_frame): Now static.
4611 (get_frame_param): Now static, unless HAVE_NS.
4612 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4613 (x_get_resource_string): Remove; not used.
4614 * frame.h (make_terminal_frame, x_report_frame_params):
4615 (x_get_resource_string); Remove decls.
4616 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4617 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4618
4619 * font.c, fontset.c: Make symbols static if they're not exported.
4620 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4621 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4622 * font.c (font_close_object): Now static.
4623 * font.h (font_close_object): Remove.
4624 * fontset.c (FONTSET_OBJLIST): Remove.
4625 (free_realized_fontset) #if-0 the body, which does nothing.
4626 (face_suitable_for_char_p): #if-0, as it's never called.
4627 * fontset.h (face_suitable_for_char_p): Remove decl.
4628 * xfaces.c (face_at_string_position):
4629 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4630 since 0 is always ASCII.
4631
4632 * fns.c (weak_hash_tables): Now static.
4633
4634 * fileio.c: Make symbols static if they're not exported.
4635 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4636 (Vwrite_region_annotation_buffers): Now static.
4637
4638 * eval.c: Make symbols static if they're not exported.
4639 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4640 * lisp.h (backtrace_list): Remove decl.
4641
4642 * emacs.c: Make symbols static if they're not exported.
4643 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4644 (fatal_error_code, fatal_error_signal_hook, standard_args):
4645 Now static.
4646 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4647 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4648 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4649 * lisp.h (fatal_error_signal_hook): Remove decl.
4650 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4651
4652 * editfns.c: Move a (normally-unused) function to its only use.
4653 * editfns.c, lisp.h (get_operating_system_release): Remove.
4654 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4655 worth the hassle of breaking this out.
4656
4657 * xterm.c: Make symbols static if they're not exported.
4658 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4659 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4660 (x_destroy_window, x_delete_display):
4661 Now static.
4662 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4663 (x_mouse_leave): Remove; unused.
4664 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4665 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4666 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4667 Remove decls.
4668 (x_mouse_leave): Declare only if WINDOWSNT.
4669 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4670 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4671 USE_X_TOOLKIT.
4672
4673 * ftxfont.c: Make symbols static if they're not exported.
4674 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4675 HAVE_FREETYPE.
4676 * font.h (ftxfont_driver): Likewise.
4677
4678 * xfns.c: Make symbols static if they're not exported.
4679 (x_last_font_name, x_display_info_for_name):
4680 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4681 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4682 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4683 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4684 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4685 (last_show_tip_args): Now static.
4686 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4687 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4688 (x_screen_planes): Remove; unused.
4689 * dispextern.h (x_screen_planes): Remove decl.
4690
4691 * dispnew.c: Make symbols static if they're not exported.
4692 * dispextern.h (redraw_garbaged_frames, scrolling):
4693 (increment_row_positions): Remove.
4694 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4695 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4696 Now static.
4697 (redraw_garbaged_frames): Remove; unused.
4698
4699 * xfaces.c: Make symbols static if they're not exported.
4700 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4701 Remove decls.
4702 * xterm.h (defined_color): Remove decls.
4703 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4704 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4705 (menu_face_changed_default, defined_color, free_realized_face):
4706 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4707 (ascii_face_of_lisp_face): Remove; unused.
4708
4709 * xdisp.c: Make symbols static if they're not exported.
4710 * dispextern.h (scratch_glyph_row, window_box_edges):
4711 (glyph_to_pixel_coords, set_cursor_from_row):
4712 (get_next_display_element, set_iterator_to_next):
4713 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4714 (show_mouse_face): Remove decls
4715 * frame.h (message_buf_print): Likewise.
4716 * lisp.h (pop_message, set_message, check_point_in_composition):
4717 Likewise.
4718 * xterm.h (set_vertical_scroll_bar): Likewise.
4719 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4720 (message_buf_print, scratch_glyph_row, displayed_buffer):
4721 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4722 (get_next_display_element, show_mouse_face, window_box_edges):
4723 (frame_to_window_pixel_xy, check_point_in_composition):
4724 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4725 (glyph_to_pixel_coords): Remove; unused.
4726
4727 * dired.c (file_name_completion): Now static.
4728
4729 * dbusbind.c (xd_in_read_queued_messages): Now static.
4730
4731 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4732 * data.c (circular_list_error): Remove.
4733
4734 * commands.h (last_point_position, last_point_position_buffer):
4735 (last_point_position_window): Remove decls.
4736 * keyboard.c: Make these variables static.
4737
4738 * coding.h (coding, code_convert_region, encode_coding_gap):
4739 Remove decls.
4740 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4741 (iso_code_class, detect_coding, code_convert_region): Now static.
4742 (encode_coding_gap): Remove; unused.
4743
4744 * chartab.c (chartab_chars, chartab_bits): Now static.
4745
4746 * charset.h (charset_iso_8859_1): Remove decl.
4747 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4748 Now static.
4749
4750 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4751 * ccl.c (Vccl_program_table): Now static.
4752 (check_ccl_update): Remove; unused.
4753
4754 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4755 * category.h: ... from here.
4756 * category.c (check_category_table, set_category_set): Now static.
4757
4758 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4759 * lisp.h: Remove these decls.
4760
4761 * buffer.c (buffer_count): Remove unused var.
4762
4763 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4764 so that it's not optimized away.
4765 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4766 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4767 exported only to the debugger.
4768
4769 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4770 * atimer.h (run_all_atimers): Remove; not exported.
4771
4772 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4773 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4774 was inaccessible from Lisp.
4775 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4776 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4777
4778 alloc.c: Import and export fewer symbols, and remove unused items.
4779 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4780 is defined.
4781 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4782 it's not optimized away by whole-program optimization.
4783 (message_enable_multibyte, free_misc): Remove.
4784 (catchlist, handlerlist, mark_backtrace):
4785 Declare only if BYTE_MARK_STACK.
4786 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4787 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4788 (message_enable_multibyte): Remove decl.
4789 (free_misc, interval_free_list, float_block, float_block_index):
4790 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4791 (cons_free_list, last_marked_index):
4792 Now static.
4793 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4794 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4795 (mark_backtrace): Define only if BYTE_MARK_STACK.
4796 * xdisp.c (message_enable_multibyte): Now static.
4797
4798 Declare Lisp_Object Q* variables to be 'static' if not exported.
4799 This makes it easier for human readers (and static analyzers)
4800 to see whether these variables are used from other modules.
4801 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4802 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4803 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4804 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4805 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4806 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4807 * xmenu.c, xselect.c:
4808 Declare Q* vars static if they are not used in other modules.
4809 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4810 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4811 Remove decls of unexported vars.
4812 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4813
4814 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4815
4816 Make Emacs functions such as Fatom 'static' by default.
4817 This makes it easier for human readers (and static analyzers)
4818 to see whether these functions can be called from other modules.
4819 DEFUN now defines a static function. To make the function external
4820 so that it can be used in other C modules, use the new macro DEFUE.
4821 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4822 (Finit_image_library):
4823 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4824 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4825 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4826 Remove decls, since these functions are now static.
4827 (Funintern, Fget_internal_run_time): New decls, since these functions
4828 were already external.
4829
4830 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4831 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4832 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4833 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4834 * keyboard.c, keymap.c, lread.c:
4835 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4836 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4837 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4838 Mark functions with DEFUE instead of DEFUN,
4839 if they are used in other modules.
4840 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4841 decls for now-static functions.
4842 * buffer.h (Fdelete_overlay): Remove decl.
4843 * callproc.c (Fgetenv_internal): Mark as internal.
4844 * composite.c (Fremove_list_of_text_properties): Remove decl.
4845 (Fcomposition_get_gstring): New forward static decl.
4846 * composite.h (Fcomposite_get_gstring): Remove decl.
4847 * dired.c (Ffile_attributes): New forward static decl.
4848 * doc.c (Fdocumntation_property): New forward static decl.
4849 * eval.c (Ffetch_bytecode): New forward static decl.
4850 (Funintern): Remove extern decl; now in .h file where it belongs.
4851 * fileio.c (Fmake_symbolic_link): New forward static decl.
4852 * image.c (Finit_image_library): New forward static decl.
4853 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4854 * intervals.h (Fprevious_property_change):
4855 (Fremove_list_of_text_properties): Remove decls.
4856 * keyboard.c (Fthis_command_keys): Remove decl.
4857 (Fcommand_execute): New forward static decl.
4858 * keymap.c (Flookup_key): New forward static decl.
4859 (Fcopy_keymap): Now static.
4860 * keymap.h (Flookup_key): Remove decl.
4861 * process.c (Fget_process): New forward static decl.
4862 (Fprocess_datagram_address): Mark as internal.
4863 * syntax.c (Fsyntax_table_p): New forward static decl.
4864 (skip_chars): Remove duplicate decl.
4865 * textprop.c (Fprevious_property_change): New forward static decl.
4866 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4867 Now internal.
4868 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4869 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4870
4871 * editfns.c (Fformat): Remove unreachable code.
4872
4873 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4874
4875 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4876 change. (Bug#8496)
4877
4878 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4879
4880 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4881 when at ZV. (Bug#8487)
4882
4883 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4884
4885 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4886 (Bug#8437)
4887 * keyboard.c (parse_tool_bar_item): Likewise.
4888 * sound.c (sound_cleanup, alsa_close): Likewise.
4889 * termcap.c (tgetent): Likewise.
4890 * xfns.c (x_default_font_parameter): Likewise.
4891 * xsettings.c (read_and_apply_settings): Likewise.
4892
4893 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4894 (overrun_check_free): Protoize.
4895
4896 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4897
4898 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4899 since callers should never pass a negative size.
4900 Change the signature to match that of plain 'read' and 'write'; see
4901 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4902 * lisp.h: Update prototypes of emacs_write and emacs_read.
4903
4904 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4905
4906 * xdisp.c (redisplay_window): Don't try to determine the character
4907 position of the scroll margin if the window start point w->startp
4908 is outside the buffer's accessible region. (Bug#8468)
4909
4910 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4911
4912 Fix write-region and its subroutines for buffers > 2GB.
4913 * fileio.c (a_write, e_write): Modify declaration of arguments and
4914 local variables to support buffers larger than 2GB.
4915 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4916
4917 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4918 argument, local variables, and return value.
4919
4920 * lisp.h: Update prototypes of emacs_write and emacs_read.
4921
4922 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4923
4924 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4925
4926 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4927
4928 Fix more problems found by GCC 4.6.0's static checks.
4929
4930 * xdisp.c (vmessage): Use a better test for character truncation.
4931
4932 * charset.c (load_charset_map): <, not <=, for optimization,
4933 and to avoid potential problems with integer overflow.
4934 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4935 * casetab.c (set_identity, shuffle): Likewise.
4936 * editfns.c (Fformat): Likewise.
4937 * syntax.c (skip_chars): Likewise.
4938
4939 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4940 This also lets GCC 4.6.0 generate slightly better loop code.
4941
4942 * callint.c (Fcall_interactively): <, not <=, for optimization.
4943 (Fcall_interactively): Count the number of arguments produced,
4944 not the number of arguments given. This is simpler and lets GCC
4945 4.6.0 generate slightly better code.
4946
4947 * ftfont.c: Distingish more carefully between FcChar8 and char.
4948 The previous code passed unsigned char * to a functions like
4949 strlen and xstrcasecmp that expect char *, which does not
4950 conform to the C standard.
4951 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4952 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4953 char * when the C standard requires it.
4954
4955 * keyboard.c (read_char): Remove unused var.
4956
4957 * eval.c: Port to Windows vsnprintf (Bug#8435).
4958 Include <limits.h>.
4959 (SIZE_MAX): Define if the headers do not.
4960 (verror): Do not give up if vsnprintf returns a negative count.
4961 Instead, grow the buffer. This ports to Windows vsnprintf, which
4962 does not conform to C99. Problem reported by Eli Zaretskii.
4963 Also, simplify the allocation scheme, by avoiding the need for
4964 calling realloc, and removing the ALLOCATED variable.
4965
4966 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4967
4968 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4969 But keep the doprint source code for now, as we might revamp it
4970 and use it again (Bug#8435).
4971 * lisp.h (doprnt): Remove.
4972 * Makefile.in (base_obj): Remove doprnt.o.
4973 * deps.mk (doprnt.o): Remove.
4974
4975 error: Print 32- and 64-bit integers portably (Bug#8435).
4976 Without this change, on typical 64-bit hosts error ("...%d...", N)
4977 was used to print both 32- and 64-bit integers N, which relied on
4978 undefined behavior.
4979 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4980 New macro.
4981 * lisp.h (error, verror): Mark as printf-like functions.
4982 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4983 Report overflow in size calculations when allocating printf buffer.
4984 Do not truncate output string at its first null byte.
4985 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4986 Truncate the output at a character boundary, since vsnprintf does not
4987 do that.
4988 * charset.c (check_iso_charset_parameter): Convert internal
4989 character to string before calling 'error', since %c now has the
4990 printf meaning.
4991 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4992 overflow when computing char to be passed to 'error'. Do not
4993 pass Lisp_Object to 'error'; pass the integer instead.
4994 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4995 formatted with plain %d.
4996
4997 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4998
4999 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5000
5001 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5002
5003 * xterm.c (x_catch_errors): Remove duplicate declaration.
5004
5005 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5006
5007 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5008
5009 2011-04-10 Jim Meyering <meyering@redhat.com>
5010
5011 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5012 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5013 return ssize_t not "int", and use size_t as the buffer length.
5014 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5015 * gnutls.h: Update declarations.
5016 * process.c (read_process_output): Use ssize_t, to match.
5017 (send_process): Likewise.
5018
5019 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5020
5021 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5022
5023 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5024
5025 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5026 Use unsigned char, to match FcChar8 type definition.
5027
5028 * xterm.c (handle_one_xevent):
5029 * xmenu.c (create_and_show_popup_menu):
5030 * xselect.c (x_decline_selection_request)
5031 (x_reply_selection_request): Avoid type-punned deref of X events.
5032
5033 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5034
5035 Fix some uses of `int' instead of EMACS_INT.
5036 * search.c (string_match_1, fast_string_match)
5037 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5038 (scan_buffer, find_next_newline_no_quit)
5039 (find_before_next_newline, search_command, Freplace_match)
5040 (Fmatch_data): Make some `int' variables be EMACS_INT.
5041
5042 * xdisp.c (display_count_lines): 3rd argument and return value now
5043 EMACS_INT. All callers changed.
5044 (pint2hrstr): Last argument is now EMACS_INT.
5045
5046 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5047 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5048 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5049 (decode_coding_utf_16, decode_coding_emacs_mule)
5050 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5051 (decode_coding_ccl, decode_coding_charset)
5052 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5053 (decode_coding_iso_2022, decode_coding_emacs_mule)
5054 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5055 <char_offset, last_offset>: Declare EMACS_INT.
5056 (encode_coding_utf_8, encode_coding_utf_16)
5057 (encode_coding_emacs_mule, encode_invocation_designation)
5058 (encode_designation_at_bol, encode_coding_iso_2022)
5059 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5060 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5061 Declare EMACS_INT.
5062 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5063 (encode_invocation_designation): Last argument P_NCHARS is now
5064 EMACS_INT.
5065 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5066 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5067
5068 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5069 All users changed.
5070
5071 * ccl.c (Fccl_execute_on_string): Declare some variables
5072 EMACS_INT.
5073
5074 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5075
5076 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5077
5078 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5079
5080 * process.c (Fformat_network_address): Doc fix.
5081
5082 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5083
5084 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5085
5086 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5087
5088 * keyboard.c (read_char): Call Lisp function help-form-show,
5089 instead of using internal_with_output_to_temp_buffer.
5090 (Qhelp_form_show): New var.
5091 (syms_of_keyboard): Use DEFSYM macro.
5092
5093 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5094
5095 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5096
5097 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5098
5099 * process.c (Flist_processes): Remove to Lisp.
5100 (list_processes_1): Delete.
5101
5102 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5103
5104 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5105
5106 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5107
5108 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5109
5110 Fix more problems found by GCC 4.6.0's static checks.
5111
5112 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5113
5114 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5115
5116 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5117
5118 * xdisp.c (vmessage): Mark as a printf-like function.
5119
5120 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5121
5122 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5123
5124 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5125 printf-like functions.
5126 (tiff_load): Add casts to remove these marks before passing them
5127 to system-supplied API.
5128
5129 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5130
5131 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5132 This avoids several warnings with gcc -Wstrict-overflow.
5133 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5134 directly, rather than having caller test rule sign. This avoids
5135 some unnecessary tests.
5136 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5137 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5138 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5139
5140 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5141 (xfont_open): Avoid unnecessary tests.
5142
5143 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5144
5145 * composite.h, composite.c (composition_gstring_put_cache):
5146 Use EMACS_INT, not int, for length.
5147
5148 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5149 breaking out part of COMPOSITION_DECODE_RULE.
5150 (COMPOSITION_DECODE_RULE): Use it.
5151 * composite.c (get_composition_id): Remove unused local vars,
5152 by using the new macro.
5153
5154 * textprop.c (set_text_properties_1): Change while to do-while,
5155 since the condition is always true at first.
5156
5157 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5158 (interval_deletion_adjustment): Return unsigned value.
5159 All uses changed.
5160
5161 * process.c (list_processes_1, create_pty, read_process_output):
5162 (exec_sentinel): Remove vars that were set but not used.
5163 (create_pty): Remove unnecessary "volatile"s.
5164 (Fnetwork_interface_info): Avoid possibility of int overflow.
5165 (read_process_output): Do adaptive read buffering even if carryover.
5166 (read_process_output): Simplify nbytes computation if buffered.
5167
5168 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5169
5170 * syntax.c (scan_words): Remove var that was set but not used.
5171 (update_syntax_table): Use unsigned instead of int.
5172
5173 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5174 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5175 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5176
5177 * print.c (print_error_message): Avoid int overflow.
5178
5179 * font.c (font_list_entities): Redo for clarity,
5180 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5181
5182 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5183 (font_score): Avoid potential overflow in diff calculation.
5184
5185 * fns.c (substring_both): Remove var that is set but not used.
5186 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5187
5188 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5189
5190 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5191 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5192 can always succeed if overflow has undefined behavior.
5193
5194 * search.c (boyer_moore, wordify): Remove vars set but not used.
5195 (wordify): Omit three unnecessary tests.
5196
5197 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5198 All callers changed. This avoids the need for an unused var.
5199
5200 * casefiddle.c (casify_region): Remove var that is set but not used.
5201
5202 * dired.c (file_name_completion): Remove var that is set but not used.
5203
5204 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5205
5206 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5207 (Finsert_file_contents): Remove unnecessary code checking fd.
5208
5209 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5210 Check for integer overflow on size calculations.
5211
5212 * buffer.c (Fprevious_overlay_change): Remove var that is set
5213 but not used.
5214
5215 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5216 Remove vars that are set but not used.
5217 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5218 (timer_check_2): Mark vars as initialized.
5219
5220 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5221
5222 * image.c (lookup_image): Remove var that is set but not used.
5223 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5224
5225 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5226 that are set but not used.
5227
5228 * xfns.c (make_invisible_cursor): Don't return garbage
5229 if XCreateBitmapFromData fails (Bug#8410).
5230
5231 * xselect.c (x_get_local_selection, x_handle_property_notify):
5232 Remove vars that are set but not used.
5233
5234 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5235 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5236
5237 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5238 Remove var that is set but not used.
5239 (scroll_bar_windows_size): Now size_t, not int.
5240 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5241 Check for overflow.
5242
5243 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5244 (map_tty_color) [!defined MSDOS]: Likewise.
5245
5246 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5247
5248 * coding.c: Remove vars that are set but not used.
5249 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5250 All callers changed.
5251 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5252 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5253 (decode_coding_charset): Remove vars that are set but not used.
5254
5255 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5256 that is set but not used.
5257
5258 * print.c (print_object): Remove var that is set but not used.
5259
5260 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5261 The gnulib version avoids calling malloc in the usual case,
5262 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5263 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5264 * filelock.c (current_lock_owner): Likewise.
5265 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5266 * sysdep.c: Include allocator.h, careadlinkat.h.
5267 (emacs_no_realloc_allocator): New static constant.
5268 (emacs_readlink): New function.
5269 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5270 ../lib/careadlinkat.h.
5271
5272 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5273
5274 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5275 first non-nil return value).
5276
5277 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5278
5279 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5280 if not defined (Bug#8403).
5281
5282 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5283
5284 * xdisp.c (display_count_lines): Remove parameter `start',
5285 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5286 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5287 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5288 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5289 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5290 and thereabouts. All callers changed.
5291 (get_per_char_metric): Remove parameter `f', unused since
5292 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5293
5294 2011-04-02 Jim Meyering <meyering@redhat.com>
5295
5296 do not dereference NULL upon failed strdup
5297 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5298 (ns_get_family): Likewise.
5299
5300 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5301
5302 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5303
5304 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5305
5306 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5307 later (Bug#8403).
5308
5309 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5310
5311 Add lexical binding.
5312
5313 * window.c (Ftemp_output_buffer_show): New fun.
5314 (Fsave_window_excursion):
5315 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5316
5317 * lread.c (lisp_file_lexically_bound_p): New function.
5318 (Fload): Bind Qlexical_binding.
5319 (readevalloop): Remove `evalfun' arg.
5320 Bind Qinternal_interpreter_environment.
5321 (Feval_buffer): Bind Qlexical_binding.
5322 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5323 Mark as dynamic.
5324 (syms_of_lread): Declare `lexical-binding'.
5325
5326 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5327
5328 * keyboard.c (eval_dyn): New fun.
5329 (menu_item_eval_property): Use it.
5330
5331 * image.c (parse_image_spec): Use Ffunctionp.
5332
5333 * fns.c (concat, mapcar1): Accept byte-code-functions.
5334
5335 * eval.c (Fsetq): Handle lexical vars.
5336 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5337 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5338 (FletX, Flet): Obey lexical binding.
5339 (Fcommandp): Handle closures.
5340 (Feval): New `lexical' arg.
5341 (eval_sub): New function extracted from Feval. Use it almost
5342 everywhere where Feval was used. Look up vars in lexical env.
5343 Handle closures.
5344 (Ffunctionp): Move from subr.el.
5345 (Ffuncall): Handle closures.
5346 (apply_lambda): Remove `eval_flags'.
5347 (funcall_lambda): Handle closures and new byte-code-functions.
5348 (Fspecial_variable_p): New function.
5349 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5350 but without exporting it to Lisp.
5351
5352 * doc.c (Fdocumentation, store_function_docstring):
5353 * data.c (Finteractive_form): Handle closures.
5354
5355 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5356 interactive spec.
5357
5358 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5359 New byte-codes.
5360 (exec_byte_code): New function extracted from Fbyte_code to handle new
5361 calling convention for byte-code-functions. Add new byte-codes.
5362
5363 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5364
5365 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5366
5367 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5368
5369 * xdisp.c (redisplay_internal): Fix prototype.
5370
5371 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5372
5373 * xdisp.c (SCROLL_LIMIT): New macro.
5374 (try_scrolling): Use it when setting scroll_limit.
5375 Limit scrolling to 100 screen lines.
5376 (redisplay_window): Even when falling back on "recentering",
5377 position point in the window according to scroll-conservatively,
5378 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5379
5380 (try_scrolling): When point is above the window, allow searching
5381 as far as scroll_max, or one screenful, to compute vertical
5382 distance from PT to the scroll margin position. This prevents
5383 try_scrolling from unnecessarily failing when
5384 scroll-conservatively is set to a value slightly larger than the
5385 window height. Clean up the case of PT below the margin at bottom
5386 of window: scroll_max can no longer be INT_MAX. When aggressive
5387 scrolling is in use, don't let point enter the opposite scroll
5388 margin as result of the scroll.
5389 (syms_of_xdisp) <scroll-conservatively>: Document the
5390 threshold of 100 lines for never-recentering scrolling.
5391
5392 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5393
5394 * dispextern.h (move_it_by_lines):
5395 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5396 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5397 (message_log_check_duplicate): Remove parameters `prev_bol' and
5398 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5399 (redisplay_internal): Remove parameter `preserve_echo_area',
5400 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5401
5402 * indent.c (Fvertical_motion):
5403 * window.c (window_scroll_pixel_based, Frecenter):
5404 Don't pass `need_y_p' to `move_it_by_lines'.
5405
5406 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5407
5408 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5409 steal a few bits to be more compact.
5410 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5411 Remove unneeded casts.
5412
5413 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5414
5415 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5416
5417 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5418 binding" message (bug#7967).
5419
5420 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5421
5422 Fix more problems found by GCC 4.6.0's static checks.
5423
5424 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5425 Remove unused local var.
5426
5427 * editfns.c (Fmessage_box): Remove unused local var.
5428
5429 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5430 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5431 Omit unused local vars.
5432 * window.c (shrink_windows): Omit unused local var.
5433 * menu.c (digest_single_submenu): Omit unused local var.
5434 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5435 Omit unused local var.
5436
5437 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5438 Don't assume string length fits in int.
5439 (keyremap_step, read_key_sequence): Use size_t for sizes.
5440 (read_key_sequence): Don't check last_real_key_start redundantly.
5441
5442 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5443 instead of alloca (Bug#8344).
5444
5445 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5446 (Fbacktrace_frame): Don't assume nframes fits in int.
5447
5448 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5449
5450 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5451 concerns.
5452
5453 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5454
5455 * cm.c (calccost): Turn while-do into do-while, for clarity.
5456
5457 * keyboard.c (syms_of_keyboard): Use the same style as later
5458 in this function when indexing through an array. This also
5459 works around GCC bug 48267.
5460
5461 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5462
5463 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5464
5465 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5466 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5467
5468 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5469 This avoids undefined behavior on integer overflow, and is a bit
5470 more convenient anyway since it is compared to a size_t variable.
5471
5472 Variadic C functions now count arguments with size_t, not int.
5473 This avoids an unnecessary limitation on 64-bit machines, which
5474 caused (substring ...) to crash on large vectors (Bug#8344).
5475 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5476 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5477 All variadic functions and their callers changed accordingly.
5478 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5479 * data.c (arith_driver, float_arith_driver): Likewise.
5480 * editfns.c (general_insert_function): Likewise.
5481 * eval.c (struct backtrace.nargs, interactive_p)
5482 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5483 (funcall_lambda, mark_backtrace): Likewise.
5484 * fns.c (concat): Likewise.
5485 * frame.c (x_set_frame_parameters): Likewise.
5486 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5487 0 if not found, not -1. All callers changed.
5488
5489 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5490 (stack_copy_size): Now size_t, not int.
5491 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5492
5493 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5494
5495 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5496 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5497 All callers changed.
5498
5499 * lisp.h (multibyte_char_to_unibyte):
5500 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5501 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5502 * character.h (CHAR_TO_BYTE8):
5503 * cmds.c (internal_self_insert):
5504 * editfns.c (general_insert_function):
5505 * keymap.c (push_key_description):
5506 * search.c (Freplace_match):
5507 * xdisp.c (message_dolog, set_message_1): All callers changed.
5508
5509 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5510
5511 * keyboard.c (safe_run_hook_funcall): New function.
5512 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5513 don't set the hook to nil, but remove the offending function instead.
5514 (Qcommand_hook_internal): Remove, unused.
5515 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5516 Vcommand_hook_internal.
5517
5518 * eval.c (enum run_hooks_condition): Remove.
5519 (funcall_nil, funcall_not): New functions.
5520 (run_hook_with_args): Call each function through a `funcall' argument.
5521 Remove `cond' argument, now redundant.
5522 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5523 (Frun_hook_with_args_until_failure): Adjust accordingly.
5524 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5525
5526 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5527
5528 * dispextern.h (string_buffer_position): Remove declaration.
5529
5530 * print.c (strout): Remove parameter `multibyte', unused since
5531 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5532
5533 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5534 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5535 All callers changed.
5536
5537 * w32.c (_wsa_errlist): Use braces for struct initializers.
5538
5539 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5540 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5541 All callers changed.
5542 (string_buffer_position): Likewise. Also, make static (it's never
5543 used outside xdisp.c).
5544 (cursor_row_p): Remove parameter `w', unused since
5545 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5546 (decode_mode_spec): Remove parameter `precision', introduced during
5547 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5548 All callers changed.
5549
5550 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5551
5552 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5553
5554 2011-03-27 Anders Lindgren <andlind@gmail.com>
5555
5556 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5557 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5558 (ns_update_auto_hide_menu_bar): New functions.
5559 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5560 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5561 ns_constrain_all_frames.
5562 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5563 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5564
5565 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5566
5567 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5568
5569 2011-03-27 Glenn Morris <rgm@gnu.org>
5570
5571 * syssignal.h: Replace RETSIGTYPE with void.
5572 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5573 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5574 Replace SIGTYPE with void everywhere.
5575 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5576 * s/template.h (SIGTYPE): Remove commented out definition.
5577
5578 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5579
5580 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5581 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5582
5583 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5584
5585 * w32.c (read_unc_volume): Use parameter `henum', instead of
5586 global variable `wget_enum_handle'.
5587
5588 * keymap.c (describe_vector): Remove parameters `indices' and
5589 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5590 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5591
5592 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5593
5594 * keyboard.c (timer_check): Remove parameter `do_it_now',
5595 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5596 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5597 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5598
5599 * keyboard.c (read_char):
5600 * w32menu.c (w32_menu_display_help):
5601 * xmenu.c (show_help_event, menu_help_callback):
5602 Adjust calls to `show_help_echo'.
5603
5604 * gtkutil.c (xg_maybe_add_timer):
5605 * keyboard.c (readable_events):
5606 * process.c (wait_reading_process_output):
5607 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5608
5609 * insdel.c (adjust_markers_gap_motion):
5610 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5611 (gap_left, gap_right): Don't call it.
5612
5613 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5614
5615 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5616 incurred during fontification.
5617
5618 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5619
5620 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5621 (DEFVAR_PER_BUFFER): Don't pass it.
5622
5623 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5624 (scrolling_window): Don't pass it.
5625
5626 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5627
5628 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5629
5630 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5631 and `suffix'.
5632 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5633 of variables specific to SELinux and computation of `encoded_absname'.
5634
5635 * image.c (XPutPixel): Remove unused variable `height'.
5636
5637 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5638
5639 * unexw32.c (get_section_info): Remove unused variable `section'.
5640
5641 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5642 (system_process_attributes): Remove unused variable `sess'.
5643 (sys_read): Remove unused variable `err'.
5644
5645 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5646 (w32_wnd_proc): Remove unused variable `isdead'.
5647 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5648 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5649 (x_create_tip_frame): Remove unused variable `tem'.
5650
5651 * w32inevt.c (w32_console_read_socket):
5652 Remove unused variable `no_events'.
5653
5654 * w32term.c (x_draw_composite_glyph_string_foreground):
5655 Remove unused variable `width'.
5656
5657 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5658
5659 * w32term.c (x_set_glyph_string_clipping):
5660 Don't pass uninitialized region to CombineRgn.
5661
5662 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5663
5664 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5665 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5666 (Fx_close_connection): Remove unused variable `i'.
5667
5668 * w32font.c (w32font_draw): Return number of glyphs.
5669 (w32font_open_internal): Remove unused variable `i'.
5670 (w32font_driver): Add missing initializer.
5671
5672 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5673 (fill_in_menu): Remove unused variable `items_added'.
5674
5675 * w32term.c (last_mouse_press_frame): Remove static global variable.
5676 (w32_clip_to_row): Remove unused variable `f'.
5677 (x_delete_terminal): Remove unused variable `i'.
5678
5679 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5680 (NOTHING): Remove unused static global variable.
5681 (uniscribe_check_otf): Remove unused variable `table'.
5682 (uniscribe_font_driver): Add missing initializers.
5683
5684 2011-03-23 Julien Danjou <julien@danjou.info>
5685
5686 * term.c (Fsuspend_tty, Fresume_tty):
5687 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5688 * window.c (temp_output_buffer_show):
5689 * insdel.c (signal_before_change):
5690 * frame.c (Fhandle_switch_frame):
5691 * fileio.c (Fdo_auto_save):
5692 * emacs.c (Fkill_emacs):
5693 * editfns.c (save_excursion_restore):
5694 * cmds.c (internal_self_insert):
5695 * callint.c (Fcall_interactively):
5696 * buffer.c (Fkill_all_local_variables):
5697 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5698 Use Frun_hooks.
5699 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5700 unconditionnaly since it does the check itself.
5701
5702 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5703
5704 Fix more problems found by GCC 4.5.2's static checks.
5705
5706 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5707 the first time through the loop, since we know p0 < p1 then.
5708 This also avoids a gcc -Wstrict-overflow warning.
5709
5710 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5711 leading to a memory leak, possible in functions like
5712 load_charset_map_from_file that can allocate an unbounded number
5713 of objects (Bug#8318).
5714
5715 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5716 that could (at least in theory) be that large.
5717
5718 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5719 This is less likely to overflow, and avoids undefined behavior if
5720 overflow does occur. All callers changed. Use strtoul to scan
5721 for the unsigned long integer.
5722 (pint2hrstr): Simplify and tune code slightly.
5723 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5724
5725 * scroll.c (do_scrolling): Work around GCC bug 48228.
5726 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5727
5728 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5729 This also avoids a warning with gcc -Wstrict-overflow.
5730 (validate_x_resource_name): Simplify count usage.
5731 This also avoids a warning with gcc -Wstrict-overflow.
5732
5733 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5734 fail (Bug#8306).
5735
5736 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5737
5738 * process.c (Fmake_network_process): Use socklen_t, not int,
5739 where POSIX says socklen_t is required in portable programs.
5740 This fixes a porting bug on hosts like 64-bit HP-UX, where
5741 socklen_t is wider than int (Bug#8277).
5742 (Fmake_network_process, server_accept_connection):
5743 (wait_reading_process_output, read_process_output):
5744 Likewise.
5745
5746 * process.c: Rename or move locals to avoid shadowing.
5747 (list_processes_1, Fmake_network_process):
5748 (read_process_output_error_handler, exec_sentinel_error_handler):
5749 Rename or move locals.
5750 (Fmake_network_process): Define label "retry_connect" only if needed.
5751 (Fnetwork_interface_info): Fix pointer signedness.
5752 (process_send_signal): Add cast to avoid pointer signedness problem.
5753 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5754 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5755
5756 Make tparam.h and terminfo.c consistent.
5757 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5758 Include tparam.h instead, since it declares them.
5759 * cm.h (PC): Remove extern decl; tparam.h now does this.
5760 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5761 * terminfo.c: Include tparam.h, to check interfaces.
5762 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5763 (tparam): Adjust signature to match interface in tparam.h;
5764 this removes some undefined behavior. Check that outstring and len
5765 are zero, which they always are with Emacs.
5766 * tparam.h (PC, BC, UP): New extern decls.
5767
5768 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5769 (xftfont_open): Rename locals to avoid shadowing.
5770
5771 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5772 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5773 (OTF_TAG_SYM): Omit macro if not needed.
5774 (ftfont_list): Remove unused local.
5775 (get_adstyle_property, ftfont_pattern_entity):
5776 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5777 Rename locals to avoid shadowing.
5778
5779 * xfont.c (xfont_list_family): Mark var as initialized.
5780
5781 * xml.c (make_dom): Now static.
5782
5783 * composite.c (composition_compute_stop_pos): Rename local to
5784 avoid shadowing.
5785 (composition_reseat_it): Remove unused locals.
5786 (find_automatic_composition, composition_adjust_point): Likewise.
5787 (composition_update_it): Mark var as initialized.
5788 (find_automatic_composition): Mark vars as initialized,
5789 with a FIXME (Bug#8290).
5790
5791 character.h: Rename locals to avoid shadowing.
5792 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5793 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5794 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5795 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5796 to avoid shadowing.
5797
5798 * textprop.c (property_change_between_p): Remove; unused.
5799
5800 * intervals.c (interval_start_pos): Now static.
5801
5802 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5803
5804 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5805 Rename locals to avoid shadowing.
5806
5807 * sound.c (wav_play, au_play, Fplay_sound_internal):
5808 Fix pointer signedness.
5809 (alsa_choose_format): Remove unused local var.
5810 (wav_play): Initialize a variable to 0, to prevent undefined
5811 behavior (Bug#8278).
5812
5813 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5814
5815 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5816
5817 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5818 clobbering (Bug#8298).
5819 * sysdep.c (sys_subshell): Likewise.
5820 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5821
5822 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5823 This should get cleaned up, so that child_setup has the
5824 same signature on all platforms.
5825
5826 * callproc.c (call_process_cleanup): Now static.
5827 (relocate_fd): Rename locals to avoid shadowing.
5828
5829 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5830
5831 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5832 not to be necessary, and produces flickering.
5833
5834 2011-03-20 Glenn Morris <rgm@gnu.org>
5835
5836 * config.in: Remove file.
5837
5838 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5839
5840 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5841 are now in src/globals.h.
5842 (syms_of_minibuf): Remove spurious & from previous change.
5843
5844 2011-03-20 Leo <sdl.web@gmail.com>
5845
5846 * minibuf.c (completing-read-function): New variable.
5847 (completing-read-default): Rename from completing-read.
5848 (completing-read): Call completing-read-function.
5849
5850 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5851
5852 * xfaces.c (Fx_load_color_file):
5853 Read color file from absolute filename (bug#8250).
5854
5855 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5856
5857 * makefile.w32-in: Update dependencies.
5858
5859 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5860
5861 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5862
5863 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5864
5865 Fix more problems found by GCC 4.5.2's static checks.
5866
5867 * process.c (make_serial_process_unwind, send_process_trap):
5868 (sigchld_handler): Now static.
5869
5870 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5871 That way, the code declares only the vars that it needs.
5872 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5873 * s/cygwin.h (PTY_ITERATION): Likewise.
5874 * s/darwin.h (PTY_ITERATION): Likewise.
5875 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5876
5877 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5878 * process.c (allocate_pty): Don't declare stb unless it's needed.
5879
5880 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5881 (CONSTANTLIM): Remove; unused.
5882 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5883 Define only if needed.
5884
5885 * unexelf.c (unexec): Name an expression,
5886 to avoid gcc -Wbad-function-cast warning.
5887 Use a different way to cause a compilation error if anyone uses
5888 n rather than nn, a way that does not involve shadowing.
5889 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5890
5891 * deps.mk (unexalpha.o): Remove; unused.
5892
5893 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5894 * unexec.h: New file.
5895 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5896 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5897 Depend on unexec.h.
5898 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5899 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5900 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5901 Change as necessary to match prototype in unexec.h.
5902
5903 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5904 shadowing.
5905 (back_comment, skip_chars): Mark vars as initialized.
5906
5907 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5908 Rename locals to avoid shadowing.
5909
5910 * lread.c (read1): Rewrite so as not to use empty "else".
5911 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5912
5913 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5914
5915 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5916 warning when compiling print.c.
5917
5918 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5919 instead of using an uninitialized var.
5920 (font_sort_entities): Mark var as initialized.
5921
5922 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5923
5924 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5925 pointers to constants.
5926 (font_parse_fcname): Remove unused vars.
5927 (font_delete_unmatched): Now static.
5928 (font_get_spec): Remove; unused.
5929 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5930 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5931 Rename or move locals to avoid shadowing.
5932
5933 * fns.c (require_nesting_list, require_unwind): Now static.
5934 (Ffillarray): Rename locals to avoid shadowing.
5935
5936 * floatfns.c (domain_error2): Define only if needed.
5937 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5938
5939 * alloc.c (mark_backtrace): Move decl from here ...
5940 * lisp.h: ... to here, so that it can be checked.
5941
5942 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5943 (Fdefvar): Rewrite so as not to use empty "else".
5944 (lisp_indirect_variable): Name an expression,
5945 to avoid gcc -Wbad-function-cast warning.
5946 (Fdefvar): Rename locals to avoid shadowing.
5947
5948 * callint.c (quotify_arg, quotify_args): Now static.
5949 (Fcall_interactively): Rename locals to avoid shadowing.
5950 Use const pointer when appropriate.
5951
5952 * lisp.h (get_system_name, get_operating_system_release):
5953 Move decls here, to check interfaces.
5954 * process.c (get_operating_system_release): Move decl to lisp.h.
5955 * xrdb.c (get_system_name): Likewise.
5956 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5957 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5958 some of which prompt warnings from gcc -Wbad-function-cast.
5959 (Fformat_time_string, Fencode_time, Finsert_char):
5960 (Ftranslate_region_internal, Fformat):
5961 Rename or remove local vars to avoid shadowing.
5962 (Ftranslate_region_internal): Mark var as initialized.
5963
5964 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5965 avoid shadowing.
5966
5967 * lisp.h (eassert): Check that the argument compiles, even if
5968 ENABLE_CHECKING is not defined.
5969
5970 * data.c (Findirect_variable): Name an expression, to avoid
5971 gcc -Wbad-function-cast warning.
5972 (default_value, arithcompare, arith_driver, arith_error): Now static.
5973 (store_symval_forwarding): Rename local to avoid shadowing.
5974 (Fmake_variable_buffer_local, Fmake_local_variable):
5975 Mark variables as initialized.
5976 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5977
5978 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5979 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5980 Rename locals to avoid shadowing.
5981 (mark_stack): Move local variables into the #ifdef region where
5982 they're used.
5983 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5984 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5985 needed otherwise.
5986 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5987 (GC_STRING_CHARS): Remove; not used.
5988 (Fmemory_limit): Cast sbrk's returned value to char *.
5989
5990 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5991 avoids undefined behavior in theory.
5992
5993 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5994
5995 Use functions, not macros, for up- and down-casing (Bug#8254).
5996 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5997 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5998 to use the following functions instead of these macros.
5999 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6000 EMACS_INT, since callers assume the returned value fits in int.
6001 (upcase1): Likewise, for UPCASE_TABLE.
6002 (uppercasep, lowercasep, upcase): New static inline functions.
6003 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6004 the race-condition problem in the old DOWNCASE.
6005
6006 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6007 Rename locals to avoid shadowing.
6008 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6009 (regex_compile, re_search_2, re_match_2_internal):
6010 Remove unused local vars.
6011 (FREE_VAR): Rewrite so as not to use empty "else",
6012 which gcc can warn about.
6013 (regex_compile, re_match_2_internal): Mark locals as initialized.
6014 (RETALLOC_IF): Define only if needed.
6015 (WORDCHAR_P): Likewise. This one is never needed, but is used
6016 only in a comment talking about a compiler bug, so put inside
6017 the #if 0 of that comment.
6018 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6019 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6020 Remove; unused.
6021
6022 * search.c (boyer_moore): Rename locals to avoid shadowing.
6023 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6024 (PREV_CHAR_BOUNDARY): Likewise.
6025
6026 * search.c (simple_search): Remove unused var.
6027
6028 * dired.c (compile_pattern): Move decl from here ...
6029 * lisp.h: ... to here, so that it can be checked.
6030 (struct re_registers): New forward decl.
6031
6032 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6033
6034 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6035 All uses changed.
6036 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6037 Rename locals to avoid shadowing.
6038 (Fvertical_motion): Mark locals as initialized.
6039
6040 * casefiddle.c (casify_object, casify_region): Now static.
6041 (casify_region): Mark local as initialized.
6042
6043 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6044
6045 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6046 New macros, so that the caller can use some names other than
6047 gcpro1, gcpro2, etc.
6048 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6049 of the new macros.
6050 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6051 argument, for consistency with GCPRO2_VAR, etc: it is now the
6052 prefix of the variable, not the variable itself. All uses
6053 changed.
6054 * dired.c (directory_files_internal, file_name_completion):
6055 Rename locals to avoid shadowing.
6056
6057 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6058 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6059 dired.c's scmp function, had undefined behavior.
6060 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6061 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6062 * buffer.h: ... to here, because these macros use current_buffer,
6063 and the new implementation with inline functions needs to have
6064 current_buffer in scope now, rather than later when the macros
6065 are used.
6066 (downcase, upcase1): New static inline functions.
6067 (DOWNCASE, UPCASE1): Reimplement using these functions.
6068 This avoids undefined behavior in expressions like
6069 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6070 from race conditions in accessing the global variables
6071 case_temp1 and case_temp2.
6072 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6073 * lisp.h (case_temp1, case_temp2): Remove their decls.
6074 * character.h (ASCII_CHAR_P): Move from here ...
6075 * lisp.h: ... to here, so that the inline functions mentioned
6076 above can use them.
6077
6078 * dired.c (directory_files_internal_unwind): Now static.
6079
6080 * fileio.c (file_name_as_directory, directory_file_name):
6081 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6082 Now static.
6083 (file_name_as_directory): Use const pointers when appropriate.
6084 (Fexpand_file_name): Likewise. In particular, newdir might
6085 point at constant storage, so make it a const pointer.
6086 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6087 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6088 signedness issues.
6089 (Fset_file_times, Finsert_file_contents, auto_save_error):
6090 Rename locals to avoid shadowing.
6091
6092 * minibuf.c (choose_minibuf_frame_1): Now static.
6093 (Ftry_completion, Fall_completions): Rename or remove locals
6094 to avoid shadowing.
6095
6096 * marker.c (bytepos_to_charpos): Remove; unused.
6097
6098 * lisp.h (verify_bytepos, count_markers): New decls,
6099 so that gcc does not warn that these functions aren't declared.
6100
6101 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6102 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6103 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6104 (copy_text): Remove unused local var.
6105
6106 * filelock.c (within_one_second): Now static.
6107 (lock_file_1): Rename local to avoid shadowing.
6108
6109 * buffer.c (fix_overlays_before): Mark locals as initialized.
6110 (fix_start_end_in_overlays): Likewise. This function should be
6111 simplified by using pointers-to-pointers, but that's a different
6112 matter.
6113 (switch_to_buffer_1): Now static.
6114 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6115 (report_overlay_modification): Rename locals to avoid shadowing.
6116
6117 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6118 Fix pointer signedness issue.
6119 (sys_subshell): Mark local as volatile if checking for lint,
6120 to suppress a gcc -Wclobbered warning that does not seem to be right.
6121 (MAXPATHLEN): Define only if needed.
6122
6123 * process.c (serial_open, serial_configure): Move decls from here ...
6124 * systty.h: ... to here, so that they can be checked.
6125
6126 * fns.c (get_random, seed_random): Move extern decls from here ...
6127 * lisp.h: ... to here, so that they can be checked.
6128
6129 * sysdep.c (reset_io): Now static.
6130 (wait_for_termination_signal): Remove; unused.
6131
6132 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6133 (copy_keymap_item, append_key, push_text_char_description):
6134 Now static.
6135 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6136 (DENSE_TABLE_SIZE): Remove; unused.
6137 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6138 (describe_map_tree):
6139 Rename locals to avoid shadowing.
6140
6141 * keyboard.c: Declare functions static if they are not used elsewhere.
6142 (echo_char, echo_dash, cmd_error, top_level_2):
6143 (poll_for_input, handle_async_input): Now static.
6144 (read_char, kbd_buffer_get_event, make_lispy_position):
6145 (make_lispy_event, make_lispy_movement, apply_modifiers):
6146 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6147 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6148 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6149 (read_key_sequence, read_char): Mark locals as initialized.
6150 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6151
6152 * keyboard.h (make_ctrl_char): New decl.
6153 (mark_kboards): Move decl here ...
6154 * alloc.c (mark_kboards): ... from here.
6155
6156 * lisp.h (force_auto_save_soon): New decl.
6157
6158 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6159 (DEFINE_DUMMY_FUNCTION): New macro.
6160 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6161 Use it.
6162 (main): Add casts to avoid warnings
6163 if GCC considers string literals to be constants.
6164
6165 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6166
6167 * dbusbind.c: Pointer signedness fixes.
6168 (xd_signature, xd_append_arg, xd_initialize):
6169 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6170 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6171 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6172 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6173
6174 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6175 if GCC considers string literals to be constants.
6176 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6177
6178 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6179
6180 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6181 (print_preprocess, print_object): New macro to fix last change.
6182
6183 * print.c (print_preprocess): Don't forget font objects.
6184
6185 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6186
6187 * emacs.c (USAGE3): Doc fixes.
6188
6189 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6190
6191 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6192 structure.
6193
6194 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6195
6196 * lisp.h (VWindow_system, Qfile_name_history):
6197 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6198 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6199 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6200
6201 * w32select.c: Don't #include "keyboard.h".
6202 (run_protected): Add extern declaration for waiting_for_input.
6203
6204 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6205 * w32console.c (detect_input_pending, read_input_pending)
6206 (encode_terminal_code):
6207 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6208 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6209 (w32_system_caret_y, Qfile_name_history):
6210 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6211 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6212 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6213 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6214 * w32proc.c (Qlocal, report_file_error):
6215 * w32term.c (Vwindow_system, updating_frame):
6216 * w32uniscribe.c (initialized, uniscribe_font_driver):
6217 Remove unneeded extern declarations.
6218
6219 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6220
6221 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6222
6223 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6224
6225 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6226 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6227 These macros can no longer be used for assignment.
6228
6229 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6230 Assign struct members directly, instead of using BUF_BEGV etc.
6231 (record_buffer_markers, fetch_buffer_markers): New functions for
6232 recording and fetching special buffer markers.
6233 (set_buffer_internal_1, set_buffer_temp): Use them.
6234
6235 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6236
6237 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6238
6239 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6240 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6241
6242 * xdisp.c (hscroll_window_tree):
6243 (reconsider_clip_changes): Use PT instead of BUF_PT.
6244
6245 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6246
6247 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6248 $(EMACS_ROOT)/lib/intprops.h.
6249
6250 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6251
6252 Fix more problems found by GCC 4.5.2's static checks.
6253
6254 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6255 to unsigned char * to avoid compiler diagnostic.
6256 (xg_free_frame_widgets): Make it clear that a local variable is
6257 needed only if USE_GTK_TOOLTIP.
6258 (gdk_window_get_screen): Make it clear that this macro is needed
6259 only if USE_GTK_TOOLTIP.
6260 (int_gtk_range_get_value): New function, which avoids a diagnostic
6261 from gcc -Wbad-function-cast.
6262 (xg_set_toolkit_scroll_bar_thumb): Use it.
6263 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6264 diagnostic from gcc -Wbad-function-cast.
6265 (get_utf8_string, xg_get_file_with_chooser):
6266 Rename locals to avoid shadowing.
6267 (create_dialog): Move locals to avoid shadowing.
6268
6269 * xgselect.c (xg_select): Remove unused var.
6270
6271 * image.c (four_corners_best): Mark locals as initialized.
6272 (gif_load): Initialize transparent_p to zero (Bug#8238).
6273 Mark another local as initialized.
6274 (my_png_error, my_error_exit): Mark with NO_RETURN.
6275
6276 * image.c (clear_image_cache): Now static.
6277 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6278 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6279 (x_edge_detection): Remove unnecessary cast that
6280 gcc -Wbad-function-cast diagnoses.
6281 (gif_load): Fix pointer signedness.
6282 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6283 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6284
6285 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6286
6287 Improve quality of tests for time stamp overflow.
6288 For example, without this patch (encode-time 0 0 0 1 1
6289 1152921504606846976) returns the obviously-bogus value (-948597
6290 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6291 reports time overflow. See
6292 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6293 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6294 * editfns.c: Include limits.h and intprops.h.
6295 (TIME_T_MIN, TIME_T_MAX): New macros.
6296 (time_overflow): Move earlier, to before first use.
6297 (hi_time, lo_time): New functions, for an accurate test for
6298 out-of-range times.
6299 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6300 (Fget_internal_run_time): Don't assume time_t fits in int.
6301 (make_time): Use list2 instead of Fcons twice.
6302 (Fdecode_time): More accurate test for out-of-range times.
6303 (check_tm_member): New function.
6304 (Fencode_time): Use it, to test for out-of-range times.
6305 (lisp_time_argument): Don't rely on undefined left-shift and
6306 right-shift behavior when checking for time stamp overflow.
6307
6308 * editfns.c (time_overflow): New function, refactoring common code.
6309 (Fformat_time_string, Fdecode_time, Fencode_time):
6310 (Fcurrent_time_string): Use it.
6311
6312 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6313 * dired.c (make_time): Move to ...
6314 * editfns.c (make_time): ... here.
6315 * systime.h: Note the move.
6316
6317 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6318
6319 * fringe.c (update_window_fringes): Remove unused variables.
6320
6321 * unexmacosx.c (copy_data_segment): Also copy __got section.
6322 (Bug#8223)
6323
6324 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6325
6326 * termcap.c [MSDOS]: Include "msdos.h".
6327 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6328 Constify `char *' arguments and their references according to
6329 prototypes in tparam.h.
6330
6331 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6332
6333 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6334 Adapt all references accordingly.
6335
6336 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6337
6338 2011-03-11 Tom Tromey <tromey@redhat.com>
6339
6340 * buffer.c (syms_of_buffer): Remove obsolete comment.
6341
6342 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6343
6344 * termhooks.h (encode_terminal_code): Declare prototype.
6345
6346 * msdos.c (encode_terminal_code): Don't declare prototype.
6347
6348 * term.c (encode_terminal_code): Now external again, used by
6349 w32console.c and msdos.c.
6350
6351 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6352 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6353
6354 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6355
6356 Fix some minor problems found by GCC 4.5.2's static checks.
6357
6358 * fringe.c (update_window_fringes): Mark locals as initialized
6359 (Bug#8227).
6360 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6361
6362 * alloc.c (mark_fringe_data): Move decl from here ...
6363 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6364 to check its interface.
6365 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6366
6367 * fontset.c (free_realized_fontset): Now static.
6368 (Fset_fontset_font): Rename local to avoid shadowing.
6369 (fontset_font): Mark local as initialized.
6370 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6371
6372 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6373
6374 * xselect.c (x_disown_buffer_selections): Remove; not used.
6375 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6376 (x_own_selection, Fx_disown_selection_internal): Rename locals
6377 to avoid shadowing.
6378 (x_handle_dnd_message): Remove local to avoid shadowing.
6379
6380 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6381 so that the caller can use some name other than gcpro1.
6382 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6383 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6384 (Fx_backspace_delete_keys_p):
6385 Use them to avoid shadowing, and rename vars to avoid shadowing.
6386 (x_decode_color, x_set_name, x_window): Now static.
6387 (Fx_create_frame): Add braces to silence GCC warning.
6388 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6389 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6390 Remove unused locals.
6391 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6392 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6393 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6394 macros.
6395
6396 * xterm.h (x_mouse_leave): New decl.
6397
6398 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6399 Remove unused functions.
6400 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6401 (x_calc_absolute_position): Now static.
6402 (XTread_socket): Don't define label "out" unless it's used.
6403 Don't declare local "event" unless it's used.
6404 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6405 unless they are used.
6406 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6407 (x_fatal_error_signal): Remove; not used.
6408 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6409 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6410 (x_error_catcher, x_connection_closed, x_error_handler):
6411 (x_error_quitter, xembed_send_message, x_iconify_frame):
6412 (my_log_handler): Rename locals to avoid shadowing.
6413 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6414 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6415
6416 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6417 Rename or move locals to avoid shadowing.
6418 (tty_defined_color, merge_face_heights): Now static.
6419 (free_realized_faces_for_fontset): Remove; not used.
6420 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6421 does not deduce is never used uninitialized.
6422 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6423 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6424
6425 * terminal.c (store_terminal_param): Now static.
6426
6427 * xmenu.c (menu_highlight_callback): Now static.
6428 (set_frame_menubar): Remove unused local.
6429 (xmenu_show): Rename parameter to avoid shadowing.
6430 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6431 since they might point to immutable storage.
6432 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6433 since it's unused otherwise.
6434
6435 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6436 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6437 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6438 avoids a gcc -Wuninitialized diagnostic.
6439 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6440 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6441 does not deduce are never used uninitialized.
6442
6443 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6444
6445 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6446 * window.c (window_loop, size_window):
6447 (run_window_configuration_change_hook, enlarge_window): Likewise.
6448
6449 * window.c (display_buffer): Now static.
6450 (size_window): Mark variables that gcc -Wuninitialized
6451 does not deduce are never used uninitialized.
6452 * window.h (check_all_windows): New decl, to forestall
6453 gcc -Wmissing-prototypes diagnostic.
6454 * dispextern.h (bidi_dump_cached_states): Likewise.
6455
6456 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6457 shadowing.
6458 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6459 Include <limits.h>.
6460 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6461 and to avoid gcc -Wuninitialized warning.
6462 (load_charset_map): Mark variables that gcc -Wuninitialized
6463 does not deduce are never used uninitialized.
6464 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6465
6466 * coding.c (coding_set_source, coding_set_destination):
6467 Use "else { /* comment */ }" rather than "else /* comment */;"
6468 for clarity, and to avoid gcc -Wempty-body warning.
6469 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6470 a block, when the outer 'i' will do.
6471 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6472 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6473 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6474 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6475 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6476 Rename locals to avoid shadowing.
6477 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6478 * coding.c (emacs_mule_char, encode_invocation_designation):
6479 Now static, since they're not used elsewhere.
6480 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6481 (decode_coding_object, encode_coding_object, detect_coding_system):
6482 (decode_coding_emacs_mule): Mark variables that gcc
6483 -Wuninitialized does not deduce are never used uninitialized.
6484 (detect_coding_iso_2022): Initialize a local variable that might
6485 be used uninitialized. Leave a FIXME because it's not clear that
6486 this initialization is needed. (Bug#8211)
6487 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6488 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6489 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6490 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6491 Remove unused macros.
6492
6493 * category.c (hash_get_category_set): Remove unused local var.
6494 (copy_category_table): Now static, since it's not used elsewhere.
6495 * character.c (string_count_byte8): Likewise.
6496
6497 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6498 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6499
6500 * chartab.c (copy_sub_char_table): Now static, since it's not used
6501 elsewhere.
6502 (sub_char_table_ref_and_range, char_table_ref_and_range):
6503 Rename locals to avoid shadowing.
6504 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6505
6506 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6507 (BIDI_BOB): Remove unused macro.
6508
6509 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6510 deduce are never used uninitialized.
6511 * term.c (encode_terminal_code): Likewise.
6512
6513 * term.c (encode_terminal_code): Now static. Remove unused local.
6514
6515 * tparam.h: New file.
6516 * term.c, tparam.h: Include it.
6517 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6518 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6519 Move these decls to tparam.h, and make them agree with what
6520 is actually in tparam.c. The previous trick of using incompatible
6521 decls in different modules does not conform to the C standard.
6522 All callers of tparam changed to use tparam's actual API.
6523 * tparam.c (tparam1, tparam, tgoto):
6524 Use const pointers where appropriate.
6525
6526 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6527 * cm.h (struct cm): Likewise.
6528 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6529 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6530 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6531 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6532 (turn_on_face, init_tty): Likewise.
6533 * termchar.h (struct tty_display_info): Likewise.
6534
6535 * term.c (term_mouse_position): Rename local to avoid shadowing.
6536
6537 * alloc.c (mark_ttys): Move decl from here ...
6538 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6539
6540 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6541
6542 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6543
6544 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6545
6546 * search.c (compile_pattern_1): Remove argument regp, unused since
6547 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6548 (compile_pattern): Don't pass it.
6549
6550 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6551
6552 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6553 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6554 for ! HAVE_GTK3.
6555 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6556
6557 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6558
6559 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6560 gdk_window_get_screen, gdk_window_get_geometry,
6561 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6562 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6563 (xg_get_pixbuf_from_pixmap): New function.
6564 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6565 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6566 Call xg_get_pixbuf_from_pixmap instead of
6567 gdk_pixbuf_get_from_drawable.
6568 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6569 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6570 (xg_check_special_colors): Use GtkStyleContext and its functions
6571 for HAVE_GTK3.
6572 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6573 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6574 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6575 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6576 Call gtk_widget_get_preferred_size.
6577 (xg_frame_resized): gdk_window_get_geometry only takes 5
6578 parameters.
6579 (xg_win_to_widget, xg_event_is_for_menubar):
6580 Call gdk_x11_window_lookup_for_display.
6581 (xg_set_widget_bg): New function.
6582 (delete_cb): New function.
6583 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6584 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6585 (xg_set_background_color): Call xg_set_widget_bg.
6586 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6587 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6588 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6589 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6590 if ! HAVE_GTK3.
6591 (update_frame_tool_bar): Call gtk_widget_hide.
6592 (xg_initialize): Use GDK_KEY_g.
6593
6594 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6595 if ! HAVE_GTK3
6596 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6597
6598 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6599 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6600 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6601
6602 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6603
6604 * w32xfns.c (select_palette): Check success of RealizePalette against
6605 GDI_ERROR, not zero.
6606
6607 See ChangeLog.11 for earlier changes.
6608
6609 ;; Local Variables:
6610 ;; coding: utf-8
6611 ;; End:
6612
6613 Copyright (C) 2011 Free Software Foundation, Inc.
6614
6615 This file is part of GNU Emacs.
6616
6617 GNU Emacs is free software: you can redistribute it and/or modify
6618 it under the terms of the GNU General Public License as published by
6619 the Free Software Foundation, either version 3 of the License, or
6620 (at your option) any later version.
6621
6622 GNU Emacs is distributed in the hope that it will be useful,
6623 but WITHOUT ANY WARRANTY; without even the implied warranty of
6624 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6625 GNU General Public License for more details.
6626
6627 You should have received a copy of the GNU General Public License
6628 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.