* keyboard.c: Integer and memory overflow fixes.
[bpt/emacs.git] / src / ChangeLog
1 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
2
3 * keyboard.c: Integer and memory overflow fixes.
4 (read_char, menu_bar_items, tool_bar_items, read_char_x_menu_prompt)
5 (read_char_minibuf_menu_width, read_char_minibuf_menu_prompt)
6 (follow_key, read_key_sequence): Use ptrdiff_t, not int, to count maps.
7 (read_char_minibuf_menu_prompt): Check for overflow in size
8 calculations. Don't update size until allocation succeeds. Redo
9 calculations to avoid overflow.
10 * keyboard.h: Change prototypes to match the above.
11
12 * image.c: Integer and memory overflow fixes.
13 (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these are duplicate
14 now that they've been promoted to lisp.h.
15 (x_allocate_bitmap_record, x_alloc_image_color)
16 (make_image_cache, cache_image, xpm_load):
17 Don't update size until alloc is done.
18 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
19 (x_detect_edges):
20 Check for size calculation overflow.
21 (ct_colors_allocated_max): New constant.
22 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
23 overflow.
24
25 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
26
27 * gtkutil.c: Integer overflow fixes.
28 (get_utf8_string, xg_store_widget_in_map):
29 Check for size-calculation overflow.
30 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
31 do, as we prefer signed integers.
32 (id_to_widget.max_size, id_to_widget.used)
33 (xg_store_widget_in_map, xg_remove_widget_from_map)
34 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
35 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
36 Use and return ptrdiff_t, not int.
37 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
38 * gtkutil.h: Change prototypes to match the above.
39
40 * ftfont.c: Check for size overflow.
41 (ftfont_get_open_type_spec, setup_otf_gstring, ftfont_shape_by_flt):
42 Check for integer overflow in size calculations.
43
44 * fringe.c (Fdefine_fringe_bitmap): Don't update size until alloc works.
45
46 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
47 This is for the members text_lines, text_cols, total_lines, total_cols,
48 where the system imposes an 'int' limit.
49
50 * frame.c: Integer overflow fixes.
51 (set_menu_bar_lines, x_set_frame_parameters, x_set_scroll_bar_width)
52 (x_figure_window_size): Check for integer overflow.
53 (x_set_alpha): Do not assume XINT fits in int.
54
55 * eval.c: Integer and memory overflow fixes.
56 (init_eval_once, grow_specpdl): Don't update size until alloc succeeds.
57 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
58
59 * emacs.c (main, sort_args): Check for size-calculation overflow.
60
61 * editfns.c: Integer and memory overflow fixes.
62 (set_time_zone_rule): Don't assume environment length fits in int.
63 (message_length): Now ptrdiff_t, not int.
64 (Fmessage_box): Don't update size until allocation succeeds.
65 Don't assume message length fits in int.
66 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
67
68 * doc.c: Integer and memory overflow fixes.
69 (get_doc_string_buffer_size): Now ptrdiff_t, not int.
70 (get_doc_string): Check for size calculation overflow.
71 Don't update size until allocation succeeds.
72 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
73 EMACS_INT, where ptrdiff_t will do.
74 (Fsubstitute_command_keys): Check for string overflow.
75
76 Integer and memory overflow fixes for display code.
77 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
78 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool, scrolling_window):
79 Check for overflow in size calculations.
80 (line_draw_cost, realloc_glyph_pool, add_row_entry):
81 Don't assume glyph table len fits in int.
82 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
83 (row_table_size): Now ptrdiff_t, not int.
84 (scrolling_window): Avoid overflow in size calculations.
85 Don't update size until allocation succeeds.
86 * fns.c (concat): Check for overflow in size calculations.
87 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
88 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
89 (NEXT_ALMOST_PRIME_LIMIT): New constant.
90
91 * composite.c: Integer overflow fixes.
92 (get_composition_id): Check for overflow in glyph length calculations.
93
94 * coding.c: Integer and memory overflow fixes.
95 (produce_chars): Redo buffer-overflow calculations to avoid
96 unnecessary integer overflow. Check for size overflow.
97 (encode_coding_object): Don't update size until xmalloc succeeds.
98
99 * character.c (Fstring): Check for size-calculation overflow.
100
101 * ccl.c: Integer and memory overflow fixes.
102 (Fccl_execute_on_string): Check for memory overflow.
103 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
104 Redo buffer-overflow calculations to avoid integer overflow.
105
106 * callproc.c (child_setup): Don't assume strlen fits in int.
107
108 * buffer.c: Memory overflow fixes.
109 (overlays_at, overlays_in, record_overlay_string, overlay_strings):
110 Don't update size of array until after memory allocation succeeds,
111 because xmalloc/xrealloc may not return.
112
113 * bidi.c: Integer overflow fix.
114 (bidi_shelve_header_size): New constant.
115 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
116 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
117
118 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
119
120 Use ptrdiff_t for composition IDs.
121 * character.c (lisp_string_width):
122 * composite.c (composition_table_size, n_compositions)
123 (get_composition_id, composition_gstring_from_id):
124 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
125 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
126 * window.c (Frecenter):
127 Use ptrdiff_t, not int, for composition IDs.
128 * composite.c (get_composition_id): Check for integer overflow.
129 * composite.h: Adjust prototypes to match the above changes.
130
131 Use ptrdiff_t for hash table indexes.
132 * category.c (hash_get_category_set):
133 * ccl.c (ccl_driver):
134 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
135 * coding.c (coding_system_charset_list, detect_coding_system):
136 * coding.h (struct coding_system.id):
137 * composite.c (get_composition_id, gstring_lookup_cache):
138 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
139 * image.c (xpm_get_color_table_h):
140 * lisp.h (hash_lookup, hash_put):
141 * minibuf.c (Ftest_completion):
142 Use ptrdiff_t for hash table indexes, not int (which is too
143 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
144 32-bit --with-wide-int hosts).
145
146 * charset.c (Fdefine_charset_internal): Check for integer overflow.
147 Add a FIXME comment about memory leaks.
148 (syms_of_charset): Don't assume xmalloc returns.
149
150 Don't assume that stated character widths fit in int.
151 * character.c (Fchar_width, c_string_width, lisp_string_width):
152 * character.h (CHAR_WIDTH):
153 * indent.c (MULTIBYTE_BYTES_WIDTH):
154 Use sanitize_char_width to avoid undefined and/or bad behavior
155 with outlandish widths.
156 * character.h (sanitize_tab_width): Renamed from sanitize_width,
157 now that we have two such functions. All uses changed.
158 (sanitize_char_width): New inline function.
159
160 Don't assume that tab-width fits in int.
161 * character.h (sanitize_width): New inline function.
162 (SANE_TAB_WIDTH): New macro.
163 (ASCII_CHAR_WIDTH): Use it.
164 * indent.c (sane_tab_width): Remove. All uses replaced by
165 SANE_TAB_WIDTH (current_buffer).
166 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
167
168 * fileio.c: Integer overflow issues with file modes.
169 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
170
171 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
172 Remove unreachable code.
173 (read_hex, load_charset_map_from_file): Check for integer overflow.
174
175 * xterm.c: don't go over XClientMessageEvent limit
176 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
177 (x_send_scroll_bar_event): Likewise. Check that the size does not
178 exceed limits imposed by XClientMessageEvent, as well as the usual
179 ptrdiff_t and size_t limits.
180
181 * keyboard.c: Overflow, signedness and related fixes.
182 (make_lispy_movement): Use same integer type in forward decl
183 that is used in the definition.
184 (read_key_sequence, keyremap_step):
185 Change bufsize argument back to int, undoing my 2011-03-30 change.
186 We prefer signed types, and int is wide enough here.
187 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
188 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
189 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
190 length, not size_t. Use ptrdiff_t for index, not int.
191 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
192 possibility of integer overflow.
193
194 Overflow, signedness and related fixes for images.
195
196 * dispextern.h (struct it.stack[0].u.image.image_id)
197 (struct_it.image_id, struct image.id, struct image_cache.size)
198 (struct image_cache.used, struct image_cache.ref_count):
199 * gtkutil.c (update_frame_tool_bar):
200 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
201 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
202 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
203 * nsmenu.m (update_frame_tool_bar):
204 * xdisp.c (calc_pixel_width_or_height):
205 * xfns.c (image_cache_refcount):
206 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
207 on typical 64-bit hosts.
208
209 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
210 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
211 Omit unnecessary casts to int.
212 (parse_image_spec): Check that integers fall into 'int' range
213 when the callers expect that.
214 (image_ascent): Redo ascent calculation to avoid int overflow.
215 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
216 (lookup_image): Remove unnecessary tests.
217 (xbm_image_p): Locals are now of int, not EMACS_INT,
218 since parse_image_check makes sure they fit into int.
219 (png_load, gif_load, svg_load_image):
220 Prefer int to unsigned where either will do.
221 (tiff_handler): New function, combining the cores of the
222 old tiff_error_handler and tiff_warning_handler. This
223 function is rewritten to use vsnprintf and thereby avoid
224 stack buffer overflows. It uses only the features of vsnprintf
225 that are common to both POSIX and native Microsoft.
226 (tiff_error_handler, tiff_warning_handler): Use it.
227 (tiff_load, gif_load, imagemagick_load_image):
228 Don't assume :index value fits in 'int'.
229 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
230 (imagemagick_load_image): Check that crop parameters fit into
231 the integer types that MagickCropImage accepts. Don't assume
232 Vimagemagick_render_type has a nonnegative value. Don't assume
233 size_t fits in 'long'.
234 (gs_load): Use printmax_t to print the widest integers possible.
235 Check for integer overflow when computing image height and width.
236
237 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
238
239 Integer signedness and overflow and related fixes. (Bug#9079)
240
241 * bidi.c: Integer size and overflow fixes.
242 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
243 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
244 (bidi_cache_find_level_change, bidi_cache_ensure_space)
245 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
246 (bidi_find_other_level_edge):
247 Use ptrdiff_t instead of EMACS_INT where either will do.
248 This works better on 32-bit hosts configured --with-wide-int.
249 (bidi_cache_ensure_space): Check for size-calculation overflow.
250 Use % rather than repeated addition, for better worst-case speed.
251 Don't set bidi_cache_size until after xrealloc returns, because it
252 might not return.
253 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
254 (bidi_cache_ensure_space): Also check that the bidi cache size
255 does not exceed that of the largest Lisp string or buffer. See Eli
256 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
257
258 * alloc.c (__malloc_size_t): Remove.
259 All uses replaced by size_t. See Andreas Schwab's note
260 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
261
262 * image.c: Improve checking for integer overflow.
263 (check_image_size): Assume that f is nonnull, since
264 it is always nonnull in practice. This is one less thing to
265 worry about when checking for integer overflow later.
266 (x_check_image_size): New function, which checks for integer
267 overflow issues inside X.
268 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
269 This removes the need for a memory_full check.
270 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
271 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
272 (xbm_read_bitmap_data): Change locals back to 'int', since
273 their values must fit in 'int'.
274 (xpm_load_image, png_load, tiff_load):
275 Invoke x_create_x_image_and_pixmap earlier,
276 to avoid much needless work if the image is too large.
277 (tiff_load): Treat overly large images as if
278 x_create_x_image_and_pixmap failed, not as malloc failures.
279 (gs_load): Use x_check_image_size.
280
281 * gtkutil.c: Omit integer casts.
282 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
283 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
284
285 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
286
287 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
288 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
289 would wrongly return t on a 64-bit host.
290
291 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
292 The plain *_OVERFLOW macros run afoul of GCC bug 49705
293 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
294 and therefore cause GCC to emit a bogus diagnostic in some cases.
295
296 * image.c: Integer signedness and overflow and related fixes.
297 This is not an exhaustive set of fixes, but it's time to
298 record what I've got.
299 (lookup_pixel_color, check_image_size): Remove redundant decls.
300 (check_image_size): Don't assume that arbitrary EMACS_INT values
301 fit in 'int', or that arbitrary 'double' values fit in 'int'.
302 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
303 (tiff_load, imagemagick_load_image):
304 Check for overflow in size calculations.
305 (x_create_x_image_and_pixmap): Remove unnecessary test for
306 xmalloc returning NULL; that can't happen.
307 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
308 (xpm_color_bucket): Use better integer hashing function.
309 (xpm_cache_color): Don't possibly over-allocate memory.
310 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
311 (gif_memory_source):
312 Use ptrdiff_t, not int or size_t, to record sizes.
313 (png_load): Don't assume values greater than 2**31 fit in 'int'.
314 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
315 either works, as we prefer signed integers.
316 (tiff_read_from_memory, tiff_write_from_memory):
317 Return tsize_t, not size_t, since that's what the TIFF API wants.
318 (tiff_read_from_memory): Don't fail simply because the read would
319 go past EOF; instead, return a short read.
320 (tiff_load): Omit no-longer-needed casts.
321 (Fimagemagick_types): Don't assume size fits into 'int'.
322
323 Improve hashing quality when configured --with-wide-int.
324 * fns.c (hash_string): New function, taken from sxhash_string.
325 Do not discard information about ASCII character case; this
326 discarding is no longer needed.
327 (sxhash-string): Use it. Change sig to match it. Caller changed.
328 * lisp.h: Declare it.
329 * lread.c (hash_string): Remove, since we now use fns.c's version.
330 The fns.c version returns a wider integer if --with-wide-int is
331 specified, so this should help the quality of the hashing a bit.
332
333 * emacs.c: Integer overflow minor fix.
334 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
335 Define only if GNU_LINUX.
336 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
337
338 * dispnew.c: Integer signedness and overflow fixes.
339 Remove unnecessary forward decls, that were a maintenance hassle.
340 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
341 All uses changed.
342 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
343 (scrolling_window): Use ptrdiff_t, not int, for byte count.
344 (prepare_desired_row, line_draw_cost):
345 Use int, not unsigned, where either works.
346 (save_current_matrix, restore_current_matrix):
347 Use ptrdiff_t, not size_t, where either works.
348 (init_display): Check for overflow more accurately, and without
349 relying on undefined behavior.
350
351 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
352 Remove, replacing with the new symbols in lisp.h. All uses changed.
353 * fileio.c (make_temp_name):
354 * filelock.c (lock_file_1, lock_file):
355 * xdisp.c (message_dolog):
356 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
357 Use pMd etc. instead.
358 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
359 replacing the pWIDE etc. symbols removed from editfns.c.
360
361 * keyboard.h (num_input_events): Now uintmax_t.
362 This is (very slightly) less likely to mess up due to wraparound.
363 All uses changed.
364
365 * buffer.c: Integer signedness fixes.
366 (alloc_buffer_text, enlarge_buffer_text):
367 Use ptrdiff_t rather than size_t when either will do, as we prefer
368 signed integers.
369
370 * alloc.c: Integer signedness and overflow fixes.
371 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
372 (__malloc_size_t): Default to size_t, not to int.
373 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
374 (Fgarbage_collect, mark_object_loop_halt, mark_object):
375 Prefer ptrdiff_t to size_t when either would do, as we prefer
376 signed integers.
377 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
378 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
379 Now const. Initialize with values that are in range even if char
380 is signed.
381 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
382 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
383 These functions do the right thing with sizes > 2**32.
384 (check_depth): Now ptrdiff_t, not int.
385 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
386 Adjust to new way of storing sizes. Check for size overflow bugs
387 in rest of code.
388 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
389 slightly wrong anyway, as it missed one instance of
390 XMALLOC_OVERRUN_CHECK_OVERHEAD.
391 (refill_memory_reserve): Omit needless cast to size_t.
392 (mark_object_loop_halt): Mark as externally visible.
393
394 * xselect.c: Integer signedness and overflow fixes.
395 (Fx_register_dnd_atom, x_handle_dnd_message):
396 Use ptrdiff_t, not size_t, since we prefer signed.
397 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
398 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
399 x_dnd_atoms_size and x_dnd_atoms_length.
400
401 * doprnt.c: Prefer signed to unsigned when either works.
402 * eval.c (verror):
403 * doprnt.c (doprnt):
404 * lisp.h (doprnt):
405 * xdisp.c (vmessage):
406 Use ptrdiff_t, not size_t, when using or implementing doprnt,
407 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
408 prefer signed arithmetic to avoid comparison confusion.
409 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
410 but is a bit tricky.
411
412 Assume freestanding C89 headers, string.h, stdlib.h.
413 * data.c, doprnt.c, floatfns.c, print.c:
414 Include float.h unconditionally.
415 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
416 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
417 * regex.c: Likewise for stddef.h, string.h.
418 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
419 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
420 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
421 (STDC_HEADERS): Remove obsolete defines.
422 * sysdep.c: Include limits.h unconditionally.
423
424 Assume support for memcmp, memcpy, memmove, memset.
425 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
426 * regex.c (memcmp, memcpy):
427 Remove; we assume C89 now.
428
429 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
430 (__malloc_safe_bcopy): Remove; no longer needed.
431
432 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
433 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
434 well either way, and we prefer signed to unsigned.
435
436 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
437
438 Port to OpenBSD.
439 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
440 and the surrounding thread.
441 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
442 rather than fgets, and retry after EINTR. Otherwise, 'emacs
443 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
444 timer goes off.
445 * s/openbsd.h (BROKEN_SIGIO): Define.
446 * unexelf.c (unexec) [__OpenBSD__]:
447 Don't update the .mdebug section of the Alpha COFF symbol table.
448
449 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
450
451 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
452 (bug#8460).
453
454 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
455
456 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
457 This fixes some race conditions on the permissions of any newly
458 created file.
459
460 * alloc.c (valid_pointer_p): Use pipe, not open.
461 This fixes some permissions issues when debugging.
462
463 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
464 If fchown fails to set both uid and gid, try to set just gid,
465 as that is sometimes allowed. Adjust the file's mode to eliminate
466 setuid or setgid bits that are inappropriate if fchown fails.
467
468 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
469
470 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
471 to compare Lisp_Objects.
472 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
473 global_gnutls_log_level, don't mistake it for a Lisp_Object.
474 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
475
476 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
477
478 * lread.c (read_integer): Unread even EOF character.
479 (read1): Likewise. Properly record start position of symbol.
480
481 * lread.c (read1): Read `#:' as empty uninterned symbol if no
482 symbol character follows.
483
484 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
485
486 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
487 This works around a problem with the previous change to Fcopy_file.
488 Recent glibc declares fchown with __attribute__((warn_unused_result)),
489 and without this change, GCC might complain about discarding
490 fchown's return value.
491
492 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
493
494 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
495
496 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
497
498 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
499
500 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
501
502 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
503 it's used from the C level.
504
505 * process.c: Use the same condition for POLL_FOR_INPUT in both
506 keyboard.c and process.c (bug#1858).
507
508 2011-07-09 Lawrence Mitchell <wence@gmx.li>
509
510 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
511 (Fgnutls_boot): Use it.
512
513 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
514
515 * doc.c (Fsubstitute_command_keys): Revert last change.
516
517 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
518
519 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
520 quotes the next character, and doesn't affect other longer
521 sequences (bug#8935).
522
523 * lread.c (syms_of_lread): Clarify that is isn't only
524 `eval-buffer' and `eval-defun' that's affected by
525 `lexical-binding' (bug#8460).
526
527 2011-07-15 Eli Zaretskii <eliz@gnu.org>
528
529 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
530 bidi redisplay when a line includes both an image and is
531 truncated.
532
533 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
534
535 Fix minor problems found by static checking.
536 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
537 (elsz): Now a signed constant, not a size_t var. We prefer signed
538 types to unsigned, to avoid integer comparison confusion. Without
539 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
540 "cannot optimize loop, the loop counter may overflow", a symptom
541 of the confusion.
542 * indent.c (Fvertical_motion): Mark locals as initialized.
543 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
544
545 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
546
547 * search.c (Fre_search_backward): Mention `case-fold-search' in
548 all the re_search_* functions (bug#8138).
549
550 * keyboard.c (Fopen_dribble_file): Document when the file is
551 closed (bug#8056).
552
553 2011-07-14 Eli Zaretskii <eliz@gnu.org>
554
555 * bidi.c (bidi_dump_cached_states): Fix format of displaying
556 bidi_cache_idx.
557
558 Support bidi reordering of display and overlay strings.
559 * xdisp.c (compute_display_string_pos)
560 (compute_display_string_end): Accept additional argument STRING.
561 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
562 (reseat_to_string): Initialize bidi_it->string.s and
563 bidi_it->string.schars.
564 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
565 NULL (avoids a crash in bidi_paragraph_init). Initialize
566 itb.string.lstring.
567 (init_iterator): Call bidi_init_it only of a valid
568 buffer position was specified. Initialize paragraph_embedding to
569 L2R.
570 (reseat_to_string): Initialize the bidi iterator.
571 (display_string): If we need to ignore text properties of
572 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
573 original value of -1 will not work with bidi.)
574 (compute_display_string_pos): First arg is now struct
575 `text_pos *'; all callers changed. Support display properties on
576 Lisp strings.
577 (compute_display_string_end): Support display properties on Lisp
578 strings.
579 (init_iterator, reseat_1, reseat_to_string): Initialize the
580 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
581 when iterating on a string not from display properties).
582 (compute_display_string_pos, compute_display_string_end): Fix
583 calculation of the object to scan. Fixes an error when using
584 arrow keys.
585 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
586 base_level_stop; instead, set base_level_stop to BEGV. Fixes
587 crashes in vertical-motion.
588 (next_element_from_buffer): Improve commentary for when
589 the iterator is before prev_stop.
590 (init_iterator): Initialize bidi_p from the default value of
591 bidi-display-reordering, not from buffer-local value. Use the
592 buffer-local value only if initializing for buffer iteration.
593 (handle_invisible_prop): Support invisible properties on strings
594 that are being bidi-reordered.
595 (set_iterator_to_next): Support bidi reordering of C strings and
596 Lisp strings.
597 (next_element_from_string): Support bidi reordering of Lisp
598 strings.
599 (handle_stop_backwards): Support Lisp strings as well.
600 (display_string): Support display of R2L glyph rows. Use
601 IT_STRING_CHARPOS when displaying from a Lisp string.
602 (init_iterator): Don't initialize it->bidi_p for strings
603 here.
604 (reseat_to_string): Initialize it->bidi_p for strings here.
605 (next_element_from_string, next_element_from_c_string)
606 (next_element_from_buffer): Add xassert's for correspondence
607 between IT's object being iterated and it->bidi_it.string
608 structure.
609 (face_before_or_after_it_pos): Support bidi iteration.
610 (next_element_from_c_string): Handle the case of the first string
611 character that is not the first one in the visual order.
612 (get_visually_first_element): New function, refactored from common
613 parts of next_element_from_buffer, next_element_from_string, and
614 next_element_from_c_string.
615 (tool_bar_lines_needed, redisplay_tool_bar)
616 (display_menu_bar): Force left-to-right direction. Add a FIXME
617 comment for making that be controlled by a user option.
618 (push_it, pop_it): Save and restore the state of the
619 bidi iterator. Save and restore the bidi_p flag.
620 (pop_it): Iterate out of display property for string iteration as
621 well.
622 (iterate_out_of_display_property): Support iteration over strings.
623 (handle_single_display_spec): Set up it->bidi_it for iteration
624 over a display string, and call bidi_init_it.
625 (handle_single_display_spec, next_overlay_string)
626 (get_overlay_strings_1, push_display_prop): Set up the bidi
627 iterator for displaying display or overlay strings.
628 (forward_to_next_line_start): Don't use the shortcut if
629 bidi-iterating.
630 (back_to_previous_visible_line_start): If handle_display_prop
631 pushed the iterator stack, restore the internal state of the bidi
632 iterator by calling bidi_pop_it same number of times.
633 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
634 and we are bidi-iterating, don't decrement the iterator position;
635 instead, set the first_elt flag in the bidi iterator, to produce
636 the same effect.
637 (reseat_1): Remove redundant setting of string_from_display_prop_p.
638 (push_display_prop): xassert that we are iterating a buffer.
639 (push_it, pop_it): Save and restore paragraph_embedding member.
640 (handle_single_display_spec, next_overlay_string)
641 (get_overlay_strings_1, reseat_1, reseat_to_string)
642 (push_display_prop): Set up the `unibyte' member of bidi_it.string
643 correctly. Don't assume unibyte strings are not bidi-reordered.
644 (compute_display_string_pos)
645 (compute_display_string_end): Fix handling the case of C string.
646 (push_it, pop_it): Save and restore from_disp_prop_p.
647 (handle_single_display_spec, push_display_prop): Set the
648 from_disp_prop_p flag.
649 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
650 (pop_it): Call iterate_out_of_display_property only if we are
651 popping after iteration over a string that came from a display
652 property. Fix a typo in popping stretch info. Add an assertion
653 for verifying that the iterator position is in sync with the bidi
654 iterator.
655 (handle_single_display_spec, get_overlay_strings_1)
656 (push_display_prop): Fix initialization of paragraph direction for
657 string when that of the parent object is not yet determined.
658 (reseat_1): Call bidi_init_it to resync the bidi
659 iterator with IT's position. (Bug#7616)
660 (find_row_edges): If ROW->start.pos gives position
661 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
662 (handle_stop, back_to_previous_visible_line_start, reseat_1):
663 Reset the from_disp_prop_p flag.
664 (SAVE_IT, RESTORE_IT): New macros.
665 (pos_visible_p, face_before_or_after_it_pos)
666 (back_to_previous_visible_line_start)
667 (move_it_in_display_line_to, move_it_in_display_line)
668 (move_it_to, move_it_vertically_backward, move_it_by_lines)
669 (try_scrolling, redisplay_window, display_line): Use them when
670 saving a temporary copy of the iterator and restoring it back.
671 (back_to_previous_visible_line_start, reseat_1)
672 (init_iterator): Empty the bidi cache "stack".
673 (move_it_in_display_line_to): If iterator ended up at
674 EOL, but we never saw any buffer positions smaller than
675 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
676 motion in bidi-reordered lines.
677 (move_it_in_display_line_to): Record prev_method and prev_pos
678 immediately before the call to set_iterator_to_next. Fixes cursor
679 motion in bidi-reordered lines with stretch glyphs and strings
680 displayed in margins. (Bug#8133) (Bug#8867)
681 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
682 TO_CHARPOS.
683 (pos_visible_p): Support positions in bidi-reordered lines. Save
684 and restore bidi cache.
685
686 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
687 (bidi_paragraph_info): Delete unused struct.
688 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
689 (bidi_cache_start): New variable.
690 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
691 to zero.
692 (bidi_cache_fetch_state, bidi_cache_search)
693 (bidi_cache_find_level_change, bidi_cache_iterator_state)
694 (bidi_cache_find, bidi_peek_at_next_level)
695 (bidi_level_of_next_char, bidi_find_other_level_edge)
696 (bidi_move_to_visually_next): Compare cache index with
697 bidi_cache_start rather than with zero.
698 (bidi_fetch_char): Accept new argument STRING; all callers
699 changed. Support iteration over a string. Support strings with
700 display properties. Support unibyte strings. Fix the type of
701 `len' according to what STRING_CHAR_AND_LENGTH expects.
702 (bidi_paragraph_init, bidi_resolve_explicit_1)
703 (bidi_resolve_explicit, bidi_resolve_weak)
704 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
705 iteration over a string.
706 (bidi_set_sor_type, bidi_resolve_explicit_1)
707 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
708 can now be zero (for strings); special values 0 and -1 were
709 changed to -1 and -2, respectively.
710 (bidi_char_at_pos): New function.
711 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
712 Call it instead of FETCH_MULTIBYTE_CHAR.
713 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
714 initialized to valid values.
715 (bidi_init_it): Don't initialize charpos and bytepos with invalid
716 values.
717 (bidi_level_of_next_char): Allow the sentinel "position" to pass
718 the test for valid cached positions. Fix the logic for looking up
719 the sentinel state in the cache. GCPRO the Lisp string we are
720 iterating.
721 (bidi_push_it, bidi_pop_it): New functions.
722 (bidi_initialize): Initialize the bidi cache start stack pointer.
723 (bidi_cache_ensure_space): New function, refactored from part of
724 bidi_cache_iterator_state. Don't assume the required size is just
725 one BIDI_CACHE_CHUNK away.
726 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
727 (bidi_count_bytes, bidi_char_at_pos): New functions.
728 (bidi_cache_search): Don't assume bidi_cache_last_idx is
729 always valid if bidi_cache_idx is valid.
730 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
731 is valid if it's going to be used.
732 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
733 (bidi_cache_fetch_state, bidi_cache_search)
734 (bidi_cache_find_level_change, bidi_cache_ensure_space)
735 (bidi_cache_iterator_state, bidi_cache_find)
736 (bidi_find_other_level_edge, bidi_cache_start_stack): All
737 variables related to cache indices are now EMACS_INT.
738
739 * dispextern.h (struct bidi_string_data): New structure.
740 (struct bidi_it): New member `string'. Make flag members be 1-bit
741 fields, and put them last in the struct.
742 (compute_display_string_pos, compute_display_string_end): Update
743 prototypes.
744 (bidi_push_it, bidi_pop_it): Add prototypes.
745 (struct iterator_stack_entry): New members bidi_p,
746 paragraph_embedding, and from_disp_prop_p.
747 (struct it): Member bidi_p is now a bit field 1 bit wide.
748 (bidi_shelve_cache, bidi_unshelve_cache): Declare
749 prototypes.
750
751 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
752 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
753 and vector-like objects.
754
755 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
756 cache around display iteration.
757
758 * window.c (Fwindow_end, window_scroll_pixel_based)
759 (displayed_window_lines, Frecenter): Save and restore the bidi
760 cache around display iteration.
761
762 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
763
764 * editfns.c (Fdelete_region): Clarify the use of the named
765 parameters (bug#6788).
766
767 2011-07-14 Martin Rudalics <rudalics@gmx.at>
768
769 * indent.c (Fvertical_motion): Set and restore w->pointm when
770 saving and restoring the window's buffer (Bug#9006).
771
772 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
773
774 * editfns.c (Fstring_to_char): Clarify just what is returned
775 (bug#6576). Text by Eli Zaretskii.
776
777 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
778
779 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
780
781 2011-07-13 Eli Zaretskii <eliz@gnu.org>
782
783 * buffer.c (mmap_find): Fix a typo.
784
785 2011-07-13 Johan Bockgård <bojohan@gnu.org>
786
787 Fix execution of x selection hooks.
788 * xselect.c (Qx_lost_selection_functions)
789 (Qx_sent_selection_functions): New vars.
790 (syms_of_xselect): DEFSYM them.
791 (x_handle_selection_request): Pass Qx_sent_selection_functions
792 rather than Vx_sent_selection_functions to Frun_hook_with_args.
793 (x_handle_selection_clear,x_clear_frame_selections):
794 Pass Qx_lost_selection_functions rather than
795 Vx_lost_selection_functions to Frun_hook_with_args.
796
797 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
798
799 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
800 The old code sometimes used this field without initializing it.
801
802 * alloc.c (gc_sweep): Don't read past end of array.
803 In theory, the old code could also have corrupted Emacs internals,
804 though it'd be very unlikely.
805
806 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
807
808 * character.c (Fcharacterp): Don't advertise optional ignored
809 argument. (Bug#4026)
810
811 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
812
813 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
814 key" (bug#4257).
815
816 * window.c (Fset_window_start): Doc fix (bug#4199).
817 (Fset_window_hscroll): Ditto.
818
819 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
820
821 Fix minor new problems caught by GCC 4.6.1.
822 * term.c (init_tty): Remove unused local.
823 * xsettings.c (store_monospaced_changed): Define this function only
824 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
825 not used otherwise.
826
827 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
828
829 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
830
831 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
832
833 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
834 are the mini-buffer and the echo area (bug#3320).
835
836 * term.c (init_tty): Remove support for supdup, c10 and perq
837 terminals, which are no longer supported (bug#1482).
838
839 2011-07-10 Johan Bockgård <bojohan@gnu.org>
840
841 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
842
843 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
844
845 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
846 for non-popups (Bug#3642).
847
848 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
849
850 * alloc.c (reset_malloc_hooks): Protoize.
851 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
852 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
853 * cm.c (losecursor): Likewise.
854 * data.c (fmod): Likewise.
855 * dispnew.c (swap_glyphs_in_rows): Likewise.
856 * emacs.c (memory_warning_signal): Likewise.
857 * floatfns.c (float_error): Likewise.
858 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
859 (otf_open, font_otf_capability, generate_otf_features)
860 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
861 Likewise.
862 * image.c (pbm_read_file): Likewise.
863 * indent.c (string_display_width): Likewise.
864 * intervals.c (check_for_interval, search_for_interval)
865 (inc_interval_count, count_intervals, root_interval)
866 (adjust_intervals_for_insertion, make_new_interval): Likewise.
867 * lread.c (defalias): Likewise.
868 * ralloc.c (r_alloc_check): Likewise.
869 * regex.c (set_image_of_range_1, set_image_of_range)
870 (regex_grow_registers): Likewise.
871 * sysdep.c (strerror): Likewise.
872 * termcap.c (valid_filename_p, tprint, main): Likewise.
873 * tparam.c (main): Likewise.
874 * unexhp9k800.c (run_time_remap, save_data_space)
875 (update_file_ptrs, read_header, write_header, calculate_checksum)
876 (copy_file, copy_rest, display_header): Likewise.
877 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
878 Likewise.
879 * xdisp.c (check_it): Likewise.
880 * xfaces.c (register_color, unregister_color, unregister_colors):
881 Likewise.
882 * xfns.c (print_fontset_result): Likewise.
883 * xrdb.c (member, fatal, main): Likewise.
884
885 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
886
887 Fix minor problems found by static checking (Bug#9031).
888 * chartab.c (char_table_set_range, map_sub_char_table):
889 Remove unused locals.
890 (uniprop_table): Now static.
891 * composite.c (_work_char): Remove unused static var.
892
893 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
894
895 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
896
897 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
898
899 * gtkutil.c (qttip_cb): Remove code without function.
900
901 2011-07-09 Eli Zaretskii <eliz@gnu.org>
902
903 * w32.c (pthread_sigmask): New stub.
904
905 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
906
907 Use pthread_sigmask, not sigprocmask (Bug#9010).
908 sigprocmask is portable only for single-threaded applications, and
909 Emacs can be multi-threaded when it uses GTK.
910 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
911 (LIBES): Use it.
912 * callproc.c (Fcall_process):
913 * process.c (create_process):
914 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
915 Use pthread_sigmask, not sigprocmask.
916
917 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
918
919 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
920 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
921 wrong (Bug#8591).
922
923 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
924
925 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
926 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
927 (xg_hide_tooltip): Fix comment.
928
929 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
930 in registerServicesMenuSendTypes.
931 (validRequestorForSendType): Don't check ns_return_types.
932
933 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
934 ns_return_type.
935
936 2011-07-08 Jason Rumney <jasonr@gnu.org>
937
938 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
939 frame struct members of non-existent frames (Bug#6284).
940
941 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
942
943 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
944 variable firstTime not needed on OSX >= 10.6.
945 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
946 >= 10.5. Use setKnobProportion, setDoubleValue.
947
948 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
949 (MAC_OS_X_VERSION_10_5): Define if not defined.
950 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
951 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
952 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
953
954 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
955 cString and lossyCString on OSX >= 10.4
956
957 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
958 sizeToFit on OSX >= 10.2.
959
960 * nsimage.m (allocInitFromFile): Don't use deprecated method
961 bestRepresentationForDevice on OSX >= 10.6.
962
963 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
964 to avoid warning.
965
966 * emacs.c: Declare unexec_init_emacs_zone.
967
968 * nsgui.h: Fix compiler warning about gnulib redefining verify.
969
970 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
971
972 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
973 on svcsMenu (Bug#8842).
974
975 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
976 ns_return_types.
977 (Fns_list_services): Just return Qnil on 10.6, code not working there.
978
979 * nsterm.m (QUTF8_STRING): Declare.
980 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
981 (validRequestorForSendType): Return type is (id).
982 Change indexOfObjectIdenticalTo to indexOfObject.
983 Check if we have local selection before returning self (Bug#8842).
984 (writeSelectionToPasteboard): Put local selection into paste board
985 if we have a local selection (Bug#8842).
986 (syms_of_nsterm): DEFSYM QUTF8_STRING.
987
988 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
989 (ns_get_local_selection): Declare.
990
991 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
992
993 * keymap.c (describe_map_tree): Don't insert a double newline at
994 the end of the buffer (bug#1169) and return whether we inserted
995 something.
996
997 * callint.c (Fcall_interactively): Change "reading args" to
998 "providing args" to try to clarify what it does (bug#1010).
999
1000 2011-07-07 Kenichi Handa <handa@m17n.org>
1001
1002 * composite.c (composition_compute_stop_pos): Ignore a static
1003 composition starting before CHARPOS (Bug#8915).
1004
1005 * xdisp.c (handle_composition_prop): Likewise.
1006
1007 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1008
1009 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1010 (Bug#9015)
1011
1012 2011-07-07 Kenichi Handa <handa@m17n.org>
1013
1014 * character.h (unicode_category_t): New enum type.
1015
1016 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1017 (Qchar_code_property_table): New variable.
1018 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1019 (UNIPROP_COMPRESSED_FORM_P): New macros.
1020 (char_table_ascii): Uncompress the compressed values.
1021 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1022 Uncompress the compressed values.
1023 (sub_char_table_ref_and_range): Likewise.
1024 (char_table_ref_and_range): Uncompress the compressed values.
1025 (sub_char_table_set): New arg is_uniprop. Callers changed.
1026 Uncompress the compressed values.
1027 (sub_char_table_set_range): Args changed. Callers changed.
1028 (char_table_set_range): Adjuted for the above change.
1029 (map_sub_char_table): Delete args default_val and parent. Add arg
1030 top. Give decoded values to a Lisp function.
1031 (map_char_table): Adjusted for the above change. Give decoded
1032 values to a Lisp function. Gcpro more variables.
1033 (uniprop_table_uncompress)
1034 (uniprop_decode_value_run_length): New functions.
1035 (uniprop_decoder, uniprop_decoder_count): New variables.
1036 (uniprop_get_decoder, uniprop_encode_value_character)
1037 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1038 New functions.
1039 (uniprop_encoder, uniprop_encoder_count): New variables.
1040 (uniprop_get_encoder, uniprop_table)
1041 (Funicode_property_table_internal, Fget_unicode_property_internal)
1042 (Fput_unicode_property_internal): New functions.
1043 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1044 Sunicode_property_table_internal, Sget_unicode_property_internal,
1045 and Sput_unicode_property_internal. Defvar_lisp
1046 char-code-property-alist.
1047
1048 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
1049 Vunicode_category_table.
1050
1051 * font.c (font_range): Adjusted for the change of
1052 Vunicode_category_table.
1053
1054 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1055
1056 * m/iris4d.h: Remove file, move contents ...
1057 * s/irix6-5.h: ... here.
1058
1059 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1060
1061 Remove unportable assumption about struct layout (Bug#8884).
1062 * alloc.c (mark_buffer):
1063 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1064 (clone_per_buffer_values): Don't assume that
1065 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1066 This isn't true in general, and it's particularly not true
1067 if Emacs is configured with --with-wide-int.
1068 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1069 New macros, used in the buffer.c change.
1070
1071 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1072
1073 * xsettings.c: Use both GConf and GSettings if both are available.
1074 (store_config_changed_event): Add comment.
1075 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1076 (store_tool_bar_style_changed): New functions.
1077 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1078 (struct xsettings): Move font inside HAVE_XFT.
1079 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1080 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
1081 Move inside HAVE_XFT.
1082 (something_changed_gsettingsCB): Renamed from something_changedCB.
1083 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1084 also.
1085 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1086 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1087 (something_changed_gconfCB): Renamed from something_changedCB.
1088 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1089 (parse_settings): Move check for font inside HAVE_XFT.
1090 (read_settings, apply_xft_settings): Add comment.
1091 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1092 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1093 call store_font_name_changed.
1094 (xft_settings_event): Add comment.
1095 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1096 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1097 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1098 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1099 (xsettings_initialize): Call init_gsettings last.
1100 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
1101 comment.
1102
1103 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1104
1105 Random fixes. E.g., (random) never returned negative values.
1106 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1107 subseconds part to the entropy, as that's a bit more random.
1108 Prefer signed to unsigned, since the signedness doesn't matter and
1109 in general we prefer signed. When given a limit, use a
1110 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1111 latter isn't right if USE_2_TAGS_FOR_INTS.
1112 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1113 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1114
1115 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1116
1117 * textprop.c (text_property_stickiness):
1118 Obey Vtext_property_default_nonsticky.
1119 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1120 * w32fns.c (syms_of_w32fns):
1121 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1122
1123 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1124
1125 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1126 This is more efficient than Ffile_directory_p and avoids a minor race.
1127
1128 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1129
1130 * buffer.c (Foverlay_put): Say what the return value is
1131 (bug#7835).
1132
1133 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1134 is a directory before asking whether to use the file name
1135 (bug#7564).
1136 (barf_or_query_if_file_exists): Make the "File is a directory"
1137 error be more correct.
1138
1139 * fns.c (Frequire): Remove the mention of the .gz files, since
1140 that's installation-specific, but keep the mention of
1141 `get-load-suffixes'.
1142
1143 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1144
1145 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1146 Report string overflow if the output is too long.
1147
1148 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1149
1150 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1151 (syms_of_gnutls): Remove duplicate DEFSYM for
1152 Qgnutls_bootprop_verify_hostname_error, an error for
1153 Qgnutls_bootprop_verify_error (which is no longer used).
1154
1155 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1156 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1157 Also (re)move comments that are misplaced or no longer relevant.
1158
1159 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1160
1161 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1162
1163 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1164
1165 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1166 and background color parameters if they have been changed.
1167
1168 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1169
1170 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1171
1172 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1173
1174 * xsettings.c (SYSTEM_FONT): Define only when used.
1175 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1176
1177 * keymap.c (access_keymap_1): Now static.
1178
1179 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1180
1181 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1182 leave any prefix arg for the up event (Bug#1586).
1183
1184 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1185
1186 * lread.c (syms_of_lread): Mention single symbols defined by
1187 `defvar' or `defconst' (bug#7154).
1188
1189 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1190 (Frequire): Mention get-load-suffixes.
1191
1192 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1193
1194 * window.h (window): Remove clone_number slot.
1195 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1196 Remove.
1197 (make_parent_window, make_window, saved_window)
1198 (Fset_window_configuration, save_window_save): Don't deal with
1199 clone numbers.
1200 * buffer.c (Qclone_number): Remove declaration.
1201 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1202
1203 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1204
1205 Add multiple inheritance to keymaps.
1206 * keymap.c (Fmake_composed_keymap): New function.
1207 (Fset_keymap_parent): Simplify.
1208 (fix_submap_inheritance): Remove.
1209 (access_keymap_1): New function extracted from access_keymap to handle
1210 embedded parents and handle lists of maps.
1211 (access_keymap): Use it.
1212 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1213 (Fcopy_keymap): Handle embedded parents.
1214 (Fcommand_remapping, define_as_prefix): Simplify.
1215 (Fkey_binding): Simplify.
1216 (syms_of_keymap): Move minibuffer-local-completion-map,
1217 minibuffer-local-filename-completion-map,
1218 minibuffer-local-must-match-map, and
1219 minibuffer-local-filename-must-match-map to Elisp.
1220 (syms_of_keymap): Defsubr make-composed-keymap.
1221 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1222 (parse_menu_item): Trivial simplification.
1223
1224 2011-07-01 Glenn Morris <rgm@gnu.org>
1225
1226 * Makefile.in (SETTINGS_LIBS): Fix typo.
1227
1228 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1229
1230 * coding.c (Fencode_coding_string): Record the last coding system
1231 used, as the function doc string says (bug#8738).
1232
1233 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1234
1235 * xsettings.c (store_monospaced_changed): Take new font as arg and
1236 check for change against current_mono_font.
1237 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1238 (emacs_settings_constructor, emacs_settings_get_property)
1239 (emacs_settings_set_property, emacs_settings_class_init)
1240 (emacs_settings_init, gsettings_obj): Remove.
1241 (something_changedCB): New function for HAVE_GSETTINGS.
1242 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1243 with value as argument.
1244 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1245 g_settings_new (Bug#8967). Do not create gsettings_obj.
1246 Remove calls to g_settings_bind. Connect something_changedCB to
1247 "changed".
1248
1249 * xgselect.c: Add defined (HAVE_GSETTINGS).
1250 (xgselect_initialize): Ditto.
1251
1252 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1253 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1254 xg_select.
1255
1256 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1257
1258 * eval.c (struct backtrace): Simplify and port the data structure.
1259 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1260 signed bit field, as this assumption is not portable and it makes
1261 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1262 "char debug_on_exit : 1" as this is not portable either; instead,
1263 use the portable "unsigned int debug_on_exit : 1". Remove unused
1264 member evalargs. Remove obsolete comments about cc bombing out.
1265
1266 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1267
1268 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1269 Let HAVE_GSETTINGS override HAVE_GCONF.
1270 (store_monospaced_changed): New function.
1271 (EMACS_SETTINGS): A new type derived from GObject to handle
1272 GSettings notifications.
1273 (emacs_settings_constructor, emacs_settings_get_property)
1274 (emacs_settings_set_property, emacs_settings_class_init):
1275 New functions.
1276 (gsettings_client, gsettings_obj): New variables.
1277 (GSETTINGS_SCHEMA): New define.
1278 (something_changedCB): Call store_monospaced_changed.
1279 (init_gsettings): New function.
1280 (xsettings_initialize): Call init_gsettings.
1281 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1282 to NULL.
1283
1284 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1285 GCONF_CFLAGS/LIBS.
1286
1287 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1288
1289 * window.c (resize_root_window, grow_mini_window)
1290 (shrink_mini_window): Rename Qresize_root_window to
1291 Qwindow_resize_root_window and Qresize_root_window_vertically to
1292 Qwindow_resize_root_window_vertically.
1293
1294 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1295
1296 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1297
1298 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1299
1300 * makefile.w32-in: Redesign dependencies so they reflect more
1301 clearly which files are directly included by each source file,
1302 and not through other includes.
1303
1304 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1305
1306 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1307 (sort_overlays, overlay_strings): When an overlay's clone number
1308 matches the window's clone number process the overlay even if
1309 the overlay's window property doesn't match the current window.
1310
1311 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1312 (Fwindow_hchild): Rename to Fwindow_left_child.
1313 (Fwindow_next): Rename to Fwindow_next_sibling.
1314 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1315 (resize_window_check): Rename to window_resize_check.
1316 (resize_window_apply): Rename to window_resize_apply.
1317 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1318 (Fdelete_other_windows_internal, resize_frame_windows)
1319 (Fsplit_window_internal, Fdelete_window_internal)
1320 (grow_mini_window, shrink_mini_window)
1321 (Fresize_mini_window_internal): Fix callers accordingly.
1322
1323 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1324
1325 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1326 (emacs_fixed_set_min_size): Remove.
1327 (emacs_fixed_new): Take frame as argument.
1328
1329 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1330 (_EmacsFixedPrivate): Remove minwidth/height.
1331 Add struct frame *f.
1332 (emacs_fixed_init): Initialize priv->f.
1333 (get_parent_class, emacs_fixed_set_min_size): Remove.
1334 (emacs_fixed_new): Set priv->f to argument.
1335 (emacs_fixed_get_preferred_width)
1336 (emacs_fixed_get_preferred_height): Use min_width/height from
1337 frames size_hint to set minimum and natural (Bug#8919).
1338 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1339 and use min_width/height from frames size_hint to set
1340 min_width/height (Bug#8919).
1341
1342 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1343 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1344 Fix indentation.
1345
1346 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1347
1348 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1349 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1350 called at ZV.
1351
1352 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1353
1354 * process.c (wait_reading_process_output): Bypass select if
1355 waiting for a cell while ignoring keyboard input, and input is
1356 pending. Suggested by Jan Djärv (Bug#8869).
1357
1358 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1359
1360 Use gnulib's dup2 module instead of rolling our own.
1361 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1362
1363 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1364
1365 * dispnew.c (scrolling_window): Before scrolling, turn off a
1366 mouse-highlight in the window being scrolled.
1367
1368 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1369
1370 Move DEFSYM to lisp.h and use everywhere.
1371
1372 * character.h (DEFSYM): Move declaration...
1373 * lisp.h (DEFSYM): ...here.
1374
1375 * gnutls.c:
1376 * minibuf.c:
1377 * w32menu.c:
1378 * w32proc.c:
1379 * w32select.c: Don't include character.h.
1380
1381 * alloc.c (syms_of_alloc):
1382 * buffer.c (syms_of_buffer):
1383 * bytecode.c (syms_of_bytecode):
1384 * callint.c (syms_of_callint):
1385 * casefiddle.c (syms_of_casefiddle):
1386 * casetab.c (init_casetab_once):
1387 * category.c (init_category_once, syms_of_category):
1388 * ccl.c (syms_of_ccl):
1389 * cmds.c (syms_of_cmds):
1390 * composite.c (syms_of_composite):
1391 * dbusbind.c (syms_of_dbusbind):
1392 * dired.c (syms_of_dired):
1393 * dispnew.c (syms_of_display):
1394 * doc.c (syms_of_doc):
1395 * editfns.c (syms_of_editfns):
1396 * emacs.c (syms_of_emacs):
1397 * eval.c (syms_of_eval):
1398 * fileio.c (syms_of_fileio):
1399 * fns.c (syms_of_fns):
1400 * frame.c (syms_of_frame):
1401 * fringe.c (syms_of_fringe):
1402 * insdel.c (syms_of_insdel):
1403 * keymap.c (syms_of_keymap):
1404 * lread.c (init_obarray, syms_of_lread):
1405 * macros.c (syms_of_macros):
1406 * msdos.c (syms_of_msdos):
1407 * print.c (syms_of_print):
1408 * process.c (syms_of_process):
1409 * search.c (syms_of_search):
1410 * sound.c (syms_of_sound):
1411 * syntax.c (init_syntax_once, syms_of_syntax):
1412 * terminal.c (syms_of_terminal):
1413 * textprop.c (syms_of_textprop):
1414 * undo.c (syms_of_undo):
1415 * w32.c (globals_of_w32):
1416 * window.c (syms_of_window):
1417 * xdisp.c (syms_of_xdisp):
1418 * xfaces.c (syms_of_xfaces):
1419 * xfns.c (syms_of_xfns):
1420 * xmenu.c (syms_of_xmenu):
1421 * xsettings.c (syms_of_xsettings):
1422 * xterm.c (syms_of_xterm): Use DEFSYM.
1423
1424 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1425
1426 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1427
1428 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1429
1430 Integer and buffer overflow fixes (Bug#8873).
1431
1432 * print.c (printchar, strout): Check for string overflow.
1433 (PRINTPREPARE, printchar, strout):
1434 Don't set size unless allocation succeeds.
1435
1436 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1437 for sizes. Check for string overflow more accurately.
1438 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1439
1440 * macros.c: Integer and buffer overflow fixes.
1441 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1442 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1443 Use ptrdiff_t, not int, for sizes.
1444 Don't increment bufsize until after realloc succeeds.
1445 Check for size-calculation overflow.
1446 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1447
1448 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1449
1450 * lread.c: Integer overflow fixes.
1451 (read_integer): Radix is now EMACS_INT, not int,
1452 to improve quality of diagnostics for out-of-range radices.
1453 Calculate buffer size correctly for out-of-range radices.
1454 (read1): Check for integer overflow in radices, and in
1455 read-circle numbers.
1456 (read_escape): Avoid int overflow.
1457 (Fload, openp, read_buffer_size, read1)
1458 (substitute_object_recurse, read_vector, read_list, map_obarray):
1459 Use ptrdiff_t, not int, for sizes.
1460 (read1): Use EMACS_INT, not int, for sizes.
1461 Check for size overflow.
1462
1463 * image.c (cache_image): Check for size arithmetic overflow.
1464
1465 * lread.c: Integer overflow issues.
1466 (saved_doc_string_size, saved_doc_string_length)
1467 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1468 Now ptrdiff_t, not int.
1469 (read1): Don't assume doc string length fits in int. Check for
1470 out-of-range doc string lengths.
1471 (read_list): Don't assume file position fits in int.
1472 (read_escape): Check for hex character overflow.
1473
1474 2011-06-22 Leo Liu <sdl.web@gmail.com>
1475
1476 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1477 Move to minibuffer.el.
1478
1479 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1480
1481 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1482 The following patches are for when GLYPH_DEBUG && !XASSERT.
1483 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1484 * dispnew.c (flush_stdout):
1485 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1486 Mark as externally visible.
1487 * dispnew.c (check_window_matrix_pointers): Now static.
1488 * dispnew.c (window_to_frame_vpos):
1489 * xfns.c (unwind_create_frame):
1490 * xterm.c (x_check_font): Remove unused local.
1491 * scroll.c (CHECK_BOUNDS):
1492 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1493 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1494 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1495 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1496 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1497 Now static.
1498 (debug_method_add): Use va_list and vsprintf rather than relying
1499 on undefined behavior with wrong number of arguments.
1500 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1501 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1502 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1503 since we're not interested in debugging glyphs with old libraries.
1504 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1505 GCC 4.6.0's static checking.
1506
1507 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1508
1509 Integer overflow and signedness fixes (Bug#8873).
1510 A few related buffer overrun fixes, too.
1511
1512 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1513
1514 * dispextern.h (struct face.stipple):
1515 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1516 (x_bitmap_mask, x_allocate_bitmap_record)
1517 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1518 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1519 (x_create_bitmap_from_xpm_data):
1520 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1521 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1522 (.bitmaps_last):
1523 * xfaces.c (load_pixmap):
1524 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1525 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1526 (.bitmaps_last, struct x_output.icon_bitmap):
1527 Use ptrdiff_t, not int, for bitmap indexes.
1528 (x_allocate_bitmap_record): Check for size overflow.
1529 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1530
1531 Use ptrdiff_t, not int, for overlay counts.
1532 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1533 * editfns.c (overlays_around, get_pos_property):
1534 * textprop.c (get_char_property_and_overlay):
1535 * xdisp.c (next_overlay_change, note_mouse_highlight):
1536 * xfaces.c (face_at_buffer_position):
1537 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1538 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1539 (Fnext_overlay_change, Fprevious_overlay_change)
1540 (mouse_face_overlay_overlaps, Foverlays_in):
1541 Use ptrdiff_t, not int, for sizes.
1542 (overlays_at, overlays_in): Check for size-calculation overflow.
1543
1544 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1545
1546 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1547 (x_session_initialize): Do not assume string length fits in int.
1548
1549 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1550 This is unlikely, but can occur if DPI is outlandish.
1551
1552 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1553 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1554
1555 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1556 * xrdb.c (magic_file_p, search_magic_path):
1557 Omit last arg SUFFIX; it was always 0. All callers changed.
1558 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1559
1560 * xfont.c (xfont_match): Avoid need for strlen.
1561
1562 * xfns.c: Don't assume strlen fits in int.
1563 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1564
1565 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1566 not unsigned long, as we prefer signed integers. All callers changed.
1567 Detect integer overflow in repeat count.
1568 (message_dolog): Don't assume print length fits in 39 bytes.
1569 (display_mode_element): Don't assume strlen fits in int.
1570
1571 * termcap.c: Don't assume sizes fit in int and never overflow.
1572 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1573 (gobble_line): Check for size-calculation overflow.
1574
1575 * minibuf.c (Fread_buffer):
1576 * lread.c (intern, intern_c_string):
1577 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1578 Don't assume string length fits in int.
1579
1580 * keyboard.c (parse_tool_bar_item):
1581 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1582
1583 * font.c: Don't assume string length fits in int.
1584 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1585 Use ptrdiff_t, not int.
1586 (font_intern_prop): Don't assume string length fits in int.
1587 Don't assume integer property fits in fixnum.
1588 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1589
1590 * filelock.c: Fix some buffer overrun and integer overflow issues.
1591 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1592 Reformulate so as not to need the command string.
1593 Invoke gzip -cd rather than gunzip, as it's more portable.
1594 (lock_info_type, lock_file_1, lock_file):
1595 Don't assume pid_t and time_t fit in unsigned long.
1596 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1597 (current_lock_owner): Prefer signed type for sizes.
1598 Use memcpy, not strncpy, where memcpy is what is really wanted.
1599 Don't assume (via atoi) that time_t and pid_t fit in int.
1600 Check for time_t and/or pid_t out of range, e.g., via a network share.
1601 Don't alloca where an auto var works fine.
1602
1603 * fileio.c: Fix some integer overflow issues.
1604 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1605 Don't assume string length fits in int.
1606 (directory_file_name): Don't assume string length fits in long.
1607 (make_temp_name): Don't assume pid fits in int, or that its print
1608 length is less than 20.
1609
1610 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1611
1612 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1613
1614 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1615
1616 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1617 We prefer signed integers, even for size calculations.
1618
1619 * emacs.c: Don't assume string length fits in 'int'.
1620 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1621 (main): Don't invoke strlen when not needed.
1622
1623 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1624 (XD_DEBUG_MESSAGE): Don't waste a byte.
1625
1626 * callproc.c (getenv_internal_1, getenv_internal)
1627 (Fgetenv_internal):
1628 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1629
1630 * lread.c (invalid_syntax): Omit length argument.
1631 All uses changed. This doesn't fix a bug, but it simplifies the
1632 code away from its former Hollerith-constant appearance, and it's
1633 one less 'int' to worry about when looking at integer-overflow issues.
1634 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1635
1636 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1637 This didn't break anything, but it didn't help either.
1638 It's confusing to put a bogus integer in a place where the actual
1639 value does not matter.
1640 (LIST_END_P): Remove unused macro and its bogus comment.
1641 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1642
1643 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1644 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1645 implementation.
1646 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1647 We prefer signed types, and the value cannot exceed the EMACS_INT
1648 range anyway (because otherwise the length would not be representable).
1649 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1650 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1651 This avoids a GCC warning when WIDE_EMACS_INT.
1652
1653 * indent.c (sane_tab_width): New function.
1654 (current_column, scan_for_column, Findent_to, position_indentation)
1655 (compute_motion): Use it. This is just for clarity.
1656 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1657
1658 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1659
1660 * lisp.h (lint_assume): New macro.
1661 * composite.c (composition_gstring_put_cache):
1662 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1663
1664 * editfns.c, insdel.c:
1665 Omit unnecessary forward decls, to simplify future changes.
1666
1667 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1668
1669 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1670
1671 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1672 Use much-faster test for byte-length change.
1673 Don't assume string byte-length fits in 'int'.
1674 Check that character arg fits in 'int'.
1675 (mapcar1): Declare byte as byte, for clarity.
1676
1677 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1678
1679 * fns.c (concat): Catch string overflow earlier.
1680 Do not rely on integer wraparound.
1681
1682 * dispextern.h (struct it.overlay_strings_charpos)
1683 (struct it.selective): Now EMACS_INT, not int.
1684 * xdisp.c (forward_to_next_line_start)
1685 (back_to_previous_visible_line_start)
1686 (reseat_at_next_visible_line_start, next_element_from_buffer):
1687 Don't arbitrarily truncate the value of 'selective' to int.
1688
1689 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1690
1691 * composite.c: Don't truncate sizes to 'int'.
1692 (composition_gstring_p, composition_reseat_it)
1693 (composition_adjust_point): Use EMACS_INT, not int.
1694 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1695 not EMACS_UINT, for indexes.
1696
1697 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1698
1699 * buffer.c: Include <verify.h>.
1700 (struct sortvec.priority, struct sortstr.priority):
1701 Now EMACS_INT, not int.
1702 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1703 (struct sortstr.size, record_overlay_string)
1704 (struct sortstrlist.size, struct sortlist.used):
1705 Don't truncate size to int.
1706 (record_overlay_string): Check for size-calculation overflow.
1707 (init_buffer_once): Check at compile-time, not run-time.
1708
1709 2011-06-22 Jim Meyering <meyering@redhat.com>
1710
1711 Don't leak an XBM-image-sized buffer
1712 * image.c (xbm_load): Free the image buffer after using it.
1713
1714 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1715
1716 Port to Sun C.
1717 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1718 that Sun C diagnosed.
1719 * fns.c (secure_hash): Fix pointer signedness issue.
1720 * intervals.c (static_offset_intervals): New function.
1721 (offset_intervals): Use it.
1722
1723 2011-06-21 Leo Liu <sdl.web@gmail.com>
1724
1725 * deps.mk (fns.o):
1726 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1727 sha512.h.
1728
1729 * fns.c (secure_hash): Rename from crypto_hash_function and change
1730 the first arg to accept symbols.
1731 (Fsecure_hash): New primitive.
1732 (syms_of_fns): New symbols.
1733
1734 2011-06-20 Deniz Dogan <deniz@dogan.se>
1735
1736 * process.c (Fset_process_buffer): Clarify return value in
1737 docstring.
1738
1739 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1740
1741 * dispnew.c (add_window_display_history): Use BVAR.
1742
1743 * xdisp.c (debug_method_add): Use BVAR.
1744 (check_window_end, dump_glyph_matrix, dump_glyph)
1745 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1746
1747 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1748 Likewise.
1749
1750 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1751 check till after the cache is created in init_frame_faces.
1752
1753 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1754
1755 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1756
1757 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1758
1759 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1760 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1761 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1762
1763 Improve buffer-overflow checking (Bug#8873).
1764 * fileio.c (Finsert_file_contents):
1765 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1766 Remove the old (too-loose) buffer overflow checks.
1767 They weren't needed, since make_gap checks for buffer overflow.
1768 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1769 The old code merely checked for Emacs fixnum overflow, and relied
1770 on undefined (wraparound) behavior. The new code avoids undefined
1771 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1772
1773 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1774 Tune. Don't use wider integers than needed. Don't use alloca.
1775 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1776
1777 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1778
1779 * insdel.c, lisp.h (buffer_overflow): New function.
1780 (insert_from_buffer_1, replace_range, replace_range_2):
1781 * insdel.c (make_gap_larger):
1782 * editfns.c (Finsert_char):
1783 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1784
1785 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1786
1787 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1788
1789 Integer overflow and signedness fixes (Bug#8873).
1790
1791 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1792 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1793
1794 * fileio.c: Don't assume EMACS_INT fits in off_t.
1795 (emacs_lseek): New static function.
1796 (Finsert_file_contents, Fwrite_region): Use it.
1797 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1798
1799 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1800
1801 * fns.c: Don't overflow int when computing a list length.
1802 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1803 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1804 truncation on 64-bit hosts. Check for QUIT every
1805 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1806 faster and is responsive enough.
1807 (Flength): Report an error instead of overflowing an integer.
1808 (Fsafe_length): Return a float if the value is not representable
1809 as a fixnum. This shouldn't happen except in contrived situations.
1810 (Fnthcdr, Fsort): Don't assume list length fits in int.
1811 (Fcopy_sequence): Don't assume vector length fits in int.
1812
1813 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1814 (header_size, word_size): New constants.
1815 (allocate_vectorlike): Don't check size overflow here.
1816 (allocate_vector): Check it here instead, since this is the only
1817 caller of allocate_vectorlike that could cause overflow.
1818 Check that the new vector's length is representable as a fixnum.
1819
1820 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1821 The previous code was bogus. For example, next_almost_prime (32)
1822 returned 39, which is undesirable as it is a multiple of 3; and
1823 next_almost_prime (24) returned 25, which is a multiple of 5 so
1824 why was the code bothering to check for multiples of 7?
1825
1826 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1827
1828 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1829
1830 Variadic C functions now count arguments with ptrdiff_t.
1831 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1832 Back then I didn't know that the Emacs coding style prefers signed int.
1833 Also, in the meantime I found a few more instances where arguments
1834 were being counted with int, which may truncate counts on 64-bit
1835 machines, or EMACS_INT, which may be unnecessarily wide.
1836 * lisp.h (struct Lisp_Subr.function.aMANY)
1837 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1838 Arg counts are now ptrdiff_t, not size_t.
1839 All variadic functions and their callers changed accordingly.
1840 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1841 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1842 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1843 * callint.c (Fcall_interactively): Check arg count for overflow,
1844 to avoid potential buffer overrun. Use signed char, not 'int',
1845 for 'varies' array, so that we needn't bother to check its size
1846 calculation for overflow.
1847 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1848 * eval.c (apply_lambda):
1849 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1850 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1851 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1852
1853 * callint.c (Fcall_interactively): Don't use index var as event count.
1854
1855 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1856 * mem-limits.h (SIZE): Remove; no longer used.
1857
1858 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1859
1860 Remove unnecessary casts.
1861 * xterm.c (x_term_init):
1862 * xfns.c (x_set_border_pixel):
1863 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1864 These aren't needed now that we assume ANSI C.
1865
1866 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1867 It's more likely to cause problems (due to unsigned overflow)
1868 than to cure them.
1869
1870 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1871
1872 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1873
1874 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1875
1876 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1877
1878 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1879
1880 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1881
1882 GLYPH_CODE_FACE returns EMACS_INT, not int.
1883 * dispextern.h (merge_faces):
1884 * xfaces.c (merge_faces):
1885 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1886 Don't assume EMACS_INT fits in int.
1887
1888 * character.h (CHAR_VALID_P): Remove unused parameter.
1889 * fontset.c, lisp.h, xdisp.c: All uses changed.
1890
1891 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1892
1893 * fns.c (concat): Minor tuning based on overflow analysis.
1894 This doesn't fix any bugs. Use int to hold character, instead
1895 of constantly refetching from Emacs object. Use XFASTINT, not
1896 XINT, for value known to be a character. Don't bother comparing
1897 a single byte to 0400, as it's always less.
1898
1899 * floatfns.c (Fexpt):
1900 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1901
1902 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1903 for characters.
1904
1905 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1906
1907 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1908 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1909 incorrectly succeed when S was a string, because 4294967386 was
1910 truncated before it was used.
1911
1912 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1913 Otherwise, an out-of-range integer could cause undefined behavior
1914 on a 64-bit host.
1915
1916 * composite.c: Use int, not EMACS_INT, for characters.
1917 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1918 EMACS_INT, for values that are known to be in character range.
1919 This doesn't fix any bugs but is the usual style inside Emacs and
1920 may generate better code on 32-bit machines.
1921
1922 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1923 This is for reasons similar to the recent CHAR_STRING fix.
1924 * charset.c (Fencode_char): Check that character arg is actually
1925 a character. Pass an int to ENCODE_CHAR.
1926 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1927 wider than 'int', as a compile-time check to prevent future regressions
1928 in this area.
1929
1930 * character.c (char_string): Remove unnecessary casts.
1931
1932 Make sure a 64-bit char is never passed to CHAR_STRING.
1933 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1934 by silently ignoring the top 32 bits, allowing some values
1935 that were far too large to be valid characters.
1936 * character.h: Include <verify.h>.
1937 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1938 arguments are no wider than unsigned, as a compile-time check
1939 to prevent future regressions in this area.
1940 * data.c (Faset):
1941 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1942 (Fsubst_char_in_region):
1943 * fns.c (concat):
1944 * xdisp.c (decode_mode_spec_coding):
1945 Adjust to CHAR_STRING's new requirement.
1946 * editfns.c (Finsert_char, Fsubst_char_in_region):
1947 * fns.c (concat): Check that character args are actually
1948 characters. Without this test, these functions did the wrong
1949 thing with wildly out-of-range values on 64-bit hosts.
1950
1951 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1952 These casts should not be needed on 32-bit hosts, either.
1953 * keyboard.c (read_char):
1954 * lread.c (Fload): Remove casts to unsigned.
1955
1956 * lisp.h (UNSIGNED_CMP): New macro.
1957 This fixes comparison bugs on 64-bit hosts.
1958 (ASCII_CHAR_P): Use it.
1959 * casefiddle.c (casify_object):
1960 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1961 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1962 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1963 * dispextern.h (FACE_FROM_ID):
1964 * keyboard.c (read_char): Use UNSIGNED_CMP.
1965
1966 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1967 not to EMACS_INT, to avoid GCC warning.
1968
1969 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1970
1971 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1972 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1973 isn't needed on 32-bit machines.
1974
1975 * buffer.c (Fgenerate_new_buffer_name):
1976 Use EMACS_INT for count, not int.
1977 (advance_to_char_boundary): Return EMACS_INT, not int.
1978
1979 * data.c (Qcompiled_function): Now static.
1980
1981 * window.c (window_body_lines): Now static.
1982
1983 * image.c (gif_load): Rename local to avoid shadowing.
1984
1985 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1986 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1987 * alloc.c (make_save_value): Integer argument is now of type
1988 ptrdiff_t, not int.
1989 (mark_object): Use ptrdiff_t, not int.
1990 * lisp.h (pD): New macro.
1991 * print.c (print_object): Use it.
1992
1993 * alloc.c: Use EMACS_INT, not int, to count objects.
1994 (total_conses, total_markers, total_symbols, total_vector_size)
1995 (total_free_conses, total_free_markers, total_free_symbols)
1996 (total_free_floats, total_floats, total_free_intervals)
1997 (total_intervals, total_strings, total_free_strings):
1998 Now EMACS_INT, not int. All uses changed.
1999 (Fgarbage_collect): Compute overall total using a double, so that
2000 integer overflow is less likely to be a problem. Check for overflow
2001 when converting back to an integer.
2002 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2003 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2004 These were 'int' variables that could overflow on 64-bit hosts;
2005 they were never used, so remove them instead of repairing them.
2006 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2007 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2008 Previously, this ceilinged at INT_MAX, but that doesn't work on
2009 64-bit machines.
2010 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2011
2012 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2013 (allocate_vectorlike): Check for ptrdiff_t overflow.
2014 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2015 when a (possibly-narrower) signed value would do just as well.
2016 We prefer using signed arithmetic, to avoid comparison confusion.
2017
2018 * alloc.c: Catch some string size overflows that we were missing.
2019 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2020 for convenience in STRING_BYTES_MAX.
2021 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2022 The definition here is exact; the one in lisp.h was approximate.
2023 (allocate_string_data): Check for string overflow. This catches
2024 some instances we weren't catching before. Also, it catches
2025 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2026 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2027 and ptrdiff_t and EMACS_INT are both 64 bits.
2028
2029 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2030 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2031 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
2032
2033 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2034
2035 * alloc.c (Fmake_string): Check for out-of-range init.
2036
2037 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2038
2039 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2040
2041 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2042
2043 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2044 xg_get_default_scrollbar_width.
2045
2046 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2047 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2048 (style_changed_cb): Call update_theme_scrollbar_width and call
2049 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2050 all frames (Bug#8505).
2051 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2052 Call gtk_window_set_resizable if HAVE_GTK3.
2053 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2054 and height if HAVE_GTK3 (Bug#8505).
2055 (scroll_bar_width_for_theme): New variable.
2056 (update_theme_scrollbar_width): New function.
2057 (xg_get_default_scrollbar_width): Move code to
2058 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2059 (xg_initialize): Call update_theme_scrollbar_width.
2060
2061 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2062
2063 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2064
2065 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2066
2067 * frame.c (make_frame): Call other_buffer_safely instead of
2068 other_buffer.
2069
2070 * window.c (temp_output_buffer_show): Call display_buffer with
2071 second argument Vtemp_buffer_show_specifiers and reset latter
2072 immediately after the call.
2073 (Vtemp_buffer_show_specifiers): New variable.
2074 (auto_window_vscroll_p, next_screen_context_lines)
2075 (Vscroll_preserve_screen_position): Remove leading asterisks from
2076 doc-strings.
2077
2078 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2079
2080 Fix minor problems found by GCC 4.6.0 static checking.
2081 * buffer.c (Qclone_number): Remove for now, as it's unused.
2082 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2083 (record_buffer): Remove unused local.
2084 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2085 (set_frame_buffer_list): Remove; unused.
2086 * frame.h (other_visible_frames): Remove decl.
2087 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2088 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2089 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2090 if HAVE_GPM.
2091 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2092 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2093 Define only if HAVE_GPM.
2094 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2095 (update_hints_inhibit): Remove; never set. All uses removed.
2096 * widgetprv.h (emacsFrameClassRec): Remove decl.
2097 * window.c (delete_deletable_window): Now returns void, since it
2098 wasn't returning anything.
2099 (compare_window_configurations): Remove unused locals.
2100 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2101 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2102 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2103 the same widths as pointers. This follows up on the 2011-05-06 patch.
2104 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2105 * xterm.h: Likewise.
2106 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2107
2108 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2109
2110 * makefile.w32-in: Update dependencies.
2111 (LISP_H): Add lib/intprops.h.
2112
2113 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2114
2115 * image.c (gif_load): Add animation frame delay to the metadata.
2116 (syms_of_image): Use DEFSYM. New symbol `delay'.
2117
2118 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2119
2120 * window.c (delete_deletable_window): Re-add.
2121 (Fset_window_configuration): Rewrite to handle dead buffers and
2122 consequently deletable windows.
2123 (window_tree, Fwindow_tree): Remove. Supply functionality in
2124 window.el.
2125 (compare_window_configurations): Simplify code.
2126
2127 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2128
2129 * image.c (imagemagick_load_image): Fix type mismatch.
2130 (Fimagemagick_types): Likewise.
2131
2132 * window.h (replace_buffer_in_windows): Declare.
2133
2134 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2135
2136 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2137 Qclone_number. Remove external declaration of Qdelete_window.
2138 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2139 code.
2140 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
2141 Qbuffer_list_update_hook if allowed.
2142 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2143 buffer list implementation.
2144 (other_buffer_safely): New function.
2145 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2146 calls to replace_buffer_in_windows and
2147 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2148 if allowed.
2149 (record_buffer): Inhibit quitting and rewrite using quittable
2150 functions. Run Qbuffer_list_update_hook if allowed.
2151 (Frecord_buffer, Funrecord_buffer): New functions.
2152 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
2153 switch-to-buffer to window.el.
2154 (bury-buffer): Move to window.el.
2155 (Vbuffer_list_update_hook): New variable.
2156
2157 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2158 section.
2159
2160 * window.h (resize_frame_windows): Move up in code.
2161 (Fwindow_frame): Remove EXFUN.
2162 (replace_buffer_in_all_windows): Remove prototype.
2163 (replace_buffer_in_windows_safely): Add prototype.
2164
2165 * window.c: Declare Qdelete_window static again. Move down
2166 declaration of select_count.
2167 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2168 (Fother_window): Move to window.el.
2169 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2170 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2171 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2172 window.el.
2173 (replace_buffer_in_windows): Implement by calling
2174 Qreplace_buffer_in_windows.
2175 (replace_buffer_in_all_windows): Remove with some functionality
2176 moved into replace_buffer_in_windows_safely.
2177 (replace_buffer_in_windows_safely): New function.
2178 (select_window_norecord, select_frame_norecord): Move in front
2179 of run_window_configuration_change_hook. Remove now obsolete
2180 declarations.
2181 (Fset_window_buffer): Rewrite doc-string. Call
2182 Qrecord_window_buffer.
2183 (keys_of_window): Move binding for other-window to window.el.
2184
2185 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2186
2187 * dispextern.h (struct image): Replace data member, whose int_val
2188 and ptr_val fields were not used by anything, with a single
2189 lisp_val object.
2190
2191 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2192 (gif_clear_image, gif_load, imagemagick_load_image)
2193 (gs_clear_image, gs_load): Callers changed.
2194
2195 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2196
2197 * buffer.h: Include <time.h>, for time_t.
2198 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2199
2200 Fix minor problems found by static checking.
2201
2202 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2203
2204 Make identifiers static if they are not used in other modules.
2205 * data.c (Qcompiled_function, Qframe, Qvector):
2206 * image.c (QimageMagick, Qsvg):
2207 * minibuf.c (Qmetadata):
2208 * window.c (resize_window_check, resize_root_window): Now static.
2209 * window.h (resize_window_check, resize_root_window): Remove decls.
2210
2211 * window.c (window_deletion_count, delete_deletable_window):
2212 Remove; unused.
2213 (window_body_lines): Now static.
2214 (Fdelete_other_windows_internal): Mark vars as initialized.
2215 Make sure 'resize_failed' is initialized.
2216 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2217 (resize_window_apply): Remove unused local.
2218 * window.h (delete_deletable_window): Remove decl.
2219
2220 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2221 (imagemagick_load_image): Fix pointer signedness problem by changing
2222 last arg from unsigned char * to char *. All uses changed.
2223 Also, fix a local for similar reasons.
2224 Remove unused locals. Remove locals to avoid shadowing.
2225 (fn_rsvg_handle_free): Remove; unused.
2226 (svg_load, svg_load_image): Fix pointer signedness problem.
2227 (imagemagick_load_image): Don't use garbage pointer image_wand.
2228
2229 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2230
2231 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2232
2233 * image.c (gif_load): Fix omitted cast error introduced by
2234 2011-06-06 change.
2235
2236 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2237
2238 * window.h (resize_proportionally, orig_total_lines)
2239 (orig_top_line): Remove from window structure.
2240 (set_window_height, set_window_width, change_window_heights)
2241 (Fdelete_window): Remove prototypes.
2242 (resize_frame_windows): Remove duplicate declaration.
2243
2244 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2245
2246 * window.h (resize_frame_windows, resize_window_check)
2247 (delete_deletable_window, resize_root_window)
2248 (resize_frame_windows): Declare prototypes.
2249
2250 * window.c (resize_window_apply): Make definition be "static" to
2251 match the prototype.
2252
2253 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2254
2255 * window.c: Remove declarations of Qwindow_size_fixed,
2256 window_min_size_1, window_min_size_2, window_min_size,
2257 size_window, window_fixed_size_p, enlarge_window, delete_window.
2258 Remove static from declaration of Qdelete_window, it's
2259 temporarily needed by Fbury_buffer.
2260 (replace_window): Don't assign orig_top_line and
2261 orig_total_lines.
2262 (Fdelete_window, delete_window): Remove. Window deletion is
2263 handled by window.el.
2264 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2265 Fdelete_window calls with calls to Qdelete_window.
2266 (Fdelete_other_windows): Remove. Deleting other windows is
2267 handled by window.el.
2268 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2269 handled in window.el.
2270 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2271 Window minimum sizes are handled in window.el.
2272 (shrink_windows, size_window, set_window_height)
2273 (set_window_width, change_window_heights, window_height)
2274 (window_width, CURBEG, CURSIZE, enlarge_window)
2275 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2276 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2277 handled in window.el.
2278 (make_dummy_parent): Rename to make_parent_window and give it a
2279 second argument horflag.
2280 (make_window): Don't set resize_proportionally any more.
2281 (Fsplit_window): Remove. Windows are split in window.el.
2282 (save_restore_action, save_restore_orig_size)
2283 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2284 Resize mini windows in window.el.
2285 (grow_mini_window, shrink_mini_window): Implement by calling
2286 Qresize_root_window_vertically, resize_window_check and
2287 resize_window_apply.
2288 (saved_window, Fset_window_configuration, save_window_save): Do
2289 not handle orig_top_line, orig_total_lines, and
2290 resize_proportionally.
2291 (window_min_height, window_min_width): Move to window.el.
2292 (keys_of_window): Move bindings for delete-other-windows,
2293 split-window, delete-window and enlarge-window to window.el.
2294
2295 * buffer.c: Temporarily extern Qdelete_window.
2296 (Fbury_buffer): Temporarily call Qdelete_window instead of
2297 Fdelete_window (Fbury_buffer will move to window.el soon).
2298
2299 * frame.c (set_menu_bar_lines_1): Remove code handling
2300 orig_top_line and orig_total_lines.
2301
2302 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2303 set_window_height but set heights directly.
2304 (change_frame_size_1): Use resize_frame_windows.
2305
2306 * xdisp.c (init_xdisp): Don't use set_window_height but set
2307 heights directly.
2308
2309 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2310 resize_frame_windows instead of change_window_heights and run
2311 run_window_configuration_change_hook.
2312
2313 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2314 instead of change_window_heights and run
2315 run_window_configuration_change_hook.
2316
2317 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2318
2319 * window.c (replace_window): Rename second argument REPLACEMENT to
2320 NEW. New third argument SETFLAG. Rewrite.
2321 (delete_window, make_dummy_parent): Call replace_window with
2322 third argument 1.
2323 (window_list_1): Move down in code.
2324 (run_window_configuration_change_hook): Move set_buffer part
2325 before select_frame_norecord part in order to unwind correctly.
2326 Rename count1 to count.
2327 (recombine_windows, delete_deletable_window, resize_root_window)
2328 (Fdelete_other_windows_internal)
2329 (Frun_window_configuration_change_hook, make_parent_window)
2330 (resize_window_check, resize_window_apply, Fresize_window_apply)
2331 (resize_frame_windows, Fsplit_window_internal)
2332 (Fdelete_window_internal, Fresize_mini_window_internal): New
2333 functions.
2334 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2335
2336 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2337
2338 * window.h (window): Add some new members to window structure -
2339 normal_lines, normal_cols, new_total, new_normal, clone_number,
2340 splits, nest, prev_buffers, next_buffers.
2341 (WINDOW_TOTAL_SIZE): Move here from window.c.
2342 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2343
2344 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2345 Remove.
2346 (make_dummy_parent): Set new members of windows structure.
2347 (make_window): Move down in code. Handle new members of window
2348 structure.
2349 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2350 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2351 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2352 (Fset_window_prev_buffers, Fwindow_next_buffers)
2353 (Fset_window_next_buffers, Fset_window_clone_number): New
2354 functions.
2355 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2356 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2357 Doc-string fixes.
2358 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2359 Argument WINDOW can be now internal window too.
2360 (Fwindow_use_time): Move up in code.
2361 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2362 Rewrite doc-string.
2363 (Fset_window_configuration, saved_window)
2364 (Fcurrent_window_configuration, save_window_save): Handle new
2365 members of window structure.
2366 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2367 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2368 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2369 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2370 Qget_mru_window, Qresize_root_window,
2371 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2372 Qauto_buffer_name; staticpro them.
2373
2374 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2375
2376 * window.c (Fwindow_total_size, Fwindow_left_column)
2377 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2378 (Fwindow_list_1): New functions.
2379 (window_box_text_cols): Replace with window_body_cols.
2380 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2381 window_body_cols instead of window_box_text_cols.
2382 (delete_window, Fset_window_configuration): Call
2383 delete_all_subwindows with window as argument.
2384 (delete_all_subwindows): Take a window as argument and not a
2385 structure. Rewrite.
2386 (window_loop): Remove handling of GET_LRU_WINDOW and
2387 GET_LARGEST_WINDOW.
2388 (Fget_lru_window, Fget_largest_window): Move to window.el.
2389
2390 * window.h: Extern window_body_cols instead of
2391 window_box_text_cols. delete_all_subwindows now takes a
2392 Lisp_Object as argument.
2393
2394 * indent.c (compute_motion, Fcompute_motion): Use
2395 window_body_cols instead of window_box_text_cols.
2396
2397 * frame.c (delete_frame): Call delete_all_subwindows with root
2398 window as argument.
2399
2400 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2401
2402 * fns.c (Fputhash): Document return value.
2403
2404 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2405
2406 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2407
2408 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2409
2410 Cons<->int and similar integer overflow fixes (Bug#8794).
2411
2412 Check for overflow when converting integer to cons and back.
2413 * charset.c (Fdefine_charset_internal, Fdecode_char):
2414 Use cons_to_unsigned to catch overflow.
2415 (Fencode_char): Use INTEGER_TO_CONS.
2416 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2417 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2418 * data.c (long_to_cons, cons_to_long): Remove.
2419 (cons_to_unsigned, cons_to_signed): New functions.
2420 These signal an error for invalid or out-of-range values.
2421 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2422 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2423 * font.c (Ffont_variation_glyphs):
2424 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2425 * lisp.h: Include <intprops.h>.
2426 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2427 (cons_to_signed, cons_to_unsigned): New decls.
2428 (long_to_cons, cons_to_long): Remove decls.
2429 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2430 (Fprimitive_undo): Use CONS_TO_INTEGER.
2431 * xfns.c (Fx_window_property): Likewise.
2432 * xselect.c: Include <limits.h>.
2433 (x_own_selection, selection_data_to_lisp_data):
2434 Use INTEGER_TO_CONS.
2435 (x_handle_selection_request, x_handle_selection_clear)
2436 (x_get_foreign_selection, Fx_disown_selection_internal)
2437 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2438 (lisp_data_to_selection_data): Use cons_to_unsigned.
2439 (x_fill_property_data): Use cons_to_signed.
2440 Report values out of range.
2441
2442 Check for buffer and string overflow more precisely.
2443 * buffer.h (BUF_BYTES_MAX): New macro.
2444 * lisp.h (STRING_BYTES_MAX): New macro.
2445 * alloc.c (Fmake_string):
2446 * character.c (string_escape_byte8):
2447 * coding.c (coding_alloc_by_realloc):
2448 * doprnt.c (doprnt):
2449 * editfns.c (Fformat):
2450 * eval.c (verror):
2451 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2452 since they may not be the same number.
2453 * editfns.c (Finsert_char):
2454 * fileio.c (Finsert_file_contents):
2455 Likewise for BUF_BYTES_MAX.
2456
2457 * image.c: Use ptrdiff_t, not int, for sizes.
2458 (slurp_file): Switch from int to ptrdiff_t.
2459 All uses changed.
2460 (slurp_file): Check that file size fits in both size_t (for
2461 malloc) and ptrdiff_t (for sanity and safety).
2462
2463 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2464 if b->modtime has its maximal value.
2465
2466 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2467
2468 Don't assume time_t can fit into int.
2469 * buffer.h (struct buffer.modtime): Now time_t, not int.
2470 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2471 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2472
2473 Minor fixes for signed vs unsigned integers.
2474 * character.h (MAYBE_UNIFY_CHAR):
2475 * charset.c (maybe_unify_char):
2476 * keyboard.c (read_char, reorder_modifiers):
2477 XINT -> XFASTINT, since the integer must be nonnegative.
2478 * ftfont.c (ftfont_spec_pattern):
2479 * keymap.c (access_keymap, silly_event_symbol_error):
2480 XUINT -> XFASTINT, since the integer must be nonnegative.
2481 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2482 since it makes no difference and we prefer signed.
2483 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2484 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2485 nonnegative.
2486
2487 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2488
2489 * window.h (Fwindow_frame): Declare.
2490
2491 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2492
2493 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2494 (SPARE_MEMORY): Always define.
2495 (LARGE_REQUEST): Remove.
2496 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2497
2498 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2499
2500 * lisp.h: Move EXFUNS for Fframe_root_window,
2501 Fframe_first_window and Fset_frame_selected_window to window.h.
2502
2503 * window.h: Move EXFUNS for Fframe_root_window,
2504 Fframe_first_window and Fset_frame_selected_window here from
2505 lisp.h.
2506
2507 * frame.c (Fwindow_frame, Fframe_first_window)
2508 (Fframe_root_window, Fframe_selected_window)
2509 (Fset_frame_selected_window): Move to window.c.
2510 (Factive_minibuffer_window): Move to minibuf.c.
2511 (Fother_visible_frames_p): New function.
2512
2513 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2514
2515 * window.c (decode_window, decode_any_window): Move up in code.
2516 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2517 (inhibit_frame_unsplittable): Remove unused variable.
2518 (Fwindow_buffer): Move up and rewrite doc-string.
2519 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2520 (Fwindow_prev): New functions.
2521 (Fwindow_frame): Move here from frame.c. Accept any window as
2522 argument.
2523 (Fframe_root_window, Fframe_first_window)
2524 (Fframe_selected_window): Move here from frame.c. Accept frame
2525 or arbitrary window as argument. Update doc-strings.
2526 (Fminibuffer_window): Move up in code.
2527 (Fwindow_minibuffer_p): Move up in code and simplify.
2528 (Fset_frame_selected_window): Move here from frame.c.
2529 Marginal rewrite.
2530 (Fselected_window, select_window, Fselect_window): Move up in
2531 code. Minor doc-string fixes.
2532
2533 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2534
2535 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2536 Do not assume that spare memory exists; that assumption is valid
2537 only if SYSTEM_MALLOC.
2538 (LARGE_REQUEST): New macro, so that the issue of large requests
2539 is separated from the issue of spare memory.
2540
2541 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2542
2543 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2544 format. (Bug#8806)
2545
2546 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2547
2548 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2549 before statements.
2550
2551 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2552
2553 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2554
2555 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2556
2557 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2558 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2559
2560 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2561
2562 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2563
2564 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2565
2566 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2567 (x_clipboard_manager_save): Add return value.
2568 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2569 New error handlers.
2570 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2571 Obey Vx_select_enable_clipboard_manager. Catch errors in
2572 x_clipboard_manager_save (Bug#8779).
2573 (Vx_select_enable_clipboard_manager): New variable.
2574 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2575
2576 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2577
2578 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2579
2580 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2581
2582 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2583 in the current matrix if keep_current_p is non-zero.
2584
2585 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2586
2587 * bidi.c (bidi_level_of_next_char): Fix last change.
2588
2589 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2590
2591 Support bidi reordering of text covered by display properties.
2592
2593 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2594 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2595 (bidi_cache_search, bidi_cache_iterator_state)
2596 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2597 (bidi_level_of_next_char, bidi_move_to_visually_next):
2598 Support character positions inside a run of characters covered by a
2599 display string.
2600 (bidi_paragraph_init, bidi_resolve_explicit_1)
2601 (bidi_level_of_next_char): Call bidi_fetch_char and
2602 bidi_fetch_char_advance instead of FETCH_CHAR and
2603 FETCH_CHAR_ADVANCE.
2604 (bidi_init_it): Initialize new members.
2605 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2606 definitions.
2607 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2608 instead of using explicit *_CHAR codes.
2609 (bidi_resolve_explicit, bidi_resolve_weak):
2610 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2611 bidirectional text is supported only in multibyte buffers.
2612 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2613 it to initialize the frame_window_p member of struct bidi_it.
2614 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2615 (bidi_resolve_explicit, bidi_resolve_weak)
2616 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2617 bidi_it->nchars is non-positive.
2618 (bidi_level_of_next_char): Don't try to lookup the cache for the
2619 next/previous character if nothing is cached there yet, or if we
2620 were just reseat()'ed to a new position.
2621
2622 * xdisp.c (set_cursor_from_row): Set start and stop points
2623 according to the row's direction when priming the loop that looks
2624 for the glyph on which to display cursor.
2625 (single_display_spec_intangible_p): Function deleted.
2626 (display_prop_intangible_p): Reimplement to call
2627 handle_display_spec instead of single_display_spec_intangible_p.
2628 Accept 3 additional arguments needed by handle_display_spec.
2629 This fixes incorrect cursor motion across display property with complex
2630 values: lists, `(when COND...)' forms, etc.
2631 (single_display_spec_string_p): Support property values that are
2632 lists with the argument STRING its top-level element.
2633 (display_prop_string_p): Fix the condition for processing a
2634 property that is a list to be consistent with handle_display_spec.
2635 (handle_display_spec): New function, refactored from the
2636 last portion of handle_display_prop.
2637 (compute_display_string_pos): Accept additional argument
2638 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2639 value of a `display' property is a "replacing spec".
2640 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2641 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2642 the display property, but just return a value indicating whether
2643 the display property will replace the characters it covers.
2644 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2645 frame_window_p members of struct bidi_it.
2646 (compute_display_string_pos, compute_display_string_end):
2647 New functions.
2648 (push_it): Accept second argument POSITION, where pop_it should
2649 jump to continue iteration.
2650 (reseat_1): Initialize bidi_it.disp_pos.
2651
2652 * keyboard.c (adjust_point_for_property): Adjust the call to
2653 display_prop_intangible_p to its new signature.
2654
2655 * dispextern.h (struct bidi_it): New member frame_window_p.
2656 (bidi_init_it): Update prototypes.
2657 (display_prop_intangible_p): Update prototype.
2658 (compute_display_string_pos, compute_display_string_end):
2659 Declare prototypes.
2660 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2661 EMACS_INT.
2662
2663 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2664
2665 Malloc failure behavior now depends on size of allocation.
2666 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2667 * lisp.h: Change signatures accordingly.
2668 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2669 All callers changed. (Bug#8762)
2670
2671 * gnutls.c: Use Emacs's memory allocators.
2672 Without this change, the gnutls library would invoke malloc etc.
2673 directly, which causes problems on non-SYNC_INPUT hosts, and which
2674 runs afoul of improving memory_full behavior. (Bug#8761)
2675 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2676 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2677 xfree instead of the default malloc, realloc, free.
2678 (Fgnutls_boot): No need to check for memory allocation failure,
2679 since xmalloc does that for us.
2680
2681 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2682 * category.c (hash_get_category_set):
2683 * ccl.c (ccl_driver):
2684 * charset.c (Fdefine_charset_internal):
2685 * charset.h (struct charset.hash_index):
2686 * composite.c (get_composition_id, gstring_lookup_cache)
2687 (composition_gstring_put_cache):
2688 * composite.h (struct composition.hash_index):
2689 * dispextern.h (struct image.hash):
2690 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2691 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2692 (hashfn_equal, hashfn_user_defined, make_hash_table)
2693 (maybe_resize_hash_table, hash_lookup, hash_put)
2694 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2695 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2696 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2697 * image.c (make_image, search_image_cache, lookup_image)
2698 (xpm_put_color_table_h):
2699 * lisp.h (struct Lisp_Hash_Table):
2700 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2701 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2702 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2703 * alloc.c (allocate_vectorlike):
2704 Check for overflow in vector size calculations.
2705 * ccl.c (ccl_driver):
2706 Check for overflow when converting EMACS_INT to int.
2707 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2708 need to be updated by these changes.
2709 * fns.c (make_hash_table, maybe_resize_hash_table):
2710 Check for integer overflow with large hash tables.
2711 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2712 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2713 (SXHASH_REDUCE): New macro.
2714 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2715 Use it instead of discarding useful hash info with large hash values.
2716 (sxhash_float): New function.
2717 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2718 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2719 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2720 Rewrite to use FIXNUM_BITS, as this simplifies things.
2721 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2722 Adjust signatures to match updated version of code.
2723 (consing_since_gc): Now EMACS_INT, since a single hash table can
2724 use more than INT_MAX bytes.
2725
2726 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2727
2728 Make it possible to build with GCC-4.6+ -O2 -flto.
2729
2730 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2731
2732 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2733
2734 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2735 Call minibuffer-inactive-mode.
2736
2737 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2738
2739 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2740 Update dependencies.
2741
2742 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2743
2744 * data.c (init_data): Remove code for UTS, this system is not
2745 supported anymore.
2746
2747 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2748
2749 Don't force ./temacs to start in terminal mode.
2750
2751 * frame.c (make_initial_frame): Initialize faces in all cases, not
2752 only when CANNOT_DUMP is defined.
2753 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2754
2755 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2756
2757 * dispnew.c (add_window_display_history): Use const for the string
2758 pointer. Remove declaration, not needed.
2759
2760 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2761
2762 Use 'inline', not 'INLINE'.
2763 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2764 * alloc.c, fontset.c (INLINE): Remove.
2765 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2766 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2767 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2768 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2769 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2770
2771 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2772
2773 Make it possible to run ./temacs.
2774
2775 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2776 syms_of_callproc does the same thing. Remove test for
2777 "initialized", do it in the caller.
2778 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2779
2780 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2781
2782 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2783 (read_minibuf): Use get_minibuffer.
2784 (syms_of_minibuf): Use DEFSYM.
2785 (Qmetadata): New var.
2786 * data.c (Qbuffer): Don't make it static.
2787 (syms_of_data): Use DEFSYM.
2788
2789 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2790
2791 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2792 (CCL_CODE_MIN): New macro.
2793
2794 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2795
2796 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2797
2798 * eval.c (Qdebug): Now static.
2799 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2800 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2801 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2802
2803 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2804
2805 * image.c: Various fixes to ImageMagick code comments.
2806 (Fimagemagick_types): Doc fix.
2807
2808 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2809
2810 Minor fixes prompted by GCC 4.6.0 warnings.
2811
2812 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2813
2814 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2815 (x_clipboard_manager_save_all): Move extern decl to ...
2816 * xterm.h: ... here, so that it can be checked for consistency.
2817
2818 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2819
2820 * xselect.c (x_clipboard_manager_save_frame)
2821 (x_clipboard_manager_save_all): New functions.
2822 (Fx_clipboard_manager_save): Lisp function deleted.
2823
2824 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2825 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2826
2827 * xterm.h: Update prototype.
2828
2829 2011-05-28 William Xu <william.xwl@gmail.com>
2830
2831 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2832 exiting (Bug#8239).
2833
2834 2011-05-28 Jim Meyering <meyering@redhat.com>
2835
2836 Avoid a sign-extension bug in crypto_hash_function.
2837 * fns.c (to_uchar): Define.
2838 (crypto_hash_function): Use it to convert some newly-signed
2839 variables to unsigned, to avoid sign-extension bugs. For example,
2840 without this change, (md5 "truc") would evaluate to
2841 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2842 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2843 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2844
2845 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2846
2847 Integer overflow fixes.
2848
2849 * dbusbind.c: Serial number integer overflow fixes.
2850 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2851 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2852 to hold a serial number that is too large for a fixnum.
2853 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2854 Check for serial numbers out of range. Decode any serial number
2855 that was so large that it became a float. (Bug#8722)
2856
2857 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2858 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2859 Use XFASTINT rather than XUINT when numbers are nonnegative.
2860 (xd_append_arg, Fdbus_method_return_internal):
2861 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2862 arguments, check that Lisp number is nonnegative, rather than
2863 silently wrapping negative numbers around. (Bug#8722)
2864 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2865 (Bug#8722)
2866
2867 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2868
2869 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2870
2871 ccl: add integer overflow checks
2872 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2873 (IN_INT_RANGE): New macros.
2874 (ccl_driver): Use them to check for integer overflow when
2875 decoding a CCL program. Many of the new checks are whether XINT (x)
2876 fits in int; it doesn't always, on 64-bit hosts. The new version
2877 doesn't catch all possible integer overflows, but it's an
2878 improvement. (Bug#8719)
2879
2880 * alloc.c (make_event_array): Use XINT, not XUINT.
2881 There's no need for unsigned here.
2882
2883 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2884 This follows up to the 2011-05-06 change that substituted uintptr_t
2885 for EMACS_INT. This case wasn't caught back then.
2886
2887 Rework Fformat to avoid integer overflow issues.
2888 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2889 now (part of C89). Include <verify.h>.
2890 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2891 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2892 (Fformat): Avoid the prepass trying to compute sizes; it was only
2893 approximate and thus did not catch overflow reliably. Instead, walk
2894 through the format just once, formatting and computing sizes as we go,
2895 checking for integer overflow at every step, and allocating a larger
2896 buffer as needed. Keep track separately whether the format is
2897 multibyte. Keep only the most-recently calculated precision, rather
2898 than them all. Record whether each argument has been converted to
2899 string. Use EMACS_INT, not int, for byte and char and arg counts.
2900 Support field widths and precisions larger than INT_MAX. Avoid
2901 sprintf's undefined behavior with conversion specifications such as %#d
2902 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2903 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2904 formatting out-of-range floating point numbers with int
2905 formats. (Bug#8668)
2906
2907 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2908
2909 * data.c: Avoid integer truncation in expressions involving floats.
2910 * data.c: Include <intprops.h>.
2911 (arith_driver): When there's an integer overflow in an expression
2912 involving floating point, convert the integers to floating point
2913 so that the resulting value does not suffer from catastrophic
2914 integer truncation. For example, on a 64-bit host (* 4
2915 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2916 Do not rely on undefined behavior after integer overflow.
2917
2918 merge count_size_as_multibyte, parse_str_to_multibyte
2919 * character.c, character.h (count_size_as_multibyte):
2920 Rename from parse_str_to_multibyte; all uses changed.
2921 Check for integer overflow.
2922 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2923 since it's now a duplicate of the other. This is more of
2924 a character than a buffer op, so better that it's in character.c.
2925 * fns.c, print.c: Adjust to above changes.
2926
2927 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2928
2929 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2930
2931 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2932
2933 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2934 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2935 (x_clipboard_manager_save): Now static.
2936 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2937
2938 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2939 (crypto_hash_function): Now static.
2940 Fix pointer signedness problems. Avoid unnecessary initializations.
2941
2942 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2943
2944 * termhooks.h (Vselection_alist): Make it terminal-local.
2945
2946 * terminal.c (create_terminal): Initialize it.
2947
2948 * xselect.c: Support for clipboard managers.
2949 (Vselection_alist): Move to termhooks.h as terminal-local var.
2950 (LOCAL_SELECTION): New macro.
2951 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2952 (symbol_to_x_atom): Remove gratuitous arg.
2953 (x_handle_selection_request, lisp_data_to_selection_data)
2954 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2955 (x_own_selection, x_get_local_selection, x_convert_selection):
2956 New arg, specifying work frame. Use terminal-local Vselection_alist.
2957 (some_frame_on_display): Delete unused function.
2958 (Fx_own_selection_internal, Fx_get_selection_internal)
2959 (Fx_disown_selection_internal, Fx_selection_owner_p)
2960 (Fx_selection_exists_p): New optional frame arg.
2961 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2962 (x_handle_selection_clear): Don't treat other terminals with the
2963 same keyboard specially. Use the terminal-local Vselection_alist.
2964 (x_clear_frame_selections): Use Frun_hook_with_args.
2965
2966 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2967
2968 * xterm.h: Add support for those atoms.
2969
2970 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2971
2972 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2973 (converted_selections, conversion_fail_tag): New global variables.
2974 (x_selection_request_lisp_error): Free the above.
2975 (x_get_local_selection): Remove unnecessary code.
2976 (x_reply_selection_request): Args changed; handle arbitrary array
2977 of converted selections stored in converted_selections.
2978 Separate the XChangeProperty and SelectionNotify steps.
2979 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2980 (x_convert_selection): New function.
2981 (x_handle_selection_event): Simplify.
2982 (x_get_foreign_selection): Don't ignore incoming requests while
2983 waiting for an answer; this will fail when we implement
2984 SAVE_TARGETS, and seems unnecessary anyway.
2985 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2986 (Vx_sent_selection_functions): Doc fix.
2987
2988 2011-05-26 Leo Liu <sdl.web@gmail.com>
2989
2990 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2991
2992 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2993
2994 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2995
2996 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2997 for fringe update if it has periodic bitmap.
2998 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2999 and fringe_bitmap_periodic_p.
3000
3001 * fringe.c (get_fringe_bitmap_data): New function.
3002 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3003 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3004 row. Mark glyph row for fringe update if periodicity changed.
3005
3006 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3007 for fringe update unless it has periodic bitmap.
3008
3009 2011-05-25 Kenichi Handa <handa@m17n.org>
3010
3011 * xdisp.c (get_next_display_element): Set correct it->face_id for
3012 a static composition.
3013
3014 2011-05-24 Leo Liu <sdl.web@gmail.com>
3015
3016 * deps.mk (fns.o):
3017 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3018
3019 * fns.c (crypto_hash_function, Fsha1): New function.
3020 (Fmd5): Use crypto_hash_function.
3021 (syms_of_fns): Add Ssha1.
3022
3023 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3024
3025 * gnutls.c: Remove unused macros.
3026 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3027 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3028 Remove macros that are defined and never used.
3029 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3030
3031 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3032
3033 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3034 (Fx_get_selection_internal): Minor cleanup.
3035 (Fx_own_selection_internal): Rename arguments for consistency with
3036 select.el.
3037
3038 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3039
3040 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3041
3042 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3043
3044 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3045
3046 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3047
3048 * dispnew.c (scrolling_window): Don't exclude the case that the
3049 last enabled row in the desired matrix touches the bottom boundary.
3050
3051 2011-05-21 Glenn Morris <rgm@gnu.org>
3052
3053 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3054 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3055 and add some more files.
3056
3057 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3058
3059 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3060 report_file_error introduced by the change from 2011-05-07.
3061
3062 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3063
3064 * systime.h (Time): Define only if emacs is defined.
3065 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3066 where the include path doesn't have X11/X.h by default. See
3067 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3068
3069 2011-05-20 Kenichi Handa <handa@m17n.org>
3070
3071 * composite.c (find_automatic_composition): Fix previous change.
3072
3073 2011-05-20 Glenn Morris <rgm@gnu.org>
3074
3075 * lisp.mk: New file, split from Makefile.in.
3076 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3077 (shortlisp): Remove.
3078 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3079
3080 2011-05-19 Glenn Morris <rgm@gnu.org>
3081
3082 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3083 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3084 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3085 (lisp): Set the order to that of loadup.el.
3086 (shortlisp): Make it a copy of $lisp.
3087 (SOME_MACHINE_LISP): Remove.
3088 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3089 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3090
3091 2011-05-18 Kenichi Handa <handa@m17n.org>
3092
3093 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3094 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3095 (find_automatic_composition): Mostly rewrite for efficiency.
3096
3097 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3098
3099 * makefile.w32-in: Update dependencies.
3100
3101 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3102
3103 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3104 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3105
3106 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3107
3108 Fix some integer overflow issues, such as string length overflow.
3109
3110 * insdel.c (count_size_as_multibyte): Check for string overflow.
3111
3112 * character.c (lisp_string_width): Check for string overflow.
3113 Use EMACS_INT, not int, for string indexes and lengths; in
3114 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3115 the resulting string length overflows an EMACS_INT; instead,
3116 report a string overflow if no precision given. When checking for
3117 precision exhaustion, use a check that cannot possibly have
3118 integer overflow. (Bug#8675)
3119 * character.h (lisp_string_width): Adjust to new signature.
3120
3121 * alloc.c (string_overflow): New function.
3122 (Fmake_string): Use it. This doesn't change behavior, but saves
3123 a few bytes and will simplify future changes.
3124 * character.c (string_escape_byte8): Likewise.
3125 * lisp.h (string_overflow): New decl.
3126
3127 Fixups, following up to the user-interface timestamp change.
3128 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3129 for UI timestamps, instead of unsigned long.
3130 * msdos.c (mouse_get_pos): Likewise.
3131 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3132 * w32gui.h (Time): Define by including "systime.h" rather than by
3133 declaring it ourselves. (Bug#8664)
3134
3135 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3136 * image.c (clear_image_cache): Likewise.
3137
3138 * term.c (term_mouse_position): Don't assume time_t wraparound.
3139
3140 Be more systematic about user-interface timestamps.
3141 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3142 and sometimes 'EMACS_UINT', to represent these timestamps.
3143 This change causes it to use 'Time' uniformly, as that's what X uses.
3144 This makes the code easier to follow, and makes it easier to catch
3145 integer overflow bugs such as Bug#8664.
3146 * frame.c (Fmouse_position, Fmouse_pixel_position):
3147 Use Time, not unsigned long, for user-interface timestamps.
3148 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3149 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3150 * keyboard.h (last_event_timestamp): Likewise.
3151 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3152 * menu.h (xmenu_show): Likewise.
3153 * term.c (term_mouse_position): Likewise.
3154 * termhooks.h (struct input_event.timestamp): Likewise.
3155 (struct terminal.mouse_position_hook): Likewise.
3156 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3157 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3158 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3159 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3160 what it was before.
3161 * menu.h, termhooks.h: Include "systime.h", for Time.
3162
3163 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3164 Don't assume that the difference between two unsigned long values
3165 can fit into an integer. At this point, we know button_down_time
3166 <= event->timestamp, so the difference must be nonnegative, so
3167 there's no need to cast the result if double-click-time is
3168 nonnegative, as it should be; check that it's nonnegative, just in
3169 case. This bug is triggered when events are more than 2**31 ms
3170 apart (about 25 days). (Bug#8664)
3171
3172 * xselect.c (last_event_timestamp): Remove duplicate decl.
3173 (x_own_selection): Remove needless cast to unsigned long.
3174
3175 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3176 that always fit in int. Use a sentinel instead of a counter, to
3177 avoid a temp and to allay GCC's concerns about possible int overflow.
3178 * frame.h (struct frame): Use int for menu_bar_items_used
3179 instead of EMACS_INT, since it always fits in int.
3180
3181 * menu.c (grow_menu_items): Check for int overflow.
3182
3183 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3184
3185 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3186 Before, the code was not consistent. These values cannot exceed
3187 2**31 - 1 so there's no need to make them unsigned.
3188 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3189 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3190 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3191 as modifiers.
3192 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3193
3194 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3195 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3196 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3197 presumably because the widths might not match.
3198
3199 * window.c (size_window): Avoid needless test at loop start.
3200
3201 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3202
3203 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3204
3205 2011-05-12 Drew Adams <drew.adams@oracle.com>
3206
3207 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3208
3209 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3210
3211 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3212 `width' to `bar_area_x' and `bar_area_width', respectively.
3213 (x_scroll_run): Take account of fringe background extension.
3214
3215 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3216 Rename local vars `left' and `width' to `bar_area_x' and
3217 `bar_area_width', respectively.
3218 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3219 background extension.
3220
3221 2011-05-10 Jim Meyering <meyering@redhat.com>
3222
3223 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3224
3225 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3226
3227 * image.c (Finit_image_library): Return t for built-in image types,
3228 like pbm and xbm. (Bug#8640)
3229
3230 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3231
3232 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3233
3234 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3235
3236 * w32console.c (Fset_screen_color): Doc fix.
3237 (Fget_screen_color): New function.
3238 (syms_of_ntterm): Defsubr it.
3239
3240 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3241 unlink the temporary file if Fcall_process didn't create it in the
3242 first place.
3243 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3244 child process will be redirected to a file specified with `:file'.
3245 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3246 cue to call_process_cleanup not to close that handle.
3247
3248 2011-05-07 Ben Key <bkey76@gmail.com>
3249
3250 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3251 one of two shell specific rules, either bootstrap-temacs-CMD or
3252 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3253 to the previous implementation of the bootstrap-temacs rule.
3254 The bootstrap-temacs-CMD rule is similar to the previous
3255 implementation of the bootstrap-temacs rule except that it
3256 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3257 variable.
3258
3259 These changes, along with some changes to nt/configure.bat,
3260 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3261 earlier fix to add support for --cflags and --ldflags options
3262 that include quotes so that it works whether make uses cmd or
3263 sh as the shell.
3264
3265 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3266
3267 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3268 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3269 is a constant.
3270 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3271 a string. Handle both cases.
3272 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3273 (Fdbus_register_method): Use Qinvalid_function.
3274
3275 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3276
3277 * makefile.w32-in: Update dependencies.
3278 (LISP_H): Add inttypes.h and stdin.h.
3279 (PROCESS_H): Add unistd.h.
3280
3281 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3282
3283 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3284 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3285
3286 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3287
3288 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3289
3290 * term.c (vfatal): Remove stray call to va_end.
3291 It's not needed and the C Standard doesn't allow it here anyway.
3292
3293 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3294 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3295
3296 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3297 bytes.
3298
3299 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3300
3301 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3302
3303 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3304
3305 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3306
3307 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3308
3309 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3310 * charset.c (Fdefine_charset_internal): Don't initialize
3311 charset.code_space[15]. The value was garbage, on hosts with
3312 32-bit int (Bug#8600).
3313
3314 * lread.c (read_integer): Be more consistent with string-to-number.
3315 Use string_to_number to do the actual conversion; this avoids
3316 rounding errors and fixes some other screwups. Without this fix,
3317 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3318 (digit_to_number): Move earlier, for benefit of read_integer.
3319 Return -1 if the digit is out of range for the base, -2 if it is
3320 not a digit in any supported base. (Bug#8602)
3321
3322 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3323
3324 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3325 to match comment at start of function. This also removes a
3326 GCC warning about overflow in a 32+64-bit port.
3327
3328 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3329
3330 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3331 Reported by Stefan Monnier in
3332 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3333 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3334 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3335
3336 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3337 (EMACS_UINTPTR): Likewise, with uintptr_t.
3338
3339 * lisp.h: Prefer 64-bit EMACS_INT if available.
3340 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3341 on 32-bit hosts that have 64-bit int, so that they can access
3342 large files.
3343 However, temporarily disable this change unless the temporary
3344 symbol WIDE_EMACS_INT is defined.
3345
3346 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3347
3348 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3349 This removes an assumption that EMACS_INT and long are the same
3350 width as pointers. The assumption is true for Emacs porting targets
3351 now, but we want to make other targets possible.
3352 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3353 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3354 In the rest of the code, change types of integers that hold casted
3355 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3356 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3357 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3358 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3359 No need to cast type when ORing.
3360 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3361 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3362 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3363 assume EMACS_INT is the same width as char *.
3364 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3365 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3366 Remove no-longer-needed casts.
3367 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3368 (xg_tool_bar_help_callback, xg_make_tool_item):
3369 Use EMACS_INTPTR to hold an integer
3370 that will be cast to void *; this can avoid a GCC warning
3371 if EMACS_INT is not the same width as void *.
3372 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3373 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3374 (current_message_1, set_message_1):
3375 Use a local to convert to proper width without a cast.
3376 * xmenu.c (dialog_selection_callback): Likewise.
3377
3378 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3379 Also, don't assume VALBITS / RAND_BITS is less than 5,
3380 and don't rely on undefined behavior when shifting a 1 left into
3381 the sign bit.
3382 * lisp.h (get_random): Change signature to match.
3383
3384 * lread.c (hash_string): Use size_t, not int, for hash computation.
3385 Normally we prefer signed values; but hashing is special, because
3386 it's better to use unsigned division on hash table sizes so that
3387 the remainder is nonnegative. Also, size_t is the natural width
3388 for hashing into memory. The previous code used 'int', which doesn't
3389 retain enough info to hash well into very large tables.
3390 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3391
3392 * dbusbind.c: Don't possibly lose pointer info when converting.
3393 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3394 Use XPNTR rather than XHASH, so that the high-order bits of
3395 the pointer aren't lost when converting through void *.
3396
3397 * eval.c (Fautoload): Don't double-shift a pointer.
3398
3399 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3400
3401 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3402
3403 * gnutls.c (DEF_GNUTLS_FN):
3404 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3405
3406 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3407
3408 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3409 marker. (Bug#8610)
3410
3411 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3412
3413 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3414 New version that can reserve upto 2GB of heap space.
3415
3416 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3417
3418 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3419
3420 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3421
3422 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3423 `gnutls_certificate_set_x509_key_file'.
3424
3425 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3426
3427 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3428 Update dependencies.
3429
3430 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3431
3432 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3433 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3434 Remove unused parameter `fildes'.
3435 * process.c (read_process_output, send_process): Don't pass it.
3436
3437 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3438
3439 Fix previous change: the library cache is defined in w32.c.
3440 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3441 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3442
3443 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3444
3445 Implement dynamic loading of GnuTLS on Windows.
3446
3447 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3448 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3449 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3450 Declare.
3451
3452 * gnutls.c (Qgnutls_dll): Define.
3453 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3454 (gnutls_*): Declare function pointers.
3455 (init_gnutls_functions): New function to initialize function pointers.
3456 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3457 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3458 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3459 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3460 (emacs_gnutls_write, emacs_gnutls_read)
3461 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3462 (Fgnutls_available_p): New function.
3463 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3464 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3465 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3466
3467 * image.c: Include w32.h.
3468 (Vimage_type_cache): Delete.
3469 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3470 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3471 (w32_delayed_load): Move to w32.c.
3472
3473 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3474
3475 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3476 (w32_delayed_load): Move from image.c. When loading a library, record
3477 its filename in the :loaded-from property of the library id.
3478 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3479 Initialize and staticpro them.
3480 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3481
3482 * process.c: Include lisp.h before w32.h, not after.
3483 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3484 instead of gnutls_record_check_pending.
3485
3486 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3487
3488 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3489
3490 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3491 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3492 as passed in.
3493
3494 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3495
3496 * xterm.c (x_set_frame_alpha): Do not set property on anything
3497 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3498
3499 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3500
3501 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3502
3503 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3504
3505 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3506 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3507 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3508 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3509 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3510 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3511 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3512 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3513 (Qgnutls_bootprop_callbacks_verify): Make static.
3514
3515 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3516
3517 * callproc.c: Indentation fixup.
3518
3519 * sysdep.c (wait_for_termination_1): Make static.
3520 (wait_for_termination, interruptible_wait_for_termination):
3521 Move after wait_for_termination_1.
3522
3523 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3524
3525 * sysdep.c (interruptible_wait_for_termination): New function
3526 which is like wait_for_termination, but allows keyboard
3527 interruptions.
3528
3529 * callproc.c (Fcall_process): Add (:file "file") as an option for
3530 the STDOUT buffer.
3531 (Fcall_process_region): Ditto.
3532
3533 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3534
3535 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3536 rather than `XVECTOR (FOO)->size'.
3537
3538 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3539 inttypes.h, as a gnulib replacement is used if it not available in
3540 system headers.
3541
3542 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3543
3544 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3545 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3546 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3547
3548 * coding.c (coding_alloc_by_realloc): Error out if destination
3549 will grow beyond MOST_POSITIVE_FIXNUM.
3550 (decode_coding_emacs_mule): Abort if there isn't enough place in
3551 charbuf for the composition carryover bytes. Reserve an extra
3552 space for up to 2 characters produced in a loop.
3553 (decode_coding_iso_2022): Abort if there isn't enough place in
3554 charbuf for the composition carryover bytes.
3555
3556 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3557
3558 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3559 aborting when %lld or %lll format is passed.
3560 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3561 %llo or %llx format is passed. (Bug#8545)
3562
3563 * window.c (window_scroll_line_based): Use a marker instead of
3564 simple variables to record original value of point. (Bug#7952)
3565
3566 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3567 produced by %s or %c overflows available buffer space. (Bug#8545)
3568
3569 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3570
3571 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3572 (SIZE_MAX): Move defn after all includes, as they might #define it.
3573
3574 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3575
3576 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3577
3578 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3579
3580 * keyboard.c (Qdelayed_warnings_hook): Define.
3581 (command_loop_1): Run `delayed-warnings-hook'
3582 if Vdelayed_warnings_list is non-nil.
3583 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3584 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3585
3586 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3587
3588 * doprnt.c (doprnt): Don't return value smaller than the buffer
3589 size if the message was truncated. (Bug#8545).
3590
3591 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3592
3593 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3594 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3595
3596 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3597
3598 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3599
3600 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3601
3602 * makefile.w32-in: Update dependencies.
3603
3604 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3605
3606 Improve `doprnt' and its usage. (Bug#8545)
3607 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3608 `format_end'. Remove support for %l as a conversion specifier.
3609 Don't use xrealloc. Improve diagnostics when the %l size modifier
3610 is used. Update the commentary.
3611
3612 * eval.c (verror): Simplify calculation of size_t.
3613
3614 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3615 messages.
3616
3617 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3618
3619 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3620 change.
3621
3622 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3623
3624 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3625 This makes this file independent of the recent pseudovector change.
3626
3627 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3628
3629 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3630
3631 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3632 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3633 Remove unused local.
3634 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3635
3636 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3637 GCC 4.6.0 optimizes based on type-based alias analysis.
3638 For example, if b is of type struct buffer * and v of type struct
3639 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3640 != &v->size, and therefore "v->size = 1; b->size = 2; return
3641 v->size;" must therefore return 1. This assumption is incorrect
3642 for Emacs, since it type-puns struct Lisp_Vector * with many other
3643 types. To fix this problem, this patch adds a new type struct
3644 vectorlike_header that documents the constraints on layout of vectors
3645 and pseudovectors, and helps optimizing compilers not get fooled
3646 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3647 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3648 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3649 the size member.
3650 (XSETPVECTYPE): Rewrite in terms of new macro.
3651 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3652 This is a bit clearer, and further avoids the possibility of
3653 undesirable aliasing.
3654 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3655 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3656 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3657 since Lisp_Subr is a special case (no "next" field).
3658 (ASIZE): Now uses header.size rather than size.
3659 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3660 to avoid the hassle of writing XVECTOR (foo)->header.size.
3661 (struct vectorlike_header): New type.
3662 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3663 object, to help avoid aliasing.
3664 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3665 (SUBRP): Likewise, since Lisp_Subr is a special case.
3666 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3667 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3668 (struct Lisp_Hash_Table): Combine first two members into a single
3669 struct vectorlike_header member. All uses of "size" and "next" members
3670 changed to be "header.size" and "header.next".
3671 * buffer.h (struct buffer): Likewise.
3672 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3673 * frame.h (struct frame): Likewise.
3674 * process.h (struct Lisp_Process): Likewise.
3675 * termhooks.h (struct terminal): Likewise.
3676 * window.c (struct save_window_data, struct saved_window): Likewise.
3677 * window.h (struct window): Likewise.
3678 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3679 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3680 * buffer.c (init_buffer_once): Likewise.
3681 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3682 special case.
3683 * process.c (Fformat_network_address): Use local var for size,
3684 for brevity.
3685
3686 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3687
3688 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3689 * data.c (atof): Remove decl; no longer used or needed.
3690 (digit_to_number): Move to lread.c.
3691 (Fstring_to_number): Use new string_to_number function, to be
3692 consistent with how the Lisp reader treats infinities and NaNs.
3693 Do not assume that floating-point numbers represent EMACS_INT
3694 without losing information; this is not true on most 64-bit hosts.
3695 Avoid double-rounding errors, by insisting on integers when
3696 parsing non-base-10 numbers, as the documentation specifies.
3697 * lisp.h (string_to_number): New decl, replacing ...
3698 (isfloat_string): Remove.
3699 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3700 (read1): Do not accept +. and -. as integers; this
3701 appears to have been a coding error. Similarly, do not accept
3702 strings like +-1e0 as floating point numbers. Do not report
3703 overflow for integer overflows unless the base is not 10 which
3704 means we have no simple and reliable way to continue.
3705 Break out the floating-point parsing into a new
3706 function string_to_number, so that Fstring_to_number parses
3707 floating point numbers consistently with the Lisp reader.
3708 (digit_to_number): Move here from data.c. Make it static inline.
3709 (E_CHAR, EXP_INT): Remove, replacing with ...
3710 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3711 (string_to_number): New function, replacing isfloat_string.
3712 This function checks for valid syntax and produces the resulting
3713 Lisp float number too. Rework it so that string-to-number
3714 no longer mishandles examples like "1.0e+". Use strtoumax,
3715 so that overflow for non-base-10 numbers is reported only when
3716 there's no portable and simple way to convert to floating point.
3717
3718 * textprop.c (set_text_properties_1): Rewrite for clarity,
3719 and to avoid GCC warning about integer overflow.
3720
3721 * intervals.h (struct interval): Use EMACS_INT for members
3722 where EMACS_UINT might cause problems. See
3723 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3724 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3725 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3726 All uses changed.
3727 (offset_intervals): Tell GCC not to worry about length overflow
3728 when negating a negative length.
3729
3730 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3731 (overrun_check_free): Likewise.
3732
3733 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3734 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3735 word size.
3736
3737 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3738 (gnutls_make_error): Rename local to avoid shadowing.
3739 (gnutls_emacs_global_deinit): ifdef out; not used.
3740 (Fgnutls_boot): Use const for pointer to readonly storage.
3741 Comment out unused local. Fix pointer signedness problems.
3742
3743 * lread.c (openp): Don't stuff size_t into an 'int'.
3744 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3745 about possible signed overflow.
3746
3747 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3748 (GDK_KEY_g): Don't define if already defined.
3749 (xg_prepare_tooltip): Avoid pointer signedness problem.
3750 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3751
3752 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3753 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3754
3755 * xfns.c (Fx_window_property): Simplify a bit,
3756 to make a bit faster and to avoid GCC 4.6.0 warning.
3757 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3758
3759 * fns.c (internal_equal): Don't assume size_t fits in int.
3760
3761 * alloc.c (compact_small_strings): Tighten assertion a little.
3762
3763 Replace pEd with more-general pI, and fix some printf arg casts.
3764 * lisp.h (pI): New macro, generalizing old pEd macro to other
3765 conversion specifiers. For example, use "...%"pI"d..." rather
3766 than "...%"pEd"...".
3767 (pEd): Remove. All uses replaced with similar uses of pI.
3768 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3769 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3770 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3771 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3772 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3773 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3774 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3775 64-bit hosts.
3776 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3777 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3778 * print.c (safe_debug_print, print_object): Likewise.
3779 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3780 to int.
3781 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3782 avoiding the 0 flag, which is not portable.
3783 * process.c (Fmake_network_process): Use pI to avoid cast.
3784 * region-cache.c (pp_cache): Likewise.
3785 * xdisp.c (decode_mode_spec): Likewise.
3786 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3787 behavior on 64-bit hosts with printf arg.
3788 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3789 (x_stop_queuing_selection_requests): Likewise.
3790 (x_get_window_property): Don't truncate byte count to an 'int'
3791 when tracing.
3792
3793 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3794 here, since it parses constructs like leading '-' and spaces,
3795 which are not wanted; and it overflows with large numbers.
3796 Instead, simply match F[0-9]+, which is what is wanted anyway.
3797
3798 * alloc.c: Remove unportable assumptions about struct layout.
3799 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3800 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3801 (allocate_vectorlike, make_pure_vector): Use the new macros,
3802 plus offsetof, to remove unportable assumptions about struct layout.
3803 These assumptions hold on all porting targets that I know of, but
3804 they are not guaranteed, they're easy to remove, and removing them
3805 makes further changes easier.
3806
3807 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3808 This doesn't fix a bug but makes the code clearer.
3809 (string_overrun_cookie): Now const. Use initializers that
3810 don't formally overflow signed char, to avoid warnings.
3811 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3812 can cause Emacs to crash when string overrun checking is enabled.
3813 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3814 multiple of sizeof (EMACS_INT); it need not be, if
3815 alignof(EMACS_INT) < sizeof (EMACS_INT).
3816 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3817
3818 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3819
3820 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3821
3822 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3823
3824 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3825 supposed to be handshaking. (Bug#8556)
3826 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3827
3828 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3829
3830 * lisp.h (Qdebug): List symbol.
3831 * eval.c (Qdebug): Restore global linkage.
3832 * keyboard.c (debug-on-event): New variable.
3833 (handle_user_signal): Break into debugger when debug-on-event
3834 matches the current signal symbol.
3835
3836 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3837
3838 * alloc.c (check_sblock, check_string_bytes)
3839 (check_string_free_list): Convert to standard C.
3840
3841 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3842
3843 * w32.c (emacs_gnutls_push): Fix typo.
3844
3845 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3846
3847 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3848 "cast to pointer from integer of different size".
3849
3850 Improve doprnt and its use in verror. (Bug#8545)
3851 * doprnt.c (doprnt): Document the set of format control sequences
3852 supported by the function. Use SAFE_ALLOCA instead of always
3853 using `alloca'.
3854
3855 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3856 is one byte too soon. Don't use xrealloc; instead xfree and
3857 xmalloc anew.
3858
3859 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3860
3861 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3862 callbacks stage.
3863
3864 * gnutls.c: Renamed global_initialized to
3865 gnutls_global_initialized. Added internals for the
3866 :verify-hostname-error, :verify-error, and :verify-flags
3867 parameters of `gnutls-boot' and documented those parameters in the
3868 docstring. Start callback support.
3869 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3870 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3871 on error. Return error code.
3872 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3873 (emacs_gnutls_read): Likewise.
3874 (Fgnutls_boot): Return handshake error code.
3875 (emacs_gnutls_handle_error): New function.
3876 (wsaerror_to_errno): Likewise.
3877
3878 * w32.h (emacs_gnutls_pull): Add prototype.
3879 (emacs_gnutls_push): Likewise.
3880
3881 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3882 (emacs_gnutls_push): Likewise.
3883
3884 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3885
3886 * process.c (wait_reading_process_output): Check if GnuTLS
3887 buffered some data internally if no FDs are set for TLS
3888 connections.
3889
3890 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3891 (LIBS): Link to USER_LIBS.
3892 ($(BLD)/gnutls.$(0)): New target.
3893
3894 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3895
3896 * xdisp.c (handle_single_display_spec): Rename the
3897 display_replaced_before_p argument into display_replaced_p, to
3898 make it consistent with the commentary. Fix typos in the
3899 commentary.
3900
3901 * textprop.c (syms_of_textprop): Remove dead code.
3902 (copy_text_properties): Delete obsolete commentary about an
3903 interface that was deleted long ago. Fix typos in the description
3904 of arguments.
3905
3906 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3907 to changes in oldXMenu/XMenu.h from 2011-04-16.
3908 <menu_help_message, prev_menu_help_message>: Constify.
3909 (IT_menu_make_room): menu->help_text is now `const char **';
3910 adjust.
3911
3912 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3913 to changes in oldXMenu/XMenu.h from 2011-04-16.
3914 (struct XMenu): Declare `help_text' `const char **'.
3915
3916 * xfaces.c <Qunspecified>: Make extern again.
3917
3918 * syntax.c: Include sys/types.h before including regex.h, as
3919 required by Posix.
3920
3921 * doc.c (get_doc_string): Improve the format passed to `error'.
3922
3923 * doprnt.c (doprnt): Improve commentary.
3924
3925 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3926
3927 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3928 them with etags.
3929
3930 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3931 changes in globals.h immediately force recompilation.
3932 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3933 $(CURDIR)/s/ms-w32.h.
3934 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3935
3936 * character.c (Fchar_direction): Function deleted.
3937 (syms_of_character): Don't defsubr it.
3938 <char-direction-table>: Deleted.
3939
3940 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3941
3942 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3943 * doprnt.c: Include limits.h.
3944 (SIZE_MAX): New macro.
3945 (doprnt): Return a size_t value. 2nd arg is now size_t.
3946 Many local variables are now size_t instead of int or unsigned.
3947 Improve overflow protection. Support `l' modifier for integer
3948 conversions. Support %l conversion. Don't assume an EMACS_INT
3949 argument for integer conversions and for %c.
3950
3951 * lisp.h (doprnt): Restore prototype.
3952
3953 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3954 $(SRC)/character.h.
3955
3956 * Makefile.in (base_obj): Add back doprnt.o.
3957
3958 * deps.mk (doprnt.o): Add back prerequisites.
3959 (callint.o): Depend on character.h.
3960
3961 * eval.c (internal_lisp_condition_case): Include the handler
3962 representation in the error message.
3963 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3964 when breaking from the loop.
3965
3966 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3967
3968 * callint.c (Fcall_interactively): When displaying error message
3969 about invalid control letter, pass the character's codepoint, not
3970 a pointer to its multibyte form. Improve display of the character
3971 in octal and display also its hex code.
3972
3973 * character.c (char_string): Use %x to display the (unsigned)
3974 codepoint of an invalid character, to avoid displaying a bogus
3975 negative value.
3976
3977 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3978 `error', not SYMBOL_NAME itself.
3979
3980 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3981 character arguments to `error'.
3982
3983 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3984 to `error' in error message about FINAL_CHAR argument. Make sure
3985 FINAL_CHAR is a character, and use %c when it is passed as
3986 argument to `error'.
3987
3988 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3989
3990 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3991
3992 * w32.c: Include <time.h>.
3993 (sys_localtime): New function.
3994
3995 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
3996
3997 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3998
3999 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4000
4001 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4002
4003 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4004 zombies (Bug#8467).
4005
4006 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4007
4008 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4009 gl_state.e_property when gl_state.object is Qt.
4010
4011 * insdel.c (make_gap_larger): Remove limitation of buffer size
4012 to <= INT_MAX.
4013
4014 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4015
4016 * xdisp.c (lookup_glyphless_char_display)
4017 (produce_glyphless_glyph): Handle cons cell entry in
4018 glyphless-char-display.
4019 (Vglyphless_char_display): Document it.
4020
4021 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4022 glyphless-char-display.
4023
4024 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4025
4026 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4027
4028 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4029
4030 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4031 definition for no-X builds.
4032
4033 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4034
4035 Static checks with GCC 4.6.0 and non-default toolkits.
4036
4037 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4038
4039 * process.c (keyboard_bit_set): Define only if SIGIO.
4040 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4041 (send_process): Repair possible setjmp clobbering.
4042
4043 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4044
4045 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4046
4047 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4048
4049 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4050 Define only if needed.
4051
4052 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4053 by pacifying GCC about it. Maybe it's time to retire it?
4054 * xfaces.c (USG, __TIMEVAL__): Likewise.
4055
4056 * dispextern.h (struct redisplay_interface): Rename param
4057 to avoid shadowing.
4058 * termhooks.h (struct terminal): Likewise.
4059 * xterm.c (xembed_send_message): Likewise.
4060
4061 * insdel.c (make_gap_smaller): Define only if
4062 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4063
4064 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4065 it.
4066
4067 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4068 so that we aren't warned about unused symbols.
4069
4070 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4071
4072 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4073
4074 * xfns.c (x_real_positions): Mark locals as initialized.
4075
4076 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4077
4078 * xterm.c: Fix problems found by static analysis with other toolkits.
4079 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4080 (x_dispatch_event): Declare static if USE_GTK, and
4081 define if USE_GTK || USE_X_TOOLKIT.
4082 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4083 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4084 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4085 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4086
4087 * xmenu.c (menu_help_callback): Pointer type fixes.
4088 Use const pointers when pointing at readonly data. Avoid pointer
4089 signedness clashes.
4090 (FALSE): Remove unused macro.
4091 (update_frame_menubar): Remove unused decl.
4092
4093 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4094
4095 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4096 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4097 (single_menu_item): Rename local to avoid shadowing.
4098
4099 * keyboard.c (make_lispy_event): Remove unused local var.
4100
4101 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4102 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4103
4104 * bitmaps: Change bitmaps from unsigned char back to the X11
4105 compatible char. Avoid the old compiler warnings about
4106 out-of-range initializers by using, for example, '\xab' rather
4107 than 0xab.
4108
4109 * xgselect.c (xgselect_initialize): Check vs interface
4110 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4111
4112 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4113
4114 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4115 to read-only memory.
4116
4117 * fns.c (vector): Remove; this old hack is no longer needed.
4118
4119 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4120 Remove unused var.
4121 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4122
4123 * xrdb.c (x_load_resources): Omit unused local.
4124
4125 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4126 (x_window): Rename locals to avoid shadowing.
4127 (USG): Use the kludged USG macro, to pacify gcc.
4128
4129 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4130 (x_term_init): Remove local to avoid shadowing.
4131
4132 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4133
4134 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4135 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4136
4137 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4138
4139 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4140
4141 Fix regex.c, syntax.c and friends for buffers > 2GB.
4142 * syntax.h (struct gl_state_s): Declare character position members
4143 EMACS_INT.
4144
4145 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4146
4147 * textprop.c (verify_interval_modification, interval_of):
4148 Declare arguments EMACS_INT.
4149
4150 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4151 EMACS_INT.
4152
4153 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4154
4155 * indent.c (Fvertical_motion): Local variable it_start is now
4156 EMACS_INT.
4157
4158 * regex.c (re_match, re_match_2, re_match_2_internal)
4159 (bcmp_translate, regcomp, regexec, print_double_string)
4160 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4161 (re_compile_pattern, re_exec): Declare arguments and local
4162 variables `size_t' and `ssize_t' and return values `regoff_t', as
4163 appropriate.
4164 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4165 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4166 <compile_stack_type>: `size' and `avail' are now `size_t'.
4167
4168 * regex.h <regoff_t>: Use ssize_t, not int.
4169 (re_search, re_search_2, re_match, re_match_2): Arguments that
4170 specify buffer/string position and length are now ssize_t and
4171 size_t. Return type is regoff_t.
4172
4173 2011-04-16 Ben Key <bkey76@gmail.com>
4174
4175 * nsfont.m: Fixed bugs in ns_get_family and
4176 ns_descriptor_to_entity that were caused by using free to
4177 deallocate memory blocks that were allocated by xmalloc (via
4178 xstrdup). This caused Emacs to crash when compiled with
4179 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4180 --enable-checking=xmallocoverrun). xfree is now used to
4181 deallocate these memory blocks.
4182
4183 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4184
4185 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4186
4187 emacs_write: Accept and return EMACS_INT for sizes.
4188 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4189 et seq.
4190 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4191 Accept and return EMACS_INT.
4192 (emacs_gnutls_write): Return the number of bytes written on
4193 partial writes.
4194 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4195 (emacs_read, emacs_write): Remove check for negative size, as the
4196 Emacs source code has been audited now.
4197 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4198 (emacs_read, emacs_write): Use it.
4199 * process.c (send_process): Adjust to the new signatures of
4200 emacs_write and emacs_gnutls_write. Do not attempt to store
4201 a byte offset into an 'int'; it might overflow.
4202 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4203
4204 * sound.c: Don't assume sizes fit in 'int'.
4205 (struct sound_device.period_size, alsa_period_size):
4206 Return EMACS_INT, not int.
4207 (struct sound_device.write, vox_write, alsa_write):
4208 Accept EMACS_INT, not int.
4209 (wav_play, au_play): Use EMACS_INT to store sizes and to
4210 record read return values.
4211
4212 2011-04-15 Ben Key <bkey76@gmail.com>
4213
4214 * keyboard.c (Qundefined): Don't declare static since it is used
4215 in nsfns.m.
4216 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4217 static since they are used in nsfont.m.
4218
4219 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4220
4221 * process.c (Qprocessp): Don't declare static.
4222 * lisp.h (Qprocessp): Declare again.
4223
4224 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4225
4226 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4227
4228 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4229
4230 Improve C-level modularity by making more things 'static'.
4231
4232 Don't publish debugger-only interfaces to other modules.
4233 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4234 (verify_bytepos, count_markers): Move decls to the only modules
4235 that need them.
4236 * region-cache.h (pp_cache): Likewise.
4237 * window.h (check_all_windows): Likewise.
4238 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4239
4240 * sysdep.c (croak): Now static, if
4241 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4242 * syssignal.h (croak): Declare only if not static.
4243
4244 * alloc.c (refill_memory_reserve): Now static if
4245 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4246 * lisp.h (refill_memory_reserve): Declare only if not static.
4247
4248 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4249 Define only if USE_LUCID.
4250
4251 * xrdb.c (x_customization_string, x_rm_string): Now static.
4252
4253 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4254 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4255
4256 * xdisp.c (draw_row_with_mouse_face): Now static.
4257 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4258
4259 * window.h (check_all_windows): Mark externally visible.
4260
4261 * window.c (window_deletion_count): Now static.
4262
4263 * undo.c: Make symbols static if they're not exported.
4264 (last_undo_buffer, last_boundary_position, pending_boundary):
4265 Now static.
4266
4267 * textprop.c (interval_insert_behind_hooks): Now static.
4268 (interval_insert_in_front_hooks): Likewise.
4269
4270 * term.c: Make symbols static if they're not exported.
4271 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4272 (max_frame_lines, tty_set_terminal_modes):
4273 (tty_reset_terminal_modes, tty_turn_off_highlight):
4274 (get_tty_terminal): Now static.
4275 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4276 * termhooks.h (term_mouse_moveto): Do not declare if
4277 HAVE_WINDOW_SYSTEM.
4278 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4279 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4280
4281 * sysdep.c: Make symbols static if they're not exported.
4282 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4283 Now static.
4284 (sigprocmask_set, full_mask): Remove; unused.
4285 (wait_debugging): Mark as visible.
4286 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4287 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4288
4289 * syntax.c (syntax_temp): Define only if !__GNUC__.
4290
4291 * sound.c (current_sound_device, current_sound): Now static.
4292
4293 * search.c (searchbufs, searchbuf_head): Now static.
4294
4295 * scroll.c (scroll_cost): Remove; unused.
4296 * dispextern.h (scroll_cost): Remove decl.
4297
4298 * region-cache.h (pp_cache): Mark as externally visible.
4299
4300 * process.c: Make symbols static if they're not exported.
4301 (process_tick, update_tick, create_process, chan_process):
4302 (Vprocess_alist, proc_buffered_char, datagram_access):
4303 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4304 (deactivate_process): Mark defn as static, as well as decl.
4305 * lisp.h (create_process): Remove decl.
4306 * process.h (chan_process, Vprocess_alist): Remove decls.
4307
4308 * print.c: Make symbols static if they're not exported.
4309 (print_depth, new_backquote_output, being_printed, print_buffer):
4310 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4311 (print_interval, print_number_index, initial_stderr_stream):
4312 Now static.
4313 * lisp.h (Fprinc): Remove decl.
4314 (debug_output_compilation_hack): Mark as externally visible.
4315
4316 * sysdep.c (croak): Move decl from here to syssignal.h.
4317 * syssignal.h (croak): Put it here, so the API can be checked when
4318 'croak' is called from dissociate_if_controlling_tty.
4319
4320 * minibuf.c: Make symbols static if they're not exported.
4321 (minibuf_save_list, choose_minibuf_frame): Now static.
4322 * lisp.h (choose_minibuf_frame): Remove decl.
4323
4324 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4325
4326 * lread.c: Make symbols static if they're not exported.
4327 (read_objects, initial_obarray, oblookup_last_bucket_number):
4328 Now static.
4329 (make_symbol): Remove; unused.
4330 * lisp.h (initial_obarray, make_symbol): Remove decls.
4331
4332 * keyboard.c: Make symbols static if they're not exported.
4333 (single_kboard, recent_keys_index, total_keys, recent_keys):
4334 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4335 (this_single_command_key_start, echoing, last_auto_save):
4336 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4337 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4338 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4339 (Vlispy_mouse_stem, double_click_count):
4340 Now static.
4341 (force_auto_save_soon): Define only if SIGDANGER.
4342 (ignore_mouse_drag_p): Now static if
4343 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4344 (print_help): Remove; unused.
4345 (stop_character, last_timer_event): Mark as externally visible.
4346 * keyboard.h (ignore_mouse_drag_p): Declare only if
4347 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4348 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4349 * lisp.h (echoing): Remove decl.
4350 (force_auto_save_soon): Declare only if SIGDANGER.
4351 * xdisp.c (redisplay_window): Simplify code, to make it more
4352 obvious that ignore_mouse_drag_p is not accessed if !defined
4353 USE_GTK && !defined HAVE_NS.
4354
4355 * intervals.c: Make symbols static if they're not exported.
4356 (merge_properties_sticky, merge_interval_right, delete_interval):
4357 Now static.
4358 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4359
4360 * insdel.c: Make symbols static if they're not exported.
4361 However, leave prepare_to_modify_buffer alone. It's never
4362 called from outside this function, but that appears to be a bug.
4363 (combine_after_change_list, combine_after_change_buffer):
4364 (adjust_after_replace, signal_before_change): Now static.
4365 (adjust_after_replace_noundo): Remove; unused.
4366 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4367 (signal_before_change): Remove decls.
4368
4369 * indent.c (val_compute_motion, val_vmotion): Now static.
4370
4371 * image.c: Make symbols static if they're not exported.
4372 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4373 if USE_GTK.
4374 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4375 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4376
4377 * fringe.c (standard_bitmaps): Now static.
4378 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4379
4380 * frame.c: Make symbols static if they're not exported.
4381 (x_report_frame_params, make_terminal_frame): Now static.
4382 (get_frame_param): Now static, unless HAVE_NS.
4383 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4384 (x_get_resource_string): Remove; not used.
4385 * frame.h (make_terminal_frame, x_report_frame_params):
4386 (x_get_resource_string); Remove decls.
4387 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4388 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4389
4390 * font.c, fontset.c: Make symbols static if they're not exported.
4391 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4392 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4393 * font.c (font_close_object): Now static.
4394 * font.h (font_close_object): Remove.
4395 * fontset.c (FONTSET_OBJLIST): Remove.
4396 (free_realized_fontset) #if-0 the body, which does nothing.
4397 (face_suitable_for_char_p): #if-0, as it's never called.
4398 * fontset.h (face_suitable_for_char_p): Remove decl.
4399 * xfaces.c (face_at_string_position):
4400 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4401 since 0 is always ASCII.
4402
4403 * fns.c (weak_hash_tables): Now static.
4404
4405 * fileio.c: Make symbols static if they're not exported.
4406 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4407 (Vwrite_region_annotation_buffers): Now static.
4408
4409 * eval.c: Make symbols static if they're not exported.
4410 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4411 * lisp.h (backtrace_list): Remove decl.
4412
4413 * emacs.c: Make symbols static if they're not exported.
4414 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4415 (fatal_error_code, fatal_error_signal_hook, standard_args):
4416 Now static.
4417 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4418 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4419 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4420 * lisp.h (fatal_error_signal_hook): Remove decl.
4421 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4422
4423 * editfns.c: Move a (normally-unused) function to its only use.
4424 * editfns.c, lisp.h (get_operating_system_release): Remove.
4425 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4426 worth the hassle of breaking this out.
4427
4428 * xterm.c: Make symbols static if they're not exported.
4429 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4430 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4431 (x_destroy_window, x_delete_display):
4432 Now static.
4433 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4434 (x_mouse_leave): Remove; unused.
4435 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4436 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4437 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4438 Remove decls.
4439 (x_mouse_leave): Declare only if WINDOWSNT.
4440 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4441 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4442 USE_X_TOOLKIT.
4443
4444 * ftxfont.c: Make symbols static if they're not exported.
4445 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4446 HAVE_FREETYPE.
4447 * font.h (ftxfont_driver): Likewise.
4448
4449 * xfns.c: Make symbols static if they're not exported.
4450 (x_last_font_name, x_display_info_for_name):
4451 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4452 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4453 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4454 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4455 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4456 (last_show_tip_args): Now static.
4457 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4458 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4459 (x_screen_planes): Remove; unused.
4460 * dispextern.h (x_screen_planes): Remove decl.
4461
4462 * dispnew.c: Make symbols static if they're not exported.
4463 * dispextern.h (redraw_garbaged_frames, scrolling):
4464 (increment_row_positions): Remove.
4465 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4466 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4467 Now static.
4468 (redraw_garbaged_frames): Remove; unused.
4469
4470 * xfaces.c: Make symbols static if they're not exported.
4471 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4472 Remove decls.
4473 * xterm.h (defined_color): Remove decls.
4474 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4475 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4476 (menu_face_changed_default, defined_color, free_realized_face):
4477 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4478 (ascii_face_of_lisp_face): Remove; unused.
4479
4480 * xdisp.c: Make symbols static if they're not exported.
4481 * dispextern.h (scratch_glyph_row, window_box_edges):
4482 (glyph_to_pixel_coords, set_cursor_from_row):
4483 (get_next_display_element, set_iterator_to_next):
4484 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4485 (show_mouse_face): Remove decls
4486 * frame.h (message_buf_print): Likewise.
4487 * lisp.h (pop_message, set_message, check_point_in_composition):
4488 Likewise.
4489 * xterm.h (set_vertical_scroll_bar): Likewise.
4490 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4491 (message_buf_print, scratch_glyph_row, displayed_buffer):
4492 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4493 (get_next_display_element, show_mouse_face, window_box_edges):
4494 (frame_to_window_pixel_xy, check_point_in_composition):
4495 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4496 (glyph_to_pixel_coords): Remove; unused.
4497
4498 * dired.c (file_name_completion): Now static.
4499
4500 * dbusbind.c (xd_in_read_queued_messages): Now static.
4501
4502 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4503 * data.c (circular_list_error): Remove.
4504
4505 * commands.h (last_point_position, last_point_position_buffer):
4506 (last_point_position_window): Remove decls.
4507 * keyboard.c: Make these variables static.
4508
4509 * coding.h (coding, code_convert_region, encode_coding_gap):
4510 Remove decls.
4511 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4512 (iso_code_class, detect_coding, code_convert_region): Now static.
4513 (encode_coding_gap): Remove; unused.
4514
4515 * chartab.c (chartab_chars, chartab_bits): Now static.
4516
4517 * charset.h (charset_iso_8859_1): Remove decl.
4518 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4519 Now static.
4520
4521 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4522 * ccl.c (Vccl_program_table): Now static.
4523 (check_ccl_update): Remove; unused.
4524
4525 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4526 * category.h: ... from here.
4527 * category.c (check_category_table, set_category_set): Now static.
4528
4529 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4530 * lisp.h: Remove these decls.
4531
4532 * buffer.c (buffer_count): Remove unused var.
4533
4534 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4535 so that it's not optimized away.
4536 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4537 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4538 exported only to the debugger.
4539
4540 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4541 * atimer.h (run_all_atimers): Remove; not exported.
4542
4543 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4544 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4545 was inaccessible from Lisp.
4546 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4547 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4548
4549 alloc.c: Import and export fewer symbols, and remove unused items.
4550 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4551 is defined.
4552 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4553 it's not optimized away by whole-program optimization.
4554 (message_enable_multibyte, free_misc): Remove.
4555 (catchlist, handlerlist, mark_backtrace):
4556 Declare only if BYTE_MARK_STACK.
4557 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4558 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4559 (message_enable_multibyte): Remove decl.
4560 (free_misc, interval_free_list, float_block, float_block_index):
4561 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4562 (cons_free_list, last_marked_index):
4563 Now static.
4564 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4565 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4566 (mark_backtrace): Define only if BYTE_MARK_STACK.
4567 * xdisp.c (message_enable_multibyte): Now static.
4568
4569 Declare Lisp_Object Q* variables to be 'static' if not exported.
4570 This makes it easier for human readers (and static analyzers)
4571 to see whether these variables are used from other modules.
4572 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4573 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4574 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4575 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4576 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4577 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4578 * xmenu.c, xselect.c:
4579 Declare Q* vars static if they are not used in other modules.
4580 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4581 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4582 Remove decls of unexported vars.
4583 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4584
4585 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4586
4587 Make Emacs functions such as Fatom 'static' by default.
4588 This makes it easier for human readers (and static analyzers)
4589 to see whether these functions can be called from other modules.
4590 DEFUN now defines a static function. To make the function external
4591 so that it can be used in other C modules, use the new macro DEFUE.
4592 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4593 (Finit_image_library):
4594 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4595 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4596 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4597 Remove decls, since these functions are now static.
4598 (Funintern, Fget_internal_run_time): New decls, since these functions
4599 were already external.
4600
4601 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4602 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4603 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4604 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4605 * keyboard.c, keymap.c, lread.c:
4606 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4607 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4608 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4609 Mark functions with DEFUE instead of DEFUN,
4610 if they are used in other modules.
4611 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4612 decls for now-static functions.
4613 * buffer.h (Fdelete_overlay): Remove decl.
4614 * callproc.c (Fgetenv_internal): Mark as internal.
4615 * composite.c (Fremove_list_of_text_properties): Remove decl.
4616 (Fcomposition_get_gstring): New forward static decl.
4617 * composite.h (Fcomposite_get_gstring): Remove decl.
4618 * dired.c (Ffile_attributes): New forward static decl.
4619 * doc.c (Fdocumntation_property): New forward static decl.
4620 * eval.c (Ffetch_bytecode): New forward static decl.
4621 (Funintern): Remove extern decl; now in .h file where it belongs.
4622 * fileio.c (Fmake_symbolic_link): New forward static decl.
4623 * image.c (Finit_image_library): New forward static decl.
4624 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4625 * intervals.h (Fprevious_property_change):
4626 (Fremove_list_of_text_properties): Remove decls.
4627 * keyboard.c (Fthis_command_keys): Remove decl.
4628 (Fcommand_execute): New forward static decl.
4629 * keymap.c (Flookup_key): New forward static decl.
4630 (Fcopy_keymap): Now static.
4631 * keymap.h (Flookup_key): Remove decl.
4632 * process.c (Fget_process): New forward static decl.
4633 (Fprocess_datagram_address): Mark as internal.
4634 * syntax.c (Fsyntax_table_p): New forward static decl.
4635 (skip_chars): Remove duplicate decl.
4636 * textprop.c (Fprevious_property_change): New forward static decl.
4637 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4638 Now internal.
4639 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4640 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4641
4642 * editfns.c (Fformat): Remove unreachable code.
4643
4644 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4645
4646 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4647 change. (Bug#8496)
4648
4649 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4650
4651 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4652 when at ZV. (Bug#8487)
4653
4654 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4655
4656 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4657 (Bug#8437)
4658 * keyboard.c (parse_tool_bar_item): Likewise.
4659 * sound.c (sound_cleanup, alsa_close): Likewise.
4660 * termcap.c (tgetent): Likewise.
4661 * xfns.c (x_default_font_parameter): Likewise.
4662 * xsettings.c (read_and_apply_settings): Likewise.
4663
4664 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4665 (overrun_check_free): Protoize.
4666
4667 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4668
4669 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4670 since callers should never pass a negative size.
4671 Change the signature to match that of plain 'read' and 'write'; see
4672 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4673 * lisp.h: Update prototypes of emacs_write and emacs_read.
4674
4675 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4676
4677 * xdisp.c (redisplay_window): Don't try to determine the character
4678 position of the scroll margin if the window start point w->startp
4679 is outside the buffer's accessible region. (Bug#8468)
4680
4681 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4682
4683 Fix write-region and its subroutines for buffers > 2GB.
4684 * fileio.c (a_write, e_write): Modify declaration of arguments and
4685 local variables to support buffers larger than 2GB.
4686 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4687
4688 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4689 argument, local variables, and return value.
4690
4691 * lisp.h: Update prototypes of emacs_write and emacs_read.
4692
4693 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4694
4695 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4696
4697 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4698
4699 Fix more problems found by GCC 4.6.0's static checks.
4700
4701 * xdisp.c (vmessage): Use a better test for character truncation.
4702
4703 * charset.c (load_charset_map): <, not <=, for optimization,
4704 and to avoid potential problems with integer overflow.
4705 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4706 * casetab.c (set_identity, shuffle): Likewise.
4707 * editfns.c (Fformat): Likewise.
4708 * syntax.c (skip_chars): Likewise.
4709
4710 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4711 This also lets GCC 4.6.0 generate slightly better loop code.
4712
4713 * callint.c (Fcall_interactively): <, not <=, for optimization.
4714 (Fcall_interactively): Count the number of arguments produced,
4715 not the number of arguments given. This is simpler and lets GCC
4716 4.6.0 generate slightly better code.
4717
4718 * ftfont.c: Distingish more carefully between FcChar8 and char.
4719 The previous code passed unsigned char * to a functions like
4720 strlen and xstrcasecmp that expect char *, which does not
4721 conform to the C standard.
4722 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4723 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4724 char * when the C standard requires it.
4725
4726 * keyboard.c (read_char): Remove unused var.
4727
4728 * eval.c: Port to Windows vsnprintf (Bug#8435).
4729 Include <limits.h>.
4730 (SIZE_MAX): Define if the headers do not.
4731 (verror): Do not give up if vsnprintf returns a negative count.
4732 Instead, grow the buffer. This ports to Windows vsnprintf, which
4733 does not conform to C99. Problem reported by Eli Zaretskii.
4734 Also, simplify the allocation scheme, by avoiding the need for
4735 calling realloc, and removing the ALLOCATED variable.
4736
4737 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4738
4739 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4740 But keep the doprint source code for now, as we might revamp it
4741 and use it again (Bug#8435).
4742 * lisp.h (doprnt): Remove.
4743 * Makefile.in (base_obj): Remove doprnt.o.
4744 * deps.mk (doprnt.o): Remove.
4745
4746 error: Print 32- and 64-bit integers portably (Bug#8435).
4747 Without this change, on typical 64-bit hosts error ("...%d...", N)
4748 was used to print both 32- and 64-bit integers N, which relied on
4749 undefined behavior.
4750 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4751 New macro.
4752 * lisp.h (error, verror): Mark as printf-like functions.
4753 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4754 Report overflow in size calculations when allocating printf buffer.
4755 Do not truncate output string at its first null byte.
4756 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4757 Truncate the output at a character boundary, since vsnprintf does not
4758 do that.
4759 * charset.c (check_iso_charset_parameter): Convert internal
4760 character to string before calling 'error', since %c now has the
4761 printf meaning.
4762 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4763 overflow when computing char to be passed to 'error'. Do not
4764 pass Lisp_Object to 'error'; pass the integer instead.
4765 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4766 formatted with plain %d.
4767
4768 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4769
4770 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4771
4772 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4773
4774 * xterm.c (x_catch_errors): Remove duplicate declaration.
4775
4776 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4777
4778 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4779
4780 2011-04-10 Jim Meyering <meyering@redhat.com>
4781
4782 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4783 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4784 return ssize_t not "int", and use size_t as the buffer length.
4785 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4786 * gnutls.h: Update declarations.
4787 * process.c (read_process_output): Use ssize_t, to match.
4788 (send_process): Likewise.
4789
4790 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4791
4792 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4793
4794 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4795
4796 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4797 Use unsigned char, to match FcChar8 type definition.
4798
4799 * xterm.c (handle_one_xevent):
4800 * xmenu.c (create_and_show_popup_menu):
4801 * xselect.c (x_decline_selection_request)
4802 (x_reply_selection_request): Avoid type-punned deref of X events.
4803
4804 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4805
4806 Fix some uses of `int' instead of EMACS_INT.
4807 * search.c (string_match_1, fast_string_match)
4808 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4809 (scan_buffer, find_next_newline_no_quit)
4810 (find_before_next_newline, search_command, Freplace_match)
4811 (Fmatch_data): Make some `int' variables be EMACS_INT.
4812
4813 * xdisp.c (display_count_lines): 3rd argument and return value now
4814 EMACS_INT. All callers changed.
4815 (pint2hrstr): Last argument is now EMACS_INT.
4816
4817 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4818 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4819 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4820 (decode_coding_utf_16, decode_coding_emacs_mule)
4821 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4822 (decode_coding_ccl, decode_coding_charset)
4823 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4824 (decode_coding_iso_2022, decode_coding_emacs_mule)
4825 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4826 <char_offset, last_offset>: Declare EMACS_INT.
4827 (encode_coding_utf_8, encode_coding_utf_16)
4828 (encode_coding_emacs_mule, encode_invocation_designation)
4829 (encode_designation_at_bol, encode_coding_iso_2022)
4830 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4831 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4832 Declare EMACS_INT.
4833 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4834 (encode_invocation_designation): Last argument P_NCHARS is now
4835 EMACS_INT.
4836 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4837 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4838
4839 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4840 All users changed.
4841
4842 * ccl.c (Fccl_execute_on_string): Declare some variables
4843 EMACS_INT.
4844
4845 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4846
4847 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4848
4849 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4850
4851 * process.c (Fformat_network_address): Doc fix.
4852
4853 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4854
4855 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4856
4857 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4858
4859 * keyboard.c (read_char): Call Lisp function help-form-show,
4860 instead of using internal_with_output_to_temp_buffer.
4861 (Qhelp_form_show): New var.
4862 (syms_of_keyboard): Use DEFSYM macro.
4863
4864 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4865
4866 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4867
4868 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4869
4870 * process.c (Flist_processes): Remove to Lisp.
4871 (list_processes_1): Delete.
4872
4873 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4874
4875 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4876
4877 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4878
4879 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4880
4881 Fix more problems found by GCC 4.6.0's static checks.
4882
4883 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4884
4885 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4886
4887 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4888
4889 * xdisp.c (vmessage): Mark as a printf-like function.
4890
4891 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4892
4893 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4894
4895 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4896 printf-like functions.
4897 (tiff_load): Add casts to remove these marks before passing them
4898 to system-supplied API.
4899
4900 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4901
4902 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4903 This avoids several warnings with gcc -Wstrict-overflow.
4904 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4905 directly, rather than having caller test rule sign. This avoids
4906 some unnecessary tests.
4907 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4908 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4909 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4910
4911 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4912 (xfont_open): Avoid unnecessary tests.
4913
4914 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4915
4916 * composite.h, composite.c (composition_gstring_put_cache):
4917 Use EMACS_INT, not int, for length.
4918
4919 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4920 breaking out part of COMPOSITION_DECODE_RULE.
4921 (COMPOSITION_DECODE_RULE): Use it.
4922 * composite.c (get_composition_id): Remove unused local vars,
4923 by using the new macro.
4924
4925 * textprop.c (set_text_properties_1): Change while to do-while,
4926 since the condition is always true at first.
4927
4928 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4929 (interval_deletion_adjustment): Return unsigned value.
4930 All uses changed.
4931
4932 * process.c (list_processes_1, create_pty, read_process_output):
4933 (exec_sentinel): Remove vars that were set but not used.
4934 (create_pty): Remove unnecessary "volatile"s.
4935 (Fnetwork_interface_info): Avoid possibility of int overflow.
4936 (read_process_output): Do adaptive read buffering even if carryover.
4937 (read_process_output): Simplify nbytes computation if buffered.
4938
4939 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4940
4941 * syntax.c (scan_words): Remove var that was set but not used.
4942 (update_syntax_table): Use unsigned instead of int.
4943
4944 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4945 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4946 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4947
4948 * print.c (print_error_message): Avoid int overflow.
4949
4950 * font.c (font_list_entities): Redo for clarity,
4951 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4952
4953 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4954 (font_score): Avoid potential overflow in diff calculation.
4955
4956 * fns.c (substring_both): Remove var that is set but not used.
4957 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4958
4959 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4960
4961 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4962 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4963 can always succeed if overflow has undefined behavior.
4964
4965 * search.c (boyer_moore, wordify): Remove vars set but not used.
4966 (wordify): Omit three unnecessary tests.
4967
4968 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4969 All callers changed. This avoids the need for an unused var.
4970
4971 * casefiddle.c (casify_region): Remove var that is set but not used.
4972
4973 * dired.c (file_name_completion): Remove var that is set but not used.
4974
4975 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4976
4977 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4978 (Finsert_file_contents): Remove unnecessary code checking fd.
4979
4980 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4981 Check for integer overflow on size calculations.
4982
4983 * buffer.c (Fprevious_overlay_change): Remove var that is set
4984 but not used.
4985
4986 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4987 Remove vars that are set but not used.
4988 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4989 (timer_check_2): Mark vars as initialized.
4990
4991 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4992
4993 * image.c (lookup_image): Remove var that is set but not used.
4994 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4995
4996 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4997 that are set but not used.
4998
4999 * xfns.c (make_invisible_cursor): Don't return garbage
5000 if XCreateBitmapFromData fails (Bug#8410).
5001
5002 * xselect.c (x_get_local_selection, x_handle_property_notify):
5003 Remove vars that are set but not used.
5004
5005 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5006 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5007
5008 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5009 Remove var that is set but not used.
5010 (scroll_bar_windows_size): Now size_t, not int.
5011 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5012 Check for overflow.
5013
5014 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5015 (map_tty_color) [!defined MSDOS]: Likewise.
5016
5017 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5018
5019 * coding.c: Remove vars that are set but not used.
5020 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5021 All callers changed.
5022 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5023 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5024 (decode_coding_charset): Remove vars that are set but not used.
5025
5026 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5027 that is set but not used.
5028
5029 * print.c (print_object): Remove var that is set but not used.
5030
5031 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5032 The gnulib version avoids calling malloc in the usual case,
5033 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5034 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5035 * filelock.c (current_lock_owner): Likewise.
5036 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5037 * sysdep.c: Include allocator.h, careadlinkat.h.
5038 (emacs_no_realloc_allocator): New static constant.
5039 (emacs_readlink): New function.
5040 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5041 ../lib/careadlinkat.h.
5042
5043 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5044
5045 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5046 first non-nil return value).
5047
5048 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5049
5050 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5051 if not defined (Bug#8403).
5052
5053 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5054
5055 * xdisp.c (display_count_lines): Remove parameter `start',
5056 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5057 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5058 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5059 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5060 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5061 and thereabouts. All callers changed.
5062 (get_per_char_metric): Remove parameter `f', unused since
5063 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5064
5065 2011-04-02 Jim Meyering <meyering@redhat.com>
5066
5067 do not dereference NULL upon failed strdup
5068 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5069 (ns_get_family): Likewise.
5070
5071 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5072
5073 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5074
5075 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5076
5077 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5078 later (Bug#8403).
5079
5080 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5081
5082 Add lexical binding.
5083
5084 * window.c (Ftemp_output_buffer_show): New fun.
5085 (Fsave_window_excursion):
5086 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5087
5088 * lread.c (lisp_file_lexically_bound_p): New function.
5089 (Fload): Bind Qlexical_binding.
5090 (readevalloop): Remove `evalfun' arg.
5091 Bind Qinternal_interpreter_environment.
5092 (Feval_buffer): Bind Qlexical_binding.
5093 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5094 Mark as dynamic.
5095 (syms_of_lread): Declare `lexical-binding'.
5096
5097 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5098
5099 * keyboard.c (eval_dyn): New fun.
5100 (menu_item_eval_property): Use it.
5101
5102 * image.c (parse_image_spec): Use Ffunctionp.
5103
5104 * fns.c (concat, mapcar1): Accept byte-code-functions.
5105
5106 * eval.c (Fsetq): Handle lexical vars.
5107 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5108 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5109 (FletX, Flet): Obey lexical binding.
5110 (Fcommandp): Handle closures.
5111 (Feval): New `lexical' arg.
5112 (eval_sub): New function extracted from Feval. Use it almost
5113 everywhere where Feval was used. Look up vars in lexical env.
5114 Handle closures.
5115 (Ffunctionp): Move from subr.el.
5116 (Ffuncall): Handle closures.
5117 (apply_lambda): Remove `eval_flags'.
5118 (funcall_lambda): Handle closures and new byte-code-functions.
5119 (Fspecial_variable_p): New function.
5120 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5121 but without exporting it to Lisp.
5122
5123 * doc.c (Fdocumentation, store_function_docstring):
5124 * data.c (Finteractive_form): Handle closures.
5125
5126 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5127 interactive spec.
5128
5129 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5130 New byte-codes.
5131 (exec_byte_code): New function extracted from Fbyte_code to handle new
5132 calling convention for byte-code-functions. Add new byte-codes.
5133
5134 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5135
5136 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5137
5138 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5139
5140 * xdisp.c (redisplay_internal): Fix prototype.
5141
5142 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5143
5144 * xdisp.c (SCROLL_LIMIT): New macro.
5145 (try_scrolling): Use it when setting scroll_limit.
5146 Limit scrolling to 100 screen lines.
5147 (redisplay_window): Even when falling back on "recentering",
5148 position point in the window according to scroll-conservatively,
5149 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5150
5151 (try_scrolling): When point is above the window, allow searching
5152 as far as scroll_max, or one screenful, to compute vertical
5153 distance from PT to the scroll margin position. This prevents
5154 try_scrolling from unnecessarily failing when
5155 scroll-conservatively is set to a value slightly larger than the
5156 window height. Clean up the case of PT below the margin at bottom
5157 of window: scroll_max can no longer be INT_MAX. When aggressive
5158 scrolling is in use, don't let point enter the opposite scroll
5159 margin as result of the scroll.
5160 (syms_of_xdisp) <scroll-conservatively>: Document the
5161 threshold of 100 lines for never-recentering scrolling.
5162
5163 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5164
5165 * dispextern.h (move_it_by_lines):
5166 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5167 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5168 (message_log_check_duplicate): Remove parameters `prev_bol' and
5169 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5170 (redisplay_internal): Remove parameter `preserve_echo_area',
5171 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5172
5173 * indent.c (Fvertical_motion):
5174 * window.c (window_scroll_pixel_based, Frecenter):
5175 Don't pass `need_y_p' to `move_it_by_lines'.
5176
5177 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5178
5179 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5180 steal a few bits to be more compact.
5181 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5182 Remove unneeded casts.
5183
5184 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5185
5186 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5187
5188 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5189 binding" message (bug#7967).
5190
5191 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5192
5193 Fix more problems found by GCC 4.6.0's static checks.
5194
5195 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5196 Remove unused local var.
5197
5198 * editfns.c (Fmessage_box): Remove unused local var.
5199
5200 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5201 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5202 Omit unused local vars.
5203 * window.c (shrink_windows): Omit unused local var.
5204 * menu.c (digest_single_submenu): Omit unused local var.
5205 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5206 Omit unused local var.
5207
5208 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5209 Don't assume string length fits in int.
5210 (keyremap_step, read_key_sequence): Use size_t for sizes.
5211 (read_key_sequence): Don't check last_real_key_start redundantly.
5212
5213 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5214 instead of alloca (Bug#8344).
5215
5216 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5217 (Fbacktrace_frame): Don't assume nframes fits in int.
5218
5219 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5220
5221 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5222 concerns.
5223
5224 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5225
5226 * cm.c (calccost): Turn while-do into do-while, for clarity.
5227
5228 * keyboard.c (syms_of_keyboard): Use the same style as later
5229 in this function when indexing through an array. This also
5230 works around GCC bug 48267.
5231
5232 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5233
5234 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5235
5236 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5237 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5238
5239 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5240 This avoids undefined behavior on integer overflow, and is a bit
5241 more convenient anyway since it is compared to a size_t variable.
5242
5243 Variadic C functions now count arguments with size_t, not int.
5244 This avoids an unnecessary limitation on 64-bit machines, which
5245 caused (substring ...) to crash on large vectors (Bug#8344).
5246 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5247 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5248 All variadic functions and their callers changed accordingly.
5249 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5250 * data.c (arith_driver, float_arith_driver): Likewise.
5251 * editfns.c (general_insert_function): Likewise.
5252 * eval.c (struct backtrace.nargs, interactive_p)
5253 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5254 (funcall_lambda, mark_backtrace): Likewise.
5255 * fns.c (concat): Likewise.
5256 * frame.c (x_set_frame_parameters): Likewise.
5257 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5258 0 if not found, not -1. All callers changed.
5259
5260 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5261 (stack_copy_size): Now size_t, not int.
5262 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5263
5264 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5265
5266 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5267 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5268 All callers changed.
5269
5270 * lisp.h (multibyte_char_to_unibyte):
5271 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5272 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5273 * character.h (CHAR_TO_BYTE8):
5274 * cmds.c (internal_self_insert):
5275 * editfns.c (general_insert_function):
5276 * keymap.c (push_key_description):
5277 * search.c (Freplace_match):
5278 * xdisp.c (message_dolog, set_message_1): All callers changed.
5279
5280 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5281
5282 * keyboard.c (safe_run_hook_funcall): New function.
5283 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5284 don't set the hook to nil, but remove the offending function instead.
5285 (Qcommand_hook_internal): Remove, unused.
5286 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5287 Vcommand_hook_internal.
5288
5289 * eval.c (enum run_hooks_condition): Remove.
5290 (funcall_nil, funcall_not): New functions.
5291 (run_hook_with_args): Call each function through a `funcall' argument.
5292 Remove `cond' argument, now redundant.
5293 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5294 (Frun_hook_with_args_until_failure): Adjust accordingly.
5295 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5296
5297 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5298
5299 * dispextern.h (string_buffer_position): Remove declaration.
5300
5301 * print.c (strout): Remove parameter `multibyte', unused since
5302 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5303
5304 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5305 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5306 All callers changed.
5307
5308 * w32.c (_wsa_errlist): Use braces for struct initializers.
5309
5310 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5311 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5312 All callers changed.
5313 (string_buffer_position): Likewise. Also, make static (it's never
5314 used outside xdisp.c).
5315 (cursor_row_p): Remove parameter `w', unused since
5316 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5317 (decode_mode_spec): Remove parameter `precision', introduced during
5318 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5319 All callers changed.
5320
5321 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5322
5323 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5324
5325 2011-03-27 Anders Lindgren <andlind@gmail.com>
5326
5327 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5328 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5329 (ns_update_auto_hide_menu_bar): New functions.
5330 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5331 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5332 ns_constrain_all_frames.
5333 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5334 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5335
5336 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5337
5338 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5339
5340 2011-03-27 Glenn Morris <rgm@gnu.org>
5341
5342 * syssignal.h: Replace RETSIGTYPE with void.
5343 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5344 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5345 Replace SIGTYPE with void everywhere.
5346 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5347 * s/template.h (SIGTYPE): Remove commented out definition.
5348
5349 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5350
5351 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5352 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5353
5354 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5355
5356 * w32.c (read_unc_volume): Use parameter `henum', instead of
5357 global variable `wget_enum_handle'.
5358
5359 * keymap.c (describe_vector): Remove parameters `indices' and
5360 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5361 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5362
5363 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5364
5365 * keyboard.c (timer_check): Remove parameter `do_it_now',
5366 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5367 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5368 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5369
5370 * keyboard.c (read_char):
5371 * w32menu.c (w32_menu_display_help):
5372 * xmenu.c (show_help_event, menu_help_callback):
5373 Adjust calls to `show_help_echo'.
5374
5375 * gtkutil.c (xg_maybe_add_timer):
5376 * keyboard.c (readable_events):
5377 * process.c (wait_reading_process_output):
5378 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5379
5380 * insdel.c (adjust_markers_gap_motion):
5381 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5382 (gap_left, gap_right): Don't call it.
5383
5384 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5385
5386 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5387 incurred during fontification.
5388
5389 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5390
5391 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5392 (DEFVAR_PER_BUFFER): Don't pass it.
5393
5394 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5395 (scrolling_window): Don't pass it.
5396
5397 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5398
5399 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5400
5401 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5402 and `suffix'.
5403 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5404 of variables specific to SELinux and computation of `encoded_absname'.
5405
5406 * image.c (XPutPixel): Remove unused variable `height'.
5407
5408 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5409
5410 * unexw32.c (get_section_info): Remove unused variable `section'.
5411
5412 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5413 (system_process_attributes): Remove unused variable `sess'.
5414 (sys_read): Remove unused variable `err'.
5415
5416 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5417 (w32_wnd_proc): Remove unused variable `isdead'.
5418 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5419 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5420 (x_create_tip_frame): Remove unused variable `tem'.
5421
5422 * w32inevt.c (w32_console_read_socket):
5423 Remove unused variable `no_events'.
5424
5425 * w32term.c (x_draw_composite_glyph_string_foreground):
5426 Remove unused variable `width'.
5427
5428 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5429
5430 * w32term.c (x_set_glyph_string_clipping):
5431 Don't pass uninitialized region to CombineRgn.
5432
5433 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5434
5435 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5436 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5437 (Fx_close_connection): Remove unused variable `i'.
5438
5439 * w32font.c (w32font_draw): Return number of glyphs.
5440 (w32font_open_internal): Remove unused variable `i'.
5441 (w32font_driver): Add missing initializer.
5442
5443 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5444 (fill_in_menu): Remove unused variable `items_added'.
5445
5446 * w32term.c (last_mouse_press_frame): Remove static global variable.
5447 (w32_clip_to_row): Remove unused variable `f'.
5448 (x_delete_terminal): Remove unused variable `i'.
5449
5450 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5451 (NOTHING): Remove unused static global variable.
5452 (uniscribe_check_otf): Remove unused variable `table'.
5453 (uniscribe_font_driver): Add missing initializers.
5454
5455 2011-03-23 Julien Danjou <julien@danjou.info>
5456
5457 * term.c (Fsuspend_tty, Fresume_tty):
5458 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5459 * window.c (temp_output_buffer_show):
5460 * insdel.c (signal_before_change):
5461 * frame.c (Fhandle_switch_frame):
5462 * fileio.c (Fdo_auto_save):
5463 * emacs.c (Fkill_emacs):
5464 * editfns.c (save_excursion_restore):
5465 * cmds.c (internal_self_insert):
5466 * callint.c (Fcall_interactively):
5467 * buffer.c (Fkill_all_local_variables):
5468 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5469 Use Frun_hooks.
5470 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5471 unconditionnaly since it does the check itself.
5472
5473 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5474
5475 Fix more problems found by GCC 4.5.2's static checks.
5476
5477 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5478 the first time through the loop, since we know p0 < p1 then.
5479 This also avoids a gcc -Wstrict-overflow warning.
5480
5481 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5482 leading to a memory leak, possible in functions like
5483 load_charset_map_from_file that can allocate an unbounded number
5484 of objects (Bug#8318).
5485
5486 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5487 that could (at least in theory) be that large.
5488
5489 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5490 This is less likely to overflow, and avoids undefined behavior if
5491 overflow does occur. All callers changed. Use strtoul to scan
5492 for the unsigned long integer.
5493 (pint2hrstr): Simplify and tune code slightly.
5494 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5495
5496 * scroll.c (do_scrolling): Work around GCC bug 48228.
5497 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5498
5499 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5500 This also avoids a warning with gcc -Wstrict-overflow.
5501 (validate_x_resource_name): Simplify count usage.
5502 This also avoids a warning with gcc -Wstrict-overflow.
5503
5504 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5505 fail (Bug#8306).
5506
5507 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5508
5509 * process.c (Fmake_network_process): Use socklen_t, not int,
5510 where POSIX says socklen_t is required in portable programs.
5511 This fixes a porting bug on hosts like 64-bit HP-UX, where
5512 socklen_t is wider than int (Bug#8277).
5513 (Fmake_network_process, server_accept_connection):
5514 (wait_reading_process_output, read_process_output):
5515 Likewise.
5516
5517 * process.c: Rename or move locals to avoid shadowing.
5518 (list_processes_1, Fmake_network_process):
5519 (read_process_output_error_handler, exec_sentinel_error_handler):
5520 Rename or move locals.
5521 (Fmake_network_process): Define label "retry_connect" only if needed.
5522 (Fnetwork_interface_info): Fix pointer signedness.
5523 (process_send_signal): Add cast to avoid pointer signedness problem.
5524 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5525 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5526
5527 Make tparam.h and terminfo.c consistent.
5528 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5529 Include tparam.h instead, since it declares them.
5530 * cm.h (PC): Remove extern decl; tparam.h now does this.
5531 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5532 * terminfo.c: Include tparam.h, to check interfaces.
5533 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5534 (tparam): Adjust signature to match interface in tparam.h;
5535 this removes some undefined behavior. Check that outstring and len
5536 are zero, which they always are with Emacs.
5537 * tparam.h (PC, BC, UP): New extern decls.
5538
5539 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5540 (xftfont_open): Rename locals to avoid shadowing.
5541
5542 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5543 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5544 (OTF_TAG_SYM): Omit macro if not needed.
5545 (ftfont_list): Remove unused local.
5546 (get_adstyle_property, ftfont_pattern_entity):
5547 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5548 Rename locals to avoid shadowing.
5549
5550 * xfont.c (xfont_list_family): Mark var as initialized.
5551
5552 * xml.c (make_dom): Now static.
5553
5554 * composite.c (composition_compute_stop_pos): Rename local to
5555 avoid shadowing.
5556 (composition_reseat_it): Remove unused locals.
5557 (find_automatic_composition, composition_adjust_point): Likewise.
5558 (composition_update_it): Mark var as initialized.
5559 (find_automatic_composition): Mark vars as initialized,
5560 with a FIXME (Bug#8290).
5561
5562 character.h: Rename locals to avoid shadowing.
5563 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5564 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5565 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5566 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5567 to avoid shadowing.
5568
5569 * textprop.c (property_change_between_p): Remove; unused.
5570
5571 * intervals.c (interval_start_pos): Now static.
5572
5573 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5574
5575 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5576 Rename locals to avoid shadowing.
5577
5578 * sound.c (wav_play, au_play, Fplay_sound_internal):
5579 Fix pointer signedness.
5580 (alsa_choose_format): Remove unused local var.
5581 (wav_play): Initialize a variable to 0, to prevent undefined
5582 behavior (Bug#8278).
5583
5584 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5585
5586 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5587
5588 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5589 clobbering (Bug#8298).
5590 * sysdep.c (sys_subshell): Likewise.
5591 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5592
5593 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5594 This should get cleaned up, so that child_setup has the
5595 same signature on all platforms.
5596
5597 * callproc.c (call_process_cleanup): Now static.
5598 (relocate_fd): Rename locals to avoid shadowing.
5599
5600 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5601
5602 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5603 not to be necessary, and produces flickering.
5604
5605 2011-03-20 Glenn Morris <rgm@gnu.org>
5606
5607 * config.in: Remove file.
5608
5609 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5610
5611 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5612 are now in src/globals.h.
5613 (syms_of_minibuf): Remove spurious & from previous change.
5614
5615 2011-03-20 Leo <sdl.web@gmail.com>
5616
5617 * minibuf.c (completing-read-function): New variable.
5618 (completing-read-default): Rename from completing-read.
5619 (completing-read): Call completing-read-function.
5620
5621 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5622
5623 * xfaces.c (Fx_load_color_file):
5624 Read color file from absolute filename (bug#8250).
5625
5626 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5627
5628 * makefile.w32-in: Update dependencies.
5629
5630 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5631
5632 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5633
5634 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5635
5636 Fix more problems found by GCC 4.5.2's static checks.
5637
5638 * process.c (make_serial_process_unwind, send_process_trap):
5639 (sigchld_handler): Now static.
5640
5641 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5642 That way, the code declares only the vars that it needs.
5643 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5644 * s/cygwin.h (PTY_ITERATION): Likewise.
5645 * s/darwin.h (PTY_ITERATION): Likewise.
5646 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5647
5648 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5649 * process.c (allocate_pty): Don't declare stb unless it's needed.
5650
5651 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5652 (CONSTANTLIM): Remove; unused.
5653 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5654 Define only if needed.
5655
5656 * unexelf.c (unexec): Name an expression,
5657 to avoid gcc -Wbad-function-cast warning.
5658 Use a different way to cause a compilation error if anyone uses
5659 n rather than nn, a way that does not involve shadowing.
5660 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5661
5662 * deps.mk (unexalpha.o): Remove; unused.
5663
5664 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5665 * unexec.h: New file.
5666 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5667 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5668 Depend on unexec.h.
5669 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5670 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5671 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5672 Change as necessary to match prototype in unexec.h.
5673
5674 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5675 shadowing.
5676 (back_comment, skip_chars): Mark vars as initialized.
5677
5678 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5679 Rename locals to avoid shadowing.
5680
5681 * lread.c (read1): Rewrite so as not to use empty "else".
5682 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5683
5684 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5685
5686 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5687 warning when compiling print.c.
5688
5689 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5690 instead of using an uninitialized var.
5691 (font_sort_entities): Mark var as initialized.
5692
5693 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5694
5695 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5696 pointers to constants.
5697 (font_parse_fcname): Remove unused vars.
5698 (font_delete_unmatched): Now static.
5699 (font_get_spec): Remove; unused.
5700 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5701 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5702 Rename or move locals to avoid shadowing.
5703
5704 * fns.c (require_nesting_list, require_unwind): Now static.
5705 (Ffillarray): Rename locals to avoid shadowing.
5706
5707 * floatfns.c (domain_error2): Define only if needed.
5708 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5709
5710 * alloc.c (mark_backtrace): Move decl from here ...
5711 * lisp.h: ... to here, so that it can be checked.
5712
5713 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5714 (Fdefvar): Rewrite so as not to use empty "else".
5715 (lisp_indirect_variable): Name an expression,
5716 to avoid gcc -Wbad-function-cast warning.
5717 (Fdefvar): Rename locals to avoid shadowing.
5718
5719 * callint.c (quotify_arg, quotify_args): Now static.
5720 (Fcall_interactively): Rename locals to avoid shadowing.
5721 Use const pointer when appropriate.
5722
5723 * lisp.h (get_system_name, get_operating_system_release):
5724 Move decls here, to check interfaces.
5725 * process.c (get_operating_system_release): Move decl to lisp.h.
5726 * xrdb.c (get_system_name): Likewise.
5727 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5728 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5729 some of which prompt warnings from gcc -Wbad-function-cast.
5730 (Fformat_time_string, Fencode_time, Finsert_char):
5731 (Ftranslate_region_internal, Fformat):
5732 Rename or remove local vars to avoid shadowing.
5733 (Ftranslate_region_internal): Mark var as initialized.
5734
5735 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5736 avoid shadowing.
5737
5738 * lisp.h (eassert): Check that the argument compiles, even if
5739 ENABLE_CHECKING is not defined.
5740
5741 * data.c (Findirect_variable): Name an expression, to avoid
5742 gcc -Wbad-function-cast warning.
5743 (default_value, arithcompare, arith_driver, arith_error): Now static.
5744 (store_symval_forwarding): Rename local to avoid shadowing.
5745 (Fmake_variable_buffer_local, Fmake_local_variable):
5746 Mark variables as initialized.
5747 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5748
5749 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5750 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5751 Rename locals to avoid shadowing.
5752 (mark_stack): Move local variables into the #ifdef region where
5753 they're used.
5754 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5755 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5756 needed otherwise.
5757 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5758 (GC_STRING_CHARS): Remove; not used.
5759 (Fmemory_limit): Cast sbrk's returned value to char *.
5760
5761 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5762 avoids undefined behavior in theory.
5763
5764 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5765
5766 Use functions, not macros, for up- and down-casing (Bug#8254).
5767 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5768 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5769 to use the following functions instead of these macros.
5770 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5771 EMACS_INT, since callers assume the returned value fits in int.
5772 (upcase1): Likewise, for UPCASE_TABLE.
5773 (uppercasep, lowercasep, upcase): New static inline functions.
5774 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5775 the race-condition problem in the old DOWNCASE.
5776
5777 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5778 Rename locals to avoid shadowing.
5779 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5780 (regex_compile, re_search_2, re_match_2_internal):
5781 Remove unused local vars.
5782 (FREE_VAR): Rewrite so as not to use empty "else",
5783 which gcc can warn about.
5784 (regex_compile, re_match_2_internal): Mark locals as initialized.
5785 (RETALLOC_IF): Define only if needed.
5786 (WORDCHAR_P): Likewise. This one is never needed, but is used
5787 only in a comment talking about a compiler bug, so put inside
5788 the #if 0 of that comment.
5789 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5790 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5791 Remove; unused.
5792
5793 * search.c (boyer_moore): Rename locals to avoid shadowing.
5794 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5795 (PREV_CHAR_BOUNDARY): Likewise.
5796
5797 * search.c (simple_search): Remove unused var.
5798
5799 * dired.c (compile_pattern): Move decl from here ...
5800 * lisp.h: ... to here, so that it can be checked.
5801 (struct re_registers): New forward decl.
5802
5803 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5804
5805 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5806 All uses changed.
5807 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5808 Rename locals to avoid shadowing.
5809 (Fvertical_motion): Mark locals as initialized.
5810
5811 * casefiddle.c (casify_object, casify_region): Now static.
5812 (casify_region): Mark local as initialized.
5813
5814 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5815
5816 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5817 New macros, so that the caller can use some names other than
5818 gcpro1, gcpro2, etc.
5819 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5820 of the new macros.
5821 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5822 argument, for consistency with GCPRO2_VAR, etc: it is now the
5823 prefix of the variable, not the variable itself. All uses
5824 changed.
5825 * dired.c (directory_files_internal, file_name_completion):
5826 Rename locals to avoid shadowing.
5827
5828 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5829 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5830 dired.c's scmp function, had undefined behavior.
5831 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5832 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5833 * buffer.h: ... to here, because these macros use current_buffer,
5834 and the new implementation with inline functions needs to have
5835 current_buffer in scope now, rather than later when the macros
5836 are used.
5837 (downcase, upcase1): New static inline functions.
5838 (DOWNCASE, UPCASE1): Reimplement using these functions.
5839 This avoids undefined behavior in expressions like
5840 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5841 from race conditions in accessing the global variables
5842 case_temp1 and case_temp2.
5843 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5844 * lisp.h (case_temp1, case_temp2): Remove their decls.
5845 * character.h (ASCII_CHAR_P): Move from here ...
5846 * lisp.h: ... to here, so that the inline functions mentioned
5847 above can use them.
5848
5849 * dired.c (directory_files_internal_unwind): Now static.
5850
5851 * fileio.c (file_name_as_directory, directory_file_name):
5852 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5853 Now static.
5854 (file_name_as_directory): Use const pointers when appropriate.
5855 (Fexpand_file_name): Likewise. In particular, newdir might
5856 point at constant storage, so make it a const pointer.
5857 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5858 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5859 signedness issues.
5860 (Fset_file_times, Finsert_file_contents, auto_save_error):
5861 Rename locals to avoid shadowing.
5862
5863 * minibuf.c (choose_minibuf_frame_1): Now static.
5864 (Ftry_completion, Fall_completions): Rename or remove locals
5865 to avoid shadowing.
5866
5867 * marker.c (bytepos_to_charpos): Remove; unused.
5868
5869 * lisp.h (verify_bytepos, count_markers): New decls,
5870 so that gcc does not warn that these functions aren't declared.
5871
5872 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5873 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5874 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5875 (copy_text): Remove unused local var.
5876
5877 * filelock.c (within_one_second): Now static.
5878 (lock_file_1): Rename local to avoid shadowing.
5879
5880 * buffer.c (fix_overlays_before): Mark locals as initialized.
5881 (fix_start_end_in_overlays): Likewise. This function should be
5882 simplified by using pointers-to-pointers, but that's a different
5883 matter.
5884 (switch_to_buffer_1): Now static.
5885 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5886 (report_overlay_modification): Rename locals to avoid shadowing.
5887
5888 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5889 Fix pointer signedness issue.
5890 (sys_subshell): Mark local as volatile if checking for lint,
5891 to suppress a gcc -Wclobbered warning that does not seem to be right.
5892 (MAXPATHLEN): Define only if needed.
5893
5894 * process.c (serial_open, serial_configure): Move decls from here ...
5895 * systty.h: ... to here, so that they can be checked.
5896
5897 * fns.c (get_random, seed_random): Move extern decls from here ...
5898 * lisp.h: ... to here, so that they can be checked.
5899
5900 * sysdep.c (reset_io): Now static.
5901 (wait_for_termination_signal): Remove; unused.
5902
5903 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5904 (copy_keymap_item, append_key, push_text_char_description):
5905 Now static.
5906 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5907 (DENSE_TABLE_SIZE): Remove; unused.
5908 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5909 (describe_map_tree):
5910 Rename locals to avoid shadowing.
5911
5912 * keyboard.c: Declare functions static if they are not used elsewhere.
5913 (echo_char, echo_dash, cmd_error, top_level_2):
5914 (poll_for_input, handle_async_input): Now static.
5915 (read_char, kbd_buffer_get_event, make_lispy_position):
5916 (make_lispy_event, make_lispy_movement, apply_modifiers):
5917 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5918 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5919 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5920 (read_key_sequence, read_char): Mark locals as initialized.
5921 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5922
5923 * keyboard.h (make_ctrl_char): New decl.
5924 (mark_kboards): Move decl here ...
5925 * alloc.c (mark_kboards): ... from here.
5926
5927 * lisp.h (force_auto_save_soon): New decl.
5928
5929 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5930 (DEFINE_DUMMY_FUNCTION): New macro.
5931 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5932 Use it.
5933 (main): Add casts to avoid warnings
5934 if GCC considers string literals to be constants.
5935
5936 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5937
5938 * dbusbind.c: Pointer signedness fixes.
5939 (xd_signature, xd_append_arg, xd_initialize):
5940 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5941 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5942 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5943 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5944
5945 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5946 if GCC considers string literals to be constants.
5947 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5948
5949 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5950
5951 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5952 (print_preprocess, print_object): New macro to fix last change.
5953
5954 * print.c (print_preprocess): Don't forget font objects.
5955
5956 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5957
5958 * emacs.c (USAGE3): Doc fixes.
5959
5960 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5961
5962 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5963 structure.
5964
5965 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5966
5967 * lisp.h (VWindow_system, Qfile_name_history):
5968 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5969 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5970 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5971
5972 * w32select.c: Don't #include "keyboard.h".
5973 (run_protected): Add extern declaration for waiting_for_input.
5974
5975 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5976 * w32console.c (detect_input_pending, read_input_pending)
5977 (encode_terminal_code):
5978 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5979 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5980 (w32_system_caret_y, Qfile_name_history):
5981 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5982 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5983 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5984 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5985 * w32proc.c (Qlocal, report_file_error):
5986 * w32term.c (Vwindow_system, updating_frame):
5987 * w32uniscribe.c (initialized, uniscribe_font_driver):
5988 Remove unneeded extern declarations.
5989
5990 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5991
5992 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5993
5994 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
5995
5996 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5997 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5998 These macros can no longer be used for assignment.
5999
6000 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6001 Assign struct members directly, instead of using BUF_BEGV etc.
6002 (record_buffer_markers, fetch_buffer_markers): New functions for
6003 recording and fetching special buffer markers.
6004 (set_buffer_internal_1, set_buffer_temp): Use them.
6005
6006 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6007
6008 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6009
6010 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6011 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6012
6013 * xdisp.c (hscroll_window_tree):
6014 (reconsider_clip_changes): Use PT instead of BUF_PT.
6015
6016 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6017
6018 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6019 $(EMACS_ROOT)/lib/intprops.h.
6020
6021 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6022
6023 Fix more problems found by GCC 4.5.2's static checks.
6024
6025 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6026 to unsigned char * to avoid compiler diagnostic.
6027 (xg_free_frame_widgets): Make it clear that a local variable is
6028 needed only if USE_GTK_TOOLTIP.
6029 (gdk_window_get_screen): Make it clear that this macro is needed
6030 only if USE_GTK_TOOLTIP.
6031 (int_gtk_range_get_value): New function, which avoids a diagnostic
6032 from gcc -Wbad-function-cast.
6033 (xg_set_toolkit_scroll_bar_thumb): Use it.
6034 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6035 diagnostic from gcc -Wbad-function-cast.
6036 (get_utf8_string, xg_get_file_with_chooser):
6037 Rename locals to avoid shadowing.
6038 (create_dialog): Move locals to avoid shadowing.
6039
6040 * xgselect.c (xg_select): Remove unused var.
6041
6042 * image.c (four_corners_best): Mark locals as initialized.
6043 (gif_load): Initialize transparent_p to zero (Bug#8238).
6044 Mark another local as initialized.
6045 (my_png_error, my_error_exit): Mark with NO_RETURN.
6046
6047 * image.c (clear_image_cache): Now static.
6048 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6049 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6050 (x_edge_detection): Remove unnecessary cast that
6051 gcc -Wbad-function-cast diagnoses.
6052 (gif_load): Fix pointer signedness.
6053 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6054 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6055
6056 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6057
6058 Improve quality of tests for time stamp overflow.
6059 For example, without this patch (encode-time 0 0 0 1 1
6060 1152921504606846976) returns the obviously-bogus value (-948597
6061 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6062 reports time overflow. See
6063 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6064 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6065 * editfns.c: Include limits.h and intprops.h.
6066 (TIME_T_MIN, TIME_T_MAX): New macros.
6067 (time_overflow): Move earlier, to before first use.
6068 (hi_time, lo_time): New functions, for an accurate test for
6069 out-of-range times.
6070 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6071 (Fget_internal_run_time): Don't assume time_t fits in int.
6072 (make_time): Use list2 instead of Fcons twice.
6073 (Fdecode_time): More accurate test for out-of-range times.
6074 (check_tm_member): New function.
6075 (Fencode_time): Use it, to test for out-of-range times.
6076 (lisp_time_argument): Don't rely on undefined left-shift and
6077 right-shift behavior when checking for time stamp overflow.
6078
6079 * editfns.c (time_overflow): New function, refactoring common code.
6080 (Fformat_time_string, Fdecode_time, Fencode_time):
6081 (Fcurrent_time_string): Use it.
6082
6083 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6084 * dired.c (make_time): Move to ...
6085 * editfns.c (make_time): ... here.
6086 * systime.h: Note the move.
6087
6088 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6089
6090 * fringe.c (update_window_fringes): Remove unused variables.
6091
6092 * unexmacosx.c (copy_data_segment): Also copy __got section.
6093 (Bug#8223)
6094
6095 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6096
6097 * termcap.c [MSDOS]: Include "msdos.h".
6098 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6099 Constify `char *' arguments and their references according to
6100 prototypes in tparam.h.
6101
6102 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6103
6104 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6105 Adapt all references accordingly.
6106
6107 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6108
6109 2011-03-11 Tom Tromey <tromey@redhat.com>
6110
6111 * buffer.c (syms_of_buffer): Remove obsolete comment.
6112
6113 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6114
6115 * termhooks.h (encode_terminal_code): Declare prototype.
6116
6117 * msdos.c (encode_terminal_code): Don't declare prototype.
6118
6119 * term.c (encode_terminal_code): Now external again, used by
6120 w32console.c and msdos.c.
6121
6122 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6123 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6124
6125 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6126
6127 Fix some minor problems found by GCC 4.5.2's static checks.
6128
6129 * fringe.c (update_window_fringes): Mark locals as initialized
6130 (Bug#8227).
6131 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6132
6133 * alloc.c (mark_fringe_data): Move decl from here ...
6134 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6135 to check its interface.
6136 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6137
6138 * fontset.c (free_realized_fontset): Now static.
6139 (Fset_fontset_font): Rename local to avoid shadowing.
6140 (fontset_font): Mark local as initialized.
6141 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6142
6143 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6144
6145 * xselect.c (x_disown_buffer_selections): Remove; not used.
6146 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6147 (x_own_selection, Fx_disown_selection_internal): Rename locals
6148 to avoid shadowing.
6149 (x_handle_dnd_message): Remove local to avoid shadowing.
6150
6151 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6152 so that the caller can use some name other than gcpro1.
6153 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6154 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6155 (Fx_backspace_delete_keys_p):
6156 Use them to avoid shadowing, and rename vars to avoid shadowing.
6157 (x_decode_color, x_set_name, x_window): Now static.
6158 (Fx_create_frame): Add braces to silence GCC warning.
6159 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6160 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6161 Remove unused locals.
6162 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6163 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6164 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6165 macros.
6166
6167 * xterm.h (x_mouse_leave): New decl.
6168
6169 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6170 Remove unused functions.
6171 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6172 (x_calc_absolute_position): Now static.
6173 (XTread_socket): Don't define label "out" unless it's used.
6174 Don't declare local "event" unless it's used.
6175 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6176 unless they are used.
6177 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6178 (x_fatal_error_signal): Remove; not used.
6179 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6180 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6181 (x_error_catcher, x_connection_closed, x_error_handler):
6182 (x_error_quitter, xembed_send_message, x_iconify_frame):
6183 (my_log_handler): Rename locals to avoid shadowing.
6184 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6185 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6186
6187 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6188 Rename or move locals to avoid shadowing.
6189 (tty_defined_color, merge_face_heights): Now static.
6190 (free_realized_faces_for_fontset): Remove; not used.
6191 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6192 does not deduce is never used uninitialized.
6193 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6194 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6195
6196 * terminal.c (store_terminal_param): Now static.
6197
6198 * xmenu.c (menu_highlight_callback): Now static.
6199 (set_frame_menubar): Remove unused local.
6200 (xmenu_show): Rename parameter to avoid shadowing.
6201 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6202 since they might point to immutable storage.
6203 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6204 since it's unused otherwise.
6205
6206 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6207 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6208 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6209 avoids a gcc -Wuninitialized diagnostic.
6210 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6211 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6212 does not deduce are never used uninitialized.
6213
6214 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6215
6216 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6217 * window.c (window_loop, size_window):
6218 (run_window_configuration_change_hook, enlarge_window): Likewise.
6219
6220 * window.c (display_buffer): Now static.
6221 (size_window): Mark variables that gcc -Wuninitialized
6222 does not deduce are never used uninitialized.
6223 * window.h (check_all_windows): New decl, to forestall
6224 gcc -Wmissing-prototypes diagnostic.
6225 * dispextern.h (bidi_dump_cached_states): Likewise.
6226
6227 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6228 shadowing.
6229 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6230 Include <limits.h>.
6231 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6232 and to avoid gcc -Wuninitialized warning.
6233 (load_charset_map): Mark variables that gcc -Wuninitialized
6234 does not deduce are never used uninitialized.
6235 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6236
6237 * coding.c (coding_set_source, coding_set_destination):
6238 Use "else { /* comment */ }" rather than "else /* comment */;"
6239 for clarity, and to avoid gcc -Wempty-body warning.
6240 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6241 a block, when the outer 'i' will do.
6242 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6243 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6244 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6245 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6246 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6247 Rename locals to avoid shadowing.
6248 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6249 * coding.c (emacs_mule_char, encode_invocation_designation):
6250 Now static, since they're not used elsewhere.
6251 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6252 (decode_coding_object, encode_coding_object, detect_coding_system):
6253 (decode_coding_emacs_mule): Mark variables that gcc
6254 -Wuninitialized does not deduce are never used uninitialized.
6255 (detect_coding_iso_2022): Initialize a local variable that might
6256 be used uninitialized. Leave a FIXME because it's not clear that
6257 this initialization is needed. (Bug#8211)
6258 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6259 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6260 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6261 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6262 Remove unused macros.
6263
6264 * category.c (hash_get_category_set): Remove unused local var.
6265 (copy_category_table): Now static, since it's not used elsewhere.
6266 * character.c (string_count_byte8): Likewise.
6267
6268 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6269 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6270
6271 * chartab.c (copy_sub_char_table): Now static, since it's not used
6272 elsewhere.
6273 (sub_char_table_ref_and_range, char_table_ref_and_range):
6274 Rename locals to avoid shadowing.
6275 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6276
6277 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6278 (BIDI_BOB): Remove unused macro.
6279
6280 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6281 deduce are never used uninitialized.
6282 * term.c (encode_terminal_code): Likewise.
6283
6284 * term.c (encode_terminal_code): Now static. Remove unused local.
6285
6286 * tparam.h: New file.
6287 * term.c, tparam.h: Include it.
6288 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6289 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6290 Move these decls to tparam.h, and make them agree with what
6291 is actually in tparam.c. The previous trick of using incompatible
6292 decls in different modules does not conform to the C standard.
6293 All callers of tparam changed to use tparam's actual API.
6294 * tparam.c (tparam1, tparam, tgoto):
6295 Use const pointers where appropriate.
6296
6297 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6298 * cm.h (struct cm): Likewise.
6299 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6300 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6301 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6302 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6303 (turn_on_face, init_tty): Likewise.
6304 * termchar.h (struct tty_display_info): Likewise.
6305
6306 * term.c (term_mouse_position): Rename local to avoid shadowing.
6307
6308 * alloc.c (mark_ttys): Move decl from here ...
6309 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6310
6311 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6312
6313 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6314
6315 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6316
6317 * search.c (compile_pattern_1): Remove argument regp, unused since
6318 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6319 (compile_pattern): Don't pass it.
6320
6321 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6322
6323 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6324 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6325 for ! HAVE_GTK3.
6326 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6327
6328 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6329
6330 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6331 gdk_window_get_screen, gdk_window_get_geometry,
6332 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6333 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6334 (xg_get_pixbuf_from_pixmap): New function.
6335 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6336 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6337 Call xg_get_pixbuf_from_pixmap instead of
6338 gdk_pixbuf_get_from_drawable.
6339 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6340 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6341 (xg_check_special_colors): Use GtkStyleContext and its functions
6342 for HAVE_GTK3.
6343 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6344 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6345 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6346 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6347 Call gtk_widget_get_preferred_size.
6348 (xg_frame_resized): gdk_window_get_geometry only takes 5
6349 parameters.
6350 (xg_win_to_widget, xg_event_is_for_menubar):
6351 Call gdk_x11_window_lookup_for_display.
6352 (xg_set_widget_bg): New function.
6353 (delete_cb): New function.
6354 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6355 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6356 (xg_set_background_color): Call xg_set_widget_bg.
6357 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6358 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6359 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6360 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6361 if ! HAVE_GTK3.
6362 (update_frame_tool_bar): Call gtk_widget_hide.
6363 (xg_initialize): Use GDK_KEY_g.
6364
6365 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6366 if ! HAVE_GTK3
6367 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6368
6369 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6370 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6371 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6372
6373 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6374
6375 * w32xfns.c (select_palette): Check success of RealizePalette against
6376 GDI_ERROR, not zero.
6377
6378 See ChangeLog.11 for earlier changes.
6379
6380 ;; Local Variables:
6381 ;; coding: utf-8
6382 ;; End:
6383
6384 Copyright (C) 2011 Free Software Foundation, Inc.
6385
6386 This file is part of GNU Emacs.
6387
6388 GNU Emacs is free software: you can redistribute it and/or modify
6389 it under the terms of the GNU General Public License as published by
6390 the Free Software Foundation, either version 3 of the License, or
6391 (at your option) any later version.
6392
6393 GNU Emacs is distributed in the hope that it will be useful,
6394 but WITHOUT ANY WARRANTY; without even the implied warranty of
6395 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6396 GNU General Public License for more details.
6397
6398 You should have received a copy of the GNU General Public License
6399 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.