1 2012-01-19 Martin Rudalics <rudalics@gmx.at>
3 * window.c (save_window_save, Fcurrent_window_configuration)
4 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
7 2012-01-19 Kenichi Handa <handa@m17n.org>
9 * character.c (char_width): New function.
10 (Fchar_width, c_string_width, lisp_string_width):
11 Use char_width (Bug#9496).
13 2012-01-16 Martin Rudalics <rudalics@gmx.at>
15 * window.c (Vwindow_persistent_parameters): New variable.
16 (Fset_window_configuration, save_window_save): Handle persistent
19 2012-01-14 Eli Zaretskii <eliz@gnu.org>
21 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
22 thrashing the stack of the thread. (Bug#9087)
24 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
26 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
28 2012-01-11 Eli Zaretskii <eliz@gnu.org>
30 * xdisp.c (rows_from_pos_range): Handle the case where the
31 highlight ends on a newline. (Bug#10464)
32 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
33 he end column for display of highlight that ends on a newline
36 2012-01-11 Glenn Morris <rgm@gnu.org>
38 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
39 from load-path also when installation-directory is nil. (Bug#10208)
41 2012-01-10 Glenn Morris <rgm@gnu.org>
43 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
45 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
46 Update template values to be closer to their typical values these days.
48 2012-01-09 Eli Zaretskii <eliz@gnu.org>
50 * xdisp.c (rows_from_pos_range): Accept additional argument
51 DISP_STRING, and accept any glyph in a row whose object is that
52 string as eligible for mouse highlight. Fixes mouse highlight of
53 display strings from overlays. (Bug#10464)
55 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
57 emacs: fix an auto-save permissions race condition (Bug#10400)
58 * fileio.c (auto_saving_dir_umask): New static var.
59 (Fmake_directory_internal): Use it.
60 (do_auto_save_make_dir): Set it, instead of invoking chmod after
61 creating the directory. The old code temporarily assigns
62 too-generous permissions to the directory.
63 (do_auto_save_eh): Clear it.
64 (Fdo_auto_save): Catch all errors, not just file errors, so
65 that the var is always cleared.
67 2012-01-07 Eli Zaretskii <eliz@gnu.org>
69 * search.c (scan_buffer): Pass character positions to
70 know_region_cache, not byte positions. (Bug#6540)
72 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
74 * w32.c (sys_rename): Report EXDEV when rename of a directory
75 fails because the target is on another logical disk. (Bug#10284)
77 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
79 * xterm.c (x_embed_request_focus): New function.
81 * xterm.h: Add prototype.
83 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
85 2012-01-05 Glenn Morris <rgm@gnu.org>
87 * emacs.c (emacs_copyright): Update short copyright year to 2012.
89 2012-01-01 Eli Zaretskii <eliz@gnu.org>
91 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
92 Load gnutls_transport_set_lowat only if GnuTLS version is below
94 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
95 GnuTLS versions below 2.11.1.
97 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
99 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
100 to the doc string advising against its use for altering the way
101 windows are scrolled.
103 2011-12-28 Kenichi Handa <handa@m17n.org>
105 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
106 coding-system ASCII compatible only when it does not produce BOM
107 on encoding (Bug#10383).
109 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
111 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
113 (create_and_show_popup_menu): Always use menu_position_func for
116 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
118 * callint.c (Fcall_interactively): Don't truncate prompt string.
120 2011-12-23 Eli Zaretskii <eliz@gnu.org>
122 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
123 property that ends at ZV, so that the bidi iteration could be
124 resumed from there (after widening). (Bug#10360)
126 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
128 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
130 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
132 * nsterm.m (x_free_frame_resources):
133 Release f->output_data.ns->miniimage.
134 (ns_index_color): Fix indentation. Do not retain
135 color_table->colors[i].
137 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
140 * nsfns.m (x_set_background_color): Assign return value from
141 ns_index_color to face-background instead of NSColor*.
142 (ns_implicitly_set_icon_type): Fix indentation.
143 Change assignment in for loop to comparison.
145 * emacs.c (ns_pool): New variable.
146 (main): Assign ns_pool.
147 (Fkill_emacs): Call ns_release_autorelease_pool.
149 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
150 autorelease fdesc, release fdAttrs and tdict.
151 (ns_get_covering_families): Release charset.
152 (ns_findfonts): Release NSFontDescriptor created with new.
153 (ns_uni_to_glyphs): Fix indentation.
154 (setString): Release attrStr before assigning new value.
156 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
158 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
160 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
161 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
163 2011-12-18 David Reitter <reitter@cmu.edu>
165 * nsterm.m (ns_term_init): Subscribe for notifications
166 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
167 to method trackingNotification in EmacsMenu.
169 * nsmenu.m (trackingMenu): New variable.
170 (trackingNotification): New method (from Aquamacs).
171 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
172 from Aquamacs (Bug#7030).
174 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
176 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
177 (symbol_to_nsstring): Fix indentation.
178 (ns_symbol_to_pb): New function.
179 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
180 (Fns_rotate_cut_buffers_internal): Removed.
181 (Fns_store_selection_internal): Renamed from
182 Fns_store_cut_buffer_internal.
183 (ns_get_foreign_selection, Fx_own_selection_internal)
184 (Fx_disown_selection_internal, Fx_selection_exists_p)
185 (Fns_get_selection_internal, Fns_store_selection_internal):
186 Use ns_symbol_to_pb and check if return value is nil.
187 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
188 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
189 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
190 renamed to Sns_store_selection_internal.
191 (ns_handle_selection_request): Move code to Fx_own_selection_internal
192 and remove this function.
193 (ns_handle_selection_clear): Remove, never used.
194 (Fx_own_selection_internal): Move code from ns_handle_selection_request
197 2011-12-17 Ken Brown <kbrown@cornell.edu>
199 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
200 GID is unknown (Bug#10257).
202 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
204 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
205 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
206 which caused a build failure on GNU/Linux IA-64. This problem was
207 introduced by my 2011-10-07 patch.
209 2011-12-15 Juri Linkov <juri@jurta.org>
211 * image.c (imagemagick_error): New function. (Bug#10112)
212 (imagemagick_load_image): Comment out `MagickSetResolution' call.
213 Use `imagemagick_error' where ImageMagick functions return
215 (Fimagemagick_types): Add `Fnreverse' to return the list in the
218 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
220 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
221 fill background (Bug#8992).
223 2011-12-13 Martin Rudalics <rudalics@gmx.at>
225 * window.c (Vwindow_combination_resize)
226 (Vwindow_combination_limit): Use t instead of non-nil in
228 (Vrecenter_redisplay): Add first sentence of doc-string on
230 (Frecenter): Fix doc-string typo.
232 2011-12-11 Kenichi Handa <handa@m17n.org>
234 * coding.c (Funencodable_char_position): Pay attention to the
235 buffer text relocation (Bug#9389).
237 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
239 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
240 gtk_init (Bug#10100).
242 2011-12-10 Eli Zaretskii <eliz@gnu.org>
244 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
245 IT->string is nil. (Bug#10263)
247 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
249 * nsterm.h (x_free_frame_resources): Declare.
251 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
252 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
254 * nsterm.h (ns_get_defaults_value): Declare.
256 * nsterm.m (ns_default): Call ns_get_defaults_value.
258 2011-12-09 Eli Zaretskii <eliz@gnu.org>
260 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
263 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
265 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
266 that where the value of an _OBJC_* symbol points to is in the .bss
269 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
271 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
272 after the loop to call ccl_driver at least once (Bug#8619).
274 2011-12-08 Kenichi Handa <handa@m17n.org>
276 * ftfont.c (get_adstyle_property): Fix previous change
279 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
281 * w32.c (init_environment): If no_site_lisp, remove site-lisp
282 dirs from the default value of EMACSLOADPATH (bug#10208).
284 2011-12-07 Glenn Morris <rgm@gnu.org>
286 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
287 installation and source directories as well. (Bug#10208)
289 2011-12-06 Chong Yidong <cyd@gnu.org>
291 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
293 2011-12-06 Glenn Morris <rgm@gnu.org>
295 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
296 as an error, not just -1. (Bug#10217)
298 2011-12-05 Chong Yidong <cyd@gnu.org>
300 * keyboard.c (process_special_events): New function.
301 (swallow_events, Finput_pending_p): Use it (Bug#10195).
303 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
305 * coding.c (encode_designation_at_bol): Don't use uninitialized
306 local variable (Bug#9318).
308 2011-12-05 Kenichi Handa <handa@m17n.org>
310 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
311 return Qnil (Bug#8046, Bug#10193).
313 2011-12-05 Kenichi Handa <handa@m17n.org>
315 * coding.c (encode_designation_at_bol): New args charbuf_end and
316 dst. Return the number of produced bytes. Callers changed.
317 (coding_set_source): Return how many bytes coding->source was
319 (coding_set_destination): Return how many bytes
320 coding->destination was relocated.
321 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
322 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
324 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
326 * coding.c (CODING_CHAR_CHARSET_P): New macro.
327 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
330 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
332 The following changes are to fix Bug#9318.
334 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
335 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
336 (encode_coding_iso_2022, encode_coding_sjis)
337 (encode_coding_big5, encode_coding_charset): Use the above macros.
339 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
341 * lisp.h (process_quit_flag): Fix external declaration.
343 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
345 Don't macro-inline non-performance-critical code.
346 * eval.c (process_quit_flag): New function.
347 * lisp.h (QUIT): Use it.
349 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
351 * nsfns.m (get_geometry_from_preferences): New function.
352 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
354 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
356 * emacs.c (Qkill_emacs): Define.
357 (syms_of_emacs): Initialize it.
358 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
359 Qquit_flag to `kill-emacs' instead.
360 (quit_throw_to_read_char): Add parameter `from_signal'.
361 All callers changed. Call Fkill_emacs if requested and safe.
362 * lisp.h (QUIT): Call Fkill_emacs if requested.
364 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
366 * widget.c (update_wm_hints): Return if wmshell is null.
367 (widget_update_wm_size_hints): New function.
369 * widget.h (widget_update_wm_size_hints): Declare.
371 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
372 widget_update_wm_size_hints (Bug#10104).
374 2011-12-03 Eli Zaretskii <eliz@gnu.org>
376 * xdisp.c (handle_invisible_prop): If the invisible text ends just
377 before a newline, prepare the bidi iterator for consuming the
378 newline, and keep the current paragraph direction. (Bug#10183)
379 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
381 2011-12-02 Juri Linkov <juri@jurta.org>
383 * search.c (Fword_search_regexp): New Lisp function created from
384 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
385 (Fword_search_backward, Fword_search_forward)
386 (Fword_search_backward_lax, Fword_search_forward_lax):
387 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
388 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
390 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
392 * fileio.c (Finsert_file_contents): Move after-change-function call
393 to before the "handled:" label, since all "goto handled" appear in
394 cases where the *-change-functions have already been properly called
397 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
399 * keyboard.c (interrupt_signal): Don't call kill-emacs when
400 waiting for input. (Bug#10169)
402 2011-11-30 Eli Zaretskii <eliz@gnu.org>
404 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
405 verifies glyph row's hash code--we have just reallocated the
406 glyphs, so their contents can be complete garbage. (Bug#10164)
408 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
410 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
412 2011-11-30 Eli Zaretskii <eliz@gnu.org>
414 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
415 attributes are tested _before_ calling verify_row_hash, to protect
416 against GCC re-ordering of the tests. (Bug#10164)
418 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
420 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
422 * xterm.c (handle_one_xevent): Only set async_visible and friends
423 if net_wm_state_hidden_seen is non-zero (Bug#10002)
424 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
425 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
427 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
429 Remove GCPRO-related macros that exist only to avoid shadowing locals.
430 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
431 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
432 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
433 All uses changed to use GCPRO1 etc.
434 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
435 Revert to old implementation (i.e., before 2011-03-11).
437 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
439 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
440 of scroll runs so as to avoid assigning disabled bogus rows and
441 unnecessary graphics copy operations.
443 2011-11-27 Eli Zaretskii <eliz@gnu.org>
445 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
446 (snprintf) [_MSC_VER]: Redirect to _snprintf.
447 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
448 (malloc, free, realloc, calloc): Redirect to e_* only when
451 * lisp.h (GCTYPEBITS): Move before first use.
452 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
453 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
454 this macro definition.
456 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
459 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
461 * gtkutil.c (xg_create_frame_widgets):
462 Call gtk_window_set_has_resize_grip (FALSE) if that function is
463 present with Gtk+ 2.0.
465 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
467 * fileio.c (Finsert_file_contents): Undo previous change; see
468 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
470 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
472 Rename locals to avoid shadowing.
473 * fileio.c (Finsert_file_contents):
474 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
475 * process.c (wait_reading_process_output):
476 Rename inner 'proc' to 'p' to avoid shadowing.
477 Indent for consistency with usual Emacs style.
479 2011-11-25 Eli Zaretskii <eliz@gnu.org>
481 * xdisp.c (redisplay_window): If cursor row is not fully visible
482 after recentering, and scroll-conservatively is set to a large
483 number, scroll window by a few more lines to make the cursor fully
484 visible and out of scroll-margin. (Bug#10105)
485 (start_display): Don't move to the next line if the display should
486 start at a newline that is part of a display vector or an overlay
489 2011-11-24 Juri Linkov <juri@jurta.org>
491 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
492 after the `MagickPingImage' call. (Bug#10112)
494 2011-11-23 Chong Yidong <cyd@gnu.org>
496 * window.c (Fcoordinates_in_window_p): Accept only live windows.
498 2011-11-23 Martin Rudalics <rudalics@gmx.at>
500 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
501 making another buffer current. (Bug#10114)
503 2011-11-23 Glenn Morris <rgm@gnu.org>
505 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
507 2011-11-23 Chong Yidong <cyd@gnu.org>
509 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
512 2011-11-22 Eli Zaretskii <eliz@gnu.org>
514 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
515 and header-lines, as they don't have one computed for them.
518 * .gdbinit (prow): Make displayed values more self-explaining.
521 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
523 * process.c (wait_reading_process_output): Fix asynchrounous
524 GnuTLS socket handling on some versions of the GnuTLS library.
525 (wait_reading_process_output): Add comment and URL.
527 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
529 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
531 2011-11-21 Chong Yidong <cyd@gnu.org>
533 * window.c (Fnext_window, Fprevious_window): Doc fix.
535 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
537 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
539 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
541 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
543 2011-11-20 Martin Rudalics <rudalics@gmx.at>
545 * window.c (Fset_window_combination_limit): Rename argument
547 (Vwindow_combination_limit): Remove "status" from doc-string.
549 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
551 * m/ibms390.h: Remove.
552 * m/ibms390x.h: Don't include "ibms390.h".
554 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
556 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
557 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
559 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
561 * casetab.c (Fset_case_table):
562 * charset.c (Fcharset_after): Fix typos.
564 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
566 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
567 Otherwise, valgrind does not work on some platforms.
568 Problem reported by Andreas Schwab in
569 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
570 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
571 is set, removing the need for VIRT_ADDRESS_VARIES.
572 (PURE_P): Use a more-efficient implementation that needs just one
573 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
574 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
575 to 4 (xorl, subq, cmpq, setbe).
576 * alloc.c (pure): Always extern now, since that's the
577 VIRT_ADDR_VARIES behavior.
578 (PURE_POINTER_P): Use a single comparison, not two, for
579 consistency with the new puresize.h.
580 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
581 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
582 Remove VIRT_ADDR_VARIES no longer needed.
584 2011-11-19 Eli Zaretskii <eliz@gnu.org>
586 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
587 (erase_phys_cursor, update_window_cursor, show_mouse_face)
588 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
589 behave as if the cursor position were at the window margin.
591 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
592 and the cursor position is out of bounds, behave as if the cursor
593 position were at the window margin. (Bug#10075)
595 2011-11-18 Chong Yidong <cyd@gnu.org>
597 * window.c (Fwindow_combination_limit): Make first argument
598 non-optional, since it is meaningless for live windows like the
601 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
603 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
605 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
607 * intervals.c: Fix grafting over the whole buffer (bug#10071).
608 (graft_intervals_into_buffer): Simplify.
610 2011-11-18 Eli Zaretskii <eliz@gnu.org>
612 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
613 hash values of the two rows.
614 (copy_row_except_pointers): Preserve the used[] arrays and the
615 hash values of the two rows. (Bug#10035)
616 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
618 * xdisp.c (row_hash): New function, body extracted from
619 compute_line_metrics.
620 (compute_line_metrics): Call row_hash, instead of computing the
623 * dispnew.c (verify_row_hash): Call row_hash for computing the
624 hash code of a row, instead of duplicating code from xdisp.c.
626 * dispextern.h (row_hash): Add prototype.
628 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
630 * frame.c (delete_frame): Don't delete the terminal when the last
631 X frame is closed if emacs is built with GTK toolkit.
633 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
635 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
637 2011-11-17 Martin Rudalics <rudalics@gmx.at>
639 * window.c (Vwindow_splits): Rename to
640 Vwindow_combination_resize. Suggested by Juri Linkov.
641 (Fsplit_window_internal): Use Vwindow_combination_resize instead
644 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
646 * nsfns.m (Fns_font_name):
647 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
649 2011-11-16 Martin Rudalics <rudalics@gmx.at>
651 * window.h (window): Rename slot "nest" to "combination_limit".
652 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
653 (Fset_window_nest): Rename to Fset_window_combination_limit.
654 (Vwindow_nest): Rename to Vwindow_combination_limit.
655 (recombine_windows, make_parent_window, make_window)
656 (Fsplit_window_internal, saved_window)
657 (Fset_window_configuration, save_window_save): Rename all
658 occurrences of window_nest to window_combination_limit.
660 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
662 * image.c (imagemagick_load_image): Fix typo.
664 2011-11-14 Eli Zaretskii <eliz@gnu.org>
666 * xdisp.c (display_line): Move the call to
667 highlight_trailing_whitespace before the call to
668 compute_line_metrics, since the latter needs to see the final
669 faces of all the glyphs to compute ROW's hash value.
670 Fixes assertion violations in row_equal_p. (Bug#10035)
672 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
674 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
675 just return (bug#10044).
677 2011-11-12 Eli Zaretskii <eliz@gnu.org>
679 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
680 with user-defined heap size. Bump the default size of the temacs
681 heap to 27MB, to avoid memory warning when running temacs.
682 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
684 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
685 current_matrix and desired_matrix. (Bug#9990)
686 (verify_row_hash) [XASSERTS]: New function.
687 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
688 that the hash value of glyph rows is correct.
690 2011-11-12 Martin Rudalics <rudalics@gmx.at>
692 * window.h (window): Remove splits slot.
693 * window.c (Fwindow_splits, Fset_window_splits): Remove.
694 (Fdelete_other_windows_internal, make_parent_window)
695 (make_window, Fsplit_window_internal, Fdelete_window_internal)
696 (Fset_window_configuration, save_window_save): Don't deal with
697 split status of windows.
698 (saved_window): Remove splits slot.
699 (Vwindow_splits): Rewrite doc-string.
701 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
703 * xfns.c (unwind_create_frame):
704 * nsfns.m (unwind_create_frame):
705 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
706 Vframe_list (Bug#9999).
708 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
710 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
712 2011-11-11 Kenichi Handa <handa@m17n.org>
714 * callproc.c (Fcall_process): Set the member dst_multibyte of
717 2011-11-11 Johan Bockgård <bojohan@gnu.org>
719 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
720 avoid a crash (bug#9496).
722 2011-11-09 Chong Yidong <cyd@gnu.org>
724 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
725 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
727 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
729 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
731 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
733 Avoid some portability problems by eschewing 'extern inline' functions.
734 The trivial performance wins aren't worth the portability hassles; see
735 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
737 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
738 (window_box_width, window_box_left, window_box_left_offset)
739 (window_box_right, window_box_right_offset): Undo previous change,
740 by removing the "extern"s.
741 * intervals.c (adjust_intervals_for_insertion)
742 (adjust_intervals_for_deletion): Undo previous change,
743 making these static again.
744 (offset_intervals, temp_set_point_both, temp_set_point)
745 (copy_intervals_to_string): No longer inline.
746 * xdisp.c (window_text_bottom_y, window_box_width)
747 (window_box_height, window_box_left_offset)
748 (window_box_right_offset, window_box_left, window_box_right)
749 (window_box): No longer inline.
751 2011-11-08 Chong Yidong <cyd@gnu.org>
753 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
754 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
755 Signal an error if not a live window.
756 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
757 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
759 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
761 * lisp.h (syms_of_abbrev): Remove declaration.
762 Reported by CHENG Gao <chenggao@royau.me>.
764 2011-11-07 Eli Zaretskii <eliz@gnu.org>
766 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
767 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
768 of temacs in GUI mode.
770 2011-11-07 Martin Rudalics <rudalics@gmx.at>
772 * window.h: Declare delete_all_child_windows instead of
773 delete_all_subwindows.
774 * window.c (Fwindow_nest, Fset_window_nest)
775 (Fset_window_new_total, Fset_window_new_normal)
776 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
777 (delete_all_subwindows): Rename to delete_all_child_windows.
778 (Fdelete_other_windows_internal, Fset_window_configuration):
779 Call delete_all_child_windows instead of delete_all_subwindows.
780 * frame.c (delete_frame): Call delete_all_child_windows instead
781 of delete_all_subwindows.
783 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
785 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
786 This is also needed for porting to any host where GC_MARK_STACK is
787 not GC_MAKE_GCPROS_NOOPS.
788 (which_symbols): Use it.
790 2011-11-07 Kenichi Handa <handa@m17n.org>
792 * coding.c (coding_set_destination): Check coding->src_pos only
793 when coding->src_object is a buffer (bug#9910).
795 * process.c (send_process): Set the member src_multibyte of coding
796 to 0 (bug#9911) when sending a unibyte text.
798 * callproc.c (Fcall_process): Set the member src_multibyte of
799 process_coding to 0 (bug#9912).
801 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
803 * xmenu.c (cleanup_widget_value_tree): New function.
804 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
805 calling free_menubar_widget_value_tree directly (Bug#9830).
807 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
809 Fix some portability problems with 'inline'.
810 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
811 (window_box_width, window_box_left, window_box_left_offset)
812 (window_box_right, window_box_right_offset): Declare extern.
813 Otherwise, these inline functions do not conform to C99 and
814 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
815 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
816 * intervals.c (adjust_intervals_for_insertion)
817 (adjust_intervals_for_deletion): Now extern, because otherwise the
818 extern inline functions 'offset_intervals' couldn't refer to it.
819 (static_offset_intervals): Remove.
820 (offset_intervals): Rewrite using the old contents of
821 static_offset_intervals. The old version didn't conform to C99
822 because an extern inline function contained a reference to an
823 identifier with static linkage.
825 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
827 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
830 2011-11-06 Eli Zaretskii <eliz@gnu.org>
832 * xdisp.c (init_iterator, reseat_to_string): Don't set the
833 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
834 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
835 return Qleft_to_right.
837 2011-11-06 Chong Yidong <cyd@gnu.org>
839 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
840 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
841 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
842 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
843 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
844 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
845 (Fwindow_vscroll): Doc fix.
846 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
847 argument, since it makes no sense to pass a live window and for
848 consistency with window-child.
850 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
852 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
855 2011-11-05 Jason Rumney <jasonr@gnu.org>
857 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
858 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
860 (add_font_entity_to_list): Fix logic errors in mixed boolean and
861 bitwise arithmetic preventing use of unicode-sip and non-truetype
864 2011-11-05 Eli Zaretskii <eliz@gnu.org>
866 * s/ms-w32.h (fstat, stat, utime): Move redirections to
869 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
870 initialization code to keep similarity to xfns.c after changes
873 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
875 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
876 (unwind_create_frame): New function (Bug#9943).
877 (Fx_create_frame): Restructure code to be more similar to the one in
878 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
879 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
880 Move terminal->reference_count++ just before making the frame official
883 * nsterm.m (x_free_frame_resources): New function.
884 (x_destroy_window): Move code to x_free_frame_resources.
886 * xfns.c (unwind_create_frame): Fix comment.
887 (Fx_create_frame, x_create_tip_frame):
888 Move terminal->reference_count++ just before making the frame
889 official. Move initialization of image_cache_refcount and
890 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
892 2011-11-05 Eli Zaretskii <eliz@gnu.org>
894 Support MSVC build with newer versions of Visual Studio.
895 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
896 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
899 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
900 which are not supported by MSVC.
901 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
902 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
904 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
906 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
908 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
910 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
912 Support MSVC build with newer versions of Visual Studio.
913 * w32.c: Don't include w32api.h for MSVC.
914 (init_environment) [_MSC_VER]: Call sys_access, not _access.
916 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
917 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
918 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
919 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
921 (alloca) [_MSC_VER]: Define to _alloca.
923 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
925 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
927 2011-11-04 Eli Zaretskii <eliz@gnu.org>
929 * xdisp.c (note_mouse_highlight): If either of
930 previous/next-single-property-change returns nil, treat that as
931 the beginning or the end of the buffer. (Bug#9955)
933 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
935 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
936 label is not null (Bug#9951).
937 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
940 2011-11-04 Eli Zaretskii <eliz@gnu.org>
942 * window.c (Fwindow_body_size): Mention in the doc string that the
943 return value is in frame's canonical units. (Bug#9949)
945 2011-11-03 Eli Zaretskii <eliz@gnu.org>
947 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
949 * w32fns.c (unwind_create_frame): If needed, free the glyph
950 matrices of the partially constructed frame. (Bug#9943)
951 * xfns.c (unwind_create_frame): Likewise.
953 2011-11-01 Eli Zaretskii <eliz@gnu.org>
955 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
956 Don't stop backward scan on the continuation glyph, even though
957 its CHARPOS is positive.
958 (mouse_face_from_buffer_pos, note_mouse_highlight):
959 Rename cover_string to disp_string.
961 2011-11-01 Martin Rudalics <rudalics@gmx.at>
963 * window.c (temp_output_buffer_show): Don't use
964 Vtemp_buffer_show_specifiers.
965 (Vtemp_buffer_show_specifiers): Remove unused variable.
967 2011-10-30 Eli Zaretskii <eliz@gnu.org>
969 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
970 past the beginning of the current glyph matrix.
972 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
974 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
975 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
976 HAVE_GTK3 (Bug#9869).
978 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
979 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
981 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
983 * xterm.c: Declare x_handle_net_wm_state to return int.
984 (handle_one_xevent): Check if we are iconified but don't have
985 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
986 (get_current_wm_state): Return non-zero if not hidden,
987 check for _NET_WM_STATE_HIDDEN (Bug#9893).
988 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
989 (x_handle_net_wm_state): Return what get_current_wm_state returns.
990 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
992 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
994 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
995 so that this new function doesn't get optimized away by a
996 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
998 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1000 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1002 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1004 Fix the `xbytecode' command.
1005 * .gdbinit (xprintbytestr): New command.
1006 (xwhichsymbols): Rename from `which'; all callers changed.
1007 (xbytecode): Print the byte-code string as well.
1009 2011-10-29 Kim Storm <storm@cua.dk>
1011 * alloc.c (which_symbols): New function.
1013 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1015 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1018 2011-10-29 Glenn Morris <rgm@gnu.org>
1020 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1021 Not clear what it was for, and it causes various bugs. (Bug#9839)
1023 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1025 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1026 possible random value that matches one of those tested as
1027 condition to clear the mouse face.
1029 2011-10-28 Chong Yidong <cyd@gnu.org>
1031 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1033 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1035 * window.c (make_window): Initialize phys_cursor_on_p.
1037 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1039 * lisp.h (struct Lisp_Symbol): Update comments.
1041 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1043 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1045 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1047 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1048 <oslsachem@gmail.com> for helping to debug this.
1050 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1051 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1052 (g_b_init_get_glyph_outline_w): New static variables.
1053 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1054 (GetGlyphOutlineW_Proc): New typedefs.
1055 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1056 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1058 (w32font_open_internal, compute_metrics):
1059 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1060 instead of calling the "wide" APIs directly.
1062 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1064 * w32.h (syms_of_w32font): Add prototype.
1066 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1068 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1069 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1070 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1071 (Fmove_to_window_line): Doc fix.
1073 2011-10-27 Chong Yidong <cyd@gnu.org>
1075 * process.c (make_process): Set gnutls_state to NULL.
1077 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1078 non-NULL, regardless of GNUTLS_INITSTAGE.
1079 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1080 an error. Set process slots as soon as we allocate them.
1082 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1084 2011-10-27 Chong Yidong <cyd@gnu.org>
1086 * gnutls.c (emacs_gnutls_deinit): New function.
1087 Deallocate credentials structures as well as calling gnutls_deinit.
1088 (Fgnutls_deinit, Fgnutls_boot): Use it.
1090 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1091 (deactivate_process): Call emacs_gnutls_deinit.
1093 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1095 * image.c (x_create_x_image_and_pixmap):
1096 * w32.c (sys_rename, w32_delayed_load):
1097 * w32font.c (fill_in_logfont):
1098 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1100 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1102 * w32fns.c (w32_default_color_map): New function,
1103 extracted from Fw32_default_color_map.
1104 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1106 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1108 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1110 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1112 * keyboard.c (test_undefined): New function (bug#9751).
1113 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1115 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1117 * sysdep.c (init_sys_modes): Fix the check for the controlling
1118 terminal (Bug#6649).
1120 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1122 * dispextern.h (struct bidi_it): New member next_en_type.
1124 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1125 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1126 current character, check also for next_en_type being WEAK_EN.
1127 (bidi_resolve_weak): Don't enter the expensive loop if the current
1128 position is before next_en_pos. Record the bidi type of the first
1129 non-ET, non-BN character we find, in addition to its position.
1130 (bidi_level_of_next_char): Invalidate next_en_type when
1131 next_en_pos is over-stepped.
1133 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1135 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1136 * editfns.c: Rewrite current-time-zone so that it invokes
1137 the equivalent of (format-time-string "%Z") to get the time zone name.
1138 This fixes a bug when the time zone name contains characters that
1139 need converting from the system time locale to Emacs internal format.
1140 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1141 that patch fixed format-time-string to do the conversion, but
1142 I forgot to fix current-time-zone.
1143 (format_time_string): New function, containing most of
1144 what Fformat_time_string used to contain.
1145 (Fformat_time_string): Rewrite in terms of format_time_string.
1146 This doesn't change this function's behavior.
1147 (current-time-zone): Rewrite to use format_time_string.
1148 This fixes the bug reported by Michael Schierl in
1149 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1150 Jason Rumney's 2007-06-07 change worked around this bug, but
1152 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1154 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1156 * xdisp.c (start_display): If the character at POS is displayed
1157 via a display vector, reset IT->current.dpvec_index to zero.
1158 (try_window_reusing_current_matrix): If a line ends in a display
1159 vector or the next line starts in a display vector, continue
1160 redrawing the window even though the character position of
1161 start_row was reached.
1164 2011-10-18 Chong Yidong <cyd@gnu.org>
1166 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1167 with nobreak-char-display too.
1169 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1171 Fix part 3 of bug#9771.
1172 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1173 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1174 non-neutral characters if the current character is a paragraph
1175 separator (a.k.a. Newline). This avoids running the same
1176 expensive loop twice, once when we consume the preceding newline
1177 and the other time when the line actually needs to be displayed.
1178 Avoid the loop when we see neutrals on the base embedding level
1179 following a character whose directionality is the same as the
1180 paragraph's. This avoids running the expensive loop when a line
1181 ends in a long sequence of neutrals, like control characters.
1182 Add assertion against STRONG_AL type. Slightly rearrange code
1183 that determines the type of a neutral given the first non-neutral
1185 (bidi_level_of_next_char): Set next_en_pos to zero when
1186 invalidating its info.
1188 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1190 * xdisp.c (push_display_prop): Determine whether to record string
1191 or buffer position by IT->string, not by IT->method. Allow
1192 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1193 (move_it_vertically_backward): Don't look for character position
1194 immediately after the newline when in a continuation line.
1197 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1199 * window.c (coordinates_in_window): Rewrite and delabelize
1200 vertical border check. (Bug#5357) (Bug#9618)
1202 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1204 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1205 errors in XSetWindowBorder (bug#9310).
1207 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1209 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1210 avoid crash when xmalloc overrun checking is enabled.
1212 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1214 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1215 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1216 cursor motion with <left> and <right> arrow keys.
1218 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1219 some callers set that themselves.
1221 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1223 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1224 display string and the previous row comes from the same string and
1225 is empty. (Bug#9739) (Bug#9738)
1227 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1229 * doc.c (get_doc_string): Encode file name (bug#9735).
1231 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1233 * bidi.c (bidi_level_of_next_char):
1234 * xdisp.c (get_visually_first_element): Remove old incorrect
1235 comments regarding the Unicode Line Separator character.
1237 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1239 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1241 * alloc.c (Fgc_status): Do not access beyond zombies array
1242 boundary if nzombies > MAX_ZOMBIES.
1243 * alloc.c (dump_zombies): Add missing format specifier.
1245 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1247 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1248 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1250 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1251 Some packages use them to denote characters with modifiers.
1253 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1255 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1256 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1257 matching a pp-number. Rename parameter var to var1.
1259 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1261 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1263 2011-10-08 Glenn Morris <rgm@gnu.org>
1265 * callint.c (Fcall_interactively): Give a more explicit error for the
1266 'c' case with a non-character input. (Bug#8479)
1268 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1270 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1272 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1273 lines that are hscrolled on the left.
1275 * dispnew.c (buffer_posn_from_coords): Account for a possible
1276 presence of header-line. (Bug#4426)
1278 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1280 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1281 Don't advertise functionality which we discourage or doesn't work.
1283 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1285 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1286 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1287 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1288 this makes Emacs dump core during garbage collection on rare
1289 occasions. sizeof is obviously inferior to offsetof here, so
1290 stick with offsetof.
1291 (GC_POINTER_ALIGNMENT): New macro.
1292 (mark_memory): Omit 3rd (offset) arg; caller changed.
1293 Don't assume EMACS_INT alignment is the same as pointer alignment.
1295 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1297 * keyboard.c (read_key_sequence_remapped): New var.
1298 (read_key_sequence): Compute remapping in the right buffer.
1299 (command_loop_1): Use read_key_sequence's remapping directly.
1301 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1303 * dired.c (file_name_completion): Don't expand file name.
1304 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1305 before checking file name handler.
1307 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1308 they've been requested explicitly (bug#9591).
1310 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1312 * keymap.c (Fsingle_key_description): Use make_specified_string
1313 instead of build_string to build string from push_key_description.
1316 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1318 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1319 This fixes a Y2038 bug on 64-bit hosts.
1320 * buffer.c (reset_buffer):
1321 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1322 (Fclear_buffer_auto_save_failure):
1323 Use 0, not -1, to represent an unset failure time, since time_t
1324 might not be signed.
1326 Remove dependency on glibc malloc internals.
1327 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1328 Move back here from lisp.h, but with their new implementations.
1329 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1330 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1331 * charset.c (charset_table_init): New static var.
1332 (syms_of_charset): Use it instead of xmalloc. This removes a
1333 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1334 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1335 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1336 Move back to alloc.c.
1337 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1338 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1340 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1342 * nsterm.m (windowDidResize): Call x_set_window_size only when
1343 ns_in_resize is true. Otherwise set pixelwidth/height and
1344 call change_frame_size (Bug#9628).
1346 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1348 Port --enable-checking=all to Fedora 14 x86-64.
1349 * charset.c (syms_of_charset): Also account for glibc malloc's
1350 internal overhead when calculating the initial malloc maximum.
1352 Port --enable-checking=all to Fedora 14 x86.
1353 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1355 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1356 (overrun_check_realloc, overrun_check_free):
1357 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1358 That way, xmalloc returns a properly-aligned pointer even if
1359 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1360 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1361 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1362 into account when calculating the initial malloc maximum.
1363 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1364 Move here from alloc.c, so that charset.c can use it too.
1365 Properly align; the old code wasn't right for common 32-bit hosts
1366 when configured with --enable-checking=all.
1367 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1368 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1370 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1372 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1375 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1377 * xdisp.c (compute_display_string_end): If there's no display
1378 string at CHARPOS, return -1.
1380 * bidi.c (bidi_fetch_char): When compute_display_string_end
1381 returns a negative value, treat the character as a normal
1382 character not covered by a display string. (Bug#9624)
1384 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1386 * lread.c (Fread_from_string): Fix typo in docstring.
1388 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1390 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1391 newline, reseat the iterator instead of bidi-iterating there one
1392 character at a time. (Bug#9610)
1393 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1394 TO_CHARPOS if the bidi iterator is at base embedding level.
1396 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1398 * lread.c (readevalloop): Use correct code for NBSP.
1399 (read1): Likewise. (Bug#9608)
1401 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1403 * dbusbind.c (Fdbus_register_signal): When service is not
1404 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1406 2011-09-25 Glenn Morris <rgm@gnu.org>
1408 * buffer.c (truncate-lines): Doc fix.
1410 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1412 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1413 (Fset_window_next_buffers): Doc fix.
1415 2011-09-24 Glenn Morris <rgm@gnu.org>
1417 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1419 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1421 Fix minor problems found by static checking.
1422 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1423 * indent.c (Fvertical_motion): Fix == vs = typo.
1425 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1427 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1428 Default value is now t. Doc fix.
1430 * indent.c (Fvertical_motion): Compute and apply the overshoot
1431 logic when moving up, not only when moving down. Fix the
1432 confusing name and values of the it_overshoot_expected variable;
1433 logic changes accordingly. (Bug#9254) (Bug#9549)
1435 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1436 CHARPOS is covered by a display string which includes newlines.
1437 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1438 is covered by a display string with embedded newlines.
1440 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1442 * dbusbind.c (Fdbus_register_signal): Add match rule to
1443 Vdbus_registered_objects_table. (Bug#9581)
1444 (Fdbus_register_method, Vdbus_registered_objects_table):
1447 2011-09-24 Jim Meyering <meyering@redhat.com>
1449 do not ignore write error for any output size
1450 The previous change was incomplete.
1451 While it makes emacs --batch detect the vast majority of stdout
1452 write failures, errors were still ignored whenever the output size is
1453 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1454 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1455 && echo FAIL: ignored write error
1456 FAIL: ignored write error
1457 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1458 && echo FAIL: ignored write error
1459 FAIL: ignored write error
1460 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1462 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1464 * emacs.c (Fkill_emacs): In noninteractive mode exit
1465 non-successfully if a write error occurred on stdout. (Bug#9574)
1467 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1469 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1472 * dispextern.h (struct it): Update the comment documenting what
1475 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1477 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1478 a display string, extend search for cursor position to end of row.
1479 (find_row_edges): If the row ends in a newline from a display
1480 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1481 Handle the case of a display string with multiple newlines.
1482 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1483 non-empty line. Fixes confusing cursor motion with arrow keys at
1484 the beginning of a line that starts with whitespace.
1486 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1488 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1491 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1493 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1496 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1498 * xdisp.c (display_line): Record maximum and minimum buffer
1499 positions even if no glyphs were produced (e.g., by a zero-width
1500 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1501 buffer positions that will be removed from the glyph row because
1503 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1504 column is beyond frame width: don't subtract 1 "pixel" when
1505 computing width of the stretch.
1506 (reseat_at_next_visible_line_start): Undo the change made on
1507 2011-09-17 that saved paragraph information and restored it after
1508 the call to `reseat'. (Bug#9545)
1510 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1512 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1513 and turn window cursor on if cleared (Bug#9415).
1515 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1517 * search.c (boyer_moore): Take unibyte characters from pattern
1518 literally. (Bug#9458)
1520 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1522 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1524 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1526 Fix minor problem found by static checking.
1527 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1528 initialized, to pacify gcc -Wuninitialized.
1530 * fileio.c: Report proper errno when syscall falls.
1531 (Finsert_file_contents): Save and restore errno,
1532 so that report_file_error outputs the correct diagnostic.
1533 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1535 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1537 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1539 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1541 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1542 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1544 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1546 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1547 about the current paragraph and restore it after the call to reseat.
1549 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1550 (bidi_find_paragraph_start): Search back for paragraph beginning
1551 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1552 (bidi_move_to_visually_next): Only trigger paragraph-related
1553 computations when the last character is a newline or at EOB, not
1554 just any NEUTRAL_B. (Bug#9470)
1556 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1557 truncated lines if point is covered by a display string. (Bug#9524)
1559 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1561 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1562 (cons_to_x_long): New function.
1563 (lisp_data_to_selection_data): Use it. Correct the test for
1564 short-versus-long data; it was negated. Break out of vector
1565 loop, for efficiency, when a long datum is discovered.
1567 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1569 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1571 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1573 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1574 GCC PR/17406) by declaring this function with external scope.
1576 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1578 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1579 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1581 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1583 * editfns.c (Fformat): Correctly handle text properties on "%%".
1585 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1587 * xterm.c (x_draw_composite_glyph_string_foreground):
1588 * w32term.c (x_draw_composite_glyph_string_foreground):
1589 * term.c (encode_terminal_code):
1590 * composite.c (composition_update_it, get_composition_id):
1591 * xdisp.c (get_next_display_element)
1592 (fill_composite_glyph_string): Add comments about special meaning
1593 of TAB characters in a composition.
1595 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1597 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1598 This occurs when processing a multibyte format.
1599 Problem reported by Wolfgang Jenker.
1601 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1603 * xdisp.c (try_cursor_movement): Only check for exact match if
1604 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1606 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1608 Remove unused external symbols.
1609 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1610 * xdisp.c (calc_pixel_width_or_height): Now static.
1611 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1612 * indent.c (check_display_width):
1613 * w32term.c: Fix comment to match code.
1614 * xterm.c, xterm.h (x_catching_errors): Remove.
1616 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1618 * xselect.c: Use signed conversions more consistently (Bug#9498).
1619 (selection_data_to_lisp_data): Assume incoming selection data are
1620 signed integers, not unsigned. This is to be consistent with
1621 outgoing selection data, which was modified to use signed integers
1622 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1623 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1624 expects long, not unsigned long.
1626 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1628 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1629 computation of loop end. Reported by Johan Bockgård
1632 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1634 * frame.c (Fother_visible_frames_p): Function deleted.
1636 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1638 * indent.c (compute_motion): Process display vector front to back
1639 rather than the other way around. (Bug#2496)
1641 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1643 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1645 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1647 * minibuf.c (Fread_from_minibuffer): Doc fix.
1649 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1651 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1652 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1654 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1656 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1657 value for non-existent files.
1659 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1661 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1662 set its "size" to -1. This will set the modtime_size field of
1663 the corresponding buffer to -1, which is what
1664 verify-visited-file-modtime expects for files that do not exist.
1667 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1669 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1671 * lisp.h: ... from here. push_key_description is no longer
1672 defined in keyboard.c, so its declaration should not be in
1673 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1674 logically belongs with push_key_description.
1676 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1678 * buffer.h: Include <sys/types.h> instead of <time.h>.
1679 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1680 Problem reported by Herbert J. Skuhra.
1682 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1684 * xml.c (parse_region): Make the parsing work for
1685 non-comment-starting XML files again (bug#9144).
1687 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1689 * image.c (gif_load): Fix calculation of bottom and right corner.
1692 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1694 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1695 redisplay in small windows.
1697 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1699 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1701 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1703 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1704 Operate on live windows only.
1706 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1708 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1710 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1712 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1713 only under bidi iteration.
1715 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1717 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1719 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1721 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1722 Without this fix, the command to link temacs failed due to an
1723 undefined symbol __builtin_isnan. This is because
1724 /usr/include/iso/math_c99.h #defines isnan(x) to
1725 __builtin_isnan(x), but the bundled gcc, which identifies itself
1726 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1728 * floatfns.c (isnan): #undef, and then #define to a clone of
1730 (Fisnan): Always define, since it's always available now.
1731 (syms_of_floatfns): Always define isnan at the Lisp level.
1733 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1735 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1737 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1739 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1740 The previous code assumed that file offsets (off_t values) fit in
1741 EMACS_INT variables, which is not true on typical 32-bit hosts.
1742 The code messed up by falsely reporting buffer overflow in cases
1743 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1744 when "big" contains more than 2**29 bytes, even though this
1745 inserts just one byte and does not overflow the buffer.
1746 (Finsert_file_contents): Store file offsets as off_t
1747 values, not as EMACS_INT values. Check for overflow when
1748 converting between EMACS_INT and off_t. When checking for
1749 buffer overflow or for overlap, take the offsets into account.
1750 Don't use EMACS_INT for small values where int suffices.
1751 When checking for overlap, fix a typo: ZV was used where
1752 ZV_BYTE was intended.
1753 (Fwrite_region): Don't assume off_t fits into 'long'.
1754 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1756 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1758 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1760 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1762 sprintf-related integer and memory overflow issues (Bug#9412).
1764 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1765 (esprintf, exprintf, evxprintf): New functions.
1766 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1767 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1768 (modify_event_symbol): Do not assume that the length of
1769 name_alist_or_stem is safe to alloca and fits in int.
1770 (Fexecute_extended_command): Likewise for function name and binding.
1771 (Frecursion_depth): Wrap around reliably on integer overflow.
1772 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1773 since some callers pass EMACS_INT values.
1774 (Fsingle_key_description): Don't crash if symbol name contains more
1775 than MAX_ALLOCA bytes.
1776 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1777 (get_minibuffer): Arg is now EMACS_INT, not int.
1778 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1779 (esprintf, exprintf, evxprintf): New decls.
1780 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1782 * dbusbind.c (signature_cat): New function.
1783 (xd_signature, Fdbus_register_signal):
1784 Do not overrun buffer; instead, report string overflow.
1786 * dispnew.c (add_window_display_history): Don't overrun buffer.
1787 Truncate instead; this is OK since it's just a log.
1789 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1790 even if the time zone offset is outlandishly large.
1791 Don't mishandle offset == INT_MIN.
1793 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1794 when creating daemon; the previous buffer-overflow check was incorrect.
1796 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1797 which has the guts of the old verror function.
1799 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1800 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1802 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1803 (font_unparse_xlfd): Don't blindly alloca long strings.
1804 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1805 fits in int, when using sprintf. Use single snprintf to count
1806 length of string rather than counting it via multiple sprintfs;
1807 that's simpler and more reliable.
1808 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1809 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1810 sprintf, in case result does not fit in int.
1812 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1813 (fontset_from_font): Print it.
1815 * frame.c (tty_frame_count): Now printmax_t, not int.
1816 (make_terminal_frame, set_term_frame_name): Print it.
1817 (x_report_frame_params): In X, window IDs are unsigned long,
1818 not signed long, so print them as unsigned.
1819 (validate_x_resource_name): Check for implausibly long names,
1820 and don't assume name length fits in 'int'.
1821 (x_get_resource_string): Don't blindly alloca invocation name;
1822 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1825 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1826 (xg_check_special_colors, xg_set_geometry):
1827 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1829 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1830 Use esprintf, not sprintf, in case result does not fit in int.
1832 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1833 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1834 it as a large positive number.
1835 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1836 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1838 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1839 in case result does not fit in int.
1841 * print.c (float_to_string): Detect width overflow more reliably.
1842 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1843 buffer overrun. Don't assume list length fits in 'int'. Treat
1844 print length of 0 as 0, not as infinity; to be consistent with other
1845 uses of print length in this function. Don't overflow print length
1846 index. Don't assume hash table size fits in 'long', or that
1847 vectorlike size fits in 'unsigned long'.
1849 * process.c (make_process): Use printmax_t, not int, to format
1850 process-name gensyms.
1852 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1854 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1855 to avoid potential buffer overrun.
1857 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1858 if X resource line is longer than 512 bytes.
1860 * xfns.c (x_window): Make sprintf buffer a bit bigger
1861 to avoid potential buffer overrun.
1863 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1865 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1867 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1869 Integer overflow fixes for scrolling, etc.
1870 Without these, Emacs silently mishandles large integers sometimes.
1871 For example, "C-u 4294967297 M-x recenter" was treated as if
1872 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1874 * xdisp.c (try_window_id): Check Emacs fixnum range before
1875 converting to 'int'.
1877 * window.c (window_scroll_line_based, Frecenter):
1878 Check that an Emacs fixnum is in range before assigning it to 'int'.
1879 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1880 values converted from Emacs fixnums.
1881 (Frecenter): Don't wrap around a line count if it is out of 'int'
1882 range; instead, treat it as an extreme value.
1883 (Fset_window_configuration, compare_window_configurations):
1884 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1886 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1887 that can exceed INT_MAX. Check that EMACS_INT value is in range
1888 before assigning it to the (possibly-narrower) index.
1889 (match_limit): Don't assume that a fixnum can fit in 'int'.
1891 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1894 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1895 (Fvertical_motion): Don't wrap around LINES values that don't fit
1896 in 'int'. Instead, treat them as extreme values. This is good
1897 enough for windows, which can't have more than INT_MAX lines anyway.
1899 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1901 * Require libxml/parser.h to avoid compilation warning.
1903 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1905 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1906 since this reportedly can destroy thread storage.
1908 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1910 * syntax.c (find_defun_start): Update all cache variables if
1911 exiting early (Bug#9401).
1913 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1915 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1917 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1918 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1919 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1921 * term.c (tty_append_glyph): New function.
1922 (produce_stretch_glyph): Static function and its prototype deleted.
1924 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1927 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1929 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1930 when checking :margin (Bug#9390).
1931 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1932 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1933 so that the name doesn't mislead. All uses changed.
1935 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1937 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1940 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1942 * xdisp.c (move_it_to): Don't bail out early when reaching
1943 position beyond to_charpos, if we are scanning backwards.
1944 (move_it_vertically_backward): When DY == 0, make sure we get to
1945 the first character in the line after the newline.
1947 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1949 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1950 (ccl_driver): Do not generate an out-of-range pointer.
1951 (Fccl_execute_on_string): Remove unnecessary check for
1952 integer overflow, noted by Stefan Monnier in
1953 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1954 Remove a FIXME that didn't need fixing.
1955 Simplify the newly-introduced buffer reallocation code.
1957 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1959 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1961 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1963 Integer and memory overflow issues (Bug#9196).
1965 * doc.c (get_doc_string): Rework so that
1966 get_doc_string_buffer_size is the actual buffer size, rather than
1967 being 1 less than the actual buffer size; this makes xpalloc more
1970 * image.c (x_allocate_bitmap_record, cache_image):
1971 * xselect.c (Fx_register_dnd_atom):
1972 Simplify previous changes by using xpalloc.
1974 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1975 since either will do and ptrdiff_t is convenient with xpalloc.
1977 * charset.c (charset_table_size)
1978 (struct charset_sort_data.priority): Now ptrdiff_t.
1979 (charset_compare): Don't overflow if priorities differ greatly.
1980 (Fsort_charsets): Don't assume list length fits in int.
1981 Check for size-calculation overflow when allocating sort data.
1982 (syms_of_charset): Allocate an initial charset table that is
1983 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1985 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1987 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1988 The actual value is always <= INT_MAX, and leaving it unsigned made
1989 overflow checking harder.
1991 * dispextern.h (struct glyph_matrix.rows_allocated)
1992 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1993 with xpalloc. The values are still always <= INT_MAX.
1995 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1997 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1998 (SAFE_NALLOCA): New macro.
2000 * region-cache.c (struct boundary.pos, find_cache_boundary)
2001 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2002 (set_cache_region, invalidate_region_cache)
2003 (revalidate_region_cache, know_region_cache, region_cache_forward)
2004 (region_cache_backward, pp_cache):
2005 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2006 so that ptrdiff_t * can be passed to xpalloc.
2007 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2008 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2009 (pp_cache): Don't assume cache_len fits in int.
2010 * region-cache.h: Adjust extern decls to match.
2012 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2013 EMACS_INT, since either will do, for xpalloc.
2015 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2016 (xnmalloc, xnrealloc, xpalloc): New functions.
2018 * bidi.c (bidi_shelve_header_size): New constant.
2019 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2020 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2022 * bidi.c (bidi_cache_shrink):
2023 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2025 Don't update size of array until after memory allocation succeeds,
2026 because xmalloc/xrealloc may not return.
2027 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2028 now that we have proper integer overflow checking.
2029 (record_overlay_string, overlay_strings): Catch overflows when
2030 calculating size of overlay_str_buf.
2032 * callproc.c (Fcall_process): Check for size overflow when
2033 calculating size of args2.
2034 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2035 Normally we prefer signed values, but sticking with ptrdiff_t would
2036 require adding more-complicated checks.
2038 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2039 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2040 Redo buffer-overflow calculations to avoid integer overflow.
2041 Add a FIXME comment where memory seems to be over-allocated.
2043 * character.c (Fstring): Check for size-calculation overflow.
2045 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2046 unnecessary integer overflow. Check for size overflow.
2047 (encode_coding_object): Don't update size until xmalloc succeeds.
2049 * composite.c (get_composition_id): Check for overflow in glyph
2050 length calculations.
2052 Integer and memory overflow fixes for display code.
2053 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2054 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2055 (scrolling_window): Check for overflow in size calculations.
2056 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2057 Don't assume glyph table len fits in int.
2058 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2059 (row_table_size): Now ptrdiff_t, not int.
2060 (scrolling_window): Avoid overflow in size calculations.
2061 Don't update size until allocation succeeds.
2062 * fns.c (concat): Check for overflow in size calculations.
2063 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2064 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2065 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2067 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2068 (get_doc_string): Check for size calculation overflow.
2069 Don't update size until allocation succeeds.
2070 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2071 EMACS_INT, where ptrdiff_t will do.
2072 (Fsubstitute_command_keys): Check for string overflow.
2074 * editfns.c (set_time_zone_rule): Don't assume environment length
2076 (message_length): Now ptrdiff_t, not int.
2077 (Fmessage_box): Don't update size until allocation succeeds.
2078 Don't assume message length fits in int.
2079 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2081 * emacs.c (main): Do not reallocate argv, since there is a null at
2082 the end that can be overwritten, and this way there's no need to
2083 worry about size-calculation overflow.
2084 (sort_args): Check for size-calculation overflow.
2086 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2088 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2090 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2091 (x_set_scroll_bar_width, x_figure_window_size):
2092 Check for integer overflow.
2093 (x_set_alpha): Do not assume XINT fits in int.
2095 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2096 This is for the members text_lines, text_cols, total_lines, total_cols,
2097 where the system imposes an 'int' limit.
2099 * fringe.c (Fdefine_fringe_bitmap):
2100 Don't update size until alloc works.
2102 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2103 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2105 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2106 Check for size-calculation overflow.
2107 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2108 do, as we prefer signed integers.
2109 (id_to_widget.max_size, id_to_widget.used)
2110 (xg_store_widget_in_map, xg_remove_widget_from_map)
2111 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2112 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2113 Use and return ptrdiff_t, not int.
2114 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2115 * gtkutil.h: Change prototypes to match the above.
2117 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2118 are duplicate now that they've been promoted to lisp.h.
2119 (x_allocate_bitmap_record, x_alloc_image_color)
2120 (make_image_cache, cache_image, xpm_load):
2121 Don't update size until alloc is done.
2122 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2124 Check for size calculation overflow.
2125 (ct_colors_allocated_max): New constant.
2126 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2129 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2130 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2131 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2132 Use ptrdiff_t, not int, to count maps.
2133 (read_char_minibuf_menu_prompt): Check for overflow in size
2134 calculations. Don't update size until allocation succeeds.
2135 Redo calculations to avoid overflow.
2136 * keyboard.h: Change prototypes to match the above.
2138 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2140 (current_minor_maps): Check for size calculation overflow.
2141 * keymap.h: Change prototypes to match the above.
2143 * lread.c (read1, init_obarray): Don't update size until alloc done.
2145 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2146 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2148 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2149 Now ptrdiff_t, not int.
2150 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2151 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2153 * process.c (Fnetwork_interface_list): Check for overflow
2154 in size calculation.
2156 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2158 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2159 overflow. Don't bother calling xmalloc when xrealloc will do.
2161 * search.c (Freplace_match): Check for size calculation overflow.
2162 (Fset_match_data): Don't assume list lengths fit in 'int'.
2164 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2165 for command line length. Do not attempt to address one before the
2166 beginning of an array, as that's not portable.
2168 * term.c (max_frame_lines): Remove; unused.
2169 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2171 (encode_terminal_code, calculate_costs): Check for size
2172 calculation overflow.
2173 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2174 table lengths and related sizes. Don't update size until alloc
2175 done. Redo calculations to avoid overflow.
2176 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2178 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2179 subtracting pointers.
2180 (gobble_line): Check for overflow more carefully. Don't update size
2183 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2184 Don't update size until alloc done.
2185 Redo size calculations to avoid overflow.
2186 Check for size calculation overflow.
2187 (main) [DEBUG]: Fix typo in invoking tparam1.
2189 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2190 Use ptrdiff_t, not int, for sizes.
2191 (store_mode_line_noprop_char): Don't update size until alloc done.
2193 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2194 Use ptrdiff_t, not int, for sizes.
2195 (Finternal_make_lisp_face, cache_face):
2196 Check for size calculation overflow.
2197 (cache_face): Treat size calculation overflows as if they were
2198 memory exhaustion (the usual treatment), rather than aborting.
2200 * xfns.c (x_encode_text, x_set_name_internal)
2201 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2202 sizes, since they can exceed INT_MAX in size. Check for size
2203 calculation overflow.
2205 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2206 (xg_select): Check for size calculation overflow.
2207 Don't update size until alloc done.
2209 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2210 as sprintf is limited to int lengths.
2212 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2213 (X_LONG_MIN): New macros.
2214 Use them to make the following changes clearer.
2215 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2216 This change doesn't affect the value now, but it may help remind
2217 future maintainers not to raise the value too much later.
2218 (SELECTION_QUANTUM): Remove, replacing with ...
2219 (selection_quantum): ... new function, which avoids overflow.
2221 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2222 assumption that selection length fits in 'int'.
2223 (x_reply_selection_request, x_handle_selection_request)
2224 (x_get_window_property, receive_incremental_selection)
2225 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2226 (lisp_data_to_selection_data, clean_local_selection_data):
2227 Use ptrdiff_t, not int, to record length of selection.
2228 (x_reply_selection_request, x_get_window_property)
2229 (receive_incremental_selection, x_property_data_to_lisp):
2230 Redo calculations to avoid overflow.
2231 (x_reply_selection_request): When sending hint, ceiling it at
2232 X_LONG_MAX rather than relying on wraparound overflow to send
2234 (x_get_window_property, receive_incremental_selection)
2235 (lisp_data_to_selection_data, x_property_data_to_lisp):
2236 Check for size-calculation overflow.
2237 (x_get_window_property, receive_incremental_selection)
2238 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2239 Don't store size until memory allocation succeeds.
2240 (x_get_window_property): Plug memory leak on memory exhaustion.
2241 Don't double-block input; malloc is safe here. Don't assume 2**34
2242 - 4 fits in unsigned long. Add an xassert to check
2243 XGetWindowProperty overflow. Be more careful about overflow
2244 calculations, and distinguish size from memory overflow better.
2245 (receive_incremental_selection): When tracing, don't assume
2246 unsigned int is less than INT_MAX.
2247 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2248 harmful) conversions of unsigned short to int.
2249 (lisp_data_to_selection_data): Don't assume that integers
2250 in the range -65535 through -1 fit in an X unsigned short.
2251 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2252 result parameters unless successful. Rely on cons_to_unsigned
2253 to report problems with elements; the old code wasn't right anyway.
2254 (x_check_property_data): Check for int overflow; we cannot use
2255 a wider type due to X limits.
2256 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2258 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2260 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2261 (x_term_init): Check for size calculation overflow.
2262 (x_color_cells): Don't store size until memory allocation succeeds.
2263 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2264 Don't assume alloca size is less than MAX_ALLOCA.
2265 (x_term_init): Don't assume length fits in int (sprintf is limited
2268 Use ptrdiff_t for composition IDs.
2269 * character.c (lisp_string_width):
2270 * composite.c (composition_table_size, n_compositions)
2271 (get_composition_id, composition_gstring_from_id):
2272 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2273 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2274 * window.c (Frecenter):
2275 Use ptrdiff_t, not int, for composition IDs.
2276 * composite.c (get_composition_id): Check for integer overflow.
2277 * composite.h: Adjust prototypes to match the above changes.
2279 Use ptrdiff_t for hash table indexes.
2280 * category.c (hash_get_category_set):
2281 * ccl.c (ccl_driver):
2282 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2283 * coding.c (coding_system_charset_list, detect_coding_system):
2284 * coding.h (struct coding_system.id):
2285 * composite.c (get_composition_id, gstring_lookup_cache):
2286 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2287 * image.c (xpm_get_color_table_h):
2288 * lisp.h (hash_lookup, hash_put):
2289 * minibuf.c (Ftest_completion):
2290 Use ptrdiff_t for hash table indexes, not int (which is too
2291 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2292 32-bit --with-wide-int hosts).
2294 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2295 Add a FIXME comment about memory leaks.
2296 (syms_of_charset): Don't assume xmalloc returns.
2298 Don't assume that stated character widths fit in int.
2299 * character.c (Fchar_width, c_string_width, lisp_string_width):
2300 * character.h (CHAR_WIDTH):
2301 * indent.c (MULTIBYTE_BYTES_WIDTH):
2302 Use sanitize_char_width to avoid undefined and/or bad behavior
2303 with outlandish widths.
2304 * character.h (sanitize_tab_width): Rename from sanitize_width,
2305 now that we have two such functions. All uses changed.
2306 (sanitize_char_width): New inline function.
2308 Don't assume that tab-width fits in int.
2309 * character.h (sanitize_width): New inline function.
2310 (SANE_TAB_WIDTH): New macro.
2311 (ASCII_CHAR_WIDTH): Use it.
2312 * indent.c (sane_tab_width): Remove. All uses replaced by
2313 SANE_TAB_WIDTH (current_buffer).
2314 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2316 * fileio.c: Integer overflow issues with file modes.
2317 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2319 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2320 Remove unreachable code.
2321 (read_hex, load_charset_map_from_file): Check for integer overflow.
2323 * xterm.c: don't go over XClientMessageEvent limit
2324 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2325 (x_send_scroll_bar_event): Likewise. Check that the size does not
2326 exceed limits imposed by XClientMessageEvent, as well as the usual
2327 ptrdiff_t and size_t limits.
2329 * keyboard.c: Overflow, signedness and related fixes.
2330 (make_lispy_movement): Use same integer type in forward decl
2331 that is used in the definition.
2332 (read_key_sequence, keyremap_step):
2333 Change bufsize argument back to int, undoing my 2011-03-30 change.
2334 We prefer signed types, and int is wide enough here.
2335 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2336 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2337 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2338 length, not size_t. Use ptrdiff_t for index, not int.
2339 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2340 possibility of integer overflow.
2342 Overflow, signedness and related fixes for images.
2344 * dispextern.h (struct it.stack[0].u.image.image_id)
2345 (struct_it.image_id, struct image.id, struct image_cache.size)
2346 (struct image_cache.used, struct image_cache.ref_count):
2347 * gtkutil.c (update_frame_tool_bar):
2348 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2349 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2350 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2351 * nsmenu.m (update_frame_tool_bar):
2352 * xdisp.c (calc_pixel_width_or_height):
2353 * xfns.c (image_cache_refcount):
2354 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2355 on typical 64-bit hosts.
2357 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2358 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2359 Omit unnecessary casts to int.
2360 (parse_image_spec): Check that integers fall into 'int' range
2361 when the callers expect that.
2362 (image_ascent): Redo ascent calculation to avoid int overflow.
2363 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2364 (lookup_image): Remove unnecessary tests.
2365 (xbm_image_p): Locals are now of int, not EMACS_INT,
2366 since parse_image_check makes sure they fit into int.
2367 (png_load, gif_load, svg_load_image):
2368 Prefer int to unsigned where either will do.
2369 (tiff_handler): New function, combining the cores of the
2370 old tiff_error_handler and tiff_warning_handler.
2371 This function is rewritten to use vsnprintf and thereby avoid
2372 stack buffer overflows. It uses only the features of vsnprintf
2373 that are common to both POSIX and native Microsoft.
2374 (tiff_error_handler, tiff_warning_handler): Use it.
2375 (tiff_load, gif_load, imagemagick_load_image):
2376 Don't assume :index value fits in 'int'.
2377 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2378 (imagemagick_load_image): Check that crop parameters fit into
2379 the integer types that MagickCropImage accepts. Don't assume
2380 Vimagemagick_render_type has a nonnegative value. Don't assume
2381 size_t fits in 'long'.
2382 (gs_load): Use printmax_t to print the widest integers possible.
2383 Check for integer overflow when computing image height and width.
2385 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2387 * xdisp.c (redisplay_window): Don't force window start if point
2388 will be invisible in the resulting window. (Bug#9324)
2390 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2392 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2393 the display spec is of the form `(space ...)'.
2394 (handle_display_spec): Return the value returned by
2395 handle_single_display_spec, not just 1 or zero.
2396 (handle_single_display_spec): If the display spec is of the form
2397 `(space ...)', and specifies display in the text area, return 2
2399 (try_cursor_movement): Check for the need to scroll more
2400 accurately, and prefer exact match for point under bidi.
2401 Don't advance `row' beyond the last row of the window.
2403 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2404 into disp_prop; all users changed.
2406 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2407 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2408 for the text covered by the display property.
2410 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2412 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2413 Change return value to nil.
2414 (Frecord_buffer): Delete unused function.
2416 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2418 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2419 buffers, return left-to-right.
2420 (set_cursor_from_row): Consider candidate row a win if its glyph
2421 represents a newline and point is on that newline. Fixes cursor
2422 positioning on the newline at EOL of R2L text within L2R
2423 paragraph, and vice versa.
2424 (try_cursor_movement): Check continued rows, in addition to
2425 continuation rows. Fixes unwarranted scroll when point enters a
2426 continued line of R2L text within an L2R paragraph, or vice versa.
2427 (cursor_row_p): Consider the case of point being equal to
2428 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2429 from the end of a short line to the beginning of a continued line
2430 of R2L text within L2R paragraph.
2431 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2432 composed characters.
2434 * bidi.c (bidi_check_type): Use xassert.
2435 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2438 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2440 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2443 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2445 * nsfont.m (ns_otf_to_script): Fix typo.
2447 2011-08-22 Kenichi Handa <handa@m17n.org>
2449 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2450 extra slot even if the purpose is char-code-property-table.
2452 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2454 * xdisp.c (redisplay_window): When computing centering_position,
2455 account for the height of the header line. (Bug#8874)
2457 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2458 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2459 candidate is selected by the mouse, and that candidate has a
2460 composed character under the mouse.
2462 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2463 coordinates reported by pos-visible-in-window-p for a composed
2464 character in column zero.
2466 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2468 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2470 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2472 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2473 consider it a hit if to_charpos is anywhere in the range of the
2474 composed buffer positions.
2476 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2478 * image.c (gif_load): Don't assume that each subimage has the same
2479 dimensions as the base image. Handle disposal method that is
2480 "undefined" by the gif spec (Bug#9335).
2482 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2484 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2485 (Fcondition_case): Document `debug' symbol in error handler.
2487 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2489 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2490 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2491 from an Org mode buffer to a Speedbar frame.
2493 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2494 a composition, take its buffer position from IT->cmp_it.charpos.
2495 Fixes cursor positioning at the beginning of a line that begins
2496 with a composed character.
2498 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2500 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2501 character bidirectional type, use STRONG_L instead. Fixes crashes
2502 in a buffer produced by `describe-categories'.
2504 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2505 members before the level stack, so they would be saved and
2506 restored when copying iterator state. Fixes incorrect reordering
2507 around TABs covered by display properties.
2509 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2511 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2513 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2515 * eval.c (internal_condition_case, internal_condition_case_1)
2516 (internal_condition_case_2, internal_condition_case_n):
2517 Remove unnecessary aborts (Bug#9081).
2519 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2521 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2522 has no `load' handler, try opening the file locally. (Bug#9311)
2524 2011-08-16 Ken Brown <kbrown@cornell.edu>
2526 * gmalloc.c: Expand comment.
2528 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2530 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2531 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2533 2011-08-16 Ken Brown <kbrown@cornell.edu>
2535 Fix memory allocation problems in Cygwin build (Bug#9273).
2537 * unexcw.c ( __malloc_initialized): Declare external variable.
2538 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2540 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2542 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2544 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2546 [CYGWIN] (special_realloc): New function.
2547 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2548 requests to realloc storage in the static heap.
2550 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2552 * bidi.c (bidi_initialize): Remove unused local.
2554 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2557 * biditype.h: Remove file.
2558 * makefile.w32-in ($(BLD)/bidi.$(O)):
2559 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2561 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2563 * chartab.c: Improve commentary for the uniprop_table API.
2565 * bidi.c (bidi_paragraph_init): Support zero value of
2566 bidi_ignore_explicit_marks_for_paragraph_level.
2567 (bidi_initialize): Use uniprop_table instead of including
2568 biditype.h and bidimirror.h.
2570 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2571 coordinates of the iterator when restoring from ppos_it.
2574 2011-08-14 Kenichi Handa <handa@m17n.org>
2576 * process.c (create_process): Call setup_process_coding_systems
2577 after the pid of the process is set to -1 (Bug#8162).
2579 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2581 * xdisp.c (move_it_in_display_line_to): Don't invoke
2582 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2583 ppos_it. Fixes vertical cursor motion when line beginning is
2584 covered by an image. (Bug#9296)
2586 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2588 * nsterm.h (ns_run_ascript): Declare.
2589 (NSAPP_DATA2_RUNASSCRIPT): Define.
2591 * nsfns.m (as_script, as_result, as_status): New static variables.
2592 (ns_run_ascript): New function.
2593 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2594 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2595 the event loop. Get status from as_status (Bug#7276).
2597 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2598 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2599 the event loop (Bug#7276).
2601 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2603 * gnutls.c (QCgnutls_bootprop_priority)
2604 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2605 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2606 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2607 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2608 (QCgnutls_bootprop_verify_hostname_error)
2609 (QCgnutls_bootprop_callbacks_verify): Rename from
2610 Qgnutls_bootprop_..., all uses changed.
2612 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2615 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2617 * xfaces.c (Qframe_set_background_mode): Now static.
2618 * dispextern.h (Qframe_set_background_mode): Remove decl.
2620 * process.c (Fnetwork_interface_info): Declare local only if needed.
2622 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2624 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2625 (Fnetwork_interface_list): Allocate in increments of bytes instead
2626 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2627 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2629 (struct ifflag_def): notrailers is smart on OSX.
2630 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2631 Get hardware address with getifaddrs if available.
2633 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2635 * xdisp.c (iterate_out_of_display_property): xassert that
2636 IT->position is set to within IT->object's boundaries. Break from
2637 the loop as soon as EOB is reached; avoids infloops in redisplay
2638 when IT->position is set up wrongly due to some bug.
2639 Set IT->current to match the bidi iterator unconditionally.
2640 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2641 entry. Force push_it to save on the stack the current
2642 buffer/string position, to be restored by pop_it. Fix flags in
2643 the iterator structure wrt the object coming from a display
2644 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2645 properties. (Bug#9284)
2647 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2649 * fontset.c (fontset_get_font_group): Add proper type checks.
2652 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2654 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2655 and LC_VERSION_MIN_MACOSX.
2656 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2657 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2659 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2661 * xdisp.c (forward_to_next_line_start): Allow to use the
2662 no-display-properties-and-no-overlays under bidi display.
2663 Set disp_pos in the bidi iterator to avoid searches for display
2664 properties and overlays.
2666 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2668 * editfns.c (Fset_time_zone_rule): Document relationship with the
2671 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2672 the font entity extracted from the cache (Bug#8109).
2674 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2676 * composite.c (autocmp_chars): Don't reset point. That is done by
2677 restore_point_unwind (Bug#5984).
2679 2011-08-07 Juri Linkov <juri@jurta.org>
2681 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2682 to show the arg `TIME' instead of `TIMEVAL'.
2684 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2686 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2687 display property strides EOL and includes a newline, as in
2688 longlines-mode. (Bug#9254)
2689 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2690 word-wrap under bidirectional display. (Bug#9224)
2692 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2693 is non-zero, even if the data buffer is NULL. Fixes a crash in
2694 vertical-motion with longlines-mode. (Bug#9254)
2696 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2698 * bidi.c <bidi_cache_total_alloc>: Now static.
2699 (bidi_initialize): Initialize bidi_cache_total_alloc.
2701 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2704 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2705 amount allocated this far in `bidi_cache_total_alloc'.
2706 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2707 non-zero, only free the data buffer without restoring the cache
2708 contents. All callers changed.
2710 * dispextern.h (bidi_unshelve_cache): Update prototype.
2712 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2713 (move_it_in_display_line, move_it_to)
2714 (move_it_vertically_backward, move_it_by_lines): Replace the call
2715 to xfree to an equivalent call to bidi_unshelve_cache.
2716 (move_it_in_display_line_to): Fix logic of returning
2717 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2719 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2721 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2722 came from a string character with a `cursor' property. (Bug#9229)
2724 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2726 * Makefile.in (LIB_PTHREAD): New variable.
2727 (LIBES): Add LIB_PTHREAD (Bug#9216).
2729 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2730 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2732 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2734 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2736 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2738 * xterm.c (x_find_topmost_parent): New function.
2739 (x_set_frame_alpha): Find topmost parent window with
2740 x_find_topmost_parent and set the property there also (bug#9181).
2741 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2743 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2745 * callproc.c (Fcall_process): Avoid vfork clobbering
2746 the local vars buffer, coding_systems, current_dir.
2748 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2750 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2752 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2754 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2755 so that it is not optimized away.
2757 * xdisp.c (compute_display_string_pos): Remove unused local.
2759 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2761 Fix slow cursor motion and scrolling in large buffers with
2762 selective display, like Org Mode buffers. (Bug#9218)
2764 * dispextern.h (struct bidi_it): New member disp_prop_p.
2766 * xdisp.c: Remove one-slot cache of display string positions.
2767 (compute_display_string_pos): Accept an additional argument
2768 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2769 for a display string or property. If found, set DISP_PROP_P
2772 * bidi.c (bidi_fetch_char): Accept an additional argument
2773 DISP_PROP_P, and pass it to compute_display_string_pos.
2774 Only handle text covered by a display string if DISP_PROP_P is returned
2775 non-zero. All callers of bidi_fetch_char changed.
2777 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2779 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2781 2010-12-03 Don March <don@ohspite.net>
2783 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2784 last character M-[char] is translated to ESC [char] (bug#7541).
2786 2011-08-02 Kenichi Handa <handa@m17n.org>
2788 * lisp.h (uniprop_table): Extern it.
2790 * chartab.c (uniprop_table): Make it non-static.
2792 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2794 * xdisp.c (forward_to_next_line_start): Accept additional argument
2795 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2797 (reseat_at_next_visible_line_start): Use the bidi iterator state
2798 returned by forward_to_next_line_start to restore the state of
2799 it->bidi_it after backing up to previous newline. (Bug#9212)
2801 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2803 * regex.c (re_comp): Protoize.
2804 (re_exec): Fix return type.
2805 (regexec): Fix type of `ret'. (Bug#9203)
2807 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2809 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2810 This is needed if max-image-size is a floating-point number.
2812 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2814 * print.c (print_object): Print empty symbol as ##.
2816 * lread.c (read1): Read ## as empty symbol.
2818 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2820 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2821 setting frame foreground color (Bug#9175).
2822 (x_set_background_color): Likewise.
2824 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2825 contents (Bug#9176).
2826 (EmacsTooltip -init): Remove bezels and add shadows to
2829 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2830 or scroll bar (Bug#8470).
2832 * nsfont.m (nsfont_open): Remove assignment to voffset and
2833 unnecessary vars hshink, expand, hd, full_height, min_height.
2834 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2836 * nsterm.h (nsfont_info): Remove voffset field.
2838 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2840 Implement strike-through and overline on NextStep (Bug#8863).
2842 * nsfont.m (nsfont_open): Use underline position provided by font,
2843 instead of hard-coded value of 2.
2844 (nsfont_draw): Call ns_draw_text_decoration instead.
2846 * nsterm.h: Add declaration for ns_draw_text_decoration.
2848 * nsterm.m (ns_draw_text_decoration): New function for drawing
2849 underline, overline, and strike-through.
2850 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2851 ns_draw_text_decoration. Change treatment of cursor drawing to
2852 accommodate underlining, etc.
2854 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2856 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2859 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2861 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2862 Without this fix, if a signal arrives just after memory fills up,
2863 'malloc' might be invoked reentrantly.
2865 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2866 In other words, assume that every image size is allowed, on non-X
2867 hosts. This assumption is probably wrong, but it lets Emacs compile.
2869 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2871 * regex.c (re_iswctype): Convert return values to boolean.
2873 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2875 * xdisp.c (compute_display_string_pos): Don't use cached display
2876 string position if the buffer had its restriction changed.
2879 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2881 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2883 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2885 Integer signedness and overflow and related fixes. (Bug#9079)
2887 * bidi.c: Integer size and overflow fixes.
2888 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2889 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2890 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2891 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2892 (bidi_find_other_level_edge):
2893 Use ptrdiff_t instead of EMACS_INT where either will do.
2894 This works better on 32-bit hosts configured --with-wide-int.
2895 (bidi_cache_ensure_space): Check for size-calculation overflow.
2896 Use % rather than repeated addition, for better worst-case speed.
2897 Don't set bidi_cache_size until after xrealloc returns, because it
2899 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2900 (bidi_cache_ensure_space): Also check that the bidi cache size
2901 does not exceed that of the largest Lisp string or buffer. See Eli
2902 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2904 * alloc.c (__malloc_size_t): Remove.
2905 All uses replaced by size_t. See Andreas Schwab's note
2906 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2908 * image.c: Improve checking for integer overflow.
2909 (check_image_size): Assume that f is nonnull, since
2910 it is always nonnull in practice. This is one less thing to
2911 worry about when checking for integer overflow later.
2912 (x_check_image_size): New function, which checks for integer
2913 overflow issues inside X.
2914 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2915 This removes the need for a memory_full check.
2916 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2917 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2918 (xbm_read_bitmap_data): Change locals back to 'int', since
2919 their values must fit in 'int'.
2920 (xpm_load_image, png_load, tiff_load):
2921 Invoke x_create_x_image_and_pixmap earlier,
2922 to avoid much needless work if the image is too large.
2923 (tiff_load): Treat overly large images as if
2924 x_create_x_image_and_pixmap failed, not as malloc failures.
2925 (gs_load): Use x_check_image_size.
2927 * gtkutil.c: Omit integer casts.
2928 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2929 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2931 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2933 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2934 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2935 would wrongly return t on a 64-bit host.
2937 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2938 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2939 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2940 and therefore cause GCC to emit a bogus diagnostic in some cases.
2942 * image.c: Integer signedness and overflow and related fixes.
2943 This is not an exhaustive set of fixes, but it's time to
2944 record what I've got.
2945 (lookup_pixel_color, check_image_size): Remove redundant decls.
2946 (check_image_size): Don't assume that arbitrary EMACS_INT values
2947 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2948 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2949 (tiff_load, imagemagick_load_image):
2950 Check for overflow in size calculations.
2951 (x_create_x_image_and_pixmap): Remove unnecessary test for
2952 xmalloc returning NULL; that can't happen.
2953 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2954 (xpm_color_bucket): Use better integer hashing function.
2955 (xpm_cache_color): Don't possibly over-allocate memory.
2956 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2957 (gif_memory_source):
2958 Use ptrdiff_t, not int or size_t, to record sizes.
2959 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2960 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2961 either works, as we prefer signed integers.
2962 (tiff_read_from_memory, tiff_write_from_memory):
2963 Return tsize_t, not size_t, since that's what the TIFF API wants.
2964 (tiff_read_from_memory): Don't fail simply because the read would
2965 go past EOF; instead, return a short read.
2966 (tiff_load): Omit no-longer-needed casts.
2967 (Fimagemagick_types): Don't assume size fits into 'int'.
2969 Improve hashing quality when configured --with-wide-int.
2970 * fns.c (hash_string): New function, taken from sxhash_string.
2971 Do not discard information about ASCII character case; this
2972 discarding is no longer needed.
2973 (sxhash-string): Use it. Change sig to match it. Caller changed.
2974 * lisp.h: Declare it.
2975 * lread.c (hash_string): Remove, since we now use fns.c's version.
2976 The fns.c version returns a wider integer if --with-wide-int is
2977 specified, so this should help the quality of the hashing a bit.
2979 * emacs.c: Integer overflow minor fix.
2980 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2981 Define only if GNU_LINUX.
2982 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2984 * dispnew.c: Integer signedness and overflow fixes.
2985 Remove unnecessary forward decls, that were a maintenance hassle.
2986 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2988 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2989 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2990 (prepare_desired_row, line_draw_cost):
2991 Use int, not unsigned, where either works.
2992 (save_current_matrix, restore_current_matrix):
2993 Use ptrdiff_t, not size_t, where either works.
2994 (init_display): Check for overflow more accurately, and without
2995 relying on undefined behavior.
2997 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2998 Remove, replacing with the new symbols in lisp.h. All uses changed.
2999 * fileio.c (make_temp_name):
3000 * filelock.c (lock_file_1, lock_file):
3001 * xdisp.c (message_dolog):
3002 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3003 Use pMd etc. instead.
3004 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3005 replacing the pWIDE etc. symbols removed from editfns.c.
3007 * keyboard.h (num_input_events): Now uintmax_t.
3008 This is (very slightly) less likely to mess up due to wraparound.
3011 * buffer.c: Integer signedness fixes.
3012 (alloc_buffer_text, enlarge_buffer_text):
3013 Use ptrdiff_t rather than size_t when either will do, as we prefer
3016 * alloc.c: Integer signedness and overflow fixes.
3017 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3018 (__malloc_size_t): Default to size_t, not to int.
3019 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3020 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3021 Prefer ptrdiff_t to size_t when either would do, as we prefer
3023 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3024 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3025 Now const. Initialize with values that are in range even if char
3027 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3028 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3029 These functions do the right thing with sizes > 2**32.
3030 (check_depth): Now ptrdiff_t, not int.
3031 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3032 Adjust to new way of storing sizes. Check for size overflow bugs
3034 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3035 slightly wrong anyway, as it missed one instance of
3036 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3037 (refill_memory_reserve): Omit needless cast to size_t.
3038 (mark_object_loop_halt): Mark as externally visible.
3040 * xselect.c: Integer signedness and overflow fixes.
3041 (Fx_register_dnd_atom, x_handle_dnd_message):
3042 Use ptrdiff_t, not size_t, since we prefer signed.
3043 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3044 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3045 x_dnd_atoms_size and x_dnd_atoms_length.
3047 * doprnt.c: Prefer signed to unsigned when either works.
3049 * doprnt.c (doprnt):
3051 * xdisp.c (vmessage):
3052 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3053 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3054 prefer signed arithmetic to avoid comparison confusion.
3055 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3056 but is a bit tricky.
3058 Assume freestanding C89 headers, string.h, stdlib.h.
3059 * data.c, doprnt.c, floatfns.c, print.c:
3060 Include float.h unconditionally.
3061 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3062 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3063 * regex.c: Likewise for stddef.h, string.h.
3064 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3065 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3066 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3067 (STDC_HEADERS): Remove obsolete defines.
3068 * sysdep.c: Include limits.h unconditionally.
3070 Assume support for memcmp, memcpy, memmove, memset.
3071 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3072 * regex.c (memcmp, memcpy):
3073 Remove; we assume C89 now.
3075 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3076 (__malloc_safe_bcopy): Remove; no longer needed.
3078 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3079 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3080 well either way, and we prefer signed to unsigned.
3082 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3084 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3085 closes the connection while we're reading (bug#9182).
3087 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3089 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3090 are specified (Bug#9168).
3092 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3094 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3095 Found by GCC static checking and --with-wide-int on a 32-bit host.
3097 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3099 * xdisp.c (compute_display_string_pos): Fix logic of caching
3100 previous display string position. Initialize cached_prev_pos to
3101 -1. Fixes slow-down at the beginning of a buffer.
3103 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3105 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3106 for attrs[LFACE_FONTSET_INDEX].
3108 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3110 * xml.c (parse_region): Remove unused local
3111 that was recently introduced.
3113 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3115 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3116 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3118 * xdisp.c (move_it_in_display_line_to): Record the best matching
3119 position for TO_CHARPOS while scanning the line, and restore it on
3120 exit if none of the characters scanned was an exact match.
3121 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3122 when exact match is impossible due to invisible text, and the
3123 lines are truncated.
3125 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3127 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3130 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3132 Fix a significant slow-down of cursor motion with C-n, C-p,
3133 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3134 auto-repeat under bidi redisplay in fontified buffers.
3135 * xdisp.c (compute_stop_pos_backwards): New function.
3136 (next_element_from_buffer): Call compute_stop_pos_backwards to
3137 find a suitable prev_stop when we find ourselves before
3139 (reseat): Don't look for prev_stop, as that could mean a very long
3141 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3142 <cached_disp_overlay_modiff>: Cache for last found display string
3144 (compute_display_string_pos): Return the cached position if asked
3145 about the same buffer in the same area of character positions, and
3146 the buffer wasn't changed since the time the display string
3147 position was cached.
3149 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3151 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3152 is an integer, which is important for empty lines. (Bug#9149)
3154 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3156 * frame.c (Fmodify_frame_parameters): In tty case, update the
3157 default face if necessary (Bug#4238).
3159 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3161 * editfns.c (Fstring_to_char): No need to explain what a character
3162 is in the docstring (Bug#6576).
3164 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3166 * xml.c (parse_region): Make sure we always return a tree.
3168 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3170 * xml.c (parse_region): If a document contains only comments,
3173 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3175 * xml.c (make_dom): Return comments, too.
3177 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3180 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3181 and the surrounding thread.
3182 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3183 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3184 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3186 * s/openbsd.h (BROKEN_SIGIO): Define.
3187 * unexelf.c (unexec) [__OpenBSD__]:
3188 Don't update the .mdebug section of the Alpha COFF symbol table.
3190 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3192 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3195 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3197 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3198 This fixes some race conditions on the permissions of any newly
3201 * alloc.c (valid_pointer_p): Use pipe, not open.
3202 This fixes some permissions issues when debugging.
3204 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3205 If fchown fails to set both uid and gid, try to set just gid,
3206 as that is sometimes allowed. Adjust the file's mode to eliminate
3207 setuid or setgid bits that are inappropriate if fchown fails.
3209 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3211 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3212 to compare Lisp_Objects.
3213 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3214 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3215 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3217 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3219 * lread.c (read_integer): Unread even EOF character.
3220 (read1): Likewise. Properly record start position of symbol.
3222 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3223 symbol character follows.
3225 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3227 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3228 This works around a problem with the previous change to Fcopy_file.
3229 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3230 and without this change, GCC might complain about discarding
3231 fchown's return value.
3233 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3235 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3237 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3239 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3241 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3243 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3244 it's used from the C level.
3246 * process.c: Use the same condition for POLL_FOR_INPUT in both
3247 keyboard.c and process.c (bug#1858).
3249 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3251 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3252 (Fgnutls_boot): Use it.
3254 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3256 * doc.c (Fsubstitute_command_keys): Revert last change.
3258 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3260 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3261 quotes the next character, and doesn't affect other longer
3262 sequences (bug#8935).
3264 * lread.c (syms_of_lread): Clarify that is isn't only
3265 `eval-buffer' and `eval-defun' that's affected by
3266 `lexical-binding' (bug#8460).
3268 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3270 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3271 bidi redisplay when a line includes both an image and is truncated.
3273 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3275 Fix minor problems found by static checking.
3276 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3277 (elsz): Now a signed constant, not a size_t var. We prefer signed
3278 types to unsigned, to avoid integer comparison confusion. Without
3279 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3280 "cannot optimize loop, the loop counter may overflow", a symptom
3282 * indent.c (Fvertical_motion): Mark locals as initialized.
3283 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3285 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3287 * search.c (Fre_search_backward): Mention `case-fold-search' in
3288 all the re_search_* functions (bug#8138).
3290 * keyboard.c (Fopen_dribble_file): Document when the file is
3293 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3295 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3298 Support bidi reordering of display and overlay strings.
3299 * xdisp.c (compute_display_string_pos)
3300 (compute_display_string_end): Accept additional argument STRING.
3301 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3302 (reseat_to_string): Initialize bidi_it->string.s and
3303 bidi_it->string.schars.
3304 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3305 NULL (avoids a crash in bidi_paragraph_init).
3306 Initialize itb.string.lstring.
3307 (init_iterator): Call bidi_init_it only of a valid
3308 buffer position was specified. Initialize paragraph_embedding to
3310 (reseat_to_string): Initialize the bidi iterator.
3311 (display_string): If we need to ignore text properties of
3312 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3313 original value of -1 will not work with bidi.)
3314 (compute_display_string_pos): First arg is now struct
3315 `text_pos *'; all callers changed. Support display properties on
3317 (compute_display_string_end): Support display properties on Lisp
3319 (init_iterator, reseat_1, reseat_to_string): Initialize the
3320 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3321 when iterating on a string not from display properties).
3322 (compute_display_string_pos, compute_display_string_end):
3323 Fix calculation of the object to scan. Fixes an error when using
3325 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3326 base_level_stop; instead, set base_level_stop to BEGV.
3327 Fixes crashes in vertical-motion.
3328 (next_element_from_buffer): Improve commentary for when
3329 the iterator is before prev_stop.
3330 (init_iterator): Initialize bidi_p from the default value of
3331 bidi-display-reordering, not from buffer-local value. Use the
3332 buffer-local value only if initializing for buffer iteration.
3333 (handle_invisible_prop): Support invisible properties on strings
3334 that are being bidi-reordered.
3335 (set_iterator_to_next): Support bidi reordering of C strings and
3337 (next_element_from_string): Support bidi reordering of Lisp
3339 (handle_stop_backwards): Support Lisp strings as well.
3340 (display_string): Support display of R2L glyph rows.
3341 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3342 (init_iterator): Don't initialize it->bidi_p for strings
3344 (reseat_to_string): Initialize it->bidi_p for strings here.
3345 (next_element_from_string, next_element_from_c_string)
3346 (next_element_from_buffer): Add xassert's for correspondence
3347 between IT's object being iterated and it->bidi_it.string
3349 (face_before_or_after_it_pos): Support bidi iteration.
3350 (next_element_from_c_string): Handle the case of the first string
3351 character that is not the first one in the visual order.
3352 (get_visually_first_element): New function, refactored from common
3353 parts of next_element_from_buffer, next_element_from_string, and
3354 next_element_from_c_string.
3355 (tool_bar_lines_needed, redisplay_tool_bar)
3356 (display_menu_bar): Force left-to-right direction. Add a FIXME
3357 comment for making that be controlled by a user option.
3358 (push_it, pop_it): Save and restore the state of the
3359 bidi iterator. Save and restore the bidi_p flag.
3360 (pop_it): Iterate out of display property for string iteration as
3362 (iterate_out_of_display_property): Support iteration over strings.
3363 (handle_single_display_spec): Set up it->bidi_it for iteration
3364 over a display string, and call bidi_init_it.
3365 (handle_single_display_spec, next_overlay_string)
3366 (get_overlay_strings_1, push_display_prop): Set up the bidi
3367 iterator for displaying display or overlay strings.
3368 (forward_to_next_line_start): Don't use the shortcut if
3370 (back_to_previous_visible_line_start): If handle_display_prop
3371 pushed the iterator stack, restore the internal state of the bidi
3372 iterator by calling bidi_pop_it same number of times.
3373 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3374 and we are bidi-iterating, don't decrement the iterator position;
3375 instead, set the first_elt flag in the bidi iterator, to produce
3377 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3378 (push_display_prop): xassert that we are iterating a buffer.
3379 (push_it, pop_it): Save and restore paragraph_embedding member.
3380 (handle_single_display_spec, next_overlay_string)
3381 (get_overlay_strings_1, reseat_1, reseat_to_string)
3382 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3383 correctly. Don't assume unibyte strings are not bidi-reordered.
3384 (compute_display_string_pos)
3385 (compute_display_string_end): Fix handling the case of C string.
3386 (push_it, pop_it): Save and restore from_disp_prop_p.
3387 (handle_single_display_spec, push_display_prop): Set the
3388 from_disp_prop_p flag.
3389 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3390 (pop_it): Call iterate_out_of_display_property only if we are
3391 popping after iteration over a string that came from a display
3392 property. Fix a typo in popping stretch info. Add an assertion
3393 for verifying that the iterator position is in sync with the bidi
3395 (handle_single_display_spec, get_overlay_strings_1)
3396 (push_display_prop): Fix initialization of paragraph direction for
3397 string when that of the parent object is not yet determined.
3398 (reseat_1): Call bidi_init_it to resync the bidi
3399 iterator with IT's position. (Bug#7616)
3400 (find_row_edges): If ROW->start.pos gives position
3401 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3402 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3403 Reset the from_disp_prop_p flag.
3404 (SAVE_IT, RESTORE_IT): New macros.
3405 (pos_visible_p, face_before_or_after_it_pos)
3406 (back_to_previous_visible_line_start)
3407 (move_it_in_display_line_to, move_it_in_display_line)
3408 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3409 (try_scrolling, redisplay_window, display_line): Use them when
3410 saving a temporary copy of the iterator and restoring it back.
3411 (back_to_previous_visible_line_start, reseat_1)
3412 (init_iterator): Empty the bidi cache "stack".
3413 (move_it_in_display_line_to): If iterator ended up at
3414 EOL, but we never saw any buffer positions smaller than
3415 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3416 motion in bidi-reordered lines.
3417 (move_it_in_display_line_to): Record prev_method and prev_pos
3418 immediately before the call to set_iterator_to_next. Fixes cursor
3419 motion in bidi-reordered lines with stretch glyphs and strings
3420 displayed in margins. (Bug#8133) (Bug#8867)
3421 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3423 (pos_visible_p): Support positions in bidi-reordered lines.
3424 Save and restore bidi cache.
3426 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3427 (bidi_paragraph_info): Delete unused struct.
3428 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3429 (bidi_cache_start): New variable.
3430 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3432 (bidi_cache_fetch_state, bidi_cache_search)
3433 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3434 (bidi_cache_find, bidi_peek_at_next_level)
3435 (bidi_level_of_next_char, bidi_find_other_level_edge)
3436 (bidi_move_to_visually_next): Compare cache index with
3437 bidi_cache_start rather than with zero.
3438 (bidi_fetch_char): Accept new argument STRING; all callers
3439 changed. Support iteration over a string. Support strings with
3440 display properties. Support unibyte strings. Fix the type of
3441 `len' according to what STRING_CHAR_AND_LENGTH expects.
3442 (bidi_paragraph_init, bidi_resolve_explicit_1)
3443 (bidi_resolve_explicit, bidi_resolve_weak)
3444 (bidi_level_of_next_char, bidi_move_to_visually_next):
3445 Support iteration over a string.
3446 (bidi_set_sor_type, bidi_resolve_explicit_1)
3447 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3448 can now be zero (for strings); special values 0 and -1 were
3449 changed to -1 and -2, respectively.
3450 (bidi_char_at_pos): New function.
3451 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3452 Call it instead of FETCH_MULTIBYTE_CHAR.
3453 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3454 initialized to valid values.
3455 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3457 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3458 the test for valid cached positions. Fix the logic for looking up
3459 the sentinel state in the cache. GCPRO the Lisp string we are
3461 (bidi_push_it, bidi_pop_it): New functions.
3462 (bidi_initialize): Initialize the bidi cache start stack pointer.
3463 (bidi_cache_ensure_space): New function, refactored from part of
3464 bidi_cache_iterator_state. Don't assume the required size is just
3465 one BIDI_CACHE_CHUNK away.
3466 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3467 (bidi_count_bytes, bidi_char_at_pos): New functions.
3468 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3469 always valid if bidi_cache_idx is valid.
3470 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3471 is valid if it's going to be used.
3472 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3473 (bidi_cache_fetch_state, bidi_cache_search)
3474 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3475 (bidi_cache_iterator_state, bidi_cache_find)
3476 (bidi_find_other_level_edge, bidi_cache_start_stack):
3477 All variables related to cache indices are now EMACS_INT.
3479 * dispextern.h (struct bidi_string_data): New structure.
3480 (struct bidi_it): New member `string'. Make flag members be 1-bit
3481 fields, and put them last in the struct.
3482 (compute_display_string_pos, compute_display_string_end):
3484 (bidi_push_it, bidi_pop_it): Add prototypes.
3485 (struct iterator_stack_entry): New members bidi_p,
3486 paragraph_embedding, and from_disp_prop_p.
3487 (struct it): Member bidi_p is now a bit field 1 bit wide.
3488 (bidi_shelve_cache, bidi_unshelve_cache):
3491 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3492 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3493 and vector-like objects.
3495 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3496 cache around display iteration.
3498 * window.c (Fwindow_end, window_scroll_pixel_based)
3499 (displayed_window_lines, Frecenter): Save and restore the bidi
3500 cache around display iteration.
3502 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3504 * editfns.c (Fdelete_region): Clarify the use of the named
3505 parameters (bug#6788).
3507 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3509 * indent.c (Fvertical_motion): Set and restore w->pointm when
3510 saving and restoring the window's buffer (Bug#9006).
3512 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3514 * editfns.c (Fstring_to_char): Clarify just what is returned
3515 (bug#6576). Text by Eli Zaretskii.
3517 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3519 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3521 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3523 * buffer.c (mmap_find): Fix a typo.
3525 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3527 Fix execution of x selection hooks.
3528 * xselect.c (Qx_lost_selection_functions)
3529 (Qx_sent_selection_functions): New vars.
3530 (syms_of_xselect): DEFSYM them.
3531 (x_handle_selection_request): Pass Qx_sent_selection_functions
3532 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3533 (x_handle_selection_clear,x_clear_frame_selections):
3534 Pass Qx_lost_selection_functions rather than
3535 Vx_lost_selection_functions to Frun_hook_with_args.
3537 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3539 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3540 The old code sometimes used this field without initializing it.
3542 * alloc.c (gc_sweep): Don't read past end of array.
3543 In theory, the old code could also have corrupted Emacs internals,
3544 though it'd be very unlikely.
3546 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3548 * character.c (Fcharacterp): Don't advertise optional ignored
3549 argument. (Bug#4026)
3551 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3553 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3556 * window.c (Fset_window_start): Doc fix (bug#4199).
3557 (Fset_window_hscroll): Ditto.
3559 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3561 Fix minor new problems caught by GCC 4.6.1.
3562 * term.c (init_tty): Remove unused local.
3563 * xsettings.c (store_monospaced_changed): Define this function only
3564 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3567 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3569 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3571 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3573 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3574 are the mini-buffer and the echo area (bug#3320).
3576 * term.c (init_tty): Remove support for supdup, c10 and perq
3577 terminals, which are no longer supported (bug#1482).
3579 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3581 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3583 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3585 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3586 for non-popups (Bug#3642).
3588 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3590 * alloc.c (reset_malloc_hooks): Protoize.
3591 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3592 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3593 * cm.c (losecursor): Likewise.
3594 * data.c (fmod): Likewise.
3595 * dispnew.c (swap_glyphs_in_rows): Likewise.
3596 * emacs.c (memory_warning_signal): Likewise.
3597 * floatfns.c (float_error): Likewise.
3598 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3599 (otf_open, font_otf_capability, generate_otf_features)
3600 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3602 * image.c (pbm_read_file): Likewise.
3603 * indent.c (string_display_width): Likewise.
3604 * intervals.c (check_for_interval, search_for_interval)
3605 (inc_interval_count, count_intervals, root_interval)
3606 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3607 * lread.c (defalias): Likewise.
3608 * ralloc.c (r_alloc_check): Likewise.
3609 * regex.c (set_image_of_range_1, set_image_of_range)
3610 (regex_grow_registers): Likewise.
3611 * sysdep.c (strerror): Likewise.
3612 * termcap.c (valid_filename_p, tprint, main): Likewise.
3613 * tparam.c (main): Likewise.
3614 * unexhp9k800.c (run_time_remap, save_data_space)
3615 (update_file_ptrs, read_header, write_header, calculate_checksum)
3616 (copy_file, copy_rest, display_header): Likewise.
3617 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3619 * xdisp.c (check_it): Likewise.
3620 * xfaces.c (register_color, unregister_color, unregister_colors):
3622 * xfns.c (print_fontset_result): Likewise.
3623 * xrdb.c (member, fatal, main): Likewise.
3625 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3627 Fix minor problems found by static checking (Bug#9031).
3628 * chartab.c (char_table_set_range, map_sub_char_table):
3629 Remove unused locals.
3630 (uniprop_table): Now static.
3631 * composite.c (_work_char): Remove unused static var.
3633 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3635 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3637 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3639 * gtkutil.c (qttip_cb): Remove code without function.
3641 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3643 * w32.c (pthread_sigmask): New stub.
3645 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3647 Use pthread_sigmask, not sigprocmask (Bug#9010).
3648 sigprocmask is portable only for single-threaded applications, and
3649 Emacs can be multi-threaded when it uses GTK.
3650 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3652 * callproc.c (Fcall_process):
3653 * process.c (create_process):
3654 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3655 Use pthread_sigmask, not sigprocmask.
3657 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3659 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3660 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3663 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3665 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3666 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3667 (xg_hide_tooltip): Fix comment.
3669 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3670 in registerServicesMenuSendTypes.
3671 (validRequestorForSendType): Don't check ns_return_types.
3673 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3676 2011-07-08 Jason Rumney <jasonr@gnu.org>
3678 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3679 SH_SHOW for hidden windows (Bug#5482).
3681 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3682 frame struct members of non-existent frames (Bug#6284).
3684 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3686 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3687 variable firstTime not needed on OSX >= 10.6.
3688 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3689 >= 10.5. Use setKnobProportion, setDoubleValue.
3691 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3692 (MAC_OS_X_VERSION_10_5): Define if not defined.
3693 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3694 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3695 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3697 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3698 cString and lossyCString on OSX >= 10.4
3700 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3701 sizeToFit on OSX >= 10.2.
3703 * nsimage.m (allocInitFromFile): Don't use deprecated method
3704 bestRepresentationForDevice on OSX >= 10.6.
3706 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3709 * emacs.c: Declare unexec_init_emacs_zone.
3711 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3713 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3715 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3716 on svcsMenu (Bug#8842).
3718 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3720 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3722 * nsterm.m (QUTF8_STRING): Declare.
3723 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3724 (validRequestorForSendType): Return type is (id).
3725 Change indexOfObjectIdenticalTo to indexOfObject.
3726 Check if we have local selection before returning self (Bug#8842).
3727 (writeSelectionToPasteboard): Put local selection into paste board
3728 if we have a local selection (Bug#8842).
3729 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3731 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3732 (ns_get_local_selection): Declare.
3734 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3736 * keymap.c (describe_map_tree): Don't insert a double newline at
3737 the end of the buffer (bug#1169) and return whether we inserted
3740 * callint.c (Fcall_interactively): Change "reading args" to
3741 "providing args" to try to clarify what it does (bug#1010).
3743 2011-07-07 Kenichi Handa <handa@m17n.org>
3745 * composite.c (composition_compute_stop_pos): Ignore a static
3746 composition starting before CHARPOS (Bug#8915).
3748 * xdisp.c (handle_composition_prop): Likewise.
3750 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3752 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3755 2011-07-07 Kenichi Handa <handa@m17n.org>
3757 * character.h (unicode_category_t): New enum type.
3759 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3760 (Qchar_code_property_table): New variable.
3761 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3762 (UNIPROP_COMPRESSED_FORM_P): New macros.
3763 (char_table_ascii): Uncompress the compressed values.
3764 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3765 Uncompress the compressed values.
3766 (sub_char_table_ref_and_range): Likewise.
3767 (char_table_ref_and_range): Uncompress the compressed values.
3768 (sub_char_table_set): New arg is_uniprop. Callers changed.
3769 Uncompress the compressed values.
3770 (sub_char_table_set_range): Args changed. Callers changed.
3771 (char_table_set_range): Adjuted for the above change.
3772 (map_sub_char_table): Delete args default_val and parent. Add arg
3773 top. Give decoded values to a Lisp function.
3774 (map_char_table): Adjust for the above change. Give decoded
3775 values to a Lisp function. Gcpro more variables.
3776 (uniprop_table_uncompress)
3777 (uniprop_decode_value_run_length): New functions.
3778 (uniprop_decoder, uniprop_decoder_count): New variables.
3779 (uniprop_get_decoder, uniprop_encode_value_character)
3780 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3782 (uniprop_encoder, uniprop_encoder_count): New variables.
3783 (uniprop_get_encoder, uniprop_table)
3784 (Funicode_property_table_internal, Fget_unicode_property_internal)
3785 (Fput_unicode_property_internal): New functions.
3786 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3787 Sunicode_property_table_internal, Sget_unicode_property_internal,
3788 and Sput_unicode_property_internal. Defvar_lisp
3789 char-code-property-alist.
3791 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3792 Vunicode_category_table.
3794 * font.c (font_range): Adjust for the change of
3795 Vunicode_category_table.
3797 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3799 * m/iris4d.h: Remove file, move contents ...
3800 * s/irix6-5.h: ... here.
3802 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3804 Remove unportable assumption about struct layout (Bug#8884).
3805 * alloc.c (mark_buffer):
3806 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3807 (clone_per_buffer_values): Don't assume that
3808 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3809 This isn't true in general, and it's particularly not true
3810 if Emacs is configured with --with-wide-int.
3811 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3812 New macros, used in the buffer.c change.
3814 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3816 * xsettings.c: Use both GConf and GSettings if both are available.
3817 (store_config_changed_event): Add comment.
3818 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3819 (store_tool_bar_style_changed): New functions.
3820 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3821 (struct xsettings): Move font inside HAVE_XFT.
3822 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3823 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3824 Move inside HAVE_XFT.
3825 (something_changed_gsettingsCB): Rename from something_changedCB.
3826 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3828 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3829 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3830 (something_changed_gconfCB): Rename from something_changedCB.
3831 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3832 (parse_settings): Move check for font inside HAVE_XFT.
3833 (read_settings, apply_xft_settings): Add comment.
3834 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3835 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3836 call store_font_name_changed.
3837 (xft_settings_event): Add comment.
3838 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3839 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3840 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3841 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3842 (xsettings_initialize): Call init_gsettings last.
3843 (xsettings_get_system_font, xsettings_get_system_normal_font):
3846 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3848 Random fixes. E.g., (random) never returned negative values.
3849 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3850 subseconds part to the entropy, as that's a bit more random.
3851 Prefer signed to unsigned, since the signedness doesn't matter and
3852 in general we prefer signed. When given a limit, use a
3853 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3854 latter isn't right if USE_2_TAGS_FOR_INTS.
3855 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3856 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3858 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3860 * textprop.c (text_property_stickiness):
3861 Obey Vtext_property_default_nonsticky.
3862 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3863 * w32fns.c (syms_of_w32fns):
3864 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3866 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3868 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3869 This is more efficient than Ffile_directory_p and avoids a minor race.
3871 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3873 * buffer.c (Foverlay_put): Say what the return value is
3876 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3877 is a directory before asking whether to use the file name
3879 (barf_or_query_if_file_exists): Make the "File is a directory"
3880 error be more correct.
3882 * fns.c (Frequire): Remove the mention of the .gz files, since
3883 that's installation-specific, but keep the mention of
3884 `get-load-suffixes'.
3886 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3888 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3889 Report string overflow if the output is too long.
3891 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3893 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3894 (syms_of_gnutls): Remove duplicate DEFSYM for
3895 Qgnutls_bootprop_verify_hostname_error, an error for
3896 Qgnutls_bootprop_verify_error (which is no longer used).
3898 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3899 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3900 Also (re)move comments that are misplaced or no longer relevant.
3902 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3904 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3906 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3908 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3909 and background color parameters if they have been changed.
3911 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3913 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3915 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3917 * xsettings.c (SYSTEM_FONT): Define only when used.
3918 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3920 * keymap.c (access_keymap_1): Now static.
3922 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3924 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3925 leave any prefix arg for the up event (Bug#1586).
3927 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3929 * lread.c (syms_of_lread): Mention single symbols defined by
3930 `defvar' or `defconst' (bug#7154).
3932 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3933 (Frequire): Mention get-load-suffixes.
3935 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3937 * window.h (window): Remove clone_number slot.
3938 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3940 (make_parent_window, make_window, saved_window)
3941 (Fset_window_configuration, save_window_save): Don't deal with
3943 * buffer.c (Qclone_number): Remove declaration.
3944 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3946 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3948 Add multiple inheritance to keymaps.
3949 * keymap.c (Fmake_composed_keymap): New function.
3950 (Fset_keymap_parent): Simplify.
3951 (fix_submap_inheritance): Remove.
3952 (access_keymap_1): New function extracted from access_keymap to handle
3953 embedded parents and handle lists of maps.
3954 (access_keymap): Use it.
3955 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3956 (Fcopy_keymap): Handle embedded parents.
3957 (Fcommand_remapping, define_as_prefix): Simplify.
3958 (Fkey_binding): Simplify.
3959 (syms_of_keymap): Move minibuffer-local-completion-map,
3960 minibuffer-local-filename-completion-map,
3961 minibuffer-local-must-match-map, and
3962 minibuffer-local-filename-must-match-map to Elisp.
3963 (syms_of_keymap): Defsubr make-composed-keymap.
3964 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3965 (parse_menu_item): Trivial simplification.
3967 2011-07-01 Glenn Morris <rgm@gnu.org>
3969 * Makefile.in (SETTINGS_LIBS): Fix typo.
3971 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3973 * coding.c (Fencode_coding_string): Record the last coding system
3974 used, as the function doc string says (bug#8738).
3976 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3978 * xsettings.c (store_monospaced_changed): Take new font as arg and
3979 check for change against current_mono_font.
3980 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3981 (emacs_settings_constructor, emacs_settings_get_property)
3982 (emacs_settings_set_property, emacs_settings_class_init)
3983 (emacs_settings_init, gsettings_obj): Remove.
3984 (something_changedCB): New function for HAVE_GSETTINGS.
3985 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3986 with value as argument.
3987 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3988 g_settings_new (Bug#8967). Do not create gsettings_obj.
3989 Remove calls to g_settings_bind. Connect something_changedCB to
3992 * xgselect.c: Add defined (HAVE_GSETTINGS).
3993 (xgselect_initialize): Ditto.
3995 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3996 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3999 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4001 * eval.c (struct backtrace): Simplify and port the data structure.
4002 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4003 signed bit field, as this assumption is not portable and it makes
4004 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4005 "char debug_on_exit : 1" as this is not portable either; instead,
4006 use the portable "unsigned int debug_on_exit : 1". Remove unused
4007 member evalargs. Remove obsolete comments about cc bombing out.
4009 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4011 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4012 Let HAVE_GSETTINGS override HAVE_GCONF.
4013 (store_monospaced_changed): New function.
4014 (EMACS_SETTINGS): A new type derived from GObject to handle
4015 GSettings notifications.
4016 (emacs_settings_constructor, emacs_settings_get_property)
4017 (emacs_settings_set_property, emacs_settings_class_init):
4019 (gsettings_client, gsettings_obj): New variables.
4020 (GSETTINGS_SCHEMA): New define.
4021 (something_changedCB): Call store_monospaced_changed.
4022 (init_gsettings): New function.
4023 (xsettings_initialize): Call init_gsettings.
4024 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4027 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4030 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4032 * window.c (resize_root_window, grow_mini_window)
4033 (shrink_mini_window): Rename Qresize_root_window to
4034 Qwindow_resize_root_window and Qresize_root_window_vertically to
4035 Qwindow_resize_root_window_vertically.
4037 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4039 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4041 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4043 * makefile.w32-in: Redesign dependencies so they reflect more
4044 clearly which files are directly included by each source file,
4045 and not through other includes.
4047 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4049 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4050 (sort_overlays, overlay_strings): When an overlay's clone number
4051 matches the window's clone number process the overlay even if
4052 the overlay's window property doesn't match the current window.
4054 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4055 (Fwindow_hchild): Rename to Fwindow_left_child.
4056 (Fwindow_next): Rename to Fwindow_next_sibling.
4057 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4058 (resize_window_check): Rename to window_resize_check.
4059 (resize_window_apply): Rename to window_resize_apply.
4060 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4061 (Fdelete_other_windows_internal, resize_frame_windows)
4062 (Fsplit_window_internal, Fdelete_window_internal)
4063 (grow_mini_window, shrink_mini_window)
4064 (Fresize_mini_window_internal): Fix callers accordingly.
4066 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4068 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4069 (emacs_fixed_set_min_size): Remove.
4070 (emacs_fixed_new): Take frame as argument.
4072 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4073 (_EmacsFixedPrivate): Remove minwidth/height.
4074 Add struct frame *f.
4075 (emacs_fixed_init): Initialize priv->f.
4076 (get_parent_class, emacs_fixed_set_min_size): Remove.
4077 (emacs_fixed_new): Set priv->f to argument.
4078 (emacs_fixed_get_preferred_width)
4079 (emacs_fixed_get_preferred_height): Use min_width/height from
4080 frames size_hint to set minimum and natural (Bug#8919).
4081 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4082 and use min_width/height from frames size_hint to set
4083 min_width/height (Bug#8919).
4085 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4086 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4089 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4091 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4092 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4095 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4097 * process.c (wait_reading_process_output): Bypass select if
4098 waiting for a cell while ignoring keyboard input, and input is
4099 pending. Suggested by Jan Djärv (Bug#8869).
4101 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4103 Use gnulib's dup2 module instead of rolling our own.
4104 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4106 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4108 * dispnew.c (scrolling_window): Before scrolling, turn off a
4109 mouse-highlight in the window being scrolled.
4111 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4113 Move DEFSYM to lisp.h and use everywhere.
4115 * character.h (DEFSYM): Move declaration...
4116 * lisp.h (DEFSYM): ...here.
4122 * w32select.c: Don't include character.h.
4124 * alloc.c (syms_of_alloc):
4125 * buffer.c (syms_of_buffer):
4126 * bytecode.c (syms_of_bytecode):
4127 * callint.c (syms_of_callint):
4128 * casefiddle.c (syms_of_casefiddle):
4129 * casetab.c (init_casetab_once):
4130 * category.c (init_category_once, syms_of_category):
4131 * ccl.c (syms_of_ccl):
4132 * cmds.c (syms_of_cmds):
4133 * composite.c (syms_of_composite):
4134 * dbusbind.c (syms_of_dbusbind):
4135 * dired.c (syms_of_dired):
4136 * dispnew.c (syms_of_display):
4137 * doc.c (syms_of_doc):
4138 * editfns.c (syms_of_editfns):
4139 * emacs.c (syms_of_emacs):
4140 * eval.c (syms_of_eval):
4141 * fileio.c (syms_of_fileio):
4142 * fns.c (syms_of_fns):
4143 * frame.c (syms_of_frame):
4144 * fringe.c (syms_of_fringe):
4145 * insdel.c (syms_of_insdel):
4146 * keymap.c (syms_of_keymap):
4147 * lread.c (init_obarray, syms_of_lread):
4148 * macros.c (syms_of_macros):
4149 * msdos.c (syms_of_msdos):
4150 * print.c (syms_of_print):
4151 * process.c (syms_of_process):
4152 * search.c (syms_of_search):
4153 * sound.c (syms_of_sound):
4154 * syntax.c (init_syntax_once, syms_of_syntax):
4155 * terminal.c (syms_of_terminal):
4156 * textprop.c (syms_of_textprop):
4157 * undo.c (syms_of_undo):
4158 * w32.c (globals_of_w32):
4159 * window.c (syms_of_window):
4160 * xdisp.c (syms_of_xdisp):
4161 * xfaces.c (syms_of_xfaces):
4162 * xfns.c (syms_of_xfns):
4163 * xmenu.c (syms_of_xmenu):
4164 * xsettings.c (syms_of_xsettings):
4165 * xterm.c (syms_of_xterm): Use DEFSYM.
4167 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4169 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4171 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4173 Integer and buffer overflow fixes (Bug#8873).
4175 * print.c (printchar, strout): Check for string overflow.
4176 (PRINTPREPARE, printchar, strout):
4177 Don't set size unless allocation succeeds.
4179 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4180 for sizes. Check for string overflow more accurately.
4181 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4183 * macros.c: Integer and buffer overflow fixes.
4184 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4185 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4186 Use ptrdiff_t, not int, for sizes.
4187 Don't increment bufsize until after realloc succeeds.
4188 Check for size-calculation overflow.
4189 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4191 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4193 * lread.c: Integer overflow fixes.
4194 (read_integer): Radix is now EMACS_INT, not int,
4195 to improve quality of diagnostics for out-of-range radices.
4196 Calculate buffer size correctly for out-of-range radices.
4197 (read1): Check for integer overflow in radices, and in
4198 read-circle numbers.
4199 (read_escape): Avoid int overflow.
4200 (Fload, openp, read_buffer_size, read1)
4201 (substitute_object_recurse, read_vector, read_list, map_obarray):
4202 Use ptrdiff_t, not int, for sizes.
4203 (read1): Use EMACS_INT, not int, for sizes.
4204 Check for size overflow.
4206 * image.c (cache_image): Check for size arithmetic overflow.
4208 * lread.c: Integer overflow issues.
4209 (saved_doc_string_size, saved_doc_string_length)
4210 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4211 Now ptrdiff_t, not int.
4212 (read1): Don't assume doc string length fits in int. Check for
4213 out-of-range doc string lengths.
4214 (read_list): Don't assume file position fits in int.
4215 (read_escape): Check for hex character overflow.
4217 2011-06-22 Leo Liu <sdl.web@gmail.com>
4219 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4220 Move to minibuffer.el.
4222 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4224 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4225 The following patches are for when GLYPH_DEBUG && !XASSERT.
4226 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4227 * dispnew.c (flush_stdout):
4228 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4229 Mark as externally visible.
4230 * dispnew.c (check_window_matrix_pointers): Now static.
4231 * dispnew.c (window_to_frame_vpos):
4232 * xfns.c (unwind_create_frame):
4233 * xterm.c (x_check_font): Remove unused local.
4234 * scroll.c (CHECK_BOUNDS):
4235 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4236 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4237 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4238 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4239 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4241 (debug_method_add): Use va_list and vsprintf rather than relying
4242 on undefined behavior with wrong number of arguments.
4243 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4244 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4245 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4246 since we're not interested in debugging glyphs with old libraries.
4247 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4248 GCC 4.6.0's static checking.
4250 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4252 Integer overflow and signedness fixes (Bug#8873).
4253 A few related buffer overrun fixes, too.
4255 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4257 * dispextern.h (struct face.stipple):
4258 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4259 (x_bitmap_mask, x_allocate_bitmap_record)
4260 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4261 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4262 (x_create_bitmap_from_xpm_data):
4263 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4264 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4266 * xfaces.c (load_pixmap):
4267 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4268 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4269 (.bitmaps_last, struct x_output.icon_bitmap):
4270 Use ptrdiff_t, not int, for bitmap indexes.
4271 (x_allocate_bitmap_record): Check for size overflow.
4272 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4274 Use ptrdiff_t, not int, for overlay counts.
4275 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4276 * editfns.c (overlays_around, get_pos_property):
4277 * textprop.c (get_char_property_and_overlay):
4278 * xdisp.c (next_overlay_change, note_mouse_highlight):
4279 * xfaces.c (face_at_buffer_position):
4280 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4281 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4282 (Fnext_overlay_change, Fprevious_overlay_change)
4283 (mouse_face_overlay_overlaps, Foverlays_in):
4284 Use ptrdiff_t, not int, for sizes.
4285 (overlays_at, overlays_in): Check for size-calculation overflow.
4287 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4289 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4290 (x_session_initialize): Do not assume string length fits in int.
4292 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4293 This is unlikely, but can occur if DPI is outlandish.
4295 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4296 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4298 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4299 * xrdb.c (magic_file_p, search_magic_path):
4300 Omit last arg SUFFIX; it was always 0. All callers changed.
4301 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4303 * xfont.c (xfont_match): Avoid need for strlen.
4305 * xfns.c: Don't assume strlen fits in int.
4306 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4308 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4309 not unsigned long, as we prefer signed integers. All callers changed.
4310 Detect integer overflow in repeat count.
4311 (message_dolog): Don't assume print length fits in 39 bytes.
4312 (display_mode_element): Don't assume strlen fits in int.
4314 * termcap.c: Don't assume sizes fit in int and never overflow.
4315 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4316 (gobble_line): Check for size-calculation overflow.
4318 * minibuf.c (Fread_buffer):
4319 * lread.c (intern, intern_c_string):
4320 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4321 Don't assume string length fits in int.
4323 * keyboard.c (parse_tool_bar_item):
4324 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4326 * font.c: Don't assume string length fits in int.
4327 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4328 Use ptrdiff_t, not int.
4329 (font_intern_prop): Don't assume string length fits in int.
4330 Don't assume integer property fits in fixnum.
4331 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4333 * filelock.c: Fix some buffer overrun and integer overflow issues.
4334 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4335 Reformulate so as not to need the command string.
4336 Invoke gzip -cd rather than gunzip, as it's more portable.
4337 (lock_info_type, lock_file_1, lock_file):
4338 Don't assume pid_t and time_t fit in unsigned long.
4339 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4340 (current_lock_owner): Prefer signed type for sizes.
4341 Use memcpy, not strncpy, where memcpy is what is really wanted.
4342 Don't assume (via atoi) that time_t and pid_t fit in int.
4343 Check for time_t and/or pid_t out of range, e.g., via a network share.
4344 Don't alloca where an auto var works fine.
4346 * fileio.c: Fix some integer overflow issues.
4347 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4348 Don't assume string length fits in int.
4349 (directory_file_name): Don't assume string length fits in long.
4350 (make_temp_name): Don't assume pid fits in int, or that its print
4351 length is less than 20.
4353 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4355 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4357 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4359 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4360 We prefer signed integers, even for size calculations.
4362 * emacs.c: Don't assume string length fits in 'int'.
4363 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4364 (main): Don't invoke strlen when not needed.
4366 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4367 (XD_DEBUG_MESSAGE): Don't waste a byte.
4369 * callproc.c (getenv_internal_1, getenv_internal)
4371 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4373 * lread.c (invalid_syntax): Omit length argument.
4374 All uses changed. This doesn't fix a bug, but it simplifies the
4375 code away from its former Hollerith-constant appearance, and it's
4376 one less 'int' to worry about when looking at integer-overflow issues.
4377 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4379 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4380 This didn't break anything, but it didn't help either.
4381 It's confusing to put a bogus integer in a place where the actual
4382 value does not matter.
4383 (LIST_END_P): Remove unused macro and its bogus comment.
4384 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4386 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4387 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4389 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4390 We prefer signed types, and the value cannot exceed the EMACS_INT
4391 range anyway (because otherwise the length would not be representable).
4392 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4393 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4394 This avoids a GCC warning when WIDE_EMACS_INT.
4396 * indent.c (sane_tab_width): New function.
4397 (current_column, scan_for_column, Findent_to, position_indentation)
4398 (compute_motion): Use it. This is just for clarity.
4399 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4401 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4403 * lisp.h (lint_assume): New macro.
4404 * composite.c (composition_gstring_put_cache):
4405 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4407 * editfns.c, insdel.c:
4408 Omit unnecessary forward decls, to simplify future changes.
4410 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4412 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4414 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4415 Use much-faster test for byte-length change.
4416 Don't assume string byte-length fits in 'int'.
4417 Check that character arg fits in 'int'.
4418 (mapcar1): Declare byte as byte, for clarity.
4420 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4422 * fns.c (concat): Catch string overflow earlier.
4423 Do not rely on integer wraparound.
4425 * dispextern.h (struct it.overlay_strings_charpos)
4426 (struct it.selective): Now EMACS_INT, not int.
4427 * xdisp.c (forward_to_next_line_start)
4428 (back_to_previous_visible_line_start)
4429 (reseat_at_next_visible_line_start, next_element_from_buffer):
4430 Don't arbitrarily truncate the value of 'selective' to int.
4432 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4434 * composite.c: Don't truncate sizes to 'int'.
4435 (composition_gstring_p, composition_reseat_it)
4436 (composition_adjust_point): Use EMACS_INT, not int.
4437 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4438 not EMACS_UINT, for indexes.
4440 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4442 * buffer.c: Include <verify.h>.
4443 (struct sortvec.priority, struct sortstr.priority):
4444 Now EMACS_INT, not int.
4445 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4446 (struct sortstr.size, record_overlay_string)
4447 (struct sortstrlist.size, struct sortlist.used):
4448 Don't truncate size to int.
4449 (record_overlay_string): Check for size-calculation overflow.
4450 (init_buffer_once): Check at compile-time, not run-time.
4452 2011-06-22 Jim Meyering <meyering@redhat.com>
4454 Don't leak an XBM-image-sized buffer
4455 * image.c (xbm_load): Free the image buffer after using it.
4457 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4460 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4461 that Sun C diagnosed.
4462 * fns.c (secure_hash): Fix pointer signedness issue.
4463 * intervals.c (static_offset_intervals): New function.
4464 (offset_intervals): Use it.
4466 2011-06-21 Leo Liu <sdl.web@gmail.com>
4469 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4472 * fns.c (secure_hash): Rename from crypto_hash_function and change
4473 the first arg to accept symbols.
4474 (Fsecure_hash): New primitive.
4475 (syms_of_fns): New symbols.
4477 2011-06-20 Deniz Dogan <deniz@dogan.se>
4479 * process.c (Fset_process_buffer): Clarify return value in
4482 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4484 * dispnew.c (add_window_display_history): Use BVAR.
4486 * xdisp.c (debug_method_add): Use BVAR.
4487 (check_window_end, dump_glyph_matrix, dump_glyph)
4488 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4490 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4493 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4494 check till after the cache is created in init_frame_faces.
4496 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4498 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4500 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4502 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4503 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4504 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4506 Improve buffer-overflow checking (Bug#8873).
4507 * fileio.c (Finsert_file_contents):
4508 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4509 Remove the old (too-loose) buffer overflow checks.
4510 They weren't needed, since make_gap checks for buffer overflow.
4511 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4512 The old code merely checked for Emacs fixnum overflow, and relied
4513 on undefined (wraparound) behavior. The new code avoids undefined
4514 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4516 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4517 Tune. Don't use wider integers than needed. Don't use alloca.
4518 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4520 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4522 * insdel.c, lisp.h (buffer_overflow): New function.
4523 (insert_from_buffer_1, replace_range, replace_range_2):
4524 * insdel.c (make_gap_larger):
4525 * editfns.c (Finsert_char):
4526 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4528 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4530 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4532 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4534 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4535 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4537 * fileio.c: Don't assume EMACS_INT fits in off_t.
4538 (emacs_lseek): New static function.
4539 (Finsert_file_contents, Fwrite_region): Use it.
4540 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4542 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4544 * fns.c: Don't overflow int when computing a list length.
4545 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4546 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4547 truncation on 64-bit hosts. Check for QUIT every
4548 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4549 faster and is responsive enough.
4550 (Flength): Report an error instead of overflowing an integer.
4551 (Fsafe_length): Return a float if the value is not representable
4552 as a fixnum. This shouldn't happen except in contrived situations.
4553 (Fnthcdr, Fsort): Don't assume list length fits in int.
4554 (Fcopy_sequence): Don't assume vector length fits in int.
4556 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4557 (header_size, word_size): New constants.
4558 (allocate_vectorlike): Don't check size overflow here.
4559 (allocate_vector): Check it here instead, since this is the only
4560 caller of allocate_vectorlike that could cause overflow.
4561 Check that the new vector's length is representable as a fixnum.
4563 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4564 The previous code was bogus. For example, next_almost_prime (32)
4565 returned 39, which is undesirable as it is a multiple of 3; and
4566 next_almost_prime (24) returned 25, which is a multiple of 5 so
4567 why was the code bothering to check for multiples of 7?
4569 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4571 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4573 Variadic C functions now count arguments with ptrdiff_t.
4574 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4575 Back then I didn't know that the Emacs coding style prefers signed int.
4576 Also, in the meantime I found a few more instances where arguments
4577 were being counted with int, which may truncate counts on 64-bit
4578 machines, or EMACS_INT, which may be unnecessarily wide.
4579 * lisp.h (struct Lisp_Subr.function.aMANY)
4580 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4581 Arg counts are now ptrdiff_t, not size_t.
4582 All variadic functions and their callers changed accordingly.
4583 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4584 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4585 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4586 * callint.c (Fcall_interactively): Check arg count for overflow,
4587 to avoid potential buffer overrun. Use signed char, not 'int',
4588 for 'varies' array, so that we needn't bother to check its size
4589 calculation for overflow.
4590 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4591 * eval.c (apply_lambda):
4592 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4593 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4594 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4596 * callint.c (Fcall_interactively): Don't use index var as event count.
4598 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4599 * mem-limits.h (SIZE): Remove; no longer used.
4601 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4603 Remove unnecessary casts.
4604 * xterm.c (x_term_init):
4605 * xfns.c (x_set_border_pixel):
4606 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4607 These aren't needed now that we assume ANSI C.
4609 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4610 It's more likely to cause problems (due to unsigned overflow)
4613 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4615 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4617 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4619 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4621 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4623 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4625 GLYPH_CODE_FACE returns EMACS_INT, not int.
4626 * dispextern.h (merge_faces):
4627 * xfaces.c (merge_faces):
4628 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4629 Don't assume EMACS_INT fits in int.
4631 * character.h (CHAR_VALID_P): Remove unused parameter.
4632 * fontset.c, lisp.h, xdisp.c: All uses changed.
4634 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4636 * fns.c (concat): Minor tuning based on overflow analysis.
4637 This doesn't fix any bugs. Use int to hold character, instead
4638 of constantly refetching from Emacs object. Use XFASTINT, not
4639 XINT, for value known to be a character. Don't bother comparing
4640 a single byte to 0400, as it's always less.
4642 * floatfns.c (Fexpt):
4643 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4645 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4648 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4650 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4651 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4652 incorrectly succeed when S was a string, because 4294967386 was
4653 truncated before it was used.
4655 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4656 Otherwise, an out-of-range integer could cause undefined behavior
4659 * composite.c: Use int, not EMACS_INT, for characters.
4660 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4661 EMACS_INT, for values that are known to be in character range.
4662 This doesn't fix any bugs but is the usual style inside Emacs and
4663 may generate better code on 32-bit machines.
4665 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4666 This is for reasons similar to the recent CHAR_STRING fix.
4667 * charset.c (Fencode_char): Check that character arg is actually
4668 a character. Pass an int to ENCODE_CHAR.
4669 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4670 wider than 'int', as a compile-time check to prevent future regressions
4673 * character.c (char_string): Remove unnecessary casts.
4675 Make sure a 64-bit char is never passed to CHAR_STRING.
4676 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4677 by silently ignoring the top 32 bits, allowing some values
4678 that were far too large to be valid characters.
4679 * character.h: Include <verify.h>.
4680 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4681 arguments are no wider than unsigned, as a compile-time check
4682 to prevent future regressions in this area.
4684 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4685 (Fsubst_char_in_region):
4687 * xdisp.c (decode_mode_spec_coding):
4688 Adjust to CHAR_STRING's new requirement.
4689 * editfns.c (Finsert_char, Fsubst_char_in_region):
4690 * fns.c (concat): Check that character args are actually
4691 characters. Without this test, these functions did the wrong
4692 thing with wildly out-of-range values on 64-bit hosts.
4694 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4695 These casts should not be needed on 32-bit hosts, either.
4696 * keyboard.c (read_char):
4697 * lread.c (Fload): Remove casts to unsigned.
4699 * lisp.h (UNSIGNED_CMP): New macro.
4700 This fixes comparison bugs on 64-bit hosts.
4701 (ASCII_CHAR_P): Use it.
4702 * casefiddle.c (casify_object):
4703 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4704 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4705 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4706 * dispextern.h (FACE_FROM_ID):
4707 * keyboard.c (read_char): Use UNSIGNED_CMP.
4709 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4710 not to EMACS_INT, to avoid GCC warning.
4712 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4714 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4715 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4716 isn't needed on 32-bit machines.
4718 * buffer.c (Fgenerate_new_buffer_name):
4719 Use EMACS_INT for count, not int.
4720 (advance_to_char_boundary): Return EMACS_INT, not int.
4722 * data.c (Qcompiled_function): Now static.
4724 * window.c (window_body_lines): Now static.
4726 * image.c (gif_load): Rename local to avoid shadowing.
4728 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4729 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4730 * alloc.c (make_save_value): Integer argument is now of type
4732 (mark_object): Use ptrdiff_t, not int.
4733 * lisp.h (pD): New macro.
4734 * print.c (print_object): Use it.
4736 * alloc.c: Use EMACS_INT, not int, to count objects.
4737 (total_conses, total_markers, total_symbols, total_vector_size)
4738 (total_free_conses, total_free_markers, total_free_symbols)
4739 (total_free_floats, total_floats, total_free_intervals)
4740 (total_intervals, total_strings, total_free_strings):
4741 Now EMACS_INT, not int. All uses changed.
4742 (Fgarbage_collect): Compute overall total using a double, so that
4743 integer overflow is less likely to be a problem. Check for overflow
4744 when converting back to an integer.
4745 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4746 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4747 These were 'int' variables that could overflow on 64-bit hosts;
4748 they were never used, so remove them instead of repairing them.
4749 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4750 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4751 Previously, this ceilinged at INT_MAX, but that doesn't work on
4753 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4755 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4756 (allocate_vectorlike): Check for ptrdiff_t overflow.
4757 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4758 when a (possibly-narrower) signed value would do just as well.
4759 We prefer using signed arithmetic, to avoid comparison confusion.
4761 * alloc.c: Catch some string size overflows that we were missing.
4762 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4763 for convenience in STRING_BYTES_MAX.
4764 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4765 The definition here is exact; the one in lisp.h was approximate.
4766 (allocate_string_data): Check for string overflow. This catches
4767 some instances we weren't catching before. Also, it catches
4768 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4769 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4770 and ptrdiff_t and EMACS_INT are both 64 bits.
4772 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4773 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4774 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4776 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4778 * alloc.c (Fmake_string): Check for out-of-range init.
4780 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4782 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4784 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4786 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4787 xg_get_default_scrollbar_width.
4789 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4790 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4791 (style_changed_cb): Call update_theme_scrollbar_width and call
4792 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4793 all frames (Bug#8505).
4794 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4795 Call gtk_window_set_resizable if HAVE_GTK3.
4796 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4797 and height if HAVE_GTK3 (Bug#8505).
4798 (scroll_bar_width_for_theme): New variable.
4799 (update_theme_scrollbar_width): New function.
4800 (xg_get_default_scrollbar_width): Move code to
4801 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4802 (xg_initialize): Call update_theme_scrollbar_width.
4804 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4806 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4808 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4810 * frame.c (make_frame): Call other_buffer_safely instead of
4813 * window.c (temp_output_buffer_show): Call display_buffer with
4814 second argument Vtemp_buffer_show_specifiers and reset latter
4815 immediately after the call.
4816 (Vtemp_buffer_show_specifiers): New variable.
4817 (auto_window_vscroll_p, next_screen_context_lines)
4818 (Vscroll_preserve_screen_position): Remove leading asterisks from
4821 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4823 Fix minor problems found by GCC 4.6.0 static checking.
4824 * buffer.c (Qclone_number): Remove for now, as it's unused.
4825 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4826 (record_buffer): Remove unused local.
4827 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4828 (set_frame_buffer_list): Remove; unused.
4829 * frame.h (other_visible_frames): Remove decl.
4830 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4831 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4832 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4834 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4835 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4836 Define only if HAVE_GPM.
4837 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4838 (update_hints_inhibit): Remove; never set. All uses removed.
4839 * widgetprv.h (emacsFrameClassRec): Remove decl.
4840 * window.c (delete_deletable_window): Now returns void, since it
4841 wasn't returning anything.
4842 (compare_window_configurations): Remove unused locals.
4843 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4844 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4845 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4846 the same widths as pointers. This follows up on the 2011-05-06 patch.
4847 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4848 * xterm.h: Likewise.
4849 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4851 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4853 * makefile.w32-in: Update dependencies.
4854 (LISP_H): Add lib/intprops.h.
4856 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4858 * image.c (gif_load): Add animation frame delay to the metadata.
4859 (syms_of_image): Use DEFSYM. New symbol `delay'.
4861 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4863 * window.c (delete_deletable_window): Re-add.
4864 (Fset_window_configuration): Rewrite to handle dead buffers and
4865 consequently deletable windows.
4866 (window_tree, Fwindow_tree): Remove. Supply functionality in
4868 (compare_window_configurations): Simplify code.
4870 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4872 * image.c (imagemagick_load_image): Fix type mismatch.
4873 (Fimagemagick_types): Likewise.
4875 * window.h (replace_buffer_in_windows): Declare.
4877 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4879 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4880 Qclone_number. Remove external declaration of Qdelete_window.
4881 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4883 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4884 Run Qbuffer_list_update_hook if allowed.
4885 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4886 buffer list implementation.
4887 (other_buffer_safely): New function.
4888 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4889 calls to replace_buffer_in_windows and
4890 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4892 (record_buffer): Inhibit quitting and rewrite using quittable
4893 functions. Run Qbuffer_list_update_hook if allowed.
4894 (Frecord_buffer, Funrecord_buffer): New functions.
4895 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4896 Move switch-to-buffer to window.el.
4897 (bury-buffer): Move to window.el.
4898 (Vbuffer_list_update_hook): New variable.
4900 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4903 * window.h (resize_frame_windows): Move up in code.
4904 (Fwindow_frame): Remove EXFUN.
4905 (replace_buffer_in_all_windows): Remove prototype.
4906 (replace_buffer_in_windows_safely): Add prototype.
4908 * window.c: Declare Qdelete_window static again. Move down
4909 declaration of select_count.
4910 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4911 (Fother_window): Move to window.el.
4912 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4913 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4914 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4916 (replace_buffer_in_windows): Implement by calling
4917 Qreplace_buffer_in_windows.
4918 (replace_buffer_in_all_windows): Remove with some functionality
4919 moved into replace_buffer_in_windows_safely.
4920 (replace_buffer_in_windows_safely): New function.
4921 (select_window_norecord, select_frame_norecord): Move in front
4922 of run_window_configuration_change_hook. Remove now obsolete
4924 (Fset_window_buffer): Rewrite doc-string.
4925 Call Qrecord_window_buffer.
4926 (keys_of_window): Move binding for other-window to window.el.
4928 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4930 * dispextern.h (struct image): Replace data member, whose int_val
4931 and ptr_val fields were not used by anything, with a single
4934 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4935 (gif_clear_image, gif_load, imagemagick_load_image)
4936 (gs_clear_image, gs_load): Callers changed.
4938 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4940 * buffer.h: Include <time.h>, for time_t.
4941 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4943 Fix minor problems found by static checking.
4945 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4947 Make identifiers static if they are not used in other modules.
4948 * data.c (Qcompiled_function, Qframe, Qvector):
4949 * image.c (QimageMagick, Qsvg):
4950 * minibuf.c (Qmetadata):
4951 * window.c (resize_window_check, resize_root_window): Now static.
4952 * window.h (resize_window_check, resize_root_window): Remove decls.
4954 * window.c (window_deletion_count, delete_deletable_window):
4956 (window_body_lines): Now static.
4957 (Fdelete_other_windows_internal): Mark vars as initialized.
4958 Make sure 'resize_failed' is initialized.
4959 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4960 (resize_window_apply): Remove unused local.
4961 * window.h (delete_deletable_window): Remove decl.
4963 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4964 (imagemagick_load_image): Fix pointer signedness problem by changing
4965 last arg from unsigned char * to char *. All uses changed.
4966 Also, fix a local for similar reasons.
4967 Remove unused locals. Remove locals to avoid shadowing.
4968 (fn_rsvg_handle_free): Remove; unused.
4969 (svg_load, svg_load_image): Fix pointer signedness problem.
4970 (imagemagick_load_image): Don't use garbage pointer image_wand.
4972 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4974 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4976 * image.c (gif_load): Fix omitted cast error introduced by
4979 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4981 * window.h (resize_proportionally, orig_total_lines)
4982 (orig_top_line): Remove from window structure.
4983 (set_window_height, set_window_width, change_window_heights)
4984 (Fdelete_window): Remove prototypes.
4985 (resize_frame_windows): Remove duplicate declaration.
4987 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4989 * window.h (resize_frame_windows, resize_window_check)
4990 (delete_deletable_window, resize_root_window)
4991 (resize_frame_windows): Declare prototypes.
4993 * window.c (resize_window_apply): Make definition be "static" to
4994 match the prototype.
4996 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4998 * window.c: Remove declarations of Qwindow_size_fixed,
4999 window_min_size_1, window_min_size_2, window_min_size,
5000 size_window, window_fixed_size_p, enlarge_window, delete_window.
5001 Remove static from declaration of Qdelete_window, it's
5002 temporarily needed by Fbury_buffer.
5003 (replace_window): Don't assign orig_top_line and
5005 (Fdelete_window, delete_window): Remove. Window deletion is
5006 handled by window.el.
5007 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5008 Replace Fdelete_window calls with calls to Qdelete_window.
5009 (Fdelete_other_windows): Remove. Deleting other windows is
5010 handled by window.el.
5011 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5012 handled in window.el.
5013 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5014 Window minimum sizes are handled in window.el.
5015 (shrink_windows, size_window, set_window_height)
5016 (set_window_width, change_window_heights, window_height)
5017 (window_width, CURBEG, CURSIZE, enlarge_window)
5018 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5019 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5020 handled in window.el.
5021 (make_dummy_parent): Rename to make_parent_window and give it a
5022 second argument horflag.
5023 (make_window): Don't set resize_proportionally any more.
5024 (Fsplit_window): Remove. Windows are split in window.el.
5025 (save_restore_action, save_restore_orig_size)
5026 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5027 Resize mini windows in window.el.
5028 (grow_mini_window, shrink_mini_window): Implement by calling
5029 Qresize_root_window_vertically, resize_window_check and
5030 resize_window_apply.
5031 (saved_window, Fset_window_configuration, save_window_save):
5032 Do not handle orig_top_line, orig_total_lines, and
5033 resize_proportionally.
5034 (window_min_height, window_min_width): Move to window.el.
5035 (keys_of_window): Move bindings for delete-other-windows,
5036 split-window, delete-window and enlarge-window to window.el.
5038 * buffer.c: Temporarily extern Qdelete_window.
5039 (Fbury_buffer): Temporarily call Qdelete_window instead of
5040 Fdelete_window (Fbury_buffer will move to window.el soon).
5042 * frame.c (set_menu_bar_lines_1): Remove code handling
5043 orig_top_line and orig_total_lines.
5045 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5046 set_window_height but set heights directly.
5047 (change_frame_size_1): Use resize_frame_windows.
5049 * xdisp.c (init_xdisp): Don't use set_window_height but set
5052 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5053 Use resize_frame_windows instead of change_window_heights and run
5054 run_window_configuration_change_hook.
5056 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5057 instead of change_window_heights and run
5058 run_window_configuration_change_hook.
5060 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5062 * window.c (replace_window): Rename second argument REPLACEMENT to
5063 NEW. New third argument SETFLAG. Rewrite.
5064 (delete_window, make_dummy_parent): Call replace_window with
5066 (window_list_1): Move down in code.
5067 (run_window_configuration_change_hook): Move set_buffer part
5068 before select_frame_norecord part in order to unwind correctly.
5069 Rename count1 to count.
5070 (recombine_windows, delete_deletable_window, resize_root_window)
5071 (Fdelete_other_windows_internal)
5072 (Frun_window_configuration_change_hook, make_parent_window)
5073 (resize_window_check, resize_window_apply, Fresize_window_apply)
5074 (resize_frame_windows, Fsplit_window_internal)
5075 (Fdelete_window_internal, Fresize_mini_window_internal):
5077 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5079 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5081 * window.h (window): Add some new members to window structure -
5082 normal_lines, normal_cols, new_total, new_normal, clone_number,
5083 splits, nest, prev_buffers, next_buffers.
5084 (WINDOW_TOTAL_SIZE): Move here from window.c.
5085 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5087 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5089 (make_dummy_parent): Set new members of windows structure.
5090 (make_window): Move down in code. Handle new members of window
5092 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5093 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5094 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5095 (Fset_window_prev_buffers, Fwindow_next_buffers)
5096 (Fset_window_next_buffers, Fset_window_clone_number):
5098 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5099 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5101 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5102 Argument WINDOW can be now internal window too.
5103 (Fwindow_use_time): Move up in code.
5104 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5106 (Fset_window_configuration, saved_window)
5107 (Fcurrent_window_configuration, save_window_save): Handle new
5108 members of window structure.
5109 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5110 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5111 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5112 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5113 Qget_mru_window, Qresize_root_window,
5114 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5115 Qauto_buffer_name; staticpro them.
5117 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5119 * window.c (Fwindow_total_size, Fwindow_left_column)
5120 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5121 (Fwindow_list_1): New functions.
5122 (window_box_text_cols): Replace with window_body_cols.
5123 (Fwindow_width, Fscroll_left, Fscroll_right):
5124 Use window_body_cols instead of window_box_text_cols.
5125 (delete_window, Fset_window_configuration):
5126 Call delete_all_subwindows with window as argument.
5127 (delete_all_subwindows): Take a window as argument and not a
5129 (window_loop): Remove handling of GET_LRU_WINDOW and
5131 (Fget_lru_window, Fget_largest_window): Move to window.el.
5133 * window.h: Extern window_body_cols instead of
5134 window_box_text_cols. delete_all_subwindows now takes a
5135 Lisp_Object as argument.
5137 * indent.c (compute_motion, Fcompute_motion):
5138 Use window_body_cols instead of window_box_text_cols.
5140 * frame.c (delete_frame): Call delete_all_subwindows with root
5143 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5145 * fns.c (Fputhash): Document return value.
5147 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5149 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5151 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5153 Cons<->int and similar integer overflow fixes (Bug#8794).
5155 Check for overflow when converting integer to cons and back.
5156 * charset.c (Fdefine_charset_internal, Fdecode_char):
5157 Use cons_to_unsigned to catch overflow.
5158 (Fencode_char): Use INTEGER_TO_CONS.
5159 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5160 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5161 * data.c (long_to_cons, cons_to_long): Remove.
5162 (cons_to_unsigned, cons_to_signed): New functions.
5163 These signal an error for invalid or out-of-range values.
5164 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5165 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5166 * font.c (Ffont_variation_glyphs):
5167 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5168 * lisp.h: Include <intprops.h>.
5169 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5170 (cons_to_signed, cons_to_unsigned): New decls.
5171 (long_to_cons, cons_to_long): Remove decls.
5172 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5173 (Fprimitive_undo): Use CONS_TO_INTEGER.
5174 * xfns.c (Fx_window_property): Likewise.
5175 * xselect.c: Include <limits.h>.
5176 (x_own_selection, selection_data_to_lisp_data):
5177 Use INTEGER_TO_CONS.
5178 (x_handle_selection_request, x_handle_selection_clear)
5179 (x_get_foreign_selection, Fx_disown_selection_internal)
5180 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5181 (lisp_data_to_selection_data): Use cons_to_unsigned.
5182 (x_fill_property_data): Use cons_to_signed.
5183 Report values out of range.
5185 Check for buffer and string overflow more precisely.
5186 * buffer.h (BUF_BYTES_MAX): New macro.
5187 * lisp.h (STRING_BYTES_MAX): New macro.
5188 * alloc.c (Fmake_string):
5189 * character.c (string_escape_byte8):
5190 * coding.c (coding_alloc_by_realloc):
5191 * doprnt.c (doprnt):
5192 * editfns.c (Fformat):
5194 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5195 since they may not be the same number.
5196 * editfns.c (Finsert_char):
5197 * fileio.c (Finsert_file_contents):
5198 Likewise for BUF_BYTES_MAX.
5200 * image.c: Use ptrdiff_t, not int, for sizes.
5201 (slurp_file): Switch from int to ptrdiff_t.
5203 (slurp_file): Check that file size fits in both size_t (for
5204 malloc) and ptrdiff_t (for sanity and safety).
5206 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5207 if b->modtime has its maximal value.
5209 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5211 Don't assume time_t can fit into int.
5212 * buffer.h (struct buffer.modtime): Now time_t, not int.
5213 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5214 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5216 Minor fixes for signed vs unsigned integers.
5217 * character.h (MAYBE_UNIFY_CHAR):
5218 * charset.c (maybe_unify_char):
5219 * keyboard.c (read_char, reorder_modifiers):
5220 XINT -> XFASTINT, since the integer must be nonnegative.
5221 * ftfont.c (ftfont_spec_pattern):
5222 * keymap.c (access_keymap, silly_event_symbol_error):
5223 XUINT -> XFASTINT, since the integer must be nonnegative.
5224 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5225 since it makes no difference and we prefer signed.
5226 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5227 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5230 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5232 * window.h (Fwindow_frame): Declare.
5234 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5236 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5237 (SPARE_MEMORY): Always define.
5238 (LARGE_REQUEST): Remove.
5239 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5241 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5243 * lisp.h: Move EXFUNS for Fframe_root_window,
5244 Fframe_first_window and Fset_frame_selected_window to window.h.
5246 * window.h: Move EXFUNS for Fframe_root_window,
5247 Fframe_first_window and Fset_frame_selected_window here from
5250 * frame.c (Fwindow_frame, Fframe_first_window)
5251 (Fframe_root_window, Fframe_selected_window)
5252 (Fset_frame_selected_window): Move to window.c.
5253 (Factive_minibuffer_window): Move to minibuf.c.
5254 (Fother_visible_frames_p): New function.
5256 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5258 * window.c (decode_window, decode_any_window): Move up in code.
5259 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5260 (inhibit_frame_unsplittable): Remove unused variable.
5261 (Fwindow_buffer): Move up and rewrite doc-string.
5262 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5263 (Fwindow_prev): New functions.
5264 (Fwindow_frame): Move here from frame.c. Accept any window as
5266 (Fframe_root_window, Fframe_first_window)
5267 (Fframe_selected_window): Move here from frame.c. Accept frame
5268 or arbitrary window as argument. Update doc-strings.
5269 (Fminibuffer_window): Move up in code.
5270 (Fwindow_minibuffer_p): Move up in code and simplify.
5271 (Fset_frame_selected_window): Move here from frame.c.
5273 (Fselected_window, select_window, Fselect_window): Move up in
5274 code. Minor doc-string fixes.
5276 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5278 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5279 Do not assume that spare memory exists; that assumption is valid
5280 only if SYSTEM_MALLOC.
5281 (LARGE_REQUEST): New macro, so that the issue of large requests
5282 is separated from the issue of spare memory.
5284 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5286 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5289 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5291 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5294 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5296 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5298 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5300 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5301 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5303 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5305 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5307 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5309 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5310 (x_clipboard_manager_save): Add return value.
5311 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5313 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5314 Obey Vx_select_enable_clipboard_manager. Catch errors in
5315 x_clipboard_manager_save (Bug#8779).
5316 (Vx_select_enable_clipboard_manager): New variable.
5317 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5319 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5321 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5323 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5325 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5326 in the current matrix if keep_current_p is non-zero.
5328 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5330 * bidi.c (bidi_level_of_next_char): Fix last change.
5332 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5334 Support bidi reordering of text covered by display properties.
5336 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5337 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5338 (bidi_cache_search, bidi_cache_iterator_state)
5339 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5340 (bidi_level_of_next_char, bidi_move_to_visually_next):
5341 Support character positions inside a run of characters covered by a
5343 (bidi_paragraph_init, bidi_resolve_explicit_1)
5344 (bidi_level_of_next_char): Call bidi_fetch_char and
5345 bidi_fetch_char_advance instead of FETCH_CHAR and
5347 (bidi_init_it): Initialize new members.
5348 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5350 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5351 instead of using explicit *_CHAR codes.
5352 (bidi_resolve_explicit, bidi_resolve_weak):
5353 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5354 bidirectional text is supported only in multibyte buffers.
5355 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5356 it to initialize the frame_window_p member of struct bidi_it.
5357 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5358 (bidi_resolve_explicit, bidi_resolve_weak)
5359 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5360 bidi_it->nchars is non-positive.
5361 (bidi_level_of_next_char): Don't try to lookup the cache for the
5362 next/previous character if nothing is cached there yet, or if we
5363 were just reseat()'ed to a new position.
5365 * xdisp.c (set_cursor_from_row): Set start and stop points
5366 according to the row's direction when priming the loop that looks
5367 for the glyph on which to display cursor.
5368 (single_display_spec_intangible_p): Function deleted.
5369 (display_prop_intangible_p): Reimplement to call
5370 handle_display_spec instead of single_display_spec_intangible_p.
5371 Accept 3 additional arguments needed by handle_display_spec.
5372 This fixes incorrect cursor motion across display property with complex
5373 values: lists, `(when COND...)' forms, etc.
5374 (single_display_spec_string_p): Support property values that are
5375 lists with the argument STRING its top-level element.
5376 (display_prop_string_p): Fix the condition for processing a
5377 property that is a list to be consistent with handle_display_spec.
5378 (handle_display_spec): New function, refactored from the
5379 last portion of handle_display_prop.
5380 (compute_display_string_pos): Accept additional argument
5381 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5382 value of a `display' property is a "replacing spec".
5383 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5384 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5385 the display property, but just return a value indicating whether
5386 the display property will replace the characters it covers.
5387 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5388 frame_window_p members of struct bidi_it.
5389 (compute_display_string_pos, compute_display_string_end):
5391 (push_it): Accept second argument POSITION, where pop_it should
5392 jump to continue iteration.
5393 (reseat_1): Initialize bidi_it.disp_pos.
5395 * keyboard.c (adjust_point_for_property): Adjust the call to
5396 display_prop_intangible_p to its new signature.
5398 * dispextern.h (struct bidi_it): New member frame_window_p.
5399 (bidi_init_it): Update prototypes.
5400 (display_prop_intangible_p): Update prototype.
5401 (compute_display_string_pos, compute_display_string_end):
5403 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5406 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5408 Malloc failure behavior now depends on size of allocation.
5409 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5410 * lisp.h: Change signatures accordingly.
5411 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5412 All callers changed. (Bug#8762)
5414 * gnutls.c: Use Emacs's memory allocators.
5415 Without this change, the gnutls library would invoke malloc etc.
5416 directly, which causes problems on non-SYNC_INPUT hosts, and which
5417 runs afoul of improving memory_full behavior. (Bug#8761)
5418 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5419 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5420 xfree instead of the default malloc, realloc, free.
5421 (Fgnutls_boot): No need to check for memory allocation failure,
5422 since xmalloc does that for us.
5424 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5425 * category.c (hash_get_category_set):
5426 * ccl.c (ccl_driver):
5427 * charset.c (Fdefine_charset_internal):
5428 * charset.h (struct charset.hash_index):
5429 * composite.c (get_composition_id, gstring_lookup_cache)
5430 (composition_gstring_put_cache):
5431 * composite.h (struct composition.hash_index):
5432 * dispextern.h (struct image.hash):
5433 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5434 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5435 (hashfn_equal, hashfn_user_defined, make_hash_table)
5436 (maybe_resize_hash_table, hash_lookup, hash_put)
5437 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5438 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5439 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5440 * image.c (make_image, search_image_cache, lookup_image)
5441 (xpm_put_color_table_h):
5442 * lisp.h (struct Lisp_Hash_Table):
5443 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5444 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5445 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5446 * alloc.c (allocate_vectorlike):
5447 Check for overflow in vector size calculations.
5448 * ccl.c (ccl_driver):
5449 Check for overflow when converting EMACS_INT to int.
5450 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5451 need to be updated by these changes.
5452 * fns.c (make_hash_table, maybe_resize_hash_table):
5453 Check for integer overflow with large hash tables.
5454 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5455 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5456 (SXHASH_REDUCE): New macro.
5457 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5458 Use it instead of discarding useful hash info with large hash values.
5459 (sxhash_float): New function.
5460 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5461 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5462 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5463 Rewrite to use FIXNUM_BITS, as this simplifies things.
5464 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5465 Adjust signatures to match updated version of code.
5466 (consing_since_gc): Now EMACS_INT, since a single hash table can
5467 use more than INT_MAX bytes.
5469 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5471 Make it possible to build with GCC-4.6+ -O2 -flto.
5473 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5475 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5477 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5478 Call minibuffer-inactive-mode.
5480 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5482 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5483 Update dependencies.
5485 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5487 * data.c (init_data): Remove code for UTS, this system is not
5490 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5492 Don't force ./temacs to start in terminal mode.
5494 * frame.c (make_initial_frame): Initialize faces in all cases, not
5495 only when CANNOT_DUMP is defined.
5496 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5498 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5500 * dispnew.c (add_window_display_history): Use const for the string
5501 pointer. Remove declaration, not needed.
5503 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5505 Use 'inline', not 'INLINE'.
5506 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5507 * alloc.c, fontset.c (INLINE): Remove.
5508 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5509 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5510 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5511 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5512 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5514 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5516 Make it possible to run ./temacs.
5518 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5519 syms_of_callproc does the same thing. Remove test for
5520 "initialized", do it in the caller.
5521 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5523 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5525 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5526 (read_minibuf): Use get_minibuffer.
5527 (syms_of_minibuf): Use DEFSYM.
5528 (Qmetadata): New var.
5529 * data.c (Qbuffer): Don't make it static.
5530 (syms_of_data): Use DEFSYM.
5532 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5534 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5535 (CCL_CODE_MIN): New macro.
5537 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5539 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5541 * eval.c (Qdebug): Now static.
5542 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5543 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5544 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5546 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5548 * image.c: Various fixes to ImageMagick code comments.
5549 (Fimagemagick_types): Doc fix.
5551 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5553 Minor fixes prompted by GCC 4.6.0 warnings.
5555 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5557 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5558 (x_clipboard_manager_save_all): Move extern decl to ...
5559 * xterm.h: ... here, so that it can be checked for consistency.
5561 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5563 * xselect.c (x_clipboard_manager_save_frame)
5564 (x_clipboard_manager_save_all): New functions.
5565 (Fx_clipboard_manager_save): Lisp function deleted.
5567 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5568 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5570 * xterm.h: Update prototype.
5572 2011-05-28 William Xu <william.xwl@gmail.com>
5574 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5577 2011-05-28 Jim Meyering <meyering@redhat.com>
5579 Avoid a sign-extension bug in crypto_hash_function.
5580 * fns.c (to_uchar): Define.
5581 (crypto_hash_function): Use it to convert some newly-signed
5582 variables to unsigned, to avoid sign-extension bugs. For example,
5583 without this change, (md5 "truc") would evaluate to
5584 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5585 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5586 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5588 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5590 Integer overflow fixes.
5592 * dbusbind.c: Serial number integer overflow fixes.
5593 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5594 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5595 to hold a serial number that is too large for a fixnum.
5596 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5597 Check for serial numbers out of range. Decode any serial number
5598 that was so large that it became a float. (Bug#8722)
5600 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5601 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5602 Use XFASTINT rather than XUINT when numbers are nonnegative.
5603 (xd_append_arg, Fdbus_method_return_internal):
5604 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5605 arguments, check that Lisp number is nonnegative, rather than
5606 silently wrapping negative numbers around. (Bug#8722)
5607 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5610 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5612 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5614 ccl: add integer overflow checks
5615 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5616 (IN_INT_RANGE): New macros.
5617 (ccl_driver): Use them to check for integer overflow when
5618 decoding a CCL program. Many of the new checks are whether XINT (x)
5619 fits in int; it doesn't always, on 64-bit hosts. The new version
5620 doesn't catch all possible integer overflows, but it's an
5621 improvement. (Bug#8719)
5623 * alloc.c (make_event_array): Use XINT, not XUINT.
5624 There's no need for unsigned here.
5626 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5627 This follows up to the 2011-05-06 change that substituted uintptr_t
5628 for EMACS_INT. This case wasn't caught back then.
5630 Rework Fformat to avoid integer overflow issues.
5631 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5632 now (part of C89). Include <verify.h>.
5633 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5634 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5635 (Fformat): Avoid the prepass trying to compute sizes; it was only
5636 approximate and thus did not catch overflow reliably. Instead, walk
5637 through the format just once, formatting and computing sizes as we go,
5638 checking for integer overflow at every step, and allocating a larger
5639 buffer as needed. Keep track separately whether the format is
5640 multibyte. Keep only the most-recently calculated precision, rather
5641 than them all. Record whether each argument has been converted to
5642 string. Use EMACS_INT, not int, for byte and char and arg counts.
5643 Support field widths and precisions larger than INT_MAX. Avoid
5644 sprintf's undefined behavior with conversion specifications such as %#d
5645 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5646 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5647 formatting out-of-range floating point numbers with int
5650 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5652 * data.c: Avoid integer truncation in expressions involving floats.
5653 * data.c: Include <intprops.h>.
5654 (arith_driver): When there's an integer overflow in an expression
5655 involving floating point, convert the integers to floating point
5656 so that the resulting value does not suffer from catastrophic
5657 integer truncation. For example, on a 64-bit host (* 4
5658 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5659 Do not rely on undefined behavior after integer overflow.
5661 merge count_size_as_multibyte, parse_str_to_multibyte
5662 * character.c, character.h (count_size_as_multibyte):
5663 Rename from parse_str_to_multibyte; all uses changed.
5664 Check for integer overflow.
5665 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5666 since it's now a duplicate of the other. This is more of
5667 a character than a buffer op, so better that it's in character.c.
5668 * fns.c, print.c: Adjust to above changes.
5670 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5672 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5674 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5676 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5677 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5678 (x_clipboard_manager_save): Now static.
5679 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5681 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5682 (crypto_hash_function): Now static.
5683 Fix pointer signedness problems. Avoid unnecessary initializations.
5685 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5687 * termhooks.h (Vselection_alist): Make it terminal-local.
5689 * terminal.c (create_terminal): Initialize it.
5691 * xselect.c: Support for clipboard managers.
5692 (Vselection_alist): Move to termhooks.h as terminal-local var.
5693 (LOCAL_SELECTION): New macro.
5694 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5695 (symbol_to_x_atom): Remove gratuitous arg.
5696 (x_handle_selection_request, lisp_data_to_selection_data)
5697 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5698 (x_own_selection, x_get_local_selection, x_convert_selection):
5699 New arg, specifying work frame. Use terminal-local Vselection_alist.
5700 (some_frame_on_display): Delete unused function.
5701 (Fx_own_selection_internal, Fx_get_selection_internal)
5702 (Fx_disown_selection_internal, Fx_selection_owner_p)
5703 (Fx_selection_exists_p): New optional frame arg.
5704 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5705 (x_handle_selection_clear): Don't treat other terminals with the
5706 same keyboard specially. Use the terminal-local Vselection_alist.
5707 (x_clear_frame_selections): Use Frun_hook_with_args.
5709 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5711 * xterm.h: Add support for those atoms.
5713 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5715 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5716 (converted_selections, conversion_fail_tag): New global variables.
5717 (x_selection_request_lisp_error): Free the above.
5718 (x_get_local_selection): Remove unnecessary code.
5719 (x_reply_selection_request): Args changed; handle arbitrary array
5720 of converted selections stored in converted_selections.
5721 Separate the XChangeProperty and SelectionNotify steps.
5722 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5723 (x_convert_selection): New function.
5724 (x_handle_selection_event): Simplify.
5725 (x_get_foreign_selection): Don't ignore incoming requests while
5726 waiting for an answer; this will fail when we implement
5727 SAVE_TARGETS, and seems unnecessary anyway.
5728 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5729 (Vx_sent_selection_functions): Doc fix.
5731 2011-05-26 Leo Liu <sdl.web@gmail.com>
5733 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5735 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5737 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5739 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5740 for fringe update if it has periodic bitmap.
5741 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5742 and fringe_bitmap_periodic_p.
5744 * fringe.c (get_fringe_bitmap_data): New function.
5745 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5746 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5747 row. Mark glyph row for fringe update if periodicity changed.
5749 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5750 for fringe update unless it has periodic bitmap.
5752 2011-05-25 Kenichi Handa <handa@m17n.org>
5754 * xdisp.c (get_next_display_element): Set correct it->face_id for
5755 a static composition.
5757 2011-05-24 Leo Liu <sdl.web@gmail.com>
5760 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5762 * fns.c (crypto_hash_function, Fsha1): New function.
5763 (Fmd5): Use crypto_hash_function.
5764 (syms_of_fns): Add Ssha1.
5766 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5768 * gnutls.c: Remove unused macros.
5769 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5770 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5771 Remove macros that are defined and never used.
5772 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5774 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5776 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5777 (Fx_get_selection_internal): Minor cleanup.
5778 (Fx_own_selection_internal): Rename arguments for consistency with
5781 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5783 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5785 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5787 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5789 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5791 * dispnew.c (scrolling_window): Don't exclude the case that the
5792 last enabled row in the desired matrix touches the bottom boundary.
5794 2011-05-21 Glenn Morris <rgm@gnu.org>
5796 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5797 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5798 and add some more files.
5800 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5802 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5803 report_file_error introduced by the change from 2011-05-07.
5805 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5807 * systime.h (Time): Define only if emacs is defined.
5808 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5809 where the include path doesn't have X11/X.h by default. See
5810 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5812 2011-05-20 Kenichi Handa <handa@m17n.org>
5814 * composite.c (find_automatic_composition): Fix previous change.
5816 2011-05-20 Glenn Morris <rgm@gnu.org>
5818 * lisp.mk: New file, split from Makefile.in.
5819 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5820 (shortlisp): Remove.
5821 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5823 2011-05-19 Glenn Morris <rgm@gnu.org>
5825 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5826 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5827 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5828 (lisp): Set the order to that of loadup.el.
5829 (shortlisp): Make it a copy of $lisp.
5830 (SOME_MACHINE_LISP): Remove.
5831 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5832 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5834 2011-05-18 Kenichi Handa <handa@m17n.org>
5836 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5837 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5838 (find_automatic_composition): Mostly rewrite for efficiency.
5840 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5842 * makefile.w32-in: Update dependencies.
5844 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5846 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5847 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5849 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5851 Fix some integer overflow issues, such as string length overflow.
5853 * insdel.c (count_size_as_multibyte): Check for string overflow.
5855 * character.c (lisp_string_width): Check for string overflow.
5856 Use EMACS_INT, not int, for string indexes and lengths; in
5857 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5858 the resulting string length overflows an EMACS_INT; instead,
5859 report a string overflow if no precision given. When checking for
5860 precision exhaustion, use a check that cannot possibly have
5861 integer overflow. (Bug#8675)
5862 * character.h (lisp_string_width): Adjust to new signature.
5864 * alloc.c (string_overflow): New function.
5865 (Fmake_string): Use it. This doesn't change behavior, but saves
5866 a few bytes and will simplify future changes.
5867 * character.c (string_escape_byte8): Likewise.
5868 * lisp.h (string_overflow): New decl.
5870 Fixups, following up to the user-interface timestamp change.
5871 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5872 for UI timestamps, instead of unsigned long.
5873 * msdos.c (mouse_get_pos): Likewise.
5874 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5875 * w32gui.h (Time): Define by including "systime.h" rather than by
5876 declaring it ourselves. (Bug#8664)
5878 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5879 * image.c (clear_image_cache): Likewise.
5881 * term.c (term_mouse_position): Don't assume time_t wraparound.
5883 Be more systematic about user-interface timestamps.
5884 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5885 and sometimes 'EMACS_UINT', to represent these timestamps.
5886 This change causes it to use 'Time' uniformly, as that's what X uses.
5887 This makes the code easier to follow, and makes it easier to catch
5888 integer overflow bugs such as Bug#8664.
5889 * frame.c (Fmouse_position, Fmouse_pixel_position):
5890 Use Time, not unsigned long, for user-interface timestamps.
5891 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5892 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5893 * keyboard.h (last_event_timestamp): Likewise.
5894 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5895 * menu.h (xmenu_show): Likewise.
5896 * term.c (term_mouse_position): Likewise.
5897 * termhooks.h (struct input_event.timestamp): Likewise.
5898 (struct terminal.mouse_position_hook): Likewise.
5899 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5900 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5901 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5902 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5904 * menu.h, termhooks.h: Include "systime.h", for Time.
5906 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5907 Don't assume that the difference between two unsigned long values
5908 can fit into an integer. At this point, we know button_down_time
5909 <= event->timestamp, so the difference must be nonnegative, so
5910 there's no need to cast the result if double-click-time is
5911 nonnegative, as it should be; check that it's nonnegative, just in
5912 case. This bug is triggered when events are more than 2**31 ms
5913 apart (about 25 days). (Bug#8664)
5915 * xselect.c (last_event_timestamp): Remove duplicate decl.
5916 (x_own_selection): Remove needless cast to unsigned long.
5918 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5919 that always fit in int. Use a sentinel instead of a counter, to
5920 avoid a temp and to allay GCC's concerns about possible int overflow.
5921 * frame.h (struct frame): Use int for menu_bar_items_used
5922 instead of EMACS_INT, since it always fits in int.
5924 * menu.c (grow_menu_items): Check for int overflow.
5926 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5928 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5929 Before, the code was not consistent. These values cannot exceed
5930 2**31 - 1 so there's no need to make them unsigned.
5931 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5932 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5933 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5935 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5937 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5938 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5939 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5940 presumably because the widths might not match.
5942 * window.c (size_window): Avoid needless test at loop start.
5944 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5946 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5948 2011-05-12 Drew Adams <drew.adams@oracle.com>
5950 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5952 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5954 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5955 `width' to `bar_area_x' and `bar_area_width', respectively.
5956 (x_scroll_run): Take account of fringe background extension.
5958 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5959 Rename local vars `left' and `width' to `bar_area_x' and
5960 `bar_area_width', respectively.
5961 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5962 background extension.
5964 2011-05-10 Jim Meyering <meyering@redhat.com>
5966 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5968 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5970 * image.c (Finit_image_library): Return t for built-in image types,
5971 like pbm and xbm. (Bug#8640)
5973 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5975 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5977 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5979 * w32console.c (Fset_screen_color): Doc fix.
5980 (Fget_screen_color): New function.
5981 (syms_of_ntterm): Defsubr it.
5983 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5984 unlink the temporary file if Fcall_process didn't create it in the
5986 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5987 child process will be redirected to a file specified with `:file'.
5988 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5989 cue to call_process_cleanup not to close that handle.
5991 2011-05-07 Ben Key <bkey76@gmail.com>
5993 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5994 one of two shell specific rules, either bootstrap-temacs-CMD or
5995 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5996 to the previous implementation of the bootstrap-temacs rule.
5997 The bootstrap-temacs-CMD rule is similar to the previous
5998 implementation of the bootstrap-temacs rule except that it
5999 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6002 These changes, along with some changes to nt/configure.bat,
6003 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6004 earlier fix to add support for --cflags and --ldflags options
6005 that include quotes so that it works whether make uses cmd or
6008 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6010 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6011 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6013 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6014 a string. Handle both cases.
6015 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6016 (Fdbus_register_method): Use Qinvalid_function.
6018 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6020 * makefile.w32-in: Update dependencies.
6021 (LISP_H): Add inttypes.h and stdin.h.
6022 (PROCESS_H): Add unistd.h.
6024 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6026 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6027 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6029 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6031 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6033 * term.c (vfatal): Remove stray call to va_end.
6034 It's not needed and the C Standard doesn't allow it here anyway.
6036 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6037 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6039 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6042 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6044 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6046 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6048 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6050 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6052 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6053 * charset.c (Fdefine_charset_internal): Don't initialize
6054 charset.code_space[15]. The value was garbage, on hosts with
6055 32-bit int (Bug#8600).
6057 * lread.c (read_integer): Be more consistent with string-to-number.
6058 Use string_to_number to do the actual conversion; this avoids
6059 rounding errors and fixes some other screwups. Without this fix,
6060 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6061 (digit_to_number): Move earlier, for benefit of read_integer.
6062 Return -1 if the digit is out of range for the base, -2 if it is
6063 not a digit in any supported base. (Bug#8602)
6065 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6067 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6068 to match comment at start of function. This also removes a
6069 GCC warning about overflow in a 32+64-bit port.
6071 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6073 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6074 Reported by Stefan Monnier in
6075 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6076 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6077 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6079 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6080 (EMACS_UINTPTR): Likewise, with uintptr_t.
6082 * lisp.h: Prefer 64-bit EMACS_INT if available.
6083 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6084 on 32-bit hosts that have 64-bit int, so that they can access
6086 However, temporarily disable this change unless the temporary
6087 symbol WIDE_EMACS_INT is defined.
6089 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6091 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6092 This removes an assumption that EMACS_INT and long are the same
6093 width as pointers. The assumption is true for Emacs porting targets
6094 now, but we want to make other targets possible.
6095 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6096 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6097 In the rest of the code, change types of integers that hold casted
6098 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6099 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6100 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6101 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6102 No need to cast type when ORing.
6103 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6104 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6105 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6106 assume EMACS_INT is the same width as char *.
6107 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6108 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6109 Remove no-longer-needed casts.
6110 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6111 (xg_tool_bar_help_callback, xg_make_tool_item):
6112 Use EMACS_INTPTR to hold an integer
6113 that will be cast to void *; this can avoid a GCC warning
6114 if EMACS_INT is not the same width as void *.
6115 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6116 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6117 (current_message_1, set_message_1):
6118 Use a local to convert to proper width without a cast.
6119 * xmenu.c (dialog_selection_callback): Likewise.
6121 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6122 Also, don't assume VALBITS / RAND_BITS is less than 5,
6123 and don't rely on undefined behavior when shifting a 1 left into
6125 * lisp.h (get_random): Change signature to match.
6127 * lread.c (hash_string): Use size_t, not int, for hash computation.
6128 Normally we prefer signed values; but hashing is special, because
6129 it's better to use unsigned division on hash table sizes so that
6130 the remainder is nonnegative. Also, size_t is the natural width
6131 for hashing into memory. The previous code used 'int', which doesn't
6132 retain enough info to hash well into very large tables.
6133 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6135 * dbusbind.c: Don't possibly lose pointer info when converting.
6136 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6137 Use XPNTR rather than XHASH, so that the high-order bits of
6138 the pointer aren't lost when converting through void *.
6140 * eval.c (Fautoload): Don't double-shift a pointer.
6142 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6144 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6146 * gnutls.c (DEF_GNUTLS_FN):
6147 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6149 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6151 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6154 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6156 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6157 New version that can reserve upto 2GB of heap space.
6159 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6161 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6163 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6165 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6166 `gnutls_certificate_set_x509_key_file'.
6168 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6170 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6171 Update dependencies.
6173 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6175 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6176 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6177 Remove unused parameter `fildes'.
6178 * process.c (read_process_output, send_process): Don't pass it.
6180 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6182 Fix previous change: the library cache is defined in w32.c.
6183 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6184 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6186 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6188 Implement dynamic loading of GnuTLS on Windows.
6190 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6191 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6192 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6195 * gnutls.c (Qgnutls_dll): Define.
6196 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6197 (gnutls_*): Declare function pointers.
6198 (init_gnutls_functions): New function to initialize function pointers.
6199 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6200 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6201 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6202 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6203 (emacs_gnutls_write, emacs_gnutls_read)
6204 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6205 (Fgnutls_available_p): New function.
6206 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6207 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6208 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6210 * image.c: Include w32.h.
6211 (Vimage_type_cache): Delete.
6212 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6213 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6214 (w32_delayed_load): Move to w32.c.
6216 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6218 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6219 (w32_delayed_load): Move from image.c. When loading a library, record
6220 its filename in the :loaded-from property of the library id.
6221 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6222 Initialize and staticpro them.
6223 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6225 * process.c: Include lisp.h before w32.h, not after.
6226 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6227 instead of gnutls_record_check_pending.
6229 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6231 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6233 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6234 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6237 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6239 * xterm.c (x_set_frame_alpha): Do not set property on anything
6240 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6242 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6244 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6246 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6248 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6249 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6250 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6251 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6252 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6253 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6254 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6255 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6256 (Qgnutls_bootprop_callbacks_verify): Make static.
6258 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6260 * callproc.c: Indentation fixup.
6262 * sysdep.c (wait_for_termination_1): Make static.
6263 (wait_for_termination, interruptible_wait_for_termination):
6264 Move after wait_for_termination_1.
6266 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6268 * sysdep.c (interruptible_wait_for_termination): New function
6269 which is like wait_for_termination, but allows keyboard
6272 * callproc.c (Fcall_process): Add (:file "file") as an option for
6274 (Fcall_process_region): Ditto.
6276 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6278 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6279 rather than `XVECTOR (FOO)->size'.
6281 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6282 inttypes.h, as a gnulib replacement is used if it not available in
6285 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6287 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6288 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6289 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6291 * coding.c (coding_alloc_by_realloc): Error out if destination
6292 will grow beyond MOST_POSITIVE_FIXNUM.
6293 (decode_coding_emacs_mule): Abort if there isn't enough place in
6294 charbuf for the composition carryover bytes. Reserve an extra
6295 space for up to 2 characters produced in a loop.
6296 (decode_coding_iso_2022): Abort if there isn't enough place in
6297 charbuf for the composition carryover bytes.
6299 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6301 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6302 aborting when %lld or %lll format is passed.
6303 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6304 %llo or %llx format is passed. (Bug#8545)
6306 * window.c (window_scroll_line_based): Use a marker instead of
6307 simple variables to record original value of point. (Bug#7952)
6309 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6310 produced by %s or %c overflows available buffer space. (Bug#8545)
6312 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6314 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6315 (SIZE_MAX): Move defn after all includes, as they might #define it.
6317 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6319 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6321 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6323 * keyboard.c (Qdelayed_warnings_hook): Define.
6324 (command_loop_1): Run `delayed-warnings-hook'
6325 if Vdelayed_warnings_list is non-nil.
6326 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6327 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6329 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6331 * doprnt.c (doprnt): Don't return value smaller than the buffer
6332 size if the message was truncated. (Bug#8545).
6334 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6336 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6337 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6339 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6341 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6343 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6345 * makefile.w32-in: Update dependencies.
6347 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6349 Improve `doprnt' and its usage. (Bug#8545)
6350 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6351 `format_end'. Remove support for %l as a conversion specifier.
6352 Don't use xrealloc. Improve diagnostics when the %l size modifier
6353 is used. Update the commentary.
6355 * eval.c (verror): Simplify calculation of size_t.
6357 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6360 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6362 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6365 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6367 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6368 This makes this file independent of the recent pseudovector change.
6370 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6372 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6374 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6375 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6376 Remove unused local.
6377 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6379 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6380 GCC 4.6.0 optimizes based on type-based alias analysis.
6381 For example, if b is of type struct buffer * and v of type struct
6382 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6383 != &v->size, and therefore "v->size = 1; b->size = 2; return
6384 v->size;" must therefore return 1. This assumption is incorrect
6385 for Emacs, since it type-puns struct Lisp_Vector * with many other
6386 types. To fix this problem, this patch adds a new type struct
6387 vectorlike_header that documents the constraints on layout of vectors
6388 and pseudovectors, and helps optimizing compilers not get fooled
6389 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6390 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6391 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6393 (XSETPVECTYPE): Rewrite in terms of new macro.
6394 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6395 This is a bit clearer, and further avoids the possibility of
6396 undesirable aliasing.
6397 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6398 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6399 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6400 since Lisp_Subr is a special case (no "next" field).
6401 (ASIZE): Now uses header.size rather than size.
6402 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6403 to avoid the hassle of writing XVECTOR (foo)->header.size.
6404 (struct vectorlike_header): New type.
6405 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6406 object, to help avoid aliasing.
6407 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6408 (SUBRP): Likewise, since Lisp_Subr is a special case.
6409 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6410 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6411 (struct Lisp_Hash_Table): Combine first two members into a single
6412 struct vectorlike_header member. All uses of "size" and "next" members
6413 changed to be "header.size" and "header.next".
6414 * buffer.h (struct buffer): Likewise.
6415 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6416 * frame.h (struct frame): Likewise.
6417 * process.h (struct Lisp_Process): Likewise.
6418 * termhooks.h (struct terminal): Likewise.
6419 * window.c (struct save_window_data, struct saved_window): Likewise.
6420 * window.h (struct window): Likewise.
6421 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6422 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6423 * buffer.c (init_buffer_once): Likewise.
6424 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6426 * process.c (Fformat_network_address): Use local var for size,
6429 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6431 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6432 * data.c (atof): Remove decl; no longer used or needed.
6433 (digit_to_number): Move to lread.c.
6434 (Fstring_to_number): Use new string_to_number function, to be
6435 consistent with how the Lisp reader treats infinities and NaNs.
6436 Do not assume that floating-point numbers represent EMACS_INT
6437 without losing information; this is not true on most 64-bit hosts.
6438 Avoid double-rounding errors, by insisting on integers when
6439 parsing non-base-10 numbers, as the documentation specifies.
6440 * lisp.h (string_to_number): New decl, replacing ...
6441 (isfloat_string): Remove.
6442 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6443 (read1): Do not accept +. and -. as integers; this
6444 appears to have been a coding error. Similarly, do not accept
6445 strings like +-1e0 as floating point numbers. Do not report
6446 overflow for integer overflows unless the base is not 10 which
6447 means we have no simple and reliable way to continue.
6448 Break out the floating-point parsing into a new
6449 function string_to_number, so that Fstring_to_number parses
6450 floating point numbers consistently with the Lisp reader.
6451 (digit_to_number): Move here from data.c. Make it static inline.
6452 (E_CHAR, EXP_INT): Remove, replacing with ...
6453 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6454 (string_to_number): New function, replacing isfloat_string.
6455 This function checks for valid syntax and produces the resulting
6456 Lisp float number too. Rework it so that string-to-number
6457 no longer mishandles examples like "1.0e+". Use strtoumax,
6458 so that overflow for non-base-10 numbers is reported only when
6459 there's no portable and simple way to convert to floating point.
6461 * textprop.c (set_text_properties_1): Rewrite for clarity,
6462 and to avoid GCC warning about integer overflow.
6464 * intervals.h (struct interval): Use EMACS_INT for members
6465 where EMACS_UINT might cause problems. See
6466 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6467 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6468 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6470 (offset_intervals): Tell GCC not to worry about length overflow
6471 when negating a negative length.
6473 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6474 (overrun_check_free): Likewise.
6476 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6477 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6480 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6481 (gnutls_make_error): Rename local to avoid shadowing.
6482 (gnutls_emacs_global_deinit): ifdef out; not used.
6483 (Fgnutls_boot): Use const for pointer to readonly storage.
6484 Comment out unused local. Fix pointer signedness problems.
6486 * lread.c (openp): Don't stuff size_t into an 'int'.
6487 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6488 about possible signed overflow.
6490 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6491 (GDK_KEY_g): Don't define if already defined.
6492 (xg_prepare_tooltip): Avoid pointer signedness problem.
6493 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6495 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6496 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6498 * xfns.c (Fx_window_property): Simplify a bit,
6499 to make a bit faster and to avoid GCC 4.6.0 warning.
6500 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6502 * fns.c (internal_equal): Don't assume size_t fits in int.
6504 * alloc.c (compact_small_strings): Tighten assertion a little.
6506 Replace pEd with more-general pI, and fix some printf arg casts.
6507 * lisp.h (pI): New macro, generalizing old pEd macro to other
6508 conversion specifiers. For example, use "...%"pI"d..." rather
6509 than "...%"pEd"...".
6510 (pEd): Remove. All uses replaced with similar uses of pI.
6511 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6512 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6513 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6514 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6515 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6516 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6517 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6519 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6520 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6521 * print.c (safe_debug_print, print_object): Likewise.
6522 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6524 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6525 avoiding the 0 flag, which is not portable.
6526 * process.c (Fmake_network_process): Use pI to avoid cast.
6527 * region-cache.c (pp_cache): Likewise.
6528 * xdisp.c (decode_mode_spec): Likewise.
6529 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6530 behavior on 64-bit hosts with printf arg.
6531 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6532 (x_stop_queuing_selection_requests): Likewise.
6533 (x_get_window_property): Don't truncate byte count to an 'int'
6536 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6537 here, since it parses constructs like leading '-' and spaces,
6538 which are not wanted; and it overflows with large numbers.
6539 Instead, simply match F[0-9]+, which is what is wanted anyway.
6541 * alloc.c: Remove unportable assumptions about struct layout.
6542 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6543 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6544 (allocate_vectorlike, make_pure_vector): Use the new macros,
6545 plus offsetof, to remove unportable assumptions about struct layout.
6546 These assumptions hold on all porting targets that I know of, but
6547 they are not guaranteed, they're easy to remove, and removing them
6548 makes further changes easier.
6550 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6551 This doesn't fix a bug but makes the code clearer.
6552 (string_overrun_cookie): Now const. Use initializers that
6553 don't formally overflow signed char, to avoid warnings.
6554 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6555 can cause Emacs to crash when string overrun checking is enabled.
6556 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6557 multiple of sizeof (EMACS_INT); it need not be, if
6558 alignof(EMACS_INT) < sizeof (EMACS_INT).
6559 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6561 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6563 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6565 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6567 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6568 supposed to be handshaking. (Bug#8556)
6569 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6571 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6573 * lisp.h (Qdebug): List symbol.
6574 * eval.c (Qdebug): Restore global linkage.
6575 * keyboard.c (debug-on-event): New variable.
6576 (handle_user_signal): Break into debugger when debug-on-event
6577 matches the current signal symbol.
6579 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6581 * alloc.c (check_sblock, check_string_bytes)
6582 (check_string_free_list): Convert to standard C.
6584 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6586 * w32.c (emacs_gnutls_push): Fix typo.
6588 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6590 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6591 "cast to pointer from integer of different size".
6593 Improve doprnt and its use in verror. (Bug#8545)
6594 * doprnt.c (doprnt): Document the set of format control sequences
6595 supported by the function. Use SAFE_ALLOCA instead of always
6598 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6599 is one byte too soon. Don't use xrealloc; instead xfree and
6602 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6604 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6607 * gnutls.c: Renamed global_initialized to
6608 gnutls_global_initialized. Added internals for the
6609 :verify-hostname-error, :verify-error, and :verify-flags
6610 parameters of `gnutls-boot' and documented those parameters in the
6611 docstring. Start callback support.
6612 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6613 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6614 on error. Return error code.
6615 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6616 (emacs_gnutls_read): Likewise.
6617 (Fgnutls_boot): Return handshake error code.
6618 (emacs_gnutls_handle_error): New function.
6619 (wsaerror_to_errno): Likewise.
6621 * w32.h (emacs_gnutls_pull): Add prototype.
6622 (emacs_gnutls_push): Likewise.
6624 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6625 (emacs_gnutls_push): Likewise.
6627 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6629 * process.c (wait_reading_process_output): Check if GnuTLS
6630 buffered some data internally if no FDs are set for TLS
6633 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6634 (LIBS): Link to USER_LIBS.
6635 ($(BLD)/gnutls.$(0)): New target.
6637 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6639 * xdisp.c (handle_single_display_spec): Rename the
6640 display_replaced_before_p argument into display_replaced_p, to
6641 make it consistent with the commentary. Fix typos in the
6644 * textprop.c (syms_of_textprop): Remove dead code.
6645 (copy_text_properties): Delete obsolete commentary about an
6646 interface that was deleted long ago. Fix typos in the description
6649 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6650 to changes in oldXMenu/XMenu.h from 2011-04-16.
6651 <menu_help_message, prev_menu_help_message>: Constify.
6652 (IT_menu_make_room): menu->help_text is now `const char **';
6655 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6656 to changes in oldXMenu/XMenu.h from 2011-04-16.
6657 (struct XMenu): Declare `help_text' `const char **'.
6659 * xfaces.c <Qunspecified>: Make extern again.
6661 * syntax.c: Include sys/types.h before including regex.h, as
6664 * doc.c (get_doc_string): Improve the format passed to `error'.
6666 * doprnt.c (doprnt): Improve commentary.
6668 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6670 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6673 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6674 changes in globals.h immediately force recompilation.
6675 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6676 $(CURDIR)/s/ms-w32.h.
6677 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6679 * character.c (Fchar_direction): Function deleted.
6680 (syms_of_character): Don't defsubr it.
6681 <char-direction-table>: Deleted.
6683 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6685 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6686 * doprnt.c: Include limits.h.
6687 (SIZE_MAX): New macro.
6688 (doprnt): Return a size_t value. 2nd arg is now size_t.
6689 Many local variables are now size_t instead of int or unsigned.
6690 Improve overflow protection. Support `l' modifier for integer
6691 conversions. Support %l conversion. Don't assume an EMACS_INT
6692 argument for integer conversions and for %c.
6694 * lisp.h (doprnt): Restore prototype.
6696 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6699 * Makefile.in (base_obj): Add back doprnt.o.
6701 * deps.mk (doprnt.o): Add back prerequisites.
6702 (callint.o): Depend on character.h.
6704 * eval.c (internal_lisp_condition_case): Include the handler
6705 representation in the error message.
6706 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6707 when breaking from the loop.
6709 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6711 * callint.c (Fcall_interactively): When displaying error message
6712 about invalid control letter, pass the character's codepoint, not
6713 a pointer to its multibyte form. Improve display of the character
6714 in octal and display also its hex code.
6716 * character.c (char_string): Use %x to display the (unsigned)
6717 codepoint of an invalid character, to avoid displaying a bogus
6720 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6721 `error', not SYMBOL_NAME itself.
6723 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6724 character arguments to `error'.
6726 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6727 to `error' in error message about FINAL_CHAR argument. Make sure
6728 FINAL_CHAR is a character, and use %c when it is passed as
6729 argument to `error'.
6731 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6733 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6735 * w32.c: Include <time.h>.
6736 (sys_localtime): New function.
6738 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6740 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6742 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6744 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6746 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6749 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6751 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6752 gl_state.e_property when gl_state.object is Qt.
6754 * insdel.c (make_gap_larger): Remove limitation of buffer size
6757 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6759 * xdisp.c (lookup_glyphless_char_display)
6760 (produce_glyphless_glyph): Handle cons cell entry in
6761 glyphless-char-display.
6762 (Vglyphless_char_display): Document it.
6764 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6765 glyphless-char-display.
6767 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6769 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6771 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6773 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6774 definition for no-X builds.
6776 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6778 Static checks with GCC 4.6.0 and non-default toolkits.
6780 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6782 * process.c (keyboard_bit_set): Define only if SIGIO.
6783 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6784 (send_process): Repair possible setjmp clobbering.
6786 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6788 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6790 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6792 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6793 Define only if needed.
6795 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6796 by pacifying GCC about it. Maybe it's time to retire it?
6797 * xfaces.c (USG, __TIMEVAL__): Likewise.
6799 * dispextern.h (struct redisplay_interface): Rename param
6801 * termhooks.h (struct terminal): Likewise.
6802 * xterm.c (xembed_send_message): Likewise.
6804 * insdel.c (make_gap_smaller): Define only if
6805 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6807 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6810 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6811 so that we aren't warned about unused symbols.
6813 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6815 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6817 * xfns.c (x_real_positions): Mark locals as initialized.
6819 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6821 * xterm.c: Fix problems found by static analysis with other toolkits.
6822 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6823 (x_dispatch_event): Declare static if USE_GTK, and
6824 define if USE_GTK || USE_X_TOOLKIT.
6825 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6826 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6827 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6828 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6830 * xmenu.c (menu_help_callback): Pointer type fixes.
6831 Use const pointers when pointing at readonly data. Avoid pointer
6833 (FALSE): Remove unused macro.
6834 (update_frame_menubar): Remove unused decl.
6836 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6838 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6839 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6840 (single_menu_item): Rename local to avoid shadowing.
6842 * keyboard.c (make_lispy_event): Remove unused local var.
6844 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6845 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6847 * bitmaps: Change bitmaps from unsigned char back to the X11
6848 compatible char. Avoid the old compiler warnings about
6849 out-of-range initializers by using, for example, '\xab' rather
6852 * xgselect.c (xgselect_initialize): Check vs interface
6853 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6855 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6857 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6858 to read-only memory.
6860 * fns.c (vector): Remove; this old hack is no longer needed.
6862 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6864 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6866 * xrdb.c (x_load_resources): Omit unused local.
6868 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6869 (x_window): Rename locals to avoid shadowing.
6870 (USG): Use the kludged USG macro, to pacify gcc.
6872 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6873 (x_term_init): Remove local to avoid shadowing.
6875 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6877 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6878 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6880 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6882 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6884 Fix regex.c, syntax.c and friends for buffers > 2GB.
6885 * syntax.h (struct gl_state_s): Declare character position members
6888 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6890 * textprop.c (verify_interval_modification, interval_of):
6891 Declare arguments EMACS_INT.
6893 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6896 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6898 * indent.c (Fvertical_motion): Local variable it_start is now
6901 * regex.c (re_match, re_match_2, re_match_2_internal)
6902 (bcmp_translate, regcomp, regexec, print_double_string)
6903 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6904 (re_compile_pattern, re_exec): Declare arguments and local
6905 variables `size_t' and `ssize_t' and return values `regoff_t', as
6907 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6908 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6909 <compile_stack_type>: `size' and `avail' are now `size_t'.
6911 * regex.h <regoff_t>: Use ssize_t, not int.
6912 (re_search, re_search_2, re_match, re_match_2): Arguments that
6913 specify buffer/string position and length are now ssize_t and
6914 size_t. Return type is regoff_t.
6916 2011-04-16 Ben Key <bkey76@gmail.com>
6918 * nsfont.m: Fixed bugs in ns_get_family and
6919 ns_descriptor_to_entity that were caused by using free to
6920 deallocate memory blocks that were allocated by xmalloc (via
6921 xstrdup). This caused Emacs to crash when compiled with
6922 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6923 --enable-checking=xmallocoverrun). xfree is now used to
6924 deallocate these memory blocks.
6926 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6928 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6930 emacs_write: Accept and return EMACS_INT for sizes.
6931 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6933 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6934 Accept and return EMACS_INT.
6935 (emacs_gnutls_write): Return the number of bytes written on
6937 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6938 (emacs_read, emacs_write): Remove check for negative size, as the
6939 Emacs source code has been audited now.
6940 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6941 (emacs_read, emacs_write): Use it.
6942 * process.c (send_process): Adjust to the new signatures of
6943 emacs_write and emacs_gnutls_write. Do not attempt to store
6944 a byte offset into an 'int'; it might overflow.
6945 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6947 * sound.c: Don't assume sizes fit in 'int'.
6948 (struct sound_device.period_size, alsa_period_size):
6949 Return EMACS_INT, not int.
6950 (struct sound_device.write, vox_write, alsa_write):
6951 Accept EMACS_INT, not int.
6952 (wav_play, au_play): Use EMACS_INT to store sizes and to
6953 record read return values.
6955 2011-04-15 Ben Key <bkey76@gmail.com>
6957 * keyboard.c (Qundefined): Don't declare static since it is used
6959 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6960 static since they are used in nsfont.m.
6962 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6964 * process.c (Qprocessp): Don't declare static.
6965 * lisp.h (Qprocessp): Declare again.
6967 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6969 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6971 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6973 Improve C-level modularity by making more things 'static'.
6975 Don't publish debugger-only interfaces to other modules.
6976 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6977 (verify_bytepos, count_markers): Move decls to the only modules
6979 * region-cache.h (pp_cache): Likewise.
6980 * window.h (check_all_windows): Likewise.
6981 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6983 * sysdep.c (croak): Now static, if
6984 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6985 * syssignal.h (croak): Declare only if not static.
6987 * alloc.c (refill_memory_reserve): Now static if
6988 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6989 * lisp.h (refill_memory_reserve): Declare only if not static.
6991 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6992 Define only if USE_LUCID.
6994 * xrdb.c (x_customization_string, x_rm_string): Now static.
6996 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6997 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6999 * xdisp.c (draw_row_with_mouse_face): Now static.
7000 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7002 * window.h (check_all_windows): Mark externally visible.
7004 * window.c (window_deletion_count): Now static.
7006 * undo.c: Make symbols static if they're not exported.
7007 (last_undo_buffer, last_boundary_position, pending_boundary):
7010 * textprop.c (interval_insert_behind_hooks): Now static.
7011 (interval_insert_in_front_hooks): Likewise.
7013 * term.c: Make symbols static if they're not exported.
7014 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7015 (max_frame_lines, tty_set_terminal_modes):
7016 (tty_reset_terminal_modes, tty_turn_off_highlight):
7017 (get_tty_terminal): Now static.
7018 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7019 * termhooks.h (term_mouse_moveto): Do not declare if
7021 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7022 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7024 * sysdep.c: Make symbols static if they're not exported.
7025 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7027 (sigprocmask_set, full_mask): Remove; unused.
7028 (wait_debugging): Mark as visible.
7029 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7030 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7032 * syntax.c (syntax_temp): Define only if !__GNUC__.
7034 * sound.c (current_sound_device, current_sound): Now static.
7036 * search.c (searchbufs, searchbuf_head): Now static.
7038 * scroll.c (scroll_cost): Remove; unused.
7039 * dispextern.h (scroll_cost): Remove decl.
7041 * region-cache.h (pp_cache): Mark as externally visible.
7043 * process.c: Make symbols static if they're not exported.
7044 (process_tick, update_tick, create_process, chan_process):
7045 (Vprocess_alist, proc_buffered_char, datagram_access):
7046 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7047 (deactivate_process): Mark defn as static, as well as decl.
7048 * lisp.h (create_process): Remove decl.
7049 * process.h (chan_process, Vprocess_alist): Remove decls.
7051 * print.c: Make symbols static if they're not exported.
7052 (print_depth, new_backquote_output, being_printed, print_buffer):
7053 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7054 (print_interval, print_number_index, initial_stderr_stream):
7056 * lisp.h (Fprinc): Remove decl.
7057 (debug_output_compilation_hack): Mark as externally visible.
7059 * sysdep.c (croak): Move decl from here to syssignal.h.
7060 * syssignal.h (croak): Put it here, so the API can be checked when
7061 'croak' is called from dissociate_if_controlling_tty.
7063 * minibuf.c: Make symbols static if they're not exported.
7064 (minibuf_save_list, choose_minibuf_frame): Now static.
7065 * lisp.h (choose_minibuf_frame): Remove decl.
7067 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7069 * lread.c: Make symbols static if they're not exported.
7070 (read_objects, initial_obarray, oblookup_last_bucket_number):
7072 (make_symbol): Remove; unused.
7073 * lisp.h (initial_obarray, make_symbol): Remove decls.
7075 * keyboard.c: Make symbols static if they're not exported.
7076 (single_kboard, recent_keys_index, total_keys, recent_keys):
7077 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7078 (this_single_command_key_start, echoing, last_auto_save):
7079 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7080 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7081 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7082 (Vlispy_mouse_stem, double_click_count):
7084 (force_auto_save_soon): Define only if SIGDANGER.
7085 (ignore_mouse_drag_p): Now static if
7086 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7087 (print_help): Remove; unused.
7088 (stop_character, last_timer_event): Mark as externally visible.
7089 * keyboard.h (ignore_mouse_drag_p): Declare only if
7090 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7091 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7092 * lisp.h (echoing): Remove decl.
7093 (force_auto_save_soon): Declare only if SIGDANGER.
7094 * xdisp.c (redisplay_window): Simplify code, to make it more
7095 obvious that ignore_mouse_drag_p is not accessed if !defined
7096 USE_GTK && !defined HAVE_NS.
7098 * intervals.c: Make symbols static if they're not exported.
7099 (merge_properties_sticky, merge_interval_right, delete_interval):
7101 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7103 * insdel.c: Make symbols static if they're not exported.
7104 However, leave prepare_to_modify_buffer alone. It's never
7105 called from outside this function, but that appears to be a bug.
7106 (combine_after_change_list, combine_after_change_buffer):
7107 (adjust_after_replace, signal_before_change): Now static.
7108 (adjust_after_replace_noundo): Remove; unused.
7109 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7110 (signal_before_change): Remove decls.
7112 * indent.c (val_compute_motion, val_vmotion): Now static.
7114 * image.c: Make symbols static if they're not exported.
7115 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7117 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7118 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7120 * fringe.c (standard_bitmaps): Now static.
7121 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7123 * frame.c: Make symbols static if they're not exported.
7124 (x_report_frame_params, make_terminal_frame): Now static.
7125 (get_frame_param): Now static, unless HAVE_NS.
7126 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7127 (x_get_resource_string): Remove; not used.
7128 * frame.h (make_terminal_frame, x_report_frame_params):
7129 (x_get_resource_string); Remove decls.
7130 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7131 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7133 * font.c, fontset.c: Make symbols static if they're not exported.
7134 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7135 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7136 * font.c (font_close_object): Now static.
7137 * font.h (font_close_object): Remove.
7138 * fontset.c (FONTSET_OBJLIST): Remove.
7139 (free_realized_fontset) #if-0 the body, which does nothing.
7140 (face_suitable_for_char_p): #if-0, as it's never called.
7141 * fontset.h (face_suitable_for_char_p): Remove decl.
7142 * xfaces.c (face_at_string_position):
7143 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7144 since 0 is always ASCII.
7146 * fns.c (weak_hash_tables): Now static.
7148 * fileio.c: Make symbols static if they're not exported.
7149 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7150 (Vwrite_region_annotation_buffers): Now static.
7152 * eval.c: Make symbols static if they're not exported.
7153 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7154 * lisp.h (backtrace_list): Remove decl.
7156 * emacs.c: Make symbols static if they're not exported.
7157 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7158 (fatal_error_code, fatal_error_signal_hook, standard_args):
7160 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7161 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7162 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7163 * lisp.h (fatal_error_signal_hook): Remove decl.
7164 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7166 * editfns.c: Move a (normally-unused) function to its only use.
7167 * editfns.c, lisp.h (get_operating_system_release): Remove.
7168 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7169 worth the hassle of breaking this out.
7171 * xterm.c: Make symbols static if they're not exported.
7172 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7173 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7174 (x_destroy_window, x_delete_display):
7176 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7177 (x_mouse_leave): Remove; unused.
7178 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7179 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7180 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7182 (x_mouse_leave): Declare only if WINDOWSNT.
7183 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7184 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7187 * ftxfont.c: Make symbols static if they're not exported.
7188 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7190 * font.h (ftxfont_driver): Likewise.
7192 * xfns.c: Make symbols static if they're not exported.
7193 (x_last_font_name, x_display_info_for_name):
7194 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7195 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7196 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7197 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7198 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7199 (last_show_tip_args): Now static.
7200 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7201 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7202 (x_screen_planes): Remove; unused.
7203 * dispextern.h (x_screen_planes): Remove decl.
7205 * dispnew.c: Make symbols static if they're not exported.
7206 * dispextern.h (redraw_garbaged_frames, scrolling):
7207 (increment_row_positions): Remove.
7208 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7209 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7211 (redraw_garbaged_frames): Remove; unused.
7213 * xfaces.c: Make symbols static if they're not exported.
7214 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7216 * xterm.h (defined_color): Remove decls.
7217 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7218 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7219 (menu_face_changed_default, defined_color, free_realized_face):
7220 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7221 (ascii_face_of_lisp_face): Remove; unused.
7223 * xdisp.c: Make symbols static if they're not exported.
7224 * dispextern.h (scratch_glyph_row, window_box_edges):
7225 (glyph_to_pixel_coords, set_cursor_from_row):
7226 (get_next_display_element, set_iterator_to_next):
7227 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7228 (show_mouse_face): Remove decls
7229 * frame.h (message_buf_print): Likewise.
7230 * lisp.h (pop_message, set_message, check_point_in_composition):
7232 * xterm.h (set_vertical_scroll_bar): Likewise.
7233 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7234 (message_buf_print, scratch_glyph_row, displayed_buffer):
7235 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7236 (get_next_display_element, show_mouse_face, window_box_edges):
7237 (frame_to_window_pixel_xy, check_point_in_composition):
7238 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7239 (glyph_to_pixel_coords): Remove; unused.
7241 * dired.c (file_name_completion): Now static.
7243 * dbusbind.c (xd_in_read_queued_messages): Now static.
7245 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7246 * data.c (circular_list_error): Remove.
7248 * commands.h (last_point_position, last_point_position_buffer):
7249 (last_point_position_window): Remove decls.
7250 * keyboard.c: Make these variables static.
7252 * coding.h (coding, code_convert_region, encode_coding_gap):
7254 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7255 (iso_code_class, detect_coding, code_convert_region): Now static.
7256 (encode_coding_gap): Remove; unused.
7258 * chartab.c (chartab_chars, chartab_bits): Now static.
7260 * charset.h (charset_iso_8859_1): Remove decl.
7261 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7264 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7265 * ccl.c (Vccl_program_table): Now static.
7266 (check_ccl_update): Remove; unused.
7268 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7269 * category.h: ... from here.
7270 * category.c (check_category_table, set_category_set): Now static.
7272 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7273 * lisp.h: Remove these decls.
7275 * buffer.c (buffer_count): Remove unused var.
7277 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7278 so that it's not optimized away.
7279 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7280 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7281 exported only to the debugger.
7283 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7284 * atimer.h (run_all_atimers): Remove; not exported.
7286 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7287 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7288 was inaccessible from Lisp.
7289 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7290 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7292 alloc.c: Import and export fewer symbols, and remove unused items.
7293 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7295 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7296 it's not optimized away by whole-program optimization.
7297 (message_enable_multibyte, free_misc): Remove.
7298 (catchlist, handlerlist, mark_backtrace):
7299 Declare only if BYTE_MARK_STACK.
7300 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7301 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7302 (message_enable_multibyte): Remove decl.
7303 (free_misc, interval_free_list, float_block, float_block_index):
7304 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7305 (cons_free_list, last_marked_index):
7307 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7308 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7309 (mark_backtrace): Define only if BYTE_MARK_STACK.
7310 * xdisp.c (message_enable_multibyte): Now static.
7312 Declare Lisp_Object Q* variables to be 'static' if not exported.
7313 This makes it easier for human readers (and static analyzers)
7314 to see whether these variables are used from other modules.
7315 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7316 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7317 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7318 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7319 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7320 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7321 * xmenu.c, xselect.c:
7322 Declare Q* vars static if they are not used in other modules.
7323 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7324 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7325 Remove decls of unexported vars.
7326 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7328 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7330 Make Emacs functions such as Fatom 'static' by default.
7331 This makes it easier for human readers (and static analyzers)
7332 to see whether these functions can be called from other modules.
7333 DEFUN now defines a static function. To make the function external
7334 so that it can be used in other C modules, use the new macro DEFUE.
7335 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7336 (Finit_image_library):
7337 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7338 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7339 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7340 Remove decls, since these functions are now static.
7341 (Funintern, Fget_internal_run_time): New decls, since these functions
7342 were already external.
7344 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7345 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7346 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7347 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7348 * keyboard.c, keymap.c, lread.c:
7349 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7350 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7351 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7352 Mark functions with DEFUE instead of DEFUN,
7353 if they are used in other modules.
7354 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7355 decls for now-static functions.
7356 * buffer.h (Fdelete_overlay): Remove decl.
7357 * callproc.c (Fgetenv_internal): Mark as internal.
7358 * composite.c (Fremove_list_of_text_properties): Remove decl.
7359 (Fcomposition_get_gstring): New forward static decl.
7360 * composite.h (Fcomposite_get_gstring): Remove decl.
7361 * dired.c (Ffile_attributes): New forward static decl.
7362 * doc.c (Fdocumntation_property): New forward static decl.
7363 * eval.c (Ffetch_bytecode): New forward static decl.
7364 (Funintern): Remove extern decl; now in .h file where it belongs.
7365 * fileio.c (Fmake_symbolic_link): New forward static decl.
7366 * image.c (Finit_image_library): New forward static decl.
7367 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7368 * intervals.h (Fprevious_property_change):
7369 (Fremove_list_of_text_properties): Remove decls.
7370 * keyboard.c (Fthis_command_keys): Remove decl.
7371 (Fcommand_execute): New forward static decl.
7372 * keymap.c (Flookup_key): New forward static decl.
7373 (Fcopy_keymap): Now static.
7374 * keymap.h (Flookup_key): Remove decl.
7375 * process.c (Fget_process): New forward static decl.
7376 (Fprocess_datagram_address): Mark as internal.
7377 * syntax.c (Fsyntax_table_p): New forward static decl.
7378 (skip_chars): Remove duplicate decl.
7379 * textprop.c (Fprevious_property_change): New forward static decl.
7380 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7382 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7383 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7385 * editfns.c (Fformat): Remove unreachable code.
7387 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7389 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7392 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7394 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7395 when at ZV. (Bug#8487)
7397 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7399 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7401 * keyboard.c (parse_tool_bar_item): Likewise.
7402 * sound.c (sound_cleanup, alsa_close): Likewise.
7403 * termcap.c (tgetent): Likewise.
7404 * xfns.c (x_default_font_parameter): Likewise.
7405 * xsettings.c (read_and_apply_settings): Likewise.
7407 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7408 (overrun_check_free): Protoize.
7410 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7412 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7413 since callers should never pass a negative size.
7414 Change the signature to match that of plain 'read' and 'write'; see
7415 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7416 * lisp.h: Update prototypes of emacs_write and emacs_read.
7418 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7420 * xdisp.c (redisplay_window): Don't try to determine the character
7421 position of the scroll margin if the window start point w->startp
7422 is outside the buffer's accessible region. (Bug#8468)
7424 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7426 Fix write-region and its subroutines for buffers > 2GB.
7427 * fileio.c (a_write, e_write): Modify declaration of arguments and
7428 local variables to support buffers larger than 2GB.
7429 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7431 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7432 argument, local variables, and return value.
7434 * lisp.h: Update prototypes of emacs_write and emacs_read.
7436 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7438 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7440 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7442 Fix more problems found by GCC 4.6.0's static checks.
7444 * xdisp.c (vmessage): Use a better test for character truncation.
7446 * charset.c (load_charset_map): <, not <=, for optimization,
7447 and to avoid potential problems with integer overflow.
7448 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7449 * casetab.c (set_identity, shuffle): Likewise.
7450 * editfns.c (Fformat): Likewise.
7451 * syntax.c (skip_chars): Likewise.
7453 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7454 This also lets GCC 4.6.0 generate slightly better loop code.
7456 * callint.c (Fcall_interactively): <, not <=, for optimization.
7457 (Fcall_interactively): Count the number of arguments produced,
7458 not the number of arguments given. This is simpler and lets GCC
7459 4.6.0 generate slightly better code.
7461 * ftfont.c: Distingish more carefully between FcChar8 and char.
7462 The previous code passed unsigned char * to a functions like
7463 strlen and xstrcasecmp that expect char *, which does not
7464 conform to the C standard.
7465 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7466 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7467 char * when the C standard requires it.
7469 * keyboard.c (read_char): Remove unused var.
7471 * eval.c: Port to Windows vsnprintf (Bug#8435).
7473 (SIZE_MAX): Define if the headers do not.
7474 (verror): Do not give up if vsnprintf returns a negative count.
7475 Instead, grow the buffer. This ports to Windows vsnprintf, which
7476 does not conform to C99. Problem reported by Eli Zaretskii.
7477 Also, simplify the allocation scheme, by avoiding the need for
7478 calling realloc, and removing the ALLOCATED variable.
7480 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7482 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7483 But keep the doprint source code for now, as we might revamp it
7484 and use it again (Bug#8435).
7485 * lisp.h (doprnt): Remove.
7486 * Makefile.in (base_obj): Remove doprnt.o.
7487 * deps.mk (doprnt.o): Remove.
7489 error: Print 32- and 64-bit integers portably (Bug#8435).
7490 Without this change, on typical 64-bit hosts error ("...%d...", N)
7491 was used to print both 32- and 64-bit integers N, which relied on
7493 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7495 * lisp.h (error, verror): Mark as printf-like functions.
7496 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7497 Report overflow in size calculations when allocating printf buffer.
7498 Do not truncate output string at its first null byte.
7499 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7500 Truncate the output at a character boundary, since vsnprintf does not
7502 * charset.c (check_iso_charset_parameter): Convert internal
7503 character to string before calling 'error', since %c now has the
7505 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7506 overflow when computing char to be passed to 'error'. Do not
7507 pass Lisp_Object to 'error'; pass the integer instead.
7508 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7509 formatted with plain %d.
7511 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7513 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7515 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7517 * xterm.c (x_catch_errors): Remove duplicate declaration.
7519 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7521 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7523 2011-04-10 Jim Meyering <meyering@redhat.com>
7525 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7526 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7527 return ssize_t not "int", and use size_t as the buffer length.
7528 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7529 * gnutls.h: Update declarations.
7530 * process.c (read_process_output): Use ssize_t, to match.
7531 (send_process): Likewise.
7533 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7535 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7537 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7539 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7540 Use unsigned char, to match FcChar8 type definition.
7542 * xterm.c (handle_one_xevent):
7543 * xmenu.c (create_and_show_popup_menu):
7544 * xselect.c (x_decline_selection_request)
7545 (x_reply_selection_request): Avoid type-punned deref of X events.
7547 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7549 Fix some uses of `int' instead of EMACS_INT.
7550 * search.c (string_match_1, fast_string_match)
7551 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7552 (scan_buffer, find_next_newline_no_quit)
7553 (find_before_next_newline, search_command, Freplace_match)
7554 (Fmatch_data): Make some `int' variables be EMACS_INT.
7556 * xdisp.c (display_count_lines): 3rd argument and return value now
7557 EMACS_INT. All callers changed.
7558 (pint2hrstr): Last argument is now EMACS_INT.
7560 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7561 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7562 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7563 (decode_coding_utf_16, decode_coding_emacs_mule)
7564 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7565 (decode_coding_ccl, decode_coding_charset)
7566 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7567 (decode_coding_iso_2022, decode_coding_emacs_mule)
7568 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7569 <char_offset, last_offset>: Declare EMACS_INT.
7570 (encode_coding_utf_8, encode_coding_utf_16)
7571 (encode_coding_emacs_mule, encode_invocation_designation)
7572 (encode_designation_at_bol, encode_coding_iso_2022)
7573 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7574 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7576 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7577 (encode_invocation_designation): Last argument P_NCHARS is now
7579 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7580 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7582 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7585 * ccl.c (Fccl_execute_on_string): Declare some variables
7588 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7590 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7592 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7594 * process.c (Fformat_network_address): Doc fix.
7596 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7598 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7600 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7602 * keyboard.c (read_char): Call Lisp function help-form-show,
7603 instead of using internal_with_output_to_temp_buffer.
7604 (Qhelp_form_show): New var.
7605 (syms_of_keyboard): Use DEFSYM macro.
7607 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7609 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7611 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7613 * process.c (Flist_processes): Remove to Lisp.
7614 (list_processes_1): Delete.
7616 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7618 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7620 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7622 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7624 Fix more problems found by GCC 4.6.0's static checks.
7626 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7628 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7630 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7632 * xdisp.c (vmessage): Mark as a printf-like function.
7634 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7636 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7638 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7639 printf-like functions.
7640 (tiff_load): Add casts to remove these marks before passing them
7641 to system-supplied API.
7643 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7645 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7646 This avoids several warnings with gcc -Wstrict-overflow.
7647 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7648 directly, rather than having caller test rule sign. This avoids
7649 some unnecessary tests.
7650 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7651 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7652 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7654 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7655 (xfont_open): Avoid unnecessary tests.
7657 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7659 * composite.h, composite.c (composition_gstring_put_cache):
7660 Use EMACS_INT, not int, for length.
7662 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7663 breaking out part of COMPOSITION_DECODE_RULE.
7664 (COMPOSITION_DECODE_RULE): Use it.
7665 * composite.c (get_composition_id): Remove unused local vars,
7666 by using the new macro.
7668 * textprop.c (set_text_properties_1): Change while to do-while,
7669 since the condition is always true at first.
7671 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7672 (interval_deletion_adjustment): Return unsigned value.
7675 * process.c (list_processes_1, create_pty, read_process_output):
7676 (exec_sentinel): Remove vars that were set but not used.
7677 (create_pty): Remove unnecessary "volatile"s.
7678 (Fnetwork_interface_info): Avoid possibility of int overflow.
7679 (read_process_output): Do adaptive read buffering even if carryover.
7680 (read_process_output): Simplify nbytes computation if buffered.
7682 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7684 * syntax.c (scan_words): Remove var that was set but not used.
7685 (update_syntax_table): Use unsigned instead of int.
7687 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7688 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7689 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7691 * print.c (print_error_message): Avoid int overflow.
7693 * font.c (font_list_entities): Redo for clarity,
7694 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7696 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7697 (font_score): Avoid potential overflow in diff calculation.
7699 * fns.c (substring_both): Remove var that is set but not used.
7700 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7702 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7704 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7705 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7706 can always succeed if overflow has undefined behavior.
7708 * search.c (boyer_moore, wordify): Remove vars set but not used.
7709 (wordify): Omit three unnecessary tests.
7711 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7712 All callers changed. This avoids the need for an unused var.
7714 * casefiddle.c (casify_region): Remove var that is set but not used.
7716 * dired.c (file_name_completion): Remove var that is set but not used.
7718 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7720 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7721 (Finsert_file_contents): Remove unnecessary code checking fd.
7723 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7724 Check for integer overflow on size calculations.
7726 * buffer.c (Fprevious_overlay_change): Remove var that is set
7729 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7730 Remove vars that are set but not used.
7731 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7732 (timer_check_2): Mark vars as initialized.
7734 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7736 * image.c (lookup_image): Remove var that is set but not used.
7737 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7739 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7740 that are set but not used.
7742 * xfns.c (make_invisible_cursor): Don't return garbage
7743 if XCreateBitmapFromData fails (Bug#8410).
7745 * xselect.c (x_get_local_selection, x_handle_property_notify):
7746 Remove vars that are set but not used.
7748 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7749 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7751 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7752 Remove var that is set but not used.
7753 (scroll_bar_windows_size): Now size_t, not int.
7754 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7757 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7758 (map_tty_color) [!defined MSDOS]: Likewise.
7760 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7762 * coding.c: Remove vars that are set but not used.
7763 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7764 All callers changed.
7765 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7766 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7767 (decode_coding_charset): Remove vars that are set but not used.
7769 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7770 that is set but not used.
7772 * print.c (print_object): Remove var that is set but not used.
7774 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7775 The gnulib version avoids calling malloc in the usual case,
7776 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7777 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7778 * filelock.c (current_lock_owner): Likewise.
7779 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7780 * sysdep.c: Include allocator.h, careadlinkat.h.
7781 (emacs_no_realloc_allocator): New static constant.
7782 (emacs_readlink): New function.
7783 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7784 ../lib/careadlinkat.h.
7786 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7788 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7789 first non-nil return value).
7791 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7793 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7794 if not defined (Bug#8403).
7796 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7798 * xdisp.c (display_count_lines): Remove parameter `start',
7799 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7800 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7801 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7802 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7803 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7804 and thereabouts. All callers changed.
7805 (get_per_char_metric): Remove parameter `f', unused since
7806 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7808 2011-04-02 Jim Meyering <meyering@redhat.com>
7810 do not dereference NULL upon failed strdup
7811 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7812 (ns_get_family): Likewise.
7814 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7816 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7818 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7820 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7823 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7825 Add lexical binding.
7827 * window.c (Ftemp_output_buffer_show): New fun.
7828 (Fsave_window_excursion):
7829 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7831 * lread.c (lisp_file_lexically_bound_p): New function.
7832 (Fload): Bind Qlexical_binding.
7833 (readevalloop): Remove `evalfun' arg.
7834 Bind Qinternal_interpreter_environment.
7835 (Feval_buffer): Bind Qlexical_binding.
7836 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7838 (syms_of_lread): Declare `lexical-binding'.
7840 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7842 * keyboard.c (eval_dyn): New fun.
7843 (menu_item_eval_property): Use it.
7845 * image.c (parse_image_spec): Use Ffunctionp.
7847 * fns.c (concat, mapcar1): Accept byte-code-functions.
7849 * eval.c (Fsetq): Handle lexical vars.
7850 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7851 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7852 (FletX, Flet): Obey lexical binding.
7853 (Fcommandp): Handle closures.
7854 (Feval): New `lexical' arg.
7855 (eval_sub): New function extracted from Feval. Use it almost
7856 everywhere where Feval was used. Look up vars in lexical env.
7858 (Ffunctionp): Move from subr.el.
7859 (Ffuncall): Handle closures.
7860 (apply_lambda): Remove `eval_flags'.
7861 (funcall_lambda): Handle closures and new byte-code-functions.
7862 (Fspecial_variable_p): New function.
7863 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7864 but without exporting it to Lisp.
7866 * doc.c (Fdocumentation, store_function_docstring):
7867 * data.c (Finteractive_form): Handle closures.
7869 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7872 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7874 (exec_byte_code): New function extracted from Fbyte_code to handle new
7875 calling convention for byte-code-functions. Add new byte-codes.
7877 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7879 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7881 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7883 * xdisp.c (redisplay_internal): Fix prototype.
7885 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7887 * xdisp.c (SCROLL_LIMIT): New macro.
7888 (try_scrolling): Use it when setting scroll_limit.
7889 Limit scrolling to 100 screen lines.
7890 (redisplay_window): Even when falling back on "recentering",
7891 position point in the window according to scroll-conservatively,
7892 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7894 (try_scrolling): When point is above the window, allow searching
7895 as far as scroll_max, or one screenful, to compute vertical
7896 distance from PT to the scroll margin position. This prevents
7897 try_scrolling from unnecessarily failing when
7898 scroll-conservatively is set to a value slightly larger than the
7899 window height. Clean up the case of PT below the margin at bottom
7900 of window: scroll_max can no longer be INT_MAX. When aggressive
7901 scrolling is in use, don't let point enter the opposite scroll
7902 margin as result of the scroll.
7903 (syms_of_xdisp) <scroll-conservatively>: Document the
7904 threshold of 100 lines for never-recentering scrolling.
7906 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7908 * dispextern.h (move_it_by_lines):
7909 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7910 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7911 (message_log_check_duplicate): Remove parameters `prev_bol' and
7912 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7913 (redisplay_internal): Remove parameter `preserve_echo_area',
7914 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7916 * indent.c (Fvertical_motion):
7917 * window.c (window_scroll_pixel_based, Frecenter):
7918 Don't pass `need_y_p' to `move_it_by_lines'.
7920 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7922 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7923 steal a few bits to be more compact.
7924 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7925 Remove unneeded casts.
7927 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7929 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7931 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7932 binding" message (bug#7967).
7934 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7936 Fix more problems found by GCC 4.6.0's static checks.
7938 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7939 Remove unused local var.
7941 * editfns.c (Fmessage_box): Remove unused local var.
7943 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7944 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7945 Omit unused local vars.
7946 * window.c (shrink_windows): Omit unused local var.
7947 * menu.c (digest_single_submenu): Omit unused local var.
7948 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7949 Omit unused local var.
7951 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7952 Don't assume string length fits in int.
7953 (keyremap_step, read_key_sequence): Use size_t for sizes.
7954 (read_key_sequence): Don't check last_real_key_start redundantly.
7956 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7957 instead of alloca (Bug#8344).
7959 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7960 (Fbacktrace_frame): Don't assume nframes fits in int.
7962 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7964 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7967 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7969 * cm.c (calccost): Turn while-do into do-while, for clarity.
7971 * keyboard.c (syms_of_keyboard): Use the same style as later
7972 in this function when indexing through an array. This also
7973 works around GCC bug 48267.
7975 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7977 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7979 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7980 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7982 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7983 This avoids undefined behavior on integer overflow, and is a bit
7984 more convenient anyway since it is compared to a size_t variable.
7986 Variadic C functions now count arguments with size_t, not int.
7987 This avoids an unnecessary limitation on 64-bit machines, which
7988 caused (substring ...) to crash on large vectors (Bug#8344).
7989 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7990 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7991 All variadic functions and their callers changed accordingly.
7992 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7993 * data.c (arith_driver, float_arith_driver): Likewise.
7994 * editfns.c (general_insert_function): Likewise.
7995 * eval.c (struct backtrace.nargs, interactive_p)
7996 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7997 (funcall_lambda, mark_backtrace): Likewise.
7998 * fns.c (concat): Likewise.
7999 * frame.c (x_set_frame_parameters): Likewise.
8000 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8001 0 if not found, not -1. All callers changed.
8003 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8004 (stack_copy_size): Now size_t, not int.
8005 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8007 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8009 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8010 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8011 All callers changed.
8013 * lisp.h (multibyte_char_to_unibyte):
8014 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8015 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8016 * character.h (CHAR_TO_BYTE8):
8017 * cmds.c (internal_self_insert):
8018 * editfns.c (general_insert_function):
8019 * keymap.c (push_key_description):
8020 * search.c (Freplace_match):
8021 * xdisp.c (message_dolog, set_message_1): All callers changed.
8023 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8025 * keyboard.c (safe_run_hook_funcall): New function.
8026 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8027 don't set the hook to nil, but remove the offending function instead.
8028 (Qcommand_hook_internal): Remove, unused.
8029 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8030 Vcommand_hook_internal.
8032 * eval.c (enum run_hooks_condition): Remove.
8033 (funcall_nil, funcall_not): New functions.
8034 (run_hook_with_args): Call each function through a `funcall' argument.
8035 Remove `cond' argument, now redundant.
8036 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8037 (Frun_hook_with_args_until_failure): Adjust accordingly.
8038 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8040 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8042 * dispextern.h (string_buffer_position): Remove declaration.
8044 * print.c (strout): Remove parameter `multibyte', unused since
8045 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8047 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8048 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8049 All callers changed.
8051 * w32.c (_wsa_errlist): Use braces for struct initializers.
8053 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8054 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8055 All callers changed.
8056 (string_buffer_position): Likewise. Also, make static (it's never
8057 used outside xdisp.c).
8058 (cursor_row_p): Remove parameter `w', unused since
8059 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8060 (decode_mode_spec): Remove parameter `precision', introduced during
8061 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8062 All callers changed.
8064 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8066 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8068 2011-03-27 Anders Lindgren <andlind@gmail.com>
8070 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8071 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8072 (ns_update_auto_hide_menu_bar): New functions.
8073 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8074 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8075 ns_constrain_all_frames.
8076 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8077 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8079 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8081 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8083 2011-03-27 Glenn Morris <rgm@gnu.org>
8085 * syssignal.h: Replace RETSIGTYPE with void.
8086 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8087 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8088 Replace SIGTYPE with void everywhere.
8089 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8090 * s/template.h (SIGTYPE): Remove commented out definition.
8092 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8094 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8095 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8097 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8099 * w32.c (read_unc_volume): Use parameter `henum', instead of
8100 global variable `wget_enum_handle'.
8102 * keymap.c (describe_vector): Remove parameters `indices' and
8103 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8104 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8106 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8108 * keyboard.c (timer_check): Remove parameter `do_it_now',
8109 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8110 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8111 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8113 * keyboard.c (read_char):
8114 * w32menu.c (w32_menu_display_help):
8115 * xmenu.c (show_help_event, menu_help_callback):
8116 Adjust calls to `show_help_echo'.
8118 * gtkutil.c (xg_maybe_add_timer):
8119 * keyboard.c (readable_events):
8120 * process.c (wait_reading_process_output):
8121 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8123 * insdel.c (adjust_markers_gap_motion):
8124 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8125 (gap_left, gap_right): Don't call it.
8127 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8129 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8130 incurred during fontification.
8132 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8134 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8135 (DEFVAR_PER_BUFFER): Don't pass it.
8137 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8138 (scrolling_window): Don't pass it.
8140 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8142 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8144 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8146 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8147 of variables specific to SELinux and computation of `encoded_absname'.
8149 * image.c (XPutPixel): Remove unused variable `height'.
8151 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8153 * unexw32.c (get_section_info): Remove unused variable `section'.
8155 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8156 (system_process_attributes): Remove unused variable `sess'.
8157 (sys_read): Remove unused variable `err'.
8159 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8160 (w32_wnd_proc): Remove unused variable `isdead'.
8161 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8162 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8163 (x_create_tip_frame): Remove unused variable `tem'.
8165 * w32inevt.c (w32_console_read_socket):
8166 Remove unused variable `no_events'.
8168 * w32term.c (x_draw_composite_glyph_string_foreground):
8169 Remove unused variable `width'.
8171 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8173 * w32term.c (x_set_glyph_string_clipping):
8174 Don't pass uninitialized region to CombineRgn.
8176 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8178 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8179 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8180 (Fx_close_connection): Remove unused variable `i'.
8182 * w32font.c (w32font_draw): Return number of glyphs.
8183 (w32font_open_internal): Remove unused variable `i'.
8184 (w32font_driver): Add missing initializer.
8186 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8187 (fill_in_menu): Remove unused variable `items_added'.
8189 * w32term.c (last_mouse_press_frame): Remove static global variable.
8190 (w32_clip_to_row): Remove unused variable `f'.
8191 (x_delete_terminal): Remove unused variable `i'.
8193 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8194 (NOTHING): Remove unused static global variable.
8195 (uniscribe_check_otf): Remove unused variable `table'.
8196 (uniscribe_font_driver): Add missing initializers.
8198 2011-03-23 Julien Danjou <julien@danjou.info>
8200 * term.c (Fsuspend_tty, Fresume_tty):
8201 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8202 * window.c (temp_output_buffer_show):
8203 * insdel.c (signal_before_change):
8204 * frame.c (Fhandle_switch_frame):
8205 * fileio.c (Fdo_auto_save):
8206 * emacs.c (Fkill_emacs):
8207 * editfns.c (save_excursion_restore):
8208 * cmds.c (internal_self_insert):
8209 * callint.c (Fcall_interactively):
8210 * buffer.c (Fkill_all_local_variables):
8211 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8213 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8214 unconditionally since it does the check itself.
8216 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8218 Fix more problems found by GCC 4.5.2's static checks.
8220 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8221 the first time through the loop, since we know p0 < p1 then.
8222 This also avoids a gcc -Wstrict-overflow warning.
8224 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8225 leading to a memory leak, possible in functions like
8226 load_charset_map_from_file that can allocate an unbounded number
8227 of objects (Bug#8318).
8229 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8230 that could (at least in theory) be that large.
8232 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8233 This is less likely to overflow, and avoids undefined behavior if
8234 overflow does occur. All callers changed. Use strtoul to scan
8235 for the unsigned long integer.
8236 (pint2hrstr): Simplify and tune code slightly.
8237 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8239 * scroll.c (do_scrolling): Work around GCC bug 48228.
8240 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8242 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8243 This also avoids a warning with gcc -Wstrict-overflow.
8244 (validate_x_resource_name): Simplify count usage.
8245 This also avoids a warning with gcc -Wstrict-overflow.
8247 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8250 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8252 * process.c (Fmake_network_process): Use socklen_t, not int,
8253 where POSIX says socklen_t is required in portable programs.
8254 This fixes a porting bug on hosts like 64-bit HP-UX, where
8255 socklen_t is wider than int (Bug#8277).
8256 (Fmake_network_process, server_accept_connection):
8257 (wait_reading_process_output, read_process_output):
8260 * process.c: Rename or move locals to avoid shadowing.
8261 (list_processes_1, Fmake_network_process):
8262 (read_process_output_error_handler, exec_sentinel_error_handler):
8263 Rename or move locals.
8264 (Fmake_network_process): Define label "retry_connect" only if needed.
8265 (Fnetwork_interface_info): Fix pointer signedness.
8266 (process_send_signal): Add cast to avoid pointer signedness problem.
8267 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8268 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8270 Make tparam.h and terminfo.c consistent.
8271 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8272 Include tparam.h instead, since it declares them.
8273 * cm.h (PC): Remove extern decl; tparam.h now does this.
8274 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8275 * terminfo.c: Include tparam.h, to check interfaces.
8276 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8277 (tparam): Adjust signature to match interface in tparam.h;
8278 this removes some undefined behavior. Check that outstring and len
8279 are zero, which they always are with Emacs.
8280 * tparam.h (PC, BC, UP): New extern decls.
8282 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8283 (xftfont_open): Rename locals to avoid shadowing.
8285 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8286 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8287 (OTF_TAG_SYM): Omit macro if not needed.
8288 (ftfont_list): Remove unused local.
8289 (get_adstyle_property, ftfont_pattern_entity):
8290 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8291 Rename locals to avoid shadowing.
8293 * xfont.c (xfont_list_family): Mark var as initialized.
8295 * xml.c (make_dom): Now static.
8297 * composite.c (composition_compute_stop_pos): Rename local to
8299 (composition_reseat_it): Remove unused locals.
8300 (find_automatic_composition, composition_adjust_point): Likewise.
8301 (composition_update_it): Mark var as initialized.
8302 (find_automatic_composition): Mark vars as initialized,
8303 with a FIXME (Bug#8290).
8305 character.h: Rename locals to avoid shadowing.
8306 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8307 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8308 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8309 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8312 * textprop.c (property_change_between_p): Remove; unused.
8314 * intervals.c (interval_start_pos): Now static.
8316 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8318 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8319 Rename locals to avoid shadowing.
8321 * sound.c (wav_play, au_play, Fplay_sound_internal):
8322 Fix pointer signedness.
8323 (alsa_choose_format): Remove unused local var.
8324 (wav_play): Initialize a variable to 0, to prevent undefined
8325 behavior (Bug#8278).
8327 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8329 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8331 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8332 clobbering (Bug#8298).
8333 * sysdep.c (sys_subshell): Likewise.
8334 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8336 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8337 This should get cleaned up, so that child_setup has the
8338 same signature on all platforms.
8340 * callproc.c (call_process_cleanup): Now static.
8341 (relocate_fd): Rename locals to avoid shadowing.
8343 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8345 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8346 not to be necessary, and produces flickering.
8348 2011-03-20 Glenn Morris <rgm@gnu.org>
8350 * config.in: Remove file.
8352 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8354 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8355 are now in src/globals.h.
8356 (syms_of_minibuf): Remove spurious & from previous change.
8358 2011-03-20 Leo Liu <sdl.web@gmail.com>
8360 * minibuf.c (completing-read-function): New variable.
8361 (completing-read-default): Rename from completing-read.
8362 (completing-read): Call completing-read-function.
8364 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8366 * xfaces.c (Fx_load_color_file):
8367 Read color file from absolute filename (bug#8250).
8369 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8371 * makefile.w32-in: Update dependencies.
8373 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8375 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8377 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8379 Fix more problems found by GCC 4.5.2's static checks.
8381 * process.c (make_serial_process_unwind, send_process_trap):
8382 (sigchld_handler): Now static.
8384 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8385 That way, the code declares only the vars that it needs.
8386 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8387 * s/cygwin.h (PTY_ITERATION): Likewise.
8388 * s/darwin.h (PTY_ITERATION): Likewise.
8389 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8391 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8392 * process.c (allocate_pty): Don't declare stb unless it's needed.
8394 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8395 (CONSTANTLIM): Remove; unused.
8396 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8397 Define only if needed.
8399 * unexelf.c (unexec): Name an expression,
8400 to avoid gcc -Wbad-function-cast warning.
8401 Use a different way to cause a compilation error if anyone uses
8402 n rather than nn, a way that does not involve shadowing.
8403 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8405 * deps.mk (unexalpha.o): Remove; unused.
8407 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8408 * unexec.h: New file.
8409 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8410 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8412 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8413 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8414 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8415 Change as necessary to match prototype in unexec.h.
8417 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8419 (back_comment, skip_chars): Mark vars as initialized.
8421 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8422 Rename locals to avoid shadowing.
8424 * lread.c (read1): Rewrite so as not to use empty "else".
8425 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8427 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8429 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8430 warning when compiling print.c.
8432 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8433 instead of using an uninitialized var.
8434 (font_sort_entities): Mark var as initialized.
8436 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8438 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8439 pointers to constants.
8440 (font_parse_fcname): Remove unused vars.
8441 (font_delete_unmatched): Now static.
8442 (font_get_spec): Remove; unused.
8443 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8444 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8445 Rename or move locals to avoid shadowing.
8447 * fns.c (require_nesting_list, require_unwind): Now static.
8448 (Ffillarray): Rename locals to avoid shadowing.
8450 * floatfns.c (domain_error2): Define only if needed.
8451 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8453 * alloc.c (mark_backtrace): Move decl from here ...
8454 * lisp.h: ... to here, so that it can be checked.
8456 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8457 (Fdefvar): Rewrite so as not to use empty "else".
8458 (lisp_indirect_variable): Name an expression,
8459 to avoid gcc -Wbad-function-cast warning.
8460 (Fdefvar): Rename locals to avoid shadowing.
8462 * callint.c (quotify_arg, quotify_args): Now static.
8463 (Fcall_interactively): Rename locals to avoid shadowing.
8464 Use const pointer when appropriate.
8466 * lisp.h (get_system_name, get_operating_system_release):
8467 Move decls here, to check interfaces.
8468 * process.c (get_operating_system_release): Move decl to lisp.h.
8469 * xrdb.c (get_system_name): Likewise.
8470 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8471 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8472 some of which prompt warnings from gcc -Wbad-function-cast.
8473 (Fformat_time_string, Fencode_time, Finsert_char):
8474 (Ftranslate_region_internal, Fformat):
8475 Rename or remove local vars to avoid shadowing.
8476 (Ftranslate_region_internal): Mark var as initialized.
8478 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8481 * lisp.h (eassert): Check that the argument compiles, even if
8482 ENABLE_CHECKING is not defined.
8484 * data.c (Findirect_variable): Name an expression, to avoid
8485 gcc -Wbad-function-cast warning.
8486 (default_value, arithcompare, arith_driver, arith_error): Now static.
8487 (store_symval_forwarding): Rename local to avoid shadowing.
8488 (Fmake_variable_buffer_local, Fmake_local_variable):
8489 Mark variables as initialized.
8490 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8492 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8493 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8494 Rename locals to avoid shadowing.
8495 (mark_stack): Move local variables into the #ifdef region where
8497 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8498 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8500 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8501 (GC_STRING_CHARS): Remove; not used.
8502 (Fmemory_limit): Cast sbrk's returned value to char *.
8504 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8505 avoids undefined behavior in theory.
8507 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8509 Use functions, not macros, for up- and down-casing (Bug#8254).
8510 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8511 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8512 to use the following functions instead of these macros.
8513 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8514 EMACS_INT, since callers assume the returned value fits in int.
8515 (upcase1): Likewise, for UPCASE_TABLE.
8516 (uppercasep, lowercasep, upcase): New static inline functions.
8517 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8518 the race-condition problem in the old DOWNCASE.
8520 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8521 Rename locals to avoid shadowing.
8522 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8523 (regex_compile, re_search_2, re_match_2_internal):
8524 Remove unused local vars.
8525 (FREE_VAR): Rewrite so as not to use empty "else",
8526 which gcc can warn about.
8527 (regex_compile, re_match_2_internal): Mark locals as initialized.
8528 (RETALLOC_IF): Define only if needed.
8529 (WORDCHAR_P): Likewise. This one is never needed, but is used
8530 only in a comment talking about a compiler bug, so put inside
8531 the #if 0 of that comment.
8532 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8533 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8536 * search.c (boyer_moore): Rename locals to avoid shadowing.
8537 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8538 (PREV_CHAR_BOUNDARY): Likewise.
8540 * search.c (simple_search): Remove unused var.
8542 * dired.c (compile_pattern): Move decl from here ...
8543 * lisp.h: ... to here, so that it can be checked.
8544 (struct re_registers): New forward decl.
8546 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8548 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8550 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8551 Rename locals to avoid shadowing.
8552 (Fvertical_motion): Mark locals as initialized.
8554 * casefiddle.c (casify_object, casify_region): Now static.
8555 (casify_region): Mark local as initialized.
8557 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8559 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8560 New macros, so that the caller can use some names other than
8561 gcpro1, gcpro2, etc.
8562 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8564 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8565 argument, for consistency with GCPRO2_VAR, etc: it is now the
8566 prefix of the variable, not the variable itself. All uses
8568 * dired.c (directory_files_internal, file_name_completion):
8569 Rename locals to avoid shadowing.
8571 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8572 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8573 dired.c's scmp function, had undefined behavior.
8574 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8575 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8576 * buffer.h: ... to here, because these macros use current_buffer,
8577 and the new implementation with inline functions needs to have
8578 current_buffer in scope now, rather than later when the macros
8580 (downcase, upcase1): New static inline functions.
8581 (DOWNCASE, UPCASE1): Reimplement using these functions.
8582 This avoids undefined behavior in expressions like
8583 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8584 from race conditions in accessing the global variables
8585 case_temp1 and case_temp2.
8586 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8587 * lisp.h (case_temp1, case_temp2): Remove their decls.
8588 * character.h (ASCII_CHAR_P): Move from here ...
8589 * lisp.h: ... to here, so that the inline functions mentioned
8592 * dired.c (directory_files_internal_unwind): Now static.
8594 * fileio.c (file_name_as_directory, directory_file_name):
8595 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8597 (file_name_as_directory): Use const pointers when appropriate.
8598 (Fexpand_file_name): Likewise. In particular, newdir might
8599 point at constant storage, so make it a const pointer.
8600 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8601 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8603 (Fset_file_times, Finsert_file_contents, auto_save_error):
8604 Rename locals to avoid shadowing.
8606 * minibuf.c (choose_minibuf_frame_1): Now static.
8607 (Ftry_completion, Fall_completions): Rename or remove locals
8610 * marker.c (bytepos_to_charpos): Remove; unused.
8612 * lisp.h (verify_bytepos, count_markers): New decls,
8613 so that gcc does not warn that these functions aren't declared.
8615 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8616 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8617 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8618 (copy_text): Remove unused local var.
8620 * filelock.c (within_one_second): Now static.
8621 (lock_file_1): Rename local to avoid shadowing.
8623 * buffer.c (fix_overlays_before): Mark locals as initialized.
8624 (fix_start_end_in_overlays): Likewise. This function should be
8625 simplified by using pointers-to-pointers, but that's a different
8627 (switch_to_buffer_1): Now static.
8628 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8629 (report_overlay_modification): Rename locals to avoid shadowing.
8631 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8632 Fix pointer signedness issue.
8633 (sys_subshell): Mark local as volatile if checking for lint,
8634 to suppress a gcc -Wclobbered warning that does not seem to be right.
8635 (MAXPATHLEN): Define only if needed.
8637 * process.c (serial_open, serial_configure): Move decls from here ...
8638 * systty.h: ... to here, so that they can be checked.
8640 * fns.c (get_random, seed_random): Move extern decls from here ...
8641 * lisp.h: ... to here, so that they can be checked.
8643 * sysdep.c (reset_io): Now static.
8644 (wait_for_termination_signal): Remove; unused.
8646 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8647 (copy_keymap_item, append_key, push_text_char_description):
8649 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8650 (DENSE_TABLE_SIZE): Remove; unused.
8651 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8652 (describe_map_tree):
8653 Rename locals to avoid shadowing.
8655 * keyboard.c: Declare functions static if they are not used elsewhere.
8656 (echo_char, echo_dash, cmd_error, top_level_2):
8657 (poll_for_input, handle_async_input): Now static.
8658 (read_char, kbd_buffer_get_event, make_lispy_position):
8659 (make_lispy_event, make_lispy_movement, apply_modifiers):
8660 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8661 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8662 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8663 (read_key_sequence, read_char): Mark locals as initialized.
8664 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8666 * keyboard.h (make_ctrl_char): New decl.
8667 (mark_kboards): Move decl here ...
8668 * alloc.c (mark_kboards): ... from here.
8670 * lisp.h (force_auto_save_soon): New decl.
8672 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8673 (DEFINE_DUMMY_FUNCTION): New macro.
8674 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8676 (main): Add casts to avoid warnings
8677 if GCC considers string literals to be constants.
8679 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8681 * dbusbind.c: Pointer signedness fixes.
8682 (xd_signature, xd_append_arg, xd_initialize):
8683 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8684 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8685 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8686 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8688 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8689 if GCC considers string literals to be constants.
8690 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8692 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8694 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8695 (print_preprocess, print_object): New macro to fix last change.
8697 * print.c (print_preprocess): Don't forget font objects.
8699 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8701 * emacs.c (USAGE3): Doc fixes.
8703 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8705 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8708 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8710 * lisp.h (VWindow_system, Qfile_name_history):
8711 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8712 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8713 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8715 * w32select.c: Don't #include "keyboard.h".
8716 (run_protected): Add extern declaration for waiting_for_input.
8718 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8719 * w32console.c (detect_input_pending, read_input_pending)
8720 (encode_terminal_code):
8721 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8722 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8723 (w32_system_caret_y, Qfile_name_history):
8724 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8725 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8726 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8727 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8728 * w32proc.c (Qlocal, report_file_error):
8729 * w32term.c (Vwindow_system, updating_frame):
8730 * w32uniscribe.c (initialized, uniscribe_font_driver):
8731 Remove unneeded extern declarations.
8733 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8735 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8737 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8739 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8740 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8741 These macros can no longer be used for assignment.
8743 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8744 Assign struct members directly, instead of using BUF_BEGV etc.
8745 (record_buffer_markers, fetch_buffer_markers): New functions for
8746 recording and fetching special buffer markers.
8747 (set_buffer_internal_1, set_buffer_temp): Use them.
8749 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8751 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8753 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8754 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8756 * xdisp.c (hscroll_window_tree):
8757 (reconsider_clip_changes): Use PT instead of BUF_PT.
8759 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8761 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8762 $(EMACS_ROOT)/lib/intprops.h.
8764 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8766 Fix more problems found by GCC 4.5.2's static checks.
8768 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8769 to unsigned char * to avoid compiler diagnostic.
8770 (xg_free_frame_widgets): Make it clear that a local variable is
8771 needed only if USE_GTK_TOOLTIP.
8772 (gdk_window_get_screen): Make it clear that this macro is needed
8773 only if USE_GTK_TOOLTIP.
8774 (int_gtk_range_get_value): New function, which avoids a diagnostic
8775 from gcc -Wbad-function-cast.
8776 (xg_set_toolkit_scroll_bar_thumb): Use it.
8777 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8778 diagnostic from gcc -Wbad-function-cast.
8779 (get_utf8_string, xg_get_file_with_chooser):
8780 Rename locals to avoid shadowing.
8781 (create_dialog): Move locals to avoid shadowing.
8783 * xgselect.c (xg_select): Remove unused var.
8785 * image.c (four_corners_best): Mark locals as initialized.
8786 (gif_load): Initialize transparent_p to zero (Bug#8238).
8787 Mark another local as initialized.
8788 (my_png_error, my_error_exit): Mark with NO_RETURN.
8790 * image.c (clear_image_cache): Now static.
8791 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8792 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8793 (x_edge_detection): Remove unnecessary cast that
8794 gcc -Wbad-function-cast diagnoses.
8795 (gif_load): Fix pointer signedness.
8796 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8797 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8799 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8801 Improve quality of tests for time stamp overflow.
8802 For example, without this patch (encode-time 0 0 0 1 1
8803 1152921504606846976) returns the obviously-bogus value (-948597
8804 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8805 reports time overflow. See
8806 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8807 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8808 * editfns.c: Include limits.h and intprops.h.
8809 (TIME_T_MIN, TIME_T_MAX): New macros.
8810 (time_overflow): Move earlier, to before first use.
8811 (hi_time, lo_time): New functions, for an accurate test for
8813 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8814 (Fget_internal_run_time): Don't assume time_t fits in int.
8815 (make_time): Use list2 instead of Fcons twice.
8816 (Fdecode_time): More accurate test for out-of-range times.
8817 (check_tm_member): New function.
8818 (Fencode_time): Use it, to test for out-of-range times.
8819 (lisp_time_argument): Don't rely on undefined left-shift and
8820 right-shift behavior when checking for time stamp overflow.
8822 * editfns.c (time_overflow): New function, refactoring common code.
8823 (Fformat_time_string, Fdecode_time, Fencode_time):
8824 (Fcurrent_time_string): Use it.
8826 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8827 * dired.c (make_time): Move to ...
8828 * editfns.c (make_time): ... here.
8829 * systime.h: Note the move.
8831 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8833 * fringe.c (update_window_fringes): Remove unused variables.
8835 * unexmacosx.c (copy_data_segment): Also copy __got section.
8838 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8840 * termcap.c [MSDOS]: Include "msdos.h".
8841 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8842 Constify `char *' arguments and their references according to
8843 prototypes in tparam.h.
8845 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8847 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8848 Adapt all references accordingly.
8850 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8852 2011-03-11 Tom Tromey <tromey@redhat.com>
8854 * buffer.c (syms_of_buffer): Remove obsolete comment.
8856 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8858 * termhooks.h (encode_terminal_code): Declare prototype.
8860 * msdos.c (encode_terminal_code): Don't declare prototype.
8862 * term.c (encode_terminal_code): Now external again, used by
8863 w32console.c and msdos.c.
8865 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8866 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8868 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8870 Fix some minor problems found by GCC 4.5.2's static checks.
8872 * fringe.c (update_window_fringes): Mark locals as initialized
8874 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8876 * alloc.c (mark_fringe_data): Move decl from here ...
8877 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8878 to check its interface.
8879 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8881 * fontset.c (free_realized_fontset): Now static.
8882 (Fset_fontset_font): Rename local to avoid shadowing.
8883 (fontset_font): Mark local as initialized.
8884 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8886 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8888 * xselect.c (x_disown_buffer_selections): Remove; not used.
8889 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8890 (x_own_selection, Fx_disown_selection_internal): Rename locals
8892 (x_handle_dnd_message): Remove local to avoid shadowing.
8894 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8895 so that the caller can use some name other than gcpro1.
8896 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8897 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8898 (Fx_backspace_delete_keys_p):
8899 Use them to avoid shadowing, and rename vars to avoid shadowing.
8900 (x_decode_color, x_set_name, x_window): Now static.
8901 (Fx_create_frame): Add braces to silence GCC warning.
8902 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8903 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8904 Remove unused locals.
8905 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8906 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8907 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8910 * xterm.h (x_mouse_leave): New decl.
8912 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8913 Remove unused functions.
8914 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8915 (x_calc_absolute_position): Now static.
8916 (XTread_socket): Don't define label "out" unless it's used.
8917 Don't declare local "event" unless it's used.
8918 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8919 unless they are used.
8920 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8921 (x_fatal_error_signal): Remove; not used.
8922 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8923 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8924 (x_error_catcher, x_connection_closed, x_error_handler):
8925 (x_error_quitter, xembed_send_message, x_iconify_frame):
8926 (my_log_handler): Rename locals to avoid shadowing.
8927 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8928 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8930 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8931 Rename or move locals to avoid shadowing.
8932 (tty_defined_color, merge_face_heights): Now static.
8933 (free_realized_faces_for_fontset): Remove; not used.
8934 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8935 does not deduce is never used uninitialized.
8936 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8937 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8939 * terminal.c (store_terminal_param): Now static.
8941 * xmenu.c (menu_highlight_callback): Now static.
8942 (set_frame_menubar): Remove unused local.
8943 (xmenu_show): Rename parameter to avoid shadowing.
8944 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8945 since they might point to immutable storage.
8946 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8947 since it's unused otherwise.
8949 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8950 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8951 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8952 avoids a gcc -Wuninitialized diagnostic.
8953 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8954 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8955 does not deduce are never used uninitialized.
8957 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8959 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8960 * window.c (window_loop, size_window):
8961 (run_window_configuration_change_hook, enlarge_window): Likewise.
8963 * window.c (display_buffer): Now static.
8964 (size_window): Mark variables that gcc -Wuninitialized
8965 does not deduce are never used uninitialized.
8966 * window.h (check_all_windows): New decl, to forestall
8967 gcc -Wmissing-prototypes diagnostic.
8968 * dispextern.h (bidi_dump_cached_states): Likewise.
8970 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8972 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8974 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8975 and to avoid gcc -Wuninitialized warning.
8976 (load_charset_map): Mark variables that gcc -Wuninitialized
8977 does not deduce are never used uninitialized.
8978 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8980 * coding.c (coding_set_source, coding_set_destination):
8981 Use "else { /* comment */ }" rather than "else /* comment */;"
8982 for clarity, and to avoid gcc -Wempty-body warning.
8983 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8984 a block, when the outer 'i' will do.
8985 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8986 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8987 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8988 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8989 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8990 Rename locals to avoid shadowing.
8991 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8992 * coding.c (emacs_mule_char, encode_invocation_designation):
8993 Now static, since they're not used elsewhere.
8994 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8995 (decode_coding_object, encode_coding_object, detect_coding_system):
8996 (decode_coding_emacs_mule): Mark variables that gcc
8997 -Wuninitialized does not deduce are never used uninitialized.
8998 (detect_coding_iso_2022): Initialize a local variable that might
8999 be used uninitialized. Leave a FIXME because it's not clear that
9000 this initialization is needed. (Bug#8211)
9001 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9002 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9003 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9004 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9005 Remove unused macros.
9007 * category.c (hash_get_category_set): Remove unused local var.
9008 (copy_category_table): Now static, since it's not used elsewhere.
9009 * character.c (string_count_byte8): Likewise.
9011 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9012 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9014 * chartab.c (copy_sub_char_table): Now static, since it's not used
9016 (sub_char_table_ref_and_range, char_table_ref_and_range):
9017 Rename locals to avoid shadowing.
9018 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9020 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9021 (BIDI_BOB): Remove unused macro.
9023 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9024 deduce are never used uninitialized.
9025 * term.c (encode_terminal_code): Likewise.
9027 * term.c (encode_terminal_code): Now static. Remove unused local.
9029 * tparam.h: New file.
9030 * term.c, tparam.h: Include it.
9031 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9032 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9033 Move these decls to tparam.h, and make them agree with what
9034 is actually in tparam.c. The previous trick of using incompatible
9035 decls in different modules does not conform to the C standard.
9036 All callers of tparam changed to use tparam's actual API.
9037 * tparam.c (tparam1, tparam, tgoto):
9038 Use const pointers where appropriate.
9040 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9041 * cm.h (struct cm): Likewise.
9042 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9043 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9044 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9045 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9046 (turn_on_face, init_tty): Likewise.
9047 * termchar.h (struct tty_display_info): Likewise.
9049 * term.c (term_mouse_position): Rename local to avoid shadowing.
9051 * alloc.c (mark_ttys): Move decl from here ...
9052 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9054 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9056 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9058 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9060 * search.c (compile_pattern_1): Remove argument regp, unused since
9061 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9062 (compile_pattern): Don't pass it.
9064 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9066 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9067 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9069 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9071 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9073 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9074 gdk_window_get_screen, gdk_window_get_geometry,
9075 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9076 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9077 (xg_get_pixbuf_from_pixmap): New function.
9078 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9079 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9080 Call xg_get_pixbuf_from_pixmap instead of
9081 gdk_pixbuf_get_from_drawable.
9082 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9083 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9084 (xg_check_special_colors): Use GtkStyleContext and its functions
9086 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9087 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9088 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9089 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9090 Call gtk_widget_get_preferred_size.
9091 (xg_frame_resized): gdk_window_get_geometry only takes 5
9093 (xg_win_to_widget, xg_event_is_for_menubar):
9094 Call gdk_x11_window_lookup_for_display.
9095 (xg_set_widget_bg): New function.
9096 (delete_cb): New function.
9097 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9098 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9099 (xg_set_background_color): Call xg_set_widget_bg.
9100 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9101 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9102 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9103 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9105 (update_frame_tool_bar): Call gtk_widget_hide.
9106 (xg_initialize): Use GDK_KEY_g.
9108 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9110 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9112 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9113 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9114 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9116 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9118 * w32xfns.c (select_palette): Check success of RealizePalette against
9119 GDI_ERROR, not zero.
9121 See ChangeLog.11 for earlier changes.
9127 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9129 This file is part of GNU Emacs.
9131 GNU Emacs is free software: you can redistribute it and/or modify
9132 it under the terms of the GNU General Public License as published by
9133 the Free Software Foundation, either version 3 of the License, or
9134 (at your option) any later version.
9136 GNU Emacs is distributed in the hope that it will be useful,
9137 but WITHOUT ANY WARRANTY; without even the implied warranty of
9138 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9139 GNU General Public License for more details.
9141 You should have received a copy of the GNU General Public License
9142 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.