1 2011-12-23 Eli Zaretskii <eliz@gnu.org>
3 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4 property that ends at ZV, so that the bidi iteration could be
5 resumed from there (after widening).
7 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
9 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
11 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
13 * nsterm.m (x_free_frame_resources): Release
14 f->output_data.ns->miniimage
15 (ns_index_color): Fix indentation. Do not retain
16 color_table->colors[i].
18 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
21 * nsfns.m (x_set_background_color): Assign return value from
22 ns_index_color to face-background instead of NSColor*.
23 (ns_implicitly_set_icon_type): Fix indentation.
24 Change assignment in for loop to comparison.
26 * emacs.c (ns_pool): New variable.
27 (main): Assign ns_pool.
28 (Fkill_emacs): Call ns_release_autorelease_pool.
30 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
31 autorelease fdesc, release fdAttrs and tdict.
32 (ns_get_covering_families): Release charset.
33 (ns_findfonts): Release NSFontDescriptor created with new.
34 (ns_uni_to_glyphs): Fix indentation.
35 (setString): Release attrStr before assigning new value.
37 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
39 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
41 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
42 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
44 2011-12-18 David Reitter <reitter@cmu.edu>
46 * nsterm.m (ns_term_init): Subscribe for notifications
47 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
48 to method trackingNotification in EmacsMenu.
50 * nsmenu.m (trackingMenu): New variable.
51 (trackingNotification): New method (from Aquamacs).
52 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
53 from Aquamacs (Bug#7030).
55 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
57 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
58 (symbol_to_nsstring): Fix indentation.
59 (ns_symbol_to_pb): New function.
60 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
61 (Fns_rotate_cut_buffers_internal): Removed.
62 (Fns_store_selection_internal): Renamed from
63 Fns_store_cut_buffer_internal.
64 (ns_get_foreign_selection, Fx_own_selection_internal)
65 (Fx_disown_selection_internal, Fx_selection_exists_p)
66 (Fns_get_selection_internal, Fns_store_selection_internal): Use
67 ns_symbol_to_pb and check if return value is nil.
68 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove
69 defsubr Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
70 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
71 renamed to Sns_store_selection_internal.
72 (ns_handle_selection_request): Move code to Fx_own_selection_internal
73 and remove this function.
74 (ns_handle_selection_clear): Remove, never used.
75 (Fx_own_selection_internal): Move code from ns_handle_selection_request
78 2011-12-17 Ken Brown <kbrown@cornell.edu>
80 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
81 GID is unknown (Bug#10257).
83 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
85 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
86 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
87 which caused a build failure on GNU/Linux IA-64. This problem was
88 introduced by my 2011-10-07 patch.
90 2011-12-15 Juri Linkov <juri@jurta.org>
92 * image.c (imagemagick_error): New function. (Bug#10112)
93 (imagemagick_load_image): Comment out `MagickSetResolution' call.
94 Use `imagemagick_error' where ImageMagick functions return
96 (Fimagemagick_types): Add `Fnreverse' to return the list in the
99 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
101 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
102 fill background (Bug#8992).
104 2011-12-13 Martin Rudalics <rudalics@gmx.at>
106 * window.c (Vwindow_combination_resize)
107 (Vwindow_combination_limit): Use t instead of non-nil in
109 (Vrecenter_redisplay): Add first sentence of doc-string on
111 (Frecenter): Fix doc-string typo.
113 2011-12-11 Kenichi Handa <handa@m17n.org>
115 * coding.c (Funencodable_char_position): Pay attention to the
116 buffer text relocation (Bug#9389).
118 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
120 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
121 gtk_init (Bug#10100).
123 2011-12-10 Eli Zaretskii <eliz@gnu.org>
125 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
126 IT->string is nil. (Bug#10263)
128 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
130 * nsterm.h (x_free_frame_resources): Declare.
132 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
133 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
135 * nsterm.h (ns_get_defaults_value): Declare.
137 * nsterm.m (ns_default): Call ns_get_defaults_value.
139 2011-12-09 Eli Zaretskii <eliz@gnu.org>
141 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
144 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
146 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
147 that where the value of an _OBJC_* symbol points to is in the .bss
150 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
152 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
153 after the loop to call ccl_driver at least once (Bug#8619).
155 2011-12-08 Kenichi Handa <handa@m17n.org>
157 * ftfont.c (get_adstyle_property): Fix previous change
160 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
162 * w32.c (init_environment): If no_site_lisp, remove site-lisp
163 dirs from the default value of EMACSLOADPATH (bug#10208).
165 2011-12-07 Glenn Morris <rgm@gnu.org>
167 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
168 installation and source directories as well. (Bug#10208)
170 2011-12-06 Chong Yidong <cyd@gnu.org>
172 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
174 2011-12-06 Glenn Morris <rgm@gnu.org>
176 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
177 as an error, not just -1. (Bug#10217)
179 2011-12-05 Chong Yidong <cyd@gnu.org>
181 * keyboard.c (process_special_events): New function.
182 (swallow_events, Finput_pending_p): Use it (Bug#10195).
184 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
186 * coding.c (encode_designation_at_bol): Don't use uninitialized
187 local variable (Bug#9318).
189 2011-12-05 Kenichi Handa <handa@m17n.org>
191 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
192 return Qnil (Bug#8046, Bug#10193).
194 2011-12-05 Kenichi Handa <handa@m17n.org>
196 * coding.c (encode_designation_at_bol): New args charbuf_end and
197 dst. Return the number of produced bytes. Callers changed.
198 (coding_set_source): Return how many bytes coding->source was
200 (coding_set_destination): Return how many bytes
201 coding->destination was relocated.
202 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
203 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
205 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
207 * coding.c (CODING_CHAR_CHARSET_P): New macro.
208 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
211 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
213 The following changes are to fix Bug#9318.
215 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
216 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
217 (encode_coding_iso_2022, encode_coding_sjis)
218 (encode_coding_big5, encode_coding_charset): Use the above macros.
220 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
222 * lisp.h (process_quit_flag): Fix external declaration.
224 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
226 Don't macro-inline non-performance-critical code.
227 * eval.c (process_quit_flag): New function.
228 * lisp.h (QUIT): Use it.
230 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
232 * nsfns.m (get_geometry_from_preferences): New function.
233 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
235 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
237 * emacs.c (Qkill_emacs): Define.
238 (syms_of_emacs): Initialize it.
239 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
240 Qquit_flag to `kill-emacs' instead.
241 (quit_throw_to_read_char): Add parameter `from_signal'.
242 All callers changed. Call Fkill_emacs if requested and safe.
243 * lisp.h (QUIT): Call Fkill_emacs if requested.
245 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
247 * widget.c (update_wm_hints): Return if wmshell is null.
248 (widget_update_wm_size_hints): New function.
250 * widget.h (widget_update_wm_size_hints): Declare.
252 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
253 widget_update_wm_size_hints (Bug#10104).
255 2011-12-03 Eli Zaretskii <eliz@gnu.org>
257 * xdisp.c (handle_invisible_prop): If the invisible text ends just
258 before a newline, prepare the bidi iterator for consuming the
259 newline, and keep the current paragraph direction. (Bug#10183)
260 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
262 2011-12-02 Juri Linkov <juri@jurta.org>
264 * search.c (Fword_search_regexp): New Lisp function created from
265 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
266 (Fword_search_backward, Fword_search_forward)
267 (Fword_search_backward_lax, Fword_search_forward_lax):
268 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
269 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
271 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
273 * fileio.c (Finsert_file_contents): Move after-change-function call
274 to before the "handled:" label, since all "goto handled" appear in
275 cases where the *-change-functions have already been properly called
278 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
280 * keyboard.c (interrupt_signal): Don't call kill-emacs when
281 waiting for input. (Bug#10169)
283 2011-11-30 Eli Zaretskii <eliz@gnu.org>
285 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
286 verifies glyph row's hash code--we have just reallocated the
287 glyphs, so their contents can be complete garbage. (Bug#10164)
289 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
291 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
293 2011-11-30 Eli Zaretskii <eliz@gnu.org>
295 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
296 attributes are tested _before_ calling verify_row_hash, to protect
297 against GCC re-ordering of the tests. (Bug#10164)
299 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
301 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
303 * xterm.c (handle_one_xevent): Only set async_visible and friends
304 if net_wm_state_hidden_seen is non-zero (Bug#10002)
305 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
306 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
308 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
310 Remove GCPRO-related macros that exist only to avoid shadowing locals.
311 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
312 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
313 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
314 All uses changed to use GCPRO1 etc.
315 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
316 Revert to old implementation (i.e., before 2011-03-11).
318 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
320 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
321 of scroll runs so as to avoid assigning disabled bogus rows and
322 unnecessary graphics copy operations.
324 2011-11-27 Eli Zaretskii <eliz@gnu.org>
326 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
327 (snprintf) [_MSC_VER]: Redirect to _snprintf.
328 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
329 (malloc, free, realloc, calloc): Redirect to e_* only when
332 * lisp.h (GCTYPEBITS): Move before first use.
333 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
334 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
335 this macro definition.
337 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
340 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
342 * gtkutil.c (xg_create_frame_widgets):
343 Call gtk_window_set_has_resize_grip (FALSE) if that function is
344 present with Gtk+ 2.0.
346 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
348 * fileio.c (Finsert_file_contents): Undo previous change; see
349 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
351 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
353 Rename locals to avoid shadowing.
354 * fileio.c (Finsert_file_contents):
355 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
356 * process.c (wait_reading_process_output):
357 Rename inner 'proc' to 'p' to avoid shadowing.
358 Indent for consistency with usual Emacs style.
360 2011-11-25 Eli Zaretskii <eliz@gnu.org>
362 * xdisp.c (redisplay_window): If cursor row is not fully visible
363 after recentering, and scroll-conservatively is set to a large
364 number, scroll window by a few more lines to make the cursor fully
365 visible and out of scroll-margin. (Bug#10105)
366 (start_display): Don't move to the next line if the display should
367 start at a newline that is part of a display vector or an overlay
370 2011-11-24 Juri Linkov <juri@jurta.org>
372 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
373 after the `MagickPingImage' call. (Bug#10112)
375 2011-11-23 Chong Yidong <cyd@gnu.org>
377 * window.c (Fcoordinates_in_window_p): Accept only live windows.
379 2011-11-23 Martin Rudalics <rudalics@gmx.at>
381 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
382 making another buffer current. (Bug#10114)
384 2011-11-23 Glenn Morris <rgm@gnu.org>
386 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
388 2011-11-23 Chong Yidong <cyd@gnu.org>
390 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
393 2011-11-22 Eli Zaretskii <eliz@gnu.org>
395 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
396 and header-lines, as they don't have one computed for them.
399 * .gdbinit (prow): Make displayed values more self-explaining.
402 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
404 * process.c (wait_reading_process_output): Fix asynchrounous
405 GnuTLS socket handling on some versions of the GnuTLS library.
406 (wait_reading_process_output): Add comment and URL.
408 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
410 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
412 2011-11-21 Chong Yidong <cyd@gnu.org>
414 * window.c (Fnext_window, Fprevious_window): Doc fix.
416 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
418 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
420 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
422 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
424 2011-11-20 Martin Rudalics <rudalics@gmx.at>
426 * window.c (Fset_window_combination_limit): Rename argument
428 (Vwindow_combination_limit): Remove "status" from doc-string.
430 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
432 * m/ibms390.h: Remove.
433 * m/ibms390x.h: Don't include "ibms390.h".
435 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
437 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
438 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
440 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
442 * casetab.c (Fset_case_table):
443 * charset.c (Fcharset_after): Fix typos.
445 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
447 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
448 Otherwise, valgrind does not work on some platforms.
449 Problem reported by Andreas Schwab in
450 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
451 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
452 is set, removing the need for VIRT_ADDRESS_VARIES.
453 (PURE_P): Use a more-efficient implementation that needs just one
454 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
455 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
456 to 4 (xorl, subq, cmpq, setbe).
457 * alloc.c (pure): Always extern now, since that's the
458 VIRT_ADDR_VARIES behavior.
459 (PURE_POINTER_P): Use a single comparison, not two, for
460 consistency with the new puresize.h.
461 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
462 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
463 Remove VIRT_ADDR_VARIES no longer needed.
465 2011-11-19 Eli Zaretskii <eliz@gnu.org>
467 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
468 (erase_phys_cursor, update_window_cursor, show_mouse_face)
469 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
470 behave as if the cursor position were at the window margin.
472 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
473 and the cursor position is out of bounds, behave as if the cursor
474 position were at the window margin. (Bug#10075)
476 2011-11-18 Chong Yidong <cyd@gnu.org>
478 * window.c (Fwindow_combination_limit): Make first argument
479 non-optional, since it is meaningless for live windows like the
482 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
484 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
486 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
488 * intervals.c: Fix grafting over the whole buffer (bug#10071).
489 (graft_intervals_into_buffer): Simplify.
491 2011-11-18 Eli Zaretskii <eliz@gnu.org>
493 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
494 hash values of the two rows.
495 (copy_row_except_pointers): Preserve the used[] arrays and the
496 hash values of the two rows. (Bug#10035)
497 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
499 * xdisp.c (row_hash): New function, body extracted from
500 compute_line_metrics.
501 (compute_line_metrics): Call row_hash, instead of computing the
504 * dispnew.c (verify_row_hash): Call row_hash for computing the
505 hash code of a row, instead of duplicating code from xdisp.c.
507 * dispextern.h (row_hash): Add prototype.
509 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
511 * frame.c (delete_frame): Don't delete the terminal when the last
512 X frame is closed if emacs is built with GTK toolkit.
514 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
516 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
518 2011-11-17 Martin Rudalics <rudalics@gmx.at>
520 * window.c (Vwindow_splits): Rename to
521 Vwindow_combination_resize. Suggested by Juri Linkov.
522 (Fsplit_window_internal): Use Vwindow_combination_resize instead
525 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
527 * nsfns.m (Fns_font_name):
528 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
530 2011-11-16 Martin Rudalics <rudalics@gmx.at>
532 * window.h (window): Rename slot "nest" to "combination_limit".
533 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
534 (Fset_window_nest): Rename to Fset_window_combination_limit.
535 (Vwindow_nest): Rename to Vwindow_combination_limit.
536 (recombine_windows, make_parent_window, make_window)
537 (Fsplit_window_internal, saved_window)
538 (Fset_window_configuration, save_window_save): Rename all
539 occurrences of window_nest to window_combination_limit.
541 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
543 * image.c (imagemagick_load_image): Fix typo.
545 2011-11-14 Eli Zaretskii <eliz@gnu.org>
547 * xdisp.c (display_line): Move the call to
548 highlight_trailing_whitespace before the call to
549 compute_line_metrics, since the latter needs to see the final
550 faces of all the glyphs to compute ROW's hash value.
551 Fixes assertion violations in row_equal_p. (Bug#10035)
553 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
555 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
556 just return (bug#10044).
558 2011-11-12 Eli Zaretskii <eliz@gnu.org>
560 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
561 with user-defined heap size. Bump the default size of the temacs
562 heap to 27MB, to avoid memory warning when running temacs.
563 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
565 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
566 current_matrix and desired_matrix. (Bug#9990)
567 (verify_row_hash) [XASSERTS]: New function.
568 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
569 that the hash value of glyph rows is correct.
571 2011-11-12 Martin Rudalics <rudalics@gmx.at>
573 * window.h (window): Remove splits slot.
574 * window.c (Fwindow_splits, Fset_window_splits): Remove.
575 (Fdelete_other_windows_internal, make_parent_window)
576 (make_window, Fsplit_window_internal, Fdelete_window_internal)
577 (Fset_window_configuration, save_window_save): Don't deal with
578 split status of windows.
579 (saved_window): Remove splits slot.
580 (Vwindow_splits): Rewrite doc-string.
582 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
584 * xfns.c (unwind_create_frame):
585 * nsfns.m (unwind_create_frame):
586 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
587 Vframe_list (Bug#9999).
589 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
591 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
593 2011-11-11 Kenichi Handa <handa@m17n.org>
595 * callproc.c (Fcall_process): Set the member dst_multibyte of
598 2011-11-11 Johan Bockgård <bojohan@gnu.org>
600 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
601 avoid a crash (bug#9496).
603 2011-11-09 Chong Yidong <cyd@gnu.org>
605 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
606 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
608 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
610 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
612 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
614 Avoid some portability problems by eschewing 'extern inline' functions.
615 The trivial performance wins aren't worth the portability hassles; see
616 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
618 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
619 (window_box_width, window_box_left, window_box_left_offset)
620 (window_box_right, window_box_right_offset): Undo previous change,
621 by removing the "extern"s.
622 * intervals.c (adjust_intervals_for_insertion)
623 (adjust_intervals_for_deletion): Undo previous change,
624 making these static again.
625 (offset_intervals, temp_set_point_both, temp_set_point)
626 (copy_intervals_to_string): No longer inline.
627 * xdisp.c (window_text_bottom_y, window_box_width)
628 (window_box_height, window_box_left_offset)
629 (window_box_right_offset, window_box_left, window_box_right)
630 (window_box): No longer inline.
632 2011-11-08 Chong Yidong <cyd@gnu.org>
634 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
635 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
636 Signal an error if not a live window.
637 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
638 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
640 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
642 * lisp.h (syms_of_abbrev): Remove declaration.
643 Reported by CHENG Gao <chenggao@royau.me>.
645 2011-11-07 Eli Zaretskii <eliz@gnu.org>
647 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
648 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
649 of temacs in GUI mode.
651 2011-11-07 Martin Rudalics <rudalics@gmx.at>
653 * window.h: Declare delete_all_child_windows instead of
654 delete_all_subwindows.
655 * window.c (Fwindow_nest, Fset_window_nest)
656 (Fset_window_new_total, Fset_window_new_normal)
657 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
658 (delete_all_subwindows): Rename to delete_all_child_windows.
659 (Fdelete_other_windows_internal, Fset_window_configuration):
660 Call delete_all_child_windows instead of delete_all_subwindows.
661 * frame.c (delete_frame): Call delete_all_child_windows instead
662 of delete_all_subwindows.
664 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
666 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
667 This is also needed for porting to any host where GC_MARK_STACK is
668 not GC_MAKE_GCPROS_NOOPS.
669 (which_symbols): Use it.
671 2011-11-07 Kenichi Handa <handa@m17n.org>
673 * coding.c (coding_set_destination): Check coding->src_pos only
674 when coding->src_object is a buffer (bug#9910).
676 * process.c (send_process): Set the member src_multibyte of coding
677 to 0 (bug#9911) when sending a unibyte text.
679 * callproc.c (Fcall_process): Set the member src_multibyte of
680 process_coding to 0 (bug#9912).
682 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
684 * xmenu.c (cleanup_widget_value_tree): New function.
685 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
686 calling free_menubar_widget_value_tree directly (Bug#9830).
688 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
690 Fix some portability problems with 'inline'.
691 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
692 (window_box_width, window_box_left, window_box_left_offset)
693 (window_box_right, window_box_right_offset): Declare extern.
694 Otherwise, these inline functions do not conform to C99 and
695 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
696 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
697 * intervals.c (adjust_intervals_for_insertion)
698 (adjust_intervals_for_deletion): Now extern, because otherwise the
699 extern inline functions 'offset_intervals' couldn't refer to it.
700 (static_offset_intervals): Remove.
701 (offset_intervals): Rewrite using the old contents of
702 static_offset_intervals. The old version didn't conform to C99
703 because an extern inline function contained a reference to an
704 identifier with static linkage.
706 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
708 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
711 2011-11-06 Eli Zaretskii <eliz@gnu.org>
713 * xdisp.c (init_iterator, reseat_to_string): Don't set the
714 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
715 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
716 return Qleft_to_right.
718 2011-11-06 Chong Yidong <cyd@gnu.org>
720 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
721 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
722 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
723 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
724 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
725 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
726 (Fwindow_vscroll): Doc fix.
727 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
728 argument, since it makes no sense to pass a live window and for
729 consistency with window-child.
731 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
733 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
736 2011-11-05 Jason Rumney <jasonr@gnu.org>
738 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
739 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
741 (add_font_entity_to_list): Fix logic errors in mixed boolean and
742 bitwise arithmetic preventing use of unicode-sip and non-truetype
745 2011-11-05 Eli Zaretskii <eliz@gnu.org>
747 * s/ms-w32.h (fstat, stat, utime): Move redirections to
750 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
751 initialization code to keep similarity to xfns.c after changes
754 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
756 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
757 (unwind_create_frame): New function (Bug#9943).
758 (Fx_create_frame): Restructure code to be more similar to the one in
759 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
760 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
761 Move terminal->reference_count++ just before making the frame official
764 * nsterm.m (x_free_frame_resources): New function.
765 (x_destroy_window): Move code to x_free_frame_resources.
767 * xfns.c (unwind_create_frame): Fix comment.
768 (Fx_create_frame, x_create_tip_frame):
769 Move terminal->reference_count++ just before making the frame
770 official. Move initialization of image_cache_refcount and
771 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
773 2011-11-05 Eli Zaretskii <eliz@gnu.org>
775 Support MSVC build with newer versions of Visual Studio.
776 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
777 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
780 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
781 which are not supported by MSVC.
782 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
783 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
785 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
787 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
789 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
791 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
793 Support MSVC build with newer versions of Visual Studio.
794 * w32.c: Don't include w32api.h for MSVC.
795 (init_environment) [_MSC_VER]: Call sys_access, not _access.
797 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
798 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
799 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
800 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
802 (alloca) [_MSC_VER]: Define to _alloca.
804 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
806 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
808 2011-11-04 Eli Zaretskii <eliz@gnu.org>
810 * xdisp.c (note_mouse_highlight): If either of
811 previous/next-single-property-change returns nil, treat that as
812 the beginning or the end of the buffer. (Bug#9955)
814 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
816 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
817 label is not null (Bug#9951).
818 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
821 2011-11-04 Eli Zaretskii <eliz@gnu.org>
823 * window.c (Fwindow_body_size): Mention in the doc string that the
824 return value is in frame's canonical units. (Bug#9949)
826 2011-11-03 Eli Zaretskii <eliz@gnu.org>
828 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
830 * w32fns.c (unwind_create_frame): If needed, free the glyph
831 matrices of the partially constructed frame. (Bug#9943)
832 * xfns.c (unwind_create_frame): Likewise.
834 2011-11-01 Eli Zaretskii <eliz@gnu.org>
836 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
837 Don't stop backward scan on the continuation glyph, even though
838 its CHARPOS is positive.
839 (mouse_face_from_buffer_pos, note_mouse_highlight):
840 Rename cover_string to disp_string.
842 2011-11-01 Martin Rudalics <rudalics@gmx.at>
844 * window.c (temp_output_buffer_show): Don't use
845 Vtemp_buffer_show_specifiers.
846 (Vtemp_buffer_show_specifiers): Remove unused variable.
848 2011-10-30 Eli Zaretskii <eliz@gnu.org>
850 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
851 past the beginning of the current glyph matrix.
853 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
855 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
856 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
857 HAVE_GTK3 (Bug#9869).
859 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
860 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
862 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
864 * xterm.c: Declare x_handle_net_wm_state to return int.
865 (handle_one_xevent): Check if we are iconified but don't have
866 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
867 (get_current_wm_state): Return non-zero if not hidden,
868 check for _NET_WM_STATE_HIDDEN (Bug#9893).
869 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
870 (x_handle_net_wm_state): Return what get_current_wm_state returns.
871 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
873 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
875 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
876 so that this new function doesn't get optimized away by a
877 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
879 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
881 * frame.h (MOUSE_HL_INFO): Remove excess parens.
883 2011-10-29 Eli Zaretskii <eliz@gnu.org>
885 Fix the `xbytecode' command.
886 * .gdbinit (xprintbytestr): New command.
887 (xwhichsymbols): Rename from `which'; all callers changed.
888 (xbytecode): Print the byte-code string as well.
890 2011-10-29 Kim Storm <storm@cua.dk>
892 * alloc.c (which_symbols): New function.
894 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
896 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
899 2011-10-29 Glenn Morris <rgm@gnu.org>
901 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
902 Not clear what it was for, and it causes various bugs. (Bug#9839)
904 2011-10-28 Eli Zaretskii <eliz@gnu.org>
906 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
907 possible random value that matches one of those tested as
908 condition to clear the mouse face.
910 2011-10-28 Chong Yidong <cyd@gnu.org>
912 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
914 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
916 * window.c (make_window): Initialize phys_cursor_on_p.
918 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
920 * lisp.h (struct Lisp_Symbol): Update comments.
922 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
924 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
926 2011-10-28 Eli Zaretskii <eliz@gnu.org>
928 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
929 <oslsachem@gmail.com> for helping to debug this.
931 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
932 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
933 (g_b_init_get_glyph_outline_w): New static variables.
934 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
935 (GetGlyphOutlineW_Proc): New typedefs.
936 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
937 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
939 (w32font_open_internal, compute_metrics):
940 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
941 instead of calling the "wide" APIs directly.
943 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
945 * w32.h (syms_of_w32font): Add prototype.
947 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
949 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
950 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
951 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
952 (Fmove_to_window_line): Doc fix.
954 2011-10-27 Chong Yidong <cyd@gnu.org>
956 * process.c (make_process): Set gnutls_state to NULL.
958 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
959 non-NULL, regardless of GNUTLS_INITSTAGE.
960 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
961 an error. Set process slots as soon as we allocate them.
963 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
965 2011-10-27 Chong Yidong <cyd@gnu.org>
967 * gnutls.c (emacs_gnutls_deinit): New function.
968 Deallocate credentials structures as well as calling gnutls_deinit.
969 (Fgnutls_deinit, Fgnutls_boot): Use it.
971 * process.c (make_process): Initialize GnuTLS credentials to NULL.
972 (deactivate_process): Call emacs_gnutls_deinit.
974 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
976 * image.c (x_create_x_image_and_pixmap):
977 * w32.c (sys_rename, w32_delayed_load):
978 * w32font.c (fill_in_logfont):
979 * w32reg.c (x_get_string_resource): Silence compiler warnings.
981 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
983 * w32fns.c (w32_default_color_map): New function,
984 extracted from Fw32_default_color_map.
985 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
987 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
989 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
991 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
993 * keyboard.c (test_undefined): New function (bug#9751).
994 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
996 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
998 * sysdep.c (init_sys_modes): Fix the check for the controlling
1001 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1003 * dispextern.h (struct bidi_it): New member next_en_type.
1005 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1006 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1007 current character, check also for next_en_type being WEAK_EN.
1008 (bidi_resolve_weak): Don't enter the expensive loop if the current
1009 position is before next_en_pos. Record the bidi type of the first
1010 non-ET, non-BN character we find, in addition to its position.
1011 (bidi_level_of_next_char): Invalidate next_en_type when
1012 next_en_pos is over-stepped.
1014 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1016 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1017 * editfns.c: Rewrite current-time-zone so that it invokes
1018 the equivalent of (format-time-string "%Z") to get the time zone name.
1019 This fixes a bug when the time zone name contains characters that
1020 need converting from the system time locale to Emacs internal format.
1021 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1022 that patch fixed format-time-string to do the conversion, but
1023 I forgot to fix current-time-zone.
1024 (format_time_string): New function, containing most of
1025 what Fformat_time_string used to contain.
1026 (Fformat_time_string): Rewrite in terms of format_time_string.
1027 This doesn't change this function's behavior.
1028 (current-time-zone): Rewrite to use format_time_string.
1029 This fixes the bug reported by Michael Schierl in
1030 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1031 Jason Rumney's 2007-06-07 change worked around this bug, but
1033 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1035 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1037 * xdisp.c (start_display): If the character at POS is displayed
1038 via a display vector, reset IT->current.dpvec_index to zero.
1039 (try_window_reusing_current_matrix): If a line ends in a display
1040 vector or the next line starts in a display vector, continue
1041 redrawing the window even though the character position of
1042 start_row was reached.
1045 2011-10-18 Chong Yidong <cyd@gnu.org>
1047 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1048 with nobreak-char-display too.
1050 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1052 Fix part 3 of bug#9771.
1053 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1054 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1055 non-neutral characters if the current character is a paragraph
1056 separator (a.k.a. Newline). This avoids running the same
1057 expensive loop twice, once when we consume the preceding newline
1058 and the other time when the line actually needs to be displayed.
1059 Avoid the loop when we see neutrals on the base embedding level
1060 following a character whose directionality is the same as the
1061 paragraph's. This avoids running the expensive loop when a line
1062 ends in a long sequence of neutrals, like control characters.
1063 Add assertion against STRONG_AL type. Slightly rearrange code
1064 that determines the type of a neutral given the first non-neutral
1066 (bidi_level_of_next_char): Set next_en_pos to zero when
1067 invalidating its info.
1069 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1071 * xdisp.c (push_display_prop): Determine whether to record string
1072 or buffer position by IT->string, not by IT->method. Allow
1073 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1074 (move_it_vertically_backward): Don't look for character position
1075 immediately after the newline when in a continuation line.
1078 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1080 * window.c (coordinates_in_window): Rewrite and delabelize
1081 vertical border check. (Bug#5357) (Bug#9618)
1083 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1085 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1086 errors in XSetWindowBorder (bug#9310).
1088 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1090 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1091 avoid crash when xmalloc overrun checking is enabled.
1093 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1095 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1096 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1097 cursor motion with <left> and <right> arrow keys.
1099 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1100 some callers set that themselves.
1102 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1104 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1105 display string and the previous row comes from the same string and
1106 is empty. (Bug#9739) (Bug#9738)
1108 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1110 * doc.c (get_doc_string): Encode file name (bug#9735).
1112 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1114 * bidi.c (bidi_level_of_next_char):
1115 * xdisp.c (get_visually_first_element): Remove old incorrect
1116 comments regarding the Unicode Line Separator character.
1118 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1120 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1122 * alloc.c (Fgc_status): Do not access beyond zombies array
1123 boundary if nzombies > MAX_ZOMBIES.
1124 * alloc.c (dump_zombies): Add missing format specifier.
1126 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1128 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1129 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1131 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1132 Some packages use them to denote characters with modifiers.
1134 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1136 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1137 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1138 matching a pp-number. Rename parameter var to var1.
1140 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1142 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1144 2011-10-08 Glenn Morris <rgm@gnu.org>
1146 * callint.c (Fcall_interactively): Give a more explicit error for the
1147 'c' case with a non-character input. (Bug#8479)
1149 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1151 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1153 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1154 lines that are hscrolled on the left.
1156 * dispnew.c (buffer_posn_from_coords): Account for a possible
1157 presence of header-line. (Bug#4426)
1159 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1161 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1162 Don't advertise functionality which we discourage or doesn't work.
1164 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1166 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1167 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1168 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1169 this makes Emacs dump core during garbage collection on rare
1170 occasions. sizeof is obviously inferior to offsetof here, so
1171 stick with offsetof.
1172 (GC_POINTER_ALIGNMENT): New macro.
1173 (mark_memory): Omit 3rd (offset) arg; caller changed.
1174 Don't assume EMACS_INT alignment is the same as pointer alignment.
1176 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1178 * keyboard.c (read_key_sequence_remapped): New var.
1179 (read_key_sequence): Compute remapping in the right buffer.
1180 (command_loop_1): Use read_key_sequence's remapping directly.
1182 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1184 * dired.c (file_name_completion): Don't expand file name.
1185 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1186 before checking file name handler.
1188 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1189 they've been requested explicitly (bug#9591).
1191 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1193 * keymap.c (Fsingle_key_description): Use make_specified_string
1194 instead of build_string to build string from push_key_description.
1197 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1199 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1200 This fixes a Y2038 bug on 64-bit hosts.
1201 * buffer.c (reset_buffer):
1202 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1203 (Fclear_buffer_auto_save_failure):
1204 Use 0, not -1, to represent an unset failure time, since time_t
1205 might not be signed.
1207 Remove dependency on glibc malloc internals.
1208 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1209 Move back here from lisp.h, but with their new implementations.
1210 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1211 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1212 * charset.c (charset_table_init): New static var.
1213 (syms_of_charset): Use it instead of xmalloc. This removes a
1214 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1215 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1216 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1217 Move back to alloc.c.
1218 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1219 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1221 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1223 * nsterm.m (windowDidResize): Call x_set_window_size only when
1224 ns_in_resize is true. Otherwise set pixelwidth/height and
1225 call change_frame_size (Bug#9628).
1227 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1229 Port --enable-checking=all to Fedora 14 x86-64.
1230 * charset.c (syms_of_charset): Also account for glibc malloc's
1231 internal overhead when calculating the initial malloc maximum.
1233 Port --enable-checking=all to Fedora 14 x86.
1234 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1236 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1237 (overrun_check_realloc, overrun_check_free):
1238 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1239 That way, xmalloc returns a properly-aligned pointer even if
1240 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1241 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1242 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1243 into account when calculating the initial malloc maximum.
1244 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1245 Move here from alloc.c, so that charset.c can use it too.
1246 Properly align; the old code wasn't right for common 32-bit hosts
1247 when configured with --enable-checking=all.
1248 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1249 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1251 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1253 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1256 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1258 * xdisp.c (compute_display_string_end): If there's no display
1259 string at CHARPOS, return -1.
1261 * bidi.c (bidi_fetch_char): When compute_display_string_end
1262 returns a negative value, treat the character as a normal
1263 character not covered by a display string. (Bug#9624)
1265 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1267 * lread.c (Fread_from_string): Fix typo in docstring.
1269 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1271 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1272 newline, reseat the iterator instead of bidi-iterating there one
1273 character at a time. (Bug#9610)
1274 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1275 TO_CHARPOS if the bidi iterator is at base embedding level.
1277 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1279 * lread.c (readevalloop): Use correct code for NBSP.
1280 (read1): Likewise. (Bug#9608)
1282 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1284 * dbusbind.c (Fdbus_register_signal): When service is not
1285 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1287 2011-09-25 Glenn Morris <rgm@gnu.org>
1289 * buffer.c (truncate-lines): Doc fix.
1291 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1293 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1294 (Fset_window_next_buffers): Doc fix.
1296 2011-09-24 Glenn Morris <rgm@gnu.org>
1298 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1300 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1302 Fix minor problems found by static checking.
1303 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1304 * indent.c (Fvertical_motion): Fix == vs = typo.
1306 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1308 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1309 Default value is now t. Doc fix.
1311 * indent.c (Fvertical_motion): Compute and apply the overshoot
1312 logic when moving up, not only when moving down. Fix the
1313 confusing name and values of the it_overshoot_expected variable;
1314 logic changes accordingly. (Bug#9254) (Bug#9549)
1316 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1317 CHARPOS is covered by a display string which includes newlines.
1318 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1319 is covered by a display string with embedded newlines.
1321 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1323 * dbusbind.c (Fdbus_register_signal): Add match rule to
1324 Vdbus_registered_objects_table. (Bug#9581)
1325 (Fdbus_register_method, Vdbus_registered_objects_table):
1328 2011-09-24 Jim Meyering <meyering@redhat.com>
1330 do not ignore write error for any output size
1331 The previous change was incomplete.
1332 While it makes emacs --batch detect the vast majority of stdout
1333 write failures, errors were still ignored whenever the output size is
1334 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1335 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1336 && echo FAIL: ignored write error
1337 FAIL: ignored write error
1338 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1339 && echo FAIL: ignored write error
1340 FAIL: ignored write error
1341 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1343 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1345 * emacs.c (Fkill_emacs): In noninteractive mode exit
1346 non-successfully if a write error occurred on stdout. (Bug#9574)
1348 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1350 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1353 * dispextern.h (struct it): Update the comment documenting what
1356 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1358 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1359 a display string, extend search for cursor position to end of row.
1360 (find_row_edges): If the row ends in a newline from a display
1361 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1362 Handle the case of a display string with multiple newlines.
1363 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1364 non-empty line. Fixes confusing cursor motion with arrow keys at
1365 the beginning of a line that starts with whitespace.
1367 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1369 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1372 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1374 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1377 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1379 * xdisp.c (display_line): Record maximum and minimum buffer
1380 positions even if no glyphs were produced (e.g., by a zero-width
1381 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1382 buffer positions that will be removed from the glyph row because
1384 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1385 column is beyond frame width: don't subtract 1 "pixel" when
1386 computing width of the stretch.
1387 (reseat_at_next_visible_line_start): Undo the change made on
1388 2011-09-17 that saved paragraph information and restored it after
1389 the call to `reseat'. (Bug#9545)
1391 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1393 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1394 and turn window cursor on if cleared (Bug#9415).
1396 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1398 * search.c (boyer_moore): Take unibyte characters from pattern
1399 literally. (Bug#9458)
1401 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1403 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1405 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1407 Fix minor problem found by static checking.
1408 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1409 initialized, to pacify gcc -Wuninitialized.
1411 * fileio.c: Report proper errno when syscall falls.
1412 (Finsert_file_contents): Save and restore errno,
1413 so that report_file_error outputs the correct diagnostic.
1414 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1416 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1418 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1420 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1422 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1423 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1425 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1427 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1428 about the current paragraph and restore it after the call to reseat.
1430 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1431 (bidi_find_paragraph_start): Search back for paragraph beginning
1432 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1433 (bidi_move_to_visually_next): Only trigger paragraph-related
1434 computations when the last character is a newline or at EOB, not
1435 just any NEUTRAL_B. (Bug#9470)
1437 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1438 truncated lines if point is covered by a display string. (Bug#9524)
1440 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1442 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1443 (cons_to_x_long): New function.
1444 (lisp_data_to_selection_data): Use it. Correct the test for
1445 short-versus-long data; it was negated. Break out of vector
1446 loop, for efficiency, when a long datum is discovered.
1448 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1450 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1452 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1454 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1455 GCC PR/17406) by declaring this function with external scope.
1457 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1459 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1460 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1462 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1464 * editfns.c (Fformat): Correctly handle text properties on "%%".
1466 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1468 * xterm.c (x_draw_composite_glyph_string_foreground):
1469 * w32term.c (x_draw_composite_glyph_string_foreground):
1470 * term.c (encode_terminal_code):
1471 * composite.c (composition_update_it, get_composition_id):
1472 * xdisp.c (get_next_display_element)
1473 (fill_composite_glyph_string): Add comments about special meaning
1474 of TAB characters in a composition.
1476 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1478 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1479 This occurs when processing a multibyte format.
1480 Problem reported by Wolfgang Jenker.
1482 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1484 * xdisp.c (try_cursor_movement): Only check for exact match if
1485 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1487 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1489 Remove unused external symbols.
1490 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1491 * xdisp.c (calc_pixel_width_or_height): Now static.
1492 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1493 * indent.c (check_display_width):
1494 * w32term.c: Fix comment to match code.
1495 * xterm.c, xterm.h (x_catching_errors): Remove.
1497 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1499 * xselect.c: Use signed conversions more consistently (Bug#9498).
1500 (selection_data_to_lisp_data): Assume incoming selection data are
1501 signed integers, not unsigned. This is to be consistent with
1502 outgoing selection data, which was modified to use signed integers
1503 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1504 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1505 expects long, not unsigned long.
1507 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1509 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1510 computation of loop end. Reported by Johan Bockgård
1513 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1515 * frame.c (Fother_visible_frames_p): Function deleted.
1517 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1519 * indent.c (compute_motion): Process display vector front to back
1520 rather than the other way around. (Bug#2496)
1522 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1524 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1526 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1528 * minibuf.c (Fread_from_minibuffer): Doc fix.
1530 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1532 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1533 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1535 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1537 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1538 value for non-existent files.
1540 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1542 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1543 set its "size" to -1. This will set the modtime_size field of
1544 the corresponding buffer to -1, which is what
1545 verify-visited-file-modtime expects for files that do not exist.
1548 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1550 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1552 * lisp.h: ... from here. push_key_description is no longer
1553 defined in keyboard.c, so its declaration should not be in
1554 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1555 logically belongs with push_key_description.
1557 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1559 * buffer.h: Include <sys/types.h> instead of <time.h>.
1560 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1561 Problem reported by Herbert J. Skuhra.
1563 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1565 * xml.c (parse_region): Make the parsing work for
1566 non-comment-starting XML files again (bug#9144).
1568 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1570 * image.c (gif_load): Fix calculation of bottom and right corner.
1573 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1575 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1576 redisplay in small windows.
1578 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1580 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1582 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1584 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1585 Operate on live windows only.
1587 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1589 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1591 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1593 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1594 only under bidi iteration.
1596 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1598 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1600 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1602 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1603 Without this fix, the command to link temacs failed due to an
1604 undefined symbol __builtin_isnan. This is because
1605 /usr/include/iso/math_c99.h #defines isnan(x) to
1606 __builtin_isnan(x), but the bundled gcc, which identifies itself
1607 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1609 * floatfns.c (isnan): #undef, and then #define to a clone of
1611 (Fisnan): Always define, since it's always available now.
1612 (syms_of_floatfns): Always define isnan at the Lisp level.
1614 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1616 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1618 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1620 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1621 The previous code assumed that file offsets (off_t values) fit in
1622 EMACS_INT variables, which is not true on typical 32-bit hosts.
1623 The code messed up by falsely reporting buffer overflow in cases
1624 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1625 when "big" contains more than 2**29 bytes, even though this
1626 inserts just one byte and does not overflow the buffer.
1627 (Finsert_file_contents): Store file offsets as off_t
1628 values, not as EMACS_INT values. Check for overflow when
1629 converting between EMACS_INT and off_t. When checking for
1630 buffer overflow or for overlap, take the offsets into account.
1631 Don't use EMACS_INT for small values where int suffices.
1632 When checking for overlap, fix a typo: ZV was used where
1633 ZV_BYTE was intended.
1634 (Fwrite_region): Don't assume off_t fits into 'long'.
1635 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1637 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1639 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1641 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1643 sprintf-related integer and memory overflow issues (Bug#9412).
1645 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1646 (esprintf, exprintf, evxprintf): New functions.
1647 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1648 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1649 (modify_event_symbol): Do not assume that the length of
1650 name_alist_or_stem is safe to alloca and fits in int.
1651 (Fexecute_extended_command): Likewise for function name and binding.
1652 (Frecursion_depth): Wrap around reliably on integer overflow.
1653 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1654 since some callers pass EMACS_INT values.
1655 (Fsingle_key_description): Don't crash if symbol name contains more
1656 than MAX_ALLOCA bytes.
1657 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1658 (get_minibuffer): Arg is now EMACS_INT, not int.
1659 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1660 (esprintf, exprintf, evxprintf): New decls.
1661 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1663 * dbusbind.c (signature_cat): New function.
1664 (xd_signature, Fdbus_register_signal):
1665 Do not overrun buffer; instead, report string overflow.
1667 * dispnew.c (add_window_display_history): Don't overrun buffer.
1668 Truncate instead; this is OK since it's just a log.
1670 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1671 even if the time zone offset is outlandishly large.
1672 Don't mishandle offset == INT_MIN.
1674 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1675 when creating daemon; the previous buffer-overflow check was incorrect.
1677 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1678 which has the guts of the old verror function.
1680 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1681 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1683 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1684 (font_unparse_xlfd): Don't blindly alloca long strings.
1685 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1686 fits in int, when using sprintf. Use single snprintf to count
1687 length of string rather than counting it via multiple sprintfs;
1688 that's simpler and more reliable.
1689 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1690 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1691 sprintf, in case result does not fit in int.
1693 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1694 (fontset_from_font): Print it.
1696 * frame.c (tty_frame_count): Now printmax_t, not int.
1697 (make_terminal_frame, set_term_frame_name): Print it.
1698 (x_report_frame_params): In X, window IDs are unsigned long,
1699 not signed long, so print them as unsigned.
1700 (validate_x_resource_name): Check for implausibly long names,
1701 and don't assume name length fits in 'int'.
1702 (x_get_resource_string): Don't blindly alloca invocation name;
1703 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1706 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1707 (xg_check_special_colors, xg_set_geometry):
1708 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1710 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1711 Use esprintf, not sprintf, in case result does not fit in int.
1713 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1714 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1715 it as a large positive number.
1716 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1717 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1719 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1720 in case result does not fit in int.
1722 * print.c (float_to_string): Detect width overflow more reliably.
1723 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1724 buffer overrun. Don't assume list length fits in 'int'. Treat
1725 print length of 0 as 0, not as infinity; to be consistent with other
1726 uses of print length in this function. Don't overflow print length
1727 index. Don't assume hash table size fits in 'long', or that
1728 vectorlike size fits in 'unsigned long'.
1730 * process.c (make_process): Use printmax_t, not int, to format
1731 process-name gensyms.
1733 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1735 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1736 to avoid potential buffer overrun.
1738 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1739 if X resource line is longer than 512 bytes.
1741 * xfns.c (x_window): Make sprintf buffer a bit bigger
1742 to avoid potential buffer overrun.
1744 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1746 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1748 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1750 Integer overflow fixes for scrolling, etc.
1751 Without these, Emacs silently mishandles large integers sometimes.
1752 For example, "C-u 4294967297 M-x recenter" was treated as if
1753 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1755 * xdisp.c (try_window_id): Check Emacs fixnum range before
1756 converting to 'int'.
1758 * window.c (window_scroll_line_based, Frecenter):
1759 Check that an Emacs fixnum is in range before assigning it to 'int'.
1760 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1761 values converted from Emacs fixnums.
1762 (Frecenter): Don't wrap around a line count if it is out of 'int'
1763 range; instead, treat it as an extreme value.
1764 (Fset_window_configuration, compare_window_configurations):
1765 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1767 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1768 that can exceed INT_MAX. Check that EMACS_INT value is in range
1769 before assigning it to the (possibly-narrower) index.
1770 (match_limit): Don't assume that a fixnum can fit in 'int'.
1772 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1775 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1776 (Fvertical_motion): Don't wrap around LINES values that don't fit
1777 in 'int'. Instead, treat them as extreme values. This is good
1778 enough for windows, which can't have more than INT_MAX lines anyway.
1780 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1782 * Require libxml/parser.h to avoid compilation warning.
1784 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1786 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1787 since this reportedly can destroy thread storage.
1789 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1791 * syntax.c (find_defun_start): Update all cache variables if
1792 exiting early (Bug#9401).
1794 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1796 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1798 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1799 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1800 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1802 * term.c (tty_append_glyph): New function.
1803 (produce_stretch_glyph): Static function and its prototype deleted.
1805 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1808 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1810 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1811 when checking :margin (Bug#9390).
1812 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1813 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1814 so that the name doesn't mislead. All uses changed.
1816 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1818 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1821 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1823 * xdisp.c (move_it_to): Don't bail out early when reaching
1824 position beyond to_charpos, if we are scanning backwards.
1825 (move_it_vertically_backward): When DY == 0, make sure we get to
1826 the first character in the line after the newline.
1828 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1830 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1831 (ccl_driver): Do not generate an out-of-range pointer.
1832 (Fccl_execute_on_string): Remove unnecessary check for
1833 integer overflow, noted by Stefan Monnier in
1834 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1835 Remove a FIXME that didn't need fixing.
1836 Simplify the newly-introduced buffer reallocation code.
1838 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1840 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1842 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1844 Integer and memory overflow issues (Bug#9196).
1846 * doc.c (get_doc_string): Rework so that
1847 get_doc_string_buffer_size is the actual buffer size, rather than
1848 being 1 less than the actual buffer size; this makes xpalloc more
1851 * image.c (x_allocate_bitmap_record, cache_image):
1852 * xselect.c (Fx_register_dnd_atom):
1853 Simplify previous changes by using xpalloc.
1855 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1856 since either will do and ptrdiff_t is convenient with xpalloc.
1858 * charset.c (charset_table_size)
1859 (struct charset_sort_data.priority): Now ptrdiff_t.
1860 (charset_compare): Don't overflow if priorities differ greatly.
1861 (Fsort_charsets): Don't assume list length fits in int.
1862 Check for size-calculation overflow when allocating sort data.
1863 (syms_of_charset): Allocate an initial charset table that is
1864 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1866 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1868 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1869 The actual value is always <= INT_MAX, and leaving it unsigned made
1870 overflow checking harder.
1872 * dispextern.h (struct glyph_matrix.rows_allocated)
1873 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1874 with xpalloc. The values are still always <= INT_MAX.
1876 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1878 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1879 (SAFE_NALLOCA): New macro.
1881 * region-cache.c (struct boundary.pos, find_cache_boundary)
1882 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1883 (set_cache_region, invalidate_region_cache)
1884 (revalidate_region_cache, know_region_cache, region_cache_forward)
1885 (region_cache_backward, pp_cache):
1886 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1887 so that ptrdiff_t * can be passed to xpalloc.
1888 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1889 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1890 (pp_cache): Don't assume cache_len fits in int.
1891 * region-cache.h: Adjust extern decls to match.
1893 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1894 EMACS_INT, since either will do, for xpalloc.
1896 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1897 (xnmalloc, xnrealloc, xpalloc): New functions.
1899 * bidi.c (bidi_shelve_header_size): New constant.
1900 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1901 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1903 * bidi.c (bidi_cache_shrink):
1904 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1906 Don't update size of array until after memory allocation succeeds,
1907 because xmalloc/xrealloc may not return.
1908 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1909 now that we have proper integer overflow checking.
1910 (record_overlay_string, overlay_strings): Catch overflows when
1911 calculating size of overlay_str_buf.
1913 * callproc.c (Fcall_process): Check for size overflow when
1914 calculating size of args2.
1915 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1916 Normally we prefer signed values, but sticking with ptrdiff_t would
1917 require adding more-complicated checks.
1919 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1920 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1921 Redo buffer-overflow calculations to avoid integer overflow.
1922 Add a FIXME comment where memory seems to be over-allocated.
1924 * character.c (Fstring): Check for size-calculation overflow.
1926 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1927 unnecessary integer overflow. Check for size overflow.
1928 (encode_coding_object): Don't update size until xmalloc succeeds.
1930 * composite.c (get_composition_id): Check for overflow in glyph
1931 length calculations.
1933 Integer and memory overflow fixes for display code.
1934 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1935 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1936 (scrolling_window): Check for overflow in size calculations.
1937 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1938 Don't assume glyph table len fits in int.
1939 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1940 (row_table_size): Now ptrdiff_t, not int.
1941 (scrolling_window): Avoid overflow in size calculations.
1942 Don't update size until allocation succeeds.
1943 * fns.c (concat): Check for overflow in size calculations.
1944 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1945 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1946 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1948 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1949 (get_doc_string): Check for size calculation overflow.
1950 Don't update size until allocation succeeds.
1951 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1952 EMACS_INT, where ptrdiff_t will do.
1953 (Fsubstitute_command_keys): Check for string overflow.
1955 * editfns.c (set_time_zone_rule): Don't assume environment length
1957 (message_length): Now ptrdiff_t, not int.
1958 (Fmessage_box): Don't update size until allocation succeeds.
1959 Don't assume message length fits in int.
1960 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1962 * emacs.c (main): Do not reallocate argv, since there is a null at
1963 the end that can be overwritten, and this way there's no need to
1964 worry about size-calculation overflow.
1965 (sort_args): Check for size-calculation overflow.
1967 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1969 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1971 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1972 (x_set_scroll_bar_width, x_figure_window_size):
1973 Check for integer overflow.
1974 (x_set_alpha): Do not assume XINT fits in int.
1976 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1977 This is for the members text_lines, text_cols, total_lines, total_cols,
1978 where the system imposes an 'int' limit.
1980 * fringe.c (Fdefine_fringe_bitmap):
1981 Don't update size until alloc works.
1983 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1984 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1986 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1987 Check for size-calculation overflow.
1988 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1989 do, as we prefer signed integers.
1990 (id_to_widget.max_size, id_to_widget.used)
1991 (xg_store_widget_in_map, xg_remove_widget_from_map)
1992 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1993 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1994 Use and return ptrdiff_t, not int.
1995 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1996 * gtkutil.h: Change prototypes to match the above.
1998 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1999 are duplicate now that they've been promoted to lisp.h.
2000 (x_allocate_bitmap_record, x_alloc_image_color)
2001 (make_image_cache, cache_image, xpm_load):
2002 Don't update size until alloc is done.
2003 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2005 Check for size calculation overflow.
2006 (ct_colors_allocated_max): New constant.
2007 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2010 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2011 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2012 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2013 Use ptrdiff_t, not int, to count maps.
2014 (read_char_minibuf_menu_prompt): Check for overflow in size
2015 calculations. Don't update size until allocation succeeds.
2016 Redo calculations to avoid overflow.
2017 * keyboard.h: Change prototypes to match the above.
2019 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2021 (current_minor_maps): Check for size calculation overflow.
2022 * keymap.h: Change prototypes to match the above.
2024 * lread.c (read1, init_obarray): Don't update size until alloc done.
2026 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2027 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2029 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2030 Now ptrdiff_t, not int.
2031 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2032 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2034 * process.c (Fnetwork_interface_list): Check for overflow
2035 in size calculation.
2037 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2039 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2040 overflow. Don't bother calling xmalloc when xrealloc will do.
2042 * search.c (Freplace_match): Check for size calculation overflow.
2043 (Fset_match_data): Don't assume list lengths fit in 'int'.
2045 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2046 for command line length. Do not attempt to address one before the
2047 beginning of an array, as that's not portable.
2049 * term.c (max_frame_lines): Remove; unused.
2050 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2052 (encode_terminal_code, calculate_costs): Check for size
2053 calculation overflow.
2054 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2055 table lengths and related sizes. Don't update size until alloc
2056 done. Redo calculations to avoid overflow.
2057 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2059 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2060 subtracting pointers.
2061 (gobble_line): Check for overflow more carefully. Don't update size
2064 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2065 Don't update size until alloc done.
2066 Redo size calculations to avoid overflow.
2067 Check for size calculation overflow.
2068 (main) [DEBUG]: Fix typo in invoking tparam1.
2070 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2071 Use ptrdiff_t, not int, for sizes.
2072 (store_mode_line_noprop_char): Don't update size until alloc done.
2074 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2075 Use ptrdiff_t, not int, for sizes.
2076 (Finternal_make_lisp_face, cache_face):
2077 Check for size calculation overflow.
2078 (cache_face): Treat size calculation overflows as if they were
2079 memory exhaustion (the usual treatment), rather than aborting.
2081 * xfns.c (x_encode_text, x_set_name_internal)
2082 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2083 sizes, since they can exceed INT_MAX in size. Check for size
2084 calculation overflow.
2086 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2087 (xg_select): Check for size calculation overflow.
2088 Don't update size until alloc done.
2090 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2091 as sprintf is limited to int lengths.
2093 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2094 (X_LONG_MIN): New macros.
2095 Use them to make the following changes clearer.
2096 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2097 This change doesn't affect the value now, but it may help remind
2098 future maintainers not to raise the value too much later.
2099 (SELECTION_QUANTUM): Remove, replacing with ...
2100 (selection_quantum): ... new function, which avoids overflow.
2102 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2103 assumption that selection length fits in 'int'.
2104 (x_reply_selection_request, x_handle_selection_request)
2105 (x_get_window_property, receive_incremental_selection)
2106 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2107 (lisp_data_to_selection_data, clean_local_selection_data):
2108 Use ptrdiff_t, not int, to record length of selection.
2109 (x_reply_selection_request, x_get_window_property)
2110 (receive_incremental_selection, x_property_data_to_lisp):
2111 Redo calculations to avoid overflow.
2112 (x_reply_selection_request): When sending hint, ceiling it at
2113 X_LONG_MAX rather than relying on wraparound overflow to send
2115 (x_get_window_property, receive_incremental_selection)
2116 (lisp_data_to_selection_data, x_property_data_to_lisp):
2117 Check for size-calculation overflow.
2118 (x_get_window_property, receive_incremental_selection)
2119 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2120 Don't store size until memory allocation succeeds.
2121 (x_get_window_property): Plug memory leak on memory exhaustion.
2122 Don't double-block input; malloc is safe here. Don't assume 2**34
2123 - 4 fits in unsigned long. Add an xassert to check
2124 XGetWindowProperty overflow. Be more careful about overflow
2125 calculations, and distinguish size from memory overflow better.
2126 (receive_incremental_selection): When tracing, don't assume
2127 unsigned int is less than INT_MAX.
2128 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2129 harmful) conversions of unsigned short to int.
2130 (lisp_data_to_selection_data): Don't assume that integers
2131 in the range -65535 through -1 fit in an X unsigned short.
2132 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2133 result parameters unless successful. Rely on cons_to_unsigned
2134 to report problems with elements; the old code wasn't right anyway.
2135 (x_check_property_data): Check for int overflow; we cannot use
2136 a wider type due to X limits.
2137 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2139 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2141 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2142 (x_term_init): Check for size calculation overflow.
2143 (x_color_cells): Don't store size until memory allocation succeeds.
2144 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2145 Don't assume alloca size is less than MAX_ALLOCA.
2146 (x_term_init): Don't assume length fits in int (sprintf is limited
2149 Use ptrdiff_t for composition IDs.
2150 * character.c (lisp_string_width):
2151 * composite.c (composition_table_size, n_compositions)
2152 (get_composition_id, composition_gstring_from_id):
2153 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2154 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2155 * window.c (Frecenter):
2156 Use ptrdiff_t, not int, for composition IDs.
2157 * composite.c (get_composition_id): Check for integer overflow.
2158 * composite.h: Adjust prototypes to match the above changes.
2160 Use ptrdiff_t for hash table indexes.
2161 * category.c (hash_get_category_set):
2162 * ccl.c (ccl_driver):
2163 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2164 * coding.c (coding_system_charset_list, detect_coding_system):
2165 * coding.h (struct coding_system.id):
2166 * composite.c (get_composition_id, gstring_lookup_cache):
2167 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2168 * image.c (xpm_get_color_table_h):
2169 * lisp.h (hash_lookup, hash_put):
2170 * minibuf.c (Ftest_completion):
2171 Use ptrdiff_t for hash table indexes, not int (which is too
2172 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2173 32-bit --with-wide-int hosts).
2175 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2176 Add a FIXME comment about memory leaks.
2177 (syms_of_charset): Don't assume xmalloc returns.
2179 Don't assume that stated character widths fit in int.
2180 * character.c (Fchar_width, c_string_width, lisp_string_width):
2181 * character.h (CHAR_WIDTH):
2182 * indent.c (MULTIBYTE_BYTES_WIDTH):
2183 Use sanitize_char_width to avoid undefined and/or bad behavior
2184 with outlandish widths.
2185 * character.h (sanitize_tab_width): Rename from sanitize_width,
2186 now that we have two such functions. All uses changed.
2187 (sanitize_char_width): New inline function.
2189 Don't assume that tab-width fits in int.
2190 * character.h (sanitize_width): New inline function.
2191 (SANE_TAB_WIDTH): New macro.
2192 (ASCII_CHAR_WIDTH): Use it.
2193 * indent.c (sane_tab_width): Remove. All uses replaced by
2194 SANE_TAB_WIDTH (current_buffer).
2195 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2197 * fileio.c: Integer overflow issues with file modes.
2198 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2200 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2201 Remove unreachable code.
2202 (read_hex, load_charset_map_from_file): Check for integer overflow.
2204 * xterm.c: don't go over XClientMessageEvent limit
2205 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2206 (x_send_scroll_bar_event): Likewise. Check that the size does not
2207 exceed limits imposed by XClientMessageEvent, as well as the usual
2208 ptrdiff_t and size_t limits.
2210 * keyboard.c: Overflow, signedness and related fixes.
2211 (make_lispy_movement): Use same integer type in forward decl
2212 that is used in the definition.
2213 (read_key_sequence, keyremap_step):
2214 Change bufsize argument back to int, undoing my 2011-03-30 change.
2215 We prefer signed types, and int is wide enough here.
2216 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2217 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2218 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2219 length, not size_t. Use ptrdiff_t for index, not int.
2220 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2221 possibility of integer overflow.
2223 Overflow, signedness and related fixes for images.
2225 * dispextern.h (struct it.stack[0].u.image.image_id)
2226 (struct_it.image_id, struct image.id, struct image_cache.size)
2227 (struct image_cache.used, struct image_cache.ref_count):
2228 * gtkutil.c (update_frame_tool_bar):
2229 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2230 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2231 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2232 * nsmenu.m (update_frame_tool_bar):
2233 * xdisp.c (calc_pixel_width_or_height):
2234 * xfns.c (image_cache_refcount):
2235 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2236 on typical 64-bit hosts.
2238 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2239 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2240 Omit unnecessary casts to int.
2241 (parse_image_spec): Check that integers fall into 'int' range
2242 when the callers expect that.
2243 (image_ascent): Redo ascent calculation to avoid int overflow.
2244 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2245 (lookup_image): Remove unnecessary tests.
2246 (xbm_image_p): Locals are now of int, not EMACS_INT,
2247 since parse_image_check makes sure they fit into int.
2248 (png_load, gif_load, svg_load_image):
2249 Prefer int to unsigned where either will do.
2250 (tiff_handler): New function, combining the cores of the
2251 old tiff_error_handler and tiff_warning_handler.
2252 This function is rewritten to use vsnprintf and thereby avoid
2253 stack buffer overflows. It uses only the features of vsnprintf
2254 that are common to both POSIX and native Microsoft.
2255 (tiff_error_handler, tiff_warning_handler): Use it.
2256 (tiff_load, gif_load, imagemagick_load_image):
2257 Don't assume :index value fits in 'int'.
2258 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2259 (imagemagick_load_image): Check that crop parameters fit into
2260 the integer types that MagickCropImage accepts. Don't assume
2261 Vimagemagick_render_type has a nonnegative value. Don't assume
2262 size_t fits in 'long'.
2263 (gs_load): Use printmax_t to print the widest integers possible.
2264 Check for integer overflow when computing image height and width.
2266 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2268 * xdisp.c (redisplay_window): Don't force window start if point
2269 will be invisible in the resulting window. (Bug#9324)
2271 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2273 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2274 the display spec is of the form `(space ...)'.
2275 (handle_display_spec): Return the value returned by
2276 handle_single_display_spec, not just 1 or zero.
2277 (handle_single_display_spec): If the display spec is of the form
2278 `(space ...)', and specifies display in the text area, return 2
2280 (try_cursor_movement): Check for the need to scroll more
2281 accurately, and prefer exact match for point under bidi.
2282 Don't advance `row' beyond the last row of the window.
2284 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2285 into disp_prop; all users changed.
2287 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2288 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2289 for the text covered by the display property.
2291 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2293 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2294 Change return value to nil.
2295 (Frecord_buffer): Delete unused function.
2297 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2299 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2300 buffers, return left-to-right.
2301 (set_cursor_from_row): Consider candidate row a win if its glyph
2302 represents a newline and point is on that newline. Fixes cursor
2303 positioning on the newline at EOL of R2L text within L2R
2304 paragraph, and vice versa.
2305 (try_cursor_movement): Check continued rows, in addition to
2306 continuation rows. Fixes unwarranted scroll when point enters a
2307 continued line of R2L text within an L2R paragraph, or vice versa.
2308 (cursor_row_p): Consider the case of point being equal to
2309 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2310 from the end of a short line to the beginning of a continued line
2311 of R2L text within L2R paragraph.
2312 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2313 composed characters.
2315 * bidi.c (bidi_check_type): Use xassert.
2316 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2319 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2321 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2324 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2326 * nsfont.m (ns_otf_to_script): Fix typo.
2328 2011-08-22 Kenichi Handa <handa@m17n.org>
2330 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2331 extra slot even if the purpose is char-code-property-table.
2333 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2335 * xdisp.c (redisplay_window): When computing centering_position,
2336 account for the height of the header line. (Bug#8874)
2338 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2339 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2340 candidate is selected by the mouse, and that candidate has a
2341 composed character under the mouse.
2343 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2344 coordinates reported by pos-visible-in-window-p for a composed
2345 character in column zero.
2347 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2349 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2351 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2353 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2354 consider it a hit if to_charpos is anywhere in the range of the
2355 composed buffer positions.
2357 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2359 * image.c (gif_load): Don't assume that each subimage has the same
2360 dimensions as the base image. Handle disposal method that is
2361 "undefined" by the gif spec (Bug#9335).
2363 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2365 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2366 (Fcondition_case): Document `debug' symbol in error handler.
2368 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2370 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2371 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2372 from an Org mode buffer to a Speedbar frame.
2374 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2375 a composition, take its buffer position from IT->cmp_it.charpos.
2376 Fixes cursor positioning at the beginning of a line that begins
2377 with a composed character.
2379 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2381 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2382 character bidirectional type, use STRONG_L instead. Fixes crashes
2383 in a buffer produced by `describe-categories'.
2385 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2386 members before the level stack, so they would be saved and
2387 restored when copying iterator state. Fixes incorrect reordering
2388 around TABs covered by display properties.
2390 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2392 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2394 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2396 * eval.c (internal_condition_case, internal_condition_case_1)
2397 (internal_condition_case_2, internal_condition_case_n):
2398 Remove unnecessary aborts (Bug#9081).
2400 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2402 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2403 has no `load' handler, try opening the file locally. (Bug#9311)
2405 2011-08-16 Ken Brown <kbrown@cornell.edu>
2407 * gmalloc.c: Expand comment.
2409 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2411 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2412 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2414 2011-08-16 Ken Brown <kbrown@cornell.edu>
2416 Fix memory allocation problems in Cygwin build (Bug#9273).
2418 * unexcw.c ( __malloc_initialized): Declare external variable.
2419 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2421 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2423 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2425 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2427 [CYGWIN] (special_realloc): New function.
2428 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2429 requests to realloc storage in the static heap.
2431 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2433 * bidi.c (bidi_initialize): Remove unused local.
2435 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2438 * biditype.h: Remove file.
2439 * makefile.w32-in ($(BLD)/bidi.$(O)):
2440 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2442 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2444 * chartab.c: Improve commentary for the uniprop_table API.
2446 * bidi.c (bidi_paragraph_init): Support zero value of
2447 bidi_ignore_explicit_marks_for_paragraph_level.
2448 (bidi_initialize): Use uniprop_table instead of including
2449 biditype.h and bidimirror.h.
2451 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2452 coordinates of the iterator when restoring from ppos_it.
2455 2011-08-14 Kenichi Handa <handa@m17n.org>
2457 * process.c (create_process): Call setup_process_coding_systems
2458 after the pid of the process is set to -1 (Bug#8162).
2460 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2462 * xdisp.c (move_it_in_display_line_to): Don't invoke
2463 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2464 ppos_it. Fixes vertical cursor motion when line beginning is
2465 covered by an image. (Bug#9296)
2467 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2469 * nsterm.h (ns_run_ascript): Declare.
2470 (NSAPP_DATA2_RUNASSCRIPT): Define.
2472 * nsfns.m (as_script, as_result, as_status): New static variables.
2473 (ns_run_ascript): New function.
2474 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2475 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2476 the event loop. Get status from as_status (Bug#7276).
2478 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2479 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2480 the event loop (Bug#7276).
2482 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2484 * gnutls.c (QCgnutls_bootprop_priority)
2485 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2486 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2487 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2488 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2489 (QCgnutls_bootprop_verify_hostname_error)
2490 (QCgnutls_bootprop_callbacks_verify): Rename from
2491 Qgnutls_bootprop_..., all uses changed.
2493 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2496 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2498 * xfaces.c (Qframe_set_background_mode): Now static.
2499 * dispextern.h (Qframe_set_background_mode): Remove decl.
2501 * process.c (Fnetwork_interface_info): Declare local only if needed.
2503 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2505 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2506 (Fnetwork_interface_list): Allocate in increments of bytes instead
2507 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2508 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2510 (struct ifflag_def): notrailers is smart on OSX.
2511 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2512 Get hardware address with getifaddrs if available.
2514 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2516 * xdisp.c (iterate_out_of_display_property): xassert that
2517 IT->position is set to within IT->object's boundaries. Break from
2518 the loop as soon as EOB is reached; avoids infloops in redisplay
2519 when IT->position is set up wrongly due to some bug.
2520 Set IT->current to match the bidi iterator unconditionally.
2521 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2522 entry. Force push_it to save on the stack the current
2523 buffer/string position, to be restored by pop_it. Fix flags in
2524 the iterator structure wrt the object coming from a display
2525 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2526 properties. (Bug#9284)
2528 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2530 * fontset.c (fontset_get_font_group): Add proper type checks.
2533 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2535 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2536 and LC_VERSION_MIN_MACOSX.
2537 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2538 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2540 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2542 * xdisp.c (forward_to_next_line_start): Allow to use the
2543 no-display-properties-and-no-overlays under bidi display.
2544 Set disp_pos in the bidi iterator to avoid searches for display
2545 properties and overlays.
2547 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2549 * editfns.c (Fset_time_zone_rule): Document relationship with the
2552 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2553 the font entity extracted from the cache (Bug#8109).
2555 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2557 * composite.c (autocmp_chars): Don't reset point. That is done by
2558 restore_point_unwind (Bug#5984).
2560 2011-08-07 Juri Linkov <juri@jurta.org>
2562 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2563 to show the arg `TIME' instead of `TIMEVAL'.
2565 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2567 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2568 display property strides EOL and includes a newline, as in
2569 longlines-mode. (Bug#9254)
2570 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2571 word-wrap under bidirectional display. (Bug#9224)
2573 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2574 is non-zero, even if the data buffer is NULL. Fixes a crash in
2575 vertical-motion with longlines-mode. (Bug#9254)
2577 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2579 * bidi.c <bidi_cache_total_alloc>: Now static.
2580 (bidi_initialize): Initialize bidi_cache_total_alloc.
2582 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2585 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2586 amount allocated this far in `bidi_cache_total_alloc'.
2587 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2588 non-zero, only free the data buffer without restoring the cache
2589 contents. All callers changed.
2591 * dispextern.h (bidi_unshelve_cache): Update prototype.
2593 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2594 (move_it_in_display_line, move_it_to)
2595 (move_it_vertically_backward, move_it_by_lines): Replace the call
2596 to xfree to an equivalent call to bidi_unshelve_cache.
2597 (move_it_in_display_line_to): Fix logic of returning
2598 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2600 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2602 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2603 came from a string character with a `cursor' property. (Bug#9229)
2605 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2607 * Makefile.in (LIB_PTHREAD): New variable.
2608 (LIBES): Add LIB_PTHREAD (Bug#9216).
2610 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2611 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2613 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2615 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2617 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2619 * xterm.c (x_find_topmost_parent): New function.
2620 (x_set_frame_alpha): Find topmost parent window with
2621 x_find_topmost_parent and set the property there also (bug#9181).
2622 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2624 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2626 * callproc.c (Fcall_process): Avoid vfork clobbering
2627 the local vars buffer, coding_systems, current_dir.
2629 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2631 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2633 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2635 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2636 so that it is not optimized away.
2638 * xdisp.c (compute_display_string_pos): Remove unused local.
2640 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2642 Fix slow cursor motion and scrolling in large buffers with
2643 selective display, like Org Mode buffers. (Bug#9218)
2645 * dispextern.h (struct bidi_it): New member disp_prop_p.
2647 * xdisp.c: Remove one-slot cache of display string positions.
2648 (compute_display_string_pos): Accept an additional argument
2649 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2650 for a display string or property. If found, set DISP_PROP_P
2653 * bidi.c (bidi_fetch_char): Accept an additional argument
2654 DISP_PROP_P, and pass it to compute_display_string_pos.
2655 Only handle text covered by a display string if DISP_PROP_P is returned
2656 non-zero. All callers of bidi_fetch_char changed.
2658 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2660 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2662 2010-12-03 Don March <don@ohspite.net>
2664 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2665 last character M-[char] is translated to ESC [char] (bug#7541).
2667 2011-08-02 Kenichi Handa <handa@m17n.org>
2669 * lisp.h (uniprop_table): Extern it.
2671 * chartab.c (uniprop_table): Make it non-static.
2673 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2675 * xdisp.c (forward_to_next_line_start): Accept additional argument
2676 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2678 (reseat_at_next_visible_line_start): Use the bidi iterator state
2679 returned by forward_to_next_line_start to restore the state of
2680 it->bidi_it after backing up to previous newline. (Bug#9212)
2682 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2684 * regex.c (re_comp): Protoize.
2685 (re_exec): Fix return type.
2686 (regexec): Fix type of `ret'. (Bug#9203)
2688 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2690 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2691 This is needed if max-image-size is a floating-point number.
2693 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2695 * print.c (print_object): Print empty symbol as ##.
2697 * lread.c (read1): Read ## as empty symbol.
2699 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2701 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2702 setting frame foreground color (Bug#9175).
2703 (x_set_background_color): Likewise.
2705 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2706 contents (Bug#9176).
2707 (EmacsTooltip -init): Remove bezels and add shadows to
2710 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2711 or scroll bar (Bug#8470).
2713 * nsfont.m (nsfont_open): Remove assignment to voffset and
2714 unnecessary vars hshink, expand, hd, full_height, min_height.
2715 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2717 * nsterm.h (nsfont_info): Remove voffset field.
2719 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2721 Implement strike-through and overline on NextStep (Bug#8863).
2723 * nsfont.m (nsfont_open): Use underline position provided by font,
2724 instead of hard-coded value of 2.
2725 (nsfont_draw): Call ns_draw_text_decoration instead.
2727 * nsterm.h: Add declaration for ns_draw_text_decoration.
2729 * nsterm.m (ns_draw_text_decoration): New function for drawing
2730 underline, overline, and strike-through.
2731 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2732 ns_draw_text_decoration. Change treatment of cursor drawing to
2733 accommodate underlining, etc.
2735 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2737 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2740 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2742 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2743 Without this fix, if a signal arrives just after memory fills up,
2744 'malloc' might be invoked reentrantly.
2746 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2747 In other words, assume that every image size is allowed, on non-X
2748 hosts. This assumption is probably wrong, but it lets Emacs compile.
2750 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2752 * regex.c (re_iswctype): Convert return values to boolean.
2754 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2756 * xdisp.c (compute_display_string_pos): Don't use cached display
2757 string position if the buffer had its restriction changed.
2760 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2762 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2764 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2766 Integer signedness and overflow and related fixes. (Bug#9079)
2768 * bidi.c: Integer size and overflow fixes.
2769 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2770 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2771 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2772 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2773 (bidi_find_other_level_edge):
2774 Use ptrdiff_t instead of EMACS_INT where either will do.
2775 This works better on 32-bit hosts configured --with-wide-int.
2776 (bidi_cache_ensure_space): Check for size-calculation overflow.
2777 Use % rather than repeated addition, for better worst-case speed.
2778 Don't set bidi_cache_size until after xrealloc returns, because it
2780 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2781 (bidi_cache_ensure_space): Also check that the bidi cache size
2782 does not exceed that of the largest Lisp string or buffer. See Eli
2783 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2785 * alloc.c (__malloc_size_t): Remove.
2786 All uses replaced by size_t. See Andreas Schwab's note
2787 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2789 * image.c: Improve checking for integer overflow.
2790 (check_image_size): Assume that f is nonnull, since
2791 it is always nonnull in practice. This is one less thing to
2792 worry about when checking for integer overflow later.
2793 (x_check_image_size): New function, which checks for integer
2794 overflow issues inside X.
2795 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2796 This removes the need for a memory_full check.
2797 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2798 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2799 (xbm_read_bitmap_data): Change locals back to 'int', since
2800 their values must fit in 'int'.
2801 (xpm_load_image, png_load, tiff_load):
2802 Invoke x_create_x_image_and_pixmap earlier,
2803 to avoid much needless work if the image is too large.
2804 (tiff_load): Treat overly large images as if
2805 x_create_x_image_and_pixmap failed, not as malloc failures.
2806 (gs_load): Use x_check_image_size.
2808 * gtkutil.c: Omit integer casts.
2809 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2810 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2812 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2814 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2815 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2816 would wrongly return t on a 64-bit host.
2818 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2819 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2820 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2821 and therefore cause GCC to emit a bogus diagnostic in some cases.
2823 * image.c: Integer signedness and overflow and related fixes.
2824 This is not an exhaustive set of fixes, but it's time to
2825 record what I've got.
2826 (lookup_pixel_color, check_image_size): Remove redundant decls.
2827 (check_image_size): Don't assume that arbitrary EMACS_INT values
2828 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2829 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2830 (tiff_load, imagemagick_load_image):
2831 Check for overflow in size calculations.
2832 (x_create_x_image_and_pixmap): Remove unnecessary test for
2833 xmalloc returning NULL; that can't happen.
2834 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2835 (xpm_color_bucket): Use better integer hashing function.
2836 (xpm_cache_color): Don't possibly over-allocate memory.
2837 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2838 (gif_memory_source):
2839 Use ptrdiff_t, not int or size_t, to record sizes.
2840 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2841 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2842 either works, as we prefer signed integers.
2843 (tiff_read_from_memory, tiff_write_from_memory):
2844 Return tsize_t, not size_t, since that's what the TIFF API wants.
2845 (tiff_read_from_memory): Don't fail simply because the read would
2846 go past EOF; instead, return a short read.
2847 (tiff_load): Omit no-longer-needed casts.
2848 (Fimagemagick_types): Don't assume size fits into 'int'.
2850 Improve hashing quality when configured --with-wide-int.
2851 * fns.c (hash_string): New function, taken from sxhash_string.
2852 Do not discard information about ASCII character case; this
2853 discarding is no longer needed.
2854 (sxhash-string): Use it. Change sig to match it. Caller changed.
2855 * lisp.h: Declare it.
2856 * lread.c (hash_string): Remove, since we now use fns.c's version.
2857 The fns.c version returns a wider integer if --with-wide-int is
2858 specified, so this should help the quality of the hashing a bit.
2860 * emacs.c: Integer overflow minor fix.
2861 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2862 Define only if GNU_LINUX.
2863 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2865 * dispnew.c: Integer signedness and overflow fixes.
2866 Remove unnecessary forward decls, that were a maintenance hassle.
2867 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2869 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2870 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2871 (prepare_desired_row, line_draw_cost):
2872 Use int, not unsigned, where either works.
2873 (save_current_matrix, restore_current_matrix):
2874 Use ptrdiff_t, not size_t, where either works.
2875 (init_display): Check for overflow more accurately, and without
2876 relying on undefined behavior.
2878 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2879 Remove, replacing with the new symbols in lisp.h. All uses changed.
2880 * fileio.c (make_temp_name):
2881 * filelock.c (lock_file_1, lock_file):
2882 * xdisp.c (message_dolog):
2883 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2884 Use pMd etc. instead.
2885 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2886 replacing the pWIDE etc. symbols removed from editfns.c.
2888 * keyboard.h (num_input_events): Now uintmax_t.
2889 This is (very slightly) less likely to mess up due to wraparound.
2892 * buffer.c: Integer signedness fixes.
2893 (alloc_buffer_text, enlarge_buffer_text):
2894 Use ptrdiff_t rather than size_t when either will do, as we prefer
2897 * alloc.c: Integer signedness and overflow fixes.
2898 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2899 (__malloc_size_t): Default to size_t, not to int.
2900 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2901 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2902 Prefer ptrdiff_t to size_t when either would do, as we prefer
2904 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2905 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2906 Now const. Initialize with values that are in range even if char
2908 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2909 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2910 These functions do the right thing with sizes > 2**32.
2911 (check_depth): Now ptrdiff_t, not int.
2912 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2913 Adjust to new way of storing sizes. Check for size overflow bugs
2915 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2916 slightly wrong anyway, as it missed one instance of
2917 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2918 (refill_memory_reserve): Omit needless cast to size_t.
2919 (mark_object_loop_halt): Mark as externally visible.
2921 * xselect.c: Integer signedness and overflow fixes.
2922 (Fx_register_dnd_atom, x_handle_dnd_message):
2923 Use ptrdiff_t, not size_t, since we prefer signed.
2924 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2925 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2926 x_dnd_atoms_size and x_dnd_atoms_length.
2928 * doprnt.c: Prefer signed to unsigned when either works.
2930 * doprnt.c (doprnt):
2932 * xdisp.c (vmessage):
2933 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2934 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2935 prefer signed arithmetic to avoid comparison confusion.
2936 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2937 but is a bit tricky.
2939 Assume freestanding C89 headers, string.h, stdlib.h.
2940 * data.c, doprnt.c, floatfns.c, print.c:
2941 Include float.h unconditionally.
2942 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2943 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2944 * regex.c: Likewise for stddef.h, string.h.
2945 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2946 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2947 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2948 (STDC_HEADERS): Remove obsolete defines.
2949 * sysdep.c: Include limits.h unconditionally.
2951 Assume support for memcmp, memcpy, memmove, memset.
2952 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2953 * regex.c (memcmp, memcpy):
2954 Remove; we assume C89 now.
2956 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2957 (__malloc_safe_bcopy): Remove; no longer needed.
2959 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
2960 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2961 well either way, and we prefer signed to unsigned.
2963 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2965 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2966 closes the connection while we're reading (bug#9182).
2968 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
2970 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2971 are specified (Bug#9168).
2973 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2975 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2976 Found by GCC static checking and --with-wide-int on a 32-bit host.
2978 2011-07-25 Eli Zaretskii <eliz@gnu.org>
2980 * xdisp.c (compute_display_string_pos): Fix logic of caching
2981 previous display string position. Initialize cached_prev_pos to
2982 -1. Fixes slow-down at the beginning of a buffer.
2984 2011-07-24 Eli Zaretskii <eliz@gnu.org>
2986 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2987 for attrs[LFACE_FONTSET_INDEX].
2989 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2991 * xml.c (parse_region): Remove unused local
2992 that was recently introduced.
2994 2011-07-23 Eli Zaretskii <eliz@gnu.org>
2996 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2997 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2999 * xdisp.c (move_it_in_display_line_to): Record the best matching
3000 position for TO_CHARPOS while scanning the line, and restore it on
3001 exit if none of the characters scanned was an exact match.
3002 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3003 when exact match is impossible due to invisible text, and the
3004 lines are truncated.
3006 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3008 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3011 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3013 Fix a significant slow-down of cursor motion with C-n, C-p,
3014 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3015 auto-repeat under bidi redisplay in fontified buffers.
3016 * xdisp.c (compute_stop_pos_backwards): New function.
3017 (next_element_from_buffer): Call compute_stop_pos_backwards to
3018 find a suitable prev_stop when we find ourselves before
3020 (reseat): Don't look for prev_stop, as that could mean a very long
3022 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3023 <cached_disp_overlay_modiff>: Cache for last found display string
3025 (compute_display_string_pos): Return the cached position if asked
3026 about the same buffer in the same area of character positions, and
3027 the buffer wasn't changed since the time the display string
3028 position was cached.
3030 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3032 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3033 is an integer, which is important for empty lines. (Bug#9149)
3035 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3037 * frame.c (Fmodify_frame_parameters): In tty case, update the
3038 default face if necessary (Bug#4238).
3040 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3042 * editfns.c (Fstring_to_char): No need to explain what a character
3043 is in the docstring (Bug#6576).
3045 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3047 * xml.c (parse_region): Make sure we always return a tree.
3049 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3051 * xml.c (parse_region): If a document contains only comments,
3054 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3056 * xml.c (make_dom): Return comments, too.
3058 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3061 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3062 and the surrounding thread.
3063 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3064 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3065 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3067 * s/openbsd.h (BROKEN_SIGIO): Define.
3068 * unexelf.c (unexec) [__OpenBSD__]:
3069 Don't update the .mdebug section of the Alpha COFF symbol table.
3071 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3073 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3076 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3078 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3079 This fixes some race conditions on the permissions of any newly
3082 * alloc.c (valid_pointer_p): Use pipe, not open.
3083 This fixes some permissions issues when debugging.
3085 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3086 If fchown fails to set both uid and gid, try to set just gid,
3087 as that is sometimes allowed. Adjust the file's mode to eliminate
3088 setuid or setgid bits that are inappropriate if fchown fails.
3090 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3092 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3093 to compare Lisp_Objects.
3094 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3095 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3096 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3098 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3100 * lread.c (read_integer): Unread even EOF character.
3101 (read1): Likewise. Properly record start position of symbol.
3103 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3104 symbol character follows.
3106 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3108 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3109 This works around a problem with the previous change to Fcopy_file.
3110 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3111 and without this change, GCC might complain about discarding
3112 fchown's return value.
3114 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3116 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3118 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3120 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3122 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3124 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3125 it's used from the C level.
3127 * process.c: Use the same condition for POLL_FOR_INPUT in both
3128 keyboard.c and process.c (bug#1858).
3130 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3132 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3133 (Fgnutls_boot): Use it.
3135 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3137 * doc.c (Fsubstitute_command_keys): Revert last change.
3139 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3141 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3142 quotes the next character, and doesn't affect other longer
3143 sequences (bug#8935).
3145 * lread.c (syms_of_lread): Clarify that is isn't only
3146 `eval-buffer' and `eval-defun' that's affected by
3147 `lexical-binding' (bug#8460).
3149 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3151 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3152 bidi redisplay when a line includes both an image and is truncated.
3154 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3156 Fix minor problems found by static checking.
3157 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3158 (elsz): Now a signed constant, not a size_t var. We prefer signed
3159 types to unsigned, to avoid integer comparison confusion. Without
3160 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3161 "cannot optimize loop, the loop counter may overflow", a symptom
3163 * indent.c (Fvertical_motion): Mark locals as initialized.
3164 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3166 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3168 * search.c (Fre_search_backward): Mention `case-fold-search' in
3169 all the re_search_* functions (bug#8138).
3171 * keyboard.c (Fopen_dribble_file): Document when the file is
3174 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3176 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3179 Support bidi reordering of display and overlay strings.
3180 * xdisp.c (compute_display_string_pos)
3181 (compute_display_string_end): Accept additional argument STRING.
3182 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3183 (reseat_to_string): Initialize bidi_it->string.s and
3184 bidi_it->string.schars.
3185 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3186 NULL (avoids a crash in bidi_paragraph_init).
3187 Initialize itb.string.lstring.
3188 (init_iterator): Call bidi_init_it only of a valid
3189 buffer position was specified. Initialize paragraph_embedding to
3191 (reseat_to_string): Initialize the bidi iterator.
3192 (display_string): If we need to ignore text properties of
3193 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3194 original value of -1 will not work with bidi.)
3195 (compute_display_string_pos): First arg is now struct
3196 `text_pos *'; all callers changed. Support display properties on
3198 (compute_display_string_end): Support display properties on Lisp
3200 (init_iterator, reseat_1, reseat_to_string): Initialize the
3201 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3202 when iterating on a string not from display properties).
3203 (compute_display_string_pos, compute_display_string_end):
3204 Fix calculation of the object to scan. Fixes an error when using
3206 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3207 base_level_stop; instead, set base_level_stop to BEGV.
3208 Fixes crashes in vertical-motion.
3209 (next_element_from_buffer): Improve commentary for when
3210 the iterator is before prev_stop.
3211 (init_iterator): Initialize bidi_p from the default value of
3212 bidi-display-reordering, not from buffer-local value. Use the
3213 buffer-local value only if initializing for buffer iteration.
3214 (handle_invisible_prop): Support invisible properties on strings
3215 that are being bidi-reordered.
3216 (set_iterator_to_next): Support bidi reordering of C strings and
3218 (next_element_from_string): Support bidi reordering of Lisp
3220 (handle_stop_backwards): Support Lisp strings as well.
3221 (display_string): Support display of R2L glyph rows.
3222 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3223 (init_iterator): Don't initialize it->bidi_p for strings
3225 (reseat_to_string): Initialize it->bidi_p for strings here.
3226 (next_element_from_string, next_element_from_c_string)
3227 (next_element_from_buffer): Add xassert's for correspondence
3228 between IT's object being iterated and it->bidi_it.string
3230 (face_before_or_after_it_pos): Support bidi iteration.
3231 (next_element_from_c_string): Handle the case of the first string
3232 character that is not the first one in the visual order.
3233 (get_visually_first_element): New function, refactored from common
3234 parts of next_element_from_buffer, next_element_from_string, and
3235 next_element_from_c_string.
3236 (tool_bar_lines_needed, redisplay_tool_bar)
3237 (display_menu_bar): Force left-to-right direction. Add a FIXME
3238 comment for making that be controlled by a user option.
3239 (push_it, pop_it): Save and restore the state of the
3240 bidi iterator. Save and restore the bidi_p flag.
3241 (pop_it): Iterate out of display property for string iteration as
3243 (iterate_out_of_display_property): Support iteration over strings.
3244 (handle_single_display_spec): Set up it->bidi_it for iteration
3245 over a display string, and call bidi_init_it.
3246 (handle_single_display_spec, next_overlay_string)
3247 (get_overlay_strings_1, push_display_prop): Set up the bidi
3248 iterator for displaying display or overlay strings.
3249 (forward_to_next_line_start): Don't use the shortcut if
3251 (back_to_previous_visible_line_start): If handle_display_prop
3252 pushed the iterator stack, restore the internal state of the bidi
3253 iterator by calling bidi_pop_it same number of times.
3254 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3255 and we are bidi-iterating, don't decrement the iterator position;
3256 instead, set the first_elt flag in the bidi iterator, to produce
3258 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3259 (push_display_prop): xassert that we are iterating a buffer.
3260 (push_it, pop_it): Save and restore paragraph_embedding member.
3261 (handle_single_display_spec, next_overlay_string)
3262 (get_overlay_strings_1, reseat_1, reseat_to_string)
3263 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3264 correctly. Don't assume unibyte strings are not bidi-reordered.
3265 (compute_display_string_pos)
3266 (compute_display_string_end): Fix handling the case of C string.
3267 (push_it, pop_it): Save and restore from_disp_prop_p.
3268 (handle_single_display_spec, push_display_prop): Set the
3269 from_disp_prop_p flag.
3270 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3271 (pop_it): Call iterate_out_of_display_property only if we are
3272 popping after iteration over a string that came from a display
3273 property. Fix a typo in popping stretch info. Add an assertion
3274 for verifying that the iterator position is in sync with the bidi
3276 (handle_single_display_spec, get_overlay_strings_1)
3277 (push_display_prop): Fix initialization of paragraph direction for
3278 string when that of the parent object is not yet determined.
3279 (reseat_1): Call bidi_init_it to resync the bidi
3280 iterator with IT's position. (Bug#7616)
3281 (find_row_edges): If ROW->start.pos gives position
3282 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3283 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3284 Reset the from_disp_prop_p flag.
3285 (SAVE_IT, RESTORE_IT): New macros.
3286 (pos_visible_p, face_before_or_after_it_pos)
3287 (back_to_previous_visible_line_start)
3288 (move_it_in_display_line_to, move_it_in_display_line)
3289 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3290 (try_scrolling, redisplay_window, display_line): Use them when
3291 saving a temporary copy of the iterator and restoring it back.
3292 (back_to_previous_visible_line_start, reseat_1)
3293 (init_iterator): Empty the bidi cache "stack".
3294 (move_it_in_display_line_to): If iterator ended up at
3295 EOL, but we never saw any buffer positions smaller than
3296 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3297 motion in bidi-reordered lines.
3298 (move_it_in_display_line_to): Record prev_method and prev_pos
3299 immediately before the call to set_iterator_to_next. Fixes cursor
3300 motion in bidi-reordered lines with stretch glyphs and strings
3301 displayed in margins. (Bug#8133) (Bug#8867)
3302 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3304 (pos_visible_p): Support positions in bidi-reordered lines.
3305 Save and restore bidi cache.
3307 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3308 (bidi_paragraph_info): Delete unused struct.
3309 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3310 (bidi_cache_start): New variable.
3311 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3313 (bidi_cache_fetch_state, bidi_cache_search)
3314 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3315 (bidi_cache_find, bidi_peek_at_next_level)
3316 (bidi_level_of_next_char, bidi_find_other_level_edge)
3317 (bidi_move_to_visually_next): Compare cache index with
3318 bidi_cache_start rather than with zero.
3319 (bidi_fetch_char): Accept new argument STRING; all callers
3320 changed. Support iteration over a string. Support strings with
3321 display properties. Support unibyte strings. Fix the type of
3322 `len' according to what STRING_CHAR_AND_LENGTH expects.
3323 (bidi_paragraph_init, bidi_resolve_explicit_1)
3324 (bidi_resolve_explicit, bidi_resolve_weak)
3325 (bidi_level_of_next_char, bidi_move_to_visually_next):
3326 Support iteration over a string.
3327 (bidi_set_sor_type, bidi_resolve_explicit_1)
3328 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3329 can now be zero (for strings); special values 0 and -1 were
3330 changed to -1 and -2, respectively.
3331 (bidi_char_at_pos): New function.
3332 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3333 Call it instead of FETCH_MULTIBYTE_CHAR.
3334 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3335 initialized to valid values.
3336 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3338 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3339 the test for valid cached positions. Fix the logic for looking up
3340 the sentinel state in the cache. GCPRO the Lisp string we are
3342 (bidi_push_it, bidi_pop_it): New functions.
3343 (bidi_initialize): Initialize the bidi cache start stack pointer.
3344 (bidi_cache_ensure_space): New function, refactored from part of
3345 bidi_cache_iterator_state. Don't assume the required size is just
3346 one BIDI_CACHE_CHUNK away.
3347 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3348 (bidi_count_bytes, bidi_char_at_pos): New functions.
3349 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3350 always valid if bidi_cache_idx is valid.
3351 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3352 is valid if it's going to be used.
3353 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3354 (bidi_cache_fetch_state, bidi_cache_search)
3355 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3356 (bidi_cache_iterator_state, bidi_cache_find)
3357 (bidi_find_other_level_edge, bidi_cache_start_stack):
3358 All variables related to cache indices are now EMACS_INT.
3360 * dispextern.h (struct bidi_string_data): New structure.
3361 (struct bidi_it): New member `string'. Make flag members be 1-bit
3362 fields, and put them last in the struct.
3363 (compute_display_string_pos, compute_display_string_end):
3365 (bidi_push_it, bidi_pop_it): Add prototypes.
3366 (struct iterator_stack_entry): New members bidi_p,
3367 paragraph_embedding, and from_disp_prop_p.
3368 (struct it): Member bidi_p is now a bit field 1 bit wide.
3369 (bidi_shelve_cache, bidi_unshelve_cache):
3372 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3373 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3374 and vector-like objects.
3376 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3377 cache around display iteration.
3379 * window.c (Fwindow_end, window_scroll_pixel_based)
3380 (displayed_window_lines, Frecenter): Save and restore the bidi
3381 cache around display iteration.
3383 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3385 * editfns.c (Fdelete_region): Clarify the use of the named
3386 parameters (bug#6788).
3388 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3390 * indent.c (Fvertical_motion): Set and restore w->pointm when
3391 saving and restoring the window's buffer (Bug#9006).
3393 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3395 * editfns.c (Fstring_to_char): Clarify just what is returned
3396 (bug#6576). Text by Eli Zaretskii.
3398 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3400 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3402 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3404 * buffer.c (mmap_find): Fix a typo.
3406 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3408 Fix execution of x selection hooks.
3409 * xselect.c (Qx_lost_selection_functions)
3410 (Qx_sent_selection_functions): New vars.
3411 (syms_of_xselect): DEFSYM them.
3412 (x_handle_selection_request): Pass Qx_sent_selection_functions
3413 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3414 (x_handle_selection_clear,x_clear_frame_selections):
3415 Pass Qx_lost_selection_functions rather than
3416 Vx_lost_selection_functions to Frun_hook_with_args.
3418 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3420 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3421 The old code sometimes used this field without initializing it.
3423 * alloc.c (gc_sweep): Don't read past end of array.
3424 In theory, the old code could also have corrupted Emacs internals,
3425 though it'd be very unlikely.
3427 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3429 * character.c (Fcharacterp): Don't advertise optional ignored
3430 argument. (Bug#4026)
3432 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3434 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3437 * window.c (Fset_window_start): Doc fix (bug#4199).
3438 (Fset_window_hscroll): Ditto.
3440 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3442 Fix minor new problems caught by GCC 4.6.1.
3443 * term.c (init_tty): Remove unused local.
3444 * xsettings.c (store_monospaced_changed): Define this function only
3445 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3448 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3450 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3452 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3454 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3455 are the mini-buffer and the echo area (bug#3320).
3457 * term.c (init_tty): Remove support for supdup, c10 and perq
3458 terminals, which are no longer supported (bug#1482).
3460 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3462 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3464 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3466 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3467 for non-popups (Bug#3642).
3469 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3471 * alloc.c (reset_malloc_hooks): Protoize.
3472 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3473 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3474 * cm.c (losecursor): Likewise.
3475 * data.c (fmod): Likewise.
3476 * dispnew.c (swap_glyphs_in_rows): Likewise.
3477 * emacs.c (memory_warning_signal): Likewise.
3478 * floatfns.c (float_error): Likewise.
3479 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3480 (otf_open, font_otf_capability, generate_otf_features)
3481 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3483 * image.c (pbm_read_file): Likewise.
3484 * indent.c (string_display_width): Likewise.
3485 * intervals.c (check_for_interval, search_for_interval)
3486 (inc_interval_count, count_intervals, root_interval)
3487 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3488 * lread.c (defalias): Likewise.
3489 * ralloc.c (r_alloc_check): Likewise.
3490 * regex.c (set_image_of_range_1, set_image_of_range)
3491 (regex_grow_registers): Likewise.
3492 * sysdep.c (strerror): Likewise.
3493 * termcap.c (valid_filename_p, tprint, main): Likewise.
3494 * tparam.c (main): Likewise.
3495 * unexhp9k800.c (run_time_remap, save_data_space)
3496 (update_file_ptrs, read_header, write_header, calculate_checksum)
3497 (copy_file, copy_rest, display_header): Likewise.
3498 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3500 * xdisp.c (check_it): Likewise.
3501 * xfaces.c (register_color, unregister_color, unregister_colors):
3503 * xfns.c (print_fontset_result): Likewise.
3504 * xrdb.c (member, fatal, main): Likewise.
3506 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3508 Fix minor problems found by static checking (Bug#9031).
3509 * chartab.c (char_table_set_range, map_sub_char_table):
3510 Remove unused locals.
3511 (uniprop_table): Now static.
3512 * composite.c (_work_char): Remove unused static var.
3514 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3516 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3518 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3520 * gtkutil.c (qttip_cb): Remove code without function.
3522 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3524 * w32.c (pthread_sigmask): New stub.
3526 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3528 Use pthread_sigmask, not sigprocmask (Bug#9010).
3529 sigprocmask is portable only for single-threaded applications, and
3530 Emacs can be multi-threaded when it uses GTK.
3531 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3533 * callproc.c (Fcall_process):
3534 * process.c (create_process):
3535 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3536 Use pthread_sigmask, not sigprocmask.
3538 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3540 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3541 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3544 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3546 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3547 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3548 (xg_hide_tooltip): Fix comment.
3550 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3551 in registerServicesMenuSendTypes.
3552 (validRequestorForSendType): Don't check ns_return_types.
3554 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3557 2011-07-08 Jason Rumney <jasonr@gnu.org>
3559 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3560 SH_SHOW for hidden windows (Bug#5482).
3562 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3563 frame struct members of non-existent frames (Bug#6284).
3565 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3567 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3568 variable firstTime not needed on OSX >= 10.6.
3569 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3570 >= 10.5. Use setKnobProportion, setDoubleValue.
3572 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3573 (MAC_OS_X_VERSION_10_5): Define if not defined.
3574 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3575 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3576 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3578 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3579 cString and lossyCString on OSX >= 10.4
3581 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3582 sizeToFit on OSX >= 10.2.
3584 * nsimage.m (allocInitFromFile): Don't use deprecated method
3585 bestRepresentationForDevice on OSX >= 10.6.
3587 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3590 * emacs.c: Declare unexec_init_emacs_zone.
3592 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3594 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3596 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3597 on svcsMenu (Bug#8842).
3599 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3601 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3603 * nsterm.m (QUTF8_STRING): Declare.
3604 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3605 (validRequestorForSendType): Return type is (id).
3606 Change indexOfObjectIdenticalTo to indexOfObject.
3607 Check if we have local selection before returning self (Bug#8842).
3608 (writeSelectionToPasteboard): Put local selection into paste board
3609 if we have a local selection (Bug#8842).
3610 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3612 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3613 (ns_get_local_selection): Declare.
3615 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3617 * keymap.c (describe_map_tree): Don't insert a double newline at
3618 the end of the buffer (bug#1169) and return whether we inserted
3621 * callint.c (Fcall_interactively): Change "reading args" to
3622 "providing args" to try to clarify what it does (bug#1010).
3624 2011-07-07 Kenichi Handa <handa@m17n.org>
3626 * composite.c (composition_compute_stop_pos): Ignore a static
3627 composition starting before CHARPOS (Bug#8915).
3629 * xdisp.c (handle_composition_prop): Likewise.
3631 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3633 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3636 2011-07-07 Kenichi Handa <handa@m17n.org>
3638 * character.h (unicode_category_t): New enum type.
3640 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3641 (Qchar_code_property_table): New variable.
3642 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3643 (UNIPROP_COMPRESSED_FORM_P): New macros.
3644 (char_table_ascii): Uncompress the compressed values.
3645 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3646 Uncompress the compressed values.
3647 (sub_char_table_ref_and_range): Likewise.
3648 (char_table_ref_and_range): Uncompress the compressed values.
3649 (sub_char_table_set): New arg is_uniprop. Callers changed.
3650 Uncompress the compressed values.
3651 (sub_char_table_set_range): Args changed. Callers changed.
3652 (char_table_set_range): Adjuted for the above change.
3653 (map_sub_char_table): Delete args default_val and parent. Add arg
3654 top. Give decoded values to a Lisp function.
3655 (map_char_table): Adjust for the above change. Give decoded
3656 values to a Lisp function. Gcpro more variables.
3657 (uniprop_table_uncompress)
3658 (uniprop_decode_value_run_length): New functions.
3659 (uniprop_decoder, uniprop_decoder_count): New variables.
3660 (uniprop_get_decoder, uniprop_encode_value_character)
3661 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3663 (uniprop_encoder, uniprop_encoder_count): New variables.
3664 (uniprop_get_encoder, uniprop_table)
3665 (Funicode_property_table_internal, Fget_unicode_property_internal)
3666 (Fput_unicode_property_internal): New functions.
3667 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3668 Sunicode_property_table_internal, Sget_unicode_property_internal,
3669 and Sput_unicode_property_internal. Defvar_lisp
3670 char-code-property-alist.
3672 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3673 Vunicode_category_table.
3675 * font.c (font_range): Adjust for the change of
3676 Vunicode_category_table.
3678 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3680 * m/iris4d.h: Remove file, move contents ...
3681 * s/irix6-5.h: ... here.
3683 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3685 Remove unportable assumption about struct layout (Bug#8884).
3686 * alloc.c (mark_buffer):
3687 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3688 (clone_per_buffer_values): Don't assume that
3689 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3690 This isn't true in general, and it's particularly not true
3691 if Emacs is configured with --with-wide-int.
3692 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3693 New macros, used in the buffer.c change.
3695 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3697 * xsettings.c: Use both GConf and GSettings if both are available.
3698 (store_config_changed_event): Add comment.
3699 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3700 (store_tool_bar_style_changed): New functions.
3701 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3702 (struct xsettings): Move font inside HAVE_XFT.
3703 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3704 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3705 Move inside HAVE_XFT.
3706 (something_changed_gsettingsCB): Rename from something_changedCB.
3707 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3709 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3710 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3711 (something_changed_gconfCB): Rename from something_changedCB.
3712 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3713 (parse_settings): Move check for font inside HAVE_XFT.
3714 (read_settings, apply_xft_settings): Add comment.
3715 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3716 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3717 call store_font_name_changed.
3718 (xft_settings_event): Add comment.
3719 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3720 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3721 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3722 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3723 (xsettings_initialize): Call init_gsettings last.
3724 (xsettings_get_system_font, xsettings_get_system_normal_font):
3727 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3729 Random fixes. E.g., (random) never returned negative values.
3730 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3731 subseconds part to the entropy, as that's a bit more random.
3732 Prefer signed to unsigned, since the signedness doesn't matter and
3733 in general we prefer signed. When given a limit, use a
3734 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3735 latter isn't right if USE_2_TAGS_FOR_INTS.
3736 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3737 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3739 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3741 * textprop.c (text_property_stickiness):
3742 Obey Vtext_property_default_nonsticky.
3743 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3744 * w32fns.c (syms_of_w32fns):
3745 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3747 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3749 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3750 This is more efficient than Ffile_directory_p and avoids a minor race.
3752 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3754 * buffer.c (Foverlay_put): Say what the return value is
3757 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3758 is a directory before asking whether to use the file name
3760 (barf_or_query_if_file_exists): Make the "File is a directory"
3761 error be more correct.
3763 * fns.c (Frequire): Remove the mention of the .gz files, since
3764 that's installation-specific, but keep the mention of
3765 `get-load-suffixes'.
3767 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3769 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3770 Report string overflow if the output is too long.
3772 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3774 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3775 (syms_of_gnutls): Remove duplicate DEFSYM for
3776 Qgnutls_bootprop_verify_hostname_error, an error for
3777 Qgnutls_bootprop_verify_error (which is no longer used).
3779 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3780 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3781 Also (re)move comments that are misplaced or no longer relevant.
3783 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3785 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3787 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3789 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3790 and background color parameters if they have been changed.
3792 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3794 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3796 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3798 * xsettings.c (SYSTEM_FONT): Define only when used.
3799 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3801 * keymap.c (access_keymap_1): Now static.
3803 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3805 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3806 leave any prefix arg for the up event (Bug#1586).
3808 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3810 * lread.c (syms_of_lread): Mention single symbols defined by
3811 `defvar' or `defconst' (bug#7154).
3813 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3814 (Frequire): Mention get-load-suffixes.
3816 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3818 * window.h (window): Remove clone_number slot.
3819 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3821 (make_parent_window, make_window, saved_window)
3822 (Fset_window_configuration, save_window_save): Don't deal with
3824 * buffer.c (Qclone_number): Remove declaration.
3825 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3827 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3829 Add multiple inheritance to keymaps.
3830 * keymap.c (Fmake_composed_keymap): New function.
3831 (Fset_keymap_parent): Simplify.
3832 (fix_submap_inheritance): Remove.
3833 (access_keymap_1): New function extracted from access_keymap to handle
3834 embedded parents and handle lists of maps.
3835 (access_keymap): Use it.
3836 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3837 (Fcopy_keymap): Handle embedded parents.
3838 (Fcommand_remapping, define_as_prefix): Simplify.
3839 (Fkey_binding): Simplify.
3840 (syms_of_keymap): Move minibuffer-local-completion-map,
3841 minibuffer-local-filename-completion-map,
3842 minibuffer-local-must-match-map, and
3843 minibuffer-local-filename-must-match-map to Elisp.
3844 (syms_of_keymap): Defsubr make-composed-keymap.
3845 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3846 (parse_menu_item): Trivial simplification.
3848 2011-07-01 Glenn Morris <rgm@gnu.org>
3850 * Makefile.in (SETTINGS_LIBS): Fix typo.
3852 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3854 * coding.c (Fencode_coding_string): Record the last coding system
3855 used, as the function doc string says (bug#8738).
3857 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3859 * xsettings.c (store_monospaced_changed): Take new font as arg and
3860 check for change against current_mono_font.
3861 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3862 (emacs_settings_constructor, emacs_settings_get_property)
3863 (emacs_settings_set_property, emacs_settings_class_init)
3864 (emacs_settings_init, gsettings_obj): Remove.
3865 (something_changedCB): New function for HAVE_GSETTINGS.
3866 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3867 with value as argument.
3868 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3869 g_settings_new (Bug#8967). Do not create gsettings_obj.
3870 Remove calls to g_settings_bind. Connect something_changedCB to
3873 * xgselect.c: Add defined (HAVE_GSETTINGS).
3874 (xgselect_initialize): Ditto.
3876 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3877 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3880 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3882 * eval.c (struct backtrace): Simplify and port the data structure.
3883 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3884 signed bit field, as this assumption is not portable and it makes
3885 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3886 "char debug_on_exit : 1" as this is not portable either; instead,
3887 use the portable "unsigned int debug_on_exit : 1". Remove unused
3888 member evalargs. Remove obsolete comments about cc bombing out.
3890 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3892 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3893 Let HAVE_GSETTINGS override HAVE_GCONF.
3894 (store_monospaced_changed): New function.
3895 (EMACS_SETTINGS): A new type derived from GObject to handle
3896 GSettings notifications.
3897 (emacs_settings_constructor, emacs_settings_get_property)
3898 (emacs_settings_set_property, emacs_settings_class_init):
3900 (gsettings_client, gsettings_obj): New variables.
3901 (GSETTINGS_SCHEMA): New define.
3902 (something_changedCB): Call store_monospaced_changed.
3903 (init_gsettings): New function.
3904 (xsettings_initialize): Call init_gsettings.
3905 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3908 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3911 2011-06-29 Martin Rudalics <rudalics@gmx.at>
3913 * window.c (resize_root_window, grow_mini_window)
3914 (shrink_mini_window): Rename Qresize_root_window to
3915 Qwindow_resize_root_window and Qresize_root_window_vertically to
3916 Qwindow_resize_root_window_vertically.
3918 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3920 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3922 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
3924 * makefile.w32-in: Redesign dependencies so they reflect more
3925 clearly which files are directly included by each source file,
3926 and not through other includes.
3928 2011-06-27 Martin Rudalics <rudalics@gmx.at>
3930 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3931 (sort_overlays, overlay_strings): When an overlay's clone number
3932 matches the window's clone number process the overlay even if
3933 the overlay's window property doesn't match the current window.
3935 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3936 (Fwindow_hchild): Rename to Fwindow_left_child.
3937 (Fwindow_next): Rename to Fwindow_next_sibling.
3938 (Fwindow_prev): Rename to Fwindow_prev_sibling.
3939 (resize_window_check): Rename to window_resize_check.
3940 (resize_window_apply): Rename to window_resize_apply.
3941 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3942 (Fdelete_other_windows_internal, resize_frame_windows)
3943 (Fsplit_window_internal, Fdelete_window_internal)
3944 (grow_mini_window, shrink_mini_window)
3945 (Fresize_mini_window_internal): Fix callers accordingly.
3947 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3949 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3950 (emacs_fixed_set_min_size): Remove.
3951 (emacs_fixed_new): Take frame as argument.
3953 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3954 (_EmacsFixedPrivate): Remove minwidth/height.
3955 Add struct frame *f.
3956 (emacs_fixed_init): Initialize priv->f.
3957 (get_parent_class, emacs_fixed_set_min_size): Remove.
3958 (emacs_fixed_new): Set priv->f to argument.
3959 (emacs_fixed_get_preferred_width)
3960 (emacs_fixed_get_preferred_height): Use min_width/height from
3961 frames size_hint to set minimum and natural (Bug#8919).
3962 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3963 and use min_width/height from frames size_hint to set
3964 min_width/height (Bug#8919).
3966 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
3967 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3970 2011-06-26 Eli Zaretskii <eliz@gnu.org>
3972 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3973 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3976 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
3978 * process.c (wait_reading_process_output): Bypass select if
3979 waiting for a cell while ignoring keyboard input, and input is
3980 pending. Suggested by Jan Djärv (Bug#8869).
3982 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3984 Use gnulib's dup2 module instead of rolling our own.
3985 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3987 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3989 * dispnew.c (scrolling_window): Before scrolling, turn off a
3990 mouse-highlight in the window being scrolled.
3992 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
3994 Move DEFSYM to lisp.h and use everywhere.
3996 * character.h (DEFSYM): Move declaration...
3997 * lisp.h (DEFSYM): ...here.
4003 * w32select.c: Don't include character.h.
4005 * alloc.c (syms_of_alloc):
4006 * buffer.c (syms_of_buffer):
4007 * bytecode.c (syms_of_bytecode):
4008 * callint.c (syms_of_callint):
4009 * casefiddle.c (syms_of_casefiddle):
4010 * casetab.c (init_casetab_once):
4011 * category.c (init_category_once, syms_of_category):
4012 * ccl.c (syms_of_ccl):
4013 * cmds.c (syms_of_cmds):
4014 * composite.c (syms_of_composite):
4015 * dbusbind.c (syms_of_dbusbind):
4016 * dired.c (syms_of_dired):
4017 * dispnew.c (syms_of_display):
4018 * doc.c (syms_of_doc):
4019 * editfns.c (syms_of_editfns):
4020 * emacs.c (syms_of_emacs):
4021 * eval.c (syms_of_eval):
4022 * fileio.c (syms_of_fileio):
4023 * fns.c (syms_of_fns):
4024 * frame.c (syms_of_frame):
4025 * fringe.c (syms_of_fringe):
4026 * insdel.c (syms_of_insdel):
4027 * keymap.c (syms_of_keymap):
4028 * lread.c (init_obarray, syms_of_lread):
4029 * macros.c (syms_of_macros):
4030 * msdos.c (syms_of_msdos):
4031 * print.c (syms_of_print):
4032 * process.c (syms_of_process):
4033 * search.c (syms_of_search):
4034 * sound.c (syms_of_sound):
4035 * syntax.c (init_syntax_once, syms_of_syntax):
4036 * terminal.c (syms_of_terminal):
4037 * textprop.c (syms_of_textprop):
4038 * undo.c (syms_of_undo):
4039 * w32.c (globals_of_w32):
4040 * window.c (syms_of_window):
4041 * xdisp.c (syms_of_xdisp):
4042 * xfaces.c (syms_of_xfaces):
4043 * xfns.c (syms_of_xfns):
4044 * xmenu.c (syms_of_xmenu):
4045 * xsettings.c (syms_of_xsettings):
4046 * xterm.c (syms_of_xterm): Use DEFSYM.
4048 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4050 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4052 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4054 Integer and buffer overflow fixes (Bug#8873).
4056 * print.c (printchar, strout): Check for string overflow.
4057 (PRINTPREPARE, printchar, strout):
4058 Don't set size unless allocation succeeds.
4060 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4061 for sizes. Check for string overflow more accurately.
4062 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4064 * macros.c: Integer and buffer overflow fixes.
4065 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4066 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4067 Use ptrdiff_t, not int, for sizes.
4068 Don't increment bufsize until after realloc succeeds.
4069 Check for size-calculation overflow.
4070 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4072 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4074 * lread.c: Integer overflow fixes.
4075 (read_integer): Radix is now EMACS_INT, not int,
4076 to improve quality of diagnostics for out-of-range radices.
4077 Calculate buffer size correctly for out-of-range radices.
4078 (read1): Check for integer overflow in radices, and in
4079 read-circle numbers.
4080 (read_escape): Avoid int overflow.
4081 (Fload, openp, read_buffer_size, read1)
4082 (substitute_object_recurse, read_vector, read_list, map_obarray):
4083 Use ptrdiff_t, not int, for sizes.
4084 (read1): Use EMACS_INT, not int, for sizes.
4085 Check for size overflow.
4087 * image.c (cache_image): Check for size arithmetic overflow.
4089 * lread.c: Integer overflow issues.
4090 (saved_doc_string_size, saved_doc_string_length)
4091 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4092 Now ptrdiff_t, not int.
4093 (read1): Don't assume doc string length fits in int. Check for
4094 out-of-range doc string lengths.
4095 (read_list): Don't assume file position fits in int.
4096 (read_escape): Check for hex character overflow.
4098 2011-06-22 Leo Liu <sdl.web@gmail.com>
4100 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4101 Move to minibuffer.el.
4103 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4105 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4106 The following patches are for when GLYPH_DEBUG && !XASSERT.
4107 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4108 * dispnew.c (flush_stdout):
4109 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4110 Mark as externally visible.
4111 * dispnew.c (check_window_matrix_pointers): Now static.
4112 * dispnew.c (window_to_frame_vpos):
4113 * xfns.c (unwind_create_frame):
4114 * xterm.c (x_check_font): Remove unused local.
4115 * scroll.c (CHECK_BOUNDS):
4116 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4117 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4118 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4119 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4120 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4122 (debug_method_add): Use va_list and vsprintf rather than relying
4123 on undefined behavior with wrong number of arguments.
4124 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4125 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4126 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4127 since we're not interested in debugging glyphs with old libraries.
4128 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4129 GCC 4.6.0's static checking.
4131 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4133 Integer overflow and signedness fixes (Bug#8873).
4134 A few related buffer overrun fixes, too.
4136 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4138 * dispextern.h (struct face.stipple):
4139 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4140 (x_bitmap_mask, x_allocate_bitmap_record)
4141 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4142 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4143 (x_create_bitmap_from_xpm_data):
4144 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4145 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4147 * xfaces.c (load_pixmap):
4148 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4149 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4150 (.bitmaps_last, struct x_output.icon_bitmap):
4151 Use ptrdiff_t, not int, for bitmap indexes.
4152 (x_allocate_bitmap_record): Check for size overflow.
4153 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4155 Use ptrdiff_t, not int, for overlay counts.
4156 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4157 * editfns.c (overlays_around, get_pos_property):
4158 * textprop.c (get_char_property_and_overlay):
4159 * xdisp.c (next_overlay_change, note_mouse_highlight):
4160 * xfaces.c (face_at_buffer_position):
4161 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4162 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4163 (Fnext_overlay_change, Fprevious_overlay_change)
4164 (mouse_face_overlay_overlaps, Foverlays_in):
4165 Use ptrdiff_t, not int, for sizes.
4166 (overlays_at, overlays_in): Check for size-calculation overflow.
4168 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4170 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4171 (x_session_initialize): Do not assume string length fits in int.
4173 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4174 This is unlikely, but can occur if DPI is outlandish.
4176 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4177 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4179 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4180 * xrdb.c (magic_file_p, search_magic_path):
4181 Omit last arg SUFFIX; it was always 0. All callers changed.
4182 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4184 * xfont.c (xfont_match): Avoid need for strlen.
4186 * xfns.c: Don't assume strlen fits in int.
4187 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4189 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4190 not unsigned long, as we prefer signed integers. All callers changed.
4191 Detect integer overflow in repeat count.
4192 (message_dolog): Don't assume print length fits in 39 bytes.
4193 (display_mode_element): Don't assume strlen fits in int.
4195 * termcap.c: Don't assume sizes fit in int and never overflow.
4196 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4197 (gobble_line): Check for size-calculation overflow.
4199 * minibuf.c (Fread_buffer):
4200 * lread.c (intern, intern_c_string):
4201 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4202 Don't assume string length fits in int.
4204 * keyboard.c (parse_tool_bar_item):
4205 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4207 * font.c: Don't assume string length fits in int.
4208 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4209 Use ptrdiff_t, not int.
4210 (font_intern_prop): Don't assume string length fits in int.
4211 Don't assume integer property fits in fixnum.
4212 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4214 * filelock.c: Fix some buffer overrun and integer overflow issues.
4215 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4216 Reformulate so as not to need the command string.
4217 Invoke gzip -cd rather than gunzip, as it's more portable.
4218 (lock_info_type, lock_file_1, lock_file):
4219 Don't assume pid_t and time_t fit in unsigned long.
4220 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4221 (current_lock_owner): Prefer signed type for sizes.
4222 Use memcpy, not strncpy, where memcpy is what is really wanted.
4223 Don't assume (via atoi) that time_t and pid_t fit in int.
4224 Check for time_t and/or pid_t out of range, e.g., via a network share.
4225 Don't alloca where an auto var works fine.
4227 * fileio.c: Fix some integer overflow issues.
4228 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4229 Don't assume string length fits in int.
4230 (directory_file_name): Don't assume string length fits in long.
4231 (make_temp_name): Don't assume pid fits in int, or that its print
4232 length is less than 20.
4234 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4236 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4238 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4240 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4241 We prefer signed integers, even for size calculations.
4243 * emacs.c: Don't assume string length fits in 'int'.
4244 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4245 (main): Don't invoke strlen when not needed.
4247 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4248 (XD_DEBUG_MESSAGE): Don't waste a byte.
4250 * callproc.c (getenv_internal_1, getenv_internal)
4252 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4254 * lread.c (invalid_syntax): Omit length argument.
4255 All uses changed. This doesn't fix a bug, but it simplifies the
4256 code away from its former Hollerith-constant appearance, and it's
4257 one less 'int' to worry about when looking at integer-overflow issues.
4258 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4260 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4261 This didn't break anything, but it didn't help either.
4262 It's confusing to put a bogus integer in a place where the actual
4263 value does not matter.
4264 (LIST_END_P): Remove unused macro and its bogus comment.
4265 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4267 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4268 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4270 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4271 We prefer signed types, and the value cannot exceed the EMACS_INT
4272 range anyway (because otherwise the length would not be representable).
4273 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4274 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4275 This avoids a GCC warning when WIDE_EMACS_INT.
4277 * indent.c (sane_tab_width): New function.
4278 (current_column, scan_for_column, Findent_to, position_indentation)
4279 (compute_motion): Use it. This is just for clarity.
4280 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4282 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4284 * lisp.h (lint_assume): New macro.
4285 * composite.c (composition_gstring_put_cache):
4286 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4288 * editfns.c, insdel.c:
4289 Omit unnecessary forward decls, to simplify future changes.
4291 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4293 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4295 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4296 Use much-faster test for byte-length change.
4297 Don't assume string byte-length fits in 'int'.
4298 Check that character arg fits in 'int'.
4299 (mapcar1): Declare byte as byte, for clarity.
4301 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4303 * fns.c (concat): Catch string overflow earlier.
4304 Do not rely on integer wraparound.
4306 * dispextern.h (struct it.overlay_strings_charpos)
4307 (struct it.selective): Now EMACS_INT, not int.
4308 * xdisp.c (forward_to_next_line_start)
4309 (back_to_previous_visible_line_start)
4310 (reseat_at_next_visible_line_start, next_element_from_buffer):
4311 Don't arbitrarily truncate the value of 'selective' to int.
4313 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4315 * composite.c: Don't truncate sizes to 'int'.
4316 (composition_gstring_p, composition_reseat_it)
4317 (composition_adjust_point): Use EMACS_INT, not int.
4318 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4319 not EMACS_UINT, for indexes.
4321 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4323 * buffer.c: Include <verify.h>.
4324 (struct sortvec.priority, struct sortstr.priority):
4325 Now EMACS_INT, not int.
4326 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4327 (struct sortstr.size, record_overlay_string)
4328 (struct sortstrlist.size, struct sortlist.used):
4329 Don't truncate size to int.
4330 (record_overlay_string): Check for size-calculation overflow.
4331 (init_buffer_once): Check at compile-time, not run-time.
4333 2011-06-22 Jim Meyering <meyering@redhat.com>
4335 Don't leak an XBM-image-sized buffer
4336 * image.c (xbm_load): Free the image buffer after using it.
4338 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4341 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4342 that Sun C diagnosed.
4343 * fns.c (secure_hash): Fix pointer signedness issue.
4344 * intervals.c (static_offset_intervals): New function.
4345 (offset_intervals): Use it.
4347 2011-06-21 Leo Liu <sdl.web@gmail.com>
4350 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4353 * fns.c (secure_hash): Rename from crypto_hash_function and change
4354 the first arg to accept symbols.
4355 (Fsecure_hash): New primitive.
4356 (syms_of_fns): New symbols.
4358 2011-06-20 Deniz Dogan <deniz@dogan.se>
4360 * process.c (Fset_process_buffer): Clarify return value in
4363 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4365 * dispnew.c (add_window_display_history): Use BVAR.
4367 * xdisp.c (debug_method_add): Use BVAR.
4368 (check_window_end, dump_glyph_matrix, dump_glyph)
4369 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4371 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4374 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4375 check till after the cache is created in init_frame_faces.
4377 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4379 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4381 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4383 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4384 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4385 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4387 Improve buffer-overflow checking (Bug#8873).
4388 * fileio.c (Finsert_file_contents):
4389 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4390 Remove the old (too-loose) buffer overflow checks.
4391 They weren't needed, since make_gap checks for buffer overflow.
4392 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4393 The old code merely checked for Emacs fixnum overflow, and relied
4394 on undefined (wraparound) behavior. The new code avoids undefined
4395 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4397 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4398 Tune. Don't use wider integers than needed. Don't use alloca.
4399 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4401 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4403 * insdel.c, lisp.h (buffer_overflow): New function.
4404 (insert_from_buffer_1, replace_range, replace_range_2):
4405 * insdel.c (make_gap_larger):
4406 * editfns.c (Finsert_char):
4407 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4409 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4411 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4413 Integer overflow and signedness fixes (Bug#8873).
4415 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4416 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4418 * fileio.c: Don't assume EMACS_INT fits in off_t.
4419 (emacs_lseek): New static function.
4420 (Finsert_file_contents, Fwrite_region): Use it.
4421 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4423 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4425 * fns.c: Don't overflow int when computing a list length.
4426 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4427 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4428 truncation on 64-bit hosts. Check for QUIT every
4429 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4430 faster and is responsive enough.
4431 (Flength): Report an error instead of overflowing an integer.
4432 (Fsafe_length): Return a float if the value is not representable
4433 as a fixnum. This shouldn't happen except in contrived situations.
4434 (Fnthcdr, Fsort): Don't assume list length fits in int.
4435 (Fcopy_sequence): Don't assume vector length fits in int.
4437 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4438 (header_size, word_size): New constants.
4439 (allocate_vectorlike): Don't check size overflow here.
4440 (allocate_vector): Check it here instead, since this is the only
4441 caller of allocate_vectorlike that could cause overflow.
4442 Check that the new vector's length is representable as a fixnum.
4444 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4445 The previous code was bogus. For example, next_almost_prime (32)
4446 returned 39, which is undesirable as it is a multiple of 3; and
4447 next_almost_prime (24) returned 25, which is a multiple of 5 so
4448 why was the code bothering to check for multiples of 7?
4450 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4452 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4454 Variadic C functions now count arguments with ptrdiff_t.
4455 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4456 Back then I didn't know that the Emacs coding style prefers signed int.
4457 Also, in the meantime I found a few more instances where arguments
4458 were being counted with int, which may truncate counts on 64-bit
4459 machines, or EMACS_INT, which may be unnecessarily wide.
4460 * lisp.h (struct Lisp_Subr.function.aMANY)
4461 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4462 Arg counts are now ptrdiff_t, not size_t.
4463 All variadic functions and their callers changed accordingly.
4464 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4465 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4466 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4467 * callint.c (Fcall_interactively): Check arg count for overflow,
4468 to avoid potential buffer overrun. Use signed char, not 'int',
4469 for 'varies' array, so that we needn't bother to check its size
4470 calculation for overflow.
4471 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4472 * eval.c (apply_lambda):
4473 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4474 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4475 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4477 * callint.c (Fcall_interactively): Don't use index var as event count.
4479 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4480 * mem-limits.h (SIZE): Remove; no longer used.
4482 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4484 Remove unnecessary casts.
4485 * xterm.c (x_term_init):
4486 * xfns.c (x_set_border_pixel):
4487 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4488 These aren't needed now that we assume ANSI C.
4490 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4491 It's more likely to cause problems (due to unsigned overflow)
4494 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4496 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4498 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4500 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4502 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4504 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4506 GLYPH_CODE_FACE returns EMACS_INT, not int.
4507 * dispextern.h (merge_faces):
4508 * xfaces.c (merge_faces):
4509 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4510 Don't assume EMACS_INT fits in int.
4512 * character.h (CHAR_VALID_P): Remove unused parameter.
4513 * fontset.c, lisp.h, xdisp.c: All uses changed.
4515 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4517 * fns.c (concat): Minor tuning based on overflow analysis.
4518 This doesn't fix any bugs. Use int to hold character, instead
4519 of constantly refetching from Emacs object. Use XFASTINT, not
4520 XINT, for value known to be a character. Don't bother comparing
4521 a single byte to 0400, as it's always less.
4523 * floatfns.c (Fexpt):
4524 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4526 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4529 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4531 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4532 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4533 incorrectly succeed when S was a string, because 4294967386 was
4534 truncated before it was used.
4536 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4537 Otherwise, an out-of-range integer could cause undefined behavior
4540 * composite.c: Use int, not EMACS_INT, for characters.
4541 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4542 EMACS_INT, for values that are known to be in character range.
4543 This doesn't fix any bugs but is the usual style inside Emacs and
4544 may generate better code on 32-bit machines.
4546 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4547 This is for reasons similar to the recent CHAR_STRING fix.
4548 * charset.c (Fencode_char): Check that character arg is actually
4549 a character. Pass an int to ENCODE_CHAR.
4550 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4551 wider than 'int', as a compile-time check to prevent future regressions
4554 * character.c (char_string): Remove unnecessary casts.
4556 Make sure a 64-bit char is never passed to CHAR_STRING.
4557 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4558 by silently ignoring the top 32 bits, allowing some values
4559 that were far too large to be valid characters.
4560 * character.h: Include <verify.h>.
4561 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4562 arguments are no wider than unsigned, as a compile-time check
4563 to prevent future regressions in this area.
4565 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4566 (Fsubst_char_in_region):
4568 * xdisp.c (decode_mode_spec_coding):
4569 Adjust to CHAR_STRING's new requirement.
4570 * editfns.c (Finsert_char, Fsubst_char_in_region):
4571 * fns.c (concat): Check that character args are actually
4572 characters. Without this test, these functions did the wrong
4573 thing with wildly out-of-range values on 64-bit hosts.
4575 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4576 These casts should not be needed on 32-bit hosts, either.
4577 * keyboard.c (read_char):
4578 * lread.c (Fload): Remove casts to unsigned.
4580 * lisp.h (UNSIGNED_CMP): New macro.
4581 This fixes comparison bugs on 64-bit hosts.
4582 (ASCII_CHAR_P): Use it.
4583 * casefiddle.c (casify_object):
4584 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4585 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4586 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4587 * dispextern.h (FACE_FROM_ID):
4588 * keyboard.c (read_char): Use UNSIGNED_CMP.
4590 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4591 not to EMACS_INT, to avoid GCC warning.
4593 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4595 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4596 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4597 isn't needed on 32-bit machines.
4599 * buffer.c (Fgenerate_new_buffer_name):
4600 Use EMACS_INT for count, not int.
4601 (advance_to_char_boundary): Return EMACS_INT, not int.
4603 * data.c (Qcompiled_function): Now static.
4605 * window.c (window_body_lines): Now static.
4607 * image.c (gif_load): Rename local to avoid shadowing.
4609 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4610 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4611 * alloc.c (make_save_value): Integer argument is now of type
4613 (mark_object): Use ptrdiff_t, not int.
4614 * lisp.h (pD): New macro.
4615 * print.c (print_object): Use it.
4617 * alloc.c: Use EMACS_INT, not int, to count objects.
4618 (total_conses, total_markers, total_symbols, total_vector_size)
4619 (total_free_conses, total_free_markers, total_free_symbols)
4620 (total_free_floats, total_floats, total_free_intervals)
4621 (total_intervals, total_strings, total_free_strings):
4622 Now EMACS_INT, not int. All uses changed.
4623 (Fgarbage_collect): Compute overall total using a double, so that
4624 integer overflow is less likely to be a problem. Check for overflow
4625 when converting back to an integer.
4626 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4627 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4628 These were 'int' variables that could overflow on 64-bit hosts;
4629 they were never used, so remove them instead of repairing them.
4630 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4631 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4632 Previously, this ceilinged at INT_MAX, but that doesn't work on
4634 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4636 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4637 (allocate_vectorlike): Check for ptrdiff_t overflow.
4638 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4639 when a (possibly-narrower) signed value would do just as well.
4640 We prefer using signed arithmetic, to avoid comparison confusion.
4642 * alloc.c: Catch some string size overflows that we were missing.
4643 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4644 for convenience in STRING_BYTES_MAX.
4645 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4646 The definition here is exact; the one in lisp.h was approximate.
4647 (allocate_string_data): Check for string overflow. This catches
4648 some instances we weren't catching before. Also, it catches
4649 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4650 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4651 and ptrdiff_t and EMACS_INT are both 64 bits.
4653 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4654 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4655 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4657 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4659 * alloc.c (Fmake_string): Check for out-of-range init.
4661 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4663 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4665 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4667 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4668 xg_get_default_scrollbar_width.
4670 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4671 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4672 (style_changed_cb): Call update_theme_scrollbar_width and call
4673 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4674 all frames (Bug#8505).
4675 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4676 Call gtk_window_set_resizable if HAVE_GTK3.
4677 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4678 and height if HAVE_GTK3 (Bug#8505).
4679 (scroll_bar_width_for_theme): New variable.
4680 (update_theme_scrollbar_width): New function.
4681 (xg_get_default_scrollbar_width): Move code to
4682 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4683 (xg_initialize): Call update_theme_scrollbar_width.
4685 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4687 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4689 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4691 * frame.c (make_frame): Call other_buffer_safely instead of
4694 * window.c (temp_output_buffer_show): Call display_buffer with
4695 second argument Vtemp_buffer_show_specifiers and reset latter
4696 immediately after the call.
4697 (Vtemp_buffer_show_specifiers): New variable.
4698 (auto_window_vscroll_p, next_screen_context_lines)
4699 (Vscroll_preserve_screen_position): Remove leading asterisks from
4702 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4704 Fix minor problems found by GCC 4.6.0 static checking.
4705 * buffer.c (Qclone_number): Remove for now, as it's unused.
4706 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4707 (record_buffer): Remove unused local.
4708 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4709 (set_frame_buffer_list): Remove; unused.
4710 * frame.h (other_visible_frames): Remove decl.
4711 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4712 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4713 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4715 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4716 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4717 Define only if HAVE_GPM.
4718 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4719 (update_hints_inhibit): Remove; never set. All uses removed.
4720 * widgetprv.h (emacsFrameClassRec): Remove decl.
4721 * window.c (delete_deletable_window): Now returns void, since it
4722 wasn't returning anything.
4723 (compare_window_configurations): Remove unused locals.
4724 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4725 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4726 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4727 the same widths as pointers. This follows up on the 2011-05-06 patch.
4728 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4729 * xterm.h: Likewise.
4730 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4732 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4734 * makefile.w32-in: Update dependencies.
4735 (LISP_H): Add lib/intprops.h.
4737 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4739 * image.c (gif_load): Add animation frame delay to the metadata.
4740 (syms_of_image): Use DEFSYM. New symbol `delay'.
4742 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4744 * window.c (delete_deletable_window): Re-add.
4745 (Fset_window_configuration): Rewrite to handle dead buffers and
4746 consequently deletable windows.
4747 (window_tree, Fwindow_tree): Remove. Supply functionality in
4749 (compare_window_configurations): Simplify code.
4751 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4753 * image.c (imagemagick_load_image): Fix type mismatch.
4754 (Fimagemagick_types): Likewise.
4756 * window.h (replace_buffer_in_windows): Declare.
4758 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4760 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4761 Qclone_number. Remove external declaration of Qdelete_window.
4762 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4764 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4765 Run Qbuffer_list_update_hook if allowed.
4766 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4767 buffer list implementation.
4768 (other_buffer_safely): New function.
4769 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4770 calls to replace_buffer_in_windows and
4771 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4773 (record_buffer): Inhibit quitting and rewrite using quittable
4774 functions. Run Qbuffer_list_update_hook if allowed.
4775 (Frecord_buffer, Funrecord_buffer): New functions.
4776 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4777 Move switch-to-buffer to window.el.
4778 (bury-buffer): Move to window.el.
4779 (Vbuffer_list_update_hook): New variable.
4781 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4784 * window.h (resize_frame_windows): Move up in code.
4785 (Fwindow_frame): Remove EXFUN.
4786 (replace_buffer_in_all_windows): Remove prototype.
4787 (replace_buffer_in_windows_safely): Add prototype.
4789 * window.c: Declare Qdelete_window static again. Move down
4790 declaration of select_count.
4791 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4792 (Fother_window): Move to window.el.
4793 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4794 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4795 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4797 (replace_buffer_in_windows): Implement by calling
4798 Qreplace_buffer_in_windows.
4799 (replace_buffer_in_all_windows): Remove with some functionality
4800 moved into replace_buffer_in_windows_safely.
4801 (replace_buffer_in_windows_safely): New function.
4802 (select_window_norecord, select_frame_norecord): Move in front
4803 of run_window_configuration_change_hook. Remove now obsolete
4805 (Fset_window_buffer): Rewrite doc-string.
4806 Call Qrecord_window_buffer.
4807 (keys_of_window): Move binding for other-window to window.el.
4809 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4811 * dispextern.h (struct image): Replace data member, whose int_val
4812 and ptr_val fields were not used by anything, with a single
4815 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4816 (gif_clear_image, gif_load, imagemagick_load_image)
4817 (gs_clear_image, gs_load): Callers changed.
4819 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4821 * buffer.h: Include <time.h>, for time_t.
4822 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4824 Fix minor problems found by static checking.
4826 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4828 Make identifiers static if they are not used in other modules.
4829 * data.c (Qcompiled_function, Qframe, Qvector):
4830 * image.c (QimageMagick, Qsvg):
4831 * minibuf.c (Qmetadata):
4832 * window.c (resize_window_check, resize_root_window): Now static.
4833 * window.h (resize_window_check, resize_root_window): Remove decls.
4835 * window.c (window_deletion_count, delete_deletable_window):
4837 (window_body_lines): Now static.
4838 (Fdelete_other_windows_internal): Mark vars as initialized.
4839 Make sure 'resize_failed' is initialized.
4840 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4841 (resize_window_apply): Remove unused local.
4842 * window.h (delete_deletable_window): Remove decl.
4844 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4845 (imagemagick_load_image): Fix pointer signedness problem by changing
4846 last arg from unsigned char * to char *. All uses changed.
4847 Also, fix a local for similar reasons.
4848 Remove unused locals. Remove locals to avoid shadowing.
4849 (fn_rsvg_handle_free): Remove; unused.
4850 (svg_load, svg_load_image): Fix pointer signedness problem.
4851 (imagemagick_load_image): Don't use garbage pointer image_wand.
4853 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4855 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4857 * image.c (gif_load): Fix omitted cast error introduced by
4860 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4862 * window.h (resize_proportionally, orig_total_lines)
4863 (orig_top_line): Remove from window structure.
4864 (set_window_height, set_window_width, change_window_heights)
4865 (Fdelete_window): Remove prototypes.
4866 (resize_frame_windows): Remove duplicate declaration.
4868 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4870 * window.h (resize_frame_windows, resize_window_check)
4871 (delete_deletable_window, resize_root_window)
4872 (resize_frame_windows): Declare prototypes.
4874 * window.c (resize_window_apply): Make definition be "static" to
4875 match the prototype.
4877 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4879 * window.c: Remove declarations of Qwindow_size_fixed,
4880 window_min_size_1, window_min_size_2, window_min_size,
4881 size_window, window_fixed_size_p, enlarge_window, delete_window.
4882 Remove static from declaration of Qdelete_window, it's
4883 temporarily needed by Fbury_buffer.
4884 (replace_window): Don't assign orig_top_line and
4886 (Fdelete_window, delete_window): Remove. Window deletion is
4887 handled by window.el.
4888 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4889 Replace Fdelete_window calls with calls to Qdelete_window.
4890 (Fdelete_other_windows): Remove. Deleting other windows is
4891 handled by window.el.
4892 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4893 handled in window.el.
4894 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4895 Window minimum sizes are handled in window.el.
4896 (shrink_windows, size_window, set_window_height)
4897 (set_window_width, change_window_heights, window_height)
4898 (window_width, CURBEG, CURSIZE, enlarge_window)
4899 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4900 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4901 handled in window.el.
4902 (make_dummy_parent): Rename to make_parent_window and give it a
4903 second argument horflag.
4904 (make_window): Don't set resize_proportionally any more.
4905 (Fsplit_window): Remove. Windows are split in window.el.
4906 (save_restore_action, save_restore_orig_size)
4907 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4908 Resize mini windows in window.el.
4909 (grow_mini_window, shrink_mini_window): Implement by calling
4910 Qresize_root_window_vertically, resize_window_check and
4911 resize_window_apply.
4912 (saved_window, Fset_window_configuration, save_window_save):
4913 Do not handle orig_top_line, orig_total_lines, and
4914 resize_proportionally.
4915 (window_min_height, window_min_width): Move to window.el.
4916 (keys_of_window): Move bindings for delete-other-windows,
4917 split-window, delete-window and enlarge-window to window.el.
4919 * buffer.c: Temporarily extern Qdelete_window.
4920 (Fbury_buffer): Temporarily call Qdelete_window instead of
4921 Fdelete_window (Fbury_buffer will move to window.el soon).
4923 * frame.c (set_menu_bar_lines_1): Remove code handling
4924 orig_top_line and orig_total_lines.
4926 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4927 set_window_height but set heights directly.
4928 (change_frame_size_1): Use resize_frame_windows.
4930 * xdisp.c (init_xdisp): Don't use set_window_height but set
4933 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4934 Use resize_frame_windows instead of change_window_heights and run
4935 run_window_configuration_change_hook.
4937 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4938 instead of change_window_heights and run
4939 run_window_configuration_change_hook.
4941 2011-06-09 Martin Rudalics <rudalics@gmx.at>
4943 * window.c (replace_window): Rename second argument REPLACEMENT to
4944 NEW. New third argument SETFLAG. Rewrite.
4945 (delete_window, make_dummy_parent): Call replace_window with
4947 (window_list_1): Move down in code.
4948 (run_window_configuration_change_hook): Move set_buffer part
4949 before select_frame_norecord part in order to unwind correctly.
4950 Rename count1 to count.
4951 (recombine_windows, delete_deletable_window, resize_root_window)
4952 (Fdelete_other_windows_internal)
4953 (Frun_window_configuration_change_hook, make_parent_window)
4954 (resize_window_check, resize_window_apply, Fresize_window_apply)
4955 (resize_frame_windows, Fsplit_window_internal)
4956 (Fdelete_window_internal, Fresize_mini_window_internal):
4958 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4960 2011-06-08 Martin Rudalics <rudalics@gmx.at>
4962 * window.h (window): Add some new members to window structure -
4963 normal_lines, normal_cols, new_total, new_normal, clone_number,
4964 splits, nest, prev_buffers, next_buffers.
4965 (WINDOW_TOTAL_SIZE): Move here from window.c.
4966 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
4968 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4970 (make_dummy_parent): Set new members of windows structure.
4971 (make_window): Move down in code. Handle new members of window
4973 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4974 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4975 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4976 (Fset_window_prev_buffers, Fwindow_next_buffers)
4977 (Fset_window_next_buffers, Fset_window_clone_number):
4979 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4980 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4982 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4983 Argument WINDOW can be now internal window too.
4984 (Fwindow_use_time): Move up in code.
4985 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4987 (Fset_window_configuration, saved_window)
4988 (Fcurrent_window_configuration, save_window_save): Handle new
4989 members of window structure.
4990 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4991 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4992 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4993 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4994 Qget_mru_window, Qresize_root_window,
4995 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4996 Qauto_buffer_name; staticpro them.
4998 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5000 * window.c (Fwindow_total_size, Fwindow_left_column)
5001 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5002 (Fwindow_list_1): New functions.
5003 (window_box_text_cols): Replace with window_body_cols.
5004 (Fwindow_width, Fscroll_left, Fscroll_right):
5005 Use window_body_cols instead of window_box_text_cols.
5006 (delete_window, Fset_window_configuration):
5007 Call delete_all_subwindows with window as argument.
5008 (delete_all_subwindows): Take a window as argument and not a
5010 (window_loop): Remove handling of GET_LRU_WINDOW and
5012 (Fget_lru_window, Fget_largest_window): Move to window.el.
5014 * window.h: Extern window_body_cols instead of
5015 window_box_text_cols. delete_all_subwindows now takes a
5016 Lisp_Object as argument.
5018 * indent.c (compute_motion, Fcompute_motion):
5019 Use window_body_cols instead of window_box_text_cols.
5021 * frame.c (delete_frame): Call delete_all_subwindows with root
5024 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5026 * fns.c (Fputhash): Document return value.
5028 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5030 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5032 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5034 Cons<->int and similar integer overflow fixes (Bug#8794).
5036 Check for overflow when converting integer to cons and back.
5037 * charset.c (Fdefine_charset_internal, Fdecode_char):
5038 Use cons_to_unsigned to catch overflow.
5039 (Fencode_char): Use INTEGER_TO_CONS.
5040 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5041 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5042 * data.c (long_to_cons, cons_to_long): Remove.
5043 (cons_to_unsigned, cons_to_signed): New functions.
5044 These signal an error for invalid or out-of-range values.
5045 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5046 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5047 * font.c (Ffont_variation_glyphs):
5048 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5049 * lisp.h: Include <intprops.h>.
5050 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5051 (cons_to_signed, cons_to_unsigned): New decls.
5052 (long_to_cons, cons_to_long): Remove decls.
5053 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5054 (Fprimitive_undo): Use CONS_TO_INTEGER.
5055 * xfns.c (Fx_window_property): Likewise.
5056 * xselect.c: Include <limits.h>.
5057 (x_own_selection, selection_data_to_lisp_data):
5058 Use INTEGER_TO_CONS.
5059 (x_handle_selection_request, x_handle_selection_clear)
5060 (x_get_foreign_selection, Fx_disown_selection_internal)
5061 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5062 (lisp_data_to_selection_data): Use cons_to_unsigned.
5063 (x_fill_property_data): Use cons_to_signed.
5064 Report values out of range.
5066 Check for buffer and string overflow more precisely.
5067 * buffer.h (BUF_BYTES_MAX): New macro.
5068 * lisp.h (STRING_BYTES_MAX): New macro.
5069 * alloc.c (Fmake_string):
5070 * character.c (string_escape_byte8):
5071 * coding.c (coding_alloc_by_realloc):
5072 * doprnt.c (doprnt):
5073 * editfns.c (Fformat):
5075 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5076 since they may not be the same number.
5077 * editfns.c (Finsert_char):
5078 * fileio.c (Finsert_file_contents):
5079 Likewise for BUF_BYTES_MAX.
5081 * image.c: Use ptrdiff_t, not int, for sizes.
5082 (slurp_file): Switch from int to ptrdiff_t.
5084 (slurp_file): Check that file size fits in both size_t (for
5085 malloc) and ptrdiff_t (for sanity and safety).
5087 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5088 if b->modtime has its maximal value.
5090 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5092 Don't assume time_t can fit into int.
5093 * buffer.h (struct buffer.modtime): Now time_t, not int.
5094 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5095 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5097 Minor fixes for signed vs unsigned integers.
5098 * character.h (MAYBE_UNIFY_CHAR):
5099 * charset.c (maybe_unify_char):
5100 * keyboard.c (read_char, reorder_modifiers):
5101 XINT -> XFASTINT, since the integer must be nonnegative.
5102 * ftfont.c (ftfont_spec_pattern):
5103 * keymap.c (access_keymap, silly_event_symbol_error):
5104 XUINT -> XFASTINT, since the integer must be nonnegative.
5105 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5106 since it makes no difference and we prefer signed.
5107 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5108 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5111 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5113 * window.h (Fwindow_frame): Declare.
5115 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5117 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5118 (SPARE_MEMORY): Always define.
5119 (LARGE_REQUEST): Remove.
5120 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5122 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5124 * lisp.h: Move EXFUNS for Fframe_root_window,
5125 Fframe_first_window and Fset_frame_selected_window to window.h.
5127 * window.h: Move EXFUNS for Fframe_root_window,
5128 Fframe_first_window and Fset_frame_selected_window here from
5131 * frame.c (Fwindow_frame, Fframe_first_window)
5132 (Fframe_root_window, Fframe_selected_window)
5133 (Fset_frame_selected_window): Move to window.c.
5134 (Factive_minibuffer_window): Move to minibuf.c.
5135 (Fother_visible_frames_p): New function.
5137 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5139 * window.c (decode_window, decode_any_window): Move up in code.
5140 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5141 (inhibit_frame_unsplittable): Remove unused variable.
5142 (Fwindow_buffer): Move up and rewrite doc-string.
5143 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5144 (Fwindow_prev): New functions.
5145 (Fwindow_frame): Move here from frame.c. Accept any window as
5147 (Fframe_root_window, Fframe_first_window)
5148 (Fframe_selected_window): Move here from frame.c. Accept frame
5149 or arbitrary window as argument. Update doc-strings.
5150 (Fminibuffer_window): Move up in code.
5151 (Fwindow_minibuffer_p): Move up in code and simplify.
5152 (Fset_frame_selected_window): Move here from frame.c.
5154 (Fselected_window, select_window, Fselect_window): Move up in
5155 code. Minor doc-string fixes.
5157 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5159 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5160 Do not assume that spare memory exists; that assumption is valid
5161 only if SYSTEM_MALLOC.
5162 (LARGE_REQUEST): New macro, so that the issue of large requests
5163 is separated from the issue of spare memory.
5165 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5167 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5170 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5172 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5175 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5177 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5179 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5181 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5182 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5184 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5186 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5188 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5190 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5191 (x_clipboard_manager_save): Add return value.
5192 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5194 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5195 Obey Vx_select_enable_clipboard_manager. Catch errors in
5196 x_clipboard_manager_save (Bug#8779).
5197 (Vx_select_enable_clipboard_manager): New variable.
5198 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5200 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5202 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5204 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5206 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5207 in the current matrix if keep_current_p is non-zero.
5209 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5211 * bidi.c (bidi_level_of_next_char): Fix last change.
5213 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5215 Support bidi reordering of text covered by display properties.
5217 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5218 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5219 (bidi_cache_search, bidi_cache_iterator_state)
5220 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5221 (bidi_level_of_next_char, bidi_move_to_visually_next):
5222 Support character positions inside a run of characters covered by a
5224 (bidi_paragraph_init, bidi_resolve_explicit_1)
5225 (bidi_level_of_next_char): Call bidi_fetch_char and
5226 bidi_fetch_char_advance instead of FETCH_CHAR and
5228 (bidi_init_it): Initialize new members.
5229 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5231 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5232 instead of using explicit *_CHAR codes.
5233 (bidi_resolve_explicit, bidi_resolve_weak):
5234 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5235 bidirectional text is supported only in multibyte buffers.
5236 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5237 it to initialize the frame_window_p member of struct bidi_it.
5238 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5239 (bidi_resolve_explicit, bidi_resolve_weak)
5240 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5241 bidi_it->nchars is non-positive.
5242 (bidi_level_of_next_char): Don't try to lookup the cache for the
5243 next/previous character if nothing is cached there yet, or if we
5244 were just reseat()'ed to a new position.
5246 * xdisp.c (set_cursor_from_row): Set start and stop points
5247 according to the row's direction when priming the loop that looks
5248 for the glyph on which to display cursor.
5249 (single_display_spec_intangible_p): Function deleted.
5250 (display_prop_intangible_p): Reimplement to call
5251 handle_display_spec instead of single_display_spec_intangible_p.
5252 Accept 3 additional arguments needed by handle_display_spec.
5253 This fixes incorrect cursor motion across display property with complex
5254 values: lists, `(when COND...)' forms, etc.
5255 (single_display_spec_string_p): Support property values that are
5256 lists with the argument STRING its top-level element.
5257 (display_prop_string_p): Fix the condition for processing a
5258 property that is a list to be consistent with handle_display_spec.
5259 (handle_display_spec): New function, refactored from the
5260 last portion of handle_display_prop.
5261 (compute_display_string_pos): Accept additional argument
5262 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5263 value of a `display' property is a "replacing spec".
5264 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5265 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5266 the display property, but just return a value indicating whether
5267 the display property will replace the characters it covers.
5268 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5269 frame_window_p members of struct bidi_it.
5270 (compute_display_string_pos, compute_display_string_end):
5272 (push_it): Accept second argument POSITION, where pop_it should
5273 jump to continue iteration.
5274 (reseat_1): Initialize bidi_it.disp_pos.
5276 * keyboard.c (adjust_point_for_property): Adjust the call to
5277 display_prop_intangible_p to its new signature.
5279 * dispextern.h (struct bidi_it): New member frame_window_p.
5280 (bidi_init_it): Update prototypes.
5281 (display_prop_intangible_p): Update prototype.
5282 (compute_display_string_pos, compute_display_string_end):
5284 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5287 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5289 Malloc failure behavior now depends on size of allocation.
5290 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5291 * lisp.h: Change signatures accordingly.
5292 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5293 All callers changed. (Bug#8762)
5295 * gnutls.c: Use Emacs's memory allocators.
5296 Without this change, the gnutls library would invoke malloc etc.
5297 directly, which causes problems on non-SYNC_INPUT hosts, and which
5298 runs afoul of improving memory_full behavior. (Bug#8761)
5299 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5300 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5301 xfree instead of the default malloc, realloc, free.
5302 (Fgnutls_boot): No need to check for memory allocation failure,
5303 since xmalloc does that for us.
5305 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5306 * category.c (hash_get_category_set):
5307 * ccl.c (ccl_driver):
5308 * charset.c (Fdefine_charset_internal):
5309 * charset.h (struct charset.hash_index):
5310 * composite.c (get_composition_id, gstring_lookup_cache)
5311 (composition_gstring_put_cache):
5312 * composite.h (struct composition.hash_index):
5313 * dispextern.h (struct image.hash):
5314 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5315 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5316 (hashfn_equal, hashfn_user_defined, make_hash_table)
5317 (maybe_resize_hash_table, hash_lookup, hash_put)
5318 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5319 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5320 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5321 * image.c (make_image, search_image_cache, lookup_image)
5322 (xpm_put_color_table_h):
5323 * lisp.h (struct Lisp_Hash_Table):
5324 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5325 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5326 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5327 * alloc.c (allocate_vectorlike):
5328 Check for overflow in vector size calculations.
5329 * ccl.c (ccl_driver):
5330 Check for overflow when converting EMACS_INT to int.
5331 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5332 need to be updated by these changes.
5333 * fns.c (make_hash_table, maybe_resize_hash_table):
5334 Check for integer overflow with large hash tables.
5335 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5336 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5337 (SXHASH_REDUCE): New macro.
5338 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5339 Use it instead of discarding useful hash info with large hash values.
5340 (sxhash_float): New function.
5341 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5342 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5343 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5344 Rewrite to use FIXNUM_BITS, as this simplifies things.
5345 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5346 Adjust signatures to match updated version of code.
5347 (consing_since_gc): Now EMACS_INT, since a single hash table can
5348 use more than INT_MAX bytes.
5350 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5352 Make it possible to build with GCC-4.6+ -O2 -flto.
5354 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5356 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5358 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5359 Call minibuffer-inactive-mode.
5361 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5363 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5364 Update dependencies.
5366 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5368 * data.c (init_data): Remove code for UTS, this system is not
5371 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5373 Don't force ./temacs to start in terminal mode.
5375 * frame.c (make_initial_frame): Initialize faces in all cases, not
5376 only when CANNOT_DUMP is defined.
5377 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5379 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5381 * dispnew.c (add_window_display_history): Use const for the string
5382 pointer. Remove declaration, not needed.
5384 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5386 Use 'inline', not 'INLINE'.
5387 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5388 * alloc.c, fontset.c (INLINE): Remove.
5389 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5390 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5391 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5392 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5393 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5395 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5397 Make it possible to run ./temacs.
5399 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5400 syms_of_callproc does the same thing. Remove test for
5401 "initialized", do it in the caller.
5402 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5404 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5406 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5407 (read_minibuf): Use get_minibuffer.
5408 (syms_of_minibuf): Use DEFSYM.
5409 (Qmetadata): New var.
5410 * data.c (Qbuffer): Don't make it static.
5411 (syms_of_data): Use DEFSYM.
5413 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5415 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5416 (CCL_CODE_MIN): New macro.
5418 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5420 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5422 * eval.c (Qdebug): Now static.
5423 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5424 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5425 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5427 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5429 * image.c: Various fixes to ImageMagick code comments.
5430 (Fimagemagick_types): Doc fix.
5432 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5434 Minor fixes prompted by GCC 4.6.0 warnings.
5436 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5438 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5439 (x_clipboard_manager_save_all): Move extern decl to ...
5440 * xterm.h: ... here, so that it can be checked for consistency.
5442 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5444 * xselect.c (x_clipboard_manager_save_frame)
5445 (x_clipboard_manager_save_all): New functions.
5446 (Fx_clipboard_manager_save): Lisp function deleted.
5448 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5449 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5451 * xterm.h: Update prototype.
5453 2011-05-28 William Xu <william.xwl@gmail.com>
5455 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5458 2011-05-28 Jim Meyering <meyering@redhat.com>
5460 Avoid a sign-extension bug in crypto_hash_function.
5461 * fns.c (to_uchar): Define.
5462 (crypto_hash_function): Use it to convert some newly-signed
5463 variables to unsigned, to avoid sign-extension bugs. For example,
5464 without this change, (md5 "truc") would evaluate to
5465 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5466 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5467 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5469 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5471 Integer overflow fixes.
5473 * dbusbind.c: Serial number integer overflow fixes.
5474 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5475 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5476 to hold a serial number that is too large for a fixnum.
5477 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5478 Check for serial numbers out of range. Decode any serial number
5479 that was so large that it became a float. (Bug#8722)
5481 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5482 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5483 Use XFASTINT rather than XUINT when numbers are nonnegative.
5484 (xd_append_arg, Fdbus_method_return_internal):
5485 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5486 arguments, check that Lisp number is nonnegative, rather than
5487 silently wrapping negative numbers around. (Bug#8722)
5488 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5491 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5493 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5495 ccl: add integer overflow checks
5496 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5497 (IN_INT_RANGE): New macros.
5498 (ccl_driver): Use them to check for integer overflow when
5499 decoding a CCL program. Many of the new checks are whether XINT (x)
5500 fits in int; it doesn't always, on 64-bit hosts. The new version
5501 doesn't catch all possible integer overflows, but it's an
5502 improvement. (Bug#8719)
5504 * alloc.c (make_event_array): Use XINT, not XUINT.
5505 There's no need for unsigned here.
5507 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5508 This follows up to the 2011-05-06 change that substituted uintptr_t
5509 for EMACS_INT. This case wasn't caught back then.
5511 Rework Fformat to avoid integer overflow issues.
5512 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5513 now (part of C89). Include <verify.h>.
5514 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5515 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5516 (Fformat): Avoid the prepass trying to compute sizes; it was only
5517 approximate and thus did not catch overflow reliably. Instead, walk
5518 through the format just once, formatting and computing sizes as we go,
5519 checking for integer overflow at every step, and allocating a larger
5520 buffer as needed. Keep track separately whether the format is
5521 multibyte. Keep only the most-recently calculated precision, rather
5522 than them all. Record whether each argument has been converted to
5523 string. Use EMACS_INT, not int, for byte and char and arg counts.
5524 Support field widths and precisions larger than INT_MAX. Avoid
5525 sprintf's undefined behavior with conversion specifications such as %#d
5526 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5527 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5528 formatting out-of-range floating point numbers with int
5531 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5533 * data.c: Avoid integer truncation in expressions involving floats.
5534 * data.c: Include <intprops.h>.
5535 (arith_driver): When there's an integer overflow in an expression
5536 involving floating point, convert the integers to floating point
5537 so that the resulting value does not suffer from catastrophic
5538 integer truncation. For example, on a 64-bit host (* 4
5539 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5540 Do not rely on undefined behavior after integer overflow.
5542 merge count_size_as_multibyte, parse_str_to_multibyte
5543 * character.c, character.h (count_size_as_multibyte):
5544 Rename from parse_str_to_multibyte; all uses changed.
5545 Check for integer overflow.
5546 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5547 since it's now a duplicate of the other. This is more of
5548 a character than a buffer op, so better that it's in character.c.
5549 * fns.c, print.c: Adjust to above changes.
5551 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5553 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5555 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5557 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5558 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5559 (x_clipboard_manager_save): Now static.
5560 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5562 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5563 (crypto_hash_function): Now static.
5564 Fix pointer signedness problems. Avoid unnecessary initializations.
5566 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5568 * termhooks.h (Vselection_alist): Make it terminal-local.
5570 * terminal.c (create_terminal): Initialize it.
5572 * xselect.c: Support for clipboard managers.
5573 (Vselection_alist): Move to termhooks.h as terminal-local var.
5574 (LOCAL_SELECTION): New macro.
5575 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5576 (symbol_to_x_atom): Remove gratuitous arg.
5577 (x_handle_selection_request, lisp_data_to_selection_data)
5578 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5579 (x_own_selection, x_get_local_selection, x_convert_selection):
5580 New arg, specifying work frame. Use terminal-local Vselection_alist.
5581 (some_frame_on_display): Delete unused function.
5582 (Fx_own_selection_internal, Fx_get_selection_internal)
5583 (Fx_disown_selection_internal, Fx_selection_owner_p)
5584 (Fx_selection_exists_p): New optional frame arg.
5585 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5586 (x_handle_selection_clear): Don't treat other terminals with the
5587 same keyboard specially. Use the terminal-local Vselection_alist.
5588 (x_clear_frame_selections): Use Frun_hook_with_args.
5590 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5592 * xterm.h: Add support for those atoms.
5594 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5596 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5597 (converted_selections, conversion_fail_tag): New global variables.
5598 (x_selection_request_lisp_error): Free the above.
5599 (x_get_local_selection): Remove unnecessary code.
5600 (x_reply_selection_request): Args changed; handle arbitrary array
5601 of converted selections stored in converted_selections.
5602 Separate the XChangeProperty and SelectionNotify steps.
5603 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5604 (x_convert_selection): New function.
5605 (x_handle_selection_event): Simplify.
5606 (x_get_foreign_selection): Don't ignore incoming requests while
5607 waiting for an answer; this will fail when we implement
5608 SAVE_TARGETS, and seems unnecessary anyway.
5609 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5610 (Vx_sent_selection_functions): Doc fix.
5612 2011-05-26 Leo Liu <sdl.web@gmail.com>
5614 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5616 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5618 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5620 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5621 for fringe update if it has periodic bitmap.
5622 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5623 and fringe_bitmap_periodic_p.
5625 * fringe.c (get_fringe_bitmap_data): New function.
5626 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5627 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5628 row. Mark glyph row for fringe update if periodicity changed.
5630 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5631 for fringe update unless it has periodic bitmap.
5633 2011-05-25 Kenichi Handa <handa@m17n.org>
5635 * xdisp.c (get_next_display_element): Set correct it->face_id for
5636 a static composition.
5638 2011-05-24 Leo Liu <sdl.web@gmail.com>
5641 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5643 * fns.c (crypto_hash_function, Fsha1): New function.
5644 (Fmd5): Use crypto_hash_function.
5645 (syms_of_fns): Add Ssha1.
5647 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5649 * gnutls.c: Remove unused macros.
5650 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5651 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5652 Remove macros that are defined and never used.
5653 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5655 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5657 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5658 (Fx_get_selection_internal): Minor cleanup.
5659 (Fx_own_selection_internal): Rename arguments for consistency with
5662 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5664 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5666 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5668 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5670 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5672 * dispnew.c (scrolling_window): Don't exclude the case that the
5673 last enabled row in the desired matrix touches the bottom boundary.
5675 2011-05-21 Glenn Morris <rgm@gnu.org>
5677 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5678 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5679 and add some more files.
5681 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5683 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5684 report_file_error introduced by the change from 2011-05-07.
5686 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5688 * systime.h (Time): Define only if emacs is defined.
5689 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5690 where the include path doesn't have X11/X.h by default. See
5691 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5693 2011-05-20 Kenichi Handa <handa@m17n.org>
5695 * composite.c (find_automatic_composition): Fix previous change.
5697 2011-05-20 Glenn Morris <rgm@gnu.org>
5699 * lisp.mk: New file, split from Makefile.in.
5700 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5701 (shortlisp): Remove.
5702 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5704 2011-05-19 Glenn Morris <rgm@gnu.org>
5706 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5707 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5708 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5709 (lisp): Set the order to that of loadup.el.
5710 (shortlisp): Make it a copy of $lisp.
5711 (SOME_MACHINE_LISP): Remove.
5712 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5713 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5715 2011-05-18 Kenichi Handa <handa@m17n.org>
5717 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5718 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5719 (find_automatic_composition): Mostly rewrite for efficiency.
5721 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5723 * makefile.w32-in: Update dependencies.
5725 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5727 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5728 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5730 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5732 Fix some integer overflow issues, such as string length overflow.
5734 * insdel.c (count_size_as_multibyte): Check for string overflow.
5736 * character.c (lisp_string_width): Check for string overflow.
5737 Use EMACS_INT, not int, for string indexes and lengths; in
5738 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5739 the resulting string length overflows an EMACS_INT; instead,
5740 report a string overflow if no precision given. When checking for
5741 precision exhaustion, use a check that cannot possibly have
5742 integer overflow. (Bug#8675)
5743 * character.h (lisp_string_width): Adjust to new signature.
5745 * alloc.c (string_overflow): New function.
5746 (Fmake_string): Use it. This doesn't change behavior, but saves
5747 a few bytes and will simplify future changes.
5748 * character.c (string_escape_byte8): Likewise.
5749 * lisp.h (string_overflow): New decl.
5751 Fixups, following up to the user-interface timestamp change.
5752 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5753 for UI timestamps, instead of unsigned long.
5754 * msdos.c (mouse_get_pos): Likewise.
5755 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5756 * w32gui.h (Time): Define by including "systime.h" rather than by
5757 declaring it ourselves. (Bug#8664)
5759 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5760 * image.c (clear_image_cache): Likewise.
5762 * term.c (term_mouse_position): Don't assume time_t wraparound.
5764 Be more systematic about user-interface timestamps.
5765 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5766 and sometimes 'EMACS_UINT', to represent these timestamps.
5767 This change causes it to use 'Time' uniformly, as that's what X uses.
5768 This makes the code easier to follow, and makes it easier to catch
5769 integer overflow bugs such as Bug#8664.
5770 * frame.c (Fmouse_position, Fmouse_pixel_position):
5771 Use Time, not unsigned long, for user-interface timestamps.
5772 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5773 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5774 * keyboard.h (last_event_timestamp): Likewise.
5775 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5776 * menu.h (xmenu_show): Likewise.
5777 * term.c (term_mouse_position): Likewise.
5778 * termhooks.h (struct input_event.timestamp): Likewise.
5779 (struct terminal.mouse_position_hook): Likewise.
5780 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5781 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5782 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5783 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5785 * menu.h, termhooks.h: Include "systime.h", for Time.
5787 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5788 Don't assume that the difference between two unsigned long values
5789 can fit into an integer. At this point, we know button_down_time
5790 <= event->timestamp, so the difference must be nonnegative, so
5791 there's no need to cast the result if double-click-time is
5792 nonnegative, as it should be; check that it's nonnegative, just in
5793 case. This bug is triggered when events are more than 2**31 ms
5794 apart (about 25 days). (Bug#8664)
5796 * xselect.c (last_event_timestamp): Remove duplicate decl.
5797 (x_own_selection): Remove needless cast to unsigned long.
5799 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5800 that always fit in int. Use a sentinel instead of a counter, to
5801 avoid a temp and to allay GCC's concerns about possible int overflow.
5802 * frame.h (struct frame): Use int for menu_bar_items_used
5803 instead of EMACS_INT, since it always fits in int.
5805 * menu.c (grow_menu_items): Check for int overflow.
5807 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5809 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5810 Before, the code was not consistent. These values cannot exceed
5811 2**31 - 1 so there's no need to make them unsigned.
5812 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5813 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5814 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5816 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5818 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5819 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5820 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5821 presumably because the widths might not match.
5823 * window.c (size_window): Avoid needless test at loop start.
5825 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5827 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5829 2011-05-12 Drew Adams <drew.adams@oracle.com>
5831 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5833 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5835 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5836 `width' to `bar_area_x' and `bar_area_width', respectively.
5837 (x_scroll_run): Take account of fringe background extension.
5839 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5840 Rename local vars `left' and `width' to `bar_area_x' and
5841 `bar_area_width', respectively.
5842 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5843 background extension.
5845 2011-05-10 Jim Meyering <meyering@redhat.com>
5847 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5849 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5851 * image.c (Finit_image_library): Return t for built-in image types,
5852 like pbm and xbm. (Bug#8640)
5854 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5856 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5858 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5860 * w32console.c (Fset_screen_color): Doc fix.
5861 (Fget_screen_color): New function.
5862 (syms_of_ntterm): Defsubr it.
5864 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5865 unlink the temporary file if Fcall_process didn't create it in the
5867 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5868 child process will be redirected to a file specified with `:file'.
5869 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5870 cue to call_process_cleanup not to close that handle.
5872 2011-05-07 Ben Key <bkey76@gmail.com>
5874 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5875 one of two shell specific rules, either bootstrap-temacs-CMD or
5876 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5877 to the previous implementation of the bootstrap-temacs rule.
5878 The bootstrap-temacs-CMD rule is similar to the previous
5879 implementation of the bootstrap-temacs rule except that it
5880 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5883 These changes, along with some changes to nt/configure.bat,
5884 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5885 earlier fix to add support for --cflags and --ldflags options
5886 that include quotes so that it works whether make uses cmd or
5889 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5891 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5892 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5894 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5895 a string. Handle both cases.
5896 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5897 (Fdbus_register_method): Use Qinvalid_function.
5899 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5901 * makefile.w32-in: Update dependencies.
5902 (LISP_H): Add inttypes.h and stdin.h.
5903 (PROCESS_H): Add unistd.h.
5905 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5907 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5908 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5910 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5912 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5914 * term.c (vfatal): Remove stray call to va_end.
5915 It's not needed and the C Standard doesn't allow it here anyway.
5917 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5918 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5920 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5923 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5925 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5927 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5929 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5931 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5933 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5934 * charset.c (Fdefine_charset_internal): Don't initialize
5935 charset.code_space[15]. The value was garbage, on hosts with
5936 32-bit int (Bug#8600).
5938 * lread.c (read_integer): Be more consistent with string-to-number.
5939 Use string_to_number to do the actual conversion; this avoids
5940 rounding errors and fixes some other screwups. Without this fix,
5941 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5942 (digit_to_number): Move earlier, for benefit of read_integer.
5943 Return -1 if the digit is out of range for the base, -2 if it is
5944 not a digit in any supported base. (Bug#8602)
5946 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5948 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5949 to match comment at start of function. This also removes a
5950 GCC warning about overflow in a 32+64-bit port.
5952 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5954 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5955 Reported by Stefan Monnier in
5956 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
5957 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5958 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
5960 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5961 (EMACS_UINTPTR): Likewise, with uintptr_t.
5963 * lisp.h: Prefer 64-bit EMACS_INT if available.
5964 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5965 on 32-bit hosts that have 64-bit int, so that they can access
5967 However, temporarily disable this change unless the temporary
5968 symbol WIDE_EMACS_INT is defined.
5970 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5972 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5973 This removes an assumption that EMACS_INT and long are the same
5974 width as pointers. The assumption is true for Emacs porting targets
5975 now, but we want to make other targets possible.
5976 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5977 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5978 In the rest of the code, change types of integers that hold casted
5979 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5980 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5981 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5982 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5983 No need to cast type when ORing.
5984 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5985 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5986 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5987 assume EMACS_INT is the same width as char *.
5988 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5989 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5990 Remove no-longer-needed casts.
5991 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5992 (xg_tool_bar_help_callback, xg_make_tool_item):
5993 Use EMACS_INTPTR to hold an integer
5994 that will be cast to void *; this can avoid a GCC warning
5995 if EMACS_INT is not the same width as void *.
5996 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5997 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5998 (current_message_1, set_message_1):
5999 Use a local to convert to proper width without a cast.
6000 * xmenu.c (dialog_selection_callback): Likewise.
6002 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6003 Also, don't assume VALBITS / RAND_BITS is less than 5,
6004 and don't rely on undefined behavior when shifting a 1 left into
6006 * lisp.h (get_random): Change signature to match.
6008 * lread.c (hash_string): Use size_t, not int, for hash computation.
6009 Normally we prefer signed values; but hashing is special, because
6010 it's better to use unsigned division on hash table sizes so that
6011 the remainder is nonnegative. Also, size_t is the natural width
6012 for hashing into memory. The previous code used 'int', which doesn't
6013 retain enough info to hash well into very large tables.
6014 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6016 * dbusbind.c: Don't possibly lose pointer info when converting.
6017 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6018 Use XPNTR rather than XHASH, so that the high-order bits of
6019 the pointer aren't lost when converting through void *.
6021 * eval.c (Fautoload): Don't double-shift a pointer.
6023 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6025 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6027 * gnutls.c (DEF_GNUTLS_FN):
6028 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6030 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6032 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6035 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6037 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6038 New version that can reserve upto 2GB of heap space.
6040 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6042 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6044 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6046 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6047 `gnutls_certificate_set_x509_key_file'.
6049 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6051 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6052 Update dependencies.
6054 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6056 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6057 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6058 Remove unused parameter `fildes'.
6059 * process.c (read_process_output, send_process): Don't pass it.
6061 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6063 Fix previous change: the library cache is defined in w32.c.
6064 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6065 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6067 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6069 Implement dynamic loading of GnuTLS on Windows.
6071 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6072 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6073 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6076 * gnutls.c (Qgnutls_dll): Define.
6077 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6078 (gnutls_*): Declare function pointers.
6079 (init_gnutls_functions): New function to initialize function pointers.
6080 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6081 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6082 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6083 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6084 (emacs_gnutls_write, emacs_gnutls_read)
6085 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6086 (Fgnutls_available_p): New function.
6087 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6088 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6089 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6091 * image.c: Include w32.h.
6092 (Vimage_type_cache): Delete.
6093 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6094 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6095 (w32_delayed_load): Move to w32.c.
6097 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6099 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6100 (w32_delayed_load): Move from image.c. When loading a library, record
6101 its filename in the :loaded-from property of the library id.
6102 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6103 Initialize and staticpro them.
6104 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6106 * process.c: Include lisp.h before w32.h, not after.
6107 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6108 instead of gnutls_record_check_pending.
6110 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6112 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6114 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6115 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6118 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6120 * xterm.c (x_set_frame_alpha): Do not set property on anything
6121 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6123 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6125 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6127 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6129 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6130 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6131 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6132 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6133 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6134 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6135 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6136 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6137 (Qgnutls_bootprop_callbacks_verify): Make static.
6139 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6141 * callproc.c: Indentation fixup.
6143 * sysdep.c (wait_for_termination_1): Make static.
6144 (wait_for_termination, interruptible_wait_for_termination):
6145 Move after wait_for_termination_1.
6147 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6149 * sysdep.c (interruptible_wait_for_termination): New function
6150 which is like wait_for_termination, but allows keyboard
6153 * callproc.c (Fcall_process): Add (:file "file") as an option for
6155 (Fcall_process_region): Ditto.
6157 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6159 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6160 rather than `XVECTOR (FOO)->size'.
6162 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6163 inttypes.h, as a gnulib replacement is used if it not available in
6166 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6168 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6169 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6170 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6172 * coding.c (coding_alloc_by_realloc): Error out if destination
6173 will grow beyond MOST_POSITIVE_FIXNUM.
6174 (decode_coding_emacs_mule): Abort if there isn't enough place in
6175 charbuf for the composition carryover bytes. Reserve an extra
6176 space for up to 2 characters produced in a loop.
6177 (decode_coding_iso_2022): Abort if there isn't enough place in
6178 charbuf for the composition carryover bytes.
6180 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6182 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6183 aborting when %lld or %lll format is passed.
6184 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6185 %llo or %llx format is passed. (Bug#8545)
6187 * window.c (window_scroll_line_based): Use a marker instead of
6188 simple variables to record original value of point. (Bug#7952)
6190 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6191 produced by %s or %c overflows available buffer space. (Bug#8545)
6193 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6195 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6196 (SIZE_MAX): Move defn after all includes, as they might #define it.
6198 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6200 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6202 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6204 * keyboard.c (Qdelayed_warnings_hook): Define.
6205 (command_loop_1): Run `delayed-warnings-hook'
6206 if Vdelayed_warnings_list is non-nil.
6207 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6208 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6210 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6212 * doprnt.c (doprnt): Don't return value smaller than the buffer
6213 size if the message was truncated. (Bug#8545).
6215 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6217 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6218 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6220 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6222 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6224 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6226 * makefile.w32-in: Update dependencies.
6228 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6230 Improve `doprnt' and its usage. (Bug#8545)
6231 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6232 `format_end'. Remove support for %l as a conversion specifier.
6233 Don't use xrealloc. Improve diagnostics when the %l size modifier
6234 is used. Update the commentary.
6236 * eval.c (verror): Simplify calculation of size_t.
6238 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6241 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6243 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6246 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6248 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6249 This makes this file independent of the recent pseudovector change.
6251 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6253 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6255 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6256 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6257 Remove unused local.
6258 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6260 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6261 GCC 4.6.0 optimizes based on type-based alias analysis.
6262 For example, if b is of type struct buffer * and v of type struct
6263 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6264 != &v->size, and therefore "v->size = 1; b->size = 2; return
6265 v->size;" must therefore return 1. This assumption is incorrect
6266 for Emacs, since it type-puns struct Lisp_Vector * with many other
6267 types. To fix this problem, this patch adds a new type struct
6268 vectorlike_header that documents the constraints on layout of vectors
6269 and pseudovectors, and helps optimizing compilers not get fooled
6270 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6271 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6272 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6274 (XSETPVECTYPE): Rewrite in terms of new macro.
6275 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6276 This is a bit clearer, and further avoids the possibility of
6277 undesirable aliasing.
6278 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6279 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6280 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6281 since Lisp_Subr is a special case (no "next" field).
6282 (ASIZE): Now uses header.size rather than size.
6283 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6284 to avoid the hassle of writing XVECTOR (foo)->header.size.
6285 (struct vectorlike_header): New type.
6286 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6287 object, to help avoid aliasing.
6288 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6289 (SUBRP): Likewise, since Lisp_Subr is a special case.
6290 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6291 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6292 (struct Lisp_Hash_Table): Combine first two members into a single
6293 struct vectorlike_header member. All uses of "size" and "next" members
6294 changed to be "header.size" and "header.next".
6295 * buffer.h (struct buffer): Likewise.
6296 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6297 * frame.h (struct frame): Likewise.
6298 * process.h (struct Lisp_Process): Likewise.
6299 * termhooks.h (struct terminal): Likewise.
6300 * window.c (struct save_window_data, struct saved_window): Likewise.
6301 * window.h (struct window): Likewise.
6302 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6303 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6304 * buffer.c (init_buffer_once): Likewise.
6305 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6307 * process.c (Fformat_network_address): Use local var for size,
6310 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6312 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6313 * data.c (atof): Remove decl; no longer used or needed.
6314 (digit_to_number): Move to lread.c.
6315 (Fstring_to_number): Use new string_to_number function, to be
6316 consistent with how the Lisp reader treats infinities and NaNs.
6317 Do not assume that floating-point numbers represent EMACS_INT
6318 without losing information; this is not true on most 64-bit hosts.
6319 Avoid double-rounding errors, by insisting on integers when
6320 parsing non-base-10 numbers, as the documentation specifies.
6321 * lisp.h (string_to_number): New decl, replacing ...
6322 (isfloat_string): Remove.
6323 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6324 (read1): Do not accept +. and -. as integers; this
6325 appears to have been a coding error. Similarly, do not accept
6326 strings like +-1e0 as floating point numbers. Do not report
6327 overflow for integer overflows unless the base is not 10 which
6328 means we have no simple and reliable way to continue.
6329 Break out the floating-point parsing into a new
6330 function string_to_number, so that Fstring_to_number parses
6331 floating point numbers consistently with the Lisp reader.
6332 (digit_to_number): Move here from data.c. Make it static inline.
6333 (E_CHAR, EXP_INT): Remove, replacing with ...
6334 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6335 (string_to_number): New function, replacing isfloat_string.
6336 This function checks for valid syntax and produces the resulting
6337 Lisp float number too. Rework it so that string-to-number
6338 no longer mishandles examples like "1.0e+". Use strtoumax,
6339 so that overflow for non-base-10 numbers is reported only when
6340 there's no portable and simple way to convert to floating point.
6342 * textprop.c (set_text_properties_1): Rewrite for clarity,
6343 and to avoid GCC warning about integer overflow.
6345 * intervals.h (struct interval): Use EMACS_INT for members
6346 where EMACS_UINT might cause problems. See
6347 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6348 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6349 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6351 (offset_intervals): Tell GCC not to worry about length overflow
6352 when negating a negative length.
6354 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6355 (overrun_check_free): Likewise.
6357 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6358 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6361 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6362 (gnutls_make_error): Rename local to avoid shadowing.
6363 (gnutls_emacs_global_deinit): ifdef out; not used.
6364 (Fgnutls_boot): Use const for pointer to readonly storage.
6365 Comment out unused local. Fix pointer signedness problems.
6367 * lread.c (openp): Don't stuff size_t into an 'int'.
6368 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6369 about possible signed overflow.
6371 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6372 (GDK_KEY_g): Don't define if already defined.
6373 (xg_prepare_tooltip): Avoid pointer signedness problem.
6374 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6376 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6377 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6379 * xfns.c (Fx_window_property): Simplify a bit,
6380 to make a bit faster and to avoid GCC 4.6.0 warning.
6381 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6383 * fns.c (internal_equal): Don't assume size_t fits in int.
6385 * alloc.c (compact_small_strings): Tighten assertion a little.
6387 Replace pEd with more-general pI, and fix some printf arg casts.
6388 * lisp.h (pI): New macro, generalizing old pEd macro to other
6389 conversion specifiers. For example, use "...%"pI"d..." rather
6390 than "...%"pEd"...".
6391 (pEd): Remove. All uses replaced with similar uses of pI.
6392 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6393 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6394 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6395 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6396 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6397 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6398 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6400 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6401 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6402 * print.c (safe_debug_print, print_object): Likewise.
6403 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6405 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6406 avoiding the 0 flag, which is not portable.
6407 * process.c (Fmake_network_process): Use pI to avoid cast.
6408 * region-cache.c (pp_cache): Likewise.
6409 * xdisp.c (decode_mode_spec): Likewise.
6410 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6411 behavior on 64-bit hosts with printf arg.
6412 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6413 (x_stop_queuing_selection_requests): Likewise.
6414 (x_get_window_property): Don't truncate byte count to an 'int'
6417 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6418 here, since it parses constructs like leading '-' and spaces,
6419 which are not wanted; and it overflows with large numbers.
6420 Instead, simply match F[0-9]+, which is what is wanted anyway.
6422 * alloc.c: Remove unportable assumptions about struct layout.
6423 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6424 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6425 (allocate_vectorlike, make_pure_vector): Use the new macros,
6426 plus offsetof, to remove unportable assumptions about struct layout.
6427 These assumptions hold on all porting targets that I know of, but
6428 they are not guaranteed, they're easy to remove, and removing them
6429 makes further changes easier.
6431 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6432 This doesn't fix a bug but makes the code clearer.
6433 (string_overrun_cookie): Now const. Use initializers that
6434 don't formally overflow signed char, to avoid warnings.
6435 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6436 can cause Emacs to crash when string overrun checking is enabled.
6437 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6438 multiple of sizeof (EMACS_INT); it need not be, if
6439 alignof(EMACS_INT) < sizeof (EMACS_INT).
6440 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6442 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6444 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6446 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6448 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6449 supposed to be handshaking. (Bug#8556)
6450 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6452 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6454 * lisp.h (Qdebug): List symbol.
6455 * eval.c (Qdebug): Restore global linkage.
6456 * keyboard.c (debug-on-event): New variable.
6457 (handle_user_signal): Break into debugger when debug-on-event
6458 matches the current signal symbol.
6460 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6462 * alloc.c (check_sblock, check_string_bytes)
6463 (check_string_free_list): Convert to standard C.
6465 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6467 * w32.c (emacs_gnutls_push): Fix typo.
6469 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6471 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6472 "cast to pointer from integer of different size".
6474 Improve doprnt and its use in verror. (Bug#8545)
6475 * doprnt.c (doprnt): Document the set of format control sequences
6476 supported by the function. Use SAFE_ALLOCA instead of always
6479 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6480 is one byte too soon. Don't use xrealloc; instead xfree and
6483 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6485 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6488 * gnutls.c: Renamed global_initialized to
6489 gnutls_global_initialized. Added internals for the
6490 :verify-hostname-error, :verify-error, and :verify-flags
6491 parameters of `gnutls-boot' and documented those parameters in the
6492 docstring. Start callback support.
6493 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6494 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6495 on error. Return error code.
6496 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6497 (emacs_gnutls_read): Likewise.
6498 (Fgnutls_boot): Return handshake error code.
6499 (emacs_gnutls_handle_error): New function.
6500 (wsaerror_to_errno): Likewise.
6502 * w32.h (emacs_gnutls_pull): Add prototype.
6503 (emacs_gnutls_push): Likewise.
6505 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6506 (emacs_gnutls_push): Likewise.
6508 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6510 * process.c (wait_reading_process_output): Check if GnuTLS
6511 buffered some data internally if no FDs are set for TLS
6514 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6515 (LIBS): Link to USER_LIBS.
6516 ($(BLD)/gnutls.$(0)): New target.
6518 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6520 * xdisp.c (handle_single_display_spec): Rename the
6521 display_replaced_before_p argument into display_replaced_p, to
6522 make it consistent with the commentary. Fix typos in the
6525 * textprop.c (syms_of_textprop): Remove dead code.
6526 (copy_text_properties): Delete obsolete commentary about an
6527 interface that was deleted long ago. Fix typos in the description
6530 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6531 to changes in oldXMenu/XMenu.h from 2011-04-16.
6532 <menu_help_message, prev_menu_help_message>: Constify.
6533 (IT_menu_make_room): menu->help_text is now `const char **';
6536 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6537 to changes in oldXMenu/XMenu.h from 2011-04-16.
6538 (struct XMenu): Declare `help_text' `const char **'.
6540 * xfaces.c <Qunspecified>: Make extern again.
6542 * syntax.c: Include sys/types.h before including regex.h, as
6545 * doc.c (get_doc_string): Improve the format passed to `error'.
6547 * doprnt.c (doprnt): Improve commentary.
6549 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6551 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6554 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6555 changes in globals.h immediately force recompilation.
6556 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6557 $(CURDIR)/s/ms-w32.h.
6558 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6560 * character.c (Fchar_direction): Function deleted.
6561 (syms_of_character): Don't defsubr it.
6562 <char-direction-table>: Deleted.
6564 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6566 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6567 * doprnt.c: Include limits.h.
6568 (SIZE_MAX): New macro.
6569 (doprnt): Return a size_t value. 2nd arg is now size_t.
6570 Many local variables are now size_t instead of int or unsigned.
6571 Improve overflow protection. Support `l' modifier for integer
6572 conversions. Support %l conversion. Don't assume an EMACS_INT
6573 argument for integer conversions and for %c.
6575 * lisp.h (doprnt): Restore prototype.
6577 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6580 * Makefile.in (base_obj): Add back doprnt.o.
6582 * deps.mk (doprnt.o): Add back prerequisites.
6583 (callint.o): Depend on character.h.
6585 * eval.c (internal_lisp_condition_case): Include the handler
6586 representation in the error message.
6587 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6588 when breaking from the loop.
6590 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6592 * callint.c (Fcall_interactively): When displaying error message
6593 about invalid control letter, pass the character's codepoint, not
6594 a pointer to its multibyte form. Improve display of the character
6595 in octal and display also its hex code.
6597 * character.c (char_string): Use %x to display the (unsigned)
6598 codepoint of an invalid character, to avoid displaying a bogus
6601 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6602 `error', not SYMBOL_NAME itself.
6604 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6605 character arguments to `error'.
6607 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6608 to `error' in error message about FINAL_CHAR argument. Make sure
6609 FINAL_CHAR is a character, and use %c when it is passed as
6610 argument to `error'.
6612 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6614 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6616 * w32.c: Include <time.h>.
6617 (sys_localtime): New function.
6619 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6621 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6623 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6625 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6627 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6630 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6632 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6633 gl_state.e_property when gl_state.object is Qt.
6635 * insdel.c (make_gap_larger): Remove limitation of buffer size
6638 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6640 * xdisp.c (lookup_glyphless_char_display)
6641 (produce_glyphless_glyph): Handle cons cell entry in
6642 glyphless-char-display.
6643 (Vglyphless_char_display): Document it.
6645 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6646 glyphless-char-display.
6648 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6650 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6652 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6654 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6655 definition for no-X builds.
6657 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6659 Static checks with GCC 4.6.0 and non-default toolkits.
6661 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6663 * process.c (keyboard_bit_set): Define only if SIGIO.
6664 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6665 (send_process): Repair possible setjmp clobbering.
6667 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6669 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6671 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6673 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6674 Define only if needed.
6676 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6677 by pacifying GCC about it. Maybe it's time to retire it?
6678 * xfaces.c (USG, __TIMEVAL__): Likewise.
6680 * dispextern.h (struct redisplay_interface): Rename param
6682 * termhooks.h (struct terminal): Likewise.
6683 * xterm.c (xembed_send_message): Likewise.
6685 * insdel.c (make_gap_smaller): Define only if
6686 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6688 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6691 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6692 so that we aren't warned about unused symbols.
6694 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6696 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6698 * xfns.c (x_real_positions): Mark locals as initialized.
6700 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6702 * xterm.c: Fix problems found by static analysis with other toolkits.
6703 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6704 (x_dispatch_event): Declare static if USE_GTK, and
6705 define if USE_GTK || USE_X_TOOLKIT.
6706 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6707 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6708 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6709 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6711 * xmenu.c (menu_help_callback): Pointer type fixes.
6712 Use const pointers when pointing at readonly data. Avoid pointer
6714 (FALSE): Remove unused macro.
6715 (update_frame_menubar): Remove unused decl.
6717 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6719 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6720 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6721 (single_menu_item): Rename local to avoid shadowing.
6723 * keyboard.c (make_lispy_event): Remove unused local var.
6725 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6726 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6728 * bitmaps: Change bitmaps from unsigned char back to the X11
6729 compatible char. Avoid the old compiler warnings about
6730 out-of-range initializers by using, for example, '\xab' rather
6733 * xgselect.c (xgselect_initialize): Check vs interface
6734 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6736 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6738 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6739 to read-only memory.
6741 * fns.c (vector): Remove; this old hack is no longer needed.
6743 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6745 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6747 * xrdb.c (x_load_resources): Omit unused local.
6749 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6750 (x_window): Rename locals to avoid shadowing.
6751 (USG): Use the kludged USG macro, to pacify gcc.
6753 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6754 (x_term_init): Remove local to avoid shadowing.
6756 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6758 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6759 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6761 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6763 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6765 Fix regex.c, syntax.c and friends for buffers > 2GB.
6766 * syntax.h (struct gl_state_s): Declare character position members
6769 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6771 * textprop.c (verify_interval_modification, interval_of):
6772 Declare arguments EMACS_INT.
6774 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6777 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6779 * indent.c (Fvertical_motion): Local variable it_start is now
6782 * regex.c (re_match, re_match_2, re_match_2_internal)
6783 (bcmp_translate, regcomp, regexec, print_double_string)
6784 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6785 (re_compile_pattern, re_exec): Declare arguments and local
6786 variables `size_t' and `ssize_t' and return values `regoff_t', as
6788 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6789 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6790 <compile_stack_type>: `size' and `avail' are now `size_t'.
6792 * regex.h <regoff_t>: Use ssize_t, not int.
6793 (re_search, re_search_2, re_match, re_match_2): Arguments that
6794 specify buffer/string position and length are now ssize_t and
6795 size_t. Return type is regoff_t.
6797 2011-04-16 Ben Key <bkey76@gmail.com>
6799 * nsfont.m: Fixed bugs in ns_get_family and
6800 ns_descriptor_to_entity that were caused by using free to
6801 deallocate memory blocks that were allocated by xmalloc (via
6802 xstrdup). This caused Emacs to crash when compiled with
6803 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6804 --enable-checking=xmallocoverrun). xfree is now used to
6805 deallocate these memory blocks.
6807 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6809 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6811 emacs_write: Accept and return EMACS_INT for sizes.
6812 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6814 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6815 Accept and return EMACS_INT.
6816 (emacs_gnutls_write): Return the number of bytes written on
6818 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6819 (emacs_read, emacs_write): Remove check for negative size, as the
6820 Emacs source code has been audited now.
6821 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6822 (emacs_read, emacs_write): Use it.
6823 * process.c (send_process): Adjust to the new signatures of
6824 emacs_write and emacs_gnutls_write. Do not attempt to store
6825 a byte offset into an 'int'; it might overflow.
6826 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6828 * sound.c: Don't assume sizes fit in 'int'.
6829 (struct sound_device.period_size, alsa_period_size):
6830 Return EMACS_INT, not int.
6831 (struct sound_device.write, vox_write, alsa_write):
6832 Accept EMACS_INT, not int.
6833 (wav_play, au_play): Use EMACS_INT to store sizes and to
6834 record read return values.
6836 2011-04-15 Ben Key <bkey76@gmail.com>
6838 * keyboard.c (Qundefined): Don't declare static since it is used
6840 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6841 static since they are used in nsfont.m.
6843 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6845 * process.c (Qprocessp): Don't declare static.
6846 * lisp.h (Qprocessp): Declare again.
6848 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6850 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6852 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6854 Improve C-level modularity by making more things 'static'.
6856 Don't publish debugger-only interfaces to other modules.
6857 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6858 (verify_bytepos, count_markers): Move decls to the only modules
6860 * region-cache.h (pp_cache): Likewise.
6861 * window.h (check_all_windows): Likewise.
6862 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6864 * sysdep.c (croak): Now static, if
6865 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6866 * syssignal.h (croak): Declare only if not static.
6868 * alloc.c (refill_memory_reserve): Now static if
6869 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6870 * lisp.h (refill_memory_reserve): Declare only if not static.
6872 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6873 Define only if USE_LUCID.
6875 * xrdb.c (x_customization_string, x_rm_string): Now static.
6877 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6878 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6880 * xdisp.c (draw_row_with_mouse_face): Now static.
6881 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6883 * window.h (check_all_windows): Mark externally visible.
6885 * window.c (window_deletion_count): Now static.
6887 * undo.c: Make symbols static if they're not exported.
6888 (last_undo_buffer, last_boundary_position, pending_boundary):
6891 * textprop.c (interval_insert_behind_hooks): Now static.
6892 (interval_insert_in_front_hooks): Likewise.
6894 * term.c: Make symbols static if they're not exported.
6895 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6896 (max_frame_lines, tty_set_terminal_modes):
6897 (tty_reset_terminal_modes, tty_turn_off_highlight):
6898 (get_tty_terminal): Now static.
6899 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6900 * termhooks.h (term_mouse_moveto): Do not declare if
6902 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6903 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6905 * sysdep.c: Make symbols static if they're not exported.
6906 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6908 (sigprocmask_set, full_mask): Remove; unused.
6909 (wait_debugging): Mark as visible.
6910 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6911 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6913 * syntax.c (syntax_temp): Define only if !__GNUC__.
6915 * sound.c (current_sound_device, current_sound): Now static.
6917 * search.c (searchbufs, searchbuf_head): Now static.
6919 * scroll.c (scroll_cost): Remove; unused.
6920 * dispextern.h (scroll_cost): Remove decl.
6922 * region-cache.h (pp_cache): Mark as externally visible.
6924 * process.c: Make symbols static if they're not exported.
6925 (process_tick, update_tick, create_process, chan_process):
6926 (Vprocess_alist, proc_buffered_char, datagram_access):
6927 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6928 (deactivate_process): Mark defn as static, as well as decl.
6929 * lisp.h (create_process): Remove decl.
6930 * process.h (chan_process, Vprocess_alist): Remove decls.
6932 * print.c: Make symbols static if they're not exported.
6933 (print_depth, new_backquote_output, being_printed, print_buffer):
6934 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6935 (print_interval, print_number_index, initial_stderr_stream):
6937 * lisp.h (Fprinc): Remove decl.
6938 (debug_output_compilation_hack): Mark as externally visible.
6940 * sysdep.c (croak): Move decl from here to syssignal.h.
6941 * syssignal.h (croak): Put it here, so the API can be checked when
6942 'croak' is called from dissociate_if_controlling_tty.
6944 * minibuf.c: Make symbols static if they're not exported.
6945 (minibuf_save_list, choose_minibuf_frame): Now static.
6946 * lisp.h (choose_minibuf_frame): Remove decl.
6948 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6950 * lread.c: Make symbols static if they're not exported.
6951 (read_objects, initial_obarray, oblookup_last_bucket_number):
6953 (make_symbol): Remove; unused.
6954 * lisp.h (initial_obarray, make_symbol): Remove decls.
6956 * keyboard.c: Make symbols static if they're not exported.
6957 (single_kboard, recent_keys_index, total_keys, recent_keys):
6958 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6959 (this_single_command_key_start, echoing, last_auto_save):
6960 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6961 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6962 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6963 (Vlispy_mouse_stem, double_click_count):
6965 (force_auto_save_soon): Define only if SIGDANGER.
6966 (ignore_mouse_drag_p): Now static if
6967 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6968 (print_help): Remove; unused.
6969 (stop_character, last_timer_event): Mark as externally visible.
6970 * keyboard.h (ignore_mouse_drag_p): Declare only if
6971 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6972 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6973 * lisp.h (echoing): Remove decl.
6974 (force_auto_save_soon): Declare only if SIGDANGER.
6975 * xdisp.c (redisplay_window): Simplify code, to make it more
6976 obvious that ignore_mouse_drag_p is not accessed if !defined
6977 USE_GTK && !defined HAVE_NS.
6979 * intervals.c: Make symbols static if they're not exported.
6980 (merge_properties_sticky, merge_interval_right, delete_interval):
6982 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6984 * insdel.c: Make symbols static if they're not exported.
6985 However, leave prepare_to_modify_buffer alone. It's never
6986 called from outside this function, but that appears to be a bug.
6987 (combine_after_change_list, combine_after_change_buffer):
6988 (adjust_after_replace, signal_before_change): Now static.
6989 (adjust_after_replace_noundo): Remove; unused.
6990 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
6991 (signal_before_change): Remove decls.
6993 * indent.c (val_compute_motion, val_vmotion): Now static.
6995 * image.c: Make symbols static if they're not exported.
6996 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6998 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6999 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7001 * fringe.c (standard_bitmaps): Now static.
7002 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7004 * frame.c: Make symbols static if they're not exported.
7005 (x_report_frame_params, make_terminal_frame): Now static.
7006 (get_frame_param): Now static, unless HAVE_NS.
7007 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7008 (x_get_resource_string): Remove; not used.
7009 * frame.h (make_terminal_frame, x_report_frame_params):
7010 (x_get_resource_string); Remove decls.
7011 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7012 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7014 * font.c, fontset.c: Make symbols static if they're not exported.
7015 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7016 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7017 * font.c (font_close_object): Now static.
7018 * font.h (font_close_object): Remove.
7019 * fontset.c (FONTSET_OBJLIST): Remove.
7020 (free_realized_fontset) #if-0 the body, which does nothing.
7021 (face_suitable_for_char_p): #if-0, as it's never called.
7022 * fontset.h (face_suitable_for_char_p): Remove decl.
7023 * xfaces.c (face_at_string_position):
7024 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7025 since 0 is always ASCII.
7027 * fns.c (weak_hash_tables): Now static.
7029 * fileio.c: Make symbols static if they're not exported.
7030 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7031 (Vwrite_region_annotation_buffers): Now static.
7033 * eval.c: Make symbols static if they're not exported.
7034 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7035 * lisp.h (backtrace_list): Remove decl.
7037 * emacs.c: Make symbols static if they're not exported.
7038 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7039 (fatal_error_code, fatal_error_signal_hook, standard_args):
7041 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7042 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7043 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7044 * lisp.h (fatal_error_signal_hook): Remove decl.
7045 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7047 * editfns.c: Move a (normally-unused) function to its only use.
7048 * editfns.c, lisp.h (get_operating_system_release): Remove.
7049 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7050 worth the hassle of breaking this out.
7052 * xterm.c: Make symbols static if they're not exported.
7053 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7054 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7055 (x_destroy_window, x_delete_display):
7057 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7058 (x_mouse_leave): Remove; unused.
7059 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7060 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7061 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7063 (x_mouse_leave): Declare only if WINDOWSNT.
7064 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7065 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7068 * ftxfont.c: Make symbols static if they're not exported.
7069 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7071 * font.h (ftxfont_driver): Likewise.
7073 * xfns.c: Make symbols static if they're not exported.
7074 (x_last_font_name, x_display_info_for_name):
7075 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7076 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7077 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7078 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7079 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7080 (last_show_tip_args): Now static.
7081 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7082 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7083 (x_screen_planes): Remove; unused.
7084 * dispextern.h (x_screen_planes): Remove decl.
7086 * dispnew.c: Make symbols static if they're not exported.
7087 * dispextern.h (redraw_garbaged_frames, scrolling):
7088 (increment_row_positions): Remove.
7089 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7090 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7092 (redraw_garbaged_frames): Remove; unused.
7094 * xfaces.c: Make symbols static if they're not exported.
7095 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7097 * xterm.h (defined_color): Remove decls.
7098 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7099 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7100 (menu_face_changed_default, defined_color, free_realized_face):
7101 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7102 (ascii_face_of_lisp_face): Remove; unused.
7104 * xdisp.c: Make symbols static if they're not exported.
7105 * dispextern.h (scratch_glyph_row, window_box_edges):
7106 (glyph_to_pixel_coords, set_cursor_from_row):
7107 (get_next_display_element, set_iterator_to_next):
7108 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7109 (show_mouse_face): Remove decls
7110 * frame.h (message_buf_print): Likewise.
7111 * lisp.h (pop_message, set_message, check_point_in_composition):
7113 * xterm.h (set_vertical_scroll_bar): Likewise.
7114 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7115 (message_buf_print, scratch_glyph_row, displayed_buffer):
7116 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7117 (get_next_display_element, show_mouse_face, window_box_edges):
7118 (frame_to_window_pixel_xy, check_point_in_composition):
7119 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7120 (glyph_to_pixel_coords): Remove; unused.
7122 * dired.c (file_name_completion): Now static.
7124 * dbusbind.c (xd_in_read_queued_messages): Now static.
7126 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7127 * data.c (circular_list_error): Remove.
7129 * commands.h (last_point_position, last_point_position_buffer):
7130 (last_point_position_window): Remove decls.
7131 * keyboard.c: Make these variables static.
7133 * coding.h (coding, code_convert_region, encode_coding_gap):
7135 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7136 (iso_code_class, detect_coding, code_convert_region): Now static.
7137 (encode_coding_gap): Remove; unused.
7139 * chartab.c (chartab_chars, chartab_bits): Now static.
7141 * charset.h (charset_iso_8859_1): Remove decl.
7142 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7145 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7146 * ccl.c (Vccl_program_table): Now static.
7147 (check_ccl_update): Remove; unused.
7149 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7150 * category.h: ... from here.
7151 * category.c (check_category_table, set_category_set): Now static.
7153 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7154 * lisp.h: Remove these decls.
7156 * buffer.c (buffer_count): Remove unused var.
7158 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7159 so that it's not optimized away.
7160 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7161 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7162 exported only to the debugger.
7164 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7165 * atimer.h (run_all_atimers): Remove; not exported.
7167 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7168 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7169 was inaccessible from Lisp.
7170 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7171 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7173 alloc.c: Import and export fewer symbols, and remove unused items.
7174 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7176 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7177 it's not optimized away by whole-program optimization.
7178 (message_enable_multibyte, free_misc): Remove.
7179 (catchlist, handlerlist, mark_backtrace):
7180 Declare only if BYTE_MARK_STACK.
7181 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7182 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7183 (message_enable_multibyte): Remove decl.
7184 (free_misc, interval_free_list, float_block, float_block_index):
7185 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7186 (cons_free_list, last_marked_index):
7188 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7189 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7190 (mark_backtrace): Define only if BYTE_MARK_STACK.
7191 * xdisp.c (message_enable_multibyte): Now static.
7193 Declare Lisp_Object Q* variables to be 'static' if not exported.
7194 This makes it easier for human readers (and static analyzers)
7195 to see whether these variables are used from other modules.
7196 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7197 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7198 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7199 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7200 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7201 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7202 * xmenu.c, xselect.c:
7203 Declare Q* vars static if they are not used in other modules.
7204 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7205 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7206 Remove decls of unexported vars.
7207 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7209 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7211 Make Emacs functions such as Fatom 'static' by default.
7212 This makes it easier for human readers (and static analyzers)
7213 to see whether these functions can be called from other modules.
7214 DEFUN now defines a static function. To make the function external
7215 so that it can be used in other C modules, use the new macro DEFUE.
7216 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7217 (Finit_image_library):
7218 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7219 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7220 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7221 Remove decls, since these functions are now static.
7222 (Funintern, Fget_internal_run_time): New decls, since these functions
7223 were already external.
7225 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7226 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7227 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7228 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7229 * keyboard.c, keymap.c, lread.c:
7230 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7231 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7232 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7233 Mark functions with DEFUE instead of DEFUN,
7234 if they are used in other modules.
7235 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7236 decls for now-static functions.
7237 * buffer.h (Fdelete_overlay): Remove decl.
7238 * callproc.c (Fgetenv_internal): Mark as internal.
7239 * composite.c (Fremove_list_of_text_properties): Remove decl.
7240 (Fcomposition_get_gstring): New forward static decl.
7241 * composite.h (Fcomposite_get_gstring): Remove decl.
7242 * dired.c (Ffile_attributes): New forward static decl.
7243 * doc.c (Fdocumntation_property): New forward static decl.
7244 * eval.c (Ffetch_bytecode): New forward static decl.
7245 (Funintern): Remove extern decl; now in .h file where it belongs.
7246 * fileio.c (Fmake_symbolic_link): New forward static decl.
7247 * image.c (Finit_image_library): New forward static decl.
7248 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7249 * intervals.h (Fprevious_property_change):
7250 (Fremove_list_of_text_properties): Remove decls.
7251 * keyboard.c (Fthis_command_keys): Remove decl.
7252 (Fcommand_execute): New forward static decl.
7253 * keymap.c (Flookup_key): New forward static decl.
7254 (Fcopy_keymap): Now static.
7255 * keymap.h (Flookup_key): Remove decl.
7256 * process.c (Fget_process): New forward static decl.
7257 (Fprocess_datagram_address): Mark as internal.
7258 * syntax.c (Fsyntax_table_p): New forward static decl.
7259 (skip_chars): Remove duplicate decl.
7260 * textprop.c (Fprevious_property_change): New forward static decl.
7261 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7263 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7264 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7266 * editfns.c (Fformat): Remove unreachable code.
7268 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7270 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7273 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7275 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7276 when at ZV. (Bug#8487)
7278 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7280 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7282 * keyboard.c (parse_tool_bar_item): Likewise.
7283 * sound.c (sound_cleanup, alsa_close): Likewise.
7284 * termcap.c (tgetent): Likewise.
7285 * xfns.c (x_default_font_parameter): Likewise.
7286 * xsettings.c (read_and_apply_settings): Likewise.
7288 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7289 (overrun_check_free): Protoize.
7291 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7293 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7294 since callers should never pass a negative size.
7295 Change the signature to match that of plain 'read' and 'write'; see
7296 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7297 * lisp.h: Update prototypes of emacs_write and emacs_read.
7299 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7301 * xdisp.c (redisplay_window): Don't try to determine the character
7302 position of the scroll margin if the window start point w->startp
7303 is outside the buffer's accessible region. (Bug#8468)
7305 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7307 Fix write-region and its subroutines for buffers > 2GB.
7308 * fileio.c (a_write, e_write): Modify declaration of arguments and
7309 local variables to support buffers larger than 2GB.
7310 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7312 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7313 argument, local variables, and return value.
7315 * lisp.h: Update prototypes of emacs_write and emacs_read.
7317 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7319 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7321 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7323 Fix more problems found by GCC 4.6.0's static checks.
7325 * xdisp.c (vmessage): Use a better test for character truncation.
7327 * charset.c (load_charset_map): <, not <=, for optimization,
7328 and to avoid potential problems with integer overflow.
7329 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7330 * casetab.c (set_identity, shuffle): Likewise.
7331 * editfns.c (Fformat): Likewise.
7332 * syntax.c (skip_chars): Likewise.
7334 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7335 This also lets GCC 4.6.0 generate slightly better loop code.
7337 * callint.c (Fcall_interactively): <, not <=, for optimization.
7338 (Fcall_interactively): Count the number of arguments produced,
7339 not the number of arguments given. This is simpler and lets GCC
7340 4.6.0 generate slightly better code.
7342 * ftfont.c: Distingish more carefully between FcChar8 and char.
7343 The previous code passed unsigned char * to a functions like
7344 strlen and xstrcasecmp that expect char *, which does not
7345 conform to the C standard.
7346 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7347 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7348 char * when the C standard requires it.
7350 * keyboard.c (read_char): Remove unused var.
7352 * eval.c: Port to Windows vsnprintf (Bug#8435).
7354 (SIZE_MAX): Define if the headers do not.
7355 (verror): Do not give up if vsnprintf returns a negative count.
7356 Instead, grow the buffer. This ports to Windows vsnprintf, which
7357 does not conform to C99. Problem reported by Eli Zaretskii.
7358 Also, simplify the allocation scheme, by avoiding the need for
7359 calling realloc, and removing the ALLOCATED variable.
7361 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7363 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7364 But keep the doprint source code for now, as we might revamp it
7365 and use it again (Bug#8435).
7366 * lisp.h (doprnt): Remove.
7367 * Makefile.in (base_obj): Remove doprnt.o.
7368 * deps.mk (doprnt.o): Remove.
7370 error: Print 32- and 64-bit integers portably (Bug#8435).
7371 Without this change, on typical 64-bit hosts error ("...%d...", N)
7372 was used to print both 32- and 64-bit integers N, which relied on
7374 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7376 * lisp.h (error, verror): Mark as printf-like functions.
7377 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7378 Report overflow in size calculations when allocating printf buffer.
7379 Do not truncate output string at its first null byte.
7380 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7381 Truncate the output at a character boundary, since vsnprintf does not
7383 * charset.c (check_iso_charset_parameter): Convert internal
7384 character to string before calling 'error', since %c now has the
7386 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7387 overflow when computing char to be passed to 'error'. Do not
7388 pass Lisp_Object to 'error'; pass the integer instead.
7389 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7390 formatted with plain %d.
7392 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7394 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7396 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7398 * xterm.c (x_catch_errors): Remove duplicate declaration.
7400 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7402 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7404 2011-04-10 Jim Meyering <meyering@redhat.com>
7406 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7407 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7408 return ssize_t not "int", and use size_t as the buffer length.
7409 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7410 * gnutls.h: Update declarations.
7411 * process.c (read_process_output): Use ssize_t, to match.
7412 (send_process): Likewise.
7414 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7416 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7418 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7420 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7421 Use unsigned char, to match FcChar8 type definition.
7423 * xterm.c (handle_one_xevent):
7424 * xmenu.c (create_and_show_popup_menu):
7425 * xselect.c (x_decline_selection_request)
7426 (x_reply_selection_request): Avoid type-punned deref of X events.
7428 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7430 Fix some uses of `int' instead of EMACS_INT.
7431 * search.c (string_match_1, fast_string_match)
7432 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7433 (scan_buffer, find_next_newline_no_quit)
7434 (find_before_next_newline, search_command, Freplace_match)
7435 (Fmatch_data): Make some `int' variables be EMACS_INT.
7437 * xdisp.c (display_count_lines): 3rd argument and return value now
7438 EMACS_INT. All callers changed.
7439 (pint2hrstr): Last argument is now EMACS_INT.
7441 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7442 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7443 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7444 (decode_coding_utf_16, decode_coding_emacs_mule)
7445 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7446 (decode_coding_ccl, decode_coding_charset)
7447 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7448 (decode_coding_iso_2022, decode_coding_emacs_mule)
7449 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7450 <char_offset, last_offset>: Declare EMACS_INT.
7451 (encode_coding_utf_8, encode_coding_utf_16)
7452 (encode_coding_emacs_mule, encode_invocation_designation)
7453 (encode_designation_at_bol, encode_coding_iso_2022)
7454 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7455 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7457 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7458 (encode_invocation_designation): Last argument P_NCHARS is now
7460 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7461 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7463 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7466 * ccl.c (Fccl_execute_on_string): Declare some variables
7469 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7471 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7473 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7475 * process.c (Fformat_network_address): Doc fix.
7477 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7479 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7481 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7483 * keyboard.c (read_char): Call Lisp function help-form-show,
7484 instead of using internal_with_output_to_temp_buffer.
7485 (Qhelp_form_show): New var.
7486 (syms_of_keyboard): Use DEFSYM macro.
7488 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7490 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7492 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7494 * process.c (Flist_processes): Remove to Lisp.
7495 (list_processes_1): Delete.
7497 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7499 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7501 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7503 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7505 Fix more problems found by GCC 4.6.0's static checks.
7507 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7509 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7511 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7513 * xdisp.c (vmessage): Mark as a printf-like function.
7515 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7517 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7519 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7520 printf-like functions.
7521 (tiff_load): Add casts to remove these marks before passing them
7522 to system-supplied API.
7524 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7526 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7527 This avoids several warnings with gcc -Wstrict-overflow.
7528 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7529 directly, rather than having caller test rule sign. This avoids
7530 some unnecessary tests.
7531 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7532 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7533 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7535 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7536 (xfont_open): Avoid unnecessary tests.
7538 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7540 * composite.h, composite.c (composition_gstring_put_cache):
7541 Use EMACS_INT, not int, for length.
7543 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7544 breaking out part of COMPOSITION_DECODE_RULE.
7545 (COMPOSITION_DECODE_RULE): Use it.
7546 * composite.c (get_composition_id): Remove unused local vars,
7547 by using the new macro.
7549 * textprop.c (set_text_properties_1): Change while to do-while,
7550 since the condition is always true at first.
7552 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7553 (interval_deletion_adjustment): Return unsigned value.
7556 * process.c (list_processes_1, create_pty, read_process_output):
7557 (exec_sentinel): Remove vars that were set but not used.
7558 (create_pty): Remove unnecessary "volatile"s.
7559 (Fnetwork_interface_info): Avoid possibility of int overflow.
7560 (read_process_output): Do adaptive read buffering even if carryover.
7561 (read_process_output): Simplify nbytes computation if buffered.
7563 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7565 * syntax.c (scan_words): Remove var that was set but not used.
7566 (update_syntax_table): Use unsigned instead of int.
7568 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7569 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7570 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7572 * print.c (print_error_message): Avoid int overflow.
7574 * font.c (font_list_entities): Redo for clarity,
7575 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7577 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7578 (font_score): Avoid potential overflow in diff calculation.
7580 * fns.c (substring_both): Remove var that is set but not used.
7581 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7583 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7585 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7586 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7587 can always succeed if overflow has undefined behavior.
7589 * search.c (boyer_moore, wordify): Remove vars set but not used.
7590 (wordify): Omit three unnecessary tests.
7592 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7593 All callers changed. This avoids the need for an unused var.
7595 * casefiddle.c (casify_region): Remove var that is set but not used.
7597 * dired.c (file_name_completion): Remove var that is set but not used.
7599 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7601 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7602 (Finsert_file_contents): Remove unnecessary code checking fd.
7604 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7605 Check for integer overflow on size calculations.
7607 * buffer.c (Fprevious_overlay_change): Remove var that is set
7610 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7611 Remove vars that are set but not used.
7612 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7613 (timer_check_2): Mark vars as initialized.
7615 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7617 * image.c (lookup_image): Remove var that is set but not used.
7618 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7620 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7621 that are set but not used.
7623 * xfns.c (make_invisible_cursor): Don't return garbage
7624 if XCreateBitmapFromData fails (Bug#8410).
7626 * xselect.c (x_get_local_selection, x_handle_property_notify):
7627 Remove vars that are set but not used.
7629 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7630 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7632 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7633 Remove var that is set but not used.
7634 (scroll_bar_windows_size): Now size_t, not int.
7635 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7638 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7639 (map_tty_color) [!defined MSDOS]: Likewise.
7641 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7643 * coding.c: Remove vars that are set but not used.
7644 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7645 All callers changed.
7646 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7647 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7648 (decode_coding_charset): Remove vars that are set but not used.
7650 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7651 that is set but not used.
7653 * print.c (print_object): Remove var that is set but not used.
7655 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7656 The gnulib version avoids calling malloc in the usual case,
7657 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7658 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7659 * filelock.c (current_lock_owner): Likewise.
7660 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7661 * sysdep.c: Include allocator.h, careadlinkat.h.
7662 (emacs_no_realloc_allocator): New static constant.
7663 (emacs_readlink): New function.
7664 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7665 ../lib/careadlinkat.h.
7667 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7669 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7670 first non-nil return value).
7672 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7674 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7675 if not defined (Bug#8403).
7677 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7679 * xdisp.c (display_count_lines): Remove parameter `start',
7680 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7681 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7682 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7683 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7684 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7685 and thereabouts. All callers changed.
7686 (get_per_char_metric): Remove parameter `f', unused since
7687 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7689 2011-04-02 Jim Meyering <meyering@redhat.com>
7691 do not dereference NULL upon failed strdup
7692 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7693 (ns_get_family): Likewise.
7695 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7697 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7699 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7701 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7704 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7706 Add lexical binding.
7708 * window.c (Ftemp_output_buffer_show): New fun.
7709 (Fsave_window_excursion):
7710 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7712 * lread.c (lisp_file_lexically_bound_p): New function.
7713 (Fload): Bind Qlexical_binding.
7714 (readevalloop): Remove `evalfun' arg.
7715 Bind Qinternal_interpreter_environment.
7716 (Feval_buffer): Bind Qlexical_binding.
7717 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7719 (syms_of_lread): Declare `lexical-binding'.
7721 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7723 * keyboard.c (eval_dyn): New fun.
7724 (menu_item_eval_property): Use it.
7726 * image.c (parse_image_spec): Use Ffunctionp.
7728 * fns.c (concat, mapcar1): Accept byte-code-functions.
7730 * eval.c (Fsetq): Handle lexical vars.
7731 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7732 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7733 (FletX, Flet): Obey lexical binding.
7734 (Fcommandp): Handle closures.
7735 (Feval): New `lexical' arg.
7736 (eval_sub): New function extracted from Feval. Use it almost
7737 everywhere where Feval was used. Look up vars in lexical env.
7739 (Ffunctionp): Move from subr.el.
7740 (Ffuncall): Handle closures.
7741 (apply_lambda): Remove `eval_flags'.
7742 (funcall_lambda): Handle closures and new byte-code-functions.
7743 (Fspecial_variable_p): New function.
7744 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7745 but without exporting it to Lisp.
7747 * doc.c (Fdocumentation, store_function_docstring):
7748 * data.c (Finteractive_form): Handle closures.
7750 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7753 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7755 (exec_byte_code): New function extracted from Fbyte_code to handle new
7756 calling convention for byte-code-functions. Add new byte-codes.
7758 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7760 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7762 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7764 * xdisp.c (redisplay_internal): Fix prototype.
7766 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7768 * xdisp.c (SCROLL_LIMIT): New macro.
7769 (try_scrolling): Use it when setting scroll_limit.
7770 Limit scrolling to 100 screen lines.
7771 (redisplay_window): Even when falling back on "recentering",
7772 position point in the window according to scroll-conservatively,
7773 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7775 (try_scrolling): When point is above the window, allow searching
7776 as far as scroll_max, or one screenful, to compute vertical
7777 distance from PT to the scroll margin position. This prevents
7778 try_scrolling from unnecessarily failing when
7779 scroll-conservatively is set to a value slightly larger than the
7780 window height. Clean up the case of PT below the margin at bottom
7781 of window: scroll_max can no longer be INT_MAX. When aggressive
7782 scrolling is in use, don't let point enter the opposite scroll
7783 margin as result of the scroll.
7784 (syms_of_xdisp) <scroll-conservatively>: Document the
7785 threshold of 100 lines for never-recentering scrolling.
7787 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7789 * dispextern.h (move_it_by_lines):
7790 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7791 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7792 (message_log_check_duplicate): Remove parameters `prev_bol' and
7793 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7794 (redisplay_internal): Remove parameter `preserve_echo_area',
7795 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7797 * indent.c (Fvertical_motion):
7798 * window.c (window_scroll_pixel_based, Frecenter):
7799 Don't pass `need_y_p' to `move_it_by_lines'.
7801 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7803 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7804 steal a few bits to be more compact.
7805 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7806 Remove unneeded casts.
7808 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7810 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7812 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7813 binding" message (bug#7967).
7815 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7817 Fix more problems found by GCC 4.6.0's static checks.
7819 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7820 Remove unused local var.
7822 * editfns.c (Fmessage_box): Remove unused local var.
7824 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7825 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7826 Omit unused local vars.
7827 * window.c (shrink_windows): Omit unused local var.
7828 * menu.c (digest_single_submenu): Omit unused local var.
7829 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7830 Omit unused local var.
7832 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7833 Don't assume string length fits in int.
7834 (keyremap_step, read_key_sequence): Use size_t for sizes.
7835 (read_key_sequence): Don't check last_real_key_start redundantly.
7837 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7838 instead of alloca (Bug#8344).
7840 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7841 (Fbacktrace_frame): Don't assume nframes fits in int.
7843 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7845 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7848 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7850 * cm.c (calccost): Turn while-do into do-while, for clarity.
7852 * keyboard.c (syms_of_keyboard): Use the same style as later
7853 in this function when indexing through an array. This also
7854 works around GCC bug 48267.
7856 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7858 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7860 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7861 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7863 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7864 This avoids undefined behavior on integer overflow, and is a bit
7865 more convenient anyway since it is compared to a size_t variable.
7867 Variadic C functions now count arguments with size_t, not int.
7868 This avoids an unnecessary limitation on 64-bit machines, which
7869 caused (substring ...) to crash on large vectors (Bug#8344).
7870 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7871 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7872 All variadic functions and their callers changed accordingly.
7873 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7874 * data.c (arith_driver, float_arith_driver): Likewise.
7875 * editfns.c (general_insert_function): Likewise.
7876 * eval.c (struct backtrace.nargs, interactive_p)
7877 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7878 (funcall_lambda, mark_backtrace): Likewise.
7879 * fns.c (concat): Likewise.
7880 * frame.c (x_set_frame_parameters): Likewise.
7881 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7882 0 if not found, not -1. All callers changed.
7884 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7885 (stack_copy_size): Now size_t, not int.
7886 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7888 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7890 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7891 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7892 All callers changed.
7894 * lisp.h (multibyte_char_to_unibyte):
7895 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7896 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7897 * character.h (CHAR_TO_BYTE8):
7898 * cmds.c (internal_self_insert):
7899 * editfns.c (general_insert_function):
7900 * keymap.c (push_key_description):
7901 * search.c (Freplace_match):
7902 * xdisp.c (message_dolog, set_message_1): All callers changed.
7904 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7906 * keyboard.c (safe_run_hook_funcall): New function.
7907 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7908 don't set the hook to nil, but remove the offending function instead.
7909 (Qcommand_hook_internal): Remove, unused.
7910 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7911 Vcommand_hook_internal.
7913 * eval.c (enum run_hooks_condition): Remove.
7914 (funcall_nil, funcall_not): New functions.
7915 (run_hook_with_args): Call each function through a `funcall' argument.
7916 Remove `cond' argument, now redundant.
7917 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7918 (Frun_hook_with_args_until_failure): Adjust accordingly.
7919 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7921 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7923 * dispextern.h (string_buffer_position): Remove declaration.
7925 * print.c (strout): Remove parameter `multibyte', unused since
7926 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7928 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7929 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7930 All callers changed.
7932 * w32.c (_wsa_errlist): Use braces for struct initializers.
7934 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7935 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7936 All callers changed.
7937 (string_buffer_position): Likewise. Also, make static (it's never
7938 used outside xdisp.c).
7939 (cursor_row_p): Remove parameter `w', unused since
7940 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7941 (decode_mode_spec): Remove parameter `precision', introduced during
7942 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7943 All callers changed.
7945 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7947 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7949 2011-03-27 Anders Lindgren <andlind@gmail.com>
7951 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7952 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7953 (ns_update_auto_hide_menu_bar): New functions.
7954 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7955 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7956 ns_constrain_all_frames.
7957 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7958 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7960 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7962 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7964 2011-03-27 Glenn Morris <rgm@gnu.org>
7966 * syssignal.h: Replace RETSIGTYPE with void.
7967 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7968 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7969 Replace SIGTYPE with void everywhere.
7970 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7971 * s/template.h (SIGTYPE): Remove commented out definition.
7973 2011-03-26 Eli Zaretskii <eliz@gnu.org>
7975 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7976 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7978 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
7980 * w32.c (read_unc_volume): Use parameter `henum', instead of
7981 global variable `wget_enum_handle'.
7983 * keymap.c (describe_vector): Remove parameters `indices' and
7984 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7985 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7987 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7989 * keyboard.c (timer_check): Remove parameter `do_it_now',
7990 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7991 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7992 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7994 * keyboard.c (read_char):
7995 * w32menu.c (w32_menu_display_help):
7996 * xmenu.c (show_help_event, menu_help_callback):
7997 Adjust calls to `show_help_echo'.
7999 * gtkutil.c (xg_maybe_add_timer):
8000 * keyboard.c (readable_events):
8001 * process.c (wait_reading_process_output):
8002 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8004 * insdel.c (adjust_markers_gap_motion):
8005 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8006 (gap_left, gap_right): Don't call it.
8008 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8010 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8011 incurred during fontification.
8013 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8015 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8016 (DEFVAR_PER_BUFFER): Don't pass it.
8018 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8019 (scrolling_window): Don't pass it.
8021 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8023 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8025 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8027 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8028 of variables specific to SELinux and computation of `encoded_absname'.
8030 * image.c (XPutPixel): Remove unused variable `height'.
8032 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8034 * unexw32.c (get_section_info): Remove unused variable `section'.
8036 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8037 (system_process_attributes): Remove unused variable `sess'.
8038 (sys_read): Remove unused variable `err'.
8040 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8041 (w32_wnd_proc): Remove unused variable `isdead'.
8042 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8043 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8044 (x_create_tip_frame): Remove unused variable `tem'.
8046 * w32inevt.c (w32_console_read_socket):
8047 Remove unused variable `no_events'.
8049 * w32term.c (x_draw_composite_glyph_string_foreground):
8050 Remove unused variable `width'.
8052 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8054 * w32term.c (x_set_glyph_string_clipping):
8055 Don't pass uninitialized region to CombineRgn.
8057 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8059 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8060 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8061 (Fx_close_connection): Remove unused variable `i'.
8063 * w32font.c (w32font_draw): Return number of glyphs.
8064 (w32font_open_internal): Remove unused variable `i'.
8065 (w32font_driver): Add missing initializer.
8067 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8068 (fill_in_menu): Remove unused variable `items_added'.
8070 * w32term.c (last_mouse_press_frame): Remove static global variable.
8071 (w32_clip_to_row): Remove unused variable `f'.
8072 (x_delete_terminal): Remove unused variable `i'.
8074 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8075 (NOTHING): Remove unused static global variable.
8076 (uniscribe_check_otf): Remove unused variable `table'.
8077 (uniscribe_font_driver): Add missing initializers.
8079 2011-03-23 Julien Danjou <julien@danjou.info>
8081 * term.c (Fsuspend_tty, Fresume_tty):
8082 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8083 * window.c (temp_output_buffer_show):
8084 * insdel.c (signal_before_change):
8085 * frame.c (Fhandle_switch_frame):
8086 * fileio.c (Fdo_auto_save):
8087 * emacs.c (Fkill_emacs):
8088 * editfns.c (save_excursion_restore):
8089 * cmds.c (internal_self_insert):
8090 * callint.c (Fcall_interactively):
8091 * buffer.c (Fkill_all_local_variables):
8092 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8094 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8095 unconditionally since it does the check itself.
8097 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8099 Fix more problems found by GCC 4.5.2's static checks.
8101 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8102 the first time through the loop, since we know p0 < p1 then.
8103 This also avoids a gcc -Wstrict-overflow warning.
8105 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8106 leading to a memory leak, possible in functions like
8107 load_charset_map_from_file that can allocate an unbounded number
8108 of objects (Bug#8318).
8110 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8111 that could (at least in theory) be that large.
8113 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8114 This is less likely to overflow, and avoids undefined behavior if
8115 overflow does occur. All callers changed. Use strtoul to scan
8116 for the unsigned long integer.
8117 (pint2hrstr): Simplify and tune code slightly.
8118 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8120 * scroll.c (do_scrolling): Work around GCC bug 48228.
8121 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8123 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8124 This also avoids a warning with gcc -Wstrict-overflow.
8125 (validate_x_resource_name): Simplify count usage.
8126 This also avoids a warning with gcc -Wstrict-overflow.
8128 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8131 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8133 * process.c (Fmake_network_process): Use socklen_t, not int,
8134 where POSIX says socklen_t is required in portable programs.
8135 This fixes a porting bug on hosts like 64-bit HP-UX, where
8136 socklen_t is wider than int (Bug#8277).
8137 (Fmake_network_process, server_accept_connection):
8138 (wait_reading_process_output, read_process_output):
8141 * process.c: Rename or move locals to avoid shadowing.
8142 (list_processes_1, Fmake_network_process):
8143 (read_process_output_error_handler, exec_sentinel_error_handler):
8144 Rename or move locals.
8145 (Fmake_network_process): Define label "retry_connect" only if needed.
8146 (Fnetwork_interface_info): Fix pointer signedness.
8147 (process_send_signal): Add cast to avoid pointer signedness problem.
8148 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8149 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8151 Make tparam.h and terminfo.c consistent.
8152 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8153 Include tparam.h instead, since it declares them.
8154 * cm.h (PC): Remove extern decl; tparam.h now does this.
8155 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8156 * terminfo.c: Include tparam.h, to check interfaces.
8157 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8158 (tparam): Adjust signature to match interface in tparam.h;
8159 this removes some undefined behavior. Check that outstring and len
8160 are zero, which they always are with Emacs.
8161 * tparam.h (PC, BC, UP): New extern decls.
8163 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8164 (xftfont_open): Rename locals to avoid shadowing.
8166 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8167 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8168 (OTF_TAG_SYM): Omit macro if not needed.
8169 (ftfont_list): Remove unused local.
8170 (get_adstyle_property, ftfont_pattern_entity):
8171 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8172 Rename locals to avoid shadowing.
8174 * xfont.c (xfont_list_family): Mark var as initialized.
8176 * xml.c (make_dom): Now static.
8178 * composite.c (composition_compute_stop_pos): Rename local to
8180 (composition_reseat_it): Remove unused locals.
8181 (find_automatic_composition, composition_adjust_point): Likewise.
8182 (composition_update_it): Mark var as initialized.
8183 (find_automatic_composition): Mark vars as initialized,
8184 with a FIXME (Bug#8290).
8186 character.h: Rename locals to avoid shadowing.
8187 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8188 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8189 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8190 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8193 * textprop.c (property_change_between_p): Remove; unused.
8195 * intervals.c (interval_start_pos): Now static.
8197 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8199 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8200 Rename locals to avoid shadowing.
8202 * sound.c (wav_play, au_play, Fplay_sound_internal):
8203 Fix pointer signedness.
8204 (alsa_choose_format): Remove unused local var.
8205 (wav_play): Initialize a variable to 0, to prevent undefined
8206 behavior (Bug#8278).
8208 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8210 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8212 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8213 clobbering (Bug#8298).
8214 * sysdep.c (sys_subshell): Likewise.
8215 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8217 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8218 This should get cleaned up, so that child_setup has the
8219 same signature on all platforms.
8221 * callproc.c (call_process_cleanup): Now static.
8222 (relocate_fd): Rename locals to avoid shadowing.
8224 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8226 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8227 not to be necessary, and produces flickering.
8229 2011-03-20 Glenn Morris <rgm@gnu.org>
8231 * config.in: Remove file.
8233 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8235 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8236 are now in src/globals.h.
8237 (syms_of_minibuf): Remove spurious & from previous change.
8239 2011-03-20 Leo <sdl.web@gmail.com>
8241 * minibuf.c (completing-read-function): New variable.
8242 (completing-read-default): Rename from completing-read.
8243 (completing-read): Call completing-read-function.
8245 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8247 * xfaces.c (Fx_load_color_file):
8248 Read color file from absolute filename (bug#8250).
8250 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8252 * makefile.w32-in: Update dependencies.
8254 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8256 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8258 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8260 Fix more problems found by GCC 4.5.2's static checks.
8262 * process.c (make_serial_process_unwind, send_process_trap):
8263 (sigchld_handler): Now static.
8265 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8266 That way, the code declares only the vars that it needs.
8267 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8268 * s/cygwin.h (PTY_ITERATION): Likewise.
8269 * s/darwin.h (PTY_ITERATION): Likewise.
8270 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8272 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8273 * process.c (allocate_pty): Don't declare stb unless it's needed.
8275 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8276 (CONSTANTLIM): Remove; unused.
8277 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8278 Define only if needed.
8280 * unexelf.c (unexec): Name an expression,
8281 to avoid gcc -Wbad-function-cast warning.
8282 Use a different way to cause a compilation error if anyone uses
8283 n rather than nn, a way that does not involve shadowing.
8284 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8286 * deps.mk (unexalpha.o): Remove; unused.
8288 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8289 * unexec.h: New file.
8290 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8291 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8293 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8294 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8295 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8296 Change as necessary to match prototype in unexec.h.
8298 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8300 (back_comment, skip_chars): Mark vars as initialized.
8302 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8303 Rename locals to avoid shadowing.
8305 * lread.c (read1): Rewrite so as not to use empty "else".
8306 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8308 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8310 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8311 warning when compiling print.c.
8313 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8314 instead of using an uninitialized var.
8315 (font_sort_entities): Mark var as initialized.
8317 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8319 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8320 pointers to constants.
8321 (font_parse_fcname): Remove unused vars.
8322 (font_delete_unmatched): Now static.
8323 (font_get_spec): Remove; unused.
8324 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8325 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8326 Rename or move locals to avoid shadowing.
8328 * fns.c (require_nesting_list, require_unwind): Now static.
8329 (Ffillarray): Rename locals to avoid shadowing.
8331 * floatfns.c (domain_error2): Define only if needed.
8332 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8334 * alloc.c (mark_backtrace): Move decl from here ...
8335 * lisp.h: ... to here, so that it can be checked.
8337 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8338 (Fdefvar): Rewrite so as not to use empty "else".
8339 (lisp_indirect_variable): Name an expression,
8340 to avoid gcc -Wbad-function-cast warning.
8341 (Fdefvar): Rename locals to avoid shadowing.
8343 * callint.c (quotify_arg, quotify_args): Now static.
8344 (Fcall_interactively): Rename locals to avoid shadowing.
8345 Use const pointer when appropriate.
8347 * lisp.h (get_system_name, get_operating_system_release):
8348 Move decls here, to check interfaces.
8349 * process.c (get_operating_system_release): Move decl to lisp.h.
8350 * xrdb.c (get_system_name): Likewise.
8351 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8352 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8353 some of which prompt warnings from gcc -Wbad-function-cast.
8354 (Fformat_time_string, Fencode_time, Finsert_char):
8355 (Ftranslate_region_internal, Fformat):
8356 Rename or remove local vars to avoid shadowing.
8357 (Ftranslate_region_internal): Mark var as initialized.
8359 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8362 * lisp.h (eassert): Check that the argument compiles, even if
8363 ENABLE_CHECKING is not defined.
8365 * data.c (Findirect_variable): Name an expression, to avoid
8366 gcc -Wbad-function-cast warning.
8367 (default_value, arithcompare, arith_driver, arith_error): Now static.
8368 (store_symval_forwarding): Rename local to avoid shadowing.
8369 (Fmake_variable_buffer_local, Fmake_local_variable):
8370 Mark variables as initialized.
8371 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8373 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8374 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8375 Rename locals to avoid shadowing.
8376 (mark_stack): Move local variables into the #ifdef region where
8378 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8379 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8381 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8382 (GC_STRING_CHARS): Remove; not used.
8383 (Fmemory_limit): Cast sbrk's returned value to char *.
8385 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8386 avoids undefined behavior in theory.
8388 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8390 Use functions, not macros, for up- and down-casing (Bug#8254).
8391 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8392 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8393 to use the following functions instead of these macros.
8394 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8395 EMACS_INT, since callers assume the returned value fits in int.
8396 (upcase1): Likewise, for UPCASE_TABLE.
8397 (uppercasep, lowercasep, upcase): New static inline functions.
8398 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8399 the race-condition problem in the old DOWNCASE.
8401 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8402 Rename locals to avoid shadowing.
8403 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8404 (regex_compile, re_search_2, re_match_2_internal):
8405 Remove unused local vars.
8406 (FREE_VAR): Rewrite so as not to use empty "else",
8407 which gcc can warn about.
8408 (regex_compile, re_match_2_internal): Mark locals as initialized.
8409 (RETALLOC_IF): Define only if needed.
8410 (WORDCHAR_P): Likewise. This one is never needed, but is used
8411 only in a comment talking about a compiler bug, so put inside
8412 the #if 0 of that comment.
8413 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8414 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8417 * search.c (boyer_moore): Rename locals to avoid shadowing.
8418 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8419 (PREV_CHAR_BOUNDARY): Likewise.
8421 * search.c (simple_search): Remove unused var.
8423 * dired.c (compile_pattern): Move decl from here ...
8424 * lisp.h: ... to here, so that it can be checked.
8425 (struct re_registers): New forward decl.
8427 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8429 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8431 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8432 Rename locals to avoid shadowing.
8433 (Fvertical_motion): Mark locals as initialized.
8435 * casefiddle.c (casify_object, casify_region): Now static.
8436 (casify_region): Mark local as initialized.
8438 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8440 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8441 New macros, so that the caller can use some names other than
8442 gcpro1, gcpro2, etc.
8443 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8445 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8446 argument, for consistency with GCPRO2_VAR, etc: it is now the
8447 prefix of the variable, not the variable itself. All uses
8449 * dired.c (directory_files_internal, file_name_completion):
8450 Rename locals to avoid shadowing.
8452 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8453 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8454 dired.c's scmp function, had undefined behavior.
8455 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8456 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8457 * buffer.h: ... to here, because these macros use current_buffer,
8458 and the new implementation with inline functions needs to have
8459 current_buffer in scope now, rather than later when the macros
8461 (downcase, upcase1): New static inline functions.
8462 (DOWNCASE, UPCASE1): Reimplement using these functions.
8463 This avoids undefined behavior in expressions like
8464 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8465 from race conditions in accessing the global variables
8466 case_temp1 and case_temp2.
8467 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8468 * lisp.h (case_temp1, case_temp2): Remove their decls.
8469 * character.h (ASCII_CHAR_P): Move from here ...
8470 * lisp.h: ... to here, so that the inline functions mentioned
8473 * dired.c (directory_files_internal_unwind): Now static.
8475 * fileio.c (file_name_as_directory, directory_file_name):
8476 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8478 (file_name_as_directory): Use const pointers when appropriate.
8479 (Fexpand_file_name): Likewise. In particular, newdir might
8480 point at constant storage, so make it a const pointer.
8481 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8482 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8484 (Fset_file_times, Finsert_file_contents, auto_save_error):
8485 Rename locals to avoid shadowing.
8487 * minibuf.c (choose_minibuf_frame_1): Now static.
8488 (Ftry_completion, Fall_completions): Rename or remove locals
8491 * marker.c (bytepos_to_charpos): Remove; unused.
8493 * lisp.h (verify_bytepos, count_markers): New decls,
8494 so that gcc does not warn that these functions aren't declared.
8496 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8497 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8498 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8499 (copy_text): Remove unused local var.
8501 * filelock.c (within_one_second): Now static.
8502 (lock_file_1): Rename local to avoid shadowing.
8504 * buffer.c (fix_overlays_before): Mark locals as initialized.
8505 (fix_start_end_in_overlays): Likewise. This function should be
8506 simplified by using pointers-to-pointers, but that's a different
8508 (switch_to_buffer_1): Now static.
8509 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8510 (report_overlay_modification): Rename locals to avoid shadowing.
8512 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8513 Fix pointer signedness issue.
8514 (sys_subshell): Mark local as volatile if checking for lint,
8515 to suppress a gcc -Wclobbered warning that does not seem to be right.
8516 (MAXPATHLEN): Define only if needed.
8518 * process.c (serial_open, serial_configure): Move decls from here ...
8519 * systty.h: ... to here, so that they can be checked.
8521 * fns.c (get_random, seed_random): Move extern decls from here ...
8522 * lisp.h: ... to here, so that they can be checked.
8524 * sysdep.c (reset_io): Now static.
8525 (wait_for_termination_signal): Remove; unused.
8527 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8528 (copy_keymap_item, append_key, push_text_char_description):
8530 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8531 (DENSE_TABLE_SIZE): Remove; unused.
8532 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8533 (describe_map_tree):
8534 Rename locals to avoid shadowing.
8536 * keyboard.c: Declare functions static if they are not used elsewhere.
8537 (echo_char, echo_dash, cmd_error, top_level_2):
8538 (poll_for_input, handle_async_input): Now static.
8539 (read_char, kbd_buffer_get_event, make_lispy_position):
8540 (make_lispy_event, make_lispy_movement, apply_modifiers):
8541 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8542 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8543 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8544 (read_key_sequence, read_char): Mark locals as initialized.
8545 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8547 * keyboard.h (make_ctrl_char): New decl.
8548 (mark_kboards): Move decl here ...
8549 * alloc.c (mark_kboards): ... from here.
8551 * lisp.h (force_auto_save_soon): New decl.
8553 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8554 (DEFINE_DUMMY_FUNCTION): New macro.
8555 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8557 (main): Add casts to avoid warnings
8558 if GCC considers string literals to be constants.
8560 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8562 * dbusbind.c: Pointer signedness fixes.
8563 (xd_signature, xd_append_arg, xd_initialize):
8564 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8565 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8566 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8567 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8569 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8570 if GCC considers string literals to be constants.
8571 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8573 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8575 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8576 (print_preprocess, print_object): New macro to fix last change.
8578 * print.c (print_preprocess): Don't forget font objects.
8580 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8582 * emacs.c (USAGE3): Doc fixes.
8584 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8586 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8589 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8591 * lisp.h (VWindow_system, Qfile_name_history):
8592 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8593 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8594 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8596 * w32select.c: Don't #include "keyboard.h".
8597 (run_protected): Add extern declaration for waiting_for_input.
8599 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8600 * w32console.c (detect_input_pending, read_input_pending)
8601 (encode_terminal_code):
8602 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8603 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8604 (w32_system_caret_y, Qfile_name_history):
8605 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8606 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8607 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8608 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8609 * w32proc.c (Qlocal, report_file_error):
8610 * w32term.c (Vwindow_system, updating_frame):
8611 * w32uniscribe.c (initialized, uniscribe_font_driver):
8612 Remove unneeded extern declarations.
8614 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8616 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8618 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8620 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8621 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8622 These macros can no longer be used for assignment.
8624 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8625 Assign struct members directly, instead of using BUF_BEGV etc.
8626 (record_buffer_markers, fetch_buffer_markers): New functions for
8627 recording and fetching special buffer markers.
8628 (set_buffer_internal_1, set_buffer_temp): Use them.
8630 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8632 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8634 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8635 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8637 * xdisp.c (hscroll_window_tree):
8638 (reconsider_clip_changes): Use PT instead of BUF_PT.
8640 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8642 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8643 $(EMACS_ROOT)/lib/intprops.h.
8645 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8647 Fix more problems found by GCC 4.5.2's static checks.
8649 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8650 to unsigned char * to avoid compiler diagnostic.
8651 (xg_free_frame_widgets): Make it clear that a local variable is
8652 needed only if USE_GTK_TOOLTIP.
8653 (gdk_window_get_screen): Make it clear that this macro is needed
8654 only if USE_GTK_TOOLTIP.
8655 (int_gtk_range_get_value): New function, which avoids a diagnostic
8656 from gcc -Wbad-function-cast.
8657 (xg_set_toolkit_scroll_bar_thumb): Use it.
8658 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8659 diagnostic from gcc -Wbad-function-cast.
8660 (get_utf8_string, xg_get_file_with_chooser):
8661 Rename locals to avoid shadowing.
8662 (create_dialog): Move locals to avoid shadowing.
8664 * xgselect.c (xg_select): Remove unused var.
8666 * image.c (four_corners_best): Mark locals as initialized.
8667 (gif_load): Initialize transparent_p to zero (Bug#8238).
8668 Mark another local as initialized.
8669 (my_png_error, my_error_exit): Mark with NO_RETURN.
8671 * image.c (clear_image_cache): Now static.
8672 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8673 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8674 (x_edge_detection): Remove unnecessary cast that
8675 gcc -Wbad-function-cast diagnoses.
8676 (gif_load): Fix pointer signedness.
8677 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8678 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8680 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8682 Improve quality of tests for time stamp overflow.
8683 For example, without this patch (encode-time 0 0 0 1 1
8684 1152921504606846976) returns the obviously-bogus value (-948597
8685 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8686 reports time overflow. See
8687 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8688 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8689 * editfns.c: Include limits.h and intprops.h.
8690 (TIME_T_MIN, TIME_T_MAX): New macros.
8691 (time_overflow): Move earlier, to before first use.
8692 (hi_time, lo_time): New functions, for an accurate test for
8694 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8695 (Fget_internal_run_time): Don't assume time_t fits in int.
8696 (make_time): Use list2 instead of Fcons twice.
8697 (Fdecode_time): More accurate test for out-of-range times.
8698 (check_tm_member): New function.
8699 (Fencode_time): Use it, to test for out-of-range times.
8700 (lisp_time_argument): Don't rely on undefined left-shift and
8701 right-shift behavior when checking for time stamp overflow.
8703 * editfns.c (time_overflow): New function, refactoring common code.
8704 (Fformat_time_string, Fdecode_time, Fencode_time):
8705 (Fcurrent_time_string): Use it.
8707 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8708 * dired.c (make_time): Move to ...
8709 * editfns.c (make_time): ... here.
8710 * systime.h: Note the move.
8712 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8714 * fringe.c (update_window_fringes): Remove unused variables.
8716 * unexmacosx.c (copy_data_segment): Also copy __got section.
8719 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8721 * termcap.c [MSDOS]: Include "msdos.h".
8722 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8723 Constify `char *' arguments and their references according to
8724 prototypes in tparam.h.
8726 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8728 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8729 Adapt all references accordingly.
8731 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8733 2011-03-11 Tom Tromey <tromey@redhat.com>
8735 * buffer.c (syms_of_buffer): Remove obsolete comment.
8737 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8739 * termhooks.h (encode_terminal_code): Declare prototype.
8741 * msdos.c (encode_terminal_code): Don't declare prototype.
8743 * term.c (encode_terminal_code): Now external again, used by
8744 w32console.c and msdos.c.
8746 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8747 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8749 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8751 Fix some minor problems found by GCC 4.5.2's static checks.
8753 * fringe.c (update_window_fringes): Mark locals as initialized
8755 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8757 * alloc.c (mark_fringe_data): Move decl from here ...
8758 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8759 to check its interface.
8760 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8762 * fontset.c (free_realized_fontset): Now static.
8763 (Fset_fontset_font): Rename local to avoid shadowing.
8764 (fontset_font): Mark local as initialized.
8765 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8767 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8769 * xselect.c (x_disown_buffer_selections): Remove; not used.
8770 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8771 (x_own_selection, Fx_disown_selection_internal): Rename locals
8773 (x_handle_dnd_message): Remove local to avoid shadowing.
8775 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8776 so that the caller can use some name other than gcpro1.
8777 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8778 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8779 (Fx_backspace_delete_keys_p):
8780 Use them to avoid shadowing, and rename vars to avoid shadowing.
8781 (x_decode_color, x_set_name, x_window): Now static.
8782 (Fx_create_frame): Add braces to silence GCC warning.
8783 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8784 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8785 Remove unused locals.
8786 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8787 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8788 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8791 * xterm.h (x_mouse_leave): New decl.
8793 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8794 Remove unused functions.
8795 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8796 (x_calc_absolute_position): Now static.
8797 (XTread_socket): Don't define label "out" unless it's used.
8798 Don't declare local "event" unless it's used.
8799 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8800 unless they are used.
8801 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8802 (x_fatal_error_signal): Remove; not used.
8803 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8804 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8805 (x_error_catcher, x_connection_closed, x_error_handler):
8806 (x_error_quitter, xembed_send_message, x_iconify_frame):
8807 (my_log_handler): Rename locals to avoid shadowing.
8808 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8809 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8811 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8812 Rename or move locals to avoid shadowing.
8813 (tty_defined_color, merge_face_heights): Now static.
8814 (free_realized_faces_for_fontset): Remove; not used.
8815 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8816 does not deduce is never used uninitialized.
8817 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8818 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8820 * terminal.c (store_terminal_param): Now static.
8822 * xmenu.c (menu_highlight_callback): Now static.
8823 (set_frame_menubar): Remove unused local.
8824 (xmenu_show): Rename parameter to avoid shadowing.
8825 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8826 since they might point to immutable storage.
8827 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8828 since it's unused otherwise.
8830 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8831 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8832 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8833 avoids a gcc -Wuninitialized diagnostic.
8834 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8835 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8836 does not deduce are never used uninitialized.
8838 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8840 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8841 * window.c (window_loop, size_window):
8842 (run_window_configuration_change_hook, enlarge_window): Likewise.
8844 * window.c (display_buffer): Now static.
8845 (size_window): Mark variables that gcc -Wuninitialized
8846 does not deduce are never used uninitialized.
8847 * window.h (check_all_windows): New decl, to forestall
8848 gcc -Wmissing-prototypes diagnostic.
8849 * dispextern.h (bidi_dump_cached_states): Likewise.
8851 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8853 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8855 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8856 and to avoid gcc -Wuninitialized warning.
8857 (load_charset_map): Mark variables that gcc -Wuninitialized
8858 does not deduce are never used uninitialized.
8859 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8861 * coding.c (coding_set_source, coding_set_destination):
8862 Use "else { /* comment */ }" rather than "else /* comment */;"
8863 for clarity, and to avoid gcc -Wempty-body warning.
8864 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8865 a block, when the outer 'i' will do.
8866 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8867 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8868 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8869 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8870 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8871 Rename locals to avoid shadowing.
8872 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8873 * coding.c (emacs_mule_char, encode_invocation_designation):
8874 Now static, since they're not used elsewhere.
8875 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8876 (decode_coding_object, encode_coding_object, detect_coding_system):
8877 (decode_coding_emacs_mule): Mark variables that gcc
8878 -Wuninitialized does not deduce are never used uninitialized.
8879 (detect_coding_iso_2022): Initialize a local variable that might
8880 be used uninitialized. Leave a FIXME because it's not clear that
8881 this initialization is needed. (Bug#8211)
8882 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8883 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8884 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8885 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8886 Remove unused macros.
8888 * category.c (hash_get_category_set): Remove unused local var.
8889 (copy_category_table): Now static, since it's not used elsewhere.
8890 * character.c (string_count_byte8): Likewise.
8892 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8893 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8895 * chartab.c (copy_sub_char_table): Now static, since it's not used
8897 (sub_char_table_ref_and_range, char_table_ref_and_range):
8898 Rename locals to avoid shadowing.
8899 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8901 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8902 (BIDI_BOB): Remove unused macro.
8904 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8905 deduce are never used uninitialized.
8906 * term.c (encode_terminal_code): Likewise.
8908 * term.c (encode_terminal_code): Now static. Remove unused local.
8910 * tparam.h: New file.
8911 * term.c, tparam.h: Include it.
8912 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8913 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8914 Move these decls to tparam.h, and make them agree with what
8915 is actually in tparam.c. The previous trick of using incompatible
8916 decls in different modules does not conform to the C standard.
8917 All callers of tparam changed to use tparam's actual API.
8918 * tparam.c (tparam1, tparam, tgoto):
8919 Use const pointers where appropriate.
8921 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8922 * cm.h (struct cm): Likewise.
8923 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8924 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8925 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8926 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8927 (turn_on_face, init_tty): Likewise.
8928 * termchar.h (struct tty_display_info): Likewise.
8930 * term.c (term_mouse_position): Rename local to avoid shadowing.
8932 * alloc.c (mark_ttys): Move decl from here ...
8933 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8935 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8937 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8939 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
8941 * search.c (compile_pattern_1): Remove argument regp, unused since
8942 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8943 (compile_pattern): Don't pass it.
8945 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8947 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8948 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8950 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8952 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8954 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8955 gdk_window_get_screen, gdk_window_get_geometry,
8956 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8957 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8958 (xg_get_pixbuf_from_pixmap): New function.
8959 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8960 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8961 Call xg_get_pixbuf_from_pixmap instead of
8962 gdk_pixbuf_get_from_drawable.
8963 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8964 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8965 (xg_check_special_colors): Use GtkStyleContext and its functions
8967 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8968 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8969 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
8970 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8971 Call gtk_widget_get_preferred_size.
8972 (xg_frame_resized): gdk_window_get_geometry only takes 5
8974 (xg_win_to_widget, xg_event_is_for_menubar):
8975 Call gdk_x11_window_lookup_for_display.
8976 (xg_set_widget_bg): New function.
8977 (delete_cb): New function.
8978 (xg_create_frame_widgets): Connect delete-event to delete_cb.
8979 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
8980 (xg_set_background_color): Call xg_set_widget_bg.
8981 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8982 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8983 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8984 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8986 (update_frame_tool_bar): Call gtk_widget_hide.
8987 (xg_initialize): Use GDK_KEY_g.
8989 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8991 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8993 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8994 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8995 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8997 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
8999 * w32xfns.c (select_palette): Check success of RealizePalette against
9000 GDI_ERROR, not zero.
9002 See ChangeLog.11 for earlier changes.
9008 Copyright (C) 2011 Free Software Foundation, Inc.
9010 This file is part of GNU Emacs.
9012 GNU Emacs is free software: you can redistribute it and/or modify
9013 it under the terms of the GNU General Public License as published by
9014 the Free Software Foundation, either version 3 of the License, or
9015 (at your option) any later version.
9017 GNU Emacs is distributed in the hope that it will be useful,
9018 but WITHOUT ANY WARRANTY; without even the implied warranty of
9019 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9020 GNU General Public License for more details.
9022 You should have received a copy of the GNU General Public License
9023 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.