Fix handling of X resource for window icons.
[bpt/emacs.git] / src / ChangeLog
1 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2
3 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4 boolean (Bug#9154).
5
6 2011-09-18 Eli Zaretskii <eliz@gnu.org>
7
8 * xdisp.c (display_line): Record maximum and minimum buffer
9 positions even if no glyphs were produced (e.g., by a zero-width
10 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
11 buffer positions that will be removed from the glyph row because
12 they don't fit.
13 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
14 column is beyond frame width: don't subtract 1 "pixel" when
15 computing width of the stretch.
16 (reseat_at_next_visible_line_start): Undo the change made on
17 2011-09-17 that saved paragraph information and restored it after
18 the call to `reseat'. (Bug#9545)
19
20 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
21
22 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
23 and turn window cursor on if cleared (Bug#9415).
24
25 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
26
27 * search.c (boyer_moore): Take unibyte characters from pattern
28 literally. (Bug#9458)
29
30 2011-09-18 Eli Zaretskii <eliz@gnu.org>
31
32 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
33
34 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
35
36 Fix minor problem found by static checking.
37 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
38 initialized, to pacify gcc -Wuninitialized.
39
40 * fileio.c: Report proper errno when syscall falls.
41 (Finsert_file_contents): Save and restore errno,
42 so that report_file_error outputs the correct diagnostic.
43 (Fwrite_region) [CLASH_DETECTION]: Likewise.
44
45 2011-09-18 Eli Zaretskii <eliz@gnu.org>
46
47 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
48
49 2011-09-17 Eli Zaretskii <eliz@gnu.org>
50
51 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
52 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
53
54 2011-09-17 Eli Zaretskii <eliz@gnu.org>
55
56 * xdisp.c (reseat_at_next_visible_line_start): Keep information
57 about the current paragraph and restore it after the call to
58 reseat.
59
60 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
61 (bidi_find_paragraph_start): Search back for paragraph beginning
62 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
63 (bidi_move_to_visually_next): Only trigger paragraph-related
64 computations when the last character is a newline or at EOB, not
65 just any NEUTRAL_B. (Bug#9470)
66
67 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
68 truncated lines if point is covered by a display string. (Bug#9524)
69
70 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
71
72 * xselect.c: Relax test for outgoing X longs (Bug#9498).
73 (cons_to_x_long): New function.
74 (lisp_data_to_selection_data): Use it. Correct the test for
75 short-versus-long data; it was negated. Break out of vector
76 loop, for efficiency, when a long datum is discovered.
77
78 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
79
80 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
81
82 2011-09-16 Eli Zaretskii <eliz@gnu.org>
83
84 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
85 GCC PR/17406) by declaring this function with external scope.
86
87 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
88
89 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
90 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
91
92 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
93
94 * editfns.c (Fformat): Correctly handle text properties on "%%".
95
96 2011-09-15 Eli Zaretskii <eliz@gnu.org>
97
98 * xterm.c (x_draw_composite_glyph_string_foreground):
99 * w32term.c (x_draw_composite_glyph_string_foreground):
100 * term.c (encode_terminal_code):
101 * composite.c (composition_update_it, get_composition_id):
102 * xdisp.c (get_next_display_element)
103 (fill_composite_glyph_string): Add comments about special meaning
104 of TAB characters in a composition.
105
106 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
107
108 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
109 This occurs when processing a multibyte format.
110 Problem reported by Wolfgang Jenker.
111
112 2011-09-15 Johan Bockgård <bojohan@gnu.org>
113
114 * xdisp.c (try_cursor_movement): Only check for exact match if
115 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
116
117 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
118
119 Remove unused external symbols.
120 * dispextern.h (calc_pixel_width_or_height): Remove decl.
121 * xdisp.c (calc_pixel_width_or_height): Now static.
122 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
123 * indent.c (check_display_width):
124 * w32term.c: Fix comment to match code.
125 * xterm.c, xterm.h (x_catching_errors): Remove.
126
127 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
128
129 * xselect.c: Use signed conversions more consistently (Bug#9498).
130 (selection_data_to_lisp_data): Assume incoming selection data are
131 signed integers, not unsigned. This is to be consistent with
132 outgoing selection data, which was modified to use signed integers
133 in as part of the fix to Bug#9196 in response to Jan D.'s comment
134 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
135 expects long, not unsigned long.
136
137 2011-09-14 Eli Zaretskii <eliz@gnu.org>
138
139 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
140 computation of loop end. Reported by Johan Bockgård
141 <bojohan@gnu.org>.
142
143 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
144
145 * frame.c (Fother_visible_frames_p): Function deleted.
146
147 2011-09-12 Eli Zaretskii <eliz@gnu.org>
148
149 * indent.c (compute_motion): Process display vector front to back
150 rather than the other way around. (Bug#2496)
151
152 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
153
154 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
155
156 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
157
158 * minibuf.c (Fread_from_minibuffer): Doc fix.
159
160 2011-09-11 Eli Zaretskii <eliz@gnu.org>
161
162 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
163 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
164
165 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
166
167 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
168 value for non-existent files.
169
170 2011-09-11 Eli Zaretskii <eliz@gnu.org>
171
172 * fileio.c (Finsert_file_contents): If the file cannot be opened,
173 set its "size" to -1. This will set the modtime_size field of
174 the corresponding buffer to -1, which is what
175 verify-visited-file-modtime expects for files that do not exist.
176 (Bug#9139)
177
178 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
179
180 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
181 here ...
182 * lisp.h: ... from here. push_key_description is no longer
183 defined in keyboard.c, so its declaration should not be in
184 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
185 logically belongs with push_key_description.
186
187 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
188
189 * buffer.h: Include <sys/types.h> instead of <time.h>.
190 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
191 Problem reported by Herbert J. Skuhra.
192
193 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
194
195 * xml.c (parse_region): Make the parsing work for
196 non-comment-starting XML files again (bug#9144).
197
198 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
199
200 * image.c (gif_load): Fix calculation of bottom and right corner.
201 (Bug#9468)
202
203 2011-09-10 Eli Zaretskii <eliz@gnu.org>
204
205 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
206 redisplay in small windows.
207
208 2011-09-09 Eli Zaretskii <eliz@gnu.org>
209
210 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
211
212 2011-09-08 Martin Rudalics <rudalics@gmx.at>
213
214 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
215 Operate on live windows only.
216
217 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
218
219 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
220
221 2011-09-07 Eli Zaretskii <eliz@gnu.org>
222
223 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
224 only under bidi iteration.
225
226 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
227
228 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
229
230 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
231
232 isnan: Fix porting problem to Solaris 10 with bundled gcc.
233 Without this fix, the command to link temacs failed due to an
234 undefined symbol __builtin_isnan. This is because
235 /usr/include/iso/math_c99.h #defines isnan(x) to
236 __builtin_isnan(x), but the bundled gcc, which identifies itself
237 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
238 a __builtin_isnan.
239 * floatfns.c (isnan): #undef, and then #define to a clone of
240 what's in data.c.
241 (Fisnan): Always define, since it's always available now.
242 (syms_of_floatfns): Always define isnan at the Lisp level.
243
244 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
245
246 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
247
248 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
249
250 * fileio.c: Fix bugs with large file offsets (Bug#9428).
251 The previous code assumed that file offsets (off_t values) fit in
252 EMACS_INT variables, which is not true on typical 32-bit hosts.
253 The code messed up by falsely reporting buffer overflow in cases
254 such as (insert-file-contents "big" nil 1 2) into an empty buffer
255 when "big" contains more than 2**29 bytes, even though this
256 inserts just one byte and does not overflow the buffer.
257 (Finsert_file_contents): Store file offsets as off_t
258 values, not as EMACS_INT values. Check for overflow when
259 converting between EMACS_INT and off_t. When checking for
260 buffer overflow or for overlap, take the offsets into account.
261 Don't use EMACS_INT for small values where int suffices.
262 When checking for overlap, fix a typo: ZV was used where
263 ZV_BYTE was intended.
264 (Fwrite_region): Don't assume off_t fits into 'long'.
265 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
266
267 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
268
269 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
270
271 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
272
273 sprintf-related integer and memory overflow issues (Bug#9412).
274
275 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
276 (esprintf, exprintf, evxprintf): New functions.
277 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
278 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
279 (modify_event_symbol): Do not assume that the length of
280 name_alist_or_stem is safe to alloca and fits in int.
281 (Fexecute_extended_command): Likewise for function name and binding.
282 (Frecursion_depth): Wrap around reliably on integer overflow.
283 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
284 since some callers pass EMACS_INT values.
285 (Fsingle_key_description): Don't crash if symbol name contains more
286 than MAX_ALLOCA bytes.
287 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
288 (get_minibuffer): Arg is now EMACS_INT, not int.
289 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
290 (esprintf, exprintf, evxprintf): New decls.
291 * window.h (command_loop_level, minibuf_level): Reflect API changes.
292
293 * dbusbind.c (signature_cat): New function.
294 (xd_signature, Fdbus_register_signal):
295 Do not overrun buffer; instead, report string overflow.
296
297 * dispnew.c (add_window_display_history): Don't overrun buffer.
298 Truncate instead; this is OK since it's just a log.
299
300 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
301 even if the time zone offset is outlandishly large.
302 Don't mishandle offset == INT_MIN.
303
304 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
305 when creating daemon; the previous buffer-overflow check was incorrect.
306
307 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
308 which has the guts of the old verror function.
309
310 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
311 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
312
313 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
314 (font_unparse_xlfd): Don't blindly alloca long strings.
315 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
316 fits in int, when using sprintf. Use single snprintf to count
317 length of string rather than counting it via multiple sprintfs;
318 that's simpler and more reliable.
319 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
320 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
321 sprintf, in case result does not fit in int.
322
323 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
324 (fontset_from_font): Print it.
325
326 * frame.c (tty_frame_count): Now printmax_t, not int.
327 (make_terminal_frame, set_term_frame_name): Print it.
328 (x_report_frame_params): In X, window IDs are unsigned long,
329 not signed long, so print them as unsigned.
330 (validate_x_resource_name): Check for implausibly long names,
331 and don't assume name length fits in 'int'.
332 (x_get_resource_string): Don't blindly alloca invocation name;
333 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
334 not fit in int.
335
336 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
337 (xg_check_special_colors, xg_set_geometry):
338 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
339
340 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
341 Use esprintf, not sprintf, in case result does not fit in int.
342
343 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
344 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
345 it as a large positive number.
346 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
347 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
348
349 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
350 in case result does not fit in int.
351
352 * print.c (float_to_string): Detect width overflow more reliably.
353 (print_object): Make sprintf buffer a bit bigger, to avoid potential
354 buffer overrun. Don't assume list length fits in 'int'. Treat
355 print length of 0 as 0, not as infinity; to be consistent with other
356 uses of print length in this function. Don't overflow print length
357 index. Don't assume hash table size fits in 'long', or that
358 vectorlike size fits in 'unsigned long'.
359
360 * process.c (make_process): Use printmax_t, not int, to format
361 process-name gensyms.
362
363 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
364
365 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
366 to avoid potential buffer overrun.
367
368 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
369 if X resource line is longer than 512 bytes.
370
371 * xfns.c (x_window): Make sprintf buffer a bit bigger
372 to avoid potential buffer overrun.
373
374 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
375
376 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
377
378 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
379
380 Integer overflow fixes for scrolling, etc.
381 Without these, Emacs silently mishandles large integers sometimes.
382 For example, "C-u 4294967297 M-x recenter" was treated as if
383 it were "C-u 1 M-x recenter" on a typical 64-bit host.
384
385 * xdisp.c (try_window_id): Check Emacs fixnum range before
386 converting to 'int'.
387
388 * window.c (window_scroll_line_based, Frecenter):
389 Check that an Emacs fixnum is in range before assigning it to 'int'.
390 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
391 values converted from Emacs fixnums.
392 (Frecenter): Don't wrap around a line count if it is out of 'int'
393 range; instead, treat it as an extreme value.
394 (Fset_window_configuration, compare_window_configurations):
395 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
396
397 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
398 that can exceed INT_MAX. Check that EMACS_INT value is in range
399 before assigning it to the (possibly-narrower) index.
400 (match_limit): Don't assume that a fixnum can fit in 'int'.
401
402 * print.c (print_object): Use ptrdiff_t, not int, for index that can
403 exceed INT_MAX.
404
405 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
406 (Fvertical_motion): Don't wrap around LINES values that don't fit
407 in 'int'. Instead, treat them as extreme values. This is good
408 enough for windows, which can't have more than INT_MAX lines anyway.
409
410 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
411
412 * Require libxml/parser.h to avoid compilation warning.
413
414 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
415
416 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
417 since this reportedly can destroy thread storage.
418
419 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
420
421 * syntax.c (find_defun_start): Update all cache variables if
422 exiting early (Bug#9401).
423
424 2011-08-30 Eli Zaretskii <eliz@gnu.org>
425
426 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
427
428 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
429 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
430 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
431
432 * term.c (tty_append_glyph): New function.
433 (produce_stretch_glyph): Static function and its prototype deleted.
434
435 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
436 prototypes.
437
438 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
439
440 * image.c (parse_image_spec): Check for nonnegative, not for positive,
441 when checking :margin (Bug#9390).
442 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
443 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
444 so that the name doesn't mislead. All uses changed.
445
446 2011-08-28 Johan Bockgård <bojohan@gnu.org>
447
448 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
449 set_tty_hooks.
450
451 2011-08-27 Eli Zaretskii <eliz@gnu.org>
452
453 * xdisp.c (move_it_to): Don't bail out early when reaching
454 position beyond to_charpos, if we are scanning backwards.
455 (move_it_vertically_backward): When DY == 0, make sure we get to
456 the first character in the line after the newline.
457
458 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
459
460 * ccl.c: Improve and simplify overflow checking (Bug#9196).
461 (ccl_driver): Do not generate an out-of-range pointer.
462 (Fccl_execute_on_string): Remove unnecessary check for
463 integer overflow, noted by Stefan Monnier in
464 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
465 Remove a FIXME that didn't need fixing.
466 Simplify the newly-introduced buffer reallocation code.
467
468 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
469
470 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
471
472 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
473
474 Integer and memory overflow issues (Bug#9196).
475
476 * doc.c (get_doc_string): Rework so that
477 get_doc_string_buffer_size is the actual buffer size, rather than
478 being 1 less than the actual buffer size; this makes xpalloc more
479 convenient.
480
481 * image.c (x_allocate_bitmap_record, cache_image):
482 * xselect.c (Fx_register_dnd_atom):
483 Simplify previous changes by using xpalloc.
484
485 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
486 since either will do and ptrdiff_t is convenient with xpalloc.
487
488 * charset.c (charset_table_size)
489 (struct charset_sort_data.priority): Now ptrdiff_t.
490 (charset_compare): Don't overflow if priorities differ greatly.
491 (Fsort_charsets): Don't assume list length fits in int.
492 Check for size-calculation overflow when allocating sort data.
493 (syms_of_charset): Allocate an initial charset table that is
494 just under 64 KiB, to avoid problems with glibc malloc and mmap.
495
496 * cmds.c (internal_self_insert): Check for size-calculation overflow.
497
498 * composite.h (struct composition.glyph_len): Now int, not unsigned.
499 The actual value is always <= INT_MAX, and leaving it unsigned made
500 overflow checking harder.
501
502 * dispextern.h (struct glyph_matrix.rows_allocated)
503 (struct face_cache.size): Now ptrdiff_t, for convenience in use
504 with xpalloc. The values are still always <= INT_MAX.
505
506 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
507
508 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
509 (SAFE_NALLOCA): New macro.
510
511 * region-cache.c (struct boundary.pos, find_cache_boundary)
512 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
513 (set_cache_region, invalidate_region_cache)
514 (revalidate_region_cache, know_region_cache, region_cache_forward)
515 (region_cache_backward, pp_cache):
516 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
517 so that ptrdiff_t * can be passed to xpalloc.
518 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
519 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
520 (pp_cache): Don't assume cache_len fits in int.
521 * region-cache.h: Adjust extern decls to match.
522
523 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
524 EMACS_INT, since either will do, for xpalloc.
525
526 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
527 (xnmalloc, xnrealloc, xpalloc): New functions.
528
529 * bidi.c (bidi_shelve_header_size): New constant.
530 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
531 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
532
533 * bidi.c (bidi_cache_shrink):
534 * buffer.c (overlays_at, overlays_in, record_overlay_string)
535 (overlay_strings):
536 Don't update size of array until after memory allocation succeeds,
537 because xmalloc/xrealloc may not return.
538 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
539 now that we have proper integer overflow checking.
540 (record_overlay_string, overlay_strings): Catch overflows when
541 calculating size of overlay_str_buf.
542
543 * callproc.c (Fcall_process): Check for size overflow when
544 calculating size of args2.
545 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
546 Normally we prefer signed values, but sticking with ptrdiff_t would
547 require adding more-complicated checks.
548
549 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
550 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
551 Redo buffer-overflow calculations to avoid integer overflow.
552 Add a FIXME comment where memory seems to be over-allocated.
553
554 * character.c (Fstring): Check for size-calculation overflow.
555
556 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
557 unnecessary integer overflow. Check for size overflow.
558 (encode_coding_object): Don't update size until xmalloc succeeds.
559
560 * composite.c (get_composition_id): Check for overflow in glyph
561 length calculations.
562
563 Integer and memory overflow fixes for display code.
564 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
565 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
566 (scrolling_window): Check for overflow in size calculations.
567 (line_draw_cost, realloc_glyph_pool, add_row_entry):
568 Don't assume glyph table len fits in int.
569 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
570 (row_table_size): Now ptrdiff_t, not int.
571 (scrolling_window): Avoid overflow in size calculations.
572 Don't update size until allocation succeeds.
573 * fns.c (concat): Check for overflow in size calculations.
574 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
575 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
576 (NEXT_ALMOST_PRIME_LIMIT): New constant.
577
578 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
579 (get_doc_string): Check for size calculation overflow.
580 Don't update size until allocation succeeds.
581 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
582 EMACS_INT, where ptrdiff_t will do.
583 (Fsubstitute_command_keys): Check for string overflow.
584
585 * editfns.c (set_time_zone_rule): Don't assume environment length
586 fits in int.
587 (message_length): Now ptrdiff_t, not int.
588 (Fmessage_box): Don't update size until allocation succeeds.
589 Don't assume message length fits in int.
590 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
591
592 * emacs.c (main): Do not reallocate argv, since there is a null at
593 the end that can be overwritten, and this way there's no need to
594 worry about size-calculation overflow.
595 (sort_args): Check for size-calculation overflow.
596
597 * eval.c (init_eval_once, grow_specpdl): Don't update size until
598 alloc succeeds.
599 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
600
601 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
602 (x_set_scroll_bar_width, x_figure_window_size):
603 Check for integer overflow.
604 (x_set_alpha): Do not assume XINT fits in int.
605
606 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
607 This is for the members text_lines, text_cols, total_lines, total_cols,
608 where the system imposes an 'int' limit.
609
610 * fringe.c (Fdefine_fringe_bitmap):
611 Don't update size until alloc works.
612
613 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
614 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
615
616 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
617 Check for size-calculation overflow.
618 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
619 do, as we prefer signed integers.
620 (id_to_widget.max_size, id_to_widget.used)
621 (xg_store_widget_in_map, xg_remove_widget_from_map)
622 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
623 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
624 Use and return ptrdiff_t, not int.
625 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
626 * gtkutil.h: Change prototypes to match the above.
627
628 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
629 are duplicate now that they've been promoted to lisp.h.
630 (x_allocate_bitmap_record, x_alloc_image_color)
631 (make_image_cache, cache_image, xpm_load):
632 Don't update size until alloc is done.
633 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
634 (x_detect_edges):
635 Check for size calculation overflow.
636 (ct_colors_allocated_max): New constant.
637 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
638 overflow.
639
640 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
641 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
642 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
643 Use ptrdiff_t, not int, to count maps.
644 (read_char_minibuf_menu_prompt): Check for overflow in size
645 calculations. Don't update size until allocation succeeds. Redo
646 calculations to avoid overflow.
647 * keyboard.h: Change prototypes to match the above.
648
649 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
650 to count maps.
651 (current_minor_maps): Check for size calculation overflow.
652 * keymap.h: Change prototypes to match the above.
653
654 * lread.c (read1, init_obarray): Don't update size until alloc done.
655
656 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
657 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
658
659 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
660 Now ptrdiff_t, not int.
661 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
662 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
663
664 * process.c (Fnetwork_interface_list): Check for overflow
665 in size calculation.
666
667 * region-cache.c (move_cache_gap): Check for size calculation overflow.
668
669 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
670 overflow. Don't bother calling xmalloc when xrealloc will do.
671
672 * search.c (Freplace_match): Check for size calculation overflow.
673 (Fset_match_data): Don't assume list lengths fit in 'int'.
674
675 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
676 for command line length. Do not attempt to address one before the
677 beginning of an array, as that's not portable.
678
679 * term.c (max_frame_lines): Remove; unused.
680 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
681 not int.
682 (encode_terminal_code, calculate_costs): Check for size
683 calculation overflow.
684 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
685 table lengths and related sizes. Don't update size until alloc
686 done. Redo calculations to avoid overflow.
687 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
688
689 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
690 subtracting pointers.
691 (gobble_line): Check for overflow more carefully. Don't update size
692 until alloc done.
693
694 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
695 Don't update size until alloc done.
696 Redo size calculations to avoid overflow.
697 Check for size calculation overflow.
698 (main) [DEBUG]: Fix typo in invoking tparam1.
699
700 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
701 Use ptrdiff_t, not int, for sizes.
702 (store_mode_line_noprop_char): Don't update size until alloc done.
703
704 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
705 Use ptrdiff_t, not int, for sizes.
706 (Finternal_make_lisp_face, cache_face):
707 Check for size calculation overflow.
708 (cache_face): Treat size calculation overflows as if they were
709 memory exhaustion (the usual treatment), rather than aborting.
710
711 * xfns.c (x_encode_text, x_set_name_internal)
712 (Fx_change_window_property): Use ptrdiff_t, not int, to count
713 sizes, since they can exceed INT_MAX in size. Check for size
714 calculation overflow.
715
716 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
717 (xg_select): Check for size calculation overflow.
718 Don't update size until alloc done.
719
720 * xrdb.c (get_environ_db): Don't assume path length fits in int,
721 as sprintf is limited to int lengths.
722
723 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
724 (X_LONG_MIN): New macros.
725 Use them to make the following changes clearer.
726 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
727 This change doesn't affect the value now, but it may help remind
728 future maintainers not to raise the value too much later.
729 (SELECTION_QUANTUM): Remove, replacing with ...
730 (selection_quantum): ... new function, which avoids overflow.
731 All uses changed.
732 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
733 assumption that selection length fits in 'int'.
734 (x_reply_selection_request, x_handle_selection_request)
735 (x_get_window_property, receive_incremental_selection)
736 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
737 (lisp_data_to_selection_data, clean_local_selection_data):
738 Use ptrdiff_t, not int, to record length of selection.
739 (x_reply_selection_request, x_get_window_property)
740 (receive_incremental_selection, x_property_data_to_lisp):
741 Redo calculations to avoid overflow.
742 (x_reply_selection_request): When sending hint, ceiling it at
743 X_LONG_MAX rather than relying on wraparound overflow to send
744 something.
745 (x_get_window_property, receive_incremental_selection)
746 (lisp_data_to_selection_data, x_property_data_to_lisp):
747 Check for size-calculation overflow.
748 (x_get_window_property, receive_incremental_selection)
749 (lisp_data_to_selection_data, Fx_register_dnd_atom):
750 Don't store size until memory allocation succeeds.
751 (x_get_window_property): Plug memory leak on memory exhaustion.
752 Don't double-block input; malloc is safe here. Don't assume 2**34
753 - 4 fits in unsigned long. Add an xassert to check
754 XGetWindowProperty overflow. Be more careful about overflow
755 calculations, and distinguish size from memory overflow better.
756 (receive_incremental_selection): When tracing, don't assume
757 unsigned int is less than INT_MAX.
758 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
759 harmful) conversions of unsigned short to int.
760 (lisp_data_to_selection_data): Don't assume that integers
761 in the range -65535 through -1 fit in an X unsigned short.
762 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
763 result parameters unless successful. Rely on cons_to_unsigned
764 to report problems with elements; the old code wasn't right anyway.
765 (x_check_property_data): Check for int overflow; we cannot use
766 a wider type due to X limits.
767 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
768
769 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
770
771 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
772 (x_term_init): Check for size calculation overflow.
773 (x_color_cells): Don't store size until memory allocation succeeds.
774 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
775 Don't assume alloca size is less than MAX_ALLOCA.
776 (x_term_init): Don't assume length fits in int (sprintf is limited
777 to int size).
778
779 Use ptrdiff_t for composition IDs.
780 * character.c (lisp_string_width):
781 * composite.c (composition_table_size, n_compositions)
782 (get_composition_id, composition_gstring_from_id):
783 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
784 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
785 * window.c (Frecenter):
786 Use ptrdiff_t, not int, for composition IDs.
787 * composite.c (get_composition_id): Check for integer overflow.
788 * composite.h: Adjust prototypes to match the above changes.
789
790 Use ptrdiff_t for hash table indexes.
791 * category.c (hash_get_category_set):
792 * ccl.c (ccl_driver):
793 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
794 * coding.c (coding_system_charset_list, detect_coding_system):
795 * coding.h (struct coding_system.id):
796 * composite.c (get_composition_id, gstring_lookup_cache):
797 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
798 * image.c (xpm_get_color_table_h):
799 * lisp.h (hash_lookup, hash_put):
800 * minibuf.c (Ftest_completion):
801 Use ptrdiff_t for hash table indexes, not int (which is too
802 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
803 32-bit --with-wide-int hosts).
804
805 * charset.c (Fdefine_charset_internal): Check for integer overflow.
806 Add a FIXME comment about memory leaks.
807 (syms_of_charset): Don't assume xmalloc returns.
808
809 Don't assume that stated character widths fit in int.
810 * character.c (Fchar_width, c_string_width, lisp_string_width):
811 * character.h (CHAR_WIDTH):
812 * indent.c (MULTIBYTE_BYTES_WIDTH):
813 Use sanitize_char_width to avoid undefined and/or bad behavior
814 with outlandish widths.
815 * character.h (sanitize_tab_width): Renamed from sanitize_width,
816 now that we have two such functions. All uses changed.
817 (sanitize_char_width): New inline function.
818
819 Don't assume that tab-width fits in int.
820 * character.h (sanitize_width): New inline function.
821 (SANE_TAB_WIDTH): New macro.
822 (ASCII_CHAR_WIDTH): Use it.
823 * indent.c (sane_tab_width): Remove. All uses replaced by
824 SANE_TAB_WIDTH (current_buffer).
825 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
826
827 * fileio.c: Integer overflow issues with file modes.
828 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
829
830 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
831 Remove unreachable code.
832 (read_hex, load_charset_map_from_file): Check for integer overflow.
833
834 * xterm.c: don't go over XClientMessageEvent limit
835 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
836 (x_send_scroll_bar_event): Likewise. Check that the size does not
837 exceed limits imposed by XClientMessageEvent, as well as the usual
838 ptrdiff_t and size_t limits.
839
840 * keyboard.c: Overflow, signedness and related fixes.
841 (make_lispy_movement): Use same integer type in forward decl
842 that is used in the definition.
843 (read_key_sequence, keyremap_step):
844 Change bufsize argument back to int, undoing my 2011-03-30 change.
845 We prefer signed types, and int is wide enough here.
846 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
847 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
848 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
849 length, not size_t. Use ptrdiff_t for index, not int.
850 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
851 possibility of integer overflow.
852
853 Overflow, signedness and related fixes for images.
854
855 * dispextern.h (struct it.stack[0].u.image.image_id)
856 (struct_it.image_id, struct image.id, struct image_cache.size)
857 (struct image_cache.used, struct image_cache.ref_count):
858 * gtkutil.c (update_frame_tool_bar):
859 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
860 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
861 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
862 * nsmenu.m (update_frame_tool_bar):
863 * xdisp.c (calc_pixel_width_or_height):
864 * xfns.c (image_cache_refcount):
865 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
866 on typical 64-bit hosts.
867
868 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
869 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
870 Omit unnecessary casts to int.
871 (parse_image_spec): Check that integers fall into 'int' range
872 when the callers expect that.
873 (image_ascent): Redo ascent calculation to avoid int overflow.
874 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
875 (lookup_image): Remove unnecessary tests.
876 (xbm_image_p): Locals are now of int, not EMACS_INT,
877 since parse_image_check makes sure they fit into int.
878 (png_load, gif_load, svg_load_image):
879 Prefer int to unsigned where either will do.
880 (tiff_handler): New function, combining the cores of the
881 old tiff_error_handler and tiff_warning_handler. This
882 function is rewritten to use vsnprintf and thereby avoid
883 stack buffer overflows. It uses only the features of vsnprintf
884 that are common to both POSIX and native Microsoft.
885 (tiff_error_handler, tiff_warning_handler): Use it.
886 (tiff_load, gif_load, imagemagick_load_image):
887 Don't assume :index value fits in 'int'.
888 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
889 (imagemagick_load_image): Check that crop parameters fit into
890 the integer types that MagickCropImage accepts. Don't assume
891 Vimagemagick_render_type has a nonnegative value. Don't assume
892 size_t fits in 'long'.
893 (gs_load): Use printmax_t to print the widest integers possible.
894 Check for integer overflow when computing image height and width.
895
896 2011-08-26 Eli Zaretskii <eliz@gnu.org>
897
898 * xdisp.c (redisplay_window): Don't force window start if point
899 will be invisible in the resulting window. (Bug#9324)
900
901 2011-08-25 Eli Zaretskii <eliz@gnu.org>
902
903 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
904 the display spec is of the form `(space ...)'.
905 (handle_display_spec): Return the value returned by
906 handle_single_display_spec, not just 1 or zero.
907 (handle_single_display_spec): If the display spec is of the form
908 `(space ...)', and specifies display in the text area, return 2
909 rather than 1.
910 (try_cursor_movement): Check for the need to scroll more
911 accurately, and prefer exact match for point under bidi. Don't
912 advance `row' beyond the last row of the window.
913
914 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
915 into disp_prop; all users changed.
916
917 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
918 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
919 for the text covered by the display property.
920
921 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
922
923 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
924 Change return value to nil.
925 (Frecord_buffer): Delete unused function.
926
927 2011-08-24 Eli Zaretskii <eliz@gnu.org>
928
929 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
930 buffers, return left-to-right.
931 (set_cursor_from_row): Consider candidate row a win if its glyph
932 represents a newline and point is on that newline. Fixes cursor
933 positioning on the newline at EOL of R2L text within L2R
934 paragraph, and vice versa.
935 (try_cursor_movement): Check continued rows, in addition to
936 continuation rows. Fixes unwarranted scroll when point enters a
937 continued line of R2L text within an L2R paragraph, or vice versa.
938 (cursor_row_p): Consider the case of point being equal to
939 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
940 from the end of a short line to the beginning of a continued line
941 of R2L text within L2R paragraph.
942 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
943 composed characters.
944
945 * bidi.c (bidi_check_type): Use xassert.
946 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
947 members.
948
949 2011-08-23 Eli Zaretskii <eliz@gnu.org>
950
951 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
952 a character.
953
954 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
955
956 * nsfont.m (ns_otf_to_script): Fix typo.
957
958 2011-08-22 Kenichi Handa <handa@m17n.org>
959
960 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
961 extra slot even if the purpose is char-code-property-table.
962
963 2011-08-23 Eli Zaretskii <eliz@gnu.org>
964
965 * xdisp.c (redisplay_window): When computing centering_position,
966 account for the height of the header line. (Bug#8874)
967
968 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
969 instead of CHAR_TO_BYTE. Fixes a crash when a completion
970 candidate is selected by the mouse, and that candidate has a
971 composed character under the mouse.
972
973 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
974 coordinates reported by pos-visible-in-window-p for a composed
975 character in column zero.
976
977 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
978
979 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
980
981 2011-08-22 Eli Zaretskii <eliz@gnu.org>
982
983 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
984 consider it a hit if to_charpos is anywhere in the range of the
985 composed buffer positions.
986
987 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
988
989 * image.c (gif_load): Don't assume that each subimage has the same
990 dimensions as the base image. Handle disposal method that is
991 "undefined" by the gif spec (Bug#9335).
992
993 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
994
995 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
996 (Fcondition_case): Document `debug' symbol in error handler.
997
998 2011-08-19 Eli Zaretskii <eliz@gnu.org>
999
1000 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1001 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1002 from an Org mode buffer to a Speedbar frame.
1003
1004 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1005 a composition, take its buffer position from IT->cmp_it.charpos.
1006 Fixes cursor positioning at the beginning of a line that begins
1007 with a composed character.
1008
1009 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1010
1011 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1012 character bidirectional type, use STRONG_L instead. Fixes crashes
1013 in a buffer produced by `describe-categories'.
1014
1015 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1016 members before the level stack, so they would be saved and
1017 restored when copying iterator state. Fixes incorrect reordering
1018 around TABs covered by display properties.
1019
1020 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1021
1022 * process.c (Fnetwork_interface_list): Correctly determine buffer
1023 size.
1024
1025 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1026
1027 * eval.c (internal_condition_case, internal_condition_case_1)
1028 (internal_condition_case_2, internal_condition_case_n):
1029 Remove unnecessary aborts (Bug#9081).
1030
1031 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1032
1033 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1034 has no `load' handler, try opening the file locally. (Bug#9311)
1035
1036 2011-08-16 Ken Brown <kbrown@cornell.edu>
1037
1038 * gmalloc.c: Expand comment.
1039
1040 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1041
1042 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1043 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1044
1045 2011-08-16 Ken Brown <kbrown@cornell.edu>
1046
1047 Fix memory allocation problems in Cygwin build (Bug#9273).
1048
1049 * unexcw.c ( __malloc_initialized): Declare external variable.
1050 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1051
1052 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1053 New variables.
1054 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1055 dumped emacs.
1056 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1057 in the static heap.
1058 [CYGWIN] (special_realloc): New function.
1059 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1060 requests to realloc storage in the static heap.
1061
1062 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1063
1064 * bidi.c (bidi_initialize): Remove unused local.
1065
1066 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1067
1068 * biditype.h: File removed.
1069
1070 * bidimirror.h: File removed.
1071
1072 * deps.mk (bidi.o): Remove biditype.h and
1073 bidimirror.h.
1074
1075 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1076 bidimirror.h.
1077
1078 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1079
1080 * chartab.c: Improve commentary for the uniprop_table API.
1081
1082 * bidi.c (bidi_paragraph_init): Support zero value of
1083 bidi_ignore_explicit_marks_for_paragraph_level.
1084 (bidi_initialize): Use uniprop_table instead of including
1085 biditype.h and bidimirror.h.
1086
1087 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1088 coordinates of the iterator when restoring from ppos_it.
1089 (Bug#9296)
1090
1091 2011-08-14 Kenichi Handa <handa@m17n.org>
1092
1093 * process.c (create_process): Call setup_process_coding_systems
1094 after the pid of the process is set to -1 (Bug#8162).
1095
1096 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1097
1098 * xdisp.c (move_it_in_display_line_to): Don't invoke
1099 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1100 ppos_it. Fixes vertical cursor motion when line beginning is
1101 covered by an image. (Bug#9296)
1102
1103 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1104
1105 * nsterm.h (ns_run_ascript): Declare.
1106 (NSAPP_DATA2_RUNASSCRIPT): Define.
1107
1108 * nsfns.m (as_script, as_result, as_status): New static variables.
1109 (ns_run_ascript): New function.
1110 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1111 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1112 the event loop. Get status from as_status (Bug#7276).
1113
1114 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1115 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1116 the event loop (Bug#7276).
1117
1118 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1119
1120 * gnutls.c (QCgnutls_bootprop_priority)
1121 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1122 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1123 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1124 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1125 (QCgnutls_bootprop_verify_hostname_error)
1126 (QCgnutls_bootprop_callbacks_verify): Rename from
1127 Qgnutls_bootprop_..., all uses changed.
1128
1129 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1130 uses changed.
1131
1132 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1133
1134 * xfaces.c (Qframe_set_background_mode): Now static.
1135 * dispextern.h (Qframe_set_background_mode): Remove decl.
1136
1137 * process.c (Fnetwork_interface_info): Declare local only if needed.
1138
1139 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1140
1141 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1142 (Fnetwork_interface_list): Allocate in increments of bytes instead
1143 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1144 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1145 sockaddr.
1146 (struct ifflag_def): notrailers is smart on OSX.
1147 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1148 Get hardware address with getifaddrs if available.
1149
1150 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1151
1152 * xdisp.c (iterate_out_of_display_property): xassert that
1153 IT->position is set to within IT->object's boundaries. Break from
1154 the loop as soon as EOB is reached; avoids infloops in redisplay
1155 when IT->position is set up wrongly due to some bug.
1156 Set IT->current to match the bidi iterator unconditionally.
1157 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1158 entry. Force push_it to save on the stack the current
1159 buffer/string position, to be restored by pop_it. Fix flags in
1160 the iterator structure wrt the object coming from a display
1161 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1162 properties. (Bug#9284)
1163
1164 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1165
1166 * fontset.c (fontset_get_font_group): Add proper type checks.
1167 (Bug#9172)
1168
1169 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1170
1171 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1172 and LC_VERSION_MIN_MACOSX.
1173 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1174 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1175
1176 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1177
1178 * xdisp.c (forward_to_next_line_start): Allow to use the
1179 no-display-properties-and-no-overlays under bidi display.
1180 Set disp_pos in the bidi iterator to avoid searches for display
1181 properties and overlays.
1182
1183 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1184
1185 * editfns.c (Fset_time_zone_rule): Document relationship with the
1186 setenv function.
1187
1188 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1189 the font entity extracted from the cache (Bug#8109).
1190
1191 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1192
1193 * composite.c (autocmp_chars): Don't reset point. That is done by
1194 restore_point_unwind (Bug#5984).
1195
1196 2011-08-07 Juri Linkov <juri@jurta.org>
1197
1198 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1199 to show the arg `TIME' instead of `TIMEVAL'.
1200
1201 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1202
1203 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1204 display property strides EOL and includes a newline, as in
1205 longlines-mode. (Bug#9254)
1206 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1207 word-wrap under bidirectional display. (Bug#9224)
1208
1209 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1210 is non-zero, even if the data buffer is NULL. Fixes a crash in
1211 vertical-motion with longlines-mode. (Bug#9254)
1212
1213 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1214
1215 * bidi.c <bidi_cache_total_alloc>: Now static.
1216 (bidi_initialize): Initialize bidi_cache_total_alloc.
1217
1218 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1219 cache. (Bug#9221)
1220
1221 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1222 amount allocated this far in `bidi_cache_total_alloc'.
1223 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1224 non-zero, only free the data buffer without restoring the cache
1225 contents. All callers changed.
1226
1227 * dispextern.h (bidi_unshelve_cache): Update prototype.
1228
1229 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1230 (move_it_in_display_line, move_it_to)
1231 (move_it_vertically_backward, move_it_by_lines): Replace the call
1232 to xfree to an equivalent call to bidi_unshelve_cache.
1233 (move_it_in_display_line_to): Fix logic of returning
1234 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1235
1236 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1237
1238 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1239 came from a string character with a `cursor' property. (Bug#9229)
1240
1241 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1242
1243 * Makefile.in (LIB_PTHREAD): New variable.
1244 (LIBES): Add LIB_PTHREAD (Bug#9216).
1245
1246 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1247 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1248
1249 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1250
1251 * regex.c (re_iswctype): Remove some redundant boolean
1252 conversions.
1253
1254 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1255
1256 * xterm.c (x_find_topmost_parent): New function.
1257 (x_set_frame_alpha): Find topmost parent window with
1258 x_find_topmost_parent and set the property there also (bug#9181).
1259 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1260
1261 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1262
1263 * callproc.c (Fcall_process): Avoid vfork clobbering
1264 the local vars buffer, coding_systems, current_dir.
1265
1266 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1267
1268 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1269
1270 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1271
1272 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1273 so that it is not optimized away.
1274
1275 * xdisp.c (compute_display_string_pos): Remove unused local.
1276
1277 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1278
1279 Fix slow cursor motion and scrolling in large buffers with
1280 selective display, like Org Mode buffers. (Bug#9218)
1281
1282 * dispextern.h (struct bidi_it): New member disp_prop_p.
1283
1284 * xdisp.c: Remove one-slot cache of display string positions.
1285 (compute_display_string_pos): Accept an additional argument
1286 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1287 for a display string or property. If found, set DISP_PROP_P
1288 non-zero.
1289
1290 * bidi.c (bidi_fetch_char): Accept an additional argument
1291 DISP_PROP_P, and pass it to compute_display_string_pos.
1292 Only handle text covered by a display string if DISP_PROP_P is returned
1293 non-zero. All callers of bidi_fetch_char changed.
1294
1295 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1296
1297 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1298
1299 2010-12-03 Don March <don@ohspite.net>
1300
1301 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1302 last character M-[char] is translated to ESC [char] (bug#7541).
1303
1304 2011-08-02 Kenichi Handa <handa@m17n.org>
1305
1306 * lisp.h (uniprop_table): Extern it.
1307
1308 * chartab.c (uniprop_table): Make it non-static.
1309
1310 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1311
1312 * xdisp.c (forward_to_next_line_start): Accept additional argument
1313 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1314 on the newline.
1315 (reseat_at_next_visible_line_start): Use the bidi iterator state
1316 returned by forward_to_next_line_start to restore the state of
1317 it->bidi_it after backing up to previous newline. (Bug#9212)
1318
1319 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1320
1321 * regex.c (re_comp): Protoize.
1322 (re_exec): Fix return type.
1323 (regexec): Fix type of `ret'. (Bug#9203)
1324
1325 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1326
1327 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1328 This is needed if max-image-size is a floating-point number.
1329
1330 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1331
1332 * print.c (print_object): Print empty symbol as ##.
1333
1334 * lread.c (read1): Read ## as empty symbol.
1335
1336 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1337
1338 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1339 setting frame foreground color (Bug#9175).
1340 (x_set_background_color): Likewise.
1341
1342 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1343 contents (Bug#9176).
1344 (EmacsTooltip -init): Remove bezels and add shadows to
1345 tooltip windows.
1346
1347 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1348 or scroll bar (Bug#8470).
1349
1350 * nsfont.m (nsfont_open): Remove assignment to voffset and
1351 unnecessary vars hshink, expand, hd, full_height, min_height.
1352 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1353
1354 * nsterm.h (nsfont_info): Remove voffset field.
1355
1356 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1357
1358 Implement strike-through and overline on NextStep (Bug#8863).
1359
1360 * nsfont.m (nsfont_open): Use underline position provided by font,
1361 instead of hard-coded value of 2.
1362 (nsfont_draw): Call ns_draw_text_decoration instead.
1363
1364 * nsterm.h: Add declaration for ns_draw_text_decoration.
1365
1366 * nsterm.m (ns_draw_text_decoration): New function for drawing
1367 underline, overline, and strike-through.
1368 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1369 ns_draw_text_decoration. Change treatment of cursor drawing to
1370 accommodate underlining, etc.
1371
1372 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1373
1374 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1375 default.
1376
1377 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1378
1379 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1380 Without this fix, if a signal arrives just after memory fills up,
1381 'malloc' might be invoked reentrantly.
1382
1383 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1384 In other words, assume that every image size is allowed, on non-X
1385 hosts. This assumption is probably wrong, but it lets Emacs compile.
1386
1387 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1388
1389 * regex.c (re_iswctype): Convert return values to boolean.
1390
1391 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1392
1393 * xdisp.c (compute_display_string_pos): Don't use cached display
1394 string position if the buffer had its restriction changed.
1395 (Bug#9184)
1396
1397 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1398
1399 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1400
1401 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1402
1403 Integer signedness and overflow and related fixes. (Bug#9079)
1404
1405 * bidi.c: Integer size and overflow fixes.
1406 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1407 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1408 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1409 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1410 (bidi_find_other_level_edge):
1411 Use ptrdiff_t instead of EMACS_INT where either will do.
1412 This works better on 32-bit hosts configured --with-wide-int.
1413 (bidi_cache_ensure_space): Check for size-calculation overflow.
1414 Use % rather than repeated addition, for better worst-case speed.
1415 Don't set bidi_cache_size until after xrealloc returns, because it
1416 might not return.
1417 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1418 (bidi_cache_ensure_space): Also check that the bidi cache size
1419 does not exceed that of the largest Lisp string or buffer. See Eli
1420 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1421
1422 * alloc.c (__malloc_size_t): Remove.
1423 All uses replaced by size_t. See Andreas Schwab's note
1424 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1425
1426 * image.c: Improve checking for integer overflow.
1427 (check_image_size): Assume that f is nonnull, since
1428 it is always nonnull in practice. This is one less thing to
1429 worry about when checking for integer overflow later.
1430 (x_check_image_size): New function, which checks for integer
1431 overflow issues inside X.
1432 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1433 This removes the need for a memory_full check.
1434 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1435 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1436 (xbm_read_bitmap_data): Change locals back to 'int', since
1437 their values must fit in 'int'.
1438 (xpm_load_image, png_load, tiff_load):
1439 Invoke x_create_x_image_and_pixmap earlier,
1440 to avoid much needless work if the image is too large.
1441 (tiff_load): Treat overly large images as if
1442 x_create_x_image_and_pixmap failed, not as malloc failures.
1443 (gs_load): Use x_check_image_size.
1444
1445 * gtkutil.c: Omit integer casts.
1446 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1447 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1448
1449 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1450
1451 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1452 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1453 would wrongly return t on a 64-bit host.
1454
1455 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1456 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1457 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1458 and therefore cause GCC to emit a bogus diagnostic in some cases.
1459
1460 * image.c: Integer signedness and overflow and related fixes.
1461 This is not an exhaustive set of fixes, but it's time to
1462 record what I've got.
1463 (lookup_pixel_color, check_image_size): Remove redundant decls.
1464 (check_image_size): Don't assume that arbitrary EMACS_INT values
1465 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1466 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1467 (tiff_load, imagemagick_load_image):
1468 Check for overflow in size calculations.
1469 (x_create_x_image_and_pixmap): Remove unnecessary test for
1470 xmalloc returning NULL; that can't happen.
1471 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1472 (xpm_color_bucket): Use better integer hashing function.
1473 (xpm_cache_color): Don't possibly over-allocate memory.
1474 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1475 (gif_memory_source):
1476 Use ptrdiff_t, not int or size_t, to record sizes.
1477 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1478 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1479 either works, as we prefer signed integers.
1480 (tiff_read_from_memory, tiff_write_from_memory):
1481 Return tsize_t, not size_t, since that's what the TIFF API wants.
1482 (tiff_read_from_memory): Don't fail simply because the read would
1483 go past EOF; instead, return a short read.
1484 (tiff_load): Omit no-longer-needed casts.
1485 (Fimagemagick_types): Don't assume size fits into 'int'.
1486
1487 Improve hashing quality when configured --with-wide-int.
1488 * fns.c (hash_string): New function, taken from sxhash_string.
1489 Do not discard information about ASCII character case; this
1490 discarding is no longer needed.
1491 (sxhash-string): Use it. Change sig to match it. Caller changed.
1492 * lisp.h: Declare it.
1493 * lread.c (hash_string): Remove, since we now use fns.c's version.
1494 The fns.c version returns a wider integer if --with-wide-int is
1495 specified, so this should help the quality of the hashing a bit.
1496
1497 * emacs.c: Integer overflow minor fix.
1498 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1499 Define only if GNU_LINUX.
1500 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1501
1502 * dispnew.c: Integer signedness and overflow fixes.
1503 Remove unnecessary forward decls, that were a maintenance hassle.
1504 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1505 All uses changed.
1506 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1507 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1508 (prepare_desired_row, line_draw_cost):
1509 Use int, not unsigned, where either works.
1510 (save_current_matrix, restore_current_matrix):
1511 Use ptrdiff_t, not size_t, where either works.
1512 (init_display): Check for overflow more accurately, and without
1513 relying on undefined behavior.
1514
1515 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1516 Remove, replacing with the new symbols in lisp.h. All uses changed.
1517 * fileio.c (make_temp_name):
1518 * filelock.c (lock_file_1, lock_file):
1519 * xdisp.c (message_dolog):
1520 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1521 Use pMd etc. instead.
1522 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1523 replacing the pWIDE etc. symbols removed from editfns.c.
1524
1525 * keyboard.h (num_input_events): Now uintmax_t.
1526 This is (very slightly) less likely to mess up due to wraparound.
1527 All uses changed.
1528
1529 * buffer.c: Integer signedness fixes.
1530 (alloc_buffer_text, enlarge_buffer_text):
1531 Use ptrdiff_t rather than size_t when either will do, as we prefer
1532 signed integers.
1533
1534 * alloc.c: Integer signedness and overflow fixes.
1535 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1536 (__malloc_size_t): Default to size_t, not to int.
1537 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1538 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1539 Prefer ptrdiff_t to size_t when either would do, as we prefer
1540 signed integers.
1541 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1542 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1543 Now const. Initialize with values that are in range even if char
1544 is signed.
1545 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1546 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1547 These functions do the right thing with sizes > 2**32.
1548 (check_depth): Now ptrdiff_t, not int.
1549 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1550 Adjust to new way of storing sizes. Check for size overflow bugs
1551 in rest of code.
1552 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1553 slightly wrong anyway, as it missed one instance of
1554 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1555 (refill_memory_reserve): Omit needless cast to size_t.
1556 (mark_object_loop_halt): Mark as externally visible.
1557
1558 * xselect.c: Integer signedness and overflow fixes.
1559 (Fx_register_dnd_atom, x_handle_dnd_message):
1560 Use ptrdiff_t, not size_t, since we prefer signed.
1561 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1562 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1563 x_dnd_atoms_size and x_dnd_atoms_length.
1564
1565 * doprnt.c: Prefer signed to unsigned when either works.
1566 * eval.c (verror):
1567 * doprnt.c (doprnt):
1568 * lisp.h (doprnt):
1569 * xdisp.c (vmessage):
1570 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1571 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1572 prefer signed arithmetic to avoid comparison confusion.
1573 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1574 but is a bit tricky.
1575
1576 Assume freestanding C89 headers, string.h, stdlib.h.
1577 * data.c, doprnt.c, floatfns.c, print.c:
1578 Include float.h unconditionally.
1579 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1580 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1581 * regex.c: Likewise for stddef.h, string.h.
1582 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1583 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1584 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1585 (STDC_HEADERS): Remove obsolete defines.
1586 * sysdep.c: Include limits.h unconditionally.
1587
1588 Assume support for memcmp, memcpy, memmove, memset.
1589 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1590 * regex.c (memcmp, memcpy):
1591 Remove; we assume C89 now.
1592
1593 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1594 (__malloc_safe_bcopy): Remove; no longer needed.
1595
1596 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1597 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1598 well either way, and we prefer signed to unsigned.
1599
1600 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1601
1602 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1603 closes the connection while we're reading (bug#9182).
1604
1605 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1606
1607 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1608 are specified (Bug#9168).
1609
1610 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1611
1612 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1613 Found by GCC static checking and --with-wide-int on a 32-bit host.
1614
1615 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1616
1617 * xdisp.c (compute_display_string_pos): Fix logic of caching
1618 previous display string position. Initialize cached_prev_pos to
1619 -1. Fixes slow-down at the beginning of a buffer.
1620
1621 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1622
1623 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1624 for attrs[LFACE_FONTSET_INDEX].
1625
1626 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1627
1628 * xml.c (parse_region): Remove unused local
1629 that was recently introduced.
1630
1631 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1632
1633 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1634 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1635
1636 * xdisp.c (move_it_in_display_line_to): Record the best matching
1637 position for TO_CHARPOS while scanning the line, and restore it on
1638 exit if none of the characters scanned was an exact match.
1639 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1640 when exact match is impossible due to invisible text, and the
1641 lines are truncated.
1642
1643 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1644
1645 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1646 for OSX >= 10.7.
1647
1648 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1649
1650 Fix a significant slow-down of cursor motion with C-n, C-p,
1651 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1652 auto-repeat under bidi redisplay in fontified buffers.
1653 * xdisp.c (compute_stop_pos_backwards): New function.
1654 (next_element_from_buffer): Call compute_stop_pos_backwards to
1655 find a suitable prev_stop when we find ourselves before
1656 base_level_stop.
1657 (reseat): Don't look for prev_stop, as that could mean a very long
1658 run.
1659 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1660 <cached_disp_overlay_modiff>: Cache for last found display string
1661 position.
1662 (compute_display_string_pos): Return the cached position if asked
1663 about the same buffer in the same area of character positions, and
1664 the buffer wasn't changed since the time the display string
1665 position was cached.
1666
1667 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1668
1669 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1670 is an integer, which is important for empty lines. (Bug#9149)
1671
1672 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1673
1674 * frame.c (Fmodify_frame_parameters): In tty case, update the
1675 default face if necessary (Bug#4238).
1676
1677 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1678
1679 * editfns.c (Fstring_to_char): No need to explain what a character
1680 is in the docstring (Bug#6576).
1681
1682 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1683
1684 * xml.c (parse_region): Make sure we always return a tree.
1685
1686 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1687
1688 * xml.c (parse_region): If a document contains only comments,
1689 return that, too.
1690
1691 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1692
1693 * xml.c (make_dom): Return comments, too.
1694
1695 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1696
1697 Port to OpenBSD.
1698 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1699 and the surrounding thread.
1700 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1701 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1702 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1703 timer goes off.
1704 * s/openbsd.h (BROKEN_SIGIO): Define.
1705 * unexelf.c (unexec) [__OpenBSD__]:
1706 Don't update the .mdebug section of the Alpha COFF symbol table.
1707
1708 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1709
1710 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1711 (bug#8460).
1712
1713 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1714
1715 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1716 This fixes some race conditions on the permissions of any newly
1717 created file.
1718
1719 * alloc.c (valid_pointer_p): Use pipe, not open.
1720 This fixes some permissions issues when debugging.
1721
1722 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1723 If fchown fails to set both uid and gid, try to set just gid,
1724 as that is sometimes allowed. Adjust the file's mode to eliminate
1725 setuid or setgid bits that are inappropriate if fchown fails.
1726
1727 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1728
1729 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1730 to compare Lisp_Objects.
1731 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1732 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1733 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1734
1735 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1736
1737 * lread.c (read_integer): Unread even EOF character.
1738 (read1): Likewise. Properly record start position of symbol.
1739
1740 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1741 symbol character follows.
1742
1743 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1744
1745 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1746 This works around a problem with the previous change to Fcopy_file.
1747 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1748 and without this change, GCC might complain about discarding
1749 fchown's return value.
1750
1751 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1752
1753 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1754
1755 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1756
1757 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1758
1759 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1760
1761 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1762 it's used from the C level.
1763
1764 * process.c: Use the same condition for POLL_FOR_INPUT in both
1765 keyboard.c and process.c (bug#1858).
1766
1767 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1768
1769 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1770 (Fgnutls_boot): Use it.
1771
1772 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1773
1774 * doc.c (Fsubstitute_command_keys): Revert last change.
1775
1776 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1777
1778 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1779 quotes the next character, and doesn't affect other longer
1780 sequences (bug#8935).
1781
1782 * lread.c (syms_of_lread): Clarify that is isn't only
1783 `eval-buffer' and `eval-defun' that's affected by
1784 `lexical-binding' (bug#8460).
1785
1786 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1787
1788 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1789 bidi redisplay when a line includes both an image and is
1790 truncated.
1791
1792 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1793
1794 Fix minor problems found by static checking.
1795 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1796 (elsz): Now a signed constant, not a size_t var. We prefer signed
1797 types to unsigned, to avoid integer comparison confusion. Without
1798 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1799 "cannot optimize loop, the loop counter may overflow", a symptom
1800 of the confusion.
1801 * indent.c (Fvertical_motion): Mark locals as initialized.
1802 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1803
1804 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1805
1806 * search.c (Fre_search_backward): Mention `case-fold-search' in
1807 all the re_search_* functions (bug#8138).
1808
1809 * keyboard.c (Fopen_dribble_file): Document when the file is
1810 closed (bug#8056).
1811
1812 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1813
1814 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1815 bidi_cache_idx.
1816
1817 Support bidi reordering of display and overlay strings.
1818 * xdisp.c (compute_display_string_pos)
1819 (compute_display_string_end): Accept additional argument STRING.
1820 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1821 (reseat_to_string): Initialize bidi_it->string.s and
1822 bidi_it->string.schars.
1823 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1824 NULL (avoids a crash in bidi_paragraph_init).
1825 Initialize itb.string.lstring.
1826 (init_iterator): Call bidi_init_it only of a valid
1827 buffer position was specified. Initialize paragraph_embedding to
1828 L2R.
1829 (reseat_to_string): Initialize the bidi iterator.
1830 (display_string): If we need to ignore text properties of
1831 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1832 original value of -1 will not work with bidi.)
1833 (compute_display_string_pos): First arg is now struct
1834 `text_pos *'; all callers changed. Support display properties on
1835 Lisp strings.
1836 (compute_display_string_end): Support display properties on Lisp
1837 strings.
1838 (init_iterator, reseat_1, reseat_to_string): Initialize the
1839 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1840 when iterating on a string not from display properties).
1841 (compute_display_string_pos, compute_display_string_end):
1842 Fix calculation of the object to scan. Fixes an error when using
1843 arrow keys.
1844 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1845 base_level_stop; instead, set base_level_stop to BEGV.
1846 Fixes crashes in vertical-motion.
1847 (next_element_from_buffer): Improve commentary for when
1848 the iterator is before prev_stop.
1849 (init_iterator): Initialize bidi_p from the default value of
1850 bidi-display-reordering, not from buffer-local value. Use the
1851 buffer-local value only if initializing for buffer iteration.
1852 (handle_invisible_prop): Support invisible properties on strings
1853 that are being bidi-reordered.
1854 (set_iterator_to_next): Support bidi reordering of C strings and
1855 Lisp strings.
1856 (next_element_from_string): Support bidi reordering of Lisp
1857 strings.
1858 (handle_stop_backwards): Support Lisp strings as well.
1859 (display_string): Support display of R2L glyph rows.
1860 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1861 (init_iterator): Don't initialize it->bidi_p for strings
1862 here.
1863 (reseat_to_string): Initialize it->bidi_p for strings here.
1864 (next_element_from_string, next_element_from_c_string)
1865 (next_element_from_buffer): Add xassert's for correspondence
1866 between IT's object being iterated and it->bidi_it.string
1867 structure.
1868 (face_before_or_after_it_pos): Support bidi iteration.
1869 (next_element_from_c_string): Handle the case of the first string
1870 character that is not the first one in the visual order.
1871 (get_visually_first_element): New function, refactored from common
1872 parts of next_element_from_buffer, next_element_from_string, and
1873 next_element_from_c_string.
1874 (tool_bar_lines_needed, redisplay_tool_bar)
1875 (display_menu_bar): Force left-to-right direction. Add a FIXME
1876 comment for making that be controlled by a user option.
1877 (push_it, pop_it): Save and restore the state of the
1878 bidi iterator. Save and restore the bidi_p flag.
1879 (pop_it): Iterate out of display property for string iteration as
1880 well.
1881 (iterate_out_of_display_property): Support iteration over strings.
1882 (handle_single_display_spec): Set up it->bidi_it for iteration
1883 over a display string, and call bidi_init_it.
1884 (handle_single_display_spec, next_overlay_string)
1885 (get_overlay_strings_1, push_display_prop): Set up the bidi
1886 iterator for displaying display or overlay strings.
1887 (forward_to_next_line_start): Don't use the shortcut if
1888 bidi-iterating.
1889 (back_to_previous_visible_line_start): If handle_display_prop
1890 pushed the iterator stack, restore the internal state of the bidi
1891 iterator by calling bidi_pop_it same number of times.
1892 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1893 and we are bidi-iterating, don't decrement the iterator position;
1894 instead, set the first_elt flag in the bidi iterator, to produce
1895 the same effect.
1896 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1897 (push_display_prop): xassert that we are iterating a buffer.
1898 (push_it, pop_it): Save and restore paragraph_embedding member.
1899 (handle_single_display_spec, next_overlay_string)
1900 (get_overlay_strings_1, reseat_1, reseat_to_string)
1901 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1902 correctly. Don't assume unibyte strings are not bidi-reordered.
1903 (compute_display_string_pos)
1904 (compute_display_string_end): Fix handling the case of C string.
1905 (push_it, pop_it): Save and restore from_disp_prop_p.
1906 (handle_single_display_spec, push_display_prop): Set the
1907 from_disp_prop_p flag.
1908 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1909 (pop_it): Call iterate_out_of_display_property only if we are
1910 popping after iteration over a string that came from a display
1911 property. Fix a typo in popping stretch info. Add an assertion
1912 for verifying that the iterator position is in sync with the bidi
1913 iterator.
1914 (handle_single_display_spec, get_overlay_strings_1)
1915 (push_display_prop): Fix initialization of paragraph direction for
1916 string when that of the parent object is not yet determined.
1917 (reseat_1): Call bidi_init_it to resync the bidi
1918 iterator with IT's position. (Bug#7616)
1919 (find_row_edges): If ROW->start.pos gives position
1920 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1921 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1922 Reset the from_disp_prop_p flag.
1923 (SAVE_IT, RESTORE_IT): New macros.
1924 (pos_visible_p, face_before_or_after_it_pos)
1925 (back_to_previous_visible_line_start)
1926 (move_it_in_display_line_to, move_it_in_display_line)
1927 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1928 (try_scrolling, redisplay_window, display_line): Use them when
1929 saving a temporary copy of the iterator and restoring it back.
1930 (back_to_previous_visible_line_start, reseat_1)
1931 (init_iterator): Empty the bidi cache "stack".
1932 (move_it_in_display_line_to): If iterator ended up at
1933 EOL, but we never saw any buffer positions smaller than
1934 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1935 motion in bidi-reordered lines.
1936 (move_it_in_display_line_to): Record prev_method and prev_pos
1937 immediately before the call to set_iterator_to_next. Fixes cursor
1938 motion in bidi-reordered lines with stretch glyphs and strings
1939 displayed in margins. (Bug#8133) (Bug#8867)
1940 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1941 TO_CHARPOS.
1942 (pos_visible_p): Support positions in bidi-reordered lines.
1943 Save and restore bidi cache.
1944
1945 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1946 (bidi_paragraph_info): Delete unused struct.
1947 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1948 (bidi_cache_start): New variable.
1949 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1950 to zero.
1951 (bidi_cache_fetch_state, bidi_cache_search)
1952 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1953 (bidi_cache_find, bidi_peek_at_next_level)
1954 (bidi_level_of_next_char, bidi_find_other_level_edge)
1955 (bidi_move_to_visually_next): Compare cache index with
1956 bidi_cache_start rather than with zero.
1957 (bidi_fetch_char): Accept new argument STRING; all callers
1958 changed. Support iteration over a string. Support strings with
1959 display properties. Support unibyte strings. Fix the type of
1960 `len' according to what STRING_CHAR_AND_LENGTH expects.
1961 (bidi_paragraph_init, bidi_resolve_explicit_1)
1962 (bidi_resolve_explicit, bidi_resolve_weak)
1963 (bidi_level_of_next_char, bidi_move_to_visually_next):
1964 Support iteration over a string.
1965 (bidi_set_sor_type, bidi_resolve_explicit_1)
1966 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1967 can now be zero (for strings); special values 0 and -1 were
1968 changed to -1 and -2, respectively.
1969 (bidi_char_at_pos): New function.
1970 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1971 Call it instead of FETCH_MULTIBYTE_CHAR.
1972 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1973 initialized to valid values.
1974 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1975 values.
1976 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1977 the test for valid cached positions. Fix the logic for looking up
1978 the sentinel state in the cache. GCPRO the Lisp string we are
1979 iterating.
1980 (bidi_push_it, bidi_pop_it): New functions.
1981 (bidi_initialize): Initialize the bidi cache start stack pointer.
1982 (bidi_cache_ensure_space): New function, refactored from part of
1983 bidi_cache_iterator_state. Don't assume the required size is just
1984 one BIDI_CACHE_CHUNK away.
1985 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1986 (bidi_count_bytes, bidi_char_at_pos): New functions.
1987 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1988 always valid if bidi_cache_idx is valid.
1989 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1990 is valid if it's going to be used.
1991 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1992 (bidi_cache_fetch_state, bidi_cache_search)
1993 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1994 (bidi_cache_iterator_state, bidi_cache_find)
1995 (bidi_find_other_level_edge, bidi_cache_start_stack):
1996 All variables related to cache indices are now EMACS_INT.
1997
1998 * dispextern.h (struct bidi_string_data): New structure.
1999 (struct bidi_it): New member `string'. Make flag members be 1-bit
2000 fields, and put them last in the struct.
2001 (compute_display_string_pos, compute_display_string_end):
2002 Update prototypes.
2003 (bidi_push_it, bidi_pop_it): Add prototypes.
2004 (struct iterator_stack_entry): New members bidi_p,
2005 paragraph_embedding, and from_disp_prop_p.
2006 (struct it): Member bidi_p is now a bit field 1 bit wide.
2007 (bidi_shelve_cache, bidi_unshelve_cache):
2008 Declare prototypes.
2009
2010 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2011 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2012 and vector-like objects.
2013
2014 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2015 cache around display iteration.
2016
2017 * window.c (Fwindow_end, window_scroll_pixel_based)
2018 (displayed_window_lines, Frecenter): Save and restore the bidi
2019 cache around display iteration.
2020
2021 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2022
2023 * editfns.c (Fdelete_region): Clarify the use of the named
2024 parameters (bug#6788).
2025
2026 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2027
2028 * indent.c (Fvertical_motion): Set and restore w->pointm when
2029 saving and restoring the window's buffer (Bug#9006).
2030
2031 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2032
2033 * editfns.c (Fstring_to_char): Clarify just what is returned
2034 (bug#6576). Text by Eli Zaretskii.
2035
2036 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2037
2038 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2039
2040 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2041
2042 * buffer.c (mmap_find): Fix a typo.
2043
2044 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2045
2046 Fix execution of x selection hooks.
2047 * xselect.c (Qx_lost_selection_functions)
2048 (Qx_sent_selection_functions): New vars.
2049 (syms_of_xselect): DEFSYM them.
2050 (x_handle_selection_request): Pass Qx_sent_selection_functions
2051 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2052 (x_handle_selection_clear,x_clear_frame_selections):
2053 Pass Qx_lost_selection_functions rather than
2054 Vx_lost_selection_functions to Frun_hook_with_args.
2055
2056 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2057
2058 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2059 The old code sometimes used this field without initializing it.
2060
2061 * alloc.c (gc_sweep): Don't read past end of array.
2062 In theory, the old code could also have corrupted Emacs internals,
2063 though it'd be very unlikely.
2064
2065 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2066
2067 * character.c (Fcharacterp): Don't advertise optional ignored
2068 argument. (Bug#4026)
2069
2070 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2071
2072 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2073 key" (bug#4257).
2074
2075 * window.c (Fset_window_start): Doc fix (bug#4199).
2076 (Fset_window_hscroll): Ditto.
2077
2078 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2079
2080 Fix minor new problems caught by GCC 4.6.1.
2081 * term.c (init_tty): Remove unused local.
2082 * xsettings.c (store_monospaced_changed): Define this function only
2083 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2084 not used otherwise.
2085
2086 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2087
2088 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2089
2090 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2091
2092 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2093 are the mini-buffer and the echo area (bug#3320).
2094
2095 * term.c (init_tty): Remove support for supdup, c10 and perq
2096 terminals, which are no longer supported (bug#1482).
2097
2098 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2099
2100 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2101
2102 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2103
2104 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2105 for non-popups (Bug#3642).
2106
2107 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2108
2109 * alloc.c (reset_malloc_hooks): Protoize.
2110 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2111 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2112 * cm.c (losecursor): Likewise.
2113 * data.c (fmod): Likewise.
2114 * dispnew.c (swap_glyphs_in_rows): Likewise.
2115 * emacs.c (memory_warning_signal): Likewise.
2116 * floatfns.c (float_error): Likewise.
2117 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2118 (otf_open, font_otf_capability, generate_otf_features)
2119 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2120 Likewise.
2121 * image.c (pbm_read_file): Likewise.
2122 * indent.c (string_display_width): Likewise.
2123 * intervals.c (check_for_interval, search_for_interval)
2124 (inc_interval_count, count_intervals, root_interval)
2125 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2126 * lread.c (defalias): Likewise.
2127 * ralloc.c (r_alloc_check): Likewise.
2128 * regex.c (set_image_of_range_1, set_image_of_range)
2129 (regex_grow_registers): Likewise.
2130 * sysdep.c (strerror): Likewise.
2131 * termcap.c (valid_filename_p, tprint, main): Likewise.
2132 * tparam.c (main): Likewise.
2133 * unexhp9k800.c (run_time_remap, save_data_space)
2134 (update_file_ptrs, read_header, write_header, calculate_checksum)
2135 (copy_file, copy_rest, display_header): Likewise.
2136 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2137 Likewise.
2138 * xdisp.c (check_it): Likewise.
2139 * xfaces.c (register_color, unregister_color, unregister_colors):
2140 Likewise.
2141 * xfns.c (print_fontset_result): Likewise.
2142 * xrdb.c (member, fatal, main): Likewise.
2143
2144 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2145
2146 Fix minor problems found by static checking (Bug#9031).
2147 * chartab.c (char_table_set_range, map_sub_char_table):
2148 Remove unused locals.
2149 (uniprop_table): Now static.
2150 * composite.c (_work_char): Remove unused static var.
2151
2152 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2153
2154 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2155
2156 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2157
2158 * gtkutil.c (qttip_cb): Remove code without function.
2159
2160 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2161
2162 * w32.c (pthread_sigmask): New stub.
2163
2164 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2165
2166 Use pthread_sigmask, not sigprocmask (Bug#9010).
2167 sigprocmask is portable only for single-threaded applications, and
2168 Emacs can be multi-threaded when it uses GTK.
2169 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2170 (LIBES): Use it.
2171 * callproc.c (Fcall_process):
2172 * process.c (create_process):
2173 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2174 Use pthread_sigmask, not sigprocmask.
2175
2176 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2177
2178 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2179 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2180 wrong (Bug#8591).
2181
2182 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2183
2184 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2185 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2186 (xg_hide_tooltip): Fix comment.
2187
2188 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2189 in registerServicesMenuSendTypes.
2190 (validRequestorForSendType): Don't check ns_return_types.
2191
2192 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2193 ns_return_type.
2194
2195 2011-07-08 Jason Rumney <jasonr@gnu.org>
2196
2197 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2198 frame struct members of non-existent frames (Bug#6284).
2199
2200 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2201
2202 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2203 variable firstTime not needed on OSX >= 10.6.
2204 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2205 >= 10.5. Use setKnobProportion, setDoubleValue.
2206
2207 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2208 (MAC_OS_X_VERSION_10_5): Define if not defined.
2209 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2210 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2211 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2212
2213 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2214 cString and lossyCString on OSX >= 10.4
2215
2216 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2217 sizeToFit on OSX >= 10.2.
2218
2219 * nsimage.m (allocInitFromFile): Don't use deprecated method
2220 bestRepresentationForDevice on OSX >= 10.6.
2221
2222 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2223 to avoid warning.
2224
2225 * emacs.c: Declare unexec_init_emacs_zone.
2226
2227 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2228
2229 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2230
2231 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2232 on svcsMenu (Bug#8842).
2233
2234 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2235 ns_return_types.
2236 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2237
2238 * nsterm.m (QUTF8_STRING): Declare.
2239 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2240 (validRequestorForSendType): Return type is (id).
2241 Change indexOfObjectIdenticalTo to indexOfObject.
2242 Check if we have local selection before returning self (Bug#8842).
2243 (writeSelectionToPasteboard): Put local selection into paste board
2244 if we have a local selection (Bug#8842).
2245 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2246
2247 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2248 (ns_get_local_selection): Declare.
2249
2250 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2251
2252 * keymap.c (describe_map_tree): Don't insert a double newline at
2253 the end of the buffer (bug#1169) and return whether we inserted
2254 something.
2255
2256 * callint.c (Fcall_interactively): Change "reading args" to
2257 "providing args" to try to clarify what it does (bug#1010).
2258
2259 2011-07-07 Kenichi Handa <handa@m17n.org>
2260
2261 * composite.c (composition_compute_stop_pos): Ignore a static
2262 composition starting before CHARPOS (Bug#8915).
2263
2264 * xdisp.c (handle_composition_prop): Likewise.
2265
2266 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2267
2268 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2269 (Bug#9015)
2270
2271 2011-07-07 Kenichi Handa <handa@m17n.org>
2272
2273 * character.h (unicode_category_t): New enum type.
2274
2275 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2276 (Qchar_code_property_table): New variable.
2277 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2278 (UNIPROP_COMPRESSED_FORM_P): New macros.
2279 (char_table_ascii): Uncompress the compressed values.
2280 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2281 Uncompress the compressed values.
2282 (sub_char_table_ref_and_range): Likewise.
2283 (char_table_ref_and_range): Uncompress the compressed values.
2284 (sub_char_table_set): New arg is_uniprop. Callers changed.
2285 Uncompress the compressed values.
2286 (sub_char_table_set_range): Args changed. Callers changed.
2287 (char_table_set_range): Adjuted for the above change.
2288 (map_sub_char_table): Delete args default_val and parent. Add arg
2289 top. Give decoded values to a Lisp function.
2290 (map_char_table): Adjust for the above change. Give decoded
2291 values to a Lisp function. Gcpro more variables.
2292 (uniprop_table_uncompress)
2293 (uniprop_decode_value_run_length): New functions.
2294 (uniprop_decoder, uniprop_decoder_count): New variables.
2295 (uniprop_get_decoder, uniprop_encode_value_character)
2296 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2297 New functions.
2298 (uniprop_encoder, uniprop_encoder_count): New variables.
2299 (uniprop_get_encoder, uniprop_table)
2300 (Funicode_property_table_internal, Fget_unicode_property_internal)
2301 (Fput_unicode_property_internal): New functions.
2302 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2303 Sunicode_property_table_internal, Sget_unicode_property_internal,
2304 and Sput_unicode_property_internal. Defvar_lisp
2305 char-code-property-alist.
2306
2307 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2308 Vunicode_category_table.
2309
2310 * font.c (font_range): Adjust for the change of
2311 Vunicode_category_table.
2312
2313 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2314
2315 * m/iris4d.h: Remove file, move contents ...
2316 * s/irix6-5.h: ... here.
2317
2318 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2319
2320 Remove unportable assumption about struct layout (Bug#8884).
2321 * alloc.c (mark_buffer):
2322 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2323 (clone_per_buffer_values): Don't assume that
2324 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2325 This isn't true in general, and it's particularly not true
2326 if Emacs is configured with --with-wide-int.
2327 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2328 New macros, used in the buffer.c change.
2329
2330 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2331
2332 * xsettings.c: Use both GConf and GSettings if both are available.
2333 (store_config_changed_event): Add comment.
2334 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2335 (store_tool_bar_style_changed): New functions.
2336 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2337 (struct xsettings): Move font inside HAVE_XFT.
2338 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2339 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2340 Move inside HAVE_XFT.
2341 (something_changed_gsettingsCB): Rename from something_changedCB.
2342 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2343 also.
2344 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2345 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2346 (something_changed_gconfCB): Rename from something_changedCB.
2347 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2348 (parse_settings): Move check for font inside HAVE_XFT.
2349 (read_settings, apply_xft_settings): Add comment.
2350 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2351 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2352 call store_font_name_changed.
2353 (xft_settings_event): Add comment.
2354 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2355 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2356 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2357 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2358 (xsettings_initialize): Call init_gsettings last.
2359 (xsettings_get_system_font, xsettings_get_system_normal_font):
2360 Add comment.
2361
2362 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2363
2364 Random fixes. E.g., (random) never returned negative values.
2365 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2366 subseconds part to the entropy, as that's a bit more random.
2367 Prefer signed to unsigned, since the signedness doesn't matter and
2368 in general we prefer signed. When given a limit, use a
2369 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2370 latter isn't right if USE_2_TAGS_FOR_INTS.
2371 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2372 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2373
2374 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2375
2376 * textprop.c (text_property_stickiness):
2377 Obey Vtext_property_default_nonsticky.
2378 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2379 * w32fns.c (syms_of_w32fns):
2380 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2381
2382 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2383
2384 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2385 This is more efficient than Ffile_directory_p and avoids a minor race.
2386
2387 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2388
2389 * buffer.c (Foverlay_put): Say what the return value is
2390 (bug#7835).
2391
2392 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2393 is a directory before asking whether to use the file name
2394 (bug#7564).
2395 (barf_or_query_if_file_exists): Make the "File is a directory"
2396 error be more correct.
2397
2398 * fns.c (Frequire): Remove the mention of the .gz files, since
2399 that's installation-specific, but keep the mention of
2400 `get-load-suffixes'.
2401
2402 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2403
2404 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2405 Report string overflow if the output is too long.
2406
2407 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2408
2409 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2410 (syms_of_gnutls): Remove duplicate DEFSYM for
2411 Qgnutls_bootprop_verify_hostname_error, an error for
2412 Qgnutls_bootprop_verify_error (which is no longer used).
2413
2414 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2415 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2416 Also (re)move comments that are misplaced or no longer relevant.
2417
2418 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2419
2420 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2421
2422 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2423
2424 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2425 and background color parameters if they have been changed.
2426
2427 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2428
2429 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2430
2431 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2432
2433 * xsettings.c (SYSTEM_FONT): Define only when used.
2434 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2435
2436 * keymap.c (access_keymap_1): Now static.
2437
2438 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2439
2440 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2441 leave any prefix arg for the up event (Bug#1586).
2442
2443 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2444
2445 * lread.c (syms_of_lread): Mention single symbols defined by
2446 `defvar' or `defconst' (bug#7154).
2447
2448 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2449 (Frequire): Mention get-load-suffixes.
2450
2451 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2452
2453 * window.h (window): Remove clone_number slot.
2454 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2455 Remove.
2456 (make_parent_window, make_window, saved_window)
2457 (Fset_window_configuration, save_window_save): Don't deal with
2458 clone numbers.
2459 * buffer.c (Qclone_number): Remove declaration.
2460 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2461
2462 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2463
2464 Add multiple inheritance to keymaps.
2465 * keymap.c (Fmake_composed_keymap): New function.
2466 (Fset_keymap_parent): Simplify.
2467 (fix_submap_inheritance): Remove.
2468 (access_keymap_1): New function extracted from access_keymap to handle
2469 embedded parents and handle lists of maps.
2470 (access_keymap): Use it.
2471 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2472 (Fcopy_keymap): Handle embedded parents.
2473 (Fcommand_remapping, define_as_prefix): Simplify.
2474 (Fkey_binding): Simplify.
2475 (syms_of_keymap): Move minibuffer-local-completion-map,
2476 minibuffer-local-filename-completion-map,
2477 minibuffer-local-must-match-map, and
2478 minibuffer-local-filename-must-match-map to Elisp.
2479 (syms_of_keymap): Defsubr make-composed-keymap.
2480 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2481 (parse_menu_item): Trivial simplification.
2482
2483 2011-07-01 Glenn Morris <rgm@gnu.org>
2484
2485 * Makefile.in (SETTINGS_LIBS): Fix typo.
2486
2487 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2488
2489 * coding.c (Fencode_coding_string): Record the last coding system
2490 used, as the function doc string says (bug#8738).
2491
2492 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2493
2494 * xsettings.c (store_monospaced_changed): Take new font as arg and
2495 check for change against current_mono_font.
2496 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2497 (emacs_settings_constructor, emacs_settings_get_property)
2498 (emacs_settings_set_property, emacs_settings_class_init)
2499 (emacs_settings_init, gsettings_obj): Remove.
2500 (something_changedCB): New function for HAVE_GSETTINGS.
2501 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2502 with value as argument.
2503 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2504 g_settings_new (Bug#8967). Do not create gsettings_obj.
2505 Remove calls to g_settings_bind. Connect something_changedCB to
2506 "changed".
2507
2508 * xgselect.c: Add defined (HAVE_GSETTINGS).
2509 (xgselect_initialize): Ditto.
2510
2511 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2512 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2513 xg_select.
2514
2515 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2516
2517 * eval.c (struct backtrace): Simplify and port the data structure.
2518 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2519 signed bit field, as this assumption is not portable and it makes
2520 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2521 "char debug_on_exit : 1" as this is not portable either; instead,
2522 use the portable "unsigned int debug_on_exit : 1". Remove unused
2523 member evalargs. Remove obsolete comments about cc bombing out.
2524
2525 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2526
2527 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2528 Let HAVE_GSETTINGS override HAVE_GCONF.
2529 (store_monospaced_changed): New function.
2530 (EMACS_SETTINGS): A new type derived from GObject to handle
2531 GSettings notifications.
2532 (emacs_settings_constructor, emacs_settings_get_property)
2533 (emacs_settings_set_property, emacs_settings_class_init):
2534 New functions.
2535 (gsettings_client, gsettings_obj): New variables.
2536 (GSETTINGS_SCHEMA): New define.
2537 (something_changedCB): Call store_monospaced_changed.
2538 (init_gsettings): New function.
2539 (xsettings_initialize): Call init_gsettings.
2540 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2541 to NULL.
2542
2543 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2544 GCONF_CFLAGS/LIBS.
2545
2546 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2547
2548 * window.c (resize_root_window, grow_mini_window)
2549 (shrink_mini_window): Rename Qresize_root_window to
2550 Qwindow_resize_root_window and Qresize_root_window_vertically to
2551 Qwindow_resize_root_window_vertically.
2552
2553 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2554
2555 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2556
2557 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2558
2559 * makefile.w32-in: Redesign dependencies so they reflect more
2560 clearly which files are directly included by each source file,
2561 and not through other includes.
2562
2563 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2564
2565 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2566 (sort_overlays, overlay_strings): When an overlay's clone number
2567 matches the window's clone number process the overlay even if
2568 the overlay's window property doesn't match the current window.
2569
2570 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2571 (Fwindow_hchild): Rename to Fwindow_left_child.
2572 (Fwindow_next): Rename to Fwindow_next_sibling.
2573 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2574 (resize_window_check): Rename to window_resize_check.
2575 (resize_window_apply): Rename to window_resize_apply.
2576 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2577 (Fdelete_other_windows_internal, resize_frame_windows)
2578 (Fsplit_window_internal, Fdelete_window_internal)
2579 (grow_mini_window, shrink_mini_window)
2580 (Fresize_mini_window_internal): Fix callers accordingly.
2581
2582 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2583
2584 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2585 (emacs_fixed_set_min_size): Remove.
2586 (emacs_fixed_new): Take frame as argument.
2587
2588 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2589 (_EmacsFixedPrivate): Remove minwidth/height.
2590 Add struct frame *f.
2591 (emacs_fixed_init): Initialize priv->f.
2592 (get_parent_class, emacs_fixed_set_min_size): Remove.
2593 (emacs_fixed_new): Set priv->f to argument.
2594 (emacs_fixed_get_preferred_width)
2595 (emacs_fixed_get_preferred_height): Use min_width/height from
2596 frames size_hint to set minimum and natural (Bug#8919).
2597 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2598 and use min_width/height from frames size_hint to set
2599 min_width/height (Bug#8919).
2600
2601 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2602 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2603 Fix indentation.
2604
2605 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2606
2607 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2608 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2609 called at ZV.
2610
2611 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2612
2613 * process.c (wait_reading_process_output): Bypass select if
2614 waiting for a cell while ignoring keyboard input, and input is
2615 pending. Suggested by Jan Djärv (Bug#8869).
2616
2617 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2618
2619 Use gnulib's dup2 module instead of rolling our own.
2620 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2621
2622 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2623
2624 * dispnew.c (scrolling_window): Before scrolling, turn off a
2625 mouse-highlight in the window being scrolled.
2626
2627 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2628
2629 Move DEFSYM to lisp.h and use everywhere.
2630
2631 * character.h (DEFSYM): Move declaration...
2632 * lisp.h (DEFSYM): ...here.
2633
2634 * gnutls.c:
2635 * minibuf.c:
2636 * w32menu.c:
2637 * w32proc.c:
2638 * w32select.c: Don't include character.h.
2639
2640 * alloc.c (syms_of_alloc):
2641 * buffer.c (syms_of_buffer):
2642 * bytecode.c (syms_of_bytecode):
2643 * callint.c (syms_of_callint):
2644 * casefiddle.c (syms_of_casefiddle):
2645 * casetab.c (init_casetab_once):
2646 * category.c (init_category_once, syms_of_category):
2647 * ccl.c (syms_of_ccl):
2648 * cmds.c (syms_of_cmds):
2649 * composite.c (syms_of_composite):
2650 * dbusbind.c (syms_of_dbusbind):
2651 * dired.c (syms_of_dired):
2652 * dispnew.c (syms_of_display):
2653 * doc.c (syms_of_doc):
2654 * editfns.c (syms_of_editfns):
2655 * emacs.c (syms_of_emacs):
2656 * eval.c (syms_of_eval):
2657 * fileio.c (syms_of_fileio):
2658 * fns.c (syms_of_fns):
2659 * frame.c (syms_of_frame):
2660 * fringe.c (syms_of_fringe):
2661 * insdel.c (syms_of_insdel):
2662 * keymap.c (syms_of_keymap):
2663 * lread.c (init_obarray, syms_of_lread):
2664 * macros.c (syms_of_macros):
2665 * msdos.c (syms_of_msdos):
2666 * print.c (syms_of_print):
2667 * process.c (syms_of_process):
2668 * search.c (syms_of_search):
2669 * sound.c (syms_of_sound):
2670 * syntax.c (init_syntax_once, syms_of_syntax):
2671 * terminal.c (syms_of_terminal):
2672 * textprop.c (syms_of_textprop):
2673 * undo.c (syms_of_undo):
2674 * w32.c (globals_of_w32):
2675 * window.c (syms_of_window):
2676 * xdisp.c (syms_of_xdisp):
2677 * xfaces.c (syms_of_xfaces):
2678 * xfns.c (syms_of_xfns):
2679 * xmenu.c (syms_of_xmenu):
2680 * xsettings.c (syms_of_xsettings):
2681 * xterm.c (syms_of_xterm): Use DEFSYM.
2682
2683 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2684
2685 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2686
2687 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2688
2689 Integer and buffer overflow fixes (Bug#8873).
2690
2691 * print.c (printchar, strout): Check for string overflow.
2692 (PRINTPREPARE, printchar, strout):
2693 Don't set size unless allocation succeeds.
2694
2695 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2696 for sizes. Check for string overflow more accurately.
2697 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2698
2699 * macros.c: Integer and buffer overflow fixes.
2700 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2701 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2702 Use ptrdiff_t, not int, for sizes.
2703 Don't increment bufsize until after realloc succeeds.
2704 Check for size-calculation overflow.
2705 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2706
2707 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2708
2709 * lread.c: Integer overflow fixes.
2710 (read_integer): Radix is now EMACS_INT, not int,
2711 to improve quality of diagnostics for out-of-range radices.
2712 Calculate buffer size correctly for out-of-range radices.
2713 (read1): Check for integer overflow in radices, and in
2714 read-circle numbers.
2715 (read_escape): Avoid int overflow.
2716 (Fload, openp, read_buffer_size, read1)
2717 (substitute_object_recurse, read_vector, read_list, map_obarray):
2718 Use ptrdiff_t, not int, for sizes.
2719 (read1): Use EMACS_INT, not int, for sizes.
2720 Check for size overflow.
2721
2722 * image.c (cache_image): Check for size arithmetic overflow.
2723
2724 * lread.c: Integer overflow issues.
2725 (saved_doc_string_size, saved_doc_string_length)
2726 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2727 Now ptrdiff_t, not int.
2728 (read1): Don't assume doc string length fits in int. Check for
2729 out-of-range doc string lengths.
2730 (read_list): Don't assume file position fits in int.
2731 (read_escape): Check for hex character overflow.
2732
2733 2011-06-22 Leo Liu <sdl.web@gmail.com>
2734
2735 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2736 Move to minibuffer.el.
2737
2738 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2739
2740 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2741 The following patches are for when GLYPH_DEBUG && !XASSERT.
2742 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2743 * dispnew.c (flush_stdout):
2744 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2745 Mark as externally visible.
2746 * dispnew.c (check_window_matrix_pointers): Now static.
2747 * dispnew.c (window_to_frame_vpos):
2748 * xfns.c (unwind_create_frame):
2749 * xterm.c (x_check_font): Remove unused local.
2750 * scroll.c (CHECK_BOUNDS):
2751 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2752 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2753 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2754 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2755 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2756 Now static.
2757 (debug_method_add): Use va_list and vsprintf rather than relying
2758 on undefined behavior with wrong number of arguments.
2759 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2760 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2761 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2762 since we're not interested in debugging glyphs with old libraries.
2763 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2764 GCC 4.6.0's static checking.
2765
2766 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2767
2768 Integer overflow and signedness fixes (Bug#8873).
2769 A few related buffer overrun fixes, too.
2770
2771 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2772
2773 * dispextern.h (struct face.stipple):
2774 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2775 (x_bitmap_mask, x_allocate_bitmap_record)
2776 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2777 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2778 (x_create_bitmap_from_xpm_data):
2779 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2780 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2781 (.bitmaps_last):
2782 * xfaces.c (load_pixmap):
2783 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2784 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2785 (.bitmaps_last, struct x_output.icon_bitmap):
2786 Use ptrdiff_t, not int, for bitmap indexes.
2787 (x_allocate_bitmap_record): Check for size overflow.
2788 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2789
2790 Use ptrdiff_t, not int, for overlay counts.
2791 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2792 * editfns.c (overlays_around, get_pos_property):
2793 * textprop.c (get_char_property_and_overlay):
2794 * xdisp.c (next_overlay_change, note_mouse_highlight):
2795 * xfaces.c (face_at_buffer_position):
2796 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2797 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2798 (Fnext_overlay_change, Fprevious_overlay_change)
2799 (mouse_face_overlay_overlaps, Foverlays_in):
2800 Use ptrdiff_t, not int, for sizes.
2801 (overlays_at, overlays_in): Check for size-calculation overflow.
2802
2803 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2804
2805 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2806 (x_session_initialize): Do not assume string length fits in int.
2807
2808 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2809 This is unlikely, but can occur if DPI is outlandish.
2810
2811 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2812 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2813
2814 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2815 * xrdb.c (magic_file_p, search_magic_path):
2816 Omit last arg SUFFIX; it was always 0. All callers changed.
2817 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2818
2819 * xfont.c (xfont_match): Avoid need for strlen.
2820
2821 * xfns.c: Don't assume strlen fits in int.
2822 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2823
2824 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2825 not unsigned long, as we prefer signed integers. All callers changed.
2826 Detect integer overflow in repeat count.
2827 (message_dolog): Don't assume print length fits in 39 bytes.
2828 (display_mode_element): Don't assume strlen fits in int.
2829
2830 * termcap.c: Don't assume sizes fit in int and never overflow.
2831 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2832 (gobble_line): Check for size-calculation overflow.
2833
2834 * minibuf.c (Fread_buffer):
2835 * lread.c (intern, intern_c_string):
2836 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2837 Don't assume string length fits in int.
2838
2839 * keyboard.c (parse_tool_bar_item):
2840 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2841
2842 * font.c: Don't assume string length fits in int.
2843 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2844 Use ptrdiff_t, not int.
2845 (font_intern_prop): Don't assume string length fits in int.
2846 Don't assume integer property fits in fixnum.
2847 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2848
2849 * filelock.c: Fix some buffer overrun and integer overflow issues.
2850 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2851 Reformulate so as not to need the command string.
2852 Invoke gzip -cd rather than gunzip, as it's more portable.
2853 (lock_info_type, lock_file_1, lock_file):
2854 Don't assume pid_t and time_t fit in unsigned long.
2855 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2856 (current_lock_owner): Prefer signed type for sizes.
2857 Use memcpy, not strncpy, where memcpy is what is really wanted.
2858 Don't assume (via atoi) that time_t and pid_t fit in int.
2859 Check for time_t and/or pid_t out of range, e.g., via a network share.
2860 Don't alloca where an auto var works fine.
2861
2862 * fileio.c: Fix some integer overflow issues.
2863 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2864 Don't assume string length fits in int.
2865 (directory_file_name): Don't assume string length fits in long.
2866 (make_temp_name): Don't assume pid fits in int, or that its print
2867 length is less than 20.
2868
2869 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2870
2871 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2872
2873 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2874
2875 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2876 We prefer signed integers, even for size calculations.
2877
2878 * emacs.c: Don't assume string length fits in 'int'.
2879 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2880 (main): Don't invoke strlen when not needed.
2881
2882 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2883 (XD_DEBUG_MESSAGE): Don't waste a byte.
2884
2885 * callproc.c (getenv_internal_1, getenv_internal)
2886 (Fgetenv_internal):
2887 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2888
2889 * lread.c (invalid_syntax): Omit length argument.
2890 All uses changed. This doesn't fix a bug, but it simplifies the
2891 code away from its former Hollerith-constant appearance, and it's
2892 one less 'int' to worry about when looking at integer-overflow issues.
2893 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2894
2895 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2896 This didn't break anything, but it didn't help either.
2897 It's confusing to put a bogus integer in a place where the actual
2898 value does not matter.
2899 (LIST_END_P): Remove unused macro and its bogus comment.
2900 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2901
2902 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2903 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2904 implementation.
2905 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2906 We prefer signed types, and the value cannot exceed the EMACS_INT
2907 range anyway (because otherwise the length would not be representable).
2908 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2909 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2910 This avoids a GCC warning when WIDE_EMACS_INT.
2911
2912 * indent.c (sane_tab_width): New function.
2913 (current_column, scan_for_column, Findent_to, position_indentation)
2914 (compute_motion): Use it. This is just for clarity.
2915 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2916
2917 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2918
2919 * lisp.h (lint_assume): New macro.
2920 * composite.c (composition_gstring_put_cache):
2921 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2922
2923 * editfns.c, insdel.c:
2924 Omit unnecessary forward decls, to simplify future changes.
2925
2926 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2927
2928 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2929
2930 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2931 Use much-faster test for byte-length change.
2932 Don't assume string byte-length fits in 'int'.
2933 Check that character arg fits in 'int'.
2934 (mapcar1): Declare byte as byte, for clarity.
2935
2936 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2937
2938 * fns.c (concat): Catch string overflow earlier.
2939 Do not rely on integer wraparound.
2940
2941 * dispextern.h (struct it.overlay_strings_charpos)
2942 (struct it.selective): Now EMACS_INT, not int.
2943 * xdisp.c (forward_to_next_line_start)
2944 (back_to_previous_visible_line_start)
2945 (reseat_at_next_visible_line_start, next_element_from_buffer):
2946 Don't arbitrarily truncate the value of 'selective' to int.
2947
2948 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2949
2950 * composite.c: Don't truncate sizes to 'int'.
2951 (composition_gstring_p, composition_reseat_it)
2952 (composition_adjust_point): Use EMACS_INT, not int.
2953 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2954 not EMACS_UINT, for indexes.
2955
2956 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2957
2958 * buffer.c: Include <verify.h>.
2959 (struct sortvec.priority, struct sortstr.priority):
2960 Now EMACS_INT, not int.
2961 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2962 (struct sortstr.size, record_overlay_string)
2963 (struct sortstrlist.size, struct sortlist.used):
2964 Don't truncate size to int.
2965 (record_overlay_string): Check for size-calculation overflow.
2966 (init_buffer_once): Check at compile-time, not run-time.
2967
2968 2011-06-22 Jim Meyering <meyering@redhat.com>
2969
2970 Don't leak an XBM-image-sized buffer
2971 * image.c (xbm_load): Free the image buffer after using it.
2972
2973 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2974
2975 Port to Sun C.
2976 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2977 that Sun C diagnosed.
2978 * fns.c (secure_hash): Fix pointer signedness issue.
2979 * intervals.c (static_offset_intervals): New function.
2980 (offset_intervals): Use it.
2981
2982 2011-06-21 Leo Liu <sdl.web@gmail.com>
2983
2984 * deps.mk (fns.o):
2985 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2986 sha512.h.
2987
2988 * fns.c (secure_hash): Rename from crypto_hash_function and change
2989 the first arg to accept symbols.
2990 (Fsecure_hash): New primitive.
2991 (syms_of_fns): New symbols.
2992
2993 2011-06-20 Deniz Dogan <deniz@dogan.se>
2994
2995 * process.c (Fset_process_buffer): Clarify return value in
2996 docstring.
2997
2998 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2999
3000 * dispnew.c (add_window_display_history): Use BVAR.
3001
3002 * xdisp.c (debug_method_add): Use BVAR.
3003 (check_window_end, dump_glyph_matrix, dump_glyph)
3004 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3005
3006 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3007 Likewise.
3008
3009 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3010 check till after the cache is created in init_frame_faces.
3011
3012 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3013
3014 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3015
3016 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3017
3018 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3019 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3020 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3021
3022 Improve buffer-overflow checking (Bug#8873).
3023 * fileio.c (Finsert_file_contents):
3024 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3025 Remove the old (too-loose) buffer overflow checks.
3026 They weren't needed, since make_gap checks for buffer overflow.
3027 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3028 The old code merely checked for Emacs fixnum overflow, and relied
3029 on undefined (wraparound) behavior. The new code avoids undefined
3030 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3031
3032 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3033 Tune. Don't use wider integers than needed. Don't use alloca.
3034 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3035
3036 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3037
3038 * insdel.c, lisp.h (buffer_overflow): New function.
3039 (insert_from_buffer_1, replace_range, replace_range_2):
3040 * insdel.c (make_gap_larger):
3041 * editfns.c (Finsert_char):
3042 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3043
3044 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3045
3046 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3047
3048 Integer overflow and signedness fixes (Bug#8873).
3049
3050 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3051 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3052
3053 * fileio.c: Don't assume EMACS_INT fits in off_t.
3054 (emacs_lseek): New static function.
3055 (Finsert_file_contents, Fwrite_region): Use it.
3056 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3057
3058 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3059
3060 * fns.c: Don't overflow int when computing a list length.
3061 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3062 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3063 truncation on 64-bit hosts. Check for QUIT every
3064 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3065 faster and is responsive enough.
3066 (Flength): Report an error instead of overflowing an integer.
3067 (Fsafe_length): Return a float if the value is not representable
3068 as a fixnum. This shouldn't happen except in contrived situations.
3069 (Fnthcdr, Fsort): Don't assume list length fits in int.
3070 (Fcopy_sequence): Don't assume vector length fits in int.
3071
3072 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3073 (header_size, word_size): New constants.
3074 (allocate_vectorlike): Don't check size overflow here.
3075 (allocate_vector): Check it here instead, since this is the only
3076 caller of allocate_vectorlike that could cause overflow.
3077 Check that the new vector's length is representable as a fixnum.
3078
3079 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3080 The previous code was bogus. For example, next_almost_prime (32)
3081 returned 39, which is undesirable as it is a multiple of 3; and
3082 next_almost_prime (24) returned 25, which is a multiple of 5 so
3083 why was the code bothering to check for multiples of 7?
3084
3085 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3086
3087 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3088
3089 Variadic C functions now count arguments with ptrdiff_t.
3090 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3091 Back then I didn't know that the Emacs coding style prefers signed int.
3092 Also, in the meantime I found a few more instances where arguments
3093 were being counted with int, which may truncate counts on 64-bit
3094 machines, or EMACS_INT, which may be unnecessarily wide.
3095 * lisp.h (struct Lisp_Subr.function.aMANY)
3096 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3097 Arg counts are now ptrdiff_t, not size_t.
3098 All variadic functions and their callers changed accordingly.
3099 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3100 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3101 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3102 * callint.c (Fcall_interactively): Check arg count for overflow,
3103 to avoid potential buffer overrun. Use signed char, not 'int',
3104 for 'varies' array, so that we needn't bother to check its size
3105 calculation for overflow.
3106 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3107 * eval.c (apply_lambda):
3108 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3109 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3110 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3111
3112 * callint.c (Fcall_interactively): Don't use index var as event count.
3113
3114 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3115 * mem-limits.h (SIZE): Remove; no longer used.
3116
3117 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3118
3119 Remove unnecessary casts.
3120 * xterm.c (x_term_init):
3121 * xfns.c (x_set_border_pixel):
3122 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3123 These aren't needed now that we assume ANSI C.
3124
3125 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3126 It's more likely to cause problems (due to unsigned overflow)
3127 than to cure them.
3128
3129 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3130
3131 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3132
3133 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3134
3135 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3136
3137 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3138
3139 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3140
3141 GLYPH_CODE_FACE returns EMACS_INT, not int.
3142 * dispextern.h (merge_faces):
3143 * xfaces.c (merge_faces):
3144 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3145 Don't assume EMACS_INT fits in int.
3146
3147 * character.h (CHAR_VALID_P): Remove unused parameter.
3148 * fontset.c, lisp.h, xdisp.c: All uses changed.
3149
3150 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3151
3152 * fns.c (concat): Minor tuning based on overflow analysis.
3153 This doesn't fix any bugs. Use int to hold character, instead
3154 of constantly refetching from Emacs object. Use XFASTINT, not
3155 XINT, for value known to be a character. Don't bother comparing
3156 a single byte to 0400, as it's always less.
3157
3158 * floatfns.c (Fexpt):
3159 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3160
3161 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3162 for characters.
3163
3164 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3165
3166 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3167 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3168 incorrectly succeed when S was a string, because 4294967386 was
3169 truncated before it was used.
3170
3171 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3172 Otherwise, an out-of-range integer could cause undefined behavior
3173 on a 64-bit host.
3174
3175 * composite.c: Use int, not EMACS_INT, for characters.
3176 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3177 EMACS_INT, for values that are known to be in character range.
3178 This doesn't fix any bugs but is the usual style inside Emacs and
3179 may generate better code on 32-bit machines.
3180
3181 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3182 This is for reasons similar to the recent CHAR_STRING fix.
3183 * charset.c (Fencode_char): Check that character arg is actually
3184 a character. Pass an int to ENCODE_CHAR.
3185 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3186 wider than 'int', as a compile-time check to prevent future regressions
3187 in this area.
3188
3189 * character.c (char_string): Remove unnecessary casts.
3190
3191 Make sure a 64-bit char is never passed to CHAR_STRING.
3192 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3193 by silently ignoring the top 32 bits, allowing some values
3194 that were far too large to be valid characters.
3195 * character.h: Include <verify.h>.
3196 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3197 arguments are no wider than unsigned, as a compile-time check
3198 to prevent future regressions in this area.
3199 * data.c (Faset):
3200 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3201 (Fsubst_char_in_region):
3202 * fns.c (concat):
3203 * xdisp.c (decode_mode_spec_coding):
3204 Adjust to CHAR_STRING's new requirement.
3205 * editfns.c (Finsert_char, Fsubst_char_in_region):
3206 * fns.c (concat): Check that character args are actually
3207 characters. Without this test, these functions did the wrong
3208 thing with wildly out-of-range values on 64-bit hosts.
3209
3210 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3211 These casts should not be needed on 32-bit hosts, either.
3212 * keyboard.c (read_char):
3213 * lread.c (Fload): Remove casts to unsigned.
3214
3215 * lisp.h (UNSIGNED_CMP): New macro.
3216 This fixes comparison bugs on 64-bit hosts.
3217 (ASCII_CHAR_P): Use it.
3218 * casefiddle.c (casify_object):
3219 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3220 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3221 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3222 * dispextern.h (FACE_FROM_ID):
3223 * keyboard.c (read_char): Use UNSIGNED_CMP.
3224
3225 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3226 not to EMACS_INT, to avoid GCC warning.
3227
3228 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3229
3230 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3231 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3232 isn't needed on 32-bit machines.
3233
3234 * buffer.c (Fgenerate_new_buffer_name):
3235 Use EMACS_INT for count, not int.
3236 (advance_to_char_boundary): Return EMACS_INT, not int.
3237
3238 * data.c (Qcompiled_function): Now static.
3239
3240 * window.c (window_body_lines): Now static.
3241
3242 * image.c (gif_load): Rename local to avoid shadowing.
3243
3244 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3245 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3246 * alloc.c (make_save_value): Integer argument is now of type
3247 ptrdiff_t, not int.
3248 (mark_object): Use ptrdiff_t, not int.
3249 * lisp.h (pD): New macro.
3250 * print.c (print_object): Use it.
3251
3252 * alloc.c: Use EMACS_INT, not int, to count objects.
3253 (total_conses, total_markers, total_symbols, total_vector_size)
3254 (total_free_conses, total_free_markers, total_free_symbols)
3255 (total_free_floats, total_floats, total_free_intervals)
3256 (total_intervals, total_strings, total_free_strings):
3257 Now EMACS_INT, not int. All uses changed.
3258 (Fgarbage_collect): Compute overall total using a double, so that
3259 integer overflow is less likely to be a problem. Check for overflow
3260 when converting back to an integer.
3261 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3262 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3263 These were 'int' variables that could overflow on 64-bit hosts;
3264 they were never used, so remove them instead of repairing them.
3265 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3266 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3267 Previously, this ceilinged at INT_MAX, but that doesn't work on
3268 64-bit machines.
3269 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3270
3271 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3272 (allocate_vectorlike): Check for ptrdiff_t overflow.
3273 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3274 when a (possibly-narrower) signed value would do just as well.
3275 We prefer using signed arithmetic, to avoid comparison confusion.
3276
3277 * alloc.c: Catch some string size overflows that we were missing.
3278 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3279 for convenience in STRING_BYTES_MAX.
3280 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3281 The definition here is exact; the one in lisp.h was approximate.
3282 (allocate_string_data): Check for string overflow. This catches
3283 some instances we weren't catching before. Also, it catches
3284 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3285 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3286 and ptrdiff_t and EMACS_INT are both 64 bits.
3287
3288 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3289 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3290 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3291
3292 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3293
3294 * alloc.c (Fmake_string): Check for out-of-range init.
3295
3296 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3297
3298 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3299
3300 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3301
3302 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3303 xg_get_default_scrollbar_width.
3304
3305 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3306 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3307 (style_changed_cb): Call update_theme_scrollbar_width and call
3308 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3309 all frames (Bug#8505).
3310 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3311 Call gtk_window_set_resizable if HAVE_GTK3.
3312 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3313 and height if HAVE_GTK3 (Bug#8505).
3314 (scroll_bar_width_for_theme): New variable.
3315 (update_theme_scrollbar_width): New function.
3316 (xg_get_default_scrollbar_width): Move code to
3317 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3318 (xg_initialize): Call update_theme_scrollbar_width.
3319
3320 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3321
3322 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3323
3324 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3325
3326 * frame.c (make_frame): Call other_buffer_safely instead of
3327 other_buffer.
3328
3329 * window.c (temp_output_buffer_show): Call display_buffer with
3330 second argument Vtemp_buffer_show_specifiers and reset latter
3331 immediately after the call.
3332 (Vtemp_buffer_show_specifiers): New variable.
3333 (auto_window_vscroll_p, next_screen_context_lines)
3334 (Vscroll_preserve_screen_position): Remove leading asterisks from
3335 doc-strings.
3336
3337 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3338
3339 Fix minor problems found by GCC 4.6.0 static checking.
3340 * buffer.c (Qclone_number): Remove for now, as it's unused.
3341 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3342 (record_buffer): Remove unused local.
3343 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3344 (set_frame_buffer_list): Remove; unused.
3345 * frame.h (other_visible_frames): Remove decl.
3346 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3347 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3348 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3349 if HAVE_GPM.
3350 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3351 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3352 Define only if HAVE_GPM.
3353 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3354 (update_hints_inhibit): Remove; never set. All uses removed.
3355 * widgetprv.h (emacsFrameClassRec): Remove decl.
3356 * window.c (delete_deletable_window): Now returns void, since it
3357 wasn't returning anything.
3358 (compare_window_configurations): Remove unused locals.
3359 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3360 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3361 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3362 the same widths as pointers. This follows up on the 2011-05-06 patch.
3363 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3364 * xterm.h: Likewise.
3365 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3366
3367 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3368
3369 * makefile.w32-in: Update dependencies.
3370 (LISP_H): Add lib/intprops.h.
3371
3372 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3373
3374 * image.c (gif_load): Add animation frame delay to the metadata.
3375 (syms_of_image): Use DEFSYM. New symbol `delay'.
3376
3377 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3378
3379 * window.c (delete_deletable_window): Re-add.
3380 (Fset_window_configuration): Rewrite to handle dead buffers and
3381 consequently deletable windows.
3382 (window_tree, Fwindow_tree): Remove. Supply functionality in
3383 window.el.
3384 (compare_window_configurations): Simplify code.
3385
3386 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3387
3388 * image.c (imagemagick_load_image): Fix type mismatch.
3389 (Fimagemagick_types): Likewise.
3390
3391 * window.h (replace_buffer_in_windows): Declare.
3392
3393 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3394
3395 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3396 Qclone_number. Remove external declaration of Qdelete_window.
3397 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3398 code.
3399 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3400 Run Qbuffer_list_update_hook if allowed.
3401 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3402 buffer list implementation.
3403 (other_buffer_safely): New function.
3404 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3405 calls to replace_buffer_in_windows and
3406 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3407 if allowed.
3408 (record_buffer): Inhibit quitting and rewrite using quittable
3409 functions. Run Qbuffer_list_update_hook if allowed.
3410 (Frecord_buffer, Funrecord_buffer): New functions.
3411 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3412 Move switch-to-buffer to window.el.
3413 (bury-buffer): Move to window.el.
3414 (Vbuffer_list_update_hook): New variable.
3415
3416 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3417 section.
3418
3419 * window.h (resize_frame_windows): Move up in code.
3420 (Fwindow_frame): Remove EXFUN.
3421 (replace_buffer_in_all_windows): Remove prototype.
3422 (replace_buffer_in_windows_safely): Add prototype.
3423
3424 * window.c: Declare Qdelete_window static again. Move down
3425 declaration of select_count.
3426 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3427 (Fother_window): Move to window.el.
3428 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3429 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3430 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3431 window.el.
3432 (replace_buffer_in_windows): Implement by calling
3433 Qreplace_buffer_in_windows.
3434 (replace_buffer_in_all_windows): Remove with some functionality
3435 moved into replace_buffer_in_windows_safely.
3436 (replace_buffer_in_windows_safely): New function.
3437 (select_window_norecord, select_frame_norecord): Move in front
3438 of run_window_configuration_change_hook. Remove now obsolete
3439 declarations.
3440 (Fset_window_buffer): Rewrite doc-string.
3441 Call Qrecord_window_buffer.
3442 (keys_of_window): Move binding for other-window to window.el.
3443
3444 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3445
3446 * dispextern.h (struct image): Replace data member, whose int_val
3447 and ptr_val fields were not used by anything, with a single
3448 lisp_val object.
3449
3450 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3451 (gif_clear_image, gif_load, imagemagick_load_image)
3452 (gs_clear_image, gs_load): Callers changed.
3453
3454 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3455
3456 * buffer.h: Include <time.h>, for time_t.
3457 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3458
3459 Fix minor problems found by static checking.
3460
3461 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3462
3463 Make identifiers static if they are not used in other modules.
3464 * data.c (Qcompiled_function, Qframe, Qvector):
3465 * image.c (QimageMagick, Qsvg):
3466 * minibuf.c (Qmetadata):
3467 * window.c (resize_window_check, resize_root_window): Now static.
3468 * window.h (resize_window_check, resize_root_window): Remove decls.
3469
3470 * window.c (window_deletion_count, delete_deletable_window):
3471 Remove; unused.
3472 (window_body_lines): Now static.
3473 (Fdelete_other_windows_internal): Mark vars as initialized.
3474 Make sure 'resize_failed' is initialized.
3475 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3476 (resize_window_apply): Remove unused local.
3477 * window.h (delete_deletable_window): Remove decl.
3478
3479 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3480 (imagemagick_load_image): Fix pointer signedness problem by changing
3481 last arg from unsigned char * to char *. All uses changed.
3482 Also, fix a local for similar reasons.
3483 Remove unused locals. Remove locals to avoid shadowing.
3484 (fn_rsvg_handle_free): Remove; unused.
3485 (svg_load, svg_load_image): Fix pointer signedness problem.
3486 (imagemagick_load_image): Don't use garbage pointer image_wand.
3487
3488 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3489
3490 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3491
3492 * image.c (gif_load): Fix omitted cast error introduced by
3493 2011-06-06 change.
3494
3495 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3496
3497 * window.h (resize_proportionally, orig_total_lines)
3498 (orig_top_line): Remove from window structure.
3499 (set_window_height, set_window_width, change_window_heights)
3500 (Fdelete_window): Remove prototypes.
3501 (resize_frame_windows): Remove duplicate declaration.
3502
3503 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3504
3505 * window.h (resize_frame_windows, resize_window_check)
3506 (delete_deletable_window, resize_root_window)
3507 (resize_frame_windows): Declare prototypes.
3508
3509 * window.c (resize_window_apply): Make definition be "static" to
3510 match the prototype.
3511
3512 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3513
3514 * window.c: Remove declarations of Qwindow_size_fixed,
3515 window_min_size_1, window_min_size_2, window_min_size,
3516 size_window, window_fixed_size_p, enlarge_window, delete_window.
3517 Remove static from declaration of Qdelete_window, it's
3518 temporarily needed by Fbury_buffer.
3519 (replace_window): Don't assign orig_top_line and
3520 orig_total_lines.
3521 (Fdelete_window, delete_window): Remove. Window deletion is
3522 handled by window.el.
3523 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3524 Replace Fdelete_window calls with calls to Qdelete_window.
3525 (Fdelete_other_windows): Remove. Deleting other windows is
3526 handled by window.el.
3527 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3528 handled in window.el.
3529 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3530 Window minimum sizes are handled in window.el.
3531 (shrink_windows, size_window, set_window_height)
3532 (set_window_width, change_window_heights, window_height)
3533 (window_width, CURBEG, CURSIZE, enlarge_window)
3534 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3535 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3536 handled in window.el.
3537 (make_dummy_parent): Rename to make_parent_window and give it a
3538 second argument horflag.
3539 (make_window): Don't set resize_proportionally any more.
3540 (Fsplit_window): Remove. Windows are split in window.el.
3541 (save_restore_action, save_restore_orig_size)
3542 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3543 Resize mini windows in window.el.
3544 (grow_mini_window, shrink_mini_window): Implement by calling
3545 Qresize_root_window_vertically, resize_window_check and
3546 resize_window_apply.
3547 (saved_window, Fset_window_configuration, save_window_save):
3548 Do not handle orig_top_line, orig_total_lines, and
3549 resize_proportionally.
3550 (window_min_height, window_min_width): Move to window.el.
3551 (keys_of_window): Move bindings for delete-other-windows,
3552 split-window, delete-window and enlarge-window to window.el.
3553
3554 * buffer.c: Temporarily extern Qdelete_window.
3555 (Fbury_buffer): Temporarily call Qdelete_window instead of
3556 Fdelete_window (Fbury_buffer will move to window.el soon).
3557
3558 * frame.c (set_menu_bar_lines_1): Remove code handling
3559 orig_top_line and orig_total_lines.
3560
3561 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3562 set_window_height but set heights directly.
3563 (change_frame_size_1): Use resize_frame_windows.
3564
3565 * xdisp.c (init_xdisp): Don't use set_window_height but set
3566 heights directly.
3567
3568 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3569 Use resize_frame_windows instead of change_window_heights and run
3570 run_window_configuration_change_hook.
3571
3572 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3573 instead of change_window_heights and run
3574 run_window_configuration_change_hook.
3575
3576 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3577
3578 * window.c (replace_window): Rename second argument REPLACEMENT to
3579 NEW. New third argument SETFLAG. Rewrite.
3580 (delete_window, make_dummy_parent): Call replace_window with
3581 third argument 1.
3582 (window_list_1): Move down in code.
3583 (run_window_configuration_change_hook): Move set_buffer part
3584 before select_frame_norecord part in order to unwind correctly.
3585 Rename count1 to count.
3586 (recombine_windows, delete_deletable_window, resize_root_window)
3587 (Fdelete_other_windows_internal)
3588 (Frun_window_configuration_change_hook, make_parent_window)
3589 (resize_window_check, resize_window_apply, Fresize_window_apply)
3590 (resize_frame_windows, Fsplit_window_internal)
3591 (Fdelete_window_internal, Fresize_mini_window_internal):
3592 New functions.
3593 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3594
3595 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3596
3597 * window.h (window): Add some new members to window structure -
3598 normal_lines, normal_cols, new_total, new_normal, clone_number,
3599 splits, nest, prev_buffers, next_buffers.
3600 (WINDOW_TOTAL_SIZE): Move here from window.c.
3601 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3602
3603 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3604 Remove.
3605 (make_dummy_parent): Set new members of windows structure.
3606 (make_window): Move down in code. Handle new members of window
3607 structure.
3608 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3609 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3610 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3611 (Fset_window_prev_buffers, Fwindow_next_buffers)
3612 (Fset_window_next_buffers, Fset_window_clone_number):
3613 New functions.
3614 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3615 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3616 Doc-string fixes.
3617 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3618 Argument WINDOW can be now internal window too.
3619 (Fwindow_use_time): Move up in code.
3620 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3621 Rewrite doc-string.
3622 (Fset_window_configuration, saved_window)
3623 (Fcurrent_window_configuration, save_window_save): Handle new
3624 members of window structure.
3625 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3626 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3627 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3628 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3629 Qget_mru_window, Qresize_root_window,
3630 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3631 Qauto_buffer_name; staticpro them.
3632
3633 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3634
3635 * window.c (Fwindow_total_size, Fwindow_left_column)
3636 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3637 (Fwindow_list_1): New functions.
3638 (window_box_text_cols): Replace with window_body_cols.
3639 (Fwindow_width, Fscroll_left, Fscroll_right):
3640 Use window_body_cols instead of window_box_text_cols.
3641 (delete_window, Fset_window_configuration):
3642 Call delete_all_subwindows with window as argument.
3643 (delete_all_subwindows): Take a window as argument and not a
3644 structure. Rewrite.
3645 (window_loop): Remove handling of GET_LRU_WINDOW and
3646 GET_LARGEST_WINDOW.
3647 (Fget_lru_window, Fget_largest_window): Move to window.el.
3648
3649 * window.h: Extern window_body_cols instead of
3650 window_box_text_cols. delete_all_subwindows now takes a
3651 Lisp_Object as argument.
3652
3653 * indent.c (compute_motion, Fcompute_motion):
3654 Use window_body_cols instead of window_box_text_cols.
3655
3656 * frame.c (delete_frame): Call delete_all_subwindows with root
3657 window as argument.
3658
3659 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3660
3661 * fns.c (Fputhash): Document return value.
3662
3663 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3664
3665 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3666
3667 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3668
3669 Cons<->int and similar integer overflow fixes (Bug#8794).
3670
3671 Check for overflow when converting integer to cons and back.
3672 * charset.c (Fdefine_charset_internal, Fdecode_char):
3673 Use cons_to_unsigned to catch overflow.
3674 (Fencode_char): Use INTEGER_TO_CONS.
3675 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3676 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3677 * data.c (long_to_cons, cons_to_long): Remove.
3678 (cons_to_unsigned, cons_to_signed): New functions.
3679 These signal an error for invalid or out-of-range values.
3680 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3681 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3682 * font.c (Ffont_variation_glyphs):
3683 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3684 * lisp.h: Include <intprops.h>.
3685 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3686 (cons_to_signed, cons_to_unsigned): New decls.
3687 (long_to_cons, cons_to_long): Remove decls.
3688 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3689 (Fprimitive_undo): Use CONS_TO_INTEGER.
3690 * xfns.c (Fx_window_property): Likewise.
3691 * xselect.c: Include <limits.h>.
3692 (x_own_selection, selection_data_to_lisp_data):
3693 Use INTEGER_TO_CONS.
3694 (x_handle_selection_request, x_handle_selection_clear)
3695 (x_get_foreign_selection, Fx_disown_selection_internal)
3696 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3697 (lisp_data_to_selection_data): Use cons_to_unsigned.
3698 (x_fill_property_data): Use cons_to_signed.
3699 Report values out of range.
3700
3701 Check for buffer and string overflow more precisely.
3702 * buffer.h (BUF_BYTES_MAX): New macro.
3703 * lisp.h (STRING_BYTES_MAX): New macro.
3704 * alloc.c (Fmake_string):
3705 * character.c (string_escape_byte8):
3706 * coding.c (coding_alloc_by_realloc):
3707 * doprnt.c (doprnt):
3708 * editfns.c (Fformat):
3709 * eval.c (verror):
3710 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3711 since they may not be the same number.
3712 * editfns.c (Finsert_char):
3713 * fileio.c (Finsert_file_contents):
3714 Likewise for BUF_BYTES_MAX.
3715
3716 * image.c: Use ptrdiff_t, not int, for sizes.
3717 (slurp_file): Switch from int to ptrdiff_t.
3718 All uses changed.
3719 (slurp_file): Check that file size fits in both size_t (for
3720 malloc) and ptrdiff_t (for sanity and safety).
3721
3722 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3723 if b->modtime has its maximal value.
3724
3725 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3726
3727 Don't assume time_t can fit into int.
3728 * buffer.h (struct buffer.modtime): Now time_t, not int.
3729 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3730 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3731
3732 Minor fixes for signed vs unsigned integers.
3733 * character.h (MAYBE_UNIFY_CHAR):
3734 * charset.c (maybe_unify_char):
3735 * keyboard.c (read_char, reorder_modifiers):
3736 XINT -> XFASTINT, since the integer must be nonnegative.
3737 * ftfont.c (ftfont_spec_pattern):
3738 * keymap.c (access_keymap, silly_event_symbol_error):
3739 XUINT -> XFASTINT, since the integer must be nonnegative.
3740 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3741 since it makes no difference and we prefer signed.
3742 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3743 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3744 nonnegative.
3745
3746 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3747
3748 * window.h (Fwindow_frame): Declare.
3749
3750 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3751
3752 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3753 (SPARE_MEMORY): Always define.
3754 (LARGE_REQUEST): Remove.
3755 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3756
3757 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3758
3759 * lisp.h: Move EXFUNS for Fframe_root_window,
3760 Fframe_first_window and Fset_frame_selected_window to window.h.
3761
3762 * window.h: Move EXFUNS for Fframe_root_window,
3763 Fframe_first_window and Fset_frame_selected_window here from
3764 lisp.h.
3765
3766 * frame.c (Fwindow_frame, Fframe_first_window)
3767 (Fframe_root_window, Fframe_selected_window)
3768 (Fset_frame_selected_window): Move to window.c.
3769 (Factive_minibuffer_window): Move to minibuf.c.
3770 (Fother_visible_frames_p): New function.
3771
3772 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3773
3774 * window.c (decode_window, decode_any_window): Move up in code.
3775 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3776 (inhibit_frame_unsplittable): Remove unused variable.
3777 (Fwindow_buffer): Move up and rewrite doc-string.
3778 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3779 (Fwindow_prev): New functions.
3780 (Fwindow_frame): Move here from frame.c. Accept any window as
3781 argument.
3782 (Fframe_root_window, Fframe_first_window)
3783 (Fframe_selected_window): Move here from frame.c. Accept frame
3784 or arbitrary window as argument. Update doc-strings.
3785 (Fminibuffer_window): Move up in code.
3786 (Fwindow_minibuffer_p): Move up in code and simplify.
3787 (Fset_frame_selected_window): Move here from frame.c.
3788 Marginal rewrite.
3789 (Fselected_window, select_window, Fselect_window): Move up in
3790 code. Minor doc-string fixes.
3791
3792 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3793
3794 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3795 Do not assume that spare memory exists; that assumption is valid
3796 only if SYSTEM_MALLOC.
3797 (LARGE_REQUEST): New macro, so that the issue of large requests
3798 is separated from the issue of spare memory.
3799
3800 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3801
3802 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3803 format. (Bug#8806)
3804
3805 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3806
3807 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3808 before statements.
3809
3810 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3811
3812 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3813
3814 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3815
3816 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3817 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3818
3819 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3820
3821 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3822
3823 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3824
3825 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3826 (x_clipboard_manager_save): Add return value.
3827 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3828 New error handlers.
3829 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3830 Obey Vx_select_enable_clipboard_manager. Catch errors in
3831 x_clipboard_manager_save (Bug#8779).
3832 (Vx_select_enable_clipboard_manager): New variable.
3833 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3834
3835 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3836
3837 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3838
3839 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3840
3841 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3842 in the current matrix if keep_current_p is non-zero.
3843
3844 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3845
3846 * bidi.c (bidi_level_of_next_char): Fix last change.
3847
3848 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3849
3850 Support bidi reordering of text covered by display properties.
3851
3852 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3853 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3854 (bidi_cache_search, bidi_cache_iterator_state)
3855 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3856 (bidi_level_of_next_char, bidi_move_to_visually_next):
3857 Support character positions inside a run of characters covered by a
3858 display string.
3859 (bidi_paragraph_init, bidi_resolve_explicit_1)
3860 (bidi_level_of_next_char): Call bidi_fetch_char and
3861 bidi_fetch_char_advance instead of FETCH_CHAR and
3862 FETCH_CHAR_ADVANCE.
3863 (bidi_init_it): Initialize new members.
3864 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3865 definitions.
3866 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3867 instead of using explicit *_CHAR codes.
3868 (bidi_resolve_explicit, bidi_resolve_weak):
3869 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3870 bidirectional text is supported only in multibyte buffers.
3871 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3872 it to initialize the frame_window_p member of struct bidi_it.
3873 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3874 (bidi_resolve_explicit, bidi_resolve_weak)
3875 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3876 bidi_it->nchars is non-positive.
3877 (bidi_level_of_next_char): Don't try to lookup the cache for the
3878 next/previous character if nothing is cached there yet, or if we
3879 were just reseat()'ed to a new position.
3880
3881 * xdisp.c (set_cursor_from_row): Set start and stop points
3882 according to the row's direction when priming the loop that looks
3883 for the glyph on which to display cursor.
3884 (single_display_spec_intangible_p): Function deleted.
3885 (display_prop_intangible_p): Reimplement to call
3886 handle_display_spec instead of single_display_spec_intangible_p.
3887 Accept 3 additional arguments needed by handle_display_spec.
3888 This fixes incorrect cursor motion across display property with complex
3889 values: lists, `(when COND...)' forms, etc.
3890 (single_display_spec_string_p): Support property values that are
3891 lists with the argument STRING its top-level element.
3892 (display_prop_string_p): Fix the condition for processing a
3893 property that is a list to be consistent with handle_display_spec.
3894 (handle_display_spec): New function, refactored from the
3895 last portion of handle_display_prop.
3896 (compute_display_string_pos): Accept additional argument
3897 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3898 value of a `display' property is a "replacing spec".
3899 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3900 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3901 the display property, but just return a value indicating whether
3902 the display property will replace the characters it covers.
3903 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3904 frame_window_p members of struct bidi_it.
3905 (compute_display_string_pos, compute_display_string_end):
3906 New functions.
3907 (push_it): Accept second argument POSITION, where pop_it should
3908 jump to continue iteration.
3909 (reseat_1): Initialize bidi_it.disp_pos.
3910
3911 * keyboard.c (adjust_point_for_property): Adjust the call to
3912 display_prop_intangible_p to its new signature.
3913
3914 * dispextern.h (struct bidi_it): New member frame_window_p.
3915 (bidi_init_it): Update prototypes.
3916 (display_prop_intangible_p): Update prototype.
3917 (compute_display_string_pos, compute_display_string_end):
3918 Declare prototypes.
3919 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3920 EMACS_INT.
3921
3922 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3923
3924 Malloc failure behavior now depends on size of allocation.
3925 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3926 * lisp.h: Change signatures accordingly.
3927 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3928 All callers changed. (Bug#8762)
3929
3930 * gnutls.c: Use Emacs's memory allocators.
3931 Without this change, the gnutls library would invoke malloc etc.
3932 directly, which causes problems on non-SYNC_INPUT hosts, and which
3933 runs afoul of improving memory_full behavior. (Bug#8761)
3934 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3935 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3936 xfree instead of the default malloc, realloc, free.
3937 (Fgnutls_boot): No need to check for memory allocation failure,
3938 since xmalloc does that for us.
3939
3940 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3941 * category.c (hash_get_category_set):
3942 * ccl.c (ccl_driver):
3943 * charset.c (Fdefine_charset_internal):
3944 * charset.h (struct charset.hash_index):
3945 * composite.c (get_composition_id, gstring_lookup_cache)
3946 (composition_gstring_put_cache):
3947 * composite.h (struct composition.hash_index):
3948 * dispextern.h (struct image.hash):
3949 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3950 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3951 (hashfn_equal, hashfn_user_defined, make_hash_table)
3952 (maybe_resize_hash_table, hash_lookup, hash_put)
3953 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3954 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3955 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3956 * image.c (make_image, search_image_cache, lookup_image)
3957 (xpm_put_color_table_h):
3958 * lisp.h (struct Lisp_Hash_Table):
3959 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3960 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3961 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3962 * alloc.c (allocate_vectorlike):
3963 Check for overflow in vector size calculations.
3964 * ccl.c (ccl_driver):
3965 Check for overflow when converting EMACS_INT to int.
3966 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3967 need to be updated by these changes.
3968 * fns.c (make_hash_table, maybe_resize_hash_table):
3969 Check for integer overflow with large hash tables.
3970 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3971 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3972 (SXHASH_REDUCE): New macro.
3973 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3974 Use it instead of discarding useful hash info with large hash values.
3975 (sxhash_float): New function.
3976 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3977 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3978 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3979 Rewrite to use FIXNUM_BITS, as this simplifies things.
3980 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3981 Adjust signatures to match updated version of code.
3982 (consing_since_gc): Now EMACS_INT, since a single hash table can
3983 use more than INT_MAX bytes.
3984
3985 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3986
3987 Make it possible to build with GCC-4.6+ -O2 -flto.
3988
3989 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3990
3991 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3992
3993 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3994 Call minibuffer-inactive-mode.
3995
3996 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3997
3998 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3999 Update dependencies.
4000
4001 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4002
4003 * data.c (init_data): Remove code for UTS, this system is not
4004 supported anymore.
4005
4006 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4007
4008 Don't force ./temacs to start in terminal mode.
4009
4010 * frame.c (make_initial_frame): Initialize faces in all cases, not
4011 only when CANNOT_DUMP is defined.
4012 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4013
4014 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4015
4016 * dispnew.c (add_window_display_history): Use const for the string
4017 pointer. Remove declaration, not needed.
4018
4019 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4020
4021 Use 'inline', not 'INLINE'.
4022 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4023 * alloc.c, fontset.c (INLINE): Remove.
4024 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4025 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4026 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4027 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4028 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4029
4030 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4031
4032 Make it possible to run ./temacs.
4033
4034 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4035 syms_of_callproc does the same thing. Remove test for
4036 "initialized", do it in the caller.
4037 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4038
4039 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4040
4041 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4042 (read_minibuf): Use get_minibuffer.
4043 (syms_of_minibuf): Use DEFSYM.
4044 (Qmetadata): New var.
4045 * data.c (Qbuffer): Don't make it static.
4046 (syms_of_data): Use DEFSYM.
4047
4048 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4049
4050 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4051 (CCL_CODE_MIN): New macro.
4052
4053 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4054
4055 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4056
4057 * eval.c (Qdebug): Now static.
4058 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4059 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4060 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4061
4062 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4063
4064 * image.c: Various fixes to ImageMagick code comments.
4065 (Fimagemagick_types): Doc fix.
4066
4067 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4068
4069 Minor fixes prompted by GCC 4.6.0 warnings.
4070
4071 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4072
4073 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4074 (x_clipboard_manager_save_all): Move extern decl to ...
4075 * xterm.h: ... here, so that it can be checked for consistency.
4076
4077 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4078
4079 * xselect.c (x_clipboard_manager_save_frame)
4080 (x_clipboard_manager_save_all): New functions.
4081 (Fx_clipboard_manager_save): Lisp function deleted.
4082
4083 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4084 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4085
4086 * xterm.h: Update prototype.
4087
4088 2011-05-28 William Xu <william.xwl@gmail.com>
4089
4090 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4091 exiting (Bug#8239).
4092
4093 2011-05-28 Jim Meyering <meyering@redhat.com>
4094
4095 Avoid a sign-extension bug in crypto_hash_function.
4096 * fns.c (to_uchar): Define.
4097 (crypto_hash_function): Use it to convert some newly-signed
4098 variables to unsigned, to avoid sign-extension bugs. For example,
4099 without this change, (md5 "truc") would evaluate to
4100 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4101 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4102 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4103
4104 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4105
4106 Integer overflow fixes.
4107
4108 * dbusbind.c: Serial number integer overflow fixes.
4109 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4110 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4111 to hold a serial number that is too large for a fixnum.
4112 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4113 Check for serial numbers out of range. Decode any serial number
4114 that was so large that it became a float. (Bug#8722)
4115
4116 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4117 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4118 Use XFASTINT rather than XUINT when numbers are nonnegative.
4119 (xd_append_arg, Fdbus_method_return_internal):
4120 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4121 arguments, check that Lisp number is nonnegative, rather than
4122 silently wrapping negative numbers around. (Bug#8722)
4123 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4124 (Bug#8722)
4125
4126 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4127
4128 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4129
4130 ccl: add integer overflow checks
4131 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4132 (IN_INT_RANGE): New macros.
4133 (ccl_driver): Use them to check for integer overflow when
4134 decoding a CCL program. Many of the new checks are whether XINT (x)
4135 fits in int; it doesn't always, on 64-bit hosts. The new version
4136 doesn't catch all possible integer overflows, but it's an
4137 improvement. (Bug#8719)
4138
4139 * alloc.c (make_event_array): Use XINT, not XUINT.
4140 There's no need for unsigned here.
4141
4142 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4143 This follows up to the 2011-05-06 change that substituted uintptr_t
4144 for EMACS_INT. This case wasn't caught back then.
4145
4146 Rework Fformat to avoid integer overflow issues.
4147 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4148 now (part of C89). Include <verify.h>.
4149 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4150 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4151 (Fformat): Avoid the prepass trying to compute sizes; it was only
4152 approximate and thus did not catch overflow reliably. Instead, walk
4153 through the format just once, formatting and computing sizes as we go,
4154 checking for integer overflow at every step, and allocating a larger
4155 buffer as needed. Keep track separately whether the format is
4156 multibyte. Keep only the most-recently calculated precision, rather
4157 than them all. Record whether each argument has been converted to
4158 string. Use EMACS_INT, not int, for byte and char and arg counts.
4159 Support field widths and precisions larger than INT_MAX. Avoid
4160 sprintf's undefined behavior with conversion specifications such as %#d
4161 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4162 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4163 formatting out-of-range floating point numbers with int
4164 formats. (Bug#8668)
4165
4166 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4167
4168 * data.c: Avoid integer truncation in expressions involving floats.
4169 * data.c: Include <intprops.h>.
4170 (arith_driver): When there's an integer overflow in an expression
4171 involving floating point, convert the integers to floating point
4172 so that the resulting value does not suffer from catastrophic
4173 integer truncation. For example, on a 64-bit host (* 4
4174 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4175 Do not rely on undefined behavior after integer overflow.
4176
4177 merge count_size_as_multibyte, parse_str_to_multibyte
4178 * character.c, character.h (count_size_as_multibyte):
4179 Rename from parse_str_to_multibyte; all uses changed.
4180 Check for integer overflow.
4181 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4182 since it's now a duplicate of the other. This is more of
4183 a character than a buffer op, so better that it's in character.c.
4184 * fns.c, print.c: Adjust to above changes.
4185
4186 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4187
4188 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4189
4190 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4191
4192 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4193 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4194 (x_clipboard_manager_save): Now static.
4195 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4196
4197 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4198 (crypto_hash_function): Now static.
4199 Fix pointer signedness problems. Avoid unnecessary initializations.
4200
4201 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4202
4203 * termhooks.h (Vselection_alist): Make it terminal-local.
4204
4205 * terminal.c (create_terminal): Initialize it.
4206
4207 * xselect.c: Support for clipboard managers.
4208 (Vselection_alist): Move to termhooks.h as terminal-local var.
4209 (LOCAL_SELECTION): New macro.
4210 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4211 (symbol_to_x_atom): Remove gratuitous arg.
4212 (x_handle_selection_request, lisp_data_to_selection_data)
4213 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4214 (x_own_selection, x_get_local_selection, x_convert_selection):
4215 New arg, specifying work frame. Use terminal-local Vselection_alist.
4216 (some_frame_on_display): Delete unused function.
4217 (Fx_own_selection_internal, Fx_get_selection_internal)
4218 (Fx_disown_selection_internal, Fx_selection_owner_p)
4219 (Fx_selection_exists_p): New optional frame arg.
4220 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4221 (x_handle_selection_clear): Don't treat other terminals with the
4222 same keyboard specially. Use the terminal-local Vselection_alist.
4223 (x_clear_frame_selections): Use Frun_hook_with_args.
4224
4225 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4226
4227 * xterm.h: Add support for those atoms.
4228
4229 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4230
4231 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4232 (converted_selections, conversion_fail_tag): New global variables.
4233 (x_selection_request_lisp_error): Free the above.
4234 (x_get_local_selection): Remove unnecessary code.
4235 (x_reply_selection_request): Args changed; handle arbitrary array
4236 of converted selections stored in converted_selections.
4237 Separate the XChangeProperty and SelectionNotify steps.
4238 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4239 (x_convert_selection): New function.
4240 (x_handle_selection_event): Simplify.
4241 (x_get_foreign_selection): Don't ignore incoming requests while
4242 waiting for an answer; this will fail when we implement
4243 SAVE_TARGETS, and seems unnecessary anyway.
4244 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4245 (Vx_sent_selection_functions): Doc fix.
4246
4247 2011-05-26 Leo Liu <sdl.web@gmail.com>
4248
4249 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4250
4251 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4252
4253 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4254
4255 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4256 for fringe update if it has periodic bitmap.
4257 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4258 and fringe_bitmap_periodic_p.
4259
4260 * fringe.c (get_fringe_bitmap_data): New function.
4261 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4262 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4263 row. Mark glyph row for fringe update if periodicity changed.
4264
4265 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4266 for fringe update unless it has periodic bitmap.
4267
4268 2011-05-25 Kenichi Handa <handa@m17n.org>
4269
4270 * xdisp.c (get_next_display_element): Set correct it->face_id for
4271 a static composition.
4272
4273 2011-05-24 Leo Liu <sdl.web@gmail.com>
4274
4275 * deps.mk (fns.o):
4276 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4277
4278 * fns.c (crypto_hash_function, Fsha1): New function.
4279 (Fmd5): Use crypto_hash_function.
4280 (syms_of_fns): Add Ssha1.
4281
4282 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4283
4284 * gnutls.c: Remove unused macros.
4285 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4286 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4287 Remove macros that are defined and never used.
4288 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4289
4290 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4291
4292 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4293 (Fx_get_selection_internal): Minor cleanup.
4294 (Fx_own_selection_internal): Rename arguments for consistency with
4295 select.el.
4296
4297 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4298
4299 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4300
4301 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4302
4303 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4304
4305 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4306
4307 * dispnew.c (scrolling_window): Don't exclude the case that the
4308 last enabled row in the desired matrix touches the bottom boundary.
4309
4310 2011-05-21 Glenn Morris <rgm@gnu.org>
4311
4312 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4313 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4314 and add some more files.
4315
4316 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4317
4318 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4319 report_file_error introduced by the change from 2011-05-07.
4320
4321 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4322
4323 * systime.h (Time): Define only if emacs is defined.
4324 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4325 where the include path doesn't have X11/X.h by default. See
4326 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4327
4328 2011-05-20 Kenichi Handa <handa@m17n.org>
4329
4330 * composite.c (find_automatic_composition): Fix previous change.
4331
4332 2011-05-20 Glenn Morris <rgm@gnu.org>
4333
4334 * lisp.mk: New file, split from Makefile.in.
4335 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4336 (shortlisp): Remove.
4337 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4338
4339 2011-05-19 Glenn Morris <rgm@gnu.org>
4340
4341 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4342 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4343 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4344 (lisp): Set the order to that of loadup.el.
4345 (shortlisp): Make it a copy of $lisp.
4346 (SOME_MACHINE_LISP): Remove.
4347 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4348 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4349
4350 2011-05-18 Kenichi Handa <handa@m17n.org>
4351
4352 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4353 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4354 (find_automatic_composition): Mostly rewrite for efficiency.
4355
4356 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4357
4358 * makefile.w32-in: Update dependencies.
4359
4360 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4361
4362 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4363 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4364
4365 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4366
4367 Fix some integer overflow issues, such as string length overflow.
4368
4369 * insdel.c (count_size_as_multibyte): Check for string overflow.
4370
4371 * character.c (lisp_string_width): Check for string overflow.
4372 Use EMACS_INT, not int, for string indexes and lengths; in
4373 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4374 the resulting string length overflows an EMACS_INT; instead,
4375 report a string overflow if no precision given. When checking for
4376 precision exhaustion, use a check that cannot possibly have
4377 integer overflow. (Bug#8675)
4378 * character.h (lisp_string_width): Adjust to new signature.
4379
4380 * alloc.c (string_overflow): New function.
4381 (Fmake_string): Use it. This doesn't change behavior, but saves
4382 a few bytes and will simplify future changes.
4383 * character.c (string_escape_byte8): Likewise.
4384 * lisp.h (string_overflow): New decl.
4385
4386 Fixups, following up to the user-interface timestamp change.
4387 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4388 for UI timestamps, instead of unsigned long.
4389 * msdos.c (mouse_get_pos): Likewise.
4390 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4391 * w32gui.h (Time): Define by including "systime.h" rather than by
4392 declaring it ourselves. (Bug#8664)
4393
4394 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4395 * image.c (clear_image_cache): Likewise.
4396
4397 * term.c (term_mouse_position): Don't assume time_t wraparound.
4398
4399 Be more systematic about user-interface timestamps.
4400 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4401 and sometimes 'EMACS_UINT', to represent these timestamps.
4402 This change causes it to use 'Time' uniformly, as that's what X uses.
4403 This makes the code easier to follow, and makes it easier to catch
4404 integer overflow bugs such as Bug#8664.
4405 * frame.c (Fmouse_position, Fmouse_pixel_position):
4406 Use Time, not unsigned long, for user-interface timestamps.
4407 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4408 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4409 * keyboard.h (last_event_timestamp): Likewise.
4410 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4411 * menu.h (xmenu_show): Likewise.
4412 * term.c (term_mouse_position): Likewise.
4413 * termhooks.h (struct input_event.timestamp): Likewise.
4414 (struct terminal.mouse_position_hook): Likewise.
4415 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4416 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4417 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4418 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4419 what it was before.
4420 * menu.h, termhooks.h: Include "systime.h", for Time.
4421
4422 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4423 Don't assume that the difference between two unsigned long values
4424 can fit into an integer. At this point, we know button_down_time
4425 <= event->timestamp, so the difference must be nonnegative, so
4426 there's no need to cast the result if double-click-time is
4427 nonnegative, as it should be; check that it's nonnegative, just in
4428 case. This bug is triggered when events are more than 2**31 ms
4429 apart (about 25 days). (Bug#8664)
4430
4431 * xselect.c (last_event_timestamp): Remove duplicate decl.
4432 (x_own_selection): Remove needless cast to unsigned long.
4433
4434 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4435 that always fit in int. Use a sentinel instead of a counter, to
4436 avoid a temp and to allay GCC's concerns about possible int overflow.
4437 * frame.h (struct frame): Use int for menu_bar_items_used
4438 instead of EMACS_INT, since it always fits in int.
4439
4440 * menu.c (grow_menu_items): Check for int overflow.
4441
4442 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4443
4444 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4445 Before, the code was not consistent. These values cannot exceed
4446 2**31 - 1 so there's no need to make them unsigned.
4447 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4448 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4449 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4450 as modifiers.
4451 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4452
4453 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4454 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4455 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4456 presumably because the widths might not match.
4457
4458 * window.c (size_window): Avoid needless test at loop start.
4459
4460 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4461
4462 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4463
4464 2011-05-12 Drew Adams <drew.adams@oracle.com>
4465
4466 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4467
4468 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4469
4470 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4471 `width' to `bar_area_x' and `bar_area_width', respectively.
4472 (x_scroll_run): Take account of fringe background extension.
4473
4474 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4475 Rename local vars `left' and `width' to `bar_area_x' and
4476 `bar_area_width', respectively.
4477 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4478 background extension.
4479
4480 2011-05-10 Jim Meyering <meyering@redhat.com>
4481
4482 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4483
4484 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4485
4486 * image.c (Finit_image_library): Return t for built-in image types,
4487 like pbm and xbm. (Bug#8640)
4488
4489 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4490
4491 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4492
4493 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4494
4495 * w32console.c (Fset_screen_color): Doc fix.
4496 (Fget_screen_color): New function.
4497 (syms_of_ntterm): Defsubr it.
4498
4499 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4500 unlink the temporary file if Fcall_process didn't create it in the
4501 first place.
4502 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4503 child process will be redirected to a file specified with `:file'.
4504 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4505 cue to call_process_cleanup not to close that handle.
4506
4507 2011-05-07 Ben Key <bkey76@gmail.com>
4508
4509 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4510 one of two shell specific rules, either bootstrap-temacs-CMD or
4511 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4512 to the previous implementation of the bootstrap-temacs rule.
4513 The bootstrap-temacs-CMD rule is similar to the previous
4514 implementation of the bootstrap-temacs rule except that it
4515 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4516 variable.
4517
4518 These changes, along with some changes to nt/configure.bat,
4519 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4520 earlier fix to add support for --cflags and --ldflags options
4521 that include quotes so that it works whether make uses cmd or
4522 sh as the shell.
4523
4524 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4525
4526 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4527 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4528 is a constant.
4529 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4530 a string. Handle both cases.
4531 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4532 (Fdbus_register_method): Use Qinvalid_function.
4533
4534 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4535
4536 * makefile.w32-in: Update dependencies.
4537 (LISP_H): Add inttypes.h and stdin.h.
4538 (PROCESS_H): Add unistd.h.
4539
4540 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4541
4542 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4543 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4544
4545 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4546
4547 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4548
4549 * term.c (vfatal): Remove stray call to va_end.
4550 It's not needed and the C Standard doesn't allow it here anyway.
4551
4552 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4553 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4554
4555 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4556 bytes.
4557
4558 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4559
4560 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4561
4562 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4563
4564 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4565
4566 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4567
4568 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4569 * charset.c (Fdefine_charset_internal): Don't initialize
4570 charset.code_space[15]. The value was garbage, on hosts with
4571 32-bit int (Bug#8600).
4572
4573 * lread.c (read_integer): Be more consistent with string-to-number.
4574 Use string_to_number to do the actual conversion; this avoids
4575 rounding errors and fixes some other screwups. Without this fix,
4576 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4577 (digit_to_number): Move earlier, for benefit of read_integer.
4578 Return -1 if the digit is out of range for the base, -2 if it is
4579 not a digit in any supported base. (Bug#8602)
4580
4581 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4582
4583 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4584 to match comment at start of function. This also removes a
4585 GCC warning about overflow in a 32+64-bit port.
4586
4587 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4588
4589 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4590 Reported by Stefan Monnier in
4591 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4592 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4593 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4594
4595 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4596 (EMACS_UINTPTR): Likewise, with uintptr_t.
4597
4598 * lisp.h: Prefer 64-bit EMACS_INT if available.
4599 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4600 on 32-bit hosts that have 64-bit int, so that they can access
4601 large files.
4602 However, temporarily disable this change unless the temporary
4603 symbol WIDE_EMACS_INT is defined.
4604
4605 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4606
4607 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4608 This removes an assumption that EMACS_INT and long are the same
4609 width as pointers. The assumption is true for Emacs porting targets
4610 now, but we want to make other targets possible.
4611 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4612 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4613 In the rest of the code, change types of integers that hold casted
4614 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4615 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4616 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4617 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4618 No need to cast type when ORing.
4619 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4620 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4621 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4622 assume EMACS_INT is the same width as char *.
4623 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4624 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4625 Remove no-longer-needed casts.
4626 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4627 (xg_tool_bar_help_callback, xg_make_tool_item):
4628 Use EMACS_INTPTR to hold an integer
4629 that will be cast to void *; this can avoid a GCC warning
4630 if EMACS_INT is not the same width as void *.
4631 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4632 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4633 (current_message_1, set_message_1):
4634 Use a local to convert to proper width without a cast.
4635 * xmenu.c (dialog_selection_callback): Likewise.
4636
4637 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4638 Also, don't assume VALBITS / RAND_BITS is less than 5,
4639 and don't rely on undefined behavior when shifting a 1 left into
4640 the sign bit.
4641 * lisp.h (get_random): Change signature to match.
4642
4643 * lread.c (hash_string): Use size_t, not int, for hash computation.
4644 Normally we prefer signed values; but hashing is special, because
4645 it's better to use unsigned division on hash table sizes so that
4646 the remainder is nonnegative. Also, size_t is the natural width
4647 for hashing into memory. The previous code used 'int', which doesn't
4648 retain enough info to hash well into very large tables.
4649 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4650
4651 * dbusbind.c: Don't possibly lose pointer info when converting.
4652 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4653 Use XPNTR rather than XHASH, so that the high-order bits of
4654 the pointer aren't lost when converting through void *.
4655
4656 * eval.c (Fautoload): Don't double-shift a pointer.
4657
4658 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4659
4660 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4661
4662 * gnutls.c (DEF_GNUTLS_FN):
4663 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4664
4665 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4666
4667 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4668 marker. (Bug#8610)
4669
4670 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4671
4672 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4673 New version that can reserve upto 2GB of heap space.
4674
4675 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4676
4677 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4678
4679 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4680
4681 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4682 `gnutls_certificate_set_x509_key_file'.
4683
4684 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4685
4686 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4687 Update dependencies.
4688
4689 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4690
4691 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4692 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4693 Remove unused parameter `fildes'.
4694 * process.c (read_process_output, send_process): Don't pass it.
4695
4696 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4697
4698 Fix previous change: the library cache is defined in w32.c.
4699 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4700 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4701
4702 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4703
4704 Implement dynamic loading of GnuTLS on Windows.
4705
4706 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4707 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4708 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4709 Declare.
4710
4711 * gnutls.c (Qgnutls_dll): Define.
4712 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4713 (gnutls_*): Declare function pointers.
4714 (init_gnutls_functions): New function to initialize function pointers.
4715 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4716 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4717 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4718 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4719 (emacs_gnutls_write, emacs_gnutls_read)
4720 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4721 (Fgnutls_available_p): New function.
4722 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4723 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4724 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4725
4726 * image.c: Include w32.h.
4727 (Vimage_type_cache): Delete.
4728 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4729 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4730 (w32_delayed_load): Move to w32.c.
4731
4732 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4733
4734 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4735 (w32_delayed_load): Move from image.c. When loading a library, record
4736 its filename in the :loaded-from property of the library id.
4737 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4738 Initialize and staticpro them.
4739 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4740
4741 * process.c: Include lisp.h before w32.h, not after.
4742 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4743 instead of gnutls_record_check_pending.
4744
4745 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4746
4747 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4748
4749 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4750 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4751 as passed in.
4752
4753 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4754
4755 * xterm.c (x_set_frame_alpha): Do not set property on anything
4756 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4757
4758 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4759
4760 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4761
4762 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4763
4764 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4765 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4766 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4767 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4768 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4769 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4770 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4771 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4772 (Qgnutls_bootprop_callbacks_verify): Make static.
4773
4774 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4775
4776 * callproc.c: Indentation fixup.
4777
4778 * sysdep.c (wait_for_termination_1): Make static.
4779 (wait_for_termination, interruptible_wait_for_termination):
4780 Move after wait_for_termination_1.
4781
4782 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4783
4784 * sysdep.c (interruptible_wait_for_termination): New function
4785 which is like wait_for_termination, but allows keyboard
4786 interruptions.
4787
4788 * callproc.c (Fcall_process): Add (:file "file") as an option for
4789 the STDOUT buffer.
4790 (Fcall_process_region): Ditto.
4791
4792 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4793
4794 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4795 rather than `XVECTOR (FOO)->size'.
4796
4797 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4798 inttypes.h, as a gnulib replacement is used if it not available in
4799 system headers.
4800
4801 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4802
4803 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4804 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4805 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4806
4807 * coding.c (coding_alloc_by_realloc): Error out if destination
4808 will grow beyond MOST_POSITIVE_FIXNUM.
4809 (decode_coding_emacs_mule): Abort if there isn't enough place in
4810 charbuf for the composition carryover bytes. Reserve an extra
4811 space for up to 2 characters produced in a loop.
4812 (decode_coding_iso_2022): Abort if there isn't enough place in
4813 charbuf for the composition carryover bytes.
4814
4815 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4816
4817 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4818 aborting when %lld or %lll format is passed.
4819 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4820 %llo or %llx format is passed. (Bug#8545)
4821
4822 * window.c (window_scroll_line_based): Use a marker instead of
4823 simple variables to record original value of point. (Bug#7952)
4824
4825 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4826 produced by %s or %c overflows available buffer space. (Bug#8545)
4827
4828 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4829
4830 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4831 (SIZE_MAX): Move defn after all includes, as they might #define it.
4832
4833 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4834
4835 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4836
4837 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4838
4839 * keyboard.c (Qdelayed_warnings_hook): Define.
4840 (command_loop_1): Run `delayed-warnings-hook'
4841 if Vdelayed_warnings_list is non-nil.
4842 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4843 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4844
4845 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4846
4847 * doprnt.c (doprnt): Don't return value smaller than the buffer
4848 size if the message was truncated. (Bug#8545).
4849
4850 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4851
4852 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4853 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4854
4855 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4856
4857 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4858
4859 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4860
4861 * makefile.w32-in: Update dependencies.
4862
4863 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4864
4865 Improve `doprnt' and its usage. (Bug#8545)
4866 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4867 `format_end'. Remove support for %l as a conversion specifier.
4868 Don't use xrealloc. Improve diagnostics when the %l size modifier
4869 is used. Update the commentary.
4870
4871 * eval.c (verror): Simplify calculation of size_t.
4872
4873 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4874 messages.
4875
4876 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4877
4878 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4879 change.
4880
4881 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4882
4883 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4884 This makes this file independent of the recent pseudovector change.
4885
4886 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4887
4888 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4889
4890 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4891 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4892 Remove unused local.
4893 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4894
4895 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4896 GCC 4.6.0 optimizes based on type-based alias analysis.
4897 For example, if b is of type struct buffer * and v of type struct
4898 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4899 != &v->size, and therefore "v->size = 1; b->size = 2; return
4900 v->size;" must therefore return 1. This assumption is incorrect
4901 for Emacs, since it type-puns struct Lisp_Vector * with many other
4902 types. To fix this problem, this patch adds a new type struct
4903 vectorlike_header that documents the constraints on layout of vectors
4904 and pseudovectors, and helps optimizing compilers not get fooled
4905 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4906 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4907 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4908 the size member.
4909 (XSETPVECTYPE): Rewrite in terms of new macro.
4910 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4911 This is a bit clearer, and further avoids the possibility of
4912 undesirable aliasing.
4913 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4914 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4915 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4916 since Lisp_Subr is a special case (no "next" field).
4917 (ASIZE): Now uses header.size rather than size.
4918 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4919 to avoid the hassle of writing XVECTOR (foo)->header.size.
4920 (struct vectorlike_header): New type.
4921 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4922 object, to help avoid aliasing.
4923 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4924 (SUBRP): Likewise, since Lisp_Subr is a special case.
4925 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4926 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4927 (struct Lisp_Hash_Table): Combine first two members into a single
4928 struct vectorlike_header member. All uses of "size" and "next" members
4929 changed to be "header.size" and "header.next".
4930 * buffer.h (struct buffer): Likewise.
4931 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4932 * frame.h (struct frame): Likewise.
4933 * process.h (struct Lisp_Process): Likewise.
4934 * termhooks.h (struct terminal): Likewise.
4935 * window.c (struct save_window_data, struct saved_window): Likewise.
4936 * window.h (struct window): Likewise.
4937 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4938 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4939 * buffer.c (init_buffer_once): Likewise.
4940 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4941 special case.
4942 * process.c (Fformat_network_address): Use local var for size,
4943 for brevity.
4944
4945 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4946
4947 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4948 * data.c (atof): Remove decl; no longer used or needed.
4949 (digit_to_number): Move to lread.c.
4950 (Fstring_to_number): Use new string_to_number function, to be
4951 consistent with how the Lisp reader treats infinities and NaNs.
4952 Do not assume that floating-point numbers represent EMACS_INT
4953 without losing information; this is not true on most 64-bit hosts.
4954 Avoid double-rounding errors, by insisting on integers when
4955 parsing non-base-10 numbers, as the documentation specifies.
4956 * lisp.h (string_to_number): New decl, replacing ...
4957 (isfloat_string): Remove.
4958 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4959 (read1): Do not accept +. and -. as integers; this
4960 appears to have been a coding error. Similarly, do not accept
4961 strings like +-1e0 as floating point numbers. Do not report
4962 overflow for integer overflows unless the base is not 10 which
4963 means we have no simple and reliable way to continue.
4964 Break out the floating-point parsing into a new
4965 function string_to_number, so that Fstring_to_number parses
4966 floating point numbers consistently with the Lisp reader.
4967 (digit_to_number): Move here from data.c. Make it static inline.
4968 (E_CHAR, EXP_INT): Remove, replacing with ...
4969 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4970 (string_to_number): New function, replacing isfloat_string.
4971 This function checks for valid syntax and produces the resulting
4972 Lisp float number too. Rework it so that string-to-number
4973 no longer mishandles examples like "1.0e+". Use strtoumax,
4974 so that overflow for non-base-10 numbers is reported only when
4975 there's no portable and simple way to convert to floating point.
4976
4977 * textprop.c (set_text_properties_1): Rewrite for clarity,
4978 and to avoid GCC warning about integer overflow.
4979
4980 * intervals.h (struct interval): Use EMACS_INT for members
4981 where EMACS_UINT might cause problems. See
4982 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4983 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4984 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4985 All uses changed.
4986 (offset_intervals): Tell GCC not to worry about length overflow
4987 when negating a negative length.
4988
4989 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4990 (overrun_check_free): Likewise.
4991
4992 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4993 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4994 word size.
4995
4996 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4997 (gnutls_make_error): Rename local to avoid shadowing.
4998 (gnutls_emacs_global_deinit): ifdef out; not used.
4999 (Fgnutls_boot): Use const for pointer to readonly storage.
5000 Comment out unused local. Fix pointer signedness problems.
5001
5002 * lread.c (openp): Don't stuff size_t into an 'int'.
5003 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5004 about possible signed overflow.
5005
5006 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5007 (GDK_KEY_g): Don't define if already defined.
5008 (xg_prepare_tooltip): Avoid pointer signedness problem.
5009 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5010
5011 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5012 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5013
5014 * xfns.c (Fx_window_property): Simplify a bit,
5015 to make a bit faster and to avoid GCC 4.6.0 warning.
5016 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5017
5018 * fns.c (internal_equal): Don't assume size_t fits in int.
5019
5020 * alloc.c (compact_small_strings): Tighten assertion a little.
5021
5022 Replace pEd with more-general pI, and fix some printf arg casts.
5023 * lisp.h (pI): New macro, generalizing old pEd macro to other
5024 conversion specifiers. For example, use "...%"pI"d..." rather
5025 than "...%"pEd"...".
5026 (pEd): Remove. All uses replaced with similar uses of pI.
5027 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5028 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5029 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5030 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5031 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5032 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5033 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5034 64-bit hosts.
5035 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5036 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5037 * print.c (safe_debug_print, print_object): Likewise.
5038 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5039 to int.
5040 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5041 avoiding the 0 flag, which is not portable.
5042 * process.c (Fmake_network_process): Use pI to avoid cast.
5043 * region-cache.c (pp_cache): Likewise.
5044 * xdisp.c (decode_mode_spec): Likewise.
5045 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5046 behavior on 64-bit hosts with printf arg.
5047 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5048 (x_stop_queuing_selection_requests): Likewise.
5049 (x_get_window_property): Don't truncate byte count to an 'int'
5050 when tracing.
5051
5052 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5053 here, since it parses constructs like leading '-' and spaces,
5054 which are not wanted; and it overflows with large numbers.
5055 Instead, simply match F[0-9]+, which is what is wanted anyway.
5056
5057 * alloc.c: Remove unportable assumptions about struct layout.
5058 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5059 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5060 (allocate_vectorlike, make_pure_vector): Use the new macros,
5061 plus offsetof, to remove unportable assumptions about struct layout.
5062 These assumptions hold on all porting targets that I know of, but
5063 they are not guaranteed, they're easy to remove, and removing them
5064 makes further changes easier.
5065
5066 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5067 This doesn't fix a bug but makes the code clearer.
5068 (string_overrun_cookie): Now const. Use initializers that
5069 don't formally overflow signed char, to avoid warnings.
5070 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5071 can cause Emacs to crash when string overrun checking is enabled.
5072 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5073 multiple of sizeof (EMACS_INT); it need not be, if
5074 alignof(EMACS_INT) < sizeof (EMACS_INT).
5075 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5076
5077 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5078
5079 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5080
5081 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5082
5083 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5084 supposed to be handshaking. (Bug#8556)
5085 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5086
5087 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5088
5089 * lisp.h (Qdebug): List symbol.
5090 * eval.c (Qdebug): Restore global linkage.
5091 * keyboard.c (debug-on-event): New variable.
5092 (handle_user_signal): Break into debugger when debug-on-event
5093 matches the current signal symbol.
5094
5095 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5096
5097 * alloc.c (check_sblock, check_string_bytes)
5098 (check_string_free_list): Convert to standard C.
5099
5100 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5101
5102 * w32.c (emacs_gnutls_push): Fix typo.
5103
5104 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5105
5106 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5107 "cast to pointer from integer of different size".
5108
5109 Improve doprnt and its use in verror. (Bug#8545)
5110 * doprnt.c (doprnt): Document the set of format control sequences
5111 supported by the function. Use SAFE_ALLOCA instead of always
5112 using `alloca'.
5113
5114 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5115 is one byte too soon. Don't use xrealloc; instead xfree and
5116 xmalloc anew.
5117
5118 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5119
5120 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5121 callbacks stage.
5122
5123 * gnutls.c: Renamed global_initialized to
5124 gnutls_global_initialized. Added internals for the
5125 :verify-hostname-error, :verify-error, and :verify-flags
5126 parameters of `gnutls-boot' and documented those parameters in the
5127 docstring. Start callback support.
5128 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5129 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5130 on error. Return error code.
5131 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5132 (emacs_gnutls_read): Likewise.
5133 (Fgnutls_boot): Return handshake error code.
5134 (emacs_gnutls_handle_error): New function.
5135 (wsaerror_to_errno): Likewise.
5136
5137 * w32.h (emacs_gnutls_pull): Add prototype.
5138 (emacs_gnutls_push): Likewise.
5139
5140 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5141 (emacs_gnutls_push): Likewise.
5142
5143 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5144
5145 * process.c (wait_reading_process_output): Check if GnuTLS
5146 buffered some data internally if no FDs are set for TLS
5147 connections.
5148
5149 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5150 (LIBS): Link to USER_LIBS.
5151 ($(BLD)/gnutls.$(0)): New target.
5152
5153 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5154
5155 * xdisp.c (handle_single_display_spec): Rename the
5156 display_replaced_before_p argument into display_replaced_p, to
5157 make it consistent with the commentary. Fix typos in the
5158 commentary.
5159
5160 * textprop.c (syms_of_textprop): Remove dead code.
5161 (copy_text_properties): Delete obsolete commentary about an
5162 interface that was deleted long ago. Fix typos in the description
5163 of arguments.
5164
5165 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5166 to changes in oldXMenu/XMenu.h from 2011-04-16.
5167 <menu_help_message, prev_menu_help_message>: Constify.
5168 (IT_menu_make_room): menu->help_text is now `const char **';
5169 adjust.
5170
5171 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5172 to changes in oldXMenu/XMenu.h from 2011-04-16.
5173 (struct XMenu): Declare `help_text' `const char **'.
5174
5175 * xfaces.c <Qunspecified>: Make extern again.
5176
5177 * syntax.c: Include sys/types.h before including regex.h, as
5178 required by Posix.
5179
5180 * doc.c (get_doc_string): Improve the format passed to `error'.
5181
5182 * doprnt.c (doprnt): Improve commentary.
5183
5184 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5185
5186 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5187 them with etags.
5188
5189 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5190 changes in globals.h immediately force recompilation.
5191 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5192 $(CURDIR)/s/ms-w32.h.
5193 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5194
5195 * character.c (Fchar_direction): Function deleted.
5196 (syms_of_character): Don't defsubr it.
5197 <char-direction-table>: Deleted.
5198
5199 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5200
5201 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5202 * doprnt.c: Include limits.h.
5203 (SIZE_MAX): New macro.
5204 (doprnt): Return a size_t value. 2nd arg is now size_t.
5205 Many local variables are now size_t instead of int or unsigned.
5206 Improve overflow protection. Support `l' modifier for integer
5207 conversions. Support %l conversion. Don't assume an EMACS_INT
5208 argument for integer conversions and for %c.
5209
5210 * lisp.h (doprnt): Restore prototype.
5211
5212 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5213 $(SRC)/character.h.
5214
5215 * Makefile.in (base_obj): Add back doprnt.o.
5216
5217 * deps.mk (doprnt.o): Add back prerequisites.
5218 (callint.o): Depend on character.h.
5219
5220 * eval.c (internal_lisp_condition_case): Include the handler
5221 representation in the error message.
5222 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5223 when breaking from the loop.
5224
5225 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5226
5227 * callint.c (Fcall_interactively): When displaying error message
5228 about invalid control letter, pass the character's codepoint, not
5229 a pointer to its multibyte form. Improve display of the character
5230 in octal and display also its hex code.
5231
5232 * character.c (char_string): Use %x to display the (unsigned)
5233 codepoint of an invalid character, to avoid displaying a bogus
5234 negative value.
5235
5236 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5237 `error', not SYMBOL_NAME itself.
5238
5239 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5240 character arguments to `error'.
5241
5242 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5243 to `error' in error message about FINAL_CHAR argument. Make sure
5244 FINAL_CHAR is a character, and use %c when it is passed as
5245 argument to `error'.
5246
5247 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5248
5249 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5250
5251 * w32.c: Include <time.h>.
5252 (sys_localtime): New function.
5253
5254 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5255
5256 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5257
5258 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5259
5260 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5261
5262 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5263 zombies (Bug#8467).
5264
5265 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5266
5267 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5268 gl_state.e_property when gl_state.object is Qt.
5269
5270 * insdel.c (make_gap_larger): Remove limitation of buffer size
5271 to <= INT_MAX.
5272
5273 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5274
5275 * xdisp.c (lookup_glyphless_char_display)
5276 (produce_glyphless_glyph): Handle cons cell entry in
5277 glyphless-char-display.
5278 (Vglyphless_char_display): Document it.
5279
5280 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5281 glyphless-char-display.
5282
5283 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5284
5285 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5286
5287 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5288
5289 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5290 definition for no-X builds.
5291
5292 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5293
5294 Static checks with GCC 4.6.0 and non-default toolkits.
5295
5296 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5297
5298 * process.c (keyboard_bit_set): Define only if SIGIO.
5299 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5300 (send_process): Repair possible setjmp clobbering.
5301
5302 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5303
5304 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5305
5306 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5307
5308 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5309 Define only if needed.
5310
5311 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5312 by pacifying GCC about it. Maybe it's time to retire it?
5313 * xfaces.c (USG, __TIMEVAL__): Likewise.
5314
5315 * dispextern.h (struct redisplay_interface): Rename param
5316 to avoid shadowing.
5317 * termhooks.h (struct terminal): Likewise.
5318 * xterm.c (xembed_send_message): Likewise.
5319
5320 * insdel.c (make_gap_smaller): Define only if
5321 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5322
5323 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5324 it.
5325
5326 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5327 so that we aren't warned about unused symbols.
5328
5329 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5330
5331 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5332
5333 * xfns.c (x_real_positions): Mark locals as initialized.
5334
5335 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5336
5337 * xterm.c: Fix problems found by static analysis with other toolkits.
5338 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5339 (x_dispatch_event): Declare static if USE_GTK, and
5340 define if USE_GTK || USE_X_TOOLKIT.
5341 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5342 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5343 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5344 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5345
5346 * xmenu.c (menu_help_callback): Pointer type fixes.
5347 Use const pointers when pointing at readonly data. Avoid pointer
5348 signedness clashes.
5349 (FALSE): Remove unused macro.
5350 (update_frame_menubar): Remove unused decl.
5351
5352 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5353
5354 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5355 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5356 (single_menu_item): Rename local to avoid shadowing.
5357
5358 * keyboard.c (make_lispy_event): Remove unused local var.
5359
5360 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5361 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5362
5363 * bitmaps: Change bitmaps from unsigned char back to the X11
5364 compatible char. Avoid the old compiler warnings about
5365 out-of-range initializers by using, for example, '\xab' rather
5366 than 0xab.
5367
5368 * xgselect.c (xgselect_initialize): Check vs interface
5369 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5370
5371 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5372
5373 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5374 to read-only memory.
5375
5376 * fns.c (vector): Remove; this old hack is no longer needed.
5377
5378 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5379 Remove unused var.
5380 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5381
5382 * xrdb.c (x_load_resources): Omit unused local.
5383
5384 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5385 (x_window): Rename locals to avoid shadowing.
5386 (USG): Use the kludged USG macro, to pacify gcc.
5387
5388 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5389 (x_term_init): Remove local to avoid shadowing.
5390
5391 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5392
5393 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5394 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5395
5396 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5397
5398 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5399
5400 Fix regex.c, syntax.c and friends for buffers > 2GB.
5401 * syntax.h (struct gl_state_s): Declare character position members
5402 EMACS_INT.
5403
5404 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5405
5406 * textprop.c (verify_interval_modification, interval_of):
5407 Declare arguments EMACS_INT.
5408
5409 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5410 EMACS_INT.
5411
5412 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5413
5414 * indent.c (Fvertical_motion): Local variable it_start is now
5415 EMACS_INT.
5416
5417 * regex.c (re_match, re_match_2, re_match_2_internal)
5418 (bcmp_translate, regcomp, regexec, print_double_string)
5419 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5420 (re_compile_pattern, re_exec): Declare arguments and local
5421 variables `size_t' and `ssize_t' and return values `regoff_t', as
5422 appropriate.
5423 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5424 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5425 <compile_stack_type>: `size' and `avail' are now `size_t'.
5426
5427 * regex.h <regoff_t>: Use ssize_t, not int.
5428 (re_search, re_search_2, re_match, re_match_2): Arguments that
5429 specify buffer/string position and length are now ssize_t and
5430 size_t. Return type is regoff_t.
5431
5432 2011-04-16 Ben Key <bkey76@gmail.com>
5433
5434 * nsfont.m: Fixed bugs in ns_get_family and
5435 ns_descriptor_to_entity that were caused by using free to
5436 deallocate memory blocks that were allocated by xmalloc (via
5437 xstrdup). This caused Emacs to crash when compiled with
5438 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5439 --enable-checking=xmallocoverrun). xfree is now used to
5440 deallocate these memory blocks.
5441
5442 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5443
5444 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5445
5446 emacs_write: Accept and return EMACS_INT for sizes.
5447 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5448 et seq.
5449 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5450 Accept and return EMACS_INT.
5451 (emacs_gnutls_write): Return the number of bytes written on
5452 partial writes.
5453 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5454 (emacs_read, emacs_write): Remove check for negative size, as the
5455 Emacs source code has been audited now.
5456 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5457 (emacs_read, emacs_write): Use it.
5458 * process.c (send_process): Adjust to the new signatures of
5459 emacs_write and emacs_gnutls_write. Do not attempt to store
5460 a byte offset into an 'int'; it might overflow.
5461 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5462
5463 * sound.c: Don't assume sizes fit in 'int'.
5464 (struct sound_device.period_size, alsa_period_size):
5465 Return EMACS_INT, not int.
5466 (struct sound_device.write, vox_write, alsa_write):
5467 Accept EMACS_INT, not int.
5468 (wav_play, au_play): Use EMACS_INT to store sizes and to
5469 record read return values.
5470
5471 2011-04-15 Ben Key <bkey76@gmail.com>
5472
5473 * keyboard.c (Qundefined): Don't declare static since it is used
5474 in nsfns.m.
5475 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5476 static since they are used in nsfont.m.
5477
5478 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5479
5480 * process.c (Qprocessp): Don't declare static.
5481 * lisp.h (Qprocessp): Declare again.
5482
5483 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5484
5485 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5486
5487 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5488
5489 Improve C-level modularity by making more things 'static'.
5490
5491 Don't publish debugger-only interfaces to other modules.
5492 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5493 (verify_bytepos, count_markers): Move decls to the only modules
5494 that need them.
5495 * region-cache.h (pp_cache): Likewise.
5496 * window.h (check_all_windows): Likewise.
5497 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5498
5499 * sysdep.c (croak): Now static, if
5500 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5501 * syssignal.h (croak): Declare only if not static.
5502
5503 * alloc.c (refill_memory_reserve): Now static if
5504 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5505 * lisp.h (refill_memory_reserve): Declare only if not static.
5506
5507 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5508 Define only if USE_LUCID.
5509
5510 * xrdb.c (x_customization_string, x_rm_string): Now static.
5511
5512 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5513 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5514
5515 * xdisp.c (draw_row_with_mouse_face): Now static.
5516 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5517
5518 * window.h (check_all_windows): Mark externally visible.
5519
5520 * window.c (window_deletion_count): Now static.
5521
5522 * undo.c: Make symbols static if they're not exported.
5523 (last_undo_buffer, last_boundary_position, pending_boundary):
5524 Now static.
5525
5526 * textprop.c (interval_insert_behind_hooks): Now static.
5527 (interval_insert_in_front_hooks): Likewise.
5528
5529 * term.c: Make symbols static if they're not exported.
5530 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5531 (max_frame_lines, tty_set_terminal_modes):
5532 (tty_reset_terminal_modes, tty_turn_off_highlight):
5533 (get_tty_terminal): Now static.
5534 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5535 * termhooks.h (term_mouse_moveto): Do not declare if
5536 HAVE_WINDOW_SYSTEM.
5537 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5538 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5539
5540 * sysdep.c: Make symbols static if they're not exported.
5541 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5542 Now static.
5543 (sigprocmask_set, full_mask): Remove; unused.
5544 (wait_debugging): Mark as visible.
5545 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5546 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5547
5548 * syntax.c (syntax_temp): Define only if !__GNUC__.
5549
5550 * sound.c (current_sound_device, current_sound): Now static.
5551
5552 * search.c (searchbufs, searchbuf_head): Now static.
5553
5554 * scroll.c (scroll_cost): Remove; unused.
5555 * dispextern.h (scroll_cost): Remove decl.
5556
5557 * region-cache.h (pp_cache): Mark as externally visible.
5558
5559 * process.c: Make symbols static if they're not exported.
5560 (process_tick, update_tick, create_process, chan_process):
5561 (Vprocess_alist, proc_buffered_char, datagram_access):
5562 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5563 (deactivate_process): Mark defn as static, as well as decl.
5564 * lisp.h (create_process): Remove decl.
5565 * process.h (chan_process, Vprocess_alist): Remove decls.
5566
5567 * print.c: Make symbols static if they're not exported.
5568 (print_depth, new_backquote_output, being_printed, print_buffer):
5569 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5570 (print_interval, print_number_index, initial_stderr_stream):
5571 Now static.
5572 * lisp.h (Fprinc): Remove decl.
5573 (debug_output_compilation_hack): Mark as externally visible.
5574
5575 * sysdep.c (croak): Move decl from here to syssignal.h.
5576 * syssignal.h (croak): Put it here, so the API can be checked when
5577 'croak' is called from dissociate_if_controlling_tty.
5578
5579 * minibuf.c: Make symbols static if they're not exported.
5580 (minibuf_save_list, choose_minibuf_frame): Now static.
5581 * lisp.h (choose_minibuf_frame): Remove decl.
5582
5583 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5584
5585 * lread.c: Make symbols static if they're not exported.
5586 (read_objects, initial_obarray, oblookup_last_bucket_number):
5587 Now static.
5588 (make_symbol): Remove; unused.
5589 * lisp.h (initial_obarray, make_symbol): Remove decls.
5590
5591 * keyboard.c: Make symbols static if they're not exported.
5592 (single_kboard, recent_keys_index, total_keys, recent_keys):
5593 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5594 (this_single_command_key_start, echoing, last_auto_save):
5595 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5596 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5597 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5598 (Vlispy_mouse_stem, double_click_count):
5599 Now static.
5600 (force_auto_save_soon): Define only if SIGDANGER.
5601 (ignore_mouse_drag_p): Now static if
5602 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5603 (print_help): Remove; unused.
5604 (stop_character, last_timer_event): Mark as externally visible.
5605 * keyboard.h (ignore_mouse_drag_p): Declare only if
5606 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5607 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5608 * lisp.h (echoing): Remove decl.
5609 (force_auto_save_soon): Declare only if SIGDANGER.
5610 * xdisp.c (redisplay_window): Simplify code, to make it more
5611 obvious that ignore_mouse_drag_p is not accessed if !defined
5612 USE_GTK && !defined HAVE_NS.
5613
5614 * intervals.c: Make symbols static if they're not exported.
5615 (merge_properties_sticky, merge_interval_right, delete_interval):
5616 Now static.
5617 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5618
5619 * insdel.c: Make symbols static if they're not exported.
5620 However, leave prepare_to_modify_buffer alone. It's never
5621 called from outside this function, but that appears to be a bug.
5622 (combine_after_change_list, combine_after_change_buffer):
5623 (adjust_after_replace, signal_before_change): Now static.
5624 (adjust_after_replace_noundo): Remove; unused.
5625 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5626 (signal_before_change): Remove decls.
5627
5628 * indent.c (val_compute_motion, val_vmotion): Now static.
5629
5630 * image.c: Make symbols static if they're not exported.
5631 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5632 if USE_GTK.
5633 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5634 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5635
5636 * fringe.c (standard_bitmaps): Now static.
5637 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5638
5639 * frame.c: Make symbols static if they're not exported.
5640 (x_report_frame_params, make_terminal_frame): Now static.
5641 (get_frame_param): Now static, unless HAVE_NS.
5642 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5643 (x_get_resource_string): Remove; not used.
5644 * frame.h (make_terminal_frame, x_report_frame_params):
5645 (x_get_resource_string); Remove decls.
5646 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5647 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5648
5649 * font.c, fontset.c: Make symbols static if they're not exported.
5650 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5651 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5652 * font.c (font_close_object): Now static.
5653 * font.h (font_close_object): Remove.
5654 * fontset.c (FONTSET_OBJLIST): Remove.
5655 (free_realized_fontset) #if-0 the body, which does nothing.
5656 (face_suitable_for_char_p): #if-0, as it's never called.
5657 * fontset.h (face_suitable_for_char_p): Remove decl.
5658 * xfaces.c (face_at_string_position):
5659 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5660 since 0 is always ASCII.
5661
5662 * fns.c (weak_hash_tables): Now static.
5663
5664 * fileio.c: Make symbols static if they're not exported.
5665 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5666 (Vwrite_region_annotation_buffers): Now static.
5667
5668 * eval.c: Make symbols static if they're not exported.
5669 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5670 * lisp.h (backtrace_list): Remove decl.
5671
5672 * emacs.c: Make symbols static if they're not exported.
5673 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5674 (fatal_error_code, fatal_error_signal_hook, standard_args):
5675 Now static.
5676 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5677 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5678 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5679 * lisp.h (fatal_error_signal_hook): Remove decl.
5680 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5681
5682 * editfns.c: Move a (normally-unused) function to its only use.
5683 * editfns.c, lisp.h (get_operating_system_release): Remove.
5684 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5685 worth the hassle of breaking this out.
5686
5687 * xterm.c: Make symbols static if they're not exported.
5688 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5689 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5690 (x_destroy_window, x_delete_display):
5691 Now static.
5692 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5693 (x_mouse_leave): Remove; unused.
5694 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5695 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5696 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5697 Remove decls.
5698 (x_mouse_leave): Declare only if WINDOWSNT.
5699 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5700 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5701 USE_X_TOOLKIT.
5702
5703 * ftxfont.c: Make symbols static if they're not exported.
5704 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5705 HAVE_FREETYPE.
5706 * font.h (ftxfont_driver): Likewise.
5707
5708 * xfns.c: Make symbols static if they're not exported.
5709 (x_last_font_name, x_display_info_for_name):
5710 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5711 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5712 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5713 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5714 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5715 (last_show_tip_args): Now static.
5716 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5717 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5718 (x_screen_planes): Remove; unused.
5719 * dispextern.h (x_screen_planes): Remove decl.
5720
5721 * dispnew.c: Make symbols static if they're not exported.
5722 * dispextern.h (redraw_garbaged_frames, scrolling):
5723 (increment_row_positions): Remove.
5724 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5725 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5726 Now static.
5727 (redraw_garbaged_frames): Remove; unused.
5728
5729 * xfaces.c: Make symbols static if they're not exported.
5730 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5731 Remove decls.
5732 * xterm.h (defined_color): Remove decls.
5733 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5734 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5735 (menu_face_changed_default, defined_color, free_realized_face):
5736 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5737 (ascii_face_of_lisp_face): Remove; unused.
5738
5739 * xdisp.c: Make symbols static if they're not exported.
5740 * dispextern.h (scratch_glyph_row, window_box_edges):
5741 (glyph_to_pixel_coords, set_cursor_from_row):
5742 (get_next_display_element, set_iterator_to_next):
5743 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5744 (show_mouse_face): Remove decls
5745 * frame.h (message_buf_print): Likewise.
5746 * lisp.h (pop_message, set_message, check_point_in_composition):
5747 Likewise.
5748 * xterm.h (set_vertical_scroll_bar): Likewise.
5749 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5750 (message_buf_print, scratch_glyph_row, displayed_buffer):
5751 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5752 (get_next_display_element, show_mouse_face, window_box_edges):
5753 (frame_to_window_pixel_xy, check_point_in_composition):
5754 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5755 (glyph_to_pixel_coords): Remove; unused.
5756
5757 * dired.c (file_name_completion): Now static.
5758
5759 * dbusbind.c (xd_in_read_queued_messages): Now static.
5760
5761 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5762 * data.c (circular_list_error): Remove.
5763
5764 * commands.h (last_point_position, last_point_position_buffer):
5765 (last_point_position_window): Remove decls.
5766 * keyboard.c: Make these variables static.
5767
5768 * coding.h (coding, code_convert_region, encode_coding_gap):
5769 Remove decls.
5770 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5771 (iso_code_class, detect_coding, code_convert_region): Now static.
5772 (encode_coding_gap): Remove; unused.
5773
5774 * chartab.c (chartab_chars, chartab_bits): Now static.
5775
5776 * charset.h (charset_iso_8859_1): Remove decl.
5777 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5778 Now static.
5779
5780 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5781 * ccl.c (Vccl_program_table): Now static.
5782 (check_ccl_update): Remove; unused.
5783
5784 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5785 * category.h: ... from here.
5786 * category.c (check_category_table, set_category_set): Now static.
5787
5788 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5789 * lisp.h: Remove these decls.
5790
5791 * buffer.c (buffer_count): Remove unused var.
5792
5793 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5794 so that it's not optimized away.
5795 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5796 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5797 exported only to the debugger.
5798
5799 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5800 * atimer.h (run_all_atimers): Remove; not exported.
5801
5802 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5803 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5804 was inaccessible from Lisp.
5805 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5806 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5807
5808 alloc.c: Import and export fewer symbols, and remove unused items.
5809 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5810 is defined.
5811 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5812 it's not optimized away by whole-program optimization.
5813 (message_enable_multibyte, free_misc): Remove.
5814 (catchlist, handlerlist, mark_backtrace):
5815 Declare only if BYTE_MARK_STACK.
5816 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5817 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5818 (message_enable_multibyte): Remove decl.
5819 (free_misc, interval_free_list, float_block, float_block_index):
5820 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5821 (cons_free_list, last_marked_index):
5822 Now static.
5823 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5824 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5825 (mark_backtrace): Define only if BYTE_MARK_STACK.
5826 * xdisp.c (message_enable_multibyte): Now static.
5827
5828 Declare Lisp_Object Q* variables to be 'static' if not exported.
5829 This makes it easier for human readers (and static analyzers)
5830 to see whether these variables are used from other modules.
5831 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5832 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5833 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5834 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5835 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5836 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5837 * xmenu.c, xselect.c:
5838 Declare Q* vars static if they are not used in other modules.
5839 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5840 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5841 Remove decls of unexported vars.
5842 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5843
5844 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5845
5846 Make Emacs functions such as Fatom 'static' by default.
5847 This makes it easier for human readers (and static analyzers)
5848 to see whether these functions can be called from other modules.
5849 DEFUN now defines a static function. To make the function external
5850 so that it can be used in other C modules, use the new macro DEFUE.
5851 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5852 (Finit_image_library):
5853 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5854 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5855 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5856 Remove decls, since these functions are now static.
5857 (Funintern, Fget_internal_run_time): New decls, since these functions
5858 were already external.
5859
5860 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5861 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5862 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5863 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5864 * keyboard.c, keymap.c, lread.c:
5865 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5866 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5867 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5868 Mark functions with DEFUE instead of DEFUN,
5869 if they are used in other modules.
5870 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5871 decls for now-static functions.
5872 * buffer.h (Fdelete_overlay): Remove decl.
5873 * callproc.c (Fgetenv_internal): Mark as internal.
5874 * composite.c (Fremove_list_of_text_properties): Remove decl.
5875 (Fcomposition_get_gstring): New forward static decl.
5876 * composite.h (Fcomposite_get_gstring): Remove decl.
5877 * dired.c (Ffile_attributes): New forward static decl.
5878 * doc.c (Fdocumntation_property): New forward static decl.
5879 * eval.c (Ffetch_bytecode): New forward static decl.
5880 (Funintern): Remove extern decl; now in .h file where it belongs.
5881 * fileio.c (Fmake_symbolic_link): New forward static decl.
5882 * image.c (Finit_image_library): New forward static decl.
5883 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5884 * intervals.h (Fprevious_property_change):
5885 (Fremove_list_of_text_properties): Remove decls.
5886 * keyboard.c (Fthis_command_keys): Remove decl.
5887 (Fcommand_execute): New forward static decl.
5888 * keymap.c (Flookup_key): New forward static decl.
5889 (Fcopy_keymap): Now static.
5890 * keymap.h (Flookup_key): Remove decl.
5891 * process.c (Fget_process): New forward static decl.
5892 (Fprocess_datagram_address): Mark as internal.
5893 * syntax.c (Fsyntax_table_p): New forward static decl.
5894 (skip_chars): Remove duplicate decl.
5895 * textprop.c (Fprevious_property_change): New forward static decl.
5896 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5897 Now internal.
5898 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5899 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5900
5901 * editfns.c (Fformat): Remove unreachable code.
5902
5903 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5904
5905 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5906 change. (Bug#8496)
5907
5908 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5909
5910 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5911 when at ZV. (Bug#8487)
5912
5913 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5914
5915 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5916 (Bug#8437)
5917 * keyboard.c (parse_tool_bar_item): Likewise.
5918 * sound.c (sound_cleanup, alsa_close): Likewise.
5919 * termcap.c (tgetent): Likewise.
5920 * xfns.c (x_default_font_parameter): Likewise.
5921 * xsettings.c (read_and_apply_settings): Likewise.
5922
5923 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5924 (overrun_check_free): Protoize.
5925
5926 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5927
5928 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5929 since callers should never pass a negative size.
5930 Change the signature to match that of plain 'read' and 'write'; see
5931 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5932 * lisp.h: Update prototypes of emacs_write and emacs_read.
5933
5934 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5935
5936 * xdisp.c (redisplay_window): Don't try to determine the character
5937 position of the scroll margin if the window start point w->startp
5938 is outside the buffer's accessible region. (Bug#8468)
5939
5940 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5941
5942 Fix write-region and its subroutines for buffers > 2GB.
5943 * fileio.c (a_write, e_write): Modify declaration of arguments and
5944 local variables to support buffers larger than 2GB.
5945 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5946
5947 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5948 argument, local variables, and return value.
5949
5950 * lisp.h: Update prototypes of emacs_write and emacs_read.
5951
5952 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5953
5954 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5955
5956 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5957
5958 Fix more problems found by GCC 4.6.0's static checks.
5959
5960 * xdisp.c (vmessage): Use a better test for character truncation.
5961
5962 * charset.c (load_charset_map): <, not <=, for optimization,
5963 and to avoid potential problems with integer overflow.
5964 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5965 * casetab.c (set_identity, shuffle): Likewise.
5966 * editfns.c (Fformat): Likewise.
5967 * syntax.c (skip_chars): Likewise.
5968
5969 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5970 This also lets GCC 4.6.0 generate slightly better loop code.
5971
5972 * callint.c (Fcall_interactively): <, not <=, for optimization.
5973 (Fcall_interactively): Count the number of arguments produced,
5974 not the number of arguments given. This is simpler and lets GCC
5975 4.6.0 generate slightly better code.
5976
5977 * ftfont.c: Distingish more carefully between FcChar8 and char.
5978 The previous code passed unsigned char * to a functions like
5979 strlen and xstrcasecmp that expect char *, which does not
5980 conform to the C standard.
5981 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5982 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5983 char * when the C standard requires it.
5984
5985 * keyboard.c (read_char): Remove unused var.
5986
5987 * eval.c: Port to Windows vsnprintf (Bug#8435).
5988 Include <limits.h>.
5989 (SIZE_MAX): Define if the headers do not.
5990 (verror): Do not give up if vsnprintf returns a negative count.
5991 Instead, grow the buffer. This ports to Windows vsnprintf, which
5992 does not conform to C99. Problem reported by Eli Zaretskii.
5993 Also, simplify the allocation scheme, by avoiding the need for
5994 calling realloc, and removing the ALLOCATED variable.
5995
5996 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5997
5998 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5999 But keep the doprint source code for now, as we might revamp it
6000 and use it again (Bug#8435).
6001 * lisp.h (doprnt): Remove.
6002 * Makefile.in (base_obj): Remove doprnt.o.
6003 * deps.mk (doprnt.o): Remove.
6004
6005 error: Print 32- and 64-bit integers portably (Bug#8435).
6006 Without this change, on typical 64-bit hosts error ("...%d...", N)
6007 was used to print both 32- and 64-bit integers N, which relied on
6008 undefined behavior.
6009 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6010 New macro.
6011 * lisp.h (error, verror): Mark as printf-like functions.
6012 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6013 Report overflow in size calculations when allocating printf buffer.
6014 Do not truncate output string at its first null byte.
6015 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6016 Truncate the output at a character boundary, since vsnprintf does not
6017 do that.
6018 * charset.c (check_iso_charset_parameter): Convert internal
6019 character to string before calling 'error', since %c now has the
6020 printf meaning.
6021 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6022 overflow when computing char to be passed to 'error'. Do not
6023 pass Lisp_Object to 'error'; pass the integer instead.
6024 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6025 formatted with plain %d.
6026
6027 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6028
6029 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6030
6031 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6032
6033 * xterm.c (x_catch_errors): Remove duplicate declaration.
6034
6035 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6036
6037 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6038
6039 2011-04-10 Jim Meyering <meyering@redhat.com>
6040
6041 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6042 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6043 return ssize_t not "int", and use size_t as the buffer length.
6044 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6045 * gnutls.h: Update declarations.
6046 * process.c (read_process_output): Use ssize_t, to match.
6047 (send_process): Likewise.
6048
6049 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6050
6051 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6052
6053 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6054
6055 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6056 Use unsigned char, to match FcChar8 type definition.
6057
6058 * xterm.c (handle_one_xevent):
6059 * xmenu.c (create_and_show_popup_menu):
6060 * xselect.c (x_decline_selection_request)
6061 (x_reply_selection_request): Avoid type-punned deref of X events.
6062
6063 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6064
6065 Fix some uses of `int' instead of EMACS_INT.
6066 * search.c (string_match_1, fast_string_match)
6067 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6068 (scan_buffer, find_next_newline_no_quit)
6069 (find_before_next_newline, search_command, Freplace_match)
6070 (Fmatch_data): Make some `int' variables be EMACS_INT.
6071
6072 * xdisp.c (display_count_lines): 3rd argument and return value now
6073 EMACS_INT. All callers changed.
6074 (pint2hrstr): Last argument is now EMACS_INT.
6075
6076 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6077 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6078 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6079 (decode_coding_utf_16, decode_coding_emacs_mule)
6080 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6081 (decode_coding_ccl, decode_coding_charset)
6082 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6083 (decode_coding_iso_2022, decode_coding_emacs_mule)
6084 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6085 <char_offset, last_offset>: Declare EMACS_INT.
6086 (encode_coding_utf_8, encode_coding_utf_16)
6087 (encode_coding_emacs_mule, encode_invocation_designation)
6088 (encode_designation_at_bol, encode_coding_iso_2022)
6089 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6090 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6091 Declare EMACS_INT.
6092 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6093 (encode_invocation_designation): Last argument P_NCHARS is now
6094 EMACS_INT.
6095 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6096 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6097
6098 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6099 All users changed.
6100
6101 * ccl.c (Fccl_execute_on_string): Declare some variables
6102 EMACS_INT.
6103
6104 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6105
6106 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6107
6108 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6109
6110 * process.c (Fformat_network_address): Doc fix.
6111
6112 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6113
6114 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6115
6116 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6117
6118 * keyboard.c (read_char): Call Lisp function help-form-show,
6119 instead of using internal_with_output_to_temp_buffer.
6120 (Qhelp_form_show): New var.
6121 (syms_of_keyboard): Use DEFSYM macro.
6122
6123 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6124
6125 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6126
6127 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6128
6129 * process.c (Flist_processes): Remove to Lisp.
6130 (list_processes_1): Delete.
6131
6132 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6133
6134 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6135
6136 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6137
6138 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6139
6140 Fix more problems found by GCC 4.6.0's static checks.
6141
6142 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6143
6144 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6145
6146 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6147
6148 * xdisp.c (vmessage): Mark as a printf-like function.
6149
6150 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6151
6152 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6153
6154 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6155 printf-like functions.
6156 (tiff_load): Add casts to remove these marks before passing them
6157 to system-supplied API.
6158
6159 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6160
6161 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6162 This avoids several warnings with gcc -Wstrict-overflow.
6163 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6164 directly, rather than having caller test rule sign. This avoids
6165 some unnecessary tests.
6166 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6167 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6168 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6169
6170 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6171 (xfont_open): Avoid unnecessary tests.
6172
6173 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6174
6175 * composite.h, composite.c (composition_gstring_put_cache):
6176 Use EMACS_INT, not int, for length.
6177
6178 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6179 breaking out part of COMPOSITION_DECODE_RULE.
6180 (COMPOSITION_DECODE_RULE): Use it.
6181 * composite.c (get_composition_id): Remove unused local vars,
6182 by using the new macro.
6183
6184 * textprop.c (set_text_properties_1): Change while to do-while,
6185 since the condition is always true at first.
6186
6187 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6188 (interval_deletion_adjustment): Return unsigned value.
6189 All uses changed.
6190
6191 * process.c (list_processes_1, create_pty, read_process_output):
6192 (exec_sentinel): Remove vars that were set but not used.
6193 (create_pty): Remove unnecessary "volatile"s.
6194 (Fnetwork_interface_info): Avoid possibility of int overflow.
6195 (read_process_output): Do adaptive read buffering even if carryover.
6196 (read_process_output): Simplify nbytes computation if buffered.
6197
6198 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6199
6200 * syntax.c (scan_words): Remove var that was set but not used.
6201 (update_syntax_table): Use unsigned instead of int.
6202
6203 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6204 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6205 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6206
6207 * print.c (print_error_message): Avoid int overflow.
6208
6209 * font.c (font_list_entities): Redo for clarity,
6210 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6211
6212 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6213 (font_score): Avoid potential overflow in diff calculation.
6214
6215 * fns.c (substring_both): Remove var that is set but not used.
6216 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6217
6218 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6219
6220 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6221 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6222 can always succeed if overflow has undefined behavior.
6223
6224 * search.c (boyer_moore, wordify): Remove vars set but not used.
6225 (wordify): Omit three unnecessary tests.
6226
6227 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6228 All callers changed. This avoids the need for an unused var.
6229
6230 * casefiddle.c (casify_region): Remove var that is set but not used.
6231
6232 * dired.c (file_name_completion): Remove var that is set but not used.
6233
6234 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6235
6236 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6237 (Finsert_file_contents): Remove unnecessary code checking fd.
6238
6239 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6240 Check for integer overflow on size calculations.
6241
6242 * buffer.c (Fprevious_overlay_change): Remove var that is set
6243 but not used.
6244
6245 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6246 Remove vars that are set but not used.
6247 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6248 (timer_check_2): Mark vars as initialized.
6249
6250 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6251
6252 * image.c (lookup_image): Remove var that is set but not used.
6253 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6254
6255 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6256 that are set but not used.
6257
6258 * xfns.c (make_invisible_cursor): Don't return garbage
6259 if XCreateBitmapFromData fails (Bug#8410).
6260
6261 * xselect.c (x_get_local_selection, x_handle_property_notify):
6262 Remove vars that are set but not used.
6263
6264 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6265 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6266
6267 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6268 Remove var that is set but not used.
6269 (scroll_bar_windows_size): Now size_t, not int.
6270 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6271 Check for overflow.
6272
6273 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6274 (map_tty_color) [!defined MSDOS]: Likewise.
6275
6276 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6277
6278 * coding.c: Remove vars that are set but not used.
6279 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6280 All callers changed.
6281 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6282 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6283 (decode_coding_charset): Remove vars that are set but not used.
6284
6285 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6286 that is set but not used.
6287
6288 * print.c (print_object): Remove var that is set but not used.
6289
6290 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6291 The gnulib version avoids calling malloc in the usual case,
6292 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6293 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6294 * filelock.c (current_lock_owner): Likewise.
6295 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6296 * sysdep.c: Include allocator.h, careadlinkat.h.
6297 (emacs_no_realloc_allocator): New static constant.
6298 (emacs_readlink): New function.
6299 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6300 ../lib/careadlinkat.h.
6301
6302 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6303
6304 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6305 first non-nil return value).
6306
6307 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6308
6309 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6310 if not defined (Bug#8403).
6311
6312 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6313
6314 * xdisp.c (display_count_lines): Remove parameter `start',
6315 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6316 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6317 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6318 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6319 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6320 and thereabouts. All callers changed.
6321 (get_per_char_metric): Remove parameter `f', unused since
6322 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6323
6324 2011-04-02 Jim Meyering <meyering@redhat.com>
6325
6326 do not dereference NULL upon failed strdup
6327 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6328 (ns_get_family): Likewise.
6329
6330 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6331
6332 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6333
6334 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6335
6336 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6337 later (Bug#8403).
6338
6339 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6340
6341 Add lexical binding.
6342
6343 * window.c (Ftemp_output_buffer_show): New fun.
6344 (Fsave_window_excursion):
6345 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6346
6347 * lread.c (lisp_file_lexically_bound_p): New function.
6348 (Fload): Bind Qlexical_binding.
6349 (readevalloop): Remove `evalfun' arg.
6350 Bind Qinternal_interpreter_environment.
6351 (Feval_buffer): Bind Qlexical_binding.
6352 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6353 Mark as dynamic.
6354 (syms_of_lread): Declare `lexical-binding'.
6355
6356 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6357
6358 * keyboard.c (eval_dyn): New fun.
6359 (menu_item_eval_property): Use it.
6360
6361 * image.c (parse_image_spec): Use Ffunctionp.
6362
6363 * fns.c (concat, mapcar1): Accept byte-code-functions.
6364
6365 * eval.c (Fsetq): Handle lexical vars.
6366 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6367 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6368 (FletX, Flet): Obey lexical binding.
6369 (Fcommandp): Handle closures.
6370 (Feval): New `lexical' arg.
6371 (eval_sub): New function extracted from Feval. Use it almost
6372 everywhere where Feval was used. Look up vars in lexical env.
6373 Handle closures.
6374 (Ffunctionp): Move from subr.el.
6375 (Ffuncall): Handle closures.
6376 (apply_lambda): Remove `eval_flags'.
6377 (funcall_lambda): Handle closures and new byte-code-functions.
6378 (Fspecial_variable_p): New function.
6379 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6380 but without exporting it to Lisp.
6381
6382 * doc.c (Fdocumentation, store_function_docstring):
6383 * data.c (Finteractive_form): Handle closures.
6384
6385 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6386 interactive spec.
6387
6388 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6389 New byte-codes.
6390 (exec_byte_code): New function extracted from Fbyte_code to handle new
6391 calling convention for byte-code-functions. Add new byte-codes.
6392
6393 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6394
6395 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6396
6397 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6398
6399 * xdisp.c (redisplay_internal): Fix prototype.
6400
6401 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6402
6403 * xdisp.c (SCROLL_LIMIT): New macro.
6404 (try_scrolling): Use it when setting scroll_limit.
6405 Limit scrolling to 100 screen lines.
6406 (redisplay_window): Even when falling back on "recentering",
6407 position point in the window according to scroll-conservatively,
6408 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6409
6410 (try_scrolling): When point is above the window, allow searching
6411 as far as scroll_max, or one screenful, to compute vertical
6412 distance from PT to the scroll margin position. This prevents
6413 try_scrolling from unnecessarily failing when
6414 scroll-conservatively is set to a value slightly larger than the
6415 window height. Clean up the case of PT below the margin at bottom
6416 of window: scroll_max can no longer be INT_MAX. When aggressive
6417 scrolling is in use, don't let point enter the opposite scroll
6418 margin as result of the scroll.
6419 (syms_of_xdisp) <scroll-conservatively>: Document the
6420 threshold of 100 lines for never-recentering scrolling.
6421
6422 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6423
6424 * dispextern.h (move_it_by_lines):
6425 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6426 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6427 (message_log_check_duplicate): Remove parameters `prev_bol' and
6428 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6429 (redisplay_internal): Remove parameter `preserve_echo_area',
6430 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6431
6432 * indent.c (Fvertical_motion):
6433 * window.c (window_scroll_pixel_based, Frecenter):
6434 Don't pass `need_y_p' to `move_it_by_lines'.
6435
6436 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6437
6438 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6439 steal a few bits to be more compact.
6440 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6441 Remove unneeded casts.
6442
6443 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6444
6445 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6446
6447 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6448 binding" message (bug#7967).
6449
6450 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6451
6452 Fix more problems found by GCC 4.6.0's static checks.
6453
6454 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6455 Remove unused local var.
6456
6457 * editfns.c (Fmessage_box): Remove unused local var.
6458
6459 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6460 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6461 Omit unused local vars.
6462 * window.c (shrink_windows): Omit unused local var.
6463 * menu.c (digest_single_submenu): Omit unused local var.
6464 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6465 Omit unused local var.
6466
6467 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6468 Don't assume string length fits in int.
6469 (keyremap_step, read_key_sequence): Use size_t for sizes.
6470 (read_key_sequence): Don't check last_real_key_start redundantly.
6471
6472 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6473 instead of alloca (Bug#8344).
6474
6475 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6476 (Fbacktrace_frame): Don't assume nframes fits in int.
6477
6478 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6479
6480 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6481 concerns.
6482
6483 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6484
6485 * cm.c (calccost): Turn while-do into do-while, for clarity.
6486
6487 * keyboard.c (syms_of_keyboard): Use the same style as later
6488 in this function when indexing through an array. This also
6489 works around GCC bug 48267.
6490
6491 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6492
6493 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6494
6495 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6496 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6497
6498 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6499 This avoids undefined behavior on integer overflow, and is a bit
6500 more convenient anyway since it is compared to a size_t variable.
6501
6502 Variadic C functions now count arguments with size_t, not int.
6503 This avoids an unnecessary limitation on 64-bit machines, which
6504 caused (substring ...) to crash on large vectors (Bug#8344).
6505 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6506 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6507 All variadic functions and their callers changed accordingly.
6508 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6509 * data.c (arith_driver, float_arith_driver): Likewise.
6510 * editfns.c (general_insert_function): Likewise.
6511 * eval.c (struct backtrace.nargs, interactive_p)
6512 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6513 (funcall_lambda, mark_backtrace): Likewise.
6514 * fns.c (concat): Likewise.
6515 * frame.c (x_set_frame_parameters): Likewise.
6516 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6517 0 if not found, not -1. All callers changed.
6518
6519 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6520 (stack_copy_size): Now size_t, not int.
6521 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6522
6523 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6524
6525 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6526 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6527 All callers changed.
6528
6529 * lisp.h (multibyte_char_to_unibyte):
6530 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6531 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6532 * character.h (CHAR_TO_BYTE8):
6533 * cmds.c (internal_self_insert):
6534 * editfns.c (general_insert_function):
6535 * keymap.c (push_key_description):
6536 * search.c (Freplace_match):
6537 * xdisp.c (message_dolog, set_message_1): All callers changed.
6538
6539 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6540
6541 * keyboard.c (safe_run_hook_funcall): New function.
6542 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6543 don't set the hook to nil, but remove the offending function instead.
6544 (Qcommand_hook_internal): Remove, unused.
6545 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6546 Vcommand_hook_internal.
6547
6548 * eval.c (enum run_hooks_condition): Remove.
6549 (funcall_nil, funcall_not): New functions.
6550 (run_hook_with_args): Call each function through a `funcall' argument.
6551 Remove `cond' argument, now redundant.
6552 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6553 (Frun_hook_with_args_until_failure): Adjust accordingly.
6554 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6555
6556 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6557
6558 * dispextern.h (string_buffer_position): Remove declaration.
6559
6560 * print.c (strout): Remove parameter `multibyte', unused since
6561 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6562
6563 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6564 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6565 All callers changed.
6566
6567 * w32.c (_wsa_errlist): Use braces for struct initializers.
6568
6569 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6570 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6571 All callers changed.
6572 (string_buffer_position): Likewise. Also, make static (it's never
6573 used outside xdisp.c).
6574 (cursor_row_p): Remove parameter `w', unused since
6575 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6576 (decode_mode_spec): Remove parameter `precision', introduced during
6577 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6578 All callers changed.
6579
6580 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6581
6582 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6583
6584 2011-03-27 Anders Lindgren <andlind@gmail.com>
6585
6586 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6587 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6588 (ns_update_auto_hide_menu_bar): New functions.
6589 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6590 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6591 ns_constrain_all_frames.
6592 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6593 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6594
6595 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6596
6597 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6598
6599 2011-03-27 Glenn Morris <rgm@gnu.org>
6600
6601 * syssignal.h: Replace RETSIGTYPE with void.
6602 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6603 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6604 Replace SIGTYPE with void everywhere.
6605 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6606 * s/template.h (SIGTYPE): Remove commented out definition.
6607
6608 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6609
6610 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6611 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6612
6613 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6614
6615 * w32.c (read_unc_volume): Use parameter `henum', instead of
6616 global variable `wget_enum_handle'.
6617
6618 * keymap.c (describe_vector): Remove parameters `indices' and
6619 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6620 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6621
6622 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6623
6624 * keyboard.c (timer_check): Remove parameter `do_it_now',
6625 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6626 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6627 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6628
6629 * keyboard.c (read_char):
6630 * w32menu.c (w32_menu_display_help):
6631 * xmenu.c (show_help_event, menu_help_callback):
6632 Adjust calls to `show_help_echo'.
6633
6634 * gtkutil.c (xg_maybe_add_timer):
6635 * keyboard.c (readable_events):
6636 * process.c (wait_reading_process_output):
6637 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6638
6639 * insdel.c (adjust_markers_gap_motion):
6640 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6641 (gap_left, gap_right): Don't call it.
6642
6643 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6644
6645 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6646 incurred during fontification.
6647
6648 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6649
6650 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6651 (DEFVAR_PER_BUFFER): Don't pass it.
6652
6653 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6654 (scrolling_window): Don't pass it.
6655
6656 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6657
6658 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6659
6660 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6661 and `suffix'.
6662 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6663 of variables specific to SELinux and computation of `encoded_absname'.
6664
6665 * image.c (XPutPixel): Remove unused variable `height'.
6666
6667 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6668
6669 * unexw32.c (get_section_info): Remove unused variable `section'.
6670
6671 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6672 (system_process_attributes): Remove unused variable `sess'.
6673 (sys_read): Remove unused variable `err'.
6674
6675 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6676 (w32_wnd_proc): Remove unused variable `isdead'.
6677 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6678 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6679 (x_create_tip_frame): Remove unused variable `tem'.
6680
6681 * w32inevt.c (w32_console_read_socket):
6682 Remove unused variable `no_events'.
6683
6684 * w32term.c (x_draw_composite_glyph_string_foreground):
6685 Remove unused variable `width'.
6686
6687 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6688
6689 * w32term.c (x_set_glyph_string_clipping):
6690 Don't pass uninitialized region to CombineRgn.
6691
6692 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6693
6694 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6695 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6696 (Fx_close_connection): Remove unused variable `i'.
6697
6698 * w32font.c (w32font_draw): Return number of glyphs.
6699 (w32font_open_internal): Remove unused variable `i'.
6700 (w32font_driver): Add missing initializer.
6701
6702 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6703 (fill_in_menu): Remove unused variable `items_added'.
6704
6705 * w32term.c (last_mouse_press_frame): Remove static global variable.
6706 (w32_clip_to_row): Remove unused variable `f'.
6707 (x_delete_terminal): Remove unused variable `i'.
6708
6709 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6710 (NOTHING): Remove unused static global variable.
6711 (uniscribe_check_otf): Remove unused variable `table'.
6712 (uniscribe_font_driver): Add missing initializers.
6713
6714 2011-03-23 Julien Danjou <julien@danjou.info>
6715
6716 * term.c (Fsuspend_tty, Fresume_tty):
6717 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6718 * window.c (temp_output_buffer_show):
6719 * insdel.c (signal_before_change):
6720 * frame.c (Fhandle_switch_frame):
6721 * fileio.c (Fdo_auto_save):
6722 * emacs.c (Fkill_emacs):
6723 * editfns.c (save_excursion_restore):
6724 * cmds.c (internal_self_insert):
6725 * callint.c (Fcall_interactively):
6726 * buffer.c (Fkill_all_local_variables):
6727 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6728 Use Frun_hooks.
6729 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6730 unconditionnaly since it does the check itself.
6731
6732 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6733
6734 Fix more problems found by GCC 4.5.2's static checks.
6735
6736 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6737 the first time through the loop, since we know p0 < p1 then.
6738 This also avoids a gcc -Wstrict-overflow warning.
6739
6740 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6741 leading to a memory leak, possible in functions like
6742 load_charset_map_from_file that can allocate an unbounded number
6743 of objects (Bug#8318).
6744
6745 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6746 that could (at least in theory) be that large.
6747
6748 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6749 This is less likely to overflow, and avoids undefined behavior if
6750 overflow does occur. All callers changed. Use strtoul to scan
6751 for the unsigned long integer.
6752 (pint2hrstr): Simplify and tune code slightly.
6753 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6754
6755 * scroll.c (do_scrolling): Work around GCC bug 48228.
6756 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6757
6758 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6759 This also avoids a warning with gcc -Wstrict-overflow.
6760 (validate_x_resource_name): Simplify count usage.
6761 This also avoids a warning with gcc -Wstrict-overflow.
6762
6763 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6764 fail (Bug#8306).
6765
6766 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6767
6768 * process.c (Fmake_network_process): Use socklen_t, not int,
6769 where POSIX says socklen_t is required in portable programs.
6770 This fixes a porting bug on hosts like 64-bit HP-UX, where
6771 socklen_t is wider than int (Bug#8277).
6772 (Fmake_network_process, server_accept_connection):
6773 (wait_reading_process_output, read_process_output):
6774 Likewise.
6775
6776 * process.c: Rename or move locals to avoid shadowing.
6777 (list_processes_1, Fmake_network_process):
6778 (read_process_output_error_handler, exec_sentinel_error_handler):
6779 Rename or move locals.
6780 (Fmake_network_process): Define label "retry_connect" only if needed.
6781 (Fnetwork_interface_info): Fix pointer signedness.
6782 (process_send_signal): Add cast to avoid pointer signedness problem.
6783 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6784 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6785
6786 Make tparam.h and terminfo.c consistent.
6787 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6788 Include tparam.h instead, since it declares them.
6789 * cm.h (PC): Remove extern decl; tparam.h now does this.
6790 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6791 * terminfo.c: Include tparam.h, to check interfaces.
6792 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6793 (tparam): Adjust signature to match interface in tparam.h;
6794 this removes some undefined behavior. Check that outstring and len
6795 are zero, which they always are with Emacs.
6796 * tparam.h (PC, BC, UP): New extern decls.
6797
6798 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6799 (xftfont_open): Rename locals to avoid shadowing.
6800
6801 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6802 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6803 (OTF_TAG_SYM): Omit macro if not needed.
6804 (ftfont_list): Remove unused local.
6805 (get_adstyle_property, ftfont_pattern_entity):
6806 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6807 Rename locals to avoid shadowing.
6808
6809 * xfont.c (xfont_list_family): Mark var as initialized.
6810
6811 * xml.c (make_dom): Now static.
6812
6813 * composite.c (composition_compute_stop_pos): Rename local to
6814 avoid shadowing.
6815 (composition_reseat_it): Remove unused locals.
6816 (find_automatic_composition, composition_adjust_point): Likewise.
6817 (composition_update_it): Mark var as initialized.
6818 (find_automatic_composition): Mark vars as initialized,
6819 with a FIXME (Bug#8290).
6820
6821 character.h: Rename locals to avoid shadowing.
6822 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6823 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6824 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6825 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6826 to avoid shadowing.
6827
6828 * textprop.c (property_change_between_p): Remove; unused.
6829
6830 * intervals.c (interval_start_pos): Now static.
6831
6832 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6833
6834 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6835 Rename locals to avoid shadowing.
6836
6837 * sound.c (wav_play, au_play, Fplay_sound_internal):
6838 Fix pointer signedness.
6839 (alsa_choose_format): Remove unused local var.
6840 (wav_play): Initialize a variable to 0, to prevent undefined
6841 behavior (Bug#8278).
6842
6843 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6844
6845 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6846
6847 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6848 clobbering (Bug#8298).
6849 * sysdep.c (sys_subshell): Likewise.
6850 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6851
6852 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6853 This should get cleaned up, so that child_setup has the
6854 same signature on all platforms.
6855
6856 * callproc.c (call_process_cleanup): Now static.
6857 (relocate_fd): Rename locals to avoid shadowing.
6858
6859 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6860
6861 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6862 not to be necessary, and produces flickering.
6863
6864 2011-03-20 Glenn Morris <rgm@gnu.org>
6865
6866 * config.in: Remove file.
6867
6868 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6869
6870 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6871 are now in src/globals.h.
6872 (syms_of_minibuf): Remove spurious & from previous change.
6873
6874 2011-03-20 Leo <sdl.web@gmail.com>
6875
6876 * minibuf.c (completing-read-function): New variable.
6877 (completing-read-default): Rename from completing-read.
6878 (completing-read): Call completing-read-function.
6879
6880 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6881
6882 * xfaces.c (Fx_load_color_file):
6883 Read color file from absolute filename (bug#8250).
6884
6885 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6886
6887 * makefile.w32-in: Update dependencies.
6888
6889 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6890
6891 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6892
6893 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6894
6895 Fix more problems found by GCC 4.5.2's static checks.
6896
6897 * process.c (make_serial_process_unwind, send_process_trap):
6898 (sigchld_handler): Now static.
6899
6900 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6901 That way, the code declares only the vars that it needs.
6902 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6903 * s/cygwin.h (PTY_ITERATION): Likewise.
6904 * s/darwin.h (PTY_ITERATION): Likewise.
6905 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6906
6907 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6908 * process.c (allocate_pty): Don't declare stb unless it's needed.
6909
6910 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6911 (CONSTANTLIM): Remove; unused.
6912 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6913 Define only if needed.
6914
6915 * unexelf.c (unexec): Name an expression,
6916 to avoid gcc -Wbad-function-cast warning.
6917 Use a different way to cause a compilation error if anyone uses
6918 n rather than nn, a way that does not involve shadowing.
6919 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6920
6921 * deps.mk (unexalpha.o): Remove; unused.
6922
6923 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6924 * unexec.h: New file.
6925 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6926 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6927 Depend on unexec.h.
6928 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6929 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6930 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6931 Change as necessary to match prototype in unexec.h.
6932
6933 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6934 shadowing.
6935 (back_comment, skip_chars): Mark vars as initialized.
6936
6937 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6938 Rename locals to avoid shadowing.
6939
6940 * lread.c (read1): Rewrite so as not to use empty "else".
6941 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6942
6943 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6944
6945 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6946 warning when compiling print.c.
6947
6948 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6949 instead of using an uninitialized var.
6950 (font_sort_entities): Mark var as initialized.
6951
6952 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6953
6954 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6955 pointers to constants.
6956 (font_parse_fcname): Remove unused vars.
6957 (font_delete_unmatched): Now static.
6958 (font_get_spec): Remove; unused.
6959 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6960 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6961 Rename or move locals to avoid shadowing.
6962
6963 * fns.c (require_nesting_list, require_unwind): Now static.
6964 (Ffillarray): Rename locals to avoid shadowing.
6965
6966 * floatfns.c (domain_error2): Define only if needed.
6967 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6968
6969 * alloc.c (mark_backtrace): Move decl from here ...
6970 * lisp.h: ... to here, so that it can be checked.
6971
6972 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6973 (Fdefvar): Rewrite so as not to use empty "else".
6974 (lisp_indirect_variable): Name an expression,
6975 to avoid gcc -Wbad-function-cast warning.
6976 (Fdefvar): Rename locals to avoid shadowing.
6977
6978 * callint.c (quotify_arg, quotify_args): Now static.
6979 (Fcall_interactively): Rename locals to avoid shadowing.
6980 Use const pointer when appropriate.
6981
6982 * lisp.h (get_system_name, get_operating_system_release):
6983 Move decls here, to check interfaces.
6984 * process.c (get_operating_system_release): Move decl to lisp.h.
6985 * xrdb.c (get_system_name): Likewise.
6986 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6987 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6988 some of which prompt warnings from gcc -Wbad-function-cast.
6989 (Fformat_time_string, Fencode_time, Finsert_char):
6990 (Ftranslate_region_internal, Fformat):
6991 Rename or remove local vars to avoid shadowing.
6992 (Ftranslate_region_internal): Mark var as initialized.
6993
6994 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6995 avoid shadowing.
6996
6997 * lisp.h (eassert): Check that the argument compiles, even if
6998 ENABLE_CHECKING is not defined.
6999
7000 * data.c (Findirect_variable): Name an expression, to avoid
7001 gcc -Wbad-function-cast warning.
7002 (default_value, arithcompare, arith_driver, arith_error): Now static.
7003 (store_symval_forwarding): Rename local to avoid shadowing.
7004 (Fmake_variable_buffer_local, Fmake_local_variable):
7005 Mark variables as initialized.
7006 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7007
7008 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7009 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7010 Rename locals to avoid shadowing.
7011 (mark_stack): Move local variables into the #ifdef region where
7012 they're used.
7013 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7014 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7015 needed otherwise.
7016 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7017 (GC_STRING_CHARS): Remove; not used.
7018 (Fmemory_limit): Cast sbrk's returned value to char *.
7019
7020 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7021 avoids undefined behavior in theory.
7022
7023 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7024
7025 Use functions, not macros, for up- and down-casing (Bug#8254).
7026 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7027 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7028 to use the following functions instead of these macros.
7029 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7030 EMACS_INT, since callers assume the returned value fits in int.
7031 (upcase1): Likewise, for UPCASE_TABLE.
7032 (uppercasep, lowercasep, upcase): New static inline functions.
7033 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7034 the race-condition problem in the old DOWNCASE.
7035
7036 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7037 Rename locals to avoid shadowing.
7038 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7039 (regex_compile, re_search_2, re_match_2_internal):
7040 Remove unused local vars.
7041 (FREE_VAR): Rewrite so as not to use empty "else",
7042 which gcc can warn about.
7043 (regex_compile, re_match_2_internal): Mark locals as initialized.
7044 (RETALLOC_IF): Define only if needed.
7045 (WORDCHAR_P): Likewise. This one is never needed, but is used
7046 only in a comment talking about a compiler bug, so put inside
7047 the #if 0 of that comment.
7048 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7049 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7050 Remove; unused.
7051
7052 * search.c (boyer_moore): Rename locals to avoid shadowing.
7053 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7054 (PREV_CHAR_BOUNDARY): Likewise.
7055
7056 * search.c (simple_search): Remove unused var.
7057
7058 * dired.c (compile_pattern): Move decl from here ...
7059 * lisp.h: ... to here, so that it can be checked.
7060 (struct re_registers): New forward decl.
7061
7062 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7063
7064 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7065 All uses changed.
7066 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7067 Rename locals to avoid shadowing.
7068 (Fvertical_motion): Mark locals as initialized.
7069
7070 * casefiddle.c (casify_object, casify_region): Now static.
7071 (casify_region): Mark local as initialized.
7072
7073 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7074
7075 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7076 New macros, so that the caller can use some names other than
7077 gcpro1, gcpro2, etc.
7078 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7079 of the new macros.
7080 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7081 argument, for consistency with GCPRO2_VAR, etc: it is now the
7082 prefix of the variable, not the variable itself. All uses
7083 changed.
7084 * dired.c (directory_files_internal, file_name_completion):
7085 Rename locals to avoid shadowing.
7086
7087 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7088 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7089 dired.c's scmp function, had undefined behavior.
7090 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7091 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7092 * buffer.h: ... to here, because these macros use current_buffer,
7093 and the new implementation with inline functions needs to have
7094 current_buffer in scope now, rather than later when the macros
7095 are used.
7096 (downcase, upcase1): New static inline functions.
7097 (DOWNCASE, UPCASE1): Reimplement using these functions.
7098 This avoids undefined behavior in expressions like
7099 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7100 from race conditions in accessing the global variables
7101 case_temp1 and case_temp2.
7102 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7103 * lisp.h (case_temp1, case_temp2): Remove their decls.
7104 * character.h (ASCII_CHAR_P): Move from here ...
7105 * lisp.h: ... to here, so that the inline functions mentioned
7106 above can use them.
7107
7108 * dired.c (directory_files_internal_unwind): Now static.
7109
7110 * fileio.c (file_name_as_directory, directory_file_name):
7111 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7112 Now static.
7113 (file_name_as_directory): Use const pointers when appropriate.
7114 (Fexpand_file_name): Likewise. In particular, newdir might
7115 point at constant storage, so make it a const pointer.
7116 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7117 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7118 signedness issues.
7119 (Fset_file_times, Finsert_file_contents, auto_save_error):
7120 Rename locals to avoid shadowing.
7121
7122 * minibuf.c (choose_minibuf_frame_1): Now static.
7123 (Ftry_completion, Fall_completions): Rename or remove locals
7124 to avoid shadowing.
7125
7126 * marker.c (bytepos_to_charpos): Remove; unused.
7127
7128 * lisp.h (verify_bytepos, count_markers): New decls,
7129 so that gcc does not warn that these functions aren't declared.
7130
7131 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7132 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7133 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7134 (copy_text): Remove unused local var.
7135
7136 * filelock.c (within_one_second): Now static.
7137 (lock_file_1): Rename local to avoid shadowing.
7138
7139 * buffer.c (fix_overlays_before): Mark locals as initialized.
7140 (fix_start_end_in_overlays): Likewise. This function should be
7141 simplified by using pointers-to-pointers, but that's a different
7142 matter.
7143 (switch_to_buffer_1): Now static.
7144 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7145 (report_overlay_modification): Rename locals to avoid shadowing.
7146
7147 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7148 Fix pointer signedness issue.
7149 (sys_subshell): Mark local as volatile if checking for lint,
7150 to suppress a gcc -Wclobbered warning that does not seem to be right.
7151 (MAXPATHLEN): Define only if needed.
7152
7153 * process.c (serial_open, serial_configure): Move decls from here ...
7154 * systty.h: ... to here, so that they can be checked.
7155
7156 * fns.c (get_random, seed_random): Move extern decls from here ...
7157 * lisp.h: ... to here, so that they can be checked.
7158
7159 * sysdep.c (reset_io): Now static.
7160 (wait_for_termination_signal): Remove; unused.
7161
7162 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7163 (copy_keymap_item, append_key, push_text_char_description):
7164 Now static.
7165 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7166 (DENSE_TABLE_SIZE): Remove; unused.
7167 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7168 (describe_map_tree):
7169 Rename locals to avoid shadowing.
7170
7171 * keyboard.c: Declare functions static if they are not used elsewhere.
7172 (echo_char, echo_dash, cmd_error, top_level_2):
7173 (poll_for_input, handle_async_input): Now static.
7174 (read_char, kbd_buffer_get_event, make_lispy_position):
7175 (make_lispy_event, make_lispy_movement, apply_modifiers):
7176 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7177 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7178 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7179 (read_key_sequence, read_char): Mark locals as initialized.
7180 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7181
7182 * keyboard.h (make_ctrl_char): New decl.
7183 (mark_kboards): Move decl here ...
7184 * alloc.c (mark_kboards): ... from here.
7185
7186 * lisp.h (force_auto_save_soon): New decl.
7187
7188 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7189 (DEFINE_DUMMY_FUNCTION): New macro.
7190 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7191 Use it.
7192 (main): Add casts to avoid warnings
7193 if GCC considers string literals to be constants.
7194
7195 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7196
7197 * dbusbind.c: Pointer signedness fixes.
7198 (xd_signature, xd_append_arg, xd_initialize):
7199 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7200 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7201 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7202 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7203
7204 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7205 if GCC considers string literals to be constants.
7206 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7207
7208 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7209
7210 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7211 (print_preprocess, print_object): New macro to fix last change.
7212
7213 * print.c (print_preprocess): Don't forget font objects.
7214
7215 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7216
7217 * emacs.c (USAGE3): Doc fixes.
7218
7219 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7220
7221 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7222 structure.
7223
7224 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7225
7226 * lisp.h (VWindow_system, Qfile_name_history):
7227 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7228 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7229 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7230
7231 * w32select.c: Don't #include "keyboard.h".
7232 (run_protected): Add extern declaration for waiting_for_input.
7233
7234 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7235 * w32console.c (detect_input_pending, read_input_pending)
7236 (encode_terminal_code):
7237 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7238 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7239 (w32_system_caret_y, Qfile_name_history):
7240 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7241 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7242 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7243 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7244 * w32proc.c (Qlocal, report_file_error):
7245 * w32term.c (Vwindow_system, updating_frame):
7246 * w32uniscribe.c (initialized, uniscribe_font_driver):
7247 Remove unneeded extern declarations.
7248
7249 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7250
7251 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7252
7253 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7254
7255 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7256 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7257 These macros can no longer be used for assignment.
7258
7259 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7260 Assign struct members directly, instead of using BUF_BEGV etc.
7261 (record_buffer_markers, fetch_buffer_markers): New functions for
7262 recording and fetching special buffer markers.
7263 (set_buffer_internal_1, set_buffer_temp): Use them.
7264
7265 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7266
7267 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7268
7269 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7270 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7271
7272 * xdisp.c (hscroll_window_tree):
7273 (reconsider_clip_changes): Use PT instead of BUF_PT.
7274
7275 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7276
7277 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7278 $(EMACS_ROOT)/lib/intprops.h.
7279
7280 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7281
7282 Fix more problems found by GCC 4.5.2's static checks.
7283
7284 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7285 to unsigned char * to avoid compiler diagnostic.
7286 (xg_free_frame_widgets): Make it clear that a local variable is
7287 needed only if USE_GTK_TOOLTIP.
7288 (gdk_window_get_screen): Make it clear that this macro is needed
7289 only if USE_GTK_TOOLTIP.
7290 (int_gtk_range_get_value): New function, which avoids a diagnostic
7291 from gcc -Wbad-function-cast.
7292 (xg_set_toolkit_scroll_bar_thumb): Use it.
7293 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7294 diagnostic from gcc -Wbad-function-cast.
7295 (get_utf8_string, xg_get_file_with_chooser):
7296 Rename locals to avoid shadowing.
7297 (create_dialog): Move locals to avoid shadowing.
7298
7299 * xgselect.c (xg_select): Remove unused var.
7300
7301 * image.c (four_corners_best): Mark locals as initialized.
7302 (gif_load): Initialize transparent_p to zero (Bug#8238).
7303 Mark another local as initialized.
7304 (my_png_error, my_error_exit): Mark with NO_RETURN.
7305
7306 * image.c (clear_image_cache): Now static.
7307 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7308 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7309 (x_edge_detection): Remove unnecessary cast that
7310 gcc -Wbad-function-cast diagnoses.
7311 (gif_load): Fix pointer signedness.
7312 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7313 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7314
7315 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7316
7317 Improve quality of tests for time stamp overflow.
7318 For example, without this patch (encode-time 0 0 0 1 1
7319 1152921504606846976) returns the obviously-bogus value (-948597
7320 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7321 reports time overflow. See
7322 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7323 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7324 * editfns.c: Include limits.h and intprops.h.
7325 (TIME_T_MIN, TIME_T_MAX): New macros.
7326 (time_overflow): Move earlier, to before first use.
7327 (hi_time, lo_time): New functions, for an accurate test for
7328 out-of-range times.
7329 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7330 (Fget_internal_run_time): Don't assume time_t fits in int.
7331 (make_time): Use list2 instead of Fcons twice.
7332 (Fdecode_time): More accurate test for out-of-range times.
7333 (check_tm_member): New function.
7334 (Fencode_time): Use it, to test for out-of-range times.
7335 (lisp_time_argument): Don't rely on undefined left-shift and
7336 right-shift behavior when checking for time stamp overflow.
7337
7338 * editfns.c (time_overflow): New function, refactoring common code.
7339 (Fformat_time_string, Fdecode_time, Fencode_time):
7340 (Fcurrent_time_string): Use it.
7341
7342 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7343 * dired.c (make_time): Move to ...
7344 * editfns.c (make_time): ... here.
7345 * systime.h: Note the move.
7346
7347 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7348
7349 * fringe.c (update_window_fringes): Remove unused variables.
7350
7351 * unexmacosx.c (copy_data_segment): Also copy __got section.
7352 (Bug#8223)
7353
7354 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7355
7356 * termcap.c [MSDOS]: Include "msdos.h".
7357 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7358 Constify `char *' arguments and their references according to
7359 prototypes in tparam.h.
7360
7361 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7362
7363 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7364 Adapt all references accordingly.
7365
7366 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7367
7368 2011-03-11 Tom Tromey <tromey@redhat.com>
7369
7370 * buffer.c (syms_of_buffer): Remove obsolete comment.
7371
7372 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7373
7374 * termhooks.h (encode_terminal_code): Declare prototype.
7375
7376 * msdos.c (encode_terminal_code): Don't declare prototype.
7377
7378 * term.c (encode_terminal_code): Now external again, used by
7379 w32console.c and msdos.c.
7380
7381 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7382 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7383
7384 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7385
7386 Fix some minor problems found by GCC 4.5.2's static checks.
7387
7388 * fringe.c (update_window_fringes): Mark locals as initialized
7389 (Bug#8227).
7390 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7391
7392 * alloc.c (mark_fringe_data): Move decl from here ...
7393 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7394 to check its interface.
7395 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7396
7397 * fontset.c (free_realized_fontset): Now static.
7398 (Fset_fontset_font): Rename local to avoid shadowing.
7399 (fontset_font): Mark local as initialized.
7400 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7401
7402 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7403
7404 * xselect.c (x_disown_buffer_selections): Remove; not used.
7405 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7406 (x_own_selection, Fx_disown_selection_internal): Rename locals
7407 to avoid shadowing.
7408 (x_handle_dnd_message): Remove local to avoid shadowing.
7409
7410 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7411 so that the caller can use some name other than gcpro1.
7412 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7413 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7414 (Fx_backspace_delete_keys_p):
7415 Use them to avoid shadowing, and rename vars to avoid shadowing.
7416 (x_decode_color, x_set_name, x_window): Now static.
7417 (Fx_create_frame): Add braces to silence GCC warning.
7418 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7419 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7420 Remove unused locals.
7421 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7422 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7423 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7424 macros.
7425
7426 * xterm.h (x_mouse_leave): New decl.
7427
7428 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7429 Remove unused functions.
7430 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7431 (x_calc_absolute_position): Now static.
7432 (XTread_socket): Don't define label "out" unless it's used.
7433 Don't declare local "event" unless it's used.
7434 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7435 unless they are used.
7436 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7437 (x_fatal_error_signal): Remove; not used.
7438 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7439 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7440 (x_error_catcher, x_connection_closed, x_error_handler):
7441 (x_error_quitter, xembed_send_message, x_iconify_frame):
7442 (my_log_handler): Rename locals to avoid shadowing.
7443 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7444 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7445
7446 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7447 Rename or move locals to avoid shadowing.
7448 (tty_defined_color, merge_face_heights): Now static.
7449 (free_realized_faces_for_fontset): Remove; not used.
7450 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7451 does not deduce is never used uninitialized.
7452 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7453 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7454
7455 * terminal.c (store_terminal_param): Now static.
7456
7457 * xmenu.c (menu_highlight_callback): Now static.
7458 (set_frame_menubar): Remove unused local.
7459 (xmenu_show): Rename parameter to avoid shadowing.
7460 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7461 since they might point to immutable storage.
7462 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7463 since it's unused otherwise.
7464
7465 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7466 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7467 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7468 avoids a gcc -Wuninitialized diagnostic.
7469 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7470 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7471 does not deduce are never used uninitialized.
7472
7473 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7474
7475 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7476 * window.c (window_loop, size_window):
7477 (run_window_configuration_change_hook, enlarge_window): Likewise.
7478
7479 * window.c (display_buffer): Now static.
7480 (size_window): Mark variables that gcc -Wuninitialized
7481 does not deduce are never used uninitialized.
7482 * window.h (check_all_windows): New decl, to forestall
7483 gcc -Wmissing-prototypes diagnostic.
7484 * dispextern.h (bidi_dump_cached_states): Likewise.
7485
7486 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7487 shadowing.
7488 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7489 Include <limits.h>.
7490 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7491 and to avoid gcc -Wuninitialized warning.
7492 (load_charset_map): Mark variables that gcc -Wuninitialized
7493 does not deduce are never used uninitialized.
7494 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7495
7496 * coding.c (coding_set_source, coding_set_destination):
7497 Use "else { /* comment */ }" rather than "else /* comment */;"
7498 for clarity, and to avoid gcc -Wempty-body warning.
7499 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7500 a block, when the outer 'i' will do.
7501 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7502 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7503 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7504 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7505 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7506 Rename locals to avoid shadowing.
7507 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7508 * coding.c (emacs_mule_char, encode_invocation_designation):
7509 Now static, since they're not used elsewhere.
7510 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7511 (decode_coding_object, encode_coding_object, detect_coding_system):
7512 (decode_coding_emacs_mule): Mark variables that gcc
7513 -Wuninitialized does not deduce are never used uninitialized.
7514 (detect_coding_iso_2022): Initialize a local variable that might
7515 be used uninitialized. Leave a FIXME because it's not clear that
7516 this initialization is needed. (Bug#8211)
7517 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7518 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7519 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7520 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7521 Remove unused macros.
7522
7523 * category.c (hash_get_category_set): Remove unused local var.
7524 (copy_category_table): Now static, since it's not used elsewhere.
7525 * character.c (string_count_byte8): Likewise.
7526
7527 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7528 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7529
7530 * chartab.c (copy_sub_char_table): Now static, since it's not used
7531 elsewhere.
7532 (sub_char_table_ref_and_range, char_table_ref_and_range):
7533 Rename locals to avoid shadowing.
7534 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7535
7536 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7537 (BIDI_BOB): Remove unused macro.
7538
7539 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7540 deduce are never used uninitialized.
7541 * term.c (encode_terminal_code): Likewise.
7542
7543 * term.c (encode_terminal_code): Now static. Remove unused local.
7544
7545 * tparam.h: New file.
7546 * term.c, tparam.h: Include it.
7547 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7548 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7549 Move these decls to tparam.h, and make them agree with what
7550 is actually in tparam.c. The previous trick of using incompatible
7551 decls in different modules does not conform to the C standard.
7552 All callers of tparam changed to use tparam's actual API.
7553 * tparam.c (tparam1, tparam, tgoto):
7554 Use const pointers where appropriate.
7555
7556 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7557 * cm.h (struct cm): Likewise.
7558 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7559 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7560 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7561 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7562 (turn_on_face, init_tty): Likewise.
7563 * termchar.h (struct tty_display_info): Likewise.
7564
7565 * term.c (term_mouse_position): Rename local to avoid shadowing.
7566
7567 * alloc.c (mark_ttys): Move decl from here ...
7568 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7569
7570 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7571
7572 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7573
7574 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7575
7576 * search.c (compile_pattern_1): Remove argument regp, unused since
7577 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7578 (compile_pattern): Don't pass it.
7579
7580 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7581
7582 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7583 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7584 for ! HAVE_GTK3.
7585 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7586
7587 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7588
7589 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7590 gdk_window_get_screen, gdk_window_get_geometry,
7591 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7592 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7593 (xg_get_pixbuf_from_pixmap): New function.
7594 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7595 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7596 Call xg_get_pixbuf_from_pixmap instead of
7597 gdk_pixbuf_get_from_drawable.
7598 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7599 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7600 (xg_check_special_colors): Use GtkStyleContext and its functions
7601 for HAVE_GTK3.
7602 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7603 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7604 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7605 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7606 Call gtk_widget_get_preferred_size.
7607 (xg_frame_resized): gdk_window_get_geometry only takes 5
7608 parameters.
7609 (xg_win_to_widget, xg_event_is_for_menubar):
7610 Call gdk_x11_window_lookup_for_display.
7611 (xg_set_widget_bg): New function.
7612 (delete_cb): New function.
7613 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7614 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7615 (xg_set_background_color): Call xg_set_widget_bg.
7616 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7617 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7618 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7619 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7620 if ! HAVE_GTK3.
7621 (update_frame_tool_bar): Call gtk_widget_hide.
7622 (xg_initialize): Use GDK_KEY_g.
7623
7624 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7625 if ! HAVE_GTK3
7626 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7627
7628 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7629 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7630 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7631
7632 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7633
7634 * w32xfns.c (select_palette): Check success of RealizePalette against
7635 GDI_ERROR, not zero.
7636
7637 See ChangeLog.11 for earlier changes.
7638
7639 ;; Local Variables:
7640 ;; coding: utf-8
7641 ;; End:
7642
7643 Copyright (C) 2011 Free Software Foundation, Inc.
7644
7645 This file is part of GNU Emacs.
7646
7647 GNU Emacs is free software: you can redistribute it and/or modify
7648 it under the terms of the GNU General Public License as published by
7649 the Free Software Foundation, either version 3 of the License, or
7650 (at your option) any later version.
7651
7652 GNU Emacs is distributed in the hope that it will be useful,
7653 but WITHOUT ANY WARRANTY; without even the implied warranty of
7654 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7655 GNU General Public License for more details.
7656
7657 You should have received a copy of the GNU General Public License
7658 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.