composite.c (find_automatic_composition): Fix previous change.
[bpt/emacs.git] / src / ChangeLog
1 2011-05-20 handa <handa@m17n.org>
2
3 * composite.c (find_automatic_composition): Fix previous change.
4
5 2011-05-18 Kenichi Handa <handa@m17n.org>
6
7 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9 (find_automatic_composition): Mostly rewrite for efficiency.
10
11 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
12
13 * makefile.w32-in: Update dependencies.
14
15 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
16
17 * menu.c: Include limits.h (fixes the MS-Windows build broken by
18 revision 104625).
19
20 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
21
22 Fix some integer overflow issues, such as string length overflow.
23
24 * insdel.c (count_size_as_multibyte): Check for string overflow.
25
26 * character.c (lisp_string_width): Check for string overflow.
27 Use EMACS_INT, not int, for string indexes and lengths; in
28 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
29 the resulting string length overflows an EMACS_INT; instead,
30 report a string overflow if no precision given. When checking for
31 precision exhaustion, use a check that cannot possibly have
32 integer overflow. (Bug#8675)
33 * character.h (lisp_string_width): Adjust to new signature.
34
35 * alloc.c (string_overflow): New function.
36 (Fmake_string): Use it. This doesn't change behavior, but saves
37 a few bytes and will simplify future changes.
38 * character.c (string_escape_byte8): Likewise.
39 * lisp.h (string_overflow): New decl.
40
41 Fixups, following up to the user-interface timestamp change.
42 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
43 for UI timestamps, instead of unsigned long.
44 * msdos.c (mouse_get_pos): Likewise.
45 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
46 * w32gui.h (Time): Define by including "systime.h" rather than by
47 declaring it ourselves. (Bug#8664)
48
49 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
50 * image.c (clear_image_cache): Likewise.
51
52 * term.c (term_mouse_position): Don't assume time_t wraparound.
53
54 Be more systematic about user-interface timestamps.
55 Before, the code sometimes used 'Time', sometimes 'unsigned long',
56 and sometimes 'EMACS_UINT', to represent these timestamps. This
57 change causes it to use 'Time' uniformly, as that's what X uses.
58 This makes the code easier to follow, and makes it easier to catch
59 integer overflow bugs such as Bug#8664.
60 * frame.c (Fmouse_position, Fmouse_pixel_position):
61 Use Time, not unsigned long, for user-interface timestamps.
62 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
63 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
64 * keyboard.h (last_event_timestamp): Likewise.
65 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
66 * menu.h (xmenu_show): Likewise.
67 * term.c (term_mouse_position): Likewise.
68 * termhooks.h (struct input_event.timestamp): Likewise.
69 (struct terminal.mouse_position_hook): Likewise.
70 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
71 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
72 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
73 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
74 what it was before.
75 * menu.h, termhooks.h: Include "systime.h", for Time.
76
77 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
78 Don't assume that the difference between two unsigned long values
79 can fit into an integer. At this point, we know button_down_time
80 <= event->timestamp, so the difference must be nonnegative, so
81 there's no need to cast the result if double-click-time is
82 nonnegative, as it should be; check that it's nonnegative, just in
83 case. This bug is triggered when events are more than 2**31 ms
84 apart (about 25 days). (Bug#8664)
85
86 * xselect.c (last_event_timestamp): Remove duplicate decl.
87 (x_own_selection): Remove needless cast to unsigned long.
88
89 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
90 that always fit in int. Use a sentinel instead of a counter, to
91 avoid a temp and to allay GCC's concerns about possible int overflow.
92 * frame.h (struct frame): Use int for menu_bar_items_used
93 instead of EMACS_INT, since it always fits in int.
94
95 * menu.c (grow_menu_items): Check for int overflow.
96
97 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
98
99 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
100 Before, the code was not consistent. These values cannot exceed
101 2**31 - 1 so there's no need to make them unsigned.
102 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
103 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
104 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
105 as modifiers.
106 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
107
108 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
109 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
110 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
111 presumably because the widths might not match.
112
113 * window.c (size_window): Avoid needless test at loop start.
114
115 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
116
117 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
118
119 2011-05-12 Drew Adams <drew.adams@oracle.com>
120
121 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
122
123 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
124
125 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
126 `width' to `bar_area_x' and `bar_area_width', respectively.
127 (x_scroll_run): Take account of fringe background extension.
128
129 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
130 Rename local vars `left' and `width' to `bar_area_x' and
131 `bar_area_width', respectively.
132 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
133 background extension.
134
135 2011-05-10 Jim Meyering <meyering@redhat.com>
136
137 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
138
139 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
140
141 * image.c (Finit_image_library): Return t for built-in image types,
142 like pbm and xbm. (Bug#8640)
143
144 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
145
146 * w32menu.c (set_frame_menubar): Fix submenu allocation.
147
148 2011-05-07 Eli Zaretskii <eliz@gnu.org>
149
150 * w32console.c (Fset_screen_color): Doc fix.
151 (Fget_screen_color): New function.
152 (syms_of_ntterm): Defsubr it.
153
154 * callproc.c (call_process_cleanup): Don't close and unlink the
155 temporary file if Fcall_process didn't create it in the first
156 place.
157 (Fcall_process): Don't create tempfile if stdout of the child
158 process will be redirected to a file specified with `:file'.
159 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
160 cue to call_process_cleanup not to close that handle.
161
162 2011-05-07 Ben Key <bkey76@gmail.com>
163
164 * makefile.w32-in: The bootstrap-temacs rule now makes use of
165 one of two shell specific rules, either bootstrap-temacs-CMD or
166 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
167 to the previous implementation of the bootstrap-temacs rule.
168 The bootstrap-temacs-CMD rule is similar to the previous
169 implementation of the bootstrap-temacs rule except that it
170 makes use of the ESC_CFLAGS variable instead of the CFLAGS
171 variable.
172
173 These changes, along with some changes to nt/configure.bat,
174 nt/gmake.defs, and nt/nmake.defs, are required to extend my
175 earlier fix to add support for --cflags and --ldflags options
176 that include quotes so that it works whether make uses cmd or
177 sh as the shell.
178
179 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
180
181 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
182 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
183 is a constant.
184 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
185 a string. Handle both cases.
186 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
187 (Fdbus_register_method): Use Qinvalid_function.
188
189 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
190
191 * makefile.w32-in: Update dependencies.
192 (LISP_H): Add inttypes.h and stdin.h.
193 (PROCESS_H): Add unistd.h.
194
195 2011-05-06 Eli Zaretskii <eliz@gnu.org>
196
197 * lread.c: Include limits.h (fixes the MS-Windows build broken by
198 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
199
200 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
201
202 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
203
204 * term.c (vfatal): Remove stray call to va_end.
205 It's not needed and the C Standard doesn't allow it here anyway.
206
207 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
208 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
209
210 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
211 bytes.
212
213 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
214
215 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
216
217 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
218
219 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
220
221 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
222
223 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
224 * charset.c (Fdefine_charset_internal): Don't initialize
225 charset.code_space[15]. The value was garbage, on hosts with
226 32-bit int (Bug#8600).
227
228 * lread.c (read_integer): Be more consistent with string-to-number.
229 Use string_to_number to do the actual conversion; this avoids
230 rounding errors and fixes some other screwups. Without this fix,
231 for example, #x1fffffffffffffff was misread as -2305843009213693952.
232 (digit_to_number): Move earlier, for benefit of read_integer.
233 Return -1 if the digit is out of range for the base, -2 if it is
234 not a digit in any supported base. (Bug#8602)
235
236 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
237
238 * dispnew.c (scrolling_window): Return 1 if we scrolled,
239 to match comment at start of function. This also removes a
240 GCC warning about overflow in a 32+64-bit port.
241
242 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
243
244 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
245 Reported by Stefan Monnier in
246 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
247 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
248 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
249
250 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
251 (EMACS_UINTPTR): Likewise, with uintptr_t.
252
253 * lisp.h: Prefer 64-bit EMACS_INT if available.
254 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
255 on 32-bit hosts that have 64-bit int, so that they can access
256 large files.
257 However, temporarily disable this change unless the temporary
258 symbol WIDE_EMACS_INT is defined.
259
260 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
261
262 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
263 This removes an assumption that EMACS_INT and long are the same
264 width as pointers. The assumption is true for Emacs porting targets
265 now, but we want to make other targets possible.
266 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
267 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
268 In the rest of the code, change types of integers that hold casted
269 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
270 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
271 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
272 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
273 No need to cast type when ORing.
274 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
275 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
276 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
277 assume EMACS_INT is the same width as char *.
278 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
279 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
280 Remove no-longer-needed casts.
281 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
282 (xg_tool_bar_help_callback, xg_make_tool_item):
283 Use EMACS_INTPTR to hold an integer
284 that will be cast to void *; this can avoid a GCC warning
285 if EMACS_INT is not the same width as void *.
286 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
287 * xdisp.c (display_echo_area_1, resize_mini_window_1):
288 (current_message_1, set_message_1):
289 Use a local to convert to proper width without a cast.
290 * xmenu.c (dialog_selection_callback): Likewise.
291
292 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
293 Also, don't assume VALBITS / RAND_BITS is less than 5,
294 and don't rely on undefined behavior when shifting a 1 left into
295 the sign bit.
296 * lisp.h (get_random): Change signature to match.
297
298 * lread.c (hash_string): Use size_t, not int, for hash computation.
299 Normally we prefer signed values; but hashing is special, because
300 it's better to use unsigned division on hash table sizes so that
301 the remainder is nonnegative. Also, size_t is the natural width
302 for hashing into memory. The previous code used 'int', which doesn't
303 retain enough info to hash well into very large tables.
304 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
305
306 * dbusbind.c: Don't possibly lose pointer info when converting.
307 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
308 Use XPNTR rather than XHASH, so that the high-order bits of
309 the pointer aren't lost when converting through void *.
310
311 * eval.c (Fautoload): Don't double-shift a pointer.
312
313 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
314
315 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
316
317 * gnutls.c (DEF_GNUTLS_FN):
318 * image.c (DEF_IMGLIB_FN): Make function pointers static.
319
320 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
321
322 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
323 marker. (Bug#8610)
324
325 2011-05-05 Eli Zaretskii <eliz@gnu.org>
326
327 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
328 New version that can reserve upto 2GB of heap space.
329
330 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
331
332 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
333
334 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
335
336 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
337 `gnutls_certificate_set_x509_key_file'.
338
339 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
340
341 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
342 Update dependencies.
343
344 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
345
346 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
347 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
348 Remove unused parameter `fildes'.
349 * process.c (read_process_output, send_process): Don't pass it.
350
351 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
352
353 Fix previous change: the library cache is defined in w32.c.
354 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
355 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
356
357 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
358
359 Implement dynamic loading of GnuTLS on Windows.
360
361 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
362 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
363 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
364 Declare.
365
366 * gnutls.c (Qgnutls_dll): Define.
367 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
368 (gnutls_*): Declare function pointers.
369 (init_gnutls_functions): New function to initialize function pointers.
370 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
371 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
372 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
373 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
374 (emacs_gnutls_write, emacs_gnutls_read)
375 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
376 (Fgnutls_available_p): New function.
377 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
378 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
379 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
380
381 * image.c: Include w32.h.
382 (Vimage_type_cache): Delete.
383 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
384 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
385 (w32_delayed_load): Move to w32.c.
386
387 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
388
389 * w32.c (QCloaded_from, Vlibrary_cache): Define.
390 (w32_delayed_load): Move from image.c. When loading a library, record
391 its filename in the :loaded-from property of the library id.
392 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
393 Initialize and staticpro them.
394 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
395
396 * process.c: Include lisp.h before w32.h, not after.
397 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
398 instead of gnutls_record_check_pending.
399
400 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
401
402 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
403
404 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
405 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
406 as passed in.
407
408 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
409
410 * xterm.c (x_set_frame_alpha): Do not set property on anything
411 else than FRAME_X_OUTER_WINDOW (Bug#8608).
412
413 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
414
415 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
416
417 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
418
419 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
420 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
421 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
422 (gnutls_global_initialized, Qgnutls_bootprop_priority)
423 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
424 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
425 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
426 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
427 (Qgnutls_bootprop_callbacks_verify): Make static.
428
429 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
430
431 * callproc.c: Indentation fixup.
432
433 * sysdep.c (wait_for_termination_1): Make static.
434 (wait_for_termination, interruptible_wait_for_termination):
435 Move after wait_for_termination_1.
436
437 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
438
439 * sysdep.c (interruptible_wait_for_termination): New function
440 which is like wait_for_termination, but allows keyboard
441 interruptions.
442
443 * callproc.c (Fcall_process): Add (:file "file") as an option for
444 the STDOUT buffer.
445 (Fcall_process_region): Ditto.
446
447 2011-04-30 Eli Zaretskii <eliz@gnu.org>
448
449 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
450 rather than `XVECTOR (FOO)->size'.
451
452 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
453 inttypes.h, as a gnulib replacement is used if it not available in
454 system headers.
455
456 2011-04-21 Eli Zaretskii <eliz@gnu.org>
457
458 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
459 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
460 of MOST_POSITIVE_FIXNUM. (Bug#8528)
461
462 * coding.c (coding_alloc_by_realloc): Error out if destination
463 will grow beyond MOST_POSITIVE_FIXNUM.
464 (decode_coding_emacs_mule): Abort if there isn't enough place in
465 charbuf for the composition carryover bytes. Reserve an extra
466 space for up to 2 characters produced in a loop.
467 (decode_coding_iso_2022): Abort if there isn't enough place in
468 charbuf for the composition carryover bytes.
469
470 2011-04-21 Eli Zaretskii <eliz@gnu.org>
471
472 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
473 aborting when %lld or %lll format is passed.
474 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
475 %llo or %llx format is passed. (Bug#8545)
476
477 * window.c (window_scroll_line_based): Use a marker instead of
478 simple variables to record original value of point. (Bug#7952)
479
480 * doprnt.c (doprnt): Fix the case where a multibyte sequence
481 produced by %s or %c overflows available buffer space. (Bug#8545)
482
483 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
484
485 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
486 (SIZE_MAX): Move defn after all includes, as they might #define it.
487
488 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
489
490 * w32.c (init_environment): Warn about defaulting HOME to C:\.
491
492 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
493
494 * keyboard.c (Qdelayed_warnings_hook): Define.
495 (command_loop_1): Run `delayed-warnings-hook'
496 if Vdelayed_warnings_list is non-nil.
497 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
498 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
499
500 2011-04-28 Eli Zaretskii <eliz@gnu.org>
501
502 * doprnt.c (doprnt): Don't return value smaller than the buffer
503 size if the message was truncated. (Bug#8545).
504
505 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
506
507 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
508 (Fx_window_property): #if-0 the whole functions, not just the bodies.
509
510 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
511
512 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
513
514 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
515
516 * makefile.w32-in: Update dependencies.
517
518 2011-04-27 Eli Zaretskii <eliz@gnu.org>
519
520 Improve `doprnt' and its usage. (Bug#8545)
521 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
522 `format_end'. Remove support for %l as a conversion specifier.
523 Don't use xrealloc. Improve diagnostics when the %l size modifier
524 is used. Update the commentary.
525
526 * eval.c (verror): Simplify calculation of size_t.
527
528 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
529 messages.
530
531 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
532
533 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
534 change.
535
536 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
537
538 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
539 This makes this file independent of the recent pseudovector change.
540
541 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
542
543 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
544
545 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
546 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
547 Remove unused local.
548 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
549
550 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
551 GCC 4.6.0 optimizes based on type-based alias analysis.
552 For example, if b is of type struct buffer * and v of type struct
553 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
554 != &v->size, and therefore "v->size = 1; b->size = 2; return
555 v->size;" must therefore return 1. This assumption is incorrect
556 for Emacs, since it type-puns struct Lisp_Vector * with many other
557 types. To fix this problem, this patch adds a new type struct
558 vectorlike_header that documents the constraints on layout of vectors
559 and pseudovectors, and helps optimizing compilers not get fooled
560 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
561 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
562 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
563 the size member.
564 (XSETPVECTYPE): Rewrite in terms of new macro.
565 (XSETPVECTYPESIZE): New macro, specifying both type and size.
566 This is a bit clearer, and further avoids the possibility of
567 undesirable aliasing.
568 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
569 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
570 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
571 since Lisp_Subr is a special case (no "next" field).
572 (ASIZE): Now uses header.size rather than size.
573 All previous uses of XVECTOR (foo)->size replaced to use this macro,
574 to avoid the hassle of writing XVECTOR (foo)->header.size.
575 (struct vectorlike_header): New type.
576 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
577 object, to help avoid aliasing.
578 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
579 (SUBRP): Likewise, since Lisp_Subr is a special case.
580 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
581 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
582 (struct Lisp_Hash_Table): Combine first two members into a single
583 struct vectorlike_header member. All uses of "size" and "next" members
584 changed to be "header.size" and "header.next".
585 * buffer.h (struct buffer): Likewise.
586 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
587 * frame.h (struct frame): Likewise.
588 * process.h (struct Lisp_Process): Likewise.
589 * termhooks.h (struct terminal): Likewise.
590 * window.c (struct save_window_data, struct saved_window): Likewise.
591 * window.h (struct window): Likewise.
592 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
593 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
594 * buffer.c (init_buffer_once): Likewise.
595 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
596 special case.
597 * process.c (Fformat_network_address): Use local var for size,
598 for brevity.
599
600 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
601
602 Make the Lisp reader and string-to-float more consistent (Bug#8525)
603 * data.c (atof): Remove decl; no longer used or needed.
604 (digit_to_number): Move to lread.c.
605 (Fstring_to_number): Use new string_to_number function, to be
606 consistent with how the Lisp reader treats infinities and NaNs.
607 Do not assume that floating-point numbers represent EMACS_INT
608 without losing information; this is not true on most 64-bit hosts.
609 Avoid double-rounding errors, by insisting on integers when
610 parsing non-base-10 numbers, as the documentation specifies.
611 * lisp.h (string_to_number): New decl, replacing ...
612 (isfloat_string): Remove.
613 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
614 (read1): Do not accept +. and -. as integers; this
615 appears to have been a coding error. Similarly, do not accept
616 strings like +-1e0 as floating point numbers. Do not report
617 overflow for integer overflows unless the base is not 10 which
618 means we have no simple and reliable way to continue.
619 Break out the floating-point parsing into a new
620 function string_to_number, so that Fstring_to_number parses
621 floating point numbers consistently with the Lisp reader.
622 (digit_to_number): Move here from data.c. Make it static inline.
623 (E_CHAR, EXP_INT): Remove, replacing with ...
624 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
625 (string_to_number): New function, replacing isfloat_string.
626 This function checks for valid syntax and produces the resulting
627 Lisp float number too. Rework it so that string-to-number
628 no longer mishandles examples like "1.0e+". Use strtoumax,
629 so that overflow for non-base-10 numbers is reported only when
630 there's no portable and simple way to convert to floating point.
631
632 * textprop.c (set_text_properties_1): Rewrite for clarity,
633 and to avoid GCC warning about integer overflow.
634
635 * intervals.h (struct interval): Use EMACS_INT for members
636 where EMACS_UINT might cause problems. See
637 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
638 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
639 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
640 All uses changed.
641 (offset_intervals): Tell GCC not to worry about length overflow
642 when negating a negative length.
643
644 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
645 (overrun_check_free): Likewise.
646
647 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
648 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
649 word size.
650
651 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
652 (gnutls_make_error): Rename local to avoid shadowing.
653 (gnutls_emacs_global_deinit): ifdef out; not used.
654 (Fgnutls_boot): Use const for pointer to readonly storage.
655 Comment out unused local. Fix pointer signedness problems.
656
657 * lread.c (openp): Don't stuff size_t into an 'int'.
658 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
659 about possible signed overflow.
660
661 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
662 (GDK_KEY_g): Don't define if already defined.
663 (xg_prepare_tooltip): Avoid pointer signedness problem.
664 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
665
666 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
667 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
668
669 * xfns.c (Fx_window_property): Simplify a bit,
670 to make a bit faster and to avoid GCC 4.6.0 warning.
671 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
672
673 * fns.c (internal_equal): Don't assume size_t fits in int.
674
675 * alloc.c (compact_small_strings): Tighten assertion a little.
676
677 Replace pEd with more-general pI, and fix some printf arg casts.
678 * lisp.h (pI): New macro, generalizing old pEd macro to other
679 conversion specifiers. For example, use "...%"pI"d..." rather
680 than "...%"pEd"...".
681 (pEd): Remove. All uses replaced with similar uses of pI.
682 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
683 * alloc.c (check_pure_size): Don't overflow by converting size to int.
684 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
685 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
686 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
687 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
688 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
689 64-bit hosts.
690 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
691 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
692 * print.c (safe_debug_print, print_object): Likewise.
693 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
694 to int.
695 Use pI instead of if-then-else-abort. Use %p to avoid casts,
696 avoiding the 0 flag, which is not portable.
697 * process.c (Fmake_network_process): Use pI to avoid cast.
698 * region-cache.c (pp_cache): Likewise.
699 * xdisp.c (decode_mode_spec): Likewise.
700 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
701 behavior on 64-bit hosts with printf arg.
702 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
703 (x_stop_queuing_selection_requests): Likewise.
704 (x_get_window_property): Don't truncate byte count to an 'int'
705 when tracing.
706
707 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
708 here, since it parses constructs like leading '-' and spaces,
709 which are not wanted; and it overflows with large numbers.
710 Instead, simply match F[0-9]+, which is what is wanted anyway.
711
712 * alloc.c: Remove unportable assumptions about struct layout.
713 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
714 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
715 (allocate_vectorlike, make_pure_vector): Use the new macros,
716 plus offsetof, to remove unportable assumptions about struct layout.
717 These assumptions hold on all porting targets that I know of, but
718 they are not guaranteed, they're easy to remove, and removing them
719 makes further changes easier.
720
721 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
722 This doesn't fix a bug but makes the code clearer.
723 (string_overrun_cookie): Now const. Use initializers that
724 don't formally overflow signed char, to avoid warnings.
725 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
726 can cause Emacs to crash when string overrun checking is enabled.
727 (allocate_buffer): Don't assume sizeof (struct buffer) is a
728 multiple of sizeof (EMACS_INT); it need not be, if
729 alignof(EMACS_INT) < sizeof (EMACS_INT).
730 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
731
732 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
733
734 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
735
736 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
737
738 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
739 supposed to be handshaking. (Bug#8556)
740 Reported by Paul Eggert <eggert@cs.ucla.edu>.
741
742 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
743
744 * lisp.h (Qdebug): List symbol.
745 * eval.c (Qdebug): Restore global linkage.
746 * keyboard.c (debug-on-event): New variable.
747 (handle_user_signal): Break into debugger when debug-on-event
748 matches the current signal symbol.
749
750 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
751
752 * alloc.c (check_sblock, check_string_bytes)
753 (check_string_free_list): Convert to standard C.
754
755 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
756
757 * w32.c (emacs_gnutls_push): Fix typo.
758
759 2011-04-25 Eli Zaretskii <eliz@gnu.org>
760
761 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
762 "cast to pointer from integer of different size".
763
764 Improve doprnt and its use in verror. (Bug#8545)
765 * doprnt.c (doprnt): Document the set of format control sequences
766 supported by the function. Use SAFE_ALLOCA instead of always
767 using `alloca'.
768
769 * eval.c (verror): Don't limit the buffer size at size_max-1, that
770 is one byte too soon. Don't use xrealloc; instead xfree and
771 xmalloc anew.
772
773 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
774
775 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
776 callbacks stage.
777
778 * gnutls.c: Renamed global_initialized to
779 gnutls_global_initialized. Added internals for the
780 :verify-hostname-error, :verify-error, and :verify-flags
781 parameters of `gnutls-boot' and documented those parameters in the
782 docstring. Start callback support.
783 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
784 unless a fatal error occured. Call gnutls_alert_send_appropriate
785 on error. Return error code.
786 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
787 (emacs_gnutls_read): Likewise.
788 (Fgnutls_boot): Return handshake error code.
789 (emacs_gnutls_handle_error): New function.
790 (wsaerror_to_errno): Likewise.
791
792 * w32.h (emacs_gnutls_pull): Add prototype.
793 (emacs_gnutls_push): Likewise.
794
795 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
796 (emacs_gnutls_push): Likewise.
797
798 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
799
800 * process.c (wait_reading_process_output): Check if GnuTLS
801 buffered some data internally if no FDs are set for TLS
802 connections.
803
804 * makefile.w32-in (OBJ2): Add gnutls.$(O).
805 (LIBS): Link to USER_LIBS.
806 ($(BLD)/gnutls.$(0)): New target.
807
808 2011-04-24 Eli Zaretskii <eliz@gnu.org>
809
810 * xdisp.c (handle_single_display_spec): Rename the
811 display_replaced_before_p argument into display_replaced_p, to
812 make it consistent with the commentary. Fix typos in the
813 commentary.
814
815 * textprop.c (syms_of_textprop): Remove dead code.
816 (copy_text_properties): Delete obsolete commentary about an
817 interface that was deleted long ago. Fix typos in the description
818 of arguments.
819
820 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
821 to changes in oldXMenu/XMenu.h from 2011-04-16.
822 <menu_help_message, prev_menu_help_message>: Constify.
823 (IT_menu_make_room): menu->help_text is now `const char **';
824 adjust.
825
826 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
827 to changes in oldXMenu/XMenu.h from 2011-04-16.
828 (struct XMenu): Declare `help_text' `const char **'.
829
830 * xfaces.c <Qunspecified>: Make extern again.
831
832 * syntax.c: Include sys/types.h before including regex.h, as
833 required by Posix.
834
835 * doc.c (get_doc_string): Improve the format passed to `error'.
836
837 * doprnt.c (doprnt): Improve commentary.
838
839 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
840
841 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
842 them with etags.
843
844 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
845 changes in globals.h immediately force recompilation.
846 (TAGS): Depend on $(CURDIR)/m/intel386.h and
847 $(CURDIR)/s/ms-w32.h.
848 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
849
850 * character.c (Fchar_direction): Function deleted.
851 (syms_of_character): Don't defsubr it.
852 <char-direction-table>: Deleted.
853
854 2011-04-23 Eli Zaretskii <eliz@gnu.org>
855
856 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
857 * doprnt.c: Include limits.h.
858 (SIZE_MAX): New macro.
859 (doprnt): Return a size_t value. 2nd arg is now size_t.
860 Many local variables are now size_t instead of int or unsigned.
861 Improve overflow protection. Support `l' modifier for integer
862 conversions. Support %l conversion. Don't assume an EMACS_INT
863 argument for integer conversions and for %c.
864
865 * lisp.h (doprnt): Restore prototype.
866
867 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
868 $(SRC)/character.h.
869
870 * Makefile.in (base_obj): Add back doprnt.o.
871
872 * deps.mk (doprnt.o): Add back prerequisites.
873 (callint.o): Depend on character.h.
874
875 * eval.c (internal_lisp_condition_case): Include the handler
876 representation in the error message.
877 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
878 when breaking from the loop.
879
880 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
881
882 * callint.c (Fcall_interactively): When displaying error message
883 about invalid control letter, pass the character's codepoint, not
884 a pointer to its multibyte form. Improve display of the character
885 in octal and display also its hex code.
886
887 * character.c (char_string): Use %x to display the (unsigned)
888 codepoint of an invalid character, to avoid displaying a bogus
889 negative value.
890
891 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
892 `error', not SYMBOL_NAME itself.
893
894 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
895 character arguments to `error'.
896
897 * charset.c (check_iso_charset_parameter): Fix incorrect argument
898 to `error' in error message about FINAL_CHAR argument. Make sure
899 FINAL_CHAR is a character, and use %c when it is passed as
900 argument to `error'.
901
902 2011-04-23 Eli Zaretskii <eliz@gnu.org>
903
904 * s/ms-w32.h (localtime): Redirect to sys_localtime.
905
906 * w32.c: Include <time.h>.
907 (sys_localtime): New function.
908
909 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
910
911 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
912
913 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
914
915 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
916
917 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
918 zombies (Bug#8467).
919
920 2011-04-19 Eli Zaretskii <eliz@gnu.org>
921
922 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
923 gl_state.e_property when gl_state.object is Qt.
924
925 * insdel.c (make_gap_larger): Remove limitation of buffer size
926 to <= INT_MAX.
927
928 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
929
930 * xdisp.c (lookup_glyphless_char_display)
931 (produce_glyphless_glyph): Handle cons cell entry in
932 glyphless-char-display.
933 (Vglyphless_char_display): Document it.
934
935 * term.c (produce_glyphless_glyph): Handle cons cell entry in
936 glyphless-char-display.
937
938 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
939
940 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
941
942 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
943
944 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
945 definition for no-X builds.
946
947 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
948
949 Static checks with GCC 4.6.0 and non-default toolkits.
950
951 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
952
953 * process.c (keyboard_bit_set): Define only if SIGIO.
954 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
955 (send_process): Repair possible setjmp clobbering.
956
957 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
958
959 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
960
961 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
962
963 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
964 Define only if needed.
965
966 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
967 by pacifying GCC about it. Maybe it's time to retire it?
968 * xfaces.c (USG, __TIMEVAL__): Likewise.
969
970 * dispextern.h (struct redisplay_interface): Rename param
971 to avoid shadowing.
972 * termhooks.h (struct terminal): Likewise.
973 * xterm.c (xembed_send_message): Likewise.
974
975 * insdel.c (make_gap_smaller): Define only if
976 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
977
978 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
979 it.
980
981 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
982 so that we aren't warned about unused symbols.
983
984 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
985
986 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
987
988 * xfns.c (x_real_positions): Mark locals as initialized.
989
990 * xmenu.c (xmenu_show): Don't use uninitialized vars.
991
992 * xterm.c: Fix problems found by static analysis with other toolkits.
993 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
994 (x_dispatch_event): Declare static if USE_GTK, and
995 define if USE_GTK || USE_X_TOOLKIT.
996 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
997 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
998 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
999 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1000
1001 * xmenu.c (menu_help_callback): Pointer type fixes.
1002 Use const pointers when pointing at readonly data. Avoid pointer
1003 signedness clashes.
1004 (FALSE): Remove unused macro.
1005 (update_frame_menubar): Remove unused decl.
1006
1007 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1008
1009 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1010 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1011 (single_menu_item): Rename local to avoid shadowing.
1012
1013 * keyboard.c (make_lispy_event): Remove unused local var.
1014
1015 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1016 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1017
1018 * bitmaps: Change bitmaps from unsigned char back to the X11
1019 compatible char. Avoid the old compiler warnings about
1020 out-of-range initializers by using, for example, '\xab' rather
1021 than 0xab.
1022
1023 * xgselect.c (xgselect_initialize): Check vs interface
1024 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1025
1026 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1027
1028 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1029 to read-only memory.
1030
1031 * fns.c (vector): Remove; this old hack is no longer needed.
1032
1033 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1034 Remove unused var.
1035 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1036
1037 * xrdb.c (x_load_resources): Omit unused local.
1038
1039 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1040 (x_window): Rename locals to avoid shadowing.
1041 (USG): Use the kludged USG macro, to pacify gcc.
1042
1043 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1044 (x_term_init): Remove local to avoid shadowing.
1045
1046 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1047
1048 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1049 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1050
1051 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1052
1053 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1054
1055 Fix regex.c, syntax.c and friends for buffers > 2GB.
1056 * syntax.h (struct gl_state_s): Declare character position members
1057 EMACS_INT.
1058
1059 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1060
1061 * textprop.c (verify_interval_modification, interval_of):
1062 Declare arguments EMACS_INT.
1063
1064 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1065 EMACS_INT.
1066
1067 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1068
1069 * indent.c (Fvertical_motion): Local variable it_start is now
1070 EMACS_INT.
1071
1072 * regex.c (re_match, re_match_2, re_match_2_internal)
1073 (bcmp_translate, regcomp, regexec, print_double_string)
1074 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1075 (re_compile_pattern, re_exec): Declare arguments and local
1076 variables `size_t' and `ssize_t' and return values `regoff_t', as
1077 appropriate.
1078 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1079 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1080 <compile_stack_type>: `size' and `avail' are now `size_t'.
1081
1082 * regex.h <regoff_t>: Use ssize_t, not int.
1083 (re_search, re_search_2, re_match, re_match_2): Arguments that
1084 specify buffer/string position and length are now ssize_t and
1085 size_t. Return type is regoff_t.
1086
1087 2011-04-16 Ben Key <bkey76@gmail.com>
1088
1089 * nsfont.m: Fixed bugs in ns_get_family and
1090 ns_descriptor_to_entity that were caused by using free to
1091 deallocate memory blocks that were allocated by xmalloc (via
1092 xstrdup). This caused Emacs to crash when compiled with
1093 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1094 --enable-checking=xmallocoverrun). xfree is now used to
1095 deallocate these memory blocks.
1096
1097 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1098
1099 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1100
1101 emacs_write: Accept and return EMACS_INT for sizes.
1102 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1103 et seq.
1104 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1105 Accept and return EMACS_INT.
1106 (emacs_gnutls_write): Return the number of bytes written on
1107 partial writes.
1108 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1109 (emacs_read, emacs_write): Remove check for negative size, as the
1110 Emacs source code has been audited now.
1111 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1112 (emacs_read, emacs_write): Use it.
1113 * process.c (send_process): Adjust to the new signatures of
1114 emacs_write and emacs_gnutls_write. Do not attempt to store
1115 a byte offset into an 'int'; it might overflow.
1116 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1117
1118 * sound.c: Don't assume sizes fit in 'int'.
1119 (struct sound_device.period_size, alsa_period_size):
1120 Return EMACS_INT, not int.
1121 (struct sound_device.write, vox_write, alsa_write):
1122 Accept EMACS_INT, not int.
1123 (wav_play, au_play): Use EMACS_INT to store sizes and to
1124 record read return values.
1125
1126 2011-04-15 Ben Key <bkey76@gmail.com>
1127
1128 * keyboard.c (Qundefined): Don't declare static since it is used
1129 in nsfns.m.
1130 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1131 static since they are used in nsfont.m.
1132
1133 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1134
1135 * process.c (Qprocessp): Don't declare static.
1136 * lisp.h (Qprocessp): Declare again.
1137
1138 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
1139
1140 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1141
1142 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1143
1144 Improve C-level modularity by making more things 'static'.
1145
1146 Don't publish debugger-only interfaces to other modules.
1147 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1148 (verify_bytepos, count_markers): Move decls to the only modules
1149 that need them.
1150 * region-cache.h (pp_cache): Likewise.
1151 * window.h (check_all_windows): Likewise.
1152 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1153
1154 * sysdep.c (croak): Now static, if
1155 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1156 * syssignal.h (croak): Declare only if not static.
1157
1158 * alloc.c (refill_memory_reserve): Now static if
1159 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1160 * lisp.h (refill_memory_reserve): Declare only if not static.
1161
1162 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1163 Define only if USE_LUCID.
1164
1165 * xrdb.c (x_customization_string, x_rm_string): Now static.
1166
1167 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1168 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1169
1170 * xdisp.c (draw_row_with_mouse_face): Now static.
1171 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1172
1173 * window.h (check_all_windows): Mark externally visible.
1174
1175 * window.c (window_deletion_count): Now static.
1176
1177 * undo.c: Make symbols static if they're not exported.
1178 (last_undo_buffer, last_boundary_position, pending_boundary):
1179 Now static.
1180
1181 * textprop.c (interval_insert_behind_hooks): Now static.
1182 (interval_insert_in_front_hooks): Likewise.
1183
1184 * term.c: Make symbols static if they're not exported.
1185 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1186 (max_frame_lines, tty_set_terminal_modes):
1187 (tty_reset_terminal_modes, tty_turn_off_highlight):
1188 (get_tty_terminal): Now static.
1189 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1190 * termhooks.h (term_mouse_moveto): Do not declare if
1191 HAVE_WINDOW_SYSTEM.
1192 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1193 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1194
1195 * sysdep.c: Make symbols static if they're not exported.
1196 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1197 Now static.
1198 (sigprocmask_set, full_mask): Remove; unused.
1199 (wait_debugging): Mark as visible.
1200 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1201 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1202
1203 * syntax.c (syntax_temp): Define only if !__GNUC__.
1204
1205 * sound.c (current_sound_device, current_sound): Now static.
1206
1207 * search.c (searchbufs, searchbuf_head): Now static.
1208
1209 * scroll.c (scroll_cost): Remove; unused.
1210 * dispextern.h (scroll_cost): Remove decl.
1211
1212 * region-cache.h (pp_cache): Mark as externally visible.
1213
1214 * process.c: Make symbols static if they're not exported.
1215 (process_tick, update_tick, create_process, chan_process):
1216 (Vprocess_alist, proc_buffered_char, datagram_access):
1217 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1218 (deactivate_process): Mark defn as static, as well as decl.
1219 * lisp.h (create_process): Remove decl.
1220 * process.h (chan_process, Vprocess_alist): Remove decls.
1221
1222 * print.c: Make symbols static if they're not exported.
1223 (print_depth, new_backquote_output, being_printed, print_buffer):
1224 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1225 (print_interval, print_number_index, initial_stderr_stream):
1226 Now static.
1227 * lisp.h (Fprinc): Remove decl.
1228 (debug_output_compilation_hack): Mark as externally visible.
1229
1230 * sysdep.c (croak): Move decl from here to syssignal.h.
1231 * syssignal.h (croak): Put it here, so the API can be checked when
1232 'croak' is called from dissociate_if_controlling_tty.
1233
1234 * minibuf.c: Make symbols static if they're not exported.
1235 (minibuf_save_list, choose_minibuf_frame): Now static.
1236 * lisp.h (choose_minibuf_frame): Remove decl.
1237
1238 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1239
1240 * lread.c: Make symbols static if they're not exported.
1241 (read_objects, initial_obarray, oblookup_last_bucket_number):
1242 Now static.
1243 (make_symbol): Remove; unused.
1244 * lisp.h (initial_obarray, make_symbol): Remove decls.
1245
1246 * keyboard.c: Make symbols static if they're not exported.
1247 (single_kboard, recent_keys_index, total_keys, recent_keys):
1248 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1249 (this_single_command_key_start, echoing, last_auto_save):
1250 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1251 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1252 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1253 (Vlispy_mouse_stem, double_click_count):
1254 Now static.
1255 (force_auto_save_soon): Define only if SIGDANGER.
1256 (ignore_mouse_drag_p): Now static if
1257 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1258 (print_help): Remove; unused.
1259 (stop_character, last_timer_event): Mark as externally visible.
1260 * keyboard.h (ignore_mouse_drag_p): Declare only if
1261 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1262 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1263 * lisp.h (echoing): Remove decl.
1264 (force_auto_save_soon): Declare only if SIGDANGER.
1265 * xdisp.c (redisplay_window): Simplify code, to make it more
1266 obvious that ignore_mouse_drag_p is not accessed if !defined
1267 USE_GTK && !defined HAVE_NS.
1268
1269 * intervals.c: Make symbols static if they're not exported.
1270 (merge_properties_sticky, merge_interval_right, delete_interval):
1271 Now static.
1272 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1273
1274 * insdel.c: Make symbols static if they're not exported.
1275 However, leave prepare_to_modify_buffer alone. It's never
1276 called from outside this function, but that appears to be a bug.
1277 (combine_after_change_list, combine_after_change_buffer):
1278 (adjust_after_replace, signal_before_change): Now static.
1279 (adjust_after_replace_noundo): Remove; unused.
1280 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
1281 (signal_before_change): Remove decls.
1282
1283 * indent.c (val_compute_motion, val_vmotion): Now static.
1284
1285 * image.c: Make symbols static if they're not exported.
1286 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1287 if USE_GTK.
1288 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1289 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1290
1291 * fringe.c (standard_bitmaps): Now static.
1292 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1293
1294 * frame.c: Make symbols static if they're not exported.
1295 (x_report_frame_params, make_terminal_frame): Now static.
1296 (get_frame_param): Now static, unless HAVE_NS.
1297 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1298 (x_get_resource_string): Remove; not used.
1299 * frame.h (make_terminal_frame, x_report_frame_params):
1300 (x_get_resource_string); Remove decls.
1301 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1302 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1303
1304 * font.c, fontset.c: Make symbols static if they're not exported.
1305 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1306 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1307 * font.c (font_close_object): Now static.
1308 * font.h (font_close_object): Remove.
1309 * fontset.c (FONTSET_OBJLIST): Remove.
1310 (free_realized_fontset) #if-0 the body, which does nothing.
1311 (face_suitable_for_char_p): #if-0, as it's never called.
1312 * fontset.h (face_suitable_for_char_p): Remove decl.
1313 * xfaces.c (face_at_string_position):
1314 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1315 since 0 is always ASCII.
1316
1317 * fns.c (weak_hash_tables): Now static.
1318
1319 * fileio.c: Make symbols static if they're not exported.
1320 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1321 (Vwrite_region_annotation_buffers): Now static.
1322
1323 * eval.c: Make symbols static if they're not exported.
1324 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1325 * lisp.h (backtrace_list): Remove decl.
1326
1327 * emacs.c: Make symbols static if they're not exported.
1328 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1329 (fatal_error_code, fatal_error_signal_hook, standard_args):
1330 Now static.
1331 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1332 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1333 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1334 * lisp.h (fatal_error_signal_hook): Remove decl.
1335 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1336
1337 * editfns.c: Move a (normally-unused) function to its only use.
1338 * editfns.c, lisp.h (get_operating_system_release): Remove.
1339 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1340 worth the hassle of breaking this out.
1341
1342 * xterm.c: Make symbols static if they're not exported.
1343 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1344 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1345 (x_destroy_window, x_delete_display):
1346 Now static.
1347 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1348 (x_mouse_leave): Remove; unused.
1349 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1350 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1351 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1352 Remove decls.
1353 (x_mouse_leave): Declare only if WINDOWSNT.
1354 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1355 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1356 USE_X_TOOLKIT.
1357
1358 * ftxfont.c: Make symbols static if they're not exported.
1359 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1360 HAVE_FREETYPE.
1361 * font.h (ftxfont_driver): Likewise.
1362
1363 * xfns.c: Make symbols static if they're not exported.
1364 (x_last_font_name, x_display_info_for_name):
1365 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1366 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1367 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1368 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1369 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1370 (last_show_tip_args): Now static.
1371 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1372 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1373 (x_screen_planes): Remove; unused.
1374 * dispextern.h (x_screen_planes): Remove decl.
1375
1376 * dispnew.c: Make symbols static if they're not exported.
1377 * dispextern.h (redraw_garbaged_frames, scrolling):
1378 (increment_row_positions): Remove.
1379 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1380 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1381 Now static.
1382 (redraw_garbaged_frames): Remove; unused.
1383
1384 * xfaces.c: Make symbols static if they're not exported.
1385 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1386 Remove decls.
1387 * xterm.h (defined_color): Remove decls.
1388 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1389 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1390 (menu_face_changed_default, defined_color, free_realized_face):
1391 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1392 (ascii_face_of_lisp_face): Remove; unused.
1393
1394 * xdisp.c: Make symbols static if they're not exported.
1395 * dispextern.h (scratch_glyph_row, window_box_edges):
1396 (glyph_to_pixel_coords, set_cursor_from_row):
1397 (get_next_display_element, set_iterator_to_next):
1398 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1399 (show_mouse_face): Remove decls
1400 * frame.h (message_buf_print): Likewise.
1401 * lisp.h (pop_message, set_message, check_point_in_composition):
1402 Likewise.
1403 * xterm.h (set_vertical_scroll_bar): Likewise.
1404 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1405 (message_buf_print, scratch_glyph_row, displayed_buffer):
1406 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1407 (get_next_display_element, show_mouse_face, window_box_edges):
1408 (frame_to_window_pixel_xy, check_point_in_composition):
1409 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1410 (glyph_to_pixel_coords): Remove; unused.
1411
1412 * dired.c (file_name_completion): Now static.
1413
1414 * dbusbind.c (xd_in_read_queued_messages): Now static.
1415
1416 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1417 * data.c (circular_list_error): Remove.
1418
1419 * commands.h (last_point_position, last_point_position_buffer):
1420 (last_point_position_window): Remove decls.
1421 * keyboard.c: Make these variables static.
1422
1423 * coding.h (coding, code_convert_region, encode_coding_gap):
1424 Remove decls.
1425 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1426 (iso_code_class, detect_coding, code_convert_region): Now static.
1427 (encode_coding_gap): Remove; unused.
1428
1429 * chartab.c (chartab_chars, chartab_bits): Now static.
1430
1431 * charset.h (charset_iso_8859_1): Remove decl.
1432 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1433 Now static.
1434
1435 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1436 * ccl.c (Vccl_program_table): Now static.
1437 (check_ccl_update): Remove; unused.
1438
1439 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1440 * category.h: ... from here.
1441 * category.c (check_category_table, set_category_set): Now static.
1442
1443 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1444 * lisp.h: Remove these decls.
1445
1446 * buffer.c (buffer_count): Remove unused var.
1447
1448 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1449 so that it's not optimized away.
1450 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1451 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1452 exported only to the debugger.
1453
1454 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1455 * atimer.h (run_all_atimers): Remove; not exported.
1456
1457 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1458 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1459 was inaccessible from Lisp.
1460 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1461 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1462
1463 alloc.c: Import and export fewer symbols, and remove unused items.
1464 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1465 is defined.
1466 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1467 it's not optimized away by whole-program optimization.
1468 (message_enable_multibyte, free_misc): Remove.
1469 (catchlist, handlerlist, mark_backtrace):
1470 Declare only if BYTE_MARK_STACK.
1471 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1472 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1473 (message_enable_multibyte): Remove decl.
1474 (free_misc, interval_free_list, float_block, float_block_index):
1475 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1476 (cons_free_list, last_marked_index):
1477 Now static.
1478 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1479 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1480 (mark_backtrace): Define only if BYTE_MARK_STACK.
1481 * xdisp.c (message_enable_multibyte): Now static.
1482
1483 Declare Lisp_Object Q* variables to be 'static' if not exported.
1484 This makes it easier for human readers (and static analyzers)
1485 to see whether these variables are used from other modules.
1486 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1487 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1488 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1489 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1490 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1491 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1492 * xmenu.c, xselect.c:
1493 Declare Q* vars static if they are not used in other modules.
1494 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1495 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1496 Remove decls of unexported vars.
1497 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1498
1499 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1500
1501 Make Emacs functions such as Fatom 'static' by default.
1502 This makes it easier for human readers (and static analyzers)
1503 to see whether these functions can be called from other modules.
1504 DEFUN now defines a static function. To make the function external
1505 so that it can be used in other C modules, use the new macro DEFUE.
1506 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1507 (Finit_image_library):
1508 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1509 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1510 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1511 Remove decls, since these functions are now static.
1512 (Funintern, Fget_internal_run_time): New decls, since these functions
1513 were already external.
1514
1515 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1516 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1517 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1518 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1519 * keyboard.c, keymap.c, lread.c:
1520 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1521 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1522 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1523 Mark functions with DEFUE instead of DEFUN,
1524 if they are used in other modules.
1525 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1526 decls for now-static functions.
1527 * buffer.h (Fdelete_overlay): Remove decl.
1528 * callproc.c (Fgetenv_internal): Mark as internal.
1529 * composite.c (Fremove_list_of_text_properties): Remove decl.
1530 (Fcomposition_get_gstring): New forward static decl.
1531 * composite.h (Fcomposite_get_gstring): Remove decl.
1532 * dired.c (Ffile_attributes): New forward static decl.
1533 * doc.c (Fdocumntation_property): New forward static decl.
1534 * eval.c (Ffetch_bytecode): New forward static decl.
1535 (Funintern): Remove extern decl; now in .h file where it belongs.
1536 * fileio.c (Fmake_symbolic_link): New forward static decl.
1537 * image.c (Finit_image_library): New forward static decl.
1538 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1539 * intervals.h (Fprevious_property_change):
1540 (Fremove_list_of_text_properties): Remove decls.
1541 * keyboard.c (Fthis_command_keys): Remove decl.
1542 (Fcommand_execute): New forward static decl.
1543 * keymap.c (Flookup_key): New forward static decl.
1544 (Fcopy_keymap): Now static.
1545 * keymap.h (Flookup_key): Remove decl.
1546 * process.c (Fget_process): New forward static decl.
1547 (Fprocess_datagram_address): Mark as internal.
1548 * syntax.c (Fsyntax_table_p): New forward static decl.
1549 (skip_chars): Remove duplicate decl.
1550 * textprop.c (Fprevious_property_change): New forward static decl.
1551 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1552 Now internal.
1553 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1554 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1555
1556 * editfns.c (Fformat): Remove unreachable code.
1557
1558 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1559
1560 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1561 change. (Bug#8496)
1562
1563 2011-04-13 Eli Zaretskii <eliz@gnu.org>
1564
1565 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1566 when at ZV. (Bug#8487)
1567
1568 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1569
1570 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1571 (Bug#8437)
1572 * keyboard.c (parse_tool_bar_item): Likewise.
1573 * sound.c (sound_cleanup, alsa_close): Likewise.
1574 * termcap.c (tgetent): Likewise.
1575 * xfns.c (x_default_font_parameter): Likewise.
1576 * xsettings.c (read_and_apply_settings): Likewise.
1577
1578 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1579 (overrun_check_free): Protoize.
1580
1581 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1582
1583 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1584 since callers should never pass a negative size.
1585 Change the signature to match that of plain 'read' and 'write'; see
1586 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1587 * lisp.h: Update prototypes of emacs_write and emacs_read.
1588
1589 2011-04-11 Eli Zaretskii <eliz@gnu.org>
1590
1591 * xdisp.c (redisplay_window): Don't try to determine the character
1592 position of the scroll margin if the window start point w->startp
1593 is outside the buffer's accessible region. (Bug#8468)
1594
1595 2011-04-10 Eli Zaretskii <eliz@gnu.org>
1596
1597 Fix write-region and its subroutines for buffers > 2GB.
1598 * fileio.c (a_write, e_write): Modify declaration of arguments and
1599 local variables to support buffers larger than 2GB.
1600 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1601
1602 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1603 argument, local variables, and return value.
1604
1605 * lisp.h: Update prototypes of emacs_write and emacs_read.
1606
1607 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1608
1609 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
1610
1611 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1612
1613 Fix more problems found by GCC 4.6.0's static checks.
1614
1615 * xdisp.c (vmessage): Use a better test for character truncation.
1616
1617 * charset.c (load_charset_map): <, not <=, for optimization,
1618 and to avoid potential problems with integer overflow.
1619 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
1620 * casetab.c (set_identity, shuffle): Likewise.
1621 * editfns.c (Fformat): Likewise.
1622 * syntax.c (skip_chars): Likewise.
1623
1624 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1625 This also lets GCC 4.6.0 generate slightly better loop code.
1626
1627 * callint.c (Fcall_interactively): <, not <=, for optimization.
1628 (Fcall_interactively): Count the number of arguments produced,
1629 not the number of arguments given. This is simpler and lets GCC
1630 4.6.0 generate slightly better code.
1631
1632 * ftfont.c: Distingish more carefully between FcChar8 and char.
1633 The previous code passed unsigned char * to a functions like
1634 strlen and xstrcasecmp that expect char *, which does not
1635 conform to the C standard.
1636 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1637 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1638 char * when the C standard requires it.
1639
1640 * keyboard.c (read_char): Remove unused var.
1641
1642 * eval.c: Port to Windows vsnprintf (Bug#8435).
1643 Include <limits.h>.
1644 (SIZE_MAX): Define if the headers do not.
1645 (verror): Do not give up if vsnprintf returns a negative count.
1646 Instead, grow the buffer. This ports to Windows vsnprintf, which
1647 does not conform to C99. Problem reported by Eli Zaretskii.
1648 Also, simplify the allocation scheme, by avoiding the need for
1649 calling realloc, and removing the ALLOCATED variable.
1650
1651 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1652
1653 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1654 But keep the doprint source code for now, as we might revamp it
1655 and use it again (Bug#8435).
1656 * lisp.h (doprnt): Remove.
1657 * Makefile.in (base_obj): Remove doprnt.o.
1658 * deps.mk (doprnt.o): Remove.
1659
1660 error: Print 32- and 64-bit integers portably (Bug#8435).
1661 Without this change, on typical 64-bit hosts error ("...%d...", N)
1662 was used to print both 32- and 64-bit integers N, which relied on
1663 undefined behavior.
1664 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1665 New macro.
1666 * lisp.h (error, verror): Mark as printf-like functions.
1667 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1668 Report overflow in size calculations when allocating printf buffer.
1669 Do not truncate output string at its first null byte.
1670 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1671 Truncate the output at a character boundary, since vsnprintf does not
1672 do that.
1673 * charset.c (check_iso_charset_parameter): Convert internal
1674 character to string before calling 'error', since %c now has the
1675 printf meaning.
1676 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1677 overflow when computing char to be passed to 'error'. Do not
1678 pass Lisp_Object to 'error'; pass the integer instead.
1679 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1680 formatted with plain %d.
1681
1682 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1683
1684 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1685
1686 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1687
1688 * xterm.c (x_catch_errors): Remove duplicate declaration.
1689
1690 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1691
1692 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1693
1694 2011-04-10 Jim Meyering <meyering@redhat.com>
1695
1696 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1697 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1698 return ssize_t not "int", and use size_t as the buffer length.
1699 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1700 * gnutls.h: Update declarations.
1701 * process.c (read_process_output): Use ssize_t, to match.
1702 (send_process): Likewise.
1703
1704 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1705
1706 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1707
1708 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1709
1710 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
1711 Use unsigned char, to match FcChar8 type definition.
1712
1713 * xterm.c (handle_one_xevent):
1714 * xmenu.c (create_and_show_popup_menu):
1715 * xselect.c (x_decline_selection_request)
1716 (x_reply_selection_request): Avoid type-punned deref of X events.
1717
1718 2011-04-09 Eli Zaretskii <eliz@gnu.org>
1719
1720 Fix some uses of `int' instead of EMACS_INT.
1721 * search.c (string_match_1, fast_string_match)
1722 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1723 (scan_buffer, find_next_newline_no_quit)
1724 (find_before_next_newline, search_command, Freplace_match)
1725 (Fmatch_data): Make some `int' variables be EMACS_INT.
1726
1727 * xdisp.c (display_count_lines): 3rd argument and return value now
1728 EMACS_INT. All callers changed.
1729 (pint2hrstr): Last argument is now EMACS_INT.
1730
1731 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1732 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1733 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1734 (decode_coding_utf_16, decode_coding_emacs_mule)
1735 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1736 (decode_coding_ccl, decode_coding_charset)
1737 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1738 (decode_coding_iso_2022, decode_coding_emacs_mule)
1739 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1740 <char_offset, last_offset>: Declare EMACS_INT.
1741 (encode_coding_utf_8, encode_coding_utf_16)
1742 (encode_coding_emacs_mule, encode_invocation_designation)
1743 (encode_designation_at_bol, encode_coding_iso_2022)
1744 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1745 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1746 Declare EMACS_INT.
1747 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1748 (encode_invocation_designation): Last argument P_NCHARS is now
1749 EMACS_INT.
1750 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1751 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1752
1753 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1754 All users changed.
1755
1756 * ccl.c (Fccl_execute_on_string): Declare some variables
1757 EMACS_INT.
1758
1759 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
1760
1761 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1762
1763 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1764
1765 * process.c (Fformat_network_address): Doc fix.
1766
1767 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1768
1769 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1770
1771 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
1772
1773 * keyboard.c (read_char): Call Lisp function help-form-show,
1774 instead of using internal_with_output_to_temp_buffer.
1775 (Qhelp_form_show): New var.
1776 (syms_of_keyboard): Use DEFSYM macro.
1777
1778 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1779
1780 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1781
1782 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
1783
1784 * process.c (Flist_processes): Remove to Lisp.
1785 (list_processes_1): Delete.
1786
1787 2011-04-06 Eli Zaretskii <eliz@gnu.org>
1788
1789 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1790
1791 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1792
1793 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
1794
1795 Fix more problems found by GCC 4.6.0's static checks.
1796
1797 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1798
1799 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1800
1801 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1802
1803 * xdisp.c (vmessage): Mark as a printf-like function.
1804
1805 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1806
1807 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1808
1809 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1810 printf-like functions.
1811 (tiff_load): Add casts to remove these marks before passing them
1812 to system-supplied API.
1813
1814 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1815
1816 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1817 This avoids several warnings with gcc -Wstrict-overflow.
1818 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1819 directly, rather than having caller test rule sign. This avoids
1820 some unnecessary tests.
1821 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1822 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1823 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
1824
1825 * xfont.c (xfont_text_extents): Remove var that was set but not used.
1826 (xfont_open): Avoid unnecessary tests.
1827
1828 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1829
1830 * composite.h, composite.c (composition_gstring_put_cache):
1831 Use EMACS_INT, not int, for length.
1832
1833 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1834 breaking out part of COMPOSITION_DECODE_RULE.
1835 (COMPOSITION_DECODE_RULE): Use it.
1836 * composite.c (get_composition_id): Remove unused local vars,
1837 by using the new macro.
1838
1839 * textprop.c (set_text_properties_1): Change while to do-while,
1840 since the condition is always true at first.
1841
1842 * intervals.c (graft_intervals_into_buffer): Mark var as used.
1843 (interval_deletion_adjustment): Return unsigned value.
1844 All uses changed.
1845
1846 * process.c (list_processes_1, create_pty, read_process_output):
1847 (exec_sentinel): Remove vars that were set but not used.
1848 (create_pty): Remove unnecessary "volatile"s.
1849 (Fnetwork_interface_info): Avoid possibility of int overflow.
1850 (read_process_output): Do adaptive read buffering even if carryover.
1851 (read_process_output): Simplify nbytes computation if buffered.
1852
1853 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1854
1855 * syntax.c (scan_words): Remove var that was set but not used.
1856 (update_syntax_table): Use unsigned instead of int.
1857
1858 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
1859 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
1860 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
1861
1862 * print.c (print_error_message): Avoid int overflow.
1863
1864 * font.c (font_list_entities): Redo for clarity,
1865 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1866
1867 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
1868 (font_score): Avoid potential overflow in diff calculation.
1869
1870 * fns.c (substring_both): Remove var that is set but not used.
1871 (sxhash): Redo loop for clarity and to avoid wraparound warning.
1872
1873 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1874
1875 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1876 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1877 can always succeed if overflow has undefined behavior.
1878
1879 * search.c (boyer_moore, wordify): Remove vars set but not used.
1880 (wordify): Omit three unnecessary tests.
1881
1882 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1883 All callers changed. This avoids the need for an unused var.
1884
1885 * casefiddle.c (casify_region): Remove var that is set but not used.
1886
1887 * dired.c (file_name_completion): Remove var that is set but not used.
1888
1889 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1890
1891 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
1892 (Finsert_file_contents): Remove unnecessary code checking fd.
1893
1894 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1895 Check for integer overflow on size calculations.
1896
1897 * buffer.c (Fprevious_overlay_change): Remove var that is set
1898 but not used.
1899
1900 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1901 Remove vars that are set but not used.
1902 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
1903 (timer_check_2): Mark vars as initialized.
1904
1905 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1906
1907 * image.c (lookup_image): Remove var that is set but not used.
1908 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
1909
1910 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1911 that are set but not used.
1912
1913 * xfns.c (make_invisible_cursor): Don't return garbage
1914 if XCreateBitmapFromData fails (Bug#8410).
1915
1916 * xselect.c (x_get_local_selection, x_handle_property_notify):
1917 Remove vars that are set but not used.
1918
1919 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
1920 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
1921
1922 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1923 Remove var that is set but not used.
1924 (scroll_bar_windows_size): Now size_t, not int.
1925 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1926 Check for overflow.
1927
1928 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1929 (map_tty_color) [!defined MSDOS]: Likewise.
1930
1931 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1932
1933 * coding.c: Remove vars that are set but not used.
1934 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1935 All callers changed.
1936 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1937 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1938 (decode_coding_charset): Remove vars that are set but not used.
1939
1940 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1941 that is set but not used.
1942
1943 * print.c (print_object): Remove var that is set but not used.
1944
1945 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
1946 The gnulib version avoids calling malloc in the usual case,
1947 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1948 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1949 * filelock.c (current_lock_owner): Likewise.
1950 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1951 * sysdep.c: Include allocator.h, careadlinkat.h.
1952 (emacs_no_realloc_allocator): New static constant.
1953 (emacs_readlink): New function.
1954 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1955 ../lib/careadlinkat.h.
1956
1957 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1958
1959 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1960 first non-nil return value).
1961
1962 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1963
1964 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1965 if not defined (Bug#8403).
1966
1967 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1968
1969 * xdisp.c (display_count_lines): Remove parameter `start',
1970 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1971 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1972 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1973 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1974 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1975 and thereabouts. All callers changed.
1976 (get_per_char_metric): Remove parameter `f', unused since
1977 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1978
1979 2011-04-02 Jim Meyering <meyering@redhat.com>
1980
1981 do not dereference NULL upon failed strdup
1982 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1983 (ns_get_family): Likewise.
1984
1985 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1986
1987 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1988
1989 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1990
1991 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1992 later (Bug#8403).
1993
1994 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1995
1996 Add lexical binding.
1997
1998 * window.c (Ftemp_output_buffer_show): New fun.
1999 (Fsave_window_excursion):
2000 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2001
2002 * lread.c (lisp_file_lexically_bound_p): New function.
2003 (Fload): Bind Qlexical_binding.
2004 (readevalloop): Remove `evalfun' arg.
2005 Bind Qinternal_interpreter_environment.
2006 (Feval_buffer): Bind Qlexical_binding.
2007 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2008 Mark as dynamic.
2009 (syms_of_lread): Declare `lexical-binding'.
2010
2011 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2012
2013 * keyboard.c (eval_dyn): New fun.
2014 (menu_item_eval_property): Use it.
2015
2016 * image.c (parse_image_spec): Use Ffunctionp.
2017
2018 * fns.c (concat, mapcar1): Accept byte-code-functions.
2019
2020 * eval.c (Fsetq): Handle lexical vars.
2021 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2022 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2023 (FletX, Flet): Obey lexical binding.
2024 (Fcommandp): Handle closures.
2025 (Feval): New `lexical' arg.
2026 (eval_sub): New function extracted from Feval. Use it almost
2027 everywhere where Feval was used. Look up vars in lexical env.
2028 Handle closures.
2029 (Ffunctionp): Move from subr.el.
2030 (Ffuncall): Handle closures.
2031 (apply_lambda): Remove `eval_flags'.
2032 (funcall_lambda): Handle closures and new byte-code-functions.
2033 (Fspecial_variable_p): New function.
2034 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2035 but without exporting it to Lisp.
2036
2037 * doc.c (Fdocumentation, store_function_docstring):
2038 * data.c (Finteractive_form): Handle closures.
2039
2040 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2041 interactive spec.
2042
2043 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2044 New byte-codes.
2045 (exec_byte_code): New function extracted from Fbyte_code to handle new
2046 calling convention for byte-code-functions. Add new byte-codes.
2047
2048 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2049
2050 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2051
2052 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2053
2054 * xdisp.c (redisplay_internal): Fix prototype.
2055
2056 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2057
2058 * xdisp.c (SCROLL_LIMIT): New macro.
2059 (try_scrolling): Use it when setting scroll_limit.
2060 Limit scrolling to 100 screen lines.
2061 (redisplay_window): Even when falling back on "recentering",
2062 position point in the window according to scroll-conservatively,
2063 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2064
2065 (try_scrolling): When point is above the window, allow searching
2066 as far as scroll_max, or one screenful, to compute vertical
2067 distance from PT to the scroll margin position. This prevents
2068 try_scrolling from unnecessarily failing when
2069 scroll-conservatively is set to a value slightly larger than the
2070 window height. Clean up the case of PT below the margin at bottom
2071 of window: scroll_max can no longer be INT_MAX. When aggressive
2072 scrolling is in use, don't let point enter the opposite scroll
2073 margin as result of the scroll.
2074 (syms_of_xdisp) <scroll-conservatively>: Document the
2075 threshold of 100 lines for never-recentering scrolling.
2076
2077 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2078
2079 * dispextern.h (move_it_by_lines):
2080 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2081 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2082 (message_log_check_duplicate): Remove parameters `prev_bol' and
2083 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2084 (redisplay_internal): Remove parameter `preserve_echo_area',
2085 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2086
2087 * indent.c (Fvertical_motion):
2088 * window.c (window_scroll_pixel_based, Frecenter):
2089 Don't pass `need_y_p' to `move_it_by_lines'.
2090
2091 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2092
2093 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2094 steal a few bits to be more compact.
2095 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2096 Remove unneeded casts.
2097
2098 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2099
2100 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2101
2102 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2103 binding" message (bug#7967).
2104
2105 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2106
2107 Fix more problems found by GCC 4.6.0's static checks.
2108
2109 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2110 Remove unused local var.
2111
2112 * editfns.c (Fmessage_box): Remove unused local var.
2113
2114 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2115 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2116 Omit unused local vars.
2117 * window.c (shrink_windows): Omit unused local var.
2118 * menu.c (digest_single_submenu): Omit unused local var.
2119 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2120 Omit unused local var.
2121
2122 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2123 Don't assume string length fits in int.
2124 (keyremap_step, read_key_sequence): Use size_t for sizes.
2125 (read_key_sequence): Don't check last_real_key_start redundantly.
2126
2127 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2128 instead of alloca (Bug#8344).
2129
2130 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2131 (Fbacktrace_frame): Don't assume nframes fits in int.
2132
2133 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2134
2135 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2136 concerns.
2137
2138 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2139
2140 * cm.c (calccost): Turn while-do into do-while, for clarity.
2141
2142 * keyboard.c (syms_of_keyboard): Use the same style as later
2143 in this function when indexing through an array. This also
2144 works around GCC bug 48267.
2145
2146 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2147
2148 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2149
2150 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2151 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2152
2153 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2154 This avoids undefined behavior on integer overflow, and is a bit
2155 more convenient anyway since it is compared to a size_t variable.
2156
2157 Variadic C functions now count arguments with size_t, not int.
2158 This avoids an unnecessary limitation on 64-bit machines, which
2159 caused (substring ...) to crash on large vectors (Bug#8344).
2160 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2161 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
2162 All variadic functions and their callers changed accordingly.
2163 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2164 * data.c (arith_driver, float_arith_driver): Likewise.
2165 * editfns.c (general_insert_function): Likewise.
2166 * eval.c (struct backtrace.nargs, interactive_p)
2167 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2168 (funcall_lambda, mark_backtrace): Likewise.
2169 * fns.c (concat): Likewise.
2170 * frame.c (x_set_frame_parameters): Likewise.
2171 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2172 0 if not found, not -1. All callers changed.
2173
2174 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2175 (stack_copy_size): Now size_t, not int.
2176 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2177
2178 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2179
2180 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2181 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2182 All callers changed.
2183
2184 * lisp.h (multibyte_char_to_unibyte):
2185 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2186 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2187 * character.h (CHAR_TO_BYTE8):
2188 * cmds.c (internal_self_insert):
2189 * editfns.c (general_insert_function):
2190 * keymap.c (push_key_description):
2191 * search.c (Freplace_match):
2192 * xdisp.c (message_dolog, set_message_1): All callers changed.
2193
2194 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2195
2196 * keyboard.c (safe_run_hook_funcall): New function.
2197 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2198 don't set the hook to nil, but remove the offending function instead.
2199 (Qcommand_hook_internal): Remove, unused.
2200 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2201 Vcommand_hook_internal.
2202
2203 * eval.c (enum run_hooks_condition): Remove.
2204 (funcall_nil, funcall_not): New functions.
2205 (run_hook_with_args): Call each function through a `funcall' argument.
2206 Remove `cond' argument, now redundant.
2207 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2208 (Frun_hook_with_args_until_failure): Adjust accordingly.
2209 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2210
2211 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2212
2213 * dispextern.h (string_buffer_position): Remove declaration.
2214
2215 * print.c (strout): Remove parameter `multibyte', unused since
2216 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2217
2218 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2219 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2220 All callers changed.
2221
2222 * w32.c (_wsa_errlist): Use braces for struct initializers.
2223
2224 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2225 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2226 All callers changed.
2227 (string_buffer_position): Likewise. Also, make static (it's never
2228 used outside xdisp.c).
2229 (cursor_row_p): Remove parameter `w', unused since
2230 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2231 (decode_mode_spec): Remove parameter `precision', introduced during
2232 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2233 All callers changed.
2234
2235 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2236
2237 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2238
2239 2011-03-27 Anders Lindgren <andlind@gmail.com>
2240
2241 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2242 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2243 (ns_update_auto_hide_menu_bar): New functions.
2244 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2245 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2246 ns_constrain_all_frames.
2247 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2248 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2249
2250 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2251
2252 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2253
2254 2011-03-27 Glenn Morris <rgm@gnu.org>
2255
2256 * syssignal.h: Replace RETSIGTYPE with void.
2257 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2258 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2259 Replace SIGTYPE with void everywhere.
2260 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2261 * s/template.h (SIGTYPE): Remove commented out definition.
2262
2263 2011-03-26 Eli Zaretskii <eliz@gnu.org>
2264
2265 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2266 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2267
2268 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
2269
2270 * w32.c (read_unc_volume): Use parameter `henum', instead of
2271 global variable `wget_enum_handle'.
2272
2273 * keymap.c (describe_vector): Remove parameters `indices' and
2274 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2275 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2276
2277 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2278
2279 * keyboard.c (timer_check): Remove parameter `do_it_now',
2280 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2281 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2282 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2283
2284 * keyboard.c (read_char):
2285 * w32menu.c (w32_menu_display_help):
2286 * xmenu.c (show_help_event, menu_help_callback):
2287 Adjust calls to `show_help_echo'.
2288
2289 * gtkutil.c (xg_maybe_add_timer):
2290 * keyboard.c (readable_events):
2291 * process.c (wait_reading_process_output):
2292 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2293
2294 * insdel.c (adjust_markers_gap_motion):
2295 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2296 (gap_left, gap_right): Don't call it.
2297
2298 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
2299
2300 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2301 incurred during fontification.
2302
2303 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2304
2305 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2306 (DEFVAR_PER_BUFFER): Don't pass it.
2307
2308 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2309 (scrolling_window): Don't pass it.
2310
2311 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2312
2313 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2314
2315 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2316 and `suffix'.
2317 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2318 of variables specific to SELinux and computation of `encoded_absname'.
2319
2320 * image.c (XPutPixel): Remove unused variable `height'.
2321
2322 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2323
2324 * unexw32.c (get_section_info): Remove unused variable `section'.
2325
2326 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2327 (system_process_attributes): Remove unused variable `sess'.
2328 (sys_read): Remove unused variable `err'.
2329
2330 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2331 (w32_wnd_proc): Remove unused variable `isdead'.
2332 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2333 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2334 (x_create_tip_frame): Remove unused variable `tem'.
2335
2336 * w32inevt.c (w32_console_read_socket):
2337 Remove unused variable `no_events'.
2338
2339 * w32term.c (x_draw_composite_glyph_string_foreground):
2340 Remove unused variable `width'.
2341
2342 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
2343
2344 * w32term.c (x_set_glyph_string_clipping):
2345 Don't pass uninitialized region to CombineRgn.
2346
2347 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
2348
2349 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2350 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2351 (Fx_close_connection): Remove unused variable `i'.
2352
2353 * w32font.c (w32font_draw): Return number of glyphs.
2354 (w32font_open_internal): Remove unused variable `i'.
2355 (w32font_driver): Add missing initializer.
2356
2357 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2358 (fill_in_menu): Remove unused variable `items_added'.
2359
2360 * w32term.c (last_mouse_press_frame): Remove static global variable.
2361 (w32_clip_to_row): Remove unused variable `f'.
2362 (x_delete_terminal): Remove unused variable `i'.
2363
2364 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2365 (NOTHING): Remove unused static global variable.
2366 (uniscribe_check_otf): Remove unused variable `table'.
2367 (uniscribe_font_driver): Add missing initializers.
2368
2369 2011-03-23 Julien Danjou <julien@danjou.info>
2370
2371 * term.c (Fsuspend_tty, Fresume_tty):
2372 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2373 * window.c (temp_output_buffer_show):
2374 * insdel.c (signal_before_change):
2375 * frame.c (Fhandle_switch_frame):
2376 * fileio.c (Fdo_auto_save):
2377 * emacs.c (Fkill_emacs):
2378 * editfns.c (save_excursion_restore):
2379 * cmds.c (internal_self_insert):
2380 * callint.c (Fcall_interactively):
2381 * buffer.c (Fkill_all_local_variables):
2382 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2383 Use Frun_hooks.
2384 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
2385 unconditionnaly since it does the check itself.
2386
2387 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
2388
2389 Fix more problems found by GCC 4.5.2's static checks.
2390
2391 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2392 the first time through the loop, since we know p0 < p1 then.
2393 This also avoids a gcc -Wstrict-overflow warning.
2394
2395 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2396 leading to a memory leak, possible in functions like
2397 load_charset_map_from_file that can allocate an unbounded number
2398 of objects (Bug#8318).
2399
2400 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2401 that could (at least in theory) be that large.
2402
2403 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2404 This is less likely to overflow, and avoids undefined behavior if
2405 overflow does occur. All callers changed. Use strtoul to scan
2406 for the unsigned long integer.
2407 (pint2hrstr): Simplify and tune code slightly.
2408 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
2409
2410 * scroll.c (do_scrolling): Work around GCC bug 48228.
2411 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2412
2413 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2414 This also avoids a warning with gcc -Wstrict-overflow.
2415 (validate_x_resource_name): Simplify count usage.
2416 This also avoids a warning with gcc -Wstrict-overflow.
2417
2418 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2419 fail (Bug#8306).
2420
2421 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
2422
2423 * process.c (Fmake_network_process): Use socklen_t, not int,
2424 where POSIX says socklen_t is required in portable programs.
2425 This fixes a porting bug on hosts like 64-bit HP-UX, where
2426 socklen_t is wider than int (Bug#8277).
2427 (Fmake_network_process, server_accept_connection):
2428 (wait_reading_process_output, read_process_output):
2429 Likewise.
2430
2431 * process.c: Rename or move locals to avoid shadowing.
2432 (list_processes_1, Fmake_network_process):
2433 (read_process_output_error_handler, exec_sentinel_error_handler):
2434 Rename or move locals.
2435 (Fmake_network_process): Define label "retry_connect" only if needed.
2436 (Fnetwork_interface_info): Fix pointer signedness.
2437 (process_send_signal): Add cast to avoid pointer signedness problem.
2438 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
2439 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
2440
2441 Make tparam.h and terminfo.c consistent.
2442 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2443 Include tparam.h instead, since it declares them.
2444 * cm.h (PC): Remove extern decl; tparam.h now does this.
2445 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2446 * terminfo.c: Include tparam.h, to check interfaces.
2447 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2448 (tparam): Adjust signature to match interface in tparam.h;
2449 this removes some undefined behavior. Check that outstring and len
2450 are zero, which they always are with Emacs.
2451 * tparam.h (PC, BC, UP): New extern decls.
2452
2453 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
2454 (xftfont_open): Rename locals to avoid shadowing.
2455
2456 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
2457 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2458 (OTF_TAG_SYM): Omit macro if not needed.
2459 (ftfont_list): Remove unused local.
2460 (get_adstyle_property, ftfont_pattern_entity):
2461 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2462 Rename locals to avoid shadowing.
2463
2464 * xfont.c (xfont_list_family): Mark var as initialized.
2465
2466 * xml.c (make_dom): Now static.
2467
2468 * composite.c (composition_compute_stop_pos): Rename local to
2469 avoid shadowing.
2470 (composition_reseat_it): Remove unused locals.
2471 (find_automatic_composition, composition_adjust_point): Likewise.
2472 (composition_update_it): Mark var as initialized.
2473 (find_automatic_composition): Mark vars as initialized,
2474 with a FIXME (Bug#8290).
2475
2476 character.h: Rename locals to avoid shadowing.
2477 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2478 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2479 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2480 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2481 to avoid shadowing.
2482
2483 * textprop.c (property_change_between_p): Remove; unused.
2484
2485 * intervals.c (interval_start_pos): Now static.
2486
2487 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2488
2489 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2490 Rename locals to avoid shadowing.
2491
2492 * sound.c (wav_play, au_play, Fplay_sound_internal):
2493 Fix pointer signedness.
2494 (alsa_choose_format): Remove unused local var.
2495 (wav_play): Initialize a variable to 0, to prevent undefined
2496 behavior (Bug#8278).
2497
2498 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2499
2500 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2501
2502 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2503 clobbering (Bug#8298).
2504 * sysdep.c (sys_subshell): Likewise.
2505 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
2506
2507 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2508 This should get cleaned up, so that child_setup has the
2509 same signature on all platforms.
2510
2511 * callproc.c (call_process_cleanup): Now static.
2512 (relocate_fd): Rename locals to avoid shadowing.
2513
2514 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
2515
2516 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2517 not to be necessary, and produces flickering.
2518
2519 2011-03-20 Glenn Morris <rgm@gnu.org>
2520
2521 * config.in: Remove file.
2522
2523 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
2524
2525 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2526 are now in src/globals.h.
2527 (syms_of_minibuf): Remove spurious & from previous change.
2528
2529 2011-03-20 Leo <sdl.web@gmail.com>
2530
2531 * minibuf.c (completing-read-function): New variable.
2532 (completing-read-default): Rename from completing-read.
2533 (completing-read): Call completing-read-function.
2534
2535 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2536
2537 * xfaces.c (Fx_load_color_file):
2538 Read color file from absolute filename (bug#8250).
2539
2540 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2541
2542 * makefile.w32-in: Update dependencies.
2543
2544 2011-03-17 Eli Zaretskii <eliz@gnu.org>
2545
2546 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2547
2548 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2549
2550 Fix more problems found by GCC 4.5.2's static checks.
2551
2552 * process.c (make_serial_process_unwind, send_process_trap):
2553 (sigchld_handler): Now static.
2554
2555 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2556 That way, the code declares only the vars that it needs.
2557 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2558 * s/cygwin.h (PTY_ITERATION): Likewise.
2559 * s/darwin.h (PTY_ITERATION): Likewise.
2560 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2561
2562 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2563 * process.c (allocate_pty): Don't declare stb unless it's needed.
2564
2565 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
2566 (CONSTANTLIM): Remove; unused.
2567 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2568 Define only if needed.
2569
2570 * unexelf.c (unexec): Name an expression,
2571 to avoid gcc -Wbad-function-cast warning.
2572 Use a different way to cause a compilation error if anyone uses
2573 n rather than nn, a way that does not involve shadowing.
2574 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
2575
2576 * deps.mk (unexalpha.o): Remove; unused.
2577
2578 New file unexec.h, the (simple) interface for unexec (Bug#8267).
2579 * unexec.h: New file.
2580 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2581 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2582 Depend on unexec.h.
2583 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2584 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2585 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
2586 Change as necessary to match prototype in unexec.h.
2587
2588 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2589 shadowing.
2590 (back_comment, skip_chars): Mark vars as initialized.
2591
2592 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2593 Rename locals to avoid shadowing.
2594
2595 * lread.c (read1): Rewrite so as not to use empty "else".
2596 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
2597
2598 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2599
2600 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2601 warning when compiling print.c.
2602
2603 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2604 instead of using an uninitialized var.
2605 (font_sort_entities): Mark var as initialized.
2606
2607 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2608
2609 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2610 pointers to constants.
2611 (font_parse_fcname): Remove unused vars.
2612 (font_delete_unmatched): Now static.
2613 (font_get_spec): Remove; unused.
2614 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2615 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2616 Rename or move locals to avoid shadowing.
2617
2618 * fns.c (require_nesting_list, require_unwind): Now static.
2619 (Ffillarray): Rename locals to avoid shadowing.
2620
2621 * floatfns.c (domain_error2): Define only if needed.
2622 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
2623
2624 * alloc.c (mark_backtrace): Move decl from here ...
2625 * lisp.h: ... to here, so that it can be checked.
2626
2627 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
2628 (Fdefvar): Rewrite so as not to use empty "else".
2629 (lisp_indirect_variable): Name an expression,
2630 to avoid gcc -Wbad-function-cast warning.
2631 (Fdefvar): Rename locals to avoid shadowing.
2632
2633 * callint.c (quotify_arg, quotify_args): Now static.
2634 (Fcall_interactively): Rename locals to avoid shadowing.
2635 Use const pointer when appropriate.
2636
2637 * lisp.h (get_system_name, get_operating_system_release):
2638 Move decls here, to check interfaces.
2639 * process.c (get_operating_system_release): Move decl to lisp.h.
2640 * xrdb.c (get_system_name): Likewise.
2641 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2642 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2643 some of which prompt warnings from gcc -Wbad-function-cast.
2644 (Fformat_time_string, Fencode_time, Finsert_char):
2645 (Ftranslate_region_internal, Fformat):
2646 Rename or remove local vars to avoid shadowing.
2647 (Ftranslate_region_internal): Mark var as initialized.
2648
2649 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2650 avoid shadowing.
2651
2652 * lisp.h (eassert): Check that the argument compiles, even if
2653 ENABLE_CHECKING is not defined.
2654
2655 * data.c (Findirect_variable): Name an expression, to avoid
2656 gcc -Wbad-function-cast warning.
2657 (default_value, arithcompare, arith_driver, arith_error): Now static.
2658 (store_symval_forwarding): Rename local to avoid shadowing.
2659 (Fmake_variable_buffer_local, Fmake_local_variable):
2660 Mark variables as initialized.
2661 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
2662
2663 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
2664 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2665 Rename locals to avoid shadowing.
2666 (mark_stack): Move local variables into the #ifdef region where
2667 they're used.
2668 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2669 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2670 needed otherwise.
2671 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2672 (GC_STRING_CHARS): Remove; not used.
2673 (Fmemory_limit): Cast sbrk's returned value to char *.
2674
2675 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2676 avoids undefined behavior in theory.
2677
2678 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2679
2680 Use functions, not macros, for up- and down-casing (Bug#8254).
2681 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2682 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2683 to use the following functions instead of these macros.
2684 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2685 EMACS_INT, since callers assume the returned value fits in int.
2686 (upcase1): Likewise, for UPCASE_TABLE.
2687 (uppercasep, lowercasep, upcase): New static inline functions.
2688 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
2689 the race-condition problem in the old DOWNCASE.
2690
2691 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2692 Rename locals to avoid shadowing.
2693 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
2694 (regex_compile, re_search_2, re_match_2_internal):
2695 Remove unused local vars.
2696 (FREE_VAR): Rewrite so as not to use empty "else",
2697 which gcc can warn about.
2698 (regex_compile, re_match_2_internal): Mark locals as initialized.
2699 (RETALLOC_IF): Define only if needed.
2700 (WORDCHAR_P): Likewise. This one is never needed, but is used
2701 only in a comment talking about a compiler bug, so put inside
2702 the #if 0 of that comment.
2703 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2704 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2705 Remove; unused.
2706
2707 * search.c (boyer_moore): Rename locals to avoid shadowing.
2708 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2709 (PREV_CHAR_BOUNDARY): Likewise.
2710
2711 * search.c (simple_search): Remove unused var.
2712
2713 * dired.c (compile_pattern): Move decl from here ...
2714 * lisp.h: ... to here, so that it can be checked.
2715 (struct re_registers): New forward decl.
2716
2717 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2718
2719 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2720 All uses changed.
2721 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2722 Rename locals to avoid shadowing.
2723 (Fvertical_motion): Mark locals as initialized.
2724
2725 * casefiddle.c (casify_object, casify_region): Now static.
2726 (casify_region): Mark local as initialized.
2727
2728 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2729
2730 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2731 New macros, so that the caller can use some names other than
2732 gcpro1, gcpro2, etc.
2733 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2734 of the new macros.
2735 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2736 argument, for consistency with GCPRO2_VAR, etc: it is now the
2737 prefix of the variable, not the variable itself. All uses
2738 changed.
2739 * dired.c (directory_files_internal, file_name_completion):
2740 Rename locals to avoid shadowing.
2741
2742 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2743 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2744 dired.c's scmp function, had undefined behavior.
2745 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2746 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2747 * buffer.h: ... to here, because these macros use current_buffer,
2748 and the new implementation with inline functions needs to have
2749 current_buffer in scope now, rather than later when the macros
2750 are used.
2751 (downcase, upcase1): New static inline functions.
2752 (DOWNCASE, UPCASE1): Reimplement using these functions.
2753 This avoids undefined behavior in expressions like
2754 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2755 from race conditions in accessing the global variables
2756 case_temp1 and case_temp2.
2757 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2758 * lisp.h (case_temp1, case_temp2): Remove their decls.
2759 * character.h (ASCII_CHAR_P): Move from here ...
2760 * lisp.h: ... to here, so that the inline functions mentioned
2761 above can use them.
2762
2763 * dired.c (directory_files_internal_unwind): Now static.
2764
2765 * fileio.c (file_name_as_directory, directory_file_name):
2766 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2767 Now static.
2768 (file_name_as_directory): Use const pointers when appropriate.
2769 (Fexpand_file_name): Likewise. In particular, newdir might
2770 point at constant storage, so make it a const pointer.
2771 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
2772 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2773 signedness issues.
2774 (Fset_file_times, Finsert_file_contents, auto_save_error):
2775 Rename locals to avoid shadowing.
2776
2777 * minibuf.c (choose_minibuf_frame_1): Now static.
2778 (Ftry_completion, Fall_completions): Rename or remove locals
2779 to avoid shadowing.
2780
2781 * marker.c (bytepos_to_charpos): Remove; unused.
2782
2783 * lisp.h (verify_bytepos, count_markers): New decls,
2784 so that gcc does not warn that these functions aren't declared.
2785
2786 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2787 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
2788 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
2789 (copy_text): Remove unused local var.
2790
2791 * filelock.c (within_one_second): Now static.
2792 (lock_file_1): Rename local to avoid shadowing.
2793
2794 * buffer.c (fix_overlays_before): Mark locals as initialized.
2795 (fix_start_end_in_overlays): Likewise. This function should be
2796 simplified by using pointers-to-pointers, but that's a different
2797 matter.
2798 (switch_to_buffer_1): Now static.
2799 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2800 (report_overlay_modification): Rename locals to avoid shadowing.
2801
2802 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
2803 Fix pointer signedness issue.
2804 (sys_subshell): Mark local as volatile if checking for lint,
2805 to suppress a gcc -Wclobbered warning that does not seem to be right.
2806 (MAXPATHLEN): Define only if needed.
2807
2808 * process.c (serial_open, serial_configure): Move decls from here ...
2809 * systty.h: ... to here, so that they can be checked.
2810
2811 * fns.c (get_random, seed_random): Move extern decls from here ...
2812 * lisp.h: ... to here, so that they can be checked.
2813
2814 * sysdep.c (reset_io): Now static.
2815 (wait_for_termination_signal): Remove; unused.
2816
2817 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2818 (copy_keymap_item, append_key, push_text_char_description):
2819 Now static.
2820 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
2821 (DENSE_TABLE_SIZE): Remove; unused.
2822 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2823 (describe_map_tree):
2824 Rename locals to avoid shadowing.
2825
2826 * keyboard.c: Declare functions static if they are not used elsewhere.
2827 (echo_char, echo_dash, cmd_error, top_level_2):
2828 (poll_for_input, handle_async_input): Now static.
2829 (read_char, kbd_buffer_get_event, make_lispy_position):
2830 (make_lispy_event, make_lispy_movement, apply_modifiers):
2831 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2832 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2833 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
2834 (read_key_sequence, read_char): Mark locals as initialized.
2835 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2836
2837 * keyboard.h (make_ctrl_char): New decl.
2838 (mark_kboards): Move decl here ...
2839 * alloc.c (mark_kboards): ... from here.
2840
2841 * lisp.h (force_auto_save_soon): New decl.
2842
2843 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
2844 (DEFINE_DUMMY_FUNCTION): New macro.
2845 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2846 Use it.
2847 (main): Add casts to avoid warnings
2848 if GCC considers string literals to be constants.
2849
2850 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2851
2852 * dbusbind.c: Pointer signedness fixes.
2853 (xd_signature, xd_append_arg, xd_initialize):
2854 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2855 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2856 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2857 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2858
2859 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2860 if GCC considers string literals to be constants.
2861 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
2862
2863 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2864
2865 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2866 (print_preprocess, print_object): New macro to fix last change.
2867
2868 * print.c (print_preprocess): Don't forget font objects.
2869
2870 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
2871
2872 * emacs.c (USAGE3): Doc fixes.
2873
2874 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2875
2876 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2877 structure.
2878
2879 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
2880
2881 * lisp.h (VWindow_system, Qfile_name_history):
2882 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2883 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2884 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2885
2886 * w32select.c: Don't #include "keyboard.h".
2887 (run_protected): Add extern declaration for waiting_for_input.
2888
2889 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2890 * w32console.c (detect_input_pending, read_input_pending)
2891 (encode_terminal_code):
2892 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2893 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2894 (w32_system_caret_y, Qfile_name_history):
2895 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2896 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2897 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2898 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2899 * w32proc.c (Qlocal, report_file_error):
2900 * w32term.c (Vwindow_system, updating_frame):
2901 * w32uniscribe.c (initialized, uniscribe_font_driver):
2902 Remove unneeded extern declarations.
2903
2904 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
2905
2906 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2907
2908 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
2909
2910 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2911 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2912 These macros can no longer be used for assignment.
2913
2914 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2915 Assign struct members directly, instead of using BUF_BEGV etc.
2916 (record_buffer_markers, fetch_buffer_markers): New functions for
2917 recording and fetching special buffer markers.
2918 (set_buffer_internal_1, set_buffer_temp): Use them.
2919
2920 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2921
2922 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2923
2924 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2925 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2926
2927 * xdisp.c (hscroll_window_tree):
2928 (reconsider_clip_changes): Use PT instead of BUF_PT.
2929
2930 2011-03-13 Eli Zaretskii <eliz@gnu.org>
2931
2932 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2933 $(EMACS_ROOT)/lib/intprops.h.
2934
2935 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2936
2937 Fix more problems found by GCC 4.5.2's static checks.
2938
2939 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2940 to unsigned char * to avoid compiler diagnostic.
2941 (xg_free_frame_widgets): Make it clear that a local variable is
2942 needed only if USE_GTK_TOOLTIP.
2943 (gdk_window_get_screen): Make it clear that this macro is needed
2944 only if USE_GTK_TOOLTIP.
2945 (int_gtk_range_get_value): New function, which avoids a diagnostic
2946 from gcc -Wbad-function-cast.
2947 (xg_set_toolkit_scroll_bar_thumb): Use it.
2948 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2949 diagnostic from gcc -Wbad-function-cast.
2950 (get_utf8_string, xg_get_file_with_chooser):
2951 Rename locals to avoid shadowing.
2952 (create_dialog): Move locals to avoid shadowing.
2953
2954 * xgselect.c (xg_select): Remove unused var.
2955
2956 * image.c (four_corners_best): Mark locals as initialized.
2957 (gif_load): Initialize transparent_p to zero (Bug#8238).
2958 Mark another local as initialized.
2959 (my_png_error, my_error_exit): Mark with NO_RETURN.
2960
2961 * image.c (clear_image_cache): Now static.
2962 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
2963 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
2964 (x_edge_detection): Remove unnecessary cast that
2965 gcc -Wbad-function-cast diagnoses.
2966 (gif_load): Fix pointer signedness.
2967 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2968 (jpeg_load, gif_load): Rename locals to avoid shadowing.
2969
2970 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
2971
2972 Improve quality of tests for time stamp overflow.
2973 For example, without this patch (encode-time 0 0 0 1 1
2974 1152921504606846976) returns the obviously-bogus value (-948597
2975 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2976 reports time overflow. See
2977 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
2978 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2979 * editfns.c: Include limits.h and intprops.h.
2980 (TIME_T_MIN, TIME_T_MAX): New macros.
2981 (time_overflow): Move earlier, to before first use.
2982 (hi_time, lo_time): New functions, for an accurate test for
2983 out-of-range times.
2984 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2985 (Fget_internal_run_time): Don't assume time_t fits in int.
2986 (make_time): Use list2 instead of Fcons twice.
2987 (Fdecode_time): More accurate test for out-of-range times.
2988 (check_tm_member): New function.
2989 (Fencode_time): Use it, to test for out-of-range times.
2990 (lisp_time_argument): Don't rely on undefined left-shift and
2991 right-shift behavior when checking for time stamp overflow.
2992
2993 * editfns.c (time_overflow): New function, refactoring common code.
2994 (Fformat_time_string, Fdecode_time, Fencode_time):
2995 (Fcurrent_time_string): Use it.
2996
2997 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2998 * dired.c (make_time): Move to ...
2999 * editfns.c (make_time): ... here.
3000 * systime.h: Note the move.
3001
3002 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3003
3004 * fringe.c (update_window_fringes): Remove unused variables.
3005
3006 * unexmacosx.c (copy_data_segment): Also copy __got section.
3007 (Bug#8223)
3008
3009 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3010
3011 * termcap.c [MSDOS]: Include "msdos.h".
3012 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3013 Constify `char *' arguments and their references according to
3014 prototypes in tparam.h.
3015
3016 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3017
3018 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3019 Adapt all references accordingly.
3020
3021 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3022
3023 2011-03-11 Tom Tromey <tromey@redhat.com>
3024
3025 * buffer.c (syms_of_buffer): Remove obsolete comment.
3026
3027 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3028
3029 * termhooks.h (encode_terminal_code): Declare prototype.
3030
3031 * msdos.c (encode_terminal_code): Don't declare prototype.
3032
3033 * term.c (encode_terminal_code): Now external again, used by
3034 w32console.c and msdos.c.
3035
3036 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3037 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3038
3039 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3040
3041 Fix some minor problems found by GCC 4.5.2's static checks.
3042
3043 * fringe.c (update_window_fringes): Mark locals as initialized
3044 (Bug#8227).
3045 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3046
3047 * alloc.c (mark_fringe_data): Move decl from here ...
3048 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3049 to check its interface.
3050 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3051
3052 * fontset.c (free_realized_fontset): Now static.
3053 (Fset_fontset_font): Rename local to avoid shadowing.
3054 (fontset_font): Mark local as initialized.
3055 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3056
3057 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3058
3059 * xselect.c (x_disown_buffer_selections): Remove; not used.
3060 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3061 (x_own_selection, Fx_disown_selection_internal): Rename locals
3062 to avoid shadowing.
3063 (x_handle_dnd_message): Remove local to avoid shadowing.
3064
3065 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3066 so that the caller can use some name other than gcpro1.
3067 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3068 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3069 (Fx_backspace_delete_keys_p):
3070 Use them to avoid shadowing, and rename vars to avoid shadowing.
3071 (x_decode_color, x_set_name, x_window): Now static.
3072 (Fx_create_frame): Add braces to silence GCC warning.
3073 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3074 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3075 Remove unused locals.
3076 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3077 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3078 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3079 macros.
3080
3081 * xterm.h (x_mouse_leave): New decl.
3082
3083 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3084 Remove unused functions.
3085 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3086 (x_calc_absolute_position): Now static.
3087 (XTread_socket): Don't define label "out" unless it's used.
3088 Don't declare local "event" unless it's used.
3089 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3090 unless they are used.
3091 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3092 (x_fatal_error_signal): Remove; not used.
3093 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3094 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3095 (x_error_catcher, x_connection_closed, x_error_handler):
3096 (x_error_quitter, xembed_send_message, x_iconify_frame):
3097 (my_log_handler): Rename locals to avoid shadowing.
3098 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3099 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3100
3101 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3102 Rename or move locals to avoid shadowing.
3103 (tty_defined_color, merge_face_heights): Now static.
3104 (free_realized_faces_for_fontset): Remove; not used.
3105 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3106 does not deduce is never used uninitialized.
3107 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3108 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3109
3110 * terminal.c (store_terminal_param): Now static.
3111
3112 * xmenu.c (menu_highlight_callback): Now static.
3113 (set_frame_menubar): Remove unused local.
3114 (xmenu_show): Rename parameter to avoid shadowing.
3115 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3116 since they might point to immutable storage.
3117 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3118 since it's unused otherwise.
3119
3120 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3121 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3122 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3123 avoids a gcc -Wuninitialized diagnostic.
3124 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3125 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3126 does not deduce are never used uninitialized.
3127
3128 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3129
3130 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3131 * window.c (window_loop, size_window):
3132 (run_window_configuration_change_hook, enlarge_window): Likewise.
3133
3134 * window.c (display_buffer): Now static.
3135 (size_window): Mark variables that gcc -Wuninitialized
3136 does not deduce are never used uninitialized.
3137 * window.h (check_all_windows): New decl, to forestall
3138 gcc -Wmissing-prototypes diagnostic.
3139 * dispextern.h (bidi_dump_cached_states): Likewise.
3140
3141 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3142 shadowing.
3143 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3144 Include <limits.h>.
3145 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3146 and to avoid gcc -Wuninitialized warning.
3147 (load_charset_map): Mark variables that gcc -Wuninitialized
3148 does not deduce are never used uninitialized.
3149 (load_charset): Abort instead of using uninitialized var (Bug#8229).
3150
3151 * coding.c (coding_set_source, coding_set_destination):
3152 Use "else { /* comment */ }" rather than "else /* comment */;"
3153 for clarity, and to avoid gcc -Wempty-body warning.
3154 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3155 a block, when the outer 'i' will do.
3156 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3157 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3158 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3159 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3160 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3161 Rename locals to avoid shadowing.
3162 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
3163 * coding.c (emacs_mule_char, encode_invocation_designation):
3164 Now static, since they're not used elsewhere.
3165 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
3166 (decode_coding_object, encode_coding_object, detect_coding_system):
3167 (decode_coding_emacs_mule): Mark variables that gcc
3168 -Wuninitialized does not deduce are never used uninitialized.
3169 (detect_coding_iso_2022): Initialize a local variable that might
3170 be used uninitialized. Leave a FIXME because it's not clear that
3171 this initialization is needed. (Bug#8211)
3172 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3173 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3174 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3175 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3176 Remove unused macros.
3177
3178 * category.c (hash_get_category_set): Remove unused local var.
3179 (copy_category_table): Now static, since it's not used elsewhere.
3180 * character.c (string_count_byte8): Likewise.
3181
3182 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3183 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3184
3185 * chartab.c (copy_sub_char_table): Now static, since it's not used
3186 elsewhere.
3187 (sub_char_table_ref_and_range, char_table_ref_and_range):
3188 Rename locals to avoid shadowing.
3189 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
3190
3191 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
3192 (BIDI_BOB): Remove unused macro.
3193
3194 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3195 deduce are never used uninitialized.
3196 * term.c (encode_terminal_code): Likewise.
3197
3198 * term.c (encode_terminal_code): Now static. Remove unused local.
3199
3200 * tparam.h: New file.
3201 * term.c, tparam.h: Include it.
3202 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3203 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3204 Move these decls to tparam.h, and make them agree with what
3205 is actually in tparam.c. The previous trick of using incompatible
3206 decls in different modules does not conform to the C standard.
3207 All callers of tparam changed to use tparam's actual API.
3208 * tparam.c (tparam1, tparam, tgoto):
3209 Use const pointers where appropriate.
3210
3211 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3212 * cm.h (struct cm): Likewise.
3213 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3214 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3215 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3216 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3217 (turn_on_face, init_tty): Likewise.
3218 * termchar.h (struct tty_display_info): Likewise.
3219
3220 * term.c (term_mouse_position): Rename local to avoid shadowing.
3221
3222 * alloc.c (mark_ttys): Move decl from here ...
3223 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3224
3225 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3226
3227 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3228
3229 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
3230
3231 * search.c (compile_pattern_1): Remove argument regp, unused since
3232 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3233 (compile_pattern): Don't pass it.
3234
3235 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3236
3237 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3238 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3239 for ! HAVE_GTK3.
3240 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3241
3242 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3243
3244 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3245 gdk_window_get_screen, gdk_window_get_geometry,
3246 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3247 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3248 (xg_get_pixbuf_from_pixmap): New function.
3249 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3250 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3251 Call xg_get_pixbuf_from_pixmap instead of
3252 gdk_pixbuf_get_from_drawable.
3253 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3254 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3255 (xg_check_special_colors): Use GtkStyleContext and its functions
3256 for HAVE_GTK3.
3257 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3258 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3259 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
3260 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3261 Call gtk_widget_get_preferred_size.
3262 (xg_frame_resized): gdk_window_get_geometry only takes 5
3263 parameters.
3264 (xg_win_to_widget, xg_event_is_for_menubar):
3265 Call gdk_x11_window_lookup_for_display.
3266 (xg_set_widget_bg): New function.
3267 (delete_cb): New function.
3268 (xg_create_frame_widgets): Connect delete-event to delete_cb.
3269 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3270 (xg_set_background_color): Call xg_set_widget_bg.
3271 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3272 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3273 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3274 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3275 if ! HAVE_GTK3.
3276 (update_frame_tool_bar): Call gtk_widget_hide.
3277 (xg_initialize): Use GDK_KEY_g.
3278
3279 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3280 if ! HAVE_GTK3
3281 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3282
3283 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3284 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3285 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3286
3287 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
3288
3289 * w32xfns.c (select_palette): Check success of RealizePalette against
3290 GDI_ERROR, not zero.
3291
3292 See ChangeLog.11 for earlier changes.
3293
3294 ;; Local Variables:
3295 ;; coding: utf-8
3296 ;; End:
3297
3298 Copyright (C) 2011 Free Software Foundation, Inc.
3299
3300 This file is part of GNU Emacs.
3301
3302 GNU Emacs is free software: you can redistribute it and/or modify
3303 it under the terms of the GNU General Public License as published by
3304 the Free Software Foundation, either version 3 of the License, or
3305 (at your option) any later version.
3306
3307 GNU Emacs is distributed in the hope that it will be useful,
3308 but WITHOUT ANY WARRANTY; without even the implied warranty of
3309 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3310 GNU General Public License for more details.
3311
3312 You should have received a copy of the GNU General Public License
3313 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.