1 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3 Fix up display of the *Minibuf-0* buffer in the mini window.
4 * keyboard.c (read_char): Don't clear the echo area if there's no
6 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
7 contents of *Minibuf-0*) if there's no message displayed in its stead.
9 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
11 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
14 2012-05-06 Chong Yidong <cyd@gnu.org>
16 * lisp.mk (lisp): Update.
18 2012-05-05 Jim Meyering <meyering@redhat.com>
20 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
22 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
24 * data.c (PUT_ERROR): New macro.
25 (syms_of_data): Use it. Add new error type `user-error'.
26 * undo.c (user_error): New function.
27 (Fprimitive_undo): Use it.
28 * print.c (print_error_message): Adjust print style for `user-error'.
29 * keyboard.c (user_error): New function.
30 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
32 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
34 Do not limit current-time-string to years 1000..9999.
35 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
36 (Fcurrent_time_string): Support any year that is supported by the
37 underlying localtime representation. Don't use asctime, as it
38 has undefined behavior for years outside the range -999..9999.
40 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
42 Fix race conditions involving setenv, gmtime, localtime, asctime.
43 Without this fix, interrupts could mess up code that uses these
44 nonreentrant functions, since setting TZ invalidates existing
45 tm_zone or tzname values, and since most of these functions return
46 pointers to static storage.
47 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
48 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
49 Grow the critical sections to include not just invoking
50 localtime/gmtime, but also accessing these functions' results
51 including their tm_zone values if any, and any related TZ setting.
52 (format_time_string): Last arg is now struct tm *, not struct tm **,
53 so that the struct tm is saved in the critical section.
54 All callers changed. Simplify allocation of initial buffer, partly
55 motivated by the fact that memory allocation needs to be outside
58 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
60 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
63 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
64 Remove duplicated buffer name initialization.
66 2012-05-02 Jim Meyering <jim@meyering.net>
68 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
70 * xfns.c (x_window): Use xstrdup (Bug#11375).
72 2012-05-02 Eli Zaretskii <eliz@gnu.org>
74 * xdisp.c (pos_visible_p): If already at a newline from the
75 display string before the 'while' loop, don't walk back the glyphs
76 from it3.glyph_row. Solves assertion violation when the display
77 string begins with a newline (egg.el). (Bug#11367)
79 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
81 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
84 2012-05-01 Glenn Morris <rgm@gnu.org>
86 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
87 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
88 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
89 All were removed before 23.1.
91 * dispnew.c: Remove HAVE_LIBNCURSES test;
92 it is always true on relevant platforms.
94 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
95 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
97 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
99 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
101 * .gdbinit (xpr): Remove checks for no longer existing misc types.
102 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
105 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
107 Do not avoid creating empty evaporating overlays (Bug#9642).
108 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
109 That is, do not delete an evaporating overlay if it becomes
110 empty after its bounds are adjusted to fit within its buffer.
111 This fix caused other problems, and I'm reverting it until we get
112 to the bottom of them.
114 2012-04-27 Chong Yidong <cyd@gnu.org>
116 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
118 2012-04-27 Eli Zaretskii <eliz@gnu.org>
120 * xdisp.c (pos_visible_p): If the window start position is beyond
121 ZV, start the display from buffer beginning. Prevents assertion
122 violation in init_iterator when the minibuffer window is scrolled
125 * window.c (window_scroll_pixel_based): Likewise.
127 2012-04-27 Chong Yidong <cyd@gnu.org>
129 * keymap.c (where_is_internal): Doc fix (Bug#10872).
131 2012-04-27 Glenn Morris <rgm@gnu.org>
133 * fileio.c (Fcopy_file, Fset_file_selinux_context):
134 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
136 2012-04-27 Eli Zaretskii <eliz@gnu.org>
138 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
139 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
141 2012-04-26 Eli Zaretskii <eliz@gnu.org>
143 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
144 display element, check also the underlying string or buffer
145 character. (Bug#11341)
147 * w32menu.c: Include w32heap.h.
148 (add_menu_item): If the call to AppendMenuW (via
149 unicode_append_menu) fails, disable Unicode menus only if we are
150 running on Windows 9X/Me.
152 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
154 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
155 (xgetint): Add missing shift for LSB tags.
157 2012-04-24 Martin Rudalics <rudalics@gmx.at>
159 * keyboard.c (read_char): Don't wipe echo area for select window
160 events: These might get delayed via `mouse-autoselect-window'
163 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
165 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
166 manipulation of :loaded-from data.
168 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
170 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
171 now a cons (bug#11311).
173 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
175 Do not create empty overlays with the evaporate property (Bug#9642).
176 * buffer.c (Fmove_overlay): Delete an evaporating overlay
177 if it becomes empty after its bounds are adjusted to fit within
178 its buffer. Without this fix, in a nonempty buffer (let ((o
179 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
180 yields an empty overlay that has the evaporate property, which is
181 not supposed to happen.
183 Fix minor GTK3 problems found by static checking.
184 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
185 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
186 (struct _EmacsFixedClass, emacs_fixed_get_type):
187 Move decls here from emacsgtkfixed.h, since they needn't be public.
188 (emacs_fixed_get_type): Now static.
189 (emacs_fixed_class_init): Omit unused local.
190 (emacs_fixed_child_type): Remove; unused.
191 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
192 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
193 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
194 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
195 (EMACS_FIXED_GET_CLASS): Remove; unused.
196 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
198 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
199 Problem reported by Juanma Barranquero for Windows -Wunused-function.
201 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
203 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
204 * gmalloc.c: (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
205 (__malloc_size_t, __malloc_ptrdiff_t):
206 Remove. All uses removed, replaced by the definiens if needed,
207 since we can assume C89 or better now.
208 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
209 (protect_malloc_state, align, get_contiguous_space)
210 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
211 (malloc_atfork_handler_child, malloc_enable_thread)
212 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
213 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
214 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
215 (special_realloc, _realloc_internal_nolock, _realloc_internal)
216 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
217 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
218 Define using prototypes, not old style.
219 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
220 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
221 (align): Don't assume that signed integer overflow wraps around.
222 Omit unused local var.
223 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
224 (_free_internal_nolock, memalign, mallochook, reallochook):
225 Omit no-longer-needed casts.
226 (valloc): Use getpagesize, not __getpagesize.
227 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
228 (struct hdr): The 'magic' member is now size_t, not unsigned long.
230 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
232 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
234 Move functions from C to Lisp. Make non-blocking method calls
235 the default. Implement further D-Bus standard interfaces.
237 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
238 (QCdbus_request_name_allow_replacement)
239 (QCdbus_request_name_replace_existing)
240 (QCdbus_request_name_do_not_queue)
241 (QCdbus_request_name_reply_primary_owner)
242 (QCdbus_request_name_reply_in_queue)
243 (QCdbus_request_name_reply_exists)
244 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
245 (QCdbus_registered_serial, QCdbus_registered_method)
246 (QCdbus_registered_signal): New Lisp objects.
247 (XD_DEBUG_MESSAGE): Use sizeof.
248 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
249 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
250 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
251 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
252 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
253 (xd_signature, xd_append_arg): Allow float for integer types.
254 (xd_get_connection_references): New function.
255 (xd_get_connection_address): Rename from xd_initialize.
256 Return cached address.
257 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
258 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
260 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
261 Return number of refcounts.
262 (Fdbus_get_unique_name): Make stronger parameter check.
263 (Fdbus_message_internal): New defun.
264 (Fdbus_call_method, Fdbus_call_method_asynchronously)
265 (Fdbus_method_return_internal, Fdbus_method_error_internal)
266 (Fdbus_send_signal, Fdbus_register_service)
267 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
268 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
269 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
270 (Vdbus_compiled_version, Vdbus_runtime_version)
271 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
272 (Vdbus_message_type_method_return, Vdbus_message_type_error)
273 (Vdbus_message_type_signal): New defvars.
274 (Vdbus_registered_buses, Vdbus_registered_objects_table):
277 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
279 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
280 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
281 Do not assume ptrdiff_t is the same width as 'int'.
283 * alloc.c: Handle unusual debugging option combinations.
284 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
285 since the two debugging options are incompatible.
286 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
288 (mem_init, mem_insert, mem_insert_fixup):
289 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
290 (NEED_MEM_INSERT): Remove; no longer needed.
292 2012-04-22 Leo Liu <sdl.web@gmail.com>
294 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
296 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
298 * sysdep.c [__FreeBSD__]: Minor cleanups.
299 (list_system_processes, system_process_attributes) [__FreeBSD__]:
300 Use Emacs indenting style more consistently. Avoid some casts.
301 Use 'double' consistently rather than mixing 'float' and 'double'.
303 2012-04-21 Eduard Wiebe <usenet@pusto.de>
305 * sysdep.c (list_system_processes, system_process_attributes):
306 Add implementation for FreeBSD (Bug#5243).
308 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
310 * lisp.mk (lisp): Update.
312 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
314 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
315 It is never used otherwise.
317 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
319 * print.c (print_preprocess): Only check print_depth if print-circle
321 (print_object): Check for cycles even when print-circle is nil and
322 print-gensym is t, but only check print_depth if print-circle is nil.
324 2012-04-20 Chong Yidong <cyd@gnu.org>
326 * process.c (wait_reading_process_output): If EIO occurs on a pty,
327 set the status to "failed" and ensure that sentinel is run.
329 2012-04-20 Glenn Morris <rgm@gnu.org>
331 * process.c (Fset_process_inherit_coding_system_flag)
332 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
333 (Fmake_network_process, Fmake_serial_process): Doc fix.
335 2012-04-20 Eli Zaretskii <eliz@gnu.org>
337 * xdisp.c (string_buffer_position_lim): Limit starting position to
339 (set_cursor_from_row): If called for a mode-line or header-line
340 row, return zero immediately.
341 (try_cursor_movement): If inside continuation line, don't back up
342 farther than the first row after the header line, if any.
343 Don't consider the header-line row as "partially visible", even if
344 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
346 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
348 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
351 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
352 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
354 configure: new option --enable-gcc-warnings (Bug#11207)
355 * Makefile.in (C_WARNINGS_SWITCH): Remove.
356 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
357 (ALL_CFLAGS): Use new macros rather than old.
358 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
359 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
360 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
361 -Wunused-result, -Wunused-variable. This should go away once
362 the Emacs and Gnulib regex code is merged.
363 (xmalloc, xrealloc): Now static.
365 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
367 * dired.c (Fsystem_groups): Remove unused local.
369 2012-04-17 Glenn Morris <rgm@gnu.org>
371 * dired.c (Fsystem_users): Doc fix.
373 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
375 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
376 (syms_of_dired): Add them.
378 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
380 Fix minor alloc.c problems found by static checking.
381 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
382 New extern decls, to avoid calling undeclared functions.
383 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
384 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
385 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
386 (NEED_MEM_INSERT): New macro.
387 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
388 Remove one incorrect comment and fix another.
390 Fix minor ralloc.c problems found by static checking.
391 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
392 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
393 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
394 (r_alloc_sbrk): Now static.
396 Improve ralloc.c interface checking.
397 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
398 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
399 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
400 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
401 [REL_ALLOC]: ... to here, to check interface.
402 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
403 Remove decls. This fixes an "It stinks!".
405 * alloc.c (which_symbols): Fix alignment issue / type clash.
407 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
409 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
410 (struct Lisp_Misc_Any): Likewise.
411 (struct Lisp_Free): Likewise.
412 * alloc.c (union aligned_Lisp_Symbol): Define.
413 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
414 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
415 (union aligned_Lisp_Misc): Define.
416 (MARKER_BLOCK_SIZE, struct marker_block): Use union
417 aligned_Lisp_Misc instead of union Lisp_Misc.
418 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
420 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
422 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
423 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
424 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
425 * s/netbsd.h, s/sol2-6.h:
426 Remove definition of GC_MARK_STACK, since the default now works.
427 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
428 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
429 no longer the default.
430 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
432 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
434 * lread.c (lisp_file_lexically_bound_p):
435 Fix hang at ";-*-\n" (bug#11238).
437 2012-04-14 Eli Zaretskii <eliz@gnu.org>
439 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
440 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
442 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
444 * nsterm.m (constrainFrameRect): Always constrain when there is only
445 one screen (Bug#10962).
447 2012-04-13 Ken Brown <kbrown@cornell.edu>
449 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
451 2012-04-13 Reuben Thomas <rrt@sc3d.org>
453 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
455 2012-04-11 Daniel Colascione <dancol@dancol.org>
457 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
458 against is gone. It's better to use vfork now so that when Cygwin
459 gains a new, working vfork, we use it automatically (bug#10398).
461 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
463 * window.c (save_window_save): Obey window-point-insertion-type.
465 2012-04-11 Glenn Morris <rgm@gnu.org>
467 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
469 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
471 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
473 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
475 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
476 (force_quit_count): New var.
477 (handle_interrupt): Use it.
479 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
481 * w32.c (w32_delayed_load): Record the full path of the library
482 being loaded (bug#10424).
484 2012-04-09 Glenn Morris <rgm@gnu.org>
486 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
487 not just in the obarray, before snarfing them. (Bug#11036)
489 * Makefile.in ($(leimdir)/leim-list.el):
490 Pass EMACS rather than BUILT_EMACS.
492 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
494 * process.c (make_process):
495 * process.h: Add integer `gnutls_handshakes_tried' member to
498 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
499 Add convenience `GNUTLS_LOG2i' macro.
501 * gnutls.c (gnutls_log_function2i): Convenience log function.
502 (emacs_gnutls_read): Use new log functions,
503 `gnutls_handshakes_tried' process member, and
504 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
505 attempts per process (connection).
507 2012-04-09 Chong Yidong <cyd@gnu.org>
509 * eval.c (Fuser_variable_p, user_variable_p_eh)
510 (lisp_indirect_variable): Functions deleted.
511 (Fdefvar): Caller changed.
513 * callint.c (Finteractive, Fcall_interactively):
514 * minibuf.c (Fread_variable): Callers changed.
516 2012-04-09 Eli Zaretskii <eliz@gnu.org>
518 * xdisp.c (set_cursor_from_row): If the display string appears in
519 the buffer at position that is closer to point than the position
520 after the display string, display the cursor on the first glyph of
521 the display string. Fixes cursor display when a 'display' text
522 property immediately follows invisible text. (Bug#11094)
524 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
526 composite.c: use 'double' consistently
527 * composite.c (get_composition_id): Use 'double' consistently
528 instead of converting 'float' to 'double' and vice versa; this is
529 easier to understand and avoids a GCC warning.
531 2012-04-09 Glenn Morris <rgm@gnu.org>
533 * Makefile.in: Generate leim-list with bootstrap-emacs, in
534 preparation for dumping it with emacs. (Bug#4789)
535 (leimdir): New variable.
536 ($(leimdir)/leim-list.el): New rule.
537 (emacs$(EXEEXT)): Depend on leim-list.el.
539 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
540 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
541 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
543 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
545 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
548 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
550 * xml.c (init_libxml2_functions) [WINDOWSNT]:
551 Remove unused local variable.
553 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
555 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
556 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
557 (mark_memory): Mark Lisp_Objects only if pointers might hide in
558 objects, as mark_maybe_pointer will catch them otherwise.
559 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
560 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
562 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
564 Fix typo that broke non-Windows builds.
565 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
567 2012-04-07 Eli Zaretskii <eliz@gnu.org>
569 Support building on MS-Windows with libxml2.
571 * makefile.w32-in (OBJ2): Add xml.$(O).
572 (GLOBAL_SOURCES): Add xml.c.
573 ($(BLD)/xml.$(O)): New dependency list.
575 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
576 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
577 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
578 [!WINDOWSNT]: New macros.
579 (init_libxml2_functions, libxml2_loaded_p): New functions.
580 (parse_region): Call fn_xmlCheckVersion instead of using the macro
581 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
582 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
583 Calls xmlCleanupParser only if libxml2 was loaded (or statically
585 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
586 Call init_libxml2_functions before calling libxml2 functions.
587 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
589 * emacs.c: Don't include libxml/parser.h.
590 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
591 xmlCleanupParser directly.
593 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
595 2012-04-07 Eli Zaretskii <eliz@gnu.org>
597 * indent.c (Fvertical_motion): If there is a display string at
598 point, use it.vpos to compute how many lines to backtrack after
599 move_it_to point. (Bug#11133)
601 2012-04-06 Eli Zaretskii <eliz@gnu.org>
603 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
604 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
605 about subtle differences between FETCH_CHAR* and STRING_CHAR*
606 macros related to unification of CJK characters. For the details,
607 see the discussion following the message here:
608 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
610 2012-04-04 Chong Yidong <cyd@gnu.org>
612 * keyboard.c (Vdelayed_warnings_list): Doc fix.
614 2012-04-01 Eli Zaretskii <eliz@gnu.org>
616 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
617 instead of alloca. (Bug#11138)
619 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
621 * w32menu.c (is_simple_dialog): Properly check lisp types.
624 2012-03-31 Eli Zaretskii <eliz@gnu.org>
626 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
627 position we get to after a call to move_it_to fails the
628 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
629 only if we wind up in a string from display property. (Bug#11063)
631 * window.c (Fdelete_other_windows_internal): Invalidate the row
632 and column information about mouse highlight, so that redisplay
633 restores it after reallocating the glyph matrices. (Bug#7464)
635 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
636 string comes from a `display' text property, use the buffer
637 position of that property as if we actually saw that position in
639 (move_it_by_lines): Remove the assertion that
640 "it->current_x == 0 && it->hpos == 0" which can be legitimately
641 violated when there's a before-string at the beginning of a line.
644 2012-03-30 Eli Zaretskii <eliz@gnu.org>
646 * xdisp.c (append_space_for_newline): If the default face was
647 remapped, use the remapped face for the appended newline.
648 (extend_face_to_end_of_line): Use the remapped default face for
649 extending the face to the end of the line.
650 (display_line): Call extend_face_to_end_of_line when the default
651 face was remapped. (Bug#11068)
653 2012-03-29 Eli Zaretskii <eliz@gnu.org>
655 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
657 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
659 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
661 2012-03-27 Glenn Morris <rgm@gnu.org>
663 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
666 2012-03-26 Kenichi Handa <handa@m17n.org>
668 * dispextern.h (struct glyph): Fix previous change. Change the
669 bit length of glyphless.ch to 25 (Bug#11082).
671 2012-03-26 Chong Yidong <cyd@gnu.org>
673 * keyboard.c (Vselection_inhibit_update_commands): New variable.
674 (command_loop_1): Use it; inhibit selection update for
675 handle-select-window too (Bug#8996).
677 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
679 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
681 2012-03-25 Kenichi Handa <handa@m17n.org>
683 * dispextern.h (struct glyph): Change the bit length of
684 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
686 2012-03-24 Eli Zaretskii <eliz@gnu.org>
688 * s/ms-w32.h (tzname): Include time.h before redirecting to
689 _tzname. Fixes the MSVC build. (Bug#9960)
691 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
693 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
696 * xterm.c (XTread_socket): Only modify handling_signal if
697 !SYNC_INPUT. (Bug#11080)
699 2012-03-23 Eli Zaretskii <eliz@gnu.org>
701 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
702 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
703 when fetching a multibyte character consumes more bytes than
704 CHAR_BYTES returns, due to unification of CJK characters in
705 string_char. (Bug#11073)
707 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
709 * process.c (wait_reading_process_output): Handle pty disconnect
710 by refraining from sending oneself a SIGCHLD (bug#10933).
712 2012-03-22 Chong Yidong <cyd@gnu.org>
714 * dispextern.h (struct it): New member string_from_prefix_prop_p.
716 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
717 Mark string as coming from a prefix property.
718 (handle_face_prop): Use default face for prefix strings (Bug#4281).
719 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
721 2012-03-21 Chong Yidong <cyd@gnu.org>
723 * xfaces.c (Vface_remapping_alist): Doc fix.
725 2012-03-20 Eli Zaretskii <eliz@gnu.org>
727 * w32proc.c (Fw32_set_console_codepage)
728 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
731 2012-03-20 Chong Yidong <cyd@gnu.org>
733 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
734 to reflect default non-nil value of redisplay-dont-pause.
736 2012-03-19 Kenichi Handa <handa@m17n.org>
738 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
739 it fit in a valid range (Bug#11003).
741 2012-03-18 Eli Zaretskii <eliz@gnu.org>
743 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
744 that is not from display property, accept the row as a "cursor
745 row" if one of the string's character has a non-nil `cursor'
746 property. Fixes cursor positioning when there are newlines in
747 overlay strings, e.g. in icomplete.el. (Bug#11035)
749 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
751 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
753 2012-03-12 Chong Yidong <cyd@gnu.org>
755 * eval.c (inhibit_lisp_code): Rename from
756 inhibit_window_configuration_change_hook; move from window.c.
758 * xfns.c (unwind_create_frame_1, Fx_create_frame):
759 * window.c (run_window_configuration_change_hook)
760 (syms_of_window): Callers changed.
762 2012-03-11 Chong Yidong <cyd@gnu.org>
764 * keymap.c (Fkey_description): Doc fix (Bug#9700).
766 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
768 2012-03-10 Chong Yidong <cyd@gnu.org>
770 * frame.c (other_visible_frames): Don't assume the selected frame
771 is visible (Bug#10955).
773 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
775 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
777 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
779 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
780 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
783 2012-03-03 Glenn Morris <rgm@gnu.org>
785 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
787 2012-03-02 Eli Zaretskii <eliz@gnu.org>
789 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
790 position past the first glyph_row that ends at ZV. (Bug#10902)
791 (redisplay_window, next_element_from_string): Fix typos in
793 (redisplay_window): Pass to move_it_vertically the margin in
794 pixels, not in screen lines.
796 2012-03-02 Glenn Morris <rgm@gnu.org>
798 * buffer.c (buffer-list-update-hook): Doc fix.
800 2012-02-29 Eli Zaretskii <eliz@gnu.org>
802 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
803 push_it before setting up the iterator for the first overlay
804 string, even if we have an empty string loaded.
805 (next_overlay_string): If there's an empty string on the iterator
806 stack, pop the stack. (Bug#10903)
808 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
810 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
811 Suggested by Stefan Monnier in
812 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
813 * alloc.c (widen_to_Lisp_Object): New static function.
814 (mark_memory): Also mark Lisp_Objects by fetching pointer words
815 and widening them to Lisp_Objects. This would work even if
816 USE_LSB_TAG is defined and wide integers are used, which might
817 happen in a future version of Emacs.
819 2012-02-25 Chong Yidong <cyd@gnu.org>
821 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
824 * xselect.c (Fx_selection_exists_p): Doc fix.
825 (x_clipboard_manager_save_all): Print an informative message
826 before saving to clipboard manager.
828 2012-02-24 Chong Yidong <cyd@gnu.org>
830 * keyboard.c (process_special_events): Handle all X selection
831 requests in kbd_buffer, not just the next one (Bug#8869).
833 2012-02-23 Chong Yidong <cyd@gnu.org>
835 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
836 call when setting menu-bar-lines and tool-bar-lines parameters.
837 (unwind_create_frame_1): New helper function.
839 * window.c (inhibit_window_configuration_change_hook): New var.
840 (run_window_configuration_change_hook): Obey it.
841 (syms_of_window): Initialize it.
843 2012-02-22 Chong Yidong <cyd@gnu.org>
845 * xterm.c (x_draw_image_relief): Add missing type check for
846 Vtool_bar_button_margin (Bug#10743).
848 2012-02-21 Chong Yidong <cyd@gnu.org>
850 * fileio.c (Vfile_name_handler_alist): Doc fix.
852 * buffer.c (Fget_file_buffer): Protect against invalid file
853 handler return value.
855 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
857 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
858 when computing $valmask.
860 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
861 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
862 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
863 It's useless in that case, and it can cause problems on hosts
864 that allocate halves of EMACS_INT values separately.
865 Reported by Dan Horák. Diagnosed by Andreas Schwab in
866 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
867 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
868 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
869 it avoids undefined behavior on hosts where shifting right by more
870 than the word width has undefined behavior.
872 2012-02-19 Chong Yidong <cyd@gnu.org>
874 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
875 (Funhandled_file_name_directory, Ffile_name_as_directory)
876 (Fdirectory_file_name, Fexpand_file_name)
877 (Fsubstitute_in_file_name): Protect against invalid file handler
878 return values (Bug#10845).
880 2012-02-18 Eli Zaretskii <eliz@gnu.org>
882 * .gdbinit (pitx): Fix incorrect references to fields of the
885 2012-02-17 Chong Yidong <cyd@gnu.org>
887 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
889 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
891 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
892 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
894 2012-02-15 Chong Yidong <cyd@gnu.org>
896 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
897 marked as special. Also, starting docstrings with * is obsolete.
899 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
901 * gnutls.c (emacs_gnutls_write): Fix last change.
903 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
905 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
908 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
910 * keymap.c (Fsingle_key_description): Handle char ranges.
912 2012-02-12 Chong Yidong <cyd@gnu.org>
914 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
915 as that creates a dangerous corner case.
917 * window.c (Fdelete_window_internal): Invalidate the mouse
918 highlight (Bug#9904).
920 2012-02-12 Glenn Morris <rgm@gnu.org>
922 * xselect.c (Fx_own_selection_internal)
923 (Fx_get_selection_internal, Fx_disown_selection_internal)
924 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
925 * nsselect.m (Fx_own_selection_internal)
926 (Fx_disown_selection_internal, Fx_selection_exists_p)
927 (Fx_selection_owner_p, Fx_get_selection_internal):
928 Sync docs and argument specs with the xselect.c versions.
930 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
932 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
934 2012-02-11 Eli Zaretskii <eliz@gnu.org>
936 * w32select.c (Fx_selection_exists_p): Sync doc string and
937 argument list with xselect.c. (Bug#10783)
939 * w16select.c (Fx_selection_exists_p): Sync doc string and
940 argument list with xselect.c. (Bug#10783)
942 2012-02-10 Glenn Morris <rgm@gnu.org>
944 * fns.c (Fsecure_hash): Doc fix.
946 2012-02-09 Kenichi Handa <handa@m17n.org>
948 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
950 2012-02-07 Chong Yidong <cyd@gnu.org>
952 * buffer.c (Fbuffer_local_variables)
953 (buffer_lisp_local_variables): Handle unbound vars correctly;
954 don't let Qunbound leak into Lisp.
956 2012-02-07 Glenn Morris <rgm@gnu.org>
958 * image.c (Fimagemagick_types): Doc fix.
960 * image.c (imagemagick-render-type): Change it from a lisp object
961 to an integer. Move the doc here from the lisp manual.
962 Treat all values not equal to 0 the same.
964 2012-02-06 Chong Yidong <cyd@gnu.org>
966 * doc.c (store_function_docstring): Avoid applying docstring of
967 alias to base function (Bug#2603).
969 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
971 * .gdbinit (pp1, pv1): Remove redundant defines.
974 2012-02-04 Chong Yidong <cyd@gnu.org>
976 * nsterm.m: Declare a global (Bug#10694).
978 2012-02-04 Eli Zaretskii <eliz@gnu.org>
980 * w32.c (get_emacs_configuration_options):
981 Include --enable-checking, if specified, in the return value.
983 2012-02-04 Martin Rudalics <rudalics@gmx.at>
985 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
986 after rounding frame sizes. (Bug#9723)
988 2012-02-04 Eli Zaretskii <eliz@gnu.org>
990 * keyboard.c (adjust_point_for_property): Don't position point
991 before BEGV. (Bug#10696)
993 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
995 Handle overflow when computing char display width (Bug#9496).
996 * character.c (char_width): Return EMACS_INT, not int.
997 (char_width, c_string_width): Check for overflow when
998 computing the width; this is possible now that individual
999 characters can have unbounded width. Problem introduced
1000 by merge from Emacs 23 on 2012-01-19.
1002 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
1004 * dbusbind.c (Fdbus_register_method): Mention the return value
1005 :ignore in the docstring.
1007 2012-02-02 Glenn Morris <rgm@gnu.org>
1009 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
1011 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1012 Unconditionally set to t. (Bug#10673)
1013 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1014 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
1015 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
1017 2012-02-02 Kenichi Handa <handa@m17n.org>
1019 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
1020 0, do not call append_composite_glyph.
1022 2012-02-02 Kenichi Handa <handa@m17n.org>
1024 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
1026 (x_produce_glyphs): If the component of a composition is a null
1027 string, set it->pixel_width to 1 to avoid zero-width glyph.
1029 2012-02-01 Eli Zaretskii <eliz@gnu.org>
1031 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
1032 first 2 arguments are identical. This makes inserting large
1033 output from a subprocess an order of magnitude faster on
1034 MS-Windows, where all sbrk'ed memory is always contiguous.
1036 2012-01-31 Glenn Morris <rgm@gnu.org>
1038 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1039 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
1040 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
1042 2012-01-29 Glenn Morris <rgm@gnu.org>
1044 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
1046 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
1048 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
1050 2012-01-28 Chong Yidong <cyd@gnu.org>
1052 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
1054 2012-01-26 Chong Yidong <cyd@gnu.org>
1056 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
1058 * search.c (Fsearch_forward, Fsearch_backward): Document negative
1059 repeat counts (Bug#10507).
1061 2012-01-26 Glenn Morris <rgm@gnu.org>
1063 * lread.c (syms_of_lread): Doc fix.
1065 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
1067 * coding.c (encode_designation_at_bol): Change return value to
1070 2012-01-25 Chong Yidong <cyd@gnu.org>
1072 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
1074 2012-01-21 Chong Yidong <cyd@gnu.org>
1076 * floatfns.c (Fcopysign): Make the second argument non-optional,
1077 since nil is not allowed anyway.
1079 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
1081 * process.c (read_process_output): Use p instead of XPROCESS (proc).
1082 (send_process): Likewise.
1084 2012-01-19 Martin Rudalics <rudalics@gmx.at>
1086 * window.c (save_window_save, Fcurrent_window_configuration)
1087 (Vwindow_persistent_parameters): Do not use Qstate.
1088 Rewrite doc-strings.
1090 2012-01-19 Kenichi Handa <handa@m17n.org>
1092 * character.c (char_width): New function.
1093 (Fchar_width, c_string_width, lisp_string_width):
1094 Use char_width (Bug#9496).
1096 2012-01-16 Martin Rudalics <rudalics@gmx.at>
1098 * window.c (Vwindow_persistent_parameters): New variable.
1099 (Fset_window_configuration, save_window_save): Handle persistent
1102 2012-01-14 Eli Zaretskii <eliz@gnu.org>
1104 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
1105 thrashing the stack of the thread. (Bug#9087)
1107 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
1109 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
1111 2012-01-11 Eli Zaretskii <eliz@gnu.org>
1113 * xdisp.c (rows_from_pos_range): Handle the case where the
1114 highlight ends on a newline. (Bug#10464)
1115 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
1116 he end column for display of highlight that ends on a newline
1119 2012-01-11 Glenn Morris <rgm@gnu.org>
1121 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
1122 from load-path also when installation-directory is nil. (Bug#10208)
1124 2012-01-10 Glenn Morris <rgm@gnu.org>
1126 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
1128 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
1129 Update template values to be closer to their typical values these days.
1131 2012-01-09 Eli Zaretskii <eliz@gnu.org>
1133 * xdisp.c (rows_from_pos_range): Accept additional argument
1134 DISP_STRING, and accept any glyph in a row whose object is that
1135 string as eligible for mouse highlight. Fixes mouse highlight of
1136 display strings from overlays. (Bug#10464)
1138 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
1140 emacs: fix an auto-save permissions race condition (Bug#10400)
1141 * fileio.c (auto_saving_dir_umask): New static var.
1142 (Fmake_directory_internal): Use it.
1143 (do_auto_save_make_dir): Set it, instead of invoking chmod after
1144 creating the directory. The old code temporarily assigns
1145 too-generous permissions to the directory.
1146 (do_auto_save_eh): Clear it.
1147 (Fdo_auto_save): Catch all errors, not just file errors, so
1148 that the var is always cleared.
1150 2012-01-07 Eli Zaretskii <eliz@gnu.org>
1152 * search.c (scan_buffer): Pass character positions to
1153 know_region_cache, not byte positions. (Bug#6540)
1155 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
1157 * w32.c (sys_rename): Report EXDEV when rename of a directory
1158 fails because the target is on another logical disk. (Bug#10284)
1160 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
1162 * xterm.c (x_embed_request_focus): New function.
1164 * xterm.h: Add prototype.
1166 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
1168 2012-01-05 Glenn Morris <rgm@gnu.org>
1170 * emacs.c (emacs_copyright): Update short copyright year to 2012.
1172 2012-01-01 Eli Zaretskii <eliz@gnu.org>
1174 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
1175 Load gnutls_transport_set_lowat only if GnuTLS version is below
1177 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
1178 GnuTLS versions below 2.11.1.
1180 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
1182 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
1183 to the doc string advising against its use for altering the way
1184 windows are scrolled.
1186 2011-12-28 Kenichi Handa <handa@m17n.org>
1188 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
1189 coding-system ASCII compatible only when it does not produce BOM
1190 on encoding (Bug#10383).
1192 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
1194 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
1196 (create_and_show_popup_menu): Always use menu_position_func for
1199 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
1201 * callint.c (Fcall_interactively): Don't truncate prompt string.
1203 2011-12-23 Eli Zaretskii <eliz@gnu.org>
1205 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
1206 property that ends at ZV, so that the bidi iteration could be
1207 resumed from there (after widening). (Bug#10360)
1209 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
1211 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
1213 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
1215 * nsterm.m (x_free_frame_resources):
1216 Release f->output_data.ns->miniimage.
1217 (ns_index_color): Fix indentation. Do not retain
1218 color_table->colors[i].
1220 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
1223 * nsfns.m (x_set_background_color): Assign return value from
1224 ns_index_color to face-background instead of NSColor*.
1225 (ns_implicitly_set_icon_type): Fix indentation.
1226 Change assignment in for loop to comparison.
1228 * emacs.c (ns_pool): New variable.
1229 (main): Assign ns_pool.
1230 (Fkill_emacs): Call ns_release_autorelease_pool.
1232 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1233 autorelease fdesc, release fdAttrs and tdict.
1234 (ns_get_covering_families): Release charset.
1235 (ns_findfonts): Release NSFontDescriptor created with new.
1236 (ns_uni_to_glyphs): Fix indentation.
1237 (setString): Release attrStr before assigning new value.
1239 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1241 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1243 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1244 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1246 2011-12-18 David Reitter <reitter@cmu.edu>
1248 * nsterm.m (ns_term_init): Subscribe for notifications
1249 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1250 to method trackingNotification in EmacsMenu.
1252 * nsmenu.m (trackingMenu): New variable.
1253 (trackingNotification): New method (from Aquamacs).
1254 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
1255 from Aquamacs (Bug#7030).
1257 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1259 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1260 (symbol_to_nsstring): Fix indentation.
1261 (ns_symbol_to_pb): New function.
1262 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1263 (Fns_rotate_cut_buffers_internal): Remove.
1264 (Fns_store_selection_internal): Rename from
1265 Fns_store_cut_buffer_internal.
1266 (ns_get_foreign_selection, Fx_own_selection_internal)
1267 (Fx_disown_selection_internal, Fx_selection_exists_p)
1268 (Fns_get_selection_internal, Fns_store_selection_internal):
1269 Use ns_symbol_to_pb and check if return value is nil.
1270 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1271 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
1272 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1273 renamed to Sns_store_selection_internal.
1274 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1275 and remove this function.
1276 (ns_handle_selection_clear): Remove, never used.
1277 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1280 2011-12-17 Ken Brown <kbrown@cornell.edu>
1282 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1283 GID is unknown (Bug#10257).
1285 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1287 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1288 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1289 which caused a build failure on GNU/Linux IA-64. This problem was
1290 introduced by my 2011-10-07 patch.
1292 2011-12-15 Juri Linkov <juri@jurta.org>
1294 * image.c (imagemagick_error): New function. (Bug#10112)
1295 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1296 Use `imagemagick_error' where ImageMagick functions return
1298 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1301 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1303 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1304 fill background (Bug#8992).
1306 2011-12-13 Martin Rudalics <rudalics@gmx.at>
1308 * window.c (Vwindow_combination_resize)
1309 (Vwindow_combination_limit): Use t instead of non-nil in
1311 (Vrecenter_redisplay): Add first sentence of doc-string on
1313 (Frecenter): Fix doc-string typo.
1315 2011-12-11 Kenichi Handa <handa@m17n.org>
1317 * coding.c (Funencodable_char_position): Pay attention to the
1318 buffer text relocation (Bug#9389).
1320 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1322 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1323 gtk_init (Bug#10100).
1325 2011-12-10 Eli Zaretskii <eliz@gnu.org>
1327 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1328 IT->string is nil. (Bug#10263)
1330 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1332 * nsterm.h (x_free_frame_resources): Declare.
1334 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1335 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1337 * nsterm.h (ns_get_defaults_value): Declare.
1339 * nsterm.m (ns_default): Call ns_get_defaults_value.
1341 2011-12-09 Eli Zaretskii <eliz@gnu.org>
1343 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1346 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1348 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1349 that where the value of an _OBJC_* symbol points to is in the .bss
1350 section (Bug#10240).
1352 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1354 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
1355 after the loop to call ccl_driver at least once (Bug#8619).
1357 2011-12-08 Kenichi Handa <handa@m17n.org>
1359 * ftfont.c (get_adstyle_property): Fix previous change
1362 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
1364 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1365 dirs from the default value of EMACSLOADPATH (bug#10208).
1367 2011-12-07 Glenn Morris <rgm@gnu.org>
1369 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1370 installation and source directories as well. (Bug#10208)
1372 2011-12-06 Chong Yidong <cyd@gnu.org>
1374 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1376 2011-12-06 Glenn Morris <rgm@gnu.org>
1378 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1379 as an error, not just -1. (Bug#10217)
1381 2011-12-05 Chong Yidong <cyd@gnu.org>
1383 * keyboard.c (process_special_events): New function.
1384 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1386 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1388 * coding.c (encode_designation_at_bol): Don't use uninitialized
1389 local variable (Bug#9318).
1391 2011-12-05 Kenichi Handa <handa@m17n.org>
1393 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1394 return Qnil (Bug#8046, Bug#10193).
1396 2011-12-05 Kenichi Handa <handa@m17n.org>
1398 * coding.c (encode_designation_at_bol): New args charbuf_end and
1399 dst. Return the number of produced bytes. Callers changed.
1400 (coding_set_source): Return how many bytes coding->source was
1402 (coding_set_destination): Return how many bytes
1403 coding->destination was relocated.
1404 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1405 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1407 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1409 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1410 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1413 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1415 The following changes are to fix Bug#9318.
1417 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1418 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1419 (encode_coding_iso_2022, encode_coding_sjis)
1420 (encode_coding_big5, encode_coding_charset): Use the above macros.
1422 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1424 * lisp.h (process_quit_flag): Fix external declaration.
1426 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1428 Don't macro-inline non-performance-critical code.
1429 * eval.c (process_quit_flag): New function.
1430 * lisp.h (QUIT): Use it.
1432 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1434 * nsfns.m (get_geometry_from_preferences): New function.
1435 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1437 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1439 * emacs.c (Qkill_emacs): Define.
1440 (syms_of_emacs): Initialize it.
1441 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1442 Qquit_flag to `kill-emacs' instead.
1443 (quit_throw_to_read_char): Add parameter `from_signal'.
1444 All callers changed. Call Fkill_emacs if requested and safe.
1445 * lisp.h (QUIT): Call Fkill_emacs if requested.
1447 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1449 * widget.c (update_wm_hints): Return if wmshell is null.
1450 (widget_update_wm_size_hints): New function.
1452 * widget.h (widget_update_wm_size_hints): Declare.
1454 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1455 widget_update_wm_size_hints (Bug#10104).
1457 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1459 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1460 before a newline, prepare the bidi iterator for consuming the
1461 newline, and keep the current paragraph direction. (Bug#10183)
1462 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1464 2011-12-02 Juri Linkov <juri@jurta.org>
1466 * search.c (Fword_search_regexp): New Lisp function created from
1467 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1468 (Fword_search_backward, Fword_search_forward)
1469 (Fword_search_backward_lax, Fword_search_forward_lax):
1470 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1471 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1473 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1475 * fileio.c (Finsert_file_contents): Move after-change-function call
1476 to before the "handled:" label, since all "goto handled" appear in
1477 cases where the *-change-functions have already been properly called
1480 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1482 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1483 waiting for input. (Bug#10169)
1485 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1487 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1488 verifies glyph row's hash code--we have just reallocated the
1489 glyphs, so their contents can be complete garbage. (Bug#10164)
1491 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1493 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1495 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1497 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1498 attributes are tested _before_ calling verify_row_hash, to protect
1499 against GCC re-ordering of the tests. (Bug#10164)
1501 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1503 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1505 * xterm.c (handle_one_xevent): Only set async_visible and friends
1506 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1507 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1508 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1510 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1512 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1513 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1514 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1515 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1516 All uses changed to use GCPRO1 etc.
1517 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1518 Revert to old implementation (i.e., before 2011-03-11).
1520 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1522 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1523 of scroll runs so as to avoid assigning disabled bogus rows and
1524 unnecessary graphics copy operations.
1526 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1528 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1529 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1530 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1531 (malloc, free, realloc, calloc): Redirect to e_* only when
1534 * lisp.h (GCTYPEBITS): Move before first use.
1535 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1536 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1537 this macro definition.
1539 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1542 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1544 * gtkutil.c (xg_create_frame_widgets):
1545 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1546 present with Gtk+ 2.0.
1548 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1550 * fileio.c (Finsert_file_contents): Undo previous change; see
1551 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1553 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1555 Rename locals to avoid shadowing.
1556 * fileio.c (Finsert_file_contents):
1557 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1558 * process.c (wait_reading_process_output):
1559 Rename inner 'proc' to 'p' to avoid shadowing.
1560 Indent for consistency with usual Emacs style.
1562 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1564 * xdisp.c (redisplay_window): If cursor row is not fully visible
1565 after recentering, and scroll-conservatively is set to a large
1566 number, scroll window by a few more lines to make the cursor fully
1567 visible and out of scroll-margin. (Bug#10105)
1568 (start_display): Don't move to the next line if the display should
1569 start at a newline that is part of a display vector or an overlay
1572 2011-11-24 Juri Linkov <juri@jurta.org>
1574 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1575 after the `MagickPingImage' call. (Bug#10112)
1577 2011-11-23 Chong Yidong <cyd@gnu.org>
1579 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1581 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1583 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1584 making another buffer current. (Bug#10114)
1586 2011-11-23 Glenn Morris <rgm@gnu.org>
1588 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1590 2011-11-23 Chong Yidong <cyd@gnu.org>
1592 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1593 using it (Bug#5984).
1595 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1597 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1598 and header-lines, as they don't have one computed for them.
1601 * .gdbinit (prow): Make displayed values more self-explaining.
1602 Add row's hash code.
1604 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1606 * process.c (wait_reading_process_output): Fix asynchrounous
1607 GnuTLS socket handling on some versions of the GnuTLS library.
1608 (wait_reading_process_output): Add comment and URL.
1610 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1612 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1614 2011-11-21 Chong Yidong <cyd@gnu.org>
1616 * window.c (Fnext_window, Fprevious_window): Doc fix.
1618 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1620 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1622 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1624 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1626 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1628 * window.c (Fset_window_combination_limit): Rename argument
1630 (Vwindow_combination_limit): Remove "status" from doc-string.
1632 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1634 * m/ibms390.h: Remove.
1635 * m/ibms390x.h: Don't include "ibms390.h".
1637 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1639 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1640 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1642 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1644 * casetab.c (Fset_case_table):
1645 * charset.c (Fcharset_after): Fix typos.
1647 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1649 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1650 Otherwise, valgrind does not work on some platforms.
1651 Problem reported by Andreas Schwab in
1652 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1653 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1654 is set, removing the need for VIRT_ADDRESS_VARIES.
1655 (PURE_P): Use a more-efficient implementation that needs just one
1656 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1657 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1658 to 4 (xorl, subq, cmpq, setbe).
1659 * alloc.c (pure): Always extern now, since that's the
1660 VIRT_ADDR_VARIES behavior.
1661 (PURE_POINTER_P): Use a single comparison, not two, for
1662 consistency with the new puresize.h.
1663 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1664 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1665 Remove VIRT_ADDR_VARIES no longer needed.
1667 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1669 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1670 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1671 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1672 behave as if the cursor position were at the window margin.
1674 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1675 and the cursor position is out of bounds, behave as if the cursor
1676 position were at the window margin. (Bug#10075)
1678 2011-11-18 Chong Yidong <cyd@gnu.org>
1680 * window.c (Fwindow_combination_limit): Make first argument
1681 non-optional, since it is meaningless for live windows like the
1684 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1686 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1688 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1690 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1691 (graft_intervals_into_buffer): Simplify.
1693 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1695 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1696 hash values of the two rows.
1697 (copy_row_except_pointers): Preserve the used[] arrays and the
1698 hash values of the two rows. (Bug#10035)
1699 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1701 * xdisp.c (row_hash): New function, body extracted from
1702 compute_line_metrics.
1703 (compute_line_metrics): Call row_hash, instead of computing the
1706 * dispnew.c (verify_row_hash): Call row_hash for computing the
1707 hash code of a row, instead of duplicating code from xdisp.c.
1709 * dispextern.h (row_hash): Add prototype.
1711 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1713 * frame.c (delete_frame): Don't delete the terminal when the last
1714 X frame is closed if emacs is built with GTK toolkit.
1716 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1718 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1720 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1722 * window.c (Vwindow_splits): Rename to
1723 Vwindow_combination_resize. Suggested by Juri Linkov.
1724 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1727 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1729 * nsfns.m (Fns_font_name):
1730 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1732 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1734 * window.h (window): Rename slot "nest" to "combination_limit".
1735 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1736 (Fset_window_nest): Rename to Fset_window_combination_limit.
1737 (Vwindow_nest): Rename to Vwindow_combination_limit.
1738 (recombine_windows, make_parent_window, make_window)
1739 (Fsplit_window_internal, saved_window)
1740 (Fset_window_configuration, save_window_save): Rename all
1741 occurrences of window_nest to window_combination_limit.
1743 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1745 * image.c (imagemagick_load_image): Fix typo.
1747 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1749 * xdisp.c (display_line): Move the call to
1750 highlight_trailing_whitespace before the call to
1751 compute_line_metrics, since the latter needs to see the final
1752 faces of all the glyphs to compute ROW's hash value.
1753 Fixes assertion violations in row_equal_p. (Bug#10035)
1755 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1757 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1758 just return (bug#10044).
1760 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1762 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1763 with user-defined heap size. Bump the default size of the temacs
1764 heap to 27MB, to avoid memory warning when running temacs.
1765 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1767 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1768 current_matrix and desired_matrix. (Bug#9990)
1769 (verify_row_hash) [XASSERTS]: New function.
1770 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1771 that the hash value of glyph rows is correct.
1773 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1775 * window.h (window): Remove splits slot.
1776 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1777 (Fdelete_other_windows_internal, make_parent_window)
1778 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1779 (Fset_window_configuration, save_window_save): Don't deal with
1780 split status of windows.
1781 (saved_window): Remove splits slot.
1782 (Vwindow_splits): Rewrite doc-string.
1784 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1786 * xfns.c (unwind_create_frame):
1787 * nsfns.m (unwind_create_frame):
1788 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1789 Vframe_list (Bug#9999).
1791 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1793 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1795 2011-11-11 Kenichi Handa <handa@m17n.org>
1797 * callproc.c (Fcall_process): Set the member dst_multibyte of
1800 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1802 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1803 avoid a crash (bug#9496).
1805 2011-11-09 Chong Yidong <cyd@gnu.org>
1807 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1808 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1810 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1812 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1814 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1816 Avoid some portability problems by eschewing 'extern inline' functions.
1817 The trivial performance wins aren't worth the portability hassles; see
1818 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1820 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1821 (window_box_width, window_box_left, window_box_left_offset)
1822 (window_box_right, window_box_right_offset): Undo previous change,
1823 by removing the "extern"s.
1824 * intervals.c (adjust_intervals_for_insertion)
1825 (adjust_intervals_for_deletion): Undo previous change,
1826 making these static again.
1827 (offset_intervals, temp_set_point_both, temp_set_point)
1828 (copy_intervals_to_string): No longer inline.
1829 * xdisp.c (window_text_bottom_y, window_box_width)
1830 (window_box_height, window_box_left_offset)
1831 (window_box_right_offset, window_box_left, window_box_right)
1832 (window_box): No longer inline.
1834 2011-11-08 Chong Yidong <cyd@gnu.org>
1836 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1837 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1838 Signal an error if not a live window.
1839 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1840 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1842 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1844 * lisp.h (syms_of_abbrev): Remove declaration.
1845 Reported by CHENG Gao <chenggao@royau.me>.
1847 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1849 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1850 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1851 of temacs in GUI mode.
1853 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1855 * window.h: Declare delete_all_child_windows instead of
1856 delete_all_subwindows.
1857 * window.c (Fwindow_nest, Fset_window_nest)
1858 (Fset_window_new_total, Fset_window_new_normal)
1859 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1860 (delete_all_subwindows): Rename to delete_all_child_windows.
1861 (Fdelete_other_windows_internal, Fset_window_configuration):
1862 Call delete_all_child_windows instead of delete_all_subwindows.
1863 * frame.c (delete_frame): Call delete_all_child_windows instead
1864 of delete_all_subwindows.
1866 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1868 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1869 This is also needed for porting to any host where GC_MARK_STACK is
1870 not GC_MAKE_GCPROS_NOOPS.
1871 (which_symbols): Use it.
1873 2011-11-07 Kenichi Handa <handa@m17n.org>
1875 * coding.c (coding_set_destination): Check coding->src_pos only
1876 when coding->src_object is a buffer (bug#9910).
1878 * process.c (send_process): Set the member src_multibyte of coding
1879 to 0 (bug#9911) when sending a unibyte text.
1881 * callproc.c (Fcall_process): Set the member src_multibyte of
1882 process_coding to 0 (bug#9912).
1884 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1886 * xmenu.c (cleanup_widget_value_tree): New function.
1887 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1888 calling free_menubar_widget_value_tree directly (Bug#9830).
1890 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1892 Fix some portability problems with 'inline'.
1893 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1894 (window_box_width, window_box_left, window_box_left_offset)
1895 (window_box_right, window_box_right_offset): Declare extern.
1896 Otherwise, these inline functions do not conform to C99 and
1897 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1898 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1899 * intervals.c (adjust_intervals_for_insertion)
1900 (adjust_intervals_for_deletion): Now extern, because otherwise the
1901 extern inline functions 'offset_intervals' couldn't refer to it.
1902 (static_offset_intervals): Remove.
1903 (offset_intervals): Rewrite using the old contents of
1904 static_offset_intervals. The old version didn't conform to C99
1905 because an extern inline function contained a reference to an
1906 identifier with static linkage.
1908 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1910 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1913 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1915 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1916 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1917 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1918 return Qleft_to_right.
1920 2011-11-06 Chong Yidong <cyd@gnu.org>
1922 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1923 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1924 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1925 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1926 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1927 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1928 (Fwindow_vscroll): Doc fix.
1929 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1930 argument, since it makes no sense to pass a live window and for
1931 consistency with window-child.
1933 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1935 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1938 2011-11-05 Jason Rumney <jasonr@gnu.org>
1940 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1941 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1943 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1944 bitwise arithmetic preventing use of unicode-sip and non-truetype
1947 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1949 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1952 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1953 initialization code to keep similarity to xfns.c after changes
1956 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1958 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1959 (unwind_create_frame): New function (Bug#9943).
1960 (Fx_create_frame): Restructure code to be more similar to the one in
1961 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1962 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1963 Move terminal->reference_count++ just before making the frame official
1966 * nsterm.m (x_free_frame_resources): New function.
1967 (x_destroy_window): Move code to x_free_frame_resources.
1969 * xfns.c (unwind_create_frame): Fix comment.
1970 (Fx_create_frame, x_create_tip_frame):
1971 Move terminal->reference_count++ just before making the frame
1972 official. Move initialization of image_cache_refcount and
1973 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1975 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1977 Support MSVC build with newer versions of Visual Studio.
1978 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1979 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1982 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1983 which are not supported by MSVC.
1984 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1985 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1987 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1989 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1991 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1993 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1995 Support MSVC build with newer versions of Visual Studio.
1996 * w32.c: Don't include w32api.h for MSVC.
1997 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1999 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
2000 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
2001 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
2002 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
2004 (alloca) [_MSC_VER]: Define to _alloca.
2006 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
2008 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
2010 2011-11-04 Eli Zaretskii <eliz@gnu.org>
2012 * xdisp.c (note_mouse_highlight): If either of
2013 previous/next-single-property-change returns nil, treat that as
2014 the beginning or the end of the buffer. (Bug#9955)
2016 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
2018 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
2019 label is not null (Bug#9951).
2020 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
2023 2011-11-04 Eli Zaretskii <eliz@gnu.org>
2025 * window.c (Fwindow_body_size): Mention in the doc string that the
2026 return value is in frame's canonical units. (Bug#9949)
2028 2011-11-03 Eli Zaretskii <eliz@gnu.org>
2030 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
2032 * w32fns.c (unwind_create_frame): If needed, free the glyph
2033 matrices of the partially constructed frame. (Bug#9943)
2034 * xfns.c (unwind_create_frame): Likewise.
2036 2011-11-01 Eli Zaretskii <eliz@gnu.org>
2038 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
2039 Don't stop backward scan on the continuation glyph, even though
2040 its CHARPOS is positive.
2041 (mouse_face_from_buffer_pos, note_mouse_highlight):
2042 Rename cover_string to disp_string.
2044 2011-11-01 Martin Rudalics <rudalics@gmx.at>
2046 * window.c (temp_output_buffer_show): Don't use
2047 Vtemp_buffer_show_specifiers.
2048 (Vtemp_buffer_show_specifiers): Remove unused variable.
2050 2011-10-30 Eli Zaretskii <eliz@gnu.org>
2052 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
2053 past the beginning of the current glyph matrix.
2055 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
2057 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
2058 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
2059 HAVE_GTK3 (Bug#9869).
2061 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
2062 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
2064 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
2066 * xterm.c: Declare x_handle_net_wm_state to return int.
2067 (handle_one_xevent): Check if we are iconified but don't have
2068 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
2069 (get_current_wm_state): Return non-zero if not hidden,
2070 check for _NET_WM_STATE_HIDDEN (Bug#9893).
2071 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
2072 (x_handle_net_wm_state): Return what get_current_wm_state returns.
2073 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
2075 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
2077 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
2078 so that this new function doesn't get optimized away by a
2079 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
2081 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2083 * frame.h (MOUSE_HL_INFO): Remove excess parens.
2085 2011-10-29 Eli Zaretskii <eliz@gnu.org>
2087 Fix the `xbytecode' command.
2088 * .gdbinit (xprintbytestr): New command.
2089 (xwhichsymbols): Rename from `which'; all callers changed.
2090 (xbytecode): Print the byte-code string as well.
2092 2011-10-29 Kim Storm <storm@cua.dk>
2094 * alloc.c (which_symbols): New function.
2096 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2098 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
2101 2011-10-29 Glenn Morris <rgm@gnu.org>
2103 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
2104 Not clear what it was for, and it causes various bugs. (Bug#9839)
2106 2011-10-28 Eli Zaretskii <eliz@gnu.org>
2108 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
2109 possible random value that matches one of those tested as
2110 condition to clear the mouse face.
2112 2011-10-28 Chong Yidong <cyd@gnu.org>
2114 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
2116 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
2118 * window.c (make_window): Initialize phys_cursor_on_p.
2120 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
2122 * lisp.h (struct Lisp_Symbol): Update comments.
2124 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
2126 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
2128 2011-10-28 Eli Zaretskii <eliz@gnu.org>
2130 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
2131 <oslsachem@gmail.com> for helping to debug this.
2133 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
2134 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
2135 (g_b_init_get_glyph_outline_w): New static variables.
2136 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
2137 (GetGlyphOutlineW_Proc): New typedefs.
2138 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
2139 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
2141 (w32font_open_internal, compute_metrics):
2142 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
2143 instead of calling the "wide" APIs directly.
2145 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
2147 * w32.h (syms_of_w32font): Add prototype.
2149 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2151 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
2152 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
2153 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
2154 (Fmove_to_window_line): Doc fix.
2156 2011-10-27 Chong Yidong <cyd@gnu.org>
2158 * process.c (make_process): Set gnutls_state to NULL.
2160 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
2161 non-NULL, regardless of GNUTLS_INITSTAGE.
2162 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
2163 an error. Set process slots as soon as we allocate them.
2165 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
2167 2011-10-27 Chong Yidong <cyd@gnu.org>
2169 * gnutls.c (emacs_gnutls_deinit): New function.
2170 Deallocate credentials structures as well as calling gnutls_deinit.
2171 (Fgnutls_deinit, Fgnutls_boot): Use it.
2173 * process.c (make_process): Initialize GnuTLS credentials to NULL.
2174 (deactivate_process): Call emacs_gnutls_deinit.
2176 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2178 * image.c (x_create_x_image_and_pixmap):
2179 * w32.c (sys_rename, w32_delayed_load):
2180 * w32font.c (fill_in_logfont):
2181 * w32reg.c (x_get_string_resource): Silence compiler warnings.
2183 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
2185 * w32fns.c (w32_default_color_map): New function,
2186 extracted from Fw32_default_color_map.
2187 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
2189 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
2191 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
2193 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
2195 * keyboard.c (test_undefined): New function (bug#9751).
2196 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
2198 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
2200 * sysdep.c (init_sys_modes): Fix the check for the controlling
2201 terminal (Bug#6649).
2203 2011-10-20 Eli Zaretskii <eliz@gnu.org>
2205 * dispextern.h (struct bidi_it): New member next_en_type.
2207 * bidi.c (bidi_line_init): Initialize the next_en_type member.
2208 (bidi_resolve_explicit_1): When next_en_pos is valid for the
2209 current character, check also for next_en_type being WEAK_EN.
2210 (bidi_resolve_weak): Don't enter the expensive loop if the current
2211 position is before next_en_pos. Record the bidi type of the first
2212 non-ET, non-BN character we find, in addition to its position.
2213 (bidi_level_of_next_char): Invalidate next_en_type when
2214 next_en_pos is over-stepped.
2216 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2218 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
2219 * editfns.c: Rewrite current-time-zone so that it invokes
2220 the equivalent of (format-time-string "%Z") to get the time zone name.
2221 This fixes a bug when the time zone name contains characters that
2222 need converting from the system time locale to Emacs internal format.
2223 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
2224 that patch fixed format-time-string to do the conversion, but
2225 I forgot to fix current-time-zone.
2226 (format_time_string): New function, containing most of
2227 what Fformat_time_string used to contain.
2228 (Fformat_time_string): Rewrite in terms of format_time_string.
2229 This doesn't change this function's behavior.
2230 (current-time-zone): Rewrite to use format_time_string.
2231 This fixes the bug reported by Michael Schierl in
2232 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2233 Jason Rumney's 2007-06-07 change worked around this bug, but
2235 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2237 2011-10-19 Eli Zaretskii <eliz@gnu.org>
2239 * xdisp.c (start_display): If the character at POS is displayed
2240 via a display vector, reset IT->current.dpvec_index to zero.
2241 (try_window_reusing_current_matrix): If a line ends in a display
2242 vector or the next line starts in a display vector, continue
2243 redrawing the window even though the character position of
2244 start_row was reached.
2247 2011-10-18 Chong Yidong <cyd@gnu.org>
2249 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2250 with nobreak-char-display too.
2252 2011-10-18 Eli Zaretskii <eliz@gnu.org>
2254 Fix part 3 of bug#9771.
2255 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2256 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2257 non-neutral characters if the current character is a paragraph
2258 separator (a.k.a. Newline). This avoids running the same
2259 expensive loop twice, once when we consume the preceding newline
2260 and the other time when the line actually needs to be displayed.
2261 Avoid the loop when we see neutrals on the base embedding level
2262 following a character whose directionality is the same as the
2263 paragraph's. This avoids running the expensive loop when a line
2264 ends in a long sequence of neutrals, like control characters.
2265 Add assertion against STRONG_AL type. Slightly rearrange code
2266 that determines the type of a neutral given the first non-neutral
2268 (bidi_level_of_next_char): Set next_en_pos to zero when
2269 invalidating its info.
2271 2011-10-17 Eli Zaretskii <eliz@gnu.org>
2273 * xdisp.c (push_display_prop): Determine whether to record string
2274 or buffer position by IT->string, not by IT->method. Allow
2275 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
2276 (move_it_vertically_backward): Don't look for character position
2277 immediately after the newline when in a continuation line.
2280 2011-10-15 Martin Rudalics <rudalics@gmx.at>
2282 * window.c (coordinates_in_window): Rewrite and delabelize
2283 vertical border check. (Bug#5357) (Bug#9618)
2285 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2287 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2288 errors in XSetWindowBorder (bug#9310).
2290 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2292 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2293 avoid crash when xmalloc overrun checking is enabled.
2295 2011-10-13 Eli Zaretskii <eliz@gnu.org>
2297 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2298 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2299 cursor motion with <left> and <right> arrow keys.
2301 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2302 some callers set that themselves.
2304 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2306 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2307 display string and the previous row comes from the same string and
2308 is empty. (Bug#9739) (Bug#9738)
2310 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2312 * doc.c (get_doc_string): Encode file name (bug#9735).
2314 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2316 * bidi.c (bidi_level_of_next_char):
2317 * xdisp.c (get_visually_first_element): Remove old incorrect
2318 comments regarding the Unicode Line Separator character.
2320 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2322 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2324 * alloc.c (Fgc_status): Do not access beyond zombies array
2325 boundary if nzombies > MAX_ZOMBIES.
2326 * alloc.c (dump_zombies): Add missing format specifier.
2328 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2330 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2331 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2333 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2334 Some packages use them to denote characters with modifiers.
2336 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2338 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2339 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2340 matching a pp-number. Rename parameter var to var1.
2342 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2344 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2346 2011-10-08 Glenn Morris <rgm@gnu.org>
2348 * callint.c (Fcall_interactively): Give a more explicit error for the
2349 'c' case with a non-character input. (Bug#8479)
2351 2011-10-08 Eli Zaretskii <eliz@gnu.org>
2353 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2355 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2356 lines that are hscrolled on the left.
2358 * dispnew.c (buffer_posn_from_coords): Account for a possible
2359 presence of header-line. (Bug#4426)
2361 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2363 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2364 Don't advertise functionality which we discourage or doesn't work.
2366 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2368 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2369 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2370 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2371 this makes Emacs dump core during garbage collection on rare
2372 occasions. sizeof is obviously inferior to offsetof here, so
2373 stick with offsetof.
2374 (GC_POINTER_ALIGNMENT): New macro.
2375 (mark_memory): Omit 3rd (offset) arg; caller changed.
2376 Don't assume EMACS_INT alignment is the same as pointer alignment.
2378 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2380 * keyboard.c (read_key_sequence_remapped): New var.
2381 (read_key_sequence): Compute remapping in the right buffer.
2382 (command_loop_1): Use read_key_sequence's remapping directly.
2384 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2386 * dired.c (file_name_completion): Don't expand file name.
2387 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2388 before checking file name handler.
2390 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2391 they've been requested explicitly (bug#9591).
2393 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
2395 * keymap.c (Fsingle_key_description): Use make_specified_string
2396 instead of build_string to build string from push_key_description.
2399 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2401 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2402 This fixes a Y2038 bug on 64-bit hosts.
2403 * buffer.c (reset_buffer):
2404 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2405 (Fclear_buffer_auto_save_failure):
2406 Use 0, not -1, to represent an unset failure time, since time_t
2407 might not be signed.
2409 Remove dependency on glibc malloc internals.
2410 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2411 Move back here from lisp.h, but with their new implementations.
2412 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2413 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2414 * charset.c (charset_table_init): New static var.
2415 (syms_of_charset): Use it instead of xmalloc. This removes a
2416 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2417 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2418 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2419 Move back to alloc.c.
2420 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2421 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2423 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2425 * nsterm.m (windowDidResize): Call x_set_window_size only when
2426 ns_in_resize is true. Otherwise set pixelwidth/height and
2427 call change_frame_size (Bug#9628).
2429 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2431 Port --enable-checking=all to Fedora 14 x86-64.
2432 * charset.c (syms_of_charset): Also account for glibc malloc's
2433 internal overhead when calculating the initial malloc maximum.
2435 Port --enable-checking=all to Fedora 14 x86.
2436 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2438 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2439 (overrun_check_realloc, overrun_check_free):
2440 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2441 That way, xmalloc returns a properly-aligned pointer even if
2442 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2443 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2444 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2445 into account when calculating the initial malloc maximum.
2446 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2447 Move here from alloc.c, so that charset.c can use it too.
2448 Properly align; the old code wasn't right for common 32-bit hosts
2449 when configured with --enable-checking=all.
2450 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2451 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2453 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2455 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2458 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2460 * xdisp.c (compute_display_string_end): If there's no display
2461 string at CHARPOS, return -1.
2463 * bidi.c (bidi_fetch_char): When compute_display_string_end
2464 returns a negative value, treat the character as a normal
2465 character not covered by a display string. (Bug#9624)
2467 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2469 * lread.c (Fread_from_string): Fix typo in docstring.
2471 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2473 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2474 newline, reseat the iterator instead of bidi-iterating there one
2475 character at a time. (Bug#9610)
2476 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2477 TO_CHARPOS if the bidi iterator is at base embedding level.
2479 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2481 * lread.c (readevalloop): Use correct code for NBSP.
2482 (read1): Likewise. (Bug#9608)
2484 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2486 * dbusbind.c (Fdbus_register_signal): When service is not
2487 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2489 2011-09-25 Glenn Morris <rgm@gnu.org>
2491 * buffer.c (truncate-lines): Doc fix.
2493 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2495 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2496 (Fset_window_next_buffers): Doc fix.
2498 2011-09-24 Glenn Morris <rgm@gnu.org>
2500 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2502 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2504 Fix minor problems found by static checking.
2505 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2506 * indent.c (Fvertical_motion): Fix == vs = typo.
2508 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2510 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2511 Default value is now t. Doc fix.
2513 * indent.c (Fvertical_motion): Compute and apply the overshoot
2514 logic when moving up, not only when moving down. Fix the
2515 confusing name and values of the it_overshoot_expected variable;
2516 logic changes accordingly. (Bug#9254) (Bug#9549)
2518 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2519 CHARPOS is covered by a display string which includes newlines.
2520 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2521 is covered by a display string with embedded newlines.
2523 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2525 * dbusbind.c (Fdbus_register_signal): Add match rule to
2526 Vdbus_registered_objects_table. (Bug#9581)
2527 (Fdbus_register_method, Vdbus_registered_objects_table):
2530 2011-09-24 Jim Meyering <meyering@redhat.com>
2532 do not ignore write error for any output size
2533 The previous change was incomplete.
2534 While it makes emacs --batch detect the vast majority of stdout
2535 write failures, errors were still ignored whenever the output size is
2536 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2537 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2538 && echo FAIL: ignored write error
2539 FAIL: ignored write error
2540 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2541 && echo FAIL: ignored write error
2542 FAIL: ignored write error
2543 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2545 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2547 * emacs.c (Fkill_emacs): In noninteractive mode exit
2548 non-successfully if a write error occurred on stdout. (Bug#9574)
2550 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2552 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2555 * dispextern.h (struct it): Update the comment documenting what
2558 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2560 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2561 a display string, extend search for cursor position to end of row.
2562 (find_row_edges): If the row ends in a newline from a display
2563 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2564 Handle the case of a display string with multiple newlines.
2565 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2566 non-empty line. Fixes confusing cursor motion with arrow keys at
2567 the beginning of a line that starts with whitespace.
2569 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2571 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2574 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2576 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2579 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2581 * xdisp.c (display_line): Record maximum and minimum buffer
2582 positions even if no glyphs were produced (e.g., by a zero-width
2583 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2584 buffer positions that will be removed from the glyph row because
2586 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2587 column is beyond frame width: don't subtract 1 "pixel" when
2588 computing width of the stretch.
2589 (reseat_at_next_visible_line_start): Undo the change made on
2590 2011-09-17 that saved paragraph information and restored it after
2591 the call to `reseat'. (Bug#9545)
2593 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2595 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2596 and turn window cursor on if cleared (Bug#9415).
2598 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2600 * search.c (boyer_moore): Take unibyte characters from pattern
2601 literally. (Bug#9458)
2603 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2605 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2607 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2609 Fix minor problem found by static checking.
2610 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2611 initialized, to pacify gcc -Wuninitialized.
2613 * fileio.c: Report proper errno when syscall falls.
2614 (Finsert_file_contents): Save and restore errno,
2615 so that report_file_error outputs the correct diagnostic.
2616 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2618 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2620 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2622 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2624 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2625 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2627 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2629 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2630 about the current paragraph and restore it after the call to reseat.
2632 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2633 (bidi_find_paragraph_start): Search back for paragraph beginning
2634 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2635 (bidi_move_to_visually_next): Only trigger paragraph-related
2636 computations when the last character is a newline or at EOB, not
2637 just any NEUTRAL_B. (Bug#9470)
2639 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2640 truncated lines if point is covered by a display string. (Bug#9524)
2642 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2644 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2645 (cons_to_x_long): New function.
2646 (lisp_data_to_selection_data): Use it. Correct the test for
2647 short-versus-long data; it was negated. Break out of vector
2648 loop, for efficiency, when a long datum is discovered.
2650 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2652 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2654 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2656 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2657 GCC PR/17406) by declaring this function with external scope.
2659 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2661 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2662 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2664 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2666 * editfns.c (Fformat): Correctly handle text properties on "%%".
2668 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2670 * xterm.c (x_draw_composite_glyph_string_foreground):
2671 * w32term.c (x_draw_composite_glyph_string_foreground):
2672 * term.c (encode_terminal_code):
2673 * composite.c (composition_update_it, get_composition_id):
2674 * xdisp.c (get_next_display_element)
2675 (fill_composite_glyph_string): Add comments about special meaning
2676 of TAB characters in a composition.
2678 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2680 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2681 This occurs when processing a multibyte format.
2682 Problem reported by Wolfgang Jenker.
2684 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2686 * xdisp.c (try_cursor_movement): Only check for exact match if
2687 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2689 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2691 Remove unused external symbols.
2692 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2693 * xdisp.c (calc_pixel_width_or_height): Now static.
2694 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2695 * indent.c (check_display_width):
2696 * w32term.c: Fix comment to match code.
2697 * xterm.c, xterm.h (x_catching_errors): Remove.
2699 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2701 * xselect.c: Use signed conversions more consistently (Bug#9498).
2702 (selection_data_to_lisp_data): Assume incoming selection data are
2703 signed integers, not unsigned. This is to be consistent with
2704 outgoing selection data, which was modified to use signed integers
2705 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2706 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2707 expects long, not unsigned long.
2709 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2711 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2712 computation of loop end. Reported by Johan Bockgård
2715 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2717 * frame.c (Fother_visible_frames_p): Function deleted.
2719 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2721 * indent.c (compute_motion): Process display vector front to back
2722 rather than the other way around. (Bug#2496)
2724 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2726 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2728 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2730 * minibuf.c (Fread_from_minibuffer): Doc fix.
2732 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2734 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2735 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2737 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2739 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2740 value for non-existent files.
2742 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2744 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2745 set its "size" to -1. This will set the modtime_size field of
2746 the corresponding buffer to -1, which is what
2747 verify-visited-file-modtime expects for files that do not exist.
2750 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2752 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2754 * lisp.h: ... from here. push_key_description is no longer
2755 defined in keyboard.c, so its declaration should not be in
2756 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2757 logically belongs with push_key_description.
2759 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2761 * buffer.h: Include <sys/types.h> instead of <time.h>.
2762 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2763 Problem reported by Herbert J. Skuhra.
2765 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2767 * xml.c (parse_region): Make the parsing work for
2768 non-comment-starting XML files again (bug#9144).
2770 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2772 * image.c (gif_load): Fix calculation of bottom and right corner.
2775 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2777 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2778 redisplay in small windows.
2780 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2782 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2784 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2786 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2787 Operate on live windows only.
2789 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2791 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2793 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2795 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2796 only under bidi iteration.
2798 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2800 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2802 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2804 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2805 Without this fix, the command to link temacs failed due to an
2806 undefined symbol __builtin_isnan. This is because
2807 /usr/include/iso/math_c99.h #defines isnan(x) to
2808 __builtin_isnan(x), but the bundled gcc, which identifies itself
2809 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2811 * floatfns.c (isnan): #undef, and then #define to a clone of
2813 (Fisnan): Always define, since it's always available now.
2814 (syms_of_floatfns): Always define isnan at the Lisp level.
2816 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2818 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2820 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2822 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2823 The previous code assumed that file offsets (off_t values) fit in
2824 EMACS_INT variables, which is not true on typical 32-bit hosts.
2825 The code messed up by falsely reporting buffer overflow in cases
2826 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2827 when "big" contains more than 2**29 bytes, even though this
2828 inserts just one byte and does not overflow the buffer.
2829 (Finsert_file_contents): Store file offsets as off_t
2830 values, not as EMACS_INT values. Check for overflow when
2831 converting between EMACS_INT and off_t. When checking for
2832 buffer overflow or for overlap, take the offsets into account.
2833 Don't use EMACS_INT for small values where int suffices.
2834 When checking for overlap, fix a typo: ZV was used where
2835 ZV_BYTE was intended.
2836 (Fwrite_region): Don't assume off_t fits into 'long'.
2837 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2839 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2841 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2843 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2845 sprintf-related integer and memory overflow issues (Bug#9412).
2847 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2848 (esprintf, exprintf, evxprintf): New functions.
2849 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2850 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2851 (modify_event_symbol): Do not assume that the length of
2852 name_alist_or_stem is safe to alloca and fits in int.
2853 (Fexecute_extended_command): Likewise for function name and binding.
2854 (Frecursion_depth): Wrap around reliably on integer overflow.
2855 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2856 since some callers pass EMACS_INT values.
2857 (Fsingle_key_description): Don't crash if symbol name contains more
2858 than MAX_ALLOCA bytes.
2859 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2860 (get_minibuffer): Arg is now EMACS_INT, not int.
2861 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2862 (esprintf, exprintf, evxprintf): New decls.
2863 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2865 * dbusbind.c (signature_cat): New function.
2866 (xd_signature, Fdbus_register_signal):
2867 Do not overrun buffer; instead, report string overflow.
2869 * dispnew.c (add_window_display_history): Don't overrun buffer.
2870 Truncate instead; this is OK since it's just a log.
2872 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2873 even if the time zone offset is outlandishly large.
2874 Don't mishandle offset == INT_MIN.
2876 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2877 when creating daemon; the previous buffer-overflow check was incorrect.
2879 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2880 which has the guts of the old verror function.
2882 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2883 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2885 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2886 (font_unparse_xlfd): Don't blindly alloca long strings.
2887 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2888 fits in int, when using sprintf. Use single snprintf to count
2889 length of string rather than counting it via multiple sprintfs;
2890 that's simpler and more reliable.
2891 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2892 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2893 sprintf, in case result does not fit in int.
2895 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2896 (fontset_from_font): Print it.
2898 * frame.c (tty_frame_count): Now printmax_t, not int.
2899 (make_terminal_frame, set_term_frame_name): Print it.
2900 (x_report_frame_params): In X, window IDs are unsigned long,
2901 not signed long, so print them as unsigned.
2902 (validate_x_resource_name): Check for implausibly long names,
2903 and don't assume name length fits in 'int'.
2904 (x_get_resource_string): Don't blindly alloca invocation name;
2905 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2908 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2909 (xg_check_special_colors, xg_set_geometry):
2910 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2912 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2913 Use esprintf, not sprintf, in case result does not fit in int.
2915 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2916 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2917 it as a large positive number.
2918 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2919 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2921 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2922 in case result does not fit in int.
2924 * print.c (float_to_string): Detect width overflow more reliably.
2925 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2926 buffer overrun. Don't assume list length fits in 'int'. Treat
2927 print length of 0 as 0, not as infinity; to be consistent with other
2928 uses of print length in this function. Don't overflow print length
2929 index. Don't assume hash table size fits in 'long', or that
2930 vectorlike size fits in 'unsigned long'.
2932 * process.c (make_process): Use printmax_t, not int, to format
2933 process-name gensyms.
2935 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2937 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2938 to avoid potential buffer overrun.
2940 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2941 if X resource line is longer than 512 bytes.
2943 * xfns.c (x_window): Make sprintf buffer a bit bigger
2944 to avoid potential buffer overrun.
2946 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2948 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2950 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2952 Integer overflow fixes for scrolling, etc.
2953 Without these, Emacs silently mishandles large integers sometimes.
2954 For example, "C-u 4294967297 M-x recenter" was treated as if
2955 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2957 * xdisp.c (try_window_id): Check Emacs fixnum range before
2958 converting to 'int'.
2960 * window.c (window_scroll_line_based, Frecenter):
2961 Check that an Emacs fixnum is in range before assigning it to 'int'.
2962 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2963 values converted from Emacs fixnums.
2964 (Frecenter): Don't wrap around a line count if it is out of 'int'
2965 range; instead, treat it as an extreme value.
2966 (Fset_window_configuration, compare_window_configurations):
2967 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2969 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2970 that can exceed INT_MAX. Check that EMACS_INT value is in range
2971 before assigning it to the (possibly-narrower) index.
2972 (match_limit): Don't assume that a fixnum can fit in 'int'.
2974 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2977 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2978 (Fvertical_motion): Don't wrap around LINES values that don't fit
2979 in 'int'. Instead, treat them as extreme values. This is good
2980 enough for windows, which can't have more than INT_MAX lines anyway.
2982 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2984 * Require libxml/parser.h to avoid compilation warning.
2986 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2988 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2989 since this reportedly can destroy thread storage.
2991 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2993 * syntax.c (find_defun_start): Update all cache variables if
2994 exiting early (Bug#9401).
2996 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2998 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
3000 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
3001 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
3002 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
3004 * term.c (tty_append_glyph): New function.
3005 (produce_stretch_glyph): Static function and its prototype deleted.
3007 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
3010 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
3012 * image.c (parse_image_spec): Check for nonnegative, not for positive,
3013 when checking :margin (Bug#9390).
3014 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
3015 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
3016 so that the name doesn't mislead. All uses changed.
3018 2011-08-28 Johan Bockgård <bojohan@gnu.org>
3020 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
3023 2011-08-27 Eli Zaretskii <eliz@gnu.org>
3025 * xdisp.c (move_it_to): Don't bail out early when reaching
3026 position beyond to_charpos, if we are scanning backwards.
3027 (move_it_vertically_backward): When DY == 0, make sure we get to
3028 the first character in the line after the newline.
3030 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
3032 * ccl.c: Improve and simplify overflow checking (Bug#9196).
3033 (ccl_driver): Do not generate an out-of-range pointer.
3034 (Fccl_execute_on_string): Remove unnecessary check for
3035 integer overflow, noted by Stefan Monnier in
3036 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
3037 Remove a FIXME that didn't need fixing.
3038 Simplify the newly-introduced buffer reallocation code.
3040 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
3042 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
3044 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
3046 Integer and memory overflow issues (Bug#9196).
3048 * doc.c (get_doc_string): Rework so that
3049 get_doc_string_buffer_size is the actual buffer size, rather than
3050 being 1 less than the actual buffer size; this makes xpalloc more
3053 * image.c (x_allocate_bitmap_record, cache_image):
3054 * xselect.c (Fx_register_dnd_atom):
3055 Simplify previous changes by using xpalloc.
3057 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
3058 since either will do and ptrdiff_t is convenient with xpalloc.
3060 * charset.c (charset_table_size)
3061 (struct charset_sort_data.priority): Now ptrdiff_t.
3062 (charset_compare): Don't overflow if priorities differ greatly.
3063 (Fsort_charsets): Don't assume list length fits in int.
3064 Check for size-calculation overflow when allocating sort data.
3065 (syms_of_charset): Allocate an initial charset table that is
3066 just under 64 KiB, to avoid problems with glibc malloc and mmap.
3068 * cmds.c (internal_self_insert): Check for size-calculation overflow.
3070 * composite.h (struct composition.glyph_len): Now int, not unsigned.
3071 The actual value is always <= INT_MAX, and leaving it unsigned made
3072 overflow checking harder.
3074 * dispextern.h (struct glyph_matrix.rows_allocated)
3075 (struct face_cache.size): Now ptrdiff_t, for convenience in use
3076 with xpalloc. The values are still always <= INT_MAX.
3078 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
3080 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
3081 (SAFE_NALLOCA): New macro.
3083 * region-cache.c (struct boundary.pos, find_cache_boundary)
3084 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
3085 (set_cache_region, invalidate_region_cache)
3086 (revalidate_region_cache, know_region_cache, region_cache_forward)
3087 (region_cache_backward, pp_cache):
3088 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
3089 so that ptrdiff_t * can be passed to xpalloc.
3090 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
3091 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
3092 (pp_cache): Don't assume cache_len fits in int.
3093 * region-cache.h: Adjust extern decls to match.
3095 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
3096 EMACS_INT, since either will do, for xpalloc.
3098 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
3099 (xnmalloc, xnrealloc, xpalloc): New functions.
3101 * bidi.c (bidi_shelve_header_size): New constant.
3102 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
3103 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
3105 * bidi.c (bidi_cache_shrink):
3106 * buffer.c (overlays_at, overlays_in, record_overlay_string)
3108 Don't update size of array until after memory allocation succeeds,
3109 because xmalloc/xrealloc may not return.
3110 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
3111 now that we have proper integer overflow checking.
3112 (record_overlay_string, overlay_strings): Catch overflows when
3113 calculating size of overlay_str_buf.
3115 * callproc.c (Fcall_process): Check for size overflow when
3116 calculating size of args2.
3117 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
3118 Normally we prefer signed values, but sticking with ptrdiff_t would
3119 require adding more-complicated checks.
3121 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
3122 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
3123 Redo buffer-overflow calculations to avoid integer overflow.
3124 Add a FIXME comment where memory seems to be over-allocated.
3126 * character.c (Fstring): Check for size-calculation overflow.
3128 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
3129 unnecessary integer overflow. Check for size overflow.
3130 (encode_coding_object): Don't update size until xmalloc succeeds.
3132 * composite.c (get_composition_id): Check for overflow in glyph
3133 length calculations.
3135 Integer and memory overflow fixes for display code.
3136 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
3137 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
3138 (scrolling_window): Check for overflow in size calculations.
3139 (line_draw_cost, realloc_glyph_pool, add_row_entry):
3140 Don't assume glyph table len fits in int.
3141 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
3142 (row_table_size): Now ptrdiff_t, not int.
3143 (scrolling_window): Avoid overflow in size calculations.
3144 Don't update size until allocation succeeds.
3145 * fns.c (concat): Check for overflow in size calculations.
3146 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
3147 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3148 (NEXT_ALMOST_PRIME_LIMIT): New constant.
3150 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
3151 (get_doc_string): Check for size calculation overflow.
3152 Don't update size until allocation succeeds.
3153 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
3154 EMACS_INT, where ptrdiff_t will do.
3155 (Fsubstitute_command_keys): Check for string overflow.
3157 * editfns.c (set_time_zone_rule): Don't assume environment length
3159 (message_length): Now ptrdiff_t, not int.
3160 (Fmessage_box): Don't update size until allocation succeeds.
3161 Don't assume message length fits in int.
3162 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
3164 * emacs.c (main): Do not reallocate argv, since there is a null at
3165 the end that can be overwritten, and this way there's no need to
3166 worry about size-calculation overflow.
3167 (sort_args): Check for size-calculation overflow.
3169 * eval.c (init_eval_once, grow_specpdl): Don't update size until
3171 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
3173 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
3174 (x_set_scroll_bar_width, x_figure_window_size):
3175 Check for integer overflow.
3176 (x_set_alpha): Do not assume XINT fits in int.
3178 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
3179 This is for the members text_lines, text_cols, total_lines, total_cols,
3180 where the system imposes an 'int' limit.
3182 * fringe.c (Fdefine_fringe_bitmap):
3183 Don't update size until alloc works.
3185 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
3186 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
3188 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
3189 Check for size-calculation overflow.
3190 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
3191 do, as we prefer signed integers.
3192 (id_to_widget.max_size, id_to_widget.used)
3193 (xg_store_widget_in_map, xg_remove_widget_from_map)
3194 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
3195 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
3196 Use and return ptrdiff_t, not int.
3197 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
3198 * gtkutil.h: Change prototypes to match the above.
3200 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
3201 are duplicate now that they've been promoted to lisp.h.
3202 (x_allocate_bitmap_record, x_alloc_image_color)
3203 (make_image_cache, cache_image, xpm_load):
3204 Don't update size until alloc is done.
3205 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
3207 Check for size calculation overflow.
3208 (ct_colors_allocated_max): New constant.
3209 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
3212 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
3213 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
3214 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
3215 Use ptrdiff_t, not int, to count maps.
3216 (read_char_minibuf_menu_prompt): Check for overflow in size
3217 calculations. Don't update size until allocation succeeds.
3218 Redo calculations to avoid overflow.
3219 * keyboard.h: Change prototypes to match the above.
3221 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
3223 (current_minor_maps): Check for size calculation overflow.
3224 * keymap.h: Change prototypes to match the above.
3226 * lread.c (read1, init_obarray): Don't update size until alloc done.
3228 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
3229 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
3231 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3232 Now ptrdiff_t, not int.
3233 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3234 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3236 * process.c (Fnetwork_interface_list): Check for overflow
3237 in size calculation.
3239 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3241 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3242 overflow. Don't bother calling xmalloc when xrealloc will do.
3244 * search.c (Freplace_match): Check for size calculation overflow.
3245 (Fset_match_data): Don't assume list lengths fit in 'int'.
3247 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3248 for command line length. Do not attempt to address one before the
3249 beginning of an array, as that's not portable.
3251 * term.c (max_frame_lines): Remove; unused.
3252 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3254 (encode_terminal_code, calculate_costs): Check for size
3255 calculation overflow.
3256 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3257 table lengths and related sizes. Don't update size until alloc
3258 done. Redo calculations to avoid overflow.
3259 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3261 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3262 subtracting pointers.
3263 (gobble_line): Check for overflow more carefully. Don't update size
3266 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3267 Don't update size until alloc done.
3268 Redo size calculations to avoid overflow.
3269 Check for size calculation overflow.
3270 (main) [DEBUG]: Fix typo in invoking tparam1.
3272 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3273 Use ptrdiff_t, not int, for sizes.
3274 (store_mode_line_noprop_char): Don't update size until alloc done.
3276 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3277 Use ptrdiff_t, not int, for sizes.
3278 (Finternal_make_lisp_face, cache_face):
3279 Check for size calculation overflow.
3280 (cache_face): Treat size calculation overflows as if they were
3281 memory exhaustion (the usual treatment), rather than aborting.
3283 * xfns.c (x_encode_text, x_set_name_internal)
3284 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3285 sizes, since they can exceed INT_MAX in size. Check for size
3286 calculation overflow.
3288 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3289 (xg_select): Check for size calculation overflow.
3290 Don't update size until alloc done.
3292 * xrdb.c (get_environ_db): Don't assume path length fits in int,
3293 as sprintf is limited to int lengths.
3295 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3296 (X_LONG_MIN): New macros.
3297 Use them to make the following changes clearer.
3298 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3299 This change doesn't affect the value now, but it may help remind
3300 future maintainers not to raise the value too much later.
3301 (SELECTION_QUANTUM): Remove, replacing with ...
3302 (selection_quantum): ... new function, which avoids overflow.
3304 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3305 assumption that selection length fits in 'int'.
3306 (x_reply_selection_request, x_handle_selection_request)
3307 (x_get_window_property, receive_incremental_selection)
3308 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3309 (lisp_data_to_selection_data, clean_local_selection_data):
3310 Use ptrdiff_t, not int, to record length of selection.
3311 (x_reply_selection_request, x_get_window_property)
3312 (receive_incremental_selection, x_property_data_to_lisp):
3313 Redo calculations to avoid overflow.
3314 (x_reply_selection_request): When sending hint, ceiling it at
3315 X_LONG_MAX rather than relying on wraparound overflow to send
3317 (x_get_window_property, receive_incremental_selection)
3318 (lisp_data_to_selection_data, x_property_data_to_lisp):
3319 Check for size-calculation overflow.
3320 (x_get_window_property, receive_incremental_selection)
3321 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3322 Don't store size until memory allocation succeeds.
3323 (x_get_window_property): Plug memory leak on memory exhaustion.
3324 Don't double-block input; malloc is safe here. Don't assume 2**34
3325 - 4 fits in unsigned long. Add an xassert to check
3326 XGetWindowProperty overflow. Be more careful about overflow
3327 calculations, and distinguish size from memory overflow better.
3328 (receive_incremental_selection): When tracing, don't assume
3329 unsigned int is less than INT_MAX.
3330 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3331 harmful) conversions of unsigned short to int.
3332 (lisp_data_to_selection_data): Don't assume that integers
3333 in the range -65535 through -1 fit in an X unsigned short.
3334 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3335 result parameters unless successful. Rely on cons_to_unsigned
3336 to report problems with elements; the old code wasn't right anyway.
3337 (x_check_property_data): Check for int overflow; we cannot use
3338 a wider type due to X limits.
3339 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3341 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
3343 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3344 (x_term_init): Check for size calculation overflow.
3345 (x_color_cells): Don't store size until memory allocation succeeds.
3346 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
3347 Don't assume alloca size is less than MAX_ALLOCA.
3348 (x_term_init): Don't assume length fits in int (sprintf is limited
3351 Use ptrdiff_t for composition IDs.
3352 * character.c (lisp_string_width):
3353 * composite.c (composition_table_size, n_compositions)
3354 (get_composition_id, composition_gstring_from_id):
3355 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3356 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3357 * window.c (Frecenter):
3358 Use ptrdiff_t, not int, for composition IDs.
3359 * composite.c (get_composition_id): Check for integer overflow.
3360 * composite.h: Adjust prototypes to match the above changes.
3362 Use ptrdiff_t for hash table indexes.
3363 * category.c (hash_get_category_set):
3364 * ccl.c (ccl_driver):
3365 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3366 * coding.c (coding_system_charset_list, detect_coding_system):
3367 * coding.h (struct coding_system.id):
3368 * composite.c (get_composition_id, gstring_lookup_cache):
3369 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3370 * image.c (xpm_get_color_table_h):
3371 * lisp.h (hash_lookup, hash_put):
3372 * minibuf.c (Ftest_completion):
3373 Use ptrdiff_t for hash table indexes, not int (which is too
3374 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3375 32-bit --with-wide-int hosts).
3377 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3378 Add a FIXME comment about memory leaks.
3379 (syms_of_charset): Don't assume xmalloc returns.
3381 Don't assume that stated character widths fit in int.
3382 * character.c (Fchar_width, c_string_width, lisp_string_width):
3383 * character.h (CHAR_WIDTH):
3384 * indent.c (MULTIBYTE_BYTES_WIDTH):
3385 Use sanitize_char_width to avoid undefined and/or bad behavior
3386 with outlandish widths.
3387 * character.h (sanitize_tab_width): Rename from sanitize_width,
3388 now that we have two such functions. All uses changed.
3389 (sanitize_char_width): New inline function.
3391 Don't assume that tab-width fits in int.
3392 * character.h (sanitize_width): New inline function.
3393 (SANE_TAB_WIDTH): New macro.
3394 (ASCII_CHAR_WIDTH): Use it.
3395 * indent.c (sane_tab_width): Remove. All uses replaced by
3396 SANE_TAB_WIDTH (current_buffer).
3397 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3399 * fileio.c: Integer overflow issues with file modes.
3400 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3402 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3403 Remove unreachable code.
3404 (read_hex, load_charset_map_from_file): Check for integer overflow.
3406 * xterm.c: Don't go over XClientMessageEvent limit.
3407 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3408 (x_send_scroll_bar_event): Likewise. Check that the size does not
3409 exceed limits imposed by XClientMessageEvent, as well as the usual
3410 ptrdiff_t and size_t limits.
3412 * keyboard.c: Overflow, signedness and related fixes.
3413 (make_lispy_movement): Use same integer type in forward decl
3414 that is used in the definition.
3415 (read_key_sequence, keyremap_step):
3416 Change bufsize argument back to int, undoing my 2011-03-30 change.
3417 We prefer signed types, and int is wide enough here.
3418 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3419 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3420 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3421 length, not size_t. Use ptrdiff_t for index, not int.
3422 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3423 possibility of integer overflow.
3425 Overflow, signedness and related fixes for images.
3427 * dispextern.h (struct it.stack[0].u.image.image_id)
3428 (struct_it.image_id, struct image.id, struct image_cache.size)
3429 (struct image_cache.used, struct image_cache.ref_count):
3430 * gtkutil.c (update_frame_tool_bar):
3431 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3432 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3433 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3434 * nsmenu.m (update_frame_tool_bar):
3435 * xdisp.c (calc_pixel_width_or_height):
3436 * xfns.c (image_cache_refcount):
3437 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3438 on typical 64-bit hosts.
3440 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3441 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3442 Omit unnecessary casts to int.
3443 (parse_image_spec): Check that integers fall into 'int' range
3444 when the callers expect that.
3445 (image_ascent): Redo ascent calculation to avoid int overflow.
3446 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3447 (lookup_image): Remove unnecessary tests.
3448 (xbm_image_p): Locals are now of int, not EMACS_INT,
3449 since parse_image_check makes sure they fit into int.
3450 (png_load, gif_load, svg_load_image):
3451 Prefer int to unsigned where either will do.
3452 (tiff_handler): New function, combining the cores of the
3453 old tiff_error_handler and tiff_warning_handler.
3454 This function is rewritten to use vsnprintf and thereby avoid
3455 stack buffer overflows. It uses only the features of vsnprintf
3456 that are common to both POSIX and native Microsoft.
3457 (tiff_error_handler, tiff_warning_handler): Use it.
3458 (tiff_load, gif_load, imagemagick_load_image):
3459 Don't assume :index value fits in 'int'.
3460 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3461 (imagemagick_load_image): Check that crop parameters fit into
3462 the integer types that MagickCropImage accepts. Don't assume
3463 Vimagemagick_render_type has a nonnegative value. Don't assume
3464 size_t fits in 'long'.
3465 (gs_load): Use printmax_t to print the widest integers possible.
3466 Check for integer overflow when computing image height and width.
3468 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3470 * xdisp.c (redisplay_window): Don't force window start if point
3471 will be invisible in the resulting window. (Bug#9324)
3473 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3475 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3476 the display spec is of the form `(space ...)'.
3477 (handle_display_spec): Return the value returned by
3478 handle_single_display_spec, not just 1 or zero.
3479 (handle_single_display_spec): If the display spec is of the form
3480 `(space ...)', and specifies display in the text area, return 2
3482 (try_cursor_movement): Check for the need to scroll more
3483 accurately, and prefer exact match for point under bidi.
3484 Don't advance `row' beyond the last row of the window.
3486 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3487 into disp_prop; all users changed.
3489 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3490 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3491 for the text covered by the display property.
3493 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3495 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3496 Change return value to nil.
3497 (Frecord_buffer): Delete unused function.
3499 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3501 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3502 buffers, return left-to-right.
3503 (set_cursor_from_row): Consider candidate row a win if its glyph
3504 represents a newline and point is on that newline. Fixes cursor
3505 positioning on the newline at EOL of R2L text within L2R
3506 paragraph, and vice versa.
3507 (try_cursor_movement): Check continued rows, in addition to
3508 continuation rows. Fixes unwarranted scroll when point enters a
3509 continued line of R2L text within an L2R paragraph, or vice versa.
3510 (cursor_row_p): Consider the case of point being equal to
3511 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3512 from the end of a short line to the beginning of a continued line
3513 of R2L text within L2R paragraph.
3514 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3515 composed characters.
3517 * bidi.c (bidi_check_type): Use xassert.
3518 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3521 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3523 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3526 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3528 * nsfont.m (ns_otf_to_script): Fix typo.
3530 2011-08-22 Kenichi Handa <handa@m17n.org>
3532 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3533 extra slot even if the purpose is char-code-property-table.
3535 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3537 * xdisp.c (redisplay_window): When computing centering_position,
3538 account for the height of the header line. (Bug#8874)
3540 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3541 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3542 candidate is selected by the mouse, and that candidate has a
3543 composed character under the mouse.
3545 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3546 coordinates reported by pos-visible-in-window-p for a composed
3547 character in column zero.
3549 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3551 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3553 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3555 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3556 consider it a hit if to_charpos is anywhere in the range of the
3557 composed buffer positions.
3559 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3561 * image.c (gif_load): Don't assume that each subimage has the same
3562 dimensions as the base image. Handle disposal method that is
3563 "undefined" by the gif spec (Bug#9335).
3565 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3567 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3568 (Fcondition_case): Document `debug' symbol in error handler.
3570 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3572 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3573 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3574 from an Org mode buffer to a Speedbar frame.
3576 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3577 a composition, take its buffer position from IT->cmp_it.charpos.
3578 Fixes cursor positioning at the beginning of a line that begins
3579 with a composed character.
3581 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3583 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3584 character bidirectional type, use STRONG_L instead. Fixes crashes
3585 in a buffer produced by `describe-categories'.
3587 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3588 members before the level stack, so they would be saved and
3589 restored when copying iterator state. Fixes incorrect reordering
3590 around TABs covered by display properties.
3592 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3594 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3596 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3598 * eval.c (internal_condition_case, internal_condition_case_1)
3599 (internal_condition_case_2, internal_condition_case_n):
3600 Remove unnecessary aborts (Bug#9081).
3602 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3604 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3605 has no `load' handler, try opening the file locally. (Bug#9311)
3607 2011-08-16 Ken Brown <kbrown@cornell.edu>
3609 * gmalloc.c: Expand comment.
3611 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3613 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3614 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3616 2011-08-16 Ken Brown <kbrown@cornell.edu>
3618 Fix memory allocation problems in Cygwin build (Bug#9273).
3620 * unexcw.c ( __malloc_initialized): Declare external variable.
3621 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3623 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3625 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3627 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3629 [CYGWIN] (special_realloc): New function.
3630 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3631 requests to realloc storage in the static heap.
3633 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3635 * bidi.c (bidi_initialize): Remove unused local.
3637 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3640 * biditype.h: Remove file.
3641 * makefile.w32-in ($(BLD)/bidi.$(O)):
3642 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3644 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3646 * chartab.c: Improve commentary for the uniprop_table API.
3648 * bidi.c (bidi_paragraph_init): Support zero value of
3649 bidi_ignore_explicit_marks_for_paragraph_level.
3650 (bidi_initialize): Use uniprop_table instead of including
3651 biditype.h and bidimirror.h.
3653 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3654 coordinates of the iterator when restoring from ppos_it.
3657 2011-08-14 Kenichi Handa <handa@m17n.org>
3659 * process.c (create_process): Call setup_process_coding_systems
3660 after the pid of the process is set to -1 (Bug#8162).
3662 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3664 * xdisp.c (move_it_in_display_line_to): Don't invoke
3665 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3666 ppos_it. Fixes vertical cursor motion when line beginning is
3667 covered by an image. (Bug#9296)
3669 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3671 * nsterm.h (ns_run_ascript): Declare.
3672 (NSAPP_DATA2_RUNASSCRIPT): Define.
3674 * nsfns.m (as_script, as_result, as_status): New static variables.
3675 (ns_run_ascript): New function.
3676 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3677 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3678 the event loop. Get status from as_status (Bug#7276).
3680 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3681 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3682 the event loop (Bug#7276).
3684 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3686 * gnutls.c (QCgnutls_bootprop_priority)
3687 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3688 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3689 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3690 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3691 (QCgnutls_bootprop_verify_hostname_error)
3692 (QCgnutls_bootprop_callbacks_verify): Rename from
3693 Qgnutls_bootprop_..., all uses changed.
3695 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3698 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3700 * xfaces.c (Qframe_set_background_mode): Now static.
3701 * dispextern.h (Qframe_set_background_mode): Remove decl.
3703 * process.c (Fnetwork_interface_info): Declare local only if needed.
3705 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3707 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3708 (Fnetwork_interface_list): Allocate in increments of bytes instead
3709 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3710 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3712 (struct ifflag_def): notrailers is smart on OSX.
3713 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3714 Get hardware address with getifaddrs if available.
3716 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3718 * xdisp.c (iterate_out_of_display_property): xassert that
3719 IT->position is set to within IT->object's boundaries. Break from
3720 the loop as soon as EOB is reached; avoids infloops in redisplay
3721 when IT->position is set up wrongly due to some bug.
3722 Set IT->current to match the bidi iterator unconditionally.
3723 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3724 entry. Force push_it to save on the stack the current
3725 buffer/string position, to be restored by pop_it. Fix flags in
3726 the iterator structure wrt the object coming from a display
3727 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3728 properties. (Bug#9284)
3730 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3732 * fontset.c (fontset_get_font_group): Add proper type checks.
3735 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3737 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3738 and LC_VERSION_MIN_MACOSX.
3739 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3740 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3742 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3744 * xdisp.c (forward_to_next_line_start): Allow to use the
3745 no-display-properties-and-no-overlays under bidi display.
3746 Set disp_pos in the bidi iterator to avoid searches for display
3747 properties and overlays.
3749 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3751 * editfns.c (Fset_time_zone_rule): Document relationship with the
3754 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3755 the font entity extracted from the cache (Bug#8109).
3757 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3759 * composite.c (autocmp_chars): Don't reset point. That is done by
3760 restore_point_unwind (Bug#5984).
3762 2011-08-07 Juri Linkov <juri@jurta.org>
3764 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3765 to show the arg `TIME' instead of `TIMEVAL'.
3767 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3769 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3770 display property strides EOL and includes a newline, as in
3771 longlines-mode. (Bug#9254)
3772 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3773 word-wrap under bidirectional display. (Bug#9224)
3775 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3776 is non-zero, even if the data buffer is NULL. Fixes a crash in
3777 vertical-motion with longlines-mode. (Bug#9254)
3779 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3781 * bidi.c <bidi_cache_total_alloc>: Now static.
3782 (bidi_initialize): Initialize bidi_cache_total_alloc.
3784 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3787 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3788 amount allocated this far in `bidi_cache_total_alloc'.
3789 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3790 non-zero, only free the data buffer without restoring the cache
3791 contents. All callers changed.
3793 * dispextern.h (bidi_unshelve_cache): Update prototype.
3795 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3796 (move_it_in_display_line, move_it_to)
3797 (move_it_vertically_backward, move_it_by_lines): Replace the call
3798 to xfree to an equivalent call to bidi_unshelve_cache.
3799 (move_it_in_display_line_to): Fix logic of returning
3800 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3802 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3804 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3805 came from a string character with a `cursor' property. (Bug#9229)
3807 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3809 * Makefile.in (LIB_PTHREAD): New variable.
3810 (LIBES): Add LIB_PTHREAD (Bug#9216).
3812 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3813 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3815 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3817 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3819 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3821 * xterm.c (x_find_topmost_parent): New function.
3822 (x_set_frame_alpha): Find topmost parent window with
3823 x_find_topmost_parent and set the property there also (bug#9181).
3824 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3826 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3828 * callproc.c (Fcall_process): Avoid vfork clobbering
3829 the local vars buffer, coding_systems, current_dir.
3831 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3833 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3835 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3837 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3838 so that it is not optimized away.
3840 * xdisp.c (compute_display_string_pos): Remove unused local.
3842 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3844 Fix slow cursor motion and scrolling in large buffers with
3845 selective display, like Org Mode buffers. (Bug#9218)
3847 * dispextern.h (struct bidi_it): New member disp_prop_p.
3849 * xdisp.c: Remove one-slot cache of display string positions.
3850 (compute_display_string_pos): Accept an additional argument
3851 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3852 for a display string or property. If found, set DISP_PROP_P
3855 * bidi.c (bidi_fetch_char): Accept an additional argument
3856 DISP_PROP_P, and pass it to compute_display_string_pos.
3857 Only handle text covered by a display string if DISP_PROP_P is returned
3858 non-zero. All callers of bidi_fetch_char changed.
3860 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3862 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3864 2010-12-03 Don March <don@ohspite.net>
3866 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3867 last character M-[char] is translated to ESC [char] (bug#7541).
3869 2011-08-02 Kenichi Handa <handa@m17n.org>
3871 * lisp.h (uniprop_table): Extern it.
3873 * chartab.c (uniprop_table): Make it non-static.
3875 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3877 * xdisp.c (forward_to_next_line_start): Accept additional argument
3878 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3880 (reseat_at_next_visible_line_start): Use the bidi iterator state
3881 returned by forward_to_next_line_start to restore the state of
3882 it->bidi_it after backing up to previous newline. (Bug#9212)
3884 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3886 * regex.c (re_comp): Protoize.
3887 (re_exec): Fix return type.
3888 (regexec): Fix type of `ret'. (Bug#9203)
3890 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3892 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3893 This is needed if max-image-size is a floating-point number.
3895 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3897 * print.c (print_object): Print empty symbol as ##.
3899 * lread.c (read1): Read ## as empty symbol.
3901 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3903 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3904 setting frame foreground color (Bug#9175).
3905 (x_set_background_color): Likewise.
3907 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3908 contents (Bug#9176).
3909 (EmacsTooltip -init): Remove bezels and add shadows to
3912 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3913 or scroll bar (Bug#8470).
3915 * nsfont.m (nsfont_open): Remove assignment to voffset and
3916 unnecessary vars hshink, expand, hd, full_height, min_height.
3917 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3919 * nsterm.h (nsfont_info): Remove voffset field.
3921 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3923 Implement strike-through and overline on NextStep (Bug#8863).
3925 * nsfont.m (nsfont_open): Use underline position provided by font,
3926 instead of hard-coded value of 2.
3927 (nsfont_draw): Call ns_draw_text_decoration instead.
3929 * nsterm.h: Add declaration for ns_draw_text_decoration.
3931 * nsterm.m (ns_draw_text_decoration): New function for drawing
3932 underline, overline, and strike-through.
3933 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3934 ns_draw_text_decoration. Change treatment of cursor drawing to
3935 accommodate underlining, etc.
3937 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3939 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3942 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3944 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3945 Without this fix, if a signal arrives just after memory fills up,
3946 'malloc' might be invoked reentrantly.
3948 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3949 In other words, assume that every image size is allowed, on non-X
3950 hosts. This assumption is probably wrong, but it lets Emacs compile.
3952 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3954 * regex.c (re_iswctype): Convert return values to boolean.
3956 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3958 * xdisp.c (compute_display_string_pos): Don't use cached display
3959 string position if the buffer had its restriction changed.
3962 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3964 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3966 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3968 Integer signedness and overflow and related fixes. (Bug#9079)
3970 * bidi.c: Integer size and overflow fixes.
3971 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3972 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3973 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3974 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3975 (bidi_find_other_level_edge):
3976 Use ptrdiff_t instead of EMACS_INT where either will do.
3977 This works better on 32-bit hosts configured --with-wide-int.
3978 (bidi_cache_ensure_space): Check for size-calculation overflow.
3979 Use % rather than repeated addition, for better worst-case speed.
3980 Don't set bidi_cache_size until after xrealloc returns, because it
3982 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3983 (bidi_cache_ensure_space): Also check that the bidi cache size
3984 does not exceed that of the largest Lisp string or buffer. See Eli
3985 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3987 * alloc.c (__malloc_size_t): Remove.
3988 All uses replaced by size_t. See Andreas Schwab's note
3989 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3991 * image.c: Improve checking for integer overflow.
3992 (check_image_size): Assume that f is nonnull, since
3993 it is always nonnull in practice. This is one less thing to
3994 worry about when checking for integer overflow later.
3995 (x_check_image_size): New function, which checks for integer
3996 overflow issues inside X.
3997 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3998 This removes the need for a memory_full check.
3999 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
4000 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
4001 (xbm_read_bitmap_data): Change locals back to 'int', since
4002 their values must fit in 'int'.
4003 (xpm_load_image, png_load, tiff_load):
4004 Invoke x_create_x_image_and_pixmap earlier,
4005 to avoid much needless work if the image is too large.
4006 (tiff_load): Treat overly large images as if
4007 x_create_x_image_and_pixmap failed, not as malloc failures.
4008 (gs_load): Use x_check_image_size.
4010 * gtkutil.c: Omit integer casts.
4011 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
4012 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
4014 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
4016 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
4017 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
4018 would wrongly return t on a 64-bit host.
4020 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
4021 The plain *_OVERFLOW macros run afoul of GCC bug 49705
4022 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
4023 and therefore cause GCC to emit a bogus diagnostic in some cases.
4025 * image.c: Integer signedness and overflow and related fixes.
4026 This is not an exhaustive set of fixes, but it's time to
4027 record what I've got.
4028 (lookup_pixel_color, check_image_size): Remove redundant decls.
4029 (check_image_size): Don't assume that arbitrary EMACS_INT values
4030 fit in 'int', or that arbitrary 'double' values fit in 'int'.
4031 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
4032 (tiff_load, imagemagick_load_image):
4033 Check for overflow in size calculations.
4034 (x_create_x_image_and_pixmap): Remove unnecessary test for
4035 xmalloc returning NULL; that can't happen.
4036 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
4037 (xpm_color_bucket): Use better integer hashing function.
4038 (xpm_cache_color): Don't possibly over-allocate memory.
4039 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
4040 (gif_memory_source):
4041 Use ptrdiff_t, not int or size_t, to record sizes.
4042 (png_load): Don't assume values greater than 2**31 fit in 'int'.
4043 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
4044 either works, as we prefer signed integers.
4045 (tiff_read_from_memory, tiff_write_from_memory):
4046 Return tsize_t, not size_t, since that's what the TIFF API wants.
4047 (tiff_read_from_memory): Don't fail simply because the read would
4048 go past EOF; instead, return a short read.
4049 (tiff_load): Omit no-longer-needed casts.
4050 (Fimagemagick_types): Don't assume size fits into 'int'.
4052 Improve hashing quality when configured --with-wide-int.
4053 * fns.c (hash_string): New function, taken from sxhash_string.
4054 Do not discard information about ASCII character case; this
4055 discarding is no longer needed.
4056 (sxhash-string): Use it. Change sig to match it. Caller changed.
4057 * lisp.h: Declare it.
4058 * lread.c (hash_string): Remove, since we now use fns.c's version.
4059 The fns.c version returns a wider integer if --with-wide-int is
4060 specified, so this should help the quality of the hashing a bit.
4062 * emacs.c: Integer overflow minor fix.
4063 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
4064 Define only if GNU_LINUX.
4065 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
4067 * dispnew.c: Integer signedness and overflow fixes.
4068 Remove unnecessary forward decls, that were a maintenance hassle.
4069 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
4071 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
4072 (scrolling_window): Use ptrdiff_t, not int, for byte count.
4073 (prepare_desired_row, line_draw_cost):
4074 Use int, not unsigned, where either works.
4075 (save_current_matrix, restore_current_matrix):
4076 Use ptrdiff_t, not size_t, where either works.
4077 (init_display): Check for overflow more accurately, and without
4078 relying on undefined behavior.
4080 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
4081 Remove, replacing with the new symbols in lisp.h. All uses changed.
4082 * fileio.c (make_temp_name):
4083 * filelock.c (lock_file_1, lock_file):
4084 * xdisp.c (message_dolog):
4085 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
4086 Use pMd etc. instead.
4087 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
4088 replacing the pWIDE etc. symbols removed from editfns.c.
4090 * keyboard.h (num_input_events): Now uintmax_t.
4091 This is (very slightly) less likely to mess up due to wraparound.
4094 * buffer.c: Integer signedness fixes.
4095 (alloc_buffer_text, enlarge_buffer_text):
4096 Use ptrdiff_t rather than size_t when either will do, as we prefer
4099 * alloc.c: Integer signedness and overflow fixes.
4100 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
4101 (__malloc_size_t): Default to size_t, not to int.
4102 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
4103 (Fgarbage_collect, mark_object_loop_halt, mark_object):
4104 Prefer ptrdiff_t to size_t when either would do, as we prefer
4106 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
4107 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
4108 Now const. Initialize with values that are in range even if char
4110 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
4111 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
4112 These functions do the right thing with sizes > 2**32.
4113 (check_depth): Now ptrdiff_t, not int.
4114 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
4115 Adjust to new way of storing sizes. Check for size overflow bugs
4117 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
4118 slightly wrong anyway, as it missed one instance of
4119 XMALLOC_OVERRUN_CHECK_OVERHEAD.
4120 (refill_memory_reserve): Omit needless cast to size_t.
4121 (mark_object_loop_halt): Mark as externally visible.
4123 * xselect.c: Integer signedness and overflow fixes.
4124 (Fx_register_dnd_atom, x_handle_dnd_message):
4125 Use ptrdiff_t, not size_t, since we prefer signed.
4126 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
4127 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
4128 x_dnd_atoms_size and x_dnd_atoms_length.
4130 * doprnt.c: Prefer signed to unsigned when either works.
4132 * doprnt.c (doprnt):
4134 * xdisp.c (vmessage):
4135 Use ptrdiff_t, not size_t, when using or implementing doprnt,
4136 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
4137 prefer signed arithmetic to avoid comparison confusion.
4138 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
4139 but is a bit tricky.
4141 Assume freestanding C89 headers, string.h, stdlib.h.
4142 * data.c, doprnt.c, floatfns.c, print.c:
4143 Include float.h unconditionally.
4144 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
4145 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
4146 * regex.c: Likewise for stddef.h, string.h.
4147 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
4148 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
4149 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
4150 (STDC_HEADERS): Remove obsolete defines.
4151 * sysdep.c: Include limits.h unconditionally.
4153 Assume support for memcmp, memcpy, memmove, memset.
4154 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
4155 * regex.c (memcmp, memcpy):
4156 Remove; we assume C89 now.
4158 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
4159 (__malloc_safe_bcopy): Remove; no longer needed.
4161 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
4162 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
4163 well either way, and we prefer signed to unsigned.
4165 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
4167 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
4168 closes the connection while we're reading (bug#9182).
4170 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
4172 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
4173 are specified (Bug#9168).
4175 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
4177 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
4178 Found by GCC static checking and --with-wide-int on a 32-bit host.
4180 2011-07-25 Eli Zaretskii <eliz@gnu.org>
4182 * xdisp.c (compute_display_string_pos): Fix logic of caching
4183 previous display string position. Initialize cached_prev_pos to
4184 -1. Fixes slow-down at the beginning of a buffer.
4186 2011-07-24 Eli Zaretskii <eliz@gnu.org>
4188 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
4189 for attrs[LFACE_FONTSET_INDEX].
4191 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
4193 * xml.c (parse_region): Remove unused local
4194 that was recently introduced.
4196 2011-07-23 Eli Zaretskii <eliz@gnu.org>
4198 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
4199 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
4201 * xdisp.c (move_it_in_display_line_to): Record the best matching
4202 position for TO_CHARPOS while scanning the line, and restore it on
4203 exit if none of the characters scanned was an exact match.
4204 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
4205 when exact match is impossible due to invisible text, and the
4206 lines are truncated.
4208 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
4210 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4213 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4215 Fix a significant slow-down of cursor motion with C-n, C-p,
4216 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
4217 auto-repeat under bidi redisplay in fontified buffers.
4218 * xdisp.c (compute_stop_pos_backwards): New function.
4219 (next_element_from_buffer): Call compute_stop_pos_backwards to
4220 find a suitable prev_stop when we find ourselves before
4222 (reseat): Don't look for prev_stop, as that could mean a very long
4224 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
4225 <cached_disp_overlay_modiff>: Cache for last found display string
4227 (compute_display_string_pos): Return the cached position if asked
4228 about the same buffer in the same area of character positions, and
4229 the buffer wasn't changed since the time the display string
4230 position was cached.
4232 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4234 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4235 is an integer, which is important for empty lines. (Bug#9149)
4237 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
4239 * frame.c (Fmodify_frame_parameters): In tty case, update the
4240 default face if necessary (Bug#4238).
4242 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
4244 * editfns.c (Fstring_to_char): No need to explain what a character
4245 is in the docstring (Bug#6576).
4247 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4249 * xml.c (parse_region): Make sure we always return a tree.
4251 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4253 * xml.c (parse_region): If a document contains only comments,
4256 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4258 * xml.c (make_dom): Return comments, too.
4260 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4263 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4264 and the surrounding thread.
4265 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4266 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4267 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4269 * s/openbsd.h (BROKEN_SIGIO): Define.
4270 * unexelf.c (unexec) [__OpenBSD__]:
4271 Don't update the .mdebug section of the Alpha COFF symbol table.
4273 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4275 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4278 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4280 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4281 This fixes some race conditions on the permissions of any newly
4284 * alloc.c (valid_pointer_p): Use pipe, not open.
4285 This fixes some permissions issues when debugging.
4287 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4288 If fchown fails to set both uid and gid, try to set just gid,
4289 as that is sometimes allowed. Adjust the file's mode to eliminate
4290 setuid or setgid bits that are inappropriate if fchown fails.
4292 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4294 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4295 to compare Lisp_Objects.
4296 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4297 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4298 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4300 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4302 * lread.c (read_integer): Unread even EOF character.
4303 (read1): Likewise. Properly record start position of symbol.
4305 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4306 symbol character follows.
4308 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4310 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4311 This works around a problem with the previous change to Fcopy_file.
4312 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4313 and without this change, GCC might complain about discarding
4314 fchown's return value.
4316 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
4318 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4320 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4322 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4324 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4326 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4327 it's used from the C level.
4329 * process.c: Use the same condition for POLL_FOR_INPUT in both
4330 keyboard.c and process.c (bug#1858).
4332 2011-07-09 Lawrence Mitchell <wence@gmx.li>
4334 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4335 (Fgnutls_boot): Use it.
4337 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4339 * doc.c (Fsubstitute_command_keys): Revert last change.
4341 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4343 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4344 quotes the next character, and doesn't affect other longer
4345 sequences (bug#8935).
4347 * lread.c (syms_of_lread): Clarify that is isn't only
4348 `eval-buffer' and `eval-defun' that's affected by
4349 `lexical-binding' (bug#8460).
4351 2011-07-15 Eli Zaretskii <eliz@gnu.org>
4353 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
4354 bidi redisplay when a line includes both an image and is truncated.
4356 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4358 Fix minor problems found by static checking.
4359 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4360 (elsz): Now a signed constant, not a size_t var. We prefer signed
4361 types to unsigned, to avoid integer comparison confusion. Without
4362 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4363 "cannot optimize loop, the loop counter may overflow", a symptom
4365 * indent.c (Fvertical_motion): Mark locals as initialized.
4366 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4368 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4370 * search.c (Fre_search_backward): Mention `case-fold-search' in
4371 all the re_search_* functions (bug#8138).
4373 * keyboard.c (Fopen_dribble_file): Document when the file is
4376 2011-07-14 Eli Zaretskii <eliz@gnu.org>
4378 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4381 Support bidi reordering of display and overlay strings.
4382 * xdisp.c (compute_display_string_pos)
4383 (compute_display_string_end): Accept additional argument STRING.
4384 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4385 (reseat_to_string): Initialize bidi_it->string.s and
4386 bidi_it->string.schars.
4387 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
4388 NULL (avoids a crash in bidi_paragraph_init).
4389 Initialize itb.string.lstring.
4390 (init_iterator): Call bidi_init_it only of a valid
4391 buffer position was specified. Initialize paragraph_embedding to
4393 (reseat_to_string): Initialize the bidi iterator.
4394 (display_string): If we need to ignore text properties of
4395 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4396 original value of -1 will not work with bidi.)
4397 (compute_display_string_pos): First arg is now struct
4398 `text_pos *'; all callers changed. Support display properties on
4400 (compute_display_string_end): Support display properties on Lisp
4402 (init_iterator, reseat_1, reseat_to_string): Initialize the
4403 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4404 when iterating on a string not from display properties).
4405 (compute_display_string_pos, compute_display_string_end):
4406 Fix calculation of the object to scan. Fixes an error when using
4408 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4409 base_level_stop; instead, set base_level_stop to BEGV.
4410 Fixes crashes in vertical-motion.
4411 (next_element_from_buffer): Improve commentary for when
4412 the iterator is before prev_stop.
4413 (init_iterator): Initialize bidi_p from the default value of
4414 bidi-display-reordering, not from buffer-local value. Use the
4415 buffer-local value only if initializing for buffer iteration.
4416 (handle_invisible_prop): Support invisible properties on strings
4417 that are being bidi-reordered.
4418 (set_iterator_to_next): Support bidi reordering of C strings and
4420 (next_element_from_string): Support bidi reordering of Lisp
4422 (handle_stop_backwards): Support Lisp strings as well.
4423 (display_string): Support display of R2L glyph rows.
4424 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4425 (init_iterator): Don't initialize it->bidi_p for strings
4427 (reseat_to_string): Initialize it->bidi_p for strings here.
4428 (next_element_from_string, next_element_from_c_string)
4429 (next_element_from_buffer): Add xassert's for correspondence
4430 between IT's object being iterated and it->bidi_it.string
4432 (face_before_or_after_it_pos): Support bidi iteration.
4433 (next_element_from_c_string): Handle the case of the first string
4434 character that is not the first one in the visual order.
4435 (get_visually_first_element): New function, refactored from common
4436 parts of next_element_from_buffer, next_element_from_string, and
4437 next_element_from_c_string.
4438 (tool_bar_lines_needed, redisplay_tool_bar)
4439 (display_menu_bar): Force left-to-right direction. Add a FIXME
4440 comment for making that be controlled by a user option.
4441 (push_it, pop_it): Save and restore the state of the
4442 bidi iterator. Save and restore the bidi_p flag.
4443 (pop_it): Iterate out of display property for string iteration as
4445 (iterate_out_of_display_property): Support iteration over strings.
4446 (handle_single_display_spec): Set up it->bidi_it for iteration
4447 over a display string, and call bidi_init_it.
4448 (handle_single_display_spec, next_overlay_string)
4449 (get_overlay_strings_1, push_display_prop): Set up the bidi
4450 iterator for displaying display or overlay strings.
4451 (forward_to_next_line_start): Don't use the shortcut if
4453 (back_to_previous_visible_line_start): If handle_display_prop
4454 pushed the iterator stack, restore the internal state of the bidi
4455 iterator by calling bidi_pop_it same number of times.
4456 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4457 and we are bidi-iterating, don't decrement the iterator position;
4458 instead, set the first_elt flag in the bidi iterator, to produce
4460 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4461 (push_display_prop): xassert that we are iterating a buffer.
4462 (push_it, pop_it): Save and restore paragraph_embedding member.
4463 (handle_single_display_spec, next_overlay_string)
4464 (get_overlay_strings_1, reseat_1, reseat_to_string)
4465 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4466 correctly. Don't assume unibyte strings are not bidi-reordered.
4467 (compute_display_string_pos)
4468 (compute_display_string_end): Fix handling the case of C string.
4469 (push_it, pop_it): Save and restore from_disp_prop_p.
4470 (handle_single_display_spec, push_display_prop): Set the
4471 from_disp_prop_p flag.
4472 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4473 (pop_it): Call iterate_out_of_display_property only if we are
4474 popping after iteration over a string that came from a display
4475 property. Fix a typo in popping stretch info. Add an assertion
4476 for verifying that the iterator position is in sync with the bidi
4478 (handle_single_display_spec, get_overlay_strings_1)
4479 (push_display_prop): Fix initialization of paragraph direction for
4480 string when that of the parent object is not yet determined.
4481 (reseat_1): Call bidi_init_it to resync the bidi
4482 iterator with IT's position. (Bug#7616)
4483 (find_row_edges): If ROW->start.pos gives position
4484 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4485 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4486 Reset the from_disp_prop_p flag.
4487 (SAVE_IT, RESTORE_IT): New macros.
4488 (pos_visible_p, face_before_or_after_it_pos)
4489 (back_to_previous_visible_line_start)
4490 (move_it_in_display_line_to, move_it_in_display_line)
4491 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4492 (try_scrolling, redisplay_window, display_line): Use them when
4493 saving a temporary copy of the iterator and restoring it back.
4494 (back_to_previous_visible_line_start, reseat_1)
4495 (init_iterator): Empty the bidi cache "stack".
4496 (move_it_in_display_line_to): If iterator ended up at
4497 EOL, but we never saw any buffer positions smaller than
4498 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4499 motion in bidi-reordered lines.
4500 (move_it_in_display_line_to): Record prev_method and prev_pos
4501 immediately before the call to set_iterator_to_next. Fixes cursor
4502 motion in bidi-reordered lines with stretch glyphs and strings
4503 displayed in margins. (Bug#8133) (Bug#8867)
4504 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4506 (pos_visible_p): Support positions in bidi-reordered lines.
4507 Save and restore bidi cache.
4509 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4510 (bidi_paragraph_info): Delete unused struct.
4511 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4512 (bidi_cache_start): New variable.
4513 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4515 (bidi_cache_fetch_state, bidi_cache_search)
4516 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4517 (bidi_cache_find, bidi_peek_at_next_level)
4518 (bidi_level_of_next_char, bidi_find_other_level_edge)
4519 (bidi_move_to_visually_next): Compare cache index with
4520 bidi_cache_start rather than with zero.
4521 (bidi_fetch_char): Accept new argument STRING; all callers
4522 changed. Support iteration over a string. Support strings with
4523 display properties. Support unibyte strings. Fix the type of
4524 `len' according to what STRING_CHAR_AND_LENGTH expects.
4525 (bidi_paragraph_init, bidi_resolve_explicit_1)
4526 (bidi_resolve_explicit, bidi_resolve_weak)
4527 (bidi_level_of_next_char, bidi_move_to_visually_next):
4528 Support iteration over a string.
4529 (bidi_set_sor_type, bidi_resolve_explicit_1)
4530 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4531 can now be zero (for strings); special values 0 and -1 were
4532 changed to -1 and -2, respectively.
4533 (bidi_char_at_pos): New function.
4534 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4535 Call it instead of FETCH_MULTIBYTE_CHAR.
4536 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4537 initialized to valid values.
4538 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4540 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4541 the test for valid cached positions. Fix the logic for looking up
4542 the sentinel state in the cache. GCPRO the Lisp string we are
4544 (bidi_push_it, bidi_pop_it): New functions.
4545 (bidi_initialize): Initialize the bidi cache start stack pointer.
4546 (bidi_cache_ensure_space): New function, refactored from part of
4547 bidi_cache_iterator_state. Don't assume the required size is just
4548 one BIDI_CACHE_CHUNK away.
4549 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4550 (bidi_count_bytes, bidi_char_at_pos): New functions.
4551 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4552 always valid if bidi_cache_idx is valid.
4553 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4554 is valid if it's going to be used.
4555 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4556 (bidi_cache_fetch_state, bidi_cache_search)
4557 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4558 (bidi_cache_iterator_state, bidi_cache_find)
4559 (bidi_find_other_level_edge, bidi_cache_start_stack):
4560 All variables related to cache indices are now EMACS_INT.
4562 * dispextern.h (struct bidi_string_data): New structure.
4563 (struct bidi_it): New member `string'. Make flag members be 1-bit
4564 fields, and put them last in the struct.
4565 (compute_display_string_pos, compute_display_string_end):
4567 (bidi_push_it, bidi_pop_it): Add prototypes.
4568 (struct iterator_stack_entry): New members bidi_p,
4569 paragraph_embedding, and from_disp_prop_p.
4570 (struct it): Member bidi_p is now a bit field 1 bit wide.
4571 (bidi_shelve_cache, bidi_unshelve_cache):
4574 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4575 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4576 and vector-like objects.
4578 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4579 cache around display iteration.
4581 * window.c (Fwindow_end, window_scroll_pixel_based)
4582 (displayed_window_lines, Frecenter): Save and restore the bidi
4583 cache around display iteration.
4585 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4587 * editfns.c (Fdelete_region): Clarify the use of the named
4588 parameters (bug#6788).
4590 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4592 * indent.c (Fvertical_motion): Set and restore w->pointm when
4593 saving and restoring the window's buffer (Bug#9006).
4595 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4597 * editfns.c (Fstring_to_char): Clarify just what is returned
4598 (bug#6576). Text by Eli Zaretskii.
4600 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4602 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4604 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4606 * buffer.c (mmap_find): Fix a typo.
4608 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4610 Fix execution of x selection hooks.
4611 * xselect.c (Qx_lost_selection_functions)
4612 (Qx_sent_selection_functions): New vars.
4613 (syms_of_xselect): DEFSYM them.
4614 (x_handle_selection_request): Pass Qx_sent_selection_functions
4615 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4616 (x_handle_selection_clear,x_clear_frame_selections):
4617 Pass Qx_lost_selection_functions rather than
4618 Vx_lost_selection_functions to Frun_hook_with_args.
4620 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4622 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4623 The old code sometimes used this field without initializing it.
4625 * alloc.c (gc_sweep): Don't read past end of array.
4626 In theory, the old code could also have corrupted Emacs internals,
4627 though it'd be very unlikely.
4629 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4631 * character.c (Fcharacterp): Don't advertise optional ignored
4632 argument. (Bug#4026)
4634 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4636 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4639 * window.c (Fset_window_start): Doc fix (bug#4199).
4640 (Fset_window_hscroll): Ditto.
4642 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4644 Fix minor new problems caught by GCC 4.6.1.
4645 * term.c (init_tty): Remove unused local.
4646 * xsettings.c (store_monospaced_changed): Define this function only
4647 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4650 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4652 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4654 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4656 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4657 are the mini-buffer and the echo area (bug#3320).
4659 * term.c (init_tty): Remove support for supdup, c10 and perq
4660 terminals, which are no longer supported (bug#1482).
4662 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4664 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4666 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4668 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4669 for non-popups (Bug#3642).
4671 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4673 * alloc.c (reset_malloc_hooks): Protoize.
4674 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4675 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4676 * cm.c (losecursor): Likewise.
4677 * data.c (fmod): Likewise.
4678 * dispnew.c (swap_glyphs_in_rows): Likewise.
4679 * emacs.c (memory_warning_signal): Likewise.
4680 * floatfns.c (float_error): Likewise.
4681 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4682 (otf_open, font_otf_capability, generate_otf_features)
4683 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4685 * image.c (pbm_read_file): Likewise.
4686 * indent.c (string_display_width): Likewise.
4687 * intervals.c (check_for_interval, search_for_interval)
4688 (inc_interval_count, count_intervals, root_interval)
4689 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4690 * lread.c (defalias): Likewise.
4691 * ralloc.c (r_alloc_check): Likewise.
4692 * regex.c (set_image_of_range_1, set_image_of_range)
4693 (regex_grow_registers): Likewise.
4694 * sysdep.c (strerror): Likewise.
4695 * termcap.c (valid_filename_p, tprint, main): Likewise.
4696 * tparam.c (main): Likewise.
4697 * unexhp9k800.c (run_time_remap, save_data_space)
4698 (update_file_ptrs, read_header, write_header, calculate_checksum)
4699 (copy_file, copy_rest, display_header): Likewise.
4700 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4702 * xdisp.c (check_it): Likewise.
4703 * xfaces.c (register_color, unregister_color, unregister_colors):
4705 * xfns.c (print_fontset_result): Likewise.
4706 * xrdb.c (member, fatal, main): Likewise.
4708 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4710 Fix minor problems found by static checking (Bug#9031).
4711 * chartab.c (char_table_set_range, map_sub_char_table):
4712 Remove unused locals.
4713 (uniprop_table): Now static.
4714 * composite.c (_work_char): Remove unused static var.
4716 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4718 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4720 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4722 * gtkutil.c (qttip_cb): Remove code without function.
4724 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4726 * w32.c (pthread_sigmask): New stub.
4728 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4730 Use pthread_sigmask, not sigprocmask (Bug#9010).
4731 sigprocmask is portable only for single-threaded applications, and
4732 Emacs can be multi-threaded when it uses GTK.
4733 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4735 * callproc.c (Fcall_process):
4736 * process.c (create_process):
4737 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4738 Use pthread_sigmask, not sigprocmask.
4740 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4742 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4743 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4746 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4748 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4749 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4750 (xg_hide_tooltip): Fix comment.
4752 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4753 in registerServicesMenuSendTypes.
4754 (validRequestorForSendType): Don't check ns_return_types.
4756 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4759 2011-07-08 Jason Rumney <jasonr@gnu.org>
4761 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4762 SH_SHOW for hidden windows (Bug#5482).
4764 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4765 frame struct members of non-existent frames (Bug#6284).
4767 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4769 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4770 variable firstTime not needed on OSX >= 10.6.
4771 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4772 >= 10.5. Use setKnobProportion, setDoubleValue.
4774 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4775 (MAC_OS_X_VERSION_10_5): Define if not defined.
4776 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4777 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4778 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4780 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4781 cString and lossyCString on OSX >= 10.4
4783 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4784 sizeToFit on OSX >= 10.2.
4786 * nsimage.m (allocInitFromFile): Don't use deprecated method
4787 bestRepresentationForDevice on OSX >= 10.6.
4789 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4792 * emacs.c: Declare unexec_init_emacs_zone.
4794 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4796 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4798 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4799 on svcsMenu (Bug#8842).
4801 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4803 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4805 * nsterm.m (QUTF8_STRING): Declare.
4806 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4807 (validRequestorForSendType): Return type is (id).
4808 Change indexOfObjectIdenticalTo to indexOfObject.
4809 Check if we have local selection before returning self (Bug#8842).
4810 (writeSelectionToPasteboard): Put local selection into paste board
4811 if we have a local selection (Bug#8842).
4812 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4814 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4815 (ns_get_local_selection): Declare.
4817 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4819 * keymap.c (describe_map_tree): Don't insert a double newline at
4820 the end of the buffer (bug#1169) and return whether we inserted
4823 * callint.c (Fcall_interactively): Change "reading args" to
4824 "providing args" to try to clarify what it does (bug#1010).
4826 2011-07-07 Kenichi Handa <handa@m17n.org>
4828 * composite.c (composition_compute_stop_pos): Ignore a static
4829 composition starting before CHARPOS (Bug#8915).
4831 * xdisp.c (handle_composition_prop): Likewise.
4833 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4835 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4838 2011-07-07 Kenichi Handa <handa@m17n.org>
4840 * character.h (unicode_category_t): New enum type.
4842 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4843 (Qchar_code_property_table): New variable.
4844 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4845 (UNIPROP_COMPRESSED_FORM_P): New macros.
4846 (char_table_ascii): Uncompress the compressed values.
4847 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4848 Uncompress the compressed values.
4849 (sub_char_table_ref_and_range): Likewise.
4850 (char_table_ref_and_range): Uncompress the compressed values.
4851 (sub_char_table_set): New arg is_uniprop. Callers changed.
4852 Uncompress the compressed values.
4853 (sub_char_table_set_range): Args changed. Callers changed.
4854 (char_table_set_range): Adjuted for the above change.
4855 (map_sub_char_table): Delete args default_val and parent. Add arg
4856 top. Give decoded values to a Lisp function.
4857 (map_char_table): Adjust for the above change. Give decoded
4858 values to a Lisp function. Gcpro more variables.
4859 (uniprop_table_uncompress)
4860 (uniprop_decode_value_run_length): New functions.
4861 (uniprop_decoder, uniprop_decoder_count): New variables.
4862 (uniprop_get_decoder, uniprop_encode_value_character)
4863 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4865 (uniprop_encoder, uniprop_encoder_count): New variables.
4866 (uniprop_get_encoder, uniprop_table)
4867 (Funicode_property_table_internal, Fget_unicode_property_internal)
4868 (Fput_unicode_property_internal): New functions.
4869 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4870 Sunicode_property_table_internal, Sget_unicode_property_internal,
4871 and Sput_unicode_property_internal. Defvar_lisp
4872 char-code-property-alist.
4874 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4875 Vunicode_category_table.
4877 * font.c (font_range): Adjust for the change of
4878 Vunicode_category_table.
4880 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4882 * m/iris4d.h: Remove file, move contents ...
4883 * s/irix6-5.h: ... here.
4885 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4887 Remove unportable assumption about struct layout (Bug#8884).
4888 * alloc.c (mark_buffer):
4889 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4890 (clone_per_buffer_values): Don't assume that
4891 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4892 This isn't true in general, and it's particularly not true
4893 if Emacs is configured with --with-wide-int.
4894 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4895 New macros, used in the buffer.c change.
4897 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4899 * xsettings.c: Use both GConf and GSettings if both are available.
4900 (store_config_changed_event): Add comment.
4901 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4902 (store_tool_bar_style_changed): New functions.
4903 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4904 (struct xsettings): Move font inside HAVE_XFT.
4905 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4906 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4907 Move inside HAVE_XFT.
4908 (something_changed_gsettingsCB): Rename from something_changedCB.
4909 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4911 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4912 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4913 (something_changed_gconfCB): Rename from something_changedCB.
4914 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4915 (parse_settings): Move check for font inside HAVE_XFT.
4916 (read_settings, apply_xft_settings): Add comment.
4917 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4918 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4919 call store_font_name_changed.
4920 (xft_settings_event): Add comment.
4921 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4922 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4923 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4924 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4925 (xsettings_initialize): Call init_gsettings last.
4926 (xsettings_get_system_font, xsettings_get_system_normal_font):
4929 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4931 Random fixes. E.g., (random) never returned negative values.
4932 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4933 subseconds part to the entropy, as that's a bit more random.
4934 Prefer signed to unsigned, since the signedness doesn't matter and
4935 in general we prefer signed. When given a limit, use a
4936 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4937 latter isn't right if USE_2_TAGS_FOR_INTS.
4938 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4939 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4941 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4943 * textprop.c (text_property_stickiness):
4944 Obey Vtext_property_default_nonsticky.
4945 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4946 * w32fns.c (syms_of_w32fns):
4947 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4949 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4951 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4952 This is more efficient than Ffile_directory_p and avoids a minor race.
4954 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4956 * buffer.c (Foverlay_put): Say what the return value is
4959 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4960 is a directory before asking whether to use the file name
4962 (barf_or_query_if_file_exists): Make the "File is a directory"
4963 error be more correct.
4965 * fns.c (Frequire): Remove the mention of the .gz files, since
4966 that's installation-specific, but keep the mention of
4967 `get-load-suffixes'.
4969 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4971 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4972 Report string overflow if the output is too long.
4974 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4976 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4977 (syms_of_gnutls): Remove duplicate DEFSYM for
4978 Qgnutls_bootprop_verify_hostname_error, an error for
4979 Qgnutls_bootprop_verify_error (which is no longer used).
4981 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4982 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4983 Also (re)move comments that are misplaced or no longer relevant.
4985 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4987 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4989 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4991 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4992 and background color parameters if they have been changed.
4994 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4996 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4998 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
5000 * xsettings.c (SYSTEM_FONT): Define only when used.
5001 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
5003 * keymap.c (access_keymap_1): Now static.
5005 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
5007 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
5008 leave any prefix arg for the up event (Bug#1586).
5010 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
5012 * lread.c (syms_of_lread): Mention single symbols defined by
5013 `defvar' or `defconst' (bug#7154).
5015 * fns.c (Frequire): Mention .el.gz files (bug#7314).
5016 (Frequire): Mention get-load-suffixes.
5018 2011-07-02 Martin Rudalics <rudalics@gmx.at>
5020 * window.h (window): Remove clone_number slot.
5021 * window.c (Fwindow_clone_number, Fset_window_clone_number):
5023 (make_parent_window, make_window, saved_window)
5024 (Fset_window_configuration, save_window_save): Don't deal with
5026 * buffer.c (Qclone_number): Remove declaration.
5027 (sort_overlays, overlay_strings): Don't deal with clone numbers.
5029 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
5031 Add multiple inheritance to keymaps.
5032 * keymap.c (Fmake_composed_keymap): New function.
5033 (Fset_keymap_parent): Simplify.
5034 (fix_submap_inheritance): Remove.
5035 (access_keymap_1): New function extracted from access_keymap to handle
5036 embedded parents and handle lists of maps.
5037 (access_keymap): Use it.
5038 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
5039 (Fcopy_keymap): Handle embedded parents.
5040 (Fcommand_remapping, define_as_prefix): Simplify.
5041 (Fkey_binding): Simplify.
5042 (syms_of_keymap): Move minibuffer-local-completion-map,
5043 minibuffer-local-filename-completion-map,
5044 minibuffer-local-must-match-map, and
5045 minibuffer-local-filename-must-match-map to Elisp.
5046 (syms_of_keymap): Defsubr make-composed-keymap.
5047 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
5048 (parse_menu_item): Trivial simplification.
5050 2011-07-01 Glenn Morris <rgm@gnu.org>
5052 * Makefile.in (SETTINGS_LIBS): Fix typo.
5054 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
5056 * coding.c (Fencode_coding_string): Record the last coding system
5057 used, as the function doc string says (bug#8738).
5059 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
5061 * xsettings.c (store_monospaced_changed): Take new font as arg and
5062 check for change against current_mono_font.
5063 (EMACS_TYPE_SETTINGS): Remove this and related defines.
5064 (emacs_settings_constructor, emacs_settings_get_property)
5065 (emacs_settings_set_property, emacs_settings_class_init)
5066 (emacs_settings_init, gsettings_obj): Remove.
5067 (something_changedCB): New function for HAVE_GSETTINGS.
5068 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
5069 with value as argument.
5070 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
5071 g_settings_new (Bug#8967). Do not create gsettings_obj.
5072 Remove calls to g_settings_bind. Connect something_changedCB to
5075 * xgselect.c: Add defined (HAVE_GSETTINGS).
5076 (xgselect_initialize): Ditto.
5078 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
5079 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
5082 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
5084 * eval.c (struct backtrace): Simplify and port the data structure.
5085 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
5086 signed bit field, as this assumption is not portable and it makes
5087 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
5088 "char debug_on_exit : 1" as this is not portable either; instead,
5089 use the portable "unsigned int debug_on_exit : 1". Remove unused
5090 member evalargs. Remove obsolete comments about cc bombing out.
5092 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
5094 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
5095 Let HAVE_GSETTINGS override HAVE_GCONF.
5096 (store_monospaced_changed): New function.
5097 (EMACS_SETTINGS): A new type derived from GObject to handle
5098 GSettings notifications.
5099 (emacs_settings_constructor, emacs_settings_get_property)
5100 (emacs_settings_set_property, emacs_settings_class_init):
5102 (gsettings_client, gsettings_obj): New variables.
5103 (GSETTINGS_SCHEMA): New define.
5104 (something_changedCB): Call store_monospaced_changed.
5105 (init_gsettings): New function.
5106 (xsettings_initialize): Call init_gsettings.
5107 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
5110 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
5113 2011-06-29 Martin Rudalics <rudalics@gmx.at>
5115 * window.c (resize_root_window, grow_mini_window)
5116 (shrink_mini_window): Rename Qresize_root_window to
5117 Qwindow_resize_root_window and Qresize_root_window_vertically to
5118 Qwindow_resize_root_window_vertically.
5120 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
5122 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
5124 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
5126 * makefile.w32-in: Redesign dependencies so they reflect more
5127 clearly which files are directly included by each source file,
5128 and not through other includes.
5130 2011-06-27 Martin Rudalics <rudalics@gmx.at>
5132 * buffer.c (Qclone_number): Declare static and DEFSYM it.
5133 (sort_overlays, overlay_strings): When an overlay's clone number
5134 matches the window's clone number process the overlay even if
5135 the overlay's window property doesn't match the current window.
5137 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
5138 (Fwindow_hchild): Rename to Fwindow_left_child.
5139 (Fwindow_next): Rename to Fwindow_next_sibling.
5140 (Fwindow_prev): Rename to Fwindow_prev_sibling.
5141 (resize_window_check): Rename to window_resize_check.
5142 (resize_window_apply): Rename to window_resize_apply.
5143 (Fresize_window_apply): Rename to Fwindow_resize_apply.
5144 (Fdelete_other_windows_internal, resize_frame_windows)
5145 (Fsplit_window_internal, Fdelete_window_internal)
5146 (grow_mini_window, shrink_mini_window)
5147 (Fresize_mini_window_internal): Fix callers accordingly.
5149 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
5151 * emacsgtkfixed.h: State that this is only used with Gtk+3.
5152 (emacs_fixed_set_min_size): Remove.
5153 (emacs_fixed_new): Take frame as argument.
5155 * emacsgtkfixed.c: State that this is only used with Gtk+3.
5156 (_EmacsFixedPrivate): Remove minwidth/height.
5157 Add struct frame *f.
5158 (emacs_fixed_init): Initialize priv->f.
5159 (get_parent_class, emacs_fixed_set_min_size): Remove.
5160 (emacs_fixed_new): Set priv->f to argument.
5161 (emacs_fixed_get_preferred_width)
5162 (emacs_fixed_get_preferred_height): Use min_width/height from
5163 frames size_hint to set minimum and natural (Bug#8919).
5164 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
5165 and use min_width/height from frames size_hint to set
5166 min_width/height (Bug#8919).
5168 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
5169 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
5172 2011-06-26 Eli Zaretskii <eliz@gnu.org>
5174 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
5175 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
5178 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
5180 * process.c (wait_reading_process_output): Bypass select if
5181 waiting for a cell while ignoring keyboard input, and input is
5182 pending. Suggested by Jan Djärv (Bug#8869).
5184 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
5186 Use gnulib's dup2 module instead of rolling our own.
5187 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
5189 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5191 * dispnew.c (scrolling_window): Before scrolling, turn off a
5192 mouse-highlight in the window being scrolled.
5194 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
5196 Move DEFSYM to lisp.h and use everywhere.
5198 * character.h (DEFSYM): Move declaration...
5199 * lisp.h (DEFSYM): ...here.
5205 * w32select.c: Don't include character.h.
5207 * alloc.c (syms_of_alloc):
5208 * buffer.c (syms_of_buffer):
5209 * bytecode.c (syms_of_bytecode):
5210 * callint.c (syms_of_callint):
5211 * casefiddle.c (syms_of_casefiddle):
5212 * casetab.c (init_casetab_once):
5213 * category.c (init_category_once, syms_of_category):
5214 * ccl.c (syms_of_ccl):
5215 * cmds.c (syms_of_cmds):
5216 * composite.c (syms_of_composite):
5217 * dbusbind.c (syms_of_dbusbind):
5218 * dired.c (syms_of_dired):
5219 * dispnew.c (syms_of_display):
5220 * doc.c (syms_of_doc):
5221 * editfns.c (syms_of_editfns):
5222 * emacs.c (syms_of_emacs):
5223 * eval.c (syms_of_eval):
5224 * fileio.c (syms_of_fileio):
5225 * fns.c (syms_of_fns):
5226 * frame.c (syms_of_frame):
5227 * fringe.c (syms_of_fringe):
5228 * insdel.c (syms_of_insdel):
5229 * keymap.c (syms_of_keymap):
5230 * lread.c (init_obarray, syms_of_lread):
5231 * macros.c (syms_of_macros):
5232 * msdos.c (syms_of_msdos):
5233 * print.c (syms_of_print):
5234 * process.c (syms_of_process):
5235 * search.c (syms_of_search):
5236 * sound.c (syms_of_sound):
5237 * syntax.c (init_syntax_once, syms_of_syntax):
5238 * terminal.c (syms_of_terminal):
5239 * textprop.c (syms_of_textprop):
5240 * undo.c (syms_of_undo):
5241 * w32.c (globals_of_w32):
5242 * window.c (syms_of_window):
5243 * xdisp.c (syms_of_xdisp):
5244 * xfaces.c (syms_of_xfaces):
5245 * xfns.c (syms_of_xfns):
5246 * xmenu.c (syms_of_xmenu):
5247 * xsettings.c (syms_of_xsettings):
5248 * xterm.c (syms_of_xterm): Use DEFSYM.
5250 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5252 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
5254 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5256 Integer and buffer overflow fixes (Bug#8873).
5258 * print.c (printchar, strout): Check for string overflow.
5259 (PRINTPREPARE, printchar, strout):
5260 Don't set size unless allocation succeeds.
5262 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5263 for sizes. Check for string overflow more accurately.
5264 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5266 * macros.c: Integer and buffer overflow fixes.
5267 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5268 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5269 Use ptrdiff_t, not int, for sizes.
5270 Don't increment bufsize until after realloc succeeds.
5271 Check for size-calculation overflow.
5272 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5274 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5276 * lread.c: Integer overflow fixes.
5277 (read_integer): Radix is now EMACS_INT, not int,
5278 to improve quality of diagnostics for out-of-range radices.
5279 Calculate buffer size correctly for out-of-range radices.
5280 (read1): Check for integer overflow in radices, and in
5281 read-circle numbers.
5282 (read_escape): Avoid int overflow.
5283 (Fload, openp, read_buffer_size, read1)
5284 (substitute_object_recurse, read_vector, read_list, map_obarray):
5285 Use ptrdiff_t, not int, for sizes.
5286 (read1): Use EMACS_INT, not int, for sizes.
5287 Check for size overflow.
5289 * image.c (cache_image): Check for size arithmetic overflow.
5291 * lread.c: Integer overflow issues.
5292 (saved_doc_string_size, saved_doc_string_length)
5293 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5294 Now ptrdiff_t, not int.
5295 (read1): Don't assume doc string length fits in int. Check for
5296 out-of-range doc string lengths.
5297 (read_list): Don't assume file position fits in int.
5298 (read_escape): Check for hex character overflow.
5300 2011-06-22 Leo Liu <sdl.web@gmail.com>
5302 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5303 Move to minibuffer.el.
5305 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5307 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
5308 The following patches are for when GLYPH_DEBUG && !XASSERT.
5309 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5310 * dispnew.c (flush_stdout):
5311 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5312 Mark as externally visible.
5313 * dispnew.c (check_window_matrix_pointers): Now static.
5314 * dispnew.c (window_to_frame_vpos):
5315 * xfns.c (unwind_create_frame):
5316 * xterm.c (x_check_font): Remove unused local.
5317 * scroll.c (CHECK_BOUNDS):
5318 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5319 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5320 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5321 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5322 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5324 (debug_method_add): Use va_list and vsprintf rather than relying
5325 on undefined behavior with wrong number of arguments.
5326 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5327 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5328 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5329 since we're not interested in debugging glyphs with old libraries.
5330 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5331 GCC 4.6.0's static checking.
5333 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5335 Integer overflow and signedness fixes (Bug#8873).
5336 A few related buffer overrun fixes, too.
5338 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5340 * dispextern.h (struct face.stipple):
5341 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5342 (x_bitmap_mask, x_allocate_bitmap_record)
5343 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5344 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5345 (x_create_bitmap_from_xpm_data):
5346 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5347 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5349 * xfaces.c (load_pixmap):
5350 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5351 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5352 (.bitmaps_last, struct x_output.icon_bitmap):
5353 Use ptrdiff_t, not int, for bitmap indexes.
5354 (x_allocate_bitmap_record): Check for size overflow.
5355 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5357 Use ptrdiff_t, not int, for overlay counts.
5358 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5359 * editfns.c (overlays_around, get_pos_property):
5360 * textprop.c (get_char_property_and_overlay):
5361 * xdisp.c (next_overlay_change, note_mouse_highlight):
5362 * xfaces.c (face_at_buffer_position):
5363 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5364 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5365 (Fnext_overlay_change, Fprevious_overlay_change)
5366 (mouse_face_overlay_overlaps, Foverlays_in):
5367 Use ptrdiff_t, not int, for sizes.
5368 (overlays_at, overlays_in): Check for size-calculation overflow.
5370 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5372 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5373 (x_session_initialize): Do not assume string length fits in int.
5375 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5376 This is unlikely, but can occur if DPI is outlandish.
5378 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
5379 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5381 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5382 * xrdb.c (magic_file_p, search_magic_path):
5383 Omit last arg SUFFIX; it was always 0. All callers changed.
5384 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5386 * xfont.c (xfont_match): Avoid need for strlen.
5388 * xfns.c: Don't assume strlen fits in int.
5389 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5391 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5392 not unsigned long, as we prefer signed integers. All callers changed.
5393 Detect integer overflow in repeat count.
5394 (message_dolog): Don't assume print length fits in 39 bytes.
5395 (display_mode_element): Don't assume strlen fits in int.
5397 * termcap.c: Don't assume sizes fit in int and never overflow.
5398 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5399 (gobble_line): Check for size-calculation overflow.
5401 * minibuf.c (Fread_buffer):
5402 * lread.c (intern, intern_c_string):
5403 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5404 Don't assume string length fits in int.
5406 * keyboard.c (parse_tool_bar_item):
5407 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5409 * font.c: Don't assume string length fits in int.
5410 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5411 Use ptrdiff_t, not int.
5412 (font_intern_prop): Don't assume string length fits in int.
5413 Don't assume integer property fits in fixnum.
5414 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5416 * filelock.c: Fix some buffer overrun and integer overflow issues.
5417 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5418 Reformulate so as not to need the command string.
5419 Invoke gzip -cd rather than gunzip, as it's more portable.
5420 (lock_info_type, lock_file_1, lock_file):
5421 Don't assume pid_t and time_t fit in unsigned long.
5422 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5423 (current_lock_owner): Prefer signed type for sizes.
5424 Use memcpy, not strncpy, where memcpy is what is really wanted.
5425 Don't assume (via atoi) that time_t and pid_t fit in int.
5426 Check for time_t and/or pid_t out of range, e.g., via a network share.
5427 Don't alloca where an auto var works fine.
5429 * fileio.c: Fix some integer overflow issues.
5430 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5431 Don't assume string length fits in int.
5432 (directory_file_name): Don't assume string length fits in long.
5433 (make_temp_name): Don't assume pid fits in int, or that its print
5434 length is less than 20.
5436 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5438 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5440 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5442 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5443 We prefer signed integers, even for size calculations.
5445 * emacs.c: Don't assume string length fits in 'int'.
5446 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5447 (main): Don't invoke strlen when not needed.
5449 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5450 (XD_DEBUG_MESSAGE): Don't waste a byte.
5452 * callproc.c (getenv_internal_1, getenv_internal)
5454 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5456 * lread.c (invalid_syntax): Omit length argument.
5457 All uses changed. This doesn't fix a bug, but it simplifies the
5458 code away from its former Hollerith-constant appearance, and it's
5459 one less 'int' to worry about when looking at integer-overflow issues.
5460 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5462 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5463 This didn't break anything, but it didn't help either.
5464 It's confusing to put a bogus integer in a place where the actual
5465 value does not matter.
5466 (LIST_END_P): Remove unused macro and its bogus comment.
5467 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5469 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5470 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5472 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5473 We prefer signed types, and the value cannot exceed the EMACS_INT
5474 range anyway (because otherwise the length would not be representable).
5475 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5476 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5477 This avoids a GCC warning when WIDE_EMACS_INT.
5479 * indent.c (sane_tab_width): New function.
5480 (current_column, scan_for_column, Findent_to, position_indentation)
5481 (compute_motion): Use it. This is just for clarity.
5482 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5484 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5486 * lisp.h (lint_assume): New macro.
5487 * composite.c (composition_gstring_put_cache):
5488 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5490 * editfns.c, insdel.c:
5491 Omit unnecessary forward decls, to simplify future changes.
5493 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5495 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5497 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5498 Use much-faster test for byte-length change.
5499 Don't assume string byte-length fits in 'int'.
5500 Check that character arg fits in 'int'.
5501 (mapcar1): Declare byte as byte, for clarity.
5503 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5505 * fns.c (concat): Catch string overflow earlier.
5506 Do not rely on integer wraparound.
5508 * dispextern.h (struct it.overlay_strings_charpos)
5509 (struct it.selective): Now EMACS_INT, not int.
5510 * xdisp.c (forward_to_next_line_start)
5511 (back_to_previous_visible_line_start)
5512 (reseat_at_next_visible_line_start, next_element_from_buffer):
5513 Don't arbitrarily truncate the value of 'selective' to int.
5515 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5517 * composite.c: Don't truncate sizes to 'int'.
5518 (composition_gstring_p, composition_reseat_it)
5519 (composition_adjust_point): Use EMACS_INT, not int.
5520 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5521 not EMACS_UINT, for indexes.
5523 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5525 * buffer.c: Include <verify.h>.
5526 (struct sortvec.priority, struct sortstr.priority):
5527 Now EMACS_INT, not int.
5528 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5529 (struct sortstr.size, record_overlay_string)
5530 (struct sortstrlist.size, struct sortlist.used):
5531 Don't truncate size to int.
5532 (record_overlay_string): Check for size-calculation overflow.
5533 (init_buffer_once): Check at compile-time, not run-time.
5535 2011-06-22 Jim Meyering <meyering@redhat.com>
5537 Don't leak an XBM-image-sized buffer
5538 * image.c (xbm_load): Free the image buffer after using it.
5540 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5543 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5544 that Sun C diagnosed.
5545 * fns.c (secure_hash): Fix pointer signedness issue.
5546 * intervals.c (static_offset_intervals): New function.
5547 (offset_intervals): Use it.
5549 2011-06-21 Leo Liu <sdl.web@gmail.com>
5552 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5555 * fns.c (secure_hash): Rename from crypto_hash_function and change
5556 the first arg to accept symbols.
5557 (Fsecure_hash): New primitive.
5558 (syms_of_fns): New symbols.
5560 2011-06-20 Deniz Dogan <deniz@dogan.se>
5562 * process.c (Fset_process_buffer): Clarify return value in
5565 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5567 * dispnew.c (add_window_display_history): Use BVAR.
5569 * xdisp.c (debug_method_add): Use BVAR.
5570 (check_window_end, dump_glyph_matrix, dump_glyph)
5571 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5573 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5576 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5577 check till after the cache is created in init_frame_faces.
5579 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5581 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5583 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5585 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5586 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5587 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5589 Improve buffer-overflow checking (Bug#8873).
5590 * fileio.c (Finsert_file_contents):
5591 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5592 Remove the old (too-loose) buffer overflow checks.
5593 They weren't needed, since make_gap checks for buffer overflow.
5594 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5595 The old code merely checked for Emacs fixnum overflow, and relied
5596 on undefined (wraparound) behavior. The new code avoids undefined
5597 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5599 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5600 Tune. Don't use wider integers than needed. Don't use alloca.
5601 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5603 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5605 * insdel.c, lisp.h (buffer_overflow): New function.
5606 (insert_from_buffer_1, replace_range, replace_range_2):
5607 * insdel.c (make_gap_larger):
5608 * editfns.c (Finsert_char):
5609 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5611 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5613 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5615 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5617 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5618 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5620 * fileio.c: Don't assume EMACS_INT fits in off_t.
5621 (emacs_lseek): New static function.
5622 (Finsert_file_contents, Fwrite_region): Use it.
5623 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5625 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5627 * fns.c: Don't overflow int when computing a list length.
5628 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5629 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5630 truncation on 64-bit hosts. Check for QUIT every
5631 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5632 faster and is responsive enough.
5633 (Flength): Report an error instead of overflowing an integer.
5634 (Fsafe_length): Return a float if the value is not representable
5635 as a fixnum. This shouldn't happen except in contrived situations.
5636 (Fnthcdr, Fsort): Don't assume list length fits in int.
5637 (Fcopy_sequence): Don't assume vector length fits in int.
5639 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5640 (header_size, word_size): New constants.
5641 (allocate_vectorlike): Don't check size overflow here.
5642 (allocate_vector): Check it here instead, since this is the only
5643 caller of allocate_vectorlike that could cause overflow.
5644 Check that the new vector's length is representable as a fixnum.
5646 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5647 The previous code was bogus. For example, next_almost_prime (32)
5648 returned 39, which is undesirable as it is a multiple of 3; and
5649 next_almost_prime (24) returned 25, which is a multiple of 5 so
5650 why was the code bothering to check for multiples of 7?
5652 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5654 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5656 Variadic C functions now count arguments with ptrdiff_t.
5657 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5658 Back then I didn't know that the Emacs coding style prefers signed int.
5659 Also, in the meantime I found a few more instances where arguments
5660 were being counted with int, which may truncate counts on 64-bit
5661 machines, or EMACS_INT, which may be unnecessarily wide.
5662 * lisp.h (struct Lisp_Subr.function.aMANY)
5663 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5664 Arg counts are now ptrdiff_t, not size_t.
5665 All variadic functions and their callers changed accordingly.
5666 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5667 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5668 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5669 * callint.c (Fcall_interactively): Check arg count for overflow,
5670 to avoid potential buffer overrun. Use signed char, not 'int',
5671 for 'varies' array, so that we needn't bother to check its size
5672 calculation for overflow.
5673 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5674 * eval.c (apply_lambda):
5675 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5676 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5677 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5679 * callint.c (Fcall_interactively): Don't use index var as event count.
5681 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5682 * mem-limits.h (SIZE): Remove; no longer used.
5684 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5686 Remove unnecessary casts.
5687 * xterm.c (x_term_init):
5688 * xfns.c (x_set_border_pixel):
5689 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5690 These aren't needed now that we assume ANSI C.
5692 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5693 It's more likely to cause problems (due to unsigned overflow)
5696 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5698 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5700 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5702 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5704 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5706 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5708 GLYPH_CODE_FACE returns EMACS_INT, not int.
5709 * dispextern.h (merge_faces):
5710 * xfaces.c (merge_faces):
5711 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5712 Don't assume EMACS_INT fits in int.
5714 * character.h (CHAR_VALID_P): Remove unused parameter.
5715 * fontset.c, lisp.h, xdisp.c: All uses changed.
5717 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5719 * fns.c (concat): Minor tuning based on overflow analysis.
5720 This doesn't fix any bugs. Use int to hold character, instead
5721 of constantly refetching from Emacs object. Use XFASTINT, not
5722 XINT, for value known to be a character. Don't bother comparing
5723 a single byte to 0400, as it's always less.
5725 * floatfns.c (Fexpt):
5726 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5728 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5731 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5733 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5734 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5735 incorrectly succeed when S was a string, because 4294967386 was
5736 truncated before it was used.
5738 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5739 Otherwise, an out-of-range integer could cause undefined behavior
5742 * composite.c: Use int, not EMACS_INT, for characters.
5743 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5744 EMACS_INT, for values that are known to be in character range.
5745 This doesn't fix any bugs but is the usual style inside Emacs and
5746 may generate better code on 32-bit machines.
5748 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5749 This is for reasons similar to the recent CHAR_STRING fix.
5750 * charset.c (Fencode_char): Check that character arg is actually
5751 a character. Pass an int to ENCODE_CHAR.
5752 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5753 wider than 'int', as a compile-time check to prevent future regressions
5756 * character.c (char_string): Remove unnecessary casts.
5758 Make sure a 64-bit char is never passed to CHAR_STRING.
5759 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5760 by silently ignoring the top 32 bits, allowing some values
5761 that were far too large to be valid characters.
5762 * character.h: Include <verify.h>.
5763 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5764 arguments are no wider than unsigned, as a compile-time check
5765 to prevent future regressions in this area.
5767 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5768 (Fsubst_char_in_region):
5770 * xdisp.c (decode_mode_spec_coding):
5771 Adjust to CHAR_STRING's new requirement.
5772 * editfns.c (Finsert_char, Fsubst_char_in_region):
5773 * fns.c (concat): Check that character args are actually
5774 characters. Without this test, these functions did the wrong
5775 thing with wildly out-of-range values on 64-bit hosts.
5777 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5778 These casts should not be needed on 32-bit hosts, either.
5779 * keyboard.c (read_char):
5780 * lread.c (Fload): Remove casts to unsigned.
5782 * lisp.h (UNSIGNED_CMP): New macro.
5783 This fixes comparison bugs on 64-bit hosts.
5784 (ASCII_CHAR_P): Use it.
5785 * casefiddle.c (casify_object):
5786 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5787 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5788 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5789 * dispextern.h (FACE_FROM_ID):
5790 * keyboard.c (read_char): Use UNSIGNED_CMP.
5792 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5793 not to EMACS_INT, to avoid GCC warning.
5795 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5797 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5798 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5799 isn't needed on 32-bit machines.
5801 * buffer.c (Fgenerate_new_buffer_name):
5802 Use EMACS_INT for count, not int.
5803 (advance_to_char_boundary): Return EMACS_INT, not int.
5805 * data.c (Qcompiled_function): Now static.
5807 * window.c (window_body_lines): Now static.
5809 * image.c (gif_load): Rename local to avoid shadowing.
5811 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5812 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5813 * alloc.c (make_save_value): Integer argument is now of type
5815 (mark_object): Use ptrdiff_t, not int.
5816 * lisp.h (pD): New macro.
5817 * print.c (print_object): Use it.
5819 * alloc.c: Use EMACS_INT, not int, to count objects.
5820 (total_conses, total_markers, total_symbols, total_vector_size)
5821 (total_free_conses, total_free_markers, total_free_symbols)
5822 (total_free_floats, total_floats, total_free_intervals)
5823 (total_intervals, total_strings, total_free_strings):
5824 Now EMACS_INT, not int. All uses changed.
5825 (Fgarbage_collect): Compute overall total using a double, so that
5826 integer overflow is less likely to be a problem. Check for overflow
5827 when converting back to an integer.
5828 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5829 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5830 These were 'int' variables that could overflow on 64-bit hosts;
5831 they were never used, so remove them instead of repairing them.
5832 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5833 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5834 Previously, this ceilinged at INT_MAX, but that doesn't work on
5836 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5838 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5839 (allocate_vectorlike): Check for ptrdiff_t overflow.
5840 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5841 when a (possibly-narrower) signed value would do just as well.
5842 We prefer using signed arithmetic, to avoid comparison confusion.
5844 * alloc.c: Catch some string size overflows that we were missing.
5845 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5846 for convenience in STRING_BYTES_MAX.
5847 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5848 The definition here is exact; the one in lisp.h was approximate.
5849 (allocate_string_data): Check for string overflow. This catches
5850 some instances we weren't catching before. Also, it catches
5851 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5852 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5853 and ptrdiff_t and EMACS_INT are both 64 bits.
5855 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5856 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5857 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5859 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5861 * alloc.c (Fmake_string): Check for out-of-range init.
5863 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5865 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5867 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5869 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5870 xg_get_default_scrollbar_width.
5872 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5873 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5874 (style_changed_cb): Call update_theme_scrollbar_width and call
5875 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5876 all frames (Bug#8505).
5877 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5878 Call gtk_window_set_resizable if HAVE_GTK3.
5879 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5880 and height if HAVE_GTK3 (Bug#8505).
5881 (scroll_bar_width_for_theme): New variable.
5882 (update_theme_scrollbar_width): New function.
5883 (xg_get_default_scrollbar_width): Move code to
5884 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5885 (xg_initialize): Call update_theme_scrollbar_width.
5887 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5889 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5891 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5893 * frame.c (make_frame): Call other_buffer_safely instead of
5896 * window.c (temp_output_buffer_show): Call display_buffer with
5897 second argument Vtemp_buffer_show_specifiers and reset latter
5898 immediately after the call.
5899 (Vtemp_buffer_show_specifiers): New variable.
5900 (auto_window_vscroll_p, next_screen_context_lines)
5901 (Vscroll_preserve_screen_position): Remove leading asterisks from
5904 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5906 Fix minor problems found by GCC 4.6.0 static checking.
5907 * buffer.c (Qclone_number): Remove for now, as it's unused.
5908 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5909 (record_buffer): Remove unused local.
5910 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5911 (set_frame_buffer_list): Remove; unused.
5912 * frame.h (other_visible_frames): Remove decl.
5913 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5914 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5915 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5917 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5918 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5919 Define only if HAVE_GPM.
5920 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5921 (update_hints_inhibit): Remove; never set. All uses removed.
5922 * widgetprv.h (emacsFrameClassRec): Remove decl.
5923 * window.c (delete_deletable_window): Now returns void, since it
5924 wasn't returning anything.
5925 (compare_window_configurations): Remove unused locals.
5926 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5927 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5928 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5929 the same widths as pointers. This follows up on the 2011-05-06 patch.
5930 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5931 * xterm.h: Likewise.
5932 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5934 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5936 * makefile.w32-in: Update dependencies.
5937 (LISP_H): Add lib/intprops.h.
5939 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5941 * image.c (gif_load): Add animation frame delay to the metadata.
5942 (syms_of_image): Use DEFSYM. New symbol `delay'.
5944 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5946 * window.c (delete_deletable_window): Re-add.
5947 (Fset_window_configuration): Rewrite to handle dead buffers and
5948 consequently deletable windows.
5949 (window_tree, Fwindow_tree): Remove. Supply functionality in
5951 (compare_window_configurations): Simplify code.
5953 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5955 * image.c (imagemagick_load_image): Fix type mismatch.
5956 (Fimagemagick_types): Likewise.
5958 * window.h (replace_buffer_in_windows): Declare.
5960 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5962 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5963 Qclone_number. Remove external declaration of Qdelete_window.
5964 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5966 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5967 Run Qbuffer_list_update_hook if allowed.
5968 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5969 buffer list implementation.
5970 (other_buffer_safely): New function.
5971 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5972 calls to replace_buffer_in_windows and
5973 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5975 (record_buffer): Inhibit quitting and rewrite using quittable
5976 functions. Run Qbuffer_list_update_hook if allowed.
5977 (Frecord_buffer, Funrecord_buffer): New functions.
5978 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5979 Move switch-to-buffer to window.el.
5980 (bury-buffer): Move to window.el.
5981 (Vbuffer_list_update_hook): New variable.
5983 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5986 * window.h (resize_frame_windows): Move up in code.
5987 (Fwindow_frame): Remove EXFUN.
5988 (replace_buffer_in_all_windows): Remove prototype.
5989 (replace_buffer_in_windows_safely): Add prototype.
5991 * window.c: Declare Qdelete_window static again. Move down
5992 declaration of select_count.
5993 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5994 (Fother_window): Move to window.el.
5995 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5996 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5997 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5999 (replace_buffer_in_windows): Implement by calling
6000 Qreplace_buffer_in_windows.
6001 (replace_buffer_in_all_windows): Remove with some functionality
6002 moved into replace_buffer_in_windows_safely.
6003 (replace_buffer_in_windows_safely): New function.
6004 (select_window_norecord, select_frame_norecord): Move in front
6005 of run_window_configuration_change_hook. Remove now obsolete
6007 (Fset_window_buffer): Rewrite doc-string.
6008 Call Qrecord_window_buffer.
6009 (keys_of_window): Move binding for other-window to window.el.
6011 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
6013 * dispextern.h (struct image): Replace data member, whose int_val
6014 and ptr_val fields were not used by anything, with a single
6017 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
6018 (gif_clear_image, gif_load, imagemagick_load_image)
6019 (gs_clear_image, gs_load): Callers changed.
6021 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
6023 * buffer.h: Include <time.h>, for time_t.
6024 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
6026 Fix minor problems found by static checking.
6028 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
6030 Make identifiers static if they are not used in other modules.
6031 * data.c (Qcompiled_function, Qframe, Qvector):
6032 * image.c (QimageMagick, Qsvg):
6033 * minibuf.c (Qmetadata):
6034 * window.c (resize_window_check, resize_root_window): Now static.
6035 * window.h (resize_window_check, resize_root_window): Remove decls.
6037 * window.c (window_deletion_count, delete_deletable_window):
6039 (window_body_lines): Now static.
6040 (Fdelete_other_windows_internal): Mark vars as initialized.
6041 Make sure 'resize_failed' is initialized.
6042 (run_window_configuration_change_hook): Rename local to avoid shadowing.
6043 (resize_window_apply): Remove unused local.
6044 * window.h (delete_deletable_window): Remove decl.
6046 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
6047 (imagemagick_load_image): Fix pointer signedness problem by changing
6048 last arg from unsigned char * to char *. All uses changed.
6049 Also, fix a local for similar reasons.
6050 Remove unused locals. Remove locals to avoid shadowing.
6051 (fn_rsvg_handle_free): Remove; unused.
6052 (svg_load, svg_load_image): Fix pointer signedness problem.
6053 (imagemagick_load_image): Don't use garbage pointer image_wand.
6055 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
6057 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
6059 * image.c (gif_load): Fix omitted cast error introduced by
6062 2011-06-10 Martin Rudalics <rudalics@gmx.at>
6064 * window.h (resize_proportionally, orig_total_lines)
6065 (orig_top_line): Remove from window structure.
6066 (set_window_height, set_window_width, change_window_heights)
6067 (Fdelete_window): Remove prototypes.
6068 (resize_frame_windows): Remove duplicate declaration.
6070 2011-06-10 Eli Zaretskii <eliz@gnu.org>
6072 * window.h (resize_frame_windows, resize_window_check)
6073 (delete_deletable_window, resize_root_window)
6074 (resize_frame_windows): Declare prototypes.
6076 * window.c (resize_window_apply): Make definition be "static" to
6077 match the prototype.
6079 2011-06-10 Martin Rudalics <rudalics@gmx.at>
6081 * window.c: Remove declarations of Qwindow_size_fixed,
6082 window_min_size_1, window_min_size_2, window_min_size,
6083 size_window, window_fixed_size_p, enlarge_window, delete_window.
6084 Remove static from declaration of Qdelete_window, it's
6085 temporarily needed by Fbury_buffer.
6086 (replace_window): Don't assign orig_top_line and
6088 (Fdelete_window, delete_window): Remove. Window deletion is
6089 handled by window.el.
6090 (window_loop): Remove DELETE_OTHER_WINDOWS case.
6091 Replace Fdelete_window calls with calls to Qdelete_window.
6092 (Fdelete_other_windows): Remove. Deleting other windows is
6093 handled by window.el.
6094 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
6095 handled in window.el.
6096 (window_min_size_2, window_min_size_1, window_min_size): Remove.
6097 Window minimum sizes are handled in window.el.
6098 (shrink_windows, size_window, set_window_height)
6099 (set_window_width, change_window_heights, window_height)
6100 (window_width, CURBEG, CURSIZE, enlarge_window)
6101 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
6102 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
6103 handled in window.el.
6104 (make_dummy_parent): Rename to make_parent_window and give it a
6105 second argument horflag.
6106 (make_window): Don't set resize_proportionally any more.
6107 (Fsplit_window): Remove. Windows are split in window.el.
6108 (save_restore_action, save_restore_orig_size)
6109 (shrink_window_lowest_first, save_restore_orig_size): Remove.
6110 Resize mini windows in window.el.
6111 (grow_mini_window, shrink_mini_window): Implement by calling
6112 Qresize_root_window_vertically, resize_window_check and
6113 resize_window_apply.
6114 (saved_window, Fset_window_configuration, save_window_save):
6115 Do not handle orig_top_line, orig_total_lines, and
6116 resize_proportionally.
6117 (window_min_height, window_min_width): Move to window.el.
6118 (keys_of_window): Move bindings for delete-other-windows,
6119 split-window, delete-window and enlarge-window to window.el.
6121 * buffer.c: Temporarily extern Qdelete_window.
6122 (Fbury_buffer): Temporarily call Qdelete_window instead of
6123 Fdelete_window (Fbury_buffer will move to window.el soon).
6125 * frame.c (set_menu_bar_lines_1): Remove code handling
6126 orig_top_line and orig_total_lines.
6128 * dispnew.c (adjust_frame_glyphs_initially): Don't use
6129 set_window_height but set heights directly.
6130 (change_frame_size_1): Use resize_frame_windows.
6132 * xdisp.c (init_xdisp): Don't use set_window_height but set
6135 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
6136 Use resize_frame_windows instead of change_window_heights and run
6137 run_window_configuration_change_hook.
6139 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
6140 instead of change_window_heights and run
6141 run_window_configuration_change_hook.
6143 2011-06-09 Martin Rudalics <rudalics@gmx.at>
6145 * window.c (replace_window): Rename second argument REPLACEMENT to
6146 NEW. New third argument SETFLAG. Rewrite.
6147 (delete_window, make_dummy_parent): Call replace_window with
6149 (window_list_1): Move down in code.
6150 (run_window_configuration_change_hook): Move set_buffer part
6151 before select_frame_norecord part in order to unwind correctly.
6152 Rename count1 to count.
6153 (recombine_windows, delete_deletable_window, resize_root_window)
6154 (Fdelete_other_windows_internal)
6155 (Frun_window_configuration_change_hook, make_parent_window)
6156 (resize_window_check, resize_window_apply, Fresize_window_apply)
6157 (resize_frame_windows, Fsplit_window_internal)
6158 (Fdelete_window_internal, Fresize_mini_window_internal):
6160 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
6162 2011-06-08 Martin Rudalics <rudalics@gmx.at>
6164 * window.h (window): Add some new members to window structure -
6165 normal_lines, normal_cols, new_total, new_normal, clone_number,
6166 splits, nest, prev_buffers, next_buffers.
6167 (WINDOW_TOTAL_SIZE): Move here from window.c.
6168 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
6170 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
6172 (make_dummy_parent): Set new members of windows structure.
6173 (make_window): Move down in code. Handle new members of window
6175 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
6176 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
6177 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
6178 (Fset_window_prev_buffers, Fwindow_next_buffers)
6179 (Fset_window_next_buffers, Fset_window_clone_number):
6181 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
6182 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
6184 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
6185 Argument WINDOW can be now internal window too.
6186 (Fwindow_use_time): Move up in code.
6187 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
6189 (Fset_window_configuration, saved_window)
6190 (Fcurrent_window_configuration, save_window_save): Handle new
6191 members of window structure.
6192 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
6193 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
6194 (syms_of_window): New Lisp objects Qrecord_window_buffer,
6195 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
6196 Qget_mru_window, Qresize_root_window,
6197 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
6198 Qauto_buffer_name; staticpro them.
6200 2011-06-07 Martin Rudalics <rudalics@gmx.at>
6202 * window.c (Fwindow_total_size, Fwindow_left_column)
6203 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
6204 (Fwindow_list_1): New functions.
6205 (window_box_text_cols): Replace with window_body_cols.
6206 (Fwindow_width, Fscroll_left, Fscroll_right):
6207 Use window_body_cols instead of window_box_text_cols.
6208 (delete_window, Fset_window_configuration):
6209 Call delete_all_subwindows with window as argument.
6210 (delete_all_subwindows): Take a window as argument and not a
6212 (window_loop): Remove handling of GET_LRU_WINDOW and
6214 (Fget_lru_window, Fget_largest_window): Move to window.el.
6216 * window.h: Extern window_body_cols instead of
6217 window_box_text_cols. delete_all_subwindows now takes a
6218 Lisp_Object as argument.
6220 * indent.c (compute_motion, Fcompute_motion):
6221 Use window_body_cols instead of window_box_text_cols.
6223 * frame.c (delete_frame): Call delete_all_subwindows with root
6226 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
6228 * fns.c (Fputhash): Document return value.
6230 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
6232 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6234 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6236 Cons<->int and similar integer overflow fixes (Bug#8794).
6238 Check for overflow when converting integer to cons and back.
6239 * charset.c (Fdefine_charset_internal, Fdecode_char):
6240 Use cons_to_unsigned to catch overflow.
6241 (Fencode_char): Use INTEGER_TO_CONS.
6242 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6243 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6244 * data.c (long_to_cons, cons_to_long): Remove.
6245 (cons_to_unsigned, cons_to_signed): New functions.
6246 These signal an error for invalid or out-of-range values.
6247 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6248 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6249 * font.c (Ffont_variation_glyphs):
6250 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6251 * lisp.h: Include <intprops.h>.
6252 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6253 (cons_to_signed, cons_to_unsigned): New decls.
6254 (long_to_cons, cons_to_long): Remove decls.
6255 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6256 (Fprimitive_undo): Use CONS_TO_INTEGER.
6257 * xfns.c (Fx_window_property): Likewise.
6258 * xselect.c: Include <limits.h>.
6259 (x_own_selection, selection_data_to_lisp_data):
6260 Use INTEGER_TO_CONS.
6261 (x_handle_selection_request, x_handle_selection_clear)
6262 (x_get_foreign_selection, Fx_disown_selection_internal)
6263 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6264 (lisp_data_to_selection_data): Use cons_to_unsigned.
6265 (x_fill_property_data): Use cons_to_signed.
6266 Report values out of range.
6268 Check for buffer and string overflow more precisely.
6269 * buffer.h (BUF_BYTES_MAX): New macro.
6270 * lisp.h (STRING_BYTES_MAX): New macro.
6271 * alloc.c (Fmake_string):
6272 * character.c (string_escape_byte8):
6273 * coding.c (coding_alloc_by_realloc):
6274 * doprnt.c (doprnt):
6275 * editfns.c (Fformat):
6277 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6278 since they may not be the same number.
6279 * editfns.c (Finsert_char):
6280 * fileio.c (Finsert_file_contents):
6281 Likewise for BUF_BYTES_MAX.
6283 * image.c: Use ptrdiff_t, not int, for sizes.
6284 (slurp_file): Switch from int to ptrdiff_t.
6286 (slurp_file): Check that file size fits in both size_t (for
6287 malloc) and ptrdiff_t (for sanity and safety).
6289 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6290 if b->modtime has its maximal value.
6292 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6294 Don't assume time_t can fit into int.
6295 * buffer.h (struct buffer.modtime): Now time_t, not int.
6296 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6297 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6299 Minor fixes for signed vs unsigned integers.
6300 * character.h (MAYBE_UNIFY_CHAR):
6301 * charset.c (maybe_unify_char):
6302 * keyboard.c (read_char, reorder_modifiers):
6303 XINT -> XFASTINT, since the integer must be nonnegative.
6304 * ftfont.c (ftfont_spec_pattern):
6305 * keymap.c (access_keymap, silly_event_symbol_error):
6306 XUINT -> XFASTINT, since the integer must be nonnegative.
6307 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6308 since it makes no difference and we prefer signed.
6309 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6310 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6313 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6315 * window.h (Fwindow_frame): Declare.
6317 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6319 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6320 (SPARE_MEMORY): Always define.
6321 (LARGE_REQUEST): Remove.
6322 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6324 2011-06-06 Martin Rudalics <rudalics@gmx.at>
6326 * lisp.h: Move EXFUNS for Fframe_root_window,
6327 Fframe_first_window and Fset_frame_selected_window to window.h.
6329 * window.h: Move EXFUNS for Fframe_root_window,
6330 Fframe_first_window and Fset_frame_selected_window here from
6333 * frame.c (Fwindow_frame, Fframe_first_window)
6334 (Fframe_root_window, Fframe_selected_window)
6335 (Fset_frame_selected_window): Move to window.c.
6336 (Factive_minibuffer_window): Move to minibuf.c.
6337 (Fother_visible_frames_p): New function.
6339 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6341 * window.c (decode_window, decode_any_window): Move up in code.
6342 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6343 (inhibit_frame_unsplittable): Remove unused variable.
6344 (Fwindow_buffer): Move up and rewrite doc-string.
6345 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6346 (Fwindow_prev): New functions.
6347 (Fwindow_frame): Move here from frame.c. Accept any window as
6349 (Fframe_root_window, Fframe_first_window)
6350 (Fframe_selected_window): Move here from frame.c. Accept frame
6351 or arbitrary window as argument. Update doc-strings.
6352 (Fminibuffer_window): Move up in code.
6353 (Fwindow_minibuffer_p): Move up in code and simplify.
6354 (Fset_frame_selected_window): Move here from frame.c.
6356 (Fselected_window, select_window, Fselect_window): Move up in
6357 code. Minor doc-string fixes.
6359 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6361 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6362 Do not assume that spare memory exists; that assumption is valid
6363 only if SYSTEM_MALLOC.
6364 (LARGE_REQUEST): New macro, so that the issue of large requests
6365 is separated from the issue of spare memory.
6367 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6369 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6372 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6374 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6377 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6379 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6381 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6383 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6384 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6386 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
6388 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6390 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
6392 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6393 (x_clipboard_manager_save): Add return value.
6394 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6396 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6397 Obey Vx_select_enable_clipboard_manager. Catch errors in
6398 x_clipboard_manager_save (Bug#8779).
6399 (Vx_select_enable_clipboard_manager): New variable.
6400 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6402 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6404 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6406 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6408 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6409 in the current matrix if keep_current_p is non-zero.
6411 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6413 * bidi.c (bidi_level_of_next_char): Fix last change.
6415 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6417 Support bidi reordering of text covered by display properties.
6419 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6420 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6421 (bidi_cache_search, bidi_cache_iterator_state)
6422 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6423 (bidi_level_of_next_char, bidi_move_to_visually_next):
6424 Support character positions inside a run of characters covered by a
6426 (bidi_paragraph_init, bidi_resolve_explicit_1)
6427 (bidi_level_of_next_char): Call bidi_fetch_char and
6428 bidi_fetch_char_advance instead of FETCH_CHAR and
6430 (bidi_init_it): Initialize new members.
6431 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6433 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6434 instead of using explicit *_CHAR codes.
6435 (bidi_resolve_explicit, bidi_resolve_weak):
6436 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6437 bidirectional text is supported only in multibyte buffers.
6438 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6439 it to initialize the frame_window_p member of struct bidi_it.
6440 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6441 (bidi_resolve_explicit, bidi_resolve_weak)
6442 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6443 bidi_it->nchars is non-positive.
6444 (bidi_level_of_next_char): Don't try to lookup the cache for the
6445 next/previous character if nothing is cached there yet, or if we
6446 were just reseat()'ed to a new position.
6448 * xdisp.c (set_cursor_from_row): Set start and stop points
6449 according to the row's direction when priming the loop that looks
6450 for the glyph on which to display cursor.
6451 (single_display_spec_intangible_p): Function deleted.
6452 (display_prop_intangible_p): Reimplement to call
6453 handle_display_spec instead of single_display_spec_intangible_p.
6454 Accept 3 additional arguments needed by handle_display_spec.
6455 This fixes incorrect cursor motion across display property with complex
6456 values: lists, `(when COND...)' forms, etc.
6457 (single_display_spec_string_p): Support property values that are
6458 lists with the argument STRING its top-level element.
6459 (display_prop_string_p): Fix the condition for processing a
6460 property that is a list to be consistent with handle_display_spec.
6461 (handle_display_spec): New function, refactored from the
6462 last portion of handle_display_prop.
6463 (compute_display_string_pos): Accept additional argument
6464 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6465 value of a `display' property is a "replacing spec".
6466 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6467 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6468 the display property, but just return a value indicating whether
6469 the display property will replace the characters it covers.
6470 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6471 frame_window_p members of struct bidi_it.
6472 (compute_display_string_pos, compute_display_string_end):
6474 (push_it): Accept second argument POSITION, where pop_it should
6475 jump to continue iteration.
6476 (reseat_1): Initialize bidi_it.disp_pos.
6478 * keyboard.c (adjust_point_for_property): Adjust the call to
6479 display_prop_intangible_p to its new signature.
6481 * dispextern.h (struct bidi_it): New member frame_window_p.
6482 (bidi_init_it): Update prototypes.
6483 (display_prop_intangible_p): Update prototype.
6484 (compute_display_string_pos, compute_display_string_end):
6486 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6489 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6491 Malloc failure behavior now depends on size of allocation.
6492 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6493 * lisp.h: Change signatures accordingly.
6494 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6495 All callers changed. (Bug#8762)
6497 * gnutls.c: Use Emacs's memory allocators.
6498 Without this change, the gnutls library would invoke malloc etc.
6499 directly, which causes problems on non-SYNC_INPUT hosts, and which
6500 runs afoul of improving memory_full behavior. (Bug#8761)
6501 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6502 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6503 xfree instead of the default malloc, realloc, free.
6504 (Fgnutls_boot): No need to check for memory allocation failure,
6505 since xmalloc does that for us.
6507 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6508 * category.c (hash_get_category_set):
6509 * ccl.c (ccl_driver):
6510 * charset.c (Fdefine_charset_internal):
6511 * charset.h (struct charset.hash_index):
6512 * composite.c (get_composition_id, gstring_lookup_cache)
6513 (composition_gstring_put_cache):
6514 * composite.h (struct composition.hash_index):
6515 * dispextern.h (struct image.hash):
6516 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6517 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6518 (hashfn_equal, hashfn_user_defined, make_hash_table)
6519 (maybe_resize_hash_table, hash_lookup, hash_put)
6520 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6521 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6522 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6523 * image.c (make_image, search_image_cache, lookup_image)
6524 (xpm_put_color_table_h):
6525 * lisp.h (struct Lisp_Hash_Table):
6526 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6527 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6528 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6529 * alloc.c (allocate_vectorlike):
6530 Check for overflow in vector size calculations.
6531 * ccl.c (ccl_driver):
6532 Check for overflow when converting EMACS_INT to int.
6533 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6534 need to be updated by these changes.
6535 * fns.c (make_hash_table, maybe_resize_hash_table):
6536 Check for integer overflow with large hash tables.
6537 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6538 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6539 (SXHASH_REDUCE): New macro.
6540 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6541 Use it instead of discarding useful hash info with large hash values.
6542 (sxhash_float): New function.
6543 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6544 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6545 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6546 Rewrite to use FIXNUM_BITS, as this simplifies things.
6547 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6548 Adjust signatures to match updated version of code.
6549 (consing_since_gc): Now EMACS_INT, since a single hash table can
6550 use more than INT_MAX bytes.
6552 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6554 Make it possible to build with GCC-4.6+ -O2 -flto.
6556 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6558 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6560 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6561 Call minibuffer-inactive-mode.
6563 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6565 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6566 Update dependencies.
6568 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6570 * data.c (init_data): Remove code for UTS, this system is not
6573 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6575 Don't force ./temacs to start in terminal mode.
6577 * frame.c (make_initial_frame): Initialize faces in all cases, not
6578 only when CANNOT_DUMP is defined.
6579 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6581 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6583 * dispnew.c (add_window_display_history): Use const for the string
6584 pointer. Remove declaration, not needed.
6586 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6588 Use 'inline', not 'INLINE'.
6589 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6590 * alloc.c, fontset.c (INLINE): Remove.
6591 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6592 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6593 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6594 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6595 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6597 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6599 Make it possible to run ./temacs.
6601 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6602 syms_of_callproc does the same thing. Remove test for
6603 "initialized", do it in the caller.
6604 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6606 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6608 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6609 (read_minibuf): Use get_minibuffer.
6610 (syms_of_minibuf): Use DEFSYM.
6611 (Qmetadata): New var.
6612 * data.c (Qbuffer): Don't make it static.
6613 (syms_of_data): Use DEFSYM.
6615 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6617 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6618 (CCL_CODE_MIN): New macro.
6620 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6622 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6624 * eval.c (Qdebug): Now static.
6625 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6626 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6627 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6629 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6631 * image.c: Various fixes to ImageMagick code comments.
6632 (Fimagemagick_types): Doc fix.
6634 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6636 Minor fixes prompted by GCC 4.6.0 warnings.
6638 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6640 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6641 (x_clipboard_manager_save_all): Move extern decl to ...
6642 * xterm.h: ... here, so that it can be checked for consistency.
6644 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6646 * xselect.c (x_clipboard_manager_save_frame)
6647 (x_clipboard_manager_save_all): New functions.
6648 (Fx_clipboard_manager_save): Lisp function deleted.
6650 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6651 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6653 * xterm.h: Update prototype.
6655 2011-05-28 William Xu <william.xwl@gmail.com>
6657 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6660 2011-05-28 Jim Meyering <meyering@redhat.com>
6662 Avoid a sign-extension bug in crypto_hash_function.
6663 * fns.c (to_uchar): Define.
6664 (crypto_hash_function): Use it to convert some newly-signed
6665 variables to unsigned, to avoid sign-extension bugs. For example,
6666 without this change, (md5 "truc") would evaluate to
6667 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6668 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6669 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6671 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6673 Integer overflow fixes.
6675 * dbusbind.c: Serial number integer overflow fixes.
6676 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6677 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6678 to hold a serial number that is too large for a fixnum.
6679 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6680 Check for serial numbers out of range. Decode any serial number
6681 that was so large that it became a float. (Bug#8722)
6683 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6684 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6685 Use XFASTINT rather than XUINT when numbers are nonnegative.
6686 (xd_append_arg, Fdbus_method_return_internal):
6687 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6688 arguments, check that Lisp number is nonnegative, rather than
6689 silently wrapping negative numbers around. (Bug#8722)
6690 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6693 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6695 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6697 ccl: Add integer overflow checks.
6698 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6699 (IN_INT_RANGE): New macros.
6700 (ccl_driver): Use them to check for integer overflow when
6701 decoding a CCL program. Many of the new checks are whether XINT (x)
6702 fits in int; it doesn't always, on 64-bit hosts. The new version
6703 doesn't catch all possible integer overflows, but it's an
6704 improvement. (Bug#8719)
6706 * alloc.c (make_event_array): Use XINT, not XUINT.
6707 There's no need for unsigned here.
6709 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6710 This follows up to the 2011-05-06 change that substituted uintptr_t
6711 for EMACS_INT. This case wasn't caught back then.
6713 Rework Fformat to avoid integer overflow issues.
6714 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6715 now (part of C89). Include <verify.h>.
6716 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6717 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6718 (Fformat): Avoid the prepass trying to compute sizes; it was only
6719 approximate and thus did not catch overflow reliably. Instead, walk
6720 through the format just once, formatting and computing sizes as we go,
6721 checking for integer overflow at every step, and allocating a larger
6722 buffer as needed. Keep track separately whether the format is
6723 multibyte. Keep only the most-recently calculated precision, rather
6724 than them all. Record whether each argument has been converted to
6725 string. Use EMACS_INT, not int, for byte and char and arg counts.
6726 Support field widths and precisions larger than INT_MAX. Avoid
6727 sprintf's undefined behavior with conversion specifications such as %#d
6728 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6729 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6730 formatting out-of-range floating point numbers with int
6733 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6735 * data.c: Avoid integer truncation in expressions involving floats.
6736 * data.c: Include <intprops.h>.
6737 (arith_driver): When there's an integer overflow in an expression
6738 involving floating point, convert the integers to floating point
6739 so that the resulting value does not suffer from catastrophic
6740 integer truncation. For example, on a 64-bit host (* 4
6741 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6742 Do not rely on undefined behavior after integer overflow.
6744 merge count_size_as_multibyte, parse_str_to_multibyte
6745 * character.c, character.h (count_size_as_multibyte):
6746 Rename from parse_str_to_multibyte; all uses changed.
6747 Check for integer overflow.
6748 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6749 since it's now a duplicate of the other. This is more of
6750 a character than a buffer op, so better that it's in character.c.
6751 * fns.c, print.c: Adjust to above changes.
6753 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6755 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6757 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6759 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6760 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6761 (x_clipboard_manager_save): Now static.
6762 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6764 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6765 (crypto_hash_function): Now static.
6766 Fix pointer signedness problems. Avoid unnecessary initializations.
6768 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6770 * termhooks.h (Vselection_alist): Make it terminal-local.
6772 * terminal.c (create_terminal): Initialize it.
6774 * xselect.c: Support for clipboard managers.
6775 (Vselection_alist): Move to termhooks.h as terminal-local var.
6776 (LOCAL_SELECTION): New macro.
6777 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6778 (symbol_to_x_atom): Remove gratuitous arg.
6779 (x_handle_selection_request, lisp_data_to_selection_data)
6780 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6781 (x_own_selection, x_get_local_selection, x_convert_selection):
6782 New arg, specifying work frame. Use terminal-local Vselection_alist.
6783 (some_frame_on_display): Delete unused function.
6784 (Fx_own_selection_internal, Fx_get_selection_internal)
6785 (Fx_disown_selection_internal, Fx_selection_owner_p)
6786 (Fx_selection_exists_p): New optional frame arg.
6787 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6788 (x_handle_selection_clear): Don't treat other terminals with the
6789 same keyboard specially. Use the terminal-local Vselection_alist.
6790 (x_clear_frame_selections): Use Frun_hook_with_args.
6792 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6794 * xterm.h: Add support for those atoms.
6796 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6798 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6799 (converted_selections, conversion_fail_tag): New global variables.
6800 (x_selection_request_lisp_error): Free the above.
6801 (x_get_local_selection): Remove unnecessary code.
6802 (x_reply_selection_request): Args changed; handle arbitrary array
6803 of converted selections stored in converted_selections.
6804 Separate the XChangeProperty and SelectionNotify steps.
6805 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6806 (x_convert_selection): New function.
6807 (x_handle_selection_event): Simplify.
6808 (x_get_foreign_selection): Don't ignore incoming requests while
6809 waiting for an answer; this will fail when we implement
6810 SAVE_TARGETS, and seems unnecessary anyway.
6811 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6812 (Vx_sent_selection_functions): Doc fix.
6814 2011-05-26 Leo Liu <sdl.web@gmail.com>
6816 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6818 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6820 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6822 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6823 for fringe update if it has periodic bitmap.
6824 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6825 and fringe_bitmap_periodic_p.
6827 * fringe.c (get_fringe_bitmap_data): New function.
6828 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6829 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6830 row. Mark glyph row for fringe update if periodicity changed.
6832 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6833 for fringe update unless it has periodic bitmap.
6835 2011-05-25 Kenichi Handa <handa@m17n.org>
6837 * xdisp.c (get_next_display_element): Set correct it->face_id for
6838 a static composition.
6840 2011-05-24 Leo Liu <sdl.web@gmail.com>
6843 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6845 * fns.c (crypto_hash_function, Fsha1): New function.
6846 (Fmd5): Use crypto_hash_function.
6847 (syms_of_fns): Add Ssha1.
6849 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6851 * gnutls.c: Remove unused macros.
6852 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6853 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6854 Remove macros that are defined and never used.
6855 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6857 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6859 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6860 (Fx_get_selection_internal): Minor cleanup.
6861 (Fx_own_selection_internal): Rename arguments for consistency with
6864 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6866 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6868 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6870 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6872 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6874 * dispnew.c (scrolling_window): Don't exclude the case that the
6875 last enabled row in the desired matrix touches the bottom boundary.
6877 2011-05-21 Glenn Morris <rgm@gnu.org>
6879 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6880 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6881 and add some more files.
6883 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6885 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6886 report_file_error introduced by the change from 2011-05-07.
6888 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6890 * systime.h (Time): Define only if emacs is defined.
6891 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6892 where the include path doesn't have X11/X.h by default. See
6893 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6895 2011-05-20 Kenichi Handa <handa@m17n.org>
6897 * composite.c (find_automatic_composition): Fix previous change.
6899 2011-05-20 Glenn Morris <rgm@gnu.org>
6901 * lisp.mk: New file, split from Makefile.in.
6902 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6903 (shortlisp): Remove.
6904 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6906 2011-05-19 Glenn Morris <rgm@gnu.org>
6908 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6909 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6910 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6911 (lisp): Set the order to that of loadup.el.
6912 (shortlisp): Make it a copy of $lisp.
6913 (SOME_MACHINE_LISP): Remove.
6914 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6915 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6917 2011-05-18 Kenichi Handa <handa@m17n.org>
6919 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6920 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6921 (find_automatic_composition): Mostly rewrite for efficiency.
6923 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6925 * makefile.w32-in: Update dependencies.
6927 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6929 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6930 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6932 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6934 Fix some integer overflow issues, such as string length overflow.
6936 * insdel.c (count_size_as_multibyte): Check for string overflow.
6938 * character.c (lisp_string_width): Check for string overflow.
6939 Use EMACS_INT, not int, for string indexes and lengths; in
6940 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6941 the resulting string length overflows an EMACS_INT; instead,
6942 report a string overflow if no precision given. When checking for
6943 precision exhaustion, use a check that cannot possibly have
6944 integer overflow. (Bug#8675)
6945 * character.h (lisp_string_width): Adjust to new signature.
6947 * alloc.c (string_overflow): New function.
6948 (Fmake_string): Use it. This doesn't change behavior, but saves
6949 a few bytes and will simplify future changes.
6950 * character.c (string_escape_byte8): Likewise.
6951 * lisp.h (string_overflow): New decl.
6953 Fixups, following up to the user-interface timestamp change.
6954 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6955 for UI timestamps, instead of unsigned long.
6956 * msdos.c (mouse_get_pos): Likewise.
6957 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6958 * w32gui.h (Time): Define by including "systime.h" rather than by
6959 declaring it ourselves. (Bug#8664)
6961 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6962 * image.c (clear_image_cache): Likewise.
6964 * term.c (term_mouse_position): Don't assume time_t wraparound.
6966 Be more systematic about user-interface timestamps.
6967 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6968 and sometimes 'EMACS_UINT', to represent these timestamps.
6969 This change causes it to use 'Time' uniformly, as that's what X uses.
6970 This makes the code easier to follow, and makes it easier to catch
6971 integer overflow bugs such as Bug#8664.
6972 * frame.c (Fmouse_position, Fmouse_pixel_position):
6973 Use Time, not unsigned long, for user-interface timestamps.
6974 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6975 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6976 * keyboard.h (last_event_timestamp): Likewise.
6977 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6978 * menu.h (xmenu_show): Likewise.
6979 * term.c (term_mouse_position): Likewise.
6980 * termhooks.h (struct input_event.timestamp): Likewise.
6981 (struct terminal.mouse_position_hook): Likewise.
6982 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6983 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6984 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6985 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6987 * menu.h, termhooks.h: Include "systime.h", for Time.
6989 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6990 Don't assume that the difference between two unsigned long values
6991 can fit into an integer. At this point, we know button_down_time
6992 <= event->timestamp, so the difference must be nonnegative, so
6993 there's no need to cast the result if double-click-time is
6994 nonnegative, as it should be; check that it's nonnegative, just in
6995 case. This bug is triggered when events are more than 2**31 ms
6996 apart (about 25 days). (Bug#8664)
6998 * xselect.c (last_event_timestamp): Remove duplicate decl.
6999 (x_own_selection): Remove needless cast to unsigned long.
7001 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
7002 that always fit in int. Use a sentinel instead of a counter, to
7003 avoid a temp and to allay GCC's concerns about possible int overflow.
7004 * frame.h (struct frame): Use int for menu_bar_items_used
7005 instead of EMACS_INT, since it always fits in int.
7007 * menu.c (grow_menu_items): Check for int overflow.
7009 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
7011 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
7012 Before, the code was not consistent. These values cannot exceed
7013 2**31 - 1 so there's no need to make them unsigned.
7014 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
7015 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
7016 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
7018 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
7020 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
7021 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
7022 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
7023 presumably because the widths might not match.
7025 * window.c (size_window): Avoid needless test at loop start.
7027 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
7029 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
7031 2011-05-12 Drew Adams <drew.adams@oracle.com>
7033 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
7035 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7037 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
7038 `width' to `bar_area_x' and `bar_area_width', respectively.
7039 (x_scroll_run): Take account of fringe background extension.
7041 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
7042 Rename local vars `left' and `width' to `bar_area_x' and
7043 `bar_area_width', respectively.
7044 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
7045 background extension.
7047 2011-05-10 Jim Meyering <meyering@redhat.com>
7049 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
7051 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
7053 * image.c (Finit_image_library): Return t for built-in image types,
7054 like pbm and xbm. (Bug#8640)
7056 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
7058 * w32menu.c (set_frame_menubar): Fix submenu allocation.
7060 2011-05-07 Eli Zaretskii <eliz@gnu.org>
7062 * w32console.c (Fset_screen_color): Doc fix.
7063 (Fget_screen_color): New function.
7064 (syms_of_ntterm): Defsubr it.
7066 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
7067 unlink the temporary file if Fcall_process didn't create it in the
7069 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
7070 child process will be redirected to a file specified with `:file'.
7071 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
7072 cue to call_process_cleanup not to close that handle.
7074 2011-05-07 Ben Key <bkey76@gmail.com>
7076 * makefile.w32-in: The bootstrap-temacs rule now makes use of
7077 one of two shell specific rules, either bootstrap-temacs-CMD or
7078 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
7079 to the previous implementation of the bootstrap-temacs rule.
7080 The bootstrap-temacs-CMD rule is similar to the previous
7081 implementation of the bootstrap-temacs rule except that it
7082 makes use of the ESC_CFLAGS variable instead of the CFLAGS
7085 These changes, along with some changes to nt/configure.bat,
7086 nt/gmake.defs, and nt/nmake.defs, are required to extend my
7087 earlier fix to add support for --cflags and --ldflags options
7088 that include quotes so that it works whether make uses cmd or
7091 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
7093 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
7094 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
7096 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
7097 a string. Handle both cases.
7098 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
7099 (Fdbus_register_method): Use Qinvalid_function.
7101 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7103 * makefile.w32-in: Update dependencies.
7104 (LISP_H): Add inttypes.h and stdin.h.
7105 (PROCESS_H): Add unistd.h.
7107 2011-05-06 Eli Zaretskii <eliz@gnu.org>
7109 * lread.c: Include limits.h (fixes the MS-Windows build broken by
7110 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
7112 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
7114 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
7116 * term.c (vfatal): Remove stray call to va_end.
7117 It's not needed and the C Standard doesn't allow it here anyway.
7119 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
7120 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
7122 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
7125 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
7127 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7129 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
7131 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
7133 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
7135 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
7136 * charset.c (Fdefine_charset_internal): Don't initialize
7137 charset.code_space[15]. The value was garbage, on hosts with
7138 32-bit int (Bug#8600).
7140 * lread.c (read_integer): Be more consistent with string-to-number.
7141 Use string_to_number to do the actual conversion; this avoids
7142 rounding errors and fixes some other screwups. Without this fix,
7143 for example, #x1fffffffffffffff was misread as -2305843009213693952.
7144 (digit_to_number): Move earlier, for benefit of read_integer.
7145 Return -1 if the digit is out of range for the base, -2 if it is
7146 not a digit in any supported base. (Bug#8602)
7148 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
7150 * dispnew.c (scrolling_window): Return 1 if we scrolled,
7151 to match comment at start of function. This also removes a
7152 GCC warning about overflow in a 32+64-bit port.
7154 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
7156 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
7157 Reported by Stefan Monnier in
7158 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
7159 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7160 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
7162 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
7163 (EMACS_UINTPTR): Likewise, with uintptr_t.
7165 * lisp.h: Prefer 64-bit EMACS_INT if available.
7166 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
7167 on 32-bit hosts that have 64-bit int, so that they can access
7169 However, temporarily disable this change unless the temporary
7170 symbol WIDE_EMACS_INT is defined.
7172 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
7174 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
7175 This removes an assumption that EMACS_INT and long are the same
7176 width as pointers. The assumption is true for Emacs porting targets
7177 now, but we want to make other targets possible.
7178 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
7179 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
7180 In the rest of the code, change types of integers that hold casted
7181 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
7182 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
7183 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
7184 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
7185 No need to cast type when ORing.
7186 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
7187 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
7188 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
7189 assume EMACS_INT is the same width as char *.
7190 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
7191 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
7192 Remove no-longer-needed casts.
7193 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
7194 (xg_tool_bar_help_callback, xg_make_tool_item):
7195 Use EMACS_INTPTR to hold an integer
7196 that will be cast to void *; this can avoid a GCC warning
7197 if EMACS_INT is not the same width as void *.
7198 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
7199 * xdisp.c (display_echo_area_1, resize_mini_window_1):
7200 (current_message_1, set_message_1):
7201 Use a local to convert to proper width without a cast.
7202 * xmenu.c (dialog_selection_callback): Likewise.
7204 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
7205 Also, don't assume VALBITS / RAND_BITS is less than 5,
7206 and don't rely on undefined behavior when shifting a 1 left into
7208 * lisp.h (get_random): Change signature to match.
7210 * lread.c (hash_string): Use size_t, not int, for hash computation.
7211 Normally we prefer signed values; but hashing is special, because
7212 it's better to use unsigned division on hash table sizes so that
7213 the remainder is nonnegative. Also, size_t is the natural width
7214 for hashing into memory. The previous code used 'int', which doesn't
7215 retain enough info to hash well into very large tables.
7216 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
7218 * dbusbind.c: Don't possibly lose pointer info when converting.
7219 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7220 Use XPNTR rather than XHASH, so that the high-order bits of
7221 the pointer aren't lost when converting through void *.
7223 * eval.c (Fautoload): Don't double-shift a pointer.
7225 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
7227 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7229 * gnutls.c (DEF_GNUTLS_FN):
7230 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7232 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7234 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7237 2011-05-05 Eli Zaretskii <eliz@gnu.org>
7239 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7240 New version that can reserve upto 2GB of heap space.
7242 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
7244 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7246 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7248 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7249 `gnutls_certificate_set_x509_key_file'.
7251 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
7253 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7254 Update dependencies.
7256 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7258 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7259 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7260 Remove unused parameter `fildes'.
7261 * process.c (read_process_output, send_process): Don't pass it.
7263 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7265 Fix previous change: the library cache is defined in w32.c.
7266 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7267 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7269 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7271 Implement dynamic loading of GnuTLS on Windows.
7273 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7274 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7275 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7278 * gnutls.c (Qgnutls_dll): Define.
7279 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7280 (gnutls_*): Declare function pointers.
7281 (init_gnutls_functions): New function to initialize function pointers.
7282 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7283 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7284 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7285 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7286 (emacs_gnutls_write, emacs_gnutls_read)
7287 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7288 (Fgnutls_available_p): New function.
7289 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7290 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7291 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7293 * image.c: Include w32.h.
7294 (Vimage_type_cache): Delete.
7295 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7296 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7297 (w32_delayed_load): Move to w32.c.
7299 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7301 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7302 (w32_delayed_load): Move from image.c. When loading a library, record
7303 its filename in the :loaded-from property of the library id.
7304 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7305 Initialize and staticpro them.
7306 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7308 * process.c: Include lisp.h before w32.h, not after.
7309 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7310 instead of gnutls_record_check_pending.
7312 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7314 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7316 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7317 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7320 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7322 * xterm.c (x_set_frame_alpha): Do not set property on anything
7323 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7325 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7327 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7329 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7331 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7332 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7333 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7334 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7335 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7336 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7337 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7338 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7339 (Qgnutls_bootprop_callbacks_verify): Make static.
7341 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7343 * callproc.c: Indentation fixup.
7345 * sysdep.c (wait_for_termination_1): Make static.
7346 (wait_for_termination, interruptible_wait_for_termination):
7347 Move after wait_for_termination_1.
7349 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7351 * sysdep.c (interruptible_wait_for_termination): New function
7352 which is like wait_for_termination, but allows keyboard
7355 * callproc.c (Fcall_process): Add (:file "file") as an option for
7357 (Fcall_process_region): Ditto.
7359 2011-04-30 Eli Zaretskii <eliz@gnu.org>
7361 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7362 rather than `XVECTOR (FOO)->size'.
7364 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7365 inttypes.h, as a gnulib replacement is used if it not available in
7368 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7370 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7371 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7372 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7374 * coding.c (coding_alloc_by_realloc): Error out if destination
7375 will grow beyond MOST_POSITIVE_FIXNUM.
7376 (decode_coding_emacs_mule): Abort if there isn't enough place in
7377 charbuf for the composition carryover bytes. Reserve an extra
7378 space for up to 2 characters produced in a loop.
7379 (decode_coding_iso_2022): Abort if there isn't enough place in
7380 charbuf for the composition carryover bytes.
7382 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7384 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7385 aborting when %lld or %lll format is passed.
7386 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7387 %llo or %llx format is passed. (Bug#8545)
7389 * window.c (window_scroll_line_based): Use a marker instead of
7390 simple variables to record original value of point. (Bug#7952)
7392 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7393 produced by %s or %c overflows available buffer space. (Bug#8545)
7395 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7397 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7398 (SIZE_MAX): Move defn after all includes, as they might #define it.
7400 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7402 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7404 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7406 * keyboard.c (Qdelayed_warnings_hook): Define.
7407 (command_loop_1): Run `delayed-warnings-hook'
7408 if Vdelayed_warnings_list is non-nil.
7409 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7410 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7412 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7414 * doprnt.c (doprnt): Don't return value smaller than the buffer
7415 size if the message was truncated. (Bug#8545).
7417 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7419 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7420 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7422 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7424 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7426 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7428 * makefile.w32-in: Update dependencies.
7430 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7432 Improve `doprnt' and its usage. (Bug#8545)
7433 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7434 `format_end'. Remove support for %l as a conversion specifier.
7435 Don't use xrealloc. Improve diagnostics when the %l size modifier
7436 is used. Update the commentary.
7438 * eval.c (verror): Simplify calculation of size_t.
7440 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7443 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7445 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7448 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7450 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7451 This makes this file independent of the recent pseudovector change.
7453 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7455 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7457 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7458 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7459 Remove unused local.
7460 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7462 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7463 GCC 4.6.0 optimizes based on type-based alias analysis.
7464 For example, if b is of type struct buffer * and v of type struct
7465 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7466 != &v->size, and therefore "v->size = 1; b->size = 2; return
7467 v->size;" must therefore return 1. This assumption is incorrect
7468 for Emacs, since it type-puns struct Lisp_Vector * with many other
7469 types. To fix this problem, this patch adds a new type struct
7470 vectorlike_header that documents the constraints on layout of vectors
7471 and pseudovectors, and helps optimizing compilers not get fooled
7472 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7473 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7474 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7476 (XSETPVECTYPE): Rewrite in terms of new macro.
7477 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7478 This is a bit clearer, and further avoids the possibility of
7479 undesirable aliasing.
7480 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7481 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7482 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7483 since Lisp_Subr is a special case (no "next" field).
7484 (ASIZE): Now uses header.size rather than size.
7485 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7486 to avoid the hassle of writing XVECTOR (foo)->header.size.
7487 (struct vectorlike_header): New type.
7488 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7489 object, to help avoid aliasing.
7490 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7491 (SUBRP): Likewise, since Lisp_Subr is a special case.
7492 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7493 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7494 (struct Lisp_Hash_Table): Combine first two members into a single
7495 struct vectorlike_header member. All uses of "size" and "next" members
7496 changed to be "header.size" and "header.next".
7497 * buffer.h (struct buffer): Likewise.
7498 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7499 * frame.h (struct frame): Likewise.
7500 * process.h (struct Lisp_Process): Likewise.
7501 * termhooks.h (struct terminal): Likewise.
7502 * window.c (struct save_window_data, struct saved_window): Likewise.
7503 * window.h (struct window): Likewise.
7504 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7505 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7506 * buffer.c (init_buffer_once): Likewise.
7507 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7509 * process.c (Fformat_network_address): Use local var for size,
7512 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7514 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7515 * data.c (atof): Remove decl; no longer used or needed.
7516 (digit_to_number): Move to lread.c.
7517 (Fstring_to_number): Use new string_to_number function, to be
7518 consistent with how the Lisp reader treats infinities and NaNs.
7519 Do not assume that floating-point numbers represent EMACS_INT
7520 without losing information; this is not true on most 64-bit hosts.
7521 Avoid double-rounding errors, by insisting on integers when
7522 parsing non-base-10 numbers, as the documentation specifies.
7523 * lisp.h (string_to_number): New decl, replacing ...
7524 (isfloat_string): Remove.
7525 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7526 (read1): Do not accept +. and -. as integers; this
7527 appears to have been a coding error. Similarly, do not accept
7528 strings like +-1e0 as floating point numbers. Do not report
7529 overflow for integer overflows unless the base is not 10 which
7530 means we have no simple and reliable way to continue.
7531 Break out the floating-point parsing into a new
7532 function string_to_number, so that Fstring_to_number parses
7533 floating point numbers consistently with the Lisp reader.
7534 (digit_to_number): Move here from data.c. Make it static inline.
7535 (E_CHAR, EXP_INT): Remove, replacing with ...
7536 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7537 (string_to_number): New function, replacing isfloat_string.
7538 This function checks for valid syntax and produces the resulting
7539 Lisp float number too. Rework it so that string-to-number
7540 no longer mishandles examples like "1.0e+". Use strtoumax,
7541 so that overflow for non-base-10 numbers is reported only when
7542 there's no portable and simple way to convert to floating point.
7544 * textprop.c (set_text_properties_1): Rewrite for clarity,
7545 and to avoid GCC warning about integer overflow.
7547 * intervals.h (struct interval): Use EMACS_INT for members
7548 where EMACS_UINT might cause problems. See
7549 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7550 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7551 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7553 (offset_intervals): Tell GCC not to worry about length overflow
7554 when negating a negative length.
7556 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7557 (overrun_check_free): Likewise.
7559 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7560 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7563 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7564 (gnutls_make_error): Rename local to avoid shadowing.
7565 (gnutls_emacs_global_deinit): ifdef out; not used.
7566 (Fgnutls_boot): Use const for pointer to readonly storage.
7567 Comment out unused local. Fix pointer signedness problems.
7569 * lread.c (openp): Don't stuff size_t into an 'int'.
7570 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7571 about possible signed overflow.
7573 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7574 (GDK_KEY_g): Don't define if already defined.
7575 (xg_prepare_tooltip): Avoid pointer signedness problem.
7576 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7578 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7579 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7581 * xfns.c (Fx_window_property): Simplify a bit,
7582 to make a bit faster and to avoid GCC 4.6.0 warning.
7583 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7585 * fns.c (internal_equal): Don't assume size_t fits in int.
7587 * alloc.c (compact_small_strings): Tighten assertion a little.
7589 Replace pEd with more-general pI, and fix some printf arg casts.
7590 * lisp.h (pI): New macro, generalizing old pEd macro to other
7591 conversion specifiers. For example, use "...%"pI"d..." rather
7592 than "...%"pEd"...".
7593 (pEd): Remove. All uses replaced with similar uses of pI.
7594 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7595 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7596 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7597 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7598 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7599 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7600 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7602 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7603 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7604 * print.c (safe_debug_print, print_object): Likewise.
7605 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7607 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7608 avoiding the 0 flag, which is not portable.
7609 * process.c (Fmake_network_process): Use pI to avoid cast.
7610 * region-cache.c (pp_cache): Likewise.
7611 * xdisp.c (decode_mode_spec): Likewise.
7612 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7613 behavior on 64-bit hosts with printf arg.
7614 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7615 (x_stop_queuing_selection_requests): Likewise.
7616 (x_get_window_property): Don't truncate byte count to an 'int'
7619 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7620 here, since it parses constructs like leading '-' and spaces,
7621 which are not wanted; and it overflows with large numbers.
7622 Instead, simply match F[0-9]+, which is what is wanted anyway.
7624 * alloc.c: Remove unportable assumptions about struct layout.
7625 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7626 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7627 (allocate_vectorlike, make_pure_vector): Use the new macros,
7628 plus offsetof, to remove unportable assumptions about struct layout.
7629 These assumptions hold on all porting targets that I know of, but
7630 they are not guaranteed, they're easy to remove, and removing them
7631 makes further changes easier.
7633 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7634 This doesn't fix a bug but makes the code clearer.
7635 (string_overrun_cookie): Now const. Use initializers that
7636 don't formally overflow signed char, to avoid warnings.
7637 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7638 can cause Emacs to crash when string overrun checking is enabled.
7639 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7640 multiple of sizeof (EMACS_INT); it need not be, if
7641 alignof(EMACS_INT) < sizeof (EMACS_INT).
7642 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7644 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7646 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7648 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7650 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7651 supposed to be handshaking. (Bug#8556)
7652 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7654 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7656 * lisp.h (Qdebug): List symbol.
7657 * eval.c (Qdebug): Restore global linkage.
7658 * keyboard.c (debug-on-event): New variable.
7659 (handle_user_signal): Break into debugger when debug-on-event
7660 matches the current signal symbol.
7662 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7664 * alloc.c (check_sblock, check_string_bytes)
7665 (check_string_free_list): Convert to standard C.
7667 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7669 * w32.c (emacs_gnutls_push): Fix typo.
7671 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7673 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7674 "cast to pointer from integer of different size".
7676 Improve doprnt and its use in verror. (Bug#8545)
7677 * doprnt.c (doprnt): Document the set of format control sequences
7678 supported by the function. Use SAFE_ALLOCA instead of always
7681 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7682 is one byte too soon. Don't use xrealloc; instead xfree and
7685 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7687 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7690 * gnutls.c: Renamed global_initialized to
7691 gnutls_global_initialized. Added internals for the
7692 :verify-hostname-error, :verify-error, and :verify-flags
7693 parameters of `gnutls-boot' and documented those parameters in the
7694 docstring. Start callback support.
7695 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7696 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7697 on error. Return error code.
7698 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7699 (emacs_gnutls_read): Likewise.
7700 (Fgnutls_boot): Return handshake error code.
7701 (emacs_gnutls_handle_error): New function.
7702 (wsaerror_to_errno): Likewise.
7704 * w32.h (emacs_gnutls_pull): Add prototype.
7705 (emacs_gnutls_push): Likewise.
7707 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7708 (emacs_gnutls_push): Likewise.
7710 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7712 * process.c (wait_reading_process_output): Check if GnuTLS
7713 buffered some data internally if no FDs are set for TLS
7716 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7717 (LIBS): Link to USER_LIBS.
7718 ($(BLD)/gnutls.$(0)): New target.
7720 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7722 * xdisp.c (handle_single_display_spec): Rename the
7723 display_replaced_before_p argument into display_replaced_p, to
7724 make it consistent with the commentary. Fix typos in the
7727 * textprop.c (syms_of_textprop): Remove dead code.
7728 (copy_text_properties): Delete obsolete commentary about an
7729 interface that was deleted long ago. Fix typos in the description
7732 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7733 to changes in oldXMenu/XMenu.h from 2011-04-16.
7734 <menu_help_message, prev_menu_help_message>: Constify.
7735 (IT_menu_make_room): menu->help_text is now `const char **';
7738 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7739 to changes in oldXMenu/XMenu.h from 2011-04-16.
7740 (struct XMenu): Declare `help_text' `const char **'.
7742 * xfaces.c <Qunspecified>: Make extern again.
7744 * syntax.c: Include sys/types.h before including regex.h, as
7747 * doc.c (get_doc_string): Improve the format passed to `error'.
7749 * doprnt.c (doprnt): Improve commentary.
7751 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7753 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7756 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7757 changes in globals.h immediately force recompilation.
7758 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7759 $(CURDIR)/s/ms-w32.h.
7760 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7762 * character.c (Fchar_direction): Function deleted.
7763 (syms_of_character): Don't defsubr it.
7764 <char-direction-table>: Deleted.
7766 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7768 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7769 * doprnt.c: Include limits.h.
7770 (SIZE_MAX): New macro.
7771 (doprnt): Return a size_t value. 2nd arg is now size_t.
7772 Many local variables are now size_t instead of int or unsigned.
7773 Improve overflow protection. Support `l' modifier for integer
7774 conversions. Support %l conversion. Don't assume an EMACS_INT
7775 argument for integer conversions and for %c.
7777 * lisp.h (doprnt): Restore prototype.
7779 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7782 * Makefile.in (base_obj): Add back doprnt.o.
7784 * deps.mk (doprnt.o): Add back prerequisites.
7785 (callint.o): Depend on character.h.
7787 * eval.c (internal_lisp_condition_case): Include the handler
7788 representation in the error message.
7789 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7790 when breaking from the loop.
7792 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7794 * callint.c (Fcall_interactively): When displaying error message
7795 about invalid control letter, pass the character's codepoint, not
7796 a pointer to its multibyte form. Improve display of the character
7797 in octal and display also its hex code.
7799 * character.c (char_string): Use %x to display the (unsigned)
7800 codepoint of an invalid character, to avoid displaying a bogus
7803 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7804 `error', not SYMBOL_NAME itself.
7806 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7807 character arguments to `error'.
7809 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7810 to `error' in error message about FINAL_CHAR argument. Make sure
7811 FINAL_CHAR is a character, and use %c when it is passed as
7812 argument to `error'.
7814 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7816 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7818 * w32.c: Include <time.h>.
7819 (sys_localtime): New function.
7821 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7823 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7825 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7827 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7829 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7832 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7834 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7835 gl_state.e_property when gl_state.object is Qt.
7837 * insdel.c (make_gap_larger): Remove limitation of buffer size
7840 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7842 * xdisp.c (lookup_glyphless_char_display)
7843 (produce_glyphless_glyph): Handle cons cell entry in
7844 glyphless-char-display.
7845 (Vglyphless_char_display): Document it.
7847 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7848 glyphless-char-display.
7850 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7852 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7854 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7856 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7857 definition for no-X builds.
7859 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7861 Static checks with GCC 4.6.0 and non-default toolkits.
7863 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7865 * process.c (keyboard_bit_set): Define only if SIGIO.
7866 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7867 (send_process): Repair possible setjmp clobbering.
7869 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7871 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7873 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7875 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7876 Define only if needed.
7878 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7879 by pacifying GCC about it. Maybe it's time to retire it?
7880 * xfaces.c (USG, __TIMEVAL__): Likewise.
7882 * dispextern.h (struct redisplay_interface): Rename param
7884 * termhooks.h (struct terminal): Likewise.
7885 * xterm.c (xembed_send_message): Likewise.
7887 * insdel.c (make_gap_smaller): Define only if
7888 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7890 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7893 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7894 so that we aren't warned about unused symbols.
7896 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7898 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7900 * xfns.c (x_real_positions): Mark locals as initialized.
7902 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7904 * xterm.c: Fix problems found by static analysis with other toolkits.
7905 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7906 (x_dispatch_event): Declare static if USE_GTK, and
7907 define if USE_GTK || USE_X_TOOLKIT.
7908 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7909 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7910 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7911 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7913 * xmenu.c (menu_help_callback): Pointer type fixes.
7914 Use const pointers when pointing at readonly data. Avoid pointer
7916 (FALSE): Remove unused macro.
7917 (update_frame_menubar): Remove unused decl.
7919 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7921 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7922 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7923 (single_menu_item): Rename local to avoid shadowing.
7925 * keyboard.c (make_lispy_event): Remove unused local var.
7927 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7928 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7930 * bitmaps: Change bitmaps from unsigned char back to the X11
7931 compatible char. Avoid the old compiler warnings about
7932 out-of-range initializers by using, for example, '\xab' rather
7935 * xgselect.c (xgselect_initialize): Check vs interface
7936 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7938 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7940 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7941 to read-only memory.
7943 * fns.c (vector): Remove; this old hack is no longer needed.
7945 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7947 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7949 * xrdb.c (x_load_resources): Omit unused local.
7951 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7952 (x_window): Rename locals to avoid shadowing.
7953 (USG): Use the kludged USG macro, to pacify gcc.
7955 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7956 (x_term_init): Remove local to avoid shadowing.
7958 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7960 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7961 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7963 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7965 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7967 Fix regex.c, syntax.c and friends for buffers > 2GB.
7968 * syntax.h (struct gl_state_s): Declare character position members
7971 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7973 * textprop.c (verify_interval_modification, interval_of):
7974 Declare arguments EMACS_INT.
7976 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7979 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7981 * indent.c (Fvertical_motion): Local variable it_start is now
7984 * regex.c (re_match, re_match_2, re_match_2_internal)
7985 (bcmp_translate, regcomp, regexec, print_double_string)
7986 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7987 (re_compile_pattern, re_exec): Declare arguments and local
7988 variables `size_t' and `ssize_t' and return values `regoff_t', as
7990 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7991 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7992 <compile_stack_type>: `size' and `avail' are now `size_t'.
7994 * regex.h <regoff_t>: Use ssize_t, not int.
7995 (re_search, re_search_2, re_match, re_match_2): Arguments that
7996 specify buffer/string position and length are now ssize_t and
7997 size_t. Return type is regoff_t.
7999 2011-04-16 Ben Key <bkey76@gmail.com>
8001 * nsfont.m: Fixed bugs in ns_get_family and
8002 ns_descriptor_to_entity that were caused by using free to
8003 deallocate memory blocks that were allocated by xmalloc (via
8004 xstrdup). This caused Emacs to crash when compiled with
8005 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
8006 --enable-checking=xmallocoverrun). xfree is now used to
8007 deallocate these memory blocks.
8009 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
8011 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
8013 emacs_write: Accept and return EMACS_INT for sizes.
8014 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
8016 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
8017 Accept and return EMACS_INT.
8018 (emacs_gnutls_write): Return the number of bytes written on
8020 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
8021 (emacs_read, emacs_write): Remove check for negative size, as the
8022 Emacs source code has been audited now.
8023 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
8024 (emacs_read, emacs_write): Use it.
8025 * process.c (send_process): Adjust to the new signatures of
8026 emacs_write and emacs_gnutls_write. Do not attempt to store
8027 a byte offset into an 'int'; it might overflow.
8028 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
8030 * sound.c: Don't assume sizes fit in 'int'.
8031 (struct sound_device.period_size, alsa_period_size):
8032 Return EMACS_INT, not int.
8033 (struct sound_device.write, vox_write, alsa_write):
8034 Accept EMACS_INT, not int.
8035 (wav_play, au_play): Use EMACS_INT to store sizes and to
8036 record read return values.
8038 2011-04-15 Ben Key <bkey76@gmail.com>
8040 * keyboard.c (Qundefined): Don't declare static since it is used
8042 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
8043 static since they are used in nsfont.m.
8045 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
8047 * process.c (Qprocessp): Don't declare static.
8048 * lisp.h (Qprocessp): Declare again.
8050 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
8052 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
8054 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
8056 Improve C-level modularity by making more things 'static'.
8058 Don't publish debugger-only interfaces to other modules.
8059 * lisp.h (safe_debug_print, debug_output_compilation_hack):
8060 (verify_bytepos, count_markers): Move decls to the only modules
8062 * region-cache.h (pp_cache): Likewise.
8063 * window.h (check_all_windows): Likewise.
8064 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
8066 * sysdep.c (croak): Now static, if
8067 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
8068 * syssignal.h (croak): Declare only if not static.
8070 * alloc.c (refill_memory_reserve): Now static if
8071 !defined REL_ALLOC || defined SYSTEM_MALLOC.
8072 * lisp.h (refill_memory_reserve): Declare only if not static.
8074 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
8075 Define only if USE_LUCID.
8077 * xrdb.c (x_customization_string, x_rm_string): Now static.
8079 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
8080 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
8082 * xdisp.c (draw_row_with_mouse_face): Now static.
8083 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
8085 * window.h (check_all_windows): Mark externally visible.
8087 * window.c (window_deletion_count): Now static.
8089 * undo.c: Make symbols static if they're not exported.
8090 (last_undo_buffer, last_boundary_position, pending_boundary):
8093 * textprop.c (interval_insert_behind_hooks): Now static.
8094 (interval_insert_in_front_hooks): Likewise.
8096 * term.c: Make symbols static if they're not exported.
8097 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
8098 (max_frame_lines, tty_set_terminal_modes):
8099 (tty_reset_terminal_modes, tty_turn_off_highlight):
8100 (get_tty_terminal): Now static.
8101 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
8102 * termhooks.h (term_mouse_moveto): Do not declare if
8104 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
8105 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
8107 * sysdep.c: Make symbols static if they're not exported.
8108 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
8110 (sigprocmask_set, full_mask): Remove; unused.
8111 (wait_debugging): Mark as visible.
8112 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
8113 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
8115 * syntax.c (syntax_temp): Define only if !__GNUC__.
8117 * sound.c (current_sound_device, current_sound): Now static.
8119 * search.c (searchbufs, searchbuf_head): Now static.
8121 * scroll.c (scroll_cost): Remove; unused.
8122 * dispextern.h (scroll_cost): Remove decl.
8124 * region-cache.h (pp_cache): Mark as externally visible.
8126 * process.c: Make symbols static if they're not exported.
8127 (process_tick, update_tick, create_process, chan_process):
8128 (Vprocess_alist, proc_buffered_char, datagram_access):
8129 (fd_callback_data, send_process_frame, process_sent_to): Now static.
8130 (deactivate_process): Mark defn as static, as well as decl.
8131 * lisp.h (create_process): Remove decl.
8132 * process.h (chan_process, Vprocess_alist): Remove decls.
8134 * print.c: Make symbols static if they're not exported.
8135 (print_depth, new_backquote_output, being_printed, print_buffer):
8136 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
8137 (print_interval, print_number_index, initial_stderr_stream):
8139 * lisp.h (Fprinc): Remove decl.
8140 (debug_output_compilation_hack): Mark as externally visible.
8142 * sysdep.c (croak): Move decl from here to syssignal.h.
8143 * syssignal.h (croak): Put it here, so the API can be checked when
8144 'croak' is called from dissociate_if_controlling_tty.
8146 * minibuf.c: Make symbols static if they're not exported.
8147 (minibuf_save_list, choose_minibuf_frame): Now static.
8148 * lisp.h (choose_minibuf_frame): Remove decl.
8150 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
8152 * lread.c: Make symbols static if they're not exported.
8153 (read_objects, initial_obarray, oblookup_last_bucket_number):
8155 (make_symbol): Remove; unused.
8156 * lisp.h (initial_obarray, make_symbol): Remove decls.
8158 * keyboard.c: Make symbols static if they're not exported.
8159 (single_kboard, recent_keys_index, total_keys, recent_keys):
8160 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
8161 (this_single_command_key_start, echoing, last_auto_save):
8162 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
8163 (command_loop, echo_now, keyboard_init_hook, help_char_p):
8164 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
8165 (Vlispy_mouse_stem, double_click_count):
8167 (force_auto_save_soon): Define only if SIGDANGER.
8168 (ignore_mouse_drag_p): Now static if
8169 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
8170 (print_help): Remove; unused.
8171 (stop_character, last_timer_event): Mark as externally visible.
8172 * keyboard.h (ignore_mouse_drag_p): Declare only if
8173 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
8174 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
8175 * lisp.h (echoing): Remove decl.
8176 (force_auto_save_soon): Declare only if SIGDANGER.
8177 * xdisp.c (redisplay_window): Simplify code, to make it more
8178 obvious that ignore_mouse_drag_p is not accessed if !defined
8179 USE_GTK && !defined HAVE_NS.
8181 * intervals.c: Make symbols static if they're not exported.
8182 (merge_properties_sticky, merge_interval_right, delete_interval):
8184 * intervals.h (merge_interval_right, delete_interval): Remove decls.
8186 * insdel.c: Make symbols static if they're not exported.
8187 However, leave prepare_to_modify_buffer alone. It's never
8188 called from outside this function, but that appears to be a bug.
8189 (combine_after_change_list, combine_after_change_buffer):
8190 (adjust_after_replace, signal_before_change): Now static.
8191 (adjust_after_replace_noundo): Remove; unused.
8192 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
8193 (signal_before_change): Remove decls.
8195 * indent.c (val_compute_motion, val_vmotion): Now static.
8197 * image.c: Make symbols static if they're not exported.
8198 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
8200 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
8201 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8203 * fringe.c (standard_bitmaps): Now static.
8204 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
8206 * frame.c: Make symbols static if they're not exported.
8207 (x_report_frame_params, make_terminal_frame): Now static.
8208 (get_frame_param): Now static, unless HAVE_NS.
8209 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
8210 (x_get_resource_string): Remove; not used.
8211 * frame.h (make_terminal_frame, x_report_frame_params):
8212 (x_get_resource_string); Remove decls.
8213 (x_fullscreen_adjust): Declare only if WINDOWSNT.
8214 * lisp.h (get_frame_param): Declare only if HAVE_NS.
8216 * font.c, fontset.c: Make symbols static if they're not exported.
8217 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
8218 (FACE_SUITABLE_FOR_CHAR_P): Use it.
8219 * font.c (font_close_object): Now static.
8220 * font.h (font_close_object): Remove.
8221 * fontset.c (FONTSET_OBJLIST): Remove.
8222 (free_realized_fontset) #if-0 the body, which does nothing.
8223 (face_suitable_for_char_p): #if-0, as it's never called.
8224 * fontset.h (face_suitable_for_char_p): Remove decl.
8225 * xfaces.c (face_at_string_position):
8226 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
8227 since 0 is always ASCII.
8229 * fns.c (weak_hash_tables): Now static.
8231 * fileio.c: Make symbols static if they're not exported.
8232 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8233 (Vwrite_region_annotation_buffers): Now static.
8235 * eval.c: Make symbols static if they're not exported.
8236 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8237 * lisp.h (backtrace_list): Remove decl.
8239 * emacs.c: Make symbols static if they're not exported.
8240 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8241 (fatal_error_code, fatal_error_signal_hook, standard_args):
8243 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8244 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8245 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8246 * lisp.h (fatal_error_signal_hook): Remove decl.
8247 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8249 * editfns.c: Move a (normally-unused) function to its only use.
8250 * editfns.c, lisp.h (get_operating_system_release): Remove.
8251 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8252 worth the hassle of breaking this out.
8254 * xterm.c: Make symbols static if they're not exported.
8255 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8256 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8257 (x_destroy_window, x_delete_display):
8259 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8260 (x_mouse_leave): Remove; unused.
8261 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8262 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8263 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8265 (x_mouse_leave): Declare only if WINDOWSNT.
8266 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8267 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8270 * ftxfont.c: Make symbols static if they're not exported.
8271 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8273 * font.h (ftxfont_driver): Likewise.
8275 * xfns.c: Make symbols static if they're not exported.
8276 (x_last_font_name, x_display_info_for_name):
8277 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8278 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8279 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8280 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8281 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8282 (last_show_tip_args): Now static.
8283 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8284 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8285 (x_screen_planes): Remove; unused.
8286 * dispextern.h (x_screen_planes): Remove decl.
8288 * dispnew.c: Make symbols static if they're not exported.
8289 * dispextern.h (redraw_garbaged_frames, scrolling):
8290 (increment_row_positions): Remove.
8291 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8292 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8294 (redraw_garbaged_frames): Remove; unused.
8296 * xfaces.c: Make symbols static if they're not exported.
8297 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8299 * xterm.h (defined_color): Remove decls.
8300 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8301 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8302 (menu_face_changed_default, defined_color, free_realized_face):
8303 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8304 (ascii_face_of_lisp_face): Remove; unused.
8306 * xdisp.c: Make symbols static if they're not exported.
8307 * dispextern.h (scratch_glyph_row, window_box_edges):
8308 (glyph_to_pixel_coords, set_cursor_from_row):
8309 (get_next_display_element, set_iterator_to_next):
8310 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8311 (show_mouse_face): Remove decls
8312 * frame.h (message_buf_print): Likewise.
8313 * lisp.h (pop_message, set_message, check_point_in_composition):
8315 * xterm.h (set_vertical_scroll_bar): Likewise.
8316 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8317 (message_buf_print, scratch_glyph_row, displayed_buffer):
8318 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8319 (get_next_display_element, show_mouse_face, window_box_edges):
8320 (frame_to_window_pixel_xy, check_point_in_composition):
8321 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8322 (glyph_to_pixel_coords): Remove; unused.
8324 * dired.c (file_name_completion): Now static.
8326 * dbusbind.c (xd_in_read_queued_messages): Now static.
8328 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8329 * data.c (circular_list_error): Remove.
8331 * commands.h (last_point_position, last_point_position_buffer):
8332 (last_point_position_window): Remove decls.
8333 * keyboard.c: Make these variables static.
8335 * coding.h (coding, code_convert_region, encode_coding_gap):
8337 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8338 (iso_code_class, detect_coding, code_convert_region): Now static.
8339 (encode_coding_gap): Remove; unused.
8341 * chartab.c (chartab_chars, chartab_bits): Now static.
8343 * charset.h (charset_iso_8859_1): Remove decl.
8344 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8347 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8348 * ccl.c (Vccl_program_table): Now static.
8349 (check_ccl_update): Remove; unused.
8351 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8352 * category.h: ... from here.
8353 * category.c (check_category_table, set_category_set): Now static.
8355 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8356 * lisp.h: Remove these decls.
8358 * buffer.c (buffer_count): Remove unused var.
8360 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8361 so that it's not optimized away.
8362 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8363 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8364 exported only to the debugger.
8366 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
8367 * atimer.h (run_all_atimers): Remove; not exported.
8369 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8370 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8371 was inaccessible from Lisp.
8372 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8373 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8375 alloc.c: Import and export fewer symbols, and remove unused items.
8376 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8378 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8379 it's not optimized away by whole-program optimization.
8380 (message_enable_multibyte, free_misc): Remove.
8381 (catchlist, handlerlist, mark_backtrace):
8382 Declare only if BYTE_MARK_STACK.
8383 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8384 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8385 (message_enable_multibyte): Remove decl.
8386 (free_misc, interval_free_list, float_block, float_block_index):
8387 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8388 (cons_free_list, last_marked_index):
8390 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8391 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8392 (mark_backtrace): Define only if BYTE_MARK_STACK.
8393 * xdisp.c (message_enable_multibyte): Now static.
8395 Declare Lisp_Object Q* variables to be 'static' if not exported.
8396 This makes it easier for human readers (and static analyzers)
8397 to see whether these variables are used from other modules.
8398 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8399 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8400 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8401 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8402 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8403 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8404 * xmenu.c, xselect.c:
8405 Declare Q* vars static if they are not used in other modules.
8406 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8407 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8408 Remove decls of unexported vars.
8409 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8411 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8413 Make Emacs functions such as Fatom 'static' by default.
8414 This makes it easier for human readers (and static analyzers)
8415 to see whether these functions can be called from other modules.
8416 DEFUN now defines a static function. To make the function external
8417 so that it can be used in other C modules, use the new macro DEFUE.
8418 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8419 (Finit_image_library):
8420 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8421 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8422 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8423 Remove decls, since these functions are now static.
8424 (Funintern, Fget_internal_run_time): New decls, since these functions
8425 were already external.
8427 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8428 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8429 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8430 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8431 * keyboard.c, keymap.c, lread.c:
8432 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8433 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8434 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8435 Mark functions with DEFUE instead of DEFUN,
8436 if they are used in other modules.
8437 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8438 decls for now-static functions.
8439 * buffer.h (Fdelete_overlay): Remove decl.
8440 * callproc.c (Fgetenv_internal): Mark as internal.
8441 * composite.c (Fremove_list_of_text_properties): Remove decl.
8442 (Fcomposition_get_gstring): New forward static decl.
8443 * composite.h (Fcomposite_get_gstring): Remove decl.
8444 * dired.c (Ffile_attributes): New forward static decl.
8445 * doc.c (Fdocumntation_property): New forward static decl.
8446 * eval.c (Ffetch_bytecode): New forward static decl.
8447 (Funintern): Remove extern decl; now in .h file where it belongs.
8448 * fileio.c (Fmake_symbolic_link): New forward static decl.
8449 * image.c (Finit_image_library): New forward static decl.
8450 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8451 * intervals.h (Fprevious_property_change):
8452 (Fremove_list_of_text_properties): Remove decls.
8453 * keyboard.c (Fthis_command_keys): Remove decl.
8454 (Fcommand_execute): New forward static decl.
8455 * keymap.c (Flookup_key): New forward static decl.
8456 (Fcopy_keymap): Now static.
8457 * keymap.h (Flookup_key): Remove decl.
8458 * process.c (Fget_process): New forward static decl.
8459 (Fprocess_datagram_address): Mark as internal.
8460 * syntax.c (Fsyntax_table_p): New forward static decl.
8461 (skip_chars): Remove duplicate decl.
8462 * textprop.c (Fprevious_property_change): New forward static decl.
8463 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8465 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8466 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8468 * editfns.c (Fformat): Remove unreachable code.
8470 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8472 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8475 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8477 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8478 when at ZV. (Bug#8487)
8480 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8482 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8484 * keyboard.c (parse_tool_bar_item): Likewise.
8485 * sound.c (sound_cleanup, alsa_close): Likewise.
8486 * termcap.c (tgetent): Likewise.
8487 * xfns.c (x_default_font_parameter): Likewise.
8488 * xsettings.c (read_and_apply_settings): Likewise.
8490 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8491 (overrun_check_free): Protoize.
8493 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8495 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8496 since callers should never pass a negative size.
8497 Change the signature to match that of plain 'read' and 'write'; see
8498 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8499 * lisp.h: Update prototypes of emacs_write and emacs_read.
8501 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8503 * xdisp.c (redisplay_window): Don't try to determine the character
8504 position of the scroll margin if the window start point w->startp
8505 is outside the buffer's accessible region. (Bug#8468)
8507 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8509 Fix write-region and its subroutines for buffers > 2GB.
8510 * fileio.c (a_write, e_write): Modify declaration of arguments and
8511 local variables to support buffers larger than 2GB.
8512 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8514 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8515 argument, local variables, and return value.
8517 * lisp.h: Update prototypes of emacs_write and emacs_read.
8519 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8521 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8523 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8525 Fix more problems found by GCC 4.6.0's static checks.
8527 * xdisp.c (vmessage): Use a better test for character truncation.
8529 * charset.c (load_charset_map): <, not <=, for optimization,
8530 and to avoid potential problems with integer overflow.
8531 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8532 * casetab.c (set_identity, shuffle): Likewise.
8533 * editfns.c (Fformat): Likewise.
8534 * syntax.c (skip_chars): Likewise.
8536 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8537 This also lets GCC 4.6.0 generate slightly better loop code.
8539 * callint.c (Fcall_interactively): <, not <=, for optimization.
8540 (Fcall_interactively): Count the number of arguments produced,
8541 not the number of arguments given. This is simpler and lets GCC
8542 4.6.0 generate slightly better code.
8544 * ftfont.c: Distingish more carefully between FcChar8 and char.
8545 The previous code passed unsigned char * to a functions like
8546 strlen and xstrcasecmp that expect char *, which does not
8547 conform to the C standard.
8548 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8549 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8550 char * when the C standard requires it.
8552 * keyboard.c (read_char): Remove unused var.
8554 * eval.c: Port to Windows vsnprintf (Bug#8435).
8556 (SIZE_MAX): Define if the headers do not.
8557 (verror): Do not give up if vsnprintf returns a negative count.
8558 Instead, grow the buffer. This ports to Windows vsnprintf, which
8559 does not conform to C99. Problem reported by Eli Zaretskii.
8560 Also, simplify the allocation scheme, by avoiding the need for
8561 calling realloc, and removing the ALLOCATED variable.
8563 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8565 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8566 But keep the doprint source code for now, as we might revamp it
8567 and use it again (Bug#8435).
8568 * lisp.h (doprnt): Remove.
8569 * Makefile.in (base_obj): Remove doprnt.o.
8570 * deps.mk (doprnt.o): Remove.
8572 error: Print 32- and 64-bit integers portably (Bug#8435).
8573 Without this change, on typical 64-bit hosts error ("...%d...", N)
8574 was used to print both 32- and 64-bit integers N, which relied on
8576 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8577 * lisp.h (error, verror): Mark as printf-like functions.
8578 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8579 Report overflow in size calculations when allocating printf buffer.
8580 Do not truncate output string at its first null byte.
8581 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8582 Truncate the output at a character boundary, since vsnprintf does not
8584 * charset.c (check_iso_charset_parameter): Convert internal
8585 character to string before calling 'error', since %c now has the
8587 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8588 overflow when computing char to be passed to 'error'. Do not
8589 pass Lisp_Object to 'error'; pass the integer instead.
8590 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8591 formatted with plain %d.
8593 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8595 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8597 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8599 * xterm.c (x_catch_errors): Remove duplicate declaration.
8601 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8603 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8605 2011-04-10 Jim Meyering <meyering@redhat.com>
8607 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8608 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8609 return ssize_t not "int", and use size_t as the buffer length.
8610 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8611 * gnutls.h: Update declarations.
8612 * process.c (read_process_output): Use ssize_t, to match.
8613 (send_process): Likewise.
8615 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8617 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8619 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8621 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8622 Use unsigned char, to match FcChar8 type definition.
8624 * xterm.c (handle_one_xevent):
8625 * xmenu.c (create_and_show_popup_menu):
8626 * xselect.c (x_decline_selection_request)
8627 (x_reply_selection_request): Avoid type-punned deref of X events.
8629 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8631 Fix some uses of `int' instead of EMACS_INT.
8632 * search.c (string_match_1, fast_string_match)
8633 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8634 (scan_buffer, find_next_newline_no_quit)
8635 (find_before_next_newline, search_command, Freplace_match)
8636 (Fmatch_data): Make some `int' variables be EMACS_INT.
8638 * xdisp.c (display_count_lines): 3rd argument and return value now
8639 EMACS_INT. All callers changed.
8640 (pint2hrstr): Last argument is now EMACS_INT.
8642 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8643 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8644 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8645 (decode_coding_utf_16, decode_coding_emacs_mule)
8646 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8647 (decode_coding_ccl, decode_coding_charset)
8648 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8649 (decode_coding_iso_2022, decode_coding_emacs_mule)
8650 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8651 <char_offset, last_offset>: Declare EMACS_INT.
8652 (encode_coding_utf_8, encode_coding_utf_16)
8653 (encode_coding_emacs_mule, encode_invocation_designation)
8654 (encode_designation_at_bol, encode_coding_iso_2022)
8655 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8656 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8658 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8659 (encode_invocation_designation): Last argument P_NCHARS is now
8661 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8662 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8664 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8667 * ccl.c (Fccl_execute_on_string): Declare some variables
8670 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8672 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8674 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8676 * process.c (Fformat_network_address): Doc fix.
8678 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8680 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8682 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8684 * keyboard.c (read_char): Call Lisp function help-form-show,
8685 instead of using internal_with_output_to_temp_buffer.
8686 (Qhelp_form_show): New var.
8687 (syms_of_keyboard): Use DEFSYM macro.
8689 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8691 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8693 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8695 * process.c (Flist_processes): Remove to Lisp.
8696 (list_processes_1): Delete.
8698 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8700 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8702 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8704 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8706 Fix more problems found by GCC 4.6.0's static checks.
8708 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8710 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8712 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8714 * xdisp.c (vmessage): Mark as a printf-like function.
8716 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8718 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8720 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8721 printf-like functions.
8722 (tiff_load): Add casts to remove these marks before passing them
8723 to system-supplied API.
8725 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8727 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8728 This avoids several warnings with gcc -Wstrict-overflow.
8729 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8730 directly, rather than having caller test rule sign. This avoids
8731 some unnecessary tests.
8732 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8733 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8734 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8736 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8737 (xfont_open): Avoid unnecessary tests.
8739 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8741 * composite.h, composite.c (composition_gstring_put_cache):
8742 Use EMACS_INT, not int, for length.
8744 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8745 breaking out part of COMPOSITION_DECODE_RULE.
8746 (COMPOSITION_DECODE_RULE): Use it.
8747 * composite.c (get_composition_id): Remove unused local vars,
8748 by using the new macro.
8750 * textprop.c (set_text_properties_1): Change while to do-while,
8751 since the condition is always true at first.
8753 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8754 (interval_deletion_adjustment): Return unsigned value.
8757 * process.c (list_processes_1, create_pty, read_process_output):
8758 (exec_sentinel): Remove vars that were set but not used.
8759 (create_pty): Remove unnecessary "volatile"s.
8760 (Fnetwork_interface_info): Avoid possibility of int overflow.
8761 (read_process_output): Do adaptive read buffering even if carryover.
8762 (read_process_output): Simplify nbytes computation if buffered.
8764 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8766 * syntax.c (scan_words): Remove var that was set but not used.
8767 (update_syntax_table): Use unsigned instead of int.
8769 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8770 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8771 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8773 * print.c (print_error_message): Avoid int overflow.
8775 * font.c (font_list_entities): Redo for clarity,
8776 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8778 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8779 (font_score): Avoid potential overflow in diff calculation.
8781 * fns.c (substring_both): Remove var that is set but not used.
8782 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8784 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8786 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8787 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8788 can always succeed if overflow has undefined behavior.
8790 * search.c (boyer_moore, wordify): Remove vars set but not used.
8791 (wordify): Omit three unnecessary tests.
8793 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8794 All callers changed. This avoids the need for an unused var.
8796 * casefiddle.c (casify_region): Remove var that is set but not used.
8798 * dired.c (file_name_completion): Remove var that is set but not used.
8800 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8802 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8803 (Finsert_file_contents): Remove unnecessary code checking fd.
8805 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8806 Check for integer overflow on size calculations.
8808 * buffer.c (Fprevious_overlay_change): Remove var that is set
8811 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8812 Remove vars that are set but not used.
8813 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8814 (timer_check_2): Mark vars as initialized.
8816 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8818 * image.c (lookup_image): Remove var that is set but not used.
8819 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8821 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8822 that are set but not used.
8824 * xfns.c (make_invisible_cursor): Don't return garbage
8825 if XCreateBitmapFromData fails (Bug#8410).
8827 * xselect.c (x_get_local_selection, x_handle_property_notify):
8828 Remove vars that are set but not used.
8830 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8831 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8833 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8834 Remove var that is set but not used.
8835 (scroll_bar_windows_size): Now size_t, not int.
8836 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8839 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8840 (map_tty_color) [!defined MSDOS]: Likewise.
8842 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8844 * coding.c: Remove vars that are set but not used.
8845 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8846 All callers changed.
8847 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8848 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8849 (decode_coding_charset): Remove vars that are set but not used.
8851 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8852 that is set but not used.
8854 * print.c (print_object): Remove var that is set but not used.
8856 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8857 The gnulib version avoids calling malloc in the usual case,
8858 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8859 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8860 * filelock.c (current_lock_owner): Likewise.
8861 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8862 * sysdep.c: Include allocator.h, careadlinkat.h.
8863 (emacs_no_realloc_allocator): New static constant.
8864 (emacs_readlink): New function.
8865 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8866 ../lib/careadlinkat.h.
8868 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8870 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8871 first non-nil return value).
8873 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8875 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8876 if not defined (Bug#8403).
8878 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8880 * xdisp.c (display_count_lines): Remove parameter `start',
8881 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8882 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8883 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8884 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8885 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8886 and thereabouts. All callers changed.
8887 (get_per_char_metric): Remove parameter `f', unused since
8888 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8890 2011-04-02 Jim Meyering <meyering@redhat.com>
8892 do not dereference NULL upon failed strdup
8893 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8894 (ns_get_family): Likewise.
8896 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8898 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8900 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8902 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8905 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8907 Add lexical binding.
8909 * window.c (Ftemp_output_buffer_show): New fun.
8910 (Fsave_window_excursion):
8911 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8913 * lread.c (lisp_file_lexically_bound_p): New function.
8914 (Fload): Bind Qlexical_binding.
8915 (readevalloop): Remove `evalfun' arg.
8916 Bind Qinternal_interpreter_environment.
8917 (Feval_buffer): Bind Qlexical_binding.
8918 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8920 (syms_of_lread): Declare `lexical-binding'.
8922 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8924 * keyboard.c (eval_dyn): New fun.
8925 (menu_item_eval_property): Use it.
8927 * image.c (parse_image_spec): Use Ffunctionp.
8929 * fns.c (concat, mapcar1): Accept byte-code-functions.
8931 * eval.c (Fsetq): Handle lexical vars.
8932 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8933 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8934 (FletX, Flet): Obey lexical binding.
8935 (Fcommandp): Handle closures.
8936 (Feval): New `lexical' arg.
8937 (eval_sub): New function extracted from Feval. Use it almost
8938 everywhere where Feval was used. Look up vars in lexical env.
8940 (Ffunctionp): Move from subr.el.
8941 (Ffuncall): Handle closures.
8942 (apply_lambda): Remove `eval_flags'.
8943 (funcall_lambda): Handle closures and new byte-code-functions.
8944 (Fspecial_variable_p): New function.
8945 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8946 but without exporting it to Lisp.
8948 * doc.c (Fdocumentation, store_function_docstring):
8949 * data.c (Finteractive_form): Handle closures.
8951 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8954 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8956 (exec_byte_code): New function extracted from Fbyte_code to handle new
8957 calling convention for byte-code-functions. Add new byte-codes.
8959 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8961 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8963 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8965 * xdisp.c (redisplay_internal): Fix prototype.
8967 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8969 * xdisp.c (SCROLL_LIMIT): New macro.
8970 (try_scrolling): Use it when setting scroll_limit.
8971 Limit scrolling to 100 screen lines.
8972 (redisplay_window): Even when falling back on "recentering",
8973 position point in the window according to scroll-conservatively,
8974 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8976 (try_scrolling): When point is above the window, allow searching
8977 as far as scroll_max, or one screenful, to compute vertical
8978 distance from PT to the scroll margin position. This prevents
8979 try_scrolling from unnecessarily failing when
8980 scroll-conservatively is set to a value slightly larger than the
8981 window height. Clean up the case of PT below the margin at bottom
8982 of window: scroll_max can no longer be INT_MAX. When aggressive
8983 scrolling is in use, don't let point enter the opposite scroll
8984 margin as result of the scroll.
8985 (syms_of_xdisp) <scroll-conservatively>: Document the
8986 threshold of 100 lines for never-recentering scrolling.
8988 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8990 * dispextern.h (move_it_by_lines):
8991 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8992 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8993 (message_log_check_duplicate): Remove parameters `prev_bol' and
8994 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8995 (redisplay_internal): Remove parameter `preserve_echo_area',
8996 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8998 * indent.c (Fvertical_motion):
8999 * window.c (window_scroll_pixel_based, Frecenter):
9000 Don't pass `need_y_p' to `move_it_by_lines'.
9002 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
9004 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
9005 steal a few bits to be more compact.
9006 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
9007 Remove unneeded casts.
9009 * bytecode.c (Fbyte_code): CAR and CDR can GC.
9011 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
9013 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
9014 binding" message (bug#7967).
9016 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
9018 Fix more problems found by GCC 4.6.0's static checks.
9020 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
9021 Remove unused local var.
9023 * editfns.c (Fmessage_box): Remove unused local var.
9025 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
9026 (note_mode_line_or_margin_highlight, note_mouse_highlight):
9027 Omit unused local vars.
9028 * window.c (shrink_windows): Omit unused local var.
9029 * menu.c (digest_single_submenu): Omit unused local var.
9030 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
9031 Omit unused local var.
9033 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
9034 Don't assume string length fits in int.
9035 (keyremap_step, read_key_sequence): Use size_t for sizes.
9036 (read_key_sequence): Don't check last_real_key_start redundantly.
9038 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
9039 instead of alloca (Bug#8344).
9041 * eval.c (Fbacktrace): Don't assume nargs fits in int.
9042 (Fbacktrace_frame): Don't assume nframes fits in int.
9044 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
9046 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
9049 * term.c (produce_glyphless_glyph): Remove unnecessary test.
9051 * cm.c (calccost): Turn while-do into do-while, for clarity.
9053 * keyboard.c (syms_of_keyboard): Use the same style as later
9054 in this function when indexing through an array. This also
9055 works around GCC bug 48267.
9057 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
9059 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
9061 * chartab.c (sub_char_table_ref_and_range): Redo for slight
9062 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
9064 * keyboard.c, keyboard.h (num_input_events): Now size_t.
9065 This avoids undefined behavior on integer overflow, and is a bit
9066 more convenient anyway since it is compared to a size_t variable.
9068 Variadic C functions now count arguments with size_t, not int.
9069 This avoids an unnecessary limitation on 64-bit machines, which
9070 caused (substring ...) to crash on large vectors (Bug#8344).
9071 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
9072 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
9073 All variadic functions and their callers changed accordingly.
9074 (struct gcpro.nvars): Now size_t, not int. All uses changed.
9075 * data.c (arith_driver, float_arith_driver): Likewise.
9076 * editfns.c (general_insert_function): Likewise.
9077 * eval.c (struct backtrace.nargs, interactive_p)
9078 (internal_condition_case_n, run_hook_with_args, apply_lambda)
9079 (funcall_lambda, mark_backtrace): Likewise.
9080 * fns.c (concat): Likewise.
9081 * frame.c (x_set_frame_parameters): Likewise.
9082 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
9083 0 if not found, not -1. All callers changed.
9085 * alloc.c (garbage_collect): Don't assume stack size fits in int.
9086 (stack_copy_size): Now size_t, not int.
9087 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
9089 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
9091 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
9092 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9093 All callers changed.
9095 * lisp.h (multibyte_char_to_unibyte):
9096 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
9097 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9098 * character.h (CHAR_TO_BYTE8):
9099 * cmds.c (internal_self_insert):
9100 * editfns.c (general_insert_function):
9101 * keymap.c (push_key_description):
9102 * search.c (Freplace_match):
9103 * xdisp.c (message_dolog, set_message_1): All callers changed.
9105 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
9107 * keyboard.c (safe_run_hook_funcall): New function.
9108 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
9109 don't set the hook to nil, but remove the offending function instead.
9110 (Qcommand_hook_internal): Remove, unused.
9111 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
9112 Vcommand_hook_internal.
9114 * eval.c (enum run_hooks_condition): Remove.
9115 (funcall_nil, funcall_not): New functions.
9116 (run_hook_with_args): Call each function through a `funcall' argument.
9117 Remove `cond' argument, now redundant.
9118 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
9119 (Frun_hook_with_args_until_failure): Adjust accordingly.
9120 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
9122 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
9124 * dispextern.h (string_buffer_position): Remove declaration.
9126 * print.c (strout): Remove parameter `multibyte', unused since
9127 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
9129 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
9130 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
9131 All callers changed.
9133 * w32.c (_wsa_errlist): Use braces for struct initializers.
9135 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
9136 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
9137 All callers changed.
9138 (string_buffer_position): Likewise. Also, make static (it's never
9139 used outside xdisp.c).
9140 (cursor_row_p): Remove parameter `w', unused since
9141 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
9142 (decode_mode_spec): Remove parameter `precision', introduced during
9143 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
9144 All callers changed.
9146 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9148 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
9150 2011-03-27 Anders Lindgren <andlind@gmail.com>
9152 * nsterm.m (ns_menu_bar_is_hidden): New variable.
9153 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
9154 (ns_update_auto_hide_menu_bar): New functions.
9155 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
9156 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
9157 ns_constrain_all_frames.
9158 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
9159 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
9161 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9163 * nsmenu.m (runDialogAt): Remove argument to timer_check.
9165 2011-03-27 Glenn Morris <rgm@gnu.org>
9167 * syssignal.h: Replace RETSIGTYPE with void.
9168 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
9169 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
9170 Replace SIGTYPE with void everywhere.
9171 * s/usg5-4-common.h (SIGTYPE): Remove definition.
9172 * s/template.h (SIGTYPE): Remove commented out definition.
9174 2011-03-26 Eli Zaretskii <eliz@gnu.org>
9176 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
9177 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
9179 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
9181 * w32.c (read_unc_volume): Use parameter `henum', instead of
9182 global variable `wget_enum_handle'.
9184 * keymap.c (describe_vector): Remove parameters `indices' and
9185 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
9186 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
9188 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
9190 * keyboard.c (timer_check): Remove parameter `do_it_now',
9191 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
9192 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
9193 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
9195 * keyboard.c (read_char):
9196 * w32menu.c (w32_menu_display_help):
9197 * xmenu.c (show_help_event, menu_help_callback):
9198 Adjust calls to `show_help_echo'.
9200 * gtkutil.c (xg_maybe_add_timer):
9201 * keyboard.c (readable_events):
9202 * process.c (wait_reading_process_output):
9203 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
9205 * insdel.c (adjust_markers_gap_motion):
9206 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
9207 (gap_left, gap_right): Don't call it.
9209 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
9211 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
9212 incurred during fontification.
9214 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9216 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
9217 (DEFVAR_PER_BUFFER): Don't pass it.
9219 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
9220 (scrolling_window): Don't pass it.
9222 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9224 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
9226 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
9228 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
9229 of variables specific to SELinux and computation of `encoded_absname'.
9231 * image.c (XPutPixel): Remove unused variable `height'.
9233 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9235 * unexw32.c (get_section_info): Remove unused variable `section'.
9237 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9238 (system_process_attributes): Remove unused variable `sess'.
9239 (sys_read): Remove unused variable `err'.
9241 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9242 (w32_wnd_proc): Remove unused variable `isdead'.
9243 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9244 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9245 (x_create_tip_frame): Remove unused variable `tem'.
9247 * w32inevt.c (w32_console_read_socket):
9248 Remove unused variable `no_events'.
9250 * w32term.c (x_draw_composite_glyph_string_foreground):
9251 Remove unused variable `width'.
9253 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
9255 * w32term.c (x_set_glyph_string_clipping):
9256 Don't pass uninitialized region to CombineRgn.
9258 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
9260 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9261 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9262 (Fx_close_connection): Remove unused variable `i'.
9264 * w32font.c (w32font_draw): Return number of glyphs.
9265 (w32font_open_internal): Remove unused variable `i'.
9266 (w32font_driver): Add missing initializer.
9268 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9269 (fill_in_menu): Remove unused variable `items_added'.
9271 * w32term.c (last_mouse_press_frame): Remove static global variable.
9272 (w32_clip_to_row): Remove unused variable `f'.
9273 (x_delete_terminal): Remove unused variable `i'.
9275 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9276 (NOTHING): Remove unused static global variable.
9277 (uniscribe_check_otf): Remove unused variable `table'.
9278 (uniscribe_font_driver): Add missing initializers.
9280 2011-03-23 Julien Danjou <julien@danjou.info>
9282 * term.c (Fsuspend_tty, Fresume_tty):
9283 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9284 * window.c (temp_output_buffer_show):
9285 * insdel.c (signal_before_change):
9286 * frame.c (Fhandle_switch_frame):
9287 * fileio.c (Fdo_auto_save):
9288 * emacs.c (Fkill_emacs):
9289 * editfns.c (save_excursion_restore):
9290 * cmds.c (internal_self_insert):
9291 * callint.c (Fcall_interactively):
9292 * buffer.c (Fkill_all_local_variables):
9293 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9295 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
9296 unconditionally since it does the check itself.
9298 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
9300 Fix more problems found by GCC 4.5.2's static checks.
9302 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9303 the first time through the loop, since we know p0 < p1 then.
9304 This also avoids a gcc -Wstrict-overflow warning.
9306 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9307 leading to a memory leak, possible in functions like
9308 load_charset_map_from_file that can allocate an unbounded number
9309 of objects (Bug#8318).
9311 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9312 that could (at least in theory) be that large.
9314 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9315 This is less likely to overflow, and avoids undefined behavior if
9316 overflow does occur. All callers changed. Use strtoul to scan
9317 for the unsigned long integer.
9318 (pint2hrstr): Simplify and tune code slightly.
9319 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
9321 * scroll.c (do_scrolling): Work around GCC bug 48228.
9322 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9324 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9325 This also avoids a warning with gcc -Wstrict-overflow.
9326 (validate_x_resource_name): Simplify count usage.
9327 This also avoids a warning with gcc -Wstrict-overflow.
9329 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9332 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
9334 * process.c (Fmake_network_process): Use socklen_t, not int,
9335 where POSIX says socklen_t is required in portable programs.
9336 This fixes a porting bug on hosts like 64-bit HP-UX, where
9337 socklen_t is wider than int (Bug#8277).
9338 (Fmake_network_process, server_accept_connection):
9339 (wait_reading_process_output, read_process_output):
9342 * process.c: Rename or move locals to avoid shadowing.
9343 (list_processes_1, Fmake_network_process):
9344 (read_process_output_error_handler, exec_sentinel_error_handler):
9345 Rename or move locals.
9346 (Fmake_network_process): Define label "retry_connect" only if needed.
9347 (Fnetwork_interface_info): Fix pointer signedness.
9348 (process_send_signal): Add cast to avoid pointer signedness problem.
9349 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
9350 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
9352 Make tparam.h and terminfo.c consistent.
9353 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9354 Include tparam.h instead, since it declares them.
9355 * cm.h (PC): Remove extern decl; tparam.h now does this.
9356 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9357 * terminfo.c: Include tparam.h, to check interfaces.
9358 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9359 (tparam): Adjust signature to match interface in tparam.h;
9360 this removes some undefined behavior. Check that outstring and len
9361 are zero, which they always are with Emacs.
9362 * tparam.h (PC, BC, UP): New extern decls.
9364 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
9365 (xftfont_open): Rename locals to avoid shadowing.
9367 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
9368 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9369 (OTF_TAG_SYM): Omit macro if not needed.
9370 (ftfont_list): Remove unused local.
9371 (get_adstyle_property, ftfont_pattern_entity):
9372 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9373 Rename locals to avoid shadowing.
9375 * xfont.c (xfont_list_family): Mark var as initialized.
9377 * xml.c (make_dom): Now static.
9379 * composite.c (composition_compute_stop_pos): Rename local to
9381 (composition_reseat_it): Remove unused locals.
9382 (find_automatic_composition, composition_adjust_point): Likewise.
9383 (composition_update_it): Mark var as initialized.
9384 (find_automatic_composition): Mark vars as initialized,
9385 with a FIXME (Bug#8290).
9387 character.h: Rename locals to avoid shadowing.
9388 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9389 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9390 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9391 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9394 * textprop.c (property_change_between_p): Remove; unused.
9396 * intervals.c (interval_start_pos): Now static.
9398 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9400 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9401 Rename locals to avoid shadowing.
9403 * sound.c (wav_play, au_play, Fplay_sound_internal):
9404 Fix pointer signedness.
9405 (alsa_choose_format): Remove unused local var.
9406 (wav_play): Initialize a variable to 0, to prevent undefined
9407 behavior (Bug#8278).
9409 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9411 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9413 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9414 clobbering (Bug#8298).
9415 * sysdep.c (sys_subshell): Likewise.
9416 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9418 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9419 This should get cleaned up, so that child_setup has the
9420 same signature on all platforms.
9422 * callproc.c (call_process_cleanup): Now static.
9423 (relocate_fd): Rename locals to avoid shadowing.
9425 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9427 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9428 not to be necessary, and produces flickering.
9430 2011-03-20 Glenn Morris <rgm@gnu.org>
9432 * config.in: Remove file.
9434 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9436 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9437 are now in src/globals.h.
9438 (syms_of_minibuf): Remove spurious & from previous change.
9440 2011-03-20 Leo Liu <sdl.web@gmail.com>
9442 * minibuf.c (completing-read-function): New variable.
9443 (completing-read-default): Rename from completing-read.
9444 (completing-read): Call completing-read-function.
9446 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9448 * xfaces.c (Fx_load_color_file):
9449 Read color file from absolute filename (bug#8250).
9451 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9453 * makefile.w32-in: Update dependencies.
9455 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9457 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9459 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9461 Fix more problems found by GCC 4.5.2's static checks.
9463 * process.c (make_serial_process_unwind, send_process_trap):
9464 (sigchld_handler): Now static.
9466 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9467 That way, the code declares only the vars that it needs.
9468 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9469 * s/cygwin.h (PTY_ITERATION): Likewise.
9470 * s/darwin.h (PTY_ITERATION): Likewise.
9471 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9473 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9474 * process.c (allocate_pty): Don't declare stb unless it's needed.
9476 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9477 (CONSTANTLIM): Remove; unused.
9478 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9479 Define only if needed.
9481 * unexelf.c (unexec): Name an expression,
9482 to avoid gcc -Wbad-function-cast warning.
9483 Use a different way to cause a compilation error if anyone uses
9484 n rather than nn, a way that does not involve shadowing.
9485 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9487 * deps.mk (unexalpha.o): Remove; unused.
9489 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9490 * unexec.h: New file.
9491 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9492 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9494 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9495 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9496 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9497 Change as necessary to match prototype in unexec.h.
9499 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9501 (back_comment, skip_chars): Mark vars as initialized.
9503 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9504 Rename locals to avoid shadowing.
9506 * lread.c (read1): Rewrite so as not to use empty "else".
9507 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9509 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9511 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9512 warning when compiling print.c.
9514 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9515 instead of using an uninitialized var.
9516 (font_sort_entities): Mark var as initialized.
9518 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9520 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9521 pointers to constants.
9522 (font_parse_fcname): Remove unused vars.
9523 (font_delete_unmatched): Now static.
9524 (font_get_spec): Remove; unused.
9525 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9526 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9527 Rename or move locals to avoid shadowing.
9529 * fns.c (require_nesting_list, require_unwind): Now static.
9530 (Ffillarray): Rename locals to avoid shadowing.
9532 * floatfns.c (domain_error2): Define only if needed.
9533 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9535 * alloc.c (mark_backtrace): Move decl from here ...
9536 * lisp.h: ... to here, so that it can be checked.
9538 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9539 (Fdefvar): Rewrite so as not to use empty "else".
9540 (lisp_indirect_variable): Name an expression,
9541 to avoid gcc -Wbad-function-cast warning.
9542 (Fdefvar): Rename locals to avoid shadowing.
9544 * callint.c (quotify_arg, quotify_args): Now static.
9545 (Fcall_interactively): Rename locals to avoid shadowing.
9546 Use const pointer when appropriate.
9548 * lisp.h (get_system_name, get_operating_system_release):
9549 Move decls here, to check interfaces.
9550 * process.c (get_operating_system_release): Move decl to lisp.h.
9551 * xrdb.c (get_system_name): Likewise.
9552 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9553 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9554 some of which prompt warnings from gcc -Wbad-function-cast.
9555 (Fformat_time_string, Fencode_time, Finsert_char):
9556 (Ftranslate_region_internal, Fformat):
9557 Rename or remove local vars to avoid shadowing.
9558 (Ftranslate_region_internal): Mark var as initialized.
9560 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9563 * lisp.h (eassert): Check that the argument compiles, even if
9564 ENABLE_CHECKING is not defined.
9566 * data.c (Findirect_variable): Name an expression, to avoid
9567 gcc -Wbad-function-cast warning.
9568 (default_value, arithcompare, arith_driver, arith_error): Now static.
9569 (store_symval_forwarding): Rename local to avoid shadowing.
9570 (Fmake_variable_buffer_local, Fmake_local_variable):
9571 Mark variables as initialized.
9572 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9574 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9575 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9576 Rename locals to avoid shadowing.
9577 (mark_stack): Move local variables into the #ifdef region where
9579 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9580 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9582 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9583 (GC_STRING_CHARS): Remove; not used.
9584 (Fmemory_limit): Cast sbrk's returned value to char *.
9586 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9587 avoids undefined behavior in theory.
9589 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9591 Use functions, not macros, for up- and down-casing (Bug#8254).
9592 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9593 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9594 to use the following functions instead of these macros.
9595 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9596 EMACS_INT, since callers assume the returned value fits in int.
9597 (upcase1): Likewise, for UPCASE_TABLE.
9598 (uppercasep, lowercasep, upcase): New static inline functions.
9599 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9600 the race-condition problem in the old DOWNCASE.
9602 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9603 Rename locals to avoid shadowing.
9604 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9605 (regex_compile, re_search_2, re_match_2_internal):
9606 Remove unused local vars.
9607 (FREE_VAR): Rewrite so as not to use empty "else",
9608 which gcc can warn about.
9609 (regex_compile, re_match_2_internal): Mark locals as initialized.
9610 (RETALLOC_IF): Define only if needed.
9611 (WORDCHAR_P): Likewise. This one is never needed, but is used
9612 only in a comment talking about a compiler bug, so put inside
9613 the #if 0 of that comment.
9614 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9615 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9618 * search.c (boyer_moore): Rename locals to avoid shadowing.
9619 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9620 (PREV_CHAR_BOUNDARY): Likewise.
9622 * search.c (simple_search): Remove unused var.
9624 * dired.c (compile_pattern): Move decl from here ...
9625 * lisp.h: ... to here, so that it can be checked.
9626 (struct re_registers): New forward decl.
9628 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9630 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9632 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9633 Rename locals to avoid shadowing.
9634 (Fvertical_motion): Mark locals as initialized.
9636 * casefiddle.c (casify_object, casify_region): Now static.
9637 (casify_region): Mark local as initialized.
9639 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9641 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9642 New macros, so that the caller can use some names other than
9643 gcpro1, gcpro2, etc.
9644 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9646 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9647 argument, for consistency with GCPRO2_VAR, etc: it is now the
9648 prefix of the variable, not the variable itself. All uses
9650 * dired.c (directory_files_internal, file_name_completion):
9651 Rename locals to avoid shadowing.
9653 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9654 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9655 dired.c's scmp function, had undefined behavior.
9656 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9657 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9658 * buffer.h: ... to here, because these macros use current_buffer,
9659 and the new implementation with inline functions needs to have
9660 current_buffer in scope now, rather than later when the macros
9662 (downcase, upcase1): New static inline functions.
9663 (DOWNCASE, UPCASE1): Reimplement using these functions.
9664 This avoids undefined behavior in expressions like
9665 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9666 from race conditions in accessing the global variables
9667 case_temp1 and case_temp2.
9668 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9669 * lisp.h (case_temp1, case_temp2): Remove their decls.
9670 * character.h (ASCII_CHAR_P): Move from here ...
9671 * lisp.h: ... to here, so that the inline functions mentioned
9674 * dired.c (directory_files_internal_unwind): Now static.
9676 * fileio.c (file_name_as_directory, directory_file_name):
9677 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9679 (file_name_as_directory): Use const pointers when appropriate.
9680 (Fexpand_file_name): Likewise. In particular, newdir might
9681 point at constant storage, so make it a const pointer.
9682 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9683 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9685 (Fset_file_times, Finsert_file_contents, auto_save_error):
9686 Rename locals to avoid shadowing.
9688 * minibuf.c (choose_minibuf_frame_1): Now static.
9689 (Ftry_completion, Fall_completions): Rename or remove locals
9692 * marker.c (bytepos_to_charpos): Remove; unused.
9694 * lisp.h (verify_bytepos, count_markers): New decls,
9695 so that gcc does not warn that these functions aren't declared.
9697 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9698 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9699 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9700 (copy_text): Remove unused local var.
9702 * filelock.c (within_one_second): Now static.
9703 (lock_file_1): Rename local to avoid shadowing.
9705 * buffer.c (fix_overlays_before): Mark locals as initialized.
9706 (fix_start_end_in_overlays): Likewise. This function should be
9707 simplified by using pointers-to-pointers, but that's a different
9709 (switch_to_buffer_1): Now static.
9710 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9711 (report_overlay_modification): Rename locals to avoid shadowing.
9713 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9714 Fix pointer signedness issue.
9715 (sys_subshell): Mark local as volatile if checking for lint,
9716 to suppress a gcc -Wclobbered warning that does not seem to be right.
9717 (MAXPATHLEN): Define only if needed.
9719 * process.c (serial_open, serial_configure): Move decls from here ...
9720 * systty.h: ... to here, so that they can be checked.
9722 * fns.c (get_random, seed_random): Move extern decls from here ...
9723 * lisp.h: ... to here, so that they can be checked.
9725 * sysdep.c (reset_io): Now static.
9726 (wait_for_termination_signal): Remove; unused.
9728 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9729 (copy_keymap_item, append_key, push_text_char_description):
9731 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9732 (DENSE_TABLE_SIZE): Remove; unused.
9733 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9734 (describe_map_tree):
9735 Rename locals to avoid shadowing.
9737 * keyboard.c: Declare functions static if they are not used elsewhere.
9738 (echo_char, echo_dash, cmd_error, top_level_2):
9739 (poll_for_input, handle_async_input): Now static.
9740 (read_char, kbd_buffer_get_event, make_lispy_position):
9741 (make_lispy_event, make_lispy_movement, apply_modifiers):
9742 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9743 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9744 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9745 (read_key_sequence, read_char): Mark locals as initialized.
9746 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9748 * keyboard.h (make_ctrl_char): New decl.
9749 (mark_kboards): Move decl here ...
9750 * alloc.c (mark_kboards): ... from here.
9752 * lisp.h (force_auto_save_soon): New decl.
9754 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9755 (DEFINE_DUMMY_FUNCTION): New macro.
9756 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9758 (main): Add casts to avoid warnings
9759 if GCC considers string literals to be constants.
9761 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9763 * dbusbind.c: Pointer signedness fixes.
9764 (xd_signature, xd_append_arg, xd_initialize):
9765 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9766 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9767 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9768 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9770 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9771 if GCC considers string literals to be constants.
9772 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9774 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9776 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9777 (print_preprocess, print_object): New macro to fix last change.
9779 * print.c (print_preprocess): Don't forget font objects.
9781 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9783 * emacs.c (USAGE3): Doc fixes.
9785 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9787 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9790 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9792 * lisp.h (VWindow_system, Qfile_name_history):
9793 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9794 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9795 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9797 * w32select.c: Don't #include "keyboard.h".
9798 (run_protected): Add extern declaration for waiting_for_input.
9800 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9801 * w32console.c (detect_input_pending, read_input_pending)
9802 (encode_terminal_code):
9803 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9804 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9805 (w32_system_caret_y, Qfile_name_history):
9806 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9807 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9808 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9809 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9810 * w32proc.c (Qlocal, report_file_error):
9811 * w32term.c (Vwindow_system, updating_frame):
9812 * w32uniscribe.c (initialized, uniscribe_font_driver):
9813 Remove unneeded extern declarations.
9815 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9817 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9819 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9821 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9822 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9823 These macros can no longer be used for assignment.
9825 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9826 Assign struct members directly, instead of using BUF_BEGV etc.
9827 (record_buffer_markers, fetch_buffer_markers): New functions for
9828 recording and fetching special buffer markers.
9829 (set_buffer_internal_1, set_buffer_temp): Use them.
9831 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9833 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9835 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9836 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9838 * xdisp.c (hscroll_window_tree):
9839 (reconsider_clip_changes): Use PT instead of BUF_PT.
9841 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9843 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9844 $(EMACS_ROOT)/lib/intprops.h.
9846 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9848 Fix more problems found by GCC 4.5.2's static checks.
9850 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9851 to unsigned char * to avoid compiler diagnostic.
9852 (xg_free_frame_widgets): Make it clear that a local variable is
9853 needed only if USE_GTK_TOOLTIP.
9854 (gdk_window_get_screen): Make it clear that this macro is needed
9855 only if USE_GTK_TOOLTIP.
9856 (int_gtk_range_get_value): New function, which avoids a diagnostic
9857 from gcc -Wbad-function-cast.
9858 (xg_set_toolkit_scroll_bar_thumb): Use it.
9859 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9860 diagnostic from gcc -Wbad-function-cast.
9861 (get_utf8_string, xg_get_file_with_chooser):
9862 Rename locals to avoid shadowing.
9863 (create_dialog): Move locals to avoid shadowing.
9865 * xgselect.c (xg_select): Remove unused var.
9867 * image.c (four_corners_best): Mark locals as initialized.
9868 (gif_load): Initialize transparent_p to zero (Bug#8238).
9869 Mark another local as initialized.
9870 (my_png_error, my_error_exit): Mark with NO_RETURN.
9872 * image.c (clear_image_cache): Now static.
9873 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9874 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9875 (x_edge_detection): Remove unnecessary cast that
9876 gcc -Wbad-function-cast diagnoses.
9877 (gif_load): Fix pointer signedness.
9878 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9879 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9881 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9883 Improve quality of tests for time stamp overflow.
9884 For example, without this patch (encode-time 0 0 0 1 1
9885 1152921504606846976) returns the obviously-bogus value (-948597
9886 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9887 reports time overflow. See
9888 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9889 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9890 * editfns.c: Include limits.h and intprops.h.
9891 (TIME_T_MIN, TIME_T_MAX): New macros.
9892 (time_overflow): Move earlier, to before first use.
9893 (hi_time, lo_time): New functions, for an accurate test for
9895 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9896 (Fget_internal_run_time): Don't assume time_t fits in int.
9897 (make_time): Use list2 instead of Fcons twice.
9898 (Fdecode_time): More accurate test for out-of-range times.
9899 (check_tm_member): New function.
9900 (Fencode_time): Use it, to test for out-of-range times.
9901 (lisp_time_argument): Don't rely on undefined left-shift and
9902 right-shift behavior when checking for time stamp overflow.
9904 * editfns.c (time_overflow): New function, refactoring common code.
9905 (Fformat_time_string, Fdecode_time, Fencode_time):
9906 (Fcurrent_time_string): Use it.
9908 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9909 * dired.c (make_time): Move to ...
9910 * editfns.c (make_time): ... here.
9911 * systime.h: Note the move.
9913 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9915 * fringe.c (update_window_fringes): Remove unused variables.
9917 * unexmacosx.c (copy_data_segment): Also copy __got section.
9920 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9922 * termcap.c [MSDOS]: Include "msdos.h".
9923 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9924 Constify `char *' arguments and their references according to
9925 prototypes in tparam.h.
9927 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9929 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9930 Adapt all references accordingly.
9932 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9934 2011-03-11 Tom Tromey <tromey@redhat.com>
9936 * buffer.c (syms_of_buffer): Remove obsolete comment.
9938 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9940 * termhooks.h (encode_terminal_code): Declare prototype.
9942 * msdos.c (encode_terminal_code): Don't declare prototype.
9944 * term.c (encode_terminal_code): Now external again, used by
9945 w32console.c and msdos.c.
9947 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9948 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9950 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9952 Fix some minor problems found by GCC 4.5.2's static checks.
9954 * fringe.c (update_window_fringes): Mark locals as initialized
9956 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9958 * alloc.c (mark_fringe_data): Move decl from here ...
9959 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9960 to check its interface.
9961 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9963 * fontset.c (free_realized_fontset): Now static.
9964 (Fset_fontset_font): Rename local to avoid shadowing.
9965 (fontset_font): Mark local as initialized.
9966 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9968 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9970 * xselect.c (x_disown_buffer_selections): Remove; not used.
9971 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9972 (x_own_selection, Fx_disown_selection_internal): Rename locals
9974 (x_handle_dnd_message): Remove local to avoid shadowing.
9976 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9977 so that the caller can use some name other than gcpro1.
9978 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9979 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9980 (Fx_backspace_delete_keys_p):
9981 Use them to avoid shadowing, and rename vars to avoid shadowing.
9982 (x_decode_color, x_set_name, x_window): Now static.
9983 (Fx_create_frame): Add braces to silence GCC warning.
9984 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9985 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9986 Remove unused locals.
9987 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9988 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9989 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9992 * xterm.h (x_mouse_leave): New decl.
9994 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9995 Remove unused functions.
9996 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9997 (x_calc_absolute_position): Now static.
9998 (XTread_socket): Don't define label "out" unless it's used.
9999 Don't declare local "event" unless it's used.
10000 (x_iconify_frame, x_free_frame_resources): Don't declare locals
10001 unless they are used.
10002 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
10003 (x_fatal_error_signal): Remove; not used.
10004 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
10005 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
10006 (x_error_catcher, x_connection_closed, x_error_handler):
10007 (x_error_quitter, xembed_send_message, x_iconify_frame):
10008 (my_log_handler): Rename locals to avoid shadowing.
10009 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
10010 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
10012 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
10013 Rename or move locals to avoid shadowing.
10014 (tty_defined_color, merge_face_heights): Now static.
10015 (free_realized_faces_for_fontset): Remove; not used.
10016 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
10017 does not deduce is never used uninitialized.
10018 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
10019 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
10021 * terminal.c (store_terminal_param): Now static.
10023 * xmenu.c (menu_highlight_callback): Now static.
10024 (set_frame_menubar): Remove unused local.
10025 (xmenu_show): Rename parameter to avoid shadowing.
10026 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
10027 since they might point to immutable storage.
10028 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
10029 since it's unused otherwise.
10031 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
10032 Add a FIXME, since the code still doesn't look right. (Bug#8215)
10033 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
10034 avoids a gcc -Wuninitialized diagnostic.
10035 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
10036 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
10037 does not deduce are never used uninitialized.
10039 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
10041 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
10042 * window.c (window_loop, size_window):
10043 (run_window_configuration_change_hook, enlarge_window): Likewise.
10045 * window.c (display_buffer): Now static.
10046 (size_window): Mark variables that gcc -Wuninitialized
10047 does not deduce are never used uninitialized.
10048 * window.h (check_all_windows): New decl, to forestall
10049 gcc -Wmissing-prototypes diagnostic.
10050 * dispextern.h (bidi_dump_cached_states): Likewise.
10052 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
10054 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
10055 Include <limits.h>.
10056 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
10057 and to avoid gcc -Wuninitialized warning.
10058 (load_charset_map): Mark variables that gcc -Wuninitialized
10059 does not deduce are never used uninitialized.
10060 (load_charset): Abort instead of using uninitialized var (Bug#8229).
10062 * coding.c (coding_set_source, coding_set_destination):
10063 Use "else { /* comment */ }" rather than "else /* comment */;"
10064 for clarity, and to avoid gcc -Wempty-body warning.
10065 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
10066 a block, when the outer 'i' will do.
10067 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
10068 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
10069 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
10070 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
10071 (Fdecode_sjis_char, Fdefine_coding_system_internal):
10072 Rename locals to avoid shadowing.
10073 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
10074 * coding.c (emacs_mule_char, encode_invocation_designation):
10075 Now static, since they're not used elsewhere.
10076 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
10077 (decode_coding_object, encode_coding_object, detect_coding_system):
10078 (decode_coding_emacs_mule): Mark variables that gcc
10079 -Wuninitialized does not deduce are never used uninitialized.
10080 (detect_coding_iso_2022): Initialize a local variable that might
10081 be used uninitialized. Leave a FIXME because it's not clear that
10082 this initialization is needed. (Bug#8211)
10083 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
10084 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
10085 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
10086 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
10087 Remove unused macros.
10089 * category.c (hash_get_category_set): Remove unused local var.
10090 (copy_category_table): Now static, since it's not used elsewhere.
10091 * character.c (string_count_byte8): Likewise.
10093 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
10094 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
10096 * chartab.c (copy_sub_char_table): Now static, since it's not used
10098 (sub_char_table_ref_and_range, char_table_ref_and_range):
10099 Rename locals to avoid shadowing.
10100 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
10102 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
10103 (BIDI_BOB): Remove unused macro.
10105 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
10106 deduce are never used uninitialized.
10107 * term.c (encode_terminal_code): Likewise.
10109 * term.c (encode_terminal_code): Now static. Remove unused local.
10111 * tparam.h: New file.
10112 * term.c, tparam.h: Include it.
10113 * deps.mk (term.o, tparam.o): Depend on tparam.h.
10114 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
10115 Move these decls to tparam.h, and make them agree with what
10116 is actually in tparam.c. The previous trick of using incompatible
10117 decls in different modules does not conform to the C standard.
10118 All callers of tparam changed to use tparam's actual API.
10119 * tparam.c (tparam1, tparam, tgoto):
10120 Use const pointers where appropriate.
10122 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
10123 * cm.h (struct cm): Likewise.
10124 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
10125 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
10126 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
10127 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
10128 (turn_on_face, init_tty): Likewise.
10129 * termchar.h (struct tty_display_info): Likewise.
10131 * term.c (term_mouse_position): Rename local to avoid shadowing.
10133 * alloc.c (mark_ttys): Move decl from here ...
10134 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
10136 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
10138 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
10140 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
10142 * search.c (compile_pattern_1): Remove argument regp, unused since
10143 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
10144 (compile_pattern): Don't pass it.
10146 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
10148 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
10149 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
10151 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
10153 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
10155 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
10156 gdk_window_get_screen, gdk_window_get_geometry,
10157 gdk_x11_window_lookup_for_display and GDK_KEY_g.
10158 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
10159 (xg_get_pixbuf_from_pixmap): New function.
10160 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
10161 to Pixmap, take frame as parameter, remove GdkColormap parameter.
10162 Call xg_get_pixbuf_from_pixmap instead of
10163 gdk_pixbuf_get_from_drawable.
10164 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
10165 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
10166 (xg_check_special_colors): Use GtkStyleContext and its functions
10168 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
10169 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
10170 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
10171 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
10172 Call gtk_widget_get_preferred_size.
10173 (xg_frame_resized): gdk_window_get_geometry only takes 5
10175 (xg_win_to_widget, xg_event_is_for_menubar):
10176 Call gdk_x11_window_lookup_for_display.
10177 (xg_set_widget_bg): New function.
10178 (delete_cb): New function.
10179 (xg_create_frame_widgets): Connect delete-event to delete_cb.
10180 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
10181 (xg_set_background_color): Call xg_set_widget_bg.
10182 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
10183 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
10184 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
10185 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
10187 (update_frame_tool_bar): Call gtk_widget_hide.
10188 (xg_initialize): Use GDK_KEY_g.
10190 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
10192 (x_session_initialize): Call gdk_x11_set_sm_client_id.
10194 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
10195 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
10196 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
10198 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
10200 * w32xfns.c (select_palette): Check success of RealizePalette against
10201 GDI_ERROR, not zero.
10203 See ChangeLog.11 for earlier changes.
10205 ;; Local Variables:
10209 Copyright (C) 2011-2012 Free Software Foundation, Inc.
10211 This file is part of GNU Emacs.
10213 GNU Emacs is free software: you can redistribute it and/or modify
10214 it under the terms of the GNU General Public License as published by
10215 the Free Software Foundation, either version 3 of the License, or
10216 (at your option) any later version.
10218 GNU Emacs is distributed in the hope that it will be useful,
10219 but WITHOUT ANY WARRANTY; without even the implied warranty of
10220 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10221 GNU General Public License for more details.
10223 You should have received a copy of the GNU General Public License
10224 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.