1 2012-06-29 Eli Zaretskii <eliz@gnu.org>
3 * xdisp.c (try_window_id): Undo last change.
5 * w32.c (getwd): Adjust commentary about startup_dir.
6 (init_environment): Always call sys_access, even in non-MSVC
7 builds. Don't chdir to the directory of the Emacs executable.
8 This undoes code from 1997 which was justified by the need to
9 "avoid conflicts when removing and renaming directories". But its
10 downside was that every relative file name was being interpreted
11 relative to the directory of the Emacs executable, which can never
12 be TRT. In particular, it broke sys_access when called with
14 (sys_access): Map GetLastError to errno.
16 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
18 * window.h (struct window): Change type of 'fringes_outside_margins'
19 to bitfield. Fix comment. Adjust users accordingly.
20 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
22 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
25 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
27 * gnutls.c (emacs_gnutls_handshake):
28 Add QUIT to make the loop interruptible.
30 2012-06-29 Glenn Morris <rgm@gnu.org>
32 * charset.c (init_charset): Make lack of etc/charsets fatal.
34 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
36 * editfns.c (region_limit): Fix type mismatch.
38 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
40 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
41 undefined. Convert from xassert to eassert.
42 * nsmenu.m: Convert from xassert to eassert.
45 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
47 * editfns.c (region_limit): Clip to narrowing (bug#11770).
49 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
51 Avoid integer overflow on scroll-left and scroll-right.
52 * window.c (HSCROLL_MAX): New macro.
53 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
54 overflow when requested scroll falls outside ptrdiff_t range.
56 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
58 * window.h (struct window): Change type of 'hscroll',
59 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
60 'last_modified' and 'last_overlay_modified' to EMACS_INT.
61 Adjust users accordingly.
62 * xdisp.c (try_cursor_movement): Replace type check with eassert.
63 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
64 from EMACS_INT to ptrdiff_t.
65 (make_window): Omit redundant initialization.
67 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
69 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
71 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
73 * window.h (struct window): Change type of 'use_time' and
74 'sequence_number' from Lisp_Object to int.
75 * frame.c (make_frame): Adjust users accordingly.
76 * print.c (print_object): Likewise.
77 * window.c (select_window, Fwindow_use_time, make_parent_window)
78 (make_window): Likewise.
80 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
82 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
83 enabled with --enable-checking=[all,glyphs] configure option.
84 Fix GLYPH_DEBUG usage assuming that it may be undefined,
85 adjust comments accordingly.
86 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
87 undefined, adjust comments accordingly.
91 * w32term.c: Likewise.
97 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
99 Generalize run-time debugging checks.
100 * dispextern.h (XASSERTS): Remove.
101 * fontset.c (xassert): Remove.
102 Convert from xassert to eassert.
103 * alloc.c: Convert from xassert to eassert.
105 * dispnew.c: Likewise.
107 * fringe.c: Likewise.
108 * ftfont.c: Likewise.
109 * gtkutil.c: Likewise.
111 * keyboard.c: Likewise.
113 * process.c: Likewise.
114 * scroll.c: Likewise.
117 * w32console.c: Likewise.
118 * w32fns.c: Likewise.
119 * w32term.c: Likewise.
120 * window.c: Likewise.
122 * xfaces.c: Likewise.
124 * xselect.c: Likewise.
127 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
129 * fns.c (maybe_resize_hash_table): Output message when growing the
132 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
134 * alloc.c (allocate_string_data): Remove dead code.
135 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
136 avoid GCC warning about unused macro.
138 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
140 * alloc.c (allocate_string): Omit intervals initialization.
141 * alloc.c (make_uninit_multibyte_string): Initialize intervals
142 as in make_pure_string and make_pure_c_string.
144 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
146 * alloc.c (allocate_string): Fix last change.
148 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
150 * alloc.c (allocate_string): Remove two redundant calls
151 to memset, add explicit initialization where appropriate.
153 2012-06-27 Glenn Morris <rgm@gnu.org>
155 * lisp.mk (lisp): Remove paths.elc.
157 2012-06-27 Chong Yidong <cyd@gnu.org>
159 * doc.c (Fsubstitute_command_keys): Fix punctuation.
161 2012-06-26 John Wiegley <johnw@newartisans.com>
163 * unexmacosx.c (copy_data_segment): Add two section names used
164 on Mac OS X Lion: __mod_init_func and __mod_term_func.
166 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
167 when building with Clang.
169 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
171 * eval.c (Fapply): Allow calling it with a single argument.
173 2012-06-26 Eli Zaretskii <eliz@gnu.org>
175 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
176 _stricmp and _strnicmp.
177 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
179 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
181 * alloc.c (allocate_window): Zero out non-Lisp part of newly
183 (allocate_process): Likewise for new process.
184 (allocate_terminal): Change to use offsetof.
185 (allocate_frame): Likewise.
186 * frame.c (make_frame): Omit redundant initialization.
187 * window.c (make_parent_window): Use memset.
188 (make_window): Omit redundant initialization.
189 * process.c (make_process): Omit redundant initialization.
190 * terminal.c (create_terminal): Likewise.
192 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
194 * term.c (delete_tty): Remove redundant call to memset.
196 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
198 * alloc.c: Remove build_string.
199 * lisp.h: Define build_string as static inline. This provides
200 a better opportunity to optimize away calls to strlen when the
201 function is called with compile-time constant argument.
202 * image.c (imagemagick_error): Convert to build_string.
203 * w32proc.c (sys_spawnve): Likewise.
204 * xterm.c (x_term_init): Likewise.
206 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
208 Use sprintf return value instead of invoking strlen on result.
209 In the old days this wasn't portable, since some sprintf
210 implementations returned char *. But they died out years ago and
211 Emacs already assumes sprintf returns int.
212 Similarly for float_to_string.
213 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
214 * ccl.c (ccl_driver):
215 * character.c (string_escape_byte8):
216 * data.c (Fnumber_to_string):
218 * print.c (print_object):
219 * xdisp.c (message_dolog):
220 * xfns.c (syms_of_xfns):
221 Use sprintf or float_to_string result to avoid need to call strlen.
222 * data.c (Fnumber_to_string):
223 Use make_unibyte_string, since the string must be ASCII.
224 * lisp.h, print.c (float_to_string): Now returns int length.
225 * term.c (produce_glyphless_glyph):
226 Use sprintf result rather than recomputing it.
228 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
229 * Makefile.in (ALL_CFLAGS):
230 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
231 * gmalloc.c, regex.c: Include <config.h> unconditionally.
233 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
235 * dispextern.h (xstrcasecmp): Define to library function
236 strcasecmp if available.
237 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
239 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
241 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
242 Avoid comma operator.
243 * menu.c (push_submenu_start, push_submenu_end)
244 (push_left_right_boundary, push_menu_pane): Likewise.
245 * msdos.c (dos_rawgetc): Likewise.
247 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
249 * xfns.c (xic_create_fontsetname): Remove redundant calls
252 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
254 * gtkutil.c (get_utf8_string): Remove redundant assignment.
255 sprintf already null-terminates its output.
257 * xfns.c (x_window): Remove redundant cast.
259 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
261 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
262 `const char *' to `char *' to avoid compiler warning.
264 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
266 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
267 instead of truncating it to 63 (admittedly a generous limit).
269 * process.c: Fix spelling and caps in comments.
271 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
273 * emacs.c (setpgrp): Remove definition, unused.
274 * sysdep.c (setpgrp): Remove definition, not used in this file.
276 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
278 * makefile.w32-in: Update dependencies.
280 2012-06-24 Eli Zaretskii <eliz@gnu.org>
282 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
283 (SYSTIME_H): Add nt/inc/sys/time.h.
285 * systime.h [WINDOWSNT]: Include sys/time.h.
287 * s/ms-w32.h (struct timespec): Definition moved from
288 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
290 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
292 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
293 * buffer.h (buffer_slot_type_mismatch):
294 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
295 * eval.c (unwind_to_catch):
296 * image.c (my_png_error, my_error_exit):
297 * keyboard.c (quit_throw_to_read_char, user_error)
298 (Fexit_recursive_edit, Fabort_recursive_edit):
299 * lisp.h (die, args_out_of_range, args_out_of_range_3)
300 (wrong_type_argument, buffer_overflow, __executable_start)
301 (memory_full, buffer_memory_full, string_overflow, Fthrow)
302 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
303 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
305 (child_setup) [!DOS_NT]:
306 * lread.c (end_of_file_error, invalid_syntax):
307 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
308 * puresize.h (pure_write_error):
309 * search.c (matcher_overflow):
310 * sound.c (sound_perror, alsa_sound_perror):
311 * sysdep.c, syssignal.h (croak):
312 * term.c (maybe_fatal, vfatal):
313 * textprop.c (text_read_only):
314 * undo.c (user_error):
315 * unexmacosx.c (unexec_error):
316 * xterm.c (x_ins_del_lines, x_delete_glyphs):
317 Use _Noreturn rather than NO_RETURN.
318 No need for separate decl merely because of _Noreturn.
319 * sound.c (sound_warning, parse_sound):
320 Remove unnecessary forward decls.
322 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
324 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
325 * lisp.h (WAIT_READING_MAX): New macro.
326 * dispnew.c (Fsleep_for, sit_for):
327 * keyboard.c (kbd_buffer_get_event):
328 * process.c (Faccept_process_output):
329 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
330 This improves on the previous patch, which introduced a bug
331 when time_t is unsigned and as wide as intmax_t.
332 See <http://bugs.gnu.org/9000#51>.
334 2012-06-23 Eli Zaretskii <eliz@gnu.org>
336 * dispnew.c (sit_for, Fsleep_for):
337 * keyboard.c (kbd_buffer_get_event):
338 * process.c (Faccept_process_output): Avoid compiler warnings when
339 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
341 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
343 * makefile.w32-in: Update dependencies.
345 * w32.c (ltime): Add return type and declare static.
346 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
348 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
350 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
351 Privately reported by Herbert J. Skuhra.
352 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
354 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
355 not make_lisp_timeval, when the argument is of type EMACS_TIME.
357 2012-06-23 Eli Zaretskii <eliz@gnu.org>
359 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
360 last argument of make_unibyte_string.
362 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
363 language ID in the event parameters.
365 * w32term.c (w32_read_socket): Put the new keyboard codepage into
366 event.code, not the obscure "character set ID".
368 2012-06-23 Chong Yidong <cyd@gnu.org>
370 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
372 2012-06-23 Eli Zaretskii <eliz@gnu.org>
374 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
375 * w32.c (fdutimens): New function.
377 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
379 * s/ms-w32.h (pselect): Redirect to sys_select.
381 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
383 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
384 in the logic of incrementing and decrementing the value of
385 use_relocatable_buffers.
387 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
389 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
390 Privately reported by Herbert J. Skuhra.
391 [__FreeBSD__]: Remove "*/" typo after "#include".
392 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
393 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
394 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
395 Don't assume EMACS_TIME and struct timeval are the same type.
397 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
399 Support higher-resolution time stamps (Bug#9000).
400 The time stamps are only nanosecond-resolution at the C level,
401 since that's the best that any real-world system supports now.
402 But they are picosecond-resolution at the Lisp level, as that's
403 easy, and leaves room for future OS improvements.
405 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
408 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
409 Don't get current time unless it's needed.
411 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
412 now provides it if it's absent.
413 (start_atimer): Port to higher-res time stamps.
414 Check for time stamp overflow. Don't get current time more
415 often than is needed.
417 * buffer.h (struct buffer): Buffer modtime now has high resolution.
418 Include systime.h, not time.h.
419 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
421 * dired.c: Include stat-time.h.
422 (Ffile-attributes): File times now have higher resolution.
424 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
425 (struct image): Timestamp now has higher resolution.
427 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
428 has at least microseconds now. All uses removed.
429 (update_frame, update_single_window, update_window, update_frame_1)
430 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
432 * editfns.c (time_overflow): Now extern.
433 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
434 (float-time, Fformat_time_string, Fcurrent_time_string)
435 (Fcurrent_time_zone): Accept and generate higher-resolution
437 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
438 (decode_time_components, lisp_seconds_argument): New functions.
439 (make_time): Now static.
440 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
441 Report an error if the time is invalid, rather than having the caller
444 * fileio.c: Include <stat-time.h>
445 (Fcopy_file): Copy higher-resolution time stamps.
446 Prefer to set the time stamp via a file descriptor if that works.
447 (Fset_file_times, Finsert_file_contents, Fwrite_region)
448 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
449 (Fvisited_file_modtime, Fset_visited_file_modtime):
450 Support higher-resolution time stamps.
452 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
454 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
456 * image.c (prepare_image_for_display, clear_image_cache)
457 (lookup_image): Port to higer-resolution time stamps.
459 * keyboard.c (start_polling, bind_polling_period):
460 Check for time stamp overflow.
461 (read_char, kbd_buffer_get_event, timer_start_idle)
462 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
463 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
464 Port to higher-resolution time stamps. Do not assume time_t is signed.
465 (decode_timer): New function. Timers are now vectors of length 9,
466 not 8, to accommodate the picosecond component.
467 (timer_check_2): Use it.
469 * nsterm.m (select_timeout, timeval_subtract): Remove.
470 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
471 as they're a bit more accurate and handle overflow better.
472 (ns_select): Change prototype to be compatible with pselect.
473 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
474 * nsterm.h (ns_select): Adjust prototype.
476 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
477 us-resolution time stamps.
478 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
480 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
482 * lisp.h (time_overflow): New decl.
483 (wait_reading_process_output): First arg is now intmax_t, not int,
484 to accommodate larger waits.
486 * process.h (struct Lisp_Process.read_output_delay):
487 Now counts nanoseconds, not microseconds.
488 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
490 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
491 (wait_reading_process_output):
492 Port to ns-resolution time stamps.
493 (Faccept_process_output, wait_reading_process_output):
494 Check for time stamp overflow. Do not assume time_t is signed.
495 (select_wrapper): Remove; we now use pselect.
496 (Fprocess_attributes): Now generates ns-resolution time stamps.
498 * sysdep.c: Include utimens.h. Don't include utime.h
499 or worry about struct utimbuf; gnulib does that for us now.
500 (gettimeofday): Remove; gnulib provides a substitute.
501 (make_timeval): New function.
502 (set_file_times): Now sets ns-resolution time stamps.
503 New arg FD; all uses changed.
504 (time_from_jiffies, ltime_from_jiffies, get_up_time)
505 (system_process_attributes):
506 Now returns ns-resolution time stamp. All uses changed.
507 Check for time stamp overflow.
509 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
510 provides a substitute now.
512 * systime.h: Include timespec.h rather than sys/time.h and time.h,
513 since it guarantees struct timespec.
514 (EMACS_TIME): Now struct timespec, so that we can support
515 ns-resolution time stamps.
516 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
517 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
518 (EMACS_USECS): Remove.
519 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
520 so multiply the arg by 1000 before storing it.
521 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
523 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
524 Port to ns-resolution time stamps.
525 (EMACS_TIME_NEG_P): Remove; replaced by....
526 (EMACS_TIME_SIGN): New macro.
527 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
528 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
529 (set_file_times, make_time, lisp_time_argument): Adjust signature.
530 (make_timeval, make_lisp_time, decode_time_components): New decls.
531 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
532 that it mishandled time_t overflow. You can't compare by subtracting!
533 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
534 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
536 * term.c: Include <sys/time.h>.
537 (timeval_to_Time): New function, for proper overflow wraparound.
538 (term_mouse_position, term_mouse_click): Use it.
540 * undo.c (record_first_change): Support higher-resolution time stamps
542 (Fprimitive_undo): Use them when restoring time stamps.
544 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
545 (w32_get_internal_run_time):
546 Port to higher-resolution Emacs time stamps.
547 (ltime): Now accepts single 64-bit integer, as that's more convenient
550 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
552 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
553 for compatibility with pselect. Support ns-resolution time stamps.
555 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
557 * xselect.c (wait_for_property_change, x_get_foreign_selection):
558 Check for time stamp overflow, and support ns-resolution time stamps.
560 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
561 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
562 (timeval_subtract): Remove; no longer needed.
563 (XTflash, XTring_bell, x_wait_for_event):
564 Port to ns-resolution time stamps. Don't assume time_t is signed.
566 2012-06-22 Chong Yidong <cyd@gnu.org>
568 * xdisp.c (x_consider_frame_title): Revert last change.
570 2012-06-22 Eli Zaretskii <eliz@gnu.org>
572 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
573 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
574 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
575 staticidx goes up to 1597 out of 1600 = 0x640.)
577 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
579 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
580 Otherwise, the umask might be mistakenly 0 while handling input signals.
582 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
584 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
586 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
588 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
589 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
590 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
591 access to `contents' member of Lisp_Vector objects with AREF and ASET
594 2012-06-19 Chong Yidong <cyd@gnu.org>
596 * frame.c (delete_frame): When selecting a frame on a different
597 text terminal, do not alter the terminal's top-frame.
599 * xdisp.c (format_mode_line_unwind_data): Record the target
600 frame's selected window and its terminal's top-frame.
601 (unwind_format_mode_line): Restore them.
602 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
604 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
605 since tty frames can be explicitly named.
606 (prepare_menu_bars): Likewise.
608 * term.c (Ftty_top_frame): New function.
610 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
612 Port byte-code-meter to modern targets.
613 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
614 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
615 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
616 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
617 (METER_1, METER_2): Simplify.
619 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
621 * data.c (Fdefalias): Return `symbol' (bug#11686).
623 2012-06-18 Martin Rudalics <rudalics@gmx.at>
625 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
626 gets killed during executing of this function (Bug#11665).
627 Try to always return Qt when the buffer has been actually killed.
628 (Vkill_buffer_query_functions): In doc-string say that functions
629 run by this hook should not change the current buffer.
631 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
633 Fix recently-introduced process.c problems found by static checking.
634 * process.c (write_queue_push, write_queue_pop, send_process):
635 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
636 (write_queue_pop): Fix pointer signedness problem.
637 (send_process): Remove unused local.
639 2012-06-17 Chong Yidong <cyd@gnu.org>
641 * xdisp.c (redisplay_internal): No need to redisplay terminal
642 frames that are not on top.
644 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
646 * process.c (make_process): Initialize write_queue.
647 (write_queue_push, write_queue_pop): New functions.
648 (send_process): Use them to maintain correct ordering of process
651 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
653 * lisp.h (eassert): Assume C89 or later.
654 This removes the need for CHECK.
655 (CHECK): Remove. Its comments about always evaluating its
656 argument were confusing, as 'eassert' typically does not evaluate
659 * coding.c (produce_chars): Use ptrdiff_t, not int.
661 * xterm.c (x_draw_underwave): Check for integer overflow.
662 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
664 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
666 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
667 referenced (Bug#11583).
669 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
671 Implement wave-style variant of underlining.
672 * dispextern.h (face_underline_type): New enum.
673 (face): Add field for underline type.
674 * nsterm.m (ns_draw_underwave): New function.
675 (ns_draw_text_decoration): Use it.
676 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
678 (x_draw_glyph_string): Use them.
679 * xfaces.c (Qline, Qwave): New Lisp objects.
680 (check_lface_attrs, merge_face_ref)
681 (Finternal_set_lisp_face_attribute, realize_x_face):
682 Handle wave-style underline face attributes.
683 * xterm.c (x_draw_underwave): New function.
684 (x_draw_glyph_string): Use it.
686 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
688 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
689 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
690 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
691 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
692 ($(BLD)/w32select.$(O)): Update dependencies.
694 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
696 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
697 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
698 * character.c (_fetch_multibyte_char_p): Remove.
699 * alloc.c: Include "character.h" before "buffer.h".
701 * buffer.c: Likewise.
702 * bytecode.c: Likewise.
703 * callint.c: Likewise.
704 * callproc.c: Likewise.
705 * casefiddle.c: Likewise.
706 * casetab.c: Likewise.
707 * category.c: Likewise.
709 * coding.c: Likewise.
710 * composite.c: Likewise.
712 * dispnew.c: Likewise.
714 * dosfns.c: Likewise.
715 * editfns.c: Likewise.
717 * fileio.c: Likewise.
718 * filelock.c: Likewise.
720 * fontset.c: Likewise.
721 * fringe.c: Likewise.
722 * indent.c: Likewise.
723 * insdel.c: Likewise.
724 * intervals.c: Likewise.
725 * keyboard.c: Likewise.
726 * keymap.c: Likewise.
728 * macros.c: Likewise.
729 * marker.c: Likewise.
730 * minibuf.c: Likewise.
732 * nsmenu.m: Likewise.
734 * process.c: Likewise.
736 * region-cache.c: Likewise.
737 * search.c: Likewise.
738 * syntax.c: Likewise.
740 * textprop.c: Likewise.
742 * unexsol.c: Likewise.
743 * w16select.c: Likewise.
744 * w32fns.c: Likewise.
745 * w32menu.c: Likewise.
746 * window.c: Likewise.
751 * xselect.c: Likewise.
753 2012-06-16 Eli Zaretskii <eliz@gnu.org>
755 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
756 If all the glyphs of the glyph row came from strings, and we have no
757 cursor positioning clues, put the cursor on the first glyph of the
759 (handle_face_prop): Use chunk-relative overlay string index when
760 indexing into it->string_overlays array. (Bug#11653)
761 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
762 the rightmost. (Bug#11720)
764 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
766 * category.h (CHAR_HAS_CATEGORY): Define as inline.
767 (CATEGORY_MEMBER): Enforce 1/0 value.
768 * category.c (_temp_category_set): Remove.
770 2012-06-16 Eli Zaretskii <eliz@gnu.org>
772 * window.c (Fdelete_other_windows_internal)
773 (Fdelete_window_internal): Don't access frame's mouse highlight
774 info of the initial frame. (Bug#11677)
776 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
778 * .gdbinit (xgetint): Fix recently-introduced paren typo.
779 Assume USE_2_TAGS_FOR_INTS.
780 (xreload): Adjust $tagmask width to match recent lisp.h change.
782 Simplify lisp.h in minor ways that should not affect code.
783 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
784 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
785 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
786 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
787 (INTTYPEBITS): New macro, for clarity.
788 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
789 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
790 Simplify now that USE_LSB_TAG is always defined.
791 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
792 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
794 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
796 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
798 2012-06-13 Glenn Morris <rgm@gnu.org>
800 * s/bsd-common.h (BSD4_3):
801 * s/usg5-4-common.h (USG5_4): No longer define; unused.
803 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
805 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
808 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
810 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
811 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
812 * alloc.c (widen_to_Lisp_Object): Remove.
813 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
814 * frame.c (delete_frame): Remove outdated comment.
815 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
817 (Fw32_unregister_hot_key): Likewise.
818 (Fw32_toggle_lock_key): Likewise.
819 * w32menu.c (add_menu_item): Likewise.
820 (w32_menu_display_help): Use XIL instead of checking
822 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
823 (init_heap): Likewise.
824 * w32term.c (w32_read_socket): Update comment.
826 2012-06-13 Glenn Morris <rgm@gnu.org>
828 * s/usg5-4-common.h, src/s/unixware.h:
829 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
831 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
833 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
835 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
836 * alloc.c (make_number) [!defined make_number]:
837 Remove, as lisp.h always defines this now.
838 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
839 (roundup_size): Verify that it is a power of 2.
840 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
841 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
842 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
843 -DUSE_LSB_TAG=0, to override the automatically-selected default.
844 USE_LSB_TAG now is always defined to be either 0 or 1.
846 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
847 code works fine either way, and efficiency is not a concern here,
848 as the union type is for debugging, not for production.
849 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
850 Use an inline function on all platforms when using the union type,
851 since this is simpler and 'static inline' can be used portably
853 (LISP_INITIALLY_ZERO): New macro.
854 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
855 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
857 2012-06-12 Glenn Morris <rgm@gnu.org>
859 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
861 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
863 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
864 Move BROKEN_SIGIO to configure.
866 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
867 Move NO_TERMIO to configure.
869 2012-06-12 Chong Yidong <cyd@gnu.org>
871 * image.c (imagemagick_load_image): Use MagickFlattenImage if
872 MagickMergeImageLayers is undefined. Use pixel pusher loop if
873 MagickExportImagePixels is undefined.
875 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
877 * image.c (imagemagick_load_image): Remove unused label.
879 2012-06-11 Glenn Morris <rgm@gnu.org>
881 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
882 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
883 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
884 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
886 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
888 * alloc.c (make_byte_code): New function.
889 (Fmake_byte_code): Use it. Don't purify here.
890 * lread.c (read1): Use it as well to avoid extra allocation.
892 2012-06-11 Chong Yidong <cyd@gnu.org>
894 * image.c (imagemagick_load_image): Implement transparency.
896 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
898 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
899 account for preceding backslashes. (Bug#11663)
901 2012-06-09 Chong Yidong <cyd@gnu.org>
903 * term.c: Support italics in capable terminals (Bug#9652).
904 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
905 (turn_on_face): Output using TS_enter_italic_mode if available.
906 Don't handle unused blinking and alt-charset cases.
907 (turn_off_face): Handle italic case; discard unused tty_blinking_p
908 and tty_alt_charset_p cases.
909 (tty_capable_p, init_tty): Support italics.
911 * termchar.h (struct tty_display_info): Add field for italics.
912 Remove unused blink field.
914 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
917 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
918 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
919 tty_alt_charset_p. Add tty_italic_p.
921 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
923 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
924 dbus_type_is_basic if available.
925 (xd_extract_signed, xd_extract_unsigned): Rename from
926 extract_signed and extract_unsigned, respectively. Adapt callers.
928 2012-06-09 Chong Yidong <cyd@gnu.org>
930 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
932 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
935 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
937 * xdisp.c (vmessage): Treat frame message as multibyte.
938 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
939 would generate the diagnostic "Making \302\247 buffer-local while
942 2012-06-08 Eli Zaretskii <eliz@gnu.org>
944 * dispnew.c (showing_window_margins_p): Undo last change, which
945 was done due to an inadvertent commit.
946 (adjust_frame_glyphs_for_frame_redisplay): Do call
947 showing_window_margins_p.
949 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
951 * eval.c (Fmake_var_non_special): New primitive.
952 (syms_of_eval): Defsubr it.
953 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
955 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
957 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
958 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
960 2012-06-08 Eli Zaretskii <eliz@gnu.org>
962 * alloc.c (allocate_vectorlike): Fix last change.
964 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
966 Block-based vector allocation of small vectors.
967 * lisp.h (struct vectorlike_header): New field `nbytes',
968 adjust comment accordingly.
969 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
970 to denote vector blocks. Adjust users (live_vector_p,
971 mark_maybe_pointer, valid_lisp_object_p) accordingly.
972 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
973 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
974 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
975 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
976 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
977 (roundup_size): New constant.
978 (struct vector_block): New data type.
979 (vector_blocks, vector_free_lists, zero_vector): New variables.
980 (all_vectors): Rename to `large_vectors'.
981 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
982 (sweep_vectors): New functions.
983 (allocate_vectorlike): Return `zero_vector' as the only vector of
984 0 items. Allocate new vector from block if vector size is less than
985 or equal to VBLOCK_BYTES_MAX.
986 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
987 (init_alloc_once): Add call to init_vectors.
989 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
991 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
993 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
995 * doprnt.c (doprnt): Truncate multibyte char correctly.
996 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
997 would mishandle a string argument "Xc" if X was a multibyte
998 character of length 2: it would truncate after X's first byte
999 rather than including all of X.
1001 2012-06-06 Chong Yidong <cyd@gnu.org>
1003 * buffer.c (word_wrap): Doc fix.
1005 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1007 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1009 2012-06-03 Glenn Morris <rgm@gnu.org>
1011 * xdisp.c (tool-bar-style): Doc fix.
1013 2012-06-03 Ulrich Müller <ulm@gentoo.org>
1015 * Makefile.in (PAXCTL): Define.
1016 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1017 binary via PaX flags if the paxctl utility is available.
1018 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1019 Restore PaX flags to their default. (Bug#11398)
1021 2012-06-03 Chong Yidong <cyd@gnu.org>
1023 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1026 2012-06-03 Chong Yidong <cyd@gnu.org>
1028 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1029 (note_mode_line_or_margin_highlight): If there is no help echo,
1030 use mode-line-default-help-echo. Handle the case where the mouse
1031 position is past the end of the mode line string.
1033 * buffer.c (buffer_local_value_1): New function, split from
1034 Fbuffer_local_value; can return Qunbound.
1035 (Fbuffer_local_value): Use it.
1036 (Vmode_line_format): Docstring tweaks.
1038 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1040 * sysdep.c (system_process_attributes): Improve comment.
1042 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1044 * keyboard.c: Export real-this-command to Elisp.
1045 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1046 and DEFVAR it. Update all users.
1048 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1050 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1052 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1053 Convert pctcpu and pctmem to Lisp float properly.
1054 Let the compiler fold better, as 100.0/0x8000 is exact.
1056 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1058 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1061 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1063 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1065 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1067 For a 'struct window', replace some Lisp_Object fields to
1068 bitfields where appropriate, remove unused fields.
1069 * window.h (struct window): Remove unused 'last_mark_x' and
1070 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1071 change it's type from Lisp_Object to bitfield.
1072 Change type of 'force_start', 'optional_new_start',
1073 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1074 fields from Lisp_Object to bitfield. Adjust users accordingly.
1076 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1078 Pacify gcc -Wdouble-precision when using Xaw.
1079 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1080 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1081 Use 'float' consistently, rather than 'float' in most places
1082 and 'double' in a couple of places.
1084 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1086 * xdisp.c (handle_stop): Detect whether we have overlay strings
1087 loaded by testing it->current.overlay_string_index to be
1088 non-negative, instead of checking whether n_overlay_strings is
1089 positive. (Bug#11587)
1091 2012-05-31 Chong Yidong <cyd@gnu.org>
1093 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1095 * doc.c (Fsubstitute_command_keys): Doc fix.
1097 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1099 * search.c (search_buffer): Remove calls to
1100 r_alloc_inhibit_buffer_relocation, as it is now called by
1101 maybe_unify_char, which was the cause of relocation of buffer text
1104 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1106 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1107 for the duration of call to load_charset, to avoid problems with
1108 callers of maybe_unify_char that access buffer text through C
1111 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1112 decrement the inhibition flag, instead of just setting or
1115 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1117 Remove obsolete '#define static' cruft.
1118 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1119 This #undef was "temporary" in 2000; it is no longer needed
1120 now that '#define static' has gone away.
1121 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1122 (gray_bitmap_bits): Remove; no longer needed.
1123 All uses replaced with definiens.
1124 * xterm.c: Include "bitmaps/gray.xbm".
1126 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1128 Clean up __executable_start, monstartup when --enable-profiling.
1129 The following changes affect the code only when profiling.
1130 * dispnew.c (__executable_start): Rename from safe_bcopy.
1131 Define only on platforms that need it.
1132 * emacs.c: Include <sys/gmon.h> when profiling.
1133 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1134 (__executable_start): Remove decl, since lisp.h does it now.
1135 (safe_bcopy): Remove decl; no longer has that name.
1136 (main): Coalesce #if into single bit of code, for simplicity.
1137 Cast pointers to uintptr_t, since standard libraries want integers
1139 * lisp.h (__executable_start): New decl.
1141 2012-05-31 Glenn Morris <rgm@gnu.org>
1143 * image.c (Fimagemagick_types): Doc fix.
1145 2012-05-30 Jim Meyering <meyering@redhat.com>
1147 * callproc.c (Fcall_process_region): Include directory component
1148 in mkstemp error message (Bug#11586).
1150 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1152 * alloc.c, lisp.h (make_pure_vector): Now static.
1154 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1156 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1157 Move to byte-run.el.
1158 (Fautoload): Do the hash-doc more carefully.
1159 * data.c (Fdefalias): Purify definition, except for keymaps.
1160 (Qdefun): Move from eval.c.
1161 * lisp.h (Qdefun): Remove.
1162 * lread.c (read1): Tiny simplification.
1164 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
1166 Do not create empty overlays with the evaporate property (Bug#9642).
1167 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1168 Bug#9642, but explicitly check that the buffer the overlay would
1169 be moved to is live and rearrange lines to make sure that errors
1170 will not put the overlay in an inconsistent state.
1171 (Fdelete_overlay): Cosmetics.
1173 2012-05-28 Eli Zaretskii <eliz@gnu.org>
1175 * w32term.c (my_bring_window_to_top): New function.
1176 (x_raise_frame): Use handle returned by DeferWindowPos, which
1177 could be different from the original one.
1178 Call my_bring_window_to_top instead of my_set_foreground_window.
1181 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1182 by calling BringWindowToTop.
1184 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1185 (WM_EMACS_END): Increase by one.
1187 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1189 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1190 This avoids undefined behavior that might cause the eassert
1191 to not catch an out-of-range value.
1193 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
1195 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1196 Update dependencies.
1198 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1200 * bidi.c (bidi_mirror_char): Fix last change.
1202 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1204 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1205 when referring to sectname field in printf format.
1207 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1209 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1210 Only r_alloc_inhibit_buffer_relocation needed to be added;
1211 the others were already declared.
1213 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1214 before checking whether it's out of range. Put the check inside
1216 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1218 2012-05-27 Ken Brown <kbrown@cornell.edu>
1220 * callproc.c (Fcall_process): Restore a line that was accidentally
1221 commented out in the 2011-02-13 change (bug#11547).
1223 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1225 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1226 defined on ralloc.c.
1228 * buffer.c [REL_ALLOC]: Remove prototypes of
1229 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1230 they are now on lisp.h.
1232 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1234 * search.c (search_buffer): Use it to inhibit relocation of buffer
1235 text while re_search_2 is doing its job, because re_search_2 is
1236 passed C pointers to buffer text. (Bug#11519)
1238 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1241 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1242 state after an additional call to move_it_in_display_line_to, keep
1243 the values of it->max_ascent and it->max_descent found for the
1245 (pos_visible_p): Revert the comparison against bottom_y to what it
1246 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1249 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1251 Fix coding-related core dumps with gcc -ftrapv.
1252 The code was computing A - B, where A and B are pointers, and B is
1253 random garbage. This can lead to core dumps on platforms that
1254 have special pointer registers, and it also leads to core dumps on
1255 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1256 A - B only when B is initialized properly.
1257 * coding.c (coding_set_source, coding_set_destination): Return void.
1258 (coding_change_source, coding_change_destinations): New functions,
1259 with the old behaviors of coding_set_source and coding_set_destination.
1260 All callers that need an offset changed to use these new functions.
1262 2012-05-26 Glenn Morris <rgm@gnu.org>
1264 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1266 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1268 Extend mouse support on W32 text-mode console.
1269 * xdisp.c (draw_row_with_mouse_face):
1270 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
1272 * w32console.c: Include window.h.
1273 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1275 (initialize_w32_display): Initialize mouse-highlight data.
1277 * w32inevt.c: Include termchar.h and window.h.
1278 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1279 moves, call note_mouse_highlight. If help_echo changed, call
1280 gen_help_event to produce help-echo message in the echo area.
1281 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1284 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1286 * lread.c (read1): Simplify slightly to avoid an overflow warning
1287 with GCC 4.7.0 on x86-64.
1289 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1291 * bidi.c (bidi_mirror_char): Revert last change: an int is
1292 definitely wide enough here.
1294 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
1296 Fix integer width and related bugs (Bug#9874).
1297 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
1298 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1299 (string_bytes, check_sblock, allocate_string_data):
1300 (compact_small_strings, Fmake_bool_vector, make_string)
1301 (make_unibyte_string, make_multibyte_string)
1302 (make_string_from_bytes, make_specified_string)
1303 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1304 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1306 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1307 (allocate_pseudovector):
1308 Use int, not EMACS_INT, where int is wide enough.
1309 (inhibit_garbage_collection, Fgarbage_collect):
1310 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1311 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1312 int might not be wide enough.
1313 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1314 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1315 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1316 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1317 (bidi_level_of_next_char, bidi_move_to_visually_next):
1318 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1319 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1320 (Fkill_buffer, Fset_buffer_major_mode)
1321 (advance_to_char_boundary, Fbuffer_swap_text)
1322 (Fset_buffer_multibyte, overlays_at, overlays_in)
1323 (overlay_touches_p, struct sortvec, record_overlay_string)
1324 (overlay_strings, recenter_overlay_lists)
1325 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1326 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1327 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1328 (Foverlay_recenter, last_overlay_modification_hooks_used)
1329 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1330 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1331 (validate_region): Omit unnecessary test for b <= e,
1332 since that's guaranteed by the previous test.
1333 (adjust_overlays_for_delete): Avoid pos + length overflow.
1334 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1335 (report_overlay_modification):
1336 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1337 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1338 Omit pointer cast, which isn't needed anyway, and doesn't work
1339 after the EMACS_INT -> ptrdiff_t change.
1340 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
1341 * buffer.h: Adjust decls to match defn changes elsewhere.
1342 (struct buffer_text, struct buffer):
1343 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1344 Use EMACS_INT, not int, where int might not be wide enough.
1345 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1346 not int, to avoid needless 32-bit limit on 64-bit hosts.
1347 (exec_byte_code): Use tighter memory-full test, one that checks
1348 for alloca overflow. Don't compute the address of the object just
1349 before an array, as that's not portable. Use EMACS_INT, not
1350 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
1351 * callint.c (Fcall_interactively):
1352 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1353 * callproc.c (call_process_kill, Fcall_process):
1354 Don't assume pid_t fits into an Emacs fixnum.
1355 (call_process_cleanup, Fcall_process, child_setup):
1356 Don't assume pid_t fits into int.
1357 (call_process_cleanup, Fcall_process, delete_temp_file)
1358 (Fcall_process_region):
1359 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1360 (Fcall_process): Simplify handling of volatile integers.
1361 Use int, not EMACS_INT, where int will do.
1362 * casefiddle.c (casify_object, casify_region, operate_on_word)
1363 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1364 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1365 (casify_object): Avoid integer overflow when overallocating buffer.
1366 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
1367 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
1368 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1369 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1370 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1371 integers are now checked earlier. All uses replaced with XINT.
1373 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1374 For CCL_MapSingle, check that content and value are in int range.
1375 (ccl_driver, Fregister_code_conversion_map):
1376 Check that Vcode_version_map_vector is a vector.
1377 (resolve_symbol_ccl_program): Check that vector header is in range.
1378 Always copy the vector, so that we can check its contents reliably
1379 now rather than having to recheck each instruction as it's being
1380 executed. Check that vector words fit in 'int'.
1381 (ccl_get_compiled_code, Fregister_ccl_program)
1382 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1383 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1384 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1385 contents are in range.
1386 (Fccl_execute_on_string): Check that status is in range.
1387 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1388 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1389 Accept and return EMACS_INT, not int, because callers can pass values
1391 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1392 (multibyte_chars_in_text, parse_str_as_multibyte)
1393 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1394 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1395 (string_escape_byte8, Fget_byte):
1396 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1397 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
1398 avoid mishandling large integers.
1399 * character.h: Adjust decls to match defn changes elsewhere.
1400 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1401 (Ffind_charset_region):
1402 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1403 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1404 (load_charset_map_from_vector, Fdefine_charset_internal):
1405 Don't assume fixnum fits in int.
1406 (load_charset_map_from_vector, Fmap_charset_chars):
1407 Remove now-unnecessary CHECK_NATNUMs.
1408 (Fdefine_charset_internal): Check ranges here, more carefully.
1409 Don't rely on undefined behavior with signed left shift overflow.
1410 Don't assume unsigned int fits into fixnum, or that fixnum fits
1411 into unsigned int. Don't require max_code to be a valid fixnum;
1412 that's not true for gb10830 4-byte on a 32-bit host. Allow
1413 invalid_code to be a cons, for the same reason. Require code_offset
1414 to be a character. Avoid int overflow if max_char is close
1416 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1417 this is intended anyway and avoids some undefined behavior.
1418 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1419 INDEX_TO_CODE_POINT, as that's what it expects.
1420 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
1421 * charset.h (DECODE_CHAR): Return int, not unsigned;
1422 this is what was intended anyway, and it avoids undefined behavior.
1423 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1424 integer-overflow issues.
1425 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1426 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1427 where the argument is EMACS_INT, and this behavior is not intended.
1428 * chartab.c (Fmake_char_table, Fset_char_table_range)
1429 (uniprop_get_decoder, uniprop_get_encoder):
1430 Don't assume fixnum fits in int.
1431 * cmds.c (move_point): New function, that does the gist of
1432 Fforward_char and Fbackward_char, but does so while checking
1433 for integer overflow more accurately.
1434 (Fforward_char, Fbackward_char): Use it.
1435 (Fforward_line, Fend_of_line, internal_self_insert)
1436 (internal_self_insert):
1437 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1438 Fix a FIXME, by checking for integer overflow when calculating
1439 target_clm and actual_clm.
1440 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
1441 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
1442 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1443 (coding_alloc_by_making_gap, alloc_destination)
1444 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1445 (encode_coding_utf_16, detect_coding_emacs_mule)
1446 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1447 (detect_coding_iso_2022, decode_coding_iso_2022)
1448 (encode_invocation_designation, encode_designation_at_bol)
1449 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1450 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1451 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1452 (encode_coding_ccl, encode_coding_raw_text)
1453 (detect_coding_charset, decode_coding_charset)
1454 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1455 (produce_composition, produce_charset, produce_annotation)
1456 (decode_coding, handle_composition_annotation)
1457 (handle_charset_annotation, consume_chars, decode_coding_gap)
1458 (decode_coding_object, encode_coding_object, detect_coding_system)
1459 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1460 (code_convert_region, code_convert_string)
1461 (Fdefine_coding_system_internal)
1462 (coding_set_source, coding_set_destination):
1463 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1464 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1465 (Fdefine_coding_system_internal):
1466 Don't assume fixnums fit in int.
1467 (decode_coding_gap, decode_coding_object, encode_coding_object)
1468 (Fread_coding_system, Fdetect_coding_region)
1469 (Funencodable_char_position, Fcheck_coding_systems_region)
1470 (get_translation, handle_composition_annotation, consume_chars):
1471 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1472 (consume_chars): Rewrite to not calculate an address outside buffer.
1473 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
1474 Don't access memory outside of the args array.
1475 (Fdefine_coding_system_internal): Check for charset-id overflow.
1476 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1477 result of ENCODE_CHAR.
1478 * coding.h: Adjust decls to match defn changes elsewhere.
1479 (struct coding_system):
1480 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1481 * composite.c (get_composition_id, find_composition)
1482 (run_composition_function, update_compositions)
1483 (compose_text, composition_gstring_put_cache)
1484 (composition_gstring_p, composition_gstring_width)
1485 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1486 (composition_compute_stop_pos, composition_reseat_it)
1487 (composition_update_it, struct position_record)
1488 (find_automatic_composition, composition_adjust_point)
1489 (Fcomposition_get_gstring, Ffind_composition_internal):
1490 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1491 (update_compositions):
1492 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1493 * composite.h: Adjust decls to match defn changes elsewhere.
1494 (struct composition):
1495 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1496 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1497 Do not attempt to compute the address of the object just before a
1498 buffer; this is not portable.
1500 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1501 (Faset): Use int, not EMACS_INT, where int is wide enough.
1502 (Fstring_to_number): Don't assume fixnums fit in int.
1503 (Frem): Don't assume arg is nonnegative.
1504 * dbusbind.c (xd_append_arg): Check for integers out of range.
1505 (Fdbus_call_method): Don't overflow the timeout int.
1506 (extract_signed, extract_unsigned): New functions.
1507 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1508 (xd_get_connection_references): Return ptrdiff_t, not int.
1510 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1511 (xd_read_message_1):
1512 Use int, not unsigned, where the dbus API uses int.
1513 (Fdbus_message_internal): Don't overflow mtype.
1514 (syms_of_dbusbind): Allocate right-sized buffer for integers.
1515 * dired.c (directory_files_internal, file_name_completion, scmp)
1516 (file_name_completion_stat):
1517 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1518 (file_name_completion): Don't overflow matchcount.
1519 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1520 * dispextern.h: Adjust decls to match defn changes elsewhere.
1521 (struct text_pos, struct glyph, struct bidi_saved_info)
1522 (struct bidi_string_data, struct bidi_it, struct composition_it)
1524 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1525 (struct display_pos, struct composition_it, struct it):
1526 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1527 * dispnew.c (increment_matrix_positions)
1528 (increment_row_positions, mode_line_string)
1529 (marginal_area_string):
1530 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1531 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
1532 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1533 (duration_to_sec_usec): New function, to check for overflow better.
1534 (Fsleep_for, sit_for): Use it.
1535 * doc.c (get_doc_string, store_function_docstring):
1536 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1537 (get_doc_string, Fsnarf_documentation):
1538 Use int, not EMACS_INT, where int is wide enough.
1540 Use SAFE_ALLOCA, not alloca.
1541 Check for overflow when converting EMACS_INT to off_t.
1542 * doprnt.c (doprnt):
1543 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1544 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1545 Don't assume uid_t fits into fixnum.
1546 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1547 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1548 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1549 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1550 (general_insert_function)
1551 (Finsert_char, make_buffer_string, make_buffer_string_both)
1552 (update_buffer_properties, Fbuffer_substring)
1553 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1554 (Fsubst_char_in_region, check_translation)
1555 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1556 (transpose_markers, Ftranspose_regions):
1557 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1558 (clip_to_bounds): Move to lisp.h as an inline function).
1559 (Fconstrain_to_field): Don't assume integers are nonnegative.
1560 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1561 (Fsubst_char_in_region, Fsave_restriction):
1562 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1563 (Femacs_pid): Don't assume pid_t fits into fixnum.
1564 (lo_time): Use int, not EMACS_INT, when int suffices.
1565 (lisp_time_argument): Check for usec out of range.
1566 (Fencode_time): Don't assume fixnum fits in int.
1567 (Fuser_login_name, Fuser_full_name): Signal an error
1568 if a uid argument is out of range, rather than relying on
1570 (Fformat_time_string): Remove now-unnecessary check.
1571 lisp_time_argument checks for out-of-range usec now.
1572 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
1573 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1574 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1575 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1576 (init_cmdargs, Fdump_emacs):
1577 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1578 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1579 the bottom (typically) 32 bits of the fixnum.
1580 * eval.c (specpdl_size, call_debugger):
1581 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1582 (when_entered_debugger, Fbacktrace_debug):
1583 Don't assume fixnum can fit in int.
1584 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1585 the object just before a buffer; this is not portable.
1586 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1587 (grow_specpdl, unbind_to):
1588 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1589 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1590 (grow_specpdl): Simplify allocation by using xpalloc.
1591 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
1592 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1593 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1594 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1595 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1597 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1598 (Fcopy_file, non_regular_nbytes, read_non_regular)
1599 (Finsert_file_contents):
1600 Use int, not EMACS_INT, where int is wide enough.
1601 (READ_BUF_SIZE): Verify that it fits in int.
1602 (Finsert_file_contents): Check that counts are in proper range,
1603 rather than assuming fixnums fit into ptrdiff_t etc.
1604 Don't assume fixnums fit into int.
1605 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
1606 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1607 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
1608 (string_char_to_byte, string_byte_to_char)
1609 (string_make_multibyte, string_to_multibyte)
1610 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1611 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1612 (substring_both, Fdelete, internal_equal, Ffillarray)
1613 (Fclear_string, mapcar1)
1614 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1615 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1616 (larger_vector, make_hash_table, maybe_resize_hash_table)
1617 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1618 (Fmaphash, secure_hash):
1619 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1620 (concat): Check for string index and length overflow.
1621 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1623 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1624 (larger_vector): New API (vec, incr_min, size_max) replaces old
1625 one (vec, new_size, init). This catches size overflow.
1626 INIT was removed because it was always Qnil.
1627 All callers changed.
1628 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1629 the upper bound on a hash table index size.
1630 (make_hash_table, maybe_resize_hash_table): Use it.
1631 (secure_hash): Computer start_byte and end_byte only after
1632 they're known to be in ptrdiff_t range.
1633 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1634 (Ffont_get_glyphs, Ffont_at):
1635 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1636 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1637 (Flist_fonts, Fopen_font):
1638 Don't assume fixnum can fit in int.
1639 (check_gstring): Don't assume index can fit in int.
1640 (font_match_p): Check that fixnum is a character, not a nonnegative
1641 fixnum, since the later code needs to stuff it into an int.
1642 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1643 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1644 conversion overflow issues.
1645 (Fopen_font): Check for integer out of range.
1646 (Ffont_get_glyphs): Don't assume index can fit in int.
1647 * font.h: Adjust decls to match defn changes elsewhere.
1648 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1650 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1651 printmax_t, where ptrdiff_t is wide enough.
1652 (Finternal_char_font):
1653 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1654 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1655 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1656 (Fset_frame_position, x_set_frame_parameters)
1657 (x_set_line_spacing, x_set_border_width)
1658 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1659 Check that fixnums are in proper range for system types.
1660 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1661 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1662 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1663 Use SAFE_ALLOCA_LISP, not alloca.
1664 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1665 intptr_t is wide enough.
1666 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1667 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1668 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1669 Check for fixnum out of range.
1670 * ftfont.c (ftfont_list): Don't assume index fits in int.
1671 Check that fixnums are in proper range for system types.
1672 (ftfont_shape_by_flt):
1673 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1674 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1675 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1676 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1677 Check that fixnums are in proper range for system types.
1678 * gnutls.h: Adjust decls to match defn changes elsewhere.
1679 * gtkutil.c (xg_dialog_run):
1680 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1681 (update_frame_tool_bar):
1682 Check that fixnums are in proper range for system types.
1683 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
1684 (lookup_image): Check that fixnums are in range for system types.
1685 * indent.c (last_known_column, last_known_column_point):
1686 (current_column_bol_cache):
1687 (skip_invisible, current_column, check_display_width):
1688 (check_display_width, scan_for_column, current_column_1)
1689 (Findent_to, Fcurrent_indentation, position_indentation)
1690 (indented_beyond_p, Fmove_to_column, compute_motion):
1691 (Fcompute_motion, Fvertical_motion):
1692 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1693 (last_known_column_modified): Use EMACS_INT, not int.
1694 (check_display_width):
1696 Check that fixnums and floats are in proper range for system types.
1697 (compute_motion): Don't assume index or fixnum fits in int.
1698 (compute_motion, Fcompute_motion):
1699 Use int, not EMACS_INT, when it is wide enough.
1700 (vmotion): Omit local var start_hpos that is always 0; that way
1701 we don't need to worry about overflow in expressions involving it.
1702 * indent.h: Adjust decls to match defn changes elsewhere.
1704 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1705 Use int, not EMACS_INT, where int is wide enough.
1706 Remove unused members ovstring_chars_done and tab_offset;
1708 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1709 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1710 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1711 (make_gap, copy_text, insert, insert_and_inherit)
1712 (insert_before_markers, insert_before_markers_and_inherit)
1713 (insert_1, count_combining_before, count_combining_after)
1714 (insert_1_both, insert_from_string)
1715 (insert_from_string_before_markers, insert_from_string_1)
1716 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1717 (adjust_after_replace, adjust_after_insert, replace_range)
1718 (replace_range_2, del_range, del_range_1, del_range_byte)
1719 (del_range_both, del_range_2, modify_region)
1720 (prepare_to_modify_buffer, signal_before_change)
1721 (signal_after_change, Fcombine_after_change_execute):
1722 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1723 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1724 (balance_an_interval, split_interval_right, split_interval_left)
1725 (find_interval, next_interval, update_interval)
1726 (adjust_intervals_for_insertion, delete_node, delete_interval)
1727 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1728 (static_offset_intervals, offset_intervals)
1729 (merge_interval_right, merge_interval_left, make_new_interval)
1730 (graft_intervals_into_buffer, temp_set_point_both)
1731 (temp_set_point, set_point, adjust_for_invis_intang)
1732 (set_point_both, move_if_not_intangible, get_property_and_range)
1733 (get_local_map, copy_intervals, copy_intervals_to_string)
1734 (compare_string_intervals, set_intervals_multibyte_1):
1735 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1736 * intervals.h: Adjust decls to match defn changes elsewhere.
1738 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1739 * keyboard.c (this_command_key_count, this_single_command_key_start)
1740 (before_command_key_count, before_command_echo_length, echo_now)
1741 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1742 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1743 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1744 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1745 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1746 (last_non_minibuf_size, last_point_position, echo_truncate)
1747 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1748 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1749 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1750 (stuff_buffered_input):
1751 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1752 (last_auto_save, command_loop_1, read_char):
1753 Use EMACS_INT, not int, to avoid integer overflow.
1754 (record_char): Avoid overflow in total_keys computation.
1755 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1756 * keyboard.h: Adjust decls to match defn changes elsewhere.
1757 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1758 (Fkey_description, Fdescribe_vector, Flookup_key):
1759 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1760 (click_position): New function, to check that positions are in range.
1761 (Fcurrent_active_maps):
1763 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1764 (Faccessible_keymaps, Fkey_description):
1765 (preferred_sequence_p):
1766 Don't assume fixnum can fit into int.
1767 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1768 Check for integer overflow in size calculations.
1769 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1770 avoid mishandling large integers.
1771 * lisp.h: Adjust decls to match defn changes elsewhere.
1772 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1773 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1774 (struct Lisp_Marker):
1775 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1776 (clip_to_bounds): Now an inline function, moved here from editfns.c.
1777 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1778 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1779 All callers changed.
1780 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1781 Assume the arg has valid form, since it always does.
1782 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1783 unsigned integer system type.
1784 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1785 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1786 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1787 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1788 (duration_to_sec_usec): New decl.
1789 * lread.c (read_from_string_index, read_from_string_index_byte)
1790 (read_from_string_limit, readchar, unreadchar, openp)
1791 (read_internal_start, read1, oblookup):
1792 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1793 (Fload, readevalloop, Feval_buffer, Feval_region):
1794 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1795 (openp): Check for out-of-range argument to 'access'.
1796 (read1): Use int, not EMACS_INT, where int is wide enough.
1797 Don't assume fixnum fits into int.
1798 Fix off-by-one error that can read outside a buffer.
1799 (read_filtered_event): Use duration_to_sec_usec
1800 to do proper overflow checking on durations.
1801 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1802 in size calculation.
1803 (Fexecute_kbd_macro):
1804 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1805 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1806 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1807 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1808 (set_marker_both, set_marker_restricted_both, marker_position)
1809 (marker_byte_position, Fbuffer_has_markers_at):
1810 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1811 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
1812 * menu.c (ensure_menu_items): Rename from grow_menu_items.
1813 It now merely ensures that the menu is large enough, without
1814 necessarily growing it, as this avoids some integer overflow issues.
1815 All callers changed.
1816 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1817 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1818 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1819 Use SAFE_ALLOCA_LISP, not alloca.
1820 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1821 to EMACS_INT. Check that fixnums are in proper range for system types.
1822 * minibuf.c (minibuf_prompt_width, string_to_object)
1823 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1824 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1825 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1826 (get_minibuffer, read_minibuf_unwind):
1827 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1828 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1829 this simplifies overflow checking. All callers changed.
1830 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1832 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1833 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1834 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1835 Check that fixnums are in proper range for system types.
1836 (Fx_create_frame, Fx_show_tip):
1837 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1838 * nsfont.m (ns_findfonts, nsfont_list_family):
1839 Don't assume fixnum fits in long.
1840 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1841 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1842 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1844 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
1845 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1846 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1847 (PRINTDECLARE, PRINTPREPARE):
1848 (strout, print_string):
1849 (print, print_preprocess, print_check_string_charset_prop)
1851 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1853 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1854 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1855 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
1856 (printchar, strout): Use xpalloc to catch size calculation overflow.
1857 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
1858 (print_error_message): Use SAFE_ALLOCA, not alloca.
1859 (print_object): Use int, not EMACS_INT, where int is wide enough.
1860 (print_depth, new_backquote_output, print_number_index):
1861 Use ptrdiff_t, not int, where int might not be wide enough.
1862 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1863 (Fset_process_window_size, Fformat_network_address)
1864 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
1866 Check that fixnums are in proper range for system types.
1867 (Fsignal_process): Simplify by avoiding a goto.
1868 Check for process-ids out of pid_t range rather than relying on
1870 (process_tick, update_tick): Use EMACS_INT, not int.
1871 (Fformat_network_address, read_process_output, send_process)
1872 (Fprocess_send_region, status_notify):
1873 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1874 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1875 (wait_reading_process_output, read_process_output, exec_sentinel):
1876 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1877 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1878 (Faccept_process_output): Use duration_to_sec_usec to do proper
1879 overflow checking on durations.
1880 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1881 Don't assume pid_t fits in int.
1882 * process.h (struct Lisp_Process): Members tick and update_tick
1883 are now of type EMACS_INT, not int.
1884 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1885 configured --with-wide-int.
1886 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1887 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1888 * search.c (looking_at_1, string_match_1):
1889 (fast_string_match, fast_c_string_match_ignore_case)
1890 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1891 (scan_newline, find_before_next_newline, search_command)
1892 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1893 (set_search_regs, wordify):
1896 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1897 (string_match_1, search_buffer, set_search_regs):
1899 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1900 (wordify): Check for overflow in size calculation.
1901 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1902 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1903 Check that fixnums are in proper range for system types.
1904 * sound.c (struct sound_device)
1905 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1906 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1907 (Fplay_sound_internal):
1908 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1909 * syntax.c (struct lisp_parse_state, find_start_modiff)
1910 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1911 (Fparse_partial_sexp):
1912 Don't assume fixnums can fit in int.
1913 (struct lisp_parse_state, find_start_pos, find_start_value)
1914 (find_start_value_byte, find_start_begv)
1915 (update_syntax_table, char_quoted, dec_bytepos)
1916 (find_defun_start, prev_char_comend_first, back_comment):
1917 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1918 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1919 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1920 (Finternal_describe_syntax_value): Check that match_lisp is a
1921 character, not an integer, since the code stuffs it into int.
1922 (scan_words, scan_sexps_forward):
1923 Check that fixnums are in proper range for system types.
1925 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1926 (scan_sexps_forward):
1927 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1928 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1929 * syntax.h: Adjust decls to match defn changes elsewhere.
1930 (struct gl_state_s):
1931 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1932 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1933 MOST_POSITIVE_FIXNUM.
1934 * sysdep.c (wait_for_termination_1, wait_for_termination)
1935 (interruptible_wait_for_termination, mkdir):
1936 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1937 (emacs_read, emacs_write):
1938 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1939 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1940 and double all fit in int.
1941 * term.c (set_tty_color_mode):
1942 Check that fixnums are in proper range for system types.
1943 * termhooks.h (struct input_event):
1944 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1945 * textprop.c (validate_interval_range, interval_of)
1946 (Fadd_text_properties, set_text_properties_1)
1947 (Fremove_text_properties, Fremove_list_of_text_properties)
1948 (Ftext_property_any, Ftext_property_not_all)
1949 (copy_text_properties, text_property_list, extend_property_ranges)
1950 (verify_interval_modification):
1951 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1952 (Fnext_single_char_property_change)
1953 (Fprevious_single_char_property_change):
1954 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1955 (copy_text_properties):
1956 Check for integer overflow in index calculation.
1957 * undo.c (last_boundary_position, record_point, record_insert)
1958 (record_delete, record_marker_adjustment, record_change)
1959 (record_property_change):
1960 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1961 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1962 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1963 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1964 (Fx_hide_tip, Fx_file_dialog):
1965 * w32menu.c (set_frame_menubar):
1966 Use ptrdiff_t, not int, for consistency with rest of code.
1967 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1968 (select_window, Fdelete_other_windows_internal)
1969 (window_scroll_pixel_based, window_scroll_line_based)
1970 (Frecenter, Fset_window_configuration):
1971 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1972 (Fset_window_hscroll, run_window_configuration_change_hook)
1973 (set_window_buffer, temp_output_buffer_show, scroll_command)
1974 (Fscroll_other_window, Frecenter):
1975 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1976 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1977 Don't assume fixnum fits in int.
1978 (Fset_window_scroll_bars):
1979 Check that fixnums are in proper range for system types.
1980 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1981 (string_pos, c_string_pos, number_of_chars, init_iterator)
1982 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1983 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1984 (compute_display_string_end, handle_face_prop)
1985 (face_before_or_after_it_pos, handle_invisible_prop)
1986 (handle_display_prop, handle_display_spec, handle_single_display_spec)
1987 (display_prop_intangible_p, string_buffer_position_lim)
1988 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1989 (get_overlay_strings_1, get_overlay_strings)
1990 (iterate_out_of_display_property, forward_to_next_line_start)
1991 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1992 (get_next_display_element, set_iterator_to_next)
1993 (get_visually_first_element, compute_stop_pos_backwards)
1994 (handle_stop_backwards, next_element_from_buffer)
1995 (move_it_in_display_line_to, move_it_in_display_line)
1996 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1997 (add_to_log, message_dolog, message_log_check_duplicate)
1998 (message2, message2_nolog, message3, message3_nolog
1999 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2000 (current_message_1, truncate_echo_area, truncate_message_1)
2001 (set_message, set_message_1, store_mode_line_noprop)
2002 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2003 (text_outside_line_unchanged_p, check_point_in_composition)
2004 (reconsider_clip_changes)
2005 (redisplay_internal, set_cursor_from_row, try_scrolling)
2006 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2007 (redisplay_window, find_last_unchanged_at_beg_row)
2008 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2009 (trailing_whitespace_p, find_row_edges, display_line)
2010 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2011 (display_mode_element, store_mode_line_string)
2012 (pint2str, pint2hrstr, decode_mode_spec)
2013 (display_count_lines, display_string, draw_glyphs)
2014 (x_produce_glyphs, x_insert_glyphs)
2015 (rows_from_pos_range, mouse_face_from_buffer_pos)
2016 (fast_find_string_pos, mouse_face_from_string_pos)
2017 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2018 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2019 (safe_call, init_from_display_pos, handle_fontified_prop)
2020 (handle_single_display_spec, load_overlay_strings)
2021 (with_echo_area_buffer, setup_echo_area_for_printing)
2022 (display_echo_area, echo_area_display)
2023 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2024 (update_tool_bar, hscroll_window_tree, redisplay_internal)
2025 (redisplay_window, dump_glyph_row, display_mode_line)
2026 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
2027 (handle_display_spec, display_prop_string_p):
2028 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2029 (handle_single_display_spec, build_desired_tool_bar_string)
2030 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2031 (get_specified_cursor_type):
2032 Check that fixnums are in proper range for system types.
2033 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2034 (Flookup_image_map):
2035 Don't assume fixnums fit in int.
2036 (compare_overlay_entries):
2037 Avoid mishandling comparisons due to subtraction overflow.
2038 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2039 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2040 (handle_tool_bar_click):
2041 Use int, not unsigned, since we prefer signed and the signedness
2042 doesn't matter here.
2043 (get_next_display_element, next_element_from_display_vector):
2044 Use int, not EMACS_INT, when int is wide enough.
2045 (start_hourglass): Use duration_to_sec_usec to do proper
2046 overflow checking on durations.
2047 * xfaces.c (Fbitmap_spec_p):
2048 Check that fixnums are in proper range for system types.
2049 (compare_fonts_by_sort_order):
2050 Avoid mishandling comparisons due to subtraction overflow.
2051 (Fx_family_fonts, realize_basic_faces):
2052 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2054 Don't assume fixnum fits in int.
2055 Use SAFE_ALLOCA_LISP, not alloca.
2056 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2057 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2058 (face_at_buffer_position, face_for_overlay_string)
2059 (face_at_string_position):
2060 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2061 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2062 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2064 Check that fixnums are in proper range for system types.
2065 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2066 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2067 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2068 (Fx_change_window_property): Don't assume fixnums fit in int.
2069 * xfont.c (xfont_chars_supported):
2070 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2071 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2072 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2073 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2074 * xml.c (parse_region):
2075 * xrdb.c (magic_file_p):
2076 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2077 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2078 (x_get_local_selection, x_reply_selection_request)
2079 (x_handle_selection_request, wait_for_property_change):
2080 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2081 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2082 short is wide enough.
2083 (x_send_client_event): Don't assume fixnum fits in int.
2084 * xterm.c (x_x_to_emacs_modifiers):
2085 Don't assume EMACS_INT overflows nicely into int.
2086 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2088 (handle_one_xevent): NATNUMP can eval its arg twice.
2089 (x_connection_closed):
2090 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2091 * xterm.h: Adjust decls to match defn changes elsewhere.
2092 (struct scroll_bar): Use struct vectorlike_header
2093 rather than rolling our own approximation.
2094 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2096 2012-05-25 Glenn Morris <rgm@gnu.org>
2098 * lisp.mk (lisp): Update for more files being compiled now.
2100 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2102 * lread.c: Remove `read_pure' which makes no difference.
2103 (read_pure): Remove var.
2104 (unreadpure): Remove function.
2105 (readevalloop): Don't call read_list with -1 flag.
2106 (read1, read_vector): Don't test read_pure any more.
2107 (read_list): Simplify.
2109 * fileio.c, character.h: Minor style tweaks.
2111 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2113 * window.h (clip_changed): Remove useless declaration.
2115 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
2117 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2118 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2120 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2123 This directory predates autoconf and is no longer needed nowadays.
2124 Move its few remaining bits of functionality to where they're needed.
2125 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2126 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2127 * m/template.h: Remove.
2128 * Makefile.in (M_FILE): Remove. All uses removed.
2129 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2130 * lisp.h (USE_LSB_TAG):
2131 * mem-limits.h (EXCEEDS_LISP_PTR):
2132 Use VAL_MAX, not VALBITS, in #if.
2133 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2134 (EMACS_UINT): Define unconditionally now.
2135 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2136 (BITS_PER_EMACS_INT): New constants, replacing
2137 what used to be in config.h, but not useful in #if.
2138 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2139 define them any more.
2140 (VAL_MAX): New macro.
2142 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2143 BITS_PER_EMACS_INT, in #if.
2144 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2145 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2146 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2147 * s/ms-w32.h (DATA_START):
2148 Move here from removed file m/intel386.h.
2149 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2150 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2152 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2154 Assume C89 or later.
2155 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2156 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2158 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2159 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2160 * textprop.c, tparam.c (NULL): Remove.
2161 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2162 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2163 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2164 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2165 * xterm.c (input_signal_count): Assume volatile works.
2167 2012-05-21 Ken Brown <kbrown@cornell.edu>
2169 * xgselect.c (xg_select): Fix first argument in call to 'select'
2172 2012-05-20 Ken Brown <kbrown@cornell.edu>
2174 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
2175 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
2177 2012-05-19 Ken Brown <kbrown@cornell.edu>
2179 * xfns.c (x_in_use): Remove `static' qualifier.
2180 * xterm.h (x_in_use): Declare.
2181 * xgselect.c: Include xterm.h.
2182 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2183 and `display_arg' (bug#9754).
2185 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2187 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2189 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2190 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2192 2012-05-18 Eli Zaretskii <eliz@gnu.org>
2194 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2196 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2197 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2199 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2200 reference to image_cache->refcount.
2201 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2203 2012-05-17 Juri Linkov <juri@jurta.org>
2205 * search.c (Fword_search_regexp, Fword_search_backward)
2206 (Fword_search_forward, Fword_search_backward_lax)
2207 (Fword_search_forward_lax): Move functions to isearch.el
2208 (bug#10145, bug#11381).
2210 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2212 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2214 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2216 * lread.c (init_obarray): Declare Qt and Qnil as special.
2218 2012-05-14 Glenn Morris <rgm@gnu.org>
2220 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
2221 Put "libexec" before "bin", for the sake of init_callproc_1.
2223 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2225 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2227 * unexaix.c: Port to more-recent AIX compilers.
2228 (report_error, report_error_1, make_hdr, copy_sym)
2229 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2230 Make arguments const char *, not char *, to avoid violations of C
2231 standard and to fix some AIX warnings reported by Gilles Pion.
2233 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2235 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2236 already have overlays loaded.
2237 (handle_single_display_spec): Before returning without displaying
2238 fringe bitmap, synchronize the bidi iterator with the main display
2239 iterator, by calling iterate_out_of_display_property.
2240 (iterate_out_of_display_property): Detect buffer iteration by
2241 testing that it->string is a Lisp string.
2242 (get_next_display_element): When the current object is exhausted,
2243 and there's something on it->stack, call set_iterator_to_next to
2244 proceed with what's on the stack, instead of returning zero.
2245 (set_iterator_to_next): If called at the end of a Lisp string,
2246 proceed to consider_string_end without incrementing string
2247 position. Don't increment display vector index past the end of
2248 the display vector. (Bug#11417)
2249 (pos_visible_p): Don't report a position visible when move_it_to
2250 stopped at the last line of window, which happens to be scanned
2251 backwards by the bidi iteration. (Bug#11464)
2253 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2255 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2256 and right-margin display specs even if the spec is invalid or we
2257 are on a TTY, and thus unable to display on the fringes.
2258 That's because the text with the property will not be displayed anyway,
2259 so we need to signal to the caller that this is a "replacing"
2260 display spec. This fixes display when the spec is invalid or we
2263 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2265 * unexaix.c (make_hdr): Fix typo in prototype.
2266 This bug broke the build on AIX. Problem reported by Gilles Pion.
2268 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
2270 * keyboard.c (kbd_buffer_get_event): Read special events also in
2271 batch mode. (Bug#11415)
2273 2012-05-12 Glenn Morris <rgm@gnu.org>
2275 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2277 2012-05-12 Eli Zaretskii <eliz@gnu.org>
2279 * lisp.mk (lisp): Add newcomment.elc.
2281 2012-05-12 Glenn Morris <rgm@gnu.org>
2283 * Makefile.in (MKDIR_P): New, set by configure.
2284 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2286 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2288 Remove unused function hourglass_started.
2289 * dispextern.h (hourglass_started):
2290 * w32fns.c (hourglass_started):
2291 * xdisp.c (hourglass_started): Remove.
2293 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
2295 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2296 Update dependencies.
2298 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2300 * xgselect.c (xg_select): Put maxfds+1 into a var.
2301 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2303 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2305 2012-05-10 Dave Abrahams <dave@boostpro.com>
2307 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2308 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2310 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
2312 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2313 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2314 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2315 Initialize xd_registered_buses.
2317 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2319 Untag more efficiently if USE_LSB_TAG.
2320 This is based on a proposal by YAMAMOTO Mitsuharu in
2321 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2322 For an admittedly artificial (nth 8000 longlist) benchmark on
2323 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2324 Emacs's overall text size by 1%.
2325 * lisp.h (XUNTAG): New macro.
2326 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2327 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2328 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2329 * eval.c (Fautoload):
2330 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2331 * frame.h (XFRAME): Use XUNTAG.
2333 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2334 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2335 Remove unportable assumptions about print widths of types like
2337 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2338 intptr_t when converting between pointer and integer, to avoid GCC
2339 warnings about wrong width.
2341 2012-05-09 Eli Zaretskii <eliz@gnu.org>
2343 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2344 stack for each reader_thread, instead of defaulting to 8MB
2345 determined by the linker. This avoids failures in creating
2346 subprocesses on Windows 7, see the discussion in this thread:
2347 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2349 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2351 Fix up display of the *Minibuf-0* buffer in the mini window.
2352 * keyboard.c (read_char): Don't clear the echo area if there's no
2354 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2355 contents of *Minibuf-0*) if there's no message displayed in its stead.
2357 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
2359 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2362 2012-05-06 Chong Yidong <cyd@gnu.org>
2364 * lisp.mk (lisp): Update.
2366 2012-05-05 Jim Meyering <meyering@redhat.com>
2368 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2370 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2372 * data.c (PUT_ERROR): New macro.
2373 (syms_of_data): Use it. Add new error type `user-error'.
2374 * undo.c (user_error): New function.
2375 (Fprimitive_undo): Use it.
2376 * print.c (print_error_message): Adjust print style for `user-error'.
2377 * keyboard.c (user_error): New function.
2378 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2380 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2382 Do not limit current-time-string to years 1000..9999.
2383 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2384 (Fcurrent_time_string): Support any year that is supported by the
2385 underlying localtime representation. Don't use asctime, as it
2386 has undefined behavior for years outside the range -999..9999.
2388 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2390 Fix race conditions involving setenv, gmtime, localtime, asctime.
2391 Without this fix, interrupts could mess up code that uses these
2392 nonreentrant functions, since setting TZ invalidates existing
2393 tm_zone or tzname values, and since most of these functions return
2394 pointers to static storage.
2395 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2396 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2397 Grow the critical sections to include not just invoking
2398 localtime/gmtime, but also accessing these functions' results
2399 including their tm_zone values if any, and any related TZ setting.
2400 (format_time_string): Last arg is now struct tm *, not struct tm **,
2401 so that the struct tm is saved in the critical section.
2402 All callers changed. Simplify allocation of initial buffer, partly
2403 motivated by the fact that memory allocation needs to be outside
2404 the critical section.
2406 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2408 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2409 with RESET_INTERVAL.
2411 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2412 Remove duplicated buffer name initialization.
2414 2012-05-02 Jim Meyering <jim@meyering.net>
2416 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2418 * xfns.c (x_window): Use xstrdup (Bug#11375).
2420 2012-05-02 Eli Zaretskii <eliz@gnu.org>
2422 * xdisp.c (pos_visible_p): If already at a newline from the
2423 display string before the 'while' loop, don't walk back the glyphs
2424 from it3.glyph_row. Solves assertion violation when the display
2425 string begins with a newline (egg.el). (Bug#11367)
2427 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2429 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2432 2012-05-01 Glenn Morris <rgm@gnu.org>
2434 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2435 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2436 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2437 All were removed before 23.1.
2439 * dispnew.c: Remove HAVE_LIBNCURSES test;
2440 it is always true on relevant platforms.
2442 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2443 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2445 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2447 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2449 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2450 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2453 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2455 Do not avoid creating empty evaporating overlays (Bug#9642).
2456 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2457 That is, do not delete an evaporating overlay if it becomes
2458 empty after its bounds are adjusted to fit within its buffer.
2459 This fix caused other problems, and I'm reverting it until we get
2460 to the bottom of them.
2462 2012-04-27 Chong Yidong <cyd@gnu.org>
2464 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2466 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2468 * xdisp.c (pos_visible_p): If the window start position is beyond
2469 ZV, start the display from buffer beginning. Prevents assertion
2470 violation in init_iterator when the minibuffer window is scrolled
2473 * window.c (window_scroll_pixel_based): Likewise.
2475 2012-04-27 Chong Yidong <cyd@gnu.org>
2477 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2479 2012-04-27 Glenn Morris <rgm@gnu.org>
2481 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2482 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2484 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2486 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2487 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
2489 2012-04-26 Eli Zaretskii <eliz@gnu.org>
2491 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2492 display element, check also the underlying string or buffer
2493 character. (Bug#11341)
2495 * w32menu.c: Include w32heap.h.
2496 (add_menu_item): If the call to AppendMenuW (via
2497 unicode_append_menu) fails, disable Unicode menus only if we are
2498 running on Windows 9X/Me.
2500 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2502 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2503 (xgetint): Add missing shift for LSB tags.
2505 2012-04-24 Martin Rudalics <rudalics@gmx.at>
2507 * keyboard.c (read_char): Don't wipe echo area for select window
2508 events: These might get delayed via `mouse-autoselect-window'
2511 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
2513 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2514 manipulation of :loaded-from data.
2516 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
2518 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2519 now a cons (bug#11311).
2521 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2523 Do not create empty overlays with the evaporate property (Bug#9642).
2524 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2525 if it becomes empty after its bounds are adjusted to fit within
2526 its buffer. Without this fix, in a nonempty buffer (let ((o
2527 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2528 yields an empty overlay that has the evaporate property, which is
2529 not supposed to happen.
2531 Fix minor GTK3 problems found by static checking.
2532 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2533 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2534 (struct _EmacsFixedClass, emacs_fixed_get_type):
2535 Move decls here from emacsgtkfixed.h, since they needn't be public.
2536 (emacs_fixed_get_type): Now static.
2537 (emacs_fixed_class_init): Omit unused local.
2538 (emacs_fixed_child_type): Remove; unused.
2539 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2540 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2541 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2542 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2543 (EMACS_FIXED_GET_CLASS): Remove; unused.
2544 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2546 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2547 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2549 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2551 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
2552 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
2553 (__malloc_size_t, __malloc_ptrdiff_t):
2554 Remove. All uses removed, replaced by the definiens if needed,
2555 since we can assume C89 or better now.
2556 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2557 (protect_malloc_state, align, get_contiguous_space)
2558 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2559 (malloc_atfork_handler_child, malloc_enable_thread)
2560 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2561 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2562 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2563 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2564 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2565 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2566 Define using prototypes, not old style.
2567 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2568 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2569 (align): Don't assume that signed integer overflow wraps around.
2570 Omit unused local var.
2571 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2572 (_free_internal_nolock, memalign, mallochook, reallochook):
2573 Omit no-longer-needed casts.
2574 (valloc): Use getpagesize, not __getpagesize.
2575 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2576 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2578 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2580 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
2582 Move functions from C to Lisp. Make non-blocking method calls
2583 the default. Implement further D-Bus standard interfaces.
2585 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2586 (QCdbus_request_name_allow_replacement)
2587 (QCdbus_request_name_replace_existing)
2588 (QCdbus_request_name_do_not_queue)
2589 (QCdbus_request_name_reply_primary_owner)
2590 (QCdbus_request_name_reply_in_queue)
2591 (QCdbus_request_name_reply_exists)
2592 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2593 (QCdbus_registered_serial, QCdbus_registered_method)
2594 (QCdbus_registered_signal): New Lisp objects.
2595 (XD_DEBUG_MESSAGE): Use sizeof.
2596 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2597 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2598 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2599 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2600 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2601 (xd_signature, xd_append_arg): Allow float for integer types.
2602 (xd_get_connection_references): New function.
2603 (xd_get_connection_address): Rename from xd_initialize.
2604 Return cached address.
2605 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2606 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2608 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
2609 Return number of refcounts.
2610 (Fdbus_get_unique_name): Make stronger parameter check.
2611 (Fdbus_message_internal): New defun.
2612 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2613 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2614 (Fdbus_send_signal, Fdbus_register_service)
2615 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2616 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2617 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2618 (Vdbus_compiled_version, Vdbus_runtime_version)
2619 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2620 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2621 (Vdbus_message_type_signal): New defvars.
2622 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2625 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2627 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2628 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2629 Do not assume ptrdiff_t is the same width as 'int'.
2631 * alloc.c: Handle unusual debugging option combinations.
2632 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2633 since the two debugging options are incompatible.
2634 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2636 (mem_init, mem_insert, mem_insert_fixup):
2637 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2638 (NEED_MEM_INSERT): Remove; no longer needed.
2640 2012-04-22 Leo Liu <sdl.web@gmail.com>
2642 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2644 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2646 * sysdep.c [__FreeBSD__]: Minor cleanups.
2647 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2648 Use Emacs indenting style more consistently. Avoid some casts.
2649 Use 'double' consistently rather than mixing 'float' and 'double'.
2651 2012-04-21 Eduard Wiebe <usenet@pusto.de>
2653 * sysdep.c (list_system_processes, system_process_attributes):
2654 Add implementation for FreeBSD (Bug#5243).
2656 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2658 * lisp.mk (lisp): Update.
2660 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2662 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2663 It is never used otherwise.
2665 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2667 * print.c (print_preprocess): Only check print_depth if print-circle
2669 (print_object): Check for cycles even when print-circle is nil and
2670 print-gensym is t, but only check print_depth if print-circle is nil.
2672 2012-04-20 Chong Yidong <cyd@gnu.org>
2674 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2675 set the status to "failed" and ensure that sentinel is run.
2677 2012-04-20 Glenn Morris <rgm@gnu.org>
2679 * process.c (Fset_process_inherit_coding_system_flag)
2680 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
2681 (Fmake_network_process, Fmake_serial_process): Doc fix.
2683 2012-04-20 Eli Zaretskii <eliz@gnu.org>
2685 * xdisp.c (string_buffer_position_lim): Limit starting position to
2687 (set_cursor_from_row): If called for a mode-line or header-line
2688 row, return zero immediately.
2689 (try_cursor_movement): If inside continuation line, don't back up
2690 farther than the first row after the header line, if any.
2691 Don't consider the header-line row as "partially visible", even if
2692 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2694 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2696 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2699 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
2700 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
2702 configure: new option --enable-gcc-warnings (Bug#11207)
2703 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2704 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2705 (ALL_CFLAGS): Use new macros rather than old.
2706 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2707 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2708 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2709 -Wunused-result, -Wunused-variable. This should go away once
2710 the Emacs and Gnulib regex code is merged.
2711 (xmalloc, xrealloc): Now static.
2713 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2715 * dired.c (Fsystem_groups): Remove unused local.
2717 2012-04-17 Glenn Morris <rgm@gnu.org>
2719 * dired.c (Fsystem_users): Doc fix.
2721 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2723 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2724 (syms_of_dired): Add them.
2726 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2728 Fix minor alloc.c problems found by static checking.
2729 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2730 New extern decls, to avoid calling undeclared functions.
2731 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2732 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2733 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2734 (NEED_MEM_INSERT): New macro.
2735 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
2736 Remove one incorrect comment and fix another.
2738 Fix minor ralloc.c problems found by static checking.
2739 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2740 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2741 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2742 (r_alloc_sbrk): Now static.
2744 Improve ralloc.c interface checking.
2745 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2746 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2747 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2748 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2749 [REL_ALLOC]: ... to here, to check interface.
2750 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2751 Remove decls. This fixes an "It stinks!".
2753 * alloc.c (which_symbols): Fix alignment issue / type clash.
2755 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2757 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2758 (struct Lisp_Misc_Any): Likewise.
2759 (struct Lisp_Free): Likewise.
2760 * alloc.c (union aligned_Lisp_Symbol): Define.
2761 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2762 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2763 (union aligned_Lisp_Misc): Define.
2764 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2765 aligned_Lisp_Misc instead of union Lisp_Misc.
2766 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
2768 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2770 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2771 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2772 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2773 * s/netbsd.h, s/sol2-6.h:
2774 Remove definition of GC_MARK_STACK, since the default now works.
2775 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2776 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2777 no longer the default.
2778 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2780 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2782 * lread.c (lisp_file_lexically_bound_p):
2783 Fix hang at ";-*-\n" (bug#11238).
2785 2012-04-14 Eli Zaretskii <eliz@gnu.org>
2787 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2788 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2790 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2792 * nsterm.m (constrainFrameRect): Always constrain when there is only
2793 one screen (Bug#10962).
2795 2012-04-13 Ken Brown <kbrown@cornell.edu>
2797 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2799 2012-04-13 Reuben Thomas <rrt@sc3d.org>
2801 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2803 2012-04-11 Daniel Colascione <dancol@dancol.org>
2805 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2806 against is gone. It's better to use vfork now so that when Cygwin
2807 gains a new, working vfork, we use it automatically (bug#10398).
2809 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2811 * window.c (save_window_save): Obey window-point-insertion-type.
2813 2012-04-11 Glenn Morris <rgm@gnu.org>
2815 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2817 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2819 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2821 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
2823 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2824 (force_quit_count): New var.
2825 (handle_interrupt): Use it.
2827 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
2829 * w32.c (w32_delayed_load): Record the full path of the library
2830 being loaded (bug#10424).
2832 2012-04-09 Glenn Morris <rgm@gnu.org>
2834 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2835 not just in the obarray, before snarfing them. (Bug#11036)
2837 * Makefile.in ($(leimdir)/leim-list.el):
2838 Pass EMACS rather than BUILT_EMACS.
2840 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2842 * process.c (make_process):
2843 * process.h: Add integer `gnutls_handshakes_tried' member to
2846 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2847 Add convenience `GNUTLS_LOG2i' macro.
2849 * gnutls.c (gnutls_log_function2i): Convenience log function.
2850 (emacs_gnutls_read): Use new log functions,
2851 `gnutls_handshakes_tried' process member, and
2852 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2853 attempts per process (connection).
2855 2012-04-09 Chong Yidong <cyd@gnu.org>
2857 * eval.c (Fuser_variable_p, user_variable_p_eh)
2858 (lisp_indirect_variable): Functions deleted.
2859 (Fdefvar): Caller changed.
2861 * callint.c (Finteractive, Fcall_interactively):
2862 * minibuf.c (Fread_variable): Callers changed.
2864 2012-04-09 Eli Zaretskii <eliz@gnu.org>
2866 * xdisp.c (set_cursor_from_row): If the display string appears in
2867 the buffer at position that is closer to point than the position
2868 after the display string, display the cursor on the first glyph of
2869 the display string. Fixes cursor display when a 'display' text
2870 property immediately follows invisible text. (Bug#11094)
2872 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2874 composite.c: use 'double' consistently
2875 * composite.c (get_composition_id): Use 'double' consistently
2876 instead of converting 'float' to 'double' and vice versa; this is
2877 easier to understand and avoids a GCC warning.
2879 2012-04-09 Glenn Morris <rgm@gnu.org>
2881 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2882 preparation for dumping it with emacs. (Bug#4789)
2883 (leimdir): New variable.
2884 ($(leimdir)/leim-list.el): New rule.
2885 (emacs$(EXEEXT)): Depend on leim-list.el.
2887 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2888 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2889 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2891 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2893 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2896 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
2898 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2899 Remove unused local variable.
2901 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2903 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2904 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2905 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2906 objects, as mark_maybe_pointer will catch them otherwise.
2907 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2908 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2910 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2912 Fix typo that broke non-Windows builds.
2913 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2915 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2917 Support building on MS-Windows with libxml2.
2919 * makefile.w32-in (OBJ2): Add xml.$(O).
2920 (GLOBAL_SOURCES): Add xml.c.
2921 ($(BLD)/xml.$(O)): New dependency list.
2923 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2924 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2925 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2926 [!WINDOWSNT]: New macros.
2927 (init_libxml2_functions, libxml2_loaded_p): New functions.
2928 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2929 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2930 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2931 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2933 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2934 Call init_libxml2_functions before calling libxml2 functions.
2935 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2937 * emacs.c: Don't include libxml/parser.h.
2938 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2939 xmlCleanupParser directly.
2941 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2943 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2945 * indent.c (Fvertical_motion): If there is a display string at
2946 point, use it.vpos to compute how many lines to backtrack after
2947 move_it_to point. (Bug#11133)
2949 2012-04-06 Eli Zaretskii <eliz@gnu.org>
2951 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2952 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2953 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2954 macros related to unification of CJK characters. For the details,
2955 see the discussion following the message here:
2956 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2958 2012-04-04 Chong Yidong <cyd@gnu.org>
2960 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2962 2012-04-01 Eli Zaretskii <eliz@gnu.org>
2964 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2965 instead of alloca. (Bug#11138)
2967 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2969 * w32menu.c (is_simple_dialog): Properly check lisp types.
2972 2012-03-31 Eli Zaretskii <eliz@gnu.org>
2974 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2975 position we get to after a call to move_it_to fails the
2976 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2977 only if we wind up in a string from display property. (Bug#11063)
2979 * window.c (Fdelete_other_windows_internal): Invalidate the row
2980 and column information about mouse highlight, so that redisplay
2981 restores it after reallocating the glyph matrices. (Bug#7464)
2983 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2984 string comes from a `display' text property, use the buffer
2985 position of that property as if we actually saw that position in
2987 (move_it_by_lines): Remove the assertion that
2988 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2989 violated when there's a before-string at the beginning of a line.
2992 2012-03-30 Eli Zaretskii <eliz@gnu.org>
2994 * xdisp.c (append_space_for_newline): If the default face was
2995 remapped, use the remapped face for the appended newline.
2996 (extend_face_to_end_of_line): Use the remapped default face for
2997 extending the face to the end of the line.
2998 (display_line): Call extend_face_to_end_of_line when the default
2999 face was remapped. (Bug#11068)
3001 2012-03-29 Eli Zaretskii <eliz@gnu.org>
3003 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3005 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3007 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3009 2012-03-27 Glenn Morris <rgm@gnu.org>
3011 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3014 2012-03-26 Kenichi Handa <handa@m17n.org>
3016 * dispextern.h (struct glyph): Fix previous change. Change the
3017 bit length of glyphless.ch to 25 (Bug#11082).
3019 2012-03-26 Chong Yidong <cyd@gnu.org>
3021 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3022 (command_loop_1): Use it; inhibit selection update for
3023 handle-select-window too (Bug#8996).
3025 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3027 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
3029 2012-03-25 Kenichi Handa <handa@m17n.org>
3031 * dispextern.h (struct glyph): Change the bit length of
3032 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3034 2012-03-24 Eli Zaretskii <eliz@gnu.org>
3036 * s/ms-w32.h (tzname): Include time.h before redirecting to
3037 _tzname. Fixes the MSVC build. (Bug#9960)
3039 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3041 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3044 * xterm.c (XTread_socket): Only modify handling_signal if
3045 !SYNC_INPUT. (Bug#11080)
3047 2012-03-23 Eli Zaretskii <eliz@gnu.org>
3049 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3050 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3051 when fetching a multibyte character consumes more bytes than
3052 CHAR_BYTES returns, due to unification of CJK characters in
3053 string_char. (Bug#11073)
3055 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3057 * process.c (wait_reading_process_output): Handle pty disconnect
3058 by refraining from sending oneself a SIGCHLD (bug#10933).
3060 2012-03-22 Chong Yidong <cyd@gnu.org>
3062 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3064 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
3065 Mark string as coming from a prefix property.
3066 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3067 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3069 2012-03-21 Chong Yidong <cyd@gnu.org>
3071 * xfaces.c (Vface_remapping_alist): Doc fix.
3073 2012-03-20 Eli Zaretskii <eliz@gnu.org>
3075 * w32proc.c (Fw32_set_console_codepage)
3076 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3079 2012-03-20 Chong Yidong <cyd@gnu.org>
3081 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3082 to reflect default non-nil value of redisplay-dont-pause.
3084 2012-03-19 Kenichi Handa <handa@m17n.org>
3086 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3087 it fit in a valid range (Bug#11003).
3089 2012-03-18 Eli Zaretskii <eliz@gnu.org>
3091 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3092 that is not from display property, accept the row as a "cursor
3093 row" if one of the string's character has a non-nil `cursor'
3094 property. Fixes cursor positioning when there are newlines in
3095 overlay strings, e.g. in icomplete.el. (Bug#11035)
3097 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3099 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3101 2012-03-12 Chong Yidong <cyd@gnu.org>
3103 * eval.c (inhibit_lisp_code): Rename from
3104 inhibit_window_configuration_change_hook; move from window.c.
3106 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3107 * window.c (run_window_configuration_change_hook)
3108 (syms_of_window): Callers changed.
3110 2012-03-11 Chong Yidong <cyd@gnu.org>
3112 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3114 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3116 2012-03-10 Chong Yidong <cyd@gnu.org>
3118 * frame.c (other_visible_frames): Don't assume the selected frame
3119 is visible (Bug#10955).
3121 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3123 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3125 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3127 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3128 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3131 2012-03-03 Glenn Morris <rgm@gnu.org>
3133 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
3135 2012-03-02 Eli Zaretskii <eliz@gnu.org>
3137 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3138 position past the first glyph_row that ends at ZV. (Bug#10902)
3139 (redisplay_window, next_element_from_string): Fix typos in
3141 (redisplay_window): Pass to move_it_vertically the margin in
3142 pixels, not in screen lines.
3144 2012-03-02 Glenn Morris <rgm@gnu.org>
3146 * buffer.c (buffer-list-update-hook): Doc fix.
3148 2012-02-29 Eli Zaretskii <eliz@gnu.org>
3150 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3151 push_it before setting up the iterator for the first overlay
3152 string, even if we have an empty string loaded.
3153 (next_overlay_string): If there's an empty string on the iterator
3154 stack, pop the stack. (Bug#10903)
3156 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3158 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3159 Suggested by Stefan Monnier in
3160 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3161 * alloc.c (widen_to_Lisp_Object): New static function.
3162 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3163 and widening them to Lisp_Objects. This would work even if
3164 USE_LSB_TAG is defined and wide integers are used, which might
3165 happen in a future version of Emacs.
3167 2012-02-25 Chong Yidong <cyd@gnu.org>
3169 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3172 * xselect.c (Fx_selection_exists_p): Doc fix.
3173 (x_clipboard_manager_save_all): Print an informative message
3174 before saving to clipboard manager.
3176 2012-02-24 Chong Yidong <cyd@gnu.org>
3178 * keyboard.c (process_special_events): Handle all X selection
3179 requests in kbd_buffer, not just the next one (Bug#8869).
3181 2012-02-23 Chong Yidong <cyd@gnu.org>
3183 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3184 call when setting menu-bar-lines and tool-bar-lines parameters.
3185 (unwind_create_frame_1): New helper function.
3187 * window.c (inhibit_window_configuration_change_hook): New var.
3188 (run_window_configuration_change_hook): Obey it.
3189 (syms_of_window): Initialize it.
3191 2012-02-22 Chong Yidong <cyd@gnu.org>
3193 * xterm.c (x_draw_image_relief): Add missing type check for
3194 Vtool_bar_button_margin (Bug#10743).
3196 2012-02-21 Chong Yidong <cyd@gnu.org>
3198 * fileio.c (Vfile_name_handler_alist): Doc fix.
3200 * buffer.c (Fget_file_buffer): Protect against invalid file
3201 handler return value.
3203 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3205 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3206 when computing $valmask.
3208 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3209 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3210 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3211 It's useless in that case, and it can cause problems on hosts
3212 that allocate halves of EMACS_INT values separately.
3213 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3214 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3215 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3216 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3217 it avoids undefined behavior on hosts where shifting right by more
3218 than the word width has undefined behavior.
3220 2012-02-19 Chong Yidong <cyd@gnu.org>
3222 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3223 (Funhandled_file_name_directory, Ffile_name_as_directory)
3224 (Fdirectory_file_name, Fexpand_file_name)
3225 (Fsubstitute_in_file_name): Protect against invalid file handler
3226 return values (Bug#10845).
3228 2012-02-18 Eli Zaretskii <eliz@gnu.org>
3230 * .gdbinit (pitx): Fix incorrect references to fields of the
3233 2012-02-17 Chong Yidong <cyd@gnu.org>
3235 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3237 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3239 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3240 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3242 2012-02-15 Chong Yidong <cyd@gnu.org>
3244 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3245 marked as special. Also, starting docstrings with * is obsolete.
3247 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3249 * gnutls.c (emacs_gnutls_write): Fix last change.
3251 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3253 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3256 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3258 * keymap.c (Fsingle_key_description): Handle char ranges.
3260 2012-02-12 Chong Yidong <cyd@gnu.org>
3262 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3263 as that creates a dangerous corner case.
3265 * window.c (Fdelete_window_internal): Invalidate the mouse
3266 highlight (Bug#9904).
3268 2012-02-12 Glenn Morris <rgm@gnu.org>
3270 * xselect.c (Fx_own_selection_internal)
3271 (Fx_get_selection_internal, Fx_disown_selection_internal)
3272 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3273 * nsselect.m (Fx_own_selection_internal)
3274 (Fx_disown_selection_internal, Fx_selection_exists_p)
3275 (Fx_selection_owner_p, Fx_get_selection_internal):
3276 Sync docs and argument specs with the xselect.c versions.
3278 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3280 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3282 2012-02-11 Eli Zaretskii <eliz@gnu.org>
3284 * w32select.c (Fx_selection_exists_p): Sync doc string and
3285 argument list with xselect.c. (Bug#10783)
3287 * w16select.c (Fx_selection_exists_p): Sync doc string and
3288 argument list with xselect.c. (Bug#10783)
3290 2012-02-10 Glenn Morris <rgm@gnu.org>
3292 * fns.c (Fsecure_hash): Doc fix.
3294 2012-02-09 Kenichi Handa <handa@m17n.org>
3296 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3298 2012-02-07 Chong Yidong <cyd@gnu.org>
3300 * buffer.c (Fbuffer_local_variables)
3301 (buffer_lisp_local_variables): Handle unbound vars correctly;
3302 don't let Qunbound leak into Lisp.
3304 2012-02-07 Glenn Morris <rgm@gnu.org>
3306 * image.c (Fimagemagick_types): Doc fix.
3308 * image.c (imagemagick-render-type): Change it from a lisp object
3309 to an integer. Move the doc here from the lisp manual.
3310 Treat all values not equal to 0 the same.
3312 2012-02-06 Chong Yidong <cyd@gnu.org>
3314 * doc.c (store_function_docstring): Avoid applying docstring of
3315 alias to base function (Bug#2603).
3317 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3319 * .gdbinit (pp1, pv1): Remove redundant defines.
3322 2012-02-04 Chong Yidong <cyd@gnu.org>
3324 * nsterm.m: Declare a global (Bug#10694).
3326 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3328 * w32.c (get_emacs_configuration_options):
3329 Include --enable-checking, if specified, in the return value.
3331 2012-02-04 Martin Rudalics <rudalics@gmx.at>
3333 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3334 after rounding frame sizes. (Bug#9723)
3336 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3338 * keyboard.c (adjust_point_for_property): Don't position point
3339 before BEGV. (Bug#10696)
3341 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3343 Handle overflow when computing char display width (Bug#9496).
3344 * character.c (char_width): Return EMACS_INT, not int.
3345 (char_width, c_string_width): Check for overflow when
3346 computing the width; this is possible now that individual
3347 characters can have unbounded width. Problem introduced
3348 by merge from Emacs 23 on 2012-01-19.
3350 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
3352 * dbusbind.c (Fdbus_register_method): Mention the return value
3353 :ignore in the docstring.
3355 2012-02-02 Glenn Morris <rgm@gnu.org>
3357 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3359 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3360 Unconditionally set to t. (Bug#10673)
3361 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3362 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3363 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3365 2012-02-02 Kenichi Handa <handa@m17n.org>
3367 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3368 0, do not call append_composite_glyph.
3370 2012-02-02 Kenichi Handa <handa@m17n.org>
3372 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3374 (x_produce_glyphs): If the component of a composition is a null
3375 string, set it->pixel_width to 1 to avoid zero-width glyph.
3377 2012-02-01 Eli Zaretskii <eliz@gnu.org>
3379 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3380 first 2 arguments are identical. This makes inserting large
3381 output from a subprocess an order of magnitude faster on
3382 MS-Windows, where all sbrk'ed memory is always contiguous.
3384 2012-01-31 Glenn Morris <rgm@gnu.org>
3386 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3387 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3388 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3390 2012-01-29 Glenn Morris <rgm@gnu.org>
3392 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3394 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3396 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3398 2012-01-28 Chong Yidong <cyd@gnu.org>
3400 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3402 2012-01-26 Chong Yidong <cyd@gnu.org>
3404 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3406 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3407 repeat counts (Bug#10507).
3409 2012-01-26 Glenn Morris <rgm@gnu.org>
3411 * lread.c (syms_of_lread): Doc fix.
3413 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3415 * coding.c (encode_designation_at_bol): Change return value to
3418 2012-01-25 Chong Yidong <cyd@gnu.org>
3420 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3422 2012-01-21 Chong Yidong <cyd@gnu.org>
3424 * floatfns.c (Fcopysign): Make the second argument non-optional,
3425 since nil is not allowed anyway.
3427 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3429 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3430 (send_process): Likewise.
3432 2012-01-19 Martin Rudalics <rudalics@gmx.at>
3434 * window.c (save_window_save, Fcurrent_window_configuration)
3435 (Vwindow_persistent_parameters): Do not use Qstate.
3436 Rewrite doc-strings.
3438 2012-01-19 Kenichi Handa <handa@m17n.org>
3440 * character.c (char_width): New function.
3441 (Fchar_width, c_string_width, lisp_string_width):
3442 Use char_width (Bug#9496).
3444 2012-01-16 Martin Rudalics <rudalics@gmx.at>
3446 * window.c (Vwindow_persistent_parameters): New variable.
3447 (Fset_window_configuration, save_window_save): Handle persistent
3450 2012-01-14 Eli Zaretskii <eliz@gnu.org>
3452 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3453 thrashing the stack of the thread. (Bug#9087)
3455 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3457 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3459 2012-01-11 Eli Zaretskii <eliz@gnu.org>
3461 * xdisp.c (rows_from_pos_range): Handle the case where the
3462 highlight ends on a newline. (Bug#10464)
3463 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3464 he end column for display of highlight that ends on a newline
3467 2012-01-11 Glenn Morris <rgm@gnu.org>
3469 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3470 from load-path also when installation-directory is nil. (Bug#10208)
3472 2012-01-10 Glenn Morris <rgm@gnu.org>
3474 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3476 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3477 Update template values to be closer to their typical values these days.
3479 2012-01-09 Eli Zaretskii <eliz@gnu.org>
3481 * xdisp.c (rows_from_pos_range): Accept additional argument
3482 DISP_STRING, and accept any glyph in a row whose object is that
3483 string as eligible for mouse highlight. Fixes mouse highlight of
3484 display strings from overlays. (Bug#10464)
3486 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
3488 emacs: fix an auto-save permissions race condition (Bug#10400)
3489 * fileio.c (auto_saving_dir_umask): New static var.
3490 (Fmake_directory_internal): Use it.
3491 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3492 creating the directory. The old code temporarily assigns
3493 too-generous permissions to the directory.
3494 (do_auto_save_eh): Clear it.
3495 (Fdo_auto_save): Catch all errors, not just file errors, so
3496 that the var is always cleared.
3498 2012-01-07 Eli Zaretskii <eliz@gnu.org>
3500 * search.c (scan_buffer): Pass character positions to
3501 know_region_cache, not byte positions. (Bug#6540)
3503 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
3505 * w32.c (sys_rename): Report EXDEV when rename of a directory
3506 fails because the target is on another logical disk. (Bug#10284)
3508 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3510 * xterm.c (x_embed_request_focus): New function.
3512 * xterm.h: Add prototype.
3514 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3516 2012-01-05 Glenn Morris <rgm@gnu.org>
3518 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3520 2012-01-01 Eli Zaretskii <eliz@gnu.org>
3522 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3523 Load gnutls_transport_set_lowat only if GnuTLS version is below
3525 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3526 GnuTLS versions below 2.11.1.
3528 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3530 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3531 to the doc string advising against its use for altering the way
3532 windows are scrolled.
3534 2011-12-28 Kenichi Handa <handa@m17n.org>
3536 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3537 coding-system ASCII compatible only when it does not produce BOM
3538 on encoding (Bug#10383).
3540 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3542 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3544 (create_and_show_popup_menu): Always use menu_position_func for
3547 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3549 * callint.c (Fcall_interactively): Don't truncate prompt string.
3551 2011-12-23 Eli Zaretskii <eliz@gnu.org>
3553 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3554 property that ends at ZV, so that the bidi iteration could be
3555 resumed from there (after widening). (Bug#10360)
3557 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3559 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3561 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3563 * nsterm.m (x_free_frame_resources):
3564 Release f->output_data.ns->miniimage.
3565 (ns_index_color): Fix indentation. Do not retain
3566 color_table->colors[i].
3568 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3571 * nsfns.m (x_set_background_color): Assign return value from
3572 ns_index_color to face-background instead of NSColor*.
3573 (ns_implicitly_set_icon_type): Fix indentation.
3574 Change assignment in for loop to comparison.
3576 * emacs.c (ns_pool): New variable.
3577 (main): Assign ns_pool.
3578 (Fkill_emacs): Call ns_release_autorelease_pool.
3580 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3581 autorelease fdesc, release fdAttrs and tdict.
3582 (ns_get_covering_families): Release charset.
3583 (ns_findfonts): Release NSFontDescriptor created with new.
3584 (ns_uni_to_glyphs): Fix indentation.
3585 (setString): Release attrStr before assigning new value.
3587 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3589 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3591 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3592 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3594 2011-12-18 David Reitter <reitter@cmu.edu>
3596 * nsterm.m (ns_term_init): Subscribe for notifications
3597 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3598 to method trackingNotification in EmacsMenu.
3600 * nsmenu.m (trackingMenu): New variable.
3601 (trackingNotification): New method (from Aquamacs).
3602 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3603 from Aquamacs (Bug#7030).
3605 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3607 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3608 (symbol_to_nsstring): Fix indentation.
3609 (ns_symbol_to_pb): New function.
3610 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3611 (Fns_rotate_cut_buffers_internal): Remove.
3612 (Fns_store_selection_internal): Rename from
3613 Fns_store_cut_buffer_internal.
3614 (ns_get_foreign_selection, Fx_own_selection_internal)
3615 (Fx_disown_selection_internal, Fx_selection_exists_p)
3616 (Fns_get_selection_internal, Fns_store_selection_internal):
3617 Use ns_symbol_to_pb and check if return value is nil.
3618 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3619 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
3620 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3621 renamed to Sns_store_selection_internal.
3622 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3623 and remove this function.
3624 (ns_handle_selection_clear): Remove, never used.
3625 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3628 2011-12-17 Ken Brown <kbrown@cornell.edu>
3630 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3631 GID is unknown (Bug#10257).
3633 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3635 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3636 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3637 which caused a build failure on GNU/Linux IA-64. This problem was
3638 introduced by my 2011-10-07 patch.
3640 2011-12-15 Juri Linkov <juri@jurta.org>
3642 * image.c (imagemagick_error): New function. (Bug#10112)
3643 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3644 Use `imagemagick_error' where ImageMagick functions return
3646 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3649 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3651 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3652 fill background (Bug#8992).
3654 2011-12-13 Martin Rudalics <rudalics@gmx.at>
3656 * window.c (Vwindow_combination_resize)
3657 (Vwindow_combination_limit): Use t instead of non-nil in
3659 (Vrecenter_redisplay): Add first sentence of doc-string on
3661 (Frecenter): Fix doc-string typo.
3663 2011-12-11 Kenichi Handa <handa@m17n.org>
3665 * coding.c (Funencodable_char_position): Pay attention to the
3666 buffer text relocation (Bug#9389).
3668 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3670 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3671 gtk_init (Bug#10100).
3673 2011-12-10 Eli Zaretskii <eliz@gnu.org>
3675 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3676 IT->string is nil. (Bug#10263)
3678 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3680 * nsterm.h (x_free_frame_resources): Declare.
3682 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3683 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3685 * nsterm.h (ns_get_defaults_value): Declare.
3687 * nsterm.m (ns_default): Call ns_get_defaults_value.
3689 2011-12-09 Eli Zaretskii <eliz@gnu.org>
3691 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3694 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3696 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3697 that where the value of an _OBJC_* symbol points to is in the .bss
3698 section (Bug#10240).
3700 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3702 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
3703 after the loop to call ccl_driver at least once (Bug#8619).
3705 2011-12-08 Kenichi Handa <handa@m17n.org>
3707 * ftfont.c (get_adstyle_property): Fix previous change
3710 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
3712 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3713 dirs from the default value of EMACSLOADPATH (bug#10208).
3715 2011-12-07 Glenn Morris <rgm@gnu.org>
3717 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3718 installation and source directories as well. (Bug#10208)
3720 2011-12-06 Chong Yidong <cyd@gnu.org>
3722 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3724 2011-12-06 Glenn Morris <rgm@gnu.org>
3726 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3727 as an error, not just -1. (Bug#10217)
3729 2011-12-05 Chong Yidong <cyd@gnu.org>
3731 * keyboard.c (process_special_events): New function.
3732 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3734 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3736 * coding.c (encode_designation_at_bol): Don't use uninitialized
3737 local variable (Bug#9318).
3739 2011-12-05 Kenichi Handa <handa@m17n.org>
3741 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3742 return Qnil (Bug#8046, Bug#10193).
3744 2011-12-05 Kenichi Handa <handa@m17n.org>
3746 * coding.c (encode_designation_at_bol): New args charbuf_end and
3747 dst. Return the number of produced bytes. Callers changed.
3748 (coding_set_source): Return how many bytes coding->source was
3750 (coding_set_destination): Return how many bytes
3751 coding->destination was relocated.
3752 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
3753 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
3755 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3757 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3758 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3761 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3763 The following changes are to fix Bug#9318.
3765 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
3766 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3767 (encode_coding_iso_2022, encode_coding_sjis)
3768 (encode_coding_big5, encode_coding_charset): Use the above macros.
3770 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
3772 * lisp.h (process_quit_flag): Fix external declaration.
3774 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3776 Don't macro-inline non-performance-critical code.
3777 * eval.c (process_quit_flag): New function.
3778 * lisp.h (QUIT): Use it.
3780 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3782 * nsfns.m (get_geometry_from_preferences): New function.
3783 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3785 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3787 * emacs.c (Qkill_emacs): Define.
3788 (syms_of_emacs): Initialize it.
3789 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3790 Qquit_flag to `kill-emacs' instead.
3791 (quit_throw_to_read_char): Add parameter `from_signal'.
3792 All callers changed. Call Fkill_emacs if requested and safe.
3793 * lisp.h (QUIT): Call Fkill_emacs if requested.
3795 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3797 * widget.c (update_wm_hints): Return if wmshell is null.
3798 (widget_update_wm_size_hints): New function.
3800 * widget.h (widget_update_wm_size_hints): Declare.
3802 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3803 widget_update_wm_size_hints (Bug#10104).
3805 2011-12-03 Eli Zaretskii <eliz@gnu.org>
3807 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3808 before a newline, prepare the bidi iterator for consuming the
3809 newline, and keep the current paragraph direction. (Bug#10183)
3810 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
3812 2011-12-02 Juri Linkov <juri@jurta.org>
3814 * search.c (Fword_search_regexp): New Lisp function created from
3815 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3816 (Fword_search_backward, Fword_search_forward)
3817 (Fword_search_backward_lax, Fword_search_forward_lax):
3818 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3819 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3821 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3823 * fileio.c (Finsert_file_contents): Move after-change-function call
3824 to before the "handled:" label, since all "goto handled" appear in
3825 cases where the *-change-functions have already been properly called
3828 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3830 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3831 waiting for input. (Bug#10169)
3833 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3835 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3836 verifies glyph row's hash code--we have just reallocated the
3837 glyphs, so their contents can be complete garbage. (Bug#10164)
3839 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
3841 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3843 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3845 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3846 attributes are tested _before_ calling verify_row_hash, to protect
3847 against GCC re-ordering of the tests. (Bug#10164)
3849 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3851 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3853 * xterm.c (handle_one_xevent): Only set async_visible and friends
3854 if net_wm_state_hidden_seen is non-zero (Bug#10002)
3855 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
3856 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3858 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3860 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3861 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3862 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3863 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3864 All uses changed to use GCPRO1 etc.
3865 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3866 Revert to old implementation (i.e., before 2011-03-11).
3868 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3870 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3871 of scroll runs so as to avoid assigning disabled bogus rows and
3872 unnecessary graphics copy operations.
3874 2011-11-27 Eli Zaretskii <eliz@gnu.org>
3876 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3877 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3878 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3879 (malloc, free, realloc, calloc): Redirect to e_* only when
3882 * lisp.h (GCTYPEBITS): Move before first use.
3883 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3884 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3885 this macro definition.
3887 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3890 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3892 * gtkutil.c (xg_create_frame_widgets):
3893 Call gtk_window_set_has_resize_grip (FALSE) if that function is
3894 present with Gtk+ 2.0.
3896 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3898 * fileio.c (Finsert_file_contents): Undo previous change; see
3899 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3901 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3903 Rename locals to avoid shadowing.
3904 * fileio.c (Finsert_file_contents):
3905 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3906 * process.c (wait_reading_process_output):
3907 Rename inner 'proc' to 'p' to avoid shadowing.
3908 Indent for consistency with usual Emacs style.
3910 2011-11-25 Eli Zaretskii <eliz@gnu.org>
3912 * xdisp.c (redisplay_window): If cursor row is not fully visible
3913 after recentering, and scroll-conservatively is set to a large
3914 number, scroll window by a few more lines to make the cursor fully
3915 visible and out of scroll-margin. (Bug#10105)
3916 (start_display): Don't move to the next line if the display should
3917 start at a newline that is part of a display vector or an overlay
3920 2011-11-24 Juri Linkov <juri@jurta.org>
3922 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3923 after the `MagickPingImage' call. (Bug#10112)
3925 2011-11-23 Chong Yidong <cyd@gnu.org>
3927 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3929 2011-11-23 Martin Rudalics <rudalics@gmx.at>
3931 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3932 making another buffer current. (Bug#10114)
3934 2011-11-23 Glenn Morris <rgm@gnu.org>
3936 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3938 2011-11-23 Chong Yidong <cyd@gnu.org>
3940 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3941 using it (Bug#5984).
3943 2011-11-22 Eli Zaretskii <eliz@gnu.org>
3945 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3946 and header-lines, as they don't have one computed for them.
3949 * .gdbinit (prow): Make displayed values more self-explaining.
3950 Add row's hash code.
3952 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3954 * process.c (wait_reading_process_output): Fix asynchrounous
3955 GnuTLS socket handling on some versions of the GnuTLS library.
3956 (wait_reading_process_output): Add comment and URL.
3958 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3960 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3962 2011-11-21 Chong Yidong <cyd@gnu.org>
3964 * window.c (Fnext_window, Fprevious_window): Doc fix.
3966 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3968 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3970 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3972 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3974 2011-11-20 Martin Rudalics <rudalics@gmx.at>
3976 * window.c (Fset_window_combination_limit): Rename argument
3978 (Vwindow_combination_limit): Remove "status" from doc-string.
3980 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3982 * m/ibms390.h: Remove.
3983 * m/ibms390x.h: Don't include "ibms390.h".
3985 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3987 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3988 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3990 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3992 * casetab.c (Fset_case_table):
3993 * charset.c (Fcharset_after): Fix typos.
3995 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
3997 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3998 Otherwise, valgrind does not work on some platforms.
3999 Problem reported by Andreas Schwab in
4000 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4001 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4002 is set, removing the need for VIRT_ADDRESS_VARIES.
4003 (PURE_P): Use a more-efficient implementation that needs just one
4004 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4005 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4006 to 4 (xorl, subq, cmpq, setbe).
4007 * alloc.c (pure): Always extern now, since that's the
4008 VIRT_ADDR_VARIES behavior.
4009 (PURE_POINTER_P): Use a single comparison, not two, for
4010 consistency with the new puresize.h.
4011 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4012 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4013 Remove VIRT_ADDR_VARIES no longer needed.
4015 2011-11-19 Eli Zaretskii <eliz@gnu.org>
4017 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4018 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4019 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4020 behave as if the cursor position were at the window margin.
4022 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4023 and the cursor position is out of bounds, behave as if the cursor
4024 position were at the window margin. (Bug#10075)
4026 2011-11-18 Chong Yidong <cyd@gnu.org>
4028 * window.c (Fwindow_combination_limit): Make first argument
4029 non-optional, since it is meaningless for live windows like the
4032 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4034 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4036 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4038 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4039 (graft_intervals_into_buffer): Simplify.
4041 2011-11-18 Eli Zaretskii <eliz@gnu.org>
4043 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4044 hash values of the two rows.
4045 (copy_row_except_pointers): Preserve the used[] arrays and the
4046 hash values of the two rows. (Bug#10035)
4047 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
4049 * xdisp.c (row_hash): New function, body extracted from
4050 compute_line_metrics.
4051 (compute_line_metrics): Call row_hash, instead of computing the
4054 * dispnew.c (verify_row_hash): Call row_hash for computing the
4055 hash code of a row, instead of duplicating code from xdisp.c.
4057 * dispextern.h (row_hash): Add prototype.
4059 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4061 * frame.c (delete_frame): Don't delete the terminal when the last
4062 X frame is closed if emacs is built with GTK toolkit.
4064 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
4066 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4068 2011-11-17 Martin Rudalics <rudalics@gmx.at>
4070 * window.c (Vwindow_splits): Rename to
4071 Vwindow_combination_resize. Suggested by Juri Linkov.
4072 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4075 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
4077 * nsfns.m (Fns_font_name):
4078 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
4080 2011-11-16 Martin Rudalics <rudalics@gmx.at>
4082 * window.h (window): Rename slot "nest" to "combination_limit".
4083 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4084 (Fset_window_nest): Rename to Fset_window_combination_limit.
4085 (Vwindow_nest): Rename to Vwindow_combination_limit.
4086 (recombine_windows, make_parent_window, make_window)
4087 (Fsplit_window_internal, saved_window)
4088 (Fset_window_configuration, save_window_save): Rename all
4089 occurrences of window_nest to window_combination_limit.
4091 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
4093 * image.c (imagemagick_load_image): Fix typo.
4095 2011-11-14 Eli Zaretskii <eliz@gnu.org>
4097 * xdisp.c (display_line): Move the call to
4098 highlight_trailing_whitespace before the call to
4099 compute_line_metrics, since the latter needs to see the final
4100 faces of all the glyphs to compute ROW's hash value.
4101 Fixes assertion violations in row_equal_p. (Bug#10035)
4103 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
4105 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4106 just return (bug#10044).
4108 2011-11-12 Eli Zaretskii <eliz@gnu.org>
4110 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4111 with user-defined heap size. Bump the default size of the temacs
4112 heap to 27MB, to avoid memory warning when running temacs.
4113 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4115 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4116 current_matrix and desired_matrix. (Bug#9990)
4117 (verify_row_hash) [XASSERTS]: New function.
4118 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4119 that the hash value of glyph rows is correct.
4121 2011-11-12 Martin Rudalics <rudalics@gmx.at>
4123 * window.h (window): Remove splits slot.
4124 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4125 (Fdelete_other_windows_internal, make_parent_window)
4126 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4127 (Fset_window_configuration, save_window_save): Don't deal with
4128 split status of windows.
4129 (saved_window): Remove splits slot.
4130 (Vwindow_splits): Rewrite doc-string.
4132 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4134 * xfns.c (unwind_create_frame):
4135 * nsfns.m (unwind_create_frame):
4136 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4137 Vframe_list (Bug#9999).
4139 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4141 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
4143 2011-11-11 Kenichi Handa <handa@m17n.org>
4145 * callproc.c (Fcall_process): Set the member dst_multibyte of
4148 2011-11-11 Johan Bockgård <bojohan@gnu.org>
4150 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4151 avoid a crash (bug#9496).
4153 2011-11-09 Chong Yidong <cyd@gnu.org>
4155 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4156 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4158 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4160 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4162 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4164 Avoid some portability problems by eschewing 'extern inline' functions.
4165 The trivial performance wins aren't worth the portability hassles; see
4166 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4168 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4169 (window_box_width, window_box_left, window_box_left_offset)
4170 (window_box_right, window_box_right_offset): Undo previous change,
4171 by removing the "extern"s.
4172 * intervals.c (adjust_intervals_for_insertion)
4173 (adjust_intervals_for_deletion): Undo previous change,
4174 making these static again.
4175 (offset_intervals, temp_set_point_both, temp_set_point)
4176 (copy_intervals_to_string): No longer inline.
4177 * xdisp.c (window_text_bottom_y, window_box_width)
4178 (window_box_height, window_box_left_offset)
4179 (window_box_right_offset, window_box_left, window_box_right)
4180 (window_box): No longer inline.
4182 2011-11-08 Chong Yidong <cyd@gnu.org>
4184 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
4185 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4186 Signal an error if not a live window.
4187 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4188 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4190 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
4192 * lisp.h (syms_of_abbrev): Remove declaration.
4193 Reported by CHENG Gao <chenggao@royau.me>.
4195 2011-11-07 Eli Zaretskii <eliz@gnu.org>
4197 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4198 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4199 of temacs in GUI mode.
4201 2011-11-07 Martin Rudalics <rudalics@gmx.at>
4203 * window.h: Declare delete_all_child_windows instead of
4204 delete_all_subwindows.
4205 * window.c (Fwindow_nest, Fset_window_nest)
4206 (Fset_window_new_total, Fset_window_new_normal)
4207 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4208 (delete_all_subwindows): Rename to delete_all_child_windows.
4209 (Fdelete_other_windows_internal, Fset_window_configuration):
4210 Call delete_all_child_windows instead of delete_all_subwindows.
4211 * frame.c (delete_frame): Call delete_all_child_windows instead
4212 of delete_all_subwindows.
4214 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4216 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4217 This is also needed for porting to any host where GC_MARK_STACK is
4218 not GC_MAKE_GCPROS_NOOPS.
4219 (which_symbols): Use it.
4221 2011-11-07 Kenichi Handa <handa@m17n.org>
4223 * coding.c (coding_set_destination): Check coding->src_pos only
4224 when coding->src_object is a buffer (bug#9910).
4226 * process.c (send_process): Set the member src_multibyte of coding
4227 to 0 (bug#9911) when sending a unibyte text.
4229 * callproc.c (Fcall_process): Set the member src_multibyte of
4230 process_coding to 0 (bug#9912).
4232 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4234 * xmenu.c (cleanup_widget_value_tree): New function.
4235 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4236 calling free_menubar_widget_value_tree directly (Bug#9830).
4238 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4240 Fix some portability problems with 'inline'.
4241 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4242 (window_box_width, window_box_left, window_box_left_offset)
4243 (window_box_right, window_box_right_offset): Declare extern.
4244 Otherwise, these inline functions do not conform to C99 and
4245 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4246 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4247 * intervals.c (adjust_intervals_for_insertion)
4248 (adjust_intervals_for_deletion): Now extern, because otherwise the
4249 extern inline functions 'offset_intervals' couldn't refer to it.
4250 (static_offset_intervals): Remove.
4251 (offset_intervals): Rewrite using the old contents of
4252 static_offset_intervals. The old version didn't conform to C99
4253 because an extern inline function contained a reference to an
4254 identifier with static linkage.
4256 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4258 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4261 2011-11-06 Eli Zaretskii <eliz@gnu.org>
4263 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4264 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4265 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4266 return Qleft_to_right.
4268 2011-11-06 Chong Yidong <cyd@gnu.org>
4270 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4271 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4272 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4273 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4274 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4275 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4276 (Fwindow_vscroll): Doc fix.
4277 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4278 argument, since it makes no sense to pass a live window and for
4279 consistency with window-child.
4281 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4283 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4286 2011-11-05 Jason Rumney <jasonr@gnu.org>
4288 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4289 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4291 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4292 bitwise arithmetic preventing use of unicode-sip and non-truetype
4295 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4297 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4300 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4301 initialization code to keep similarity to xfns.c after changes
4304 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4306 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4307 (unwind_create_frame): New function (Bug#9943).
4308 (Fx_create_frame): Restructure code to be more similar to the one in
4309 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4310 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4311 Move terminal->reference_count++ just before making the frame official
4314 * nsterm.m (x_free_frame_resources): New function.
4315 (x_destroy_window): Move code to x_free_frame_resources.
4317 * xfns.c (unwind_create_frame): Fix comment.
4318 (Fx_create_frame, x_create_tip_frame):
4319 Move terminal->reference_count++ just before making the frame
4320 official. Move initialization of image_cache_refcount and
4321 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4323 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4325 Support MSVC build with newer versions of Visual Studio.
4326 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4327 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4330 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4331 which are not supported by MSVC.
4332 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4333 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4335 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4337 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4339 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4341 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
4343 Support MSVC build with newer versions of Visual Studio.
4344 * w32.c: Don't include w32api.h for MSVC.
4345 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4347 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4348 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4349 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4350 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4352 (alloca) [_MSC_VER]: Define to _alloca.
4354 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4356 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4358 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4360 * xdisp.c (note_mouse_highlight): If either of
4361 previous/next-single-property-change returns nil, treat that as
4362 the beginning or the end of the buffer. (Bug#9955)
4364 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4366 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
4367 label is not null (Bug#9951).
4368 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4371 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4373 * window.c (Fwindow_body_size): Mention in the doc string that the
4374 return value is in frame's canonical units. (Bug#9949)
4376 2011-11-03 Eli Zaretskii <eliz@gnu.org>
4378 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4380 * w32fns.c (unwind_create_frame): If needed, free the glyph
4381 matrices of the partially constructed frame. (Bug#9943)
4382 * xfns.c (unwind_create_frame): Likewise.
4384 2011-11-01 Eli Zaretskii <eliz@gnu.org>
4386 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4387 Don't stop backward scan on the continuation glyph, even though
4388 its CHARPOS is positive.
4389 (mouse_face_from_buffer_pos, note_mouse_highlight):
4390 Rename cover_string to disp_string.
4392 2011-11-01 Martin Rudalics <rudalics@gmx.at>
4394 * window.c (temp_output_buffer_show): Don't use
4395 Vtemp_buffer_show_specifiers.
4396 (Vtemp_buffer_show_specifiers): Remove unused variable.
4398 2011-10-30 Eli Zaretskii <eliz@gnu.org>
4400 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4401 past the beginning of the current glyph matrix.
4403 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
4405 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4406 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4407 HAVE_GTK3 (Bug#9869).
4409 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4410 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4412 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4414 * xterm.c: Declare x_handle_net_wm_state to return int.
4415 (handle_one_xevent): Check if we are iconified but don't have
4416 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4417 (get_current_wm_state): Return non-zero if not hidden,
4418 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4419 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4420 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4421 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4423 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4425 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4426 so that this new function doesn't get optimized away by a
4427 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4429 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4431 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4433 2011-10-29 Eli Zaretskii <eliz@gnu.org>
4435 Fix the `xbytecode' command.
4436 * .gdbinit (xprintbytestr): New command.
4437 (xwhichsymbols): Rename from `which'; all callers changed.
4438 (xbytecode): Print the byte-code string as well.
4440 2011-10-29 Kim Storm <storm@cua.dk>
4442 * alloc.c (which_symbols): New function.
4444 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4446 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4449 2011-10-29 Glenn Morris <rgm@gnu.org>
4451 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4452 Not clear what it was for, and it causes various bugs. (Bug#9839)
4454 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4456 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4457 possible random value that matches one of those tested as
4458 condition to clear the mouse face.
4460 2011-10-28 Chong Yidong <cyd@gnu.org>
4462 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4464 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4466 * window.c (make_window): Initialize phys_cursor_on_p.
4468 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4470 * lisp.h (struct Lisp_Symbol): Update comments.
4472 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
4474 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4476 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4478 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4479 <oslsachem@gmail.com> for helping to debug this.
4481 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4482 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4483 (g_b_init_get_glyph_outline_w): New static variables.
4484 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4485 (GetGlyphOutlineW_Proc): New typedefs.
4486 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
4487 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4489 (w32font_open_internal, compute_metrics):
4490 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
4491 instead of calling the "wide" APIs directly.
4493 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4495 * w32.h (syms_of_w32font): Add prototype.
4497 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4499 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4500 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4501 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4502 (Fmove_to_window_line): Doc fix.
4504 2011-10-27 Chong Yidong <cyd@gnu.org>
4506 * process.c (make_process): Set gnutls_state to NULL.
4508 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4509 non-NULL, regardless of GNUTLS_INITSTAGE.
4510 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4511 an error. Set process slots as soon as we allocate them.
4513 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4515 2011-10-27 Chong Yidong <cyd@gnu.org>
4517 * gnutls.c (emacs_gnutls_deinit): New function.
4518 Deallocate credentials structures as well as calling gnutls_deinit.
4519 (Fgnutls_deinit, Fgnutls_boot): Use it.
4521 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4522 (deactivate_process): Call emacs_gnutls_deinit.
4524 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4526 * image.c (x_create_x_image_and_pixmap):
4527 * w32.c (sys_rename, w32_delayed_load):
4528 * w32font.c (fill_in_logfont):
4529 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4531 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
4533 * w32fns.c (w32_default_color_map): New function,
4534 extracted from Fw32_default_color_map.
4535 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
4537 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4539 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4541 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4543 * keyboard.c (test_undefined): New function (bug#9751).
4544 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4546 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4548 * sysdep.c (init_sys_modes): Fix the check for the controlling
4549 terminal (Bug#6649).
4551 2011-10-20 Eli Zaretskii <eliz@gnu.org>
4553 * dispextern.h (struct bidi_it): New member next_en_type.
4555 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4556 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4557 current character, check also for next_en_type being WEAK_EN.
4558 (bidi_resolve_weak): Don't enter the expensive loop if the current
4559 position is before next_en_pos. Record the bidi type of the first
4560 non-ET, non-BN character we find, in addition to its position.
4561 (bidi_level_of_next_char): Invalidate next_en_type when
4562 next_en_pos is over-stepped.
4564 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4566 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4567 * editfns.c: Rewrite current-time-zone so that it invokes
4568 the equivalent of (format-time-string "%Z") to get the time zone name.
4569 This fixes a bug when the time zone name contains characters that
4570 need converting from the system time locale to Emacs internal format.
4571 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4572 that patch fixed format-time-string to do the conversion, but
4573 I forgot to fix current-time-zone.
4574 (format_time_string): New function, containing most of
4575 what Fformat_time_string used to contain.
4576 (Fformat_time_string): Rewrite in terms of format_time_string.
4577 This doesn't change this function's behavior.
4578 (current-time-zone): Rewrite to use format_time_string.
4579 This fixes the bug reported by Michael Schierl in
4580 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4581 Jason Rumney's 2007-06-07 change worked around this bug, but
4583 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4585 2011-10-19 Eli Zaretskii <eliz@gnu.org>
4587 * xdisp.c (start_display): If the character at POS is displayed
4588 via a display vector, reset IT->current.dpvec_index to zero.
4589 (try_window_reusing_current_matrix): If a line ends in a display
4590 vector or the next line starts in a display vector, continue
4591 redrawing the window even though the character position of
4592 start_row was reached.
4595 2011-10-18 Chong Yidong <cyd@gnu.org>
4597 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4598 with nobreak-char-display too.
4600 2011-10-18 Eli Zaretskii <eliz@gnu.org>
4602 Fix part 3 of bug#9771.
4603 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4604 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4605 non-neutral characters if the current character is a paragraph
4606 separator (a.k.a. Newline). This avoids running the same
4607 expensive loop twice, once when we consume the preceding newline
4608 and the other time when the line actually needs to be displayed.
4609 Avoid the loop when we see neutrals on the base embedding level
4610 following a character whose directionality is the same as the
4611 paragraph's. This avoids running the expensive loop when a line
4612 ends in a long sequence of neutrals, like control characters.
4613 Add assertion against STRONG_AL type. Slightly rearrange code
4614 that determines the type of a neutral given the first non-neutral
4616 (bidi_level_of_next_char): Set next_en_pos to zero when
4617 invalidating its info.
4619 2011-10-17 Eli Zaretskii <eliz@gnu.org>
4621 * xdisp.c (push_display_prop): Determine whether to record string
4622 or buffer position by IT->string, not by IT->method. Allow
4623 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
4624 (move_it_vertically_backward): Don't look for character position
4625 immediately after the newline when in a continuation line.
4628 2011-10-15 Martin Rudalics <rudalics@gmx.at>
4630 * window.c (coordinates_in_window): Rewrite and delabelize
4631 vertical border check. (Bug#5357) (Bug#9618)
4633 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4635 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4636 errors in XSetWindowBorder (bug#9310).
4638 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4640 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4641 avoid crash when xmalloc overrun checking is enabled.
4643 2011-10-13 Eli Zaretskii <eliz@gnu.org>
4645 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4646 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4647 cursor motion with <left> and <right> arrow keys.
4649 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4650 some callers set that themselves.
4652 2011-10-12 Eli Zaretskii <eliz@gnu.org>
4654 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4655 display string and the previous row comes from the same string and
4656 is empty. (Bug#9739) (Bug#9738)
4658 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4660 * doc.c (get_doc_string): Encode file name (bug#9735).
4662 2011-10-12 Eli Zaretskii <eliz@gnu.org>
4664 * bidi.c (bidi_level_of_next_char):
4665 * xdisp.c (get_visually_first_element): Remove old incorrect
4666 comments regarding the Unicode Line Separator character.
4668 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4670 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4672 * alloc.c (Fgc_status): Do not access beyond zombies array
4673 boundary if nzombies > MAX_ZOMBIES.
4674 * alloc.c (dump_zombies): Add missing format specifier.
4676 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4678 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4679 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4681 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4682 Some packages use them to denote characters with modifiers.
4684 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4686 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4687 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4688 matching a pp-number. Rename parameter var to var1.
4690 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4692 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4694 2011-10-08 Glenn Morris <rgm@gnu.org>
4696 * callint.c (Fcall_interactively): Give a more explicit error for the
4697 'c' case with a non-character input. (Bug#8479)
4699 2011-10-08 Eli Zaretskii <eliz@gnu.org>
4701 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4703 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4704 lines that are hscrolled on the left.
4706 * dispnew.c (buffer_posn_from_coords): Account for a possible
4707 presence of header-line. (Bug#4426)
4709 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4711 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4712 Don't advertise functionality which we discourage or doesn't work.
4714 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4716 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4717 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4718 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4719 this makes Emacs dump core during garbage collection on rare
4720 occasions. sizeof is obviously inferior to offsetof here, so
4721 stick with offsetof.
4722 (GC_POINTER_ALIGNMENT): New macro.
4723 (mark_memory): Omit 3rd (offset) arg; caller changed.
4724 Don't assume EMACS_INT alignment is the same as pointer alignment.
4726 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4728 * keyboard.c (read_key_sequence_remapped): New var.
4729 (read_key_sequence): Compute remapping in the right buffer.
4730 (command_loop_1): Use read_key_sequence's remapping directly.
4732 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4734 * dired.c (file_name_completion): Don't expand file name.
4735 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4736 before checking file name handler.
4738 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4739 they've been requested explicitly (bug#9591).
4741 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
4743 * keymap.c (Fsingle_key_description): Use make_specified_string
4744 instead of build_string to build string from push_key_description.
4747 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4749 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4750 This fixes a Y2038 bug on 64-bit hosts.
4751 * buffer.c (reset_buffer):
4752 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4753 (Fclear_buffer_auto_save_failure):
4754 Use 0, not -1, to represent an unset failure time, since time_t
4755 might not be signed.
4757 Remove dependency on glibc malloc internals.
4758 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4759 Move back here from lisp.h, but with their new implementations.
4760 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4761 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4762 * charset.c (charset_table_init): New static var.
4763 (syms_of_charset): Use it instead of xmalloc. This removes a
4764 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4765 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4766 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4767 Move back to alloc.c.
4768 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4769 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4771 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4773 * nsterm.m (windowDidResize): Call x_set_window_size only when
4774 ns_in_resize is true. Otherwise set pixelwidth/height and
4775 call change_frame_size (Bug#9628).
4777 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4779 Port --enable-checking=all to Fedora 14 x86-64.
4780 * charset.c (syms_of_charset): Also account for glibc malloc's
4781 internal overhead when calculating the initial malloc maximum.
4783 Port --enable-checking=all to Fedora 14 x86.
4784 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4786 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4787 (overrun_check_realloc, overrun_check_free):
4788 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4789 That way, xmalloc returns a properly-aligned pointer even if
4790 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4791 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4792 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4793 into account when calculating the initial malloc maximum.
4794 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4795 Move here from alloc.c, so that charset.c can use it too.
4796 Properly align; the old code wasn't right for common 32-bit hosts
4797 when configured with --enable-checking=all.
4798 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4799 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4801 2011-09-29 Eli Zaretskii <eliz@gnu.org>
4803 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
4806 2011-09-28 Eli Zaretskii <eliz@gnu.org>
4808 * xdisp.c (compute_display_string_end): If there's no display
4809 string at CHARPOS, return -1.
4811 * bidi.c (bidi_fetch_char): When compute_display_string_end
4812 returns a negative value, treat the character as a normal
4813 character not covered by a display string. (Bug#9624)
4815 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
4817 * lread.c (Fread_from_string): Fix typo in docstring.
4819 2011-09-27 Eli Zaretskii <eliz@gnu.org>
4821 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4822 newline, reseat the iterator instead of bidi-iterating there one
4823 character at a time. (Bug#9610)
4824 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4825 TO_CHARPOS if the bidi iterator is at base embedding level.
4827 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4829 * lread.c (readevalloop): Use correct code for NBSP.
4830 (read1): Likewise. (Bug#9608)
4832 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
4834 * dbusbind.c (Fdbus_register_signal): When service is not
4835 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4837 2011-09-25 Glenn Morris <rgm@gnu.org>
4839 * buffer.c (truncate-lines): Doc fix.
4841 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
4843 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4844 (Fset_window_next_buffers): Doc fix.
4846 2011-09-24 Glenn Morris <rgm@gnu.org>
4848 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4850 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4852 Fix minor problems found by static checking.
4853 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
4854 * indent.c (Fvertical_motion): Fix == vs = typo.
4856 2011-09-24 Eli Zaretskii <eliz@gnu.org>
4858 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4859 Default value is now t. Doc fix.
4861 * indent.c (Fvertical_motion): Compute and apply the overshoot
4862 logic when moving up, not only when moving down. Fix the
4863 confusing name and values of the it_overshoot_expected variable;
4864 logic changes accordingly. (Bug#9254) (Bug#9549)
4866 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4867 CHARPOS is covered by a display string which includes newlines.
4868 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4869 is covered by a display string with embedded newlines.
4871 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
4873 * dbusbind.c (Fdbus_register_signal): Add match rule to
4874 Vdbus_registered_objects_table. (Bug#9581)
4875 (Fdbus_register_method, Vdbus_registered_objects_table):
4878 2011-09-24 Jim Meyering <meyering@redhat.com>
4880 do not ignore write error for any output size
4881 The previous change was incomplete.
4882 While it makes emacs --batch detect the vast majority of stdout
4883 write failures, errors were still ignored whenever the output size is
4884 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4885 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4886 && echo FAIL: ignored write error
4887 FAIL: ignored write error
4888 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4889 && echo FAIL: ignored write error
4890 FAIL: ignored write error
4891 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4893 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4895 * emacs.c (Fkill_emacs): In noninteractive mode exit
4896 non-successfully if a write error occurred on stdout. (Bug#9574)
4898 2011-09-21 Eli Zaretskii <eliz@gnu.org>
4900 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4903 * dispextern.h (struct it): Update the comment documenting what
4906 2011-09-20 Eli Zaretskii <eliz@gnu.org>
4908 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4909 a display string, extend search for cursor position to end of row.
4910 (find_row_edges): If the row ends in a newline from a display
4911 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4912 Handle the case of a display string with multiple newlines.
4913 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4914 non-empty line. Fixes confusing cursor motion with arrow keys at
4915 the beginning of a line that starts with whitespace.
4917 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4919 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4922 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
4924 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4927 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4929 * xdisp.c (display_line): Record maximum and minimum buffer
4930 positions even if no glyphs were produced (e.g., by a zero-width
4931 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4932 buffer positions that will be removed from the glyph row because
4934 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4935 column is beyond frame width: don't subtract 1 "pixel" when
4936 computing width of the stretch.
4937 (reseat_at_next_visible_line_start): Undo the change made on
4938 2011-09-17 that saved paragraph information and restored it after
4939 the call to `reseat'. (Bug#9545)
4941 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4943 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4944 and turn window cursor on if cleared (Bug#9415).
4946 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
4948 * search.c (boyer_moore): Take unibyte characters from pattern
4949 literally. (Bug#9458)
4951 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4953 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4955 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4957 Fix minor problem found by static checking.
4958 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4959 initialized, to pacify gcc -Wuninitialized.
4961 * fileio.c: Report proper errno when syscall falls.
4962 (Finsert_file_contents): Save and restore errno,
4963 so that report_file_error outputs the correct diagnostic.
4964 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4966 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4968 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4970 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4972 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4973 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4975 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4977 * xdisp.c (reseat_at_next_visible_line_start): Keep information
4978 about the current paragraph and restore it after the call to reseat.
4980 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4981 (bidi_find_paragraph_start): Search back for paragraph beginning
4982 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4983 (bidi_move_to_visually_next): Only trigger paragraph-related
4984 computations when the last character is a newline or at EOB, not
4985 just any NEUTRAL_B. (Bug#9470)
4987 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4988 truncated lines if point is covered by a display string. (Bug#9524)
4990 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4992 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4993 (cons_to_x_long): New function.
4994 (lisp_data_to_selection_data): Use it. Correct the test for
4995 short-versus-long data; it was negated. Break out of vector
4996 loop, for efficiency, when a long datum is discovered.
4998 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5000 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5002 2011-09-16 Eli Zaretskii <eliz@gnu.org>
5004 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5005 GCC PR/17406) by declaring this function with external scope.
5007 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5009 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5010 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5012 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5014 * editfns.c (Fformat): Correctly handle text properties on "%%".
5016 2011-09-15 Eli Zaretskii <eliz@gnu.org>
5018 * xterm.c (x_draw_composite_glyph_string_foreground):
5019 * w32term.c (x_draw_composite_glyph_string_foreground):
5020 * term.c (encode_terminal_code):
5021 * composite.c (composition_update_it, get_composition_id):
5022 * xdisp.c (get_next_display_element)
5023 (fill_composite_glyph_string): Add comments about special meaning
5024 of TAB characters in a composition.
5026 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5028 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
5029 This occurs when processing a multibyte format.
5030 Problem reported by Wolfgang Jenker.
5032 2011-09-15 Johan Bockgård <bojohan@gnu.org>
5034 * xdisp.c (try_cursor_movement): Only check for exact match if
5035 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5037 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5039 Remove unused external symbols.
5040 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5041 * xdisp.c (calc_pixel_width_or_height): Now static.
5042 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5043 * indent.c (check_display_width):
5044 * w32term.c: Fix comment to match code.
5045 * xterm.c, xterm.h (x_catching_errors): Remove.
5047 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5049 * xselect.c: Use signed conversions more consistently (Bug#9498).
5050 (selection_data_to_lisp_data): Assume incoming selection data are
5051 signed integers, not unsigned. This is to be consistent with
5052 outgoing selection data, which was modified to use signed integers
5053 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5054 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5055 expects long, not unsigned long.
5057 2011-09-14 Eli Zaretskii <eliz@gnu.org>
5059 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5060 computation of loop end. Reported by Johan Bockgård
5063 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
5065 * frame.c (Fother_visible_frames_p): Function deleted.
5067 2011-09-12 Eli Zaretskii <eliz@gnu.org>
5069 * indent.c (compute_motion): Process display vector front to back
5070 rather than the other way around. (Bug#2496)
5072 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5074 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5076 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
5078 * minibuf.c (Fread_from_minibuffer): Doc fix.
5080 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5082 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5083 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5085 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5087 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5088 value for non-existent files.
5090 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5092 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5093 set its "size" to -1. This will set the modtime_size field of
5094 the corresponding buffer to -1, which is what
5095 verify-visited-file-modtime expects for files that do not exist.
5098 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5100 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5102 * lisp.h: ... from here. push_key_description is no longer
5103 defined in keyboard.c, so its declaration should not be in
5104 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5105 logically belongs with push_key_description.
5107 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5109 * buffer.h: Include <sys/types.h> instead of <time.h>.
5110 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5111 Problem reported by Herbert J. Skuhra.
5113 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5115 * xml.c (parse_region): Make the parsing work for
5116 non-comment-starting XML files again (bug#9144).
5118 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5120 * image.c (gif_load): Fix calculation of bottom and right corner.
5123 2011-09-10 Eli Zaretskii <eliz@gnu.org>
5125 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5126 redisplay in small windows.
5128 2011-09-09 Eli Zaretskii <eliz@gnu.org>
5130 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5132 2011-09-08 Martin Rudalics <rudalics@gmx.at>
5134 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5135 Operate on live windows only.
5137 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
5139 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5141 2011-09-07 Eli Zaretskii <eliz@gnu.org>
5143 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5144 only under bidi iteration.
5146 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5148 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5150 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5152 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5153 Without this fix, the command to link temacs failed due to an
5154 undefined symbol __builtin_isnan. This is because
5155 /usr/include/iso/math_c99.h #defines isnan(x) to
5156 __builtin_isnan(x), but the bundled gcc, which identifies itself
5157 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5159 * floatfns.c (isnan): #undef, and then #define to a clone of
5161 (Fisnan): Always define, since it's always available now.
5162 (syms_of_floatfns): Always define isnan at the Lisp level.
5164 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5166 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5168 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5170 * fileio.c: Fix bugs with large file offsets (Bug#9428).
5171 The previous code assumed that file offsets (off_t values) fit in
5172 EMACS_INT variables, which is not true on typical 32-bit hosts.
5173 The code messed up by falsely reporting buffer overflow in cases
5174 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5175 when "big" contains more than 2**29 bytes, even though this
5176 inserts just one byte and does not overflow the buffer.
5177 (Finsert_file_contents): Store file offsets as off_t
5178 values, not as EMACS_INT values. Check for overflow when
5179 converting between EMACS_INT and off_t. When checking for
5180 buffer overflow or for overlap, take the offsets into account.
5181 Don't use EMACS_INT for small values where int suffices.
5182 When checking for overlap, fix a typo: ZV was used where
5183 ZV_BYTE was intended.
5184 (Fwrite_region): Don't assume off_t fits into 'long'.
5185 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5187 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
5189 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5191 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5193 sprintf-related integer and memory overflow issues (Bug#9412).
5195 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
5196 (esprintf, exprintf, evxprintf): New functions.
5197 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
5198 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
5199 (modify_event_symbol): Do not assume that the length of
5200 name_alist_or_stem is safe to alloca and fits in int.
5201 (Fexecute_extended_command): Likewise for function name and binding.
5202 (Frecursion_depth): Wrap around reliably on integer overflow.
5203 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5204 since some callers pass EMACS_INT values.
5205 (Fsingle_key_description): Don't crash if symbol name contains more
5206 than MAX_ALLOCA bytes.
5207 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5208 (get_minibuffer): Arg is now EMACS_INT, not int.
5209 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
5210 (esprintf, exprintf, evxprintf): New decls.
5211 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5213 * dbusbind.c (signature_cat): New function.
5214 (xd_signature, Fdbus_register_signal):
5215 Do not overrun buffer; instead, report string overflow.
5217 * dispnew.c (add_window_display_history): Don't overrun buffer.
5218 Truncate instead; this is OK since it's just a log.
5220 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5221 even if the time zone offset is outlandishly large.
5222 Don't mishandle offset == INT_MIN.
5224 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5225 when creating daemon; the previous buffer-overflow check was incorrect.
5227 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5228 which has the guts of the old verror function.
5230 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5231 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5233 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5234 (font_unparse_xlfd): Don't blindly alloca long strings.
5235 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
5236 fits in int, when using sprintf. Use single snprintf to count
5237 length of string rather than counting it via multiple sprintfs;
5238 that's simpler and more reliable.
5239 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5240 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5241 sprintf, in case result does not fit in int.
5243 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5244 (fontset_from_font): Print it.
5246 * frame.c (tty_frame_count): Now printmax_t, not int.
5247 (make_terminal_frame, set_term_frame_name): Print it.
5248 (x_report_frame_params): In X, window IDs are unsigned long,
5249 not signed long, so print them as unsigned.
5250 (validate_x_resource_name): Check for implausibly long names,
5251 and don't assume name length fits in 'int'.
5252 (x_get_resource_string): Don't blindly alloca invocation name;
5253 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5256 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5257 (xg_check_special_colors, xg_set_geometry):
5258 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5260 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5261 Use esprintf, not sprintf, in case result does not fit in int.
5263 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5264 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5265 it as a large positive number.
5266 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5267 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5269 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5270 in case result does not fit in int.
5272 * print.c (float_to_string): Detect width overflow more reliably.
5273 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5274 buffer overrun. Don't assume list length fits in 'int'. Treat
5275 print length of 0 as 0, not as infinity; to be consistent with other
5276 uses of print length in this function. Don't overflow print length
5277 index. Don't assume hash table size fits in 'long', or that
5278 vectorlike size fits in 'unsigned long'.
5280 * process.c (make_process): Use printmax_t, not int, to format
5281 process-name gensyms.
5283 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5285 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5286 to avoid potential buffer overrun.
5288 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5289 if X resource line is longer than 512 bytes.
5291 * xfns.c (x_window): Make sprintf buffer a bit bigger
5292 to avoid potential buffer overrun.
5294 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5296 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5298 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5300 Integer overflow fixes for scrolling, etc.
5301 Without these, Emacs silently mishandles large integers sometimes.
5302 For example, "C-u 4294967297 M-x recenter" was treated as if
5303 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5305 * xdisp.c (try_window_id): Check Emacs fixnum range before
5306 converting to 'int'.
5308 * window.c (window_scroll_line_based, Frecenter):
5309 Check that an Emacs fixnum is in range before assigning it to 'int'.
5310 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5311 values converted from Emacs fixnums.
5312 (Frecenter): Don't wrap around a line count if it is out of 'int'
5313 range; instead, treat it as an extreme value.
5314 (Fset_window_configuration, compare_window_configurations):
5315 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5317 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5318 that can exceed INT_MAX. Check that EMACS_INT value is in range
5319 before assigning it to the (possibly-narrower) index.
5320 (match_limit): Don't assume that a fixnum can fit in 'int'.
5322 * print.c (print_object): Use ptrdiff_t, not int, for index that can
5325 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
5326 (Fvertical_motion): Don't wrap around LINES values that don't fit
5327 in 'int'. Instead, treat them as extreme values. This is good
5328 enough for windows, which can't have more than INT_MAX lines anyway.
5330 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5332 * Require libxml/parser.h to avoid compilation warning.
5334 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5336 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5337 since this reportedly can destroy thread storage.
5339 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
5341 * syntax.c (find_defun_start): Update all cache variables if
5342 exiting early (Bug#9401).
5344 2011-08-30 Eli Zaretskii <eliz@gnu.org>
5346 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5348 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5349 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5350 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5352 * term.c (tty_append_glyph): New function.
5353 (produce_stretch_glyph): Static function and its prototype deleted.
5355 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5358 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5360 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5361 when checking :margin (Bug#9390).
5362 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
5363 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
5364 so that the name doesn't mislead. All uses changed.
5366 2011-08-28 Johan Bockgård <bojohan@gnu.org>
5368 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5371 2011-08-27 Eli Zaretskii <eliz@gnu.org>
5373 * xdisp.c (move_it_to): Don't bail out early when reaching
5374 position beyond to_charpos, if we are scanning backwards.
5375 (move_it_vertically_backward): When DY == 0, make sure we get to
5376 the first character in the line after the newline.
5378 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5380 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5381 (ccl_driver): Do not generate an out-of-range pointer.
5382 (Fccl_execute_on_string): Remove unnecessary check for
5383 integer overflow, noted by Stefan Monnier in
5384 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5385 Remove a FIXME that didn't need fixing.
5386 Simplify the newly-introduced buffer reallocation code.
5388 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
5390 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5392 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
5394 Integer and memory overflow issues (Bug#9196).
5396 * doc.c (get_doc_string): Rework so that
5397 get_doc_string_buffer_size is the actual buffer size, rather than
5398 being 1 less than the actual buffer size; this makes xpalloc more
5401 * image.c (x_allocate_bitmap_record, cache_image):
5402 * xselect.c (Fx_register_dnd_atom):
5403 Simplify previous changes by using xpalloc.
5405 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5406 since either will do and ptrdiff_t is convenient with xpalloc.
5408 * charset.c (charset_table_size)
5409 (struct charset_sort_data.priority): Now ptrdiff_t.
5410 (charset_compare): Don't overflow if priorities differ greatly.
5411 (Fsort_charsets): Don't assume list length fits in int.
5412 Check for size-calculation overflow when allocating sort data.
5413 (syms_of_charset): Allocate an initial charset table that is
5414 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5416 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5418 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5419 The actual value is always <= INT_MAX, and leaving it unsigned made
5420 overflow checking harder.
5422 * dispextern.h (struct glyph_matrix.rows_allocated)
5423 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5424 with xpalloc. The values are still always <= INT_MAX.
5426 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5428 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5429 (SAFE_NALLOCA): New macro.
5431 * region-cache.c (struct boundary.pos, find_cache_boundary)
5432 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5433 (set_cache_region, invalidate_region_cache)
5434 (revalidate_region_cache, know_region_cache, region_cache_forward)
5435 (region_cache_backward, pp_cache):
5436 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5437 so that ptrdiff_t * can be passed to xpalloc.
5438 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5439 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5440 (pp_cache): Don't assume cache_len fits in int.
5441 * region-cache.h: Adjust extern decls to match.
5443 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5444 EMACS_INT, since either will do, for xpalloc.
5446 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5447 (xnmalloc, xnrealloc, xpalloc): New functions.
5449 * bidi.c (bidi_shelve_header_size): New constant.
5450 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5451 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5453 * bidi.c (bidi_cache_shrink):
5454 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5456 Don't update size of array until after memory allocation succeeds,
5457 because xmalloc/xrealloc may not return.
5458 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5459 now that we have proper integer overflow checking.
5460 (record_overlay_string, overlay_strings): Catch overflows when
5461 calculating size of overlay_str_buf.
5463 * callproc.c (Fcall_process): Check for size overflow when
5464 calculating size of args2.
5465 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5466 Normally we prefer signed values, but sticking with ptrdiff_t would
5467 require adding more-complicated checks.
5469 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5470 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5471 Redo buffer-overflow calculations to avoid integer overflow.
5472 Add a FIXME comment where memory seems to be over-allocated.
5474 * character.c (Fstring): Check for size-calculation overflow.
5476 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5477 unnecessary integer overflow. Check for size overflow.
5478 (encode_coding_object): Don't update size until xmalloc succeeds.
5480 * composite.c (get_composition_id): Check for overflow in glyph
5481 length calculations.
5483 Integer and memory overflow fixes for display code.
5484 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5485 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5486 (scrolling_window): Check for overflow in size calculations.
5487 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5488 Don't assume glyph table len fits in int.
5489 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5490 (row_table_size): Now ptrdiff_t, not int.
5491 (scrolling_window): Avoid overflow in size calculations.
5492 Don't update size until allocation succeeds.
5493 * fns.c (concat): Check for overflow in size calculations.
5494 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5495 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5496 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5498 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5499 (get_doc_string): Check for size calculation overflow.
5500 Don't update size until allocation succeeds.
5501 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5502 EMACS_INT, where ptrdiff_t will do.
5503 (Fsubstitute_command_keys): Check for string overflow.
5505 * editfns.c (set_time_zone_rule): Don't assume environment length
5507 (message_length): Now ptrdiff_t, not int.
5508 (Fmessage_box): Don't update size until allocation succeeds.
5509 Don't assume message length fits in int.
5510 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5512 * emacs.c (main): Do not reallocate argv, since there is a null at
5513 the end that can be overwritten, and this way there's no need to
5514 worry about size-calculation overflow.
5515 (sort_args): Check for size-calculation overflow.
5517 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5519 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5521 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5522 (x_set_scroll_bar_width, x_figure_window_size):
5523 Check for integer overflow.
5524 (x_set_alpha): Do not assume XINT fits in int.
5526 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5527 This is for the members text_lines, text_cols, total_lines, total_cols,
5528 where the system imposes an 'int' limit.
5530 * fringe.c (Fdefine_fringe_bitmap):
5531 Don't update size until alloc works.
5533 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5534 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5536 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5537 Check for size-calculation overflow.
5538 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5539 do, as we prefer signed integers.
5540 (id_to_widget.max_size, id_to_widget.used)
5541 (xg_store_widget_in_map, xg_remove_widget_from_map)
5542 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5543 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5544 Use and return ptrdiff_t, not int.
5545 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5546 * gtkutil.h: Change prototypes to match the above.
5548 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5549 are duplicate now that they've been promoted to lisp.h.
5550 (x_allocate_bitmap_record, x_alloc_image_color)
5551 (make_image_cache, cache_image, xpm_load):
5552 Don't update size until alloc is done.
5553 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5555 Check for size calculation overflow.
5556 (ct_colors_allocated_max): New constant.
5557 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5560 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5561 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5562 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5563 Use ptrdiff_t, not int, to count maps.
5564 (read_char_minibuf_menu_prompt): Check for overflow in size
5565 calculations. Don't update size until allocation succeeds.
5566 Redo calculations to avoid overflow.
5567 * keyboard.h: Change prototypes to match the above.
5569 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5571 (current_minor_maps): Check for size calculation overflow.
5572 * keymap.h: Change prototypes to match the above.
5574 * lread.c (read1, init_obarray): Don't update size until alloc done.
5576 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5577 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5579 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5580 Now ptrdiff_t, not int.
5581 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5582 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5584 * process.c (Fnetwork_interface_list): Check for overflow
5585 in size calculation.
5587 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5589 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5590 overflow. Don't bother calling xmalloc when xrealloc will do.
5592 * search.c (Freplace_match): Check for size calculation overflow.
5593 (Fset_match_data): Don't assume list lengths fit in 'int'.
5595 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5596 for command line length. Do not attempt to address one before the
5597 beginning of an array, as that's not portable.
5599 * term.c (max_frame_lines): Remove; unused.
5600 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5602 (encode_terminal_code, calculate_costs): Check for size
5603 calculation overflow.
5604 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5605 table lengths and related sizes. Don't update size until alloc
5606 done. Redo calculations to avoid overflow.
5607 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5609 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5610 subtracting pointers.
5611 (gobble_line): Check for overflow more carefully. Don't update size
5614 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5615 Don't update size until alloc done.
5616 Redo size calculations to avoid overflow.
5617 Check for size calculation overflow.
5618 (main) [DEBUG]: Fix typo in invoking tparam1.
5620 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5621 Use ptrdiff_t, not int, for sizes.
5622 (store_mode_line_noprop_char): Don't update size until alloc done.
5624 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5625 Use ptrdiff_t, not int, for sizes.
5626 (Finternal_make_lisp_face, cache_face):
5627 Check for size calculation overflow.
5628 (cache_face): Treat size calculation overflows as if they were
5629 memory exhaustion (the usual treatment), rather than aborting.
5631 * xfns.c (x_encode_text, x_set_name_internal)
5632 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5633 sizes, since they can exceed INT_MAX in size. Check for size
5634 calculation overflow.
5636 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5637 (xg_select): Check for size calculation overflow.
5638 Don't update size until alloc done.
5640 * xrdb.c (get_environ_db): Don't assume path length fits in int,
5641 as sprintf is limited to int lengths.
5643 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5644 (X_LONG_MIN): New macros.
5645 Use them to make the following changes clearer.
5646 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5647 This change doesn't affect the value now, but it may help remind
5648 future maintainers not to raise the value too much later.
5649 (SELECTION_QUANTUM): Remove, replacing with ...
5650 (selection_quantum): ... new function, which avoids overflow.
5652 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5653 assumption that selection length fits in 'int'.
5654 (x_reply_selection_request, x_handle_selection_request)
5655 (x_get_window_property, receive_incremental_selection)
5656 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5657 (lisp_data_to_selection_data, clean_local_selection_data):
5658 Use ptrdiff_t, not int, to record length of selection.
5659 (x_reply_selection_request, x_get_window_property)
5660 (receive_incremental_selection, x_property_data_to_lisp):
5661 Redo calculations to avoid overflow.
5662 (x_reply_selection_request): When sending hint, ceiling it at
5663 X_LONG_MAX rather than relying on wraparound overflow to send
5665 (x_get_window_property, receive_incremental_selection)
5666 (lisp_data_to_selection_data, x_property_data_to_lisp):
5667 Check for size-calculation overflow.
5668 (x_get_window_property, receive_incremental_selection)
5669 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5670 Don't store size until memory allocation succeeds.
5671 (x_get_window_property): Plug memory leak on memory exhaustion.
5672 Don't double-block input; malloc is safe here. Don't assume 2**34
5673 - 4 fits in unsigned long. Add an xassert to check
5674 XGetWindowProperty overflow. Be more careful about overflow
5675 calculations, and distinguish size from memory overflow better.
5676 (receive_incremental_selection): When tracing, don't assume
5677 unsigned int is less than INT_MAX.
5678 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5679 harmful) conversions of unsigned short to int.
5680 (lisp_data_to_selection_data): Don't assume that integers
5681 in the range -65535 through -1 fit in an X unsigned short.
5682 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5683 result parameters unless successful. Rely on cons_to_unsigned
5684 to report problems with elements; the old code wasn't right anyway.
5685 (x_check_property_data): Check for int overflow; we cannot use
5686 a wider type due to X limits.
5687 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5689 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
5691 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5692 (x_term_init): Check for size calculation overflow.
5693 (x_color_cells): Don't store size until memory allocation succeeds.
5694 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
5695 Don't assume alloca size is less than MAX_ALLOCA.
5696 (x_term_init): Don't assume length fits in int (sprintf is limited
5699 Use ptrdiff_t for composition IDs.
5700 * character.c (lisp_string_width):
5701 * composite.c (composition_table_size, n_compositions)
5702 (get_composition_id, composition_gstring_from_id):
5703 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5704 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5705 * window.c (Frecenter):
5706 Use ptrdiff_t, not int, for composition IDs.
5707 * composite.c (get_composition_id): Check for integer overflow.
5708 * composite.h: Adjust prototypes to match the above changes.
5710 Use ptrdiff_t for hash table indexes.
5711 * category.c (hash_get_category_set):
5712 * ccl.c (ccl_driver):
5713 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5714 * coding.c (coding_system_charset_list, detect_coding_system):
5715 * coding.h (struct coding_system.id):
5716 * composite.c (get_composition_id, gstring_lookup_cache):
5717 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5718 * image.c (xpm_get_color_table_h):
5719 * lisp.h (hash_lookup, hash_put):
5720 * minibuf.c (Ftest_completion):
5721 Use ptrdiff_t for hash table indexes, not int (which is too
5722 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5723 32-bit --with-wide-int hosts).
5725 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5726 Add a FIXME comment about memory leaks.
5727 (syms_of_charset): Don't assume xmalloc returns.
5729 Don't assume that stated character widths fit in int.
5730 * character.c (Fchar_width, c_string_width, lisp_string_width):
5731 * character.h (CHAR_WIDTH):
5732 * indent.c (MULTIBYTE_BYTES_WIDTH):
5733 Use sanitize_char_width to avoid undefined and/or bad behavior
5734 with outlandish widths.
5735 * character.h (sanitize_tab_width): Rename from sanitize_width,
5736 now that we have two such functions. All uses changed.
5737 (sanitize_char_width): New inline function.
5739 Don't assume that tab-width fits in int.
5740 * character.h (sanitize_width): New inline function.
5741 (SANE_TAB_WIDTH): New macro.
5742 (ASCII_CHAR_WIDTH): Use it.
5743 * indent.c (sane_tab_width): Remove. All uses replaced by
5744 SANE_TAB_WIDTH (current_buffer).
5745 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5747 * fileio.c: Integer overflow issues with file modes.
5748 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5750 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5751 Remove unreachable code.
5752 (read_hex, load_charset_map_from_file): Check for integer overflow.
5754 * xterm.c: Don't go over XClientMessageEvent limit.
5755 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5756 (x_send_scroll_bar_event): Likewise. Check that the size does not
5757 exceed limits imposed by XClientMessageEvent, as well as the usual
5758 ptrdiff_t and size_t limits.
5760 * keyboard.c: Overflow, signedness and related fixes.
5761 (make_lispy_movement): Use same integer type in forward decl
5762 that is used in the definition.
5763 (read_key_sequence, keyremap_step):
5764 Change bufsize argument back to int, undoing my 2011-03-30 change.
5765 We prefer signed types, and int is wide enough here.
5766 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5767 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5768 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5769 length, not size_t. Use ptrdiff_t for index, not int.
5770 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5771 possibility of integer overflow.
5773 Overflow, signedness and related fixes for images.
5775 * dispextern.h (struct it.stack[0].u.image.image_id)
5776 (struct_it.image_id, struct image.id, struct image_cache.size)
5777 (struct image_cache.used, struct image_cache.ref_count):
5778 * gtkutil.c (update_frame_tool_bar):
5779 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5780 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5781 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5782 * nsmenu.m (update_frame_tool_bar):
5783 * xdisp.c (calc_pixel_width_or_height):
5784 * xfns.c (image_cache_refcount):
5785 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5786 on typical 64-bit hosts.
5788 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5789 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5790 Omit unnecessary casts to int.
5791 (parse_image_spec): Check that integers fall into 'int' range
5792 when the callers expect that.
5793 (image_ascent): Redo ascent calculation to avoid int overflow.
5794 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5795 (lookup_image): Remove unnecessary tests.
5796 (xbm_image_p): Locals are now of int, not EMACS_INT,
5797 since parse_image_check makes sure they fit into int.
5798 (png_load, gif_load, svg_load_image):
5799 Prefer int to unsigned where either will do.
5800 (tiff_handler): New function, combining the cores of the
5801 old tiff_error_handler and tiff_warning_handler.
5802 This function is rewritten to use vsnprintf and thereby avoid
5803 stack buffer overflows. It uses only the features of vsnprintf
5804 that are common to both POSIX and native Microsoft.
5805 (tiff_error_handler, tiff_warning_handler): Use it.
5806 (tiff_load, gif_load, imagemagick_load_image):
5807 Don't assume :index value fits in 'int'.
5808 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5809 (imagemagick_load_image): Check that crop parameters fit into
5810 the integer types that MagickCropImage accepts. Don't assume
5811 Vimagemagick_render_type has a nonnegative value. Don't assume
5812 size_t fits in 'long'.
5813 (gs_load): Use printmax_t to print the widest integers possible.
5814 Check for integer overflow when computing image height and width.
5816 2011-08-26 Eli Zaretskii <eliz@gnu.org>
5818 * xdisp.c (redisplay_window): Don't force window start if point
5819 will be invisible in the resulting window. (Bug#9324)
5821 2011-08-25 Eli Zaretskii <eliz@gnu.org>
5823 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5824 the display spec is of the form `(space ...)'.
5825 (handle_display_spec): Return the value returned by
5826 handle_single_display_spec, not just 1 or zero.
5827 (handle_single_display_spec): If the display spec is of the form
5828 `(space ...)', and specifies display in the text area, return 2
5830 (try_cursor_movement): Check for the need to scroll more
5831 accurately, and prefer exact match for point under bidi.
5832 Don't advance `row' beyond the last row of the window.
5834 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5835 into disp_prop; all users changed.
5837 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5838 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5839 for the text covered by the display property.
5841 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
5843 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5844 Change return value to nil.
5845 (Frecord_buffer): Delete unused function.
5847 2011-08-24 Eli Zaretskii <eliz@gnu.org>
5849 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5850 buffers, return left-to-right.
5851 (set_cursor_from_row): Consider candidate row a win if its glyph
5852 represents a newline and point is on that newline. Fixes cursor
5853 positioning on the newline at EOL of R2L text within L2R
5854 paragraph, and vice versa.
5855 (try_cursor_movement): Check continued rows, in addition to
5856 continuation rows. Fixes unwarranted scroll when point enters a
5857 continued line of R2L text within an L2R paragraph, or vice versa.
5858 (cursor_row_p): Consider the case of point being equal to
5859 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5860 from the end of a short line to the beginning of a continued line
5861 of R2L text within L2R paragraph.
5862 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5863 composed characters.
5865 * bidi.c (bidi_check_type): Use xassert.
5866 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5869 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5871 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5874 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
5876 * nsfont.m (ns_otf_to_script): Fix typo.
5878 2011-08-22 Kenichi Handa <handa@m17n.org>
5880 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5881 extra slot even if the purpose is char-code-property-table.
5883 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5885 * xdisp.c (redisplay_window): When computing centering_position,
5886 account for the height of the header line. (Bug#8874)
5888 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5889 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5890 candidate is selected by the mouse, and that candidate has a
5891 composed character under the mouse.
5893 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5894 coordinates reported by pos-visible-in-window-p for a composed
5895 character in column zero.
5897 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5899 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5901 2011-08-22 Eli Zaretskii <eliz@gnu.org>
5903 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5904 consider it a hit if to_charpos is anywhere in the range of the
5905 composed buffer positions.
5907 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
5909 * image.c (gif_load): Don't assume that each subimage has the same
5910 dimensions as the base image. Handle disposal method that is
5911 "undefined" by the gif spec (Bug#9335).
5913 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
5915 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
5916 (Fcondition_case): Document `debug' symbol in error handler.
5918 2011-08-19 Eli Zaretskii <eliz@gnu.org>
5920 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5921 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5922 from an Org mode buffer to a Speedbar frame.
5924 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5925 a composition, take its buffer position from IT->cmp_it.charpos.
5926 Fixes cursor positioning at the beginning of a line that begins
5927 with a composed character.
5929 2011-08-18 Eli Zaretskii <eliz@gnu.org>
5931 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5932 character bidirectional type, use STRONG_L instead. Fixes crashes
5933 in a buffer produced by `describe-categories'.
5935 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5936 members before the level stack, so they would be saved and
5937 restored when copying iterator state. Fixes incorrect reordering
5938 around TABs covered by display properties.
5940 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5942 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
5944 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
5946 * eval.c (internal_condition_case, internal_condition_case_1)
5947 (internal_condition_case_2, internal_condition_case_n):
5948 Remove unnecessary aborts (Bug#9081).
5950 2011-08-17 Eli Zaretskii <eliz@gnu.org>
5952 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5953 has no `load' handler, try opening the file locally. (Bug#9311)
5955 2011-08-16 Ken Brown <kbrown@cornell.edu>
5957 * gmalloc.c: Expand comment.
5959 2011-08-16 Eli Zaretskii <eliz@gnu.org>
5961 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5962 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5964 2011-08-16 Ken Brown <kbrown@cornell.edu>
5966 Fix memory allocation problems in Cygwin build (Bug#9273).
5968 * unexcw.c ( __malloc_initialized): Declare external variable.
5969 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5971 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5973 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5975 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5977 [CYGWIN] (special_realloc): New function.
5978 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5979 requests to realloc storage in the static heap.
5981 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5983 * bidi.c (bidi_initialize): Remove unused local.
5985 2011-08-15 Eli Zaretskii <eliz@gnu.org>
5988 * biditype.h: Remove file.
5989 * makefile.w32-in ($(BLD)/bidi.$(O)):
5990 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
5992 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5994 * chartab.c: Improve commentary for the uniprop_table API.
5996 * bidi.c (bidi_paragraph_init): Support zero value of
5997 bidi_ignore_explicit_marks_for_paragraph_level.
5998 (bidi_initialize): Use uniprop_table instead of including
5999 biditype.h and bidimirror.h.
6001 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6002 coordinates of the iterator when restoring from ppos_it.
6005 2011-08-14 Kenichi Handa <handa@m17n.org>
6007 * process.c (create_process): Call setup_process_coding_systems
6008 after the pid of the process is set to -1 (Bug#8162).
6010 2011-08-14 Eli Zaretskii <eliz@gnu.org>
6012 * xdisp.c (move_it_in_display_line_to): Don't invoke
6013 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6014 ppos_it. Fixes vertical cursor motion when line beginning is
6015 covered by an image. (Bug#9296)
6017 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6019 * nsterm.h (ns_run_ascript): Declare.
6020 (NSAPP_DATA2_RUNASSCRIPT): Define.
6022 * nsfns.m (as_script, as_result, as_status): New static variables.
6023 (ns_run_ascript): New function.
6024 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
6025 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6026 the event loop. Get status from as_status (Bug#7276).
6028 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6029 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6030 the event loop (Bug#7276).
6032 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6034 * gnutls.c (QCgnutls_bootprop_priority)
6035 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6036 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6037 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6038 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6039 (QCgnutls_bootprop_verify_hostname_error)
6040 (QCgnutls_bootprop_callbacks_verify): Rename from
6041 Qgnutls_bootprop_..., all uses changed.
6043 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6046 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6048 * xfaces.c (Qframe_set_background_mode): Now static.
6049 * dispextern.h (Qframe_set_background_mode): Remove decl.
6051 * process.c (Fnetwork_interface_info): Declare local only if needed.
6053 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6055 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6056 (Fnetwork_interface_list): Allocate in increments of bytes instead
6057 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6058 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6060 (struct ifflag_def): notrailers is smart on OSX.
6061 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6062 Get hardware address with getifaddrs if available.
6064 2011-08-12 Eli Zaretskii <eliz@gnu.org>
6066 * xdisp.c (iterate_out_of_display_property): xassert that
6067 IT->position is set to within IT->object's boundaries. Break from
6068 the loop as soon as EOB is reached; avoids infloops in redisplay
6069 when IT->position is set up wrongly due to some bug.
6070 Set IT->current to match the bidi iterator unconditionally.
6071 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6072 entry. Force push_it to save on the stack the current
6073 buffer/string position, to be restored by pop_it. Fix flags in
6074 the iterator structure wrt the object coming from a display
6075 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6076 properties. (Bug#9284)
6078 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
6080 * fontset.c (fontset_get_font_group): Add proper type checks.
6083 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6085 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6086 and LC_VERSION_MIN_MACOSX.
6087 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6088 (dump_it) [LC_FUNCTION_STARTS]: Use it.
6090 2011-08-08 Eli Zaretskii <eliz@gnu.org>
6092 * xdisp.c (forward_to_next_line_start): Allow to use the
6093 no-display-properties-and-no-overlays under bidi display.
6094 Set disp_pos in the bidi iterator to avoid searches for display
6095 properties and overlays.
6097 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
6099 * editfns.c (Fset_time_zone_rule): Document relationship with the
6102 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6103 the font entity extracted from the cache (Bug#8109).
6105 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
6107 * composite.c (autocmp_chars): Don't reset point. That is done by
6108 restore_point_unwind (Bug#5984).
6110 2011-08-07 Juri Linkov <juri@jurta.org>
6112 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6113 to show the arg `TIME' instead of `TIMEVAL'.
6115 2011-08-06 Eli Zaretskii <eliz@gnu.org>
6117 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6118 display property strides EOL and includes a newline, as in
6119 longlines-mode. (Bug#9254)
6120 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6121 word-wrap under bidirectional display. (Bug#9224)
6123 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6124 is non-zero, even if the data buffer is NULL. Fixes a crash in
6125 vertical-motion with longlines-mode. (Bug#9254)
6127 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6129 * bidi.c <bidi_cache_total_alloc>: Now static.
6130 (bidi_initialize): Initialize bidi_cache_total_alloc.
6132 * xdisp.c (display_line): Release buffer allocated for shelved bidi
6135 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6136 amount allocated this far in `bidi_cache_total_alloc'.
6137 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6138 non-zero, only free the data buffer without restoring the cache
6139 contents. All callers changed.
6141 * dispextern.h (bidi_unshelve_cache): Update prototype.
6143 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6144 (move_it_in_display_line, move_it_to)
6145 (move_it_vertically_backward, move_it_by_lines): Replace the call
6146 to xfree to an equivalent call to bidi_unshelve_cache.
6147 (move_it_in_display_line_to): Fix logic of returning
6148 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
6150 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6152 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6153 came from a string character with a `cursor' property. (Bug#9229)
6155 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6157 * Makefile.in (LIB_PTHREAD): New variable.
6158 (LIBES): Add LIB_PTHREAD (Bug#9216).
6160 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6161 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6163 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6165 * regex.c (re_iswctype): Remove some redundant boolean conversions.
6167 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6169 * xterm.c (x_find_topmost_parent): New function.
6170 (x_set_frame_alpha): Find topmost parent window with
6171 x_find_topmost_parent and set the property there also (bug#9181).
6172 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6174 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6176 * callproc.c (Fcall_process): Avoid vfork clobbering
6177 the local vars buffer, coding_systems, current_dir.
6179 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6181 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6183 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6185 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6186 so that it is not optimized away.
6188 * xdisp.c (compute_display_string_pos): Remove unused local.
6190 2011-08-02 Eli Zaretskii <eliz@gnu.org>
6192 Fix slow cursor motion and scrolling in large buffers with
6193 selective display, like Org Mode buffers. (Bug#9218)
6195 * dispextern.h (struct bidi_it): New member disp_prop_p.
6197 * xdisp.c: Remove one-slot cache of display string positions.
6198 (compute_display_string_pos): Accept an additional argument
6199 DISP_PROP_P; callers changed. Scan at most 5K characters forward
6200 for a display string or property. If found, set DISP_PROP_P
6203 * bidi.c (bidi_fetch_char): Accept an additional argument
6204 DISP_PROP_P, and pass it to compute_display_string_pos.
6205 Only handle text covered by a display string if DISP_PROP_P is returned
6206 non-zero. All callers of bidi_fetch_char changed.
6208 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6210 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6212 2010-12-03 Don March <don@ohspite.net>
6214 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6215 last character M-[char] is translated to ESC [char] (bug#7541).
6217 2011-08-02 Kenichi Handa <handa@m17n.org>
6219 * lisp.h (uniprop_table): Extern it.
6221 * chartab.c (uniprop_table): Make it non-static.
6223 2011-08-01 Eli Zaretskii <eliz@gnu.org>
6225 * xdisp.c (forward_to_next_line_start): Accept additional argument
6226 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6228 (reseat_at_next_visible_line_start): Use the bidi iterator state
6229 returned by forward_to_next_line_start to restore the state of
6230 it->bidi_it after backing up to previous newline. (Bug#9212)
6232 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6234 * regex.c (re_comp): Protoize.
6235 (re_exec): Fix return type.
6236 (regexec): Fix type of `ret'. (Bug#9203)
6238 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6240 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6241 This is needed if max-image-size is a floating-point number.
6243 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6245 * print.c (print_object): Print empty symbol as ##.
6247 * lread.c (read1): Read ## as empty symbol.
6249 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6251 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6252 setting frame foreground color (Bug#9175).
6253 (x_set_background_color): Likewise.
6255 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6256 contents (Bug#9176).
6257 (EmacsTooltip -init): Remove bezels and add shadows to
6260 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6261 or scroll bar (Bug#8470).
6263 * nsfont.m (nsfont_open): Remove assignment to voffset and
6264 unnecessary vars hshink, expand, hd, full_height, min_height.
6265 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6267 * nsterm.h (nsfont_info): Remove voffset field.
6269 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6271 Implement strike-through and overline on NextStep (Bug#8863).
6273 * nsfont.m (nsfont_open): Use underline position provided by font,
6274 instead of hard-coded value of 2.
6275 (nsfont_draw): Call ns_draw_text_decoration instead.
6277 * nsterm.h: Add declaration for ns_draw_text_decoration.
6279 * nsterm.m (ns_draw_text_decoration): New function for drawing
6280 underline, overline, and strike-through.
6281 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6282 ns_draw_text_decoration. Change treatment of cursor drawing to
6283 accommodate underlining, etc.
6285 2011-07-28 Eli Zaretskii <eliz@gnu.org>
6287 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6290 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6292 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6293 Without this fix, if a signal arrives just after memory fills up,
6294 'malloc' might be invoked reentrantly.
6296 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6297 In other words, assume that every image size is allowed, on non-X
6298 hosts. This assumption is probably wrong, but it lets Emacs compile.
6300 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6302 * regex.c (re_iswctype): Convert return values to boolean.
6304 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6306 * xdisp.c (compute_display_string_pos): Don't use cached display
6307 string position if the buffer had its restriction changed.
6310 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6312 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6314 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6316 Integer signedness and overflow and related fixes. (Bug#9079)
6318 * bidi.c: Integer size and overflow fixes.
6319 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6320 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6321 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6322 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6323 (bidi_find_other_level_edge):
6324 Use ptrdiff_t instead of EMACS_INT where either will do.
6325 This works better on 32-bit hosts configured --with-wide-int.
6326 (bidi_cache_ensure_space): Check for size-calculation overflow.
6327 Use % rather than repeated addition, for better worst-case speed.
6328 Don't set bidi_cache_size until after xrealloc returns, because it
6330 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
6331 (bidi_cache_ensure_space): Also check that the bidi cache size
6332 does not exceed that of the largest Lisp string or buffer. See Eli
6333 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
6335 * alloc.c (__malloc_size_t): Remove.
6336 All uses replaced by size_t. See Andreas Schwab's note
6337 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6339 * image.c: Improve checking for integer overflow.
6340 (check_image_size): Assume that f is nonnull, since
6341 it is always nonnull in practice. This is one less thing to
6342 worry about when checking for integer overflow later.
6343 (x_check_image_size): New function, which checks for integer
6344 overflow issues inside X.
6345 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6346 This removes the need for a memory_full check.
6347 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6348 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6349 (xbm_read_bitmap_data): Change locals back to 'int', since
6350 their values must fit in 'int'.
6351 (xpm_load_image, png_load, tiff_load):
6352 Invoke x_create_x_image_and_pixmap earlier,
6353 to avoid much needless work if the image is too large.
6354 (tiff_load): Treat overly large images as if
6355 x_create_x_image_and_pixmap failed, not as malloc failures.
6356 (gs_load): Use x_check_image_size.
6358 * gtkutil.c: Omit integer casts.
6359 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6360 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6362 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6364 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6365 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6366 would wrongly return t on a 64-bit host.
6368 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6369 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6370 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6371 and therefore cause GCC to emit a bogus diagnostic in some cases.
6373 * image.c: Integer signedness and overflow and related fixes.
6374 This is not an exhaustive set of fixes, but it's time to
6375 record what I've got.
6376 (lookup_pixel_color, check_image_size): Remove redundant decls.
6377 (check_image_size): Don't assume that arbitrary EMACS_INT values
6378 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6379 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6380 (tiff_load, imagemagick_load_image):
6381 Check for overflow in size calculations.
6382 (x_create_x_image_and_pixmap): Remove unnecessary test for
6383 xmalloc returning NULL; that can't happen.
6384 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6385 (xpm_color_bucket): Use better integer hashing function.
6386 (xpm_cache_color): Don't possibly over-allocate memory.
6387 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6388 (gif_memory_source):
6389 Use ptrdiff_t, not int or size_t, to record sizes.
6390 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6391 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6392 either works, as we prefer signed integers.
6393 (tiff_read_from_memory, tiff_write_from_memory):
6394 Return tsize_t, not size_t, since that's what the TIFF API wants.
6395 (tiff_read_from_memory): Don't fail simply because the read would
6396 go past EOF; instead, return a short read.
6397 (tiff_load): Omit no-longer-needed casts.
6398 (Fimagemagick_types): Don't assume size fits into 'int'.
6400 Improve hashing quality when configured --with-wide-int.
6401 * fns.c (hash_string): New function, taken from sxhash_string.
6402 Do not discard information about ASCII character case; this
6403 discarding is no longer needed.
6404 (sxhash-string): Use it. Change sig to match it. Caller changed.
6405 * lisp.h: Declare it.
6406 * lread.c (hash_string): Remove, since we now use fns.c's version.
6407 The fns.c version returns a wider integer if --with-wide-int is
6408 specified, so this should help the quality of the hashing a bit.
6410 * emacs.c: Integer overflow minor fix.
6411 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6412 Define only if GNU_LINUX.
6413 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6415 * dispnew.c: Integer signedness and overflow fixes.
6416 Remove unnecessary forward decls, that were a maintenance hassle.
6417 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6419 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6420 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6421 (prepare_desired_row, line_draw_cost):
6422 Use int, not unsigned, where either works.
6423 (save_current_matrix, restore_current_matrix):
6424 Use ptrdiff_t, not size_t, where either works.
6425 (init_display): Check for overflow more accurately, and without
6426 relying on undefined behavior.
6428 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6429 Remove, replacing with the new symbols in lisp.h. All uses changed.
6430 * fileio.c (make_temp_name):
6431 * filelock.c (lock_file_1, lock_file):
6432 * xdisp.c (message_dolog):
6433 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6434 Use pMd etc. instead.
6435 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6436 replacing the pWIDE etc. symbols removed from editfns.c.
6438 * keyboard.h (num_input_events): Now uintmax_t.
6439 This is (very slightly) less likely to mess up due to wraparound.
6442 * buffer.c: Integer signedness fixes.
6443 (alloc_buffer_text, enlarge_buffer_text):
6444 Use ptrdiff_t rather than size_t when either will do, as we prefer
6447 * alloc.c: Integer signedness and overflow fixes.
6448 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6449 (__malloc_size_t): Default to size_t, not to int.
6450 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6451 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6452 Prefer ptrdiff_t to size_t when either would do, as we prefer
6454 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6455 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6456 Now const. Initialize with values that are in range even if char
6458 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6459 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6460 These functions do the right thing with sizes > 2**32.
6461 (check_depth): Now ptrdiff_t, not int.
6462 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6463 Adjust to new way of storing sizes. Check for size overflow bugs
6465 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6466 slightly wrong anyway, as it missed one instance of
6467 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6468 (refill_memory_reserve): Omit needless cast to size_t.
6469 (mark_object_loop_halt): Mark as externally visible.
6471 * xselect.c: Integer signedness and overflow fixes.
6472 (Fx_register_dnd_atom, x_handle_dnd_message):
6473 Use ptrdiff_t, not size_t, since we prefer signed.
6474 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6475 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6476 x_dnd_atoms_size and x_dnd_atoms_length.
6478 * doprnt.c: Prefer signed to unsigned when either works.
6480 * doprnt.c (doprnt):
6482 * xdisp.c (vmessage):
6483 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6484 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6485 prefer signed arithmetic to avoid comparison confusion.
6486 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6487 but is a bit tricky.
6489 Assume freestanding C89 headers, string.h, stdlib.h.
6490 * data.c, doprnt.c, floatfns.c, print.c:
6491 Include float.h unconditionally.
6492 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6493 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6494 * regex.c: Likewise for stddef.h, string.h.
6495 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6496 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6497 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6498 (STDC_HEADERS): Remove obsolete defines.
6499 * sysdep.c: Include limits.h unconditionally.
6501 Assume support for memcmp, memcpy, memmove, memset.
6502 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6503 * regex.c (memcmp, memcpy):
6504 Remove; we assume C89 now.
6506 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6507 (__malloc_safe_bcopy): Remove; no longer needed.
6509 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6510 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6511 well either way, and we prefer signed to unsigned.
6513 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6515 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6516 closes the connection while we're reading (bug#9182).
6518 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
6520 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6521 are specified (Bug#9168).
6523 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6525 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6526 Found by GCC static checking and --with-wide-int on a 32-bit host.
6528 2011-07-25 Eli Zaretskii <eliz@gnu.org>
6530 * xdisp.c (compute_display_string_pos): Fix logic of caching
6531 previous display string position. Initialize cached_prev_pos to
6532 -1. Fixes slow-down at the beginning of a buffer.
6534 2011-07-24 Eli Zaretskii <eliz@gnu.org>
6536 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6537 for attrs[LFACE_FONTSET_INDEX].
6539 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6541 * xml.c (parse_region): Remove unused local
6542 that was recently introduced.
6544 2011-07-23 Eli Zaretskii <eliz@gnu.org>
6546 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6547 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6549 * xdisp.c (move_it_in_display_line_to): Record the best matching
6550 position for TO_CHARPOS while scanning the line, and restore it on
6551 exit if none of the characters scanned was an exact match.
6552 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
6553 when exact match is impossible due to invisible text, and the
6554 lines are truncated.
6556 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6558 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6561 2011-07-22 Eli Zaretskii <eliz@gnu.org>
6563 Fix a significant slow-down of cursor motion with C-n, C-p,
6564 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6565 auto-repeat under bidi redisplay in fontified buffers.
6566 * xdisp.c (compute_stop_pos_backwards): New function.
6567 (next_element_from_buffer): Call compute_stop_pos_backwards to
6568 find a suitable prev_stop when we find ourselves before
6570 (reseat): Don't look for prev_stop, as that could mean a very long
6572 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6573 <cached_disp_overlay_modiff>: Cache for last found display string
6575 (compute_display_string_pos): Return the cached position if asked
6576 about the same buffer in the same area of character positions, and
6577 the buffer wasn't changed since the time the display string
6578 position was cached.
6580 2011-07-22 Eli Zaretskii <eliz@gnu.org>
6582 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6583 is an integer, which is important for empty lines. (Bug#9149)
6585 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
6587 * frame.c (Fmodify_frame_parameters): In tty case, update the
6588 default face if necessary (Bug#4238).
6590 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
6592 * editfns.c (Fstring_to_char): No need to explain what a character
6593 is in the docstring (Bug#6576).
6595 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6597 * xml.c (parse_region): Make sure we always return a tree.
6599 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6601 * xml.c (parse_region): If a document contains only comments,
6604 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6606 * xml.c (make_dom): Return comments, too.
6608 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6611 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6612 and the surrounding thread.
6613 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6614 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6615 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6617 * s/openbsd.h (BROKEN_SIGIO): Define.
6618 * unexelf.c (unexec) [__OpenBSD__]:
6619 Don't update the .mdebug section of the Alpha COFF symbol table.
6621 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6623 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6626 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6628 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6629 This fixes some race conditions on the permissions of any newly
6632 * alloc.c (valid_pointer_p): Use pipe, not open.
6633 This fixes some permissions issues when debugging.
6635 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6636 If fchown fails to set both uid and gid, try to set just gid,
6637 as that is sometimes allowed. Adjust the file's mode to eliminate
6638 setuid or setgid bits that are inappropriate if fchown fails.
6640 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6642 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6643 to compare Lisp_Objects.
6644 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6645 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6646 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6648 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6650 * lread.c (read_integer): Unread even EOF character.
6651 (read1): Likewise. Properly record start position of symbol.
6653 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6654 symbol character follows.
6656 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6658 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6659 This works around a problem with the previous change to Fcopy_file.
6660 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6661 and without this change, GCC might complain about discarding
6662 fchown's return value.
6664 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
6666 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6668 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6670 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6672 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6674 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6675 it's used from the C level.
6677 * process.c: Use the same condition for POLL_FOR_INPUT in both
6678 keyboard.c and process.c (bug#1858).
6680 2011-07-09 Lawrence Mitchell <wence@gmx.li>
6682 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6683 (Fgnutls_boot): Use it.
6685 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6687 * doc.c (Fsubstitute_command_keys): Revert last change.
6689 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6691 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6692 quotes the next character, and doesn't affect other longer
6693 sequences (bug#8935).
6695 * lread.c (syms_of_lread): Clarify that is isn't only
6696 `eval-buffer' and `eval-defun' that's affected by
6697 `lexical-binding' (bug#8460).
6699 2011-07-15 Eli Zaretskii <eliz@gnu.org>
6701 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6702 bidi redisplay when a line includes both an image and is truncated.
6704 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6706 Fix minor problems found by static checking.
6707 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6708 (elsz): Now a signed constant, not a size_t var. We prefer signed
6709 types to unsigned, to avoid integer comparison confusion. Without
6710 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6711 "cannot optimize loop, the loop counter may overflow", a symptom
6713 * indent.c (Fvertical_motion): Mark locals as initialized.
6714 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6716 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6718 * search.c (Fre_search_backward): Mention `case-fold-search' in
6719 all the re_search_* functions (bug#8138).
6721 * keyboard.c (Fopen_dribble_file): Document when the file is
6724 2011-07-14 Eli Zaretskii <eliz@gnu.org>
6726 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6729 Support bidi reordering of display and overlay strings.
6730 * xdisp.c (compute_display_string_pos)
6731 (compute_display_string_end): Accept additional argument STRING.
6732 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6733 (reseat_to_string): Initialize bidi_it->string.s and
6734 bidi_it->string.schars.
6735 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
6736 NULL (avoids a crash in bidi_paragraph_init).
6737 Initialize itb.string.lstring.
6738 (init_iterator): Call bidi_init_it only of a valid
6739 buffer position was specified. Initialize paragraph_embedding to
6741 (reseat_to_string): Initialize the bidi iterator.
6742 (display_string): If we need to ignore text properties of
6743 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6744 original value of -1 will not work with bidi.)
6745 (compute_display_string_pos): First arg is now struct
6746 `text_pos *'; all callers changed. Support display properties on
6748 (compute_display_string_end): Support display properties on Lisp
6750 (init_iterator, reseat_1, reseat_to_string): Initialize the
6751 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6752 when iterating on a string not from display properties).
6753 (compute_display_string_pos, compute_display_string_end):
6754 Fix calculation of the object to scan. Fixes an error when using
6756 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
6757 base_level_stop; instead, set base_level_stop to BEGV.
6758 Fixes crashes in vertical-motion.
6759 (next_element_from_buffer): Improve commentary for when
6760 the iterator is before prev_stop.
6761 (init_iterator): Initialize bidi_p from the default value of
6762 bidi-display-reordering, not from buffer-local value. Use the
6763 buffer-local value only if initializing for buffer iteration.
6764 (handle_invisible_prop): Support invisible properties on strings
6765 that are being bidi-reordered.
6766 (set_iterator_to_next): Support bidi reordering of C strings and
6768 (next_element_from_string): Support bidi reordering of Lisp
6770 (handle_stop_backwards): Support Lisp strings as well.
6771 (display_string): Support display of R2L glyph rows.
6772 Use IT_STRING_CHARPOS when displaying from a Lisp string.
6773 (init_iterator): Don't initialize it->bidi_p for strings
6775 (reseat_to_string): Initialize it->bidi_p for strings here.
6776 (next_element_from_string, next_element_from_c_string)
6777 (next_element_from_buffer): Add xassert's for correspondence
6778 between IT's object being iterated and it->bidi_it.string
6780 (face_before_or_after_it_pos): Support bidi iteration.
6781 (next_element_from_c_string): Handle the case of the first string
6782 character that is not the first one in the visual order.
6783 (get_visually_first_element): New function, refactored from common
6784 parts of next_element_from_buffer, next_element_from_string, and
6785 next_element_from_c_string.
6786 (tool_bar_lines_needed, redisplay_tool_bar)
6787 (display_menu_bar): Force left-to-right direction. Add a FIXME
6788 comment for making that be controlled by a user option.
6789 (push_it, pop_it): Save and restore the state of the
6790 bidi iterator. Save and restore the bidi_p flag.
6791 (pop_it): Iterate out of display property for string iteration as
6793 (iterate_out_of_display_property): Support iteration over strings.
6794 (handle_single_display_spec): Set up it->bidi_it for iteration
6795 over a display string, and call bidi_init_it.
6796 (handle_single_display_spec, next_overlay_string)
6797 (get_overlay_strings_1, push_display_prop): Set up the bidi
6798 iterator for displaying display or overlay strings.
6799 (forward_to_next_line_start): Don't use the shortcut if
6801 (back_to_previous_visible_line_start): If handle_display_prop
6802 pushed the iterator stack, restore the internal state of the bidi
6803 iterator by calling bidi_pop_it same number of times.
6804 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6805 and we are bidi-iterating, don't decrement the iterator position;
6806 instead, set the first_elt flag in the bidi iterator, to produce
6808 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6809 (push_display_prop): xassert that we are iterating a buffer.
6810 (push_it, pop_it): Save and restore paragraph_embedding member.
6811 (handle_single_display_spec, next_overlay_string)
6812 (get_overlay_strings_1, reseat_1, reseat_to_string)
6813 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6814 correctly. Don't assume unibyte strings are not bidi-reordered.
6815 (compute_display_string_pos)
6816 (compute_display_string_end): Fix handling the case of C string.
6817 (push_it, pop_it): Save and restore from_disp_prop_p.
6818 (handle_single_display_spec, push_display_prop): Set the
6819 from_disp_prop_p flag.
6820 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6821 (pop_it): Call iterate_out_of_display_property only if we are
6822 popping after iteration over a string that came from a display
6823 property. Fix a typo in popping stretch info. Add an assertion
6824 for verifying that the iterator position is in sync with the bidi
6826 (handle_single_display_spec, get_overlay_strings_1)
6827 (push_display_prop): Fix initialization of paragraph direction for
6828 string when that of the parent object is not yet determined.
6829 (reseat_1): Call bidi_init_it to resync the bidi
6830 iterator with IT's position. (Bug#7616)
6831 (find_row_edges): If ROW->start.pos gives position
6832 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6833 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6834 Reset the from_disp_prop_p flag.
6835 (SAVE_IT, RESTORE_IT): New macros.
6836 (pos_visible_p, face_before_or_after_it_pos)
6837 (back_to_previous_visible_line_start)
6838 (move_it_in_display_line_to, move_it_in_display_line)
6839 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6840 (try_scrolling, redisplay_window, display_line): Use them when
6841 saving a temporary copy of the iterator and restoring it back.
6842 (back_to_previous_visible_line_start, reseat_1)
6843 (init_iterator): Empty the bidi cache "stack".
6844 (move_it_in_display_line_to): If iterator ended up at
6845 EOL, but we never saw any buffer positions smaller than
6846 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6847 motion in bidi-reordered lines.
6848 (move_it_in_display_line_to): Record prev_method and prev_pos
6849 immediately before the call to set_iterator_to_next. Fixes cursor
6850 motion in bidi-reordered lines with stretch glyphs and strings
6851 displayed in margins. (Bug#8133) (Bug#8867)
6852 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6854 (pos_visible_p): Support positions in bidi-reordered lines.
6855 Save and restore bidi cache.
6857 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6858 (bidi_paragraph_info): Delete unused struct.
6859 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6860 (bidi_cache_start): New variable.
6861 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6863 (bidi_cache_fetch_state, bidi_cache_search)
6864 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6865 (bidi_cache_find, bidi_peek_at_next_level)
6866 (bidi_level_of_next_char, bidi_find_other_level_edge)
6867 (bidi_move_to_visually_next): Compare cache index with
6868 bidi_cache_start rather than with zero.
6869 (bidi_fetch_char): Accept new argument STRING; all callers
6870 changed. Support iteration over a string. Support strings with
6871 display properties. Support unibyte strings. Fix the type of
6872 `len' according to what STRING_CHAR_AND_LENGTH expects.
6873 (bidi_paragraph_init, bidi_resolve_explicit_1)
6874 (bidi_resolve_explicit, bidi_resolve_weak)
6875 (bidi_level_of_next_char, bidi_move_to_visually_next):
6876 Support iteration over a string.
6877 (bidi_set_sor_type, bidi_resolve_explicit_1)
6878 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6879 can now be zero (for strings); special values 0 and -1 were
6880 changed to -1 and -2, respectively.
6881 (bidi_char_at_pos): New function.
6882 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6883 Call it instead of FETCH_MULTIBYTE_CHAR.
6884 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6885 initialized to valid values.
6886 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6888 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6889 the test for valid cached positions. Fix the logic for looking up
6890 the sentinel state in the cache. GCPRO the Lisp string we are
6892 (bidi_push_it, bidi_pop_it): New functions.
6893 (bidi_initialize): Initialize the bidi cache start stack pointer.
6894 (bidi_cache_ensure_space): New function, refactored from part of
6895 bidi_cache_iterator_state. Don't assume the required size is just
6896 one BIDI_CACHE_CHUNK away.
6897 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6898 (bidi_count_bytes, bidi_char_at_pos): New functions.
6899 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6900 always valid if bidi_cache_idx is valid.
6901 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6902 is valid if it's going to be used.
6903 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6904 (bidi_cache_fetch_state, bidi_cache_search)
6905 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6906 (bidi_cache_iterator_state, bidi_cache_find)
6907 (bidi_find_other_level_edge, bidi_cache_start_stack):
6908 All variables related to cache indices are now EMACS_INT.
6910 * dispextern.h (struct bidi_string_data): New structure.
6911 (struct bidi_it): New member `string'. Make flag members be 1-bit
6912 fields, and put them last in the struct.
6913 (compute_display_string_pos, compute_display_string_end):
6915 (bidi_push_it, bidi_pop_it): Add prototypes.
6916 (struct iterator_stack_entry): New members bidi_p,
6917 paragraph_embedding, and from_disp_prop_p.
6918 (struct it): Member bidi_p is now a bit field 1 bit wide.
6919 (bidi_shelve_cache, bidi_unshelve_cache):
6922 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6923 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6924 and vector-like objects.
6926 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6927 cache around display iteration.
6929 * window.c (Fwindow_end, window_scroll_pixel_based)
6930 (displayed_window_lines, Frecenter): Save and restore the bidi
6931 cache around display iteration.
6933 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6935 * editfns.c (Fdelete_region): Clarify the use of the named
6936 parameters (bug#6788).
6938 2011-07-14 Martin Rudalics <rudalics@gmx.at>
6940 * indent.c (Fvertical_motion): Set and restore w->pointm when
6941 saving and restoring the window's buffer (Bug#9006).
6943 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6945 * editfns.c (Fstring_to_char): Clarify just what is returned
6946 (bug#6576). Text by Eli Zaretskii.
6948 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
6950 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6952 2011-07-13 Eli Zaretskii <eliz@gnu.org>
6954 * buffer.c (mmap_find): Fix a typo.
6956 2011-07-13 Johan Bockgård <bojohan@gnu.org>
6958 Fix execution of x selection hooks.
6959 * xselect.c (Qx_lost_selection_functions)
6960 (Qx_sent_selection_functions): New vars.
6961 (syms_of_xselect): DEFSYM them.
6962 (x_handle_selection_request): Pass Qx_sent_selection_functions
6963 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6964 (x_handle_selection_clear,x_clear_frame_selections):
6965 Pass Qx_lost_selection_functions rather than
6966 Vx_lost_selection_functions to Frun_hook_with_args.
6968 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6970 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
6971 The old code sometimes used this field without initializing it.
6973 * alloc.c (gc_sweep): Don't read past end of array.
6974 In theory, the old code could also have corrupted Emacs internals,
6975 though it'd be very unlikely.
6977 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6979 * character.c (Fcharacterp): Don't advertise optional ignored
6980 argument. (Bug#4026)
6982 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6984 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6987 * window.c (Fset_window_start): Doc fix (bug#4199).
6988 (Fset_window_hscroll): Ditto.
6990 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6992 Fix minor new problems caught by GCC 4.6.1.
6993 * term.c (init_tty): Remove unused local.
6994 * xsettings.c (store_monospaced_changed): Define this function only
6995 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
6998 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
7000 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7002 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7004 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7005 are the mini-buffer and the echo area (bug#3320).
7007 * term.c (init_tty): Remove support for supdup, c10 and perq
7008 terminals, which are no longer supported (bug#1482).
7010 2011-07-10 Johan Bockgård <bojohan@gnu.org>
7012 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7014 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7016 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7017 for non-popups (Bug#3642).
7019 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7021 * alloc.c (reset_malloc_hooks): Protoize.
7022 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
7023 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7024 * cm.c (losecursor): Likewise.
7025 * data.c (fmod): Likewise.
7026 * dispnew.c (swap_glyphs_in_rows): Likewise.
7027 * emacs.c (memory_warning_signal): Likewise.
7028 * floatfns.c (float_error): Likewise.
7029 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7030 (otf_open, font_otf_capability, generate_otf_features)
7031 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7033 * image.c (pbm_read_file): Likewise.
7034 * indent.c (string_display_width): Likewise.
7035 * intervals.c (check_for_interval, search_for_interval)
7036 (inc_interval_count, count_intervals, root_interval)
7037 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7038 * lread.c (defalias): Likewise.
7039 * ralloc.c (r_alloc_check): Likewise.
7040 * regex.c (set_image_of_range_1, set_image_of_range)
7041 (regex_grow_registers): Likewise.
7042 * sysdep.c (strerror): Likewise.
7043 * termcap.c (valid_filename_p, tprint, main): Likewise.
7044 * tparam.c (main): Likewise.
7045 * unexhp9k800.c (run_time_remap, save_data_space)
7046 (update_file_ptrs, read_header, write_header, calculate_checksum)
7047 (copy_file, copy_rest, display_header): Likewise.
7048 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7050 * xdisp.c (check_it): Likewise.
7051 * xfaces.c (register_color, unregister_color, unregister_colors):
7053 * xfns.c (print_fontset_result): Likewise.
7054 * xrdb.c (member, fatal, main): Likewise.
7056 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7058 Fix minor problems found by static checking (Bug#9031).
7059 * chartab.c (char_table_set_range, map_sub_char_table):
7060 Remove unused locals.
7061 (uniprop_table): Now static.
7062 * composite.c (_work_char): Remove unused static var.
7064 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
7066 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7068 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7070 * gtkutil.c (qttip_cb): Remove code without function.
7072 2011-07-09 Eli Zaretskii <eliz@gnu.org>
7074 * w32.c (pthread_sigmask): New stub.
7076 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
7078 Use pthread_sigmask, not sigprocmask (Bug#9010).
7079 sigprocmask is portable only for single-threaded applications, and
7080 Emacs can be multi-threaded when it uses GTK.
7081 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7083 * callproc.c (Fcall_process):
7084 * process.c (create_process):
7085 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7086 Use pthread_sigmask, not sigprocmask.
7088 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7090 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7091 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7094 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7096 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7097 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7098 (xg_hide_tooltip): Fix comment.
7100 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7101 in registerServicesMenuSendTypes.
7102 (validRequestorForSendType): Don't check ns_return_types.
7104 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7107 2011-07-08 Jason Rumney <jasonr@gnu.org>
7109 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7110 SH_SHOW for hidden windows (Bug#5482).
7112 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7113 frame struct members of non-existent frames (Bug#6284).
7115 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7117 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7118 variable firstTime not needed on OSX >= 10.6.
7119 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7120 >= 10.5. Use setKnobProportion, setDoubleValue.
7122 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7123 (MAC_OS_X_VERSION_10_5): Define if not defined.
7124 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7125 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7126 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7128 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7129 cString and lossyCString on OSX >= 10.4
7131 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
7132 sizeToFit on OSX >= 10.2.
7134 * nsimage.m (allocInitFromFile): Don't use deprecated method
7135 bestRepresentationForDevice on OSX >= 10.6.
7137 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7140 * emacs.c: Declare unexec_init_emacs_zone.
7142 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7144 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7146 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7147 on svcsMenu (Bug#8842).
7149 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7151 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7153 * nsterm.m (QUTF8_STRING): Declare.
7154 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7155 (validRequestorForSendType): Return type is (id).
7156 Change indexOfObjectIdenticalTo to indexOfObject.
7157 Check if we have local selection before returning self (Bug#8842).
7158 (writeSelectionToPasteboard): Put local selection into paste board
7159 if we have a local selection (Bug#8842).
7160 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7162 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7163 (ns_get_local_selection): Declare.
7165 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7167 * keymap.c (describe_map_tree): Don't insert a double newline at
7168 the end of the buffer (bug#1169) and return whether we inserted
7171 * callint.c (Fcall_interactively): Change "reading args" to
7172 "providing args" to try to clarify what it does (bug#1010).
7174 2011-07-07 Kenichi Handa <handa@m17n.org>
7176 * composite.c (composition_compute_stop_pos): Ignore a static
7177 composition starting before CHARPOS (Bug#8915).
7179 * xdisp.c (handle_composition_prop): Likewise.
7181 2011-07-07 Eli Zaretskii <eliz@gnu.org>
7183 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7186 2011-07-07 Kenichi Handa <handa@m17n.org>
7188 * character.h (unicode_category_t): New enum type.
7190 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7191 (Qchar_code_property_table): New variable.
7192 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7193 (UNIPROP_COMPRESSED_FORM_P): New macros.
7194 (char_table_ascii): Uncompress the compressed values.
7195 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7196 Uncompress the compressed values.
7197 (sub_char_table_ref_and_range): Likewise.
7198 (char_table_ref_and_range): Uncompress the compressed values.
7199 (sub_char_table_set): New arg is_uniprop. Callers changed.
7200 Uncompress the compressed values.
7201 (sub_char_table_set_range): Args changed. Callers changed.
7202 (char_table_set_range): Adjuted for the above change.
7203 (map_sub_char_table): Delete args default_val and parent. Add arg
7204 top. Give decoded values to a Lisp function.
7205 (map_char_table): Adjust for the above change. Give decoded
7206 values to a Lisp function. Gcpro more variables.
7207 (uniprop_table_uncompress)
7208 (uniprop_decode_value_run_length): New functions.
7209 (uniprop_decoder, uniprop_decoder_count): New variables.
7210 (uniprop_get_decoder, uniprop_encode_value_character)
7211 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7213 (uniprop_encoder, uniprop_encoder_count): New variables.
7214 (uniprop_get_encoder, uniprop_table)
7215 (Funicode_property_table_internal, Fget_unicode_property_internal)
7216 (Fput_unicode_property_internal): New functions.
7217 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7218 Sunicode_property_table_internal, Sget_unicode_property_internal,
7219 and Sput_unicode_property_internal. Defvar_lisp
7220 char-code-property-alist.
7222 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
7223 Vunicode_category_table.
7225 * font.c (font_range): Adjust for the change of
7226 Vunicode_category_table.
7228 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7230 * m/iris4d.h: Remove file, move contents ...
7231 * s/irix6-5.h: ... here.
7233 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7235 Remove unportable assumption about struct layout (Bug#8884).
7236 * alloc.c (mark_buffer):
7237 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7238 (clone_per_buffer_values): Don't assume that
7239 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7240 This isn't true in general, and it's particularly not true
7241 if Emacs is configured with --with-wide-int.
7242 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7243 New macros, used in the buffer.c change.
7245 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7247 * xsettings.c: Use both GConf and GSettings if both are available.
7248 (store_config_changed_event): Add comment.
7249 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7250 (store_tool_bar_style_changed): New functions.
7251 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
7252 (struct xsettings): Move font inside HAVE_XFT.
7253 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
7254 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
7255 Move inside HAVE_XFT.
7256 (something_changed_gsettingsCB): Rename from something_changedCB.
7257 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7259 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
7260 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
7261 (something_changed_gconfCB): Rename from something_changedCB.
7262 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7263 (parse_settings): Move check for font inside HAVE_XFT.
7264 (read_settings, apply_xft_settings): Add comment.
7265 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7266 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7267 call store_font_name_changed.
7268 (xft_settings_event): Add comment.
7269 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7270 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7271 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7272 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7273 (xsettings_initialize): Call init_gsettings last.
7274 (xsettings_get_system_font, xsettings_get_system_normal_font):
7277 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7279 Random fixes. E.g., (random) never returned negative values.
7280 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7281 subseconds part to the entropy, as that's a bit more random.
7282 Prefer signed to unsigned, since the signedness doesn't matter and
7283 in general we prefer signed. When given a limit, use a
7284 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7285 latter isn't right if USE_2_TAGS_FOR_INTS.
7286 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7287 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7289 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7291 * textprop.c (text_property_stickiness):
7292 Obey Vtext_property_default_nonsticky.
7293 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7294 * w32fns.c (syms_of_w32fns):
7295 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7297 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7299 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7300 This is more efficient than Ffile_directory_p and avoids a minor race.
7302 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7304 * buffer.c (Foverlay_put): Say what the return value is
7307 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7308 is a directory before asking whether to use the file name
7310 (barf_or_query_if_file_exists): Make the "File is a directory"
7311 error be more correct.
7313 * fns.c (Frequire): Remove the mention of the .gz files, since
7314 that's installation-specific, but keep the mention of
7315 `get-load-suffixes'.
7317 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7319 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7320 Report string overflow if the output is too long.
7322 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
7324 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7325 (syms_of_gnutls): Remove duplicate DEFSYM for
7326 Qgnutls_bootprop_verify_hostname_error, an error for
7327 Qgnutls_bootprop_verify_error (which is no longer used).
7329 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7330 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7331 Also (re)move comments that are misplaced or no longer relevant.
7333 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7335 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7337 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
7339 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7340 and background color parameters if they have been changed.
7342 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7344 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7346 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7348 * xsettings.c (SYSTEM_FONT): Define only when used.
7349 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7351 * keymap.c (access_keymap_1): Now static.
7353 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
7355 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7356 leave any prefix arg for the up event (Bug#1586).
7358 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7360 * lread.c (syms_of_lread): Mention single symbols defined by
7361 `defvar' or `defconst' (bug#7154).
7363 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7364 (Frequire): Mention get-load-suffixes.
7366 2011-07-02 Martin Rudalics <rudalics@gmx.at>
7368 * window.h (window): Remove clone_number slot.
7369 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7371 (make_parent_window, make_window, saved_window)
7372 (Fset_window_configuration, save_window_save): Don't deal with
7374 * buffer.c (Qclone_number): Remove declaration.
7375 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7377 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7379 Add multiple inheritance to keymaps.
7380 * keymap.c (Fmake_composed_keymap): New function.
7381 (Fset_keymap_parent): Simplify.
7382 (fix_submap_inheritance): Remove.
7383 (access_keymap_1): New function extracted from access_keymap to handle
7384 embedded parents and handle lists of maps.
7385 (access_keymap): Use it.
7386 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7387 (Fcopy_keymap): Handle embedded parents.
7388 (Fcommand_remapping, define_as_prefix): Simplify.
7389 (Fkey_binding): Simplify.
7390 (syms_of_keymap): Move minibuffer-local-completion-map,
7391 minibuffer-local-filename-completion-map,
7392 minibuffer-local-must-match-map, and
7393 minibuffer-local-filename-must-match-map to Elisp.
7394 (syms_of_keymap): Defsubr make-composed-keymap.
7395 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7396 (parse_menu_item): Trivial simplification.
7398 2011-07-01 Glenn Morris <rgm@gnu.org>
7400 * Makefile.in (SETTINGS_LIBS): Fix typo.
7402 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7404 * coding.c (Fencode_coding_string): Record the last coding system
7405 used, as the function doc string says (bug#8738).
7407 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7409 * xsettings.c (store_monospaced_changed): Take new font as arg and
7410 check for change against current_mono_font.
7411 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7412 (emacs_settings_constructor, emacs_settings_get_property)
7413 (emacs_settings_set_property, emacs_settings_class_init)
7414 (emacs_settings_init, gsettings_obj): Remove.
7415 (something_changedCB): New function for HAVE_GSETTINGS.
7416 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7417 with value as argument.
7418 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7419 g_settings_new (Bug#8967). Do not create gsettings_obj.
7420 Remove calls to g_settings_bind. Connect something_changedCB to
7423 * xgselect.c: Add defined (HAVE_GSETTINGS).
7424 (xgselect_initialize): Ditto.
7426 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7427 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7430 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7432 * eval.c (struct backtrace): Simplify and port the data structure.
7433 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7434 signed bit field, as this assumption is not portable and it makes
7435 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7436 "char debug_on_exit : 1" as this is not portable either; instead,
7437 use the portable "unsigned int debug_on_exit : 1". Remove unused
7438 member evalargs. Remove obsolete comments about cc bombing out.
7440 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7442 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
7443 Let HAVE_GSETTINGS override HAVE_GCONF.
7444 (store_monospaced_changed): New function.
7445 (EMACS_SETTINGS): A new type derived from GObject to handle
7446 GSettings notifications.
7447 (emacs_settings_constructor, emacs_settings_get_property)
7448 (emacs_settings_set_property, emacs_settings_class_init):
7450 (gsettings_client, gsettings_obj): New variables.
7451 (GSETTINGS_SCHEMA): New define.
7452 (something_changedCB): Call store_monospaced_changed.
7453 (init_gsettings): New function.
7454 (xsettings_initialize): Call init_gsettings.
7455 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7458 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
7461 2011-06-29 Martin Rudalics <rudalics@gmx.at>
7463 * window.c (resize_root_window, grow_mini_window)
7464 (shrink_mini_window): Rename Qresize_root_window to
7465 Qwindow_resize_root_window and Qresize_root_window_vertically to
7466 Qwindow_resize_root_window_vertically.
7468 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7470 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7472 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
7474 * makefile.w32-in: Redesign dependencies so they reflect more
7475 clearly which files are directly included by each source file,
7476 and not through other includes.
7478 2011-06-27 Martin Rudalics <rudalics@gmx.at>
7480 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7481 (sort_overlays, overlay_strings): When an overlay's clone number
7482 matches the window's clone number process the overlay even if
7483 the overlay's window property doesn't match the current window.
7485 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7486 (Fwindow_hchild): Rename to Fwindow_left_child.
7487 (Fwindow_next): Rename to Fwindow_next_sibling.
7488 (Fwindow_prev): Rename to Fwindow_prev_sibling.
7489 (resize_window_check): Rename to window_resize_check.
7490 (resize_window_apply): Rename to window_resize_apply.
7491 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7492 (Fdelete_other_windows_internal, resize_frame_windows)
7493 (Fsplit_window_internal, Fdelete_window_internal)
7494 (grow_mini_window, shrink_mini_window)
7495 (Fresize_mini_window_internal): Fix callers accordingly.
7497 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7499 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7500 (emacs_fixed_set_min_size): Remove.
7501 (emacs_fixed_new): Take frame as argument.
7503 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7504 (_EmacsFixedPrivate): Remove minwidth/height.
7505 Add struct frame *f.
7506 (emacs_fixed_init): Initialize priv->f.
7507 (get_parent_class, emacs_fixed_set_min_size): Remove.
7508 (emacs_fixed_new): Set priv->f to argument.
7509 (emacs_fixed_get_preferred_width)
7510 (emacs_fixed_get_preferred_height): Use min_width/height from
7511 frames size_hint to set minimum and natural (Bug#8919).
7512 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7513 and use min_width/height from frames size_hint to set
7514 min_width/height (Bug#8919).
7516 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
7517 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7520 2011-06-26 Eli Zaretskii <eliz@gnu.org>
7522 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7523 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7526 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
7528 * process.c (wait_reading_process_output): Bypass select if
7529 waiting for a cell while ignoring keyboard input, and input is
7530 pending. Suggested by Jan Djärv (Bug#8869).
7532 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7534 Use gnulib's dup2 module instead of rolling our own.
7535 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7537 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7539 * dispnew.c (scrolling_window): Before scrolling, turn off a
7540 mouse-highlight in the window being scrolled.
7542 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
7544 Move DEFSYM to lisp.h and use everywhere.
7546 * character.h (DEFSYM): Move declaration...
7547 * lisp.h (DEFSYM): ...here.
7553 * w32select.c: Don't include character.h.
7555 * alloc.c (syms_of_alloc):
7556 * buffer.c (syms_of_buffer):
7557 * bytecode.c (syms_of_bytecode):
7558 * callint.c (syms_of_callint):
7559 * casefiddle.c (syms_of_casefiddle):
7560 * casetab.c (init_casetab_once):
7561 * category.c (init_category_once, syms_of_category):
7562 * ccl.c (syms_of_ccl):
7563 * cmds.c (syms_of_cmds):
7564 * composite.c (syms_of_composite):
7565 * dbusbind.c (syms_of_dbusbind):
7566 * dired.c (syms_of_dired):
7567 * dispnew.c (syms_of_display):
7568 * doc.c (syms_of_doc):
7569 * editfns.c (syms_of_editfns):
7570 * emacs.c (syms_of_emacs):
7571 * eval.c (syms_of_eval):
7572 * fileio.c (syms_of_fileio):
7573 * fns.c (syms_of_fns):
7574 * frame.c (syms_of_frame):
7575 * fringe.c (syms_of_fringe):
7576 * insdel.c (syms_of_insdel):
7577 * keymap.c (syms_of_keymap):
7578 * lread.c (init_obarray, syms_of_lread):
7579 * macros.c (syms_of_macros):
7580 * msdos.c (syms_of_msdos):
7581 * print.c (syms_of_print):
7582 * process.c (syms_of_process):
7583 * search.c (syms_of_search):
7584 * sound.c (syms_of_sound):
7585 * syntax.c (init_syntax_once, syms_of_syntax):
7586 * terminal.c (syms_of_terminal):
7587 * textprop.c (syms_of_textprop):
7588 * undo.c (syms_of_undo):
7589 * w32.c (globals_of_w32):
7590 * window.c (syms_of_window):
7591 * xdisp.c (syms_of_xdisp):
7592 * xfaces.c (syms_of_xfaces):
7593 * xfns.c (syms_of_xfns):
7594 * xmenu.c (syms_of_xmenu):
7595 * xsettings.c (syms_of_xsettings):
7596 * xterm.c (syms_of_xterm): Use DEFSYM.
7598 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7600 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
7602 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7604 Integer and buffer overflow fixes (Bug#8873).
7606 * print.c (printchar, strout): Check for string overflow.
7607 (PRINTPREPARE, printchar, strout):
7608 Don't set size unless allocation succeeds.
7610 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7611 for sizes. Check for string overflow more accurately.
7612 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7614 * macros.c: Integer and buffer overflow fixes.
7615 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7616 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7617 Use ptrdiff_t, not int, for sizes.
7618 Don't increment bufsize until after realloc succeeds.
7619 Check for size-calculation overflow.
7620 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7622 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7624 * lread.c: Integer overflow fixes.
7625 (read_integer): Radix is now EMACS_INT, not int,
7626 to improve quality of diagnostics for out-of-range radices.
7627 Calculate buffer size correctly for out-of-range radices.
7628 (read1): Check for integer overflow in radices, and in
7629 read-circle numbers.
7630 (read_escape): Avoid int overflow.
7631 (Fload, openp, read_buffer_size, read1)
7632 (substitute_object_recurse, read_vector, read_list, map_obarray):
7633 Use ptrdiff_t, not int, for sizes.
7634 (read1): Use EMACS_INT, not int, for sizes.
7635 Check for size overflow.
7637 * image.c (cache_image): Check for size arithmetic overflow.
7639 * lread.c: Integer overflow issues.
7640 (saved_doc_string_size, saved_doc_string_length)
7641 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7642 Now ptrdiff_t, not int.
7643 (read1): Don't assume doc string length fits in int. Check for
7644 out-of-range doc string lengths.
7645 (read_list): Don't assume file position fits in int.
7646 (read_escape): Check for hex character overflow.
7648 2011-06-22 Leo Liu <sdl.web@gmail.com>
7650 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7651 Move to minibuffer.el.
7653 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7655 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
7656 The following patches are for when GLYPH_DEBUG && !XASSERT.
7657 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7658 * dispnew.c (flush_stdout):
7659 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7660 Mark as externally visible.
7661 * dispnew.c (check_window_matrix_pointers): Now static.
7662 * dispnew.c (window_to_frame_vpos):
7663 * xfns.c (unwind_create_frame):
7664 * xterm.c (x_check_font): Remove unused local.
7665 * scroll.c (CHECK_BOUNDS):
7666 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7667 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7668 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7669 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7670 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7672 (debug_method_add): Use va_list and vsprintf rather than relying
7673 on undefined behavior with wrong number of arguments.
7674 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7675 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7676 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7677 since we're not interested in debugging glyphs with old libraries.
7678 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7679 GCC 4.6.0's static checking.
7681 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7683 Integer overflow and signedness fixes (Bug#8873).
7684 A few related buffer overrun fixes, too.
7686 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7688 * dispextern.h (struct face.stipple):
7689 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7690 (x_bitmap_mask, x_allocate_bitmap_record)
7691 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7692 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7693 (x_create_bitmap_from_xpm_data):
7694 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7695 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7697 * xfaces.c (load_pixmap):
7698 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7699 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7700 (.bitmaps_last, struct x_output.icon_bitmap):
7701 Use ptrdiff_t, not int, for bitmap indexes.
7702 (x_allocate_bitmap_record): Check for size overflow.
7703 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7705 Use ptrdiff_t, not int, for overlay counts.
7706 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7707 * editfns.c (overlays_around, get_pos_property):
7708 * textprop.c (get_char_property_and_overlay):
7709 * xdisp.c (next_overlay_change, note_mouse_highlight):
7710 * xfaces.c (face_at_buffer_position):
7711 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7712 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7713 (Fnext_overlay_change, Fprevious_overlay_change)
7714 (mouse_face_overlay_overlaps, Foverlays_in):
7715 Use ptrdiff_t, not int, for sizes.
7716 (overlays_at, overlays_in): Check for size-calculation overflow.
7718 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7720 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7721 (x_session_initialize): Do not assume string length fits in int.
7723 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7724 This is unlikely, but can occur if DPI is outlandish.
7726 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
7727 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7729 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7730 * xrdb.c (magic_file_p, search_magic_path):
7731 Omit last arg SUFFIX; it was always 0. All callers changed.
7732 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7734 * xfont.c (xfont_match): Avoid need for strlen.
7736 * xfns.c: Don't assume strlen fits in int.
7737 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7739 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7740 not unsigned long, as we prefer signed integers. All callers changed.
7741 Detect integer overflow in repeat count.
7742 (message_dolog): Don't assume print length fits in 39 bytes.
7743 (display_mode_element): Don't assume strlen fits in int.
7745 * termcap.c: Don't assume sizes fit in int and never overflow.
7746 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7747 (gobble_line): Check for size-calculation overflow.
7749 * minibuf.c (Fread_buffer):
7750 * lread.c (intern, intern_c_string):
7751 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7752 Don't assume string length fits in int.
7754 * keyboard.c (parse_tool_bar_item):
7755 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7757 * font.c: Don't assume string length fits in int.
7758 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7759 Use ptrdiff_t, not int.
7760 (font_intern_prop): Don't assume string length fits in int.
7761 Don't assume integer property fits in fixnum.
7762 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
7764 * filelock.c: Fix some buffer overrun and integer overflow issues.
7765 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
7766 Reformulate so as not to need the command string.
7767 Invoke gzip -cd rather than gunzip, as it's more portable.
7768 (lock_info_type, lock_file_1, lock_file):
7769 Don't assume pid_t and time_t fit in unsigned long.
7770 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7771 (current_lock_owner): Prefer signed type for sizes.
7772 Use memcpy, not strncpy, where memcpy is what is really wanted.
7773 Don't assume (via atoi) that time_t and pid_t fit in int.
7774 Check for time_t and/or pid_t out of range, e.g., via a network share.
7775 Don't alloca where an auto var works fine.
7777 * fileio.c: Fix some integer overflow issues.
7778 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7779 Don't assume string length fits in int.
7780 (directory_file_name): Don't assume string length fits in long.
7781 (make_temp_name): Don't assume pid fits in int, or that its print
7782 length is less than 20.
7784 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7786 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7788 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7790 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7791 We prefer signed integers, even for size calculations.
7793 * emacs.c: Don't assume string length fits in 'int'.
7794 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7795 (main): Don't invoke strlen when not needed.
7797 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7798 (XD_DEBUG_MESSAGE): Don't waste a byte.
7800 * callproc.c (getenv_internal_1, getenv_internal)
7802 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7804 * lread.c (invalid_syntax): Omit length argument.
7805 All uses changed. This doesn't fix a bug, but it simplifies the
7806 code away from its former Hollerith-constant appearance, and it's
7807 one less 'int' to worry about when looking at integer-overflow issues.
7808 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
7810 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7811 This didn't break anything, but it didn't help either.
7812 It's confusing to put a bogus integer in a place where the actual
7813 value does not matter.
7814 (LIST_END_P): Remove unused macro and its bogus comment.
7815 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
7817 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7818 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7820 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7821 We prefer signed types, and the value cannot exceed the EMACS_INT
7822 range anyway (because otherwise the length would not be representable).
7823 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7824 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7825 This avoids a GCC warning when WIDE_EMACS_INT.
7827 * indent.c (sane_tab_width): New function.
7828 (current_column, scan_for_column, Findent_to, position_indentation)
7829 (compute_motion): Use it. This is just for clarity.
7830 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
7832 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
7834 * lisp.h (lint_assume): New macro.
7835 * composite.c (composition_gstring_put_cache):
7836 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7838 * editfns.c, insdel.c:
7839 Omit unnecessary forward decls, to simplify future changes.
7841 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7843 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7845 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
7846 Use much-faster test for byte-length change.
7847 Don't assume string byte-length fits in 'int'.
7848 Check that character arg fits in 'int'.
7849 (mapcar1): Declare byte as byte, for clarity.
7851 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7853 * fns.c (concat): Catch string overflow earlier.
7854 Do not rely on integer wraparound.
7856 * dispextern.h (struct it.overlay_strings_charpos)
7857 (struct it.selective): Now EMACS_INT, not int.
7858 * xdisp.c (forward_to_next_line_start)
7859 (back_to_previous_visible_line_start)
7860 (reseat_at_next_visible_line_start, next_element_from_buffer):
7861 Don't arbitrarily truncate the value of 'selective' to int.
7863 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7865 * composite.c: Don't truncate sizes to 'int'.
7866 (composition_gstring_p, composition_reseat_it)
7867 (composition_adjust_point): Use EMACS_INT, not int.
7868 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7869 not EMACS_UINT, for indexes.
7871 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7873 * buffer.c: Include <verify.h>.
7874 (struct sortvec.priority, struct sortstr.priority):
7875 Now EMACS_INT, not int.
7876 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
7877 (struct sortstr.size, record_overlay_string)
7878 (struct sortstrlist.size, struct sortlist.used):
7879 Don't truncate size to int.
7880 (record_overlay_string): Check for size-calculation overflow.
7881 (init_buffer_once): Check at compile-time, not run-time.
7883 2011-06-22 Jim Meyering <meyering@redhat.com>
7885 Don't leak an XBM-image-sized buffer
7886 * image.c (xbm_load): Free the image buffer after using it.
7888 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7891 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7892 that Sun C diagnosed.
7893 * fns.c (secure_hash): Fix pointer signedness issue.
7894 * intervals.c (static_offset_intervals): New function.
7895 (offset_intervals): Use it.
7897 2011-06-21 Leo Liu <sdl.web@gmail.com>
7900 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7903 * fns.c (secure_hash): Rename from crypto_hash_function and change
7904 the first arg to accept symbols.
7905 (Fsecure_hash): New primitive.
7906 (syms_of_fns): New symbols.
7908 2011-06-20 Deniz Dogan <deniz@dogan.se>
7910 * process.c (Fset_process_buffer): Clarify return value in
7913 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
7915 * dispnew.c (add_window_display_history): Use BVAR.
7917 * xdisp.c (debug_method_add): Use BVAR.
7918 (check_window_end, dump_glyph_matrix, dump_glyph)
7919 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7921 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7924 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7925 check till after the cache is created in init_frame_faces.
7927 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7929 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7931 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7933 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7934 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7935 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7937 Improve buffer-overflow checking (Bug#8873).
7938 * fileio.c (Finsert_file_contents):
7939 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7940 Remove the old (too-loose) buffer overflow checks.
7941 They weren't needed, since make_gap checks for buffer overflow.
7942 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7943 The old code merely checked for Emacs fixnum overflow, and relied
7944 on undefined (wraparound) behavior. The new code avoids undefined
7945 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7947 * editfns.c (Finsert_char): Don't dump core with very negative counts.
7948 Tune. Don't use wider integers than needed. Don't use alloca.
7949 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
7951 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7953 * insdel.c, lisp.h (buffer_overflow): New function.
7954 (insert_from_buffer_1, replace_range, replace_range_2):
7955 * insdel.c (make_gap_larger):
7956 * editfns.c (Finsert_char):
7957 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7959 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7961 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7963 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
7965 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7966 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7968 * fileio.c: Don't assume EMACS_INT fits in off_t.
7969 (emacs_lseek): New static function.
7970 (Finsert_file_contents, Fwrite_region): Use it.
7971 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7973 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7975 * fns.c: Don't overflow int when computing a list length.
7976 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7977 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7978 truncation on 64-bit hosts. Check for QUIT every
7979 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7980 faster and is responsive enough.
7981 (Flength): Report an error instead of overflowing an integer.
7982 (Fsafe_length): Return a float if the value is not representable
7983 as a fixnum. This shouldn't happen except in contrived situations.
7984 (Fnthcdr, Fsort): Don't assume list length fits in int.
7985 (Fcopy_sequence): Don't assume vector length fits in int.
7987 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7988 (header_size, word_size): New constants.
7989 (allocate_vectorlike): Don't check size overflow here.
7990 (allocate_vector): Check it here instead, since this is the only
7991 caller of allocate_vectorlike that could cause overflow.
7992 Check that the new vector's length is representable as a fixnum.
7994 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7995 The previous code was bogus. For example, next_almost_prime (32)
7996 returned 39, which is undesirable as it is a multiple of 3; and
7997 next_almost_prime (24) returned 25, which is a multiple of 5 so
7998 why was the code bothering to check for multiples of 7?
8000 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8002 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8004 Variadic C functions now count arguments with ptrdiff_t.
8005 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8006 Back then I didn't know that the Emacs coding style prefers signed int.
8007 Also, in the meantime I found a few more instances where arguments
8008 were being counted with int, which may truncate counts on 64-bit
8009 machines, or EMACS_INT, which may be unnecessarily wide.
8010 * lisp.h (struct Lisp_Subr.function.aMANY)
8011 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8012 Arg counts are now ptrdiff_t, not size_t.
8013 All variadic functions and their callers changed accordingly.
8014 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8015 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8016 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8017 * callint.c (Fcall_interactively): Check arg count for overflow,
8018 to avoid potential buffer overrun. Use signed char, not 'int',
8019 for 'varies' array, so that we needn't bother to check its size
8020 calculation for overflow.
8021 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8022 * eval.c (apply_lambda):
8023 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8024 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8025 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8027 * callint.c (Fcall_interactively): Don't use index var as event count.
8029 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8030 * mem-limits.h (SIZE): Remove; no longer used.
8032 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
8034 Remove unnecessary casts.
8035 * xterm.c (x_term_init):
8036 * xfns.c (x_set_border_pixel):
8037 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8038 These aren't needed now that we assume ANSI C.
8040 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8041 It's more likely to cause problems (due to unsigned overflow)
8044 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8046 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8048 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8050 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8052 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8054 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8056 GLYPH_CODE_FACE returns EMACS_INT, not int.
8057 * dispextern.h (merge_faces):
8058 * xfaces.c (merge_faces):
8059 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8060 Don't assume EMACS_INT fits in int.
8062 * character.h (CHAR_VALID_P): Remove unused parameter.
8063 * fontset.c, lisp.h, xdisp.c: All uses changed.
8065 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8067 * fns.c (concat): Minor tuning based on overflow analysis.
8068 This doesn't fix any bugs. Use int to hold character, instead
8069 of constantly refetching from Emacs object. Use XFASTINT, not
8070 XINT, for value known to be a character. Don't bother comparing
8071 a single byte to 0400, as it's always less.
8073 * floatfns.c (Fexpt):
8074 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8076 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8079 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8081 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8082 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8083 incorrectly succeed when S was a string, because 4294967386 was
8084 truncated before it was used.
8086 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8087 Otherwise, an out-of-range integer could cause undefined behavior
8090 * composite.c: Use int, not EMACS_INT, for characters.
8091 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8092 EMACS_INT, for values that are known to be in character range.
8093 This doesn't fix any bugs but is the usual style inside Emacs and
8094 may generate better code on 32-bit machines.
8096 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8097 This is for reasons similar to the recent CHAR_STRING fix.
8098 * charset.c (Fencode_char): Check that character arg is actually
8099 a character. Pass an int to ENCODE_CHAR.
8100 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8101 wider than 'int', as a compile-time check to prevent future regressions
8104 * character.c (char_string): Remove unnecessary casts.
8106 Make sure a 64-bit char is never passed to CHAR_STRING.
8107 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8108 by silently ignoring the top 32 bits, allowing some values
8109 that were far too large to be valid characters.
8110 * character.h: Include <verify.h>.
8111 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8112 arguments are no wider than unsigned, as a compile-time check
8113 to prevent future regressions in this area.
8115 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
8116 (Fsubst_char_in_region):
8118 * xdisp.c (decode_mode_spec_coding):
8119 Adjust to CHAR_STRING's new requirement.
8120 * editfns.c (Finsert_char, Fsubst_char_in_region):
8121 * fns.c (concat): Check that character args are actually
8122 characters. Without this test, these functions did the wrong
8123 thing with wildly out-of-range values on 64-bit hosts.
8125 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8126 These casts should not be needed on 32-bit hosts, either.
8127 * keyboard.c (read_char):
8128 * lread.c (Fload): Remove casts to unsigned.
8130 * lisp.h (UNSIGNED_CMP): New macro.
8131 This fixes comparison bugs on 64-bit hosts.
8132 (ASCII_CHAR_P): Use it.
8133 * casefiddle.c (casify_object):
8134 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
8135 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8136 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8137 * dispextern.h (FACE_FROM_ID):
8138 * keyboard.c (read_char): Use UNSIGNED_CMP.
8140 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8141 not to EMACS_INT, to avoid GCC warning.
8143 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8145 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8146 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8147 isn't needed on 32-bit machines.
8149 * buffer.c (Fgenerate_new_buffer_name):
8150 Use EMACS_INT for count, not int.
8151 (advance_to_char_boundary): Return EMACS_INT, not int.
8153 * data.c (Qcompiled_function): Now static.
8155 * window.c (window_body_lines): Now static.
8157 * image.c (gif_load): Rename local to avoid shadowing.
8159 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8160 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8161 * alloc.c (make_save_value): Integer argument is now of type
8163 (mark_object): Use ptrdiff_t, not int.
8164 * lisp.h (pD): New macro.
8165 * print.c (print_object): Use it.
8167 * alloc.c: Use EMACS_INT, not int, to count objects.
8168 (total_conses, total_markers, total_symbols, total_vector_size)
8169 (total_free_conses, total_free_markers, total_free_symbols)
8170 (total_free_floats, total_floats, total_free_intervals)
8171 (total_intervals, total_strings, total_free_strings):
8172 Now EMACS_INT, not int. All uses changed.
8173 (Fgarbage_collect): Compute overall total using a double, so that
8174 integer overflow is less likely to be a problem. Check for overflow
8175 when converting back to an integer.
8176 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8177 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8178 These were 'int' variables that could overflow on 64-bit hosts;
8179 they were never used, so remove them instead of repairing them.
8180 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
8181 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8182 Previously, this ceilinged at INT_MAX, but that doesn't work on
8184 (allocate_pseudovector): Don't use EMACS_INT when int would do.
8186 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
8187 (allocate_vectorlike): Check for ptrdiff_t overflow.
8188 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8189 when a (possibly-narrower) signed value would do just as well.
8190 We prefer using signed arithmetic, to avoid comparison confusion.
8192 * alloc.c: Catch some string size overflows that we were missing.
8193 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8194 for convenience in STRING_BYTES_MAX.
8195 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8196 The definition here is exact; the one in lisp.h was approximate.
8197 (allocate_string_data): Check for string overflow. This catches
8198 some instances we weren't catching before. Also, it catches
8199 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8200 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8201 and ptrdiff_t and EMACS_INT are both 64 bits.
8203 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8204 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
8205 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
8207 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8209 * alloc.c (Fmake_string): Check for out-of-range init.
8211 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8213 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8215 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8217 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8218 xg_get_default_scrollbar_width.
8220 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8221 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8222 (style_changed_cb): Call update_theme_scrollbar_width and call
8223 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8224 all frames (Bug#8505).
8225 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8226 Call gtk_window_set_resizable if HAVE_GTK3.
8227 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8228 and height if HAVE_GTK3 (Bug#8505).
8229 (scroll_bar_width_for_theme): New variable.
8230 (update_theme_scrollbar_width): New function.
8231 (xg_get_default_scrollbar_width): Move code to
8232 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8233 (xg_initialize): Call update_theme_scrollbar_width.
8235 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8237 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8239 2011-06-12 Martin Rudalics <rudalics@gmx.at>
8241 * frame.c (make_frame): Call other_buffer_safely instead of
8244 * window.c (temp_output_buffer_show): Call display_buffer with
8245 second argument Vtemp_buffer_show_specifiers and reset latter
8246 immediately after the call.
8247 (Vtemp_buffer_show_specifiers): New variable.
8248 (auto_window_vscroll_p, next_screen_context_lines)
8249 (Vscroll_preserve_screen_position): Remove leading asterisks from
8252 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
8254 Fix minor problems found by GCC 4.6.0 static checking.
8255 * buffer.c (Qclone_number): Remove for now, as it's unused.
8256 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8257 (record_buffer): Remove unused local.
8258 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8259 (set_frame_buffer_list): Remove; unused.
8260 * frame.h (other_visible_frames): Remove decl.
8261 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8262 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8263 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8265 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8266 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8267 Define only if HAVE_GPM.
8268 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8269 (update_hints_inhibit): Remove; never set. All uses removed.
8270 * widgetprv.h (emacsFrameClassRec): Remove decl.
8271 * window.c (delete_deletable_window): Now returns void, since it
8272 wasn't returning anything.
8273 (compare_window_configurations): Remove unused locals.
8274 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8275 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
8276 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8277 the same widths as pointers. This follows up on the 2011-05-06 patch.
8278 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8279 * xterm.h: Likewise.
8280 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8282 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
8284 * makefile.w32-in: Update dependencies.
8285 (LISP_H): Add lib/intprops.h.
8287 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8289 * image.c (gif_load): Add animation frame delay to the metadata.
8290 (syms_of_image): Use DEFSYM. New symbol `delay'.
8292 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8294 * window.c (delete_deletable_window): Re-add.
8295 (Fset_window_configuration): Rewrite to handle dead buffers and
8296 consequently deletable windows.
8297 (window_tree, Fwindow_tree): Remove. Supply functionality in
8299 (compare_window_configurations): Simplify code.
8301 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8303 * image.c (imagemagick_load_image): Fix type mismatch.
8304 (Fimagemagick_types): Likewise.
8306 * window.h (replace_buffer_in_windows): Declare.
8308 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8310 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8311 Qclone_number. Remove external declaration of Qdelete_window.
8312 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8314 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8315 Run Qbuffer_list_update_hook if allowed.
8316 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8317 buffer list implementation.
8318 (other_buffer_safely): New function.
8319 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8320 calls to replace_buffer_in_windows and
8321 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8323 (record_buffer): Inhibit quitting and rewrite using quittable
8324 functions. Run Qbuffer_list_update_hook if allowed.
8325 (Frecord_buffer, Funrecord_buffer): New functions.
8326 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8327 Move switch-to-buffer to window.el.
8328 (bury-buffer): Move to window.el.
8329 (Vbuffer_list_update_hook): New variable.
8331 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8334 * window.h (resize_frame_windows): Move up in code.
8335 (Fwindow_frame): Remove EXFUN.
8336 (replace_buffer_in_all_windows): Remove prototype.
8337 (replace_buffer_in_windows_safely): Add prototype.
8339 * window.c: Declare Qdelete_window static again. Move down
8340 declaration of select_count.
8341 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8342 (Fother_window): Move to window.el.
8343 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8344 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8345 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8347 (replace_buffer_in_windows): Implement by calling
8348 Qreplace_buffer_in_windows.
8349 (replace_buffer_in_all_windows): Remove with some functionality
8350 moved into replace_buffer_in_windows_safely.
8351 (replace_buffer_in_windows_safely): New function.
8352 (select_window_norecord, select_frame_norecord): Move in front
8353 of run_window_configuration_change_hook. Remove now obsolete
8355 (Fset_window_buffer): Rewrite doc-string.
8356 Call Qrecord_window_buffer.
8357 (keys_of_window): Move binding for other-window to window.el.
8359 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8361 * dispextern.h (struct image): Replace data member, whose int_val
8362 and ptr_val fields were not used by anything, with a single
8365 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8366 (gif_clear_image, gif_load, imagemagick_load_image)
8367 (gs_clear_image, gs_load): Callers changed.
8369 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8371 * buffer.h: Include <time.h>, for time_t.
8372 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8374 Fix minor problems found by static checking.
8376 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8378 Make identifiers static if they are not used in other modules.
8379 * data.c (Qcompiled_function, Qframe, Qvector):
8380 * image.c (QimageMagick, Qsvg):
8381 * minibuf.c (Qmetadata):
8382 * window.c (resize_window_check, resize_root_window): Now static.
8383 * window.h (resize_window_check, resize_root_window): Remove decls.
8385 * window.c (window_deletion_count, delete_deletable_window):
8387 (window_body_lines): Now static.
8388 (Fdelete_other_windows_internal): Mark vars as initialized.
8389 Make sure 'resize_failed' is initialized.
8390 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8391 (resize_window_apply): Remove unused local.
8392 * window.h (delete_deletable_window): Remove decl.
8394 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
8395 (imagemagick_load_image): Fix pointer signedness problem by changing
8396 last arg from unsigned char * to char *. All uses changed.
8397 Also, fix a local for similar reasons.
8398 Remove unused locals. Remove locals to avoid shadowing.
8399 (fn_rsvg_handle_free): Remove; unused.
8400 (svg_load, svg_load_image): Fix pointer signedness problem.
8401 (imagemagick_load_image): Don't use garbage pointer image_wand.
8403 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8405 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
8407 * image.c (gif_load): Fix omitted cast error introduced by
8410 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8412 * window.h (resize_proportionally, orig_total_lines)
8413 (orig_top_line): Remove from window structure.
8414 (set_window_height, set_window_width, change_window_heights)
8415 (Fdelete_window): Remove prototypes.
8416 (resize_frame_windows): Remove duplicate declaration.
8418 2011-06-10 Eli Zaretskii <eliz@gnu.org>
8420 * window.h (resize_frame_windows, resize_window_check)
8421 (delete_deletable_window, resize_root_window)
8422 (resize_frame_windows): Declare prototypes.
8424 * window.c (resize_window_apply): Make definition be "static" to
8425 match the prototype.
8427 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8429 * window.c: Remove declarations of Qwindow_size_fixed,
8430 window_min_size_1, window_min_size_2, window_min_size,
8431 size_window, window_fixed_size_p, enlarge_window, delete_window.
8432 Remove static from declaration of Qdelete_window, it's
8433 temporarily needed by Fbury_buffer.
8434 (replace_window): Don't assign orig_top_line and
8436 (Fdelete_window, delete_window): Remove. Window deletion is
8437 handled by window.el.
8438 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8439 Replace Fdelete_window calls with calls to Qdelete_window.
8440 (Fdelete_other_windows): Remove. Deleting other windows is
8441 handled by window.el.
8442 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8443 handled in window.el.
8444 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8445 Window minimum sizes are handled in window.el.
8446 (shrink_windows, size_window, set_window_height)
8447 (set_window_width, change_window_heights, window_height)
8448 (window_width, CURBEG, CURSIZE, enlarge_window)
8449 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8450 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8451 handled in window.el.
8452 (make_dummy_parent): Rename to make_parent_window and give it a
8453 second argument horflag.
8454 (make_window): Don't set resize_proportionally any more.
8455 (Fsplit_window): Remove. Windows are split in window.el.
8456 (save_restore_action, save_restore_orig_size)
8457 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8458 Resize mini windows in window.el.
8459 (grow_mini_window, shrink_mini_window): Implement by calling
8460 Qresize_root_window_vertically, resize_window_check and
8461 resize_window_apply.
8462 (saved_window, Fset_window_configuration, save_window_save):
8463 Do not handle orig_top_line, orig_total_lines, and
8464 resize_proportionally.
8465 (window_min_height, window_min_width): Move to window.el.
8466 (keys_of_window): Move bindings for delete-other-windows,
8467 split-window, delete-window and enlarge-window to window.el.
8469 * buffer.c: Temporarily extern Qdelete_window.
8470 (Fbury_buffer): Temporarily call Qdelete_window instead of
8471 Fdelete_window (Fbury_buffer will move to window.el soon).
8473 * frame.c (set_menu_bar_lines_1): Remove code handling
8474 orig_top_line and orig_total_lines.
8476 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8477 set_window_height but set heights directly.
8478 (change_frame_size_1): Use resize_frame_windows.
8480 * xdisp.c (init_xdisp): Don't use set_window_height but set
8483 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8484 Use resize_frame_windows instead of change_window_heights and run
8485 run_window_configuration_change_hook.
8487 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8488 instead of change_window_heights and run
8489 run_window_configuration_change_hook.
8491 2011-06-09 Martin Rudalics <rudalics@gmx.at>
8493 * window.c (replace_window): Rename second argument REPLACEMENT to
8494 NEW. New third argument SETFLAG. Rewrite.
8495 (delete_window, make_dummy_parent): Call replace_window with
8497 (window_list_1): Move down in code.
8498 (run_window_configuration_change_hook): Move set_buffer part
8499 before select_frame_norecord part in order to unwind correctly.
8500 Rename count1 to count.
8501 (recombine_windows, delete_deletable_window, resize_root_window)
8502 (Fdelete_other_windows_internal)
8503 (Frun_window_configuration_change_hook, make_parent_window)
8504 (resize_window_check, resize_window_apply, Fresize_window_apply)
8505 (resize_frame_windows, Fsplit_window_internal)
8506 (Fdelete_window_internal, Fresize_mini_window_internal):
8508 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8510 2011-06-08 Martin Rudalics <rudalics@gmx.at>
8512 * window.h (window): Add some new members to window structure -
8513 normal_lines, normal_cols, new_total, new_normal, clone_number,
8514 splits, nest, prev_buffers, next_buffers.
8515 (WINDOW_TOTAL_SIZE): Move here from window.c.
8516 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
8518 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8520 (make_dummy_parent): Set new members of windows structure.
8521 (make_window): Move down in code. Handle new members of window
8523 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8524 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8525 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8526 (Fset_window_prev_buffers, Fwindow_next_buffers)
8527 (Fset_window_next_buffers, Fset_window_clone_number):
8529 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8530 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8532 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8533 Argument WINDOW can be now internal window too.
8534 (Fwindow_use_time): Move up in code.
8535 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8537 (Fset_window_configuration, saved_window)
8538 (Fcurrent_window_configuration, save_window_save): Handle new
8539 members of window structure.
8540 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8541 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8542 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8543 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8544 Qget_mru_window, Qresize_root_window,
8545 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8546 Qauto_buffer_name; staticpro them.
8548 2011-06-07 Martin Rudalics <rudalics@gmx.at>
8550 * window.c (Fwindow_total_size, Fwindow_left_column)
8551 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8552 (Fwindow_list_1): New functions.
8553 (window_box_text_cols): Replace with window_body_cols.
8554 (Fwindow_width, Fscroll_left, Fscroll_right):
8555 Use window_body_cols instead of window_box_text_cols.
8556 (delete_window, Fset_window_configuration):
8557 Call delete_all_subwindows with window as argument.
8558 (delete_all_subwindows): Take a window as argument and not a
8560 (window_loop): Remove handling of GET_LRU_WINDOW and
8562 (Fget_lru_window, Fget_largest_window): Move to window.el.
8564 * window.h: Extern window_body_cols instead of
8565 window_box_text_cols. delete_all_subwindows now takes a
8566 Lisp_Object as argument.
8568 * indent.c (compute_motion, Fcompute_motion):
8569 Use window_body_cols instead of window_box_text_cols.
8571 * frame.c (delete_frame): Call delete_all_subwindows with root
8574 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8576 * fns.c (Fputhash): Document return value.
8578 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
8580 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8582 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8584 Cons<->int and similar integer overflow fixes (Bug#8794).
8586 Check for overflow when converting integer to cons and back.
8587 * charset.c (Fdefine_charset_internal, Fdecode_char):
8588 Use cons_to_unsigned to catch overflow.
8589 (Fencode_char): Use INTEGER_TO_CONS.
8590 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8591 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8592 * data.c (long_to_cons, cons_to_long): Remove.
8593 (cons_to_unsigned, cons_to_signed): New functions.
8594 These signal an error for invalid or out-of-range values.
8595 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8596 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8597 * font.c (Ffont_variation_glyphs):
8598 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8599 * lisp.h: Include <intprops.h>.
8600 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8601 (cons_to_signed, cons_to_unsigned): New decls.
8602 (long_to_cons, cons_to_long): Remove decls.
8603 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8604 (Fprimitive_undo): Use CONS_TO_INTEGER.
8605 * xfns.c (Fx_window_property): Likewise.
8606 * xselect.c: Include <limits.h>.
8607 (x_own_selection, selection_data_to_lisp_data):
8608 Use INTEGER_TO_CONS.
8609 (x_handle_selection_request, x_handle_selection_clear)
8610 (x_get_foreign_selection, Fx_disown_selection_internal)
8611 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8612 (lisp_data_to_selection_data): Use cons_to_unsigned.
8613 (x_fill_property_data): Use cons_to_signed.
8614 Report values out of range.
8616 Check for buffer and string overflow more precisely.
8617 * buffer.h (BUF_BYTES_MAX): New macro.
8618 * lisp.h (STRING_BYTES_MAX): New macro.
8619 * alloc.c (Fmake_string):
8620 * character.c (string_escape_byte8):
8621 * coding.c (coding_alloc_by_realloc):
8622 * doprnt.c (doprnt):
8623 * editfns.c (Fformat):
8625 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8626 since they may not be the same number.
8627 * editfns.c (Finsert_char):
8628 * fileio.c (Finsert_file_contents):
8629 Likewise for BUF_BYTES_MAX.
8631 * image.c: Use ptrdiff_t, not int, for sizes.
8632 (slurp_file): Switch from int to ptrdiff_t.
8634 (slurp_file): Check that file size fits in both size_t (for
8635 malloc) and ptrdiff_t (for sanity and safety).
8637 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8638 if b->modtime has its maximal value.
8640 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8642 Don't assume time_t can fit into int.
8643 * buffer.h (struct buffer.modtime): Now time_t, not int.
8644 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8645 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8647 Minor fixes for signed vs unsigned integers.
8648 * character.h (MAYBE_UNIFY_CHAR):
8649 * charset.c (maybe_unify_char):
8650 * keyboard.c (read_char, reorder_modifiers):
8651 XINT -> XFASTINT, since the integer must be nonnegative.
8652 * ftfont.c (ftfont_spec_pattern):
8653 * keymap.c (access_keymap, silly_event_symbol_error):
8654 XUINT -> XFASTINT, since the integer must be nonnegative.
8655 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8656 since it makes no difference and we prefer signed.
8657 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8658 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8661 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8663 * window.h (Fwindow_frame): Declare.
8665 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8667 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8668 (SPARE_MEMORY): Always define.
8669 (LARGE_REQUEST): Remove.
8670 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8672 2011-06-06 Martin Rudalics <rudalics@gmx.at>
8674 * lisp.h: Move EXFUNS for Fframe_root_window,
8675 Fframe_first_window and Fset_frame_selected_window to window.h.
8677 * window.h: Move EXFUNS for Fframe_root_window,
8678 Fframe_first_window and Fset_frame_selected_window here from
8681 * frame.c (Fwindow_frame, Fframe_first_window)
8682 (Fframe_root_window, Fframe_selected_window)
8683 (Fset_frame_selected_window): Move to window.c.
8684 (Factive_minibuffer_window): Move to minibuf.c.
8685 (Fother_visible_frames_p): New function.
8687 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8689 * window.c (decode_window, decode_any_window): Move up in code.
8690 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8691 (inhibit_frame_unsplittable): Remove unused variable.
8692 (Fwindow_buffer): Move up and rewrite doc-string.
8693 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8694 (Fwindow_prev): New functions.
8695 (Fwindow_frame): Move here from frame.c. Accept any window as
8697 (Fframe_root_window, Fframe_first_window)
8698 (Fframe_selected_window): Move here from frame.c. Accept frame
8699 or arbitrary window as argument. Update doc-strings.
8700 (Fminibuffer_window): Move up in code.
8701 (Fwindow_minibuffer_p): Move up in code and simplify.
8702 (Fset_frame_selected_window): Move here from frame.c.
8704 (Fselected_window, select_window, Fselect_window): Move up in
8705 code. Minor doc-string fixes.
8707 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8709 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8710 Do not assume that spare memory exists; that assumption is valid
8711 only if SYSTEM_MALLOC.
8712 (LARGE_REQUEST): New macro, so that the issue of large requests
8713 is separated from the issue of spare memory.
8715 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8717 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8720 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8722 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8725 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8727 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8729 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8731 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8732 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8734 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
8736 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8738 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
8740 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8741 (x_clipboard_manager_save): Add return value.
8742 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8744 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8745 Obey Vx_select_enable_clipboard_manager. Catch errors in
8746 x_clipboard_manager_save (Bug#8779).
8747 (Vx_select_enable_clipboard_manager): New variable.
8748 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
8750 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8752 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8754 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8756 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8757 in the current matrix if keep_current_p is non-zero.
8759 2011-06-04 Eli Zaretskii <eliz@gnu.org>
8761 * bidi.c (bidi_level_of_next_char): Fix last change.
8763 2011-06-03 Eli Zaretskii <eliz@gnu.org>
8765 Support bidi reordering of text covered by display properties.
8767 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8768 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8769 (bidi_cache_search, bidi_cache_iterator_state)
8770 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
8771 (bidi_level_of_next_char, bidi_move_to_visually_next):
8772 Support character positions inside a run of characters covered by a
8774 (bidi_paragraph_init, bidi_resolve_explicit_1)
8775 (bidi_level_of_next_char): Call bidi_fetch_char and
8776 bidi_fetch_char_advance instead of FETCH_CHAR and
8778 (bidi_init_it): Initialize new members.
8779 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8781 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8782 instead of using explicit *_CHAR codes.
8783 (bidi_resolve_explicit, bidi_resolve_weak):
8784 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
8785 bidirectional text is supported only in multibyte buffers.
8786 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8787 it to initialize the frame_window_p member of struct bidi_it.
8788 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8789 (bidi_resolve_explicit, bidi_resolve_weak)
8790 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8791 bidi_it->nchars is non-positive.
8792 (bidi_level_of_next_char): Don't try to lookup the cache for the
8793 next/previous character if nothing is cached there yet, or if we
8794 were just reseat()'ed to a new position.
8796 * xdisp.c (set_cursor_from_row): Set start and stop points
8797 according to the row's direction when priming the loop that looks
8798 for the glyph on which to display cursor.
8799 (single_display_spec_intangible_p): Function deleted.
8800 (display_prop_intangible_p): Reimplement to call
8801 handle_display_spec instead of single_display_spec_intangible_p.
8802 Accept 3 additional arguments needed by handle_display_spec.
8803 This fixes incorrect cursor motion across display property with complex
8804 values: lists, `(when COND...)' forms, etc.
8805 (single_display_spec_string_p): Support property values that are
8806 lists with the argument STRING its top-level element.
8807 (display_prop_string_p): Fix the condition for processing a
8808 property that is a list to be consistent with handle_display_spec.
8809 (handle_display_spec): New function, refactored from the
8810 last portion of handle_display_prop.
8811 (compute_display_string_pos): Accept additional argument
8812 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8813 value of a `display' property is a "replacing spec".
8814 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8815 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8816 the display property, but just return a value indicating whether
8817 the display property will replace the characters it covers.
8818 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8819 frame_window_p members of struct bidi_it.
8820 (compute_display_string_pos, compute_display_string_end):
8822 (push_it): Accept second argument POSITION, where pop_it should
8823 jump to continue iteration.
8824 (reseat_1): Initialize bidi_it.disp_pos.
8826 * keyboard.c (adjust_point_for_property): Adjust the call to
8827 display_prop_intangible_p to its new signature.
8829 * dispextern.h (struct bidi_it): New member frame_window_p.
8830 (bidi_init_it): Update prototypes.
8831 (display_prop_intangible_p): Update prototype.
8832 (compute_display_string_pos, compute_display_string_end):
8834 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8837 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
8839 Malloc failure behavior now depends on size of allocation.
8840 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8841 * lisp.h: Change signatures accordingly.
8842 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8843 All callers changed. (Bug#8762)
8845 * gnutls.c: Use Emacs's memory allocators.
8846 Without this change, the gnutls library would invoke malloc etc.
8847 directly, which causes problems on non-SYNC_INPUT hosts, and which
8848 runs afoul of improving memory_full behavior. (Bug#8761)
8849 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8850 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8851 xfree instead of the default malloc, realloc, free.
8852 (Fgnutls_boot): No need to check for memory allocation failure,
8853 since xmalloc does that for us.
8855 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
8856 * category.c (hash_get_category_set):
8857 * ccl.c (ccl_driver):
8858 * charset.c (Fdefine_charset_internal):
8859 * charset.h (struct charset.hash_index):
8860 * composite.c (get_composition_id, gstring_lookup_cache)
8861 (composition_gstring_put_cache):
8862 * composite.h (struct composition.hash_index):
8863 * dispextern.h (struct image.hash):
8864 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8865 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8866 (hashfn_equal, hashfn_user_defined, make_hash_table)
8867 (maybe_resize_hash_table, hash_lookup, hash_put)
8868 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8869 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8870 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8871 * image.c (make_image, search_image_cache, lookup_image)
8872 (xpm_put_color_table_h):
8873 * lisp.h (struct Lisp_Hash_Table):
8874 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
8875 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
8876 for hashes and hash indexes, instead of 'unsigned' and 'int'.
8877 * alloc.c (allocate_vectorlike):
8878 Check for overflow in vector size calculations.
8879 * ccl.c (ccl_driver):
8880 Check for overflow when converting EMACS_INT to int.
8881 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8882 need to be updated by these changes.
8883 * fns.c (make_hash_table, maybe_resize_hash_table):
8884 Check for integer overflow with large hash tables.
8885 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8886 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8887 (SXHASH_REDUCE): New macro.
8888 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8889 Use it instead of discarding useful hash info with large hash values.
8890 (sxhash_float): New function.
8891 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8892 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
8893 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8894 Rewrite to use FIXNUM_BITS, as this simplifies things.
8895 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8896 Adjust signatures to match updated version of code.
8897 (consing_since_gc): Now EMACS_INT, since a single hash table can
8898 use more than INT_MAX bytes.
8900 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8902 Make it possible to build with GCC-4.6+ -O2 -flto.
8904 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8906 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8908 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8909 Call minibuffer-inactive-mode.
8911 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
8913 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8914 Update dependencies.
8916 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8918 * data.c (init_data): Remove code for UTS, this system is not
8921 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8923 Don't force ./temacs to start in terminal mode.
8925 * frame.c (make_initial_frame): Initialize faces in all cases, not
8926 only when CANNOT_DUMP is defined.
8927 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8929 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8931 * dispnew.c (add_window_display_history): Use const for the string
8932 pointer. Remove declaration, not needed.
8934 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8936 Use 'inline', not 'INLINE'.
8937 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
8938 * alloc.c, fontset.c (INLINE): Remove.
8939 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8940 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8941 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8942 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8943 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8945 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8947 Make it possible to run ./temacs.
8949 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8950 syms_of_callproc does the same thing. Remove test for
8951 "initialized", do it in the caller.
8952 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8954 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8956 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8957 (read_minibuf): Use get_minibuffer.
8958 (syms_of_minibuf): Use DEFSYM.
8959 (Qmetadata): New var.
8960 * data.c (Qbuffer): Don't make it static.
8961 (syms_of_data): Use DEFSYM.
8963 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8965 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8966 (CCL_CODE_MIN): New macro.
8968 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8970 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8972 * eval.c (Qdebug): Now static.
8973 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8974 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8975 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8977 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8979 * image.c: Various fixes to ImageMagick code comments.
8980 (Fimagemagick_types): Doc fix.
8982 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8984 Minor fixes prompted by GCC 4.6.0 warnings.
8986 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8988 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8989 (x_clipboard_manager_save_all): Move extern decl to ...
8990 * xterm.h: ... here, so that it can be checked for consistency.
8992 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8994 * xselect.c (x_clipboard_manager_save_frame)
8995 (x_clipboard_manager_save_all): New functions.
8996 (Fx_clipboard_manager_save): Lisp function deleted.
8998 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8999 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9001 * xterm.h: Update prototype.
9003 2011-05-28 William Xu <william.xwl@gmail.com>
9005 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9008 2011-05-28 Jim Meyering <meyering@redhat.com>
9010 Avoid a sign-extension bug in crypto_hash_function.
9011 * fns.c (to_uchar): Define.
9012 (crypto_hash_function): Use it to convert some newly-signed
9013 variables to unsigned, to avoid sign-extension bugs. For example,
9014 without this change, (md5 "truc") would evaluate to
9015 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9016 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
9017 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
9019 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9021 Integer overflow fixes.
9023 * dbusbind.c: Serial number integer overflow fixes.
9024 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
9025 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9026 to hold a serial number that is too large for a fixnum.
9027 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9028 Check for serial numbers out of range. Decode any serial number
9029 that was so large that it became a float. (Bug#8722)
9031 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9032 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9033 Use XFASTINT rather than XUINT when numbers are nonnegative.
9034 (xd_append_arg, Fdbus_method_return_internal):
9035 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9036 arguments, check that Lisp number is nonnegative, rather than
9037 silently wrapping negative numbers around. (Bug#8722)
9038 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
9041 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9043 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9045 ccl: Add integer overflow checks.
9046 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9047 (IN_INT_RANGE): New macros.
9048 (ccl_driver): Use them to check for integer overflow when
9049 decoding a CCL program. Many of the new checks are whether XINT (x)
9050 fits in int; it doesn't always, on 64-bit hosts. The new version
9051 doesn't catch all possible integer overflows, but it's an
9052 improvement. (Bug#8719)
9054 * alloc.c (make_event_array): Use XINT, not XUINT.
9055 There's no need for unsigned here.
9057 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9058 This follows up to the 2011-05-06 change that substituted uintptr_t
9059 for EMACS_INT. This case wasn't caught back then.
9061 Rework Fformat to avoid integer overflow issues.
9062 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9063 now (part of C89). Include <verify.h>.
9064 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9065 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9066 (Fformat): Avoid the prepass trying to compute sizes; it was only
9067 approximate and thus did not catch overflow reliably. Instead, walk
9068 through the format just once, formatting and computing sizes as we go,
9069 checking for integer overflow at every step, and allocating a larger
9070 buffer as needed. Keep track separately whether the format is
9071 multibyte. Keep only the most-recently calculated precision, rather
9072 than them all. Record whether each argument has been converted to
9073 string. Use EMACS_INT, not int, for byte and char and arg counts.
9074 Support field widths and precisions larger than INT_MAX. Avoid
9075 sprintf's undefined behavior with conversion specifications such as %#d
9076 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9077 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9078 formatting out-of-range floating point numbers with int
9081 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9083 * data.c: Avoid integer truncation in expressions involving floats.
9084 * data.c: Include <intprops.h>.
9085 (arith_driver): When there's an integer overflow in an expression
9086 involving floating point, convert the integers to floating point
9087 so that the resulting value does not suffer from catastrophic
9088 integer truncation. For example, on a 64-bit host (* 4
9089 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9090 Do not rely on undefined behavior after integer overflow.
9092 merge count_size_as_multibyte, parse_str_to_multibyte
9093 * character.c, character.h (count_size_as_multibyte):
9094 Rename from parse_str_to_multibyte; all uses changed.
9095 Check for integer overflow.
9096 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9097 since it's now a duplicate of the other. This is more of
9098 a character than a buffer op, so better that it's in character.c.
9099 * fns.c, print.c: Adjust to above changes.
9101 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9103 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9105 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9107 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9108 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9109 (x_clipboard_manager_save): Now static.
9110 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9112 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9113 (crypto_hash_function): Now static.
9114 Fix pointer signedness problems. Avoid unnecessary initializations.
9116 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
9118 * termhooks.h (Vselection_alist): Make it terminal-local.
9120 * terminal.c (create_terminal): Initialize it.
9122 * xselect.c: Support for clipboard managers.
9123 (Vselection_alist): Move to termhooks.h as terminal-local var.
9124 (LOCAL_SELECTION): New macro.
9125 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9126 (symbol_to_x_atom): Remove gratuitous arg.
9127 (x_handle_selection_request, lisp_data_to_selection_data)
9128 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
9129 (x_own_selection, x_get_local_selection, x_convert_selection):
9130 New arg, specifying work frame. Use terminal-local Vselection_alist.
9131 (some_frame_on_display): Delete unused function.
9132 (Fx_own_selection_internal, Fx_get_selection_internal)
9133 (Fx_disown_selection_internal, Fx_selection_owner_p)
9134 (Fx_selection_exists_p): New optional frame arg.
9135 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9136 (x_handle_selection_clear): Don't treat other terminals with the
9137 same keyboard specially. Use the terminal-local Vselection_alist.
9138 (x_clear_frame_selections): Use Frun_hook_with_args.
9140 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9142 * xterm.h: Add support for those atoms.
9144 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
9146 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9147 (converted_selections, conversion_fail_tag): New global variables.
9148 (x_selection_request_lisp_error): Free the above.
9149 (x_get_local_selection): Remove unnecessary code.
9150 (x_reply_selection_request): Args changed; handle arbitrary array
9151 of converted selections stored in converted_selections.
9152 Separate the XChangeProperty and SelectionNotify steps.
9153 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9154 (x_convert_selection): New function.
9155 (x_handle_selection_event): Simplify.
9156 (x_get_foreign_selection): Don't ignore incoming requests while
9157 waiting for an answer; this will fail when we implement
9158 SAVE_TARGETS, and seems unnecessary anyway.
9159 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9160 (Vx_sent_selection_functions): Doc fix.
9162 2011-05-26 Leo Liu <sdl.web@gmail.com>
9164 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9166 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9168 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9170 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9171 for fringe update if it has periodic bitmap.
9172 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
9173 and fringe_bitmap_periodic_p.
9175 * fringe.c (get_fringe_bitmap_data): New function.
9176 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9177 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9178 row. Mark glyph row for fringe update if periodicity changed.
9180 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9181 for fringe update unless it has periodic bitmap.
9183 2011-05-25 Kenichi Handa <handa@m17n.org>
9185 * xdisp.c (get_next_display_element): Set correct it->face_id for
9186 a static composition.
9188 2011-05-24 Leo Liu <sdl.web@gmail.com>
9191 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9193 * fns.c (crypto_hash_function, Fsha1): New function.
9194 (Fmd5): Use crypto_hash_function.
9195 (syms_of_fns): Add Ssha1.
9197 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9199 * gnutls.c: Remove unused macros.
9200 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9201 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9202 Remove macros that are defined and never used.
9203 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9205 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9207 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9208 (Fx_get_selection_internal): Minor cleanup.
9209 (Fx_own_selection_internal): Rename arguments for consistency with
9212 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9214 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9216 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9218 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9220 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9222 * dispnew.c (scrolling_window): Don't exclude the case that the
9223 last enabled row in the desired matrix touches the bottom boundary.
9225 2011-05-21 Glenn Morris <rgm@gnu.org>
9227 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
9228 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9229 and add some more files.
9231 2011-05-20 Eli Zaretskii <eliz@gnu.org>
9233 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9234 report_file_error introduced by the change from 2011-05-07.
9236 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9238 * systime.h (Time): Define only if emacs is defined.
9239 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9240 where the include path doesn't have X11/X.h by default. See
9241 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9243 2011-05-20 Kenichi Handa <handa@m17n.org>
9245 * composite.c (find_automatic_composition): Fix previous change.
9247 2011-05-20 Glenn Morris <rgm@gnu.org>
9249 * lisp.mk: New file, split from Makefile.in.
9250 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9251 (shortlisp): Remove.
9252 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9254 2011-05-19 Glenn Morris <rgm@gnu.org>
9256 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9257 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9258 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9259 (lisp): Set the order to that of loadup.el.
9260 (shortlisp): Make it a copy of $lisp.
9261 (SOME_MACHINE_LISP): Remove.
9262 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9263 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9265 2011-05-18 Kenichi Handa <handa@m17n.org>
9267 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9268 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9269 (find_automatic_composition): Mostly rewrite for efficiency.
9271 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
9273 * makefile.w32-in: Update dependencies.
9275 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9277 * menu.c: Include limits.h (fixes the MS-Windows build broken by
9278 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
9280 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
9282 Fix some integer overflow issues, such as string length overflow.
9284 * insdel.c (count_size_as_multibyte): Check for string overflow.
9286 * character.c (lisp_string_width): Check for string overflow.
9287 Use EMACS_INT, not int, for string indexes and lengths; in
9288 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9289 the resulting string length overflows an EMACS_INT; instead,
9290 report a string overflow if no precision given. When checking for
9291 precision exhaustion, use a check that cannot possibly have
9292 integer overflow. (Bug#8675)
9293 * character.h (lisp_string_width): Adjust to new signature.
9295 * alloc.c (string_overflow): New function.
9296 (Fmake_string): Use it. This doesn't change behavior, but saves
9297 a few bytes and will simplify future changes.
9298 * character.c (string_escape_byte8): Likewise.
9299 * lisp.h (string_overflow): New decl.
9301 Fixups, following up to the user-interface timestamp change.
9302 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9303 for UI timestamps, instead of unsigned long.
9304 * msdos.c (mouse_get_pos): Likewise.
9305 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
9306 * w32gui.h (Time): Define by including "systime.h" rather than by
9307 declaring it ourselves. (Bug#8664)
9309 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9310 * image.c (clear_image_cache): Likewise.
9312 * term.c (term_mouse_position): Don't assume time_t wraparound.
9314 Be more systematic about user-interface timestamps.
9315 Before, the code sometimes used 'Time', sometimes 'unsigned long',
9316 and sometimes 'EMACS_UINT', to represent these timestamps.
9317 This change causes it to use 'Time' uniformly, as that's what X uses.
9318 This makes the code easier to follow, and makes it easier to catch
9319 integer overflow bugs such as Bug#8664.
9320 * frame.c (Fmouse_position, Fmouse_pixel_position):
9321 Use Time, not unsigned long, for user-interface timestamps.
9322 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9323 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9324 * keyboard.h (last_event_timestamp): Likewise.
9325 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9326 * menu.h (xmenu_show): Likewise.
9327 * term.c (term_mouse_position): Likewise.
9328 * termhooks.h (struct input_event.timestamp): Likewise.
9329 (struct terminal.mouse_position_hook): Likewise.
9330 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9331 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9332 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9333 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9335 * menu.h, termhooks.h: Include "systime.h", for Time.
9337 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9338 Don't assume that the difference between two unsigned long values
9339 can fit into an integer. At this point, we know button_down_time
9340 <= event->timestamp, so the difference must be nonnegative, so
9341 there's no need to cast the result if double-click-time is
9342 nonnegative, as it should be; check that it's nonnegative, just in
9343 case. This bug is triggered when events are more than 2**31 ms
9344 apart (about 25 days). (Bug#8664)
9346 * xselect.c (last_event_timestamp): Remove duplicate decl.
9347 (x_own_selection): Remove needless cast to unsigned long.
9349 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9350 that always fit in int. Use a sentinel instead of a counter, to
9351 avoid a temp and to allay GCC's concerns about possible int overflow.
9352 * frame.h (struct frame): Use int for menu_bar_items_used
9353 instead of EMACS_INT, since it always fits in int.
9355 * menu.c (grow_menu_items): Check for int overflow.
9357 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9359 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9360 Before, the code was not consistent. These values cannot exceed
9361 2**31 - 1 so there's no need to make them unsigned.
9362 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9363 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9364 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9366 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9368 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9369 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9370 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9371 presumably because the widths might not match.
9373 * window.c (size_window): Avoid needless test at loop start.
9375 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9377 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9379 2011-05-12 Drew Adams <drew.adams@oracle.com>
9381 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9383 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9385 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9386 `width' to `bar_area_x' and `bar_area_width', respectively.
9387 (x_scroll_run): Take account of fringe background extension.
9389 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9390 Rename local vars `left' and `width' to `bar_area_x' and
9391 `bar_area_width', respectively.
9392 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9393 background extension.
9395 2011-05-10 Jim Meyering <meyering@redhat.com>
9397 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9399 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
9401 * image.c (Finit_image_library): Return t for built-in image types,
9402 like pbm and xbm. (Bug#8640)
9404 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9406 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9408 2011-05-07 Eli Zaretskii <eliz@gnu.org>
9410 * w32console.c (Fset_screen_color): Doc fix.
9411 (Fget_screen_color): New function.
9412 (syms_of_ntterm): Defsubr it.
9414 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9415 unlink the temporary file if Fcall_process didn't create it in the
9417 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9418 child process will be redirected to a file specified with `:file'.
9419 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9420 cue to call_process_cleanup not to close that handle.
9422 2011-05-07 Ben Key <bkey76@gmail.com>
9424 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9425 one of two shell specific rules, either bootstrap-temacs-CMD or
9426 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9427 to the previous implementation of the bootstrap-temacs rule.
9428 The bootstrap-temacs-CMD rule is similar to the previous
9429 implementation of the bootstrap-temacs rule except that it
9430 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9433 These changes, along with some changes to nt/configure.bat,
9434 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9435 earlier fix to add support for --cflags and --ldflags options
9436 that include quotes so that it works whether make uses cmd or
9439 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
9441 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9442 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9444 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9445 a string. Handle both cases.
9446 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9447 (Fdbus_register_method): Use Qinvalid_function.
9449 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9451 * makefile.w32-in: Update dependencies.
9452 (LISP_H): Add inttypes.h and stdin.h.
9453 (PROCESS_H): Add unistd.h.
9455 2011-05-06 Eli Zaretskii <eliz@gnu.org>
9457 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9458 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9460 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
9462 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9464 * term.c (vfatal): Remove stray call to va_end.
9465 It's not needed and the C Standard doesn't allow it here anyway.
9467 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9468 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9470 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9473 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9475 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9477 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9479 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9481 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9483 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9484 * charset.c (Fdefine_charset_internal): Don't initialize
9485 charset.code_space[15]. The value was garbage, on hosts with
9486 32-bit int (Bug#8600).
9488 * lread.c (read_integer): Be more consistent with string-to-number.
9489 Use string_to_number to do the actual conversion; this avoids
9490 rounding errors and fixes some other screwups. Without this fix,
9491 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9492 (digit_to_number): Move earlier, for benefit of read_integer.
9493 Return -1 if the digit is out of range for the base, -2 if it is
9494 not a digit in any supported base. (Bug#8602)
9496 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9498 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9499 to match comment at start of function. This also removes a
9500 GCC warning about overflow in a 32+64-bit port.
9502 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9504 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9505 Reported by Stefan Monnier in
9506 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
9507 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9508 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
9510 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9511 (EMACS_UINTPTR): Likewise, with uintptr_t.
9513 * lisp.h: Prefer 64-bit EMACS_INT if available.
9514 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9515 on 32-bit hosts that have 64-bit int, so that they can access
9517 However, temporarily disable this change unless the temporary
9518 symbol WIDE_EMACS_INT is defined.
9520 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9522 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9523 This removes an assumption that EMACS_INT and long are the same
9524 width as pointers. The assumption is true for Emacs porting targets
9525 now, but we want to make other targets possible.
9526 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9527 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9528 In the rest of the code, change types of integers that hold casted
9529 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9530 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9531 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9532 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9533 No need to cast type when ORing.
9534 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9535 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9536 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9537 assume EMACS_INT is the same width as char *.
9538 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9539 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9540 Remove no-longer-needed casts.
9541 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9542 (xg_tool_bar_help_callback, xg_make_tool_item):
9543 Use EMACS_INTPTR to hold an integer
9544 that will be cast to void *; this can avoid a GCC warning
9545 if EMACS_INT is not the same width as void *.
9546 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9547 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9548 (current_message_1, set_message_1):
9549 Use a local to convert to proper width without a cast.
9550 * xmenu.c (dialog_selection_callback): Likewise.
9552 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9553 Also, don't assume VALBITS / RAND_BITS is less than 5,
9554 and don't rely on undefined behavior when shifting a 1 left into
9556 * lisp.h (get_random): Change signature to match.
9558 * lread.c (hash_string): Use size_t, not int, for hash computation.
9559 Normally we prefer signed values; but hashing is special, because
9560 it's better to use unsigned division on hash table sizes so that
9561 the remainder is nonnegative. Also, size_t is the natural width
9562 for hashing into memory. The previous code used 'int', which doesn't
9563 retain enough info to hash well into very large tables.
9564 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9566 * dbusbind.c: Don't possibly lose pointer info when converting.
9567 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9568 Use XPNTR rather than XHASH, so that the high-order bits of
9569 the pointer aren't lost when converting through void *.
9571 * eval.c (Fautoload): Don't double-shift a pointer.
9573 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9575 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9577 * gnutls.c (DEF_GNUTLS_FN):
9578 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9580 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9582 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9585 2011-05-05 Eli Zaretskii <eliz@gnu.org>
9587 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9588 New version that can reserve upto 2GB of heap space.
9590 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
9592 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9594 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9596 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9597 `gnutls_certificate_set_x509_key_file'.
9599 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
9601 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9602 Update dependencies.
9604 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9606 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9607 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9608 Remove unused parameter `fildes'.
9609 * process.c (read_process_output, send_process): Don't pass it.
9611 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9613 Fix previous change: the library cache is defined in w32.c.
9614 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9615 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9617 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9619 Implement dynamic loading of GnuTLS on Windows.
9621 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9622 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9623 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9626 * gnutls.c (Qgnutls_dll): Define.
9627 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9628 (gnutls_*): Declare function pointers.
9629 (init_gnutls_functions): New function to initialize function pointers.
9630 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9631 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9632 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9633 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9634 (emacs_gnutls_write, emacs_gnutls_read)
9635 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9636 (Fgnutls_available_p): New function.
9637 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9638 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9639 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9641 * image.c: Include w32.h.
9642 (Vimage_type_cache): Delete.
9643 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9644 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9645 (w32_delayed_load): Move to w32.c.
9647 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9649 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9650 (w32_delayed_load): Move from image.c. When loading a library, record
9651 its filename in the :loaded-from property of the library id.
9652 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9653 Initialize and staticpro them.
9654 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9656 * process.c: Include lisp.h before w32.h, not after.
9657 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9658 instead of gnutls_record_check_pending.
9660 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9662 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9664 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9665 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9668 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9670 * xterm.c (x_set_frame_alpha): Do not set property on anything
9671 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9673 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9675 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9677 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9679 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9680 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9681 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9682 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9683 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9684 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9685 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9686 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9687 (Qgnutls_bootprop_callbacks_verify): Make static.
9689 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9691 * callproc.c: Indentation fixup.
9693 * sysdep.c (wait_for_termination_1): Make static.
9694 (wait_for_termination, interruptible_wait_for_termination):
9695 Move after wait_for_termination_1.
9697 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9699 * sysdep.c (interruptible_wait_for_termination): New function
9700 which is like wait_for_termination, but allows keyboard
9703 * callproc.c (Fcall_process): Add (:file "file") as an option for
9705 (Fcall_process_region): Ditto.
9707 2011-04-30 Eli Zaretskii <eliz@gnu.org>
9709 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9710 rather than `XVECTOR (FOO)->size'.
9712 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9713 inttypes.h, as a gnulib replacement is used if it not available in
9716 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9718 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9719 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9720 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9722 * coding.c (coding_alloc_by_realloc): Error out if destination
9723 will grow beyond MOST_POSITIVE_FIXNUM.
9724 (decode_coding_emacs_mule): Abort if there isn't enough place in
9725 charbuf for the composition carryover bytes. Reserve an extra
9726 space for up to 2 characters produced in a loop.
9727 (decode_coding_iso_2022): Abort if there isn't enough place in
9728 charbuf for the composition carryover bytes.
9730 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9732 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9733 aborting when %lld or %lll format is passed.
9734 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9735 %llo or %llx format is passed. (Bug#8545)
9737 * window.c (window_scroll_line_based): Use a marker instead of
9738 simple variables to record original value of point. (Bug#7952)
9740 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9741 produced by %s or %c overflows available buffer space. (Bug#8545)
9743 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9745 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
9746 (SIZE_MAX): Move defn after all includes, as they might #define it.
9748 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9750 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9752 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9754 * keyboard.c (Qdelayed_warnings_hook): Define.
9755 (command_loop_1): Run `delayed-warnings-hook'
9756 if Vdelayed_warnings_list is non-nil.
9757 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9758 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9760 2011-04-28 Eli Zaretskii <eliz@gnu.org>
9762 * doprnt.c (doprnt): Don't return value smaller than the buffer
9763 size if the message was truncated. (Bug#8545).
9765 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9767 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9768 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9770 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9772 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9774 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
9776 * makefile.w32-in: Update dependencies.
9778 2011-04-27 Eli Zaretskii <eliz@gnu.org>
9780 Improve `doprnt' and its usage. (Bug#8545)
9781 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9782 `format_end'. Remove support for %l as a conversion specifier.
9783 Don't use xrealloc. Improve diagnostics when the %l size modifier
9784 is used. Update the commentary.
9786 * eval.c (verror): Simplify calculation of size_t.
9788 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9791 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9793 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9796 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9798 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9799 This makes this file independent of the recent pseudovector change.
9801 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
9803 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9805 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
9806 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
9807 Remove unused local.
9808 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
9810 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
9811 GCC 4.6.0 optimizes based on type-based alias analysis.
9812 For example, if b is of type struct buffer * and v of type struct
9813 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9814 != &v->size, and therefore "v->size = 1; b->size = 2; return
9815 v->size;" must therefore return 1. This assumption is incorrect
9816 for Emacs, since it type-puns struct Lisp_Vector * with many other
9817 types. To fix this problem, this patch adds a new type struct
9818 vectorlike_header that documents the constraints on layout of vectors
9819 and pseudovectors, and helps optimizing compilers not get fooled
9820 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9821 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
9822 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9824 (XSETPVECTYPE): Rewrite in terms of new macro.
9825 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9826 This is a bit clearer, and further avoids the possibility of
9827 undesirable aliasing.
9828 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
9829 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
9830 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9831 since Lisp_Subr is a special case (no "next" field).
9832 (ASIZE): Now uses header.size rather than size.
9833 All previous uses of XVECTOR (foo)->size replaced to use this macro,
9834 to avoid the hassle of writing XVECTOR (foo)->header.size.
9835 (struct vectorlike_header): New type.
9836 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9837 object, to help avoid aliasing.
9838 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9839 (SUBRP): Likewise, since Lisp_Subr is a special case.
9840 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9841 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9842 (struct Lisp_Hash_Table): Combine first two members into a single
9843 struct vectorlike_header member. All uses of "size" and "next" members
9844 changed to be "header.size" and "header.next".
9845 * buffer.h (struct buffer): Likewise.
9846 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9847 * frame.h (struct frame): Likewise.
9848 * process.h (struct Lisp_Process): Likewise.
9849 * termhooks.h (struct terminal): Likewise.
9850 * window.c (struct save_window_data, struct saved_window): Likewise.
9851 * window.h (struct window): Likewise.
9852 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9853 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9854 * buffer.c (init_buffer_once): Likewise.
9855 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9857 * process.c (Fformat_network_address): Use local var for size,
9860 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9862 Make the Lisp reader and string-to-float more consistent (Bug#8525)
9863 * data.c (atof): Remove decl; no longer used or needed.
9864 (digit_to_number): Move to lread.c.
9865 (Fstring_to_number): Use new string_to_number function, to be
9866 consistent with how the Lisp reader treats infinities and NaNs.
9867 Do not assume that floating-point numbers represent EMACS_INT
9868 without losing information; this is not true on most 64-bit hosts.
9869 Avoid double-rounding errors, by insisting on integers when
9870 parsing non-base-10 numbers, as the documentation specifies.
9871 * lisp.h (string_to_number): New decl, replacing ...
9872 (isfloat_string): Remove.
9873 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
9874 (read1): Do not accept +. and -. as integers; this
9875 appears to have been a coding error. Similarly, do not accept
9876 strings like +-1e0 as floating point numbers. Do not report
9877 overflow for integer overflows unless the base is not 10 which
9878 means we have no simple and reliable way to continue.
9879 Break out the floating-point parsing into a new
9880 function string_to_number, so that Fstring_to_number parses
9881 floating point numbers consistently with the Lisp reader.
9882 (digit_to_number): Move here from data.c. Make it static inline.
9883 (E_CHAR, EXP_INT): Remove, replacing with ...
9884 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9885 (string_to_number): New function, replacing isfloat_string.
9886 This function checks for valid syntax and produces the resulting
9887 Lisp float number too. Rework it so that string-to-number
9888 no longer mishandles examples like "1.0e+". Use strtoumax,
9889 so that overflow for non-base-10 numbers is reported only when
9890 there's no portable and simple way to convert to floating point.
9892 * textprop.c (set_text_properties_1): Rewrite for clarity,
9893 and to avoid GCC warning about integer overflow.
9895 * intervals.h (struct interval): Use EMACS_INT for members
9896 where EMACS_UINT might cause problems. See
9897 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9898 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9899 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9901 (offset_intervals): Tell GCC not to worry about length overflow
9902 when negating a negative length.
9904 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9905 (overrun_check_free): Likewise.
9907 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9908 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9911 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9912 (gnutls_make_error): Rename local to avoid shadowing.
9913 (gnutls_emacs_global_deinit): ifdef out; not used.
9914 (Fgnutls_boot): Use const for pointer to readonly storage.
9915 Comment out unused local. Fix pointer signedness problems.
9917 * lread.c (openp): Don't stuff size_t into an 'int'.
9918 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9919 about possible signed overflow.
9921 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9922 (GDK_KEY_g): Don't define if already defined.
9923 (xg_prepare_tooltip): Avoid pointer signedness problem.
9924 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9926 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9927 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9929 * xfns.c (Fx_window_property): Simplify a bit,
9930 to make a bit faster and to avoid GCC 4.6.0 warning.
9931 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9933 * fns.c (internal_equal): Don't assume size_t fits in int.
9935 * alloc.c (compact_small_strings): Tighten assertion a little.
9937 Replace pEd with more-general pI, and fix some printf arg casts.
9938 * lisp.h (pI): New macro, generalizing old pEd macro to other
9939 conversion specifiers. For example, use "...%"pI"d..." rather
9940 than "...%"pEd"...".
9941 (pEd): Remove. All uses replaced with similar uses of pI.
9942 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
9943 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9944 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9945 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9946 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9947 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9948 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9950 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9951 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9952 * print.c (safe_debug_print, print_object): Likewise.
9953 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9955 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9956 avoiding the 0 flag, which is not portable.
9957 * process.c (Fmake_network_process): Use pI to avoid cast.
9958 * region-cache.c (pp_cache): Likewise.
9959 * xdisp.c (decode_mode_spec): Likewise.
9960 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9961 behavior on 64-bit hosts with printf arg.
9962 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
9963 (x_stop_queuing_selection_requests): Likewise.
9964 (x_get_window_property): Don't truncate byte count to an 'int'
9967 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9968 here, since it parses constructs like leading '-' and spaces,
9969 which are not wanted; and it overflows with large numbers.
9970 Instead, simply match F[0-9]+, which is what is wanted anyway.
9972 * alloc.c: Remove unportable assumptions about struct layout.
9973 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9974 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9975 (allocate_vectorlike, make_pure_vector): Use the new macros,
9976 plus offsetof, to remove unportable assumptions about struct layout.
9977 These assumptions hold on all porting targets that I know of, but
9978 they are not guaranteed, they're easy to remove, and removing them
9979 makes further changes easier.
9981 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9982 This doesn't fix a bug but makes the code clearer.
9983 (string_overrun_cookie): Now const. Use initializers that
9984 don't formally overflow signed char, to avoid warnings.
9985 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9986 can cause Emacs to crash when string overrun checking is enabled.
9987 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9988 multiple of sizeof (EMACS_INT); it need not be, if
9989 alignof(EMACS_INT) < sizeof (EMACS_INT).
9990 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
9992 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
9994 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9996 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9998 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
9999 supposed to be handshaking. (Bug#8556)
10000 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10002 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
10004 * lisp.h (Qdebug): List symbol.
10005 * eval.c (Qdebug): Restore global linkage.
10006 * keyboard.c (debug-on-event): New variable.
10007 (handle_user_signal): Break into debugger when debug-on-event
10008 matches the current signal symbol.
10010 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10012 * alloc.c (check_sblock, check_string_bytes)
10013 (check_string_free_list): Convert to standard C.
10015 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10017 * w32.c (emacs_gnutls_push): Fix typo.
10019 2011-04-25 Eli Zaretskii <eliz@gnu.org>
10021 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10022 "cast to pointer from integer of different size".
10024 Improve doprnt and its use in verror. (Bug#8545)
10025 * doprnt.c (doprnt): Document the set of format control sequences
10026 supported by the function. Use SAFE_ALLOCA instead of always
10029 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10030 is one byte too soon. Don't use xrealloc; instead xfree and
10033 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10035 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10038 * gnutls.c: Renamed global_initialized to
10039 gnutls_global_initialized. Added internals for the
10040 :verify-hostname-error, :verify-error, and :verify-flags
10041 parameters of `gnutls-boot' and documented those parameters in the
10042 docstring. Start callback support.
10043 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10044 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10045 on error. Return error code.
10046 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10047 (emacs_gnutls_read): Likewise.
10048 (Fgnutls_boot): Return handshake error code.
10049 (emacs_gnutls_handle_error): New function.
10050 (wsaerror_to_errno): Likewise.
10052 * w32.h (emacs_gnutls_pull): Add prototype.
10053 (emacs_gnutls_push): Likewise.
10055 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10056 (emacs_gnutls_push): Likewise.
10058 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10060 * process.c (wait_reading_process_output): Check if GnuTLS
10061 buffered some data internally if no FDs are set for TLS
10064 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10065 (LIBS): Link to USER_LIBS.
10066 ($(BLD)/gnutls.$(0)): New target.
10068 2011-04-24 Eli Zaretskii <eliz@gnu.org>
10070 * xdisp.c (handle_single_display_spec): Rename the
10071 display_replaced_before_p argument into display_replaced_p, to
10072 make it consistent with the commentary. Fix typos in the
10075 * textprop.c (syms_of_textprop): Remove dead code.
10076 (copy_text_properties): Delete obsolete commentary about an
10077 interface that was deleted long ago. Fix typos in the description
10080 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10081 to changes in oldXMenu/XMenu.h from 2011-04-16.
10082 <menu_help_message, prev_menu_help_message>: Constify.
10083 (IT_menu_make_room): menu->help_text is now `const char **';
10086 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10087 to changes in oldXMenu/XMenu.h from 2011-04-16.
10088 (struct XMenu): Declare `help_text' `const char **'.
10090 * xfaces.c <Qunspecified>: Make extern again.
10092 * syntax.c: Include sys/types.h before including regex.h, as
10095 * doc.c (get_doc_string): Improve the format passed to `error'.
10097 * doprnt.c (doprnt): Improve commentary.
10099 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10101 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10104 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10105 changes in globals.h immediately force recompilation.
10106 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10107 $(CURDIR)/s/ms-w32.h.
10108 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
10110 * character.c (Fchar_direction): Function deleted.
10111 (syms_of_character): Don't defsubr it.
10112 <char-direction-table>: Deleted.
10114 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10116 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10117 * doprnt.c: Include limits.h.
10118 (SIZE_MAX): New macro.
10119 (doprnt): Return a size_t value. 2nd arg is now size_t.
10120 Many local variables are now size_t instead of int or unsigned.
10121 Improve overflow protection. Support `l' modifier for integer
10122 conversions. Support %l conversion. Don't assume an EMACS_INT
10123 argument for integer conversions and for %c.
10125 * lisp.h (doprnt): Restore prototype.
10127 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10128 $(SRC)/character.h.
10130 * Makefile.in (base_obj): Add back doprnt.o.
10132 * deps.mk (doprnt.o): Add back prerequisites.
10133 (callint.o): Depend on character.h.
10135 * eval.c (internal_lisp_condition_case): Include the handler
10136 representation in the error message.
10137 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10138 when breaking from the loop.
10140 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10142 * callint.c (Fcall_interactively): When displaying error message
10143 about invalid control letter, pass the character's codepoint, not
10144 a pointer to its multibyte form. Improve display of the character
10145 in octal and display also its hex code.
10147 * character.c (char_string): Use %x to display the (unsigned)
10148 codepoint of an invalid character, to avoid displaying a bogus
10151 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10152 `error', not SYMBOL_NAME itself.
10154 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10155 character arguments to `error'.
10157 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10158 to `error' in error message about FINAL_CHAR argument. Make sure
10159 FINAL_CHAR is a character, and use %c when it is passed as
10160 argument to `error'.
10162 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10164 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10166 * w32.c: Include <time.h>.
10167 (sys_localtime): New function.
10169 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
10171 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10173 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
10175 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
10177 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10178 zombies (Bug#8467).
10180 2011-04-19 Eli Zaretskii <eliz@gnu.org>
10182 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10183 gl_state.e_property when gl_state.object is Qt.
10185 * insdel.c (make_gap_larger): Remove limitation of buffer size
10188 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
10190 * xdisp.c (lookup_glyphless_char_display)
10191 (produce_glyphless_glyph): Handle cons cell entry in
10192 glyphless-char-display.
10193 (Vglyphless_char_display): Document it.
10195 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10196 glyphless-char-display.
10198 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
10200 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10202 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10204 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10205 definition for no-X builds.
10207 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
10209 Static checks with GCC 4.6.0 and non-default toolkits.
10211 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10213 * process.c (keyboard_bit_set): Define only if SIGIO.
10214 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10215 (send_process): Repair possible setjmp clobbering.
10217 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10219 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10221 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10223 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10224 Define only if needed.
10226 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10227 by pacifying GCC about it. Maybe it's time to retire it?
10228 * xfaces.c (USG, __TIMEVAL__): Likewise.
10230 * dispextern.h (struct redisplay_interface): Rename param
10231 to avoid shadowing.
10232 * termhooks.h (struct terminal): Likewise.
10233 * xterm.c (xembed_send_message): Likewise.
10235 * insdel.c (make_gap_smaller): Define only if
10236 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10238 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10241 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10242 so that we aren't warned about unused symbols.
10244 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10246 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
10248 * xfns.c (x_real_positions): Mark locals as initialized.
10250 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10252 * xterm.c: Fix problems found by static analysis with other toolkits.
10253 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
10254 (x_dispatch_event): Declare static if USE_GTK, and
10255 define if USE_GTK || USE_X_TOOLKIT.
10256 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
10257 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
10258 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10259 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
10261 * xmenu.c (menu_help_callback): Pointer type fixes.
10262 Use const pointers when pointing at readonly data. Avoid pointer
10263 signedness clashes.
10264 (FALSE): Remove unused macro.
10265 (update_frame_menubar): Remove unused decl.
10267 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10269 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10270 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10271 (single_menu_item): Rename local to avoid shadowing.
10273 * keyboard.c (make_lispy_event): Remove unused local var.
10275 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10276 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10278 * bitmaps: Change bitmaps from unsigned char back to the X11
10279 compatible char. Avoid the old compiler warnings about
10280 out-of-range initializers by using, for example, '\xab' rather
10283 * xgselect.c (xgselect_initialize): Check vs interface
10284 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10286 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10288 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10289 to read-only memory.
10291 * fns.c (vector): Remove; this old hack is no longer needed.
10293 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
10295 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
10297 * xrdb.c (x_load_resources): Omit unused local.
10299 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
10300 (x_window): Rename locals to avoid shadowing.
10301 (USG): Use the kludged USG macro, to pacify gcc.
10303 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
10304 (x_term_init): Remove local to avoid shadowing.
10306 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
10308 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10309 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10311 2011-04-16 Eli Zaretskii <eliz@gnu.org>
10313 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10315 Fix regex.c, syntax.c and friends for buffers > 2GB.
10316 * syntax.h (struct gl_state_s): Declare character position members
10319 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10321 * textprop.c (verify_interval_modification, interval_of):
10322 Declare arguments EMACS_INT.
10324 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10327 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10329 * indent.c (Fvertical_motion): Local variable it_start is now
10332 * regex.c (re_match, re_match_2, re_match_2_internal)
10333 (bcmp_translate, regcomp, regexec, print_double_string)
10334 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10335 (re_compile_pattern, re_exec): Declare arguments and local
10336 variables `size_t' and `ssize_t' and return values `regoff_t', as
10338 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10339 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10340 <compile_stack_type>: `size' and `avail' are now `size_t'.
10342 * regex.h <regoff_t>: Use ssize_t, not int.
10343 (re_search, re_search_2, re_match, re_match_2): Arguments that
10344 specify buffer/string position and length are now ssize_t and
10345 size_t. Return type is regoff_t.
10347 2011-04-16 Ben Key <bkey76@gmail.com>
10349 * nsfont.m: Fixed bugs in ns_get_family and
10350 ns_descriptor_to_entity that were caused by using free to
10351 deallocate memory blocks that were allocated by xmalloc (via
10352 xstrdup). This caused Emacs to crash when compiled with
10353 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10354 --enable-checking=xmallocoverrun). xfree is now used to
10355 deallocate these memory blocks.
10357 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
10359 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10361 emacs_write: Accept and return EMACS_INT for sizes.
10362 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10364 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10365 Accept and return EMACS_INT.
10366 (emacs_gnutls_write): Return the number of bytes written on
10368 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
10369 (emacs_read, emacs_write): Remove check for negative size, as the
10370 Emacs source code has been audited now.
10371 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10372 (emacs_read, emacs_write): Use it.
10373 * process.c (send_process): Adjust to the new signatures of
10374 emacs_write and emacs_gnutls_write. Do not attempt to store
10375 a byte offset into an 'int'; it might overflow.
10376 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
10378 * sound.c: Don't assume sizes fit in 'int'.
10379 (struct sound_device.period_size, alsa_period_size):
10380 Return EMACS_INT, not int.
10381 (struct sound_device.write, vox_write, alsa_write):
10382 Accept EMACS_INT, not int.
10383 (wav_play, au_play): Use EMACS_INT to store sizes and to
10384 record read return values.
10386 2011-04-15 Ben Key <bkey76@gmail.com>
10388 * keyboard.c (Qundefined): Don't declare static since it is used
10390 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10391 static since they are used in nsfont.m.
10393 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10395 * process.c (Qprocessp): Don't declare static.
10396 * lisp.h (Qprocessp): Declare again.
10398 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
10400 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10402 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10404 Improve C-level modularity by making more things 'static'.
10406 Don't publish debugger-only interfaces to other modules.
10407 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10408 (verify_bytepos, count_markers): Move decls to the only modules
10410 * region-cache.h (pp_cache): Likewise.
10411 * window.h (check_all_windows): Likewise.
10412 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10414 * sysdep.c (croak): Now static, if
10415 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10416 * syssignal.h (croak): Declare only if not static.
10418 * alloc.c (refill_memory_reserve): Now static if
10419 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10420 * lisp.h (refill_memory_reserve): Declare only if not static.
10422 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10423 Define only if USE_LUCID.
10425 * xrdb.c (x_customization_string, x_rm_string): Now static.
10427 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10428 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10430 * xdisp.c (draw_row_with_mouse_face): Now static.
10431 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10433 * window.h (check_all_windows): Mark externally visible.
10435 * window.c (window_deletion_count): Now static.
10437 * undo.c: Make symbols static if they're not exported.
10438 (last_undo_buffer, last_boundary_position, pending_boundary):
10441 * textprop.c (interval_insert_behind_hooks): Now static.
10442 (interval_insert_in_front_hooks): Likewise.
10444 * term.c: Make symbols static if they're not exported.
10445 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10446 (max_frame_lines, tty_set_terminal_modes):
10447 (tty_reset_terminal_modes, tty_turn_off_highlight):
10448 (get_tty_terminal): Now static.
10449 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10450 * termhooks.h (term_mouse_moveto): Do not declare if
10451 HAVE_WINDOW_SYSTEM.
10452 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10453 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10455 * sysdep.c: Make symbols static if they're not exported.
10456 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10458 (sigprocmask_set, full_mask): Remove; unused.
10459 (wait_debugging): Mark as visible.
10460 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10461 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10463 * syntax.c (syntax_temp): Define only if !__GNUC__.
10465 * sound.c (current_sound_device, current_sound): Now static.
10467 * search.c (searchbufs, searchbuf_head): Now static.
10469 * scroll.c (scroll_cost): Remove; unused.
10470 * dispextern.h (scroll_cost): Remove decl.
10472 * region-cache.h (pp_cache): Mark as externally visible.
10474 * process.c: Make symbols static if they're not exported.
10475 (process_tick, update_tick, create_process, chan_process):
10476 (Vprocess_alist, proc_buffered_char, datagram_access):
10477 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10478 (deactivate_process): Mark defn as static, as well as decl.
10479 * lisp.h (create_process): Remove decl.
10480 * process.h (chan_process, Vprocess_alist): Remove decls.
10482 * print.c: Make symbols static if they're not exported.
10483 (print_depth, new_backquote_output, being_printed, print_buffer):
10484 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10485 (print_interval, print_number_index, initial_stderr_stream):
10487 * lisp.h (Fprinc): Remove decl.
10488 (debug_output_compilation_hack): Mark as externally visible.
10490 * sysdep.c (croak): Move decl from here to syssignal.h.
10491 * syssignal.h (croak): Put it here, so the API can be checked when
10492 'croak' is called from dissociate_if_controlling_tty.
10494 * minibuf.c: Make symbols static if they're not exported.
10495 (minibuf_save_list, choose_minibuf_frame): Now static.
10496 * lisp.h (choose_minibuf_frame): Remove decl.
10498 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10500 * lread.c: Make symbols static if they're not exported.
10501 (read_objects, initial_obarray, oblookup_last_bucket_number):
10503 (make_symbol): Remove; unused.
10504 * lisp.h (initial_obarray, make_symbol): Remove decls.
10506 * keyboard.c: Make symbols static if they're not exported.
10507 (single_kboard, recent_keys_index, total_keys, recent_keys):
10508 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10509 (this_single_command_key_start, echoing, last_auto_save):
10510 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10511 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10512 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10513 (Vlispy_mouse_stem, double_click_count):
10515 (force_auto_save_soon): Define only if SIGDANGER.
10516 (ignore_mouse_drag_p): Now static if
10517 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10518 (print_help): Remove; unused.
10519 (stop_character, last_timer_event): Mark as externally visible.
10520 * keyboard.h (ignore_mouse_drag_p): Declare only if
10521 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10522 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10523 * lisp.h (echoing): Remove decl.
10524 (force_auto_save_soon): Declare only if SIGDANGER.
10525 * xdisp.c (redisplay_window): Simplify code, to make it more
10526 obvious that ignore_mouse_drag_p is not accessed if !defined
10527 USE_GTK && !defined HAVE_NS.
10529 * intervals.c: Make symbols static if they're not exported.
10530 (merge_properties_sticky, merge_interval_right, delete_interval):
10532 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10534 * insdel.c: Make symbols static if they're not exported.
10535 However, leave prepare_to_modify_buffer alone. It's never
10536 called from outside this function, but that appears to be a bug.
10537 (combine_after_change_list, combine_after_change_buffer):
10538 (adjust_after_replace, signal_before_change): Now static.
10539 (adjust_after_replace_noundo): Remove; unused.
10540 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
10541 (signal_before_change): Remove decls.
10543 * indent.c (val_compute_motion, val_vmotion): Now static.
10545 * image.c: Make symbols static if they're not exported.
10546 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10548 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10549 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10551 * fringe.c (standard_bitmaps): Now static.
10552 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10554 * frame.c: Make symbols static if they're not exported.
10555 (x_report_frame_params, make_terminal_frame): Now static.
10556 (get_frame_param): Now static, unless HAVE_NS.
10557 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10558 (x_get_resource_string): Remove; not used.
10559 * frame.h (make_terminal_frame, x_report_frame_params):
10560 (x_get_resource_string); Remove decls.
10561 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10562 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10564 * font.c, fontset.c: Make symbols static if they're not exported.
10565 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10566 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10567 * font.c (font_close_object): Now static.
10568 * font.h (font_close_object): Remove.
10569 * fontset.c (FONTSET_OBJLIST): Remove.
10570 (free_realized_fontset) #if-0 the body, which does nothing.
10571 (face_suitable_for_char_p): #if-0, as it's never called.
10572 * fontset.h (face_suitable_for_char_p): Remove decl.
10573 * xfaces.c (face_at_string_position):
10574 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
10575 since 0 is always ASCII.
10577 * fns.c (weak_hash_tables): Now static.
10579 * fileio.c: Make symbols static if they're not exported.
10580 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10581 (Vwrite_region_annotation_buffers): Now static.
10583 * eval.c: Make symbols static if they're not exported.
10584 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10585 * lisp.h (backtrace_list): Remove decl.
10587 * emacs.c: Make symbols static if they're not exported.
10588 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10589 (fatal_error_code, fatal_error_signal_hook, standard_args):
10591 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10592 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10593 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10594 * lisp.h (fatal_error_signal_hook): Remove decl.
10595 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10597 * editfns.c: Move a (normally-unused) function to its only use.
10598 * editfns.c, lisp.h (get_operating_system_release): Remove.
10599 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10600 worth the hassle of breaking this out.
10602 * xterm.c: Make symbols static if they're not exported.
10603 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10604 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10605 (x_destroy_window, x_delete_display):
10607 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10608 (x_mouse_leave): Remove; unused.
10609 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10610 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10611 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10613 (x_mouse_leave): Declare only if WINDOWSNT.
10614 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10615 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10618 * ftxfont.c: Make symbols static if they're not exported.
10619 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10621 * font.h (ftxfont_driver): Likewise.
10623 * xfns.c: Make symbols static if they're not exported.
10624 (x_last_font_name, x_display_info_for_name):
10625 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10626 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10627 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10628 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10629 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10630 (last_show_tip_args): Now static.
10631 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10632 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10633 (x_screen_planes): Remove; unused.
10634 * dispextern.h (x_screen_planes): Remove decl.
10636 * dispnew.c: Make symbols static if they're not exported.
10637 * dispextern.h (redraw_garbaged_frames, scrolling):
10638 (increment_row_positions): Remove.
10639 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10640 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10642 (redraw_garbaged_frames): Remove; unused.
10644 * xfaces.c: Make symbols static if they're not exported.
10645 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10647 * xterm.h (defined_color): Remove decls.
10648 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10649 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10650 (menu_face_changed_default, defined_color, free_realized_face):
10651 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10652 (ascii_face_of_lisp_face): Remove; unused.
10654 * xdisp.c: Make symbols static if they're not exported.
10655 * dispextern.h (scratch_glyph_row, window_box_edges):
10656 (glyph_to_pixel_coords, set_cursor_from_row):
10657 (get_next_display_element, set_iterator_to_next):
10658 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10659 (show_mouse_face): Remove decls
10660 * frame.h (message_buf_print): Likewise.
10661 * lisp.h (pop_message, set_message, check_point_in_composition):
10663 * xterm.h (set_vertical_scroll_bar): Likewise.
10664 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10665 (message_buf_print, scratch_glyph_row, displayed_buffer):
10666 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10667 (get_next_display_element, show_mouse_face, window_box_edges):
10668 (frame_to_window_pixel_xy, check_point_in_composition):
10669 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10670 (glyph_to_pixel_coords): Remove; unused.
10672 * dired.c (file_name_completion): Now static.
10674 * dbusbind.c (xd_in_read_queued_messages): Now static.
10676 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10677 * data.c (circular_list_error): Remove.
10679 * commands.h (last_point_position, last_point_position_buffer):
10680 (last_point_position_window): Remove decls.
10681 * keyboard.c: Make these variables static.
10683 * coding.h (coding, code_convert_region, encode_coding_gap):
10685 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10686 (iso_code_class, detect_coding, code_convert_region): Now static.
10687 (encode_coding_gap): Remove; unused.
10689 * chartab.c (chartab_chars, chartab_bits): Now static.
10691 * charset.h (charset_iso_8859_1): Remove decl.
10692 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10695 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10696 * ccl.c (Vccl_program_table): Now static.
10697 (check_ccl_update): Remove; unused.
10699 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10700 * category.h: ... from here.
10701 * category.c (check_category_table, set_category_set): Now static.
10703 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10704 * lisp.h: Remove these decls.
10706 * buffer.c (buffer_count): Remove unused var.
10708 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10709 so that it's not optimized away.
10710 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10711 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10712 exported only to the debugger.
10714 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
10715 * atimer.h (run_all_atimers): Remove; not exported.
10717 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10718 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10719 was inaccessible from Lisp.
10720 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10721 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10723 alloc.c: Import and export fewer symbols, and remove unused items.
10724 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10726 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10727 it's not optimized away by whole-program optimization.
10728 (message_enable_multibyte, free_misc): Remove.
10729 (catchlist, handlerlist, mark_backtrace):
10730 Declare only if BYTE_MARK_STACK.
10731 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10732 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10733 (message_enable_multibyte): Remove decl.
10734 (free_misc, interval_free_list, float_block, float_block_index):
10735 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10736 (cons_free_list, last_marked_index):
10738 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10739 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10740 (mark_backtrace): Define only if BYTE_MARK_STACK.
10741 * xdisp.c (message_enable_multibyte): Now static.
10743 Declare Lisp_Object Q* variables to be 'static' if not exported.
10744 This makes it easier for human readers (and static analyzers)
10745 to see whether these variables are used from other modules.
10746 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10747 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10748 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10749 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10750 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10751 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10752 * xmenu.c, xselect.c:
10753 Declare Q* vars static if they are not used in other modules.
10754 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10755 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10756 Remove decls of unexported vars.
10757 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10759 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10761 Make Emacs functions such as Fatom 'static' by default.
10762 This makes it easier for human readers (and static analyzers)
10763 to see whether these functions can be called from other modules.
10764 DEFUN now defines a static function. To make the function external
10765 so that it can be used in other C modules, use the new macro DEFUE.
10766 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10767 (Finit_image_library):
10768 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10769 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10770 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10771 Remove decls, since these functions are now static.
10772 (Funintern, Fget_internal_run_time): New decls, since these functions
10773 were already external.
10775 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10776 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10777 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10778 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10779 * keyboard.c, keymap.c, lread.c:
10780 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10781 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10782 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10783 Mark functions with DEFUE instead of DEFUN,
10784 if they are used in other modules.
10785 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10786 decls for now-static functions.
10787 * buffer.h (Fdelete_overlay): Remove decl.
10788 * callproc.c (Fgetenv_internal): Mark as internal.
10789 * composite.c (Fremove_list_of_text_properties): Remove decl.
10790 (Fcomposition_get_gstring): New forward static decl.
10791 * composite.h (Fcomposite_get_gstring): Remove decl.
10792 * dired.c (Ffile_attributes): New forward static decl.
10793 * doc.c (Fdocumntation_property): New forward static decl.
10794 * eval.c (Ffetch_bytecode): New forward static decl.
10795 (Funintern): Remove extern decl; now in .h file where it belongs.
10796 * fileio.c (Fmake_symbolic_link): New forward static decl.
10797 * image.c (Finit_image_library): New forward static decl.
10798 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10799 * intervals.h (Fprevious_property_change):
10800 (Fremove_list_of_text_properties): Remove decls.
10801 * keyboard.c (Fthis_command_keys): Remove decl.
10802 (Fcommand_execute): New forward static decl.
10803 * keymap.c (Flookup_key): New forward static decl.
10804 (Fcopy_keymap): Now static.
10805 * keymap.h (Flookup_key): Remove decl.
10806 * process.c (Fget_process): New forward static decl.
10807 (Fprocess_datagram_address): Mark as internal.
10808 * syntax.c (Fsyntax_table_p): New forward static decl.
10809 (skip_chars): Remove duplicate decl.
10810 * textprop.c (Fprevious_property_change): New forward static decl.
10811 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10813 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10814 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10816 * editfns.c (Fformat): Remove unreachable code.
10818 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10820 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10823 2011-04-13 Eli Zaretskii <eliz@gnu.org>
10825 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10826 when at ZV. (Bug#8487)
10828 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10830 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10832 * keyboard.c (parse_tool_bar_item): Likewise.
10833 * sound.c (sound_cleanup, alsa_close): Likewise.
10834 * termcap.c (tgetent): Likewise.
10835 * xfns.c (x_default_font_parameter): Likewise.
10836 * xsettings.c (read_and_apply_settings): Likewise.
10838 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10839 (overrun_check_free): Protoize.
10841 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10843 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10844 since callers should never pass a negative size.
10845 Change the signature to match that of plain 'read' and 'write'; see
10846 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10847 * lisp.h: Update prototypes of emacs_write and emacs_read.
10849 2011-04-11 Eli Zaretskii <eliz@gnu.org>
10851 * xdisp.c (redisplay_window): Don't try to determine the character
10852 position of the scroll margin if the window start point w->startp
10853 is outside the buffer's accessible region. (Bug#8468)
10855 2011-04-10 Eli Zaretskii <eliz@gnu.org>
10857 Fix write-region and its subroutines for buffers > 2GB.
10858 * fileio.c (a_write, e_write): Modify declaration of arguments and
10859 local variables to support buffers larger than 2GB.
10860 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10862 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10863 argument, local variables, and return value.
10865 * lisp.h: Update prototypes of emacs_write and emacs_read.
10867 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10869 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
10871 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10873 Fix more problems found by GCC 4.6.0's static checks.
10875 * xdisp.c (vmessage): Use a better test for character truncation.
10877 * charset.c (load_charset_map): <, not <=, for optimization,
10878 and to avoid potential problems with integer overflow.
10879 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
10880 * casetab.c (set_identity, shuffle): Likewise.
10881 * editfns.c (Fformat): Likewise.
10882 * syntax.c (skip_chars): Likewise.
10884 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10885 This also lets GCC 4.6.0 generate slightly better loop code.
10887 * callint.c (Fcall_interactively): <, not <=, for optimization.
10888 (Fcall_interactively): Count the number of arguments produced,
10889 not the number of arguments given. This is simpler and lets GCC
10890 4.6.0 generate slightly better code.
10892 * ftfont.c: Distingish more carefully between FcChar8 and char.
10893 The previous code passed unsigned char * to a functions like
10894 strlen and xstrcasecmp that expect char *, which does not
10895 conform to the C standard.
10896 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10897 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10898 char * when the C standard requires it.
10900 * keyboard.c (read_char): Remove unused var.
10902 * eval.c: Port to Windows vsnprintf (Bug#8435).
10903 Include <limits.h>.
10904 (SIZE_MAX): Define if the headers do not.
10905 (verror): Do not give up if vsnprintf returns a negative count.
10906 Instead, grow the buffer. This ports to Windows vsnprintf, which
10907 does not conform to C99. Problem reported by Eli Zaretskii.
10908 Also, simplify the allocation scheme, by avoiding the need for
10909 calling realloc, and removing the ALLOCATED variable.
10911 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10913 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10914 But keep the doprint source code for now, as we might revamp it
10915 and use it again (Bug#8435).
10916 * lisp.h (doprnt): Remove.
10917 * Makefile.in (base_obj): Remove doprnt.o.
10918 * deps.mk (doprnt.o): Remove.
10920 error: Print 32- and 64-bit integers portably (Bug#8435).
10921 Without this change, on typical 64-bit hosts error ("...%d...", N)
10922 was used to print both 32- and 64-bit integers N, which relied on
10923 undefined behavior.
10924 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
10925 * lisp.h (error, verror): Mark as printf-like functions.
10926 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10927 Report overflow in size calculations when allocating printf buffer.
10928 Do not truncate output string at its first null byte.
10929 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10930 Truncate the output at a character boundary, since vsnprintf does not
10932 * charset.c (check_iso_charset_parameter): Convert internal
10933 character to string before calling 'error', since %c now has the
10935 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10936 overflow when computing char to be passed to 'error'. Do not
10937 pass Lisp_Object to 'error'; pass the integer instead.
10938 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10939 formatted with plain %d.
10941 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10943 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10945 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10947 * xterm.c (x_catch_errors): Remove duplicate declaration.
10949 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10951 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10953 2011-04-10 Jim Meyering <meyering@redhat.com>
10955 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10956 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10957 return ssize_t not "int", and use size_t as the buffer length.
10958 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10959 * gnutls.h: Update declarations.
10960 * process.c (read_process_output): Use ssize_t, to match.
10961 (send_process): Likewise.
10963 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10965 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10967 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10969 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10970 Use unsigned char, to match FcChar8 type definition.
10972 * xterm.c (handle_one_xevent):
10973 * xmenu.c (create_and_show_popup_menu):
10974 * xselect.c (x_decline_selection_request)
10975 (x_reply_selection_request): Avoid type-punned deref of X events.
10977 2011-04-09 Eli Zaretskii <eliz@gnu.org>
10979 Fix some uses of `int' instead of EMACS_INT.
10980 * search.c (string_match_1, fast_string_match)
10981 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10982 (scan_buffer, find_next_newline_no_quit)
10983 (find_before_next_newline, search_command, Freplace_match)
10984 (Fmatch_data): Make some `int' variables be EMACS_INT.
10986 * xdisp.c (display_count_lines): 3rd argument and return value now
10987 EMACS_INT. All callers changed.
10988 (pint2hrstr): Last argument is now EMACS_INT.
10990 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10991 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10992 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10993 (decode_coding_utf_16, decode_coding_emacs_mule)
10994 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10995 (decode_coding_ccl, decode_coding_charset)
10996 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10997 (decode_coding_iso_2022, decode_coding_emacs_mule)
10998 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10999 <char_offset, last_offset>: Declare EMACS_INT.
11000 (encode_coding_utf_8, encode_coding_utf_16)
11001 (encode_coding_emacs_mule, encode_invocation_designation)
11002 (encode_designation_at_bol, encode_coding_iso_2022)
11003 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11004 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11006 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11007 (encode_invocation_designation): Last argument P_NCHARS is now
11009 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11010 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11012 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11015 * ccl.c (Fccl_execute_on_string): Declare some variables
11018 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
11020 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11022 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11024 * process.c (Fformat_network_address): Doc fix.
11026 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11028 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
11030 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
11032 * keyboard.c (read_char): Call Lisp function help-form-show,
11033 instead of using internal_with_output_to_temp_buffer.
11034 (Qhelp_form_show): New var.
11035 (syms_of_keyboard): Use DEFSYM macro.
11037 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11039 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11041 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
11043 * process.c (Flist_processes): Remove to Lisp.
11044 (list_processes_1): Delete.
11046 2011-04-06 Eli Zaretskii <eliz@gnu.org>
11048 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11050 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11052 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
11054 Fix more problems found by GCC 4.6.0's static checks.
11056 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11058 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11060 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
11062 * xdisp.c (vmessage): Mark as a printf-like function.
11064 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11066 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11068 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11069 printf-like functions.
11070 (tiff_load): Add casts to remove these marks before passing them
11071 to system-supplied API.
11073 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11075 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11076 This avoids several warnings with gcc -Wstrict-overflow.
11077 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11078 directly, rather than having caller test rule sign. This avoids
11079 some unnecessary tests.
11080 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11081 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11082 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
11084 * xfont.c (xfont_text_extents): Remove var that was set but not used.
11085 (xfont_open): Avoid unnecessary tests.
11087 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11089 * composite.h, composite.c (composition_gstring_put_cache):
11090 Use EMACS_INT, not int, for length.
11092 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11093 breaking out part of COMPOSITION_DECODE_RULE.
11094 (COMPOSITION_DECODE_RULE): Use it.
11095 * composite.c (get_composition_id): Remove unused local vars,
11096 by using the new macro.
11098 * textprop.c (set_text_properties_1): Change while to do-while,
11099 since the condition is always true at first.
11101 * intervals.c (graft_intervals_into_buffer): Mark var as used.
11102 (interval_deletion_adjustment): Return unsigned value.
11105 * process.c (list_processes_1, create_pty, read_process_output):
11106 (exec_sentinel): Remove vars that were set but not used.
11107 (create_pty): Remove unnecessary "volatile"s.
11108 (Fnetwork_interface_info): Avoid possibility of int overflow.
11109 (read_process_output): Do adaptive read buffering even if carryover.
11110 (read_process_output): Simplify nbytes computation if buffered.
11112 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11114 * syntax.c (scan_words): Remove var that was set but not used.
11115 (update_syntax_table): Use unsigned instead of int.
11117 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
11118 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
11119 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
11121 * print.c (print_error_message): Avoid int overflow.
11123 * font.c (font_list_entities): Redo for clarity,
11124 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11126 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
11127 (font_score): Avoid potential overflow in diff calculation.
11129 * fns.c (substring_both): Remove var that is set but not used.
11130 (sxhash): Redo loop for clarity and to avoid wraparound warning.
11132 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11134 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11135 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11136 can always succeed if overflow has undefined behavior.
11138 * search.c (boyer_moore, wordify): Remove vars set but not used.
11139 (wordify): Omit three unnecessary tests.
11141 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11142 All callers changed. This avoids the need for an unused var.
11144 * casefiddle.c (casify_region): Remove var that is set but not used.
11146 * dired.c (file_name_completion): Remove var that is set but not used.
11148 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11150 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
11151 (Finsert_file_contents): Remove unnecessary code checking fd.
11153 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11154 Check for integer overflow on size calculations.
11156 * buffer.c (Fprevious_overlay_change): Remove var that is set
11159 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11160 Remove vars that are set but not used.
11161 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
11162 (timer_check_2): Mark vars as initialized.
11164 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11166 * image.c (lookup_image): Remove var that is set but not used.
11167 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
11169 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11170 that are set but not used.
11172 * xfns.c (make_invisible_cursor): Don't return garbage
11173 if XCreateBitmapFromData fails (Bug#8410).
11175 * xselect.c (x_get_local_selection, x_handle_property_notify):
11176 Remove vars that are set but not used.
11178 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
11179 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
11181 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11182 Remove var that is set but not used.
11183 (scroll_bar_windows_size): Now size_t, not int.
11184 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11185 Check for overflow.
11187 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11188 (map_tty_color) [!defined MSDOS]: Likewise.
11190 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11192 * coding.c: Remove vars that are set but not used.
11193 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11194 All callers changed.
11195 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11196 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11197 (decode_coding_charset): Remove vars that are set but not used.
11199 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11200 that is set but not used.
11202 * print.c (print_object): Remove var that is set but not used.
11204 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
11205 The gnulib version avoids calling malloc in the usual case,
11206 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11207 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11208 * filelock.c (current_lock_owner): Likewise.
11209 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11210 * sysdep.c: Include allocator.h, careadlinkat.h.
11211 (emacs_no_realloc_allocator): New static constant.
11212 (emacs_readlink): New function.
11213 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11214 ../lib/careadlinkat.h.
11216 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11218 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11219 first non-nil return value).
11221 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11223 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11224 if not defined (Bug#8403).
11226 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11228 * xdisp.c (display_count_lines): Remove parameter `start',
11229 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11230 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11231 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11232 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11233 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11234 and thereabouts. All callers changed.
11235 (get_per_char_metric): Remove parameter `f', unused since
11236 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11238 2011-04-02 Jim Meyering <meyering@redhat.com>
11240 do not dereference NULL upon failed strdup
11241 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11242 (ns_get_family): Likewise.
11244 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11246 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11248 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11250 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11253 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11255 Add lexical binding.
11257 * window.c (Ftemp_output_buffer_show): New fun.
11258 (Fsave_window_excursion):
11259 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11261 * lread.c (lisp_file_lexically_bound_p): New function.
11262 (Fload): Bind Qlexical_binding.
11263 (readevalloop): Remove `evalfun' arg.
11264 Bind Qinternal_interpreter_environment.
11265 (Feval_buffer): Bind Qlexical_binding.
11266 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11268 (syms_of_lread): Declare `lexical-binding'.
11270 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11272 * keyboard.c (eval_dyn): New fun.
11273 (menu_item_eval_property): Use it.
11275 * image.c (parse_image_spec): Use Ffunctionp.
11277 * fns.c (concat, mapcar1): Accept byte-code-functions.
11279 * eval.c (Fsetq): Handle lexical vars.
11280 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11281 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11282 (FletX, Flet): Obey lexical binding.
11283 (Fcommandp): Handle closures.
11284 (Feval): New `lexical' arg.
11285 (eval_sub): New function extracted from Feval. Use it almost
11286 everywhere where Feval was used. Look up vars in lexical env.
11288 (Ffunctionp): Move from subr.el.
11289 (Ffuncall): Handle closures.
11290 (apply_lambda): Remove `eval_flags'.
11291 (funcall_lambda): Handle closures and new byte-code-functions.
11292 (Fspecial_variable_p): New function.
11293 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11294 but without exporting it to Lisp.
11296 * doc.c (Fdocumentation, store_function_docstring):
11297 * data.c (Finteractive_form): Handle closures.
11299 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11302 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11304 (exec_byte_code): New function extracted from Fbyte_code to handle new
11305 calling convention for byte-code-functions. Add new byte-codes.
11307 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
11309 * alloc.c (Fmake_symbol): Init new `declared_special' field.
11311 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11313 * xdisp.c (redisplay_internal): Fix prototype.
11315 2011-03-31 Eli Zaretskii <eliz@gnu.org>
11317 * xdisp.c (SCROLL_LIMIT): New macro.
11318 (try_scrolling): Use it when setting scroll_limit.
11319 Limit scrolling to 100 screen lines.
11320 (redisplay_window): Even when falling back on "recentering",
11321 position point in the window according to scroll-conservatively,
11322 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11324 (try_scrolling): When point is above the window, allow searching
11325 as far as scroll_max, or one screenful, to compute vertical
11326 distance from PT to the scroll margin position. This prevents
11327 try_scrolling from unnecessarily failing when
11328 scroll-conservatively is set to a value slightly larger than the
11329 window height. Clean up the case of PT below the margin at bottom
11330 of window: scroll_max can no longer be INT_MAX. When aggressive
11331 scrolling is in use, don't let point enter the opposite scroll
11332 margin as result of the scroll.
11333 (syms_of_xdisp) <scroll-conservatively>: Document the
11334 threshold of 100 lines for never-recentering scrolling.
11336 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11338 * dispextern.h (move_it_by_lines):
11339 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11340 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11341 (message_log_check_duplicate): Remove parameters `prev_bol' and
11342 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11343 (redisplay_internal): Remove parameter `preserve_echo_area',
11344 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11346 * indent.c (Fvertical_motion):
11347 * window.c (window_scroll_pixel_based, Frecenter):
11348 Don't pass `need_y_p' to `move_it_by_lines'.
11350 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11352 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11353 steal a few bits to be more compact.
11354 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11355 Remove unneeded casts.
11357 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11359 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11361 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11362 binding" message (bug#7967).
11364 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11366 Fix more problems found by GCC 4.6.0's static checks.
11368 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11369 Remove unused local var.
11371 * editfns.c (Fmessage_box): Remove unused local var.
11373 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11374 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11375 Omit unused local vars.
11376 * window.c (shrink_windows): Omit unused local var.
11377 * menu.c (digest_single_submenu): Omit unused local var.
11378 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11379 Omit unused local var.
11381 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11382 Don't assume string length fits in int.
11383 (keyremap_step, read_key_sequence): Use size_t for sizes.
11384 (read_key_sequence): Don't check last_real_key_start redundantly.
11386 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11387 instead of alloca (Bug#8344).
11389 * eval.c (Fbacktrace): Don't assume nargs fits in int.
11390 (Fbacktrace_frame): Don't assume nframes fits in int.
11392 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11394 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11397 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11399 * cm.c (calccost): Turn while-do into do-while, for clarity.
11401 * keyboard.c (syms_of_keyboard): Use the same style as later
11402 in this function when indexing through an array. This also
11403 works around GCC bug 48267.
11405 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11407 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11409 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11410 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11412 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11413 This avoids undefined behavior on integer overflow, and is a bit
11414 more convenient anyway since it is compared to a size_t variable.
11416 Variadic C functions now count arguments with size_t, not int.
11417 This avoids an unnecessary limitation on 64-bit machines, which
11418 caused (substring ...) to crash on large vectors (Bug#8344).
11419 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11420 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
11421 All variadic functions and their callers changed accordingly.
11422 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11423 * data.c (arith_driver, float_arith_driver): Likewise.
11424 * editfns.c (general_insert_function): Likewise.
11425 * eval.c (struct backtrace.nargs, interactive_p)
11426 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11427 (funcall_lambda, mark_backtrace): Likewise.
11428 * fns.c (concat): Likewise.
11429 * frame.c (x_set_frame_parameters): Likewise.
11430 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11431 0 if not found, not -1. All callers changed.
11433 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11434 (stack_copy_size): Now size_t, not int.
11435 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11437 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11439 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11440 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11441 All callers changed.
11443 * lisp.h (multibyte_char_to_unibyte):
11444 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11445 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11446 * character.h (CHAR_TO_BYTE8):
11447 * cmds.c (internal_self_insert):
11448 * editfns.c (general_insert_function):
11449 * keymap.c (push_key_description):
11450 * search.c (Freplace_match):
11451 * xdisp.c (message_dolog, set_message_1): All callers changed.
11453 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11455 * keyboard.c (safe_run_hook_funcall): New function.
11456 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11457 don't set the hook to nil, but remove the offending function instead.
11458 (Qcommand_hook_internal): Remove, unused.
11459 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11460 Vcommand_hook_internal.
11462 * eval.c (enum run_hooks_condition): Remove.
11463 (funcall_nil, funcall_not): New functions.
11464 (run_hook_with_args): Call each function through a `funcall' argument.
11465 Remove `cond' argument, now redundant.
11466 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11467 (Frun_hook_with_args_until_failure): Adjust accordingly.
11468 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11470 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11472 * dispextern.h (string_buffer_position): Remove declaration.
11474 * print.c (strout): Remove parameter `multibyte', unused since
11475 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11477 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11478 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11479 All callers changed.
11481 * w32.c (_wsa_errlist): Use braces for struct initializers.
11483 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11484 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11485 All callers changed.
11486 (string_buffer_position): Likewise. Also, make static (it's never
11487 used outside xdisp.c).
11488 (cursor_row_p): Remove parameter `w', unused since
11489 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11490 (decode_mode_spec): Remove parameter `precision', introduced during
11491 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11492 All callers changed.
11494 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11496 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11498 2011-03-27 Anders Lindgren <andlind@gmail.com>
11500 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11501 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11502 (ns_update_auto_hide_menu_bar): New functions.
11503 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11504 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11505 ns_constrain_all_frames.
11506 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11507 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11509 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11511 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11513 2011-03-27 Glenn Morris <rgm@gnu.org>
11515 * syssignal.h: Replace RETSIGTYPE with void.
11516 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11517 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11518 Replace SIGTYPE with void everywhere.
11519 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11520 * s/template.h (SIGTYPE): Remove commented out definition.
11522 2011-03-26 Eli Zaretskii <eliz@gnu.org>
11524 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11525 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11527 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
11529 * w32.c (read_unc_volume): Use parameter `henum', instead of
11530 global variable `wget_enum_handle'.
11532 * keymap.c (describe_vector): Remove parameters `indices' and
11533 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11534 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11536 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11538 * keyboard.c (timer_check): Remove parameter `do_it_now',
11539 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11540 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11541 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11543 * keyboard.c (read_char):
11544 * w32menu.c (w32_menu_display_help):
11545 * xmenu.c (show_help_event, menu_help_callback):
11546 Adjust calls to `show_help_echo'.
11548 * gtkutil.c (xg_maybe_add_timer):
11549 * keyboard.c (readable_events):
11550 * process.c (wait_reading_process_output):
11551 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11553 * insdel.c (adjust_markers_gap_motion):
11554 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11555 (gap_left, gap_right): Don't call it.
11557 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
11559 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11560 incurred during fontification.
11562 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
11564 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11565 (DEFVAR_PER_BUFFER): Don't pass it.
11567 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11568 (scrolling_window): Don't pass it.
11570 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
11572 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11574 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11576 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11577 of variables specific to SELinux and computation of `encoded_absname'.
11579 * image.c (XPutPixel): Remove unused variable `height'.
11581 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11583 * unexw32.c (get_section_info): Remove unused variable `section'.
11585 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11586 (system_process_attributes): Remove unused variable `sess'.
11587 (sys_read): Remove unused variable `err'.
11589 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11590 (w32_wnd_proc): Remove unused variable `isdead'.
11591 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11592 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11593 (x_create_tip_frame): Remove unused variable `tem'.
11595 * w32inevt.c (w32_console_read_socket):
11596 Remove unused variable `no_events'.
11598 * w32term.c (x_draw_composite_glyph_string_foreground):
11599 Remove unused variable `width'.
11601 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
11603 * w32term.c (x_set_glyph_string_clipping):
11604 Don't pass uninitialized region to CombineRgn.
11606 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
11608 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11609 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11610 (Fx_close_connection): Remove unused variable `i'.
11612 * w32font.c (w32font_draw): Return number of glyphs.
11613 (w32font_open_internal): Remove unused variable `i'.
11614 (w32font_driver): Add missing initializer.
11616 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11617 (fill_in_menu): Remove unused variable `items_added'.
11619 * w32term.c (last_mouse_press_frame): Remove static global variable.
11620 (w32_clip_to_row): Remove unused variable `f'.
11621 (x_delete_terminal): Remove unused variable `i'.
11623 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11624 (NOTHING): Remove unused static global variable.
11625 (uniscribe_check_otf): Remove unused variable `table'.
11626 (uniscribe_font_driver): Add missing initializers.
11628 2011-03-23 Julien Danjou <julien@danjou.info>
11630 * term.c (Fsuspend_tty, Fresume_tty):
11631 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11632 * window.c (temp_output_buffer_show):
11633 * insdel.c (signal_before_change):
11634 * frame.c (Fhandle_switch_frame):
11635 * fileio.c (Fdo_auto_save):
11636 * emacs.c (Fkill_emacs):
11637 * editfns.c (save_excursion_restore):
11638 * cmds.c (internal_self_insert):
11639 * callint.c (Fcall_interactively):
11640 * buffer.c (Fkill_all_local_variables):
11641 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11643 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
11644 unconditionally since it does the check itself.
11646 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
11648 Fix more problems found by GCC 4.5.2's static checks.
11650 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11651 the first time through the loop, since we know p0 < p1 then.
11652 This also avoids a gcc -Wstrict-overflow warning.
11654 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11655 leading to a memory leak, possible in functions like
11656 load_charset_map_from_file that can allocate an unbounded number
11657 of objects (Bug#8318).
11659 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11660 that could (at least in theory) be that large.
11662 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11663 This is less likely to overflow, and avoids undefined behavior if
11664 overflow does occur. All callers changed. Use strtoul to scan
11665 for the unsigned long integer.
11666 (pint2hrstr): Simplify and tune code slightly.
11667 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
11669 * scroll.c (do_scrolling): Work around GCC bug 48228.
11670 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11672 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11673 This also avoids a warning with gcc -Wstrict-overflow.
11674 (validate_x_resource_name): Simplify count usage.
11675 This also avoids a warning with gcc -Wstrict-overflow.
11677 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11680 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
11682 * process.c (Fmake_network_process): Use socklen_t, not int,
11683 where POSIX says socklen_t is required in portable programs.
11684 This fixes a porting bug on hosts like 64-bit HP-UX, where
11685 socklen_t is wider than int (Bug#8277).
11686 (Fmake_network_process, server_accept_connection):
11687 (wait_reading_process_output, read_process_output):
11690 * process.c: Rename or move locals to avoid shadowing.
11691 (list_processes_1, Fmake_network_process):
11692 (read_process_output_error_handler, exec_sentinel_error_handler):
11693 Rename or move locals.
11694 (Fmake_network_process): Define label "retry_connect" only if needed.
11695 (Fnetwork_interface_info): Fix pointer signedness.
11696 (process_send_signal): Add cast to avoid pointer signedness problem.
11697 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
11698 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
11700 Make tparam.h and terminfo.c consistent.
11701 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11702 Include tparam.h instead, since it declares them.
11703 * cm.h (PC): Remove extern decl; tparam.h now does this.
11704 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11705 * terminfo.c: Include tparam.h, to check interfaces.
11706 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11707 (tparam): Adjust signature to match interface in tparam.h;
11708 this removes some undefined behavior. Check that outstring and len
11709 are zero, which they always are with Emacs.
11710 * tparam.h (PC, BC, UP): New extern decls.
11712 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
11713 (xftfont_open): Rename locals to avoid shadowing.
11715 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
11716 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11717 (OTF_TAG_SYM): Omit macro if not needed.
11718 (ftfont_list): Remove unused local.
11719 (get_adstyle_property, ftfont_pattern_entity):
11720 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11721 Rename locals to avoid shadowing.
11723 * xfont.c (xfont_list_family): Mark var as initialized.
11725 * xml.c (make_dom): Now static.
11727 * composite.c (composition_compute_stop_pos): Rename local to
11729 (composition_reseat_it): Remove unused locals.
11730 (find_automatic_composition, composition_adjust_point): Likewise.
11731 (composition_update_it): Mark var as initialized.
11732 (find_automatic_composition): Mark vars as initialized,
11733 with a FIXME (Bug#8290).
11735 character.h: Rename locals to avoid shadowing.
11736 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11737 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11738 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11739 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11740 to avoid shadowing.
11742 * textprop.c (property_change_between_p): Remove; unused.
11744 * intervals.c (interval_start_pos): Now static.
11746 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11748 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11749 Rename locals to avoid shadowing.
11751 * sound.c (wav_play, au_play, Fplay_sound_internal):
11752 Fix pointer signedness.
11753 (alsa_choose_format): Remove unused local var.
11754 (wav_play): Initialize a variable to 0, to prevent undefined
11755 behavior (Bug#8278).
11757 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11759 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11761 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11762 clobbering (Bug#8298).
11763 * sysdep.c (sys_subshell): Likewise.
11764 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
11766 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11767 This should get cleaned up, so that child_setup has the
11768 same signature on all platforms.
11770 * callproc.c (call_process_cleanup): Now static.
11771 (relocate_fd): Rename locals to avoid shadowing.
11773 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
11775 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11776 not to be necessary, and produces flickering.
11778 2011-03-20 Glenn Morris <rgm@gnu.org>
11780 * config.in: Remove file.
11782 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
11784 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11785 are now in src/globals.h.
11786 (syms_of_minibuf): Remove spurious & from previous change.
11788 2011-03-20 Leo Liu <sdl.web@gmail.com>
11790 * minibuf.c (completing-read-function): New variable.
11791 (completing-read-default): Rename from completing-read.
11792 (completing-read): Call completing-read-function.
11794 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11796 * xfaces.c (Fx_load_color_file):
11797 Read color file from absolute filename (bug#8250).
11799 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11801 * makefile.w32-in: Update dependencies.
11803 2011-03-17 Eli Zaretskii <eliz@gnu.org>
11805 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11807 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11809 Fix more problems found by GCC 4.5.2's static checks.
11811 * process.c (make_serial_process_unwind, send_process_trap):
11812 (sigchld_handler): Now static.
11814 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11815 That way, the code declares only the vars that it needs.
11816 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11817 * s/cygwin.h (PTY_ITERATION): Likewise.
11818 * s/darwin.h (PTY_ITERATION): Likewise.
11819 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11821 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11822 * process.c (allocate_pty): Don't declare stb unless it's needed.
11824 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
11825 (CONSTANTLIM): Remove; unused.
11826 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11827 Define only if needed.
11829 * unexelf.c (unexec): Name an expression,
11830 to avoid gcc -Wbad-function-cast warning.
11831 Use a different way to cause a compilation error if anyone uses
11832 n rather than nn, a way that does not involve shadowing.
11833 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
11835 * deps.mk (unexalpha.o): Remove; unused.
11837 New file unexec.h, the (simple) interface for unexec (Bug#8267).
11838 * unexec.h: New file.
11839 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11840 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11841 Depend on unexec.h.
11842 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11843 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11844 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
11845 Change as necessary to match prototype in unexec.h.
11847 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11849 (back_comment, skip_chars): Mark vars as initialized.
11851 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11852 Rename locals to avoid shadowing.
11854 * lread.c (read1): Rewrite so as not to use empty "else".
11855 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
11857 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11859 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11860 warning when compiling print.c.
11862 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11863 instead of using an uninitialized var.
11864 (font_sort_entities): Mark var as initialized.
11866 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11868 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11869 pointers to constants.
11870 (font_parse_fcname): Remove unused vars.
11871 (font_delete_unmatched): Now static.
11872 (font_get_spec): Remove; unused.
11873 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11874 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11875 Rename or move locals to avoid shadowing.
11877 * fns.c (require_nesting_list, require_unwind): Now static.
11878 (Ffillarray): Rename locals to avoid shadowing.
11880 * floatfns.c (domain_error2): Define only if needed.
11881 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
11883 * alloc.c (mark_backtrace): Move decl from here ...
11884 * lisp.h: ... to here, so that it can be checked.
11886 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
11887 (Fdefvar): Rewrite so as not to use empty "else".
11888 (lisp_indirect_variable): Name an expression,
11889 to avoid gcc -Wbad-function-cast warning.
11890 (Fdefvar): Rename locals to avoid shadowing.
11892 * callint.c (quotify_arg, quotify_args): Now static.
11893 (Fcall_interactively): Rename locals to avoid shadowing.
11894 Use const pointer when appropriate.
11896 * lisp.h (get_system_name, get_operating_system_release):
11897 Move decls here, to check interfaces.
11898 * process.c (get_operating_system_release): Move decl to lisp.h.
11899 * xrdb.c (get_system_name): Likewise.
11900 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11901 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11902 some of which prompt warnings from gcc -Wbad-function-cast.
11903 (Fformat_time_string, Fencode_time, Finsert_char):
11904 (Ftranslate_region_internal, Fformat):
11905 Rename or remove local vars to avoid shadowing.
11906 (Ftranslate_region_internal): Mark var as initialized.
11908 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11911 * lisp.h (eassert): Check that the argument compiles, even if
11912 ENABLE_CHECKING is not defined.
11914 * data.c (Findirect_variable): Name an expression, to avoid
11915 gcc -Wbad-function-cast warning.
11916 (default_value, arithcompare, arith_driver, arith_error): Now static.
11917 (store_symval_forwarding): Rename local to avoid shadowing.
11918 (Fmake_variable_buffer_local, Fmake_local_variable):
11919 Mark variables as initialized.
11920 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
11922 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
11923 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11924 Rename locals to avoid shadowing.
11925 (mark_stack): Move local variables into the #ifdef region where
11927 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11928 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11930 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11931 (GC_STRING_CHARS): Remove; not used.
11932 (Fmemory_limit): Cast sbrk's returned value to char *.
11934 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11935 avoids undefined behavior in theory.
11937 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11939 Use functions, not macros, for up- and down-casing (Bug#8254).
11940 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11941 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11942 to use the following functions instead of these macros.
11943 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11944 EMACS_INT, since callers assume the returned value fits in int.
11945 (upcase1): Likewise, for UPCASE_TABLE.
11946 (uppercasep, lowercasep, upcase): New static inline functions.
11947 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
11948 the race-condition problem in the old DOWNCASE.
11950 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11951 Rename locals to avoid shadowing.
11952 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
11953 (regex_compile, re_search_2, re_match_2_internal):
11954 Remove unused local vars.
11955 (FREE_VAR): Rewrite so as not to use empty "else",
11956 which gcc can warn about.
11957 (regex_compile, re_match_2_internal): Mark locals as initialized.
11958 (RETALLOC_IF): Define only if needed.
11959 (WORDCHAR_P): Likewise. This one is never needed, but is used
11960 only in a comment talking about a compiler bug, so put inside
11961 the #if 0 of that comment.
11962 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11963 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11966 * search.c (boyer_moore): Rename locals to avoid shadowing.
11967 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11968 (PREV_CHAR_BOUNDARY): Likewise.
11970 * search.c (simple_search): Remove unused var.
11972 * dired.c (compile_pattern): Move decl from here ...
11973 * lisp.h: ... to here, so that it can be checked.
11974 (struct re_registers): New forward decl.
11976 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11978 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11980 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11981 Rename locals to avoid shadowing.
11982 (Fvertical_motion): Mark locals as initialized.
11984 * casefiddle.c (casify_object, casify_region): Now static.
11985 (casify_region): Mark local as initialized.
11987 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11989 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11990 New macros, so that the caller can use some names other than
11991 gcpro1, gcpro2, etc.
11992 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11994 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11995 argument, for consistency with GCPRO2_VAR, etc: it is now the
11996 prefix of the variable, not the variable itself. All uses
11998 * dired.c (directory_files_internal, file_name_completion):
11999 Rename locals to avoid shadowing.
12001 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12002 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12003 dired.c's scmp function, had undefined behavior.
12004 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12005 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12006 * buffer.h: ... to here, because these macros use current_buffer,
12007 and the new implementation with inline functions needs to have
12008 current_buffer in scope now, rather than later when the macros
12010 (downcase, upcase1): New static inline functions.
12011 (DOWNCASE, UPCASE1): Reimplement using these functions.
12012 This avoids undefined behavior in expressions like
12013 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12014 from race conditions in accessing the global variables
12015 case_temp1 and case_temp2.
12016 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12017 * lisp.h (case_temp1, case_temp2): Remove their decls.
12018 * character.h (ASCII_CHAR_P): Move from here ...
12019 * lisp.h: ... to here, so that the inline functions mentioned
12020 above can use them.
12022 * dired.c (directory_files_internal_unwind): Now static.
12024 * fileio.c (file_name_as_directory, directory_file_name):
12025 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12027 (file_name_as_directory): Use const pointers when appropriate.
12028 (Fexpand_file_name): Likewise. In particular, newdir might
12029 point at constant storage, so make it a const pointer.
12030 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
12031 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12033 (Fset_file_times, Finsert_file_contents, auto_save_error):
12034 Rename locals to avoid shadowing.
12036 * minibuf.c (choose_minibuf_frame_1): Now static.
12037 (Ftry_completion, Fall_completions): Rename or remove locals
12038 to avoid shadowing.
12040 * marker.c (bytepos_to_charpos): Remove; unused.
12042 * lisp.h (verify_bytepos, count_markers): New decls,
12043 so that gcc does not warn that these functions aren't declared.
12045 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12046 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
12047 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
12048 (copy_text): Remove unused local var.
12050 * filelock.c (within_one_second): Now static.
12051 (lock_file_1): Rename local to avoid shadowing.
12053 * buffer.c (fix_overlays_before): Mark locals as initialized.
12054 (fix_start_end_in_overlays): Likewise. This function should be
12055 simplified by using pointers-to-pointers, but that's a different
12057 (switch_to_buffer_1): Now static.
12058 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12059 (report_overlay_modification): Rename locals to avoid shadowing.
12061 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
12062 Fix pointer signedness issue.
12063 (sys_subshell): Mark local as volatile if checking for lint,
12064 to suppress a gcc -Wclobbered warning that does not seem to be right.
12065 (MAXPATHLEN): Define only if needed.
12067 * process.c (serial_open, serial_configure): Move decls from here ...
12068 * systty.h: ... to here, so that they can be checked.
12070 * fns.c (get_random, seed_random): Move extern decls from here ...
12071 * lisp.h: ... to here, so that they can be checked.
12073 * sysdep.c (reset_io): Now static.
12074 (wait_for_termination_signal): Remove; unused.
12076 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12077 (copy_keymap_item, append_key, push_text_char_description):
12079 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
12080 (DENSE_TABLE_SIZE): Remove; unused.
12081 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12082 (describe_map_tree):
12083 Rename locals to avoid shadowing.
12085 * keyboard.c: Declare functions static if they are not used elsewhere.
12086 (echo_char, echo_dash, cmd_error, top_level_2):
12087 (poll_for_input, handle_async_input): Now static.
12088 (read_char, kbd_buffer_get_event, make_lispy_position):
12089 (make_lispy_event, make_lispy_movement, apply_modifiers):
12090 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12091 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12092 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
12093 (read_key_sequence, read_char): Mark locals as initialized.
12094 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
12096 * keyboard.h (make_ctrl_char): New decl.
12097 (mark_kboards): Move decl here ...
12098 * alloc.c (mark_kboards): ... from here.
12100 * lisp.h (force_auto_save_soon): New decl.
12102 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
12103 (DEFINE_DUMMY_FUNCTION): New macro.
12104 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12106 (main): Add casts to avoid warnings
12107 if GCC considers string literals to be constants.
12109 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12111 * dbusbind.c: Pointer signedness fixes.
12112 (xd_signature, xd_append_arg, xd_initialize):
12113 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12114 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12115 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12116 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12118 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12119 if GCC considers string literals to be constants.
12120 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
12122 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12124 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12125 (print_preprocess, print_object): New macro to fix last change.
12127 * print.c (print_preprocess): Don't forget font objects.
12129 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
12131 * emacs.c (USAGE3): Doc fixes.
12133 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12135 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12138 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
12140 * lisp.h (VWindow_system, Qfile_name_history):
12141 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12142 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12143 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12145 * w32select.c: Don't #include "keyboard.h".
12146 (run_protected): Add extern declaration for waiting_for_input.
12148 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12149 * w32console.c (detect_input_pending, read_input_pending)
12150 (encode_terminal_code):
12151 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12152 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12153 (w32_system_caret_y, Qfile_name_history):
12154 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12155 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12156 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12157 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12158 * w32proc.c (Qlocal, report_file_error):
12159 * w32term.c (Vwindow_system, updating_frame):
12160 * w32uniscribe.c (initialized, uniscribe_font_driver):
12161 Remove unneeded extern declarations.
12163 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
12165 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
12167 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
12169 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12170 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12171 These macros can no longer be used for assignment.
12173 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12174 Assign struct members directly, instead of using BUF_BEGV etc.
12175 (record_buffer_markers, fetch_buffer_markers): New functions for
12176 recording and fetching special buffer markers.
12177 (set_buffer_internal_1, set_buffer_temp): Use them.
12179 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12181 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12183 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12184 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12186 * xdisp.c (hscroll_window_tree):
12187 (reconsider_clip_changes): Use PT instead of BUF_PT.
12189 2011-03-13 Eli Zaretskii <eliz@gnu.org>
12191 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12192 $(EMACS_ROOT)/lib/intprops.h.
12194 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12196 Fix more problems found by GCC 4.5.2's static checks.
12198 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12199 to unsigned char * to avoid compiler diagnostic.
12200 (xg_free_frame_widgets): Make it clear that a local variable is
12201 needed only if USE_GTK_TOOLTIP.
12202 (gdk_window_get_screen): Make it clear that this macro is needed
12203 only if USE_GTK_TOOLTIP.
12204 (int_gtk_range_get_value): New function, which avoids a diagnostic
12205 from gcc -Wbad-function-cast.
12206 (xg_set_toolkit_scroll_bar_thumb): Use it.
12207 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12208 diagnostic from gcc -Wbad-function-cast.
12209 (get_utf8_string, xg_get_file_with_chooser):
12210 Rename locals to avoid shadowing.
12211 (create_dialog): Move locals to avoid shadowing.
12213 * xgselect.c (xg_select): Remove unused var.
12215 * image.c (four_corners_best): Mark locals as initialized.
12216 (gif_load): Initialize transparent_p to zero (Bug#8238).
12217 Mark another local as initialized.
12218 (my_png_error, my_error_exit): Mark with NO_RETURN.
12220 * image.c (clear_image_cache): Now static.
12221 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
12222 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
12223 (x_edge_detection): Remove unnecessary cast that
12224 gcc -Wbad-function-cast diagnoses.
12225 (gif_load): Fix pointer signedness.
12226 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12227 (jpeg_load, gif_load): Rename locals to avoid shadowing.
12229 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
12231 Improve quality of tests for time stamp overflow.
12232 For example, without this patch (encode-time 0 0 0 1 1
12233 1152921504606846976) returns the obviously-bogus value (-948597
12234 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12235 reports time overflow. See
12236 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
12237 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12238 * editfns.c: Include limits.h and intprops.h.
12239 (TIME_T_MIN, TIME_T_MAX): New macros.
12240 (time_overflow): Move earlier, to before first use.
12241 (hi_time, lo_time): New functions, for an accurate test for
12242 out-of-range times.
12243 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12244 (Fget_internal_run_time): Don't assume time_t fits in int.
12245 (make_time): Use list2 instead of Fcons twice.
12246 (Fdecode_time): More accurate test for out-of-range times.
12247 (check_tm_member): New function.
12248 (Fencode_time): Use it, to test for out-of-range times.
12249 (lisp_time_argument): Don't rely on undefined left-shift and
12250 right-shift behavior when checking for time stamp overflow.
12252 * editfns.c (time_overflow): New function, refactoring common code.
12253 (Fformat_time_string, Fdecode_time, Fencode_time):
12254 (Fcurrent_time_string): Use it.
12256 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12257 * dired.c (make_time): Move to ...
12258 * editfns.c (make_time): ... here.
12259 * systime.h: Note the move.
12261 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12263 * fringe.c (update_window_fringes): Remove unused variables.
12265 * unexmacosx.c (copy_data_segment): Also copy __got section.
12268 2011-03-12 Eli Zaretskii <eliz@gnu.org>
12270 * termcap.c [MSDOS]: Include "msdos.h".
12271 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12272 Constify `char *' arguments and their references according to
12273 prototypes in tparam.h.
12275 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
12277 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12278 Adapt all references accordingly.
12280 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12282 2011-03-11 Tom Tromey <tromey@redhat.com>
12284 * buffer.c (syms_of_buffer): Remove obsolete comment.
12286 2011-03-11 Eli Zaretskii <eliz@gnu.org>
12288 * termhooks.h (encode_terminal_code): Declare prototype.
12290 * msdos.c (encode_terminal_code): Don't declare prototype.
12292 * term.c (encode_terminal_code): Now external again, used by
12293 w32console.c and msdos.c.
12295 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12296 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
12298 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
12300 Fix some minor problems found by GCC 4.5.2's static checks.
12302 * fringe.c (update_window_fringes): Mark locals as initialized
12304 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
12306 * alloc.c (mark_fringe_data): Move decl from here ...
12307 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12308 to check its interface.
12309 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12311 * fontset.c (free_realized_fontset): Now static.
12312 (Fset_fontset_font): Rename local to avoid shadowing.
12313 (fontset_font): Mark local as initialized.
12314 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
12316 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12318 * xselect.c (x_disown_buffer_selections): Remove; not used.
12319 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
12320 (x_own_selection, Fx_disown_selection_internal): Rename locals
12321 to avoid shadowing.
12322 (x_handle_dnd_message): Remove local to avoid shadowing.
12324 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12325 so that the caller can use some name other than gcpro1.
12326 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
12327 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12328 (Fx_backspace_delete_keys_p):
12329 Use them to avoid shadowing, and rename vars to avoid shadowing.
12330 (x_decode_color, x_set_name, x_window): Now static.
12331 (Fx_create_frame): Add braces to silence GCC warning.
12332 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
12333 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12334 Remove unused locals.
12335 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12336 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12337 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12340 * xterm.h (x_mouse_leave): New decl.
12342 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12343 Remove unused functions.
12344 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12345 (x_calc_absolute_position): Now static.
12346 (XTread_socket): Don't define label "out" unless it's used.
12347 Don't declare local "event" unless it's used.
12348 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12349 unless they are used.
12350 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12351 (x_fatal_error_signal): Remove; not used.
12352 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12353 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12354 (x_error_catcher, x_connection_closed, x_error_handler):
12355 (x_error_quitter, xembed_send_message, x_iconify_frame):
12356 (my_log_handler): Rename locals to avoid shadowing.
12357 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
12358 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
12360 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12361 Rename or move locals to avoid shadowing.
12362 (tty_defined_color, merge_face_heights): Now static.
12363 (free_realized_faces_for_fontset): Remove; not used.
12364 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12365 does not deduce is never used uninitialized.
12366 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12367 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
12369 * terminal.c (store_terminal_param): Now static.
12371 * xmenu.c (menu_highlight_callback): Now static.
12372 (set_frame_menubar): Remove unused local.
12373 (xmenu_show): Rename parameter to avoid shadowing.
12374 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12375 since they might point to immutable storage.
12376 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12377 since it's unused otherwise.
12379 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
12380 Add a FIXME, since the code still doesn't look right. (Bug#8215)
12381 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12382 avoids a gcc -Wuninitialized diagnostic.
12383 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
12384 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12385 does not deduce are never used uninitialized.
12387 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12389 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
12390 * window.c (window_loop, size_window):
12391 (run_window_configuration_change_hook, enlarge_window): Likewise.
12393 * window.c (display_buffer): Now static.
12394 (size_window): Mark variables that gcc -Wuninitialized
12395 does not deduce are never used uninitialized.
12396 * window.h (check_all_windows): New decl, to forestall
12397 gcc -Wmissing-prototypes diagnostic.
12398 * dispextern.h (bidi_dump_cached_states): Likewise.
12400 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12402 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
12403 Include <limits.h>.
12404 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12405 and to avoid gcc -Wuninitialized warning.
12406 (load_charset_map): Mark variables that gcc -Wuninitialized
12407 does not deduce are never used uninitialized.
12408 (load_charset): Abort instead of using uninitialized var (Bug#8229).
12410 * coding.c (coding_set_source, coding_set_destination):
12411 Use "else { /* comment */ }" rather than "else /* comment */;"
12412 for clarity, and to avoid gcc -Wempty-body warning.
12413 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12414 a block, when the outer 'i' will do.
12415 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12416 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12417 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12418 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12419 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12420 Rename locals to avoid shadowing.
12421 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
12422 * coding.c (emacs_mule_char, encode_invocation_designation):
12423 Now static, since they're not used elsewhere.
12424 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
12425 (decode_coding_object, encode_coding_object, detect_coding_system):
12426 (decode_coding_emacs_mule): Mark variables that gcc
12427 -Wuninitialized does not deduce are never used uninitialized.
12428 (detect_coding_iso_2022): Initialize a local variable that might
12429 be used uninitialized. Leave a FIXME because it's not clear that
12430 this initialization is needed. (Bug#8211)
12431 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12432 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12433 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12434 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12435 Remove unused macros.
12437 * category.c (hash_get_category_set): Remove unused local var.
12438 (copy_category_table): Now static, since it's not used elsewhere.
12439 * character.c (string_count_byte8): Likewise.
12441 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12442 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12444 * chartab.c (copy_sub_char_table): Now static, since it's not used
12446 (sub_char_table_ref_and_range, char_table_ref_and_range):
12447 Rename locals to avoid shadowing.
12448 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
12450 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
12451 (BIDI_BOB): Remove unused macro.
12453 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12454 deduce are never used uninitialized.
12455 * term.c (encode_terminal_code): Likewise.
12457 * term.c (encode_terminal_code): Now static. Remove unused local.
12459 * tparam.h: New file.
12460 * term.c, tparam.h: Include it.
12461 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12462 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12463 Move these decls to tparam.h, and make them agree with what
12464 is actually in tparam.c. The previous trick of using incompatible
12465 decls in different modules does not conform to the C standard.
12466 All callers of tparam changed to use tparam's actual API.
12467 * tparam.c (tparam1, tparam, tgoto):
12468 Use const pointers where appropriate.
12470 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12471 * cm.h (struct cm): Likewise.
12472 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12473 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12474 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12475 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12476 (turn_on_face, init_tty): Likewise.
12477 * termchar.h (struct tty_display_info): Likewise.
12479 * term.c (term_mouse_position): Rename local to avoid shadowing.
12481 * alloc.c (mark_ttys): Move decl from here ...
12482 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12484 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12486 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12488 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
12490 * search.c (compile_pattern_1): Remove argument regp, unused since
12491 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12492 (compile_pattern): Don't pass it.
12494 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12496 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12497 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12499 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12501 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12503 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12504 gdk_window_get_screen, gdk_window_get_geometry,
12505 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12506 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12507 (xg_get_pixbuf_from_pixmap): New function.
12508 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12509 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12510 Call xg_get_pixbuf_from_pixmap instead of
12511 gdk_pixbuf_get_from_drawable.
12512 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12513 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12514 (xg_check_special_colors): Use GtkStyleContext and its functions
12516 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12517 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12518 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
12519 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12520 Call gtk_widget_get_preferred_size.
12521 (xg_frame_resized): gdk_window_get_geometry only takes 5
12523 (xg_win_to_widget, xg_event_is_for_menubar):
12524 Call gdk_x11_window_lookup_for_display.
12525 (xg_set_widget_bg): New function.
12526 (delete_cb): New function.
12527 (xg_create_frame_widgets): Connect delete-event to delete_cb.
12528 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
12529 (xg_set_background_color): Call xg_set_widget_bg.
12530 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12531 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12532 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12533 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12535 (update_frame_tool_bar): Call gtk_widget_hide.
12536 (xg_initialize): Use GDK_KEY_g.
12538 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12540 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12542 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12543 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12544 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12546 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
12548 * w32xfns.c (select_palette): Check success of RealizePalette against
12549 GDI_ERROR, not zero.
12551 See ChangeLog.11 for earlier changes.
12553 ;; Local Variables:
12557 Copyright (C) 2011-2012 Free Software Foundation, Inc.
12559 This file is part of GNU Emacs.
12561 GNU Emacs is free software: you can redistribute it and/or modify
12562 it under the terms of the GNU General Public License as published by
12563 the Free Software Foundation, either version 3 of the License, or
12564 (at your option) any later version.
12566 GNU Emacs is distributed in the hope that it will be useful,
12567 but WITHOUT ANY WARRANTY; without even the implied warranty of
12568 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12569 GNU General Public License for more details.
12571 You should have received a copy of the GNU General Public License
12572 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.