1 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
3 * print.c: Integer overflow fix.
4 (print_object): Use ptrdiff_t, not int, for index that can
7 * indent.c: Integer overflow fixes.
8 (position_indentation): Now takes ptrdiff_t, not int.
9 (Fvertical_motion): Don't wrap around LINES values that don't fit
10 in 'int'. Instead, treat them as extreme values. This is good
11 enough for windows, which can't have more than INT_MAX lines anyway.
13 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
15 * Require libxml/parser.h to avoid compilation warning.
17 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
19 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
20 since this reportedly can destroy thread storage.
22 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
24 * syntax.c (find_defun_start): Update all cache variables if
25 exiting early (Bug#9401).
27 2011-08-30 Eli Zaretskii <eliz@gnu.org>
29 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
31 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
32 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
33 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
35 * term.c (tty_append_glyph): New function.
36 (produce_stretch_glyph): Static function and its prototype deleted.
38 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
41 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
43 * image.c (parse_image_spec): Check for nonnegative, not for positive,
44 when checking :margin (Bug#9390).
45 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
46 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
47 so that the name doesn't mislead. All uses changed.
49 2011-08-28 Johan Bockgård <bojohan@gnu.org>
51 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
54 2011-08-27 Eli Zaretskii <eliz@gnu.org>
56 * xdisp.c (move_it_to): Don't bail out early when reaching
57 position beyond to_charpos, if we are scanning backwards.
58 (move_it_vertically_backward): When DY == 0, make sure we get to
59 the first character in the line after the newline.
61 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
63 * ccl.c: Improve and simplify overflow checking (Bug#9196).
64 (ccl_driver): Do not generate an out-of-range pointer.
65 (Fccl_execute_on_string): Remove unnecessary check for
66 integer overflow, noted by Stefan Monnier in
67 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
68 Remove a FIXME that didn't need fixing.
69 Simplify the newly-introduced buffer reallocation code.
71 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
73 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
75 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
77 Integer and memory overflow issues (Bug#9196).
79 * doc.c (get_doc_string): Rework so that
80 get_doc_string_buffer_size is the actual buffer size, rather than
81 being 1 less than the actual buffer size; this makes xpalloc more
84 * image.c (x_allocate_bitmap_record, cache_image):
85 * xselect.c (Fx_register_dnd_atom):
86 Simplify previous changes by using xpalloc.
88 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
89 since either will do and ptrdiff_t is convenient with xpalloc.
91 * charset.c (charset_table_size)
92 (struct charset_sort_data.priority): Now ptrdiff_t.
93 (charset_compare): Don't overflow if priorities differ greatly.
94 (Fsort_charsets): Don't assume list length fits in int.
95 Check for size-calculation overflow when allocating sort data.
96 (syms_of_charset): Allocate an initial charset table that is
97 just under 64 KiB, to avoid problems with glibc malloc and mmap.
99 * cmds.c (internal_self_insert): Check for size-calculation overflow.
101 * composite.h (struct composition.glyph_len): Now int, not unsigned.
102 The actual value is always <= INT_MAX, and leaving it unsigned made
103 overflow checking harder.
105 * dispextern.h (struct glyph_matrix.rows_allocated)
106 (struct face_cache.size): Now ptrdiff_t, for convenience in use
107 with xpalloc. The values are still always <= INT_MAX.
109 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
111 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
112 (SAFE_NALLOCA): New macro.
114 * region-cache.c (struct boundary.pos, find_cache_boundary)
115 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
116 (set_cache_region, invalidate_region_cache)
117 (revalidate_region_cache, know_region_cache, region_cache_forward)
118 (region_cache_backward, pp_cache):
119 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
120 so that ptrdiff_t * can be passed to xpalloc.
121 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
122 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
123 (pp_cache): Don't assume cache_len fits in int.
124 * region-cache.h: Adjust extern decls to match.
126 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
127 EMACS_INT, since either will do, for xpalloc.
129 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
130 (xnmalloc, xnrealloc, xpalloc): New functions.
132 * bidi.c (bidi_shelve_header_size): New constant.
133 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
134 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
136 * bidi.c (bidi_cache_shrink):
137 * buffer.c (overlays_at, overlays_in, record_overlay_string)
139 Don't update size of array until after memory allocation succeeds,
140 because xmalloc/xrealloc may not return.
141 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
142 now that we have proper integer overflow checking.
143 (record_overlay_string, overlay_strings): Catch overflows when
144 calculating size of overlay_str_buf.
146 * callproc.c (Fcall_process): Check for size overflow when
147 calculating size of args2.
148 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
149 Normally we prefer signed values, but sticking with ptrdiff_t would
150 require adding more-complicated checks.
152 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
153 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
154 Redo buffer-overflow calculations to avoid integer overflow.
155 Add a FIXME comment where memory seems to be over-allocated.
157 * character.c (Fstring): Check for size-calculation overflow.
159 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
160 unnecessary integer overflow. Check for size overflow.
161 (encode_coding_object): Don't update size until xmalloc succeeds.
163 * composite.c (get_composition_id): Check for overflow in glyph
166 Integer and memory overflow fixes for display code.
167 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
168 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
169 (scrolling_window): Check for overflow in size calculations.
170 (line_draw_cost, realloc_glyph_pool, add_row_entry):
171 Don't assume glyph table len fits in int.
172 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
173 (row_table_size): Now ptrdiff_t, not int.
174 (scrolling_window): Avoid overflow in size calculations.
175 Don't update size until allocation succeeds.
176 * fns.c (concat): Check for overflow in size calculations.
177 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
178 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
179 (NEXT_ALMOST_PRIME_LIMIT): New constant.
181 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
182 (get_doc_string): Check for size calculation overflow.
183 Don't update size until allocation succeeds.
184 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
185 EMACS_INT, where ptrdiff_t will do.
186 (Fsubstitute_command_keys): Check for string overflow.
188 * editfns.c (set_time_zone_rule): Don't assume environment length
190 (message_length): Now ptrdiff_t, not int.
191 (Fmessage_box): Don't update size until allocation succeeds.
192 Don't assume message length fits in int.
193 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
195 * emacs.c (main): Do not reallocate argv, since there is a null at
196 the end that can be overwritten, and this way there's no need to
197 worry about size-calculation overflow.
198 (sort_args): Check for size-calculation overflow.
200 * eval.c (init_eval_once, grow_specpdl): Don't update size until
202 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
204 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
205 (x_set_scroll_bar_width, x_figure_window_size):
206 Check for integer overflow.
207 (x_set_alpha): Do not assume XINT fits in int.
209 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
210 This is for the members text_lines, text_cols, total_lines, total_cols,
211 where the system imposes an 'int' limit.
213 * fringe.c (Fdefine_fringe_bitmap):
214 Don't update size until alloc works.
216 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
217 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
219 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
220 Check for size-calculation overflow.
221 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
222 do, as we prefer signed integers.
223 (id_to_widget.max_size, id_to_widget.used)
224 (xg_store_widget_in_map, xg_remove_widget_from_map)
225 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
226 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
227 Use and return ptrdiff_t, not int.
228 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
229 * gtkutil.h: Change prototypes to match the above.
231 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
232 are duplicate now that they've been promoted to lisp.h.
233 (x_allocate_bitmap_record, x_alloc_image_color)
234 (make_image_cache, cache_image, xpm_load):
235 Don't update size until alloc is done.
236 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
238 Check for size calculation overflow.
239 (ct_colors_allocated_max): New constant.
240 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
243 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
244 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
245 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
246 Use ptrdiff_t, not int, to count maps.
247 (read_char_minibuf_menu_prompt): Check for overflow in size
248 calculations. Don't update size until allocation succeeds. Redo
249 calculations to avoid overflow.
250 * keyboard.h: Change prototypes to match the above.
252 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
254 (current_minor_maps): Check for size calculation overflow.
255 * keymap.h: Change prototypes to match the above.
257 * lread.c (read1, init_obarray): Don't update size until alloc done.
259 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
260 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
262 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
263 Now ptrdiff_t, not int.
264 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
265 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
267 * process.c (Fnetwork_interface_list): Check for overflow
270 * region-cache.c (move_cache_gap): Check for size calculation overflow.
272 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
273 overflow. Don't bother calling xmalloc when xrealloc will do.
275 * search.c (Freplace_match): Check for size calculation overflow.
276 (Fset_match_data): Don't assume list lengths fit in 'int'.
278 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
279 for command line length. Do not attempt to address one before the
280 beginning of an array, as that's not portable.
282 * term.c (max_frame_lines): Remove; unused.
283 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
285 (encode_terminal_code, calculate_costs): Check for size
286 calculation overflow.
287 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
288 table lengths and related sizes. Don't update size until alloc
289 done. Redo calculations to avoid overflow.
290 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
292 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
293 subtracting pointers.
294 (gobble_line): Check for overflow more carefully. Don't update size
297 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
298 Don't update size until alloc done.
299 Redo size calculations to avoid overflow.
300 Check for size calculation overflow.
301 (main) [DEBUG]: Fix typo in invoking tparam1.
303 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
304 Use ptrdiff_t, not int, for sizes.
305 (store_mode_line_noprop_char): Don't update size until alloc done.
307 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
308 Use ptrdiff_t, not int, for sizes.
309 (Finternal_make_lisp_face, cache_face):
310 Check for size calculation overflow.
311 (cache_face): Treat size calculation overflows as if they were
312 memory exhaustion (the usual treatment), rather than aborting.
314 * xfns.c (x_encode_text, x_set_name_internal)
315 (Fx_change_window_property): Use ptrdiff_t, not int, to count
316 sizes, since they can exceed INT_MAX in size. Check for size
317 calculation overflow.
319 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
320 (xg_select): Check for size calculation overflow.
321 Don't update size until alloc done.
323 * xrdb.c (get_environ_db): Don't assume path length fits in int,
324 as sprintf is limited to int lengths.
326 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
327 (X_LONG_MIN): New macros.
328 Use them to make the following changes clearer.
329 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
330 This change doesn't affect the value now, but it may help remind
331 future maintainers not to raise the value too much later.
332 (SELECTION_QUANTUM): Remove, replacing with ...
333 (selection_quantum): ... new function, which avoids overflow.
335 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
336 assumption that selection length fits in 'int'.
337 (x_reply_selection_request, x_handle_selection_request)
338 (x_get_window_property, receive_incremental_selection)
339 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
340 (lisp_data_to_selection_data, clean_local_selection_data):
341 Use ptrdiff_t, not int, to record length of selection.
342 (x_reply_selection_request, x_get_window_property)
343 (receive_incremental_selection, x_property_data_to_lisp):
344 Redo calculations to avoid overflow.
345 (x_reply_selection_request): When sending hint, ceiling it at
346 X_LONG_MAX rather than relying on wraparound overflow to send
348 (x_get_window_property, receive_incremental_selection)
349 (lisp_data_to_selection_data, x_property_data_to_lisp):
350 Check for size-calculation overflow.
351 (x_get_window_property, receive_incremental_selection)
352 (lisp_data_to_selection_data, Fx_register_dnd_atom):
353 Don't store size until memory allocation succeeds.
354 (x_get_window_property): Plug memory leak on memory exhaustion.
355 Don't double-block input; malloc is safe here. Don't assume 2**34
356 - 4 fits in unsigned long. Add an xassert to check
357 XGetWindowProperty overflow. Be more careful about overflow
358 calculations, and distinguish size from memory overflow better.
359 (receive_incremental_selection): When tracing, don't assume
360 unsigned int is less than INT_MAX.
361 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
362 harmful) conversions of unsigned short to int.
363 (lisp_data_to_selection_data): Don't assume that integers
364 in the range -65535 through -1 fit in an X unsigned short.
365 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
366 result parameters unless successful. Rely on cons_to_unsigned
367 to report problems with elements; the old code wasn't right anyway.
368 (x_check_property_data): Check for int overflow; we cannot use
369 a wider type due to X limits.
370 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
372 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
374 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
375 (x_term_init): Check for size calculation overflow.
376 (x_color_cells): Don't store size until memory allocation succeeds.
377 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
378 Don't assume alloca size is less than MAX_ALLOCA.
379 (x_term_init): Don't assume length fits in int (sprintf is limited
382 Use ptrdiff_t for composition IDs.
383 * character.c (lisp_string_width):
384 * composite.c (composition_table_size, n_compositions)
385 (get_composition_id, composition_gstring_from_id):
386 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
387 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
388 * window.c (Frecenter):
389 Use ptrdiff_t, not int, for composition IDs.
390 * composite.c (get_composition_id): Check for integer overflow.
391 * composite.h: Adjust prototypes to match the above changes.
393 Use ptrdiff_t for hash table indexes.
394 * category.c (hash_get_category_set):
395 * ccl.c (ccl_driver):
396 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
397 * coding.c (coding_system_charset_list, detect_coding_system):
398 * coding.h (struct coding_system.id):
399 * composite.c (get_composition_id, gstring_lookup_cache):
400 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
401 * image.c (xpm_get_color_table_h):
402 * lisp.h (hash_lookup, hash_put):
403 * minibuf.c (Ftest_completion):
404 Use ptrdiff_t for hash table indexes, not int (which is too
405 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
406 32-bit --with-wide-int hosts).
408 * charset.c (Fdefine_charset_internal): Check for integer overflow.
409 Add a FIXME comment about memory leaks.
410 (syms_of_charset): Don't assume xmalloc returns.
412 Don't assume that stated character widths fit in int.
413 * character.c (Fchar_width, c_string_width, lisp_string_width):
414 * character.h (CHAR_WIDTH):
415 * indent.c (MULTIBYTE_BYTES_WIDTH):
416 Use sanitize_char_width to avoid undefined and/or bad behavior
417 with outlandish widths.
418 * character.h (sanitize_tab_width): Renamed from sanitize_width,
419 now that we have two such functions. All uses changed.
420 (sanitize_char_width): New inline function.
422 Don't assume that tab-width fits in int.
423 * character.h (sanitize_width): New inline function.
424 (SANE_TAB_WIDTH): New macro.
425 (ASCII_CHAR_WIDTH): Use it.
426 * indent.c (sane_tab_width): Remove. All uses replaced by
427 SANE_TAB_WIDTH (current_buffer).
428 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
430 * fileio.c: Integer overflow issues with file modes.
431 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
433 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
434 Remove unreachable code.
435 (read_hex, load_charset_map_from_file): Check for integer overflow.
437 * xterm.c: don't go over XClientMessageEvent limit
438 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
439 (x_send_scroll_bar_event): Likewise. Check that the size does not
440 exceed limits imposed by XClientMessageEvent, as well as the usual
441 ptrdiff_t and size_t limits.
443 * keyboard.c: Overflow, signedness and related fixes.
444 (make_lispy_movement): Use same integer type in forward decl
445 that is used in the definition.
446 (read_key_sequence, keyremap_step):
447 Change bufsize argument back to int, undoing my 2011-03-30 change.
448 We prefer signed types, and int is wide enough here.
449 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
450 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
451 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
452 length, not size_t. Use ptrdiff_t for index, not int.
453 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
454 possibility of integer overflow.
456 Overflow, signedness and related fixes for images.
458 * dispextern.h (struct it.stack[0].u.image.image_id)
459 (struct_it.image_id, struct image.id, struct image_cache.size)
460 (struct image_cache.used, struct image_cache.ref_count):
461 * gtkutil.c (update_frame_tool_bar):
462 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
463 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
464 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
465 * nsmenu.m (update_frame_tool_bar):
466 * xdisp.c (calc_pixel_width_or_height):
467 * xfns.c (image_cache_refcount):
468 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
469 on typical 64-bit hosts.
471 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
472 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
473 Omit unnecessary casts to int.
474 (parse_image_spec): Check that integers fall into 'int' range
475 when the callers expect that.
476 (image_ascent): Redo ascent calculation to avoid int overflow.
477 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
478 (lookup_image): Remove unnecessary tests.
479 (xbm_image_p): Locals are now of int, not EMACS_INT,
480 since parse_image_check makes sure they fit into int.
481 (png_load, gif_load, svg_load_image):
482 Prefer int to unsigned where either will do.
483 (tiff_handler): New function, combining the cores of the
484 old tiff_error_handler and tiff_warning_handler. This
485 function is rewritten to use vsnprintf and thereby avoid
486 stack buffer overflows. It uses only the features of vsnprintf
487 that are common to both POSIX and native Microsoft.
488 (tiff_error_handler, tiff_warning_handler): Use it.
489 (tiff_load, gif_load, imagemagick_load_image):
490 Don't assume :index value fits in 'int'.
491 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
492 (imagemagick_load_image): Check that crop parameters fit into
493 the integer types that MagickCropImage accepts. Don't assume
494 Vimagemagick_render_type has a nonnegative value. Don't assume
495 size_t fits in 'long'.
496 (gs_load): Use printmax_t to print the widest integers possible.
497 Check for integer overflow when computing image height and width.
499 2011-08-26 Eli Zaretskii <eliz@gnu.org>
501 * xdisp.c (redisplay_window): Don't force window start if point
502 will be invisible in the resulting window. (Bug#9324)
504 2011-08-25 Eli Zaretskii <eliz@gnu.org>
506 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
507 the display spec is of the form `(space ...)'.
508 (handle_display_spec): Return the value returned by
509 handle_single_display_spec, not just 1 or zero.
510 (handle_single_display_spec): If the display spec is of the form
511 `(space ...)', and specifies display in the text area, return 2
513 (try_cursor_movement): Check for the need to scroll more
514 accurately, and prefer exact match for point under bidi. Don't
515 advance `row' beyond the last row of the window.
517 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
518 into disp_prop; all users changed.
520 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
521 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
522 for the text covered by the display property.
524 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
526 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
527 Change return value to nil.
528 (Frecord_buffer): Delete unused function.
530 2011-08-24 Eli Zaretskii <eliz@gnu.org>
532 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
533 buffers, return left-to-right.
534 (set_cursor_from_row): Consider candidate row a win if its glyph
535 represents a newline and point is on that newline. Fixes cursor
536 positioning on the newline at EOL of R2L text within L2R
537 paragraph, and vice versa.
538 (try_cursor_movement): Check continued rows, in addition to
539 continuation rows. Fixes unwarranted scroll when point enters a
540 continued line of R2L text within an L2R paragraph, or vice versa.
541 (cursor_row_p): Consider the case of point being equal to
542 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
543 from the end of a short line to the beginning of a continued line
544 of R2L text within L2R paragraph.
545 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
548 * bidi.c (bidi_check_type): Use xassert.
549 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
552 2011-08-23 Eli Zaretskii <eliz@gnu.org>
554 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
557 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
559 * nsfont.m (ns_otf_to_script): Fix typo.
561 2011-08-22 Kenichi Handa <handa@m17n.org>
563 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
564 extra slot even if the purpose is char-code-property-table.
566 2011-08-23 Eli Zaretskii <eliz@gnu.org>
568 * xdisp.c (redisplay_window): When computing centering_position,
569 account for the height of the header line. (Bug#8874)
571 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
572 instead of CHAR_TO_BYTE. Fixes a crash when a completion
573 candidate is selected by the mouse, and that candidate has a
574 composed character under the mouse.
576 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
577 coordinates reported by pos-visible-in-window-p for a composed
578 character in column zero.
580 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
582 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
584 2011-08-22 Eli Zaretskii <eliz@gnu.org>
586 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
587 consider it a hit if to_charpos is anywhere in the range of the
588 composed buffer positions.
590 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
592 * image.c (gif_load): Don't assume that each subimage has the same
593 dimensions as the base image. Handle disposal method that is
594 "undefined" by the gif spec (Bug#9335).
596 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
598 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
599 (Fcondition_case): Document `debug' symbol in error handler.
601 2011-08-19 Eli Zaretskii <eliz@gnu.org>
603 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
604 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
605 from an Org mode buffer to a Speedbar frame.
607 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
608 a composition, take its buffer position from IT->cmp_it.charpos.
609 Fixes cursor positioning at the beginning of a line that begins
610 with a composed character.
612 2011-08-18 Eli Zaretskii <eliz@gnu.org>
614 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
615 character bidirectional type, use STRONG_L instead. Fixes crashes
616 in a buffer produced by `describe-categories'.
618 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
619 members before the level stack, so they would be saved and
620 restored when copying iterator state. Fixes incorrect reordering
621 around TABs covered by display properties.
623 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
625 * process.c (Fnetwork_interface_list): Correctly determine buffer
628 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
630 * eval.c (internal_condition_case, internal_condition_case_1)
631 (internal_condition_case_2, internal_condition_case_n):
632 Remove unnecessary aborts (Bug#9081).
634 2011-08-17 Eli Zaretskii <eliz@gnu.org>
636 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
637 has no `load' handler, try opening the file locally. (Bug#9311)
639 2011-08-16 Ken Brown <kbrown@cornell.edu>
641 * gmalloc.c: Expand comment.
643 2011-08-16 Eli Zaretskii <eliz@gnu.org>
645 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
646 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
648 2011-08-16 Ken Brown <kbrown@cornell.edu>
650 Fix memory allocation problems in Cygwin build (Bug#9273).
652 * unexcw.c ( __malloc_initialized): Declare external variable.
653 (fixup_executable): Force the dumped emacs to reinitialize malloc.
655 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
657 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
659 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
661 [CYGWIN] (special_realloc): New function.
662 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
663 requests to realloc storage in the static heap.
665 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
667 * bidi.c (bidi_initialize): Remove unused local.
669 2011-08-15 Eli Zaretskii <eliz@gnu.org>
671 * biditype.h: File removed.
673 * bidimirror.h: File removed.
675 * deps.mk (bidi.o): Remove biditype.h and
678 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
681 * dispextern.h: Fix a typo in the comment to bidi_type_t.
683 * chartab.c: Improve commentary for the uniprop_table API.
685 * bidi.c (bidi_paragraph_init): Support zero value of
686 bidi_ignore_explicit_marks_for_paragraph_level.
687 (bidi_initialize): Use uniprop_table instead of including
688 biditype.h and bidimirror.h.
690 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
691 coordinates of the iterator when restoring from ppos_it.
694 2011-08-14 Kenichi Handa <handa@m17n.org>
696 * process.c (create_process): Call setup_process_coding_systems
697 after the pid of the process is set to -1 (Bug#8162).
699 2011-08-14 Eli Zaretskii <eliz@gnu.org>
701 * xdisp.c (move_it_in_display_line_to): Don't invoke
702 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
703 ppos_it. Fixes vertical cursor motion when line beginning is
704 covered by an image. (Bug#9296)
706 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
708 * nsterm.h (ns_run_ascript): Declare.
709 (NSAPP_DATA2_RUNASSCRIPT): Define.
711 * nsfns.m (as_script, as_result, as_status): New static variables.
712 (ns_run_ascript): New function.
713 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
714 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
715 the event loop. Get status from as_status (Bug#7276).
717 * nsterm.m (sendEvent): If event is NSApplicationDefined and
718 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
719 the event loop (Bug#7276).
721 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
723 * gnutls.c (QCgnutls_bootprop_priority)
724 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
725 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
726 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
727 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
728 (QCgnutls_bootprop_verify_hostname_error)
729 (QCgnutls_bootprop_callbacks_verify): Rename from
730 Qgnutls_bootprop_..., all uses changed.
732 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
735 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
737 * xfaces.c (Qframe_set_background_mode): Now static.
738 * dispextern.h (Qframe_set_background_mode): Remove decl.
740 * process.c (Fnetwork_interface_info): Declare local only if needed.
742 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
744 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
745 (Fnetwork_interface_list): Allocate in increments of bytes instead
746 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
747 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
749 (struct ifflag_def): notrailers is smart on OSX.
750 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
751 Get hardware address with getifaddrs if available.
753 2011-08-12 Eli Zaretskii <eliz@gnu.org>
755 * xdisp.c (iterate_out_of_display_property): xassert that
756 IT->position is set to within IT->object's boundaries. Break from
757 the loop as soon as EOB is reached; avoids infloops in redisplay
758 when IT->position is set up wrongly due to some bug.
759 Set IT->current to match the bidi iterator unconditionally.
760 (push_display_prop): Allow GET_FROM_STRING as IT->method on
761 entry. Force push_it to save on the stack the current
762 buffer/string position, to be restored by pop_it. Fix flags in
763 the iterator structure wrt the object coming from a display
764 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
765 properties. (Bug#9284)
767 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
769 * fontset.c (fontset_get_font_group): Add proper type checks.
772 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
774 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
775 and LC_VERSION_MIN_MACOSX.
776 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
777 (dump_it) [LC_FUNCTION_STARTS]: Use it.
779 2011-08-08 Eli Zaretskii <eliz@gnu.org>
781 * xdisp.c (forward_to_next_line_start): Allow to use the
782 no-display-properties-and-no-overlays under bidi display.
783 Set disp_pos in the bidi iterator to avoid searches for display
784 properties and overlays.
786 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
788 * editfns.c (Fset_time_zone_rule): Document relationship with the
791 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
792 the font entity extracted from the cache (Bug#8109).
794 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
796 * composite.c (autocmp_chars): Don't reset point. That is done by
797 restore_point_unwind (Bug#5984).
799 2011-08-07 Juri Linkov <juri@jurta.org>
801 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
802 to show the arg `TIME' instead of `TIMEVAL'.
804 2011-08-06 Eli Zaretskii <eliz@gnu.org>
806 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
807 display property strides EOL and includes a newline, as in
808 longlines-mode. (Bug#9254)
809 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
810 word-wrap under bidirectional display. (Bug#9224)
812 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
813 is non-zero, even if the data buffer is NULL. Fixes a crash in
814 vertical-motion with longlines-mode. (Bug#9254)
816 2011-08-05 Eli Zaretskii <eliz@gnu.org>
818 * bidi.c <bidi_cache_total_alloc>: Now static.
819 (bidi_initialize): Initialize bidi_cache_total_alloc.
821 * xdisp.c (display_line): Release buffer allocated for shelved bidi
824 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
825 amount allocated this far in `bidi_cache_total_alloc'.
826 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
827 non-zero, only free the data buffer without restoring the cache
828 contents. All callers changed.
830 * dispextern.h (bidi_unshelve_cache): Update prototype.
832 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
833 (move_it_in_display_line, move_it_to)
834 (move_it_vertically_backward, move_it_by_lines): Replace the call
835 to xfree to an equivalent call to bidi_unshelve_cache.
836 (move_it_in_display_line_to): Fix logic of returning
837 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
839 2011-08-05 Eli Zaretskii <eliz@gnu.org>
841 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
842 came from a string character with a `cursor' property. (Bug#9229)
844 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
846 * Makefile.in (LIB_PTHREAD): New variable.
847 (LIBES): Add LIB_PTHREAD (Bug#9216).
849 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
850 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
852 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
854 * regex.c (re_iswctype): Remove some redundant boolean
857 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
859 * xterm.c (x_find_topmost_parent): New function.
860 (x_set_frame_alpha): Find topmost parent window with
861 x_find_topmost_parent and set the property there also (bug#9181).
862 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
864 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
866 * callproc.c (Fcall_process): Avoid vfork clobbering
867 the local vars buffer, coding_systems, current_dir.
869 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
871 * keymap.c (Fmake_composed_keymap): Move to subr.el.
873 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
875 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
876 so that it is not optimized away.
878 * xdisp.c (compute_display_string_pos): Remove unused local.
880 2011-08-02 Eli Zaretskii <eliz@gnu.org>
882 Fix slow cursor motion and scrolling in large buffers with
883 selective display, like Org Mode buffers. (Bug#9218)
885 * dispextern.h (struct bidi_it): New member disp_prop_p.
887 * xdisp.c: Remove one-slot cache of display string positions.
888 (compute_display_string_pos): Accept an additional argument
889 DISP_PROP_P; callers changed. Scan at most 5K characters forward
890 for a display string or property. If found, set DISP_PROP_P
893 * bidi.c (bidi_fetch_char): Accept an additional argument
894 DISP_PROP_P, and pass it to compute_display_string_pos.
895 Only handle text covered by a display string if DISP_PROP_P is returned
896 non-zero. All callers of bidi_fetch_char changed.
898 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
900 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
902 2010-12-03 Don March <don@ohspite.net>
904 * keymap.c (Fdefine_key): Fix non-prefix key error message when
905 last character M-[char] is translated to ESC [char] (bug#7541).
907 2011-08-02 Kenichi Handa <handa@m17n.org>
909 * lisp.h (uniprop_table): Extern it.
911 * chartab.c (uniprop_table): Make it non-static.
913 2011-08-01 Eli Zaretskii <eliz@gnu.org>
915 * xdisp.c (forward_to_next_line_start): Accept additional argument
916 BIDI_IT_PREV, and store into it the state of the bidi iterator had
918 (reseat_at_next_visible_line_start): Use the bidi iterator state
919 returned by forward_to_next_line_start to restore the state of
920 it->bidi_it after backing up to previous newline. (Bug#9212)
922 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
924 * regex.c (re_comp): Protoize.
925 (re_exec): Fix return type.
926 (regexec): Fix type of `ret'. (Bug#9203)
928 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
930 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
931 This is needed if max-image-size is a floating-point number.
933 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
935 * print.c (print_object): Print empty symbol as ##.
937 * lread.c (read1): Read ## as empty symbol.
939 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
941 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
942 setting frame foreground color (Bug#9175).
943 (x_set_background_color): Likewise.
945 * nsmenu.m (-setText): Size tooltip dimensions precisely to
947 (EmacsTooltip -init): Remove bezels and add shadows to
950 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
951 or scroll bar (Bug#8470).
953 * nsfont.m (nsfont_open): Remove assignment to voffset and
954 unnecessary vars hshink, expand, hd, full_height, min_height.
955 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
957 * nsterm.h (nsfont_info): Remove voffset field.
959 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
961 Implement strike-through and overline on NextStep (Bug#8863).
963 * nsfont.m (nsfont_open): Use underline position provided by font,
964 instead of hard-coded value of 2.
965 (nsfont_draw): Call ns_draw_text_decoration instead.
967 * nsterm.h: Add declaration for ns_draw_text_decoration.
969 * nsterm.m (ns_draw_text_decoration): New function for drawing
970 underline, overline, and strike-through.
971 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
972 ns_draw_text_decoration. Change treatment of cursor drawing to
973 accomodate underlining, etc.
975 2011-07-28 Eli Zaretskii <eliz@gnu.org>
977 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
980 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
982 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
983 Without this fix, if a signal arrives just after memory fills up,
984 'malloc' might be invoked reentrantly.
986 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
987 In other words, assume that every image size is allowed, on non-X
988 hosts. This assumption is probably wrong, but it lets Emacs compile.
990 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
992 * regex.c (re_iswctype): Convert return values to boolean.
994 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
996 * xdisp.c (compute_display_string_pos): Don't use cached display
997 string position if the buffer had its restriction changed.
1000 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1002 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1004 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1006 Integer signedness and overflow and related fixes. (Bug#9079)
1008 * bidi.c: Integer size and overflow fixes.
1009 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1010 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1011 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1012 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1013 (bidi_find_other_level_edge):
1014 Use ptrdiff_t instead of EMACS_INT where either will do.
1015 This works better on 32-bit hosts configured --with-wide-int.
1016 (bidi_cache_ensure_space): Check for size-calculation overflow.
1017 Use % rather than repeated addition, for better worst-case speed.
1018 Don't set bidi_cache_size until after xrealloc returns, because it
1020 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1021 (bidi_cache_ensure_space): Also check that the bidi cache size
1022 does not exceed that of the largest Lisp string or buffer. See Eli
1023 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1025 * alloc.c (__malloc_size_t): Remove.
1026 All uses replaced by size_t. See Andreas Schwab's note
1027 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1029 * image.c: Improve checking for integer overflow.
1030 (check_image_size): Assume that f is nonnull, since
1031 it is always nonnull in practice. This is one less thing to
1032 worry about when checking for integer overflow later.
1033 (x_check_image_size): New function, which checks for integer
1034 overflow issues inside X.
1035 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1036 This removes the need for a memory_full check.
1037 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1038 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1039 (xbm_read_bitmap_data): Change locals back to 'int', since
1040 their values must fit in 'int'.
1041 (xpm_load_image, png_load, tiff_load):
1042 Invoke x_create_x_image_and_pixmap earlier,
1043 to avoid much needless work if the image is too large.
1044 (tiff_load): Treat overly large images as if
1045 x_create_x_image_and_pixmap failed, not as malloc failures.
1046 (gs_load): Use x_check_image_size.
1048 * gtkutil.c: Omit integer casts.
1049 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1050 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1052 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1054 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1055 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1056 would wrongly return t on a 64-bit host.
1058 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1059 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1060 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1061 and therefore cause GCC to emit a bogus diagnostic in some cases.
1063 * image.c: Integer signedness and overflow and related fixes.
1064 This is not an exhaustive set of fixes, but it's time to
1065 record what I've got.
1066 (lookup_pixel_color, check_image_size): Remove redundant decls.
1067 (check_image_size): Don't assume that arbitrary EMACS_INT values
1068 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1069 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1070 (tiff_load, imagemagick_load_image):
1071 Check for overflow in size calculations.
1072 (x_create_x_image_and_pixmap): Remove unnecessary test for
1073 xmalloc returning NULL; that can't happen.
1074 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1075 (xpm_color_bucket): Use better integer hashing function.
1076 (xpm_cache_color): Don't possibly over-allocate memory.
1077 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1078 (gif_memory_source):
1079 Use ptrdiff_t, not int or size_t, to record sizes.
1080 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1081 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1082 either works, as we prefer signed integers.
1083 (tiff_read_from_memory, tiff_write_from_memory):
1084 Return tsize_t, not size_t, since that's what the TIFF API wants.
1085 (tiff_read_from_memory): Don't fail simply because the read would
1086 go past EOF; instead, return a short read.
1087 (tiff_load): Omit no-longer-needed casts.
1088 (Fimagemagick_types): Don't assume size fits into 'int'.
1090 Improve hashing quality when configured --with-wide-int.
1091 * fns.c (hash_string): New function, taken from sxhash_string.
1092 Do not discard information about ASCII character case; this
1093 discarding is no longer needed.
1094 (sxhash-string): Use it. Change sig to match it. Caller changed.
1095 * lisp.h: Declare it.
1096 * lread.c (hash_string): Remove, since we now use fns.c's version.
1097 The fns.c version returns a wider integer if --with-wide-int is
1098 specified, so this should help the quality of the hashing a bit.
1100 * emacs.c: Integer overflow minor fix.
1101 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1102 Define only if GNU_LINUX.
1103 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1105 * dispnew.c: Integer signedness and overflow fixes.
1106 Remove unnecessary forward decls, that were a maintenance hassle.
1107 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1109 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1110 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1111 (prepare_desired_row, line_draw_cost):
1112 Use int, not unsigned, where either works.
1113 (save_current_matrix, restore_current_matrix):
1114 Use ptrdiff_t, not size_t, where either works.
1115 (init_display): Check for overflow more accurately, and without
1116 relying on undefined behavior.
1118 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1119 Remove, replacing with the new symbols in lisp.h. All uses changed.
1120 * fileio.c (make_temp_name):
1121 * filelock.c (lock_file_1, lock_file):
1122 * xdisp.c (message_dolog):
1123 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1124 Use pMd etc. instead.
1125 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1126 replacing the pWIDE etc. symbols removed from editfns.c.
1128 * keyboard.h (num_input_events): Now uintmax_t.
1129 This is (very slightly) less likely to mess up due to wraparound.
1132 * buffer.c: Integer signedness fixes.
1133 (alloc_buffer_text, enlarge_buffer_text):
1134 Use ptrdiff_t rather than size_t when either will do, as we prefer
1137 * alloc.c: Integer signedness and overflow fixes.
1138 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1139 (__malloc_size_t): Default to size_t, not to int.
1140 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1141 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1142 Prefer ptrdiff_t to size_t when either would do, as we prefer
1144 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1145 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1146 Now const. Initialize with values that are in range even if char
1148 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1149 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1150 These functions do the right thing with sizes > 2**32.
1151 (check_depth): Now ptrdiff_t, not int.
1152 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1153 Adjust to new way of storing sizes. Check for size overflow bugs
1155 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1156 slightly wrong anyway, as it missed one instance of
1157 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1158 (refill_memory_reserve): Omit needless cast to size_t.
1159 (mark_object_loop_halt): Mark as externally visible.
1161 * xselect.c: Integer signedness and overflow fixes.
1162 (Fx_register_dnd_atom, x_handle_dnd_message):
1163 Use ptrdiff_t, not size_t, since we prefer signed.
1164 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1165 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1166 x_dnd_atoms_size and x_dnd_atoms_length.
1168 * doprnt.c: Prefer signed to unsigned when either works.
1170 * doprnt.c (doprnt):
1172 * xdisp.c (vmessage):
1173 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1174 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1175 prefer signed arithmetic to avoid comparison confusion.
1176 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1177 but is a bit tricky.
1179 Assume freestanding C89 headers, string.h, stdlib.h.
1180 * data.c, doprnt.c, floatfns.c, print.c:
1181 Include float.h unconditionally.
1182 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1183 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1184 * regex.c: Likewise for stddef.h, string.h.
1185 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1186 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1187 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1188 (STDC_HEADERS): Remove obsolete defines.
1189 * sysdep.c: Include limits.h unconditionally.
1191 Assume support for memcmp, memcpy, memmove, memset.
1192 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1193 * regex.c (memcmp, memcpy):
1194 Remove; we assume C89 now.
1196 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1197 (__malloc_safe_bcopy): Remove; no longer needed.
1199 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1200 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1201 well either way, and we prefer signed to unsigned.
1203 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1205 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1206 closes the connection while we're reading (bug#9182).
1208 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1210 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1211 are specified (Bug#9168).
1213 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1215 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1216 Found by GCC static checking and --with-wide-int on a 32-bit host.
1218 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1220 * xdisp.c (compute_display_string_pos): Fix logic of caching
1221 previous display string position. Initialize cached_prev_pos to
1222 -1. Fixes slow-down at the beginning of a buffer.
1224 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1226 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1227 for attrs[LFACE_FONTSET_INDEX].
1229 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1231 * xml.c (parse_region): Remove unused local
1232 that was recently introduced.
1234 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1236 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1237 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1239 * xdisp.c (move_it_in_display_line_to): Record the best matching
1240 position for TO_CHARPOS while scanning the line, and restore it on
1241 exit if none of the characters scanned was an exact match.
1242 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1243 when exact match is impossible due to invisible text, and the
1244 lines are truncated.
1246 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1248 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1251 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1253 Fix a significant slow-down of cursor motion with C-n, C-p,
1254 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1255 auto-repeat under bidi redisplay in fontified buffers.
1256 * xdisp.c (compute_stop_pos_backwards): New function.
1257 (next_element_from_buffer): Call compute_stop_pos_backwards to
1258 find a suitable prev_stop when we find ourselves before
1260 (reseat): Don't look for prev_stop, as that could mean a very long
1262 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1263 <cached_disp_overlay_modiff>: Cache for last found display string
1265 (compute_display_string_pos): Return the cached position if asked
1266 about the same buffer in the same area of character positions, and
1267 the buffer wasn't changed since the time the display string
1268 position was cached.
1270 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1272 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1273 is an integer, which is important for empty lines. (Bug#9149)
1275 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1277 * frame.c (Fmodify_frame_parameters): In tty case, update the
1278 default face if necessary (Bug#4238).
1280 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1282 * editfns.c (Fstring_to_char): No need to explain what a character
1283 is in the docstring (Bug#6576).
1285 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1287 * xml.c (parse_region): Make sure we always return a tree.
1289 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1291 * xml.c (parse_region): If a document contains only comments,
1294 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1296 * xml.c (make_dom): Return comments, too.
1298 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1301 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1302 and the surrounding thread.
1303 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1304 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1305 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1307 * s/openbsd.h (BROKEN_SIGIO): Define.
1308 * unexelf.c (unexec) [__OpenBSD__]:
1309 Don't update the .mdebug section of the Alpha COFF symbol table.
1311 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1313 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1316 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1318 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1319 This fixes some race conditions on the permissions of any newly
1322 * alloc.c (valid_pointer_p): Use pipe, not open.
1323 This fixes some permissions issues when debugging.
1325 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1326 If fchown fails to set both uid and gid, try to set just gid,
1327 as that is sometimes allowed. Adjust the file's mode to eliminate
1328 setuid or setgid bits that are inappropriate if fchown fails.
1330 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1332 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1333 to compare Lisp_Objects.
1334 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1335 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1336 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1338 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1340 * lread.c (read_integer): Unread even EOF character.
1341 (read1): Likewise. Properly record start position of symbol.
1343 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1344 symbol character follows.
1346 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1348 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1349 This works around a problem with the previous change to Fcopy_file.
1350 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1351 and without this change, GCC might complain about discarding
1352 fchown's return value.
1354 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1356 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1358 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1360 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1362 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1364 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1365 it's used from the C level.
1367 * process.c: Use the same condition for POLL_FOR_INPUT in both
1368 keyboard.c and process.c (bug#1858).
1370 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1372 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1373 (Fgnutls_boot): Use it.
1375 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1377 * doc.c (Fsubstitute_command_keys): Revert last change.
1379 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1381 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1382 quotes the next character, and doesn't affect other longer
1383 sequences (bug#8935).
1385 * lread.c (syms_of_lread): Clarify that is isn't only
1386 `eval-buffer' and `eval-defun' that's affected by
1387 `lexical-binding' (bug#8460).
1389 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1391 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1392 bidi redisplay when a line includes both an image and is
1395 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1397 Fix minor problems found by static checking.
1398 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1399 (elsz): Now a signed constant, not a size_t var. We prefer signed
1400 types to unsigned, to avoid integer comparison confusion. Without
1401 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1402 "cannot optimize loop, the loop counter may overflow", a symptom
1404 * indent.c (Fvertical_motion): Mark locals as initialized.
1405 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1407 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1409 * search.c (Fre_search_backward): Mention `case-fold-search' in
1410 all the re_search_* functions (bug#8138).
1412 * keyboard.c (Fopen_dribble_file): Document when the file is
1415 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1417 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1420 Support bidi reordering of display and overlay strings.
1421 * xdisp.c (compute_display_string_pos)
1422 (compute_display_string_end): Accept additional argument STRING.
1423 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1424 (reseat_to_string): Initialize bidi_it->string.s and
1425 bidi_it->string.schars.
1426 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1427 NULL (avoids a crash in bidi_paragraph_init).
1428 Initialize itb.string.lstring.
1429 (init_iterator): Call bidi_init_it only of a valid
1430 buffer position was specified. Initialize paragraph_embedding to
1432 (reseat_to_string): Initialize the bidi iterator.
1433 (display_string): If we need to ignore text properties of
1434 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1435 original value of -1 will not work with bidi.)
1436 (compute_display_string_pos): First arg is now struct
1437 `text_pos *'; all callers changed. Support display properties on
1439 (compute_display_string_end): Support display properties on Lisp
1441 (init_iterator, reseat_1, reseat_to_string): Initialize the
1442 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1443 when iterating on a string not from display properties).
1444 (compute_display_string_pos, compute_display_string_end):
1445 Fix calculation of the object to scan. Fixes an error when using
1447 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1448 base_level_stop; instead, set base_level_stop to BEGV.
1449 Fixes crashes in vertical-motion.
1450 (next_element_from_buffer): Improve commentary for when
1451 the iterator is before prev_stop.
1452 (init_iterator): Initialize bidi_p from the default value of
1453 bidi-display-reordering, not from buffer-local value. Use the
1454 buffer-local value only if initializing for buffer iteration.
1455 (handle_invisible_prop): Support invisible properties on strings
1456 that are being bidi-reordered.
1457 (set_iterator_to_next): Support bidi reordering of C strings and
1459 (next_element_from_string): Support bidi reordering of Lisp
1461 (handle_stop_backwards): Support Lisp strings as well.
1462 (display_string): Support display of R2L glyph rows.
1463 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1464 (init_iterator): Don't initialize it->bidi_p for strings
1466 (reseat_to_string): Initialize it->bidi_p for strings here.
1467 (next_element_from_string, next_element_from_c_string)
1468 (next_element_from_buffer): Add xassert's for correspondence
1469 between IT's object being iterated and it->bidi_it.string
1471 (face_before_or_after_it_pos): Support bidi iteration.
1472 (next_element_from_c_string): Handle the case of the first string
1473 character that is not the first one in the visual order.
1474 (get_visually_first_element): New function, refactored from common
1475 parts of next_element_from_buffer, next_element_from_string, and
1476 next_element_from_c_string.
1477 (tool_bar_lines_needed, redisplay_tool_bar)
1478 (display_menu_bar): Force left-to-right direction. Add a FIXME
1479 comment for making that be controlled by a user option.
1480 (push_it, pop_it): Save and restore the state of the
1481 bidi iterator. Save and restore the bidi_p flag.
1482 (pop_it): Iterate out of display property for string iteration as
1484 (iterate_out_of_display_property): Support iteration over strings.
1485 (handle_single_display_spec): Set up it->bidi_it for iteration
1486 over a display string, and call bidi_init_it.
1487 (handle_single_display_spec, next_overlay_string)
1488 (get_overlay_strings_1, push_display_prop): Set up the bidi
1489 iterator for displaying display or overlay strings.
1490 (forward_to_next_line_start): Don't use the shortcut if
1492 (back_to_previous_visible_line_start): If handle_display_prop
1493 pushed the iterator stack, restore the internal state of the bidi
1494 iterator by calling bidi_pop_it same number of times.
1495 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1496 and we are bidi-iterating, don't decrement the iterator position;
1497 instead, set the first_elt flag in the bidi iterator, to produce
1499 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1500 (push_display_prop): xassert that we are iterating a buffer.
1501 (push_it, pop_it): Save and restore paragraph_embedding member.
1502 (handle_single_display_spec, next_overlay_string)
1503 (get_overlay_strings_1, reseat_1, reseat_to_string)
1504 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1505 correctly. Don't assume unibyte strings are not bidi-reordered.
1506 (compute_display_string_pos)
1507 (compute_display_string_end): Fix handling the case of C string.
1508 (push_it, pop_it): Save and restore from_disp_prop_p.
1509 (handle_single_display_spec, push_display_prop): Set the
1510 from_disp_prop_p flag.
1511 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1512 (pop_it): Call iterate_out_of_display_property only if we are
1513 popping after iteration over a string that came from a display
1514 property. Fix a typo in popping stretch info. Add an assertion
1515 for verifying that the iterator position is in sync with the bidi
1517 (handle_single_display_spec, get_overlay_strings_1)
1518 (push_display_prop): Fix initialization of paragraph direction for
1519 string when that of the parent object is not yet determined.
1520 (reseat_1): Call bidi_init_it to resync the bidi
1521 iterator with IT's position. (Bug#7616)
1522 (find_row_edges): If ROW->start.pos gives position
1523 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1524 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1525 Reset the from_disp_prop_p flag.
1526 (SAVE_IT, RESTORE_IT): New macros.
1527 (pos_visible_p, face_before_or_after_it_pos)
1528 (back_to_previous_visible_line_start)
1529 (move_it_in_display_line_to, move_it_in_display_line)
1530 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1531 (try_scrolling, redisplay_window, display_line): Use them when
1532 saving a temporary copy of the iterator and restoring it back.
1533 (back_to_previous_visible_line_start, reseat_1)
1534 (init_iterator): Empty the bidi cache "stack".
1535 (move_it_in_display_line_to): If iterator ended up at
1536 EOL, but we never saw any buffer positions smaller than
1537 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1538 motion in bidi-reordered lines.
1539 (move_it_in_display_line_to): Record prev_method and prev_pos
1540 immediately before the call to set_iterator_to_next. Fixes cursor
1541 motion in bidi-reordered lines with stretch glyphs and strings
1542 displayed in margins. (Bug#8133) (Bug#8867)
1543 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1545 (pos_visible_p): Support positions in bidi-reordered lines.
1546 Save and restore bidi cache.
1548 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1549 (bidi_paragraph_info): Delete unused struct.
1550 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1551 (bidi_cache_start): New variable.
1552 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1554 (bidi_cache_fetch_state, bidi_cache_search)
1555 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1556 (bidi_cache_find, bidi_peek_at_next_level)
1557 (bidi_level_of_next_char, bidi_find_other_level_edge)
1558 (bidi_move_to_visually_next): Compare cache index with
1559 bidi_cache_start rather than with zero.
1560 (bidi_fetch_char): Accept new argument STRING; all callers
1561 changed. Support iteration over a string. Support strings with
1562 display properties. Support unibyte strings. Fix the type of
1563 `len' according to what STRING_CHAR_AND_LENGTH expects.
1564 (bidi_paragraph_init, bidi_resolve_explicit_1)
1565 (bidi_resolve_explicit, bidi_resolve_weak)
1566 (bidi_level_of_next_char, bidi_move_to_visually_next):
1567 Support iteration over a string.
1568 (bidi_set_sor_type, bidi_resolve_explicit_1)
1569 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1570 can now be zero (for strings); special values 0 and -1 were
1571 changed to -1 and -2, respectively.
1572 (bidi_char_at_pos): New function.
1573 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1574 Call it instead of FETCH_MULTIBYTE_CHAR.
1575 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1576 initialized to valid values.
1577 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1579 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1580 the test for valid cached positions. Fix the logic for looking up
1581 the sentinel state in the cache. GCPRO the Lisp string we are
1583 (bidi_push_it, bidi_pop_it): New functions.
1584 (bidi_initialize): Initialize the bidi cache start stack pointer.
1585 (bidi_cache_ensure_space): New function, refactored from part of
1586 bidi_cache_iterator_state. Don't assume the required size is just
1587 one BIDI_CACHE_CHUNK away.
1588 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1589 (bidi_count_bytes, bidi_char_at_pos): New functions.
1590 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1591 always valid if bidi_cache_idx is valid.
1592 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1593 is valid if it's going to be used.
1594 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1595 (bidi_cache_fetch_state, bidi_cache_search)
1596 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1597 (bidi_cache_iterator_state, bidi_cache_find)
1598 (bidi_find_other_level_edge, bidi_cache_start_stack):
1599 All variables related to cache indices are now EMACS_INT.
1601 * dispextern.h (struct bidi_string_data): New structure.
1602 (struct bidi_it): New member `string'. Make flag members be 1-bit
1603 fields, and put them last in the struct.
1604 (compute_display_string_pos, compute_display_string_end):
1606 (bidi_push_it, bidi_pop_it): Add prototypes.
1607 (struct iterator_stack_entry): New members bidi_p,
1608 paragraph_embedding, and from_disp_prop_p.
1609 (struct it): Member bidi_p is now a bit field 1 bit wide.
1610 (bidi_shelve_cache, bidi_unshelve_cache):
1613 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1614 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1615 and vector-like objects.
1617 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1618 cache around display iteration.
1620 * window.c (Fwindow_end, window_scroll_pixel_based)
1621 (displayed_window_lines, Frecenter): Save and restore the bidi
1622 cache around display iteration.
1624 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1626 * editfns.c (Fdelete_region): Clarify the use of the named
1627 parameters (bug#6788).
1629 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1631 * indent.c (Fvertical_motion): Set and restore w->pointm when
1632 saving and restoring the window's buffer (Bug#9006).
1634 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1636 * editfns.c (Fstring_to_char): Clarify just what is returned
1637 (bug#6576). Text by Eli Zaretskii.
1639 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1641 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1643 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1645 * buffer.c (mmap_find): Fix a typo.
1647 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1649 Fix execution of x selection hooks.
1650 * xselect.c (Qx_lost_selection_functions)
1651 (Qx_sent_selection_functions): New vars.
1652 (syms_of_xselect): DEFSYM them.
1653 (x_handle_selection_request): Pass Qx_sent_selection_functions
1654 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1655 (x_handle_selection_clear,x_clear_frame_selections):
1656 Pass Qx_lost_selection_functions rather than
1657 Vx_lost_selection_functions to Frun_hook_with_args.
1659 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1661 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1662 The old code sometimes used this field without initializing it.
1664 * alloc.c (gc_sweep): Don't read past end of array.
1665 In theory, the old code could also have corrupted Emacs internals,
1666 though it'd be very unlikely.
1668 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1670 * character.c (Fcharacterp): Don't advertise optional ignored
1671 argument. (Bug#4026)
1673 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1675 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1678 * window.c (Fset_window_start): Doc fix (bug#4199).
1679 (Fset_window_hscroll): Ditto.
1681 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1683 Fix minor new problems caught by GCC 4.6.1.
1684 * term.c (init_tty): Remove unused local.
1685 * xsettings.c (store_monospaced_changed): Define this function only
1686 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1689 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1691 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1693 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1695 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1696 are the mini-buffer and the echo area (bug#3320).
1698 * term.c (init_tty): Remove support for supdup, c10 and perq
1699 terminals, which are no longer supported (bug#1482).
1701 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1703 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1705 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1707 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1708 for non-popups (Bug#3642).
1710 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1712 * alloc.c (reset_malloc_hooks): Protoize.
1713 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1714 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1715 * cm.c (losecursor): Likewise.
1716 * data.c (fmod): Likewise.
1717 * dispnew.c (swap_glyphs_in_rows): Likewise.
1718 * emacs.c (memory_warning_signal): Likewise.
1719 * floatfns.c (float_error): Likewise.
1720 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1721 (otf_open, font_otf_capability, generate_otf_features)
1722 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1724 * image.c (pbm_read_file): Likewise.
1725 * indent.c (string_display_width): Likewise.
1726 * intervals.c (check_for_interval, search_for_interval)
1727 (inc_interval_count, count_intervals, root_interval)
1728 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1729 * lread.c (defalias): Likewise.
1730 * ralloc.c (r_alloc_check): Likewise.
1731 * regex.c (set_image_of_range_1, set_image_of_range)
1732 (regex_grow_registers): Likewise.
1733 * sysdep.c (strerror): Likewise.
1734 * termcap.c (valid_filename_p, tprint, main): Likewise.
1735 * tparam.c (main): Likewise.
1736 * unexhp9k800.c (run_time_remap, save_data_space)
1737 (update_file_ptrs, read_header, write_header, calculate_checksum)
1738 (copy_file, copy_rest, display_header): Likewise.
1739 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1741 * xdisp.c (check_it): Likewise.
1742 * xfaces.c (register_color, unregister_color, unregister_colors):
1744 * xfns.c (print_fontset_result): Likewise.
1745 * xrdb.c (member, fatal, main): Likewise.
1747 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1749 Fix minor problems found by static checking (Bug#9031).
1750 * chartab.c (char_table_set_range, map_sub_char_table):
1751 Remove unused locals.
1752 (uniprop_table): Now static.
1753 * composite.c (_work_char): Remove unused static var.
1755 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1757 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1759 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1761 * gtkutil.c (qttip_cb): Remove code without function.
1763 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1765 * w32.c (pthread_sigmask): New stub.
1767 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1769 Use pthread_sigmask, not sigprocmask (Bug#9010).
1770 sigprocmask is portable only for single-threaded applications, and
1771 Emacs can be multi-threaded when it uses GTK.
1772 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1774 * callproc.c (Fcall_process):
1775 * process.c (create_process):
1776 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1777 Use pthread_sigmask, not sigprocmask.
1779 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1781 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1782 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1785 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1787 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1788 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1789 (xg_hide_tooltip): Fix comment.
1791 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1792 in registerServicesMenuSendTypes.
1793 (validRequestorForSendType): Don't check ns_return_types.
1795 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1798 2011-07-08 Jason Rumney <jasonr@gnu.org>
1800 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1801 frame struct members of non-existent frames (Bug#6284).
1803 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1805 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1806 variable firstTime not needed on OSX >= 10.6.
1807 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1808 >= 10.5. Use setKnobProportion, setDoubleValue.
1810 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1811 (MAC_OS_X_VERSION_10_5): Define if not defined.
1812 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1813 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1814 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1816 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1817 cString and lossyCString on OSX >= 10.4
1819 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1820 sizeToFit on OSX >= 10.2.
1822 * nsimage.m (allocInitFromFile): Don't use deprecated method
1823 bestRepresentationForDevice on OSX >= 10.6.
1825 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1828 * emacs.c: Declare unexec_init_emacs_zone.
1830 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1832 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1834 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1835 on svcsMenu (Bug#8842).
1837 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1839 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1841 * nsterm.m (QUTF8_STRING): Declare.
1842 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1843 (validRequestorForSendType): Return type is (id).
1844 Change indexOfObjectIdenticalTo to indexOfObject.
1845 Check if we have local selection before returning self (Bug#8842).
1846 (writeSelectionToPasteboard): Put local selection into paste board
1847 if we have a local selection (Bug#8842).
1848 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1850 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1851 (ns_get_local_selection): Declare.
1853 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1855 * keymap.c (describe_map_tree): Don't insert a double newline at
1856 the end of the buffer (bug#1169) and return whether we inserted
1859 * callint.c (Fcall_interactively): Change "reading args" to
1860 "providing args" to try to clarify what it does (bug#1010).
1862 2011-07-07 Kenichi Handa <handa@m17n.org>
1864 * composite.c (composition_compute_stop_pos): Ignore a static
1865 composition starting before CHARPOS (Bug#8915).
1867 * xdisp.c (handle_composition_prop): Likewise.
1869 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1871 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1874 2011-07-07 Kenichi Handa <handa@m17n.org>
1876 * character.h (unicode_category_t): New enum type.
1878 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1879 (Qchar_code_property_table): New variable.
1880 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1881 (UNIPROP_COMPRESSED_FORM_P): New macros.
1882 (char_table_ascii): Uncompress the compressed values.
1883 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1884 Uncompress the compressed values.
1885 (sub_char_table_ref_and_range): Likewise.
1886 (char_table_ref_and_range): Uncompress the compressed values.
1887 (sub_char_table_set): New arg is_uniprop. Callers changed.
1888 Uncompress the compressed values.
1889 (sub_char_table_set_range): Args changed. Callers changed.
1890 (char_table_set_range): Adjuted for the above change.
1891 (map_sub_char_table): Delete args default_val and parent. Add arg
1892 top. Give decoded values to a Lisp function.
1893 (map_char_table): Adjust for the above change. Give decoded
1894 values to a Lisp function. Gcpro more variables.
1895 (uniprop_table_uncompress)
1896 (uniprop_decode_value_run_length): New functions.
1897 (uniprop_decoder, uniprop_decoder_count): New variables.
1898 (uniprop_get_decoder, uniprop_encode_value_character)
1899 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1901 (uniprop_encoder, uniprop_encoder_count): New variables.
1902 (uniprop_get_encoder, uniprop_table)
1903 (Funicode_property_table_internal, Fget_unicode_property_internal)
1904 (Fput_unicode_property_internal): New functions.
1905 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1906 Sunicode_property_table_internal, Sget_unicode_property_internal,
1907 and Sput_unicode_property_internal. Defvar_lisp
1908 char-code-property-alist.
1910 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1911 Vunicode_category_table.
1913 * font.c (font_range): Adjust for the change of
1914 Vunicode_category_table.
1916 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1918 * m/iris4d.h: Remove file, move contents ...
1919 * s/irix6-5.h: ... here.
1921 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1923 Remove unportable assumption about struct layout (Bug#8884).
1924 * alloc.c (mark_buffer):
1925 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1926 (clone_per_buffer_values): Don't assume that
1927 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1928 This isn't true in general, and it's particularly not true
1929 if Emacs is configured with --with-wide-int.
1930 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1931 New macros, used in the buffer.c change.
1933 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1935 * xsettings.c: Use both GConf and GSettings if both are available.
1936 (store_config_changed_event): Add comment.
1937 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1938 (store_tool_bar_style_changed): New functions.
1939 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1940 (struct xsettings): Move font inside HAVE_XFT.
1941 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1942 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
1943 Move inside HAVE_XFT.
1944 (something_changed_gsettingsCB): Rename from something_changedCB.
1945 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1947 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1948 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1949 (something_changed_gconfCB): Rename from something_changedCB.
1950 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1951 (parse_settings): Move check for font inside HAVE_XFT.
1952 (read_settings, apply_xft_settings): Add comment.
1953 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1954 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1955 call store_font_name_changed.
1956 (xft_settings_event): Add comment.
1957 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1958 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1959 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1960 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1961 (xsettings_initialize): Call init_gsettings last.
1962 (xsettings_get_system_font, xsettings_get_system_normal_font):
1965 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1967 Random fixes. E.g., (random) never returned negative values.
1968 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1969 subseconds part to the entropy, as that's a bit more random.
1970 Prefer signed to unsigned, since the signedness doesn't matter and
1971 in general we prefer signed. When given a limit, use a
1972 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1973 latter isn't right if USE_2_TAGS_FOR_INTS.
1974 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1975 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1977 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1979 * textprop.c (text_property_stickiness):
1980 Obey Vtext_property_default_nonsticky.
1981 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1982 * w32fns.c (syms_of_w32fns):
1983 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1985 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1987 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1988 This is more efficient than Ffile_directory_p and avoids a minor race.
1990 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1992 * buffer.c (Foverlay_put): Say what the return value is
1995 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1996 is a directory before asking whether to use the file name
1998 (barf_or_query_if_file_exists): Make the "File is a directory"
1999 error be more correct.
2001 * fns.c (Frequire): Remove the mention of the .gz files, since
2002 that's installation-specific, but keep the mention of
2003 `get-load-suffixes'.
2005 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2007 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2008 Report string overflow if the output is too long.
2010 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2012 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2013 (syms_of_gnutls): Remove duplicate DEFSYM for
2014 Qgnutls_bootprop_verify_hostname_error, an error for
2015 Qgnutls_bootprop_verify_error (which is no longer used).
2017 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2018 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2019 Also (re)move comments that are misplaced or no longer relevant.
2021 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2023 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2025 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2027 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2028 and background color parameters if they have been changed.
2030 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2032 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2034 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2036 * xsettings.c (SYSTEM_FONT): Define only when used.
2037 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2039 * keymap.c (access_keymap_1): Now static.
2041 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2043 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2044 leave any prefix arg for the up event (Bug#1586).
2046 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2048 * lread.c (syms_of_lread): Mention single symbols defined by
2049 `defvar' or `defconst' (bug#7154).
2051 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2052 (Frequire): Mention get-load-suffixes.
2054 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2056 * window.h (window): Remove clone_number slot.
2057 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2059 (make_parent_window, make_window, saved_window)
2060 (Fset_window_configuration, save_window_save): Don't deal with
2062 * buffer.c (Qclone_number): Remove declaration.
2063 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2065 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2067 Add multiple inheritance to keymaps.
2068 * keymap.c (Fmake_composed_keymap): New function.
2069 (Fset_keymap_parent): Simplify.
2070 (fix_submap_inheritance): Remove.
2071 (access_keymap_1): New function extracted from access_keymap to handle
2072 embedded parents and handle lists of maps.
2073 (access_keymap): Use it.
2074 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2075 (Fcopy_keymap): Handle embedded parents.
2076 (Fcommand_remapping, define_as_prefix): Simplify.
2077 (Fkey_binding): Simplify.
2078 (syms_of_keymap): Move minibuffer-local-completion-map,
2079 minibuffer-local-filename-completion-map,
2080 minibuffer-local-must-match-map, and
2081 minibuffer-local-filename-must-match-map to Elisp.
2082 (syms_of_keymap): Defsubr make-composed-keymap.
2083 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2084 (parse_menu_item): Trivial simplification.
2086 2011-07-01 Glenn Morris <rgm@gnu.org>
2088 * Makefile.in (SETTINGS_LIBS): Fix typo.
2090 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2092 * coding.c (Fencode_coding_string): Record the last coding system
2093 used, as the function doc string says (bug#8738).
2095 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2097 * xsettings.c (store_monospaced_changed): Take new font as arg and
2098 check for change against current_mono_font.
2099 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2100 (emacs_settings_constructor, emacs_settings_get_property)
2101 (emacs_settings_set_property, emacs_settings_class_init)
2102 (emacs_settings_init, gsettings_obj): Remove.
2103 (something_changedCB): New function for HAVE_GSETTINGS.
2104 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2105 with value as argument.
2106 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2107 g_settings_new (Bug#8967). Do not create gsettings_obj.
2108 Remove calls to g_settings_bind. Connect something_changedCB to
2111 * xgselect.c: Add defined (HAVE_GSETTINGS).
2112 (xgselect_initialize): Ditto.
2114 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2115 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2118 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2120 * eval.c (struct backtrace): Simplify and port the data structure.
2121 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2122 signed bit field, as this assumption is not portable and it makes
2123 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2124 "char debug_on_exit : 1" as this is not portable either; instead,
2125 use the portable "unsigned int debug_on_exit : 1". Remove unused
2126 member evalargs. Remove obsolete comments about cc bombing out.
2128 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2130 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2131 Let HAVE_GSETTINGS override HAVE_GCONF.
2132 (store_monospaced_changed): New function.
2133 (EMACS_SETTINGS): A new type derived from GObject to handle
2134 GSettings notifications.
2135 (emacs_settings_constructor, emacs_settings_get_property)
2136 (emacs_settings_set_property, emacs_settings_class_init):
2138 (gsettings_client, gsettings_obj): New variables.
2139 (GSETTINGS_SCHEMA): New define.
2140 (something_changedCB): Call store_monospaced_changed.
2141 (init_gsettings): New function.
2142 (xsettings_initialize): Call init_gsettings.
2143 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2146 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2149 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2151 * window.c (resize_root_window, grow_mini_window)
2152 (shrink_mini_window): Rename Qresize_root_window to
2153 Qwindow_resize_root_window and Qresize_root_window_vertically to
2154 Qwindow_resize_root_window_vertically.
2156 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2158 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2160 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2162 * makefile.w32-in: Redesign dependencies so they reflect more
2163 clearly which files are directly included by each source file,
2164 and not through other includes.
2166 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2168 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2169 (sort_overlays, overlay_strings): When an overlay's clone number
2170 matches the window's clone number process the overlay even if
2171 the overlay's window property doesn't match the current window.
2173 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2174 (Fwindow_hchild): Rename to Fwindow_left_child.
2175 (Fwindow_next): Rename to Fwindow_next_sibling.
2176 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2177 (resize_window_check): Rename to window_resize_check.
2178 (resize_window_apply): Rename to window_resize_apply.
2179 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2180 (Fdelete_other_windows_internal, resize_frame_windows)
2181 (Fsplit_window_internal, Fdelete_window_internal)
2182 (grow_mini_window, shrink_mini_window)
2183 (Fresize_mini_window_internal): Fix callers accordingly.
2185 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2187 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2188 (emacs_fixed_set_min_size): Remove.
2189 (emacs_fixed_new): Take frame as argument.
2191 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2192 (_EmacsFixedPrivate): Remove minwidth/height.
2193 Add struct frame *f.
2194 (emacs_fixed_init): Initialize priv->f.
2195 (get_parent_class, emacs_fixed_set_min_size): Remove.
2196 (emacs_fixed_new): Set priv->f to argument.
2197 (emacs_fixed_get_preferred_width)
2198 (emacs_fixed_get_preferred_height): Use min_width/height from
2199 frames size_hint to set minimum and natural (Bug#8919).
2200 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2201 and use min_width/height from frames size_hint to set
2202 min_width/height (Bug#8919).
2204 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2205 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2208 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2210 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2211 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2214 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2216 * process.c (wait_reading_process_output): Bypass select if
2217 waiting for a cell while ignoring keyboard input, and input is
2218 pending. Suggested by Jan Djärv (Bug#8869).
2220 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2222 Use gnulib's dup2 module instead of rolling our own.
2223 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2225 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2227 * dispnew.c (scrolling_window): Before scrolling, turn off a
2228 mouse-highlight in the window being scrolled.
2230 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2232 Move DEFSYM to lisp.h and use everywhere.
2234 * character.h (DEFSYM): Move declaration...
2235 * lisp.h (DEFSYM): ...here.
2241 * w32select.c: Don't include character.h.
2243 * alloc.c (syms_of_alloc):
2244 * buffer.c (syms_of_buffer):
2245 * bytecode.c (syms_of_bytecode):
2246 * callint.c (syms_of_callint):
2247 * casefiddle.c (syms_of_casefiddle):
2248 * casetab.c (init_casetab_once):
2249 * category.c (init_category_once, syms_of_category):
2250 * ccl.c (syms_of_ccl):
2251 * cmds.c (syms_of_cmds):
2252 * composite.c (syms_of_composite):
2253 * dbusbind.c (syms_of_dbusbind):
2254 * dired.c (syms_of_dired):
2255 * dispnew.c (syms_of_display):
2256 * doc.c (syms_of_doc):
2257 * editfns.c (syms_of_editfns):
2258 * emacs.c (syms_of_emacs):
2259 * eval.c (syms_of_eval):
2260 * fileio.c (syms_of_fileio):
2261 * fns.c (syms_of_fns):
2262 * frame.c (syms_of_frame):
2263 * fringe.c (syms_of_fringe):
2264 * insdel.c (syms_of_insdel):
2265 * keymap.c (syms_of_keymap):
2266 * lread.c (init_obarray, syms_of_lread):
2267 * macros.c (syms_of_macros):
2268 * msdos.c (syms_of_msdos):
2269 * print.c (syms_of_print):
2270 * process.c (syms_of_process):
2271 * search.c (syms_of_search):
2272 * sound.c (syms_of_sound):
2273 * syntax.c (init_syntax_once, syms_of_syntax):
2274 * terminal.c (syms_of_terminal):
2275 * textprop.c (syms_of_textprop):
2276 * undo.c (syms_of_undo):
2277 * w32.c (globals_of_w32):
2278 * window.c (syms_of_window):
2279 * xdisp.c (syms_of_xdisp):
2280 * xfaces.c (syms_of_xfaces):
2281 * xfns.c (syms_of_xfns):
2282 * xmenu.c (syms_of_xmenu):
2283 * xsettings.c (syms_of_xsettings):
2284 * xterm.c (syms_of_xterm): Use DEFSYM.
2286 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2288 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2290 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2292 Integer and buffer overflow fixes (Bug#8873).
2294 * print.c (printchar, strout): Check for string overflow.
2295 (PRINTPREPARE, printchar, strout):
2296 Don't set size unless allocation succeeds.
2298 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2299 for sizes. Check for string overflow more accurately.
2300 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2302 * macros.c: Integer and buffer overflow fixes.
2303 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2304 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2305 Use ptrdiff_t, not int, for sizes.
2306 Don't increment bufsize until after realloc succeeds.
2307 Check for size-calculation overflow.
2308 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2310 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2312 * lread.c: Integer overflow fixes.
2313 (read_integer): Radix is now EMACS_INT, not int,
2314 to improve quality of diagnostics for out-of-range radices.
2315 Calculate buffer size correctly for out-of-range radices.
2316 (read1): Check for integer overflow in radices, and in
2317 read-circle numbers.
2318 (read_escape): Avoid int overflow.
2319 (Fload, openp, read_buffer_size, read1)
2320 (substitute_object_recurse, read_vector, read_list, map_obarray):
2321 Use ptrdiff_t, not int, for sizes.
2322 (read1): Use EMACS_INT, not int, for sizes.
2323 Check for size overflow.
2325 * image.c (cache_image): Check for size arithmetic overflow.
2327 * lread.c: Integer overflow issues.
2328 (saved_doc_string_size, saved_doc_string_length)
2329 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2330 Now ptrdiff_t, not int.
2331 (read1): Don't assume doc string length fits in int. Check for
2332 out-of-range doc string lengths.
2333 (read_list): Don't assume file position fits in int.
2334 (read_escape): Check for hex character overflow.
2336 2011-06-22 Leo Liu <sdl.web@gmail.com>
2338 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2339 Move to minibuffer.el.
2341 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2343 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2344 The following patches are for when GLYPH_DEBUG && !XASSERT.
2345 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2346 * dispnew.c (flush_stdout):
2347 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2348 Mark as externally visible.
2349 * dispnew.c (check_window_matrix_pointers): Now static.
2350 * dispnew.c (window_to_frame_vpos):
2351 * xfns.c (unwind_create_frame):
2352 * xterm.c (x_check_font): Remove unused local.
2353 * scroll.c (CHECK_BOUNDS):
2354 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2355 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2356 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2357 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2358 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2360 (debug_method_add): Use va_list and vsprintf rather than relying
2361 on undefined behavior with wrong number of arguments.
2362 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2363 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2364 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2365 since we're not interested in debugging glyphs with old libraries.
2366 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2367 GCC 4.6.0's static checking.
2369 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2371 Integer overflow and signedness fixes (Bug#8873).
2372 A few related buffer overrun fixes, too.
2374 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2376 * dispextern.h (struct face.stipple):
2377 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2378 (x_bitmap_mask, x_allocate_bitmap_record)
2379 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2380 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2381 (x_create_bitmap_from_xpm_data):
2382 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2383 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2385 * xfaces.c (load_pixmap):
2386 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2387 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2388 (.bitmaps_last, struct x_output.icon_bitmap):
2389 Use ptrdiff_t, not int, for bitmap indexes.
2390 (x_allocate_bitmap_record): Check for size overflow.
2391 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2393 Use ptrdiff_t, not int, for overlay counts.
2394 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2395 * editfns.c (overlays_around, get_pos_property):
2396 * textprop.c (get_char_property_and_overlay):
2397 * xdisp.c (next_overlay_change, note_mouse_highlight):
2398 * xfaces.c (face_at_buffer_position):
2399 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2400 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2401 (Fnext_overlay_change, Fprevious_overlay_change)
2402 (mouse_face_overlay_overlaps, Foverlays_in):
2403 Use ptrdiff_t, not int, for sizes.
2404 (overlays_at, overlays_in): Check for size-calculation overflow.
2406 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2408 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2409 (x_session_initialize): Do not assume string length fits in int.
2411 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2412 This is unlikely, but can occur if DPI is outlandish.
2414 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2415 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2417 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2418 * xrdb.c (magic_file_p, search_magic_path):
2419 Omit last arg SUFFIX; it was always 0. All callers changed.
2420 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2422 * xfont.c (xfont_match): Avoid need for strlen.
2424 * xfns.c: Don't assume strlen fits in int.
2425 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2427 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2428 not unsigned long, as we prefer signed integers. All callers changed.
2429 Detect integer overflow in repeat count.
2430 (message_dolog): Don't assume print length fits in 39 bytes.
2431 (display_mode_element): Don't assume strlen fits in int.
2433 * termcap.c: Don't assume sizes fit in int and never overflow.
2434 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2435 (gobble_line): Check for size-calculation overflow.
2437 * minibuf.c (Fread_buffer):
2438 * lread.c (intern, intern_c_string):
2439 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2440 Don't assume string length fits in int.
2442 * keyboard.c (parse_tool_bar_item):
2443 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2445 * font.c: Don't assume string length fits in int.
2446 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2447 Use ptrdiff_t, not int.
2448 (font_intern_prop): Don't assume string length fits in int.
2449 Don't assume integer property fits in fixnum.
2450 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2452 * filelock.c: Fix some buffer overrun and integer overflow issues.
2453 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2454 Reformulate so as not to need the command string.
2455 Invoke gzip -cd rather than gunzip, as it's more portable.
2456 (lock_info_type, lock_file_1, lock_file):
2457 Don't assume pid_t and time_t fit in unsigned long.
2458 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2459 (current_lock_owner): Prefer signed type for sizes.
2460 Use memcpy, not strncpy, where memcpy is what is really wanted.
2461 Don't assume (via atoi) that time_t and pid_t fit in int.
2462 Check for time_t and/or pid_t out of range, e.g., via a network share.
2463 Don't alloca where an auto var works fine.
2465 * fileio.c: Fix some integer overflow issues.
2466 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2467 Don't assume string length fits in int.
2468 (directory_file_name): Don't assume string length fits in long.
2469 (make_temp_name): Don't assume pid fits in int, or that its print
2470 length is less than 20.
2472 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2474 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2476 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2478 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2479 We prefer signed integers, even for size calculations.
2481 * emacs.c: Don't assume string length fits in 'int'.
2482 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2483 (main): Don't invoke strlen when not needed.
2485 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2486 (XD_DEBUG_MESSAGE): Don't waste a byte.
2488 * callproc.c (getenv_internal_1, getenv_internal)
2490 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2492 * lread.c (invalid_syntax): Omit length argument.
2493 All uses changed. This doesn't fix a bug, but it simplifies the
2494 code away from its former Hollerith-constant appearance, and it's
2495 one less 'int' to worry about when looking at integer-overflow issues.
2496 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2498 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2499 This didn't break anything, but it didn't help either.
2500 It's confusing to put a bogus integer in a place where the actual
2501 value does not matter.
2502 (LIST_END_P): Remove unused macro and its bogus comment.
2503 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2505 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2506 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2508 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2509 We prefer signed types, and the value cannot exceed the EMACS_INT
2510 range anyway (because otherwise the length would not be representable).
2511 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2512 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2513 This avoids a GCC warning when WIDE_EMACS_INT.
2515 * indent.c (sane_tab_width): New function.
2516 (current_column, scan_for_column, Findent_to, position_indentation)
2517 (compute_motion): Use it. This is just for clarity.
2518 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2520 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2522 * lisp.h (lint_assume): New macro.
2523 * composite.c (composition_gstring_put_cache):
2524 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2526 * editfns.c, insdel.c:
2527 Omit unnecessary forward decls, to simplify future changes.
2529 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2531 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2533 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2534 Use much-faster test for byte-length change.
2535 Don't assume string byte-length fits in 'int'.
2536 Check that character arg fits in 'int'.
2537 (mapcar1): Declare byte as byte, for clarity.
2539 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2541 * fns.c (concat): Catch string overflow earlier.
2542 Do not rely on integer wraparound.
2544 * dispextern.h (struct it.overlay_strings_charpos)
2545 (struct it.selective): Now EMACS_INT, not int.
2546 * xdisp.c (forward_to_next_line_start)
2547 (back_to_previous_visible_line_start)
2548 (reseat_at_next_visible_line_start, next_element_from_buffer):
2549 Don't arbitrarily truncate the value of 'selective' to int.
2551 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2553 * composite.c: Don't truncate sizes to 'int'.
2554 (composition_gstring_p, composition_reseat_it)
2555 (composition_adjust_point): Use EMACS_INT, not int.
2556 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2557 not EMACS_UINT, for indexes.
2559 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2561 * buffer.c: Include <verify.h>.
2562 (struct sortvec.priority, struct sortstr.priority):
2563 Now EMACS_INT, not int.
2564 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2565 (struct sortstr.size, record_overlay_string)
2566 (struct sortstrlist.size, struct sortlist.used):
2567 Don't truncate size to int.
2568 (record_overlay_string): Check for size-calculation overflow.
2569 (init_buffer_once): Check at compile-time, not run-time.
2571 2011-06-22 Jim Meyering <meyering@redhat.com>
2573 Don't leak an XBM-image-sized buffer
2574 * image.c (xbm_load): Free the image buffer after using it.
2576 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2579 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2580 that Sun C diagnosed.
2581 * fns.c (secure_hash): Fix pointer signedness issue.
2582 * intervals.c (static_offset_intervals): New function.
2583 (offset_intervals): Use it.
2585 2011-06-21 Leo Liu <sdl.web@gmail.com>
2588 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2591 * fns.c (secure_hash): Rename from crypto_hash_function and change
2592 the first arg to accept symbols.
2593 (Fsecure_hash): New primitive.
2594 (syms_of_fns): New symbols.
2596 2011-06-20 Deniz Dogan <deniz@dogan.se>
2598 * process.c (Fset_process_buffer): Clarify return value in
2601 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2603 * dispnew.c (add_window_display_history): Use BVAR.
2605 * xdisp.c (debug_method_add): Use BVAR.
2606 (check_window_end, dump_glyph_matrix, dump_glyph)
2607 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2609 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2612 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2613 check till after the cache is created in init_frame_faces.
2615 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2617 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2619 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2621 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2622 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2623 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2625 Improve buffer-overflow checking (Bug#8873).
2626 * fileio.c (Finsert_file_contents):
2627 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2628 Remove the old (too-loose) buffer overflow checks.
2629 They weren't needed, since make_gap checks for buffer overflow.
2630 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2631 The old code merely checked for Emacs fixnum overflow, and relied
2632 on undefined (wraparound) behavior. The new code avoids undefined
2633 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2635 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2636 Tune. Don't use wider integers than needed. Don't use alloca.
2637 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2639 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2641 * insdel.c, lisp.h (buffer_overflow): New function.
2642 (insert_from_buffer_1, replace_range, replace_range_2):
2643 * insdel.c (make_gap_larger):
2644 * editfns.c (Finsert_char):
2645 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2647 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2649 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2651 Integer overflow and signedness fixes (Bug#8873).
2653 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2654 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2656 * fileio.c: Don't assume EMACS_INT fits in off_t.
2657 (emacs_lseek): New static function.
2658 (Finsert_file_contents, Fwrite_region): Use it.
2659 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2661 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2663 * fns.c: Don't overflow int when computing a list length.
2664 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2665 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2666 truncation on 64-bit hosts. Check for QUIT every
2667 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2668 faster and is responsive enough.
2669 (Flength): Report an error instead of overflowing an integer.
2670 (Fsafe_length): Return a float if the value is not representable
2671 as a fixnum. This shouldn't happen except in contrived situations.
2672 (Fnthcdr, Fsort): Don't assume list length fits in int.
2673 (Fcopy_sequence): Don't assume vector length fits in int.
2675 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2676 (header_size, word_size): New constants.
2677 (allocate_vectorlike): Don't check size overflow here.
2678 (allocate_vector): Check it here instead, since this is the only
2679 caller of allocate_vectorlike that could cause overflow.
2680 Check that the new vector's length is representable as a fixnum.
2682 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2683 The previous code was bogus. For example, next_almost_prime (32)
2684 returned 39, which is undesirable as it is a multiple of 3; and
2685 next_almost_prime (24) returned 25, which is a multiple of 5 so
2686 why was the code bothering to check for multiples of 7?
2688 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2690 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2692 Variadic C functions now count arguments with ptrdiff_t.
2693 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2694 Back then I didn't know that the Emacs coding style prefers signed int.
2695 Also, in the meantime I found a few more instances where arguments
2696 were being counted with int, which may truncate counts on 64-bit
2697 machines, or EMACS_INT, which may be unnecessarily wide.
2698 * lisp.h (struct Lisp_Subr.function.aMANY)
2699 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2700 Arg counts are now ptrdiff_t, not size_t.
2701 All variadic functions and their callers changed accordingly.
2702 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2703 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2704 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2705 * callint.c (Fcall_interactively): Check arg count for overflow,
2706 to avoid potential buffer overrun. Use signed char, not 'int',
2707 for 'varies' array, so that we needn't bother to check its size
2708 calculation for overflow.
2709 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2710 * eval.c (apply_lambda):
2711 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2712 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2713 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2715 * callint.c (Fcall_interactively): Don't use index var as event count.
2717 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2718 * mem-limits.h (SIZE): Remove; no longer used.
2720 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2722 Remove unnecessary casts.
2723 * xterm.c (x_term_init):
2724 * xfns.c (x_set_border_pixel):
2725 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2726 These aren't needed now that we assume ANSI C.
2728 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2729 It's more likely to cause problems (due to unsigned overflow)
2732 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2734 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2736 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2738 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2740 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2742 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2744 GLYPH_CODE_FACE returns EMACS_INT, not int.
2745 * dispextern.h (merge_faces):
2746 * xfaces.c (merge_faces):
2747 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2748 Don't assume EMACS_INT fits in int.
2750 * character.h (CHAR_VALID_P): Remove unused parameter.
2751 * fontset.c, lisp.h, xdisp.c: All uses changed.
2753 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2755 * fns.c (concat): Minor tuning based on overflow analysis.
2756 This doesn't fix any bugs. Use int to hold character, instead
2757 of constantly refetching from Emacs object. Use XFASTINT, not
2758 XINT, for value known to be a character. Don't bother comparing
2759 a single byte to 0400, as it's always less.
2761 * floatfns.c (Fexpt):
2762 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2764 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2767 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2769 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2770 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2771 incorrectly succeed when S was a string, because 4294967386 was
2772 truncated before it was used.
2774 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2775 Otherwise, an out-of-range integer could cause undefined behavior
2778 * composite.c: Use int, not EMACS_INT, for characters.
2779 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2780 EMACS_INT, for values that are known to be in character range.
2781 This doesn't fix any bugs but is the usual style inside Emacs and
2782 may generate better code on 32-bit machines.
2784 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2785 This is for reasons similar to the recent CHAR_STRING fix.
2786 * charset.c (Fencode_char): Check that character arg is actually
2787 a character. Pass an int to ENCODE_CHAR.
2788 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2789 wider than 'int', as a compile-time check to prevent future regressions
2792 * character.c (char_string): Remove unnecessary casts.
2794 Make sure a 64-bit char is never passed to CHAR_STRING.
2795 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2796 by silently ignoring the top 32 bits, allowing some values
2797 that were far too large to be valid characters.
2798 * character.h: Include <verify.h>.
2799 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2800 arguments are no wider than unsigned, as a compile-time check
2801 to prevent future regressions in this area.
2803 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2804 (Fsubst_char_in_region):
2806 * xdisp.c (decode_mode_spec_coding):
2807 Adjust to CHAR_STRING's new requirement.
2808 * editfns.c (Finsert_char, Fsubst_char_in_region):
2809 * fns.c (concat): Check that character args are actually
2810 characters. Without this test, these functions did the wrong
2811 thing with wildly out-of-range values on 64-bit hosts.
2813 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2814 These casts should not be needed on 32-bit hosts, either.
2815 * keyboard.c (read_char):
2816 * lread.c (Fload): Remove casts to unsigned.
2818 * lisp.h (UNSIGNED_CMP): New macro.
2819 This fixes comparison bugs on 64-bit hosts.
2820 (ASCII_CHAR_P): Use it.
2821 * casefiddle.c (casify_object):
2822 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2823 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2824 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2825 * dispextern.h (FACE_FROM_ID):
2826 * keyboard.c (read_char): Use UNSIGNED_CMP.
2828 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2829 not to EMACS_INT, to avoid GCC warning.
2831 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2833 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2834 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2835 isn't needed on 32-bit machines.
2837 * buffer.c (Fgenerate_new_buffer_name):
2838 Use EMACS_INT for count, not int.
2839 (advance_to_char_boundary): Return EMACS_INT, not int.
2841 * data.c (Qcompiled_function): Now static.
2843 * window.c (window_body_lines): Now static.
2845 * image.c (gif_load): Rename local to avoid shadowing.
2847 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2848 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2849 * alloc.c (make_save_value): Integer argument is now of type
2851 (mark_object): Use ptrdiff_t, not int.
2852 * lisp.h (pD): New macro.
2853 * print.c (print_object): Use it.
2855 * alloc.c: Use EMACS_INT, not int, to count objects.
2856 (total_conses, total_markers, total_symbols, total_vector_size)
2857 (total_free_conses, total_free_markers, total_free_symbols)
2858 (total_free_floats, total_floats, total_free_intervals)
2859 (total_intervals, total_strings, total_free_strings):
2860 Now EMACS_INT, not int. All uses changed.
2861 (Fgarbage_collect): Compute overall total using a double, so that
2862 integer overflow is less likely to be a problem. Check for overflow
2863 when converting back to an integer.
2864 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2865 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2866 These were 'int' variables that could overflow on 64-bit hosts;
2867 they were never used, so remove them instead of repairing them.
2868 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2869 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2870 Previously, this ceilinged at INT_MAX, but that doesn't work on
2872 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2874 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2875 (allocate_vectorlike): Check for ptrdiff_t overflow.
2876 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2877 when a (possibly-narrower) signed value would do just as well.
2878 We prefer using signed arithmetic, to avoid comparison confusion.
2880 * alloc.c: Catch some string size overflows that we were missing.
2881 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2882 for convenience in STRING_BYTES_MAX.
2883 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2884 The definition here is exact; the one in lisp.h was approximate.
2885 (allocate_string_data): Check for string overflow. This catches
2886 some instances we weren't catching before. Also, it catches
2887 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2888 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2889 and ptrdiff_t and EMACS_INT are both 64 bits.
2891 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2892 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2893 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2895 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2897 * alloc.c (Fmake_string): Check for out-of-range init.
2899 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2901 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2903 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2905 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2906 xg_get_default_scrollbar_width.
2908 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2909 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2910 (style_changed_cb): Call update_theme_scrollbar_width and call
2911 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2912 all frames (Bug#8505).
2913 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2914 Call gtk_window_set_resizable if HAVE_GTK3.
2915 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2916 and height if HAVE_GTK3 (Bug#8505).
2917 (scroll_bar_width_for_theme): New variable.
2918 (update_theme_scrollbar_width): New function.
2919 (xg_get_default_scrollbar_width): Move code to
2920 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2921 (xg_initialize): Call update_theme_scrollbar_width.
2923 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2925 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2927 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2929 * frame.c (make_frame): Call other_buffer_safely instead of
2932 * window.c (temp_output_buffer_show): Call display_buffer with
2933 second argument Vtemp_buffer_show_specifiers and reset latter
2934 immediately after the call.
2935 (Vtemp_buffer_show_specifiers): New variable.
2936 (auto_window_vscroll_p, next_screen_context_lines)
2937 (Vscroll_preserve_screen_position): Remove leading asterisks from
2940 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2942 Fix minor problems found by GCC 4.6.0 static checking.
2943 * buffer.c (Qclone_number): Remove for now, as it's unused.
2944 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2945 (record_buffer): Remove unused local.
2946 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2947 (set_frame_buffer_list): Remove; unused.
2948 * frame.h (other_visible_frames): Remove decl.
2949 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2950 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2951 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2953 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2954 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2955 Define only if HAVE_GPM.
2956 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2957 (update_hints_inhibit): Remove; never set. All uses removed.
2958 * widgetprv.h (emacsFrameClassRec): Remove decl.
2959 * window.c (delete_deletable_window): Now returns void, since it
2960 wasn't returning anything.
2961 (compare_window_configurations): Remove unused locals.
2962 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2963 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2964 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2965 the same widths as pointers. This follows up on the 2011-05-06 patch.
2966 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2967 * xterm.h: Likewise.
2968 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2970 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2972 * makefile.w32-in: Update dependencies.
2973 (LISP_H): Add lib/intprops.h.
2975 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2977 * image.c (gif_load): Add animation frame delay to the metadata.
2978 (syms_of_image): Use DEFSYM. New symbol `delay'.
2980 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2982 * window.c (delete_deletable_window): Re-add.
2983 (Fset_window_configuration): Rewrite to handle dead buffers and
2984 consequently deletable windows.
2985 (window_tree, Fwindow_tree): Remove. Supply functionality in
2987 (compare_window_configurations): Simplify code.
2989 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2991 * image.c (imagemagick_load_image): Fix type mismatch.
2992 (Fimagemagick_types): Likewise.
2994 * window.h (replace_buffer_in_windows): Declare.
2996 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2998 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2999 Qclone_number. Remove external declaration of Qdelete_window.
3000 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3002 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3003 Run Qbuffer_list_update_hook if allowed.
3004 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3005 buffer list implementation.
3006 (other_buffer_safely): New function.
3007 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3008 calls to replace_buffer_in_windows and
3009 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3011 (record_buffer): Inhibit quitting and rewrite using quittable
3012 functions. Run Qbuffer_list_update_hook if allowed.
3013 (Frecord_buffer, Funrecord_buffer): New functions.
3014 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3015 Move switch-to-buffer to window.el.
3016 (bury-buffer): Move to window.el.
3017 (Vbuffer_list_update_hook): New variable.
3019 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3022 * window.h (resize_frame_windows): Move up in code.
3023 (Fwindow_frame): Remove EXFUN.
3024 (replace_buffer_in_all_windows): Remove prototype.
3025 (replace_buffer_in_windows_safely): Add prototype.
3027 * window.c: Declare Qdelete_window static again. Move down
3028 declaration of select_count.
3029 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3030 (Fother_window): Move to window.el.
3031 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3032 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3033 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3035 (replace_buffer_in_windows): Implement by calling
3036 Qreplace_buffer_in_windows.
3037 (replace_buffer_in_all_windows): Remove with some functionality
3038 moved into replace_buffer_in_windows_safely.
3039 (replace_buffer_in_windows_safely): New function.
3040 (select_window_norecord, select_frame_norecord): Move in front
3041 of run_window_configuration_change_hook. Remove now obsolete
3043 (Fset_window_buffer): Rewrite doc-string.
3044 Call Qrecord_window_buffer.
3045 (keys_of_window): Move binding for other-window to window.el.
3047 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3049 * dispextern.h (struct image): Replace data member, whose int_val
3050 and ptr_val fields were not used by anything, with a single
3053 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3054 (gif_clear_image, gif_load, imagemagick_load_image)
3055 (gs_clear_image, gs_load): Callers changed.
3057 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3059 * buffer.h: Include <time.h>, for time_t.
3060 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3062 Fix minor problems found by static checking.
3064 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3066 Make identifiers static if they are not used in other modules.
3067 * data.c (Qcompiled_function, Qframe, Qvector):
3068 * image.c (QimageMagick, Qsvg):
3069 * minibuf.c (Qmetadata):
3070 * window.c (resize_window_check, resize_root_window): Now static.
3071 * window.h (resize_window_check, resize_root_window): Remove decls.
3073 * window.c (window_deletion_count, delete_deletable_window):
3075 (window_body_lines): Now static.
3076 (Fdelete_other_windows_internal): Mark vars as initialized.
3077 Make sure 'resize_failed' is initialized.
3078 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3079 (resize_window_apply): Remove unused local.
3080 * window.h (delete_deletable_window): Remove decl.
3082 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3083 (imagemagick_load_image): Fix pointer signedness problem by changing
3084 last arg from unsigned char * to char *. All uses changed.
3085 Also, fix a local for similar reasons.
3086 Remove unused locals. Remove locals to avoid shadowing.
3087 (fn_rsvg_handle_free): Remove; unused.
3088 (svg_load, svg_load_image): Fix pointer signedness problem.
3089 (imagemagick_load_image): Don't use garbage pointer image_wand.
3091 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3093 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3095 * image.c (gif_load): Fix omitted cast error introduced by
3098 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3100 * window.h (resize_proportionally, orig_total_lines)
3101 (orig_top_line): Remove from window structure.
3102 (set_window_height, set_window_width, change_window_heights)
3103 (Fdelete_window): Remove prototypes.
3104 (resize_frame_windows): Remove duplicate declaration.
3106 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3108 * window.h (resize_frame_windows, resize_window_check)
3109 (delete_deletable_window, resize_root_window)
3110 (resize_frame_windows): Declare prototypes.
3112 * window.c (resize_window_apply): Make definition be "static" to
3113 match the prototype.
3115 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3117 * window.c: Remove declarations of Qwindow_size_fixed,
3118 window_min_size_1, window_min_size_2, window_min_size,
3119 size_window, window_fixed_size_p, enlarge_window, delete_window.
3120 Remove static from declaration of Qdelete_window, it's
3121 temporarily needed by Fbury_buffer.
3122 (replace_window): Don't assign orig_top_line and
3124 (Fdelete_window, delete_window): Remove. Window deletion is
3125 handled by window.el.
3126 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3127 Replace Fdelete_window calls with calls to Qdelete_window.
3128 (Fdelete_other_windows): Remove. Deleting other windows is
3129 handled by window.el.
3130 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3131 handled in window.el.
3132 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3133 Window minimum sizes are handled in window.el.
3134 (shrink_windows, size_window, set_window_height)
3135 (set_window_width, change_window_heights, window_height)
3136 (window_width, CURBEG, CURSIZE, enlarge_window)
3137 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3138 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3139 handled in window.el.
3140 (make_dummy_parent): Rename to make_parent_window and give it a
3141 second argument horflag.
3142 (make_window): Don't set resize_proportionally any more.
3143 (Fsplit_window): Remove. Windows are split in window.el.
3144 (save_restore_action, save_restore_orig_size)
3145 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3146 Resize mini windows in window.el.
3147 (grow_mini_window, shrink_mini_window): Implement by calling
3148 Qresize_root_window_vertically, resize_window_check and
3149 resize_window_apply.
3150 (saved_window, Fset_window_configuration, save_window_save):
3151 Do not handle orig_top_line, orig_total_lines, and
3152 resize_proportionally.
3153 (window_min_height, window_min_width): Move to window.el.
3154 (keys_of_window): Move bindings for delete-other-windows,
3155 split-window, delete-window and enlarge-window to window.el.
3157 * buffer.c: Temporarily extern Qdelete_window.
3158 (Fbury_buffer): Temporarily call Qdelete_window instead of
3159 Fdelete_window (Fbury_buffer will move to window.el soon).
3161 * frame.c (set_menu_bar_lines_1): Remove code handling
3162 orig_top_line and orig_total_lines.
3164 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3165 set_window_height but set heights directly.
3166 (change_frame_size_1): Use resize_frame_windows.
3168 * xdisp.c (init_xdisp): Don't use set_window_height but set
3171 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3172 Use resize_frame_windows instead of change_window_heights and run
3173 run_window_configuration_change_hook.
3175 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3176 instead of change_window_heights and run
3177 run_window_configuration_change_hook.
3179 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3181 * window.c (replace_window): Rename second argument REPLACEMENT to
3182 NEW. New third argument SETFLAG. Rewrite.
3183 (delete_window, make_dummy_parent): Call replace_window with
3185 (window_list_1): Move down in code.
3186 (run_window_configuration_change_hook): Move set_buffer part
3187 before select_frame_norecord part in order to unwind correctly.
3188 Rename count1 to count.
3189 (recombine_windows, delete_deletable_window, resize_root_window)
3190 (Fdelete_other_windows_internal)
3191 (Frun_window_configuration_change_hook, make_parent_window)
3192 (resize_window_check, resize_window_apply, Fresize_window_apply)
3193 (resize_frame_windows, Fsplit_window_internal)
3194 (Fdelete_window_internal, Fresize_mini_window_internal):
3196 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3198 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3200 * window.h (window): Add some new members to window structure -
3201 normal_lines, normal_cols, new_total, new_normal, clone_number,
3202 splits, nest, prev_buffers, next_buffers.
3203 (WINDOW_TOTAL_SIZE): Move here from window.c.
3204 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3206 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3208 (make_dummy_parent): Set new members of windows structure.
3209 (make_window): Move down in code. Handle new members of window
3211 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3212 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3213 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3214 (Fset_window_prev_buffers, Fwindow_next_buffers)
3215 (Fset_window_next_buffers, Fset_window_clone_number):
3217 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3218 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3220 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3221 Argument WINDOW can be now internal window too.
3222 (Fwindow_use_time): Move up in code.
3223 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3225 (Fset_window_configuration, saved_window)
3226 (Fcurrent_window_configuration, save_window_save): Handle new
3227 members of window structure.
3228 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3229 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3230 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3231 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3232 Qget_mru_window, Qresize_root_window,
3233 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3234 Qauto_buffer_name; staticpro them.
3236 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3238 * window.c (Fwindow_total_size, Fwindow_left_column)
3239 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3240 (Fwindow_list_1): New functions.
3241 (window_box_text_cols): Replace with window_body_cols.
3242 (Fwindow_width, Fscroll_left, Fscroll_right):
3243 Use window_body_cols instead of window_box_text_cols.
3244 (delete_window, Fset_window_configuration):
3245 Call delete_all_subwindows with window as argument.
3246 (delete_all_subwindows): Take a window as argument and not a
3248 (window_loop): Remove handling of GET_LRU_WINDOW and
3250 (Fget_lru_window, Fget_largest_window): Move to window.el.
3252 * window.h: Extern window_body_cols instead of
3253 window_box_text_cols. delete_all_subwindows now takes a
3254 Lisp_Object as argument.
3256 * indent.c (compute_motion, Fcompute_motion):
3257 Use window_body_cols instead of window_box_text_cols.
3259 * frame.c (delete_frame): Call delete_all_subwindows with root
3262 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3264 * fns.c (Fputhash): Document return value.
3266 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3268 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3270 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3272 Cons<->int and similar integer overflow fixes (Bug#8794).
3274 Check for overflow when converting integer to cons and back.
3275 * charset.c (Fdefine_charset_internal, Fdecode_char):
3276 Use cons_to_unsigned to catch overflow.
3277 (Fencode_char): Use INTEGER_TO_CONS.
3278 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3279 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3280 * data.c (long_to_cons, cons_to_long): Remove.
3281 (cons_to_unsigned, cons_to_signed): New functions.
3282 These signal an error for invalid or out-of-range values.
3283 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3284 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3285 * font.c (Ffont_variation_glyphs):
3286 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3287 * lisp.h: Include <intprops.h>.
3288 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3289 (cons_to_signed, cons_to_unsigned): New decls.
3290 (long_to_cons, cons_to_long): Remove decls.
3291 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3292 (Fprimitive_undo): Use CONS_TO_INTEGER.
3293 * xfns.c (Fx_window_property): Likewise.
3294 * xselect.c: Include <limits.h>.
3295 (x_own_selection, selection_data_to_lisp_data):
3296 Use INTEGER_TO_CONS.
3297 (x_handle_selection_request, x_handle_selection_clear)
3298 (x_get_foreign_selection, Fx_disown_selection_internal)
3299 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3300 (lisp_data_to_selection_data): Use cons_to_unsigned.
3301 (x_fill_property_data): Use cons_to_signed.
3302 Report values out of range.
3304 Check for buffer and string overflow more precisely.
3305 * buffer.h (BUF_BYTES_MAX): New macro.
3306 * lisp.h (STRING_BYTES_MAX): New macro.
3307 * alloc.c (Fmake_string):
3308 * character.c (string_escape_byte8):
3309 * coding.c (coding_alloc_by_realloc):
3310 * doprnt.c (doprnt):
3311 * editfns.c (Fformat):
3313 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3314 since they may not be the same number.
3315 * editfns.c (Finsert_char):
3316 * fileio.c (Finsert_file_contents):
3317 Likewise for BUF_BYTES_MAX.
3319 * image.c: Use ptrdiff_t, not int, for sizes.
3320 (slurp_file): Switch from int to ptrdiff_t.
3322 (slurp_file): Check that file size fits in both size_t (for
3323 malloc) and ptrdiff_t (for sanity and safety).
3325 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3326 if b->modtime has its maximal value.
3328 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3330 Don't assume time_t can fit into int.
3331 * buffer.h (struct buffer.modtime): Now time_t, not int.
3332 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3333 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3335 Minor fixes for signed vs unsigned integers.
3336 * character.h (MAYBE_UNIFY_CHAR):
3337 * charset.c (maybe_unify_char):
3338 * keyboard.c (read_char, reorder_modifiers):
3339 XINT -> XFASTINT, since the integer must be nonnegative.
3340 * ftfont.c (ftfont_spec_pattern):
3341 * keymap.c (access_keymap, silly_event_symbol_error):
3342 XUINT -> XFASTINT, since the integer must be nonnegative.
3343 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3344 since it makes no difference and we prefer signed.
3345 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3346 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3349 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3351 * window.h (Fwindow_frame): Declare.
3353 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3355 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3356 (SPARE_MEMORY): Always define.
3357 (LARGE_REQUEST): Remove.
3358 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3360 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3362 * lisp.h: Move EXFUNS for Fframe_root_window,
3363 Fframe_first_window and Fset_frame_selected_window to window.h.
3365 * window.h: Move EXFUNS for Fframe_root_window,
3366 Fframe_first_window and Fset_frame_selected_window here from
3369 * frame.c (Fwindow_frame, Fframe_first_window)
3370 (Fframe_root_window, Fframe_selected_window)
3371 (Fset_frame_selected_window): Move to window.c.
3372 (Factive_minibuffer_window): Move to minibuf.c.
3373 (Fother_visible_frames_p): New function.
3375 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3377 * window.c (decode_window, decode_any_window): Move up in code.
3378 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3379 (inhibit_frame_unsplittable): Remove unused variable.
3380 (Fwindow_buffer): Move up and rewrite doc-string.
3381 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3382 (Fwindow_prev): New functions.
3383 (Fwindow_frame): Move here from frame.c. Accept any window as
3385 (Fframe_root_window, Fframe_first_window)
3386 (Fframe_selected_window): Move here from frame.c. Accept frame
3387 or arbitrary window as argument. Update doc-strings.
3388 (Fminibuffer_window): Move up in code.
3389 (Fwindow_minibuffer_p): Move up in code and simplify.
3390 (Fset_frame_selected_window): Move here from frame.c.
3392 (Fselected_window, select_window, Fselect_window): Move up in
3393 code. Minor doc-string fixes.
3395 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3397 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3398 Do not assume that spare memory exists; that assumption is valid
3399 only if SYSTEM_MALLOC.
3400 (LARGE_REQUEST): New macro, so that the issue of large requests
3401 is separated from the issue of spare memory.
3403 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3405 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3408 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3410 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3413 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3415 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3417 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3419 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3420 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3422 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3424 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3426 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3428 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3429 (x_clipboard_manager_save): Add return value.
3430 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3432 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3433 Obey Vx_select_enable_clipboard_manager. Catch errors in
3434 x_clipboard_manager_save (Bug#8779).
3435 (Vx_select_enable_clipboard_manager): New variable.
3436 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3438 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3440 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3442 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3444 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3445 in the current matrix if keep_current_p is non-zero.
3447 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3449 * bidi.c (bidi_level_of_next_char): Fix last change.
3451 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3453 Support bidi reordering of text covered by display properties.
3455 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3456 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3457 (bidi_cache_search, bidi_cache_iterator_state)
3458 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3459 (bidi_level_of_next_char, bidi_move_to_visually_next):
3460 Support character positions inside a run of characters covered by a
3462 (bidi_paragraph_init, bidi_resolve_explicit_1)
3463 (bidi_level_of_next_char): Call bidi_fetch_char and
3464 bidi_fetch_char_advance instead of FETCH_CHAR and
3466 (bidi_init_it): Initialize new members.
3467 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3469 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3470 instead of using explicit *_CHAR codes.
3471 (bidi_resolve_explicit, bidi_resolve_weak):
3472 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3473 bidirectional text is supported only in multibyte buffers.
3474 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3475 it to initialize the frame_window_p member of struct bidi_it.
3476 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3477 (bidi_resolve_explicit, bidi_resolve_weak)
3478 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3479 bidi_it->nchars is non-positive.
3480 (bidi_level_of_next_char): Don't try to lookup the cache for the
3481 next/previous character if nothing is cached there yet, or if we
3482 were just reseat()'ed to a new position.
3484 * xdisp.c (set_cursor_from_row): Set start and stop points
3485 according to the row's direction when priming the loop that looks
3486 for the glyph on which to display cursor.
3487 (single_display_spec_intangible_p): Function deleted.
3488 (display_prop_intangible_p): Reimplement to call
3489 handle_display_spec instead of single_display_spec_intangible_p.
3490 Accept 3 additional arguments needed by handle_display_spec.
3491 This fixes incorrect cursor motion across display property with complex
3492 values: lists, `(when COND...)' forms, etc.
3493 (single_display_spec_string_p): Support property values that are
3494 lists with the argument STRING its top-level element.
3495 (display_prop_string_p): Fix the condition for processing a
3496 property that is a list to be consistent with handle_display_spec.
3497 (handle_display_spec): New function, refactored from the
3498 last portion of handle_display_prop.
3499 (compute_display_string_pos): Accept additional argument
3500 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3501 value of a `display' property is a "replacing spec".
3502 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3503 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3504 the display property, but just return a value indicating whether
3505 the display property will replace the characters it covers.
3506 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3507 frame_window_p members of struct bidi_it.
3508 (compute_display_string_pos, compute_display_string_end):
3510 (push_it): Accept second argument POSITION, where pop_it should
3511 jump to continue iteration.
3512 (reseat_1): Initialize bidi_it.disp_pos.
3514 * keyboard.c (adjust_point_for_property): Adjust the call to
3515 display_prop_intangible_p to its new signature.
3517 * dispextern.h (struct bidi_it): New member frame_window_p.
3518 (bidi_init_it): Update prototypes.
3519 (display_prop_intangible_p): Update prototype.
3520 (compute_display_string_pos, compute_display_string_end):
3522 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3525 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3527 Malloc failure behavior now depends on size of allocation.
3528 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3529 * lisp.h: Change signatures accordingly.
3530 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3531 All callers changed. (Bug#8762)
3533 * gnutls.c: Use Emacs's memory allocators.
3534 Without this change, the gnutls library would invoke malloc etc.
3535 directly, which causes problems on non-SYNC_INPUT hosts, and which
3536 runs afoul of improving memory_full behavior. (Bug#8761)
3537 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3538 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3539 xfree instead of the default malloc, realloc, free.
3540 (Fgnutls_boot): No need to check for memory allocation failure,
3541 since xmalloc does that for us.
3543 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3544 * category.c (hash_get_category_set):
3545 * ccl.c (ccl_driver):
3546 * charset.c (Fdefine_charset_internal):
3547 * charset.h (struct charset.hash_index):
3548 * composite.c (get_composition_id, gstring_lookup_cache)
3549 (composition_gstring_put_cache):
3550 * composite.h (struct composition.hash_index):
3551 * dispextern.h (struct image.hash):
3552 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3553 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3554 (hashfn_equal, hashfn_user_defined, make_hash_table)
3555 (maybe_resize_hash_table, hash_lookup, hash_put)
3556 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3557 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3558 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3559 * image.c (make_image, search_image_cache, lookup_image)
3560 (xpm_put_color_table_h):
3561 * lisp.h (struct Lisp_Hash_Table):
3562 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3563 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3564 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3565 * alloc.c (allocate_vectorlike):
3566 Check for overflow in vector size calculations.
3567 * ccl.c (ccl_driver):
3568 Check for overflow when converting EMACS_INT to int.
3569 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3570 need to be updated by these changes.
3571 * fns.c (make_hash_table, maybe_resize_hash_table):
3572 Check for integer overflow with large hash tables.
3573 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3574 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3575 (SXHASH_REDUCE): New macro.
3576 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3577 Use it instead of discarding useful hash info with large hash values.
3578 (sxhash_float): New function.
3579 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3580 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3581 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3582 Rewrite to use FIXNUM_BITS, as this simplifies things.
3583 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3584 Adjust signatures to match updated version of code.
3585 (consing_since_gc): Now EMACS_INT, since a single hash table can
3586 use more than INT_MAX bytes.
3588 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3590 Make it possible to build with GCC-4.6+ -O2 -flto.
3592 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3594 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3596 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3597 Call minibuffer-inactive-mode.
3599 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3601 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3602 Update dependencies.
3604 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3606 * data.c (init_data): Remove code for UTS, this system is not
3609 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3611 Don't force ./temacs to start in terminal mode.
3613 * frame.c (make_initial_frame): Initialize faces in all cases, not
3614 only when CANNOT_DUMP is defined.
3615 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3617 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3619 * dispnew.c (add_window_display_history): Use const for the string
3620 pointer. Remove declaration, not needed.
3622 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3624 Use 'inline', not 'INLINE'.
3625 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3626 * alloc.c, fontset.c (INLINE): Remove.
3627 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3628 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3629 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3630 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3631 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3633 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3635 Make it possible to run ./temacs.
3637 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3638 syms_of_callproc does the same thing. Remove test for
3639 "initialized", do it in the caller.
3640 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3642 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3644 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3645 (read_minibuf): Use get_minibuffer.
3646 (syms_of_minibuf): Use DEFSYM.
3647 (Qmetadata): New var.
3648 * data.c (Qbuffer): Don't make it static.
3649 (syms_of_data): Use DEFSYM.
3651 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3653 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3654 (CCL_CODE_MIN): New macro.
3656 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3658 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3660 * eval.c (Qdebug): Now static.
3661 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3662 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3663 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3665 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3667 * image.c: Various fixes to ImageMagick code comments.
3668 (Fimagemagick_types): Doc fix.
3670 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3672 Minor fixes prompted by GCC 4.6.0 warnings.
3674 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3676 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3677 (x_clipboard_manager_save_all): Move extern decl to ...
3678 * xterm.h: ... here, so that it can be checked for consistency.
3680 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3682 * xselect.c (x_clipboard_manager_save_frame)
3683 (x_clipboard_manager_save_all): New functions.
3684 (Fx_clipboard_manager_save): Lisp function deleted.
3686 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3687 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3689 * xterm.h: Update prototype.
3691 2011-05-28 William Xu <william.xwl@gmail.com>
3693 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3696 2011-05-28 Jim Meyering <meyering@redhat.com>
3698 Avoid a sign-extension bug in crypto_hash_function.
3699 * fns.c (to_uchar): Define.
3700 (crypto_hash_function): Use it to convert some newly-signed
3701 variables to unsigned, to avoid sign-extension bugs. For example,
3702 without this change, (md5 "truc") would evaluate to
3703 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3704 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3705 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3707 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3709 Integer overflow fixes.
3711 * dbusbind.c: Serial number integer overflow fixes.
3712 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3713 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3714 to hold a serial number that is too large for a fixnum.
3715 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3716 Check for serial numbers out of range. Decode any serial number
3717 that was so large that it became a float. (Bug#8722)
3719 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3720 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3721 Use XFASTINT rather than XUINT when numbers are nonnegative.
3722 (xd_append_arg, Fdbus_method_return_internal):
3723 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3724 arguments, check that Lisp number is nonnegative, rather than
3725 silently wrapping negative numbers around. (Bug#8722)
3726 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3729 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3731 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3733 ccl: add integer overflow checks
3734 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3735 (IN_INT_RANGE): New macros.
3736 (ccl_driver): Use them to check for integer overflow when
3737 decoding a CCL program. Many of the new checks are whether XINT (x)
3738 fits in int; it doesn't always, on 64-bit hosts. The new version
3739 doesn't catch all possible integer overflows, but it's an
3740 improvement. (Bug#8719)
3742 * alloc.c (make_event_array): Use XINT, not XUINT.
3743 There's no need for unsigned here.
3745 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3746 This follows up to the 2011-05-06 change that substituted uintptr_t
3747 for EMACS_INT. This case wasn't caught back then.
3749 Rework Fformat to avoid integer overflow issues.
3750 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3751 now (part of C89). Include <verify.h>.
3752 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3753 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3754 (Fformat): Avoid the prepass trying to compute sizes; it was only
3755 approximate and thus did not catch overflow reliably. Instead, walk
3756 through the format just once, formatting and computing sizes as we go,
3757 checking for integer overflow at every step, and allocating a larger
3758 buffer as needed. Keep track separately whether the format is
3759 multibyte. Keep only the most-recently calculated precision, rather
3760 than them all. Record whether each argument has been converted to
3761 string. Use EMACS_INT, not int, for byte and char and arg counts.
3762 Support field widths and precisions larger than INT_MAX. Avoid
3763 sprintf's undefined behavior with conversion specifications such as %#d
3764 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3765 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3766 formatting out-of-range floating point numbers with int
3769 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3771 * data.c: Avoid integer truncation in expressions involving floats.
3772 * data.c: Include <intprops.h>.
3773 (arith_driver): When there's an integer overflow in an expression
3774 involving floating point, convert the integers to floating point
3775 so that the resulting value does not suffer from catastrophic
3776 integer truncation. For example, on a 64-bit host (* 4
3777 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3778 Do not rely on undefined behavior after integer overflow.
3780 merge count_size_as_multibyte, parse_str_to_multibyte
3781 * character.c, character.h (count_size_as_multibyte):
3782 Rename from parse_str_to_multibyte; all uses changed.
3783 Check for integer overflow.
3784 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3785 since it's now a duplicate of the other. This is more of
3786 a character than a buffer op, so better that it's in character.c.
3787 * fns.c, print.c: Adjust to above changes.
3789 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3791 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3793 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3795 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3796 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3797 (x_clipboard_manager_save): Now static.
3798 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3800 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3801 (crypto_hash_function): Now static.
3802 Fix pointer signedness problems. Avoid unnecessary initializations.
3804 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3806 * termhooks.h (Vselection_alist): Make it terminal-local.
3808 * terminal.c (create_terminal): Initialize it.
3810 * xselect.c: Support for clipboard managers.
3811 (Vselection_alist): Move to termhooks.h as terminal-local var.
3812 (LOCAL_SELECTION): New macro.
3813 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3814 (symbol_to_x_atom): Remove gratuitous arg.
3815 (x_handle_selection_request, lisp_data_to_selection_data)
3816 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3817 (x_own_selection, x_get_local_selection, x_convert_selection):
3818 New arg, specifying work frame. Use terminal-local Vselection_alist.
3819 (some_frame_on_display): Delete unused function.
3820 (Fx_own_selection_internal, Fx_get_selection_internal)
3821 (Fx_disown_selection_internal, Fx_selection_owner_p)
3822 (Fx_selection_exists_p): New optional frame arg.
3823 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3824 (x_handle_selection_clear): Don't treat other terminals with the
3825 same keyboard specially. Use the terminal-local Vselection_alist.
3826 (x_clear_frame_selections): Use Frun_hook_with_args.
3828 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3830 * xterm.h: Add support for those atoms.
3832 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3834 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3835 (converted_selections, conversion_fail_tag): New global variables.
3836 (x_selection_request_lisp_error): Free the above.
3837 (x_get_local_selection): Remove unnecessary code.
3838 (x_reply_selection_request): Args changed; handle arbitrary array
3839 of converted selections stored in converted_selections.
3840 Separate the XChangeProperty and SelectionNotify steps.
3841 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3842 (x_convert_selection): New function.
3843 (x_handle_selection_event): Simplify.
3844 (x_get_foreign_selection): Don't ignore incoming requests while
3845 waiting for an answer; this will fail when we implement
3846 SAVE_TARGETS, and seems unnecessary anyway.
3847 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3848 (Vx_sent_selection_functions): Doc fix.
3850 2011-05-26 Leo Liu <sdl.web@gmail.com>
3852 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3854 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3856 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3858 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3859 for fringe update if it has periodic bitmap.
3860 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3861 and fringe_bitmap_periodic_p.
3863 * fringe.c (get_fringe_bitmap_data): New function.
3864 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3865 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3866 row. Mark glyph row for fringe update if periodicity changed.
3868 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3869 for fringe update unless it has periodic bitmap.
3871 2011-05-25 Kenichi Handa <handa@m17n.org>
3873 * xdisp.c (get_next_display_element): Set correct it->face_id for
3874 a static composition.
3876 2011-05-24 Leo Liu <sdl.web@gmail.com>
3879 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3881 * fns.c (crypto_hash_function, Fsha1): New function.
3882 (Fmd5): Use crypto_hash_function.
3883 (syms_of_fns): Add Ssha1.
3885 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3887 * gnutls.c: Remove unused macros.
3888 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3889 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3890 Remove macros that are defined and never used.
3891 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3893 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3895 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3896 (Fx_get_selection_internal): Minor cleanup.
3897 (Fx_own_selection_internal): Rename arguments for consistency with
3900 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3902 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3904 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3906 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3908 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3910 * dispnew.c (scrolling_window): Don't exclude the case that the
3911 last enabled row in the desired matrix touches the bottom boundary.
3913 2011-05-21 Glenn Morris <rgm@gnu.org>
3915 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3916 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3917 and add some more files.
3919 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3921 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3922 report_file_error introduced by the change from 2011-05-07.
3924 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3926 * systime.h (Time): Define only if emacs is defined.
3927 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3928 where the include path doesn't have X11/X.h by default. See
3929 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3931 2011-05-20 Kenichi Handa <handa@m17n.org>
3933 * composite.c (find_automatic_composition): Fix previous change.
3935 2011-05-20 Glenn Morris <rgm@gnu.org>
3937 * lisp.mk: New file, split from Makefile.in.
3938 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3939 (shortlisp): Remove.
3940 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3942 2011-05-19 Glenn Morris <rgm@gnu.org>
3944 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3945 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3946 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3947 (lisp): Set the order to that of loadup.el.
3948 (shortlisp): Make it a copy of $lisp.
3949 (SOME_MACHINE_LISP): Remove.
3950 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3951 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3953 2011-05-18 Kenichi Handa <handa@m17n.org>
3955 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3956 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3957 (find_automatic_composition): Mostly rewrite for efficiency.
3959 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3961 * makefile.w32-in: Update dependencies.
3963 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3965 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3966 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3968 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3970 Fix some integer overflow issues, such as string length overflow.
3972 * insdel.c (count_size_as_multibyte): Check for string overflow.
3974 * character.c (lisp_string_width): Check for string overflow.
3975 Use EMACS_INT, not int, for string indexes and lengths; in
3976 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3977 the resulting string length overflows an EMACS_INT; instead,
3978 report a string overflow if no precision given. When checking for
3979 precision exhaustion, use a check that cannot possibly have
3980 integer overflow. (Bug#8675)
3981 * character.h (lisp_string_width): Adjust to new signature.
3983 * alloc.c (string_overflow): New function.
3984 (Fmake_string): Use it. This doesn't change behavior, but saves
3985 a few bytes and will simplify future changes.
3986 * character.c (string_escape_byte8): Likewise.
3987 * lisp.h (string_overflow): New decl.
3989 Fixups, following up to the user-interface timestamp change.
3990 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3991 for UI timestamps, instead of unsigned long.
3992 * msdos.c (mouse_get_pos): Likewise.
3993 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3994 * w32gui.h (Time): Define by including "systime.h" rather than by
3995 declaring it ourselves. (Bug#8664)
3997 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3998 * image.c (clear_image_cache): Likewise.
4000 * term.c (term_mouse_position): Don't assume time_t wraparound.
4002 Be more systematic about user-interface timestamps.
4003 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4004 and sometimes 'EMACS_UINT', to represent these timestamps.
4005 This change causes it to use 'Time' uniformly, as that's what X uses.
4006 This makes the code easier to follow, and makes it easier to catch
4007 integer overflow bugs such as Bug#8664.
4008 * frame.c (Fmouse_position, Fmouse_pixel_position):
4009 Use Time, not unsigned long, for user-interface timestamps.
4010 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4011 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4012 * keyboard.h (last_event_timestamp): Likewise.
4013 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4014 * menu.h (xmenu_show): Likewise.
4015 * term.c (term_mouse_position): Likewise.
4016 * termhooks.h (struct input_event.timestamp): Likewise.
4017 (struct terminal.mouse_position_hook): Likewise.
4018 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4019 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4020 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4021 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4023 * menu.h, termhooks.h: Include "systime.h", for Time.
4025 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4026 Don't assume that the difference between two unsigned long values
4027 can fit into an integer. At this point, we know button_down_time
4028 <= event->timestamp, so the difference must be nonnegative, so
4029 there's no need to cast the result if double-click-time is
4030 nonnegative, as it should be; check that it's nonnegative, just in
4031 case. This bug is triggered when events are more than 2**31 ms
4032 apart (about 25 days). (Bug#8664)
4034 * xselect.c (last_event_timestamp): Remove duplicate decl.
4035 (x_own_selection): Remove needless cast to unsigned long.
4037 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4038 that always fit in int. Use a sentinel instead of a counter, to
4039 avoid a temp and to allay GCC's concerns about possible int overflow.
4040 * frame.h (struct frame): Use int for menu_bar_items_used
4041 instead of EMACS_INT, since it always fits in int.
4043 * menu.c (grow_menu_items): Check for int overflow.
4045 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4047 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4048 Before, the code was not consistent. These values cannot exceed
4049 2**31 - 1 so there's no need to make them unsigned.
4050 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4051 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4052 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4054 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4056 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4057 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4058 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4059 presumably because the widths might not match.
4061 * window.c (size_window): Avoid needless test at loop start.
4063 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4065 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4067 2011-05-12 Drew Adams <drew.adams@oracle.com>
4069 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4071 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4073 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4074 `width' to `bar_area_x' and `bar_area_width', respectively.
4075 (x_scroll_run): Take account of fringe background extension.
4077 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4078 Rename local vars `left' and `width' to `bar_area_x' and
4079 `bar_area_width', respectively.
4080 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4081 background extension.
4083 2011-05-10 Jim Meyering <meyering@redhat.com>
4085 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4087 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4089 * image.c (Finit_image_library): Return t for built-in image types,
4090 like pbm and xbm. (Bug#8640)
4092 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4094 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4096 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4098 * w32console.c (Fset_screen_color): Doc fix.
4099 (Fget_screen_color): New function.
4100 (syms_of_ntterm): Defsubr it.
4102 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4103 unlink the temporary file if Fcall_process didn't create it in the
4105 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4106 child process will be redirected to a file specified with `:file'.
4107 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4108 cue to call_process_cleanup not to close that handle.
4110 2011-05-07 Ben Key <bkey76@gmail.com>
4112 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4113 one of two shell specific rules, either bootstrap-temacs-CMD or
4114 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4115 to the previous implementation of the bootstrap-temacs rule.
4116 The bootstrap-temacs-CMD rule is similar to the previous
4117 implementation of the bootstrap-temacs rule except that it
4118 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4121 These changes, along with some changes to nt/configure.bat,
4122 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4123 earlier fix to add support for --cflags and --ldflags options
4124 that include quotes so that it works whether make uses cmd or
4127 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4129 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4130 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4132 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4133 a string. Handle both cases.
4134 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4135 (Fdbus_register_method): Use Qinvalid_function.
4137 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4139 * makefile.w32-in: Update dependencies.
4140 (LISP_H): Add inttypes.h and stdin.h.
4141 (PROCESS_H): Add unistd.h.
4143 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4145 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4146 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4148 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4150 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4152 * term.c (vfatal): Remove stray call to va_end.
4153 It's not needed and the C Standard doesn't allow it here anyway.
4155 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4156 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4158 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4161 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4163 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4165 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4167 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4169 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4171 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4172 * charset.c (Fdefine_charset_internal): Don't initialize
4173 charset.code_space[15]. The value was garbage, on hosts with
4174 32-bit int (Bug#8600).
4176 * lread.c (read_integer): Be more consistent with string-to-number.
4177 Use string_to_number to do the actual conversion; this avoids
4178 rounding errors and fixes some other screwups. Without this fix,
4179 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4180 (digit_to_number): Move earlier, for benefit of read_integer.
4181 Return -1 if the digit is out of range for the base, -2 if it is
4182 not a digit in any supported base. (Bug#8602)
4184 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4186 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4187 to match comment at start of function. This also removes a
4188 GCC warning about overflow in a 32+64-bit port.
4190 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4192 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4193 Reported by Stefan Monnier in
4194 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4195 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4196 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4198 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4199 (EMACS_UINTPTR): Likewise, with uintptr_t.
4201 * lisp.h: Prefer 64-bit EMACS_INT if available.
4202 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4203 on 32-bit hosts that have 64-bit int, so that they can access
4205 However, temporarily disable this change unless the temporary
4206 symbol WIDE_EMACS_INT is defined.
4208 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4210 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4211 This removes an assumption that EMACS_INT and long are the same
4212 width as pointers. The assumption is true for Emacs porting targets
4213 now, but we want to make other targets possible.
4214 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4215 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4216 In the rest of the code, change types of integers that hold casted
4217 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4218 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4219 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4220 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4221 No need to cast type when ORing.
4222 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4223 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4224 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4225 assume EMACS_INT is the same width as char *.
4226 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4227 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4228 Remove no-longer-needed casts.
4229 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4230 (xg_tool_bar_help_callback, xg_make_tool_item):
4231 Use EMACS_INTPTR to hold an integer
4232 that will be cast to void *; this can avoid a GCC warning
4233 if EMACS_INT is not the same width as void *.
4234 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4235 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4236 (current_message_1, set_message_1):
4237 Use a local to convert to proper width without a cast.
4238 * xmenu.c (dialog_selection_callback): Likewise.
4240 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4241 Also, don't assume VALBITS / RAND_BITS is less than 5,
4242 and don't rely on undefined behavior when shifting a 1 left into
4244 * lisp.h (get_random): Change signature to match.
4246 * lread.c (hash_string): Use size_t, not int, for hash computation.
4247 Normally we prefer signed values; but hashing is special, because
4248 it's better to use unsigned division on hash table sizes so that
4249 the remainder is nonnegative. Also, size_t is the natural width
4250 for hashing into memory. The previous code used 'int', which doesn't
4251 retain enough info to hash well into very large tables.
4252 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4254 * dbusbind.c: Don't possibly lose pointer info when converting.
4255 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4256 Use XPNTR rather than XHASH, so that the high-order bits of
4257 the pointer aren't lost when converting through void *.
4259 * eval.c (Fautoload): Don't double-shift a pointer.
4261 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4263 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4265 * gnutls.c (DEF_GNUTLS_FN):
4266 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4268 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4270 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4273 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4275 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4276 New version that can reserve upto 2GB of heap space.
4278 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4280 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4282 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4284 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4285 `gnutls_certificate_set_x509_key_file'.
4287 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4289 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4290 Update dependencies.
4292 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4294 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4295 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4296 Remove unused parameter `fildes'.
4297 * process.c (read_process_output, send_process): Don't pass it.
4299 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4301 Fix previous change: the library cache is defined in w32.c.
4302 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4303 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4305 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4307 Implement dynamic loading of GnuTLS on Windows.
4309 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4310 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4311 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4314 * gnutls.c (Qgnutls_dll): Define.
4315 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4316 (gnutls_*): Declare function pointers.
4317 (init_gnutls_functions): New function to initialize function pointers.
4318 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4319 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4320 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4321 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4322 (emacs_gnutls_write, emacs_gnutls_read)
4323 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4324 (Fgnutls_available_p): New function.
4325 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4326 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4327 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4329 * image.c: Include w32.h.
4330 (Vimage_type_cache): Delete.
4331 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4332 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4333 (w32_delayed_load): Move to w32.c.
4335 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4337 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4338 (w32_delayed_load): Move from image.c. When loading a library, record
4339 its filename in the :loaded-from property of the library id.
4340 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4341 Initialize and staticpro them.
4342 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4344 * process.c: Include lisp.h before w32.h, not after.
4345 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4346 instead of gnutls_record_check_pending.
4348 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4350 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4352 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4353 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4356 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4358 * xterm.c (x_set_frame_alpha): Do not set property on anything
4359 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4361 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4363 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4365 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4367 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4368 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4369 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4370 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4371 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4372 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4373 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4374 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4375 (Qgnutls_bootprop_callbacks_verify): Make static.
4377 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4379 * callproc.c: Indentation fixup.
4381 * sysdep.c (wait_for_termination_1): Make static.
4382 (wait_for_termination, interruptible_wait_for_termination):
4383 Move after wait_for_termination_1.
4385 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4387 * sysdep.c (interruptible_wait_for_termination): New function
4388 which is like wait_for_termination, but allows keyboard
4391 * callproc.c (Fcall_process): Add (:file "file") as an option for
4393 (Fcall_process_region): Ditto.
4395 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4397 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4398 rather than `XVECTOR (FOO)->size'.
4400 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4401 inttypes.h, as a gnulib replacement is used if it not available in
4404 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4406 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4407 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4408 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4410 * coding.c (coding_alloc_by_realloc): Error out if destination
4411 will grow beyond MOST_POSITIVE_FIXNUM.
4412 (decode_coding_emacs_mule): Abort if there isn't enough place in
4413 charbuf for the composition carryover bytes. Reserve an extra
4414 space for up to 2 characters produced in a loop.
4415 (decode_coding_iso_2022): Abort if there isn't enough place in
4416 charbuf for the composition carryover bytes.
4418 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4420 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4421 aborting when %lld or %lll format is passed.
4422 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4423 %llo or %llx format is passed. (Bug#8545)
4425 * window.c (window_scroll_line_based): Use a marker instead of
4426 simple variables to record original value of point. (Bug#7952)
4428 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4429 produced by %s or %c overflows available buffer space. (Bug#8545)
4431 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4433 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4434 (SIZE_MAX): Move defn after all includes, as they might #define it.
4436 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4438 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4440 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4442 * keyboard.c (Qdelayed_warnings_hook): Define.
4443 (command_loop_1): Run `delayed-warnings-hook'
4444 if Vdelayed_warnings_list is non-nil.
4445 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4446 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4448 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4450 * doprnt.c (doprnt): Don't return value smaller than the buffer
4451 size if the message was truncated. (Bug#8545).
4453 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4455 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4456 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4458 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4460 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4462 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4464 * makefile.w32-in: Update dependencies.
4466 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4468 Improve `doprnt' and its usage. (Bug#8545)
4469 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4470 `format_end'. Remove support for %l as a conversion specifier.
4471 Don't use xrealloc. Improve diagnostics when the %l size modifier
4472 is used. Update the commentary.
4474 * eval.c (verror): Simplify calculation of size_t.
4476 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4479 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4481 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4484 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4486 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4487 This makes this file independent of the recent pseudovector change.
4489 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4491 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4493 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4494 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4495 Remove unused local.
4496 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4498 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4499 GCC 4.6.0 optimizes based on type-based alias analysis.
4500 For example, if b is of type struct buffer * and v of type struct
4501 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4502 != &v->size, and therefore "v->size = 1; b->size = 2; return
4503 v->size;" must therefore return 1. This assumption is incorrect
4504 for Emacs, since it type-puns struct Lisp_Vector * with many other
4505 types. To fix this problem, this patch adds a new type struct
4506 vectorlike_header that documents the constraints on layout of vectors
4507 and pseudovectors, and helps optimizing compilers not get fooled
4508 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4509 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4510 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4512 (XSETPVECTYPE): Rewrite in terms of new macro.
4513 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4514 This is a bit clearer, and further avoids the possibility of
4515 undesirable aliasing.
4516 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4517 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4518 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4519 since Lisp_Subr is a special case (no "next" field).
4520 (ASIZE): Now uses header.size rather than size.
4521 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4522 to avoid the hassle of writing XVECTOR (foo)->header.size.
4523 (struct vectorlike_header): New type.
4524 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4525 object, to help avoid aliasing.
4526 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4527 (SUBRP): Likewise, since Lisp_Subr is a special case.
4528 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4529 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4530 (struct Lisp_Hash_Table): Combine first two members into a single
4531 struct vectorlike_header member. All uses of "size" and "next" members
4532 changed to be "header.size" and "header.next".
4533 * buffer.h (struct buffer): Likewise.
4534 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4535 * frame.h (struct frame): Likewise.
4536 * process.h (struct Lisp_Process): Likewise.
4537 * termhooks.h (struct terminal): Likewise.
4538 * window.c (struct save_window_data, struct saved_window): Likewise.
4539 * window.h (struct window): Likewise.
4540 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4541 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4542 * buffer.c (init_buffer_once): Likewise.
4543 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4545 * process.c (Fformat_network_address): Use local var for size,
4548 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4550 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4551 * data.c (atof): Remove decl; no longer used or needed.
4552 (digit_to_number): Move to lread.c.
4553 (Fstring_to_number): Use new string_to_number function, to be
4554 consistent with how the Lisp reader treats infinities and NaNs.
4555 Do not assume that floating-point numbers represent EMACS_INT
4556 without losing information; this is not true on most 64-bit hosts.
4557 Avoid double-rounding errors, by insisting on integers when
4558 parsing non-base-10 numbers, as the documentation specifies.
4559 * lisp.h (string_to_number): New decl, replacing ...
4560 (isfloat_string): Remove.
4561 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4562 (read1): Do not accept +. and -. as integers; this
4563 appears to have been a coding error. Similarly, do not accept
4564 strings like +-1e0 as floating point numbers. Do not report
4565 overflow for integer overflows unless the base is not 10 which
4566 means we have no simple and reliable way to continue.
4567 Break out the floating-point parsing into a new
4568 function string_to_number, so that Fstring_to_number parses
4569 floating point numbers consistently with the Lisp reader.
4570 (digit_to_number): Move here from data.c. Make it static inline.
4571 (E_CHAR, EXP_INT): Remove, replacing with ...
4572 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4573 (string_to_number): New function, replacing isfloat_string.
4574 This function checks for valid syntax and produces the resulting
4575 Lisp float number too. Rework it so that string-to-number
4576 no longer mishandles examples like "1.0e+". Use strtoumax,
4577 so that overflow for non-base-10 numbers is reported only when
4578 there's no portable and simple way to convert to floating point.
4580 * textprop.c (set_text_properties_1): Rewrite for clarity,
4581 and to avoid GCC warning about integer overflow.
4583 * intervals.h (struct interval): Use EMACS_INT for members
4584 where EMACS_UINT might cause problems. See
4585 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4586 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4587 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4589 (offset_intervals): Tell GCC not to worry about length overflow
4590 when negating a negative length.
4592 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4593 (overrun_check_free): Likewise.
4595 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4596 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4599 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4600 (gnutls_make_error): Rename local to avoid shadowing.
4601 (gnutls_emacs_global_deinit): ifdef out; not used.
4602 (Fgnutls_boot): Use const for pointer to readonly storage.
4603 Comment out unused local. Fix pointer signedness problems.
4605 * lread.c (openp): Don't stuff size_t into an 'int'.
4606 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4607 about possible signed overflow.
4609 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4610 (GDK_KEY_g): Don't define if already defined.
4611 (xg_prepare_tooltip): Avoid pointer signedness problem.
4612 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4614 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4615 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4617 * xfns.c (Fx_window_property): Simplify a bit,
4618 to make a bit faster and to avoid GCC 4.6.0 warning.
4619 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4621 * fns.c (internal_equal): Don't assume size_t fits in int.
4623 * alloc.c (compact_small_strings): Tighten assertion a little.
4625 Replace pEd with more-general pI, and fix some printf arg casts.
4626 * lisp.h (pI): New macro, generalizing old pEd macro to other
4627 conversion specifiers. For example, use "...%"pI"d..." rather
4628 than "...%"pEd"...".
4629 (pEd): Remove. All uses replaced with similar uses of pI.
4630 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4631 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4632 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4633 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4634 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4635 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4636 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4638 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4639 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4640 * print.c (safe_debug_print, print_object): Likewise.
4641 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4643 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4644 avoiding the 0 flag, which is not portable.
4645 * process.c (Fmake_network_process): Use pI to avoid cast.
4646 * region-cache.c (pp_cache): Likewise.
4647 * xdisp.c (decode_mode_spec): Likewise.
4648 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4649 behavior on 64-bit hosts with printf arg.
4650 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4651 (x_stop_queuing_selection_requests): Likewise.
4652 (x_get_window_property): Don't truncate byte count to an 'int'
4655 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4656 here, since it parses constructs like leading '-' and spaces,
4657 which are not wanted; and it overflows with large numbers.
4658 Instead, simply match F[0-9]+, which is what is wanted anyway.
4660 * alloc.c: Remove unportable assumptions about struct layout.
4661 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4662 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4663 (allocate_vectorlike, make_pure_vector): Use the new macros,
4664 plus offsetof, to remove unportable assumptions about struct layout.
4665 These assumptions hold on all porting targets that I know of, but
4666 they are not guaranteed, they're easy to remove, and removing them
4667 makes further changes easier.
4669 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4670 This doesn't fix a bug but makes the code clearer.
4671 (string_overrun_cookie): Now const. Use initializers that
4672 don't formally overflow signed char, to avoid warnings.
4673 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4674 can cause Emacs to crash when string overrun checking is enabled.
4675 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4676 multiple of sizeof (EMACS_INT); it need not be, if
4677 alignof(EMACS_INT) < sizeof (EMACS_INT).
4678 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4680 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4682 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4684 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4686 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4687 supposed to be handshaking. (Bug#8556)
4688 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4690 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4692 * lisp.h (Qdebug): List symbol.
4693 * eval.c (Qdebug): Restore global linkage.
4694 * keyboard.c (debug-on-event): New variable.
4695 (handle_user_signal): Break into debugger when debug-on-event
4696 matches the current signal symbol.
4698 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4700 * alloc.c (check_sblock, check_string_bytes)
4701 (check_string_free_list): Convert to standard C.
4703 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4705 * w32.c (emacs_gnutls_push): Fix typo.
4707 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4709 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4710 "cast to pointer from integer of different size".
4712 Improve doprnt and its use in verror. (Bug#8545)
4713 * doprnt.c (doprnt): Document the set of format control sequences
4714 supported by the function. Use SAFE_ALLOCA instead of always
4717 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4718 is one byte too soon. Don't use xrealloc; instead xfree and
4721 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4723 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4726 * gnutls.c: Renamed global_initialized to
4727 gnutls_global_initialized. Added internals for the
4728 :verify-hostname-error, :verify-error, and :verify-flags
4729 parameters of `gnutls-boot' and documented those parameters in the
4730 docstring. Start callback support.
4731 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4732 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4733 on error. Return error code.
4734 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4735 (emacs_gnutls_read): Likewise.
4736 (Fgnutls_boot): Return handshake error code.
4737 (emacs_gnutls_handle_error): New function.
4738 (wsaerror_to_errno): Likewise.
4740 * w32.h (emacs_gnutls_pull): Add prototype.
4741 (emacs_gnutls_push): Likewise.
4743 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4744 (emacs_gnutls_push): Likewise.
4746 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4748 * process.c (wait_reading_process_output): Check if GnuTLS
4749 buffered some data internally if no FDs are set for TLS
4752 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4753 (LIBS): Link to USER_LIBS.
4754 ($(BLD)/gnutls.$(0)): New target.
4756 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4758 * xdisp.c (handle_single_display_spec): Rename the
4759 display_replaced_before_p argument into display_replaced_p, to
4760 make it consistent with the commentary. Fix typos in the
4763 * textprop.c (syms_of_textprop): Remove dead code.
4764 (copy_text_properties): Delete obsolete commentary about an
4765 interface that was deleted long ago. Fix typos in the description
4768 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4769 to changes in oldXMenu/XMenu.h from 2011-04-16.
4770 <menu_help_message, prev_menu_help_message>: Constify.
4771 (IT_menu_make_room): menu->help_text is now `const char **';
4774 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4775 to changes in oldXMenu/XMenu.h from 2011-04-16.
4776 (struct XMenu): Declare `help_text' `const char **'.
4778 * xfaces.c <Qunspecified>: Make extern again.
4780 * syntax.c: Include sys/types.h before including regex.h, as
4783 * doc.c (get_doc_string): Improve the format passed to `error'.
4785 * doprnt.c (doprnt): Improve commentary.
4787 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4789 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4792 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4793 changes in globals.h immediately force recompilation.
4794 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4795 $(CURDIR)/s/ms-w32.h.
4796 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4798 * character.c (Fchar_direction): Function deleted.
4799 (syms_of_character): Don't defsubr it.
4800 <char-direction-table>: Deleted.
4802 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4804 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4805 * doprnt.c: Include limits.h.
4806 (SIZE_MAX): New macro.
4807 (doprnt): Return a size_t value. 2nd arg is now size_t.
4808 Many local variables are now size_t instead of int or unsigned.
4809 Improve overflow protection. Support `l' modifier for integer
4810 conversions. Support %l conversion. Don't assume an EMACS_INT
4811 argument for integer conversions and for %c.
4813 * lisp.h (doprnt): Restore prototype.
4815 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4818 * Makefile.in (base_obj): Add back doprnt.o.
4820 * deps.mk (doprnt.o): Add back prerequisites.
4821 (callint.o): Depend on character.h.
4823 * eval.c (internal_lisp_condition_case): Include the handler
4824 representation in the error message.
4825 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4826 when breaking from the loop.
4828 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4830 * callint.c (Fcall_interactively): When displaying error message
4831 about invalid control letter, pass the character's codepoint, not
4832 a pointer to its multibyte form. Improve display of the character
4833 in octal and display also its hex code.
4835 * character.c (char_string): Use %x to display the (unsigned)
4836 codepoint of an invalid character, to avoid displaying a bogus
4839 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4840 `error', not SYMBOL_NAME itself.
4842 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4843 character arguments to `error'.
4845 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4846 to `error' in error message about FINAL_CHAR argument. Make sure
4847 FINAL_CHAR is a character, and use %c when it is passed as
4848 argument to `error'.
4850 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4852 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4854 * w32.c: Include <time.h>.
4855 (sys_localtime): New function.
4857 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4859 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4861 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4863 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4865 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4868 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4870 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4871 gl_state.e_property when gl_state.object is Qt.
4873 * insdel.c (make_gap_larger): Remove limitation of buffer size
4876 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4878 * xdisp.c (lookup_glyphless_char_display)
4879 (produce_glyphless_glyph): Handle cons cell entry in
4880 glyphless-char-display.
4881 (Vglyphless_char_display): Document it.
4883 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4884 glyphless-char-display.
4886 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4888 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4890 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4892 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4893 definition for no-X builds.
4895 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4897 Static checks with GCC 4.6.0 and non-default toolkits.
4899 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4901 * process.c (keyboard_bit_set): Define only if SIGIO.
4902 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4903 (send_process): Repair possible setjmp clobbering.
4905 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4907 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4909 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4911 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4912 Define only if needed.
4914 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4915 by pacifying GCC about it. Maybe it's time to retire it?
4916 * xfaces.c (USG, __TIMEVAL__): Likewise.
4918 * dispextern.h (struct redisplay_interface): Rename param
4920 * termhooks.h (struct terminal): Likewise.
4921 * xterm.c (xembed_send_message): Likewise.
4923 * insdel.c (make_gap_smaller): Define only if
4924 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4926 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4929 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4930 so that we aren't warned about unused symbols.
4932 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4934 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4936 * xfns.c (x_real_positions): Mark locals as initialized.
4938 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4940 * xterm.c: Fix problems found by static analysis with other toolkits.
4941 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4942 (x_dispatch_event): Declare static if USE_GTK, and
4943 define if USE_GTK || USE_X_TOOLKIT.
4944 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4945 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4946 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4947 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4949 * xmenu.c (menu_help_callback): Pointer type fixes.
4950 Use const pointers when pointing at readonly data. Avoid pointer
4952 (FALSE): Remove unused macro.
4953 (update_frame_menubar): Remove unused decl.
4955 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4957 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4958 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4959 (single_menu_item): Rename local to avoid shadowing.
4961 * keyboard.c (make_lispy_event): Remove unused local var.
4963 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4964 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4966 * bitmaps: Change bitmaps from unsigned char back to the X11
4967 compatible char. Avoid the old compiler warnings about
4968 out-of-range initializers by using, for example, '\xab' rather
4971 * xgselect.c (xgselect_initialize): Check vs interface
4972 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4974 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4976 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4977 to read-only memory.
4979 * fns.c (vector): Remove; this old hack is no longer needed.
4981 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4983 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4985 * xrdb.c (x_load_resources): Omit unused local.
4987 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4988 (x_window): Rename locals to avoid shadowing.
4989 (USG): Use the kludged USG macro, to pacify gcc.
4991 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4992 (x_term_init): Remove local to avoid shadowing.
4994 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4996 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4997 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4999 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5001 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5003 Fix regex.c, syntax.c and friends for buffers > 2GB.
5004 * syntax.h (struct gl_state_s): Declare character position members
5007 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5009 * textprop.c (verify_interval_modification, interval_of):
5010 Declare arguments EMACS_INT.
5012 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5015 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5017 * indent.c (Fvertical_motion): Local variable it_start is now
5020 * regex.c (re_match, re_match_2, re_match_2_internal)
5021 (bcmp_translate, regcomp, regexec, print_double_string)
5022 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5023 (re_compile_pattern, re_exec): Declare arguments and local
5024 variables `size_t' and `ssize_t' and return values `regoff_t', as
5026 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5027 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5028 <compile_stack_type>: `size' and `avail' are now `size_t'.
5030 * regex.h <regoff_t>: Use ssize_t, not int.
5031 (re_search, re_search_2, re_match, re_match_2): Arguments that
5032 specify buffer/string position and length are now ssize_t and
5033 size_t. Return type is regoff_t.
5035 2011-04-16 Ben Key <bkey76@gmail.com>
5037 * nsfont.m: Fixed bugs in ns_get_family and
5038 ns_descriptor_to_entity that were caused by using free to
5039 deallocate memory blocks that were allocated by xmalloc (via
5040 xstrdup). This caused Emacs to crash when compiled with
5041 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5042 --enable-checking=xmallocoverrun). xfree is now used to
5043 deallocate these memory blocks.
5045 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5047 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5049 emacs_write: Accept and return EMACS_INT for sizes.
5050 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5052 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5053 Accept and return EMACS_INT.
5054 (emacs_gnutls_write): Return the number of bytes written on
5056 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5057 (emacs_read, emacs_write): Remove check for negative size, as the
5058 Emacs source code has been audited now.
5059 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5060 (emacs_read, emacs_write): Use it.
5061 * process.c (send_process): Adjust to the new signatures of
5062 emacs_write and emacs_gnutls_write. Do not attempt to store
5063 a byte offset into an 'int'; it might overflow.
5064 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5066 * sound.c: Don't assume sizes fit in 'int'.
5067 (struct sound_device.period_size, alsa_period_size):
5068 Return EMACS_INT, not int.
5069 (struct sound_device.write, vox_write, alsa_write):
5070 Accept EMACS_INT, not int.
5071 (wav_play, au_play): Use EMACS_INT to store sizes and to
5072 record read return values.
5074 2011-04-15 Ben Key <bkey76@gmail.com>
5076 * keyboard.c (Qundefined): Don't declare static since it is used
5078 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5079 static since they are used in nsfont.m.
5081 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5083 * process.c (Qprocessp): Don't declare static.
5084 * lisp.h (Qprocessp): Declare again.
5086 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5088 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5090 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5092 Improve C-level modularity by making more things 'static'.
5094 Don't publish debugger-only interfaces to other modules.
5095 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5096 (verify_bytepos, count_markers): Move decls to the only modules
5098 * region-cache.h (pp_cache): Likewise.
5099 * window.h (check_all_windows): Likewise.
5100 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5102 * sysdep.c (croak): Now static, if
5103 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5104 * syssignal.h (croak): Declare only if not static.
5106 * alloc.c (refill_memory_reserve): Now static if
5107 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5108 * lisp.h (refill_memory_reserve): Declare only if not static.
5110 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5111 Define only if USE_LUCID.
5113 * xrdb.c (x_customization_string, x_rm_string): Now static.
5115 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5116 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5118 * xdisp.c (draw_row_with_mouse_face): Now static.
5119 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5121 * window.h (check_all_windows): Mark externally visible.
5123 * window.c (window_deletion_count): Now static.
5125 * undo.c: Make symbols static if they're not exported.
5126 (last_undo_buffer, last_boundary_position, pending_boundary):
5129 * textprop.c (interval_insert_behind_hooks): Now static.
5130 (interval_insert_in_front_hooks): Likewise.
5132 * term.c: Make symbols static if they're not exported.
5133 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5134 (max_frame_lines, tty_set_terminal_modes):
5135 (tty_reset_terminal_modes, tty_turn_off_highlight):
5136 (get_tty_terminal): Now static.
5137 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5138 * termhooks.h (term_mouse_moveto): Do not declare if
5140 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5141 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5143 * sysdep.c: Make symbols static if they're not exported.
5144 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5146 (sigprocmask_set, full_mask): Remove; unused.
5147 (wait_debugging): Mark as visible.
5148 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5149 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5151 * syntax.c (syntax_temp): Define only if !__GNUC__.
5153 * sound.c (current_sound_device, current_sound): Now static.
5155 * search.c (searchbufs, searchbuf_head): Now static.
5157 * scroll.c (scroll_cost): Remove; unused.
5158 * dispextern.h (scroll_cost): Remove decl.
5160 * region-cache.h (pp_cache): Mark as externally visible.
5162 * process.c: Make symbols static if they're not exported.
5163 (process_tick, update_tick, create_process, chan_process):
5164 (Vprocess_alist, proc_buffered_char, datagram_access):
5165 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5166 (deactivate_process): Mark defn as static, as well as decl.
5167 * lisp.h (create_process): Remove decl.
5168 * process.h (chan_process, Vprocess_alist): Remove decls.
5170 * print.c: Make symbols static if they're not exported.
5171 (print_depth, new_backquote_output, being_printed, print_buffer):
5172 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5173 (print_interval, print_number_index, initial_stderr_stream):
5175 * lisp.h (Fprinc): Remove decl.
5176 (debug_output_compilation_hack): Mark as externally visible.
5178 * sysdep.c (croak): Move decl from here to syssignal.h.
5179 * syssignal.h (croak): Put it here, so the API can be checked when
5180 'croak' is called from dissociate_if_controlling_tty.
5182 * minibuf.c: Make symbols static if they're not exported.
5183 (minibuf_save_list, choose_minibuf_frame): Now static.
5184 * lisp.h (choose_minibuf_frame): Remove decl.
5186 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5188 * lread.c: Make symbols static if they're not exported.
5189 (read_objects, initial_obarray, oblookup_last_bucket_number):
5191 (make_symbol): Remove; unused.
5192 * lisp.h (initial_obarray, make_symbol): Remove decls.
5194 * keyboard.c: Make symbols static if they're not exported.
5195 (single_kboard, recent_keys_index, total_keys, recent_keys):
5196 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5197 (this_single_command_key_start, echoing, last_auto_save):
5198 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5199 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5200 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5201 (Vlispy_mouse_stem, double_click_count):
5203 (force_auto_save_soon): Define only if SIGDANGER.
5204 (ignore_mouse_drag_p): Now static if
5205 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5206 (print_help): Remove; unused.
5207 (stop_character, last_timer_event): Mark as externally visible.
5208 * keyboard.h (ignore_mouse_drag_p): Declare only if
5209 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5210 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5211 * lisp.h (echoing): Remove decl.
5212 (force_auto_save_soon): Declare only if SIGDANGER.
5213 * xdisp.c (redisplay_window): Simplify code, to make it more
5214 obvious that ignore_mouse_drag_p is not accessed if !defined
5215 USE_GTK && !defined HAVE_NS.
5217 * intervals.c: Make symbols static if they're not exported.
5218 (merge_properties_sticky, merge_interval_right, delete_interval):
5220 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5222 * insdel.c: Make symbols static if they're not exported.
5223 However, leave prepare_to_modify_buffer alone. It's never
5224 called from outside this function, but that appears to be a bug.
5225 (combine_after_change_list, combine_after_change_buffer):
5226 (adjust_after_replace, signal_before_change): Now static.
5227 (adjust_after_replace_noundo): Remove; unused.
5228 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5229 (signal_before_change): Remove decls.
5231 * indent.c (val_compute_motion, val_vmotion): Now static.
5233 * image.c: Make symbols static if they're not exported.
5234 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5236 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5237 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5239 * fringe.c (standard_bitmaps): Now static.
5240 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5242 * frame.c: Make symbols static if they're not exported.
5243 (x_report_frame_params, make_terminal_frame): Now static.
5244 (get_frame_param): Now static, unless HAVE_NS.
5245 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5246 (x_get_resource_string): Remove; not used.
5247 * frame.h (make_terminal_frame, x_report_frame_params):
5248 (x_get_resource_string); Remove decls.
5249 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5250 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5252 * font.c, fontset.c: Make symbols static if they're not exported.
5253 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5254 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5255 * font.c (font_close_object): Now static.
5256 * font.h (font_close_object): Remove.
5257 * fontset.c (FONTSET_OBJLIST): Remove.
5258 (free_realized_fontset) #if-0 the body, which does nothing.
5259 (face_suitable_for_char_p): #if-0, as it's never called.
5260 * fontset.h (face_suitable_for_char_p): Remove decl.
5261 * xfaces.c (face_at_string_position):
5262 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5263 since 0 is always ASCII.
5265 * fns.c (weak_hash_tables): Now static.
5267 * fileio.c: Make symbols static if they're not exported.
5268 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5269 (Vwrite_region_annotation_buffers): Now static.
5271 * eval.c: Make symbols static if they're not exported.
5272 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5273 * lisp.h (backtrace_list): Remove decl.
5275 * emacs.c: Make symbols static if they're not exported.
5276 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5277 (fatal_error_code, fatal_error_signal_hook, standard_args):
5279 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5280 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5281 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5282 * lisp.h (fatal_error_signal_hook): Remove decl.
5283 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5285 * editfns.c: Move a (normally-unused) function to its only use.
5286 * editfns.c, lisp.h (get_operating_system_release): Remove.
5287 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5288 worth the hassle of breaking this out.
5290 * xterm.c: Make symbols static if they're not exported.
5291 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5292 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5293 (x_destroy_window, x_delete_display):
5295 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5296 (x_mouse_leave): Remove; unused.
5297 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5298 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5299 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5301 (x_mouse_leave): Declare only if WINDOWSNT.
5302 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5303 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5306 * ftxfont.c: Make symbols static if they're not exported.
5307 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5309 * font.h (ftxfont_driver): Likewise.
5311 * xfns.c: Make symbols static if they're not exported.
5312 (x_last_font_name, x_display_info_for_name):
5313 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5314 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5315 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5316 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5317 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5318 (last_show_tip_args): Now static.
5319 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5320 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5321 (x_screen_planes): Remove; unused.
5322 * dispextern.h (x_screen_planes): Remove decl.
5324 * dispnew.c: Make symbols static if they're not exported.
5325 * dispextern.h (redraw_garbaged_frames, scrolling):
5326 (increment_row_positions): Remove.
5327 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5328 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5330 (redraw_garbaged_frames): Remove; unused.
5332 * xfaces.c: Make symbols static if they're not exported.
5333 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5335 * xterm.h (defined_color): Remove decls.
5336 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5337 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5338 (menu_face_changed_default, defined_color, free_realized_face):
5339 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5340 (ascii_face_of_lisp_face): Remove; unused.
5342 * xdisp.c: Make symbols static if they're not exported.
5343 * dispextern.h (scratch_glyph_row, window_box_edges):
5344 (glyph_to_pixel_coords, set_cursor_from_row):
5345 (get_next_display_element, set_iterator_to_next):
5346 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5347 (show_mouse_face): Remove decls
5348 * frame.h (message_buf_print): Likewise.
5349 * lisp.h (pop_message, set_message, check_point_in_composition):
5351 * xterm.h (set_vertical_scroll_bar): Likewise.
5352 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5353 (message_buf_print, scratch_glyph_row, displayed_buffer):
5354 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5355 (get_next_display_element, show_mouse_face, window_box_edges):
5356 (frame_to_window_pixel_xy, check_point_in_composition):
5357 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5358 (glyph_to_pixel_coords): Remove; unused.
5360 * dired.c (file_name_completion): Now static.
5362 * dbusbind.c (xd_in_read_queued_messages): Now static.
5364 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5365 * data.c (circular_list_error): Remove.
5367 * commands.h (last_point_position, last_point_position_buffer):
5368 (last_point_position_window): Remove decls.
5369 * keyboard.c: Make these variables static.
5371 * coding.h (coding, code_convert_region, encode_coding_gap):
5373 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5374 (iso_code_class, detect_coding, code_convert_region): Now static.
5375 (encode_coding_gap): Remove; unused.
5377 * chartab.c (chartab_chars, chartab_bits): Now static.
5379 * charset.h (charset_iso_8859_1): Remove decl.
5380 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5383 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5384 * ccl.c (Vccl_program_table): Now static.
5385 (check_ccl_update): Remove; unused.
5387 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5388 * category.h: ... from here.
5389 * category.c (check_category_table, set_category_set): Now static.
5391 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5392 * lisp.h: Remove these decls.
5394 * buffer.c (buffer_count): Remove unused var.
5396 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5397 so that it's not optimized away.
5398 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5399 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5400 exported only to the debugger.
5402 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5403 * atimer.h (run_all_atimers): Remove; not exported.
5405 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5406 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5407 was inaccessible from Lisp.
5408 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5409 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5411 alloc.c: Import and export fewer symbols, and remove unused items.
5412 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5414 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5415 it's not optimized away by whole-program optimization.
5416 (message_enable_multibyte, free_misc): Remove.
5417 (catchlist, handlerlist, mark_backtrace):
5418 Declare only if BYTE_MARK_STACK.
5419 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5420 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5421 (message_enable_multibyte): Remove decl.
5422 (free_misc, interval_free_list, float_block, float_block_index):
5423 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5424 (cons_free_list, last_marked_index):
5426 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5427 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5428 (mark_backtrace): Define only if BYTE_MARK_STACK.
5429 * xdisp.c (message_enable_multibyte): Now static.
5431 Declare Lisp_Object Q* variables to be 'static' if not exported.
5432 This makes it easier for human readers (and static analyzers)
5433 to see whether these variables are used from other modules.
5434 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5435 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5436 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5437 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5438 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5439 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5440 * xmenu.c, xselect.c:
5441 Declare Q* vars static if they are not used in other modules.
5442 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5443 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5444 Remove decls of unexported vars.
5445 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5447 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5449 Make Emacs functions such as Fatom 'static' by default.
5450 This makes it easier for human readers (and static analyzers)
5451 to see whether these functions can be called from other modules.
5452 DEFUN now defines a static function. To make the function external
5453 so that it can be used in other C modules, use the new macro DEFUE.
5454 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5455 (Finit_image_library):
5456 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5457 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5458 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5459 Remove decls, since these functions are now static.
5460 (Funintern, Fget_internal_run_time): New decls, since these functions
5461 were already external.
5463 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5464 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5465 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5466 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5467 * keyboard.c, keymap.c, lread.c:
5468 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5469 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5470 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5471 Mark functions with DEFUE instead of DEFUN,
5472 if they are used in other modules.
5473 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5474 decls for now-static functions.
5475 * buffer.h (Fdelete_overlay): Remove decl.
5476 * callproc.c (Fgetenv_internal): Mark as internal.
5477 * composite.c (Fremove_list_of_text_properties): Remove decl.
5478 (Fcomposition_get_gstring): New forward static decl.
5479 * composite.h (Fcomposite_get_gstring): Remove decl.
5480 * dired.c (Ffile_attributes): New forward static decl.
5481 * doc.c (Fdocumntation_property): New forward static decl.
5482 * eval.c (Ffetch_bytecode): New forward static decl.
5483 (Funintern): Remove extern decl; now in .h file where it belongs.
5484 * fileio.c (Fmake_symbolic_link): New forward static decl.
5485 * image.c (Finit_image_library): New forward static decl.
5486 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5487 * intervals.h (Fprevious_property_change):
5488 (Fremove_list_of_text_properties): Remove decls.
5489 * keyboard.c (Fthis_command_keys): Remove decl.
5490 (Fcommand_execute): New forward static decl.
5491 * keymap.c (Flookup_key): New forward static decl.
5492 (Fcopy_keymap): Now static.
5493 * keymap.h (Flookup_key): Remove decl.
5494 * process.c (Fget_process): New forward static decl.
5495 (Fprocess_datagram_address): Mark as internal.
5496 * syntax.c (Fsyntax_table_p): New forward static decl.
5497 (skip_chars): Remove duplicate decl.
5498 * textprop.c (Fprevious_property_change): New forward static decl.
5499 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5501 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5502 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5504 * editfns.c (Fformat): Remove unreachable code.
5506 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5508 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5511 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5513 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5514 when at ZV. (Bug#8487)
5516 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5518 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5520 * keyboard.c (parse_tool_bar_item): Likewise.
5521 * sound.c (sound_cleanup, alsa_close): Likewise.
5522 * termcap.c (tgetent): Likewise.
5523 * xfns.c (x_default_font_parameter): Likewise.
5524 * xsettings.c (read_and_apply_settings): Likewise.
5526 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5527 (overrun_check_free): Protoize.
5529 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5531 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5532 since callers should never pass a negative size.
5533 Change the signature to match that of plain 'read' and 'write'; see
5534 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5535 * lisp.h: Update prototypes of emacs_write and emacs_read.
5537 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5539 * xdisp.c (redisplay_window): Don't try to determine the character
5540 position of the scroll margin if the window start point w->startp
5541 is outside the buffer's accessible region. (Bug#8468)
5543 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5545 Fix write-region and its subroutines for buffers > 2GB.
5546 * fileio.c (a_write, e_write): Modify declaration of arguments and
5547 local variables to support buffers larger than 2GB.
5548 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5550 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5551 argument, local variables, and return value.
5553 * lisp.h: Update prototypes of emacs_write and emacs_read.
5555 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5557 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5559 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5561 Fix more problems found by GCC 4.6.0's static checks.
5563 * xdisp.c (vmessage): Use a better test for character truncation.
5565 * charset.c (load_charset_map): <, not <=, for optimization,
5566 and to avoid potential problems with integer overflow.
5567 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5568 * casetab.c (set_identity, shuffle): Likewise.
5569 * editfns.c (Fformat): Likewise.
5570 * syntax.c (skip_chars): Likewise.
5572 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5573 This also lets GCC 4.6.0 generate slightly better loop code.
5575 * callint.c (Fcall_interactively): <, not <=, for optimization.
5576 (Fcall_interactively): Count the number of arguments produced,
5577 not the number of arguments given. This is simpler and lets GCC
5578 4.6.0 generate slightly better code.
5580 * ftfont.c: Distingish more carefully between FcChar8 and char.
5581 The previous code passed unsigned char * to a functions like
5582 strlen and xstrcasecmp that expect char *, which does not
5583 conform to the C standard.
5584 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5585 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5586 char * when the C standard requires it.
5588 * keyboard.c (read_char): Remove unused var.
5590 * eval.c: Port to Windows vsnprintf (Bug#8435).
5592 (SIZE_MAX): Define if the headers do not.
5593 (verror): Do not give up if vsnprintf returns a negative count.
5594 Instead, grow the buffer. This ports to Windows vsnprintf, which
5595 does not conform to C99. Problem reported by Eli Zaretskii.
5596 Also, simplify the allocation scheme, by avoiding the need for
5597 calling realloc, and removing the ALLOCATED variable.
5599 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5601 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5602 But keep the doprint source code for now, as we might revamp it
5603 and use it again (Bug#8435).
5604 * lisp.h (doprnt): Remove.
5605 * Makefile.in (base_obj): Remove doprnt.o.
5606 * deps.mk (doprnt.o): Remove.
5608 error: Print 32- and 64-bit integers portably (Bug#8435).
5609 Without this change, on typical 64-bit hosts error ("...%d...", N)
5610 was used to print both 32- and 64-bit integers N, which relied on
5612 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5614 * lisp.h (error, verror): Mark as printf-like functions.
5615 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5616 Report overflow in size calculations when allocating printf buffer.
5617 Do not truncate output string at its first null byte.
5618 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5619 Truncate the output at a character boundary, since vsnprintf does not
5621 * charset.c (check_iso_charset_parameter): Convert internal
5622 character to string before calling 'error', since %c now has the
5624 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5625 overflow when computing char to be passed to 'error'. Do not
5626 pass Lisp_Object to 'error'; pass the integer instead.
5627 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5628 formatted with plain %d.
5630 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5632 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5634 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5636 * xterm.c (x_catch_errors): Remove duplicate declaration.
5638 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5640 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5642 2011-04-10 Jim Meyering <meyering@redhat.com>
5644 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5645 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5646 return ssize_t not "int", and use size_t as the buffer length.
5647 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5648 * gnutls.h: Update declarations.
5649 * process.c (read_process_output): Use ssize_t, to match.
5650 (send_process): Likewise.
5652 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5654 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5656 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5658 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5659 Use unsigned char, to match FcChar8 type definition.
5661 * xterm.c (handle_one_xevent):
5662 * xmenu.c (create_and_show_popup_menu):
5663 * xselect.c (x_decline_selection_request)
5664 (x_reply_selection_request): Avoid type-punned deref of X events.
5666 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5668 Fix some uses of `int' instead of EMACS_INT.
5669 * search.c (string_match_1, fast_string_match)
5670 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5671 (scan_buffer, find_next_newline_no_quit)
5672 (find_before_next_newline, search_command, Freplace_match)
5673 (Fmatch_data): Make some `int' variables be EMACS_INT.
5675 * xdisp.c (display_count_lines): 3rd argument and return value now
5676 EMACS_INT. All callers changed.
5677 (pint2hrstr): Last argument is now EMACS_INT.
5679 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5680 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5681 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5682 (decode_coding_utf_16, decode_coding_emacs_mule)
5683 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5684 (decode_coding_ccl, decode_coding_charset)
5685 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5686 (decode_coding_iso_2022, decode_coding_emacs_mule)
5687 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5688 <char_offset, last_offset>: Declare EMACS_INT.
5689 (encode_coding_utf_8, encode_coding_utf_16)
5690 (encode_coding_emacs_mule, encode_invocation_designation)
5691 (encode_designation_at_bol, encode_coding_iso_2022)
5692 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5693 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5695 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5696 (encode_invocation_designation): Last argument P_NCHARS is now
5698 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5699 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5701 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5704 * ccl.c (Fccl_execute_on_string): Declare some variables
5707 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5709 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5711 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5713 * process.c (Fformat_network_address): Doc fix.
5715 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5717 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5719 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5721 * keyboard.c (read_char): Call Lisp function help-form-show,
5722 instead of using internal_with_output_to_temp_buffer.
5723 (Qhelp_form_show): New var.
5724 (syms_of_keyboard): Use DEFSYM macro.
5726 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5728 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5730 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5732 * process.c (Flist_processes): Remove to Lisp.
5733 (list_processes_1): Delete.
5735 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5737 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5739 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5741 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5743 Fix more problems found by GCC 4.6.0's static checks.
5745 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5747 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5749 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5751 * xdisp.c (vmessage): Mark as a printf-like function.
5753 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5755 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5757 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5758 printf-like functions.
5759 (tiff_load): Add casts to remove these marks before passing them
5760 to system-supplied API.
5762 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5764 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5765 This avoids several warnings with gcc -Wstrict-overflow.
5766 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5767 directly, rather than having caller test rule sign. This avoids
5768 some unnecessary tests.
5769 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5770 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5771 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5773 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5774 (xfont_open): Avoid unnecessary tests.
5776 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5778 * composite.h, composite.c (composition_gstring_put_cache):
5779 Use EMACS_INT, not int, for length.
5781 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5782 breaking out part of COMPOSITION_DECODE_RULE.
5783 (COMPOSITION_DECODE_RULE): Use it.
5784 * composite.c (get_composition_id): Remove unused local vars,
5785 by using the new macro.
5787 * textprop.c (set_text_properties_1): Change while to do-while,
5788 since the condition is always true at first.
5790 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5791 (interval_deletion_adjustment): Return unsigned value.
5794 * process.c (list_processes_1, create_pty, read_process_output):
5795 (exec_sentinel): Remove vars that were set but not used.
5796 (create_pty): Remove unnecessary "volatile"s.
5797 (Fnetwork_interface_info): Avoid possibility of int overflow.
5798 (read_process_output): Do adaptive read buffering even if carryover.
5799 (read_process_output): Simplify nbytes computation if buffered.
5801 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5803 * syntax.c (scan_words): Remove var that was set but not used.
5804 (update_syntax_table): Use unsigned instead of int.
5806 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5807 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5808 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5810 * print.c (print_error_message): Avoid int overflow.
5812 * font.c (font_list_entities): Redo for clarity,
5813 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5815 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5816 (font_score): Avoid potential overflow in diff calculation.
5818 * fns.c (substring_both): Remove var that is set but not used.
5819 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5821 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5823 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5824 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5825 can always succeed if overflow has undefined behavior.
5827 * search.c (boyer_moore, wordify): Remove vars set but not used.
5828 (wordify): Omit three unnecessary tests.
5830 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5831 All callers changed. This avoids the need for an unused var.
5833 * casefiddle.c (casify_region): Remove var that is set but not used.
5835 * dired.c (file_name_completion): Remove var that is set but not used.
5837 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5839 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5840 (Finsert_file_contents): Remove unnecessary code checking fd.
5842 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5843 Check for integer overflow on size calculations.
5845 * buffer.c (Fprevious_overlay_change): Remove var that is set
5848 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5849 Remove vars that are set but not used.
5850 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5851 (timer_check_2): Mark vars as initialized.
5853 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5855 * image.c (lookup_image): Remove var that is set but not used.
5856 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5858 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5859 that are set but not used.
5861 * xfns.c (make_invisible_cursor): Don't return garbage
5862 if XCreateBitmapFromData fails (Bug#8410).
5864 * xselect.c (x_get_local_selection, x_handle_property_notify):
5865 Remove vars that are set but not used.
5867 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5868 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5870 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5871 Remove var that is set but not used.
5872 (scroll_bar_windows_size): Now size_t, not int.
5873 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5876 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5877 (map_tty_color) [!defined MSDOS]: Likewise.
5879 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5881 * coding.c: Remove vars that are set but not used.
5882 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5883 All callers changed.
5884 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5885 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5886 (decode_coding_charset): Remove vars that are set but not used.
5888 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5889 that is set but not used.
5891 * print.c (print_object): Remove var that is set but not used.
5893 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5894 The gnulib version avoids calling malloc in the usual case,
5895 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5896 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5897 * filelock.c (current_lock_owner): Likewise.
5898 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5899 * sysdep.c: Include allocator.h, careadlinkat.h.
5900 (emacs_no_realloc_allocator): New static constant.
5901 (emacs_readlink): New function.
5902 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5903 ../lib/careadlinkat.h.
5905 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5907 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5908 first non-nil return value).
5910 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5912 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5913 if not defined (Bug#8403).
5915 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5917 * xdisp.c (display_count_lines): Remove parameter `start',
5918 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5919 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5920 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5921 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5922 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5923 and thereabouts. All callers changed.
5924 (get_per_char_metric): Remove parameter `f', unused since
5925 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5927 2011-04-02 Jim Meyering <meyering@redhat.com>
5929 do not dereference NULL upon failed strdup
5930 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5931 (ns_get_family): Likewise.
5933 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5935 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5937 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5939 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5942 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5944 Add lexical binding.
5946 * window.c (Ftemp_output_buffer_show): New fun.
5947 (Fsave_window_excursion):
5948 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5950 * lread.c (lisp_file_lexically_bound_p): New function.
5951 (Fload): Bind Qlexical_binding.
5952 (readevalloop): Remove `evalfun' arg.
5953 Bind Qinternal_interpreter_environment.
5954 (Feval_buffer): Bind Qlexical_binding.
5955 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5957 (syms_of_lread): Declare `lexical-binding'.
5959 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5961 * keyboard.c (eval_dyn): New fun.
5962 (menu_item_eval_property): Use it.
5964 * image.c (parse_image_spec): Use Ffunctionp.
5966 * fns.c (concat, mapcar1): Accept byte-code-functions.
5968 * eval.c (Fsetq): Handle lexical vars.
5969 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5970 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5971 (FletX, Flet): Obey lexical binding.
5972 (Fcommandp): Handle closures.
5973 (Feval): New `lexical' arg.
5974 (eval_sub): New function extracted from Feval. Use it almost
5975 everywhere where Feval was used. Look up vars in lexical env.
5977 (Ffunctionp): Move from subr.el.
5978 (Ffuncall): Handle closures.
5979 (apply_lambda): Remove `eval_flags'.
5980 (funcall_lambda): Handle closures and new byte-code-functions.
5981 (Fspecial_variable_p): New function.
5982 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5983 but without exporting it to Lisp.
5985 * doc.c (Fdocumentation, store_function_docstring):
5986 * data.c (Finteractive_form): Handle closures.
5988 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5991 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5993 (exec_byte_code): New function extracted from Fbyte_code to handle new
5994 calling convention for byte-code-functions. Add new byte-codes.
5996 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5998 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6000 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6002 * xdisp.c (redisplay_internal): Fix prototype.
6004 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6006 * xdisp.c (SCROLL_LIMIT): New macro.
6007 (try_scrolling): Use it when setting scroll_limit.
6008 Limit scrolling to 100 screen lines.
6009 (redisplay_window): Even when falling back on "recentering",
6010 position point in the window according to scroll-conservatively,
6011 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6013 (try_scrolling): When point is above the window, allow searching
6014 as far as scroll_max, or one screenful, to compute vertical
6015 distance from PT to the scroll margin position. This prevents
6016 try_scrolling from unnecessarily failing when
6017 scroll-conservatively is set to a value slightly larger than the
6018 window height. Clean up the case of PT below the margin at bottom
6019 of window: scroll_max can no longer be INT_MAX. When aggressive
6020 scrolling is in use, don't let point enter the opposite scroll
6021 margin as result of the scroll.
6022 (syms_of_xdisp) <scroll-conservatively>: Document the
6023 threshold of 100 lines for never-recentering scrolling.
6025 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6027 * dispextern.h (move_it_by_lines):
6028 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6029 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6030 (message_log_check_duplicate): Remove parameters `prev_bol' and
6031 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6032 (redisplay_internal): Remove parameter `preserve_echo_area',
6033 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6035 * indent.c (Fvertical_motion):
6036 * window.c (window_scroll_pixel_based, Frecenter):
6037 Don't pass `need_y_p' to `move_it_by_lines'.
6039 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6041 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6042 steal a few bits to be more compact.
6043 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6044 Remove unneeded casts.
6046 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6048 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6050 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6051 binding" message (bug#7967).
6053 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6055 Fix more problems found by GCC 4.6.0's static checks.
6057 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6058 Remove unused local var.
6060 * editfns.c (Fmessage_box): Remove unused local var.
6062 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6063 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6064 Omit unused local vars.
6065 * window.c (shrink_windows): Omit unused local var.
6066 * menu.c (digest_single_submenu): Omit unused local var.
6067 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6068 Omit unused local var.
6070 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6071 Don't assume string length fits in int.
6072 (keyremap_step, read_key_sequence): Use size_t for sizes.
6073 (read_key_sequence): Don't check last_real_key_start redundantly.
6075 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6076 instead of alloca (Bug#8344).
6078 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6079 (Fbacktrace_frame): Don't assume nframes fits in int.
6081 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6083 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6086 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6088 * cm.c (calccost): Turn while-do into do-while, for clarity.
6090 * keyboard.c (syms_of_keyboard): Use the same style as later
6091 in this function when indexing through an array. This also
6092 works around GCC bug 48267.
6094 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6096 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6098 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6099 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6101 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6102 This avoids undefined behavior on integer overflow, and is a bit
6103 more convenient anyway since it is compared to a size_t variable.
6105 Variadic C functions now count arguments with size_t, not int.
6106 This avoids an unnecessary limitation on 64-bit machines, which
6107 caused (substring ...) to crash on large vectors (Bug#8344).
6108 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6109 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6110 All variadic functions and their callers changed accordingly.
6111 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6112 * data.c (arith_driver, float_arith_driver): Likewise.
6113 * editfns.c (general_insert_function): Likewise.
6114 * eval.c (struct backtrace.nargs, interactive_p)
6115 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6116 (funcall_lambda, mark_backtrace): Likewise.
6117 * fns.c (concat): Likewise.
6118 * frame.c (x_set_frame_parameters): Likewise.
6119 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6120 0 if not found, not -1. All callers changed.
6122 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6123 (stack_copy_size): Now size_t, not int.
6124 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6126 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6128 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6129 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6130 All callers changed.
6132 * lisp.h (multibyte_char_to_unibyte):
6133 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6134 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6135 * character.h (CHAR_TO_BYTE8):
6136 * cmds.c (internal_self_insert):
6137 * editfns.c (general_insert_function):
6138 * keymap.c (push_key_description):
6139 * search.c (Freplace_match):
6140 * xdisp.c (message_dolog, set_message_1): All callers changed.
6142 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6144 * keyboard.c (safe_run_hook_funcall): New function.
6145 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6146 don't set the hook to nil, but remove the offending function instead.
6147 (Qcommand_hook_internal): Remove, unused.
6148 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6149 Vcommand_hook_internal.
6151 * eval.c (enum run_hooks_condition): Remove.
6152 (funcall_nil, funcall_not): New functions.
6153 (run_hook_with_args): Call each function through a `funcall' argument.
6154 Remove `cond' argument, now redundant.
6155 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6156 (Frun_hook_with_args_until_failure): Adjust accordingly.
6157 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6159 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6161 * dispextern.h (string_buffer_position): Remove declaration.
6163 * print.c (strout): Remove parameter `multibyte', unused since
6164 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6166 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6167 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6168 All callers changed.
6170 * w32.c (_wsa_errlist): Use braces for struct initializers.
6172 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6173 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6174 All callers changed.
6175 (string_buffer_position): Likewise. Also, make static (it's never
6176 used outside xdisp.c).
6177 (cursor_row_p): Remove parameter `w', unused since
6178 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6179 (decode_mode_spec): Remove parameter `precision', introduced during
6180 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6181 All callers changed.
6183 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6185 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6187 2011-03-27 Anders Lindgren <andlind@gmail.com>
6189 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6190 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6191 (ns_update_auto_hide_menu_bar): New functions.
6192 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6193 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6194 ns_constrain_all_frames.
6195 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6196 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6198 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6200 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6202 2011-03-27 Glenn Morris <rgm@gnu.org>
6204 * syssignal.h: Replace RETSIGTYPE with void.
6205 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6206 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6207 Replace SIGTYPE with void everywhere.
6208 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6209 * s/template.h (SIGTYPE): Remove commented out definition.
6211 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6213 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6214 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6216 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6218 * w32.c (read_unc_volume): Use parameter `henum', instead of
6219 global variable `wget_enum_handle'.
6221 * keymap.c (describe_vector): Remove parameters `indices' and
6222 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6223 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6225 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6227 * keyboard.c (timer_check): Remove parameter `do_it_now',
6228 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6229 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6230 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6232 * keyboard.c (read_char):
6233 * w32menu.c (w32_menu_display_help):
6234 * xmenu.c (show_help_event, menu_help_callback):
6235 Adjust calls to `show_help_echo'.
6237 * gtkutil.c (xg_maybe_add_timer):
6238 * keyboard.c (readable_events):
6239 * process.c (wait_reading_process_output):
6240 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6242 * insdel.c (adjust_markers_gap_motion):
6243 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6244 (gap_left, gap_right): Don't call it.
6246 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6248 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6249 incurred during fontification.
6251 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6253 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6254 (DEFVAR_PER_BUFFER): Don't pass it.
6256 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6257 (scrolling_window): Don't pass it.
6259 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6261 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6263 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6265 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6266 of variables specific to SELinux and computation of `encoded_absname'.
6268 * image.c (XPutPixel): Remove unused variable `height'.
6270 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6272 * unexw32.c (get_section_info): Remove unused variable `section'.
6274 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6275 (system_process_attributes): Remove unused variable `sess'.
6276 (sys_read): Remove unused variable `err'.
6278 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6279 (w32_wnd_proc): Remove unused variable `isdead'.
6280 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6281 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6282 (x_create_tip_frame): Remove unused variable `tem'.
6284 * w32inevt.c (w32_console_read_socket):
6285 Remove unused variable `no_events'.
6287 * w32term.c (x_draw_composite_glyph_string_foreground):
6288 Remove unused variable `width'.
6290 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6292 * w32term.c (x_set_glyph_string_clipping):
6293 Don't pass uninitialized region to CombineRgn.
6295 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6297 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6298 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6299 (Fx_close_connection): Remove unused variable `i'.
6301 * w32font.c (w32font_draw): Return number of glyphs.
6302 (w32font_open_internal): Remove unused variable `i'.
6303 (w32font_driver): Add missing initializer.
6305 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6306 (fill_in_menu): Remove unused variable `items_added'.
6308 * w32term.c (last_mouse_press_frame): Remove static global variable.
6309 (w32_clip_to_row): Remove unused variable `f'.
6310 (x_delete_terminal): Remove unused variable `i'.
6312 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6313 (NOTHING): Remove unused static global variable.
6314 (uniscribe_check_otf): Remove unused variable `table'.
6315 (uniscribe_font_driver): Add missing initializers.
6317 2011-03-23 Julien Danjou <julien@danjou.info>
6319 * term.c (Fsuspend_tty, Fresume_tty):
6320 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6321 * window.c (temp_output_buffer_show):
6322 * insdel.c (signal_before_change):
6323 * frame.c (Fhandle_switch_frame):
6324 * fileio.c (Fdo_auto_save):
6325 * emacs.c (Fkill_emacs):
6326 * editfns.c (save_excursion_restore):
6327 * cmds.c (internal_self_insert):
6328 * callint.c (Fcall_interactively):
6329 * buffer.c (Fkill_all_local_variables):
6330 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6332 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6333 unconditionnaly since it does the check itself.
6335 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6337 Fix more problems found by GCC 4.5.2's static checks.
6339 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6340 the first time through the loop, since we know p0 < p1 then.
6341 This also avoids a gcc -Wstrict-overflow warning.
6343 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6344 leading to a memory leak, possible in functions like
6345 load_charset_map_from_file that can allocate an unbounded number
6346 of objects (Bug#8318).
6348 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6349 that could (at least in theory) be that large.
6351 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6352 This is less likely to overflow, and avoids undefined behavior if
6353 overflow does occur. All callers changed. Use strtoul to scan
6354 for the unsigned long integer.
6355 (pint2hrstr): Simplify and tune code slightly.
6356 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6358 * scroll.c (do_scrolling): Work around GCC bug 48228.
6359 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6361 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6362 This also avoids a warning with gcc -Wstrict-overflow.
6363 (validate_x_resource_name): Simplify count usage.
6364 This also avoids a warning with gcc -Wstrict-overflow.
6366 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6369 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6371 * process.c (Fmake_network_process): Use socklen_t, not int,
6372 where POSIX says socklen_t is required in portable programs.
6373 This fixes a porting bug on hosts like 64-bit HP-UX, where
6374 socklen_t is wider than int (Bug#8277).
6375 (Fmake_network_process, server_accept_connection):
6376 (wait_reading_process_output, read_process_output):
6379 * process.c: Rename or move locals to avoid shadowing.
6380 (list_processes_1, Fmake_network_process):
6381 (read_process_output_error_handler, exec_sentinel_error_handler):
6382 Rename or move locals.
6383 (Fmake_network_process): Define label "retry_connect" only if needed.
6384 (Fnetwork_interface_info): Fix pointer signedness.
6385 (process_send_signal): Add cast to avoid pointer signedness problem.
6386 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6387 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6389 Make tparam.h and terminfo.c consistent.
6390 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6391 Include tparam.h instead, since it declares them.
6392 * cm.h (PC): Remove extern decl; tparam.h now does this.
6393 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6394 * terminfo.c: Include tparam.h, to check interfaces.
6395 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6396 (tparam): Adjust signature to match interface in tparam.h;
6397 this removes some undefined behavior. Check that outstring and len
6398 are zero, which they always are with Emacs.
6399 * tparam.h (PC, BC, UP): New extern decls.
6401 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6402 (xftfont_open): Rename locals to avoid shadowing.
6404 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6405 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6406 (OTF_TAG_SYM): Omit macro if not needed.
6407 (ftfont_list): Remove unused local.
6408 (get_adstyle_property, ftfont_pattern_entity):
6409 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6410 Rename locals to avoid shadowing.
6412 * xfont.c (xfont_list_family): Mark var as initialized.
6414 * xml.c (make_dom): Now static.
6416 * composite.c (composition_compute_stop_pos): Rename local to
6418 (composition_reseat_it): Remove unused locals.
6419 (find_automatic_composition, composition_adjust_point): Likewise.
6420 (composition_update_it): Mark var as initialized.
6421 (find_automatic_composition): Mark vars as initialized,
6422 with a FIXME (Bug#8290).
6424 character.h: Rename locals to avoid shadowing.
6425 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6426 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6427 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6428 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6431 * textprop.c (property_change_between_p): Remove; unused.
6433 * intervals.c (interval_start_pos): Now static.
6435 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6437 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6438 Rename locals to avoid shadowing.
6440 * sound.c (wav_play, au_play, Fplay_sound_internal):
6441 Fix pointer signedness.
6442 (alsa_choose_format): Remove unused local var.
6443 (wav_play): Initialize a variable to 0, to prevent undefined
6444 behavior (Bug#8278).
6446 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6448 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6450 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6451 clobbering (Bug#8298).
6452 * sysdep.c (sys_subshell): Likewise.
6453 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6455 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6456 This should get cleaned up, so that child_setup has the
6457 same signature on all platforms.
6459 * callproc.c (call_process_cleanup): Now static.
6460 (relocate_fd): Rename locals to avoid shadowing.
6462 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6464 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6465 not to be necessary, and produces flickering.
6467 2011-03-20 Glenn Morris <rgm@gnu.org>
6469 * config.in: Remove file.
6471 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6473 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6474 are now in src/globals.h.
6475 (syms_of_minibuf): Remove spurious & from previous change.
6477 2011-03-20 Leo <sdl.web@gmail.com>
6479 * minibuf.c (completing-read-function): New variable.
6480 (completing-read-default): Rename from completing-read.
6481 (completing-read): Call completing-read-function.
6483 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6485 * xfaces.c (Fx_load_color_file):
6486 Read color file from absolute filename (bug#8250).
6488 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6490 * makefile.w32-in: Update dependencies.
6492 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6494 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6496 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6498 Fix more problems found by GCC 4.5.2's static checks.
6500 * process.c (make_serial_process_unwind, send_process_trap):
6501 (sigchld_handler): Now static.
6503 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6504 That way, the code declares only the vars that it needs.
6505 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6506 * s/cygwin.h (PTY_ITERATION): Likewise.
6507 * s/darwin.h (PTY_ITERATION): Likewise.
6508 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6510 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6511 * process.c (allocate_pty): Don't declare stb unless it's needed.
6513 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6514 (CONSTANTLIM): Remove; unused.
6515 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6516 Define only if needed.
6518 * unexelf.c (unexec): Name an expression,
6519 to avoid gcc -Wbad-function-cast warning.
6520 Use a different way to cause a compilation error if anyone uses
6521 n rather than nn, a way that does not involve shadowing.
6522 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6524 * deps.mk (unexalpha.o): Remove; unused.
6526 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6527 * unexec.h: New file.
6528 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6529 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6531 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6532 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6533 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6534 Change as necessary to match prototype in unexec.h.
6536 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6538 (back_comment, skip_chars): Mark vars as initialized.
6540 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6541 Rename locals to avoid shadowing.
6543 * lread.c (read1): Rewrite so as not to use empty "else".
6544 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6546 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6548 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6549 warning when compiling print.c.
6551 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6552 instead of using an uninitialized var.
6553 (font_sort_entities): Mark var as initialized.
6555 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6557 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6558 pointers to constants.
6559 (font_parse_fcname): Remove unused vars.
6560 (font_delete_unmatched): Now static.
6561 (font_get_spec): Remove; unused.
6562 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6563 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6564 Rename or move locals to avoid shadowing.
6566 * fns.c (require_nesting_list, require_unwind): Now static.
6567 (Ffillarray): Rename locals to avoid shadowing.
6569 * floatfns.c (domain_error2): Define only if needed.
6570 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6572 * alloc.c (mark_backtrace): Move decl from here ...
6573 * lisp.h: ... to here, so that it can be checked.
6575 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6576 (Fdefvar): Rewrite so as not to use empty "else".
6577 (lisp_indirect_variable): Name an expression,
6578 to avoid gcc -Wbad-function-cast warning.
6579 (Fdefvar): Rename locals to avoid shadowing.
6581 * callint.c (quotify_arg, quotify_args): Now static.
6582 (Fcall_interactively): Rename locals to avoid shadowing.
6583 Use const pointer when appropriate.
6585 * lisp.h (get_system_name, get_operating_system_release):
6586 Move decls here, to check interfaces.
6587 * process.c (get_operating_system_release): Move decl to lisp.h.
6588 * xrdb.c (get_system_name): Likewise.
6589 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6590 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6591 some of which prompt warnings from gcc -Wbad-function-cast.
6592 (Fformat_time_string, Fencode_time, Finsert_char):
6593 (Ftranslate_region_internal, Fformat):
6594 Rename or remove local vars to avoid shadowing.
6595 (Ftranslate_region_internal): Mark var as initialized.
6597 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6600 * lisp.h (eassert): Check that the argument compiles, even if
6601 ENABLE_CHECKING is not defined.
6603 * data.c (Findirect_variable): Name an expression, to avoid
6604 gcc -Wbad-function-cast warning.
6605 (default_value, arithcompare, arith_driver, arith_error): Now static.
6606 (store_symval_forwarding): Rename local to avoid shadowing.
6607 (Fmake_variable_buffer_local, Fmake_local_variable):
6608 Mark variables as initialized.
6609 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6611 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6612 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6613 Rename locals to avoid shadowing.
6614 (mark_stack): Move local variables into the #ifdef region where
6616 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6617 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6619 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6620 (GC_STRING_CHARS): Remove; not used.
6621 (Fmemory_limit): Cast sbrk's returned value to char *.
6623 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6624 avoids undefined behavior in theory.
6626 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6628 Use functions, not macros, for up- and down-casing (Bug#8254).
6629 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6630 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6631 to use the following functions instead of these macros.
6632 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6633 EMACS_INT, since callers assume the returned value fits in int.
6634 (upcase1): Likewise, for UPCASE_TABLE.
6635 (uppercasep, lowercasep, upcase): New static inline functions.
6636 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6637 the race-condition problem in the old DOWNCASE.
6639 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6640 Rename locals to avoid shadowing.
6641 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6642 (regex_compile, re_search_2, re_match_2_internal):
6643 Remove unused local vars.
6644 (FREE_VAR): Rewrite so as not to use empty "else",
6645 which gcc can warn about.
6646 (regex_compile, re_match_2_internal): Mark locals as initialized.
6647 (RETALLOC_IF): Define only if needed.
6648 (WORDCHAR_P): Likewise. This one is never needed, but is used
6649 only in a comment talking about a compiler bug, so put inside
6650 the #if 0 of that comment.
6651 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6652 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6655 * search.c (boyer_moore): Rename locals to avoid shadowing.
6656 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6657 (PREV_CHAR_BOUNDARY): Likewise.
6659 * search.c (simple_search): Remove unused var.
6661 * dired.c (compile_pattern): Move decl from here ...
6662 * lisp.h: ... to here, so that it can be checked.
6663 (struct re_registers): New forward decl.
6665 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6667 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6669 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6670 Rename locals to avoid shadowing.
6671 (Fvertical_motion): Mark locals as initialized.
6673 * casefiddle.c (casify_object, casify_region): Now static.
6674 (casify_region): Mark local as initialized.
6676 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6678 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6679 New macros, so that the caller can use some names other than
6680 gcpro1, gcpro2, etc.
6681 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6683 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6684 argument, for consistency with GCPRO2_VAR, etc: it is now the
6685 prefix of the variable, not the variable itself. All uses
6687 * dired.c (directory_files_internal, file_name_completion):
6688 Rename locals to avoid shadowing.
6690 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6691 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6692 dired.c's scmp function, had undefined behavior.
6693 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6694 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6695 * buffer.h: ... to here, because these macros use current_buffer,
6696 and the new implementation with inline functions needs to have
6697 current_buffer in scope now, rather than later when the macros
6699 (downcase, upcase1): New static inline functions.
6700 (DOWNCASE, UPCASE1): Reimplement using these functions.
6701 This avoids undefined behavior in expressions like
6702 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6703 from race conditions in accessing the global variables
6704 case_temp1 and case_temp2.
6705 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6706 * lisp.h (case_temp1, case_temp2): Remove their decls.
6707 * character.h (ASCII_CHAR_P): Move from here ...
6708 * lisp.h: ... to here, so that the inline functions mentioned
6711 * dired.c (directory_files_internal_unwind): Now static.
6713 * fileio.c (file_name_as_directory, directory_file_name):
6714 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6716 (file_name_as_directory): Use const pointers when appropriate.
6717 (Fexpand_file_name): Likewise. In particular, newdir might
6718 point at constant storage, so make it a const pointer.
6719 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6720 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6722 (Fset_file_times, Finsert_file_contents, auto_save_error):
6723 Rename locals to avoid shadowing.
6725 * minibuf.c (choose_minibuf_frame_1): Now static.
6726 (Ftry_completion, Fall_completions): Rename or remove locals
6729 * marker.c (bytepos_to_charpos): Remove; unused.
6731 * lisp.h (verify_bytepos, count_markers): New decls,
6732 so that gcc does not warn that these functions aren't declared.
6734 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6735 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6736 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6737 (copy_text): Remove unused local var.
6739 * filelock.c (within_one_second): Now static.
6740 (lock_file_1): Rename local to avoid shadowing.
6742 * buffer.c (fix_overlays_before): Mark locals as initialized.
6743 (fix_start_end_in_overlays): Likewise. This function should be
6744 simplified by using pointers-to-pointers, but that's a different
6746 (switch_to_buffer_1): Now static.
6747 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6748 (report_overlay_modification): Rename locals to avoid shadowing.
6750 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6751 Fix pointer signedness issue.
6752 (sys_subshell): Mark local as volatile if checking for lint,
6753 to suppress a gcc -Wclobbered warning that does not seem to be right.
6754 (MAXPATHLEN): Define only if needed.
6756 * process.c (serial_open, serial_configure): Move decls from here ...
6757 * systty.h: ... to here, so that they can be checked.
6759 * fns.c (get_random, seed_random): Move extern decls from here ...
6760 * lisp.h: ... to here, so that they can be checked.
6762 * sysdep.c (reset_io): Now static.
6763 (wait_for_termination_signal): Remove; unused.
6765 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6766 (copy_keymap_item, append_key, push_text_char_description):
6768 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6769 (DENSE_TABLE_SIZE): Remove; unused.
6770 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6771 (describe_map_tree):
6772 Rename locals to avoid shadowing.
6774 * keyboard.c: Declare functions static if they are not used elsewhere.
6775 (echo_char, echo_dash, cmd_error, top_level_2):
6776 (poll_for_input, handle_async_input): Now static.
6777 (read_char, kbd_buffer_get_event, make_lispy_position):
6778 (make_lispy_event, make_lispy_movement, apply_modifiers):
6779 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6780 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6781 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6782 (read_key_sequence, read_char): Mark locals as initialized.
6783 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6785 * keyboard.h (make_ctrl_char): New decl.
6786 (mark_kboards): Move decl here ...
6787 * alloc.c (mark_kboards): ... from here.
6789 * lisp.h (force_auto_save_soon): New decl.
6791 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6792 (DEFINE_DUMMY_FUNCTION): New macro.
6793 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6795 (main): Add casts to avoid warnings
6796 if GCC considers string literals to be constants.
6798 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6800 * dbusbind.c: Pointer signedness fixes.
6801 (xd_signature, xd_append_arg, xd_initialize):
6802 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6803 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6804 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6805 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6807 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6808 if GCC considers string literals to be constants.
6809 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6811 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6813 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6814 (print_preprocess, print_object): New macro to fix last change.
6816 * print.c (print_preprocess): Don't forget font objects.
6818 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6820 * emacs.c (USAGE3): Doc fixes.
6822 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6824 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6827 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6829 * lisp.h (VWindow_system, Qfile_name_history):
6830 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6831 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6832 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6834 * w32select.c: Don't #include "keyboard.h".
6835 (run_protected): Add extern declaration for waiting_for_input.
6837 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6838 * w32console.c (detect_input_pending, read_input_pending)
6839 (encode_terminal_code):
6840 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6841 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6842 (w32_system_caret_y, Qfile_name_history):
6843 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6844 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6845 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6846 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6847 * w32proc.c (Qlocal, report_file_error):
6848 * w32term.c (Vwindow_system, updating_frame):
6849 * w32uniscribe.c (initialized, uniscribe_font_driver):
6850 Remove unneeded extern declarations.
6852 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6854 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6856 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6858 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6859 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6860 These macros can no longer be used for assignment.
6862 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6863 Assign struct members directly, instead of using BUF_BEGV etc.
6864 (record_buffer_markers, fetch_buffer_markers): New functions for
6865 recording and fetching special buffer markers.
6866 (set_buffer_internal_1, set_buffer_temp): Use them.
6868 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6870 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6872 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6873 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6875 * xdisp.c (hscroll_window_tree):
6876 (reconsider_clip_changes): Use PT instead of BUF_PT.
6878 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6880 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6881 $(EMACS_ROOT)/lib/intprops.h.
6883 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6885 Fix more problems found by GCC 4.5.2's static checks.
6887 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6888 to unsigned char * to avoid compiler diagnostic.
6889 (xg_free_frame_widgets): Make it clear that a local variable is
6890 needed only if USE_GTK_TOOLTIP.
6891 (gdk_window_get_screen): Make it clear that this macro is needed
6892 only if USE_GTK_TOOLTIP.
6893 (int_gtk_range_get_value): New function, which avoids a diagnostic
6894 from gcc -Wbad-function-cast.
6895 (xg_set_toolkit_scroll_bar_thumb): Use it.
6896 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6897 diagnostic from gcc -Wbad-function-cast.
6898 (get_utf8_string, xg_get_file_with_chooser):
6899 Rename locals to avoid shadowing.
6900 (create_dialog): Move locals to avoid shadowing.
6902 * xgselect.c (xg_select): Remove unused var.
6904 * image.c (four_corners_best): Mark locals as initialized.
6905 (gif_load): Initialize transparent_p to zero (Bug#8238).
6906 Mark another local as initialized.
6907 (my_png_error, my_error_exit): Mark with NO_RETURN.
6909 * image.c (clear_image_cache): Now static.
6910 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6911 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6912 (x_edge_detection): Remove unnecessary cast that
6913 gcc -Wbad-function-cast diagnoses.
6914 (gif_load): Fix pointer signedness.
6915 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6916 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6918 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6920 Improve quality of tests for time stamp overflow.
6921 For example, without this patch (encode-time 0 0 0 1 1
6922 1152921504606846976) returns the obviously-bogus value (-948597
6923 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6924 reports time overflow. See
6925 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6926 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6927 * editfns.c: Include limits.h and intprops.h.
6928 (TIME_T_MIN, TIME_T_MAX): New macros.
6929 (time_overflow): Move earlier, to before first use.
6930 (hi_time, lo_time): New functions, for an accurate test for
6932 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6933 (Fget_internal_run_time): Don't assume time_t fits in int.
6934 (make_time): Use list2 instead of Fcons twice.
6935 (Fdecode_time): More accurate test for out-of-range times.
6936 (check_tm_member): New function.
6937 (Fencode_time): Use it, to test for out-of-range times.
6938 (lisp_time_argument): Don't rely on undefined left-shift and
6939 right-shift behavior when checking for time stamp overflow.
6941 * editfns.c (time_overflow): New function, refactoring common code.
6942 (Fformat_time_string, Fdecode_time, Fencode_time):
6943 (Fcurrent_time_string): Use it.
6945 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6946 * dired.c (make_time): Move to ...
6947 * editfns.c (make_time): ... here.
6948 * systime.h: Note the move.
6950 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6952 * fringe.c (update_window_fringes): Remove unused variables.
6954 * unexmacosx.c (copy_data_segment): Also copy __got section.
6957 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6959 * termcap.c [MSDOS]: Include "msdos.h".
6960 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6961 Constify `char *' arguments and their references according to
6962 prototypes in tparam.h.
6964 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6966 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6967 Adapt all references accordingly.
6969 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6971 2011-03-11 Tom Tromey <tromey@redhat.com>
6973 * buffer.c (syms_of_buffer): Remove obsolete comment.
6975 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6977 * termhooks.h (encode_terminal_code): Declare prototype.
6979 * msdos.c (encode_terminal_code): Don't declare prototype.
6981 * term.c (encode_terminal_code): Now external again, used by
6982 w32console.c and msdos.c.
6984 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6985 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6987 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6989 Fix some minor problems found by GCC 4.5.2's static checks.
6991 * fringe.c (update_window_fringes): Mark locals as initialized
6993 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6995 * alloc.c (mark_fringe_data): Move decl from here ...
6996 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6997 to check its interface.
6998 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7000 * fontset.c (free_realized_fontset): Now static.
7001 (Fset_fontset_font): Rename local to avoid shadowing.
7002 (fontset_font): Mark local as initialized.
7003 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7005 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7007 * xselect.c (x_disown_buffer_selections): Remove; not used.
7008 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7009 (x_own_selection, Fx_disown_selection_internal): Rename locals
7011 (x_handle_dnd_message): Remove local to avoid shadowing.
7013 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7014 so that the caller can use some name other than gcpro1.
7015 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7016 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7017 (Fx_backspace_delete_keys_p):
7018 Use them to avoid shadowing, and rename vars to avoid shadowing.
7019 (x_decode_color, x_set_name, x_window): Now static.
7020 (Fx_create_frame): Add braces to silence GCC warning.
7021 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7022 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7023 Remove unused locals.
7024 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7025 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7026 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7029 * xterm.h (x_mouse_leave): New decl.
7031 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7032 Remove unused functions.
7033 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7034 (x_calc_absolute_position): Now static.
7035 (XTread_socket): Don't define label "out" unless it's used.
7036 Don't declare local "event" unless it's used.
7037 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7038 unless they are used.
7039 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7040 (x_fatal_error_signal): Remove; not used.
7041 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7042 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7043 (x_error_catcher, x_connection_closed, x_error_handler):
7044 (x_error_quitter, xembed_send_message, x_iconify_frame):
7045 (my_log_handler): Rename locals to avoid shadowing.
7046 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7047 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7049 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7050 Rename or move locals to avoid shadowing.
7051 (tty_defined_color, merge_face_heights): Now static.
7052 (free_realized_faces_for_fontset): Remove; not used.
7053 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7054 does not deduce is never used uninitialized.
7055 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7056 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7058 * terminal.c (store_terminal_param): Now static.
7060 * xmenu.c (menu_highlight_callback): Now static.
7061 (set_frame_menubar): Remove unused local.
7062 (xmenu_show): Rename parameter to avoid shadowing.
7063 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7064 since they might point to immutable storage.
7065 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7066 since it's unused otherwise.
7068 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7069 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7070 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7071 avoids a gcc -Wuninitialized diagnostic.
7072 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7073 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7074 does not deduce are never used uninitialized.
7076 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7078 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7079 * window.c (window_loop, size_window):
7080 (run_window_configuration_change_hook, enlarge_window): Likewise.
7082 * window.c (display_buffer): Now static.
7083 (size_window): Mark variables that gcc -Wuninitialized
7084 does not deduce are never used uninitialized.
7085 * window.h (check_all_windows): New decl, to forestall
7086 gcc -Wmissing-prototypes diagnostic.
7087 * dispextern.h (bidi_dump_cached_states): Likewise.
7089 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7091 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7093 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7094 and to avoid gcc -Wuninitialized warning.
7095 (load_charset_map): Mark variables that gcc -Wuninitialized
7096 does not deduce are never used uninitialized.
7097 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7099 * coding.c (coding_set_source, coding_set_destination):
7100 Use "else { /* comment */ }" rather than "else /* comment */;"
7101 for clarity, and to avoid gcc -Wempty-body warning.
7102 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7103 a block, when the outer 'i' will do.
7104 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7105 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7106 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7107 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7108 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7109 Rename locals to avoid shadowing.
7110 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7111 * coding.c (emacs_mule_char, encode_invocation_designation):
7112 Now static, since they're not used elsewhere.
7113 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7114 (decode_coding_object, encode_coding_object, detect_coding_system):
7115 (decode_coding_emacs_mule): Mark variables that gcc
7116 -Wuninitialized does not deduce are never used uninitialized.
7117 (detect_coding_iso_2022): Initialize a local variable that might
7118 be used uninitialized. Leave a FIXME because it's not clear that
7119 this initialization is needed. (Bug#8211)
7120 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7121 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7122 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7123 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7124 Remove unused macros.
7126 * category.c (hash_get_category_set): Remove unused local var.
7127 (copy_category_table): Now static, since it's not used elsewhere.
7128 * character.c (string_count_byte8): Likewise.
7130 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7131 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7133 * chartab.c (copy_sub_char_table): Now static, since it's not used
7135 (sub_char_table_ref_and_range, char_table_ref_and_range):
7136 Rename locals to avoid shadowing.
7137 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7139 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7140 (BIDI_BOB): Remove unused macro.
7142 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7143 deduce are never used uninitialized.
7144 * term.c (encode_terminal_code): Likewise.
7146 * term.c (encode_terminal_code): Now static. Remove unused local.
7148 * tparam.h: New file.
7149 * term.c, tparam.h: Include it.
7150 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7151 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7152 Move these decls to tparam.h, and make them agree with what
7153 is actually in tparam.c. The previous trick of using incompatible
7154 decls in different modules does not conform to the C standard.
7155 All callers of tparam changed to use tparam's actual API.
7156 * tparam.c (tparam1, tparam, tgoto):
7157 Use const pointers where appropriate.
7159 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7160 * cm.h (struct cm): Likewise.
7161 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7162 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7163 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7164 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7165 (turn_on_face, init_tty): Likewise.
7166 * termchar.h (struct tty_display_info): Likewise.
7168 * term.c (term_mouse_position): Rename local to avoid shadowing.
7170 * alloc.c (mark_ttys): Move decl from here ...
7171 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7173 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7175 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7177 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7179 * search.c (compile_pattern_1): Remove argument regp, unused since
7180 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7181 (compile_pattern): Don't pass it.
7183 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7185 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7186 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7188 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7190 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7192 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7193 gdk_window_get_screen, gdk_window_get_geometry,
7194 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7195 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7196 (xg_get_pixbuf_from_pixmap): New function.
7197 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7198 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7199 Call xg_get_pixbuf_from_pixmap instead of
7200 gdk_pixbuf_get_from_drawable.
7201 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7202 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7203 (xg_check_special_colors): Use GtkStyleContext and its functions
7205 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7206 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7207 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7208 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7209 Call gtk_widget_get_preferred_size.
7210 (xg_frame_resized): gdk_window_get_geometry only takes 5
7212 (xg_win_to_widget, xg_event_is_for_menubar):
7213 Call gdk_x11_window_lookup_for_display.
7214 (xg_set_widget_bg): New function.
7215 (delete_cb): New function.
7216 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7217 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7218 (xg_set_background_color): Call xg_set_widget_bg.
7219 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7220 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7221 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7222 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7224 (update_frame_tool_bar): Call gtk_widget_hide.
7225 (xg_initialize): Use GDK_KEY_g.
7227 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7229 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7231 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7232 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7233 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7235 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7237 * w32xfns.c (select_palette): Check success of RealizePalette against
7238 GDI_ERROR, not zero.
7240 See ChangeLog.11 for earlier changes.
7246 Copyright (C) 2011 Free Software Foundation, Inc.
7248 This file is part of GNU Emacs.
7250 GNU Emacs is free software: you can redistribute it and/or modify
7251 it under the terms of the GNU General Public License as published by
7252 the Free Software Foundation, either version 3 of the License, or
7253 (at your option) any later version.
7255 GNU Emacs is distributed in the hope that it will be useful,
7256 but WITHOUT ANY WARRANTY; without even the implied warranty of
7257 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7258 GNU General Public License for more details.
7260 You should have received a copy of the GNU General Public License
7261 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.