1 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3 * unexaix.c (make_hdr): Fix typo in prototype.
4 This bug broke the build on AIX. Problem reported by Gilles Pion.
6 2012-05-05 Eli Zaretskii <eliz@gnu.org>
8 * w32proc.c (new_child): Force Windows to reserve only 64KB of
9 stack for each reader_thread, instead of defaulting to 8MB
10 determined by the linker. This avoids failures in creating
11 subprocesses on Windows 7, see the discussion in this thread:
12 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
14 2012-05-02 Jim Meyering <meyering@redhat.com>
16 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
18 2012-04-29 Eli Zaretskii <eliz@gnu.org>
20 * xdisp.c (pos_visible_p): If already at a newline from the
21 display string before the 'while' loop, don't walk back the glyphs
22 from it3.glyph_row. Solves assertion violation when the display
23 string begins with a newline (egg.el). (Bug#11367)
25 2012-04-24 Chong Yidong <cyd@gnu.org>
27 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
29 2012-04-23 Eli Zaretskii <eliz@gnu.org>
31 * xdisp.c (pos_visible_p): If the window start position is beyond
32 ZV, start the display from buffer beginning. Prevents assertion
33 violation in init_iterator when the minibuffer window is scrolled
36 * window.c (window_scroll_pixel_based): Likewise.
38 2012-04-23 Chong Yidong <cyd@gnu.org>
40 * keymap.c (where_is_internal): Doc fix (Bug#10872).
42 2012-04-20 Glenn Morris <rgm@gnu.org>
44 * fileio.c (Fcopy_file, Fset_file_selinux_context):
45 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
47 2012-04-20 Eli Zaretskii <eliz@gnu.org>
49 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers): Don't
50 overrun array limits of glyph row's used[] array. (Bug#11288)
52 2012-04-20 Chong Yidong <cyd@gnu.org>
54 * process.c (wait_reading_process_output): If EIO occurs on a pty,
55 set the status to "failed" and ensure that sentinel is run.
57 2012-04-18 Glenn Morris <rgm@gnu.org>
59 * process.c (Fset_process_inherit_coding_system_flag)
60 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
61 (Fmake_network_process, Fmake_serial_process): Doc fix.
63 2012-04-17 Eli Zaretskii <eliz@gnu.org>
65 * xdisp.c (string_buffer_position_lim): Limit starting position to
67 (set_cursor_from_row): If called for a mode-line or header-line
68 row, return zero immediately.
69 (try_cursor_movement): If inside continuation line, don't back up
70 farther than the first row after the header line, if any. Don't
71 consider the header-line row as "partially visible", even if
72 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
74 2012-04-13 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
76 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n" (bug#11238).
78 2012-04-10 Teodor Zlatanov <tzz@lifelogs.com>
80 * process.c (make_process):
81 * process.h: Add integer `gnutls_handshakes_tried' member to
84 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
85 Add convenience `GNUTLS_LOG2i' macro.
87 * gnutls.c (gnutls_log_function2i): Convenience log function.
88 (emacs_gnutls_read): Use new log functions,
89 `gnutls_handshakes_tried' process member, and
90 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
91 attempts per process (connection).
93 2012-04-09 Eli Zaretskii <eliz@gnu.org>
95 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
96 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
98 2012-04-09 Jan Djärv <jan.h.d@swipnet.se>
100 * nsterm.m (constrainFrameRect): Always constrain when there is only
101 one screen (Bug#10962).
103 2012-04-06 Eli Zaretskii <eliz@gnu.org>
105 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
106 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
107 about subtle differences between FETCH_CHAR* and STRING_CHAR*
108 macros related to unification of CJK characters. For the details,
109 see the discussion following the message here:
110 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
112 2012-04-04 Chong Yidong <cyd@gnu.org>
114 * keyboard.c (Vdelayed_warnings_list): Doc fix.
116 2012-04-01 Eli Zaretskii <eliz@gnu.org>
118 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
119 instead of alloca. (Bug#11138)
121 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
123 * w32menu.c (is_simple_dialog): Properly check lisp types.
126 2012-03-31 Eli Zaretskii <eliz@gnu.org>
128 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
129 position we get to after a call to move_it_to fails the
130 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
131 only if we wind up in a string from display property. (Bug#11063)
133 * window.c (Fdelete_other_windows_internal): Invalidate the row
134 and column information about mouse highlight, so that redisplay
135 restores it after reallocating the glyph matrices. (Bug#7464)
137 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
138 string comes from a `display' text property, use the buffer
139 position of that property as if we actually saw that position in
141 (move_it_by_lines): Remove the assertion that
142 "it->current_x == 0 && it->hpos == 0" which can be legitimately
143 violated when there's a before-string at the beginning of a line.
146 2012-03-30 Eli Zaretskii <eliz@gnu.org>
148 * xdisp.c (append_space_for_newline): If the default face was
149 remapped, use the remapped face for the appended newline.
150 (extend_face_to_end_of_line): Use the remapped default face for
151 extending the face to the end of the line.
152 (display_line): Call extend_face_to_end_of_line when the default
153 face was remapped. (Bug#11068)
155 2012-03-29 Eli Zaretskii <eliz@gnu.org>
157 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
159 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
161 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
163 2012-03-27 Glenn Morris <rgm@gnu.org>
165 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
168 2012-03-26 Kenichi Handa <handa@m17n.org>
170 * dispextern.h (struct glyph): Fix previous change. Change the
171 bit length of glyphless.ch to 25 (Bug#11082).
173 2012-03-26 Chong Yidong <cyd@gnu.org>
175 * keyboard.c (Vselection_inhibit_update_commands): New variable.
176 (command_loop_1): Use it; inhibit selection update for
177 handle-select-window too (Bug#8996).
179 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
181 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
183 2012-03-25 Kenichi Handa <handa@m17n.org>
185 * dispextern.h (struct glyph): Change the bit length of
186 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
188 2012-03-24 Eli Zaretskii <eliz@gnu.org>
190 * s/ms-w32.h (tzname): Include time.h before redirecting to
191 _tzname. Fixes the MSVC build. (Bug#9960)
193 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
195 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
198 * xterm.c (XTread_socket): Only modify handling_signal if
199 !SYNC_INPUT. (Bug#11080)
201 2012-03-23 Eli Zaretskii <eliz@gnu.org>
203 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
204 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
205 when fetching a multibyte character consumes more bytes than
206 CHAR_BYTES returns, due to unification of CJK characters in
207 string_char. (Bug#11073)
209 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
211 * process.c (wait_reading_process_output): Handle pty disconnect
212 by refraining from sending oneself a SIGCHLD (bug#10933).
214 2012-03-22 Chong Yidong <cyd@gnu.org>
216 * dispextern.h (struct it): New member string_from_prefix_prop_p.
218 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
219 Mark string as coming from a prefix property.
220 (handle_face_prop): Use default face for prefix strings (Bug#4281).
221 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
223 2012-03-21 Chong Yidong <cyd@gnu.org>
225 * xfaces.c (Vface_remapping_alist): Doc fix.
227 2012-03-20 Eli Zaretskii <eliz@gnu.org>
229 * w32proc.c (Fw32_set_console_codepage)
230 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
233 2012-03-20 Chong Yidong <cyd@gnu.org>
235 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
236 to reflect default non-nil value of redisplay-dont-pause.
238 2012-03-19 Kenichi Handa <handa@m17n.org>
240 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
241 it fit in a valid range (Bug#11003).
243 2012-03-18 Eli Zaretskii <eliz@gnu.org>
245 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
246 that is not from display property, accept the row as a "cursor
247 row" if one of the string's character has a non-nil `cursor'
248 property. Fixes cursor positioning when there are newlines in
249 overlay strings, e.g. in icomplete.el. (Bug#11035)
251 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
253 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
255 2012-03-12 Chong Yidong <cyd@gnu.org>
257 * eval.c (inhibit_lisp_code): Rename from
258 inhibit_window_configuration_change_hook; move from window.c.
260 * xfns.c (unwind_create_frame_1, Fx_create_frame):
261 * window.c (run_window_configuration_change_hook)
262 (syms_of_window): Callers changed.
264 2012-03-11 Chong Yidong <cyd@gnu.org>
266 * keymap.c (Fkey_description): Doc fix (Bug#9700).
268 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
270 2012-03-10 Chong Yidong <cyd@gnu.org>
272 * frame.c (other_visible_frames): Don't assume the selected frame
273 is visible (Bug#10955).
275 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
277 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
279 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
281 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
282 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
285 2012-03-03 Glenn Morris <rgm@gnu.org>
287 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
289 2012-03-02 Eli Zaretskii <eliz@gnu.org>
291 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
292 position past the first glyph_row that ends at ZV. (Bug#10902)
293 (redisplay_window, next_element_from_string): Fix typos in
295 (redisplay_window): Pass to move_it_vertically the margin in
296 pixels, not in screen lines.
298 2012-03-02 Glenn Morris <rgm@gnu.org>
300 * buffer.c (buffer-list-update-hook): Doc fix.
302 2012-02-29 Eli Zaretskii <eliz@gnu.org>
304 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
305 push_it before setting up the iterator for the first overlay
306 string, even if we have an empty string loaded.
307 (next_overlay_string): If there's an empty string on the iterator
308 stack, pop the stack. (Bug#10903)
310 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
312 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
313 Suggested by Stefan Monnier in
314 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
315 * alloc.c (widen_to_Lisp_Object): New static function.
316 (mark_memory): Also mark Lisp_Objects by fetching pointer words
317 and widening them to Lisp_Objects. This would work even if
318 USE_LSB_TAG is defined and wide integers are used, which might
319 happen in a future version of Emacs.
321 2012-02-25 Chong Yidong <cyd@gnu.org>
323 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
326 * xselect.c (Fx_selection_exists_p): Doc fix.
327 (x_clipboard_manager_save_all): Print an informative message
328 before saving to clipboard manager.
330 2012-02-24 Chong Yidong <cyd@gnu.org>
332 * keyboard.c (process_special_events): Handle all X selection
333 requests in kbd_buffer, not just the next one (Bug#8869).
335 2012-02-23 Chong Yidong <cyd@gnu.org>
337 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
338 call when setting menu-bar-lines and tool-bar-lines parameters.
339 (unwind_create_frame_1): New helper function.
341 * window.c (inhibit_window_configuration_change_hook): New var.
342 (run_window_configuration_change_hook): Obey it.
343 (syms_of_window): Initialize it.
345 2012-02-22 Chong Yidong <cyd@gnu.org>
347 * xterm.c (x_draw_image_relief): Add missing type check for
348 Vtool_bar_button_margin (Bug#10743).
350 2012-02-21 Chong Yidong <cyd@gnu.org>
352 * fileio.c (Vfile_name_handler_alist): Doc fix.
354 * buffer.c (Fget_file_buffer): Protect against invalid file
355 handler return value.
357 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
359 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
360 when computing $valmask.
362 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
363 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
364 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
365 It's useless in that case, and it can cause problems on hosts
366 that allocate halves of EMACS_INT values separately.
367 Reported by Dan Horák. Diagnosed by Andreas Schwab in
368 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
369 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
370 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
371 it avoids undefined behavior on hosts where shifting right by more
372 than the word width has undefined behavior.
374 2012-02-19 Chong Yidong <cyd@gnu.org>
376 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
377 (Funhandled_file_name_directory, Ffile_name_as_directory)
378 (Fdirectory_file_name, Fexpand_file_name)
379 (Fsubstitute_in_file_name): Protect against invalid file handler
380 return values (Bug#10845).
382 2012-02-18 Eli Zaretskii <eliz@gnu.org>
384 * .gdbinit (pitx): Fix incorrect references to fields of the
387 2012-02-17 Chong Yidong <cyd@gnu.org>
389 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
391 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
393 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
394 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
396 2012-02-15 Chong Yidong <cyd@gnu.org>
398 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
399 marked as special. Also, starting docstrings with * is obsolete.
401 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
403 * gnutls.c (emacs_gnutls_write): Fix last change.
405 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
407 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
410 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
412 * keymap.c (Fsingle_key_description): Handle char ranges.
414 2012-02-12 Chong Yidong <cyd@gnu.org>
416 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
417 as that creates a dangerous corner case.
419 * window.c (Fdelete_window_internal): Invalidate the mouse
420 highlight (Bug#9904).
422 2012-02-12 Glenn Morris <rgm@gnu.org>
424 * xselect.c (Fx_own_selection_internal)
425 (Fx_get_selection_internal, Fx_disown_selection_internal)
426 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
427 * nsselect.m (Fx_own_selection_internal)
428 (Fx_disown_selection_internal, Fx_selection_exists_p)
429 (Fx_selection_owner_p, Fx_get_selection_internal):
430 Sync docs and argument specs with the xselect.c versions.
432 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
434 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
436 2012-02-11 Eli Zaretskii <eliz@gnu.org>
438 * w32select.c (Fx_selection_exists_p): Sync doc string and
439 argument list with xselect.c. (Bug#10783)
441 * w16select.c (Fx_selection_exists_p): Sync doc string and
442 argument list with xselect.c. (Bug#10783)
444 2012-02-10 Glenn Morris <rgm@gnu.org>
446 * fns.c (Fsecure_hash): Doc fix.
448 2012-02-09 Kenichi Handa <handa@m17n.org>
450 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
452 2012-02-07 Chong Yidong <cyd@gnu.org>
454 * buffer.c (Fbuffer_local_variables)
455 (buffer_lisp_local_variables): Handle unbound vars correctly;
456 don't let Qunbound leak into Lisp.
458 2012-02-07 Glenn Morris <rgm@gnu.org>
460 * image.c (Fimagemagick_types): Doc fix.
462 * image.c (imagemagick-render-type): Change it from a lisp object
463 to an integer. Move the doc here from the lisp manual.
464 Treat all values not equal to 0 the same.
466 2012-02-06 Chong Yidong <cyd@gnu.org>
468 * doc.c (store_function_docstring): Avoid applying docstring of
469 alias to base function (Bug#2603).
471 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
473 * .gdbinit (pp1, pv1): Remove redundant defines.
476 2012-02-04 Chong Yidong <cyd@gnu.org>
478 * nsterm.m: Declare a global (Bug#10694).
480 2012-02-04 Eli Zaretskii <eliz@gnu.org>
482 * w32.c (get_emacs_configuration_options):
483 Include --enable-checking, if specified, in the return value.
485 2012-02-04 Martin Rudalics <rudalics@gmx.at>
487 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
488 after rounding frame sizes. (Bug#9723)
490 2012-02-04 Eli Zaretskii <eliz@gnu.org>
492 * keyboard.c (adjust_point_for_property): Don't position point
493 before BEGV. (Bug#10696)
495 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
497 Handle overflow when computing char display width (Bug#9496).
498 * character.c (char_width): Return EMACS_INT, not int.
499 (char_width, c_string_width): Check for overflow when
500 computing the width; this is possible now that individual
501 characters can have unbounded width. Problem introduced
502 by merge from Emacs 23 on 2012-01-19.
504 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
506 * dbusbind.c (Fdbus_register_method): Mention the return value
507 :ignore in the docstring.
509 2012-02-02 Glenn Morris <rgm@gnu.org>
511 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
513 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
514 Unconditionally set to t. (Bug#10673)
515 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
516 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
517 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
519 2012-02-02 Kenichi Handa <handa@m17n.org>
521 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
522 0, do not call append_composite_glyph.
524 2012-02-02 Kenichi Handa <handa@m17n.org>
526 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
528 (x_produce_glyphs): If the component of a composition is a null
529 string, set it->pixel_width to 1 to avoid zero-width glyph.
531 2012-02-01 Eli Zaretskii <eliz@gnu.org>
533 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
534 first 2 arguments are identical. This makes inserting large
535 output from a subprocess an order of magnitude faster on
536 MS-Windows, where all sbrk'ed memory is always contiguous.
538 2012-01-31 Glenn Morris <rgm@gnu.org>
540 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
541 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
542 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
544 2012-01-29 Glenn Morris <rgm@gnu.org>
546 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
548 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
550 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
552 2012-01-28 Chong Yidong <cyd@gnu.org>
554 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
556 2012-01-26 Chong Yidong <cyd@gnu.org>
558 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
560 * search.c (Fsearch_forward, Fsearch_backward): Document negative
561 repeat counts (Bug#10507).
563 2012-01-26 Glenn Morris <rgm@gnu.org>
565 * lread.c (syms_of_lread): Doc fix.
567 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
569 * coding.c (encode_designation_at_bol): Change return value to
572 2012-01-25 Chong Yidong <cyd@gnu.org>
574 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
576 2012-01-21 Chong Yidong <cyd@gnu.org>
578 * floatfns.c (Fcopysign): Make the second argument non-optional,
579 since nil is not allowed anyway.
581 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
583 * process.c (read_process_output): Use p instead of XPROCESS (proc).
584 (send_process): Likewise.
586 2012-01-19 Martin Rudalics <rudalics@gmx.at>
588 * window.c (save_window_save, Fcurrent_window_configuration)
589 (Vwindow_persistent_parameters): Do not use Qstate.
592 2012-01-19 Kenichi Handa <handa@m17n.org>
594 * character.c (char_width): New function.
595 (Fchar_width, c_string_width, lisp_string_width):
596 Use char_width (Bug#9496).
598 2012-01-16 Martin Rudalics <rudalics@gmx.at>
600 * window.c (Vwindow_persistent_parameters): New variable.
601 (Fset_window_configuration, save_window_save): Handle persistent
604 2012-01-14 Eli Zaretskii <eliz@gnu.org>
606 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
607 thrashing the stack of the thread. (Bug#9087)
609 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
611 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
613 2012-01-11 Eli Zaretskii <eliz@gnu.org>
615 * xdisp.c (rows_from_pos_range): Handle the case where the
616 highlight ends on a newline. (Bug#10464)
617 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
618 he end column for display of highlight that ends on a newline
621 2012-01-11 Glenn Morris <rgm@gnu.org>
623 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
624 from load-path also when installation-directory is nil. (Bug#10208)
626 2012-01-10 Glenn Morris <rgm@gnu.org>
628 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
630 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
631 Update template values to be closer to their typical values these days.
633 2012-01-09 Eli Zaretskii <eliz@gnu.org>
635 * xdisp.c (rows_from_pos_range): Accept additional argument
636 DISP_STRING, and accept any glyph in a row whose object is that
637 string as eligible for mouse highlight. Fixes mouse highlight of
638 display strings from overlays. (Bug#10464)
640 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
642 emacs: fix an auto-save permissions race condition (Bug#10400)
643 * fileio.c (auto_saving_dir_umask): New static var.
644 (Fmake_directory_internal): Use it.
645 (do_auto_save_make_dir): Set it, instead of invoking chmod after
646 creating the directory. The old code temporarily assigns
647 too-generous permissions to the directory.
648 (do_auto_save_eh): Clear it.
649 (Fdo_auto_save): Catch all errors, not just file errors, so
650 that the var is always cleared.
652 2012-01-07 Eli Zaretskii <eliz@gnu.org>
654 * search.c (scan_buffer): Pass character positions to
655 know_region_cache, not byte positions. (Bug#6540)
657 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
659 * w32.c (sys_rename): Report EXDEV when rename of a directory
660 fails because the target is on another logical disk. (Bug#10284)
662 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
664 * xterm.c (x_embed_request_focus): New function.
666 * xterm.h: Add prototype.
668 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
670 2012-01-05 Glenn Morris <rgm@gnu.org>
672 * emacs.c (emacs_copyright): Update short copyright year to 2012.
674 2012-01-01 Eli Zaretskii <eliz@gnu.org>
676 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
677 Load gnutls_transport_set_lowat only if GnuTLS version is below
679 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
680 GnuTLS versions below 2.11.1.
682 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
684 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
685 to the doc string advising against its use for altering the way
686 windows are scrolled.
688 2011-12-28 Kenichi Handa <handa@m17n.org>
690 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
691 coding-system ASCII compatible only when it does not produce BOM
692 on encoding (Bug#10383).
694 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
696 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
698 (create_and_show_popup_menu): Always use menu_position_func for
701 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
703 * callint.c (Fcall_interactively): Don't truncate prompt string.
705 2011-12-23 Eli Zaretskii <eliz@gnu.org>
707 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
708 property that ends at ZV, so that the bidi iteration could be
709 resumed from there (after widening). (Bug#10360)
711 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
713 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
715 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
717 * nsterm.m (x_free_frame_resources):
718 Release f->output_data.ns->miniimage.
719 (ns_index_color): Fix indentation. Do not retain
720 color_table->colors[i].
722 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
725 * nsfns.m (x_set_background_color): Assign return value from
726 ns_index_color to face-background instead of NSColor*.
727 (ns_implicitly_set_icon_type): Fix indentation.
728 Change assignment in for loop to comparison.
730 * emacs.c (ns_pool): New variable.
731 (main): Assign ns_pool.
732 (Fkill_emacs): Call ns_release_autorelease_pool.
734 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
735 autorelease fdesc, release fdAttrs and tdict.
736 (ns_get_covering_families): Release charset.
737 (ns_findfonts): Release NSFontDescriptor created with new.
738 (ns_uni_to_glyphs): Fix indentation.
739 (setString): Release attrStr before assigning new value.
741 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
743 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
745 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
746 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
748 2011-12-18 David Reitter <reitter@cmu.edu>
750 * nsterm.m (ns_term_init): Subscribe for notifications
751 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
752 to method trackingNotification in EmacsMenu.
754 * nsmenu.m (trackingMenu): New variable.
755 (trackingNotification): New method (from Aquamacs).
756 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
757 from Aquamacs (Bug#7030).
759 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
761 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
762 (symbol_to_nsstring): Fix indentation.
763 (ns_symbol_to_pb): New function.
764 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
765 (Fns_rotate_cut_buffers_internal): Remove.
766 (Fns_store_selection_internal): Rename from
767 Fns_store_cut_buffer_internal.
768 (ns_get_foreign_selection, Fx_own_selection_internal)
769 (Fx_disown_selection_internal, Fx_selection_exists_p)
770 (Fns_get_selection_internal, Fns_store_selection_internal):
771 Use ns_symbol_to_pb and check if return value is nil.
772 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
773 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
774 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
775 renamed to Sns_store_selection_internal.
776 (ns_handle_selection_request): Move code to Fx_own_selection_internal
777 and remove this function.
778 (ns_handle_selection_clear): Remove, never used.
779 (Fx_own_selection_internal): Move code from ns_handle_selection_request
782 2011-12-17 Ken Brown <kbrown@cornell.edu>
784 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
785 GID is unknown (Bug#10257).
787 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
789 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
790 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
791 which caused a build failure on GNU/Linux IA-64. This problem was
792 introduced by my 2011-10-07 patch.
794 2011-12-15 Juri Linkov <juri@jurta.org>
796 * image.c (imagemagick_error): New function. (Bug#10112)
797 (imagemagick_load_image): Comment out `MagickSetResolution' call.
798 Use `imagemagick_error' where ImageMagick functions return
800 (Fimagemagick_types): Add `Fnreverse' to return the list in the
803 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
805 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
806 fill background (Bug#8992).
808 2011-12-13 Martin Rudalics <rudalics@gmx.at>
810 * window.c (Vwindow_combination_resize)
811 (Vwindow_combination_limit): Use t instead of non-nil in
813 (Vrecenter_redisplay): Add first sentence of doc-string on
815 (Frecenter): Fix doc-string typo.
817 2011-12-11 Kenichi Handa <handa@m17n.org>
819 * coding.c (Funencodable_char_position): Pay attention to the
820 buffer text relocation (Bug#9389).
822 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
824 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
825 gtk_init (Bug#10100).
827 2011-12-10 Eli Zaretskii <eliz@gnu.org>
829 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
830 IT->string is nil. (Bug#10263)
832 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
834 * nsterm.h (x_free_frame_resources): Declare.
836 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
837 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
839 * nsterm.h (ns_get_defaults_value): Declare.
841 * nsterm.m (ns_default): Call ns_get_defaults_value.
843 2011-12-09 Eli Zaretskii <eliz@gnu.org>
845 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
848 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
850 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
851 that where the value of an _OBJC_* symbol points to is in the .bss
854 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
856 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
857 after the loop to call ccl_driver at least once (Bug#8619).
859 2011-12-08 Kenichi Handa <handa@m17n.org>
861 * ftfont.c (get_adstyle_property): Fix previous change
864 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
866 * w32.c (init_environment): If no_site_lisp, remove site-lisp
867 dirs from the default value of EMACSLOADPATH (bug#10208).
869 2011-12-07 Glenn Morris <rgm@gnu.org>
871 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
872 installation and source directories as well. (Bug#10208)
874 2011-12-06 Chong Yidong <cyd@gnu.org>
876 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
878 2011-12-06 Glenn Morris <rgm@gnu.org>
880 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
881 as an error, not just -1. (Bug#10217)
883 2011-12-05 Chong Yidong <cyd@gnu.org>
885 * keyboard.c (process_special_events): New function.
886 (swallow_events, Finput_pending_p): Use it (Bug#10195).
888 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
890 * coding.c (encode_designation_at_bol): Don't use uninitialized
891 local variable (Bug#9318).
893 2011-12-05 Kenichi Handa <handa@m17n.org>
895 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
896 return Qnil (Bug#8046, Bug#10193).
898 2011-12-05 Kenichi Handa <handa@m17n.org>
900 * coding.c (encode_designation_at_bol): New args charbuf_end and
901 dst. Return the number of produced bytes. Callers changed.
902 (coding_set_source): Return how many bytes coding->source was
904 (coding_set_destination): Return how many bytes
905 coding->destination was relocated.
906 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
907 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
909 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
911 * coding.c (CODING_CHAR_CHARSET_P): New macro.
912 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
915 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
917 The following changes are to fix Bug#9318.
919 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
920 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
921 (encode_coding_iso_2022, encode_coding_sjis)
922 (encode_coding_big5, encode_coding_charset): Use the above macros.
924 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
926 * lisp.h (process_quit_flag): Fix external declaration.
928 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
930 Don't macro-inline non-performance-critical code.
931 * eval.c (process_quit_flag): New function.
932 * lisp.h (QUIT): Use it.
934 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
936 * nsfns.m (get_geometry_from_preferences): New function.
937 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
939 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
941 * emacs.c (Qkill_emacs): Define.
942 (syms_of_emacs): Initialize it.
943 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
944 Qquit_flag to `kill-emacs' instead.
945 (quit_throw_to_read_char): Add parameter `from_signal'.
946 All callers changed. Call Fkill_emacs if requested and safe.
947 * lisp.h (QUIT): Call Fkill_emacs if requested.
949 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
951 * widget.c (update_wm_hints): Return if wmshell is null.
952 (widget_update_wm_size_hints): New function.
954 * widget.h (widget_update_wm_size_hints): Declare.
956 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
957 widget_update_wm_size_hints (Bug#10104).
959 2011-12-03 Eli Zaretskii <eliz@gnu.org>
961 * xdisp.c (handle_invisible_prop): If the invisible text ends just
962 before a newline, prepare the bidi iterator for consuming the
963 newline, and keep the current paragraph direction. (Bug#10183)
964 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
966 2011-12-02 Juri Linkov <juri@jurta.org>
968 * search.c (Fword_search_regexp): New Lisp function created from
969 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
970 (Fword_search_backward, Fword_search_forward)
971 (Fword_search_backward_lax, Fword_search_forward_lax):
972 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
973 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
975 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
977 * fileio.c (Finsert_file_contents): Move after-change-function call
978 to before the "handled:" label, since all "goto handled" appear in
979 cases where the *-change-functions have already been properly called
982 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
984 * keyboard.c (interrupt_signal): Don't call kill-emacs when
985 waiting for input. (Bug#10169)
987 2011-11-30 Eli Zaretskii <eliz@gnu.org>
989 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
990 verifies glyph row's hash code--we have just reallocated the
991 glyphs, so their contents can be complete garbage. (Bug#10164)
993 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
995 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
997 2011-11-30 Eli Zaretskii <eliz@gnu.org>
999 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1000 attributes are tested _before_ calling verify_row_hash, to protect
1001 against GCC re-ordering of the tests. (Bug#10164)
1003 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1005 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1007 * xterm.c (handle_one_xevent): Only set async_visible and friends
1008 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1009 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1010 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1012 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1014 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1015 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1016 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1017 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1018 All uses changed to use GCPRO1 etc.
1019 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1020 Revert to old implementation (i.e., before 2011-03-11).
1022 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1024 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1025 of scroll runs so as to avoid assigning disabled bogus rows and
1026 unnecessary graphics copy operations.
1028 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1030 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1031 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1032 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1033 (malloc, free, realloc, calloc): Redirect to e_* only when
1036 * lisp.h (GCTYPEBITS): Move before first use.
1037 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1038 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1039 this macro definition.
1041 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1044 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1046 * gtkutil.c (xg_create_frame_widgets):
1047 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1048 present with Gtk+ 2.0.
1050 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1052 * fileio.c (Finsert_file_contents): Undo previous change; see
1053 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1055 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1057 Rename locals to avoid shadowing.
1058 * fileio.c (Finsert_file_contents):
1059 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1060 * process.c (wait_reading_process_output):
1061 Rename inner 'proc' to 'p' to avoid shadowing.
1062 Indent for consistency with usual Emacs style.
1064 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1066 * xdisp.c (redisplay_window): If cursor row is not fully visible
1067 after recentering, and scroll-conservatively is set to a large
1068 number, scroll window by a few more lines to make the cursor fully
1069 visible and out of scroll-margin. (Bug#10105)
1070 (start_display): Don't move to the next line if the display should
1071 start at a newline that is part of a display vector or an overlay
1074 2011-11-24 Juri Linkov <juri@jurta.org>
1076 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1077 after the `MagickPingImage' call. (Bug#10112)
1079 2011-11-23 Chong Yidong <cyd@gnu.org>
1081 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1083 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1085 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1086 making another buffer current. (Bug#10114)
1088 2011-11-23 Glenn Morris <rgm@gnu.org>
1090 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1092 2011-11-23 Chong Yidong <cyd@gnu.org>
1094 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1095 using it (Bug#5984).
1097 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1099 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1100 and header-lines, as they don't have one computed for them.
1103 * .gdbinit (prow): Make displayed values more self-explaining.
1104 Add row's hash code.
1106 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1108 * process.c (wait_reading_process_output): Fix asynchrounous
1109 GnuTLS socket handling on some versions of the GnuTLS library.
1110 (wait_reading_process_output): Add comment and URL.
1112 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1114 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1116 2011-11-21 Chong Yidong <cyd@gnu.org>
1118 * window.c (Fnext_window, Fprevious_window): Doc fix.
1120 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1122 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1124 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1126 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1128 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1130 * window.c (Fset_window_combination_limit): Rename argument
1132 (Vwindow_combination_limit): Remove "status" from doc-string.
1134 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1136 * m/ibms390.h: Remove.
1137 * m/ibms390x.h: Don't include "ibms390.h".
1139 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1141 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1142 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1144 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1146 * casetab.c (Fset_case_table):
1147 * charset.c (Fcharset_after): Fix typos.
1149 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1151 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1152 Otherwise, valgrind does not work on some platforms.
1153 Problem reported by Andreas Schwab in
1154 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1155 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1156 is set, removing the need for VIRT_ADDRESS_VARIES.
1157 (PURE_P): Use a more-efficient implementation that needs just one
1158 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1159 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1160 to 4 (xorl, subq, cmpq, setbe).
1161 * alloc.c (pure): Always extern now, since that's the
1162 VIRT_ADDR_VARIES behavior.
1163 (PURE_POINTER_P): Use a single comparison, not two, for
1164 consistency with the new puresize.h.
1165 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1166 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1167 Remove VIRT_ADDR_VARIES no longer needed.
1169 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1171 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1172 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1173 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1174 behave as if the cursor position were at the window margin.
1176 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1177 and the cursor position is out of bounds, behave as if the cursor
1178 position were at the window margin. (Bug#10075)
1180 2011-11-18 Chong Yidong <cyd@gnu.org>
1182 * window.c (Fwindow_combination_limit): Make first argument
1183 non-optional, since it is meaningless for live windows like the
1186 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1188 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1190 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1192 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1193 (graft_intervals_into_buffer): Simplify.
1195 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1197 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1198 hash values of the two rows.
1199 (copy_row_except_pointers): Preserve the used[] arrays and the
1200 hash values of the two rows. (Bug#10035)
1201 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1203 * xdisp.c (row_hash): New function, body extracted from
1204 compute_line_metrics.
1205 (compute_line_metrics): Call row_hash, instead of computing the
1208 * dispnew.c (verify_row_hash): Call row_hash for computing the
1209 hash code of a row, instead of duplicating code from xdisp.c.
1211 * dispextern.h (row_hash): Add prototype.
1213 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1215 * frame.c (delete_frame): Don't delete the terminal when the last
1216 X frame is closed if emacs is built with GTK toolkit.
1218 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1220 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1222 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1224 * window.c (Vwindow_splits): Rename to
1225 Vwindow_combination_resize. Suggested by Juri Linkov.
1226 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1229 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1231 * nsfns.m (Fns_font_name):
1232 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1234 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1236 * window.h (window): Rename slot "nest" to "combination_limit".
1237 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1238 (Fset_window_nest): Rename to Fset_window_combination_limit.
1239 (Vwindow_nest): Rename to Vwindow_combination_limit.
1240 (recombine_windows, make_parent_window, make_window)
1241 (Fsplit_window_internal, saved_window)
1242 (Fset_window_configuration, save_window_save): Rename all
1243 occurrences of window_nest to window_combination_limit.
1245 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1247 * image.c (imagemagick_load_image): Fix typo.
1249 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1251 * xdisp.c (display_line): Move the call to
1252 highlight_trailing_whitespace before the call to
1253 compute_line_metrics, since the latter needs to see the final
1254 faces of all the glyphs to compute ROW's hash value.
1255 Fixes assertion violations in row_equal_p. (Bug#10035)
1257 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1259 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1260 just return (bug#10044).
1262 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1264 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1265 with user-defined heap size. Bump the default size of the temacs
1266 heap to 27MB, to avoid memory warning when running temacs.
1267 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1269 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1270 current_matrix and desired_matrix. (Bug#9990)
1271 (verify_row_hash) [XASSERTS]: New function.
1272 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1273 that the hash value of glyph rows is correct.
1275 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1277 * window.h (window): Remove splits slot.
1278 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1279 (Fdelete_other_windows_internal, make_parent_window)
1280 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1281 (Fset_window_configuration, save_window_save): Don't deal with
1282 split status of windows.
1283 (saved_window): Remove splits slot.
1284 (Vwindow_splits): Rewrite doc-string.
1286 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1288 * xfns.c (unwind_create_frame):
1289 * nsfns.m (unwind_create_frame):
1290 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1291 Vframe_list (Bug#9999).
1293 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1295 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1297 2011-11-11 Kenichi Handa <handa@m17n.org>
1299 * callproc.c (Fcall_process): Set the member dst_multibyte of
1302 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1304 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1305 avoid a crash (bug#9496).
1307 2011-11-09 Chong Yidong <cyd@gnu.org>
1309 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1310 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1312 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1314 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1316 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1318 Avoid some portability problems by eschewing 'extern inline' functions.
1319 The trivial performance wins aren't worth the portability hassles; see
1320 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1322 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1323 (window_box_width, window_box_left, window_box_left_offset)
1324 (window_box_right, window_box_right_offset): Undo previous change,
1325 by removing the "extern"s.
1326 * intervals.c (adjust_intervals_for_insertion)
1327 (adjust_intervals_for_deletion): Undo previous change,
1328 making these static again.
1329 (offset_intervals, temp_set_point_both, temp_set_point)
1330 (copy_intervals_to_string): No longer inline.
1331 * xdisp.c (window_text_bottom_y, window_box_width)
1332 (window_box_height, window_box_left_offset)
1333 (window_box_right_offset, window_box_left, window_box_right)
1334 (window_box): No longer inline.
1336 2011-11-08 Chong Yidong <cyd@gnu.org>
1338 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1339 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1340 Signal an error if not a live window.
1341 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1342 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1344 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1346 * lisp.h (syms_of_abbrev): Remove declaration.
1347 Reported by CHENG Gao <chenggao@royau.me>.
1349 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1351 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1352 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1353 of temacs in GUI mode.
1355 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1357 * window.h: Declare delete_all_child_windows instead of
1358 delete_all_subwindows.
1359 * window.c (Fwindow_nest, Fset_window_nest)
1360 (Fset_window_new_total, Fset_window_new_normal)
1361 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1362 (delete_all_subwindows): Rename to delete_all_child_windows.
1363 (Fdelete_other_windows_internal, Fset_window_configuration):
1364 Call delete_all_child_windows instead of delete_all_subwindows.
1365 * frame.c (delete_frame): Call delete_all_child_windows instead
1366 of delete_all_subwindows.
1368 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1370 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1371 This is also needed for porting to any host where GC_MARK_STACK is
1372 not GC_MAKE_GCPROS_NOOPS.
1373 (which_symbols): Use it.
1375 2011-11-07 Kenichi Handa <handa@m17n.org>
1377 * coding.c (coding_set_destination): Check coding->src_pos only
1378 when coding->src_object is a buffer (bug#9910).
1380 * process.c (send_process): Set the member src_multibyte of coding
1381 to 0 (bug#9911) when sending a unibyte text.
1383 * callproc.c (Fcall_process): Set the member src_multibyte of
1384 process_coding to 0 (bug#9912).
1386 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1388 * xmenu.c (cleanup_widget_value_tree): New function.
1389 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1390 calling free_menubar_widget_value_tree directly (Bug#9830).
1392 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1394 Fix some portability problems with 'inline'.
1395 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1396 (window_box_width, window_box_left, window_box_left_offset)
1397 (window_box_right, window_box_right_offset): Declare extern.
1398 Otherwise, these inline functions do not conform to C99 and
1399 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1400 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1401 * intervals.c (adjust_intervals_for_insertion)
1402 (adjust_intervals_for_deletion): Now extern, because otherwise the
1403 extern inline functions 'offset_intervals' couldn't refer to it.
1404 (static_offset_intervals): Remove.
1405 (offset_intervals): Rewrite using the old contents of
1406 static_offset_intervals. The old version didn't conform to C99
1407 because an extern inline function contained a reference to an
1408 identifier with static linkage.
1410 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1412 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1415 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1417 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1418 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1419 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1420 return Qleft_to_right.
1422 2011-11-06 Chong Yidong <cyd@gnu.org>
1424 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1425 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1426 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1427 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1428 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1429 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1430 (Fwindow_vscroll): Doc fix.
1431 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1432 argument, since it makes no sense to pass a live window and for
1433 consistency with window-child.
1435 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1437 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1440 2011-11-05 Jason Rumney <jasonr@gnu.org>
1442 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1443 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1445 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1446 bitwise arithmetic preventing use of unicode-sip and non-truetype
1449 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1451 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1454 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1455 initialization code to keep similarity to xfns.c after changes
1458 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1460 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1461 (unwind_create_frame): New function (Bug#9943).
1462 (Fx_create_frame): Restructure code to be more similar to the one in
1463 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1464 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1465 Move terminal->reference_count++ just before making the frame official
1468 * nsterm.m (x_free_frame_resources): New function.
1469 (x_destroy_window): Move code to x_free_frame_resources.
1471 * xfns.c (unwind_create_frame): Fix comment.
1472 (Fx_create_frame, x_create_tip_frame):
1473 Move terminal->reference_count++ just before making the frame
1474 official. Move initialization of image_cache_refcount and
1475 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1477 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1479 Support MSVC build with newer versions of Visual Studio.
1480 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1481 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1484 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1485 which are not supported by MSVC.
1486 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1487 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1489 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1491 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1493 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1495 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1497 Support MSVC build with newer versions of Visual Studio.
1498 * w32.c: Don't include w32api.h for MSVC.
1499 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1501 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1502 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1503 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1504 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1506 (alloca) [_MSC_VER]: Define to _alloca.
1508 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1510 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1512 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1514 * xdisp.c (note_mouse_highlight): If either of
1515 previous/next-single-property-change returns nil, treat that as
1516 the beginning or the end of the buffer. (Bug#9955)
1518 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1520 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1521 label is not null (Bug#9951).
1522 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1525 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1527 * window.c (Fwindow_body_size): Mention in the doc string that the
1528 return value is in frame's canonical units. (Bug#9949)
1530 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1532 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1534 * w32fns.c (unwind_create_frame): If needed, free the glyph
1535 matrices of the partially constructed frame. (Bug#9943)
1536 * xfns.c (unwind_create_frame): Likewise.
1538 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1540 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1541 Don't stop backward scan on the continuation glyph, even though
1542 its CHARPOS is positive.
1543 (mouse_face_from_buffer_pos, note_mouse_highlight):
1544 Rename cover_string to disp_string.
1546 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1548 * window.c (temp_output_buffer_show): Don't use
1549 Vtemp_buffer_show_specifiers.
1550 (Vtemp_buffer_show_specifiers): Remove unused variable.
1552 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1554 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1555 past the beginning of the current glyph matrix.
1557 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1559 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1560 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1561 HAVE_GTK3 (Bug#9869).
1563 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1564 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1566 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1568 * xterm.c: Declare x_handle_net_wm_state to return int.
1569 (handle_one_xevent): Check if we are iconified but don't have
1570 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1571 (get_current_wm_state): Return non-zero if not hidden,
1572 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1573 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1574 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1575 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1577 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1579 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1580 so that this new function doesn't get optimized away by a
1581 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1583 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1585 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1587 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1589 Fix the `xbytecode' command.
1590 * .gdbinit (xprintbytestr): New command.
1591 (xwhichsymbols): Rename from `which'; all callers changed.
1592 (xbytecode): Print the byte-code string as well.
1594 2011-10-29 Kim Storm <storm@cua.dk>
1596 * alloc.c (which_symbols): New function.
1598 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1600 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1603 2011-10-29 Glenn Morris <rgm@gnu.org>
1605 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1606 Not clear what it was for, and it causes various bugs. (Bug#9839)
1608 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1610 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1611 possible random value that matches one of those tested as
1612 condition to clear the mouse face.
1614 2011-10-28 Chong Yidong <cyd@gnu.org>
1616 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1618 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1620 * window.c (make_window): Initialize phys_cursor_on_p.
1622 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1624 * lisp.h (struct Lisp_Symbol): Update comments.
1626 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1628 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1630 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1632 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1633 <oslsachem@gmail.com> for helping to debug this.
1635 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1636 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1637 (g_b_init_get_glyph_outline_w): New static variables.
1638 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1639 (GetGlyphOutlineW_Proc): New typedefs.
1640 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1641 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1643 (w32font_open_internal, compute_metrics):
1644 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1645 instead of calling the "wide" APIs directly.
1647 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1649 * w32.h (syms_of_w32font): Add prototype.
1651 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1653 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1654 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1655 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1656 (Fmove_to_window_line): Doc fix.
1658 2011-10-27 Chong Yidong <cyd@gnu.org>
1660 * process.c (make_process): Set gnutls_state to NULL.
1662 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1663 non-NULL, regardless of GNUTLS_INITSTAGE.
1664 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1665 an error. Set process slots as soon as we allocate them.
1667 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1669 2011-10-27 Chong Yidong <cyd@gnu.org>
1671 * gnutls.c (emacs_gnutls_deinit): New function.
1672 Deallocate credentials structures as well as calling gnutls_deinit.
1673 (Fgnutls_deinit, Fgnutls_boot): Use it.
1675 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1676 (deactivate_process): Call emacs_gnutls_deinit.
1678 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1680 * image.c (x_create_x_image_and_pixmap):
1681 * w32.c (sys_rename, w32_delayed_load):
1682 * w32font.c (fill_in_logfont):
1683 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1685 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1687 * w32fns.c (w32_default_color_map): New function,
1688 extracted from Fw32_default_color_map.
1689 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1691 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1693 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1695 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1697 * keyboard.c (test_undefined): New function (bug#9751).
1698 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1700 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1702 * sysdep.c (init_sys_modes): Fix the check for the controlling
1703 terminal (Bug#6649).
1705 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1707 * dispextern.h (struct bidi_it): New member next_en_type.
1709 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1710 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1711 current character, check also for next_en_type being WEAK_EN.
1712 (bidi_resolve_weak): Don't enter the expensive loop if the current
1713 position is before next_en_pos. Record the bidi type of the first
1714 non-ET, non-BN character we find, in addition to its position.
1715 (bidi_level_of_next_char): Invalidate next_en_type when
1716 next_en_pos is over-stepped.
1718 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1720 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1721 * editfns.c: Rewrite current-time-zone so that it invokes
1722 the equivalent of (format-time-string "%Z") to get the time zone name.
1723 This fixes a bug when the time zone name contains characters that
1724 need converting from the system time locale to Emacs internal format.
1725 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1726 that patch fixed format-time-string to do the conversion, but
1727 I forgot to fix current-time-zone.
1728 (format_time_string): New function, containing most of
1729 what Fformat_time_string used to contain.
1730 (Fformat_time_string): Rewrite in terms of format_time_string.
1731 This doesn't change this function's behavior.
1732 (current-time-zone): Rewrite to use format_time_string.
1733 This fixes the bug reported by Michael Schierl in
1734 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1735 Jason Rumney's 2007-06-07 change worked around this bug, but
1737 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1739 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1741 * xdisp.c (start_display): If the character at POS is displayed
1742 via a display vector, reset IT->current.dpvec_index to zero.
1743 (try_window_reusing_current_matrix): If a line ends in a display
1744 vector or the next line starts in a display vector, continue
1745 redrawing the window even though the character position of
1746 start_row was reached.
1749 2011-10-18 Chong Yidong <cyd@gnu.org>
1751 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1752 with nobreak-char-display too.
1754 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1756 Fix part 3 of bug#9771.
1757 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1758 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1759 non-neutral characters if the current character is a paragraph
1760 separator (a.k.a. Newline). This avoids running the same
1761 expensive loop twice, once when we consume the preceding newline
1762 and the other time when the line actually needs to be displayed.
1763 Avoid the loop when we see neutrals on the base embedding level
1764 following a character whose directionality is the same as the
1765 paragraph's. This avoids running the expensive loop when a line
1766 ends in a long sequence of neutrals, like control characters.
1767 Add assertion against STRONG_AL type. Slightly rearrange code
1768 that determines the type of a neutral given the first non-neutral
1770 (bidi_level_of_next_char): Set next_en_pos to zero when
1771 invalidating its info.
1773 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1775 * xdisp.c (push_display_prop): Determine whether to record string
1776 or buffer position by IT->string, not by IT->method. Allow
1777 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1778 (move_it_vertically_backward): Don't look for character position
1779 immediately after the newline when in a continuation line.
1782 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1784 * window.c (coordinates_in_window): Rewrite and delabelize
1785 vertical border check. (Bug#5357) (Bug#9618)
1787 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1789 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1790 errors in XSetWindowBorder (bug#9310).
1792 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1794 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1795 avoid crash when xmalloc overrun checking is enabled.
1797 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1799 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1800 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1801 cursor motion with <left> and <right> arrow keys.
1803 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1804 some callers set that themselves.
1806 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1808 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1809 display string and the previous row comes from the same string and
1810 is empty. (Bug#9739) (Bug#9738)
1812 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1814 * doc.c (get_doc_string): Encode file name (bug#9735).
1816 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1818 * bidi.c (bidi_level_of_next_char):
1819 * xdisp.c (get_visually_first_element): Remove old incorrect
1820 comments regarding the Unicode Line Separator character.
1822 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1824 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1826 * alloc.c (Fgc_status): Do not access beyond zombies array
1827 boundary if nzombies > MAX_ZOMBIES.
1828 * alloc.c (dump_zombies): Add missing format specifier.
1830 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1832 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1833 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1835 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1836 Some packages use them to denote characters with modifiers.
1838 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1840 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1841 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1842 matching a pp-number. Rename parameter var to var1.
1844 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1846 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1848 2011-10-08 Glenn Morris <rgm@gnu.org>
1850 * callint.c (Fcall_interactively): Give a more explicit error for the
1851 'c' case with a non-character input. (Bug#8479)
1853 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1855 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1857 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1858 lines that are hscrolled on the left.
1860 * dispnew.c (buffer_posn_from_coords): Account for a possible
1861 presence of header-line. (Bug#4426)
1863 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1865 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1866 Don't advertise functionality which we discourage or doesn't work.
1868 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1870 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1871 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1872 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1873 this makes Emacs dump core during garbage collection on rare
1874 occasions. sizeof is obviously inferior to offsetof here, so
1875 stick with offsetof.
1876 (GC_POINTER_ALIGNMENT): New macro.
1877 (mark_memory): Omit 3rd (offset) arg; caller changed.
1878 Don't assume EMACS_INT alignment is the same as pointer alignment.
1880 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1882 * keyboard.c (read_key_sequence_remapped): New var.
1883 (read_key_sequence): Compute remapping in the right buffer.
1884 (command_loop_1): Use read_key_sequence's remapping directly.
1886 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1888 * dired.c (file_name_completion): Don't expand file name.
1889 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1890 before checking file name handler.
1892 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1893 they've been requested explicitly (bug#9591).
1895 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1897 * keymap.c (Fsingle_key_description): Use make_specified_string
1898 instead of build_string to build string from push_key_description.
1901 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1903 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1904 This fixes a Y2038 bug on 64-bit hosts.
1905 * buffer.c (reset_buffer):
1906 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1907 (Fclear_buffer_auto_save_failure):
1908 Use 0, not -1, to represent an unset failure time, since time_t
1909 might not be signed.
1911 Remove dependency on glibc malloc internals.
1912 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1913 Move back here from lisp.h, but with their new implementations.
1914 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1915 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1916 * charset.c (charset_table_init): New static var.
1917 (syms_of_charset): Use it instead of xmalloc. This removes a
1918 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1919 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1920 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1921 Move back to alloc.c.
1922 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1923 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1925 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1927 * nsterm.m (windowDidResize): Call x_set_window_size only when
1928 ns_in_resize is true. Otherwise set pixelwidth/height and
1929 call change_frame_size (Bug#9628).
1931 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1933 Port --enable-checking=all to Fedora 14 x86-64.
1934 * charset.c (syms_of_charset): Also account for glibc malloc's
1935 internal overhead when calculating the initial malloc maximum.
1937 Port --enable-checking=all to Fedora 14 x86.
1938 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1940 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1941 (overrun_check_realloc, overrun_check_free):
1942 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1943 That way, xmalloc returns a properly-aligned pointer even if
1944 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1945 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1946 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1947 into account when calculating the initial malloc maximum.
1948 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1949 Move here from alloc.c, so that charset.c can use it too.
1950 Properly align; the old code wasn't right for common 32-bit hosts
1951 when configured with --enable-checking=all.
1952 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1953 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1955 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1957 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1960 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1962 * xdisp.c (compute_display_string_end): If there's no display
1963 string at CHARPOS, return -1.
1965 * bidi.c (bidi_fetch_char): When compute_display_string_end
1966 returns a negative value, treat the character as a normal
1967 character not covered by a display string. (Bug#9624)
1969 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1971 * lread.c (Fread_from_string): Fix typo in docstring.
1973 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1975 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1976 newline, reseat the iterator instead of bidi-iterating there one
1977 character at a time. (Bug#9610)
1978 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1979 TO_CHARPOS if the bidi iterator is at base embedding level.
1981 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1983 * lread.c (readevalloop): Use correct code for NBSP.
1984 (read1): Likewise. (Bug#9608)
1986 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1988 * dbusbind.c (Fdbus_register_signal): When service is not
1989 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1991 2011-09-25 Glenn Morris <rgm@gnu.org>
1993 * buffer.c (truncate-lines): Doc fix.
1995 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1997 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1998 (Fset_window_next_buffers): Doc fix.
2000 2011-09-24 Glenn Morris <rgm@gnu.org>
2002 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2004 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2006 Fix minor problems found by static checking.
2007 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2008 * indent.c (Fvertical_motion): Fix == vs = typo.
2010 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2012 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2013 Default value is now t. Doc fix.
2015 * indent.c (Fvertical_motion): Compute and apply the overshoot
2016 logic when moving up, not only when moving down. Fix the
2017 confusing name and values of the it_overshoot_expected variable;
2018 logic changes accordingly. (Bug#9254) (Bug#9549)
2020 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2021 CHARPOS is covered by a display string which includes newlines.
2022 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2023 is covered by a display string with embedded newlines.
2025 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2027 * dbusbind.c (Fdbus_register_signal): Add match rule to
2028 Vdbus_registered_objects_table. (Bug#9581)
2029 (Fdbus_register_method, Vdbus_registered_objects_table):
2032 2011-09-24 Jim Meyering <meyering@redhat.com>
2034 do not ignore write error for any output size
2035 The previous change was incomplete.
2036 While it makes emacs --batch detect the vast majority of stdout
2037 write failures, errors were still ignored whenever the output size is
2038 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2039 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2040 && echo FAIL: ignored write error
2041 FAIL: ignored write error
2042 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2043 && echo FAIL: ignored write error
2044 FAIL: ignored write error
2045 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2047 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2049 * emacs.c (Fkill_emacs): In noninteractive mode exit
2050 non-successfully if a write error occurred on stdout. (Bug#9574)
2052 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2054 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2057 * dispextern.h (struct it): Update the comment documenting what
2060 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2062 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2063 a display string, extend search for cursor position to end of row.
2064 (find_row_edges): If the row ends in a newline from a display
2065 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2066 Handle the case of a display string with multiple newlines.
2067 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2068 non-empty line. Fixes confusing cursor motion with arrow keys at
2069 the beginning of a line that starts with whitespace.
2071 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2073 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2076 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2078 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2081 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2083 * xdisp.c (display_line): Record maximum and minimum buffer
2084 positions even if no glyphs were produced (e.g., by a zero-width
2085 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2086 buffer positions that will be removed from the glyph row because
2088 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2089 column is beyond frame width: don't subtract 1 "pixel" when
2090 computing width of the stretch.
2091 (reseat_at_next_visible_line_start): Undo the change made on
2092 2011-09-17 that saved paragraph information and restored it after
2093 the call to `reseat'. (Bug#9545)
2095 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2097 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2098 and turn window cursor on if cleared (Bug#9415).
2100 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2102 * search.c (boyer_moore): Take unibyte characters from pattern
2103 literally. (Bug#9458)
2105 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2107 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2109 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2111 Fix minor problem found by static checking.
2112 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2113 initialized, to pacify gcc -Wuninitialized.
2115 * fileio.c: Report proper errno when syscall falls.
2116 (Finsert_file_contents): Save and restore errno,
2117 so that report_file_error outputs the correct diagnostic.
2118 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2120 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2122 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2124 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2126 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2127 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2129 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2131 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2132 about the current paragraph and restore it after the call to reseat.
2134 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2135 (bidi_find_paragraph_start): Search back for paragraph beginning
2136 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2137 (bidi_move_to_visually_next): Only trigger paragraph-related
2138 computations when the last character is a newline or at EOB, not
2139 just any NEUTRAL_B. (Bug#9470)
2141 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2142 truncated lines if point is covered by a display string. (Bug#9524)
2144 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2146 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2147 (cons_to_x_long): New function.
2148 (lisp_data_to_selection_data): Use it. Correct the test for
2149 short-versus-long data; it was negated. Break out of vector
2150 loop, for efficiency, when a long datum is discovered.
2152 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2154 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2156 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2158 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2159 GCC PR/17406) by declaring this function with external scope.
2161 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2163 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2164 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2166 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2168 * editfns.c (Fformat): Correctly handle text properties on "%%".
2170 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2172 * xterm.c (x_draw_composite_glyph_string_foreground):
2173 * w32term.c (x_draw_composite_glyph_string_foreground):
2174 * term.c (encode_terminal_code):
2175 * composite.c (composition_update_it, get_composition_id):
2176 * xdisp.c (get_next_display_element)
2177 (fill_composite_glyph_string): Add comments about special meaning
2178 of TAB characters in a composition.
2180 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2182 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2183 This occurs when processing a multibyte format.
2184 Problem reported by Wolfgang Jenker.
2186 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2188 * xdisp.c (try_cursor_movement): Only check for exact match if
2189 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2191 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2193 Remove unused external symbols.
2194 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2195 * xdisp.c (calc_pixel_width_or_height): Now static.
2196 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2197 * indent.c (check_display_width):
2198 * w32term.c: Fix comment to match code.
2199 * xterm.c, xterm.h (x_catching_errors): Remove.
2201 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2203 * xselect.c: Use signed conversions more consistently (Bug#9498).
2204 (selection_data_to_lisp_data): Assume incoming selection data are
2205 signed integers, not unsigned. This is to be consistent with
2206 outgoing selection data, which was modified to use signed integers
2207 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2208 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2209 expects long, not unsigned long.
2211 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2213 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2214 computation of loop end. Reported by Johan Bockgård
2217 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2219 * frame.c (Fother_visible_frames_p): Function deleted.
2221 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2223 * indent.c (compute_motion): Process display vector front to back
2224 rather than the other way around. (Bug#2496)
2226 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2228 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2230 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2232 * minibuf.c (Fread_from_minibuffer): Doc fix.
2234 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2236 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2237 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2239 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2241 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2242 value for non-existent files.
2244 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2246 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2247 set its "size" to -1. This will set the modtime_size field of
2248 the corresponding buffer to -1, which is what
2249 verify-visited-file-modtime expects for files that do not exist.
2252 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2254 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2256 * lisp.h: ... from here. push_key_description is no longer
2257 defined in keyboard.c, so its declaration should not be in
2258 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2259 logically belongs with push_key_description.
2261 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2263 * buffer.h: Include <sys/types.h> instead of <time.h>.
2264 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2265 Problem reported by Herbert J. Skuhra.
2267 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2269 * xml.c (parse_region): Make the parsing work for
2270 non-comment-starting XML files again (bug#9144).
2272 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2274 * image.c (gif_load): Fix calculation of bottom and right corner.
2277 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2279 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2280 redisplay in small windows.
2282 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2284 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2286 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2288 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2289 Operate on live windows only.
2291 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2293 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2295 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2297 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2298 only under bidi iteration.
2300 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2302 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2304 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2306 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2307 Without this fix, the command to link temacs failed due to an
2308 undefined symbol __builtin_isnan. This is because
2309 /usr/include/iso/math_c99.h #defines isnan(x) to
2310 __builtin_isnan(x), but the bundled gcc, which identifies itself
2311 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2313 * floatfns.c (isnan): #undef, and then #define to a clone of
2315 (Fisnan): Always define, since it's always available now.
2316 (syms_of_floatfns): Always define isnan at the Lisp level.
2318 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2320 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2322 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2324 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2325 The previous code assumed that file offsets (off_t values) fit in
2326 EMACS_INT variables, which is not true on typical 32-bit hosts.
2327 The code messed up by falsely reporting buffer overflow in cases
2328 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2329 when "big" contains more than 2**29 bytes, even though this
2330 inserts just one byte and does not overflow the buffer.
2331 (Finsert_file_contents): Store file offsets as off_t
2332 values, not as EMACS_INT values. Check for overflow when
2333 converting between EMACS_INT and off_t. When checking for
2334 buffer overflow or for overlap, take the offsets into account.
2335 Don't use EMACS_INT for small values where int suffices.
2336 When checking for overlap, fix a typo: ZV was used where
2337 ZV_BYTE was intended.
2338 (Fwrite_region): Don't assume off_t fits into 'long'.
2339 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2341 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2343 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2345 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2347 sprintf-related integer and memory overflow issues (Bug#9412).
2349 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2350 (esprintf, exprintf, evxprintf): New functions.
2351 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2352 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2353 (modify_event_symbol): Do not assume that the length of
2354 name_alist_or_stem is safe to alloca and fits in int.
2355 (Fexecute_extended_command): Likewise for function name and binding.
2356 (Frecursion_depth): Wrap around reliably on integer overflow.
2357 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2358 since some callers pass EMACS_INT values.
2359 (Fsingle_key_description): Don't crash if symbol name contains more
2360 than MAX_ALLOCA bytes.
2361 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2362 (get_minibuffer): Arg is now EMACS_INT, not int.
2363 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2364 (esprintf, exprintf, evxprintf): New decls.
2365 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2367 * dbusbind.c (signature_cat): New function.
2368 (xd_signature, Fdbus_register_signal):
2369 Do not overrun buffer; instead, report string overflow.
2371 * dispnew.c (add_window_display_history): Don't overrun buffer.
2372 Truncate instead; this is OK since it's just a log.
2374 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2375 even if the time zone offset is outlandishly large.
2376 Don't mishandle offset == INT_MIN.
2378 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2379 when creating daemon; the previous buffer-overflow check was incorrect.
2381 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2382 which has the guts of the old verror function.
2384 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2385 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2387 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2388 (font_unparse_xlfd): Don't blindly alloca long strings.
2389 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2390 fits in int, when using sprintf. Use single snprintf to count
2391 length of string rather than counting it via multiple sprintfs;
2392 that's simpler and more reliable.
2393 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2394 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2395 sprintf, in case result does not fit in int.
2397 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2398 (fontset_from_font): Print it.
2400 * frame.c (tty_frame_count): Now printmax_t, not int.
2401 (make_terminal_frame, set_term_frame_name): Print it.
2402 (x_report_frame_params): In X, window IDs are unsigned long,
2403 not signed long, so print them as unsigned.
2404 (validate_x_resource_name): Check for implausibly long names,
2405 and don't assume name length fits in 'int'.
2406 (x_get_resource_string): Don't blindly alloca invocation name;
2407 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2410 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2411 (xg_check_special_colors, xg_set_geometry):
2412 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2414 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2415 Use esprintf, not sprintf, in case result does not fit in int.
2417 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2418 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2419 it as a large positive number.
2420 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2421 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2423 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2424 in case result does not fit in int.
2426 * print.c (float_to_string): Detect width overflow more reliably.
2427 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2428 buffer overrun. Don't assume list length fits in 'int'. Treat
2429 print length of 0 as 0, not as infinity; to be consistent with other
2430 uses of print length in this function. Don't overflow print length
2431 index. Don't assume hash table size fits in 'long', or that
2432 vectorlike size fits in 'unsigned long'.
2434 * process.c (make_process): Use printmax_t, not int, to format
2435 process-name gensyms.
2437 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2439 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2440 to avoid potential buffer overrun.
2442 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2443 if X resource line is longer than 512 bytes.
2445 * xfns.c (x_window): Make sprintf buffer a bit bigger
2446 to avoid potential buffer overrun.
2448 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2450 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2452 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2454 Integer overflow fixes for scrolling, etc.
2455 Without these, Emacs silently mishandles large integers sometimes.
2456 For example, "C-u 4294967297 M-x recenter" was treated as if
2457 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2459 * xdisp.c (try_window_id): Check Emacs fixnum range before
2460 converting to 'int'.
2462 * window.c (window_scroll_line_based, Frecenter):
2463 Check that an Emacs fixnum is in range before assigning it to 'int'.
2464 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2465 values converted from Emacs fixnums.
2466 (Frecenter): Don't wrap around a line count if it is out of 'int'
2467 range; instead, treat it as an extreme value.
2468 (Fset_window_configuration, compare_window_configurations):
2469 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2471 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2472 that can exceed INT_MAX. Check that EMACS_INT value is in range
2473 before assigning it to the (possibly-narrower) index.
2474 (match_limit): Don't assume that a fixnum can fit in 'int'.
2476 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2479 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2480 (Fvertical_motion): Don't wrap around LINES values that don't fit
2481 in 'int'. Instead, treat them as extreme values. This is good
2482 enough for windows, which can't have more than INT_MAX lines anyway.
2484 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2486 * Require libxml/parser.h to avoid compilation warning.
2488 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2490 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2491 since this reportedly can destroy thread storage.
2493 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2495 * syntax.c (find_defun_start): Update all cache variables if
2496 exiting early (Bug#9401).
2498 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2500 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2502 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2503 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2504 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2506 * term.c (tty_append_glyph): New function.
2507 (produce_stretch_glyph): Static function and its prototype deleted.
2509 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2512 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2514 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2515 when checking :margin (Bug#9390).
2516 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2517 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2518 so that the name doesn't mislead. All uses changed.
2520 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2522 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2525 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2527 * xdisp.c (move_it_to): Don't bail out early when reaching
2528 position beyond to_charpos, if we are scanning backwards.
2529 (move_it_vertically_backward): When DY == 0, make sure we get to
2530 the first character in the line after the newline.
2532 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2534 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2535 (ccl_driver): Do not generate an out-of-range pointer.
2536 (Fccl_execute_on_string): Remove unnecessary check for
2537 integer overflow, noted by Stefan Monnier in
2538 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2539 Remove a FIXME that didn't need fixing.
2540 Simplify the newly-introduced buffer reallocation code.
2542 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2544 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2546 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2548 Integer and memory overflow issues (Bug#9196).
2550 * doc.c (get_doc_string): Rework so that
2551 get_doc_string_buffer_size is the actual buffer size, rather than
2552 being 1 less than the actual buffer size; this makes xpalloc more
2555 * image.c (x_allocate_bitmap_record, cache_image):
2556 * xselect.c (Fx_register_dnd_atom):
2557 Simplify previous changes by using xpalloc.
2559 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2560 since either will do and ptrdiff_t is convenient with xpalloc.
2562 * charset.c (charset_table_size)
2563 (struct charset_sort_data.priority): Now ptrdiff_t.
2564 (charset_compare): Don't overflow if priorities differ greatly.
2565 (Fsort_charsets): Don't assume list length fits in int.
2566 Check for size-calculation overflow when allocating sort data.
2567 (syms_of_charset): Allocate an initial charset table that is
2568 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2570 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2572 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2573 The actual value is always <= INT_MAX, and leaving it unsigned made
2574 overflow checking harder.
2576 * dispextern.h (struct glyph_matrix.rows_allocated)
2577 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2578 with xpalloc. The values are still always <= INT_MAX.
2580 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2582 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2583 (SAFE_NALLOCA): New macro.
2585 * region-cache.c (struct boundary.pos, find_cache_boundary)
2586 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2587 (set_cache_region, invalidate_region_cache)
2588 (revalidate_region_cache, know_region_cache, region_cache_forward)
2589 (region_cache_backward, pp_cache):
2590 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2591 so that ptrdiff_t * can be passed to xpalloc.
2592 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2593 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2594 (pp_cache): Don't assume cache_len fits in int.
2595 * region-cache.h: Adjust extern decls to match.
2597 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2598 EMACS_INT, since either will do, for xpalloc.
2600 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2601 (xnmalloc, xnrealloc, xpalloc): New functions.
2603 * bidi.c (bidi_shelve_header_size): New constant.
2604 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2605 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2607 * bidi.c (bidi_cache_shrink):
2608 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2610 Don't update size of array until after memory allocation succeeds,
2611 because xmalloc/xrealloc may not return.
2612 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2613 now that we have proper integer overflow checking.
2614 (record_overlay_string, overlay_strings): Catch overflows when
2615 calculating size of overlay_str_buf.
2617 * callproc.c (Fcall_process): Check for size overflow when
2618 calculating size of args2.
2619 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2620 Normally we prefer signed values, but sticking with ptrdiff_t would
2621 require adding more-complicated checks.
2623 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2624 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2625 Redo buffer-overflow calculations to avoid integer overflow.
2626 Add a FIXME comment where memory seems to be over-allocated.
2628 * character.c (Fstring): Check for size-calculation overflow.
2630 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2631 unnecessary integer overflow. Check for size overflow.
2632 (encode_coding_object): Don't update size until xmalloc succeeds.
2634 * composite.c (get_composition_id): Check for overflow in glyph
2635 length calculations.
2637 Integer and memory overflow fixes for display code.
2638 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2639 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2640 (scrolling_window): Check for overflow in size calculations.
2641 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2642 Don't assume glyph table len fits in int.
2643 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2644 (row_table_size): Now ptrdiff_t, not int.
2645 (scrolling_window): Avoid overflow in size calculations.
2646 Don't update size until allocation succeeds.
2647 * fns.c (concat): Check for overflow in size calculations.
2648 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2649 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2650 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2652 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2653 (get_doc_string): Check for size calculation overflow.
2654 Don't update size until allocation succeeds.
2655 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2656 EMACS_INT, where ptrdiff_t will do.
2657 (Fsubstitute_command_keys): Check for string overflow.
2659 * editfns.c (set_time_zone_rule): Don't assume environment length
2661 (message_length): Now ptrdiff_t, not int.
2662 (Fmessage_box): Don't update size until allocation succeeds.
2663 Don't assume message length fits in int.
2664 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2666 * emacs.c (main): Do not reallocate argv, since there is a null at
2667 the end that can be overwritten, and this way there's no need to
2668 worry about size-calculation overflow.
2669 (sort_args): Check for size-calculation overflow.
2671 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2673 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2675 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2676 (x_set_scroll_bar_width, x_figure_window_size):
2677 Check for integer overflow.
2678 (x_set_alpha): Do not assume XINT fits in int.
2680 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2681 This is for the members text_lines, text_cols, total_lines, total_cols,
2682 where the system imposes an 'int' limit.
2684 * fringe.c (Fdefine_fringe_bitmap):
2685 Don't update size until alloc works.
2687 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2688 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2690 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2691 Check for size-calculation overflow.
2692 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2693 do, as we prefer signed integers.
2694 (id_to_widget.max_size, id_to_widget.used)
2695 (xg_store_widget_in_map, xg_remove_widget_from_map)
2696 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2697 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2698 Use and return ptrdiff_t, not int.
2699 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2700 * gtkutil.h: Change prototypes to match the above.
2702 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2703 are duplicate now that they've been promoted to lisp.h.
2704 (x_allocate_bitmap_record, x_alloc_image_color)
2705 (make_image_cache, cache_image, xpm_load):
2706 Don't update size until alloc is done.
2707 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2709 Check for size calculation overflow.
2710 (ct_colors_allocated_max): New constant.
2711 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2714 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2715 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2716 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2717 Use ptrdiff_t, not int, to count maps.
2718 (read_char_minibuf_menu_prompt): Check for overflow in size
2719 calculations. Don't update size until allocation succeeds.
2720 Redo calculations to avoid overflow.
2721 * keyboard.h: Change prototypes to match the above.
2723 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2725 (current_minor_maps): Check for size calculation overflow.
2726 * keymap.h: Change prototypes to match the above.
2728 * lread.c (read1, init_obarray): Don't update size until alloc done.
2730 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2731 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2733 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2734 Now ptrdiff_t, not int.
2735 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2736 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2738 * process.c (Fnetwork_interface_list): Check for overflow
2739 in size calculation.
2741 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2743 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2744 overflow. Don't bother calling xmalloc when xrealloc will do.
2746 * search.c (Freplace_match): Check for size calculation overflow.
2747 (Fset_match_data): Don't assume list lengths fit in 'int'.
2749 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2750 for command line length. Do not attempt to address one before the
2751 beginning of an array, as that's not portable.
2753 * term.c (max_frame_lines): Remove; unused.
2754 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2756 (encode_terminal_code, calculate_costs): Check for size
2757 calculation overflow.
2758 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2759 table lengths and related sizes. Don't update size until alloc
2760 done. Redo calculations to avoid overflow.
2761 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2763 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2764 subtracting pointers.
2765 (gobble_line): Check for overflow more carefully. Don't update size
2768 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2769 Don't update size until alloc done.
2770 Redo size calculations to avoid overflow.
2771 Check for size calculation overflow.
2772 (main) [DEBUG]: Fix typo in invoking tparam1.
2774 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2775 Use ptrdiff_t, not int, for sizes.
2776 (store_mode_line_noprop_char): Don't update size until alloc done.
2778 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2779 Use ptrdiff_t, not int, for sizes.
2780 (Finternal_make_lisp_face, cache_face):
2781 Check for size calculation overflow.
2782 (cache_face): Treat size calculation overflows as if they were
2783 memory exhaustion (the usual treatment), rather than aborting.
2785 * xfns.c (x_encode_text, x_set_name_internal)
2786 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2787 sizes, since they can exceed INT_MAX in size. Check for size
2788 calculation overflow.
2790 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2791 (xg_select): Check for size calculation overflow.
2792 Don't update size until alloc done.
2794 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2795 as sprintf is limited to int lengths.
2797 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2798 (X_LONG_MIN): New macros.
2799 Use them to make the following changes clearer.
2800 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2801 This change doesn't affect the value now, but it may help remind
2802 future maintainers not to raise the value too much later.
2803 (SELECTION_QUANTUM): Remove, replacing with ...
2804 (selection_quantum): ... new function, which avoids overflow.
2806 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2807 assumption that selection length fits in 'int'.
2808 (x_reply_selection_request, x_handle_selection_request)
2809 (x_get_window_property, receive_incremental_selection)
2810 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2811 (lisp_data_to_selection_data, clean_local_selection_data):
2812 Use ptrdiff_t, not int, to record length of selection.
2813 (x_reply_selection_request, x_get_window_property)
2814 (receive_incremental_selection, x_property_data_to_lisp):
2815 Redo calculations to avoid overflow.
2816 (x_reply_selection_request): When sending hint, ceiling it at
2817 X_LONG_MAX rather than relying on wraparound overflow to send
2819 (x_get_window_property, receive_incremental_selection)
2820 (lisp_data_to_selection_data, x_property_data_to_lisp):
2821 Check for size-calculation overflow.
2822 (x_get_window_property, receive_incremental_selection)
2823 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2824 Don't store size until memory allocation succeeds.
2825 (x_get_window_property): Plug memory leak on memory exhaustion.
2826 Don't double-block input; malloc is safe here. Don't assume 2**34
2827 - 4 fits in unsigned long. Add an xassert to check
2828 XGetWindowProperty overflow. Be more careful about overflow
2829 calculations, and distinguish size from memory overflow better.
2830 (receive_incremental_selection): When tracing, don't assume
2831 unsigned int is less than INT_MAX.
2832 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2833 harmful) conversions of unsigned short to int.
2834 (lisp_data_to_selection_data): Don't assume that integers
2835 in the range -65535 through -1 fit in an X unsigned short.
2836 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2837 result parameters unless successful. Rely on cons_to_unsigned
2838 to report problems with elements; the old code wasn't right anyway.
2839 (x_check_property_data): Check for int overflow; we cannot use
2840 a wider type due to X limits.
2841 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2843 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2845 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2846 (x_term_init): Check for size calculation overflow.
2847 (x_color_cells): Don't store size until memory allocation succeeds.
2848 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2849 Don't assume alloca size is less than MAX_ALLOCA.
2850 (x_term_init): Don't assume length fits in int (sprintf is limited
2853 Use ptrdiff_t for composition IDs.
2854 * character.c (lisp_string_width):
2855 * composite.c (composition_table_size, n_compositions)
2856 (get_composition_id, composition_gstring_from_id):
2857 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2858 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2859 * window.c (Frecenter):
2860 Use ptrdiff_t, not int, for composition IDs.
2861 * composite.c (get_composition_id): Check for integer overflow.
2862 * composite.h: Adjust prototypes to match the above changes.
2864 Use ptrdiff_t for hash table indexes.
2865 * category.c (hash_get_category_set):
2866 * ccl.c (ccl_driver):
2867 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2868 * coding.c (coding_system_charset_list, detect_coding_system):
2869 * coding.h (struct coding_system.id):
2870 * composite.c (get_composition_id, gstring_lookup_cache):
2871 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2872 * image.c (xpm_get_color_table_h):
2873 * lisp.h (hash_lookup, hash_put):
2874 * minibuf.c (Ftest_completion):
2875 Use ptrdiff_t for hash table indexes, not int (which is too
2876 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2877 32-bit --with-wide-int hosts).
2879 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2880 Add a FIXME comment about memory leaks.
2881 (syms_of_charset): Don't assume xmalloc returns.
2883 Don't assume that stated character widths fit in int.
2884 * character.c (Fchar_width, c_string_width, lisp_string_width):
2885 * character.h (CHAR_WIDTH):
2886 * indent.c (MULTIBYTE_BYTES_WIDTH):
2887 Use sanitize_char_width to avoid undefined and/or bad behavior
2888 with outlandish widths.
2889 * character.h (sanitize_tab_width): Rename from sanitize_width,
2890 now that we have two such functions. All uses changed.
2891 (sanitize_char_width): New inline function.
2893 Don't assume that tab-width fits in int.
2894 * character.h (sanitize_width): New inline function.
2895 (SANE_TAB_WIDTH): New macro.
2896 (ASCII_CHAR_WIDTH): Use it.
2897 * indent.c (sane_tab_width): Remove. All uses replaced by
2898 SANE_TAB_WIDTH (current_buffer).
2899 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2901 * fileio.c: Integer overflow issues with file modes.
2902 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2904 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2905 Remove unreachable code.
2906 (read_hex, load_charset_map_from_file): Check for integer overflow.
2908 * xterm.c: Don't go over XClientMessageEvent limit.
2909 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2910 (x_send_scroll_bar_event): Likewise. Check that the size does not
2911 exceed limits imposed by XClientMessageEvent, as well as the usual
2912 ptrdiff_t and size_t limits.
2914 * keyboard.c: Overflow, signedness and related fixes.
2915 (make_lispy_movement): Use same integer type in forward decl
2916 that is used in the definition.
2917 (read_key_sequence, keyremap_step):
2918 Change bufsize argument back to int, undoing my 2011-03-30 change.
2919 We prefer signed types, and int is wide enough here.
2920 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2921 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2922 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2923 length, not size_t. Use ptrdiff_t for index, not int.
2924 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2925 possibility of integer overflow.
2927 Overflow, signedness and related fixes for images.
2929 * dispextern.h (struct it.stack[0].u.image.image_id)
2930 (struct_it.image_id, struct image.id, struct image_cache.size)
2931 (struct image_cache.used, struct image_cache.ref_count):
2932 * gtkutil.c (update_frame_tool_bar):
2933 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2934 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2935 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2936 * nsmenu.m (update_frame_tool_bar):
2937 * xdisp.c (calc_pixel_width_or_height):
2938 * xfns.c (image_cache_refcount):
2939 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2940 on typical 64-bit hosts.
2942 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2943 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2944 Omit unnecessary casts to int.
2945 (parse_image_spec): Check that integers fall into 'int' range
2946 when the callers expect that.
2947 (image_ascent): Redo ascent calculation to avoid int overflow.
2948 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2949 (lookup_image): Remove unnecessary tests.
2950 (xbm_image_p): Locals are now of int, not EMACS_INT,
2951 since parse_image_check makes sure they fit into int.
2952 (png_load, gif_load, svg_load_image):
2953 Prefer int to unsigned where either will do.
2954 (tiff_handler): New function, combining the cores of the
2955 old tiff_error_handler and tiff_warning_handler.
2956 This function is rewritten to use vsnprintf and thereby avoid
2957 stack buffer overflows. It uses only the features of vsnprintf
2958 that are common to both POSIX and native Microsoft.
2959 (tiff_error_handler, tiff_warning_handler): Use it.
2960 (tiff_load, gif_load, imagemagick_load_image):
2961 Don't assume :index value fits in 'int'.
2962 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2963 (imagemagick_load_image): Check that crop parameters fit into
2964 the integer types that MagickCropImage accepts. Don't assume
2965 Vimagemagick_render_type has a nonnegative value. Don't assume
2966 size_t fits in 'long'.
2967 (gs_load): Use printmax_t to print the widest integers possible.
2968 Check for integer overflow when computing image height and width.
2970 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2972 * xdisp.c (redisplay_window): Don't force window start if point
2973 will be invisible in the resulting window. (Bug#9324)
2975 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2977 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2978 the display spec is of the form `(space ...)'.
2979 (handle_display_spec): Return the value returned by
2980 handle_single_display_spec, not just 1 or zero.
2981 (handle_single_display_spec): If the display spec is of the form
2982 `(space ...)', and specifies display in the text area, return 2
2984 (try_cursor_movement): Check for the need to scroll more
2985 accurately, and prefer exact match for point under bidi.
2986 Don't advance `row' beyond the last row of the window.
2988 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2989 into disp_prop; all users changed.
2991 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2992 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2993 for the text covered by the display property.
2995 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2997 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2998 Change return value to nil.
2999 (Frecord_buffer): Delete unused function.
3001 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3003 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3004 buffers, return left-to-right.
3005 (set_cursor_from_row): Consider candidate row a win if its glyph
3006 represents a newline and point is on that newline. Fixes cursor
3007 positioning on the newline at EOL of R2L text within L2R
3008 paragraph, and vice versa.
3009 (try_cursor_movement): Check continued rows, in addition to
3010 continuation rows. Fixes unwarranted scroll when point enters a
3011 continued line of R2L text within an L2R paragraph, or vice versa.
3012 (cursor_row_p): Consider the case of point being equal to
3013 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3014 from the end of a short line to the beginning of a continued line
3015 of R2L text within L2R paragraph.
3016 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3017 composed characters.
3019 * bidi.c (bidi_check_type): Use xassert.
3020 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3023 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3025 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3028 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3030 * nsfont.m (ns_otf_to_script): Fix typo.
3032 2011-08-22 Kenichi Handa <handa@m17n.org>
3034 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3035 extra slot even if the purpose is char-code-property-table.
3037 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3039 * xdisp.c (redisplay_window): When computing centering_position,
3040 account for the height of the header line. (Bug#8874)
3042 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3043 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3044 candidate is selected by the mouse, and that candidate has a
3045 composed character under the mouse.
3047 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3048 coordinates reported by pos-visible-in-window-p for a composed
3049 character in column zero.
3051 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3053 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3055 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3057 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3058 consider it a hit if to_charpos is anywhere in the range of the
3059 composed buffer positions.
3061 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3063 * image.c (gif_load): Don't assume that each subimage has the same
3064 dimensions as the base image. Handle disposal method that is
3065 "undefined" by the gif spec (Bug#9335).
3067 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3069 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3070 (Fcondition_case): Document `debug' symbol in error handler.
3072 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3074 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3075 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3076 from an Org mode buffer to a Speedbar frame.
3078 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3079 a composition, take its buffer position from IT->cmp_it.charpos.
3080 Fixes cursor positioning at the beginning of a line that begins
3081 with a composed character.
3083 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3085 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3086 character bidirectional type, use STRONG_L instead. Fixes crashes
3087 in a buffer produced by `describe-categories'.
3089 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3090 members before the level stack, so they would be saved and
3091 restored when copying iterator state. Fixes incorrect reordering
3092 around TABs covered by display properties.
3094 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3096 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3098 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3100 * eval.c (internal_condition_case, internal_condition_case_1)
3101 (internal_condition_case_2, internal_condition_case_n):
3102 Remove unnecessary aborts (Bug#9081).
3104 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3106 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3107 has no `load' handler, try opening the file locally. (Bug#9311)
3109 2011-08-16 Ken Brown <kbrown@cornell.edu>
3111 * gmalloc.c: Expand comment.
3113 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3115 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3116 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3118 2011-08-16 Ken Brown <kbrown@cornell.edu>
3120 Fix memory allocation problems in Cygwin build (Bug#9273).
3122 * unexcw.c ( __malloc_initialized): Declare external variable.
3123 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3125 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3127 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3129 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3131 [CYGWIN] (special_realloc): New function.
3132 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3133 requests to realloc storage in the static heap.
3135 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3137 * bidi.c (bidi_initialize): Remove unused local.
3139 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3142 * biditype.h: Remove file.
3143 * makefile.w32-in ($(BLD)/bidi.$(O)):
3144 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3146 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3148 * chartab.c: Improve commentary for the uniprop_table API.
3150 * bidi.c (bidi_paragraph_init): Support zero value of
3151 bidi_ignore_explicit_marks_for_paragraph_level.
3152 (bidi_initialize): Use uniprop_table instead of including
3153 biditype.h and bidimirror.h.
3155 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3156 coordinates of the iterator when restoring from ppos_it.
3159 2011-08-14 Kenichi Handa <handa@m17n.org>
3161 * process.c (create_process): Call setup_process_coding_systems
3162 after the pid of the process is set to -1 (Bug#8162).
3164 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3166 * xdisp.c (move_it_in_display_line_to): Don't invoke
3167 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3168 ppos_it. Fixes vertical cursor motion when line beginning is
3169 covered by an image. (Bug#9296)
3171 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3173 * nsterm.h (ns_run_ascript): Declare.
3174 (NSAPP_DATA2_RUNASSCRIPT): Define.
3176 * nsfns.m (as_script, as_result, as_status): New static variables.
3177 (ns_run_ascript): New function.
3178 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3179 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3180 the event loop. Get status from as_status (Bug#7276).
3182 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3183 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3184 the event loop (Bug#7276).
3186 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3188 * gnutls.c (QCgnutls_bootprop_priority)
3189 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3190 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3191 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3192 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3193 (QCgnutls_bootprop_verify_hostname_error)
3194 (QCgnutls_bootprop_callbacks_verify): Rename from
3195 Qgnutls_bootprop_..., all uses changed.
3197 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3200 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3202 * xfaces.c (Qframe_set_background_mode): Now static.
3203 * dispextern.h (Qframe_set_background_mode): Remove decl.
3205 * process.c (Fnetwork_interface_info): Declare local only if needed.
3207 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3209 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3210 (Fnetwork_interface_list): Allocate in increments of bytes instead
3211 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3212 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3214 (struct ifflag_def): notrailers is smart on OSX.
3215 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3216 Get hardware address with getifaddrs if available.
3218 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3220 * xdisp.c (iterate_out_of_display_property): xassert that
3221 IT->position is set to within IT->object's boundaries. Break from
3222 the loop as soon as EOB is reached; avoids infloops in redisplay
3223 when IT->position is set up wrongly due to some bug.
3224 Set IT->current to match the bidi iterator unconditionally.
3225 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3226 entry. Force push_it to save on the stack the current
3227 buffer/string position, to be restored by pop_it. Fix flags in
3228 the iterator structure wrt the object coming from a display
3229 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3230 properties. (Bug#9284)
3232 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3234 * fontset.c (fontset_get_font_group): Add proper type checks.
3237 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3239 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3240 and LC_VERSION_MIN_MACOSX.
3241 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3242 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3244 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3246 * xdisp.c (forward_to_next_line_start): Allow to use the
3247 no-display-properties-and-no-overlays under bidi display.
3248 Set disp_pos in the bidi iterator to avoid searches for display
3249 properties and overlays.
3251 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3253 * editfns.c (Fset_time_zone_rule): Document relationship with the
3256 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3257 the font entity extracted from the cache (Bug#8109).
3259 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3261 * composite.c (autocmp_chars): Don't reset point. That is done by
3262 restore_point_unwind (Bug#5984).
3264 2011-08-07 Juri Linkov <juri@jurta.org>
3266 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3267 to show the arg `TIME' instead of `TIMEVAL'.
3269 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3271 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3272 display property strides EOL and includes a newline, as in
3273 longlines-mode. (Bug#9254)
3274 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3275 word-wrap under bidirectional display. (Bug#9224)
3277 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3278 is non-zero, even if the data buffer is NULL. Fixes a crash in
3279 vertical-motion with longlines-mode. (Bug#9254)
3281 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3283 * bidi.c <bidi_cache_total_alloc>: Now static.
3284 (bidi_initialize): Initialize bidi_cache_total_alloc.
3286 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3289 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3290 amount allocated this far in `bidi_cache_total_alloc'.
3291 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3292 non-zero, only free the data buffer without restoring the cache
3293 contents. All callers changed.
3295 * dispextern.h (bidi_unshelve_cache): Update prototype.
3297 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3298 (move_it_in_display_line, move_it_to)
3299 (move_it_vertically_backward, move_it_by_lines): Replace the call
3300 to xfree to an equivalent call to bidi_unshelve_cache.
3301 (move_it_in_display_line_to): Fix logic of returning
3302 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3304 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3306 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3307 came from a string character with a `cursor' property. (Bug#9229)
3309 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3311 * Makefile.in (LIB_PTHREAD): New variable.
3312 (LIBES): Add LIB_PTHREAD (Bug#9216).
3314 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3315 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3317 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3319 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3321 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3323 * xterm.c (x_find_topmost_parent): New function.
3324 (x_set_frame_alpha): Find topmost parent window with
3325 x_find_topmost_parent and set the property there also (bug#9181).
3326 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3328 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3330 * callproc.c (Fcall_process): Avoid vfork clobbering
3331 the local vars buffer, coding_systems, current_dir.
3333 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3335 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3337 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3339 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3340 so that it is not optimized away.
3342 * xdisp.c (compute_display_string_pos): Remove unused local.
3344 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3346 Fix slow cursor motion and scrolling in large buffers with
3347 selective display, like Org Mode buffers. (Bug#9218)
3349 * dispextern.h (struct bidi_it): New member disp_prop_p.
3351 * xdisp.c: Remove one-slot cache of display string positions.
3352 (compute_display_string_pos): Accept an additional argument
3353 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3354 for a display string or property. If found, set DISP_PROP_P
3357 * bidi.c (bidi_fetch_char): Accept an additional argument
3358 DISP_PROP_P, and pass it to compute_display_string_pos.
3359 Only handle text covered by a display string if DISP_PROP_P is returned
3360 non-zero. All callers of bidi_fetch_char changed.
3362 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3364 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3366 2010-12-03 Don March <don@ohspite.net>
3368 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3369 last character M-[char] is translated to ESC [char] (bug#7541).
3371 2011-08-02 Kenichi Handa <handa@m17n.org>
3373 * lisp.h (uniprop_table): Extern it.
3375 * chartab.c (uniprop_table): Make it non-static.
3377 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3379 * xdisp.c (forward_to_next_line_start): Accept additional argument
3380 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3382 (reseat_at_next_visible_line_start): Use the bidi iterator state
3383 returned by forward_to_next_line_start to restore the state of
3384 it->bidi_it after backing up to previous newline. (Bug#9212)
3386 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3388 * regex.c (re_comp): Protoize.
3389 (re_exec): Fix return type.
3390 (regexec): Fix type of `ret'. (Bug#9203)
3392 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3394 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3395 This is needed if max-image-size is a floating-point number.
3397 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3399 * print.c (print_object): Print empty symbol as ##.
3401 * lread.c (read1): Read ## as empty symbol.
3403 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3405 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3406 setting frame foreground color (Bug#9175).
3407 (x_set_background_color): Likewise.
3409 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3410 contents (Bug#9176).
3411 (EmacsTooltip -init): Remove bezels and add shadows to
3414 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3415 or scroll bar (Bug#8470).
3417 * nsfont.m (nsfont_open): Remove assignment to voffset and
3418 unnecessary vars hshink, expand, hd, full_height, min_height.
3419 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3421 * nsterm.h (nsfont_info): Remove voffset field.
3423 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3425 Implement strike-through and overline on NextStep (Bug#8863).
3427 * nsfont.m (nsfont_open): Use underline position provided by font,
3428 instead of hard-coded value of 2.
3429 (nsfont_draw): Call ns_draw_text_decoration instead.
3431 * nsterm.h: Add declaration for ns_draw_text_decoration.
3433 * nsterm.m (ns_draw_text_decoration): New function for drawing
3434 underline, overline, and strike-through.
3435 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3436 ns_draw_text_decoration. Change treatment of cursor drawing to
3437 accommodate underlining, etc.
3439 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3441 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3444 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3446 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3447 Without this fix, if a signal arrives just after memory fills up,
3448 'malloc' might be invoked reentrantly.
3450 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3451 In other words, assume that every image size is allowed, on non-X
3452 hosts. This assumption is probably wrong, but it lets Emacs compile.
3454 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3456 * regex.c (re_iswctype): Convert return values to boolean.
3458 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3460 * xdisp.c (compute_display_string_pos): Don't use cached display
3461 string position if the buffer had its restriction changed.
3464 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3466 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3468 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3470 Integer signedness and overflow and related fixes. (Bug#9079)
3472 * bidi.c: Integer size and overflow fixes.
3473 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3474 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3475 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3476 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3477 (bidi_find_other_level_edge):
3478 Use ptrdiff_t instead of EMACS_INT where either will do.
3479 This works better on 32-bit hosts configured --with-wide-int.
3480 (bidi_cache_ensure_space): Check for size-calculation overflow.
3481 Use % rather than repeated addition, for better worst-case speed.
3482 Don't set bidi_cache_size until after xrealloc returns, because it
3484 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3485 (bidi_cache_ensure_space): Also check that the bidi cache size
3486 does not exceed that of the largest Lisp string or buffer. See Eli
3487 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3489 * alloc.c (__malloc_size_t): Remove.
3490 All uses replaced by size_t. See Andreas Schwab's note
3491 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3493 * image.c: Improve checking for integer overflow.
3494 (check_image_size): Assume that f is nonnull, since
3495 it is always nonnull in practice. This is one less thing to
3496 worry about when checking for integer overflow later.
3497 (x_check_image_size): New function, which checks for integer
3498 overflow issues inside X.
3499 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3500 This removes the need for a memory_full check.
3501 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3502 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3503 (xbm_read_bitmap_data): Change locals back to 'int', since
3504 their values must fit in 'int'.
3505 (xpm_load_image, png_load, tiff_load):
3506 Invoke x_create_x_image_and_pixmap earlier,
3507 to avoid much needless work if the image is too large.
3508 (tiff_load): Treat overly large images as if
3509 x_create_x_image_and_pixmap failed, not as malloc failures.
3510 (gs_load): Use x_check_image_size.
3512 * gtkutil.c: Omit integer casts.
3513 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3514 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3516 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3518 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3519 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3520 would wrongly return t on a 64-bit host.
3522 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3523 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3524 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3525 and therefore cause GCC to emit a bogus diagnostic in some cases.
3527 * image.c: Integer signedness and overflow and related fixes.
3528 This is not an exhaustive set of fixes, but it's time to
3529 record what I've got.
3530 (lookup_pixel_color, check_image_size): Remove redundant decls.
3531 (check_image_size): Don't assume that arbitrary EMACS_INT values
3532 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3533 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3534 (tiff_load, imagemagick_load_image):
3535 Check for overflow in size calculations.
3536 (x_create_x_image_and_pixmap): Remove unnecessary test for
3537 xmalloc returning NULL; that can't happen.
3538 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3539 (xpm_color_bucket): Use better integer hashing function.
3540 (xpm_cache_color): Don't possibly over-allocate memory.
3541 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3542 (gif_memory_source):
3543 Use ptrdiff_t, not int or size_t, to record sizes.
3544 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3545 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3546 either works, as we prefer signed integers.
3547 (tiff_read_from_memory, tiff_write_from_memory):
3548 Return tsize_t, not size_t, since that's what the TIFF API wants.
3549 (tiff_read_from_memory): Don't fail simply because the read would
3550 go past EOF; instead, return a short read.
3551 (tiff_load): Omit no-longer-needed casts.
3552 (Fimagemagick_types): Don't assume size fits into 'int'.
3554 Improve hashing quality when configured --with-wide-int.
3555 * fns.c (hash_string): New function, taken from sxhash_string.
3556 Do not discard information about ASCII character case; this
3557 discarding is no longer needed.
3558 (sxhash-string): Use it. Change sig to match it. Caller changed.
3559 * lisp.h: Declare it.
3560 * lread.c (hash_string): Remove, since we now use fns.c's version.
3561 The fns.c version returns a wider integer if --with-wide-int is
3562 specified, so this should help the quality of the hashing a bit.
3564 * emacs.c: Integer overflow minor fix.
3565 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3566 Define only if GNU_LINUX.
3567 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3569 * dispnew.c: Integer signedness and overflow fixes.
3570 Remove unnecessary forward decls, that were a maintenance hassle.
3571 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3573 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3574 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3575 (prepare_desired_row, line_draw_cost):
3576 Use int, not unsigned, where either works.
3577 (save_current_matrix, restore_current_matrix):
3578 Use ptrdiff_t, not size_t, where either works.
3579 (init_display): Check for overflow more accurately, and without
3580 relying on undefined behavior.
3582 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3583 Remove, replacing with the new symbols in lisp.h. All uses changed.
3584 * fileio.c (make_temp_name):
3585 * filelock.c (lock_file_1, lock_file):
3586 * xdisp.c (message_dolog):
3587 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3588 Use pMd etc. instead.
3589 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3590 replacing the pWIDE etc. symbols removed from editfns.c.
3592 * keyboard.h (num_input_events): Now uintmax_t.
3593 This is (very slightly) less likely to mess up due to wraparound.
3596 * buffer.c: Integer signedness fixes.
3597 (alloc_buffer_text, enlarge_buffer_text):
3598 Use ptrdiff_t rather than size_t when either will do, as we prefer
3601 * alloc.c: Integer signedness and overflow fixes.
3602 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3603 (__malloc_size_t): Default to size_t, not to int.
3604 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3605 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3606 Prefer ptrdiff_t to size_t when either would do, as we prefer
3608 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3609 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3610 Now const. Initialize with values that are in range even if char
3612 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3613 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3614 These functions do the right thing with sizes > 2**32.
3615 (check_depth): Now ptrdiff_t, not int.
3616 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3617 Adjust to new way of storing sizes. Check for size overflow bugs
3619 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3620 slightly wrong anyway, as it missed one instance of
3621 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3622 (refill_memory_reserve): Omit needless cast to size_t.
3623 (mark_object_loop_halt): Mark as externally visible.
3625 * xselect.c: Integer signedness and overflow fixes.
3626 (Fx_register_dnd_atom, x_handle_dnd_message):
3627 Use ptrdiff_t, not size_t, since we prefer signed.
3628 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3629 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3630 x_dnd_atoms_size and x_dnd_atoms_length.
3632 * doprnt.c: Prefer signed to unsigned when either works.
3634 * doprnt.c (doprnt):
3636 * xdisp.c (vmessage):
3637 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3638 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3639 prefer signed arithmetic to avoid comparison confusion.
3640 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3641 but is a bit tricky.
3643 Assume freestanding C89 headers, string.h, stdlib.h.
3644 * data.c, doprnt.c, floatfns.c, print.c:
3645 Include float.h unconditionally.
3646 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3647 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3648 * regex.c: Likewise for stddef.h, string.h.
3649 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3650 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3651 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3652 (STDC_HEADERS): Remove obsolete defines.
3653 * sysdep.c: Include limits.h unconditionally.
3655 Assume support for memcmp, memcpy, memmove, memset.
3656 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3657 * regex.c (memcmp, memcpy):
3658 Remove; we assume C89 now.
3660 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3661 (__malloc_safe_bcopy): Remove; no longer needed.
3663 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3664 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3665 well either way, and we prefer signed to unsigned.
3667 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3669 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3670 closes the connection while we're reading (bug#9182).
3672 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3674 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3675 are specified (Bug#9168).
3677 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3679 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3680 Found by GCC static checking and --with-wide-int on a 32-bit host.
3682 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3684 * xdisp.c (compute_display_string_pos): Fix logic of caching
3685 previous display string position. Initialize cached_prev_pos to
3686 -1. Fixes slow-down at the beginning of a buffer.
3688 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3690 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3691 for attrs[LFACE_FONTSET_INDEX].
3693 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3695 * xml.c (parse_region): Remove unused local
3696 that was recently introduced.
3698 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3700 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3701 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3703 * xdisp.c (move_it_in_display_line_to): Record the best matching
3704 position for TO_CHARPOS while scanning the line, and restore it on
3705 exit if none of the characters scanned was an exact match.
3706 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3707 when exact match is impossible due to invisible text, and the
3708 lines are truncated.
3710 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3712 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3715 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3717 Fix a significant slow-down of cursor motion with C-n, C-p,
3718 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3719 auto-repeat under bidi redisplay in fontified buffers.
3720 * xdisp.c (compute_stop_pos_backwards): New function.
3721 (next_element_from_buffer): Call compute_stop_pos_backwards to
3722 find a suitable prev_stop when we find ourselves before
3724 (reseat): Don't look for prev_stop, as that could mean a very long
3726 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3727 <cached_disp_overlay_modiff>: Cache for last found display string
3729 (compute_display_string_pos): Return the cached position if asked
3730 about the same buffer in the same area of character positions, and
3731 the buffer wasn't changed since the time the display string
3732 position was cached.
3734 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3736 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3737 is an integer, which is important for empty lines. (Bug#9149)
3739 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3741 * frame.c (Fmodify_frame_parameters): In tty case, update the
3742 default face if necessary (Bug#4238).
3744 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3746 * editfns.c (Fstring_to_char): No need to explain what a character
3747 is in the docstring (Bug#6576).
3749 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3751 * xml.c (parse_region): Make sure we always return a tree.
3753 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3755 * xml.c (parse_region): If a document contains only comments,
3758 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3760 * xml.c (make_dom): Return comments, too.
3762 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3765 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3766 and the surrounding thread.
3767 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3768 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3769 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3771 * s/openbsd.h (BROKEN_SIGIO): Define.
3772 * unexelf.c (unexec) [__OpenBSD__]:
3773 Don't update the .mdebug section of the Alpha COFF symbol table.
3775 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3777 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3780 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3782 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3783 This fixes some race conditions on the permissions of any newly
3786 * alloc.c (valid_pointer_p): Use pipe, not open.
3787 This fixes some permissions issues when debugging.
3789 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3790 If fchown fails to set both uid and gid, try to set just gid,
3791 as that is sometimes allowed. Adjust the file's mode to eliminate
3792 setuid or setgid bits that are inappropriate if fchown fails.
3794 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3796 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3797 to compare Lisp_Objects.
3798 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3799 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3800 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3802 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3804 * lread.c (read_integer): Unread even EOF character.
3805 (read1): Likewise. Properly record start position of symbol.
3807 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3808 symbol character follows.
3810 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3812 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3813 This works around a problem with the previous change to Fcopy_file.
3814 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3815 and without this change, GCC might complain about discarding
3816 fchown's return value.
3818 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3820 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3822 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3824 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3826 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3828 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3829 it's used from the C level.
3831 * process.c: Use the same condition for POLL_FOR_INPUT in both
3832 keyboard.c and process.c (bug#1858).
3834 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3836 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3837 (Fgnutls_boot): Use it.
3839 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3841 * doc.c (Fsubstitute_command_keys): Revert last change.
3843 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3845 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3846 quotes the next character, and doesn't affect other longer
3847 sequences (bug#8935).
3849 * lread.c (syms_of_lread): Clarify that is isn't only
3850 `eval-buffer' and `eval-defun' that's affected by
3851 `lexical-binding' (bug#8460).
3853 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3855 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3856 bidi redisplay when a line includes both an image and is truncated.
3858 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3860 Fix minor problems found by static checking.
3861 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3862 (elsz): Now a signed constant, not a size_t var. We prefer signed
3863 types to unsigned, to avoid integer comparison confusion. Without
3864 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3865 "cannot optimize loop, the loop counter may overflow", a symptom
3867 * indent.c (Fvertical_motion): Mark locals as initialized.
3868 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3870 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3872 * search.c (Fre_search_backward): Mention `case-fold-search' in
3873 all the re_search_* functions (bug#8138).
3875 * keyboard.c (Fopen_dribble_file): Document when the file is
3878 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3880 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3883 Support bidi reordering of display and overlay strings.
3884 * xdisp.c (compute_display_string_pos)
3885 (compute_display_string_end): Accept additional argument STRING.
3886 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3887 (reseat_to_string): Initialize bidi_it->string.s and
3888 bidi_it->string.schars.
3889 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3890 NULL (avoids a crash in bidi_paragraph_init).
3891 Initialize itb.string.lstring.
3892 (init_iterator): Call bidi_init_it only of a valid
3893 buffer position was specified. Initialize paragraph_embedding to
3895 (reseat_to_string): Initialize the bidi iterator.
3896 (display_string): If we need to ignore text properties of
3897 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3898 original value of -1 will not work with bidi.)
3899 (compute_display_string_pos): First arg is now struct
3900 `text_pos *'; all callers changed. Support display properties on
3902 (compute_display_string_end): Support display properties on Lisp
3904 (init_iterator, reseat_1, reseat_to_string): Initialize the
3905 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3906 when iterating on a string not from display properties).
3907 (compute_display_string_pos, compute_display_string_end):
3908 Fix calculation of the object to scan. Fixes an error when using
3910 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3911 base_level_stop; instead, set base_level_stop to BEGV.
3912 Fixes crashes in vertical-motion.
3913 (next_element_from_buffer): Improve commentary for when
3914 the iterator is before prev_stop.
3915 (init_iterator): Initialize bidi_p from the default value of
3916 bidi-display-reordering, not from buffer-local value. Use the
3917 buffer-local value only if initializing for buffer iteration.
3918 (handle_invisible_prop): Support invisible properties on strings
3919 that are being bidi-reordered.
3920 (set_iterator_to_next): Support bidi reordering of C strings and
3922 (next_element_from_string): Support bidi reordering of Lisp
3924 (handle_stop_backwards): Support Lisp strings as well.
3925 (display_string): Support display of R2L glyph rows.
3926 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3927 (init_iterator): Don't initialize it->bidi_p for strings
3929 (reseat_to_string): Initialize it->bidi_p for strings here.
3930 (next_element_from_string, next_element_from_c_string)
3931 (next_element_from_buffer): Add xassert's for correspondence
3932 between IT's object being iterated and it->bidi_it.string
3934 (face_before_or_after_it_pos): Support bidi iteration.
3935 (next_element_from_c_string): Handle the case of the first string
3936 character that is not the first one in the visual order.
3937 (get_visually_first_element): New function, refactored from common
3938 parts of next_element_from_buffer, next_element_from_string, and
3939 next_element_from_c_string.
3940 (tool_bar_lines_needed, redisplay_tool_bar)
3941 (display_menu_bar): Force left-to-right direction. Add a FIXME
3942 comment for making that be controlled by a user option.
3943 (push_it, pop_it): Save and restore the state of the
3944 bidi iterator. Save and restore the bidi_p flag.
3945 (pop_it): Iterate out of display property for string iteration as
3947 (iterate_out_of_display_property): Support iteration over strings.
3948 (handle_single_display_spec): Set up it->bidi_it for iteration
3949 over a display string, and call bidi_init_it.
3950 (handle_single_display_spec, next_overlay_string)
3951 (get_overlay_strings_1, push_display_prop): Set up the bidi
3952 iterator for displaying display or overlay strings.
3953 (forward_to_next_line_start): Don't use the shortcut if
3955 (back_to_previous_visible_line_start): If handle_display_prop
3956 pushed the iterator stack, restore the internal state of the bidi
3957 iterator by calling bidi_pop_it same number of times.
3958 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3959 and we are bidi-iterating, don't decrement the iterator position;
3960 instead, set the first_elt flag in the bidi iterator, to produce
3962 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3963 (push_display_prop): xassert that we are iterating a buffer.
3964 (push_it, pop_it): Save and restore paragraph_embedding member.
3965 (handle_single_display_spec, next_overlay_string)
3966 (get_overlay_strings_1, reseat_1, reseat_to_string)
3967 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3968 correctly. Don't assume unibyte strings are not bidi-reordered.
3969 (compute_display_string_pos)
3970 (compute_display_string_end): Fix handling the case of C string.
3971 (push_it, pop_it): Save and restore from_disp_prop_p.
3972 (handle_single_display_spec, push_display_prop): Set the
3973 from_disp_prop_p flag.
3974 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3975 (pop_it): Call iterate_out_of_display_property only if we are
3976 popping after iteration over a string that came from a display
3977 property. Fix a typo in popping stretch info. Add an assertion
3978 for verifying that the iterator position is in sync with the bidi
3980 (handle_single_display_spec, get_overlay_strings_1)
3981 (push_display_prop): Fix initialization of paragraph direction for
3982 string when that of the parent object is not yet determined.
3983 (reseat_1): Call bidi_init_it to resync the bidi
3984 iterator with IT's position. (Bug#7616)
3985 (find_row_edges): If ROW->start.pos gives position
3986 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3987 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3988 Reset the from_disp_prop_p flag.
3989 (SAVE_IT, RESTORE_IT): New macros.
3990 (pos_visible_p, face_before_or_after_it_pos)
3991 (back_to_previous_visible_line_start)
3992 (move_it_in_display_line_to, move_it_in_display_line)
3993 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3994 (try_scrolling, redisplay_window, display_line): Use them when
3995 saving a temporary copy of the iterator and restoring it back.
3996 (back_to_previous_visible_line_start, reseat_1)
3997 (init_iterator): Empty the bidi cache "stack".
3998 (move_it_in_display_line_to): If iterator ended up at
3999 EOL, but we never saw any buffer positions smaller than
4000 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4001 motion in bidi-reordered lines.
4002 (move_it_in_display_line_to): Record prev_method and prev_pos
4003 immediately before the call to set_iterator_to_next. Fixes cursor
4004 motion in bidi-reordered lines with stretch glyphs and strings
4005 displayed in margins. (Bug#8133) (Bug#8867)
4006 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4008 (pos_visible_p): Support positions in bidi-reordered lines.
4009 Save and restore bidi cache.
4011 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4012 (bidi_paragraph_info): Delete unused struct.
4013 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4014 (bidi_cache_start): New variable.
4015 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4017 (bidi_cache_fetch_state, bidi_cache_search)
4018 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4019 (bidi_cache_find, bidi_peek_at_next_level)
4020 (bidi_level_of_next_char, bidi_find_other_level_edge)
4021 (bidi_move_to_visually_next): Compare cache index with
4022 bidi_cache_start rather than with zero.
4023 (bidi_fetch_char): Accept new argument STRING; all callers
4024 changed. Support iteration over a string. Support strings with
4025 display properties. Support unibyte strings. Fix the type of
4026 `len' according to what STRING_CHAR_AND_LENGTH expects.
4027 (bidi_paragraph_init, bidi_resolve_explicit_1)
4028 (bidi_resolve_explicit, bidi_resolve_weak)
4029 (bidi_level_of_next_char, bidi_move_to_visually_next):
4030 Support iteration over a string.
4031 (bidi_set_sor_type, bidi_resolve_explicit_1)
4032 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4033 can now be zero (for strings); special values 0 and -1 were
4034 changed to -1 and -2, respectively.
4035 (bidi_char_at_pos): New function.
4036 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4037 Call it instead of FETCH_MULTIBYTE_CHAR.
4038 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4039 initialized to valid values.
4040 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4042 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4043 the test for valid cached positions. Fix the logic for looking up
4044 the sentinel state in the cache. GCPRO the Lisp string we are
4046 (bidi_push_it, bidi_pop_it): New functions.
4047 (bidi_initialize): Initialize the bidi cache start stack pointer.
4048 (bidi_cache_ensure_space): New function, refactored from part of
4049 bidi_cache_iterator_state. Don't assume the required size is just
4050 one BIDI_CACHE_CHUNK away.
4051 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4052 (bidi_count_bytes, bidi_char_at_pos): New functions.
4053 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4054 always valid if bidi_cache_idx is valid.
4055 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4056 is valid if it's going to be used.
4057 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4058 (bidi_cache_fetch_state, bidi_cache_search)
4059 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4060 (bidi_cache_iterator_state, bidi_cache_find)
4061 (bidi_find_other_level_edge, bidi_cache_start_stack):
4062 All variables related to cache indices are now EMACS_INT.
4064 * dispextern.h (struct bidi_string_data): New structure.
4065 (struct bidi_it): New member `string'. Make flag members be 1-bit
4066 fields, and put them last in the struct.
4067 (compute_display_string_pos, compute_display_string_end):
4069 (bidi_push_it, bidi_pop_it): Add prototypes.
4070 (struct iterator_stack_entry): New members bidi_p,
4071 paragraph_embedding, and from_disp_prop_p.
4072 (struct it): Member bidi_p is now a bit field 1 bit wide.
4073 (bidi_shelve_cache, bidi_unshelve_cache):
4076 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4077 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4078 and vector-like objects.
4080 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4081 cache around display iteration.
4083 * window.c (Fwindow_end, window_scroll_pixel_based)
4084 (displayed_window_lines, Frecenter): Save and restore the bidi
4085 cache around display iteration.
4087 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4089 * editfns.c (Fdelete_region): Clarify the use of the named
4090 parameters (bug#6788).
4092 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4094 * indent.c (Fvertical_motion): Set and restore w->pointm when
4095 saving and restoring the window's buffer (Bug#9006).
4097 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4099 * editfns.c (Fstring_to_char): Clarify just what is returned
4100 (bug#6576). Text by Eli Zaretskii.
4102 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4104 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4106 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4108 * buffer.c (mmap_find): Fix a typo.
4110 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4112 Fix execution of x selection hooks.
4113 * xselect.c (Qx_lost_selection_functions)
4114 (Qx_sent_selection_functions): New vars.
4115 (syms_of_xselect): DEFSYM them.
4116 (x_handle_selection_request): Pass Qx_sent_selection_functions
4117 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4118 (x_handle_selection_clear,x_clear_frame_selections):
4119 Pass Qx_lost_selection_functions rather than
4120 Vx_lost_selection_functions to Frun_hook_with_args.
4122 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4124 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4125 The old code sometimes used this field without initializing it.
4127 * alloc.c (gc_sweep): Don't read past end of array.
4128 In theory, the old code could also have corrupted Emacs internals,
4129 though it'd be very unlikely.
4131 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4133 * character.c (Fcharacterp): Don't advertise optional ignored
4134 argument. (Bug#4026)
4136 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4138 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4141 * window.c (Fset_window_start): Doc fix (bug#4199).
4142 (Fset_window_hscroll): Ditto.
4144 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4146 Fix minor new problems caught by GCC 4.6.1.
4147 * term.c (init_tty): Remove unused local.
4148 * xsettings.c (store_monospaced_changed): Define this function only
4149 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4152 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4154 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4156 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4158 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4159 are the mini-buffer and the echo area (bug#3320).
4161 * term.c (init_tty): Remove support for supdup, c10 and perq
4162 terminals, which are no longer supported (bug#1482).
4164 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4166 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4168 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4170 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4171 for non-popups (Bug#3642).
4173 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4175 * alloc.c (reset_malloc_hooks): Protoize.
4176 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4177 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4178 * cm.c (losecursor): Likewise.
4179 * data.c (fmod): Likewise.
4180 * dispnew.c (swap_glyphs_in_rows): Likewise.
4181 * emacs.c (memory_warning_signal): Likewise.
4182 * floatfns.c (float_error): Likewise.
4183 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4184 (otf_open, font_otf_capability, generate_otf_features)
4185 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4187 * image.c (pbm_read_file): Likewise.
4188 * indent.c (string_display_width): Likewise.
4189 * intervals.c (check_for_interval, search_for_interval)
4190 (inc_interval_count, count_intervals, root_interval)
4191 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4192 * lread.c (defalias): Likewise.
4193 * ralloc.c (r_alloc_check): Likewise.
4194 * regex.c (set_image_of_range_1, set_image_of_range)
4195 (regex_grow_registers): Likewise.
4196 * sysdep.c (strerror): Likewise.
4197 * termcap.c (valid_filename_p, tprint, main): Likewise.
4198 * tparam.c (main): Likewise.
4199 * unexhp9k800.c (run_time_remap, save_data_space)
4200 (update_file_ptrs, read_header, write_header, calculate_checksum)
4201 (copy_file, copy_rest, display_header): Likewise.
4202 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4204 * xdisp.c (check_it): Likewise.
4205 * xfaces.c (register_color, unregister_color, unregister_colors):
4207 * xfns.c (print_fontset_result): Likewise.
4208 * xrdb.c (member, fatal, main): Likewise.
4210 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4212 Fix minor problems found by static checking (Bug#9031).
4213 * chartab.c (char_table_set_range, map_sub_char_table):
4214 Remove unused locals.
4215 (uniprop_table): Now static.
4216 * composite.c (_work_char): Remove unused static var.
4218 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4220 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4222 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4224 * gtkutil.c (qttip_cb): Remove code without function.
4226 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4228 * w32.c (pthread_sigmask): New stub.
4230 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4232 Use pthread_sigmask, not sigprocmask (Bug#9010).
4233 sigprocmask is portable only for single-threaded applications, and
4234 Emacs can be multi-threaded when it uses GTK.
4235 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4237 * callproc.c (Fcall_process):
4238 * process.c (create_process):
4239 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4240 Use pthread_sigmask, not sigprocmask.
4242 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4244 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4245 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4248 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4250 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4251 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4252 (xg_hide_tooltip): Fix comment.
4254 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4255 in registerServicesMenuSendTypes.
4256 (validRequestorForSendType): Don't check ns_return_types.
4258 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4261 2011-07-08 Jason Rumney <jasonr@gnu.org>
4263 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4264 SH_SHOW for hidden windows (Bug#5482).
4266 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4267 frame struct members of non-existent frames (Bug#6284).
4269 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4271 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4272 variable firstTime not needed on OSX >= 10.6.
4273 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4274 >= 10.5. Use setKnobProportion, setDoubleValue.
4276 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4277 (MAC_OS_X_VERSION_10_5): Define if not defined.
4278 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4279 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4280 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4282 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4283 cString and lossyCString on OSX >= 10.4
4285 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4286 sizeToFit on OSX >= 10.2.
4288 * nsimage.m (allocInitFromFile): Don't use deprecated method
4289 bestRepresentationForDevice on OSX >= 10.6.
4291 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4294 * emacs.c: Declare unexec_init_emacs_zone.
4296 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4298 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4300 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4301 on svcsMenu (Bug#8842).
4303 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4305 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4307 * nsterm.m (QUTF8_STRING): Declare.
4308 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4309 (validRequestorForSendType): Return type is (id).
4310 Change indexOfObjectIdenticalTo to indexOfObject.
4311 Check if we have local selection before returning self (Bug#8842).
4312 (writeSelectionToPasteboard): Put local selection into paste board
4313 if we have a local selection (Bug#8842).
4314 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4316 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4317 (ns_get_local_selection): Declare.
4319 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4321 * keymap.c (describe_map_tree): Don't insert a double newline at
4322 the end of the buffer (bug#1169) and return whether we inserted
4325 * callint.c (Fcall_interactively): Change "reading args" to
4326 "providing args" to try to clarify what it does (bug#1010).
4328 2011-07-07 Kenichi Handa <handa@m17n.org>
4330 * composite.c (composition_compute_stop_pos): Ignore a static
4331 composition starting before CHARPOS (Bug#8915).
4333 * xdisp.c (handle_composition_prop): Likewise.
4335 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4337 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4340 2011-07-07 Kenichi Handa <handa@m17n.org>
4342 * character.h (unicode_category_t): New enum type.
4344 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4345 (Qchar_code_property_table): New variable.
4346 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4347 (UNIPROP_COMPRESSED_FORM_P): New macros.
4348 (char_table_ascii): Uncompress the compressed values.
4349 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4350 Uncompress the compressed values.
4351 (sub_char_table_ref_and_range): Likewise.
4352 (char_table_ref_and_range): Uncompress the compressed values.
4353 (sub_char_table_set): New arg is_uniprop. Callers changed.
4354 Uncompress the compressed values.
4355 (sub_char_table_set_range): Args changed. Callers changed.
4356 (char_table_set_range): Adjuted for the above change.
4357 (map_sub_char_table): Delete args default_val and parent. Add arg
4358 top. Give decoded values to a Lisp function.
4359 (map_char_table): Adjust for the above change. Give decoded
4360 values to a Lisp function. Gcpro more variables.
4361 (uniprop_table_uncompress)
4362 (uniprop_decode_value_run_length): New functions.
4363 (uniprop_decoder, uniprop_decoder_count): New variables.
4364 (uniprop_get_decoder, uniprop_encode_value_character)
4365 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4367 (uniprop_encoder, uniprop_encoder_count): New variables.
4368 (uniprop_get_encoder, uniprop_table)
4369 (Funicode_property_table_internal, Fget_unicode_property_internal)
4370 (Fput_unicode_property_internal): New functions.
4371 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4372 Sunicode_property_table_internal, Sget_unicode_property_internal,
4373 and Sput_unicode_property_internal. Defvar_lisp
4374 char-code-property-alist.
4376 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4377 Vunicode_category_table.
4379 * font.c (font_range): Adjust for the change of
4380 Vunicode_category_table.
4382 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4384 * m/iris4d.h: Remove file, move contents ...
4385 * s/irix6-5.h: ... here.
4387 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4389 Remove unportable assumption about struct layout (Bug#8884).
4390 * alloc.c (mark_buffer):
4391 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4392 (clone_per_buffer_values): Don't assume that
4393 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4394 This isn't true in general, and it's particularly not true
4395 if Emacs is configured with --with-wide-int.
4396 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4397 New macros, used in the buffer.c change.
4399 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4401 * xsettings.c: Use both GConf and GSettings if both are available.
4402 (store_config_changed_event): Add comment.
4403 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4404 (store_tool_bar_style_changed): New functions.
4405 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4406 (struct xsettings): Move font inside HAVE_XFT.
4407 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4408 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4409 Move inside HAVE_XFT.
4410 (something_changed_gsettingsCB): Rename from something_changedCB.
4411 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4413 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4414 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4415 (something_changed_gconfCB): Rename from something_changedCB.
4416 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4417 (parse_settings): Move check for font inside HAVE_XFT.
4418 (read_settings, apply_xft_settings): Add comment.
4419 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4420 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4421 call store_font_name_changed.
4422 (xft_settings_event): Add comment.
4423 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4424 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4425 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4426 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4427 (xsettings_initialize): Call init_gsettings last.
4428 (xsettings_get_system_font, xsettings_get_system_normal_font):
4431 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4433 Random fixes. E.g., (random) never returned negative values.
4434 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4435 subseconds part to the entropy, as that's a bit more random.
4436 Prefer signed to unsigned, since the signedness doesn't matter and
4437 in general we prefer signed. When given a limit, use a
4438 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4439 latter isn't right if USE_2_TAGS_FOR_INTS.
4440 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4441 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4443 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4445 * textprop.c (text_property_stickiness):
4446 Obey Vtext_property_default_nonsticky.
4447 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4448 * w32fns.c (syms_of_w32fns):
4449 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4451 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4453 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4454 This is more efficient than Ffile_directory_p and avoids a minor race.
4456 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4458 * buffer.c (Foverlay_put): Say what the return value is
4461 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4462 is a directory before asking whether to use the file name
4464 (barf_or_query_if_file_exists): Make the "File is a directory"
4465 error be more correct.
4467 * fns.c (Frequire): Remove the mention of the .gz files, since
4468 that's installation-specific, but keep the mention of
4469 `get-load-suffixes'.
4471 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4473 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4474 Report string overflow if the output is too long.
4476 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4478 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4479 (syms_of_gnutls): Remove duplicate DEFSYM for
4480 Qgnutls_bootprop_verify_hostname_error, an error for
4481 Qgnutls_bootprop_verify_error (which is no longer used).
4483 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4484 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4485 Also (re)move comments that are misplaced or no longer relevant.
4487 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4489 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4491 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4493 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4494 and background color parameters if they have been changed.
4496 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4498 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4500 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4502 * xsettings.c (SYSTEM_FONT): Define only when used.
4503 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4505 * keymap.c (access_keymap_1): Now static.
4507 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4509 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4510 leave any prefix arg for the up event (Bug#1586).
4512 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4514 * lread.c (syms_of_lread): Mention single symbols defined by
4515 `defvar' or `defconst' (bug#7154).
4517 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4518 (Frequire): Mention get-load-suffixes.
4520 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4522 * window.h (window): Remove clone_number slot.
4523 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4525 (make_parent_window, make_window, saved_window)
4526 (Fset_window_configuration, save_window_save): Don't deal with
4528 * buffer.c (Qclone_number): Remove declaration.
4529 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4531 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4533 Add multiple inheritance to keymaps.
4534 * keymap.c (Fmake_composed_keymap): New function.
4535 (Fset_keymap_parent): Simplify.
4536 (fix_submap_inheritance): Remove.
4537 (access_keymap_1): New function extracted from access_keymap to handle
4538 embedded parents and handle lists of maps.
4539 (access_keymap): Use it.
4540 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4541 (Fcopy_keymap): Handle embedded parents.
4542 (Fcommand_remapping, define_as_prefix): Simplify.
4543 (Fkey_binding): Simplify.
4544 (syms_of_keymap): Move minibuffer-local-completion-map,
4545 minibuffer-local-filename-completion-map,
4546 minibuffer-local-must-match-map, and
4547 minibuffer-local-filename-must-match-map to Elisp.
4548 (syms_of_keymap): Defsubr make-composed-keymap.
4549 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4550 (parse_menu_item): Trivial simplification.
4552 2011-07-01 Glenn Morris <rgm@gnu.org>
4554 * Makefile.in (SETTINGS_LIBS): Fix typo.
4556 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4558 * coding.c (Fencode_coding_string): Record the last coding system
4559 used, as the function doc string says (bug#8738).
4561 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4563 * xsettings.c (store_monospaced_changed): Take new font as arg and
4564 check for change against current_mono_font.
4565 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4566 (emacs_settings_constructor, emacs_settings_get_property)
4567 (emacs_settings_set_property, emacs_settings_class_init)
4568 (emacs_settings_init, gsettings_obj): Remove.
4569 (something_changedCB): New function for HAVE_GSETTINGS.
4570 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4571 with value as argument.
4572 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4573 g_settings_new (Bug#8967). Do not create gsettings_obj.
4574 Remove calls to g_settings_bind. Connect something_changedCB to
4577 * xgselect.c: Add defined (HAVE_GSETTINGS).
4578 (xgselect_initialize): Ditto.
4580 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4581 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4584 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4586 * eval.c (struct backtrace): Simplify and port the data structure.
4587 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4588 signed bit field, as this assumption is not portable and it makes
4589 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4590 "char debug_on_exit : 1" as this is not portable either; instead,
4591 use the portable "unsigned int debug_on_exit : 1". Remove unused
4592 member evalargs. Remove obsolete comments about cc bombing out.
4594 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4596 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4597 Let HAVE_GSETTINGS override HAVE_GCONF.
4598 (store_monospaced_changed): New function.
4599 (EMACS_SETTINGS): A new type derived from GObject to handle
4600 GSettings notifications.
4601 (emacs_settings_constructor, emacs_settings_get_property)
4602 (emacs_settings_set_property, emacs_settings_class_init):
4604 (gsettings_client, gsettings_obj): New variables.
4605 (GSETTINGS_SCHEMA): New define.
4606 (something_changedCB): Call store_monospaced_changed.
4607 (init_gsettings): New function.
4608 (xsettings_initialize): Call init_gsettings.
4609 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4612 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4615 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4617 * window.c (resize_root_window, grow_mini_window)
4618 (shrink_mini_window): Rename Qresize_root_window to
4619 Qwindow_resize_root_window and Qresize_root_window_vertically to
4620 Qwindow_resize_root_window_vertically.
4622 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4624 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4626 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4628 * makefile.w32-in: Redesign dependencies so they reflect more
4629 clearly which files are directly included by each source file,
4630 and not through other includes.
4632 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4634 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4635 (sort_overlays, overlay_strings): When an overlay's clone number
4636 matches the window's clone number process the overlay even if
4637 the overlay's window property doesn't match the current window.
4639 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4640 (Fwindow_hchild): Rename to Fwindow_left_child.
4641 (Fwindow_next): Rename to Fwindow_next_sibling.
4642 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4643 (resize_window_check): Rename to window_resize_check.
4644 (resize_window_apply): Rename to window_resize_apply.
4645 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4646 (Fdelete_other_windows_internal, resize_frame_windows)
4647 (Fsplit_window_internal, Fdelete_window_internal)
4648 (grow_mini_window, shrink_mini_window)
4649 (Fresize_mini_window_internal): Fix callers accordingly.
4651 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4653 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4654 (emacs_fixed_set_min_size): Remove.
4655 (emacs_fixed_new): Take frame as argument.
4657 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4658 (_EmacsFixedPrivate): Remove minwidth/height.
4659 Add struct frame *f.
4660 (emacs_fixed_init): Initialize priv->f.
4661 (get_parent_class, emacs_fixed_set_min_size): Remove.
4662 (emacs_fixed_new): Set priv->f to argument.
4663 (emacs_fixed_get_preferred_width)
4664 (emacs_fixed_get_preferred_height): Use min_width/height from
4665 frames size_hint to set minimum and natural (Bug#8919).
4666 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4667 and use min_width/height from frames size_hint to set
4668 min_width/height (Bug#8919).
4670 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4671 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4674 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4676 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4677 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4680 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4682 * process.c (wait_reading_process_output): Bypass select if
4683 waiting for a cell while ignoring keyboard input, and input is
4684 pending. Suggested by Jan Djärv (Bug#8869).
4686 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4688 Use gnulib's dup2 module instead of rolling our own.
4689 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4691 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4693 * dispnew.c (scrolling_window): Before scrolling, turn off a
4694 mouse-highlight in the window being scrolled.
4696 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4698 Move DEFSYM to lisp.h and use everywhere.
4700 * character.h (DEFSYM): Move declaration...
4701 * lisp.h (DEFSYM): ...here.
4707 * w32select.c: Don't include character.h.
4709 * alloc.c (syms_of_alloc):
4710 * buffer.c (syms_of_buffer):
4711 * bytecode.c (syms_of_bytecode):
4712 * callint.c (syms_of_callint):
4713 * casefiddle.c (syms_of_casefiddle):
4714 * casetab.c (init_casetab_once):
4715 * category.c (init_category_once, syms_of_category):
4716 * ccl.c (syms_of_ccl):
4717 * cmds.c (syms_of_cmds):
4718 * composite.c (syms_of_composite):
4719 * dbusbind.c (syms_of_dbusbind):
4720 * dired.c (syms_of_dired):
4721 * dispnew.c (syms_of_display):
4722 * doc.c (syms_of_doc):
4723 * editfns.c (syms_of_editfns):
4724 * emacs.c (syms_of_emacs):
4725 * eval.c (syms_of_eval):
4726 * fileio.c (syms_of_fileio):
4727 * fns.c (syms_of_fns):
4728 * frame.c (syms_of_frame):
4729 * fringe.c (syms_of_fringe):
4730 * insdel.c (syms_of_insdel):
4731 * keymap.c (syms_of_keymap):
4732 * lread.c (init_obarray, syms_of_lread):
4733 * macros.c (syms_of_macros):
4734 * msdos.c (syms_of_msdos):
4735 * print.c (syms_of_print):
4736 * process.c (syms_of_process):
4737 * search.c (syms_of_search):
4738 * sound.c (syms_of_sound):
4739 * syntax.c (init_syntax_once, syms_of_syntax):
4740 * terminal.c (syms_of_terminal):
4741 * textprop.c (syms_of_textprop):
4742 * undo.c (syms_of_undo):
4743 * w32.c (globals_of_w32):
4744 * window.c (syms_of_window):
4745 * xdisp.c (syms_of_xdisp):
4746 * xfaces.c (syms_of_xfaces):
4747 * xfns.c (syms_of_xfns):
4748 * xmenu.c (syms_of_xmenu):
4749 * xsettings.c (syms_of_xsettings):
4750 * xterm.c (syms_of_xterm): Use DEFSYM.
4752 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4754 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4756 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4758 Integer and buffer overflow fixes (Bug#8873).
4760 * print.c (printchar, strout): Check for string overflow.
4761 (PRINTPREPARE, printchar, strout):
4762 Don't set size unless allocation succeeds.
4764 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4765 for sizes. Check for string overflow more accurately.
4766 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4768 * macros.c: Integer and buffer overflow fixes.
4769 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4770 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4771 Use ptrdiff_t, not int, for sizes.
4772 Don't increment bufsize until after realloc succeeds.
4773 Check for size-calculation overflow.
4774 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4776 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4778 * lread.c: Integer overflow fixes.
4779 (read_integer): Radix is now EMACS_INT, not int,
4780 to improve quality of diagnostics for out-of-range radices.
4781 Calculate buffer size correctly for out-of-range radices.
4782 (read1): Check for integer overflow in radices, and in
4783 read-circle numbers.
4784 (read_escape): Avoid int overflow.
4785 (Fload, openp, read_buffer_size, read1)
4786 (substitute_object_recurse, read_vector, read_list, map_obarray):
4787 Use ptrdiff_t, not int, for sizes.
4788 (read1): Use EMACS_INT, not int, for sizes.
4789 Check for size overflow.
4791 * image.c (cache_image): Check for size arithmetic overflow.
4793 * lread.c: Integer overflow issues.
4794 (saved_doc_string_size, saved_doc_string_length)
4795 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4796 Now ptrdiff_t, not int.
4797 (read1): Don't assume doc string length fits in int. Check for
4798 out-of-range doc string lengths.
4799 (read_list): Don't assume file position fits in int.
4800 (read_escape): Check for hex character overflow.
4802 2011-06-22 Leo Liu <sdl.web@gmail.com>
4804 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4805 Move to minibuffer.el.
4807 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4809 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4810 The following patches are for when GLYPH_DEBUG && !XASSERT.
4811 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4812 * dispnew.c (flush_stdout):
4813 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4814 Mark as externally visible.
4815 * dispnew.c (check_window_matrix_pointers): Now static.
4816 * dispnew.c (window_to_frame_vpos):
4817 * xfns.c (unwind_create_frame):
4818 * xterm.c (x_check_font): Remove unused local.
4819 * scroll.c (CHECK_BOUNDS):
4820 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4821 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4822 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4823 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4824 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4826 (debug_method_add): Use va_list and vsprintf rather than relying
4827 on undefined behavior with wrong number of arguments.
4828 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4829 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4830 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4831 since we're not interested in debugging glyphs with old libraries.
4832 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4833 GCC 4.6.0's static checking.
4835 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4837 Integer overflow and signedness fixes (Bug#8873).
4838 A few related buffer overrun fixes, too.
4840 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4842 * dispextern.h (struct face.stipple):
4843 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4844 (x_bitmap_mask, x_allocate_bitmap_record)
4845 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4846 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4847 (x_create_bitmap_from_xpm_data):
4848 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4849 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4851 * xfaces.c (load_pixmap):
4852 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4853 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4854 (.bitmaps_last, struct x_output.icon_bitmap):
4855 Use ptrdiff_t, not int, for bitmap indexes.
4856 (x_allocate_bitmap_record): Check for size overflow.
4857 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4859 Use ptrdiff_t, not int, for overlay counts.
4860 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4861 * editfns.c (overlays_around, get_pos_property):
4862 * textprop.c (get_char_property_and_overlay):
4863 * xdisp.c (next_overlay_change, note_mouse_highlight):
4864 * xfaces.c (face_at_buffer_position):
4865 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4866 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4867 (Fnext_overlay_change, Fprevious_overlay_change)
4868 (mouse_face_overlay_overlaps, Foverlays_in):
4869 Use ptrdiff_t, not int, for sizes.
4870 (overlays_at, overlays_in): Check for size-calculation overflow.
4872 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4874 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4875 (x_session_initialize): Do not assume string length fits in int.
4877 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4878 This is unlikely, but can occur if DPI is outlandish.
4880 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4881 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4883 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4884 * xrdb.c (magic_file_p, search_magic_path):
4885 Omit last arg SUFFIX; it was always 0. All callers changed.
4886 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4888 * xfont.c (xfont_match): Avoid need for strlen.
4890 * xfns.c: Don't assume strlen fits in int.
4891 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4893 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4894 not unsigned long, as we prefer signed integers. All callers changed.
4895 Detect integer overflow in repeat count.
4896 (message_dolog): Don't assume print length fits in 39 bytes.
4897 (display_mode_element): Don't assume strlen fits in int.
4899 * termcap.c: Don't assume sizes fit in int and never overflow.
4900 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4901 (gobble_line): Check for size-calculation overflow.
4903 * minibuf.c (Fread_buffer):
4904 * lread.c (intern, intern_c_string):
4905 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4906 Don't assume string length fits in int.
4908 * keyboard.c (parse_tool_bar_item):
4909 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4911 * font.c: Don't assume string length fits in int.
4912 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4913 Use ptrdiff_t, not int.
4914 (font_intern_prop): Don't assume string length fits in int.
4915 Don't assume integer property fits in fixnum.
4916 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4918 * filelock.c: Fix some buffer overrun and integer overflow issues.
4919 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4920 Reformulate so as not to need the command string.
4921 Invoke gzip -cd rather than gunzip, as it's more portable.
4922 (lock_info_type, lock_file_1, lock_file):
4923 Don't assume pid_t and time_t fit in unsigned long.
4924 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4925 (current_lock_owner): Prefer signed type for sizes.
4926 Use memcpy, not strncpy, where memcpy is what is really wanted.
4927 Don't assume (via atoi) that time_t and pid_t fit in int.
4928 Check for time_t and/or pid_t out of range, e.g., via a network share.
4929 Don't alloca where an auto var works fine.
4931 * fileio.c: Fix some integer overflow issues.
4932 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4933 Don't assume string length fits in int.
4934 (directory_file_name): Don't assume string length fits in long.
4935 (make_temp_name): Don't assume pid fits in int, or that its print
4936 length is less than 20.
4938 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4940 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4942 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4944 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4945 We prefer signed integers, even for size calculations.
4947 * emacs.c: Don't assume string length fits in 'int'.
4948 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4949 (main): Don't invoke strlen when not needed.
4951 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4952 (XD_DEBUG_MESSAGE): Don't waste a byte.
4954 * callproc.c (getenv_internal_1, getenv_internal)
4956 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4958 * lread.c (invalid_syntax): Omit length argument.
4959 All uses changed. This doesn't fix a bug, but it simplifies the
4960 code away from its former Hollerith-constant appearance, and it's
4961 one less 'int' to worry about when looking at integer-overflow issues.
4962 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4964 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4965 This didn't break anything, but it didn't help either.
4966 It's confusing to put a bogus integer in a place where the actual
4967 value does not matter.
4968 (LIST_END_P): Remove unused macro and its bogus comment.
4969 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4971 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4972 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4974 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4975 We prefer signed types, and the value cannot exceed the EMACS_INT
4976 range anyway (because otherwise the length would not be representable).
4977 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4978 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4979 This avoids a GCC warning when WIDE_EMACS_INT.
4981 * indent.c (sane_tab_width): New function.
4982 (current_column, scan_for_column, Findent_to, position_indentation)
4983 (compute_motion): Use it. This is just for clarity.
4984 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4986 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4988 * lisp.h (lint_assume): New macro.
4989 * composite.c (composition_gstring_put_cache):
4990 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4992 * editfns.c, insdel.c:
4993 Omit unnecessary forward decls, to simplify future changes.
4995 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4997 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4999 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5000 Use much-faster test for byte-length change.
5001 Don't assume string byte-length fits in 'int'.
5002 Check that character arg fits in 'int'.
5003 (mapcar1): Declare byte as byte, for clarity.
5005 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5007 * fns.c (concat): Catch string overflow earlier.
5008 Do not rely on integer wraparound.
5010 * dispextern.h (struct it.overlay_strings_charpos)
5011 (struct it.selective): Now EMACS_INT, not int.
5012 * xdisp.c (forward_to_next_line_start)
5013 (back_to_previous_visible_line_start)
5014 (reseat_at_next_visible_line_start, next_element_from_buffer):
5015 Don't arbitrarily truncate the value of 'selective' to int.
5017 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5019 * composite.c: Don't truncate sizes to 'int'.
5020 (composition_gstring_p, composition_reseat_it)
5021 (composition_adjust_point): Use EMACS_INT, not int.
5022 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5023 not EMACS_UINT, for indexes.
5025 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5027 * buffer.c: Include <verify.h>.
5028 (struct sortvec.priority, struct sortstr.priority):
5029 Now EMACS_INT, not int.
5030 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5031 (struct sortstr.size, record_overlay_string)
5032 (struct sortstrlist.size, struct sortlist.used):
5033 Don't truncate size to int.
5034 (record_overlay_string): Check for size-calculation overflow.
5035 (init_buffer_once): Check at compile-time, not run-time.
5037 2011-06-22 Jim Meyering <meyering@redhat.com>
5039 Don't leak an XBM-image-sized buffer
5040 * image.c (xbm_load): Free the image buffer after using it.
5042 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5045 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5046 that Sun C diagnosed.
5047 * fns.c (secure_hash): Fix pointer signedness issue.
5048 * intervals.c (static_offset_intervals): New function.
5049 (offset_intervals): Use it.
5051 2011-06-21 Leo Liu <sdl.web@gmail.com>
5054 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5057 * fns.c (secure_hash): Rename from crypto_hash_function and change
5058 the first arg to accept symbols.
5059 (Fsecure_hash): New primitive.
5060 (syms_of_fns): New symbols.
5062 2011-06-20 Deniz Dogan <deniz@dogan.se>
5064 * process.c (Fset_process_buffer): Clarify return value in
5067 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5069 * dispnew.c (add_window_display_history): Use BVAR.
5071 * xdisp.c (debug_method_add): Use BVAR.
5072 (check_window_end, dump_glyph_matrix, dump_glyph)
5073 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5075 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5078 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5079 check till after the cache is created in init_frame_faces.
5081 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5083 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5085 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5087 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5088 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5089 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5091 Improve buffer-overflow checking (Bug#8873).
5092 * fileio.c (Finsert_file_contents):
5093 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5094 Remove the old (too-loose) buffer overflow checks.
5095 They weren't needed, since make_gap checks for buffer overflow.
5096 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5097 The old code merely checked for Emacs fixnum overflow, and relied
5098 on undefined (wraparound) behavior. The new code avoids undefined
5099 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5101 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5102 Tune. Don't use wider integers than needed. Don't use alloca.
5103 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5105 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5107 * insdel.c, lisp.h (buffer_overflow): New function.
5108 (insert_from_buffer_1, replace_range, replace_range_2):
5109 * insdel.c (make_gap_larger):
5110 * editfns.c (Finsert_char):
5111 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5113 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5115 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5117 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5119 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5120 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5122 * fileio.c: Don't assume EMACS_INT fits in off_t.
5123 (emacs_lseek): New static function.
5124 (Finsert_file_contents, Fwrite_region): Use it.
5125 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5127 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5129 * fns.c: Don't overflow int when computing a list length.
5130 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5131 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5132 truncation on 64-bit hosts. Check for QUIT every
5133 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5134 faster and is responsive enough.
5135 (Flength): Report an error instead of overflowing an integer.
5136 (Fsafe_length): Return a float if the value is not representable
5137 as a fixnum. This shouldn't happen except in contrived situations.
5138 (Fnthcdr, Fsort): Don't assume list length fits in int.
5139 (Fcopy_sequence): Don't assume vector length fits in int.
5141 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5142 (header_size, word_size): New constants.
5143 (allocate_vectorlike): Don't check size overflow here.
5144 (allocate_vector): Check it here instead, since this is the only
5145 caller of allocate_vectorlike that could cause overflow.
5146 Check that the new vector's length is representable as a fixnum.
5148 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5149 The previous code was bogus. For example, next_almost_prime (32)
5150 returned 39, which is undesirable as it is a multiple of 3; and
5151 next_almost_prime (24) returned 25, which is a multiple of 5 so
5152 why was the code bothering to check for multiples of 7?
5154 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5156 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5158 Variadic C functions now count arguments with ptrdiff_t.
5159 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5160 Back then I didn't know that the Emacs coding style prefers signed int.
5161 Also, in the meantime I found a few more instances where arguments
5162 were being counted with int, which may truncate counts on 64-bit
5163 machines, or EMACS_INT, which may be unnecessarily wide.
5164 * lisp.h (struct Lisp_Subr.function.aMANY)
5165 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5166 Arg counts are now ptrdiff_t, not size_t.
5167 All variadic functions and their callers changed accordingly.
5168 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5169 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5170 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5171 * callint.c (Fcall_interactively): Check arg count for overflow,
5172 to avoid potential buffer overrun. Use signed char, not 'int',
5173 for 'varies' array, so that we needn't bother to check its size
5174 calculation for overflow.
5175 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5176 * eval.c (apply_lambda):
5177 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5178 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5179 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5181 * callint.c (Fcall_interactively): Don't use index var as event count.
5183 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5184 * mem-limits.h (SIZE): Remove; no longer used.
5186 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5188 Remove unnecessary casts.
5189 * xterm.c (x_term_init):
5190 * xfns.c (x_set_border_pixel):
5191 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5192 These aren't needed now that we assume ANSI C.
5194 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5195 It's more likely to cause problems (due to unsigned overflow)
5198 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5200 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5202 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5204 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5206 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5208 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5210 GLYPH_CODE_FACE returns EMACS_INT, not int.
5211 * dispextern.h (merge_faces):
5212 * xfaces.c (merge_faces):
5213 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5214 Don't assume EMACS_INT fits in int.
5216 * character.h (CHAR_VALID_P): Remove unused parameter.
5217 * fontset.c, lisp.h, xdisp.c: All uses changed.
5219 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5221 * fns.c (concat): Minor tuning based on overflow analysis.
5222 This doesn't fix any bugs. Use int to hold character, instead
5223 of constantly refetching from Emacs object. Use XFASTINT, not
5224 XINT, for value known to be a character. Don't bother comparing
5225 a single byte to 0400, as it's always less.
5227 * floatfns.c (Fexpt):
5228 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5230 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5233 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5235 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5236 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5237 incorrectly succeed when S was a string, because 4294967386 was
5238 truncated before it was used.
5240 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5241 Otherwise, an out-of-range integer could cause undefined behavior
5244 * composite.c: Use int, not EMACS_INT, for characters.
5245 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5246 EMACS_INT, for values that are known to be in character range.
5247 This doesn't fix any bugs but is the usual style inside Emacs and
5248 may generate better code on 32-bit machines.
5250 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5251 This is for reasons similar to the recent CHAR_STRING fix.
5252 * charset.c (Fencode_char): Check that character arg is actually
5253 a character. Pass an int to ENCODE_CHAR.
5254 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5255 wider than 'int', as a compile-time check to prevent future regressions
5258 * character.c (char_string): Remove unnecessary casts.
5260 Make sure a 64-bit char is never passed to CHAR_STRING.
5261 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5262 by silently ignoring the top 32 bits, allowing some values
5263 that were far too large to be valid characters.
5264 * character.h: Include <verify.h>.
5265 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5266 arguments are no wider than unsigned, as a compile-time check
5267 to prevent future regressions in this area.
5269 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5270 (Fsubst_char_in_region):
5272 * xdisp.c (decode_mode_spec_coding):
5273 Adjust to CHAR_STRING's new requirement.
5274 * editfns.c (Finsert_char, Fsubst_char_in_region):
5275 * fns.c (concat): Check that character args are actually
5276 characters. Without this test, these functions did the wrong
5277 thing with wildly out-of-range values on 64-bit hosts.
5279 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5280 These casts should not be needed on 32-bit hosts, either.
5281 * keyboard.c (read_char):
5282 * lread.c (Fload): Remove casts to unsigned.
5284 * lisp.h (UNSIGNED_CMP): New macro.
5285 This fixes comparison bugs on 64-bit hosts.
5286 (ASCII_CHAR_P): Use it.
5287 * casefiddle.c (casify_object):
5288 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5289 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5290 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5291 * dispextern.h (FACE_FROM_ID):
5292 * keyboard.c (read_char): Use UNSIGNED_CMP.
5294 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5295 not to EMACS_INT, to avoid GCC warning.
5297 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5299 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5300 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5301 isn't needed on 32-bit machines.
5303 * buffer.c (Fgenerate_new_buffer_name):
5304 Use EMACS_INT for count, not int.
5305 (advance_to_char_boundary): Return EMACS_INT, not int.
5307 * data.c (Qcompiled_function): Now static.
5309 * window.c (window_body_lines): Now static.
5311 * image.c (gif_load): Rename local to avoid shadowing.
5313 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5314 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5315 * alloc.c (make_save_value): Integer argument is now of type
5317 (mark_object): Use ptrdiff_t, not int.
5318 * lisp.h (pD): New macro.
5319 * print.c (print_object): Use it.
5321 * alloc.c: Use EMACS_INT, not int, to count objects.
5322 (total_conses, total_markers, total_symbols, total_vector_size)
5323 (total_free_conses, total_free_markers, total_free_symbols)
5324 (total_free_floats, total_floats, total_free_intervals)
5325 (total_intervals, total_strings, total_free_strings):
5326 Now EMACS_INT, not int. All uses changed.
5327 (Fgarbage_collect): Compute overall total using a double, so that
5328 integer overflow is less likely to be a problem. Check for overflow
5329 when converting back to an integer.
5330 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5331 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5332 These were 'int' variables that could overflow on 64-bit hosts;
5333 they were never used, so remove them instead of repairing them.
5334 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5335 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5336 Previously, this ceilinged at INT_MAX, but that doesn't work on
5338 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5340 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5341 (allocate_vectorlike): Check for ptrdiff_t overflow.
5342 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5343 when a (possibly-narrower) signed value would do just as well.
5344 We prefer using signed arithmetic, to avoid comparison confusion.
5346 * alloc.c: Catch some string size overflows that we were missing.
5347 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5348 for convenience in STRING_BYTES_MAX.
5349 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5350 The definition here is exact; the one in lisp.h was approximate.
5351 (allocate_string_data): Check for string overflow. This catches
5352 some instances we weren't catching before. Also, it catches
5353 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5354 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5355 and ptrdiff_t and EMACS_INT are both 64 bits.
5357 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5358 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5359 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5361 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5363 * alloc.c (Fmake_string): Check for out-of-range init.
5365 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5367 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5369 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5371 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5372 xg_get_default_scrollbar_width.
5374 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5375 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5376 (style_changed_cb): Call update_theme_scrollbar_width and call
5377 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5378 all frames (Bug#8505).
5379 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5380 Call gtk_window_set_resizable if HAVE_GTK3.
5381 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5382 and height if HAVE_GTK3 (Bug#8505).
5383 (scroll_bar_width_for_theme): New variable.
5384 (update_theme_scrollbar_width): New function.
5385 (xg_get_default_scrollbar_width): Move code to
5386 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5387 (xg_initialize): Call update_theme_scrollbar_width.
5389 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5391 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5393 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5395 * frame.c (make_frame): Call other_buffer_safely instead of
5398 * window.c (temp_output_buffer_show): Call display_buffer with
5399 second argument Vtemp_buffer_show_specifiers and reset latter
5400 immediately after the call.
5401 (Vtemp_buffer_show_specifiers): New variable.
5402 (auto_window_vscroll_p, next_screen_context_lines)
5403 (Vscroll_preserve_screen_position): Remove leading asterisks from
5406 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5408 Fix minor problems found by GCC 4.6.0 static checking.
5409 * buffer.c (Qclone_number): Remove for now, as it's unused.
5410 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5411 (record_buffer): Remove unused local.
5412 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5413 (set_frame_buffer_list): Remove; unused.
5414 * frame.h (other_visible_frames): Remove decl.
5415 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5416 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5417 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5419 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5420 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5421 Define only if HAVE_GPM.
5422 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5423 (update_hints_inhibit): Remove; never set. All uses removed.
5424 * widgetprv.h (emacsFrameClassRec): Remove decl.
5425 * window.c (delete_deletable_window): Now returns void, since it
5426 wasn't returning anything.
5427 (compare_window_configurations): Remove unused locals.
5428 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5429 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5430 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5431 the same widths as pointers. This follows up on the 2011-05-06 patch.
5432 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5433 * xterm.h: Likewise.
5434 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5436 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5438 * makefile.w32-in: Update dependencies.
5439 (LISP_H): Add lib/intprops.h.
5441 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5443 * image.c (gif_load): Add animation frame delay to the metadata.
5444 (syms_of_image): Use DEFSYM. New symbol `delay'.
5446 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5448 * window.c (delete_deletable_window): Re-add.
5449 (Fset_window_configuration): Rewrite to handle dead buffers and
5450 consequently deletable windows.
5451 (window_tree, Fwindow_tree): Remove. Supply functionality in
5453 (compare_window_configurations): Simplify code.
5455 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5457 * image.c (imagemagick_load_image): Fix type mismatch.
5458 (Fimagemagick_types): Likewise.
5460 * window.h (replace_buffer_in_windows): Declare.
5462 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5464 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5465 Qclone_number. Remove external declaration of Qdelete_window.
5466 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5468 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5469 Run Qbuffer_list_update_hook if allowed.
5470 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5471 buffer list implementation.
5472 (other_buffer_safely): New function.
5473 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5474 calls to replace_buffer_in_windows and
5475 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5477 (record_buffer): Inhibit quitting and rewrite using quittable
5478 functions. Run Qbuffer_list_update_hook if allowed.
5479 (Frecord_buffer, Funrecord_buffer): New functions.
5480 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5481 Move switch-to-buffer to window.el.
5482 (bury-buffer): Move to window.el.
5483 (Vbuffer_list_update_hook): New variable.
5485 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5488 * window.h (resize_frame_windows): Move up in code.
5489 (Fwindow_frame): Remove EXFUN.
5490 (replace_buffer_in_all_windows): Remove prototype.
5491 (replace_buffer_in_windows_safely): Add prototype.
5493 * window.c: Declare Qdelete_window static again. Move down
5494 declaration of select_count.
5495 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5496 (Fother_window): Move to window.el.
5497 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5498 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5499 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5501 (replace_buffer_in_windows): Implement by calling
5502 Qreplace_buffer_in_windows.
5503 (replace_buffer_in_all_windows): Remove with some functionality
5504 moved into replace_buffer_in_windows_safely.
5505 (replace_buffer_in_windows_safely): New function.
5506 (select_window_norecord, select_frame_norecord): Move in front
5507 of run_window_configuration_change_hook. Remove now obsolete
5509 (Fset_window_buffer): Rewrite doc-string.
5510 Call Qrecord_window_buffer.
5511 (keys_of_window): Move binding for other-window to window.el.
5513 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5515 * dispextern.h (struct image): Replace data member, whose int_val
5516 and ptr_val fields were not used by anything, with a single
5519 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5520 (gif_clear_image, gif_load, imagemagick_load_image)
5521 (gs_clear_image, gs_load): Callers changed.
5523 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5525 * buffer.h: Include <time.h>, for time_t.
5526 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5528 Fix minor problems found by static checking.
5530 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5532 Make identifiers static if they are not used in other modules.
5533 * data.c (Qcompiled_function, Qframe, Qvector):
5534 * image.c (QimageMagick, Qsvg):
5535 * minibuf.c (Qmetadata):
5536 * window.c (resize_window_check, resize_root_window): Now static.
5537 * window.h (resize_window_check, resize_root_window): Remove decls.
5539 * window.c (window_deletion_count, delete_deletable_window):
5541 (window_body_lines): Now static.
5542 (Fdelete_other_windows_internal): Mark vars as initialized.
5543 Make sure 'resize_failed' is initialized.
5544 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5545 (resize_window_apply): Remove unused local.
5546 * window.h (delete_deletable_window): Remove decl.
5548 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5549 (imagemagick_load_image): Fix pointer signedness problem by changing
5550 last arg from unsigned char * to char *. All uses changed.
5551 Also, fix a local for similar reasons.
5552 Remove unused locals. Remove locals to avoid shadowing.
5553 (fn_rsvg_handle_free): Remove; unused.
5554 (svg_load, svg_load_image): Fix pointer signedness problem.
5555 (imagemagick_load_image): Don't use garbage pointer image_wand.
5557 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5559 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5561 * image.c (gif_load): Fix omitted cast error introduced by
5564 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5566 * window.h (resize_proportionally, orig_total_lines)
5567 (orig_top_line): Remove from window structure.
5568 (set_window_height, set_window_width, change_window_heights)
5569 (Fdelete_window): Remove prototypes.
5570 (resize_frame_windows): Remove duplicate declaration.
5572 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5574 * window.h (resize_frame_windows, resize_window_check)
5575 (delete_deletable_window, resize_root_window)
5576 (resize_frame_windows): Declare prototypes.
5578 * window.c (resize_window_apply): Make definition be "static" to
5579 match the prototype.
5581 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5583 * window.c: Remove declarations of Qwindow_size_fixed,
5584 window_min_size_1, window_min_size_2, window_min_size,
5585 size_window, window_fixed_size_p, enlarge_window, delete_window.
5586 Remove static from declaration of Qdelete_window, it's
5587 temporarily needed by Fbury_buffer.
5588 (replace_window): Don't assign orig_top_line and
5590 (Fdelete_window, delete_window): Remove. Window deletion is
5591 handled by window.el.
5592 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5593 Replace Fdelete_window calls with calls to Qdelete_window.
5594 (Fdelete_other_windows): Remove. Deleting other windows is
5595 handled by window.el.
5596 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5597 handled in window.el.
5598 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5599 Window minimum sizes are handled in window.el.
5600 (shrink_windows, size_window, set_window_height)
5601 (set_window_width, change_window_heights, window_height)
5602 (window_width, CURBEG, CURSIZE, enlarge_window)
5603 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5604 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5605 handled in window.el.
5606 (make_dummy_parent): Rename to make_parent_window and give it a
5607 second argument horflag.
5608 (make_window): Don't set resize_proportionally any more.
5609 (Fsplit_window): Remove. Windows are split in window.el.
5610 (save_restore_action, save_restore_orig_size)
5611 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5612 Resize mini windows in window.el.
5613 (grow_mini_window, shrink_mini_window): Implement by calling
5614 Qresize_root_window_vertically, resize_window_check and
5615 resize_window_apply.
5616 (saved_window, Fset_window_configuration, save_window_save):
5617 Do not handle orig_top_line, orig_total_lines, and
5618 resize_proportionally.
5619 (window_min_height, window_min_width): Move to window.el.
5620 (keys_of_window): Move bindings for delete-other-windows,
5621 split-window, delete-window and enlarge-window to window.el.
5623 * buffer.c: Temporarily extern Qdelete_window.
5624 (Fbury_buffer): Temporarily call Qdelete_window instead of
5625 Fdelete_window (Fbury_buffer will move to window.el soon).
5627 * frame.c (set_menu_bar_lines_1): Remove code handling
5628 orig_top_line and orig_total_lines.
5630 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5631 set_window_height but set heights directly.
5632 (change_frame_size_1): Use resize_frame_windows.
5634 * xdisp.c (init_xdisp): Don't use set_window_height but set
5637 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5638 Use resize_frame_windows instead of change_window_heights and run
5639 run_window_configuration_change_hook.
5641 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5642 instead of change_window_heights and run
5643 run_window_configuration_change_hook.
5645 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5647 * window.c (replace_window): Rename second argument REPLACEMENT to
5648 NEW. New third argument SETFLAG. Rewrite.
5649 (delete_window, make_dummy_parent): Call replace_window with
5651 (window_list_1): Move down in code.
5652 (run_window_configuration_change_hook): Move set_buffer part
5653 before select_frame_norecord part in order to unwind correctly.
5654 Rename count1 to count.
5655 (recombine_windows, delete_deletable_window, resize_root_window)
5656 (Fdelete_other_windows_internal)
5657 (Frun_window_configuration_change_hook, make_parent_window)
5658 (resize_window_check, resize_window_apply, Fresize_window_apply)
5659 (resize_frame_windows, Fsplit_window_internal)
5660 (Fdelete_window_internal, Fresize_mini_window_internal):
5662 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5664 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5666 * window.h (window): Add some new members to window structure -
5667 normal_lines, normal_cols, new_total, new_normal, clone_number,
5668 splits, nest, prev_buffers, next_buffers.
5669 (WINDOW_TOTAL_SIZE): Move here from window.c.
5670 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5672 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5674 (make_dummy_parent): Set new members of windows structure.
5675 (make_window): Move down in code. Handle new members of window
5677 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5678 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5679 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5680 (Fset_window_prev_buffers, Fwindow_next_buffers)
5681 (Fset_window_next_buffers, Fset_window_clone_number):
5683 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5684 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5686 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5687 Argument WINDOW can be now internal window too.
5688 (Fwindow_use_time): Move up in code.
5689 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5691 (Fset_window_configuration, saved_window)
5692 (Fcurrent_window_configuration, save_window_save): Handle new
5693 members of window structure.
5694 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5695 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5696 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5697 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5698 Qget_mru_window, Qresize_root_window,
5699 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5700 Qauto_buffer_name; staticpro them.
5702 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5704 * window.c (Fwindow_total_size, Fwindow_left_column)
5705 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5706 (Fwindow_list_1): New functions.
5707 (window_box_text_cols): Replace with window_body_cols.
5708 (Fwindow_width, Fscroll_left, Fscroll_right):
5709 Use window_body_cols instead of window_box_text_cols.
5710 (delete_window, Fset_window_configuration):
5711 Call delete_all_subwindows with window as argument.
5712 (delete_all_subwindows): Take a window as argument and not a
5714 (window_loop): Remove handling of GET_LRU_WINDOW and
5716 (Fget_lru_window, Fget_largest_window): Move to window.el.
5718 * window.h: Extern window_body_cols instead of
5719 window_box_text_cols. delete_all_subwindows now takes a
5720 Lisp_Object as argument.
5722 * indent.c (compute_motion, Fcompute_motion):
5723 Use window_body_cols instead of window_box_text_cols.
5725 * frame.c (delete_frame): Call delete_all_subwindows with root
5728 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5730 * fns.c (Fputhash): Document return value.
5732 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5734 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5736 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5738 Cons<->int and similar integer overflow fixes (Bug#8794).
5740 Check for overflow when converting integer to cons and back.
5741 * charset.c (Fdefine_charset_internal, Fdecode_char):
5742 Use cons_to_unsigned to catch overflow.
5743 (Fencode_char): Use INTEGER_TO_CONS.
5744 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5745 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5746 * data.c (long_to_cons, cons_to_long): Remove.
5747 (cons_to_unsigned, cons_to_signed): New functions.
5748 These signal an error for invalid or out-of-range values.
5749 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5750 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5751 * font.c (Ffont_variation_glyphs):
5752 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5753 * lisp.h: Include <intprops.h>.
5754 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5755 (cons_to_signed, cons_to_unsigned): New decls.
5756 (long_to_cons, cons_to_long): Remove decls.
5757 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5758 (Fprimitive_undo): Use CONS_TO_INTEGER.
5759 * xfns.c (Fx_window_property): Likewise.
5760 * xselect.c: Include <limits.h>.
5761 (x_own_selection, selection_data_to_lisp_data):
5762 Use INTEGER_TO_CONS.
5763 (x_handle_selection_request, x_handle_selection_clear)
5764 (x_get_foreign_selection, Fx_disown_selection_internal)
5765 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5766 (lisp_data_to_selection_data): Use cons_to_unsigned.
5767 (x_fill_property_data): Use cons_to_signed.
5768 Report values out of range.
5770 Check for buffer and string overflow more precisely.
5771 * buffer.h (BUF_BYTES_MAX): New macro.
5772 * lisp.h (STRING_BYTES_MAX): New macro.
5773 * alloc.c (Fmake_string):
5774 * character.c (string_escape_byte8):
5775 * coding.c (coding_alloc_by_realloc):
5776 * doprnt.c (doprnt):
5777 * editfns.c (Fformat):
5779 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5780 since they may not be the same number.
5781 * editfns.c (Finsert_char):
5782 * fileio.c (Finsert_file_contents):
5783 Likewise for BUF_BYTES_MAX.
5785 * image.c: Use ptrdiff_t, not int, for sizes.
5786 (slurp_file): Switch from int to ptrdiff_t.
5788 (slurp_file): Check that file size fits in both size_t (for
5789 malloc) and ptrdiff_t (for sanity and safety).
5791 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5792 if b->modtime has its maximal value.
5794 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5796 Don't assume time_t can fit into int.
5797 * buffer.h (struct buffer.modtime): Now time_t, not int.
5798 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5799 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5801 Minor fixes for signed vs unsigned integers.
5802 * character.h (MAYBE_UNIFY_CHAR):
5803 * charset.c (maybe_unify_char):
5804 * keyboard.c (read_char, reorder_modifiers):
5805 XINT -> XFASTINT, since the integer must be nonnegative.
5806 * ftfont.c (ftfont_spec_pattern):
5807 * keymap.c (access_keymap, silly_event_symbol_error):
5808 XUINT -> XFASTINT, since the integer must be nonnegative.
5809 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5810 since it makes no difference and we prefer signed.
5811 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5812 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5815 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5817 * window.h (Fwindow_frame): Declare.
5819 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5821 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5822 (SPARE_MEMORY): Always define.
5823 (LARGE_REQUEST): Remove.
5824 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5826 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5828 * lisp.h: Move EXFUNS for Fframe_root_window,
5829 Fframe_first_window and Fset_frame_selected_window to window.h.
5831 * window.h: Move EXFUNS for Fframe_root_window,
5832 Fframe_first_window and Fset_frame_selected_window here from
5835 * frame.c (Fwindow_frame, Fframe_first_window)
5836 (Fframe_root_window, Fframe_selected_window)
5837 (Fset_frame_selected_window): Move to window.c.
5838 (Factive_minibuffer_window): Move to minibuf.c.
5839 (Fother_visible_frames_p): New function.
5841 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5843 * window.c (decode_window, decode_any_window): Move up in code.
5844 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5845 (inhibit_frame_unsplittable): Remove unused variable.
5846 (Fwindow_buffer): Move up and rewrite doc-string.
5847 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5848 (Fwindow_prev): New functions.
5849 (Fwindow_frame): Move here from frame.c. Accept any window as
5851 (Fframe_root_window, Fframe_first_window)
5852 (Fframe_selected_window): Move here from frame.c. Accept frame
5853 or arbitrary window as argument. Update doc-strings.
5854 (Fminibuffer_window): Move up in code.
5855 (Fwindow_minibuffer_p): Move up in code and simplify.
5856 (Fset_frame_selected_window): Move here from frame.c.
5858 (Fselected_window, select_window, Fselect_window): Move up in
5859 code. Minor doc-string fixes.
5861 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5863 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5864 Do not assume that spare memory exists; that assumption is valid
5865 only if SYSTEM_MALLOC.
5866 (LARGE_REQUEST): New macro, so that the issue of large requests
5867 is separated from the issue of spare memory.
5869 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5871 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5874 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5876 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5879 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5881 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5883 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5885 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5886 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5888 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5890 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5892 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5894 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5895 (x_clipboard_manager_save): Add return value.
5896 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5898 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5899 Obey Vx_select_enable_clipboard_manager. Catch errors in
5900 x_clipboard_manager_save (Bug#8779).
5901 (Vx_select_enable_clipboard_manager): New variable.
5902 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5904 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5906 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5908 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5910 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5911 in the current matrix if keep_current_p is non-zero.
5913 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5915 * bidi.c (bidi_level_of_next_char): Fix last change.
5917 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5919 Support bidi reordering of text covered by display properties.
5921 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5922 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5923 (bidi_cache_search, bidi_cache_iterator_state)
5924 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5925 (bidi_level_of_next_char, bidi_move_to_visually_next):
5926 Support character positions inside a run of characters covered by a
5928 (bidi_paragraph_init, bidi_resolve_explicit_1)
5929 (bidi_level_of_next_char): Call bidi_fetch_char and
5930 bidi_fetch_char_advance instead of FETCH_CHAR and
5932 (bidi_init_it): Initialize new members.
5933 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5935 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5936 instead of using explicit *_CHAR codes.
5937 (bidi_resolve_explicit, bidi_resolve_weak):
5938 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5939 bidirectional text is supported only in multibyte buffers.
5940 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5941 it to initialize the frame_window_p member of struct bidi_it.
5942 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5943 (bidi_resolve_explicit, bidi_resolve_weak)
5944 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5945 bidi_it->nchars is non-positive.
5946 (bidi_level_of_next_char): Don't try to lookup the cache for the
5947 next/previous character if nothing is cached there yet, or if we
5948 were just reseat()'ed to a new position.
5950 * xdisp.c (set_cursor_from_row): Set start and stop points
5951 according to the row's direction when priming the loop that looks
5952 for the glyph on which to display cursor.
5953 (single_display_spec_intangible_p): Function deleted.
5954 (display_prop_intangible_p): Reimplement to call
5955 handle_display_spec instead of single_display_spec_intangible_p.
5956 Accept 3 additional arguments needed by handle_display_spec.
5957 This fixes incorrect cursor motion across display property with complex
5958 values: lists, `(when COND...)' forms, etc.
5959 (single_display_spec_string_p): Support property values that are
5960 lists with the argument STRING its top-level element.
5961 (display_prop_string_p): Fix the condition for processing a
5962 property that is a list to be consistent with handle_display_spec.
5963 (handle_display_spec): New function, refactored from the
5964 last portion of handle_display_prop.
5965 (compute_display_string_pos): Accept additional argument
5966 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5967 value of a `display' property is a "replacing spec".
5968 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5969 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5970 the display property, but just return a value indicating whether
5971 the display property will replace the characters it covers.
5972 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5973 frame_window_p members of struct bidi_it.
5974 (compute_display_string_pos, compute_display_string_end):
5976 (push_it): Accept second argument POSITION, where pop_it should
5977 jump to continue iteration.
5978 (reseat_1): Initialize bidi_it.disp_pos.
5980 * keyboard.c (adjust_point_for_property): Adjust the call to
5981 display_prop_intangible_p to its new signature.
5983 * dispextern.h (struct bidi_it): New member frame_window_p.
5984 (bidi_init_it): Update prototypes.
5985 (display_prop_intangible_p): Update prototype.
5986 (compute_display_string_pos, compute_display_string_end):
5988 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5991 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5993 Malloc failure behavior now depends on size of allocation.
5994 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5995 * lisp.h: Change signatures accordingly.
5996 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5997 All callers changed. (Bug#8762)
5999 * gnutls.c: Use Emacs's memory allocators.
6000 Without this change, the gnutls library would invoke malloc etc.
6001 directly, which causes problems on non-SYNC_INPUT hosts, and which
6002 runs afoul of improving memory_full behavior. (Bug#8761)
6003 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6004 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6005 xfree instead of the default malloc, realloc, free.
6006 (Fgnutls_boot): No need to check for memory allocation failure,
6007 since xmalloc does that for us.
6009 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6010 * category.c (hash_get_category_set):
6011 * ccl.c (ccl_driver):
6012 * charset.c (Fdefine_charset_internal):
6013 * charset.h (struct charset.hash_index):
6014 * composite.c (get_composition_id, gstring_lookup_cache)
6015 (composition_gstring_put_cache):
6016 * composite.h (struct composition.hash_index):
6017 * dispextern.h (struct image.hash):
6018 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6019 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6020 (hashfn_equal, hashfn_user_defined, make_hash_table)
6021 (maybe_resize_hash_table, hash_lookup, hash_put)
6022 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6023 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6024 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6025 * image.c (make_image, search_image_cache, lookup_image)
6026 (xpm_put_color_table_h):
6027 * lisp.h (struct Lisp_Hash_Table):
6028 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6029 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6030 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6031 * alloc.c (allocate_vectorlike):
6032 Check for overflow in vector size calculations.
6033 * ccl.c (ccl_driver):
6034 Check for overflow when converting EMACS_INT to int.
6035 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6036 need to be updated by these changes.
6037 * fns.c (make_hash_table, maybe_resize_hash_table):
6038 Check for integer overflow with large hash tables.
6039 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6040 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6041 (SXHASH_REDUCE): New macro.
6042 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6043 Use it instead of discarding useful hash info with large hash values.
6044 (sxhash_float): New function.
6045 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6046 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6047 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6048 Rewrite to use FIXNUM_BITS, as this simplifies things.
6049 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6050 Adjust signatures to match updated version of code.
6051 (consing_since_gc): Now EMACS_INT, since a single hash table can
6052 use more than INT_MAX bytes.
6054 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6056 Make it possible to build with GCC-4.6+ -O2 -flto.
6058 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6060 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6062 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6063 Call minibuffer-inactive-mode.
6065 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6067 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6068 Update dependencies.
6070 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6072 * data.c (init_data): Remove code for UTS, this system is not
6075 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6077 Don't force ./temacs to start in terminal mode.
6079 * frame.c (make_initial_frame): Initialize faces in all cases, not
6080 only when CANNOT_DUMP is defined.
6081 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6083 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6085 * dispnew.c (add_window_display_history): Use const for the string
6086 pointer. Remove declaration, not needed.
6088 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6090 Use 'inline', not 'INLINE'.
6091 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6092 * alloc.c, fontset.c (INLINE): Remove.
6093 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6094 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6095 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6096 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6097 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6099 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6101 Make it possible to run ./temacs.
6103 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6104 syms_of_callproc does the same thing. Remove test for
6105 "initialized", do it in the caller.
6106 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6108 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6110 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6111 (read_minibuf): Use get_minibuffer.
6112 (syms_of_minibuf): Use DEFSYM.
6113 (Qmetadata): New var.
6114 * data.c (Qbuffer): Don't make it static.
6115 (syms_of_data): Use DEFSYM.
6117 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6119 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6120 (CCL_CODE_MIN): New macro.
6122 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6124 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6126 * eval.c (Qdebug): Now static.
6127 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6128 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6129 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6131 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6133 * image.c: Various fixes to ImageMagick code comments.
6134 (Fimagemagick_types): Doc fix.
6136 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6138 Minor fixes prompted by GCC 4.6.0 warnings.
6140 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6142 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6143 (x_clipboard_manager_save_all): Move extern decl to ...
6144 * xterm.h: ... here, so that it can be checked for consistency.
6146 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6148 * xselect.c (x_clipboard_manager_save_frame)
6149 (x_clipboard_manager_save_all): New functions.
6150 (Fx_clipboard_manager_save): Lisp function deleted.
6152 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6153 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6155 * xterm.h: Update prototype.
6157 2011-05-28 William Xu <william.xwl@gmail.com>
6159 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6162 2011-05-28 Jim Meyering <meyering@redhat.com>
6164 Avoid a sign-extension bug in crypto_hash_function.
6165 * fns.c (to_uchar): Define.
6166 (crypto_hash_function): Use it to convert some newly-signed
6167 variables to unsigned, to avoid sign-extension bugs. For example,
6168 without this change, (md5 "truc") would evaluate to
6169 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6170 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6171 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6173 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6175 Integer overflow fixes.
6177 * dbusbind.c: Serial number integer overflow fixes.
6178 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6179 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6180 to hold a serial number that is too large for a fixnum.
6181 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6182 Check for serial numbers out of range. Decode any serial number
6183 that was so large that it became a float. (Bug#8722)
6185 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6186 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6187 Use XFASTINT rather than XUINT when numbers are nonnegative.
6188 (xd_append_arg, Fdbus_method_return_internal):
6189 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6190 arguments, check that Lisp number is nonnegative, rather than
6191 silently wrapping negative numbers around. (Bug#8722)
6192 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6195 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6197 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6199 ccl: Add integer overflow checks.
6200 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6201 (IN_INT_RANGE): New macros.
6202 (ccl_driver): Use them to check for integer overflow when
6203 decoding a CCL program. Many of the new checks are whether XINT (x)
6204 fits in int; it doesn't always, on 64-bit hosts. The new version
6205 doesn't catch all possible integer overflows, but it's an
6206 improvement. (Bug#8719)
6208 * alloc.c (make_event_array): Use XINT, not XUINT.
6209 There's no need for unsigned here.
6211 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6212 This follows up to the 2011-05-06 change that substituted uintptr_t
6213 for EMACS_INT. This case wasn't caught back then.
6215 Rework Fformat to avoid integer overflow issues.
6216 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6217 now (part of C89). Include <verify.h>.
6218 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6219 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6220 (Fformat): Avoid the prepass trying to compute sizes; it was only
6221 approximate and thus did not catch overflow reliably. Instead, walk
6222 through the format just once, formatting and computing sizes as we go,
6223 checking for integer overflow at every step, and allocating a larger
6224 buffer as needed. Keep track separately whether the format is
6225 multibyte. Keep only the most-recently calculated precision, rather
6226 than them all. Record whether each argument has been converted to
6227 string. Use EMACS_INT, not int, for byte and char and arg counts.
6228 Support field widths and precisions larger than INT_MAX. Avoid
6229 sprintf's undefined behavior with conversion specifications such as %#d
6230 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6231 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6232 formatting out-of-range floating point numbers with int
6235 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6237 * data.c: Avoid integer truncation in expressions involving floats.
6238 * data.c: Include <intprops.h>.
6239 (arith_driver): When there's an integer overflow in an expression
6240 involving floating point, convert the integers to floating point
6241 so that the resulting value does not suffer from catastrophic
6242 integer truncation. For example, on a 64-bit host (* 4
6243 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6244 Do not rely on undefined behavior after integer overflow.
6246 merge count_size_as_multibyte, parse_str_to_multibyte
6247 * character.c, character.h (count_size_as_multibyte):
6248 Rename from parse_str_to_multibyte; all uses changed.
6249 Check for integer overflow.
6250 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6251 since it's now a duplicate of the other. This is more of
6252 a character than a buffer op, so better that it's in character.c.
6253 * fns.c, print.c: Adjust to above changes.
6255 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6257 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6259 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6261 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6262 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6263 (x_clipboard_manager_save): Now static.
6264 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6266 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6267 (crypto_hash_function): Now static.
6268 Fix pointer signedness problems. Avoid unnecessary initializations.
6270 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6272 * termhooks.h (Vselection_alist): Make it terminal-local.
6274 * terminal.c (create_terminal): Initialize it.
6276 * xselect.c: Support for clipboard managers.
6277 (Vselection_alist): Move to termhooks.h as terminal-local var.
6278 (LOCAL_SELECTION): New macro.
6279 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6280 (symbol_to_x_atom): Remove gratuitous arg.
6281 (x_handle_selection_request, lisp_data_to_selection_data)
6282 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6283 (x_own_selection, x_get_local_selection, x_convert_selection):
6284 New arg, specifying work frame. Use terminal-local Vselection_alist.
6285 (some_frame_on_display): Delete unused function.
6286 (Fx_own_selection_internal, Fx_get_selection_internal)
6287 (Fx_disown_selection_internal, Fx_selection_owner_p)
6288 (Fx_selection_exists_p): New optional frame arg.
6289 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6290 (x_handle_selection_clear): Don't treat other terminals with the
6291 same keyboard specially. Use the terminal-local Vselection_alist.
6292 (x_clear_frame_selections): Use Frun_hook_with_args.
6294 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6296 * xterm.h: Add support for those atoms.
6298 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6300 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6301 (converted_selections, conversion_fail_tag): New global variables.
6302 (x_selection_request_lisp_error): Free the above.
6303 (x_get_local_selection): Remove unnecessary code.
6304 (x_reply_selection_request): Args changed; handle arbitrary array
6305 of converted selections stored in converted_selections.
6306 Separate the XChangeProperty and SelectionNotify steps.
6307 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6308 (x_convert_selection): New function.
6309 (x_handle_selection_event): Simplify.
6310 (x_get_foreign_selection): Don't ignore incoming requests while
6311 waiting for an answer; this will fail when we implement
6312 SAVE_TARGETS, and seems unnecessary anyway.
6313 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6314 (Vx_sent_selection_functions): Doc fix.
6316 2011-05-26 Leo Liu <sdl.web@gmail.com>
6318 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6320 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6322 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6324 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6325 for fringe update if it has periodic bitmap.
6326 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6327 and fringe_bitmap_periodic_p.
6329 * fringe.c (get_fringe_bitmap_data): New function.
6330 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6331 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6332 row. Mark glyph row for fringe update if periodicity changed.
6334 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6335 for fringe update unless it has periodic bitmap.
6337 2011-05-25 Kenichi Handa <handa@m17n.org>
6339 * xdisp.c (get_next_display_element): Set correct it->face_id for
6340 a static composition.
6342 2011-05-24 Leo Liu <sdl.web@gmail.com>
6345 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6347 * fns.c (crypto_hash_function, Fsha1): New function.
6348 (Fmd5): Use crypto_hash_function.
6349 (syms_of_fns): Add Ssha1.
6351 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6353 * gnutls.c: Remove unused macros.
6354 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6355 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6356 Remove macros that are defined and never used.
6357 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6359 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6361 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6362 (Fx_get_selection_internal): Minor cleanup.
6363 (Fx_own_selection_internal): Rename arguments for consistency with
6366 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6368 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6370 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6372 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6374 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6376 * dispnew.c (scrolling_window): Don't exclude the case that the
6377 last enabled row in the desired matrix touches the bottom boundary.
6379 2011-05-21 Glenn Morris <rgm@gnu.org>
6381 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6382 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6383 and add some more files.
6385 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6387 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6388 report_file_error introduced by the change from 2011-05-07.
6390 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6392 * systime.h (Time): Define only if emacs is defined.
6393 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6394 where the include path doesn't have X11/X.h by default. See
6395 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6397 2011-05-20 Kenichi Handa <handa@m17n.org>
6399 * composite.c (find_automatic_composition): Fix previous change.
6401 2011-05-20 Glenn Morris <rgm@gnu.org>
6403 * lisp.mk: New file, split from Makefile.in.
6404 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6405 (shortlisp): Remove.
6406 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6408 2011-05-19 Glenn Morris <rgm@gnu.org>
6410 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6411 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6412 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6413 (lisp): Set the order to that of loadup.el.
6414 (shortlisp): Make it a copy of $lisp.
6415 (SOME_MACHINE_LISP): Remove.
6416 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6417 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6419 2011-05-18 Kenichi Handa <handa@m17n.org>
6421 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6422 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6423 (find_automatic_composition): Mostly rewrite for efficiency.
6425 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6427 * makefile.w32-in: Update dependencies.
6429 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6431 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6432 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6434 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6436 Fix some integer overflow issues, such as string length overflow.
6438 * insdel.c (count_size_as_multibyte): Check for string overflow.
6440 * character.c (lisp_string_width): Check for string overflow.
6441 Use EMACS_INT, not int, for string indexes and lengths; in
6442 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6443 the resulting string length overflows an EMACS_INT; instead,
6444 report a string overflow if no precision given. When checking for
6445 precision exhaustion, use a check that cannot possibly have
6446 integer overflow. (Bug#8675)
6447 * character.h (lisp_string_width): Adjust to new signature.
6449 * alloc.c (string_overflow): New function.
6450 (Fmake_string): Use it. This doesn't change behavior, but saves
6451 a few bytes and will simplify future changes.
6452 * character.c (string_escape_byte8): Likewise.
6453 * lisp.h (string_overflow): New decl.
6455 Fixups, following up to the user-interface timestamp change.
6456 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6457 for UI timestamps, instead of unsigned long.
6458 * msdos.c (mouse_get_pos): Likewise.
6459 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6460 * w32gui.h (Time): Define by including "systime.h" rather than by
6461 declaring it ourselves. (Bug#8664)
6463 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6464 * image.c (clear_image_cache): Likewise.
6466 * term.c (term_mouse_position): Don't assume time_t wraparound.
6468 Be more systematic about user-interface timestamps.
6469 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6470 and sometimes 'EMACS_UINT', to represent these timestamps.
6471 This change causes it to use 'Time' uniformly, as that's what X uses.
6472 This makes the code easier to follow, and makes it easier to catch
6473 integer overflow bugs such as Bug#8664.
6474 * frame.c (Fmouse_position, Fmouse_pixel_position):
6475 Use Time, not unsigned long, for user-interface timestamps.
6476 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6477 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6478 * keyboard.h (last_event_timestamp): Likewise.
6479 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6480 * menu.h (xmenu_show): Likewise.
6481 * term.c (term_mouse_position): Likewise.
6482 * termhooks.h (struct input_event.timestamp): Likewise.
6483 (struct terminal.mouse_position_hook): Likewise.
6484 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6485 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6486 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6487 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6489 * menu.h, termhooks.h: Include "systime.h", for Time.
6491 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6492 Don't assume that the difference between two unsigned long values
6493 can fit into an integer. At this point, we know button_down_time
6494 <= event->timestamp, so the difference must be nonnegative, so
6495 there's no need to cast the result if double-click-time is
6496 nonnegative, as it should be; check that it's nonnegative, just in
6497 case. This bug is triggered when events are more than 2**31 ms
6498 apart (about 25 days). (Bug#8664)
6500 * xselect.c (last_event_timestamp): Remove duplicate decl.
6501 (x_own_selection): Remove needless cast to unsigned long.
6503 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6504 that always fit in int. Use a sentinel instead of a counter, to
6505 avoid a temp and to allay GCC's concerns about possible int overflow.
6506 * frame.h (struct frame): Use int for menu_bar_items_used
6507 instead of EMACS_INT, since it always fits in int.
6509 * menu.c (grow_menu_items): Check for int overflow.
6511 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6513 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6514 Before, the code was not consistent. These values cannot exceed
6515 2**31 - 1 so there's no need to make them unsigned.
6516 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6517 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6518 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6520 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6522 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6523 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6524 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6525 presumably because the widths might not match.
6527 * window.c (size_window): Avoid needless test at loop start.
6529 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6531 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6533 2011-05-12 Drew Adams <drew.adams@oracle.com>
6535 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6537 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6539 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6540 `width' to `bar_area_x' and `bar_area_width', respectively.
6541 (x_scroll_run): Take account of fringe background extension.
6543 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6544 Rename local vars `left' and `width' to `bar_area_x' and
6545 `bar_area_width', respectively.
6546 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6547 background extension.
6549 2011-05-10 Jim Meyering <meyering@redhat.com>
6551 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6553 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6555 * image.c (Finit_image_library): Return t for built-in image types,
6556 like pbm and xbm. (Bug#8640)
6558 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6560 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6562 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6564 * w32console.c (Fset_screen_color): Doc fix.
6565 (Fget_screen_color): New function.
6566 (syms_of_ntterm): Defsubr it.
6568 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6569 unlink the temporary file if Fcall_process didn't create it in the
6571 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6572 child process will be redirected to a file specified with `:file'.
6573 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6574 cue to call_process_cleanup not to close that handle.
6576 2011-05-07 Ben Key <bkey76@gmail.com>
6578 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6579 one of two shell specific rules, either bootstrap-temacs-CMD or
6580 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6581 to the previous implementation of the bootstrap-temacs rule.
6582 The bootstrap-temacs-CMD rule is similar to the previous
6583 implementation of the bootstrap-temacs rule except that it
6584 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6587 These changes, along with some changes to nt/configure.bat,
6588 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6589 earlier fix to add support for --cflags and --ldflags options
6590 that include quotes so that it works whether make uses cmd or
6593 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6595 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6596 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6598 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6599 a string. Handle both cases.
6600 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6601 (Fdbus_register_method): Use Qinvalid_function.
6603 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6605 * makefile.w32-in: Update dependencies.
6606 (LISP_H): Add inttypes.h and stdin.h.
6607 (PROCESS_H): Add unistd.h.
6609 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6611 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6612 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6614 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6616 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6618 * term.c (vfatal): Remove stray call to va_end.
6619 It's not needed and the C Standard doesn't allow it here anyway.
6621 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6622 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6624 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6627 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6629 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6631 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6633 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6635 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6637 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6638 * charset.c (Fdefine_charset_internal): Don't initialize
6639 charset.code_space[15]. The value was garbage, on hosts with
6640 32-bit int (Bug#8600).
6642 * lread.c (read_integer): Be more consistent with string-to-number.
6643 Use string_to_number to do the actual conversion; this avoids
6644 rounding errors and fixes some other screwups. Without this fix,
6645 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6646 (digit_to_number): Move earlier, for benefit of read_integer.
6647 Return -1 if the digit is out of range for the base, -2 if it is
6648 not a digit in any supported base. (Bug#8602)
6650 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6652 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6653 to match comment at start of function. This also removes a
6654 GCC warning about overflow in a 32+64-bit port.
6656 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6658 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6659 Reported by Stefan Monnier in
6660 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6661 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6662 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6664 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6665 (EMACS_UINTPTR): Likewise, with uintptr_t.
6667 * lisp.h: Prefer 64-bit EMACS_INT if available.
6668 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6669 on 32-bit hosts that have 64-bit int, so that they can access
6671 However, temporarily disable this change unless the temporary
6672 symbol WIDE_EMACS_INT is defined.
6674 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6676 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6677 This removes an assumption that EMACS_INT and long are the same
6678 width as pointers. The assumption is true for Emacs porting targets
6679 now, but we want to make other targets possible.
6680 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6681 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6682 In the rest of the code, change types of integers that hold casted
6683 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6684 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6685 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6686 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6687 No need to cast type when ORing.
6688 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6689 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6690 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6691 assume EMACS_INT is the same width as char *.
6692 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6693 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6694 Remove no-longer-needed casts.
6695 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6696 (xg_tool_bar_help_callback, xg_make_tool_item):
6697 Use EMACS_INTPTR to hold an integer
6698 that will be cast to void *; this can avoid a GCC warning
6699 if EMACS_INT is not the same width as void *.
6700 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6701 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6702 (current_message_1, set_message_1):
6703 Use a local to convert to proper width without a cast.
6704 * xmenu.c (dialog_selection_callback): Likewise.
6706 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6707 Also, don't assume VALBITS / RAND_BITS is less than 5,
6708 and don't rely on undefined behavior when shifting a 1 left into
6710 * lisp.h (get_random): Change signature to match.
6712 * lread.c (hash_string): Use size_t, not int, for hash computation.
6713 Normally we prefer signed values; but hashing is special, because
6714 it's better to use unsigned division on hash table sizes so that
6715 the remainder is nonnegative. Also, size_t is the natural width
6716 for hashing into memory. The previous code used 'int', which doesn't
6717 retain enough info to hash well into very large tables.
6718 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6720 * dbusbind.c: Don't possibly lose pointer info when converting.
6721 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6722 Use XPNTR rather than XHASH, so that the high-order bits of
6723 the pointer aren't lost when converting through void *.
6725 * eval.c (Fautoload): Don't double-shift a pointer.
6727 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6729 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6731 * gnutls.c (DEF_GNUTLS_FN):
6732 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6734 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6736 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6739 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6741 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6742 New version that can reserve upto 2GB of heap space.
6744 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6746 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6748 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6750 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6751 `gnutls_certificate_set_x509_key_file'.
6753 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6755 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6756 Update dependencies.
6758 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6760 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6761 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6762 Remove unused parameter `fildes'.
6763 * process.c (read_process_output, send_process): Don't pass it.
6765 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6767 Fix previous change: the library cache is defined in w32.c.
6768 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6769 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6771 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6773 Implement dynamic loading of GnuTLS on Windows.
6775 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6776 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6777 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6780 * gnutls.c (Qgnutls_dll): Define.
6781 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6782 (gnutls_*): Declare function pointers.
6783 (init_gnutls_functions): New function to initialize function pointers.
6784 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6785 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6786 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6787 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6788 (emacs_gnutls_write, emacs_gnutls_read)
6789 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6790 (Fgnutls_available_p): New function.
6791 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6792 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6793 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6795 * image.c: Include w32.h.
6796 (Vimage_type_cache): Delete.
6797 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6798 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6799 (w32_delayed_load): Move to w32.c.
6801 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6803 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6804 (w32_delayed_load): Move from image.c. When loading a library, record
6805 its filename in the :loaded-from property of the library id.
6806 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6807 Initialize and staticpro them.
6808 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6810 * process.c: Include lisp.h before w32.h, not after.
6811 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6812 instead of gnutls_record_check_pending.
6814 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6816 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6818 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6819 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6822 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6824 * xterm.c (x_set_frame_alpha): Do not set property on anything
6825 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6827 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6829 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6831 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6833 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6834 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6835 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6836 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6837 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6838 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6839 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6840 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6841 (Qgnutls_bootprop_callbacks_verify): Make static.
6843 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6845 * callproc.c: Indentation fixup.
6847 * sysdep.c (wait_for_termination_1): Make static.
6848 (wait_for_termination, interruptible_wait_for_termination):
6849 Move after wait_for_termination_1.
6851 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6853 * sysdep.c (interruptible_wait_for_termination): New function
6854 which is like wait_for_termination, but allows keyboard
6857 * callproc.c (Fcall_process): Add (:file "file") as an option for
6859 (Fcall_process_region): Ditto.
6861 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6863 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6864 rather than `XVECTOR (FOO)->size'.
6866 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6867 inttypes.h, as a gnulib replacement is used if it not available in
6870 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6872 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6873 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6874 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6876 * coding.c (coding_alloc_by_realloc): Error out if destination
6877 will grow beyond MOST_POSITIVE_FIXNUM.
6878 (decode_coding_emacs_mule): Abort if there isn't enough place in
6879 charbuf for the composition carryover bytes. Reserve an extra
6880 space for up to 2 characters produced in a loop.
6881 (decode_coding_iso_2022): Abort if there isn't enough place in
6882 charbuf for the composition carryover bytes.
6884 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6886 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6887 aborting when %lld or %lll format is passed.
6888 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6889 %llo or %llx format is passed. (Bug#8545)
6891 * window.c (window_scroll_line_based): Use a marker instead of
6892 simple variables to record original value of point. (Bug#7952)
6894 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6895 produced by %s or %c overflows available buffer space. (Bug#8545)
6897 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6899 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6900 (SIZE_MAX): Move defn after all includes, as they might #define it.
6902 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6904 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6906 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6908 * keyboard.c (Qdelayed_warnings_hook): Define.
6909 (command_loop_1): Run `delayed-warnings-hook'
6910 if Vdelayed_warnings_list is non-nil.
6911 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6912 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6914 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6916 * doprnt.c (doprnt): Don't return value smaller than the buffer
6917 size if the message was truncated. (Bug#8545).
6919 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6921 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6922 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6924 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6926 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6928 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6930 * makefile.w32-in: Update dependencies.
6932 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6934 Improve `doprnt' and its usage. (Bug#8545)
6935 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6936 `format_end'. Remove support for %l as a conversion specifier.
6937 Don't use xrealloc. Improve diagnostics when the %l size modifier
6938 is used. Update the commentary.
6940 * eval.c (verror): Simplify calculation of size_t.
6942 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6945 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6947 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6950 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6952 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6953 This makes this file independent of the recent pseudovector change.
6955 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6957 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6959 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6960 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6961 Remove unused local.
6962 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6964 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6965 GCC 4.6.0 optimizes based on type-based alias analysis.
6966 For example, if b is of type struct buffer * and v of type struct
6967 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6968 != &v->size, and therefore "v->size = 1; b->size = 2; return
6969 v->size;" must therefore return 1. This assumption is incorrect
6970 for Emacs, since it type-puns struct Lisp_Vector * with many other
6971 types. To fix this problem, this patch adds a new type struct
6972 vectorlike_header that documents the constraints on layout of vectors
6973 and pseudovectors, and helps optimizing compilers not get fooled
6974 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6975 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6976 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6978 (XSETPVECTYPE): Rewrite in terms of new macro.
6979 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6980 This is a bit clearer, and further avoids the possibility of
6981 undesirable aliasing.
6982 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6983 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6984 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6985 since Lisp_Subr is a special case (no "next" field).
6986 (ASIZE): Now uses header.size rather than size.
6987 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6988 to avoid the hassle of writing XVECTOR (foo)->header.size.
6989 (struct vectorlike_header): New type.
6990 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6991 object, to help avoid aliasing.
6992 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6993 (SUBRP): Likewise, since Lisp_Subr is a special case.
6994 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6995 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6996 (struct Lisp_Hash_Table): Combine first two members into a single
6997 struct vectorlike_header member. All uses of "size" and "next" members
6998 changed to be "header.size" and "header.next".
6999 * buffer.h (struct buffer): Likewise.
7000 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7001 * frame.h (struct frame): Likewise.
7002 * process.h (struct Lisp_Process): Likewise.
7003 * termhooks.h (struct terminal): Likewise.
7004 * window.c (struct save_window_data, struct saved_window): Likewise.
7005 * window.h (struct window): Likewise.
7006 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7007 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7008 * buffer.c (init_buffer_once): Likewise.
7009 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7011 * process.c (Fformat_network_address): Use local var for size,
7014 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7016 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7017 * data.c (atof): Remove decl; no longer used or needed.
7018 (digit_to_number): Move to lread.c.
7019 (Fstring_to_number): Use new string_to_number function, to be
7020 consistent with how the Lisp reader treats infinities and NaNs.
7021 Do not assume that floating-point numbers represent EMACS_INT
7022 without losing information; this is not true on most 64-bit hosts.
7023 Avoid double-rounding errors, by insisting on integers when
7024 parsing non-base-10 numbers, as the documentation specifies.
7025 * lisp.h (string_to_number): New decl, replacing ...
7026 (isfloat_string): Remove.
7027 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7028 (read1): Do not accept +. and -. as integers; this
7029 appears to have been a coding error. Similarly, do not accept
7030 strings like +-1e0 as floating point numbers. Do not report
7031 overflow for integer overflows unless the base is not 10 which
7032 means we have no simple and reliable way to continue.
7033 Break out the floating-point parsing into a new
7034 function string_to_number, so that Fstring_to_number parses
7035 floating point numbers consistently with the Lisp reader.
7036 (digit_to_number): Move here from data.c. Make it static inline.
7037 (E_CHAR, EXP_INT): Remove, replacing with ...
7038 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7039 (string_to_number): New function, replacing isfloat_string.
7040 This function checks for valid syntax and produces the resulting
7041 Lisp float number too. Rework it so that string-to-number
7042 no longer mishandles examples like "1.0e+". Use strtoumax,
7043 so that overflow for non-base-10 numbers is reported only when
7044 there's no portable and simple way to convert to floating point.
7046 * textprop.c (set_text_properties_1): Rewrite for clarity,
7047 and to avoid GCC warning about integer overflow.
7049 * intervals.h (struct interval): Use EMACS_INT for members
7050 where EMACS_UINT might cause problems. See
7051 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7052 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7053 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7055 (offset_intervals): Tell GCC not to worry about length overflow
7056 when negating a negative length.
7058 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7059 (overrun_check_free): Likewise.
7061 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7062 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7065 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7066 (gnutls_make_error): Rename local to avoid shadowing.
7067 (gnutls_emacs_global_deinit): ifdef out; not used.
7068 (Fgnutls_boot): Use const for pointer to readonly storage.
7069 Comment out unused local. Fix pointer signedness problems.
7071 * lread.c (openp): Don't stuff size_t into an 'int'.
7072 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7073 about possible signed overflow.
7075 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7076 (GDK_KEY_g): Don't define if already defined.
7077 (xg_prepare_tooltip): Avoid pointer signedness problem.
7078 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7080 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7081 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7083 * xfns.c (Fx_window_property): Simplify a bit,
7084 to make a bit faster and to avoid GCC 4.6.0 warning.
7085 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7087 * fns.c (internal_equal): Don't assume size_t fits in int.
7089 * alloc.c (compact_small_strings): Tighten assertion a little.
7091 Replace pEd with more-general pI, and fix some printf arg casts.
7092 * lisp.h (pI): New macro, generalizing old pEd macro to other
7093 conversion specifiers. For example, use "...%"pI"d..." rather
7094 than "...%"pEd"...".
7095 (pEd): Remove. All uses replaced with similar uses of pI.
7096 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7097 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7098 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7099 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7100 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7101 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7102 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7104 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7105 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7106 * print.c (safe_debug_print, print_object): Likewise.
7107 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7109 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7110 avoiding the 0 flag, which is not portable.
7111 * process.c (Fmake_network_process): Use pI to avoid cast.
7112 * region-cache.c (pp_cache): Likewise.
7113 * xdisp.c (decode_mode_spec): Likewise.
7114 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7115 behavior on 64-bit hosts with printf arg.
7116 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7117 (x_stop_queuing_selection_requests): Likewise.
7118 (x_get_window_property): Don't truncate byte count to an 'int'
7121 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7122 here, since it parses constructs like leading '-' and spaces,
7123 which are not wanted; and it overflows with large numbers.
7124 Instead, simply match F[0-9]+, which is what is wanted anyway.
7126 * alloc.c: Remove unportable assumptions about struct layout.
7127 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7128 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7129 (allocate_vectorlike, make_pure_vector): Use the new macros,
7130 plus offsetof, to remove unportable assumptions about struct layout.
7131 These assumptions hold on all porting targets that I know of, but
7132 they are not guaranteed, they're easy to remove, and removing them
7133 makes further changes easier.
7135 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7136 This doesn't fix a bug but makes the code clearer.
7137 (string_overrun_cookie): Now const. Use initializers that
7138 don't formally overflow signed char, to avoid warnings.
7139 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7140 can cause Emacs to crash when string overrun checking is enabled.
7141 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7142 multiple of sizeof (EMACS_INT); it need not be, if
7143 alignof(EMACS_INT) < sizeof (EMACS_INT).
7144 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7146 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7148 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7150 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7152 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7153 supposed to be handshaking. (Bug#8556)
7154 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7156 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7158 * lisp.h (Qdebug): List symbol.
7159 * eval.c (Qdebug): Restore global linkage.
7160 * keyboard.c (debug-on-event): New variable.
7161 (handle_user_signal): Break into debugger when debug-on-event
7162 matches the current signal symbol.
7164 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7166 * alloc.c (check_sblock, check_string_bytes)
7167 (check_string_free_list): Convert to standard C.
7169 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7171 * w32.c (emacs_gnutls_push): Fix typo.
7173 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7175 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7176 "cast to pointer from integer of different size".
7178 Improve doprnt and its use in verror. (Bug#8545)
7179 * doprnt.c (doprnt): Document the set of format control sequences
7180 supported by the function. Use SAFE_ALLOCA instead of always
7183 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7184 is one byte too soon. Don't use xrealloc; instead xfree and
7187 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7189 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7192 * gnutls.c: Renamed global_initialized to
7193 gnutls_global_initialized. Added internals for the
7194 :verify-hostname-error, :verify-error, and :verify-flags
7195 parameters of `gnutls-boot' and documented those parameters in the
7196 docstring. Start callback support.
7197 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7198 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7199 on error. Return error code.
7200 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7201 (emacs_gnutls_read): Likewise.
7202 (Fgnutls_boot): Return handshake error code.
7203 (emacs_gnutls_handle_error): New function.
7204 (wsaerror_to_errno): Likewise.
7206 * w32.h (emacs_gnutls_pull): Add prototype.
7207 (emacs_gnutls_push): Likewise.
7209 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7210 (emacs_gnutls_push): Likewise.
7212 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7214 * process.c (wait_reading_process_output): Check if GnuTLS
7215 buffered some data internally if no FDs are set for TLS
7218 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7219 (LIBS): Link to USER_LIBS.
7220 ($(BLD)/gnutls.$(0)): New target.
7222 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7224 * xdisp.c (handle_single_display_spec): Rename the
7225 display_replaced_before_p argument into display_replaced_p, to
7226 make it consistent with the commentary. Fix typos in the
7229 * textprop.c (syms_of_textprop): Remove dead code.
7230 (copy_text_properties): Delete obsolete commentary about an
7231 interface that was deleted long ago. Fix typos in the description
7234 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7235 to changes in oldXMenu/XMenu.h from 2011-04-16.
7236 <menu_help_message, prev_menu_help_message>: Constify.
7237 (IT_menu_make_room): menu->help_text is now `const char **';
7240 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7241 to changes in oldXMenu/XMenu.h from 2011-04-16.
7242 (struct XMenu): Declare `help_text' `const char **'.
7244 * xfaces.c <Qunspecified>: Make extern again.
7246 * syntax.c: Include sys/types.h before including regex.h, as
7249 * doc.c (get_doc_string): Improve the format passed to `error'.
7251 * doprnt.c (doprnt): Improve commentary.
7253 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7255 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7258 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7259 changes in globals.h immediately force recompilation.
7260 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7261 $(CURDIR)/s/ms-w32.h.
7262 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7264 * character.c (Fchar_direction): Function deleted.
7265 (syms_of_character): Don't defsubr it.
7266 <char-direction-table>: Deleted.
7268 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7270 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7271 * doprnt.c: Include limits.h.
7272 (SIZE_MAX): New macro.
7273 (doprnt): Return a size_t value. 2nd arg is now size_t.
7274 Many local variables are now size_t instead of int or unsigned.
7275 Improve overflow protection. Support `l' modifier for integer
7276 conversions. Support %l conversion. Don't assume an EMACS_INT
7277 argument for integer conversions and for %c.
7279 * lisp.h (doprnt): Restore prototype.
7281 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7284 * Makefile.in (base_obj): Add back doprnt.o.
7286 * deps.mk (doprnt.o): Add back prerequisites.
7287 (callint.o): Depend on character.h.
7289 * eval.c (internal_lisp_condition_case): Include the handler
7290 representation in the error message.
7291 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7292 when breaking from the loop.
7294 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7296 * callint.c (Fcall_interactively): When displaying error message
7297 about invalid control letter, pass the character's codepoint, not
7298 a pointer to its multibyte form. Improve display of the character
7299 in octal and display also its hex code.
7301 * character.c (char_string): Use %x to display the (unsigned)
7302 codepoint of an invalid character, to avoid displaying a bogus
7305 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7306 `error', not SYMBOL_NAME itself.
7308 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7309 character arguments to `error'.
7311 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7312 to `error' in error message about FINAL_CHAR argument. Make sure
7313 FINAL_CHAR is a character, and use %c when it is passed as
7314 argument to `error'.
7316 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7318 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7320 * w32.c: Include <time.h>.
7321 (sys_localtime): New function.
7323 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7325 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7327 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7329 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7331 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7334 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7336 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7337 gl_state.e_property when gl_state.object is Qt.
7339 * insdel.c (make_gap_larger): Remove limitation of buffer size
7342 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7344 * xdisp.c (lookup_glyphless_char_display)
7345 (produce_glyphless_glyph): Handle cons cell entry in
7346 glyphless-char-display.
7347 (Vglyphless_char_display): Document it.
7349 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7350 glyphless-char-display.
7352 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7354 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7356 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7358 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7359 definition for no-X builds.
7361 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7363 Static checks with GCC 4.6.0 and non-default toolkits.
7365 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7367 * process.c (keyboard_bit_set): Define only if SIGIO.
7368 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7369 (send_process): Repair possible setjmp clobbering.
7371 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7373 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7375 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7377 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7378 Define only if needed.
7380 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7381 by pacifying GCC about it. Maybe it's time to retire it?
7382 * xfaces.c (USG, __TIMEVAL__): Likewise.
7384 * dispextern.h (struct redisplay_interface): Rename param
7386 * termhooks.h (struct terminal): Likewise.
7387 * xterm.c (xembed_send_message): Likewise.
7389 * insdel.c (make_gap_smaller): Define only if
7390 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7392 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7395 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7396 so that we aren't warned about unused symbols.
7398 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7400 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7402 * xfns.c (x_real_positions): Mark locals as initialized.
7404 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7406 * xterm.c: Fix problems found by static analysis with other toolkits.
7407 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7408 (x_dispatch_event): Declare static if USE_GTK, and
7409 define if USE_GTK || USE_X_TOOLKIT.
7410 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7411 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7412 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7413 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7415 * xmenu.c (menu_help_callback): Pointer type fixes.
7416 Use const pointers when pointing at readonly data. Avoid pointer
7418 (FALSE): Remove unused macro.
7419 (update_frame_menubar): Remove unused decl.
7421 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7423 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7424 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7425 (single_menu_item): Rename local to avoid shadowing.
7427 * keyboard.c (make_lispy_event): Remove unused local var.
7429 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7430 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7432 * bitmaps: Change bitmaps from unsigned char back to the X11
7433 compatible char. Avoid the old compiler warnings about
7434 out-of-range initializers by using, for example, '\xab' rather
7437 * xgselect.c (xgselect_initialize): Check vs interface
7438 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7440 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7442 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7443 to read-only memory.
7445 * fns.c (vector): Remove; this old hack is no longer needed.
7447 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7449 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7451 * xrdb.c (x_load_resources): Omit unused local.
7453 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7454 (x_window): Rename locals to avoid shadowing.
7455 (USG): Use the kludged USG macro, to pacify gcc.
7457 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7458 (x_term_init): Remove local to avoid shadowing.
7460 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7462 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7463 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7465 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7467 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7469 Fix regex.c, syntax.c and friends for buffers > 2GB.
7470 * syntax.h (struct gl_state_s): Declare character position members
7473 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7475 * textprop.c (verify_interval_modification, interval_of):
7476 Declare arguments EMACS_INT.
7478 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7481 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7483 * indent.c (Fvertical_motion): Local variable it_start is now
7486 * regex.c (re_match, re_match_2, re_match_2_internal)
7487 (bcmp_translate, regcomp, regexec, print_double_string)
7488 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7489 (re_compile_pattern, re_exec): Declare arguments and local
7490 variables `size_t' and `ssize_t' and return values `regoff_t', as
7492 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7493 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7494 <compile_stack_type>: `size' and `avail' are now `size_t'.
7496 * regex.h <regoff_t>: Use ssize_t, not int.
7497 (re_search, re_search_2, re_match, re_match_2): Arguments that
7498 specify buffer/string position and length are now ssize_t and
7499 size_t. Return type is regoff_t.
7501 2011-04-16 Ben Key <bkey76@gmail.com>
7503 * nsfont.m: Fixed bugs in ns_get_family and
7504 ns_descriptor_to_entity that were caused by using free to
7505 deallocate memory blocks that were allocated by xmalloc (via
7506 xstrdup). This caused Emacs to crash when compiled with
7507 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7508 --enable-checking=xmallocoverrun). xfree is now used to
7509 deallocate these memory blocks.
7511 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7513 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7515 emacs_write: Accept and return EMACS_INT for sizes.
7516 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7518 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7519 Accept and return EMACS_INT.
7520 (emacs_gnutls_write): Return the number of bytes written on
7522 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7523 (emacs_read, emacs_write): Remove check for negative size, as the
7524 Emacs source code has been audited now.
7525 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7526 (emacs_read, emacs_write): Use it.
7527 * process.c (send_process): Adjust to the new signatures of
7528 emacs_write and emacs_gnutls_write. Do not attempt to store
7529 a byte offset into an 'int'; it might overflow.
7530 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7532 * sound.c: Don't assume sizes fit in 'int'.
7533 (struct sound_device.period_size, alsa_period_size):
7534 Return EMACS_INT, not int.
7535 (struct sound_device.write, vox_write, alsa_write):
7536 Accept EMACS_INT, not int.
7537 (wav_play, au_play): Use EMACS_INT to store sizes and to
7538 record read return values.
7540 2011-04-15 Ben Key <bkey76@gmail.com>
7542 * keyboard.c (Qundefined): Don't declare static since it is used
7544 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7545 static since they are used in nsfont.m.
7547 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7549 * process.c (Qprocessp): Don't declare static.
7550 * lisp.h (Qprocessp): Declare again.
7552 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7554 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7556 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7558 Improve C-level modularity by making more things 'static'.
7560 Don't publish debugger-only interfaces to other modules.
7561 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7562 (verify_bytepos, count_markers): Move decls to the only modules
7564 * region-cache.h (pp_cache): Likewise.
7565 * window.h (check_all_windows): Likewise.
7566 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7568 * sysdep.c (croak): Now static, if
7569 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7570 * syssignal.h (croak): Declare only if not static.
7572 * alloc.c (refill_memory_reserve): Now static if
7573 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7574 * lisp.h (refill_memory_reserve): Declare only if not static.
7576 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7577 Define only if USE_LUCID.
7579 * xrdb.c (x_customization_string, x_rm_string): Now static.
7581 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7582 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7584 * xdisp.c (draw_row_with_mouse_face): Now static.
7585 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7587 * window.h (check_all_windows): Mark externally visible.
7589 * window.c (window_deletion_count): Now static.
7591 * undo.c: Make symbols static if they're not exported.
7592 (last_undo_buffer, last_boundary_position, pending_boundary):
7595 * textprop.c (interval_insert_behind_hooks): Now static.
7596 (interval_insert_in_front_hooks): Likewise.
7598 * term.c: Make symbols static if they're not exported.
7599 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7600 (max_frame_lines, tty_set_terminal_modes):
7601 (tty_reset_terminal_modes, tty_turn_off_highlight):
7602 (get_tty_terminal): Now static.
7603 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7604 * termhooks.h (term_mouse_moveto): Do not declare if
7606 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7607 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7609 * sysdep.c: Make symbols static if they're not exported.
7610 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7612 (sigprocmask_set, full_mask): Remove; unused.
7613 (wait_debugging): Mark as visible.
7614 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7615 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7617 * syntax.c (syntax_temp): Define only if !__GNUC__.
7619 * sound.c (current_sound_device, current_sound): Now static.
7621 * search.c (searchbufs, searchbuf_head): Now static.
7623 * scroll.c (scroll_cost): Remove; unused.
7624 * dispextern.h (scroll_cost): Remove decl.
7626 * region-cache.h (pp_cache): Mark as externally visible.
7628 * process.c: Make symbols static if they're not exported.
7629 (process_tick, update_tick, create_process, chan_process):
7630 (Vprocess_alist, proc_buffered_char, datagram_access):
7631 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7632 (deactivate_process): Mark defn as static, as well as decl.
7633 * lisp.h (create_process): Remove decl.
7634 * process.h (chan_process, Vprocess_alist): Remove decls.
7636 * print.c: Make symbols static if they're not exported.
7637 (print_depth, new_backquote_output, being_printed, print_buffer):
7638 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7639 (print_interval, print_number_index, initial_stderr_stream):
7641 * lisp.h (Fprinc): Remove decl.
7642 (debug_output_compilation_hack): Mark as externally visible.
7644 * sysdep.c (croak): Move decl from here to syssignal.h.
7645 * syssignal.h (croak): Put it here, so the API can be checked when
7646 'croak' is called from dissociate_if_controlling_tty.
7648 * minibuf.c: Make symbols static if they're not exported.
7649 (minibuf_save_list, choose_minibuf_frame): Now static.
7650 * lisp.h (choose_minibuf_frame): Remove decl.
7652 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7654 * lread.c: Make symbols static if they're not exported.
7655 (read_objects, initial_obarray, oblookup_last_bucket_number):
7657 (make_symbol): Remove; unused.
7658 * lisp.h (initial_obarray, make_symbol): Remove decls.
7660 * keyboard.c: Make symbols static if they're not exported.
7661 (single_kboard, recent_keys_index, total_keys, recent_keys):
7662 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7663 (this_single_command_key_start, echoing, last_auto_save):
7664 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7665 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7666 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7667 (Vlispy_mouse_stem, double_click_count):
7669 (force_auto_save_soon): Define only if SIGDANGER.
7670 (ignore_mouse_drag_p): Now static if
7671 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7672 (print_help): Remove; unused.
7673 (stop_character, last_timer_event): Mark as externally visible.
7674 * keyboard.h (ignore_mouse_drag_p): Declare only if
7675 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7676 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7677 * lisp.h (echoing): Remove decl.
7678 (force_auto_save_soon): Declare only if SIGDANGER.
7679 * xdisp.c (redisplay_window): Simplify code, to make it more
7680 obvious that ignore_mouse_drag_p is not accessed if !defined
7681 USE_GTK && !defined HAVE_NS.
7683 * intervals.c: Make symbols static if they're not exported.
7684 (merge_properties_sticky, merge_interval_right, delete_interval):
7686 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7688 * insdel.c: Make symbols static if they're not exported.
7689 However, leave prepare_to_modify_buffer alone. It's never
7690 called from outside this function, but that appears to be a bug.
7691 (combine_after_change_list, combine_after_change_buffer):
7692 (adjust_after_replace, signal_before_change): Now static.
7693 (adjust_after_replace_noundo): Remove; unused.
7694 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7695 (signal_before_change): Remove decls.
7697 * indent.c (val_compute_motion, val_vmotion): Now static.
7699 * image.c: Make symbols static if they're not exported.
7700 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7702 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7703 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7705 * fringe.c (standard_bitmaps): Now static.
7706 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7708 * frame.c: Make symbols static if they're not exported.
7709 (x_report_frame_params, make_terminal_frame): Now static.
7710 (get_frame_param): Now static, unless HAVE_NS.
7711 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7712 (x_get_resource_string): Remove; not used.
7713 * frame.h (make_terminal_frame, x_report_frame_params):
7714 (x_get_resource_string); Remove decls.
7715 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7716 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7718 * font.c, fontset.c: Make symbols static if they're not exported.
7719 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7720 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7721 * font.c (font_close_object): Now static.
7722 * font.h (font_close_object): Remove.
7723 * fontset.c (FONTSET_OBJLIST): Remove.
7724 (free_realized_fontset) #if-0 the body, which does nothing.
7725 (face_suitable_for_char_p): #if-0, as it's never called.
7726 * fontset.h (face_suitable_for_char_p): Remove decl.
7727 * xfaces.c (face_at_string_position):
7728 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7729 since 0 is always ASCII.
7731 * fns.c (weak_hash_tables): Now static.
7733 * fileio.c: Make symbols static if they're not exported.
7734 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7735 (Vwrite_region_annotation_buffers): Now static.
7737 * eval.c: Make symbols static if they're not exported.
7738 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7739 * lisp.h (backtrace_list): Remove decl.
7741 * emacs.c: Make symbols static if they're not exported.
7742 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7743 (fatal_error_code, fatal_error_signal_hook, standard_args):
7745 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7746 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7747 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7748 * lisp.h (fatal_error_signal_hook): Remove decl.
7749 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7751 * editfns.c: Move a (normally-unused) function to its only use.
7752 * editfns.c, lisp.h (get_operating_system_release): Remove.
7753 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7754 worth the hassle of breaking this out.
7756 * xterm.c: Make symbols static if they're not exported.
7757 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7758 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7759 (x_destroy_window, x_delete_display):
7761 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7762 (x_mouse_leave): Remove; unused.
7763 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7764 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7765 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7767 (x_mouse_leave): Declare only if WINDOWSNT.
7768 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7769 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7772 * ftxfont.c: Make symbols static if they're not exported.
7773 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7775 * font.h (ftxfont_driver): Likewise.
7777 * xfns.c: Make symbols static if they're not exported.
7778 (x_last_font_name, x_display_info_for_name):
7779 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7780 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7781 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7782 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7783 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7784 (last_show_tip_args): Now static.
7785 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7786 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7787 (x_screen_planes): Remove; unused.
7788 * dispextern.h (x_screen_planes): Remove decl.
7790 * dispnew.c: Make symbols static if they're not exported.
7791 * dispextern.h (redraw_garbaged_frames, scrolling):
7792 (increment_row_positions): Remove.
7793 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7794 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7796 (redraw_garbaged_frames): Remove; unused.
7798 * xfaces.c: Make symbols static if they're not exported.
7799 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7801 * xterm.h (defined_color): Remove decls.
7802 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7803 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7804 (menu_face_changed_default, defined_color, free_realized_face):
7805 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7806 (ascii_face_of_lisp_face): Remove; unused.
7808 * xdisp.c: Make symbols static if they're not exported.
7809 * dispextern.h (scratch_glyph_row, window_box_edges):
7810 (glyph_to_pixel_coords, set_cursor_from_row):
7811 (get_next_display_element, set_iterator_to_next):
7812 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7813 (show_mouse_face): Remove decls
7814 * frame.h (message_buf_print): Likewise.
7815 * lisp.h (pop_message, set_message, check_point_in_composition):
7817 * xterm.h (set_vertical_scroll_bar): Likewise.
7818 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7819 (message_buf_print, scratch_glyph_row, displayed_buffer):
7820 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7821 (get_next_display_element, show_mouse_face, window_box_edges):
7822 (frame_to_window_pixel_xy, check_point_in_composition):
7823 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7824 (glyph_to_pixel_coords): Remove; unused.
7826 * dired.c (file_name_completion): Now static.
7828 * dbusbind.c (xd_in_read_queued_messages): Now static.
7830 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7831 * data.c (circular_list_error): Remove.
7833 * commands.h (last_point_position, last_point_position_buffer):
7834 (last_point_position_window): Remove decls.
7835 * keyboard.c: Make these variables static.
7837 * coding.h (coding, code_convert_region, encode_coding_gap):
7839 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7840 (iso_code_class, detect_coding, code_convert_region): Now static.
7841 (encode_coding_gap): Remove; unused.
7843 * chartab.c (chartab_chars, chartab_bits): Now static.
7845 * charset.h (charset_iso_8859_1): Remove decl.
7846 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7849 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7850 * ccl.c (Vccl_program_table): Now static.
7851 (check_ccl_update): Remove; unused.
7853 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7854 * category.h: ... from here.
7855 * category.c (check_category_table, set_category_set): Now static.
7857 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7858 * lisp.h: Remove these decls.
7860 * buffer.c (buffer_count): Remove unused var.
7862 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7863 so that it's not optimized away.
7864 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7865 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7866 exported only to the debugger.
7868 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7869 * atimer.h (run_all_atimers): Remove; not exported.
7871 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7872 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7873 was inaccessible from Lisp.
7874 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7875 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7877 alloc.c: Import and export fewer symbols, and remove unused items.
7878 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7880 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7881 it's not optimized away by whole-program optimization.
7882 (message_enable_multibyte, free_misc): Remove.
7883 (catchlist, handlerlist, mark_backtrace):
7884 Declare only if BYTE_MARK_STACK.
7885 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7886 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7887 (message_enable_multibyte): Remove decl.
7888 (free_misc, interval_free_list, float_block, float_block_index):
7889 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7890 (cons_free_list, last_marked_index):
7892 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7893 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7894 (mark_backtrace): Define only if BYTE_MARK_STACK.
7895 * xdisp.c (message_enable_multibyte): Now static.
7897 Declare Lisp_Object Q* variables to be 'static' if not exported.
7898 This makes it easier for human readers (and static analyzers)
7899 to see whether these variables are used from other modules.
7900 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7901 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7902 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7903 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7904 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7905 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7906 * xmenu.c, xselect.c:
7907 Declare Q* vars static if they are not used in other modules.
7908 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7909 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7910 Remove decls of unexported vars.
7911 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7913 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7915 Make Emacs functions such as Fatom 'static' by default.
7916 This makes it easier for human readers (and static analyzers)
7917 to see whether these functions can be called from other modules.
7918 DEFUN now defines a static function. To make the function external
7919 so that it can be used in other C modules, use the new macro DEFUE.
7920 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7921 (Finit_image_library):
7922 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7923 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7924 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7925 Remove decls, since these functions are now static.
7926 (Funintern, Fget_internal_run_time): New decls, since these functions
7927 were already external.
7929 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7930 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7931 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7932 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7933 * keyboard.c, keymap.c, lread.c:
7934 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7935 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7936 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7937 Mark functions with DEFUE instead of DEFUN,
7938 if they are used in other modules.
7939 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7940 decls for now-static functions.
7941 * buffer.h (Fdelete_overlay): Remove decl.
7942 * callproc.c (Fgetenv_internal): Mark as internal.
7943 * composite.c (Fremove_list_of_text_properties): Remove decl.
7944 (Fcomposition_get_gstring): New forward static decl.
7945 * composite.h (Fcomposite_get_gstring): Remove decl.
7946 * dired.c (Ffile_attributes): New forward static decl.
7947 * doc.c (Fdocumntation_property): New forward static decl.
7948 * eval.c (Ffetch_bytecode): New forward static decl.
7949 (Funintern): Remove extern decl; now in .h file where it belongs.
7950 * fileio.c (Fmake_symbolic_link): New forward static decl.
7951 * image.c (Finit_image_library): New forward static decl.
7952 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7953 * intervals.h (Fprevious_property_change):
7954 (Fremove_list_of_text_properties): Remove decls.
7955 * keyboard.c (Fthis_command_keys): Remove decl.
7956 (Fcommand_execute): New forward static decl.
7957 * keymap.c (Flookup_key): New forward static decl.
7958 (Fcopy_keymap): Now static.
7959 * keymap.h (Flookup_key): Remove decl.
7960 * process.c (Fget_process): New forward static decl.
7961 (Fprocess_datagram_address): Mark as internal.
7962 * syntax.c (Fsyntax_table_p): New forward static decl.
7963 (skip_chars): Remove duplicate decl.
7964 * textprop.c (Fprevious_property_change): New forward static decl.
7965 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7967 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7968 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7970 * editfns.c (Fformat): Remove unreachable code.
7972 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7974 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7977 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7979 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7980 when at ZV. (Bug#8487)
7982 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7984 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7986 * keyboard.c (parse_tool_bar_item): Likewise.
7987 * sound.c (sound_cleanup, alsa_close): Likewise.
7988 * termcap.c (tgetent): Likewise.
7989 * xfns.c (x_default_font_parameter): Likewise.
7990 * xsettings.c (read_and_apply_settings): Likewise.
7992 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7993 (overrun_check_free): Protoize.
7995 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7997 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7998 since callers should never pass a negative size.
7999 Change the signature to match that of plain 'read' and 'write'; see
8000 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8001 * lisp.h: Update prototypes of emacs_write and emacs_read.
8003 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8005 * xdisp.c (redisplay_window): Don't try to determine the character
8006 position of the scroll margin if the window start point w->startp
8007 is outside the buffer's accessible region. (Bug#8468)
8009 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8011 Fix write-region and its subroutines for buffers > 2GB.
8012 * fileio.c (a_write, e_write): Modify declaration of arguments and
8013 local variables to support buffers larger than 2GB.
8014 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8016 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8017 argument, local variables, and return value.
8019 * lisp.h: Update prototypes of emacs_write and emacs_read.
8021 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8023 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8025 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8027 Fix more problems found by GCC 4.6.0's static checks.
8029 * xdisp.c (vmessage): Use a better test for character truncation.
8031 * charset.c (load_charset_map): <, not <=, for optimization,
8032 and to avoid potential problems with integer overflow.
8033 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8034 * casetab.c (set_identity, shuffle): Likewise.
8035 * editfns.c (Fformat): Likewise.
8036 * syntax.c (skip_chars): Likewise.
8038 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8039 This also lets GCC 4.6.0 generate slightly better loop code.
8041 * callint.c (Fcall_interactively): <, not <=, for optimization.
8042 (Fcall_interactively): Count the number of arguments produced,
8043 not the number of arguments given. This is simpler and lets GCC
8044 4.6.0 generate slightly better code.
8046 * ftfont.c: Distingish more carefully between FcChar8 and char.
8047 The previous code passed unsigned char * to a functions like
8048 strlen and xstrcasecmp that expect char *, which does not
8049 conform to the C standard.
8050 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8051 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8052 char * when the C standard requires it.
8054 * keyboard.c (read_char): Remove unused var.
8056 * eval.c: Port to Windows vsnprintf (Bug#8435).
8058 (SIZE_MAX): Define if the headers do not.
8059 (verror): Do not give up if vsnprintf returns a negative count.
8060 Instead, grow the buffer. This ports to Windows vsnprintf, which
8061 does not conform to C99. Problem reported by Eli Zaretskii.
8062 Also, simplify the allocation scheme, by avoiding the need for
8063 calling realloc, and removing the ALLOCATED variable.
8065 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8067 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8068 But keep the doprint source code for now, as we might revamp it
8069 and use it again (Bug#8435).
8070 * lisp.h (doprnt): Remove.
8071 * Makefile.in (base_obj): Remove doprnt.o.
8072 * deps.mk (doprnt.o): Remove.
8074 error: Print 32- and 64-bit integers portably (Bug#8435).
8075 Without this change, on typical 64-bit hosts error ("...%d...", N)
8076 was used to print both 32- and 64-bit integers N, which relied on
8078 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8079 * lisp.h (error, verror): Mark as printf-like functions.
8080 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8081 Report overflow in size calculations when allocating printf buffer.
8082 Do not truncate output string at its first null byte.
8083 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8084 Truncate the output at a character boundary, since vsnprintf does not
8086 * charset.c (check_iso_charset_parameter): Convert internal
8087 character to string before calling 'error', since %c now has the
8089 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8090 overflow when computing char to be passed to 'error'. Do not
8091 pass Lisp_Object to 'error'; pass the integer instead.
8092 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8093 formatted with plain %d.
8095 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8097 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8099 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8101 * xterm.c (x_catch_errors): Remove duplicate declaration.
8103 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8105 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8107 2011-04-10 Jim Meyering <meyering@redhat.com>
8109 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8110 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8111 return ssize_t not "int", and use size_t as the buffer length.
8112 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8113 * gnutls.h: Update declarations.
8114 * process.c (read_process_output): Use ssize_t, to match.
8115 (send_process): Likewise.
8117 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8119 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8121 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8123 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8124 Use unsigned char, to match FcChar8 type definition.
8126 * xterm.c (handle_one_xevent):
8127 * xmenu.c (create_and_show_popup_menu):
8128 * xselect.c (x_decline_selection_request)
8129 (x_reply_selection_request): Avoid type-punned deref of X events.
8131 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8133 Fix some uses of `int' instead of EMACS_INT.
8134 * search.c (string_match_1, fast_string_match)
8135 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8136 (scan_buffer, find_next_newline_no_quit)
8137 (find_before_next_newline, search_command, Freplace_match)
8138 (Fmatch_data): Make some `int' variables be EMACS_INT.
8140 * xdisp.c (display_count_lines): 3rd argument and return value now
8141 EMACS_INT. All callers changed.
8142 (pint2hrstr): Last argument is now EMACS_INT.
8144 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8145 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8146 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8147 (decode_coding_utf_16, decode_coding_emacs_mule)
8148 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8149 (decode_coding_ccl, decode_coding_charset)
8150 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8151 (decode_coding_iso_2022, decode_coding_emacs_mule)
8152 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8153 <char_offset, last_offset>: Declare EMACS_INT.
8154 (encode_coding_utf_8, encode_coding_utf_16)
8155 (encode_coding_emacs_mule, encode_invocation_designation)
8156 (encode_designation_at_bol, encode_coding_iso_2022)
8157 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8158 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8160 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8161 (encode_invocation_designation): Last argument P_NCHARS is now
8163 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8164 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8166 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8169 * ccl.c (Fccl_execute_on_string): Declare some variables
8172 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8174 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8176 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8178 * process.c (Fformat_network_address): Doc fix.
8180 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8182 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8184 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8186 * keyboard.c (read_char): Call Lisp function help-form-show,
8187 instead of using internal_with_output_to_temp_buffer.
8188 (Qhelp_form_show): New var.
8189 (syms_of_keyboard): Use DEFSYM macro.
8191 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8193 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8195 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8197 * process.c (Flist_processes): Remove to Lisp.
8198 (list_processes_1): Delete.
8200 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8202 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8204 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8206 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8208 Fix more problems found by GCC 4.6.0's static checks.
8210 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8212 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8214 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8216 * xdisp.c (vmessage): Mark as a printf-like function.
8218 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8220 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8222 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8223 printf-like functions.
8224 (tiff_load): Add casts to remove these marks before passing them
8225 to system-supplied API.
8227 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8229 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8230 This avoids several warnings with gcc -Wstrict-overflow.
8231 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8232 directly, rather than having caller test rule sign. This avoids
8233 some unnecessary tests.
8234 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8235 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8236 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8238 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8239 (xfont_open): Avoid unnecessary tests.
8241 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8243 * composite.h, composite.c (composition_gstring_put_cache):
8244 Use EMACS_INT, not int, for length.
8246 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8247 breaking out part of COMPOSITION_DECODE_RULE.
8248 (COMPOSITION_DECODE_RULE): Use it.
8249 * composite.c (get_composition_id): Remove unused local vars,
8250 by using the new macro.
8252 * textprop.c (set_text_properties_1): Change while to do-while,
8253 since the condition is always true at first.
8255 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8256 (interval_deletion_adjustment): Return unsigned value.
8259 * process.c (list_processes_1, create_pty, read_process_output):
8260 (exec_sentinel): Remove vars that were set but not used.
8261 (create_pty): Remove unnecessary "volatile"s.
8262 (Fnetwork_interface_info): Avoid possibility of int overflow.
8263 (read_process_output): Do adaptive read buffering even if carryover.
8264 (read_process_output): Simplify nbytes computation if buffered.
8266 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8268 * syntax.c (scan_words): Remove var that was set but not used.
8269 (update_syntax_table): Use unsigned instead of int.
8271 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8272 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8273 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8275 * print.c (print_error_message): Avoid int overflow.
8277 * font.c (font_list_entities): Redo for clarity,
8278 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8280 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8281 (font_score): Avoid potential overflow in diff calculation.
8283 * fns.c (substring_both): Remove var that is set but not used.
8284 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8286 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8288 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8289 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8290 can always succeed if overflow has undefined behavior.
8292 * search.c (boyer_moore, wordify): Remove vars set but not used.
8293 (wordify): Omit three unnecessary tests.
8295 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8296 All callers changed. This avoids the need for an unused var.
8298 * casefiddle.c (casify_region): Remove var that is set but not used.
8300 * dired.c (file_name_completion): Remove var that is set but not used.
8302 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8304 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8305 (Finsert_file_contents): Remove unnecessary code checking fd.
8307 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8308 Check for integer overflow on size calculations.
8310 * buffer.c (Fprevious_overlay_change): Remove var that is set
8313 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8314 Remove vars that are set but not used.
8315 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8316 (timer_check_2): Mark vars as initialized.
8318 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8320 * image.c (lookup_image): Remove var that is set but not used.
8321 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8323 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8324 that are set but not used.
8326 * xfns.c (make_invisible_cursor): Don't return garbage
8327 if XCreateBitmapFromData fails (Bug#8410).
8329 * xselect.c (x_get_local_selection, x_handle_property_notify):
8330 Remove vars that are set but not used.
8332 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8333 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8335 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8336 Remove var that is set but not used.
8337 (scroll_bar_windows_size): Now size_t, not int.
8338 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8341 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8342 (map_tty_color) [!defined MSDOS]: Likewise.
8344 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8346 * coding.c: Remove vars that are set but not used.
8347 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8348 All callers changed.
8349 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8350 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8351 (decode_coding_charset): Remove vars that are set but not used.
8353 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8354 that is set but not used.
8356 * print.c (print_object): Remove var that is set but not used.
8358 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8359 The gnulib version avoids calling malloc in the usual case,
8360 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8361 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8362 * filelock.c (current_lock_owner): Likewise.
8363 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8364 * sysdep.c: Include allocator.h, careadlinkat.h.
8365 (emacs_no_realloc_allocator): New static constant.
8366 (emacs_readlink): New function.
8367 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8368 ../lib/careadlinkat.h.
8370 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8372 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8373 first non-nil return value).
8375 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8377 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8378 if not defined (Bug#8403).
8380 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8382 * xdisp.c (display_count_lines): Remove parameter `start',
8383 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8384 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8385 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8386 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8387 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8388 and thereabouts. All callers changed.
8389 (get_per_char_metric): Remove parameter `f', unused since
8390 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8392 2011-04-02 Jim Meyering <meyering@redhat.com>
8394 do not dereference NULL upon failed strdup
8395 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8396 (ns_get_family): Likewise.
8398 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8400 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8402 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8404 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8407 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8409 Add lexical binding.
8411 * window.c (Ftemp_output_buffer_show): New fun.
8412 (Fsave_window_excursion):
8413 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8415 * lread.c (lisp_file_lexically_bound_p): New function.
8416 (Fload): Bind Qlexical_binding.
8417 (readevalloop): Remove `evalfun' arg.
8418 Bind Qinternal_interpreter_environment.
8419 (Feval_buffer): Bind Qlexical_binding.
8420 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8422 (syms_of_lread): Declare `lexical-binding'.
8424 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8426 * keyboard.c (eval_dyn): New fun.
8427 (menu_item_eval_property): Use it.
8429 * image.c (parse_image_spec): Use Ffunctionp.
8431 * fns.c (concat, mapcar1): Accept byte-code-functions.
8433 * eval.c (Fsetq): Handle lexical vars.
8434 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8435 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8436 (FletX, Flet): Obey lexical binding.
8437 (Fcommandp): Handle closures.
8438 (Feval): New `lexical' arg.
8439 (eval_sub): New function extracted from Feval. Use it almost
8440 everywhere where Feval was used. Look up vars in lexical env.
8442 (Ffunctionp): Move from subr.el.
8443 (Ffuncall): Handle closures.
8444 (apply_lambda): Remove `eval_flags'.
8445 (funcall_lambda): Handle closures and new byte-code-functions.
8446 (Fspecial_variable_p): New function.
8447 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8448 but without exporting it to Lisp.
8450 * doc.c (Fdocumentation, store_function_docstring):
8451 * data.c (Finteractive_form): Handle closures.
8453 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8456 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8458 (exec_byte_code): New function extracted from Fbyte_code to handle new
8459 calling convention for byte-code-functions. Add new byte-codes.
8461 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8463 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8465 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8467 * xdisp.c (redisplay_internal): Fix prototype.
8469 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8471 * xdisp.c (SCROLL_LIMIT): New macro.
8472 (try_scrolling): Use it when setting scroll_limit.
8473 Limit scrolling to 100 screen lines.
8474 (redisplay_window): Even when falling back on "recentering",
8475 position point in the window according to scroll-conservatively,
8476 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8478 (try_scrolling): When point is above the window, allow searching
8479 as far as scroll_max, or one screenful, to compute vertical
8480 distance from PT to the scroll margin position. This prevents
8481 try_scrolling from unnecessarily failing when
8482 scroll-conservatively is set to a value slightly larger than the
8483 window height. Clean up the case of PT below the margin at bottom
8484 of window: scroll_max can no longer be INT_MAX. When aggressive
8485 scrolling is in use, don't let point enter the opposite scroll
8486 margin as result of the scroll.
8487 (syms_of_xdisp) <scroll-conservatively>: Document the
8488 threshold of 100 lines for never-recentering scrolling.
8490 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8492 * dispextern.h (move_it_by_lines):
8493 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8494 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8495 (message_log_check_duplicate): Remove parameters `prev_bol' and
8496 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8497 (redisplay_internal): Remove parameter `preserve_echo_area',
8498 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8500 * indent.c (Fvertical_motion):
8501 * window.c (window_scroll_pixel_based, Frecenter):
8502 Don't pass `need_y_p' to `move_it_by_lines'.
8504 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8506 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8507 steal a few bits to be more compact.
8508 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8509 Remove unneeded casts.
8511 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8513 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8515 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8516 binding" message (bug#7967).
8518 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8520 Fix more problems found by GCC 4.6.0's static checks.
8522 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8523 Remove unused local var.
8525 * editfns.c (Fmessage_box): Remove unused local var.
8527 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8528 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8529 Omit unused local vars.
8530 * window.c (shrink_windows): Omit unused local var.
8531 * menu.c (digest_single_submenu): Omit unused local var.
8532 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8533 Omit unused local var.
8535 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8536 Don't assume string length fits in int.
8537 (keyremap_step, read_key_sequence): Use size_t for sizes.
8538 (read_key_sequence): Don't check last_real_key_start redundantly.
8540 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8541 instead of alloca (Bug#8344).
8543 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8544 (Fbacktrace_frame): Don't assume nframes fits in int.
8546 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8548 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8551 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8553 * cm.c (calccost): Turn while-do into do-while, for clarity.
8555 * keyboard.c (syms_of_keyboard): Use the same style as later
8556 in this function when indexing through an array. This also
8557 works around GCC bug 48267.
8559 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8561 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8563 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8564 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8566 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8567 This avoids undefined behavior on integer overflow, and is a bit
8568 more convenient anyway since it is compared to a size_t variable.
8570 Variadic C functions now count arguments with size_t, not int.
8571 This avoids an unnecessary limitation on 64-bit machines, which
8572 caused (substring ...) to crash on large vectors (Bug#8344).
8573 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8574 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8575 All variadic functions and their callers changed accordingly.
8576 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8577 * data.c (arith_driver, float_arith_driver): Likewise.
8578 * editfns.c (general_insert_function): Likewise.
8579 * eval.c (struct backtrace.nargs, interactive_p)
8580 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8581 (funcall_lambda, mark_backtrace): Likewise.
8582 * fns.c (concat): Likewise.
8583 * frame.c (x_set_frame_parameters): Likewise.
8584 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8585 0 if not found, not -1. All callers changed.
8587 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8588 (stack_copy_size): Now size_t, not int.
8589 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8591 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8593 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8594 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8595 All callers changed.
8597 * lisp.h (multibyte_char_to_unibyte):
8598 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8599 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8600 * character.h (CHAR_TO_BYTE8):
8601 * cmds.c (internal_self_insert):
8602 * editfns.c (general_insert_function):
8603 * keymap.c (push_key_description):
8604 * search.c (Freplace_match):
8605 * xdisp.c (message_dolog, set_message_1): All callers changed.
8607 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8609 * keyboard.c (safe_run_hook_funcall): New function.
8610 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8611 don't set the hook to nil, but remove the offending function instead.
8612 (Qcommand_hook_internal): Remove, unused.
8613 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8614 Vcommand_hook_internal.
8616 * eval.c (enum run_hooks_condition): Remove.
8617 (funcall_nil, funcall_not): New functions.
8618 (run_hook_with_args): Call each function through a `funcall' argument.
8619 Remove `cond' argument, now redundant.
8620 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8621 (Frun_hook_with_args_until_failure): Adjust accordingly.
8622 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8624 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8626 * dispextern.h (string_buffer_position): Remove declaration.
8628 * print.c (strout): Remove parameter `multibyte', unused since
8629 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8631 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8632 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8633 All callers changed.
8635 * w32.c (_wsa_errlist): Use braces for struct initializers.
8637 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8638 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8639 All callers changed.
8640 (string_buffer_position): Likewise. Also, make static (it's never
8641 used outside xdisp.c).
8642 (cursor_row_p): Remove parameter `w', unused since
8643 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8644 (decode_mode_spec): Remove parameter `precision', introduced during
8645 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8646 All callers changed.
8648 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8650 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8652 2011-03-27 Anders Lindgren <andlind@gmail.com>
8654 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8655 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8656 (ns_update_auto_hide_menu_bar): New functions.
8657 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8658 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8659 ns_constrain_all_frames.
8660 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8661 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8663 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8665 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8667 2011-03-27 Glenn Morris <rgm@gnu.org>
8669 * syssignal.h: Replace RETSIGTYPE with void.
8670 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8671 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8672 Replace SIGTYPE with void everywhere.
8673 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8674 * s/template.h (SIGTYPE): Remove commented out definition.
8676 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8678 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8679 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8681 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8683 * w32.c (read_unc_volume): Use parameter `henum', instead of
8684 global variable `wget_enum_handle'.
8686 * keymap.c (describe_vector): Remove parameters `indices' and
8687 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8688 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8690 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8692 * keyboard.c (timer_check): Remove parameter `do_it_now',
8693 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8694 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8695 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8697 * keyboard.c (read_char):
8698 * w32menu.c (w32_menu_display_help):
8699 * xmenu.c (show_help_event, menu_help_callback):
8700 Adjust calls to `show_help_echo'.
8702 * gtkutil.c (xg_maybe_add_timer):
8703 * keyboard.c (readable_events):
8704 * process.c (wait_reading_process_output):
8705 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8707 * insdel.c (adjust_markers_gap_motion):
8708 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8709 (gap_left, gap_right): Don't call it.
8711 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8713 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8714 incurred during fontification.
8716 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8718 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8719 (DEFVAR_PER_BUFFER): Don't pass it.
8721 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8722 (scrolling_window): Don't pass it.
8724 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8726 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8728 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8730 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8731 of variables specific to SELinux and computation of `encoded_absname'.
8733 * image.c (XPutPixel): Remove unused variable `height'.
8735 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8737 * unexw32.c (get_section_info): Remove unused variable `section'.
8739 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8740 (system_process_attributes): Remove unused variable `sess'.
8741 (sys_read): Remove unused variable `err'.
8743 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8744 (w32_wnd_proc): Remove unused variable `isdead'.
8745 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8746 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8747 (x_create_tip_frame): Remove unused variable `tem'.
8749 * w32inevt.c (w32_console_read_socket):
8750 Remove unused variable `no_events'.
8752 * w32term.c (x_draw_composite_glyph_string_foreground):
8753 Remove unused variable `width'.
8755 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8757 * w32term.c (x_set_glyph_string_clipping):
8758 Don't pass uninitialized region to CombineRgn.
8760 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8762 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8763 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8764 (Fx_close_connection): Remove unused variable `i'.
8766 * w32font.c (w32font_draw): Return number of glyphs.
8767 (w32font_open_internal): Remove unused variable `i'.
8768 (w32font_driver): Add missing initializer.
8770 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8771 (fill_in_menu): Remove unused variable `items_added'.
8773 * w32term.c (last_mouse_press_frame): Remove static global variable.
8774 (w32_clip_to_row): Remove unused variable `f'.
8775 (x_delete_terminal): Remove unused variable `i'.
8777 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8778 (NOTHING): Remove unused static global variable.
8779 (uniscribe_check_otf): Remove unused variable `table'.
8780 (uniscribe_font_driver): Add missing initializers.
8782 2011-03-23 Julien Danjou <julien@danjou.info>
8784 * term.c (Fsuspend_tty, Fresume_tty):
8785 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8786 * window.c (temp_output_buffer_show):
8787 * insdel.c (signal_before_change):
8788 * frame.c (Fhandle_switch_frame):
8789 * fileio.c (Fdo_auto_save):
8790 * emacs.c (Fkill_emacs):
8791 * editfns.c (save_excursion_restore):
8792 * cmds.c (internal_self_insert):
8793 * callint.c (Fcall_interactively):
8794 * buffer.c (Fkill_all_local_variables):
8795 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8797 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8798 unconditionally since it does the check itself.
8800 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8802 Fix more problems found by GCC 4.5.2's static checks.
8804 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8805 the first time through the loop, since we know p0 < p1 then.
8806 This also avoids a gcc -Wstrict-overflow warning.
8808 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8809 leading to a memory leak, possible in functions like
8810 load_charset_map_from_file that can allocate an unbounded number
8811 of objects (Bug#8318).
8813 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8814 that could (at least in theory) be that large.
8816 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8817 This is less likely to overflow, and avoids undefined behavior if
8818 overflow does occur. All callers changed. Use strtoul to scan
8819 for the unsigned long integer.
8820 (pint2hrstr): Simplify and tune code slightly.
8821 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8823 * scroll.c (do_scrolling): Work around GCC bug 48228.
8824 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8826 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8827 This also avoids a warning with gcc -Wstrict-overflow.
8828 (validate_x_resource_name): Simplify count usage.
8829 This also avoids a warning with gcc -Wstrict-overflow.
8831 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8834 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8836 * process.c (Fmake_network_process): Use socklen_t, not int,
8837 where POSIX says socklen_t is required in portable programs.
8838 This fixes a porting bug on hosts like 64-bit HP-UX, where
8839 socklen_t is wider than int (Bug#8277).
8840 (Fmake_network_process, server_accept_connection):
8841 (wait_reading_process_output, read_process_output):
8844 * process.c: Rename or move locals to avoid shadowing.
8845 (list_processes_1, Fmake_network_process):
8846 (read_process_output_error_handler, exec_sentinel_error_handler):
8847 Rename or move locals.
8848 (Fmake_network_process): Define label "retry_connect" only if needed.
8849 (Fnetwork_interface_info): Fix pointer signedness.
8850 (process_send_signal): Add cast to avoid pointer signedness problem.
8851 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8852 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8854 Make tparam.h and terminfo.c consistent.
8855 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8856 Include tparam.h instead, since it declares them.
8857 * cm.h (PC): Remove extern decl; tparam.h now does this.
8858 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8859 * terminfo.c: Include tparam.h, to check interfaces.
8860 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8861 (tparam): Adjust signature to match interface in tparam.h;
8862 this removes some undefined behavior. Check that outstring and len
8863 are zero, which they always are with Emacs.
8864 * tparam.h (PC, BC, UP): New extern decls.
8866 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8867 (xftfont_open): Rename locals to avoid shadowing.
8869 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8870 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8871 (OTF_TAG_SYM): Omit macro if not needed.
8872 (ftfont_list): Remove unused local.
8873 (get_adstyle_property, ftfont_pattern_entity):
8874 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8875 Rename locals to avoid shadowing.
8877 * xfont.c (xfont_list_family): Mark var as initialized.
8879 * xml.c (make_dom): Now static.
8881 * composite.c (composition_compute_stop_pos): Rename local to
8883 (composition_reseat_it): Remove unused locals.
8884 (find_automatic_composition, composition_adjust_point): Likewise.
8885 (composition_update_it): Mark var as initialized.
8886 (find_automatic_composition): Mark vars as initialized,
8887 with a FIXME (Bug#8290).
8889 character.h: Rename locals to avoid shadowing.
8890 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8891 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8892 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8893 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8896 * textprop.c (property_change_between_p): Remove; unused.
8898 * intervals.c (interval_start_pos): Now static.
8900 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8902 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8903 Rename locals to avoid shadowing.
8905 * sound.c (wav_play, au_play, Fplay_sound_internal):
8906 Fix pointer signedness.
8907 (alsa_choose_format): Remove unused local var.
8908 (wav_play): Initialize a variable to 0, to prevent undefined
8909 behavior (Bug#8278).
8911 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8913 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8915 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8916 clobbering (Bug#8298).
8917 * sysdep.c (sys_subshell): Likewise.
8918 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8920 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8921 This should get cleaned up, so that child_setup has the
8922 same signature on all platforms.
8924 * callproc.c (call_process_cleanup): Now static.
8925 (relocate_fd): Rename locals to avoid shadowing.
8927 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8929 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8930 not to be necessary, and produces flickering.
8932 2011-03-20 Glenn Morris <rgm@gnu.org>
8934 * config.in: Remove file.
8936 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8938 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8939 are now in src/globals.h.
8940 (syms_of_minibuf): Remove spurious & from previous change.
8942 2011-03-20 Leo Liu <sdl.web@gmail.com>
8944 * minibuf.c (completing-read-function): New variable.
8945 (completing-read-default): Rename from completing-read.
8946 (completing-read): Call completing-read-function.
8948 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8950 * xfaces.c (Fx_load_color_file):
8951 Read color file from absolute filename (bug#8250).
8953 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8955 * makefile.w32-in: Update dependencies.
8957 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8959 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8961 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8963 Fix more problems found by GCC 4.5.2's static checks.
8965 * process.c (make_serial_process_unwind, send_process_trap):
8966 (sigchld_handler): Now static.
8968 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8969 That way, the code declares only the vars that it needs.
8970 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8971 * s/cygwin.h (PTY_ITERATION): Likewise.
8972 * s/darwin.h (PTY_ITERATION): Likewise.
8973 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8975 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8976 * process.c (allocate_pty): Don't declare stb unless it's needed.
8978 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8979 (CONSTANTLIM): Remove; unused.
8980 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8981 Define only if needed.
8983 * unexelf.c (unexec): Name an expression,
8984 to avoid gcc -Wbad-function-cast warning.
8985 Use a different way to cause a compilation error if anyone uses
8986 n rather than nn, a way that does not involve shadowing.
8987 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8989 * deps.mk (unexalpha.o): Remove; unused.
8991 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8992 * unexec.h: New file.
8993 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8994 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8996 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8997 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8998 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8999 Change as necessary to match prototype in unexec.h.
9001 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9003 (back_comment, skip_chars): Mark vars as initialized.
9005 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9006 Rename locals to avoid shadowing.
9008 * lread.c (read1): Rewrite so as not to use empty "else".
9009 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9011 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9013 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9014 warning when compiling print.c.
9016 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9017 instead of using an uninitialized var.
9018 (font_sort_entities): Mark var as initialized.
9020 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9022 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9023 pointers to constants.
9024 (font_parse_fcname): Remove unused vars.
9025 (font_delete_unmatched): Now static.
9026 (font_get_spec): Remove; unused.
9027 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9028 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9029 Rename or move locals to avoid shadowing.
9031 * fns.c (require_nesting_list, require_unwind): Now static.
9032 (Ffillarray): Rename locals to avoid shadowing.
9034 * floatfns.c (domain_error2): Define only if needed.
9035 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9037 * alloc.c (mark_backtrace): Move decl from here ...
9038 * lisp.h: ... to here, so that it can be checked.
9040 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9041 (Fdefvar): Rewrite so as not to use empty "else".
9042 (lisp_indirect_variable): Name an expression,
9043 to avoid gcc -Wbad-function-cast warning.
9044 (Fdefvar): Rename locals to avoid shadowing.
9046 * callint.c (quotify_arg, quotify_args): Now static.
9047 (Fcall_interactively): Rename locals to avoid shadowing.
9048 Use const pointer when appropriate.
9050 * lisp.h (get_system_name, get_operating_system_release):
9051 Move decls here, to check interfaces.
9052 * process.c (get_operating_system_release): Move decl to lisp.h.
9053 * xrdb.c (get_system_name): Likewise.
9054 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9055 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9056 some of which prompt warnings from gcc -Wbad-function-cast.
9057 (Fformat_time_string, Fencode_time, Finsert_char):
9058 (Ftranslate_region_internal, Fformat):
9059 Rename or remove local vars to avoid shadowing.
9060 (Ftranslate_region_internal): Mark var as initialized.
9062 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9065 * lisp.h (eassert): Check that the argument compiles, even if
9066 ENABLE_CHECKING is not defined.
9068 * data.c (Findirect_variable): Name an expression, to avoid
9069 gcc -Wbad-function-cast warning.
9070 (default_value, arithcompare, arith_driver, arith_error): Now static.
9071 (store_symval_forwarding): Rename local to avoid shadowing.
9072 (Fmake_variable_buffer_local, Fmake_local_variable):
9073 Mark variables as initialized.
9074 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9076 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9077 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9078 Rename locals to avoid shadowing.
9079 (mark_stack): Move local variables into the #ifdef region where
9081 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9082 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9084 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9085 (GC_STRING_CHARS): Remove; not used.
9086 (Fmemory_limit): Cast sbrk's returned value to char *.
9088 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9089 avoids undefined behavior in theory.
9091 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9093 Use functions, not macros, for up- and down-casing (Bug#8254).
9094 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9095 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9096 to use the following functions instead of these macros.
9097 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9098 EMACS_INT, since callers assume the returned value fits in int.
9099 (upcase1): Likewise, for UPCASE_TABLE.
9100 (uppercasep, lowercasep, upcase): New static inline functions.
9101 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9102 the race-condition problem in the old DOWNCASE.
9104 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9105 Rename locals to avoid shadowing.
9106 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9107 (regex_compile, re_search_2, re_match_2_internal):
9108 Remove unused local vars.
9109 (FREE_VAR): Rewrite so as not to use empty "else",
9110 which gcc can warn about.
9111 (regex_compile, re_match_2_internal): Mark locals as initialized.
9112 (RETALLOC_IF): Define only if needed.
9113 (WORDCHAR_P): Likewise. This one is never needed, but is used
9114 only in a comment talking about a compiler bug, so put inside
9115 the #if 0 of that comment.
9116 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9117 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9120 * search.c (boyer_moore): Rename locals to avoid shadowing.
9121 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9122 (PREV_CHAR_BOUNDARY): Likewise.
9124 * search.c (simple_search): Remove unused var.
9126 * dired.c (compile_pattern): Move decl from here ...
9127 * lisp.h: ... to here, so that it can be checked.
9128 (struct re_registers): New forward decl.
9130 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9132 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9134 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9135 Rename locals to avoid shadowing.
9136 (Fvertical_motion): Mark locals as initialized.
9138 * casefiddle.c (casify_object, casify_region): Now static.
9139 (casify_region): Mark local as initialized.
9141 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9143 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9144 New macros, so that the caller can use some names other than
9145 gcpro1, gcpro2, etc.
9146 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9148 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9149 argument, for consistency with GCPRO2_VAR, etc: it is now the
9150 prefix of the variable, not the variable itself. All uses
9152 * dired.c (directory_files_internal, file_name_completion):
9153 Rename locals to avoid shadowing.
9155 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9156 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9157 dired.c's scmp function, had undefined behavior.
9158 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9159 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9160 * buffer.h: ... to here, because these macros use current_buffer,
9161 and the new implementation with inline functions needs to have
9162 current_buffer in scope now, rather than later when the macros
9164 (downcase, upcase1): New static inline functions.
9165 (DOWNCASE, UPCASE1): Reimplement using these functions.
9166 This avoids undefined behavior in expressions like
9167 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9168 from race conditions in accessing the global variables
9169 case_temp1 and case_temp2.
9170 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9171 * lisp.h (case_temp1, case_temp2): Remove their decls.
9172 * character.h (ASCII_CHAR_P): Move from here ...
9173 * lisp.h: ... to here, so that the inline functions mentioned
9176 * dired.c (directory_files_internal_unwind): Now static.
9178 * fileio.c (file_name_as_directory, directory_file_name):
9179 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9181 (file_name_as_directory): Use const pointers when appropriate.
9182 (Fexpand_file_name): Likewise. In particular, newdir might
9183 point at constant storage, so make it a const pointer.
9184 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9185 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9187 (Fset_file_times, Finsert_file_contents, auto_save_error):
9188 Rename locals to avoid shadowing.
9190 * minibuf.c (choose_minibuf_frame_1): Now static.
9191 (Ftry_completion, Fall_completions): Rename or remove locals
9194 * marker.c (bytepos_to_charpos): Remove; unused.
9196 * lisp.h (verify_bytepos, count_markers): New decls,
9197 so that gcc does not warn that these functions aren't declared.
9199 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9200 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9201 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9202 (copy_text): Remove unused local var.
9204 * filelock.c (within_one_second): Now static.
9205 (lock_file_1): Rename local to avoid shadowing.
9207 * buffer.c (fix_overlays_before): Mark locals as initialized.
9208 (fix_start_end_in_overlays): Likewise. This function should be
9209 simplified by using pointers-to-pointers, but that's a different
9211 (switch_to_buffer_1): Now static.
9212 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9213 (report_overlay_modification): Rename locals to avoid shadowing.
9215 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9216 Fix pointer signedness issue.
9217 (sys_subshell): Mark local as volatile if checking for lint,
9218 to suppress a gcc -Wclobbered warning that does not seem to be right.
9219 (MAXPATHLEN): Define only if needed.
9221 * process.c (serial_open, serial_configure): Move decls from here ...
9222 * systty.h: ... to here, so that they can be checked.
9224 * fns.c (get_random, seed_random): Move extern decls from here ...
9225 * lisp.h: ... to here, so that they can be checked.
9227 * sysdep.c (reset_io): Now static.
9228 (wait_for_termination_signal): Remove; unused.
9230 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9231 (copy_keymap_item, append_key, push_text_char_description):
9233 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9234 (DENSE_TABLE_SIZE): Remove; unused.
9235 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9236 (describe_map_tree):
9237 Rename locals to avoid shadowing.
9239 * keyboard.c: Declare functions static if they are not used elsewhere.
9240 (echo_char, echo_dash, cmd_error, top_level_2):
9241 (poll_for_input, handle_async_input): Now static.
9242 (read_char, kbd_buffer_get_event, make_lispy_position):
9243 (make_lispy_event, make_lispy_movement, apply_modifiers):
9244 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9245 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9246 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9247 (read_key_sequence, read_char): Mark locals as initialized.
9248 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9250 * keyboard.h (make_ctrl_char): New decl.
9251 (mark_kboards): Move decl here ...
9252 * alloc.c (mark_kboards): ... from here.
9254 * lisp.h (force_auto_save_soon): New decl.
9256 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9257 (DEFINE_DUMMY_FUNCTION): New macro.
9258 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9260 (main): Add casts to avoid warnings
9261 if GCC considers string literals to be constants.
9263 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9265 * dbusbind.c: Pointer signedness fixes.
9266 (xd_signature, xd_append_arg, xd_initialize):
9267 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9268 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9269 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9270 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9272 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9273 if GCC considers string literals to be constants.
9274 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9276 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9278 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9279 (print_preprocess, print_object): New macro to fix last change.
9281 * print.c (print_preprocess): Don't forget font objects.
9283 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9285 * emacs.c (USAGE3): Doc fixes.
9287 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9289 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9292 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9294 * lisp.h (VWindow_system, Qfile_name_history):
9295 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9296 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9297 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9299 * w32select.c: Don't #include "keyboard.h".
9300 (run_protected): Add extern declaration for waiting_for_input.
9302 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9303 * w32console.c (detect_input_pending, read_input_pending)
9304 (encode_terminal_code):
9305 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9306 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9307 (w32_system_caret_y, Qfile_name_history):
9308 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9309 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9310 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9311 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9312 * w32proc.c (Qlocal, report_file_error):
9313 * w32term.c (Vwindow_system, updating_frame):
9314 * w32uniscribe.c (initialized, uniscribe_font_driver):
9315 Remove unneeded extern declarations.
9317 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9319 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9321 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9323 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9324 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9325 These macros can no longer be used for assignment.
9327 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9328 Assign struct members directly, instead of using BUF_BEGV etc.
9329 (record_buffer_markers, fetch_buffer_markers): New functions for
9330 recording and fetching special buffer markers.
9331 (set_buffer_internal_1, set_buffer_temp): Use them.
9333 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9335 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9337 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9338 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9340 * xdisp.c (hscroll_window_tree):
9341 (reconsider_clip_changes): Use PT instead of BUF_PT.
9343 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9345 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9346 $(EMACS_ROOT)/lib/intprops.h.
9348 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9350 Fix more problems found by GCC 4.5.2's static checks.
9352 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9353 to unsigned char * to avoid compiler diagnostic.
9354 (xg_free_frame_widgets): Make it clear that a local variable is
9355 needed only if USE_GTK_TOOLTIP.
9356 (gdk_window_get_screen): Make it clear that this macro is needed
9357 only if USE_GTK_TOOLTIP.
9358 (int_gtk_range_get_value): New function, which avoids a diagnostic
9359 from gcc -Wbad-function-cast.
9360 (xg_set_toolkit_scroll_bar_thumb): Use it.
9361 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9362 diagnostic from gcc -Wbad-function-cast.
9363 (get_utf8_string, xg_get_file_with_chooser):
9364 Rename locals to avoid shadowing.
9365 (create_dialog): Move locals to avoid shadowing.
9367 * xgselect.c (xg_select): Remove unused var.
9369 * image.c (four_corners_best): Mark locals as initialized.
9370 (gif_load): Initialize transparent_p to zero (Bug#8238).
9371 Mark another local as initialized.
9372 (my_png_error, my_error_exit): Mark with NO_RETURN.
9374 * image.c (clear_image_cache): Now static.
9375 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9376 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9377 (x_edge_detection): Remove unnecessary cast that
9378 gcc -Wbad-function-cast diagnoses.
9379 (gif_load): Fix pointer signedness.
9380 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9381 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9383 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9385 Improve quality of tests for time stamp overflow.
9386 For example, without this patch (encode-time 0 0 0 1 1
9387 1152921504606846976) returns the obviously-bogus value (-948597
9388 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9389 reports time overflow. See
9390 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9391 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9392 * editfns.c: Include limits.h and intprops.h.
9393 (TIME_T_MIN, TIME_T_MAX): New macros.
9394 (time_overflow): Move earlier, to before first use.
9395 (hi_time, lo_time): New functions, for an accurate test for
9397 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9398 (Fget_internal_run_time): Don't assume time_t fits in int.
9399 (make_time): Use list2 instead of Fcons twice.
9400 (Fdecode_time): More accurate test for out-of-range times.
9401 (check_tm_member): New function.
9402 (Fencode_time): Use it, to test for out-of-range times.
9403 (lisp_time_argument): Don't rely on undefined left-shift and
9404 right-shift behavior when checking for time stamp overflow.
9406 * editfns.c (time_overflow): New function, refactoring common code.
9407 (Fformat_time_string, Fdecode_time, Fencode_time):
9408 (Fcurrent_time_string): Use it.
9410 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9411 * dired.c (make_time): Move to ...
9412 * editfns.c (make_time): ... here.
9413 * systime.h: Note the move.
9415 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9417 * fringe.c (update_window_fringes): Remove unused variables.
9419 * unexmacosx.c (copy_data_segment): Also copy __got section.
9422 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9424 * termcap.c [MSDOS]: Include "msdos.h".
9425 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9426 Constify `char *' arguments and their references according to
9427 prototypes in tparam.h.
9429 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9431 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9432 Adapt all references accordingly.
9434 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9436 2011-03-11 Tom Tromey <tromey@redhat.com>
9438 * buffer.c (syms_of_buffer): Remove obsolete comment.
9440 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9442 * termhooks.h (encode_terminal_code): Declare prototype.
9444 * msdos.c (encode_terminal_code): Don't declare prototype.
9446 * term.c (encode_terminal_code): Now external again, used by
9447 w32console.c and msdos.c.
9449 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9450 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9452 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9454 Fix some minor problems found by GCC 4.5.2's static checks.
9456 * fringe.c (update_window_fringes): Mark locals as initialized
9458 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9460 * alloc.c (mark_fringe_data): Move decl from here ...
9461 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9462 to check its interface.
9463 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9465 * fontset.c (free_realized_fontset): Now static.
9466 (Fset_fontset_font): Rename local to avoid shadowing.
9467 (fontset_font): Mark local as initialized.
9468 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9470 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9472 * xselect.c (x_disown_buffer_selections): Remove; not used.
9473 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9474 (x_own_selection, Fx_disown_selection_internal): Rename locals
9476 (x_handle_dnd_message): Remove local to avoid shadowing.
9478 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9479 so that the caller can use some name other than gcpro1.
9480 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9481 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9482 (Fx_backspace_delete_keys_p):
9483 Use them to avoid shadowing, and rename vars to avoid shadowing.
9484 (x_decode_color, x_set_name, x_window): Now static.
9485 (Fx_create_frame): Add braces to silence GCC warning.
9486 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9487 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9488 Remove unused locals.
9489 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9490 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9491 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9494 * xterm.h (x_mouse_leave): New decl.
9496 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9497 Remove unused functions.
9498 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9499 (x_calc_absolute_position): Now static.
9500 (XTread_socket): Don't define label "out" unless it's used.
9501 Don't declare local "event" unless it's used.
9502 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9503 unless they are used.
9504 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9505 (x_fatal_error_signal): Remove; not used.
9506 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9507 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9508 (x_error_catcher, x_connection_closed, x_error_handler):
9509 (x_error_quitter, xembed_send_message, x_iconify_frame):
9510 (my_log_handler): Rename locals to avoid shadowing.
9511 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9512 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9514 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9515 Rename or move locals to avoid shadowing.
9516 (tty_defined_color, merge_face_heights): Now static.
9517 (free_realized_faces_for_fontset): Remove; not used.
9518 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9519 does not deduce is never used uninitialized.
9520 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9521 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9523 * terminal.c (store_terminal_param): Now static.
9525 * xmenu.c (menu_highlight_callback): Now static.
9526 (set_frame_menubar): Remove unused local.
9527 (xmenu_show): Rename parameter to avoid shadowing.
9528 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9529 since they might point to immutable storage.
9530 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9531 since it's unused otherwise.
9533 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9534 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9535 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9536 avoids a gcc -Wuninitialized diagnostic.
9537 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9538 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9539 does not deduce are never used uninitialized.
9541 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9543 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9544 * window.c (window_loop, size_window):
9545 (run_window_configuration_change_hook, enlarge_window): Likewise.
9547 * window.c (display_buffer): Now static.
9548 (size_window): Mark variables that gcc -Wuninitialized
9549 does not deduce are never used uninitialized.
9550 * window.h (check_all_windows): New decl, to forestall
9551 gcc -Wmissing-prototypes diagnostic.
9552 * dispextern.h (bidi_dump_cached_states): Likewise.
9554 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9556 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9558 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9559 and to avoid gcc -Wuninitialized warning.
9560 (load_charset_map): Mark variables that gcc -Wuninitialized
9561 does not deduce are never used uninitialized.
9562 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9564 * coding.c (coding_set_source, coding_set_destination):
9565 Use "else { /* comment */ }" rather than "else /* comment */;"
9566 for clarity, and to avoid gcc -Wempty-body warning.
9567 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9568 a block, when the outer 'i' will do.
9569 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9570 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9571 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9572 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9573 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9574 Rename locals to avoid shadowing.
9575 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9576 * coding.c (emacs_mule_char, encode_invocation_designation):
9577 Now static, since they're not used elsewhere.
9578 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9579 (decode_coding_object, encode_coding_object, detect_coding_system):
9580 (decode_coding_emacs_mule): Mark variables that gcc
9581 -Wuninitialized does not deduce are never used uninitialized.
9582 (detect_coding_iso_2022): Initialize a local variable that might
9583 be used uninitialized. Leave a FIXME because it's not clear that
9584 this initialization is needed. (Bug#8211)
9585 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9586 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9587 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9588 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9589 Remove unused macros.
9591 * category.c (hash_get_category_set): Remove unused local var.
9592 (copy_category_table): Now static, since it's not used elsewhere.
9593 * character.c (string_count_byte8): Likewise.
9595 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9596 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9598 * chartab.c (copy_sub_char_table): Now static, since it's not used
9600 (sub_char_table_ref_and_range, char_table_ref_and_range):
9601 Rename locals to avoid shadowing.
9602 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9604 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9605 (BIDI_BOB): Remove unused macro.
9607 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9608 deduce are never used uninitialized.
9609 * term.c (encode_terminal_code): Likewise.
9611 * term.c (encode_terminal_code): Now static. Remove unused local.
9613 * tparam.h: New file.
9614 * term.c, tparam.h: Include it.
9615 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9616 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9617 Move these decls to tparam.h, and make them agree with what
9618 is actually in tparam.c. The previous trick of using incompatible
9619 decls in different modules does not conform to the C standard.
9620 All callers of tparam changed to use tparam's actual API.
9621 * tparam.c (tparam1, tparam, tgoto):
9622 Use const pointers where appropriate.
9624 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9625 * cm.h (struct cm): Likewise.
9626 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9627 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9628 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9629 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9630 (turn_on_face, init_tty): Likewise.
9631 * termchar.h (struct tty_display_info): Likewise.
9633 * term.c (term_mouse_position): Rename local to avoid shadowing.
9635 * alloc.c (mark_ttys): Move decl from here ...
9636 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9638 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9640 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9642 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9644 * search.c (compile_pattern_1): Remove argument regp, unused since
9645 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9646 (compile_pattern): Don't pass it.
9648 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9650 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9651 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9653 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9655 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9657 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9658 gdk_window_get_screen, gdk_window_get_geometry,
9659 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9660 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9661 (xg_get_pixbuf_from_pixmap): New function.
9662 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9663 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9664 Call xg_get_pixbuf_from_pixmap instead of
9665 gdk_pixbuf_get_from_drawable.
9666 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9667 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9668 (xg_check_special_colors): Use GtkStyleContext and its functions
9670 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9671 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9672 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9673 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9674 Call gtk_widget_get_preferred_size.
9675 (xg_frame_resized): gdk_window_get_geometry only takes 5
9677 (xg_win_to_widget, xg_event_is_for_menubar):
9678 Call gdk_x11_window_lookup_for_display.
9679 (xg_set_widget_bg): New function.
9680 (delete_cb): New function.
9681 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9682 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9683 (xg_set_background_color): Call xg_set_widget_bg.
9684 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9685 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9686 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9687 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9689 (update_frame_tool_bar): Call gtk_widget_hide.
9690 (xg_initialize): Use GDK_KEY_g.
9692 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9694 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9696 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9697 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9698 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9700 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9702 * w32xfns.c (select_palette): Check success of RealizePalette against
9703 GDI_ERROR, not zero.
9705 See ChangeLog.11 for earlier changes.
9711 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9713 This file is part of GNU Emacs.
9715 GNU Emacs is free software: you can redistribute it and/or modify
9716 it under the terms of the GNU General Public License as published by
9717 the Free Software Foundation, either version 3 of the License, or
9718 (at your option) any later version.
9720 GNU Emacs is distributed in the hope that it will be useful,
9721 but WITHOUT ANY WARRANTY; without even the implied warranty of
9722 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9723 GNU General Public License for more details.
9725 You should have received a copy of the GNU General Public License
9726 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.