1 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
3 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
4 This is needed if max-image-size is a floating-point number.
6 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8 * print.c (print_object): Print empty symbol as ##.
10 * lread.c (read1): Read ## as empty symbol.
12 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
14 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
15 setting frame foreground color (Bug#9175).
16 (x_set_background_color): Likewise.
18 * nsmenu.m (-setText): Size tooltip dimensions precisely to
20 (EmacsTooltip -init): Remove bezels and add shadows to
23 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
24 or scroll bar (Bug#8470).
26 * nsfont.m (nsfont_open): Remove assignment to voffset and
27 unnecessary vars hshink, expand, hd, full_height, min_height.
28 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
30 * nsterm.h (nsfont_info): Remove voffset field.
32 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
34 Implement strike-through and overline on NextStep (Bug#8863).
36 * nsfont.m (nsfont_open): Use underline position provided by font,
37 instead of hard-coded value of 2.
38 (nsfont_draw): Call ns_draw_text_decoration instead.
40 * nsterm.h: Add declaration for ns_draw_text_decoration.
42 * nsterm.m (ns_draw_text_decoration): New function for drawing
43 underline, overline, and strike-through.
44 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
45 ns_draw_text_decoration. Change treatment of cursor drawing to
46 accomodate underlining, etc.
48 2011-07-28 Eli Zaretskii <eliz@gnu.org>
50 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
53 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
55 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
56 Without this fix, if a signal arrives just after memory fills up,
57 'malloc' might be invoked reentrantly.
59 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
60 In other words, assume that every image size is allowed, on non-X
61 hosts. This assumption is probably wrong, but it lets Emacs compile.
63 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
65 * regex.c (re_iswctype): Convert return values to boolean.
67 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
69 * xdisp.c (compute_display_string_pos): Don't use cached display
70 string position if the buffer had its restriction changed.
73 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
75 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
77 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
79 Integer signedness and overflow and related fixes. (Bug#9079)
81 * bidi.c: Integer size and overflow fixes.
82 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
83 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
84 (bidi_cache_find_level_change, bidi_cache_ensure_space)
85 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
86 (bidi_find_other_level_edge):
87 Use ptrdiff_t instead of EMACS_INT where either will do.
88 This works better on 32-bit hosts configured --with-wide-int.
89 (bidi_cache_ensure_space): Check for size-calculation overflow.
90 Use % rather than repeated addition, for better worst-case speed.
91 Don't set bidi_cache_size until after xrealloc returns, because it
93 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
94 (bidi_cache_ensure_space): Also check that the bidi cache size
95 does not exceed that of the largest Lisp string or buffer. See Eli
96 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
98 * alloc.c (__malloc_size_t): Remove.
99 All uses replaced by size_t. See Andreas Schwab's note
100 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
102 * image.c: Improve checking for integer overflow.
103 (check_image_size): Assume that f is nonnull, since
104 it is always nonnull in practice. This is one less thing to
105 worry about when checking for integer overflow later.
106 (x_check_image_size): New function, which checks for integer
107 overflow issues inside X.
108 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
109 This removes the need for a memory_full check.
110 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
111 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
112 (xbm_read_bitmap_data): Change locals back to 'int', since
113 their values must fit in 'int'.
114 (xpm_load_image, png_load, tiff_load):
115 Invoke x_create_x_image_and_pixmap earlier,
116 to avoid much needless work if the image is too large.
117 (tiff_load): Treat overly large images as if
118 x_create_x_image_and_pixmap failed, not as malloc failures.
119 (gs_load): Use x_check_image_size.
121 * gtkutil.c: Omit integer casts.
122 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
123 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
125 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
127 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
128 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
129 would wrongly return t on a 64-bit host.
131 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
132 The plain *_OVERFLOW macros run afoul of GCC bug 49705
133 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
134 and therefore cause GCC to emit a bogus diagnostic in some cases.
136 * image.c: Integer signedness and overflow and related fixes.
137 This is not an exhaustive set of fixes, but it's time to
138 record what I've got.
139 (lookup_pixel_color, check_image_size): Remove redundant decls.
140 (check_image_size): Don't assume that arbitrary EMACS_INT values
141 fit in 'int', or that arbitrary 'double' values fit in 'int'.
142 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
143 (tiff_load, imagemagick_load_image):
144 Check for overflow in size calculations.
145 (x_create_x_image_and_pixmap): Remove unnecessary test for
146 xmalloc returning NULL; that can't happen.
147 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
148 (xpm_color_bucket): Use better integer hashing function.
149 (xpm_cache_color): Don't possibly over-allocate memory.
150 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
152 Use ptrdiff_t, not int or size_t, to record sizes.
153 (png_load): Don't assume values greater than 2**31 fit in 'int'.
154 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
155 either works, as we prefer signed integers.
156 (tiff_read_from_memory, tiff_write_from_memory):
157 Return tsize_t, not size_t, since that's what the TIFF API wants.
158 (tiff_read_from_memory): Don't fail simply because the read would
159 go past EOF; instead, return a short read.
160 (tiff_load): Omit no-longer-needed casts.
161 (Fimagemagick_types): Don't assume size fits into 'int'.
163 Improve hashing quality when configured --with-wide-int.
164 * fns.c (hash_string): New function, taken from sxhash_string.
165 Do not discard information about ASCII character case; this
166 discarding is no longer needed.
167 (sxhash-string): Use it. Change sig to match it. Caller changed.
168 * lisp.h: Declare it.
169 * lread.c (hash_string): Remove, since we now use fns.c's version.
170 The fns.c version returns a wider integer if --with-wide-int is
171 specified, so this should help the quality of the hashing a bit.
173 * emacs.c: Integer overflow minor fix.
174 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
175 Define only if GNU_LINUX.
176 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
178 * dispnew.c: Integer signedness and overflow fixes.
179 Remove unnecessary forward decls, that were a maintenance hassle.
180 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
182 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
183 (scrolling_window): Use ptrdiff_t, not int, for byte count.
184 (prepare_desired_row, line_draw_cost):
185 Use int, not unsigned, where either works.
186 (save_current_matrix, restore_current_matrix):
187 Use ptrdiff_t, not size_t, where either works.
188 (init_display): Check for overflow more accurately, and without
189 relying on undefined behavior.
191 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
192 Remove, replacing with the new symbols in lisp.h. All uses changed.
193 * fileio.c (make_temp_name):
194 * filelock.c (lock_file_1, lock_file):
195 * xdisp.c (message_dolog):
196 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
197 Use pMd etc. instead.
198 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
199 replacing the pWIDE etc. symbols removed from editfns.c.
201 * keyboard.h (num_input_events): Now uintmax_t.
202 This is (very slightly) less likely to mess up due to wraparound.
205 * buffer.c: Integer signedness fixes.
206 (alloc_buffer_text, enlarge_buffer_text):
207 Use ptrdiff_t rather than size_t when either will do, as we prefer
210 * alloc.c: Integer signedness and overflow fixes.
211 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
212 (__malloc_size_t): Default to size_t, not to int.
213 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
214 (Fgarbage_collect, mark_object_loop_halt, mark_object):
215 Prefer ptrdiff_t to size_t when either would do, as we prefer
217 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
218 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
219 Now const. Initialize with values that are in range even if char
221 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
222 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
223 These functions do the right thing with sizes > 2**32.
224 (check_depth): Now ptrdiff_t, not int.
225 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
226 Adjust to new way of storing sizes. Check for size overflow bugs
228 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
229 slightly wrong anyway, as it missed one instance of
230 XMALLOC_OVERRUN_CHECK_OVERHEAD.
231 (refill_memory_reserve): Omit needless cast to size_t.
232 (mark_object_loop_halt): Mark as externally visible.
234 * xselect.c: Integer signedness and overflow fixes.
235 (Fx_register_dnd_atom, x_handle_dnd_message):
236 Use ptrdiff_t, not size_t, since we prefer signed.
237 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
238 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
239 x_dnd_atoms_size and x_dnd_atoms_length.
241 * doprnt.c: Prefer signed to unsigned when either works.
245 * xdisp.c (vmessage):
246 Use ptrdiff_t, not size_t, when using or implementing doprnt,
247 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
248 prefer signed arithmetic to avoid comparison confusion.
249 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
252 Assume freestanding C89 headers, string.h, stdlib.h.
253 * data.c, doprnt.c, floatfns.c, print.c:
254 Include float.h unconditionally.
255 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
256 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
257 * regex.c: Likewise for stddef.h, string.h.
258 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
259 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
260 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
261 (STDC_HEADERS): Remove obsolete defines.
262 * sysdep.c: Include limits.h unconditionally.
264 Assume support for memcmp, memcpy, memmove, memset.
265 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
266 * regex.c (memcmp, memcpy):
267 Remove; we assume C89 now.
269 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
270 (__malloc_safe_bcopy): Remove; no longer needed.
272 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
273 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
274 well either way, and we prefer signed to unsigned.
276 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
278 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
279 closes the connection while we're reading (bug#9182).
281 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
283 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
284 are specified (Bug#9168).
286 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
288 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
289 Found by GCC static checking and --with-wide-int on a 32-bit host.
291 2011-07-25 Eli Zaretskii <eliz@gnu.org>
293 * xdisp.c (compute_display_string_pos): Fix logic of caching
294 previous display string position. Initialize cached_prev_pos to
295 -1. Fixes slow-down at the beginning of a buffer.
297 2011-07-24 Eli Zaretskii <eliz@gnu.org>
299 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
300 for attrs[LFACE_FONTSET_INDEX].
302 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
304 * xml.c (parse_region): Remove unused local
305 that was recently introduced.
307 2011-07-23 Eli Zaretskii <eliz@gnu.org>
309 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
310 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
312 * xdisp.c (move_it_in_display_line_to): Record the best matching
313 position for TO_CHARPOS while scanning the line, and restore it on
314 exit if none of the characters scanned was an exact match. Fixes
315 vertical-motion and pos-visible-in-window-p under bidi redisplay
316 when exact match is impossible due to invisible text, and the
319 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
321 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
324 2011-07-22 Eli Zaretskii <eliz@gnu.org>
326 Fix a significant slow-down of cursor motion with C-n, C-p,
327 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
328 auto-repeat under bidi redisplay in fontified buffers.
329 * xdisp.c (compute_stop_pos_backwards): New function.
330 (next_element_from_buffer): Call compute_stop_pos_backwards to
331 find a suitable prev_stop when we find ourselves before
333 (reseat): Don't look for prev_stop, as that could mean a very long
335 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
336 <cached_disp_overlay_modiff>: Cache for last found display string
338 (compute_display_string_pos): Return the cached position if asked
339 about the same buffer in the same area of character positions, and
340 the buffer wasn't changed since the time the display string
343 2011-07-22 Eli Zaretskii <eliz@gnu.org>
345 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
346 is an integer, which is important for empty lines. (Bug#9149)
348 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
350 * frame.c (Fmodify_frame_parameters): In tty case, update the
351 default face if necessary (Bug#4238).
353 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
355 * editfns.c (Fstring_to_char): No need to explain what a character
356 is in the docstring (Bug#6576).
358 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
360 * xml.c (parse_region): Make sure we always return a tree.
362 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
364 * xml.c (parse_region): If a document contains only comments,
367 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
369 * xml.c (make_dom): Return comments, too.
371 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
374 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
375 and the surrounding thread.
376 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
377 rather than fgets, and retry after EINTR. Otherwise, 'emacs
378 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
380 * s/openbsd.h (BROKEN_SIGIO): Define.
381 * unexelf.c (unexec) [__OpenBSD__]:
382 Don't update the .mdebug section of the Alpha COFF symbol table.
384 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
386 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
389 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
391 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
392 This fixes some race conditions on the permissions of any newly
395 * alloc.c (valid_pointer_p): Use pipe, not open.
396 This fixes some permissions issues when debugging.
398 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
399 If fchown fails to set both uid and gid, try to set just gid,
400 as that is sometimes allowed. Adjust the file's mode to eliminate
401 setuid or setgid bits that are inappropriate if fchown fails.
403 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
405 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
406 to compare Lisp_Objects.
407 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
408 global_gnutls_log_level, don't mistake it for a Lisp_Object.
409 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
411 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
413 * lread.c (read_integer): Unread even EOF character.
414 (read1): Likewise. Properly record start position of symbol.
416 * lread.c (read1): Read `#:' as empty uninterned symbol if no
417 symbol character follows.
419 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
421 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
422 This works around a problem with the previous change to Fcopy_file.
423 Recent glibc declares fchown with __attribute__((warn_unused_result)),
424 and without this change, GCC might complain about discarding
425 fchown's return value.
427 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
429 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
431 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
433 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
435 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
437 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
438 it's used from the C level.
440 * process.c: Use the same condition for POLL_FOR_INPUT in both
441 keyboard.c and process.c (bug#1858).
443 2011-07-09 Lawrence Mitchell <wence@gmx.li>
445 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
446 (Fgnutls_boot): Use it.
448 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
450 * doc.c (Fsubstitute_command_keys): Revert last change.
452 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
454 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
455 quotes the next character, and doesn't affect other longer
456 sequences (bug#8935).
458 * lread.c (syms_of_lread): Clarify that is isn't only
459 `eval-buffer' and `eval-defun' that's affected by
460 `lexical-binding' (bug#8460).
462 2011-07-15 Eli Zaretskii <eliz@gnu.org>
464 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
465 bidi redisplay when a line includes both an image and is
468 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
470 Fix minor problems found by static checking.
471 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
472 (elsz): Now a signed constant, not a size_t var. We prefer signed
473 types to unsigned, to avoid integer comparison confusion. Without
474 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
475 "cannot optimize loop, the loop counter may overflow", a symptom
477 * indent.c (Fvertical_motion): Mark locals as initialized.
478 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
480 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
482 * search.c (Fre_search_backward): Mention `case-fold-search' in
483 all the re_search_* functions (bug#8138).
485 * keyboard.c (Fopen_dribble_file): Document when the file is
488 2011-07-14 Eli Zaretskii <eliz@gnu.org>
490 * bidi.c (bidi_dump_cached_states): Fix format of displaying
493 Support bidi reordering of display and overlay strings.
494 * xdisp.c (compute_display_string_pos)
495 (compute_display_string_end): Accept additional argument STRING.
496 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
497 (reseat_to_string): Initialize bidi_it->string.s and
498 bidi_it->string.schars.
499 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
500 NULL (avoids a crash in bidi_paragraph_init). Initialize
502 (init_iterator): Call bidi_init_it only of a valid
503 buffer position was specified. Initialize paragraph_embedding to
505 (reseat_to_string): Initialize the bidi iterator.
506 (display_string): If we need to ignore text properties of
507 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
508 original value of -1 will not work with bidi.)
509 (compute_display_string_pos): First arg is now struct
510 `text_pos *'; all callers changed. Support display properties on
512 (compute_display_string_end): Support display properties on Lisp
514 (init_iterator, reseat_1, reseat_to_string): Initialize the
515 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
516 when iterating on a string not from display properties).
517 (compute_display_string_pos, compute_display_string_end): Fix
518 calculation of the object to scan. Fixes an error when using
520 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
521 base_level_stop; instead, set base_level_stop to BEGV. Fixes
522 crashes in vertical-motion.
523 (next_element_from_buffer): Improve commentary for when
524 the iterator is before prev_stop.
525 (init_iterator): Initialize bidi_p from the default value of
526 bidi-display-reordering, not from buffer-local value. Use the
527 buffer-local value only if initializing for buffer iteration.
528 (handle_invisible_prop): Support invisible properties on strings
529 that are being bidi-reordered.
530 (set_iterator_to_next): Support bidi reordering of C strings and
532 (next_element_from_string): Support bidi reordering of Lisp
534 (handle_stop_backwards): Support Lisp strings as well.
535 (display_string): Support display of R2L glyph rows. Use
536 IT_STRING_CHARPOS when displaying from a Lisp string.
537 (init_iterator): Don't initialize it->bidi_p for strings
539 (reseat_to_string): Initialize it->bidi_p for strings here.
540 (next_element_from_string, next_element_from_c_string)
541 (next_element_from_buffer): Add xassert's for correspondence
542 between IT's object being iterated and it->bidi_it.string
544 (face_before_or_after_it_pos): Support bidi iteration.
545 (next_element_from_c_string): Handle the case of the first string
546 character that is not the first one in the visual order.
547 (get_visually_first_element): New function, refactored from common
548 parts of next_element_from_buffer, next_element_from_string, and
549 next_element_from_c_string.
550 (tool_bar_lines_needed, redisplay_tool_bar)
551 (display_menu_bar): Force left-to-right direction. Add a FIXME
552 comment for making that be controlled by a user option.
553 (push_it, pop_it): Save and restore the state of the
554 bidi iterator. Save and restore the bidi_p flag.
555 (pop_it): Iterate out of display property for string iteration as
557 (iterate_out_of_display_property): Support iteration over strings.
558 (handle_single_display_spec): Set up it->bidi_it for iteration
559 over a display string, and call bidi_init_it.
560 (handle_single_display_spec, next_overlay_string)
561 (get_overlay_strings_1, push_display_prop): Set up the bidi
562 iterator for displaying display or overlay strings.
563 (forward_to_next_line_start): Don't use the shortcut if
565 (back_to_previous_visible_line_start): If handle_display_prop
566 pushed the iterator stack, restore the internal state of the bidi
567 iterator by calling bidi_pop_it same number of times.
568 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
569 and we are bidi-iterating, don't decrement the iterator position;
570 instead, set the first_elt flag in the bidi iterator, to produce
572 (reseat_1): Remove redundant setting of string_from_display_prop_p.
573 (push_display_prop): xassert that we are iterating a buffer.
574 (push_it, pop_it): Save and restore paragraph_embedding member.
575 (handle_single_display_spec, next_overlay_string)
576 (get_overlay_strings_1, reseat_1, reseat_to_string)
577 (push_display_prop): Set up the `unibyte' member of bidi_it.string
578 correctly. Don't assume unibyte strings are not bidi-reordered.
579 (compute_display_string_pos)
580 (compute_display_string_end): Fix handling the case of C string.
581 (push_it, pop_it): Save and restore from_disp_prop_p.
582 (handle_single_display_spec, push_display_prop): Set the
583 from_disp_prop_p flag.
584 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
585 (pop_it): Call iterate_out_of_display_property only if we are
586 popping after iteration over a string that came from a display
587 property. Fix a typo in popping stretch info. Add an assertion
588 for verifying that the iterator position is in sync with the bidi
590 (handle_single_display_spec, get_overlay_strings_1)
591 (push_display_prop): Fix initialization of paragraph direction for
592 string when that of the parent object is not yet determined.
593 (reseat_1): Call bidi_init_it to resync the bidi
594 iterator with IT's position. (Bug#7616)
595 (find_row_edges): If ROW->start.pos gives position
596 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
597 (handle_stop, back_to_previous_visible_line_start, reseat_1):
598 Reset the from_disp_prop_p flag.
599 (SAVE_IT, RESTORE_IT): New macros.
600 (pos_visible_p, face_before_or_after_it_pos)
601 (back_to_previous_visible_line_start)
602 (move_it_in_display_line_to, move_it_in_display_line)
603 (move_it_to, move_it_vertically_backward, move_it_by_lines)
604 (try_scrolling, redisplay_window, display_line): Use them when
605 saving a temporary copy of the iterator and restoring it back.
606 (back_to_previous_visible_line_start, reseat_1)
607 (init_iterator): Empty the bidi cache "stack".
608 (move_it_in_display_line_to): If iterator ended up at
609 EOL, but we never saw any buffer positions smaller than
610 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
611 motion in bidi-reordered lines.
612 (move_it_in_display_line_to): Record prev_method and prev_pos
613 immediately before the call to set_iterator_to_next. Fixes cursor
614 motion in bidi-reordered lines with stretch glyphs and strings
615 displayed in margins. (Bug#8133) (Bug#8867)
616 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
618 (pos_visible_p): Support positions in bidi-reordered lines. Save
619 and restore bidi cache.
621 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
622 (bidi_paragraph_info): Delete unused struct.
623 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
624 (bidi_cache_start): New variable.
625 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
627 (bidi_cache_fetch_state, bidi_cache_search)
628 (bidi_cache_find_level_change, bidi_cache_iterator_state)
629 (bidi_cache_find, bidi_peek_at_next_level)
630 (bidi_level_of_next_char, bidi_find_other_level_edge)
631 (bidi_move_to_visually_next): Compare cache index with
632 bidi_cache_start rather than with zero.
633 (bidi_fetch_char): Accept new argument STRING; all callers
634 changed. Support iteration over a string. Support strings with
635 display properties. Support unibyte strings. Fix the type of
636 `len' according to what STRING_CHAR_AND_LENGTH expects.
637 (bidi_paragraph_init, bidi_resolve_explicit_1)
638 (bidi_resolve_explicit, bidi_resolve_weak)
639 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
640 iteration over a string.
641 (bidi_set_sor_type, bidi_resolve_explicit_1)
642 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
643 can now be zero (for strings); special values 0 and -1 were
644 changed to -1 and -2, respectively.
645 (bidi_char_at_pos): New function.
646 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
647 Call it instead of FETCH_MULTIBYTE_CHAR.
648 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
649 initialized to valid values.
650 (bidi_init_it): Don't initialize charpos and bytepos with invalid
652 (bidi_level_of_next_char): Allow the sentinel "position" to pass
653 the test for valid cached positions. Fix the logic for looking up
654 the sentinel state in the cache. GCPRO the Lisp string we are
656 (bidi_push_it, bidi_pop_it): New functions.
657 (bidi_initialize): Initialize the bidi cache start stack pointer.
658 (bidi_cache_ensure_space): New function, refactored from part of
659 bidi_cache_iterator_state. Don't assume the required size is just
660 one BIDI_CACHE_CHUNK away.
661 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
662 (bidi_count_bytes, bidi_char_at_pos): New functions.
663 (bidi_cache_search): Don't assume bidi_cache_last_idx is
664 always valid if bidi_cache_idx is valid.
665 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
666 is valid if it's going to be used.
667 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
668 (bidi_cache_fetch_state, bidi_cache_search)
669 (bidi_cache_find_level_change, bidi_cache_ensure_space)
670 (bidi_cache_iterator_state, bidi_cache_find)
671 (bidi_find_other_level_edge, bidi_cache_start_stack): All
672 variables related to cache indices are now EMACS_INT.
674 * dispextern.h (struct bidi_string_data): New structure.
675 (struct bidi_it): New member `string'. Make flag members be 1-bit
676 fields, and put them last in the struct.
677 (compute_display_string_pos, compute_display_string_end): Update
679 (bidi_push_it, bidi_pop_it): Add prototypes.
680 (struct iterator_stack_entry): New members bidi_p,
681 paragraph_embedding, and from_disp_prop_p.
682 (struct it): Member bidi_p is now a bit field 1 bit wide.
683 (bidi_shelve_cache, bidi_unshelve_cache): Declare
686 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
687 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
688 and vector-like objects.
690 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
691 cache around display iteration.
693 * window.c (Fwindow_end, window_scroll_pixel_based)
694 (displayed_window_lines, Frecenter): Save and restore the bidi
695 cache around display iteration.
697 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
699 * editfns.c (Fdelete_region): Clarify the use of the named
700 parameters (bug#6788).
702 2011-07-14 Martin Rudalics <rudalics@gmx.at>
704 * indent.c (Fvertical_motion): Set and restore w->pointm when
705 saving and restoring the window's buffer (Bug#9006).
707 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
709 * editfns.c (Fstring_to_char): Clarify just what is returned
710 (bug#6576). Text by Eli Zaretskii.
712 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
714 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
716 2011-07-13 Eli Zaretskii <eliz@gnu.org>
718 * buffer.c (mmap_find): Fix a typo.
720 2011-07-13 Johan Bockgård <bojohan@gnu.org>
722 Fix execution of x selection hooks.
723 * xselect.c (Qx_lost_selection_functions)
724 (Qx_sent_selection_functions): New vars.
725 (syms_of_xselect): DEFSYM them.
726 (x_handle_selection_request): Pass Qx_sent_selection_functions
727 rather than Vx_sent_selection_functions to Frun_hook_with_args.
728 (x_handle_selection_clear,x_clear_frame_selections):
729 Pass Qx_lost_selection_functions rather than
730 Vx_lost_selection_functions to Frun_hook_with_args.
732 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
734 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
735 The old code sometimes used this field without initializing it.
737 * alloc.c (gc_sweep): Don't read past end of array.
738 In theory, the old code could also have corrupted Emacs internals,
739 though it'd be very unlikely.
741 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
743 * character.c (Fcharacterp): Don't advertise optional ignored
746 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
748 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
751 * window.c (Fset_window_start): Doc fix (bug#4199).
752 (Fset_window_hscroll): Ditto.
754 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
756 Fix minor new problems caught by GCC 4.6.1.
757 * term.c (init_tty): Remove unused local.
758 * xsettings.c (store_monospaced_changed): Define this function only
759 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
762 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
764 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
766 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
768 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
769 are the mini-buffer and the echo area (bug#3320).
771 * term.c (init_tty): Remove support for supdup, c10 and perq
772 terminals, which are no longer supported (bug#1482).
774 2011-07-10 Johan Bockgård <bojohan@gnu.org>
776 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
778 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
780 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
781 for non-popups (Bug#3642).
783 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
785 * alloc.c (reset_malloc_hooks): Protoize.
786 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
787 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
788 * cm.c (losecursor): Likewise.
789 * data.c (fmod): Likewise.
790 * dispnew.c (swap_glyphs_in_rows): Likewise.
791 * emacs.c (memory_warning_signal): Likewise.
792 * floatfns.c (float_error): Likewise.
793 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
794 (otf_open, font_otf_capability, generate_otf_features)
795 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
797 * image.c (pbm_read_file): Likewise.
798 * indent.c (string_display_width): Likewise.
799 * intervals.c (check_for_interval, search_for_interval)
800 (inc_interval_count, count_intervals, root_interval)
801 (adjust_intervals_for_insertion, make_new_interval): Likewise.
802 * lread.c (defalias): Likewise.
803 * ralloc.c (r_alloc_check): Likewise.
804 * regex.c (set_image_of_range_1, set_image_of_range)
805 (regex_grow_registers): Likewise.
806 * sysdep.c (strerror): Likewise.
807 * termcap.c (valid_filename_p, tprint, main): Likewise.
808 * tparam.c (main): Likewise.
809 * unexhp9k800.c (run_time_remap, save_data_space)
810 (update_file_ptrs, read_header, write_header, calculate_checksum)
811 (copy_file, copy_rest, display_header): Likewise.
812 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
814 * xdisp.c (check_it): Likewise.
815 * xfaces.c (register_color, unregister_color, unregister_colors):
817 * xfns.c (print_fontset_result): Likewise.
818 * xrdb.c (member, fatal, main): Likewise.
820 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
822 Fix minor problems found by static checking (Bug#9031).
823 * chartab.c (char_table_set_range, map_sub_char_table):
824 Remove unused locals.
825 (uniprop_table): Now static.
826 * composite.c (_work_char): Remove unused static var.
828 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
830 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
832 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
834 * gtkutil.c (qttip_cb): Remove code without function.
836 2011-07-09 Eli Zaretskii <eliz@gnu.org>
838 * w32.c (pthread_sigmask): New stub.
840 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
842 Use pthread_sigmask, not sigprocmask (Bug#9010).
843 sigprocmask is portable only for single-threaded applications, and
844 Emacs can be multi-threaded when it uses GTK.
845 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
847 * callproc.c (Fcall_process):
848 * process.c (create_process):
849 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
850 Use pthread_sigmask, not sigprocmask.
852 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
854 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
855 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
858 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
860 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
861 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
862 (xg_hide_tooltip): Fix comment.
864 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
865 in registerServicesMenuSendTypes.
866 (validRequestorForSendType): Don't check ns_return_types.
868 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
871 2011-07-08 Jason Rumney <jasonr@gnu.org>
873 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
874 frame struct members of non-existent frames (Bug#6284).
876 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
878 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
879 variable firstTime not needed on OSX >= 10.6.
880 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
881 >= 10.5. Use setKnobProportion, setDoubleValue.
883 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
884 (MAC_OS_X_VERSION_10_5): Define if not defined.
885 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
886 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
887 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
889 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
890 cString and lossyCString on OSX >= 10.4
892 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
893 sizeToFit on OSX >= 10.2.
895 * nsimage.m (allocInitFromFile): Don't use deprecated method
896 bestRepresentationForDevice on OSX >= 10.6.
898 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
901 * emacs.c: Declare unexec_init_emacs_zone.
903 * nsgui.h: Fix compiler warning about gnulib redefining verify.
905 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
907 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
908 on svcsMenu (Bug#8842).
910 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
912 (Fns_list_services): Just return Qnil on 10.6, code not working there.
914 * nsterm.m (QUTF8_STRING): Declare.
915 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
916 (validRequestorForSendType): Return type is (id).
917 Change indexOfObjectIdenticalTo to indexOfObject.
918 Check if we have local selection before returning self (Bug#8842).
919 (writeSelectionToPasteboard): Put local selection into paste board
920 if we have a local selection (Bug#8842).
921 (syms_of_nsterm): DEFSYM QUTF8_STRING.
923 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
924 (ns_get_local_selection): Declare.
926 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
928 * keymap.c (describe_map_tree): Don't insert a double newline at
929 the end of the buffer (bug#1169) and return whether we inserted
932 * callint.c (Fcall_interactively): Change "reading args" to
933 "providing args" to try to clarify what it does (bug#1010).
935 2011-07-07 Kenichi Handa <handa@m17n.org>
937 * composite.c (composition_compute_stop_pos): Ignore a static
938 composition starting before CHARPOS (Bug#8915).
940 * xdisp.c (handle_composition_prop): Likewise.
942 2011-07-07 Eli Zaretskii <eliz@gnu.org>
944 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
947 2011-07-07 Kenichi Handa <handa@m17n.org>
949 * character.h (unicode_category_t): New enum type.
951 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
952 (Qchar_code_property_table): New variable.
953 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
954 (UNIPROP_COMPRESSED_FORM_P): New macros.
955 (char_table_ascii): Uncompress the compressed values.
956 (sub_char_table_ref): New arg is_uniprop. Callers changed.
957 Uncompress the compressed values.
958 (sub_char_table_ref_and_range): Likewise.
959 (char_table_ref_and_range): Uncompress the compressed values.
960 (sub_char_table_set): New arg is_uniprop. Callers changed.
961 Uncompress the compressed values.
962 (sub_char_table_set_range): Args changed. Callers changed.
963 (char_table_set_range): Adjuted for the above change.
964 (map_sub_char_table): Delete args default_val and parent. Add arg
965 top. Give decoded values to a Lisp function.
966 (map_char_table): Adjusted for the above change. Give decoded
967 values to a Lisp function. Gcpro more variables.
968 (uniprop_table_uncompress)
969 (uniprop_decode_value_run_length): New functions.
970 (uniprop_decoder, uniprop_decoder_count): New variables.
971 (uniprop_get_decoder, uniprop_encode_value_character)
972 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
974 (uniprop_encoder, uniprop_encoder_count): New variables.
975 (uniprop_get_encoder, uniprop_table)
976 (Funicode_property_table_internal, Fget_unicode_property_internal)
977 (Fput_unicode_property_internal): New functions.
978 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
979 Sunicode_property_table_internal, Sget_unicode_property_internal,
980 and Sput_unicode_property_internal. Defvar_lisp
981 char-code-property-alist.
983 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
984 Vunicode_category_table.
986 * font.c (font_range): Adjusted for the change of
987 Vunicode_category_table.
989 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
991 * m/iris4d.h: Remove file, move contents ...
992 * s/irix6-5.h: ... here.
994 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
996 Remove unportable assumption about struct layout (Bug#8884).
997 * alloc.c (mark_buffer):
998 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
999 (clone_per_buffer_values): Don't assume that
1000 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1001 This isn't true in general, and it's particularly not true
1002 if Emacs is configured with --with-wide-int.
1003 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1004 New macros, used in the buffer.c change.
1006 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1008 * xsettings.c: Use both GConf and GSettings if both are available.
1009 (store_config_changed_event): Add comment.
1010 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1011 (store_tool_bar_style_changed): New functions.
1012 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1013 (struct xsettings): Move font inside HAVE_XFT.
1014 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1015 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
1016 Move inside HAVE_XFT.
1017 (something_changed_gsettingsCB): Renamed from something_changedCB.
1018 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1020 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1021 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1022 (something_changed_gconfCB): Renamed from something_changedCB.
1023 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1024 (parse_settings): Move check for font inside HAVE_XFT.
1025 (read_settings, apply_xft_settings): Add comment.
1026 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1027 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1028 call store_font_name_changed.
1029 (xft_settings_event): Add comment.
1030 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1031 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1032 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1033 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1034 (xsettings_initialize): Call init_gsettings last.
1035 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
1038 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1040 Random fixes. E.g., (random) never returned negative values.
1041 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1042 subseconds part to the entropy, as that's a bit more random.
1043 Prefer signed to unsigned, since the signedness doesn't matter and
1044 in general we prefer signed. When given a limit, use a
1045 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1046 latter isn't right if USE_2_TAGS_FOR_INTS.
1047 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1048 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1050 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1052 * textprop.c (text_property_stickiness):
1053 Obey Vtext_property_default_nonsticky.
1054 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1055 * w32fns.c (syms_of_w32fns):
1056 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1058 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1060 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1061 This is more efficient than Ffile_directory_p and avoids a minor race.
1063 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1065 * buffer.c (Foverlay_put): Say what the return value is
1068 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1069 is a directory before asking whether to use the file name
1071 (barf_or_query_if_file_exists): Make the "File is a directory"
1072 error be more correct.
1074 * fns.c (Frequire): Remove the mention of the .gz files, since
1075 that's installation-specific, but keep the mention of
1076 `get-load-suffixes'.
1078 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1080 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1081 Report string overflow if the output is too long.
1083 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1085 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1086 (syms_of_gnutls): Remove duplicate DEFSYM for
1087 Qgnutls_bootprop_verify_hostname_error, an error for
1088 Qgnutls_bootprop_verify_error (which is no longer used).
1090 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1091 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1092 Also (re)move comments that are misplaced or no longer relevant.
1094 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1096 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1098 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1100 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1101 and background color parameters if they have been changed.
1103 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1105 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1107 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1109 * xsettings.c (SYSTEM_FONT): Define only when used.
1110 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1112 * keymap.c (access_keymap_1): Now static.
1114 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1116 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1117 leave any prefix arg for the up event (Bug#1586).
1119 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1121 * lread.c (syms_of_lread): Mention single symbols defined by
1122 `defvar' or `defconst' (bug#7154).
1124 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1125 (Frequire): Mention get-load-suffixes.
1127 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1129 * window.h (window): Remove clone_number slot.
1130 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1132 (make_parent_window, make_window, saved_window)
1133 (Fset_window_configuration, save_window_save): Don't deal with
1135 * buffer.c (Qclone_number): Remove declaration.
1136 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1138 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1140 Add multiple inheritance to keymaps.
1141 * keymap.c (Fmake_composed_keymap): New function.
1142 (Fset_keymap_parent): Simplify.
1143 (fix_submap_inheritance): Remove.
1144 (access_keymap_1): New function extracted from access_keymap to handle
1145 embedded parents and handle lists of maps.
1146 (access_keymap): Use it.
1147 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1148 (Fcopy_keymap): Handle embedded parents.
1149 (Fcommand_remapping, define_as_prefix): Simplify.
1150 (Fkey_binding): Simplify.
1151 (syms_of_keymap): Move minibuffer-local-completion-map,
1152 minibuffer-local-filename-completion-map,
1153 minibuffer-local-must-match-map, and
1154 minibuffer-local-filename-must-match-map to Elisp.
1155 (syms_of_keymap): Defsubr make-composed-keymap.
1156 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1157 (parse_menu_item): Trivial simplification.
1159 2011-07-01 Glenn Morris <rgm@gnu.org>
1161 * Makefile.in (SETTINGS_LIBS): Fix typo.
1163 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1165 * coding.c (Fencode_coding_string): Record the last coding system
1166 used, as the function doc string says (bug#8738).
1168 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1170 * xsettings.c (store_monospaced_changed): Take new font as arg and
1171 check for change against current_mono_font.
1172 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1173 (emacs_settings_constructor, emacs_settings_get_property)
1174 (emacs_settings_set_property, emacs_settings_class_init)
1175 (emacs_settings_init, gsettings_obj): Remove.
1176 (something_changedCB): New function for HAVE_GSETTINGS.
1177 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1178 with value as argument.
1179 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1180 g_settings_new (Bug#8967). Do not create gsettings_obj.
1181 Remove calls to g_settings_bind. Connect something_changedCB to
1184 * xgselect.c: Add defined (HAVE_GSETTINGS).
1185 (xgselect_initialize): Ditto.
1187 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1188 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1191 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1193 * eval.c (struct backtrace): Simplify and port the data structure.
1194 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1195 signed bit field, as this assumption is not portable and it makes
1196 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1197 "char debug_on_exit : 1" as this is not portable either; instead,
1198 use the portable "unsigned int debug_on_exit : 1". Remove unused
1199 member evalargs. Remove obsolete comments about cc bombing out.
1201 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1203 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1204 Let HAVE_GSETTINGS override HAVE_GCONF.
1205 (store_monospaced_changed): New function.
1206 (EMACS_SETTINGS): A new type derived from GObject to handle
1207 GSettings notifications.
1208 (emacs_settings_constructor, emacs_settings_get_property)
1209 (emacs_settings_set_property, emacs_settings_class_init):
1211 (gsettings_client, gsettings_obj): New variables.
1212 (GSETTINGS_SCHEMA): New define.
1213 (something_changedCB): Call store_monospaced_changed.
1214 (init_gsettings): New function.
1215 (xsettings_initialize): Call init_gsettings.
1216 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1219 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1222 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1224 * window.c (resize_root_window, grow_mini_window)
1225 (shrink_mini_window): Rename Qresize_root_window to
1226 Qwindow_resize_root_window and Qresize_root_window_vertically to
1227 Qwindow_resize_root_window_vertically.
1229 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1231 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1233 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1235 * makefile.w32-in: Redesign dependencies so they reflect more
1236 clearly which files are directly included by each source file,
1237 and not through other includes.
1239 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1241 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1242 (sort_overlays, overlay_strings): When an overlay's clone number
1243 matches the window's clone number process the overlay even if
1244 the overlay's window property doesn't match the current window.
1246 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1247 (Fwindow_hchild): Rename to Fwindow_left_child.
1248 (Fwindow_next): Rename to Fwindow_next_sibling.
1249 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1250 (resize_window_check): Rename to window_resize_check.
1251 (resize_window_apply): Rename to window_resize_apply.
1252 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1253 (Fdelete_other_windows_internal, resize_frame_windows)
1254 (Fsplit_window_internal, Fdelete_window_internal)
1255 (grow_mini_window, shrink_mini_window)
1256 (Fresize_mini_window_internal): Fix callers accordingly.
1258 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1260 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1261 (emacs_fixed_set_min_size): Remove.
1262 (emacs_fixed_new): Take frame as argument.
1264 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1265 (_EmacsFixedPrivate): Remove minwidth/height.
1266 Add struct frame *f.
1267 (emacs_fixed_init): Initialize priv->f.
1268 (get_parent_class, emacs_fixed_set_min_size): Remove.
1269 (emacs_fixed_new): Set priv->f to argument.
1270 (emacs_fixed_get_preferred_width)
1271 (emacs_fixed_get_preferred_height): Use min_width/height from
1272 frames size_hint to set minimum and natural (Bug#8919).
1273 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1274 and use min_width/height from frames size_hint to set
1275 min_width/height (Bug#8919).
1277 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1278 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1281 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1283 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1284 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1287 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1289 * process.c (wait_reading_process_output): Bypass select if
1290 waiting for a cell while ignoring keyboard input, and input is
1291 pending. Suggested by Jan Djärv (Bug#8869).
1293 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1295 Use gnulib's dup2 module instead of rolling our own.
1296 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1298 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1300 * dispnew.c (scrolling_window): Before scrolling, turn off a
1301 mouse-highlight in the window being scrolled.
1303 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1305 Move DEFSYM to lisp.h and use everywhere.
1307 * character.h (DEFSYM): Move declaration...
1308 * lisp.h (DEFSYM): ...here.
1314 * w32select.c: Don't include character.h.
1316 * alloc.c (syms_of_alloc):
1317 * buffer.c (syms_of_buffer):
1318 * bytecode.c (syms_of_bytecode):
1319 * callint.c (syms_of_callint):
1320 * casefiddle.c (syms_of_casefiddle):
1321 * casetab.c (init_casetab_once):
1322 * category.c (init_category_once, syms_of_category):
1323 * ccl.c (syms_of_ccl):
1324 * cmds.c (syms_of_cmds):
1325 * composite.c (syms_of_composite):
1326 * dbusbind.c (syms_of_dbusbind):
1327 * dired.c (syms_of_dired):
1328 * dispnew.c (syms_of_display):
1329 * doc.c (syms_of_doc):
1330 * editfns.c (syms_of_editfns):
1331 * emacs.c (syms_of_emacs):
1332 * eval.c (syms_of_eval):
1333 * fileio.c (syms_of_fileio):
1334 * fns.c (syms_of_fns):
1335 * frame.c (syms_of_frame):
1336 * fringe.c (syms_of_fringe):
1337 * insdel.c (syms_of_insdel):
1338 * keymap.c (syms_of_keymap):
1339 * lread.c (init_obarray, syms_of_lread):
1340 * macros.c (syms_of_macros):
1341 * msdos.c (syms_of_msdos):
1342 * print.c (syms_of_print):
1343 * process.c (syms_of_process):
1344 * search.c (syms_of_search):
1345 * sound.c (syms_of_sound):
1346 * syntax.c (init_syntax_once, syms_of_syntax):
1347 * terminal.c (syms_of_terminal):
1348 * textprop.c (syms_of_textprop):
1349 * undo.c (syms_of_undo):
1350 * w32.c (globals_of_w32):
1351 * window.c (syms_of_window):
1352 * xdisp.c (syms_of_xdisp):
1353 * xfaces.c (syms_of_xfaces):
1354 * xfns.c (syms_of_xfns):
1355 * xmenu.c (syms_of_xmenu):
1356 * xsettings.c (syms_of_xsettings):
1357 * xterm.c (syms_of_xterm): Use DEFSYM.
1359 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1361 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1363 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1365 Integer and buffer overflow fixes (Bug#8873).
1367 * print.c (printchar, strout): Check for string overflow.
1368 (PRINTPREPARE, printchar, strout):
1369 Don't set size unless allocation succeeds.
1371 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1372 for sizes. Check for string overflow more accurately.
1373 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1375 * macros.c: Integer and buffer overflow fixes.
1376 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1377 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1378 Use ptrdiff_t, not int, for sizes.
1379 Don't increment bufsize until after realloc succeeds.
1380 Check for size-calculation overflow.
1381 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1383 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1385 * lread.c: Integer overflow fixes.
1386 (read_integer): Radix is now EMACS_INT, not int,
1387 to improve quality of diagnostics for out-of-range radices.
1388 Calculate buffer size correctly for out-of-range radices.
1389 (read1): Check for integer overflow in radices, and in
1390 read-circle numbers.
1391 (read_escape): Avoid int overflow.
1392 (Fload, openp, read_buffer_size, read1)
1393 (substitute_object_recurse, read_vector, read_list, map_obarray):
1394 Use ptrdiff_t, not int, for sizes.
1395 (read1): Use EMACS_INT, not int, for sizes.
1396 Check for size overflow.
1398 * image.c (cache_image): Check for size arithmetic overflow.
1400 * lread.c: Integer overflow issues.
1401 (saved_doc_string_size, saved_doc_string_length)
1402 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1403 Now ptrdiff_t, not int.
1404 (read1): Don't assume doc string length fits in int. Check for
1405 out-of-range doc string lengths.
1406 (read_list): Don't assume file position fits in int.
1407 (read_escape): Check for hex character overflow.
1409 2011-06-22 Leo Liu <sdl.web@gmail.com>
1411 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1412 Move to minibuffer.el.
1414 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1416 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1417 The following patches are for when GLYPH_DEBUG && !XASSERT.
1418 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1419 * dispnew.c (flush_stdout):
1420 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1421 Mark as externally visible.
1422 * dispnew.c (check_window_matrix_pointers): Now static.
1423 * dispnew.c (window_to_frame_vpos):
1424 * xfns.c (unwind_create_frame):
1425 * xterm.c (x_check_font): Remove unused local.
1426 * scroll.c (CHECK_BOUNDS):
1427 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1428 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1429 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1430 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1431 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1433 (debug_method_add): Use va_list and vsprintf rather than relying
1434 on undefined behavior with wrong number of arguments.
1435 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1436 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1437 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1438 since we're not interested in debugging glyphs with old libraries.
1439 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1440 GCC 4.6.0's static checking.
1442 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1444 Integer overflow and signedness fixes (Bug#8873).
1445 A few related buffer overrun fixes, too.
1447 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1449 * dispextern.h (struct face.stipple):
1450 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1451 (x_bitmap_mask, x_allocate_bitmap_record)
1452 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1453 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1454 (x_create_bitmap_from_xpm_data):
1455 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1456 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1458 * xfaces.c (load_pixmap):
1459 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1460 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1461 (.bitmaps_last, struct x_output.icon_bitmap):
1462 Use ptrdiff_t, not int, for bitmap indexes.
1463 (x_allocate_bitmap_record): Check for size overflow.
1464 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1466 Use ptrdiff_t, not int, for overlay counts.
1467 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1468 * editfns.c (overlays_around, get_pos_property):
1469 * textprop.c (get_char_property_and_overlay):
1470 * xdisp.c (next_overlay_change, note_mouse_highlight):
1471 * xfaces.c (face_at_buffer_position):
1472 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1473 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1474 (Fnext_overlay_change, Fprevious_overlay_change)
1475 (mouse_face_overlay_overlaps, Foverlays_in):
1476 Use ptrdiff_t, not int, for sizes.
1477 (overlays_at, overlays_in): Check for size-calculation overflow.
1479 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1481 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1482 (x_session_initialize): Do not assume string length fits in int.
1484 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1485 This is unlikely, but can occur if DPI is outlandish.
1487 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1488 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1490 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1491 * xrdb.c (magic_file_p, search_magic_path):
1492 Omit last arg SUFFIX; it was always 0. All callers changed.
1493 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1495 * xfont.c (xfont_match): Avoid need for strlen.
1497 * xfns.c: Don't assume strlen fits in int.
1498 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1500 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1501 not unsigned long, as we prefer signed integers. All callers changed.
1502 Detect integer overflow in repeat count.
1503 (message_dolog): Don't assume print length fits in 39 bytes.
1504 (display_mode_element): Don't assume strlen fits in int.
1506 * termcap.c: Don't assume sizes fit in int and never overflow.
1507 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1508 (gobble_line): Check for size-calculation overflow.
1510 * minibuf.c (Fread_buffer):
1511 * lread.c (intern, intern_c_string):
1512 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1513 Don't assume string length fits in int.
1515 * keyboard.c (parse_tool_bar_item):
1516 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1518 * font.c: Don't assume string length fits in int.
1519 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1520 Use ptrdiff_t, not int.
1521 (font_intern_prop): Don't assume string length fits in int.
1522 Don't assume integer property fits in fixnum.
1523 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1525 * filelock.c: Fix some buffer overrun and integer overflow issues.
1526 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1527 Reformulate so as not to need the command string.
1528 Invoke gzip -cd rather than gunzip, as it's more portable.
1529 (lock_info_type, lock_file_1, lock_file):
1530 Don't assume pid_t and time_t fit in unsigned long.
1531 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1532 (current_lock_owner): Prefer signed type for sizes.
1533 Use memcpy, not strncpy, where memcpy is what is really wanted.
1534 Don't assume (via atoi) that time_t and pid_t fit in int.
1535 Check for time_t and/or pid_t out of range, e.g., via a network share.
1536 Don't alloca where an auto var works fine.
1538 * fileio.c: Fix some integer overflow issues.
1539 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1540 Don't assume string length fits in int.
1541 (directory_file_name): Don't assume string length fits in long.
1542 (make_temp_name): Don't assume pid fits in int, or that its print
1543 length is less than 20.
1545 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1547 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1549 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1551 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1552 We prefer signed integers, even for size calculations.
1554 * emacs.c: Don't assume string length fits in 'int'.
1555 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1556 (main): Don't invoke strlen when not needed.
1558 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1559 (XD_DEBUG_MESSAGE): Don't waste a byte.
1561 * callproc.c (getenv_internal_1, getenv_internal)
1563 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1565 * lread.c (invalid_syntax): Omit length argument.
1566 All uses changed. This doesn't fix a bug, but it simplifies the
1567 code away from its former Hollerith-constant appearance, and it's
1568 one less 'int' to worry about when looking at integer-overflow issues.
1569 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1571 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1572 This didn't break anything, but it didn't help either.
1573 It's confusing to put a bogus integer in a place where the actual
1574 value does not matter.
1575 (LIST_END_P): Remove unused macro and its bogus comment.
1576 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1578 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1579 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1581 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1582 We prefer signed types, and the value cannot exceed the EMACS_INT
1583 range anyway (because otherwise the length would not be representable).
1584 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1585 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1586 This avoids a GCC warning when WIDE_EMACS_INT.
1588 * indent.c (sane_tab_width): New function.
1589 (current_column, scan_for_column, Findent_to, position_indentation)
1590 (compute_motion): Use it. This is just for clarity.
1591 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1593 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1595 * lisp.h (lint_assume): New macro.
1596 * composite.c (composition_gstring_put_cache):
1597 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1599 * editfns.c, insdel.c:
1600 Omit unnecessary forward decls, to simplify future changes.
1602 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1604 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1606 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1607 Use much-faster test for byte-length change.
1608 Don't assume string byte-length fits in 'int'.
1609 Check that character arg fits in 'int'.
1610 (mapcar1): Declare byte as byte, for clarity.
1612 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1614 * fns.c (concat): Catch string overflow earlier.
1615 Do not rely on integer wraparound.
1617 * dispextern.h (struct it.overlay_strings_charpos)
1618 (struct it.selective): Now EMACS_INT, not int.
1619 * xdisp.c (forward_to_next_line_start)
1620 (back_to_previous_visible_line_start)
1621 (reseat_at_next_visible_line_start, next_element_from_buffer):
1622 Don't arbitrarily truncate the value of 'selective' to int.
1624 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1626 * composite.c: Don't truncate sizes to 'int'.
1627 (composition_gstring_p, composition_reseat_it)
1628 (composition_adjust_point): Use EMACS_INT, not int.
1629 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1630 not EMACS_UINT, for indexes.
1632 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1634 * buffer.c: Include <verify.h>.
1635 (struct sortvec.priority, struct sortstr.priority):
1636 Now EMACS_INT, not int.
1637 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1638 (struct sortstr.size, record_overlay_string)
1639 (struct sortstrlist.size, struct sortlist.used):
1640 Don't truncate size to int.
1641 (record_overlay_string): Check for size-calculation overflow.
1642 (init_buffer_once): Check at compile-time, not run-time.
1644 2011-06-22 Jim Meyering <meyering@redhat.com>
1646 Don't leak an XBM-image-sized buffer
1647 * image.c (xbm_load): Free the image buffer after using it.
1649 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1652 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1653 that Sun C diagnosed.
1654 * fns.c (secure_hash): Fix pointer signedness issue.
1655 * intervals.c (static_offset_intervals): New function.
1656 (offset_intervals): Use it.
1658 2011-06-21 Leo Liu <sdl.web@gmail.com>
1661 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1664 * fns.c (secure_hash): Rename from crypto_hash_function and change
1665 the first arg to accept symbols.
1666 (Fsecure_hash): New primitive.
1667 (syms_of_fns): New symbols.
1669 2011-06-20 Deniz Dogan <deniz@dogan.se>
1671 * process.c (Fset_process_buffer): Clarify return value in
1674 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1676 * dispnew.c (add_window_display_history): Use BVAR.
1678 * xdisp.c (debug_method_add): Use BVAR.
1679 (check_window_end, dump_glyph_matrix, dump_glyph)
1680 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1682 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1685 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1686 check till after the cache is created in init_frame_faces.
1688 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1690 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1692 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1694 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1695 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1696 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1698 Improve buffer-overflow checking (Bug#8873).
1699 * fileio.c (Finsert_file_contents):
1700 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1701 Remove the old (too-loose) buffer overflow checks.
1702 They weren't needed, since make_gap checks for buffer overflow.
1703 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1704 The old code merely checked for Emacs fixnum overflow, and relied
1705 on undefined (wraparound) behavior. The new code avoids undefined
1706 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1708 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1709 Tune. Don't use wider integers than needed. Don't use alloca.
1710 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1712 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1714 * insdel.c, lisp.h (buffer_overflow): New function.
1715 (insert_from_buffer_1, replace_range, replace_range_2):
1716 * insdel.c (make_gap_larger):
1717 * editfns.c (Finsert_char):
1718 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1720 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1722 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1724 Integer overflow and signedness fixes (Bug#8873).
1726 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1727 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1729 * fileio.c: Don't assume EMACS_INT fits in off_t.
1730 (emacs_lseek): New static function.
1731 (Finsert_file_contents, Fwrite_region): Use it.
1732 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1734 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1736 * fns.c: Don't overflow int when computing a list length.
1737 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1738 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1739 truncation on 64-bit hosts. Check for QUIT every
1740 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1741 faster and is responsive enough.
1742 (Flength): Report an error instead of overflowing an integer.
1743 (Fsafe_length): Return a float if the value is not representable
1744 as a fixnum. This shouldn't happen except in contrived situations.
1745 (Fnthcdr, Fsort): Don't assume list length fits in int.
1746 (Fcopy_sequence): Don't assume vector length fits in int.
1748 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1749 (header_size, word_size): New constants.
1750 (allocate_vectorlike): Don't check size overflow here.
1751 (allocate_vector): Check it here instead, since this is the only
1752 caller of allocate_vectorlike that could cause overflow.
1753 Check that the new vector's length is representable as a fixnum.
1755 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1756 The previous code was bogus. For example, next_almost_prime (32)
1757 returned 39, which is undesirable as it is a multiple of 3; and
1758 next_almost_prime (24) returned 25, which is a multiple of 5 so
1759 why was the code bothering to check for multiples of 7?
1761 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1763 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1765 Variadic C functions now count arguments with ptrdiff_t.
1766 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1767 Back then I didn't know that the Emacs coding style prefers signed int.
1768 Also, in the meantime I found a few more instances where arguments
1769 were being counted with int, which may truncate counts on 64-bit
1770 machines, or EMACS_INT, which may be unnecessarily wide.
1771 * lisp.h (struct Lisp_Subr.function.aMANY)
1772 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1773 Arg counts are now ptrdiff_t, not size_t.
1774 All variadic functions and their callers changed accordingly.
1775 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1776 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1777 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1778 * callint.c (Fcall_interactively): Check arg count for overflow,
1779 to avoid potential buffer overrun. Use signed char, not 'int',
1780 for 'varies' array, so that we needn't bother to check its size
1781 calculation for overflow.
1782 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1783 * eval.c (apply_lambda):
1784 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1785 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1786 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1788 * callint.c (Fcall_interactively): Don't use index var as event count.
1790 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1791 * mem-limits.h (SIZE): Remove; no longer used.
1793 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1795 Remove unnecessary casts.
1796 * xterm.c (x_term_init):
1797 * xfns.c (x_set_border_pixel):
1798 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1799 These aren't needed now that we assume ANSI C.
1801 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1802 It's more likely to cause problems (due to unsigned overflow)
1805 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1807 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1809 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1811 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1813 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1815 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1817 GLYPH_CODE_FACE returns EMACS_INT, not int.
1818 * dispextern.h (merge_faces):
1819 * xfaces.c (merge_faces):
1820 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1821 Don't assume EMACS_INT fits in int.
1823 * character.h (CHAR_VALID_P): Remove unused parameter.
1824 * fontset.c, lisp.h, xdisp.c: All uses changed.
1826 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1828 * fns.c (concat): Minor tuning based on overflow analysis.
1829 This doesn't fix any bugs. Use int to hold character, instead
1830 of constantly refetching from Emacs object. Use XFASTINT, not
1831 XINT, for value known to be a character. Don't bother comparing
1832 a single byte to 0400, as it's always less.
1834 * floatfns.c (Fexpt):
1835 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1837 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1840 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1842 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1843 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1844 incorrectly succeed when S was a string, because 4294967386 was
1845 truncated before it was used.
1847 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1848 Otherwise, an out-of-range integer could cause undefined behavior
1851 * composite.c: Use int, not EMACS_INT, for characters.
1852 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1853 EMACS_INT, for values that are known to be in character range.
1854 This doesn't fix any bugs but is the usual style inside Emacs and
1855 may generate better code on 32-bit machines.
1857 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1858 This is for reasons similar to the recent CHAR_STRING fix.
1859 * charset.c (Fencode_char): Check that character arg is actually
1860 a character. Pass an int to ENCODE_CHAR.
1861 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1862 wider than 'int', as a compile-time check to prevent future regressions
1865 * character.c (char_string): Remove unnecessary casts.
1867 Make sure a 64-bit char is never passed to CHAR_STRING.
1868 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1869 by silently ignoring the top 32 bits, allowing some values
1870 that were far too large to be valid characters.
1871 * character.h: Include <verify.h>.
1872 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1873 arguments are no wider than unsigned, as a compile-time check
1874 to prevent future regressions in this area.
1876 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1877 (Fsubst_char_in_region):
1879 * xdisp.c (decode_mode_spec_coding):
1880 Adjust to CHAR_STRING's new requirement.
1881 * editfns.c (Finsert_char, Fsubst_char_in_region):
1882 * fns.c (concat): Check that character args are actually
1883 characters. Without this test, these functions did the wrong
1884 thing with wildly out-of-range values on 64-bit hosts.
1886 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1887 These casts should not be needed on 32-bit hosts, either.
1888 * keyboard.c (read_char):
1889 * lread.c (Fload): Remove casts to unsigned.
1891 * lisp.h (UNSIGNED_CMP): New macro.
1892 This fixes comparison bugs on 64-bit hosts.
1893 (ASCII_CHAR_P): Use it.
1894 * casefiddle.c (casify_object):
1895 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1896 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1897 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1898 * dispextern.h (FACE_FROM_ID):
1899 * keyboard.c (read_char): Use UNSIGNED_CMP.
1901 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1902 not to EMACS_INT, to avoid GCC warning.
1904 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1906 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1907 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1908 isn't needed on 32-bit machines.
1910 * buffer.c (Fgenerate_new_buffer_name):
1911 Use EMACS_INT for count, not int.
1912 (advance_to_char_boundary): Return EMACS_INT, not int.
1914 * data.c (Qcompiled_function): Now static.
1916 * window.c (window_body_lines): Now static.
1918 * image.c (gif_load): Rename local to avoid shadowing.
1920 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1921 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1922 * alloc.c (make_save_value): Integer argument is now of type
1924 (mark_object): Use ptrdiff_t, not int.
1925 * lisp.h (pD): New macro.
1926 * print.c (print_object): Use it.
1928 * alloc.c: Use EMACS_INT, not int, to count objects.
1929 (total_conses, total_markers, total_symbols, total_vector_size)
1930 (total_free_conses, total_free_markers, total_free_symbols)
1931 (total_free_floats, total_floats, total_free_intervals)
1932 (total_intervals, total_strings, total_free_strings):
1933 Now EMACS_INT, not int. All uses changed.
1934 (Fgarbage_collect): Compute overall total using a double, so that
1935 integer overflow is less likely to be a problem. Check for overflow
1936 when converting back to an integer.
1937 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1938 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1939 These were 'int' variables that could overflow on 64-bit hosts;
1940 they were never used, so remove them instead of repairing them.
1941 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1942 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1943 Previously, this ceilinged at INT_MAX, but that doesn't work on
1945 (allocate_pseudovector): Don't use EMACS_INT when int would do.
1947 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1948 (allocate_vectorlike): Check for ptrdiff_t overflow.
1949 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1950 when a (possibly-narrower) signed value would do just as well.
1951 We prefer using signed arithmetic, to avoid comparison confusion.
1953 * alloc.c: Catch some string size overflows that we were missing.
1954 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1955 for convenience in STRING_BYTES_MAX.
1956 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1957 The definition here is exact; the one in lisp.h was approximate.
1958 (allocate_string_data): Check for string overflow. This catches
1959 some instances we weren't catching before. Also, it catches
1960 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1961 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1962 and ptrdiff_t and EMACS_INT are both 64 bits.
1964 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1965 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1966 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1968 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1970 * alloc.c (Fmake_string): Check for out-of-range init.
1972 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1974 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1976 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1978 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1979 xg_get_default_scrollbar_width.
1981 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1982 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1983 (style_changed_cb): Call update_theme_scrollbar_width and call
1984 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1985 all frames (Bug#8505).
1986 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1987 Call gtk_window_set_resizable if HAVE_GTK3.
1988 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1989 and height if HAVE_GTK3 (Bug#8505).
1990 (scroll_bar_width_for_theme): New variable.
1991 (update_theme_scrollbar_width): New function.
1992 (xg_get_default_scrollbar_width): Move code to
1993 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1994 (xg_initialize): Call update_theme_scrollbar_width.
1996 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1998 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2000 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2002 * frame.c (make_frame): Call other_buffer_safely instead of
2005 * window.c (temp_output_buffer_show): Call display_buffer with
2006 second argument Vtemp_buffer_show_specifiers and reset latter
2007 immediately after the call.
2008 (Vtemp_buffer_show_specifiers): New variable.
2009 (auto_window_vscroll_p, next_screen_context_lines)
2010 (Vscroll_preserve_screen_position): Remove leading asterisks from
2013 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2015 Fix minor problems found by GCC 4.6.0 static checking.
2016 * buffer.c (Qclone_number): Remove for now, as it's unused.
2017 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2018 (record_buffer): Remove unused local.
2019 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2020 (set_frame_buffer_list): Remove; unused.
2021 * frame.h (other_visible_frames): Remove decl.
2022 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2023 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2024 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2026 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2027 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2028 Define only if HAVE_GPM.
2029 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2030 (update_hints_inhibit): Remove; never set. All uses removed.
2031 * widgetprv.h (emacsFrameClassRec): Remove decl.
2032 * window.c (delete_deletable_window): Now returns void, since it
2033 wasn't returning anything.
2034 (compare_window_configurations): Remove unused locals.
2035 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2036 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2037 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2038 the same widths as pointers. This follows up on the 2011-05-06 patch.
2039 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2040 * xterm.h: Likewise.
2041 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2043 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2045 * makefile.w32-in: Update dependencies.
2046 (LISP_H): Add lib/intprops.h.
2048 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2050 * image.c (gif_load): Add animation frame delay to the metadata.
2051 (syms_of_image): Use DEFSYM. New symbol `delay'.
2053 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2055 * window.c (delete_deletable_window): Re-add.
2056 (Fset_window_configuration): Rewrite to handle dead buffers and
2057 consequently deletable windows.
2058 (window_tree, Fwindow_tree): Remove. Supply functionality in
2060 (compare_window_configurations): Simplify code.
2062 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2064 * image.c (imagemagick_load_image): Fix type mismatch.
2065 (Fimagemagick_types): Likewise.
2067 * window.h (replace_buffer_in_windows): Declare.
2069 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2071 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2072 Qclone_number. Remove external declaration of Qdelete_window.
2073 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2075 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
2076 Qbuffer_list_update_hook if allowed.
2077 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2078 buffer list implementation.
2079 (other_buffer_safely): New function.
2080 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2081 calls to replace_buffer_in_windows and
2082 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2084 (record_buffer): Inhibit quitting and rewrite using quittable
2085 functions. Run Qbuffer_list_update_hook if allowed.
2086 (Frecord_buffer, Funrecord_buffer): New functions.
2087 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
2088 switch-to-buffer to window.el.
2089 (bury-buffer): Move to window.el.
2090 (Vbuffer_list_update_hook): New variable.
2092 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2095 * window.h (resize_frame_windows): Move up in code.
2096 (Fwindow_frame): Remove EXFUN.
2097 (replace_buffer_in_all_windows): Remove prototype.
2098 (replace_buffer_in_windows_safely): Add prototype.
2100 * window.c: Declare Qdelete_window static again. Move down
2101 declaration of select_count.
2102 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2103 (Fother_window): Move to window.el.
2104 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2105 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2106 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2108 (replace_buffer_in_windows): Implement by calling
2109 Qreplace_buffer_in_windows.
2110 (replace_buffer_in_all_windows): Remove with some functionality
2111 moved into replace_buffer_in_windows_safely.
2112 (replace_buffer_in_windows_safely): New function.
2113 (select_window_norecord, select_frame_norecord): Move in front
2114 of run_window_configuration_change_hook. Remove now obsolete
2116 (Fset_window_buffer): Rewrite doc-string. Call
2117 Qrecord_window_buffer.
2118 (keys_of_window): Move binding for other-window to window.el.
2120 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2122 * dispextern.h (struct image): Replace data member, whose int_val
2123 and ptr_val fields were not used by anything, with a single
2126 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2127 (gif_clear_image, gif_load, imagemagick_load_image)
2128 (gs_clear_image, gs_load): Callers changed.
2130 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2132 * buffer.h: Include <time.h>, for time_t.
2133 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2135 Fix minor problems found by static checking.
2137 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2139 Make identifiers static if they are not used in other modules.
2140 * data.c (Qcompiled_function, Qframe, Qvector):
2141 * image.c (QimageMagick, Qsvg):
2142 * minibuf.c (Qmetadata):
2143 * window.c (resize_window_check, resize_root_window): Now static.
2144 * window.h (resize_window_check, resize_root_window): Remove decls.
2146 * window.c (window_deletion_count, delete_deletable_window):
2148 (window_body_lines): Now static.
2149 (Fdelete_other_windows_internal): Mark vars as initialized.
2150 Make sure 'resize_failed' is initialized.
2151 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2152 (resize_window_apply): Remove unused local.
2153 * window.h (delete_deletable_window): Remove decl.
2155 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2156 (imagemagick_load_image): Fix pointer signedness problem by changing
2157 last arg from unsigned char * to char *. All uses changed.
2158 Also, fix a local for similar reasons.
2159 Remove unused locals. Remove locals to avoid shadowing.
2160 (fn_rsvg_handle_free): Remove; unused.
2161 (svg_load, svg_load_image): Fix pointer signedness problem.
2162 (imagemagick_load_image): Don't use garbage pointer image_wand.
2164 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2166 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2168 * image.c (gif_load): Fix omitted cast error introduced by
2171 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2173 * window.h (resize_proportionally, orig_total_lines)
2174 (orig_top_line): Remove from window structure.
2175 (set_window_height, set_window_width, change_window_heights)
2176 (Fdelete_window): Remove prototypes.
2177 (resize_frame_windows): Remove duplicate declaration.
2179 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2181 * window.h (resize_frame_windows, resize_window_check)
2182 (delete_deletable_window, resize_root_window)
2183 (resize_frame_windows): Declare prototypes.
2185 * window.c (resize_window_apply): Make definition be "static" to
2186 match the prototype.
2188 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2190 * window.c: Remove declarations of Qwindow_size_fixed,
2191 window_min_size_1, window_min_size_2, window_min_size,
2192 size_window, window_fixed_size_p, enlarge_window, delete_window.
2193 Remove static from declaration of Qdelete_window, it's
2194 temporarily needed by Fbury_buffer.
2195 (replace_window): Don't assign orig_top_line and
2197 (Fdelete_window, delete_window): Remove. Window deletion is
2198 handled by window.el.
2199 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2200 Fdelete_window calls with calls to Qdelete_window.
2201 (Fdelete_other_windows): Remove. Deleting other windows is
2202 handled by window.el.
2203 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2204 handled in window.el.
2205 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2206 Window minimum sizes are handled in window.el.
2207 (shrink_windows, size_window, set_window_height)
2208 (set_window_width, change_window_heights, window_height)
2209 (window_width, CURBEG, CURSIZE, enlarge_window)
2210 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2211 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2212 handled in window.el.
2213 (make_dummy_parent): Rename to make_parent_window and give it a
2214 second argument horflag.
2215 (make_window): Don't set resize_proportionally any more.
2216 (Fsplit_window): Remove. Windows are split in window.el.
2217 (save_restore_action, save_restore_orig_size)
2218 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2219 Resize mini windows in window.el.
2220 (grow_mini_window, shrink_mini_window): Implement by calling
2221 Qresize_root_window_vertically, resize_window_check and
2222 resize_window_apply.
2223 (saved_window, Fset_window_configuration, save_window_save): Do
2224 not handle orig_top_line, orig_total_lines, and
2225 resize_proportionally.
2226 (window_min_height, window_min_width): Move to window.el.
2227 (keys_of_window): Move bindings for delete-other-windows,
2228 split-window, delete-window and enlarge-window to window.el.
2230 * buffer.c: Temporarily extern Qdelete_window.
2231 (Fbury_buffer): Temporarily call Qdelete_window instead of
2232 Fdelete_window (Fbury_buffer will move to window.el soon).
2234 * frame.c (set_menu_bar_lines_1): Remove code handling
2235 orig_top_line and orig_total_lines.
2237 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2238 set_window_height but set heights directly.
2239 (change_frame_size_1): Use resize_frame_windows.
2241 * xdisp.c (init_xdisp): Don't use set_window_height but set
2244 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2245 resize_frame_windows instead of change_window_heights and run
2246 run_window_configuration_change_hook.
2248 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2249 instead of change_window_heights and run
2250 run_window_configuration_change_hook.
2252 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2254 * window.c (replace_window): Rename second argument REPLACEMENT to
2255 NEW. New third argument SETFLAG. Rewrite.
2256 (delete_window, make_dummy_parent): Call replace_window with
2258 (window_list_1): Move down in code.
2259 (run_window_configuration_change_hook): Move set_buffer part
2260 before select_frame_norecord part in order to unwind correctly.
2261 Rename count1 to count.
2262 (recombine_windows, delete_deletable_window, resize_root_window)
2263 (Fdelete_other_windows_internal)
2264 (Frun_window_configuration_change_hook, make_parent_window)
2265 (resize_window_check, resize_window_apply, Fresize_window_apply)
2266 (resize_frame_windows, Fsplit_window_internal)
2267 (Fdelete_window_internal, Fresize_mini_window_internal): New
2269 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2271 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2273 * window.h (window): Add some new members to window structure -
2274 normal_lines, normal_cols, new_total, new_normal, clone_number,
2275 splits, nest, prev_buffers, next_buffers.
2276 (WINDOW_TOTAL_SIZE): Move here from window.c.
2277 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2279 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2281 (make_dummy_parent): Set new members of windows structure.
2282 (make_window): Move down in code. Handle new members of window
2284 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2285 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2286 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2287 (Fset_window_prev_buffers, Fwindow_next_buffers)
2288 (Fset_window_next_buffers, Fset_window_clone_number): New
2290 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2291 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2293 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2294 Argument WINDOW can be now internal window too.
2295 (Fwindow_use_time): Move up in code.
2296 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2298 (Fset_window_configuration, saved_window)
2299 (Fcurrent_window_configuration, save_window_save): Handle new
2300 members of window structure.
2301 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2302 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2303 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2304 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2305 Qget_mru_window, Qresize_root_window,
2306 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2307 Qauto_buffer_name; staticpro them.
2309 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2311 * window.c (Fwindow_total_size, Fwindow_left_column)
2312 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2313 (Fwindow_list_1): New functions.
2314 (window_box_text_cols): Replace with window_body_cols.
2315 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2316 window_body_cols instead of window_box_text_cols.
2317 (delete_window, Fset_window_configuration): Call
2318 delete_all_subwindows with window as argument.
2319 (delete_all_subwindows): Take a window as argument and not a
2321 (window_loop): Remove handling of GET_LRU_WINDOW and
2323 (Fget_lru_window, Fget_largest_window): Move to window.el.
2325 * window.h: Extern window_body_cols instead of
2326 window_box_text_cols. delete_all_subwindows now takes a
2327 Lisp_Object as argument.
2329 * indent.c (compute_motion, Fcompute_motion): Use
2330 window_body_cols instead of window_box_text_cols.
2332 * frame.c (delete_frame): Call delete_all_subwindows with root
2335 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2337 * fns.c (Fputhash): Document return value.
2339 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2341 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2343 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2345 Cons<->int and similar integer overflow fixes (Bug#8794).
2347 Check for overflow when converting integer to cons and back.
2348 * charset.c (Fdefine_charset_internal, Fdecode_char):
2349 Use cons_to_unsigned to catch overflow.
2350 (Fencode_char): Use INTEGER_TO_CONS.
2351 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2352 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2353 * data.c (long_to_cons, cons_to_long): Remove.
2354 (cons_to_unsigned, cons_to_signed): New functions.
2355 These signal an error for invalid or out-of-range values.
2356 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2357 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2358 * font.c (Ffont_variation_glyphs):
2359 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2360 * lisp.h: Include <intprops.h>.
2361 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2362 (cons_to_signed, cons_to_unsigned): New decls.
2363 (long_to_cons, cons_to_long): Remove decls.
2364 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2365 (Fprimitive_undo): Use CONS_TO_INTEGER.
2366 * xfns.c (Fx_window_property): Likewise.
2367 * xselect.c: Include <limits.h>.
2368 (x_own_selection, selection_data_to_lisp_data):
2369 Use INTEGER_TO_CONS.
2370 (x_handle_selection_request, x_handle_selection_clear)
2371 (x_get_foreign_selection, Fx_disown_selection_internal)
2372 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2373 (lisp_data_to_selection_data): Use cons_to_unsigned.
2374 (x_fill_property_data): Use cons_to_signed.
2375 Report values out of range.
2377 Check for buffer and string overflow more precisely.
2378 * buffer.h (BUF_BYTES_MAX): New macro.
2379 * lisp.h (STRING_BYTES_MAX): New macro.
2380 * alloc.c (Fmake_string):
2381 * character.c (string_escape_byte8):
2382 * coding.c (coding_alloc_by_realloc):
2383 * doprnt.c (doprnt):
2384 * editfns.c (Fformat):
2386 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2387 since they may not be the same number.
2388 * editfns.c (Finsert_char):
2389 * fileio.c (Finsert_file_contents):
2390 Likewise for BUF_BYTES_MAX.
2392 * image.c: Use ptrdiff_t, not int, for sizes.
2393 (slurp_file): Switch from int to ptrdiff_t.
2395 (slurp_file): Check that file size fits in both size_t (for
2396 malloc) and ptrdiff_t (for sanity and safety).
2398 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2399 if b->modtime has its maximal value.
2401 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2403 Don't assume time_t can fit into int.
2404 * buffer.h (struct buffer.modtime): Now time_t, not int.
2405 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2406 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2408 Minor fixes for signed vs unsigned integers.
2409 * character.h (MAYBE_UNIFY_CHAR):
2410 * charset.c (maybe_unify_char):
2411 * keyboard.c (read_char, reorder_modifiers):
2412 XINT -> XFASTINT, since the integer must be nonnegative.
2413 * ftfont.c (ftfont_spec_pattern):
2414 * keymap.c (access_keymap, silly_event_symbol_error):
2415 XUINT -> XFASTINT, since the integer must be nonnegative.
2416 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2417 since it makes no difference and we prefer signed.
2418 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2419 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2422 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2424 * window.h (Fwindow_frame): Declare.
2426 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2428 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2429 (SPARE_MEMORY): Always define.
2430 (LARGE_REQUEST): Remove.
2431 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2433 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2435 * lisp.h: Move EXFUNS for Fframe_root_window,
2436 Fframe_first_window and Fset_frame_selected_window to window.h.
2438 * window.h: Move EXFUNS for Fframe_root_window,
2439 Fframe_first_window and Fset_frame_selected_window here from
2442 * frame.c (Fwindow_frame, Fframe_first_window)
2443 (Fframe_root_window, Fframe_selected_window)
2444 (Fset_frame_selected_window): Move to window.c.
2445 (Factive_minibuffer_window): Move to minibuf.c.
2446 (Fother_visible_frames_p): New function.
2448 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2450 * window.c (decode_window, decode_any_window): Move up in code.
2451 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2452 (inhibit_frame_unsplittable): Remove unused variable.
2453 (Fwindow_buffer): Move up and rewrite doc-string.
2454 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2455 (Fwindow_prev): New functions.
2456 (Fwindow_frame): Move here from frame.c. Accept any window as
2458 (Fframe_root_window, Fframe_first_window)
2459 (Fframe_selected_window): Move here from frame.c. Accept frame
2460 or arbitrary window as argument. Update doc-strings.
2461 (Fminibuffer_window): Move up in code.
2462 (Fwindow_minibuffer_p): Move up in code and simplify.
2463 (Fset_frame_selected_window): Move here from frame.c.
2465 (Fselected_window, select_window, Fselect_window): Move up in
2466 code. Minor doc-string fixes.
2468 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2470 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2471 Do not assume that spare memory exists; that assumption is valid
2472 only if SYSTEM_MALLOC.
2473 (LARGE_REQUEST): New macro, so that the issue of large requests
2474 is separated from the issue of spare memory.
2476 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2478 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2481 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2483 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2486 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2488 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2490 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2492 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2493 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2495 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2497 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2499 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2501 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2502 (x_clipboard_manager_save): Add return value.
2503 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2505 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2506 Obey Vx_select_enable_clipboard_manager. Catch errors in
2507 x_clipboard_manager_save (Bug#8779).
2508 (Vx_select_enable_clipboard_manager): New variable.
2509 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2511 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2513 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2515 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2517 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2518 in the current matrix if keep_current_p is non-zero.
2520 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2522 * bidi.c (bidi_level_of_next_char): Fix last change.
2524 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2526 Support bidi reordering of text covered by display properties.
2528 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2529 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2530 (bidi_cache_search, bidi_cache_iterator_state)
2531 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2532 (bidi_level_of_next_char, bidi_move_to_visually_next):
2533 Support character positions inside a run of characters covered by a
2535 (bidi_paragraph_init, bidi_resolve_explicit_1)
2536 (bidi_level_of_next_char): Call bidi_fetch_char and
2537 bidi_fetch_char_advance instead of FETCH_CHAR and
2539 (bidi_init_it): Initialize new members.
2540 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2542 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2543 instead of using explicit *_CHAR codes.
2544 (bidi_resolve_explicit, bidi_resolve_weak):
2545 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2546 bidirectional text is supported only in multibyte buffers.
2547 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2548 it to initialize the frame_window_p member of struct bidi_it.
2549 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2550 (bidi_resolve_explicit, bidi_resolve_weak)
2551 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2552 bidi_it->nchars is non-positive.
2553 (bidi_level_of_next_char): Don't try to lookup the cache for the
2554 next/previous character if nothing is cached there yet, or if we
2555 were just reseat()'ed to a new position.
2557 * xdisp.c (set_cursor_from_row): Set start and stop points
2558 according to the row's direction when priming the loop that looks
2559 for the glyph on which to display cursor.
2560 (single_display_spec_intangible_p): Function deleted.
2561 (display_prop_intangible_p): Reimplement to call
2562 handle_display_spec instead of single_display_spec_intangible_p.
2563 Accept 3 additional arguments needed by handle_display_spec.
2564 This fixes incorrect cursor motion across display property with complex
2565 values: lists, `(when COND...)' forms, etc.
2566 (single_display_spec_string_p): Support property values that are
2567 lists with the argument STRING its top-level element.
2568 (display_prop_string_p): Fix the condition for processing a
2569 property that is a list to be consistent with handle_display_spec.
2570 (handle_display_spec): New function, refactored from the
2571 last portion of handle_display_prop.
2572 (compute_display_string_pos): Accept additional argument
2573 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2574 value of a `display' property is a "replacing spec".
2575 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2576 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2577 the display property, but just return a value indicating whether
2578 the display property will replace the characters it covers.
2579 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2580 frame_window_p members of struct bidi_it.
2581 (compute_display_string_pos, compute_display_string_end):
2583 (push_it): Accept second argument POSITION, where pop_it should
2584 jump to continue iteration.
2585 (reseat_1): Initialize bidi_it.disp_pos.
2587 * keyboard.c (adjust_point_for_property): Adjust the call to
2588 display_prop_intangible_p to its new signature.
2590 * dispextern.h (struct bidi_it): New member frame_window_p.
2591 (bidi_init_it): Update prototypes.
2592 (display_prop_intangible_p): Update prototype.
2593 (compute_display_string_pos, compute_display_string_end):
2595 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2598 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2600 Malloc failure behavior now depends on size of allocation.
2601 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2602 * lisp.h: Change signatures accordingly.
2603 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2604 All callers changed. (Bug#8762)
2606 * gnutls.c: Use Emacs's memory allocators.
2607 Without this change, the gnutls library would invoke malloc etc.
2608 directly, which causes problems on non-SYNC_INPUT hosts, and which
2609 runs afoul of improving memory_full behavior. (Bug#8761)
2610 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2611 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2612 xfree instead of the default malloc, realloc, free.
2613 (Fgnutls_boot): No need to check for memory allocation failure,
2614 since xmalloc does that for us.
2616 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2617 * category.c (hash_get_category_set):
2618 * ccl.c (ccl_driver):
2619 * charset.c (Fdefine_charset_internal):
2620 * charset.h (struct charset.hash_index):
2621 * composite.c (get_composition_id, gstring_lookup_cache)
2622 (composition_gstring_put_cache):
2623 * composite.h (struct composition.hash_index):
2624 * dispextern.h (struct image.hash):
2625 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2626 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2627 (hashfn_equal, hashfn_user_defined, make_hash_table)
2628 (maybe_resize_hash_table, hash_lookup, hash_put)
2629 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2630 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2631 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2632 * image.c (make_image, search_image_cache, lookup_image)
2633 (xpm_put_color_table_h):
2634 * lisp.h (struct Lisp_Hash_Table):
2635 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2636 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2637 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2638 * alloc.c (allocate_vectorlike):
2639 Check for overflow in vector size calculations.
2640 * ccl.c (ccl_driver):
2641 Check for overflow when converting EMACS_INT to int.
2642 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2643 need to be updated by these changes.
2644 * fns.c (make_hash_table, maybe_resize_hash_table):
2645 Check for integer overflow with large hash tables.
2646 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2647 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2648 (SXHASH_REDUCE): New macro.
2649 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2650 Use it instead of discarding useful hash info with large hash values.
2651 (sxhash_float): New function.
2652 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2653 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2654 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2655 Rewrite to use FIXNUM_BITS, as this simplifies things.
2656 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2657 Adjust signatures to match updated version of code.
2658 (consing_since_gc): Now EMACS_INT, since a single hash table can
2659 use more than INT_MAX bytes.
2661 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2663 Make it possible to build with GCC-4.6+ -O2 -flto.
2665 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2667 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2669 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2670 Call minibuffer-inactive-mode.
2672 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2674 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2675 Update dependencies.
2677 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2679 * data.c (init_data): Remove code for UTS, this system is not
2682 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2684 Don't force ./temacs to start in terminal mode.
2686 * frame.c (make_initial_frame): Initialize faces in all cases, not
2687 only when CANNOT_DUMP is defined.
2688 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2690 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2692 * dispnew.c (add_window_display_history): Use const for the string
2693 pointer. Remove declaration, not needed.
2695 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2697 Use 'inline', not 'INLINE'.
2698 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2699 * alloc.c, fontset.c (INLINE): Remove.
2700 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2701 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2702 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2703 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2704 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2706 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2708 Make it possible to run ./temacs.
2710 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2711 syms_of_callproc does the same thing. Remove test for
2712 "initialized", do it in the caller.
2713 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2715 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2717 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2718 (read_minibuf): Use get_minibuffer.
2719 (syms_of_minibuf): Use DEFSYM.
2720 (Qmetadata): New var.
2721 * data.c (Qbuffer): Don't make it static.
2722 (syms_of_data): Use DEFSYM.
2724 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2726 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2727 (CCL_CODE_MIN): New macro.
2729 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2731 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2733 * eval.c (Qdebug): Now static.
2734 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2735 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2736 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2738 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2740 * image.c: Various fixes to ImageMagick code comments.
2741 (Fimagemagick_types): Doc fix.
2743 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2745 Minor fixes prompted by GCC 4.6.0 warnings.
2747 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2749 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2750 (x_clipboard_manager_save_all): Move extern decl to ...
2751 * xterm.h: ... here, so that it can be checked for consistency.
2753 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2755 * xselect.c (x_clipboard_manager_save_frame)
2756 (x_clipboard_manager_save_all): New functions.
2757 (Fx_clipboard_manager_save): Lisp function deleted.
2759 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2760 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2762 * xterm.h: Update prototype.
2764 2011-05-28 William Xu <william.xwl@gmail.com>
2766 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2769 2011-05-28 Jim Meyering <meyering@redhat.com>
2771 Avoid a sign-extension bug in crypto_hash_function.
2772 * fns.c (to_uchar): Define.
2773 (crypto_hash_function): Use it to convert some newly-signed
2774 variables to unsigned, to avoid sign-extension bugs. For example,
2775 without this change, (md5 "truc") would evaluate to
2776 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2777 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2778 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2780 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2782 Integer overflow fixes.
2784 * dbusbind.c: Serial number integer overflow fixes.
2785 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2786 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2787 to hold a serial number that is too large for a fixnum.
2788 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2789 Check for serial numbers out of range. Decode any serial number
2790 that was so large that it became a float. (Bug#8722)
2792 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2793 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2794 Use XFASTINT rather than XUINT when numbers are nonnegative.
2795 (xd_append_arg, Fdbus_method_return_internal):
2796 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2797 arguments, check that Lisp number is nonnegative, rather than
2798 silently wrapping negative numbers around. (Bug#8722)
2799 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2802 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2804 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2806 ccl: add integer overflow checks
2807 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2808 (IN_INT_RANGE): New macros.
2809 (ccl_driver): Use them to check for integer overflow when
2810 decoding a CCL program. Many of the new checks are whether XINT (x)
2811 fits in int; it doesn't always, on 64-bit hosts. The new version
2812 doesn't catch all possible integer overflows, but it's an
2813 improvement. (Bug#8719)
2815 * alloc.c (make_event_array): Use XINT, not XUINT.
2816 There's no need for unsigned here.
2818 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2819 This follows up to the 2011-05-06 change that substituted uintptr_t
2820 for EMACS_INT. This case wasn't caught back then.
2822 Rework Fformat to avoid integer overflow issues.
2823 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2824 now (part of C89). Include <verify.h>.
2825 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2826 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2827 (Fformat): Avoid the prepass trying to compute sizes; it was only
2828 approximate and thus did not catch overflow reliably. Instead, walk
2829 through the format just once, formatting and computing sizes as we go,
2830 checking for integer overflow at every step, and allocating a larger
2831 buffer as needed. Keep track separately whether the format is
2832 multibyte. Keep only the most-recently calculated precision, rather
2833 than them all. Record whether each argument has been converted to
2834 string. Use EMACS_INT, not int, for byte and char and arg counts.
2835 Support field widths and precisions larger than INT_MAX. Avoid
2836 sprintf's undefined behavior with conversion specifications such as %#d
2837 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2838 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2839 formatting out-of-range floating point numbers with int
2842 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2844 * data.c: Avoid integer truncation in expressions involving floats.
2845 * data.c: Include <intprops.h>.
2846 (arith_driver): When there's an integer overflow in an expression
2847 involving floating point, convert the integers to floating point
2848 so that the resulting value does not suffer from catastrophic
2849 integer truncation. For example, on a 64-bit host (* 4
2850 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2851 Do not rely on undefined behavior after integer overflow.
2853 merge count_size_as_multibyte, parse_str_to_multibyte
2854 * character.c, character.h (count_size_as_multibyte):
2855 Rename from parse_str_to_multibyte; all uses changed.
2856 Check for integer overflow.
2857 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2858 since it's now a duplicate of the other. This is more of
2859 a character than a buffer op, so better that it's in character.c.
2860 * fns.c, print.c: Adjust to above changes.
2862 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2864 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2866 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2868 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2869 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2870 (x_clipboard_manager_save): Now static.
2871 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2873 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2874 (crypto_hash_function): Now static.
2875 Fix pointer signedness problems. Avoid unnecessary initializations.
2877 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2879 * termhooks.h (Vselection_alist): Make it terminal-local.
2881 * terminal.c (create_terminal): Initialize it.
2883 * xselect.c: Support for clipboard managers.
2884 (Vselection_alist): Move to termhooks.h as terminal-local var.
2885 (LOCAL_SELECTION): New macro.
2886 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2887 (symbol_to_x_atom): Remove gratuitous arg.
2888 (x_handle_selection_request, lisp_data_to_selection_data)
2889 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2890 (x_own_selection, x_get_local_selection, x_convert_selection):
2891 New arg, specifying work frame. Use terminal-local Vselection_alist.
2892 (some_frame_on_display): Delete unused function.
2893 (Fx_own_selection_internal, Fx_get_selection_internal)
2894 (Fx_disown_selection_internal, Fx_selection_owner_p)
2895 (Fx_selection_exists_p): New optional frame arg.
2896 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2897 (x_handle_selection_clear): Don't treat other terminals with the
2898 same keyboard specially. Use the terminal-local Vselection_alist.
2899 (x_clear_frame_selections): Use Frun_hook_with_args.
2901 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2903 * xterm.h: Add support for those atoms.
2905 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2907 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2908 (converted_selections, conversion_fail_tag): New global variables.
2909 (x_selection_request_lisp_error): Free the above.
2910 (x_get_local_selection): Remove unnecessary code.
2911 (x_reply_selection_request): Args changed; handle arbitrary array
2912 of converted selections stored in converted_selections.
2913 Separate the XChangeProperty and SelectionNotify steps.
2914 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2915 (x_convert_selection): New function.
2916 (x_handle_selection_event): Simplify.
2917 (x_get_foreign_selection): Don't ignore incoming requests while
2918 waiting for an answer; this will fail when we implement
2919 SAVE_TARGETS, and seems unnecessary anyway.
2920 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2921 (Vx_sent_selection_functions): Doc fix.
2923 2011-05-26 Leo Liu <sdl.web@gmail.com>
2925 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2927 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2929 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2931 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2932 for fringe update if it has periodic bitmap.
2933 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2934 and fringe_bitmap_periodic_p.
2936 * fringe.c (get_fringe_bitmap_data): New function.
2937 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2938 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2939 row. Mark glyph row for fringe update if periodicity changed.
2941 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2942 for fringe update unless it has periodic bitmap.
2944 2011-05-25 Kenichi Handa <handa@m17n.org>
2946 * xdisp.c (get_next_display_element): Set correct it->face_id for
2947 a static composition.
2949 2011-05-24 Leo Liu <sdl.web@gmail.com>
2952 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2954 * fns.c (crypto_hash_function, Fsha1): New function.
2955 (Fmd5): Use crypto_hash_function.
2956 (syms_of_fns): Add Ssha1.
2958 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2960 * gnutls.c: Remove unused macros.
2961 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2962 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2963 Remove macros that are defined and never used.
2964 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2966 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2968 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2969 (Fx_get_selection_internal): Minor cleanup.
2970 (Fx_own_selection_internal): Rename arguments for consistency with
2973 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2975 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2977 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2979 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2981 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2983 * dispnew.c (scrolling_window): Don't exclude the case that the
2984 last enabled row in the desired matrix touches the bottom boundary.
2986 2011-05-21 Glenn Morris <rgm@gnu.org>
2988 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2989 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2990 and add some more files.
2992 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2994 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2995 report_file_error introduced by the change from 2011-05-07.
2997 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2999 * systime.h (Time): Define only if emacs is defined.
3000 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3001 where the include path doesn't have X11/X.h by default. See
3002 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3004 2011-05-20 Kenichi Handa <handa@m17n.org>
3006 * composite.c (find_automatic_composition): Fix previous change.
3008 2011-05-20 Glenn Morris <rgm@gnu.org>
3010 * lisp.mk: New file, split from Makefile.in.
3011 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3012 (shortlisp): Remove.
3013 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3015 2011-05-19 Glenn Morris <rgm@gnu.org>
3017 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3018 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3019 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3020 (lisp): Set the order to that of loadup.el.
3021 (shortlisp): Make it a copy of $lisp.
3022 (SOME_MACHINE_LISP): Remove.
3023 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3024 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3026 2011-05-18 Kenichi Handa <handa@m17n.org>
3028 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3029 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3030 (find_automatic_composition): Mostly rewrite for efficiency.
3032 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3034 * makefile.w32-in: Update dependencies.
3036 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3038 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3039 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3041 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3043 Fix some integer overflow issues, such as string length overflow.
3045 * insdel.c (count_size_as_multibyte): Check for string overflow.
3047 * character.c (lisp_string_width): Check for string overflow.
3048 Use EMACS_INT, not int, for string indexes and lengths; in
3049 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3050 the resulting string length overflows an EMACS_INT; instead,
3051 report a string overflow if no precision given. When checking for
3052 precision exhaustion, use a check that cannot possibly have
3053 integer overflow. (Bug#8675)
3054 * character.h (lisp_string_width): Adjust to new signature.
3056 * alloc.c (string_overflow): New function.
3057 (Fmake_string): Use it. This doesn't change behavior, but saves
3058 a few bytes and will simplify future changes.
3059 * character.c (string_escape_byte8): Likewise.
3060 * lisp.h (string_overflow): New decl.
3062 Fixups, following up to the user-interface timestamp change.
3063 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3064 for UI timestamps, instead of unsigned long.
3065 * msdos.c (mouse_get_pos): Likewise.
3066 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3067 * w32gui.h (Time): Define by including "systime.h" rather than by
3068 declaring it ourselves. (Bug#8664)
3070 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3071 * image.c (clear_image_cache): Likewise.
3073 * term.c (term_mouse_position): Don't assume time_t wraparound.
3075 Be more systematic about user-interface timestamps.
3076 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3077 and sometimes 'EMACS_UINT', to represent these timestamps.
3078 This change causes it to use 'Time' uniformly, as that's what X uses.
3079 This makes the code easier to follow, and makes it easier to catch
3080 integer overflow bugs such as Bug#8664.
3081 * frame.c (Fmouse_position, Fmouse_pixel_position):
3082 Use Time, not unsigned long, for user-interface timestamps.
3083 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3084 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3085 * keyboard.h (last_event_timestamp): Likewise.
3086 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3087 * menu.h (xmenu_show): Likewise.
3088 * term.c (term_mouse_position): Likewise.
3089 * termhooks.h (struct input_event.timestamp): Likewise.
3090 (struct terminal.mouse_position_hook): Likewise.
3091 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3092 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3093 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3094 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3096 * menu.h, termhooks.h: Include "systime.h", for Time.
3098 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3099 Don't assume that the difference between two unsigned long values
3100 can fit into an integer. At this point, we know button_down_time
3101 <= event->timestamp, so the difference must be nonnegative, so
3102 there's no need to cast the result if double-click-time is
3103 nonnegative, as it should be; check that it's nonnegative, just in
3104 case. This bug is triggered when events are more than 2**31 ms
3105 apart (about 25 days). (Bug#8664)
3107 * xselect.c (last_event_timestamp): Remove duplicate decl.
3108 (x_own_selection): Remove needless cast to unsigned long.
3110 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3111 that always fit in int. Use a sentinel instead of a counter, to
3112 avoid a temp and to allay GCC's concerns about possible int overflow.
3113 * frame.h (struct frame): Use int for menu_bar_items_used
3114 instead of EMACS_INT, since it always fits in int.
3116 * menu.c (grow_menu_items): Check for int overflow.
3118 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3120 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3121 Before, the code was not consistent. These values cannot exceed
3122 2**31 - 1 so there's no need to make them unsigned.
3123 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3124 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3125 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3127 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3129 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3130 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3131 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3132 presumably because the widths might not match.
3134 * window.c (size_window): Avoid needless test at loop start.
3136 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3138 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3140 2011-05-12 Drew Adams <drew.adams@oracle.com>
3142 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3144 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3146 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3147 `width' to `bar_area_x' and `bar_area_width', respectively.
3148 (x_scroll_run): Take account of fringe background extension.
3150 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3151 Rename local vars `left' and `width' to `bar_area_x' and
3152 `bar_area_width', respectively.
3153 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3154 background extension.
3156 2011-05-10 Jim Meyering <meyering@redhat.com>
3158 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3160 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3162 * image.c (Finit_image_library): Return t for built-in image types,
3163 like pbm and xbm. (Bug#8640)
3165 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3167 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3169 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3171 * w32console.c (Fset_screen_color): Doc fix.
3172 (Fget_screen_color): New function.
3173 (syms_of_ntterm): Defsubr it.
3175 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3176 unlink the temporary file if Fcall_process didn't create it in the
3178 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3179 child process will be redirected to a file specified with `:file'.
3180 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3181 cue to call_process_cleanup not to close that handle.
3183 2011-05-07 Ben Key <bkey76@gmail.com>
3185 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3186 one of two shell specific rules, either bootstrap-temacs-CMD or
3187 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3188 to the previous implementation of the bootstrap-temacs rule.
3189 The bootstrap-temacs-CMD rule is similar to the previous
3190 implementation of the bootstrap-temacs rule except that it
3191 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3194 These changes, along with some changes to nt/configure.bat,
3195 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3196 earlier fix to add support for --cflags and --ldflags options
3197 that include quotes so that it works whether make uses cmd or
3200 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3202 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3203 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3205 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3206 a string. Handle both cases.
3207 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3208 (Fdbus_register_method): Use Qinvalid_function.
3210 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3212 * makefile.w32-in: Update dependencies.
3213 (LISP_H): Add inttypes.h and stdin.h.
3214 (PROCESS_H): Add unistd.h.
3216 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3218 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3219 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3221 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3223 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3225 * term.c (vfatal): Remove stray call to va_end.
3226 It's not needed and the C Standard doesn't allow it here anyway.
3228 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3229 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3231 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3234 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3236 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3238 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3240 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3242 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3244 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3245 * charset.c (Fdefine_charset_internal): Don't initialize
3246 charset.code_space[15]. The value was garbage, on hosts with
3247 32-bit int (Bug#8600).
3249 * lread.c (read_integer): Be more consistent with string-to-number.
3250 Use string_to_number to do the actual conversion; this avoids
3251 rounding errors and fixes some other screwups. Without this fix,
3252 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3253 (digit_to_number): Move earlier, for benefit of read_integer.
3254 Return -1 if the digit is out of range for the base, -2 if it is
3255 not a digit in any supported base. (Bug#8602)
3257 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3259 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3260 to match comment at start of function. This also removes a
3261 GCC warning about overflow in a 32+64-bit port.
3263 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3265 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3266 Reported by Stefan Monnier in
3267 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3268 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3269 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3271 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3272 (EMACS_UINTPTR): Likewise, with uintptr_t.
3274 * lisp.h: Prefer 64-bit EMACS_INT if available.
3275 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3276 on 32-bit hosts that have 64-bit int, so that they can access
3278 However, temporarily disable this change unless the temporary
3279 symbol WIDE_EMACS_INT is defined.
3281 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3283 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3284 This removes an assumption that EMACS_INT and long are the same
3285 width as pointers. The assumption is true for Emacs porting targets
3286 now, but we want to make other targets possible.
3287 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3288 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3289 In the rest of the code, change types of integers that hold casted
3290 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3291 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3292 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3293 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3294 No need to cast type when ORing.
3295 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3296 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3297 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3298 assume EMACS_INT is the same width as char *.
3299 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3300 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3301 Remove no-longer-needed casts.
3302 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3303 (xg_tool_bar_help_callback, xg_make_tool_item):
3304 Use EMACS_INTPTR to hold an integer
3305 that will be cast to void *; this can avoid a GCC warning
3306 if EMACS_INT is not the same width as void *.
3307 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3308 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3309 (current_message_1, set_message_1):
3310 Use a local to convert to proper width without a cast.
3311 * xmenu.c (dialog_selection_callback): Likewise.
3313 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3314 Also, don't assume VALBITS / RAND_BITS is less than 5,
3315 and don't rely on undefined behavior when shifting a 1 left into
3317 * lisp.h (get_random): Change signature to match.
3319 * lread.c (hash_string): Use size_t, not int, for hash computation.
3320 Normally we prefer signed values; but hashing is special, because
3321 it's better to use unsigned division on hash table sizes so that
3322 the remainder is nonnegative. Also, size_t is the natural width
3323 for hashing into memory. The previous code used 'int', which doesn't
3324 retain enough info to hash well into very large tables.
3325 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3327 * dbusbind.c: Don't possibly lose pointer info when converting.
3328 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3329 Use XPNTR rather than XHASH, so that the high-order bits of
3330 the pointer aren't lost when converting through void *.
3332 * eval.c (Fautoload): Don't double-shift a pointer.
3334 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3336 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3338 * gnutls.c (DEF_GNUTLS_FN):
3339 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3341 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3343 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3346 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3348 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3349 New version that can reserve upto 2GB of heap space.
3351 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3353 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3355 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3357 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3358 `gnutls_certificate_set_x509_key_file'.
3360 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3362 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3363 Update dependencies.
3365 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3367 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3368 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3369 Remove unused parameter `fildes'.
3370 * process.c (read_process_output, send_process): Don't pass it.
3372 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3374 Fix previous change: the library cache is defined in w32.c.
3375 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3376 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3378 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3380 Implement dynamic loading of GnuTLS on Windows.
3382 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3383 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3384 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3387 * gnutls.c (Qgnutls_dll): Define.
3388 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3389 (gnutls_*): Declare function pointers.
3390 (init_gnutls_functions): New function to initialize function pointers.
3391 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3392 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3393 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3394 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3395 (emacs_gnutls_write, emacs_gnutls_read)
3396 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3397 (Fgnutls_available_p): New function.
3398 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3399 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3400 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3402 * image.c: Include w32.h.
3403 (Vimage_type_cache): Delete.
3404 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3405 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3406 (w32_delayed_load): Move to w32.c.
3408 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3410 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3411 (w32_delayed_load): Move from image.c. When loading a library, record
3412 its filename in the :loaded-from property of the library id.
3413 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3414 Initialize and staticpro them.
3415 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3417 * process.c: Include lisp.h before w32.h, not after.
3418 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3419 instead of gnutls_record_check_pending.
3421 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3423 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3425 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3426 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3429 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3431 * xterm.c (x_set_frame_alpha): Do not set property on anything
3432 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3434 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3436 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3438 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3440 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3441 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3442 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3443 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3444 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3445 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3446 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3447 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3448 (Qgnutls_bootprop_callbacks_verify): Make static.
3450 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3452 * callproc.c: Indentation fixup.
3454 * sysdep.c (wait_for_termination_1): Make static.
3455 (wait_for_termination, interruptible_wait_for_termination):
3456 Move after wait_for_termination_1.
3458 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3460 * sysdep.c (interruptible_wait_for_termination): New function
3461 which is like wait_for_termination, but allows keyboard
3464 * callproc.c (Fcall_process): Add (:file "file") as an option for
3466 (Fcall_process_region): Ditto.
3468 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3470 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3471 rather than `XVECTOR (FOO)->size'.
3473 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3474 inttypes.h, as a gnulib replacement is used if it not available in
3477 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3479 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3480 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3481 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3483 * coding.c (coding_alloc_by_realloc): Error out if destination
3484 will grow beyond MOST_POSITIVE_FIXNUM.
3485 (decode_coding_emacs_mule): Abort if there isn't enough place in
3486 charbuf for the composition carryover bytes. Reserve an extra
3487 space for up to 2 characters produced in a loop.
3488 (decode_coding_iso_2022): Abort if there isn't enough place in
3489 charbuf for the composition carryover bytes.
3491 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3493 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3494 aborting when %lld or %lll format is passed.
3495 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3496 %llo or %llx format is passed. (Bug#8545)
3498 * window.c (window_scroll_line_based): Use a marker instead of
3499 simple variables to record original value of point. (Bug#7952)
3501 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3502 produced by %s or %c overflows available buffer space. (Bug#8545)
3504 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3506 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3507 (SIZE_MAX): Move defn after all includes, as they might #define it.
3509 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3511 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3513 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3515 * keyboard.c (Qdelayed_warnings_hook): Define.
3516 (command_loop_1): Run `delayed-warnings-hook'
3517 if Vdelayed_warnings_list is non-nil.
3518 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3519 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3521 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3523 * doprnt.c (doprnt): Don't return value smaller than the buffer
3524 size if the message was truncated. (Bug#8545).
3526 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3528 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3529 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3531 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3533 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3535 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3537 * makefile.w32-in: Update dependencies.
3539 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3541 Improve `doprnt' and its usage. (Bug#8545)
3542 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3543 `format_end'. Remove support for %l as a conversion specifier.
3544 Don't use xrealloc. Improve diagnostics when the %l size modifier
3545 is used. Update the commentary.
3547 * eval.c (verror): Simplify calculation of size_t.
3549 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3552 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3554 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3557 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3559 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3560 This makes this file independent of the recent pseudovector change.
3562 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3564 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3566 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3567 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3568 Remove unused local.
3569 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3571 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3572 GCC 4.6.0 optimizes based on type-based alias analysis.
3573 For example, if b is of type struct buffer * and v of type struct
3574 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3575 != &v->size, and therefore "v->size = 1; b->size = 2; return
3576 v->size;" must therefore return 1. This assumption is incorrect
3577 for Emacs, since it type-puns struct Lisp_Vector * with many other
3578 types. To fix this problem, this patch adds a new type struct
3579 vectorlike_header that documents the constraints on layout of vectors
3580 and pseudovectors, and helps optimizing compilers not get fooled
3581 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3582 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3583 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3585 (XSETPVECTYPE): Rewrite in terms of new macro.
3586 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3587 This is a bit clearer, and further avoids the possibility of
3588 undesirable aliasing.
3589 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3590 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3591 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3592 since Lisp_Subr is a special case (no "next" field).
3593 (ASIZE): Now uses header.size rather than size.
3594 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3595 to avoid the hassle of writing XVECTOR (foo)->header.size.
3596 (struct vectorlike_header): New type.
3597 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3598 object, to help avoid aliasing.
3599 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3600 (SUBRP): Likewise, since Lisp_Subr is a special case.
3601 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3602 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3603 (struct Lisp_Hash_Table): Combine first two members into a single
3604 struct vectorlike_header member. All uses of "size" and "next" members
3605 changed to be "header.size" and "header.next".
3606 * buffer.h (struct buffer): Likewise.
3607 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3608 * frame.h (struct frame): Likewise.
3609 * process.h (struct Lisp_Process): Likewise.
3610 * termhooks.h (struct terminal): Likewise.
3611 * window.c (struct save_window_data, struct saved_window): Likewise.
3612 * window.h (struct window): Likewise.
3613 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3614 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3615 * buffer.c (init_buffer_once): Likewise.
3616 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3618 * process.c (Fformat_network_address): Use local var for size,
3621 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3623 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3624 * data.c (atof): Remove decl; no longer used or needed.
3625 (digit_to_number): Move to lread.c.
3626 (Fstring_to_number): Use new string_to_number function, to be
3627 consistent with how the Lisp reader treats infinities and NaNs.
3628 Do not assume that floating-point numbers represent EMACS_INT
3629 without losing information; this is not true on most 64-bit hosts.
3630 Avoid double-rounding errors, by insisting on integers when
3631 parsing non-base-10 numbers, as the documentation specifies.
3632 * lisp.h (string_to_number): New decl, replacing ...
3633 (isfloat_string): Remove.
3634 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3635 (read1): Do not accept +. and -. as integers; this
3636 appears to have been a coding error. Similarly, do not accept
3637 strings like +-1e0 as floating point numbers. Do not report
3638 overflow for integer overflows unless the base is not 10 which
3639 means we have no simple and reliable way to continue.
3640 Break out the floating-point parsing into a new
3641 function string_to_number, so that Fstring_to_number parses
3642 floating point numbers consistently with the Lisp reader.
3643 (digit_to_number): Move here from data.c. Make it static inline.
3644 (E_CHAR, EXP_INT): Remove, replacing with ...
3645 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3646 (string_to_number): New function, replacing isfloat_string.
3647 This function checks for valid syntax and produces the resulting
3648 Lisp float number too. Rework it so that string-to-number
3649 no longer mishandles examples like "1.0e+". Use strtoumax,
3650 so that overflow for non-base-10 numbers is reported only when
3651 there's no portable and simple way to convert to floating point.
3653 * textprop.c (set_text_properties_1): Rewrite for clarity,
3654 and to avoid GCC warning about integer overflow.
3656 * intervals.h (struct interval): Use EMACS_INT for members
3657 where EMACS_UINT might cause problems. See
3658 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3659 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3660 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3662 (offset_intervals): Tell GCC not to worry about length overflow
3663 when negating a negative length.
3665 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3666 (overrun_check_free): Likewise.
3668 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3669 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3672 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3673 (gnutls_make_error): Rename local to avoid shadowing.
3674 (gnutls_emacs_global_deinit): ifdef out; not used.
3675 (Fgnutls_boot): Use const for pointer to readonly storage.
3676 Comment out unused local. Fix pointer signedness problems.
3678 * lread.c (openp): Don't stuff size_t into an 'int'.
3679 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3680 about possible signed overflow.
3682 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3683 (GDK_KEY_g): Don't define if already defined.
3684 (xg_prepare_tooltip): Avoid pointer signedness problem.
3685 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3687 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3688 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3690 * xfns.c (Fx_window_property): Simplify a bit,
3691 to make a bit faster and to avoid GCC 4.6.0 warning.
3692 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3694 * fns.c (internal_equal): Don't assume size_t fits in int.
3696 * alloc.c (compact_small_strings): Tighten assertion a little.
3698 Replace pEd with more-general pI, and fix some printf arg casts.
3699 * lisp.h (pI): New macro, generalizing old pEd macro to other
3700 conversion specifiers. For example, use "...%"pI"d..." rather
3701 than "...%"pEd"...".
3702 (pEd): Remove. All uses replaced with similar uses of pI.
3703 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3704 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3705 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3706 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3707 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3708 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3709 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3711 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3712 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3713 * print.c (safe_debug_print, print_object): Likewise.
3714 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3716 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3717 avoiding the 0 flag, which is not portable.
3718 * process.c (Fmake_network_process): Use pI to avoid cast.
3719 * region-cache.c (pp_cache): Likewise.
3720 * xdisp.c (decode_mode_spec): Likewise.
3721 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3722 behavior on 64-bit hosts with printf arg.
3723 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3724 (x_stop_queuing_selection_requests): Likewise.
3725 (x_get_window_property): Don't truncate byte count to an 'int'
3728 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3729 here, since it parses constructs like leading '-' and spaces,
3730 which are not wanted; and it overflows with large numbers.
3731 Instead, simply match F[0-9]+, which is what is wanted anyway.
3733 * alloc.c: Remove unportable assumptions about struct layout.
3734 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3735 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3736 (allocate_vectorlike, make_pure_vector): Use the new macros,
3737 plus offsetof, to remove unportable assumptions about struct layout.
3738 These assumptions hold on all porting targets that I know of, but
3739 they are not guaranteed, they're easy to remove, and removing them
3740 makes further changes easier.
3742 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3743 This doesn't fix a bug but makes the code clearer.
3744 (string_overrun_cookie): Now const. Use initializers that
3745 don't formally overflow signed char, to avoid warnings.
3746 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3747 can cause Emacs to crash when string overrun checking is enabled.
3748 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3749 multiple of sizeof (EMACS_INT); it need not be, if
3750 alignof(EMACS_INT) < sizeof (EMACS_INT).
3751 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3753 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3755 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3757 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3759 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3760 supposed to be handshaking. (Bug#8556)
3761 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3763 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3765 * lisp.h (Qdebug): List symbol.
3766 * eval.c (Qdebug): Restore global linkage.
3767 * keyboard.c (debug-on-event): New variable.
3768 (handle_user_signal): Break into debugger when debug-on-event
3769 matches the current signal symbol.
3771 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3773 * alloc.c (check_sblock, check_string_bytes)
3774 (check_string_free_list): Convert to standard C.
3776 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3778 * w32.c (emacs_gnutls_push): Fix typo.
3780 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3782 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3783 "cast to pointer from integer of different size".
3785 Improve doprnt and its use in verror. (Bug#8545)
3786 * doprnt.c (doprnt): Document the set of format control sequences
3787 supported by the function. Use SAFE_ALLOCA instead of always
3790 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3791 is one byte too soon. Don't use xrealloc; instead xfree and
3794 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3796 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3799 * gnutls.c: Renamed global_initialized to
3800 gnutls_global_initialized. Added internals for the
3801 :verify-hostname-error, :verify-error, and :verify-flags
3802 parameters of `gnutls-boot' and documented those parameters in the
3803 docstring. Start callback support.
3804 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3805 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3806 on error. Return error code.
3807 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3808 (emacs_gnutls_read): Likewise.
3809 (Fgnutls_boot): Return handshake error code.
3810 (emacs_gnutls_handle_error): New function.
3811 (wsaerror_to_errno): Likewise.
3813 * w32.h (emacs_gnutls_pull): Add prototype.
3814 (emacs_gnutls_push): Likewise.
3816 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3817 (emacs_gnutls_push): Likewise.
3819 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3821 * process.c (wait_reading_process_output): Check if GnuTLS
3822 buffered some data internally if no FDs are set for TLS
3825 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3826 (LIBS): Link to USER_LIBS.
3827 ($(BLD)/gnutls.$(0)): New target.
3829 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3831 * xdisp.c (handle_single_display_spec): Rename the
3832 display_replaced_before_p argument into display_replaced_p, to
3833 make it consistent with the commentary. Fix typos in the
3836 * textprop.c (syms_of_textprop): Remove dead code.
3837 (copy_text_properties): Delete obsolete commentary about an
3838 interface that was deleted long ago. Fix typos in the description
3841 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3842 to changes in oldXMenu/XMenu.h from 2011-04-16.
3843 <menu_help_message, prev_menu_help_message>: Constify.
3844 (IT_menu_make_room): menu->help_text is now `const char **';
3847 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3848 to changes in oldXMenu/XMenu.h from 2011-04-16.
3849 (struct XMenu): Declare `help_text' `const char **'.
3851 * xfaces.c <Qunspecified>: Make extern again.
3853 * syntax.c: Include sys/types.h before including regex.h, as
3856 * doc.c (get_doc_string): Improve the format passed to `error'.
3858 * doprnt.c (doprnt): Improve commentary.
3860 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3862 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3865 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3866 changes in globals.h immediately force recompilation.
3867 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3868 $(CURDIR)/s/ms-w32.h.
3869 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3871 * character.c (Fchar_direction): Function deleted.
3872 (syms_of_character): Don't defsubr it.
3873 <char-direction-table>: Deleted.
3875 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3877 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3878 * doprnt.c: Include limits.h.
3879 (SIZE_MAX): New macro.
3880 (doprnt): Return a size_t value. 2nd arg is now size_t.
3881 Many local variables are now size_t instead of int or unsigned.
3882 Improve overflow protection. Support `l' modifier for integer
3883 conversions. Support %l conversion. Don't assume an EMACS_INT
3884 argument for integer conversions and for %c.
3886 * lisp.h (doprnt): Restore prototype.
3888 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3891 * Makefile.in (base_obj): Add back doprnt.o.
3893 * deps.mk (doprnt.o): Add back prerequisites.
3894 (callint.o): Depend on character.h.
3896 * eval.c (internal_lisp_condition_case): Include the handler
3897 representation in the error message.
3898 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3899 when breaking from the loop.
3901 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3903 * callint.c (Fcall_interactively): When displaying error message
3904 about invalid control letter, pass the character's codepoint, not
3905 a pointer to its multibyte form. Improve display of the character
3906 in octal and display also its hex code.
3908 * character.c (char_string): Use %x to display the (unsigned)
3909 codepoint of an invalid character, to avoid displaying a bogus
3912 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3913 `error', not SYMBOL_NAME itself.
3915 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3916 character arguments to `error'.
3918 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3919 to `error' in error message about FINAL_CHAR argument. Make sure
3920 FINAL_CHAR is a character, and use %c when it is passed as
3921 argument to `error'.
3923 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3925 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3927 * w32.c: Include <time.h>.
3928 (sys_localtime): New function.
3930 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
3932 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3934 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3936 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3938 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3941 2011-04-19 Eli Zaretskii <eliz@gnu.org>
3943 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3944 gl_state.e_property when gl_state.object is Qt.
3946 * insdel.c (make_gap_larger): Remove limitation of buffer size
3949 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
3951 * xdisp.c (lookup_glyphless_char_display)
3952 (produce_glyphless_glyph): Handle cons cell entry in
3953 glyphless-char-display.
3954 (Vglyphless_char_display): Document it.
3956 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3957 glyphless-char-display.
3959 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
3961 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3963 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3965 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3966 definition for no-X builds.
3968 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3970 Static checks with GCC 4.6.0 and non-default toolkits.
3972 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3974 * process.c (keyboard_bit_set): Define only if SIGIO.
3975 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3976 (send_process): Repair possible setjmp clobbering.
3978 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3980 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3982 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3984 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3985 Define only if needed.
3987 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3988 by pacifying GCC about it. Maybe it's time to retire it?
3989 * xfaces.c (USG, __TIMEVAL__): Likewise.
3991 * dispextern.h (struct redisplay_interface): Rename param
3993 * termhooks.h (struct terminal): Likewise.
3994 * xterm.c (xembed_send_message): Likewise.
3996 * insdel.c (make_gap_smaller): Define only if
3997 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3999 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4002 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4003 so that we aren't warned about unused symbols.
4005 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4007 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4009 * xfns.c (x_real_positions): Mark locals as initialized.
4011 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4013 * xterm.c: Fix problems found by static analysis with other toolkits.
4014 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4015 (x_dispatch_event): Declare static if USE_GTK, and
4016 define if USE_GTK || USE_X_TOOLKIT.
4017 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4018 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4019 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4020 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4022 * xmenu.c (menu_help_callback): Pointer type fixes.
4023 Use const pointers when pointing at readonly data. Avoid pointer
4025 (FALSE): Remove unused macro.
4026 (update_frame_menubar): Remove unused decl.
4028 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4030 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4031 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4032 (single_menu_item): Rename local to avoid shadowing.
4034 * keyboard.c (make_lispy_event): Remove unused local var.
4036 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4037 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4039 * bitmaps: Change bitmaps from unsigned char back to the X11
4040 compatible char. Avoid the old compiler warnings about
4041 out-of-range initializers by using, for example, '\xab' rather
4044 * xgselect.c (xgselect_initialize): Check vs interface
4045 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4047 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4049 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4050 to read-only memory.
4052 * fns.c (vector): Remove; this old hack is no longer needed.
4054 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4056 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4058 * xrdb.c (x_load_resources): Omit unused local.
4060 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4061 (x_window): Rename locals to avoid shadowing.
4062 (USG): Use the kludged USG macro, to pacify gcc.
4064 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4065 (x_term_init): Remove local to avoid shadowing.
4067 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4069 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4070 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4072 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4074 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4076 Fix regex.c, syntax.c and friends for buffers > 2GB.
4077 * syntax.h (struct gl_state_s): Declare character position members
4080 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4082 * textprop.c (verify_interval_modification, interval_of):
4083 Declare arguments EMACS_INT.
4085 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4088 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4090 * indent.c (Fvertical_motion): Local variable it_start is now
4093 * regex.c (re_match, re_match_2, re_match_2_internal)
4094 (bcmp_translate, regcomp, regexec, print_double_string)
4095 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4096 (re_compile_pattern, re_exec): Declare arguments and local
4097 variables `size_t' and `ssize_t' and return values `regoff_t', as
4099 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4100 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4101 <compile_stack_type>: `size' and `avail' are now `size_t'.
4103 * regex.h <regoff_t>: Use ssize_t, not int.
4104 (re_search, re_search_2, re_match, re_match_2): Arguments that
4105 specify buffer/string position and length are now ssize_t and
4106 size_t. Return type is regoff_t.
4108 2011-04-16 Ben Key <bkey76@gmail.com>
4110 * nsfont.m: Fixed bugs in ns_get_family and
4111 ns_descriptor_to_entity that were caused by using free to
4112 deallocate memory blocks that were allocated by xmalloc (via
4113 xstrdup). This caused Emacs to crash when compiled with
4114 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4115 --enable-checking=xmallocoverrun). xfree is now used to
4116 deallocate these memory blocks.
4118 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4120 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4122 emacs_write: Accept and return EMACS_INT for sizes.
4123 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4125 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4126 Accept and return EMACS_INT.
4127 (emacs_gnutls_write): Return the number of bytes written on
4129 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4130 (emacs_read, emacs_write): Remove check for negative size, as the
4131 Emacs source code has been audited now.
4132 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4133 (emacs_read, emacs_write): Use it.
4134 * process.c (send_process): Adjust to the new signatures of
4135 emacs_write and emacs_gnutls_write. Do not attempt to store
4136 a byte offset into an 'int'; it might overflow.
4137 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4139 * sound.c: Don't assume sizes fit in 'int'.
4140 (struct sound_device.period_size, alsa_period_size):
4141 Return EMACS_INT, not int.
4142 (struct sound_device.write, vox_write, alsa_write):
4143 Accept EMACS_INT, not int.
4144 (wav_play, au_play): Use EMACS_INT to store sizes and to
4145 record read return values.
4147 2011-04-15 Ben Key <bkey76@gmail.com>
4149 * keyboard.c (Qundefined): Don't declare static since it is used
4151 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4152 static since they are used in nsfont.m.
4154 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4156 * process.c (Qprocessp): Don't declare static.
4157 * lisp.h (Qprocessp): Declare again.
4159 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4161 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4163 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4165 Improve C-level modularity by making more things 'static'.
4167 Don't publish debugger-only interfaces to other modules.
4168 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4169 (verify_bytepos, count_markers): Move decls to the only modules
4171 * region-cache.h (pp_cache): Likewise.
4172 * window.h (check_all_windows): Likewise.
4173 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4175 * sysdep.c (croak): Now static, if
4176 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4177 * syssignal.h (croak): Declare only if not static.
4179 * alloc.c (refill_memory_reserve): Now static if
4180 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4181 * lisp.h (refill_memory_reserve): Declare only if not static.
4183 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4184 Define only if USE_LUCID.
4186 * xrdb.c (x_customization_string, x_rm_string): Now static.
4188 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4189 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4191 * xdisp.c (draw_row_with_mouse_face): Now static.
4192 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4194 * window.h (check_all_windows): Mark externally visible.
4196 * window.c (window_deletion_count): Now static.
4198 * undo.c: Make symbols static if they're not exported.
4199 (last_undo_buffer, last_boundary_position, pending_boundary):
4202 * textprop.c (interval_insert_behind_hooks): Now static.
4203 (interval_insert_in_front_hooks): Likewise.
4205 * term.c: Make symbols static if they're not exported.
4206 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4207 (max_frame_lines, tty_set_terminal_modes):
4208 (tty_reset_terminal_modes, tty_turn_off_highlight):
4209 (get_tty_terminal): Now static.
4210 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4211 * termhooks.h (term_mouse_moveto): Do not declare if
4213 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4214 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4216 * sysdep.c: Make symbols static if they're not exported.
4217 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4219 (sigprocmask_set, full_mask): Remove; unused.
4220 (wait_debugging): Mark as visible.
4221 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4222 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4224 * syntax.c (syntax_temp): Define only if !__GNUC__.
4226 * sound.c (current_sound_device, current_sound): Now static.
4228 * search.c (searchbufs, searchbuf_head): Now static.
4230 * scroll.c (scroll_cost): Remove; unused.
4231 * dispextern.h (scroll_cost): Remove decl.
4233 * region-cache.h (pp_cache): Mark as externally visible.
4235 * process.c: Make symbols static if they're not exported.
4236 (process_tick, update_tick, create_process, chan_process):
4237 (Vprocess_alist, proc_buffered_char, datagram_access):
4238 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4239 (deactivate_process): Mark defn as static, as well as decl.
4240 * lisp.h (create_process): Remove decl.
4241 * process.h (chan_process, Vprocess_alist): Remove decls.
4243 * print.c: Make symbols static if they're not exported.
4244 (print_depth, new_backquote_output, being_printed, print_buffer):
4245 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4246 (print_interval, print_number_index, initial_stderr_stream):
4248 * lisp.h (Fprinc): Remove decl.
4249 (debug_output_compilation_hack): Mark as externally visible.
4251 * sysdep.c (croak): Move decl from here to syssignal.h.
4252 * syssignal.h (croak): Put it here, so the API can be checked when
4253 'croak' is called from dissociate_if_controlling_tty.
4255 * minibuf.c: Make symbols static if they're not exported.
4256 (minibuf_save_list, choose_minibuf_frame): Now static.
4257 * lisp.h (choose_minibuf_frame): Remove decl.
4259 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4261 * lread.c: Make symbols static if they're not exported.
4262 (read_objects, initial_obarray, oblookup_last_bucket_number):
4264 (make_symbol): Remove; unused.
4265 * lisp.h (initial_obarray, make_symbol): Remove decls.
4267 * keyboard.c: Make symbols static if they're not exported.
4268 (single_kboard, recent_keys_index, total_keys, recent_keys):
4269 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4270 (this_single_command_key_start, echoing, last_auto_save):
4271 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4272 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4273 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4274 (Vlispy_mouse_stem, double_click_count):
4276 (force_auto_save_soon): Define only if SIGDANGER.
4277 (ignore_mouse_drag_p): Now static if
4278 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4279 (print_help): Remove; unused.
4280 (stop_character, last_timer_event): Mark as externally visible.
4281 * keyboard.h (ignore_mouse_drag_p): Declare only if
4282 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4283 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4284 * lisp.h (echoing): Remove decl.
4285 (force_auto_save_soon): Declare only if SIGDANGER.
4286 * xdisp.c (redisplay_window): Simplify code, to make it more
4287 obvious that ignore_mouse_drag_p is not accessed if !defined
4288 USE_GTK && !defined HAVE_NS.
4290 * intervals.c: Make symbols static if they're not exported.
4291 (merge_properties_sticky, merge_interval_right, delete_interval):
4293 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4295 * insdel.c: Make symbols static if they're not exported.
4296 However, leave prepare_to_modify_buffer alone. It's never
4297 called from outside this function, but that appears to be a bug.
4298 (combine_after_change_list, combine_after_change_buffer):
4299 (adjust_after_replace, signal_before_change): Now static.
4300 (adjust_after_replace_noundo): Remove; unused.
4301 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4302 (signal_before_change): Remove decls.
4304 * indent.c (val_compute_motion, val_vmotion): Now static.
4306 * image.c: Make symbols static if they're not exported.
4307 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4309 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4310 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4312 * fringe.c (standard_bitmaps): Now static.
4313 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4315 * frame.c: Make symbols static if they're not exported.
4316 (x_report_frame_params, make_terminal_frame): Now static.
4317 (get_frame_param): Now static, unless HAVE_NS.
4318 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4319 (x_get_resource_string): Remove; not used.
4320 * frame.h (make_terminal_frame, x_report_frame_params):
4321 (x_get_resource_string); Remove decls.
4322 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4323 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4325 * font.c, fontset.c: Make symbols static if they're not exported.
4326 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4327 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4328 * font.c (font_close_object): Now static.
4329 * font.h (font_close_object): Remove.
4330 * fontset.c (FONTSET_OBJLIST): Remove.
4331 (free_realized_fontset) #if-0 the body, which does nothing.
4332 (face_suitable_for_char_p): #if-0, as it's never called.
4333 * fontset.h (face_suitable_for_char_p): Remove decl.
4334 * xfaces.c (face_at_string_position):
4335 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4336 since 0 is always ASCII.
4338 * fns.c (weak_hash_tables): Now static.
4340 * fileio.c: Make symbols static if they're not exported.
4341 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4342 (Vwrite_region_annotation_buffers): Now static.
4344 * eval.c: Make symbols static if they're not exported.
4345 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4346 * lisp.h (backtrace_list): Remove decl.
4348 * emacs.c: Make symbols static if they're not exported.
4349 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4350 (fatal_error_code, fatal_error_signal_hook, standard_args):
4352 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4353 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4354 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4355 * lisp.h (fatal_error_signal_hook): Remove decl.
4356 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4358 * editfns.c: Move a (normally-unused) function to its only use.
4359 * editfns.c, lisp.h (get_operating_system_release): Remove.
4360 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4361 worth the hassle of breaking this out.
4363 * xterm.c: Make symbols static if they're not exported.
4364 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4365 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4366 (x_destroy_window, x_delete_display):
4368 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4369 (x_mouse_leave): Remove; unused.
4370 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4371 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4372 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4374 (x_mouse_leave): Declare only if WINDOWSNT.
4375 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4376 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4379 * ftxfont.c: Make symbols static if they're not exported.
4380 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4382 * font.h (ftxfont_driver): Likewise.
4384 * xfns.c: Make symbols static if they're not exported.
4385 (x_last_font_name, x_display_info_for_name):
4386 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4387 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4388 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4389 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4390 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4391 (last_show_tip_args): Now static.
4392 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4393 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4394 (x_screen_planes): Remove; unused.
4395 * dispextern.h (x_screen_planes): Remove decl.
4397 * dispnew.c: Make symbols static if they're not exported.
4398 * dispextern.h (redraw_garbaged_frames, scrolling):
4399 (increment_row_positions): Remove.
4400 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4401 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4403 (redraw_garbaged_frames): Remove; unused.
4405 * xfaces.c: Make symbols static if they're not exported.
4406 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4408 * xterm.h (defined_color): Remove decls.
4409 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4410 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4411 (menu_face_changed_default, defined_color, free_realized_face):
4412 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4413 (ascii_face_of_lisp_face): Remove; unused.
4415 * xdisp.c: Make symbols static if they're not exported.
4416 * dispextern.h (scratch_glyph_row, window_box_edges):
4417 (glyph_to_pixel_coords, set_cursor_from_row):
4418 (get_next_display_element, set_iterator_to_next):
4419 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4420 (show_mouse_face): Remove decls
4421 * frame.h (message_buf_print): Likewise.
4422 * lisp.h (pop_message, set_message, check_point_in_composition):
4424 * xterm.h (set_vertical_scroll_bar): Likewise.
4425 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4426 (message_buf_print, scratch_glyph_row, displayed_buffer):
4427 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4428 (get_next_display_element, show_mouse_face, window_box_edges):
4429 (frame_to_window_pixel_xy, check_point_in_composition):
4430 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4431 (glyph_to_pixel_coords): Remove; unused.
4433 * dired.c (file_name_completion): Now static.
4435 * dbusbind.c (xd_in_read_queued_messages): Now static.
4437 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4438 * data.c (circular_list_error): Remove.
4440 * commands.h (last_point_position, last_point_position_buffer):
4441 (last_point_position_window): Remove decls.
4442 * keyboard.c: Make these variables static.
4444 * coding.h (coding, code_convert_region, encode_coding_gap):
4446 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4447 (iso_code_class, detect_coding, code_convert_region): Now static.
4448 (encode_coding_gap): Remove; unused.
4450 * chartab.c (chartab_chars, chartab_bits): Now static.
4452 * charset.h (charset_iso_8859_1): Remove decl.
4453 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4456 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4457 * ccl.c (Vccl_program_table): Now static.
4458 (check_ccl_update): Remove; unused.
4460 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4461 * category.h: ... from here.
4462 * category.c (check_category_table, set_category_set): Now static.
4464 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4465 * lisp.h: Remove these decls.
4467 * buffer.c (buffer_count): Remove unused var.
4469 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4470 so that it's not optimized away.
4471 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4472 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4473 exported only to the debugger.
4475 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4476 * atimer.h (run_all_atimers): Remove; not exported.
4478 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4479 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4480 was inaccessible from Lisp.
4481 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4482 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4484 alloc.c: Import and export fewer symbols, and remove unused items.
4485 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4487 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4488 it's not optimized away by whole-program optimization.
4489 (message_enable_multibyte, free_misc): Remove.
4490 (catchlist, handlerlist, mark_backtrace):
4491 Declare only if BYTE_MARK_STACK.
4492 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4493 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4494 (message_enable_multibyte): Remove decl.
4495 (free_misc, interval_free_list, float_block, float_block_index):
4496 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4497 (cons_free_list, last_marked_index):
4499 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4500 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4501 (mark_backtrace): Define only if BYTE_MARK_STACK.
4502 * xdisp.c (message_enable_multibyte): Now static.
4504 Declare Lisp_Object Q* variables to be 'static' if not exported.
4505 This makes it easier for human readers (and static analyzers)
4506 to see whether these variables are used from other modules.
4507 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4508 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4509 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4510 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4511 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4512 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4513 * xmenu.c, xselect.c:
4514 Declare Q* vars static if they are not used in other modules.
4515 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4516 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4517 Remove decls of unexported vars.
4518 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4520 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4522 Make Emacs functions such as Fatom 'static' by default.
4523 This makes it easier for human readers (and static analyzers)
4524 to see whether these functions can be called from other modules.
4525 DEFUN now defines a static function. To make the function external
4526 so that it can be used in other C modules, use the new macro DEFUE.
4527 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4528 (Finit_image_library):
4529 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4530 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4531 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4532 Remove decls, since these functions are now static.
4533 (Funintern, Fget_internal_run_time): New decls, since these functions
4534 were already external.
4536 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4537 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4538 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4539 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4540 * keyboard.c, keymap.c, lread.c:
4541 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4542 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4543 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4544 Mark functions with DEFUE instead of DEFUN,
4545 if they are used in other modules.
4546 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4547 decls for now-static functions.
4548 * buffer.h (Fdelete_overlay): Remove decl.
4549 * callproc.c (Fgetenv_internal): Mark as internal.
4550 * composite.c (Fremove_list_of_text_properties): Remove decl.
4551 (Fcomposition_get_gstring): New forward static decl.
4552 * composite.h (Fcomposite_get_gstring): Remove decl.
4553 * dired.c (Ffile_attributes): New forward static decl.
4554 * doc.c (Fdocumntation_property): New forward static decl.
4555 * eval.c (Ffetch_bytecode): New forward static decl.
4556 (Funintern): Remove extern decl; now in .h file where it belongs.
4557 * fileio.c (Fmake_symbolic_link): New forward static decl.
4558 * image.c (Finit_image_library): New forward static decl.
4559 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4560 * intervals.h (Fprevious_property_change):
4561 (Fremove_list_of_text_properties): Remove decls.
4562 * keyboard.c (Fthis_command_keys): Remove decl.
4563 (Fcommand_execute): New forward static decl.
4564 * keymap.c (Flookup_key): New forward static decl.
4565 (Fcopy_keymap): Now static.
4566 * keymap.h (Flookup_key): Remove decl.
4567 * process.c (Fget_process): New forward static decl.
4568 (Fprocess_datagram_address): Mark as internal.
4569 * syntax.c (Fsyntax_table_p): New forward static decl.
4570 (skip_chars): Remove duplicate decl.
4571 * textprop.c (Fprevious_property_change): New forward static decl.
4572 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4574 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4575 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4577 * editfns.c (Fformat): Remove unreachable code.
4579 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4581 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4584 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4586 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4587 when at ZV. (Bug#8487)
4589 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4591 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4593 * keyboard.c (parse_tool_bar_item): Likewise.
4594 * sound.c (sound_cleanup, alsa_close): Likewise.
4595 * termcap.c (tgetent): Likewise.
4596 * xfns.c (x_default_font_parameter): Likewise.
4597 * xsettings.c (read_and_apply_settings): Likewise.
4599 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4600 (overrun_check_free): Protoize.
4602 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4604 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4605 since callers should never pass a negative size.
4606 Change the signature to match that of plain 'read' and 'write'; see
4607 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4608 * lisp.h: Update prototypes of emacs_write and emacs_read.
4610 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4612 * xdisp.c (redisplay_window): Don't try to determine the character
4613 position of the scroll margin if the window start point w->startp
4614 is outside the buffer's accessible region. (Bug#8468)
4616 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4618 Fix write-region and its subroutines for buffers > 2GB.
4619 * fileio.c (a_write, e_write): Modify declaration of arguments and
4620 local variables to support buffers larger than 2GB.
4621 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4623 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4624 argument, local variables, and return value.
4626 * lisp.h: Update prototypes of emacs_write and emacs_read.
4628 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4630 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4632 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4634 Fix more problems found by GCC 4.6.0's static checks.
4636 * xdisp.c (vmessage): Use a better test for character truncation.
4638 * charset.c (load_charset_map): <, not <=, for optimization,
4639 and to avoid potential problems with integer overflow.
4640 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4641 * casetab.c (set_identity, shuffle): Likewise.
4642 * editfns.c (Fformat): Likewise.
4643 * syntax.c (skip_chars): Likewise.
4645 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4646 This also lets GCC 4.6.0 generate slightly better loop code.
4648 * callint.c (Fcall_interactively): <, not <=, for optimization.
4649 (Fcall_interactively): Count the number of arguments produced,
4650 not the number of arguments given. This is simpler and lets GCC
4651 4.6.0 generate slightly better code.
4653 * ftfont.c: Distingish more carefully between FcChar8 and char.
4654 The previous code passed unsigned char * to a functions like
4655 strlen and xstrcasecmp that expect char *, which does not
4656 conform to the C standard.
4657 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4658 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4659 char * when the C standard requires it.
4661 * keyboard.c (read_char): Remove unused var.
4663 * eval.c: Port to Windows vsnprintf (Bug#8435).
4665 (SIZE_MAX): Define if the headers do not.
4666 (verror): Do not give up if vsnprintf returns a negative count.
4667 Instead, grow the buffer. This ports to Windows vsnprintf, which
4668 does not conform to C99. Problem reported by Eli Zaretskii.
4669 Also, simplify the allocation scheme, by avoiding the need for
4670 calling realloc, and removing the ALLOCATED variable.
4672 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4674 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4675 But keep the doprint source code for now, as we might revamp it
4676 and use it again (Bug#8435).
4677 * lisp.h (doprnt): Remove.
4678 * Makefile.in (base_obj): Remove doprnt.o.
4679 * deps.mk (doprnt.o): Remove.
4681 error: Print 32- and 64-bit integers portably (Bug#8435).
4682 Without this change, on typical 64-bit hosts error ("...%d...", N)
4683 was used to print both 32- and 64-bit integers N, which relied on
4685 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4687 * lisp.h (error, verror): Mark as printf-like functions.
4688 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4689 Report overflow in size calculations when allocating printf buffer.
4690 Do not truncate output string at its first null byte.
4691 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4692 Truncate the output at a character boundary, since vsnprintf does not
4694 * charset.c (check_iso_charset_parameter): Convert internal
4695 character to string before calling 'error', since %c now has the
4697 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4698 overflow when computing char to be passed to 'error'. Do not
4699 pass Lisp_Object to 'error'; pass the integer instead.
4700 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4701 formatted with plain %d.
4703 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4705 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4707 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4709 * xterm.c (x_catch_errors): Remove duplicate declaration.
4711 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4713 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4715 2011-04-10 Jim Meyering <meyering@redhat.com>
4717 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4718 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4719 return ssize_t not "int", and use size_t as the buffer length.
4720 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4721 * gnutls.h: Update declarations.
4722 * process.c (read_process_output): Use ssize_t, to match.
4723 (send_process): Likewise.
4725 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4727 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4729 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4731 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4732 Use unsigned char, to match FcChar8 type definition.
4734 * xterm.c (handle_one_xevent):
4735 * xmenu.c (create_and_show_popup_menu):
4736 * xselect.c (x_decline_selection_request)
4737 (x_reply_selection_request): Avoid type-punned deref of X events.
4739 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4741 Fix some uses of `int' instead of EMACS_INT.
4742 * search.c (string_match_1, fast_string_match)
4743 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4744 (scan_buffer, find_next_newline_no_quit)
4745 (find_before_next_newline, search_command, Freplace_match)
4746 (Fmatch_data): Make some `int' variables be EMACS_INT.
4748 * xdisp.c (display_count_lines): 3rd argument and return value now
4749 EMACS_INT. All callers changed.
4750 (pint2hrstr): Last argument is now EMACS_INT.
4752 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4753 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4754 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4755 (decode_coding_utf_16, decode_coding_emacs_mule)
4756 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4757 (decode_coding_ccl, decode_coding_charset)
4758 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4759 (decode_coding_iso_2022, decode_coding_emacs_mule)
4760 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4761 <char_offset, last_offset>: Declare EMACS_INT.
4762 (encode_coding_utf_8, encode_coding_utf_16)
4763 (encode_coding_emacs_mule, encode_invocation_designation)
4764 (encode_designation_at_bol, encode_coding_iso_2022)
4765 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4766 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4768 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4769 (encode_invocation_designation): Last argument P_NCHARS is now
4771 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4772 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4774 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4777 * ccl.c (Fccl_execute_on_string): Declare some variables
4780 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4782 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4784 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4786 * process.c (Fformat_network_address): Doc fix.
4788 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4790 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4792 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4794 * keyboard.c (read_char): Call Lisp function help-form-show,
4795 instead of using internal_with_output_to_temp_buffer.
4796 (Qhelp_form_show): New var.
4797 (syms_of_keyboard): Use DEFSYM macro.
4799 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4801 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4803 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4805 * process.c (Flist_processes): Remove to Lisp.
4806 (list_processes_1): Delete.
4808 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4810 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4812 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4814 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4816 Fix more problems found by GCC 4.6.0's static checks.
4818 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4820 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4822 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4824 * xdisp.c (vmessage): Mark as a printf-like function.
4826 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4828 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4830 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4831 printf-like functions.
4832 (tiff_load): Add casts to remove these marks before passing them
4833 to system-supplied API.
4835 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4837 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4838 This avoids several warnings with gcc -Wstrict-overflow.
4839 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4840 directly, rather than having caller test rule sign. This avoids
4841 some unnecessary tests.
4842 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4843 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4844 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4846 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4847 (xfont_open): Avoid unnecessary tests.
4849 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4851 * composite.h, composite.c (composition_gstring_put_cache):
4852 Use EMACS_INT, not int, for length.
4854 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4855 breaking out part of COMPOSITION_DECODE_RULE.
4856 (COMPOSITION_DECODE_RULE): Use it.
4857 * composite.c (get_composition_id): Remove unused local vars,
4858 by using the new macro.
4860 * textprop.c (set_text_properties_1): Change while to do-while,
4861 since the condition is always true at first.
4863 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4864 (interval_deletion_adjustment): Return unsigned value.
4867 * process.c (list_processes_1, create_pty, read_process_output):
4868 (exec_sentinel): Remove vars that were set but not used.
4869 (create_pty): Remove unnecessary "volatile"s.
4870 (Fnetwork_interface_info): Avoid possibility of int overflow.
4871 (read_process_output): Do adaptive read buffering even if carryover.
4872 (read_process_output): Simplify nbytes computation if buffered.
4874 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4876 * syntax.c (scan_words): Remove var that was set but not used.
4877 (update_syntax_table): Use unsigned instead of int.
4879 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4880 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4881 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4883 * print.c (print_error_message): Avoid int overflow.
4885 * font.c (font_list_entities): Redo for clarity,
4886 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4888 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4889 (font_score): Avoid potential overflow in diff calculation.
4891 * fns.c (substring_both): Remove var that is set but not used.
4892 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4894 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4896 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4897 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4898 can always succeed if overflow has undefined behavior.
4900 * search.c (boyer_moore, wordify): Remove vars set but not used.
4901 (wordify): Omit three unnecessary tests.
4903 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4904 All callers changed. This avoids the need for an unused var.
4906 * casefiddle.c (casify_region): Remove var that is set but not used.
4908 * dired.c (file_name_completion): Remove var that is set but not used.
4910 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4912 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4913 (Finsert_file_contents): Remove unnecessary code checking fd.
4915 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4916 Check for integer overflow on size calculations.
4918 * buffer.c (Fprevious_overlay_change): Remove var that is set
4921 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4922 Remove vars that are set but not used.
4923 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4924 (timer_check_2): Mark vars as initialized.
4926 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4928 * image.c (lookup_image): Remove var that is set but not used.
4929 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4931 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4932 that are set but not used.
4934 * xfns.c (make_invisible_cursor): Don't return garbage
4935 if XCreateBitmapFromData fails (Bug#8410).
4937 * xselect.c (x_get_local_selection, x_handle_property_notify):
4938 Remove vars that are set but not used.
4940 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4941 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4943 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4944 Remove var that is set but not used.
4945 (scroll_bar_windows_size): Now size_t, not int.
4946 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4949 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4950 (map_tty_color) [!defined MSDOS]: Likewise.
4952 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4954 * coding.c: Remove vars that are set but not used.
4955 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4956 All callers changed.
4957 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4958 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4959 (decode_coding_charset): Remove vars that are set but not used.
4961 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4962 that is set but not used.
4964 * print.c (print_object): Remove var that is set but not used.
4966 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4967 The gnulib version avoids calling malloc in the usual case,
4968 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4969 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4970 * filelock.c (current_lock_owner): Likewise.
4971 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4972 * sysdep.c: Include allocator.h, careadlinkat.h.
4973 (emacs_no_realloc_allocator): New static constant.
4974 (emacs_readlink): New function.
4975 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4976 ../lib/careadlinkat.h.
4978 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4980 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4981 first non-nil return value).
4983 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4985 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4986 if not defined (Bug#8403).
4988 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4990 * xdisp.c (display_count_lines): Remove parameter `start',
4991 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4992 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4993 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4994 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4995 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4996 and thereabouts. All callers changed.
4997 (get_per_char_metric): Remove parameter `f', unused since
4998 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5000 2011-04-02 Jim Meyering <meyering@redhat.com>
5002 do not dereference NULL upon failed strdup
5003 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5004 (ns_get_family): Likewise.
5006 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5008 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5010 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5012 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5015 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5017 Add lexical binding.
5019 * window.c (Ftemp_output_buffer_show): New fun.
5020 (Fsave_window_excursion):
5021 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5023 * lread.c (lisp_file_lexically_bound_p): New function.
5024 (Fload): Bind Qlexical_binding.
5025 (readevalloop): Remove `evalfun' arg.
5026 Bind Qinternal_interpreter_environment.
5027 (Feval_buffer): Bind Qlexical_binding.
5028 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5030 (syms_of_lread): Declare `lexical-binding'.
5032 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5034 * keyboard.c (eval_dyn): New fun.
5035 (menu_item_eval_property): Use it.
5037 * image.c (parse_image_spec): Use Ffunctionp.
5039 * fns.c (concat, mapcar1): Accept byte-code-functions.
5041 * eval.c (Fsetq): Handle lexical vars.
5042 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5043 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5044 (FletX, Flet): Obey lexical binding.
5045 (Fcommandp): Handle closures.
5046 (Feval): New `lexical' arg.
5047 (eval_sub): New function extracted from Feval. Use it almost
5048 everywhere where Feval was used. Look up vars in lexical env.
5050 (Ffunctionp): Move from subr.el.
5051 (Ffuncall): Handle closures.
5052 (apply_lambda): Remove `eval_flags'.
5053 (funcall_lambda): Handle closures and new byte-code-functions.
5054 (Fspecial_variable_p): New function.
5055 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5056 but without exporting it to Lisp.
5058 * doc.c (Fdocumentation, store_function_docstring):
5059 * data.c (Finteractive_form): Handle closures.
5061 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5064 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5066 (exec_byte_code): New function extracted from Fbyte_code to handle new
5067 calling convention for byte-code-functions. Add new byte-codes.
5069 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5071 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5073 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5075 * xdisp.c (redisplay_internal): Fix prototype.
5077 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5079 * xdisp.c (SCROLL_LIMIT): New macro.
5080 (try_scrolling): Use it when setting scroll_limit.
5081 Limit scrolling to 100 screen lines.
5082 (redisplay_window): Even when falling back on "recentering",
5083 position point in the window according to scroll-conservatively,
5084 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5086 (try_scrolling): When point is above the window, allow searching
5087 as far as scroll_max, or one screenful, to compute vertical
5088 distance from PT to the scroll margin position. This prevents
5089 try_scrolling from unnecessarily failing when
5090 scroll-conservatively is set to a value slightly larger than the
5091 window height. Clean up the case of PT below the margin at bottom
5092 of window: scroll_max can no longer be INT_MAX. When aggressive
5093 scrolling is in use, don't let point enter the opposite scroll
5094 margin as result of the scroll.
5095 (syms_of_xdisp) <scroll-conservatively>: Document the
5096 threshold of 100 lines for never-recentering scrolling.
5098 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5100 * dispextern.h (move_it_by_lines):
5101 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5102 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5103 (message_log_check_duplicate): Remove parameters `prev_bol' and
5104 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5105 (redisplay_internal): Remove parameter `preserve_echo_area',
5106 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5108 * indent.c (Fvertical_motion):
5109 * window.c (window_scroll_pixel_based, Frecenter):
5110 Don't pass `need_y_p' to `move_it_by_lines'.
5112 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5114 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5115 steal a few bits to be more compact.
5116 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5117 Remove unneeded casts.
5119 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5121 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5123 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5124 binding" message (bug#7967).
5126 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5128 Fix more problems found by GCC 4.6.0's static checks.
5130 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5131 Remove unused local var.
5133 * editfns.c (Fmessage_box): Remove unused local var.
5135 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5136 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5137 Omit unused local vars.
5138 * window.c (shrink_windows): Omit unused local var.
5139 * menu.c (digest_single_submenu): Omit unused local var.
5140 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5141 Omit unused local var.
5143 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5144 Don't assume string length fits in int.
5145 (keyremap_step, read_key_sequence): Use size_t for sizes.
5146 (read_key_sequence): Don't check last_real_key_start redundantly.
5148 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5149 instead of alloca (Bug#8344).
5151 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5152 (Fbacktrace_frame): Don't assume nframes fits in int.
5154 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5156 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5159 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5161 * cm.c (calccost): Turn while-do into do-while, for clarity.
5163 * keyboard.c (syms_of_keyboard): Use the same style as later
5164 in this function when indexing through an array. This also
5165 works around GCC bug 48267.
5167 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5169 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5171 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5172 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5174 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5175 This avoids undefined behavior on integer overflow, and is a bit
5176 more convenient anyway since it is compared to a size_t variable.
5178 Variadic C functions now count arguments with size_t, not int.
5179 This avoids an unnecessary limitation on 64-bit machines, which
5180 caused (substring ...) to crash on large vectors (Bug#8344).
5181 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5182 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5183 All variadic functions and their callers changed accordingly.
5184 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5185 * data.c (arith_driver, float_arith_driver): Likewise.
5186 * editfns.c (general_insert_function): Likewise.
5187 * eval.c (struct backtrace.nargs, interactive_p)
5188 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5189 (funcall_lambda, mark_backtrace): Likewise.
5190 * fns.c (concat): Likewise.
5191 * frame.c (x_set_frame_parameters): Likewise.
5192 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5193 0 if not found, not -1. All callers changed.
5195 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5196 (stack_copy_size): Now size_t, not int.
5197 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5199 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5201 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5202 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5203 All callers changed.
5205 * lisp.h (multibyte_char_to_unibyte):
5206 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5207 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5208 * character.h (CHAR_TO_BYTE8):
5209 * cmds.c (internal_self_insert):
5210 * editfns.c (general_insert_function):
5211 * keymap.c (push_key_description):
5212 * search.c (Freplace_match):
5213 * xdisp.c (message_dolog, set_message_1): All callers changed.
5215 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5217 * keyboard.c (safe_run_hook_funcall): New function.
5218 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5219 don't set the hook to nil, but remove the offending function instead.
5220 (Qcommand_hook_internal): Remove, unused.
5221 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5222 Vcommand_hook_internal.
5224 * eval.c (enum run_hooks_condition): Remove.
5225 (funcall_nil, funcall_not): New functions.
5226 (run_hook_with_args): Call each function through a `funcall' argument.
5227 Remove `cond' argument, now redundant.
5228 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5229 (Frun_hook_with_args_until_failure): Adjust accordingly.
5230 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5232 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5234 * dispextern.h (string_buffer_position): Remove declaration.
5236 * print.c (strout): Remove parameter `multibyte', unused since
5237 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5239 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5240 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5241 All callers changed.
5243 * w32.c (_wsa_errlist): Use braces for struct initializers.
5245 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5246 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5247 All callers changed.
5248 (string_buffer_position): Likewise. Also, make static (it's never
5249 used outside xdisp.c).
5250 (cursor_row_p): Remove parameter `w', unused since
5251 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5252 (decode_mode_spec): Remove parameter `precision', introduced during
5253 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5254 All callers changed.
5256 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5258 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5260 2011-03-27 Anders Lindgren <andlind@gmail.com>
5262 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5263 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5264 (ns_update_auto_hide_menu_bar): New functions.
5265 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5266 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5267 ns_constrain_all_frames.
5268 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5269 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5271 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5273 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5275 2011-03-27 Glenn Morris <rgm@gnu.org>
5277 * syssignal.h: Replace RETSIGTYPE with void.
5278 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5279 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5280 Replace SIGTYPE with void everywhere.
5281 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5282 * s/template.h (SIGTYPE): Remove commented out definition.
5284 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5286 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5287 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5289 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5291 * w32.c (read_unc_volume): Use parameter `henum', instead of
5292 global variable `wget_enum_handle'.
5294 * keymap.c (describe_vector): Remove parameters `indices' and
5295 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5296 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5298 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5300 * keyboard.c (timer_check): Remove parameter `do_it_now',
5301 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5302 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5303 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5305 * keyboard.c (read_char):
5306 * w32menu.c (w32_menu_display_help):
5307 * xmenu.c (show_help_event, menu_help_callback):
5308 Adjust calls to `show_help_echo'.
5310 * gtkutil.c (xg_maybe_add_timer):
5311 * keyboard.c (readable_events):
5312 * process.c (wait_reading_process_output):
5313 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5315 * insdel.c (adjust_markers_gap_motion):
5316 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5317 (gap_left, gap_right): Don't call it.
5319 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5321 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5322 incurred during fontification.
5324 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5326 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5327 (DEFVAR_PER_BUFFER): Don't pass it.
5329 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5330 (scrolling_window): Don't pass it.
5332 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5334 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5336 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5338 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5339 of variables specific to SELinux and computation of `encoded_absname'.
5341 * image.c (XPutPixel): Remove unused variable `height'.
5343 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5345 * unexw32.c (get_section_info): Remove unused variable `section'.
5347 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5348 (system_process_attributes): Remove unused variable `sess'.
5349 (sys_read): Remove unused variable `err'.
5351 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5352 (w32_wnd_proc): Remove unused variable `isdead'.
5353 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5354 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5355 (x_create_tip_frame): Remove unused variable `tem'.
5357 * w32inevt.c (w32_console_read_socket):
5358 Remove unused variable `no_events'.
5360 * w32term.c (x_draw_composite_glyph_string_foreground):
5361 Remove unused variable `width'.
5363 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5365 * w32term.c (x_set_glyph_string_clipping):
5366 Don't pass uninitialized region to CombineRgn.
5368 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5370 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5371 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5372 (Fx_close_connection): Remove unused variable `i'.
5374 * w32font.c (w32font_draw): Return number of glyphs.
5375 (w32font_open_internal): Remove unused variable `i'.
5376 (w32font_driver): Add missing initializer.
5378 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5379 (fill_in_menu): Remove unused variable `items_added'.
5381 * w32term.c (last_mouse_press_frame): Remove static global variable.
5382 (w32_clip_to_row): Remove unused variable `f'.
5383 (x_delete_terminal): Remove unused variable `i'.
5385 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5386 (NOTHING): Remove unused static global variable.
5387 (uniscribe_check_otf): Remove unused variable `table'.
5388 (uniscribe_font_driver): Add missing initializers.
5390 2011-03-23 Julien Danjou <julien@danjou.info>
5392 * term.c (Fsuspend_tty, Fresume_tty):
5393 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5394 * window.c (temp_output_buffer_show):
5395 * insdel.c (signal_before_change):
5396 * frame.c (Fhandle_switch_frame):
5397 * fileio.c (Fdo_auto_save):
5398 * emacs.c (Fkill_emacs):
5399 * editfns.c (save_excursion_restore):
5400 * cmds.c (internal_self_insert):
5401 * callint.c (Fcall_interactively):
5402 * buffer.c (Fkill_all_local_variables):
5403 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5405 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5406 unconditionnaly since it does the check itself.
5408 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5410 Fix more problems found by GCC 4.5.2's static checks.
5412 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5413 the first time through the loop, since we know p0 < p1 then.
5414 This also avoids a gcc -Wstrict-overflow warning.
5416 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5417 leading to a memory leak, possible in functions like
5418 load_charset_map_from_file that can allocate an unbounded number
5419 of objects (Bug#8318).
5421 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5422 that could (at least in theory) be that large.
5424 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5425 This is less likely to overflow, and avoids undefined behavior if
5426 overflow does occur. All callers changed. Use strtoul to scan
5427 for the unsigned long integer.
5428 (pint2hrstr): Simplify and tune code slightly.
5429 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5431 * scroll.c (do_scrolling): Work around GCC bug 48228.
5432 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5434 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5435 This also avoids a warning with gcc -Wstrict-overflow.
5436 (validate_x_resource_name): Simplify count usage.
5437 This also avoids a warning with gcc -Wstrict-overflow.
5439 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5442 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5444 * process.c (Fmake_network_process): Use socklen_t, not int,
5445 where POSIX says socklen_t is required in portable programs.
5446 This fixes a porting bug on hosts like 64-bit HP-UX, where
5447 socklen_t is wider than int (Bug#8277).
5448 (Fmake_network_process, server_accept_connection):
5449 (wait_reading_process_output, read_process_output):
5452 * process.c: Rename or move locals to avoid shadowing.
5453 (list_processes_1, Fmake_network_process):
5454 (read_process_output_error_handler, exec_sentinel_error_handler):
5455 Rename or move locals.
5456 (Fmake_network_process): Define label "retry_connect" only if needed.
5457 (Fnetwork_interface_info): Fix pointer signedness.
5458 (process_send_signal): Add cast to avoid pointer signedness problem.
5459 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5460 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5462 Make tparam.h and terminfo.c consistent.
5463 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5464 Include tparam.h instead, since it declares them.
5465 * cm.h (PC): Remove extern decl; tparam.h now does this.
5466 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5467 * terminfo.c: Include tparam.h, to check interfaces.
5468 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5469 (tparam): Adjust signature to match interface in tparam.h;
5470 this removes some undefined behavior. Check that outstring and len
5471 are zero, which they always are with Emacs.
5472 * tparam.h (PC, BC, UP): New extern decls.
5474 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5475 (xftfont_open): Rename locals to avoid shadowing.
5477 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5478 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5479 (OTF_TAG_SYM): Omit macro if not needed.
5480 (ftfont_list): Remove unused local.
5481 (get_adstyle_property, ftfont_pattern_entity):
5482 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5483 Rename locals to avoid shadowing.
5485 * xfont.c (xfont_list_family): Mark var as initialized.
5487 * xml.c (make_dom): Now static.
5489 * composite.c (composition_compute_stop_pos): Rename local to
5491 (composition_reseat_it): Remove unused locals.
5492 (find_automatic_composition, composition_adjust_point): Likewise.
5493 (composition_update_it): Mark var as initialized.
5494 (find_automatic_composition): Mark vars as initialized,
5495 with a FIXME (Bug#8290).
5497 character.h: Rename locals to avoid shadowing.
5498 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5499 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5500 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5501 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5504 * textprop.c (property_change_between_p): Remove; unused.
5506 * intervals.c (interval_start_pos): Now static.
5508 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5510 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5511 Rename locals to avoid shadowing.
5513 * sound.c (wav_play, au_play, Fplay_sound_internal):
5514 Fix pointer signedness.
5515 (alsa_choose_format): Remove unused local var.
5516 (wav_play): Initialize a variable to 0, to prevent undefined
5517 behavior (Bug#8278).
5519 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5521 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5523 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5524 clobbering (Bug#8298).
5525 * sysdep.c (sys_subshell): Likewise.
5526 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5528 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5529 This should get cleaned up, so that child_setup has the
5530 same signature on all platforms.
5532 * callproc.c (call_process_cleanup): Now static.
5533 (relocate_fd): Rename locals to avoid shadowing.
5535 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5537 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5538 not to be necessary, and produces flickering.
5540 2011-03-20 Glenn Morris <rgm@gnu.org>
5542 * config.in: Remove file.
5544 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5546 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5547 are now in src/globals.h.
5548 (syms_of_minibuf): Remove spurious & from previous change.
5550 2011-03-20 Leo <sdl.web@gmail.com>
5552 * minibuf.c (completing-read-function): New variable.
5553 (completing-read-default): Rename from completing-read.
5554 (completing-read): Call completing-read-function.
5556 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5558 * xfaces.c (Fx_load_color_file):
5559 Read color file from absolute filename (bug#8250).
5561 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5563 * makefile.w32-in: Update dependencies.
5565 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5567 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5569 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5571 Fix more problems found by GCC 4.5.2's static checks.
5573 * process.c (make_serial_process_unwind, send_process_trap):
5574 (sigchld_handler): Now static.
5576 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5577 That way, the code declares only the vars that it needs.
5578 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5579 * s/cygwin.h (PTY_ITERATION): Likewise.
5580 * s/darwin.h (PTY_ITERATION): Likewise.
5581 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5583 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5584 * process.c (allocate_pty): Don't declare stb unless it's needed.
5586 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5587 (CONSTANTLIM): Remove; unused.
5588 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5589 Define only if needed.
5591 * unexelf.c (unexec): Name an expression,
5592 to avoid gcc -Wbad-function-cast warning.
5593 Use a different way to cause a compilation error if anyone uses
5594 n rather than nn, a way that does not involve shadowing.
5595 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5597 * deps.mk (unexalpha.o): Remove; unused.
5599 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5600 * unexec.h: New file.
5601 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5602 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5604 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5605 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5606 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5607 Change as necessary to match prototype in unexec.h.
5609 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5611 (back_comment, skip_chars): Mark vars as initialized.
5613 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5614 Rename locals to avoid shadowing.
5616 * lread.c (read1): Rewrite so as not to use empty "else".
5617 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5619 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5621 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5622 warning when compiling print.c.
5624 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5625 instead of using an uninitialized var.
5626 (font_sort_entities): Mark var as initialized.
5628 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5630 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5631 pointers to constants.
5632 (font_parse_fcname): Remove unused vars.
5633 (font_delete_unmatched): Now static.
5634 (font_get_spec): Remove; unused.
5635 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5636 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5637 Rename or move locals to avoid shadowing.
5639 * fns.c (require_nesting_list, require_unwind): Now static.
5640 (Ffillarray): Rename locals to avoid shadowing.
5642 * floatfns.c (domain_error2): Define only if needed.
5643 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5645 * alloc.c (mark_backtrace): Move decl from here ...
5646 * lisp.h: ... to here, so that it can be checked.
5648 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5649 (Fdefvar): Rewrite so as not to use empty "else".
5650 (lisp_indirect_variable): Name an expression,
5651 to avoid gcc -Wbad-function-cast warning.
5652 (Fdefvar): Rename locals to avoid shadowing.
5654 * callint.c (quotify_arg, quotify_args): Now static.
5655 (Fcall_interactively): Rename locals to avoid shadowing.
5656 Use const pointer when appropriate.
5658 * lisp.h (get_system_name, get_operating_system_release):
5659 Move decls here, to check interfaces.
5660 * process.c (get_operating_system_release): Move decl to lisp.h.
5661 * xrdb.c (get_system_name): Likewise.
5662 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5663 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5664 some of which prompt warnings from gcc -Wbad-function-cast.
5665 (Fformat_time_string, Fencode_time, Finsert_char):
5666 (Ftranslate_region_internal, Fformat):
5667 Rename or remove local vars to avoid shadowing.
5668 (Ftranslate_region_internal): Mark var as initialized.
5670 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5673 * lisp.h (eassert): Check that the argument compiles, even if
5674 ENABLE_CHECKING is not defined.
5676 * data.c (Findirect_variable): Name an expression, to avoid
5677 gcc -Wbad-function-cast warning.
5678 (default_value, arithcompare, arith_driver, arith_error): Now static.
5679 (store_symval_forwarding): Rename local to avoid shadowing.
5680 (Fmake_variable_buffer_local, Fmake_local_variable):
5681 Mark variables as initialized.
5682 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5684 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5685 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5686 Rename locals to avoid shadowing.
5687 (mark_stack): Move local variables into the #ifdef region where
5689 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5690 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5692 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5693 (GC_STRING_CHARS): Remove; not used.
5694 (Fmemory_limit): Cast sbrk's returned value to char *.
5696 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5697 avoids undefined behavior in theory.
5699 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5701 Use functions, not macros, for up- and down-casing (Bug#8254).
5702 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5703 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5704 to use the following functions instead of these macros.
5705 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5706 EMACS_INT, since callers assume the returned value fits in int.
5707 (upcase1): Likewise, for UPCASE_TABLE.
5708 (uppercasep, lowercasep, upcase): New static inline functions.
5709 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5710 the race-condition problem in the old DOWNCASE.
5712 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5713 Rename locals to avoid shadowing.
5714 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5715 (regex_compile, re_search_2, re_match_2_internal):
5716 Remove unused local vars.
5717 (FREE_VAR): Rewrite so as not to use empty "else",
5718 which gcc can warn about.
5719 (regex_compile, re_match_2_internal): Mark locals as initialized.
5720 (RETALLOC_IF): Define only if needed.
5721 (WORDCHAR_P): Likewise. This one is never needed, but is used
5722 only in a comment talking about a compiler bug, so put inside
5723 the #if 0 of that comment.
5724 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5725 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5728 * search.c (boyer_moore): Rename locals to avoid shadowing.
5729 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5730 (PREV_CHAR_BOUNDARY): Likewise.
5732 * search.c (simple_search): Remove unused var.
5734 * dired.c (compile_pattern): Move decl from here ...
5735 * lisp.h: ... to here, so that it can be checked.
5736 (struct re_registers): New forward decl.
5738 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5740 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5742 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5743 Rename locals to avoid shadowing.
5744 (Fvertical_motion): Mark locals as initialized.
5746 * casefiddle.c (casify_object, casify_region): Now static.
5747 (casify_region): Mark local as initialized.
5749 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5751 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5752 New macros, so that the caller can use some names other than
5753 gcpro1, gcpro2, etc.
5754 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5756 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5757 argument, for consistency with GCPRO2_VAR, etc: it is now the
5758 prefix of the variable, not the variable itself. All uses
5760 * dired.c (directory_files_internal, file_name_completion):
5761 Rename locals to avoid shadowing.
5763 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5764 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5765 dired.c's scmp function, had undefined behavior.
5766 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5767 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5768 * buffer.h: ... to here, because these macros use current_buffer,
5769 and the new implementation with inline functions needs to have
5770 current_buffer in scope now, rather than later when the macros
5772 (downcase, upcase1): New static inline functions.
5773 (DOWNCASE, UPCASE1): Reimplement using these functions.
5774 This avoids undefined behavior in expressions like
5775 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5776 from race conditions in accessing the global variables
5777 case_temp1 and case_temp2.
5778 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5779 * lisp.h (case_temp1, case_temp2): Remove their decls.
5780 * character.h (ASCII_CHAR_P): Move from here ...
5781 * lisp.h: ... to here, so that the inline functions mentioned
5784 * dired.c (directory_files_internal_unwind): Now static.
5786 * fileio.c (file_name_as_directory, directory_file_name):
5787 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5789 (file_name_as_directory): Use const pointers when appropriate.
5790 (Fexpand_file_name): Likewise. In particular, newdir might
5791 point at constant storage, so make it a const pointer.
5792 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5793 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5795 (Fset_file_times, Finsert_file_contents, auto_save_error):
5796 Rename locals to avoid shadowing.
5798 * minibuf.c (choose_minibuf_frame_1): Now static.
5799 (Ftry_completion, Fall_completions): Rename or remove locals
5802 * marker.c (bytepos_to_charpos): Remove; unused.
5804 * lisp.h (verify_bytepos, count_markers): New decls,
5805 so that gcc does not warn that these functions aren't declared.
5807 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5808 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5809 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5810 (copy_text): Remove unused local var.
5812 * filelock.c (within_one_second): Now static.
5813 (lock_file_1): Rename local to avoid shadowing.
5815 * buffer.c (fix_overlays_before): Mark locals as initialized.
5816 (fix_start_end_in_overlays): Likewise. This function should be
5817 simplified by using pointers-to-pointers, but that's a different
5819 (switch_to_buffer_1): Now static.
5820 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5821 (report_overlay_modification): Rename locals to avoid shadowing.
5823 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5824 Fix pointer signedness issue.
5825 (sys_subshell): Mark local as volatile if checking for lint,
5826 to suppress a gcc -Wclobbered warning that does not seem to be right.
5827 (MAXPATHLEN): Define only if needed.
5829 * process.c (serial_open, serial_configure): Move decls from here ...
5830 * systty.h: ... to here, so that they can be checked.
5832 * fns.c (get_random, seed_random): Move extern decls from here ...
5833 * lisp.h: ... to here, so that they can be checked.
5835 * sysdep.c (reset_io): Now static.
5836 (wait_for_termination_signal): Remove; unused.
5838 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5839 (copy_keymap_item, append_key, push_text_char_description):
5841 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5842 (DENSE_TABLE_SIZE): Remove; unused.
5843 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5844 (describe_map_tree):
5845 Rename locals to avoid shadowing.
5847 * keyboard.c: Declare functions static if they are not used elsewhere.
5848 (echo_char, echo_dash, cmd_error, top_level_2):
5849 (poll_for_input, handle_async_input): Now static.
5850 (read_char, kbd_buffer_get_event, make_lispy_position):
5851 (make_lispy_event, make_lispy_movement, apply_modifiers):
5852 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5853 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5854 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5855 (read_key_sequence, read_char): Mark locals as initialized.
5856 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5858 * keyboard.h (make_ctrl_char): New decl.
5859 (mark_kboards): Move decl here ...
5860 * alloc.c (mark_kboards): ... from here.
5862 * lisp.h (force_auto_save_soon): New decl.
5864 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5865 (DEFINE_DUMMY_FUNCTION): New macro.
5866 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5868 (main): Add casts to avoid warnings
5869 if GCC considers string literals to be constants.
5871 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5873 * dbusbind.c: Pointer signedness fixes.
5874 (xd_signature, xd_append_arg, xd_initialize):
5875 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5876 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5877 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5878 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5880 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5881 if GCC considers string literals to be constants.
5882 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5884 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5886 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5887 (print_preprocess, print_object): New macro to fix last change.
5889 * print.c (print_preprocess): Don't forget font objects.
5891 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5893 * emacs.c (USAGE3): Doc fixes.
5895 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5897 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5900 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5902 * lisp.h (VWindow_system, Qfile_name_history):
5903 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5904 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5905 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5907 * w32select.c: Don't #include "keyboard.h".
5908 (run_protected): Add extern declaration for waiting_for_input.
5910 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5911 * w32console.c (detect_input_pending, read_input_pending)
5912 (encode_terminal_code):
5913 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5914 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5915 (w32_system_caret_y, Qfile_name_history):
5916 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5917 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5918 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5919 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5920 * w32proc.c (Qlocal, report_file_error):
5921 * w32term.c (Vwindow_system, updating_frame):
5922 * w32uniscribe.c (initialized, uniscribe_font_driver):
5923 Remove unneeded extern declarations.
5925 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5927 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5929 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
5931 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5932 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5933 These macros can no longer be used for assignment.
5935 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5936 Assign struct members directly, instead of using BUF_BEGV etc.
5937 (record_buffer_markers, fetch_buffer_markers): New functions for
5938 recording and fetching special buffer markers.
5939 (set_buffer_internal_1, set_buffer_temp): Use them.
5941 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5943 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5945 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5946 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5948 * xdisp.c (hscroll_window_tree):
5949 (reconsider_clip_changes): Use PT instead of BUF_PT.
5951 2011-03-13 Eli Zaretskii <eliz@gnu.org>
5953 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5954 $(EMACS_ROOT)/lib/intprops.h.
5956 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5958 Fix more problems found by GCC 4.5.2's static checks.
5960 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5961 to unsigned char * to avoid compiler diagnostic.
5962 (xg_free_frame_widgets): Make it clear that a local variable is
5963 needed only if USE_GTK_TOOLTIP.
5964 (gdk_window_get_screen): Make it clear that this macro is needed
5965 only if USE_GTK_TOOLTIP.
5966 (int_gtk_range_get_value): New function, which avoids a diagnostic
5967 from gcc -Wbad-function-cast.
5968 (xg_set_toolkit_scroll_bar_thumb): Use it.
5969 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5970 diagnostic from gcc -Wbad-function-cast.
5971 (get_utf8_string, xg_get_file_with_chooser):
5972 Rename locals to avoid shadowing.
5973 (create_dialog): Move locals to avoid shadowing.
5975 * xgselect.c (xg_select): Remove unused var.
5977 * image.c (four_corners_best): Mark locals as initialized.
5978 (gif_load): Initialize transparent_p to zero (Bug#8238).
5979 Mark another local as initialized.
5980 (my_png_error, my_error_exit): Mark with NO_RETURN.
5982 * image.c (clear_image_cache): Now static.
5983 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5984 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5985 (x_edge_detection): Remove unnecessary cast that
5986 gcc -Wbad-function-cast diagnoses.
5987 (gif_load): Fix pointer signedness.
5988 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5989 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5991 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5993 Improve quality of tests for time stamp overflow.
5994 For example, without this patch (encode-time 0 0 0 1 1
5995 1152921504606846976) returns the obviously-bogus value (-948597
5996 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5997 reports time overflow. See
5998 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5999 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6000 * editfns.c: Include limits.h and intprops.h.
6001 (TIME_T_MIN, TIME_T_MAX): New macros.
6002 (time_overflow): Move earlier, to before first use.
6003 (hi_time, lo_time): New functions, for an accurate test for
6005 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6006 (Fget_internal_run_time): Don't assume time_t fits in int.
6007 (make_time): Use list2 instead of Fcons twice.
6008 (Fdecode_time): More accurate test for out-of-range times.
6009 (check_tm_member): New function.
6010 (Fencode_time): Use it, to test for out-of-range times.
6011 (lisp_time_argument): Don't rely on undefined left-shift and
6012 right-shift behavior when checking for time stamp overflow.
6014 * editfns.c (time_overflow): New function, refactoring common code.
6015 (Fformat_time_string, Fdecode_time, Fencode_time):
6016 (Fcurrent_time_string): Use it.
6018 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6019 * dired.c (make_time): Move to ...
6020 * editfns.c (make_time): ... here.
6021 * systime.h: Note the move.
6023 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6025 * fringe.c (update_window_fringes): Remove unused variables.
6027 * unexmacosx.c (copy_data_segment): Also copy __got section.
6030 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6032 * termcap.c [MSDOS]: Include "msdos.h".
6033 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6034 Constify `char *' arguments and their references according to
6035 prototypes in tparam.h.
6037 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6039 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6040 Adapt all references accordingly.
6042 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6044 2011-03-11 Tom Tromey <tromey@redhat.com>
6046 * buffer.c (syms_of_buffer): Remove obsolete comment.
6048 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6050 * termhooks.h (encode_terminal_code): Declare prototype.
6052 * msdos.c (encode_terminal_code): Don't declare prototype.
6054 * term.c (encode_terminal_code): Now external again, used by
6055 w32console.c and msdos.c.
6057 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6058 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6060 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6062 Fix some minor problems found by GCC 4.5.2's static checks.
6064 * fringe.c (update_window_fringes): Mark locals as initialized
6066 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6068 * alloc.c (mark_fringe_data): Move decl from here ...
6069 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6070 to check its interface.
6071 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6073 * fontset.c (free_realized_fontset): Now static.
6074 (Fset_fontset_font): Rename local to avoid shadowing.
6075 (fontset_font): Mark local as initialized.
6076 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6078 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6080 * xselect.c (x_disown_buffer_selections): Remove; not used.
6081 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6082 (x_own_selection, Fx_disown_selection_internal): Rename locals
6084 (x_handle_dnd_message): Remove local to avoid shadowing.
6086 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6087 so that the caller can use some name other than gcpro1.
6088 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6089 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6090 (Fx_backspace_delete_keys_p):
6091 Use them to avoid shadowing, and rename vars to avoid shadowing.
6092 (x_decode_color, x_set_name, x_window): Now static.
6093 (Fx_create_frame): Add braces to silence GCC warning.
6094 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6095 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6096 Remove unused locals.
6097 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6098 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6099 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6102 * xterm.h (x_mouse_leave): New decl.
6104 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6105 Remove unused functions.
6106 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6107 (x_calc_absolute_position): Now static.
6108 (XTread_socket): Don't define label "out" unless it's used.
6109 Don't declare local "event" unless it's used.
6110 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6111 unless they are used.
6112 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6113 (x_fatal_error_signal): Remove; not used.
6114 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6115 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6116 (x_error_catcher, x_connection_closed, x_error_handler):
6117 (x_error_quitter, xembed_send_message, x_iconify_frame):
6118 (my_log_handler): Rename locals to avoid shadowing.
6119 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6120 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6122 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6123 Rename or move locals to avoid shadowing.
6124 (tty_defined_color, merge_face_heights): Now static.
6125 (free_realized_faces_for_fontset): Remove; not used.
6126 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6127 does not deduce is never used uninitialized.
6128 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6129 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6131 * terminal.c (store_terminal_param): Now static.
6133 * xmenu.c (menu_highlight_callback): Now static.
6134 (set_frame_menubar): Remove unused local.
6135 (xmenu_show): Rename parameter to avoid shadowing.
6136 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6137 since they might point to immutable storage.
6138 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6139 since it's unused otherwise.
6141 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6142 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6143 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6144 avoids a gcc -Wuninitialized diagnostic.
6145 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6146 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6147 does not deduce are never used uninitialized.
6149 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6151 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6152 * window.c (window_loop, size_window):
6153 (run_window_configuration_change_hook, enlarge_window): Likewise.
6155 * window.c (display_buffer): Now static.
6156 (size_window): Mark variables that gcc -Wuninitialized
6157 does not deduce are never used uninitialized.
6158 * window.h (check_all_windows): New decl, to forestall
6159 gcc -Wmissing-prototypes diagnostic.
6160 * dispextern.h (bidi_dump_cached_states): Likewise.
6162 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6164 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6166 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6167 and to avoid gcc -Wuninitialized warning.
6168 (load_charset_map): Mark variables that gcc -Wuninitialized
6169 does not deduce are never used uninitialized.
6170 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6172 * coding.c (coding_set_source, coding_set_destination):
6173 Use "else { /* comment */ }" rather than "else /* comment */;"
6174 for clarity, and to avoid gcc -Wempty-body warning.
6175 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6176 a block, when the outer 'i' will do.
6177 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6178 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6179 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6180 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6181 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6182 Rename locals to avoid shadowing.
6183 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6184 * coding.c (emacs_mule_char, encode_invocation_designation):
6185 Now static, since they're not used elsewhere.
6186 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6187 (decode_coding_object, encode_coding_object, detect_coding_system):
6188 (decode_coding_emacs_mule): Mark variables that gcc
6189 -Wuninitialized does not deduce are never used uninitialized.
6190 (detect_coding_iso_2022): Initialize a local variable that might
6191 be used uninitialized. Leave a FIXME because it's not clear that
6192 this initialization is needed. (Bug#8211)
6193 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6194 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6195 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6196 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6197 Remove unused macros.
6199 * category.c (hash_get_category_set): Remove unused local var.
6200 (copy_category_table): Now static, since it's not used elsewhere.
6201 * character.c (string_count_byte8): Likewise.
6203 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6204 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6206 * chartab.c (copy_sub_char_table): Now static, since it's not used
6208 (sub_char_table_ref_and_range, char_table_ref_and_range):
6209 Rename locals to avoid shadowing.
6210 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6212 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6213 (BIDI_BOB): Remove unused macro.
6215 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6216 deduce are never used uninitialized.
6217 * term.c (encode_terminal_code): Likewise.
6219 * term.c (encode_terminal_code): Now static. Remove unused local.
6221 * tparam.h: New file.
6222 * term.c, tparam.h: Include it.
6223 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6224 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6225 Move these decls to tparam.h, and make them agree with what
6226 is actually in tparam.c. The previous trick of using incompatible
6227 decls in different modules does not conform to the C standard.
6228 All callers of tparam changed to use tparam's actual API.
6229 * tparam.c (tparam1, tparam, tgoto):
6230 Use const pointers where appropriate.
6232 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6233 * cm.h (struct cm): Likewise.
6234 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6235 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6236 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6237 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6238 (turn_on_face, init_tty): Likewise.
6239 * termchar.h (struct tty_display_info): Likewise.
6241 * term.c (term_mouse_position): Rename local to avoid shadowing.
6243 * alloc.c (mark_ttys): Move decl from here ...
6244 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6246 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6248 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6250 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6252 * search.c (compile_pattern_1): Remove argument regp, unused since
6253 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6254 (compile_pattern): Don't pass it.
6256 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6258 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6259 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6261 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6263 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6265 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6266 gdk_window_get_screen, gdk_window_get_geometry,
6267 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6268 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6269 (xg_get_pixbuf_from_pixmap): New function.
6270 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6271 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6272 Call xg_get_pixbuf_from_pixmap instead of
6273 gdk_pixbuf_get_from_drawable.
6274 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6275 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6276 (xg_check_special_colors): Use GtkStyleContext and its functions
6278 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6279 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6280 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6281 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6282 Call gtk_widget_get_preferred_size.
6283 (xg_frame_resized): gdk_window_get_geometry only takes 5
6285 (xg_win_to_widget, xg_event_is_for_menubar):
6286 Call gdk_x11_window_lookup_for_display.
6287 (xg_set_widget_bg): New function.
6288 (delete_cb): New function.
6289 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6290 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6291 (xg_set_background_color): Call xg_set_widget_bg.
6292 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6293 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6294 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6295 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6297 (update_frame_tool_bar): Call gtk_widget_hide.
6298 (xg_initialize): Use GDK_KEY_g.
6300 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6302 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6304 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6305 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6306 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6308 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6310 * w32xfns.c (select_palette): Check success of RealizePalette against
6311 GDI_ERROR, not zero.
6313 See ChangeLog.11 for earlier changes.
6319 Copyright (C) 2011 Free Software Foundation, Inc.
6321 This file is part of GNU Emacs.
6323 GNU Emacs is free software: you can redistribute it and/or modify
6324 it under the terms of the GNU General Public License as published by
6325 the Free Software Foundation, either version 3 of the License, or
6326 (at your option) any later version.
6328 GNU Emacs is distributed in the hope that it will be useful,
6329 but WITHOUT ANY WARRANTY; without even the implied warranty of
6330 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6331 GNU General Public License for more details.
6333 You should have received a copy of the GNU General Public License
6334 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.