1 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3 * buffer.c (Fget_buffer_create): Initialized inhibit_shrinking.
4 The old code sometimes used this field without initializing it.
6 * alloc.c (gc_sweep): Don't read past end of array.
7 In theory, the old code could also have corrupted Emacs internals,
8 though it'd be very unlikely.
10 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
12 * character.c (Fcharacterp): Don't advertise optional ignored
15 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
17 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
20 * window.c (Fset_window_start): Doc fix (bug#4199).
21 (Fset_window_hscroll): Ditto.
23 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
25 Fix minor new problems caught by GCC 4.6.1.
26 * term.c (init_tty): Remove unused local.
27 * xsettings.c (store_monospaced_changed): Define this function only
28 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
31 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
33 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
35 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
37 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
38 are the mini-buffer and the echo area (bug#3320).
40 * term.c (init_tty): Remove support for supdup, c10 and perq
41 terminals, which are no longer supported (bug#1482).
43 2011-07-10 Johan Bockgård <bojohan@gnu.org>
45 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
47 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
49 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
50 for non-popups (Bug#3642).
52 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
54 * alloc.c (reset_malloc_hooks): Protoize.
55 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
56 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
57 * cm.c (losecursor): Likewise.
58 * data.c (fmod): Likewise.
59 * dispnew.c (swap_glyphs_in_rows): Likewise.
60 * emacs.c (memory_warning_signal): Likewise.
61 * floatfns.c (float_error): Likewise.
62 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
63 (otf_open, font_otf_capability, generate_otf_features)
64 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
66 * image.c (pbm_read_file): Likewise.
67 * indent.c (string_display_width): Likewise.
68 * intervals.c (check_for_interval, search_for_interval)
69 (inc_interval_count, count_intervals, root_interval)
70 (adjust_intervals_for_insertion, make_new_interval): Likewise.
71 * lread.c (defalias): Likewise.
72 * ralloc.c (r_alloc_check): Likewise.
73 * regex.c (set_image_of_range_1, set_image_of_range)
74 (regex_grow_registers): Likewise.
75 * sysdep.c (strerror): Likewise.
76 * termcap.c (valid_filename_p, tprint, main): Likewise.
77 * tparam.c (main): Likewise.
78 * unexhp9k800.c (run_time_remap, save_data_space)
79 (update_file_ptrs, read_header, write_header, calculate_checksum)
80 (copy_file, copy_rest, display_header): Likewise.
81 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
83 * xdisp.c (check_it): Likewise.
84 * xfaces.c (register_color, unregister_color, unregister_colors):
86 * xfns.c (print_fontset_result): Likewise.
87 * xrdb.c (member, fatal, main): Likewise.
89 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
91 Fix minor problems found by static checking (Bug#9031).
92 * chartab.c (char_table_set_range, map_sub_char_table):
94 (uniprop_table): Now static.
95 * composite.c (_work_char): Remove unused static var.
97 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
99 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
101 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
103 * gtkutil.c (qttip_cb): Remove code without function.
105 2011-07-09 Eli Zaretskii <eliz@gnu.org>
107 * w32.c (pthread_sigmask): New stub.
109 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
111 Use pthread_sigmask, not sigprocmask (Bug#9010).
112 sigprocmask is portable only for single-threaded applications, and
113 Emacs can be multi-threaded when it uses GTK.
114 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
116 * callproc.c (Fcall_process):
117 * process.c (create_process):
118 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
119 Use pthread_sigmask, not sigprocmask.
121 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
123 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
124 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
127 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
129 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
130 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
131 (xg_hide_tooltip): Fix comment.
133 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
134 in registerServicesMenuSendTypes.
135 (validRequestorForSendType): Don't check ns_return_types.
137 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
140 2011-07-08 Jason Rumney <jasonr@gnu.org>
142 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
143 frame struct members of non-existent frames (Bug#6284).
145 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
147 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
148 variable firstTime not needed on OSX >= 10.6.
149 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
150 >= 10.5. Use setKnobProportion, setDoubleValue.
152 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
153 (MAC_OS_X_VERSION_10_5): Define if not defined.
154 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
155 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
156 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
158 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
159 cString and lossyCString on OSX >= 10.4
161 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
162 sizeToFit on OSX >= 10.2.
164 * nsimage.m (allocInitFromFile): Don't use deprecated method
165 bestRepresentationForDevice on OSX >= 10.6.
167 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
170 * emacs.c: Declare unexec_init_emacs_zone.
172 * nsgui.h: Fix compiler warning about gnulib redefining verify.
174 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
176 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
177 on svcsMenu (Bug#8842).
179 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
181 (Fns_list_services): Just return Qnil on 10.6, code not working there.
183 * nsterm.m (QUTF8_STRING): Declare.
184 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
185 (validRequestorForSendType): Return type is (id).
186 Change indexOfObjectIdenticalTo to indexOfObject.
187 Check if we have local selection before returning self (Bug#8842).
188 (writeSelectionToPasteboard): Put local selection into paste board
189 if we have a local selection (Bug#8842).
190 (syms_of_nsterm): DEFSYM QUTF8_STRING.
192 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
193 (ns_get_local_selection): Declare.
195 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
197 * keymap.c (describe_map_tree): Don't insert a double newline at
198 the end of the buffer (bug#1169) and return whether we inserted
201 * callint.c (Fcall_interactively): Change "reading args" to
202 "providing args" to try to clarify what it does (bug#1010).
204 2011-07-07 Kenichi Handa <handa@m17n.org>
206 * composite.c (composition_compute_stop_pos): Ignore a static
207 composition starting before CHARPOS (Bug#8915).
209 * xdisp.c (handle_composition_prop): Likewise.
211 2011-07-07 Eli Zaretskii <eliz@gnu.org>
213 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
216 2011-07-07 Kenichi Handa <handa@m17n.org>
218 * character.h (unicode_category_t): New enum type.
220 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
221 (Qchar_code_property_table): New variable.
222 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
223 (UNIPROP_COMPRESSED_FORM_P): New macros.
224 (char_table_ascii): Uncompress the compressed values.
225 (sub_char_table_ref): New arg is_uniprop. Callers changed.
226 Uncompress the compressed values.
227 (sub_char_table_ref_and_range): Likewise.
228 (char_table_ref_and_range): Uncompress the compressed values.
229 (sub_char_table_set): New arg is_uniprop. Callers changed.
230 Uncompress the compressed values.
231 (sub_char_table_set_range): Args changed. Callers changed.
232 (char_table_set_range): Adjuted for the above change.
233 (map_sub_char_table): Delete args default_val and parent. Add arg
234 top. Give decoded values to a Lisp function.
235 (map_char_table): Adjusted for the above change. Give decoded
236 values to a Lisp function. Gcpro more variables.
237 (uniprop_table_uncompress)
238 (uniprop_decode_value_run_length): New functions.
239 (uniprop_decoder, uniprop_decoder_count): New variables.
240 (uniprop_get_decoder, uniprop_encode_value_character)
241 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
243 (uniprop_encoder, uniprop_encoder_count): New variables.
244 (uniprop_get_encoder, uniprop_table)
245 (Funicode_property_table_internal, Fget_unicode_property_internal)
246 (Fput_unicode_property_internal): New functions.
247 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
248 Sunicode_property_table_internal, Sget_unicode_property_internal,
249 and Sput_unicode_property_internal. Defvar_lisp
250 char-code-property-alist.
252 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
253 Vunicode_category_table.
255 * font.c (font_range): Adjusted for the change of
256 Vunicode_category_table.
258 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
260 * m/iris4d.h: Remove file, move contents ...
261 * s/irix6-5.h: ... here.
263 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
265 Remove unportable assumption about struct layout (Bug#8884).
266 * alloc.c (mark_buffer):
267 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
268 (clone_per_buffer_values): Don't assume that
269 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
270 This isn't true in general, and it's particularly not true
271 if Emacs is configured with --with-wide-int.
272 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
273 New macros, used in the buffer.c change.
275 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
277 * xsettings.c: Use both GConf and GSettings if both are available.
278 (store_config_changed_event): Add comment.
279 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
280 (store_tool_bar_style_changed): New functions.
281 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
282 (struct xsettings): Move font inside HAVE_XFT.
283 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
284 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
285 Move inside HAVE_XFT.
286 (something_changed_gsettingsCB): Renamed from something_changedCB.
287 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
289 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
290 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
291 (something_changed_gconfCB): Renamed from something_changedCB.
292 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
293 (parse_settings): Move check for font inside HAVE_XFT.
294 (read_settings, apply_xft_settings): Add comment.
295 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
296 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
297 call store_font_name_changed.
298 (xft_settings_event): Add comment.
299 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
300 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
301 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
302 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
303 (xsettings_initialize): Call init_gsettings last.
304 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
307 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
309 Random fixes. E.g., (random) never returned negative values.
310 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
311 subseconds part to the entropy, as that's a bit more random.
312 Prefer signed to unsigned, since the signedness doesn't matter and
313 in general we prefer signed. When given a limit, use a
314 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
315 latter isn't right if USE_2_TAGS_FOR_INTS.
316 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
317 not 0..VALMASK. Don't discard "excess" bits that random () returns.
319 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
321 * textprop.c (text_property_stickiness):
322 Obey Vtext_property_default_nonsticky.
323 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
324 * w32fns.c (syms_of_w32fns):
325 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
327 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
329 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
330 This is more efficient than Ffile_directory_p and avoids a minor race.
332 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
334 * buffer.c (Foverlay_put): Say what the return value is
337 * fileio.c (barf_or_query_if_file_exists): Check first if the file
338 is a directory before asking whether to use the file name
340 (barf_or_query_if_file_exists): Make the "File is a directory"
341 error be more correct.
343 * fns.c (Frequire): Remove the mention of the .gz files, since
344 that's installation-specific, but keep the mention of
347 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
349 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
350 Report string overflow if the output is too long.
352 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
354 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
355 (syms_of_gnutls): Remove duplicate DEFSYM for
356 Qgnutls_bootprop_verify_hostname_error, an error for
357 Qgnutls_bootprop_verify_error (which is no longer used).
359 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
360 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
361 Also (re)move comments that are misplaced or no longer relevant.
363 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
365 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
367 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
369 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
370 and background color parameters if they have been changed.
372 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
374 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
376 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
378 * xsettings.c (SYSTEM_FONT): Define only when used.
379 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
381 * keymap.c (access_keymap_1): Now static.
383 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
385 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
386 leave any prefix arg for the up event (Bug#1586).
388 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
390 * lread.c (syms_of_lread): Mention single symbols defined by
391 `defvar' or `defconst' (bug#7154).
393 * fns.c (Frequire): Mention .el.gz files (bug#7314).
394 (Frequire): Mention get-load-suffixes.
396 2011-07-02 Martin Rudalics <rudalics@gmx.at>
398 * window.h (window): Remove clone_number slot.
399 * window.c (Fwindow_clone_number, Fset_window_clone_number):
401 (make_parent_window, make_window, saved_window)
402 (Fset_window_configuration, save_window_save): Don't deal with
404 * buffer.c (Qclone_number): Remove declaration.
405 (sort_overlays, overlay_strings): Don't deal with clone numbers.
407 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
409 Add multiple inheritance to keymaps.
410 * keymap.c (Fmake_composed_keymap): New function.
411 (Fset_keymap_parent): Simplify.
412 (fix_submap_inheritance): Remove.
413 (access_keymap_1): New function extracted from access_keymap to handle
414 embedded parents and handle lists of maps.
415 (access_keymap): Use it.
416 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
417 (Fcopy_keymap): Handle embedded parents.
418 (Fcommand_remapping, define_as_prefix): Simplify.
419 (Fkey_binding): Simplify.
420 (syms_of_keymap): Move minibuffer-local-completion-map,
421 minibuffer-local-filename-completion-map,
422 minibuffer-local-must-match-map, and
423 minibuffer-local-filename-must-match-map to Elisp.
424 (syms_of_keymap): Defsubr make-composed-keymap.
425 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
426 (parse_menu_item): Trivial simplification.
428 2011-07-01 Glenn Morris <rgm@gnu.org>
430 * Makefile.in (SETTINGS_LIBS): Fix typo.
432 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
434 * coding.c (Fencode_coding_string): Record the last coding system
435 used, as the function doc string says (bug#8738).
437 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
439 * xsettings.c (store_monospaced_changed): Take new font as arg and
440 check for change against current_mono_font.
441 (EMACS_TYPE_SETTINGS): Remove this and related defines.
442 (emacs_settings_constructor, emacs_settings_get_property)
443 (emacs_settings_set_property, emacs_settings_class_init)
444 (emacs_settings_init, gsettings_obj): Remove.
445 (something_changedCB): New function for HAVE_GSETTINGS.
446 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
447 with value as argument.
448 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
449 g_settings_new (Bug#8967). Do not create gsettings_obj.
450 Remove calls to g_settings_bind. Connect something_changedCB to
453 * xgselect.c: Add defined (HAVE_GSETTINGS).
454 (xgselect_initialize): Ditto.
456 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
457 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
460 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
462 * eval.c (struct backtrace): Simplify and port the data structure.
463 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
464 signed bit field, as this assumption is not portable and it makes
465 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
466 "char debug_on_exit : 1" as this is not portable either; instead,
467 use the portable "unsigned int debug_on_exit : 1". Remove unused
468 member evalargs. Remove obsolete comments about cc bombing out.
470 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
472 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
473 Let HAVE_GSETTINGS override HAVE_GCONF.
474 (store_monospaced_changed): New function.
475 (EMACS_SETTINGS): A new type derived from GObject to handle
476 GSettings notifications.
477 (emacs_settings_constructor, emacs_settings_get_property)
478 (emacs_settings_set_property, emacs_settings_class_init):
480 (gsettings_client, gsettings_obj): New variables.
481 (GSETTINGS_SCHEMA): New define.
482 (something_changedCB): Call store_monospaced_changed.
483 (init_gsettings): New function.
484 (xsettings_initialize): Call init_gsettings.
485 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
488 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
491 2011-06-29 Martin Rudalics <rudalics@gmx.at>
493 * window.c (resize_root_window, grow_mini_window)
494 (shrink_mini_window): Rename Qresize_root_window to
495 Qwindow_resize_root_window and Qresize_root_window_vertically to
496 Qwindow_resize_root_window_vertically.
498 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
500 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
502 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
504 * makefile.w32-in: Redesign dependencies so they reflect more
505 clearly which files are directly included by each source file,
506 and not through other includes.
508 2011-06-27 Martin Rudalics <rudalics@gmx.at>
510 * buffer.c (Qclone_number): Declare static and DEFSYM it.
511 (sort_overlays, overlay_strings): When an overlay's clone number
512 matches the window's clone number process the overlay even if
513 the overlay's window property doesn't match the current window.
515 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
516 (Fwindow_hchild): Rename to Fwindow_left_child.
517 (Fwindow_next): Rename to Fwindow_next_sibling.
518 (Fwindow_prev): Rename to Fwindow_prev_sibling.
519 (resize_window_check): Rename to window_resize_check.
520 (resize_window_apply): Rename to window_resize_apply.
521 (Fresize_window_apply): Rename to Fwindow_resize_apply.
522 (Fdelete_other_windows_internal, resize_frame_windows)
523 (Fsplit_window_internal, Fdelete_window_internal)
524 (grow_mini_window, shrink_mini_window)
525 (Fresize_mini_window_internal): Fix callers accordingly.
527 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
529 * emacsgtkfixed.h: State that this is only used with Gtk+3.
530 (emacs_fixed_set_min_size): Remove.
531 (emacs_fixed_new): Take frame as argument.
533 * emacsgtkfixed.c: State that this is only used with Gtk+3.
534 (_EmacsFixedPrivate): Remove minwidth/height.
536 (emacs_fixed_init): Initialize priv->f.
537 (get_parent_class, emacs_fixed_set_min_size): Remove.
538 (emacs_fixed_new): Set priv->f to argument.
539 (emacs_fixed_get_preferred_width)
540 (emacs_fixed_get_preferred_height): Use min_width/height from
541 frames size_hint to set minimum and natural (Bug#8919).
542 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
543 and use min_width/height from frames size_hint to set
544 min_width/height (Bug#8919).
546 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
547 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
550 2011-06-26 Eli Zaretskii <eliz@gnu.org>
552 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
553 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
556 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
558 * process.c (wait_reading_process_output): Bypass select if
559 waiting for a cell while ignoring keyboard input, and input is
560 pending. Suggested by Jan Djärv (Bug#8869).
562 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
564 Use gnulib's dup2 module instead of rolling our own.
565 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
567 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
569 * dispnew.c (scrolling_window): Before scrolling, turn off a
570 mouse-highlight in the window being scrolled.
572 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
574 Move DEFSYM to lisp.h and use everywhere.
576 * character.h (DEFSYM): Move declaration...
577 * lisp.h (DEFSYM): ...here.
583 * w32select.c: Don't include character.h.
585 * alloc.c (syms_of_alloc):
586 * buffer.c (syms_of_buffer):
587 * bytecode.c (syms_of_bytecode):
588 * callint.c (syms_of_callint):
589 * casefiddle.c (syms_of_casefiddle):
590 * casetab.c (init_casetab_once):
591 * category.c (init_category_once, syms_of_category):
592 * ccl.c (syms_of_ccl):
593 * cmds.c (syms_of_cmds):
594 * composite.c (syms_of_composite):
595 * dbusbind.c (syms_of_dbusbind):
596 * dired.c (syms_of_dired):
597 * dispnew.c (syms_of_display):
598 * doc.c (syms_of_doc):
599 * editfns.c (syms_of_editfns):
600 * emacs.c (syms_of_emacs):
601 * eval.c (syms_of_eval):
602 * fileio.c (syms_of_fileio):
603 * fns.c (syms_of_fns):
604 * frame.c (syms_of_frame):
605 * fringe.c (syms_of_fringe):
606 * insdel.c (syms_of_insdel):
607 * keymap.c (syms_of_keymap):
608 * lread.c (init_obarray, syms_of_lread):
609 * macros.c (syms_of_macros):
610 * msdos.c (syms_of_msdos):
611 * print.c (syms_of_print):
612 * process.c (syms_of_process):
613 * search.c (syms_of_search):
614 * sound.c (syms_of_sound):
615 * syntax.c (init_syntax_once, syms_of_syntax):
616 * terminal.c (syms_of_terminal):
617 * textprop.c (syms_of_textprop):
618 * undo.c (syms_of_undo):
619 * w32.c (globals_of_w32):
620 * window.c (syms_of_window):
621 * xdisp.c (syms_of_xdisp):
622 * xfaces.c (syms_of_xfaces):
623 * xfns.c (syms_of_xfns):
624 * xmenu.c (syms_of_xmenu):
625 * xsettings.c (syms_of_xsettings):
626 * xterm.c (syms_of_xterm): Use DEFSYM.
628 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
630 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
632 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
634 Integer and buffer overflow fixes (Bug#8873).
636 * print.c (printchar, strout): Check for string overflow.
637 (PRINTPREPARE, printchar, strout):
638 Don't set size unless allocation succeeds.
640 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
641 for sizes. Check for string overflow more accurately.
642 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
644 * macros.c: Integer and buffer overflow fixes.
645 * keyboard.h (struct keyboard.kbd_macro_bufsize):
646 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
647 Use ptrdiff_t, not int, for sizes.
648 Don't increment bufsize until after realloc succeeds.
649 Check for size-calculation overflow.
650 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
652 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
654 * lread.c: Integer overflow fixes.
655 (read_integer): Radix is now EMACS_INT, not int,
656 to improve quality of diagnostics for out-of-range radices.
657 Calculate buffer size correctly for out-of-range radices.
658 (read1): Check for integer overflow in radices, and in
660 (read_escape): Avoid int overflow.
661 (Fload, openp, read_buffer_size, read1)
662 (substitute_object_recurse, read_vector, read_list, map_obarray):
663 Use ptrdiff_t, not int, for sizes.
664 (read1): Use EMACS_INT, not int, for sizes.
665 Check for size overflow.
667 * image.c (cache_image): Check for size arithmetic overflow.
669 * lread.c: Integer overflow issues.
670 (saved_doc_string_size, saved_doc_string_length)
671 (prev_saved_doc_string_size, prev_saved_doc_string_length):
672 Now ptrdiff_t, not int.
673 (read1): Don't assume doc string length fits in int. Check for
674 out-of-range doc string lengths.
675 (read_list): Don't assume file position fits in int.
676 (read_escape): Check for hex character overflow.
678 2011-06-22 Leo Liu <sdl.web@gmail.com>
680 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
681 Move to minibuffer.el.
683 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
685 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
686 The following patches are for when GLYPH_DEBUG && !XASSERT.
687 * dispextern.h (trace_redisplay_p, dump_glyph_string):
688 * dispnew.c (flush_stdout):
689 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
690 Mark as externally visible.
691 * dispnew.c (check_window_matrix_pointers): Now static.
692 * dispnew.c (window_to_frame_vpos):
693 * xfns.c (unwind_create_frame):
694 * xterm.c (x_check_font): Remove unused local.
695 * scroll.c (CHECK_BOUNDS):
696 * xfaces.c (cache_fache): Rename local to avoid shadowing.
697 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
698 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
699 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
700 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
702 (debug_method_add): Use va_list and vsprintf rather than relying
703 on undefined behavior with wrong number of arguments.
704 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
705 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
706 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
707 since we're not interested in debugging glyphs with old libraries.
708 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
709 GCC 4.6.0's static checking.
711 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
713 Integer overflow and signedness fixes (Bug#8873).
714 A few related buffer overrun fixes, too.
716 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
718 * dispextern.h (struct face.stipple):
719 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
720 (x_bitmap_mask, x_allocate_bitmap_record)
721 (x_create_bitmap_from_data, x_create_bitmap_from_file)
722 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
723 (x_create_bitmap_from_xpm_data):
724 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
725 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
727 * xfaces.c (load_pixmap):
728 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
729 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
730 (.bitmaps_last, struct x_output.icon_bitmap):
731 Use ptrdiff_t, not int, for bitmap indexes.
732 (x_allocate_bitmap_record): Check for size overflow.
733 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
735 Use ptrdiff_t, not int, for overlay counts.
736 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
737 * editfns.c (overlays_around, get_pos_property):
738 * textprop.c (get_char_property_and_overlay):
739 * xdisp.c (next_overlay_change, note_mouse_highlight):
740 * xfaces.c (face_at_buffer_position):
741 * buffer.c (OVERLAY_COUNT_MAX): New macro.
742 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
743 (Fnext_overlay_change, Fprevious_overlay_change)
744 (mouse_face_overlay_overlaps, Foverlays_in):
745 Use ptrdiff_t, not int, for sizes.
746 (overlays_at, overlays_in): Check for size-calculation overflow.
748 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
750 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
751 (x_session_initialize): Do not assume string length fits in int.
753 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
754 This is unlikely, but can occur if DPI is outlandish.
756 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
757 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
759 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
760 * xrdb.c (magic_file_p, search_magic_path):
761 Omit last arg SUFFIX; it was always 0. All callers changed.
762 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
764 * xfont.c (xfont_match): Avoid need for strlen.
766 * xfns.c: Don't assume strlen fits in int.
767 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
769 * xdisp.c (message_log_check_duplicate): Return intmax_t,
770 not unsigned long, as we prefer signed integers. All callers changed.
771 Detect integer overflow in repeat count.
772 (message_dolog): Don't assume print length fits in 39 bytes.
773 (display_mode_element): Don't assume strlen fits in int.
775 * termcap.c: Don't assume sizes fit in int and never overflow.
776 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
777 (gobble_line): Check for size-calculation overflow.
779 * minibuf.c (Fread_buffer):
780 * lread.c (intern, intern_c_string):
781 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
782 Don't assume string length fits in int.
784 * keyboard.c (parse_tool_bar_item):
785 * gtkutil.c (style_changed_cb): Avoid need for strlen.
787 * font.c: Don't assume string length fits in int.
788 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
789 Use ptrdiff_t, not int.
790 (font_intern_prop): Don't assume string length fits in int.
791 Don't assume integer property fits in fixnum.
792 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
794 * filelock.c: Fix some buffer overrun and integer overflow issues.
795 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
796 Reformulate so as not to need the command string.
797 Invoke gzip -cd rather than gunzip, as it's more portable.
798 (lock_info_type, lock_file_1, lock_file):
799 Don't assume pid_t and time_t fit in unsigned long.
800 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
801 (current_lock_owner): Prefer signed type for sizes.
802 Use memcpy, not strncpy, where memcpy is what is really wanted.
803 Don't assume (via atoi) that time_t and pid_t fit in int.
804 Check for time_t and/or pid_t out of range, e.g., via a network share.
805 Don't alloca where an auto var works fine.
807 * fileio.c: Fix some integer overflow issues.
808 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
809 Don't assume string length fits in int.
810 (directory_file_name): Don't assume string length fits in long.
811 (make_temp_name): Don't assume pid fits in int, or that its print
812 length is less than 20.
814 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
816 * coding.c (make_subsidiaries): Don't assume string length fits in int.
818 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
820 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
821 We prefer signed integers, even for size calculations.
823 * emacs.c: Don't assume string length fits in 'int'.
824 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
825 (main): Don't invoke strlen when not needed.
827 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
828 (XD_DEBUG_MESSAGE): Don't waste a byte.
830 * callproc.c (getenv_internal_1, getenv_internal)
832 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
834 * lread.c (invalid_syntax): Omit length argument.
835 All uses changed. This doesn't fix a bug, but it simplifies the
836 code away from its former Hollerith-constant appearance, and it's
837 one less 'int' to worry about when looking at integer-overflow issues.
838 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
840 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
841 This didn't break anything, but it didn't help either.
842 It's confusing to put a bogus integer in a place where the actual
843 value does not matter.
844 (LIST_END_P): Remove unused macro and its bogus comment.
845 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
847 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
848 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
850 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
851 We prefer signed types, and the value cannot exceed the EMACS_INT
852 range anyway (because otherwise the length would not be representable).
853 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
854 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
855 This avoids a GCC warning when WIDE_EMACS_INT.
857 * indent.c (sane_tab_width): New function.
858 (current_column, scan_for_column, Findent_to, position_indentation)
859 (compute_motion): Use it. This is just for clarity.
860 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
862 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
864 * lisp.h (lint_assume): New macro.
865 * composite.c (composition_gstring_put_cache):
866 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
868 * editfns.c, insdel.c:
869 Omit unnecessary forward decls, to simplify future changes.
871 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
873 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
875 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
876 Use much-faster test for byte-length change.
877 Don't assume string byte-length fits in 'int'.
878 Check that character arg fits in 'int'.
879 (mapcar1): Declare byte as byte, for clarity.
881 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
883 * fns.c (concat): Catch string overflow earlier.
884 Do not rely on integer wraparound.
886 * dispextern.h (struct it.overlay_strings_charpos)
887 (struct it.selective): Now EMACS_INT, not int.
888 * xdisp.c (forward_to_next_line_start)
889 (back_to_previous_visible_line_start)
890 (reseat_at_next_visible_line_start, next_element_from_buffer):
891 Don't arbitrarily truncate the value of 'selective' to int.
893 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
895 * composite.c: Don't truncate sizes to 'int'.
896 (composition_gstring_p, composition_reseat_it)
897 (composition_adjust_point): Use EMACS_INT, not int.
898 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
899 not EMACS_UINT, for indexes.
901 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
903 * buffer.c: Include <verify.h>.
904 (struct sortvec.priority, struct sortstr.priority):
905 Now EMACS_INT, not int.
906 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
907 (struct sortstr.size, record_overlay_string)
908 (struct sortstrlist.size, struct sortlist.used):
909 Don't truncate size to int.
910 (record_overlay_string): Check for size-calculation overflow.
911 (init_buffer_once): Check at compile-time, not run-time.
913 2011-06-22 Jim Meyering <meyering@redhat.com>
915 Don't leak an XBM-image-sized buffer
916 * image.c (xbm_load): Free the image buffer after using it.
918 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
921 * composite.c (find_automatic_composition): Omit needless 'return 0;'
922 that Sun C diagnosed.
923 * fns.c (secure_hash): Fix pointer signedness issue.
924 * intervals.c (static_offset_intervals): New function.
925 (offset_intervals): Use it.
927 2011-06-21 Leo Liu <sdl.web@gmail.com>
930 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
933 * fns.c (secure_hash): Rename from crypto_hash_function and change
934 the first arg to accept symbols.
935 (Fsecure_hash): New primitive.
936 (syms_of_fns): New symbols.
938 2011-06-20 Deniz Dogan <deniz@dogan.se>
940 * process.c (Fset_process_buffer): Clarify return value in
943 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
945 * dispnew.c (add_window_display_history): Use BVAR.
947 * xdisp.c (debug_method_add): Use BVAR.
948 (check_window_end, dump_glyph_matrix, dump_glyph)
949 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
951 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
954 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
955 check till after the cache is created in init_frame_faces.
957 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
959 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
961 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
963 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
964 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
965 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
967 Improve buffer-overflow checking (Bug#8873).
968 * fileio.c (Finsert_file_contents):
969 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
970 Remove the old (too-loose) buffer overflow checks.
971 They weren't needed, since make_gap checks for buffer overflow.
972 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
973 The old code merely checked for Emacs fixnum overflow, and relied
974 on undefined (wraparound) behavior. The new code avoids undefined
975 behavior, and also checks for ptrdiff_t and/or size_t overflow.
977 * editfns.c (Finsert_char): Don't dump core with very negative counts.
978 Tune. Don't use wider integers than needed. Don't use alloca.
979 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
981 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
983 * insdel.c, lisp.h (buffer_overflow): New function.
984 (insert_from_buffer_1, replace_range, replace_range_2):
985 * insdel.c (make_gap_larger):
986 * editfns.c (Finsert_char):
987 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
989 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
991 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
993 Integer overflow and signedness fixes (Bug#8873).
995 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
996 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
998 * fileio.c: Don't assume EMACS_INT fits in off_t.
999 (emacs_lseek): New static function.
1000 (Finsert_file_contents, Fwrite_region): Use it.
1001 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1003 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1005 * fns.c: Don't overflow int when computing a list length.
1006 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1007 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1008 truncation on 64-bit hosts. Check for QUIT every
1009 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1010 faster and is responsive enough.
1011 (Flength): Report an error instead of overflowing an integer.
1012 (Fsafe_length): Return a float if the value is not representable
1013 as a fixnum. This shouldn't happen except in contrived situations.
1014 (Fnthcdr, Fsort): Don't assume list length fits in int.
1015 (Fcopy_sequence): Don't assume vector length fits in int.
1017 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1018 (header_size, word_size): New constants.
1019 (allocate_vectorlike): Don't check size overflow here.
1020 (allocate_vector): Check it here instead, since this is the only
1021 caller of allocate_vectorlike that could cause overflow.
1022 Check that the new vector's length is representable as a fixnum.
1024 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1025 The previous code was bogus. For example, next_almost_prime (32)
1026 returned 39, which is undesirable as it is a multiple of 3; and
1027 next_almost_prime (24) returned 25, which is a multiple of 5 so
1028 why was the code bothering to check for multiples of 7?
1030 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1032 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1034 Variadic C functions now count arguments with ptrdiff_t.
1035 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1036 Back then I didn't know that the Emacs coding style prefers signed int.
1037 Also, in the meantime I found a few more instances where arguments
1038 were being counted with int, which may truncate counts on 64-bit
1039 machines, or EMACS_INT, which may be unnecessarily wide.
1040 * lisp.h (struct Lisp_Subr.function.aMANY)
1041 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1042 Arg counts are now ptrdiff_t, not size_t.
1043 All variadic functions and their callers changed accordingly.
1044 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1045 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1046 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1047 * callint.c (Fcall_interactively): Check arg count for overflow,
1048 to avoid potential buffer overrun. Use signed char, not 'int',
1049 for 'varies' array, so that we needn't bother to check its size
1050 calculation for overflow.
1051 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1052 * eval.c (apply_lambda):
1053 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1054 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1055 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1057 * callint.c (Fcall_interactively): Don't use index var as event count.
1059 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1060 * mem-limits.h (SIZE): Remove; no longer used.
1062 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1064 Remove unnecessary casts.
1065 * xterm.c (x_term_init):
1066 * xfns.c (x_set_border_pixel):
1067 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1068 These aren't needed now that we assume ANSI C.
1070 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1071 It's more likely to cause problems (due to unsigned overflow)
1074 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1076 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1078 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1080 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1082 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1084 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1086 GLYPH_CODE_FACE returns EMACS_INT, not int.
1087 * dispextern.h (merge_faces):
1088 * xfaces.c (merge_faces):
1089 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1090 Don't assume EMACS_INT fits in int.
1092 * character.h (CHAR_VALID_P): Remove unused parameter.
1093 * fontset.c, lisp.h, xdisp.c: All uses changed.
1095 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1097 * fns.c (concat): Minor tuning based on overflow analysis.
1098 This doesn't fix any bugs. Use int to hold character, instead
1099 of constantly refetching from Emacs object. Use XFASTINT, not
1100 XINT, for value known to be a character. Don't bother comparing
1101 a single byte to 0400, as it's always less.
1103 * floatfns.c (Fexpt):
1104 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1106 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1109 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1111 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1112 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1113 incorrectly succeed when S was a string, because 4294967386 was
1114 truncated before it was used.
1116 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1117 Otherwise, an out-of-range integer could cause undefined behavior
1120 * composite.c: Use int, not EMACS_INT, for characters.
1121 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1122 EMACS_INT, for values that are known to be in character range.
1123 This doesn't fix any bugs but is the usual style inside Emacs and
1124 may generate better code on 32-bit machines.
1126 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1127 This is for reasons similar to the recent CHAR_STRING fix.
1128 * charset.c (Fencode_char): Check that character arg is actually
1129 a character. Pass an int to ENCODE_CHAR.
1130 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1131 wider than 'int', as a compile-time check to prevent future regressions
1134 * character.c (char_string): Remove unnecessary casts.
1136 Make sure a 64-bit char is never passed to CHAR_STRING.
1137 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1138 by silently ignoring the top 32 bits, allowing some values
1139 that were far too large to be valid characters.
1140 * character.h: Include <verify.h>.
1141 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1142 arguments are no wider than unsigned, as a compile-time check
1143 to prevent future regressions in this area.
1145 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1146 (Fsubst_char_in_region):
1148 * xdisp.c (decode_mode_spec_coding):
1149 Adjust to CHAR_STRING's new requirement.
1150 * editfns.c (Finsert_char, Fsubst_char_in_region):
1151 * fns.c (concat): Check that character args are actually
1152 characters. Without this test, these functions did the wrong
1153 thing with wildly out-of-range values on 64-bit hosts.
1155 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1156 These casts should not be needed on 32-bit hosts, either.
1157 * keyboard.c (read_char):
1158 * lread.c (Fload): Remove casts to unsigned.
1160 * lisp.h (UNSIGNED_CMP): New macro.
1161 This fixes comparison bugs on 64-bit hosts.
1162 (ASCII_CHAR_P): Use it.
1163 * casefiddle.c (casify_object):
1164 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1165 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1166 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1167 * dispextern.h (FACE_FROM_ID):
1168 * keyboard.c (read_char): Use UNSIGNED_CMP.
1170 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1171 not to EMACS_INT, to avoid GCC warning.
1173 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1175 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1176 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1177 isn't needed on 32-bit machines.
1179 * buffer.c (Fgenerate_new_buffer_name):
1180 Use EMACS_INT for count, not int.
1181 (advance_to_char_boundary): Return EMACS_INT, not int.
1183 * data.c (Qcompiled_function): Now static.
1185 * window.c (window_body_lines): Now static.
1187 * image.c (gif_load): Rename local to avoid shadowing.
1189 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1190 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1191 * alloc.c (make_save_value): Integer argument is now of type
1193 (mark_object): Use ptrdiff_t, not int.
1194 * lisp.h (pD): New macro.
1195 * print.c (print_object): Use it.
1197 * alloc.c: Use EMACS_INT, not int, to count objects.
1198 (total_conses, total_markers, total_symbols, total_vector_size)
1199 (total_free_conses, total_free_markers, total_free_symbols)
1200 (total_free_floats, total_floats, total_free_intervals)
1201 (total_intervals, total_strings, total_free_strings):
1202 Now EMACS_INT, not int. All uses changed.
1203 (Fgarbage_collect): Compute overall total using a double, so that
1204 integer overflow is less likely to be a problem. Check for overflow
1205 when converting back to an integer.
1206 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1207 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1208 These were 'int' variables that could overflow on 64-bit hosts;
1209 they were never used, so remove them instead of repairing them.
1210 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1211 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1212 Previously, this ceilinged at INT_MAX, but that doesn't work on
1214 (allocate_pseudovector): Don't use EMACS_INT when int would do.
1216 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1217 (allocate_vectorlike): Check for ptrdiff_t overflow.
1218 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1219 when a (possibly-narrower) signed value would do just as well.
1220 We prefer using signed arithmetic, to avoid comparison confusion.
1222 * alloc.c: Catch some string size overflows that we were missing.
1223 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1224 for convenience in STRING_BYTES_MAX.
1225 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1226 The definition here is exact; the one in lisp.h was approximate.
1227 (allocate_string_data): Check for string overflow. This catches
1228 some instances we weren't catching before. Also, it catches
1229 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1230 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1231 and ptrdiff_t and EMACS_INT are both 64 bits.
1233 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1234 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1235 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1237 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1239 * alloc.c (Fmake_string): Check for out-of-range init.
1241 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1243 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1245 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1247 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1248 xg_get_default_scrollbar_width.
1250 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1251 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1252 (style_changed_cb): Call update_theme_scrollbar_width and call
1253 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1254 all frames (Bug#8505).
1255 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1256 Call gtk_window_set_resizable if HAVE_GTK3.
1257 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1258 and height if HAVE_GTK3 (Bug#8505).
1259 (scroll_bar_width_for_theme): New variable.
1260 (update_theme_scrollbar_width): New function.
1261 (xg_get_default_scrollbar_width): Move code to
1262 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1263 (xg_initialize): Call update_theme_scrollbar_width.
1265 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1267 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1269 2011-06-12 Martin Rudalics <rudalics@gmx.at>
1271 * frame.c (make_frame): Call other_buffer_safely instead of
1274 * window.c (temp_output_buffer_show): Call display_buffer with
1275 second argument Vtemp_buffer_show_specifiers and reset latter
1276 immediately after the call.
1277 (Vtemp_buffer_show_specifiers): New variable.
1278 (auto_window_vscroll_p, next_screen_context_lines)
1279 (Vscroll_preserve_screen_position): Remove leading asterisks from
1282 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
1284 Fix minor problems found by GCC 4.6.0 static checking.
1285 * buffer.c (Qclone_number): Remove for now, as it's unused.
1286 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1287 (record_buffer): Remove unused local.
1288 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1289 (set_frame_buffer_list): Remove; unused.
1290 * frame.h (other_visible_frames): Remove decl.
1291 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1292 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1293 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1295 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1296 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1297 Define only if HAVE_GPM.
1298 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1299 (update_hints_inhibit): Remove; never set. All uses removed.
1300 * widgetprv.h (emacsFrameClassRec): Remove decl.
1301 * window.c (delete_deletable_window): Now returns void, since it
1302 wasn't returning anything.
1303 (compare_window_configurations): Remove unused locals.
1304 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1305 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
1306 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1307 the same widths as pointers. This follows up on the 2011-05-06 patch.
1308 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1309 * xterm.h: Likewise.
1310 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1312 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
1314 * makefile.w32-in: Update dependencies.
1315 (LISP_H): Add lib/intprops.h.
1317 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1319 * image.c (gif_load): Add animation frame delay to the metadata.
1320 (syms_of_image): Use DEFSYM. New symbol `delay'.
1322 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1324 * window.c (delete_deletable_window): Re-add.
1325 (Fset_window_configuration): Rewrite to handle dead buffers and
1326 consequently deletable windows.
1327 (window_tree, Fwindow_tree): Remove. Supply functionality in
1329 (compare_window_configurations): Simplify code.
1331 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1333 * image.c (imagemagick_load_image): Fix type mismatch.
1334 (Fimagemagick_types): Likewise.
1336 * window.h (replace_buffer_in_windows): Declare.
1338 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1340 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1341 Qclone_number. Remove external declaration of Qdelete_window.
1342 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1344 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1345 Qbuffer_list_update_hook if allowed.
1346 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1347 buffer list implementation.
1348 (other_buffer_safely): New function.
1349 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1350 calls to replace_buffer_in_windows and
1351 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1353 (record_buffer): Inhibit quitting and rewrite using quittable
1354 functions. Run Qbuffer_list_update_hook if allowed.
1355 (Frecord_buffer, Funrecord_buffer): New functions.
1356 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1357 switch-to-buffer to window.el.
1358 (bury-buffer): Move to window.el.
1359 (Vbuffer_list_update_hook): New variable.
1361 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1364 * window.h (resize_frame_windows): Move up in code.
1365 (Fwindow_frame): Remove EXFUN.
1366 (replace_buffer_in_all_windows): Remove prototype.
1367 (replace_buffer_in_windows_safely): Add prototype.
1369 * window.c: Declare Qdelete_window static again. Move down
1370 declaration of select_count.
1371 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1372 (Fother_window): Move to window.el.
1373 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1374 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1375 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1377 (replace_buffer_in_windows): Implement by calling
1378 Qreplace_buffer_in_windows.
1379 (replace_buffer_in_all_windows): Remove with some functionality
1380 moved into replace_buffer_in_windows_safely.
1381 (replace_buffer_in_windows_safely): New function.
1382 (select_window_norecord, select_frame_norecord): Move in front
1383 of run_window_configuration_change_hook. Remove now obsolete
1385 (Fset_window_buffer): Rewrite doc-string. Call
1386 Qrecord_window_buffer.
1387 (keys_of_window): Move binding for other-window to window.el.
1389 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1391 * dispextern.h (struct image): Replace data member, whose int_val
1392 and ptr_val fields were not used by anything, with a single
1395 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1396 (gif_clear_image, gif_load, imagemagick_load_image)
1397 (gs_clear_image, gs_load): Callers changed.
1399 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1401 * buffer.h: Include <time.h>, for time_t.
1402 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1404 Fix minor problems found by static checking.
1406 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1408 Make identifiers static if they are not used in other modules.
1409 * data.c (Qcompiled_function, Qframe, Qvector):
1410 * image.c (QimageMagick, Qsvg):
1411 * minibuf.c (Qmetadata):
1412 * window.c (resize_window_check, resize_root_window): Now static.
1413 * window.h (resize_window_check, resize_root_window): Remove decls.
1415 * window.c (window_deletion_count, delete_deletable_window):
1417 (window_body_lines): Now static.
1418 (Fdelete_other_windows_internal): Mark vars as initialized.
1419 Make sure 'resize_failed' is initialized.
1420 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1421 (resize_window_apply): Remove unused local.
1422 * window.h (delete_deletable_window): Remove decl.
1424 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
1425 (imagemagick_load_image): Fix pointer signedness problem by changing
1426 last arg from unsigned char * to char *. All uses changed.
1427 Also, fix a local for similar reasons.
1428 Remove unused locals. Remove locals to avoid shadowing.
1429 (fn_rsvg_handle_free): Remove; unused.
1430 (svg_load, svg_load_image): Fix pointer signedness problem.
1431 (imagemagick_load_image): Don't use garbage pointer image_wand.
1433 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1435 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
1437 * image.c (gif_load): Fix omitted cast error introduced by
1440 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1442 * window.h (resize_proportionally, orig_total_lines)
1443 (orig_top_line): Remove from window structure.
1444 (set_window_height, set_window_width, change_window_heights)
1445 (Fdelete_window): Remove prototypes.
1446 (resize_frame_windows): Remove duplicate declaration.
1448 2011-06-10 Eli Zaretskii <eliz@gnu.org>
1450 * window.h (resize_frame_windows, resize_window_check)
1451 (delete_deletable_window, resize_root_window)
1452 (resize_frame_windows): Declare prototypes.
1454 * window.c (resize_window_apply): Make definition be "static" to
1455 match the prototype.
1457 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1459 * window.c: Remove declarations of Qwindow_size_fixed,
1460 window_min_size_1, window_min_size_2, window_min_size,
1461 size_window, window_fixed_size_p, enlarge_window, delete_window.
1462 Remove static from declaration of Qdelete_window, it's
1463 temporarily needed by Fbury_buffer.
1464 (replace_window): Don't assign orig_top_line and
1466 (Fdelete_window, delete_window): Remove. Window deletion is
1467 handled by window.el.
1468 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1469 Fdelete_window calls with calls to Qdelete_window.
1470 (Fdelete_other_windows): Remove. Deleting other windows is
1471 handled by window.el.
1472 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1473 handled in window.el.
1474 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1475 Window minimum sizes are handled in window.el.
1476 (shrink_windows, size_window, set_window_height)
1477 (set_window_width, change_window_heights, window_height)
1478 (window_width, CURBEG, CURSIZE, enlarge_window)
1479 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1480 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1481 handled in window.el.
1482 (make_dummy_parent): Rename to make_parent_window and give it a
1483 second argument horflag.
1484 (make_window): Don't set resize_proportionally any more.
1485 (Fsplit_window): Remove. Windows are split in window.el.
1486 (save_restore_action, save_restore_orig_size)
1487 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1488 Resize mini windows in window.el.
1489 (grow_mini_window, shrink_mini_window): Implement by calling
1490 Qresize_root_window_vertically, resize_window_check and
1491 resize_window_apply.
1492 (saved_window, Fset_window_configuration, save_window_save): Do
1493 not handle orig_top_line, orig_total_lines, and
1494 resize_proportionally.
1495 (window_min_height, window_min_width): Move to window.el.
1496 (keys_of_window): Move bindings for delete-other-windows,
1497 split-window, delete-window and enlarge-window to window.el.
1499 * buffer.c: Temporarily extern Qdelete_window.
1500 (Fbury_buffer): Temporarily call Qdelete_window instead of
1501 Fdelete_window (Fbury_buffer will move to window.el soon).
1503 * frame.c (set_menu_bar_lines_1): Remove code handling
1504 orig_top_line and orig_total_lines.
1506 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1507 set_window_height but set heights directly.
1508 (change_frame_size_1): Use resize_frame_windows.
1510 * xdisp.c (init_xdisp): Don't use set_window_height but set
1513 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1514 resize_frame_windows instead of change_window_heights and run
1515 run_window_configuration_change_hook.
1517 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1518 instead of change_window_heights and run
1519 run_window_configuration_change_hook.
1521 2011-06-09 Martin Rudalics <rudalics@gmx.at>
1523 * window.c (replace_window): Rename second argument REPLACEMENT to
1524 NEW. New third argument SETFLAG. Rewrite.
1525 (delete_window, make_dummy_parent): Call replace_window with
1527 (window_list_1): Move down in code.
1528 (run_window_configuration_change_hook): Move set_buffer part
1529 before select_frame_norecord part in order to unwind correctly.
1530 Rename count1 to count.
1531 (recombine_windows, delete_deletable_window, resize_root_window)
1532 (Fdelete_other_windows_internal)
1533 (Frun_window_configuration_change_hook, make_parent_window)
1534 (resize_window_check, resize_window_apply, Fresize_window_apply)
1535 (resize_frame_windows, Fsplit_window_internal)
1536 (Fdelete_window_internal, Fresize_mini_window_internal): New
1538 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1540 2011-06-08 Martin Rudalics <rudalics@gmx.at>
1542 * window.h (window): Add some new members to window structure -
1543 normal_lines, normal_cols, new_total, new_normal, clone_number,
1544 splits, nest, prev_buffers, next_buffers.
1545 (WINDOW_TOTAL_SIZE): Move here from window.c.
1546 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1548 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1550 (make_dummy_parent): Set new members of windows structure.
1551 (make_window): Move down in code. Handle new members of window
1553 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1554 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1555 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1556 (Fset_window_prev_buffers, Fwindow_next_buffers)
1557 (Fset_window_next_buffers, Fset_window_clone_number): New
1559 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1560 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1562 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1563 Argument WINDOW can be now internal window too.
1564 (Fwindow_use_time): Move up in code.
1565 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1567 (Fset_window_configuration, saved_window)
1568 (Fcurrent_window_configuration, save_window_save): Handle new
1569 members of window structure.
1570 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1571 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1572 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1573 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1574 Qget_mru_window, Qresize_root_window,
1575 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1576 Qauto_buffer_name; staticpro them.
1578 2011-06-07 Martin Rudalics <rudalics@gmx.at>
1580 * window.c (Fwindow_total_size, Fwindow_left_column)
1581 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1582 (Fwindow_list_1): New functions.
1583 (window_box_text_cols): Replace with window_body_cols.
1584 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1585 window_body_cols instead of window_box_text_cols.
1586 (delete_window, Fset_window_configuration): Call
1587 delete_all_subwindows with window as argument.
1588 (delete_all_subwindows): Take a window as argument and not a
1590 (window_loop): Remove handling of GET_LRU_WINDOW and
1592 (Fget_lru_window, Fget_largest_window): Move to window.el.
1594 * window.h: Extern window_body_cols instead of
1595 window_box_text_cols. delete_all_subwindows now takes a
1596 Lisp_Object as argument.
1598 * indent.c (compute_motion, Fcompute_motion): Use
1599 window_body_cols instead of window_box_text_cols.
1601 * frame.c (delete_frame): Call delete_all_subwindows with root
1604 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1606 * fns.c (Fputhash): Document return value.
1608 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
1610 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1612 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1614 Cons<->int and similar integer overflow fixes (Bug#8794).
1616 Check for overflow when converting integer to cons and back.
1617 * charset.c (Fdefine_charset_internal, Fdecode_char):
1618 Use cons_to_unsigned to catch overflow.
1619 (Fencode_char): Use INTEGER_TO_CONS.
1620 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1621 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1622 * data.c (long_to_cons, cons_to_long): Remove.
1623 (cons_to_unsigned, cons_to_signed): New functions.
1624 These signal an error for invalid or out-of-range values.
1625 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1626 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1627 * font.c (Ffont_variation_glyphs):
1628 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1629 * lisp.h: Include <intprops.h>.
1630 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1631 (cons_to_signed, cons_to_unsigned): New decls.
1632 (long_to_cons, cons_to_long): Remove decls.
1633 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1634 (Fprimitive_undo): Use CONS_TO_INTEGER.
1635 * xfns.c (Fx_window_property): Likewise.
1636 * xselect.c: Include <limits.h>.
1637 (x_own_selection, selection_data_to_lisp_data):
1638 Use INTEGER_TO_CONS.
1639 (x_handle_selection_request, x_handle_selection_clear)
1640 (x_get_foreign_selection, Fx_disown_selection_internal)
1641 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1642 (lisp_data_to_selection_data): Use cons_to_unsigned.
1643 (x_fill_property_data): Use cons_to_signed.
1644 Report values out of range.
1646 Check for buffer and string overflow more precisely.
1647 * buffer.h (BUF_BYTES_MAX): New macro.
1648 * lisp.h (STRING_BYTES_MAX): New macro.
1649 * alloc.c (Fmake_string):
1650 * character.c (string_escape_byte8):
1651 * coding.c (coding_alloc_by_realloc):
1652 * doprnt.c (doprnt):
1653 * editfns.c (Fformat):
1655 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1656 since they may not be the same number.
1657 * editfns.c (Finsert_char):
1658 * fileio.c (Finsert_file_contents):
1659 Likewise for BUF_BYTES_MAX.
1661 * image.c: Use ptrdiff_t, not int, for sizes.
1662 (slurp_file): Switch from int to ptrdiff_t.
1664 (slurp_file): Check that file size fits in both size_t (for
1665 malloc) and ptrdiff_t (for sanity and safety).
1667 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1668 if b->modtime has its maximal value.
1670 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1672 Don't assume time_t can fit into int.
1673 * buffer.h (struct buffer.modtime): Now time_t, not int.
1674 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1675 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1677 Minor fixes for signed vs unsigned integers.
1678 * character.h (MAYBE_UNIFY_CHAR):
1679 * charset.c (maybe_unify_char):
1680 * keyboard.c (read_char, reorder_modifiers):
1681 XINT -> XFASTINT, since the integer must be nonnegative.
1682 * ftfont.c (ftfont_spec_pattern):
1683 * keymap.c (access_keymap, silly_event_symbol_error):
1684 XUINT -> XFASTINT, since the integer must be nonnegative.
1685 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1686 since it makes no difference and we prefer signed.
1687 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1688 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1691 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1693 * window.h (Fwindow_frame): Declare.
1695 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1697 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1698 (SPARE_MEMORY): Always define.
1699 (LARGE_REQUEST): Remove.
1700 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1702 2011-06-06 Martin Rudalics <rudalics@gmx.at>
1704 * lisp.h: Move EXFUNS for Fframe_root_window,
1705 Fframe_first_window and Fset_frame_selected_window to window.h.
1707 * window.h: Move EXFUNS for Fframe_root_window,
1708 Fframe_first_window and Fset_frame_selected_window here from
1711 * frame.c (Fwindow_frame, Fframe_first_window)
1712 (Fframe_root_window, Fframe_selected_window)
1713 (Fset_frame_selected_window): Move to window.c.
1714 (Factive_minibuffer_window): Move to minibuf.c.
1715 (Fother_visible_frames_p): New function.
1717 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1719 * window.c (decode_window, decode_any_window): Move up in code.
1720 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1721 (inhibit_frame_unsplittable): Remove unused variable.
1722 (Fwindow_buffer): Move up and rewrite doc-string.
1723 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1724 (Fwindow_prev): New functions.
1725 (Fwindow_frame): Move here from frame.c. Accept any window as
1727 (Fframe_root_window, Fframe_first_window)
1728 (Fframe_selected_window): Move here from frame.c. Accept frame
1729 or arbitrary window as argument. Update doc-strings.
1730 (Fminibuffer_window): Move up in code.
1731 (Fwindow_minibuffer_p): Move up in code and simplify.
1732 (Fset_frame_selected_window): Move here from frame.c.
1734 (Fselected_window, select_window, Fselect_window): Move up in
1735 code. Minor doc-string fixes.
1737 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1739 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1740 Do not assume that spare memory exists; that assumption is valid
1741 only if SYSTEM_MALLOC.
1742 (LARGE_REQUEST): New macro, so that the issue of large requests
1743 is separated from the issue of spare memory.
1745 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1747 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1750 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1752 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1755 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1757 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1759 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1761 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1762 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1764 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
1766 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1768 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
1770 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1771 (x_clipboard_manager_save): Add return value.
1772 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1774 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1775 Obey Vx_select_enable_clipboard_manager. Catch errors in
1776 x_clipboard_manager_save (Bug#8779).
1777 (Vx_select_enable_clipboard_manager): New variable.
1778 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
1780 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
1782 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1784 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1786 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1787 in the current matrix if keep_current_p is non-zero.
1789 2011-06-04 Eli Zaretskii <eliz@gnu.org>
1791 * bidi.c (bidi_level_of_next_char): Fix last change.
1793 2011-06-03 Eli Zaretskii <eliz@gnu.org>
1795 Support bidi reordering of text covered by display properties.
1797 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1798 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1799 (bidi_cache_search, bidi_cache_iterator_state)
1800 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1801 (bidi_level_of_next_char, bidi_move_to_visually_next):
1802 Support character positions inside a run of characters covered by a
1804 (bidi_paragraph_init, bidi_resolve_explicit_1)
1805 (bidi_level_of_next_char): Call bidi_fetch_char and
1806 bidi_fetch_char_advance instead of FETCH_CHAR and
1808 (bidi_init_it): Initialize new members.
1809 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1811 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1812 instead of using explicit *_CHAR codes.
1813 (bidi_resolve_explicit, bidi_resolve_weak):
1814 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
1815 bidirectional text is supported only in multibyte buffers.
1816 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1817 it to initialize the frame_window_p member of struct bidi_it.
1818 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1819 (bidi_resolve_explicit, bidi_resolve_weak)
1820 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1821 bidi_it->nchars is non-positive.
1822 (bidi_level_of_next_char): Don't try to lookup the cache for the
1823 next/previous character if nothing is cached there yet, or if we
1824 were just reseat()'ed to a new position.
1826 * xdisp.c (set_cursor_from_row): Set start and stop points
1827 according to the row's direction when priming the loop that looks
1828 for the glyph on which to display cursor.
1829 (single_display_spec_intangible_p): Function deleted.
1830 (display_prop_intangible_p): Reimplement to call
1831 handle_display_spec instead of single_display_spec_intangible_p.
1832 Accept 3 additional arguments needed by handle_display_spec.
1833 This fixes incorrect cursor motion across display property with complex
1834 values: lists, `(when COND...)' forms, etc.
1835 (single_display_spec_string_p): Support property values that are
1836 lists with the argument STRING its top-level element.
1837 (display_prop_string_p): Fix the condition for processing a
1838 property that is a list to be consistent with handle_display_spec.
1839 (handle_display_spec): New function, refactored from the
1840 last portion of handle_display_prop.
1841 (compute_display_string_pos): Accept additional argument
1842 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1843 value of a `display' property is a "replacing spec".
1844 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1845 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1846 the display property, but just return a value indicating whether
1847 the display property will replace the characters it covers.
1848 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1849 frame_window_p members of struct bidi_it.
1850 (compute_display_string_pos, compute_display_string_end):
1852 (push_it): Accept second argument POSITION, where pop_it should
1853 jump to continue iteration.
1854 (reseat_1): Initialize bidi_it.disp_pos.
1856 * keyboard.c (adjust_point_for_property): Adjust the call to
1857 display_prop_intangible_p to its new signature.
1859 * dispextern.h (struct bidi_it): New member frame_window_p.
1860 (bidi_init_it): Update prototypes.
1861 (display_prop_intangible_p): Update prototype.
1862 (compute_display_string_pos, compute_display_string_end):
1864 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1867 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1869 Malloc failure behavior now depends on size of allocation.
1870 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1871 * lisp.h: Change signatures accordingly.
1872 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1873 All callers changed. (Bug#8762)
1875 * gnutls.c: Use Emacs's memory allocators.
1876 Without this change, the gnutls library would invoke malloc etc.
1877 directly, which causes problems on non-SYNC_INPUT hosts, and which
1878 runs afoul of improving memory_full behavior. (Bug#8761)
1879 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1880 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1881 xfree instead of the default malloc, realloc, free.
1882 (Fgnutls_boot): No need to check for memory allocation failure,
1883 since xmalloc does that for us.
1885 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1886 * category.c (hash_get_category_set):
1887 * ccl.c (ccl_driver):
1888 * charset.c (Fdefine_charset_internal):
1889 * charset.h (struct charset.hash_index):
1890 * composite.c (get_composition_id, gstring_lookup_cache)
1891 (composition_gstring_put_cache):
1892 * composite.h (struct composition.hash_index):
1893 * dispextern.h (struct image.hash):
1894 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1895 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1896 (hashfn_equal, hashfn_user_defined, make_hash_table)
1897 (maybe_resize_hash_table, hash_lookup, hash_put)
1898 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1899 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1900 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1901 * image.c (make_image, search_image_cache, lookup_image)
1902 (xpm_put_color_table_h):
1903 * lisp.h (struct Lisp_Hash_Table):
1904 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1905 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1906 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1907 * alloc.c (allocate_vectorlike):
1908 Check for overflow in vector size calculations.
1909 * ccl.c (ccl_driver):
1910 Check for overflow when converting EMACS_INT to int.
1911 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1912 need to be updated by these changes.
1913 * fns.c (make_hash_table, maybe_resize_hash_table):
1914 Check for integer overflow with large hash tables.
1915 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1916 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1917 (SXHASH_REDUCE): New macro.
1918 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1919 Use it instead of discarding useful hash info with large hash values.
1920 (sxhash_float): New function.
1921 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1922 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1923 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1924 Rewrite to use FIXNUM_BITS, as this simplifies things.
1925 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1926 Adjust signatures to match updated version of code.
1927 (consing_since_gc): Now EMACS_INT, since a single hash table can
1928 use more than INT_MAX bytes.
1930 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1932 Make it possible to build with GCC-4.6+ -O2 -flto.
1934 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1936 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1938 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1939 Call minibuffer-inactive-mode.
1941 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1943 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1944 Update dependencies.
1946 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1948 * data.c (init_data): Remove code for UTS, this system is not
1951 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1953 Don't force ./temacs to start in terminal mode.
1955 * frame.c (make_initial_frame): Initialize faces in all cases, not
1956 only when CANNOT_DUMP is defined.
1957 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1959 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1961 * dispnew.c (add_window_display_history): Use const for the string
1962 pointer. Remove declaration, not needed.
1964 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1966 Use 'inline', not 'INLINE'.
1967 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1968 * alloc.c, fontset.c (INLINE): Remove.
1969 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1970 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1971 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1972 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1973 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1975 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1977 Make it possible to run ./temacs.
1979 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1980 syms_of_callproc does the same thing. Remove test for
1981 "initialized", do it in the caller.
1982 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1984 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1986 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1987 (read_minibuf): Use get_minibuffer.
1988 (syms_of_minibuf): Use DEFSYM.
1989 (Qmetadata): New var.
1990 * data.c (Qbuffer): Don't make it static.
1991 (syms_of_data): Use DEFSYM.
1993 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1995 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1996 (CCL_CODE_MIN): New macro.
1998 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2000 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2002 * eval.c (Qdebug): Now static.
2003 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2004 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2005 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2007 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2009 * image.c: Various fixes to ImageMagick code comments.
2010 (Fimagemagick_types): Doc fix.
2012 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2014 Minor fixes prompted by GCC 4.6.0 warnings.
2016 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2018 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2019 (x_clipboard_manager_save_all): Move extern decl to ...
2020 * xterm.h: ... here, so that it can be checked for consistency.
2022 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2024 * xselect.c (x_clipboard_manager_save_frame)
2025 (x_clipboard_manager_save_all): New functions.
2026 (Fx_clipboard_manager_save): Lisp function deleted.
2028 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2029 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2031 * xterm.h: Update prototype.
2033 2011-05-28 William Xu <william.xwl@gmail.com>
2035 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2038 2011-05-28 Jim Meyering <meyering@redhat.com>
2040 Avoid a sign-extension bug in crypto_hash_function.
2041 * fns.c (to_uchar): Define.
2042 (crypto_hash_function): Use it to convert some newly-signed
2043 variables to unsigned, to avoid sign-extension bugs. For example,
2044 without this change, (md5 "truc") would evaluate to
2045 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2046 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2047 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2049 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2051 Integer overflow fixes.
2053 * dbusbind.c: Serial number integer overflow fixes.
2054 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2055 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2056 to hold a serial number that is too large for a fixnum.
2057 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2058 Check for serial numbers out of range. Decode any serial number
2059 that was so large that it became a float. (Bug#8722)
2061 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2062 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2063 Use XFASTINT rather than XUINT when numbers are nonnegative.
2064 (xd_append_arg, Fdbus_method_return_internal):
2065 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2066 arguments, check that Lisp number is nonnegative, rather than
2067 silently wrapping negative numbers around. (Bug#8722)
2068 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2071 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2073 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2075 ccl: add integer overflow checks
2076 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2077 (IN_INT_RANGE): New macros.
2078 (ccl_driver): Use them to check for integer overflow when
2079 decoding a CCL program. Many of the new checks are whether XINT (x)
2080 fits in int; it doesn't always, on 64-bit hosts. The new version
2081 doesn't catch all possible integer overflows, but it's an
2082 improvement. (Bug#8719)
2084 * alloc.c (make_event_array): Use XINT, not XUINT.
2085 There's no need for unsigned here.
2087 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2088 This follows up to the 2011-05-06 change that substituted uintptr_t
2089 for EMACS_INT. This case wasn't caught back then.
2091 Rework Fformat to avoid integer overflow issues.
2092 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2093 now (part of C89). Include <verify.h>.
2094 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2095 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2096 (Fformat): Avoid the prepass trying to compute sizes; it was only
2097 approximate and thus did not catch overflow reliably. Instead, walk
2098 through the format just once, formatting and computing sizes as we go,
2099 checking for integer overflow at every step, and allocating a larger
2100 buffer as needed. Keep track separately whether the format is
2101 multibyte. Keep only the most-recently calculated precision, rather
2102 than them all. Record whether each argument has been converted to
2103 string. Use EMACS_INT, not int, for byte and char and arg counts.
2104 Support field widths and precisions larger than INT_MAX. Avoid
2105 sprintf's undefined behavior with conversion specifications such as %#d
2106 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2107 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2108 formatting out-of-range floating point numbers with int
2111 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2113 * data.c: Avoid integer truncation in expressions involving floats.
2114 * data.c: Include <intprops.h>.
2115 (arith_driver): When there's an integer overflow in an expression
2116 involving floating point, convert the integers to floating point
2117 so that the resulting value does not suffer from catastrophic
2118 integer truncation. For example, on a 64-bit host (* 4
2119 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2120 Do not rely on undefined behavior after integer overflow.
2122 merge count_size_as_multibyte, parse_str_to_multibyte
2123 * character.c, character.h (count_size_as_multibyte):
2124 Rename from parse_str_to_multibyte; all uses changed.
2125 Check for integer overflow.
2126 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2127 since it's now a duplicate of the other. This is more of
2128 a character than a buffer op, so better that it's in character.c.
2129 * fns.c, print.c: Adjust to above changes.
2131 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2133 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2135 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2137 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2138 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2139 (x_clipboard_manager_save): Now static.
2140 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2142 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2143 (crypto_hash_function): Now static.
2144 Fix pointer signedness problems. Avoid unnecessary initializations.
2146 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2148 * termhooks.h (Vselection_alist): Make it terminal-local.
2150 * terminal.c (create_terminal): Initialize it.
2152 * xselect.c: Support for clipboard managers.
2153 (Vselection_alist): Move to termhooks.h as terminal-local var.
2154 (LOCAL_SELECTION): New macro.
2155 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2156 (symbol_to_x_atom): Remove gratuitous arg.
2157 (x_handle_selection_request, lisp_data_to_selection_data)
2158 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2159 (x_own_selection, x_get_local_selection, x_convert_selection):
2160 New arg, specifying work frame. Use terminal-local Vselection_alist.
2161 (some_frame_on_display): Delete unused function.
2162 (Fx_own_selection_internal, Fx_get_selection_internal)
2163 (Fx_disown_selection_internal, Fx_selection_owner_p)
2164 (Fx_selection_exists_p): New optional frame arg.
2165 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2166 (x_handle_selection_clear): Don't treat other terminals with the
2167 same keyboard specially. Use the terminal-local Vselection_alist.
2168 (x_clear_frame_selections): Use Frun_hook_with_args.
2170 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2172 * xterm.h: Add support for those atoms.
2174 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2176 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2177 (converted_selections, conversion_fail_tag): New global variables.
2178 (x_selection_request_lisp_error): Free the above.
2179 (x_get_local_selection): Remove unnecessary code.
2180 (x_reply_selection_request): Args changed; handle arbitrary array
2181 of converted selections stored in converted_selections.
2182 Separate the XChangeProperty and SelectionNotify steps.
2183 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2184 (x_convert_selection): New function.
2185 (x_handle_selection_event): Simplify.
2186 (x_get_foreign_selection): Don't ignore incoming requests while
2187 waiting for an answer; this will fail when we implement
2188 SAVE_TARGETS, and seems unnecessary anyway.
2189 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2190 (Vx_sent_selection_functions): Doc fix.
2192 2011-05-26 Leo Liu <sdl.web@gmail.com>
2194 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2196 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2198 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2200 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2201 for fringe update if it has periodic bitmap.
2202 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2203 and fringe_bitmap_periodic_p.
2205 * fringe.c (get_fringe_bitmap_data): New function.
2206 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2207 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2208 row. Mark glyph row for fringe update if periodicity changed.
2210 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2211 for fringe update unless it has periodic bitmap.
2213 2011-05-25 Kenichi Handa <handa@m17n.org>
2215 * xdisp.c (get_next_display_element): Set correct it->face_id for
2216 a static composition.
2218 2011-05-24 Leo Liu <sdl.web@gmail.com>
2221 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2223 * fns.c (crypto_hash_function, Fsha1): New function.
2224 (Fmd5): Use crypto_hash_function.
2225 (syms_of_fns): Add Ssha1.
2227 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2229 * gnutls.c: Remove unused macros.
2230 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2231 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2232 Remove macros that are defined and never used.
2233 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2235 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2237 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2238 (Fx_get_selection_internal): Minor cleanup.
2239 (Fx_own_selection_internal): Rename arguments for consistency with
2242 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2244 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2246 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2248 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2250 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2252 * dispnew.c (scrolling_window): Don't exclude the case that the
2253 last enabled row in the desired matrix touches the bottom boundary.
2255 2011-05-21 Glenn Morris <rgm@gnu.org>
2257 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2258 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2259 and add some more files.
2261 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2263 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2264 report_file_error introduced by the change from 2011-05-07.
2266 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2268 * systime.h (Time): Define only if emacs is defined.
2269 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2270 where the include path doesn't have X11/X.h by default. See
2271 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2273 2011-05-20 Kenichi Handa <handa@m17n.org>
2275 * composite.c (find_automatic_composition): Fix previous change.
2277 2011-05-20 Glenn Morris <rgm@gnu.org>
2279 * lisp.mk: New file, split from Makefile.in.
2280 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2281 (shortlisp): Remove.
2282 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2284 2011-05-19 Glenn Morris <rgm@gnu.org>
2286 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2287 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2288 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2289 (lisp): Set the order to that of loadup.el.
2290 (shortlisp): Make it a copy of $lisp.
2291 (SOME_MACHINE_LISP): Remove.
2292 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2293 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2295 2011-05-18 Kenichi Handa <handa@m17n.org>
2297 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2298 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2299 (find_automatic_composition): Mostly rewrite for efficiency.
2301 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
2303 * makefile.w32-in: Update dependencies.
2305 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2307 * menu.c: Include limits.h (fixes the MS-Windows build broken by
2308 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
2310 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
2312 Fix some integer overflow issues, such as string length overflow.
2314 * insdel.c (count_size_as_multibyte): Check for string overflow.
2316 * character.c (lisp_string_width): Check for string overflow.
2317 Use EMACS_INT, not int, for string indexes and lengths; in
2318 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2319 the resulting string length overflows an EMACS_INT; instead,
2320 report a string overflow if no precision given. When checking for
2321 precision exhaustion, use a check that cannot possibly have
2322 integer overflow. (Bug#8675)
2323 * character.h (lisp_string_width): Adjust to new signature.
2325 * alloc.c (string_overflow): New function.
2326 (Fmake_string): Use it. This doesn't change behavior, but saves
2327 a few bytes and will simplify future changes.
2328 * character.c (string_escape_byte8): Likewise.
2329 * lisp.h (string_overflow): New decl.
2331 Fixups, following up to the user-interface timestamp change.
2332 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2333 for UI timestamps, instead of unsigned long.
2334 * msdos.c (mouse_get_pos): Likewise.
2335 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
2336 * w32gui.h (Time): Define by including "systime.h" rather than by
2337 declaring it ourselves. (Bug#8664)
2339 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2340 * image.c (clear_image_cache): Likewise.
2342 * term.c (term_mouse_position): Don't assume time_t wraparound.
2344 Be more systematic about user-interface timestamps.
2345 Before, the code sometimes used 'Time', sometimes 'unsigned long',
2346 and sometimes 'EMACS_UINT', to represent these timestamps.
2347 This change causes it to use 'Time' uniformly, as that's what X uses.
2348 This makes the code easier to follow, and makes it easier to catch
2349 integer overflow bugs such as Bug#8664.
2350 * frame.c (Fmouse_position, Fmouse_pixel_position):
2351 Use Time, not unsigned long, for user-interface timestamps.
2352 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2353 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2354 * keyboard.h (last_event_timestamp): Likewise.
2355 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2356 * menu.h (xmenu_show): Likewise.
2357 * term.c (term_mouse_position): Likewise.
2358 * termhooks.h (struct input_event.timestamp): Likewise.
2359 (struct terminal.mouse_position_hook): Likewise.
2360 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2361 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2362 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2363 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2365 * menu.h, termhooks.h: Include "systime.h", for Time.
2367 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2368 Don't assume that the difference between two unsigned long values
2369 can fit into an integer. At this point, we know button_down_time
2370 <= event->timestamp, so the difference must be nonnegative, so
2371 there's no need to cast the result if double-click-time is
2372 nonnegative, as it should be; check that it's nonnegative, just in
2373 case. This bug is triggered when events are more than 2**31 ms
2374 apart (about 25 days). (Bug#8664)
2376 * xselect.c (last_event_timestamp): Remove duplicate decl.
2377 (x_own_selection): Remove needless cast to unsigned long.
2379 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2380 that always fit in int. Use a sentinel instead of a counter, to
2381 avoid a temp and to allay GCC's concerns about possible int overflow.
2382 * frame.h (struct frame): Use int for menu_bar_items_used
2383 instead of EMACS_INT, since it always fits in int.
2385 * menu.c (grow_menu_items): Check for int overflow.
2387 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2389 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2390 Before, the code was not consistent. These values cannot exceed
2391 2**31 - 1 so there's no need to make them unsigned.
2392 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2393 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2394 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2396 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2398 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2399 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2400 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2401 presumably because the widths might not match.
2403 * window.c (size_window): Avoid needless test at loop start.
2405 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2407 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2409 2011-05-12 Drew Adams <drew.adams@oracle.com>
2411 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2413 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2415 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2416 `width' to `bar_area_x' and `bar_area_width', respectively.
2417 (x_scroll_run): Take account of fringe background extension.
2419 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2420 Rename local vars `left' and `width' to `bar_area_x' and
2421 `bar_area_width', respectively.
2422 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2423 background extension.
2425 2011-05-10 Jim Meyering <meyering@redhat.com>
2427 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2429 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
2431 * image.c (Finit_image_library): Return t for built-in image types,
2432 like pbm and xbm. (Bug#8640)
2434 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2436 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2438 2011-05-07 Eli Zaretskii <eliz@gnu.org>
2440 * w32console.c (Fset_screen_color): Doc fix.
2441 (Fget_screen_color): New function.
2442 (syms_of_ntterm): Defsubr it.
2444 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2445 unlink the temporary file if Fcall_process didn't create it in the
2447 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2448 child process will be redirected to a file specified with `:file'.
2449 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2450 cue to call_process_cleanup not to close that handle.
2452 2011-05-07 Ben Key <bkey76@gmail.com>
2454 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2455 one of two shell specific rules, either bootstrap-temacs-CMD or
2456 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2457 to the previous implementation of the bootstrap-temacs rule.
2458 The bootstrap-temacs-CMD rule is similar to the previous
2459 implementation of the bootstrap-temacs rule except that it
2460 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2463 These changes, along with some changes to nt/configure.bat,
2464 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2465 earlier fix to add support for --cflags and --ldflags options
2466 that include quotes so that it works whether make uses cmd or
2469 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
2471 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2472 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2474 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2475 a string. Handle both cases.
2476 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2477 (Fdbus_register_method): Use Qinvalid_function.
2479 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2481 * makefile.w32-in: Update dependencies.
2482 (LISP_H): Add inttypes.h and stdin.h.
2483 (PROCESS_H): Add unistd.h.
2485 2011-05-06 Eli Zaretskii <eliz@gnu.org>
2487 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2488 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2490 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
2492 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2494 * term.c (vfatal): Remove stray call to va_end.
2495 It's not needed and the C Standard doesn't allow it here anyway.
2497 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2498 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2500 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2503 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2505 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2507 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2509 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2511 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2513 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2514 * charset.c (Fdefine_charset_internal): Don't initialize
2515 charset.code_space[15]. The value was garbage, on hosts with
2516 32-bit int (Bug#8600).
2518 * lread.c (read_integer): Be more consistent with string-to-number.
2519 Use string_to_number to do the actual conversion; this avoids
2520 rounding errors and fixes some other screwups. Without this fix,
2521 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2522 (digit_to_number): Move earlier, for benefit of read_integer.
2523 Return -1 if the digit is out of range for the base, -2 if it is
2524 not a digit in any supported base. (Bug#8602)
2526 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2528 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2529 to match comment at start of function. This also removes a
2530 GCC warning about overflow in a 32+64-bit port.
2532 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2534 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2535 Reported by Stefan Monnier in
2536 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2537 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2538 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2540 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2541 (EMACS_UINTPTR): Likewise, with uintptr_t.
2543 * lisp.h: Prefer 64-bit EMACS_INT if available.
2544 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2545 on 32-bit hosts that have 64-bit int, so that they can access
2547 However, temporarily disable this change unless the temporary
2548 symbol WIDE_EMACS_INT is defined.
2550 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2552 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2553 This removes an assumption that EMACS_INT and long are the same
2554 width as pointers. The assumption is true for Emacs porting targets
2555 now, but we want to make other targets possible.
2556 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2557 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2558 In the rest of the code, change types of integers that hold casted
2559 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2560 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2561 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2562 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2563 No need to cast type when ORing.
2564 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2565 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2566 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2567 assume EMACS_INT is the same width as char *.
2568 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2569 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2570 Remove no-longer-needed casts.
2571 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2572 (xg_tool_bar_help_callback, xg_make_tool_item):
2573 Use EMACS_INTPTR to hold an integer
2574 that will be cast to void *; this can avoid a GCC warning
2575 if EMACS_INT is not the same width as void *.
2576 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2577 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2578 (current_message_1, set_message_1):
2579 Use a local to convert to proper width without a cast.
2580 * xmenu.c (dialog_selection_callback): Likewise.
2582 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2583 Also, don't assume VALBITS / RAND_BITS is less than 5,
2584 and don't rely on undefined behavior when shifting a 1 left into
2586 * lisp.h (get_random): Change signature to match.
2588 * lread.c (hash_string): Use size_t, not int, for hash computation.
2589 Normally we prefer signed values; but hashing is special, because
2590 it's better to use unsigned division on hash table sizes so that
2591 the remainder is nonnegative. Also, size_t is the natural width
2592 for hashing into memory. The previous code used 'int', which doesn't
2593 retain enough info to hash well into very large tables.
2594 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2596 * dbusbind.c: Don't possibly lose pointer info when converting.
2597 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2598 Use XPNTR rather than XHASH, so that the high-order bits of
2599 the pointer aren't lost when converting through void *.
2601 * eval.c (Fautoload): Don't double-shift a pointer.
2603 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2605 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2607 * gnutls.c (DEF_GNUTLS_FN):
2608 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2610 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2612 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2615 2011-05-05 Eli Zaretskii <eliz@gnu.org>
2617 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2618 New version that can reserve upto 2GB of heap space.
2620 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
2622 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2624 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2626 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2627 `gnutls_certificate_set_x509_key_file'.
2629 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
2631 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2632 Update dependencies.
2634 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2636 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2637 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2638 Remove unused parameter `fildes'.
2639 * process.c (read_process_output, send_process): Don't pass it.
2641 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2643 Fix previous change: the library cache is defined in w32.c.
2644 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2645 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2647 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2649 Implement dynamic loading of GnuTLS on Windows.
2651 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2652 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2653 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2656 * gnutls.c (Qgnutls_dll): Define.
2657 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2658 (gnutls_*): Declare function pointers.
2659 (init_gnutls_functions): New function to initialize function pointers.
2660 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2661 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2662 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2663 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2664 (emacs_gnutls_write, emacs_gnutls_read)
2665 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2666 (Fgnutls_available_p): New function.
2667 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2668 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2669 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2671 * image.c: Include w32.h.
2672 (Vimage_type_cache): Delete.
2673 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2674 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2675 (w32_delayed_load): Move to w32.c.
2677 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2679 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2680 (w32_delayed_load): Move from image.c. When loading a library, record
2681 its filename in the :loaded-from property of the library id.
2682 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2683 Initialize and staticpro them.
2684 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2686 * process.c: Include lisp.h before w32.h, not after.
2687 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2688 instead of gnutls_record_check_pending.
2690 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2692 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2694 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2695 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2698 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2700 * xterm.c (x_set_frame_alpha): Do not set property on anything
2701 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2703 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2705 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2707 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2709 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2710 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2711 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2712 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2713 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2714 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2715 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2716 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2717 (Qgnutls_bootprop_callbacks_verify): Make static.
2719 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2721 * callproc.c: Indentation fixup.
2723 * sysdep.c (wait_for_termination_1): Make static.
2724 (wait_for_termination, interruptible_wait_for_termination):
2725 Move after wait_for_termination_1.
2727 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2729 * sysdep.c (interruptible_wait_for_termination): New function
2730 which is like wait_for_termination, but allows keyboard
2733 * callproc.c (Fcall_process): Add (:file "file") as an option for
2735 (Fcall_process_region): Ditto.
2737 2011-04-30 Eli Zaretskii <eliz@gnu.org>
2739 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2740 rather than `XVECTOR (FOO)->size'.
2742 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2743 inttypes.h, as a gnulib replacement is used if it not available in
2746 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2748 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2749 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2750 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2752 * coding.c (coding_alloc_by_realloc): Error out if destination
2753 will grow beyond MOST_POSITIVE_FIXNUM.
2754 (decode_coding_emacs_mule): Abort if there isn't enough place in
2755 charbuf for the composition carryover bytes. Reserve an extra
2756 space for up to 2 characters produced in a loop.
2757 (decode_coding_iso_2022): Abort if there isn't enough place in
2758 charbuf for the composition carryover bytes.
2760 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2762 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2763 aborting when %lld or %lll format is passed.
2764 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2765 %llo or %llx format is passed. (Bug#8545)
2767 * window.c (window_scroll_line_based): Use a marker instead of
2768 simple variables to record original value of point. (Bug#7952)
2770 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2771 produced by %s or %c overflows available buffer space. (Bug#8545)
2773 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2775 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
2776 (SIZE_MAX): Move defn after all includes, as they might #define it.
2778 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2780 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2782 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2784 * keyboard.c (Qdelayed_warnings_hook): Define.
2785 (command_loop_1): Run `delayed-warnings-hook'
2786 if Vdelayed_warnings_list is non-nil.
2787 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2788 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2790 2011-04-28 Eli Zaretskii <eliz@gnu.org>
2792 * doprnt.c (doprnt): Don't return value smaller than the buffer
2793 size if the message was truncated. (Bug#8545).
2795 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2797 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2798 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2800 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2802 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2804 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
2806 * makefile.w32-in: Update dependencies.
2808 2011-04-27 Eli Zaretskii <eliz@gnu.org>
2810 Improve `doprnt' and its usage. (Bug#8545)
2811 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2812 `format_end'. Remove support for %l as a conversion specifier.
2813 Don't use xrealloc. Improve diagnostics when the %l size modifier
2814 is used. Update the commentary.
2816 * eval.c (verror): Simplify calculation of size_t.
2818 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2821 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2823 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2826 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2828 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2829 This makes this file independent of the recent pseudovector change.
2831 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2833 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2835 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2836 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2837 Remove unused local.
2838 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2840 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2841 GCC 4.6.0 optimizes based on type-based alias analysis.
2842 For example, if b is of type struct buffer * and v of type struct
2843 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2844 != &v->size, and therefore "v->size = 1; b->size = 2; return
2845 v->size;" must therefore return 1. This assumption is incorrect
2846 for Emacs, since it type-puns struct Lisp_Vector * with many other
2847 types. To fix this problem, this patch adds a new type struct
2848 vectorlike_header that documents the constraints on layout of vectors
2849 and pseudovectors, and helps optimizing compilers not get fooled
2850 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2851 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2852 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2854 (XSETPVECTYPE): Rewrite in terms of new macro.
2855 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2856 This is a bit clearer, and further avoids the possibility of
2857 undesirable aliasing.
2858 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2859 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2860 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2861 since Lisp_Subr is a special case (no "next" field).
2862 (ASIZE): Now uses header.size rather than size.
2863 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2864 to avoid the hassle of writing XVECTOR (foo)->header.size.
2865 (struct vectorlike_header): New type.
2866 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2867 object, to help avoid aliasing.
2868 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2869 (SUBRP): Likewise, since Lisp_Subr is a special case.
2870 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2871 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2872 (struct Lisp_Hash_Table): Combine first two members into a single
2873 struct vectorlike_header member. All uses of "size" and "next" members
2874 changed to be "header.size" and "header.next".
2875 * buffer.h (struct buffer): Likewise.
2876 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2877 * frame.h (struct frame): Likewise.
2878 * process.h (struct Lisp_Process): Likewise.
2879 * termhooks.h (struct terminal): Likewise.
2880 * window.c (struct save_window_data, struct saved_window): Likewise.
2881 * window.h (struct window): Likewise.
2882 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2883 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2884 * buffer.c (init_buffer_once): Likewise.
2885 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2887 * process.c (Fformat_network_address): Use local var for size,
2890 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2892 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2893 * data.c (atof): Remove decl; no longer used or needed.
2894 (digit_to_number): Move to lread.c.
2895 (Fstring_to_number): Use new string_to_number function, to be
2896 consistent with how the Lisp reader treats infinities and NaNs.
2897 Do not assume that floating-point numbers represent EMACS_INT
2898 without losing information; this is not true on most 64-bit hosts.
2899 Avoid double-rounding errors, by insisting on integers when
2900 parsing non-base-10 numbers, as the documentation specifies.
2901 * lisp.h (string_to_number): New decl, replacing ...
2902 (isfloat_string): Remove.
2903 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2904 (read1): Do not accept +. and -. as integers; this
2905 appears to have been a coding error. Similarly, do not accept
2906 strings like +-1e0 as floating point numbers. Do not report
2907 overflow for integer overflows unless the base is not 10 which
2908 means we have no simple and reliable way to continue.
2909 Break out the floating-point parsing into a new
2910 function string_to_number, so that Fstring_to_number parses
2911 floating point numbers consistently with the Lisp reader.
2912 (digit_to_number): Move here from data.c. Make it static inline.
2913 (E_CHAR, EXP_INT): Remove, replacing with ...
2914 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2915 (string_to_number): New function, replacing isfloat_string.
2916 This function checks for valid syntax and produces the resulting
2917 Lisp float number too. Rework it so that string-to-number
2918 no longer mishandles examples like "1.0e+". Use strtoumax,
2919 so that overflow for non-base-10 numbers is reported only when
2920 there's no portable and simple way to convert to floating point.
2922 * textprop.c (set_text_properties_1): Rewrite for clarity,
2923 and to avoid GCC warning about integer overflow.
2925 * intervals.h (struct interval): Use EMACS_INT for members
2926 where EMACS_UINT might cause problems. See
2927 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2928 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2929 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2931 (offset_intervals): Tell GCC not to worry about length overflow
2932 when negating a negative length.
2934 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2935 (overrun_check_free): Likewise.
2937 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2938 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2941 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2942 (gnutls_make_error): Rename local to avoid shadowing.
2943 (gnutls_emacs_global_deinit): ifdef out; not used.
2944 (Fgnutls_boot): Use const for pointer to readonly storage.
2945 Comment out unused local. Fix pointer signedness problems.
2947 * lread.c (openp): Don't stuff size_t into an 'int'.
2948 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2949 about possible signed overflow.
2951 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2952 (GDK_KEY_g): Don't define if already defined.
2953 (xg_prepare_tooltip): Avoid pointer signedness problem.
2954 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2956 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2957 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2959 * xfns.c (Fx_window_property): Simplify a bit,
2960 to make a bit faster and to avoid GCC 4.6.0 warning.
2961 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2963 * fns.c (internal_equal): Don't assume size_t fits in int.
2965 * alloc.c (compact_small_strings): Tighten assertion a little.
2967 Replace pEd with more-general pI, and fix some printf arg casts.
2968 * lisp.h (pI): New macro, generalizing old pEd macro to other
2969 conversion specifiers. For example, use "...%"pI"d..." rather
2970 than "...%"pEd"...".
2971 (pEd): Remove. All uses replaced with similar uses of pI.
2972 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2973 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2974 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2975 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2976 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2977 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2978 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2980 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2981 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2982 * print.c (safe_debug_print, print_object): Likewise.
2983 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2985 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2986 avoiding the 0 flag, which is not portable.
2987 * process.c (Fmake_network_process): Use pI to avoid cast.
2988 * region-cache.c (pp_cache): Likewise.
2989 * xdisp.c (decode_mode_spec): Likewise.
2990 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2991 behavior on 64-bit hosts with printf arg.
2992 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2993 (x_stop_queuing_selection_requests): Likewise.
2994 (x_get_window_property): Don't truncate byte count to an 'int'
2997 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2998 here, since it parses constructs like leading '-' and spaces,
2999 which are not wanted; and it overflows with large numbers.
3000 Instead, simply match F[0-9]+, which is what is wanted anyway.
3002 * alloc.c: Remove unportable assumptions about struct layout.
3003 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3004 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3005 (allocate_vectorlike, make_pure_vector): Use the new macros,
3006 plus offsetof, to remove unportable assumptions about struct layout.
3007 These assumptions hold on all porting targets that I know of, but
3008 they are not guaranteed, they're easy to remove, and removing them
3009 makes further changes easier.
3011 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3012 This doesn't fix a bug but makes the code clearer.
3013 (string_overrun_cookie): Now const. Use initializers that
3014 don't formally overflow signed char, to avoid warnings.
3015 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3016 can cause Emacs to crash when string overrun checking is enabled.
3017 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3018 multiple of sizeof (EMACS_INT); it need not be, if
3019 alignof(EMACS_INT) < sizeof (EMACS_INT).
3020 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3022 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3024 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3026 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3028 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3029 supposed to be handshaking. (Bug#8556)
3030 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3032 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3034 * lisp.h (Qdebug): List symbol.
3035 * eval.c (Qdebug): Restore global linkage.
3036 * keyboard.c (debug-on-event): New variable.
3037 (handle_user_signal): Break into debugger when debug-on-event
3038 matches the current signal symbol.
3040 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3042 * alloc.c (check_sblock, check_string_bytes)
3043 (check_string_free_list): Convert to standard C.
3045 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3047 * w32.c (emacs_gnutls_push): Fix typo.
3049 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3051 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3052 "cast to pointer from integer of different size".
3054 Improve doprnt and its use in verror. (Bug#8545)
3055 * doprnt.c (doprnt): Document the set of format control sequences
3056 supported by the function. Use SAFE_ALLOCA instead of always
3059 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3060 is one byte too soon. Don't use xrealloc; instead xfree and
3063 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3065 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3068 * gnutls.c: Renamed global_initialized to
3069 gnutls_global_initialized. Added internals for the
3070 :verify-hostname-error, :verify-error, and :verify-flags
3071 parameters of `gnutls-boot' and documented those parameters in the
3072 docstring. Start callback support.
3073 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3074 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3075 on error. Return error code.
3076 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3077 (emacs_gnutls_read): Likewise.
3078 (Fgnutls_boot): Return handshake error code.
3079 (emacs_gnutls_handle_error): New function.
3080 (wsaerror_to_errno): Likewise.
3082 * w32.h (emacs_gnutls_pull): Add prototype.
3083 (emacs_gnutls_push): Likewise.
3085 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3086 (emacs_gnutls_push): Likewise.
3088 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3090 * process.c (wait_reading_process_output): Check if GnuTLS
3091 buffered some data internally if no FDs are set for TLS
3094 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3095 (LIBS): Link to USER_LIBS.
3096 ($(BLD)/gnutls.$(0)): New target.
3098 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3100 * xdisp.c (handle_single_display_spec): Rename the
3101 display_replaced_before_p argument into display_replaced_p, to
3102 make it consistent with the commentary. Fix typos in the
3105 * textprop.c (syms_of_textprop): Remove dead code.
3106 (copy_text_properties): Delete obsolete commentary about an
3107 interface that was deleted long ago. Fix typos in the description
3110 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3111 to changes in oldXMenu/XMenu.h from 2011-04-16.
3112 <menu_help_message, prev_menu_help_message>: Constify.
3113 (IT_menu_make_room): menu->help_text is now `const char **';
3116 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3117 to changes in oldXMenu/XMenu.h from 2011-04-16.
3118 (struct XMenu): Declare `help_text' `const char **'.
3120 * xfaces.c <Qunspecified>: Make extern again.
3122 * syntax.c: Include sys/types.h before including regex.h, as
3125 * doc.c (get_doc_string): Improve the format passed to `error'.
3127 * doprnt.c (doprnt): Improve commentary.
3129 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3131 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3134 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3135 changes in globals.h immediately force recompilation.
3136 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3137 $(CURDIR)/s/ms-w32.h.
3138 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3140 * character.c (Fchar_direction): Function deleted.
3141 (syms_of_character): Don't defsubr it.
3142 <char-direction-table>: Deleted.
3144 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3146 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3147 * doprnt.c: Include limits.h.
3148 (SIZE_MAX): New macro.
3149 (doprnt): Return a size_t value. 2nd arg is now size_t.
3150 Many local variables are now size_t instead of int or unsigned.
3151 Improve overflow protection. Support `l' modifier for integer
3152 conversions. Support %l conversion. Don't assume an EMACS_INT
3153 argument for integer conversions and for %c.
3155 * lisp.h (doprnt): Restore prototype.
3157 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3160 * Makefile.in (base_obj): Add back doprnt.o.
3162 * deps.mk (doprnt.o): Add back prerequisites.
3163 (callint.o): Depend on character.h.
3165 * eval.c (internal_lisp_condition_case): Include the handler
3166 representation in the error message.
3167 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3168 when breaking from the loop.
3170 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3172 * callint.c (Fcall_interactively): When displaying error message
3173 about invalid control letter, pass the character's codepoint, not
3174 a pointer to its multibyte form. Improve display of the character
3175 in octal and display also its hex code.
3177 * character.c (char_string): Use %x to display the (unsigned)
3178 codepoint of an invalid character, to avoid displaying a bogus
3181 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3182 `error', not SYMBOL_NAME itself.
3184 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3185 character arguments to `error'.
3187 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3188 to `error' in error message about FINAL_CHAR argument. Make sure
3189 FINAL_CHAR is a character, and use %c when it is passed as
3190 argument to `error'.
3192 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3194 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3196 * w32.c: Include <time.h>.
3197 (sys_localtime): New function.
3199 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
3201 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3203 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3205 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3207 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3210 2011-04-19 Eli Zaretskii <eliz@gnu.org>
3212 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3213 gl_state.e_property when gl_state.object is Qt.
3215 * insdel.c (make_gap_larger): Remove limitation of buffer size
3218 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
3220 * xdisp.c (lookup_glyphless_char_display)
3221 (produce_glyphless_glyph): Handle cons cell entry in
3222 glyphless-char-display.
3223 (Vglyphless_char_display): Document it.
3225 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3226 glyphless-char-display.
3228 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
3230 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3232 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3234 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3235 definition for no-X builds.
3237 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3239 Static checks with GCC 4.6.0 and non-default toolkits.
3241 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3243 * process.c (keyboard_bit_set): Define only if SIGIO.
3244 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3245 (send_process): Repair possible setjmp clobbering.
3247 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3249 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3251 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3253 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3254 Define only if needed.
3256 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3257 by pacifying GCC about it. Maybe it's time to retire it?
3258 * xfaces.c (USG, __TIMEVAL__): Likewise.
3260 * dispextern.h (struct redisplay_interface): Rename param
3262 * termhooks.h (struct terminal): Likewise.
3263 * xterm.c (xembed_send_message): Likewise.
3265 * insdel.c (make_gap_smaller): Define only if
3266 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3268 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3271 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3272 so that we aren't warned about unused symbols.
3274 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3276 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
3278 * xfns.c (x_real_positions): Mark locals as initialized.
3280 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3282 * xterm.c: Fix problems found by static analysis with other toolkits.
3283 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
3284 (x_dispatch_event): Declare static if USE_GTK, and
3285 define if USE_GTK || USE_X_TOOLKIT.
3286 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
3287 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
3288 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3289 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
3291 * xmenu.c (menu_help_callback): Pointer type fixes.
3292 Use const pointers when pointing at readonly data. Avoid pointer
3294 (FALSE): Remove unused macro.
3295 (update_frame_menubar): Remove unused decl.
3297 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3299 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3300 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3301 (single_menu_item): Rename local to avoid shadowing.
3303 * keyboard.c (make_lispy_event): Remove unused local var.
3305 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3306 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3308 * bitmaps: Change bitmaps from unsigned char back to the X11
3309 compatible char. Avoid the old compiler warnings about
3310 out-of-range initializers by using, for example, '\xab' rather
3313 * xgselect.c (xgselect_initialize): Check vs interface
3314 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3316 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3318 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3319 to read-only memory.
3321 * fns.c (vector): Remove; this old hack is no longer needed.
3323 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
3325 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
3327 * xrdb.c (x_load_resources): Omit unused local.
3329 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
3330 (x_window): Rename locals to avoid shadowing.
3331 (USG): Use the kludged USG macro, to pacify gcc.
3333 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
3334 (x_term_init): Remove local to avoid shadowing.
3336 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
3338 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3339 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3341 2011-04-16 Eli Zaretskii <eliz@gnu.org>
3343 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3345 Fix regex.c, syntax.c and friends for buffers > 2GB.
3346 * syntax.h (struct gl_state_s): Declare character position members
3349 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3351 * textprop.c (verify_interval_modification, interval_of):
3352 Declare arguments EMACS_INT.
3354 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3357 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3359 * indent.c (Fvertical_motion): Local variable it_start is now
3362 * regex.c (re_match, re_match_2, re_match_2_internal)
3363 (bcmp_translate, regcomp, regexec, print_double_string)
3364 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3365 (re_compile_pattern, re_exec): Declare arguments and local
3366 variables `size_t' and `ssize_t' and return values `regoff_t', as
3368 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3369 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3370 <compile_stack_type>: `size' and `avail' are now `size_t'.
3372 * regex.h <regoff_t>: Use ssize_t, not int.
3373 (re_search, re_search_2, re_match, re_match_2): Arguments that
3374 specify buffer/string position and length are now ssize_t and
3375 size_t. Return type is regoff_t.
3377 2011-04-16 Ben Key <bkey76@gmail.com>
3379 * nsfont.m: Fixed bugs in ns_get_family and
3380 ns_descriptor_to_entity that were caused by using free to
3381 deallocate memory blocks that were allocated by xmalloc (via
3382 xstrdup). This caused Emacs to crash when compiled with
3383 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3384 --enable-checking=xmallocoverrun). xfree is now used to
3385 deallocate these memory blocks.
3387 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3389 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3391 emacs_write: Accept and return EMACS_INT for sizes.
3392 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3394 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3395 Accept and return EMACS_INT.
3396 (emacs_gnutls_write): Return the number of bytes written on
3398 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
3399 (emacs_read, emacs_write): Remove check for negative size, as the
3400 Emacs source code has been audited now.
3401 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3402 (emacs_read, emacs_write): Use it.
3403 * process.c (send_process): Adjust to the new signatures of
3404 emacs_write and emacs_gnutls_write. Do not attempt to store
3405 a byte offset into an 'int'; it might overflow.
3406 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
3408 * sound.c: Don't assume sizes fit in 'int'.
3409 (struct sound_device.period_size, alsa_period_size):
3410 Return EMACS_INT, not int.
3411 (struct sound_device.write, vox_write, alsa_write):
3412 Accept EMACS_INT, not int.
3413 (wav_play, au_play): Use EMACS_INT to store sizes and to
3414 record read return values.
3416 2011-04-15 Ben Key <bkey76@gmail.com>
3418 * keyboard.c (Qundefined): Don't declare static since it is used
3420 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3421 static since they are used in nsfont.m.
3423 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3425 * process.c (Qprocessp): Don't declare static.
3426 * lisp.h (Qprocessp): Declare again.
3428 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
3430 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3432 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3434 Improve C-level modularity by making more things 'static'.
3436 Don't publish debugger-only interfaces to other modules.
3437 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3438 (verify_bytepos, count_markers): Move decls to the only modules
3440 * region-cache.h (pp_cache): Likewise.
3441 * window.h (check_all_windows): Likewise.
3442 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3444 * sysdep.c (croak): Now static, if
3445 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3446 * syssignal.h (croak): Declare only if not static.
3448 * alloc.c (refill_memory_reserve): Now static if
3449 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3450 * lisp.h (refill_memory_reserve): Declare only if not static.
3452 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3453 Define only if USE_LUCID.
3455 * xrdb.c (x_customization_string, x_rm_string): Now static.
3457 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3458 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3460 * xdisp.c (draw_row_with_mouse_face): Now static.
3461 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3463 * window.h (check_all_windows): Mark externally visible.
3465 * window.c (window_deletion_count): Now static.
3467 * undo.c: Make symbols static if they're not exported.
3468 (last_undo_buffer, last_boundary_position, pending_boundary):
3471 * textprop.c (interval_insert_behind_hooks): Now static.
3472 (interval_insert_in_front_hooks): Likewise.
3474 * term.c: Make symbols static if they're not exported.
3475 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3476 (max_frame_lines, tty_set_terminal_modes):
3477 (tty_reset_terminal_modes, tty_turn_off_highlight):
3478 (get_tty_terminal): Now static.
3479 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3480 * termhooks.h (term_mouse_moveto): Do not declare if
3482 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3483 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3485 * sysdep.c: Make symbols static if they're not exported.
3486 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3488 (sigprocmask_set, full_mask): Remove; unused.
3489 (wait_debugging): Mark as visible.
3490 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3491 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3493 * syntax.c (syntax_temp): Define only if !__GNUC__.
3495 * sound.c (current_sound_device, current_sound): Now static.
3497 * search.c (searchbufs, searchbuf_head): Now static.
3499 * scroll.c (scroll_cost): Remove; unused.
3500 * dispextern.h (scroll_cost): Remove decl.
3502 * region-cache.h (pp_cache): Mark as externally visible.
3504 * process.c: Make symbols static if they're not exported.
3505 (process_tick, update_tick, create_process, chan_process):
3506 (Vprocess_alist, proc_buffered_char, datagram_access):
3507 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3508 (deactivate_process): Mark defn as static, as well as decl.
3509 * lisp.h (create_process): Remove decl.
3510 * process.h (chan_process, Vprocess_alist): Remove decls.
3512 * print.c: Make symbols static if they're not exported.
3513 (print_depth, new_backquote_output, being_printed, print_buffer):
3514 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3515 (print_interval, print_number_index, initial_stderr_stream):
3517 * lisp.h (Fprinc): Remove decl.
3518 (debug_output_compilation_hack): Mark as externally visible.
3520 * sysdep.c (croak): Move decl from here to syssignal.h.
3521 * syssignal.h (croak): Put it here, so the API can be checked when
3522 'croak' is called from dissociate_if_controlling_tty.
3524 * minibuf.c: Make symbols static if they're not exported.
3525 (minibuf_save_list, choose_minibuf_frame): Now static.
3526 * lisp.h (choose_minibuf_frame): Remove decl.
3528 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3530 * lread.c: Make symbols static if they're not exported.
3531 (read_objects, initial_obarray, oblookup_last_bucket_number):
3533 (make_symbol): Remove; unused.
3534 * lisp.h (initial_obarray, make_symbol): Remove decls.
3536 * keyboard.c: Make symbols static if they're not exported.
3537 (single_kboard, recent_keys_index, total_keys, recent_keys):
3538 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3539 (this_single_command_key_start, echoing, last_auto_save):
3540 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3541 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3542 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3543 (Vlispy_mouse_stem, double_click_count):
3545 (force_auto_save_soon): Define only if SIGDANGER.
3546 (ignore_mouse_drag_p): Now static if
3547 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3548 (print_help): Remove; unused.
3549 (stop_character, last_timer_event): Mark as externally visible.
3550 * keyboard.h (ignore_mouse_drag_p): Declare only if
3551 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3552 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3553 * lisp.h (echoing): Remove decl.
3554 (force_auto_save_soon): Declare only if SIGDANGER.
3555 * xdisp.c (redisplay_window): Simplify code, to make it more
3556 obvious that ignore_mouse_drag_p is not accessed if !defined
3557 USE_GTK && !defined HAVE_NS.
3559 * intervals.c: Make symbols static if they're not exported.
3560 (merge_properties_sticky, merge_interval_right, delete_interval):
3562 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3564 * insdel.c: Make symbols static if they're not exported.
3565 However, leave prepare_to_modify_buffer alone. It's never
3566 called from outside this function, but that appears to be a bug.
3567 (combine_after_change_list, combine_after_change_buffer):
3568 (adjust_after_replace, signal_before_change): Now static.
3569 (adjust_after_replace_noundo): Remove; unused.
3570 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3571 (signal_before_change): Remove decls.
3573 * indent.c (val_compute_motion, val_vmotion): Now static.
3575 * image.c: Make symbols static if they're not exported.
3576 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3578 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3579 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3581 * fringe.c (standard_bitmaps): Now static.
3582 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3584 * frame.c: Make symbols static if they're not exported.
3585 (x_report_frame_params, make_terminal_frame): Now static.
3586 (get_frame_param): Now static, unless HAVE_NS.
3587 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3588 (x_get_resource_string): Remove; not used.
3589 * frame.h (make_terminal_frame, x_report_frame_params):
3590 (x_get_resource_string); Remove decls.
3591 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3592 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3594 * font.c, fontset.c: Make symbols static if they're not exported.
3595 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3596 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3597 * font.c (font_close_object): Now static.
3598 * font.h (font_close_object): Remove.
3599 * fontset.c (FONTSET_OBJLIST): Remove.
3600 (free_realized_fontset) #if-0 the body, which does nothing.
3601 (face_suitable_for_char_p): #if-0, as it's never called.
3602 * fontset.h (face_suitable_for_char_p): Remove decl.
3603 * xfaces.c (face_at_string_position):
3604 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
3605 since 0 is always ASCII.
3607 * fns.c (weak_hash_tables): Now static.
3609 * fileio.c: Make symbols static if they're not exported.
3610 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3611 (Vwrite_region_annotation_buffers): Now static.
3613 * eval.c: Make symbols static if they're not exported.
3614 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3615 * lisp.h (backtrace_list): Remove decl.
3617 * emacs.c: Make symbols static if they're not exported.
3618 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3619 (fatal_error_code, fatal_error_signal_hook, standard_args):
3621 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3622 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3623 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3624 * lisp.h (fatal_error_signal_hook): Remove decl.
3625 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3627 * editfns.c: Move a (normally-unused) function to its only use.
3628 * editfns.c, lisp.h (get_operating_system_release): Remove.
3629 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3630 worth the hassle of breaking this out.
3632 * xterm.c: Make symbols static if they're not exported.
3633 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3634 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3635 (x_destroy_window, x_delete_display):
3637 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3638 (x_mouse_leave): Remove; unused.
3639 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3640 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3641 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3643 (x_mouse_leave): Declare only if WINDOWSNT.
3644 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3645 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3648 * ftxfont.c: Make symbols static if they're not exported.
3649 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3651 * font.h (ftxfont_driver): Likewise.
3653 * xfns.c: Make symbols static if they're not exported.
3654 (x_last_font_name, x_display_info_for_name):
3655 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3656 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3657 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3658 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3659 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3660 (last_show_tip_args): Now static.
3661 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3662 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3663 (x_screen_planes): Remove; unused.
3664 * dispextern.h (x_screen_planes): Remove decl.
3666 * dispnew.c: Make symbols static if they're not exported.
3667 * dispextern.h (redraw_garbaged_frames, scrolling):
3668 (increment_row_positions): Remove.
3669 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3670 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3672 (redraw_garbaged_frames): Remove; unused.
3674 * xfaces.c: Make symbols static if they're not exported.
3675 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3677 * xterm.h (defined_color): Remove decls.
3678 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3679 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3680 (menu_face_changed_default, defined_color, free_realized_face):
3681 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3682 (ascii_face_of_lisp_face): Remove; unused.
3684 * xdisp.c: Make symbols static if they're not exported.
3685 * dispextern.h (scratch_glyph_row, window_box_edges):
3686 (glyph_to_pixel_coords, set_cursor_from_row):
3687 (get_next_display_element, set_iterator_to_next):
3688 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3689 (show_mouse_face): Remove decls
3690 * frame.h (message_buf_print): Likewise.
3691 * lisp.h (pop_message, set_message, check_point_in_composition):
3693 * xterm.h (set_vertical_scroll_bar): Likewise.
3694 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3695 (message_buf_print, scratch_glyph_row, displayed_buffer):
3696 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3697 (get_next_display_element, show_mouse_face, window_box_edges):
3698 (frame_to_window_pixel_xy, check_point_in_composition):
3699 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3700 (glyph_to_pixel_coords): Remove; unused.
3702 * dired.c (file_name_completion): Now static.
3704 * dbusbind.c (xd_in_read_queued_messages): Now static.
3706 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3707 * data.c (circular_list_error): Remove.
3709 * commands.h (last_point_position, last_point_position_buffer):
3710 (last_point_position_window): Remove decls.
3711 * keyboard.c: Make these variables static.
3713 * coding.h (coding, code_convert_region, encode_coding_gap):
3715 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3716 (iso_code_class, detect_coding, code_convert_region): Now static.
3717 (encode_coding_gap): Remove; unused.
3719 * chartab.c (chartab_chars, chartab_bits): Now static.
3721 * charset.h (charset_iso_8859_1): Remove decl.
3722 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3725 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3726 * ccl.c (Vccl_program_table): Now static.
3727 (check_ccl_update): Remove; unused.
3729 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3730 * category.h: ... from here.
3731 * category.c (check_category_table, set_category_set): Now static.
3733 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3734 * lisp.h: Remove these decls.
3736 * buffer.c (buffer_count): Remove unused var.
3738 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3739 so that it's not optimized away.
3740 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3741 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3742 exported only to the debugger.
3744 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
3745 * atimer.h (run_all_atimers): Remove; not exported.
3747 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3748 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3749 was inaccessible from Lisp.
3750 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3751 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3753 alloc.c: Import and export fewer symbols, and remove unused items.
3754 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3756 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3757 it's not optimized away by whole-program optimization.
3758 (message_enable_multibyte, free_misc): Remove.
3759 (catchlist, handlerlist, mark_backtrace):
3760 Declare only if BYTE_MARK_STACK.
3761 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3762 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3763 (message_enable_multibyte): Remove decl.
3764 (free_misc, interval_free_list, float_block, float_block_index):
3765 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3766 (cons_free_list, last_marked_index):
3768 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3769 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3770 (mark_backtrace): Define only if BYTE_MARK_STACK.
3771 * xdisp.c (message_enable_multibyte): Now static.
3773 Declare Lisp_Object Q* variables to be 'static' if not exported.
3774 This makes it easier for human readers (and static analyzers)
3775 to see whether these variables are used from other modules.
3776 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3777 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3778 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3779 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3780 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3781 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3782 * xmenu.c, xselect.c:
3783 Declare Q* vars static if they are not used in other modules.
3784 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3785 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3786 Remove decls of unexported vars.
3787 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3789 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3791 Make Emacs functions such as Fatom 'static' by default.
3792 This makes it easier for human readers (and static analyzers)
3793 to see whether these functions can be called from other modules.
3794 DEFUN now defines a static function. To make the function external
3795 so that it can be used in other C modules, use the new macro DEFUE.
3796 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3797 (Finit_image_library):
3798 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3799 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3800 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3801 Remove decls, since these functions are now static.
3802 (Funintern, Fget_internal_run_time): New decls, since these functions
3803 were already external.
3805 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3806 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3807 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3808 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3809 * keyboard.c, keymap.c, lread.c:
3810 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3811 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3812 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3813 Mark functions with DEFUE instead of DEFUN,
3814 if they are used in other modules.
3815 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3816 decls for now-static functions.
3817 * buffer.h (Fdelete_overlay): Remove decl.
3818 * callproc.c (Fgetenv_internal): Mark as internal.
3819 * composite.c (Fremove_list_of_text_properties): Remove decl.
3820 (Fcomposition_get_gstring): New forward static decl.
3821 * composite.h (Fcomposite_get_gstring): Remove decl.
3822 * dired.c (Ffile_attributes): New forward static decl.
3823 * doc.c (Fdocumntation_property): New forward static decl.
3824 * eval.c (Ffetch_bytecode): New forward static decl.
3825 (Funintern): Remove extern decl; now in .h file where it belongs.
3826 * fileio.c (Fmake_symbolic_link): New forward static decl.
3827 * image.c (Finit_image_library): New forward static decl.
3828 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3829 * intervals.h (Fprevious_property_change):
3830 (Fremove_list_of_text_properties): Remove decls.
3831 * keyboard.c (Fthis_command_keys): Remove decl.
3832 (Fcommand_execute): New forward static decl.
3833 * keymap.c (Flookup_key): New forward static decl.
3834 (Fcopy_keymap): Now static.
3835 * keymap.h (Flookup_key): Remove decl.
3836 * process.c (Fget_process): New forward static decl.
3837 (Fprocess_datagram_address): Mark as internal.
3838 * syntax.c (Fsyntax_table_p): New forward static decl.
3839 (skip_chars): Remove duplicate decl.
3840 * textprop.c (Fprevious_property_change): New forward static decl.
3841 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3843 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3844 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3846 * editfns.c (Fformat): Remove unreachable code.
3848 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3850 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3853 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3855 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3856 when at ZV. (Bug#8487)
3858 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3860 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3862 * keyboard.c (parse_tool_bar_item): Likewise.
3863 * sound.c (sound_cleanup, alsa_close): Likewise.
3864 * termcap.c (tgetent): Likewise.
3865 * xfns.c (x_default_font_parameter): Likewise.
3866 * xsettings.c (read_and_apply_settings): Likewise.
3868 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3869 (overrun_check_free): Protoize.
3871 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3873 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3874 since callers should never pass a negative size.
3875 Change the signature to match that of plain 'read' and 'write'; see
3876 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3877 * lisp.h: Update prototypes of emacs_write and emacs_read.
3879 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3881 * xdisp.c (redisplay_window): Don't try to determine the character
3882 position of the scroll margin if the window start point w->startp
3883 is outside the buffer's accessible region. (Bug#8468)
3885 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3887 Fix write-region and its subroutines for buffers > 2GB.
3888 * fileio.c (a_write, e_write): Modify declaration of arguments and
3889 local variables to support buffers larger than 2GB.
3890 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3892 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3893 argument, local variables, and return value.
3895 * lisp.h: Update prototypes of emacs_write and emacs_read.
3897 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3899 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3901 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3903 Fix more problems found by GCC 4.6.0's static checks.
3905 * xdisp.c (vmessage): Use a better test for character truncation.
3907 * charset.c (load_charset_map): <, not <=, for optimization,
3908 and to avoid potential problems with integer overflow.
3909 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3910 * casetab.c (set_identity, shuffle): Likewise.
3911 * editfns.c (Fformat): Likewise.
3912 * syntax.c (skip_chars): Likewise.
3914 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3915 This also lets GCC 4.6.0 generate slightly better loop code.
3917 * callint.c (Fcall_interactively): <, not <=, for optimization.
3918 (Fcall_interactively): Count the number of arguments produced,
3919 not the number of arguments given. This is simpler and lets GCC
3920 4.6.0 generate slightly better code.
3922 * ftfont.c: Distingish more carefully between FcChar8 and char.
3923 The previous code passed unsigned char * to a functions like
3924 strlen and xstrcasecmp that expect char *, which does not
3925 conform to the C standard.
3926 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3927 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3928 char * when the C standard requires it.
3930 * keyboard.c (read_char): Remove unused var.
3932 * eval.c: Port to Windows vsnprintf (Bug#8435).
3934 (SIZE_MAX): Define if the headers do not.
3935 (verror): Do not give up if vsnprintf returns a negative count.
3936 Instead, grow the buffer. This ports to Windows vsnprintf, which
3937 does not conform to C99. Problem reported by Eli Zaretskii.
3938 Also, simplify the allocation scheme, by avoiding the need for
3939 calling realloc, and removing the ALLOCATED variable.
3941 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3943 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3944 But keep the doprint source code for now, as we might revamp it
3945 and use it again (Bug#8435).
3946 * lisp.h (doprnt): Remove.
3947 * Makefile.in (base_obj): Remove doprnt.o.
3948 * deps.mk (doprnt.o): Remove.
3950 error: Print 32- and 64-bit integers portably (Bug#8435).
3951 Without this change, on typical 64-bit hosts error ("...%d...", N)
3952 was used to print both 32- and 64-bit integers N, which relied on
3954 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3956 * lisp.h (error, verror): Mark as printf-like functions.
3957 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3958 Report overflow in size calculations when allocating printf buffer.
3959 Do not truncate output string at its first null byte.
3960 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3961 Truncate the output at a character boundary, since vsnprintf does not
3963 * charset.c (check_iso_charset_parameter): Convert internal
3964 character to string before calling 'error', since %c now has the
3966 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3967 overflow when computing char to be passed to 'error'. Do not
3968 pass Lisp_Object to 'error'; pass the integer instead.
3969 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3970 formatted with plain %d.
3972 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3974 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3976 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3978 * xterm.c (x_catch_errors): Remove duplicate declaration.
3980 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3982 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3984 2011-04-10 Jim Meyering <meyering@redhat.com>
3986 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3987 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3988 return ssize_t not "int", and use size_t as the buffer length.
3989 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3990 * gnutls.h: Update declarations.
3991 * process.c (read_process_output): Use ssize_t, to match.
3992 (send_process): Likewise.
3994 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3996 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3998 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4000 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4001 Use unsigned char, to match FcChar8 type definition.
4003 * xterm.c (handle_one_xevent):
4004 * xmenu.c (create_and_show_popup_menu):
4005 * xselect.c (x_decline_selection_request)
4006 (x_reply_selection_request): Avoid type-punned deref of X events.
4008 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4010 Fix some uses of `int' instead of EMACS_INT.
4011 * search.c (string_match_1, fast_string_match)
4012 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4013 (scan_buffer, find_next_newline_no_quit)
4014 (find_before_next_newline, search_command, Freplace_match)
4015 (Fmatch_data): Make some `int' variables be EMACS_INT.
4017 * xdisp.c (display_count_lines): 3rd argument and return value now
4018 EMACS_INT. All callers changed.
4019 (pint2hrstr): Last argument is now EMACS_INT.
4021 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4022 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4023 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4024 (decode_coding_utf_16, decode_coding_emacs_mule)
4025 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4026 (decode_coding_ccl, decode_coding_charset)
4027 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4028 (decode_coding_iso_2022, decode_coding_emacs_mule)
4029 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4030 <char_offset, last_offset>: Declare EMACS_INT.
4031 (encode_coding_utf_8, encode_coding_utf_16)
4032 (encode_coding_emacs_mule, encode_invocation_designation)
4033 (encode_designation_at_bol, encode_coding_iso_2022)
4034 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4035 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4037 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4038 (encode_invocation_designation): Last argument P_NCHARS is now
4040 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4041 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4043 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4046 * ccl.c (Fccl_execute_on_string): Declare some variables
4049 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4051 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4053 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4055 * process.c (Fformat_network_address): Doc fix.
4057 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4059 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4061 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4063 * keyboard.c (read_char): Call Lisp function help-form-show,
4064 instead of using internal_with_output_to_temp_buffer.
4065 (Qhelp_form_show): New var.
4066 (syms_of_keyboard): Use DEFSYM macro.
4068 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4070 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4072 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4074 * process.c (Flist_processes): Remove to Lisp.
4075 (list_processes_1): Delete.
4077 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4079 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4081 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4083 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4085 Fix more problems found by GCC 4.6.0's static checks.
4087 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4089 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4091 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4093 * xdisp.c (vmessage): Mark as a printf-like function.
4095 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4097 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4099 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4100 printf-like functions.
4101 (tiff_load): Add casts to remove these marks before passing them
4102 to system-supplied API.
4104 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4106 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4107 This avoids several warnings with gcc -Wstrict-overflow.
4108 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4109 directly, rather than having caller test rule sign. This avoids
4110 some unnecessary tests.
4111 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4112 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4113 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4115 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4116 (xfont_open): Avoid unnecessary tests.
4118 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4120 * composite.h, composite.c (composition_gstring_put_cache):
4121 Use EMACS_INT, not int, for length.
4123 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4124 breaking out part of COMPOSITION_DECODE_RULE.
4125 (COMPOSITION_DECODE_RULE): Use it.
4126 * composite.c (get_composition_id): Remove unused local vars,
4127 by using the new macro.
4129 * textprop.c (set_text_properties_1): Change while to do-while,
4130 since the condition is always true at first.
4132 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4133 (interval_deletion_adjustment): Return unsigned value.
4136 * process.c (list_processes_1, create_pty, read_process_output):
4137 (exec_sentinel): Remove vars that were set but not used.
4138 (create_pty): Remove unnecessary "volatile"s.
4139 (Fnetwork_interface_info): Avoid possibility of int overflow.
4140 (read_process_output): Do adaptive read buffering even if carryover.
4141 (read_process_output): Simplify nbytes computation if buffered.
4143 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4145 * syntax.c (scan_words): Remove var that was set but not used.
4146 (update_syntax_table): Use unsigned instead of int.
4148 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4149 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4150 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4152 * print.c (print_error_message): Avoid int overflow.
4154 * font.c (font_list_entities): Redo for clarity,
4155 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4157 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4158 (font_score): Avoid potential overflow in diff calculation.
4160 * fns.c (substring_both): Remove var that is set but not used.
4161 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4163 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4165 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4166 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4167 can always succeed if overflow has undefined behavior.
4169 * search.c (boyer_moore, wordify): Remove vars set but not used.
4170 (wordify): Omit three unnecessary tests.
4172 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4173 All callers changed. This avoids the need for an unused var.
4175 * casefiddle.c (casify_region): Remove var that is set but not used.
4177 * dired.c (file_name_completion): Remove var that is set but not used.
4179 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4181 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4182 (Finsert_file_contents): Remove unnecessary code checking fd.
4184 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4185 Check for integer overflow on size calculations.
4187 * buffer.c (Fprevious_overlay_change): Remove var that is set
4190 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4191 Remove vars that are set but not used.
4192 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4193 (timer_check_2): Mark vars as initialized.
4195 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4197 * image.c (lookup_image): Remove var that is set but not used.
4198 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4200 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4201 that are set but not used.
4203 * xfns.c (make_invisible_cursor): Don't return garbage
4204 if XCreateBitmapFromData fails (Bug#8410).
4206 * xselect.c (x_get_local_selection, x_handle_property_notify):
4207 Remove vars that are set but not used.
4209 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4210 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4212 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4213 Remove var that is set but not used.
4214 (scroll_bar_windows_size): Now size_t, not int.
4215 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4218 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4219 (map_tty_color) [!defined MSDOS]: Likewise.
4221 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4223 * coding.c: Remove vars that are set but not used.
4224 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4225 All callers changed.
4226 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4227 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4228 (decode_coding_charset): Remove vars that are set but not used.
4230 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4231 that is set but not used.
4233 * print.c (print_object): Remove var that is set but not used.
4235 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4236 The gnulib version avoids calling malloc in the usual case,
4237 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4238 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4239 * filelock.c (current_lock_owner): Likewise.
4240 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4241 * sysdep.c: Include allocator.h, careadlinkat.h.
4242 (emacs_no_realloc_allocator): New static constant.
4243 (emacs_readlink): New function.
4244 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4245 ../lib/careadlinkat.h.
4247 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4249 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4250 first non-nil return value).
4252 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4254 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4255 if not defined (Bug#8403).
4257 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4259 * xdisp.c (display_count_lines): Remove parameter `start',
4260 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4261 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4262 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4263 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4264 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4265 and thereabouts. All callers changed.
4266 (get_per_char_metric): Remove parameter `f', unused since
4267 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4269 2011-04-02 Jim Meyering <meyering@redhat.com>
4271 do not dereference NULL upon failed strdup
4272 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4273 (ns_get_family): Likewise.
4275 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4277 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4279 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4281 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4284 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4286 Add lexical binding.
4288 * window.c (Ftemp_output_buffer_show): New fun.
4289 (Fsave_window_excursion):
4290 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4292 * lread.c (lisp_file_lexically_bound_p): New function.
4293 (Fload): Bind Qlexical_binding.
4294 (readevalloop): Remove `evalfun' arg.
4295 Bind Qinternal_interpreter_environment.
4296 (Feval_buffer): Bind Qlexical_binding.
4297 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4299 (syms_of_lread): Declare `lexical-binding'.
4301 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4303 * keyboard.c (eval_dyn): New fun.
4304 (menu_item_eval_property): Use it.
4306 * image.c (parse_image_spec): Use Ffunctionp.
4308 * fns.c (concat, mapcar1): Accept byte-code-functions.
4310 * eval.c (Fsetq): Handle lexical vars.
4311 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4312 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4313 (FletX, Flet): Obey lexical binding.
4314 (Fcommandp): Handle closures.
4315 (Feval): New `lexical' arg.
4316 (eval_sub): New function extracted from Feval. Use it almost
4317 everywhere where Feval was used. Look up vars in lexical env.
4319 (Ffunctionp): Move from subr.el.
4320 (Ffuncall): Handle closures.
4321 (apply_lambda): Remove `eval_flags'.
4322 (funcall_lambda): Handle closures and new byte-code-functions.
4323 (Fspecial_variable_p): New function.
4324 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4325 but without exporting it to Lisp.
4327 * doc.c (Fdocumentation, store_function_docstring):
4328 * data.c (Finteractive_form): Handle closures.
4330 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4333 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4335 (exec_byte_code): New function extracted from Fbyte_code to handle new
4336 calling convention for byte-code-functions. Add new byte-codes.
4338 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
4340 * alloc.c (Fmake_symbol): Init new `declared_special' field.
4342 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4344 * xdisp.c (redisplay_internal): Fix prototype.
4346 2011-03-31 Eli Zaretskii <eliz@gnu.org>
4348 * xdisp.c (SCROLL_LIMIT): New macro.
4349 (try_scrolling): Use it when setting scroll_limit.
4350 Limit scrolling to 100 screen lines.
4351 (redisplay_window): Even when falling back on "recentering",
4352 position point in the window according to scroll-conservatively,
4353 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4355 (try_scrolling): When point is above the window, allow searching
4356 as far as scroll_max, or one screenful, to compute vertical
4357 distance from PT to the scroll margin position. This prevents
4358 try_scrolling from unnecessarily failing when
4359 scroll-conservatively is set to a value slightly larger than the
4360 window height. Clean up the case of PT below the margin at bottom
4361 of window: scroll_max can no longer be INT_MAX. When aggressive
4362 scrolling is in use, don't let point enter the opposite scroll
4363 margin as result of the scroll.
4364 (syms_of_xdisp) <scroll-conservatively>: Document the
4365 threshold of 100 lines for never-recentering scrolling.
4367 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4369 * dispextern.h (move_it_by_lines):
4370 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4371 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4372 (message_log_check_duplicate): Remove parameters `prev_bol' and
4373 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4374 (redisplay_internal): Remove parameter `preserve_echo_area',
4375 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4377 * indent.c (Fvertical_motion):
4378 * window.c (window_scroll_pixel_based, Frecenter):
4379 Don't pass `need_y_p' to `move_it_by_lines'.
4381 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4383 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4384 steal a few bits to be more compact.
4385 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4386 Remove unneeded casts.
4388 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4390 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4392 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4393 binding" message (bug#7967).
4395 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4397 Fix more problems found by GCC 4.6.0's static checks.
4399 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4400 Remove unused local var.
4402 * editfns.c (Fmessage_box): Remove unused local var.
4404 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4405 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4406 Omit unused local vars.
4407 * window.c (shrink_windows): Omit unused local var.
4408 * menu.c (digest_single_submenu): Omit unused local var.
4409 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4410 Omit unused local var.
4412 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4413 Don't assume string length fits in int.
4414 (keyremap_step, read_key_sequence): Use size_t for sizes.
4415 (read_key_sequence): Don't check last_real_key_start redundantly.
4417 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4418 instead of alloca (Bug#8344).
4420 * eval.c (Fbacktrace): Don't assume nargs fits in int.
4421 (Fbacktrace_frame): Don't assume nframes fits in int.
4423 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4425 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4428 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4430 * cm.c (calccost): Turn while-do into do-while, for clarity.
4432 * keyboard.c (syms_of_keyboard): Use the same style as later
4433 in this function when indexing through an array. This also
4434 works around GCC bug 48267.
4436 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4438 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4440 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4441 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4443 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4444 This avoids undefined behavior on integer overflow, and is a bit
4445 more convenient anyway since it is compared to a size_t variable.
4447 Variadic C functions now count arguments with size_t, not int.
4448 This avoids an unnecessary limitation on 64-bit machines, which
4449 caused (substring ...) to crash on large vectors (Bug#8344).
4450 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4451 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
4452 All variadic functions and their callers changed accordingly.
4453 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4454 * data.c (arith_driver, float_arith_driver): Likewise.
4455 * editfns.c (general_insert_function): Likewise.
4456 * eval.c (struct backtrace.nargs, interactive_p)
4457 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4458 (funcall_lambda, mark_backtrace): Likewise.
4459 * fns.c (concat): Likewise.
4460 * frame.c (x_set_frame_parameters): Likewise.
4461 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4462 0 if not found, not -1. All callers changed.
4464 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4465 (stack_copy_size): Now size_t, not int.
4466 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4468 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4470 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4471 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4472 All callers changed.
4474 * lisp.h (multibyte_char_to_unibyte):
4475 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4476 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4477 * character.h (CHAR_TO_BYTE8):
4478 * cmds.c (internal_self_insert):
4479 * editfns.c (general_insert_function):
4480 * keymap.c (push_key_description):
4481 * search.c (Freplace_match):
4482 * xdisp.c (message_dolog, set_message_1): All callers changed.
4484 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4486 * keyboard.c (safe_run_hook_funcall): New function.
4487 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4488 don't set the hook to nil, but remove the offending function instead.
4489 (Qcommand_hook_internal): Remove, unused.
4490 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4491 Vcommand_hook_internal.
4493 * eval.c (enum run_hooks_condition): Remove.
4494 (funcall_nil, funcall_not): New functions.
4495 (run_hook_with_args): Call each function through a `funcall' argument.
4496 Remove `cond' argument, now redundant.
4497 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4498 (Frun_hook_with_args_until_failure): Adjust accordingly.
4499 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4501 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4503 * dispextern.h (string_buffer_position): Remove declaration.
4505 * print.c (strout): Remove parameter `multibyte', unused since
4506 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4508 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4509 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4510 All callers changed.
4512 * w32.c (_wsa_errlist): Use braces for struct initializers.
4514 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4515 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4516 All callers changed.
4517 (string_buffer_position): Likewise. Also, make static (it's never
4518 used outside xdisp.c).
4519 (cursor_row_p): Remove parameter `w', unused since
4520 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4521 (decode_mode_spec): Remove parameter `precision', introduced during
4522 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4523 All callers changed.
4525 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4527 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4529 2011-03-27 Anders Lindgren <andlind@gmail.com>
4531 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4532 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4533 (ns_update_auto_hide_menu_bar): New functions.
4534 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4535 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4536 ns_constrain_all_frames.
4537 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4538 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4540 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4542 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4544 2011-03-27 Glenn Morris <rgm@gnu.org>
4546 * syssignal.h: Replace RETSIGTYPE with void.
4547 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4548 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4549 Replace SIGTYPE with void everywhere.
4550 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4551 * s/template.h (SIGTYPE): Remove commented out definition.
4553 2011-03-26 Eli Zaretskii <eliz@gnu.org>
4555 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4556 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4558 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
4560 * w32.c (read_unc_volume): Use parameter `henum', instead of
4561 global variable `wget_enum_handle'.
4563 * keymap.c (describe_vector): Remove parameters `indices' and
4564 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4565 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4567 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4569 * keyboard.c (timer_check): Remove parameter `do_it_now',
4570 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4571 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4572 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4574 * keyboard.c (read_char):
4575 * w32menu.c (w32_menu_display_help):
4576 * xmenu.c (show_help_event, menu_help_callback):
4577 Adjust calls to `show_help_echo'.
4579 * gtkutil.c (xg_maybe_add_timer):
4580 * keyboard.c (readable_events):
4581 * process.c (wait_reading_process_output):
4582 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4584 * insdel.c (adjust_markers_gap_motion):
4585 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4586 (gap_left, gap_right): Don't call it.
4588 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
4590 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4591 incurred during fontification.
4593 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4595 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4596 (DEFVAR_PER_BUFFER): Don't pass it.
4598 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4599 (scrolling_window): Don't pass it.
4601 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4603 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4605 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4607 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4608 of variables specific to SELinux and computation of `encoded_absname'.
4610 * image.c (XPutPixel): Remove unused variable `height'.
4612 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4614 * unexw32.c (get_section_info): Remove unused variable `section'.
4616 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4617 (system_process_attributes): Remove unused variable `sess'.
4618 (sys_read): Remove unused variable `err'.
4620 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4621 (w32_wnd_proc): Remove unused variable `isdead'.
4622 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4623 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4624 (x_create_tip_frame): Remove unused variable `tem'.
4626 * w32inevt.c (w32_console_read_socket):
4627 Remove unused variable `no_events'.
4629 * w32term.c (x_draw_composite_glyph_string_foreground):
4630 Remove unused variable `width'.
4632 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
4634 * w32term.c (x_set_glyph_string_clipping):
4635 Don't pass uninitialized region to CombineRgn.
4637 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
4639 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4640 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4641 (Fx_close_connection): Remove unused variable `i'.
4643 * w32font.c (w32font_draw): Return number of glyphs.
4644 (w32font_open_internal): Remove unused variable `i'.
4645 (w32font_driver): Add missing initializer.
4647 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4648 (fill_in_menu): Remove unused variable `items_added'.
4650 * w32term.c (last_mouse_press_frame): Remove static global variable.
4651 (w32_clip_to_row): Remove unused variable `f'.
4652 (x_delete_terminal): Remove unused variable `i'.
4654 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4655 (NOTHING): Remove unused static global variable.
4656 (uniscribe_check_otf): Remove unused variable `table'.
4657 (uniscribe_font_driver): Add missing initializers.
4659 2011-03-23 Julien Danjou <julien@danjou.info>
4661 * term.c (Fsuspend_tty, Fresume_tty):
4662 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4663 * window.c (temp_output_buffer_show):
4664 * insdel.c (signal_before_change):
4665 * frame.c (Fhandle_switch_frame):
4666 * fileio.c (Fdo_auto_save):
4667 * emacs.c (Fkill_emacs):
4668 * editfns.c (save_excursion_restore):
4669 * cmds.c (internal_self_insert):
4670 * callint.c (Fcall_interactively):
4671 * buffer.c (Fkill_all_local_variables):
4672 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4674 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
4675 unconditionnaly since it does the check itself.
4677 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
4679 Fix more problems found by GCC 4.5.2's static checks.
4681 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4682 the first time through the loop, since we know p0 < p1 then.
4683 This also avoids a gcc -Wstrict-overflow warning.
4685 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4686 leading to a memory leak, possible in functions like
4687 load_charset_map_from_file that can allocate an unbounded number
4688 of objects (Bug#8318).
4690 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4691 that could (at least in theory) be that large.
4693 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4694 This is less likely to overflow, and avoids undefined behavior if
4695 overflow does occur. All callers changed. Use strtoul to scan
4696 for the unsigned long integer.
4697 (pint2hrstr): Simplify and tune code slightly.
4698 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
4700 * scroll.c (do_scrolling): Work around GCC bug 48228.
4701 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4703 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4704 This also avoids a warning with gcc -Wstrict-overflow.
4705 (validate_x_resource_name): Simplify count usage.
4706 This also avoids a warning with gcc -Wstrict-overflow.
4708 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4711 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
4713 * process.c (Fmake_network_process): Use socklen_t, not int,
4714 where POSIX says socklen_t is required in portable programs.
4715 This fixes a porting bug on hosts like 64-bit HP-UX, where
4716 socklen_t is wider than int (Bug#8277).
4717 (Fmake_network_process, server_accept_connection):
4718 (wait_reading_process_output, read_process_output):
4721 * process.c: Rename or move locals to avoid shadowing.
4722 (list_processes_1, Fmake_network_process):
4723 (read_process_output_error_handler, exec_sentinel_error_handler):
4724 Rename or move locals.
4725 (Fmake_network_process): Define label "retry_connect" only if needed.
4726 (Fnetwork_interface_info): Fix pointer signedness.
4727 (process_send_signal): Add cast to avoid pointer signedness problem.
4728 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
4729 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
4731 Make tparam.h and terminfo.c consistent.
4732 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4733 Include tparam.h instead, since it declares them.
4734 * cm.h (PC): Remove extern decl; tparam.h now does this.
4735 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4736 * terminfo.c: Include tparam.h, to check interfaces.
4737 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4738 (tparam): Adjust signature to match interface in tparam.h;
4739 this removes some undefined behavior. Check that outstring and len
4740 are zero, which they always are with Emacs.
4741 * tparam.h (PC, BC, UP): New extern decls.
4743 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
4744 (xftfont_open): Rename locals to avoid shadowing.
4746 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
4747 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4748 (OTF_TAG_SYM): Omit macro if not needed.
4749 (ftfont_list): Remove unused local.
4750 (get_adstyle_property, ftfont_pattern_entity):
4751 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4752 Rename locals to avoid shadowing.
4754 * xfont.c (xfont_list_family): Mark var as initialized.
4756 * xml.c (make_dom): Now static.
4758 * composite.c (composition_compute_stop_pos): Rename local to
4760 (composition_reseat_it): Remove unused locals.
4761 (find_automatic_composition, composition_adjust_point): Likewise.
4762 (composition_update_it): Mark var as initialized.
4763 (find_automatic_composition): Mark vars as initialized,
4764 with a FIXME (Bug#8290).
4766 character.h: Rename locals to avoid shadowing.
4767 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4768 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4769 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4770 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4773 * textprop.c (property_change_between_p): Remove; unused.
4775 * intervals.c (interval_start_pos): Now static.
4777 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4779 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4780 Rename locals to avoid shadowing.
4782 * sound.c (wav_play, au_play, Fplay_sound_internal):
4783 Fix pointer signedness.
4784 (alsa_choose_format): Remove unused local var.
4785 (wav_play): Initialize a variable to 0, to prevent undefined
4786 behavior (Bug#8278).
4788 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4790 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4792 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4793 clobbering (Bug#8298).
4794 * sysdep.c (sys_subshell): Likewise.
4795 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
4797 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4798 This should get cleaned up, so that child_setup has the
4799 same signature on all platforms.
4801 * callproc.c (call_process_cleanup): Now static.
4802 (relocate_fd): Rename locals to avoid shadowing.
4804 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
4806 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4807 not to be necessary, and produces flickering.
4809 2011-03-20 Glenn Morris <rgm@gnu.org>
4811 * config.in: Remove file.
4813 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
4815 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4816 are now in src/globals.h.
4817 (syms_of_minibuf): Remove spurious & from previous change.
4819 2011-03-20 Leo <sdl.web@gmail.com>
4821 * minibuf.c (completing-read-function): New variable.
4822 (completing-read-default): Rename from completing-read.
4823 (completing-read): Call completing-read-function.
4825 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4827 * xfaces.c (Fx_load_color_file):
4828 Read color file from absolute filename (bug#8250).
4830 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4832 * makefile.w32-in: Update dependencies.
4834 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4836 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4838 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4840 Fix more problems found by GCC 4.5.2's static checks.
4842 * process.c (make_serial_process_unwind, send_process_trap):
4843 (sigchld_handler): Now static.
4845 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4846 That way, the code declares only the vars that it needs.
4847 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4848 * s/cygwin.h (PTY_ITERATION): Likewise.
4849 * s/darwin.h (PTY_ITERATION): Likewise.
4850 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4852 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4853 * process.c (allocate_pty): Don't declare stb unless it's needed.
4855 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4856 (CONSTANTLIM): Remove; unused.
4857 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4858 Define only if needed.
4860 * unexelf.c (unexec): Name an expression,
4861 to avoid gcc -Wbad-function-cast warning.
4862 Use a different way to cause a compilation error if anyone uses
4863 n rather than nn, a way that does not involve shadowing.
4864 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4866 * deps.mk (unexalpha.o): Remove; unused.
4868 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4869 * unexec.h: New file.
4870 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4871 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4873 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4874 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4875 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4876 Change as necessary to match prototype in unexec.h.
4878 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4880 (back_comment, skip_chars): Mark vars as initialized.
4882 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4883 Rename locals to avoid shadowing.
4885 * lread.c (read1): Rewrite so as not to use empty "else".
4886 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4888 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4890 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4891 warning when compiling print.c.
4893 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4894 instead of using an uninitialized var.
4895 (font_sort_entities): Mark var as initialized.
4897 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4899 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4900 pointers to constants.
4901 (font_parse_fcname): Remove unused vars.
4902 (font_delete_unmatched): Now static.
4903 (font_get_spec): Remove; unused.
4904 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4905 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4906 Rename or move locals to avoid shadowing.
4908 * fns.c (require_nesting_list, require_unwind): Now static.
4909 (Ffillarray): Rename locals to avoid shadowing.
4911 * floatfns.c (domain_error2): Define only if needed.
4912 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4914 * alloc.c (mark_backtrace): Move decl from here ...
4915 * lisp.h: ... to here, so that it can be checked.
4917 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4918 (Fdefvar): Rewrite so as not to use empty "else".
4919 (lisp_indirect_variable): Name an expression,
4920 to avoid gcc -Wbad-function-cast warning.
4921 (Fdefvar): Rename locals to avoid shadowing.
4923 * callint.c (quotify_arg, quotify_args): Now static.
4924 (Fcall_interactively): Rename locals to avoid shadowing.
4925 Use const pointer when appropriate.
4927 * lisp.h (get_system_name, get_operating_system_release):
4928 Move decls here, to check interfaces.
4929 * process.c (get_operating_system_release): Move decl to lisp.h.
4930 * xrdb.c (get_system_name): Likewise.
4931 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4932 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4933 some of which prompt warnings from gcc -Wbad-function-cast.
4934 (Fformat_time_string, Fencode_time, Finsert_char):
4935 (Ftranslate_region_internal, Fformat):
4936 Rename or remove local vars to avoid shadowing.
4937 (Ftranslate_region_internal): Mark var as initialized.
4939 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4942 * lisp.h (eassert): Check that the argument compiles, even if
4943 ENABLE_CHECKING is not defined.
4945 * data.c (Findirect_variable): Name an expression, to avoid
4946 gcc -Wbad-function-cast warning.
4947 (default_value, arithcompare, arith_driver, arith_error): Now static.
4948 (store_symval_forwarding): Rename local to avoid shadowing.
4949 (Fmake_variable_buffer_local, Fmake_local_variable):
4950 Mark variables as initialized.
4951 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4953 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4954 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4955 Rename locals to avoid shadowing.
4956 (mark_stack): Move local variables into the #ifdef region where
4958 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4959 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4961 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4962 (GC_STRING_CHARS): Remove; not used.
4963 (Fmemory_limit): Cast sbrk's returned value to char *.
4965 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4966 avoids undefined behavior in theory.
4968 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4970 Use functions, not macros, for up- and down-casing (Bug#8254).
4971 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4972 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4973 to use the following functions instead of these macros.
4974 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4975 EMACS_INT, since callers assume the returned value fits in int.
4976 (upcase1): Likewise, for UPCASE_TABLE.
4977 (uppercasep, lowercasep, upcase): New static inline functions.
4978 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4979 the race-condition problem in the old DOWNCASE.
4981 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4982 Rename locals to avoid shadowing.
4983 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4984 (regex_compile, re_search_2, re_match_2_internal):
4985 Remove unused local vars.
4986 (FREE_VAR): Rewrite so as not to use empty "else",
4987 which gcc can warn about.
4988 (regex_compile, re_match_2_internal): Mark locals as initialized.
4989 (RETALLOC_IF): Define only if needed.
4990 (WORDCHAR_P): Likewise. This one is never needed, but is used
4991 only in a comment talking about a compiler bug, so put inside
4992 the #if 0 of that comment.
4993 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4994 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4997 * search.c (boyer_moore): Rename locals to avoid shadowing.
4998 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4999 (PREV_CHAR_BOUNDARY): Likewise.
5001 * search.c (simple_search): Remove unused var.
5003 * dired.c (compile_pattern): Move decl from here ...
5004 * lisp.h: ... to here, so that it can be checked.
5005 (struct re_registers): New forward decl.
5007 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5009 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5011 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5012 Rename locals to avoid shadowing.
5013 (Fvertical_motion): Mark locals as initialized.
5015 * casefiddle.c (casify_object, casify_region): Now static.
5016 (casify_region): Mark local as initialized.
5018 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5020 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5021 New macros, so that the caller can use some names other than
5022 gcpro1, gcpro2, etc.
5023 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5025 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5026 argument, for consistency with GCPRO2_VAR, etc: it is now the
5027 prefix of the variable, not the variable itself. All uses
5029 * dired.c (directory_files_internal, file_name_completion):
5030 Rename locals to avoid shadowing.
5032 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5033 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5034 dired.c's scmp function, had undefined behavior.
5035 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5036 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5037 * buffer.h: ... to here, because these macros use current_buffer,
5038 and the new implementation with inline functions needs to have
5039 current_buffer in scope now, rather than later when the macros
5041 (downcase, upcase1): New static inline functions.
5042 (DOWNCASE, UPCASE1): Reimplement using these functions.
5043 This avoids undefined behavior in expressions like
5044 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5045 from race conditions in accessing the global variables
5046 case_temp1 and case_temp2.
5047 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5048 * lisp.h (case_temp1, case_temp2): Remove their decls.
5049 * character.h (ASCII_CHAR_P): Move from here ...
5050 * lisp.h: ... to here, so that the inline functions mentioned
5053 * dired.c (directory_files_internal_unwind): Now static.
5055 * fileio.c (file_name_as_directory, directory_file_name):
5056 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5058 (file_name_as_directory): Use const pointers when appropriate.
5059 (Fexpand_file_name): Likewise. In particular, newdir might
5060 point at constant storage, so make it a const pointer.
5061 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5062 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5064 (Fset_file_times, Finsert_file_contents, auto_save_error):
5065 Rename locals to avoid shadowing.
5067 * minibuf.c (choose_minibuf_frame_1): Now static.
5068 (Ftry_completion, Fall_completions): Rename or remove locals
5071 * marker.c (bytepos_to_charpos): Remove; unused.
5073 * lisp.h (verify_bytepos, count_markers): New decls,
5074 so that gcc does not warn that these functions aren't declared.
5076 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5077 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5078 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5079 (copy_text): Remove unused local var.
5081 * filelock.c (within_one_second): Now static.
5082 (lock_file_1): Rename local to avoid shadowing.
5084 * buffer.c (fix_overlays_before): Mark locals as initialized.
5085 (fix_start_end_in_overlays): Likewise. This function should be
5086 simplified by using pointers-to-pointers, but that's a different
5088 (switch_to_buffer_1): Now static.
5089 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5090 (report_overlay_modification): Rename locals to avoid shadowing.
5092 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5093 Fix pointer signedness issue.
5094 (sys_subshell): Mark local as volatile if checking for lint,
5095 to suppress a gcc -Wclobbered warning that does not seem to be right.
5096 (MAXPATHLEN): Define only if needed.
5098 * process.c (serial_open, serial_configure): Move decls from here ...
5099 * systty.h: ... to here, so that they can be checked.
5101 * fns.c (get_random, seed_random): Move extern decls from here ...
5102 * lisp.h: ... to here, so that they can be checked.
5104 * sysdep.c (reset_io): Now static.
5105 (wait_for_termination_signal): Remove; unused.
5107 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5108 (copy_keymap_item, append_key, push_text_char_description):
5110 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5111 (DENSE_TABLE_SIZE): Remove; unused.
5112 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5113 (describe_map_tree):
5114 Rename locals to avoid shadowing.
5116 * keyboard.c: Declare functions static if they are not used elsewhere.
5117 (echo_char, echo_dash, cmd_error, top_level_2):
5118 (poll_for_input, handle_async_input): Now static.
5119 (read_char, kbd_buffer_get_event, make_lispy_position):
5120 (make_lispy_event, make_lispy_movement, apply_modifiers):
5121 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5122 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5123 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5124 (read_key_sequence, read_char): Mark locals as initialized.
5125 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5127 * keyboard.h (make_ctrl_char): New decl.
5128 (mark_kboards): Move decl here ...
5129 * alloc.c (mark_kboards): ... from here.
5131 * lisp.h (force_auto_save_soon): New decl.
5133 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5134 (DEFINE_DUMMY_FUNCTION): New macro.
5135 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5137 (main): Add casts to avoid warnings
5138 if GCC considers string literals to be constants.
5140 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5142 * dbusbind.c: Pointer signedness fixes.
5143 (xd_signature, xd_append_arg, xd_initialize):
5144 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5145 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5146 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5147 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5149 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5150 if GCC considers string literals to be constants.
5151 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5153 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5155 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5156 (print_preprocess, print_object): New macro to fix last change.
5158 * print.c (print_preprocess): Don't forget font objects.
5160 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5162 * emacs.c (USAGE3): Doc fixes.
5164 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5166 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5169 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5171 * lisp.h (VWindow_system, Qfile_name_history):
5172 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5173 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5174 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5176 * w32select.c: Don't #include "keyboard.h".
5177 (run_protected): Add extern declaration for waiting_for_input.
5179 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5180 * w32console.c (detect_input_pending, read_input_pending)
5181 (encode_terminal_code):
5182 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5183 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5184 (w32_system_caret_y, Qfile_name_history):
5185 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5186 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5187 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5188 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5189 * w32proc.c (Qlocal, report_file_error):
5190 * w32term.c (Vwindow_system, updating_frame):
5191 * w32uniscribe.c (initialized, uniscribe_font_driver):
5192 Remove unneeded extern declarations.
5194 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5196 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5198 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
5200 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5201 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5202 These macros can no longer be used for assignment.
5204 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5205 Assign struct members directly, instead of using BUF_BEGV etc.
5206 (record_buffer_markers, fetch_buffer_markers): New functions for
5207 recording and fetching special buffer markers.
5208 (set_buffer_internal_1, set_buffer_temp): Use them.
5210 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5212 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5214 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5215 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5217 * xdisp.c (hscroll_window_tree):
5218 (reconsider_clip_changes): Use PT instead of BUF_PT.
5220 2011-03-13 Eli Zaretskii <eliz@gnu.org>
5222 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5223 $(EMACS_ROOT)/lib/intprops.h.
5225 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5227 Fix more problems found by GCC 4.5.2's static checks.
5229 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5230 to unsigned char * to avoid compiler diagnostic.
5231 (xg_free_frame_widgets): Make it clear that a local variable is
5232 needed only if USE_GTK_TOOLTIP.
5233 (gdk_window_get_screen): Make it clear that this macro is needed
5234 only if USE_GTK_TOOLTIP.
5235 (int_gtk_range_get_value): New function, which avoids a diagnostic
5236 from gcc -Wbad-function-cast.
5237 (xg_set_toolkit_scroll_bar_thumb): Use it.
5238 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5239 diagnostic from gcc -Wbad-function-cast.
5240 (get_utf8_string, xg_get_file_with_chooser):
5241 Rename locals to avoid shadowing.
5242 (create_dialog): Move locals to avoid shadowing.
5244 * xgselect.c (xg_select): Remove unused var.
5246 * image.c (four_corners_best): Mark locals as initialized.
5247 (gif_load): Initialize transparent_p to zero (Bug#8238).
5248 Mark another local as initialized.
5249 (my_png_error, my_error_exit): Mark with NO_RETURN.
5251 * image.c (clear_image_cache): Now static.
5252 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5253 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5254 (x_edge_detection): Remove unnecessary cast that
5255 gcc -Wbad-function-cast diagnoses.
5256 (gif_load): Fix pointer signedness.
5257 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5258 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5260 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5262 Improve quality of tests for time stamp overflow.
5263 For example, without this patch (encode-time 0 0 0 1 1
5264 1152921504606846976) returns the obviously-bogus value (-948597
5265 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5266 reports time overflow. See
5267 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5268 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5269 * editfns.c: Include limits.h and intprops.h.
5270 (TIME_T_MIN, TIME_T_MAX): New macros.
5271 (time_overflow): Move earlier, to before first use.
5272 (hi_time, lo_time): New functions, for an accurate test for
5274 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5275 (Fget_internal_run_time): Don't assume time_t fits in int.
5276 (make_time): Use list2 instead of Fcons twice.
5277 (Fdecode_time): More accurate test for out-of-range times.
5278 (check_tm_member): New function.
5279 (Fencode_time): Use it, to test for out-of-range times.
5280 (lisp_time_argument): Don't rely on undefined left-shift and
5281 right-shift behavior when checking for time stamp overflow.
5283 * editfns.c (time_overflow): New function, refactoring common code.
5284 (Fformat_time_string, Fdecode_time, Fencode_time):
5285 (Fcurrent_time_string): Use it.
5287 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5288 * dired.c (make_time): Move to ...
5289 * editfns.c (make_time): ... here.
5290 * systime.h: Note the move.
5292 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5294 * fringe.c (update_window_fringes): Remove unused variables.
5296 * unexmacosx.c (copy_data_segment): Also copy __got section.
5299 2011-03-12 Eli Zaretskii <eliz@gnu.org>
5301 * termcap.c [MSDOS]: Include "msdos.h".
5302 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5303 Constify `char *' arguments and their references according to
5304 prototypes in tparam.h.
5306 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
5308 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5309 Adapt all references accordingly.
5311 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5313 2011-03-11 Tom Tromey <tromey@redhat.com>
5315 * buffer.c (syms_of_buffer): Remove obsolete comment.
5317 2011-03-11 Eli Zaretskii <eliz@gnu.org>
5319 * termhooks.h (encode_terminal_code): Declare prototype.
5321 * msdos.c (encode_terminal_code): Don't declare prototype.
5323 * term.c (encode_terminal_code): Now external again, used by
5324 w32console.c and msdos.c.
5326 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5327 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
5329 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
5331 Fix some minor problems found by GCC 4.5.2's static checks.
5333 * fringe.c (update_window_fringes): Mark locals as initialized
5335 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
5337 * alloc.c (mark_fringe_data): Move decl from here ...
5338 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5339 to check its interface.
5340 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5342 * fontset.c (free_realized_fontset): Now static.
5343 (Fset_fontset_font): Rename local to avoid shadowing.
5344 (fontset_font): Mark local as initialized.
5345 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
5347 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5349 * xselect.c (x_disown_buffer_selections): Remove; not used.
5350 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
5351 (x_own_selection, Fx_disown_selection_internal): Rename locals
5353 (x_handle_dnd_message): Remove local to avoid shadowing.
5355 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5356 so that the caller can use some name other than gcpro1.
5357 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
5358 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5359 (Fx_backspace_delete_keys_p):
5360 Use them to avoid shadowing, and rename vars to avoid shadowing.
5361 (x_decode_color, x_set_name, x_window): Now static.
5362 (Fx_create_frame): Add braces to silence GCC warning.
5363 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
5364 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5365 Remove unused locals.
5366 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5367 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5368 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5371 * xterm.h (x_mouse_leave): New decl.
5373 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5374 Remove unused functions.
5375 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5376 (x_calc_absolute_position): Now static.
5377 (XTread_socket): Don't define label "out" unless it's used.
5378 Don't declare local "event" unless it's used.
5379 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5380 unless they are used.
5381 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5382 (x_fatal_error_signal): Remove; not used.
5383 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5384 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5385 (x_error_catcher, x_connection_closed, x_error_handler):
5386 (x_error_quitter, xembed_send_message, x_iconify_frame):
5387 (my_log_handler): Rename locals to avoid shadowing.
5388 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
5389 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
5391 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5392 Rename or move locals to avoid shadowing.
5393 (tty_defined_color, merge_face_heights): Now static.
5394 (free_realized_faces_for_fontset): Remove; not used.
5395 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5396 does not deduce is never used uninitialized.
5397 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5398 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
5400 * terminal.c (store_terminal_param): Now static.
5402 * xmenu.c (menu_highlight_callback): Now static.
5403 (set_frame_menubar): Remove unused local.
5404 (xmenu_show): Rename parameter to avoid shadowing.
5405 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5406 since they might point to immutable storage.
5407 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5408 since it's unused otherwise.
5410 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
5411 Add a FIXME, since the code still doesn't look right. (Bug#8215)
5412 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5413 avoids a gcc -Wuninitialized diagnostic.
5414 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
5415 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5416 does not deduce are never used uninitialized.
5418 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5420 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
5421 * window.c (window_loop, size_window):
5422 (run_window_configuration_change_hook, enlarge_window): Likewise.
5424 * window.c (display_buffer): Now static.
5425 (size_window): Mark variables that gcc -Wuninitialized
5426 does not deduce are never used uninitialized.
5427 * window.h (check_all_windows): New decl, to forestall
5428 gcc -Wmissing-prototypes diagnostic.
5429 * dispextern.h (bidi_dump_cached_states): Likewise.
5431 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5433 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
5435 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5436 and to avoid gcc -Wuninitialized warning.
5437 (load_charset_map): Mark variables that gcc -Wuninitialized
5438 does not deduce are never used uninitialized.
5439 (load_charset): Abort instead of using uninitialized var (Bug#8229).
5441 * coding.c (coding_set_source, coding_set_destination):
5442 Use "else { /* comment */ }" rather than "else /* comment */;"
5443 for clarity, and to avoid gcc -Wempty-body warning.
5444 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5445 a block, when the outer 'i' will do.
5446 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5447 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5448 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5449 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5450 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5451 Rename locals to avoid shadowing.
5452 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
5453 * coding.c (emacs_mule_char, encode_invocation_designation):
5454 Now static, since they're not used elsewhere.
5455 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
5456 (decode_coding_object, encode_coding_object, detect_coding_system):
5457 (decode_coding_emacs_mule): Mark variables that gcc
5458 -Wuninitialized does not deduce are never used uninitialized.
5459 (detect_coding_iso_2022): Initialize a local variable that might
5460 be used uninitialized. Leave a FIXME because it's not clear that
5461 this initialization is needed. (Bug#8211)
5462 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5463 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5464 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5465 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5466 Remove unused macros.
5468 * category.c (hash_get_category_set): Remove unused local var.
5469 (copy_category_table): Now static, since it's not used elsewhere.
5470 * character.c (string_count_byte8): Likewise.
5472 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5473 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5475 * chartab.c (copy_sub_char_table): Now static, since it's not used
5477 (sub_char_table_ref_and_range, char_table_ref_and_range):
5478 Rename locals to avoid shadowing.
5479 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
5481 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
5482 (BIDI_BOB): Remove unused macro.
5484 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5485 deduce are never used uninitialized.
5486 * term.c (encode_terminal_code): Likewise.
5488 * term.c (encode_terminal_code): Now static. Remove unused local.
5490 * tparam.h: New file.
5491 * term.c, tparam.h: Include it.
5492 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5493 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5494 Move these decls to tparam.h, and make them agree with what
5495 is actually in tparam.c. The previous trick of using incompatible
5496 decls in different modules does not conform to the C standard.
5497 All callers of tparam changed to use tparam's actual API.
5498 * tparam.c (tparam1, tparam, tgoto):
5499 Use const pointers where appropriate.
5501 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5502 * cm.h (struct cm): Likewise.
5503 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5504 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5505 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5506 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5507 (turn_on_face, init_tty): Likewise.
5508 * termchar.h (struct tty_display_info): Likewise.
5510 * term.c (term_mouse_position): Rename local to avoid shadowing.
5512 * alloc.c (mark_ttys): Move decl from here ...
5513 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5515 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5517 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5519 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
5521 * search.c (compile_pattern_1): Remove argument regp, unused since
5522 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5523 (compile_pattern): Don't pass it.
5525 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5527 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5528 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5530 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5532 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5534 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5535 gdk_window_get_screen, gdk_window_get_geometry,
5536 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5537 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5538 (xg_get_pixbuf_from_pixmap): New function.
5539 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5540 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5541 Call xg_get_pixbuf_from_pixmap instead of
5542 gdk_pixbuf_get_from_drawable.
5543 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5544 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5545 (xg_check_special_colors): Use GtkStyleContext and its functions
5547 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5548 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5549 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5550 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5551 Call gtk_widget_get_preferred_size.
5552 (xg_frame_resized): gdk_window_get_geometry only takes 5
5554 (xg_win_to_widget, xg_event_is_for_menubar):
5555 Call gdk_x11_window_lookup_for_display.
5556 (xg_set_widget_bg): New function.
5557 (delete_cb): New function.
5558 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5559 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5560 (xg_set_background_color): Call xg_set_widget_bg.
5561 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5562 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5563 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5564 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5566 (update_frame_tool_bar): Call gtk_widget_hide.
5567 (xg_initialize): Use GDK_KEY_g.
5569 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5571 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5573 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5574 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5575 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5577 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
5579 * w32xfns.c (select_palette): Check success of RealizePalette against
5580 GDI_ERROR, not zero.
5582 See ChangeLog.11 for earlier changes.
5588 Copyright (C) 2011 Free Software Foundation, Inc.
5590 This file is part of GNU Emacs.
5592 GNU Emacs is free software: you can redistribute it and/or modify
5593 it under the terms of the GNU General Public License as published by
5594 the Free Software Foundation, either version 3 of the License, or
5595 (at your option) any later version.
5597 GNU Emacs is distributed in the hope that it will be useful,
5598 but WITHOUT ANY WARRANTY; without even the implied warranty of
5599 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5600 GNU General Public License for more details.
5602 You should have received a copy of the GNU General Public License
5603 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.