1 2012-08-10 Glenn Morris <rgm@gnu.org>
3 * conf_post.h (IF_LINT, lint_assume): Move here from lisp.h.
4 * lisp.h (IF_LINT, lint_assume): Move to conf_post.h.
6 2012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
8 Fix last change to allow compilation with low optimization levels.
9 * intervals.c (INTERVALS_INLINE): Define to EXTERN_INLINE.
10 Reported by Jan Djärv <jan.h.d@swipnet.se>.
12 2012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
14 Use common inline syntax in intervals.h.
15 * intervals.h (INTERVALS_INLINE): New macro.
16 Change all users from LISP_INLINE.
18 2012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
20 Define Qnone once for all platforms.
21 * frame.c (Qnone): Define here.
22 (syms_of_frame): DEFSYM it.
23 * lisp.h (Qnone): New declaration.
24 * nsfns.m, nsterm.h, nsterm.m, w32fns.c, w32font.c:
25 * xfns.c: Remove duplication. Adjust users.
27 2012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
29 Remove unused macros from intervals.h.
30 * intervals.h (MERGE_INSERTIONS, DISPLAY_INVISIBLE_GLYPH): Remove.
31 * intervals.c: Adjust comment.
33 2012-08-10 Eli Zaretskii <eliz@gnu.org>
35 * w32fns.c <w32_unicode_gui>: New static variable.
36 (globals_of_w32fns): Initialize it according to os_subtype.
37 (w32_init_class, w32_msg_pump, w32_wnd_proc): Use it instead of
40 2012-08-10 Joakim Hårsman <joakim.harsman@gmail.com> (tiny change)
41 Eli Zaretskii <eliz@gnu.org>
43 Fix bug #10299 with Unicode characters sent by customized
44 keyboards created by MSKLC.
45 * w32fns.c (INIT_WINDOW_CLASS): New macro.
46 (w32_init_class): Use it to initialize the Emacs class with either
47 ANSI or Unicode API calls.
48 (w32_msg_pump): Call GetMessageW and DispatchMessageW on NT and
50 (w32_wnd_proc): If the character code sent by WM_CHAR or
51 WM_SYSCHAR is above 255, post a WM_UNICHAR message, not the
52 original message. Call DefWindowProcW on NT and later.
54 2012-08-10 Glenn Morris <rgm@gnu.org>
56 * Makefile.in (config_h): Fix conf_post.h out-of-tree build location.
58 * lisp.h (DIRECTORY_SEP): Let configure set it.
60 2012-08-09 Dmitry Antipov <dmantipov@yandex.ru>
62 Use TSET for write access to Lisp_Object slots of struct terminal.
63 * termhooks.h (TSET): New macro.
64 * coding.c, terminal.c, xselect.c: Adjust users.
66 2012-08-08 Stefan Monnier <monnier@iro.umontreal.ca>
68 * xdisp.c (safe_eval_handler): Remove prototype. Receive args describing
69 the failing expression, include them in the error message.
70 * eval.c (internal_condition_case_n): Pass nargs and args to hfun.
71 * lisp.h (internal_condition_case_n): Update declaration.
73 2012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
75 Inline functions to examine and change buffer overlays.
76 * buffer.c (unchain_both): New function.
77 * buffer.h (buffer_get_overlays, buffer_set_overlays):
78 (buffer_has_overlays): New function.
79 (enum overlay_type): New enum.
80 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c:
81 * insdel.c, intervals.c, print.c, xdisp.c: Adjust users.
83 2012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
85 Inline functions to examine and change buffer intervals.
86 * alloc.c (mark_interval_tree): Remove.
87 (MARK_INTERVAL_TREE): Simplify.
88 (UNMARK_BALANCE_INTERVALS): Remove. Adjust users.
89 * intervals.c (buffer_balance_intervals): New function.
90 (graft_intervals_into_buffer): Adjust indentation.
91 (set_intervals_multibyte): Simplify.
92 * buffer.h (BUF_INTERVALS): Remove.
93 (buffer_get_intervals, buffer_set_intervals): New function.
94 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c, insdel.c:
95 * intervals.c, textprop.c: Adjust users.
97 2012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
99 Inline functions to examine and change string intervals.
100 * lisp.h (STRING_INTERVALS, STRING_SET_INTERVALS): Remove.
101 (string_get_intervals, string_set_intervals): New function.
102 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
103 * lread.c, print.c, textprop.c: Adjust users.
105 2012-08-08 Glenn Morris <rgm@gnu.org>
107 * lisp.mk (lisp): Remove language/persian.elc.
109 2012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
112 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
113 (NULL_INTERVAL_P): Likewise. Adjust users.
114 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P): Adjust
115 comment. Move under #if 0.
116 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
117 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
119 2012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
121 Check total length of intervals with eassert.
122 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
123 * intervals.c: Change all users to eassert.
125 2012-08-07 Eli Zaretskii <eliz@gnu.org>
127 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist): Rename
128 fields to match removal of FGET and WGET and disuse of
129 INTERNAL_FIELD in Lisp_Cons.
131 2012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
133 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
134 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
135 name since all xname users are fixed long time ago. Do not
137 (set_symbol_name, set_symbol_function, set_symbol_plist):
138 (set_symbol_next, set_overlay_plist): New function.
139 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
140 (struct Lisp_Overlay): Likewise.
141 (CVAR, MVAR, SVAR): Remove.
142 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
143 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
144 * xterm.c: Adjust users.
145 * .gdbinit: Change to use name field of struct Lisp_Symbol
148 2012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
150 Basic functions to set Lisp_Object and pointer slots of intervals.
151 * intervals.h (interval_set_parent, interval_set_object):
152 (interval_set_left, interval_set_right, interval_set_plist):
153 (interval_copy_parent): New function.
154 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
155 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE): Adjust
157 (INTERVAL_SIZE): Remove. Adjust users.
158 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
160 2012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
162 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
163 * process.h (PGET): Remove.
164 (struct Lisp_Process): Do not use INTERNAL_FIELD.
165 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
167 2012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
169 Drop WGET and revert read access to Lisp_Objects slots of struct window.
170 * window.h (WGET): Remove.
171 (struct window): Do not use INTERNAL_FIELD.
172 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
173 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
174 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
175 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
176 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
179 2012-08-07 Chong Yidong <cyd@gnu.org>
181 * window.c (Fwindow_edges, Fwindow_pixel_edges)
182 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
183 (Fdelete_window_internal): Signal an error if the window is not on
184 a live frame (Bug#12025).
186 2012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
188 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
189 * frame.h (FGET): Remove.
190 (struct frame): Do not use INTERNAL_FIELD.
191 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
192 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
193 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
194 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
196 2012-08-06 Juanma Barranquero <lekktu@gmail.com>
198 * w32.c: Silence compiler warnings.
199 (map_w32_filename): Remove unused variable `is_fat'.
200 (chase_symlinks): Add parentheses around expression.
202 2012-08-06 Glenn Morris <rgm@gnu.org>
204 * sysdep.c: Respect BROKEN_GETWD.
206 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
207 Let configure handle it.
208 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
210 2012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
212 Use GCALIGNMENT where appropriate.
213 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
214 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
215 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
217 2012-08-06 Eli Zaretskii <eliz@gnu.org>
219 * w32menu.c (set_frame_menubar, initialize_frame_menubar): Don't
220 use FRAME_MENU_BAR_ITEMS as an lvalue.
222 2012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
224 * buffer.h (struct buffer): Revert `indirections' to a simple int;
225 that should be sufficient for everyone.
227 2012-08-06 Jan Djärv <jan.h.d@swipnet.se>
229 * keyboard.c (timer_check_2): Add break so timer_check returns next
232 2012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
234 Fix Windows build errors introduced after converting to WGET and WSET.
235 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
236 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
238 2012-08-06 Jan Djärv <jan.h.d@swipnet.se>
240 * nsterm.m (ns_frame_rehighlight): Use FSET.
242 * nsmenu.m (ns_update_menubar): Use FSET.
244 2012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
246 Separate read and write access to Lisp_Object slots of Lisp_Process.
247 * process.h (PGET, PSET): New macros similar to AREF and ASET.
248 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
250 2012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
252 Separate read and write access to Lisp_Object slots of struct window.
253 * window.h (WGET, WSET): New macros similar to AREF and ASET.
254 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
255 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
256 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
257 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
258 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
261 2012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
263 Fix Windows build errors introduced after converting to FGET and FSET.
264 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
265 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
266 (w32_judge_scroll_bars): Change to use FSET.
267 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
269 2012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
271 Fix replacement typo.
272 * window.c (replace_window): Set root_window instead of
273 selected_window. This fixes a total window subsystem
274 malfunction reported by Bastien Guerry <bzg@gnu.org>.
276 2012-08-06 Glenn Morris <rgm@gnu.org>
278 * lisp.mk (lisp): Add language/persian.elc.
280 2012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
282 Separate read and write access to Lisp_Object slots of struct frame.
283 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
284 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
285 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
286 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
287 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
289 2012-08-05 Andreas Schwab <schwab@linux-m68k.org>
291 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
293 2012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
295 Generalize common compile-time constants.
296 * lisp.h (header_size, bool_header_size, word_size): Now here.
297 (struct Lisp_Vector): Add comment.
298 (struct Lisp_Bool_Vector): Move up to define handy constants.
299 (VECSIZE, PSEUDOVECSIZE): Simplify.
300 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
301 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
302 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
303 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
304 * xfont.c, xmenu.c: Use word_size where appropriate.
306 2012-08-05 Lawrence Mitchell <wence@gmx.li>
308 * search.c (Freplace_match): Treat \? in the replacement text
309 literally (Bug#8161).
311 2012-08-05 Chong Yidong <cyd@gnu.org>
313 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
314 * frame.c (Vdelete_frame_functions):
315 * emacs.c (Vkill_emacs_hook): Doc fix.
317 2012-08-04 Eli Zaretskii <eliz@gnu.org>
319 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
320 --with-x-toolkit=no builds.
321 Reported by Carsten Mattner <carstenmattner@gmail.com>.
323 2012-08-04 Chong Yidong <cyd@gnu.org>
325 * syntax.c (Fmodify_syntax_entry): Doc fix.
327 2012-08-04 Eli Zaretskii <eliz@gnu.org>
329 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
330 * w32.c (init_environment): Change the default values of many
331 environment variables in dflt_envvars[] to NULL, to avoid pushing
332 them into environment when they were not already defined. Remove
333 the code that deletes site-lisp subdirectories from the default
334 value of EMACSLOADPATH, as it is no longer needed.
335 (check_windows_init_file): Now external, not static. Use
336 Vload_path as is, without adding anything, as this function is now
337 called when Vload_path is already set up.
339 * w32.h (check_windows_init_file): Add prototype.
341 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
342 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
343 compatibility with Posix platforms.
344 (main): Move the call to check_windows_init_file to here from
346 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
347 any, in the DEFALT argument into the root of the Emacs build or
348 installation tree, as appropriate.
350 * callproc.c (init_callproc_1): Call decode_env_path instead of
351 doing its equivalent by hand.
352 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
353 the code that sets Vexec_path run on MS-Windows.
355 * lread.c (init_lread): Add comments to #ifdef's.
357 * msdos.c (dos_set_window_size, IT_update_begin)
358 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
359 instead of direct references.
361 2012-08-04 Paul Eggert <eggert@cs.ucla.edu>
363 Export DEFAULT_REHASH_* to GDB.
364 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
365 Now constants, not macros.
367 2012-08-03 Paul Eggert <eggert@cs.ucla.edu>
369 Remove unnecessary casts involving pointers.
370 These casts are no longer needed now that we assume C89 or later,
371 since they involve casting to or from void *.
372 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
373 (make_pure_float, make_pure_vector):
374 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
375 * macros.c (Fstart_kbd_macro):
376 * menu.c (find_and_return_menu_selection):
377 * minibuf.c (read_minibuf_noninteractive):
378 * sysdep.c (closedir):
379 * xdisp.c (x_produce_glyphs):
380 * xfaces.c (compare_fonts_by_sort_order):
381 * xfns.c (x_real_positions, select_visual):
382 * xselect.c (x_stop_queuing_selection_requests)
383 (x_get_window_property, x_get_window_property_as_lisp_data):
384 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
385 Remove unnecessary pointer casts.
386 * alloc.c (record_xmalloc): New function.
387 * lisp.h (record_xmalloc): New decl.
388 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
389 more like a function. This is because the pointer cast is not
390 needed. All uses changed.
391 * print.c (print_string, print_error_message): Avoid length recalc.
393 Improve fix for macroexp crash with debugging (Bug#12118).
394 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
395 ARRAY_MARK_FLAG when checking subscripts, because ASET is
396 not supposed to be invoked from the garbage collector.
397 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
398 (gc_aset): New function, which is like ASET but can be
399 used in the garbage collector.
400 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
401 (set_hash_index): Use it instead of ASET.
403 2012-08-03 Eli Zaretskii <eliz@gnu.org>
405 Support symlinks on latest versions of MS-Windows.
406 * w32.c: Include winioctl.h and aclapi.h.
407 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
408 (revert_to_self): Forward declarations of static functions.
409 <static BOOL g_b_init_get_security_info>:
410 <g_b_init_create_symbolic_link>: New static flags.
411 (globals_of_w32): Initialize them to zero.
412 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
413 (map_w32_filename): Improve commentary. Simplify switch.
414 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
415 headers (most versions of MinGW w32api don't).
416 (get_security_info, create_symbolic_link)
417 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
419 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
420 in the argument file name.
421 (sys_access): Call unc_volume_file_attributes only if
422 GetFileAttributes fails with network-related error codes.
423 (sys_rename): Diagnose renaming of a symlink when the user doesn't
424 have the required privileges.
425 (get_file_security_desc_by_name): Renamed from
426 get_file_security_desc.
427 (stat_worker): New function, with most of the guts of 'stat', and
428 with addition of handling of symlinks and support for 'lstat'. If
429 possible, get file's attributes and security information by
430 handle, not by name. Produce S_IFLNK bit for symlinks, when
432 (stat, lstat): New functions, call 'stat_worker'.
433 (symlink, readlink, careadlinkat): Rewritten to create and resolve
434 symlinks when the underlying filesystem supports them.
436 2012-08-02 Paul Eggert <eggert@cs.ucla.edu>
438 Fix macroexp crash on Windows with debugging (Bug#12118).
439 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
440 checking subscripts; problem introduced with the recent
441 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
442 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
443 since it's used in non-static inline functions now.
445 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
446 Don't assume buffer size fits in 'int'. Remove unused local.
448 Use C99-style 'extern inline' if available.
449 * buffer.h (BUFFER_INLINE):
450 * category.h (CATEGORY_INLINE):
451 * character.h (CHARACTER_INLINE):
452 * charset.h (CHARSET_INLINE):
453 * composite.h (COMPOSITE_INLINE):
454 * dispextern.h (DISPEXTERN_INLINE):
455 * lisp.h (LISP_INLINE):
456 * systime.h (SYSTIME_INLINE):
457 New macro, replacing 'static inline' in this header.
458 * buffer.h, category.h, character.h, charset.h, composite.h:
459 * dispextern.h, lisp.h, systime.h:
460 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
461 * alloc.c (LISP_INLINE):
462 * buffer.c (BUFFER_INLINE):
463 * category.c (CATEGORY_INLINE):
464 * character.c (CHARACTER_INLINE):
465 * charset.c (CHARSET_INLINE):
466 * composite.c (COMPOSITE_INLINE):
467 * dispnew.c (DISPEXTERN_INLINE):
468 * sysdep.c (SYSTIME_INLINE):
469 Define to EXTERN_INLINE, so that the corresponding functions
470 are compiled into code.
471 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
472 (INLINE_HEADER_END): New macros.
473 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
474 since it's used in non-static inline functions now.
475 (VALMASK) [!USE_LSB_TAG]: Likewise.
477 2012-08-02 Glenn Morris <rgm@gnu.org>
479 * s/: Remove empty directory.
481 * s/ms-w32.h: Move to ../nt/inc.
482 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
483 Update for new ms-w32.h location.
485 2012-08-02 Paul Eggert <eggert@cs.ucla.edu>
488 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
490 2012-08-02 Glenn Morris <rgm@gnu.org>
492 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
493 hard-coding the path separator.
495 2012-08-01 Paul Eggert <eggert@cs.ucla.edu>
497 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
498 This how ASET and AREF are supposed to work, and makes
499 it easier to think about future improvements. See
500 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
501 * charset.h (set_charset_attr): New function.
502 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
503 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
504 (aref_addr): New function. All uses of &AREF(...) changed.
505 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
506 (set_hash_index): New functions. All lvalue-style uses of
507 HASH_KEY etc. changed.
508 * keyboard.c (set_prop): New function. All lvalue-style uses
511 2012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
513 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
514 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
515 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
516 * nsfns.m (ns_set_name_as_filename): Likewise.
517 * nsmenu.m (ns_update_menubar): Likewise.
518 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
520 2012-08-01 Eli Zaretskii <eliz@gnu.org>
522 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
523 Adapt to latest changes in field names of the corresponding Lisp
526 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
528 2012-08-01 Glenn Morris <rgm@gnu.org>
530 * s/msdos.h: Remove file.
531 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
532 * Makefile.in (S_FILE): Remove.
533 (config_h): Remove S_FILE.
535 2012-08-01 Juanma Barranquero <lekktu@gmail.com>
537 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
538 Remove; moved to nt/config.nt.
540 2012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
542 Use INTERNAL_FIELD for conses and overlays.
543 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
544 Remove obsolete comment.
546 (struct Lisp_Overlay): Use INTERNAL_FIELD.
547 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
549 2012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
551 Use INTERNAL_FIELD for symbols.
552 * lisp.h (SVAR): New macro. Adjust users.
553 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
554 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
556 2012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
558 Use INTERNAL_FIELD for processes.
559 * process.h (PVAR): New macro. Adjust style.
560 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
561 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
563 2012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
565 Use INTERNAL_FIELD for windows.
566 * window.h (WVAR): New macro.
567 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
568 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
569 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
570 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
571 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
572 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
574 2012-08-01 Paul Eggert <eggert@cs.ucla.edu>
576 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
578 2012-08-01 Glenn Morris <rgm@gnu.org>
580 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
581 Move to configure.ac.
583 2012-08-01 Juanma Barranquero <lekktu@gmail.com>
585 * makefile.w32-in (CONFIG_H): Update dependencies.
586 (CONF_POST_H): New macro.
588 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
590 2012-07-31 Glenn Morris <rgm@gnu.org>
592 * Makefile.in (S_FILE): No longer set by configure.
594 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
596 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
598 * process.h (NULL_DEVICE):
600 * editfns.c (USER_FULL_NAME): Let configure set them.
602 * s/README, s/template.h: Remove files.
604 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
606 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
607 Move to configure.ac.
609 2012-07-31 Eli Zaretskii <eliz@gnu.org>
611 * .gdbinit (xframe): Adapt to introduction of FVAR and the
612 resulting renaming of 'struct frame' members.
614 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
616 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
617 after introduction of FVAR.
619 2012-07-31 Jan Djärv <jan.h.d@swipnet.se>
621 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
623 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
624 instead of compositeToPoint.
625 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
627 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
629 2012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
631 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
632 * lisp.h (INTERNAL_FIELD): New macro.
633 * buffer.h (BUFFER_INTERNAL_FIELD): Removed.
634 (BVAR): Change to use INTERNAL_FIELD.
635 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
636 (KVAR): Change to use INTERNAL_FIELD.
637 * frame.h (FVAR): New macro.
638 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
639 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
640 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
641 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
642 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
644 2012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
646 Miscellaneous fixes for non-default X toolkits.
647 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
648 * xterm.c (x_frame_of_widget): Remove redundant prototype.
649 Move under #ifdef USE_LUCID.
650 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
651 definition and usage to avoid warnings.
653 2012-07-31 Jan Djärv <jan.h.d@swipnet.se>
655 * nsterm.m (openFiles): Fix previous checkin.
657 2012-07-31 Paul Eggert <eggert@cs.ucla.edu>
659 * indent.c (compute_motion): Remove unused local.
661 2012-07-31 Glenn Morris <rgm@gnu.org>
663 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
665 * conf_post.h [USG5_4]:
666 Move remaining contents of s/usg5-4-common.h here.
667 * s/usg5-4-common.h: Remove file.
669 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
670 * s/irix6-5.h: Remove file.
672 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
673 * s/darwin.h: Remove file.
675 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
676 * s/hpux10-20.h: Remove file, which is now empty.
678 2012-07-30 Glenn Morris <rgm@gnu.org>
680 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
681 * Makefile.in (config_h): Add conf_post.h.
682 * makefile.w32-in (CONFIG_H): Add conf_post.h.
684 2012-07-30 Jan Djärv <jan.h.d@swipnet.se>
686 * nsterm.m (ns_do_open_file): New variable.
687 (ns_term_init): Set ns_do_open_file to YES after run returns.
688 (openFile, openTempFile, openFileWithoutUI, openFiles): Open
689 files only if ns_do_open_file.
691 2012-07-30 Paul Eggert <eggert@cs.ucla.edu>
693 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
694 This no-op macro hasn't been needed for many years.
695 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
697 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
698 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
699 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
700 gdb_make_enums_visible.
701 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
702 (DIRECTORY_SEP): Now a constant, not a macro.
704 2012-07-30 Eli Zaretskii <eliz@gnu.org>
706 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
707 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
709 * w32term.c <w32_keyboard_codepage>: Renamed from
710 keyboard_codepage and now external. All users changed.
712 * w32term.h: Add declaration of w32_keyboard_codepage.
714 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
715 the codepage to translate keys to Unicode. If this argument is
716 -1, use the value returned by GetConsoleCP. All callers changed.
718 2012-07-30 Paul Eggert <eggert@cs.ucla.edu>
720 Update .PHONY listings in makefiles.
721 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
722 bootstrap-clean, distclean, maintainer-clean, versioclean,
725 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
726 This is a bit clearer. Fix some commentary typos.
728 2012-07-30 Glenn Morris <rgm@gnu.org>
730 * s/netbsd.h: Let configure include signal.h if needed.
731 Remove file, which is now empty.
733 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
734 Let configure set them.
735 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
736 No more need to undefine.
738 2012-07-30 Andreas Schwab <schwab@linux-m68k.org>
740 * keymap.c (Fkey_description): Don't remove 0x80 bit from
741 non-single-byte char when adding meta modifier. (Bug#12090)
743 2012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
745 Convert safe_call to use variable number of arguments.
746 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
747 (safe_call2): Fix comment.
748 * lisp.h (safe_call): Adjust prototype.
749 * coding.c (encode_coding_object): Change to use safe_call2.
750 * xfaces.c (merge_face_heights): Change to use safe_call1.
752 2012-07-30 Glenn Morris <rgm@gnu.org>
754 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
755 does that unconditionally. Remove file, which is now empty.
757 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
760 2012-07-30 Paul Eggert <eggert@cs.ucla.edu>
762 Export to GDB most of lisp.h's remaining object-like macros.
763 * lisp.h (min, max): Move earlier, because they're used earlier now.
764 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
765 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
766 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
767 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
768 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
769 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
770 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
771 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
772 Now constants, for GDB. They need not be macros.
773 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
774 Now constants, for GDB, as well as macros, for static initializers.
775 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
776 Move to after the definition of struct Lisp_Char_Table,
777 since the former now needs that type defined.
778 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
779 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
780 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
781 New enums, for gdb_make_enums_visible.
782 (GLYPH_MODE_LINE_FACE): Remove; unused.
783 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
784 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
785 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
786 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
787 enum maxargs, enum MAX_ALLOCA.
788 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
789 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
790 no longer needed, now that they are done in lisp.h.
792 2012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
794 Cleanup string bytes checking.
795 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
796 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
797 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
798 (check_sblock, compact_small_strings): Simplify.
800 2012-07-29 Paul Eggert <eggert@cs.ucla.edu>
802 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
803 These macros are confusing and no longer need to be defined, as
804 the enum values now suffice. All uses replaced with definiens.
805 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
807 2012-07-29 Juanma Barranquero <lekktu@gmail.com>
809 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
810 ($(BLD)/w32console.$(O)): Update dependencies.
812 2012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
814 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
815 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
817 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
819 2012-07-29 Jan Djärv <jan.h.d@swipnet.se>
821 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
822 setting sitelisp (Bug#12010).
824 2012-07-29 Eli Zaretskii <eliz@gnu.org>
826 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
828 * w32heap.c (cache_system_info):
829 * w32.c (sys_rename):
830 * w32proc.c (find_child_console, sys_kill): All users changed.
832 2012-07-29 Paul Eggert <eggert@cs.ucla.edu>
834 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
836 2012-07-29 Eli Zaretskii <eliz@gnu.org>
838 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
840 2012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
842 Cleanup statistics calculation in Fgarbage_collect.
843 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
844 zombies percentage calculation. Simplify elapsed time calculation.
846 2012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
848 Generalize marker debugging code under MARKER_DEBUG and use eassert.
849 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
850 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
851 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
852 (replace_range, replace_range_2, del_range_2): Change to eassert.
853 * marker.c (byte_char_debug_check): Adjust style.
855 2012-07-29 Paul Eggert <eggert@cs.ucla.edu>
857 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
858 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
859 long-ago-commented-out code that talks about "WIN32".
860 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
863 2012-07-28 Paul Eggert <eggert@cs.ucla.edu>
865 Use Gnulib stdalign module (Bug#9772, Bug#9960).
866 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
867 Simplify by using alignof.
868 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
869 * lisp.h: Include <stdalign.h>.
870 (GCALIGNMENT): New macro and constant.
871 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
872 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
873 (stdalign): New macro, if not already defined.
875 2012-07-28 Eli Zaretskii <eliz@gnu.org>
877 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
878 * w32inevt.c: Include w32inevt.h.
879 (w32_read_console_input): New inline function, calls either
880 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
881 w32_console_unicode_input.
882 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
883 (w32_kbd_patch_key, key_event): Use the codepage returned by
884 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
885 (key_event): use uChar.UnicodeChar only if
886 w32_console_unicode_input is non-zero.
888 * w32console.c: Include w32heap.h.
889 <w32_console_unicode_input>: New global variable.
890 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
891 family of Windows, zero otherwise.
893 * w32inevt.h: Declare w32_console_unicode_input.
895 * xdisp.c (init_iterator): Don't reference tip_frame in a build
896 --without-x. (Bug#11742)
898 2012-07-27 Paul Eggert <eggert@cs.ucla.edu>
900 Adjust GDB to reflect pvec_type changes (Bug#12036).
901 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
902 2012-07-04 changes to pseudovector representation. Problem
903 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
905 2012-07-27 Michael Albinus <michael.albinus@gmx.de>
907 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
909 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
911 2012-07-27 Eli Zaretskii <eliz@gnu.org>
913 * alloc.c (listn): Fix the order the arguments are consed onto the
916 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
917 enumeration constants, as PURE and HEAP are too general, and clash
918 with other headers and sources, such as gmalloc.c and the
919 MS-Windows system headers. All users changed.
921 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
923 Revert last save_excursion_save and save_excursion_restore changes.
924 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
925 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
927 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
929 Fix recently-introduced typos in Windows port.
930 Reported by Martin Rudalics <rudalics@gmx.at>.
931 * w32.c (init_environment): Replace comma with semicolon.
932 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
934 2012-07-27 Paul Eggert <eggert@cs.ucla.edu>
936 Improve GDB symbol export (Bug#12036).
937 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
938 arms of an 'if', not using conditional expressions; otherwise GDB
939 complains about the types in the unevaluated arm when the argument
940 is an integer literal.
941 (xgetint): Simplify expression.
942 * alloc.c (gdb_make_enums_visible): New constant. This ports to
943 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
944 Zaretskii in <http://bugs.gnu.org/12036#13>.
945 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
946 needed now that we have gdb_make_enums_visible.
947 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
948 (enum enum_USE_LSB_TAG):
949 New enum types, packaging up enums that need to be exported to GDB.
951 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
953 Utility function to make a list from specified amount of objects.
954 * lisp.h (enum constype): New datatype.
955 (listn): New prototype.
956 * alloc.c (listn): New function.
957 (Fmemory_use_count, syms_of_alloc): Use it.
958 * buffer.c (syms_of_buffer): Likewise.
959 * callint.c (syms_of_callint): Likewise.
960 * charset.c (define_charset_internal): Likewise.
961 * coding.c (syms_of_coding): Likewise.
962 * keymap.c (syms_of_keymap): Likewise.
963 * search.c (syms_of_search): Likewise.
964 * syntax.c (syms_of_syntax): Likewise.
965 * w32.c (init_environment): Likewise.
966 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
967 * xdisp.c (syms_of_xdisp): Likewise.
968 * xfns.c (syms_of_xfns): Likewise.
970 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
972 Fast save_excursion_save and save_excursion_restore.
973 * lisp.h (struct Lisp_Excursion): New data type.
974 (PVEC_EXCURSION): New pseudovector type.
975 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
976 to deal with it. Adjust comments.
977 (init_marker, attach_marker): New prototype.
978 (unchain_marker): Adjust prototype.
979 * marker.c (attach_marker): Change to global.
980 (init_marker): New function.
981 * alloc.c (Fmake_marker, build_marker): Use it.
982 (build_marker): More easserts.
983 (mark_object): Handle struct Lisp_Excursion.
984 * editfns.c (save_excursion_save, save_excursion_restore):
985 Reimplement to use struct Lisp_Excursion. Add comments.
987 2012-07-26 Paul Eggert <eggert@cs.ucla.edu>
989 Fix export of symbols to GDB (Bug#12036).
990 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
991 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
992 emacs.c, as this is a more-suitable home. Had this been done earlier
993 the fix for 12036 would have avoided some of the problems noted in
994 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
995 would have been more obvious.
996 * emacs.c: Do not include <verify.h>; no longer needed.
997 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
998 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
999 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
1000 Remove; now done in lisp.h.
1001 * lisp.h (PUBLISH_TO_GDB): New macro.
1002 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
1003 (DATA_SEG_BITS): Use it.
1004 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
1005 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
1006 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
1007 not be usable in #if. This simplifies things.
1009 2012-07-26 Juanma Barranquero <lekktu@gmail.com>
1011 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
1013 2012-07-26 Paul Eggert <eggert@cs.ucla.edu>
1015 Simplify export of symbols to GDB (Bug#12036).
1016 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
1017 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
1018 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
1019 Adjust to changes in lisp.h and emacs.c, by using
1020 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
1021 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
1022 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
1023 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
1024 instead of gdb_valbits.
1025 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
1026 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
1027 instead of gdb_array_mark_flag.
1028 (xboolvector): Get size from $->size, not $->header.size.
1029 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
1030 (xreload, hook-run, hookpost-run): Remove.
1031 * emacs.c: Include <verify.h>.
1032 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
1033 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
1035 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
1036 (gdb_USE_LSB_TAG): New enum constants.
1037 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
1038 Also define these as enum constants, so they're visible to GDB.
1039 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
1040 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
1041 as constants, so they're visible to GDB.
1042 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
1043 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
1044 Now enum constants, not macros, so they're visible to GDB.
1045 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
1046 more convenient now. All uses changed.
1047 (VALMASK) [USE_LSB_TAG]: Also define in this case.
1048 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
1050 2012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
1052 Explicitly free restriction data that are not needed anymore.
1053 * editfns.c (save_restriction_restore): Free restriction data.
1055 2012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1057 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
1058 add argument, tune behavior, and adjust all callers.
1060 2012-07-25 Paul Eggert <eggert@cs.ucla.edu>
1062 Use typedef for EMACS_INT, EMACS_UINT.
1063 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
1064 than macros. This simplifies debugging in the usual case, since
1065 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
1066 and it allows expressions involving EMACS_INT casts.
1067 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
1069 2012-07-25 Jan Djärv <jan.h.d@swipnet.se>
1071 * nsterm.m (ns_read_socket): Return early if there is a modal
1074 2012-07-25 Martin Rudalics <rudalics@gmx.at>
1076 * frame.c (Fredirect_frame_focus): In doc-string don't mention
1077 that FOCUS-FRAME can be omitted.
1079 2012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
1081 Adjust buffer text indirection counters at the end of Fkill_buffer.
1082 * buffer.c (Fkill_buffer): Adjust indirection counters when the
1083 buffer is definitely dead. This should really fix an issue reported
1084 by Christoph Scholtes again. (Bug#12007).
1085 (init_buffer_once): Initialize indirection counters of
1086 buffer_defaults and buffer_local_symbols (for sanity and safety).
1088 2012-07-24 Eli Zaretskii <eliz@gnu.org>
1090 * xdisp.c (init_iterator): Don't compute dimensions of truncation
1091 and continuation glyphs on tooltip frames, leave them at zero.
1092 Avoids continued lines in tooltips. (Bug#11832)
1094 2012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
1096 Simplify copy_overlay.
1097 * buffer.c (copy_overlay): Simplify. Use build_marker.
1098 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
1100 2012-07-23 Eli Zaretskii <eliz@gnu.org>
1102 * print.c (print_object): Don't crash when a frame's name is nil
1103 or invalid. (Bug#12025)
1105 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
1106 it signals an error when a tooltip frame is being created.
1108 2012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
1110 Cleanup miscellaneous objects allocation and initialization.
1111 * alloc.c (allocate_misc): Change to static. Add argument to
1112 specify the subtype. Adjust comment and users.
1113 (build_overlay): New function.
1114 * buffer.c (copy_overlays, Fmake_overlay): Use it.
1115 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
1116 (allocate_misc): Remove prototype.
1117 (build_overlay): Add prototype.
1119 2012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
1121 Swap buffer text indirection counters in Fbuffer_swap_text.
1122 * buffer.c (Fbuffer_swap_text): Swap indirections too.
1123 This avoids crash reported by Christoph Scholtes at
1124 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
1126 2012-07-22 Jan Djärv <jan.h.d@swipnet.se>
1128 * nsmenu.m (Popdown_data): New struct.
1129 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
1131 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
1132 (initWithContentRect): Make imgView and contentView non-static
1133 and autorelease them. Also autorelease img and matrix (Bug#12005).
1134 (dealloc): Remove (Bug#12005).
1136 2012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1138 Adjust consing_since_gc when objects are explicitly freed.
1139 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
1140 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
1141 (free_cons, free_misc): Subtract object size from consing_since_gc.
1143 2012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1145 Simplify and cleanup markers positioning code.
1146 * marker.c (attach_marker): More useful eassert.
1147 (live_buffer, set_marker_internal): New function.
1148 (Fset_marker, set_marker_restricted): Use set_marker_internal.
1149 (set_marker_both, set_marker_restricted_both): Use live_buffer.
1151 2012-07-22 Paul Eggert <eggert@cs.ucla.edu>
1153 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
1154 as it's limited by the amount of memory, not by INT_MAX.
1156 2012-07-21 Eli Zaretskii <eliz@gnu.org>
1158 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
1159 in special-event-map. See the discussion at
1160 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
1163 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
1164 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
1165 Fabrice Popineau <fabrice.popineau@supelec.fr>.
1167 2012-07-21 Jan Djärv <jan.h.d@swipnet.se>
1169 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
1170 (conversationIdentifier): Return value is NSInteger.
1171 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
1173 2012-07-21 Chong Yidong <cyd@gnu.org>
1175 * window.c (decode_any_window): Signal an error if the window is
1176 on a dead frame (Bug#11984).
1178 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1180 Add indirection counting to speed up Fkill_buffer.
1181 * buffer.h (struct buffer): New member.
1182 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
1183 (Fmake_indirect_buffer): Set indirection counter to -1, increment
1184 base buffer indirection counter.
1185 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
1186 (Fkill_buffer): Adjust indirection counters as needed, don't walk
1187 through buffer list if indirection counter is 0.
1189 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1191 Extend the value returned by Fgarbage_collect with heap statistics.
1192 * alloc.c (Qheap): New symbol.
1193 (syms_of_alloc): DEFSYM it.
1194 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
1195 (Fmemory_free): Remove.
1196 (syms_of_alloc): Don't defsubr it.
1197 * buffer.c (Fcompact_buffer): Remove.
1198 (syms_of_buffer): Don't defsubr it.
1200 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1202 Make maybe_gc inline.
1203 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
1204 * lisp.h (consing_since_gc, gc_relative_threshold)
1205 (memory_full_cons_threshold): Revert declaration.
1206 (maybe_gc): Remove prototype, define as inline.
1207 * alloc.c: Remove old commented-out code.
1208 (consing_since_gc, gc_relative_threshold)
1209 (memory_full_cons_threshold): Revert to global.
1212 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1214 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
1215 * lisp.h (build_unibyte_string): New function.
1216 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
1217 * sysdep.c, w32fns.c, xfns.c: Use it.
1218 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
1219 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
1220 Adjust users accordingly.
1221 * font.h (font_open_by_name): Adjust prototype.
1223 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1225 Cleanup calls to Fgarbage_collect.
1226 * lisp.h (maybe_gc): New prototype.
1227 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1228 Remove declarations.
1229 * alloc.c (maybe_gc): New function.
1230 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1232 * bytecode.c (MAYBE_GC): Use maybe_gc.
1233 * eval.c (eval_sub, Ffuncall): Likewise.
1234 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
1235 to avoid dependency from auto-save feature.
1237 2012-07-19 Paul Eggert <eggert@cs.ucla.edu>
1239 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
1240 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
1241 'for_each_per_buffer_object_at'.
1242 All uses changed. It's better to use upper-case for macros that
1243 cannot be implemented as functions, to give the reader a clue
1244 that they're special.
1246 2012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
1248 * alloc.c (Fgarbage_collect): Tweak docstring.
1250 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1252 Tweak the value returned from Fgarbage_collect again.
1253 * alloc.c (Fgarbage_collect): New return value, as confirmed in
1254 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
1255 Adjust documentation.
1256 (total_vector_bytes): Rename to total_vector_slots, adjust
1258 (total_free_vector_bytes): Rename to total_free_vector_slots,
1260 (Qstring_bytes, Qvector_slots): New symbols.
1261 (syms_of_alloc): DEFSYM them.
1263 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1265 Buffer compaction primitive which may be used from Lisp.
1266 * buffer.c (compact_buffer, Fcompact_buffer): New function.
1267 (syms_of_buffer): Register Fcompact_buffer.
1268 * alloc.c (Fgarbage_collect): Use compact_buffer.
1269 * buffer.h (compact_buffer): New prototype.
1270 (struct buffer_text): New member.
1272 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1274 New macro to iterate over all buffers, miscellaneous cleanups.
1275 * lisp.h (all_buffers): Remove declaration.
1276 * buffer.h (all_buffers): Add declaration, with comment.
1277 (for_each_buffer): New macro.
1278 * alloc.c (Fgarbage_collect, mark_object): Use it.
1279 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
1280 (init_buffer): Likewise.
1281 * data.c (Fset_default): Likewise.
1282 * coding.c (code_conversion_restore): Remove redundant check
1284 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
1286 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1288 Fix bug that created negative-length intervals.
1289 * intervals.c (merge_interval_right, merge_interval_left):
1290 Do not zero out this interval if it is absorbed by its children,
1291 as this interval's total length doesn't change in that case. See
1292 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
1294 2012-07-18 Paul Eggert <eggert@cs.ucla.edu>
1296 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
1297 when invoking (make-bool-vector N t) and N is a positive
1298 multiple of 8 -- the last 8 bits were mistakenly cleared.
1300 Remove some struct layout assumptions in bool vectors.
1301 * alloc.c (bool_header_size): New constant.
1302 (header_size, word_size): Move earlier, as they're now used earlier.
1303 Use 'word_size' in a few more places, where it's appropriate.
1304 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
1305 padding before the data member of a bool vector.
1306 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
1307 than doing the check by hand with an abort ().
1309 2012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1311 * eval.c (Fdefvar): Don't check constants since we only set the var if
1312 it's not yet defined anyway (bug#11904).
1314 * lisp.h (last_undo_boundary): Declare new var.
1315 * keyboard.c (command_loop_1): Set it.
1316 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
1317 were auto-added by the command loop (bug#11774).
1319 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1321 * w32font.c (Qsymbol): Remove local definition.
1322 (syms_of_w32font): Don't DEFSYM it.
1324 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1326 Fix sweep_vectors to handle large bool vectors correctly.
1327 * alloc.c (sweep_vectors): Account total_vector_bytes for
1328 bool vectors larger than VBLOCK_BYTES_MAX.
1330 2012-07-18 Chong Yidong <cyd@gnu.org>
1332 * frame.c (x_set_frame_parameters): Revert bogus change introduced
1333 in 2012-05-25 commit by Paul Eggert (Bug#11738).
1335 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1337 Return more descriptive data from Fgarbage_collect.
1338 Suggested by Stefan Monnier in
1339 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
1340 * alloc.c (bounded_number): New function.
1341 (total_buffers, total_vectors): New variable.
1342 (total_string_size): Rename to total_string_bytes, adjust users.
1343 (total_vector_size): Rename to total_vector_bytes, adjust users.
1344 (sweep_vectors): Account total_vectors and total_vector_bytes.
1345 (Fgarbage_collect): New return value. Adjust documentation.
1346 (gc_sweep): Account total_buffers.
1347 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
1348 (VECTOR_SIZE): Remove.
1349 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
1350 (Qinterval, Qmisc): New symbols.
1351 (syms_of_data): Initialize them.
1352 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
1353 (Qcons, Qbuffer): New declarations.
1355 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1357 * alloc.c (Fmemory_free): Account for memory-free's own storage.
1358 Round up, not down. Improve doc.
1360 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1362 Restore old code in allocate_string_data to avoid Faset breakage.
1363 Reported by Julien Danjou <julien@danjou.info> in
1364 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
1365 * alloc.c (allocate_string_data): Restore old code with minor
1366 adjustments, fix comment to explain this subtle issue.
1368 2012-07-17 Eli Zaretskii <eliz@gnu.org>
1370 Remove FILE_SYSTEM_CASE.
1371 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
1373 * fileio.c (FILE_SYSTEM_CASE): Don't define.
1374 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
1375 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
1376 call-process-region passes it through expand-file-name.
1378 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
1380 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1382 Fix crash when creating indirect buffer (Bug#11917)
1383 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
1384 Don't handle unbound variables specially if non-zero.
1385 (Fbuffer_local_variables): Pass zero.
1386 (clone_per_buffer_values): Pass non-zero.
1388 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1390 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
1391 to make the loop interruptible.
1393 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1395 * gnutls.c (emacs_gnutls_handshake): Only retry if
1396 GNUTLS_E_INTERRUPTED.
1398 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1400 Cleanup and convert miscellaneous checks to eassert.
1401 * alloc.c (mark_interval): Fix comment, partially rephrase
1402 old comment from intervals.h (see below).
1403 * intervals.c (find_interval, adjust_intervals_for_insertion)
1404 (delete_interval, adjust_intervals_for_deletion)
1405 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
1407 (adjust_intervals_for_insertion, make_new_interval):
1408 Remove obsolete and unused code.
1409 * intervals.h (struct interval): Remove obsolete comment.
1410 * textprotp.c (erase_properties): Remove unused code.
1411 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
1412 (Fremove_list_of_text_properties): Convert to eassert.
1414 2012-07-17 Chong Yidong <cyd@gnu.org>
1416 * editfns.c (Finsert_char): Doc fix.
1418 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1420 Fix previous change to make Fmemory_free always accurate.
1421 * alloc.c (make_interval): Update total_free_intervals.
1422 (make_float): Likewise for total_free_floats.
1423 (free_cons, Fcons): Likewise for total_free_conses.
1424 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
1425 Likewise for total_free_vector_bytes.
1426 (Fmake_symbol): Likewise for total_free_symbols.
1427 (bytes_free): Remove.
1429 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1431 Simple free memory accounting feature.
1432 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
1433 (sweep_vectors): Accumulate size of free vectors.
1434 (Fgarbage_collect): Setup bytes_free.
1435 (Fmemory_free): New function.
1436 (syms_of_alloc): Register it.
1438 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1440 Cleanup overlays checking.
1441 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
1442 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
1443 eassert and OVERLAYP.
1444 (sort_overlays): Change to use OVERLAYP.
1446 2012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
1448 * editfns.c (Finsert_char): Make it interactive, and make the
1449 second arg optional. Copy interactive spec and docstring from
1452 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1454 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
1455 Unlike the other wrapped functions, fabs has an unspecified
1458 2012-07-16 Jan Djärv <jan.h.d@swipnet.se>
1460 * nsterm.m (keyDown): Interpret flags without left/right bits
1461 as the left key (Bug#11670).
1463 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1465 Remove empty and useless init functions.
1466 * lisp.h (init_character_once, init_fns, init_image)
1467 (init_filelock, init_sound): Remove prototype.
1468 * character.c (init_character_once): Remove.
1469 * filelock.c (init_filelock): Likewise.
1470 * fns.c (init_fns): Likewise.
1471 * image.c (init_image): Likewise.
1472 * sound.c (init_sound): Likewise.
1473 * emacs.c (main): Adjust accordingly.
1475 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1477 * gtkutil.h: Tiny cleanups.
1478 (use_old_gtk_file_dialog): Remove useless declaration.
1479 (xg_uses_old_file_dialog): Add suggested const attribute.
1481 2012-07-15 Eli Zaretskii <eliz@gnu.org>
1483 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
1484 (bidi_paragraph_init): Use it to limit search forward for a strong
1485 directional character in abnormally large paragraphs full of
1486 neutral or weak characters. (Bug#11943)
1488 2012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
1490 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
1491 the toolbar (Bug#9451).
1492 (xg_make_tool_item): Give the widget event box a transparent
1495 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1497 Cleanup basic allocation variables and functions.
1498 * alloc.c (ignore_warnings, init_intervals, init_float)
1499 (init_cons, init_symbol, init_marker): Remove.
1500 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
1501 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
1502 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
1503 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
1504 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
1505 (staticidx, init_alloc_once, init_strings, free_ablock):
1506 Remove redundant initialization.
1507 * fns.c (init_weak_hash_tables): Remove.
1508 * lisp.h (init_weak_hash_tables): Remove prototype.
1510 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1512 Use zero_vector where appropriate.
1513 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
1515 * lisp.h (zero_vector): New declaration.
1516 * font.c (null_vector): Remove.
1517 (syms_of_font): Remove initialization and staticpro.
1518 (font_list_entities, font_find_for_lface): Change to use zero_vector.
1519 * keymap.c (Faccessible_keymaps): Likewise.
1521 2012-07-15 Leo Liu <sdl.web@gmail.com>
1523 * fringe.c: Fix typo in comments.
1525 2012-07-14 Leo Liu <sdl.web@gmail.com>
1527 * fringe.c: Add a new bitmap exclamation-mark.
1529 2012-07-14 Eli Zaretskii <eliz@gnu.org>
1531 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
1533 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
1534 (HAVE_MENUS): Don't define, defined by editing config.in with
1536 (GMALLOC_INHIBIT_VALLOC): Don't define.
1537 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
1539 2012-07-14 Juanma Barranquero <lekktu@gmail.com>
1541 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
1543 2012-07-14 Glenn Morris <rgm@gnu.org>
1545 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
1546 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
1547 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
1549 2012-07-13 Glenn Morris <rgm@gnu.org>
1551 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
1553 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
1554 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
1556 2012-07-13 Jan Djärv <jan.h.d@swipnet.se>
1558 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
1559 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
1560 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
1561 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
1563 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
1564 as boolean expression.
1565 (x_set_window_size): Remove unused variable toolbar.
1566 (ns_get_color_default, ns_mod_to_lisp): Remove.
1567 (ns_mouse_position): Remove unused variables xchar and ychar.
1568 (ns_compute_glyph_string_overhangs): Remove unused variable face.
1569 (ns_set_vertical_scroll_bar): Remove unused variable count.
1570 (ns_delete_terminal): Remove unused variable i.
1571 (ns_term_init): Remove unused variables r, g and b.
1572 (mouseDown): Remove unused variable window.
1573 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1574 (initFrameFromEmacs): Remove unused variable vbextra.
1575 (mouseEntered): Remove unused variables p and dpyinfo.
1576 (mouseExited): Remove unused variables p and r.
1577 (ns_define_frame_cursor, ns_clear_frame_area)
1578 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1579 (menuDown): Assign [sender tag] to variable and cast the variable.
1581 * nsterm.h (menuDown): Add id as type to argument sender.
1582 (ns_display_info_for_name): Add Lisp_Object argument.
1583 (ns_term_init): Add Lisp_Object argument.
1584 (ns_map_event_to_object): Add void argument.
1585 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1586 prototype with arguments and only declare if __OBJC__.
1587 (nxatoms_of_nsselect): Add void argument.
1588 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1589 (ns_alloc_autorelease_pool): Add void argument.
1590 (ns_release_autorelease_pool): Add void* argument.
1591 (ns_get_defaults_value): Add const char* argument.
1593 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1594 (initFromContents): Use SSDATA where appropriate.
1595 (ns_update_menubar): Add braces to ambigous if-else.
1596 (initWithTitle): Put () around assignment in if statement.
1597 (ns_menu_show): Remove unused variables window and keymap.
1598 (update_frame_tool_bar): Remove unused variable selected_p.
1599 (initWithContentRect): Remove unused variable this_cmd_name.
1601 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1603 (setXBMColor): Remove unused variable len.
1604 (setPixmapData): Put () around assignment in loop statement.
1606 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1607 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1609 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1610 around assignment in loop statement.
1611 (nsfont_open): Remove unused variable i.
1612 (nsfont_open): Remove unused variable len.
1613 (nsfont_draw): Remove unused variable cs.
1615 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1616 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1617 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1618 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1619 (Fns_font_name, Fns_perform_service)
1620 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1621 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1622 (ns_set_name): Remove unused variable view.
1623 (x_set_menu_bar_lines): Remove unused variable olines.
1624 (x_set_tool_bar_lines): Remove unused variable root_window.
1625 (Fns_list_colors): Put () around assignment in while statement.
1626 (Fns_perform_service): Remove unused variable len.
1627 (Fns_display_usable_bounds): Remove unused variable top.
1628 (syms_of_nsfns): Remove unused variable i.
1630 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1633 2012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
1635 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1636 and free it with DestroyExceptionInfo (Bug#11558).
1638 2012-07-13 Juanma Barranquero <lekktu@gmail.com>
1640 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1641 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1642 Set here, not in nt/config.nt.
1644 2012-07-13 Eli Zaretskii <eliz@gnu.org>
1646 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1647 cursor overflow into the last glyph on display line when the right
1648 fringe is off. (Bug#11832)
1650 2012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1652 * xdisp.c (produce_special_glyphs): Now static.
1653 * dispextern.h (produce_special_glyphs): Remove decl.
1655 2012-07-13 Glenn Morris <rgm@gnu.org>
1657 * s/bsd-common.h, s/cygwin.h: Remove empty files.
1658 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1660 * s/usg5-4-common.h (USG, USG5):
1661 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1662 * s/sol2-6.h (SOLARIS2):
1663 * s/irix6-5.h (IRIX6_5):
1664 * s/hpux10-20.h (USG, USG5, HPUX):
1665 * s/gnu-linux.h (USG, GNU_LINUX):
1666 * s/freebsd.h (BSD_SYSTEM):
1667 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1668 * s/cygwin.h (CYGWIN):
1669 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1670 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1672 2012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
1674 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
1676 2012-07-13 Glenn Morris <rgm@gnu.org>
1678 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1680 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1682 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1683 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1685 2012-07-12 Glenn Morris <rgm@gnu.org>
1687 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
1689 * process.c (init_process_emacs): Rename from init_process.
1690 The old name is also the name of a Mach system call.
1691 * lisp.h, emacs.c: Update for this name change.
1692 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1695 2012-07-12 Eli Zaretskii <eliz@gnu.org>
1697 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1698 memmove call that removes glyphs covered by the left truncation
1699 glyph. Improve commentary.
1700 (display_line): Fix display of continuation glyphs on GUI frames
1701 when the right fringe is turned off and variable-size fonts are
1702 used in the window. Move the code that appends a stretch glyph to
1703 produce_special_glyphs, so that it could be used for truncation
1704 and continuation glyphs alike.
1705 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1706 glyph of a suitably computed width, to align the special glyphs at
1707 the window margin. Code moved from display_line. (Bug#11832)
1709 2012-07-12 Glenn Morris <rgm@gnu.org>
1711 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1713 * s/gnu-linux.h, s/hpux10-20.h:
1714 Do not unconditionally define HAVE_XRMSETDATABASE.
1716 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1718 2012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1720 Fix typos that broke OS X build.
1721 Reported by Randal L. Schwartz in
1722 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1723 * nsterm.m (ns_timeout): Add missing local decl.
1724 (ns_get_color): snprintf -> sprintf, to fix typo.
1726 2012-07-12 Glenn Morris <rgm@gnu.org>
1728 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1729 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1730 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1731 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1733 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1734 Move PTY_OPEN to configure.
1736 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1737 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1738 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1740 2012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1742 Use empty_unibyte_string where applicable.
1743 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1744 * lread.c (read1): Likewise.
1745 * xsettings.c (syms_of_xsettings): Likewise.
1747 2012-07-12 Glenn Morris <rgm@gnu.org>
1749 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1750 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
1751 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1752 * s/hpux10-20.h (RUN_TIME_REMAP):
1753 * s/bsd-common.h (TABDLY): Move to configure.
1755 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1757 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1759 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1760 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
1762 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
1764 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1765 * s/template.h: Move NARROWPROTO to configure.
1767 2012-07-11 Glenn Morris <rgm@gnu.org>
1769 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1770 unused since 2011-01-17 change to systty.h.
1772 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1773 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1774 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1776 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1778 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1780 2012-07-11 Glenn Morris <rgm@gnu.org>
1782 * s/darwin.h, s/gnu-linux.h, s/template.h:
1783 Move INTERRUPT_INPUT to configure.
1785 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1787 Minor adjustments to interning code.
1788 * lisp.h (intern, intern_c_string): Redefine as static inline
1789 wrappers for intern_1 and intern_c_string_1, respectively.
1790 (intern_1, intern_c_string_1): Rename prototypes.
1791 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1793 * font.c (font_intern_prop): Likewise. Adjust comment.
1794 * w32font.c (intern_font_name): Likewise.
1796 2012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1798 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1800 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1801 of Fcar/Fcdr if possible.
1802 * font.c (check_otf_features): Likewise.
1803 * fontset.c (Fnew_fontset): Likewise.
1804 * gnutls.c (Fgnutls_boot): Likewise.
1805 * minibuf.c (read_minibuf): Likewise.
1806 * msdos.c (IT_set_frame_parameters): Likewise.
1807 * xmenu.c (Fx_popup_dialog): Likewise.
1808 * w32menu.c (Fx_popup_dialog): Likewise.
1810 2012-07-11 Glenn Morris <rgm@gnu.org>
1812 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1813 since nothing has defined it on these platforms.
1815 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1816 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1818 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1819 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1820 Move CLASH_DETECTION to configure.
1822 * s/gnu.h: Remove file, which is now empty.
1824 * s/gnu.h, s/gnu-linux.h:
1825 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1827 2012-07-11 John Wiegley <johnw@newartisans.com>
1829 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1830 function attribute, so we only use it if it exists in the
1833 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1835 Avoid call to strlen in fast_c_string_match_ignore_case.
1836 * search.c (fast_c_string_match_ignore_case): Change to use
1837 length argument. Adjust users accordingly.
1838 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1840 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1842 Assume mkdir, rmdir.
1843 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1844 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1847 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1850 * s/hpux10-20.h (HAVE_PERROR): Remove.
1851 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1852 Remove dummy definition, as this problem was obsolete long ago.
1855 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1857 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1859 Avoid calls to strlen in font processing functions.
1860 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
1861 (font_open_by_name): Change to use length argument. Adjust
1863 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1865 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1866 Change to return ptrdiff_t.
1867 (xfont_list_pattern, xfont_match): Use length returned by
1868 xfont_decode_coding_xlfd.
1869 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1871 2012-07-11 Glenn Morris <rgm@gnu.org>
1873 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1874 Move DONT_REOPEN_PTY to configure.
1876 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1877 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1879 2012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1881 Remove "#define unix" that is no longer needed (Bug#11905).
1882 * s/aix4-2.h (unix): Remove; no longer needed.
1884 EMACS_TIME simplification (Bug#11875).
1885 This replaces macros (which typically do not work in GDB)
1886 with functions, typedefs and enums, making the code easier to debug.
1887 The functional style also makes code easier to read and maintain.
1888 * systime.h: Include <sys/time.h> on all hosts, not just if
1889 WINDOWSNT, since 'struct timeval' is needed in general.
1890 (EMACS_TIME): Now a typedef, not a macro.
1891 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1893 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1894 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1895 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1896 (EMACS_TIME_LE): Now functions, not macros.
1897 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1898 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1899 which are not functions. All uses rewritten to use:
1900 (make_emacs_time): New function.
1901 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1902 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1903 not functions. All uses rewritten to use the following, respectively:
1904 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1905 (add_emacs_time, sub_emacs_time): New functions.
1906 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
1907 * fileio.c (Fcopy_file):
1908 * xterm.c (XTflash): Get the current time closer to when it's used.
1909 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1911 * bytecode.c (targets): Suppress -Woverride-init warnings.
1913 Simplify by avoiding confusing use of strncpy etc.
1914 * doc.c (Fsnarf_documentation):
1915 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1916 * frame.c (Fmake_terminal_frame):
1917 * gtkutil.c (get_utf8_string):
1919 * nsmenu.m (ns_update_menubar):
1920 * regex.c (regerror):
1921 Prefer memcpy to strncpy and strncat when either will do.
1922 * fileio.c (Fsubstitute_in_file_name):
1923 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1924 (menu_separator_name_p):
1925 * nsmenu.m (ns_update_menubar):
1926 Prefer memcmp to strncmp when either will do.
1927 * nsterm.m: Include <ftoastr.h>.
1929 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1930 Prefer snprintf to strncpy.
1931 * nsterm.m (ns_term_init):
1932 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1933 * nsterm.m (ns_term_init):
1934 Avoid the need for strncpy, by using build_string or
1935 make_unibyte_string directly. Use dtoastr, not snprintf.
1936 * process.c (Fmake_network_process): Diagnose service names that
1937 are too long, rather than silently truncating them or creating
1938 non-null-terminated names.
1939 (Fnetwork_interface_info): Likewise, for interface names.
1940 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1941 Prefer sprintf to strncat.
1942 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1943 Prefer vsnprintf to vsprintf + strncpy.
1945 2012-07-10 Glenn Morris <rgm@gnu.org>
1947 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1948 Clarify fallback case.
1950 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1952 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1953 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1954 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
1955 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
1956 where argument type is known to be a Lisp_Cons.
1958 2012-07-10 Tom Tromey <tromey@redhat.com>
1960 * bytecode.c (BYTE_CODE_THREADED): New macro.
1961 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1962 (enum byte_code_op): New type.
1963 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1964 (exec_byte_code): Use them. Use token threading when applicable.
1966 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1968 Optimize pure C strings initialization.
1969 * lisp.h (make_pure_string): Fix prototype.
1970 (build_pure_c_string): New function, defined as static inline. This
1971 provides a better opportunity to optimize away calls to strlen when
1972 the function is called with compile-time constant argument.
1973 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1974 argument, adjust users accordingly. Use build_pure_c_string where
1976 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1977 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1978 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1980 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1982 Avoid calls to strlen in miscellaneous functions.
1983 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1984 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1985 * lread.c (openp): Likewise.
1987 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1989 Avoid calls to strlen in path processing functions.
1990 * fileio.c (file_name_as_directory): Add comment. Change to add
1991 srclen argument and return the length of result. Adjust users
1993 (directory_file_name): Fix comment. Change to add srclen argument,
1994 swap 1st and 2nd arguments to obey the common convention. Adjust
1996 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1998 2012-07-10 Glenn Morris <rgm@gnu.org>
2000 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
2001 Move PENDING_OUTPUT_COUNT definition to configure.
2003 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
2004 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
2005 * s/gnu.h (DATA_START): Move definitions to configure.
2007 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
2008 We include usg5-4-common.h, which defines them both.
2010 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
2011 O_RDONLY already includes it).
2013 Stop ns builds setting the EMACSLOADPATH environment variable.
2014 * nsterm.m (ns_load_path): Rename from ns_init_paths.
2015 Now it does not set EMACSLOADPATH, just returns the load-path string.
2016 * nsterm.h: Update accordingly.
2017 * lread.c [HAVE_NS]: Include nsterm.h.
2018 (init_lread) [HAVE_NS]: Use ns_load_path.
2019 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
2021 2012-07-09 Glenn Morris <rgm@gnu.org>
2023 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
2024 since the included bsd-common.h does so.
2026 Stop ns builds setting the EMACSPATH environment variable.
2027 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
2028 (ns_init_paths): Do not set EMACSPATH.
2029 * nsterm.h (ns_exec_path): Add it.
2030 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
2033 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
2035 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
2037 * process.c (wait_reading_process_output): 'waitchannels' was unset
2038 when read_kbd || !NILP (wait_for_cell); fix this.
2040 Add GCC-style 'const' attribute to functions that can use it.
2041 * character.h (char_resolve_modifier_mask):
2042 * keyboard.h (make_ctrl_char):
2043 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
2044 (init_character_once, next_almost_prime, init_fns, init_image)
2045 (flush_pending_output, init_sound):
2046 * mem-limits.h (start_of_data):
2047 * menu.h (finish_menu_items):
2048 Add ATTRIBUTE_CONST.
2049 * emacs.c (DEFINE_DUMMY_FUNCTION):
2050 Declare the dummy function with ATTRIBUTE_CONST.
2051 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
2052 Add decls with ATTRIBUTE_CONST.
2054 Minor improvements to make_formatted_string.
2055 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
2056 where int is good enough, as vsprintf returns an int.
2057 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
2059 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
2061 Use make_formatted_string to avoid double length calculation.
2062 * lisp.h (make_formatted_string): New prototype.
2063 * alloc.c (make_formatted_string): New function.
2064 * buffer.c (Fgenerate_new_buffer_name): Use it.
2065 * dbus.c (syms_of_dbusbind): Likewise.
2066 * editfns.c (Fcurrent_time_zone): Likewise.
2067 * filelock.c (get_boot_time): Likewise.
2068 * frame.c (make_terminal_frame, set_term_frame_name)
2069 (x_report_frame_params): Likewise.
2070 * image.c (gs_load): Likewise.
2071 * minibuf.c (get_minibuffer): Likewise.
2072 * msdos.c (dos_set_window_size): Likewise.
2073 * process.c (make_process): Likewise.
2074 * xdisp.c (ensure_echo_area_buffers): Likewise.
2075 * xsettings.c (apply_xft_settings): Likewise.
2077 2012-07-09 Glenn Morris <rgm@gnu.org>
2079 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
2080 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
2081 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
2082 * nsterm.h (ns_etc_directory): Add it.
2083 * callproc.c [HAVE_NS]: Include nsterm.h.
2084 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
2086 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
2088 Move marker debugging code under MARKER_DEBUG.
2089 * marker.c (MARKER_DEBUG): Move marker debugging code under
2090 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
2091 for bootstrap with --enable-checking (~3x slowdown reported
2092 by Juanma Barranquero <lekktu@gmail.com>).
2093 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
2095 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
2097 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
2098 See <http://bugs.gnu.org/11825#29>.
2100 2012-07-08 Eli Zaretskii <eliz@gnu.org>
2102 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
2103 has no font, use the frame's font. (Bug#11813)
2104 (display_line): Add commentary about displaying truncation glyphs
2106 (produce_special_glyphs): Move here from term.c.
2108 * term.c (produce_special_glyphs): Move to xdisp.c.
2110 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
2113 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
2115 * xdisp.c (display_line): Avoid warning about implicit declaration
2118 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
2120 * lisp.h: Remove empty conditional.
2122 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2124 * lread.c (load_path_check): Now static.
2126 Fix some minor --with-ns problems found by static checking.
2127 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
2128 (x_set_font) [!HAVE_X_WINDOWS]:
2129 * image.c (xpm_load_image) [HAVE_NS]:
2130 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
2131 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
2132 Remove unused local.
2133 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
2134 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
2135 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
2136 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
2137 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
2138 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
2139 Fix pointer signedness problem.
2140 * xfaces.c (FRAME_X_FONT_TABLE):
2141 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
2143 2012-07-07 Glenn Morris <rgm@gnu.org>
2145 * lread.c (load_path_check): New function, split from init_lread.
2146 (init_lread): Reorganize. Motivation:
2147 If EMACSLOADPATH is set, check/warn about that rather than the
2148 defaults, which we are not going to use. Hence we can remove
2149 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
2150 Don't warn if site-lisp directories are missing.
2151 If not installed, start from a blank load-path, since
2152 PATH_LOADSEARCH refers to the eventual installation directories.
2154 2012-07-07 Eli Zaretskii <eliz@gnu.org>
2156 Support truncation and continuation glyphs on GUI frames, when
2157 fringes are disabled. (Bug#11832)
2158 * xdisp.c (init_iterator): Get dimensions of truncation and
2159 continuation glyphs even if on GUI frames. Adjust
2160 it->last_visible_x on GUI frames when the left or right fringes,
2161 or both, are absent.
2162 (start_display, move_it_in_display_line_to): Handle the case of a
2163 GUI frame without a fringe to display continuation or truncation
2165 (insert_left_trunc_glyphs): Support GUI frames: make sure
2166 truncation glyphs overwrite enough glyphs from the current line to
2167 have sufficient space in pixels.
2168 (display_line): Support truncation and continuation glyphs on GUI
2169 frames. If some spare pixels are left on the line after inserting
2170 the truncation glyphs, fill that space with a stretch glyph of a
2171 suitably computed width.
2173 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
2174 produce_glyphs, to support GUI sessions.
2176 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2178 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
2180 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
2182 Do not require float-time's arg to fit in time_t (Bug#11825).
2183 This works better on hosts where time_t is unsigned, and where
2184 float-time is applied to the (negative) difference between two times.
2185 * editfns.c (decode_time_components): Last arg is now double *,
2186 not int *, and means to store all the result as a double, without
2187 worrying about whether the seconds part fits in time_t.
2188 All callers changed.
2189 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
2190 All callers changed.
2191 (Ffloat_time): Do not fail merely because the specified time falls
2192 outside of time_t range.
2194 2012-07-07 Glenn Morris <rgm@gnu.org>
2196 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
2197 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
2198 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
2200 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
2202 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
2203 Update dependencies.
2205 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
2207 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2209 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
2210 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
2211 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
2212 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
2213 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
2214 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
2216 * xfont.c (compare_font_names): Redo to omit the need for casts.
2218 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
2220 * xfns.c (Fx_change_window_property): Doc fix.
2221 * w32fns.c (Fx_change_window_property): Doc fix.
2223 * w32fns.c (Fx_window_property): Accept the same arguments as the
2224 X Windows version. Doc fix.
2225 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
2227 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
2228 Eli Zaretskii <eliz@gnu.org>
2230 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
2231 Windows-specific code from nt/config.nt moved here.
2232 Obsolete settings removed.
2234 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2236 * process.c: Avoid unnecessary calls to gettime.
2237 (wait_reading_process_output): Don't get the time of day
2238 when gobbling data immediately and not waiting, as there's no need
2239 for it in that case. This removes a FIXME.
2241 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
2243 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
2244 is defined (Bug#11768).
2246 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2248 Fix marker debugging code.
2249 * marker.c (byte_char_debug_check): Do not perform the check
2250 if buffer is not multibyte.
2251 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2252 Call byte_char_debug_check with correct arguments.
2254 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2256 Compile marker debugging code only if ENABLE_CHECKING is defined.
2257 * marker.c (byte_char_debug_check, count_markers):
2258 Use only if ENABLE_CHECKING is defined.
2259 (byte_debug_flag): Remove.
2260 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2261 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
2263 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2265 Avoid code repetition in marker-related functions.
2266 * marker.c (attach_marker): New function.
2267 (Fset_marker, set_marker_restricted, set_marker_both)
2268 (set_marker_restricted_both): Use it.
2269 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
2270 Consistently rename charno to charpos.
2271 (marker_position): Add eassert.
2272 (marker_byte_position): Convert to eassert.
2274 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2276 Simplify list operations in unchain_overlay and unchain_marker.
2277 * buffer.c (unchain_overlay): Simplify. Add comment.
2278 * marker.c (unchain_marker): Simplify. Fix comments.
2280 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2282 Introduce fast path for the widely used marker operation.
2283 * alloc.c (build_marker): New function.
2284 * lisp.h (build_marker): New prototype.
2285 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
2286 * composite.c (autocmp_chars): Likewise.
2287 * editfns.c (buildmark): Remove.
2288 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
2289 (save_restriction_save): Use build_marker.
2290 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
2291 * window.c (save_window_save): Likewise.
2293 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2295 Do not use Fdelete_overlay in delete_all_overlays
2296 to avoid redundant calls to unchain_overlay.
2297 * buffer.c (drop_overlay): New function.
2298 (delete_all_overlays, Fdelete_overlay): Use it.
2299 * minibuf.c (get_minibuffer): Fix comment.
2301 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2303 Port to OpenBSD 5.1 amd64.
2304 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
2305 This is needed for OpenBSD, and should be harmless on all BSD systems.
2306 Also, include <sys/sysctl.h>, as it should be available on all
2307 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
2308 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
2309 use p_pid member, not kp_proc.pid.
2311 2012-07-06 Glenn Morris <rgm@gnu.org>
2313 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
2315 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2317 More xmalloc and related cleanup.
2318 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
2319 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
2320 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
2321 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
2322 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
2323 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
2324 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
2325 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
2326 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
2328 Omit needless casts involving void * pointers and allocation.
2329 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
2330 as the former is more robust if P's type is changed.
2331 Prefer xzalloc to xmalloc + memset 0.
2332 Simplify malloc-or-realloc to realloc.
2333 Don't worry about xmalloc returning a null pointer.
2334 Prefer xstrdup to xmalloc + strcpy.
2335 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
2337 * keyboard.c (apply_modifiers_uncached): Prefer local array to
2338 alloca of a constant.
2340 2012-07-05 Eli Zaretskii <eliz@gnu.org>
2342 * xdisp.c (display_line): Fix horizontal pixel coordinates when
2343 hscroll is larger than the line width. Fixes long and futile
2344 looping inside extend_face_to_end_of_line (on a TTY) producing
2345 glyphs that are not needed and thrown away.
2347 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2349 * marker.c (set_marker_restricted_both): Simplify by using
2352 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2354 * editfns.c (region_limit): Simplify by using clip_to_bounds.
2356 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
2358 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
2359 not defined (Bug#11768).
2360 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
2361 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
2362 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
2363 followed by gtk_box_set_homogeneous (Bug#11768).
2364 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
2365 (update_theme_scrollbar_width, xg_create_scroll_bar):
2366 Use gtk_scrollbar_new (Bug#11768).
2367 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
2368 (is_box_type): New function (Bug#11768).
2369 (xg_tool_item_stale_p): Call is_box_type.
2370 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
2371 with default display (Bug#11768).
2373 2012-07-05 Eli Zaretskii <eliz@gnu.org>
2375 * xdisp.c (window_hscroll_limited): New function.
2376 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
2377 coordinates when window's hscroll is set to insanely large
2380 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
2382 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
2383 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
2385 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2388 * lisp.h (xzalloc): New prototype. Omit needless casts.
2389 * alloc.c (xzalloc): New function. Omit needless casts.
2390 * charset.c: Omit needless casts. Convert all calls to
2391 xmalloc with following memset to xzalloc.
2392 * dispnew.c: Likewise.
2393 * fringe.c: Likewise.
2394 * image.c: Likewise.
2395 * sound.c: Likewise.
2397 * w32fns.c: Likewise.
2398 * w32font.c: Likewise.
2399 * w32term.c: Likewise.
2400 * xfaces.c: Likewise.
2402 * xterm.c: Likewise.
2403 * atimer.c: Omit needless casts.
2404 * buffer.c: Likewise.
2405 * callproc.c: Likewise.
2407 * coding.c: Likewise.
2408 * composite.c: Likewise.
2410 * doprnt.c: Likewise.
2411 * editfns.c: Likewise.
2412 * emacs.c: Likewise.
2414 * filelock.c: Likewise.
2416 * gtkutil.c: Likewise.
2417 * keyboard.c: Likewise.
2419 * lread.c: Likewise.
2420 * minibuf.c: Likewise.
2421 * msdos.c: Likewise.
2422 * print.c: Likewise.
2423 * process.c: Likewise.
2424 * region-cache.c: Likewise.
2425 * search.c: Likewise.
2426 * sysdep.c: Likewise.
2427 * termcap.c: Likewise.
2428 * terminal.c: Likewise.
2429 * tparam.c: Likewise.
2430 * w16select.c: Likewise.
2432 * w32reg.c: Likewise.
2433 * w32select.c: Likewise.
2434 * w32uniscribe.c: Likewise.
2435 * widget.c: Likewise.
2436 * xdisp.c: Likewise.
2437 * xmenu.c: Likewise.
2439 * xselect.c: Likewise.
2441 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2443 * fileio.c (time_error_value): Check the right error number.
2444 Problem reported by Troels Nielsen in
2445 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
2447 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2449 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
2450 This should be fixed in a better way; see Eli Zaretskii in
2451 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
2452 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
2454 * fileio.c (time_error_value): Rename from special_mtime.
2455 The old name's problems were noted by Eli Zaretskii in
2456 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
2458 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
2459 This variable's comment says Emacs needs at least one GDB-visible
2460 symbol of type enum pvec_type, to work around GDB problems.
2461 The symbol's value doesn't matter.
2463 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
2464 that causes compilation to fail on pre-C99 compilers.
2466 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
2468 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
2469 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
2471 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2473 * buffer.c (init_buffer_once): Fix initialization of
2474 headers for buffer_defaults and buffer_local_symbols.
2475 Reported by Juanma Barranquero <lekktu@gmail.com>.
2477 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2479 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
2480 * lisp.h (enum pvec_type): Use fewer bits.
2481 (PSEUDOVECTOR_SIZE_BITS): New constant.
2482 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
2483 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
2484 change in pvec_type.
2485 (PSEUDOVECTOR_TYPEP): New macro.
2486 (TYPED_PSEUDOVECTORP): Use it.
2487 * fns.c (internal_equal): Adapt code to extract pvectype.
2488 * emacs.c (gdb_pvec_type): Update type.
2489 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
2490 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
2491 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
2492 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
2493 (sweep_vectors): Use it. Use local var `total_bytes' instead of
2494 abusing vector->header.next.nbytes.
2495 (live_vector_p): Use PVEC_TYPE.
2496 (mark_object): Adapt code to extract pvectype. Use switch.
2498 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2500 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
2501 Tighten new eassert a bit.
2503 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2505 Fix compilation with --enable-gcc-warnings and -O1
2507 * doprnt.c (doprnt): Change type of tem to int, initialize
2508 to avoid compiler warning. Add eassert.
2509 * search.c (simple_search): Initialize match_byte to avoid
2510 compiler warning. Add eassert.
2512 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2514 Avoid weird behavior with large horizontal scrolls.
2515 Without this change, for example, large hscroll values would
2516 mess up Emacs's display on Fedora 15 x86, presumably due to
2517 overflows in int calculations in the display code.
2518 Also, if buffers had long lines, Emacs would freeze.
2519 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
2520 (set_window_hscroll): New function, containing the old guts of
2521 Fset_window_hscroll. Return the clipped value.
2522 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
2523 This avoids the need to check against PTRDIFF_MAX.
2525 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
2527 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2529 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
2531 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2533 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
2534 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
2535 since GCC 4.4.6 issues a bogus warning for them.
2537 Fix bugs in file timestamp newness comparisons.
2538 * fileio.c (Ffile_newer_than_file_p):
2539 * lread.c (Fload): Use full timestamp resolution of files,
2540 not just the 1-second resolution, so that files that are only
2541 slightly newer still count as newer.
2542 * fileio.c (Ffile_newer_than_file_p): Don't assume file
2543 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
2545 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
2547 * fileio.c: Improve handling of file time marker. (Bug#11852)
2548 (special_mtime): New function.
2549 (Finsert_file_contents, Fverify_visited_file_modtime):
2550 Use it to set special mtime values consistently.
2552 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
2554 * fileio.c (Finsert_file_contents): Properly handle st_mtime
2555 marker for non-existing file. (Bug#11852)
2557 2012-07-03 Glenn Morris <rgm@gnu.org>
2559 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
2560 and did not make it into globals.h).
2562 2012-07-03 Tom Tromey <tromey@redhat.com>
2564 * window.c (Fset_window_margins, Fset_window_fringes)
2565 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
2566 * textprop.c (Fprevious_property_change): No longer static.
2567 * syntax.c (Fsyntax_table_p): No longer static.
2568 * process.c (Fget_process, Fprocess_datagram_address): No longer
2570 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
2571 * keyboard.c (Fcommand_execute): No longer static.
2573 * insdel.c (Fcombine_after_change_execute): No longer static.
2574 * image.c (Finit_image_library): No longer static.
2575 * fileio.c (Fmake_symbolic_link): No longer static.
2576 * eval.c (Ffetch_bytecode): No longer static.
2577 * editfns.c (Fuser_full_name): No longer static.
2578 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2580 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2582 * dired.c (Ffile_attributes): No longer static.
2583 * composite.c (Fcomposition_get_gstring): No longer static.
2584 * callproc.c (Fgetenv_internal): No longer static.
2586 * ccl.h: Remove EXFUNs.
2587 * buffer.h: Remove EXFUNs.
2588 * dispextern.h: Remove EXFUNs.
2589 * intervals.h: Remove EXFUNs.
2590 * fontset.h: Remove EXFUN.
2591 * font.h: Remove EXFUNs.
2592 * dosfns.c (system_process_attributes): Remove EXFUN.
2593 * keymap.h: Remove EXFUNs.
2594 * lisp.h: Remove EXFUNs.
2595 * w32term.h: Remove EXFUNs.
2596 * window.h: Remove EXFUNs.
2597 * xsettings.h: Remove EXFUN.
2598 * xterm.h: Remove EXFUN.
2600 2012-07-03 Glenn Morris <rgm@gnu.org>
2602 * lisp.h (Frandom): Make it visible to C.
2603 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2604 buffer for invisible buffers. (Bug#1229)
2606 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2608 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2609 values which aren't power of 2.
2610 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
2611 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
2614 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2616 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2618 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2620 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2622 * alloc.c (allocate_vector_block): Remove redundant
2623 calls to mallopt if DOUG_LEA_MALLOC is defined.
2624 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2625 avoid calls to mallopt if zero_vector is returned.
2627 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2629 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2630 is enabled, avoid dereferencing NULL current_sblock if
2633 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2635 Cleanup basic buffer management.
2636 * buffer.h (struct buffer): Change layout to use generic vector
2637 marking code. Fix some comments. Change type of 'clip_changed'
2638 to bitfield. Remove unused #ifndef old.
2639 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2640 (GET_OVERLAYS_AT): Fix indentation.
2641 (for_each_per_buffer_object_at): New macro.
2642 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2643 (Fbuffer_local_variables): Use it.
2644 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2645 * alloc.c (allocate_buffer): Adjust to match new layout of
2646 struct buffer. Fix comment.
2647 (mark_overlay): New function.
2648 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2649 Lisp area of struct buffer.
2650 (mark_object): Use it. Adjust marking of misc objects
2651 and related comments.
2653 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2655 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2656 wrapper that is not needed because the wrapped code is a no-op (zero
2657 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2658 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2660 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2662 * alloc.c (mark_buffer): Simplify. Remove prototype.
2663 (mark_object): Add comment. Reorganize marking of vector-like
2664 objects. Use CHECK_LIVE for all vector-like objects except buffers
2665 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
2666 redundant calls to mark_vectorlike for bool vectors.
2668 2012-06-30 Glenn Morris <rgm@gnu.org>
2670 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2672 * epaths.in (PATH_SITELOADSEARCH): New.
2673 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2674 This is rather than relying on --enable-locallisppath elements
2675 having "site-lisp" in their names. (Bug#10208#25, 11658)
2677 2012-06-30 Eli Zaretskii <eliz@gnu.org>
2679 * w32proc.c (sys_select): Accept and ignore one more argument.
2681 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2683 * sysselect.h [DOS_NT]: Don't include sys/select.h.
2684 (pselect) [!MS_DOS]: Redirect to sys_select.
2686 * sysdep.c: Don't include dos.h and dosfns.h.
2688 * process.c (sys_select):
2689 * msdos.c (sys_select): Accept one more argument and ignore it.
2691 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2692 adapt data types and code to that.
2695 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2696 which clashes with the gnulib function of the same name.
2698 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2700 * font.c (font_style_to_value, font_style_symbolic)
2701 (font_prop_validate_style): Add type checks for values in
2704 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2706 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2709 2012-06-29 Eli Zaretskii <eliz@gnu.org>
2711 * xdisp.c (try_window_id): Undo last change.
2713 * w32.c (getwd): Adjust commentary about startup_dir.
2714 (init_environment): Always call sys_access, even in non-MSVC
2715 builds. Don't chdir to the directory of the Emacs executable.
2716 This undoes code from 1997 which was justified by the need to
2717 "avoid conflicts when removing and renaming directories". But its
2718 downside was that every relative file name was being interpreted
2719 relative to the directory of the Emacs executable, which can never
2720 be TRT. In particular, it broke sys_access when called with
2721 relative file names.
2722 (sys_access): Map GetLastError to errno.
2724 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2726 * window.h (struct window): Change type of 'fringes_outside_margins'
2727 to bitfield. Fix comment. Adjust users accordingly.
2728 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2730 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2733 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
2735 * gnutls.c (emacs_gnutls_handshake):
2736 Add QUIT to make the loop interruptible.
2738 2012-06-29 Glenn Morris <rgm@gnu.org>
2740 * charset.c (init_charset): Make lack of etc/charsets fatal.
2742 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2744 * editfns.c (region_limit): Fix type mismatch.
2746 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2748 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2749 undefined. Convert from xassert to eassert.
2750 * nsmenu.m: Convert from xassert to eassert.
2751 * nsterm.m: Likewise.
2753 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2755 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2757 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2759 Avoid integer overflow on scroll-left and scroll-right.
2760 * window.c (HSCROLL_MAX): New macro.
2761 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2762 overflow when requested scroll falls outside ptrdiff_t range.
2764 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2766 * window.h (struct window): Change type of 'hscroll',
2767 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2768 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2769 Adjust users accordingly.
2770 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2771 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2772 from EMACS_INT to ptrdiff_t.
2773 (make_window): Omit redundant initialization.
2775 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
2777 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2779 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2781 * window.h (struct window): Change type of 'use_time' and
2782 'sequence_number' from Lisp_Object to int.
2783 * frame.c (make_frame): Adjust users accordingly.
2784 * print.c (print_object): Likewise.
2785 * window.c (select_window, Fwindow_use_time, make_parent_window)
2786 (make_window): Likewise.
2788 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2790 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2791 enabled with --enable-checking=[all,glyphs] configure option.
2792 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2793 adjust comments accordingly.
2794 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2795 undefined, adjust comments accordingly.
2796 * image.c: Likewise.
2797 * scroll.c: Likewise.
2798 * w32fns.c: Likewise.
2799 * w32term.c: Likewise.
2800 * xdisp.c: Likewise.
2801 * xfaces.c: Likewise.
2803 * xterm.c: Likewise.
2805 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2807 Generalize run-time debugging checks.
2808 * dispextern.h (XASSERTS): Remove.
2809 * fontset.c (xassert): Remove.
2810 Convert from xassert to eassert.
2811 * alloc.c: Convert from xassert to eassert.
2813 * dispnew.c: Likewise.
2815 * fringe.c: Likewise.
2816 * ftfont.c: Likewise.
2817 * gtkutil.c: Likewise.
2818 * image.c: Likewise.
2819 * keyboard.c: Likewise.
2821 * process.c: Likewise.
2822 * scroll.c: Likewise.
2823 * sound.c: Likewise.
2825 * w32console.c: Likewise.
2826 * w32fns.c: Likewise.
2827 * w32term.c: Likewise.
2828 * window.c: Likewise.
2829 * xdisp.c: Likewise.
2830 * xfaces.c: Likewise.
2832 * xselect.c: Likewise.
2833 * xterm.c: Likewise.
2835 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2837 * fns.c (maybe_resize_hash_table): Output message when growing the
2840 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2842 * alloc.c (allocate_string_data): Remove dead code.
2843 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2844 avoid GCC warning about unused macro.
2846 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2848 * alloc.c (allocate_string): Omit intervals initialization.
2849 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2850 as in make_pure_string and make_pure_c_string.
2852 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2854 * alloc.c (allocate_string): Fix last change.
2856 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2858 * alloc.c (allocate_string): Remove two redundant calls
2859 to memset, add explicit initialization where appropriate.
2861 2012-06-27 Glenn Morris <rgm@gnu.org>
2863 * lisp.mk (lisp): Remove paths.elc.
2865 2012-06-27 Chong Yidong <cyd@gnu.org>
2867 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2869 2012-06-26 John Wiegley <johnw@newartisans.com>
2871 * unexmacosx.c (copy_data_segment): Add two section names used
2872 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2874 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2875 when building with Clang.
2877 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2879 * eval.c (Fapply): Allow calling it with a single argument.
2881 2012-06-26 Eli Zaretskii <eliz@gnu.org>
2883 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2884 _stricmp and _strnicmp.
2885 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2887 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2889 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2891 (allocate_process): Likewise for new process.
2892 (allocate_terminal): Change to use offsetof.
2893 (allocate_frame): Likewise.
2894 * frame.c (make_frame): Omit redundant initialization.
2895 * window.c (make_parent_window): Use memset.
2896 (make_window): Omit redundant initialization.
2897 * process.c (make_process): Omit redundant initialization.
2898 * terminal.c (create_terminal): Likewise.
2900 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2902 * term.c (delete_tty): Remove redundant call to memset.
2904 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2906 * alloc.c: Remove build_string.
2907 * lisp.h: Define build_string as static inline. This provides
2908 a better opportunity to optimize away calls to strlen when the
2909 function is called with compile-time constant argument.
2910 * image.c (imagemagick_error): Convert to build_string.
2911 * w32proc.c (sys_spawnve): Likewise.
2912 * xterm.c (x_term_init): Likewise.
2914 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2916 Use sprintf return value instead of invoking strlen on result.
2917 In the old days this wasn't portable, since some sprintf
2918 implementations returned char *. But they died out years ago and
2919 Emacs already assumes sprintf returns int.
2920 Similarly for float_to_string.
2921 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2922 * ccl.c (ccl_driver):
2923 * character.c (string_escape_byte8):
2924 * data.c (Fnumber_to_string):
2925 * doprnt.c (doprnt):
2926 * print.c (print_object):
2927 * xdisp.c (message_dolog):
2928 * xfns.c (syms_of_xfns):
2929 Use sprintf or float_to_string result to avoid need to call strlen.
2930 * data.c (Fnumber_to_string):
2931 Use make_unibyte_string, since the string must be ASCII.
2932 * lisp.h, print.c (float_to_string): Now returns int length.
2933 * term.c (produce_glyphless_glyph):
2934 Use sprintf result rather than recomputing it.
2936 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2937 * Makefile.in (ALL_CFLAGS):
2938 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2939 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2941 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2943 * dispextern.h (xstrcasecmp): Define to library function
2944 strcasecmp if available.
2945 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2947 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2949 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2950 Avoid comma operator.
2951 * menu.c (push_submenu_start, push_submenu_end)
2952 (push_left_right_boundary, push_menu_pane): Likewise.
2953 * msdos.c (dos_rawgetc): Likewise.
2955 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2957 * xfns.c (xic_create_fontsetname): Remove redundant calls
2960 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2962 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2963 sprintf already null-terminates its output.
2965 * xfns.c (x_window): Remove redundant cast.
2967 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2969 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2970 `const char *' to `char *' to avoid compiler warning.
2972 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2974 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2975 instead of truncating it to 63 (admittedly a generous limit).
2977 * process.c: Fix spelling and caps in comments.
2979 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2981 * emacs.c (setpgrp): Remove definition, unused.
2982 * sysdep.c (setpgrp): Remove definition, not used in this file.
2984 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
2986 * makefile.w32-in: Update dependencies.
2988 2012-06-24 Eli Zaretskii <eliz@gnu.org>
2990 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2991 (SYSTIME_H): Add nt/inc/sys/time.h.
2993 * systime.h [WINDOWSNT]: Include sys/time.h.
2995 * s/ms-w32.h (struct timespec): Definition moved from
2996 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2998 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3000 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
3001 * buffer.h (buffer_slot_type_mismatch):
3002 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
3003 * eval.c (unwind_to_catch):
3004 * image.c (my_png_error, my_error_exit):
3005 * keyboard.c (quit_throw_to_read_char, user_error)
3006 (Fexit_recursive_edit, Fabort_recursive_edit):
3007 * lisp.h (die, args_out_of_range, args_out_of_range_3)
3008 (wrong_type_argument, buffer_overflow, __executable_start)
3009 (memory_full, buffer_memory_full, string_overflow, Fthrow)
3010 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
3011 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
3013 (child_setup) [!DOS_NT]:
3014 * lread.c (end_of_file_error, invalid_syntax):
3015 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
3016 * puresize.h (pure_write_error):
3017 * search.c (matcher_overflow):
3018 * sound.c (sound_perror, alsa_sound_perror):
3019 * sysdep.c, syssignal.h (croak):
3020 * term.c (maybe_fatal, vfatal):
3021 * textprop.c (text_read_only):
3022 * undo.c (user_error):
3023 * unexmacosx.c (unexec_error):
3024 * xterm.c (x_ins_del_lines, x_delete_glyphs):
3025 Use _Noreturn rather than NO_RETURN.
3026 No need for separate decl merely because of _Noreturn.
3027 * sound.c (sound_warning, parse_sound):
3028 Remove unnecessary forward decls.
3030 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3032 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
3033 * lisp.h (WAIT_READING_MAX): New macro.
3034 * dispnew.c (Fsleep_for, sit_for):
3035 * keyboard.c (kbd_buffer_get_event):
3036 * process.c (Faccept_process_output):
3037 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
3038 This improves on the previous patch, which introduced a bug
3039 when time_t is unsigned and as wide as intmax_t.
3040 See <http://bugs.gnu.org/9000#51>.
3042 2012-06-23 Eli Zaretskii <eliz@gnu.org>
3044 * dispnew.c (sit_for, Fsleep_for):
3045 * keyboard.c (kbd_buffer_get_event):
3046 * process.c (Faccept_process_output): Avoid compiler warnings when
3047 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
3049 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
3051 * makefile.w32-in: Update dependencies.
3053 * w32.c (ltime): Add return type and declare static.
3054 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
3056 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
3058 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
3059 Privately reported by Herbert J. Skuhra.
3060 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
3062 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
3063 not make_lisp_timeval, when the argument is of type EMACS_TIME.
3065 2012-06-23 Eli Zaretskii <eliz@gnu.org>
3067 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
3068 last argument of make_unibyte_string.
3070 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
3071 language ID in the event parameters.
3073 * w32term.c (w32_read_socket): Put the new keyboard codepage into
3074 event.code, not the obscure "character set ID".
3076 2012-06-23 Chong Yidong <cyd@gnu.org>
3078 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
3080 2012-06-23 Eli Zaretskii <eliz@gnu.org>
3082 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
3083 * w32.c (fdutimens): New function.
3085 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
3087 * s/ms-w32.h (pselect): Redirect to sys_select.
3089 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
3091 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
3092 in the logic of incrementing and decrementing the value of
3093 use_relocatable_buffers.
3095 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
3097 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
3098 Privately reported by Herbert J. Skuhra.
3099 [__FreeBSD__]: Remove "*/" typo after "#include".
3100 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
3101 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
3102 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
3103 Don't assume EMACS_TIME and struct timeval are the same type.
3105 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
3107 Support higher-resolution time stamps (Bug#9000).
3108 The time stamps are only nanosecond-resolution at the C level,
3109 since that's the best that any real-world system supports now.
3110 But they are picosecond-resolution at the Lisp level, as that's
3111 easy, and leaves room for future OS improvements.
3113 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
3116 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
3117 Don't get current time unless it's needed.
3119 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
3120 now provides it if it's absent.
3121 (start_atimer): Port to higher-res time stamps.
3122 Check for time stamp overflow. Don't get current time more
3123 often than is needed.
3125 * buffer.h (struct buffer): Buffer modtime now has high resolution.
3126 Include systime.h, not time.h.
3127 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
3129 * dired.c: Include stat-time.h.
3130 (Ffile-attributes): File times now have higher resolution.
3132 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
3133 (struct image): Timestamp now has higher resolution.
3135 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
3136 has at least microseconds now. All uses removed.
3137 (update_frame, update_single_window, update_window, update_frame_1)
3138 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
3140 * editfns.c (time_overflow): Now extern.
3141 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
3142 (float-time, Fformat_time_string, Fcurrent_time_string)
3143 (Fcurrent_time_zone): Accept and generate higher-resolution
3145 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
3146 (decode_time_components, lisp_seconds_argument): New functions.
3147 (make_time): Now static.
3148 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
3149 Report an error if the time is invalid, rather than having the caller
3152 * fileio.c: Include <stat-time.h>
3153 (Fcopy_file): Copy higher-resolution time stamps.
3154 Prefer to set the time stamp via a file descriptor if that works.
3155 (Fset_file_times, Finsert_file_contents, Fwrite_region)
3156 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
3157 (Fvisited_file_modtime, Fset_visited_file_modtime):
3158 Support higher-resolution time stamps.
3160 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
3162 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
3164 * image.c (prepare_image_for_display, clear_image_cache)
3165 (lookup_image): Port to higer-resolution time stamps.
3167 * keyboard.c (start_polling, bind_polling_period):
3168 Check for time stamp overflow.
3169 (read_char, kbd_buffer_get_event, timer_start_idle)
3170 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
3171 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
3172 Port to higher-resolution time stamps. Do not assume time_t is signed.
3173 (decode_timer): New function. Timers are now vectors of length 9,
3174 not 8, to accommodate the picosecond component.
3175 (timer_check_2): Use it.
3177 * nsterm.m (select_timeout, timeval_subtract): Remove.
3178 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
3179 as they're a bit more accurate and handle overflow better.
3180 (ns_select): Change prototype to be compatible with pselect.
3181 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
3182 * nsterm.h (ns_select): Adjust prototype.
3184 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
3185 us-resolution time stamps.
3186 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
3188 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
3190 * lisp.h (time_overflow): New decl.
3191 (wait_reading_process_output): First arg is now intmax_t, not int,
3192 to accommodate larger waits.
3194 * process.h (struct Lisp_Process.read_output_delay):
3195 Now counts nanoseconds, not microseconds.
3196 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
3198 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
3199 (wait_reading_process_output):
3200 Port to ns-resolution time stamps.
3201 (Faccept_process_output, wait_reading_process_output):
3202 Check for time stamp overflow. Do not assume time_t is signed.
3203 (select_wrapper): Remove; we now use pselect.
3204 (Fprocess_attributes): Now generates ns-resolution time stamps.
3206 * sysdep.c: Include utimens.h. Don't include utime.h
3207 or worry about struct utimbuf; gnulib does that for us now.
3208 (gettimeofday): Remove; gnulib provides a substitute.
3209 (make_timeval): New function.
3210 (set_file_times): Now sets ns-resolution time stamps.
3211 New arg FD; all uses changed.
3212 (time_from_jiffies, ltime_from_jiffies, get_up_time)
3213 (system_process_attributes):
3214 Now returns ns-resolution time stamp. All uses changed.
3215 Check for time stamp overflow.
3217 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
3218 provides a substitute now.
3220 * systime.h: Include timespec.h rather than sys/time.h and time.h,
3221 since it guarantees struct timespec.
3222 (EMACS_TIME): Now struct timespec, so that we can support
3223 ns-resolution time stamps.
3224 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
3225 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
3226 (EMACS_USECS): Remove.
3227 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
3228 so multiply the arg by 1000 before storing it.
3229 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
3231 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
3232 Port to ns-resolution time stamps.
3233 (EMACS_TIME_NEG_P): Remove; replaced by....
3234 (EMACS_TIME_SIGN): New macro.
3235 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
3236 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
3237 (set_file_times, make_time, lisp_time_argument): Adjust signature.
3238 (make_timeval, make_lisp_time, decode_time_components): New decls.
3239 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
3240 that it mishandled time_t overflow. You can't compare by subtracting!
3241 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
3242 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
3244 * term.c: Include <sys/time.h>.
3245 (timeval_to_Time): New function, for proper overflow wraparound.
3246 (term_mouse_position, term_mouse_click): Use it.
3248 * undo.c (record_first_change): Support higher-resolution time stamps
3250 (Fprimitive_undo): Use them when restoring time stamps.
3252 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
3253 (w32_get_internal_run_time):
3254 Port to higher-resolution Emacs time stamps.
3255 (ltime): Now accepts single 64-bit integer, as that's more convenient
3258 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
3260 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
3261 for compatibility with pselect. Support ns-resolution time stamps.
3263 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
3265 * xselect.c (wait_for_property_change, x_get_foreign_selection):
3266 Check for time stamp overflow, and support ns-resolution time stamps.
3268 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
3269 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
3270 (timeval_subtract): Remove; no longer needed.
3271 (XTflash, XTring_bell, x_wait_for_event):
3272 Port to ns-resolution time stamps. Don't assume time_t is signed.
3274 2012-06-22 Chong Yidong <cyd@gnu.org>
3276 * xdisp.c (x_consider_frame_title): Revert last change.
3278 2012-06-22 Eli Zaretskii <eliz@gnu.org>
3280 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
3281 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
3282 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
3283 staticidx goes up to 1597 out of 1600 = 0x640.)
3285 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
3287 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
3288 Otherwise, the umask might be mistakenly 0 while handling input signals.
3290 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
3292 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
3294 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
3296 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
3297 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
3298 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
3299 access to `contents' member of Lisp_Vector objects with AREF and ASET
3302 2012-06-19 Chong Yidong <cyd@gnu.org>
3304 * frame.c (delete_frame): When selecting a frame on a different
3305 text terminal, do not alter the terminal's top-frame.
3307 * xdisp.c (format_mode_line_unwind_data): Record the target
3308 frame's selected window and its terminal's top-frame.
3309 (unwind_format_mode_line): Restore them.
3310 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
3312 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
3313 since tty frames can be explicitly named.
3314 (prepare_menu_bars): Likewise.
3316 * term.c (Ftty_top_frame): New function.
3318 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3320 Port byte-code-meter to modern targets.
3321 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
3322 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
3323 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
3324 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
3325 (METER_1, METER_2): Simplify.
3327 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
3329 * data.c (Fdefalias): Return `symbol' (bug#11686).
3331 2012-06-18 Martin Rudalics <rudalics@gmx.at>
3333 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
3334 gets killed during executing of this function (Bug#11665).
3335 Try to always return Qt when the buffer has been actually killed.
3336 (Vkill_buffer_query_functions): In doc-string say that functions
3337 run by this hook should not change the current buffer.
3339 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3341 Fix recently-introduced process.c problems found by static checking.
3342 * process.c (write_queue_push, write_queue_pop, send_process):
3343 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
3344 (write_queue_pop): Fix pointer signedness problem.
3345 (send_process): Remove unused local.
3347 2012-06-17 Chong Yidong <cyd@gnu.org>
3349 * xdisp.c (redisplay_internal): No need to redisplay terminal
3350 frames that are not on top.
3352 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
3354 * process.c (make_process): Initialize write_queue.
3355 (write_queue_push, write_queue_pop): New functions.
3356 (send_process): Use them to maintain correct ordering of process
3359 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
3361 * lisp.h (eassert): Assume C89 or later.
3362 This removes the need for CHECK.
3363 (CHECK): Remove. Its comments about always evaluating its
3364 argument were confusing, as 'eassert' typically does not evaluate
3367 * coding.c (produce_chars): Use ptrdiff_t, not int.
3369 * xterm.c (x_draw_underwave): Check for integer overflow.
3370 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
3372 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
3374 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
3375 referenced (Bug#11583).
3377 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
3379 Implement wave-style variant of underlining.
3380 * dispextern.h (face_underline_type): New enum.
3381 (face): Add field for underline type.
3382 * nsterm.m (ns_draw_underwave): New function.
3383 (ns_draw_text_decoration): Use it.
3384 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
3386 (x_draw_glyph_string): Use them.
3387 * xfaces.c (Qline, Qwave): New Lisp objects.
3388 (check_lface_attrs, merge_face_ref)
3389 (Finternal_set_lisp_face_attribute, realize_x_face):
3390 Handle wave-style underline face attributes.
3391 * xterm.c (x_draw_underwave): New function.
3392 (x_draw_glyph_string): Use it.
3394 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
3396 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
3397 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
3398 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
3399 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
3400 ($(BLD)/w32select.$(O)): Update dependencies.
3402 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3404 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
3405 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
3406 * character.c (_fetch_multibyte_char_p): Remove.
3407 * alloc.c: Include "character.h" before "buffer.h".
3409 * buffer.c: Likewise.
3410 * bytecode.c: Likewise.
3411 * callint.c: Likewise.
3412 * callproc.c: Likewise.
3413 * casefiddle.c: Likewise.
3414 * casetab.c: Likewise.
3415 * category.c: Likewise.
3417 * coding.c: Likewise.
3418 * composite.c: Likewise.
3419 * dired.c: Likewise.
3420 * dispnew.c: Likewise.
3422 * dosfns.c: Likewise.
3423 * editfns.c: Likewise.
3424 * emacs.c: Likewise.
3425 * fileio.c: Likewise.
3426 * filelock.c: Likewise.
3428 * fontset.c: Likewise.
3429 * fringe.c: Likewise.
3430 * indent.c: Likewise.
3431 * insdel.c: Likewise.
3432 * intervals.c: Likewise.
3433 * keyboard.c: Likewise.
3434 * keymap.c: Likewise.
3435 * lread.c: Likewise.
3436 * macros.c: Likewise.
3437 * marker.c: Likewise.
3438 * minibuf.c: Likewise.
3439 * nsfns.m: Likewise.
3440 * nsmenu.m: Likewise.
3441 * print.c: Likewise.
3442 * process.c: Likewise.
3443 * regex.c: Likewise.
3444 * region-cache.c: Likewise.
3445 * search.c: Likewise.
3446 * syntax.c: Likewise.
3448 * textprop.c: Likewise.
3450 * unexsol.c: Likewise.
3451 * w16select.c: Likewise.
3452 * w32fns.c: Likewise.
3453 * w32menu.c: Likewise.
3454 * window.c: Likewise.
3455 * xdisp.c: Likewise.
3457 * xmenu.c: Likewise.
3459 * xselect.c: Likewise.
3461 2012-06-16 Eli Zaretskii <eliz@gnu.org>
3463 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
3464 If all the glyphs of the glyph row came from strings, and we have no
3465 cursor positioning clues, put the cursor on the first glyph of the
3467 (handle_face_prop): Use chunk-relative overlay string index when
3468 indexing into it->string_overlays array. (Bug#11653)
3469 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
3470 the rightmost. (Bug#11720)
3472 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3474 * category.h (CHAR_HAS_CATEGORY): Define as inline.
3475 (CATEGORY_MEMBER): Enforce 1/0 value.
3476 * category.c (_temp_category_set): Remove.
3478 2012-06-16 Eli Zaretskii <eliz@gnu.org>
3480 * window.c (Fdelete_other_windows_internal)
3481 (Fdelete_window_internal): Don't access frame's mouse highlight
3482 info of the initial frame. (Bug#11677)
3484 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
3486 * .gdbinit (xgetint): Fix recently-introduced paren typo.
3487 Assume USE_2_TAGS_FOR_INTS.
3488 (xreload): Adjust $tagmask width to match recent lisp.h change.
3490 Simplify lisp.h in minor ways that should not affect code.
3491 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
3492 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
3493 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
3494 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
3495 (INTTYPEBITS): New macro, for clarity.
3496 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
3497 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
3498 Simplify now that USE_LSB_TAG is always defined.
3499 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
3500 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
3502 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
3504 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
3506 2012-06-13 Glenn Morris <rgm@gnu.org>
3508 * s/bsd-common.h (BSD4_3):
3509 * s/usg5-4-common.h (USG5_4): No longer define; unused.
3511 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
3513 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
3516 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
3518 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
3519 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
3520 * alloc.c (widen_to_Lisp_Object): Remove.
3521 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
3522 * frame.c (delete_frame): Remove outdated comment.
3523 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
3524 USE_LISP_UNION_TYPE.
3525 (Fw32_unregister_hot_key): Likewise.
3526 (Fw32_toggle_lock_key): Likewise.
3527 * w32menu.c (add_menu_item): Likewise.
3528 (w32_menu_display_help): Use XIL instead of checking
3529 USE_LISP_UNION_TYPE.
3530 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
3531 (init_heap): Likewise.
3532 * w32term.c (w32_read_socket): Update comment.
3534 2012-06-13 Glenn Morris <rgm@gnu.org>
3536 * s/usg5-4-common.h, src/s/unixware.h:
3537 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
3539 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
3541 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
3543 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
3544 * alloc.c (make_number) [!defined make_number]:
3545 Remove, as lisp.h always defines this now.
3546 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
3547 (roundup_size): Verify that it is a power of 2.
3548 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
3549 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
3550 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
3551 -DUSE_LSB_TAG=0, to override the automatically-selected default.
3552 USE_LSB_TAG now is always defined to be either 0 or 1.
3554 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
3555 code works fine either way, and efficiency is not a concern here,
3556 as the union type is for debugging, not for production.
3557 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
3558 Use an inline function on all platforms when using the union type,
3559 since this is simpler and 'static inline' can be used portably
3561 (LISP_INITIALLY_ZERO): New macro.
3562 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
3563 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
3565 2012-06-12 Glenn Morris <rgm@gnu.org>
3567 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
3569 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
3571 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
3572 Move BROKEN_SIGIO to configure.
3574 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3575 Move NO_TERMIO to configure.
3577 2012-06-12 Chong Yidong <cyd@gnu.org>
3579 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3580 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3581 MagickExportImagePixels is undefined.
3583 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3585 * image.c (imagemagick_load_image): Remove unused label.
3587 2012-06-11 Glenn Morris <rgm@gnu.org>
3589 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3590 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3591 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3592 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3594 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3596 * alloc.c (make_byte_code): New function.
3597 (Fmake_byte_code): Use it. Don't purify here.
3598 * lread.c (read1): Use it as well to avoid extra allocation.
3600 2012-06-11 Chong Yidong <cyd@gnu.org>
3602 * image.c (imagemagick_load_image): Implement transparency.
3604 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3606 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3607 account for preceding backslashes. (Bug#11663)
3609 2012-06-09 Chong Yidong <cyd@gnu.org>
3611 * term.c: Support italics in capable terminals (Bug#9652).
3612 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3613 (turn_on_face): Output using TS_enter_italic_mode if available.
3614 Don't handle unused blinking and alt-charset cases.
3615 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3616 and tty_alt_charset_p cases.
3617 (tty_capable_p, init_tty): Support italics.
3619 * termchar.h (struct tty_display_info): Add field for italics.
3620 Remove unused blink field.
3622 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3625 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3626 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3627 tty_alt_charset_p. Add tty_italic_p.
3629 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
3631 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3632 dbus_type_is_basic if available.
3633 (xd_extract_signed, xd_extract_unsigned): Rename from
3634 extract_signed and extract_unsigned, respectively. Adapt callers.
3636 2012-06-09 Chong Yidong <cyd@gnu.org>
3638 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3640 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3643 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3645 * xdisp.c (vmessage): Treat frame message as multibyte.
3646 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3647 would generate the diagnostic "Making \302\247 buffer-local while
3650 2012-06-08 Eli Zaretskii <eliz@gnu.org>
3652 * dispnew.c (showing_window_margins_p): Undo last change, which
3653 was done due to an inadvertent commit.
3654 (adjust_frame_glyphs_for_frame_redisplay): Do call
3655 showing_window_margins_p.
3657 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3659 * eval.c (Fmake_var_non_special): New primitive.
3660 (syms_of_eval): Defsubr it.
3661 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3663 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
3665 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3666 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3668 2012-06-08 Eli Zaretskii <eliz@gnu.org>
3670 * alloc.c (allocate_vectorlike): Fix last change.
3672 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3674 Block-based vector allocation of small vectors.
3675 * lisp.h (struct vectorlike_header): New field `nbytes',
3676 adjust comment accordingly.
3677 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3678 to denote vector blocks. Adjust users (live_vector_p,
3679 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3680 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3681 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3682 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3683 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3684 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3685 (roundup_size): New constant.
3686 (struct vector_block): New data type.
3687 (vector_blocks, vector_free_lists, zero_vector): New variables.
3688 (all_vectors): Rename to `large_vectors'.
3689 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3690 (sweep_vectors): New functions.
3691 (allocate_vectorlike): Return `zero_vector' as the only vector of
3692 0 items. Allocate new vector from block if vector size is less than
3693 or equal to VBLOCK_BYTES_MAX.
3694 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3695 (init_alloc_once): Add call to init_vectors.
3697 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3699 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3701 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3703 * doprnt.c (doprnt): Truncate multibyte char correctly.
3704 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3705 would mishandle a string argument "Xc" if X was a multibyte
3706 character of length 2: it would truncate after X's first byte
3707 rather than including all of X.
3709 2012-06-06 Chong Yidong <cyd@gnu.org>
3711 * buffer.c (word_wrap): Doc fix.
3713 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3715 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3717 2012-06-03 Glenn Morris <rgm@gnu.org>
3719 * xdisp.c (tool-bar-style): Doc fix.
3721 2012-06-03 Ulrich Müller <ulm@gentoo.org>
3723 * Makefile.in (PAXCTL): Define.
3724 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3725 binary via PaX flags if the paxctl utility is available.
3726 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3727 Restore PaX flags to their default. (Bug#11398)
3729 2012-06-03 Chong Yidong <cyd@gnu.org>
3731 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3734 2012-06-03 Chong Yidong <cyd@gnu.org>
3736 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3737 (note_mode_line_or_margin_highlight): If there is no help echo,
3738 use mode-line-default-help-echo. Handle the case where the mouse
3739 position is past the end of the mode line string.
3741 * buffer.c (buffer_local_value_1): New function, split from
3742 Fbuffer_local_value; can return Qunbound.
3743 (Fbuffer_local_value): Use it.
3744 (Vmode_line_format): Docstring tweaks.
3746 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3748 * sysdep.c (system_process_attributes): Improve comment.
3750 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3752 * keyboard.c: Export real-this-command to Elisp.
3753 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3754 and DEFVAR it. Update all users.
3756 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3758 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3760 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3761 Convert pctcpu and pctmem to Lisp float properly.
3762 Let the compiler fold better, as 100.0/0x8000 is exact.
3764 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3766 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3769 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3771 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3773 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3775 For a 'struct window', replace some Lisp_Object fields to
3776 bitfields where appropriate, remove unused fields.
3777 * window.h (struct window): Remove unused 'last_mark_x' and
3778 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3779 change it's type from Lisp_Object to bitfield.
3780 Change type of 'force_start', 'optional_new_start',
3781 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3782 fields from Lisp_Object to bitfield. Adjust users accordingly.
3784 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3786 Pacify gcc -Wdouble-precision when using Xaw.
3787 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3788 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3789 Use 'float' consistently, rather than 'float' in most places
3790 and 'double' in a couple of places.
3792 2012-05-31 Eli Zaretskii <eliz@gnu.org>
3794 * xdisp.c (handle_stop): Detect whether we have overlay strings
3795 loaded by testing it->current.overlay_string_index to be
3796 non-negative, instead of checking whether n_overlay_strings is
3797 positive. (Bug#11587)
3799 2012-05-31 Chong Yidong <cyd@gnu.org>
3801 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3803 * doc.c (Fsubstitute_command_keys): Doc fix.
3805 2012-05-31 Eli Zaretskii <eliz@gnu.org>
3807 * search.c (search_buffer): Remove calls to
3808 r_alloc_inhibit_buffer_relocation, as it is now called by
3809 maybe_unify_char, which was the cause of relocation of buffer text
3812 2012-05-31 Eli Zaretskii <eliz@gnu.org>
3814 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3815 for the duration of call to load_charset, to avoid problems with
3816 callers of maybe_unify_char that access buffer text through C
3819 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3820 decrement the inhibition flag, instead of just setting or
3823 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3825 Remove obsolete '#define static' cruft.
3826 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3827 This #undef was "temporary" in 2000; it is no longer needed
3828 now that '#define static' has gone away.
3829 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3830 (gray_bitmap_bits): Remove; no longer needed.
3831 All uses replaced with definiens.
3832 * xterm.c: Include "bitmaps/gray.xbm".
3834 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3836 Clean up __executable_start, monstartup when --enable-profiling.
3837 The following changes affect the code only when profiling.
3838 * dispnew.c (__executable_start): Rename from safe_bcopy.
3839 Define only on platforms that need it.
3840 * emacs.c: Include <sys/gmon.h> when profiling.
3841 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3842 (__executable_start): Remove decl, since lisp.h does it now.
3843 (safe_bcopy): Remove decl; no longer has that name.
3844 (main): Coalesce #if into single bit of code, for simplicity.
3845 Cast pointers to uintptr_t, since standard libraries want integers
3847 * lisp.h (__executable_start): New decl.
3849 2012-05-31 Glenn Morris <rgm@gnu.org>
3851 * image.c (Fimagemagick_types): Doc fix.
3853 2012-05-30 Jim Meyering <meyering@redhat.com>
3855 * callproc.c (Fcall_process_region): Include directory component
3856 in mkstemp error message (Bug#11586).
3858 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3860 * alloc.c, lisp.h (make_pure_vector): Now static.
3862 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3864 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3865 Move to byte-run.el.
3866 (Fautoload): Do the hash-doc more carefully.
3867 * data.c (Fdefalias): Purify definition, except for keymaps.
3868 (Qdefun): Move from eval.c.
3869 * lisp.h (Qdefun): Remove.
3870 * lread.c (read1): Tiny simplification.
3872 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
3874 Do not create empty overlays with the evaporate property (Bug#9642).
3875 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3876 Bug#9642, but explicitly check that the buffer the overlay would
3877 be moved to is live and rearrange lines to make sure that errors
3878 will not put the overlay in an inconsistent state.
3879 (Fdelete_overlay): Cosmetics.
3881 2012-05-28 Eli Zaretskii <eliz@gnu.org>
3883 * w32term.c (my_bring_window_to_top): New function.
3884 (x_raise_frame): Use handle returned by DeferWindowPos, which
3885 could be different from the original one.
3886 Call my_bring_window_to_top instead of my_set_foreground_window.
3889 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3890 by calling BringWindowToTop.
3892 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3893 (WM_EMACS_END): Increase by one.
3895 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3897 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3898 This avoids undefined behavior that might cause the eassert
3899 to not catch an out-of-range value.
3901 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
3903 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3904 Update dependencies.
3906 2012-05-27 Eli Zaretskii <eliz@gnu.org>
3908 * bidi.c (bidi_mirror_char): Fix last change.
3910 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3912 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3913 when referring to sectname field in printf format.
3915 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3917 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3918 Only r_alloc_inhibit_buffer_relocation needed to be added;
3919 the others were already declared.
3921 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3922 before checking whether it's out of range. Put the check inside
3924 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3926 2012-05-27 Ken Brown <kbrown@cornell.edu>
3928 * callproc.c (Fcall_process): Restore a line that was accidentally
3929 commented out in the 2011-02-13 change (bug#11547).
3931 2012-05-27 Eli Zaretskii <eliz@gnu.org>
3933 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3934 defined on ralloc.c.
3936 * buffer.c [REL_ALLOC]: Remove prototypes of
3937 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3938 they are now on lisp.h.
3940 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3942 * search.c (search_buffer): Use it to inhibit relocation of buffer
3943 text while re_search_2 is doing its job, because re_search_2 is
3944 passed C pointers to buffer text. (Bug#11519)
3946 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3949 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3950 state after an additional call to move_it_in_display_line_to, keep
3951 the values of it->max_ascent and it->max_descent found for the
3953 (pos_visible_p): Revert the comparison against bottom_y to what it
3954 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3957 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3959 Fix coding-related core dumps with gcc -ftrapv.
3960 The code was computing A - B, where A and B are pointers, and B is
3961 random garbage. This can lead to core dumps on platforms that
3962 have special pointer registers, and it also leads to core dumps on
3963 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3964 A - B only when B is initialized properly.
3965 * coding.c (coding_set_source, coding_set_destination): Return void.
3966 (coding_change_source, coding_change_destinations): New functions,
3967 with the old behaviors of coding_set_source and coding_set_destination.
3968 All callers that need an offset changed to use these new functions.
3970 2012-05-26 Glenn Morris <rgm@gnu.org>
3972 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3974 2012-05-26 Eli Zaretskii <eliz@gnu.org>
3976 Extend mouse support on W32 text-mode console.
3977 * xdisp.c (draw_row_with_mouse_face):
3978 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
3980 * w32console.c: Include window.h.
3981 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3983 (initialize_w32_display): Initialize mouse-highlight data.
3985 * w32inevt.c: Include termchar.h and window.h.
3986 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3987 moves, call note_mouse_highlight. If help_echo changed, call
3988 gen_help_event to produce help-echo message in the echo area.
3989 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3992 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3994 * lread.c (read1): Simplify slightly to avoid an overflow warning
3995 with GCC 4.7.0 on x86-64.
3997 2012-05-26 Eli Zaretskii <eliz@gnu.org>
3999 * bidi.c (bidi_mirror_char): Revert last change: an int is
4000 definitely wide enough here.
4002 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
4004 Fix integer width and related bugs (Bug#9874).
4005 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
4006 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
4007 (string_bytes, check_sblock, allocate_string_data):
4008 (compact_small_strings, Fmake_bool_vector, make_string)
4009 (make_unibyte_string, make_multibyte_string)
4010 (make_string_from_bytes, make_specified_string)
4011 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
4012 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
4014 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4015 (allocate_pseudovector):
4016 Use int, not EMACS_INT, where int is wide enough.
4017 (inhibit_garbage_collection, Fgarbage_collect):
4018 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4019 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
4020 int might not be wide enough.
4021 (bidi_cache_search, bidi_cache_find, bidi_init_it)
4022 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
4023 (bidi_at_paragraph_end, bidi_find_paragraph_start)
4024 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4025 (bidi_level_of_next_char, bidi_move_to_visually_next):
4026 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4027 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
4028 (Fkill_buffer, Fset_buffer_major_mode)
4029 (advance_to_char_boundary, Fbuffer_swap_text)
4030 (Fset_buffer_multibyte, overlays_at, overlays_in)
4031 (overlay_touches_p, struct sortvec, record_overlay_string)
4032 (overlay_strings, recenter_overlay_lists)
4033 (adjust_overlays_for_insert, adjust_overlays_for_delete)
4034 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
4035 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
4036 (Foverlay_recenter, last_overlay_modification_hooks_used)
4037 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
4038 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4039 (validate_region): Omit unnecessary test for b <= e,
4040 since that's guaranteed by the previous test.
4041 (adjust_overlays_for_delete): Avoid pos + length overflow.
4042 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
4043 (report_overlay_modification):
4044 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4045 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
4046 Omit pointer cast, which isn't needed anyway, and doesn't work
4047 after the EMACS_INT -> ptrdiff_t change.
4048 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
4049 * buffer.h: Adjust decls to match defn changes elsewhere.
4050 (struct buffer_text, struct buffer):
4051 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4052 Use EMACS_INT, not int, where int might not be wide enough.
4053 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
4054 not int, to avoid needless 32-bit limit on 64-bit hosts.
4055 (exec_byte_code): Use tighter memory-full test, one that checks
4056 for alloca overflow. Don't compute the address of the object just
4057 before an array, as that's not portable. Use EMACS_INT, not
4058 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
4059 * callint.c (Fcall_interactively):
4060 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4061 * callproc.c (call_process_kill, Fcall_process):
4062 Don't assume pid_t fits into an Emacs fixnum.
4063 (call_process_cleanup, Fcall_process, child_setup):
4064 Don't assume pid_t fits into int.
4065 (call_process_cleanup, Fcall_process, delete_temp_file)
4066 (Fcall_process_region):
4067 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4068 (Fcall_process): Simplify handling of volatile integers.
4069 Use int, not EMACS_INT, where int will do.
4070 * casefiddle.c (casify_object, casify_region, operate_on_word)
4071 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
4072 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4073 (casify_object): Avoid integer overflow when overallocating buffer.
4074 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
4075 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
4076 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
4077 * category.h (CATEGORYP): Don't assume arg is nonnegative.
4078 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
4079 integers are now checked earlier. All uses replaced with XINT.
4081 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4082 For CCL_MapSingle, check that content and value are in int range.
4083 (ccl_driver, Fregister_code_conversion_map):
4084 Check that Vcode_version_map_vector is a vector.
4085 (resolve_symbol_ccl_program): Check that vector header is in range.
4086 Always copy the vector, so that we can check its contents reliably
4087 now rather than having to recheck each instruction as it's being
4088 executed. Check that vector words fit in 'int'.
4089 (ccl_get_compiled_code, Fregister_ccl_program)
4090 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
4091 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
4092 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
4093 contents are in range.
4094 (Fccl_execute_on_string): Check that status is in range.
4095 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
4096 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
4097 Accept and return EMACS_INT, not int, because callers can pass values
4099 (c_string_width, strwidth, lisp_string_width, chars_in_text)
4100 (multibyte_chars_in_text, parse_str_as_multibyte)
4101 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
4102 (str_as_unibyte, str_to_unibyte, string_count_byte8)
4103 (string_escape_byte8, Fget_byte):
4104 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4105 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
4106 avoid mishandling large integers.
4107 * character.h: Adjust decls to match defn changes elsewhere.
4108 * charset.c (load_charset_map_from_file, find_charsets_in_text)
4109 (Ffind_charset_region):
4110 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4111 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
4112 (load_charset_map_from_vector, Fdefine_charset_internal):
4113 Don't assume fixnum fits in int.
4114 (load_charset_map_from_vector, Fmap_charset_chars):
4115 Remove now-unnecessary CHECK_NATNUMs.
4116 (Fdefine_charset_internal): Check ranges here, more carefully.
4117 Don't rely on undefined behavior with signed left shift overflow.
4118 Don't assume unsigned int fits into fixnum, or that fixnum fits
4119 into unsigned int. Don't require max_code to be a valid fixnum;
4120 that's not true for gb10830 4-byte on a 32-bit host. Allow
4121 invalid_code to be a cons, for the same reason. Require code_offset
4122 to be a character. Avoid int overflow if max_char is close
4124 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
4125 this is intended anyway and avoids some undefined behavior.
4126 (load_charset_map): Pass unsigned, not int, as 2nd arg of
4127 INDEX_TO_CODE_POINT, as that's what it expects.
4128 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
4129 * charset.h (DECODE_CHAR): Return int, not unsigned;
4130 this is what was intended anyway, and it avoids undefined behavior.
4131 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
4132 integer-overflow issues.
4133 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
4134 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
4135 where the argument is EMACS_INT, and this behavior is not intended.
4136 * chartab.c (Fmake_char_table, Fset_char_table_range)
4137 (uniprop_get_decoder, uniprop_get_encoder):
4138 Don't assume fixnum fits in int.
4139 * cmds.c (move_point): New function, that does the gist of
4140 Fforward_char and Fbackward_char, but does so while checking
4141 for integer overflow more accurately.
4142 (Fforward_char, Fbackward_char): Use it.
4143 (Fforward_line, Fend_of_line, internal_self_insert)
4144 (internal_self_insert):
4145 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4146 Fix a FIXME, by checking for integer overflow when calculating
4147 target_clm and actual_clm.
4148 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
4149 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
4150 (ASSURE_DESTINATION, coding_alloc_by_realloc)
4151 (coding_alloc_by_making_gap, alloc_destination)
4152 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
4153 (encode_coding_utf_16, detect_coding_emacs_mule)
4154 (decode_coding_emacs_mule, encode_coding_emacs_mule)
4155 (detect_coding_iso_2022, decode_coding_iso_2022)
4156 (encode_invocation_designation, encode_designation_at_bol)
4157 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4158 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
4159 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
4160 (encode_coding_ccl, encode_coding_raw_text)
4161 (detect_coding_charset, decode_coding_charset)
4162 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
4163 (produce_composition, produce_charset, produce_annotation)
4164 (decode_coding, handle_composition_annotation)
4165 (handle_charset_annotation, consume_chars, decode_coding_gap)
4166 (decode_coding_object, encode_coding_object, detect_coding_system)
4167 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
4168 (code_convert_region, code_convert_string)
4169 (Fdefine_coding_system_internal)
4170 (coding_set_source, coding_set_destination):
4171 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4172 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
4173 (Fdefine_coding_system_internal):
4174 Don't assume fixnums fit in int.
4175 (decode_coding_gap, decode_coding_object, encode_coding_object)
4176 (Fread_coding_system, Fdetect_coding_region)
4177 (Funencodable_char_position, Fcheck_coding_systems_region)
4178 (get_translation, handle_composition_annotation, consume_chars):
4179 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4180 (consume_chars): Rewrite to not calculate an address outside buffer.
4181 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
4182 Don't access memory outside of the args array.
4183 (Fdefine_coding_system_internal): Check for charset-id overflow.
4184 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
4185 result of ENCODE_CHAR.
4186 * coding.h: Adjust decls to match defn changes elsewhere.
4187 (struct coding_system):
4188 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4189 * composite.c (get_composition_id, find_composition)
4190 (run_composition_function, update_compositions)
4191 (compose_text, composition_gstring_put_cache)
4192 (composition_gstring_p, composition_gstring_width)
4193 (fill_gstring_header, fill_gstring_body, autocmp_chars)
4194 (composition_compute_stop_pos, composition_reseat_it)
4195 (composition_update_it, struct position_record)
4196 (find_automatic_composition, composition_adjust_point)
4197 (Fcomposition_get_gstring, Ffind_composition_internal):
4198 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4199 (update_compositions):
4200 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4201 * composite.h: Adjust decls to match defn changes elsewhere.
4202 (struct composition):
4203 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4204 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
4205 Do not attempt to compute the address of the object just before a
4206 buffer; this is not portable.
4208 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4209 (Faset): Use int, not EMACS_INT, where int is wide enough.
4210 (Fstring_to_number): Don't assume fixnums fit in int.
4211 (Frem): Don't assume arg is nonnegative.
4212 * dbusbind.c (xd_append_arg): Check for integers out of range.
4213 (Fdbus_call_method): Don't overflow the timeout int.
4214 (extract_signed, extract_unsigned): New functions.
4215 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
4216 (xd_get_connection_references): Return ptrdiff_t, not int.
4218 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
4219 (xd_read_message_1):
4220 Use int, not unsigned, where the dbus API uses int.
4221 (Fdbus_message_internal): Don't overflow mtype.
4222 (syms_of_dbusbind): Allocate right-sized buffer for integers.
4223 * dired.c (directory_files_internal, file_name_completion, scmp)
4224 (file_name_completion_stat):
4225 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4226 (file_name_completion): Don't overflow matchcount.
4227 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
4228 * dispextern.h: Adjust decls to match defn changes elsewhere.
4229 (struct text_pos, struct glyph, struct bidi_saved_info)
4230 (struct bidi_string_data, struct bidi_it, struct composition_it)
4232 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4233 (struct display_pos, struct composition_it, struct it):
4234 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4235 * dispnew.c (increment_matrix_positions)
4236 (increment_row_positions, mode_line_string)
4237 (marginal_area_string):
4238 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4239 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
4240 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4241 (duration_to_sec_usec): New function, to check for overflow better.
4242 (Fsleep_for, sit_for): Use it.
4243 * doc.c (get_doc_string, store_function_docstring):
4244 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4245 (get_doc_string, Fsnarf_documentation):
4246 Use int, not EMACS_INT, where int is wide enough.
4248 Use SAFE_ALLOCA, not alloca.
4249 Check for overflow when converting EMACS_INT to off_t.
4250 * doprnt.c (doprnt):
4251 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4252 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
4253 Don't assume uid_t fits into fixnum.
4254 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
4255 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
4256 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
4257 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
4258 (general_insert_function)
4259 (Finsert_char, make_buffer_string, make_buffer_string_both)
4260 (update_buffer_properties, Fbuffer_substring)
4261 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
4262 (Fsubst_char_in_region, check_translation)
4263 (Ftranslate_region_internal, save_restriction_restore, Fformat)
4264 (transpose_markers, Ftranspose_regions):
4265 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4266 (clip_to_bounds): Move to lisp.h as an inline function).
4267 (Fconstrain_to_field): Don't assume integers are nonnegative.
4268 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
4269 (Fsubst_char_in_region, Fsave_restriction):
4270 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4271 (Femacs_pid): Don't assume pid_t fits into fixnum.
4272 (lo_time): Use int, not EMACS_INT, when int suffices.
4273 (lisp_time_argument): Check for usec out of range.
4274 (Fencode_time): Don't assume fixnum fits in int.
4275 (Fuser_login_name, Fuser_full_name): Signal an error
4276 if a uid argument is out of range, rather than relying on
4278 (Fformat_time_string): Remove now-unnecessary check.
4279 lisp_time_argument checks for out-of-range usec now.
4280 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
4281 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
4282 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
4283 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
4284 (init_cmdargs, Fdump_emacs):
4285 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4286 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
4287 the bottom (typically) 32 bits of the fixnum.
4288 * eval.c (specpdl_size, call_debugger):
4289 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4290 (when_entered_debugger, Fbacktrace_debug):
4291 Don't assume fixnum can fit in int.
4292 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
4293 the object just before a buffer; this is not portable.
4294 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
4295 (grow_specpdl, unbind_to):
4296 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4297 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
4298 (grow_specpdl): Simplify allocation by using xpalloc.
4299 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
4300 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
4301 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
4302 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4303 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
4305 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4306 (Fcopy_file, non_regular_nbytes, read_non_regular)
4307 (Finsert_file_contents):
4308 Use int, not EMACS_INT, where int is wide enough.
4309 (READ_BUF_SIZE): Verify that it fits in int.
4310 (Finsert_file_contents): Check that counts are in proper range,
4311 rather than assuming fixnums fit into ptrdiff_t etc.
4312 Don't assume fixnums fit into int.
4313 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
4314 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
4315 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
4316 (string_char_to_byte, string_byte_to_char)
4317 (string_make_multibyte, string_to_multibyte)
4318 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
4319 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
4320 (substring_both, Fdelete, internal_equal, Ffillarray)
4321 (Fclear_string, mapcar1)
4322 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
4323 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
4324 (larger_vector, make_hash_table, maybe_resize_hash_table)
4325 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
4326 (Fmaphash, secure_hash):
4327 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4328 (concat): Check for string index and length overflow.
4329 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
4331 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4332 (larger_vector): New API (vec, incr_min, size_max) replaces old
4333 one (vec, new_size, init). This catches size overflow.
4334 INIT was removed because it was always Qnil.
4335 All callers changed.
4336 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
4337 the upper bound on a hash table index size.
4338 (make_hash_table, maybe_resize_hash_table): Use it.
4339 (secure_hash): Computer start_byte and end_byte only after
4340 they're known to be in ptrdiff_t range.
4341 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
4342 (Ffont_get_glyphs, Ffont_at):
4343 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4344 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
4345 (Flist_fonts, Fopen_font):
4346 Don't assume fixnum can fit in int.
4347 (check_gstring): Don't assume index can fit in int.
4348 (font_match_p): Check that fixnum is a character, not a nonnegative
4349 fixnum, since the later code needs to stuff it into an int.
4350 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
4351 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
4352 conversion overflow issues.
4353 (Fopen_font): Check for integer out of range.
4354 (Ffont_get_glyphs): Don't assume index can fit in int.
4355 * font.h: Adjust decls to match defn changes elsewhere.
4356 * fontset.c (reorder_font_vector): Redo score calculation to avoid
4358 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
4359 printmax_t, where ptrdiff_t is wide enough.
4360 (Finternal_char_font):
4361 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4362 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
4363 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
4364 (Fset_frame_position, x_set_frame_parameters)
4365 (x_set_line_spacing, x_set_border_width)
4366 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
4367 Check that fixnums are in proper range for system types.
4368 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
4369 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4370 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
4371 Use SAFE_ALLOCA_LISP, not alloca.
4372 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
4373 intptr_t is wide enough.
4374 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
4375 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
4376 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
4377 Check for fixnum out of range.
4378 * ftfont.c (ftfont_list): Don't assume index fits in int.
4379 Check that fixnums are in proper range for system types.
4380 (ftfont_shape_by_flt):
4381 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4382 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4383 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4384 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
4385 Check that fixnums are in proper range for system types.
4386 * gnutls.h: Adjust decls to match defn changes elsewhere.
4387 * gtkutil.c (xg_dialog_run):
4388 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4389 (update_frame_tool_bar):
4390 Check that fixnums are in proper range for system types.
4391 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
4392 (lookup_image): Check that fixnums are in range for system types.
4393 * indent.c (last_known_column, last_known_column_point):
4394 (current_column_bol_cache):
4395 (skip_invisible, current_column, check_display_width):
4396 (check_display_width, scan_for_column, current_column_1)
4397 (Findent_to, Fcurrent_indentation, position_indentation)
4398 (indented_beyond_p, Fmove_to_column, compute_motion):
4399 (Fcompute_motion, Fvertical_motion):
4400 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4401 (last_known_column_modified): Use EMACS_INT, not int.
4402 (check_display_width):
4404 Check that fixnums and floats are in proper range for system types.
4405 (compute_motion): Don't assume index or fixnum fits in int.
4406 (compute_motion, Fcompute_motion):
4407 Use int, not EMACS_INT, when it is wide enough.
4408 (vmotion): Omit local var start_hpos that is always 0; that way
4409 we don't need to worry about overflow in expressions involving it.
4410 * indent.h: Adjust decls to match defn changes elsewhere.
4412 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4413 Use int, not EMACS_INT, where int is wide enough.
4414 Remove unused members ovstring_chars_done and tab_offset;
4416 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
4417 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
4418 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
4419 (make_gap, copy_text, insert, insert_and_inherit)
4420 (insert_before_markers, insert_before_markers_and_inherit)
4421 (insert_1, count_combining_before, count_combining_after)
4422 (insert_1_both, insert_from_string)
4423 (insert_from_string_before_markers, insert_from_string_1)
4424 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
4425 (adjust_after_replace, adjust_after_insert, replace_range)
4426 (replace_range_2, del_range, del_range_1, del_range_byte)
4427 (del_range_both, del_range_2, modify_region)
4428 (prepare_to_modify_buffer, signal_before_change)
4429 (signal_after_change, Fcombine_after_change_execute):
4430 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4431 * intervals.c (traverse_intervals, rotate_right, rotate_left)
4432 (balance_an_interval, split_interval_right, split_interval_left)
4433 (find_interval, next_interval, update_interval)
4434 (adjust_intervals_for_insertion, delete_node, delete_interval)
4435 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4436 (static_offset_intervals, offset_intervals)
4437 (merge_interval_right, merge_interval_left, make_new_interval)
4438 (graft_intervals_into_buffer, temp_set_point_both)
4439 (temp_set_point, set_point, adjust_for_invis_intang)
4440 (set_point_both, move_if_not_intangible, get_property_and_range)
4441 (get_local_map, copy_intervals, copy_intervals_to_string)
4442 (compare_string_intervals, set_intervals_multibyte_1):
4443 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4444 * intervals.h: Adjust decls to match defn changes elsewhere.
4446 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4447 * keyboard.c (this_command_key_count, this_single_command_key_start)
4448 (before_command_key_count, before_command_echo_length, echo_now)
4449 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
4450 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
4451 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
4452 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
4453 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4454 (last_non_minibuf_size, last_point_position, echo_truncate)
4455 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
4456 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
4457 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
4458 (stuff_buffered_input):
4459 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4460 (last_auto_save, command_loop_1, read_char):
4461 Use EMACS_INT, not int, to avoid integer overflow.
4462 (record_char): Avoid overflow in total_keys computation.
4463 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
4464 * keyboard.h: Adjust decls to match defn changes elsewhere.
4465 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
4466 (Fkey_description, Fdescribe_vector, Flookup_key):
4467 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4468 (click_position): New function, to check that positions are in range.
4469 (Fcurrent_active_maps):
4471 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4472 (Faccessible_keymaps, Fkey_description):
4473 (preferred_sequence_p):
4474 Don't assume fixnum can fit into int.
4475 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
4476 Check for integer overflow in size calculations.
4477 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
4478 avoid mishandling large integers.
4479 * lisp.h: Adjust decls to match defn changes elsewhere.
4480 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
4481 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
4482 (struct Lisp_Marker):
4483 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4484 (clip_to_bounds): Now an inline function, moved here from editfns.c.
4485 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
4486 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
4487 All callers changed.
4488 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
4489 Assume the arg has valid form, since it always does.
4490 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
4491 unsigned integer system type.
4492 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
4493 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
4494 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4495 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
4496 (duration_to_sec_usec): New decl.
4497 * lread.c (read_from_string_index, read_from_string_index_byte)
4498 (read_from_string_limit, readchar, unreadchar, openp)
4499 (read_internal_start, read1, oblookup):
4500 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4501 (Fload, readevalloop, Feval_buffer, Feval_region):
4502 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4503 (openp): Check for out-of-range argument to 'access'.
4504 (read1): Use int, not EMACS_INT, where int is wide enough.
4505 Don't assume fixnum fits into int.
4506 Fix off-by-one error that can read outside a buffer.
4507 (read_filtered_event): Use duration_to_sec_usec
4508 to do proper overflow checking on durations.
4509 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
4510 in size calculation.
4511 (Fexecute_kbd_macro):
4512 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4513 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
4514 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
4515 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
4516 (set_marker_both, set_marker_restricted_both, marker_position)
4517 (marker_byte_position, Fbuffer_has_markers_at):
4518 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4519 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
4520 * menu.c (ensure_menu_items): Rename from grow_menu_items.
4521 It now merely ensures that the menu is large enough, without
4522 necessarily growing it, as this avoids some integer overflow issues.
4523 All callers changed.
4524 (keymap_panes, parse_single_submenu, Fx_popup_menu):
4525 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4526 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
4527 Use SAFE_ALLOCA_LISP, not alloca.
4528 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
4529 to EMACS_INT. Check that fixnums are in proper range for system types.
4530 * minibuf.c (minibuf_prompt_width, string_to_object)
4531 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
4532 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
4533 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4534 (get_minibuffer, read_minibuf_unwind):
4535 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4536 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
4537 this simplifies overflow checking. All callers changed.
4538 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
4540 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4541 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
4542 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
4543 Check that fixnums are in proper range for system types.
4544 (Fx_create_frame, Fx_show_tip):
4545 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4546 * nsfont.m (ns_findfonts, nsfont_list_family):
4547 Don't assume fixnum fits in long.
4548 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
4549 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4550 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
4552 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
4553 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4554 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
4555 (PRINTDECLARE, PRINTPREPARE):
4556 (strout, print_string):
4557 (print, print_preprocess, print_check_string_charset_prop)
4559 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4561 (temp_output_buffer_setup, Fprin1_to_string, print_object):
4562 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4563 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
4564 (printchar, strout): Use xpalloc to catch size calculation overflow.
4565 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
4566 (print_error_message): Use SAFE_ALLOCA, not alloca.
4567 (print_object): Use int, not EMACS_INT, where int is wide enough.
4568 (print_depth, new_backquote_output, print_number_index):
4569 Use ptrdiff_t, not int, where int might not be wide enough.
4570 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
4571 (Fset_process_window_size, Fformat_network_address)
4572 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
4574 Check that fixnums are in proper range for system types.
4575 (Fsignal_process): Simplify by avoiding a goto.
4576 Check for process-ids out of pid_t range rather than relying on
4578 (process_tick, update_tick): Use EMACS_INT, not int.
4579 (Fformat_network_address, read_process_output, send_process)
4580 (Fprocess_send_region, status_notify):
4581 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4582 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4583 (wait_reading_process_output, read_process_output, exec_sentinel):
4584 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4585 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4586 (Faccept_process_output): Use duration_to_sec_usec to do proper
4587 overflow checking on durations.
4588 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4589 Don't assume pid_t fits in int.
4590 * process.h (struct Lisp_Process): Members tick and update_tick
4591 are now of type EMACS_INT, not int.
4592 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4593 configured --with-wide-int.
4594 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4595 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4596 * search.c (looking_at_1, string_match_1):
4597 (fast_string_match, fast_c_string_match_ignore_case)
4598 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4599 (scan_newline, find_before_next_newline, search_command)
4600 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4601 (set_search_regs, wordify):
4604 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4605 (string_match_1, search_buffer, set_search_regs):
4607 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4608 (wordify): Check for overflow in size calculation.
4609 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4610 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4611 Check that fixnums are in proper range for system types.
4612 * sound.c (struct sound_device)
4613 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4614 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4615 (Fplay_sound_internal):
4616 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4617 * syntax.c (struct lisp_parse_state, find_start_modiff)
4618 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4619 (Fparse_partial_sexp):
4620 Don't assume fixnums can fit in int.
4621 (struct lisp_parse_state, find_start_pos, find_start_value)
4622 (find_start_value_byte, find_start_begv)
4623 (update_syntax_table, char_quoted, dec_bytepos)
4624 (find_defun_start, prev_char_comend_first, back_comment):
4625 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4626 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4627 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4628 (Finternal_describe_syntax_value): Check that match_lisp is a
4629 character, not an integer, since the code stuffs it into int.
4630 (scan_words, scan_sexps_forward):
4631 Check that fixnums are in proper range for system types.
4633 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4634 (scan_sexps_forward):
4635 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4636 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4637 * syntax.h: Adjust decls to match defn changes elsewhere.
4638 (struct gl_state_s):
4639 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4640 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4641 MOST_POSITIVE_FIXNUM.
4642 * sysdep.c (wait_for_termination_1, wait_for_termination)
4643 (interruptible_wait_for_termination, mkdir):
4644 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4645 (emacs_read, emacs_write):
4646 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4647 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4648 and double all fit in int.
4649 * term.c (set_tty_color_mode):
4650 Check that fixnums are in proper range for system types.
4651 * termhooks.h (struct input_event):
4652 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4653 * textprop.c (validate_interval_range, interval_of)
4654 (Fadd_text_properties, set_text_properties_1)
4655 (Fremove_text_properties, Fremove_list_of_text_properties)
4656 (Ftext_property_any, Ftext_property_not_all)
4657 (copy_text_properties, text_property_list, extend_property_ranges)
4658 (verify_interval_modification):
4659 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4660 (Fnext_single_char_property_change)
4661 (Fprevious_single_char_property_change):
4662 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4663 (copy_text_properties):
4664 Check for integer overflow in index calculation.
4665 * undo.c (last_boundary_position, record_point, record_insert)
4666 (record_delete, record_marker_adjustment, record_change)
4667 (record_property_change):
4668 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4669 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4670 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4671 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4672 (Fx_hide_tip, Fx_file_dialog):
4673 * w32menu.c (set_frame_menubar):
4674 Use ptrdiff_t, not int, for consistency with rest of code.
4675 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4676 (select_window, Fdelete_other_windows_internal)
4677 (window_scroll_pixel_based, window_scroll_line_based)
4678 (Frecenter, Fset_window_configuration):
4679 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4680 (Fset_window_hscroll, run_window_configuration_change_hook)
4681 (set_window_buffer, temp_output_buffer_show, scroll_command)
4682 (Fscroll_other_window, Frecenter):
4683 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4684 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4685 Don't assume fixnum fits in int.
4686 (Fset_window_scroll_bars):
4687 Check that fixnums are in proper range for system types.
4688 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4689 (string_pos, c_string_pos, number_of_chars, init_iterator)
4690 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4691 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4692 (compute_display_string_end, handle_face_prop)
4693 (face_before_or_after_it_pos, handle_invisible_prop)
4694 (handle_display_prop, handle_display_spec, handle_single_display_spec)
4695 (display_prop_intangible_p, string_buffer_position_lim)
4696 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4697 (get_overlay_strings_1, get_overlay_strings)
4698 (iterate_out_of_display_property, forward_to_next_line_start)
4699 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4700 (get_next_display_element, set_iterator_to_next)
4701 (get_visually_first_element, compute_stop_pos_backwards)
4702 (handle_stop_backwards, next_element_from_buffer)
4703 (move_it_in_display_line_to, move_it_in_display_line)
4704 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4705 (add_to_log, message_dolog, message_log_check_duplicate)
4706 (message2, message2_nolog, message3, message3_nolog
4707 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4708 (current_message_1, truncate_echo_area, truncate_message_1)
4709 (set_message, set_message_1, store_mode_line_noprop)
4710 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4711 (text_outside_line_unchanged_p, check_point_in_composition)
4712 (reconsider_clip_changes)
4713 (redisplay_internal, set_cursor_from_row, try_scrolling)
4714 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4715 (redisplay_window, find_last_unchanged_at_beg_row)
4716 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4717 (trailing_whitespace_p, find_row_edges, display_line)
4718 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4719 (display_mode_element, store_mode_line_string)
4720 (pint2str, pint2hrstr, decode_mode_spec)
4721 (display_count_lines, display_string, draw_glyphs)
4722 (x_produce_glyphs, x_insert_glyphs)
4723 (rows_from_pos_range, mouse_face_from_buffer_pos)
4724 (fast_find_string_pos, mouse_face_from_string_pos)
4725 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4726 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4727 (safe_call, init_from_display_pos, handle_fontified_prop)
4728 (handle_single_display_spec, load_overlay_strings)
4729 (with_echo_area_buffer, setup_echo_area_for_printing)
4730 (display_echo_area, echo_area_display)
4731 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4732 (update_tool_bar, hscroll_window_tree, redisplay_internal)
4733 (redisplay_window, dump_glyph_row, display_mode_line)
4734 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
4735 (handle_display_spec, display_prop_string_p):
4736 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4737 (handle_single_display_spec, build_desired_tool_bar_string)
4738 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4739 (get_specified_cursor_type):
4740 Check that fixnums are in proper range for system types.
4741 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4742 (Flookup_image_map):
4743 Don't assume fixnums fit in int.
4744 (compare_overlay_entries):
4745 Avoid mishandling comparisons due to subtraction overflow.
4746 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4747 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4748 (handle_tool_bar_click):
4749 Use int, not unsigned, since we prefer signed and the signedness
4750 doesn't matter here.
4751 (get_next_display_element, next_element_from_display_vector):
4752 Use int, not EMACS_INT, when int is wide enough.
4753 (start_hourglass): Use duration_to_sec_usec to do proper
4754 overflow checking on durations.
4755 * xfaces.c (Fbitmap_spec_p):
4756 Check that fixnums are in proper range for system types.
4757 (compare_fonts_by_sort_order):
4758 Avoid mishandling comparisons due to subtraction overflow.
4759 (Fx_family_fonts, realize_basic_faces):
4760 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4762 Don't assume fixnum fits in int.
4763 Use SAFE_ALLOCA_LISP, not alloca.
4764 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4765 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4766 (face_at_buffer_position, face_for_overlay_string)
4767 (face_at_string_position):
4768 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4769 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4770 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4772 Check that fixnums are in proper range for system types.
4773 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4774 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4775 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4776 (Fx_change_window_property): Don't assume fixnums fit in int.
4777 * xfont.c (xfont_chars_supported):
4778 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4779 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4780 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4781 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4782 * xml.c (parse_region):
4783 * xrdb.c (magic_file_p):
4784 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4785 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4786 (x_get_local_selection, x_reply_selection_request)
4787 (x_handle_selection_request, wait_for_property_change):
4788 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4789 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4790 short is wide enough.
4791 (x_send_client_event): Don't assume fixnum fits in int.
4792 * xterm.c (x_x_to_emacs_modifiers):
4793 Don't assume EMACS_INT overflows nicely into int.
4794 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4796 (handle_one_xevent): NATNUMP can eval its arg twice.
4797 (x_connection_closed):
4798 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4799 * xterm.h: Adjust decls to match defn changes elsewhere.
4800 (struct scroll_bar): Use struct vectorlike_header
4801 rather than rolling our own approximation.
4802 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4804 2012-05-25 Glenn Morris <rgm@gnu.org>
4806 * lisp.mk (lisp): Update for more files being compiled now.
4808 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4810 * lread.c: Remove `read_pure' which makes no difference.
4811 (read_pure): Remove var.
4812 (unreadpure): Remove function.
4813 (readevalloop): Don't call read_list with -1 flag.
4814 (read1, read_vector): Don't test read_pure any more.
4815 (read_list): Simplify.
4817 * fileio.c, character.h: Minor style tweaks.
4819 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4821 * window.h (clip_changed): Remove useless declaration.
4823 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
4825 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4826 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4828 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4831 This directory predates autoconf and is no longer needed nowadays.
4832 Move its few remaining bits of functionality to where they're needed.
4833 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4834 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4835 * m/template.h: Remove.
4836 * Makefile.in (M_FILE): Remove. All uses removed.
4837 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4838 * lisp.h (USE_LSB_TAG):
4839 * mem-limits.h (EXCEEDS_LISP_PTR):
4840 Use VAL_MAX, not VALBITS, in #if.
4841 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4842 (EMACS_UINT): Define unconditionally now.
4843 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4844 (BITS_PER_EMACS_INT): New constants, replacing
4845 what used to be in config.h, but not useful in #if.
4846 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4847 define them any more.
4848 (VAL_MAX): New macro.
4850 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4851 BITS_PER_EMACS_INT, in #if.
4852 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4853 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4854 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4855 * s/ms-w32.h (DATA_START):
4856 Move here from removed file m/intel386.h.
4857 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4858 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4860 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4862 Assume C89 or later.
4863 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4864 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4866 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4867 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4868 * textprop.c, tparam.c (NULL): Remove.
4869 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4870 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4871 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4872 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4873 * xterm.c (input_signal_count): Assume volatile works.
4875 2012-05-21 Ken Brown <kbrown@cornell.edu>
4877 * xgselect.c (xg_select): Fix first argument in call to 'select'
4880 2012-05-20 Ken Brown <kbrown@cornell.edu>
4882 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
4883 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
4885 2012-05-19 Ken Brown <kbrown@cornell.edu>
4887 * xfns.c (x_in_use): Remove `static' qualifier.
4888 * xterm.h (x_in_use): Declare.
4889 * xgselect.c: Include xterm.h.
4890 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4891 and `display_arg' (bug#9754).
4893 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4895 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4897 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4898 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4900 2012-05-18 Eli Zaretskii <eliz@gnu.org>
4902 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4904 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
4905 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
4907 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4908 reference to image_cache->refcount.
4909 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4911 2012-05-17 Juri Linkov <juri@jurta.org>
4913 * search.c (Fword_search_regexp, Fword_search_backward)
4914 (Fword_search_forward, Fword_search_backward_lax)
4915 (Fword_search_forward_lax): Move functions to isearch.el
4916 (bug#10145, bug#11381).
4918 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4920 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4922 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4924 * lread.c (init_obarray): Declare Qt and Qnil as special.
4926 2012-05-14 Glenn Morris <rgm@gnu.org>
4928 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
4929 Put "libexec" before "bin", for the sake of init_callproc_1.
4931 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4933 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4935 * unexaix.c: Port to more-recent AIX compilers.
4936 (report_error, report_error_1, make_hdr, copy_sym)
4937 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4938 Make arguments const char *, not char *, to avoid violations of C
4939 standard and to fix some AIX warnings reported by Gilles Pion.
4941 2012-05-14 Eli Zaretskii <eliz@gnu.org>
4943 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4944 already have overlays loaded.
4945 (handle_single_display_spec): Before returning without displaying
4946 fringe bitmap, synchronize the bidi iterator with the main display
4947 iterator, by calling iterate_out_of_display_property.
4948 (iterate_out_of_display_property): Detect buffer iteration by
4949 testing that it->string is a Lisp string.
4950 (get_next_display_element): When the current object is exhausted,
4951 and there's something on it->stack, call set_iterator_to_next to
4952 proceed with what's on the stack, instead of returning zero.
4953 (set_iterator_to_next): If called at the end of a Lisp string,
4954 proceed to consider_string_end without incrementing string
4955 position. Don't increment display vector index past the end of
4956 the display vector. (Bug#11417)
4957 (pos_visible_p): Don't report a position visible when move_it_to
4958 stopped at the last line of window, which happens to be scanned
4959 backwards by the bidi iteration. (Bug#11464)
4961 2012-05-14 Eli Zaretskii <eliz@gnu.org>
4963 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4964 and right-margin display specs even if the spec is invalid or we
4965 are on a TTY, and thus unable to display on the fringes.
4966 That's because the text with the property will not be displayed anyway,
4967 so we need to signal to the caller that this is a "replacing"
4968 display spec. This fixes display when the spec is invalid or we
4971 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4973 * unexaix.c (make_hdr): Fix typo in prototype.
4974 This bug broke the build on AIX. Problem reported by Gilles Pion.
4976 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
4978 * keyboard.c (kbd_buffer_get_event): Read special events also in
4979 batch mode. (Bug#11415)
4981 2012-05-12 Glenn Morris <rgm@gnu.org>
4983 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4985 2012-05-12 Eli Zaretskii <eliz@gnu.org>
4987 * lisp.mk (lisp): Add newcomment.elc.
4989 2012-05-12 Glenn Morris <rgm@gnu.org>
4991 * Makefile.in (MKDIR_P): New, set by configure.
4992 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4994 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4996 Remove unused function hourglass_started.
4997 * dispextern.h (hourglass_started):
4998 * w32fns.c (hourglass_started):
4999 * xdisp.c (hourglass_started): Remove.
5001 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
5003 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
5004 Update dependencies.
5006 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
5008 * xgselect.c (xg_select): Put maxfds+1 into a var.
5009 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
5011 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
5013 2012-05-10 Dave Abrahams <dave@boostpro.com>
5015 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
5016 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
5018 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
5020 * dbusbind.c (xd_registered_buses): New internal Lisp object.
5021 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
5022 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
5023 Initialize xd_registered_buses.
5025 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
5027 Untag more efficiently if USE_LSB_TAG.
5028 This is based on a proposal by YAMAMOTO Mitsuharu in
5029 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
5030 For an admittedly artificial (nth 8000 longlist) benchmark on
5031 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
5032 Emacs's overall text size by 1%.
5033 * lisp.h (XUNTAG): New macro.
5034 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
5035 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
5036 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
5037 * eval.c (Fautoload):
5038 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
5039 * frame.h (XFRAME): Use XUNTAG.
5041 Port recent dbusbind.c changes to 32-bit --with-wide-int.
5042 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
5043 Remove unportable assumptions about print widths of types like
5045 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
5046 intptr_t when converting between pointer and integer, to avoid GCC
5047 warnings about wrong width.
5049 2012-05-09 Eli Zaretskii <eliz@gnu.org>
5051 * w32proc.c (new_child): Force Windows to reserve only 64KB of
5052 stack for each reader_thread, instead of defaulting to 8MB
5053 determined by the linker. This avoids failures in creating
5054 subprocesses on Windows 7, see the discussion in this thread:
5055 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
5057 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
5059 Fix up display of the *Minibuf-0* buffer in the mini window.
5060 * keyboard.c (read_char): Don't clear the echo area if there's no
5062 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
5063 contents of *Minibuf-0*) if there's no message displayed in its stead.
5065 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
5067 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
5070 2012-05-06 Chong Yidong <cyd@gnu.org>
5072 * lisp.mk (lisp): Update.
5074 2012-05-05 Jim Meyering <meyering@redhat.com>
5076 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
5078 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
5080 * data.c (PUT_ERROR): New macro.
5081 (syms_of_data): Use it. Add new error type `user-error'.
5082 * undo.c (user_error): New function.
5083 (Fprimitive_undo): Use it.
5084 * print.c (print_error_message): Adjust print style for `user-error'.
5085 * keyboard.c (user_error): New function.
5086 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
5088 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
5090 Do not limit current-time-string to years 1000..9999.
5091 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
5092 (Fcurrent_time_string): Support any year that is supported by the
5093 underlying localtime representation. Don't use asctime, as it
5094 has undefined behavior for years outside the range -999..9999.
5096 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
5098 Fix race conditions involving setenv, gmtime, localtime, asctime.
5099 Without this fix, interrupts could mess up code that uses these
5100 nonreentrant functions, since setting TZ invalidates existing
5101 tm_zone or tzname values, and since most of these functions return
5102 pointers to static storage.
5103 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
5104 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
5105 Grow the critical sections to include not just invoking
5106 localtime/gmtime, but also accessing these functions' results
5107 including their tm_zone values if any, and any related TZ setting.
5108 (format_time_string): Last arg is now struct tm *, not struct tm **,
5109 so that the struct tm is saved in the critical section.
5110 All callers changed. Simplify allocation of initial buffer, partly
5111 motivated by the fact that memory allocation needs to be outside
5112 the critical section.
5114 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
5116 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
5117 with RESET_INTERVAL.
5119 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5120 Remove duplicated buffer name initialization.
5122 2012-05-02 Jim Meyering <jim@meyering.net>
5124 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
5126 * xfns.c (x_window): Use xstrdup (Bug#11375).
5128 2012-05-02 Eli Zaretskii <eliz@gnu.org>
5130 * xdisp.c (pos_visible_p): If already at a newline from the
5131 display string before the 'while' loop, don't walk back the glyphs
5132 from it3.glyph_row. Solves assertion violation when the display
5133 string begins with a newline (egg.el). (Bug#11367)
5135 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
5137 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
5140 2012-05-01 Glenn Morris <rgm@gnu.org>
5142 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
5143 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
5144 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
5145 All were removed before 23.1.
5147 * dispnew.c: Remove HAVE_LIBNCURSES test;
5148 it is always true on relevant platforms.
5150 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
5151 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
5153 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
5155 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
5157 * .gdbinit (xpr): Remove checks for no longer existing misc types.
5158 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
5161 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
5163 Do not avoid creating empty evaporating overlays (Bug#9642).
5164 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
5165 That is, do not delete an evaporating overlay if it becomes
5166 empty after its bounds are adjusted to fit within its buffer.
5167 This fix caused other problems, and I'm reverting it until we get
5168 to the bottom of them.
5170 2012-04-27 Chong Yidong <cyd@gnu.org>
5172 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
5174 2012-04-27 Eli Zaretskii <eliz@gnu.org>
5176 * xdisp.c (pos_visible_p): If the window start position is beyond
5177 ZV, start the display from buffer beginning. Prevents assertion
5178 violation in init_iterator when the minibuffer window is scrolled
5181 * window.c (window_scroll_pixel_based): Likewise.
5183 2012-04-27 Chong Yidong <cyd@gnu.org>
5185 * keymap.c (where_is_internal): Doc fix (Bug#10872).
5187 2012-04-27 Glenn Morris <rgm@gnu.org>
5189 * fileio.c (Fcopy_file, Fset_file_selinux_context):
5190 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
5192 2012-04-27 Eli Zaretskii <eliz@gnu.org>
5194 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
5195 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
5197 2012-04-26 Eli Zaretskii <eliz@gnu.org>
5199 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
5200 display element, check also the underlying string or buffer
5201 character. (Bug#11341)
5203 * w32menu.c: Include w32heap.h.
5204 (add_menu_item): If the call to AppendMenuW (via
5205 unicode_append_menu) fails, disable Unicode menus only if we are
5206 running on Windows 9X/Me.
5208 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
5210 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
5211 (xgetint): Add missing shift for LSB tags.
5213 2012-04-24 Martin Rudalics <rudalics@gmx.at>
5215 * keyboard.c (read_char): Don't wipe echo area for select window
5216 events: These might get delayed via `mouse-autoselect-window'
5219 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
5221 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
5222 manipulation of :loaded-from data.
5224 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
5226 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
5227 now a cons (bug#11311).
5229 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
5231 Do not create empty overlays with the evaporate property (Bug#9642).
5232 * buffer.c (Fmove_overlay): Delete an evaporating overlay
5233 if it becomes empty after its bounds are adjusted to fit within
5234 its buffer. Without this fix, in a nonempty buffer (let ((o
5235 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
5236 yields an empty overlay that has the evaporate property, which is
5237 not supposed to happen.
5239 Fix minor GTK3 problems found by static checking.
5240 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5241 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5242 (struct _EmacsFixedClass, emacs_fixed_get_type):
5243 Move decls here from emacsgtkfixed.h, since they needn't be public.
5244 (emacs_fixed_get_type): Now static.
5245 (emacs_fixed_class_init): Omit unused local.
5246 (emacs_fixed_child_type): Remove; unused.
5247 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5248 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5249 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
5250 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
5251 (EMACS_FIXED_GET_CLASS): Remove; unused.
5252 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
5254 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
5255 Problem reported by Juanma Barranquero for Windows -Wunused-function.
5257 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5259 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
5260 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
5261 (__malloc_size_t, __malloc_ptrdiff_t):
5262 Remove. All uses removed, replaced by the definiens if needed,
5263 since we can assume C89 or better now.
5264 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
5265 (protect_malloc_state, align, get_contiguous_space)
5266 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
5267 (malloc_atfork_handler_child, malloc_enable_thread)
5268 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
5269 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
5270 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
5271 (special_realloc, _realloc_internal_nolock, _realloc_internal)
5272 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
5273 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
5274 Define using prototypes, not old style.
5275 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
5276 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
5277 (align): Don't assume that signed integer overflow wraps around.
5278 Omit unused local var.
5279 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
5280 (_free_internal_nolock, memalign, mallochook, reallochook):
5281 Omit no-longer-needed casts.
5282 (valloc): Use getpagesize, not __getpagesize.
5283 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
5284 (struct hdr): The 'magic' member is now size_t, not unsigned long.
5286 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
5288 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
5290 Move functions from C to Lisp. Make non-blocking method calls
5291 the default. Implement further D-Bus standard interfaces.
5293 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
5294 (QCdbus_request_name_allow_replacement)
5295 (QCdbus_request_name_replace_existing)
5296 (QCdbus_request_name_do_not_queue)
5297 (QCdbus_request_name_reply_primary_owner)
5298 (QCdbus_request_name_reply_in_queue)
5299 (QCdbus_request_name_reply_exists)
5300 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
5301 (QCdbus_registered_serial, QCdbus_registered_method)
5302 (QCdbus_registered_signal): New Lisp objects.
5303 (XD_DEBUG_MESSAGE): Use sizeof.
5304 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
5305 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
5306 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
5307 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
5308 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
5309 (xd_signature, xd_append_arg): Allow float for integer types.
5310 (xd_get_connection_references): New function.
5311 (xd_get_connection_address): Rename from xd_initialize.
5312 Return cached address.
5313 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
5314 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
5316 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
5317 Return number of refcounts.
5318 (Fdbus_get_unique_name): Make stronger parameter check.
5319 (Fdbus_message_internal): New defun.
5320 (Fdbus_call_method, Fdbus_call_method_asynchronously)
5321 (Fdbus_method_return_internal, Fdbus_method_error_internal)
5322 (Fdbus_send_signal, Fdbus_register_service)
5323 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
5324 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
5325 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
5326 (Vdbus_compiled_version, Vdbus_runtime_version)
5327 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
5328 (Vdbus_message_type_method_return, Vdbus_message_type_error)
5329 (Vdbus_message_type_signal): New defvars.
5330 (Vdbus_registered_buses, Vdbus_registered_objects_table):
5333 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5335 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
5336 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
5337 Do not assume ptrdiff_t is the same width as 'int'.
5339 * alloc.c: Handle unusual debugging option combinations.
5340 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
5341 since the two debugging options are incompatible.
5342 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
5344 (mem_init, mem_insert, mem_insert_fixup):
5345 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
5346 (NEED_MEM_INSERT): Remove; no longer needed.
5348 2012-04-22 Leo Liu <sdl.web@gmail.com>
5350 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
5352 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5354 * sysdep.c [__FreeBSD__]: Minor cleanups.
5355 (list_system_processes, system_process_attributes) [__FreeBSD__]:
5356 Use Emacs indenting style more consistently. Avoid some casts.
5357 Use 'double' consistently rather than mixing 'float' and 'double'.
5359 2012-04-21 Eduard Wiebe <usenet@pusto.de>
5361 * sysdep.c (list_system_processes, system_process_attributes):
5362 Add implementation for FreeBSD (Bug#5243).
5364 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
5366 * lisp.mk (lisp): Update.
5368 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
5370 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
5371 It is never used otherwise.
5373 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
5375 * print.c (print_preprocess): Only check print_depth if print-circle
5377 (print_object): Check for cycles even when print-circle is nil and
5378 print-gensym is t, but only check print_depth if print-circle is nil.
5380 2012-04-20 Chong Yidong <cyd@gnu.org>
5382 * process.c (wait_reading_process_output): If EIO occurs on a pty,
5383 set the status to "failed" and ensure that sentinel is run.
5385 2012-04-20 Glenn Morris <rgm@gnu.org>
5387 * process.c (Fset_process_inherit_coding_system_flag)
5388 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
5389 (Fmake_network_process, Fmake_serial_process): Doc fix.
5391 2012-04-20 Eli Zaretskii <eliz@gnu.org>
5393 * xdisp.c (string_buffer_position_lim): Limit starting position to
5395 (set_cursor_from_row): If called for a mode-line or header-line
5396 row, return zero immediately.
5397 (try_cursor_movement): If inside continuation line, don't back up
5398 farther than the first row after the header line, if any.
5399 Don't consider the header-line row as "partially visible", even if
5400 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
5402 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
5404 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
5407 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
5408 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
5410 configure: new option --enable-gcc-warnings (Bug#11207)
5411 * Makefile.in (C_WARNINGS_SWITCH): Remove.
5412 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
5413 (ALL_CFLAGS): Use new macros rather than old.
5414 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
5415 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
5416 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
5417 -Wunused-result, -Wunused-variable. This should go away once
5418 the Emacs and Gnulib regex code is merged.
5419 (xmalloc, xrealloc): Now static.
5421 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
5423 * dired.c (Fsystem_groups): Remove unused local.
5425 2012-04-17 Glenn Morris <rgm@gnu.org>
5427 * dired.c (Fsystem_users): Doc fix.
5429 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
5431 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
5432 (syms_of_dired): Add them.
5434 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
5436 Fix minor alloc.c problems found by static checking.
5437 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
5438 New extern decls, to avoid calling undeclared functions.
5439 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
5440 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
5441 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
5442 (NEED_MEM_INSERT): New macro.
5443 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
5444 Remove one incorrect comment and fix another.
5446 Fix minor ralloc.c problems found by static checking.
5447 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5448 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
5449 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
5450 (r_alloc_sbrk): Now static.
5452 Improve ralloc.c interface checking.
5453 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5454 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
5455 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
5456 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
5457 [REL_ALLOC]: ... to here, to check interface.
5458 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
5459 Remove decls. This fixes an "It stinks!".
5461 * alloc.c (which_symbols): Fix alignment issue / type clash.
5463 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
5465 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
5466 (struct Lisp_Misc_Any): Likewise.
5467 (struct Lisp_Free): Likewise.
5468 * alloc.c (union aligned_Lisp_Symbol): Define.
5469 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
5470 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
5471 (union aligned_Lisp_Misc): Define.
5472 (MARKER_BLOCK_SIZE, struct marker_block): Use union
5473 aligned_Lisp_Misc instead of union Lisp_Misc.
5474 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
5476 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
5478 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
5479 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
5480 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
5481 * s/netbsd.h, s/sol2-6.h:
5482 Remove definition of GC_MARK_STACK, since the default now works.
5483 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
5484 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
5485 no longer the default.
5486 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
5488 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
5490 * lread.c (lisp_file_lexically_bound_p):
5491 Fix hang at ";-*-\n" (bug#11238).
5493 2012-04-14 Eli Zaretskii <eliz@gnu.org>
5495 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
5496 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
5498 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
5500 * nsterm.m (constrainFrameRect): Always constrain when there is only
5501 one screen (Bug#10962).
5503 2012-04-13 Ken Brown <kbrown@cornell.edu>
5505 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
5507 2012-04-13 Reuben Thomas <rrt@sc3d.org>
5509 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
5511 2012-04-11 Daniel Colascione <dancol@dancol.org>
5513 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
5514 against is gone. It's better to use vfork now so that when Cygwin
5515 gains a new, working vfork, we use it automatically (bug#10398).
5517 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5519 * window.c (save_window_save): Obey window-point-insertion-type.
5521 2012-04-11 Glenn Morris <rgm@gnu.org>
5523 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
5525 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5527 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
5529 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
5531 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
5532 (force_quit_count): New var.
5533 (handle_interrupt): Use it.
5535 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
5537 * w32.c (w32_delayed_load): Record the full path of the library
5538 being loaded (bug#10424).
5540 2012-04-09 Glenn Morris <rgm@gnu.org>
5542 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
5543 not just in the obarray, before snarfing them. (Bug#11036)
5545 * Makefile.in ($(leimdir)/leim-list.el):
5546 Pass EMACS rather than BUILT_EMACS.
5548 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
5550 * process.c (make_process):
5551 * process.h: Add integer `gnutls_handshakes_tried' member to
5554 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
5555 Add convenience `GNUTLS_LOG2i' macro.
5557 * gnutls.c (gnutls_log_function2i): Convenience log function.
5558 (emacs_gnutls_read): Use new log functions,
5559 `gnutls_handshakes_tried' process member, and
5560 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
5561 attempts per process (connection).
5563 2012-04-09 Chong Yidong <cyd@gnu.org>
5565 * eval.c (Fuser_variable_p, user_variable_p_eh)
5566 (lisp_indirect_variable): Functions deleted.
5567 (Fdefvar): Caller changed.
5569 * callint.c (Finteractive, Fcall_interactively):
5570 * minibuf.c (Fread_variable): Callers changed.
5572 2012-04-09 Eli Zaretskii <eliz@gnu.org>
5574 * xdisp.c (set_cursor_from_row): If the display string appears in
5575 the buffer at position that is closer to point than the position
5576 after the display string, display the cursor on the first glyph of
5577 the display string. Fixes cursor display when a 'display' text
5578 property immediately follows invisible text. (Bug#11094)
5580 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5582 composite.c: use 'double' consistently
5583 * composite.c (get_composition_id): Use 'double' consistently
5584 instead of converting 'float' to 'double' and vice versa; this is
5585 easier to understand and avoids a GCC warning.
5587 2012-04-09 Glenn Morris <rgm@gnu.org>
5589 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5590 preparation for dumping it with emacs. (Bug#4789)
5591 (leimdir): New variable.
5592 ($(leimdir)/leim-list.el): New rule.
5593 (emacs$(EXEEXT)): Depend on leim-list.el.
5595 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5596 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5597 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5599 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5601 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5604 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
5606 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5607 Remove unused local variable.
5609 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5611 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5612 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5613 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5614 objects, as mark_maybe_pointer will catch them otherwise.
5615 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5616 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5618 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5620 Fix typo that broke non-Windows builds.
5621 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5623 2012-04-07 Eli Zaretskii <eliz@gnu.org>
5625 Support building on MS-Windows with libxml2.
5627 * makefile.w32-in (OBJ2): Add xml.$(O).
5628 (GLOBAL_SOURCES): Add xml.c.
5629 ($(BLD)/xml.$(O)): New dependency list.
5631 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5632 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5633 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5634 [!WINDOWSNT]: New macros.
5635 (init_libxml2_functions, libxml2_loaded_p): New functions.
5636 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5637 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5638 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5639 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5641 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5642 Call init_libxml2_functions before calling libxml2 functions.
5643 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5645 * emacs.c: Don't include libxml/parser.h.
5646 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5647 xmlCleanupParser directly.
5649 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5651 2012-04-07 Eli Zaretskii <eliz@gnu.org>
5653 * indent.c (Fvertical_motion): If there is a display string at
5654 point, use it.vpos to compute how many lines to backtrack after
5655 move_it_to point. (Bug#11133)
5657 2012-04-06 Eli Zaretskii <eliz@gnu.org>
5659 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5660 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5661 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5662 macros related to unification of CJK characters. For the details,
5663 see the discussion following the message here:
5664 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5666 2012-04-04 Chong Yidong <cyd@gnu.org>
5668 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5670 2012-04-01 Eli Zaretskii <eliz@gnu.org>
5672 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5673 instead of alloca. (Bug#11138)
5675 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5677 * w32menu.c (is_simple_dialog): Properly check lisp types.
5680 2012-03-31 Eli Zaretskii <eliz@gnu.org>
5682 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5683 position we get to after a call to move_it_to fails the
5684 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5685 only if we wind up in a string from display property. (Bug#11063)
5687 * window.c (Fdelete_other_windows_internal): Invalidate the row
5688 and column information about mouse highlight, so that redisplay
5689 restores it after reallocating the glyph matrices. (Bug#7464)
5691 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5692 string comes from a `display' text property, use the buffer
5693 position of that property as if we actually saw that position in
5695 (move_it_by_lines): Remove the assertion that
5696 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5697 violated when there's a before-string at the beginning of a line.
5700 2012-03-30 Eli Zaretskii <eliz@gnu.org>
5702 * xdisp.c (append_space_for_newline): If the default face was
5703 remapped, use the remapped face for the appended newline.
5704 (extend_face_to_end_of_line): Use the remapped default face for
5705 extending the face to the end of the line.
5706 (display_line): Call extend_face_to_end_of_line when the default
5707 face was remapped. (Bug#11068)
5709 2012-03-29 Eli Zaretskii <eliz@gnu.org>
5711 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5713 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5715 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5717 2012-03-27 Glenn Morris <rgm@gnu.org>
5719 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5722 2012-03-26 Kenichi Handa <handa@m17n.org>
5724 * dispextern.h (struct glyph): Fix previous change. Change the
5725 bit length of glyphless.ch to 25 (Bug#11082).
5727 2012-03-26 Chong Yidong <cyd@gnu.org>
5729 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5730 (command_loop_1): Use it; inhibit selection update for
5731 handle-select-window too (Bug#8996).
5733 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5735 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
5737 2012-03-25 Kenichi Handa <handa@m17n.org>
5739 * dispextern.h (struct glyph): Change the bit length of
5740 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5742 2012-03-24 Eli Zaretskii <eliz@gnu.org>
5744 * s/ms-w32.h (tzname): Include time.h before redirecting to
5745 _tzname. Fixes the MSVC build. (Bug#9960)
5747 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5749 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5752 * xterm.c (XTread_socket): Only modify handling_signal if
5753 !SYNC_INPUT. (Bug#11080)
5755 2012-03-23 Eli Zaretskii <eliz@gnu.org>
5757 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5758 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5759 when fetching a multibyte character consumes more bytes than
5760 CHAR_BYTES returns, due to unification of CJK characters in
5761 string_char. (Bug#11073)
5763 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5765 * process.c (wait_reading_process_output): Handle pty disconnect
5766 by refraining from sending oneself a SIGCHLD (bug#10933).
5768 2012-03-22 Chong Yidong <cyd@gnu.org>
5770 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5772 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
5773 Mark string as coming from a prefix property.
5774 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5775 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5777 2012-03-21 Chong Yidong <cyd@gnu.org>
5779 * xfaces.c (Vface_remapping_alist): Doc fix.
5781 2012-03-20 Eli Zaretskii <eliz@gnu.org>
5783 * w32proc.c (Fw32_set_console_codepage)
5784 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5787 2012-03-20 Chong Yidong <cyd@gnu.org>
5789 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5790 to reflect default non-nil value of redisplay-dont-pause.
5792 2012-03-19 Kenichi Handa <handa@m17n.org>
5794 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5795 it fit in a valid range (Bug#11003).
5797 2012-03-18 Eli Zaretskii <eliz@gnu.org>
5799 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5800 that is not from display property, accept the row as a "cursor
5801 row" if one of the string's character has a non-nil `cursor'
5802 property. Fixes cursor positioning when there are newlines in
5803 overlay strings, e.g. in icomplete.el. (Bug#11035)
5805 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5807 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5809 2012-03-12 Chong Yidong <cyd@gnu.org>
5811 * eval.c (inhibit_lisp_code): Rename from
5812 inhibit_window_configuration_change_hook; move from window.c.
5814 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5815 * window.c (run_window_configuration_change_hook)
5816 (syms_of_window): Callers changed.
5818 2012-03-11 Chong Yidong <cyd@gnu.org>
5820 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5822 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5824 2012-03-10 Chong Yidong <cyd@gnu.org>
5826 * frame.c (other_visible_frames): Don't assume the selected frame
5827 is visible (Bug#10955).
5829 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5831 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5833 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5835 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5836 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5839 2012-03-03 Glenn Morris <rgm@gnu.org>
5841 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
5843 2012-03-02 Eli Zaretskii <eliz@gnu.org>
5845 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5846 position past the first glyph_row that ends at ZV. (Bug#10902)
5847 (redisplay_window, next_element_from_string): Fix typos in
5849 (redisplay_window): Pass to move_it_vertically the margin in
5850 pixels, not in screen lines.
5852 2012-03-02 Glenn Morris <rgm@gnu.org>
5854 * buffer.c (buffer-list-update-hook): Doc fix.
5856 2012-02-29 Eli Zaretskii <eliz@gnu.org>
5858 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5859 push_it before setting up the iterator for the first overlay
5860 string, even if we have an empty string loaded.
5861 (next_overlay_string): If there's an empty string on the iterator
5862 stack, pop the stack. (Bug#10903)
5864 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5866 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5867 Suggested by Stefan Monnier in
5868 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5869 * alloc.c (widen_to_Lisp_Object): New static function.
5870 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5871 and widening them to Lisp_Objects. This would work even if
5872 USE_LSB_TAG is defined and wide integers are used, which might
5873 happen in a future version of Emacs.
5875 2012-02-25 Chong Yidong <cyd@gnu.org>
5877 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5880 * xselect.c (Fx_selection_exists_p): Doc fix.
5881 (x_clipboard_manager_save_all): Print an informative message
5882 before saving to clipboard manager.
5884 2012-02-24 Chong Yidong <cyd@gnu.org>
5886 * keyboard.c (process_special_events): Handle all X selection
5887 requests in kbd_buffer, not just the next one (Bug#8869).
5889 2012-02-23 Chong Yidong <cyd@gnu.org>
5891 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5892 call when setting menu-bar-lines and tool-bar-lines parameters.
5893 (unwind_create_frame_1): New helper function.
5895 * window.c (inhibit_window_configuration_change_hook): New var.
5896 (run_window_configuration_change_hook): Obey it.
5897 (syms_of_window): Initialize it.
5899 2012-02-22 Chong Yidong <cyd@gnu.org>
5901 * xterm.c (x_draw_image_relief): Add missing type check for
5902 Vtool_bar_button_margin (Bug#10743).
5904 2012-02-21 Chong Yidong <cyd@gnu.org>
5906 * fileio.c (Vfile_name_handler_alist): Doc fix.
5908 * buffer.c (Fget_file_buffer): Protect against invalid file
5909 handler return value.
5911 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5913 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5914 when computing $valmask.
5916 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5917 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5918 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5919 It's useless in that case, and it can cause problems on hosts
5920 that allocate halves of EMACS_INT values separately.
5921 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5922 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5923 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5924 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5925 it avoids undefined behavior on hosts where shifting right by more
5926 than the word width has undefined behavior.
5928 2012-02-19 Chong Yidong <cyd@gnu.org>
5930 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5931 (Funhandled_file_name_directory, Ffile_name_as_directory)
5932 (Fdirectory_file_name, Fexpand_file_name)
5933 (Fsubstitute_in_file_name): Protect against invalid file handler
5934 return values (Bug#10845).
5936 2012-02-18 Eli Zaretskii <eliz@gnu.org>
5938 * .gdbinit (pitx): Fix incorrect references to fields of the
5941 2012-02-17 Chong Yidong <cyd@gnu.org>
5943 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5945 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5947 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5948 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5950 2012-02-15 Chong Yidong <cyd@gnu.org>
5952 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5953 marked as special. Also, starting docstrings with * is obsolete.
5955 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5957 * gnutls.c (emacs_gnutls_write): Fix last change.
5959 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5961 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5964 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5966 * keymap.c (Fsingle_key_description): Handle char ranges.
5968 2012-02-12 Chong Yidong <cyd@gnu.org>
5970 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5971 as that creates a dangerous corner case.
5973 * window.c (Fdelete_window_internal): Invalidate the mouse
5974 highlight (Bug#9904).
5976 2012-02-12 Glenn Morris <rgm@gnu.org>
5978 * xselect.c (Fx_own_selection_internal)
5979 (Fx_get_selection_internal, Fx_disown_selection_internal)
5980 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5981 * nsselect.m (Fx_own_selection_internal)
5982 (Fx_disown_selection_internal, Fx_selection_exists_p)
5983 (Fx_selection_owner_p, Fx_get_selection_internal):
5984 Sync docs and argument specs with the xselect.c versions.
5986 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5988 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5990 2012-02-11 Eli Zaretskii <eliz@gnu.org>
5992 * w32select.c (Fx_selection_exists_p): Sync doc string and
5993 argument list with xselect.c. (Bug#10783)
5995 * w16select.c (Fx_selection_exists_p): Sync doc string and
5996 argument list with xselect.c. (Bug#10783)
5998 2012-02-10 Glenn Morris <rgm@gnu.org>
6000 * fns.c (Fsecure_hash): Doc fix.
6002 2012-02-09 Kenichi Handa <handa@m17n.org>
6004 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
6006 2012-02-07 Chong Yidong <cyd@gnu.org>
6008 * buffer.c (Fbuffer_local_variables)
6009 (buffer_lisp_local_variables): Handle unbound vars correctly;
6010 don't let Qunbound leak into Lisp.
6012 2012-02-07 Glenn Morris <rgm@gnu.org>
6014 * image.c (Fimagemagick_types): Doc fix.
6016 * image.c (imagemagick-render-type): Change it from a lisp object
6017 to an integer. Move the doc here from the lisp manual.
6018 Treat all values not equal to 0 the same.
6020 2012-02-06 Chong Yidong <cyd@gnu.org>
6022 * doc.c (store_function_docstring): Avoid applying docstring of
6023 alias to base function (Bug#2603).
6025 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
6027 * .gdbinit (pp1, pv1): Remove redundant defines.
6030 2012-02-04 Chong Yidong <cyd@gnu.org>
6032 * nsterm.m: Declare a global (Bug#10694).
6034 2012-02-04 Eli Zaretskii <eliz@gnu.org>
6036 * w32.c (get_emacs_configuration_options):
6037 Include --enable-checking, if specified, in the return value.
6039 2012-02-04 Martin Rudalics <rudalics@gmx.at>
6041 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
6042 after rounding frame sizes. (Bug#9723)
6044 2012-02-04 Eli Zaretskii <eliz@gnu.org>
6046 * keyboard.c (adjust_point_for_property): Don't position point
6047 before BEGV. (Bug#10696)
6049 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
6051 Handle overflow when computing char display width (Bug#9496).
6052 * character.c (char_width): Return EMACS_INT, not int.
6053 (char_width, c_string_width): Check for overflow when
6054 computing the width; this is possible now that individual
6055 characters can have unbounded width. Problem introduced
6056 by merge from Emacs 23 on 2012-01-19.
6058 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
6060 * dbusbind.c (Fdbus_register_method): Mention the return value
6061 :ignore in the docstring.
6063 2012-02-02 Glenn Morris <rgm@gnu.org>
6065 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
6067 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6068 Unconditionally set to t. (Bug#10673)
6069 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6070 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
6071 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
6073 2012-02-02 Kenichi Handa <handa@m17n.org>
6075 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
6076 0, do not call append_composite_glyph.
6078 2012-02-02 Kenichi Handa <handa@m17n.org>
6080 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
6082 (x_produce_glyphs): If the component of a composition is a null
6083 string, set it->pixel_width to 1 to avoid zero-width glyph.
6085 2012-02-01 Eli Zaretskii <eliz@gnu.org>
6087 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
6088 first 2 arguments are identical. This makes inserting large
6089 output from a subprocess an order of magnitude faster on
6090 MS-Windows, where all sbrk'ed memory is always contiguous.
6092 2012-01-31 Glenn Morris <rgm@gnu.org>
6094 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6095 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
6096 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
6098 2012-01-29 Glenn Morris <rgm@gnu.org>
6100 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
6102 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
6104 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
6106 2012-01-28 Chong Yidong <cyd@gnu.org>
6108 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
6110 2012-01-26 Chong Yidong <cyd@gnu.org>
6112 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
6114 * search.c (Fsearch_forward, Fsearch_backward): Document negative
6115 repeat counts (Bug#10507).
6117 2012-01-26 Glenn Morris <rgm@gnu.org>
6119 * lread.c (syms_of_lread): Doc fix.
6121 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
6123 * coding.c (encode_designation_at_bol): Change return value to
6126 2012-01-25 Chong Yidong <cyd@gnu.org>
6128 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
6130 2012-01-21 Chong Yidong <cyd@gnu.org>
6132 * floatfns.c (Fcopysign): Make the second argument non-optional,
6133 since nil is not allowed anyway.
6135 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
6137 * process.c (read_process_output): Use p instead of XPROCESS (proc).
6138 (send_process): Likewise.
6140 2012-01-19 Martin Rudalics <rudalics@gmx.at>
6142 * window.c (save_window_save, Fcurrent_window_configuration)
6143 (Vwindow_persistent_parameters): Do not use Qstate.
6144 Rewrite doc-strings.
6146 2012-01-19 Kenichi Handa <handa@m17n.org>
6148 * character.c (char_width): New function.
6149 (Fchar_width, c_string_width, lisp_string_width):
6150 Use char_width (Bug#9496).
6152 2012-01-16 Martin Rudalics <rudalics@gmx.at>
6154 * window.c (Vwindow_persistent_parameters): New variable.
6155 (Fset_window_configuration, save_window_save): Handle persistent
6158 2012-01-14 Eli Zaretskii <eliz@gnu.org>
6160 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
6161 thrashing the stack of the thread. (Bug#9087)
6163 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
6165 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
6167 2012-01-11 Eli Zaretskii <eliz@gnu.org>
6169 * xdisp.c (rows_from_pos_range): Handle the case where the
6170 highlight ends on a newline. (Bug#10464)
6171 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
6172 he end column for display of highlight that ends on a newline
6175 2012-01-11 Glenn Morris <rgm@gnu.org>
6177 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
6178 from load-path also when installation-directory is nil. (Bug#10208)
6180 2012-01-10 Glenn Morris <rgm@gnu.org>
6182 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
6184 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
6185 Update template values to be closer to their typical values these days.
6187 2012-01-09 Eli Zaretskii <eliz@gnu.org>
6189 * xdisp.c (rows_from_pos_range): Accept additional argument
6190 DISP_STRING, and accept any glyph in a row whose object is that
6191 string as eligible for mouse highlight. Fixes mouse highlight of
6192 display strings from overlays. (Bug#10464)
6194 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
6196 emacs: fix an auto-save permissions race condition (Bug#10400)
6197 * fileio.c (auto_saving_dir_umask): New static var.
6198 (Fmake_directory_internal): Use it.
6199 (do_auto_save_make_dir): Set it, instead of invoking chmod after
6200 creating the directory. The old code temporarily assigns
6201 too-generous permissions to the directory.
6202 (do_auto_save_eh): Clear it.
6203 (Fdo_auto_save): Catch all errors, not just file errors, so
6204 that the var is always cleared.
6206 2012-01-07 Eli Zaretskii <eliz@gnu.org>
6208 * search.c (scan_buffer): Pass character positions to
6209 know_region_cache, not byte positions. (Bug#6540)
6211 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
6213 * w32.c (sys_rename): Report EXDEV when rename of a directory
6214 fails because the target is on another logical disk. (Bug#10284)
6216 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
6218 * xterm.c (x_embed_request_focus): New function.
6220 * xterm.h: Add prototype.
6222 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
6224 2012-01-05 Glenn Morris <rgm@gnu.org>
6226 * emacs.c (emacs_copyright): Update short copyright year to 2012.
6228 2012-01-01 Eli Zaretskii <eliz@gnu.org>
6230 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
6231 Load gnutls_transport_set_lowat only if GnuTLS version is below
6233 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
6234 GnuTLS versions below 2.11.1.
6236 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
6238 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
6239 to the doc string advising against its use for altering the way
6240 windows are scrolled.
6242 2011-12-28 Kenichi Handa <handa@m17n.org>
6244 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
6245 coding-system ASCII compatible only when it does not produce BOM
6246 on encoding (Bug#10383).
6248 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
6250 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
6252 (create_and_show_popup_menu): Always use menu_position_func for
6255 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
6257 * callint.c (Fcall_interactively): Don't truncate prompt string.
6259 2011-12-23 Eli Zaretskii <eliz@gnu.org>
6261 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
6262 property that ends at ZV, so that the bidi iteration could be
6263 resumed from there (after widening). (Bug#10360)
6265 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
6267 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
6269 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
6271 * nsterm.m (x_free_frame_resources):
6272 Release f->output_data.ns->miniimage.
6273 (ns_index_color): Fix indentation. Do not retain
6274 color_table->colors[i].
6276 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
6279 * nsfns.m (x_set_background_color): Assign return value from
6280 ns_index_color to face-background instead of NSColor*.
6281 (ns_implicitly_set_icon_type): Fix indentation.
6282 Change assignment in for loop to comparison.
6284 * emacs.c (ns_pool): New variable.
6285 (main): Assign ns_pool.
6286 (Fkill_emacs): Call ns_release_autorelease_pool.
6288 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
6289 autorelease fdesc, release fdAttrs and tdict.
6290 (ns_get_covering_families): Release charset.
6291 (ns_findfonts): Release NSFontDescriptor created with new.
6292 (ns_uni_to_glyphs): Fix indentation.
6293 (setString): Release attrStr before assigning new value.
6295 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
6297 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
6299 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
6300 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
6302 2011-12-18 David Reitter <reitter@cmu.edu>
6304 * nsterm.m (ns_term_init): Subscribe for notifications
6305 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
6306 to method trackingNotification in EmacsMenu.
6308 * nsmenu.m (trackingMenu): New variable.
6309 (trackingNotification): New method (from Aquamacs).
6310 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
6311 from Aquamacs (Bug#7030).
6313 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
6315 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
6316 (symbol_to_nsstring): Fix indentation.
6317 (ns_symbol_to_pb): New function.
6318 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
6319 (Fns_rotate_cut_buffers_internal): Remove.
6320 (Fns_store_selection_internal): Rename from
6321 Fns_store_cut_buffer_internal.
6322 (ns_get_foreign_selection, Fx_own_selection_internal)
6323 (Fx_disown_selection_internal, Fx_selection_exists_p)
6324 (Fns_get_selection_internal, Fns_store_selection_internal):
6325 Use ns_symbol_to_pb and check if return value is nil.
6326 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
6327 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
6328 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
6329 renamed to Sns_store_selection_internal.
6330 (ns_handle_selection_request): Move code to Fx_own_selection_internal
6331 and remove this function.
6332 (ns_handle_selection_clear): Remove, never used.
6333 (Fx_own_selection_internal): Move code from ns_handle_selection_request
6336 2011-12-17 Ken Brown <kbrown@cornell.edu>
6338 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
6339 GID is unknown (Bug#10257).
6341 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
6343 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
6344 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
6345 which caused a build failure on GNU/Linux IA-64. This problem was
6346 introduced by my 2011-10-07 patch.
6348 2011-12-15 Juri Linkov <juri@jurta.org>
6350 * image.c (imagemagick_error): New function. (Bug#10112)
6351 (imagemagick_load_image): Comment out `MagickSetResolution' call.
6352 Use `imagemagick_error' where ImageMagick functions return
6354 (Fimagemagick_types): Add `Fnreverse' to return the list in the
6357 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6359 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
6360 fill background (Bug#8992).
6362 2011-12-13 Martin Rudalics <rudalics@gmx.at>
6364 * window.c (Vwindow_combination_resize)
6365 (Vwindow_combination_limit): Use t instead of non-nil in
6367 (Vrecenter_redisplay): Add first sentence of doc-string on
6369 (Frecenter): Fix doc-string typo.
6371 2011-12-11 Kenichi Handa <handa@m17n.org>
6373 * coding.c (Funencodable_char_position): Pay attention to the
6374 buffer text relocation (Bug#9389).
6376 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
6378 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
6379 gtk_init (Bug#10100).
6381 2011-12-10 Eli Zaretskii <eliz@gnu.org>
6383 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
6384 IT->string is nil. (Bug#10263)
6386 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
6388 * nsterm.h (x_free_frame_resources): Declare.
6390 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
6391 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
6393 * nsterm.h (ns_get_defaults_value): Declare.
6395 * nsterm.m (ns_default): Call ns_get_defaults_value.
6397 2011-12-09 Eli Zaretskii <eliz@gnu.org>
6399 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
6402 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6404 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
6405 that where the value of an _OBJC_* symbol points to is in the .bss
6406 section (Bug#10240).
6408 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6410 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
6411 after the loop to call ccl_driver at least once (Bug#8619).
6413 2011-12-08 Kenichi Handa <handa@m17n.org>
6415 * ftfont.c (get_adstyle_property): Fix previous change
6418 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
6420 * w32.c (init_environment): If no_site_lisp, remove site-lisp
6421 dirs from the default value of EMACSLOADPATH (bug#10208).
6423 2011-12-07 Glenn Morris <rgm@gnu.org>
6425 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
6426 installation and source directories as well. (Bug#10208)
6428 2011-12-06 Chong Yidong <cyd@gnu.org>
6430 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
6432 2011-12-06 Glenn Morris <rgm@gnu.org>
6434 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
6435 as an error, not just -1. (Bug#10217)
6437 2011-12-05 Chong Yidong <cyd@gnu.org>
6439 * keyboard.c (process_special_events): New function.
6440 (swallow_events, Finput_pending_p): Use it (Bug#10195).
6442 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
6444 * coding.c (encode_designation_at_bol): Don't use uninitialized
6445 local variable (Bug#9318).
6447 2011-12-05 Kenichi Handa <handa@m17n.org>
6449 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
6450 return Qnil (Bug#8046, Bug#10193).
6452 2011-12-05 Kenichi Handa <handa@m17n.org>
6454 * coding.c (encode_designation_at_bol): New args charbuf_end and
6455 dst. Return the number of produced bytes. Callers changed.
6456 (coding_set_source): Return how many bytes coding->source was
6458 (coding_set_destination): Return how many bytes
6459 coding->destination was relocated.
6460 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
6461 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
6463 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6465 * coding.c (CODING_CHAR_CHARSET_P): New macro.
6466 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
6469 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
6471 The following changes are to fix Bug#9318.
6473 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
6474 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
6475 (encode_coding_iso_2022, encode_coding_sjis)
6476 (encode_coding_big5, encode_coding_charset): Use the above macros.
6478 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
6480 * lisp.h (process_quit_flag): Fix external declaration.
6482 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
6484 Don't macro-inline non-performance-critical code.
6485 * eval.c (process_quit_flag): New function.
6486 * lisp.h (QUIT): Use it.
6488 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
6490 * nsfns.m (get_geometry_from_preferences): New function.
6491 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
6493 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
6495 * emacs.c (Qkill_emacs): Define.
6496 (syms_of_emacs): Initialize it.
6497 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
6498 Qquit_flag to `kill-emacs' instead.
6499 (quit_throw_to_read_char): Add parameter `from_signal'.
6500 All callers changed. Call Fkill_emacs if requested and safe.
6501 * lisp.h (QUIT): Call Fkill_emacs if requested.
6503 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
6505 * widget.c (update_wm_hints): Return if wmshell is null.
6506 (widget_update_wm_size_hints): New function.
6508 * widget.h (widget_update_wm_size_hints): Declare.
6510 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
6511 widget_update_wm_size_hints (Bug#10104).
6513 2011-12-03 Eli Zaretskii <eliz@gnu.org>
6515 * xdisp.c (handle_invisible_prop): If the invisible text ends just
6516 before a newline, prepare the bidi iterator for consuming the
6517 newline, and keep the current paragraph direction. (Bug#10183)
6518 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
6520 2011-12-02 Juri Linkov <juri@jurta.org>
6522 * search.c (Fword_search_regexp): New Lisp function created from
6523 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
6524 (Fword_search_backward, Fword_search_forward)
6525 (Fword_search_backward_lax, Fword_search_forward_lax):
6526 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
6527 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
6529 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
6531 * fileio.c (Finsert_file_contents): Move after-change-function call
6532 to before the "handled:" label, since all "goto handled" appear in
6533 cases where the *-change-functions have already been properly called
6536 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
6538 * keyboard.c (interrupt_signal): Don't call kill-emacs when
6539 waiting for input. (Bug#10169)
6541 2011-11-30 Eli Zaretskii <eliz@gnu.org>
6543 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
6544 verifies glyph row's hash code--we have just reallocated the
6545 glyphs, so their contents can be complete garbage. (Bug#10164)
6547 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
6549 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
6551 2011-11-30 Eli Zaretskii <eliz@gnu.org>
6553 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
6554 attributes are tested _before_ calling verify_row_hash, to protect
6555 against GCC re-ordering of the tests. (Bug#10164)
6557 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
6559 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
6561 * xterm.c (handle_one_xevent): Only set async_visible and friends
6562 if net_wm_state_hidden_seen is non-zero (Bug#10002)
6563 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
6564 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
6566 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
6568 Remove GCPRO-related macros that exist only to avoid shadowing locals.
6569 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
6570 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6571 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6572 All uses changed to use GCPRO1 etc.
6573 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6574 Revert to old implementation (i.e., before 2011-03-11).
6576 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6578 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6579 of scroll runs so as to avoid assigning disabled bogus rows and
6580 unnecessary graphics copy operations.
6582 2011-11-27 Eli Zaretskii <eliz@gnu.org>
6584 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6585 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6586 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6587 (malloc, free, realloc, calloc): Redirect to e_* only when
6590 * lisp.h (GCTYPEBITS): Move before first use.
6591 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6592 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6593 this macro definition.
6595 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6598 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6600 * gtkutil.c (xg_create_frame_widgets):
6601 Call gtk_window_set_has_resize_grip (FALSE) if that function is
6602 present with Gtk+ 2.0.
6604 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6606 * fileio.c (Finsert_file_contents): Undo previous change; see
6607 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6609 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6611 Rename locals to avoid shadowing.
6612 * fileio.c (Finsert_file_contents):
6613 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6614 * process.c (wait_reading_process_output):
6615 Rename inner 'proc' to 'p' to avoid shadowing.
6616 Indent for consistency with usual Emacs style.
6618 2011-11-25 Eli Zaretskii <eliz@gnu.org>
6620 * xdisp.c (redisplay_window): If cursor row is not fully visible
6621 after recentering, and scroll-conservatively is set to a large
6622 number, scroll window by a few more lines to make the cursor fully
6623 visible and out of scroll-margin. (Bug#10105)
6624 (start_display): Don't move to the next line if the display should
6625 start at a newline that is part of a display vector or an overlay
6628 2011-11-24 Juri Linkov <juri@jurta.org>
6630 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6631 after the `MagickPingImage' call. (Bug#10112)
6633 2011-11-23 Chong Yidong <cyd@gnu.org>
6635 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6637 2011-11-23 Martin Rudalics <rudalics@gmx.at>
6639 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6640 making another buffer current. (Bug#10114)
6642 2011-11-23 Glenn Morris <rgm@gnu.org>
6644 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6646 2011-11-23 Chong Yidong <cyd@gnu.org>
6648 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6649 using it (Bug#5984).
6651 2011-11-22 Eli Zaretskii <eliz@gnu.org>
6653 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6654 and header-lines, as they don't have one computed for them.
6657 * .gdbinit (prow): Make displayed values more self-explaining.
6658 Add row's hash code.
6660 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6662 * process.c (wait_reading_process_output): Fix asynchrounous
6663 GnuTLS socket handling on some versions of the GnuTLS library.
6664 (wait_reading_process_output): Add comment and URL.
6666 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6668 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6670 2011-11-21 Chong Yidong <cyd@gnu.org>
6672 * window.c (Fnext_window, Fprevious_window): Doc fix.
6674 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6676 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6678 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
6680 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6682 2011-11-20 Martin Rudalics <rudalics@gmx.at>
6684 * window.c (Fset_window_combination_limit): Rename argument
6686 (Vwindow_combination_limit): Remove "status" from doc-string.
6688 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6690 * m/ibms390.h: Remove.
6691 * m/ibms390x.h: Don't include "ibms390.h".
6693 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6695 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6696 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6698 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
6700 * casetab.c (Fset_case_table):
6701 * charset.c (Fcharset_after): Fix typos.
6703 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6705 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6706 Otherwise, valgrind does not work on some platforms.
6707 Problem reported by Andreas Schwab in
6708 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6709 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6710 is set, removing the need for VIRT_ADDRESS_VARIES.
6711 (PURE_P): Use a more-efficient implementation that needs just one
6712 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6713 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6714 to 4 (xorl, subq, cmpq, setbe).
6715 * alloc.c (pure): Always extern now, since that's the
6716 VIRT_ADDR_VARIES behavior.
6717 (PURE_POINTER_P): Use a single comparison, not two, for
6718 consistency with the new puresize.h.
6719 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6720 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6721 Remove VIRT_ADDR_VARIES no longer needed.
6723 2011-11-19 Eli Zaretskii <eliz@gnu.org>
6725 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6726 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6727 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6728 behave as if the cursor position were at the window margin.
6730 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6731 and the cursor position is out of bounds, behave as if the cursor
6732 position were at the window margin. (Bug#10075)
6734 2011-11-18 Chong Yidong <cyd@gnu.org>
6736 * window.c (Fwindow_combination_limit): Make first argument
6737 non-optional, since it is meaningless for live windows like the
6740 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6742 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6744 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6746 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6747 (graft_intervals_into_buffer): Simplify.
6749 2011-11-18 Eli Zaretskii <eliz@gnu.org>
6751 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6752 hash values of the two rows.
6753 (copy_row_except_pointers): Preserve the used[] arrays and the
6754 hash values of the two rows. (Bug#10035)
6755 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
6757 * xdisp.c (row_hash): New function, body extracted from
6758 compute_line_metrics.
6759 (compute_line_metrics): Call row_hash, instead of computing the
6762 * dispnew.c (verify_row_hash): Call row_hash for computing the
6763 hash code of a row, instead of duplicating code from xdisp.c.
6765 * dispextern.h (row_hash): Add prototype.
6767 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6769 * frame.c (delete_frame): Don't delete the terminal when the last
6770 X frame is closed if emacs is built with GTK toolkit.
6772 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
6774 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6776 2011-11-17 Martin Rudalics <rudalics@gmx.at>
6778 * window.c (Vwindow_splits): Rename to
6779 Vwindow_combination_resize. Suggested by Juri Linkov.
6780 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6783 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
6785 * nsfns.m (Fns_font_name):
6786 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
6788 2011-11-16 Martin Rudalics <rudalics@gmx.at>
6790 * window.h (window): Rename slot "nest" to "combination_limit".
6791 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6792 (Fset_window_nest): Rename to Fset_window_combination_limit.
6793 (Vwindow_nest): Rename to Vwindow_combination_limit.
6794 (recombine_windows, make_parent_window, make_window)
6795 (Fsplit_window_internal, saved_window)
6796 (Fset_window_configuration, save_window_save): Rename all
6797 occurrences of window_nest to window_combination_limit.
6799 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
6801 * image.c (imagemagick_load_image): Fix typo.
6803 2011-11-14 Eli Zaretskii <eliz@gnu.org>
6805 * xdisp.c (display_line): Move the call to
6806 highlight_trailing_whitespace before the call to
6807 compute_line_metrics, since the latter needs to see the final
6808 faces of all the glyphs to compute ROW's hash value.
6809 Fixes assertion violations in row_equal_p. (Bug#10035)
6811 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
6813 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6814 just return (bug#10044).
6816 2011-11-12 Eli Zaretskii <eliz@gnu.org>
6818 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6819 with user-defined heap size. Bump the default size of the temacs
6820 heap to 27MB, to avoid memory warning when running temacs.
6821 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6823 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6824 current_matrix and desired_matrix. (Bug#9990)
6825 (verify_row_hash) [XASSERTS]: New function.
6826 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6827 that the hash value of glyph rows is correct.
6829 2011-11-12 Martin Rudalics <rudalics@gmx.at>
6831 * window.h (window): Remove splits slot.
6832 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6833 (Fdelete_other_windows_internal, make_parent_window)
6834 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6835 (Fset_window_configuration, save_window_save): Don't deal with
6836 split status of windows.
6837 (saved_window): Remove splits slot.
6838 (Vwindow_splits): Rewrite doc-string.
6840 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6842 * xfns.c (unwind_create_frame):
6843 * nsfns.m (unwind_create_frame):
6844 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6845 Vframe_list (Bug#9999).
6847 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6849 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
6851 2011-11-11 Kenichi Handa <handa@m17n.org>
6853 * callproc.c (Fcall_process): Set the member dst_multibyte of
6856 2011-11-11 Johan Bockgård <bojohan@gnu.org>
6858 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6859 avoid a crash (bug#9496).
6861 2011-11-09 Chong Yidong <cyd@gnu.org>
6863 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6864 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6866 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6868 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6870 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6872 Avoid some portability problems by eschewing 'extern inline' functions.
6873 The trivial performance wins aren't worth the portability hassles; see
6874 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6876 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6877 (window_box_width, window_box_left, window_box_left_offset)
6878 (window_box_right, window_box_right_offset): Undo previous change,
6879 by removing the "extern"s.
6880 * intervals.c (adjust_intervals_for_insertion)
6881 (adjust_intervals_for_deletion): Undo previous change,
6882 making these static again.
6883 (offset_intervals, temp_set_point_both, temp_set_point)
6884 (copy_intervals_to_string): No longer inline.
6885 * xdisp.c (window_text_bottom_y, window_box_width)
6886 (window_box_height, window_box_left_offset)
6887 (window_box_right_offset, window_box_left, window_box_right)
6888 (window_box): No longer inline.
6890 2011-11-08 Chong Yidong <cyd@gnu.org>
6892 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6893 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6894 Signal an error if not a live window.
6895 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6896 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6898 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
6900 * lisp.h (syms_of_abbrev): Remove declaration.
6901 Reported by CHENG Gao <chenggao@royau.me>.
6903 2011-11-07 Eli Zaretskii <eliz@gnu.org>
6905 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6906 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6907 of temacs in GUI mode.
6909 2011-11-07 Martin Rudalics <rudalics@gmx.at>
6911 * window.h: Declare delete_all_child_windows instead of
6912 delete_all_subwindows.
6913 * window.c (Fwindow_nest, Fset_window_nest)
6914 (Fset_window_new_total, Fset_window_new_normal)
6915 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6916 (delete_all_subwindows): Rename to delete_all_child_windows.
6917 (Fdelete_other_windows_internal, Fset_window_configuration):
6918 Call delete_all_child_windows instead of delete_all_subwindows.
6919 * frame.c (delete_frame): Call delete_all_child_windows instead
6920 of delete_all_subwindows.
6922 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6924 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6925 This is also needed for porting to any host where GC_MARK_STACK is
6926 not GC_MAKE_GCPROS_NOOPS.
6927 (which_symbols): Use it.
6929 2011-11-07 Kenichi Handa <handa@m17n.org>
6931 * coding.c (coding_set_destination): Check coding->src_pos only
6932 when coding->src_object is a buffer (bug#9910).
6934 * process.c (send_process): Set the member src_multibyte of coding
6935 to 0 (bug#9911) when sending a unibyte text.
6937 * callproc.c (Fcall_process): Set the member src_multibyte of
6938 process_coding to 0 (bug#9912).
6940 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6942 * xmenu.c (cleanup_widget_value_tree): New function.
6943 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6944 calling free_menubar_widget_value_tree directly (Bug#9830).
6946 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6948 Fix some portability problems with 'inline'.
6949 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6950 (window_box_width, window_box_left, window_box_left_offset)
6951 (window_box_right, window_box_right_offset): Declare extern.
6952 Otherwise, these inline functions do not conform to C99 and
6953 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6954 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6955 * intervals.c (adjust_intervals_for_insertion)
6956 (adjust_intervals_for_deletion): Now extern, because otherwise the
6957 extern inline functions 'offset_intervals' couldn't refer to it.
6958 (static_offset_intervals): Remove.
6959 (offset_intervals): Rewrite using the old contents of
6960 static_offset_intervals. The old version didn't conform to C99
6961 because an extern inline function contained a reference to an
6962 identifier with static linkage.
6964 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6966 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6969 2011-11-06 Eli Zaretskii <eliz@gnu.org>
6971 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6972 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6973 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6974 return Qleft_to_right.
6976 2011-11-06 Chong Yidong <cyd@gnu.org>
6978 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6979 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6980 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6981 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6982 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6983 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6984 (Fwindow_vscroll): Doc fix.
6985 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6986 argument, since it makes no sense to pass a live window and for
6987 consistency with window-child.
6989 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6991 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6994 2011-11-05 Jason Rumney <jasonr@gnu.org>
6996 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6997 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6999 (add_font_entity_to_list): Fix logic errors in mixed boolean and
7000 bitwise arithmetic preventing use of unicode-sip and non-truetype
7003 2011-11-05 Eli Zaretskii <eliz@gnu.org>
7005 * s/ms-w32.h (fstat, stat, utime): Move redirections to
7008 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
7009 initialization code to keep similarity to xfns.c after changes
7012 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
7014 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
7015 (unwind_create_frame): New function (Bug#9943).
7016 (Fx_create_frame): Restructure code to be more similar to the one in
7017 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
7018 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
7019 Move terminal->reference_count++ just before making the frame official
7022 * nsterm.m (x_free_frame_resources): New function.
7023 (x_destroy_window): Move code to x_free_frame_resources.
7025 * xfns.c (unwind_create_frame): Fix comment.
7026 (Fx_create_frame, x_create_tip_frame):
7027 Move terminal->reference_count++ just before making the frame
7028 official. Move initialization of image_cache_refcount and
7029 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
7031 2011-11-05 Eli Zaretskii <eliz@gnu.org>
7033 Support MSVC build with newer versions of Visual Studio.
7034 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
7035 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
7038 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
7039 which are not supported by MSVC.
7040 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
7041 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
7043 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
7045 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
7047 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
7049 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
7051 Support MSVC build with newer versions of Visual Studio.
7052 * w32.c: Don't include w32api.h for MSVC.
7053 (init_environment) [_MSC_VER]: Call sys_access, not _access.
7055 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
7056 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
7057 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
7058 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
7060 (alloca) [_MSC_VER]: Define to _alloca.
7062 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
7064 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
7066 2011-11-04 Eli Zaretskii <eliz@gnu.org>
7068 * xdisp.c (note_mouse_highlight): If either of
7069 previous/next-single-property-change returns nil, treat that as
7070 the beginning or the end of the buffer. (Bug#9955)
7072 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
7074 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
7075 label is not null (Bug#9951).
7076 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
7079 2011-11-04 Eli Zaretskii <eliz@gnu.org>
7081 * window.c (Fwindow_body_size): Mention in the doc string that the
7082 return value is in frame's canonical units. (Bug#9949)
7084 2011-11-03 Eli Zaretskii <eliz@gnu.org>
7086 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
7088 * w32fns.c (unwind_create_frame): If needed, free the glyph
7089 matrices of the partially constructed frame. (Bug#9943)
7090 * xfns.c (unwind_create_frame): Likewise.
7092 2011-11-01 Eli Zaretskii <eliz@gnu.org>
7094 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
7095 Don't stop backward scan on the continuation glyph, even though
7096 its CHARPOS is positive.
7097 (mouse_face_from_buffer_pos, note_mouse_highlight):
7098 Rename cover_string to disp_string.
7100 2011-11-01 Martin Rudalics <rudalics@gmx.at>
7102 * window.c (temp_output_buffer_show): Don't use
7103 Vtemp_buffer_show_specifiers.
7104 (Vtemp_buffer_show_specifiers): Remove unused variable.
7106 2011-10-30 Eli Zaretskii <eliz@gnu.org>
7108 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
7109 past the beginning of the current glyph matrix.
7111 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
7113 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
7114 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
7115 HAVE_GTK3 (Bug#9869).
7117 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
7118 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
7120 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
7122 * xterm.c: Declare x_handle_net_wm_state to return int.
7123 (handle_one_xevent): Check if we are iconified but don't have
7124 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
7125 (get_current_wm_state): Return non-zero if not hidden,
7126 check for _NET_WM_STATE_HIDDEN (Bug#9893).
7127 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
7128 (x_handle_net_wm_state): Return what get_current_wm_state returns.
7129 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
7131 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
7133 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
7134 so that this new function doesn't get optimized away by a
7135 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
7137 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7139 * frame.h (MOUSE_HL_INFO): Remove excess parens.
7141 2011-10-29 Eli Zaretskii <eliz@gnu.org>
7143 Fix the `xbytecode' command.
7144 * .gdbinit (xprintbytestr): New command.
7145 (xwhichsymbols): Rename from `which'; all callers changed.
7146 (xbytecode): Print the byte-code string as well.
7148 2011-10-29 Kim Storm <storm@cua.dk>
7150 * alloc.c (which_symbols): New function.
7152 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7154 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
7157 2011-10-29 Glenn Morris <rgm@gnu.org>
7159 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
7160 Not clear what it was for, and it causes various bugs. (Bug#9839)
7162 2011-10-28 Eli Zaretskii <eliz@gnu.org>
7164 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
7165 possible random value that matches one of those tested as
7166 condition to clear the mouse face.
7168 2011-10-28 Chong Yidong <cyd@gnu.org>
7170 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
7172 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
7174 * window.c (make_window): Initialize phys_cursor_on_p.
7176 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
7178 * lisp.h (struct Lisp_Symbol): Update comments.
7180 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
7182 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
7184 2011-10-28 Eli Zaretskii <eliz@gnu.org>
7186 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
7187 <oslsachem@gmail.com> for helping to debug this.
7189 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
7190 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
7191 (g_b_init_get_glyph_outline_w): New static variables.
7192 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
7193 (GetGlyphOutlineW_Proc): New typedefs.
7194 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
7195 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
7197 (w32font_open_internal, compute_metrics):
7198 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
7199 instead of calling the "wide" APIs directly.
7201 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
7203 * w32.h (syms_of_w32font): Add prototype.
7205 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
7207 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
7208 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
7209 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
7210 (Fmove_to_window_line): Doc fix.
7212 2011-10-27 Chong Yidong <cyd@gnu.org>
7214 * process.c (make_process): Set gnutls_state to NULL.
7216 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
7217 non-NULL, regardless of GNUTLS_INITSTAGE.
7218 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
7219 an error. Set process slots as soon as we allocate them.
7221 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
7223 2011-10-27 Chong Yidong <cyd@gnu.org>
7225 * gnutls.c (emacs_gnutls_deinit): New function.
7226 Deallocate credentials structures as well as calling gnutls_deinit.
7227 (Fgnutls_deinit, Fgnutls_boot): Use it.
7229 * process.c (make_process): Initialize GnuTLS credentials to NULL.
7230 (deactivate_process): Call emacs_gnutls_deinit.
7232 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
7234 * image.c (x_create_x_image_and_pixmap):
7235 * w32.c (sys_rename, w32_delayed_load):
7236 * w32font.c (fill_in_logfont):
7237 * w32reg.c (x_get_string_resource): Silence compiler warnings.
7239 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
7241 * w32fns.c (w32_default_color_map): New function,
7242 extracted from Fw32_default_color_map.
7243 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
7245 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
7247 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
7249 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
7251 * keyboard.c (test_undefined): New function (bug#9751).
7252 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
7254 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
7256 * sysdep.c (init_sys_modes): Fix the check for the controlling
7257 terminal (Bug#6649).
7259 2011-10-20 Eli Zaretskii <eliz@gnu.org>
7261 * dispextern.h (struct bidi_it): New member next_en_type.
7263 * bidi.c (bidi_line_init): Initialize the next_en_type member.
7264 (bidi_resolve_explicit_1): When next_en_pos is valid for the
7265 current character, check also for next_en_type being WEAK_EN.
7266 (bidi_resolve_weak): Don't enter the expensive loop if the current
7267 position is before next_en_pos. Record the bidi type of the first
7268 non-ET, non-BN character we find, in addition to its position.
7269 (bidi_level_of_next_char): Invalidate next_en_type when
7270 next_en_pos is over-stepped.
7272 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
7274 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
7275 * editfns.c: Rewrite current-time-zone so that it invokes
7276 the equivalent of (format-time-string "%Z") to get the time zone name.
7277 This fixes a bug when the time zone name contains characters that
7278 need converting from the system time locale to Emacs internal format.
7279 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
7280 that patch fixed format-time-string to do the conversion, but
7281 I forgot to fix current-time-zone.
7282 (format_time_string): New function, containing most of
7283 what Fformat_time_string used to contain.
7284 (Fformat_time_string): Rewrite in terms of format_time_string.
7285 This doesn't change this function's behavior.
7286 (current-time-zone): Rewrite to use format_time_string.
7287 This fixes the bug reported by Michael Schierl in
7288 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
7289 Jason Rumney's 2007-06-07 change worked around this bug, but
7291 * systime.h (tzname, timezone): Remove no-longer-used declarations.
7293 2011-10-19 Eli Zaretskii <eliz@gnu.org>
7295 * xdisp.c (start_display): If the character at POS is displayed
7296 via a display vector, reset IT->current.dpvec_index to zero.
7297 (try_window_reusing_current_matrix): If a line ends in a display
7298 vector or the next line starts in a display vector, continue
7299 redrawing the window even though the character position of
7300 start_row was reached.
7303 2011-10-18 Chong Yidong <cyd@gnu.org>
7305 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
7306 with nobreak-char-display too.
7308 2011-10-18 Eli Zaretskii <eliz@gnu.org>
7310 Fix part 3 of bug#9771.
7311 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
7312 (bidi_resolve_neutral): Don't enter the expensive loop looking for
7313 non-neutral characters if the current character is a paragraph
7314 separator (a.k.a. Newline). This avoids running the same
7315 expensive loop twice, once when we consume the preceding newline
7316 and the other time when the line actually needs to be displayed.
7317 Avoid the loop when we see neutrals on the base embedding level
7318 following a character whose directionality is the same as the
7319 paragraph's. This avoids running the expensive loop when a line
7320 ends in a long sequence of neutrals, like control characters.
7321 Add assertion against STRONG_AL type. Slightly rearrange code
7322 that determines the type of a neutral given the first non-neutral
7324 (bidi_level_of_next_char): Set next_en_pos to zero when
7325 invalidating its info.
7327 2011-10-17 Eli Zaretskii <eliz@gnu.org>
7329 * xdisp.c (push_display_prop): Determine whether to record string
7330 or buffer position by IT->string, not by IT->method. Allow
7331 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
7332 (move_it_vertically_backward): Don't look for character position
7333 immediately after the newline when in a continuation line.
7336 2011-10-15 Martin Rudalics <rudalics@gmx.at>
7338 * window.c (coordinates_in_window): Rewrite and delabelize
7339 vertical border check. (Bug#5357) (Bug#9618)
7341 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
7343 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
7344 errors in XSetWindowBorder (bug#9310).
7346 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
7348 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
7349 avoid crash when xmalloc overrun checking is enabled.
7351 2011-10-13 Eli Zaretskii <eliz@gnu.org>
7353 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
7354 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
7355 cursor motion with <left> and <right> arrow keys.
7357 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
7358 some callers set that themselves.
7360 2011-10-12 Eli Zaretskii <eliz@gnu.org>
7362 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
7363 display string and the previous row comes from the same string and
7364 is empty. (Bug#9739) (Bug#9738)
7366 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
7368 * doc.c (get_doc_string): Encode file name (bug#9735).
7370 2011-10-12 Eli Zaretskii <eliz@gnu.org>
7372 * bidi.c (bidi_level_of_next_char):
7373 * xdisp.c (get_visually_first_element): Remove old incorrect
7374 comments regarding the Unicode Line Separator character.
7376 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
7378 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
7380 * alloc.c (Fgc_status): Do not access beyond zombies array
7381 boundary if nzombies > MAX_ZOMBIES.
7382 * alloc.c (dump_zombies): Add missing format specifier.
7384 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
7386 * xdisp.c (set_cursor_from_row): Simplify conditionals,
7387 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
7389 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
7390 Some packages use them to denote characters with modifiers.
7392 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
7394 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
7395 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
7396 matching a pp-number. Rename parameter var to var1.
7398 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
7400 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
7402 2011-10-08 Glenn Morris <rgm@gnu.org>
7404 * callint.c (Fcall_interactively): Give a more explicit error for the
7405 'c' case with a non-character input. (Bug#8479)
7407 2011-10-08 Eli Zaretskii <eliz@gnu.org>
7409 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
7411 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
7412 lines that are hscrolled on the left.
7414 * dispnew.c (buffer_posn_from_coords): Account for a possible
7415 presence of header-line. (Bug#4426)
7417 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
7419 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
7420 Don't advertise functionality which we discourage or doesn't work.
7422 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
7424 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
7425 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
7426 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
7427 this makes Emacs dump core during garbage collection on rare
7428 occasions. sizeof is obviously inferior to offsetof here, so
7429 stick with offsetof.
7430 (GC_POINTER_ALIGNMENT): New macro.
7431 (mark_memory): Omit 3rd (offset) arg; caller changed.
7432 Don't assume EMACS_INT alignment is the same as pointer alignment.
7434 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
7436 * keyboard.c (read_key_sequence_remapped): New var.
7437 (read_key_sequence): Compute remapping in the right buffer.
7438 (command_loop_1): Use read_key_sequence's remapping directly.
7440 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
7442 * dired.c (file_name_completion): Don't expand file name.
7443 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
7444 before checking file name handler.
7446 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
7447 they've been requested explicitly (bug#9591).
7449 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
7451 * keymap.c (Fsingle_key_description): Use make_specified_string
7452 instead of build_string to build string from push_key_description.
7455 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7457 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
7458 This fixes a Y2038 bug on 64-bit hosts.
7459 * buffer.c (reset_buffer):
7460 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
7461 (Fclear_buffer_auto_save_failure):
7462 Use 0, not -1, to represent an unset failure time, since time_t
7463 might not be signed.
7465 Remove dependency on glibc malloc internals.
7466 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7467 Move back here from lisp.h, but with their new implementations.
7468 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7469 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
7470 * charset.c (charset_table_init): New static var.
7471 (syms_of_charset): Use it instead of xmalloc. This removes a
7472 dependency on glibc malloc internals. See Eli Zaretskii's comment in
7473 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
7474 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7475 Move back to alloc.c.
7476 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7477 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
7479 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
7481 * nsterm.m (windowDidResize): Call x_set_window_size only when
7482 ns_in_resize is true. Otherwise set pixelwidth/height and
7483 call change_frame_size (Bug#9628).
7485 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7487 Port --enable-checking=all to Fedora 14 x86-64.
7488 * charset.c (syms_of_charset): Also account for glibc malloc's
7489 internal overhead when calculating the initial malloc maximum.
7491 Port --enable-checking=all to Fedora 14 x86.
7492 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7494 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
7495 (overrun_check_realloc, overrun_check_free):
7496 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
7497 That way, xmalloc returns a properly-aligned pointer even if
7498 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
7499 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
7500 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
7501 into account when calculating the initial malloc maximum.
7502 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7503 Move here from alloc.c, so that charset.c can use it too.
7504 Properly align; the old code wasn't right for common 32-bit hosts
7505 when configured with --enable-checking=all.
7506 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7507 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
7509 2011-09-29 Eli Zaretskii <eliz@gnu.org>
7511 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
7514 2011-09-28 Eli Zaretskii <eliz@gnu.org>
7516 * xdisp.c (compute_display_string_end): If there's no display
7517 string at CHARPOS, return -1.
7519 * bidi.c (bidi_fetch_char): When compute_display_string_end
7520 returns a negative value, treat the character as a normal
7521 character not covered by a display string. (Bug#9624)
7523 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
7525 * lread.c (Fread_from_string): Fix typo in docstring.
7527 2011-09-27 Eli Zaretskii <eliz@gnu.org>
7529 * xdisp.c (handle_invisible_prop): If invisible text ends on a
7530 newline, reseat the iterator instead of bidi-iterating there one
7531 character at a time. (Bug#9610)
7532 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
7533 TO_CHARPOS if the bidi iterator is at base embedding level.
7535 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
7537 * lread.c (readevalloop): Use correct code for NBSP.
7538 (read1): Likewise. (Bug#9608)
7540 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
7542 * dbusbind.c (Fdbus_register_signal): When service is not
7543 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
7545 2011-09-25 Glenn Morris <rgm@gnu.org>
7547 * buffer.c (truncate-lines): Doc fix.
7549 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
7551 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
7552 (Fset_window_next_buffers): Doc fix.
7554 2011-09-24 Glenn Morris <rgm@gnu.org>
7556 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
7558 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
7560 Fix minor problems found by static checking.
7561 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
7562 * indent.c (Fvertical_motion): Fix == vs = typo.
7564 2011-09-24 Eli Zaretskii <eliz@gnu.org>
7566 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
7567 Default value is now t. Doc fix.
7569 * indent.c (Fvertical_motion): Compute and apply the overshoot
7570 logic when moving up, not only when moving down. Fix the
7571 confusing name and values of the it_overshoot_expected variable;
7572 logic changes accordingly. (Bug#9254) (Bug#9549)
7574 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7575 CHARPOS is covered by a display string which includes newlines.
7576 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7577 is covered by a display string with embedded newlines.
7579 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
7581 * dbusbind.c (Fdbus_register_signal): Add match rule to
7582 Vdbus_registered_objects_table. (Bug#9581)
7583 (Fdbus_register_method, Vdbus_registered_objects_table):
7586 2011-09-24 Jim Meyering <meyering@redhat.com>
7588 do not ignore write error for any output size
7589 The previous change was incomplete.
7590 While it makes emacs --batch detect the vast majority of stdout
7591 write failures, errors were still ignored whenever the output size is
7592 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7593 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7594 && echo FAIL: ignored write error
7595 FAIL: ignored write error
7596 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7597 && echo FAIL: ignored write error
7598 FAIL: ignored write error
7599 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7601 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7603 * emacs.c (Fkill_emacs): In noninteractive mode exit
7604 non-successfully if a write error occurred on stdout. (Bug#9574)
7606 2011-09-21 Eli Zaretskii <eliz@gnu.org>
7608 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7611 * dispextern.h (struct it): Update the comment documenting what
7614 2011-09-20 Eli Zaretskii <eliz@gnu.org>
7616 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7617 a display string, extend search for cursor position to end of row.
7618 (find_row_edges): If the row ends in a newline from a display
7619 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7620 Handle the case of a display string with multiple newlines.
7621 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7622 non-empty line. Fixes confusing cursor motion with arrow keys at
7623 the beginning of a line that starts with whitespace.
7625 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7627 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7630 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
7632 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7635 2011-09-18 Eli Zaretskii <eliz@gnu.org>
7637 * xdisp.c (display_line): Record maximum and minimum buffer
7638 positions even if no glyphs were produced (e.g., by a zero-width
7639 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7640 buffer positions that will be removed from the glyph row because
7642 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7643 column is beyond frame width: don't subtract 1 "pixel" when
7644 computing width of the stretch.
7645 (reseat_at_next_visible_line_start): Undo the change made on
7646 2011-09-17 that saved paragraph information and restored it after
7647 the call to `reseat'. (Bug#9545)
7649 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7651 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7652 and turn window cursor on if cleared (Bug#9415).
7654 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
7656 * search.c (boyer_moore): Take unibyte characters from pattern
7657 literally. (Bug#9458)
7659 2011-09-18 Eli Zaretskii <eliz@gnu.org>
7661 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7663 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7665 Fix minor problem found by static checking.
7666 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7667 initialized, to pacify gcc -Wuninitialized.
7669 * fileio.c: Report proper errno when syscall falls.
7670 (Finsert_file_contents): Save and restore errno,
7671 so that report_file_error outputs the correct diagnostic.
7672 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7674 2011-09-18 Eli Zaretskii <eliz@gnu.org>
7676 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7678 2011-09-17 Eli Zaretskii <eliz@gnu.org>
7680 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7681 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7683 2011-09-17 Eli Zaretskii <eliz@gnu.org>
7685 * xdisp.c (reseat_at_next_visible_line_start): Keep information
7686 about the current paragraph and restore it after the call to reseat.
7688 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7689 (bidi_find_paragraph_start): Search back for paragraph beginning
7690 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7691 (bidi_move_to_visually_next): Only trigger paragraph-related
7692 computations when the last character is a newline or at EOB, not
7693 just any NEUTRAL_B. (Bug#9470)
7695 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7696 truncated lines if point is covered by a display string. (Bug#9524)
7698 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7700 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7701 (cons_to_x_long): New function.
7702 (lisp_data_to_selection_data): Use it. Correct the test for
7703 short-versus-long data; it was negated. Break out of vector
7704 loop, for efficiency, when a long datum is discovered.
7706 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7708 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7710 2011-09-16 Eli Zaretskii <eliz@gnu.org>
7712 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7713 GCC PR/17406) by declaring this function with external scope.
7715 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7717 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7718 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7720 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7722 * editfns.c (Fformat): Correctly handle text properties on "%%".
7724 2011-09-15 Eli Zaretskii <eliz@gnu.org>
7726 * xterm.c (x_draw_composite_glyph_string_foreground):
7727 * w32term.c (x_draw_composite_glyph_string_foreground):
7728 * term.c (encode_terminal_code):
7729 * composite.c (composition_update_it, get_composition_id):
7730 * xdisp.c (get_next_display_element)
7731 (fill_composite_glyph_string): Add comments about special meaning
7732 of TAB characters in a composition.
7734 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7736 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
7737 This occurs when processing a multibyte format.
7738 Problem reported by Wolfgang Jenker.
7740 2011-09-15 Johan Bockgård <bojohan@gnu.org>
7742 * xdisp.c (try_cursor_movement): Only check for exact match if
7743 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7745 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7747 Remove unused external symbols.
7748 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7749 * xdisp.c (calc_pixel_width_or_height): Now static.
7750 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7751 * indent.c (check_display_width):
7752 * w32term.c: Fix comment to match code.
7753 * xterm.c, xterm.h (x_catching_errors): Remove.
7755 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7757 * xselect.c: Use signed conversions more consistently (Bug#9498).
7758 (selection_data_to_lisp_data): Assume incoming selection data are
7759 signed integers, not unsigned. This is to be consistent with
7760 outgoing selection data, which was modified to use signed integers
7761 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7762 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7763 expects long, not unsigned long.
7765 2011-09-14 Eli Zaretskii <eliz@gnu.org>
7767 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7768 computation of loop end. Reported by Johan Bockgård
7771 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
7773 * frame.c (Fother_visible_frames_p): Function deleted.
7775 2011-09-12 Eli Zaretskii <eliz@gnu.org>
7777 * indent.c (compute_motion): Process display vector front to back
7778 rather than the other way around. (Bug#2496)
7780 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7782 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7784 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
7786 * minibuf.c (Fread_from_minibuffer): Doc fix.
7788 2011-09-11 Eli Zaretskii <eliz@gnu.org>
7790 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7791 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7793 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7795 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7796 value for non-existent files.
7798 2011-09-11 Eli Zaretskii <eliz@gnu.org>
7800 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7801 set its "size" to -1. This will set the modtime_size field of
7802 the corresponding buffer to -1, which is what
7803 verify-visited-file-modtime expects for files that do not exist.
7806 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7808 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7810 * lisp.h: ... from here. push_key_description is no longer
7811 defined in keyboard.c, so its declaration should not be in
7812 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7813 logically belongs with push_key_description.
7815 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7817 * buffer.h: Include <sys/types.h> instead of <time.h>.
7818 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7819 Problem reported by Herbert J. Skuhra.
7821 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7823 * xml.c (parse_region): Make the parsing work for
7824 non-comment-starting XML files again (bug#9144).
7826 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7828 * image.c (gif_load): Fix calculation of bottom and right corner.
7831 2011-09-10 Eli Zaretskii <eliz@gnu.org>
7833 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7834 redisplay in small windows.
7836 2011-09-09 Eli Zaretskii <eliz@gnu.org>
7838 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7840 2011-09-08 Martin Rudalics <rudalics@gmx.at>
7842 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7843 Operate on live windows only.
7845 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
7847 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7849 2011-09-07 Eli Zaretskii <eliz@gnu.org>
7851 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7852 only under bidi iteration.
7854 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7856 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7858 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7860 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7861 Without this fix, the command to link temacs failed due to an
7862 undefined symbol __builtin_isnan. This is because
7863 /usr/include/iso/math_c99.h #defines isnan(x) to
7864 __builtin_isnan(x), but the bundled gcc, which identifies itself
7865 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7867 * floatfns.c (isnan): #undef, and then #define to a clone of
7869 (Fisnan): Always define, since it's always available now.
7870 (syms_of_floatfns): Always define isnan at the Lisp level.
7872 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7874 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7876 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7878 * fileio.c: Fix bugs with large file offsets (Bug#9428).
7879 The previous code assumed that file offsets (off_t values) fit in
7880 EMACS_INT variables, which is not true on typical 32-bit hosts.
7881 The code messed up by falsely reporting buffer overflow in cases
7882 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7883 when "big" contains more than 2**29 bytes, even though this
7884 inserts just one byte and does not overflow the buffer.
7885 (Finsert_file_contents): Store file offsets as off_t
7886 values, not as EMACS_INT values. Check for overflow when
7887 converting between EMACS_INT and off_t. When checking for
7888 buffer overflow or for overlap, take the offsets into account.
7889 Don't use EMACS_INT for small values where int suffices.
7890 When checking for overlap, fix a typo: ZV was used where
7891 ZV_BYTE was intended.
7892 (Fwrite_region): Don't assume off_t fits into 'long'.
7893 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7895 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
7897 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7899 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7901 sprintf-related integer and memory overflow issues (Bug#9412).
7903 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
7904 (esprintf, exprintf, evxprintf): New functions.
7905 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
7906 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
7907 (modify_event_symbol): Do not assume that the length of
7908 name_alist_or_stem is safe to alloca and fits in int.
7909 (Fexecute_extended_command): Likewise for function name and binding.
7910 (Frecursion_depth): Wrap around reliably on integer overflow.
7911 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7912 since some callers pass EMACS_INT values.
7913 (Fsingle_key_description): Don't crash if symbol name contains more
7914 than MAX_ALLOCA bytes.
7915 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7916 (get_minibuffer): Arg is now EMACS_INT, not int.
7917 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
7918 (esprintf, exprintf, evxprintf): New decls.
7919 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7921 * dbusbind.c (signature_cat): New function.
7922 (xd_signature, Fdbus_register_signal):
7923 Do not overrun buffer; instead, report string overflow.
7925 * dispnew.c (add_window_display_history): Don't overrun buffer.
7926 Truncate instead; this is OK since it's just a log.
7928 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7929 even if the time zone offset is outlandishly large.
7930 Don't mishandle offset == INT_MIN.
7932 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7933 when creating daemon; the previous buffer-overflow check was incorrect.
7935 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7936 which has the guts of the old verror function.
7938 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7939 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7941 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7942 (font_unparse_xlfd): Don't blindly alloca long strings.
7943 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
7944 fits in int, when using sprintf. Use single snprintf to count
7945 length of string rather than counting it via multiple sprintfs;
7946 that's simpler and more reliable.
7947 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7948 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7949 sprintf, in case result does not fit in int.
7951 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7952 (fontset_from_font): Print it.
7954 * frame.c (tty_frame_count): Now printmax_t, not int.
7955 (make_terminal_frame, set_term_frame_name): Print it.
7956 (x_report_frame_params): In X, window IDs are unsigned long,
7957 not signed long, so print them as unsigned.
7958 (validate_x_resource_name): Check for implausibly long names,
7959 and don't assume name length fits in 'int'.
7960 (x_get_resource_string): Don't blindly alloca invocation name;
7961 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7964 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7965 (xg_check_special_colors, xg_set_geometry):
7966 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7968 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7969 Use esprintf, not sprintf, in case result does not fit in int.
7971 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7972 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7973 it as a large positive number.
7974 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7975 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7977 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7978 in case result does not fit in int.
7980 * print.c (float_to_string): Detect width overflow more reliably.
7981 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7982 buffer overrun. Don't assume list length fits in 'int'. Treat
7983 print length of 0 as 0, not as infinity; to be consistent with other
7984 uses of print length in this function. Don't overflow print length
7985 index. Don't assume hash table size fits in 'long', or that
7986 vectorlike size fits in 'unsigned long'.
7988 * process.c (make_process): Use printmax_t, not int, to format
7989 process-name gensyms.
7991 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7993 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7994 to avoid potential buffer overrun.
7996 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7997 if X resource line is longer than 512 bytes.
7999 * xfns.c (x_window): Make sprintf buffer a bit bigger
8000 to avoid potential buffer overrun.
8002 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
8004 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
8006 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
8008 Integer overflow fixes for scrolling, etc.
8009 Without these, Emacs silently mishandles large integers sometimes.
8010 For example, "C-u 4294967297 M-x recenter" was treated as if
8011 it were "C-u 1 M-x recenter" on a typical 64-bit host.
8013 * xdisp.c (try_window_id): Check Emacs fixnum range before
8014 converting to 'int'.
8016 * window.c (window_scroll_line_based, Frecenter):
8017 Check that an Emacs fixnum is in range before assigning it to 'int'.
8018 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
8019 values converted from Emacs fixnums.
8020 (Frecenter): Don't wrap around a line count if it is out of 'int'
8021 range; instead, treat it as an extreme value.
8022 (Fset_window_configuration, compare_window_configurations):
8023 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
8025 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
8026 that can exceed INT_MAX. Check that EMACS_INT value is in range
8027 before assigning it to the (possibly-narrower) index.
8028 (match_limit): Don't assume that a fixnum can fit in 'int'.
8030 * print.c (print_object): Use ptrdiff_t, not int, for index that can
8033 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
8034 (Fvertical_motion): Don't wrap around LINES values that don't fit
8035 in 'int'. Instead, treat them as extreme values. This is good
8036 enough for windows, which can't have more than INT_MAX lines anyway.
8038 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8040 * Require libxml/parser.h to avoid compilation warning.
8042 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
8044 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
8045 since this reportedly can destroy thread storage.
8047 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
8049 * syntax.c (find_defun_start): Update all cache variables if
8050 exiting early (Bug#9401).
8052 2011-08-30 Eli Zaretskii <eliz@gnu.org>
8054 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
8056 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
8057 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
8058 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
8060 * term.c (tty_append_glyph): New function.
8061 (produce_stretch_glyph): Static function and its prototype deleted.
8063 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
8066 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
8068 * image.c (parse_image_spec): Check for nonnegative, not for positive,
8069 when checking :margin (Bug#9390).
8070 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
8071 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
8072 so that the name doesn't mislead. All uses changed.
8074 2011-08-28 Johan Bockgård <bojohan@gnu.org>
8076 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
8079 2011-08-27 Eli Zaretskii <eliz@gnu.org>
8081 * xdisp.c (move_it_to): Don't bail out early when reaching
8082 position beyond to_charpos, if we are scanning backwards.
8083 (move_it_vertically_backward): When DY == 0, make sure we get to
8084 the first character in the line after the newline.
8086 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
8088 * ccl.c: Improve and simplify overflow checking (Bug#9196).
8089 (ccl_driver): Do not generate an out-of-range pointer.
8090 (Fccl_execute_on_string): Remove unnecessary check for
8091 integer overflow, noted by Stefan Monnier in
8092 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
8093 Remove a FIXME that didn't need fixing.
8094 Simplify the newly-introduced buffer reallocation code.
8096 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
8098 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
8100 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
8102 Integer and memory overflow issues (Bug#9196).
8104 * doc.c (get_doc_string): Rework so that
8105 get_doc_string_buffer_size is the actual buffer size, rather than
8106 being 1 less than the actual buffer size; this makes xpalloc more
8109 * image.c (x_allocate_bitmap_record, cache_image):
8110 * xselect.c (Fx_register_dnd_atom):
8111 Simplify previous changes by using xpalloc.
8113 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
8114 since either will do and ptrdiff_t is convenient with xpalloc.
8116 * charset.c (charset_table_size)
8117 (struct charset_sort_data.priority): Now ptrdiff_t.
8118 (charset_compare): Don't overflow if priorities differ greatly.
8119 (Fsort_charsets): Don't assume list length fits in int.
8120 Check for size-calculation overflow when allocating sort data.
8121 (syms_of_charset): Allocate an initial charset table that is
8122 just under 64 KiB, to avoid problems with glibc malloc and mmap.
8124 * cmds.c (internal_self_insert): Check for size-calculation overflow.
8126 * composite.h (struct composition.glyph_len): Now int, not unsigned.
8127 The actual value is always <= INT_MAX, and leaving it unsigned made
8128 overflow checking harder.
8130 * dispextern.h (struct glyph_matrix.rows_allocated)
8131 (struct face_cache.size): Now ptrdiff_t, for convenience in use
8132 with xpalloc. The values are still always <= INT_MAX.
8134 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
8136 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
8137 (SAFE_NALLOCA): New macro.
8139 * region-cache.c (struct boundary.pos, find_cache_boundary)
8140 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
8141 (set_cache_region, invalidate_region_cache)
8142 (revalidate_region_cache, know_region_cache, region_cache_forward)
8143 (region_cache_backward, pp_cache):
8144 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
8145 so that ptrdiff_t * can be passed to xpalloc.
8146 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
8147 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
8148 (pp_cache): Don't assume cache_len fits in int.
8149 * region-cache.h: Adjust extern decls to match.
8151 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
8152 EMACS_INT, since either will do, for xpalloc.
8154 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
8155 (xnmalloc, xnrealloc, xpalloc): New functions.
8157 * bidi.c (bidi_shelve_header_size): New constant.
8158 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
8159 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
8161 * bidi.c (bidi_cache_shrink):
8162 * buffer.c (overlays_at, overlays_in, record_overlay_string)
8164 Don't update size of array until after memory allocation succeeds,
8165 because xmalloc/xrealloc may not return.
8166 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
8167 now that we have proper integer overflow checking.
8168 (record_overlay_string, overlay_strings): Catch overflows when
8169 calculating size of overlay_str_buf.
8171 * callproc.c (Fcall_process): Check for size overflow when
8172 calculating size of args2.
8173 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
8174 Normally we prefer signed values, but sticking with ptrdiff_t would
8175 require adding more-complicated checks.
8177 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
8178 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
8179 Redo buffer-overflow calculations to avoid integer overflow.
8180 Add a FIXME comment where memory seems to be over-allocated.
8182 * character.c (Fstring): Check for size-calculation overflow.
8184 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
8185 unnecessary integer overflow. Check for size overflow.
8186 (encode_coding_object): Don't update size until xmalloc succeeds.
8188 * composite.c (get_composition_id): Check for overflow in glyph
8189 length calculations.
8191 Integer and memory overflow fixes for display code.
8192 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
8193 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
8194 (scrolling_window): Check for overflow in size calculations.
8195 (line_draw_cost, realloc_glyph_pool, add_row_entry):
8196 Don't assume glyph table len fits in int.
8197 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
8198 (row_table_size): Now ptrdiff_t, not int.
8199 (scrolling_window): Avoid overflow in size calculations.
8200 Don't update size until allocation succeeds.
8201 * fns.c (concat): Check for overflow in size calculations.
8202 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
8203 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8204 (NEXT_ALMOST_PRIME_LIMIT): New constant.
8206 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
8207 (get_doc_string): Check for size calculation overflow.
8208 Don't update size until allocation succeeds.
8209 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
8210 EMACS_INT, where ptrdiff_t will do.
8211 (Fsubstitute_command_keys): Check for string overflow.
8213 * editfns.c (set_time_zone_rule): Don't assume environment length
8215 (message_length): Now ptrdiff_t, not int.
8216 (Fmessage_box): Don't update size until allocation succeeds.
8217 Don't assume message length fits in int.
8218 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
8220 * emacs.c (main): Do not reallocate argv, since there is a null at
8221 the end that can be overwritten, and this way there's no need to
8222 worry about size-calculation overflow.
8223 (sort_args): Check for size-calculation overflow.
8225 * eval.c (init_eval_once, grow_specpdl): Don't update size until
8227 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
8229 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
8230 (x_set_scroll_bar_width, x_figure_window_size):
8231 Check for integer overflow.
8232 (x_set_alpha): Do not assume XINT fits in int.
8234 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
8235 This is for the members text_lines, text_cols, total_lines, total_cols,
8236 where the system imposes an 'int' limit.
8238 * fringe.c (Fdefine_fringe_bitmap):
8239 Don't update size until alloc works.
8241 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
8242 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
8244 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
8245 Check for size-calculation overflow.
8246 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
8247 do, as we prefer signed integers.
8248 (id_to_widget.max_size, id_to_widget.used)
8249 (xg_store_widget_in_map, xg_remove_widget_from_map)
8250 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
8251 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
8252 Use and return ptrdiff_t, not int.
8253 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
8254 * gtkutil.h: Change prototypes to match the above.
8256 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
8257 are duplicate now that they've been promoted to lisp.h.
8258 (x_allocate_bitmap_record, x_alloc_image_color)
8259 (make_image_cache, cache_image, xpm_load):
8260 Don't update size until alloc is done.
8261 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
8263 Check for size calculation overflow.
8264 (ct_colors_allocated_max): New constant.
8265 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
8268 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
8269 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
8270 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
8271 Use ptrdiff_t, not int, to count maps.
8272 (read_char_minibuf_menu_prompt): Check for overflow in size
8273 calculations. Don't update size until allocation succeeds.
8274 Redo calculations to avoid overflow.
8275 * keyboard.h: Change prototypes to match the above.
8277 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
8279 (current_minor_maps): Check for size calculation overflow.
8280 * keymap.h: Change prototypes to match the above.
8282 * lread.c (read1, init_obarray): Don't update size until alloc done.
8284 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
8285 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
8287 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
8288 Now ptrdiff_t, not int.
8289 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
8290 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
8292 * process.c (Fnetwork_interface_list): Check for overflow
8293 in size calculation.
8295 * region-cache.c (move_cache_gap): Check for size calculation overflow.
8297 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
8298 overflow. Don't bother calling xmalloc when xrealloc will do.
8300 * search.c (Freplace_match): Check for size calculation overflow.
8301 (Fset_match_data): Don't assume list lengths fit in 'int'.
8303 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
8304 for command line length. Do not attempt to address one before the
8305 beginning of an array, as that's not portable.
8307 * term.c (max_frame_lines): Remove; unused.
8308 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
8310 (encode_terminal_code, calculate_costs): Check for size
8311 calculation overflow.
8312 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
8313 table lengths and related sizes. Don't update size until alloc
8314 done. Redo calculations to avoid overflow.
8315 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
8317 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
8318 subtracting pointers.
8319 (gobble_line): Check for overflow more carefully. Don't update size
8322 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
8323 Don't update size until alloc done.
8324 Redo size calculations to avoid overflow.
8325 Check for size calculation overflow.
8326 (main) [DEBUG]: Fix typo in invoking tparam1.
8328 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
8329 Use ptrdiff_t, not int, for sizes.
8330 (store_mode_line_noprop_char): Don't update size until alloc done.
8332 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
8333 Use ptrdiff_t, not int, for sizes.
8334 (Finternal_make_lisp_face, cache_face):
8335 Check for size calculation overflow.
8336 (cache_face): Treat size calculation overflows as if they were
8337 memory exhaustion (the usual treatment), rather than aborting.
8339 * xfns.c (x_encode_text, x_set_name_internal)
8340 (Fx_change_window_property): Use ptrdiff_t, not int, to count
8341 sizes, since they can exceed INT_MAX in size. Check for size
8342 calculation overflow.
8344 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
8345 (xg_select): Check for size calculation overflow.
8346 Don't update size until alloc done.
8348 * xrdb.c (get_environ_db): Don't assume path length fits in int,
8349 as sprintf is limited to int lengths.
8351 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
8352 (X_LONG_MIN): New macros.
8353 Use them to make the following changes clearer.
8354 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
8355 This change doesn't affect the value now, but it may help remind
8356 future maintainers not to raise the value too much later.
8357 (SELECTION_QUANTUM): Remove, replacing with ...
8358 (selection_quantum): ... new function, which avoids overflow.
8360 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
8361 assumption that selection length fits in 'int'.
8362 (x_reply_selection_request, x_handle_selection_request)
8363 (x_get_window_property, receive_incremental_selection)
8364 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
8365 (lisp_data_to_selection_data, clean_local_selection_data):
8366 Use ptrdiff_t, not int, to record length of selection.
8367 (x_reply_selection_request, x_get_window_property)
8368 (receive_incremental_selection, x_property_data_to_lisp):
8369 Redo calculations to avoid overflow.
8370 (x_reply_selection_request): When sending hint, ceiling it at
8371 X_LONG_MAX rather than relying on wraparound overflow to send
8373 (x_get_window_property, receive_incremental_selection)
8374 (lisp_data_to_selection_data, x_property_data_to_lisp):
8375 Check for size-calculation overflow.
8376 (x_get_window_property, receive_incremental_selection)
8377 (lisp_data_to_selection_data, Fx_register_dnd_atom):
8378 Don't store size until memory allocation succeeds.
8379 (x_get_window_property): Plug memory leak on memory exhaustion.
8380 Don't double-block input; malloc is safe here. Don't assume 2**34
8381 - 4 fits in unsigned long. Add an xassert to check
8382 XGetWindowProperty overflow. Be more careful about overflow
8383 calculations, and distinguish size from memory overflow better.
8384 (receive_incremental_selection): When tracing, don't assume
8385 unsigned int is less than INT_MAX.
8386 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
8387 harmful) conversions of unsigned short to int.
8388 (lisp_data_to_selection_data): Don't assume that integers
8389 in the range -65535 through -1 fit in an X unsigned short.
8390 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
8391 result parameters unless successful. Rely on cons_to_unsigned
8392 to report problems with elements; the old code wasn't right anyway.
8393 (x_check_property_data): Check for int overflow; we cannot use
8394 a wider type due to X limits.
8395 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
8397 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
8399 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
8400 (x_term_init): Check for size calculation overflow.
8401 (x_color_cells): Don't store size until memory allocation succeeds.
8402 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
8403 Don't assume alloca size is less than MAX_ALLOCA.
8404 (x_term_init): Don't assume length fits in int (sprintf is limited
8407 Use ptrdiff_t for composition IDs.
8408 * character.c (lisp_string_width):
8409 * composite.c (composition_table_size, n_compositions)
8410 (get_composition_id, composition_gstring_from_id):
8411 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
8412 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
8413 * window.c (Frecenter):
8414 Use ptrdiff_t, not int, for composition IDs.
8415 * composite.c (get_composition_id): Check for integer overflow.
8416 * composite.h: Adjust prototypes to match the above changes.
8418 Use ptrdiff_t for hash table indexes.
8419 * category.c (hash_get_category_set):
8420 * ccl.c (ccl_driver):
8421 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
8422 * coding.c (coding_system_charset_list, detect_coding_system):
8423 * coding.h (struct coding_system.id):
8424 * composite.c (get_composition_id, gstring_lookup_cache):
8425 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
8426 * image.c (xpm_get_color_table_h):
8427 * lisp.h (hash_lookup, hash_put):
8428 * minibuf.c (Ftest_completion):
8429 Use ptrdiff_t for hash table indexes, not int (which is too
8430 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
8431 32-bit --with-wide-int hosts).
8433 * charset.c (Fdefine_charset_internal): Check for integer overflow.
8434 Add a FIXME comment about memory leaks.
8435 (syms_of_charset): Don't assume xmalloc returns.
8437 Don't assume that stated character widths fit in int.
8438 * character.c (Fchar_width, c_string_width, lisp_string_width):
8439 * character.h (CHAR_WIDTH):
8440 * indent.c (MULTIBYTE_BYTES_WIDTH):
8441 Use sanitize_char_width to avoid undefined and/or bad behavior
8442 with outlandish widths.
8443 * character.h (sanitize_tab_width): Rename from sanitize_width,
8444 now that we have two such functions. All uses changed.
8445 (sanitize_char_width): New inline function.
8447 Don't assume that tab-width fits in int.
8448 * character.h (sanitize_width): New inline function.
8449 (SANE_TAB_WIDTH): New macro.
8450 (ASCII_CHAR_WIDTH): Use it.
8451 * indent.c (sane_tab_width): Remove. All uses replaced by
8452 SANE_TAB_WIDTH (current_buffer).
8453 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
8455 * fileio.c: Integer overflow issues with file modes.
8456 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
8458 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
8459 Remove unreachable code.
8460 (read_hex, load_charset_map_from_file): Check for integer overflow.
8462 * xterm.c: Don't go over XClientMessageEvent limit.
8463 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
8464 (x_send_scroll_bar_event): Likewise. Check that the size does not
8465 exceed limits imposed by XClientMessageEvent, as well as the usual
8466 ptrdiff_t and size_t limits.
8468 * keyboard.c: Overflow, signedness and related fixes.
8469 (make_lispy_movement): Use same integer type in forward decl
8470 that is used in the definition.
8471 (read_key_sequence, keyremap_step):
8472 Change bufsize argument back to int, undoing my 2011-03-30 change.
8473 We prefer signed types, and int is wide enough here.
8474 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
8475 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
8476 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
8477 length, not size_t. Use ptrdiff_t for index, not int.
8478 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
8479 possibility of integer overflow.
8481 Overflow, signedness and related fixes for images.
8483 * dispextern.h (struct it.stack[0].u.image.image_id)
8484 (struct_it.image_id, struct image.id, struct image_cache.size)
8485 (struct image_cache.used, struct image_cache.ref_count):
8486 * gtkutil.c (update_frame_tool_bar):
8487 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
8488 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
8489 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
8490 * nsmenu.m (update_frame_tool_bar):
8491 * xdisp.c (calc_pixel_width_or_height):
8492 * xfns.c (image_cache_refcount):
8493 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
8494 on typical 64-bit hosts.
8496 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8497 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
8498 Omit unnecessary casts to int.
8499 (parse_image_spec): Check that integers fall into 'int' range
8500 when the callers expect that.
8501 (image_ascent): Redo ascent calculation to avoid int overflow.
8502 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
8503 (lookup_image): Remove unnecessary tests.
8504 (xbm_image_p): Locals are now of int, not EMACS_INT,
8505 since parse_image_check makes sure they fit into int.
8506 (png_load, gif_load, svg_load_image):
8507 Prefer int to unsigned where either will do.
8508 (tiff_handler): New function, combining the cores of the
8509 old tiff_error_handler and tiff_warning_handler.
8510 This function is rewritten to use vsnprintf and thereby avoid
8511 stack buffer overflows. It uses only the features of vsnprintf
8512 that are common to both POSIX and native Microsoft.
8513 (tiff_error_handler, tiff_warning_handler): Use it.
8514 (tiff_load, gif_load, imagemagick_load_image):
8515 Don't assume :index value fits in 'int'.
8516 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
8517 (imagemagick_load_image): Check that crop parameters fit into
8518 the integer types that MagickCropImage accepts. Don't assume
8519 Vimagemagick_render_type has a nonnegative value. Don't assume
8520 size_t fits in 'long'.
8521 (gs_load): Use printmax_t to print the widest integers possible.
8522 Check for integer overflow when computing image height and width.
8524 2011-08-26 Eli Zaretskii <eliz@gnu.org>
8526 * xdisp.c (redisplay_window): Don't force window start if point
8527 will be invisible in the resulting window. (Bug#9324)
8529 2011-08-25 Eli Zaretskii <eliz@gnu.org>
8531 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
8532 the display spec is of the form `(space ...)'.
8533 (handle_display_spec): Return the value returned by
8534 handle_single_display_spec, not just 1 or zero.
8535 (handle_single_display_spec): If the display spec is of the form
8536 `(space ...)', and specifies display in the text area, return 2
8538 (try_cursor_movement): Check for the need to scroll more
8539 accurately, and prefer exact match for point under bidi.
8540 Don't advance `row' beyond the last row of the window.
8542 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
8543 into disp_prop; all users changed.
8545 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
8546 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
8547 for the text covered by the display property.
8549 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
8551 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
8552 Change return value to nil.
8553 (Frecord_buffer): Delete unused function.
8555 2011-08-24 Eli Zaretskii <eliz@gnu.org>
8557 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
8558 buffers, return left-to-right.
8559 (set_cursor_from_row): Consider candidate row a win if its glyph
8560 represents a newline and point is on that newline. Fixes cursor
8561 positioning on the newline at EOL of R2L text within L2R
8562 paragraph, and vice versa.
8563 (try_cursor_movement): Check continued rows, in addition to
8564 continuation rows. Fixes unwarranted scroll when point enters a
8565 continued line of R2L text within an L2R paragraph, or vice versa.
8566 (cursor_row_p): Consider the case of point being equal to
8567 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
8568 from the end of a short line to the beginning of a continued line
8569 of R2L text within L2R paragraph.
8570 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
8571 composed characters.
8573 * bidi.c (bidi_check_type): Use xassert.
8574 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8577 2011-08-23 Eli Zaretskii <eliz@gnu.org>
8579 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8582 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
8584 * nsfont.m (ns_otf_to_script): Fix typo.
8586 2011-08-22 Kenichi Handa <handa@m17n.org>
8588 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8589 extra slot even if the purpose is char-code-property-table.
8591 2011-08-23 Eli Zaretskii <eliz@gnu.org>
8593 * xdisp.c (redisplay_window): When computing centering_position,
8594 account for the height of the header line. (Bug#8874)
8596 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8597 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8598 candidate is selected by the mouse, and that candidate has a
8599 composed character under the mouse.
8601 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8602 coordinates reported by pos-visible-in-window-p for a composed
8603 character in column zero.
8605 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8607 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8609 2011-08-22 Eli Zaretskii <eliz@gnu.org>
8611 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8612 consider it a hit if to_charpos is anywhere in the range of the
8613 composed buffer positions.
8615 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
8617 * image.c (gif_load): Don't assume that each subimage has the same
8618 dimensions as the base image. Handle disposal method that is
8619 "undefined" by the gif spec (Bug#9335).
8621 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
8623 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
8624 (Fcondition_case): Document `debug' symbol in error handler.
8626 2011-08-19 Eli Zaretskii <eliz@gnu.org>
8628 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8629 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8630 from an Org mode buffer to a Speedbar frame.
8632 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8633 a composition, take its buffer position from IT->cmp_it.charpos.
8634 Fixes cursor positioning at the beginning of a line that begins
8635 with a composed character.
8637 2011-08-18 Eli Zaretskii <eliz@gnu.org>
8639 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8640 character bidirectional type, use STRONG_L instead. Fixes crashes
8641 in a buffer produced by `describe-categories'.
8643 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8644 members before the level stack, so they would be saved and
8645 restored when copying iterator state. Fixes incorrect reordering
8646 around TABs covered by display properties.
8648 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8650 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
8652 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
8654 * eval.c (internal_condition_case, internal_condition_case_1)
8655 (internal_condition_case_2, internal_condition_case_n):
8656 Remove unnecessary aborts (Bug#9081).
8658 2011-08-17 Eli Zaretskii <eliz@gnu.org>
8660 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8661 has no `load' handler, try opening the file locally. (Bug#9311)
8663 2011-08-16 Ken Brown <kbrown@cornell.edu>
8665 * gmalloc.c: Expand comment.
8667 2011-08-16 Eli Zaretskii <eliz@gnu.org>
8669 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8670 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8672 2011-08-16 Ken Brown <kbrown@cornell.edu>
8674 Fix memory allocation problems in Cygwin build (Bug#9273).
8676 * unexcw.c ( __malloc_initialized): Declare external variable.
8677 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8679 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8681 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8683 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8685 [CYGWIN] (special_realloc): New function.
8686 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8687 requests to realloc storage in the static heap.
8689 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8691 * bidi.c (bidi_initialize): Remove unused local.
8693 2011-08-15 Eli Zaretskii <eliz@gnu.org>
8696 * biditype.h: Remove file.
8697 * makefile.w32-in ($(BLD)/bidi.$(O)):
8698 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
8700 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8702 * chartab.c: Improve commentary for the uniprop_table API.
8704 * bidi.c (bidi_paragraph_init): Support zero value of
8705 bidi_ignore_explicit_marks_for_paragraph_level.
8706 (bidi_initialize): Use uniprop_table instead of including
8707 biditype.h and bidimirror.h.
8709 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8710 coordinates of the iterator when restoring from ppos_it.
8713 2011-08-14 Kenichi Handa <handa@m17n.org>
8715 * process.c (create_process): Call setup_process_coding_systems
8716 after the pid of the process is set to -1 (Bug#8162).
8718 2011-08-14 Eli Zaretskii <eliz@gnu.org>
8720 * xdisp.c (move_it_in_display_line_to): Don't invoke
8721 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8722 ppos_it. Fixes vertical cursor motion when line beginning is
8723 covered by an image. (Bug#9296)
8725 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8727 * nsterm.h (ns_run_ascript): Declare.
8728 (NSAPP_DATA2_RUNASSCRIPT): Define.
8730 * nsfns.m (as_script, as_result, as_status): New static variables.
8731 (ns_run_ascript): New function.
8732 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
8733 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8734 the event loop. Get status from as_status (Bug#7276).
8736 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8737 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8738 the event loop (Bug#7276).
8740 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8742 * gnutls.c (QCgnutls_bootprop_priority)
8743 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8744 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8745 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8746 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8747 (QCgnutls_bootprop_verify_hostname_error)
8748 (QCgnutls_bootprop_callbacks_verify): Rename from
8749 Qgnutls_bootprop_..., all uses changed.
8751 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8754 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8756 * xfaces.c (Qframe_set_background_mode): Now static.
8757 * dispextern.h (Qframe_set_background_mode): Remove decl.
8759 * process.c (Fnetwork_interface_info): Declare local only if needed.
8761 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8763 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8764 (Fnetwork_interface_list): Allocate in increments of bytes instead
8765 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8766 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8768 (struct ifflag_def): notrailers is smart on OSX.
8769 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8770 Get hardware address with getifaddrs if available.
8772 2011-08-12 Eli Zaretskii <eliz@gnu.org>
8774 * xdisp.c (iterate_out_of_display_property): xassert that
8775 IT->position is set to within IT->object's boundaries. Break from
8776 the loop as soon as EOB is reached; avoids infloops in redisplay
8777 when IT->position is set up wrongly due to some bug.
8778 Set IT->current to match the bidi iterator unconditionally.
8779 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8780 entry. Force push_it to save on the stack the current
8781 buffer/string position, to be restored by pop_it. Fix flags in
8782 the iterator structure wrt the object coming from a display
8783 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8784 properties. (Bug#9284)
8786 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
8788 * fontset.c (fontset_get_font_group): Add proper type checks.
8791 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8793 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8794 and LC_VERSION_MIN_MACOSX.
8795 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8796 (dump_it) [LC_FUNCTION_STARTS]: Use it.
8798 2011-08-08 Eli Zaretskii <eliz@gnu.org>
8800 * xdisp.c (forward_to_next_line_start): Allow to use the
8801 no-display-properties-and-no-overlays under bidi display.
8802 Set disp_pos in the bidi iterator to avoid searches for display
8803 properties and overlays.
8805 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
8807 * editfns.c (Fset_time_zone_rule): Document relationship with the
8810 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8811 the font entity extracted from the cache (Bug#8109).
8813 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
8815 * composite.c (autocmp_chars): Don't reset point. That is done by
8816 restore_point_unwind (Bug#5984).
8818 2011-08-07 Juri Linkov <juri@jurta.org>
8820 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8821 to show the arg `TIME' instead of `TIMEVAL'.
8823 2011-08-06 Eli Zaretskii <eliz@gnu.org>
8825 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8826 display property strides EOL and includes a newline, as in
8827 longlines-mode. (Bug#9254)
8828 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8829 word-wrap under bidirectional display. (Bug#9224)
8831 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8832 is non-zero, even if the data buffer is NULL. Fixes a crash in
8833 vertical-motion with longlines-mode. (Bug#9254)
8835 2011-08-05 Eli Zaretskii <eliz@gnu.org>
8837 * bidi.c <bidi_cache_total_alloc>: Now static.
8838 (bidi_initialize): Initialize bidi_cache_total_alloc.
8840 * xdisp.c (display_line): Release buffer allocated for shelved bidi
8843 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8844 amount allocated this far in `bidi_cache_total_alloc'.
8845 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8846 non-zero, only free the data buffer without restoring the cache
8847 contents. All callers changed.
8849 * dispextern.h (bidi_unshelve_cache): Update prototype.
8851 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8852 (move_it_in_display_line, move_it_to)
8853 (move_it_vertically_backward, move_it_by_lines): Replace the call
8854 to xfree to an equivalent call to bidi_unshelve_cache.
8855 (move_it_in_display_line_to): Fix logic of returning
8856 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
8858 2011-08-05 Eli Zaretskii <eliz@gnu.org>
8860 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8861 came from a string character with a `cursor' property. (Bug#9229)
8863 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8865 * Makefile.in (LIB_PTHREAD): New variable.
8866 (LIBES): Add LIB_PTHREAD (Bug#9216).
8868 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8869 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8871 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8873 * regex.c (re_iswctype): Remove some redundant boolean conversions.
8875 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8877 * xterm.c (x_find_topmost_parent): New function.
8878 (x_set_frame_alpha): Find topmost parent window with
8879 x_find_topmost_parent and set the property there also (bug#9181).
8880 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8882 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8884 * callproc.c (Fcall_process): Avoid vfork clobbering
8885 the local vars buffer, coding_systems, current_dir.
8887 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8889 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8891 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8893 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8894 so that it is not optimized away.
8896 * xdisp.c (compute_display_string_pos): Remove unused local.
8898 2011-08-02 Eli Zaretskii <eliz@gnu.org>
8900 Fix slow cursor motion and scrolling in large buffers with
8901 selective display, like Org Mode buffers. (Bug#9218)
8903 * dispextern.h (struct bidi_it): New member disp_prop_p.
8905 * xdisp.c: Remove one-slot cache of display string positions.
8906 (compute_display_string_pos): Accept an additional argument
8907 DISP_PROP_P; callers changed. Scan at most 5K characters forward
8908 for a display string or property. If found, set DISP_PROP_P
8911 * bidi.c (bidi_fetch_char): Accept an additional argument
8912 DISP_PROP_P, and pass it to compute_display_string_pos.
8913 Only handle text covered by a display string if DISP_PROP_P is returned
8914 non-zero. All callers of bidi_fetch_char changed.
8916 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8918 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8920 2010-12-03 Don March <don@ohspite.net>
8922 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8923 last character M-[char] is translated to ESC [char] (bug#7541).
8925 2011-08-02 Kenichi Handa <handa@m17n.org>
8927 * lisp.h (uniprop_table): Extern it.
8929 * chartab.c (uniprop_table): Make it non-static.
8931 2011-08-01 Eli Zaretskii <eliz@gnu.org>
8933 * xdisp.c (forward_to_next_line_start): Accept additional argument
8934 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8936 (reseat_at_next_visible_line_start): Use the bidi iterator state
8937 returned by forward_to_next_line_start to restore the state of
8938 it->bidi_it after backing up to previous newline. (Bug#9212)
8940 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8942 * regex.c (re_comp): Protoize.
8943 (re_exec): Fix return type.
8944 (regexec): Fix type of `ret'. (Bug#9203)
8946 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8948 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8949 This is needed if max-image-size is a floating-point number.
8951 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8953 * print.c (print_object): Print empty symbol as ##.
8955 * lread.c (read1): Read ## as empty symbol.
8957 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8959 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8960 setting frame foreground color (Bug#9175).
8961 (x_set_background_color): Likewise.
8963 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8964 contents (Bug#9176).
8965 (EmacsTooltip -init): Remove bezels and add shadows to
8968 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8969 or scroll bar (Bug#8470).
8971 * nsfont.m (nsfont_open): Remove assignment to voffset and
8972 unnecessary vars hshink, expand, hd, full_height, min_height.
8973 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8975 * nsterm.h (nsfont_info): Remove voffset field.
8977 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8979 Implement strike-through and overline on NextStep (Bug#8863).
8981 * nsfont.m (nsfont_open): Use underline position provided by font,
8982 instead of hard-coded value of 2.
8983 (nsfont_draw): Call ns_draw_text_decoration instead.
8985 * nsterm.h: Add declaration for ns_draw_text_decoration.
8987 * nsterm.m (ns_draw_text_decoration): New function for drawing
8988 underline, overline, and strike-through.
8989 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8990 ns_draw_text_decoration. Change treatment of cursor drawing to
8991 accommodate underlining, etc.
8993 2011-07-28 Eli Zaretskii <eliz@gnu.org>
8995 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8998 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9000 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
9001 Without this fix, if a signal arrives just after memory fills up,
9002 'malloc' might be invoked reentrantly.
9004 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
9005 In other words, assume that every image size is allowed, on non-X
9006 hosts. This assumption is probably wrong, but it lets Emacs compile.
9008 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
9010 * regex.c (re_iswctype): Convert return values to boolean.
9012 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
9014 * xdisp.c (compute_display_string_pos): Don't use cached display
9015 string position if the buffer had its restriction changed.
9018 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9020 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9022 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9024 Integer signedness and overflow and related fixes. (Bug#9079)
9026 * bidi.c: Integer size and overflow fixes.
9027 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
9028 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
9029 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9030 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
9031 (bidi_find_other_level_edge):
9032 Use ptrdiff_t instead of EMACS_INT where either will do.
9033 This works better on 32-bit hosts configured --with-wide-int.
9034 (bidi_cache_ensure_space): Check for size-calculation overflow.
9035 Use % rather than repeated addition, for better worst-case speed.
9036 Don't set bidi_cache_size until after xrealloc returns, because it
9038 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
9039 (bidi_cache_ensure_space): Also check that the bidi cache size
9040 does not exceed that of the largest Lisp string or buffer. See Eli
9041 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
9043 * alloc.c (__malloc_size_t): Remove.
9044 All uses replaced by size_t. See Andreas Schwab's note
9045 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
9047 * image.c: Improve checking for integer overflow.
9048 (check_image_size): Assume that f is nonnull, since
9049 it is always nonnull in practice. This is one less thing to
9050 worry about when checking for integer overflow later.
9051 (x_check_image_size): New function, which checks for integer
9052 overflow issues inside X.
9053 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
9054 This removes the need for a memory_full check.
9055 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
9056 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
9057 (xbm_read_bitmap_data): Change locals back to 'int', since
9058 their values must fit in 'int'.
9059 (xpm_load_image, png_load, tiff_load):
9060 Invoke x_create_x_image_and_pixmap earlier,
9061 to avoid much needless work if the image is too large.
9062 (tiff_load): Treat overly large images as if
9063 x_create_x_image_and_pixmap failed, not as malloc failures.
9064 (gs_load): Use x_check_image_size.
9066 * gtkutil.c: Omit integer casts.
9067 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
9068 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
9070 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
9072 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
9073 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
9074 would wrongly return t on a 64-bit host.
9076 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
9077 The plain *_OVERFLOW macros run afoul of GCC bug 49705
9078 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
9079 and therefore cause GCC to emit a bogus diagnostic in some cases.
9081 * image.c: Integer signedness and overflow and related fixes.
9082 This is not an exhaustive set of fixes, but it's time to
9083 record what I've got.
9084 (lookup_pixel_color, check_image_size): Remove redundant decls.
9085 (check_image_size): Don't assume that arbitrary EMACS_INT values
9086 fit in 'int', or that arbitrary 'double' values fit in 'int'.
9087 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
9088 (tiff_load, imagemagick_load_image):
9089 Check for overflow in size calculations.
9090 (x_create_x_image_and_pixmap): Remove unnecessary test for
9091 xmalloc returning NULL; that can't happen.
9092 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
9093 (xpm_color_bucket): Use better integer hashing function.
9094 (xpm_cache_color): Don't possibly over-allocate memory.
9095 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
9096 (gif_memory_source):
9097 Use ptrdiff_t, not int or size_t, to record sizes.
9098 (png_load): Don't assume values greater than 2**31 fit in 'int'.
9099 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
9100 either works, as we prefer signed integers.
9101 (tiff_read_from_memory, tiff_write_from_memory):
9102 Return tsize_t, not size_t, since that's what the TIFF API wants.
9103 (tiff_read_from_memory): Don't fail simply because the read would
9104 go past EOF; instead, return a short read.
9105 (tiff_load): Omit no-longer-needed casts.
9106 (Fimagemagick_types): Don't assume size fits into 'int'.
9108 Improve hashing quality when configured --with-wide-int.
9109 * fns.c (hash_string): New function, taken from sxhash_string.
9110 Do not discard information about ASCII character case; this
9111 discarding is no longer needed.
9112 (sxhash-string): Use it. Change sig to match it. Caller changed.
9113 * lisp.h: Declare it.
9114 * lread.c (hash_string): Remove, since we now use fns.c's version.
9115 The fns.c version returns a wider integer if --with-wide-int is
9116 specified, so this should help the quality of the hashing a bit.
9118 * emacs.c: Integer overflow minor fix.
9119 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
9120 Define only if GNU_LINUX.
9121 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
9123 * dispnew.c: Integer signedness and overflow fixes.
9124 Remove unnecessary forward decls, that were a maintenance hassle.
9125 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
9127 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
9128 (scrolling_window): Use ptrdiff_t, not int, for byte count.
9129 (prepare_desired_row, line_draw_cost):
9130 Use int, not unsigned, where either works.
9131 (save_current_matrix, restore_current_matrix):
9132 Use ptrdiff_t, not size_t, where either works.
9133 (init_display): Check for overflow more accurately, and without
9134 relying on undefined behavior.
9136 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
9137 Remove, replacing with the new symbols in lisp.h. All uses changed.
9138 * fileio.c (make_temp_name):
9139 * filelock.c (lock_file_1, lock_file):
9140 * xdisp.c (message_dolog):
9141 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
9142 Use pMd etc. instead.
9143 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
9144 replacing the pWIDE etc. symbols removed from editfns.c.
9146 * keyboard.h (num_input_events): Now uintmax_t.
9147 This is (very slightly) less likely to mess up due to wraparound.
9150 * buffer.c: Integer signedness fixes.
9151 (alloc_buffer_text, enlarge_buffer_text):
9152 Use ptrdiff_t rather than size_t when either will do, as we prefer
9155 * alloc.c: Integer signedness and overflow fixes.
9156 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
9157 (__malloc_size_t): Default to size_t, not to int.
9158 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
9159 (Fgarbage_collect, mark_object_loop_halt, mark_object):
9160 Prefer ptrdiff_t to size_t when either would do, as we prefer
9162 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
9163 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
9164 Now const. Initialize with values that are in range even if char
9166 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
9167 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
9168 These functions do the right thing with sizes > 2**32.
9169 (check_depth): Now ptrdiff_t, not int.
9170 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
9171 Adjust to new way of storing sizes. Check for size overflow bugs
9173 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
9174 slightly wrong anyway, as it missed one instance of
9175 XMALLOC_OVERRUN_CHECK_OVERHEAD.
9176 (refill_memory_reserve): Omit needless cast to size_t.
9177 (mark_object_loop_halt): Mark as externally visible.
9179 * xselect.c: Integer signedness and overflow fixes.
9180 (Fx_register_dnd_atom, x_handle_dnd_message):
9181 Use ptrdiff_t, not size_t, since we prefer signed.
9182 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
9183 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
9184 x_dnd_atoms_size and x_dnd_atoms_length.
9186 * doprnt.c: Prefer signed to unsigned when either works.
9188 * doprnt.c (doprnt):
9190 * xdisp.c (vmessage):
9191 Use ptrdiff_t, not size_t, when using or implementing doprnt,
9192 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
9193 prefer signed arithmetic to avoid comparison confusion.
9194 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
9195 but is a bit tricky.
9197 Assume freestanding C89 headers, string.h, stdlib.h.
9198 * data.c, doprnt.c, floatfns.c, print.c:
9199 Include float.h unconditionally.
9200 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
9201 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
9202 * regex.c: Likewise for stddef.h, string.h.
9203 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
9204 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
9205 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
9206 (STDC_HEADERS): Remove obsolete defines.
9207 * sysdep.c: Include limits.h unconditionally.
9209 Assume support for memcmp, memcpy, memmove, memset.
9210 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
9211 * regex.c (memcmp, memcpy):
9212 Remove; we assume C89 now.
9214 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
9215 (__malloc_safe_bcopy): Remove; no longer needed.
9217 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
9218 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
9219 well either way, and we prefer signed to unsigned.
9221 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
9223 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
9224 closes the connection while we're reading (bug#9182).
9226 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
9228 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
9229 are specified (Bug#9168).
9231 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
9233 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
9234 Found by GCC static checking and --with-wide-int on a 32-bit host.
9236 2011-07-25 Eli Zaretskii <eliz@gnu.org>
9238 * xdisp.c (compute_display_string_pos): Fix logic of caching
9239 previous display string position. Initialize cached_prev_pos to
9240 -1. Fixes slow-down at the beginning of a buffer.
9242 2011-07-24 Eli Zaretskii <eliz@gnu.org>
9244 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
9245 for attrs[LFACE_FONTSET_INDEX].
9247 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
9249 * xml.c (parse_region): Remove unused local
9250 that was recently introduced.
9252 2011-07-23 Eli Zaretskii <eliz@gnu.org>
9254 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
9255 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
9257 * xdisp.c (move_it_in_display_line_to): Record the best matching
9258 position for TO_CHARPOS while scanning the line, and restore it on
9259 exit if none of the characters scanned was an exact match.
9260 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
9261 when exact match is impossible due to invisible text, and the
9262 lines are truncated.
9264 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
9266 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
9269 2011-07-22 Eli Zaretskii <eliz@gnu.org>
9271 Fix a significant slow-down of cursor motion with C-n, C-p,
9272 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
9273 auto-repeat under bidi redisplay in fontified buffers.
9274 * xdisp.c (compute_stop_pos_backwards): New function.
9275 (next_element_from_buffer): Call compute_stop_pos_backwards to
9276 find a suitable prev_stop when we find ourselves before
9278 (reseat): Don't look for prev_stop, as that could mean a very long
9280 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
9281 <cached_disp_overlay_modiff>: Cache for last found display string
9283 (compute_display_string_pos): Return the cached position if asked
9284 about the same buffer in the same area of character positions, and
9285 the buffer wasn't changed since the time the display string
9286 position was cached.
9288 2011-07-22 Eli Zaretskii <eliz@gnu.org>
9290 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
9291 is an integer, which is important for empty lines. (Bug#9149)
9293 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
9295 * frame.c (Fmodify_frame_parameters): In tty case, update the
9296 default face if necessary (Bug#4238).
9298 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
9300 * editfns.c (Fstring_to_char): No need to explain what a character
9301 is in the docstring (Bug#6576).
9303 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9305 * xml.c (parse_region): Make sure we always return a tree.
9307 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
9309 * xml.c (parse_region): If a document contains only comments,
9312 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9314 * xml.c (make_dom): Return comments, too.
9316 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
9319 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
9320 and the surrounding thread.
9321 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
9322 rather than fgets, and retry after EINTR. Otherwise, 'emacs
9323 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
9325 * s/openbsd.h (BROKEN_SIGIO): Define.
9326 * unexelf.c (unexec) [__OpenBSD__]:
9327 Don't update the .mdebug section of the Alpha COFF symbol table.
9329 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
9331 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
9334 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
9336 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
9337 This fixes some race conditions on the permissions of any newly
9340 * alloc.c (valid_pointer_p): Use pipe, not open.
9341 This fixes some permissions issues when debugging.
9343 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
9344 If fchown fails to set both uid and gid, try to set just gid,
9345 as that is sometimes allowed. Adjust the file's mode to eliminate
9346 setuid or setgid bits that are inappropriate if fchown fails.
9348 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
9350 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
9351 to compare Lisp_Objects.
9352 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
9353 global_gnutls_log_level, don't mistake it for a Lisp_Object.
9354 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
9356 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
9358 * lread.c (read_integer): Unread even EOF character.
9359 (read1): Likewise. Properly record start position of symbol.
9361 * lread.c (read1): Read `#:' as empty uninterned symbol if no
9362 symbol character follows.
9364 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
9366 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
9367 This works around a problem with the previous change to Fcopy_file.
9368 Recent glibc declares fchown with __attribute__((warn_unused_result)),
9369 and without this change, GCC might complain about discarding
9370 fchown's return value.
9372 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
9374 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
9376 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
9378 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
9380 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
9382 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
9383 it's used from the C level.
9385 * process.c: Use the same condition for POLL_FOR_INPUT in both
9386 keyboard.c and process.c (bug#1858).
9388 2011-07-09 Lawrence Mitchell <wence@gmx.li>
9390 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
9391 (Fgnutls_boot): Use it.
9393 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
9395 * doc.c (Fsubstitute_command_keys): Revert last change.
9397 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
9399 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
9400 quotes the next character, and doesn't affect other longer
9401 sequences (bug#8935).
9403 * lread.c (syms_of_lread): Clarify that is isn't only
9404 `eval-buffer' and `eval-defun' that's affected by
9405 `lexical-binding' (bug#8460).
9407 2011-07-15 Eli Zaretskii <eliz@gnu.org>
9409 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
9410 bidi redisplay when a line includes both an image and is truncated.
9412 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
9414 Fix minor problems found by static checking.
9415 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
9416 (elsz): Now a signed constant, not a size_t var. We prefer signed
9417 types to unsigned, to avoid integer comparison confusion. Without
9418 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
9419 "cannot optimize loop, the loop counter may overflow", a symptom
9421 * indent.c (Fvertical_motion): Mark locals as initialized.
9422 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
9424 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9426 * search.c (Fre_search_backward): Mention `case-fold-search' in
9427 all the re_search_* functions (bug#8138).
9429 * keyboard.c (Fopen_dribble_file): Document when the file is
9432 2011-07-14 Eli Zaretskii <eliz@gnu.org>
9434 * bidi.c (bidi_dump_cached_states): Fix format of displaying
9437 Support bidi reordering of display and overlay strings.
9438 * xdisp.c (compute_display_string_pos)
9439 (compute_display_string_end): Accept additional argument STRING.
9440 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
9441 (reseat_to_string): Initialize bidi_it->string.s and
9442 bidi_it->string.schars.
9443 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
9444 NULL (avoids a crash in bidi_paragraph_init).
9445 Initialize itb.string.lstring.
9446 (init_iterator): Call bidi_init_it only of a valid
9447 buffer position was specified. Initialize paragraph_embedding to
9449 (reseat_to_string): Initialize the bidi iterator.
9450 (display_string): If we need to ignore text properties of
9451 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
9452 original value of -1 will not work with bidi.)
9453 (compute_display_string_pos): First arg is now struct
9454 `text_pos *'; all callers changed. Support display properties on
9456 (compute_display_string_end): Support display properties on Lisp
9458 (init_iterator, reseat_1, reseat_to_string): Initialize the
9459 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
9460 when iterating on a string not from display properties).
9461 (compute_display_string_pos, compute_display_string_end):
9462 Fix calculation of the object to scan. Fixes an error when using
9464 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
9465 base_level_stop; instead, set base_level_stop to BEGV.
9466 Fixes crashes in vertical-motion.
9467 (next_element_from_buffer): Improve commentary for when
9468 the iterator is before prev_stop.
9469 (init_iterator): Initialize bidi_p from the default value of
9470 bidi-display-reordering, not from buffer-local value. Use the
9471 buffer-local value only if initializing for buffer iteration.
9472 (handle_invisible_prop): Support invisible properties on strings
9473 that are being bidi-reordered.
9474 (set_iterator_to_next): Support bidi reordering of C strings and
9476 (next_element_from_string): Support bidi reordering of Lisp
9478 (handle_stop_backwards): Support Lisp strings as well.
9479 (display_string): Support display of R2L glyph rows.
9480 Use IT_STRING_CHARPOS when displaying from a Lisp string.
9481 (init_iterator): Don't initialize it->bidi_p for strings
9483 (reseat_to_string): Initialize it->bidi_p for strings here.
9484 (next_element_from_string, next_element_from_c_string)
9485 (next_element_from_buffer): Add xassert's for correspondence
9486 between IT's object being iterated and it->bidi_it.string
9488 (face_before_or_after_it_pos): Support bidi iteration.
9489 (next_element_from_c_string): Handle the case of the first string
9490 character that is not the first one in the visual order.
9491 (get_visually_first_element): New function, refactored from common
9492 parts of next_element_from_buffer, next_element_from_string, and
9493 next_element_from_c_string.
9494 (tool_bar_lines_needed, redisplay_tool_bar)
9495 (display_menu_bar): Force left-to-right direction. Add a FIXME
9496 comment for making that be controlled by a user option.
9497 (push_it, pop_it): Save and restore the state of the
9498 bidi iterator. Save and restore the bidi_p flag.
9499 (pop_it): Iterate out of display property for string iteration as
9501 (iterate_out_of_display_property): Support iteration over strings.
9502 (handle_single_display_spec): Set up it->bidi_it for iteration
9503 over a display string, and call bidi_init_it.
9504 (handle_single_display_spec, next_overlay_string)
9505 (get_overlay_strings_1, push_display_prop): Set up the bidi
9506 iterator for displaying display or overlay strings.
9507 (forward_to_next_line_start): Don't use the shortcut if
9509 (back_to_previous_visible_line_start): If handle_display_prop
9510 pushed the iterator stack, restore the internal state of the bidi
9511 iterator by calling bidi_pop_it same number of times.
9512 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
9513 and we are bidi-iterating, don't decrement the iterator position;
9514 instead, set the first_elt flag in the bidi iterator, to produce
9516 (reseat_1): Remove redundant setting of string_from_display_prop_p.
9517 (push_display_prop): xassert that we are iterating a buffer.
9518 (push_it, pop_it): Save and restore paragraph_embedding member.
9519 (handle_single_display_spec, next_overlay_string)
9520 (get_overlay_strings_1, reseat_1, reseat_to_string)
9521 (push_display_prop): Set up the `unibyte' member of bidi_it.string
9522 correctly. Don't assume unibyte strings are not bidi-reordered.
9523 (compute_display_string_pos)
9524 (compute_display_string_end): Fix handling the case of C string.
9525 (push_it, pop_it): Save and restore from_disp_prop_p.
9526 (handle_single_display_spec, push_display_prop): Set the
9527 from_disp_prop_p flag.
9528 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
9529 (pop_it): Call iterate_out_of_display_property only if we are
9530 popping after iteration over a string that came from a display
9531 property. Fix a typo in popping stretch info. Add an assertion
9532 for verifying that the iterator position is in sync with the bidi
9534 (handle_single_display_spec, get_overlay_strings_1)
9535 (push_display_prop): Fix initialization of paragraph direction for
9536 string when that of the parent object is not yet determined.
9537 (reseat_1): Call bidi_init_it to resync the bidi
9538 iterator with IT's position. (Bug#7616)
9539 (find_row_edges): If ROW->start.pos gives position
9540 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
9541 (handle_stop, back_to_previous_visible_line_start, reseat_1):
9542 Reset the from_disp_prop_p flag.
9543 (SAVE_IT, RESTORE_IT): New macros.
9544 (pos_visible_p, face_before_or_after_it_pos)
9545 (back_to_previous_visible_line_start)
9546 (move_it_in_display_line_to, move_it_in_display_line)
9547 (move_it_to, move_it_vertically_backward, move_it_by_lines)
9548 (try_scrolling, redisplay_window, display_line): Use them when
9549 saving a temporary copy of the iterator and restoring it back.
9550 (back_to_previous_visible_line_start, reseat_1)
9551 (init_iterator): Empty the bidi cache "stack".
9552 (move_it_in_display_line_to): If iterator ended up at
9553 EOL, but we never saw any buffer positions smaller than
9554 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
9555 motion in bidi-reordered lines.
9556 (move_it_in_display_line_to): Record prev_method and prev_pos
9557 immediately before the call to set_iterator_to_next. Fixes cursor
9558 motion in bidi-reordered lines with stretch glyphs and strings
9559 displayed in margins. (Bug#8133) (Bug#8867)
9560 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
9562 (pos_visible_p): Support positions in bidi-reordered lines.
9563 Save and restore bidi cache.
9565 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
9566 (bidi_paragraph_info): Delete unused struct.
9567 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
9568 (bidi_cache_start): New variable.
9569 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
9571 (bidi_cache_fetch_state, bidi_cache_search)
9572 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9573 (bidi_cache_find, bidi_peek_at_next_level)
9574 (bidi_level_of_next_char, bidi_find_other_level_edge)
9575 (bidi_move_to_visually_next): Compare cache index with
9576 bidi_cache_start rather than with zero.
9577 (bidi_fetch_char): Accept new argument STRING; all callers
9578 changed. Support iteration over a string. Support strings with
9579 display properties. Support unibyte strings. Fix the type of
9580 `len' according to what STRING_CHAR_AND_LENGTH expects.
9581 (bidi_paragraph_init, bidi_resolve_explicit_1)
9582 (bidi_resolve_explicit, bidi_resolve_weak)
9583 (bidi_level_of_next_char, bidi_move_to_visually_next):
9584 Support iteration over a string.
9585 (bidi_set_sor_type, bidi_resolve_explicit_1)
9586 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9587 can now be zero (for strings); special values 0 and -1 were
9588 changed to -1 and -2, respectively.
9589 (bidi_char_at_pos): New function.
9590 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9591 Call it instead of FETCH_MULTIBYTE_CHAR.
9592 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9593 initialized to valid values.
9594 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9596 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9597 the test for valid cached positions. Fix the logic for looking up
9598 the sentinel state in the cache. GCPRO the Lisp string we are
9600 (bidi_push_it, bidi_pop_it): New functions.
9601 (bidi_initialize): Initialize the bidi cache start stack pointer.
9602 (bidi_cache_ensure_space): New function, refactored from part of
9603 bidi_cache_iterator_state. Don't assume the required size is just
9604 one BIDI_CACHE_CHUNK away.
9605 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9606 (bidi_count_bytes, bidi_char_at_pos): New functions.
9607 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9608 always valid if bidi_cache_idx is valid.
9609 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9610 is valid if it's going to be used.
9611 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9612 (bidi_cache_fetch_state, bidi_cache_search)
9613 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9614 (bidi_cache_iterator_state, bidi_cache_find)
9615 (bidi_find_other_level_edge, bidi_cache_start_stack):
9616 All variables related to cache indices are now EMACS_INT.
9618 * dispextern.h (struct bidi_string_data): New structure.
9619 (struct bidi_it): New member `string'. Make flag members be 1-bit
9620 fields, and put them last in the struct.
9621 (compute_display_string_pos, compute_display_string_end):
9623 (bidi_push_it, bidi_pop_it): Add prototypes.
9624 (struct iterator_stack_entry): New members bidi_p,
9625 paragraph_embedding, and from_disp_prop_p.
9626 (struct it): Member bidi_p is now a bit field 1 bit wide.
9627 (bidi_shelve_cache, bidi_unshelve_cache):
9630 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9631 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9632 and vector-like objects.
9634 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9635 cache around display iteration.
9637 * window.c (Fwindow_end, window_scroll_pixel_based)
9638 (displayed_window_lines, Frecenter): Save and restore the bidi
9639 cache around display iteration.
9641 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9643 * editfns.c (Fdelete_region): Clarify the use of the named
9644 parameters (bug#6788).
9646 2011-07-14 Martin Rudalics <rudalics@gmx.at>
9648 * indent.c (Fvertical_motion): Set and restore w->pointm when
9649 saving and restoring the window's buffer (Bug#9006).
9651 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9653 * editfns.c (Fstring_to_char): Clarify just what is returned
9654 (bug#6576). Text by Eli Zaretskii.
9656 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
9658 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9660 2011-07-13 Eli Zaretskii <eliz@gnu.org>
9662 * buffer.c (mmap_find): Fix a typo.
9664 2011-07-13 Johan Bockgård <bojohan@gnu.org>
9666 Fix execution of x selection hooks.
9667 * xselect.c (Qx_lost_selection_functions)
9668 (Qx_sent_selection_functions): New vars.
9669 (syms_of_xselect): DEFSYM them.
9670 (x_handle_selection_request): Pass Qx_sent_selection_functions
9671 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9672 (x_handle_selection_clear,x_clear_frame_selections):
9673 Pass Qx_lost_selection_functions rather than
9674 Vx_lost_selection_functions to Frun_hook_with_args.
9676 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9678 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
9679 The old code sometimes used this field without initializing it.
9681 * alloc.c (gc_sweep): Don't read past end of array.
9682 In theory, the old code could also have corrupted Emacs internals,
9683 though it'd be very unlikely.
9685 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9687 * character.c (Fcharacterp): Don't advertise optional ignored
9688 argument. (Bug#4026)
9690 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9692 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9695 * window.c (Fset_window_start): Doc fix (bug#4199).
9696 (Fset_window_hscroll): Ditto.
9698 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9700 Fix minor new problems caught by GCC 4.6.1.
9701 * term.c (init_tty): Remove unused local.
9702 * xsettings.c (store_monospaced_changed): Define this function only
9703 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
9706 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
9708 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9710 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9712 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9713 are the mini-buffer and the echo area (bug#3320).
9715 * term.c (init_tty): Remove support for supdup, c10 and perq
9716 terminals, which are no longer supported (bug#1482).
9718 2011-07-10 Johan Bockgård <bojohan@gnu.org>
9720 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9722 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9724 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9725 for non-popups (Bug#3642).
9727 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9729 * alloc.c (reset_malloc_hooks): Protoize.
9730 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
9731 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9732 * cm.c (losecursor): Likewise.
9733 * data.c (fmod): Likewise.
9734 * dispnew.c (swap_glyphs_in_rows): Likewise.
9735 * emacs.c (memory_warning_signal): Likewise.
9736 * floatfns.c (float_error): Likewise.
9737 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9738 (otf_open, font_otf_capability, generate_otf_features)
9739 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9741 * image.c (pbm_read_file): Likewise.
9742 * indent.c (string_display_width): Likewise.
9743 * intervals.c (check_for_interval, search_for_interval)
9744 (inc_interval_count, count_intervals, root_interval)
9745 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9746 * lread.c (defalias): Likewise.
9747 * ralloc.c (r_alloc_check): Likewise.
9748 * regex.c (set_image_of_range_1, set_image_of_range)
9749 (regex_grow_registers): Likewise.
9750 * sysdep.c (strerror): Likewise.
9751 * termcap.c (valid_filename_p, tprint, main): Likewise.
9752 * tparam.c (main): Likewise.
9753 * unexhp9k800.c (run_time_remap, save_data_space)
9754 (update_file_ptrs, read_header, write_header, calculate_checksum)
9755 (copy_file, copy_rest, display_header): Likewise.
9756 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9758 * xdisp.c (check_it): Likewise.
9759 * xfaces.c (register_color, unregister_color, unregister_colors):
9761 * xfns.c (print_fontset_result): Likewise.
9762 * xrdb.c (member, fatal, main): Likewise.
9764 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9766 Fix minor problems found by static checking (Bug#9031).
9767 * chartab.c (char_table_set_range, map_sub_char_table):
9768 Remove unused locals.
9769 (uniprop_table): Now static.
9770 * composite.c (_work_char): Remove unused static var.
9772 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
9774 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9776 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9778 * gtkutil.c (qttip_cb): Remove code without function.
9780 2011-07-09 Eli Zaretskii <eliz@gnu.org>
9782 * w32.c (pthread_sigmask): New stub.
9784 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
9786 Use pthread_sigmask, not sigprocmask (Bug#9010).
9787 sigprocmask is portable only for single-threaded applications, and
9788 Emacs can be multi-threaded when it uses GTK.
9789 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9791 * callproc.c (Fcall_process):
9792 * process.c (create_process):
9793 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9794 Use pthread_sigmask, not sigprocmask.
9796 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9798 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9799 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9802 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9804 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9805 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9806 (xg_hide_tooltip): Fix comment.
9808 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9809 in registerServicesMenuSendTypes.
9810 (validRequestorForSendType): Don't check ns_return_types.
9812 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9815 2011-07-08 Jason Rumney <jasonr@gnu.org>
9817 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9818 SH_SHOW for hidden windows (Bug#5482).
9820 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9821 frame struct members of non-existent frames (Bug#6284).
9823 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9825 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9826 variable firstTime not needed on OSX >= 10.6.
9827 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9828 >= 10.5. Use setKnobProportion, setDoubleValue.
9830 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9831 (MAC_OS_X_VERSION_10_5): Define if not defined.
9832 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9833 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9834 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9836 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
9837 cString and lossyCString on OSX >= 10.4.
9839 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
9840 sizeToFit on OSX >= 10.2.
9842 * nsimage.m (allocInitFromFile): Don't use deprecated method
9843 bestRepresentationForDevice on OSX >= 10.6.
9845 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9848 * emacs.c: Declare unexec_init_emacs_zone.
9850 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9852 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9854 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9855 on svcsMenu (Bug#8842).
9857 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9859 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9861 * nsterm.m (QUTF8_STRING): Declare.
9862 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9863 (validRequestorForSendType): Return type is (id).
9864 Change indexOfObjectIdenticalTo to indexOfObject.
9865 Check if we have local selection before returning self (Bug#8842).
9866 (writeSelectionToPasteboard): Put local selection into paste board
9867 if we have a local selection (Bug#8842).
9868 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9870 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9871 (ns_get_local_selection): Declare.
9873 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9875 * keymap.c (describe_map_tree): Don't insert a double newline at
9876 the end of the buffer (bug#1169) and return whether we inserted
9879 * callint.c (Fcall_interactively): Change "reading args" to
9880 "providing args" to try to clarify what it does (bug#1010).
9882 2011-07-07 Kenichi Handa <handa@m17n.org>
9884 * composite.c (composition_compute_stop_pos): Ignore a static
9885 composition starting before CHARPOS (Bug#8915).
9887 * xdisp.c (handle_composition_prop): Likewise.
9889 2011-07-07 Eli Zaretskii <eliz@gnu.org>
9891 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9894 2011-07-07 Kenichi Handa <handa@m17n.org>
9896 * character.h (unicode_category_t): New enum type.
9898 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9899 (Qchar_code_property_table): New variable.
9900 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9901 (UNIPROP_COMPRESSED_FORM_P): New macros.
9902 (char_table_ascii): Uncompress the compressed values.
9903 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9904 Uncompress the compressed values.
9905 (sub_char_table_ref_and_range): Likewise.
9906 (char_table_ref_and_range): Uncompress the compressed values.
9907 (sub_char_table_set): New arg is_uniprop. Callers changed.
9908 Uncompress the compressed values.
9909 (sub_char_table_set_range): Args changed. Callers changed.
9910 (char_table_set_range): Adjuted for the above change.
9911 (map_sub_char_table): Delete args default_val and parent. Add arg
9912 top. Give decoded values to a Lisp function.
9913 (map_char_table): Adjust for the above change. Give decoded
9914 values to a Lisp function. Gcpro more variables.
9915 (uniprop_table_uncompress)
9916 (uniprop_decode_value_run_length): New functions.
9917 (uniprop_decoder, uniprop_decoder_count): New variables.
9918 (uniprop_get_decoder, uniprop_encode_value_character)
9919 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9921 (uniprop_encoder, uniprop_encoder_count): New variables.
9922 (uniprop_get_encoder, uniprop_table)
9923 (Funicode_property_table_internal, Fget_unicode_property_internal)
9924 (Fput_unicode_property_internal): New functions.
9925 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9926 Sunicode_property_table_internal, Sget_unicode_property_internal,
9927 and Sput_unicode_property_internal. Defvar_lisp
9928 char-code-property-alist.
9930 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
9931 Vunicode_category_table.
9933 * font.c (font_range): Adjust for the change of
9934 Vunicode_category_table.
9936 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9938 * m/iris4d.h: Remove file, move contents ...
9939 * s/irix6-5.h: ... here.
9941 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9943 Remove unportable assumption about struct layout (Bug#8884).
9944 * alloc.c (mark_buffer):
9945 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9946 (clone_per_buffer_values): Don't assume that
9947 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9948 This isn't true in general, and it's particularly not true
9949 if Emacs is configured with --with-wide-int.
9950 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9951 New macros, used in the buffer.c change.
9953 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9955 * xsettings.c: Use both GConf and GSettings if both are available.
9956 (store_config_changed_event): Add comment.
9957 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9958 (store_tool_bar_style_changed): New functions.
9959 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
9960 (struct xsettings): Move font inside HAVE_XFT.
9961 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
9962 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
9963 Move inside HAVE_XFT.
9964 (something_changed_gsettingsCB): Rename from something_changedCB.
9965 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9967 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
9968 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
9969 (something_changed_gconfCB): Rename from something_changedCB.
9970 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9971 (parse_settings): Move check for font inside HAVE_XFT.
9972 (read_settings, apply_xft_settings): Add comment.
9973 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9974 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9975 call store_font_name_changed.
9976 (xft_settings_event): Add comment.
9977 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9978 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9979 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9980 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9981 (xsettings_initialize): Call init_gsettings last.
9982 (xsettings_get_system_font, xsettings_get_system_normal_font):
9985 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9987 Random fixes. E.g., (random) never returned negative values.
9988 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9989 subseconds part to the entropy, as that's a bit more random.
9990 Prefer signed to unsigned, since the signedness doesn't matter and
9991 in general we prefer signed. When given a limit, use a
9992 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9993 latter isn't right if USE_2_TAGS_FOR_INTS.
9994 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9995 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9997 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9999 * textprop.c (text_property_stickiness):
10000 Obey Vtext_property_default_nonsticky.
10001 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
10002 * w32fns.c (syms_of_w32fns):
10003 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
10005 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
10007 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
10008 This is more efficient than Ffile_directory_p and avoids a minor race.
10010 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
10012 * buffer.c (Foverlay_put): Say what the return value is
10015 * fileio.c (barf_or_query_if_file_exists): Check first if the file
10016 is a directory before asking whether to use the file name
10018 (barf_or_query_if_file_exists): Make the "File is a directory"
10019 error be more correct.
10021 * fns.c (Frequire): Remove the mention of the .gz files, since
10022 that's installation-specific, but keep the mention of
10023 `get-load-suffixes'.
10025 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
10027 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
10028 Report string overflow if the output is too long.
10030 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
10032 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
10033 (syms_of_gnutls): Remove duplicate DEFSYM for
10034 Qgnutls_bootprop_verify_hostname_error, an error for
10035 Qgnutls_bootprop_verify_error (which is no longer used).
10037 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
10038 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
10039 Also (re)move comments that are misplaced or no longer relevant.
10041 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10043 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
10045 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
10047 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
10048 and background color parameters if they have been changed.
10050 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10052 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
10054 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
10056 * xsettings.c (SYSTEM_FONT): Define only when used.
10057 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
10059 * keymap.c (access_keymap_1): Now static.
10061 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
10063 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
10064 leave any prefix arg for the up event (Bug#1586).
10066 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
10068 * lread.c (syms_of_lread): Mention single symbols defined by
10069 `defvar' or `defconst' (bug#7154).
10071 * fns.c (Frequire): Mention .el.gz files (bug#7314).
10072 (Frequire): Mention get-load-suffixes.
10074 2011-07-02 Martin Rudalics <rudalics@gmx.at>
10076 * window.h (window): Remove clone_number slot.
10077 * window.c (Fwindow_clone_number, Fset_window_clone_number):
10079 (make_parent_window, make_window, saved_window)
10080 (Fset_window_configuration, save_window_save): Don't deal with
10082 * buffer.c (Qclone_number): Remove declaration.
10083 (sort_overlays, overlay_strings): Don't deal with clone numbers.
10085 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
10087 Add multiple inheritance to keymaps.
10088 * keymap.c (Fmake_composed_keymap): New function.
10089 (Fset_keymap_parent): Simplify.
10090 (fix_submap_inheritance): Remove.
10091 (access_keymap_1): New function extracted from access_keymap to handle
10092 embedded parents and handle lists of maps.
10093 (access_keymap): Use it.
10094 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
10095 (Fcopy_keymap): Handle embedded parents.
10096 (Fcommand_remapping, define_as_prefix): Simplify.
10097 (Fkey_binding): Simplify.
10098 (syms_of_keymap): Move minibuffer-local-completion-map,
10099 minibuffer-local-filename-completion-map,
10100 minibuffer-local-must-match-map, and
10101 minibuffer-local-filename-must-match-map to Elisp.
10102 (syms_of_keymap): Defsubr make-composed-keymap.
10103 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
10104 (parse_menu_item): Trivial simplification.
10106 2011-07-01 Glenn Morris <rgm@gnu.org>
10108 * Makefile.in (SETTINGS_LIBS): Fix typo.
10110 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
10112 * coding.c (Fencode_coding_string): Record the last coding system
10113 used, as the function doc string says (bug#8738).
10115 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
10117 * xsettings.c (store_monospaced_changed): Take new font as arg and
10118 check for change against current_mono_font.
10119 (EMACS_TYPE_SETTINGS): Remove this and related defines.
10120 (emacs_settings_constructor, emacs_settings_get_property)
10121 (emacs_settings_set_property, emacs_settings_class_init)
10122 (emacs_settings_init, gsettings_obj): Remove.
10123 (something_changedCB): New function for HAVE_GSETTINGS.
10124 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
10125 with value as argument.
10126 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
10127 g_settings_new (Bug#8967). Do not create gsettings_obj.
10128 Remove calls to g_settings_bind. Connect something_changedCB to
10131 * xgselect.c: Add defined (HAVE_GSETTINGS).
10132 (xgselect_initialize): Ditto.
10134 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
10135 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
10138 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
10140 * eval.c (struct backtrace): Simplify and port the data structure.
10141 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
10142 signed bit field, as this assumption is not portable and it makes
10143 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
10144 "char debug_on_exit : 1" as this is not portable either; instead,
10145 use the portable "unsigned int debug_on_exit : 1". Remove unused
10146 member evalargs. Remove obsolete comments about cc bombing out.
10148 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
10150 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
10151 Let HAVE_GSETTINGS override HAVE_GCONF.
10152 (store_monospaced_changed): New function.
10153 (EMACS_SETTINGS): A new type derived from GObject to handle
10154 GSettings notifications.
10155 (emacs_settings_constructor, emacs_settings_get_property)
10156 (emacs_settings_set_property, emacs_settings_class_init):
10158 (gsettings_client, gsettings_obj): New variables.
10159 (GSETTINGS_SCHEMA): New define.
10160 (something_changedCB): Call store_monospaced_changed.
10161 (init_gsettings): New function.
10162 (xsettings_initialize): Call init_gsettings.
10163 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
10166 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
10169 2011-06-29 Martin Rudalics <rudalics@gmx.at>
10171 * window.c (resize_root_window, grow_mini_window)
10172 (shrink_mini_window): Rename Qresize_root_window to
10173 Qwindow_resize_root_window and Qresize_root_window_vertically to
10174 Qwindow_resize_root_window_vertically.
10176 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
10178 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
10180 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
10182 * makefile.w32-in: Redesign dependencies so they reflect more
10183 clearly which files are directly included by each source file,
10184 and not through other includes.
10186 2011-06-27 Martin Rudalics <rudalics@gmx.at>
10188 * buffer.c (Qclone_number): Declare static and DEFSYM it.
10189 (sort_overlays, overlay_strings): When an overlay's clone number
10190 matches the window's clone number process the overlay even if
10191 the overlay's window property doesn't match the current window.
10193 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
10194 (Fwindow_hchild): Rename to Fwindow_left_child.
10195 (Fwindow_next): Rename to Fwindow_next_sibling.
10196 (Fwindow_prev): Rename to Fwindow_prev_sibling.
10197 (resize_window_check): Rename to window_resize_check.
10198 (resize_window_apply): Rename to window_resize_apply.
10199 (Fresize_window_apply): Rename to Fwindow_resize_apply.
10200 (Fdelete_other_windows_internal, resize_frame_windows)
10201 (Fsplit_window_internal, Fdelete_window_internal)
10202 (grow_mini_window, shrink_mini_window)
10203 (Fresize_mini_window_internal): Fix callers accordingly.
10205 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
10207 * emacsgtkfixed.h: State that this is only used with Gtk+3.
10208 (emacs_fixed_set_min_size): Remove.
10209 (emacs_fixed_new): Take frame as argument.
10211 * emacsgtkfixed.c: State that this is only used with Gtk+3.
10212 (_EmacsFixedPrivate): Remove minwidth/height.
10213 Add struct frame *f.
10214 (emacs_fixed_init): Initialize priv->f.
10215 (get_parent_class, emacs_fixed_set_min_size): Remove.
10216 (emacs_fixed_new): Set priv->f to argument.
10217 (emacs_fixed_get_preferred_width)
10218 (emacs_fixed_get_preferred_height): Use min_width/height from
10219 frames size_hint to set minimum and natural (Bug#8919).
10220 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
10221 and use min_width/height from frames size_hint to set
10222 min_width/height (Bug#8919).
10224 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
10225 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
10228 2011-06-26 Eli Zaretskii <eliz@gnu.org>
10230 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
10231 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
10234 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
10236 * process.c (wait_reading_process_output): Bypass select if
10237 waiting for a cell while ignoring keyboard input, and input is
10238 pending. Suggested by Jan Djärv (Bug#8869).
10240 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
10242 Use gnulib's dup2 module instead of rolling our own.
10243 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
10245 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10247 * dispnew.c (scrolling_window): Before scrolling, turn off a
10248 mouse-highlight in the window being scrolled.
10250 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
10252 Move DEFSYM to lisp.h and use everywhere.
10254 * character.h (DEFSYM): Move declaration...
10255 * lisp.h (DEFSYM): ...here.
10261 * w32select.c: Don't include character.h.
10263 * alloc.c (syms_of_alloc):
10264 * buffer.c (syms_of_buffer):
10265 * bytecode.c (syms_of_bytecode):
10266 * callint.c (syms_of_callint):
10267 * casefiddle.c (syms_of_casefiddle):
10268 * casetab.c (init_casetab_once):
10269 * category.c (init_category_once, syms_of_category):
10270 * ccl.c (syms_of_ccl):
10271 * cmds.c (syms_of_cmds):
10272 * composite.c (syms_of_composite):
10273 * dbusbind.c (syms_of_dbusbind):
10274 * dired.c (syms_of_dired):
10275 * dispnew.c (syms_of_display):
10276 * doc.c (syms_of_doc):
10277 * editfns.c (syms_of_editfns):
10278 * emacs.c (syms_of_emacs):
10279 * eval.c (syms_of_eval):
10280 * fileio.c (syms_of_fileio):
10281 * fns.c (syms_of_fns):
10282 * frame.c (syms_of_frame):
10283 * fringe.c (syms_of_fringe):
10284 * insdel.c (syms_of_insdel):
10285 * keymap.c (syms_of_keymap):
10286 * lread.c (init_obarray, syms_of_lread):
10287 * macros.c (syms_of_macros):
10288 * msdos.c (syms_of_msdos):
10289 * print.c (syms_of_print):
10290 * process.c (syms_of_process):
10291 * search.c (syms_of_search):
10292 * sound.c (syms_of_sound):
10293 * syntax.c (init_syntax_once, syms_of_syntax):
10294 * terminal.c (syms_of_terminal):
10295 * textprop.c (syms_of_textprop):
10296 * undo.c (syms_of_undo):
10297 * w32.c (globals_of_w32):
10298 * window.c (syms_of_window):
10299 * xdisp.c (syms_of_xdisp):
10300 * xfaces.c (syms_of_xfaces):
10301 * xfns.c (syms_of_xfns):
10302 * xmenu.c (syms_of_xmenu):
10303 * xsettings.c (syms_of_xsettings):
10304 * xterm.c (syms_of_xterm): Use DEFSYM.
10306 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
10308 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
10310 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
10312 Integer and buffer overflow fixes (Bug#8873).
10314 * print.c (printchar, strout): Check for string overflow.
10315 (PRINTPREPARE, printchar, strout):
10316 Don't set size unless allocation succeeds.
10318 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
10319 for sizes. Check for string overflow more accurately.
10320 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
10322 * macros.c: Integer and buffer overflow fixes.
10323 * keyboard.h (struct keyboard.kbd_macro_bufsize):
10324 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
10325 Use ptrdiff_t, not int, for sizes.
10326 Don't increment bufsize until after realloc succeeds.
10327 Check for size-calculation overflow.
10328 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
10330 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
10332 * lread.c: Integer overflow fixes.
10333 (read_integer): Radix is now EMACS_INT, not int,
10334 to improve quality of diagnostics for out-of-range radices.
10335 Calculate buffer size correctly for out-of-range radices.
10336 (read1): Check for integer overflow in radices, and in
10337 read-circle numbers.
10338 (read_escape): Avoid int overflow.
10339 (Fload, openp, read_buffer_size, read1)
10340 (substitute_object_recurse, read_vector, read_list, map_obarray):
10341 Use ptrdiff_t, not int, for sizes.
10342 (read1): Use EMACS_INT, not int, for sizes.
10343 Check for size overflow.
10345 * image.c (cache_image): Check for size arithmetic overflow.
10347 * lread.c: Integer overflow issues.
10348 (saved_doc_string_size, saved_doc_string_length)
10349 (prev_saved_doc_string_size, prev_saved_doc_string_length):
10350 Now ptrdiff_t, not int.
10351 (read1): Don't assume doc string length fits in int. Check for
10352 out-of-range doc string lengths.
10353 (read_list): Don't assume file position fits in int.
10354 (read_escape): Check for hex character overflow.
10356 2011-06-22 Leo Liu <sdl.web@gmail.com>
10358 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
10359 Move to minibuffer.el.
10361 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10363 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
10364 The following patches are for when GLYPH_DEBUG && !XASSERT.
10365 * dispextern.h (trace_redisplay_p, dump_glyph_string):
10366 * dispnew.c (flush_stdout):
10367 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
10368 Mark as externally visible.
10369 * dispnew.c (check_window_matrix_pointers): Now static.
10370 * dispnew.c (window_to_frame_vpos):
10371 * xfns.c (unwind_create_frame):
10372 * xterm.c (x_check_font): Remove unused local.
10373 * scroll.c (CHECK_BOUNDS):
10374 * xfaces.c (cache_fache): Rename local to avoid shadowing.
10375 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
10376 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
10377 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
10378 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
10380 (debug_method_add): Use va_list and vsprintf rather than relying
10381 on undefined behavior with wrong number of arguments.
10382 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
10383 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
10384 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
10385 since we're not interested in debugging glyphs with old libraries.
10386 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
10387 GCC 4.6.0's static checking.
10389 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10391 Integer overflow and signedness fixes (Bug#8873).
10392 A few related buffer overrun fixes, too.
10394 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
10396 * dispextern.h (struct face.stipple):
10397 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
10398 (x_bitmap_mask, x_allocate_bitmap_record)
10399 (x_create_bitmap_from_data, x_create_bitmap_from_file)
10400 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
10401 (x_create_bitmap_from_xpm_data):
10402 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
10403 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
10405 * xfaces.c (load_pixmap):
10406 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
10407 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
10408 (.bitmaps_last, struct x_output.icon_bitmap):
10409 Use ptrdiff_t, not int, for bitmap indexes.
10410 (x_allocate_bitmap_record): Check for size overflow.
10411 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
10413 Use ptrdiff_t, not int, for overlay counts.
10414 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
10415 * editfns.c (overlays_around, get_pos_property):
10416 * textprop.c (get_char_property_and_overlay):
10417 * xdisp.c (next_overlay_change, note_mouse_highlight):
10418 * xfaces.c (face_at_buffer_position):
10419 * buffer.c (OVERLAY_COUNT_MAX): New macro.
10420 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
10421 (Fnext_overlay_change, Fprevious_overlay_change)
10422 (mouse_face_overlay_overlaps, Foverlays_in):
10423 Use ptrdiff_t, not int, for sizes.
10424 (overlays_at, overlays_in): Check for size-calculation overflow.
10426 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
10428 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
10429 (x_session_initialize): Do not assume string length fits in int.
10431 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
10432 This is unlikely, but can occur if DPI is outlandish.
10434 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
10435 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
10437 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
10438 * xrdb.c (magic_file_p, search_magic_path):
10439 Omit last arg SUFFIX; it was always 0. All callers changed.
10440 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
10442 * xfont.c (xfont_match): Avoid need for strlen.
10444 * xfns.c: Don't assume strlen fits in int.
10445 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
10447 * xdisp.c (message_log_check_duplicate): Return intmax_t,
10448 not unsigned long, as we prefer signed integers. All callers changed.
10449 Detect integer overflow in repeat count.
10450 (message_dolog): Don't assume print length fits in 39 bytes.
10451 (display_mode_element): Don't assume strlen fits in int.
10453 * termcap.c: Don't assume sizes fit in int and never overflow.
10454 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
10455 (gobble_line): Check for size-calculation overflow.
10457 * minibuf.c (Fread_buffer):
10458 * lread.c (intern, intern_c_string):
10459 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
10460 Don't assume string length fits in int.
10462 * keyboard.c (parse_tool_bar_item):
10463 * gtkutil.c (style_changed_cb): Avoid need for strlen.
10465 * font.c: Don't assume string length fits in int.
10466 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
10467 Use ptrdiff_t, not int.
10468 (font_intern_prop): Don't assume string length fits in int.
10469 Don't assume integer property fits in fixnum.
10470 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
10472 * filelock.c: Fix some buffer overrun and integer overflow issues.
10473 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
10474 Reformulate so as not to need the command string.
10475 Invoke gzip -cd rather than gunzip, as it's more portable.
10476 (lock_info_type, lock_file_1, lock_file):
10477 Don't assume pid_t and time_t fit in unsigned long.
10478 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
10479 (current_lock_owner): Prefer signed type for sizes.
10480 Use memcpy, not strncpy, where memcpy is what is really wanted.
10481 Don't assume (via atoi) that time_t and pid_t fit in int.
10482 Check for time_t and/or pid_t out of range, e.g., via a network share.
10483 Don't alloca where an auto var works fine.
10485 * fileio.c: Fix some integer overflow issues.
10486 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
10487 Don't assume string length fits in int.
10488 (directory_file_name): Don't assume string length fits in long.
10489 (make_temp_name): Don't assume pid fits in int, or that its print
10490 length is less than 20.
10492 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
10494 * coding.c (make_subsidiaries): Don't assume string length fits in int.
10496 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
10498 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
10499 We prefer signed integers, even for size calculations.
10501 * emacs.c: Don't assume string length fits in 'int'.
10502 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
10503 (main): Don't invoke strlen when not needed.
10505 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
10506 (XD_DEBUG_MESSAGE): Don't waste a byte.
10508 * callproc.c (getenv_internal_1, getenv_internal)
10509 (Fgetenv_internal):
10510 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
10512 * lread.c (invalid_syntax): Omit length argument.
10513 All uses changed. This doesn't fix a bug, but it simplifies the
10514 code away from its former Hollerith-constant appearance, and it's
10515 one less 'int' to worry about when looking at integer-overflow issues.
10516 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
10518 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
10519 This didn't break anything, but it didn't help either.
10520 It's confusing to put a bogus integer in a place where the actual
10521 value does not matter.
10522 (LIST_END_P): Remove unused macro and its bogus comment.
10523 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
10525 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
10526 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
10528 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
10529 We prefer signed types, and the value cannot exceed the EMACS_INT
10530 range anyway (because otherwise the length would not be representable).
10531 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
10532 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
10533 This avoids a GCC warning when WIDE_EMACS_INT.
10535 * indent.c (sane_tab_width): New function.
10536 (current_column, scan_for_column, Findent_to, position_indentation)
10537 (compute_motion): Use it. This is just for clarity.
10538 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
10540 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
10542 * lisp.h (lint_assume): New macro.
10543 * composite.c (composition_gstring_put_cache):
10544 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
10546 * editfns.c, insdel.c:
10547 Omit unnecessary forward decls, to simplify future changes.
10549 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
10551 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
10553 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
10554 Use much-faster test for byte-length change.
10555 Don't assume string byte-length fits in 'int'.
10556 Check that character arg fits in 'int'.
10557 (mapcar1): Declare byte as byte, for clarity.
10559 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10561 * fns.c (concat): Catch string overflow earlier.
10562 Do not rely on integer wraparound.
10564 * dispextern.h (struct it.overlay_strings_charpos)
10565 (struct it.selective): Now EMACS_INT, not int.
10566 * xdisp.c (forward_to_next_line_start)
10567 (back_to_previous_visible_line_start)
10568 (reseat_at_next_visible_line_start, next_element_from_buffer):
10569 Don't arbitrarily truncate the value of 'selective' to int.
10571 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
10573 * composite.c: Don't truncate sizes to 'int'.
10574 (composition_gstring_p, composition_reseat_it)
10575 (composition_adjust_point): Use EMACS_INT, not int.
10576 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10577 not EMACS_UINT, for indexes.
10579 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10581 * buffer.c: Include <verify.h>.
10582 (struct sortvec.priority, struct sortstr.priority):
10583 Now EMACS_INT, not int.
10584 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
10585 (struct sortstr.size, record_overlay_string)
10586 (struct sortstrlist.size, struct sortlist.used):
10587 Don't truncate size to int.
10588 (record_overlay_string): Check for size-calculation overflow.
10589 (init_buffer_once): Check at compile-time, not run-time.
10591 2011-06-22 Jim Meyering <meyering@redhat.com>
10593 Don't leak an XBM-image-sized buffer
10594 * image.c (xbm_load): Free the image buffer after using it.
10596 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10599 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10600 that Sun C diagnosed.
10601 * fns.c (secure_hash): Fix pointer signedness issue.
10602 * intervals.c (static_offset_intervals): New function.
10603 (offset_intervals): Use it.
10605 2011-06-21 Leo Liu <sdl.web@gmail.com>
10608 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10611 * fns.c (secure_hash): Rename from crypto_hash_function and change
10612 the first arg to accept symbols.
10613 (Fsecure_hash): New primitive.
10614 (syms_of_fns): New symbols.
10616 2011-06-20 Deniz Dogan <deniz@dogan.se>
10618 * process.c (Fset_process_buffer): Clarify return value in
10621 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
10623 * dispnew.c (add_window_display_history): Use BVAR.
10625 * xdisp.c (debug_method_add): Use BVAR.
10626 (check_window_end, dump_glyph_matrix, dump_glyph)
10627 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10629 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10632 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10633 check till after the cache is created in init_frame_faces.
10635 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10637 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10639 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10641 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10642 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10643 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10645 Improve buffer-overflow checking (Bug#8873).
10646 * fileio.c (Finsert_file_contents):
10647 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10648 Remove the old (too-loose) buffer overflow checks.
10649 They weren't needed, since make_gap checks for buffer overflow.
10650 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10651 The old code merely checked for Emacs fixnum overflow, and relied
10652 on undefined (wraparound) behavior. The new code avoids undefined
10653 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10655 * editfns.c (Finsert_char): Don't dump core with very negative counts.
10656 Tune. Don't use wider integers than needed. Don't use alloca.
10657 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
10659 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10661 * insdel.c, lisp.h (buffer_overflow): New function.
10662 (insert_from_buffer_1, replace_range, replace_range_2):
10663 * insdel.c (make_gap_larger):
10664 * editfns.c (Finsert_char):
10665 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10667 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10669 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10671 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
10673 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10674 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10676 * fileio.c: Don't assume EMACS_INT fits in off_t.
10677 (emacs_lseek): New static function.
10678 (Finsert_file_contents, Fwrite_region): Use it.
10679 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10681 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10683 * fns.c: Don't overflow int when computing a list length.
10684 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10685 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10686 truncation on 64-bit hosts. Check for QUIT every
10687 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10688 faster and is responsive enough.
10689 (Flength): Report an error instead of overflowing an integer.
10690 (Fsafe_length): Return a float if the value is not representable
10691 as a fixnum. This shouldn't happen except in contrived situations.
10692 (Fnthcdr, Fsort): Don't assume list length fits in int.
10693 (Fcopy_sequence): Don't assume vector length fits in int.
10695 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10696 (header_size, word_size): New constants.
10697 (allocate_vectorlike): Don't check size overflow here.
10698 (allocate_vector): Check it here instead, since this is the only
10699 caller of allocate_vectorlike that could cause overflow.
10700 Check that the new vector's length is representable as a fixnum.
10702 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10703 The previous code was bogus. For example, next_almost_prime (32)
10704 returned 39, which is undesirable as it is a multiple of 3; and
10705 next_almost_prime (24) returned 25, which is a multiple of 5 so
10706 why was the code bothering to check for multiples of 7?
10708 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10710 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10712 Variadic C functions now count arguments with ptrdiff_t.
10713 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10714 Back then I didn't know that the Emacs coding style prefers signed int.
10715 Also, in the meantime I found a few more instances where arguments
10716 were being counted with int, which may truncate counts on 64-bit
10717 machines, or EMACS_INT, which may be unnecessarily wide.
10718 * lisp.h (struct Lisp_Subr.function.aMANY)
10719 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10720 Arg counts are now ptrdiff_t, not size_t.
10721 All variadic functions and their callers changed accordingly.
10722 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10723 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10724 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10725 * callint.c (Fcall_interactively): Check arg count for overflow,
10726 to avoid potential buffer overrun. Use signed char, not 'int',
10727 for 'varies' array, so that we needn't bother to check its size
10728 calculation for overflow.
10729 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10730 * eval.c (apply_lambda):
10731 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10732 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10733 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10735 * callint.c (Fcall_interactively): Don't use index var as event count.
10737 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10738 * mem-limits.h (SIZE): Remove; no longer used.
10740 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
10742 Remove unnecessary casts.
10743 * xterm.c (x_term_init):
10744 * xfns.c (x_set_border_pixel):
10745 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10746 These aren't needed now that we assume ANSI C.
10748 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10749 It's more likely to cause problems (due to unsigned overflow)
10752 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10754 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10756 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10758 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10760 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10762 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10764 GLYPH_CODE_FACE returns EMACS_INT, not int.
10765 * dispextern.h (merge_faces):
10766 * xfaces.c (merge_faces):
10767 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10768 Don't assume EMACS_INT fits in int.
10770 * character.h (CHAR_VALID_P): Remove unused parameter.
10771 * fontset.c, lisp.h, xdisp.c: All uses changed.
10773 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10775 * fns.c (concat): Minor tuning based on overflow analysis.
10776 This doesn't fix any bugs. Use int to hold character, instead
10777 of constantly refetching from Emacs object. Use XFASTINT, not
10778 XINT, for value known to be a character. Don't bother comparing
10779 a single byte to 0400, as it's always less.
10781 * floatfns.c (Fexpt):
10782 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10784 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10787 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10789 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10790 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10791 incorrectly succeed when S was a string, because 4294967386 was
10792 truncated before it was used.
10794 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10795 Otherwise, an out-of-range integer could cause undefined behavior
10798 * composite.c: Use int, not EMACS_INT, for characters.
10799 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10800 EMACS_INT, for values that are known to be in character range.
10801 This doesn't fix any bugs but is the usual style inside Emacs and
10802 may generate better code on 32-bit machines.
10804 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10805 This is for reasons similar to the recent CHAR_STRING fix.
10806 * charset.c (Fencode_char): Check that character arg is actually
10807 a character. Pass an int to ENCODE_CHAR.
10808 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10809 wider than 'int', as a compile-time check to prevent future regressions
10812 * character.c (char_string): Remove unnecessary casts.
10814 Make sure a 64-bit char is never passed to CHAR_STRING.
10815 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10816 by silently ignoring the top 32 bits, allowing some values
10817 that were far too large to be valid characters.
10818 * character.h: Include <verify.h>.
10819 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10820 arguments are no wider than unsigned, as a compile-time check
10821 to prevent future regressions in this area.
10823 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
10824 (Fsubst_char_in_region):
10826 * xdisp.c (decode_mode_spec_coding):
10827 Adjust to CHAR_STRING's new requirement.
10828 * editfns.c (Finsert_char, Fsubst_char_in_region):
10829 * fns.c (concat): Check that character args are actually
10830 characters. Without this test, these functions did the wrong
10831 thing with wildly out-of-range values on 64-bit hosts.
10833 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10834 These casts should not be needed on 32-bit hosts, either.
10835 * keyboard.c (read_char):
10836 * lread.c (Fload): Remove casts to unsigned.
10838 * lisp.h (UNSIGNED_CMP): New macro.
10839 This fixes comparison bugs on 64-bit hosts.
10840 (ASCII_CHAR_P): Use it.
10841 * casefiddle.c (casify_object):
10842 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
10843 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10844 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10845 * dispextern.h (FACE_FROM_ID):
10846 * keyboard.c (read_char): Use UNSIGNED_CMP.
10848 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10849 not to EMACS_INT, to avoid GCC warning.
10851 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10853 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10854 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10855 isn't needed on 32-bit machines.
10857 * buffer.c (Fgenerate_new_buffer_name):
10858 Use EMACS_INT for count, not int.
10859 (advance_to_char_boundary): Return EMACS_INT, not int.
10861 * data.c (Qcompiled_function): Now static.
10863 * window.c (window_body_lines): Now static.
10865 * image.c (gif_load): Rename local to avoid shadowing.
10867 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10868 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10869 * alloc.c (make_save_value): Integer argument is now of type
10870 ptrdiff_t, not int.
10871 (mark_object): Use ptrdiff_t, not int.
10872 * lisp.h (pD): New macro.
10873 * print.c (print_object): Use it.
10875 * alloc.c: Use EMACS_INT, not int, to count objects.
10876 (total_conses, total_markers, total_symbols, total_vector_size)
10877 (total_free_conses, total_free_markers, total_free_symbols)
10878 (total_free_floats, total_floats, total_free_intervals)
10879 (total_intervals, total_strings, total_free_strings):
10880 Now EMACS_INT, not int. All uses changed.
10881 (Fgarbage_collect): Compute overall total using a double, so that
10882 integer overflow is less likely to be a problem. Check for overflow
10883 when converting back to an integer.
10884 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10885 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10886 These were 'int' variables that could overflow on 64-bit hosts;
10887 they were never used, so remove them instead of repairing them.
10888 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
10889 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10890 Previously, this ceilinged at INT_MAX, but that doesn't work on
10892 (allocate_pseudovector): Don't use EMACS_INT when int would do.
10894 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
10895 (allocate_vectorlike): Check for ptrdiff_t overflow.
10896 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10897 when a (possibly-narrower) signed value would do just as well.
10898 We prefer using signed arithmetic, to avoid comparison confusion.
10900 * alloc.c: Catch some string size overflows that we were missing.
10901 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10902 for convenience in STRING_BYTES_MAX.
10903 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10904 The definition here is exact; the one in lisp.h was approximate.
10905 (allocate_string_data): Check for string overflow. This catches
10906 some instances we weren't catching before. Also, it catches
10907 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10908 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10909 and ptrdiff_t and EMACS_INT are both 64 bits.
10911 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10912 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
10913 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
10915 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10917 * alloc.c (Fmake_string): Check for out-of-range init.
10919 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10921 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10923 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10925 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10926 xg_get_default_scrollbar_width.
10928 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10929 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10930 (style_changed_cb): Call update_theme_scrollbar_width and call
10931 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10932 all frames (Bug#8505).
10933 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10934 Call gtk_window_set_resizable if HAVE_GTK3.
10935 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10936 and height if HAVE_GTK3 (Bug#8505).
10937 (scroll_bar_width_for_theme): New variable.
10938 (update_theme_scrollbar_width): New function.
10939 (xg_get_default_scrollbar_width): Move code to
10940 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10941 (xg_initialize): Call update_theme_scrollbar_width.
10943 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10945 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10947 2011-06-12 Martin Rudalics <rudalics@gmx.at>
10949 * frame.c (make_frame): Call other_buffer_safely instead of
10952 * window.c (temp_output_buffer_show): Call display_buffer with
10953 second argument Vtemp_buffer_show_specifiers and reset latter
10954 immediately after the call.
10955 (Vtemp_buffer_show_specifiers): New variable.
10956 (auto_window_vscroll_p, next_screen_context_lines)
10957 (Vscroll_preserve_screen_position): Remove leading asterisks from
10960 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
10962 Fix minor problems found by GCC 4.6.0 static checking.
10963 * buffer.c (Qclone_number): Remove for now, as it's unused.
10964 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10965 (record_buffer): Remove unused local.
10966 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10967 (set_frame_buffer_list): Remove; unused.
10968 * frame.h (other_visible_frames): Remove decl.
10969 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10970 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10971 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10973 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10974 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10975 Define only if HAVE_GPM.
10976 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10977 (update_hints_inhibit): Remove; never set. All uses removed.
10978 * widgetprv.h (emacsFrameClassRec): Remove decl.
10979 * window.c (delete_deletable_window): Now returns void, since it
10980 wasn't returning anything.
10981 (compare_window_configurations): Remove unused locals.
10982 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10983 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
10984 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10985 the same widths as pointers. This follows up on the 2011-05-06 patch.
10986 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10987 * xterm.h: Likewise.
10988 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10990 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
10992 * makefile.w32-in: Update dependencies.
10993 (LISP_H): Add lib/intprops.h.
10995 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
10997 * image.c (gif_load): Add animation frame delay to the metadata.
10998 (syms_of_image): Use DEFSYM. New symbol `delay'.
11000 2011-06-11 Martin Rudalics <rudalics@gmx.at>
11002 * window.c (delete_deletable_window): Re-add.
11003 (Fset_window_configuration): Rewrite to handle dead buffers and
11004 consequently deletable windows.
11005 (window_tree, Fwindow_tree): Remove. Supply functionality in
11007 (compare_window_configurations): Simplify code.
11009 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
11011 * image.c (imagemagick_load_image): Fix type mismatch.
11012 (Fimagemagick_types): Likewise.
11014 * window.h (replace_buffer_in_windows): Declare.
11016 2011-06-11 Martin Rudalics <rudalics@gmx.at>
11018 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
11019 Qclone_number. Remove external declaration of Qdelete_window.
11020 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
11022 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
11023 Run Qbuffer_list_update_hook if allowed.
11024 (Fother_buffer): Rewrite doc-string. Major rewrite for new
11025 buffer list implementation.
11026 (other_buffer_safely): New function.
11027 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
11028 calls to replace_buffer_in_windows and
11029 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
11031 (record_buffer): Inhibit quitting and rewrite using quittable
11032 functions. Run Qbuffer_list_update_hook if allowed.
11033 (Frecord_buffer, Funrecord_buffer): New functions.
11034 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
11035 Move switch-to-buffer to window.el.
11036 (bury-buffer): Move to window.el.
11037 (Vbuffer_list_update_hook): New variable.
11039 * lisp.h (other_buffer_safely): Add prototype in buffer.c
11042 * window.h (resize_frame_windows): Move up in code.
11043 (Fwindow_frame): Remove EXFUN.
11044 (replace_buffer_in_all_windows): Remove prototype.
11045 (replace_buffer_in_windows_safely): Add prototype.
11047 * window.c: Declare Qdelete_window static again. Move down
11048 declaration of select_count.
11049 (Fnext_window, Fprevious_window): Rewrite doc-strings.
11050 (Fother_window): Move to window.el.
11051 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
11052 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
11053 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
11055 (replace_buffer_in_windows): Implement by calling
11056 Qreplace_buffer_in_windows.
11057 (replace_buffer_in_all_windows): Remove with some functionality
11058 moved into replace_buffer_in_windows_safely.
11059 (replace_buffer_in_windows_safely): New function.
11060 (select_window_norecord, select_frame_norecord): Move in front
11061 of run_window_configuration_change_hook. Remove now obsolete
11063 (Fset_window_buffer): Rewrite doc-string.
11064 Call Qrecord_window_buffer.
11065 (keys_of_window): Move binding for other-window to window.el.
11067 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
11069 * dispextern.h (struct image): Replace data member, whose int_val
11070 and ptr_val fields were not used by anything, with a single
11073 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
11074 (gif_clear_image, gif_load, imagemagick_load_image)
11075 (gs_clear_image, gs_load): Callers changed.
11077 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
11079 * buffer.h: Include <time.h>, for time_t.
11080 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
11082 Fix minor problems found by static checking.
11084 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
11086 Make identifiers static if they are not used in other modules.
11087 * data.c (Qcompiled_function, Qframe, Qvector):
11088 * image.c (QimageMagick, Qsvg):
11089 * minibuf.c (Qmetadata):
11090 * window.c (resize_window_check, resize_root_window): Now static.
11091 * window.h (resize_window_check, resize_root_window): Remove decls.
11093 * window.c (window_deletion_count, delete_deletable_window):
11095 (window_body_lines): Now static.
11096 (Fdelete_other_windows_internal): Mark vars as initialized.
11097 Make sure 'resize_failed' is initialized.
11098 (run_window_configuration_change_hook): Rename local to avoid shadowing.
11099 (resize_window_apply): Remove unused local.
11100 * window.h (delete_deletable_window): Remove decl.
11102 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
11103 (imagemagick_load_image): Fix pointer signedness problem by changing
11104 last arg from unsigned char * to char *. All uses changed.
11105 Also, fix a local for similar reasons.
11106 Remove unused locals. Remove locals to avoid shadowing.
11107 (fn_rsvg_handle_free): Remove; unused.
11108 (svg_load, svg_load_image): Fix pointer signedness problem.
11109 (imagemagick_load_image): Don't use garbage pointer image_wand.
11111 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
11113 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
11115 * image.c (gif_load): Fix omitted cast error introduced by
11118 2011-06-10 Martin Rudalics <rudalics@gmx.at>
11120 * window.h (resize_proportionally, orig_total_lines)
11121 (orig_top_line): Remove from window structure.
11122 (set_window_height, set_window_width, change_window_heights)
11123 (Fdelete_window): Remove prototypes.
11124 (resize_frame_windows): Remove duplicate declaration.
11126 2011-06-10 Eli Zaretskii <eliz@gnu.org>
11128 * window.h (resize_frame_windows, resize_window_check)
11129 (delete_deletable_window, resize_root_window)
11130 (resize_frame_windows): Declare prototypes.
11132 * window.c (resize_window_apply): Make definition be "static" to
11133 match the prototype.
11135 2011-06-10 Martin Rudalics <rudalics@gmx.at>
11137 * window.c: Remove declarations of Qwindow_size_fixed,
11138 window_min_size_1, window_min_size_2, window_min_size,
11139 size_window, window_fixed_size_p, enlarge_window, delete_window.
11140 Remove static from declaration of Qdelete_window, it's
11141 temporarily needed by Fbury_buffer.
11142 (replace_window): Don't assign orig_top_line and
11144 (Fdelete_window, delete_window): Remove. Window deletion is
11145 handled by window.el.
11146 (window_loop): Remove DELETE_OTHER_WINDOWS case.
11147 Replace Fdelete_window calls with calls to Qdelete_window.
11148 (Fdelete_other_windows): Remove. Deleting other windows is
11149 handled by window.el.
11150 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
11151 handled in window.el.
11152 (window_min_size_2, window_min_size_1, window_min_size): Remove.
11153 Window minimum sizes are handled in window.el.
11154 (shrink_windows, size_window, set_window_height)
11155 (set_window_width, change_window_heights, window_height)
11156 (window_width, CURBEG, CURSIZE, enlarge_window)
11157 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
11158 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
11159 handled in window.el.
11160 (make_dummy_parent): Rename to make_parent_window and give it a
11161 second argument horflag.
11162 (make_window): Don't set resize_proportionally any more.
11163 (Fsplit_window): Remove. Windows are split in window.el.
11164 (save_restore_action, save_restore_orig_size)
11165 (shrink_window_lowest_first, save_restore_orig_size): Remove.
11166 Resize mini windows in window.el.
11167 (grow_mini_window, shrink_mini_window): Implement by calling
11168 Qresize_root_window_vertically, resize_window_check and
11169 resize_window_apply.
11170 (saved_window, Fset_window_configuration, save_window_save):
11171 Do not handle orig_top_line, orig_total_lines, and
11172 resize_proportionally.
11173 (window_min_height, window_min_width): Move to window.el.
11174 (keys_of_window): Move bindings for delete-other-windows,
11175 split-window, delete-window and enlarge-window to window.el.
11177 * buffer.c: Temporarily extern Qdelete_window.
11178 (Fbury_buffer): Temporarily call Qdelete_window instead of
11179 Fdelete_window (Fbury_buffer will move to window.el soon).
11181 * frame.c (set_menu_bar_lines_1): Remove code handling
11182 orig_top_line and orig_total_lines.
11184 * dispnew.c (adjust_frame_glyphs_initially): Don't use
11185 set_window_height but set heights directly.
11186 (change_frame_size_1): Use resize_frame_windows.
11188 * xdisp.c (init_xdisp): Don't use set_window_height but set
11191 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
11192 Use resize_frame_windows instead of change_window_heights and run
11193 run_window_configuration_change_hook.
11195 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
11196 instead of change_window_heights and run
11197 run_window_configuration_change_hook.
11199 2011-06-09 Martin Rudalics <rudalics@gmx.at>
11201 * window.c (replace_window): Rename second argument REPLACEMENT to
11202 NEW. New third argument SETFLAG. Rewrite.
11203 (delete_window, make_dummy_parent): Call replace_window with
11205 (window_list_1): Move down in code.
11206 (run_window_configuration_change_hook): Move set_buffer part
11207 before select_frame_norecord part in order to unwind correctly.
11208 Rename count1 to count.
11209 (recombine_windows, delete_deletable_window, resize_root_window)
11210 (Fdelete_other_windows_internal)
11211 (Frun_window_configuration_change_hook, make_parent_window)
11212 (resize_window_check, resize_window_apply, Fresize_window_apply)
11213 (resize_frame_windows, Fsplit_window_internal)
11214 (Fdelete_window_internal, Fresize_mini_window_internal):
11216 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
11218 2011-06-08 Martin Rudalics <rudalics@gmx.at>
11220 * window.h (window): Add some new members to window structure -
11221 normal_lines, normal_cols, new_total, new_normal, clone_number,
11222 splits, nest, prev_buffers, next_buffers.
11223 (WINDOW_TOTAL_SIZE): Move here from window.c.
11224 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
11226 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
11228 (make_dummy_parent): Set new members of windows structure.
11229 (make_window): Move down in code. Handle new members of window
11231 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
11232 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
11233 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
11234 (Fset_window_prev_buffers, Fwindow_next_buffers)
11235 (Fset_window_next_buffers, Fset_window_clone_number):
11237 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
11238 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
11240 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
11241 Argument WINDOW can be now internal window too.
11242 (Fwindow_use_time): Move up in code.
11243 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
11244 Rewrite doc-string.
11245 (Fset_window_configuration, saved_window)
11246 (Fcurrent_window_configuration, save_window_save): Handle new
11247 members of window structure.
11248 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
11249 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
11250 (syms_of_window): New Lisp objects Qrecord_window_buffer,
11251 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
11252 Qget_mru_window, Qresize_root_window,
11253 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
11254 Qauto_buffer_name; staticpro them.
11256 2011-06-07 Martin Rudalics <rudalics@gmx.at>
11258 * window.c (Fwindow_total_size, Fwindow_left_column)
11259 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
11260 (Fwindow_list_1): New functions.
11261 (window_box_text_cols): Replace with window_body_cols.
11262 (Fwindow_width, Fscroll_left, Fscroll_right):
11263 Use window_body_cols instead of window_box_text_cols.
11264 (delete_window, Fset_window_configuration):
11265 Call delete_all_subwindows with window as argument.
11266 (delete_all_subwindows): Take a window as argument and not a
11267 structure. Rewrite.
11268 (window_loop): Remove handling of GET_LRU_WINDOW and
11269 GET_LARGEST_WINDOW.
11270 (Fget_lru_window, Fget_largest_window): Move to window.el.
11272 * window.h: Extern window_body_cols instead of
11273 window_box_text_cols. delete_all_subwindows now takes a
11274 Lisp_Object as argument.
11276 * indent.c (compute_motion, Fcompute_motion):
11277 Use window_body_cols instead of window_box_text_cols.
11279 * frame.c (delete_frame): Call delete_all_subwindows with root
11280 window as argument.
11282 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
11284 * fns.c (Fputhash): Document return value.
11286 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
11288 * image.c (gif_load): Implement gif89a spec "no disposal" method.
11290 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11292 Cons<->int and similar integer overflow fixes (Bug#8794).
11294 Check for overflow when converting integer to cons and back.
11295 * charset.c (Fdefine_charset_internal, Fdecode_char):
11296 Use cons_to_unsigned to catch overflow.
11297 (Fencode_char): Use INTEGER_TO_CONS.
11298 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
11299 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
11300 * data.c (long_to_cons, cons_to_long): Remove.
11301 (cons_to_unsigned, cons_to_signed): New functions.
11302 These signal an error for invalid or out-of-range values.
11303 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
11304 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
11305 * font.c (Ffont_variation_glyphs):
11306 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
11307 * lisp.h: Include <intprops.h>.
11308 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
11309 (cons_to_signed, cons_to_unsigned): New decls.
11310 (long_to_cons, cons_to_long): Remove decls.
11311 * undo.c (record_first_change): Use INTEGER_TO_CONS.
11312 (Fprimitive_undo): Use CONS_TO_INTEGER.
11313 * xfns.c (Fx_window_property): Likewise.
11314 * xselect.c: Include <limits.h>.
11315 (x_own_selection, selection_data_to_lisp_data):
11316 Use INTEGER_TO_CONS.
11317 (x_handle_selection_request, x_handle_selection_clear)
11318 (x_get_foreign_selection, Fx_disown_selection_internal)
11319 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
11320 (lisp_data_to_selection_data): Use cons_to_unsigned.
11321 (x_fill_property_data): Use cons_to_signed.
11322 Report values out of range.
11324 Check for buffer and string overflow more precisely.
11325 * buffer.h (BUF_BYTES_MAX): New macro.
11326 * lisp.h (STRING_BYTES_MAX): New macro.
11327 * alloc.c (Fmake_string):
11328 * character.c (string_escape_byte8):
11329 * coding.c (coding_alloc_by_realloc):
11330 * doprnt.c (doprnt):
11331 * editfns.c (Fformat):
11333 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
11334 since they may not be the same number.
11335 * editfns.c (Finsert_char):
11336 * fileio.c (Finsert_file_contents):
11337 Likewise for BUF_BYTES_MAX.
11339 * image.c: Use ptrdiff_t, not int, for sizes.
11340 (slurp_file): Switch from int to ptrdiff_t.
11342 (slurp_file): Check that file size fits in both size_t (for
11343 malloc) and ptrdiff_t (for sanity and safety).
11345 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
11346 if b->modtime has its maximal value.
11348 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
11350 Don't assume time_t can fit into int.
11351 * buffer.h (struct buffer.modtime): Now time_t, not int.
11352 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
11353 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
11355 Minor fixes for signed vs unsigned integers.
11356 * character.h (MAYBE_UNIFY_CHAR):
11357 * charset.c (maybe_unify_char):
11358 * keyboard.c (read_char, reorder_modifiers):
11359 XINT -> XFASTINT, since the integer must be nonnegative.
11360 * ftfont.c (ftfont_spec_pattern):
11361 * keymap.c (access_keymap, silly_event_symbol_error):
11362 XUINT -> XFASTINT, since the integer must be nonnegative.
11363 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
11364 since it makes no difference and we prefer signed.
11365 * keyboard.c (record_char): Use XUINT when all the neighbors do.
11366 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
11369 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
11371 * window.h (Fwindow_frame): Declare.
11373 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11375 * alloc.c: Simplify handling of large-request failures (Bug#8800).
11376 (SPARE_MEMORY): Always define.
11377 (LARGE_REQUEST): Remove.
11378 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
11380 2011-06-06 Martin Rudalics <rudalics@gmx.at>
11382 * lisp.h: Move EXFUNS for Fframe_root_window,
11383 Fframe_first_window and Fset_frame_selected_window to window.h.
11385 * window.h: Move EXFUNS for Fframe_root_window,
11386 Fframe_first_window and Fset_frame_selected_window here from
11389 * frame.c (Fwindow_frame, Fframe_first_window)
11390 (Fframe_root_window, Fframe_selected_window)
11391 (Fset_frame_selected_window): Move to window.c.
11392 (Factive_minibuffer_window): Move to minibuf.c.
11393 (Fother_visible_frames_p): New function.
11395 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
11397 * window.c (decode_window, decode_any_window): Move up in code.
11398 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
11399 (inhibit_frame_unsplittable): Remove unused variable.
11400 (Fwindow_buffer): Move up and rewrite doc-string.
11401 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
11402 (Fwindow_prev): New functions.
11403 (Fwindow_frame): Move here from frame.c. Accept any window as
11405 (Fframe_root_window, Fframe_first_window)
11406 (Fframe_selected_window): Move here from frame.c. Accept frame
11407 or arbitrary window as argument. Update doc-strings.
11408 (Fminibuffer_window): Move up in code.
11409 (Fwindow_minibuffer_p): Move up in code and simplify.
11410 (Fset_frame_selected_window): Move here from frame.c.
11412 (Fselected_window, select_window, Fselect_window): Move up in
11413 code. Minor doc-string fixes.
11415 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11417 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
11418 Do not assume that spare memory exists; that assumption is valid
11419 only if SYSTEM_MALLOC.
11420 (LARGE_REQUEST): New macro, so that the issue of large requests
11421 is separated from the issue of spare memory.
11423 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
11425 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
11428 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
11430 * xfns.c (x_set_scroll_bar_default_width): Move declarations
11433 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
11435 * gtkutil.c (xg_get_default_scrollbar_width): New function.
11437 * gtkutil.h: Declare xg_get_default_scrollbar_width.
11439 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
11440 min width by calling x_set_scroll_bar_default_width (Bug#8505).
11442 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
11444 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
11446 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
11448 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
11449 (x_clipboard_manager_save): Add return value.
11450 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
11451 New error handlers.
11452 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
11453 Obey Vx_select_enable_clipboard_manager. Catch errors in
11454 x_clipboard_manager_save (Bug#8779).
11455 (Vx_select_enable_clipboard_manager): New variable.
11456 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
11458 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
11460 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
11462 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11464 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
11465 in the current matrix if keep_current_p is non-zero.
11467 2011-06-04 Eli Zaretskii <eliz@gnu.org>
11469 * bidi.c (bidi_level_of_next_char): Fix last change.
11471 2011-06-03 Eli Zaretskii <eliz@gnu.org>
11473 Support bidi reordering of text covered by display properties.
11475 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
11476 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
11477 (bidi_cache_search, bidi_cache_iterator_state)
11478 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
11479 (bidi_level_of_next_char, bidi_move_to_visually_next):
11480 Support character positions inside a run of characters covered by a
11482 (bidi_paragraph_init, bidi_resolve_explicit_1)
11483 (bidi_level_of_next_char): Call bidi_fetch_char and
11484 bidi_fetch_char_advance instead of FETCH_CHAR and
11485 FETCH_CHAR_ADVANCE.
11486 (bidi_init_it): Initialize new members.
11487 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
11489 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
11490 instead of using explicit *_CHAR codes.
11491 (bidi_resolve_explicit, bidi_resolve_weak):
11492 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
11493 bidirectional text is supported only in multibyte buffers.
11494 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
11495 it to initialize the frame_window_p member of struct bidi_it.
11496 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
11497 (bidi_resolve_explicit, bidi_resolve_weak)
11498 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
11499 bidi_it->nchars is non-positive.
11500 (bidi_level_of_next_char): Don't try to lookup the cache for the
11501 next/previous character if nothing is cached there yet, or if we
11502 were just reseat()'ed to a new position.
11504 * xdisp.c (set_cursor_from_row): Set start and stop points
11505 according to the row's direction when priming the loop that looks
11506 for the glyph on which to display cursor.
11507 (single_display_spec_intangible_p): Function deleted.
11508 (display_prop_intangible_p): Reimplement to call
11509 handle_display_spec instead of single_display_spec_intangible_p.
11510 Accept 3 additional arguments needed by handle_display_spec.
11511 This fixes incorrect cursor motion across display property with complex
11512 values: lists, `(when COND...)' forms, etc.
11513 (single_display_spec_string_p): Support property values that are
11514 lists with the argument STRING its top-level element.
11515 (display_prop_string_p): Fix the condition for processing a
11516 property that is a list to be consistent with handle_display_spec.
11517 (handle_display_spec): New function, refactored from the
11518 last portion of handle_display_prop.
11519 (compute_display_string_pos): Accept additional argument
11520 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
11521 value of a `display' property is a "replacing spec".
11522 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
11523 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
11524 the display property, but just return a value indicating whether
11525 the display property will replace the characters it covers.
11526 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
11527 frame_window_p members of struct bidi_it.
11528 (compute_display_string_pos, compute_display_string_end):
11530 (push_it): Accept second argument POSITION, where pop_it should
11531 jump to continue iteration.
11532 (reseat_1): Initialize bidi_it.disp_pos.
11534 * keyboard.c (adjust_point_for_property): Adjust the call to
11535 display_prop_intangible_p to its new signature.
11537 * dispextern.h (struct bidi_it): New member frame_window_p.
11538 (bidi_init_it): Update prototypes.
11539 (display_prop_intangible_p): Update prototype.
11540 (compute_display_string_pos, compute_display_string_end):
11541 Declare prototypes.
11542 (struct bidi_it): New members nchars and disp_pos. ch_len is now
11545 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
11547 Malloc failure behavior now depends on size of allocation.
11548 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
11549 * lisp.h: Change signatures accordingly.
11550 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
11551 All callers changed. (Bug#8762)
11553 * gnutls.c: Use Emacs's memory allocators.
11554 Without this change, the gnutls library would invoke malloc etc.
11555 directly, which causes problems on non-SYNC_INPUT hosts, and which
11556 runs afoul of improving memory_full behavior. (Bug#8761)
11557 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
11558 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
11559 xfree instead of the default malloc, realloc, free.
11560 (Fgnutls_boot): No need to check for memory allocation failure,
11561 since xmalloc does that for us.
11563 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
11564 * category.c (hash_get_category_set):
11565 * ccl.c (ccl_driver):
11566 * charset.c (Fdefine_charset_internal):
11567 * charset.h (struct charset.hash_index):
11568 * composite.c (get_composition_id, gstring_lookup_cache)
11569 (composition_gstring_put_cache):
11570 * composite.h (struct composition.hash_index):
11571 * dispextern.h (struct image.hash):
11572 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11573 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11574 (hashfn_equal, hashfn_user_defined, make_hash_table)
11575 (maybe_resize_hash_table, hash_lookup, hash_put)
11576 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11577 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11578 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11579 * image.c (make_image, search_image_cache, lookup_image)
11580 (xpm_put_color_table_h):
11581 * lisp.h (struct Lisp_Hash_Table):
11582 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
11583 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
11584 for hashes and hash indexes, instead of 'unsigned' and 'int'.
11585 * alloc.c (allocate_vectorlike):
11586 Check for overflow in vector size calculations.
11587 * ccl.c (ccl_driver):
11588 Check for overflow when converting EMACS_INT to int.
11589 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11590 need to be updated by these changes.
11591 * fns.c (make_hash_table, maybe_resize_hash_table):
11592 Check for integer overflow with large hash tables.
11593 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11594 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11595 (SXHASH_REDUCE): New macro.
11596 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11597 Use it instead of discarding useful hash info with large hash values.
11598 (sxhash_float): New function.
11599 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11600 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
11601 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11602 Rewrite to use FIXNUM_BITS, as this simplifies things.
11603 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11604 Adjust signatures to match updated version of code.
11605 (consing_since_gc): Now EMACS_INT, since a single hash table can
11606 use more than INT_MAX bytes.
11608 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11610 Make it possible to build with GCC-4.6+ -O2 -flto.
11612 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11614 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11616 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11617 Call minibuffer-inactive-mode.
11619 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
11621 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11622 Update dependencies.
11624 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11626 * data.c (init_data): Remove code for UTS, this system is not
11629 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11631 Don't force ./temacs to start in terminal mode.
11633 * frame.c (make_initial_frame): Initialize faces in all cases, not
11634 only when CANNOT_DUMP is defined.
11635 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11637 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11639 * dispnew.c (add_window_display_history): Use const for the string
11640 pointer. Remove declaration, not needed.
11642 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11644 Use 'inline', not 'INLINE'.
11645 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
11646 * alloc.c, fontset.c (INLINE): Remove.
11647 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11648 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11649 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11650 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11651 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11653 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11655 Make it possible to run ./temacs.
11657 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11658 syms_of_callproc does the same thing. Remove test for
11659 "initialized", do it in the caller.
11660 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11662 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11664 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11665 (read_minibuf): Use get_minibuffer.
11666 (syms_of_minibuf): Use DEFSYM.
11667 (Qmetadata): New var.
11668 * data.c (Qbuffer): Don't make it static.
11669 (syms_of_data): Use DEFSYM.
11671 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11673 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11674 (CCL_CODE_MIN): New macro.
11676 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11678 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11680 * eval.c (Qdebug): Now static.
11681 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11682 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11683 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11685 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
11687 * image.c: Various fixes to ImageMagick code comments.
11688 (Fimagemagick_types): Doc fix.
11690 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11692 Minor fixes prompted by GCC 4.6.0 warnings.
11694 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11696 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11697 (x_clipboard_manager_save_all): Move extern decl to ...
11698 * xterm.h: ... here, so that it can be checked for consistency.
11700 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
11702 * xselect.c (x_clipboard_manager_save_frame)
11703 (x_clipboard_manager_save_all): New functions.
11704 (Fx_clipboard_manager_save): Lisp function deleted.
11706 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11707 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11709 * xterm.h: Update prototype.
11711 2011-05-28 William Xu <william.xwl@gmail.com>
11713 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11714 exiting (Bug#8239).
11716 2011-05-28 Jim Meyering <meyering@redhat.com>
11718 Avoid a sign-extension bug in crypto_hash_function.
11719 * fns.c (to_uchar): Define.
11720 (crypto_hash_function): Use it to convert some newly-signed
11721 variables to unsigned, to avoid sign-extension bugs. For example,
11722 without this change, (md5 "truc") would evaluate to
11723 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11724 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
11725 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
11727 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11729 Integer overflow fixes.
11731 * dbusbind.c: Serial number integer overflow fixes.
11732 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
11733 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11734 to hold a serial number that is too large for a fixnum.
11735 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11736 Check for serial numbers out of range. Decode any serial number
11737 that was so large that it became a float. (Bug#8722)
11739 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11740 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11741 Use XFASTINT rather than XUINT when numbers are nonnegative.
11742 (xd_append_arg, Fdbus_method_return_internal):
11743 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11744 arguments, check that Lisp number is nonnegative, rather than
11745 silently wrapping negative numbers around. (Bug#8722)
11746 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
11749 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11751 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11753 ccl: Add integer overflow checks.
11754 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11755 (IN_INT_RANGE): New macros.
11756 (ccl_driver): Use them to check for integer overflow when
11757 decoding a CCL program. Many of the new checks are whether XINT (x)
11758 fits in int; it doesn't always, on 64-bit hosts. The new version
11759 doesn't catch all possible integer overflows, but it's an
11760 improvement. (Bug#8719)
11762 * alloc.c (make_event_array): Use XINT, not XUINT.
11763 There's no need for unsigned here.
11765 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11766 This follows up to the 2011-05-06 change that substituted uintptr_t
11767 for EMACS_INT. This case wasn't caught back then.
11769 Rework Fformat to avoid integer overflow issues.
11770 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11771 now (part of C89). Include <verify.h>.
11772 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11773 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11774 (Fformat): Avoid the prepass trying to compute sizes; it was only
11775 approximate and thus did not catch overflow reliably. Instead, walk
11776 through the format just once, formatting and computing sizes as we go,
11777 checking for integer overflow at every step, and allocating a larger
11778 buffer as needed. Keep track separately whether the format is
11779 multibyte. Keep only the most-recently calculated precision, rather
11780 than them all. Record whether each argument has been converted to
11781 string. Use EMACS_INT, not int, for byte and char and arg counts.
11782 Support field widths and precisions larger than INT_MAX. Avoid
11783 sprintf's undefined behavior with conversion specifications such as %#d
11784 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11785 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11786 formatting out-of-range floating point numbers with int
11787 formats. (Bug#8668)
11789 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11791 * data.c: Avoid integer truncation in expressions involving floats.
11792 * data.c: Include <intprops.h>.
11793 (arith_driver): When there's an integer overflow in an expression
11794 involving floating point, convert the integers to floating point
11795 so that the resulting value does not suffer from catastrophic
11796 integer truncation. For example, on a 64-bit host (* 4
11797 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11798 Do not rely on undefined behavior after integer overflow.
11800 merge count_size_as_multibyte, parse_str_to_multibyte
11801 * character.c, character.h (count_size_as_multibyte):
11802 Rename from parse_str_to_multibyte; all uses changed.
11803 Check for integer overflow.
11804 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11805 since it's now a duplicate of the other. This is more of
11806 a character than a buffer op, so better that it's in character.c.
11807 * fns.c, print.c: Adjust to above changes.
11809 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11811 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11813 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11815 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11816 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11817 (x_clipboard_manager_save): Now static.
11818 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11820 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11821 (crypto_hash_function): Now static.
11822 Fix pointer signedness problems. Avoid unnecessary initializations.
11824 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
11826 * termhooks.h (Vselection_alist): Make it terminal-local.
11828 * terminal.c (create_terminal): Initialize it.
11830 * xselect.c: Support for clipboard managers.
11831 (Vselection_alist): Move to termhooks.h as terminal-local var.
11832 (LOCAL_SELECTION): New macro.
11833 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11834 (symbol_to_x_atom): Remove gratuitous arg.
11835 (x_handle_selection_request, lisp_data_to_selection_data)
11836 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
11837 (x_own_selection, x_get_local_selection, x_convert_selection):
11838 New arg, specifying work frame. Use terminal-local Vselection_alist.
11839 (some_frame_on_display): Delete unused function.
11840 (Fx_own_selection_internal, Fx_get_selection_internal)
11841 (Fx_disown_selection_internal, Fx_selection_owner_p)
11842 (Fx_selection_exists_p): New optional frame arg.
11843 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11844 (x_handle_selection_clear): Don't treat other terminals with the
11845 same keyboard specially. Use the terminal-local Vselection_alist.
11846 (x_clear_frame_selections): Use Frun_hook_with_args.
11848 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11850 * xterm.h: Add support for those atoms.
11852 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
11854 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11855 (converted_selections, conversion_fail_tag): New global variables.
11856 (x_selection_request_lisp_error): Free the above.
11857 (x_get_local_selection): Remove unnecessary code.
11858 (x_reply_selection_request): Args changed; handle arbitrary array
11859 of converted selections stored in converted_selections.
11860 Separate the XChangeProperty and SelectionNotify steps.
11861 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11862 (x_convert_selection): New function.
11863 (x_handle_selection_event): Simplify.
11864 (x_get_foreign_selection): Don't ignore incoming requests while
11865 waiting for an answer; this will fail when we implement
11866 SAVE_TARGETS, and seems unnecessary anyway.
11867 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11868 (Vx_sent_selection_functions): Doc fix.
11870 2011-05-26 Leo Liu <sdl.web@gmail.com>
11872 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11874 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11876 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11878 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11879 for fringe update if it has periodic bitmap.
11880 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
11881 and fringe_bitmap_periodic_p.
11883 * fringe.c (get_fringe_bitmap_data): New function.
11884 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11885 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11886 row. Mark glyph row for fringe update if periodicity changed.
11888 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11889 for fringe update unless it has periodic bitmap.
11891 2011-05-25 Kenichi Handa <handa@m17n.org>
11893 * xdisp.c (get_next_display_element): Set correct it->face_id for
11894 a static composition.
11896 2011-05-24 Leo Liu <sdl.web@gmail.com>
11899 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11901 * fns.c (crypto_hash_function, Fsha1): New function.
11902 (Fmd5): Use crypto_hash_function.
11903 (syms_of_fns): Add Ssha1.
11905 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11907 * gnutls.c: Remove unused macros.
11908 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11909 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11910 Remove macros that are defined and never used.
11911 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11913 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
11915 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11916 (Fx_get_selection_internal): Minor cleanup.
11917 (Fx_own_selection_internal): Rename arguments for consistency with
11920 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11922 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11924 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
11926 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11928 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11930 * dispnew.c (scrolling_window): Don't exclude the case that the
11931 last enabled row in the desired matrix touches the bottom boundary.
11933 2011-05-21 Glenn Morris <rgm@gnu.org>
11935 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
11936 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11937 and add some more files.
11939 2011-05-20 Eli Zaretskii <eliz@gnu.org>
11941 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11942 report_file_error introduced by the change from 2011-05-07.
11944 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11946 * systime.h (Time): Define only if emacs is defined.
11947 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11948 where the include path doesn't have X11/X.h by default. See
11949 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11951 2011-05-20 Kenichi Handa <handa@m17n.org>
11953 * composite.c (find_automatic_composition): Fix previous change.
11955 2011-05-20 Glenn Morris <rgm@gnu.org>
11957 * lisp.mk: New file, split from Makefile.in.
11958 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11959 (shortlisp): Remove.
11960 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11962 2011-05-19 Glenn Morris <rgm@gnu.org>
11964 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11965 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11966 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11967 (lisp): Set the order to that of loadup.el.
11968 (shortlisp): Make it a copy of $lisp.
11969 (SOME_MACHINE_LISP): Remove.
11970 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11971 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11973 2011-05-18 Kenichi Handa <handa@m17n.org>
11975 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11976 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11977 (find_automatic_composition): Mostly rewrite for efficiency.
11979 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
11981 * makefile.w32-in: Update dependencies.
11983 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11985 * menu.c: Include limits.h (fixes the MS-Windows build broken by
11986 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
11988 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
11990 Fix some integer overflow issues, such as string length overflow.
11992 * insdel.c (count_size_as_multibyte): Check for string overflow.
11994 * character.c (lisp_string_width): Check for string overflow.
11995 Use EMACS_INT, not int, for string indexes and lengths; in
11996 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11997 the resulting string length overflows an EMACS_INT; instead,
11998 report a string overflow if no precision given. When checking for
11999 precision exhaustion, use a check that cannot possibly have
12000 integer overflow. (Bug#8675)
12001 * character.h (lisp_string_width): Adjust to new signature.
12003 * alloc.c (string_overflow): New function.
12004 (Fmake_string): Use it. This doesn't change behavior, but saves
12005 a few bytes and will simplify future changes.
12006 * character.c (string_escape_byte8): Likewise.
12007 * lisp.h (string_overflow): New decl.
12009 Fixups, following up to the user-interface timestamp change.
12010 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
12011 for UI timestamps, instead of unsigned long.
12012 * msdos.c (mouse_get_pos): Likewise.
12013 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
12014 * w32gui.h (Time): Define by including "systime.h" rather than by
12015 declaring it ourselves. (Bug#8664)
12017 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
12018 * image.c (clear_image_cache): Likewise.
12020 * term.c (term_mouse_position): Don't assume time_t wraparound.
12022 Be more systematic about user-interface timestamps.
12023 Before, the code sometimes used 'Time', sometimes 'unsigned long',
12024 and sometimes 'EMACS_UINT', to represent these timestamps.
12025 This change causes it to use 'Time' uniformly, as that's what X uses.
12026 This makes the code easier to follow, and makes it easier to catch
12027 integer overflow bugs such as Bug#8664.
12028 * frame.c (Fmouse_position, Fmouse_pixel_position):
12029 Use Time, not unsigned long, for user-interface timestamps.
12030 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
12031 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
12032 * keyboard.h (last_event_timestamp): Likewise.
12033 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
12034 * menu.h (xmenu_show): Likewise.
12035 * term.c (term_mouse_position): Likewise.
12036 * termhooks.h (struct input_event.timestamp): Likewise.
12037 (struct terminal.mouse_position_hook): Likewise.
12038 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
12039 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
12040 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
12041 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
12042 what it was before.
12043 * menu.h, termhooks.h: Include "systime.h", for Time.
12045 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
12046 Don't assume that the difference between two unsigned long values
12047 can fit into an integer. At this point, we know button_down_time
12048 <= event->timestamp, so the difference must be nonnegative, so
12049 there's no need to cast the result if double-click-time is
12050 nonnegative, as it should be; check that it's nonnegative, just in
12051 case. This bug is triggered when events are more than 2**31 ms
12052 apart (about 25 days). (Bug#8664)
12054 * xselect.c (last_event_timestamp): Remove duplicate decl.
12055 (x_own_selection): Remove needless cast to unsigned long.
12057 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
12058 that always fit in int. Use a sentinel instead of a counter, to
12059 avoid a temp and to allay GCC's concerns about possible int overflow.
12060 * frame.h (struct frame): Use int for menu_bar_items_used
12061 instead of EMACS_INT, since it always fits in int.
12063 * menu.c (grow_menu_items): Check for int overflow.
12065 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
12067 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
12068 Before, the code was not consistent. These values cannot exceed
12069 2**31 - 1 so there's no need to make them unsigned.
12070 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
12071 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
12072 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
12074 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
12076 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
12077 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
12078 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
12079 presumably because the widths might not match.
12081 * window.c (size_window): Avoid needless test at loop start.
12083 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
12085 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
12087 2011-05-12 Drew Adams <drew.adams@oracle.com>
12089 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
12091 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12093 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
12094 `width' to `bar_area_x' and `bar_area_width', respectively.
12095 (x_scroll_run): Take account of fringe background extension.
12097 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
12098 Rename local vars `left' and `width' to `bar_area_x' and
12099 `bar_area_width', respectively.
12100 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
12101 background extension.
12103 2011-05-10 Jim Meyering <meyering@redhat.com>
12105 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
12107 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
12109 * image.c (Finit_image_library): Return t for built-in image types,
12110 like pbm and xbm. (Bug#8640)
12112 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
12114 * w32menu.c (set_frame_menubar): Fix submenu allocation.
12116 2011-05-07 Eli Zaretskii <eliz@gnu.org>
12118 * w32console.c (Fset_screen_color): Doc fix.
12119 (Fget_screen_color): New function.
12120 (syms_of_ntterm): Defsubr it.
12122 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
12123 unlink the temporary file if Fcall_process didn't create it in the
12125 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
12126 child process will be redirected to a file specified with `:file'.
12127 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
12128 cue to call_process_cleanup not to close that handle.
12130 2011-05-07 Ben Key <bkey76@gmail.com>
12132 * makefile.w32-in: The bootstrap-temacs rule now makes use of
12133 one of two shell specific rules, either bootstrap-temacs-CMD or
12134 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
12135 to the previous implementation of the bootstrap-temacs rule.
12136 The bootstrap-temacs-CMD rule is similar to the previous
12137 implementation of the bootstrap-temacs rule except that it
12138 makes use of the ESC_CFLAGS variable instead of the CFLAGS
12141 These changes, along with some changes to nt/configure.bat,
12142 nt/gmake.defs, and nt/nmake.defs, are required to extend my
12143 earlier fix to add support for --cflags and --ldflags options
12144 that include quotes so that it works whether make uses cmd or
12147 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
12149 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
12150 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
12152 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
12153 a string. Handle both cases.
12154 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
12155 (Fdbus_register_method): Use Qinvalid_function.
12157 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
12159 * makefile.w32-in: Update dependencies.
12160 (LISP_H): Add inttypes.h and stdin.h.
12161 (PROCESS_H): Add unistd.h.
12163 2011-05-06 Eli Zaretskii <eliz@gnu.org>
12165 * lread.c: Include limits.h (fixes the MS-Windows build broken by
12166 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
12168 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
12170 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
12172 * term.c (vfatal): Remove stray call to va_end.
12173 It's not needed and the C Standard doesn't allow it here anyway.
12175 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
12176 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
12178 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
12181 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
12183 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
12185 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
12187 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
12189 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
12191 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
12192 * charset.c (Fdefine_charset_internal): Don't initialize
12193 charset.code_space[15]. The value was garbage, on hosts with
12194 32-bit int (Bug#8600).
12196 * lread.c (read_integer): Be more consistent with string-to-number.
12197 Use string_to_number to do the actual conversion; this avoids
12198 rounding errors and fixes some other screwups. Without this fix,
12199 for example, #x1fffffffffffffff was misread as -2305843009213693952.
12200 (digit_to_number): Move earlier, for benefit of read_integer.
12201 Return -1 if the digit is out of range for the base, -2 if it is
12202 not a digit in any supported base. (Bug#8602)
12204 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
12206 * dispnew.c (scrolling_window): Return 1 if we scrolled,
12207 to match comment at start of function. This also removes a
12208 GCC warning about overflow in a 32+64-bit port.
12210 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
12212 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
12213 Reported by Stefan Monnier in
12214 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
12215 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12216 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
12218 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
12219 (EMACS_UINTPTR): Likewise, with uintptr_t.
12221 * lisp.h: Prefer 64-bit EMACS_INT if available.
12222 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
12223 on 32-bit hosts that have 64-bit int, so that they can access
12225 However, temporarily disable this change unless the temporary
12226 symbol WIDE_EMACS_INT is defined.
12228 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
12230 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
12231 This removes an assumption that EMACS_INT and long are the same
12232 width as pointers. The assumption is true for Emacs porting targets
12233 now, but we want to make other targets possible.
12234 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
12235 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
12236 In the rest of the code, change types of integers that hold casted
12237 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
12238 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
12239 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
12240 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
12241 No need to cast type when ORing.
12242 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
12243 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
12244 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
12245 assume EMACS_INT is the same width as char *.
12246 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
12247 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
12248 Remove no-longer-needed casts.
12249 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
12250 (xg_tool_bar_help_callback, xg_make_tool_item):
12251 Use EMACS_INTPTR to hold an integer
12252 that will be cast to void *; this can avoid a GCC warning
12253 if EMACS_INT is not the same width as void *.
12254 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
12255 * xdisp.c (display_echo_area_1, resize_mini_window_1):
12256 (current_message_1, set_message_1):
12257 Use a local to convert to proper width without a cast.
12258 * xmenu.c (dialog_selection_callback): Likewise.
12260 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
12261 Also, don't assume VALBITS / RAND_BITS is less than 5,
12262 and don't rely on undefined behavior when shifting a 1 left into
12264 * lisp.h (get_random): Change signature to match.
12266 * lread.c (hash_string): Use size_t, not int, for hash computation.
12267 Normally we prefer signed values; but hashing is special, because
12268 it's better to use unsigned division on hash table sizes so that
12269 the remainder is nonnegative. Also, size_t is the natural width
12270 for hashing into memory. The previous code used 'int', which doesn't
12271 retain enough info to hash well into very large tables.
12272 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
12274 * dbusbind.c: Don't possibly lose pointer info when converting.
12275 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12276 Use XPNTR rather than XHASH, so that the high-order bits of
12277 the pointer aren't lost when converting through void *.
12279 * eval.c (Fautoload): Don't double-shift a pointer.
12281 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
12283 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
12285 * gnutls.c (DEF_GNUTLS_FN):
12286 * image.c (DEF_IMGLIB_FN): Make function pointers static.
12288 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
12290 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
12293 2011-05-05 Eli Zaretskii <eliz@gnu.org>
12295 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
12296 New version that can reserve upto 2GB of heap space.
12298 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
12300 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
12302 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
12304 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
12305 `gnutls_certificate_set_x509_key_file'.
12307 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
12309 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
12310 Update dependencies.
12312 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
12314 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
12315 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
12316 Remove unused parameter `fildes'.
12317 * process.c (read_process_output, send_process): Don't pass it.
12319 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
12321 Fix previous change: the library cache is defined in w32.c.
12322 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
12323 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
12325 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
12327 Implement dynamic loading of GnuTLS on Windows.
12329 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
12330 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
12331 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12334 * gnutls.c (Qgnutls_dll): Define.
12335 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
12336 (gnutls_*): Declare function pointers.
12337 (init_gnutls_functions): New function to initialize function pointers.
12338 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
12339 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
12340 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12341 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
12342 (emacs_gnutls_write, emacs_gnutls_read)
12343 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
12344 (Fgnutls_available_p): New function.
12345 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
12346 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
12347 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
12349 * image.c: Include w32.h.
12350 (Vimage_type_cache): Delete.
12351 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
12352 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
12353 (w32_delayed_load): Move to w32.c.
12355 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
12357 * w32.c (QCloaded_from, Vlibrary_cache): Define.
12358 (w32_delayed_load): Move from image.c. When loading a library, record
12359 its filename in the :loaded-from property of the library id.
12360 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
12361 Initialize and staticpro them.
12362 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
12364 * process.c: Include lisp.h before w32.h, not after.
12365 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
12366 instead of gnutls_record_check_pending.
12368 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
12370 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
12372 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
12373 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
12376 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
12378 * xterm.c (x_set_frame_alpha): Do not set property on anything
12379 else than FRAME_X_OUTER_WINDOW (Bug#8608).
12381 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
12383 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
12385 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
12387 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
12388 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
12389 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
12390 (gnutls_global_initialized, Qgnutls_bootprop_priority)
12391 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
12392 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
12393 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
12394 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
12395 (Qgnutls_bootprop_callbacks_verify): Make static.
12397 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
12399 * callproc.c: Indentation fixup.
12401 * sysdep.c (wait_for_termination_1): Make static.
12402 (wait_for_termination, interruptible_wait_for_termination):
12403 Move after wait_for_termination_1.
12405 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
12407 * sysdep.c (interruptible_wait_for_termination): New function
12408 which is like wait_for_termination, but allows keyboard
12411 * callproc.c (Fcall_process): Add (:file "file") as an option for
12413 (Fcall_process_region): Ditto.
12415 2011-04-30 Eli Zaretskii <eliz@gnu.org>
12417 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
12418 rather than `XVECTOR (FOO)->size'.
12420 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
12421 inttypes.h, as a gnulib replacement is used if it not available in
12424 2011-04-21 Eli Zaretskii <eliz@gnu.org>
12426 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
12427 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
12428 of MOST_POSITIVE_FIXNUM. (Bug#8528)
12430 * coding.c (coding_alloc_by_realloc): Error out if destination
12431 will grow beyond MOST_POSITIVE_FIXNUM.
12432 (decode_coding_emacs_mule): Abort if there isn't enough place in
12433 charbuf for the composition carryover bytes. Reserve an extra
12434 space for up to 2 characters produced in a loop.
12435 (decode_coding_iso_2022): Abort if there isn't enough place in
12436 charbuf for the composition carryover bytes.
12438 2011-04-21 Eli Zaretskii <eliz@gnu.org>
12440 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
12441 aborting when %lld or %lll format is passed.
12442 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
12443 %llo or %llx format is passed. (Bug#8545)
12445 * window.c (window_scroll_line_based): Use a marker instead of
12446 simple variables to record original value of point. (Bug#7952)
12448 * doprnt.c (doprnt): Fix the case where a multibyte sequence
12449 produced by %s or %c overflows available buffer space. (Bug#8545)
12451 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
12453 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
12454 (SIZE_MAX): Move defn after all includes, as they might #define it.
12456 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
12458 * w32.c (init_environment): Warn about defaulting HOME to C:\.
12460 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
12462 * keyboard.c (Qdelayed_warnings_hook): Define.
12463 (command_loop_1): Run `delayed-warnings-hook'
12464 if Vdelayed_warnings_list is non-nil.
12465 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
12466 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
12468 2011-04-28 Eli Zaretskii <eliz@gnu.org>
12470 * doprnt.c (doprnt): Don't return value smaller than the buffer
12471 size if the message was truncated. (Bug#8545).
12473 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
12475 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
12476 (Fx_window_property): #if-0 the whole functions, not just the bodies.
12478 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12480 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
12482 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
12484 * makefile.w32-in: Update dependencies.
12486 2011-04-27 Eli Zaretskii <eliz@gnu.org>
12488 Improve `doprnt' and its usage. (Bug#8545)
12489 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
12490 `format_end'. Remove support for %l as a conversion specifier.
12491 Don't use xrealloc. Improve diagnostics when the %l size modifier
12492 is used. Update the commentary.
12494 * eval.c (verror): Simplify calculation of size_t.
12496 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
12499 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
12501 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
12504 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12506 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
12507 This makes this file independent of the recent pseudovector change.
12509 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
12511 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
12513 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
12514 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
12515 Remove unused local.
12516 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
12518 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
12519 GCC 4.6.0 optimizes based on type-based alias analysis.
12520 For example, if b is of type struct buffer * and v of type struct
12521 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
12522 != &v->size, and therefore "v->size = 1; b->size = 2; return
12523 v->size;" must therefore return 1. This assumption is incorrect
12524 for Emacs, since it type-puns struct Lisp_Vector * with many other
12525 types. To fix this problem, this patch adds a new type struct
12526 vectorlike_header that documents the constraints on layout of vectors
12527 and pseudovectors, and helps optimizing compilers not get fooled
12528 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
12529 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
12530 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
12532 (XSETPVECTYPE): Rewrite in terms of new macro.
12533 (XSETPVECTYPESIZE): New macro, specifying both type and size.
12534 This is a bit clearer, and further avoids the possibility of
12535 undesirable aliasing.
12536 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
12537 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
12538 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
12539 since Lisp_Subr is a special case (no "next" field).
12540 (ASIZE): Now uses header.size rather than size.
12541 All previous uses of XVECTOR (foo)->size replaced to use this macro,
12542 to avoid the hassle of writing XVECTOR (foo)->header.size.
12543 (struct vectorlike_header): New type.
12544 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
12545 object, to help avoid aliasing.
12546 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
12547 (SUBRP): Likewise, since Lisp_Subr is a special case.
12548 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
12549 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
12550 (struct Lisp_Hash_Table): Combine first two members into a single
12551 struct vectorlike_header member. All uses of "size" and "next" members
12552 changed to be "header.size" and "header.next".
12553 * buffer.h (struct buffer): Likewise.
12554 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
12555 * frame.h (struct frame): Likewise.
12556 * process.h (struct Lisp_Process): Likewise.
12557 * termhooks.h (struct terminal): Likewise.
12558 * window.c (struct save_window_data, struct saved_window): Likewise.
12559 * window.h (struct window): Likewise.
12560 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
12561 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
12562 * buffer.c (init_buffer_once): Likewise.
12563 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
12565 * process.c (Fformat_network_address): Use local var for size,
12568 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
12570 Make the Lisp reader and string-to-float more consistent (Bug#8525)
12571 * data.c (atof): Remove decl; no longer used or needed.
12572 (digit_to_number): Move to lread.c.
12573 (Fstring_to_number): Use new string_to_number function, to be
12574 consistent with how the Lisp reader treats infinities and NaNs.
12575 Do not assume that floating-point numbers represent EMACS_INT
12576 without losing information; this is not true on most 64-bit hosts.
12577 Avoid double-rounding errors, by insisting on integers when
12578 parsing non-base-10 numbers, as the documentation specifies.
12579 * lisp.h (string_to_number): New decl, replacing ...
12580 (isfloat_string): Remove.
12581 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
12582 (read1): Do not accept +. and -. as integers; this
12583 appears to have been a coding error. Similarly, do not accept
12584 strings like +-1e0 as floating point numbers. Do not report
12585 overflow for integer overflows unless the base is not 10 which
12586 means we have no simple and reliable way to continue.
12587 Break out the floating-point parsing into a new
12588 function string_to_number, so that Fstring_to_number parses
12589 floating point numbers consistently with the Lisp reader.
12590 (digit_to_number): Move here from data.c. Make it static inline.
12591 (E_CHAR, EXP_INT): Remove, replacing with ...
12592 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12593 (string_to_number): New function, replacing isfloat_string.
12594 This function checks for valid syntax and produces the resulting
12595 Lisp float number too. Rework it so that string-to-number
12596 no longer mishandles examples like "1.0e+". Use strtoumax,
12597 so that overflow for non-base-10 numbers is reported only when
12598 there's no portable and simple way to convert to floating point.
12600 * textprop.c (set_text_properties_1): Rewrite for clarity,
12601 and to avoid GCC warning about integer overflow.
12603 * intervals.h (struct interval): Use EMACS_INT for members
12604 where EMACS_UINT might cause problems. See
12605 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12606 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12607 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12609 (offset_intervals): Tell GCC not to worry about length overflow
12610 when negating a negative length.
12612 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12613 (overrun_check_free): Likewise.
12615 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12616 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12619 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12620 (gnutls_make_error): Rename local to avoid shadowing.
12621 (gnutls_emacs_global_deinit): ifdef out; not used.
12622 (Fgnutls_boot): Use const for pointer to readonly storage.
12623 Comment out unused local. Fix pointer signedness problems.
12625 * lread.c (openp): Don't stuff size_t into an 'int'.
12626 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12627 about possible signed overflow.
12629 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12630 (GDK_KEY_g): Don't define if already defined.
12631 (xg_prepare_tooltip): Avoid pointer signedness problem.
12632 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12634 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12635 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12637 * xfns.c (Fx_window_property): Simplify a bit,
12638 to make a bit faster and to avoid GCC 4.6.0 warning.
12639 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12641 * fns.c (internal_equal): Don't assume size_t fits in int.
12643 * alloc.c (compact_small_strings): Tighten assertion a little.
12645 Replace pEd with more-general pI, and fix some printf arg casts.
12646 * lisp.h (pI): New macro, generalizing old pEd macro to other
12647 conversion specifiers. For example, use "...%"pI"d..." rather
12648 than "...%"pEd"...".
12649 (pEd): Remove. All uses replaced with similar uses of pI.
12650 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
12651 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12652 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12653 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12654 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12655 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12656 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12658 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12659 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12660 * print.c (safe_debug_print, print_object): Likewise.
12661 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12663 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12664 avoiding the 0 flag, which is not portable.
12665 * process.c (Fmake_network_process): Use pI to avoid cast.
12666 * region-cache.c (pp_cache): Likewise.
12667 * xdisp.c (decode_mode_spec): Likewise.
12668 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12669 behavior on 64-bit hosts with printf arg.
12670 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
12671 (x_stop_queuing_selection_requests): Likewise.
12672 (x_get_window_property): Don't truncate byte count to an 'int'
12675 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12676 here, since it parses constructs like leading '-' and spaces,
12677 which are not wanted; and it overflows with large numbers.
12678 Instead, simply match F[0-9]+, which is what is wanted anyway.
12680 * alloc.c: Remove unportable assumptions about struct layout.
12681 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12682 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12683 (allocate_vectorlike, make_pure_vector): Use the new macros,
12684 plus offsetof, to remove unportable assumptions about struct layout.
12685 These assumptions hold on all porting targets that I know of, but
12686 they are not guaranteed, they're easy to remove, and removing them
12687 makes further changes easier.
12689 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12690 This doesn't fix a bug but makes the code clearer.
12691 (string_overrun_cookie): Now const. Use initializers that
12692 don't formally overflow signed char, to avoid warnings.
12693 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12694 can cause Emacs to crash when string overrun checking is enabled.
12695 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12696 multiple of sizeof (EMACS_INT); it need not be, if
12697 alignof(EMACS_INT) < sizeof (EMACS_INT).
12698 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
12700 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
12702 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12704 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12706 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
12707 supposed to be handshaking. (Bug#8556)
12708 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12710 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
12712 * lisp.h (Qdebug): List symbol.
12713 * eval.c (Qdebug): Restore global linkage.
12714 * keyboard.c (debug-on-event): New variable.
12715 (handle_user_signal): Break into debugger when debug-on-event
12716 matches the current signal symbol.
12718 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12720 * alloc.c (check_sblock, check_string_bytes)
12721 (check_string_free_list): Convert to standard C.
12723 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12725 * w32.c (emacs_gnutls_push): Fix typo.
12727 2011-04-25 Eli Zaretskii <eliz@gnu.org>
12729 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12730 "cast to pointer from integer of different size".
12732 Improve doprnt and its use in verror. (Bug#8545)
12733 * doprnt.c (doprnt): Document the set of format control sequences
12734 supported by the function. Use SAFE_ALLOCA instead of always
12737 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12738 is one byte too soon. Don't use xrealloc; instead xfree and
12741 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12743 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12746 * gnutls.c: Renamed global_initialized to
12747 gnutls_global_initialized. Added internals for the
12748 :verify-hostname-error, :verify-error, and :verify-flags
12749 parameters of `gnutls-boot' and documented those parameters in the
12750 docstring. Start callback support.
12751 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12752 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12753 on error. Return error code.
12754 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12755 (emacs_gnutls_read): Likewise.
12756 (Fgnutls_boot): Return handshake error code.
12757 (emacs_gnutls_handle_error): New function.
12758 (wsaerror_to_errno): Likewise.
12760 * w32.h (emacs_gnutls_pull): Add prototype.
12761 (emacs_gnutls_push): Likewise.
12763 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12764 (emacs_gnutls_push): Likewise.
12766 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12768 * process.c (wait_reading_process_output): Check if GnuTLS
12769 buffered some data internally if no FDs are set for TLS
12772 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12773 (LIBS): Link to USER_LIBS.
12774 ($(BLD)/gnutls.$(0)): New target.
12776 2011-04-24 Eli Zaretskii <eliz@gnu.org>
12778 * xdisp.c (handle_single_display_spec): Rename the
12779 display_replaced_before_p argument into display_replaced_p, to
12780 make it consistent with the commentary. Fix typos in the
12783 * textprop.c (syms_of_textprop): Remove dead code.
12784 (copy_text_properties): Delete obsolete commentary about an
12785 interface that was deleted long ago. Fix typos in the description
12788 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12789 to changes in oldXMenu/XMenu.h from 2011-04-16.
12790 <menu_help_message, prev_menu_help_message>: Constify.
12791 (IT_menu_make_room): menu->help_text is now `const char **';
12794 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12795 to changes in oldXMenu/XMenu.h from 2011-04-16.
12796 (struct XMenu): Declare `help_text' `const char **'.
12798 * xfaces.c <Qunspecified>: Make extern again.
12800 * syntax.c: Include sys/types.h before including regex.h, as
12803 * doc.c (get_doc_string): Improve the format passed to `error'.
12805 * doprnt.c (doprnt): Improve commentary.
12807 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12809 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12812 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12813 changes in globals.h immediately force recompilation.
12814 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12815 $(CURDIR)/s/ms-w32.h.
12816 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
12818 * character.c (Fchar_direction): Function deleted.
12819 (syms_of_character): Don't defsubr it.
12820 <char-direction-table>: Deleted.
12822 2011-04-23 Eli Zaretskii <eliz@gnu.org>
12824 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12825 * doprnt.c: Include limits.h.
12826 (SIZE_MAX): New macro.
12827 (doprnt): Return a size_t value. 2nd arg is now size_t.
12828 Many local variables are now size_t instead of int or unsigned.
12829 Improve overflow protection. Support `l' modifier for integer
12830 conversions. Support %l conversion. Don't assume an EMACS_INT
12831 argument for integer conversions and for %c.
12833 * lisp.h (doprnt): Restore prototype.
12835 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12836 $(SRC)/character.h.
12838 * Makefile.in (base_obj): Add back doprnt.o.
12840 * deps.mk (doprnt.o): Add back prerequisites.
12841 (callint.o): Depend on character.h.
12843 * eval.c (internal_lisp_condition_case): Include the handler
12844 representation in the error message.
12845 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12846 when breaking from the loop.
12848 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12850 * callint.c (Fcall_interactively): When displaying error message
12851 about invalid control letter, pass the character's codepoint, not
12852 a pointer to its multibyte form. Improve display of the character
12853 in octal and display also its hex code.
12855 * character.c (char_string): Use %x to display the (unsigned)
12856 codepoint of an invalid character, to avoid displaying a bogus
12859 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12860 `error', not SYMBOL_NAME itself.
12862 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12863 character arguments to `error'.
12865 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12866 to `error' in error message about FINAL_CHAR argument. Make sure
12867 FINAL_CHAR is a character, and use %c when it is passed as
12868 argument to `error'.
12870 2011-04-23 Eli Zaretskii <eliz@gnu.org>
12872 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12874 * w32.c: Include <time.h>.
12875 (sys_localtime): New function.
12877 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
12879 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12881 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
12883 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
12885 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12886 zombies (Bug#8467).
12888 2011-04-19 Eli Zaretskii <eliz@gnu.org>
12890 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12891 gl_state.e_property when gl_state.object is Qt.
12893 * insdel.c (make_gap_larger): Remove limitation of buffer size
12896 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
12898 * xdisp.c (lookup_glyphless_char_display)
12899 (produce_glyphless_glyph): Handle cons cell entry in
12900 glyphless-char-display.
12901 (Vglyphless_char_display): Document it.
12903 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12904 glyphless-char-display.
12906 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
12908 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12910 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12912 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12913 definition for no-X builds.
12915 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
12917 Static checks with GCC 4.6.0 and non-default toolkits.
12919 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12921 * process.c (keyboard_bit_set): Define only if SIGIO.
12922 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12923 (send_process): Repair possible setjmp clobbering.
12925 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12927 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12929 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12931 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12932 Define only if needed.
12934 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12935 by pacifying GCC about it. Maybe it's time to retire it?
12936 * xfaces.c (USG, __TIMEVAL__): Likewise.
12938 * dispextern.h (struct redisplay_interface): Rename param
12939 to avoid shadowing.
12940 * termhooks.h (struct terminal): Likewise.
12941 * xterm.c (xembed_send_message): Likewise.
12943 * insdel.c (make_gap_smaller): Define only if
12944 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12946 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12949 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12950 so that we aren't warned about unused symbols.
12952 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12954 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
12956 * xfns.c (x_real_positions): Mark locals as initialized.
12958 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12960 * xterm.c: Fix problems found by static analysis with other toolkits.
12961 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
12962 (x_dispatch_event): Declare static if USE_GTK, and
12963 define if USE_GTK || USE_X_TOOLKIT.
12964 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
12965 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
12966 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12967 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
12969 * xmenu.c (menu_help_callback): Pointer type fixes.
12970 Use const pointers when pointing at readonly data. Avoid pointer
12971 signedness clashes.
12972 (FALSE): Remove unused macro.
12973 (update_frame_menubar): Remove unused decl.
12975 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12977 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12978 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12979 (single_menu_item): Rename local to avoid shadowing.
12981 * keyboard.c (make_lispy_event): Remove unused local var.
12983 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12984 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12986 * bitmaps: Change bitmaps from unsigned char back to the X11
12987 compatible char. Avoid the old compiler warnings about
12988 out-of-range initializers by using, for example, '\xab' rather
12991 * xgselect.c (xgselect_initialize): Check vs interface
12992 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12994 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12996 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12997 to read-only memory.
12999 * fns.c (vector): Remove; this old hack is no longer needed.
13001 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
13003 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
13005 * xrdb.c (x_load_resources): Omit unused local.
13007 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
13008 (x_window): Rename locals to avoid shadowing.
13009 (USG): Use the kludged USG macro, to pacify gcc.
13011 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
13012 (x_term_init): Remove local to avoid shadowing.
13014 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
13016 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
13017 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
13019 2011-04-16 Eli Zaretskii <eliz@gnu.org>
13021 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
13023 Fix regex.c, syntax.c and friends for buffers > 2GB.
13024 * syntax.h (struct gl_state_s): Declare character position members
13027 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
13029 * textprop.c (verify_interval_modification, interval_of):
13030 Declare arguments EMACS_INT.
13032 * intervals.c (adjust_intervals_for_insertion): Declare arguments
13035 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
13037 * indent.c (Fvertical_motion): Local variable it_start is now
13040 * regex.c (re_match, re_match_2, re_match_2_internal)
13041 (bcmp_translate, regcomp, regexec, print_double_string)
13042 (group_in_compile_stack, re_search, re_search_2, regex_compile)
13043 (re_compile_pattern, re_exec): Declare arguments and local
13044 variables `size_t' and `ssize_t' and return values `regoff_t', as
13046 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
13047 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
13048 <compile_stack_type>: `size' and `avail' are now `size_t'.
13050 * regex.h <regoff_t>: Use ssize_t, not int.
13051 (re_search, re_search_2, re_match, re_match_2): Arguments that
13052 specify buffer/string position and length are now ssize_t and
13053 size_t. Return type is regoff_t.
13055 2011-04-16 Ben Key <bkey76@gmail.com>
13057 * nsfont.m: Fixed bugs in ns_get_family and
13058 ns_descriptor_to_entity that were caused by using free to
13059 deallocate memory blocks that were allocated by xmalloc (via
13060 xstrdup). This caused Emacs to crash when compiled with
13061 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
13062 --enable-checking=xmallocoverrun). xfree is now used to
13063 deallocate these memory blocks.
13065 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
13067 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
13069 emacs_write: Accept and return EMACS_INT for sizes.
13070 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
13072 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
13073 Accept and return EMACS_INT.
13074 (emacs_gnutls_write): Return the number of bytes written on
13076 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
13077 (emacs_read, emacs_write): Remove check for negative size, as the
13078 Emacs source code has been audited now.
13079 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
13080 (emacs_read, emacs_write): Use it.
13081 * process.c (send_process): Adjust to the new signatures of
13082 emacs_write and emacs_gnutls_write. Do not attempt to store
13083 a byte offset into an 'int'; it might overflow.
13084 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
13086 * sound.c: Don't assume sizes fit in 'int'.
13087 (struct sound_device.period_size, alsa_period_size):
13088 Return EMACS_INT, not int.
13089 (struct sound_device.write, vox_write, alsa_write):
13090 Accept EMACS_INT, not int.
13091 (wav_play, au_play): Use EMACS_INT to store sizes and to
13092 record read return values.
13094 2011-04-15 Ben Key <bkey76@gmail.com>
13096 * keyboard.c (Qundefined): Don't declare static since it is used
13098 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
13099 static since they are used in nsfont.m.
13101 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
13103 * process.c (Qprocessp): Don't declare static.
13104 * lisp.h (Qprocessp): Declare again.
13106 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
13108 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
13110 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
13112 Improve C-level modularity by making more things 'static'.
13114 Don't publish debugger-only interfaces to other modules.
13115 * lisp.h (safe_debug_print, debug_output_compilation_hack):
13116 (verify_bytepos, count_markers): Move decls to the only modules
13118 * region-cache.h (pp_cache): Likewise.
13119 * window.h (check_all_windows): Likewise.
13120 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
13122 * sysdep.c (croak): Now static, if
13123 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
13124 * syssignal.h (croak): Declare only if not static.
13126 * alloc.c (refill_memory_reserve): Now static if
13127 !defined REL_ALLOC || defined SYSTEM_MALLOC.
13128 * lisp.h (refill_memory_reserve): Declare only if not static.
13130 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
13131 Define only if USE_LUCID.
13133 * xrdb.c (x_customization_string, x_rm_string): Now static.
13135 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
13136 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
13138 * xdisp.c (draw_row_with_mouse_face): Now static.
13139 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
13141 * window.h (check_all_windows): Mark externally visible.
13143 * window.c (window_deletion_count): Now static.
13145 * undo.c: Make symbols static if they're not exported.
13146 (last_undo_buffer, last_boundary_position, pending_boundary):
13149 * textprop.c (interval_insert_behind_hooks): Now static.
13150 (interval_insert_in_front_hooks): Likewise.
13152 * term.c: Make symbols static if they're not exported.
13153 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
13154 (max_frame_lines, tty_set_terminal_modes):
13155 (tty_reset_terminal_modes, tty_turn_off_highlight):
13156 (get_tty_terminal): Now static.
13157 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
13158 * termhooks.h (term_mouse_moveto): Do not declare if
13159 HAVE_WINDOW_SYSTEM.
13160 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
13161 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
13163 * sysdep.c: Make symbols static if they're not exported.
13164 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
13166 (sigprocmask_set, full_mask): Remove; unused.
13167 (wait_debugging): Mark as visible.
13168 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
13169 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
13171 * syntax.c (syntax_temp): Define only if !__GNUC__.
13173 * sound.c (current_sound_device, current_sound): Now static.
13175 * search.c (searchbufs, searchbuf_head): Now static.
13177 * scroll.c (scroll_cost): Remove; unused.
13178 * dispextern.h (scroll_cost): Remove decl.
13180 * region-cache.h (pp_cache): Mark as externally visible.
13182 * process.c: Make symbols static if they're not exported.
13183 (process_tick, update_tick, create_process, chan_process):
13184 (Vprocess_alist, proc_buffered_char, datagram_access):
13185 (fd_callback_data, send_process_frame, process_sent_to): Now static.
13186 (deactivate_process): Mark defn as static, as well as decl.
13187 * lisp.h (create_process): Remove decl.
13188 * process.h (chan_process, Vprocess_alist): Remove decls.
13190 * print.c: Make symbols static if they're not exported.
13191 (print_depth, new_backquote_output, being_printed, print_buffer):
13192 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
13193 (print_interval, print_number_index, initial_stderr_stream):
13195 * lisp.h (Fprinc): Remove decl.
13196 (debug_output_compilation_hack): Mark as externally visible.
13198 * sysdep.c (croak): Move decl from here to syssignal.h.
13199 * syssignal.h (croak): Put it here, so the API can be checked when
13200 'croak' is called from dissociate_if_controlling_tty.
13202 * minibuf.c: Make symbols static if they're not exported.
13203 (minibuf_save_list, choose_minibuf_frame): Now static.
13204 * lisp.h (choose_minibuf_frame): Remove decl.
13206 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
13208 * lread.c: Make symbols static if they're not exported.
13209 (read_objects, initial_obarray, oblookup_last_bucket_number):
13211 (make_symbol): Remove; unused.
13212 * lisp.h (initial_obarray, make_symbol): Remove decls.
13214 * keyboard.c: Make symbols static if they're not exported.
13215 (single_kboard, recent_keys_index, total_keys, recent_keys):
13216 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
13217 (this_single_command_key_start, echoing, last_auto_save):
13218 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
13219 (command_loop, echo_now, keyboard_init_hook, help_char_p):
13220 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
13221 (Vlispy_mouse_stem, double_click_count):
13223 (force_auto_save_soon): Define only if SIGDANGER.
13224 (ignore_mouse_drag_p): Now static if
13225 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
13226 (print_help): Remove; unused.
13227 (stop_character, last_timer_event): Mark as externally visible.
13228 * keyboard.h (ignore_mouse_drag_p): Declare only if
13229 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
13230 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
13231 * lisp.h (echoing): Remove decl.
13232 (force_auto_save_soon): Declare only if SIGDANGER.
13233 * xdisp.c (redisplay_window): Simplify code, to make it more
13234 obvious that ignore_mouse_drag_p is not accessed if !defined
13235 USE_GTK && !defined HAVE_NS.
13237 * intervals.c: Make symbols static if they're not exported.
13238 (merge_properties_sticky, merge_interval_right, delete_interval):
13240 * intervals.h (merge_interval_right, delete_interval): Remove decls.
13242 * insdel.c: Make symbols static if they're not exported.
13243 However, leave prepare_to_modify_buffer alone. It's never
13244 called from outside this function, but that appears to be a bug.
13245 (combine_after_change_list, combine_after_change_buffer):
13246 (adjust_after_replace, signal_before_change): Now static.
13247 (adjust_after_replace_noundo): Remove; unused.
13248 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
13249 (signal_before_change): Remove decls.
13251 * indent.c (val_compute_motion, val_vmotion): Now static.
13253 * image.c: Make symbols static if they're not exported.
13254 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
13256 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
13257 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
13259 * fringe.c (standard_bitmaps): Now static.
13260 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
13262 * frame.c: Make symbols static if they're not exported.
13263 (x_report_frame_params, make_terminal_frame): Now static.
13264 (get_frame_param): Now static, unless HAVE_NS.
13265 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
13266 (x_get_resource_string): Remove; not used.
13267 * frame.h (make_terminal_frame, x_report_frame_params):
13268 (x_get_resource_string); Remove decls.
13269 (x_fullscreen_adjust): Declare only if WINDOWSNT.
13270 * lisp.h (get_frame_param): Declare only if HAVE_NS.
13272 * font.c, fontset.c: Make symbols static if they're not exported.
13273 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
13274 (FACE_SUITABLE_FOR_CHAR_P): Use it.
13275 * font.c (font_close_object): Now static.
13276 * font.h (font_close_object): Remove.
13277 * fontset.c (FONTSET_OBJLIST): Remove.
13278 (free_realized_fontset) #if-0 the body, which does nothing.
13279 (face_suitable_for_char_p): #if-0, as it's never called.
13280 * fontset.h (face_suitable_for_char_p): Remove decl.
13281 * xfaces.c (face_at_string_position):
13282 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
13283 since 0 is always ASCII.
13285 * fns.c (weak_hash_tables): Now static.
13287 * fileio.c: Make symbols static if they're not exported.
13288 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
13289 (Vwrite_region_annotation_buffers): Now static.
13291 * eval.c: Make symbols static if they're not exported.
13292 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
13293 * lisp.h (backtrace_list): Remove decl.
13295 * emacs.c: Make symbols static if they're not exported.
13296 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
13297 (fatal_error_code, fatal_error_signal_hook, standard_args):
13299 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
13300 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
13301 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
13302 * lisp.h (fatal_error_signal_hook): Remove decl.
13303 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
13305 * editfns.c: Move a (normally-unused) function to its only use.
13306 * editfns.c, lisp.h (get_operating_system_release): Remove.
13307 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
13308 worth the hassle of breaking this out.
13310 * xterm.c: Make symbols static if they're not exported.
13311 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
13312 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
13313 (x_destroy_window, x_delete_display):
13315 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
13316 (x_mouse_leave): Remove; unused.
13317 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
13318 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
13319 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
13321 (x_mouse_leave): Declare only if WINDOWSNT.
13322 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
13323 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
13326 * ftxfont.c: Make symbols static if they're not exported.
13327 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
13329 * font.h (ftxfont_driver): Likewise.
13331 * xfns.c: Make symbols static if they're not exported.
13332 (x_last_font_name, x_display_info_for_name):
13333 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
13334 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
13335 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
13336 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
13337 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
13338 (last_show_tip_args): Now static.
13339 (xic_defaut_fontset, xic_create_fontsetname): Define only if
13340 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
13341 (x_screen_planes): Remove; unused.
13342 * dispextern.h (x_screen_planes): Remove decl.
13344 * dispnew.c: Make symbols static if they're not exported.
13345 * dispextern.h (redraw_garbaged_frames, scrolling):
13346 (increment_row_positions): Remove.
13347 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
13348 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
13350 (redraw_garbaged_frames): Remove; unused.
13352 * xfaces.c: Make symbols static if they're not exported.
13353 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
13355 * xterm.h (defined_color): Remove decls.
13356 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
13357 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
13358 (menu_face_changed_default, defined_color, free_realized_face):
13359 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
13360 (ascii_face_of_lisp_face): Remove; unused.
13362 * xdisp.c: Make symbols static if they're not exported.
13363 * dispextern.h (scratch_glyph_row, window_box_edges):
13364 (glyph_to_pixel_coords, set_cursor_from_row):
13365 (get_next_display_element, set_iterator_to_next):
13366 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
13367 (show_mouse_face): Remove decls
13368 * frame.h (message_buf_print): Likewise.
13369 * lisp.h (pop_message, set_message, check_point_in_composition):
13371 * xterm.h (set_vertical_scroll_bar): Likewise.
13372 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
13373 (message_buf_print, scratch_glyph_row, displayed_buffer):
13374 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
13375 (get_next_display_element, show_mouse_face, window_box_edges):
13376 (frame_to_window_pixel_xy, check_point_in_composition):
13377 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
13378 (glyph_to_pixel_coords): Remove; unused.
13380 * dired.c (file_name_completion): Now static.
13382 * dbusbind.c (xd_in_read_queued_messages): Now static.
13384 * lisp.h (circular_list_error, FOREACH): Remove; unused.
13385 * data.c (circular_list_error): Remove.
13387 * commands.h (last_point_position, last_point_position_buffer):
13388 (last_point_position_window): Remove decls.
13389 * keyboard.c: Make these variables static.
13391 * coding.h (coding, code_convert_region, encode_coding_gap):
13393 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
13394 (iso_code_class, detect_coding, code_convert_region): Now static.
13395 (encode_coding_gap): Remove; unused.
13397 * chartab.c (chartab_chars, chartab_bits): Now static.
13399 * charset.h (charset_iso_8859_1): Remove decl.
13400 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
13403 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
13404 * ccl.c (Vccl_program_table): Now static.
13405 (check_ccl_update): Remove; unused.
13407 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
13408 * category.h: ... from here.
13409 * category.c (check_category_table, set_category_set): Now static.
13411 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
13412 * lisp.h: Remove these decls.
13414 * buffer.c (buffer_count): Remove unused var.
13416 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
13417 so that it's not optimized away.
13418 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
13419 * dispextern.h (bidi_dump_cached_states): Remove, since it's
13420 exported only to the debugger.
13422 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
13423 * atimer.h (run_all_atimers): Remove; not exported.
13425 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
13426 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
13427 was inaccessible from Lisp.
13428 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
13429 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
13431 alloc.c: Import and export fewer symbols, and remove unused items.
13432 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
13434 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
13435 it's not optimized away by whole-program optimization.
13436 (message_enable_multibyte, free_misc): Remove.
13437 (catchlist, handlerlist, mark_backtrace):
13438 Declare only if BYTE_MARK_STACK.
13439 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
13440 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
13441 (message_enable_multibyte): Remove decl.
13442 (free_misc, interval_free_list, float_block, float_block_index):
13443 (n_float_blocks, float_free_list, cons_block, cons_block_index):
13444 (cons_free_list, last_marked_index):
13446 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
13447 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
13448 (mark_backtrace): Define only if BYTE_MARK_STACK.
13449 * xdisp.c (message_enable_multibyte): Now static.
13451 Declare Lisp_Object Q* variables to be 'static' if not exported.
13452 This makes it easier for human readers (and static analyzers)
13453 to see whether these variables are used from other modules.
13454 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
13455 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
13456 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
13457 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
13458 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
13459 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
13460 * xmenu.c, xselect.c:
13461 Declare Q* vars static if they are not used in other modules.
13462 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
13463 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
13464 Remove decls of unexported vars.
13465 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
13467 * lisp.h (DEFINE_FUNC): Make sname 'static'.
13469 Make Emacs functions such as Fatom 'static' by default.
13470 This makes it easier for human readers (and static analyzers)
13471 to see whether these functions can be called from other modules.
13472 DEFUN now defines a static function. To make the function external
13473 so that it can be used in other C modules, use the new macro DEFUE.
13474 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
13475 (Finit_image_library):
13476 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
13477 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
13478 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
13479 Remove decls, since these functions are now static.
13480 (Funintern, Fget_internal_run_time): New decls, since these functions
13481 were already external.
13483 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
13484 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
13485 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
13486 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
13487 * keyboard.c, keymap.c, lread.c:
13488 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
13489 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
13490 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
13491 Mark functions with DEFUE instead of DEFUN,
13492 if they are used in other modules.
13493 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
13494 decls for now-static functions.
13495 * buffer.h (Fdelete_overlay): Remove decl.
13496 * callproc.c (Fgetenv_internal): Mark as internal.
13497 * composite.c (Fremove_list_of_text_properties): Remove decl.
13498 (Fcomposition_get_gstring): New forward static decl.
13499 * composite.h (Fcomposite_get_gstring): Remove decl.
13500 * dired.c (Ffile_attributes): New forward static decl.
13501 * doc.c (Fdocumntation_property): New forward static decl.
13502 * eval.c (Ffetch_bytecode): New forward static decl.
13503 (Funintern): Remove extern decl; now in .h file where it belongs.
13504 * fileio.c (Fmake_symbolic_link): New forward static decl.
13505 * image.c (Finit_image_library): New forward static decl.
13506 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
13507 * intervals.h (Fprevious_property_change):
13508 (Fremove_list_of_text_properties): Remove decls.
13509 * keyboard.c (Fthis_command_keys): Remove decl.
13510 (Fcommand_execute): New forward static decl.
13511 * keymap.c (Flookup_key): New forward static decl.
13512 (Fcopy_keymap): Now static.
13513 * keymap.h (Flookup_key): Remove decl.
13514 * process.c (Fget_process): New forward static decl.
13515 (Fprocess_datagram_address): Mark as internal.
13516 * syntax.c (Fsyntax_table_p): New forward static decl.
13517 (skip_chars): Remove duplicate decl.
13518 * textprop.c (Fprevious_property_change): New forward static decl.
13519 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
13521 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
13522 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
13524 * editfns.c (Fformat): Remove unreachable code.
13526 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
13528 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
13531 2011-04-13 Eli Zaretskii <eliz@gnu.org>
13533 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
13534 when at ZV. (Bug#8487)
13536 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
13538 * charset.c (Fclear_charset_maps): Use xfree instead of free.
13540 * keyboard.c (parse_tool_bar_item): Likewise.
13541 * sound.c (sound_cleanup, alsa_close): Likewise.
13542 * termcap.c (tgetent): Likewise.
13543 * xfns.c (x_default_font_parameter): Likewise.
13544 * xsettings.c (read_and_apply_settings): Likewise.
13546 * alloc.c (overrun_check_malloc, overrun_check_realloc)
13547 (overrun_check_free): Protoize.
13549 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
13551 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
13552 since callers should never pass a negative size.
13553 Change the signature to match that of plain 'read' and 'write'; see
13554 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
13555 * lisp.h: Update prototypes of emacs_write and emacs_read.
13557 2011-04-11 Eli Zaretskii <eliz@gnu.org>
13559 * xdisp.c (redisplay_window): Don't try to determine the character
13560 position of the scroll margin if the window start point w->startp
13561 is outside the buffer's accessible region. (Bug#8468)
13563 2011-04-10 Eli Zaretskii <eliz@gnu.org>
13565 Fix write-region and its subroutines for buffers > 2GB.
13566 * fileio.c (a_write, e_write): Modify declaration of arguments and
13567 local variables to support buffers larger than 2GB.
13568 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
13570 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
13571 argument, local variables, and return value.
13573 * lisp.h: Update prototypes of emacs_write and emacs_read.
13575 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13577 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
13579 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13581 Fix more problems found by GCC 4.6.0's static checks.
13583 * xdisp.c (vmessage): Use a better test for character truncation.
13585 * charset.c (load_charset_map): <, not <=, for optimization,
13586 and to avoid potential problems with integer overflow.
13587 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
13588 * casetab.c (set_identity, shuffle): Likewise.
13589 * editfns.c (Fformat): Likewise.
13590 * syntax.c (skip_chars): Likewise.
13592 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13593 This also lets GCC 4.6.0 generate slightly better loop code.
13595 * callint.c (Fcall_interactively): <, not <=, for optimization.
13596 (Fcall_interactively): Count the number of arguments produced,
13597 not the number of arguments given. This is simpler and lets GCC
13598 4.6.0 generate slightly better code.
13600 * ftfont.c: Distingish more carefully between FcChar8 and char.
13601 The previous code passed unsigned char * to a functions like
13602 strlen and xstrcasecmp that expect char *, which does not
13603 conform to the C standard.
13604 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13605 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13606 char * when the C standard requires it.
13608 * keyboard.c (read_char): Remove unused var.
13610 * eval.c: Port to Windows vsnprintf (Bug#8435).
13611 Include <limits.h>.
13612 (SIZE_MAX): Define if the headers do not.
13613 (verror): Do not give up if vsnprintf returns a negative count.
13614 Instead, grow the buffer. This ports to Windows vsnprintf, which
13615 does not conform to C99. Problem reported by Eli Zaretskii.
13616 Also, simplify the allocation scheme, by avoiding the need for
13617 calling realloc, and removing the ALLOCATED variable.
13619 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13621 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13622 But keep the doprint source code for now, as we might revamp it
13623 and use it again (Bug#8435).
13624 * lisp.h (doprnt): Remove.
13625 * Makefile.in (base_obj): Remove doprnt.o.
13626 * deps.mk (doprnt.o): Remove.
13628 error: Print 32- and 64-bit integers portably (Bug#8435).
13629 Without this change, on typical 64-bit hosts error ("...%d...", N)
13630 was used to print both 32- and 64-bit integers N, which relied on
13631 undefined behavior.
13632 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
13633 * lisp.h (error, verror): Mark as printf-like functions.
13634 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13635 Report overflow in size calculations when allocating printf buffer.
13636 Do not truncate output string at its first null byte.
13637 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13638 Truncate the output at a character boundary, since vsnprintf does not
13640 * charset.c (check_iso_charset_parameter): Convert internal
13641 character to string before calling 'error', since %c now has the
13643 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13644 overflow when computing char to be passed to 'error'. Do not
13645 pass Lisp_Object to 'error'; pass the integer instead.
13646 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13647 formatted with plain %d.
13649 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13651 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13653 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13655 * xterm.c (x_catch_errors): Remove duplicate declaration.
13657 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13659 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13661 2011-04-10 Jim Meyering <meyering@redhat.com>
13663 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13664 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13665 return ssize_t not "int", and use size_t as the buffer length.
13666 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13667 * gnutls.h: Update declarations.
13668 * process.c (read_process_output): Use ssize_t, to match.
13669 (send_process): Likewise.
13671 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
13673 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13675 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
13677 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13678 Use unsigned char, to match FcChar8 type definition.
13680 * xterm.c (handle_one_xevent):
13681 * xmenu.c (create_and_show_popup_menu):
13682 * xselect.c (x_decline_selection_request)
13683 (x_reply_selection_request): Avoid type-punned deref of X events.
13685 2011-04-09 Eli Zaretskii <eliz@gnu.org>
13687 Fix some uses of `int' instead of EMACS_INT.
13688 * search.c (string_match_1, fast_string_match)
13689 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13690 (scan_buffer, find_next_newline_no_quit)
13691 (find_before_next_newline, search_command, Freplace_match)
13692 (Fmatch_data): Make some `int' variables be EMACS_INT.
13694 * xdisp.c (display_count_lines): 3rd argument and return value now
13695 EMACS_INT. All callers changed.
13696 (pint2hrstr): Last argument is now EMACS_INT.
13698 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13699 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13700 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13701 (decode_coding_utf_16, decode_coding_emacs_mule)
13702 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13703 (decode_coding_ccl, decode_coding_charset)
13704 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13705 (decode_coding_iso_2022, decode_coding_emacs_mule)
13706 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13707 <char_offset, last_offset>: Declare EMACS_INT.
13708 (encode_coding_utf_8, encode_coding_utf_16)
13709 (encode_coding_emacs_mule, encode_invocation_designation)
13710 (encode_designation_at_bol, encode_coding_iso_2022)
13711 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13712 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13714 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13715 (encode_invocation_designation): Last argument P_NCHARS is now
13717 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13718 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13720 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13723 * ccl.c (Fccl_execute_on_string): Declare some variables
13726 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
13728 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13730 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13732 * process.c (Fformat_network_address): Doc fix.
13734 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13736 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
13738 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
13740 * keyboard.c (read_char): Call Lisp function help-form-show,
13741 instead of using internal_with_output_to_temp_buffer.
13742 (Qhelp_form_show): New var.
13743 (syms_of_keyboard): Use DEFSYM macro.
13745 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13747 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13749 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
13751 * process.c (Flist_processes): Remove to Lisp.
13752 (list_processes_1): Delete.
13754 2011-04-06 Eli Zaretskii <eliz@gnu.org>
13756 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13758 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13760 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
13762 Fix more problems found by GCC 4.6.0's static checks.
13764 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13766 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13768 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
13770 * xdisp.c (vmessage): Mark as a printf-like function.
13772 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13774 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13776 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13777 printf-like functions.
13778 (tiff_load): Add casts to remove these marks before passing them
13779 to system-supplied API.
13781 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13783 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13784 This avoids several warnings with gcc -Wstrict-overflow.
13785 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13786 directly, rather than having caller test rule sign. This avoids
13787 some unnecessary tests.
13788 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13789 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13790 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
13792 * xfont.c (xfont_text_extents): Remove var that was set but not used.
13793 (xfont_open): Avoid unnecessary tests.
13795 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13797 * composite.h, composite.c (composition_gstring_put_cache):
13798 Use EMACS_INT, not int, for length.
13800 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13801 breaking out part of COMPOSITION_DECODE_RULE.
13802 (COMPOSITION_DECODE_RULE): Use it.
13803 * composite.c (get_composition_id): Remove unused local vars,
13804 by using the new macro.
13806 * textprop.c (set_text_properties_1): Change while to do-while,
13807 since the condition is always true at first.
13809 * intervals.c (graft_intervals_into_buffer): Mark var as used.
13810 (interval_deletion_adjustment): Return unsigned value.
13813 * process.c (list_processes_1, create_pty, read_process_output):
13814 (exec_sentinel): Remove vars that were set but not used.
13815 (create_pty): Remove unnecessary "volatile"s.
13816 (Fnetwork_interface_info): Avoid possibility of int overflow.
13817 (read_process_output): Do adaptive read buffering even if carryover.
13818 (read_process_output): Simplify nbytes computation if buffered.
13820 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13822 * syntax.c (scan_words): Remove var that was set but not used.
13823 (update_syntax_table): Use unsigned instead of int.
13825 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
13826 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
13827 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
13829 * print.c (print_error_message): Avoid int overflow.
13831 * font.c (font_list_entities): Redo for clarity,
13832 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13834 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
13835 (font_score): Avoid potential overflow in diff calculation.
13837 * fns.c (substring_both): Remove var that is set but not used.
13838 (sxhash): Redo loop for clarity and to avoid wraparound warning.
13840 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13842 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13843 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13844 can always succeed if overflow has undefined behavior.
13846 * search.c (boyer_moore, wordify): Remove vars set but not used.
13847 (wordify): Omit three unnecessary tests.
13849 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13850 All callers changed. This avoids the need for an unused var.
13852 * casefiddle.c (casify_region): Remove var that is set but not used.
13854 * dired.c (file_name_completion): Remove var that is set but not used.
13856 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13858 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
13859 (Finsert_file_contents): Remove unnecessary code checking fd.
13861 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13862 Check for integer overflow on size calculations.
13864 * buffer.c (Fprevious_overlay_change): Remove var that is set
13867 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13868 Remove vars that are set but not used.
13869 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
13870 (timer_check_2): Mark vars as initialized.
13872 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13874 * image.c (lookup_image): Remove var that is set but not used.
13875 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
13877 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13878 that are set but not used.
13880 * xfns.c (make_invisible_cursor): Don't return garbage
13881 if XCreateBitmapFromData fails (Bug#8410).
13883 * xselect.c (x_get_local_selection, x_handle_property_notify):
13884 Remove vars that are set but not used.
13886 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
13887 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
13889 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13890 Remove var that is set but not used.
13891 (scroll_bar_windows_size): Now size_t, not int.
13892 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13893 Check for overflow.
13895 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13896 (map_tty_color) [!defined MSDOS]: Likewise.
13898 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13900 * coding.c: Remove vars that are set but not used.
13901 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13902 All callers changed.
13903 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13904 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13905 (decode_coding_charset): Remove vars that are set but not used.
13907 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13908 that is set but not used.
13910 * print.c (print_object): Remove var that is set but not used.
13912 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
13913 The gnulib version avoids calling malloc in the usual case,
13914 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13915 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13916 * filelock.c (current_lock_owner): Likewise.
13917 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13918 * sysdep.c: Include allocator.h, careadlinkat.h.
13919 (emacs_no_realloc_allocator): New static constant.
13920 (emacs_readlink): New function.
13921 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13922 ../lib/careadlinkat.h.
13924 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13926 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13927 first non-nil return value).
13929 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13931 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13932 if not defined (Bug#8403).
13934 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
13936 * xdisp.c (display_count_lines): Remove parameter `start',
13937 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13938 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13939 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13940 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13941 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13942 and thereabouts. All callers changed.
13943 (get_per_char_metric): Remove parameter `f', unused since
13944 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13946 2011-04-02 Jim Meyering <meyering@redhat.com>
13948 do not dereference NULL upon failed strdup
13949 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13950 (ns_get_family): Likewise.
13952 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
13954 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13956 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13958 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13961 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13963 Add lexical binding.
13965 * window.c (Ftemp_output_buffer_show): New fun.
13966 (Fsave_window_excursion):
13967 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13969 * lread.c (lisp_file_lexically_bound_p): New function.
13970 (Fload): Bind Qlexical_binding.
13971 (readevalloop): Remove `evalfun' arg.
13972 Bind Qinternal_interpreter_environment.
13973 (Feval_buffer): Bind Qlexical_binding.
13974 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13976 (syms_of_lread): Declare `lexical-binding'.
13978 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13980 * keyboard.c (eval_dyn): New fun.
13981 (menu_item_eval_property): Use it.
13983 * image.c (parse_image_spec): Use Ffunctionp.
13985 * fns.c (concat, mapcar1): Accept byte-code-functions.
13987 * eval.c (Fsetq): Handle lexical vars.
13988 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13989 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13990 (FletX, Flet): Obey lexical binding.
13991 (Fcommandp): Handle closures.
13992 (Feval): New `lexical' arg.
13993 (eval_sub): New function extracted from Feval. Use it almost
13994 everywhere where Feval was used. Look up vars in lexical env.
13996 (Ffunctionp): Move from subr.el.
13997 (Ffuncall): Handle closures.
13998 (apply_lambda): Remove `eval_flags'.
13999 (funcall_lambda): Handle closures and new byte-code-functions.
14000 (Fspecial_variable_p): New function.
14001 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
14002 but without exporting it to Lisp.
14004 * doc.c (Fdocumentation, store_function_docstring):
14005 * data.c (Finteractive_form): Handle closures.
14007 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
14010 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
14012 (exec_byte_code): New function extracted from Fbyte_code to handle new
14013 calling convention for byte-code-functions. Add new byte-codes.
14015 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
14017 * alloc.c (Fmake_symbol): Init new `declared_special' field.
14019 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
14021 * xdisp.c (redisplay_internal): Fix prototype.
14023 2011-03-31 Eli Zaretskii <eliz@gnu.org>
14025 * xdisp.c (SCROLL_LIMIT): New macro.
14026 (try_scrolling): Use it when setting scroll_limit.
14027 Limit scrolling to 100 screen lines.
14028 (redisplay_window): Even when falling back on "recentering",
14029 position point in the window according to scroll-conservatively,
14030 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
14032 (try_scrolling): When point is above the window, allow searching
14033 as far as scroll_max, or one screenful, to compute vertical
14034 distance from PT to the scroll margin position. This prevents
14035 try_scrolling from unnecessarily failing when
14036 scroll-conservatively is set to a value slightly larger than the
14037 window height. Clean up the case of PT below the margin at bottom
14038 of window: scroll_max can no longer be INT_MAX. When aggressive
14039 scrolling is in use, don't let point enter the opposite scroll
14040 margin as result of the scroll.
14041 (syms_of_xdisp) <scroll-conservatively>: Document the
14042 threshold of 100 lines for never-recentering scrolling.
14044 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
14046 * dispextern.h (move_it_by_lines):
14047 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
14048 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
14049 (message_log_check_duplicate): Remove parameters `prev_bol' and
14050 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
14051 (redisplay_internal): Remove parameter `preserve_echo_area',
14052 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
14054 * indent.c (Fvertical_motion):
14055 * window.c (window_scroll_pixel_based, Frecenter):
14056 Don't pass `need_y_p' to `move_it_by_lines'.
14058 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
14060 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
14061 steal a few bits to be more compact.
14062 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
14063 Remove unneeded casts.
14065 * bytecode.c (Fbyte_code): CAR and CDR can GC.
14067 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
14069 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
14070 binding" message (bug#7967).
14072 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
14074 Fix more problems found by GCC 4.6.0's static checks.
14076 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
14077 Remove unused local var.
14079 * editfns.c (Fmessage_box): Remove unused local var.
14081 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
14082 (note_mode_line_or_margin_highlight, note_mouse_highlight):
14083 Omit unused local vars.
14084 * window.c (shrink_windows): Omit unused local var.
14085 * menu.c (digest_single_submenu): Omit unused local var.
14086 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
14087 Omit unused local var.
14089 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
14090 Don't assume string length fits in int.
14091 (keyremap_step, read_key_sequence): Use size_t for sizes.
14092 (read_key_sequence): Don't check last_real_key_start redundantly.
14094 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
14095 instead of alloca (Bug#8344).
14097 * eval.c (Fbacktrace): Don't assume nargs fits in int.
14098 (Fbacktrace_frame): Don't assume nframes fits in int.
14100 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
14102 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
14105 * term.c (produce_glyphless_glyph): Remove unnecessary test.
14107 * cm.c (calccost): Turn while-do into do-while, for clarity.
14109 * keyboard.c (syms_of_keyboard): Use the same style as later
14110 in this function when indexing through an array. This also
14111 works around GCC bug 48267.
14113 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
14115 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
14117 * chartab.c (sub_char_table_ref_and_range): Redo for slight
14118 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
14120 * keyboard.c, keyboard.h (num_input_events): Now size_t.
14121 This avoids undefined behavior on integer overflow, and is a bit
14122 more convenient anyway since it is compared to a size_t variable.
14124 Variadic C functions now count arguments with size_t, not int.
14125 This avoids an unnecessary limitation on 64-bit machines, which
14126 caused (substring ...) to crash on large vectors (Bug#8344).
14127 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
14128 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
14129 All variadic functions and their callers changed accordingly.
14130 (struct gcpro.nvars): Now size_t, not int. All uses changed.
14131 * data.c (arith_driver, float_arith_driver): Likewise.
14132 * editfns.c (general_insert_function): Likewise.
14133 * eval.c (struct backtrace.nargs, interactive_p)
14134 (internal_condition_case_n, run_hook_with_args, apply_lambda)
14135 (funcall_lambda, mark_backtrace): Likewise.
14136 * fns.c (concat): Likewise.
14137 * frame.c (x_set_frame_parameters): Likewise.
14138 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
14139 0 if not found, not -1. All callers changed.
14141 * alloc.c (garbage_collect): Don't assume stack size fits in int.
14142 (stack_copy_size): Now size_t, not int.
14143 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
14145 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
14147 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
14148 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14149 All callers changed.
14151 * lisp.h (multibyte_char_to_unibyte):
14152 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
14153 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14154 * character.h (CHAR_TO_BYTE8):
14155 * cmds.c (internal_self_insert):
14156 * editfns.c (general_insert_function):
14157 * keymap.c (push_key_description):
14158 * search.c (Freplace_match):
14159 * xdisp.c (message_dolog, set_message_1): All callers changed.
14161 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
14163 * keyboard.c (safe_run_hook_funcall): New function.
14164 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
14165 don't set the hook to nil, but remove the offending function instead.
14166 (Qcommand_hook_internal): Remove, unused.
14167 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
14168 Vcommand_hook_internal.
14170 * eval.c (enum run_hooks_condition): Remove.
14171 (funcall_nil, funcall_not): New functions.
14172 (run_hook_with_args): Call each function through a `funcall' argument.
14173 Remove `cond' argument, now redundant.
14174 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
14175 (Frun_hook_with_args_until_failure): Adjust accordingly.
14176 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
14178 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
14180 * dispextern.h (string_buffer_position): Remove declaration.
14182 * print.c (strout): Remove parameter `multibyte', unused since
14183 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
14185 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
14186 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
14187 All callers changed.
14189 * w32.c (_wsa_errlist): Use braces for struct initializers.
14191 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
14192 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
14193 All callers changed.
14194 (string_buffer_position): Likewise. Also, make static (it's never
14195 used outside xdisp.c).
14196 (cursor_row_p): Remove parameter `w', unused since
14197 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
14198 (decode_mode_spec): Remove parameter `precision', introduced during
14199 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
14200 All callers changed.
14202 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14204 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
14206 2011-03-27 Anders Lindgren <andlind@gmail.com>
14208 * nsterm.m (ns_menu_bar_is_hidden): New variable.
14209 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
14210 (ns_update_auto_hide_menu_bar): New functions.
14211 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
14212 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
14213 ns_constrain_all_frames.
14214 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
14215 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
14217 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14219 * nsmenu.m (runDialogAt): Remove argument to timer_check.
14221 2011-03-27 Glenn Morris <rgm@gnu.org>
14223 * syssignal.h: Replace RETSIGTYPE with void.
14224 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
14225 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
14226 Replace SIGTYPE with void everywhere.
14227 * s/usg5-4-common.h (SIGTYPE): Remove definition.
14228 * s/template.h (SIGTYPE): Remove commented out definition.
14230 2011-03-26 Eli Zaretskii <eliz@gnu.org>
14232 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
14233 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
14235 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
14237 * w32.c (read_unc_volume): Use parameter `henum', instead of
14238 global variable `wget_enum_handle'.
14240 * keymap.c (describe_vector): Remove parameters `indices' and
14241 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
14242 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
14244 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
14246 * keyboard.c (timer_check): Remove parameter `do_it_now',
14247 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
14248 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
14249 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
14251 * keyboard.c (read_char):
14252 * w32menu.c (w32_menu_display_help):
14253 * xmenu.c (show_help_event, menu_help_callback):
14254 Adjust calls to `show_help_echo'.
14256 * gtkutil.c (xg_maybe_add_timer):
14257 * keyboard.c (readable_events):
14258 * process.c (wait_reading_process_output):
14259 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
14261 * insdel.c (adjust_markers_gap_motion):
14262 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
14263 (gap_left, gap_right): Don't call it.
14265 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
14267 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
14268 incurred during fontification.
14270 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
14272 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
14273 (DEFVAR_PER_BUFFER): Don't pass it.
14275 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
14276 (scrolling_window): Don't pass it.
14278 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
14280 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
14282 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
14284 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
14285 of variables specific to SELinux and computation of `encoded_absname'.
14287 * image.c (XPutPixel): Remove unused variable `height'.
14289 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
14291 * unexw32.c (get_section_info): Remove unused variable `section'.
14293 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
14294 (system_process_attributes): Remove unused variable `sess'.
14295 (sys_read): Remove unused variable `err'.
14297 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
14298 (w32_wnd_proc): Remove unused variable `isdead'.
14299 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
14300 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
14301 (x_create_tip_frame): Remove unused variable `tem'.
14303 * w32inevt.c (w32_console_read_socket):
14304 Remove unused variable `no_events'.
14306 * w32term.c (x_draw_composite_glyph_string_foreground):
14307 Remove unused variable `width'.
14309 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
14311 * w32term.c (x_set_glyph_string_clipping):
14312 Don't pass uninitialized region to CombineRgn.
14314 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
14316 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
14317 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
14318 (Fx_close_connection): Remove unused variable `i'.
14320 * w32font.c (w32font_draw): Return number of glyphs.
14321 (w32font_open_internal): Remove unused variable `i'.
14322 (w32font_driver): Add missing initializer.
14324 * w32menu.c (utf8to16): Remove unused variable `utf16'.
14325 (fill_in_menu): Remove unused variable `items_added'.
14327 * w32term.c (last_mouse_press_frame): Remove static global variable.
14328 (w32_clip_to_row): Remove unused variable `f'.
14329 (x_delete_terminal): Remove unused variable `i'.
14331 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
14332 (NOTHING): Remove unused static global variable.
14333 (uniscribe_check_otf): Remove unused variable `table'.
14334 (uniscribe_font_driver): Add missing initializers.
14336 2011-03-23 Julien Danjou <julien@danjou.info>
14338 * term.c (Fsuspend_tty, Fresume_tty):
14339 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
14340 * window.c (temp_output_buffer_show):
14341 * insdel.c (signal_before_change):
14342 * frame.c (Fhandle_switch_frame):
14343 * fileio.c (Fdo_auto_save):
14344 * emacs.c (Fkill_emacs):
14345 * editfns.c (save_excursion_restore):
14346 * cmds.c (internal_self_insert):
14347 * callint.c (Fcall_interactively):
14348 * buffer.c (Fkill_all_local_variables):
14349 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
14351 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
14352 unconditionally since it does the check itself.
14354 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
14356 Fix more problems found by GCC 4.5.2's static checks.
14358 * coding.c (encode_coding_raw_text): Avoid unnecessary test
14359 the first time through the loop, since we know p0 < p1 then.
14360 This also avoids a gcc -Wstrict-overflow warning.
14362 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
14363 leading to a memory leak, possible in functions like
14364 load_charset_map_from_file that can allocate an unbounded number
14365 of objects (Bug#8318).
14367 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
14368 that could (at least in theory) be that large.
14370 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
14371 This is less likely to overflow, and avoids undefined behavior if
14372 overflow does occur. All callers changed. Use strtoul to scan
14373 for the unsigned long integer.
14374 (pint2hrstr): Simplify and tune code slightly.
14375 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
14377 * scroll.c (do_scrolling): Work around GCC bug 48228.
14378 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
14380 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
14381 This also avoids a warning with gcc -Wstrict-overflow.
14382 (validate_x_resource_name): Simplify count usage.
14383 This also avoids a warning with gcc -Wstrict-overflow.
14385 * fileio.c (Fcopy_file): Report error if fchown or fchmod
14388 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
14390 * process.c (Fmake_network_process): Use socklen_t, not int,
14391 where POSIX says socklen_t is required in portable programs.
14392 This fixes a porting bug on hosts like 64-bit HP-UX, where
14393 socklen_t is wider than int (Bug#8277).
14394 (Fmake_network_process, server_accept_connection):
14395 (wait_reading_process_output, read_process_output):
14398 * process.c: Rename or move locals to avoid shadowing.
14399 (list_processes_1, Fmake_network_process):
14400 (read_process_output_error_handler, exec_sentinel_error_handler):
14401 Rename or move locals.
14402 (Fmake_network_process): Define label "retry_connect" only if needed.
14403 (Fnetwork_interface_info): Fix pointer signedness.
14404 (process_send_signal): Add cast to avoid pointer signedness problem.
14405 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
14406 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
14408 Make tparam.h and terminfo.c consistent.
14409 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
14410 Include tparam.h instead, since it declares them.
14411 * cm.h (PC): Remove extern decl; tparam.h now does this.
14412 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
14413 * terminfo.c: Include tparam.h, to check interfaces.
14414 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
14415 (tparam): Adjust signature to match interface in tparam.h;
14416 this removes some undefined behavior. Check that outstring and len
14417 are zero, which they always are with Emacs.
14418 * tparam.h (PC, BC, UP): New extern decls.
14420 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
14421 (xftfont_open): Rename locals to avoid shadowing.
14423 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
14424 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
14425 (OTF_TAG_SYM): Omit macro if not needed.
14426 (ftfont_list): Remove unused local.
14427 (get_adstyle_property, ftfont_pattern_entity):
14428 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
14429 Rename locals to avoid shadowing.
14431 * xfont.c (xfont_list_family): Mark var as initialized.
14433 * xml.c (make_dom): Now static.
14435 * composite.c (composition_compute_stop_pos): Rename local to
14437 (composition_reseat_it): Remove unused locals.
14438 (find_automatic_composition, composition_adjust_point): Likewise.
14439 (composition_update_it): Mark var as initialized.
14440 (find_automatic_composition): Mark vars as initialized,
14441 with a FIXME (Bug#8290).
14443 character.h: Rename locals to avoid shadowing.
14444 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
14445 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
14446 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
14447 (BUF_DEC_POS): Be more systematic about renaming local temporaries
14448 to avoid shadowing.
14450 * textprop.c (property_change_between_p): Remove; unused.
14452 * intervals.c (interval_start_pos): Now static.
14454 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
14456 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
14457 Rename locals to avoid shadowing.
14459 * sound.c (wav_play, au_play, Fplay_sound_internal):
14460 Fix pointer signedness.
14461 (alsa_choose_format): Remove unused local var.
14462 (wav_play): Initialize a variable to 0, to prevent undefined
14463 behavior (Bug#8278).
14465 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
14467 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
14469 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
14470 clobbering (Bug#8298).
14471 * sysdep.c (sys_subshell): Likewise.
14472 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
14474 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
14475 This should get cleaned up, so that child_setup has the
14476 same signature on all platforms.
14478 * callproc.c (call_process_cleanup): Now static.
14479 (relocate_fd): Rename locals to avoid shadowing.
14481 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
14483 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
14484 not to be necessary, and produces flickering.
14486 2011-03-20 Glenn Morris <rgm@gnu.org>
14488 * config.in: Remove file.
14490 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
14492 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
14493 are now in src/globals.h.
14494 (syms_of_minibuf): Remove spurious & from previous change.
14496 2011-03-20 Leo Liu <sdl.web@gmail.com>
14498 * minibuf.c (completing-read-function): New variable.
14499 (completing-read-default): Rename from completing-read.
14500 (completing-read): Call completing-read-function.
14502 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
14504 * xfaces.c (Fx_load_color_file):
14505 Read color file from absolute filename (bug#8250).
14507 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
14509 * makefile.w32-in: Update dependencies.
14511 2011-03-17 Eli Zaretskii <eliz@gnu.org>
14513 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
14515 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
14517 Fix more problems found by GCC 4.5.2's static checks.
14519 * process.c (make_serial_process_unwind, send_process_trap):
14520 (sigchld_handler): Now static.
14522 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
14523 That way, the code declares only the vars that it needs.
14524 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
14525 * s/cygwin.h (PTY_ITERATION): Likewise.
14526 * s/darwin.h (PTY_ITERATION): Likewise.
14527 * s/gnu-linux.h (PTY_ITERATION): Likewise.
14529 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
14530 * process.c (allocate_pty): Don't declare stb unless it's needed.
14532 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
14533 (CONSTANTLIM): Remove; unused.
14534 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
14535 Define only if needed.
14537 * unexelf.c (unexec): Name an expression,
14538 to avoid gcc -Wbad-function-cast warning.
14539 Use a different way to cause a compilation error if anyone uses
14540 n rather than nn, a way that does not involve shadowing.
14541 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
14543 * deps.mk (unexalpha.o): Remove; unused.
14545 New file unexec.h, the (simple) interface for unexec (Bug#8267).
14546 * unexec.h: New file.
14547 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
14548 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
14549 Depend on unexec.h.
14550 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
14551 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
14552 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
14553 Change as necessary to match prototype in unexec.h.
14555 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
14557 (back_comment, skip_chars): Mark vars as initialized.
14559 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
14560 Rename locals to avoid shadowing.
14562 * lread.c (read1): Rewrite so as not to use empty "else".
14563 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
14565 * print.c (Fredirect_debugging_output): Fix pointer signedess.
14567 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
14568 warning when compiling print.c.
14570 * font.c (font_unparse_fcname): Abort in an "impossible" situation
14571 instead of using an uninitialized var.
14572 (font_sort_entities): Mark var as initialized.
14574 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14576 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14577 pointers to constants.
14578 (font_parse_fcname): Remove unused vars.
14579 (font_delete_unmatched): Now static.
14580 (font_get_spec): Remove; unused.
14581 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14582 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14583 Rename or move locals to avoid shadowing.
14585 * fns.c (require_nesting_list, require_unwind): Now static.
14586 (Ffillarray): Rename locals to avoid shadowing.
14588 * floatfns.c (domain_error2): Define only if needed.
14589 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
14591 * alloc.c (mark_backtrace): Move decl from here ...
14592 * lisp.h: ... to here, so that it can be checked.
14594 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
14595 (Fdefvar): Rewrite so as not to use empty "else".
14596 (lisp_indirect_variable): Name an expression,
14597 to avoid gcc -Wbad-function-cast warning.
14598 (Fdefvar): Rename locals to avoid shadowing.
14600 * callint.c (quotify_arg, quotify_args): Now static.
14601 (Fcall_interactively): Rename locals to avoid shadowing.
14602 Use const pointer when appropriate.
14604 * lisp.h (get_system_name, get_operating_system_release):
14605 Move decls here, to check interfaces.
14606 * process.c (get_operating_system_release): Move decl to lisp.h.
14607 * xrdb.c (get_system_name): Likewise.
14608 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14609 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14610 some of which prompt warnings from gcc -Wbad-function-cast.
14611 (Fformat_time_string, Fencode_time, Finsert_char):
14612 (Ftranslate_region_internal, Fformat):
14613 Rename or remove local vars to avoid shadowing.
14614 (Ftranslate_region_internal): Mark var as initialized.
14616 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14619 * lisp.h (eassert): Check that the argument compiles, even if
14620 ENABLE_CHECKING is not defined.
14622 * data.c (Findirect_variable): Name an expression, to avoid
14623 gcc -Wbad-function-cast warning.
14624 (default_value, arithcompare, arith_driver, arith_error): Now static.
14625 (store_symval_forwarding): Rename local to avoid shadowing.
14626 (Fmake_variable_buffer_local, Fmake_local_variable):
14627 Mark variables as initialized.
14628 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
14630 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
14631 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14632 Rename locals to avoid shadowing.
14633 (mark_stack): Move local variables into the #ifdef region where
14635 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14636 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14638 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14639 (GC_STRING_CHARS): Remove; not used.
14640 (Fmemory_limit): Cast sbrk's returned value to char *.
14642 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14643 avoids undefined behavior in theory.
14645 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14647 Use functions, not macros, for up- and down-casing (Bug#8254).
14648 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14649 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14650 to use the following functions instead of these macros.
14651 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14652 EMACS_INT, since callers assume the returned value fits in int.
14653 (upcase1): Likewise, for UPCASE_TABLE.
14654 (uppercasep, lowercasep, upcase): New static inline functions.
14655 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
14656 the race-condition problem in the old DOWNCASE.
14658 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14659 Rename locals to avoid shadowing.
14660 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
14661 (regex_compile, re_search_2, re_match_2_internal):
14662 Remove unused local vars.
14663 (FREE_VAR): Rewrite so as not to use empty "else",
14664 which gcc can warn about.
14665 (regex_compile, re_match_2_internal): Mark locals as initialized.
14666 (RETALLOC_IF): Define only if needed.
14667 (WORDCHAR_P): Likewise. This one is never needed, but is used
14668 only in a comment talking about a compiler bug, so put inside
14669 the #if 0 of that comment.
14670 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14671 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14674 * search.c (boyer_moore): Rename locals to avoid shadowing.
14675 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14676 (PREV_CHAR_BOUNDARY): Likewise.
14678 * search.c (simple_search): Remove unused var.
14680 * dired.c (compile_pattern): Move decl from here ...
14681 * lisp.h: ... to here, so that it can be checked.
14682 (struct re_registers): New forward decl.
14684 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14686 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14688 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14689 Rename locals to avoid shadowing.
14690 (Fvertical_motion): Mark locals as initialized.
14692 * casefiddle.c (casify_object, casify_region): Now static.
14693 (casify_region): Mark local as initialized.
14695 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14697 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14698 New macros, so that the caller can use some names other than
14699 gcpro1, gcpro2, etc.
14700 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14702 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14703 argument, for consistency with GCPRO2_VAR, etc: it is now the
14704 prefix of the variable, not the variable itself. All uses
14706 * dired.c (directory_files_internal, file_name_completion):
14707 Rename locals to avoid shadowing.
14709 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14710 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14711 dired.c's scmp function, had undefined behavior.
14712 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14713 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14714 * buffer.h: ... to here, because these macros use current_buffer,
14715 and the new implementation with inline functions needs to have
14716 current_buffer in scope now, rather than later when the macros
14718 (downcase, upcase1): New static inline functions.
14719 (DOWNCASE, UPCASE1): Reimplement using these functions.
14720 This avoids undefined behavior in expressions like
14721 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14722 from race conditions in accessing the global variables
14723 case_temp1 and case_temp2.
14724 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14725 * lisp.h (case_temp1, case_temp2): Remove their decls.
14726 * character.h (ASCII_CHAR_P): Move from here ...
14727 * lisp.h: ... to here, so that the inline functions mentioned
14728 above can use them.
14730 * dired.c (directory_files_internal_unwind): Now static.
14732 * fileio.c (file_name_as_directory, directory_file_name):
14733 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14735 (file_name_as_directory): Use const pointers when appropriate.
14736 (Fexpand_file_name): Likewise. In particular, newdir might
14737 point at constant storage, so make it a const pointer.
14738 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
14739 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14741 (Fset_file_times, Finsert_file_contents, auto_save_error):
14742 Rename locals to avoid shadowing.
14744 * minibuf.c (choose_minibuf_frame_1): Now static.
14745 (Ftry_completion, Fall_completions): Rename or remove locals
14746 to avoid shadowing.
14748 * marker.c (bytepos_to_charpos): Remove; unused.
14750 * lisp.h (verify_bytepos, count_markers): New decls,
14751 so that gcc does not warn that these functions aren't declared.
14753 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14754 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
14755 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
14756 (copy_text): Remove unused local var.
14758 * filelock.c (within_one_second): Now static.
14759 (lock_file_1): Rename local to avoid shadowing.
14761 * buffer.c (fix_overlays_before): Mark locals as initialized.
14762 (fix_start_end_in_overlays): Likewise. This function should be
14763 simplified by using pointers-to-pointers, but that's a different
14765 (switch_to_buffer_1): Now static.
14766 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14767 (report_overlay_modification): Rename locals to avoid shadowing.
14769 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
14770 Fix pointer signedness issue.
14771 (sys_subshell): Mark local as volatile if checking for lint,
14772 to suppress a gcc -Wclobbered warning that does not seem to be right.
14773 (MAXPATHLEN): Define only if needed.
14775 * process.c (serial_open, serial_configure): Move decls from here ...
14776 * systty.h: ... to here, so that they can be checked.
14778 * fns.c (get_random, seed_random): Move extern decls from here ...
14779 * lisp.h: ... to here, so that they can be checked.
14781 * sysdep.c (reset_io): Now static.
14782 (wait_for_termination_signal): Remove; unused.
14784 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14785 (copy_keymap_item, append_key, push_text_char_description):
14787 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
14788 (DENSE_TABLE_SIZE): Remove; unused.
14789 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14790 (describe_map_tree):
14791 Rename locals to avoid shadowing.
14793 * keyboard.c: Declare functions static if they are not used elsewhere.
14794 (echo_char, echo_dash, cmd_error, top_level_2):
14795 (poll_for_input, handle_async_input): Now static.
14796 (read_char, kbd_buffer_get_event, make_lispy_position):
14797 (make_lispy_event, make_lispy_movement, apply_modifiers):
14798 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14799 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14800 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
14801 (read_key_sequence, read_char): Mark locals as initialized.
14802 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
14804 * keyboard.h (make_ctrl_char): New decl.
14805 (mark_kboards): Move decl here ...
14806 * alloc.c (mark_kboards): ... from here.
14808 * lisp.h (force_auto_save_soon): New decl.
14810 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
14811 (DEFINE_DUMMY_FUNCTION): New macro.
14812 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14814 (main): Add casts to avoid warnings
14815 if GCC considers string literals to be constants.
14817 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14819 * dbusbind.c: Pointer signedness fixes.
14820 (xd_signature, xd_append_arg, xd_initialize):
14821 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14822 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14823 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14824 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14826 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14827 if GCC considers string literals to be constants.
14828 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
14830 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14832 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14833 (print_preprocess, print_object): New macro to fix last change.
14835 * print.c (print_preprocess): Don't forget font objects.
14837 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
14839 * emacs.c (USAGE3): Doc fixes.
14841 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14843 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14846 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
14848 * lisp.h (VWindow_system, Qfile_name_history):
14849 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14850 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14851 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14853 * w32select.c: Don't #include "keyboard.h".
14854 (run_protected): Add extern declaration for waiting_for_input.
14856 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14857 * w32console.c (detect_input_pending, read_input_pending)
14858 (encode_terminal_code):
14859 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14860 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14861 (w32_system_caret_y, Qfile_name_history):
14862 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14863 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14864 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14865 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14866 * w32proc.c (Qlocal, report_file_error):
14867 * w32term.c (Vwindow_system, updating_frame):
14868 * w32uniscribe.c (initialized, uniscribe_font_driver):
14869 Remove unneeded extern declarations.
14871 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
14873 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
14875 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
14877 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14878 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14879 These macros can no longer be used for assignment.
14881 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14882 Assign struct members directly, instead of using BUF_BEGV etc.
14883 (record_buffer_markers, fetch_buffer_markers): New functions for
14884 recording and fetching special buffer markers.
14885 (set_buffer_internal_1, set_buffer_temp): Use them.
14887 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14889 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14891 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14892 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14894 * xdisp.c (hscroll_window_tree):
14895 (reconsider_clip_changes): Use PT instead of BUF_PT.
14897 2011-03-13 Eli Zaretskii <eliz@gnu.org>
14899 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14900 $(EMACS_ROOT)/lib/intprops.h.
14902 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14904 Fix more problems found by GCC 4.5.2's static checks.
14906 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14907 to unsigned char * to avoid compiler diagnostic.
14908 (xg_free_frame_widgets): Make it clear that a local variable is
14909 needed only if USE_GTK_TOOLTIP.
14910 (gdk_window_get_screen): Make it clear that this macro is needed
14911 only if USE_GTK_TOOLTIP.
14912 (int_gtk_range_get_value): New function, which avoids a diagnostic
14913 from gcc -Wbad-function-cast.
14914 (xg_set_toolkit_scroll_bar_thumb): Use it.
14915 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14916 diagnostic from gcc -Wbad-function-cast.
14917 (get_utf8_string, xg_get_file_with_chooser):
14918 Rename locals to avoid shadowing.
14919 (create_dialog): Move locals to avoid shadowing.
14921 * xgselect.c (xg_select): Remove unused var.
14923 * image.c (four_corners_best): Mark locals as initialized.
14924 (gif_load): Initialize transparent_p to zero (Bug#8238).
14925 Mark another local as initialized.
14926 (my_png_error, my_error_exit): Mark with NO_RETURN.
14928 * image.c (clear_image_cache): Now static.
14929 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
14930 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
14931 (x_edge_detection): Remove unnecessary cast that
14932 gcc -Wbad-function-cast diagnoses.
14933 (gif_load): Fix pointer signedness.
14934 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14935 (jpeg_load, gif_load): Rename locals to avoid shadowing.
14937 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
14939 Improve quality of tests for time stamp overflow.
14940 For example, without this patch (encode-time 0 0 0 1 1
14941 1152921504606846976) returns the obviously-bogus value (-948597
14942 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14943 reports time overflow. See
14944 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
14945 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14946 * editfns.c: Include limits.h and intprops.h.
14947 (TIME_T_MIN, TIME_T_MAX): New macros.
14948 (time_overflow): Move earlier, to before first use.
14949 (hi_time, lo_time): New functions, for an accurate test for
14950 out-of-range times.
14951 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14952 (Fget_internal_run_time): Don't assume time_t fits in int.
14953 (make_time): Use list2 instead of Fcons twice.
14954 (Fdecode_time): More accurate test for out-of-range times.
14955 (check_tm_member): New function.
14956 (Fencode_time): Use it, to test for out-of-range times.
14957 (lisp_time_argument): Don't rely on undefined left-shift and
14958 right-shift behavior when checking for time stamp overflow.
14960 * editfns.c (time_overflow): New function, refactoring common code.
14961 (Fformat_time_string, Fdecode_time, Fencode_time):
14962 (Fcurrent_time_string): Use it.
14964 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14965 * dired.c (make_time): Move to ...
14966 * editfns.c (make_time): ... here.
14967 * systime.h: Note the move.
14969 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14971 * fringe.c (update_window_fringes): Remove unused variables.
14973 * unexmacosx.c (copy_data_segment): Also copy __got section.
14976 2011-03-12 Eli Zaretskii <eliz@gnu.org>
14978 * termcap.c [MSDOS]: Include "msdos.h".
14979 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14980 Constify `char *' arguments and their references according to
14981 prototypes in tparam.h.
14983 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
14985 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14986 Adapt all references accordingly.
14988 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14990 2011-03-11 Tom Tromey <tromey@redhat.com>
14992 * buffer.c (syms_of_buffer): Remove obsolete comment.
14994 2011-03-11 Eli Zaretskii <eliz@gnu.org>
14996 * termhooks.h (encode_terminal_code): Declare prototype.
14998 * msdos.c (encode_terminal_code): Don't declare prototype.
15000 * term.c (encode_terminal_code): Now external again, used by
15001 w32console.c and msdos.c.
15003 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
15004 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
15006 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
15008 Fix some minor problems found by GCC 4.5.2's static checks.
15010 * fringe.c (update_window_fringes): Mark locals as initialized
15012 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
15014 * alloc.c (mark_fringe_data): Move decl from here ...
15015 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
15016 to check its interface.
15017 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
15019 * fontset.c (free_realized_fontset): Now static.
15020 (Fset_fontset_font): Rename local to avoid shadowing.
15021 (fontset_font): Mark local as initialized.
15022 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
15024 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
15026 * xselect.c (x_disown_buffer_selections): Remove; not used.
15027 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
15028 (x_own_selection, Fx_disown_selection_internal): Rename locals
15029 to avoid shadowing.
15030 (x_handle_dnd_message): Remove local to avoid shadowing.
15032 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
15033 so that the caller can use some name other than gcpro1.
15034 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
15035 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
15036 (Fx_backspace_delete_keys_p):
15037 Use them to avoid shadowing, and rename vars to avoid shadowing.
15038 (x_decode_color, x_set_name, x_window): Now static.
15039 (Fx_create_frame): Add braces to silence GCC warning.
15040 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
15041 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
15042 Remove unused locals.
15043 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
15044 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
15045 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
15048 * xterm.h (x_mouse_leave): New decl.
15050 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
15051 Remove unused functions.
15052 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
15053 (x_calc_absolute_position): Now static.
15054 (XTread_socket): Don't define label "out" unless it's used.
15055 Don't declare local "event" unless it's used.
15056 (x_iconify_frame, x_free_frame_resources): Don't declare locals
15057 unless they are used.
15058 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
15059 (x_fatal_error_signal): Remove; not used.
15060 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
15061 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
15062 (x_error_catcher, x_connection_closed, x_error_handler):
15063 (x_error_quitter, xembed_send_message, x_iconify_frame):
15064 (my_log_handler): Rename locals to avoid shadowing.
15065 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
15066 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
15068 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
15069 Rename or move locals to avoid shadowing.
15070 (tty_defined_color, merge_face_heights): Now static.
15071 (free_realized_faces_for_fontset): Remove; not used.
15072 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
15073 does not deduce is never used uninitialized.
15074 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
15075 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
15077 * terminal.c (store_terminal_param): Now static.
15079 * xmenu.c (menu_highlight_callback): Now static.
15080 (set_frame_menubar): Remove unused local.
15081 (xmenu_show): Rename parameter to avoid shadowing.
15082 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
15083 since they might point to immutable storage.
15084 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
15085 since it's unused otherwise.
15087 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
15088 Add a FIXME, since the code still doesn't look right. (Bug#8215)
15089 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
15090 avoids a gcc -Wuninitialized diagnostic.
15091 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
15092 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
15093 does not deduce are never used uninitialized.
15095 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
15097 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
15098 * window.c (window_loop, size_window):
15099 (run_window_configuration_change_hook, enlarge_window): Likewise.
15101 * window.c (display_buffer): Now static.
15102 (size_window): Mark variables that gcc -Wuninitialized
15103 does not deduce are never used uninitialized.
15104 * window.h (check_all_windows): New decl, to forestall
15105 gcc -Wmissing-prototypes diagnostic.
15106 * dispextern.h (bidi_dump_cached_states): Likewise.
15108 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
15110 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
15111 Include <limits.h>.
15112 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
15113 and to avoid gcc -Wuninitialized warning.
15114 (load_charset_map): Mark variables that gcc -Wuninitialized
15115 does not deduce are never used uninitialized.
15116 (load_charset): Abort instead of using uninitialized var (Bug#8229).
15118 * coding.c (coding_set_source, coding_set_destination):
15119 Use "else { /* comment */ }" rather than "else /* comment */;"
15120 for clarity, and to avoid gcc -Wempty-body warning.
15121 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
15122 a block, when the outer 'i' will do.
15123 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
15124 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
15125 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
15126 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
15127 (Fdecode_sjis_char, Fdefine_coding_system_internal):
15128 Rename locals to avoid shadowing.
15129 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
15130 * coding.c (emacs_mule_char, encode_invocation_designation):
15131 Now static, since they're not used elsewhere.
15132 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
15133 (decode_coding_object, encode_coding_object, detect_coding_system):
15134 (decode_coding_emacs_mule): Mark variables that gcc
15135 -Wuninitialized does not deduce are never used uninitialized.
15136 (detect_coding_iso_2022): Initialize a local variable that might
15137 be used uninitialized. Leave a FIXME because it's not clear that
15138 this initialization is needed. (Bug#8211)
15139 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
15140 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
15141 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
15142 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
15143 Remove unused macros.
15145 * category.c (hash_get_category_set): Remove unused local var.
15146 (copy_category_table): Now static, since it's not used elsewhere.
15147 * character.c (string_count_byte8): Likewise.
15149 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
15150 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
15152 * chartab.c (copy_sub_char_table): Now static, since it's not used
15154 (sub_char_table_ref_and_range, char_table_ref_and_range):
15155 Rename locals to avoid shadowing.
15156 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
15158 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
15159 (BIDI_BOB): Remove unused macro.
15161 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
15162 deduce are never used uninitialized.
15163 * term.c (encode_terminal_code): Likewise.
15165 * term.c (encode_terminal_code): Now static. Remove unused local.
15167 * tparam.h: New file.
15168 * term.c, tparam.h: Include it.
15169 * deps.mk (term.o, tparam.o): Depend on tparam.h.
15170 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
15171 Move these decls to tparam.h, and make them agree with what
15172 is actually in tparam.c. The previous trick of using incompatible
15173 decls in different modules does not conform to the C standard.
15174 All callers of tparam changed to use tparam's actual API.
15175 * tparam.c (tparam1, tparam, tgoto):
15176 Use const pointers where appropriate.
15178 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
15179 * cm.h (struct cm): Likewise.
15180 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
15181 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
15182 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
15183 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
15184 (turn_on_face, init_tty): Likewise.
15185 * termchar.h (struct tty_display_info): Likewise.
15187 * term.c (term_mouse_position): Rename local to avoid shadowing.
15189 * alloc.c (mark_ttys): Move decl from here ...
15190 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
15192 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
15194 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
15196 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
15198 * search.c (compile_pattern_1): Remove argument regp, unused since
15199 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
15200 (compile_pattern): Don't pass it.
15202 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
15204 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
15205 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
15207 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
15209 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
15211 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
15212 gdk_window_get_screen, gdk_window_get_geometry,
15213 gdk_x11_window_lookup_for_display and GDK_KEY_g.
15214 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
15215 (xg_get_pixbuf_from_pixmap): New function.
15216 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
15217 to Pixmap, take frame as parameter, remove GdkColormap parameter.
15218 Call xg_get_pixbuf_from_pixmap instead of
15219 gdk_pixbuf_get_from_drawable.
15220 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
15221 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
15222 (xg_check_special_colors): Use GtkStyleContext and its functions
15224 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
15225 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
15226 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
15227 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
15228 Call gtk_widget_get_preferred_size.
15229 (xg_frame_resized): gdk_window_get_geometry only takes 5
15231 (xg_win_to_widget, xg_event_is_for_menubar):
15232 Call gdk_x11_window_lookup_for_display.
15233 (xg_set_widget_bg): New function.
15234 (delete_cb): New function.
15235 (xg_create_frame_widgets): Connect delete-event to delete_cb.
15236 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
15237 (xg_set_background_color): Call xg_set_widget_bg.
15238 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
15239 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
15240 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
15241 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
15243 (update_frame_tool_bar): Call gtk_widget_hide.
15244 (xg_initialize): Use GDK_KEY_g.
15246 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
15248 (x_session_initialize): Call gdk_x11_set_sm_client_id.
15250 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
15251 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
15252 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
15254 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
15256 * w32xfns.c (select_palette): Check success of RealizePalette against
15257 GDI_ERROR, not zero.
15259 See ChangeLog.11 for earlier changes.
15261 ;; Local Variables:
15265 Copyright (C) 2011-2012 Free Software Foundation, Inc.
15267 This file is part of GNU Emacs.
15269 GNU Emacs is free software: you can redistribute it and/or modify
15270 it under the terms of the GNU General Public License as published by
15271 the Free Software Foundation, either version 3 of the License, or
15272 (at your option) any later version.
15274 GNU Emacs is distributed in the hope that it will be useful,
15275 but WITHOUT ANY WARRANTY; without even the implied warranty of
15276 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15277 GNU General Public License for more details.
15279 You should have received a copy of the GNU General Public License
15280 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.
HCoop / bpt / emacs.git / blob