1 2012-07-19 Chong Yidong <cyd@gnu.org>
3 * window.c (Fwindow_absolute_pixel_edges)
4 (Fdelete_other_windows_internal): Signal an error if the window is
5 on a dead frame (Bug#11984).
7 2012-07-14 Eli Zaretskii <eliz@gnu.org>
9 Remove FILE_SYSTEM_CASE.
10 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
12 * fileio.c (FILE_SYSTEM_CASE): Don't define.
13 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
14 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
15 call-process-region passes it through expand-file-name.
17 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
19 2012-07-12 Andreas Schwab <schwab@linux-m68k.org>
21 Fix crash when creating indirect buffer (Bug#11917)
22 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
23 Don't handle unbound variables specially if non-zero.
24 (Fbuffer_local_variables): Pass zero.
25 (clone_per_buffer_values): Pass non-zero.
27 2012-06-28 Andreas Schwab <schwab@linux-m68k.org>
29 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
30 to make the loop interruptible.
32 2012-06-26 Andreas Schwab <schwab@linux-m68k.org>
34 * gnutls.c (emacs_gnutls_handshake): Only retry if
37 2012-06-23 Eli Zaretskii <eliz@gnu.org>
39 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
40 in the logic of incrementing and decrementing the value of
41 use_relocatable_buffers.
43 2012-06-21 Glenn Morris <rgm@gnu.org>
45 * charset.c (init_charset): Make lack of etc/charsets fatal.
47 2012-06-11 Jan Djärv <jan.h.d@swipnet.se>
49 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
50 referenced (Bug#11583).
52 2012-06-01 Chong Yidong <cyd@gnu.org>
54 * Version 24.1 released.
56 2012-05-30 Eli Zaretskii <eliz@gnu.org>
58 * xdisp.c (handle_stop): Detect whether we have overlay strings
59 loaded by testing it->current.overlay_string_index to be
60 non-negative, instead of checking whether n_overlay_strings is
63 2012-05-30 Chong Yidong <cyd@gnu.org>
65 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
67 * doc.c (Fsubstitute_command_keys): Doc fix.
69 2012-05-29 Eli Zaretskii <eliz@gnu.org>
71 * search.c (search_buffer): Remove calls to
72 r_alloc_inhibit_buffer_relocation, as it is now called by
73 maybe_unify_char, which was the cause of relocation of buffer text
76 2012-05-23 Eli Zaretskii <eliz@gnu.org>
78 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
79 for the duration of call to load_charset, to avoid problems with
80 callers of maybe_unify_char that access buffer text through C
83 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
84 decrement the inhibition flag, instead of just setting or
87 2012-05-24 Ken Brown <kbrown@cornell.edu>
89 * callproc.c (Fcall_process): Restore a line that was accidentally
90 commented out in the 2011-02-13 change (bug#11547).
92 2012-05-23 Eli Zaretskii <eliz@gnu.org>
94 * lisp.h [REL_ALLOC]: Add prototypes for external functions
97 * buffer.c [REL_ALLOC]: Remove prototypes of
98 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
99 they are now on lisp.h.
101 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
103 * search.c (search_buffer): Use it to inhibit relocation of buffer
104 text while re_search_2 is doing its job, because re_search_2 is
105 passed C pointers to buffer text. (Bug#11519)
107 2012-05-21 Eli Zaretskii <eliz@gnu.org>
109 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
112 2012-05-19 Eli Zaretskii <eliz@gnu.org>
114 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
115 state after an additional call to move_it_in_display_line_to, keep
116 the values of it->max_ascent and it->max_descent found for the
118 (pos_visible_p): Revert the comparison against bottom_y to what it
119 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
122 2012-05-15 Eli Zaretskii <eliz@gnu.org>
124 * xdisp.c (pos_visible_p): Fix last change. (Bug#11464)
126 2012-05-13 Eli Zaretskii <eliz@gnu.org>
128 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
129 already have overlays loaded.
130 (handle_single_display_spec): Before returning without displaying
131 fringe bitmap, synchronize the bidi iterator with the main display
132 iterator, by calling iterate_out_of_display_property.
133 (iterate_out_of_display_property): Detect buffer iteration by
134 testing that it->string is a Lisp string.
135 (get_next_display_element): When the current object is exhausted,
136 and there's something on it->stack, call set_iterator_to_next to
137 proceed with what's on the stack, instead of returning zero.
138 (set_iterator_to_next): If called at the end of a Lisp string,
139 proceed to consider_string_end without incrementing string
140 position. Don't increment display vector index past the end of
141 the display vector. (Bug#11417)
142 (pos_visible_p): Don't report a position visible when move_it_to
143 stopped at the last line of window, which happens to be scanned
144 backwards by the bidi iteration. (Bug#11464)
146 2012-05-11 Eli Zaretskii <eliz@gnu.org>
148 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
149 and right-margin display specs even if the spec is invalid or we
150 are on a TTY, and thus unable to display on the fringes. That's
151 because the text with the property will not be displayed anyway,
152 so we need to signal to the caller that this is a "replacing"
153 display spec. This fixes display when the spec is invalid or we
156 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
158 * unexaix.c (make_hdr): Fix typo in prototype.
159 This bug broke the build on AIX. Problem reported by Gilles Pion.
161 2012-05-05 Eli Zaretskii <eliz@gnu.org>
163 * w32proc.c (new_child): Force Windows to reserve only 64KB of
164 stack for each reader_thread, instead of defaulting to 8MB
165 determined by the linker. This avoids failures in creating
166 subprocesses on Windows 7, see the discussion in this thread:
167 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
169 2012-05-02 Jim Meyering <meyering@redhat.com>
171 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
173 2012-04-29 Eli Zaretskii <eliz@gnu.org>
175 * xdisp.c (pos_visible_p): If already at a newline from the
176 display string before the 'while' loop, don't walk back the glyphs
177 from it3.glyph_row. Solves assertion violation when the display
178 string begins with a newline (egg.el). (Bug#11367)
180 2012-04-24 Chong Yidong <cyd@gnu.org>
182 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
184 2012-04-23 Eli Zaretskii <eliz@gnu.org>
186 * xdisp.c (pos_visible_p): If the window start position is beyond
187 ZV, start the display from buffer beginning. Prevents assertion
188 violation in init_iterator when the minibuffer window is scrolled
191 * window.c (window_scroll_pixel_based): Likewise.
193 2012-04-23 Chong Yidong <cyd@gnu.org>
195 * keymap.c (where_is_internal): Doc fix (Bug#10872).
197 2012-04-20 Glenn Morris <rgm@gnu.org>
199 * fileio.c (Fcopy_file, Fset_file_selinux_context):
200 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
202 2012-04-20 Eli Zaretskii <eliz@gnu.org>
204 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers): Don't
205 overrun array limits of glyph row's used[] array. (Bug#11288)
207 2012-04-20 Chong Yidong <cyd@gnu.org>
209 * process.c (wait_reading_process_output): If EIO occurs on a pty,
210 set the status to "failed" and ensure that sentinel is run.
212 2012-04-18 Glenn Morris <rgm@gnu.org>
214 * process.c (Fset_process_inherit_coding_system_flag)
215 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
216 (Fmake_network_process, Fmake_serial_process): Doc fix.
218 2012-04-17 Eli Zaretskii <eliz@gnu.org>
220 * xdisp.c (string_buffer_position_lim): Limit starting position to
222 (set_cursor_from_row): If called for a mode-line or header-line
223 row, return zero immediately.
224 (try_cursor_movement): If inside continuation line, don't back up
225 farther than the first row after the header line, if any. Don't
226 consider the header-line row as "partially visible", even if
227 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
229 2012-04-13 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
231 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n" (bug#11238).
233 2012-04-10 Teodor Zlatanov <tzz@lifelogs.com>
235 * process.c (make_process):
236 * process.h: Add integer `gnutls_handshakes_tried' member to
239 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
240 Add convenience `GNUTLS_LOG2i' macro.
242 * gnutls.c (gnutls_log_function2i): Convenience log function.
243 (emacs_gnutls_read): Use new log functions,
244 `gnutls_handshakes_tried' process member, and
245 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
246 attempts per process (connection).
248 2012-04-09 Eli Zaretskii <eliz@gnu.org>
250 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
251 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
253 2012-04-09 Jan Djärv <jan.h.d@swipnet.se>
255 * nsterm.m (constrainFrameRect): Always constrain when there is only
256 one screen (Bug#10962).
258 2012-04-06 Eli Zaretskii <eliz@gnu.org>
260 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
261 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
262 about subtle differences between FETCH_CHAR* and STRING_CHAR*
263 macros related to unification of CJK characters. For the details,
264 see the discussion following the message here:
265 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
267 2012-04-04 Chong Yidong <cyd@gnu.org>
269 * keyboard.c (Vdelayed_warnings_list): Doc fix.
271 2012-04-01 Eli Zaretskii <eliz@gnu.org>
273 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
274 instead of alloca. (Bug#11138)
276 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
278 * w32menu.c (is_simple_dialog): Properly check lisp types.
281 2012-03-31 Eli Zaretskii <eliz@gnu.org>
283 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
284 position we get to after a call to move_it_to fails the
285 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
286 only if we wind up in a string from display property. (Bug#11063)
288 * window.c (Fdelete_other_windows_internal): Invalidate the row
289 and column information about mouse highlight, so that redisplay
290 restores it after reallocating the glyph matrices. (Bug#7464)
292 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
293 string comes from a `display' text property, use the buffer
294 position of that property as if we actually saw that position in
296 (move_it_by_lines): Remove the assertion that
297 "it->current_x == 0 && it->hpos == 0" which can be legitimately
298 violated when there's a before-string at the beginning of a line.
301 2012-03-30 Eli Zaretskii <eliz@gnu.org>
303 * xdisp.c (append_space_for_newline): If the default face was
304 remapped, use the remapped face for the appended newline.
305 (extend_face_to_end_of_line): Use the remapped default face for
306 extending the face to the end of the line.
307 (display_line): Call extend_face_to_end_of_line when the default
308 face was remapped. (Bug#11068)
310 2012-03-29 Eli Zaretskii <eliz@gnu.org>
312 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
314 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
316 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
318 2012-03-27 Glenn Morris <rgm@gnu.org>
320 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
323 2012-03-26 Kenichi Handa <handa@m17n.org>
325 * dispextern.h (struct glyph): Fix previous change. Change the
326 bit length of glyphless.ch to 25 (Bug#11082).
328 2012-03-26 Chong Yidong <cyd@gnu.org>
330 * keyboard.c (Vselection_inhibit_update_commands): New variable.
331 (command_loop_1): Use it; inhibit selection update for
332 handle-select-window too (Bug#8996).
334 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
336 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
338 2012-03-25 Kenichi Handa <handa@m17n.org>
340 * dispextern.h (struct glyph): Change the bit length of
341 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
343 2012-03-24 Eli Zaretskii <eliz@gnu.org>
345 * s/ms-w32.h (tzname): Include time.h before redirecting to
346 _tzname. Fixes the MSVC build. (Bug#9960)
348 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
350 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
353 * xterm.c (XTread_socket): Only modify handling_signal if
354 !SYNC_INPUT. (Bug#11080)
356 2012-03-23 Eli Zaretskii <eliz@gnu.org>
358 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
359 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
360 when fetching a multibyte character consumes more bytes than
361 CHAR_BYTES returns, due to unification of CJK characters in
362 string_char. (Bug#11073)
364 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
366 * process.c (wait_reading_process_output): Handle pty disconnect
367 by refraining from sending oneself a SIGCHLD (bug#10933).
369 2012-03-22 Chong Yidong <cyd@gnu.org>
371 * dispextern.h (struct it): New member string_from_prefix_prop_p.
373 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
374 Mark string as coming from a prefix property.
375 (handle_face_prop): Use default face for prefix strings (Bug#4281).
376 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
378 2012-03-21 Chong Yidong <cyd@gnu.org>
380 * xfaces.c (Vface_remapping_alist): Doc fix.
382 2012-03-20 Eli Zaretskii <eliz@gnu.org>
384 * w32proc.c (Fw32_set_console_codepage)
385 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
388 2012-03-20 Chong Yidong <cyd@gnu.org>
390 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
391 to reflect default non-nil value of redisplay-dont-pause.
393 2012-03-19 Kenichi Handa <handa@m17n.org>
395 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
396 it fit in a valid range (Bug#11003).
398 2012-03-18 Eli Zaretskii <eliz@gnu.org>
400 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
401 that is not from display property, accept the row as a "cursor
402 row" if one of the string's character has a non-nil `cursor'
403 property. Fixes cursor positioning when there are newlines in
404 overlay strings, e.g. in icomplete.el. (Bug#11035)
406 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
408 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
410 2012-03-12 Chong Yidong <cyd@gnu.org>
412 * eval.c (inhibit_lisp_code): Rename from
413 inhibit_window_configuration_change_hook; move from window.c.
415 * xfns.c (unwind_create_frame_1, Fx_create_frame):
416 * window.c (run_window_configuration_change_hook)
417 (syms_of_window): Callers changed.
419 2012-03-11 Chong Yidong <cyd@gnu.org>
421 * keymap.c (Fkey_description): Doc fix (Bug#9700).
423 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
425 2012-03-10 Chong Yidong <cyd@gnu.org>
427 * frame.c (other_visible_frames): Don't assume the selected frame
428 is visible (Bug#10955).
430 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
432 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
434 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
436 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
437 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
440 2012-03-03 Glenn Morris <rgm@gnu.org>
442 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
444 2012-03-02 Eli Zaretskii <eliz@gnu.org>
446 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
447 position past the first glyph_row that ends at ZV. (Bug#10902)
448 (redisplay_window, next_element_from_string): Fix typos in
450 (redisplay_window): Pass to move_it_vertically the margin in
451 pixels, not in screen lines.
453 2012-03-02 Glenn Morris <rgm@gnu.org>
455 * buffer.c (buffer-list-update-hook): Doc fix.
457 2012-02-29 Eli Zaretskii <eliz@gnu.org>
459 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
460 push_it before setting up the iterator for the first overlay
461 string, even if we have an empty string loaded.
462 (next_overlay_string): If there's an empty string on the iterator
463 stack, pop the stack. (Bug#10903)
465 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
467 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
468 Suggested by Stefan Monnier in
469 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
470 * alloc.c (widen_to_Lisp_Object): New static function.
471 (mark_memory): Also mark Lisp_Objects by fetching pointer words
472 and widening them to Lisp_Objects. This would work even if
473 USE_LSB_TAG is defined and wide integers are used, which might
474 happen in a future version of Emacs.
476 2012-02-25 Chong Yidong <cyd@gnu.org>
478 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
481 * xselect.c (Fx_selection_exists_p): Doc fix.
482 (x_clipboard_manager_save_all): Print an informative message
483 before saving to clipboard manager.
485 2012-02-24 Chong Yidong <cyd@gnu.org>
487 * keyboard.c (process_special_events): Handle all X selection
488 requests in kbd_buffer, not just the next one (Bug#8869).
490 2012-02-23 Chong Yidong <cyd@gnu.org>
492 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
493 call when setting menu-bar-lines and tool-bar-lines parameters.
494 (unwind_create_frame_1): New helper function.
496 * window.c (inhibit_window_configuration_change_hook): New var.
497 (run_window_configuration_change_hook): Obey it.
498 (syms_of_window): Initialize it.
500 2012-02-22 Chong Yidong <cyd@gnu.org>
502 * xterm.c (x_draw_image_relief): Add missing type check for
503 Vtool_bar_button_margin (Bug#10743).
505 2012-02-21 Chong Yidong <cyd@gnu.org>
507 * fileio.c (Vfile_name_handler_alist): Doc fix.
509 * buffer.c (Fget_file_buffer): Protect against invalid file
510 handler return value.
512 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
514 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
515 when computing $valmask.
517 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
518 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
519 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
520 It's useless in that case, and it can cause problems on hosts
521 that allocate halves of EMACS_INT values separately.
522 Reported by Dan Horák. Diagnosed by Andreas Schwab in
523 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
524 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
525 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
526 it avoids undefined behavior on hosts where shifting right by more
527 than the word width has undefined behavior.
529 2012-02-19 Chong Yidong <cyd@gnu.org>
531 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
532 (Funhandled_file_name_directory, Ffile_name_as_directory)
533 (Fdirectory_file_name, Fexpand_file_name)
534 (Fsubstitute_in_file_name): Protect against invalid file handler
535 return values (Bug#10845).
537 2012-02-18 Eli Zaretskii <eliz@gnu.org>
539 * .gdbinit (pitx): Fix incorrect references to fields of the
542 2012-02-17 Chong Yidong <cyd@gnu.org>
544 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
546 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
548 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
549 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
551 2012-02-15 Chong Yidong <cyd@gnu.org>
553 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
554 marked as special. Also, starting docstrings with * is obsolete.
556 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
558 * gnutls.c (emacs_gnutls_write): Fix last change.
560 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
562 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
565 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
567 * keymap.c (Fsingle_key_description): Handle char ranges.
569 2012-02-12 Chong Yidong <cyd@gnu.org>
571 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
572 as that creates a dangerous corner case.
574 * window.c (Fdelete_window_internal): Invalidate the mouse
575 highlight (Bug#9904).
577 2012-02-12 Glenn Morris <rgm@gnu.org>
579 * xselect.c (Fx_own_selection_internal)
580 (Fx_get_selection_internal, Fx_disown_selection_internal)
581 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
582 * nsselect.m (Fx_own_selection_internal)
583 (Fx_disown_selection_internal, Fx_selection_exists_p)
584 (Fx_selection_owner_p, Fx_get_selection_internal):
585 Sync docs and argument specs with the xselect.c versions.
587 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
589 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
591 2012-02-11 Eli Zaretskii <eliz@gnu.org>
593 * w32select.c (Fx_selection_exists_p): Sync doc string and
594 argument list with xselect.c. (Bug#10783)
596 * w16select.c (Fx_selection_exists_p): Sync doc string and
597 argument list with xselect.c. (Bug#10783)
599 2012-02-10 Glenn Morris <rgm@gnu.org>
601 * fns.c (Fsecure_hash): Doc fix.
603 2012-02-09 Kenichi Handa <handa@m17n.org>
605 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
607 2012-02-07 Chong Yidong <cyd@gnu.org>
609 * buffer.c (Fbuffer_local_variables)
610 (buffer_lisp_local_variables): Handle unbound vars correctly;
611 don't let Qunbound leak into Lisp.
613 2012-02-07 Glenn Morris <rgm@gnu.org>
615 * image.c (Fimagemagick_types): Doc fix.
617 * image.c (imagemagick-render-type): Change it from a lisp object
618 to an integer. Move the doc here from the lisp manual.
619 Treat all values not equal to 0 the same.
621 2012-02-06 Chong Yidong <cyd@gnu.org>
623 * doc.c (store_function_docstring): Avoid applying docstring of
624 alias to base function (Bug#2603).
626 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
628 * .gdbinit (pp1, pv1): Remove redundant defines.
631 2012-02-04 Chong Yidong <cyd@gnu.org>
633 * nsterm.m: Declare a global (Bug#10694).
635 2012-02-04 Eli Zaretskii <eliz@gnu.org>
637 * w32.c (get_emacs_configuration_options):
638 Include --enable-checking, if specified, in the return value.
640 2012-02-04 Martin Rudalics <rudalics@gmx.at>
642 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
643 after rounding frame sizes. (Bug#9723)
645 2012-02-04 Eli Zaretskii <eliz@gnu.org>
647 * keyboard.c (adjust_point_for_property): Don't position point
648 before BEGV. (Bug#10696)
650 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
652 Handle overflow when computing char display width (Bug#9496).
653 * character.c (char_width): Return EMACS_INT, not int.
654 (char_width, c_string_width): Check for overflow when
655 computing the width; this is possible now that individual
656 characters can have unbounded width. Problem introduced
657 by merge from Emacs 23 on 2012-01-19.
659 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
661 * dbusbind.c (Fdbus_register_method): Mention the return value
662 :ignore in the docstring.
664 2012-02-02 Glenn Morris <rgm@gnu.org>
666 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
668 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
669 Unconditionally set to t. (Bug#10673)
670 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
671 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
672 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
674 2012-02-02 Kenichi Handa <handa@m17n.org>
676 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
677 0, do not call append_composite_glyph.
679 2012-02-02 Kenichi Handa <handa@m17n.org>
681 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
683 (x_produce_glyphs): If the component of a composition is a null
684 string, set it->pixel_width to 1 to avoid zero-width glyph.
686 2012-02-01 Eli Zaretskii <eliz@gnu.org>
688 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
689 first 2 arguments are identical. This makes inserting large
690 output from a subprocess an order of magnitude faster on
691 MS-Windows, where all sbrk'ed memory is always contiguous.
693 2012-01-31 Glenn Morris <rgm@gnu.org>
695 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
696 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
697 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
699 2012-01-29 Glenn Morris <rgm@gnu.org>
701 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
703 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
705 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
707 2012-01-28 Chong Yidong <cyd@gnu.org>
709 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
711 2012-01-26 Chong Yidong <cyd@gnu.org>
713 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
715 * search.c (Fsearch_forward, Fsearch_backward): Document negative
716 repeat counts (Bug#10507).
718 2012-01-26 Glenn Morris <rgm@gnu.org>
720 * lread.c (syms_of_lread): Doc fix.
722 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
724 * coding.c (encode_designation_at_bol): Change return value to
727 2012-01-25 Chong Yidong <cyd@gnu.org>
729 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
731 2012-01-21 Chong Yidong <cyd@gnu.org>
733 * floatfns.c (Fcopysign): Make the second argument non-optional,
734 since nil is not allowed anyway.
736 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
738 * process.c (read_process_output): Use p instead of XPROCESS (proc).
739 (send_process): Likewise.
741 2012-01-19 Martin Rudalics <rudalics@gmx.at>
743 * window.c (save_window_save, Fcurrent_window_configuration)
744 (Vwindow_persistent_parameters): Do not use Qstate.
747 2012-01-19 Kenichi Handa <handa@m17n.org>
749 * character.c (char_width): New function.
750 (Fchar_width, c_string_width, lisp_string_width):
751 Use char_width (Bug#9496).
753 2012-01-16 Martin Rudalics <rudalics@gmx.at>
755 * window.c (Vwindow_persistent_parameters): New variable.
756 (Fset_window_configuration, save_window_save): Handle persistent
759 2012-01-14 Eli Zaretskii <eliz@gnu.org>
761 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
762 thrashing the stack of the thread. (Bug#9087)
764 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
766 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
768 2012-01-11 Eli Zaretskii <eliz@gnu.org>
770 * xdisp.c (rows_from_pos_range): Handle the case where the
771 highlight ends on a newline. (Bug#10464)
772 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
773 he end column for display of highlight that ends on a newline
776 2012-01-11 Glenn Morris <rgm@gnu.org>
778 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
779 from load-path also when installation-directory is nil. (Bug#10208)
781 2012-01-10 Glenn Morris <rgm@gnu.org>
783 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
785 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
786 Update template values to be closer to their typical values these days.
788 2012-01-09 Eli Zaretskii <eliz@gnu.org>
790 * xdisp.c (rows_from_pos_range): Accept additional argument
791 DISP_STRING, and accept any glyph in a row whose object is that
792 string as eligible for mouse highlight. Fixes mouse highlight of
793 display strings from overlays. (Bug#10464)
795 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
797 emacs: fix an auto-save permissions race condition (Bug#10400)
798 * fileio.c (auto_saving_dir_umask): New static var.
799 (Fmake_directory_internal): Use it.
800 (do_auto_save_make_dir): Set it, instead of invoking chmod after
801 creating the directory. The old code temporarily assigns
802 too-generous permissions to the directory.
803 (do_auto_save_eh): Clear it.
804 (Fdo_auto_save): Catch all errors, not just file errors, so
805 that the var is always cleared.
807 2012-01-07 Eli Zaretskii <eliz@gnu.org>
809 * search.c (scan_buffer): Pass character positions to
810 know_region_cache, not byte positions. (Bug#6540)
812 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
814 * w32.c (sys_rename): Report EXDEV when rename of a directory
815 fails because the target is on another logical disk. (Bug#10284)
817 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
819 * xterm.c (x_embed_request_focus): New function.
821 * xterm.h: Add prototype.
823 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
825 2012-01-05 Glenn Morris <rgm@gnu.org>
827 * emacs.c (emacs_copyright): Update short copyright year to 2012.
829 2012-01-01 Eli Zaretskii <eliz@gnu.org>
831 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
832 Load gnutls_transport_set_lowat only if GnuTLS version is below
834 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
835 GnuTLS versions below 2.11.1.
837 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
839 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
840 to the doc string advising against its use for altering the way
841 windows are scrolled.
843 2011-12-28 Kenichi Handa <handa@m17n.org>
845 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
846 coding-system ASCII compatible only when it does not produce BOM
847 on encoding (Bug#10383).
849 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
851 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
853 (create_and_show_popup_menu): Always use menu_position_func for
856 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
858 * callint.c (Fcall_interactively): Don't truncate prompt string.
860 2011-12-23 Eli Zaretskii <eliz@gnu.org>
862 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
863 property that ends at ZV, so that the bidi iteration could be
864 resumed from there (after widening). (Bug#10360)
866 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
868 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
870 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
872 * nsterm.m (x_free_frame_resources):
873 Release f->output_data.ns->miniimage.
874 (ns_index_color): Fix indentation. Do not retain
875 color_table->colors[i].
877 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
880 * nsfns.m (x_set_background_color): Assign return value from
881 ns_index_color to face-background instead of NSColor*.
882 (ns_implicitly_set_icon_type): Fix indentation.
883 Change assignment in for loop to comparison.
885 * emacs.c (ns_pool): New variable.
886 (main): Assign ns_pool.
887 (Fkill_emacs): Call ns_release_autorelease_pool.
889 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
890 autorelease fdesc, release fdAttrs and tdict.
891 (ns_get_covering_families): Release charset.
892 (ns_findfonts): Release NSFontDescriptor created with new.
893 (ns_uni_to_glyphs): Fix indentation.
894 (setString): Release attrStr before assigning new value.
896 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
898 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
900 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
901 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
903 2011-12-18 David Reitter <reitter@cmu.edu>
905 * nsterm.m (ns_term_init): Subscribe for notifications
906 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
907 to method trackingNotification in EmacsMenu.
909 * nsmenu.m (trackingMenu): New variable.
910 (trackingNotification): New method (from Aquamacs).
911 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
912 from Aquamacs (Bug#7030).
914 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
916 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
917 (symbol_to_nsstring): Fix indentation.
918 (ns_symbol_to_pb): New function.
919 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
920 (Fns_rotate_cut_buffers_internal): Remove.
921 (Fns_store_selection_internal): Rename from
922 Fns_store_cut_buffer_internal.
923 (ns_get_foreign_selection, Fx_own_selection_internal)
924 (Fx_disown_selection_internal, Fx_selection_exists_p)
925 (Fns_get_selection_internal, Fns_store_selection_internal):
926 Use ns_symbol_to_pb and check if return value is nil.
927 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
928 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
929 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
930 renamed to Sns_store_selection_internal.
931 (ns_handle_selection_request): Move code to Fx_own_selection_internal
932 and remove this function.
933 (ns_handle_selection_clear): Remove, never used.
934 (Fx_own_selection_internal): Move code from ns_handle_selection_request
937 2011-12-17 Ken Brown <kbrown@cornell.edu>
939 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
940 GID is unknown (Bug#10257).
942 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
944 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
945 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
946 which caused a build failure on GNU/Linux IA-64. This problem was
947 introduced by my 2011-10-07 patch.
949 2011-12-15 Juri Linkov <juri@jurta.org>
951 * image.c (imagemagick_error): New function. (Bug#10112)
952 (imagemagick_load_image): Comment out `MagickSetResolution' call.
953 Use `imagemagick_error' where ImageMagick functions return
955 (Fimagemagick_types): Add `Fnreverse' to return the list in the
958 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
960 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
961 fill background (Bug#8992).
963 2011-12-13 Martin Rudalics <rudalics@gmx.at>
965 * window.c (Vwindow_combination_resize)
966 (Vwindow_combination_limit): Use t instead of non-nil in
968 (Vrecenter_redisplay): Add first sentence of doc-string on
970 (Frecenter): Fix doc-string typo.
972 2011-12-11 Kenichi Handa <handa@m17n.org>
974 * coding.c (Funencodable_char_position): Pay attention to the
975 buffer text relocation (Bug#9389).
977 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
979 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
980 gtk_init (Bug#10100).
982 2011-12-10 Eli Zaretskii <eliz@gnu.org>
984 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
985 IT->string is nil. (Bug#10263)
987 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
989 * nsterm.h (x_free_frame_resources): Declare.
991 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
992 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
994 * nsterm.h (ns_get_defaults_value): Declare.
996 * nsterm.m (ns_default): Call ns_get_defaults_value.
998 2011-12-09 Eli Zaretskii <eliz@gnu.org>
1000 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1003 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1005 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1006 that where the value of an _OBJC_* symbol points to is in the .bss
1007 section (Bug#10240).
1009 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1011 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
1012 after the loop to call ccl_driver at least once (Bug#8619).
1014 2011-12-08 Kenichi Handa <handa@m17n.org>
1016 * ftfont.c (get_adstyle_property): Fix previous change
1019 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
1021 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1022 dirs from the default value of EMACSLOADPATH (bug#10208).
1024 2011-12-07 Glenn Morris <rgm@gnu.org>
1026 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1027 installation and source directories as well. (Bug#10208)
1029 2011-12-06 Chong Yidong <cyd@gnu.org>
1031 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1033 2011-12-06 Glenn Morris <rgm@gnu.org>
1035 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1036 as an error, not just -1. (Bug#10217)
1038 2011-12-05 Chong Yidong <cyd@gnu.org>
1040 * keyboard.c (process_special_events): New function.
1041 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1043 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1045 * coding.c (encode_designation_at_bol): Don't use uninitialized
1046 local variable (Bug#9318).
1048 2011-12-05 Kenichi Handa <handa@m17n.org>
1050 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1051 return Qnil (Bug#8046, Bug#10193).
1053 2011-12-05 Kenichi Handa <handa@m17n.org>
1055 * coding.c (encode_designation_at_bol): New args charbuf_end and
1056 dst. Return the number of produced bytes. Callers changed.
1057 (coding_set_source): Return how many bytes coding->source was
1059 (coding_set_destination): Return how many bytes
1060 coding->destination was relocated.
1061 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1062 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1064 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1066 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1067 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1070 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1072 The following changes are to fix Bug#9318.
1074 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1075 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1076 (encode_coding_iso_2022, encode_coding_sjis)
1077 (encode_coding_big5, encode_coding_charset): Use the above macros.
1079 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1081 * lisp.h (process_quit_flag): Fix external declaration.
1083 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1085 Don't macro-inline non-performance-critical code.
1086 * eval.c (process_quit_flag): New function.
1087 * lisp.h (QUIT): Use it.
1089 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1091 * nsfns.m (get_geometry_from_preferences): New function.
1092 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1094 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1096 * emacs.c (Qkill_emacs): Define.
1097 (syms_of_emacs): Initialize it.
1098 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1099 Qquit_flag to `kill-emacs' instead.
1100 (quit_throw_to_read_char): Add parameter `from_signal'.
1101 All callers changed. Call Fkill_emacs if requested and safe.
1102 * lisp.h (QUIT): Call Fkill_emacs if requested.
1104 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1106 * widget.c (update_wm_hints): Return if wmshell is null.
1107 (widget_update_wm_size_hints): New function.
1109 * widget.h (widget_update_wm_size_hints): Declare.
1111 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1112 widget_update_wm_size_hints (Bug#10104).
1114 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1116 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1117 before a newline, prepare the bidi iterator for consuming the
1118 newline, and keep the current paragraph direction. (Bug#10183)
1119 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1121 2011-12-02 Juri Linkov <juri@jurta.org>
1123 * search.c (Fword_search_regexp): New Lisp function created from
1124 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1125 (Fword_search_backward, Fword_search_forward)
1126 (Fword_search_backward_lax, Fword_search_forward_lax):
1127 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1128 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1130 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1132 * fileio.c (Finsert_file_contents): Move after-change-function call
1133 to before the "handled:" label, since all "goto handled" appear in
1134 cases where the *-change-functions have already been properly called
1137 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1139 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1140 waiting for input. (Bug#10169)
1142 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1144 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1145 verifies glyph row's hash code--we have just reallocated the
1146 glyphs, so their contents can be complete garbage. (Bug#10164)
1148 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1150 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1152 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1154 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1155 attributes are tested _before_ calling verify_row_hash, to protect
1156 against GCC re-ordering of the tests. (Bug#10164)
1158 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1160 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1162 * xterm.c (handle_one_xevent): Only set async_visible and friends
1163 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1164 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1165 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1167 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1169 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1170 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1171 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1172 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1173 All uses changed to use GCPRO1 etc.
1174 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1175 Revert to old implementation (i.e., before 2011-03-11).
1177 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1179 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1180 of scroll runs so as to avoid assigning disabled bogus rows and
1181 unnecessary graphics copy operations.
1183 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1185 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1186 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1187 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1188 (malloc, free, realloc, calloc): Redirect to e_* only when
1191 * lisp.h (GCTYPEBITS): Move before first use.
1192 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1193 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1194 this macro definition.
1196 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1199 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1201 * gtkutil.c (xg_create_frame_widgets):
1202 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1203 present with Gtk+ 2.0.
1205 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1207 * fileio.c (Finsert_file_contents): Undo previous change; see
1208 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1210 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1212 Rename locals to avoid shadowing.
1213 * fileio.c (Finsert_file_contents):
1214 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1215 * process.c (wait_reading_process_output):
1216 Rename inner 'proc' to 'p' to avoid shadowing.
1217 Indent for consistency with usual Emacs style.
1219 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1221 * xdisp.c (redisplay_window): If cursor row is not fully visible
1222 after recentering, and scroll-conservatively is set to a large
1223 number, scroll window by a few more lines to make the cursor fully
1224 visible and out of scroll-margin. (Bug#10105)
1225 (start_display): Don't move to the next line if the display should
1226 start at a newline that is part of a display vector or an overlay
1229 2011-11-24 Juri Linkov <juri@jurta.org>
1231 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1232 after the `MagickPingImage' call. (Bug#10112)
1234 2011-11-23 Chong Yidong <cyd@gnu.org>
1236 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1238 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1240 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1241 making another buffer current. (Bug#10114)
1243 2011-11-23 Glenn Morris <rgm@gnu.org>
1245 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1247 2011-11-23 Chong Yidong <cyd@gnu.org>
1249 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1250 using it (Bug#5984).
1252 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1254 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1255 and header-lines, as they don't have one computed for them.
1258 * .gdbinit (prow): Make displayed values more self-explaining.
1259 Add row's hash code.
1261 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1263 * process.c (wait_reading_process_output): Fix asynchrounous
1264 GnuTLS socket handling on some versions of the GnuTLS library.
1265 (wait_reading_process_output): Add comment and URL.
1267 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1269 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1271 2011-11-21 Chong Yidong <cyd@gnu.org>
1273 * window.c (Fnext_window, Fprevious_window): Doc fix.
1275 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1277 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1279 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1281 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1283 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1285 * window.c (Fset_window_combination_limit): Rename argument
1287 (Vwindow_combination_limit): Remove "status" from doc-string.
1289 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1291 * m/ibms390.h: Remove.
1292 * m/ibms390x.h: Don't include "ibms390.h".
1294 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1296 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1297 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1299 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1301 * casetab.c (Fset_case_table):
1302 * charset.c (Fcharset_after): Fix typos.
1304 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1306 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1307 Otherwise, valgrind does not work on some platforms.
1308 Problem reported by Andreas Schwab in
1309 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1310 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1311 is set, removing the need for VIRT_ADDRESS_VARIES.
1312 (PURE_P): Use a more-efficient implementation that needs just one
1313 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1314 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1315 to 4 (xorl, subq, cmpq, setbe).
1316 * alloc.c (pure): Always extern now, since that's the
1317 VIRT_ADDR_VARIES behavior.
1318 (PURE_POINTER_P): Use a single comparison, not two, for
1319 consistency with the new puresize.h.
1320 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1321 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1322 Remove VIRT_ADDR_VARIES no longer needed.
1324 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1326 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1327 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1328 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1329 behave as if the cursor position were at the window margin.
1331 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1332 and the cursor position is out of bounds, behave as if the cursor
1333 position were at the window margin. (Bug#10075)
1335 2011-11-18 Chong Yidong <cyd@gnu.org>
1337 * window.c (Fwindow_combination_limit): Make first argument
1338 non-optional, since it is meaningless for live windows like the
1341 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1343 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1345 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1347 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1348 (graft_intervals_into_buffer): Simplify.
1350 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1352 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1353 hash values of the two rows.
1354 (copy_row_except_pointers): Preserve the used[] arrays and the
1355 hash values of the two rows. (Bug#10035)
1356 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1358 * xdisp.c (row_hash): New function, body extracted from
1359 compute_line_metrics.
1360 (compute_line_metrics): Call row_hash, instead of computing the
1363 * dispnew.c (verify_row_hash): Call row_hash for computing the
1364 hash code of a row, instead of duplicating code from xdisp.c.
1366 * dispextern.h (row_hash): Add prototype.
1368 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1370 * frame.c (delete_frame): Don't delete the terminal when the last
1371 X frame is closed if emacs is built with GTK toolkit.
1373 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1375 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1377 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1379 * window.c (Vwindow_splits): Rename to
1380 Vwindow_combination_resize. Suggested by Juri Linkov.
1381 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1384 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1386 * nsfns.m (Fns_font_name):
1387 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1389 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1391 * window.h (window): Rename slot "nest" to "combination_limit".
1392 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1393 (Fset_window_nest): Rename to Fset_window_combination_limit.
1394 (Vwindow_nest): Rename to Vwindow_combination_limit.
1395 (recombine_windows, make_parent_window, make_window)
1396 (Fsplit_window_internal, saved_window)
1397 (Fset_window_configuration, save_window_save): Rename all
1398 occurrences of window_nest to window_combination_limit.
1400 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1402 * image.c (imagemagick_load_image): Fix typo.
1404 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1406 * xdisp.c (display_line): Move the call to
1407 highlight_trailing_whitespace before the call to
1408 compute_line_metrics, since the latter needs to see the final
1409 faces of all the glyphs to compute ROW's hash value.
1410 Fixes assertion violations in row_equal_p. (Bug#10035)
1412 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1414 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1415 just return (bug#10044).
1417 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1419 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1420 with user-defined heap size. Bump the default size of the temacs
1421 heap to 27MB, to avoid memory warning when running temacs.
1422 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1424 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1425 current_matrix and desired_matrix. (Bug#9990)
1426 (verify_row_hash) [XASSERTS]: New function.
1427 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1428 that the hash value of glyph rows is correct.
1430 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1432 * window.h (window): Remove splits slot.
1433 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1434 (Fdelete_other_windows_internal, make_parent_window)
1435 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1436 (Fset_window_configuration, save_window_save): Don't deal with
1437 split status of windows.
1438 (saved_window): Remove splits slot.
1439 (Vwindow_splits): Rewrite doc-string.
1441 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1443 * xfns.c (unwind_create_frame):
1444 * nsfns.m (unwind_create_frame):
1445 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1446 Vframe_list (Bug#9999).
1448 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1450 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1452 2011-11-11 Kenichi Handa <handa@m17n.org>
1454 * callproc.c (Fcall_process): Set the member dst_multibyte of
1457 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1459 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1460 avoid a crash (bug#9496).
1462 2011-11-09 Chong Yidong <cyd@gnu.org>
1464 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1465 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1467 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1469 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1471 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1473 Avoid some portability problems by eschewing 'extern inline' functions.
1474 The trivial performance wins aren't worth the portability hassles; see
1475 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1477 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1478 (window_box_width, window_box_left, window_box_left_offset)
1479 (window_box_right, window_box_right_offset): Undo previous change,
1480 by removing the "extern"s.
1481 * intervals.c (adjust_intervals_for_insertion)
1482 (adjust_intervals_for_deletion): Undo previous change,
1483 making these static again.
1484 (offset_intervals, temp_set_point_both, temp_set_point)
1485 (copy_intervals_to_string): No longer inline.
1486 * xdisp.c (window_text_bottom_y, window_box_width)
1487 (window_box_height, window_box_left_offset)
1488 (window_box_right_offset, window_box_left, window_box_right)
1489 (window_box): No longer inline.
1491 2011-11-08 Chong Yidong <cyd@gnu.org>
1493 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1494 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1495 Signal an error if not a live window.
1496 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1497 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1499 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1501 * lisp.h (syms_of_abbrev): Remove declaration.
1502 Reported by CHENG Gao <chenggao@royau.me>.
1504 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1506 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1507 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1508 of temacs in GUI mode.
1510 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1512 * window.h: Declare delete_all_child_windows instead of
1513 delete_all_subwindows.
1514 * window.c (Fwindow_nest, Fset_window_nest)
1515 (Fset_window_new_total, Fset_window_new_normal)
1516 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1517 (delete_all_subwindows): Rename to delete_all_child_windows.
1518 (Fdelete_other_windows_internal, Fset_window_configuration):
1519 Call delete_all_child_windows instead of delete_all_subwindows.
1520 * frame.c (delete_frame): Call delete_all_child_windows instead
1521 of delete_all_subwindows.
1523 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1525 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1526 This is also needed for porting to any host where GC_MARK_STACK is
1527 not GC_MAKE_GCPROS_NOOPS.
1528 (which_symbols): Use it.
1530 2011-11-07 Kenichi Handa <handa@m17n.org>
1532 * coding.c (coding_set_destination): Check coding->src_pos only
1533 when coding->src_object is a buffer (bug#9910).
1535 * process.c (send_process): Set the member src_multibyte of coding
1536 to 0 (bug#9911) when sending a unibyte text.
1538 * callproc.c (Fcall_process): Set the member src_multibyte of
1539 process_coding to 0 (bug#9912).
1541 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1543 * xmenu.c (cleanup_widget_value_tree): New function.
1544 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1545 calling free_menubar_widget_value_tree directly (Bug#9830).
1547 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1549 Fix some portability problems with 'inline'.
1550 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1551 (window_box_width, window_box_left, window_box_left_offset)
1552 (window_box_right, window_box_right_offset): Declare extern.
1553 Otherwise, these inline functions do not conform to C99 and
1554 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1555 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1556 * intervals.c (adjust_intervals_for_insertion)
1557 (adjust_intervals_for_deletion): Now extern, because otherwise the
1558 extern inline functions 'offset_intervals' couldn't refer to it.
1559 (static_offset_intervals): Remove.
1560 (offset_intervals): Rewrite using the old contents of
1561 static_offset_intervals. The old version didn't conform to C99
1562 because an extern inline function contained a reference to an
1563 identifier with static linkage.
1565 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1567 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1570 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1572 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1573 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1574 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1575 return Qleft_to_right.
1577 2011-11-06 Chong Yidong <cyd@gnu.org>
1579 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1580 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1581 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1582 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1583 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1584 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1585 (Fwindow_vscroll): Doc fix.
1586 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1587 argument, since it makes no sense to pass a live window and for
1588 consistency with window-child.
1590 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1592 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1595 2011-11-05 Jason Rumney <jasonr@gnu.org>
1597 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1598 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1600 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1601 bitwise arithmetic preventing use of unicode-sip and non-truetype
1604 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1606 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1609 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1610 initialization code to keep similarity to xfns.c after changes
1613 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1615 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1616 (unwind_create_frame): New function (Bug#9943).
1617 (Fx_create_frame): Restructure code to be more similar to the one in
1618 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1619 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1620 Move terminal->reference_count++ just before making the frame official
1623 * nsterm.m (x_free_frame_resources): New function.
1624 (x_destroy_window): Move code to x_free_frame_resources.
1626 * xfns.c (unwind_create_frame): Fix comment.
1627 (Fx_create_frame, x_create_tip_frame):
1628 Move terminal->reference_count++ just before making the frame
1629 official. Move initialization of image_cache_refcount and
1630 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1632 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1634 Support MSVC build with newer versions of Visual Studio.
1635 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1636 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1639 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1640 which are not supported by MSVC.
1641 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1642 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1644 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1646 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1648 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1650 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1652 Support MSVC build with newer versions of Visual Studio.
1653 * w32.c: Don't include w32api.h for MSVC.
1654 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1656 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1657 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1658 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1659 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1661 (alloca) [_MSC_VER]: Define to _alloca.
1663 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1665 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1667 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1669 * xdisp.c (note_mouse_highlight): If either of
1670 previous/next-single-property-change returns nil, treat that as
1671 the beginning or the end of the buffer. (Bug#9955)
1673 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1675 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1676 label is not null (Bug#9951).
1677 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1680 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1682 * window.c (Fwindow_body_size): Mention in the doc string that the
1683 return value is in frame's canonical units. (Bug#9949)
1685 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1687 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1689 * w32fns.c (unwind_create_frame): If needed, free the glyph
1690 matrices of the partially constructed frame. (Bug#9943)
1691 * xfns.c (unwind_create_frame): Likewise.
1693 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1695 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1696 Don't stop backward scan on the continuation glyph, even though
1697 its CHARPOS is positive.
1698 (mouse_face_from_buffer_pos, note_mouse_highlight):
1699 Rename cover_string to disp_string.
1701 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1703 * window.c (temp_output_buffer_show): Don't use
1704 Vtemp_buffer_show_specifiers.
1705 (Vtemp_buffer_show_specifiers): Remove unused variable.
1707 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1709 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1710 past the beginning of the current glyph matrix.
1712 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1714 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1715 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1716 HAVE_GTK3 (Bug#9869).
1718 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1719 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1721 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1723 * xterm.c: Declare x_handle_net_wm_state to return int.
1724 (handle_one_xevent): Check if we are iconified but don't have
1725 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1726 (get_current_wm_state): Return non-zero if not hidden,
1727 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1728 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1729 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1730 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1732 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1734 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1735 so that this new function doesn't get optimized away by a
1736 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1738 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1740 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1742 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1744 Fix the `xbytecode' command.
1745 * .gdbinit (xprintbytestr): New command.
1746 (xwhichsymbols): Rename from `which'; all callers changed.
1747 (xbytecode): Print the byte-code string as well.
1749 2011-10-29 Kim Storm <storm@cua.dk>
1751 * alloc.c (which_symbols): New function.
1753 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1755 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1758 2011-10-29 Glenn Morris <rgm@gnu.org>
1760 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1761 Not clear what it was for, and it causes various bugs. (Bug#9839)
1763 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1765 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1766 possible random value that matches one of those tested as
1767 condition to clear the mouse face.
1769 2011-10-28 Chong Yidong <cyd@gnu.org>
1771 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1773 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1775 * window.c (make_window): Initialize phys_cursor_on_p.
1777 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1779 * lisp.h (struct Lisp_Symbol): Update comments.
1781 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1783 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1785 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1787 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1788 <oslsachem@gmail.com> for helping to debug this.
1790 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1791 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1792 (g_b_init_get_glyph_outline_w): New static variables.
1793 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1794 (GetGlyphOutlineW_Proc): New typedefs.
1795 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1796 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1798 (w32font_open_internal, compute_metrics):
1799 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1800 instead of calling the "wide" APIs directly.
1802 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1804 * w32.h (syms_of_w32font): Add prototype.
1806 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1808 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1809 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1810 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1811 (Fmove_to_window_line): Doc fix.
1813 2011-10-27 Chong Yidong <cyd@gnu.org>
1815 * process.c (make_process): Set gnutls_state to NULL.
1817 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1818 non-NULL, regardless of GNUTLS_INITSTAGE.
1819 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1820 an error. Set process slots as soon as we allocate them.
1822 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1824 2011-10-27 Chong Yidong <cyd@gnu.org>
1826 * gnutls.c (emacs_gnutls_deinit): New function.
1827 Deallocate credentials structures as well as calling gnutls_deinit.
1828 (Fgnutls_deinit, Fgnutls_boot): Use it.
1830 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1831 (deactivate_process): Call emacs_gnutls_deinit.
1833 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1835 * image.c (x_create_x_image_and_pixmap):
1836 * w32.c (sys_rename, w32_delayed_load):
1837 * w32font.c (fill_in_logfont):
1838 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1840 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1842 * w32fns.c (w32_default_color_map): New function,
1843 extracted from Fw32_default_color_map.
1844 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1846 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1848 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1850 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1852 * keyboard.c (test_undefined): New function (bug#9751).
1853 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1855 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1857 * sysdep.c (init_sys_modes): Fix the check for the controlling
1858 terminal (Bug#6649).
1860 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1862 * dispextern.h (struct bidi_it): New member next_en_type.
1864 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1865 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1866 current character, check also for next_en_type being WEAK_EN.
1867 (bidi_resolve_weak): Don't enter the expensive loop if the current
1868 position is before next_en_pos. Record the bidi type of the first
1869 non-ET, non-BN character we find, in addition to its position.
1870 (bidi_level_of_next_char): Invalidate next_en_type when
1871 next_en_pos is over-stepped.
1873 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1875 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1876 * editfns.c: Rewrite current-time-zone so that it invokes
1877 the equivalent of (format-time-string "%Z") to get the time zone name.
1878 This fixes a bug when the time zone name contains characters that
1879 need converting from the system time locale to Emacs internal format.
1880 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1881 that patch fixed format-time-string to do the conversion, but
1882 I forgot to fix current-time-zone.
1883 (format_time_string): New function, containing most of
1884 what Fformat_time_string used to contain.
1885 (Fformat_time_string): Rewrite in terms of format_time_string.
1886 This doesn't change this function's behavior.
1887 (current-time-zone): Rewrite to use format_time_string.
1888 This fixes the bug reported by Michael Schierl in
1889 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1890 Jason Rumney's 2007-06-07 change worked around this bug, but
1892 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1894 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1896 * xdisp.c (start_display): If the character at POS is displayed
1897 via a display vector, reset IT->current.dpvec_index to zero.
1898 (try_window_reusing_current_matrix): If a line ends in a display
1899 vector or the next line starts in a display vector, continue
1900 redrawing the window even though the character position of
1901 start_row was reached.
1904 2011-10-18 Chong Yidong <cyd@gnu.org>
1906 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1907 with nobreak-char-display too.
1909 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1911 Fix part 3 of bug#9771.
1912 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1913 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1914 non-neutral characters if the current character is a paragraph
1915 separator (a.k.a. Newline). This avoids running the same
1916 expensive loop twice, once when we consume the preceding newline
1917 and the other time when the line actually needs to be displayed.
1918 Avoid the loop when we see neutrals on the base embedding level
1919 following a character whose directionality is the same as the
1920 paragraph's. This avoids running the expensive loop when a line
1921 ends in a long sequence of neutrals, like control characters.
1922 Add assertion against STRONG_AL type. Slightly rearrange code
1923 that determines the type of a neutral given the first non-neutral
1925 (bidi_level_of_next_char): Set next_en_pos to zero when
1926 invalidating its info.
1928 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1930 * xdisp.c (push_display_prop): Determine whether to record string
1931 or buffer position by IT->string, not by IT->method. Allow
1932 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1933 (move_it_vertically_backward): Don't look for character position
1934 immediately after the newline when in a continuation line.
1937 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1939 * window.c (coordinates_in_window): Rewrite and delabelize
1940 vertical border check. (Bug#5357) (Bug#9618)
1942 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1944 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1945 errors in XSetWindowBorder (bug#9310).
1947 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1949 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1950 avoid crash when xmalloc overrun checking is enabled.
1952 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1954 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1955 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1956 cursor motion with <left> and <right> arrow keys.
1958 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1959 some callers set that themselves.
1961 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1963 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1964 display string and the previous row comes from the same string and
1965 is empty. (Bug#9739) (Bug#9738)
1967 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1969 * doc.c (get_doc_string): Encode file name (bug#9735).
1971 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1973 * bidi.c (bidi_level_of_next_char):
1974 * xdisp.c (get_visually_first_element): Remove old incorrect
1975 comments regarding the Unicode Line Separator character.
1977 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1979 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1981 * alloc.c (Fgc_status): Do not access beyond zombies array
1982 boundary if nzombies > MAX_ZOMBIES.
1983 * alloc.c (dump_zombies): Add missing format specifier.
1985 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1987 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1988 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1990 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1991 Some packages use them to denote characters with modifiers.
1993 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1995 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1996 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1997 matching a pp-number. Rename parameter var to var1.
1999 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2001 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2003 2011-10-08 Glenn Morris <rgm@gnu.org>
2005 * callint.c (Fcall_interactively): Give a more explicit error for the
2006 'c' case with a non-character input. (Bug#8479)
2008 2011-10-08 Eli Zaretskii <eliz@gnu.org>
2010 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2012 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2013 lines that are hscrolled on the left.
2015 * dispnew.c (buffer_posn_from_coords): Account for a possible
2016 presence of header-line. (Bug#4426)
2018 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2020 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2021 Don't advertise functionality which we discourage or doesn't work.
2023 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2025 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2026 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2027 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2028 this makes Emacs dump core during garbage collection on rare
2029 occasions. sizeof is obviously inferior to offsetof here, so
2030 stick with offsetof.
2031 (GC_POINTER_ALIGNMENT): New macro.
2032 (mark_memory): Omit 3rd (offset) arg; caller changed.
2033 Don't assume EMACS_INT alignment is the same as pointer alignment.
2035 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2037 * keyboard.c (read_key_sequence_remapped): New var.
2038 (read_key_sequence): Compute remapping in the right buffer.
2039 (command_loop_1): Use read_key_sequence's remapping directly.
2041 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2043 * dired.c (file_name_completion): Don't expand file name.
2044 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2045 before checking file name handler.
2047 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2048 they've been requested explicitly (bug#9591).
2050 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
2052 * keymap.c (Fsingle_key_description): Use make_specified_string
2053 instead of build_string to build string from push_key_description.
2056 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2058 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2059 This fixes a Y2038 bug on 64-bit hosts.
2060 * buffer.c (reset_buffer):
2061 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2062 (Fclear_buffer_auto_save_failure):
2063 Use 0, not -1, to represent an unset failure time, since time_t
2064 might not be signed.
2066 Remove dependency on glibc malloc internals.
2067 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2068 Move back here from lisp.h, but with their new implementations.
2069 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2070 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2071 * charset.c (charset_table_init): New static var.
2072 (syms_of_charset): Use it instead of xmalloc. This removes a
2073 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2074 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2075 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2076 Move back to alloc.c.
2077 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2078 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2080 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2082 * nsterm.m (windowDidResize): Call x_set_window_size only when
2083 ns_in_resize is true. Otherwise set pixelwidth/height and
2084 call change_frame_size (Bug#9628).
2086 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2088 Port --enable-checking=all to Fedora 14 x86-64.
2089 * charset.c (syms_of_charset): Also account for glibc malloc's
2090 internal overhead when calculating the initial malloc maximum.
2092 Port --enable-checking=all to Fedora 14 x86.
2093 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2095 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2096 (overrun_check_realloc, overrun_check_free):
2097 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2098 That way, xmalloc returns a properly-aligned pointer even if
2099 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2100 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2101 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2102 into account when calculating the initial malloc maximum.
2103 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2104 Move here from alloc.c, so that charset.c can use it too.
2105 Properly align; the old code wasn't right for common 32-bit hosts
2106 when configured with --enable-checking=all.
2107 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2108 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2110 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2112 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2115 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2117 * xdisp.c (compute_display_string_end): If there's no display
2118 string at CHARPOS, return -1.
2120 * bidi.c (bidi_fetch_char): When compute_display_string_end
2121 returns a negative value, treat the character as a normal
2122 character not covered by a display string. (Bug#9624)
2124 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2126 * lread.c (Fread_from_string): Fix typo in docstring.
2128 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2130 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2131 newline, reseat the iterator instead of bidi-iterating there one
2132 character at a time. (Bug#9610)
2133 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2134 TO_CHARPOS if the bidi iterator is at base embedding level.
2136 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2138 * lread.c (readevalloop): Use correct code for NBSP.
2139 (read1): Likewise. (Bug#9608)
2141 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2143 * dbusbind.c (Fdbus_register_signal): When service is not
2144 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2146 2011-09-25 Glenn Morris <rgm@gnu.org>
2148 * buffer.c (truncate-lines): Doc fix.
2150 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2152 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2153 (Fset_window_next_buffers): Doc fix.
2155 2011-09-24 Glenn Morris <rgm@gnu.org>
2157 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2159 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2161 Fix minor problems found by static checking.
2162 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2163 * indent.c (Fvertical_motion): Fix == vs = typo.
2165 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2167 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2168 Default value is now t. Doc fix.
2170 * indent.c (Fvertical_motion): Compute and apply the overshoot
2171 logic when moving up, not only when moving down. Fix the
2172 confusing name and values of the it_overshoot_expected variable;
2173 logic changes accordingly. (Bug#9254) (Bug#9549)
2175 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2176 CHARPOS is covered by a display string which includes newlines.
2177 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2178 is covered by a display string with embedded newlines.
2180 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2182 * dbusbind.c (Fdbus_register_signal): Add match rule to
2183 Vdbus_registered_objects_table. (Bug#9581)
2184 (Fdbus_register_method, Vdbus_registered_objects_table):
2187 2011-09-24 Jim Meyering <meyering@redhat.com>
2189 do not ignore write error for any output size
2190 The previous change was incomplete.
2191 While it makes emacs --batch detect the vast majority of stdout
2192 write failures, errors were still ignored whenever the output size is
2193 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2194 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2195 && echo FAIL: ignored write error
2196 FAIL: ignored write error
2197 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2198 && echo FAIL: ignored write error
2199 FAIL: ignored write error
2200 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2202 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2204 * emacs.c (Fkill_emacs): In noninteractive mode exit
2205 non-successfully if a write error occurred on stdout. (Bug#9574)
2207 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2209 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2212 * dispextern.h (struct it): Update the comment documenting what
2215 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2217 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2218 a display string, extend search for cursor position to end of row.
2219 (find_row_edges): If the row ends in a newline from a display
2220 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2221 Handle the case of a display string with multiple newlines.
2222 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2223 non-empty line. Fixes confusing cursor motion with arrow keys at
2224 the beginning of a line that starts with whitespace.
2226 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2228 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2231 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2233 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2236 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2238 * xdisp.c (display_line): Record maximum and minimum buffer
2239 positions even if no glyphs were produced (e.g., by a zero-width
2240 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2241 buffer positions that will be removed from the glyph row because
2243 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2244 column is beyond frame width: don't subtract 1 "pixel" when
2245 computing width of the stretch.
2246 (reseat_at_next_visible_line_start): Undo the change made on
2247 2011-09-17 that saved paragraph information and restored it after
2248 the call to `reseat'. (Bug#9545)
2250 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2252 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2253 and turn window cursor on if cleared (Bug#9415).
2255 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2257 * search.c (boyer_moore): Take unibyte characters from pattern
2258 literally. (Bug#9458)
2260 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2262 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2264 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2266 Fix minor problem found by static checking.
2267 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2268 initialized, to pacify gcc -Wuninitialized.
2270 * fileio.c: Report proper errno when syscall falls.
2271 (Finsert_file_contents): Save and restore errno,
2272 so that report_file_error outputs the correct diagnostic.
2273 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2275 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2277 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2279 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2281 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2282 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2284 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2286 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2287 about the current paragraph and restore it after the call to reseat.
2289 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2290 (bidi_find_paragraph_start): Search back for paragraph beginning
2291 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2292 (bidi_move_to_visually_next): Only trigger paragraph-related
2293 computations when the last character is a newline or at EOB, not
2294 just any NEUTRAL_B. (Bug#9470)
2296 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2297 truncated lines if point is covered by a display string. (Bug#9524)
2299 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2301 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2302 (cons_to_x_long): New function.
2303 (lisp_data_to_selection_data): Use it. Correct the test for
2304 short-versus-long data; it was negated. Break out of vector
2305 loop, for efficiency, when a long datum is discovered.
2307 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2309 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2311 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2313 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2314 GCC PR/17406) by declaring this function with external scope.
2316 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2318 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2319 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2321 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2323 * editfns.c (Fformat): Correctly handle text properties on "%%".
2325 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2327 * xterm.c (x_draw_composite_glyph_string_foreground):
2328 * w32term.c (x_draw_composite_glyph_string_foreground):
2329 * term.c (encode_terminal_code):
2330 * composite.c (composition_update_it, get_composition_id):
2331 * xdisp.c (get_next_display_element)
2332 (fill_composite_glyph_string): Add comments about special meaning
2333 of TAB characters in a composition.
2335 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2337 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2338 This occurs when processing a multibyte format.
2339 Problem reported by Wolfgang Jenker.
2341 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2343 * xdisp.c (try_cursor_movement): Only check for exact match if
2344 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2346 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2348 Remove unused external symbols.
2349 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2350 * xdisp.c (calc_pixel_width_or_height): Now static.
2351 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2352 * indent.c (check_display_width):
2353 * w32term.c: Fix comment to match code.
2354 * xterm.c, xterm.h (x_catching_errors): Remove.
2356 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2358 * xselect.c: Use signed conversions more consistently (Bug#9498).
2359 (selection_data_to_lisp_data): Assume incoming selection data are
2360 signed integers, not unsigned. This is to be consistent with
2361 outgoing selection data, which was modified to use signed integers
2362 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2363 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2364 expects long, not unsigned long.
2366 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2368 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2369 computation of loop end. Reported by Johan Bockgård
2372 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2374 * frame.c (Fother_visible_frames_p): Function deleted.
2376 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2378 * indent.c (compute_motion): Process display vector front to back
2379 rather than the other way around. (Bug#2496)
2381 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2383 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2385 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2387 * minibuf.c (Fread_from_minibuffer): Doc fix.
2389 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2391 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2392 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2394 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2396 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2397 value for non-existent files.
2399 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2401 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2402 set its "size" to -1. This will set the modtime_size field of
2403 the corresponding buffer to -1, which is what
2404 verify-visited-file-modtime expects for files that do not exist.
2407 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2409 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2411 * lisp.h: ... from here. push_key_description is no longer
2412 defined in keyboard.c, so its declaration should not be in
2413 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2414 logically belongs with push_key_description.
2416 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2418 * buffer.h: Include <sys/types.h> instead of <time.h>.
2419 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2420 Problem reported by Herbert J. Skuhra.
2422 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2424 * xml.c (parse_region): Make the parsing work for
2425 non-comment-starting XML files again (bug#9144).
2427 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2429 * image.c (gif_load): Fix calculation of bottom and right corner.
2432 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2434 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2435 redisplay in small windows.
2437 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2439 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2441 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2443 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2444 Operate on live windows only.
2446 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2448 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2450 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2452 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2453 only under bidi iteration.
2455 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2457 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2459 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2461 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2462 Without this fix, the command to link temacs failed due to an
2463 undefined symbol __builtin_isnan. This is because
2464 /usr/include/iso/math_c99.h #defines isnan(x) to
2465 __builtin_isnan(x), but the bundled gcc, which identifies itself
2466 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2468 * floatfns.c (isnan): #undef, and then #define to a clone of
2470 (Fisnan): Always define, since it's always available now.
2471 (syms_of_floatfns): Always define isnan at the Lisp level.
2473 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2475 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2477 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2479 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2480 The previous code assumed that file offsets (off_t values) fit in
2481 EMACS_INT variables, which is not true on typical 32-bit hosts.
2482 The code messed up by falsely reporting buffer overflow in cases
2483 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2484 when "big" contains more than 2**29 bytes, even though this
2485 inserts just one byte and does not overflow the buffer.
2486 (Finsert_file_contents): Store file offsets as off_t
2487 values, not as EMACS_INT values. Check for overflow when
2488 converting between EMACS_INT and off_t. When checking for
2489 buffer overflow or for overlap, take the offsets into account.
2490 Don't use EMACS_INT for small values where int suffices.
2491 When checking for overlap, fix a typo: ZV was used where
2492 ZV_BYTE was intended.
2493 (Fwrite_region): Don't assume off_t fits into 'long'.
2494 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2496 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2498 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2500 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2502 sprintf-related integer and memory overflow issues (Bug#9412).
2504 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2505 (esprintf, exprintf, evxprintf): New functions.
2506 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2507 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2508 (modify_event_symbol): Do not assume that the length of
2509 name_alist_or_stem is safe to alloca and fits in int.
2510 (Fexecute_extended_command): Likewise for function name and binding.
2511 (Frecursion_depth): Wrap around reliably on integer overflow.
2512 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2513 since some callers pass EMACS_INT values.
2514 (Fsingle_key_description): Don't crash if symbol name contains more
2515 than MAX_ALLOCA bytes.
2516 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2517 (get_minibuffer): Arg is now EMACS_INT, not int.
2518 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2519 (esprintf, exprintf, evxprintf): New decls.
2520 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2522 * dbusbind.c (signature_cat): New function.
2523 (xd_signature, Fdbus_register_signal):
2524 Do not overrun buffer; instead, report string overflow.
2526 * dispnew.c (add_window_display_history): Don't overrun buffer.
2527 Truncate instead; this is OK since it's just a log.
2529 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2530 even if the time zone offset is outlandishly large.
2531 Don't mishandle offset == INT_MIN.
2533 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2534 when creating daemon; the previous buffer-overflow check was incorrect.
2536 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2537 which has the guts of the old verror function.
2539 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2540 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2542 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2543 (font_unparse_xlfd): Don't blindly alloca long strings.
2544 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2545 fits in int, when using sprintf. Use single snprintf to count
2546 length of string rather than counting it via multiple sprintfs;
2547 that's simpler and more reliable.
2548 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2549 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2550 sprintf, in case result does not fit in int.
2552 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2553 (fontset_from_font): Print it.
2555 * frame.c (tty_frame_count): Now printmax_t, not int.
2556 (make_terminal_frame, set_term_frame_name): Print it.
2557 (x_report_frame_params): In X, window IDs are unsigned long,
2558 not signed long, so print them as unsigned.
2559 (validate_x_resource_name): Check for implausibly long names,
2560 and don't assume name length fits in 'int'.
2561 (x_get_resource_string): Don't blindly alloca invocation name;
2562 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2565 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2566 (xg_check_special_colors, xg_set_geometry):
2567 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2569 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2570 Use esprintf, not sprintf, in case result does not fit in int.
2572 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2573 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2574 it as a large positive number.
2575 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2576 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2578 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2579 in case result does not fit in int.
2581 * print.c (float_to_string): Detect width overflow more reliably.
2582 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2583 buffer overrun. Don't assume list length fits in 'int'. Treat
2584 print length of 0 as 0, not as infinity; to be consistent with other
2585 uses of print length in this function. Don't overflow print length
2586 index. Don't assume hash table size fits in 'long', or that
2587 vectorlike size fits in 'unsigned long'.
2589 * process.c (make_process): Use printmax_t, not int, to format
2590 process-name gensyms.
2592 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2594 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2595 to avoid potential buffer overrun.
2597 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2598 if X resource line is longer than 512 bytes.
2600 * xfns.c (x_window): Make sprintf buffer a bit bigger
2601 to avoid potential buffer overrun.
2603 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2605 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2607 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2609 Integer overflow fixes for scrolling, etc.
2610 Without these, Emacs silently mishandles large integers sometimes.
2611 For example, "C-u 4294967297 M-x recenter" was treated as if
2612 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2614 * xdisp.c (try_window_id): Check Emacs fixnum range before
2615 converting to 'int'.
2617 * window.c (window_scroll_line_based, Frecenter):
2618 Check that an Emacs fixnum is in range before assigning it to 'int'.
2619 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2620 values converted from Emacs fixnums.
2621 (Frecenter): Don't wrap around a line count if it is out of 'int'
2622 range; instead, treat it as an extreme value.
2623 (Fset_window_configuration, compare_window_configurations):
2624 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2626 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2627 that can exceed INT_MAX. Check that EMACS_INT value is in range
2628 before assigning it to the (possibly-narrower) index.
2629 (match_limit): Don't assume that a fixnum can fit in 'int'.
2631 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2634 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2635 (Fvertical_motion): Don't wrap around LINES values that don't fit
2636 in 'int'. Instead, treat them as extreme values. This is good
2637 enough for windows, which can't have more than INT_MAX lines anyway.
2639 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2641 * Require libxml/parser.h to avoid compilation warning.
2643 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2645 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2646 since this reportedly can destroy thread storage.
2648 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2650 * syntax.c (find_defun_start): Update all cache variables if
2651 exiting early (Bug#9401).
2653 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2655 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2657 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2658 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2659 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2661 * term.c (tty_append_glyph): New function.
2662 (produce_stretch_glyph): Static function and its prototype deleted.
2664 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2667 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2669 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2670 when checking :margin (Bug#9390).
2671 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2672 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2673 so that the name doesn't mislead. All uses changed.
2675 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2677 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2680 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2682 * xdisp.c (move_it_to): Don't bail out early when reaching
2683 position beyond to_charpos, if we are scanning backwards.
2684 (move_it_vertically_backward): When DY == 0, make sure we get to
2685 the first character in the line after the newline.
2687 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2689 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2690 (ccl_driver): Do not generate an out-of-range pointer.
2691 (Fccl_execute_on_string): Remove unnecessary check for
2692 integer overflow, noted by Stefan Monnier in
2693 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2694 Remove a FIXME that didn't need fixing.
2695 Simplify the newly-introduced buffer reallocation code.
2697 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2699 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2701 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2703 Integer and memory overflow issues (Bug#9196).
2705 * doc.c (get_doc_string): Rework so that
2706 get_doc_string_buffer_size is the actual buffer size, rather than
2707 being 1 less than the actual buffer size; this makes xpalloc more
2710 * image.c (x_allocate_bitmap_record, cache_image):
2711 * xselect.c (Fx_register_dnd_atom):
2712 Simplify previous changes by using xpalloc.
2714 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2715 since either will do and ptrdiff_t is convenient with xpalloc.
2717 * charset.c (charset_table_size)
2718 (struct charset_sort_data.priority): Now ptrdiff_t.
2719 (charset_compare): Don't overflow if priorities differ greatly.
2720 (Fsort_charsets): Don't assume list length fits in int.
2721 Check for size-calculation overflow when allocating sort data.
2722 (syms_of_charset): Allocate an initial charset table that is
2723 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2725 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2727 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2728 The actual value is always <= INT_MAX, and leaving it unsigned made
2729 overflow checking harder.
2731 * dispextern.h (struct glyph_matrix.rows_allocated)
2732 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2733 with xpalloc. The values are still always <= INT_MAX.
2735 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2737 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2738 (SAFE_NALLOCA): New macro.
2740 * region-cache.c (struct boundary.pos, find_cache_boundary)
2741 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2742 (set_cache_region, invalidate_region_cache)
2743 (revalidate_region_cache, know_region_cache, region_cache_forward)
2744 (region_cache_backward, pp_cache):
2745 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2746 so that ptrdiff_t * can be passed to xpalloc.
2747 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2748 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2749 (pp_cache): Don't assume cache_len fits in int.
2750 * region-cache.h: Adjust extern decls to match.
2752 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2753 EMACS_INT, since either will do, for xpalloc.
2755 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2756 (xnmalloc, xnrealloc, xpalloc): New functions.
2758 * bidi.c (bidi_shelve_header_size): New constant.
2759 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2760 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2762 * bidi.c (bidi_cache_shrink):
2763 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2765 Don't update size of array until after memory allocation succeeds,
2766 because xmalloc/xrealloc may not return.
2767 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2768 now that we have proper integer overflow checking.
2769 (record_overlay_string, overlay_strings): Catch overflows when
2770 calculating size of overlay_str_buf.
2772 * callproc.c (Fcall_process): Check for size overflow when
2773 calculating size of args2.
2774 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2775 Normally we prefer signed values, but sticking with ptrdiff_t would
2776 require adding more-complicated checks.
2778 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2779 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2780 Redo buffer-overflow calculations to avoid integer overflow.
2781 Add a FIXME comment where memory seems to be over-allocated.
2783 * character.c (Fstring): Check for size-calculation overflow.
2785 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2786 unnecessary integer overflow. Check for size overflow.
2787 (encode_coding_object): Don't update size until xmalloc succeeds.
2789 * composite.c (get_composition_id): Check for overflow in glyph
2790 length calculations.
2792 Integer and memory overflow fixes for display code.
2793 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2794 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2795 (scrolling_window): Check for overflow in size calculations.
2796 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2797 Don't assume glyph table len fits in int.
2798 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2799 (row_table_size): Now ptrdiff_t, not int.
2800 (scrolling_window): Avoid overflow in size calculations.
2801 Don't update size until allocation succeeds.
2802 * fns.c (concat): Check for overflow in size calculations.
2803 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2804 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2805 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2807 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2808 (get_doc_string): Check for size calculation overflow.
2809 Don't update size until allocation succeeds.
2810 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2811 EMACS_INT, where ptrdiff_t will do.
2812 (Fsubstitute_command_keys): Check for string overflow.
2814 * editfns.c (set_time_zone_rule): Don't assume environment length
2816 (message_length): Now ptrdiff_t, not int.
2817 (Fmessage_box): Don't update size until allocation succeeds.
2818 Don't assume message length fits in int.
2819 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2821 * emacs.c (main): Do not reallocate argv, since there is a null at
2822 the end that can be overwritten, and this way there's no need to
2823 worry about size-calculation overflow.
2824 (sort_args): Check for size-calculation overflow.
2826 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2828 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2830 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2831 (x_set_scroll_bar_width, x_figure_window_size):
2832 Check for integer overflow.
2833 (x_set_alpha): Do not assume XINT fits in int.
2835 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2836 This is for the members text_lines, text_cols, total_lines, total_cols,
2837 where the system imposes an 'int' limit.
2839 * fringe.c (Fdefine_fringe_bitmap):
2840 Don't update size until alloc works.
2842 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2843 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2845 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2846 Check for size-calculation overflow.
2847 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2848 do, as we prefer signed integers.
2849 (id_to_widget.max_size, id_to_widget.used)
2850 (xg_store_widget_in_map, xg_remove_widget_from_map)
2851 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2852 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2853 Use and return ptrdiff_t, not int.
2854 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2855 * gtkutil.h: Change prototypes to match the above.
2857 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2858 are duplicate now that they've been promoted to lisp.h.
2859 (x_allocate_bitmap_record, x_alloc_image_color)
2860 (make_image_cache, cache_image, xpm_load):
2861 Don't update size until alloc is done.
2862 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2864 Check for size calculation overflow.
2865 (ct_colors_allocated_max): New constant.
2866 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2869 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2870 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2871 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2872 Use ptrdiff_t, not int, to count maps.
2873 (read_char_minibuf_menu_prompt): Check for overflow in size
2874 calculations. Don't update size until allocation succeeds.
2875 Redo calculations to avoid overflow.
2876 * keyboard.h: Change prototypes to match the above.
2878 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2880 (current_minor_maps): Check for size calculation overflow.
2881 * keymap.h: Change prototypes to match the above.
2883 * lread.c (read1, init_obarray): Don't update size until alloc done.
2885 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2886 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2888 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2889 Now ptrdiff_t, not int.
2890 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2891 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2893 * process.c (Fnetwork_interface_list): Check for overflow
2894 in size calculation.
2896 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2898 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2899 overflow. Don't bother calling xmalloc when xrealloc will do.
2901 * search.c (Freplace_match): Check for size calculation overflow.
2902 (Fset_match_data): Don't assume list lengths fit in 'int'.
2904 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2905 for command line length. Do not attempt to address one before the
2906 beginning of an array, as that's not portable.
2908 * term.c (max_frame_lines): Remove; unused.
2909 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2911 (encode_terminal_code, calculate_costs): Check for size
2912 calculation overflow.
2913 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2914 table lengths and related sizes. Don't update size until alloc
2915 done. Redo calculations to avoid overflow.
2916 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2918 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2919 subtracting pointers.
2920 (gobble_line): Check for overflow more carefully. Don't update size
2923 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2924 Don't update size until alloc done.
2925 Redo size calculations to avoid overflow.
2926 Check for size calculation overflow.
2927 (main) [DEBUG]: Fix typo in invoking tparam1.
2929 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2930 Use ptrdiff_t, not int, for sizes.
2931 (store_mode_line_noprop_char): Don't update size until alloc done.
2933 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2934 Use ptrdiff_t, not int, for sizes.
2935 (Finternal_make_lisp_face, cache_face):
2936 Check for size calculation overflow.
2937 (cache_face): Treat size calculation overflows as if they were
2938 memory exhaustion (the usual treatment), rather than aborting.
2940 * xfns.c (x_encode_text, x_set_name_internal)
2941 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2942 sizes, since they can exceed INT_MAX in size. Check for size
2943 calculation overflow.
2945 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2946 (xg_select): Check for size calculation overflow.
2947 Don't update size until alloc done.
2949 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2950 as sprintf is limited to int lengths.
2952 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2953 (X_LONG_MIN): New macros.
2954 Use them to make the following changes clearer.
2955 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2956 This change doesn't affect the value now, but it may help remind
2957 future maintainers not to raise the value too much later.
2958 (SELECTION_QUANTUM): Remove, replacing with ...
2959 (selection_quantum): ... new function, which avoids overflow.
2961 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2962 assumption that selection length fits in 'int'.
2963 (x_reply_selection_request, x_handle_selection_request)
2964 (x_get_window_property, receive_incremental_selection)
2965 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2966 (lisp_data_to_selection_data, clean_local_selection_data):
2967 Use ptrdiff_t, not int, to record length of selection.
2968 (x_reply_selection_request, x_get_window_property)
2969 (receive_incremental_selection, x_property_data_to_lisp):
2970 Redo calculations to avoid overflow.
2971 (x_reply_selection_request): When sending hint, ceiling it at
2972 X_LONG_MAX rather than relying on wraparound overflow to send
2974 (x_get_window_property, receive_incremental_selection)
2975 (lisp_data_to_selection_data, x_property_data_to_lisp):
2976 Check for size-calculation overflow.
2977 (x_get_window_property, receive_incremental_selection)
2978 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2979 Don't store size until memory allocation succeeds.
2980 (x_get_window_property): Plug memory leak on memory exhaustion.
2981 Don't double-block input; malloc is safe here. Don't assume 2**34
2982 - 4 fits in unsigned long. Add an xassert to check
2983 XGetWindowProperty overflow. Be more careful about overflow
2984 calculations, and distinguish size from memory overflow better.
2985 (receive_incremental_selection): When tracing, don't assume
2986 unsigned int is less than INT_MAX.
2987 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2988 harmful) conversions of unsigned short to int.
2989 (lisp_data_to_selection_data): Don't assume that integers
2990 in the range -65535 through -1 fit in an X unsigned short.
2991 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2992 result parameters unless successful. Rely on cons_to_unsigned
2993 to report problems with elements; the old code wasn't right anyway.
2994 (x_check_property_data): Check for int overflow; we cannot use
2995 a wider type due to X limits.
2996 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2998 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
3000 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3001 (x_term_init): Check for size calculation overflow.
3002 (x_color_cells): Don't store size until memory allocation succeeds.
3003 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
3004 Don't assume alloca size is less than MAX_ALLOCA.
3005 (x_term_init): Don't assume length fits in int (sprintf is limited
3008 Use ptrdiff_t for composition IDs.
3009 * character.c (lisp_string_width):
3010 * composite.c (composition_table_size, n_compositions)
3011 (get_composition_id, composition_gstring_from_id):
3012 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3013 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3014 * window.c (Frecenter):
3015 Use ptrdiff_t, not int, for composition IDs.
3016 * composite.c (get_composition_id): Check for integer overflow.
3017 * composite.h: Adjust prototypes to match the above changes.
3019 Use ptrdiff_t for hash table indexes.
3020 * category.c (hash_get_category_set):
3021 * ccl.c (ccl_driver):
3022 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3023 * coding.c (coding_system_charset_list, detect_coding_system):
3024 * coding.h (struct coding_system.id):
3025 * composite.c (get_composition_id, gstring_lookup_cache):
3026 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3027 * image.c (xpm_get_color_table_h):
3028 * lisp.h (hash_lookup, hash_put):
3029 * minibuf.c (Ftest_completion):
3030 Use ptrdiff_t for hash table indexes, not int (which is too
3031 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3032 32-bit --with-wide-int hosts).
3034 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3035 Add a FIXME comment about memory leaks.
3036 (syms_of_charset): Don't assume xmalloc returns.
3038 Don't assume that stated character widths fit in int.
3039 * character.c (Fchar_width, c_string_width, lisp_string_width):
3040 * character.h (CHAR_WIDTH):
3041 * indent.c (MULTIBYTE_BYTES_WIDTH):
3042 Use sanitize_char_width to avoid undefined and/or bad behavior
3043 with outlandish widths.
3044 * character.h (sanitize_tab_width): Rename from sanitize_width,
3045 now that we have two such functions. All uses changed.
3046 (sanitize_char_width): New inline function.
3048 Don't assume that tab-width fits in int.
3049 * character.h (sanitize_width): New inline function.
3050 (SANE_TAB_WIDTH): New macro.
3051 (ASCII_CHAR_WIDTH): Use it.
3052 * indent.c (sane_tab_width): Remove. All uses replaced by
3053 SANE_TAB_WIDTH (current_buffer).
3054 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3056 * fileio.c: Integer overflow issues with file modes.
3057 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3059 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3060 Remove unreachable code.
3061 (read_hex, load_charset_map_from_file): Check for integer overflow.
3063 * xterm.c: Don't go over XClientMessageEvent limit.
3064 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3065 (x_send_scroll_bar_event): Likewise. Check that the size does not
3066 exceed limits imposed by XClientMessageEvent, as well as the usual
3067 ptrdiff_t and size_t limits.
3069 * keyboard.c: Overflow, signedness and related fixes.
3070 (make_lispy_movement): Use same integer type in forward decl
3071 that is used in the definition.
3072 (read_key_sequence, keyremap_step):
3073 Change bufsize argument back to int, undoing my 2011-03-30 change.
3074 We prefer signed types, and int is wide enough here.
3075 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3076 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3077 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3078 length, not size_t. Use ptrdiff_t for index, not int.
3079 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3080 possibility of integer overflow.
3082 Overflow, signedness and related fixes for images.
3084 * dispextern.h (struct it.stack[0].u.image.image_id)
3085 (struct_it.image_id, struct image.id, struct image_cache.size)
3086 (struct image_cache.used, struct image_cache.ref_count):
3087 * gtkutil.c (update_frame_tool_bar):
3088 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3089 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3090 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3091 * nsmenu.m (update_frame_tool_bar):
3092 * xdisp.c (calc_pixel_width_or_height):
3093 * xfns.c (image_cache_refcount):
3094 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3095 on typical 64-bit hosts.
3097 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3098 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3099 Omit unnecessary casts to int.
3100 (parse_image_spec): Check that integers fall into 'int' range
3101 when the callers expect that.
3102 (image_ascent): Redo ascent calculation to avoid int overflow.
3103 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3104 (lookup_image): Remove unnecessary tests.
3105 (xbm_image_p): Locals are now of int, not EMACS_INT,
3106 since parse_image_check makes sure they fit into int.
3107 (png_load, gif_load, svg_load_image):
3108 Prefer int to unsigned where either will do.
3109 (tiff_handler): New function, combining the cores of the
3110 old tiff_error_handler and tiff_warning_handler.
3111 This function is rewritten to use vsnprintf and thereby avoid
3112 stack buffer overflows. It uses only the features of vsnprintf
3113 that are common to both POSIX and native Microsoft.
3114 (tiff_error_handler, tiff_warning_handler): Use it.
3115 (tiff_load, gif_load, imagemagick_load_image):
3116 Don't assume :index value fits in 'int'.
3117 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3118 (imagemagick_load_image): Check that crop parameters fit into
3119 the integer types that MagickCropImage accepts. Don't assume
3120 Vimagemagick_render_type has a nonnegative value. Don't assume
3121 size_t fits in 'long'.
3122 (gs_load): Use printmax_t to print the widest integers possible.
3123 Check for integer overflow when computing image height and width.
3125 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3127 * xdisp.c (redisplay_window): Don't force window start if point
3128 will be invisible in the resulting window. (Bug#9324)
3130 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3132 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3133 the display spec is of the form `(space ...)'.
3134 (handle_display_spec): Return the value returned by
3135 handle_single_display_spec, not just 1 or zero.
3136 (handle_single_display_spec): If the display spec is of the form
3137 `(space ...)', and specifies display in the text area, return 2
3139 (try_cursor_movement): Check for the need to scroll more
3140 accurately, and prefer exact match for point under bidi.
3141 Don't advance `row' beyond the last row of the window.
3143 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3144 into disp_prop; all users changed.
3146 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3147 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3148 for the text covered by the display property.
3150 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3152 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3153 Change return value to nil.
3154 (Frecord_buffer): Delete unused function.
3156 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3158 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3159 buffers, return left-to-right.
3160 (set_cursor_from_row): Consider candidate row a win if its glyph
3161 represents a newline and point is on that newline. Fixes cursor
3162 positioning on the newline at EOL of R2L text within L2R
3163 paragraph, and vice versa.
3164 (try_cursor_movement): Check continued rows, in addition to
3165 continuation rows. Fixes unwarranted scroll when point enters a
3166 continued line of R2L text within an L2R paragraph, or vice versa.
3167 (cursor_row_p): Consider the case of point being equal to
3168 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3169 from the end of a short line to the beginning of a continued line
3170 of R2L text within L2R paragraph.
3171 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3172 composed characters.
3174 * bidi.c (bidi_check_type): Use xassert.
3175 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3178 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3180 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3183 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3185 * nsfont.m (ns_otf_to_script): Fix typo.
3187 2011-08-22 Kenichi Handa <handa@m17n.org>
3189 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3190 extra slot even if the purpose is char-code-property-table.
3192 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3194 * xdisp.c (redisplay_window): When computing centering_position,
3195 account for the height of the header line. (Bug#8874)
3197 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3198 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3199 candidate is selected by the mouse, and that candidate has a
3200 composed character under the mouse.
3202 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3203 coordinates reported by pos-visible-in-window-p for a composed
3204 character in column zero.
3206 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3208 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3210 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3212 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3213 consider it a hit if to_charpos is anywhere in the range of the
3214 composed buffer positions.
3216 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3218 * image.c (gif_load): Don't assume that each subimage has the same
3219 dimensions as the base image. Handle disposal method that is
3220 "undefined" by the gif spec (Bug#9335).
3222 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3224 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3225 (Fcondition_case): Document `debug' symbol in error handler.
3227 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3229 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3230 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3231 from an Org mode buffer to a Speedbar frame.
3233 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3234 a composition, take its buffer position from IT->cmp_it.charpos.
3235 Fixes cursor positioning at the beginning of a line that begins
3236 with a composed character.
3238 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3240 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3241 character bidirectional type, use STRONG_L instead. Fixes crashes
3242 in a buffer produced by `describe-categories'.
3244 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3245 members before the level stack, so they would be saved and
3246 restored when copying iterator state. Fixes incorrect reordering
3247 around TABs covered by display properties.
3249 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3251 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3253 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3255 * eval.c (internal_condition_case, internal_condition_case_1)
3256 (internal_condition_case_2, internal_condition_case_n):
3257 Remove unnecessary aborts (Bug#9081).
3259 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3261 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3262 has no `load' handler, try opening the file locally. (Bug#9311)
3264 2011-08-16 Ken Brown <kbrown@cornell.edu>
3266 * gmalloc.c: Expand comment.
3268 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3270 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3271 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3273 2011-08-16 Ken Brown <kbrown@cornell.edu>
3275 Fix memory allocation problems in Cygwin build (Bug#9273).
3277 * unexcw.c ( __malloc_initialized): Declare external variable.
3278 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3280 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3282 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3284 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3286 [CYGWIN] (special_realloc): New function.
3287 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3288 requests to realloc storage in the static heap.
3290 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3292 * bidi.c (bidi_initialize): Remove unused local.
3294 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3297 * biditype.h: Remove file.
3298 * makefile.w32-in ($(BLD)/bidi.$(O)):
3299 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3301 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3303 * chartab.c: Improve commentary for the uniprop_table API.
3305 * bidi.c (bidi_paragraph_init): Support zero value of
3306 bidi_ignore_explicit_marks_for_paragraph_level.
3307 (bidi_initialize): Use uniprop_table instead of including
3308 biditype.h and bidimirror.h.
3310 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3311 coordinates of the iterator when restoring from ppos_it.
3314 2011-08-14 Kenichi Handa <handa@m17n.org>
3316 * process.c (create_process): Call setup_process_coding_systems
3317 after the pid of the process is set to -1 (Bug#8162).
3319 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3321 * xdisp.c (move_it_in_display_line_to): Don't invoke
3322 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3323 ppos_it. Fixes vertical cursor motion when line beginning is
3324 covered by an image. (Bug#9296)
3326 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3328 * nsterm.h (ns_run_ascript): Declare.
3329 (NSAPP_DATA2_RUNASSCRIPT): Define.
3331 * nsfns.m (as_script, as_result, as_status): New static variables.
3332 (ns_run_ascript): New function.
3333 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3334 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3335 the event loop. Get status from as_status (Bug#7276).
3337 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3338 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3339 the event loop (Bug#7276).
3341 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3343 * gnutls.c (QCgnutls_bootprop_priority)
3344 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3345 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3346 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3347 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3348 (QCgnutls_bootprop_verify_hostname_error)
3349 (QCgnutls_bootprop_callbacks_verify): Rename from
3350 Qgnutls_bootprop_..., all uses changed.
3352 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3355 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3357 * xfaces.c (Qframe_set_background_mode): Now static.
3358 * dispextern.h (Qframe_set_background_mode): Remove decl.
3360 * process.c (Fnetwork_interface_info): Declare local only if needed.
3362 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3364 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3365 (Fnetwork_interface_list): Allocate in increments of bytes instead
3366 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3367 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3369 (struct ifflag_def): notrailers is smart on OSX.
3370 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3371 Get hardware address with getifaddrs if available.
3373 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3375 * xdisp.c (iterate_out_of_display_property): xassert that
3376 IT->position is set to within IT->object's boundaries. Break from
3377 the loop as soon as EOB is reached; avoids infloops in redisplay
3378 when IT->position is set up wrongly due to some bug.
3379 Set IT->current to match the bidi iterator unconditionally.
3380 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3381 entry. Force push_it to save on the stack the current
3382 buffer/string position, to be restored by pop_it. Fix flags in
3383 the iterator structure wrt the object coming from a display
3384 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3385 properties. (Bug#9284)
3387 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3389 * fontset.c (fontset_get_font_group): Add proper type checks.
3392 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3394 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3395 and LC_VERSION_MIN_MACOSX.
3396 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3397 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3399 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3401 * xdisp.c (forward_to_next_line_start): Allow to use the
3402 no-display-properties-and-no-overlays under bidi display.
3403 Set disp_pos in the bidi iterator to avoid searches for display
3404 properties and overlays.
3406 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3408 * editfns.c (Fset_time_zone_rule): Document relationship with the
3411 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3412 the font entity extracted from the cache (Bug#8109).
3414 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3416 * composite.c (autocmp_chars): Don't reset point. That is done by
3417 restore_point_unwind (Bug#5984).
3419 2011-08-07 Juri Linkov <juri@jurta.org>
3421 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3422 to show the arg `TIME' instead of `TIMEVAL'.
3424 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3426 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3427 display property strides EOL and includes a newline, as in
3428 longlines-mode. (Bug#9254)
3429 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3430 word-wrap under bidirectional display. (Bug#9224)
3432 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3433 is non-zero, even if the data buffer is NULL. Fixes a crash in
3434 vertical-motion with longlines-mode. (Bug#9254)
3436 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3438 * bidi.c <bidi_cache_total_alloc>: Now static.
3439 (bidi_initialize): Initialize bidi_cache_total_alloc.
3441 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3444 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3445 amount allocated this far in `bidi_cache_total_alloc'.
3446 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3447 non-zero, only free the data buffer without restoring the cache
3448 contents. All callers changed.
3450 * dispextern.h (bidi_unshelve_cache): Update prototype.
3452 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3453 (move_it_in_display_line, move_it_to)
3454 (move_it_vertically_backward, move_it_by_lines): Replace the call
3455 to xfree to an equivalent call to bidi_unshelve_cache.
3456 (move_it_in_display_line_to): Fix logic of returning
3457 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3459 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3461 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3462 came from a string character with a `cursor' property. (Bug#9229)
3464 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3466 * Makefile.in (LIB_PTHREAD): New variable.
3467 (LIBES): Add LIB_PTHREAD (Bug#9216).
3469 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3470 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3472 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3474 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3476 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3478 * xterm.c (x_find_topmost_parent): New function.
3479 (x_set_frame_alpha): Find topmost parent window with
3480 x_find_topmost_parent and set the property there also (bug#9181).
3481 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3483 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3485 * callproc.c (Fcall_process): Avoid vfork clobbering
3486 the local vars buffer, coding_systems, current_dir.
3488 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3490 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3492 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3494 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3495 so that it is not optimized away.
3497 * xdisp.c (compute_display_string_pos): Remove unused local.
3499 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3501 Fix slow cursor motion and scrolling in large buffers with
3502 selective display, like Org Mode buffers. (Bug#9218)
3504 * dispextern.h (struct bidi_it): New member disp_prop_p.
3506 * xdisp.c: Remove one-slot cache of display string positions.
3507 (compute_display_string_pos): Accept an additional argument
3508 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3509 for a display string or property. If found, set DISP_PROP_P
3512 * bidi.c (bidi_fetch_char): Accept an additional argument
3513 DISP_PROP_P, and pass it to compute_display_string_pos.
3514 Only handle text covered by a display string if DISP_PROP_P is returned
3515 non-zero. All callers of bidi_fetch_char changed.
3517 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3519 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3521 2010-12-03 Don March <don@ohspite.net>
3523 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3524 last character M-[char] is translated to ESC [char] (bug#7541).
3526 2011-08-02 Kenichi Handa <handa@m17n.org>
3528 * lisp.h (uniprop_table): Extern it.
3530 * chartab.c (uniprop_table): Make it non-static.
3532 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3534 * xdisp.c (forward_to_next_line_start): Accept additional argument
3535 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3537 (reseat_at_next_visible_line_start): Use the bidi iterator state
3538 returned by forward_to_next_line_start to restore the state of
3539 it->bidi_it after backing up to previous newline. (Bug#9212)
3541 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3543 * regex.c (re_comp): Protoize.
3544 (re_exec): Fix return type.
3545 (regexec): Fix type of `ret'. (Bug#9203)
3547 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3549 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3550 This is needed if max-image-size is a floating-point number.
3552 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3554 * print.c (print_object): Print empty symbol as ##.
3556 * lread.c (read1): Read ## as empty symbol.
3558 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3560 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3561 setting frame foreground color (Bug#9175).
3562 (x_set_background_color): Likewise.
3564 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3565 contents (Bug#9176).
3566 (EmacsTooltip -init): Remove bezels and add shadows to
3569 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3570 or scroll bar (Bug#8470).
3572 * nsfont.m (nsfont_open): Remove assignment to voffset and
3573 unnecessary vars hshink, expand, hd, full_height, min_height.
3574 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3576 * nsterm.h (nsfont_info): Remove voffset field.
3578 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3580 Implement strike-through and overline on NextStep (Bug#8863).
3582 * nsfont.m (nsfont_open): Use underline position provided by font,
3583 instead of hard-coded value of 2.
3584 (nsfont_draw): Call ns_draw_text_decoration instead.
3586 * nsterm.h: Add declaration for ns_draw_text_decoration.
3588 * nsterm.m (ns_draw_text_decoration): New function for drawing
3589 underline, overline, and strike-through.
3590 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3591 ns_draw_text_decoration. Change treatment of cursor drawing to
3592 accommodate underlining, etc.
3594 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3596 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3599 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3601 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3602 Without this fix, if a signal arrives just after memory fills up,
3603 'malloc' might be invoked reentrantly.
3605 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3606 In other words, assume that every image size is allowed, on non-X
3607 hosts. This assumption is probably wrong, but it lets Emacs compile.
3609 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3611 * regex.c (re_iswctype): Convert return values to boolean.
3613 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3615 * xdisp.c (compute_display_string_pos): Don't use cached display
3616 string position if the buffer had its restriction changed.
3619 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3621 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3623 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3625 Integer signedness and overflow and related fixes. (Bug#9079)
3627 * bidi.c: Integer size and overflow fixes.
3628 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3629 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3630 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3631 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3632 (bidi_find_other_level_edge):
3633 Use ptrdiff_t instead of EMACS_INT where either will do.
3634 This works better on 32-bit hosts configured --with-wide-int.
3635 (bidi_cache_ensure_space): Check for size-calculation overflow.
3636 Use % rather than repeated addition, for better worst-case speed.
3637 Don't set bidi_cache_size until after xrealloc returns, because it
3639 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3640 (bidi_cache_ensure_space): Also check that the bidi cache size
3641 does not exceed that of the largest Lisp string or buffer. See Eli
3642 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3644 * alloc.c (__malloc_size_t): Remove.
3645 All uses replaced by size_t. See Andreas Schwab's note
3646 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3648 * image.c: Improve checking for integer overflow.
3649 (check_image_size): Assume that f is nonnull, since
3650 it is always nonnull in practice. This is one less thing to
3651 worry about when checking for integer overflow later.
3652 (x_check_image_size): New function, which checks for integer
3653 overflow issues inside X.
3654 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3655 This removes the need for a memory_full check.
3656 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3657 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3658 (xbm_read_bitmap_data): Change locals back to 'int', since
3659 their values must fit in 'int'.
3660 (xpm_load_image, png_load, tiff_load):
3661 Invoke x_create_x_image_and_pixmap earlier,
3662 to avoid much needless work if the image is too large.
3663 (tiff_load): Treat overly large images as if
3664 x_create_x_image_and_pixmap failed, not as malloc failures.
3665 (gs_load): Use x_check_image_size.
3667 * gtkutil.c: Omit integer casts.
3668 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3669 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3671 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3673 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3674 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3675 would wrongly return t on a 64-bit host.
3677 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3678 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3679 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3680 and therefore cause GCC to emit a bogus diagnostic in some cases.
3682 * image.c: Integer signedness and overflow and related fixes.
3683 This is not an exhaustive set of fixes, but it's time to
3684 record what I've got.
3685 (lookup_pixel_color, check_image_size): Remove redundant decls.
3686 (check_image_size): Don't assume that arbitrary EMACS_INT values
3687 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3688 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3689 (tiff_load, imagemagick_load_image):
3690 Check for overflow in size calculations.
3691 (x_create_x_image_and_pixmap): Remove unnecessary test for
3692 xmalloc returning NULL; that can't happen.
3693 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3694 (xpm_color_bucket): Use better integer hashing function.
3695 (xpm_cache_color): Don't possibly over-allocate memory.
3696 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3697 (gif_memory_source):
3698 Use ptrdiff_t, not int or size_t, to record sizes.
3699 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3700 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3701 either works, as we prefer signed integers.
3702 (tiff_read_from_memory, tiff_write_from_memory):
3703 Return tsize_t, not size_t, since that's what the TIFF API wants.
3704 (tiff_read_from_memory): Don't fail simply because the read would
3705 go past EOF; instead, return a short read.
3706 (tiff_load): Omit no-longer-needed casts.
3707 (Fimagemagick_types): Don't assume size fits into 'int'.
3709 Improve hashing quality when configured --with-wide-int.
3710 * fns.c (hash_string): New function, taken from sxhash_string.
3711 Do not discard information about ASCII character case; this
3712 discarding is no longer needed.
3713 (sxhash-string): Use it. Change sig to match it. Caller changed.
3714 * lisp.h: Declare it.
3715 * lread.c (hash_string): Remove, since we now use fns.c's version.
3716 The fns.c version returns a wider integer if --with-wide-int is
3717 specified, so this should help the quality of the hashing a bit.
3719 * emacs.c: Integer overflow minor fix.
3720 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3721 Define only if GNU_LINUX.
3722 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3724 * dispnew.c: Integer signedness and overflow fixes.
3725 Remove unnecessary forward decls, that were a maintenance hassle.
3726 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3728 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3729 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3730 (prepare_desired_row, line_draw_cost):
3731 Use int, not unsigned, where either works.
3732 (save_current_matrix, restore_current_matrix):
3733 Use ptrdiff_t, not size_t, where either works.
3734 (init_display): Check for overflow more accurately, and without
3735 relying on undefined behavior.
3737 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3738 Remove, replacing with the new symbols in lisp.h. All uses changed.
3739 * fileio.c (make_temp_name):
3740 * filelock.c (lock_file_1, lock_file):
3741 * xdisp.c (message_dolog):
3742 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3743 Use pMd etc. instead.
3744 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3745 replacing the pWIDE etc. symbols removed from editfns.c.
3747 * keyboard.h (num_input_events): Now uintmax_t.
3748 This is (very slightly) less likely to mess up due to wraparound.
3751 * buffer.c: Integer signedness fixes.
3752 (alloc_buffer_text, enlarge_buffer_text):
3753 Use ptrdiff_t rather than size_t when either will do, as we prefer
3756 * alloc.c: Integer signedness and overflow fixes.
3757 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3758 (__malloc_size_t): Default to size_t, not to int.
3759 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3760 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3761 Prefer ptrdiff_t to size_t when either would do, as we prefer
3763 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3764 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3765 Now const. Initialize with values that are in range even if char
3767 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3768 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3769 These functions do the right thing with sizes > 2**32.
3770 (check_depth): Now ptrdiff_t, not int.
3771 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3772 Adjust to new way of storing sizes. Check for size overflow bugs
3774 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3775 slightly wrong anyway, as it missed one instance of
3776 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3777 (refill_memory_reserve): Omit needless cast to size_t.
3778 (mark_object_loop_halt): Mark as externally visible.
3780 * xselect.c: Integer signedness and overflow fixes.
3781 (Fx_register_dnd_atom, x_handle_dnd_message):
3782 Use ptrdiff_t, not size_t, since we prefer signed.
3783 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3784 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3785 x_dnd_atoms_size and x_dnd_atoms_length.
3787 * doprnt.c: Prefer signed to unsigned when either works.
3789 * doprnt.c (doprnt):
3791 * xdisp.c (vmessage):
3792 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3793 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3794 prefer signed arithmetic to avoid comparison confusion.
3795 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3796 but is a bit tricky.
3798 Assume freestanding C89 headers, string.h, stdlib.h.
3799 * data.c, doprnt.c, floatfns.c, print.c:
3800 Include float.h unconditionally.
3801 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3802 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3803 * regex.c: Likewise for stddef.h, string.h.
3804 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3805 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3806 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3807 (STDC_HEADERS): Remove obsolete defines.
3808 * sysdep.c: Include limits.h unconditionally.
3810 Assume support for memcmp, memcpy, memmove, memset.
3811 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3812 * regex.c (memcmp, memcpy):
3813 Remove; we assume C89 now.
3815 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3816 (__malloc_safe_bcopy): Remove; no longer needed.
3818 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3819 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3820 well either way, and we prefer signed to unsigned.
3822 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3824 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3825 closes the connection while we're reading (bug#9182).
3827 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3829 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3830 are specified (Bug#9168).
3832 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3834 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3835 Found by GCC static checking and --with-wide-int on a 32-bit host.
3837 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3839 * xdisp.c (compute_display_string_pos): Fix logic of caching
3840 previous display string position. Initialize cached_prev_pos to
3841 -1. Fixes slow-down at the beginning of a buffer.
3843 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3845 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3846 for attrs[LFACE_FONTSET_INDEX].
3848 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3850 * xml.c (parse_region): Remove unused local
3851 that was recently introduced.
3853 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3855 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3856 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3858 * xdisp.c (move_it_in_display_line_to): Record the best matching
3859 position for TO_CHARPOS while scanning the line, and restore it on
3860 exit if none of the characters scanned was an exact match.
3861 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3862 when exact match is impossible due to invisible text, and the
3863 lines are truncated.
3865 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3867 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3870 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3872 Fix a significant slow-down of cursor motion with C-n, C-p,
3873 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3874 auto-repeat under bidi redisplay in fontified buffers.
3875 * xdisp.c (compute_stop_pos_backwards): New function.
3876 (next_element_from_buffer): Call compute_stop_pos_backwards to
3877 find a suitable prev_stop when we find ourselves before
3879 (reseat): Don't look for prev_stop, as that could mean a very long
3881 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3882 <cached_disp_overlay_modiff>: Cache for last found display string
3884 (compute_display_string_pos): Return the cached position if asked
3885 about the same buffer in the same area of character positions, and
3886 the buffer wasn't changed since the time the display string
3887 position was cached.
3889 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3891 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3892 is an integer, which is important for empty lines. (Bug#9149)
3894 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3896 * frame.c (Fmodify_frame_parameters): In tty case, update the
3897 default face if necessary (Bug#4238).
3899 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3901 * editfns.c (Fstring_to_char): No need to explain what a character
3902 is in the docstring (Bug#6576).
3904 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3906 * xml.c (parse_region): Make sure we always return a tree.
3908 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3910 * xml.c (parse_region): If a document contains only comments,
3913 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3915 * xml.c (make_dom): Return comments, too.
3917 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3920 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3921 and the surrounding thread.
3922 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3923 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3924 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3926 * s/openbsd.h (BROKEN_SIGIO): Define.
3927 * unexelf.c (unexec) [__OpenBSD__]:
3928 Don't update the .mdebug section of the Alpha COFF symbol table.
3930 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3932 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3935 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3937 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3938 This fixes some race conditions on the permissions of any newly
3941 * alloc.c (valid_pointer_p): Use pipe, not open.
3942 This fixes some permissions issues when debugging.
3944 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3945 If fchown fails to set both uid and gid, try to set just gid,
3946 as that is sometimes allowed. Adjust the file's mode to eliminate
3947 setuid or setgid bits that are inappropriate if fchown fails.
3949 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3951 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3952 to compare Lisp_Objects.
3953 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3954 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3955 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3957 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3959 * lread.c (read_integer): Unread even EOF character.
3960 (read1): Likewise. Properly record start position of symbol.
3962 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3963 symbol character follows.
3965 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3967 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3968 This works around a problem with the previous change to Fcopy_file.
3969 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3970 and without this change, GCC might complain about discarding
3971 fchown's return value.
3973 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3975 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3977 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3979 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3981 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3983 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3984 it's used from the C level.
3986 * process.c: Use the same condition for POLL_FOR_INPUT in both
3987 keyboard.c and process.c (bug#1858).
3989 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3991 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3992 (Fgnutls_boot): Use it.
3994 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3996 * doc.c (Fsubstitute_command_keys): Revert last change.
3998 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4000 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4001 quotes the next character, and doesn't affect other longer
4002 sequences (bug#8935).
4004 * lread.c (syms_of_lread): Clarify that is isn't only
4005 `eval-buffer' and `eval-defun' that's affected by
4006 `lexical-binding' (bug#8460).
4008 2011-07-15 Eli Zaretskii <eliz@gnu.org>
4010 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
4011 bidi redisplay when a line includes both an image and is truncated.
4013 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4015 Fix minor problems found by static checking.
4016 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4017 (elsz): Now a signed constant, not a size_t var. We prefer signed
4018 types to unsigned, to avoid integer comparison confusion. Without
4019 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4020 "cannot optimize loop, the loop counter may overflow", a symptom
4022 * indent.c (Fvertical_motion): Mark locals as initialized.
4023 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4025 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4027 * search.c (Fre_search_backward): Mention `case-fold-search' in
4028 all the re_search_* functions (bug#8138).
4030 * keyboard.c (Fopen_dribble_file): Document when the file is
4033 2011-07-14 Eli Zaretskii <eliz@gnu.org>
4035 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4038 Support bidi reordering of display and overlay strings.
4039 * xdisp.c (compute_display_string_pos)
4040 (compute_display_string_end): Accept additional argument STRING.
4041 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4042 (reseat_to_string): Initialize bidi_it->string.s and
4043 bidi_it->string.schars.
4044 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
4045 NULL (avoids a crash in bidi_paragraph_init).
4046 Initialize itb.string.lstring.
4047 (init_iterator): Call bidi_init_it only of a valid
4048 buffer position was specified. Initialize paragraph_embedding to
4050 (reseat_to_string): Initialize the bidi iterator.
4051 (display_string): If we need to ignore text properties of
4052 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4053 original value of -1 will not work with bidi.)
4054 (compute_display_string_pos): First arg is now struct
4055 `text_pos *'; all callers changed. Support display properties on
4057 (compute_display_string_end): Support display properties on Lisp
4059 (init_iterator, reseat_1, reseat_to_string): Initialize the
4060 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4061 when iterating on a string not from display properties).
4062 (compute_display_string_pos, compute_display_string_end):
4063 Fix calculation of the object to scan. Fixes an error when using
4065 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4066 base_level_stop; instead, set base_level_stop to BEGV.
4067 Fixes crashes in vertical-motion.
4068 (next_element_from_buffer): Improve commentary for when
4069 the iterator is before prev_stop.
4070 (init_iterator): Initialize bidi_p from the default value of
4071 bidi-display-reordering, not from buffer-local value. Use the
4072 buffer-local value only if initializing for buffer iteration.
4073 (handle_invisible_prop): Support invisible properties on strings
4074 that are being bidi-reordered.
4075 (set_iterator_to_next): Support bidi reordering of C strings and
4077 (next_element_from_string): Support bidi reordering of Lisp
4079 (handle_stop_backwards): Support Lisp strings as well.
4080 (display_string): Support display of R2L glyph rows.
4081 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4082 (init_iterator): Don't initialize it->bidi_p for strings
4084 (reseat_to_string): Initialize it->bidi_p for strings here.
4085 (next_element_from_string, next_element_from_c_string)
4086 (next_element_from_buffer): Add xassert's for correspondence
4087 between IT's object being iterated and it->bidi_it.string
4089 (face_before_or_after_it_pos): Support bidi iteration.
4090 (next_element_from_c_string): Handle the case of the first string
4091 character that is not the first one in the visual order.
4092 (get_visually_first_element): New function, refactored from common
4093 parts of next_element_from_buffer, next_element_from_string, and
4094 next_element_from_c_string.
4095 (tool_bar_lines_needed, redisplay_tool_bar)
4096 (display_menu_bar): Force left-to-right direction. Add a FIXME
4097 comment for making that be controlled by a user option.
4098 (push_it, pop_it): Save and restore the state of the
4099 bidi iterator. Save and restore the bidi_p flag.
4100 (pop_it): Iterate out of display property for string iteration as
4102 (iterate_out_of_display_property): Support iteration over strings.
4103 (handle_single_display_spec): Set up it->bidi_it for iteration
4104 over a display string, and call bidi_init_it.
4105 (handle_single_display_spec, next_overlay_string)
4106 (get_overlay_strings_1, push_display_prop): Set up the bidi
4107 iterator for displaying display or overlay strings.
4108 (forward_to_next_line_start): Don't use the shortcut if
4110 (back_to_previous_visible_line_start): If handle_display_prop
4111 pushed the iterator stack, restore the internal state of the bidi
4112 iterator by calling bidi_pop_it same number of times.
4113 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4114 and we are bidi-iterating, don't decrement the iterator position;
4115 instead, set the first_elt flag in the bidi iterator, to produce
4117 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4118 (push_display_prop): xassert that we are iterating a buffer.
4119 (push_it, pop_it): Save and restore paragraph_embedding member.
4120 (handle_single_display_spec, next_overlay_string)
4121 (get_overlay_strings_1, reseat_1, reseat_to_string)
4122 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4123 correctly. Don't assume unibyte strings are not bidi-reordered.
4124 (compute_display_string_pos)
4125 (compute_display_string_end): Fix handling the case of C string.
4126 (push_it, pop_it): Save and restore from_disp_prop_p.
4127 (handle_single_display_spec, push_display_prop): Set the
4128 from_disp_prop_p flag.
4129 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4130 (pop_it): Call iterate_out_of_display_property only if we are
4131 popping after iteration over a string that came from a display
4132 property. Fix a typo in popping stretch info. Add an assertion
4133 for verifying that the iterator position is in sync with the bidi
4135 (handle_single_display_spec, get_overlay_strings_1)
4136 (push_display_prop): Fix initialization of paragraph direction for
4137 string when that of the parent object is not yet determined.
4138 (reseat_1): Call bidi_init_it to resync the bidi
4139 iterator with IT's position. (Bug#7616)
4140 (find_row_edges): If ROW->start.pos gives position
4141 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4142 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4143 Reset the from_disp_prop_p flag.
4144 (SAVE_IT, RESTORE_IT): New macros.
4145 (pos_visible_p, face_before_or_after_it_pos)
4146 (back_to_previous_visible_line_start)
4147 (move_it_in_display_line_to, move_it_in_display_line)
4148 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4149 (try_scrolling, redisplay_window, display_line): Use them when
4150 saving a temporary copy of the iterator and restoring it back.
4151 (back_to_previous_visible_line_start, reseat_1)
4152 (init_iterator): Empty the bidi cache "stack".
4153 (move_it_in_display_line_to): If iterator ended up at
4154 EOL, but we never saw any buffer positions smaller than
4155 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4156 motion in bidi-reordered lines.
4157 (move_it_in_display_line_to): Record prev_method and prev_pos
4158 immediately before the call to set_iterator_to_next. Fixes cursor
4159 motion in bidi-reordered lines with stretch glyphs and strings
4160 displayed in margins. (Bug#8133) (Bug#8867)
4161 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4163 (pos_visible_p): Support positions in bidi-reordered lines.
4164 Save and restore bidi cache.
4166 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4167 (bidi_paragraph_info): Delete unused struct.
4168 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4169 (bidi_cache_start): New variable.
4170 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4172 (bidi_cache_fetch_state, bidi_cache_search)
4173 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4174 (bidi_cache_find, bidi_peek_at_next_level)
4175 (bidi_level_of_next_char, bidi_find_other_level_edge)
4176 (bidi_move_to_visually_next): Compare cache index with
4177 bidi_cache_start rather than with zero.
4178 (bidi_fetch_char): Accept new argument STRING; all callers
4179 changed. Support iteration over a string. Support strings with
4180 display properties. Support unibyte strings. Fix the type of
4181 `len' according to what STRING_CHAR_AND_LENGTH expects.
4182 (bidi_paragraph_init, bidi_resolve_explicit_1)
4183 (bidi_resolve_explicit, bidi_resolve_weak)
4184 (bidi_level_of_next_char, bidi_move_to_visually_next):
4185 Support iteration over a string.
4186 (bidi_set_sor_type, bidi_resolve_explicit_1)
4187 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4188 can now be zero (for strings); special values 0 and -1 were
4189 changed to -1 and -2, respectively.
4190 (bidi_char_at_pos): New function.
4191 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4192 Call it instead of FETCH_MULTIBYTE_CHAR.
4193 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4194 initialized to valid values.
4195 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4197 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4198 the test for valid cached positions. Fix the logic for looking up
4199 the sentinel state in the cache. GCPRO the Lisp string we are
4201 (bidi_push_it, bidi_pop_it): New functions.
4202 (bidi_initialize): Initialize the bidi cache start stack pointer.
4203 (bidi_cache_ensure_space): New function, refactored from part of
4204 bidi_cache_iterator_state. Don't assume the required size is just
4205 one BIDI_CACHE_CHUNK away.
4206 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4207 (bidi_count_bytes, bidi_char_at_pos): New functions.
4208 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4209 always valid if bidi_cache_idx is valid.
4210 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4211 is valid if it's going to be used.
4212 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4213 (bidi_cache_fetch_state, bidi_cache_search)
4214 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4215 (bidi_cache_iterator_state, bidi_cache_find)
4216 (bidi_find_other_level_edge, bidi_cache_start_stack):
4217 All variables related to cache indices are now EMACS_INT.
4219 * dispextern.h (struct bidi_string_data): New structure.
4220 (struct bidi_it): New member `string'. Make flag members be 1-bit
4221 fields, and put them last in the struct.
4222 (compute_display_string_pos, compute_display_string_end):
4224 (bidi_push_it, bidi_pop_it): Add prototypes.
4225 (struct iterator_stack_entry): New members bidi_p,
4226 paragraph_embedding, and from_disp_prop_p.
4227 (struct it): Member bidi_p is now a bit field 1 bit wide.
4228 (bidi_shelve_cache, bidi_unshelve_cache):
4231 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4232 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4233 and vector-like objects.
4235 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4236 cache around display iteration.
4238 * window.c (Fwindow_end, window_scroll_pixel_based)
4239 (displayed_window_lines, Frecenter): Save and restore the bidi
4240 cache around display iteration.
4242 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4244 * editfns.c (Fdelete_region): Clarify the use of the named
4245 parameters (bug#6788).
4247 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4249 * indent.c (Fvertical_motion): Set and restore w->pointm when
4250 saving and restoring the window's buffer (Bug#9006).
4252 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4254 * editfns.c (Fstring_to_char): Clarify just what is returned
4255 (bug#6576). Text by Eli Zaretskii.
4257 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4259 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4261 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4263 * buffer.c (mmap_find): Fix a typo.
4265 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4267 Fix execution of x selection hooks.
4268 * xselect.c (Qx_lost_selection_functions)
4269 (Qx_sent_selection_functions): New vars.
4270 (syms_of_xselect): DEFSYM them.
4271 (x_handle_selection_request): Pass Qx_sent_selection_functions
4272 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4273 (x_handle_selection_clear,x_clear_frame_selections):
4274 Pass Qx_lost_selection_functions rather than
4275 Vx_lost_selection_functions to Frun_hook_with_args.
4277 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4279 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4280 The old code sometimes used this field without initializing it.
4282 * alloc.c (gc_sweep): Don't read past end of array.
4283 In theory, the old code could also have corrupted Emacs internals,
4284 though it'd be very unlikely.
4286 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4288 * character.c (Fcharacterp): Don't advertise optional ignored
4289 argument. (Bug#4026)
4291 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4293 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4296 * window.c (Fset_window_start): Doc fix (bug#4199).
4297 (Fset_window_hscroll): Ditto.
4299 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4301 Fix minor new problems caught by GCC 4.6.1.
4302 * term.c (init_tty): Remove unused local.
4303 * xsettings.c (store_monospaced_changed): Define this function only
4304 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4307 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4309 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4311 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4313 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4314 are the mini-buffer and the echo area (bug#3320).
4316 * term.c (init_tty): Remove support for supdup, c10 and perq
4317 terminals, which are no longer supported (bug#1482).
4319 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4321 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4323 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4325 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4326 for non-popups (Bug#3642).
4328 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4330 * alloc.c (reset_malloc_hooks): Protoize.
4331 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4332 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4333 * cm.c (losecursor): Likewise.
4334 * data.c (fmod): Likewise.
4335 * dispnew.c (swap_glyphs_in_rows): Likewise.
4336 * emacs.c (memory_warning_signal): Likewise.
4337 * floatfns.c (float_error): Likewise.
4338 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4339 (otf_open, font_otf_capability, generate_otf_features)
4340 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4342 * image.c (pbm_read_file): Likewise.
4343 * indent.c (string_display_width): Likewise.
4344 * intervals.c (check_for_interval, search_for_interval)
4345 (inc_interval_count, count_intervals, root_interval)
4346 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4347 * lread.c (defalias): Likewise.
4348 * ralloc.c (r_alloc_check): Likewise.
4349 * regex.c (set_image_of_range_1, set_image_of_range)
4350 (regex_grow_registers): Likewise.
4351 * sysdep.c (strerror): Likewise.
4352 * termcap.c (valid_filename_p, tprint, main): Likewise.
4353 * tparam.c (main): Likewise.
4354 * unexhp9k800.c (run_time_remap, save_data_space)
4355 (update_file_ptrs, read_header, write_header, calculate_checksum)
4356 (copy_file, copy_rest, display_header): Likewise.
4357 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4359 * xdisp.c (check_it): Likewise.
4360 * xfaces.c (register_color, unregister_color, unregister_colors):
4362 * xfns.c (print_fontset_result): Likewise.
4363 * xrdb.c (member, fatal, main): Likewise.
4365 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4367 Fix minor problems found by static checking (Bug#9031).
4368 * chartab.c (char_table_set_range, map_sub_char_table):
4369 Remove unused locals.
4370 (uniprop_table): Now static.
4371 * composite.c (_work_char): Remove unused static var.
4373 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4375 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4377 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4379 * gtkutil.c (qttip_cb): Remove code without function.
4381 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4383 * w32.c (pthread_sigmask): New stub.
4385 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4387 Use pthread_sigmask, not sigprocmask (Bug#9010).
4388 sigprocmask is portable only for single-threaded applications, and
4389 Emacs can be multi-threaded when it uses GTK.
4390 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4392 * callproc.c (Fcall_process):
4393 * process.c (create_process):
4394 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4395 Use pthread_sigmask, not sigprocmask.
4397 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4399 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4400 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4403 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4405 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4406 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4407 (xg_hide_tooltip): Fix comment.
4409 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4410 in registerServicesMenuSendTypes.
4411 (validRequestorForSendType): Don't check ns_return_types.
4413 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4416 2011-07-08 Jason Rumney <jasonr@gnu.org>
4418 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4419 SH_SHOW for hidden windows (Bug#5482).
4421 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4422 frame struct members of non-existent frames (Bug#6284).
4424 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4426 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4427 variable firstTime not needed on OSX >= 10.6.
4428 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4429 >= 10.5. Use setKnobProportion, setDoubleValue.
4431 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4432 (MAC_OS_X_VERSION_10_5): Define if not defined.
4433 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4434 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4435 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4437 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4438 cString and lossyCString on OSX >= 10.4
4440 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4441 sizeToFit on OSX >= 10.2.
4443 * nsimage.m (allocInitFromFile): Don't use deprecated method
4444 bestRepresentationForDevice on OSX >= 10.6.
4446 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4449 * emacs.c: Declare unexec_init_emacs_zone.
4451 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4453 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4455 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4456 on svcsMenu (Bug#8842).
4458 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4460 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4462 * nsterm.m (QUTF8_STRING): Declare.
4463 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4464 (validRequestorForSendType): Return type is (id).
4465 Change indexOfObjectIdenticalTo to indexOfObject.
4466 Check if we have local selection before returning self (Bug#8842).
4467 (writeSelectionToPasteboard): Put local selection into paste board
4468 if we have a local selection (Bug#8842).
4469 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4471 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4472 (ns_get_local_selection): Declare.
4474 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4476 * keymap.c (describe_map_tree): Don't insert a double newline at
4477 the end of the buffer (bug#1169) and return whether we inserted
4480 * callint.c (Fcall_interactively): Change "reading args" to
4481 "providing args" to try to clarify what it does (bug#1010).
4483 2011-07-07 Kenichi Handa <handa@m17n.org>
4485 * composite.c (composition_compute_stop_pos): Ignore a static
4486 composition starting before CHARPOS (Bug#8915).
4488 * xdisp.c (handle_composition_prop): Likewise.
4490 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4492 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4495 2011-07-07 Kenichi Handa <handa@m17n.org>
4497 * character.h (unicode_category_t): New enum type.
4499 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4500 (Qchar_code_property_table): New variable.
4501 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4502 (UNIPROP_COMPRESSED_FORM_P): New macros.
4503 (char_table_ascii): Uncompress the compressed values.
4504 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4505 Uncompress the compressed values.
4506 (sub_char_table_ref_and_range): Likewise.
4507 (char_table_ref_and_range): Uncompress the compressed values.
4508 (sub_char_table_set): New arg is_uniprop. Callers changed.
4509 Uncompress the compressed values.
4510 (sub_char_table_set_range): Args changed. Callers changed.
4511 (char_table_set_range): Adjuted for the above change.
4512 (map_sub_char_table): Delete args default_val and parent. Add arg
4513 top. Give decoded values to a Lisp function.
4514 (map_char_table): Adjust for the above change. Give decoded
4515 values to a Lisp function. Gcpro more variables.
4516 (uniprop_table_uncompress)
4517 (uniprop_decode_value_run_length): New functions.
4518 (uniprop_decoder, uniprop_decoder_count): New variables.
4519 (uniprop_get_decoder, uniprop_encode_value_character)
4520 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4522 (uniprop_encoder, uniprop_encoder_count): New variables.
4523 (uniprop_get_encoder, uniprop_table)
4524 (Funicode_property_table_internal, Fget_unicode_property_internal)
4525 (Fput_unicode_property_internal): New functions.
4526 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4527 Sunicode_property_table_internal, Sget_unicode_property_internal,
4528 and Sput_unicode_property_internal. Defvar_lisp
4529 char-code-property-alist.
4531 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4532 Vunicode_category_table.
4534 * font.c (font_range): Adjust for the change of
4535 Vunicode_category_table.
4537 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4539 * m/iris4d.h: Remove file, move contents ...
4540 * s/irix6-5.h: ... here.
4542 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4544 Remove unportable assumption about struct layout (Bug#8884).
4545 * alloc.c (mark_buffer):
4546 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4547 (clone_per_buffer_values): Don't assume that
4548 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4549 This isn't true in general, and it's particularly not true
4550 if Emacs is configured with --with-wide-int.
4551 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4552 New macros, used in the buffer.c change.
4554 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4556 * xsettings.c: Use both GConf and GSettings if both are available.
4557 (store_config_changed_event): Add comment.
4558 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4559 (store_tool_bar_style_changed): New functions.
4560 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4561 (struct xsettings): Move font inside HAVE_XFT.
4562 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4563 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4564 Move inside HAVE_XFT.
4565 (something_changed_gsettingsCB): Rename from something_changedCB.
4566 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4568 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4569 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4570 (something_changed_gconfCB): Rename from something_changedCB.
4571 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4572 (parse_settings): Move check for font inside HAVE_XFT.
4573 (read_settings, apply_xft_settings): Add comment.
4574 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4575 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4576 call store_font_name_changed.
4577 (xft_settings_event): Add comment.
4578 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4579 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4580 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4581 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4582 (xsettings_initialize): Call init_gsettings last.
4583 (xsettings_get_system_font, xsettings_get_system_normal_font):
4586 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4588 Random fixes. E.g., (random) never returned negative values.
4589 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4590 subseconds part to the entropy, as that's a bit more random.
4591 Prefer signed to unsigned, since the signedness doesn't matter and
4592 in general we prefer signed. When given a limit, use a
4593 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4594 latter isn't right if USE_2_TAGS_FOR_INTS.
4595 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4596 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4598 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4600 * textprop.c (text_property_stickiness):
4601 Obey Vtext_property_default_nonsticky.
4602 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4603 * w32fns.c (syms_of_w32fns):
4604 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4606 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4608 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4609 This is more efficient than Ffile_directory_p and avoids a minor race.
4611 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4613 * buffer.c (Foverlay_put): Say what the return value is
4616 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4617 is a directory before asking whether to use the file name
4619 (barf_or_query_if_file_exists): Make the "File is a directory"
4620 error be more correct.
4622 * fns.c (Frequire): Remove the mention of the .gz files, since
4623 that's installation-specific, but keep the mention of
4624 `get-load-suffixes'.
4626 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4628 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4629 Report string overflow if the output is too long.
4631 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4633 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4634 (syms_of_gnutls): Remove duplicate DEFSYM for
4635 Qgnutls_bootprop_verify_hostname_error, an error for
4636 Qgnutls_bootprop_verify_error (which is no longer used).
4638 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4639 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4640 Also (re)move comments that are misplaced or no longer relevant.
4642 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4644 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4646 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4648 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4649 and background color parameters if they have been changed.
4651 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4653 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4655 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4657 * xsettings.c (SYSTEM_FONT): Define only when used.
4658 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4660 * keymap.c (access_keymap_1): Now static.
4662 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4664 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4665 leave any prefix arg for the up event (Bug#1586).
4667 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4669 * lread.c (syms_of_lread): Mention single symbols defined by
4670 `defvar' or `defconst' (bug#7154).
4672 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4673 (Frequire): Mention get-load-suffixes.
4675 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4677 * window.h (window): Remove clone_number slot.
4678 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4680 (make_parent_window, make_window, saved_window)
4681 (Fset_window_configuration, save_window_save): Don't deal with
4683 * buffer.c (Qclone_number): Remove declaration.
4684 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4686 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4688 Add multiple inheritance to keymaps.
4689 * keymap.c (Fmake_composed_keymap): New function.
4690 (Fset_keymap_parent): Simplify.
4691 (fix_submap_inheritance): Remove.
4692 (access_keymap_1): New function extracted from access_keymap to handle
4693 embedded parents and handle lists of maps.
4694 (access_keymap): Use it.
4695 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4696 (Fcopy_keymap): Handle embedded parents.
4697 (Fcommand_remapping, define_as_prefix): Simplify.
4698 (Fkey_binding): Simplify.
4699 (syms_of_keymap): Move minibuffer-local-completion-map,
4700 minibuffer-local-filename-completion-map,
4701 minibuffer-local-must-match-map, and
4702 minibuffer-local-filename-must-match-map to Elisp.
4703 (syms_of_keymap): Defsubr make-composed-keymap.
4704 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4705 (parse_menu_item): Trivial simplification.
4707 2011-07-01 Glenn Morris <rgm@gnu.org>
4709 * Makefile.in (SETTINGS_LIBS): Fix typo.
4711 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4713 * coding.c (Fencode_coding_string): Record the last coding system
4714 used, as the function doc string says (bug#8738).
4716 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4718 * xsettings.c (store_monospaced_changed): Take new font as arg and
4719 check for change against current_mono_font.
4720 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4721 (emacs_settings_constructor, emacs_settings_get_property)
4722 (emacs_settings_set_property, emacs_settings_class_init)
4723 (emacs_settings_init, gsettings_obj): Remove.
4724 (something_changedCB): New function for HAVE_GSETTINGS.
4725 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4726 with value as argument.
4727 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4728 g_settings_new (Bug#8967). Do not create gsettings_obj.
4729 Remove calls to g_settings_bind. Connect something_changedCB to
4732 * xgselect.c: Add defined (HAVE_GSETTINGS).
4733 (xgselect_initialize): Ditto.
4735 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4736 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4739 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4741 * eval.c (struct backtrace): Simplify and port the data structure.
4742 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4743 signed bit field, as this assumption is not portable and it makes
4744 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4745 "char debug_on_exit : 1" as this is not portable either; instead,
4746 use the portable "unsigned int debug_on_exit : 1". Remove unused
4747 member evalargs. Remove obsolete comments about cc bombing out.
4749 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4751 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4752 Let HAVE_GSETTINGS override HAVE_GCONF.
4753 (store_monospaced_changed): New function.
4754 (EMACS_SETTINGS): A new type derived from GObject to handle
4755 GSettings notifications.
4756 (emacs_settings_constructor, emacs_settings_get_property)
4757 (emacs_settings_set_property, emacs_settings_class_init):
4759 (gsettings_client, gsettings_obj): New variables.
4760 (GSETTINGS_SCHEMA): New define.
4761 (something_changedCB): Call store_monospaced_changed.
4762 (init_gsettings): New function.
4763 (xsettings_initialize): Call init_gsettings.
4764 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4767 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4770 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4772 * window.c (resize_root_window, grow_mini_window)
4773 (shrink_mini_window): Rename Qresize_root_window to
4774 Qwindow_resize_root_window and Qresize_root_window_vertically to
4775 Qwindow_resize_root_window_vertically.
4777 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4779 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4781 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4783 * makefile.w32-in: Redesign dependencies so they reflect more
4784 clearly which files are directly included by each source file,
4785 and not through other includes.
4787 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4789 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4790 (sort_overlays, overlay_strings): When an overlay's clone number
4791 matches the window's clone number process the overlay even if
4792 the overlay's window property doesn't match the current window.
4794 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4795 (Fwindow_hchild): Rename to Fwindow_left_child.
4796 (Fwindow_next): Rename to Fwindow_next_sibling.
4797 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4798 (resize_window_check): Rename to window_resize_check.
4799 (resize_window_apply): Rename to window_resize_apply.
4800 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4801 (Fdelete_other_windows_internal, resize_frame_windows)
4802 (Fsplit_window_internal, Fdelete_window_internal)
4803 (grow_mini_window, shrink_mini_window)
4804 (Fresize_mini_window_internal): Fix callers accordingly.
4806 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4808 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4809 (emacs_fixed_set_min_size): Remove.
4810 (emacs_fixed_new): Take frame as argument.
4812 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4813 (_EmacsFixedPrivate): Remove minwidth/height.
4814 Add struct frame *f.
4815 (emacs_fixed_init): Initialize priv->f.
4816 (get_parent_class, emacs_fixed_set_min_size): Remove.
4817 (emacs_fixed_new): Set priv->f to argument.
4818 (emacs_fixed_get_preferred_width)
4819 (emacs_fixed_get_preferred_height): Use min_width/height from
4820 frames size_hint to set minimum and natural (Bug#8919).
4821 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4822 and use min_width/height from frames size_hint to set
4823 min_width/height (Bug#8919).
4825 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4826 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4829 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4831 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4832 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4835 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4837 * process.c (wait_reading_process_output): Bypass select if
4838 waiting for a cell while ignoring keyboard input, and input is
4839 pending. Suggested by Jan Djärv (Bug#8869).
4841 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4843 Use gnulib's dup2 module instead of rolling our own.
4844 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4846 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4848 * dispnew.c (scrolling_window): Before scrolling, turn off a
4849 mouse-highlight in the window being scrolled.
4851 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4853 Move DEFSYM to lisp.h and use everywhere.
4855 * character.h (DEFSYM): Move declaration...
4856 * lisp.h (DEFSYM): ...here.
4862 * w32select.c: Don't include character.h.
4864 * alloc.c (syms_of_alloc):
4865 * buffer.c (syms_of_buffer):
4866 * bytecode.c (syms_of_bytecode):
4867 * callint.c (syms_of_callint):
4868 * casefiddle.c (syms_of_casefiddle):
4869 * casetab.c (init_casetab_once):
4870 * category.c (init_category_once, syms_of_category):
4871 * ccl.c (syms_of_ccl):
4872 * cmds.c (syms_of_cmds):
4873 * composite.c (syms_of_composite):
4874 * dbusbind.c (syms_of_dbusbind):
4875 * dired.c (syms_of_dired):
4876 * dispnew.c (syms_of_display):
4877 * doc.c (syms_of_doc):
4878 * editfns.c (syms_of_editfns):
4879 * emacs.c (syms_of_emacs):
4880 * eval.c (syms_of_eval):
4881 * fileio.c (syms_of_fileio):
4882 * fns.c (syms_of_fns):
4883 * frame.c (syms_of_frame):
4884 * fringe.c (syms_of_fringe):
4885 * insdel.c (syms_of_insdel):
4886 * keymap.c (syms_of_keymap):
4887 * lread.c (init_obarray, syms_of_lread):
4888 * macros.c (syms_of_macros):
4889 * msdos.c (syms_of_msdos):
4890 * print.c (syms_of_print):
4891 * process.c (syms_of_process):
4892 * search.c (syms_of_search):
4893 * sound.c (syms_of_sound):
4894 * syntax.c (init_syntax_once, syms_of_syntax):
4895 * terminal.c (syms_of_terminal):
4896 * textprop.c (syms_of_textprop):
4897 * undo.c (syms_of_undo):
4898 * w32.c (globals_of_w32):
4899 * window.c (syms_of_window):
4900 * xdisp.c (syms_of_xdisp):
4901 * xfaces.c (syms_of_xfaces):
4902 * xfns.c (syms_of_xfns):
4903 * xmenu.c (syms_of_xmenu):
4904 * xsettings.c (syms_of_xsettings):
4905 * xterm.c (syms_of_xterm): Use DEFSYM.
4907 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4909 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4911 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4913 Integer and buffer overflow fixes (Bug#8873).
4915 * print.c (printchar, strout): Check for string overflow.
4916 (PRINTPREPARE, printchar, strout):
4917 Don't set size unless allocation succeeds.
4919 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4920 for sizes. Check for string overflow more accurately.
4921 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4923 * macros.c: Integer and buffer overflow fixes.
4924 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4925 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4926 Use ptrdiff_t, not int, for sizes.
4927 Don't increment bufsize until after realloc succeeds.
4928 Check for size-calculation overflow.
4929 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4931 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4933 * lread.c: Integer overflow fixes.
4934 (read_integer): Radix is now EMACS_INT, not int,
4935 to improve quality of diagnostics for out-of-range radices.
4936 Calculate buffer size correctly for out-of-range radices.
4937 (read1): Check for integer overflow in radices, and in
4938 read-circle numbers.
4939 (read_escape): Avoid int overflow.
4940 (Fload, openp, read_buffer_size, read1)
4941 (substitute_object_recurse, read_vector, read_list, map_obarray):
4942 Use ptrdiff_t, not int, for sizes.
4943 (read1): Use EMACS_INT, not int, for sizes.
4944 Check for size overflow.
4946 * image.c (cache_image): Check for size arithmetic overflow.
4948 * lread.c: Integer overflow issues.
4949 (saved_doc_string_size, saved_doc_string_length)
4950 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4951 Now ptrdiff_t, not int.
4952 (read1): Don't assume doc string length fits in int. Check for
4953 out-of-range doc string lengths.
4954 (read_list): Don't assume file position fits in int.
4955 (read_escape): Check for hex character overflow.
4957 2011-06-22 Leo Liu <sdl.web@gmail.com>
4959 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4960 Move to minibuffer.el.
4962 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4964 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4965 The following patches are for when GLYPH_DEBUG && !XASSERT.
4966 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4967 * dispnew.c (flush_stdout):
4968 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4969 Mark as externally visible.
4970 * dispnew.c (check_window_matrix_pointers): Now static.
4971 * dispnew.c (window_to_frame_vpos):
4972 * xfns.c (unwind_create_frame):
4973 * xterm.c (x_check_font): Remove unused local.
4974 * scroll.c (CHECK_BOUNDS):
4975 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4976 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4977 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4978 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4979 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4981 (debug_method_add): Use va_list and vsprintf rather than relying
4982 on undefined behavior with wrong number of arguments.
4983 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4984 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4985 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4986 since we're not interested in debugging glyphs with old libraries.
4987 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4988 GCC 4.6.0's static checking.
4990 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4992 Integer overflow and signedness fixes (Bug#8873).
4993 A few related buffer overrun fixes, too.
4995 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4997 * dispextern.h (struct face.stipple):
4998 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4999 (x_bitmap_mask, x_allocate_bitmap_record)
5000 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5001 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5002 (x_create_bitmap_from_xpm_data):
5003 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5004 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5006 * xfaces.c (load_pixmap):
5007 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5008 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5009 (.bitmaps_last, struct x_output.icon_bitmap):
5010 Use ptrdiff_t, not int, for bitmap indexes.
5011 (x_allocate_bitmap_record): Check for size overflow.
5012 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5014 Use ptrdiff_t, not int, for overlay counts.
5015 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5016 * editfns.c (overlays_around, get_pos_property):
5017 * textprop.c (get_char_property_and_overlay):
5018 * xdisp.c (next_overlay_change, note_mouse_highlight):
5019 * xfaces.c (face_at_buffer_position):
5020 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5021 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5022 (Fnext_overlay_change, Fprevious_overlay_change)
5023 (mouse_face_overlay_overlaps, Foverlays_in):
5024 Use ptrdiff_t, not int, for sizes.
5025 (overlays_at, overlays_in): Check for size-calculation overflow.
5027 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5029 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5030 (x_session_initialize): Do not assume string length fits in int.
5032 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5033 This is unlikely, but can occur if DPI is outlandish.
5035 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
5036 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5038 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5039 * xrdb.c (magic_file_p, search_magic_path):
5040 Omit last arg SUFFIX; it was always 0. All callers changed.
5041 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5043 * xfont.c (xfont_match): Avoid need for strlen.
5045 * xfns.c: Don't assume strlen fits in int.
5046 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5048 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5049 not unsigned long, as we prefer signed integers. All callers changed.
5050 Detect integer overflow in repeat count.
5051 (message_dolog): Don't assume print length fits in 39 bytes.
5052 (display_mode_element): Don't assume strlen fits in int.
5054 * termcap.c: Don't assume sizes fit in int and never overflow.
5055 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5056 (gobble_line): Check for size-calculation overflow.
5058 * minibuf.c (Fread_buffer):
5059 * lread.c (intern, intern_c_string):
5060 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5061 Don't assume string length fits in int.
5063 * keyboard.c (parse_tool_bar_item):
5064 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5066 * font.c: Don't assume string length fits in int.
5067 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5068 Use ptrdiff_t, not int.
5069 (font_intern_prop): Don't assume string length fits in int.
5070 Don't assume integer property fits in fixnum.
5071 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5073 * filelock.c: Fix some buffer overrun and integer overflow issues.
5074 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5075 Reformulate so as not to need the command string.
5076 Invoke gzip -cd rather than gunzip, as it's more portable.
5077 (lock_info_type, lock_file_1, lock_file):
5078 Don't assume pid_t and time_t fit in unsigned long.
5079 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5080 (current_lock_owner): Prefer signed type for sizes.
5081 Use memcpy, not strncpy, where memcpy is what is really wanted.
5082 Don't assume (via atoi) that time_t and pid_t fit in int.
5083 Check for time_t and/or pid_t out of range, e.g., via a network share.
5084 Don't alloca where an auto var works fine.
5086 * fileio.c: Fix some integer overflow issues.
5087 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5088 Don't assume string length fits in int.
5089 (directory_file_name): Don't assume string length fits in long.
5090 (make_temp_name): Don't assume pid fits in int, or that its print
5091 length is less than 20.
5093 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5095 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5097 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5099 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5100 We prefer signed integers, even for size calculations.
5102 * emacs.c: Don't assume string length fits in 'int'.
5103 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5104 (main): Don't invoke strlen when not needed.
5106 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5107 (XD_DEBUG_MESSAGE): Don't waste a byte.
5109 * callproc.c (getenv_internal_1, getenv_internal)
5111 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5113 * lread.c (invalid_syntax): Omit length argument.
5114 All uses changed. This doesn't fix a bug, but it simplifies the
5115 code away from its former Hollerith-constant appearance, and it's
5116 one less 'int' to worry about when looking at integer-overflow issues.
5117 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5119 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5120 This didn't break anything, but it didn't help either.
5121 It's confusing to put a bogus integer in a place where the actual
5122 value does not matter.
5123 (LIST_END_P): Remove unused macro and its bogus comment.
5124 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5126 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5127 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5129 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5130 We prefer signed types, and the value cannot exceed the EMACS_INT
5131 range anyway (because otherwise the length would not be representable).
5132 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5133 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5134 This avoids a GCC warning when WIDE_EMACS_INT.
5136 * indent.c (sane_tab_width): New function.
5137 (current_column, scan_for_column, Findent_to, position_indentation)
5138 (compute_motion): Use it. This is just for clarity.
5139 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5141 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5143 * lisp.h (lint_assume): New macro.
5144 * composite.c (composition_gstring_put_cache):
5145 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5147 * editfns.c, insdel.c:
5148 Omit unnecessary forward decls, to simplify future changes.
5150 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5152 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5154 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5155 Use much-faster test for byte-length change.
5156 Don't assume string byte-length fits in 'int'.
5157 Check that character arg fits in 'int'.
5158 (mapcar1): Declare byte as byte, for clarity.
5160 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5162 * fns.c (concat): Catch string overflow earlier.
5163 Do not rely on integer wraparound.
5165 * dispextern.h (struct it.overlay_strings_charpos)
5166 (struct it.selective): Now EMACS_INT, not int.
5167 * xdisp.c (forward_to_next_line_start)
5168 (back_to_previous_visible_line_start)
5169 (reseat_at_next_visible_line_start, next_element_from_buffer):
5170 Don't arbitrarily truncate the value of 'selective' to int.
5172 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5174 * composite.c: Don't truncate sizes to 'int'.
5175 (composition_gstring_p, composition_reseat_it)
5176 (composition_adjust_point): Use EMACS_INT, not int.
5177 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5178 not EMACS_UINT, for indexes.
5180 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5182 * buffer.c: Include <verify.h>.
5183 (struct sortvec.priority, struct sortstr.priority):
5184 Now EMACS_INT, not int.
5185 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5186 (struct sortstr.size, record_overlay_string)
5187 (struct sortstrlist.size, struct sortlist.used):
5188 Don't truncate size to int.
5189 (record_overlay_string): Check for size-calculation overflow.
5190 (init_buffer_once): Check at compile-time, not run-time.
5192 2011-06-22 Jim Meyering <meyering@redhat.com>
5194 Don't leak an XBM-image-sized buffer
5195 * image.c (xbm_load): Free the image buffer after using it.
5197 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5200 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5201 that Sun C diagnosed.
5202 * fns.c (secure_hash): Fix pointer signedness issue.
5203 * intervals.c (static_offset_intervals): New function.
5204 (offset_intervals): Use it.
5206 2011-06-21 Leo Liu <sdl.web@gmail.com>
5209 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5212 * fns.c (secure_hash): Rename from crypto_hash_function and change
5213 the first arg to accept symbols.
5214 (Fsecure_hash): New primitive.
5215 (syms_of_fns): New symbols.
5217 2011-06-20 Deniz Dogan <deniz@dogan.se>
5219 * process.c (Fset_process_buffer): Clarify return value in
5222 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5224 * dispnew.c (add_window_display_history): Use BVAR.
5226 * xdisp.c (debug_method_add): Use BVAR.
5227 (check_window_end, dump_glyph_matrix, dump_glyph)
5228 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5230 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5233 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5234 check till after the cache is created in init_frame_faces.
5236 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5238 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5240 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5242 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5243 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5244 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5246 Improve buffer-overflow checking (Bug#8873).
5247 * fileio.c (Finsert_file_contents):
5248 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5249 Remove the old (too-loose) buffer overflow checks.
5250 They weren't needed, since make_gap checks for buffer overflow.
5251 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5252 The old code merely checked for Emacs fixnum overflow, and relied
5253 on undefined (wraparound) behavior. The new code avoids undefined
5254 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5256 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5257 Tune. Don't use wider integers than needed. Don't use alloca.
5258 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5260 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5262 * insdel.c, lisp.h (buffer_overflow): New function.
5263 (insert_from_buffer_1, replace_range, replace_range_2):
5264 * insdel.c (make_gap_larger):
5265 * editfns.c (Finsert_char):
5266 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5268 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5270 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5272 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5274 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5275 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5277 * fileio.c: Don't assume EMACS_INT fits in off_t.
5278 (emacs_lseek): New static function.
5279 (Finsert_file_contents, Fwrite_region): Use it.
5280 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5282 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5284 * fns.c: Don't overflow int when computing a list length.
5285 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5286 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5287 truncation on 64-bit hosts. Check for QUIT every
5288 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5289 faster and is responsive enough.
5290 (Flength): Report an error instead of overflowing an integer.
5291 (Fsafe_length): Return a float if the value is not representable
5292 as a fixnum. This shouldn't happen except in contrived situations.
5293 (Fnthcdr, Fsort): Don't assume list length fits in int.
5294 (Fcopy_sequence): Don't assume vector length fits in int.
5296 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5297 (header_size, word_size): New constants.
5298 (allocate_vectorlike): Don't check size overflow here.
5299 (allocate_vector): Check it here instead, since this is the only
5300 caller of allocate_vectorlike that could cause overflow.
5301 Check that the new vector's length is representable as a fixnum.
5303 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5304 The previous code was bogus. For example, next_almost_prime (32)
5305 returned 39, which is undesirable as it is a multiple of 3; and
5306 next_almost_prime (24) returned 25, which is a multiple of 5 so
5307 why was the code bothering to check for multiples of 7?
5309 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5311 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5313 Variadic C functions now count arguments with ptrdiff_t.
5314 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5315 Back then I didn't know that the Emacs coding style prefers signed int.
5316 Also, in the meantime I found a few more instances where arguments
5317 were being counted with int, which may truncate counts on 64-bit
5318 machines, or EMACS_INT, which may be unnecessarily wide.
5319 * lisp.h (struct Lisp_Subr.function.aMANY)
5320 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5321 Arg counts are now ptrdiff_t, not size_t.
5322 All variadic functions and their callers changed accordingly.
5323 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5324 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5325 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5326 * callint.c (Fcall_interactively): Check arg count for overflow,
5327 to avoid potential buffer overrun. Use signed char, not 'int',
5328 for 'varies' array, so that we needn't bother to check its size
5329 calculation for overflow.
5330 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5331 * eval.c (apply_lambda):
5332 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5333 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5334 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5336 * callint.c (Fcall_interactively): Don't use index var as event count.
5338 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5339 * mem-limits.h (SIZE): Remove; no longer used.
5341 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5343 Remove unnecessary casts.
5344 * xterm.c (x_term_init):
5345 * xfns.c (x_set_border_pixel):
5346 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5347 These aren't needed now that we assume ANSI C.
5349 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5350 It's more likely to cause problems (due to unsigned overflow)
5353 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5355 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5357 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5359 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5361 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5363 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5365 GLYPH_CODE_FACE returns EMACS_INT, not int.
5366 * dispextern.h (merge_faces):
5367 * xfaces.c (merge_faces):
5368 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5369 Don't assume EMACS_INT fits in int.
5371 * character.h (CHAR_VALID_P): Remove unused parameter.
5372 * fontset.c, lisp.h, xdisp.c: All uses changed.
5374 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5376 * fns.c (concat): Minor tuning based on overflow analysis.
5377 This doesn't fix any bugs. Use int to hold character, instead
5378 of constantly refetching from Emacs object. Use XFASTINT, not
5379 XINT, for value known to be a character. Don't bother comparing
5380 a single byte to 0400, as it's always less.
5382 * floatfns.c (Fexpt):
5383 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5385 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5388 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5390 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5391 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5392 incorrectly succeed when S was a string, because 4294967386 was
5393 truncated before it was used.
5395 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5396 Otherwise, an out-of-range integer could cause undefined behavior
5399 * composite.c: Use int, not EMACS_INT, for characters.
5400 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5401 EMACS_INT, for values that are known to be in character range.
5402 This doesn't fix any bugs but is the usual style inside Emacs and
5403 may generate better code on 32-bit machines.
5405 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5406 This is for reasons similar to the recent CHAR_STRING fix.
5407 * charset.c (Fencode_char): Check that character arg is actually
5408 a character. Pass an int to ENCODE_CHAR.
5409 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5410 wider than 'int', as a compile-time check to prevent future regressions
5413 * character.c (char_string): Remove unnecessary casts.
5415 Make sure a 64-bit char is never passed to CHAR_STRING.
5416 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5417 by silently ignoring the top 32 bits, allowing some values
5418 that were far too large to be valid characters.
5419 * character.h: Include <verify.h>.
5420 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5421 arguments are no wider than unsigned, as a compile-time check
5422 to prevent future regressions in this area.
5424 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5425 (Fsubst_char_in_region):
5427 * xdisp.c (decode_mode_spec_coding):
5428 Adjust to CHAR_STRING's new requirement.
5429 * editfns.c (Finsert_char, Fsubst_char_in_region):
5430 * fns.c (concat): Check that character args are actually
5431 characters. Without this test, these functions did the wrong
5432 thing with wildly out-of-range values on 64-bit hosts.
5434 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5435 These casts should not be needed on 32-bit hosts, either.
5436 * keyboard.c (read_char):
5437 * lread.c (Fload): Remove casts to unsigned.
5439 * lisp.h (UNSIGNED_CMP): New macro.
5440 This fixes comparison bugs on 64-bit hosts.
5441 (ASCII_CHAR_P): Use it.
5442 * casefiddle.c (casify_object):
5443 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5444 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5445 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5446 * dispextern.h (FACE_FROM_ID):
5447 * keyboard.c (read_char): Use UNSIGNED_CMP.
5449 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5450 not to EMACS_INT, to avoid GCC warning.
5452 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5454 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5455 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5456 isn't needed on 32-bit machines.
5458 * buffer.c (Fgenerate_new_buffer_name):
5459 Use EMACS_INT for count, not int.
5460 (advance_to_char_boundary): Return EMACS_INT, not int.
5462 * data.c (Qcompiled_function): Now static.
5464 * window.c (window_body_lines): Now static.
5466 * image.c (gif_load): Rename local to avoid shadowing.
5468 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5469 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5470 * alloc.c (make_save_value): Integer argument is now of type
5472 (mark_object): Use ptrdiff_t, not int.
5473 * lisp.h (pD): New macro.
5474 * print.c (print_object): Use it.
5476 * alloc.c: Use EMACS_INT, not int, to count objects.
5477 (total_conses, total_markers, total_symbols, total_vector_size)
5478 (total_free_conses, total_free_markers, total_free_symbols)
5479 (total_free_floats, total_floats, total_free_intervals)
5480 (total_intervals, total_strings, total_free_strings):
5481 Now EMACS_INT, not int. All uses changed.
5482 (Fgarbage_collect): Compute overall total using a double, so that
5483 integer overflow is less likely to be a problem. Check for overflow
5484 when converting back to an integer.
5485 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5486 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5487 These were 'int' variables that could overflow on 64-bit hosts;
5488 they were never used, so remove them instead of repairing them.
5489 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5490 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5491 Previously, this ceilinged at INT_MAX, but that doesn't work on
5493 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5495 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5496 (allocate_vectorlike): Check for ptrdiff_t overflow.
5497 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5498 when a (possibly-narrower) signed value would do just as well.
5499 We prefer using signed arithmetic, to avoid comparison confusion.
5501 * alloc.c: Catch some string size overflows that we were missing.
5502 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5503 for convenience in STRING_BYTES_MAX.
5504 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5505 The definition here is exact; the one in lisp.h was approximate.
5506 (allocate_string_data): Check for string overflow. This catches
5507 some instances we weren't catching before. Also, it catches
5508 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5509 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5510 and ptrdiff_t and EMACS_INT are both 64 bits.
5512 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5513 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5514 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5516 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5518 * alloc.c (Fmake_string): Check for out-of-range init.
5520 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5522 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5524 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5526 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5527 xg_get_default_scrollbar_width.
5529 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5530 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5531 (style_changed_cb): Call update_theme_scrollbar_width and call
5532 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5533 all frames (Bug#8505).
5534 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5535 Call gtk_window_set_resizable if HAVE_GTK3.
5536 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5537 and height if HAVE_GTK3 (Bug#8505).
5538 (scroll_bar_width_for_theme): New variable.
5539 (update_theme_scrollbar_width): New function.
5540 (xg_get_default_scrollbar_width): Move code to
5541 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5542 (xg_initialize): Call update_theme_scrollbar_width.
5544 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5546 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5548 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5550 * frame.c (make_frame): Call other_buffer_safely instead of
5553 * window.c (temp_output_buffer_show): Call display_buffer with
5554 second argument Vtemp_buffer_show_specifiers and reset latter
5555 immediately after the call.
5556 (Vtemp_buffer_show_specifiers): New variable.
5557 (auto_window_vscroll_p, next_screen_context_lines)
5558 (Vscroll_preserve_screen_position): Remove leading asterisks from
5561 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5563 Fix minor problems found by GCC 4.6.0 static checking.
5564 * buffer.c (Qclone_number): Remove for now, as it's unused.
5565 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5566 (record_buffer): Remove unused local.
5567 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5568 (set_frame_buffer_list): Remove; unused.
5569 * frame.h (other_visible_frames): Remove decl.
5570 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5571 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5572 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5574 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5575 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5576 Define only if HAVE_GPM.
5577 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5578 (update_hints_inhibit): Remove; never set. All uses removed.
5579 * widgetprv.h (emacsFrameClassRec): Remove decl.
5580 * window.c (delete_deletable_window): Now returns void, since it
5581 wasn't returning anything.
5582 (compare_window_configurations): Remove unused locals.
5583 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5584 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5585 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5586 the same widths as pointers. This follows up on the 2011-05-06 patch.
5587 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5588 * xterm.h: Likewise.
5589 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5591 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5593 * makefile.w32-in: Update dependencies.
5594 (LISP_H): Add lib/intprops.h.
5596 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5598 * image.c (gif_load): Add animation frame delay to the metadata.
5599 (syms_of_image): Use DEFSYM. New symbol `delay'.
5601 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5603 * window.c (delete_deletable_window): Re-add.
5604 (Fset_window_configuration): Rewrite to handle dead buffers and
5605 consequently deletable windows.
5606 (window_tree, Fwindow_tree): Remove. Supply functionality in
5608 (compare_window_configurations): Simplify code.
5610 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5612 * image.c (imagemagick_load_image): Fix type mismatch.
5613 (Fimagemagick_types): Likewise.
5615 * window.h (replace_buffer_in_windows): Declare.
5617 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5619 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5620 Qclone_number. Remove external declaration of Qdelete_window.
5621 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5623 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5624 Run Qbuffer_list_update_hook if allowed.
5625 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5626 buffer list implementation.
5627 (other_buffer_safely): New function.
5628 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5629 calls to replace_buffer_in_windows and
5630 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5632 (record_buffer): Inhibit quitting and rewrite using quittable
5633 functions. Run Qbuffer_list_update_hook if allowed.
5634 (Frecord_buffer, Funrecord_buffer): New functions.
5635 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5636 Move switch-to-buffer to window.el.
5637 (bury-buffer): Move to window.el.
5638 (Vbuffer_list_update_hook): New variable.
5640 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5643 * window.h (resize_frame_windows): Move up in code.
5644 (Fwindow_frame): Remove EXFUN.
5645 (replace_buffer_in_all_windows): Remove prototype.
5646 (replace_buffer_in_windows_safely): Add prototype.
5648 * window.c: Declare Qdelete_window static again. Move down
5649 declaration of select_count.
5650 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5651 (Fother_window): Move to window.el.
5652 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5653 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5654 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5656 (replace_buffer_in_windows): Implement by calling
5657 Qreplace_buffer_in_windows.
5658 (replace_buffer_in_all_windows): Remove with some functionality
5659 moved into replace_buffer_in_windows_safely.
5660 (replace_buffer_in_windows_safely): New function.
5661 (select_window_norecord, select_frame_norecord): Move in front
5662 of run_window_configuration_change_hook. Remove now obsolete
5664 (Fset_window_buffer): Rewrite doc-string.
5665 Call Qrecord_window_buffer.
5666 (keys_of_window): Move binding for other-window to window.el.
5668 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5670 * dispextern.h (struct image): Replace data member, whose int_val
5671 and ptr_val fields were not used by anything, with a single
5674 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5675 (gif_clear_image, gif_load, imagemagick_load_image)
5676 (gs_clear_image, gs_load): Callers changed.
5678 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5680 * buffer.h: Include <time.h>, for time_t.
5681 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5683 Fix minor problems found by static checking.
5685 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5687 Make identifiers static if they are not used in other modules.
5688 * data.c (Qcompiled_function, Qframe, Qvector):
5689 * image.c (QimageMagick, Qsvg):
5690 * minibuf.c (Qmetadata):
5691 * window.c (resize_window_check, resize_root_window): Now static.
5692 * window.h (resize_window_check, resize_root_window): Remove decls.
5694 * window.c (window_deletion_count, delete_deletable_window):
5696 (window_body_lines): Now static.
5697 (Fdelete_other_windows_internal): Mark vars as initialized.
5698 Make sure 'resize_failed' is initialized.
5699 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5700 (resize_window_apply): Remove unused local.
5701 * window.h (delete_deletable_window): Remove decl.
5703 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5704 (imagemagick_load_image): Fix pointer signedness problem by changing
5705 last arg from unsigned char * to char *. All uses changed.
5706 Also, fix a local for similar reasons.
5707 Remove unused locals. Remove locals to avoid shadowing.
5708 (fn_rsvg_handle_free): Remove; unused.
5709 (svg_load, svg_load_image): Fix pointer signedness problem.
5710 (imagemagick_load_image): Don't use garbage pointer image_wand.
5712 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5714 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5716 * image.c (gif_load): Fix omitted cast error introduced by
5719 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5721 * window.h (resize_proportionally, orig_total_lines)
5722 (orig_top_line): Remove from window structure.
5723 (set_window_height, set_window_width, change_window_heights)
5724 (Fdelete_window): Remove prototypes.
5725 (resize_frame_windows): Remove duplicate declaration.
5727 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5729 * window.h (resize_frame_windows, resize_window_check)
5730 (delete_deletable_window, resize_root_window)
5731 (resize_frame_windows): Declare prototypes.
5733 * window.c (resize_window_apply): Make definition be "static" to
5734 match the prototype.
5736 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5738 * window.c: Remove declarations of Qwindow_size_fixed,
5739 window_min_size_1, window_min_size_2, window_min_size,
5740 size_window, window_fixed_size_p, enlarge_window, delete_window.
5741 Remove static from declaration of Qdelete_window, it's
5742 temporarily needed by Fbury_buffer.
5743 (replace_window): Don't assign orig_top_line and
5745 (Fdelete_window, delete_window): Remove. Window deletion is
5746 handled by window.el.
5747 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5748 Replace Fdelete_window calls with calls to Qdelete_window.
5749 (Fdelete_other_windows): Remove. Deleting other windows is
5750 handled by window.el.
5751 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5752 handled in window.el.
5753 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5754 Window minimum sizes are handled in window.el.
5755 (shrink_windows, size_window, set_window_height)
5756 (set_window_width, change_window_heights, window_height)
5757 (window_width, CURBEG, CURSIZE, enlarge_window)
5758 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5759 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5760 handled in window.el.
5761 (make_dummy_parent): Rename to make_parent_window and give it a
5762 second argument horflag.
5763 (make_window): Don't set resize_proportionally any more.
5764 (Fsplit_window): Remove. Windows are split in window.el.
5765 (save_restore_action, save_restore_orig_size)
5766 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5767 Resize mini windows in window.el.
5768 (grow_mini_window, shrink_mini_window): Implement by calling
5769 Qresize_root_window_vertically, resize_window_check and
5770 resize_window_apply.
5771 (saved_window, Fset_window_configuration, save_window_save):
5772 Do not handle orig_top_line, orig_total_lines, and
5773 resize_proportionally.
5774 (window_min_height, window_min_width): Move to window.el.
5775 (keys_of_window): Move bindings for delete-other-windows,
5776 split-window, delete-window and enlarge-window to window.el.
5778 * buffer.c: Temporarily extern Qdelete_window.
5779 (Fbury_buffer): Temporarily call Qdelete_window instead of
5780 Fdelete_window (Fbury_buffer will move to window.el soon).
5782 * frame.c (set_menu_bar_lines_1): Remove code handling
5783 orig_top_line and orig_total_lines.
5785 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5786 set_window_height but set heights directly.
5787 (change_frame_size_1): Use resize_frame_windows.
5789 * xdisp.c (init_xdisp): Don't use set_window_height but set
5792 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5793 Use resize_frame_windows instead of change_window_heights and run
5794 run_window_configuration_change_hook.
5796 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5797 instead of change_window_heights and run
5798 run_window_configuration_change_hook.
5800 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5802 * window.c (replace_window): Rename second argument REPLACEMENT to
5803 NEW. New third argument SETFLAG. Rewrite.
5804 (delete_window, make_dummy_parent): Call replace_window with
5806 (window_list_1): Move down in code.
5807 (run_window_configuration_change_hook): Move set_buffer part
5808 before select_frame_norecord part in order to unwind correctly.
5809 Rename count1 to count.
5810 (recombine_windows, delete_deletable_window, resize_root_window)
5811 (Fdelete_other_windows_internal)
5812 (Frun_window_configuration_change_hook, make_parent_window)
5813 (resize_window_check, resize_window_apply, Fresize_window_apply)
5814 (resize_frame_windows, Fsplit_window_internal)
5815 (Fdelete_window_internal, Fresize_mini_window_internal):
5817 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5819 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5821 * window.h (window): Add some new members to window structure -
5822 normal_lines, normal_cols, new_total, new_normal, clone_number,
5823 splits, nest, prev_buffers, next_buffers.
5824 (WINDOW_TOTAL_SIZE): Move here from window.c.
5825 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5827 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5829 (make_dummy_parent): Set new members of windows structure.
5830 (make_window): Move down in code. Handle new members of window
5832 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5833 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5834 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5835 (Fset_window_prev_buffers, Fwindow_next_buffers)
5836 (Fset_window_next_buffers, Fset_window_clone_number):
5838 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5839 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5841 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5842 Argument WINDOW can be now internal window too.
5843 (Fwindow_use_time): Move up in code.
5844 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5846 (Fset_window_configuration, saved_window)
5847 (Fcurrent_window_configuration, save_window_save): Handle new
5848 members of window structure.
5849 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5850 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5851 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5852 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5853 Qget_mru_window, Qresize_root_window,
5854 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5855 Qauto_buffer_name; staticpro them.
5857 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5859 * window.c (Fwindow_total_size, Fwindow_left_column)
5860 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5861 (Fwindow_list_1): New functions.
5862 (window_box_text_cols): Replace with window_body_cols.
5863 (Fwindow_width, Fscroll_left, Fscroll_right):
5864 Use window_body_cols instead of window_box_text_cols.
5865 (delete_window, Fset_window_configuration):
5866 Call delete_all_subwindows with window as argument.
5867 (delete_all_subwindows): Take a window as argument and not a
5869 (window_loop): Remove handling of GET_LRU_WINDOW and
5871 (Fget_lru_window, Fget_largest_window): Move to window.el.
5873 * window.h: Extern window_body_cols instead of
5874 window_box_text_cols. delete_all_subwindows now takes a
5875 Lisp_Object as argument.
5877 * indent.c (compute_motion, Fcompute_motion):
5878 Use window_body_cols instead of window_box_text_cols.
5880 * frame.c (delete_frame): Call delete_all_subwindows with root
5883 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5885 * fns.c (Fputhash): Document return value.
5887 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5889 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5891 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5893 Cons<->int and similar integer overflow fixes (Bug#8794).
5895 Check for overflow when converting integer to cons and back.
5896 * charset.c (Fdefine_charset_internal, Fdecode_char):
5897 Use cons_to_unsigned to catch overflow.
5898 (Fencode_char): Use INTEGER_TO_CONS.
5899 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5900 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5901 * data.c (long_to_cons, cons_to_long): Remove.
5902 (cons_to_unsigned, cons_to_signed): New functions.
5903 These signal an error for invalid or out-of-range values.
5904 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5905 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5906 * font.c (Ffont_variation_glyphs):
5907 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5908 * lisp.h: Include <intprops.h>.
5909 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5910 (cons_to_signed, cons_to_unsigned): New decls.
5911 (long_to_cons, cons_to_long): Remove decls.
5912 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5913 (Fprimitive_undo): Use CONS_TO_INTEGER.
5914 * xfns.c (Fx_window_property): Likewise.
5915 * xselect.c: Include <limits.h>.
5916 (x_own_selection, selection_data_to_lisp_data):
5917 Use INTEGER_TO_CONS.
5918 (x_handle_selection_request, x_handle_selection_clear)
5919 (x_get_foreign_selection, Fx_disown_selection_internal)
5920 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5921 (lisp_data_to_selection_data): Use cons_to_unsigned.
5922 (x_fill_property_data): Use cons_to_signed.
5923 Report values out of range.
5925 Check for buffer and string overflow more precisely.
5926 * buffer.h (BUF_BYTES_MAX): New macro.
5927 * lisp.h (STRING_BYTES_MAX): New macro.
5928 * alloc.c (Fmake_string):
5929 * character.c (string_escape_byte8):
5930 * coding.c (coding_alloc_by_realloc):
5931 * doprnt.c (doprnt):
5932 * editfns.c (Fformat):
5934 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5935 since they may not be the same number.
5936 * editfns.c (Finsert_char):
5937 * fileio.c (Finsert_file_contents):
5938 Likewise for BUF_BYTES_MAX.
5940 * image.c: Use ptrdiff_t, not int, for sizes.
5941 (slurp_file): Switch from int to ptrdiff_t.
5943 (slurp_file): Check that file size fits in both size_t (for
5944 malloc) and ptrdiff_t (for sanity and safety).
5946 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5947 if b->modtime has its maximal value.
5949 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5951 Don't assume time_t can fit into int.
5952 * buffer.h (struct buffer.modtime): Now time_t, not int.
5953 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5954 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5956 Minor fixes for signed vs unsigned integers.
5957 * character.h (MAYBE_UNIFY_CHAR):
5958 * charset.c (maybe_unify_char):
5959 * keyboard.c (read_char, reorder_modifiers):
5960 XINT -> XFASTINT, since the integer must be nonnegative.
5961 * ftfont.c (ftfont_spec_pattern):
5962 * keymap.c (access_keymap, silly_event_symbol_error):
5963 XUINT -> XFASTINT, since the integer must be nonnegative.
5964 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5965 since it makes no difference and we prefer signed.
5966 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5967 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5970 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5972 * window.h (Fwindow_frame): Declare.
5974 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5976 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5977 (SPARE_MEMORY): Always define.
5978 (LARGE_REQUEST): Remove.
5979 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5981 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5983 * lisp.h: Move EXFUNS for Fframe_root_window,
5984 Fframe_first_window and Fset_frame_selected_window to window.h.
5986 * window.h: Move EXFUNS for Fframe_root_window,
5987 Fframe_first_window and Fset_frame_selected_window here from
5990 * frame.c (Fwindow_frame, Fframe_first_window)
5991 (Fframe_root_window, Fframe_selected_window)
5992 (Fset_frame_selected_window): Move to window.c.
5993 (Factive_minibuffer_window): Move to minibuf.c.
5994 (Fother_visible_frames_p): New function.
5996 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5998 * window.c (decode_window, decode_any_window): Move up in code.
5999 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6000 (inhibit_frame_unsplittable): Remove unused variable.
6001 (Fwindow_buffer): Move up and rewrite doc-string.
6002 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6003 (Fwindow_prev): New functions.
6004 (Fwindow_frame): Move here from frame.c. Accept any window as
6006 (Fframe_root_window, Fframe_first_window)
6007 (Fframe_selected_window): Move here from frame.c. Accept frame
6008 or arbitrary window as argument. Update doc-strings.
6009 (Fminibuffer_window): Move up in code.
6010 (Fwindow_minibuffer_p): Move up in code and simplify.
6011 (Fset_frame_selected_window): Move here from frame.c.
6013 (Fselected_window, select_window, Fselect_window): Move up in
6014 code. Minor doc-string fixes.
6016 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6018 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6019 Do not assume that spare memory exists; that assumption is valid
6020 only if SYSTEM_MALLOC.
6021 (LARGE_REQUEST): New macro, so that the issue of large requests
6022 is separated from the issue of spare memory.
6024 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6026 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6029 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6031 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6034 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6036 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6038 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6040 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6041 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6043 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
6045 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6047 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
6049 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6050 (x_clipboard_manager_save): Add return value.
6051 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6053 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6054 Obey Vx_select_enable_clipboard_manager. Catch errors in
6055 x_clipboard_manager_save (Bug#8779).
6056 (Vx_select_enable_clipboard_manager): New variable.
6057 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6059 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6061 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6063 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6065 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6066 in the current matrix if keep_current_p is non-zero.
6068 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6070 * bidi.c (bidi_level_of_next_char): Fix last change.
6072 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6074 Support bidi reordering of text covered by display properties.
6076 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6077 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6078 (bidi_cache_search, bidi_cache_iterator_state)
6079 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6080 (bidi_level_of_next_char, bidi_move_to_visually_next):
6081 Support character positions inside a run of characters covered by a
6083 (bidi_paragraph_init, bidi_resolve_explicit_1)
6084 (bidi_level_of_next_char): Call bidi_fetch_char and
6085 bidi_fetch_char_advance instead of FETCH_CHAR and
6087 (bidi_init_it): Initialize new members.
6088 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6090 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6091 instead of using explicit *_CHAR codes.
6092 (bidi_resolve_explicit, bidi_resolve_weak):
6093 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6094 bidirectional text is supported only in multibyte buffers.
6095 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6096 it to initialize the frame_window_p member of struct bidi_it.
6097 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6098 (bidi_resolve_explicit, bidi_resolve_weak)
6099 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6100 bidi_it->nchars is non-positive.
6101 (bidi_level_of_next_char): Don't try to lookup the cache for the
6102 next/previous character if nothing is cached there yet, or if we
6103 were just reseat()'ed to a new position.
6105 * xdisp.c (set_cursor_from_row): Set start and stop points
6106 according to the row's direction when priming the loop that looks
6107 for the glyph on which to display cursor.
6108 (single_display_spec_intangible_p): Function deleted.
6109 (display_prop_intangible_p): Reimplement to call
6110 handle_display_spec instead of single_display_spec_intangible_p.
6111 Accept 3 additional arguments needed by handle_display_spec.
6112 This fixes incorrect cursor motion across display property with complex
6113 values: lists, `(when COND...)' forms, etc.
6114 (single_display_spec_string_p): Support property values that are
6115 lists with the argument STRING its top-level element.
6116 (display_prop_string_p): Fix the condition for processing a
6117 property that is a list to be consistent with handle_display_spec.
6118 (handle_display_spec): New function, refactored from the
6119 last portion of handle_display_prop.
6120 (compute_display_string_pos): Accept additional argument
6121 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6122 value of a `display' property is a "replacing spec".
6123 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6124 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6125 the display property, but just return a value indicating whether
6126 the display property will replace the characters it covers.
6127 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6128 frame_window_p members of struct bidi_it.
6129 (compute_display_string_pos, compute_display_string_end):
6131 (push_it): Accept second argument POSITION, where pop_it should
6132 jump to continue iteration.
6133 (reseat_1): Initialize bidi_it.disp_pos.
6135 * keyboard.c (adjust_point_for_property): Adjust the call to
6136 display_prop_intangible_p to its new signature.
6138 * dispextern.h (struct bidi_it): New member frame_window_p.
6139 (bidi_init_it): Update prototypes.
6140 (display_prop_intangible_p): Update prototype.
6141 (compute_display_string_pos, compute_display_string_end):
6143 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6146 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6148 Malloc failure behavior now depends on size of allocation.
6149 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6150 * lisp.h: Change signatures accordingly.
6151 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6152 All callers changed. (Bug#8762)
6154 * gnutls.c: Use Emacs's memory allocators.
6155 Without this change, the gnutls library would invoke malloc etc.
6156 directly, which causes problems on non-SYNC_INPUT hosts, and which
6157 runs afoul of improving memory_full behavior. (Bug#8761)
6158 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6159 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6160 xfree instead of the default malloc, realloc, free.
6161 (Fgnutls_boot): No need to check for memory allocation failure,
6162 since xmalloc does that for us.
6164 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6165 * category.c (hash_get_category_set):
6166 * ccl.c (ccl_driver):
6167 * charset.c (Fdefine_charset_internal):
6168 * charset.h (struct charset.hash_index):
6169 * composite.c (get_composition_id, gstring_lookup_cache)
6170 (composition_gstring_put_cache):
6171 * composite.h (struct composition.hash_index):
6172 * dispextern.h (struct image.hash):
6173 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6174 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6175 (hashfn_equal, hashfn_user_defined, make_hash_table)
6176 (maybe_resize_hash_table, hash_lookup, hash_put)
6177 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6178 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6179 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6180 * image.c (make_image, search_image_cache, lookup_image)
6181 (xpm_put_color_table_h):
6182 * lisp.h (struct Lisp_Hash_Table):
6183 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6184 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6185 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6186 * alloc.c (allocate_vectorlike):
6187 Check for overflow in vector size calculations.
6188 * ccl.c (ccl_driver):
6189 Check for overflow when converting EMACS_INT to int.
6190 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6191 need to be updated by these changes.
6192 * fns.c (make_hash_table, maybe_resize_hash_table):
6193 Check for integer overflow with large hash tables.
6194 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6195 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6196 (SXHASH_REDUCE): New macro.
6197 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6198 Use it instead of discarding useful hash info with large hash values.
6199 (sxhash_float): New function.
6200 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6201 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6202 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6203 Rewrite to use FIXNUM_BITS, as this simplifies things.
6204 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6205 Adjust signatures to match updated version of code.
6206 (consing_since_gc): Now EMACS_INT, since a single hash table can
6207 use more than INT_MAX bytes.
6209 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6211 Make it possible to build with GCC-4.6+ -O2 -flto.
6213 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6215 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6217 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6218 Call minibuffer-inactive-mode.
6220 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6222 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6223 Update dependencies.
6225 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6227 * data.c (init_data): Remove code for UTS, this system is not
6230 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6232 Don't force ./temacs to start in terminal mode.
6234 * frame.c (make_initial_frame): Initialize faces in all cases, not
6235 only when CANNOT_DUMP is defined.
6236 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6238 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6240 * dispnew.c (add_window_display_history): Use const for the string
6241 pointer. Remove declaration, not needed.
6243 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6245 Use 'inline', not 'INLINE'.
6246 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6247 * alloc.c, fontset.c (INLINE): Remove.
6248 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6249 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6250 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6251 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6252 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6254 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6256 Make it possible to run ./temacs.
6258 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6259 syms_of_callproc does the same thing. Remove test for
6260 "initialized", do it in the caller.
6261 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6263 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6265 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6266 (read_minibuf): Use get_minibuffer.
6267 (syms_of_minibuf): Use DEFSYM.
6268 (Qmetadata): New var.
6269 * data.c (Qbuffer): Don't make it static.
6270 (syms_of_data): Use DEFSYM.
6272 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6274 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6275 (CCL_CODE_MIN): New macro.
6277 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6279 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6281 * eval.c (Qdebug): Now static.
6282 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6283 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6284 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6286 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6288 * image.c: Various fixes to ImageMagick code comments.
6289 (Fimagemagick_types): Doc fix.
6291 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6293 Minor fixes prompted by GCC 4.6.0 warnings.
6295 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6297 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6298 (x_clipboard_manager_save_all): Move extern decl to ...
6299 * xterm.h: ... here, so that it can be checked for consistency.
6301 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6303 * xselect.c (x_clipboard_manager_save_frame)
6304 (x_clipboard_manager_save_all): New functions.
6305 (Fx_clipboard_manager_save): Lisp function deleted.
6307 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6308 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6310 * xterm.h: Update prototype.
6312 2011-05-28 William Xu <william.xwl@gmail.com>
6314 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6317 2011-05-28 Jim Meyering <meyering@redhat.com>
6319 Avoid a sign-extension bug in crypto_hash_function.
6320 * fns.c (to_uchar): Define.
6321 (crypto_hash_function): Use it to convert some newly-signed
6322 variables to unsigned, to avoid sign-extension bugs. For example,
6323 without this change, (md5 "truc") would evaluate to
6324 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6325 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6326 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6328 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6330 Integer overflow fixes.
6332 * dbusbind.c: Serial number integer overflow fixes.
6333 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6334 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6335 to hold a serial number that is too large for a fixnum.
6336 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6337 Check for serial numbers out of range. Decode any serial number
6338 that was so large that it became a float. (Bug#8722)
6340 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6341 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6342 Use XFASTINT rather than XUINT when numbers are nonnegative.
6343 (xd_append_arg, Fdbus_method_return_internal):
6344 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6345 arguments, check that Lisp number is nonnegative, rather than
6346 silently wrapping negative numbers around. (Bug#8722)
6347 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6350 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6352 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6354 ccl: Add integer overflow checks.
6355 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6356 (IN_INT_RANGE): New macros.
6357 (ccl_driver): Use them to check for integer overflow when
6358 decoding a CCL program. Many of the new checks are whether XINT (x)
6359 fits in int; it doesn't always, on 64-bit hosts. The new version
6360 doesn't catch all possible integer overflows, but it's an
6361 improvement. (Bug#8719)
6363 * alloc.c (make_event_array): Use XINT, not XUINT.
6364 There's no need for unsigned here.
6366 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6367 This follows up to the 2011-05-06 change that substituted uintptr_t
6368 for EMACS_INT. This case wasn't caught back then.
6370 Rework Fformat to avoid integer overflow issues.
6371 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6372 now (part of C89). Include <verify.h>.
6373 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6374 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6375 (Fformat): Avoid the prepass trying to compute sizes; it was only
6376 approximate and thus did not catch overflow reliably. Instead, walk
6377 through the format just once, formatting and computing sizes as we go,
6378 checking for integer overflow at every step, and allocating a larger
6379 buffer as needed. Keep track separately whether the format is
6380 multibyte. Keep only the most-recently calculated precision, rather
6381 than them all. Record whether each argument has been converted to
6382 string. Use EMACS_INT, not int, for byte and char and arg counts.
6383 Support field widths and precisions larger than INT_MAX. Avoid
6384 sprintf's undefined behavior with conversion specifications such as %#d
6385 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6386 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6387 formatting out-of-range floating point numbers with int
6390 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6392 * data.c: Avoid integer truncation in expressions involving floats.
6393 * data.c: Include <intprops.h>.
6394 (arith_driver): When there's an integer overflow in an expression
6395 involving floating point, convert the integers to floating point
6396 so that the resulting value does not suffer from catastrophic
6397 integer truncation. For example, on a 64-bit host (* 4
6398 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6399 Do not rely on undefined behavior after integer overflow.
6401 merge count_size_as_multibyte, parse_str_to_multibyte
6402 * character.c, character.h (count_size_as_multibyte):
6403 Rename from parse_str_to_multibyte; all uses changed.
6404 Check for integer overflow.
6405 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6406 since it's now a duplicate of the other. This is more of
6407 a character than a buffer op, so better that it's in character.c.
6408 * fns.c, print.c: Adjust to above changes.
6410 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6412 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6414 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6416 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6417 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6418 (x_clipboard_manager_save): Now static.
6419 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6421 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6422 (crypto_hash_function): Now static.
6423 Fix pointer signedness problems. Avoid unnecessary initializations.
6425 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6427 * termhooks.h (Vselection_alist): Make it terminal-local.
6429 * terminal.c (create_terminal): Initialize it.
6431 * xselect.c: Support for clipboard managers.
6432 (Vselection_alist): Move to termhooks.h as terminal-local var.
6433 (LOCAL_SELECTION): New macro.
6434 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6435 (symbol_to_x_atom): Remove gratuitous arg.
6436 (x_handle_selection_request, lisp_data_to_selection_data)
6437 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6438 (x_own_selection, x_get_local_selection, x_convert_selection):
6439 New arg, specifying work frame. Use terminal-local Vselection_alist.
6440 (some_frame_on_display): Delete unused function.
6441 (Fx_own_selection_internal, Fx_get_selection_internal)
6442 (Fx_disown_selection_internal, Fx_selection_owner_p)
6443 (Fx_selection_exists_p): New optional frame arg.
6444 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6445 (x_handle_selection_clear): Don't treat other terminals with the
6446 same keyboard specially. Use the terminal-local Vselection_alist.
6447 (x_clear_frame_selections): Use Frun_hook_with_args.
6449 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6451 * xterm.h: Add support for those atoms.
6453 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6455 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6456 (converted_selections, conversion_fail_tag): New global variables.
6457 (x_selection_request_lisp_error): Free the above.
6458 (x_get_local_selection): Remove unnecessary code.
6459 (x_reply_selection_request): Args changed; handle arbitrary array
6460 of converted selections stored in converted_selections.
6461 Separate the XChangeProperty and SelectionNotify steps.
6462 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6463 (x_convert_selection): New function.
6464 (x_handle_selection_event): Simplify.
6465 (x_get_foreign_selection): Don't ignore incoming requests while
6466 waiting for an answer; this will fail when we implement
6467 SAVE_TARGETS, and seems unnecessary anyway.
6468 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6469 (Vx_sent_selection_functions): Doc fix.
6471 2011-05-26 Leo Liu <sdl.web@gmail.com>
6473 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6475 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6477 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6479 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6480 for fringe update if it has periodic bitmap.
6481 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6482 and fringe_bitmap_periodic_p.
6484 * fringe.c (get_fringe_bitmap_data): New function.
6485 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6486 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6487 row. Mark glyph row for fringe update if periodicity changed.
6489 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6490 for fringe update unless it has periodic bitmap.
6492 2011-05-25 Kenichi Handa <handa@m17n.org>
6494 * xdisp.c (get_next_display_element): Set correct it->face_id for
6495 a static composition.
6497 2011-05-24 Leo Liu <sdl.web@gmail.com>
6500 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6502 * fns.c (crypto_hash_function, Fsha1): New function.
6503 (Fmd5): Use crypto_hash_function.
6504 (syms_of_fns): Add Ssha1.
6506 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6508 * gnutls.c: Remove unused macros.
6509 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6510 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6511 Remove macros that are defined and never used.
6512 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6514 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6516 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6517 (Fx_get_selection_internal): Minor cleanup.
6518 (Fx_own_selection_internal): Rename arguments for consistency with
6521 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6523 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6525 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6527 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6529 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6531 * dispnew.c (scrolling_window): Don't exclude the case that the
6532 last enabled row in the desired matrix touches the bottom boundary.
6534 2011-05-21 Glenn Morris <rgm@gnu.org>
6536 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6537 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6538 and add some more files.
6540 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6542 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6543 report_file_error introduced by the change from 2011-05-07.
6545 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6547 * systime.h (Time): Define only if emacs is defined.
6548 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6549 where the include path doesn't have X11/X.h by default. See
6550 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6552 2011-05-20 Kenichi Handa <handa@m17n.org>
6554 * composite.c (find_automatic_composition): Fix previous change.
6556 2011-05-20 Glenn Morris <rgm@gnu.org>
6558 * lisp.mk: New file, split from Makefile.in.
6559 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6560 (shortlisp): Remove.
6561 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6563 2011-05-19 Glenn Morris <rgm@gnu.org>
6565 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6566 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6567 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6568 (lisp): Set the order to that of loadup.el.
6569 (shortlisp): Make it a copy of $lisp.
6570 (SOME_MACHINE_LISP): Remove.
6571 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6572 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6574 2011-05-18 Kenichi Handa <handa@m17n.org>
6576 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6577 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6578 (find_automatic_composition): Mostly rewrite for efficiency.
6580 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6582 * makefile.w32-in: Update dependencies.
6584 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6586 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6587 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6589 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6591 Fix some integer overflow issues, such as string length overflow.
6593 * insdel.c (count_size_as_multibyte): Check for string overflow.
6595 * character.c (lisp_string_width): Check for string overflow.
6596 Use EMACS_INT, not int, for string indexes and lengths; in
6597 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6598 the resulting string length overflows an EMACS_INT; instead,
6599 report a string overflow if no precision given. When checking for
6600 precision exhaustion, use a check that cannot possibly have
6601 integer overflow. (Bug#8675)
6602 * character.h (lisp_string_width): Adjust to new signature.
6604 * alloc.c (string_overflow): New function.
6605 (Fmake_string): Use it. This doesn't change behavior, but saves
6606 a few bytes and will simplify future changes.
6607 * character.c (string_escape_byte8): Likewise.
6608 * lisp.h (string_overflow): New decl.
6610 Fixups, following up to the user-interface timestamp change.
6611 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6612 for UI timestamps, instead of unsigned long.
6613 * msdos.c (mouse_get_pos): Likewise.
6614 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6615 * w32gui.h (Time): Define by including "systime.h" rather than by
6616 declaring it ourselves. (Bug#8664)
6618 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6619 * image.c (clear_image_cache): Likewise.
6621 * term.c (term_mouse_position): Don't assume time_t wraparound.
6623 Be more systematic about user-interface timestamps.
6624 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6625 and sometimes 'EMACS_UINT', to represent these timestamps.
6626 This change causes it to use 'Time' uniformly, as that's what X uses.
6627 This makes the code easier to follow, and makes it easier to catch
6628 integer overflow bugs such as Bug#8664.
6629 * frame.c (Fmouse_position, Fmouse_pixel_position):
6630 Use Time, not unsigned long, for user-interface timestamps.
6631 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6632 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6633 * keyboard.h (last_event_timestamp): Likewise.
6634 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6635 * menu.h (xmenu_show): Likewise.
6636 * term.c (term_mouse_position): Likewise.
6637 * termhooks.h (struct input_event.timestamp): Likewise.
6638 (struct terminal.mouse_position_hook): Likewise.
6639 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6640 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6641 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6642 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6644 * menu.h, termhooks.h: Include "systime.h", for Time.
6646 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6647 Don't assume that the difference between two unsigned long values
6648 can fit into an integer. At this point, we know button_down_time
6649 <= event->timestamp, so the difference must be nonnegative, so
6650 there's no need to cast the result if double-click-time is
6651 nonnegative, as it should be; check that it's nonnegative, just in
6652 case. This bug is triggered when events are more than 2**31 ms
6653 apart (about 25 days). (Bug#8664)
6655 * xselect.c (last_event_timestamp): Remove duplicate decl.
6656 (x_own_selection): Remove needless cast to unsigned long.
6658 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6659 that always fit in int. Use a sentinel instead of a counter, to
6660 avoid a temp and to allay GCC's concerns about possible int overflow.
6661 * frame.h (struct frame): Use int for menu_bar_items_used
6662 instead of EMACS_INT, since it always fits in int.
6664 * menu.c (grow_menu_items): Check for int overflow.
6666 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6668 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6669 Before, the code was not consistent. These values cannot exceed
6670 2**31 - 1 so there's no need to make them unsigned.
6671 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6672 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6673 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6675 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6677 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6678 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6679 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6680 presumably because the widths might not match.
6682 * window.c (size_window): Avoid needless test at loop start.
6684 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6686 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6688 2011-05-12 Drew Adams <drew.adams@oracle.com>
6690 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6692 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6694 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6695 `width' to `bar_area_x' and `bar_area_width', respectively.
6696 (x_scroll_run): Take account of fringe background extension.
6698 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6699 Rename local vars `left' and `width' to `bar_area_x' and
6700 `bar_area_width', respectively.
6701 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6702 background extension.
6704 2011-05-10 Jim Meyering <meyering@redhat.com>
6706 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6708 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6710 * image.c (Finit_image_library): Return t for built-in image types,
6711 like pbm and xbm. (Bug#8640)
6713 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6715 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6717 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6719 * w32console.c (Fset_screen_color): Doc fix.
6720 (Fget_screen_color): New function.
6721 (syms_of_ntterm): Defsubr it.
6723 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6724 unlink the temporary file if Fcall_process didn't create it in the
6726 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6727 child process will be redirected to a file specified with `:file'.
6728 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6729 cue to call_process_cleanup not to close that handle.
6731 2011-05-07 Ben Key <bkey76@gmail.com>
6733 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6734 one of two shell specific rules, either bootstrap-temacs-CMD or
6735 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6736 to the previous implementation of the bootstrap-temacs rule.
6737 The bootstrap-temacs-CMD rule is similar to the previous
6738 implementation of the bootstrap-temacs rule except that it
6739 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6742 These changes, along with some changes to nt/configure.bat,
6743 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6744 earlier fix to add support for --cflags and --ldflags options
6745 that include quotes so that it works whether make uses cmd or
6748 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6750 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6751 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6753 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6754 a string. Handle both cases.
6755 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6756 (Fdbus_register_method): Use Qinvalid_function.
6758 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6760 * makefile.w32-in: Update dependencies.
6761 (LISP_H): Add inttypes.h and stdin.h.
6762 (PROCESS_H): Add unistd.h.
6764 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6766 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6767 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6769 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6771 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6773 * term.c (vfatal): Remove stray call to va_end.
6774 It's not needed and the C Standard doesn't allow it here anyway.
6776 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6777 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6779 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6782 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6784 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6786 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6788 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6790 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6792 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6793 * charset.c (Fdefine_charset_internal): Don't initialize
6794 charset.code_space[15]. The value was garbage, on hosts with
6795 32-bit int (Bug#8600).
6797 * lread.c (read_integer): Be more consistent with string-to-number.
6798 Use string_to_number to do the actual conversion; this avoids
6799 rounding errors and fixes some other screwups. Without this fix,
6800 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6801 (digit_to_number): Move earlier, for benefit of read_integer.
6802 Return -1 if the digit is out of range for the base, -2 if it is
6803 not a digit in any supported base. (Bug#8602)
6805 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6807 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6808 to match comment at start of function. This also removes a
6809 GCC warning about overflow in a 32+64-bit port.
6811 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6813 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6814 Reported by Stefan Monnier in
6815 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6816 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6817 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6819 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6820 (EMACS_UINTPTR): Likewise, with uintptr_t.
6822 * lisp.h: Prefer 64-bit EMACS_INT if available.
6823 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6824 on 32-bit hosts that have 64-bit int, so that they can access
6826 However, temporarily disable this change unless the temporary
6827 symbol WIDE_EMACS_INT is defined.
6829 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6831 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6832 This removes an assumption that EMACS_INT and long are the same
6833 width as pointers. The assumption is true for Emacs porting targets
6834 now, but we want to make other targets possible.
6835 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6836 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6837 In the rest of the code, change types of integers that hold casted
6838 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6839 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6840 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6841 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6842 No need to cast type when ORing.
6843 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6844 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6845 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6846 assume EMACS_INT is the same width as char *.
6847 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6848 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6849 Remove no-longer-needed casts.
6850 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6851 (xg_tool_bar_help_callback, xg_make_tool_item):
6852 Use EMACS_INTPTR to hold an integer
6853 that will be cast to void *; this can avoid a GCC warning
6854 if EMACS_INT is not the same width as void *.
6855 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6856 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6857 (current_message_1, set_message_1):
6858 Use a local to convert to proper width without a cast.
6859 * xmenu.c (dialog_selection_callback): Likewise.
6861 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6862 Also, don't assume VALBITS / RAND_BITS is less than 5,
6863 and don't rely on undefined behavior when shifting a 1 left into
6865 * lisp.h (get_random): Change signature to match.
6867 * lread.c (hash_string): Use size_t, not int, for hash computation.
6868 Normally we prefer signed values; but hashing is special, because
6869 it's better to use unsigned division on hash table sizes so that
6870 the remainder is nonnegative. Also, size_t is the natural width
6871 for hashing into memory. The previous code used 'int', which doesn't
6872 retain enough info to hash well into very large tables.
6873 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6875 * dbusbind.c: Don't possibly lose pointer info when converting.
6876 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6877 Use XPNTR rather than XHASH, so that the high-order bits of
6878 the pointer aren't lost when converting through void *.
6880 * eval.c (Fautoload): Don't double-shift a pointer.
6882 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6884 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6886 * gnutls.c (DEF_GNUTLS_FN):
6887 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6889 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6891 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6894 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6896 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6897 New version that can reserve upto 2GB of heap space.
6899 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6901 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6903 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6905 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6906 `gnutls_certificate_set_x509_key_file'.
6908 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6910 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6911 Update dependencies.
6913 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6915 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6916 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6917 Remove unused parameter `fildes'.
6918 * process.c (read_process_output, send_process): Don't pass it.
6920 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6922 Fix previous change: the library cache is defined in w32.c.
6923 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6924 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6926 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6928 Implement dynamic loading of GnuTLS on Windows.
6930 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6931 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6932 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6935 * gnutls.c (Qgnutls_dll): Define.
6936 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6937 (gnutls_*): Declare function pointers.
6938 (init_gnutls_functions): New function to initialize function pointers.
6939 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6940 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6941 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6942 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6943 (emacs_gnutls_write, emacs_gnutls_read)
6944 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6945 (Fgnutls_available_p): New function.
6946 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6947 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6948 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6950 * image.c: Include w32.h.
6951 (Vimage_type_cache): Delete.
6952 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6953 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6954 (w32_delayed_load): Move to w32.c.
6956 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6958 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6959 (w32_delayed_load): Move from image.c. When loading a library, record
6960 its filename in the :loaded-from property of the library id.
6961 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6962 Initialize and staticpro them.
6963 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6965 * process.c: Include lisp.h before w32.h, not after.
6966 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6967 instead of gnutls_record_check_pending.
6969 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6971 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6973 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6974 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6977 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6979 * xterm.c (x_set_frame_alpha): Do not set property on anything
6980 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6982 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6984 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6986 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6988 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6989 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6990 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6991 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6992 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6993 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6994 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6995 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6996 (Qgnutls_bootprop_callbacks_verify): Make static.
6998 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7000 * callproc.c: Indentation fixup.
7002 * sysdep.c (wait_for_termination_1): Make static.
7003 (wait_for_termination, interruptible_wait_for_termination):
7004 Move after wait_for_termination_1.
7006 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7008 * sysdep.c (interruptible_wait_for_termination): New function
7009 which is like wait_for_termination, but allows keyboard
7012 * callproc.c (Fcall_process): Add (:file "file") as an option for
7014 (Fcall_process_region): Ditto.
7016 2011-04-30 Eli Zaretskii <eliz@gnu.org>
7018 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7019 rather than `XVECTOR (FOO)->size'.
7021 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7022 inttypes.h, as a gnulib replacement is used if it not available in
7025 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7027 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7028 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7029 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7031 * coding.c (coding_alloc_by_realloc): Error out if destination
7032 will grow beyond MOST_POSITIVE_FIXNUM.
7033 (decode_coding_emacs_mule): Abort if there isn't enough place in
7034 charbuf for the composition carryover bytes. Reserve an extra
7035 space for up to 2 characters produced in a loop.
7036 (decode_coding_iso_2022): Abort if there isn't enough place in
7037 charbuf for the composition carryover bytes.
7039 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7041 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7042 aborting when %lld or %lll format is passed.
7043 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7044 %llo or %llx format is passed. (Bug#8545)
7046 * window.c (window_scroll_line_based): Use a marker instead of
7047 simple variables to record original value of point. (Bug#7952)
7049 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7050 produced by %s or %c overflows available buffer space. (Bug#8545)
7052 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7054 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7055 (SIZE_MAX): Move defn after all includes, as they might #define it.
7057 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7059 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7061 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7063 * keyboard.c (Qdelayed_warnings_hook): Define.
7064 (command_loop_1): Run `delayed-warnings-hook'
7065 if Vdelayed_warnings_list is non-nil.
7066 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7067 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7069 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7071 * doprnt.c (doprnt): Don't return value smaller than the buffer
7072 size if the message was truncated. (Bug#8545).
7074 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7076 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7077 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7079 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7081 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7083 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7085 * makefile.w32-in: Update dependencies.
7087 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7089 Improve `doprnt' and its usage. (Bug#8545)
7090 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7091 `format_end'. Remove support for %l as a conversion specifier.
7092 Don't use xrealloc. Improve diagnostics when the %l size modifier
7093 is used. Update the commentary.
7095 * eval.c (verror): Simplify calculation of size_t.
7097 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7100 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7102 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7105 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7107 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7108 This makes this file independent of the recent pseudovector change.
7110 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7112 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7114 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7115 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7116 Remove unused local.
7117 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7119 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7120 GCC 4.6.0 optimizes based on type-based alias analysis.
7121 For example, if b is of type struct buffer * and v of type struct
7122 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7123 != &v->size, and therefore "v->size = 1; b->size = 2; return
7124 v->size;" must therefore return 1. This assumption is incorrect
7125 for Emacs, since it type-puns struct Lisp_Vector * with many other
7126 types. To fix this problem, this patch adds a new type struct
7127 vectorlike_header that documents the constraints on layout of vectors
7128 and pseudovectors, and helps optimizing compilers not get fooled
7129 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7130 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7131 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7133 (XSETPVECTYPE): Rewrite in terms of new macro.
7134 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7135 This is a bit clearer, and further avoids the possibility of
7136 undesirable aliasing.
7137 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7138 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7139 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7140 since Lisp_Subr is a special case (no "next" field).
7141 (ASIZE): Now uses header.size rather than size.
7142 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7143 to avoid the hassle of writing XVECTOR (foo)->header.size.
7144 (struct vectorlike_header): New type.
7145 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7146 object, to help avoid aliasing.
7147 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7148 (SUBRP): Likewise, since Lisp_Subr is a special case.
7149 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7150 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7151 (struct Lisp_Hash_Table): Combine first two members into a single
7152 struct vectorlike_header member. All uses of "size" and "next" members
7153 changed to be "header.size" and "header.next".
7154 * buffer.h (struct buffer): Likewise.
7155 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7156 * frame.h (struct frame): Likewise.
7157 * process.h (struct Lisp_Process): Likewise.
7158 * termhooks.h (struct terminal): Likewise.
7159 * window.c (struct save_window_data, struct saved_window): Likewise.
7160 * window.h (struct window): Likewise.
7161 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7162 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7163 * buffer.c (init_buffer_once): Likewise.
7164 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7166 * process.c (Fformat_network_address): Use local var for size,
7169 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7171 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7172 * data.c (atof): Remove decl; no longer used or needed.
7173 (digit_to_number): Move to lread.c.
7174 (Fstring_to_number): Use new string_to_number function, to be
7175 consistent with how the Lisp reader treats infinities and NaNs.
7176 Do not assume that floating-point numbers represent EMACS_INT
7177 without losing information; this is not true on most 64-bit hosts.
7178 Avoid double-rounding errors, by insisting on integers when
7179 parsing non-base-10 numbers, as the documentation specifies.
7180 * lisp.h (string_to_number): New decl, replacing ...
7181 (isfloat_string): Remove.
7182 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7183 (read1): Do not accept +. and -. as integers; this
7184 appears to have been a coding error. Similarly, do not accept
7185 strings like +-1e0 as floating point numbers. Do not report
7186 overflow for integer overflows unless the base is not 10 which
7187 means we have no simple and reliable way to continue.
7188 Break out the floating-point parsing into a new
7189 function string_to_number, so that Fstring_to_number parses
7190 floating point numbers consistently with the Lisp reader.
7191 (digit_to_number): Move here from data.c. Make it static inline.
7192 (E_CHAR, EXP_INT): Remove, replacing with ...
7193 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7194 (string_to_number): New function, replacing isfloat_string.
7195 This function checks for valid syntax and produces the resulting
7196 Lisp float number too. Rework it so that string-to-number
7197 no longer mishandles examples like "1.0e+". Use strtoumax,
7198 so that overflow for non-base-10 numbers is reported only when
7199 there's no portable and simple way to convert to floating point.
7201 * textprop.c (set_text_properties_1): Rewrite for clarity,
7202 and to avoid GCC warning about integer overflow.
7204 * intervals.h (struct interval): Use EMACS_INT for members
7205 where EMACS_UINT might cause problems. See
7206 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7207 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7208 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7210 (offset_intervals): Tell GCC not to worry about length overflow
7211 when negating a negative length.
7213 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7214 (overrun_check_free): Likewise.
7216 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7217 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7220 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7221 (gnutls_make_error): Rename local to avoid shadowing.
7222 (gnutls_emacs_global_deinit): ifdef out; not used.
7223 (Fgnutls_boot): Use const for pointer to readonly storage.
7224 Comment out unused local. Fix pointer signedness problems.
7226 * lread.c (openp): Don't stuff size_t into an 'int'.
7227 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7228 about possible signed overflow.
7230 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7231 (GDK_KEY_g): Don't define if already defined.
7232 (xg_prepare_tooltip): Avoid pointer signedness problem.
7233 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7235 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7236 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7238 * xfns.c (Fx_window_property): Simplify a bit,
7239 to make a bit faster and to avoid GCC 4.6.0 warning.
7240 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7242 * fns.c (internal_equal): Don't assume size_t fits in int.
7244 * alloc.c (compact_small_strings): Tighten assertion a little.
7246 Replace pEd with more-general pI, and fix some printf arg casts.
7247 * lisp.h (pI): New macro, generalizing old pEd macro to other
7248 conversion specifiers. For example, use "...%"pI"d..." rather
7249 than "...%"pEd"...".
7250 (pEd): Remove. All uses replaced with similar uses of pI.
7251 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7252 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7253 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7254 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7255 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7256 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7257 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7259 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7260 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7261 * print.c (safe_debug_print, print_object): Likewise.
7262 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7264 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7265 avoiding the 0 flag, which is not portable.
7266 * process.c (Fmake_network_process): Use pI to avoid cast.
7267 * region-cache.c (pp_cache): Likewise.
7268 * xdisp.c (decode_mode_spec): Likewise.
7269 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7270 behavior on 64-bit hosts with printf arg.
7271 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7272 (x_stop_queuing_selection_requests): Likewise.
7273 (x_get_window_property): Don't truncate byte count to an 'int'
7276 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7277 here, since it parses constructs like leading '-' and spaces,
7278 which are not wanted; and it overflows with large numbers.
7279 Instead, simply match F[0-9]+, which is what is wanted anyway.
7281 * alloc.c: Remove unportable assumptions about struct layout.
7282 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7283 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7284 (allocate_vectorlike, make_pure_vector): Use the new macros,
7285 plus offsetof, to remove unportable assumptions about struct layout.
7286 These assumptions hold on all porting targets that I know of, but
7287 they are not guaranteed, they're easy to remove, and removing them
7288 makes further changes easier.
7290 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7291 This doesn't fix a bug but makes the code clearer.
7292 (string_overrun_cookie): Now const. Use initializers that
7293 don't formally overflow signed char, to avoid warnings.
7294 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7295 can cause Emacs to crash when string overrun checking is enabled.
7296 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7297 multiple of sizeof (EMACS_INT); it need not be, if
7298 alignof(EMACS_INT) < sizeof (EMACS_INT).
7299 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7301 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7303 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7305 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7307 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7308 supposed to be handshaking. (Bug#8556)
7309 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7311 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7313 * lisp.h (Qdebug): List symbol.
7314 * eval.c (Qdebug): Restore global linkage.
7315 * keyboard.c (debug-on-event): New variable.
7316 (handle_user_signal): Break into debugger when debug-on-event
7317 matches the current signal symbol.
7319 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7321 * alloc.c (check_sblock, check_string_bytes)
7322 (check_string_free_list): Convert to standard C.
7324 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7326 * w32.c (emacs_gnutls_push): Fix typo.
7328 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7330 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7331 "cast to pointer from integer of different size".
7333 Improve doprnt and its use in verror. (Bug#8545)
7334 * doprnt.c (doprnt): Document the set of format control sequences
7335 supported by the function. Use SAFE_ALLOCA instead of always
7338 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7339 is one byte too soon. Don't use xrealloc; instead xfree and
7342 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7344 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7347 * gnutls.c: Renamed global_initialized to
7348 gnutls_global_initialized. Added internals for the
7349 :verify-hostname-error, :verify-error, and :verify-flags
7350 parameters of `gnutls-boot' and documented those parameters in the
7351 docstring. Start callback support.
7352 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7353 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7354 on error. Return error code.
7355 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7356 (emacs_gnutls_read): Likewise.
7357 (Fgnutls_boot): Return handshake error code.
7358 (emacs_gnutls_handle_error): New function.
7359 (wsaerror_to_errno): Likewise.
7361 * w32.h (emacs_gnutls_pull): Add prototype.
7362 (emacs_gnutls_push): Likewise.
7364 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7365 (emacs_gnutls_push): Likewise.
7367 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7369 * process.c (wait_reading_process_output): Check if GnuTLS
7370 buffered some data internally if no FDs are set for TLS
7373 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7374 (LIBS): Link to USER_LIBS.
7375 ($(BLD)/gnutls.$(0)): New target.
7377 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7379 * xdisp.c (handle_single_display_spec): Rename the
7380 display_replaced_before_p argument into display_replaced_p, to
7381 make it consistent with the commentary. Fix typos in the
7384 * textprop.c (syms_of_textprop): Remove dead code.
7385 (copy_text_properties): Delete obsolete commentary about an
7386 interface that was deleted long ago. Fix typos in the description
7389 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7390 to changes in oldXMenu/XMenu.h from 2011-04-16.
7391 <menu_help_message, prev_menu_help_message>: Constify.
7392 (IT_menu_make_room): menu->help_text is now `const char **';
7395 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7396 to changes in oldXMenu/XMenu.h from 2011-04-16.
7397 (struct XMenu): Declare `help_text' `const char **'.
7399 * xfaces.c <Qunspecified>: Make extern again.
7401 * syntax.c: Include sys/types.h before including regex.h, as
7404 * doc.c (get_doc_string): Improve the format passed to `error'.
7406 * doprnt.c (doprnt): Improve commentary.
7408 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7410 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7413 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7414 changes in globals.h immediately force recompilation.
7415 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7416 $(CURDIR)/s/ms-w32.h.
7417 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7419 * character.c (Fchar_direction): Function deleted.
7420 (syms_of_character): Don't defsubr it.
7421 <char-direction-table>: Deleted.
7423 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7425 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7426 * doprnt.c: Include limits.h.
7427 (SIZE_MAX): New macro.
7428 (doprnt): Return a size_t value. 2nd arg is now size_t.
7429 Many local variables are now size_t instead of int or unsigned.
7430 Improve overflow protection. Support `l' modifier for integer
7431 conversions. Support %l conversion. Don't assume an EMACS_INT
7432 argument for integer conversions and for %c.
7434 * lisp.h (doprnt): Restore prototype.
7436 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7439 * Makefile.in (base_obj): Add back doprnt.o.
7441 * deps.mk (doprnt.o): Add back prerequisites.
7442 (callint.o): Depend on character.h.
7444 * eval.c (internal_lisp_condition_case): Include the handler
7445 representation in the error message.
7446 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7447 when breaking from the loop.
7449 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7451 * callint.c (Fcall_interactively): When displaying error message
7452 about invalid control letter, pass the character's codepoint, not
7453 a pointer to its multibyte form. Improve display of the character
7454 in octal and display also its hex code.
7456 * character.c (char_string): Use %x to display the (unsigned)
7457 codepoint of an invalid character, to avoid displaying a bogus
7460 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7461 `error', not SYMBOL_NAME itself.
7463 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7464 character arguments to `error'.
7466 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7467 to `error' in error message about FINAL_CHAR argument. Make sure
7468 FINAL_CHAR is a character, and use %c when it is passed as
7469 argument to `error'.
7471 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7473 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7475 * w32.c: Include <time.h>.
7476 (sys_localtime): New function.
7478 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7480 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7482 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7484 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7486 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7489 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7491 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7492 gl_state.e_property when gl_state.object is Qt.
7494 * insdel.c (make_gap_larger): Remove limitation of buffer size
7497 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7499 * xdisp.c (lookup_glyphless_char_display)
7500 (produce_glyphless_glyph): Handle cons cell entry in
7501 glyphless-char-display.
7502 (Vglyphless_char_display): Document it.
7504 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7505 glyphless-char-display.
7507 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7509 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7511 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7513 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7514 definition for no-X builds.
7516 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7518 Static checks with GCC 4.6.0 and non-default toolkits.
7520 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7522 * process.c (keyboard_bit_set): Define only if SIGIO.
7523 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7524 (send_process): Repair possible setjmp clobbering.
7526 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7528 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7530 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7532 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7533 Define only if needed.
7535 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7536 by pacifying GCC about it. Maybe it's time to retire it?
7537 * xfaces.c (USG, __TIMEVAL__): Likewise.
7539 * dispextern.h (struct redisplay_interface): Rename param
7541 * termhooks.h (struct terminal): Likewise.
7542 * xterm.c (xembed_send_message): Likewise.
7544 * insdel.c (make_gap_smaller): Define only if
7545 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7547 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7550 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7551 so that we aren't warned about unused symbols.
7553 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7555 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7557 * xfns.c (x_real_positions): Mark locals as initialized.
7559 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7561 * xterm.c: Fix problems found by static analysis with other toolkits.
7562 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7563 (x_dispatch_event): Declare static if USE_GTK, and
7564 define if USE_GTK || USE_X_TOOLKIT.
7565 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7566 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7567 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7568 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7570 * xmenu.c (menu_help_callback): Pointer type fixes.
7571 Use const pointers when pointing at readonly data. Avoid pointer
7573 (FALSE): Remove unused macro.
7574 (update_frame_menubar): Remove unused decl.
7576 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7578 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7579 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7580 (single_menu_item): Rename local to avoid shadowing.
7582 * keyboard.c (make_lispy_event): Remove unused local var.
7584 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7585 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7587 * bitmaps: Change bitmaps from unsigned char back to the X11
7588 compatible char. Avoid the old compiler warnings about
7589 out-of-range initializers by using, for example, '\xab' rather
7592 * xgselect.c (xgselect_initialize): Check vs interface
7593 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7595 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7597 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7598 to read-only memory.
7600 * fns.c (vector): Remove; this old hack is no longer needed.
7602 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7604 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7606 * xrdb.c (x_load_resources): Omit unused local.
7608 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7609 (x_window): Rename locals to avoid shadowing.
7610 (USG): Use the kludged USG macro, to pacify gcc.
7612 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7613 (x_term_init): Remove local to avoid shadowing.
7615 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7617 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7618 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7620 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7622 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7624 Fix regex.c, syntax.c and friends for buffers > 2GB.
7625 * syntax.h (struct gl_state_s): Declare character position members
7628 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7630 * textprop.c (verify_interval_modification, interval_of):
7631 Declare arguments EMACS_INT.
7633 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7636 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7638 * indent.c (Fvertical_motion): Local variable it_start is now
7641 * regex.c (re_match, re_match_2, re_match_2_internal)
7642 (bcmp_translate, regcomp, regexec, print_double_string)
7643 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7644 (re_compile_pattern, re_exec): Declare arguments and local
7645 variables `size_t' and `ssize_t' and return values `regoff_t', as
7647 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7648 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7649 <compile_stack_type>: `size' and `avail' are now `size_t'.
7651 * regex.h <regoff_t>: Use ssize_t, not int.
7652 (re_search, re_search_2, re_match, re_match_2): Arguments that
7653 specify buffer/string position and length are now ssize_t and
7654 size_t. Return type is regoff_t.
7656 2011-04-16 Ben Key <bkey76@gmail.com>
7658 * nsfont.m: Fixed bugs in ns_get_family and
7659 ns_descriptor_to_entity that were caused by using free to
7660 deallocate memory blocks that were allocated by xmalloc (via
7661 xstrdup). This caused Emacs to crash when compiled with
7662 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7663 --enable-checking=xmallocoverrun). xfree is now used to
7664 deallocate these memory blocks.
7666 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7668 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7670 emacs_write: Accept and return EMACS_INT for sizes.
7671 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7673 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7674 Accept and return EMACS_INT.
7675 (emacs_gnutls_write): Return the number of bytes written on
7677 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7678 (emacs_read, emacs_write): Remove check for negative size, as the
7679 Emacs source code has been audited now.
7680 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7681 (emacs_read, emacs_write): Use it.
7682 * process.c (send_process): Adjust to the new signatures of
7683 emacs_write and emacs_gnutls_write. Do not attempt to store
7684 a byte offset into an 'int'; it might overflow.
7685 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7687 * sound.c: Don't assume sizes fit in 'int'.
7688 (struct sound_device.period_size, alsa_period_size):
7689 Return EMACS_INT, not int.
7690 (struct sound_device.write, vox_write, alsa_write):
7691 Accept EMACS_INT, not int.
7692 (wav_play, au_play): Use EMACS_INT to store sizes and to
7693 record read return values.
7695 2011-04-15 Ben Key <bkey76@gmail.com>
7697 * keyboard.c (Qundefined): Don't declare static since it is used
7699 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7700 static since they are used in nsfont.m.
7702 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7704 * process.c (Qprocessp): Don't declare static.
7705 * lisp.h (Qprocessp): Declare again.
7707 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7709 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7711 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7713 Improve C-level modularity by making more things 'static'.
7715 Don't publish debugger-only interfaces to other modules.
7716 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7717 (verify_bytepos, count_markers): Move decls to the only modules
7719 * region-cache.h (pp_cache): Likewise.
7720 * window.h (check_all_windows): Likewise.
7721 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7723 * sysdep.c (croak): Now static, if
7724 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7725 * syssignal.h (croak): Declare only if not static.
7727 * alloc.c (refill_memory_reserve): Now static if
7728 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7729 * lisp.h (refill_memory_reserve): Declare only if not static.
7731 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7732 Define only if USE_LUCID.
7734 * xrdb.c (x_customization_string, x_rm_string): Now static.
7736 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7737 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7739 * xdisp.c (draw_row_with_mouse_face): Now static.
7740 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7742 * window.h (check_all_windows): Mark externally visible.
7744 * window.c (window_deletion_count): Now static.
7746 * undo.c: Make symbols static if they're not exported.
7747 (last_undo_buffer, last_boundary_position, pending_boundary):
7750 * textprop.c (interval_insert_behind_hooks): Now static.
7751 (interval_insert_in_front_hooks): Likewise.
7753 * term.c: Make symbols static if they're not exported.
7754 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7755 (max_frame_lines, tty_set_terminal_modes):
7756 (tty_reset_terminal_modes, tty_turn_off_highlight):
7757 (get_tty_terminal): Now static.
7758 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7759 * termhooks.h (term_mouse_moveto): Do not declare if
7761 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7762 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7764 * sysdep.c: Make symbols static if they're not exported.
7765 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7767 (sigprocmask_set, full_mask): Remove; unused.
7768 (wait_debugging): Mark as visible.
7769 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7770 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7772 * syntax.c (syntax_temp): Define only if !__GNUC__.
7774 * sound.c (current_sound_device, current_sound): Now static.
7776 * search.c (searchbufs, searchbuf_head): Now static.
7778 * scroll.c (scroll_cost): Remove; unused.
7779 * dispextern.h (scroll_cost): Remove decl.
7781 * region-cache.h (pp_cache): Mark as externally visible.
7783 * process.c: Make symbols static if they're not exported.
7784 (process_tick, update_tick, create_process, chan_process):
7785 (Vprocess_alist, proc_buffered_char, datagram_access):
7786 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7787 (deactivate_process): Mark defn as static, as well as decl.
7788 * lisp.h (create_process): Remove decl.
7789 * process.h (chan_process, Vprocess_alist): Remove decls.
7791 * print.c: Make symbols static if they're not exported.
7792 (print_depth, new_backquote_output, being_printed, print_buffer):
7793 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7794 (print_interval, print_number_index, initial_stderr_stream):
7796 * lisp.h (Fprinc): Remove decl.
7797 (debug_output_compilation_hack): Mark as externally visible.
7799 * sysdep.c (croak): Move decl from here to syssignal.h.
7800 * syssignal.h (croak): Put it here, so the API can be checked when
7801 'croak' is called from dissociate_if_controlling_tty.
7803 * minibuf.c: Make symbols static if they're not exported.
7804 (minibuf_save_list, choose_minibuf_frame): Now static.
7805 * lisp.h (choose_minibuf_frame): Remove decl.
7807 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7809 * lread.c: Make symbols static if they're not exported.
7810 (read_objects, initial_obarray, oblookup_last_bucket_number):
7812 (make_symbol): Remove; unused.
7813 * lisp.h (initial_obarray, make_symbol): Remove decls.
7815 * keyboard.c: Make symbols static if they're not exported.
7816 (single_kboard, recent_keys_index, total_keys, recent_keys):
7817 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7818 (this_single_command_key_start, echoing, last_auto_save):
7819 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7820 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7821 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7822 (Vlispy_mouse_stem, double_click_count):
7824 (force_auto_save_soon): Define only if SIGDANGER.
7825 (ignore_mouse_drag_p): Now static if
7826 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7827 (print_help): Remove; unused.
7828 (stop_character, last_timer_event): Mark as externally visible.
7829 * keyboard.h (ignore_mouse_drag_p): Declare only if
7830 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7831 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7832 * lisp.h (echoing): Remove decl.
7833 (force_auto_save_soon): Declare only if SIGDANGER.
7834 * xdisp.c (redisplay_window): Simplify code, to make it more
7835 obvious that ignore_mouse_drag_p is not accessed if !defined
7836 USE_GTK && !defined HAVE_NS.
7838 * intervals.c: Make symbols static if they're not exported.
7839 (merge_properties_sticky, merge_interval_right, delete_interval):
7841 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7843 * insdel.c: Make symbols static if they're not exported.
7844 However, leave prepare_to_modify_buffer alone. It's never
7845 called from outside this function, but that appears to be a bug.
7846 (combine_after_change_list, combine_after_change_buffer):
7847 (adjust_after_replace, signal_before_change): Now static.
7848 (adjust_after_replace_noundo): Remove; unused.
7849 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7850 (signal_before_change): Remove decls.
7852 * indent.c (val_compute_motion, val_vmotion): Now static.
7854 * image.c: Make symbols static if they're not exported.
7855 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7857 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7858 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7860 * fringe.c (standard_bitmaps): Now static.
7861 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7863 * frame.c: Make symbols static if they're not exported.
7864 (x_report_frame_params, make_terminal_frame): Now static.
7865 (get_frame_param): Now static, unless HAVE_NS.
7866 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7867 (x_get_resource_string): Remove; not used.
7868 * frame.h (make_terminal_frame, x_report_frame_params):
7869 (x_get_resource_string); Remove decls.
7870 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7871 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7873 * font.c, fontset.c: Make symbols static if they're not exported.
7874 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7875 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7876 * font.c (font_close_object): Now static.
7877 * font.h (font_close_object): Remove.
7878 * fontset.c (FONTSET_OBJLIST): Remove.
7879 (free_realized_fontset) #if-0 the body, which does nothing.
7880 (face_suitable_for_char_p): #if-0, as it's never called.
7881 * fontset.h (face_suitable_for_char_p): Remove decl.
7882 * xfaces.c (face_at_string_position):
7883 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7884 since 0 is always ASCII.
7886 * fns.c (weak_hash_tables): Now static.
7888 * fileio.c: Make symbols static if they're not exported.
7889 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7890 (Vwrite_region_annotation_buffers): Now static.
7892 * eval.c: Make symbols static if they're not exported.
7893 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7894 * lisp.h (backtrace_list): Remove decl.
7896 * emacs.c: Make symbols static if they're not exported.
7897 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7898 (fatal_error_code, fatal_error_signal_hook, standard_args):
7900 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7901 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7902 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7903 * lisp.h (fatal_error_signal_hook): Remove decl.
7904 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7906 * editfns.c: Move a (normally-unused) function to its only use.
7907 * editfns.c, lisp.h (get_operating_system_release): Remove.
7908 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7909 worth the hassle of breaking this out.
7911 * xterm.c: Make symbols static if they're not exported.
7912 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7913 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7914 (x_destroy_window, x_delete_display):
7916 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7917 (x_mouse_leave): Remove; unused.
7918 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7919 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7920 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7922 (x_mouse_leave): Declare only if WINDOWSNT.
7923 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7924 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7927 * ftxfont.c: Make symbols static if they're not exported.
7928 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7930 * font.h (ftxfont_driver): Likewise.
7932 * xfns.c: Make symbols static if they're not exported.
7933 (x_last_font_name, x_display_info_for_name):
7934 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7935 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7936 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7937 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7938 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7939 (last_show_tip_args): Now static.
7940 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7941 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7942 (x_screen_planes): Remove; unused.
7943 * dispextern.h (x_screen_planes): Remove decl.
7945 * dispnew.c: Make symbols static if they're not exported.
7946 * dispextern.h (redraw_garbaged_frames, scrolling):
7947 (increment_row_positions): Remove.
7948 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7949 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7951 (redraw_garbaged_frames): Remove; unused.
7953 * xfaces.c: Make symbols static if they're not exported.
7954 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7956 * xterm.h (defined_color): Remove decls.
7957 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7958 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7959 (menu_face_changed_default, defined_color, free_realized_face):
7960 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7961 (ascii_face_of_lisp_face): Remove; unused.
7963 * xdisp.c: Make symbols static if they're not exported.
7964 * dispextern.h (scratch_glyph_row, window_box_edges):
7965 (glyph_to_pixel_coords, set_cursor_from_row):
7966 (get_next_display_element, set_iterator_to_next):
7967 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7968 (show_mouse_face): Remove decls
7969 * frame.h (message_buf_print): Likewise.
7970 * lisp.h (pop_message, set_message, check_point_in_composition):
7972 * xterm.h (set_vertical_scroll_bar): Likewise.
7973 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7974 (message_buf_print, scratch_glyph_row, displayed_buffer):
7975 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7976 (get_next_display_element, show_mouse_face, window_box_edges):
7977 (frame_to_window_pixel_xy, check_point_in_composition):
7978 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7979 (glyph_to_pixel_coords): Remove; unused.
7981 * dired.c (file_name_completion): Now static.
7983 * dbusbind.c (xd_in_read_queued_messages): Now static.
7985 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7986 * data.c (circular_list_error): Remove.
7988 * commands.h (last_point_position, last_point_position_buffer):
7989 (last_point_position_window): Remove decls.
7990 * keyboard.c: Make these variables static.
7992 * coding.h (coding, code_convert_region, encode_coding_gap):
7994 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7995 (iso_code_class, detect_coding, code_convert_region): Now static.
7996 (encode_coding_gap): Remove; unused.
7998 * chartab.c (chartab_chars, chartab_bits): Now static.
8000 * charset.h (charset_iso_8859_1): Remove decl.
8001 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8004 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8005 * ccl.c (Vccl_program_table): Now static.
8006 (check_ccl_update): Remove; unused.
8008 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8009 * category.h: ... from here.
8010 * category.c (check_category_table, set_category_set): Now static.
8012 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8013 * lisp.h: Remove these decls.
8015 * buffer.c (buffer_count): Remove unused var.
8017 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8018 so that it's not optimized away.
8019 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8020 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8021 exported only to the debugger.
8023 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
8024 * atimer.h (run_all_atimers): Remove; not exported.
8026 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8027 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8028 was inaccessible from Lisp.
8029 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8030 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8032 alloc.c: Import and export fewer symbols, and remove unused items.
8033 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8035 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8036 it's not optimized away by whole-program optimization.
8037 (message_enable_multibyte, free_misc): Remove.
8038 (catchlist, handlerlist, mark_backtrace):
8039 Declare only if BYTE_MARK_STACK.
8040 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8041 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8042 (message_enable_multibyte): Remove decl.
8043 (free_misc, interval_free_list, float_block, float_block_index):
8044 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8045 (cons_free_list, last_marked_index):
8047 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8048 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8049 (mark_backtrace): Define only if BYTE_MARK_STACK.
8050 * xdisp.c (message_enable_multibyte): Now static.
8052 Declare Lisp_Object Q* variables to be 'static' if not exported.
8053 This makes it easier for human readers (and static analyzers)
8054 to see whether these variables are used from other modules.
8055 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8056 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8057 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8058 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8059 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8060 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8061 * xmenu.c, xselect.c:
8062 Declare Q* vars static if they are not used in other modules.
8063 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8064 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8065 Remove decls of unexported vars.
8066 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8068 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8070 Make Emacs functions such as Fatom 'static' by default.
8071 This makes it easier for human readers (and static analyzers)
8072 to see whether these functions can be called from other modules.
8073 DEFUN now defines a static function. To make the function external
8074 so that it can be used in other C modules, use the new macro DEFUE.
8075 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8076 (Finit_image_library):
8077 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8078 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8079 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8080 Remove decls, since these functions are now static.
8081 (Funintern, Fget_internal_run_time): New decls, since these functions
8082 were already external.
8084 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8085 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8086 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8087 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8088 * keyboard.c, keymap.c, lread.c:
8089 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8090 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8091 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8092 Mark functions with DEFUE instead of DEFUN,
8093 if they are used in other modules.
8094 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8095 decls for now-static functions.
8096 * buffer.h (Fdelete_overlay): Remove decl.
8097 * callproc.c (Fgetenv_internal): Mark as internal.
8098 * composite.c (Fremove_list_of_text_properties): Remove decl.
8099 (Fcomposition_get_gstring): New forward static decl.
8100 * composite.h (Fcomposite_get_gstring): Remove decl.
8101 * dired.c (Ffile_attributes): New forward static decl.
8102 * doc.c (Fdocumntation_property): New forward static decl.
8103 * eval.c (Ffetch_bytecode): New forward static decl.
8104 (Funintern): Remove extern decl; now in .h file where it belongs.
8105 * fileio.c (Fmake_symbolic_link): New forward static decl.
8106 * image.c (Finit_image_library): New forward static decl.
8107 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8108 * intervals.h (Fprevious_property_change):
8109 (Fremove_list_of_text_properties): Remove decls.
8110 * keyboard.c (Fthis_command_keys): Remove decl.
8111 (Fcommand_execute): New forward static decl.
8112 * keymap.c (Flookup_key): New forward static decl.
8113 (Fcopy_keymap): Now static.
8114 * keymap.h (Flookup_key): Remove decl.
8115 * process.c (Fget_process): New forward static decl.
8116 (Fprocess_datagram_address): Mark as internal.
8117 * syntax.c (Fsyntax_table_p): New forward static decl.
8118 (skip_chars): Remove duplicate decl.
8119 * textprop.c (Fprevious_property_change): New forward static decl.
8120 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8122 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8123 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8125 * editfns.c (Fformat): Remove unreachable code.
8127 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8129 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8132 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8134 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8135 when at ZV. (Bug#8487)
8137 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8139 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8141 * keyboard.c (parse_tool_bar_item): Likewise.
8142 * sound.c (sound_cleanup, alsa_close): Likewise.
8143 * termcap.c (tgetent): Likewise.
8144 * xfns.c (x_default_font_parameter): Likewise.
8145 * xsettings.c (read_and_apply_settings): Likewise.
8147 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8148 (overrun_check_free): Protoize.
8150 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8152 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8153 since callers should never pass a negative size.
8154 Change the signature to match that of plain 'read' and 'write'; see
8155 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8156 * lisp.h: Update prototypes of emacs_write and emacs_read.
8158 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8160 * xdisp.c (redisplay_window): Don't try to determine the character
8161 position of the scroll margin if the window start point w->startp
8162 is outside the buffer's accessible region. (Bug#8468)
8164 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8166 Fix write-region and its subroutines for buffers > 2GB.
8167 * fileio.c (a_write, e_write): Modify declaration of arguments and
8168 local variables to support buffers larger than 2GB.
8169 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8171 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8172 argument, local variables, and return value.
8174 * lisp.h: Update prototypes of emacs_write and emacs_read.
8176 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8178 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8180 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8182 Fix more problems found by GCC 4.6.0's static checks.
8184 * xdisp.c (vmessage): Use a better test for character truncation.
8186 * charset.c (load_charset_map): <, not <=, for optimization,
8187 and to avoid potential problems with integer overflow.
8188 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8189 * casetab.c (set_identity, shuffle): Likewise.
8190 * editfns.c (Fformat): Likewise.
8191 * syntax.c (skip_chars): Likewise.
8193 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8194 This also lets GCC 4.6.0 generate slightly better loop code.
8196 * callint.c (Fcall_interactively): <, not <=, for optimization.
8197 (Fcall_interactively): Count the number of arguments produced,
8198 not the number of arguments given. This is simpler and lets GCC
8199 4.6.0 generate slightly better code.
8201 * ftfont.c: Distingish more carefully between FcChar8 and char.
8202 The previous code passed unsigned char * to a functions like
8203 strlen and xstrcasecmp that expect char *, which does not
8204 conform to the C standard.
8205 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8206 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8207 char * when the C standard requires it.
8209 * keyboard.c (read_char): Remove unused var.
8211 * eval.c: Port to Windows vsnprintf (Bug#8435).
8213 (SIZE_MAX): Define if the headers do not.
8214 (verror): Do not give up if vsnprintf returns a negative count.
8215 Instead, grow the buffer. This ports to Windows vsnprintf, which
8216 does not conform to C99. Problem reported by Eli Zaretskii.
8217 Also, simplify the allocation scheme, by avoiding the need for
8218 calling realloc, and removing the ALLOCATED variable.
8220 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8222 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8223 But keep the doprint source code for now, as we might revamp it
8224 and use it again (Bug#8435).
8225 * lisp.h (doprnt): Remove.
8226 * Makefile.in (base_obj): Remove doprnt.o.
8227 * deps.mk (doprnt.o): Remove.
8229 error: Print 32- and 64-bit integers portably (Bug#8435).
8230 Without this change, on typical 64-bit hosts error ("...%d...", N)
8231 was used to print both 32- and 64-bit integers N, which relied on
8233 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8234 * lisp.h (error, verror): Mark as printf-like functions.
8235 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8236 Report overflow in size calculations when allocating printf buffer.
8237 Do not truncate output string at its first null byte.
8238 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8239 Truncate the output at a character boundary, since vsnprintf does not
8241 * charset.c (check_iso_charset_parameter): Convert internal
8242 character to string before calling 'error', since %c now has the
8244 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8245 overflow when computing char to be passed to 'error'. Do not
8246 pass Lisp_Object to 'error'; pass the integer instead.
8247 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8248 formatted with plain %d.
8250 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8252 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8254 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8256 * xterm.c (x_catch_errors): Remove duplicate declaration.
8258 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8260 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8262 2011-04-10 Jim Meyering <meyering@redhat.com>
8264 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8265 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8266 return ssize_t not "int", and use size_t as the buffer length.
8267 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8268 * gnutls.h: Update declarations.
8269 * process.c (read_process_output): Use ssize_t, to match.
8270 (send_process): Likewise.
8272 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8274 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8276 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8278 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8279 Use unsigned char, to match FcChar8 type definition.
8281 * xterm.c (handle_one_xevent):
8282 * xmenu.c (create_and_show_popup_menu):
8283 * xselect.c (x_decline_selection_request)
8284 (x_reply_selection_request): Avoid type-punned deref of X events.
8286 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8288 Fix some uses of `int' instead of EMACS_INT.
8289 * search.c (string_match_1, fast_string_match)
8290 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8291 (scan_buffer, find_next_newline_no_quit)
8292 (find_before_next_newline, search_command, Freplace_match)
8293 (Fmatch_data): Make some `int' variables be EMACS_INT.
8295 * xdisp.c (display_count_lines): 3rd argument and return value now
8296 EMACS_INT. All callers changed.
8297 (pint2hrstr): Last argument is now EMACS_INT.
8299 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8300 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8301 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8302 (decode_coding_utf_16, decode_coding_emacs_mule)
8303 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8304 (decode_coding_ccl, decode_coding_charset)
8305 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8306 (decode_coding_iso_2022, decode_coding_emacs_mule)
8307 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8308 <char_offset, last_offset>: Declare EMACS_INT.
8309 (encode_coding_utf_8, encode_coding_utf_16)
8310 (encode_coding_emacs_mule, encode_invocation_designation)
8311 (encode_designation_at_bol, encode_coding_iso_2022)
8312 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8313 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8315 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8316 (encode_invocation_designation): Last argument P_NCHARS is now
8318 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8319 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8321 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8324 * ccl.c (Fccl_execute_on_string): Declare some variables
8327 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8329 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8331 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8333 * process.c (Fformat_network_address): Doc fix.
8335 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8337 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8339 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8341 * keyboard.c (read_char): Call Lisp function help-form-show,
8342 instead of using internal_with_output_to_temp_buffer.
8343 (Qhelp_form_show): New var.
8344 (syms_of_keyboard): Use DEFSYM macro.
8346 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8348 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8350 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8352 * process.c (Flist_processes): Remove to Lisp.
8353 (list_processes_1): Delete.
8355 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8357 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8359 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8361 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8363 Fix more problems found by GCC 4.6.0's static checks.
8365 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8367 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8369 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8371 * xdisp.c (vmessage): Mark as a printf-like function.
8373 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8375 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8377 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8378 printf-like functions.
8379 (tiff_load): Add casts to remove these marks before passing them
8380 to system-supplied API.
8382 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8384 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8385 This avoids several warnings with gcc -Wstrict-overflow.
8386 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8387 directly, rather than having caller test rule sign. This avoids
8388 some unnecessary tests.
8389 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8390 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8391 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8393 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8394 (xfont_open): Avoid unnecessary tests.
8396 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8398 * composite.h, composite.c (composition_gstring_put_cache):
8399 Use EMACS_INT, not int, for length.
8401 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8402 breaking out part of COMPOSITION_DECODE_RULE.
8403 (COMPOSITION_DECODE_RULE): Use it.
8404 * composite.c (get_composition_id): Remove unused local vars,
8405 by using the new macro.
8407 * textprop.c (set_text_properties_1): Change while to do-while,
8408 since the condition is always true at first.
8410 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8411 (interval_deletion_adjustment): Return unsigned value.
8414 * process.c (list_processes_1, create_pty, read_process_output):
8415 (exec_sentinel): Remove vars that were set but not used.
8416 (create_pty): Remove unnecessary "volatile"s.
8417 (Fnetwork_interface_info): Avoid possibility of int overflow.
8418 (read_process_output): Do adaptive read buffering even if carryover.
8419 (read_process_output): Simplify nbytes computation if buffered.
8421 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8423 * syntax.c (scan_words): Remove var that was set but not used.
8424 (update_syntax_table): Use unsigned instead of int.
8426 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8427 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8428 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8430 * print.c (print_error_message): Avoid int overflow.
8432 * font.c (font_list_entities): Redo for clarity,
8433 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8435 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8436 (font_score): Avoid potential overflow in diff calculation.
8438 * fns.c (substring_both): Remove var that is set but not used.
8439 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8441 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8443 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8444 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8445 can always succeed if overflow has undefined behavior.
8447 * search.c (boyer_moore, wordify): Remove vars set but not used.
8448 (wordify): Omit three unnecessary tests.
8450 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8451 All callers changed. This avoids the need for an unused var.
8453 * casefiddle.c (casify_region): Remove var that is set but not used.
8455 * dired.c (file_name_completion): Remove var that is set but not used.
8457 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8459 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8460 (Finsert_file_contents): Remove unnecessary code checking fd.
8462 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8463 Check for integer overflow on size calculations.
8465 * buffer.c (Fprevious_overlay_change): Remove var that is set
8468 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8469 Remove vars that are set but not used.
8470 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8471 (timer_check_2): Mark vars as initialized.
8473 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8475 * image.c (lookup_image): Remove var that is set but not used.
8476 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8478 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8479 that are set but not used.
8481 * xfns.c (make_invisible_cursor): Don't return garbage
8482 if XCreateBitmapFromData fails (Bug#8410).
8484 * xselect.c (x_get_local_selection, x_handle_property_notify):
8485 Remove vars that are set but not used.
8487 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8488 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8490 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8491 Remove var that is set but not used.
8492 (scroll_bar_windows_size): Now size_t, not int.
8493 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8496 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8497 (map_tty_color) [!defined MSDOS]: Likewise.
8499 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8501 * coding.c: Remove vars that are set but not used.
8502 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8503 All callers changed.
8504 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8505 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8506 (decode_coding_charset): Remove vars that are set but not used.
8508 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8509 that is set but not used.
8511 * print.c (print_object): Remove var that is set but not used.
8513 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8514 The gnulib version avoids calling malloc in the usual case,
8515 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8516 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8517 * filelock.c (current_lock_owner): Likewise.
8518 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8519 * sysdep.c: Include allocator.h, careadlinkat.h.
8520 (emacs_no_realloc_allocator): New static constant.
8521 (emacs_readlink): New function.
8522 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8523 ../lib/careadlinkat.h.
8525 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8527 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8528 first non-nil return value).
8530 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8532 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8533 if not defined (Bug#8403).
8535 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8537 * xdisp.c (display_count_lines): Remove parameter `start',
8538 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8539 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8540 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8541 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8542 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8543 and thereabouts. All callers changed.
8544 (get_per_char_metric): Remove parameter `f', unused since
8545 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8547 2011-04-02 Jim Meyering <meyering@redhat.com>
8549 do not dereference NULL upon failed strdup
8550 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8551 (ns_get_family): Likewise.
8553 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8555 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8557 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8559 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8562 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8564 Add lexical binding.
8566 * window.c (Ftemp_output_buffer_show): New fun.
8567 (Fsave_window_excursion):
8568 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8570 * lread.c (lisp_file_lexically_bound_p): New function.
8571 (Fload): Bind Qlexical_binding.
8572 (readevalloop): Remove `evalfun' arg.
8573 Bind Qinternal_interpreter_environment.
8574 (Feval_buffer): Bind Qlexical_binding.
8575 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8577 (syms_of_lread): Declare `lexical-binding'.
8579 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8581 * keyboard.c (eval_dyn): New fun.
8582 (menu_item_eval_property): Use it.
8584 * image.c (parse_image_spec): Use Ffunctionp.
8586 * fns.c (concat, mapcar1): Accept byte-code-functions.
8588 * eval.c (Fsetq): Handle lexical vars.
8589 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8590 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8591 (FletX, Flet): Obey lexical binding.
8592 (Fcommandp): Handle closures.
8593 (Feval): New `lexical' arg.
8594 (eval_sub): New function extracted from Feval. Use it almost
8595 everywhere where Feval was used. Look up vars in lexical env.
8597 (Ffunctionp): Move from subr.el.
8598 (Ffuncall): Handle closures.
8599 (apply_lambda): Remove `eval_flags'.
8600 (funcall_lambda): Handle closures and new byte-code-functions.
8601 (Fspecial_variable_p): New function.
8602 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8603 but without exporting it to Lisp.
8605 * doc.c (Fdocumentation, store_function_docstring):
8606 * data.c (Finteractive_form): Handle closures.
8608 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8611 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8613 (exec_byte_code): New function extracted from Fbyte_code to handle new
8614 calling convention for byte-code-functions. Add new byte-codes.
8616 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8618 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8620 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8622 * xdisp.c (redisplay_internal): Fix prototype.
8624 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8626 * xdisp.c (SCROLL_LIMIT): New macro.
8627 (try_scrolling): Use it when setting scroll_limit.
8628 Limit scrolling to 100 screen lines.
8629 (redisplay_window): Even when falling back on "recentering",
8630 position point in the window according to scroll-conservatively,
8631 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8633 (try_scrolling): When point is above the window, allow searching
8634 as far as scroll_max, or one screenful, to compute vertical
8635 distance from PT to the scroll margin position. This prevents
8636 try_scrolling from unnecessarily failing when
8637 scroll-conservatively is set to a value slightly larger than the
8638 window height. Clean up the case of PT below the margin at bottom
8639 of window: scroll_max can no longer be INT_MAX. When aggressive
8640 scrolling is in use, don't let point enter the opposite scroll
8641 margin as result of the scroll.
8642 (syms_of_xdisp) <scroll-conservatively>: Document the
8643 threshold of 100 lines for never-recentering scrolling.
8645 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8647 * dispextern.h (move_it_by_lines):
8648 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8649 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8650 (message_log_check_duplicate): Remove parameters `prev_bol' and
8651 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8652 (redisplay_internal): Remove parameter `preserve_echo_area',
8653 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8655 * indent.c (Fvertical_motion):
8656 * window.c (window_scroll_pixel_based, Frecenter):
8657 Don't pass `need_y_p' to `move_it_by_lines'.
8659 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8661 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8662 steal a few bits to be more compact.
8663 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8664 Remove unneeded casts.
8666 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8668 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8670 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8671 binding" message (bug#7967).
8673 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8675 Fix more problems found by GCC 4.6.0's static checks.
8677 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8678 Remove unused local var.
8680 * editfns.c (Fmessage_box): Remove unused local var.
8682 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8683 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8684 Omit unused local vars.
8685 * window.c (shrink_windows): Omit unused local var.
8686 * menu.c (digest_single_submenu): Omit unused local var.
8687 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8688 Omit unused local var.
8690 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8691 Don't assume string length fits in int.
8692 (keyremap_step, read_key_sequence): Use size_t for sizes.
8693 (read_key_sequence): Don't check last_real_key_start redundantly.
8695 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8696 instead of alloca (Bug#8344).
8698 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8699 (Fbacktrace_frame): Don't assume nframes fits in int.
8701 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8703 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8706 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8708 * cm.c (calccost): Turn while-do into do-while, for clarity.
8710 * keyboard.c (syms_of_keyboard): Use the same style as later
8711 in this function when indexing through an array. This also
8712 works around GCC bug 48267.
8714 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8716 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8718 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8719 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8721 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8722 This avoids undefined behavior on integer overflow, and is a bit
8723 more convenient anyway since it is compared to a size_t variable.
8725 Variadic C functions now count arguments with size_t, not int.
8726 This avoids an unnecessary limitation on 64-bit machines, which
8727 caused (substring ...) to crash on large vectors (Bug#8344).
8728 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8729 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8730 All variadic functions and their callers changed accordingly.
8731 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8732 * data.c (arith_driver, float_arith_driver): Likewise.
8733 * editfns.c (general_insert_function): Likewise.
8734 * eval.c (struct backtrace.nargs, interactive_p)
8735 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8736 (funcall_lambda, mark_backtrace): Likewise.
8737 * fns.c (concat): Likewise.
8738 * frame.c (x_set_frame_parameters): Likewise.
8739 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8740 0 if not found, not -1. All callers changed.
8742 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8743 (stack_copy_size): Now size_t, not int.
8744 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8746 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8748 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8749 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8750 All callers changed.
8752 * lisp.h (multibyte_char_to_unibyte):
8753 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8754 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8755 * character.h (CHAR_TO_BYTE8):
8756 * cmds.c (internal_self_insert):
8757 * editfns.c (general_insert_function):
8758 * keymap.c (push_key_description):
8759 * search.c (Freplace_match):
8760 * xdisp.c (message_dolog, set_message_1): All callers changed.
8762 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8764 * keyboard.c (safe_run_hook_funcall): New function.
8765 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8766 don't set the hook to nil, but remove the offending function instead.
8767 (Qcommand_hook_internal): Remove, unused.
8768 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8769 Vcommand_hook_internal.
8771 * eval.c (enum run_hooks_condition): Remove.
8772 (funcall_nil, funcall_not): New functions.
8773 (run_hook_with_args): Call each function through a `funcall' argument.
8774 Remove `cond' argument, now redundant.
8775 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8776 (Frun_hook_with_args_until_failure): Adjust accordingly.
8777 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8779 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8781 * dispextern.h (string_buffer_position): Remove declaration.
8783 * print.c (strout): Remove parameter `multibyte', unused since
8784 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8786 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8787 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8788 All callers changed.
8790 * w32.c (_wsa_errlist): Use braces for struct initializers.
8792 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8793 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8794 All callers changed.
8795 (string_buffer_position): Likewise. Also, make static (it's never
8796 used outside xdisp.c).
8797 (cursor_row_p): Remove parameter `w', unused since
8798 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8799 (decode_mode_spec): Remove parameter `precision', introduced during
8800 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8801 All callers changed.
8803 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8805 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8807 2011-03-27 Anders Lindgren <andlind@gmail.com>
8809 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8810 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8811 (ns_update_auto_hide_menu_bar): New functions.
8812 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8813 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8814 ns_constrain_all_frames.
8815 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8816 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8818 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8820 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8822 2011-03-27 Glenn Morris <rgm@gnu.org>
8824 * syssignal.h: Replace RETSIGTYPE with void.
8825 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8826 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8827 Replace SIGTYPE with void everywhere.
8828 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8829 * s/template.h (SIGTYPE): Remove commented out definition.
8831 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8833 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8834 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8836 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8838 * w32.c (read_unc_volume): Use parameter `henum', instead of
8839 global variable `wget_enum_handle'.
8841 * keymap.c (describe_vector): Remove parameters `indices' and
8842 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8843 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8845 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8847 * keyboard.c (timer_check): Remove parameter `do_it_now',
8848 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8849 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8850 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8852 * keyboard.c (read_char):
8853 * w32menu.c (w32_menu_display_help):
8854 * xmenu.c (show_help_event, menu_help_callback):
8855 Adjust calls to `show_help_echo'.
8857 * gtkutil.c (xg_maybe_add_timer):
8858 * keyboard.c (readable_events):
8859 * process.c (wait_reading_process_output):
8860 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8862 * insdel.c (adjust_markers_gap_motion):
8863 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8864 (gap_left, gap_right): Don't call it.
8866 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8868 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8869 incurred during fontification.
8871 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8873 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8874 (DEFVAR_PER_BUFFER): Don't pass it.
8876 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8877 (scrolling_window): Don't pass it.
8879 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8881 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8883 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8885 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8886 of variables specific to SELinux and computation of `encoded_absname'.
8888 * image.c (XPutPixel): Remove unused variable `height'.
8890 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8892 * unexw32.c (get_section_info): Remove unused variable `section'.
8894 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8895 (system_process_attributes): Remove unused variable `sess'.
8896 (sys_read): Remove unused variable `err'.
8898 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8899 (w32_wnd_proc): Remove unused variable `isdead'.
8900 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8901 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8902 (x_create_tip_frame): Remove unused variable `tem'.
8904 * w32inevt.c (w32_console_read_socket):
8905 Remove unused variable `no_events'.
8907 * w32term.c (x_draw_composite_glyph_string_foreground):
8908 Remove unused variable `width'.
8910 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8912 * w32term.c (x_set_glyph_string_clipping):
8913 Don't pass uninitialized region to CombineRgn.
8915 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8917 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8918 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8919 (Fx_close_connection): Remove unused variable `i'.
8921 * w32font.c (w32font_draw): Return number of glyphs.
8922 (w32font_open_internal): Remove unused variable `i'.
8923 (w32font_driver): Add missing initializer.
8925 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8926 (fill_in_menu): Remove unused variable `items_added'.
8928 * w32term.c (last_mouse_press_frame): Remove static global variable.
8929 (w32_clip_to_row): Remove unused variable `f'.
8930 (x_delete_terminal): Remove unused variable `i'.
8932 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8933 (NOTHING): Remove unused static global variable.
8934 (uniscribe_check_otf): Remove unused variable `table'.
8935 (uniscribe_font_driver): Add missing initializers.
8937 2011-03-23 Julien Danjou <julien@danjou.info>
8939 * term.c (Fsuspend_tty, Fresume_tty):
8940 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8941 * window.c (temp_output_buffer_show):
8942 * insdel.c (signal_before_change):
8943 * frame.c (Fhandle_switch_frame):
8944 * fileio.c (Fdo_auto_save):
8945 * emacs.c (Fkill_emacs):
8946 * editfns.c (save_excursion_restore):
8947 * cmds.c (internal_self_insert):
8948 * callint.c (Fcall_interactively):
8949 * buffer.c (Fkill_all_local_variables):
8950 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8952 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8953 unconditionally since it does the check itself.
8955 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8957 Fix more problems found by GCC 4.5.2's static checks.
8959 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8960 the first time through the loop, since we know p0 < p1 then.
8961 This also avoids a gcc -Wstrict-overflow warning.
8963 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8964 leading to a memory leak, possible in functions like
8965 load_charset_map_from_file that can allocate an unbounded number
8966 of objects (Bug#8318).
8968 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8969 that could (at least in theory) be that large.
8971 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8972 This is less likely to overflow, and avoids undefined behavior if
8973 overflow does occur. All callers changed. Use strtoul to scan
8974 for the unsigned long integer.
8975 (pint2hrstr): Simplify and tune code slightly.
8976 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8978 * scroll.c (do_scrolling): Work around GCC bug 48228.
8979 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8981 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8982 This also avoids a warning with gcc -Wstrict-overflow.
8983 (validate_x_resource_name): Simplify count usage.
8984 This also avoids a warning with gcc -Wstrict-overflow.
8986 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8989 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8991 * process.c (Fmake_network_process): Use socklen_t, not int,
8992 where POSIX says socklen_t is required in portable programs.
8993 This fixes a porting bug on hosts like 64-bit HP-UX, where
8994 socklen_t is wider than int (Bug#8277).
8995 (Fmake_network_process, server_accept_connection):
8996 (wait_reading_process_output, read_process_output):
8999 * process.c: Rename or move locals to avoid shadowing.
9000 (list_processes_1, Fmake_network_process):
9001 (read_process_output_error_handler, exec_sentinel_error_handler):
9002 Rename or move locals.
9003 (Fmake_network_process): Define label "retry_connect" only if needed.
9004 (Fnetwork_interface_info): Fix pointer signedness.
9005 (process_send_signal): Add cast to avoid pointer signedness problem.
9006 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
9007 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
9009 Make tparam.h and terminfo.c consistent.
9010 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9011 Include tparam.h instead, since it declares them.
9012 * cm.h (PC): Remove extern decl; tparam.h now does this.
9013 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9014 * terminfo.c: Include tparam.h, to check interfaces.
9015 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9016 (tparam): Adjust signature to match interface in tparam.h;
9017 this removes some undefined behavior. Check that outstring and len
9018 are zero, which they always are with Emacs.
9019 * tparam.h (PC, BC, UP): New extern decls.
9021 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
9022 (xftfont_open): Rename locals to avoid shadowing.
9024 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
9025 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9026 (OTF_TAG_SYM): Omit macro if not needed.
9027 (ftfont_list): Remove unused local.
9028 (get_adstyle_property, ftfont_pattern_entity):
9029 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9030 Rename locals to avoid shadowing.
9032 * xfont.c (xfont_list_family): Mark var as initialized.
9034 * xml.c (make_dom): Now static.
9036 * composite.c (composition_compute_stop_pos): Rename local to
9038 (composition_reseat_it): Remove unused locals.
9039 (find_automatic_composition, composition_adjust_point): Likewise.
9040 (composition_update_it): Mark var as initialized.
9041 (find_automatic_composition): Mark vars as initialized,
9042 with a FIXME (Bug#8290).
9044 character.h: Rename locals to avoid shadowing.
9045 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9046 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9047 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9048 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9051 * textprop.c (property_change_between_p): Remove; unused.
9053 * intervals.c (interval_start_pos): Now static.
9055 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9057 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9058 Rename locals to avoid shadowing.
9060 * sound.c (wav_play, au_play, Fplay_sound_internal):
9061 Fix pointer signedness.
9062 (alsa_choose_format): Remove unused local var.
9063 (wav_play): Initialize a variable to 0, to prevent undefined
9064 behavior (Bug#8278).
9066 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9068 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9070 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9071 clobbering (Bug#8298).
9072 * sysdep.c (sys_subshell): Likewise.
9073 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9075 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9076 This should get cleaned up, so that child_setup has the
9077 same signature on all platforms.
9079 * callproc.c (call_process_cleanup): Now static.
9080 (relocate_fd): Rename locals to avoid shadowing.
9082 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9084 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9085 not to be necessary, and produces flickering.
9087 2011-03-20 Glenn Morris <rgm@gnu.org>
9089 * config.in: Remove file.
9091 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9093 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9094 are now in src/globals.h.
9095 (syms_of_minibuf): Remove spurious & from previous change.
9097 2011-03-20 Leo Liu <sdl.web@gmail.com>
9099 * minibuf.c (completing-read-function): New variable.
9100 (completing-read-default): Rename from completing-read.
9101 (completing-read): Call completing-read-function.
9103 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9105 * xfaces.c (Fx_load_color_file):
9106 Read color file from absolute filename (bug#8250).
9108 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9110 * makefile.w32-in: Update dependencies.
9112 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9114 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9116 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9118 Fix more problems found by GCC 4.5.2's static checks.
9120 * process.c (make_serial_process_unwind, send_process_trap):
9121 (sigchld_handler): Now static.
9123 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9124 That way, the code declares only the vars that it needs.
9125 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9126 * s/cygwin.h (PTY_ITERATION): Likewise.
9127 * s/darwin.h (PTY_ITERATION): Likewise.
9128 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9130 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9131 * process.c (allocate_pty): Don't declare stb unless it's needed.
9133 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9134 (CONSTANTLIM): Remove; unused.
9135 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9136 Define only if needed.
9138 * unexelf.c (unexec): Name an expression,
9139 to avoid gcc -Wbad-function-cast warning.
9140 Use a different way to cause a compilation error if anyone uses
9141 n rather than nn, a way that does not involve shadowing.
9142 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9144 * deps.mk (unexalpha.o): Remove; unused.
9146 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9147 * unexec.h: New file.
9148 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9149 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9151 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9152 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9153 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9154 Change as necessary to match prototype in unexec.h.
9156 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9158 (back_comment, skip_chars): Mark vars as initialized.
9160 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9161 Rename locals to avoid shadowing.
9163 * lread.c (read1): Rewrite so as not to use empty "else".
9164 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9166 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9168 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9169 warning when compiling print.c.
9171 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9172 instead of using an uninitialized var.
9173 (font_sort_entities): Mark var as initialized.
9175 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9177 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9178 pointers to constants.
9179 (font_parse_fcname): Remove unused vars.
9180 (font_delete_unmatched): Now static.
9181 (font_get_spec): Remove; unused.
9182 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9183 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9184 Rename or move locals to avoid shadowing.
9186 * fns.c (require_nesting_list, require_unwind): Now static.
9187 (Ffillarray): Rename locals to avoid shadowing.
9189 * floatfns.c (domain_error2): Define only if needed.
9190 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9192 * alloc.c (mark_backtrace): Move decl from here ...
9193 * lisp.h: ... to here, so that it can be checked.
9195 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9196 (Fdefvar): Rewrite so as not to use empty "else".
9197 (lisp_indirect_variable): Name an expression,
9198 to avoid gcc -Wbad-function-cast warning.
9199 (Fdefvar): Rename locals to avoid shadowing.
9201 * callint.c (quotify_arg, quotify_args): Now static.
9202 (Fcall_interactively): Rename locals to avoid shadowing.
9203 Use const pointer when appropriate.
9205 * lisp.h (get_system_name, get_operating_system_release):
9206 Move decls here, to check interfaces.
9207 * process.c (get_operating_system_release): Move decl to lisp.h.
9208 * xrdb.c (get_system_name): Likewise.
9209 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9210 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9211 some of which prompt warnings from gcc -Wbad-function-cast.
9212 (Fformat_time_string, Fencode_time, Finsert_char):
9213 (Ftranslate_region_internal, Fformat):
9214 Rename or remove local vars to avoid shadowing.
9215 (Ftranslate_region_internal): Mark var as initialized.
9217 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9220 * lisp.h (eassert): Check that the argument compiles, even if
9221 ENABLE_CHECKING is not defined.
9223 * data.c (Findirect_variable): Name an expression, to avoid
9224 gcc -Wbad-function-cast warning.
9225 (default_value, arithcompare, arith_driver, arith_error): Now static.
9226 (store_symval_forwarding): Rename local to avoid shadowing.
9227 (Fmake_variable_buffer_local, Fmake_local_variable):
9228 Mark variables as initialized.
9229 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9231 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9232 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9233 Rename locals to avoid shadowing.
9234 (mark_stack): Move local variables into the #ifdef region where
9236 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9237 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9239 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9240 (GC_STRING_CHARS): Remove; not used.
9241 (Fmemory_limit): Cast sbrk's returned value to char *.
9243 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9244 avoids undefined behavior in theory.
9246 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9248 Use functions, not macros, for up- and down-casing (Bug#8254).
9249 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9250 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9251 to use the following functions instead of these macros.
9252 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9253 EMACS_INT, since callers assume the returned value fits in int.
9254 (upcase1): Likewise, for UPCASE_TABLE.
9255 (uppercasep, lowercasep, upcase): New static inline functions.
9256 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9257 the race-condition problem in the old DOWNCASE.
9259 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9260 Rename locals to avoid shadowing.
9261 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9262 (regex_compile, re_search_2, re_match_2_internal):
9263 Remove unused local vars.
9264 (FREE_VAR): Rewrite so as not to use empty "else",
9265 which gcc can warn about.
9266 (regex_compile, re_match_2_internal): Mark locals as initialized.
9267 (RETALLOC_IF): Define only if needed.
9268 (WORDCHAR_P): Likewise. This one is never needed, but is used
9269 only in a comment talking about a compiler bug, so put inside
9270 the #if 0 of that comment.
9271 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9272 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9275 * search.c (boyer_moore): Rename locals to avoid shadowing.
9276 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9277 (PREV_CHAR_BOUNDARY): Likewise.
9279 * search.c (simple_search): Remove unused var.
9281 * dired.c (compile_pattern): Move decl from here ...
9282 * lisp.h: ... to here, so that it can be checked.
9283 (struct re_registers): New forward decl.
9285 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9287 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9289 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9290 Rename locals to avoid shadowing.
9291 (Fvertical_motion): Mark locals as initialized.
9293 * casefiddle.c (casify_object, casify_region): Now static.
9294 (casify_region): Mark local as initialized.
9296 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9298 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9299 New macros, so that the caller can use some names other than
9300 gcpro1, gcpro2, etc.
9301 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9303 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9304 argument, for consistency with GCPRO2_VAR, etc: it is now the
9305 prefix of the variable, not the variable itself. All uses
9307 * dired.c (directory_files_internal, file_name_completion):
9308 Rename locals to avoid shadowing.
9310 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9311 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9312 dired.c's scmp function, had undefined behavior.
9313 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9314 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9315 * buffer.h: ... to here, because these macros use current_buffer,
9316 and the new implementation with inline functions needs to have
9317 current_buffer in scope now, rather than later when the macros
9319 (downcase, upcase1): New static inline functions.
9320 (DOWNCASE, UPCASE1): Reimplement using these functions.
9321 This avoids undefined behavior in expressions like
9322 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9323 from race conditions in accessing the global variables
9324 case_temp1 and case_temp2.
9325 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9326 * lisp.h (case_temp1, case_temp2): Remove their decls.
9327 * character.h (ASCII_CHAR_P): Move from here ...
9328 * lisp.h: ... to here, so that the inline functions mentioned
9331 * dired.c (directory_files_internal_unwind): Now static.
9333 * fileio.c (file_name_as_directory, directory_file_name):
9334 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9336 (file_name_as_directory): Use const pointers when appropriate.
9337 (Fexpand_file_name): Likewise. In particular, newdir might
9338 point at constant storage, so make it a const pointer.
9339 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9340 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9342 (Fset_file_times, Finsert_file_contents, auto_save_error):
9343 Rename locals to avoid shadowing.
9345 * minibuf.c (choose_minibuf_frame_1): Now static.
9346 (Ftry_completion, Fall_completions): Rename or remove locals
9349 * marker.c (bytepos_to_charpos): Remove; unused.
9351 * lisp.h (verify_bytepos, count_markers): New decls,
9352 so that gcc does not warn that these functions aren't declared.
9354 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9355 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9356 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9357 (copy_text): Remove unused local var.
9359 * filelock.c (within_one_second): Now static.
9360 (lock_file_1): Rename local to avoid shadowing.
9362 * buffer.c (fix_overlays_before): Mark locals as initialized.
9363 (fix_start_end_in_overlays): Likewise. This function should be
9364 simplified by using pointers-to-pointers, but that's a different
9366 (switch_to_buffer_1): Now static.
9367 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9368 (report_overlay_modification): Rename locals to avoid shadowing.
9370 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9371 Fix pointer signedness issue.
9372 (sys_subshell): Mark local as volatile if checking for lint,
9373 to suppress a gcc -Wclobbered warning that does not seem to be right.
9374 (MAXPATHLEN): Define only if needed.
9376 * process.c (serial_open, serial_configure): Move decls from here ...
9377 * systty.h: ... to here, so that they can be checked.
9379 * fns.c (get_random, seed_random): Move extern decls from here ...
9380 * lisp.h: ... to here, so that they can be checked.
9382 * sysdep.c (reset_io): Now static.
9383 (wait_for_termination_signal): Remove; unused.
9385 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9386 (copy_keymap_item, append_key, push_text_char_description):
9388 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9389 (DENSE_TABLE_SIZE): Remove; unused.
9390 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9391 (describe_map_tree):
9392 Rename locals to avoid shadowing.
9394 * keyboard.c: Declare functions static if they are not used elsewhere.
9395 (echo_char, echo_dash, cmd_error, top_level_2):
9396 (poll_for_input, handle_async_input): Now static.
9397 (read_char, kbd_buffer_get_event, make_lispy_position):
9398 (make_lispy_event, make_lispy_movement, apply_modifiers):
9399 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9400 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9401 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9402 (read_key_sequence, read_char): Mark locals as initialized.
9403 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9405 * keyboard.h (make_ctrl_char): New decl.
9406 (mark_kboards): Move decl here ...
9407 * alloc.c (mark_kboards): ... from here.
9409 * lisp.h (force_auto_save_soon): New decl.
9411 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9412 (DEFINE_DUMMY_FUNCTION): New macro.
9413 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9415 (main): Add casts to avoid warnings
9416 if GCC considers string literals to be constants.
9418 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9420 * dbusbind.c: Pointer signedness fixes.
9421 (xd_signature, xd_append_arg, xd_initialize):
9422 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9423 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9424 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9425 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9427 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9428 if GCC considers string literals to be constants.
9429 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9431 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9433 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9434 (print_preprocess, print_object): New macro to fix last change.
9436 * print.c (print_preprocess): Don't forget font objects.
9438 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9440 * emacs.c (USAGE3): Doc fixes.
9442 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9444 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9447 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9449 * lisp.h (VWindow_system, Qfile_name_history):
9450 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9451 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9452 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9454 * w32select.c: Don't #include "keyboard.h".
9455 (run_protected): Add extern declaration for waiting_for_input.
9457 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9458 * w32console.c (detect_input_pending, read_input_pending)
9459 (encode_terminal_code):
9460 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9461 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9462 (w32_system_caret_y, Qfile_name_history):
9463 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9464 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9465 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9466 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9467 * w32proc.c (Qlocal, report_file_error):
9468 * w32term.c (Vwindow_system, updating_frame):
9469 * w32uniscribe.c (initialized, uniscribe_font_driver):
9470 Remove unneeded extern declarations.
9472 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9474 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9476 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9478 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9479 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9480 These macros can no longer be used for assignment.
9482 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9483 Assign struct members directly, instead of using BUF_BEGV etc.
9484 (record_buffer_markers, fetch_buffer_markers): New functions for
9485 recording and fetching special buffer markers.
9486 (set_buffer_internal_1, set_buffer_temp): Use them.
9488 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9490 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9492 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9493 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9495 * xdisp.c (hscroll_window_tree):
9496 (reconsider_clip_changes): Use PT instead of BUF_PT.
9498 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9500 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9501 $(EMACS_ROOT)/lib/intprops.h.
9503 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9505 Fix more problems found by GCC 4.5.2's static checks.
9507 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9508 to unsigned char * to avoid compiler diagnostic.
9509 (xg_free_frame_widgets): Make it clear that a local variable is
9510 needed only if USE_GTK_TOOLTIP.
9511 (gdk_window_get_screen): Make it clear that this macro is needed
9512 only if USE_GTK_TOOLTIP.
9513 (int_gtk_range_get_value): New function, which avoids a diagnostic
9514 from gcc -Wbad-function-cast.
9515 (xg_set_toolkit_scroll_bar_thumb): Use it.
9516 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9517 diagnostic from gcc -Wbad-function-cast.
9518 (get_utf8_string, xg_get_file_with_chooser):
9519 Rename locals to avoid shadowing.
9520 (create_dialog): Move locals to avoid shadowing.
9522 * xgselect.c (xg_select): Remove unused var.
9524 * image.c (four_corners_best): Mark locals as initialized.
9525 (gif_load): Initialize transparent_p to zero (Bug#8238).
9526 Mark another local as initialized.
9527 (my_png_error, my_error_exit): Mark with NO_RETURN.
9529 * image.c (clear_image_cache): Now static.
9530 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9531 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9532 (x_edge_detection): Remove unnecessary cast that
9533 gcc -Wbad-function-cast diagnoses.
9534 (gif_load): Fix pointer signedness.
9535 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9536 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9538 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9540 Improve quality of tests for time stamp overflow.
9541 For example, without this patch (encode-time 0 0 0 1 1
9542 1152921504606846976) returns the obviously-bogus value (-948597
9543 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9544 reports time overflow. See
9545 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9546 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9547 * editfns.c: Include limits.h and intprops.h.
9548 (TIME_T_MIN, TIME_T_MAX): New macros.
9549 (time_overflow): Move earlier, to before first use.
9550 (hi_time, lo_time): New functions, for an accurate test for
9552 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9553 (Fget_internal_run_time): Don't assume time_t fits in int.
9554 (make_time): Use list2 instead of Fcons twice.
9555 (Fdecode_time): More accurate test for out-of-range times.
9556 (check_tm_member): New function.
9557 (Fencode_time): Use it, to test for out-of-range times.
9558 (lisp_time_argument): Don't rely on undefined left-shift and
9559 right-shift behavior when checking for time stamp overflow.
9561 * editfns.c (time_overflow): New function, refactoring common code.
9562 (Fformat_time_string, Fdecode_time, Fencode_time):
9563 (Fcurrent_time_string): Use it.
9565 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9566 * dired.c (make_time): Move to ...
9567 * editfns.c (make_time): ... here.
9568 * systime.h: Note the move.
9570 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9572 * fringe.c (update_window_fringes): Remove unused variables.
9574 * unexmacosx.c (copy_data_segment): Also copy __got section.
9577 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9579 * termcap.c [MSDOS]: Include "msdos.h".
9580 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9581 Constify `char *' arguments and their references according to
9582 prototypes in tparam.h.
9584 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9586 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9587 Adapt all references accordingly.
9589 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9591 2011-03-11 Tom Tromey <tromey@redhat.com>
9593 * buffer.c (syms_of_buffer): Remove obsolete comment.
9595 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9597 * termhooks.h (encode_terminal_code): Declare prototype.
9599 * msdos.c (encode_terminal_code): Don't declare prototype.
9601 * term.c (encode_terminal_code): Now external again, used by
9602 w32console.c and msdos.c.
9604 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9605 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9607 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9609 Fix some minor problems found by GCC 4.5.2's static checks.
9611 * fringe.c (update_window_fringes): Mark locals as initialized
9613 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9615 * alloc.c (mark_fringe_data): Move decl from here ...
9616 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9617 to check its interface.
9618 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9620 * fontset.c (free_realized_fontset): Now static.
9621 (Fset_fontset_font): Rename local to avoid shadowing.
9622 (fontset_font): Mark local as initialized.
9623 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9625 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9627 * xselect.c (x_disown_buffer_selections): Remove; not used.
9628 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9629 (x_own_selection, Fx_disown_selection_internal): Rename locals
9631 (x_handle_dnd_message): Remove local to avoid shadowing.
9633 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9634 so that the caller can use some name other than gcpro1.
9635 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9636 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9637 (Fx_backspace_delete_keys_p):
9638 Use them to avoid shadowing, and rename vars to avoid shadowing.
9639 (x_decode_color, x_set_name, x_window): Now static.
9640 (Fx_create_frame): Add braces to silence GCC warning.
9641 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9642 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9643 Remove unused locals.
9644 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9645 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9646 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9649 * xterm.h (x_mouse_leave): New decl.
9651 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9652 Remove unused functions.
9653 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9654 (x_calc_absolute_position): Now static.
9655 (XTread_socket): Don't define label "out" unless it's used.
9656 Don't declare local "event" unless it's used.
9657 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9658 unless they are used.
9659 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9660 (x_fatal_error_signal): Remove; not used.
9661 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9662 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9663 (x_error_catcher, x_connection_closed, x_error_handler):
9664 (x_error_quitter, xembed_send_message, x_iconify_frame):
9665 (my_log_handler): Rename locals to avoid shadowing.
9666 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9667 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9669 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9670 Rename or move locals to avoid shadowing.
9671 (tty_defined_color, merge_face_heights): Now static.
9672 (free_realized_faces_for_fontset): Remove; not used.
9673 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9674 does not deduce is never used uninitialized.
9675 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9676 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9678 * terminal.c (store_terminal_param): Now static.
9680 * xmenu.c (menu_highlight_callback): Now static.
9681 (set_frame_menubar): Remove unused local.
9682 (xmenu_show): Rename parameter to avoid shadowing.
9683 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9684 since they might point to immutable storage.
9685 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9686 since it's unused otherwise.
9688 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9689 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9690 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9691 avoids a gcc -Wuninitialized diagnostic.
9692 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9693 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9694 does not deduce are never used uninitialized.
9696 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9698 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9699 * window.c (window_loop, size_window):
9700 (run_window_configuration_change_hook, enlarge_window): Likewise.
9702 * window.c (display_buffer): Now static.
9703 (size_window): Mark variables that gcc -Wuninitialized
9704 does not deduce are never used uninitialized.
9705 * window.h (check_all_windows): New decl, to forestall
9706 gcc -Wmissing-prototypes diagnostic.
9707 * dispextern.h (bidi_dump_cached_states): Likewise.
9709 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9711 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9713 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9714 and to avoid gcc -Wuninitialized warning.
9715 (load_charset_map): Mark variables that gcc -Wuninitialized
9716 does not deduce are never used uninitialized.
9717 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9719 * coding.c (coding_set_source, coding_set_destination):
9720 Use "else { /* comment */ }" rather than "else /* comment */;"
9721 for clarity, and to avoid gcc -Wempty-body warning.
9722 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9723 a block, when the outer 'i' will do.
9724 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9725 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9726 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9727 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9728 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9729 Rename locals to avoid shadowing.
9730 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9731 * coding.c (emacs_mule_char, encode_invocation_designation):
9732 Now static, since they're not used elsewhere.
9733 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9734 (decode_coding_object, encode_coding_object, detect_coding_system):
9735 (decode_coding_emacs_mule): Mark variables that gcc
9736 -Wuninitialized does not deduce are never used uninitialized.
9737 (detect_coding_iso_2022): Initialize a local variable that might
9738 be used uninitialized. Leave a FIXME because it's not clear that
9739 this initialization is needed. (Bug#8211)
9740 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9741 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9742 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9743 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9744 Remove unused macros.
9746 * category.c (hash_get_category_set): Remove unused local var.
9747 (copy_category_table): Now static, since it's not used elsewhere.
9748 * character.c (string_count_byte8): Likewise.
9750 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9751 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9753 * chartab.c (copy_sub_char_table): Now static, since it's not used
9755 (sub_char_table_ref_and_range, char_table_ref_and_range):
9756 Rename locals to avoid shadowing.
9757 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9759 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9760 (BIDI_BOB): Remove unused macro.
9762 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9763 deduce are never used uninitialized.
9764 * term.c (encode_terminal_code): Likewise.
9766 * term.c (encode_terminal_code): Now static. Remove unused local.
9768 * tparam.h: New file.
9769 * term.c, tparam.h: Include it.
9770 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9771 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9772 Move these decls to tparam.h, and make them agree with what
9773 is actually in tparam.c. The previous trick of using incompatible
9774 decls in different modules does not conform to the C standard.
9775 All callers of tparam changed to use tparam's actual API.
9776 * tparam.c (tparam1, tparam, tgoto):
9777 Use const pointers where appropriate.
9779 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9780 * cm.h (struct cm): Likewise.
9781 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9782 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9783 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9784 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9785 (turn_on_face, init_tty): Likewise.
9786 * termchar.h (struct tty_display_info): Likewise.
9788 * term.c (term_mouse_position): Rename local to avoid shadowing.
9790 * alloc.c (mark_ttys): Move decl from here ...
9791 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9793 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9795 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9797 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9799 * search.c (compile_pattern_1): Remove argument regp, unused since
9800 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9801 (compile_pattern): Don't pass it.
9803 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9805 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9806 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9808 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9810 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9812 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9813 gdk_window_get_screen, gdk_window_get_geometry,
9814 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9815 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9816 (xg_get_pixbuf_from_pixmap): New function.
9817 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9818 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9819 Call xg_get_pixbuf_from_pixmap instead of
9820 gdk_pixbuf_get_from_drawable.
9821 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9822 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9823 (xg_check_special_colors): Use GtkStyleContext and its functions
9825 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9826 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9827 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9828 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9829 Call gtk_widget_get_preferred_size.
9830 (xg_frame_resized): gdk_window_get_geometry only takes 5
9832 (xg_win_to_widget, xg_event_is_for_menubar):
9833 Call gdk_x11_window_lookup_for_display.
9834 (xg_set_widget_bg): New function.
9835 (delete_cb): New function.
9836 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9837 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9838 (xg_set_background_color): Call xg_set_widget_bg.
9839 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9840 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9841 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9842 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9844 (update_frame_tool_bar): Call gtk_widget_hide.
9845 (xg_initialize): Use GDK_KEY_g.
9847 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9849 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9851 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9852 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9853 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9855 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9857 * w32xfns.c (select_palette): Check success of RealizePalette against
9858 GDI_ERROR, not zero.
9860 See ChangeLog.11 for earlier changes.
9866 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9868 This file is part of GNU Emacs.
9870 GNU Emacs is free software: you can redistribute it and/or modify
9871 it under the terms of the GNU General Public License as published by
9872 the Free Software Foundation, either version 3 of the License, or
9873 (at your option) any later version.
9875 GNU Emacs is distributed in the hope that it will be useful,
9876 but WITHOUT ANY WARRANTY; without even the implied warranty of
9877 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9878 GNU General Public License for more details.
9880 You should have received a copy of the GNU General Public License
9881 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.