1 2012-04-17 Eli Zaretskii <eliz@gnu.org>
3 * xdisp.c (string_buffer_position_lim): Limit starting position to
5 (set_cursor_from_row): If called for a mode-line or header-line
6 row, return zero immediately.
7 (try_cursor_movement): If inside continuation line, don't back up
8 farther than the first row after the header line, if any. Don't
9 consider the header-line row as "partially visible", even if
10 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
12 2012-04-13 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
14 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n" (bug#11238).
16 2012-04-10 Teodor Zlatanov <tzz@lifelogs.com>
18 * process.c (make_process):
19 * process.h: Add integer `gnutls_handshakes_tried' member to
22 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
23 Add convenience `GNUTLS_LOG2i' macro.
25 * gnutls.c (gnutls_log_function2i): Convenience log function.
26 (emacs_gnutls_read): Use new log functions,
27 `gnutls_handshakes_tried' process member, and
28 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
29 attempts per process (connection).
31 2012-04-09 Eli Zaretskii <eliz@gnu.org>
33 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
34 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
36 2012-04-09 Jan Djärv <jan.h.d@swipnet.se>
38 * nsterm.m (constrainFrameRect): Always constrain when there is only
39 one screen (Bug#10962).
41 2012-04-06 Eli Zaretskii <eliz@gnu.org>
43 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
44 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
45 about subtle differences between FETCH_CHAR* and STRING_CHAR*
46 macros related to unification of CJK characters. For the details,
47 see the discussion following the message here:
48 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
50 2012-04-04 Chong Yidong <cyd@gnu.org>
52 * keyboard.c (Vdelayed_warnings_list): Doc fix.
54 2012-04-01 Eli Zaretskii <eliz@gnu.org>
56 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
57 instead of alloca. (Bug#11138)
59 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
61 * w32menu.c (is_simple_dialog): Properly check lisp types.
64 2012-03-31 Eli Zaretskii <eliz@gnu.org>
66 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
67 position we get to after a call to move_it_to fails the
68 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
69 only if we wind up in a string from display property. (Bug#11063)
71 * window.c (Fdelete_other_windows_internal): Invalidate the row
72 and column information about mouse highlight, so that redisplay
73 restores it after reallocating the glyph matrices. (Bug#7464)
75 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
76 string comes from a `display' text property, use the buffer
77 position of that property as if we actually saw that position in
79 (move_it_by_lines): Remove the assertion that
80 "it->current_x == 0 && it->hpos == 0" which can be legitimately
81 violated when there's a before-string at the beginning of a line.
84 2012-03-30 Eli Zaretskii <eliz@gnu.org>
86 * xdisp.c (append_space_for_newline): If the default face was
87 remapped, use the remapped face for the appended newline.
88 (extend_face_to_end_of_line): Use the remapped default face for
89 extending the face to the end of the line.
90 (display_line): Call extend_face_to_end_of_line when the default
91 face was remapped. (Bug#11068)
93 2012-03-29 Eli Zaretskii <eliz@gnu.org>
95 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
97 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
99 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
101 2012-03-27 Glenn Morris <rgm@gnu.org>
103 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
106 2012-03-26 Kenichi Handa <handa@m17n.org>
108 * dispextern.h (struct glyph): Fix previous change. Change the
109 bit length of glyphless.ch to 25 (Bug#11082).
111 2012-03-26 Chong Yidong <cyd@gnu.org>
113 * keyboard.c (Vselection_inhibit_update_commands): New variable.
114 (command_loop_1): Use it; inhibit selection update for
115 handle-select-window too (Bug#8996).
117 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
119 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
121 2012-03-25 Kenichi Handa <handa@m17n.org>
123 * dispextern.h (struct glyph): Change the bit length of
124 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
126 2012-03-24 Eli Zaretskii <eliz@gnu.org>
128 * s/ms-w32.h (tzname): Include time.h before redirecting to
129 _tzname. Fixes the MSVC build. (Bug#9960)
131 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
133 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
136 * xterm.c (XTread_socket): Only modify handling_signal if
137 !SYNC_INPUT. (Bug#11080)
139 2012-03-23 Eli Zaretskii <eliz@gnu.org>
141 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
142 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
143 when fetching a multibyte character consumes more bytes than
144 CHAR_BYTES returns, due to unification of CJK characters in
145 string_char. (Bug#11073)
147 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
149 * process.c (wait_reading_process_output): Handle pty disconnect
150 by refraining from sending oneself a SIGCHLD (bug#10933).
152 2012-03-22 Chong Yidong <cyd@gnu.org>
154 * dispextern.h (struct it): New member string_from_prefix_prop_p.
156 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
157 Mark string as coming from a prefix property.
158 (handle_face_prop): Use default face for prefix strings (Bug#4281).
159 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
161 2012-03-21 Chong Yidong <cyd@gnu.org>
163 * xfaces.c (Vface_remapping_alist): Doc fix.
165 2012-03-20 Eli Zaretskii <eliz@gnu.org>
167 * w32proc.c (Fw32_set_console_codepage)
168 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
171 2012-03-20 Chong Yidong <cyd@gnu.org>
173 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
174 to reflect default non-nil value of redisplay-dont-pause.
176 2012-03-19 Kenichi Handa <handa@m17n.org>
178 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
179 it fit in a valid range (Bug#11003).
181 2012-03-18 Eli Zaretskii <eliz@gnu.org>
183 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
184 that is not from display property, accept the row as a "cursor
185 row" if one of the string's character has a non-nil `cursor'
186 property. Fixes cursor positioning when there are newlines in
187 overlay strings, e.g. in icomplete.el. (Bug#11035)
189 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
191 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
193 2012-03-12 Chong Yidong <cyd@gnu.org>
195 * eval.c (inhibit_lisp_code): Rename from
196 inhibit_window_configuration_change_hook; move from window.c.
198 * xfns.c (unwind_create_frame_1, Fx_create_frame):
199 * window.c (run_window_configuration_change_hook)
200 (syms_of_window): Callers changed.
202 2012-03-11 Chong Yidong <cyd@gnu.org>
204 * keymap.c (Fkey_description): Doc fix (Bug#9700).
206 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
208 2012-03-10 Chong Yidong <cyd@gnu.org>
210 * frame.c (other_visible_frames): Don't assume the selected frame
211 is visible (Bug#10955).
213 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
215 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
217 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
219 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
220 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
223 2012-03-03 Glenn Morris <rgm@gnu.org>
225 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
227 2012-03-02 Eli Zaretskii <eliz@gnu.org>
229 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
230 position past the first glyph_row that ends at ZV. (Bug#10902)
231 (redisplay_window, next_element_from_string): Fix typos in
233 (redisplay_window): Pass to move_it_vertically the margin in
234 pixels, not in screen lines.
236 2012-03-02 Glenn Morris <rgm@gnu.org>
238 * buffer.c (buffer-list-update-hook): Doc fix.
240 2012-02-29 Eli Zaretskii <eliz@gnu.org>
242 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
243 push_it before setting up the iterator for the first overlay
244 string, even if we have an empty string loaded.
245 (next_overlay_string): If there's an empty string on the iterator
246 stack, pop the stack. (Bug#10903)
248 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
250 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
251 Suggested by Stefan Monnier in
252 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
253 * alloc.c (widen_to_Lisp_Object): New static function.
254 (mark_memory): Also mark Lisp_Objects by fetching pointer words
255 and widening them to Lisp_Objects. This would work even if
256 USE_LSB_TAG is defined and wide integers are used, which might
257 happen in a future version of Emacs.
259 2012-02-25 Chong Yidong <cyd@gnu.org>
261 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
264 * xselect.c (Fx_selection_exists_p): Doc fix.
265 (x_clipboard_manager_save_all): Print an informative message
266 before saving to clipboard manager.
268 2012-02-24 Chong Yidong <cyd@gnu.org>
270 * keyboard.c (process_special_events): Handle all X selection
271 requests in kbd_buffer, not just the next one (Bug#8869).
273 2012-02-23 Chong Yidong <cyd@gnu.org>
275 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
276 call when setting menu-bar-lines and tool-bar-lines parameters.
277 (unwind_create_frame_1): New helper function.
279 * window.c (inhibit_window_configuration_change_hook): New var.
280 (run_window_configuration_change_hook): Obey it.
281 (syms_of_window): Initialize it.
283 2012-02-22 Chong Yidong <cyd@gnu.org>
285 * xterm.c (x_draw_image_relief): Add missing type check for
286 Vtool_bar_button_margin (Bug#10743).
288 2012-02-21 Chong Yidong <cyd@gnu.org>
290 * fileio.c (Vfile_name_handler_alist): Doc fix.
292 * buffer.c (Fget_file_buffer): Protect against invalid file
293 handler return value.
295 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
297 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
298 when computing $valmask.
300 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
301 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
302 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
303 It's useless in that case, and it can cause problems on hosts
304 that allocate halves of EMACS_INT values separately.
305 Reported by Dan Horák. Diagnosed by Andreas Schwab in
306 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
307 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
308 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
309 it avoids undefined behavior on hosts where shifting right by more
310 than the word width has undefined behavior.
312 2012-02-19 Chong Yidong <cyd@gnu.org>
314 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
315 (Funhandled_file_name_directory, Ffile_name_as_directory)
316 (Fdirectory_file_name, Fexpand_file_name)
317 (Fsubstitute_in_file_name): Protect against invalid file handler
318 return values (Bug#10845).
320 2012-02-18 Eli Zaretskii <eliz@gnu.org>
322 * .gdbinit (pitx): Fix incorrect references to fields of the
325 2012-02-17 Chong Yidong <cyd@gnu.org>
327 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
329 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
331 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
332 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
334 2012-02-15 Chong Yidong <cyd@gnu.org>
336 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
337 marked as special. Also, starting docstrings with * is obsolete.
339 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
341 * gnutls.c (emacs_gnutls_write): Fix last change.
343 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
345 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
348 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
350 * keymap.c (Fsingle_key_description): Handle char ranges.
352 2012-02-12 Chong Yidong <cyd@gnu.org>
354 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
355 as that creates a dangerous corner case.
357 * window.c (Fdelete_window_internal): Invalidate the mouse
358 highlight (Bug#9904).
360 2012-02-12 Glenn Morris <rgm@gnu.org>
362 * xselect.c (Fx_own_selection_internal)
363 (Fx_get_selection_internal, Fx_disown_selection_internal)
364 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
365 * nsselect.m (Fx_own_selection_internal)
366 (Fx_disown_selection_internal, Fx_selection_exists_p)
367 (Fx_selection_owner_p, Fx_get_selection_internal):
368 Sync docs and argument specs with the xselect.c versions.
370 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
372 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
374 2012-02-11 Eli Zaretskii <eliz@gnu.org>
376 * w32select.c (Fx_selection_exists_p): Sync doc string and
377 argument list with xselect.c. (Bug#10783)
379 * w16select.c (Fx_selection_exists_p): Sync doc string and
380 argument list with xselect.c. (Bug#10783)
382 2012-02-10 Glenn Morris <rgm@gnu.org>
384 * fns.c (Fsecure_hash): Doc fix.
386 2012-02-09 Kenichi Handa <handa@m17n.org>
388 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
390 2012-02-07 Chong Yidong <cyd@gnu.org>
392 * buffer.c (Fbuffer_local_variables)
393 (buffer_lisp_local_variables): Handle unbound vars correctly;
394 don't let Qunbound leak into Lisp.
396 2012-02-07 Glenn Morris <rgm@gnu.org>
398 * image.c (Fimagemagick_types): Doc fix.
400 * image.c (imagemagick-render-type): Change it from a lisp object
401 to an integer. Move the doc here from the lisp manual.
402 Treat all values not equal to 0 the same.
404 2012-02-06 Chong Yidong <cyd@gnu.org>
406 * doc.c (store_function_docstring): Avoid applying docstring of
407 alias to base function (Bug#2603).
409 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
411 * .gdbinit (pp1, pv1): Remove redundant defines.
414 2012-02-04 Chong Yidong <cyd@gnu.org>
416 * nsterm.m: Declare a global (Bug#10694).
418 2012-02-04 Eli Zaretskii <eliz@gnu.org>
420 * w32.c (get_emacs_configuration_options):
421 Include --enable-checking, if specified, in the return value.
423 2012-02-04 Martin Rudalics <rudalics@gmx.at>
425 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
426 after rounding frame sizes. (Bug#9723)
428 2012-02-04 Eli Zaretskii <eliz@gnu.org>
430 * keyboard.c (adjust_point_for_property): Don't position point
431 before BEGV. (Bug#10696)
433 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
435 Handle overflow when computing char display width (Bug#9496).
436 * character.c (char_width): Return EMACS_INT, not int.
437 (char_width, c_string_width): Check for overflow when
438 computing the width; this is possible now that individual
439 characters can have unbounded width. Problem introduced
440 by merge from Emacs 23 on 2012-01-19.
442 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
444 * dbusbind.c (Fdbus_register_method): Mention the return value
445 :ignore in the docstring.
447 2012-02-02 Glenn Morris <rgm@gnu.org>
449 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
451 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
452 Unconditionally set to t. (Bug#10673)
453 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
454 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
455 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
457 2012-02-02 Kenichi Handa <handa@m17n.org>
459 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
460 0, do not call append_composite_glyph.
462 2012-02-02 Kenichi Handa <handa@m17n.org>
464 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
466 (x_produce_glyphs): If the component of a composition is a null
467 string, set it->pixel_width to 1 to avoid zero-width glyph.
469 2012-02-01 Eli Zaretskii <eliz@gnu.org>
471 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
472 first 2 arguments are identical. This makes inserting large
473 output from a subprocess an order of magnitude faster on
474 MS-Windows, where all sbrk'ed memory is always contiguous.
476 2012-01-31 Glenn Morris <rgm@gnu.org>
478 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
479 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
480 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
482 2012-01-29 Glenn Morris <rgm@gnu.org>
484 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
486 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
488 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
490 2012-01-28 Chong Yidong <cyd@gnu.org>
492 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
494 2012-01-26 Chong Yidong <cyd@gnu.org>
496 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
498 * search.c (Fsearch_forward, Fsearch_backward): Document negative
499 repeat counts (Bug#10507).
501 2012-01-26 Glenn Morris <rgm@gnu.org>
503 * lread.c (syms_of_lread): Doc fix.
505 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
507 * coding.c (encode_designation_at_bol): Change return value to
510 2012-01-25 Chong Yidong <cyd@gnu.org>
512 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
514 2012-01-21 Chong Yidong <cyd@gnu.org>
516 * floatfns.c (Fcopysign): Make the second argument non-optional,
517 since nil is not allowed anyway.
519 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
521 * process.c (read_process_output): Use p instead of XPROCESS (proc).
522 (send_process): Likewise.
524 2012-01-19 Martin Rudalics <rudalics@gmx.at>
526 * window.c (save_window_save, Fcurrent_window_configuration)
527 (Vwindow_persistent_parameters): Do not use Qstate.
530 2012-01-19 Kenichi Handa <handa@m17n.org>
532 * character.c (char_width): New function.
533 (Fchar_width, c_string_width, lisp_string_width):
534 Use char_width (Bug#9496).
536 2012-01-16 Martin Rudalics <rudalics@gmx.at>
538 * window.c (Vwindow_persistent_parameters): New variable.
539 (Fset_window_configuration, save_window_save): Handle persistent
542 2012-01-14 Eli Zaretskii <eliz@gnu.org>
544 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
545 thrashing the stack of the thread. (Bug#9087)
547 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
549 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
551 2012-01-11 Eli Zaretskii <eliz@gnu.org>
553 * xdisp.c (rows_from_pos_range): Handle the case where the
554 highlight ends on a newline. (Bug#10464)
555 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
556 he end column for display of highlight that ends on a newline
559 2012-01-11 Glenn Morris <rgm@gnu.org>
561 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
562 from load-path also when installation-directory is nil. (Bug#10208)
564 2012-01-10 Glenn Morris <rgm@gnu.org>
566 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
568 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
569 Update template values to be closer to their typical values these days.
571 2012-01-09 Eli Zaretskii <eliz@gnu.org>
573 * xdisp.c (rows_from_pos_range): Accept additional argument
574 DISP_STRING, and accept any glyph in a row whose object is that
575 string as eligible for mouse highlight. Fixes mouse highlight of
576 display strings from overlays. (Bug#10464)
578 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
580 emacs: fix an auto-save permissions race condition (Bug#10400)
581 * fileio.c (auto_saving_dir_umask): New static var.
582 (Fmake_directory_internal): Use it.
583 (do_auto_save_make_dir): Set it, instead of invoking chmod after
584 creating the directory. The old code temporarily assigns
585 too-generous permissions to the directory.
586 (do_auto_save_eh): Clear it.
587 (Fdo_auto_save): Catch all errors, not just file errors, so
588 that the var is always cleared.
590 2012-01-07 Eli Zaretskii <eliz@gnu.org>
592 * search.c (scan_buffer): Pass character positions to
593 know_region_cache, not byte positions. (Bug#6540)
595 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
597 * w32.c (sys_rename): Report EXDEV when rename of a directory
598 fails because the target is on another logical disk. (Bug#10284)
600 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
602 * xterm.c (x_embed_request_focus): New function.
604 * xterm.h: Add prototype.
606 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
608 2012-01-05 Glenn Morris <rgm@gnu.org>
610 * emacs.c (emacs_copyright): Update short copyright year to 2012.
612 2012-01-01 Eli Zaretskii <eliz@gnu.org>
614 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
615 Load gnutls_transport_set_lowat only if GnuTLS version is below
617 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
618 GnuTLS versions below 2.11.1.
620 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
622 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
623 to the doc string advising against its use for altering the way
624 windows are scrolled.
626 2011-12-28 Kenichi Handa <handa@m17n.org>
628 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
629 coding-system ASCII compatible only when it does not produce BOM
630 on encoding (Bug#10383).
632 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
634 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
636 (create_and_show_popup_menu): Always use menu_position_func for
639 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
641 * callint.c (Fcall_interactively): Don't truncate prompt string.
643 2011-12-23 Eli Zaretskii <eliz@gnu.org>
645 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
646 property that ends at ZV, so that the bidi iteration could be
647 resumed from there (after widening). (Bug#10360)
649 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
651 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
653 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
655 * nsterm.m (x_free_frame_resources):
656 Release f->output_data.ns->miniimage.
657 (ns_index_color): Fix indentation. Do not retain
658 color_table->colors[i].
660 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
663 * nsfns.m (x_set_background_color): Assign return value from
664 ns_index_color to face-background instead of NSColor*.
665 (ns_implicitly_set_icon_type): Fix indentation.
666 Change assignment in for loop to comparison.
668 * emacs.c (ns_pool): New variable.
669 (main): Assign ns_pool.
670 (Fkill_emacs): Call ns_release_autorelease_pool.
672 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
673 autorelease fdesc, release fdAttrs and tdict.
674 (ns_get_covering_families): Release charset.
675 (ns_findfonts): Release NSFontDescriptor created with new.
676 (ns_uni_to_glyphs): Fix indentation.
677 (setString): Release attrStr before assigning new value.
679 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
681 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
683 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
684 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
686 2011-12-18 David Reitter <reitter@cmu.edu>
688 * nsterm.m (ns_term_init): Subscribe for notifications
689 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
690 to method trackingNotification in EmacsMenu.
692 * nsmenu.m (trackingMenu): New variable.
693 (trackingNotification): New method (from Aquamacs).
694 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
695 from Aquamacs (Bug#7030).
697 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
699 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
700 (symbol_to_nsstring): Fix indentation.
701 (ns_symbol_to_pb): New function.
702 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
703 (Fns_rotate_cut_buffers_internal): Remove.
704 (Fns_store_selection_internal): Rename from
705 Fns_store_cut_buffer_internal.
706 (ns_get_foreign_selection, Fx_own_selection_internal)
707 (Fx_disown_selection_internal, Fx_selection_exists_p)
708 (Fns_get_selection_internal, Fns_store_selection_internal):
709 Use ns_symbol_to_pb and check if return value is nil.
710 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
711 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
712 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
713 renamed to Sns_store_selection_internal.
714 (ns_handle_selection_request): Move code to Fx_own_selection_internal
715 and remove this function.
716 (ns_handle_selection_clear): Remove, never used.
717 (Fx_own_selection_internal): Move code from ns_handle_selection_request
720 2011-12-17 Ken Brown <kbrown@cornell.edu>
722 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
723 GID is unknown (Bug#10257).
725 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
727 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
728 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
729 which caused a build failure on GNU/Linux IA-64. This problem was
730 introduced by my 2011-10-07 patch.
732 2011-12-15 Juri Linkov <juri@jurta.org>
734 * image.c (imagemagick_error): New function. (Bug#10112)
735 (imagemagick_load_image): Comment out `MagickSetResolution' call.
736 Use `imagemagick_error' where ImageMagick functions return
738 (Fimagemagick_types): Add `Fnreverse' to return the list in the
741 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
743 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
744 fill background (Bug#8992).
746 2011-12-13 Martin Rudalics <rudalics@gmx.at>
748 * window.c (Vwindow_combination_resize)
749 (Vwindow_combination_limit): Use t instead of non-nil in
751 (Vrecenter_redisplay): Add first sentence of doc-string on
753 (Frecenter): Fix doc-string typo.
755 2011-12-11 Kenichi Handa <handa@m17n.org>
757 * coding.c (Funencodable_char_position): Pay attention to the
758 buffer text relocation (Bug#9389).
760 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
762 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
763 gtk_init (Bug#10100).
765 2011-12-10 Eli Zaretskii <eliz@gnu.org>
767 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
768 IT->string is nil. (Bug#10263)
770 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
772 * nsterm.h (x_free_frame_resources): Declare.
774 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
775 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
777 * nsterm.h (ns_get_defaults_value): Declare.
779 * nsterm.m (ns_default): Call ns_get_defaults_value.
781 2011-12-09 Eli Zaretskii <eliz@gnu.org>
783 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
786 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
788 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
789 that where the value of an _OBJC_* symbol points to is in the .bss
792 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
794 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
795 after the loop to call ccl_driver at least once (Bug#8619).
797 2011-12-08 Kenichi Handa <handa@m17n.org>
799 * ftfont.c (get_adstyle_property): Fix previous change
802 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
804 * w32.c (init_environment): If no_site_lisp, remove site-lisp
805 dirs from the default value of EMACSLOADPATH (bug#10208).
807 2011-12-07 Glenn Morris <rgm@gnu.org>
809 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
810 installation and source directories as well. (Bug#10208)
812 2011-12-06 Chong Yidong <cyd@gnu.org>
814 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
816 2011-12-06 Glenn Morris <rgm@gnu.org>
818 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
819 as an error, not just -1. (Bug#10217)
821 2011-12-05 Chong Yidong <cyd@gnu.org>
823 * keyboard.c (process_special_events): New function.
824 (swallow_events, Finput_pending_p): Use it (Bug#10195).
826 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
828 * coding.c (encode_designation_at_bol): Don't use uninitialized
829 local variable (Bug#9318).
831 2011-12-05 Kenichi Handa <handa@m17n.org>
833 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
834 return Qnil (Bug#8046, Bug#10193).
836 2011-12-05 Kenichi Handa <handa@m17n.org>
838 * coding.c (encode_designation_at_bol): New args charbuf_end and
839 dst. Return the number of produced bytes. Callers changed.
840 (coding_set_source): Return how many bytes coding->source was
842 (coding_set_destination): Return how many bytes
843 coding->destination was relocated.
844 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
845 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
847 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
849 * coding.c (CODING_CHAR_CHARSET_P): New macro.
850 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
853 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
855 The following changes are to fix Bug#9318.
857 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
858 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
859 (encode_coding_iso_2022, encode_coding_sjis)
860 (encode_coding_big5, encode_coding_charset): Use the above macros.
862 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
864 * lisp.h (process_quit_flag): Fix external declaration.
866 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
868 Don't macro-inline non-performance-critical code.
869 * eval.c (process_quit_flag): New function.
870 * lisp.h (QUIT): Use it.
872 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
874 * nsfns.m (get_geometry_from_preferences): New function.
875 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
877 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
879 * emacs.c (Qkill_emacs): Define.
880 (syms_of_emacs): Initialize it.
881 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
882 Qquit_flag to `kill-emacs' instead.
883 (quit_throw_to_read_char): Add parameter `from_signal'.
884 All callers changed. Call Fkill_emacs if requested and safe.
885 * lisp.h (QUIT): Call Fkill_emacs if requested.
887 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
889 * widget.c (update_wm_hints): Return if wmshell is null.
890 (widget_update_wm_size_hints): New function.
892 * widget.h (widget_update_wm_size_hints): Declare.
894 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
895 widget_update_wm_size_hints (Bug#10104).
897 2011-12-03 Eli Zaretskii <eliz@gnu.org>
899 * xdisp.c (handle_invisible_prop): If the invisible text ends just
900 before a newline, prepare the bidi iterator for consuming the
901 newline, and keep the current paragraph direction. (Bug#10183)
902 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
904 2011-12-02 Juri Linkov <juri@jurta.org>
906 * search.c (Fword_search_regexp): New Lisp function created from
907 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
908 (Fword_search_backward, Fword_search_forward)
909 (Fword_search_backward_lax, Fword_search_forward_lax):
910 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
911 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
913 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
915 * fileio.c (Finsert_file_contents): Move after-change-function call
916 to before the "handled:" label, since all "goto handled" appear in
917 cases where the *-change-functions have already been properly called
920 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
922 * keyboard.c (interrupt_signal): Don't call kill-emacs when
923 waiting for input. (Bug#10169)
925 2011-11-30 Eli Zaretskii <eliz@gnu.org>
927 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
928 verifies glyph row's hash code--we have just reallocated the
929 glyphs, so their contents can be complete garbage. (Bug#10164)
931 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
933 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
935 2011-11-30 Eli Zaretskii <eliz@gnu.org>
937 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
938 attributes are tested _before_ calling verify_row_hash, to protect
939 against GCC re-ordering of the tests. (Bug#10164)
941 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
943 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
945 * xterm.c (handle_one_xevent): Only set async_visible and friends
946 if net_wm_state_hidden_seen is non-zero (Bug#10002)
947 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
948 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
950 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
952 Remove GCPRO-related macros that exist only to avoid shadowing locals.
953 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
954 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
955 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
956 All uses changed to use GCPRO1 etc.
957 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
958 Revert to old implementation (i.e., before 2011-03-11).
960 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
962 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
963 of scroll runs so as to avoid assigning disabled bogus rows and
964 unnecessary graphics copy operations.
966 2011-11-27 Eli Zaretskii <eliz@gnu.org>
968 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
969 (snprintf) [_MSC_VER]: Redirect to _snprintf.
970 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
971 (malloc, free, realloc, calloc): Redirect to e_* only when
974 * lisp.h (GCTYPEBITS): Move before first use.
975 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
976 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
977 this macro definition.
979 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
982 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
984 * gtkutil.c (xg_create_frame_widgets):
985 Call gtk_window_set_has_resize_grip (FALSE) if that function is
986 present with Gtk+ 2.0.
988 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
990 * fileio.c (Finsert_file_contents): Undo previous change; see
991 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
993 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
995 Rename locals to avoid shadowing.
996 * fileio.c (Finsert_file_contents):
997 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
998 * process.c (wait_reading_process_output):
999 Rename inner 'proc' to 'p' to avoid shadowing.
1000 Indent for consistency with usual Emacs style.
1002 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1004 * xdisp.c (redisplay_window): If cursor row is not fully visible
1005 after recentering, and scroll-conservatively is set to a large
1006 number, scroll window by a few more lines to make the cursor fully
1007 visible and out of scroll-margin. (Bug#10105)
1008 (start_display): Don't move to the next line if the display should
1009 start at a newline that is part of a display vector or an overlay
1012 2011-11-24 Juri Linkov <juri@jurta.org>
1014 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1015 after the `MagickPingImage' call. (Bug#10112)
1017 2011-11-23 Chong Yidong <cyd@gnu.org>
1019 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1021 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1023 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1024 making another buffer current. (Bug#10114)
1026 2011-11-23 Glenn Morris <rgm@gnu.org>
1028 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1030 2011-11-23 Chong Yidong <cyd@gnu.org>
1032 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1033 using it (Bug#5984).
1035 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1037 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1038 and header-lines, as they don't have one computed for them.
1041 * .gdbinit (prow): Make displayed values more self-explaining.
1042 Add row's hash code.
1044 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1046 * process.c (wait_reading_process_output): Fix asynchrounous
1047 GnuTLS socket handling on some versions of the GnuTLS library.
1048 (wait_reading_process_output): Add comment and URL.
1050 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1052 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1054 2011-11-21 Chong Yidong <cyd@gnu.org>
1056 * window.c (Fnext_window, Fprevious_window): Doc fix.
1058 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1060 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1062 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1064 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1066 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1068 * window.c (Fset_window_combination_limit): Rename argument
1070 (Vwindow_combination_limit): Remove "status" from doc-string.
1072 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1074 * m/ibms390.h: Remove.
1075 * m/ibms390x.h: Don't include "ibms390.h".
1077 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1079 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1080 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1082 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1084 * casetab.c (Fset_case_table):
1085 * charset.c (Fcharset_after): Fix typos.
1087 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1089 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1090 Otherwise, valgrind does not work on some platforms.
1091 Problem reported by Andreas Schwab in
1092 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1093 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1094 is set, removing the need for VIRT_ADDRESS_VARIES.
1095 (PURE_P): Use a more-efficient implementation that needs just one
1096 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1097 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1098 to 4 (xorl, subq, cmpq, setbe).
1099 * alloc.c (pure): Always extern now, since that's the
1100 VIRT_ADDR_VARIES behavior.
1101 (PURE_POINTER_P): Use a single comparison, not two, for
1102 consistency with the new puresize.h.
1103 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1104 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1105 Remove VIRT_ADDR_VARIES no longer needed.
1107 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1109 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1110 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1111 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1112 behave as if the cursor position were at the window margin.
1114 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1115 and the cursor position is out of bounds, behave as if the cursor
1116 position were at the window margin. (Bug#10075)
1118 2011-11-18 Chong Yidong <cyd@gnu.org>
1120 * window.c (Fwindow_combination_limit): Make first argument
1121 non-optional, since it is meaningless for live windows like the
1124 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1126 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1128 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1130 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1131 (graft_intervals_into_buffer): Simplify.
1133 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1135 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1136 hash values of the two rows.
1137 (copy_row_except_pointers): Preserve the used[] arrays and the
1138 hash values of the two rows. (Bug#10035)
1139 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1141 * xdisp.c (row_hash): New function, body extracted from
1142 compute_line_metrics.
1143 (compute_line_metrics): Call row_hash, instead of computing the
1146 * dispnew.c (verify_row_hash): Call row_hash for computing the
1147 hash code of a row, instead of duplicating code from xdisp.c.
1149 * dispextern.h (row_hash): Add prototype.
1151 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1153 * frame.c (delete_frame): Don't delete the terminal when the last
1154 X frame is closed if emacs is built with GTK toolkit.
1156 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1158 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1160 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1162 * window.c (Vwindow_splits): Rename to
1163 Vwindow_combination_resize. Suggested by Juri Linkov.
1164 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1167 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1169 * nsfns.m (Fns_font_name):
1170 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1172 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1174 * window.h (window): Rename slot "nest" to "combination_limit".
1175 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1176 (Fset_window_nest): Rename to Fset_window_combination_limit.
1177 (Vwindow_nest): Rename to Vwindow_combination_limit.
1178 (recombine_windows, make_parent_window, make_window)
1179 (Fsplit_window_internal, saved_window)
1180 (Fset_window_configuration, save_window_save): Rename all
1181 occurrences of window_nest to window_combination_limit.
1183 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1185 * image.c (imagemagick_load_image): Fix typo.
1187 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1189 * xdisp.c (display_line): Move the call to
1190 highlight_trailing_whitespace before the call to
1191 compute_line_metrics, since the latter needs to see the final
1192 faces of all the glyphs to compute ROW's hash value.
1193 Fixes assertion violations in row_equal_p. (Bug#10035)
1195 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1197 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1198 just return (bug#10044).
1200 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1202 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1203 with user-defined heap size. Bump the default size of the temacs
1204 heap to 27MB, to avoid memory warning when running temacs.
1205 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1207 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1208 current_matrix and desired_matrix. (Bug#9990)
1209 (verify_row_hash) [XASSERTS]: New function.
1210 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1211 that the hash value of glyph rows is correct.
1213 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1215 * window.h (window): Remove splits slot.
1216 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1217 (Fdelete_other_windows_internal, make_parent_window)
1218 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1219 (Fset_window_configuration, save_window_save): Don't deal with
1220 split status of windows.
1221 (saved_window): Remove splits slot.
1222 (Vwindow_splits): Rewrite doc-string.
1224 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1226 * xfns.c (unwind_create_frame):
1227 * nsfns.m (unwind_create_frame):
1228 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1229 Vframe_list (Bug#9999).
1231 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1233 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1235 2011-11-11 Kenichi Handa <handa@m17n.org>
1237 * callproc.c (Fcall_process): Set the member dst_multibyte of
1240 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1242 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1243 avoid a crash (bug#9496).
1245 2011-11-09 Chong Yidong <cyd@gnu.org>
1247 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1248 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1250 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1252 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1254 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1256 Avoid some portability problems by eschewing 'extern inline' functions.
1257 The trivial performance wins aren't worth the portability hassles; see
1258 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1260 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1261 (window_box_width, window_box_left, window_box_left_offset)
1262 (window_box_right, window_box_right_offset): Undo previous change,
1263 by removing the "extern"s.
1264 * intervals.c (adjust_intervals_for_insertion)
1265 (adjust_intervals_for_deletion): Undo previous change,
1266 making these static again.
1267 (offset_intervals, temp_set_point_both, temp_set_point)
1268 (copy_intervals_to_string): No longer inline.
1269 * xdisp.c (window_text_bottom_y, window_box_width)
1270 (window_box_height, window_box_left_offset)
1271 (window_box_right_offset, window_box_left, window_box_right)
1272 (window_box): No longer inline.
1274 2011-11-08 Chong Yidong <cyd@gnu.org>
1276 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1277 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1278 Signal an error if not a live window.
1279 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1280 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1282 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1284 * lisp.h (syms_of_abbrev): Remove declaration.
1285 Reported by CHENG Gao <chenggao@royau.me>.
1287 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1289 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1290 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1291 of temacs in GUI mode.
1293 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1295 * window.h: Declare delete_all_child_windows instead of
1296 delete_all_subwindows.
1297 * window.c (Fwindow_nest, Fset_window_nest)
1298 (Fset_window_new_total, Fset_window_new_normal)
1299 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1300 (delete_all_subwindows): Rename to delete_all_child_windows.
1301 (Fdelete_other_windows_internal, Fset_window_configuration):
1302 Call delete_all_child_windows instead of delete_all_subwindows.
1303 * frame.c (delete_frame): Call delete_all_child_windows instead
1304 of delete_all_subwindows.
1306 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1308 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1309 This is also needed for porting to any host where GC_MARK_STACK is
1310 not GC_MAKE_GCPROS_NOOPS.
1311 (which_symbols): Use it.
1313 2011-11-07 Kenichi Handa <handa@m17n.org>
1315 * coding.c (coding_set_destination): Check coding->src_pos only
1316 when coding->src_object is a buffer (bug#9910).
1318 * process.c (send_process): Set the member src_multibyte of coding
1319 to 0 (bug#9911) when sending a unibyte text.
1321 * callproc.c (Fcall_process): Set the member src_multibyte of
1322 process_coding to 0 (bug#9912).
1324 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1326 * xmenu.c (cleanup_widget_value_tree): New function.
1327 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1328 calling free_menubar_widget_value_tree directly (Bug#9830).
1330 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1332 Fix some portability problems with 'inline'.
1333 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1334 (window_box_width, window_box_left, window_box_left_offset)
1335 (window_box_right, window_box_right_offset): Declare extern.
1336 Otherwise, these inline functions do not conform to C99 and
1337 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1338 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1339 * intervals.c (adjust_intervals_for_insertion)
1340 (adjust_intervals_for_deletion): Now extern, because otherwise the
1341 extern inline functions 'offset_intervals' couldn't refer to it.
1342 (static_offset_intervals): Remove.
1343 (offset_intervals): Rewrite using the old contents of
1344 static_offset_intervals. The old version didn't conform to C99
1345 because an extern inline function contained a reference to an
1346 identifier with static linkage.
1348 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1350 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1353 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1355 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1356 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1357 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1358 return Qleft_to_right.
1360 2011-11-06 Chong Yidong <cyd@gnu.org>
1362 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1363 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1364 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1365 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1366 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1367 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1368 (Fwindow_vscroll): Doc fix.
1369 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1370 argument, since it makes no sense to pass a live window and for
1371 consistency with window-child.
1373 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1375 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1378 2011-11-05 Jason Rumney <jasonr@gnu.org>
1380 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1381 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1383 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1384 bitwise arithmetic preventing use of unicode-sip and non-truetype
1387 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1389 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1392 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1393 initialization code to keep similarity to xfns.c after changes
1396 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1398 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1399 (unwind_create_frame): New function (Bug#9943).
1400 (Fx_create_frame): Restructure code to be more similar to the one in
1401 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1402 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1403 Move terminal->reference_count++ just before making the frame official
1406 * nsterm.m (x_free_frame_resources): New function.
1407 (x_destroy_window): Move code to x_free_frame_resources.
1409 * xfns.c (unwind_create_frame): Fix comment.
1410 (Fx_create_frame, x_create_tip_frame):
1411 Move terminal->reference_count++ just before making the frame
1412 official. Move initialization of image_cache_refcount and
1413 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1415 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1417 Support MSVC build with newer versions of Visual Studio.
1418 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1419 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1422 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1423 which are not supported by MSVC.
1424 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1425 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1427 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1429 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1431 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1433 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1435 Support MSVC build with newer versions of Visual Studio.
1436 * w32.c: Don't include w32api.h for MSVC.
1437 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1439 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1440 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1441 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1442 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1444 (alloca) [_MSC_VER]: Define to _alloca.
1446 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1448 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1450 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1452 * xdisp.c (note_mouse_highlight): If either of
1453 previous/next-single-property-change returns nil, treat that as
1454 the beginning or the end of the buffer. (Bug#9955)
1456 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1458 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1459 label is not null (Bug#9951).
1460 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1463 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1465 * window.c (Fwindow_body_size): Mention in the doc string that the
1466 return value is in frame's canonical units. (Bug#9949)
1468 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1470 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1472 * w32fns.c (unwind_create_frame): If needed, free the glyph
1473 matrices of the partially constructed frame. (Bug#9943)
1474 * xfns.c (unwind_create_frame): Likewise.
1476 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1478 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1479 Don't stop backward scan on the continuation glyph, even though
1480 its CHARPOS is positive.
1481 (mouse_face_from_buffer_pos, note_mouse_highlight):
1482 Rename cover_string to disp_string.
1484 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1486 * window.c (temp_output_buffer_show): Don't use
1487 Vtemp_buffer_show_specifiers.
1488 (Vtemp_buffer_show_specifiers): Remove unused variable.
1490 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1492 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1493 past the beginning of the current glyph matrix.
1495 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1497 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1498 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1499 HAVE_GTK3 (Bug#9869).
1501 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1502 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1504 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1506 * xterm.c: Declare x_handle_net_wm_state to return int.
1507 (handle_one_xevent): Check if we are iconified but don't have
1508 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1509 (get_current_wm_state): Return non-zero if not hidden,
1510 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1511 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1512 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1513 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1515 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1517 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1518 so that this new function doesn't get optimized away by a
1519 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1521 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1523 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1525 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1527 Fix the `xbytecode' command.
1528 * .gdbinit (xprintbytestr): New command.
1529 (xwhichsymbols): Rename from `which'; all callers changed.
1530 (xbytecode): Print the byte-code string as well.
1532 2011-10-29 Kim Storm <storm@cua.dk>
1534 * alloc.c (which_symbols): New function.
1536 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1538 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1541 2011-10-29 Glenn Morris <rgm@gnu.org>
1543 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1544 Not clear what it was for, and it causes various bugs. (Bug#9839)
1546 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1548 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1549 possible random value that matches one of those tested as
1550 condition to clear the mouse face.
1552 2011-10-28 Chong Yidong <cyd@gnu.org>
1554 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1556 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1558 * window.c (make_window): Initialize phys_cursor_on_p.
1560 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1562 * lisp.h (struct Lisp_Symbol): Update comments.
1564 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1566 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1568 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1570 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1571 <oslsachem@gmail.com> for helping to debug this.
1573 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1574 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1575 (g_b_init_get_glyph_outline_w): New static variables.
1576 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1577 (GetGlyphOutlineW_Proc): New typedefs.
1578 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1579 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1581 (w32font_open_internal, compute_metrics):
1582 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1583 instead of calling the "wide" APIs directly.
1585 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1587 * w32.h (syms_of_w32font): Add prototype.
1589 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1591 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1592 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1593 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1594 (Fmove_to_window_line): Doc fix.
1596 2011-10-27 Chong Yidong <cyd@gnu.org>
1598 * process.c (make_process): Set gnutls_state to NULL.
1600 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1601 non-NULL, regardless of GNUTLS_INITSTAGE.
1602 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1603 an error. Set process slots as soon as we allocate them.
1605 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1607 2011-10-27 Chong Yidong <cyd@gnu.org>
1609 * gnutls.c (emacs_gnutls_deinit): New function.
1610 Deallocate credentials structures as well as calling gnutls_deinit.
1611 (Fgnutls_deinit, Fgnutls_boot): Use it.
1613 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1614 (deactivate_process): Call emacs_gnutls_deinit.
1616 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1618 * image.c (x_create_x_image_and_pixmap):
1619 * w32.c (sys_rename, w32_delayed_load):
1620 * w32font.c (fill_in_logfont):
1621 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1623 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1625 * w32fns.c (w32_default_color_map): New function,
1626 extracted from Fw32_default_color_map.
1627 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1629 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1631 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1633 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1635 * keyboard.c (test_undefined): New function (bug#9751).
1636 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1638 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1640 * sysdep.c (init_sys_modes): Fix the check for the controlling
1641 terminal (Bug#6649).
1643 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1645 * dispextern.h (struct bidi_it): New member next_en_type.
1647 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1648 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1649 current character, check also for next_en_type being WEAK_EN.
1650 (bidi_resolve_weak): Don't enter the expensive loop if the current
1651 position is before next_en_pos. Record the bidi type of the first
1652 non-ET, non-BN character we find, in addition to its position.
1653 (bidi_level_of_next_char): Invalidate next_en_type when
1654 next_en_pos is over-stepped.
1656 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1658 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1659 * editfns.c: Rewrite current-time-zone so that it invokes
1660 the equivalent of (format-time-string "%Z") to get the time zone name.
1661 This fixes a bug when the time zone name contains characters that
1662 need converting from the system time locale to Emacs internal format.
1663 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1664 that patch fixed format-time-string to do the conversion, but
1665 I forgot to fix current-time-zone.
1666 (format_time_string): New function, containing most of
1667 what Fformat_time_string used to contain.
1668 (Fformat_time_string): Rewrite in terms of format_time_string.
1669 This doesn't change this function's behavior.
1670 (current-time-zone): Rewrite to use format_time_string.
1671 This fixes the bug reported by Michael Schierl in
1672 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1673 Jason Rumney's 2007-06-07 change worked around this bug, but
1675 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1677 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1679 * xdisp.c (start_display): If the character at POS is displayed
1680 via a display vector, reset IT->current.dpvec_index to zero.
1681 (try_window_reusing_current_matrix): If a line ends in a display
1682 vector or the next line starts in a display vector, continue
1683 redrawing the window even though the character position of
1684 start_row was reached.
1687 2011-10-18 Chong Yidong <cyd@gnu.org>
1689 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1690 with nobreak-char-display too.
1692 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1694 Fix part 3 of bug#9771.
1695 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1696 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1697 non-neutral characters if the current character is a paragraph
1698 separator (a.k.a. Newline). This avoids running the same
1699 expensive loop twice, once when we consume the preceding newline
1700 and the other time when the line actually needs to be displayed.
1701 Avoid the loop when we see neutrals on the base embedding level
1702 following a character whose directionality is the same as the
1703 paragraph's. This avoids running the expensive loop when a line
1704 ends in a long sequence of neutrals, like control characters.
1705 Add assertion against STRONG_AL type. Slightly rearrange code
1706 that determines the type of a neutral given the first non-neutral
1708 (bidi_level_of_next_char): Set next_en_pos to zero when
1709 invalidating its info.
1711 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1713 * xdisp.c (push_display_prop): Determine whether to record string
1714 or buffer position by IT->string, not by IT->method. Allow
1715 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1716 (move_it_vertically_backward): Don't look for character position
1717 immediately after the newline when in a continuation line.
1720 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1722 * window.c (coordinates_in_window): Rewrite and delabelize
1723 vertical border check. (Bug#5357) (Bug#9618)
1725 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1727 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1728 errors in XSetWindowBorder (bug#9310).
1730 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1732 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1733 avoid crash when xmalloc overrun checking is enabled.
1735 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1737 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1738 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1739 cursor motion with <left> and <right> arrow keys.
1741 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1742 some callers set that themselves.
1744 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1746 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1747 display string and the previous row comes from the same string and
1748 is empty. (Bug#9739) (Bug#9738)
1750 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1752 * doc.c (get_doc_string): Encode file name (bug#9735).
1754 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1756 * bidi.c (bidi_level_of_next_char):
1757 * xdisp.c (get_visually_first_element): Remove old incorrect
1758 comments regarding the Unicode Line Separator character.
1760 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1762 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1764 * alloc.c (Fgc_status): Do not access beyond zombies array
1765 boundary if nzombies > MAX_ZOMBIES.
1766 * alloc.c (dump_zombies): Add missing format specifier.
1768 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1770 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1771 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1773 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1774 Some packages use them to denote characters with modifiers.
1776 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1778 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1779 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1780 matching a pp-number. Rename parameter var to var1.
1782 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1784 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1786 2011-10-08 Glenn Morris <rgm@gnu.org>
1788 * callint.c (Fcall_interactively): Give a more explicit error for the
1789 'c' case with a non-character input. (Bug#8479)
1791 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1793 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1795 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1796 lines that are hscrolled on the left.
1798 * dispnew.c (buffer_posn_from_coords): Account for a possible
1799 presence of header-line. (Bug#4426)
1801 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1803 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1804 Don't advertise functionality which we discourage or doesn't work.
1806 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1808 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1809 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1810 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1811 this makes Emacs dump core during garbage collection on rare
1812 occasions. sizeof is obviously inferior to offsetof here, so
1813 stick with offsetof.
1814 (GC_POINTER_ALIGNMENT): New macro.
1815 (mark_memory): Omit 3rd (offset) arg; caller changed.
1816 Don't assume EMACS_INT alignment is the same as pointer alignment.
1818 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1820 * keyboard.c (read_key_sequence_remapped): New var.
1821 (read_key_sequence): Compute remapping in the right buffer.
1822 (command_loop_1): Use read_key_sequence's remapping directly.
1824 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1826 * dired.c (file_name_completion): Don't expand file name.
1827 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1828 before checking file name handler.
1830 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1831 they've been requested explicitly (bug#9591).
1833 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1835 * keymap.c (Fsingle_key_description): Use make_specified_string
1836 instead of build_string to build string from push_key_description.
1839 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1841 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1842 This fixes a Y2038 bug on 64-bit hosts.
1843 * buffer.c (reset_buffer):
1844 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1845 (Fclear_buffer_auto_save_failure):
1846 Use 0, not -1, to represent an unset failure time, since time_t
1847 might not be signed.
1849 Remove dependency on glibc malloc internals.
1850 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1851 Move back here from lisp.h, but with their new implementations.
1852 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1853 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1854 * charset.c (charset_table_init): New static var.
1855 (syms_of_charset): Use it instead of xmalloc. This removes a
1856 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1857 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1858 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1859 Move back to alloc.c.
1860 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1861 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1863 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1865 * nsterm.m (windowDidResize): Call x_set_window_size only when
1866 ns_in_resize is true. Otherwise set pixelwidth/height and
1867 call change_frame_size (Bug#9628).
1869 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1871 Port --enable-checking=all to Fedora 14 x86-64.
1872 * charset.c (syms_of_charset): Also account for glibc malloc's
1873 internal overhead when calculating the initial malloc maximum.
1875 Port --enable-checking=all to Fedora 14 x86.
1876 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1878 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1879 (overrun_check_realloc, overrun_check_free):
1880 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1881 That way, xmalloc returns a properly-aligned pointer even if
1882 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1883 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1884 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1885 into account when calculating the initial malloc maximum.
1886 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1887 Move here from alloc.c, so that charset.c can use it too.
1888 Properly align; the old code wasn't right for common 32-bit hosts
1889 when configured with --enable-checking=all.
1890 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1891 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1893 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1895 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1898 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1900 * xdisp.c (compute_display_string_end): If there's no display
1901 string at CHARPOS, return -1.
1903 * bidi.c (bidi_fetch_char): When compute_display_string_end
1904 returns a negative value, treat the character as a normal
1905 character not covered by a display string. (Bug#9624)
1907 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1909 * lread.c (Fread_from_string): Fix typo in docstring.
1911 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1913 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1914 newline, reseat the iterator instead of bidi-iterating there one
1915 character at a time. (Bug#9610)
1916 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1917 TO_CHARPOS if the bidi iterator is at base embedding level.
1919 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1921 * lread.c (readevalloop): Use correct code for NBSP.
1922 (read1): Likewise. (Bug#9608)
1924 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1926 * dbusbind.c (Fdbus_register_signal): When service is not
1927 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1929 2011-09-25 Glenn Morris <rgm@gnu.org>
1931 * buffer.c (truncate-lines): Doc fix.
1933 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1935 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1936 (Fset_window_next_buffers): Doc fix.
1938 2011-09-24 Glenn Morris <rgm@gnu.org>
1940 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1942 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1944 Fix minor problems found by static checking.
1945 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1946 * indent.c (Fvertical_motion): Fix == vs = typo.
1948 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1950 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1951 Default value is now t. Doc fix.
1953 * indent.c (Fvertical_motion): Compute and apply the overshoot
1954 logic when moving up, not only when moving down. Fix the
1955 confusing name and values of the it_overshoot_expected variable;
1956 logic changes accordingly. (Bug#9254) (Bug#9549)
1958 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1959 CHARPOS is covered by a display string which includes newlines.
1960 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1961 is covered by a display string with embedded newlines.
1963 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1965 * dbusbind.c (Fdbus_register_signal): Add match rule to
1966 Vdbus_registered_objects_table. (Bug#9581)
1967 (Fdbus_register_method, Vdbus_registered_objects_table):
1970 2011-09-24 Jim Meyering <meyering@redhat.com>
1972 do not ignore write error for any output size
1973 The previous change was incomplete.
1974 While it makes emacs --batch detect the vast majority of stdout
1975 write failures, errors were still ignored whenever the output size is
1976 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1977 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1978 && echo FAIL: ignored write error
1979 FAIL: ignored write error
1980 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1981 && echo FAIL: ignored write error
1982 FAIL: ignored write error
1983 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1985 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1987 * emacs.c (Fkill_emacs): In noninteractive mode exit
1988 non-successfully if a write error occurred on stdout. (Bug#9574)
1990 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1992 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1995 * dispextern.h (struct it): Update the comment documenting what
1998 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2000 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2001 a display string, extend search for cursor position to end of row.
2002 (find_row_edges): If the row ends in a newline from a display
2003 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2004 Handle the case of a display string with multiple newlines.
2005 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2006 non-empty line. Fixes confusing cursor motion with arrow keys at
2007 the beginning of a line that starts with whitespace.
2009 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2011 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2014 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2016 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2019 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2021 * xdisp.c (display_line): Record maximum and minimum buffer
2022 positions even if no glyphs were produced (e.g., by a zero-width
2023 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2024 buffer positions that will be removed from the glyph row because
2026 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2027 column is beyond frame width: don't subtract 1 "pixel" when
2028 computing width of the stretch.
2029 (reseat_at_next_visible_line_start): Undo the change made on
2030 2011-09-17 that saved paragraph information and restored it after
2031 the call to `reseat'. (Bug#9545)
2033 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2035 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2036 and turn window cursor on if cleared (Bug#9415).
2038 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2040 * search.c (boyer_moore): Take unibyte characters from pattern
2041 literally. (Bug#9458)
2043 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2045 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2047 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2049 Fix minor problem found by static checking.
2050 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2051 initialized, to pacify gcc -Wuninitialized.
2053 * fileio.c: Report proper errno when syscall falls.
2054 (Finsert_file_contents): Save and restore errno,
2055 so that report_file_error outputs the correct diagnostic.
2056 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2058 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2060 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2062 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2064 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2065 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2067 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2069 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2070 about the current paragraph and restore it after the call to reseat.
2072 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2073 (bidi_find_paragraph_start): Search back for paragraph beginning
2074 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2075 (bidi_move_to_visually_next): Only trigger paragraph-related
2076 computations when the last character is a newline or at EOB, not
2077 just any NEUTRAL_B. (Bug#9470)
2079 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2080 truncated lines if point is covered by a display string. (Bug#9524)
2082 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2084 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2085 (cons_to_x_long): New function.
2086 (lisp_data_to_selection_data): Use it. Correct the test for
2087 short-versus-long data; it was negated. Break out of vector
2088 loop, for efficiency, when a long datum is discovered.
2090 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2092 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2094 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2096 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2097 GCC PR/17406) by declaring this function with external scope.
2099 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2101 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2102 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2104 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2106 * editfns.c (Fformat): Correctly handle text properties on "%%".
2108 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2110 * xterm.c (x_draw_composite_glyph_string_foreground):
2111 * w32term.c (x_draw_composite_glyph_string_foreground):
2112 * term.c (encode_terminal_code):
2113 * composite.c (composition_update_it, get_composition_id):
2114 * xdisp.c (get_next_display_element)
2115 (fill_composite_glyph_string): Add comments about special meaning
2116 of TAB characters in a composition.
2118 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2120 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2121 This occurs when processing a multibyte format.
2122 Problem reported by Wolfgang Jenker.
2124 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2126 * xdisp.c (try_cursor_movement): Only check for exact match if
2127 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2129 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2131 Remove unused external symbols.
2132 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2133 * xdisp.c (calc_pixel_width_or_height): Now static.
2134 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2135 * indent.c (check_display_width):
2136 * w32term.c: Fix comment to match code.
2137 * xterm.c, xterm.h (x_catching_errors): Remove.
2139 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2141 * xselect.c: Use signed conversions more consistently (Bug#9498).
2142 (selection_data_to_lisp_data): Assume incoming selection data are
2143 signed integers, not unsigned. This is to be consistent with
2144 outgoing selection data, which was modified to use signed integers
2145 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2146 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2147 expects long, not unsigned long.
2149 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2151 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2152 computation of loop end. Reported by Johan Bockgård
2155 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2157 * frame.c (Fother_visible_frames_p): Function deleted.
2159 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2161 * indent.c (compute_motion): Process display vector front to back
2162 rather than the other way around. (Bug#2496)
2164 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2166 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2168 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2170 * minibuf.c (Fread_from_minibuffer): Doc fix.
2172 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2174 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2175 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2177 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2179 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2180 value for non-existent files.
2182 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2184 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2185 set its "size" to -1. This will set the modtime_size field of
2186 the corresponding buffer to -1, which is what
2187 verify-visited-file-modtime expects for files that do not exist.
2190 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2192 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2194 * lisp.h: ... from here. push_key_description is no longer
2195 defined in keyboard.c, so its declaration should not be in
2196 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2197 logically belongs with push_key_description.
2199 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2201 * buffer.h: Include <sys/types.h> instead of <time.h>.
2202 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2203 Problem reported by Herbert J. Skuhra.
2205 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2207 * xml.c (parse_region): Make the parsing work for
2208 non-comment-starting XML files again (bug#9144).
2210 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2212 * image.c (gif_load): Fix calculation of bottom and right corner.
2215 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2217 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2218 redisplay in small windows.
2220 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2222 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2224 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2226 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2227 Operate on live windows only.
2229 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2231 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2233 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2235 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2236 only under bidi iteration.
2238 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2240 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2242 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2244 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2245 Without this fix, the command to link temacs failed due to an
2246 undefined symbol __builtin_isnan. This is because
2247 /usr/include/iso/math_c99.h #defines isnan(x) to
2248 __builtin_isnan(x), but the bundled gcc, which identifies itself
2249 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2251 * floatfns.c (isnan): #undef, and then #define to a clone of
2253 (Fisnan): Always define, since it's always available now.
2254 (syms_of_floatfns): Always define isnan at the Lisp level.
2256 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2258 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2260 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2262 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2263 The previous code assumed that file offsets (off_t values) fit in
2264 EMACS_INT variables, which is not true on typical 32-bit hosts.
2265 The code messed up by falsely reporting buffer overflow in cases
2266 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2267 when "big" contains more than 2**29 bytes, even though this
2268 inserts just one byte and does not overflow the buffer.
2269 (Finsert_file_contents): Store file offsets as off_t
2270 values, not as EMACS_INT values. Check for overflow when
2271 converting between EMACS_INT and off_t. When checking for
2272 buffer overflow or for overlap, take the offsets into account.
2273 Don't use EMACS_INT for small values where int suffices.
2274 When checking for overlap, fix a typo: ZV was used where
2275 ZV_BYTE was intended.
2276 (Fwrite_region): Don't assume off_t fits into 'long'.
2277 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2279 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2281 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2283 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2285 sprintf-related integer and memory overflow issues (Bug#9412).
2287 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2288 (esprintf, exprintf, evxprintf): New functions.
2289 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2290 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2291 (modify_event_symbol): Do not assume that the length of
2292 name_alist_or_stem is safe to alloca and fits in int.
2293 (Fexecute_extended_command): Likewise for function name and binding.
2294 (Frecursion_depth): Wrap around reliably on integer overflow.
2295 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2296 since some callers pass EMACS_INT values.
2297 (Fsingle_key_description): Don't crash if symbol name contains more
2298 than MAX_ALLOCA bytes.
2299 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2300 (get_minibuffer): Arg is now EMACS_INT, not int.
2301 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2302 (esprintf, exprintf, evxprintf): New decls.
2303 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2305 * dbusbind.c (signature_cat): New function.
2306 (xd_signature, Fdbus_register_signal):
2307 Do not overrun buffer; instead, report string overflow.
2309 * dispnew.c (add_window_display_history): Don't overrun buffer.
2310 Truncate instead; this is OK since it's just a log.
2312 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2313 even if the time zone offset is outlandishly large.
2314 Don't mishandle offset == INT_MIN.
2316 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2317 when creating daemon; the previous buffer-overflow check was incorrect.
2319 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2320 which has the guts of the old verror function.
2322 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2323 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2325 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2326 (font_unparse_xlfd): Don't blindly alloca long strings.
2327 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2328 fits in int, when using sprintf. Use single snprintf to count
2329 length of string rather than counting it via multiple sprintfs;
2330 that's simpler and more reliable.
2331 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2332 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2333 sprintf, in case result does not fit in int.
2335 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2336 (fontset_from_font): Print it.
2338 * frame.c (tty_frame_count): Now printmax_t, not int.
2339 (make_terminal_frame, set_term_frame_name): Print it.
2340 (x_report_frame_params): In X, window IDs are unsigned long,
2341 not signed long, so print them as unsigned.
2342 (validate_x_resource_name): Check for implausibly long names,
2343 and don't assume name length fits in 'int'.
2344 (x_get_resource_string): Don't blindly alloca invocation name;
2345 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2348 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2349 (xg_check_special_colors, xg_set_geometry):
2350 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2352 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2353 Use esprintf, not sprintf, in case result does not fit in int.
2355 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2356 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2357 it as a large positive number.
2358 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2359 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2361 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2362 in case result does not fit in int.
2364 * print.c (float_to_string): Detect width overflow more reliably.
2365 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2366 buffer overrun. Don't assume list length fits in 'int'. Treat
2367 print length of 0 as 0, not as infinity; to be consistent with other
2368 uses of print length in this function. Don't overflow print length
2369 index. Don't assume hash table size fits in 'long', or that
2370 vectorlike size fits in 'unsigned long'.
2372 * process.c (make_process): Use printmax_t, not int, to format
2373 process-name gensyms.
2375 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2377 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2378 to avoid potential buffer overrun.
2380 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2381 if X resource line is longer than 512 bytes.
2383 * xfns.c (x_window): Make sprintf buffer a bit bigger
2384 to avoid potential buffer overrun.
2386 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2388 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2390 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2392 Integer overflow fixes for scrolling, etc.
2393 Without these, Emacs silently mishandles large integers sometimes.
2394 For example, "C-u 4294967297 M-x recenter" was treated as if
2395 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2397 * xdisp.c (try_window_id): Check Emacs fixnum range before
2398 converting to 'int'.
2400 * window.c (window_scroll_line_based, Frecenter):
2401 Check that an Emacs fixnum is in range before assigning it to 'int'.
2402 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2403 values converted from Emacs fixnums.
2404 (Frecenter): Don't wrap around a line count if it is out of 'int'
2405 range; instead, treat it as an extreme value.
2406 (Fset_window_configuration, compare_window_configurations):
2407 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2409 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2410 that can exceed INT_MAX. Check that EMACS_INT value is in range
2411 before assigning it to the (possibly-narrower) index.
2412 (match_limit): Don't assume that a fixnum can fit in 'int'.
2414 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2417 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2418 (Fvertical_motion): Don't wrap around LINES values that don't fit
2419 in 'int'. Instead, treat them as extreme values. This is good
2420 enough for windows, which can't have more than INT_MAX lines anyway.
2422 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2424 * Require libxml/parser.h to avoid compilation warning.
2426 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2428 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2429 since this reportedly can destroy thread storage.
2431 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2433 * syntax.c (find_defun_start): Update all cache variables if
2434 exiting early (Bug#9401).
2436 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2438 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2440 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2441 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2442 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2444 * term.c (tty_append_glyph): New function.
2445 (produce_stretch_glyph): Static function and its prototype deleted.
2447 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2450 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2452 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2453 when checking :margin (Bug#9390).
2454 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2455 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2456 so that the name doesn't mislead. All uses changed.
2458 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2460 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2463 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2465 * xdisp.c (move_it_to): Don't bail out early when reaching
2466 position beyond to_charpos, if we are scanning backwards.
2467 (move_it_vertically_backward): When DY == 0, make sure we get to
2468 the first character in the line after the newline.
2470 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2472 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2473 (ccl_driver): Do not generate an out-of-range pointer.
2474 (Fccl_execute_on_string): Remove unnecessary check for
2475 integer overflow, noted by Stefan Monnier in
2476 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2477 Remove a FIXME that didn't need fixing.
2478 Simplify the newly-introduced buffer reallocation code.
2480 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2482 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2484 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2486 Integer and memory overflow issues (Bug#9196).
2488 * doc.c (get_doc_string): Rework so that
2489 get_doc_string_buffer_size is the actual buffer size, rather than
2490 being 1 less than the actual buffer size; this makes xpalloc more
2493 * image.c (x_allocate_bitmap_record, cache_image):
2494 * xselect.c (Fx_register_dnd_atom):
2495 Simplify previous changes by using xpalloc.
2497 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2498 since either will do and ptrdiff_t is convenient with xpalloc.
2500 * charset.c (charset_table_size)
2501 (struct charset_sort_data.priority): Now ptrdiff_t.
2502 (charset_compare): Don't overflow if priorities differ greatly.
2503 (Fsort_charsets): Don't assume list length fits in int.
2504 Check for size-calculation overflow when allocating sort data.
2505 (syms_of_charset): Allocate an initial charset table that is
2506 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2508 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2510 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2511 The actual value is always <= INT_MAX, and leaving it unsigned made
2512 overflow checking harder.
2514 * dispextern.h (struct glyph_matrix.rows_allocated)
2515 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2516 with xpalloc. The values are still always <= INT_MAX.
2518 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2520 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2521 (SAFE_NALLOCA): New macro.
2523 * region-cache.c (struct boundary.pos, find_cache_boundary)
2524 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2525 (set_cache_region, invalidate_region_cache)
2526 (revalidate_region_cache, know_region_cache, region_cache_forward)
2527 (region_cache_backward, pp_cache):
2528 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2529 so that ptrdiff_t * can be passed to xpalloc.
2530 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2531 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2532 (pp_cache): Don't assume cache_len fits in int.
2533 * region-cache.h: Adjust extern decls to match.
2535 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2536 EMACS_INT, since either will do, for xpalloc.
2538 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2539 (xnmalloc, xnrealloc, xpalloc): New functions.
2541 * bidi.c (bidi_shelve_header_size): New constant.
2542 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2543 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2545 * bidi.c (bidi_cache_shrink):
2546 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2548 Don't update size of array until after memory allocation succeeds,
2549 because xmalloc/xrealloc may not return.
2550 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2551 now that we have proper integer overflow checking.
2552 (record_overlay_string, overlay_strings): Catch overflows when
2553 calculating size of overlay_str_buf.
2555 * callproc.c (Fcall_process): Check for size overflow when
2556 calculating size of args2.
2557 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2558 Normally we prefer signed values, but sticking with ptrdiff_t would
2559 require adding more-complicated checks.
2561 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2562 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2563 Redo buffer-overflow calculations to avoid integer overflow.
2564 Add a FIXME comment where memory seems to be over-allocated.
2566 * character.c (Fstring): Check for size-calculation overflow.
2568 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2569 unnecessary integer overflow. Check for size overflow.
2570 (encode_coding_object): Don't update size until xmalloc succeeds.
2572 * composite.c (get_composition_id): Check for overflow in glyph
2573 length calculations.
2575 Integer and memory overflow fixes for display code.
2576 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2577 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2578 (scrolling_window): Check for overflow in size calculations.
2579 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2580 Don't assume glyph table len fits in int.
2581 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2582 (row_table_size): Now ptrdiff_t, not int.
2583 (scrolling_window): Avoid overflow in size calculations.
2584 Don't update size until allocation succeeds.
2585 * fns.c (concat): Check for overflow in size calculations.
2586 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2587 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2588 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2590 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2591 (get_doc_string): Check for size calculation overflow.
2592 Don't update size until allocation succeeds.
2593 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2594 EMACS_INT, where ptrdiff_t will do.
2595 (Fsubstitute_command_keys): Check for string overflow.
2597 * editfns.c (set_time_zone_rule): Don't assume environment length
2599 (message_length): Now ptrdiff_t, not int.
2600 (Fmessage_box): Don't update size until allocation succeeds.
2601 Don't assume message length fits in int.
2602 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2604 * emacs.c (main): Do not reallocate argv, since there is a null at
2605 the end that can be overwritten, and this way there's no need to
2606 worry about size-calculation overflow.
2607 (sort_args): Check for size-calculation overflow.
2609 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2611 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2613 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2614 (x_set_scroll_bar_width, x_figure_window_size):
2615 Check for integer overflow.
2616 (x_set_alpha): Do not assume XINT fits in int.
2618 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2619 This is for the members text_lines, text_cols, total_lines, total_cols,
2620 where the system imposes an 'int' limit.
2622 * fringe.c (Fdefine_fringe_bitmap):
2623 Don't update size until alloc works.
2625 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2626 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2628 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2629 Check for size-calculation overflow.
2630 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2631 do, as we prefer signed integers.
2632 (id_to_widget.max_size, id_to_widget.used)
2633 (xg_store_widget_in_map, xg_remove_widget_from_map)
2634 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2635 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2636 Use and return ptrdiff_t, not int.
2637 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2638 * gtkutil.h: Change prototypes to match the above.
2640 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2641 are duplicate now that they've been promoted to lisp.h.
2642 (x_allocate_bitmap_record, x_alloc_image_color)
2643 (make_image_cache, cache_image, xpm_load):
2644 Don't update size until alloc is done.
2645 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2647 Check for size calculation overflow.
2648 (ct_colors_allocated_max): New constant.
2649 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2652 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2653 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2654 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2655 Use ptrdiff_t, not int, to count maps.
2656 (read_char_minibuf_menu_prompt): Check for overflow in size
2657 calculations. Don't update size until allocation succeeds.
2658 Redo calculations to avoid overflow.
2659 * keyboard.h: Change prototypes to match the above.
2661 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2663 (current_minor_maps): Check for size calculation overflow.
2664 * keymap.h: Change prototypes to match the above.
2666 * lread.c (read1, init_obarray): Don't update size until alloc done.
2668 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2669 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2671 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2672 Now ptrdiff_t, not int.
2673 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2674 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2676 * process.c (Fnetwork_interface_list): Check for overflow
2677 in size calculation.
2679 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2681 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2682 overflow. Don't bother calling xmalloc when xrealloc will do.
2684 * search.c (Freplace_match): Check for size calculation overflow.
2685 (Fset_match_data): Don't assume list lengths fit in 'int'.
2687 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2688 for command line length. Do not attempt to address one before the
2689 beginning of an array, as that's not portable.
2691 * term.c (max_frame_lines): Remove; unused.
2692 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2694 (encode_terminal_code, calculate_costs): Check for size
2695 calculation overflow.
2696 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2697 table lengths and related sizes. Don't update size until alloc
2698 done. Redo calculations to avoid overflow.
2699 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2701 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2702 subtracting pointers.
2703 (gobble_line): Check for overflow more carefully. Don't update size
2706 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2707 Don't update size until alloc done.
2708 Redo size calculations to avoid overflow.
2709 Check for size calculation overflow.
2710 (main) [DEBUG]: Fix typo in invoking tparam1.
2712 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2713 Use ptrdiff_t, not int, for sizes.
2714 (store_mode_line_noprop_char): Don't update size until alloc done.
2716 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2717 Use ptrdiff_t, not int, for sizes.
2718 (Finternal_make_lisp_face, cache_face):
2719 Check for size calculation overflow.
2720 (cache_face): Treat size calculation overflows as if they were
2721 memory exhaustion (the usual treatment), rather than aborting.
2723 * xfns.c (x_encode_text, x_set_name_internal)
2724 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2725 sizes, since they can exceed INT_MAX in size. Check for size
2726 calculation overflow.
2728 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2729 (xg_select): Check for size calculation overflow.
2730 Don't update size until alloc done.
2732 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2733 as sprintf is limited to int lengths.
2735 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2736 (X_LONG_MIN): New macros.
2737 Use them to make the following changes clearer.
2738 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2739 This change doesn't affect the value now, but it may help remind
2740 future maintainers not to raise the value too much later.
2741 (SELECTION_QUANTUM): Remove, replacing with ...
2742 (selection_quantum): ... new function, which avoids overflow.
2744 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2745 assumption that selection length fits in 'int'.
2746 (x_reply_selection_request, x_handle_selection_request)
2747 (x_get_window_property, receive_incremental_selection)
2748 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2749 (lisp_data_to_selection_data, clean_local_selection_data):
2750 Use ptrdiff_t, not int, to record length of selection.
2751 (x_reply_selection_request, x_get_window_property)
2752 (receive_incremental_selection, x_property_data_to_lisp):
2753 Redo calculations to avoid overflow.
2754 (x_reply_selection_request): When sending hint, ceiling it at
2755 X_LONG_MAX rather than relying on wraparound overflow to send
2757 (x_get_window_property, receive_incremental_selection)
2758 (lisp_data_to_selection_data, x_property_data_to_lisp):
2759 Check for size-calculation overflow.
2760 (x_get_window_property, receive_incremental_selection)
2761 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2762 Don't store size until memory allocation succeeds.
2763 (x_get_window_property): Plug memory leak on memory exhaustion.
2764 Don't double-block input; malloc is safe here. Don't assume 2**34
2765 - 4 fits in unsigned long. Add an xassert to check
2766 XGetWindowProperty overflow. Be more careful about overflow
2767 calculations, and distinguish size from memory overflow better.
2768 (receive_incremental_selection): When tracing, don't assume
2769 unsigned int is less than INT_MAX.
2770 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2771 harmful) conversions of unsigned short to int.
2772 (lisp_data_to_selection_data): Don't assume that integers
2773 in the range -65535 through -1 fit in an X unsigned short.
2774 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2775 result parameters unless successful. Rely on cons_to_unsigned
2776 to report problems with elements; the old code wasn't right anyway.
2777 (x_check_property_data): Check for int overflow; we cannot use
2778 a wider type due to X limits.
2779 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2781 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2783 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2784 (x_term_init): Check for size calculation overflow.
2785 (x_color_cells): Don't store size until memory allocation succeeds.
2786 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2787 Don't assume alloca size is less than MAX_ALLOCA.
2788 (x_term_init): Don't assume length fits in int (sprintf is limited
2791 Use ptrdiff_t for composition IDs.
2792 * character.c (lisp_string_width):
2793 * composite.c (composition_table_size, n_compositions)
2794 (get_composition_id, composition_gstring_from_id):
2795 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2796 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2797 * window.c (Frecenter):
2798 Use ptrdiff_t, not int, for composition IDs.
2799 * composite.c (get_composition_id): Check for integer overflow.
2800 * composite.h: Adjust prototypes to match the above changes.
2802 Use ptrdiff_t for hash table indexes.
2803 * category.c (hash_get_category_set):
2804 * ccl.c (ccl_driver):
2805 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2806 * coding.c (coding_system_charset_list, detect_coding_system):
2807 * coding.h (struct coding_system.id):
2808 * composite.c (get_composition_id, gstring_lookup_cache):
2809 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2810 * image.c (xpm_get_color_table_h):
2811 * lisp.h (hash_lookup, hash_put):
2812 * minibuf.c (Ftest_completion):
2813 Use ptrdiff_t for hash table indexes, not int (which is too
2814 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2815 32-bit --with-wide-int hosts).
2817 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2818 Add a FIXME comment about memory leaks.
2819 (syms_of_charset): Don't assume xmalloc returns.
2821 Don't assume that stated character widths fit in int.
2822 * character.c (Fchar_width, c_string_width, lisp_string_width):
2823 * character.h (CHAR_WIDTH):
2824 * indent.c (MULTIBYTE_BYTES_WIDTH):
2825 Use sanitize_char_width to avoid undefined and/or bad behavior
2826 with outlandish widths.
2827 * character.h (sanitize_tab_width): Rename from sanitize_width,
2828 now that we have two such functions. All uses changed.
2829 (sanitize_char_width): New inline function.
2831 Don't assume that tab-width fits in int.
2832 * character.h (sanitize_width): New inline function.
2833 (SANE_TAB_WIDTH): New macro.
2834 (ASCII_CHAR_WIDTH): Use it.
2835 * indent.c (sane_tab_width): Remove. All uses replaced by
2836 SANE_TAB_WIDTH (current_buffer).
2837 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2839 * fileio.c: Integer overflow issues with file modes.
2840 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2842 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2843 Remove unreachable code.
2844 (read_hex, load_charset_map_from_file): Check for integer overflow.
2846 * xterm.c: Don't go over XClientMessageEvent limit.
2847 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2848 (x_send_scroll_bar_event): Likewise. Check that the size does not
2849 exceed limits imposed by XClientMessageEvent, as well as the usual
2850 ptrdiff_t and size_t limits.
2852 * keyboard.c: Overflow, signedness and related fixes.
2853 (make_lispy_movement): Use same integer type in forward decl
2854 that is used in the definition.
2855 (read_key_sequence, keyremap_step):
2856 Change bufsize argument back to int, undoing my 2011-03-30 change.
2857 We prefer signed types, and int is wide enough here.
2858 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2859 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2860 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2861 length, not size_t. Use ptrdiff_t for index, not int.
2862 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2863 possibility of integer overflow.
2865 Overflow, signedness and related fixes for images.
2867 * dispextern.h (struct it.stack[0].u.image.image_id)
2868 (struct_it.image_id, struct image.id, struct image_cache.size)
2869 (struct image_cache.used, struct image_cache.ref_count):
2870 * gtkutil.c (update_frame_tool_bar):
2871 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2872 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2873 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2874 * nsmenu.m (update_frame_tool_bar):
2875 * xdisp.c (calc_pixel_width_or_height):
2876 * xfns.c (image_cache_refcount):
2877 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2878 on typical 64-bit hosts.
2880 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2881 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2882 Omit unnecessary casts to int.
2883 (parse_image_spec): Check that integers fall into 'int' range
2884 when the callers expect that.
2885 (image_ascent): Redo ascent calculation to avoid int overflow.
2886 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2887 (lookup_image): Remove unnecessary tests.
2888 (xbm_image_p): Locals are now of int, not EMACS_INT,
2889 since parse_image_check makes sure they fit into int.
2890 (png_load, gif_load, svg_load_image):
2891 Prefer int to unsigned where either will do.
2892 (tiff_handler): New function, combining the cores of the
2893 old tiff_error_handler and tiff_warning_handler.
2894 This function is rewritten to use vsnprintf and thereby avoid
2895 stack buffer overflows. It uses only the features of vsnprintf
2896 that are common to both POSIX and native Microsoft.
2897 (tiff_error_handler, tiff_warning_handler): Use it.
2898 (tiff_load, gif_load, imagemagick_load_image):
2899 Don't assume :index value fits in 'int'.
2900 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2901 (imagemagick_load_image): Check that crop parameters fit into
2902 the integer types that MagickCropImage accepts. Don't assume
2903 Vimagemagick_render_type has a nonnegative value. Don't assume
2904 size_t fits in 'long'.
2905 (gs_load): Use printmax_t to print the widest integers possible.
2906 Check for integer overflow when computing image height and width.
2908 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2910 * xdisp.c (redisplay_window): Don't force window start if point
2911 will be invisible in the resulting window. (Bug#9324)
2913 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2915 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2916 the display spec is of the form `(space ...)'.
2917 (handle_display_spec): Return the value returned by
2918 handle_single_display_spec, not just 1 or zero.
2919 (handle_single_display_spec): If the display spec is of the form
2920 `(space ...)', and specifies display in the text area, return 2
2922 (try_cursor_movement): Check for the need to scroll more
2923 accurately, and prefer exact match for point under bidi.
2924 Don't advance `row' beyond the last row of the window.
2926 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2927 into disp_prop; all users changed.
2929 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2930 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2931 for the text covered by the display property.
2933 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2935 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2936 Change return value to nil.
2937 (Frecord_buffer): Delete unused function.
2939 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2941 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2942 buffers, return left-to-right.
2943 (set_cursor_from_row): Consider candidate row a win if its glyph
2944 represents a newline and point is on that newline. Fixes cursor
2945 positioning on the newline at EOL of R2L text within L2R
2946 paragraph, and vice versa.
2947 (try_cursor_movement): Check continued rows, in addition to
2948 continuation rows. Fixes unwarranted scroll when point enters a
2949 continued line of R2L text within an L2R paragraph, or vice versa.
2950 (cursor_row_p): Consider the case of point being equal to
2951 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2952 from the end of a short line to the beginning of a continued line
2953 of R2L text within L2R paragraph.
2954 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2955 composed characters.
2957 * bidi.c (bidi_check_type): Use xassert.
2958 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2961 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2963 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2966 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2968 * nsfont.m (ns_otf_to_script): Fix typo.
2970 2011-08-22 Kenichi Handa <handa@m17n.org>
2972 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2973 extra slot even if the purpose is char-code-property-table.
2975 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2977 * xdisp.c (redisplay_window): When computing centering_position,
2978 account for the height of the header line. (Bug#8874)
2980 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2981 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2982 candidate is selected by the mouse, and that candidate has a
2983 composed character under the mouse.
2985 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2986 coordinates reported by pos-visible-in-window-p for a composed
2987 character in column zero.
2989 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2991 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2993 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2995 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2996 consider it a hit if to_charpos is anywhere in the range of the
2997 composed buffer positions.
2999 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3001 * image.c (gif_load): Don't assume that each subimage has the same
3002 dimensions as the base image. Handle disposal method that is
3003 "undefined" by the gif spec (Bug#9335).
3005 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3007 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3008 (Fcondition_case): Document `debug' symbol in error handler.
3010 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3012 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3013 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3014 from an Org mode buffer to a Speedbar frame.
3016 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3017 a composition, take its buffer position from IT->cmp_it.charpos.
3018 Fixes cursor positioning at the beginning of a line that begins
3019 with a composed character.
3021 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3023 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3024 character bidirectional type, use STRONG_L instead. Fixes crashes
3025 in a buffer produced by `describe-categories'.
3027 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3028 members before the level stack, so they would be saved and
3029 restored when copying iterator state. Fixes incorrect reordering
3030 around TABs covered by display properties.
3032 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3034 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3036 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3038 * eval.c (internal_condition_case, internal_condition_case_1)
3039 (internal_condition_case_2, internal_condition_case_n):
3040 Remove unnecessary aborts (Bug#9081).
3042 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3044 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3045 has no `load' handler, try opening the file locally. (Bug#9311)
3047 2011-08-16 Ken Brown <kbrown@cornell.edu>
3049 * gmalloc.c: Expand comment.
3051 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3053 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3054 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3056 2011-08-16 Ken Brown <kbrown@cornell.edu>
3058 Fix memory allocation problems in Cygwin build (Bug#9273).
3060 * unexcw.c ( __malloc_initialized): Declare external variable.
3061 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3063 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3065 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3067 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3069 [CYGWIN] (special_realloc): New function.
3070 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3071 requests to realloc storage in the static heap.
3073 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3075 * bidi.c (bidi_initialize): Remove unused local.
3077 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3080 * biditype.h: Remove file.
3081 * makefile.w32-in ($(BLD)/bidi.$(O)):
3082 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3084 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3086 * chartab.c: Improve commentary for the uniprop_table API.
3088 * bidi.c (bidi_paragraph_init): Support zero value of
3089 bidi_ignore_explicit_marks_for_paragraph_level.
3090 (bidi_initialize): Use uniprop_table instead of including
3091 biditype.h and bidimirror.h.
3093 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3094 coordinates of the iterator when restoring from ppos_it.
3097 2011-08-14 Kenichi Handa <handa@m17n.org>
3099 * process.c (create_process): Call setup_process_coding_systems
3100 after the pid of the process is set to -1 (Bug#8162).
3102 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3104 * xdisp.c (move_it_in_display_line_to): Don't invoke
3105 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3106 ppos_it. Fixes vertical cursor motion when line beginning is
3107 covered by an image. (Bug#9296)
3109 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3111 * nsterm.h (ns_run_ascript): Declare.
3112 (NSAPP_DATA2_RUNASSCRIPT): Define.
3114 * nsfns.m (as_script, as_result, as_status): New static variables.
3115 (ns_run_ascript): New function.
3116 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3117 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3118 the event loop. Get status from as_status (Bug#7276).
3120 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3121 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3122 the event loop (Bug#7276).
3124 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3126 * gnutls.c (QCgnutls_bootprop_priority)
3127 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3128 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3129 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3130 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3131 (QCgnutls_bootprop_verify_hostname_error)
3132 (QCgnutls_bootprop_callbacks_verify): Rename from
3133 Qgnutls_bootprop_..., all uses changed.
3135 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3138 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3140 * xfaces.c (Qframe_set_background_mode): Now static.
3141 * dispextern.h (Qframe_set_background_mode): Remove decl.
3143 * process.c (Fnetwork_interface_info): Declare local only if needed.
3145 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3147 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3148 (Fnetwork_interface_list): Allocate in increments of bytes instead
3149 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3150 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3152 (struct ifflag_def): notrailers is smart on OSX.
3153 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3154 Get hardware address with getifaddrs if available.
3156 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3158 * xdisp.c (iterate_out_of_display_property): xassert that
3159 IT->position is set to within IT->object's boundaries. Break from
3160 the loop as soon as EOB is reached; avoids infloops in redisplay
3161 when IT->position is set up wrongly due to some bug.
3162 Set IT->current to match the bidi iterator unconditionally.
3163 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3164 entry. Force push_it to save on the stack the current
3165 buffer/string position, to be restored by pop_it. Fix flags in
3166 the iterator structure wrt the object coming from a display
3167 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3168 properties. (Bug#9284)
3170 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3172 * fontset.c (fontset_get_font_group): Add proper type checks.
3175 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3177 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3178 and LC_VERSION_MIN_MACOSX.
3179 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3180 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3182 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3184 * xdisp.c (forward_to_next_line_start): Allow to use the
3185 no-display-properties-and-no-overlays under bidi display.
3186 Set disp_pos in the bidi iterator to avoid searches for display
3187 properties and overlays.
3189 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3191 * editfns.c (Fset_time_zone_rule): Document relationship with the
3194 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3195 the font entity extracted from the cache (Bug#8109).
3197 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3199 * composite.c (autocmp_chars): Don't reset point. That is done by
3200 restore_point_unwind (Bug#5984).
3202 2011-08-07 Juri Linkov <juri@jurta.org>
3204 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3205 to show the arg `TIME' instead of `TIMEVAL'.
3207 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3209 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3210 display property strides EOL and includes a newline, as in
3211 longlines-mode. (Bug#9254)
3212 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3213 word-wrap under bidirectional display. (Bug#9224)
3215 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3216 is non-zero, even if the data buffer is NULL. Fixes a crash in
3217 vertical-motion with longlines-mode. (Bug#9254)
3219 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3221 * bidi.c <bidi_cache_total_alloc>: Now static.
3222 (bidi_initialize): Initialize bidi_cache_total_alloc.
3224 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3227 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3228 amount allocated this far in `bidi_cache_total_alloc'.
3229 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3230 non-zero, only free the data buffer without restoring the cache
3231 contents. All callers changed.
3233 * dispextern.h (bidi_unshelve_cache): Update prototype.
3235 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3236 (move_it_in_display_line, move_it_to)
3237 (move_it_vertically_backward, move_it_by_lines): Replace the call
3238 to xfree to an equivalent call to bidi_unshelve_cache.
3239 (move_it_in_display_line_to): Fix logic of returning
3240 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3242 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3244 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3245 came from a string character with a `cursor' property. (Bug#9229)
3247 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3249 * Makefile.in (LIB_PTHREAD): New variable.
3250 (LIBES): Add LIB_PTHREAD (Bug#9216).
3252 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3253 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3255 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3257 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3259 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3261 * xterm.c (x_find_topmost_parent): New function.
3262 (x_set_frame_alpha): Find topmost parent window with
3263 x_find_topmost_parent and set the property there also (bug#9181).
3264 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3266 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3268 * callproc.c (Fcall_process): Avoid vfork clobbering
3269 the local vars buffer, coding_systems, current_dir.
3271 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3273 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3275 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3277 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3278 so that it is not optimized away.
3280 * xdisp.c (compute_display_string_pos): Remove unused local.
3282 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3284 Fix slow cursor motion and scrolling in large buffers with
3285 selective display, like Org Mode buffers. (Bug#9218)
3287 * dispextern.h (struct bidi_it): New member disp_prop_p.
3289 * xdisp.c: Remove one-slot cache of display string positions.
3290 (compute_display_string_pos): Accept an additional argument
3291 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3292 for a display string or property. If found, set DISP_PROP_P
3295 * bidi.c (bidi_fetch_char): Accept an additional argument
3296 DISP_PROP_P, and pass it to compute_display_string_pos.
3297 Only handle text covered by a display string if DISP_PROP_P is returned
3298 non-zero. All callers of bidi_fetch_char changed.
3300 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3302 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3304 2010-12-03 Don March <don@ohspite.net>
3306 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3307 last character M-[char] is translated to ESC [char] (bug#7541).
3309 2011-08-02 Kenichi Handa <handa@m17n.org>
3311 * lisp.h (uniprop_table): Extern it.
3313 * chartab.c (uniprop_table): Make it non-static.
3315 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3317 * xdisp.c (forward_to_next_line_start): Accept additional argument
3318 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3320 (reseat_at_next_visible_line_start): Use the bidi iterator state
3321 returned by forward_to_next_line_start to restore the state of
3322 it->bidi_it after backing up to previous newline. (Bug#9212)
3324 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3326 * regex.c (re_comp): Protoize.
3327 (re_exec): Fix return type.
3328 (regexec): Fix type of `ret'. (Bug#9203)
3330 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3332 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3333 This is needed if max-image-size is a floating-point number.
3335 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3337 * print.c (print_object): Print empty symbol as ##.
3339 * lread.c (read1): Read ## as empty symbol.
3341 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3343 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3344 setting frame foreground color (Bug#9175).
3345 (x_set_background_color): Likewise.
3347 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3348 contents (Bug#9176).
3349 (EmacsTooltip -init): Remove bezels and add shadows to
3352 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3353 or scroll bar (Bug#8470).
3355 * nsfont.m (nsfont_open): Remove assignment to voffset and
3356 unnecessary vars hshink, expand, hd, full_height, min_height.
3357 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3359 * nsterm.h (nsfont_info): Remove voffset field.
3361 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3363 Implement strike-through and overline on NextStep (Bug#8863).
3365 * nsfont.m (nsfont_open): Use underline position provided by font,
3366 instead of hard-coded value of 2.
3367 (nsfont_draw): Call ns_draw_text_decoration instead.
3369 * nsterm.h: Add declaration for ns_draw_text_decoration.
3371 * nsterm.m (ns_draw_text_decoration): New function for drawing
3372 underline, overline, and strike-through.
3373 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3374 ns_draw_text_decoration. Change treatment of cursor drawing to
3375 accommodate underlining, etc.
3377 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3379 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3382 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3384 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3385 Without this fix, if a signal arrives just after memory fills up,
3386 'malloc' might be invoked reentrantly.
3388 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3389 In other words, assume that every image size is allowed, on non-X
3390 hosts. This assumption is probably wrong, but it lets Emacs compile.
3392 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3394 * regex.c (re_iswctype): Convert return values to boolean.
3396 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3398 * xdisp.c (compute_display_string_pos): Don't use cached display
3399 string position if the buffer had its restriction changed.
3402 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3404 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3406 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3408 Integer signedness and overflow and related fixes. (Bug#9079)
3410 * bidi.c: Integer size and overflow fixes.
3411 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3412 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3413 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3414 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3415 (bidi_find_other_level_edge):
3416 Use ptrdiff_t instead of EMACS_INT where either will do.
3417 This works better on 32-bit hosts configured --with-wide-int.
3418 (bidi_cache_ensure_space): Check for size-calculation overflow.
3419 Use % rather than repeated addition, for better worst-case speed.
3420 Don't set bidi_cache_size until after xrealloc returns, because it
3422 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3423 (bidi_cache_ensure_space): Also check that the bidi cache size
3424 does not exceed that of the largest Lisp string or buffer. See Eli
3425 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3427 * alloc.c (__malloc_size_t): Remove.
3428 All uses replaced by size_t. See Andreas Schwab's note
3429 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3431 * image.c: Improve checking for integer overflow.
3432 (check_image_size): Assume that f is nonnull, since
3433 it is always nonnull in practice. This is one less thing to
3434 worry about when checking for integer overflow later.
3435 (x_check_image_size): New function, which checks for integer
3436 overflow issues inside X.
3437 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3438 This removes the need for a memory_full check.
3439 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3440 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3441 (xbm_read_bitmap_data): Change locals back to 'int', since
3442 their values must fit in 'int'.
3443 (xpm_load_image, png_load, tiff_load):
3444 Invoke x_create_x_image_and_pixmap earlier,
3445 to avoid much needless work if the image is too large.
3446 (tiff_load): Treat overly large images as if
3447 x_create_x_image_and_pixmap failed, not as malloc failures.
3448 (gs_load): Use x_check_image_size.
3450 * gtkutil.c: Omit integer casts.
3451 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3452 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3454 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3456 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3457 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3458 would wrongly return t on a 64-bit host.
3460 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3461 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3462 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3463 and therefore cause GCC to emit a bogus diagnostic in some cases.
3465 * image.c: Integer signedness and overflow and related fixes.
3466 This is not an exhaustive set of fixes, but it's time to
3467 record what I've got.
3468 (lookup_pixel_color, check_image_size): Remove redundant decls.
3469 (check_image_size): Don't assume that arbitrary EMACS_INT values
3470 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3471 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3472 (tiff_load, imagemagick_load_image):
3473 Check for overflow in size calculations.
3474 (x_create_x_image_and_pixmap): Remove unnecessary test for
3475 xmalloc returning NULL; that can't happen.
3476 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3477 (xpm_color_bucket): Use better integer hashing function.
3478 (xpm_cache_color): Don't possibly over-allocate memory.
3479 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3480 (gif_memory_source):
3481 Use ptrdiff_t, not int or size_t, to record sizes.
3482 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3483 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3484 either works, as we prefer signed integers.
3485 (tiff_read_from_memory, tiff_write_from_memory):
3486 Return tsize_t, not size_t, since that's what the TIFF API wants.
3487 (tiff_read_from_memory): Don't fail simply because the read would
3488 go past EOF; instead, return a short read.
3489 (tiff_load): Omit no-longer-needed casts.
3490 (Fimagemagick_types): Don't assume size fits into 'int'.
3492 Improve hashing quality when configured --with-wide-int.
3493 * fns.c (hash_string): New function, taken from sxhash_string.
3494 Do not discard information about ASCII character case; this
3495 discarding is no longer needed.
3496 (sxhash-string): Use it. Change sig to match it. Caller changed.
3497 * lisp.h: Declare it.
3498 * lread.c (hash_string): Remove, since we now use fns.c's version.
3499 The fns.c version returns a wider integer if --with-wide-int is
3500 specified, so this should help the quality of the hashing a bit.
3502 * emacs.c: Integer overflow minor fix.
3503 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3504 Define only if GNU_LINUX.
3505 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3507 * dispnew.c: Integer signedness and overflow fixes.
3508 Remove unnecessary forward decls, that were a maintenance hassle.
3509 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3511 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3512 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3513 (prepare_desired_row, line_draw_cost):
3514 Use int, not unsigned, where either works.
3515 (save_current_matrix, restore_current_matrix):
3516 Use ptrdiff_t, not size_t, where either works.
3517 (init_display): Check for overflow more accurately, and without
3518 relying on undefined behavior.
3520 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3521 Remove, replacing with the new symbols in lisp.h. All uses changed.
3522 * fileio.c (make_temp_name):
3523 * filelock.c (lock_file_1, lock_file):
3524 * xdisp.c (message_dolog):
3525 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3526 Use pMd etc. instead.
3527 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3528 replacing the pWIDE etc. symbols removed from editfns.c.
3530 * keyboard.h (num_input_events): Now uintmax_t.
3531 This is (very slightly) less likely to mess up due to wraparound.
3534 * buffer.c: Integer signedness fixes.
3535 (alloc_buffer_text, enlarge_buffer_text):
3536 Use ptrdiff_t rather than size_t when either will do, as we prefer
3539 * alloc.c: Integer signedness and overflow fixes.
3540 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3541 (__malloc_size_t): Default to size_t, not to int.
3542 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3543 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3544 Prefer ptrdiff_t to size_t when either would do, as we prefer
3546 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3547 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3548 Now const. Initialize with values that are in range even if char
3550 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3551 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3552 These functions do the right thing with sizes > 2**32.
3553 (check_depth): Now ptrdiff_t, not int.
3554 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3555 Adjust to new way of storing sizes. Check for size overflow bugs
3557 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3558 slightly wrong anyway, as it missed one instance of
3559 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3560 (refill_memory_reserve): Omit needless cast to size_t.
3561 (mark_object_loop_halt): Mark as externally visible.
3563 * xselect.c: Integer signedness and overflow fixes.
3564 (Fx_register_dnd_atom, x_handle_dnd_message):
3565 Use ptrdiff_t, not size_t, since we prefer signed.
3566 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3567 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3568 x_dnd_atoms_size and x_dnd_atoms_length.
3570 * doprnt.c: Prefer signed to unsigned when either works.
3572 * doprnt.c (doprnt):
3574 * xdisp.c (vmessage):
3575 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3576 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3577 prefer signed arithmetic to avoid comparison confusion.
3578 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3579 but is a bit tricky.
3581 Assume freestanding C89 headers, string.h, stdlib.h.
3582 * data.c, doprnt.c, floatfns.c, print.c:
3583 Include float.h unconditionally.
3584 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3585 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3586 * regex.c: Likewise for stddef.h, string.h.
3587 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3588 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3589 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3590 (STDC_HEADERS): Remove obsolete defines.
3591 * sysdep.c: Include limits.h unconditionally.
3593 Assume support for memcmp, memcpy, memmove, memset.
3594 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3595 * regex.c (memcmp, memcpy):
3596 Remove; we assume C89 now.
3598 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3599 (__malloc_safe_bcopy): Remove; no longer needed.
3601 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3602 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3603 well either way, and we prefer signed to unsigned.
3605 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3607 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3608 closes the connection while we're reading (bug#9182).
3610 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3612 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3613 are specified (Bug#9168).
3615 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3617 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3618 Found by GCC static checking and --with-wide-int on a 32-bit host.
3620 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3622 * xdisp.c (compute_display_string_pos): Fix logic of caching
3623 previous display string position. Initialize cached_prev_pos to
3624 -1. Fixes slow-down at the beginning of a buffer.
3626 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3628 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3629 for attrs[LFACE_FONTSET_INDEX].
3631 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3633 * xml.c (parse_region): Remove unused local
3634 that was recently introduced.
3636 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3638 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3639 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3641 * xdisp.c (move_it_in_display_line_to): Record the best matching
3642 position for TO_CHARPOS while scanning the line, and restore it on
3643 exit if none of the characters scanned was an exact match.
3644 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3645 when exact match is impossible due to invisible text, and the
3646 lines are truncated.
3648 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3650 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3653 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3655 Fix a significant slow-down of cursor motion with C-n, C-p,
3656 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3657 auto-repeat under bidi redisplay in fontified buffers.
3658 * xdisp.c (compute_stop_pos_backwards): New function.
3659 (next_element_from_buffer): Call compute_stop_pos_backwards to
3660 find a suitable prev_stop when we find ourselves before
3662 (reseat): Don't look for prev_stop, as that could mean a very long
3664 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3665 <cached_disp_overlay_modiff>: Cache for last found display string
3667 (compute_display_string_pos): Return the cached position if asked
3668 about the same buffer in the same area of character positions, and
3669 the buffer wasn't changed since the time the display string
3670 position was cached.
3672 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3674 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3675 is an integer, which is important for empty lines. (Bug#9149)
3677 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3679 * frame.c (Fmodify_frame_parameters): In tty case, update the
3680 default face if necessary (Bug#4238).
3682 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3684 * editfns.c (Fstring_to_char): No need to explain what a character
3685 is in the docstring (Bug#6576).
3687 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3689 * xml.c (parse_region): Make sure we always return a tree.
3691 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3693 * xml.c (parse_region): If a document contains only comments,
3696 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3698 * xml.c (make_dom): Return comments, too.
3700 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3703 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3704 and the surrounding thread.
3705 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3706 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3707 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3709 * s/openbsd.h (BROKEN_SIGIO): Define.
3710 * unexelf.c (unexec) [__OpenBSD__]:
3711 Don't update the .mdebug section of the Alpha COFF symbol table.
3713 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3715 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3718 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3720 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3721 This fixes some race conditions on the permissions of any newly
3724 * alloc.c (valid_pointer_p): Use pipe, not open.
3725 This fixes some permissions issues when debugging.
3727 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3728 If fchown fails to set both uid and gid, try to set just gid,
3729 as that is sometimes allowed. Adjust the file's mode to eliminate
3730 setuid or setgid bits that are inappropriate if fchown fails.
3732 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3734 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3735 to compare Lisp_Objects.
3736 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3737 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3738 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3740 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3742 * lread.c (read_integer): Unread even EOF character.
3743 (read1): Likewise. Properly record start position of symbol.
3745 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3746 symbol character follows.
3748 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3750 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3751 This works around a problem with the previous change to Fcopy_file.
3752 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3753 and without this change, GCC might complain about discarding
3754 fchown's return value.
3756 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3758 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3760 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3762 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3764 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3766 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3767 it's used from the C level.
3769 * process.c: Use the same condition for POLL_FOR_INPUT in both
3770 keyboard.c and process.c (bug#1858).
3772 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3774 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3775 (Fgnutls_boot): Use it.
3777 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3779 * doc.c (Fsubstitute_command_keys): Revert last change.
3781 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3783 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3784 quotes the next character, and doesn't affect other longer
3785 sequences (bug#8935).
3787 * lread.c (syms_of_lread): Clarify that is isn't only
3788 `eval-buffer' and `eval-defun' that's affected by
3789 `lexical-binding' (bug#8460).
3791 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3793 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3794 bidi redisplay when a line includes both an image and is truncated.
3796 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3798 Fix minor problems found by static checking.
3799 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3800 (elsz): Now a signed constant, not a size_t var. We prefer signed
3801 types to unsigned, to avoid integer comparison confusion. Without
3802 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3803 "cannot optimize loop, the loop counter may overflow", a symptom
3805 * indent.c (Fvertical_motion): Mark locals as initialized.
3806 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3808 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3810 * search.c (Fre_search_backward): Mention `case-fold-search' in
3811 all the re_search_* functions (bug#8138).
3813 * keyboard.c (Fopen_dribble_file): Document when the file is
3816 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3818 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3821 Support bidi reordering of display and overlay strings.
3822 * xdisp.c (compute_display_string_pos)
3823 (compute_display_string_end): Accept additional argument STRING.
3824 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3825 (reseat_to_string): Initialize bidi_it->string.s and
3826 bidi_it->string.schars.
3827 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3828 NULL (avoids a crash in bidi_paragraph_init).
3829 Initialize itb.string.lstring.
3830 (init_iterator): Call bidi_init_it only of a valid
3831 buffer position was specified. Initialize paragraph_embedding to
3833 (reseat_to_string): Initialize the bidi iterator.
3834 (display_string): If we need to ignore text properties of
3835 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3836 original value of -1 will not work with bidi.)
3837 (compute_display_string_pos): First arg is now struct
3838 `text_pos *'; all callers changed. Support display properties on
3840 (compute_display_string_end): Support display properties on Lisp
3842 (init_iterator, reseat_1, reseat_to_string): Initialize the
3843 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3844 when iterating on a string not from display properties).
3845 (compute_display_string_pos, compute_display_string_end):
3846 Fix calculation of the object to scan. Fixes an error when using
3848 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3849 base_level_stop; instead, set base_level_stop to BEGV.
3850 Fixes crashes in vertical-motion.
3851 (next_element_from_buffer): Improve commentary for when
3852 the iterator is before prev_stop.
3853 (init_iterator): Initialize bidi_p from the default value of
3854 bidi-display-reordering, not from buffer-local value. Use the
3855 buffer-local value only if initializing for buffer iteration.
3856 (handle_invisible_prop): Support invisible properties on strings
3857 that are being bidi-reordered.
3858 (set_iterator_to_next): Support bidi reordering of C strings and
3860 (next_element_from_string): Support bidi reordering of Lisp
3862 (handle_stop_backwards): Support Lisp strings as well.
3863 (display_string): Support display of R2L glyph rows.
3864 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3865 (init_iterator): Don't initialize it->bidi_p for strings
3867 (reseat_to_string): Initialize it->bidi_p for strings here.
3868 (next_element_from_string, next_element_from_c_string)
3869 (next_element_from_buffer): Add xassert's for correspondence
3870 between IT's object being iterated and it->bidi_it.string
3872 (face_before_or_after_it_pos): Support bidi iteration.
3873 (next_element_from_c_string): Handle the case of the first string
3874 character that is not the first one in the visual order.
3875 (get_visually_first_element): New function, refactored from common
3876 parts of next_element_from_buffer, next_element_from_string, and
3877 next_element_from_c_string.
3878 (tool_bar_lines_needed, redisplay_tool_bar)
3879 (display_menu_bar): Force left-to-right direction. Add a FIXME
3880 comment for making that be controlled by a user option.
3881 (push_it, pop_it): Save and restore the state of the
3882 bidi iterator. Save and restore the bidi_p flag.
3883 (pop_it): Iterate out of display property for string iteration as
3885 (iterate_out_of_display_property): Support iteration over strings.
3886 (handle_single_display_spec): Set up it->bidi_it for iteration
3887 over a display string, and call bidi_init_it.
3888 (handle_single_display_spec, next_overlay_string)
3889 (get_overlay_strings_1, push_display_prop): Set up the bidi
3890 iterator for displaying display or overlay strings.
3891 (forward_to_next_line_start): Don't use the shortcut if
3893 (back_to_previous_visible_line_start): If handle_display_prop
3894 pushed the iterator stack, restore the internal state of the bidi
3895 iterator by calling bidi_pop_it same number of times.
3896 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3897 and we are bidi-iterating, don't decrement the iterator position;
3898 instead, set the first_elt flag in the bidi iterator, to produce
3900 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3901 (push_display_prop): xassert that we are iterating a buffer.
3902 (push_it, pop_it): Save and restore paragraph_embedding member.
3903 (handle_single_display_spec, next_overlay_string)
3904 (get_overlay_strings_1, reseat_1, reseat_to_string)
3905 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3906 correctly. Don't assume unibyte strings are not bidi-reordered.
3907 (compute_display_string_pos)
3908 (compute_display_string_end): Fix handling the case of C string.
3909 (push_it, pop_it): Save and restore from_disp_prop_p.
3910 (handle_single_display_spec, push_display_prop): Set the
3911 from_disp_prop_p flag.
3912 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3913 (pop_it): Call iterate_out_of_display_property only if we are
3914 popping after iteration over a string that came from a display
3915 property. Fix a typo in popping stretch info. Add an assertion
3916 for verifying that the iterator position is in sync with the bidi
3918 (handle_single_display_spec, get_overlay_strings_1)
3919 (push_display_prop): Fix initialization of paragraph direction for
3920 string when that of the parent object is not yet determined.
3921 (reseat_1): Call bidi_init_it to resync the bidi
3922 iterator with IT's position. (Bug#7616)
3923 (find_row_edges): If ROW->start.pos gives position
3924 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3925 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3926 Reset the from_disp_prop_p flag.
3927 (SAVE_IT, RESTORE_IT): New macros.
3928 (pos_visible_p, face_before_or_after_it_pos)
3929 (back_to_previous_visible_line_start)
3930 (move_it_in_display_line_to, move_it_in_display_line)
3931 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3932 (try_scrolling, redisplay_window, display_line): Use them when
3933 saving a temporary copy of the iterator and restoring it back.
3934 (back_to_previous_visible_line_start, reseat_1)
3935 (init_iterator): Empty the bidi cache "stack".
3936 (move_it_in_display_line_to): If iterator ended up at
3937 EOL, but we never saw any buffer positions smaller than
3938 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3939 motion in bidi-reordered lines.
3940 (move_it_in_display_line_to): Record prev_method and prev_pos
3941 immediately before the call to set_iterator_to_next. Fixes cursor
3942 motion in bidi-reordered lines with stretch glyphs and strings
3943 displayed in margins. (Bug#8133) (Bug#8867)
3944 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3946 (pos_visible_p): Support positions in bidi-reordered lines.
3947 Save and restore bidi cache.
3949 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3950 (bidi_paragraph_info): Delete unused struct.
3951 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3952 (bidi_cache_start): New variable.
3953 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3955 (bidi_cache_fetch_state, bidi_cache_search)
3956 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3957 (bidi_cache_find, bidi_peek_at_next_level)
3958 (bidi_level_of_next_char, bidi_find_other_level_edge)
3959 (bidi_move_to_visually_next): Compare cache index with
3960 bidi_cache_start rather than with zero.
3961 (bidi_fetch_char): Accept new argument STRING; all callers
3962 changed. Support iteration over a string. Support strings with
3963 display properties. Support unibyte strings. Fix the type of
3964 `len' according to what STRING_CHAR_AND_LENGTH expects.
3965 (bidi_paragraph_init, bidi_resolve_explicit_1)
3966 (bidi_resolve_explicit, bidi_resolve_weak)
3967 (bidi_level_of_next_char, bidi_move_to_visually_next):
3968 Support iteration over a string.
3969 (bidi_set_sor_type, bidi_resolve_explicit_1)
3970 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3971 can now be zero (for strings); special values 0 and -1 were
3972 changed to -1 and -2, respectively.
3973 (bidi_char_at_pos): New function.
3974 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3975 Call it instead of FETCH_MULTIBYTE_CHAR.
3976 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3977 initialized to valid values.
3978 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3980 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3981 the test for valid cached positions. Fix the logic for looking up
3982 the sentinel state in the cache. GCPRO the Lisp string we are
3984 (bidi_push_it, bidi_pop_it): New functions.
3985 (bidi_initialize): Initialize the bidi cache start stack pointer.
3986 (bidi_cache_ensure_space): New function, refactored from part of
3987 bidi_cache_iterator_state. Don't assume the required size is just
3988 one BIDI_CACHE_CHUNK away.
3989 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3990 (bidi_count_bytes, bidi_char_at_pos): New functions.
3991 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3992 always valid if bidi_cache_idx is valid.
3993 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3994 is valid if it's going to be used.
3995 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3996 (bidi_cache_fetch_state, bidi_cache_search)
3997 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3998 (bidi_cache_iterator_state, bidi_cache_find)
3999 (bidi_find_other_level_edge, bidi_cache_start_stack):
4000 All variables related to cache indices are now EMACS_INT.
4002 * dispextern.h (struct bidi_string_data): New structure.
4003 (struct bidi_it): New member `string'. Make flag members be 1-bit
4004 fields, and put them last in the struct.
4005 (compute_display_string_pos, compute_display_string_end):
4007 (bidi_push_it, bidi_pop_it): Add prototypes.
4008 (struct iterator_stack_entry): New members bidi_p,
4009 paragraph_embedding, and from_disp_prop_p.
4010 (struct it): Member bidi_p is now a bit field 1 bit wide.
4011 (bidi_shelve_cache, bidi_unshelve_cache):
4014 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4015 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4016 and vector-like objects.
4018 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4019 cache around display iteration.
4021 * window.c (Fwindow_end, window_scroll_pixel_based)
4022 (displayed_window_lines, Frecenter): Save and restore the bidi
4023 cache around display iteration.
4025 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4027 * editfns.c (Fdelete_region): Clarify the use of the named
4028 parameters (bug#6788).
4030 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4032 * indent.c (Fvertical_motion): Set and restore w->pointm when
4033 saving and restoring the window's buffer (Bug#9006).
4035 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4037 * editfns.c (Fstring_to_char): Clarify just what is returned
4038 (bug#6576). Text by Eli Zaretskii.
4040 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4042 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4044 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4046 * buffer.c (mmap_find): Fix a typo.
4048 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4050 Fix execution of x selection hooks.
4051 * xselect.c (Qx_lost_selection_functions)
4052 (Qx_sent_selection_functions): New vars.
4053 (syms_of_xselect): DEFSYM them.
4054 (x_handle_selection_request): Pass Qx_sent_selection_functions
4055 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4056 (x_handle_selection_clear,x_clear_frame_selections):
4057 Pass Qx_lost_selection_functions rather than
4058 Vx_lost_selection_functions to Frun_hook_with_args.
4060 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4062 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4063 The old code sometimes used this field without initializing it.
4065 * alloc.c (gc_sweep): Don't read past end of array.
4066 In theory, the old code could also have corrupted Emacs internals,
4067 though it'd be very unlikely.
4069 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4071 * character.c (Fcharacterp): Don't advertise optional ignored
4072 argument. (Bug#4026)
4074 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4076 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4079 * window.c (Fset_window_start): Doc fix (bug#4199).
4080 (Fset_window_hscroll): Ditto.
4082 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4084 Fix minor new problems caught by GCC 4.6.1.
4085 * term.c (init_tty): Remove unused local.
4086 * xsettings.c (store_monospaced_changed): Define this function only
4087 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4090 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4092 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4094 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4096 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4097 are the mini-buffer and the echo area (bug#3320).
4099 * term.c (init_tty): Remove support for supdup, c10 and perq
4100 terminals, which are no longer supported (bug#1482).
4102 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4104 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4106 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4108 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4109 for non-popups (Bug#3642).
4111 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4113 * alloc.c (reset_malloc_hooks): Protoize.
4114 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4115 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4116 * cm.c (losecursor): Likewise.
4117 * data.c (fmod): Likewise.
4118 * dispnew.c (swap_glyphs_in_rows): Likewise.
4119 * emacs.c (memory_warning_signal): Likewise.
4120 * floatfns.c (float_error): Likewise.
4121 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4122 (otf_open, font_otf_capability, generate_otf_features)
4123 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4125 * image.c (pbm_read_file): Likewise.
4126 * indent.c (string_display_width): Likewise.
4127 * intervals.c (check_for_interval, search_for_interval)
4128 (inc_interval_count, count_intervals, root_interval)
4129 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4130 * lread.c (defalias): Likewise.
4131 * ralloc.c (r_alloc_check): Likewise.
4132 * regex.c (set_image_of_range_1, set_image_of_range)
4133 (regex_grow_registers): Likewise.
4134 * sysdep.c (strerror): Likewise.
4135 * termcap.c (valid_filename_p, tprint, main): Likewise.
4136 * tparam.c (main): Likewise.
4137 * unexhp9k800.c (run_time_remap, save_data_space)
4138 (update_file_ptrs, read_header, write_header, calculate_checksum)
4139 (copy_file, copy_rest, display_header): Likewise.
4140 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4142 * xdisp.c (check_it): Likewise.
4143 * xfaces.c (register_color, unregister_color, unregister_colors):
4145 * xfns.c (print_fontset_result): Likewise.
4146 * xrdb.c (member, fatal, main): Likewise.
4148 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4150 Fix minor problems found by static checking (Bug#9031).
4151 * chartab.c (char_table_set_range, map_sub_char_table):
4152 Remove unused locals.
4153 (uniprop_table): Now static.
4154 * composite.c (_work_char): Remove unused static var.
4156 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4158 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4160 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4162 * gtkutil.c (qttip_cb): Remove code without function.
4164 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4166 * w32.c (pthread_sigmask): New stub.
4168 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4170 Use pthread_sigmask, not sigprocmask (Bug#9010).
4171 sigprocmask is portable only for single-threaded applications, and
4172 Emacs can be multi-threaded when it uses GTK.
4173 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4175 * callproc.c (Fcall_process):
4176 * process.c (create_process):
4177 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4178 Use pthread_sigmask, not sigprocmask.
4180 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4182 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4183 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4186 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4188 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4189 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4190 (xg_hide_tooltip): Fix comment.
4192 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4193 in registerServicesMenuSendTypes.
4194 (validRequestorForSendType): Don't check ns_return_types.
4196 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4199 2011-07-08 Jason Rumney <jasonr@gnu.org>
4201 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4202 SH_SHOW for hidden windows (Bug#5482).
4204 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4205 frame struct members of non-existent frames (Bug#6284).
4207 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4209 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4210 variable firstTime not needed on OSX >= 10.6.
4211 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4212 >= 10.5. Use setKnobProportion, setDoubleValue.
4214 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4215 (MAC_OS_X_VERSION_10_5): Define if not defined.
4216 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4217 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4218 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4220 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4221 cString and lossyCString on OSX >= 10.4
4223 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4224 sizeToFit on OSX >= 10.2.
4226 * nsimage.m (allocInitFromFile): Don't use deprecated method
4227 bestRepresentationForDevice on OSX >= 10.6.
4229 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4232 * emacs.c: Declare unexec_init_emacs_zone.
4234 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4236 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4238 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4239 on svcsMenu (Bug#8842).
4241 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4243 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4245 * nsterm.m (QUTF8_STRING): Declare.
4246 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4247 (validRequestorForSendType): Return type is (id).
4248 Change indexOfObjectIdenticalTo to indexOfObject.
4249 Check if we have local selection before returning self (Bug#8842).
4250 (writeSelectionToPasteboard): Put local selection into paste board
4251 if we have a local selection (Bug#8842).
4252 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4254 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4255 (ns_get_local_selection): Declare.
4257 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4259 * keymap.c (describe_map_tree): Don't insert a double newline at
4260 the end of the buffer (bug#1169) and return whether we inserted
4263 * callint.c (Fcall_interactively): Change "reading args" to
4264 "providing args" to try to clarify what it does (bug#1010).
4266 2011-07-07 Kenichi Handa <handa@m17n.org>
4268 * composite.c (composition_compute_stop_pos): Ignore a static
4269 composition starting before CHARPOS (Bug#8915).
4271 * xdisp.c (handle_composition_prop): Likewise.
4273 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4275 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4278 2011-07-07 Kenichi Handa <handa@m17n.org>
4280 * character.h (unicode_category_t): New enum type.
4282 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4283 (Qchar_code_property_table): New variable.
4284 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4285 (UNIPROP_COMPRESSED_FORM_P): New macros.
4286 (char_table_ascii): Uncompress the compressed values.
4287 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4288 Uncompress the compressed values.
4289 (sub_char_table_ref_and_range): Likewise.
4290 (char_table_ref_and_range): Uncompress the compressed values.
4291 (sub_char_table_set): New arg is_uniprop. Callers changed.
4292 Uncompress the compressed values.
4293 (sub_char_table_set_range): Args changed. Callers changed.
4294 (char_table_set_range): Adjuted for the above change.
4295 (map_sub_char_table): Delete args default_val and parent. Add arg
4296 top. Give decoded values to a Lisp function.
4297 (map_char_table): Adjust for the above change. Give decoded
4298 values to a Lisp function. Gcpro more variables.
4299 (uniprop_table_uncompress)
4300 (uniprop_decode_value_run_length): New functions.
4301 (uniprop_decoder, uniprop_decoder_count): New variables.
4302 (uniprop_get_decoder, uniprop_encode_value_character)
4303 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4305 (uniprop_encoder, uniprop_encoder_count): New variables.
4306 (uniprop_get_encoder, uniprop_table)
4307 (Funicode_property_table_internal, Fget_unicode_property_internal)
4308 (Fput_unicode_property_internal): New functions.
4309 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4310 Sunicode_property_table_internal, Sget_unicode_property_internal,
4311 and Sput_unicode_property_internal. Defvar_lisp
4312 char-code-property-alist.
4314 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4315 Vunicode_category_table.
4317 * font.c (font_range): Adjust for the change of
4318 Vunicode_category_table.
4320 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4322 * m/iris4d.h: Remove file, move contents ...
4323 * s/irix6-5.h: ... here.
4325 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4327 Remove unportable assumption about struct layout (Bug#8884).
4328 * alloc.c (mark_buffer):
4329 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4330 (clone_per_buffer_values): Don't assume that
4331 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4332 This isn't true in general, and it's particularly not true
4333 if Emacs is configured with --with-wide-int.
4334 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4335 New macros, used in the buffer.c change.
4337 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4339 * xsettings.c: Use both GConf and GSettings if both are available.
4340 (store_config_changed_event): Add comment.
4341 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4342 (store_tool_bar_style_changed): New functions.
4343 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4344 (struct xsettings): Move font inside HAVE_XFT.
4345 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4346 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4347 Move inside HAVE_XFT.
4348 (something_changed_gsettingsCB): Rename from something_changedCB.
4349 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4351 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4352 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4353 (something_changed_gconfCB): Rename from something_changedCB.
4354 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4355 (parse_settings): Move check for font inside HAVE_XFT.
4356 (read_settings, apply_xft_settings): Add comment.
4357 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4358 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4359 call store_font_name_changed.
4360 (xft_settings_event): Add comment.
4361 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4362 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4363 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4364 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4365 (xsettings_initialize): Call init_gsettings last.
4366 (xsettings_get_system_font, xsettings_get_system_normal_font):
4369 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4371 Random fixes. E.g., (random) never returned negative values.
4372 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4373 subseconds part to the entropy, as that's a bit more random.
4374 Prefer signed to unsigned, since the signedness doesn't matter and
4375 in general we prefer signed. When given a limit, use a
4376 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4377 latter isn't right if USE_2_TAGS_FOR_INTS.
4378 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4379 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4381 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4383 * textprop.c (text_property_stickiness):
4384 Obey Vtext_property_default_nonsticky.
4385 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4386 * w32fns.c (syms_of_w32fns):
4387 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4389 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4391 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4392 This is more efficient than Ffile_directory_p and avoids a minor race.
4394 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4396 * buffer.c (Foverlay_put): Say what the return value is
4399 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4400 is a directory before asking whether to use the file name
4402 (barf_or_query_if_file_exists): Make the "File is a directory"
4403 error be more correct.
4405 * fns.c (Frequire): Remove the mention of the .gz files, since
4406 that's installation-specific, but keep the mention of
4407 `get-load-suffixes'.
4409 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4411 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4412 Report string overflow if the output is too long.
4414 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4416 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4417 (syms_of_gnutls): Remove duplicate DEFSYM for
4418 Qgnutls_bootprop_verify_hostname_error, an error for
4419 Qgnutls_bootprop_verify_error (which is no longer used).
4421 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4422 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4423 Also (re)move comments that are misplaced or no longer relevant.
4425 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4427 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4429 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4431 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4432 and background color parameters if they have been changed.
4434 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4436 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4438 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4440 * xsettings.c (SYSTEM_FONT): Define only when used.
4441 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4443 * keymap.c (access_keymap_1): Now static.
4445 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4447 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4448 leave any prefix arg for the up event (Bug#1586).
4450 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4452 * lread.c (syms_of_lread): Mention single symbols defined by
4453 `defvar' or `defconst' (bug#7154).
4455 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4456 (Frequire): Mention get-load-suffixes.
4458 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4460 * window.h (window): Remove clone_number slot.
4461 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4463 (make_parent_window, make_window, saved_window)
4464 (Fset_window_configuration, save_window_save): Don't deal with
4466 * buffer.c (Qclone_number): Remove declaration.
4467 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4469 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4471 Add multiple inheritance to keymaps.
4472 * keymap.c (Fmake_composed_keymap): New function.
4473 (Fset_keymap_parent): Simplify.
4474 (fix_submap_inheritance): Remove.
4475 (access_keymap_1): New function extracted from access_keymap to handle
4476 embedded parents and handle lists of maps.
4477 (access_keymap): Use it.
4478 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4479 (Fcopy_keymap): Handle embedded parents.
4480 (Fcommand_remapping, define_as_prefix): Simplify.
4481 (Fkey_binding): Simplify.
4482 (syms_of_keymap): Move minibuffer-local-completion-map,
4483 minibuffer-local-filename-completion-map,
4484 minibuffer-local-must-match-map, and
4485 minibuffer-local-filename-must-match-map to Elisp.
4486 (syms_of_keymap): Defsubr make-composed-keymap.
4487 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4488 (parse_menu_item): Trivial simplification.
4490 2011-07-01 Glenn Morris <rgm@gnu.org>
4492 * Makefile.in (SETTINGS_LIBS): Fix typo.
4494 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4496 * coding.c (Fencode_coding_string): Record the last coding system
4497 used, as the function doc string says (bug#8738).
4499 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4501 * xsettings.c (store_monospaced_changed): Take new font as arg and
4502 check for change against current_mono_font.
4503 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4504 (emacs_settings_constructor, emacs_settings_get_property)
4505 (emacs_settings_set_property, emacs_settings_class_init)
4506 (emacs_settings_init, gsettings_obj): Remove.
4507 (something_changedCB): New function for HAVE_GSETTINGS.
4508 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4509 with value as argument.
4510 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4511 g_settings_new (Bug#8967). Do not create gsettings_obj.
4512 Remove calls to g_settings_bind. Connect something_changedCB to
4515 * xgselect.c: Add defined (HAVE_GSETTINGS).
4516 (xgselect_initialize): Ditto.
4518 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4519 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4522 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4524 * eval.c (struct backtrace): Simplify and port the data structure.
4525 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4526 signed bit field, as this assumption is not portable and it makes
4527 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4528 "char debug_on_exit : 1" as this is not portable either; instead,
4529 use the portable "unsigned int debug_on_exit : 1". Remove unused
4530 member evalargs. Remove obsolete comments about cc bombing out.
4532 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4534 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4535 Let HAVE_GSETTINGS override HAVE_GCONF.
4536 (store_monospaced_changed): New function.
4537 (EMACS_SETTINGS): A new type derived from GObject to handle
4538 GSettings notifications.
4539 (emacs_settings_constructor, emacs_settings_get_property)
4540 (emacs_settings_set_property, emacs_settings_class_init):
4542 (gsettings_client, gsettings_obj): New variables.
4543 (GSETTINGS_SCHEMA): New define.
4544 (something_changedCB): Call store_monospaced_changed.
4545 (init_gsettings): New function.
4546 (xsettings_initialize): Call init_gsettings.
4547 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4550 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4553 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4555 * window.c (resize_root_window, grow_mini_window)
4556 (shrink_mini_window): Rename Qresize_root_window to
4557 Qwindow_resize_root_window and Qresize_root_window_vertically to
4558 Qwindow_resize_root_window_vertically.
4560 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4562 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4564 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4566 * makefile.w32-in: Redesign dependencies so they reflect more
4567 clearly which files are directly included by each source file,
4568 and not through other includes.
4570 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4572 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4573 (sort_overlays, overlay_strings): When an overlay's clone number
4574 matches the window's clone number process the overlay even if
4575 the overlay's window property doesn't match the current window.
4577 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4578 (Fwindow_hchild): Rename to Fwindow_left_child.
4579 (Fwindow_next): Rename to Fwindow_next_sibling.
4580 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4581 (resize_window_check): Rename to window_resize_check.
4582 (resize_window_apply): Rename to window_resize_apply.
4583 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4584 (Fdelete_other_windows_internal, resize_frame_windows)
4585 (Fsplit_window_internal, Fdelete_window_internal)
4586 (grow_mini_window, shrink_mini_window)
4587 (Fresize_mini_window_internal): Fix callers accordingly.
4589 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4591 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4592 (emacs_fixed_set_min_size): Remove.
4593 (emacs_fixed_new): Take frame as argument.
4595 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4596 (_EmacsFixedPrivate): Remove minwidth/height.
4597 Add struct frame *f.
4598 (emacs_fixed_init): Initialize priv->f.
4599 (get_parent_class, emacs_fixed_set_min_size): Remove.
4600 (emacs_fixed_new): Set priv->f to argument.
4601 (emacs_fixed_get_preferred_width)
4602 (emacs_fixed_get_preferred_height): Use min_width/height from
4603 frames size_hint to set minimum and natural (Bug#8919).
4604 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4605 and use min_width/height from frames size_hint to set
4606 min_width/height (Bug#8919).
4608 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4609 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4612 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4614 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4615 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4618 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4620 * process.c (wait_reading_process_output): Bypass select if
4621 waiting for a cell while ignoring keyboard input, and input is
4622 pending. Suggested by Jan Djärv (Bug#8869).
4624 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4626 Use gnulib's dup2 module instead of rolling our own.
4627 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4629 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4631 * dispnew.c (scrolling_window): Before scrolling, turn off a
4632 mouse-highlight in the window being scrolled.
4634 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4636 Move DEFSYM to lisp.h and use everywhere.
4638 * character.h (DEFSYM): Move declaration...
4639 * lisp.h (DEFSYM): ...here.
4645 * w32select.c: Don't include character.h.
4647 * alloc.c (syms_of_alloc):
4648 * buffer.c (syms_of_buffer):
4649 * bytecode.c (syms_of_bytecode):
4650 * callint.c (syms_of_callint):
4651 * casefiddle.c (syms_of_casefiddle):
4652 * casetab.c (init_casetab_once):
4653 * category.c (init_category_once, syms_of_category):
4654 * ccl.c (syms_of_ccl):
4655 * cmds.c (syms_of_cmds):
4656 * composite.c (syms_of_composite):
4657 * dbusbind.c (syms_of_dbusbind):
4658 * dired.c (syms_of_dired):
4659 * dispnew.c (syms_of_display):
4660 * doc.c (syms_of_doc):
4661 * editfns.c (syms_of_editfns):
4662 * emacs.c (syms_of_emacs):
4663 * eval.c (syms_of_eval):
4664 * fileio.c (syms_of_fileio):
4665 * fns.c (syms_of_fns):
4666 * frame.c (syms_of_frame):
4667 * fringe.c (syms_of_fringe):
4668 * insdel.c (syms_of_insdel):
4669 * keymap.c (syms_of_keymap):
4670 * lread.c (init_obarray, syms_of_lread):
4671 * macros.c (syms_of_macros):
4672 * msdos.c (syms_of_msdos):
4673 * print.c (syms_of_print):
4674 * process.c (syms_of_process):
4675 * search.c (syms_of_search):
4676 * sound.c (syms_of_sound):
4677 * syntax.c (init_syntax_once, syms_of_syntax):
4678 * terminal.c (syms_of_terminal):
4679 * textprop.c (syms_of_textprop):
4680 * undo.c (syms_of_undo):
4681 * w32.c (globals_of_w32):
4682 * window.c (syms_of_window):
4683 * xdisp.c (syms_of_xdisp):
4684 * xfaces.c (syms_of_xfaces):
4685 * xfns.c (syms_of_xfns):
4686 * xmenu.c (syms_of_xmenu):
4687 * xsettings.c (syms_of_xsettings):
4688 * xterm.c (syms_of_xterm): Use DEFSYM.
4690 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4692 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4694 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4696 Integer and buffer overflow fixes (Bug#8873).
4698 * print.c (printchar, strout): Check for string overflow.
4699 (PRINTPREPARE, printchar, strout):
4700 Don't set size unless allocation succeeds.
4702 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4703 for sizes. Check for string overflow more accurately.
4704 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4706 * macros.c: Integer and buffer overflow fixes.
4707 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4708 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4709 Use ptrdiff_t, not int, for sizes.
4710 Don't increment bufsize until after realloc succeeds.
4711 Check for size-calculation overflow.
4712 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4714 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4716 * lread.c: Integer overflow fixes.
4717 (read_integer): Radix is now EMACS_INT, not int,
4718 to improve quality of diagnostics for out-of-range radices.
4719 Calculate buffer size correctly for out-of-range radices.
4720 (read1): Check for integer overflow in radices, and in
4721 read-circle numbers.
4722 (read_escape): Avoid int overflow.
4723 (Fload, openp, read_buffer_size, read1)
4724 (substitute_object_recurse, read_vector, read_list, map_obarray):
4725 Use ptrdiff_t, not int, for sizes.
4726 (read1): Use EMACS_INT, not int, for sizes.
4727 Check for size overflow.
4729 * image.c (cache_image): Check for size arithmetic overflow.
4731 * lread.c: Integer overflow issues.
4732 (saved_doc_string_size, saved_doc_string_length)
4733 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4734 Now ptrdiff_t, not int.
4735 (read1): Don't assume doc string length fits in int. Check for
4736 out-of-range doc string lengths.
4737 (read_list): Don't assume file position fits in int.
4738 (read_escape): Check for hex character overflow.
4740 2011-06-22 Leo Liu <sdl.web@gmail.com>
4742 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4743 Move to minibuffer.el.
4745 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4747 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4748 The following patches are for when GLYPH_DEBUG && !XASSERT.
4749 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4750 * dispnew.c (flush_stdout):
4751 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4752 Mark as externally visible.
4753 * dispnew.c (check_window_matrix_pointers): Now static.
4754 * dispnew.c (window_to_frame_vpos):
4755 * xfns.c (unwind_create_frame):
4756 * xterm.c (x_check_font): Remove unused local.
4757 * scroll.c (CHECK_BOUNDS):
4758 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4759 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4760 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4761 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4762 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4764 (debug_method_add): Use va_list and vsprintf rather than relying
4765 on undefined behavior with wrong number of arguments.
4766 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4767 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4768 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4769 since we're not interested in debugging glyphs with old libraries.
4770 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4771 GCC 4.6.0's static checking.
4773 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4775 Integer overflow and signedness fixes (Bug#8873).
4776 A few related buffer overrun fixes, too.
4778 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4780 * dispextern.h (struct face.stipple):
4781 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4782 (x_bitmap_mask, x_allocate_bitmap_record)
4783 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4784 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4785 (x_create_bitmap_from_xpm_data):
4786 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4787 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4789 * xfaces.c (load_pixmap):
4790 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4791 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4792 (.bitmaps_last, struct x_output.icon_bitmap):
4793 Use ptrdiff_t, not int, for bitmap indexes.
4794 (x_allocate_bitmap_record): Check for size overflow.
4795 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4797 Use ptrdiff_t, not int, for overlay counts.
4798 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4799 * editfns.c (overlays_around, get_pos_property):
4800 * textprop.c (get_char_property_and_overlay):
4801 * xdisp.c (next_overlay_change, note_mouse_highlight):
4802 * xfaces.c (face_at_buffer_position):
4803 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4804 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4805 (Fnext_overlay_change, Fprevious_overlay_change)
4806 (mouse_face_overlay_overlaps, Foverlays_in):
4807 Use ptrdiff_t, not int, for sizes.
4808 (overlays_at, overlays_in): Check for size-calculation overflow.
4810 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4812 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4813 (x_session_initialize): Do not assume string length fits in int.
4815 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4816 This is unlikely, but can occur if DPI is outlandish.
4818 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4819 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4821 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4822 * xrdb.c (magic_file_p, search_magic_path):
4823 Omit last arg SUFFIX; it was always 0. All callers changed.
4824 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4826 * xfont.c (xfont_match): Avoid need for strlen.
4828 * xfns.c: Don't assume strlen fits in int.
4829 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4831 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4832 not unsigned long, as we prefer signed integers. All callers changed.
4833 Detect integer overflow in repeat count.
4834 (message_dolog): Don't assume print length fits in 39 bytes.
4835 (display_mode_element): Don't assume strlen fits in int.
4837 * termcap.c: Don't assume sizes fit in int and never overflow.
4838 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4839 (gobble_line): Check for size-calculation overflow.
4841 * minibuf.c (Fread_buffer):
4842 * lread.c (intern, intern_c_string):
4843 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4844 Don't assume string length fits in int.
4846 * keyboard.c (parse_tool_bar_item):
4847 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4849 * font.c: Don't assume string length fits in int.
4850 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4851 Use ptrdiff_t, not int.
4852 (font_intern_prop): Don't assume string length fits in int.
4853 Don't assume integer property fits in fixnum.
4854 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4856 * filelock.c: Fix some buffer overrun and integer overflow issues.
4857 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4858 Reformulate so as not to need the command string.
4859 Invoke gzip -cd rather than gunzip, as it's more portable.
4860 (lock_info_type, lock_file_1, lock_file):
4861 Don't assume pid_t and time_t fit in unsigned long.
4862 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4863 (current_lock_owner): Prefer signed type for sizes.
4864 Use memcpy, not strncpy, where memcpy is what is really wanted.
4865 Don't assume (via atoi) that time_t and pid_t fit in int.
4866 Check for time_t and/or pid_t out of range, e.g., via a network share.
4867 Don't alloca where an auto var works fine.
4869 * fileio.c: Fix some integer overflow issues.
4870 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4871 Don't assume string length fits in int.
4872 (directory_file_name): Don't assume string length fits in long.
4873 (make_temp_name): Don't assume pid fits in int, or that its print
4874 length is less than 20.
4876 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4878 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4880 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4882 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4883 We prefer signed integers, even for size calculations.
4885 * emacs.c: Don't assume string length fits in 'int'.
4886 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4887 (main): Don't invoke strlen when not needed.
4889 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4890 (XD_DEBUG_MESSAGE): Don't waste a byte.
4892 * callproc.c (getenv_internal_1, getenv_internal)
4894 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4896 * lread.c (invalid_syntax): Omit length argument.
4897 All uses changed. This doesn't fix a bug, but it simplifies the
4898 code away from its former Hollerith-constant appearance, and it's
4899 one less 'int' to worry about when looking at integer-overflow issues.
4900 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4902 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4903 This didn't break anything, but it didn't help either.
4904 It's confusing to put a bogus integer in a place where the actual
4905 value does not matter.
4906 (LIST_END_P): Remove unused macro and its bogus comment.
4907 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4909 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4910 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4912 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4913 We prefer signed types, and the value cannot exceed the EMACS_INT
4914 range anyway (because otherwise the length would not be representable).
4915 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4916 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4917 This avoids a GCC warning when WIDE_EMACS_INT.
4919 * indent.c (sane_tab_width): New function.
4920 (current_column, scan_for_column, Findent_to, position_indentation)
4921 (compute_motion): Use it. This is just for clarity.
4922 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4924 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4926 * lisp.h (lint_assume): New macro.
4927 * composite.c (composition_gstring_put_cache):
4928 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4930 * editfns.c, insdel.c:
4931 Omit unnecessary forward decls, to simplify future changes.
4933 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4935 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4937 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4938 Use much-faster test for byte-length change.
4939 Don't assume string byte-length fits in 'int'.
4940 Check that character arg fits in 'int'.
4941 (mapcar1): Declare byte as byte, for clarity.
4943 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4945 * fns.c (concat): Catch string overflow earlier.
4946 Do not rely on integer wraparound.
4948 * dispextern.h (struct it.overlay_strings_charpos)
4949 (struct it.selective): Now EMACS_INT, not int.
4950 * xdisp.c (forward_to_next_line_start)
4951 (back_to_previous_visible_line_start)
4952 (reseat_at_next_visible_line_start, next_element_from_buffer):
4953 Don't arbitrarily truncate the value of 'selective' to int.
4955 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4957 * composite.c: Don't truncate sizes to 'int'.
4958 (composition_gstring_p, composition_reseat_it)
4959 (composition_adjust_point): Use EMACS_INT, not int.
4960 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4961 not EMACS_UINT, for indexes.
4963 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4965 * buffer.c: Include <verify.h>.
4966 (struct sortvec.priority, struct sortstr.priority):
4967 Now EMACS_INT, not int.
4968 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4969 (struct sortstr.size, record_overlay_string)
4970 (struct sortstrlist.size, struct sortlist.used):
4971 Don't truncate size to int.
4972 (record_overlay_string): Check for size-calculation overflow.
4973 (init_buffer_once): Check at compile-time, not run-time.
4975 2011-06-22 Jim Meyering <meyering@redhat.com>
4977 Don't leak an XBM-image-sized buffer
4978 * image.c (xbm_load): Free the image buffer after using it.
4980 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4983 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4984 that Sun C diagnosed.
4985 * fns.c (secure_hash): Fix pointer signedness issue.
4986 * intervals.c (static_offset_intervals): New function.
4987 (offset_intervals): Use it.
4989 2011-06-21 Leo Liu <sdl.web@gmail.com>
4992 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4995 * fns.c (secure_hash): Rename from crypto_hash_function and change
4996 the first arg to accept symbols.
4997 (Fsecure_hash): New primitive.
4998 (syms_of_fns): New symbols.
5000 2011-06-20 Deniz Dogan <deniz@dogan.se>
5002 * process.c (Fset_process_buffer): Clarify return value in
5005 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5007 * dispnew.c (add_window_display_history): Use BVAR.
5009 * xdisp.c (debug_method_add): Use BVAR.
5010 (check_window_end, dump_glyph_matrix, dump_glyph)
5011 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5013 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5016 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5017 check till after the cache is created in init_frame_faces.
5019 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5021 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5023 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5025 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5026 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5027 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5029 Improve buffer-overflow checking (Bug#8873).
5030 * fileio.c (Finsert_file_contents):
5031 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5032 Remove the old (too-loose) buffer overflow checks.
5033 They weren't needed, since make_gap checks for buffer overflow.
5034 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5035 The old code merely checked for Emacs fixnum overflow, and relied
5036 on undefined (wraparound) behavior. The new code avoids undefined
5037 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5039 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5040 Tune. Don't use wider integers than needed. Don't use alloca.
5041 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5043 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5045 * insdel.c, lisp.h (buffer_overflow): New function.
5046 (insert_from_buffer_1, replace_range, replace_range_2):
5047 * insdel.c (make_gap_larger):
5048 * editfns.c (Finsert_char):
5049 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5051 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5053 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5055 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5057 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5058 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5060 * fileio.c: Don't assume EMACS_INT fits in off_t.
5061 (emacs_lseek): New static function.
5062 (Finsert_file_contents, Fwrite_region): Use it.
5063 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5065 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5067 * fns.c: Don't overflow int when computing a list length.
5068 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5069 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5070 truncation on 64-bit hosts. Check for QUIT every
5071 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5072 faster and is responsive enough.
5073 (Flength): Report an error instead of overflowing an integer.
5074 (Fsafe_length): Return a float if the value is not representable
5075 as a fixnum. This shouldn't happen except in contrived situations.
5076 (Fnthcdr, Fsort): Don't assume list length fits in int.
5077 (Fcopy_sequence): Don't assume vector length fits in int.
5079 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5080 (header_size, word_size): New constants.
5081 (allocate_vectorlike): Don't check size overflow here.
5082 (allocate_vector): Check it here instead, since this is the only
5083 caller of allocate_vectorlike that could cause overflow.
5084 Check that the new vector's length is representable as a fixnum.
5086 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5087 The previous code was bogus. For example, next_almost_prime (32)
5088 returned 39, which is undesirable as it is a multiple of 3; and
5089 next_almost_prime (24) returned 25, which is a multiple of 5 so
5090 why was the code bothering to check for multiples of 7?
5092 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5094 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5096 Variadic C functions now count arguments with ptrdiff_t.
5097 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5098 Back then I didn't know that the Emacs coding style prefers signed int.
5099 Also, in the meantime I found a few more instances where arguments
5100 were being counted with int, which may truncate counts on 64-bit
5101 machines, or EMACS_INT, which may be unnecessarily wide.
5102 * lisp.h (struct Lisp_Subr.function.aMANY)
5103 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5104 Arg counts are now ptrdiff_t, not size_t.
5105 All variadic functions and their callers changed accordingly.
5106 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5107 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5108 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5109 * callint.c (Fcall_interactively): Check arg count for overflow,
5110 to avoid potential buffer overrun. Use signed char, not 'int',
5111 for 'varies' array, so that we needn't bother to check its size
5112 calculation for overflow.
5113 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5114 * eval.c (apply_lambda):
5115 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5116 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5117 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5119 * callint.c (Fcall_interactively): Don't use index var as event count.
5121 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5122 * mem-limits.h (SIZE): Remove; no longer used.
5124 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5126 Remove unnecessary casts.
5127 * xterm.c (x_term_init):
5128 * xfns.c (x_set_border_pixel):
5129 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5130 These aren't needed now that we assume ANSI C.
5132 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5133 It's more likely to cause problems (due to unsigned overflow)
5136 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5138 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5140 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5142 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5144 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5146 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5148 GLYPH_CODE_FACE returns EMACS_INT, not int.
5149 * dispextern.h (merge_faces):
5150 * xfaces.c (merge_faces):
5151 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5152 Don't assume EMACS_INT fits in int.
5154 * character.h (CHAR_VALID_P): Remove unused parameter.
5155 * fontset.c, lisp.h, xdisp.c: All uses changed.
5157 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5159 * fns.c (concat): Minor tuning based on overflow analysis.
5160 This doesn't fix any bugs. Use int to hold character, instead
5161 of constantly refetching from Emacs object. Use XFASTINT, not
5162 XINT, for value known to be a character. Don't bother comparing
5163 a single byte to 0400, as it's always less.
5165 * floatfns.c (Fexpt):
5166 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5168 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5171 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5173 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5174 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5175 incorrectly succeed when S was a string, because 4294967386 was
5176 truncated before it was used.
5178 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5179 Otherwise, an out-of-range integer could cause undefined behavior
5182 * composite.c: Use int, not EMACS_INT, for characters.
5183 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5184 EMACS_INT, for values that are known to be in character range.
5185 This doesn't fix any bugs but is the usual style inside Emacs and
5186 may generate better code on 32-bit machines.
5188 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5189 This is for reasons similar to the recent CHAR_STRING fix.
5190 * charset.c (Fencode_char): Check that character arg is actually
5191 a character. Pass an int to ENCODE_CHAR.
5192 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5193 wider than 'int', as a compile-time check to prevent future regressions
5196 * character.c (char_string): Remove unnecessary casts.
5198 Make sure a 64-bit char is never passed to CHAR_STRING.
5199 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5200 by silently ignoring the top 32 bits, allowing some values
5201 that were far too large to be valid characters.
5202 * character.h: Include <verify.h>.
5203 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5204 arguments are no wider than unsigned, as a compile-time check
5205 to prevent future regressions in this area.
5207 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5208 (Fsubst_char_in_region):
5210 * xdisp.c (decode_mode_spec_coding):
5211 Adjust to CHAR_STRING's new requirement.
5212 * editfns.c (Finsert_char, Fsubst_char_in_region):
5213 * fns.c (concat): Check that character args are actually
5214 characters. Without this test, these functions did the wrong
5215 thing with wildly out-of-range values on 64-bit hosts.
5217 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5218 These casts should not be needed on 32-bit hosts, either.
5219 * keyboard.c (read_char):
5220 * lread.c (Fload): Remove casts to unsigned.
5222 * lisp.h (UNSIGNED_CMP): New macro.
5223 This fixes comparison bugs on 64-bit hosts.
5224 (ASCII_CHAR_P): Use it.
5225 * casefiddle.c (casify_object):
5226 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5227 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5228 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5229 * dispextern.h (FACE_FROM_ID):
5230 * keyboard.c (read_char): Use UNSIGNED_CMP.
5232 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5233 not to EMACS_INT, to avoid GCC warning.
5235 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5237 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5238 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5239 isn't needed on 32-bit machines.
5241 * buffer.c (Fgenerate_new_buffer_name):
5242 Use EMACS_INT for count, not int.
5243 (advance_to_char_boundary): Return EMACS_INT, not int.
5245 * data.c (Qcompiled_function): Now static.
5247 * window.c (window_body_lines): Now static.
5249 * image.c (gif_load): Rename local to avoid shadowing.
5251 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5252 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5253 * alloc.c (make_save_value): Integer argument is now of type
5255 (mark_object): Use ptrdiff_t, not int.
5256 * lisp.h (pD): New macro.
5257 * print.c (print_object): Use it.
5259 * alloc.c: Use EMACS_INT, not int, to count objects.
5260 (total_conses, total_markers, total_symbols, total_vector_size)
5261 (total_free_conses, total_free_markers, total_free_symbols)
5262 (total_free_floats, total_floats, total_free_intervals)
5263 (total_intervals, total_strings, total_free_strings):
5264 Now EMACS_INT, not int. All uses changed.
5265 (Fgarbage_collect): Compute overall total using a double, so that
5266 integer overflow is less likely to be a problem. Check for overflow
5267 when converting back to an integer.
5268 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5269 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5270 These were 'int' variables that could overflow on 64-bit hosts;
5271 they were never used, so remove them instead of repairing them.
5272 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5273 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5274 Previously, this ceilinged at INT_MAX, but that doesn't work on
5276 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5278 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5279 (allocate_vectorlike): Check for ptrdiff_t overflow.
5280 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5281 when a (possibly-narrower) signed value would do just as well.
5282 We prefer using signed arithmetic, to avoid comparison confusion.
5284 * alloc.c: Catch some string size overflows that we were missing.
5285 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5286 for convenience in STRING_BYTES_MAX.
5287 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5288 The definition here is exact; the one in lisp.h was approximate.
5289 (allocate_string_data): Check for string overflow. This catches
5290 some instances we weren't catching before. Also, it catches
5291 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5292 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5293 and ptrdiff_t and EMACS_INT are both 64 bits.
5295 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5296 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5297 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5299 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5301 * alloc.c (Fmake_string): Check for out-of-range init.
5303 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5305 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5307 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5309 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5310 xg_get_default_scrollbar_width.
5312 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5313 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5314 (style_changed_cb): Call update_theme_scrollbar_width and call
5315 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5316 all frames (Bug#8505).
5317 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5318 Call gtk_window_set_resizable if HAVE_GTK3.
5319 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5320 and height if HAVE_GTK3 (Bug#8505).
5321 (scroll_bar_width_for_theme): New variable.
5322 (update_theme_scrollbar_width): New function.
5323 (xg_get_default_scrollbar_width): Move code to
5324 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5325 (xg_initialize): Call update_theme_scrollbar_width.
5327 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5329 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5331 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5333 * frame.c (make_frame): Call other_buffer_safely instead of
5336 * window.c (temp_output_buffer_show): Call display_buffer with
5337 second argument Vtemp_buffer_show_specifiers and reset latter
5338 immediately after the call.
5339 (Vtemp_buffer_show_specifiers): New variable.
5340 (auto_window_vscroll_p, next_screen_context_lines)
5341 (Vscroll_preserve_screen_position): Remove leading asterisks from
5344 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5346 Fix minor problems found by GCC 4.6.0 static checking.
5347 * buffer.c (Qclone_number): Remove for now, as it's unused.
5348 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5349 (record_buffer): Remove unused local.
5350 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5351 (set_frame_buffer_list): Remove; unused.
5352 * frame.h (other_visible_frames): Remove decl.
5353 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5354 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5355 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5357 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5358 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5359 Define only if HAVE_GPM.
5360 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5361 (update_hints_inhibit): Remove; never set. All uses removed.
5362 * widgetprv.h (emacsFrameClassRec): Remove decl.
5363 * window.c (delete_deletable_window): Now returns void, since it
5364 wasn't returning anything.
5365 (compare_window_configurations): Remove unused locals.
5366 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5367 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5368 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5369 the same widths as pointers. This follows up on the 2011-05-06 patch.
5370 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5371 * xterm.h: Likewise.
5372 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5374 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5376 * makefile.w32-in: Update dependencies.
5377 (LISP_H): Add lib/intprops.h.
5379 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5381 * image.c (gif_load): Add animation frame delay to the metadata.
5382 (syms_of_image): Use DEFSYM. New symbol `delay'.
5384 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5386 * window.c (delete_deletable_window): Re-add.
5387 (Fset_window_configuration): Rewrite to handle dead buffers and
5388 consequently deletable windows.
5389 (window_tree, Fwindow_tree): Remove. Supply functionality in
5391 (compare_window_configurations): Simplify code.
5393 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5395 * image.c (imagemagick_load_image): Fix type mismatch.
5396 (Fimagemagick_types): Likewise.
5398 * window.h (replace_buffer_in_windows): Declare.
5400 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5402 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5403 Qclone_number. Remove external declaration of Qdelete_window.
5404 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5406 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5407 Run Qbuffer_list_update_hook if allowed.
5408 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5409 buffer list implementation.
5410 (other_buffer_safely): New function.
5411 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5412 calls to replace_buffer_in_windows and
5413 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5415 (record_buffer): Inhibit quitting and rewrite using quittable
5416 functions. Run Qbuffer_list_update_hook if allowed.
5417 (Frecord_buffer, Funrecord_buffer): New functions.
5418 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5419 Move switch-to-buffer to window.el.
5420 (bury-buffer): Move to window.el.
5421 (Vbuffer_list_update_hook): New variable.
5423 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5426 * window.h (resize_frame_windows): Move up in code.
5427 (Fwindow_frame): Remove EXFUN.
5428 (replace_buffer_in_all_windows): Remove prototype.
5429 (replace_buffer_in_windows_safely): Add prototype.
5431 * window.c: Declare Qdelete_window static again. Move down
5432 declaration of select_count.
5433 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5434 (Fother_window): Move to window.el.
5435 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5436 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5437 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5439 (replace_buffer_in_windows): Implement by calling
5440 Qreplace_buffer_in_windows.
5441 (replace_buffer_in_all_windows): Remove with some functionality
5442 moved into replace_buffer_in_windows_safely.
5443 (replace_buffer_in_windows_safely): New function.
5444 (select_window_norecord, select_frame_norecord): Move in front
5445 of run_window_configuration_change_hook. Remove now obsolete
5447 (Fset_window_buffer): Rewrite doc-string.
5448 Call Qrecord_window_buffer.
5449 (keys_of_window): Move binding for other-window to window.el.
5451 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5453 * dispextern.h (struct image): Replace data member, whose int_val
5454 and ptr_val fields were not used by anything, with a single
5457 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5458 (gif_clear_image, gif_load, imagemagick_load_image)
5459 (gs_clear_image, gs_load): Callers changed.
5461 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5463 * buffer.h: Include <time.h>, for time_t.
5464 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5466 Fix minor problems found by static checking.
5468 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5470 Make identifiers static if they are not used in other modules.
5471 * data.c (Qcompiled_function, Qframe, Qvector):
5472 * image.c (QimageMagick, Qsvg):
5473 * minibuf.c (Qmetadata):
5474 * window.c (resize_window_check, resize_root_window): Now static.
5475 * window.h (resize_window_check, resize_root_window): Remove decls.
5477 * window.c (window_deletion_count, delete_deletable_window):
5479 (window_body_lines): Now static.
5480 (Fdelete_other_windows_internal): Mark vars as initialized.
5481 Make sure 'resize_failed' is initialized.
5482 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5483 (resize_window_apply): Remove unused local.
5484 * window.h (delete_deletable_window): Remove decl.
5486 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5487 (imagemagick_load_image): Fix pointer signedness problem by changing
5488 last arg from unsigned char * to char *. All uses changed.
5489 Also, fix a local for similar reasons.
5490 Remove unused locals. Remove locals to avoid shadowing.
5491 (fn_rsvg_handle_free): Remove; unused.
5492 (svg_load, svg_load_image): Fix pointer signedness problem.
5493 (imagemagick_load_image): Don't use garbage pointer image_wand.
5495 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5497 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5499 * image.c (gif_load): Fix omitted cast error introduced by
5502 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5504 * window.h (resize_proportionally, orig_total_lines)
5505 (orig_top_line): Remove from window structure.
5506 (set_window_height, set_window_width, change_window_heights)
5507 (Fdelete_window): Remove prototypes.
5508 (resize_frame_windows): Remove duplicate declaration.
5510 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5512 * window.h (resize_frame_windows, resize_window_check)
5513 (delete_deletable_window, resize_root_window)
5514 (resize_frame_windows): Declare prototypes.
5516 * window.c (resize_window_apply): Make definition be "static" to
5517 match the prototype.
5519 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5521 * window.c: Remove declarations of Qwindow_size_fixed,
5522 window_min_size_1, window_min_size_2, window_min_size,
5523 size_window, window_fixed_size_p, enlarge_window, delete_window.
5524 Remove static from declaration of Qdelete_window, it's
5525 temporarily needed by Fbury_buffer.
5526 (replace_window): Don't assign orig_top_line and
5528 (Fdelete_window, delete_window): Remove. Window deletion is
5529 handled by window.el.
5530 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5531 Replace Fdelete_window calls with calls to Qdelete_window.
5532 (Fdelete_other_windows): Remove. Deleting other windows is
5533 handled by window.el.
5534 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5535 handled in window.el.
5536 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5537 Window minimum sizes are handled in window.el.
5538 (shrink_windows, size_window, set_window_height)
5539 (set_window_width, change_window_heights, window_height)
5540 (window_width, CURBEG, CURSIZE, enlarge_window)
5541 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5542 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5543 handled in window.el.
5544 (make_dummy_parent): Rename to make_parent_window and give it a
5545 second argument horflag.
5546 (make_window): Don't set resize_proportionally any more.
5547 (Fsplit_window): Remove. Windows are split in window.el.
5548 (save_restore_action, save_restore_orig_size)
5549 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5550 Resize mini windows in window.el.
5551 (grow_mini_window, shrink_mini_window): Implement by calling
5552 Qresize_root_window_vertically, resize_window_check and
5553 resize_window_apply.
5554 (saved_window, Fset_window_configuration, save_window_save):
5555 Do not handle orig_top_line, orig_total_lines, and
5556 resize_proportionally.
5557 (window_min_height, window_min_width): Move to window.el.
5558 (keys_of_window): Move bindings for delete-other-windows,
5559 split-window, delete-window and enlarge-window to window.el.
5561 * buffer.c: Temporarily extern Qdelete_window.
5562 (Fbury_buffer): Temporarily call Qdelete_window instead of
5563 Fdelete_window (Fbury_buffer will move to window.el soon).
5565 * frame.c (set_menu_bar_lines_1): Remove code handling
5566 orig_top_line and orig_total_lines.
5568 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5569 set_window_height but set heights directly.
5570 (change_frame_size_1): Use resize_frame_windows.
5572 * xdisp.c (init_xdisp): Don't use set_window_height but set
5575 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5576 Use resize_frame_windows instead of change_window_heights and run
5577 run_window_configuration_change_hook.
5579 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5580 instead of change_window_heights and run
5581 run_window_configuration_change_hook.
5583 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5585 * window.c (replace_window): Rename second argument REPLACEMENT to
5586 NEW. New third argument SETFLAG. Rewrite.
5587 (delete_window, make_dummy_parent): Call replace_window with
5589 (window_list_1): Move down in code.
5590 (run_window_configuration_change_hook): Move set_buffer part
5591 before select_frame_norecord part in order to unwind correctly.
5592 Rename count1 to count.
5593 (recombine_windows, delete_deletable_window, resize_root_window)
5594 (Fdelete_other_windows_internal)
5595 (Frun_window_configuration_change_hook, make_parent_window)
5596 (resize_window_check, resize_window_apply, Fresize_window_apply)
5597 (resize_frame_windows, Fsplit_window_internal)
5598 (Fdelete_window_internal, Fresize_mini_window_internal):
5600 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5602 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5604 * window.h (window): Add some new members to window structure -
5605 normal_lines, normal_cols, new_total, new_normal, clone_number,
5606 splits, nest, prev_buffers, next_buffers.
5607 (WINDOW_TOTAL_SIZE): Move here from window.c.
5608 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5610 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5612 (make_dummy_parent): Set new members of windows structure.
5613 (make_window): Move down in code. Handle new members of window
5615 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5616 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5617 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5618 (Fset_window_prev_buffers, Fwindow_next_buffers)
5619 (Fset_window_next_buffers, Fset_window_clone_number):
5621 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5622 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5624 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5625 Argument WINDOW can be now internal window too.
5626 (Fwindow_use_time): Move up in code.
5627 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5629 (Fset_window_configuration, saved_window)
5630 (Fcurrent_window_configuration, save_window_save): Handle new
5631 members of window structure.
5632 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5633 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5634 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5635 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5636 Qget_mru_window, Qresize_root_window,
5637 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5638 Qauto_buffer_name; staticpro them.
5640 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5642 * window.c (Fwindow_total_size, Fwindow_left_column)
5643 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5644 (Fwindow_list_1): New functions.
5645 (window_box_text_cols): Replace with window_body_cols.
5646 (Fwindow_width, Fscroll_left, Fscroll_right):
5647 Use window_body_cols instead of window_box_text_cols.
5648 (delete_window, Fset_window_configuration):
5649 Call delete_all_subwindows with window as argument.
5650 (delete_all_subwindows): Take a window as argument and not a
5652 (window_loop): Remove handling of GET_LRU_WINDOW and
5654 (Fget_lru_window, Fget_largest_window): Move to window.el.
5656 * window.h: Extern window_body_cols instead of
5657 window_box_text_cols. delete_all_subwindows now takes a
5658 Lisp_Object as argument.
5660 * indent.c (compute_motion, Fcompute_motion):
5661 Use window_body_cols instead of window_box_text_cols.
5663 * frame.c (delete_frame): Call delete_all_subwindows with root
5666 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5668 * fns.c (Fputhash): Document return value.
5670 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5672 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5674 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5676 Cons<->int and similar integer overflow fixes (Bug#8794).
5678 Check for overflow when converting integer to cons and back.
5679 * charset.c (Fdefine_charset_internal, Fdecode_char):
5680 Use cons_to_unsigned to catch overflow.
5681 (Fencode_char): Use INTEGER_TO_CONS.
5682 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5683 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5684 * data.c (long_to_cons, cons_to_long): Remove.
5685 (cons_to_unsigned, cons_to_signed): New functions.
5686 These signal an error for invalid or out-of-range values.
5687 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5688 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5689 * font.c (Ffont_variation_glyphs):
5690 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5691 * lisp.h: Include <intprops.h>.
5692 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5693 (cons_to_signed, cons_to_unsigned): New decls.
5694 (long_to_cons, cons_to_long): Remove decls.
5695 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5696 (Fprimitive_undo): Use CONS_TO_INTEGER.
5697 * xfns.c (Fx_window_property): Likewise.
5698 * xselect.c: Include <limits.h>.
5699 (x_own_selection, selection_data_to_lisp_data):
5700 Use INTEGER_TO_CONS.
5701 (x_handle_selection_request, x_handle_selection_clear)
5702 (x_get_foreign_selection, Fx_disown_selection_internal)
5703 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5704 (lisp_data_to_selection_data): Use cons_to_unsigned.
5705 (x_fill_property_data): Use cons_to_signed.
5706 Report values out of range.
5708 Check for buffer and string overflow more precisely.
5709 * buffer.h (BUF_BYTES_MAX): New macro.
5710 * lisp.h (STRING_BYTES_MAX): New macro.
5711 * alloc.c (Fmake_string):
5712 * character.c (string_escape_byte8):
5713 * coding.c (coding_alloc_by_realloc):
5714 * doprnt.c (doprnt):
5715 * editfns.c (Fformat):
5717 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5718 since they may not be the same number.
5719 * editfns.c (Finsert_char):
5720 * fileio.c (Finsert_file_contents):
5721 Likewise for BUF_BYTES_MAX.
5723 * image.c: Use ptrdiff_t, not int, for sizes.
5724 (slurp_file): Switch from int to ptrdiff_t.
5726 (slurp_file): Check that file size fits in both size_t (for
5727 malloc) and ptrdiff_t (for sanity and safety).
5729 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5730 if b->modtime has its maximal value.
5732 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5734 Don't assume time_t can fit into int.
5735 * buffer.h (struct buffer.modtime): Now time_t, not int.
5736 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5737 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5739 Minor fixes for signed vs unsigned integers.
5740 * character.h (MAYBE_UNIFY_CHAR):
5741 * charset.c (maybe_unify_char):
5742 * keyboard.c (read_char, reorder_modifiers):
5743 XINT -> XFASTINT, since the integer must be nonnegative.
5744 * ftfont.c (ftfont_spec_pattern):
5745 * keymap.c (access_keymap, silly_event_symbol_error):
5746 XUINT -> XFASTINT, since the integer must be nonnegative.
5747 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5748 since it makes no difference and we prefer signed.
5749 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5750 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5753 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5755 * window.h (Fwindow_frame): Declare.
5757 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5759 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5760 (SPARE_MEMORY): Always define.
5761 (LARGE_REQUEST): Remove.
5762 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5764 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5766 * lisp.h: Move EXFUNS for Fframe_root_window,
5767 Fframe_first_window and Fset_frame_selected_window to window.h.
5769 * window.h: Move EXFUNS for Fframe_root_window,
5770 Fframe_first_window and Fset_frame_selected_window here from
5773 * frame.c (Fwindow_frame, Fframe_first_window)
5774 (Fframe_root_window, Fframe_selected_window)
5775 (Fset_frame_selected_window): Move to window.c.
5776 (Factive_minibuffer_window): Move to minibuf.c.
5777 (Fother_visible_frames_p): New function.
5779 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5781 * window.c (decode_window, decode_any_window): Move up in code.
5782 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5783 (inhibit_frame_unsplittable): Remove unused variable.
5784 (Fwindow_buffer): Move up and rewrite doc-string.
5785 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5786 (Fwindow_prev): New functions.
5787 (Fwindow_frame): Move here from frame.c. Accept any window as
5789 (Fframe_root_window, Fframe_first_window)
5790 (Fframe_selected_window): Move here from frame.c. Accept frame
5791 or arbitrary window as argument. Update doc-strings.
5792 (Fminibuffer_window): Move up in code.
5793 (Fwindow_minibuffer_p): Move up in code and simplify.
5794 (Fset_frame_selected_window): Move here from frame.c.
5796 (Fselected_window, select_window, Fselect_window): Move up in
5797 code. Minor doc-string fixes.
5799 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5801 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5802 Do not assume that spare memory exists; that assumption is valid
5803 only if SYSTEM_MALLOC.
5804 (LARGE_REQUEST): New macro, so that the issue of large requests
5805 is separated from the issue of spare memory.
5807 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5809 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5812 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5814 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5817 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5819 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5821 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5823 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5824 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5826 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5828 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5830 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5832 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5833 (x_clipboard_manager_save): Add return value.
5834 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5836 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5837 Obey Vx_select_enable_clipboard_manager. Catch errors in
5838 x_clipboard_manager_save (Bug#8779).
5839 (Vx_select_enable_clipboard_manager): New variable.
5840 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5842 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5844 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5846 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5848 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5849 in the current matrix if keep_current_p is non-zero.
5851 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5853 * bidi.c (bidi_level_of_next_char): Fix last change.
5855 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5857 Support bidi reordering of text covered by display properties.
5859 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5860 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5861 (bidi_cache_search, bidi_cache_iterator_state)
5862 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5863 (bidi_level_of_next_char, bidi_move_to_visually_next):
5864 Support character positions inside a run of characters covered by a
5866 (bidi_paragraph_init, bidi_resolve_explicit_1)
5867 (bidi_level_of_next_char): Call bidi_fetch_char and
5868 bidi_fetch_char_advance instead of FETCH_CHAR and
5870 (bidi_init_it): Initialize new members.
5871 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5873 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5874 instead of using explicit *_CHAR codes.
5875 (bidi_resolve_explicit, bidi_resolve_weak):
5876 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5877 bidirectional text is supported only in multibyte buffers.
5878 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5879 it to initialize the frame_window_p member of struct bidi_it.
5880 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5881 (bidi_resolve_explicit, bidi_resolve_weak)
5882 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5883 bidi_it->nchars is non-positive.
5884 (bidi_level_of_next_char): Don't try to lookup the cache for the
5885 next/previous character if nothing is cached there yet, or if we
5886 were just reseat()'ed to a new position.
5888 * xdisp.c (set_cursor_from_row): Set start and stop points
5889 according to the row's direction when priming the loop that looks
5890 for the glyph on which to display cursor.
5891 (single_display_spec_intangible_p): Function deleted.
5892 (display_prop_intangible_p): Reimplement to call
5893 handle_display_spec instead of single_display_spec_intangible_p.
5894 Accept 3 additional arguments needed by handle_display_spec.
5895 This fixes incorrect cursor motion across display property with complex
5896 values: lists, `(when COND...)' forms, etc.
5897 (single_display_spec_string_p): Support property values that are
5898 lists with the argument STRING its top-level element.
5899 (display_prop_string_p): Fix the condition for processing a
5900 property that is a list to be consistent with handle_display_spec.
5901 (handle_display_spec): New function, refactored from the
5902 last portion of handle_display_prop.
5903 (compute_display_string_pos): Accept additional argument
5904 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5905 value of a `display' property is a "replacing spec".
5906 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5907 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5908 the display property, but just return a value indicating whether
5909 the display property will replace the characters it covers.
5910 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5911 frame_window_p members of struct bidi_it.
5912 (compute_display_string_pos, compute_display_string_end):
5914 (push_it): Accept second argument POSITION, where pop_it should
5915 jump to continue iteration.
5916 (reseat_1): Initialize bidi_it.disp_pos.
5918 * keyboard.c (adjust_point_for_property): Adjust the call to
5919 display_prop_intangible_p to its new signature.
5921 * dispextern.h (struct bidi_it): New member frame_window_p.
5922 (bidi_init_it): Update prototypes.
5923 (display_prop_intangible_p): Update prototype.
5924 (compute_display_string_pos, compute_display_string_end):
5926 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5929 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5931 Malloc failure behavior now depends on size of allocation.
5932 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5933 * lisp.h: Change signatures accordingly.
5934 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5935 All callers changed. (Bug#8762)
5937 * gnutls.c: Use Emacs's memory allocators.
5938 Without this change, the gnutls library would invoke malloc etc.
5939 directly, which causes problems on non-SYNC_INPUT hosts, and which
5940 runs afoul of improving memory_full behavior. (Bug#8761)
5941 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5942 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5943 xfree instead of the default malloc, realloc, free.
5944 (Fgnutls_boot): No need to check for memory allocation failure,
5945 since xmalloc does that for us.
5947 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5948 * category.c (hash_get_category_set):
5949 * ccl.c (ccl_driver):
5950 * charset.c (Fdefine_charset_internal):
5951 * charset.h (struct charset.hash_index):
5952 * composite.c (get_composition_id, gstring_lookup_cache)
5953 (composition_gstring_put_cache):
5954 * composite.h (struct composition.hash_index):
5955 * dispextern.h (struct image.hash):
5956 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5957 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5958 (hashfn_equal, hashfn_user_defined, make_hash_table)
5959 (maybe_resize_hash_table, hash_lookup, hash_put)
5960 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5961 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5962 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5963 * image.c (make_image, search_image_cache, lookup_image)
5964 (xpm_put_color_table_h):
5965 * lisp.h (struct Lisp_Hash_Table):
5966 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5967 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5968 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5969 * alloc.c (allocate_vectorlike):
5970 Check for overflow in vector size calculations.
5971 * ccl.c (ccl_driver):
5972 Check for overflow when converting EMACS_INT to int.
5973 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5974 need to be updated by these changes.
5975 * fns.c (make_hash_table, maybe_resize_hash_table):
5976 Check for integer overflow with large hash tables.
5977 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5978 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5979 (SXHASH_REDUCE): New macro.
5980 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5981 Use it instead of discarding useful hash info with large hash values.
5982 (sxhash_float): New function.
5983 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5984 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5985 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5986 Rewrite to use FIXNUM_BITS, as this simplifies things.
5987 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5988 Adjust signatures to match updated version of code.
5989 (consing_since_gc): Now EMACS_INT, since a single hash table can
5990 use more than INT_MAX bytes.
5992 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5994 Make it possible to build with GCC-4.6+ -O2 -flto.
5996 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5998 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6000 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6001 Call minibuffer-inactive-mode.
6003 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6005 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6006 Update dependencies.
6008 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6010 * data.c (init_data): Remove code for UTS, this system is not
6013 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6015 Don't force ./temacs to start in terminal mode.
6017 * frame.c (make_initial_frame): Initialize faces in all cases, not
6018 only when CANNOT_DUMP is defined.
6019 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6021 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6023 * dispnew.c (add_window_display_history): Use const for the string
6024 pointer. Remove declaration, not needed.
6026 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6028 Use 'inline', not 'INLINE'.
6029 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6030 * alloc.c, fontset.c (INLINE): Remove.
6031 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6032 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6033 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6034 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6035 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6037 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6039 Make it possible to run ./temacs.
6041 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6042 syms_of_callproc does the same thing. Remove test for
6043 "initialized", do it in the caller.
6044 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6046 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6048 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6049 (read_minibuf): Use get_minibuffer.
6050 (syms_of_minibuf): Use DEFSYM.
6051 (Qmetadata): New var.
6052 * data.c (Qbuffer): Don't make it static.
6053 (syms_of_data): Use DEFSYM.
6055 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6057 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6058 (CCL_CODE_MIN): New macro.
6060 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6062 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6064 * eval.c (Qdebug): Now static.
6065 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6066 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6067 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6069 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6071 * image.c: Various fixes to ImageMagick code comments.
6072 (Fimagemagick_types): Doc fix.
6074 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6076 Minor fixes prompted by GCC 4.6.0 warnings.
6078 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6080 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6081 (x_clipboard_manager_save_all): Move extern decl to ...
6082 * xterm.h: ... here, so that it can be checked for consistency.
6084 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6086 * xselect.c (x_clipboard_manager_save_frame)
6087 (x_clipboard_manager_save_all): New functions.
6088 (Fx_clipboard_manager_save): Lisp function deleted.
6090 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6091 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6093 * xterm.h: Update prototype.
6095 2011-05-28 William Xu <william.xwl@gmail.com>
6097 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6100 2011-05-28 Jim Meyering <meyering@redhat.com>
6102 Avoid a sign-extension bug in crypto_hash_function.
6103 * fns.c (to_uchar): Define.
6104 (crypto_hash_function): Use it to convert some newly-signed
6105 variables to unsigned, to avoid sign-extension bugs. For example,
6106 without this change, (md5 "truc") would evaluate to
6107 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6108 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6109 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6111 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6113 Integer overflow fixes.
6115 * dbusbind.c: Serial number integer overflow fixes.
6116 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6117 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6118 to hold a serial number that is too large for a fixnum.
6119 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6120 Check for serial numbers out of range. Decode any serial number
6121 that was so large that it became a float. (Bug#8722)
6123 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6124 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6125 Use XFASTINT rather than XUINT when numbers are nonnegative.
6126 (xd_append_arg, Fdbus_method_return_internal):
6127 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6128 arguments, check that Lisp number is nonnegative, rather than
6129 silently wrapping negative numbers around. (Bug#8722)
6130 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6133 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6135 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6137 ccl: Add integer overflow checks.
6138 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6139 (IN_INT_RANGE): New macros.
6140 (ccl_driver): Use them to check for integer overflow when
6141 decoding a CCL program. Many of the new checks are whether XINT (x)
6142 fits in int; it doesn't always, on 64-bit hosts. The new version
6143 doesn't catch all possible integer overflows, but it's an
6144 improvement. (Bug#8719)
6146 * alloc.c (make_event_array): Use XINT, not XUINT.
6147 There's no need for unsigned here.
6149 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6150 This follows up to the 2011-05-06 change that substituted uintptr_t
6151 for EMACS_INT. This case wasn't caught back then.
6153 Rework Fformat to avoid integer overflow issues.
6154 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6155 now (part of C89). Include <verify.h>.
6156 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6157 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6158 (Fformat): Avoid the prepass trying to compute sizes; it was only
6159 approximate and thus did not catch overflow reliably. Instead, walk
6160 through the format just once, formatting and computing sizes as we go,
6161 checking for integer overflow at every step, and allocating a larger
6162 buffer as needed. Keep track separately whether the format is
6163 multibyte. Keep only the most-recently calculated precision, rather
6164 than them all. Record whether each argument has been converted to
6165 string. Use EMACS_INT, not int, for byte and char and arg counts.
6166 Support field widths and precisions larger than INT_MAX. Avoid
6167 sprintf's undefined behavior with conversion specifications such as %#d
6168 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6169 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6170 formatting out-of-range floating point numbers with int
6173 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6175 * data.c: Avoid integer truncation in expressions involving floats.
6176 * data.c: Include <intprops.h>.
6177 (arith_driver): When there's an integer overflow in an expression
6178 involving floating point, convert the integers to floating point
6179 so that the resulting value does not suffer from catastrophic
6180 integer truncation. For example, on a 64-bit host (* 4
6181 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6182 Do not rely on undefined behavior after integer overflow.
6184 merge count_size_as_multibyte, parse_str_to_multibyte
6185 * character.c, character.h (count_size_as_multibyte):
6186 Rename from parse_str_to_multibyte; all uses changed.
6187 Check for integer overflow.
6188 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6189 since it's now a duplicate of the other. This is more of
6190 a character than a buffer op, so better that it's in character.c.
6191 * fns.c, print.c: Adjust to above changes.
6193 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6195 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6197 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6199 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6200 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6201 (x_clipboard_manager_save): Now static.
6202 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6204 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6205 (crypto_hash_function): Now static.
6206 Fix pointer signedness problems. Avoid unnecessary initializations.
6208 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6210 * termhooks.h (Vselection_alist): Make it terminal-local.
6212 * terminal.c (create_terminal): Initialize it.
6214 * xselect.c: Support for clipboard managers.
6215 (Vselection_alist): Move to termhooks.h as terminal-local var.
6216 (LOCAL_SELECTION): New macro.
6217 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6218 (symbol_to_x_atom): Remove gratuitous arg.
6219 (x_handle_selection_request, lisp_data_to_selection_data)
6220 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6221 (x_own_selection, x_get_local_selection, x_convert_selection):
6222 New arg, specifying work frame. Use terminal-local Vselection_alist.
6223 (some_frame_on_display): Delete unused function.
6224 (Fx_own_selection_internal, Fx_get_selection_internal)
6225 (Fx_disown_selection_internal, Fx_selection_owner_p)
6226 (Fx_selection_exists_p): New optional frame arg.
6227 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6228 (x_handle_selection_clear): Don't treat other terminals with the
6229 same keyboard specially. Use the terminal-local Vselection_alist.
6230 (x_clear_frame_selections): Use Frun_hook_with_args.
6232 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6234 * xterm.h: Add support for those atoms.
6236 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6238 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6239 (converted_selections, conversion_fail_tag): New global variables.
6240 (x_selection_request_lisp_error): Free the above.
6241 (x_get_local_selection): Remove unnecessary code.
6242 (x_reply_selection_request): Args changed; handle arbitrary array
6243 of converted selections stored in converted_selections.
6244 Separate the XChangeProperty and SelectionNotify steps.
6245 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6246 (x_convert_selection): New function.
6247 (x_handle_selection_event): Simplify.
6248 (x_get_foreign_selection): Don't ignore incoming requests while
6249 waiting for an answer; this will fail when we implement
6250 SAVE_TARGETS, and seems unnecessary anyway.
6251 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6252 (Vx_sent_selection_functions): Doc fix.
6254 2011-05-26 Leo Liu <sdl.web@gmail.com>
6256 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6258 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6260 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6262 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6263 for fringe update if it has periodic bitmap.
6264 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6265 and fringe_bitmap_periodic_p.
6267 * fringe.c (get_fringe_bitmap_data): New function.
6268 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6269 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6270 row. Mark glyph row for fringe update if periodicity changed.
6272 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6273 for fringe update unless it has periodic bitmap.
6275 2011-05-25 Kenichi Handa <handa@m17n.org>
6277 * xdisp.c (get_next_display_element): Set correct it->face_id for
6278 a static composition.
6280 2011-05-24 Leo Liu <sdl.web@gmail.com>
6283 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6285 * fns.c (crypto_hash_function, Fsha1): New function.
6286 (Fmd5): Use crypto_hash_function.
6287 (syms_of_fns): Add Ssha1.
6289 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6291 * gnutls.c: Remove unused macros.
6292 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6293 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6294 Remove macros that are defined and never used.
6295 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6297 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6299 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6300 (Fx_get_selection_internal): Minor cleanup.
6301 (Fx_own_selection_internal): Rename arguments for consistency with
6304 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6306 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6308 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6310 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6312 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6314 * dispnew.c (scrolling_window): Don't exclude the case that the
6315 last enabled row in the desired matrix touches the bottom boundary.
6317 2011-05-21 Glenn Morris <rgm@gnu.org>
6319 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6320 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6321 and add some more files.
6323 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6325 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6326 report_file_error introduced by the change from 2011-05-07.
6328 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6330 * systime.h (Time): Define only if emacs is defined.
6331 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6332 where the include path doesn't have X11/X.h by default. See
6333 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6335 2011-05-20 Kenichi Handa <handa@m17n.org>
6337 * composite.c (find_automatic_composition): Fix previous change.
6339 2011-05-20 Glenn Morris <rgm@gnu.org>
6341 * lisp.mk: New file, split from Makefile.in.
6342 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6343 (shortlisp): Remove.
6344 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6346 2011-05-19 Glenn Morris <rgm@gnu.org>
6348 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6349 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6350 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6351 (lisp): Set the order to that of loadup.el.
6352 (shortlisp): Make it a copy of $lisp.
6353 (SOME_MACHINE_LISP): Remove.
6354 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6355 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6357 2011-05-18 Kenichi Handa <handa@m17n.org>
6359 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6360 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6361 (find_automatic_composition): Mostly rewrite for efficiency.
6363 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6365 * makefile.w32-in: Update dependencies.
6367 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6369 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6370 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6372 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6374 Fix some integer overflow issues, such as string length overflow.
6376 * insdel.c (count_size_as_multibyte): Check for string overflow.
6378 * character.c (lisp_string_width): Check for string overflow.
6379 Use EMACS_INT, not int, for string indexes and lengths; in
6380 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6381 the resulting string length overflows an EMACS_INT; instead,
6382 report a string overflow if no precision given. When checking for
6383 precision exhaustion, use a check that cannot possibly have
6384 integer overflow. (Bug#8675)
6385 * character.h (lisp_string_width): Adjust to new signature.
6387 * alloc.c (string_overflow): New function.
6388 (Fmake_string): Use it. This doesn't change behavior, but saves
6389 a few bytes and will simplify future changes.
6390 * character.c (string_escape_byte8): Likewise.
6391 * lisp.h (string_overflow): New decl.
6393 Fixups, following up to the user-interface timestamp change.
6394 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6395 for UI timestamps, instead of unsigned long.
6396 * msdos.c (mouse_get_pos): Likewise.
6397 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6398 * w32gui.h (Time): Define by including "systime.h" rather than by
6399 declaring it ourselves. (Bug#8664)
6401 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6402 * image.c (clear_image_cache): Likewise.
6404 * term.c (term_mouse_position): Don't assume time_t wraparound.
6406 Be more systematic about user-interface timestamps.
6407 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6408 and sometimes 'EMACS_UINT', to represent these timestamps.
6409 This change causes it to use 'Time' uniformly, as that's what X uses.
6410 This makes the code easier to follow, and makes it easier to catch
6411 integer overflow bugs such as Bug#8664.
6412 * frame.c (Fmouse_position, Fmouse_pixel_position):
6413 Use Time, not unsigned long, for user-interface timestamps.
6414 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6415 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6416 * keyboard.h (last_event_timestamp): Likewise.
6417 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6418 * menu.h (xmenu_show): Likewise.
6419 * term.c (term_mouse_position): Likewise.
6420 * termhooks.h (struct input_event.timestamp): Likewise.
6421 (struct terminal.mouse_position_hook): Likewise.
6422 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6423 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6424 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6425 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6427 * menu.h, termhooks.h: Include "systime.h", for Time.
6429 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6430 Don't assume that the difference between two unsigned long values
6431 can fit into an integer. At this point, we know button_down_time
6432 <= event->timestamp, so the difference must be nonnegative, so
6433 there's no need to cast the result if double-click-time is
6434 nonnegative, as it should be; check that it's nonnegative, just in
6435 case. This bug is triggered when events are more than 2**31 ms
6436 apart (about 25 days). (Bug#8664)
6438 * xselect.c (last_event_timestamp): Remove duplicate decl.
6439 (x_own_selection): Remove needless cast to unsigned long.
6441 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6442 that always fit in int. Use a sentinel instead of a counter, to
6443 avoid a temp and to allay GCC's concerns about possible int overflow.
6444 * frame.h (struct frame): Use int for menu_bar_items_used
6445 instead of EMACS_INT, since it always fits in int.
6447 * menu.c (grow_menu_items): Check for int overflow.
6449 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6451 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6452 Before, the code was not consistent. These values cannot exceed
6453 2**31 - 1 so there's no need to make them unsigned.
6454 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6455 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6456 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6458 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6460 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6461 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6462 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6463 presumably because the widths might not match.
6465 * window.c (size_window): Avoid needless test at loop start.
6467 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6469 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6471 2011-05-12 Drew Adams <drew.adams@oracle.com>
6473 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6475 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6477 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6478 `width' to `bar_area_x' and `bar_area_width', respectively.
6479 (x_scroll_run): Take account of fringe background extension.
6481 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6482 Rename local vars `left' and `width' to `bar_area_x' and
6483 `bar_area_width', respectively.
6484 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6485 background extension.
6487 2011-05-10 Jim Meyering <meyering@redhat.com>
6489 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6491 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6493 * image.c (Finit_image_library): Return t for built-in image types,
6494 like pbm and xbm. (Bug#8640)
6496 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6498 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6500 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6502 * w32console.c (Fset_screen_color): Doc fix.
6503 (Fget_screen_color): New function.
6504 (syms_of_ntterm): Defsubr it.
6506 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6507 unlink the temporary file if Fcall_process didn't create it in the
6509 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6510 child process will be redirected to a file specified with `:file'.
6511 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6512 cue to call_process_cleanup not to close that handle.
6514 2011-05-07 Ben Key <bkey76@gmail.com>
6516 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6517 one of two shell specific rules, either bootstrap-temacs-CMD or
6518 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6519 to the previous implementation of the bootstrap-temacs rule.
6520 The bootstrap-temacs-CMD rule is similar to the previous
6521 implementation of the bootstrap-temacs rule except that it
6522 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6525 These changes, along with some changes to nt/configure.bat,
6526 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6527 earlier fix to add support for --cflags and --ldflags options
6528 that include quotes so that it works whether make uses cmd or
6531 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6533 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6534 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6536 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6537 a string. Handle both cases.
6538 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6539 (Fdbus_register_method): Use Qinvalid_function.
6541 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6543 * makefile.w32-in: Update dependencies.
6544 (LISP_H): Add inttypes.h and stdin.h.
6545 (PROCESS_H): Add unistd.h.
6547 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6549 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6550 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6552 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6554 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6556 * term.c (vfatal): Remove stray call to va_end.
6557 It's not needed and the C Standard doesn't allow it here anyway.
6559 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6560 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6562 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6565 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6567 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6569 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6571 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6573 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6575 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6576 * charset.c (Fdefine_charset_internal): Don't initialize
6577 charset.code_space[15]. The value was garbage, on hosts with
6578 32-bit int (Bug#8600).
6580 * lread.c (read_integer): Be more consistent with string-to-number.
6581 Use string_to_number to do the actual conversion; this avoids
6582 rounding errors and fixes some other screwups. Without this fix,
6583 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6584 (digit_to_number): Move earlier, for benefit of read_integer.
6585 Return -1 if the digit is out of range for the base, -2 if it is
6586 not a digit in any supported base. (Bug#8602)
6588 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6590 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6591 to match comment at start of function. This also removes a
6592 GCC warning about overflow in a 32+64-bit port.
6594 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6596 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6597 Reported by Stefan Monnier in
6598 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6599 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6600 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6602 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6603 (EMACS_UINTPTR): Likewise, with uintptr_t.
6605 * lisp.h: Prefer 64-bit EMACS_INT if available.
6606 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6607 on 32-bit hosts that have 64-bit int, so that they can access
6609 However, temporarily disable this change unless the temporary
6610 symbol WIDE_EMACS_INT is defined.
6612 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6614 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6615 This removes an assumption that EMACS_INT and long are the same
6616 width as pointers. The assumption is true for Emacs porting targets
6617 now, but we want to make other targets possible.
6618 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6619 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6620 In the rest of the code, change types of integers that hold casted
6621 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6622 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6623 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6624 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6625 No need to cast type when ORing.
6626 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6627 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6628 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6629 assume EMACS_INT is the same width as char *.
6630 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6631 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6632 Remove no-longer-needed casts.
6633 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6634 (xg_tool_bar_help_callback, xg_make_tool_item):
6635 Use EMACS_INTPTR to hold an integer
6636 that will be cast to void *; this can avoid a GCC warning
6637 if EMACS_INT is not the same width as void *.
6638 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6639 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6640 (current_message_1, set_message_1):
6641 Use a local to convert to proper width without a cast.
6642 * xmenu.c (dialog_selection_callback): Likewise.
6644 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6645 Also, don't assume VALBITS / RAND_BITS is less than 5,
6646 and don't rely on undefined behavior when shifting a 1 left into
6648 * lisp.h (get_random): Change signature to match.
6650 * lread.c (hash_string): Use size_t, not int, for hash computation.
6651 Normally we prefer signed values; but hashing is special, because
6652 it's better to use unsigned division on hash table sizes so that
6653 the remainder is nonnegative. Also, size_t is the natural width
6654 for hashing into memory. The previous code used 'int', which doesn't
6655 retain enough info to hash well into very large tables.
6656 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6658 * dbusbind.c: Don't possibly lose pointer info when converting.
6659 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6660 Use XPNTR rather than XHASH, so that the high-order bits of
6661 the pointer aren't lost when converting through void *.
6663 * eval.c (Fautoload): Don't double-shift a pointer.
6665 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6667 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6669 * gnutls.c (DEF_GNUTLS_FN):
6670 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6672 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6674 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6677 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6679 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6680 New version that can reserve upto 2GB of heap space.
6682 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6684 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6686 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6688 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6689 `gnutls_certificate_set_x509_key_file'.
6691 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6693 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6694 Update dependencies.
6696 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6698 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6699 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6700 Remove unused parameter `fildes'.
6701 * process.c (read_process_output, send_process): Don't pass it.
6703 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6705 Fix previous change: the library cache is defined in w32.c.
6706 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6707 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6709 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6711 Implement dynamic loading of GnuTLS on Windows.
6713 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6714 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6715 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6718 * gnutls.c (Qgnutls_dll): Define.
6719 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6720 (gnutls_*): Declare function pointers.
6721 (init_gnutls_functions): New function to initialize function pointers.
6722 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6723 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6724 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6725 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6726 (emacs_gnutls_write, emacs_gnutls_read)
6727 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6728 (Fgnutls_available_p): New function.
6729 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6730 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6731 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6733 * image.c: Include w32.h.
6734 (Vimage_type_cache): Delete.
6735 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6736 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6737 (w32_delayed_load): Move to w32.c.
6739 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6741 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6742 (w32_delayed_load): Move from image.c. When loading a library, record
6743 its filename in the :loaded-from property of the library id.
6744 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6745 Initialize and staticpro them.
6746 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6748 * process.c: Include lisp.h before w32.h, not after.
6749 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6750 instead of gnutls_record_check_pending.
6752 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6754 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6756 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6757 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6760 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6762 * xterm.c (x_set_frame_alpha): Do not set property on anything
6763 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6765 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6767 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6769 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6771 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6772 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6773 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6774 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6775 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6776 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6777 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6778 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6779 (Qgnutls_bootprop_callbacks_verify): Make static.
6781 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6783 * callproc.c: Indentation fixup.
6785 * sysdep.c (wait_for_termination_1): Make static.
6786 (wait_for_termination, interruptible_wait_for_termination):
6787 Move after wait_for_termination_1.
6789 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6791 * sysdep.c (interruptible_wait_for_termination): New function
6792 which is like wait_for_termination, but allows keyboard
6795 * callproc.c (Fcall_process): Add (:file "file") as an option for
6797 (Fcall_process_region): Ditto.
6799 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6801 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6802 rather than `XVECTOR (FOO)->size'.
6804 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6805 inttypes.h, as a gnulib replacement is used if it not available in
6808 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6810 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6811 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6812 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6814 * coding.c (coding_alloc_by_realloc): Error out if destination
6815 will grow beyond MOST_POSITIVE_FIXNUM.
6816 (decode_coding_emacs_mule): Abort if there isn't enough place in
6817 charbuf for the composition carryover bytes. Reserve an extra
6818 space for up to 2 characters produced in a loop.
6819 (decode_coding_iso_2022): Abort if there isn't enough place in
6820 charbuf for the composition carryover bytes.
6822 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6824 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6825 aborting when %lld or %lll format is passed.
6826 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6827 %llo or %llx format is passed. (Bug#8545)
6829 * window.c (window_scroll_line_based): Use a marker instead of
6830 simple variables to record original value of point. (Bug#7952)
6832 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6833 produced by %s or %c overflows available buffer space. (Bug#8545)
6835 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6837 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6838 (SIZE_MAX): Move defn after all includes, as they might #define it.
6840 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6842 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6844 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6846 * keyboard.c (Qdelayed_warnings_hook): Define.
6847 (command_loop_1): Run `delayed-warnings-hook'
6848 if Vdelayed_warnings_list is non-nil.
6849 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6850 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6852 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6854 * doprnt.c (doprnt): Don't return value smaller than the buffer
6855 size if the message was truncated. (Bug#8545).
6857 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6859 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6860 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6862 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6864 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6866 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6868 * makefile.w32-in: Update dependencies.
6870 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6872 Improve `doprnt' and its usage. (Bug#8545)
6873 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6874 `format_end'. Remove support for %l as a conversion specifier.
6875 Don't use xrealloc. Improve diagnostics when the %l size modifier
6876 is used. Update the commentary.
6878 * eval.c (verror): Simplify calculation of size_t.
6880 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6883 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6885 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6888 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6890 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6891 This makes this file independent of the recent pseudovector change.
6893 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6895 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6897 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6898 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6899 Remove unused local.
6900 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6902 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6903 GCC 4.6.0 optimizes based on type-based alias analysis.
6904 For example, if b is of type struct buffer * and v of type struct
6905 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6906 != &v->size, and therefore "v->size = 1; b->size = 2; return
6907 v->size;" must therefore return 1. This assumption is incorrect
6908 for Emacs, since it type-puns struct Lisp_Vector * with many other
6909 types. To fix this problem, this patch adds a new type struct
6910 vectorlike_header that documents the constraints on layout of vectors
6911 and pseudovectors, and helps optimizing compilers not get fooled
6912 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6913 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6914 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6916 (XSETPVECTYPE): Rewrite in terms of new macro.
6917 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6918 This is a bit clearer, and further avoids the possibility of
6919 undesirable aliasing.
6920 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6921 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6922 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6923 since Lisp_Subr is a special case (no "next" field).
6924 (ASIZE): Now uses header.size rather than size.
6925 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6926 to avoid the hassle of writing XVECTOR (foo)->header.size.
6927 (struct vectorlike_header): New type.
6928 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6929 object, to help avoid aliasing.
6930 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6931 (SUBRP): Likewise, since Lisp_Subr is a special case.
6932 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6933 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6934 (struct Lisp_Hash_Table): Combine first two members into a single
6935 struct vectorlike_header member. All uses of "size" and "next" members
6936 changed to be "header.size" and "header.next".
6937 * buffer.h (struct buffer): Likewise.
6938 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6939 * frame.h (struct frame): Likewise.
6940 * process.h (struct Lisp_Process): Likewise.
6941 * termhooks.h (struct terminal): Likewise.
6942 * window.c (struct save_window_data, struct saved_window): Likewise.
6943 * window.h (struct window): Likewise.
6944 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6945 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6946 * buffer.c (init_buffer_once): Likewise.
6947 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6949 * process.c (Fformat_network_address): Use local var for size,
6952 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6954 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6955 * data.c (atof): Remove decl; no longer used or needed.
6956 (digit_to_number): Move to lread.c.
6957 (Fstring_to_number): Use new string_to_number function, to be
6958 consistent with how the Lisp reader treats infinities and NaNs.
6959 Do not assume that floating-point numbers represent EMACS_INT
6960 without losing information; this is not true on most 64-bit hosts.
6961 Avoid double-rounding errors, by insisting on integers when
6962 parsing non-base-10 numbers, as the documentation specifies.
6963 * lisp.h (string_to_number): New decl, replacing ...
6964 (isfloat_string): Remove.
6965 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6966 (read1): Do not accept +. and -. as integers; this
6967 appears to have been a coding error. Similarly, do not accept
6968 strings like +-1e0 as floating point numbers. Do not report
6969 overflow for integer overflows unless the base is not 10 which
6970 means we have no simple and reliable way to continue.
6971 Break out the floating-point parsing into a new
6972 function string_to_number, so that Fstring_to_number parses
6973 floating point numbers consistently with the Lisp reader.
6974 (digit_to_number): Move here from data.c. Make it static inline.
6975 (E_CHAR, EXP_INT): Remove, replacing with ...
6976 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6977 (string_to_number): New function, replacing isfloat_string.
6978 This function checks for valid syntax and produces the resulting
6979 Lisp float number too. Rework it so that string-to-number
6980 no longer mishandles examples like "1.0e+". Use strtoumax,
6981 so that overflow for non-base-10 numbers is reported only when
6982 there's no portable and simple way to convert to floating point.
6984 * textprop.c (set_text_properties_1): Rewrite for clarity,
6985 and to avoid GCC warning about integer overflow.
6987 * intervals.h (struct interval): Use EMACS_INT for members
6988 where EMACS_UINT might cause problems. See
6989 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6990 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6991 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6993 (offset_intervals): Tell GCC not to worry about length overflow
6994 when negating a negative length.
6996 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6997 (overrun_check_free): Likewise.
6999 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7000 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7003 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7004 (gnutls_make_error): Rename local to avoid shadowing.
7005 (gnutls_emacs_global_deinit): ifdef out; not used.
7006 (Fgnutls_boot): Use const for pointer to readonly storage.
7007 Comment out unused local. Fix pointer signedness problems.
7009 * lread.c (openp): Don't stuff size_t into an 'int'.
7010 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7011 about possible signed overflow.
7013 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7014 (GDK_KEY_g): Don't define if already defined.
7015 (xg_prepare_tooltip): Avoid pointer signedness problem.
7016 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7018 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7019 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7021 * xfns.c (Fx_window_property): Simplify a bit,
7022 to make a bit faster and to avoid GCC 4.6.0 warning.
7023 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7025 * fns.c (internal_equal): Don't assume size_t fits in int.
7027 * alloc.c (compact_small_strings): Tighten assertion a little.
7029 Replace pEd with more-general pI, and fix some printf arg casts.
7030 * lisp.h (pI): New macro, generalizing old pEd macro to other
7031 conversion specifiers. For example, use "...%"pI"d..." rather
7032 than "...%"pEd"...".
7033 (pEd): Remove. All uses replaced with similar uses of pI.
7034 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7035 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7036 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7037 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7038 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7039 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7040 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7042 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7043 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7044 * print.c (safe_debug_print, print_object): Likewise.
7045 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7047 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7048 avoiding the 0 flag, which is not portable.
7049 * process.c (Fmake_network_process): Use pI to avoid cast.
7050 * region-cache.c (pp_cache): Likewise.
7051 * xdisp.c (decode_mode_spec): Likewise.
7052 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7053 behavior on 64-bit hosts with printf arg.
7054 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7055 (x_stop_queuing_selection_requests): Likewise.
7056 (x_get_window_property): Don't truncate byte count to an 'int'
7059 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7060 here, since it parses constructs like leading '-' and spaces,
7061 which are not wanted; and it overflows with large numbers.
7062 Instead, simply match F[0-9]+, which is what is wanted anyway.
7064 * alloc.c: Remove unportable assumptions about struct layout.
7065 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7066 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7067 (allocate_vectorlike, make_pure_vector): Use the new macros,
7068 plus offsetof, to remove unportable assumptions about struct layout.
7069 These assumptions hold on all porting targets that I know of, but
7070 they are not guaranteed, they're easy to remove, and removing them
7071 makes further changes easier.
7073 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7074 This doesn't fix a bug but makes the code clearer.
7075 (string_overrun_cookie): Now const. Use initializers that
7076 don't formally overflow signed char, to avoid warnings.
7077 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7078 can cause Emacs to crash when string overrun checking is enabled.
7079 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7080 multiple of sizeof (EMACS_INT); it need not be, if
7081 alignof(EMACS_INT) < sizeof (EMACS_INT).
7082 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7084 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7086 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7088 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7090 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7091 supposed to be handshaking. (Bug#8556)
7092 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7094 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7096 * lisp.h (Qdebug): List symbol.
7097 * eval.c (Qdebug): Restore global linkage.
7098 * keyboard.c (debug-on-event): New variable.
7099 (handle_user_signal): Break into debugger when debug-on-event
7100 matches the current signal symbol.
7102 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7104 * alloc.c (check_sblock, check_string_bytes)
7105 (check_string_free_list): Convert to standard C.
7107 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7109 * w32.c (emacs_gnutls_push): Fix typo.
7111 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7113 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7114 "cast to pointer from integer of different size".
7116 Improve doprnt and its use in verror. (Bug#8545)
7117 * doprnt.c (doprnt): Document the set of format control sequences
7118 supported by the function. Use SAFE_ALLOCA instead of always
7121 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7122 is one byte too soon. Don't use xrealloc; instead xfree and
7125 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7127 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7130 * gnutls.c: Renamed global_initialized to
7131 gnutls_global_initialized. Added internals for the
7132 :verify-hostname-error, :verify-error, and :verify-flags
7133 parameters of `gnutls-boot' and documented those parameters in the
7134 docstring. Start callback support.
7135 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7136 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7137 on error. Return error code.
7138 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7139 (emacs_gnutls_read): Likewise.
7140 (Fgnutls_boot): Return handshake error code.
7141 (emacs_gnutls_handle_error): New function.
7142 (wsaerror_to_errno): Likewise.
7144 * w32.h (emacs_gnutls_pull): Add prototype.
7145 (emacs_gnutls_push): Likewise.
7147 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7148 (emacs_gnutls_push): Likewise.
7150 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7152 * process.c (wait_reading_process_output): Check if GnuTLS
7153 buffered some data internally if no FDs are set for TLS
7156 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7157 (LIBS): Link to USER_LIBS.
7158 ($(BLD)/gnutls.$(0)): New target.
7160 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7162 * xdisp.c (handle_single_display_spec): Rename the
7163 display_replaced_before_p argument into display_replaced_p, to
7164 make it consistent with the commentary. Fix typos in the
7167 * textprop.c (syms_of_textprop): Remove dead code.
7168 (copy_text_properties): Delete obsolete commentary about an
7169 interface that was deleted long ago. Fix typos in the description
7172 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7173 to changes in oldXMenu/XMenu.h from 2011-04-16.
7174 <menu_help_message, prev_menu_help_message>: Constify.
7175 (IT_menu_make_room): menu->help_text is now `const char **';
7178 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7179 to changes in oldXMenu/XMenu.h from 2011-04-16.
7180 (struct XMenu): Declare `help_text' `const char **'.
7182 * xfaces.c <Qunspecified>: Make extern again.
7184 * syntax.c: Include sys/types.h before including regex.h, as
7187 * doc.c (get_doc_string): Improve the format passed to `error'.
7189 * doprnt.c (doprnt): Improve commentary.
7191 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7193 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7196 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7197 changes in globals.h immediately force recompilation.
7198 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7199 $(CURDIR)/s/ms-w32.h.
7200 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7202 * character.c (Fchar_direction): Function deleted.
7203 (syms_of_character): Don't defsubr it.
7204 <char-direction-table>: Deleted.
7206 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7208 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7209 * doprnt.c: Include limits.h.
7210 (SIZE_MAX): New macro.
7211 (doprnt): Return a size_t value. 2nd arg is now size_t.
7212 Many local variables are now size_t instead of int or unsigned.
7213 Improve overflow protection. Support `l' modifier for integer
7214 conversions. Support %l conversion. Don't assume an EMACS_INT
7215 argument for integer conversions and for %c.
7217 * lisp.h (doprnt): Restore prototype.
7219 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7222 * Makefile.in (base_obj): Add back doprnt.o.
7224 * deps.mk (doprnt.o): Add back prerequisites.
7225 (callint.o): Depend on character.h.
7227 * eval.c (internal_lisp_condition_case): Include the handler
7228 representation in the error message.
7229 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7230 when breaking from the loop.
7232 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7234 * callint.c (Fcall_interactively): When displaying error message
7235 about invalid control letter, pass the character's codepoint, not
7236 a pointer to its multibyte form. Improve display of the character
7237 in octal and display also its hex code.
7239 * character.c (char_string): Use %x to display the (unsigned)
7240 codepoint of an invalid character, to avoid displaying a bogus
7243 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7244 `error', not SYMBOL_NAME itself.
7246 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7247 character arguments to `error'.
7249 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7250 to `error' in error message about FINAL_CHAR argument. Make sure
7251 FINAL_CHAR is a character, and use %c when it is passed as
7252 argument to `error'.
7254 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7256 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7258 * w32.c: Include <time.h>.
7259 (sys_localtime): New function.
7261 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7263 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7265 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7267 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7269 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7272 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7274 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7275 gl_state.e_property when gl_state.object is Qt.
7277 * insdel.c (make_gap_larger): Remove limitation of buffer size
7280 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7282 * xdisp.c (lookup_glyphless_char_display)
7283 (produce_glyphless_glyph): Handle cons cell entry in
7284 glyphless-char-display.
7285 (Vglyphless_char_display): Document it.
7287 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7288 glyphless-char-display.
7290 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7292 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7294 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7296 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7297 definition for no-X builds.
7299 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7301 Static checks with GCC 4.6.0 and non-default toolkits.
7303 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7305 * process.c (keyboard_bit_set): Define only if SIGIO.
7306 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7307 (send_process): Repair possible setjmp clobbering.
7309 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7311 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7313 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7315 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7316 Define only if needed.
7318 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7319 by pacifying GCC about it. Maybe it's time to retire it?
7320 * xfaces.c (USG, __TIMEVAL__): Likewise.
7322 * dispextern.h (struct redisplay_interface): Rename param
7324 * termhooks.h (struct terminal): Likewise.
7325 * xterm.c (xembed_send_message): Likewise.
7327 * insdel.c (make_gap_smaller): Define only if
7328 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7330 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7333 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7334 so that we aren't warned about unused symbols.
7336 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7338 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7340 * xfns.c (x_real_positions): Mark locals as initialized.
7342 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7344 * xterm.c: Fix problems found by static analysis with other toolkits.
7345 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7346 (x_dispatch_event): Declare static if USE_GTK, and
7347 define if USE_GTK || USE_X_TOOLKIT.
7348 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7349 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7350 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7351 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7353 * xmenu.c (menu_help_callback): Pointer type fixes.
7354 Use const pointers when pointing at readonly data. Avoid pointer
7356 (FALSE): Remove unused macro.
7357 (update_frame_menubar): Remove unused decl.
7359 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7361 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7362 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7363 (single_menu_item): Rename local to avoid shadowing.
7365 * keyboard.c (make_lispy_event): Remove unused local var.
7367 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7368 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7370 * bitmaps: Change bitmaps from unsigned char back to the X11
7371 compatible char. Avoid the old compiler warnings about
7372 out-of-range initializers by using, for example, '\xab' rather
7375 * xgselect.c (xgselect_initialize): Check vs interface
7376 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7378 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7380 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7381 to read-only memory.
7383 * fns.c (vector): Remove; this old hack is no longer needed.
7385 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7387 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7389 * xrdb.c (x_load_resources): Omit unused local.
7391 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7392 (x_window): Rename locals to avoid shadowing.
7393 (USG): Use the kludged USG macro, to pacify gcc.
7395 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7396 (x_term_init): Remove local to avoid shadowing.
7398 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7400 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7401 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7403 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7405 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7407 Fix regex.c, syntax.c and friends for buffers > 2GB.
7408 * syntax.h (struct gl_state_s): Declare character position members
7411 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7413 * textprop.c (verify_interval_modification, interval_of):
7414 Declare arguments EMACS_INT.
7416 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7419 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7421 * indent.c (Fvertical_motion): Local variable it_start is now
7424 * regex.c (re_match, re_match_2, re_match_2_internal)
7425 (bcmp_translate, regcomp, regexec, print_double_string)
7426 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7427 (re_compile_pattern, re_exec): Declare arguments and local
7428 variables `size_t' and `ssize_t' and return values `regoff_t', as
7430 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7431 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7432 <compile_stack_type>: `size' and `avail' are now `size_t'.
7434 * regex.h <regoff_t>: Use ssize_t, not int.
7435 (re_search, re_search_2, re_match, re_match_2): Arguments that
7436 specify buffer/string position and length are now ssize_t and
7437 size_t. Return type is regoff_t.
7439 2011-04-16 Ben Key <bkey76@gmail.com>
7441 * nsfont.m: Fixed bugs in ns_get_family and
7442 ns_descriptor_to_entity that were caused by using free to
7443 deallocate memory blocks that were allocated by xmalloc (via
7444 xstrdup). This caused Emacs to crash when compiled with
7445 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7446 --enable-checking=xmallocoverrun). xfree is now used to
7447 deallocate these memory blocks.
7449 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7451 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7453 emacs_write: Accept and return EMACS_INT for sizes.
7454 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7456 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7457 Accept and return EMACS_INT.
7458 (emacs_gnutls_write): Return the number of bytes written on
7460 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7461 (emacs_read, emacs_write): Remove check for negative size, as the
7462 Emacs source code has been audited now.
7463 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7464 (emacs_read, emacs_write): Use it.
7465 * process.c (send_process): Adjust to the new signatures of
7466 emacs_write and emacs_gnutls_write. Do not attempt to store
7467 a byte offset into an 'int'; it might overflow.
7468 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7470 * sound.c: Don't assume sizes fit in 'int'.
7471 (struct sound_device.period_size, alsa_period_size):
7472 Return EMACS_INT, not int.
7473 (struct sound_device.write, vox_write, alsa_write):
7474 Accept EMACS_INT, not int.
7475 (wav_play, au_play): Use EMACS_INT to store sizes and to
7476 record read return values.
7478 2011-04-15 Ben Key <bkey76@gmail.com>
7480 * keyboard.c (Qundefined): Don't declare static since it is used
7482 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7483 static since they are used in nsfont.m.
7485 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7487 * process.c (Qprocessp): Don't declare static.
7488 * lisp.h (Qprocessp): Declare again.
7490 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7492 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7494 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7496 Improve C-level modularity by making more things 'static'.
7498 Don't publish debugger-only interfaces to other modules.
7499 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7500 (verify_bytepos, count_markers): Move decls to the only modules
7502 * region-cache.h (pp_cache): Likewise.
7503 * window.h (check_all_windows): Likewise.
7504 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7506 * sysdep.c (croak): Now static, if
7507 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7508 * syssignal.h (croak): Declare only if not static.
7510 * alloc.c (refill_memory_reserve): Now static if
7511 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7512 * lisp.h (refill_memory_reserve): Declare only if not static.
7514 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7515 Define only if USE_LUCID.
7517 * xrdb.c (x_customization_string, x_rm_string): Now static.
7519 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7520 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7522 * xdisp.c (draw_row_with_mouse_face): Now static.
7523 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7525 * window.h (check_all_windows): Mark externally visible.
7527 * window.c (window_deletion_count): Now static.
7529 * undo.c: Make symbols static if they're not exported.
7530 (last_undo_buffer, last_boundary_position, pending_boundary):
7533 * textprop.c (interval_insert_behind_hooks): Now static.
7534 (interval_insert_in_front_hooks): Likewise.
7536 * term.c: Make symbols static if they're not exported.
7537 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7538 (max_frame_lines, tty_set_terminal_modes):
7539 (tty_reset_terminal_modes, tty_turn_off_highlight):
7540 (get_tty_terminal): Now static.
7541 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7542 * termhooks.h (term_mouse_moveto): Do not declare if
7544 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7545 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7547 * sysdep.c: Make symbols static if they're not exported.
7548 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7550 (sigprocmask_set, full_mask): Remove; unused.
7551 (wait_debugging): Mark as visible.
7552 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7553 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7555 * syntax.c (syntax_temp): Define only if !__GNUC__.
7557 * sound.c (current_sound_device, current_sound): Now static.
7559 * search.c (searchbufs, searchbuf_head): Now static.
7561 * scroll.c (scroll_cost): Remove; unused.
7562 * dispextern.h (scroll_cost): Remove decl.
7564 * region-cache.h (pp_cache): Mark as externally visible.
7566 * process.c: Make symbols static if they're not exported.
7567 (process_tick, update_tick, create_process, chan_process):
7568 (Vprocess_alist, proc_buffered_char, datagram_access):
7569 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7570 (deactivate_process): Mark defn as static, as well as decl.
7571 * lisp.h (create_process): Remove decl.
7572 * process.h (chan_process, Vprocess_alist): Remove decls.
7574 * print.c: Make symbols static if they're not exported.
7575 (print_depth, new_backquote_output, being_printed, print_buffer):
7576 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7577 (print_interval, print_number_index, initial_stderr_stream):
7579 * lisp.h (Fprinc): Remove decl.
7580 (debug_output_compilation_hack): Mark as externally visible.
7582 * sysdep.c (croak): Move decl from here to syssignal.h.
7583 * syssignal.h (croak): Put it here, so the API can be checked when
7584 'croak' is called from dissociate_if_controlling_tty.
7586 * minibuf.c: Make symbols static if they're not exported.
7587 (minibuf_save_list, choose_minibuf_frame): Now static.
7588 * lisp.h (choose_minibuf_frame): Remove decl.
7590 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7592 * lread.c: Make symbols static if they're not exported.
7593 (read_objects, initial_obarray, oblookup_last_bucket_number):
7595 (make_symbol): Remove; unused.
7596 * lisp.h (initial_obarray, make_symbol): Remove decls.
7598 * keyboard.c: Make symbols static if they're not exported.
7599 (single_kboard, recent_keys_index, total_keys, recent_keys):
7600 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7601 (this_single_command_key_start, echoing, last_auto_save):
7602 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7603 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7604 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7605 (Vlispy_mouse_stem, double_click_count):
7607 (force_auto_save_soon): Define only if SIGDANGER.
7608 (ignore_mouse_drag_p): Now static if
7609 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7610 (print_help): Remove; unused.
7611 (stop_character, last_timer_event): Mark as externally visible.
7612 * keyboard.h (ignore_mouse_drag_p): Declare only if
7613 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7614 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7615 * lisp.h (echoing): Remove decl.
7616 (force_auto_save_soon): Declare only if SIGDANGER.
7617 * xdisp.c (redisplay_window): Simplify code, to make it more
7618 obvious that ignore_mouse_drag_p is not accessed if !defined
7619 USE_GTK && !defined HAVE_NS.
7621 * intervals.c: Make symbols static if they're not exported.
7622 (merge_properties_sticky, merge_interval_right, delete_interval):
7624 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7626 * insdel.c: Make symbols static if they're not exported.
7627 However, leave prepare_to_modify_buffer alone. It's never
7628 called from outside this function, but that appears to be a bug.
7629 (combine_after_change_list, combine_after_change_buffer):
7630 (adjust_after_replace, signal_before_change): Now static.
7631 (adjust_after_replace_noundo): Remove; unused.
7632 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7633 (signal_before_change): Remove decls.
7635 * indent.c (val_compute_motion, val_vmotion): Now static.
7637 * image.c: Make symbols static if they're not exported.
7638 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7640 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7641 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7643 * fringe.c (standard_bitmaps): Now static.
7644 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7646 * frame.c: Make symbols static if they're not exported.
7647 (x_report_frame_params, make_terminal_frame): Now static.
7648 (get_frame_param): Now static, unless HAVE_NS.
7649 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7650 (x_get_resource_string): Remove; not used.
7651 * frame.h (make_terminal_frame, x_report_frame_params):
7652 (x_get_resource_string); Remove decls.
7653 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7654 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7656 * font.c, fontset.c: Make symbols static if they're not exported.
7657 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7658 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7659 * font.c (font_close_object): Now static.
7660 * font.h (font_close_object): Remove.
7661 * fontset.c (FONTSET_OBJLIST): Remove.
7662 (free_realized_fontset) #if-0 the body, which does nothing.
7663 (face_suitable_for_char_p): #if-0, as it's never called.
7664 * fontset.h (face_suitable_for_char_p): Remove decl.
7665 * xfaces.c (face_at_string_position):
7666 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7667 since 0 is always ASCII.
7669 * fns.c (weak_hash_tables): Now static.
7671 * fileio.c: Make symbols static if they're not exported.
7672 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7673 (Vwrite_region_annotation_buffers): Now static.
7675 * eval.c: Make symbols static if they're not exported.
7676 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7677 * lisp.h (backtrace_list): Remove decl.
7679 * emacs.c: Make symbols static if they're not exported.
7680 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7681 (fatal_error_code, fatal_error_signal_hook, standard_args):
7683 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7684 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7685 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7686 * lisp.h (fatal_error_signal_hook): Remove decl.
7687 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7689 * editfns.c: Move a (normally-unused) function to its only use.
7690 * editfns.c, lisp.h (get_operating_system_release): Remove.
7691 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7692 worth the hassle of breaking this out.
7694 * xterm.c: Make symbols static if they're not exported.
7695 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7696 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7697 (x_destroy_window, x_delete_display):
7699 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7700 (x_mouse_leave): Remove; unused.
7701 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7702 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7703 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7705 (x_mouse_leave): Declare only if WINDOWSNT.
7706 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7707 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7710 * ftxfont.c: Make symbols static if they're not exported.
7711 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7713 * font.h (ftxfont_driver): Likewise.
7715 * xfns.c: Make symbols static if they're not exported.
7716 (x_last_font_name, x_display_info_for_name):
7717 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7718 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7719 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7720 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7721 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7722 (last_show_tip_args): Now static.
7723 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7724 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7725 (x_screen_planes): Remove; unused.
7726 * dispextern.h (x_screen_planes): Remove decl.
7728 * dispnew.c: Make symbols static if they're not exported.
7729 * dispextern.h (redraw_garbaged_frames, scrolling):
7730 (increment_row_positions): Remove.
7731 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7732 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7734 (redraw_garbaged_frames): Remove; unused.
7736 * xfaces.c: Make symbols static if they're not exported.
7737 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7739 * xterm.h (defined_color): Remove decls.
7740 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7741 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7742 (menu_face_changed_default, defined_color, free_realized_face):
7743 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7744 (ascii_face_of_lisp_face): Remove; unused.
7746 * xdisp.c: Make symbols static if they're not exported.
7747 * dispextern.h (scratch_glyph_row, window_box_edges):
7748 (glyph_to_pixel_coords, set_cursor_from_row):
7749 (get_next_display_element, set_iterator_to_next):
7750 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7751 (show_mouse_face): Remove decls
7752 * frame.h (message_buf_print): Likewise.
7753 * lisp.h (pop_message, set_message, check_point_in_composition):
7755 * xterm.h (set_vertical_scroll_bar): Likewise.
7756 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7757 (message_buf_print, scratch_glyph_row, displayed_buffer):
7758 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7759 (get_next_display_element, show_mouse_face, window_box_edges):
7760 (frame_to_window_pixel_xy, check_point_in_composition):
7761 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7762 (glyph_to_pixel_coords): Remove; unused.
7764 * dired.c (file_name_completion): Now static.
7766 * dbusbind.c (xd_in_read_queued_messages): Now static.
7768 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7769 * data.c (circular_list_error): Remove.
7771 * commands.h (last_point_position, last_point_position_buffer):
7772 (last_point_position_window): Remove decls.
7773 * keyboard.c: Make these variables static.
7775 * coding.h (coding, code_convert_region, encode_coding_gap):
7777 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7778 (iso_code_class, detect_coding, code_convert_region): Now static.
7779 (encode_coding_gap): Remove; unused.
7781 * chartab.c (chartab_chars, chartab_bits): Now static.
7783 * charset.h (charset_iso_8859_1): Remove decl.
7784 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7787 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7788 * ccl.c (Vccl_program_table): Now static.
7789 (check_ccl_update): Remove; unused.
7791 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7792 * category.h: ... from here.
7793 * category.c (check_category_table, set_category_set): Now static.
7795 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7796 * lisp.h: Remove these decls.
7798 * buffer.c (buffer_count): Remove unused var.
7800 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7801 so that it's not optimized away.
7802 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7803 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7804 exported only to the debugger.
7806 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7807 * atimer.h (run_all_atimers): Remove; not exported.
7809 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7810 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7811 was inaccessible from Lisp.
7812 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7813 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7815 alloc.c: Import and export fewer symbols, and remove unused items.
7816 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7818 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7819 it's not optimized away by whole-program optimization.
7820 (message_enable_multibyte, free_misc): Remove.
7821 (catchlist, handlerlist, mark_backtrace):
7822 Declare only if BYTE_MARK_STACK.
7823 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7824 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7825 (message_enable_multibyte): Remove decl.
7826 (free_misc, interval_free_list, float_block, float_block_index):
7827 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7828 (cons_free_list, last_marked_index):
7830 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7831 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7832 (mark_backtrace): Define only if BYTE_MARK_STACK.
7833 * xdisp.c (message_enable_multibyte): Now static.
7835 Declare Lisp_Object Q* variables to be 'static' if not exported.
7836 This makes it easier for human readers (and static analyzers)
7837 to see whether these variables are used from other modules.
7838 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7839 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7840 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7841 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7842 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7843 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7844 * xmenu.c, xselect.c:
7845 Declare Q* vars static if they are not used in other modules.
7846 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7847 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7848 Remove decls of unexported vars.
7849 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7851 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7853 Make Emacs functions such as Fatom 'static' by default.
7854 This makes it easier for human readers (and static analyzers)
7855 to see whether these functions can be called from other modules.
7856 DEFUN now defines a static function. To make the function external
7857 so that it can be used in other C modules, use the new macro DEFUE.
7858 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7859 (Finit_image_library):
7860 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7861 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7862 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7863 Remove decls, since these functions are now static.
7864 (Funintern, Fget_internal_run_time): New decls, since these functions
7865 were already external.
7867 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7868 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7869 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7870 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7871 * keyboard.c, keymap.c, lread.c:
7872 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7873 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7874 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7875 Mark functions with DEFUE instead of DEFUN,
7876 if they are used in other modules.
7877 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7878 decls for now-static functions.
7879 * buffer.h (Fdelete_overlay): Remove decl.
7880 * callproc.c (Fgetenv_internal): Mark as internal.
7881 * composite.c (Fremove_list_of_text_properties): Remove decl.
7882 (Fcomposition_get_gstring): New forward static decl.
7883 * composite.h (Fcomposite_get_gstring): Remove decl.
7884 * dired.c (Ffile_attributes): New forward static decl.
7885 * doc.c (Fdocumntation_property): New forward static decl.
7886 * eval.c (Ffetch_bytecode): New forward static decl.
7887 (Funintern): Remove extern decl; now in .h file where it belongs.
7888 * fileio.c (Fmake_symbolic_link): New forward static decl.
7889 * image.c (Finit_image_library): New forward static decl.
7890 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7891 * intervals.h (Fprevious_property_change):
7892 (Fremove_list_of_text_properties): Remove decls.
7893 * keyboard.c (Fthis_command_keys): Remove decl.
7894 (Fcommand_execute): New forward static decl.
7895 * keymap.c (Flookup_key): New forward static decl.
7896 (Fcopy_keymap): Now static.
7897 * keymap.h (Flookup_key): Remove decl.
7898 * process.c (Fget_process): New forward static decl.
7899 (Fprocess_datagram_address): Mark as internal.
7900 * syntax.c (Fsyntax_table_p): New forward static decl.
7901 (skip_chars): Remove duplicate decl.
7902 * textprop.c (Fprevious_property_change): New forward static decl.
7903 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7905 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7906 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7908 * editfns.c (Fformat): Remove unreachable code.
7910 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7912 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7915 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7917 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7918 when at ZV. (Bug#8487)
7920 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7922 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7924 * keyboard.c (parse_tool_bar_item): Likewise.
7925 * sound.c (sound_cleanup, alsa_close): Likewise.
7926 * termcap.c (tgetent): Likewise.
7927 * xfns.c (x_default_font_parameter): Likewise.
7928 * xsettings.c (read_and_apply_settings): Likewise.
7930 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7931 (overrun_check_free): Protoize.
7933 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7935 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7936 since callers should never pass a negative size.
7937 Change the signature to match that of plain 'read' and 'write'; see
7938 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7939 * lisp.h: Update prototypes of emacs_write and emacs_read.
7941 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7943 * xdisp.c (redisplay_window): Don't try to determine the character
7944 position of the scroll margin if the window start point w->startp
7945 is outside the buffer's accessible region. (Bug#8468)
7947 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7949 Fix write-region and its subroutines for buffers > 2GB.
7950 * fileio.c (a_write, e_write): Modify declaration of arguments and
7951 local variables to support buffers larger than 2GB.
7952 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7954 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7955 argument, local variables, and return value.
7957 * lisp.h: Update prototypes of emacs_write and emacs_read.
7959 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7961 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7963 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7965 Fix more problems found by GCC 4.6.0's static checks.
7967 * xdisp.c (vmessage): Use a better test for character truncation.
7969 * charset.c (load_charset_map): <, not <=, for optimization,
7970 and to avoid potential problems with integer overflow.
7971 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7972 * casetab.c (set_identity, shuffle): Likewise.
7973 * editfns.c (Fformat): Likewise.
7974 * syntax.c (skip_chars): Likewise.
7976 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7977 This also lets GCC 4.6.0 generate slightly better loop code.
7979 * callint.c (Fcall_interactively): <, not <=, for optimization.
7980 (Fcall_interactively): Count the number of arguments produced,
7981 not the number of arguments given. This is simpler and lets GCC
7982 4.6.0 generate slightly better code.
7984 * ftfont.c: Distingish more carefully between FcChar8 and char.
7985 The previous code passed unsigned char * to a functions like
7986 strlen and xstrcasecmp that expect char *, which does not
7987 conform to the C standard.
7988 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7989 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7990 char * when the C standard requires it.
7992 * keyboard.c (read_char): Remove unused var.
7994 * eval.c: Port to Windows vsnprintf (Bug#8435).
7996 (SIZE_MAX): Define if the headers do not.
7997 (verror): Do not give up if vsnprintf returns a negative count.
7998 Instead, grow the buffer. This ports to Windows vsnprintf, which
7999 does not conform to C99. Problem reported by Eli Zaretskii.
8000 Also, simplify the allocation scheme, by avoiding the need for
8001 calling realloc, and removing the ALLOCATED variable.
8003 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8005 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8006 But keep the doprint source code for now, as we might revamp it
8007 and use it again (Bug#8435).
8008 * lisp.h (doprnt): Remove.
8009 * Makefile.in (base_obj): Remove doprnt.o.
8010 * deps.mk (doprnt.o): Remove.
8012 error: Print 32- and 64-bit integers portably (Bug#8435).
8013 Without this change, on typical 64-bit hosts error ("...%d...", N)
8014 was used to print both 32- and 64-bit integers N, which relied on
8016 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8017 * lisp.h (error, verror): Mark as printf-like functions.
8018 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8019 Report overflow in size calculations when allocating printf buffer.
8020 Do not truncate output string at its first null byte.
8021 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8022 Truncate the output at a character boundary, since vsnprintf does not
8024 * charset.c (check_iso_charset_parameter): Convert internal
8025 character to string before calling 'error', since %c now has the
8027 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8028 overflow when computing char to be passed to 'error'. Do not
8029 pass Lisp_Object to 'error'; pass the integer instead.
8030 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8031 formatted with plain %d.
8033 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8035 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8037 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8039 * xterm.c (x_catch_errors): Remove duplicate declaration.
8041 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8043 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8045 2011-04-10 Jim Meyering <meyering@redhat.com>
8047 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8048 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8049 return ssize_t not "int", and use size_t as the buffer length.
8050 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8051 * gnutls.h: Update declarations.
8052 * process.c (read_process_output): Use ssize_t, to match.
8053 (send_process): Likewise.
8055 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8057 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8059 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8061 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8062 Use unsigned char, to match FcChar8 type definition.
8064 * xterm.c (handle_one_xevent):
8065 * xmenu.c (create_and_show_popup_menu):
8066 * xselect.c (x_decline_selection_request)
8067 (x_reply_selection_request): Avoid type-punned deref of X events.
8069 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8071 Fix some uses of `int' instead of EMACS_INT.
8072 * search.c (string_match_1, fast_string_match)
8073 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8074 (scan_buffer, find_next_newline_no_quit)
8075 (find_before_next_newline, search_command, Freplace_match)
8076 (Fmatch_data): Make some `int' variables be EMACS_INT.
8078 * xdisp.c (display_count_lines): 3rd argument and return value now
8079 EMACS_INT. All callers changed.
8080 (pint2hrstr): Last argument is now EMACS_INT.
8082 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8083 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8084 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8085 (decode_coding_utf_16, decode_coding_emacs_mule)
8086 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8087 (decode_coding_ccl, decode_coding_charset)
8088 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8089 (decode_coding_iso_2022, decode_coding_emacs_mule)
8090 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8091 <char_offset, last_offset>: Declare EMACS_INT.
8092 (encode_coding_utf_8, encode_coding_utf_16)
8093 (encode_coding_emacs_mule, encode_invocation_designation)
8094 (encode_designation_at_bol, encode_coding_iso_2022)
8095 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8096 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8098 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8099 (encode_invocation_designation): Last argument P_NCHARS is now
8101 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8102 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8104 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8107 * ccl.c (Fccl_execute_on_string): Declare some variables
8110 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8112 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8114 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8116 * process.c (Fformat_network_address): Doc fix.
8118 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8120 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8122 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8124 * keyboard.c (read_char): Call Lisp function help-form-show,
8125 instead of using internal_with_output_to_temp_buffer.
8126 (Qhelp_form_show): New var.
8127 (syms_of_keyboard): Use DEFSYM macro.
8129 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8131 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8133 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8135 * process.c (Flist_processes): Remove to Lisp.
8136 (list_processes_1): Delete.
8138 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8140 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8142 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8144 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8146 Fix more problems found by GCC 4.6.0's static checks.
8148 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8150 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8152 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8154 * xdisp.c (vmessage): Mark as a printf-like function.
8156 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8158 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8160 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8161 printf-like functions.
8162 (tiff_load): Add casts to remove these marks before passing them
8163 to system-supplied API.
8165 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8167 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8168 This avoids several warnings with gcc -Wstrict-overflow.
8169 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8170 directly, rather than having caller test rule sign. This avoids
8171 some unnecessary tests.
8172 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8173 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8174 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8176 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8177 (xfont_open): Avoid unnecessary tests.
8179 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8181 * composite.h, composite.c (composition_gstring_put_cache):
8182 Use EMACS_INT, not int, for length.
8184 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8185 breaking out part of COMPOSITION_DECODE_RULE.
8186 (COMPOSITION_DECODE_RULE): Use it.
8187 * composite.c (get_composition_id): Remove unused local vars,
8188 by using the new macro.
8190 * textprop.c (set_text_properties_1): Change while to do-while,
8191 since the condition is always true at first.
8193 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8194 (interval_deletion_adjustment): Return unsigned value.
8197 * process.c (list_processes_1, create_pty, read_process_output):
8198 (exec_sentinel): Remove vars that were set but not used.
8199 (create_pty): Remove unnecessary "volatile"s.
8200 (Fnetwork_interface_info): Avoid possibility of int overflow.
8201 (read_process_output): Do adaptive read buffering even if carryover.
8202 (read_process_output): Simplify nbytes computation if buffered.
8204 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8206 * syntax.c (scan_words): Remove var that was set but not used.
8207 (update_syntax_table): Use unsigned instead of int.
8209 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8210 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8211 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8213 * print.c (print_error_message): Avoid int overflow.
8215 * font.c (font_list_entities): Redo for clarity,
8216 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8218 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8219 (font_score): Avoid potential overflow in diff calculation.
8221 * fns.c (substring_both): Remove var that is set but not used.
8222 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8224 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8226 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8227 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8228 can always succeed if overflow has undefined behavior.
8230 * search.c (boyer_moore, wordify): Remove vars set but not used.
8231 (wordify): Omit three unnecessary tests.
8233 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8234 All callers changed. This avoids the need for an unused var.
8236 * casefiddle.c (casify_region): Remove var that is set but not used.
8238 * dired.c (file_name_completion): Remove var that is set but not used.
8240 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8242 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8243 (Finsert_file_contents): Remove unnecessary code checking fd.
8245 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8246 Check for integer overflow on size calculations.
8248 * buffer.c (Fprevious_overlay_change): Remove var that is set
8251 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8252 Remove vars that are set but not used.
8253 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8254 (timer_check_2): Mark vars as initialized.
8256 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8258 * image.c (lookup_image): Remove var that is set but not used.
8259 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8261 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8262 that are set but not used.
8264 * xfns.c (make_invisible_cursor): Don't return garbage
8265 if XCreateBitmapFromData fails (Bug#8410).
8267 * xselect.c (x_get_local_selection, x_handle_property_notify):
8268 Remove vars that are set but not used.
8270 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8271 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8273 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8274 Remove var that is set but not used.
8275 (scroll_bar_windows_size): Now size_t, not int.
8276 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8279 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8280 (map_tty_color) [!defined MSDOS]: Likewise.
8282 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8284 * coding.c: Remove vars that are set but not used.
8285 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8286 All callers changed.
8287 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8288 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8289 (decode_coding_charset): Remove vars that are set but not used.
8291 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8292 that is set but not used.
8294 * print.c (print_object): Remove var that is set but not used.
8296 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8297 The gnulib version avoids calling malloc in the usual case,
8298 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8299 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8300 * filelock.c (current_lock_owner): Likewise.
8301 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8302 * sysdep.c: Include allocator.h, careadlinkat.h.
8303 (emacs_no_realloc_allocator): New static constant.
8304 (emacs_readlink): New function.
8305 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8306 ../lib/careadlinkat.h.
8308 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8310 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8311 first non-nil return value).
8313 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8315 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8316 if not defined (Bug#8403).
8318 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8320 * xdisp.c (display_count_lines): Remove parameter `start',
8321 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8322 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8323 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8324 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8325 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8326 and thereabouts. All callers changed.
8327 (get_per_char_metric): Remove parameter `f', unused since
8328 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8330 2011-04-02 Jim Meyering <meyering@redhat.com>
8332 do not dereference NULL upon failed strdup
8333 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8334 (ns_get_family): Likewise.
8336 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8338 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8340 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8342 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8345 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8347 Add lexical binding.
8349 * window.c (Ftemp_output_buffer_show): New fun.
8350 (Fsave_window_excursion):
8351 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8353 * lread.c (lisp_file_lexically_bound_p): New function.
8354 (Fload): Bind Qlexical_binding.
8355 (readevalloop): Remove `evalfun' arg.
8356 Bind Qinternal_interpreter_environment.
8357 (Feval_buffer): Bind Qlexical_binding.
8358 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8360 (syms_of_lread): Declare `lexical-binding'.
8362 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8364 * keyboard.c (eval_dyn): New fun.
8365 (menu_item_eval_property): Use it.
8367 * image.c (parse_image_spec): Use Ffunctionp.
8369 * fns.c (concat, mapcar1): Accept byte-code-functions.
8371 * eval.c (Fsetq): Handle lexical vars.
8372 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8373 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8374 (FletX, Flet): Obey lexical binding.
8375 (Fcommandp): Handle closures.
8376 (Feval): New `lexical' arg.
8377 (eval_sub): New function extracted from Feval. Use it almost
8378 everywhere where Feval was used. Look up vars in lexical env.
8380 (Ffunctionp): Move from subr.el.
8381 (Ffuncall): Handle closures.
8382 (apply_lambda): Remove `eval_flags'.
8383 (funcall_lambda): Handle closures and new byte-code-functions.
8384 (Fspecial_variable_p): New function.
8385 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8386 but without exporting it to Lisp.
8388 * doc.c (Fdocumentation, store_function_docstring):
8389 * data.c (Finteractive_form): Handle closures.
8391 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8394 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8396 (exec_byte_code): New function extracted from Fbyte_code to handle new
8397 calling convention for byte-code-functions. Add new byte-codes.
8399 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8401 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8403 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8405 * xdisp.c (redisplay_internal): Fix prototype.
8407 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8409 * xdisp.c (SCROLL_LIMIT): New macro.
8410 (try_scrolling): Use it when setting scroll_limit.
8411 Limit scrolling to 100 screen lines.
8412 (redisplay_window): Even when falling back on "recentering",
8413 position point in the window according to scroll-conservatively,
8414 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8416 (try_scrolling): When point is above the window, allow searching
8417 as far as scroll_max, or one screenful, to compute vertical
8418 distance from PT to the scroll margin position. This prevents
8419 try_scrolling from unnecessarily failing when
8420 scroll-conservatively is set to a value slightly larger than the
8421 window height. Clean up the case of PT below the margin at bottom
8422 of window: scroll_max can no longer be INT_MAX. When aggressive
8423 scrolling is in use, don't let point enter the opposite scroll
8424 margin as result of the scroll.
8425 (syms_of_xdisp) <scroll-conservatively>: Document the
8426 threshold of 100 lines for never-recentering scrolling.
8428 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8430 * dispextern.h (move_it_by_lines):
8431 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8432 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8433 (message_log_check_duplicate): Remove parameters `prev_bol' and
8434 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8435 (redisplay_internal): Remove parameter `preserve_echo_area',
8436 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8438 * indent.c (Fvertical_motion):
8439 * window.c (window_scroll_pixel_based, Frecenter):
8440 Don't pass `need_y_p' to `move_it_by_lines'.
8442 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8444 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8445 steal a few bits to be more compact.
8446 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8447 Remove unneeded casts.
8449 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8451 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8453 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8454 binding" message (bug#7967).
8456 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8458 Fix more problems found by GCC 4.6.0's static checks.
8460 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8461 Remove unused local var.
8463 * editfns.c (Fmessage_box): Remove unused local var.
8465 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8466 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8467 Omit unused local vars.
8468 * window.c (shrink_windows): Omit unused local var.
8469 * menu.c (digest_single_submenu): Omit unused local var.
8470 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8471 Omit unused local var.
8473 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8474 Don't assume string length fits in int.
8475 (keyremap_step, read_key_sequence): Use size_t for sizes.
8476 (read_key_sequence): Don't check last_real_key_start redundantly.
8478 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8479 instead of alloca (Bug#8344).
8481 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8482 (Fbacktrace_frame): Don't assume nframes fits in int.
8484 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8486 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8489 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8491 * cm.c (calccost): Turn while-do into do-while, for clarity.
8493 * keyboard.c (syms_of_keyboard): Use the same style as later
8494 in this function when indexing through an array. This also
8495 works around GCC bug 48267.
8497 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8499 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8501 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8502 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8504 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8505 This avoids undefined behavior on integer overflow, and is a bit
8506 more convenient anyway since it is compared to a size_t variable.
8508 Variadic C functions now count arguments with size_t, not int.
8509 This avoids an unnecessary limitation on 64-bit machines, which
8510 caused (substring ...) to crash on large vectors (Bug#8344).
8511 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8512 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8513 All variadic functions and their callers changed accordingly.
8514 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8515 * data.c (arith_driver, float_arith_driver): Likewise.
8516 * editfns.c (general_insert_function): Likewise.
8517 * eval.c (struct backtrace.nargs, interactive_p)
8518 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8519 (funcall_lambda, mark_backtrace): Likewise.
8520 * fns.c (concat): Likewise.
8521 * frame.c (x_set_frame_parameters): Likewise.
8522 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8523 0 if not found, not -1. All callers changed.
8525 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8526 (stack_copy_size): Now size_t, not int.
8527 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8529 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8531 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8532 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8533 All callers changed.
8535 * lisp.h (multibyte_char_to_unibyte):
8536 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8537 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8538 * character.h (CHAR_TO_BYTE8):
8539 * cmds.c (internal_self_insert):
8540 * editfns.c (general_insert_function):
8541 * keymap.c (push_key_description):
8542 * search.c (Freplace_match):
8543 * xdisp.c (message_dolog, set_message_1): All callers changed.
8545 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8547 * keyboard.c (safe_run_hook_funcall): New function.
8548 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8549 don't set the hook to nil, but remove the offending function instead.
8550 (Qcommand_hook_internal): Remove, unused.
8551 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8552 Vcommand_hook_internal.
8554 * eval.c (enum run_hooks_condition): Remove.
8555 (funcall_nil, funcall_not): New functions.
8556 (run_hook_with_args): Call each function through a `funcall' argument.
8557 Remove `cond' argument, now redundant.
8558 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8559 (Frun_hook_with_args_until_failure): Adjust accordingly.
8560 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8562 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8564 * dispextern.h (string_buffer_position): Remove declaration.
8566 * print.c (strout): Remove parameter `multibyte', unused since
8567 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8569 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8570 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8571 All callers changed.
8573 * w32.c (_wsa_errlist): Use braces for struct initializers.
8575 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8576 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8577 All callers changed.
8578 (string_buffer_position): Likewise. Also, make static (it's never
8579 used outside xdisp.c).
8580 (cursor_row_p): Remove parameter `w', unused since
8581 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8582 (decode_mode_spec): Remove parameter `precision', introduced during
8583 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8584 All callers changed.
8586 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8588 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8590 2011-03-27 Anders Lindgren <andlind@gmail.com>
8592 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8593 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8594 (ns_update_auto_hide_menu_bar): New functions.
8595 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8596 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8597 ns_constrain_all_frames.
8598 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8599 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8601 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8603 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8605 2011-03-27 Glenn Morris <rgm@gnu.org>
8607 * syssignal.h: Replace RETSIGTYPE with void.
8608 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8609 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8610 Replace SIGTYPE with void everywhere.
8611 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8612 * s/template.h (SIGTYPE): Remove commented out definition.
8614 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8616 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8617 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8619 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8621 * w32.c (read_unc_volume): Use parameter `henum', instead of
8622 global variable `wget_enum_handle'.
8624 * keymap.c (describe_vector): Remove parameters `indices' and
8625 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8626 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8628 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8630 * keyboard.c (timer_check): Remove parameter `do_it_now',
8631 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8632 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8633 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8635 * keyboard.c (read_char):
8636 * w32menu.c (w32_menu_display_help):
8637 * xmenu.c (show_help_event, menu_help_callback):
8638 Adjust calls to `show_help_echo'.
8640 * gtkutil.c (xg_maybe_add_timer):
8641 * keyboard.c (readable_events):
8642 * process.c (wait_reading_process_output):
8643 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8645 * insdel.c (adjust_markers_gap_motion):
8646 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8647 (gap_left, gap_right): Don't call it.
8649 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8651 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8652 incurred during fontification.
8654 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8656 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8657 (DEFVAR_PER_BUFFER): Don't pass it.
8659 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8660 (scrolling_window): Don't pass it.
8662 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8664 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8666 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8668 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8669 of variables specific to SELinux and computation of `encoded_absname'.
8671 * image.c (XPutPixel): Remove unused variable `height'.
8673 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8675 * unexw32.c (get_section_info): Remove unused variable `section'.
8677 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8678 (system_process_attributes): Remove unused variable `sess'.
8679 (sys_read): Remove unused variable `err'.
8681 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8682 (w32_wnd_proc): Remove unused variable `isdead'.
8683 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8684 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8685 (x_create_tip_frame): Remove unused variable `tem'.
8687 * w32inevt.c (w32_console_read_socket):
8688 Remove unused variable `no_events'.
8690 * w32term.c (x_draw_composite_glyph_string_foreground):
8691 Remove unused variable `width'.
8693 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8695 * w32term.c (x_set_glyph_string_clipping):
8696 Don't pass uninitialized region to CombineRgn.
8698 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8700 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8701 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8702 (Fx_close_connection): Remove unused variable `i'.
8704 * w32font.c (w32font_draw): Return number of glyphs.
8705 (w32font_open_internal): Remove unused variable `i'.
8706 (w32font_driver): Add missing initializer.
8708 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8709 (fill_in_menu): Remove unused variable `items_added'.
8711 * w32term.c (last_mouse_press_frame): Remove static global variable.
8712 (w32_clip_to_row): Remove unused variable `f'.
8713 (x_delete_terminal): Remove unused variable `i'.
8715 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8716 (NOTHING): Remove unused static global variable.
8717 (uniscribe_check_otf): Remove unused variable `table'.
8718 (uniscribe_font_driver): Add missing initializers.
8720 2011-03-23 Julien Danjou <julien@danjou.info>
8722 * term.c (Fsuspend_tty, Fresume_tty):
8723 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8724 * window.c (temp_output_buffer_show):
8725 * insdel.c (signal_before_change):
8726 * frame.c (Fhandle_switch_frame):
8727 * fileio.c (Fdo_auto_save):
8728 * emacs.c (Fkill_emacs):
8729 * editfns.c (save_excursion_restore):
8730 * cmds.c (internal_self_insert):
8731 * callint.c (Fcall_interactively):
8732 * buffer.c (Fkill_all_local_variables):
8733 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8735 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8736 unconditionally since it does the check itself.
8738 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8740 Fix more problems found by GCC 4.5.2's static checks.
8742 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8743 the first time through the loop, since we know p0 < p1 then.
8744 This also avoids a gcc -Wstrict-overflow warning.
8746 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8747 leading to a memory leak, possible in functions like
8748 load_charset_map_from_file that can allocate an unbounded number
8749 of objects (Bug#8318).
8751 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8752 that could (at least in theory) be that large.
8754 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8755 This is less likely to overflow, and avoids undefined behavior if
8756 overflow does occur. All callers changed. Use strtoul to scan
8757 for the unsigned long integer.
8758 (pint2hrstr): Simplify and tune code slightly.
8759 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8761 * scroll.c (do_scrolling): Work around GCC bug 48228.
8762 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8764 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8765 This also avoids a warning with gcc -Wstrict-overflow.
8766 (validate_x_resource_name): Simplify count usage.
8767 This also avoids a warning with gcc -Wstrict-overflow.
8769 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8772 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8774 * process.c (Fmake_network_process): Use socklen_t, not int,
8775 where POSIX says socklen_t is required in portable programs.
8776 This fixes a porting bug on hosts like 64-bit HP-UX, where
8777 socklen_t is wider than int (Bug#8277).
8778 (Fmake_network_process, server_accept_connection):
8779 (wait_reading_process_output, read_process_output):
8782 * process.c: Rename or move locals to avoid shadowing.
8783 (list_processes_1, Fmake_network_process):
8784 (read_process_output_error_handler, exec_sentinel_error_handler):
8785 Rename or move locals.
8786 (Fmake_network_process): Define label "retry_connect" only if needed.
8787 (Fnetwork_interface_info): Fix pointer signedness.
8788 (process_send_signal): Add cast to avoid pointer signedness problem.
8789 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8790 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8792 Make tparam.h and terminfo.c consistent.
8793 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8794 Include tparam.h instead, since it declares them.
8795 * cm.h (PC): Remove extern decl; tparam.h now does this.
8796 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8797 * terminfo.c: Include tparam.h, to check interfaces.
8798 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8799 (tparam): Adjust signature to match interface in tparam.h;
8800 this removes some undefined behavior. Check that outstring and len
8801 are zero, which they always are with Emacs.
8802 * tparam.h (PC, BC, UP): New extern decls.
8804 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8805 (xftfont_open): Rename locals to avoid shadowing.
8807 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8808 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8809 (OTF_TAG_SYM): Omit macro if not needed.
8810 (ftfont_list): Remove unused local.
8811 (get_adstyle_property, ftfont_pattern_entity):
8812 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8813 Rename locals to avoid shadowing.
8815 * xfont.c (xfont_list_family): Mark var as initialized.
8817 * xml.c (make_dom): Now static.
8819 * composite.c (composition_compute_stop_pos): Rename local to
8821 (composition_reseat_it): Remove unused locals.
8822 (find_automatic_composition, composition_adjust_point): Likewise.
8823 (composition_update_it): Mark var as initialized.
8824 (find_automatic_composition): Mark vars as initialized,
8825 with a FIXME (Bug#8290).
8827 character.h: Rename locals to avoid shadowing.
8828 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8829 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8830 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8831 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8834 * textprop.c (property_change_between_p): Remove; unused.
8836 * intervals.c (interval_start_pos): Now static.
8838 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8840 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8841 Rename locals to avoid shadowing.
8843 * sound.c (wav_play, au_play, Fplay_sound_internal):
8844 Fix pointer signedness.
8845 (alsa_choose_format): Remove unused local var.
8846 (wav_play): Initialize a variable to 0, to prevent undefined
8847 behavior (Bug#8278).
8849 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8851 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8853 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8854 clobbering (Bug#8298).
8855 * sysdep.c (sys_subshell): Likewise.
8856 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8858 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8859 This should get cleaned up, so that child_setup has the
8860 same signature on all platforms.
8862 * callproc.c (call_process_cleanup): Now static.
8863 (relocate_fd): Rename locals to avoid shadowing.
8865 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8867 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8868 not to be necessary, and produces flickering.
8870 2011-03-20 Glenn Morris <rgm@gnu.org>
8872 * config.in: Remove file.
8874 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8876 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8877 are now in src/globals.h.
8878 (syms_of_minibuf): Remove spurious & from previous change.
8880 2011-03-20 Leo Liu <sdl.web@gmail.com>
8882 * minibuf.c (completing-read-function): New variable.
8883 (completing-read-default): Rename from completing-read.
8884 (completing-read): Call completing-read-function.
8886 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8888 * xfaces.c (Fx_load_color_file):
8889 Read color file from absolute filename (bug#8250).
8891 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8893 * makefile.w32-in: Update dependencies.
8895 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8897 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8899 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8901 Fix more problems found by GCC 4.5.2's static checks.
8903 * process.c (make_serial_process_unwind, send_process_trap):
8904 (sigchld_handler): Now static.
8906 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8907 That way, the code declares only the vars that it needs.
8908 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8909 * s/cygwin.h (PTY_ITERATION): Likewise.
8910 * s/darwin.h (PTY_ITERATION): Likewise.
8911 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8913 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8914 * process.c (allocate_pty): Don't declare stb unless it's needed.
8916 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8917 (CONSTANTLIM): Remove; unused.
8918 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8919 Define only if needed.
8921 * unexelf.c (unexec): Name an expression,
8922 to avoid gcc -Wbad-function-cast warning.
8923 Use a different way to cause a compilation error if anyone uses
8924 n rather than nn, a way that does not involve shadowing.
8925 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8927 * deps.mk (unexalpha.o): Remove; unused.
8929 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8930 * unexec.h: New file.
8931 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8932 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8934 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8935 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8936 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8937 Change as necessary to match prototype in unexec.h.
8939 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8941 (back_comment, skip_chars): Mark vars as initialized.
8943 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8944 Rename locals to avoid shadowing.
8946 * lread.c (read1): Rewrite so as not to use empty "else".
8947 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8949 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8951 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8952 warning when compiling print.c.
8954 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8955 instead of using an uninitialized var.
8956 (font_sort_entities): Mark var as initialized.
8958 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8960 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8961 pointers to constants.
8962 (font_parse_fcname): Remove unused vars.
8963 (font_delete_unmatched): Now static.
8964 (font_get_spec): Remove; unused.
8965 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8966 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8967 Rename or move locals to avoid shadowing.
8969 * fns.c (require_nesting_list, require_unwind): Now static.
8970 (Ffillarray): Rename locals to avoid shadowing.
8972 * floatfns.c (domain_error2): Define only if needed.
8973 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8975 * alloc.c (mark_backtrace): Move decl from here ...
8976 * lisp.h: ... to here, so that it can be checked.
8978 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8979 (Fdefvar): Rewrite so as not to use empty "else".
8980 (lisp_indirect_variable): Name an expression,
8981 to avoid gcc -Wbad-function-cast warning.
8982 (Fdefvar): Rename locals to avoid shadowing.
8984 * callint.c (quotify_arg, quotify_args): Now static.
8985 (Fcall_interactively): Rename locals to avoid shadowing.
8986 Use const pointer when appropriate.
8988 * lisp.h (get_system_name, get_operating_system_release):
8989 Move decls here, to check interfaces.
8990 * process.c (get_operating_system_release): Move decl to lisp.h.
8991 * xrdb.c (get_system_name): Likewise.
8992 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8993 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8994 some of which prompt warnings from gcc -Wbad-function-cast.
8995 (Fformat_time_string, Fencode_time, Finsert_char):
8996 (Ftranslate_region_internal, Fformat):
8997 Rename or remove local vars to avoid shadowing.
8998 (Ftranslate_region_internal): Mark var as initialized.
9000 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9003 * lisp.h (eassert): Check that the argument compiles, even if
9004 ENABLE_CHECKING is not defined.
9006 * data.c (Findirect_variable): Name an expression, to avoid
9007 gcc -Wbad-function-cast warning.
9008 (default_value, arithcompare, arith_driver, arith_error): Now static.
9009 (store_symval_forwarding): Rename local to avoid shadowing.
9010 (Fmake_variable_buffer_local, Fmake_local_variable):
9011 Mark variables as initialized.
9012 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9014 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9015 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9016 Rename locals to avoid shadowing.
9017 (mark_stack): Move local variables into the #ifdef region where
9019 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9020 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9022 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9023 (GC_STRING_CHARS): Remove; not used.
9024 (Fmemory_limit): Cast sbrk's returned value to char *.
9026 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9027 avoids undefined behavior in theory.
9029 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9031 Use functions, not macros, for up- and down-casing (Bug#8254).
9032 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9033 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9034 to use the following functions instead of these macros.
9035 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9036 EMACS_INT, since callers assume the returned value fits in int.
9037 (upcase1): Likewise, for UPCASE_TABLE.
9038 (uppercasep, lowercasep, upcase): New static inline functions.
9039 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9040 the race-condition problem in the old DOWNCASE.
9042 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9043 Rename locals to avoid shadowing.
9044 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9045 (regex_compile, re_search_2, re_match_2_internal):
9046 Remove unused local vars.
9047 (FREE_VAR): Rewrite so as not to use empty "else",
9048 which gcc can warn about.
9049 (regex_compile, re_match_2_internal): Mark locals as initialized.
9050 (RETALLOC_IF): Define only if needed.
9051 (WORDCHAR_P): Likewise. This one is never needed, but is used
9052 only in a comment talking about a compiler bug, so put inside
9053 the #if 0 of that comment.
9054 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9055 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9058 * search.c (boyer_moore): Rename locals to avoid shadowing.
9059 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9060 (PREV_CHAR_BOUNDARY): Likewise.
9062 * search.c (simple_search): Remove unused var.
9064 * dired.c (compile_pattern): Move decl from here ...
9065 * lisp.h: ... to here, so that it can be checked.
9066 (struct re_registers): New forward decl.
9068 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9070 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9072 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9073 Rename locals to avoid shadowing.
9074 (Fvertical_motion): Mark locals as initialized.
9076 * casefiddle.c (casify_object, casify_region): Now static.
9077 (casify_region): Mark local as initialized.
9079 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9081 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9082 New macros, so that the caller can use some names other than
9083 gcpro1, gcpro2, etc.
9084 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9086 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9087 argument, for consistency with GCPRO2_VAR, etc: it is now the
9088 prefix of the variable, not the variable itself. All uses
9090 * dired.c (directory_files_internal, file_name_completion):
9091 Rename locals to avoid shadowing.
9093 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9094 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9095 dired.c's scmp function, had undefined behavior.
9096 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9097 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9098 * buffer.h: ... to here, because these macros use current_buffer,
9099 and the new implementation with inline functions needs to have
9100 current_buffer in scope now, rather than later when the macros
9102 (downcase, upcase1): New static inline functions.
9103 (DOWNCASE, UPCASE1): Reimplement using these functions.
9104 This avoids undefined behavior in expressions like
9105 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9106 from race conditions in accessing the global variables
9107 case_temp1 and case_temp2.
9108 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9109 * lisp.h (case_temp1, case_temp2): Remove their decls.
9110 * character.h (ASCII_CHAR_P): Move from here ...
9111 * lisp.h: ... to here, so that the inline functions mentioned
9114 * dired.c (directory_files_internal_unwind): Now static.
9116 * fileio.c (file_name_as_directory, directory_file_name):
9117 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9119 (file_name_as_directory): Use const pointers when appropriate.
9120 (Fexpand_file_name): Likewise. In particular, newdir might
9121 point at constant storage, so make it a const pointer.
9122 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9123 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9125 (Fset_file_times, Finsert_file_contents, auto_save_error):
9126 Rename locals to avoid shadowing.
9128 * minibuf.c (choose_minibuf_frame_1): Now static.
9129 (Ftry_completion, Fall_completions): Rename or remove locals
9132 * marker.c (bytepos_to_charpos): Remove; unused.
9134 * lisp.h (verify_bytepos, count_markers): New decls,
9135 so that gcc does not warn that these functions aren't declared.
9137 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9138 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9139 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9140 (copy_text): Remove unused local var.
9142 * filelock.c (within_one_second): Now static.
9143 (lock_file_1): Rename local to avoid shadowing.
9145 * buffer.c (fix_overlays_before): Mark locals as initialized.
9146 (fix_start_end_in_overlays): Likewise. This function should be
9147 simplified by using pointers-to-pointers, but that's a different
9149 (switch_to_buffer_1): Now static.
9150 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9151 (report_overlay_modification): Rename locals to avoid shadowing.
9153 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9154 Fix pointer signedness issue.
9155 (sys_subshell): Mark local as volatile if checking for lint,
9156 to suppress a gcc -Wclobbered warning that does not seem to be right.
9157 (MAXPATHLEN): Define only if needed.
9159 * process.c (serial_open, serial_configure): Move decls from here ...
9160 * systty.h: ... to here, so that they can be checked.
9162 * fns.c (get_random, seed_random): Move extern decls from here ...
9163 * lisp.h: ... to here, so that they can be checked.
9165 * sysdep.c (reset_io): Now static.
9166 (wait_for_termination_signal): Remove; unused.
9168 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9169 (copy_keymap_item, append_key, push_text_char_description):
9171 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9172 (DENSE_TABLE_SIZE): Remove; unused.
9173 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9174 (describe_map_tree):
9175 Rename locals to avoid shadowing.
9177 * keyboard.c: Declare functions static if they are not used elsewhere.
9178 (echo_char, echo_dash, cmd_error, top_level_2):
9179 (poll_for_input, handle_async_input): Now static.
9180 (read_char, kbd_buffer_get_event, make_lispy_position):
9181 (make_lispy_event, make_lispy_movement, apply_modifiers):
9182 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9183 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9184 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9185 (read_key_sequence, read_char): Mark locals as initialized.
9186 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9188 * keyboard.h (make_ctrl_char): New decl.
9189 (mark_kboards): Move decl here ...
9190 * alloc.c (mark_kboards): ... from here.
9192 * lisp.h (force_auto_save_soon): New decl.
9194 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9195 (DEFINE_DUMMY_FUNCTION): New macro.
9196 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9198 (main): Add casts to avoid warnings
9199 if GCC considers string literals to be constants.
9201 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9203 * dbusbind.c: Pointer signedness fixes.
9204 (xd_signature, xd_append_arg, xd_initialize):
9205 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9206 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9207 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9208 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9210 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9211 if GCC considers string literals to be constants.
9212 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9214 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9216 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9217 (print_preprocess, print_object): New macro to fix last change.
9219 * print.c (print_preprocess): Don't forget font objects.
9221 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9223 * emacs.c (USAGE3): Doc fixes.
9225 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9227 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9230 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9232 * lisp.h (VWindow_system, Qfile_name_history):
9233 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9234 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9235 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9237 * w32select.c: Don't #include "keyboard.h".
9238 (run_protected): Add extern declaration for waiting_for_input.
9240 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9241 * w32console.c (detect_input_pending, read_input_pending)
9242 (encode_terminal_code):
9243 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9244 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9245 (w32_system_caret_y, Qfile_name_history):
9246 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9247 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9248 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9249 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9250 * w32proc.c (Qlocal, report_file_error):
9251 * w32term.c (Vwindow_system, updating_frame):
9252 * w32uniscribe.c (initialized, uniscribe_font_driver):
9253 Remove unneeded extern declarations.
9255 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9257 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9259 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9261 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9262 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9263 These macros can no longer be used for assignment.
9265 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9266 Assign struct members directly, instead of using BUF_BEGV etc.
9267 (record_buffer_markers, fetch_buffer_markers): New functions for
9268 recording and fetching special buffer markers.
9269 (set_buffer_internal_1, set_buffer_temp): Use them.
9271 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9273 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9275 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9276 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9278 * xdisp.c (hscroll_window_tree):
9279 (reconsider_clip_changes): Use PT instead of BUF_PT.
9281 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9283 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9284 $(EMACS_ROOT)/lib/intprops.h.
9286 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9288 Fix more problems found by GCC 4.5.2's static checks.
9290 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9291 to unsigned char * to avoid compiler diagnostic.
9292 (xg_free_frame_widgets): Make it clear that a local variable is
9293 needed only if USE_GTK_TOOLTIP.
9294 (gdk_window_get_screen): Make it clear that this macro is needed
9295 only if USE_GTK_TOOLTIP.
9296 (int_gtk_range_get_value): New function, which avoids a diagnostic
9297 from gcc -Wbad-function-cast.
9298 (xg_set_toolkit_scroll_bar_thumb): Use it.
9299 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9300 diagnostic from gcc -Wbad-function-cast.
9301 (get_utf8_string, xg_get_file_with_chooser):
9302 Rename locals to avoid shadowing.
9303 (create_dialog): Move locals to avoid shadowing.
9305 * xgselect.c (xg_select): Remove unused var.
9307 * image.c (four_corners_best): Mark locals as initialized.
9308 (gif_load): Initialize transparent_p to zero (Bug#8238).
9309 Mark another local as initialized.
9310 (my_png_error, my_error_exit): Mark with NO_RETURN.
9312 * image.c (clear_image_cache): Now static.
9313 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9314 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9315 (x_edge_detection): Remove unnecessary cast that
9316 gcc -Wbad-function-cast diagnoses.
9317 (gif_load): Fix pointer signedness.
9318 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9319 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9321 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9323 Improve quality of tests for time stamp overflow.
9324 For example, without this patch (encode-time 0 0 0 1 1
9325 1152921504606846976) returns the obviously-bogus value (-948597
9326 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9327 reports time overflow. See
9328 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9329 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9330 * editfns.c: Include limits.h and intprops.h.
9331 (TIME_T_MIN, TIME_T_MAX): New macros.
9332 (time_overflow): Move earlier, to before first use.
9333 (hi_time, lo_time): New functions, for an accurate test for
9335 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9336 (Fget_internal_run_time): Don't assume time_t fits in int.
9337 (make_time): Use list2 instead of Fcons twice.
9338 (Fdecode_time): More accurate test for out-of-range times.
9339 (check_tm_member): New function.
9340 (Fencode_time): Use it, to test for out-of-range times.
9341 (lisp_time_argument): Don't rely on undefined left-shift and
9342 right-shift behavior when checking for time stamp overflow.
9344 * editfns.c (time_overflow): New function, refactoring common code.
9345 (Fformat_time_string, Fdecode_time, Fencode_time):
9346 (Fcurrent_time_string): Use it.
9348 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9349 * dired.c (make_time): Move to ...
9350 * editfns.c (make_time): ... here.
9351 * systime.h: Note the move.
9353 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9355 * fringe.c (update_window_fringes): Remove unused variables.
9357 * unexmacosx.c (copy_data_segment): Also copy __got section.
9360 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9362 * termcap.c [MSDOS]: Include "msdos.h".
9363 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9364 Constify `char *' arguments and their references according to
9365 prototypes in tparam.h.
9367 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9369 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9370 Adapt all references accordingly.
9372 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9374 2011-03-11 Tom Tromey <tromey@redhat.com>
9376 * buffer.c (syms_of_buffer): Remove obsolete comment.
9378 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9380 * termhooks.h (encode_terminal_code): Declare prototype.
9382 * msdos.c (encode_terminal_code): Don't declare prototype.
9384 * term.c (encode_terminal_code): Now external again, used by
9385 w32console.c and msdos.c.
9387 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9388 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9390 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9392 Fix some minor problems found by GCC 4.5.2's static checks.
9394 * fringe.c (update_window_fringes): Mark locals as initialized
9396 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9398 * alloc.c (mark_fringe_data): Move decl from here ...
9399 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9400 to check its interface.
9401 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9403 * fontset.c (free_realized_fontset): Now static.
9404 (Fset_fontset_font): Rename local to avoid shadowing.
9405 (fontset_font): Mark local as initialized.
9406 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9408 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9410 * xselect.c (x_disown_buffer_selections): Remove; not used.
9411 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9412 (x_own_selection, Fx_disown_selection_internal): Rename locals
9414 (x_handle_dnd_message): Remove local to avoid shadowing.
9416 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9417 so that the caller can use some name other than gcpro1.
9418 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9419 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9420 (Fx_backspace_delete_keys_p):
9421 Use them to avoid shadowing, and rename vars to avoid shadowing.
9422 (x_decode_color, x_set_name, x_window): Now static.
9423 (Fx_create_frame): Add braces to silence GCC warning.
9424 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9425 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9426 Remove unused locals.
9427 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9428 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9429 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9432 * xterm.h (x_mouse_leave): New decl.
9434 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9435 Remove unused functions.
9436 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9437 (x_calc_absolute_position): Now static.
9438 (XTread_socket): Don't define label "out" unless it's used.
9439 Don't declare local "event" unless it's used.
9440 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9441 unless they are used.
9442 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9443 (x_fatal_error_signal): Remove; not used.
9444 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9445 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9446 (x_error_catcher, x_connection_closed, x_error_handler):
9447 (x_error_quitter, xembed_send_message, x_iconify_frame):
9448 (my_log_handler): Rename locals to avoid shadowing.
9449 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9450 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9452 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9453 Rename or move locals to avoid shadowing.
9454 (tty_defined_color, merge_face_heights): Now static.
9455 (free_realized_faces_for_fontset): Remove; not used.
9456 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9457 does not deduce is never used uninitialized.
9458 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9459 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9461 * terminal.c (store_terminal_param): Now static.
9463 * xmenu.c (menu_highlight_callback): Now static.
9464 (set_frame_menubar): Remove unused local.
9465 (xmenu_show): Rename parameter to avoid shadowing.
9466 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9467 since they might point to immutable storage.
9468 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9469 since it's unused otherwise.
9471 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9472 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9473 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9474 avoids a gcc -Wuninitialized diagnostic.
9475 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9476 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9477 does not deduce are never used uninitialized.
9479 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9481 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9482 * window.c (window_loop, size_window):
9483 (run_window_configuration_change_hook, enlarge_window): Likewise.
9485 * window.c (display_buffer): Now static.
9486 (size_window): Mark variables that gcc -Wuninitialized
9487 does not deduce are never used uninitialized.
9488 * window.h (check_all_windows): New decl, to forestall
9489 gcc -Wmissing-prototypes diagnostic.
9490 * dispextern.h (bidi_dump_cached_states): Likewise.
9492 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9494 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9496 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9497 and to avoid gcc -Wuninitialized warning.
9498 (load_charset_map): Mark variables that gcc -Wuninitialized
9499 does not deduce are never used uninitialized.
9500 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9502 * coding.c (coding_set_source, coding_set_destination):
9503 Use "else { /* comment */ }" rather than "else /* comment */;"
9504 for clarity, and to avoid gcc -Wempty-body warning.
9505 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9506 a block, when the outer 'i' will do.
9507 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9508 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9509 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9510 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9511 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9512 Rename locals to avoid shadowing.
9513 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9514 * coding.c (emacs_mule_char, encode_invocation_designation):
9515 Now static, since they're not used elsewhere.
9516 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9517 (decode_coding_object, encode_coding_object, detect_coding_system):
9518 (decode_coding_emacs_mule): Mark variables that gcc
9519 -Wuninitialized does not deduce are never used uninitialized.
9520 (detect_coding_iso_2022): Initialize a local variable that might
9521 be used uninitialized. Leave a FIXME because it's not clear that
9522 this initialization is needed. (Bug#8211)
9523 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9524 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9525 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9526 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9527 Remove unused macros.
9529 * category.c (hash_get_category_set): Remove unused local var.
9530 (copy_category_table): Now static, since it's not used elsewhere.
9531 * character.c (string_count_byte8): Likewise.
9533 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9534 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9536 * chartab.c (copy_sub_char_table): Now static, since it's not used
9538 (sub_char_table_ref_and_range, char_table_ref_and_range):
9539 Rename locals to avoid shadowing.
9540 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9542 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9543 (BIDI_BOB): Remove unused macro.
9545 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9546 deduce are never used uninitialized.
9547 * term.c (encode_terminal_code): Likewise.
9549 * term.c (encode_terminal_code): Now static. Remove unused local.
9551 * tparam.h: New file.
9552 * term.c, tparam.h: Include it.
9553 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9554 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9555 Move these decls to tparam.h, and make them agree with what
9556 is actually in tparam.c. The previous trick of using incompatible
9557 decls in different modules does not conform to the C standard.
9558 All callers of tparam changed to use tparam's actual API.
9559 * tparam.c (tparam1, tparam, tgoto):
9560 Use const pointers where appropriate.
9562 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9563 * cm.h (struct cm): Likewise.
9564 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9565 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9566 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9567 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9568 (turn_on_face, init_tty): Likewise.
9569 * termchar.h (struct tty_display_info): Likewise.
9571 * term.c (term_mouse_position): Rename local to avoid shadowing.
9573 * alloc.c (mark_ttys): Move decl from here ...
9574 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9576 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9578 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9580 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9582 * search.c (compile_pattern_1): Remove argument regp, unused since
9583 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9584 (compile_pattern): Don't pass it.
9586 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9588 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9589 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9591 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9593 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9595 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9596 gdk_window_get_screen, gdk_window_get_geometry,
9597 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9598 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9599 (xg_get_pixbuf_from_pixmap): New function.
9600 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9601 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9602 Call xg_get_pixbuf_from_pixmap instead of
9603 gdk_pixbuf_get_from_drawable.
9604 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9605 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9606 (xg_check_special_colors): Use GtkStyleContext and its functions
9608 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9609 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9610 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9611 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9612 Call gtk_widget_get_preferred_size.
9613 (xg_frame_resized): gdk_window_get_geometry only takes 5
9615 (xg_win_to_widget, xg_event_is_for_menubar):
9616 Call gdk_x11_window_lookup_for_display.
9617 (xg_set_widget_bg): New function.
9618 (delete_cb): New function.
9619 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9620 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9621 (xg_set_background_color): Call xg_set_widget_bg.
9622 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9623 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9624 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9625 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9627 (update_frame_tool_bar): Call gtk_widget_hide.
9628 (xg_initialize): Use GDK_KEY_g.
9630 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9632 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9634 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9635 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9636 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9638 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9640 * w32xfns.c (select_palette): Check success of RealizePalette against
9641 GDI_ERROR, not zero.
9643 See ChangeLog.11 for earlier changes.
9649 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9651 This file is part of GNU Emacs.
9653 GNU Emacs is free software: you can redistribute it and/or modify
9654 it under the terms of the GNU General Public License as published by
9655 the Free Software Foundation, either version 3 of the License, or
9656 (at your option) any later version.
9658 GNU Emacs is distributed in the hope that it will be useful,
9659 but WITHOUT ANY WARRANTY; without even the implied warranty of
9660 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9661 GNU General Public License for more details.
9663 You should have received a copy of the GNU General Public License
9664 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.