* ftfont.c: Check for size overflow.
[bpt/emacs.git] / src / ChangeLog
1 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2
3 * ftfont.c: Check for size overflow.
4 (ftfont_get_open_type_spec, setup_otf_gstring, ftfont_shape_by_flt):
5 Check for integer overflow in size calculations.
6
7 * fringe.c (Fdefine_fringe_bitmap): Don't update size until alloc works.
8
9 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
10 This is for the members text_lines, text_cols, total_lines, total_cols,
11 where the system imposes an 'int' limit.
12
13 * frame.c: Integer overflow fixes.
14 (set_menu_bar_lines, x_set_frame_parameters, x_set_scroll_bar_width)
15 (x_figure_window_size): Check for integer overflow.
16 (x_set_alpha): Do not assume XINT fits in int.
17
18 * eval.c: Integer and memory overflow fixes.
19 (init_eval_once, grow_specpdl): Don't update size until alloc succeeds.
20 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
21
22 * emacs.c (main, sort_args): Check for size-calculation overflow.
23
24 * editfns.c: Integer and memory overflow fixes.
25 (set_time_zone_rule): Don't assume environment length fits in int.
26 (message_length): Now ptrdiff_t, not int.
27 (Fmessage_box): Don't update size until allocation succeeds.
28 Don't assume message length fits in int.
29 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
30
31 * doc.c: Integer and memory overflow fixes.
32 (get_doc_string_buffer_size): Now ptrdiff_t, not int.
33 (get_doc_string): Check for size calculation overflow.
34 Don't update size until allocation succeeds.
35 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
36 EMACS_INT, where ptrdiff_t will do.
37 (Fsubstitute_command_keys): Check for string overflow.
38
39 Integer and memory overflow fixes for display code.
40 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
41 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool, scrolling_window):
42 Check for overflow in size calculations.
43 (line_draw_cost, realloc_glyph_pool, add_row_entry):
44 Don't assume glyph table len fits in int.
45 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
46 (row_table_size): Now ptrdiff_t, not int.
47 (scrolling_window): Avoid overflow in size calculations.
48 Don't update size until allocation succeeds.
49 * fns.c (concat): Check for overflow in size calculations.
50 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
51 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
52 (NEXT_ALMOST_PRIME_LIMIT): New constant.
53
54 * composite.c: Integer overflow fixes.
55 (get_composition_id): Check for overflow in glyph length calculations.
56
57 * coding.c: Integer and memory overflow fixes.
58 (produce_chars): Redo buffer-overflow calculations to avoid
59 unnecessary integer overflow. Check for size overflow.
60 (encode_coding_object): Don't update size until xmalloc succeeds.
61
62 * character.c (Fstring): Check for size-calculation overflow.
63
64 * ccl.c: Integer and memory overflow fixes.
65 (Fccl_execute_on_string): Check for memory overflow.
66 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
67 Redo buffer-overflow calculations to avoid integer overflow.
68
69 * callproc.c (child_setup): Don't assume strlen fits in int.
70
71 * buffer.c: Memory overflow fixes.
72 (overlays_at, overlays_in, record_overlay_string, overlay_strings):
73 Don't update size of array until after memory allocation succeeds,
74 because xmalloc/xrealloc may not return.
75
76 * bidi.c: Integer overflow fix.
77 (bidi_shelve_header_size): New constant.
78 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
79 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
80
81 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
82
83 Use ptrdiff_t for composition IDs.
84 * character.c (lisp_string_width):
85 * composite.c (composition_table_size, n_compositions)
86 (get_composition_id, composition_gstring_from_id):
87 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
88 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
89 * window.c (Frecenter):
90 Use ptrdiff_t, not int, for composition IDs.
91 * composite.c (get_composition_id): Check for integer overflow.
92 * composite.h: Adjust prototypes to match the above changes.
93
94 Use ptrdiff_t for hash table indexes.
95 * category.c (hash_get_category_set):
96 * ccl.c (ccl_driver):
97 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
98 * coding.c (coding_system_charset_list, detect_coding_system):
99 * coding.h (struct coding_system.id):
100 * composite.c (get_composition_id, gstring_lookup_cache):
101 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
102 * image.c (xpm_get_color_table_h):
103 * lisp.h (hash_lookup, hash_put):
104 * minibuf.c (Ftest_completion):
105 Use ptrdiff_t for hash table indexes, not int (which is too
106 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
107 32-bit --with-wide-int hosts).
108
109 * charset.c (Fdefine_charset_internal): Check for integer overflow.
110 Add a FIXME comment about memory leaks.
111 (syms_of_charset): Don't assume xmalloc returns.
112
113 Don't assume that stated character widths fit in int.
114 * character.c (Fchar_width, c_string_width, lisp_string_width):
115 * character.h (CHAR_WIDTH):
116 * indent.c (MULTIBYTE_BYTES_WIDTH):
117 Use sanitize_char_width to avoid undefined and/or bad behavior
118 with outlandish widths.
119 * character.h (sanitize_tab_width): Renamed from sanitize_width,
120 now that we have two such functions. All uses changed.
121 (sanitize_char_width): New inline function.
122
123 Don't assume that tab-width fits in int.
124 * character.h (sanitize_width): New inline function.
125 (SANE_TAB_WIDTH): New macro.
126 (ASCII_CHAR_WIDTH): Use it.
127 * indent.c (sane_tab_width): Remove. All uses replaced by
128 SANE_TAB_WIDTH (current_buffer).
129 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
130
131 * fileio.c: Integer overflow issues with file modes.
132 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
133
134 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
135 Remove unreachable code.
136 (read_hex, load_charset_map_from_file): Check for integer overflow.
137
138 * xterm.c: don't go over XClientMessageEvent limit
139 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
140 (x_send_scroll_bar_event): Likewise. Check that the size does not
141 exceed limits imposed by XClientMessageEvent, as well as the usual
142 ptrdiff_t and size_t limits.
143
144 * keyboard.c: Overflow, signedness and related fixes.
145 (make_lispy_movement): Use same integer type in forward decl
146 that is used in the definition.
147 (read_key_sequence, keyremap_step):
148 Change bufsize argument back to int, undoing my 2011-03-30 change.
149 We prefer signed types, and int is wide enough here.
150 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
151 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
152 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
153 length, not size_t. Use ptrdiff_t for index, not int.
154 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
155 possibility of integer overflow.
156
157 Overflow, signedness and related fixes for images.
158
159 * dispextern.h (struct it.stack[0].u.image.image_id)
160 (struct_it.image_id, struct image.id, struct image_cache.size)
161 (struct image_cache.used, struct image_cache.ref_count):
162 * gtkutil.c (update_frame_tool_bar):
163 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
164 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
165 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
166 * nsmenu.m (update_frame_tool_bar):
167 * xdisp.c (calc_pixel_width_or_height):
168 * xfns.c (image_cache_refcount):
169 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
170 on typical 64-bit hosts.
171
172 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
173 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
174 Omit unnecessary casts to int.
175 (parse_image_spec): Check that integers fall into 'int' range
176 when the callers expect that.
177 (image_ascent): Redo ascent calculation to avoid int overflow.
178 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
179 (lookup_image): Remove unnecessary tests.
180 (xbm_image_p): Locals are now of int, not EMACS_INT,
181 since parse_image_check makes sure they fit into int.
182 (png_load, gif_load, svg_load_image):
183 Prefer int to unsigned where either will do.
184 (tiff_handler): New function, combining the cores of the
185 old tiff_error_handler and tiff_warning_handler. This
186 function is rewritten to use vsnprintf and thereby avoid
187 stack buffer overflows. It uses only the features of vsnprintf
188 that are common to both POSIX and native Microsoft.
189 (tiff_error_handler, tiff_warning_handler): Use it.
190 (tiff_load, gif_load, imagemagick_load_image):
191 Don't assume :index value fits in 'int'.
192 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
193 (imagemagick_load_image): Check that crop parameters fit into
194 the integer types that MagickCropImage accepts. Don't assume
195 Vimagemagick_render_type has a nonnegative value. Don't assume
196 size_t fits in 'long'.
197 (gs_load): Use printmax_t to print the widest integers possible.
198 Check for integer overflow when computing image height and width.
199
200 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
201
202 Integer signedness and overflow and related fixes. (Bug#9079)
203
204 * bidi.c: Integer size and overflow fixes.
205 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
206 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
207 (bidi_cache_find_level_change, bidi_cache_ensure_space)
208 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
209 (bidi_find_other_level_edge):
210 Use ptrdiff_t instead of EMACS_INT where either will do.
211 This works better on 32-bit hosts configured --with-wide-int.
212 (bidi_cache_ensure_space): Check for size-calculation overflow.
213 Use % rather than repeated addition, for better worst-case speed.
214 Don't set bidi_cache_size until after xrealloc returns, because it
215 might not return.
216 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
217 (bidi_cache_ensure_space): Also check that the bidi cache size
218 does not exceed that of the largest Lisp string or buffer. See Eli
219 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
220
221 * alloc.c (__malloc_size_t): Remove.
222 All uses replaced by size_t. See Andreas Schwab's note
223 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
224
225 * image.c: Improve checking for integer overflow.
226 (check_image_size): Assume that f is nonnull, since
227 it is always nonnull in practice. This is one less thing to
228 worry about when checking for integer overflow later.
229 (x_check_image_size): New function, which checks for integer
230 overflow issues inside X.
231 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
232 This removes the need for a memory_full check.
233 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
234 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
235 (xbm_read_bitmap_data): Change locals back to 'int', since
236 their values must fit in 'int'.
237 (xpm_load_image, png_load, tiff_load):
238 Invoke x_create_x_image_and_pixmap earlier,
239 to avoid much needless work if the image is too large.
240 (tiff_load): Treat overly large images as if
241 x_create_x_image_and_pixmap failed, not as malloc failures.
242 (gs_load): Use x_check_image_size.
243
244 * gtkutil.c: Omit integer casts.
245 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
246 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
247
248 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
249
250 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
251 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
252 would wrongly return t on a 64-bit host.
253
254 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
255 The plain *_OVERFLOW macros run afoul of GCC bug 49705
256 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
257 and therefore cause GCC to emit a bogus diagnostic in some cases.
258
259 * image.c: Integer signedness and overflow and related fixes.
260 This is not an exhaustive set of fixes, but it's time to
261 record what I've got.
262 (lookup_pixel_color, check_image_size): Remove redundant decls.
263 (check_image_size): Don't assume that arbitrary EMACS_INT values
264 fit in 'int', or that arbitrary 'double' values fit in 'int'.
265 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
266 (tiff_load, imagemagick_load_image):
267 Check for overflow in size calculations.
268 (x_create_x_image_and_pixmap): Remove unnecessary test for
269 xmalloc returning NULL; that can't happen.
270 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
271 (xpm_color_bucket): Use better integer hashing function.
272 (xpm_cache_color): Don't possibly over-allocate memory.
273 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
274 (gif_memory_source):
275 Use ptrdiff_t, not int or size_t, to record sizes.
276 (png_load): Don't assume values greater than 2**31 fit in 'int'.
277 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
278 either works, as we prefer signed integers.
279 (tiff_read_from_memory, tiff_write_from_memory):
280 Return tsize_t, not size_t, since that's what the TIFF API wants.
281 (tiff_read_from_memory): Don't fail simply because the read would
282 go past EOF; instead, return a short read.
283 (tiff_load): Omit no-longer-needed casts.
284 (Fimagemagick_types): Don't assume size fits into 'int'.
285
286 Improve hashing quality when configured --with-wide-int.
287 * fns.c (hash_string): New function, taken from sxhash_string.
288 Do not discard information about ASCII character case; this
289 discarding is no longer needed.
290 (sxhash-string): Use it. Change sig to match it. Caller changed.
291 * lisp.h: Declare it.
292 * lread.c (hash_string): Remove, since we now use fns.c's version.
293 The fns.c version returns a wider integer if --with-wide-int is
294 specified, so this should help the quality of the hashing a bit.
295
296 * emacs.c: Integer overflow minor fix.
297 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
298 Define only if GNU_LINUX.
299 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
300
301 * dispnew.c: Integer signedness and overflow fixes.
302 Remove unnecessary forward decls, that were a maintenance hassle.
303 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
304 All uses changed.
305 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
306 (scrolling_window): Use ptrdiff_t, not int, for byte count.
307 (prepare_desired_row, line_draw_cost):
308 Use int, not unsigned, where either works.
309 (save_current_matrix, restore_current_matrix):
310 Use ptrdiff_t, not size_t, where either works.
311 (init_display): Check for overflow more accurately, and without
312 relying on undefined behavior.
313
314 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
315 Remove, replacing with the new symbols in lisp.h. All uses changed.
316 * fileio.c (make_temp_name):
317 * filelock.c (lock_file_1, lock_file):
318 * xdisp.c (message_dolog):
319 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
320 Use pMd etc. instead.
321 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
322 replacing the pWIDE etc. symbols removed from editfns.c.
323
324 * keyboard.h (num_input_events): Now uintmax_t.
325 This is (very slightly) less likely to mess up due to wraparound.
326 All uses changed.
327
328 * buffer.c: Integer signedness fixes.
329 (alloc_buffer_text, enlarge_buffer_text):
330 Use ptrdiff_t rather than size_t when either will do, as we prefer
331 signed integers.
332
333 * alloc.c: Integer signedness and overflow fixes.
334 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
335 (__malloc_size_t): Default to size_t, not to int.
336 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
337 (Fgarbage_collect, mark_object_loop_halt, mark_object):
338 Prefer ptrdiff_t to size_t when either would do, as we prefer
339 signed integers.
340 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
341 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
342 Now const. Initialize with values that are in range even if char
343 is signed.
344 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
345 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
346 These functions do the right thing with sizes > 2**32.
347 (check_depth): Now ptrdiff_t, not int.
348 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
349 Adjust to new way of storing sizes. Check for size overflow bugs
350 in rest of code.
351 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
352 slightly wrong anyway, as it missed one instance of
353 XMALLOC_OVERRUN_CHECK_OVERHEAD.
354 (refill_memory_reserve): Omit needless cast to size_t.
355 (mark_object_loop_halt): Mark as externally visible.
356
357 * xselect.c: Integer signedness and overflow fixes.
358 (Fx_register_dnd_atom, x_handle_dnd_message):
359 Use ptrdiff_t, not size_t, since we prefer signed.
360 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
361 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
362 x_dnd_atoms_size and x_dnd_atoms_length.
363
364 * doprnt.c: Prefer signed to unsigned when either works.
365 * eval.c (verror):
366 * doprnt.c (doprnt):
367 * lisp.h (doprnt):
368 * xdisp.c (vmessage):
369 Use ptrdiff_t, not size_t, when using or implementing doprnt,
370 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
371 prefer signed arithmetic to avoid comparison confusion.
372 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
373 but is a bit tricky.
374
375 Assume freestanding C89 headers, string.h, stdlib.h.
376 * data.c, doprnt.c, floatfns.c, print.c:
377 Include float.h unconditionally.
378 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
379 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
380 * regex.c: Likewise for stddef.h, string.h.
381 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
382 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
383 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
384 (STDC_HEADERS): Remove obsolete defines.
385 * sysdep.c: Include limits.h unconditionally.
386
387 Assume support for memcmp, memcpy, memmove, memset.
388 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
389 * regex.c (memcmp, memcpy):
390 Remove; we assume C89 now.
391
392 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
393 (__malloc_safe_bcopy): Remove; no longer needed.
394
395 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
396 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
397 well either way, and we prefer signed to unsigned.
398
399 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
400
401 Port to OpenBSD.
402 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
403 and the surrounding thread.
404 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
405 rather than fgets, and retry after EINTR. Otherwise, 'emacs
406 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
407 timer goes off.
408 * s/openbsd.h (BROKEN_SIGIO): Define.
409 * unexelf.c (unexec) [__OpenBSD__]:
410 Don't update the .mdebug section of the Alpha COFF symbol table.
411
412 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
413
414 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
415 (bug#8460).
416
417 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
418
419 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
420 This fixes some race conditions on the permissions of any newly
421 created file.
422
423 * alloc.c (valid_pointer_p): Use pipe, not open.
424 This fixes some permissions issues when debugging.
425
426 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
427 If fchown fails to set both uid and gid, try to set just gid,
428 as that is sometimes allowed. Adjust the file's mode to eliminate
429 setuid or setgid bits that are inappropriate if fchown fails.
430
431 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
432
433 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
434 to compare Lisp_Objects.
435 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
436 global_gnutls_log_level, don't mistake it for a Lisp_Object.
437 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
438
439 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
440
441 * lread.c (read_integer): Unread even EOF character.
442 (read1): Likewise. Properly record start position of symbol.
443
444 * lread.c (read1): Read `#:' as empty uninterned symbol if no
445 symbol character follows.
446
447 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
448
449 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
450 This works around a problem with the previous change to Fcopy_file.
451 Recent glibc declares fchown with __attribute__((warn_unused_result)),
452 and without this change, GCC might complain about discarding
453 fchown's return value.
454
455 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
456
457 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
458
459 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
460
461 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
462
463 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
464
465 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
466 it's used from the C level.
467
468 * process.c: Use the same condition for POLL_FOR_INPUT in both
469 keyboard.c and process.c (bug#1858).
470
471 2011-07-09 Lawrence Mitchell <wence@gmx.li>
472
473 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
474 (Fgnutls_boot): Use it.
475
476 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
477
478 * doc.c (Fsubstitute_command_keys): Revert last change.
479
480 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
481
482 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
483 quotes the next character, and doesn't affect other longer
484 sequences (bug#8935).
485
486 * lread.c (syms_of_lread): Clarify that is isn't only
487 `eval-buffer' and `eval-defun' that's affected by
488 `lexical-binding' (bug#8460).
489
490 2011-07-15 Eli Zaretskii <eliz@gnu.org>
491
492 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
493 bidi redisplay when a line includes both an image and is
494 truncated.
495
496 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
497
498 Fix minor problems found by static checking.
499 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
500 (elsz): Now a signed constant, not a size_t var. We prefer signed
501 types to unsigned, to avoid integer comparison confusion. Without
502 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
503 "cannot optimize loop, the loop counter may overflow", a symptom
504 of the confusion.
505 * indent.c (Fvertical_motion): Mark locals as initialized.
506 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
507
508 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
509
510 * search.c (Fre_search_backward): Mention `case-fold-search' in
511 all the re_search_* functions (bug#8138).
512
513 * keyboard.c (Fopen_dribble_file): Document when the file is
514 closed (bug#8056).
515
516 2011-07-14 Eli Zaretskii <eliz@gnu.org>
517
518 * bidi.c (bidi_dump_cached_states): Fix format of displaying
519 bidi_cache_idx.
520
521 Support bidi reordering of display and overlay strings.
522 * xdisp.c (compute_display_string_pos)
523 (compute_display_string_end): Accept additional argument STRING.
524 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
525 (reseat_to_string): Initialize bidi_it->string.s and
526 bidi_it->string.schars.
527 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
528 NULL (avoids a crash in bidi_paragraph_init). Initialize
529 itb.string.lstring.
530 (init_iterator): Call bidi_init_it only of a valid
531 buffer position was specified. Initialize paragraph_embedding to
532 L2R.
533 (reseat_to_string): Initialize the bidi iterator.
534 (display_string): If we need to ignore text properties of
535 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
536 original value of -1 will not work with bidi.)
537 (compute_display_string_pos): First arg is now struct
538 `text_pos *'; all callers changed. Support display properties on
539 Lisp strings.
540 (compute_display_string_end): Support display properties on Lisp
541 strings.
542 (init_iterator, reseat_1, reseat_to_string): Initialize the
543 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
544 when iterating on a string not from display properties).
545 (compute_display_string_pos, compute_display_string_end): Fix
546 calculation of the object to scan. Fixes an error when using
547 arrow keys.
548 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
549 base_level_stop; instead, set base_level_stop to BEGV. Fixes
550 crashes in vertical-motion.
551 (next_element_from_buffer): Improve commentary for when
552 the iterator is before prev_stop.
553 (init_iterator): Initialize bidi_p from the default value of
554 bidi-display-reordering, not from buffer-local value. Use the
555 buffer-local value only if initializing for buffer iteration.
556 (handle_invisible_prop): Support invisible properties on strings
557 that are being bidi-reordered.
558 (set_iterator_to_next): Support bidi reordering of C strings and
559 Lisp strings.
560 (next_element_from_string): Support bidi reordering of Lisp
561 strings.
562 (handle_stop_backwards): Support Lisp strings as well.
563 (display_string): Support display of R2L glyph rows. Use
564 IT_STRING_CHARPOS when displaying from a Lisp string.
565 (init_iterator): Don't initialize it->bidi_p for strings
566 here.
567 (reseat_to_string): Initialize it->bidi_p for strings here.
568 (next_element_from_string, next_element_from_c_string)
569 (next_element_from_buffer): Add xassert's for correspondence
570 between IT's object being iterated and it->bidi_it.string
571 structure.
572 (face_before_or_after_it_pos): Support bidi iteration.
573 (next_element_from_c_string): Handle the case of the first string
574 character that is not the first one in the visual order.
575 (get_visually_first_element): New function, refactored from common
576 parts of next_element_from_buffer, next_element_from_string, and
577 next_element_from_c_string.
578 (tool_bar_lines_needed, redisplay_tool_bar)
579 (display_menu_bar): Force left-to-right direction. Add a FIXME
580 comment for making that be controlled by a user option.
581 (push_it, pop_it): Save and restore the state of the
582 bidi iterator. Save and restore the bidi_p flag.
583 (pop_it): Iterate out of display property for string iteration as
584 well.
585 (iterate_out_of_display_property): Support iteration over strings.
586 (handle_single_display_spec): Set up it->bidi_it for iteration
587 over a display string, and call bidi_init_it.
588 (handle_single_display_spec, next_overlay_string)
589 (get_overlay_strings_1, push_display_prop): Set up the bidi
590 iterator for displaying display or overlay strings.
591 (forward_to_next_line_start): Don't use the shortcut if
592 bidi-iterating.
593 (back_to_previous_visible_line_start): If handle_display_prop
594 pushed the iterator stack, restore the internal state of the bidi
595 iterator by calling bidi_pop_it same number of times.
596 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
597 and we are bidi-iterating, don't decrement the iterator position;
598 instead, set the first_elt flag in the bidi iterator, to produce
599 the same effect.
600 (reseat_1): Remove redundant setting of string_from_display_prop_p.
601 (push_display_prop): xassert that we are iterating a buffer.
602 (push_it, pop_it): Save and restore paragraph_embedding member.
603 (handle_single_display_spec, next_overlay_string)
604 (get_overlay_strings_1, reseat_1, reseat_to_string)
605 (push_display_prop): Set up the `unibyte' member of bidi_it.string
606 correctly. Don't assume unibyte strings are not bidi-reordered.
607 (compute_display_string_pos)
608 (compute_display_string_end): Fix handling the case of C string.
609 (push_it, pop_it): Save and restore from_disp_prop_p.
610 (handle_single_display_spec, push_display_prop): Set the
611 from_disp_prop_p flag.
612 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
613 (pop_it): Call iterate_out_of_display_property only if we are
614 popping after iteration over a string that came from a display
615 property. Fix a typo in popping stretch info. Add an assertion
616 for verifying that the iterator position is in sync with the bidi
617 iterator.
618 (handle_single_display_spec, get_overlay_strings_1)
619 (push_display_prop): Fix initialization of paragraph direction for
620 string when that of the parent object is not yet determined.
621 (reseat_1): Call bidi_init_it to resync the bidi
622 iterator with IT's position. (Bug#7616)
623 (find_row_edges): If ROW->start.pos gives position
624 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
625 (handle_stop, back_to_previous_visible_line_start, reseat_1):
626 Reset the from_disp_prop_p flag.
627 (SAVE_IT, RESTORE_IT): New macros.
628 (pos_visible_p, face_before_or_after_it_pos)
629 (back_to_previous_visible_line_start)
630 (move_it_in_display_line_to, move_it_in_display_line)
631 (move_it_to, move_it_vertically_backward, move_it_by_lines)
632 (try_scrolling, redisplay_window, display_line): Use them when
633 saving a temporary copy of the iterator and restoring it back.
634 (back_to_previous_visible_line_start, reseat_1)
635 (init_iterator): Empty the bidi cache "stack".
636 (move_it_in_display_line_to): If iterator ended up at
637 EOL, but we never saw any buffer positions smaller than
638 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
639 motion in bidi-reordered lines.
640 (move_it_in_display_line_to): Record prev_method and prev_pos
641 immediately before the call to set_iterator_to_next. Fixes cursor
642 motion in bidi-reordered lines with stretch glyphs and strings
643 displayed in margins. (Bug#8133) (Bug#8867)
644 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
645 TO_CHARPOS.
646 (pos_visible_p): Support positions in bidi-reordered lines. Save
647 and restore bidi cache.
648
649 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
650 (bidi_paragraph_info): Delete unused struct.
651 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
652 (bidi_cache_start): New variable.
653 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
654 to zero.
655 (bidi_cache_fetch_state, bidi_cache_search)
656 (bidi_cache_find_level_change, bidi_cache_iterator_state)
657 (bidi_cache_find, bidi_peek_at_next_level)
658 (bidi_level_of_next_char, bidi_find_other_level_edge)
659 (bidi_move_to_visually_next): Compare cache index with
660 bidi_cache_start rather than with zero.
661 (bidi_fetch_char): Accept new argument STRING; all callers
662 changed. Support iteration over a string. Support strings with
663 display properties. Support unibyte strings. Fix the type of
664 `len' according to what STRING_CHAR_AND_LENGTH expects.
665 (bidi_paragraph_init, bidi_resolve_explicit_1)
666 (bidi_resolve_explicit, bidi_resolve_weak)
667 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
668 iteration over a string.
669 (bidi_set_sor_type, bidi_resolve_explicit_1)
670 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
671 can now be zero (for strings); special values 0 and -1 were
672 changed to -1 and -2, respectively.
673 (bidi_char_at_pos): New function.
674 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
675 Call it instead of FETCH_MULTIBYTE_CHAR.
676 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
677 initialized to valid values.
678 (bidi_init_it): Don't initialize charpos and bytepos with invalid
679 values.
680 (bidi_level_of_next_char): Allow the sentinel "position" to pass
681 the test for valid cached positions. Fix the logic for looking up
682 the sentinel state in the cache. GCPRO the Lisp string we are
683 iterating.
684 (bidi_push_it, bidi_pop_it): New functions.
685 (bidi_initialize): Initialize the bidi cache start stack pointer.
686 (bidi_cache_ensure_space): New function, refactored from part of
687 bidi_cache_iterator_state. Don't assume the required size is just
688 one BIDI_CACHE_CHUNK away.
689 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
690 (bidi_count_bytes, bidi_char_at_pos): New functions.
691 (bidi_cache_search): Don't assume bidi_cache_last_idx is
692 always valid if bidi_cache_idx is valid.
693 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
694 is valid if it's going to be used.
695 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
696 (bidi_cache_fetch_state, bidi_cache_search)
697 (bidi_cache_find_level_change, bidi_cache_ensure_space)
698 (bidi_cache_iterator_state, bidi_cache_find)
699 (bidi_find_other_level_edge, bidi_cache_start_stack): All
700 variables related to cache indices are now EMACS_INT.
701
702 * dispextern.h (struct bidi_string_data): New structure.
703 (struct bidi_it): New member `string'. Make flag members be 1-bit
704 fields, and put them last in the struct.
705 (compute_display_string_pos, compute_display_string_end): Update
706 prototypes.
707 (bidi_push_it, bidi_pop_it): Add prototypes.
708 (struct iterator_stack_entry): New members bidi_p,
709 paragraph_embedding, and from_disp_prop_p.
710 (struct it): Member bidi_p is now a bit field 1 bit wide.
711 (bidi_shelve_cache, bidi_unshelve_cache): Declare
712 prototypes.
713
714 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
715 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
716 and vector-like objects.
717
718 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
719 cache around display iteration.
720
721 * window.c (Fwindow_end, window_scroll_pixel_based)
722 (displayed_window_lines, Frecenter): Save and restore the bidi
723 cache around display iteration.
724
725 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
726
727 * editfns.c (Fdelete_region): Clarify the use of the named
728 parameters (bug#6788).
729
730 2011-07-14 Martin Rudalics <rudalics@gmx.at>
731
732 * indent.c (Fvertical_motion): Set and restore w->pointm when
733 saving and restoring the window's buffer (Bug#9006).
734
735 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
736
737 * editfns.c (Fstring_to_char): Clarify just what is returned
738 (bug#6576). Text by Eli Zaretskii.
739
740 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
741
742 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
743
744 2011-07-13 Eli Zaretskii <eliz@gnu.org>
745
746 * buffer.c (mmap_find): Fix a typo.
747
748 2011-07-13 Johan Bockgård <bojohan@gnu.org>
749
750 Fix execution of x selection hooks.
751 * xselect.c (Qx_lost_selection_functions)
752 (Qx_sent_selection_functions): New vars.
753 (syms_of_xselect): DEFSYM them.
754 (x_handle_selection_request): Pass Qx_sent_selection_functions
755 rather than Vx_sent_selection_functions to Frun_hook_with_args.
756 (x_handle_selection_clear,x_clear_frame_selections):
757 Pass Qx_lost_selection_functions rather than
758 Vx_lost_selection_functions to Frun_hook_with_args.
759
760 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
761
762 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
763 The old code sometimes used this field without initializing it.
764
765 * alloc.c (gc_sweep): Don't read past end of array.
766 In theory, the old code could also have corrupted Emacs internals,
767 though it'd be very unlikely.
768
769 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
770
771 * character.c (Fcharacterp): Don't advertise optional ignored
772 argument. (Bug#4026)
773
774 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
775
776 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
777 key" (bug#4257).
778
779 * window.c (Fset_window_start): Doc fix (bug#4199).
780 (Fset_window_hscroll): Ditto.
781
782 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
783
784 Fix minor new problems caught by GCC 4.6.1.
785 * term.c (init_tty): Remove unused local.
786 * xsettings.c (store_monospaced_changed): Define this function only
787 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
788 not used otherwise.
789
790 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
791
792 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
793
794 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
795
796 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
797 are the mini-buffer and the echo area (bug#3320).
798
799 * term.c (init_tty): Remove support for supdup, c10 and perq
800 terminals, which are no longer supported (bug#1482).
801
802 2011-07-10 Johan Bockgård <bojohan@gnu.org>
803
804 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
805
806 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
807
808 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
809 for non-popups (Bug#3642).
810
811 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
812
813 * alloc.c (reset_malloc_hooks): Protoize.
814 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
815 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
816 * cm.c (losecursor): Likewise.
817 * data.c (fmod): Likewise.
818 * dispnew.c (swap_glyphs_in_rows): Likewise.
819 * emacs.c (memory_warning_signal): Likewise.
820 * floatfns.c (float_error): Likewise.
821 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
822 (otf_open, font_otf_capability, generate_otf_features)
823 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
824 Likewise.
825 * image.c (pbm_read_file): Likewise.
826 * indent.c (string_display_width): Likewise.
827 * intervals.c (check_for_interval, search_for_interval)
828 (inc_interval_count, count_intervals, root_interval)
829 (adjust_intervals_for_insertion, make_new_interval): Likewise.
830 * lread.c (defalias): Likewise.
831 * ralloc.c (r_alloc_check): Likewise.
832 * regex.c (set_image_of_range_1, set_image_of_range)
833 (regex_grow_registers): Likewise.
834 * sysdep.c (strerror): Likewise.
835 * termcap.c (valid_filename_p, tprint, main): Likewise.
836 * tparam.c (main): Likewise.
837 * unexhp9k800.c (run_time_remap, save_data_space)
838 (update_file_ptrs, read_header, write_header, calculate_checksum)
839 (copy_file, copy_rest, display_header): Likewise.
840 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
841 Likewise.
842 * xdisp.c (check_it): Likewise.
843 * xfaces.c (register_color, unregister_color, unregister_colors):
844 Likewise.
845 * xfns.c (print_fontset_result): Likewise.
846 * xrdb.c (member, fatal, main): Likewise.
847
848 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
849
850 Fix minor problems found by static checking (Bug#9031).
851 * chartab.c (char_table_set_range, map_sub_char_table):
852 Remove unused locals.
853 (uniprop_table): Now static.
854 * composite.c (_work_char): Remove unused static var.
855
856 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
857
858 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
859
860 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
861
862 * gtkutil.c (qttip_cb): Remove code without function.
863
864 2011-07-09 Eli Zaretskii <eliz@gnu.org>
865
866 * w32.c (pthread_sigmask): New stub.
867
868 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
869
870 Use pthread_sigmask, not sigprocmask (Bug#9010).
871 sigprocmask is portable only for single-threaded applications, and
872 Emacs can be multi-threaded when it uses GTK.
873 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
874 (LIBES): Use it.
875 * callproc.c (Fcall_process):
876 * process.c (create_process):
877 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
878 Use pthread_sigmask, not sigprocmask.
879
880 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
881
882 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
883 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
884 wrong (Bug#8591).
885
886 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
887
888 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
889 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
890 (xg_hide_tooltip): Fix comment.
891
892 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
893 in registerServicesMenuSendTypes.
894 (validRequestorForSendType): Don't check ns_return_types.
895
896 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
897 ns_return_type.
898
899 2011-07-08 Jason Rumney <jasonr@gnu.org>
900
901 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
902 frame struct members of non-existent frames (Bug#6284).
903
904 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
905
906 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
907 variable firstTime not needed on OSX >= 10.6.
908 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
909 >= 10.5. Use setKnobProportion, setDoubleValue.
910
911 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
912 (MAC_OS_X_VERSION_10_5): Define if not defined.
913 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
914 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
915 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
916
917 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
918 cString and lossyCString on OSX >= 10.4
919
920 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
921 sizeToFit on OSX >= 10.2.
922
923 * nsimage.m (allocInitFromFile): Don't use deprecated method
924 bestRepresentationForDevice on OSX >= 10.6.
925
926 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
927 to avoid warning.
928
929 * emacs.c: Declare unexec_init_emacs_zone.
930
931 * nsgui.h: Fix compiler warning about gnulib redefining verify.
932
933 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
934
935 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
936 on svcsMenu (Bug#8842).
937
938 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
939 ns_return_types.
940 (Fns_list_services): Just return Qnil on 10.6, code not working there.
941
942 * nsterm.m (QUTF8_STRING): Declare.
943 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
944 (validRequestorForSendType): Return type is (id).
945 Change indexOfObjectIdenticalTo to indexOfObject.
946 Check if we have local selection before returning self (Bug#8842).
947 (writeSelectionToPasteboard): Put local selection into paste board
948 if we have a local selection (Bug#8842).
949 (syms_of_nsterm): DEFSYM QUTF8_STRING.
950
951 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
952 (ns_get_local_selection): Declare.
953
954 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
955
956 * keymap.c (describe_map_tree): Don't insert a double newline at
957 the end of the buffer (bug#1169) and return whether we inserted
958 something.
959
960 * callint.c (Fcall_interactively): Change "reading args" to
961 "providing args" to try to clarify what it does (bug#1010).
962
963 2011-07-07 Kenichi Handa <handa@m17n.org>
964
965 * composite.c (composition_compute_stop_pos): Ignore a static
966 composition starting before CHARPOS (Bug#8915).
967
968 * xdisp.c (handle_composition_prop): Likewise.
969
970 2011-07-07 Eli Zaretskii <eliz@gnu.org>
971
972 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
973 (Bug#9015)
974
975 2011-07-07 Kenichi Handa <handa@m17n.org>
976
977 * character.h (unicode_category_t): New enum type.
978
979 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
980 (Qchar_code_property_table): New variable.
981 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
982 (UNIPROP_COMPRESSED_FORM_P): New macros.
983 (char_table_ascii): Uncompress the compressed values.
984 (sub_char_table_ref): New arg is_uniprop. Callers changed.
985 Uncompress the compressed values.
986 (sub_char_table_ref_and_range): Likewise.
987 (char_table_ref_and_range): Uncompress the compressed values.
988 (sub_char_table_set): New arg is_uniprop. Callers changed.
989 Uncompress the compressed values.
990 (sub_char_table_set_range): Args changed. Callers changed.
991 (char_table_set_range): Adjuted for the above change.
992 (map_sub_char_table): Delete args default_val and parent. Add arg
993 top. Give decoded values to a Lisp function.
994 (map_char_table): Adjusted for the above change. Give decoded
995 values to a Lisp function. Gcpro more variables.
996 (uniprop_table_uncompress)
997 (uniprop_decode_value_run_length): New functions.
998 (uniprop_decoder, uniprop_decoder_count): New variables.
999 (uniprop_get_decoder, uniprop_encode_value_character)
1000 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1001 New functions.
1002 (uniprop_encoder, uniprop_encoder_count): New variables.
1003 (uniprop_get_encoder, uniprop_table)
1004 (Funicode_property_table_internal, Fget_unicode_property_internal)
1005 (Fput_unicode_property_internal): New functions.
1006 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1007 Sunicode_property_table_internal, Sget_unicode_property_internal,
1008 and Sput_unicode_property_internal. Defvar_lisp
1009 char-code-property-alist.
1010
1011 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
1012 Vunicode_category_table.
1013
1014 * font.c (font_range): Adjusted for the change of
1015 Vunicode_category_table.
1016
1017 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1018
1019 * m/iris4d.h: Remove file, move contents ...
1020 * s/irix6-5.h: ... here.
1021
1022 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1023
1024 Remove unportable assumption about struct layout (Bug#8884).
1025 * alloc.c (mark_buffer):
1026 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1027 (clone_per_buffer_values): Don't assume that
1028 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1029 This isn't true in general, and it's particularly not true
1030 if Emacs is configured with --with-wide-int.
1031 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1032 New macros, used in the buffer.c change.
1033
1034 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1035
1036 * xsettings.c: Use both GConf and GSettings if both are available.
1037 (store_config_changed_event): Add comment.
1038 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1039 (store_tool_bar_style_changed): New functions.
1040 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1041 (struct xsettings): Move font inside HAVE_XFT.
1042 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1043 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
1044 Move inside HAVE_XFT.
1045 (something_changed_gsettingsCB): Renamed from something_changedCB.
1046 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1047 also.
1048 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1049 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1050 (something_changed_gconfCB): Renamed from something_changedCB.
1051 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1052 (parse_settings): Move check for font inside HAVE_XFT.
1053 (read_settings, apply_xft_settings): Add comment.
1054 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1055 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1056 call store_font_name_changed.
1057 (xft_settings_event): Add comment.
1058 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1059 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1060 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1061 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1062 (xsettings_initialize): Call init_gsettings last.
1063 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
1064 comment.
1065
1066 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1067
1068 Random fixes. E.g., (random) never returned negative values.
1069 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1070 subseconds part to the entropy, as that's a bit more random.
1071 Prefer signed to unsigned, since the signedness doesn't matter and
1072 in general we prefer signed. When given a limit, use a
1073 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1074 latter isn't right if USE_2_TAGS_FOR_INTS.
1075 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1076 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1077
1078 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1079
1080 * textprop.c (text_property_stickiness):
1081 Obey Vtext_property_default_nonsticky.
1082 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1083 * w32fns.c (syms_of_w32fns):
1084 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1085
1086 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1087
1088 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1089 This is more efficient than Ffile_directory_p and avoids a minor race.
1090
1091 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1092
1093 * buffer.c (Foverlay_put): Say what the return value is
1094 (bug#7835).
1095
1096 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1097 is a directory before asking whether to use the file name
1098 (bug#7564).
1099 (barf_or_query_if_file_exists): Make the "File is a directory"
1100 error be more correct.
1101
1102 * fns.c (Frequire): Remove the mention of the .gz files, since
1103 that's installation-specific, but keep the mention of
1104 `get-load-suffixes'.
1105
1106 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1107
1108 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1109 Report string overflow if the output is too long.
1110
1111 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1112
1113 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1114 (syms_of_gnutls): Remove duplicate DEFSYM for
1115 Qgnutls_bootprop_verify_hostname_error, an error for
1116 Qgnutls_bootprop_verify_error (which is no longer used).
1117
1118 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1119 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1120 Also (re)move comments that are misplaced or no longer relevant.
1121
1122 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1123
1124 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1125
1126 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1127
1128 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1129 and background color parameters if they have been changed.
1130
1131 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1132
1133 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1134
1135 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1136
1137 * xsettings.c (SYSTEM_FONT): Define only when used.
1138 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1139
1140 * keymap.c (access_keymap_1): Now static.
1141
1142 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1143
1144 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1145 leave any prefix arg for the up event (Bug#1586).
1146
1147 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1148
1149 * lread.c (syms_of_lread): Mention single symbols defined by
1150 `defvar' or `defconst' (bug#7154).
1151
1152 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1153 (Frequire): Mention get-load-suffixes.
1154
1155 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1156
1157 * window.h (window): Remove clone_number slot.
1158 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1159 Remove.
1160 (make_parent_window, make_window, saved_window)
1161 (Fset_window_configuration, save_window_save): Don't deal with
1162 clone numbers.
1163 * buffer.c (Qclone_number): Remove declaration.
1164 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1165
1166 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1167
1168 Add multiple inheritance to keymaps.
1169 * keymap.c (Fmake_composed_keymap): New function.
1170 (Fset_keymap_parent): Simplify.
1171 (fix_submap_inheritance): Remove.
1172 (access_keymap_1): New function extracted from access_keymap to handle
1173 embedded parents and handle lists of maps.
1174 (access_keymap): Use it.
1175 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1176 (Fcopy_keymap): Handle embedded parents.
1177 (Fcommand_remapping, define_as_prefix): Simplify.
1178 (Fkey_binding): Simplify.
1179 (syms_of_keymap): Move minibuffer-local-completion-map,
1180 minibuffer-local-filename-completion-map,
1181 minibuffer-local-must-match-map, and
1182 minibuffer-local-filename-must-match-map to Elisp.
1183 (syms_of_keymap): Defsubr make-composed-keymap.
1184 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1185 (parse_menu_item): Trivial simplification.
1186
1187 2011-07-01 Glenn Morris <rgm@gnu.org>
1188
1189 * Makefile.in (SETTINGS_LIBS): Fix typo.
1190
1191 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1192
1193 * coding.c (Fencode_coding_string): Record the last coding system
1194 used, as the function doc string says (bug#8738).
1195
1196 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1197
1198 * xsettings.c (store_monospaced_changed): Take new font as arg and
1199 check for change against current_mono_font.
1200 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1201 (emacs_settings_constructor, emacs_settings_get_property)
1202 (emacs_settings_set_property, emacs_settings_class_init)
1203 (emacs_settings_init, gsettings_obj): Remove.
1204 (something_changedCB): New function for HAVE_GSETTINGS.
1205 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1206 with value as argument.
1207 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1208 g_settings_new (Bug#8967). Do not create gsettings_obj.
1209 Remove calls to g_settings_bind. Connect something_changedCB to
1210 "changed".
1211
1212 * xgselect.c: Add defined (HAVE_GSETTINGS).
1213 (xgselect_initialize): Ditto.
1214
1215 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1216 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1217 xg_select.
1218
1219 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1220
1221 * eval.c (struct backtrace): Simplify and port the data structure.
1222 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1223 signed bit field, as this assumption is not portable and it makes
1224 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1225 "char debug_on_exit : 1" as this is not portable either; instead,
1226 use the portable "unsigned int debug_on_exit : 1". Remove unused
1227 member evalargs. Remove obsolete comments about cc bombing out.
1228
1229 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1230
1231 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1232 Let HAVE_GSETTINGS override HAVE_GCONF.
1233 (store_monospaced_changed): New function.
1234 (EMACS_SETTINGS): A new type derived from GObject to handle
1235 GSettings notifications.
1236 (emacs_settings_constructor, emacs_settings_get_property)
1237 (emacs_settings_set_property, emacs_settings_class_init):
1238 New functions.
1239 (gsettings_client, gsettings_obj): New variables.
1240 (GSETTINGS_SCHEMA): New define.
1241 (something_changedCB): Call store_monospaced_changed.
1242 (init_gsettings): New function.
1243 (xsettings_initialize): Call init_gsettings.
1244 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1245 to NULL.
1246
1247 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1248 GCONF_CFLAGS/LIBS.
1249
1250 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1251
1252 * window.c (resize_root_window, grow_mini_window)
1253 (shrink_mini_window): Rename Qresize_root_window to
1254 Qwindow_resize_root_window and Qresize_root_window_vertically to
1255 Qwindow_resize_root_window_vertically.
1256
1257 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1258
1259 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1260
1261 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1262
1263 * makefile.w32-in: Redesign dependencies so they reflect more
1264 clearly which files are directly included by each source file,
1265 and not through other includes.
1266
1267 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1268
1269 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1270 (sort_overlays, overlay_strings): When an overlay's clone number
1271 matches the window's clone number process the overlay even if
1272 the overlay's window property doesn't match the current window.
1273
1274 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1275 (Fwindow_hchild): Rename to Fwindow_left_child.
1276 (Fwindow_next): Rename to Fwindow_next_sibling.
1277 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1278 (resize_window_check): Rename to window_resize_check.
1279 (resize_window_apply): Rename to window_resize_apply.
1280 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1281 (Fdelete_other_windows_internal, resize_frame_windows)
1282 (Fsplit_window_internal, Fdelete_window_internal)
1283 (grow_mini_window, shrink_mini_window)
1284 (Fresize_mini_window_internal): Fix callers accordingly.
1285
1286 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1287
1288 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1289 (emacs_fixed_set_min_size): Remove.
1290 (emacs_fixed_new): Take frame as argument.
1291
1292 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1293 (_EmacsFixedPrivate): Remove minwidth/height.
1294 Add struct frame *f.
1295 (emacs_fixed_init): Initialize priv->f.
1296 (get_parent_class, emacs_fixed_set_min_size): Remove.
1297 (emacs_fixed_new): Set priv->f to argument.
1298 (emacs_fixed_get_preferred_width)
1299 (emacs_fixed_get_preferred_height): Use min_width/height from
1300 frames size_hint to set minimum and natural (Bug#8919).
1301 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1302 and use min_width/height from frames size_hint to set
1303 min_width/height (Bug#8919).
1304
1305 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1306 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1307 Fix indentation.
1308
1309 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1310
1311 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1312 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1313 called at ZV.
1314
1315 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1316
1317 * process.c (wait_reading_process_output): Bypass select if
1318 waiting for a cell while ignoring keyboard input, and input is
1319 pending. Suggested by Jan Djärv (Bug#8869).
1320
1321 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1322
1323 Use gnulib's dup2 module instead of rolling our own.
1324 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1325
1326 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1327
1328 * dispnew.c (scrolling_window): Before scrolling, turn off a
1329 mouse-highlight in the window being scrolled.
1330
1331 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1332
1333 Move DEFSYM to lisp.h and use everywhere.
1334
1335 * character.h (DEFSYM): Move declaration...
1336 * lisp.h (DEFSYM): ...here.
1337
1338 * gnutls.c:
1339 * minibuf.c:
1340 * w32menu.c:
1341 * w32proc.c:
1342 * w32select.c: Don't include character.h.
1343
1344 * alloc.c (syms_of_alloc):
1345 * buffer.c (syms_of_buffer):
1346 * bytecode.c (syms_of_bytecode):
1347 * callint.c (syms_of_callint):
1348 * casefiddle.c (syms_of_casefiddle):
1349 * casetab.c (init_casetab_once):
1350 * category.c (init_category_once, syms_of_category):
1351 * ccl.c (syms_of_ccl):
1352 * cmds.c (syms_of_cmds):
1353 * composite.c (syms_of_composite):
1354 * dbusbind.c (syms_of_dbusbind):
1355 * dired.c (syms_of_dired):
1356 * dispnew.c (syms_of_display):
1357 * doc.c (syms_of_doc):
1358 * editfns.c (syms_of_editfns):
1359 * emacs.c (syms_of_emacs):
1360 * eval.c (syms_of_eval):
1361 * fileio.c (syms_of_fileio):
1362 * fns.c (syms_of_fns):
1363 * frame.c (syms_of_frame):
1364 * fringe.c (syms_of_fringe):
1365 * insdel.c (syms_of_insdel):
1366 * keymap.c (syms_of_keymap):
1367 * lread.c (init_obarray, syms_of_lread):
1368 * macros.c (syms_of_macros):
1369 * msdos.c (syms_of_msdos):
1370 * print.c (syms_of_print):
1371 * process.c (syms_of_process):
1372 * search.c (syms_of_search):
1373 * sound.c (syms_of_sound):
1374 * syntax.c (init_syntax_once, syms_of_syntax):
1375 * terminal.c (syms_of_terminal):
1376 * textprop.c (syms_of_textprop):
1377 * undo.c (syms_of_undo):
1378 * w32.c (globals_of_w32):
1379 * window.c (syms_of_window):
1380 * xdisp.c (syms_of_xdisp):
1381 * xfaces.c (syms_of_xfaces):
1382 * xfns.c (syms_of_xfns):
1383 * xmenu.c (syms_of_xmenu):
1384 * xsettings.c (syms_of_xsettings):
1385 * xterm.c (syms_of_xterm): Use DEFSYM.
1386
1387 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1388
1389 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1390
1391 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1392
1393 Integer and buffer overflow fixes (Bug#8873).
1394
1395 * print.c (printchar, strout): Check for string overflow.
1396 (PRINTPREPARE, printchar, strout):
1397 Don't set size unless allocation succeeds.
1398
1399 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1400 for sizes. Check for string overflow more accurately.
1401 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1402
1403 * macros.c: Integer and buffer overflow fixes.
1404 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1405 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1406 Use ptrdiff_t, not int, for sizes.
1407 Don't increment bufsize until after realloc succeeds.
1408 Check for size-calculation overflow.
1409 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1410
1411 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1412
1413 * lread.c: Integer overflow fixes.
1414 (read_integer): Radix is now EMACS_INT, not int,
1415 to improve quality of diagnostics for out-of-range radices.
1416 Calculate buffer size correctly for out-of-range radices.
1417 (read1): Check for integer overflow in radices, and in
1418 read-circle numbers.
1419 (read_escape): Avoid int overflow.
1420 (Fload, openp, read_buffer_size, read1)
1421 (substitute_object_recurse, read_vector, read_list, map_obarray):
1422 Use ptrdiff_t, not int, for sizes.
1423 (read1): Use EMACS_INT, not int, for sizes.
1424 Check for size overflow.
1425
1426 * image.c (cache_image): Check for size arithmetic overflow.
1427
1428 * lread.c: Integer overflow issues.
1429 (saved_doc_string_size, saved_doc_string_length)
1430 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1431 Now ptrdiff_t, not int.
1432 (read1): Don't assume doc string length fits in int. Check for
1433 out-of-range doc string lengths.
1434 (read_list): Don't assume file position fits in int.
1435 (read_escape): Check for hex character overflow.
1436
1437 2011-06-22 Leo Liu <sdl.web@gmail.com>
1438
1439 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1440 Move to minibuffer.el.
1441
1442 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1443
1444 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1445 The following patches are for when GLYPH_DEBUG && !XASSERT.
1446 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1447 * dispnew.c (flush_stdout):
1448 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1449 Mark as externally visible.
1450 * dispnew.c (check_window_matrix_pointers): Now static.
1451 * dispnew.c (window_to_frame_vpos):
1452 * xfns.c (unwind_create_frame):
1453 * xterm.c (x_check_font): Remove unused local.
1454 * scroll.c (CHECK_BOUNDS):
1455 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1456 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1457 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1458 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1459 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1460 Now static.
1461 (debug_method_add): Use va_list and vsprintf rather than relying
1462 on undefined behavior with wrong number of arguments.
1463 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1464 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1465 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1466 since we're not interested in debugging glyphs with old libraries.
1467 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1468 GCC 4.6.0's static checking.
1469
1470 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1471
1472 Integer overflow and signedness fixes (Bug#8873).
1473 A few related buffer overrun fixes, too.
1474
1475 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1476
1477 * dispextern.h (struct face.stipple):
1478 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1479 (x_bitmap_mask, x_allocate_bitmap_record)
1480 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1481 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1482 (x_create_bitmap_from_xpm_data):
1483 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1484 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1485 (.bitmaps_last):
1486 * xfaces.c (load_pixmap):
1487 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1488 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1489 (.bitmaps_last, struct x_output.icon_bitmap):
1490 Use ptrdiff_t, not int, for bitmap indexes.
1491 (x_allocate_bitmap_record): Check for size overflow.
1492 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1493
1494 Use ptrdiff_t, not int, for overlay counts.
1495 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1496 * editfns.c (overlays_around, get_pos_property):
1497 * textprop.c (get_char_property_and_overlay):
1498 * xdisp.c (next_overlay_change, note_mouse_highlight):
1499 * xfaces.c (face_at_buffer_position):
1500 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1501 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1502 (Fnext_overlay_change, Fprevious_overlay_change)
1503 (mouse_face_overlay_overlaps, Foverlays_in):
1504 Use ptrdiff_t, not int, for sizes.
1505 (overlays_at, overlays_in): Check for size-calculation overflow.
1506
1507 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1508
1509 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1510 (x_session_initialize): Do not assume string length fits in int.
1511
1512 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1513 This is unlikely, but can occur if DPI is outlandish.
1514
1515 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1516 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1517
1518 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1519 * xrdb.c (magic_file_p, search_magic_path):
1520 Omit last arg SUFFIX; it was always 0. All callers changed.
1521 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1522
1523 * xfont.c (xfont_match): Avoid need for strlen.
1524
1525 * xfns.c: Don't assume strlen fits in int.
1526 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1527
1528 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1529 not unsigned long, as we prefer signed integers. All callers changed.
1530 Detect integer overflow in repeat count.
1531 (message_dolog): Don't assume print length fits in 39 bytes.
1532 (display_mode_element): Don't assume strlen fits in int.
1533
1534 * termcap.c: Don't assume sizes fit in int and never overflow.
1535 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1536 (gobble_line): Check for size-calculation overflow.
1537
1538 * minibuf.c (Fread_buffer):
1539 * lread.c (intern, intern_c_string):
1540 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1541 Don't assume string length fits in int.
1542
1543 * keyboard.c (parse_tool_bar_item):
1544 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1545
1546 * font.c: Don't assume string length fits in int.
1547 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1548 Use ptrdiff_t, not int.
1549 (font_intern_prop): Don't assume string length fits in int.
1550 Don't assume integer property fits in fixnum.
1551 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1552
1553 * filelock.c: Fix some buffer overrun and integer overflow issues.
1554 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1555 Reformulate so as not to need the command string.
1556 Invoke gzip -cd rather than gunzip, as it's more portable.
1557 (lock_info_type, lock_file_1, lock_file):
1558 Don't assume pid_t and time_t fit in unsigned long.
1559 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1560 (current_lock_owner): Prefer signed type for sizes.
1561 Use memcpy, not strncpy, where memcpy is what is really wanted.
1562 Don't assume (via atoi) that time_t and pid_t fit in int.
1563 Check for time_t and/or pid_t out of range, e.g., via a network share.
1564 Don't alloca where an auto var works fine.
1565
1566 * fileio.c: Fix some integer overflow issues.
1567 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1568 Don't assume string length fits in int.
1569 (directory_file_name): Don't assume string length fits in long.
1570 (make_temp_name): Don't assume pid fits in int, or that its print
1571 length is less than 20.
1572
1573 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1574
1575 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1576
1577 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1578
1579 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1580 We prefer signed integers, even for size calculations.
1581
1582 * emacs.c: Don't assume string length fits in 'int'.
1583 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1584 (main): Don't invoke strlen when not needed.
1585
1586 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1587 (XD_DEBUG_MESSAGE): Don't waste a byte.
1588
1589 * callproc.c (getenv_internal_1, getenv_internal)
1590 (Fgetenv_internal):
1591 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1592
1593 * lread.c (invalid_syntax): Omit length argument.
1594 All uses changed. This doesn't fix a bug, but it simplifies the
1595 code away from its former Hollerith-constant appearance, and it's
1596 one less 'int' to worry about when looking at integer-overflow issues.
1597 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1598
1599 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1600 This didn't break anything, but it didn't help either.
1601 It's confusing to put a bogus integer in a place where the actual
1602 value does not matter.
1603 (LIST_END_P): Remove unused macro and its bogus comment.
1604 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1605
1606 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1607 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1608 implementation.
1609 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1610 We prefer signed types, and the value cannot exceed the EMACS_INT
1611 range anyway (because otherwise the length would not be representable).
1612 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1613 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1614 This avoids a GCC warning when WIDE_EMACS_INT.
1615
1616 * indent.c (sane_tab_width): New function.
1617 (current_column, scan_for_column, Findent_to, position_indentation)
1618 (compute_motion): Use it. This is just for clarity.
1619 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1620
1621 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1622
1623 * lisp.h (lint_assume): New macro.
1624 * composite.c (composition_gstring_put_cache):
1625 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1626
1627 * editfns.c, insdel.c:
1628 Omit unnecessary forward decls, to simplify future changes.
1629
1630 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1631
1632 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1633
1634 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1635 Use much-faster test for byte-length change.
1636 Don't assume string byte-length fits in 'int'.
1637 Check that character arg fits in 'int'.
1638 (mapcar1): Declare byte as byte, for clarity.
1639
1640 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1641
1642 * fns.c (concat): Catch string overflow earlier.
1643 Do not rely on integer wraparound.
1644
1645 * dispextern.h (struct it.overlay_strings_charpos)
1646 (struct it.selective): Now EMACS_INT, not int.
1647 * xdisp.c (forward_to_next_line_start)
1648 (back_to_previous_visible_line_start)
1649 (reseat_at_next_visible_line_start, next_element_from_buffer):
1650 Don't arbitrarily truncate the value of 'selective' to int.
1651
1652 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1653
1654 * composite.c: Don't truncate sizes to 'int'.
1655 (composition_gstring_p, composition_reseat_it)
1656 (composition_adjust_point): Use EMACS_INT, not int.
1657 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1658 not EMACS_UINT, for indexes.
1659
1660 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1661
1662 * buffer.c: Include <verify.h>.
1663 (struct sortvec.priority, struct sortstr.priority):
1664 Now EMACS_INT, not int.
1665 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1666 (struct sortstr.size, record_overlay_string)
1667 (struct sortstrlist.size, struct sortlist.used):
1668 Don't truncate size to int.
1669 (record_overlay_string): Check for size-calculation overflow.
1670 (init_buffer_once): Check at compile-time, not run-time.
1671
1672 2011-06-22 Jim Meyering <meyering@redhat.com>
1673
1674 Don't leak an XBM-image-sized buffer
1675 * image.c (xbm_load): Free the image buffer after using it.
1676
1677 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1678
1679 Port to Sun C.
1680 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1681 that Sun C diagnosed.
1682 * fns.c (secure_hash): Fix pointer signedness issue.
1683 * intervals.c (static_offset_intervals): New function.
1684 (offset_intervals): Use it.
1685
1686 2011-06-21 Leo Liu <sdl.web@gmail.com>
1687
1688 * deps.mk (fns.o):
1689 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1690 sha512.h.
1691
1692 * fns.c (secure_hash): Rename from crypto_hash_function and change
1693 the first arg to accept symbols.
1694 (Fsecure_hash): New primitive.
1695 (syms_of_fns): New symbols.
1696
1697 2011-06-20 Deniz Dogan <deniz@dogan.se>
1698
1699 * process.c (Fset_process_buffer): Clarify return value in
1700 docstring.
1701
1702 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1703
1704 * dispnew.c (add_window_display_history): Use BVAR.
1705
1706 * xdisp.c (debug_method_add): Use BVAR.
1707 (check_window_end, dump_glyph_matrix, dump_glyph)
1708 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1709
1710 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1711 Likewise.
1712
1713 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1714 check till after the cache is created in init_frame_faces.
1715
1716 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1717
1718 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1719
1720 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1721
1722 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1723 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1724 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1725
1726 Improve buffer-overflow checking (Bug#8873).
1727 * fileio.c (Finsert_file_contents):
1728 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1729 Remove the old (too-loose) buffer overflow checks.
1730 They weren't needed, since make_gap checks for buffer overflow.
1731 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1732 The old code merely checked for Emacs fixnum overflow, and relied
1733 on undefined (wraparound) behavior. The new code avoids undefined
1734 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1735
1736 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1737 Tune. Don't use wider integers than needed. Don't use alloca.
1738 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1739
1740 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1741
1742 * insdel.c, lisp.h (buffer_overflow): New function.
1743 (insert_from_buffer_1, replace_range, replace_range_2):
1744 * insdel.c (make_gap_larger):
1745 * editfns.c (Finsert_char):
1746 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1747
1748 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1749
1750 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1751
1752 Integer overflow and signedness fixes (Bug#8873).
1753
1754 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1755 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1756
1757 * fileio.c: Don't assume EMACS_INT fits in off_t.
1758 (emacs_lseek): New static function.
1759 (Finsert_file_contents, Fwrite_region): Use it.
1760 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1761
1762 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1763
1764 * fns.c: Don't overflow int when computing a list length.
1765 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1766 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1767 truncation on 64-bit hosts. Check for QUIT every
1768 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1769 faster and is responsive enough.
1770 (Flength): Report an error instead of overflowing an integer.
1771 (Fsafe_length): Return a float if the value is not representable
1772 as a fixnum. This shouldn't happen except in contrived situations.
1773 (Fnthcdr, Fsort): Don't assume list length fits in int.
1774 (Fcopy_sequence): Don't assume vector length fits in int.
1775
1776 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1777 (header_size, word_size): New constants.
1778 (allocate_vectorlike): Don't check size overflow here.
1779 (allocate_vector): Check it here instead, since this is the only
1780 caller of allocate_vectorlike that could cause overflow.
1781 Check that the new vector's length is representable as a fixnum.
1782
1783 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1784 The previous code was bogus. For example, next_almost_prime (32)
1785 returned 39, which is undesirable as it is a multiple of 3; and
1786 next_almost_prime (24) returned 25, which is a multiple of 5 so
1787 why was the code bothering to check for multiples of 7?
1788
1789 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1790
1791 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1792
1793 Variadic C functions now count arguments with ptrdiff_t.
1794 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1795 Back then I didn't know that the Emacs coding style prefers signed int.
1796 Also, in the meantime I found a few more instances where arguments
1797 were being counted with int, which may truncate counts on 64-bit
1798 machines, or EMACS_INT, which may be unnecessarily wide.
1799 * lisp.h (struct Lisp_Subr.function.aMANY)
1800 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1801 Arg counts are now ptrdiff_t, not size_t.
1802 All variadic functions and their callers changed accordingly.
1803 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1804 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1805 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1806 * callint.c (Fcall_interactively): Check arg count for overflow,
1807 to avoid potential buffer overrun. Use signed char, not 'int',
1808 for 'varies' array, so that we needn't bother to check its size
1809 calculation for overflow.
1810 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1811 * eval.c (apply_lambda):
1812 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1813 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1814 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1815
1816 * callint.c (Fcall_interactively): Don't use index var as event count.
1817
1818 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1819 * mem-limits.h (SIZE): Remove; no longer used.
1820
1821 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1822
1823 Remove unnecessary casts.
1824 * xterm.c (x_term_init):
1825 * xfns.c (x_set_border_pixel):
1826 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1827 These aren't needed now that we assume ANSI C.
1828
1829 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1830 It's more likely to cause problems (due to unsigned overflow)
1831 than to cure them.
1832
1833 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1834
1835 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1836
1837 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1838
1839 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1840
1841 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1842
1843 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1844
1845 GLYPH_CODE_FACE returns EMACS_INT, not int.
1846 * dispextern.h (merge_faces):
1847 * xfaces.c (merge_faces):
1848 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1849 Don't assume EMACS_INT fits in int.
1850
1851 * character.h (CHAR_VALID_P): Remove unused parameter.
1852 * fontset.c, lisp.h, xdisp.c: All uses changed.
1853
1854 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1855
1856 * fns.c (concat): Minor tuning based on overflow analysis.
1857 This doesn't fix any bugs. Use int to hold character, instead
1858 of constantly refetching from Emacs object. Use XFASTINT, not
1859 XINT, for value known to be a character. Don't bother comparing
1860 a single byte to 0400, as it's always less.
1861
1862 * floatfns.c (Fexpt):
1863 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1864
1865 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1866 for characters.
1867
1868 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1869
1870 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1871 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1872 incorrectly succeed when S was a string, because 4294967386 was
1873 truncated before it was used.
1874
1875 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1876 Otherwise, an out-of-range integer could cause undefined behavior
1877 on a 64-bit host.
1878
1879 * composite.c: Use int, not EMACS_INT, for characters.
1880 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1881 EMACS_INT, for values that are known to be in character range.
1882 This doesn't fix any bugs but is the usual style inside Emacs and
1883 may generate better code on 32-bit machines.
1884
1885 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1886 This is for reasons similar to the recent CHAR_STRING fix.
1887 * charset.c (Fencode_char): Check that character arg is actually
1888 a character. Pass an int to ENCODE_CHAR.
1889 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1890 wider than 'int', as a compile-time check to prevent future regressions
1891 in this area.
1892
1893 * character.c (char_string): Remove unnecessary casts.
1894
1895 Make sure a 64-bit char is never passed to CHAR_STRING.
1896 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1897 by silently ignoring the top 32 bits, allowing some values
1898 that were far too large to be valid characters.
1899 * character.h: Include <verify.h>.
1900 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1901 arguments are no wider than unsigned, as a compile-time check
1902 to prevent future regressions in this area.
1903 * data.c (Faset):
1904 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1905 (Fsubst_char_in_region):
1906 * fns.c (concat):
1907 * xdisp.c (decode_mode_spec_coding):
1908 Adjust to CHAR_STRING's new requirement.
1909 * editfns.c (Finsert_char, Fsubst_char_in_region):
1910 * fns.c (concat): Check that character args are actually
1911 characters. Without this test, these functions did the wrong
1912 thing with wildly out-of-range values on 64-bit hosts.
1913
1914 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1915 These casts should not be needed on 32-bit hosts, either.
1916 * keyboard.c (read_char):
1917 * lread.c (Fload): Remove casts to unsigned.
1918
1919 * lisp.h (UNSIGNED_CMP): New macro.
1920 This fixes comparison bugs on 64-bit hosts.
1921 (ASCII_CHAR_P): Use it.
1922 * casefiddle.c (casify_object):
1923 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1924 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1925 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1926 * dispextern.h (FACE_FROM_ID):
1927 * keyboard.c (read_char): Use UNSIGNED_CMP.
1928
1929 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1930 not to EMACS_INT, to avoid GCC warning.
1931
1932 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1933
1934 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1935 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1936 isn't needed on 32-bit machines.
1937
1938 * buffer.c (Fgenerate_new_buffer_name):
1939 Use EMACS_INT for count, not int.
1940 (advance_to_char_boundary): Return EMACS_INT, not int.
1941
1942 * data.c (Qcompiled_function): Now static.
1943
1944 * window.c (window_body_lines): Now static.
1945
1946 * image.c (gif_load): Rename local to avoid shadowing.
1947
1948 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1949 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1950 * alloc.c (make_save_value): Integer argument is now of type
1951 ptrdiff_t, not int.
1952 (mark_object): Use ptrdiff_t, not int.
1953 * lisp.h (pD): New macro.
1954 * print.c (print_object): Use it.
1955
1956 * alloc.c: Use EMACS_INT, not int, to count objects.
1957 (total_conses, total_markers, total_symbols, total_vector_size)
1958 (total_free_conses, total_free_markers, total_free_symbols)
1959 (total_free_floats, total_floats, total_free_intervals)
1960 (total_intervals, total_strings, total_free_strings):
1961 Now EMACS_INT, not int. All uses changed.
1962 (Fgarbage_collect): Compute overall total using a double, so that
1963 integer overflow is less likely to be a problem. Check for overflow
1964 when converting back to an integer.
1965 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1966 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1967 These were 'int' variables that could overflow on 64-bit hosts;
1968 they were never used, so remove them instead of repairing them.
1969 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1970 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1971 Previously, this ceilinged at INT_MAX, but that doesn't work on
1972 64-bit machines.
1973 (allocate_pseudovector): Don't use EMACS_INT when int would do.
1974
1975 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1976 (allocate_vectorlike): Check for ptrdiff_t overflow.
1977 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1978 when a (possibly-narrower) signed value would do just as well.
1979 We prefer using signed arithmetic, to avoid comparison confusion.
1980
1981 * alloc.c: Catch some string size overflows that we were missing.
1982 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1983 for convenience in STRING_BYTES_MAX.
1984 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1985 The definition here is exact; the one in lisp.h was approximate.
1986 (allocate_string_data): Check for string overflow. This catches
1987 some instances we weren't catching before. Also, it catches
1988 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1989 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1990 and ptrdiff_t and EMACS_INT are both 64 bits.
1991
1992 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1993 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1994 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1995
1996 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1997
1998 * alloc.c (Fmake_string): Check for out-of-range init.
1999
2000 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2001
2002 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2003
2004 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2005
2006 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2007 xg_get_default_scrollbar_width.
2008
2009 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2010 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2011 (style_changed_cb): Call update_theme_scrollbar_width and call
2012 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2013 all frames (Bug#8505).
2014 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2015 Call gtk_window_set_resizable if HAVE_GTK3.
2016 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2017 and height if HAVE_GTK3 (Bug#8505).
2018 (scroll_bar_width_for_theme): New variable.
2019 (update_theme_scrollbar_width): New function.
2020 (xg_get_default_scrollbar_width): Move code to
2021 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2022 (xg_initialize): Call update_theme_scrollbar_width.
2023
2024 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2025
2026 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2027
2028 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2029
2030 * frame.c (make_frame): Call other_buffer_safely instead of
2031 other_buffer.
2032
2033 * window.c (temp_output_buffer_show): Call display_buffer with
2034 second argument Vtemp_buffer_show_specifiers and reset latter
2035 immediately after the call.
2036 (Vtemp_buffer_show_specifiers): New variable.
2037 (auto_window_vscroll_p, next_screen_context_lines)
2038 (Vscroll_preserve_screen_position): Remove leading asterisks from
2039 doc-strings.
2040
2041 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2042
2043 Fix minor problems found by GCC 4.6.0 static checking.
2044 * buffer.c (Qclone_number): Remove for now, as it's unused.
2045 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2046 (record_buffer): Remove unused local.
2047 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2048 (set_frame_buffer_list): Remove; unused.
2049 * frame.h (other_visible_frames): Remove decl.
2050 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2051 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2052 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2053 if HAVE_GPM.
2054 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2055 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2056 Define only if HAVE_GPM.
2057 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2058 (update_hints_inhibit): Remove; never set. All uses removed.
2059 * widgetprv.h (emacsFrameClassRec): Remove decl.
2060 * window.c (delete_deletable_window): Now returns void, since it
2061 wasn't returning anything.
2062 (compare_window_configurations): Remove unused locals.
2063 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2064 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2065 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2066 the same widths as pointers. This follows up on the 2011-05-06 patch.
2067 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2068 * xterm.h: Likewise.
2069 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2070
2071 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2072
2073 * makefile.w32-in: Update dependencies.
2074 (LISP_H): Add lib/intprops.h.
2075
2076 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2077
2078 * image.c (gif_load): Add animation frame delay to the metadata.
2079 (syms_of_image): Use DEFSYM. New symbol `delay'.
2080
2081 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2082
2083 * window.c (delete_deletable_window): Re-add.
2084 (Fset_window_configuration): Rewrite to handle dead buffers and
2085 consequently deletable windows.
2086 (window_tree, Fwindow_tree): Remove. Supply functionality in
2087 window.el.
2088 (compare_window_configurations): Simplify code.
2089
2090 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2091
2092 * image.c (imagemagick_load_image): Fix type mismatch.
2093 (Fimagemagick_types): Likewise.
2094
2095 * window.h (replace_buffer_in_windows): Declare.
2096
2097 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2098
2099 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2100 Qclone_number. Remove external declaration of Qdelete_window.
2101 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2102 code.
2103 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
2104 Qbuffer_list_update_hook if allowed.
2105 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2106 buffer list implementation.
2107 (other_buffer_safely): New function.
2108 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2109 calls to replace_buffer_in_windows and
2110 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2111 if allowed.
2112 (record_buffer): Inhibit quitting and rewrite using quittable
2113 functions. Run Qbuffer_list_update_hook if allowed.
2114 (Frecord_buffer, Funrecord_buffer): New functions.
2115 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
2116 switch-to-buffer to window.el.
2117 (bury-buffer): Move to window.el.
2118 (Vbuffer_list_update_hook): New variable.
2119
2120 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2121 section.
2122
2123 * window.h (resize_frame_windows): Move up in code.
2124 (Fwindow_frame): Remove EXFUN.
2125 (replace_buffer_in_all_windows): Remove prototype.
2126 (replace_buffer_in_windows_safely): Add prototype.
2127
2128 * window.c: Declare Qdelete_window static again. Move down
2129 declaration of select_count.
2130 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2131 (Fother_window): Move to window.el.
2132 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2133 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2134 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2135 window.el.
2136 (replace_buffer_in_windows): Implement by calling
2137 Qreplace_buffer_in_windows.
2138 (replace_buffer_in_all_windows): Remove with some functionality
2139 moved into replace_buffer_in_windows_safely.
2140 (replace_buffer_in_windows_safely): New function.
2141 (select_window_norecord, select_frame_norecord): Move in front
2142 of run_window_configuration_change_hook. Remove now obsolete
2143 declarations.
2144 (Fset_window_buffer): Rewrite doc-string. Call
2145 Qrecord_window_buffer.
2146 (keys_of_window): Move binding for other-window to window.el.
2147
2148 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2149
2150 * dispextern.h (struct image): Replace data member, whose int_val
2151 and ptr_val fields were not used by anything, with a single
2152 lisp_val object.
2153
2154 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2155 (gif_clear_image, gif_load, imagemagick_load_image)
2156 (gs_clear_image, gs_load): Callers changed.
2157
2158 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2159
2160 * buffer.h: Include <time.h>, for time_t.
2161 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2162
2163 Fix minor problems found by static checking.
2164
2165 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2166
2167 Make identifiers static if they are not used in other modules.
2168 * data.c (Qcompiled_function, Qframe, Qvector):
2169 * image.c (QimageMagick, Qsvg):
2170 * minibuf.c (Qmetadata):
2171 * window.c (resize_window_check, resize_root_window): Now static.
2172 * window.h (resize_window_check, resize_root_window): Remove decls.
2173
2174 * window.c (window_deletion_count, delete_deletable_window):
2175 Remove; unused.
2176 (window_body_lines): Now static.
2177 (Fdelete_other_windows_internal): Mark vars as initialized.
2178 Make sure 'resize_failed' is initialized.
2179 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2180 (resize_window_apply): Remove unused local.
2181 * window.h (delete_deletable_window): Remove decl.
2182
2183 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2184 (imagemagick_load_image): Fix pointer signedness problem by changing
2185 last arg from unsigned char * to char *. All uses changed.
2186 Also, fix a local for similar reasons.
2187 Remove unused locals. Remove locals to avoid shadowing.
2188 (fn_rsvg_handle_free): Remove; unused.
2189 (svg_load, svg_load_image): Fix pointer signedness problem.
2190 (imagemagick_load_image): Don't use garbage pointer image_wand.
2191
2192 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2193
2194 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2195
2196 * image.c (gif_load): Fix omitted cast error introduced by
2197 2011-06-06 change.
2198
2199 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2200
2201 * window.h (resize_proportionally, orig_total_lines)
2202 (orig_top_line): Remove from window structure.
2203 (set_window_height, set_window_width, change_window_heights)
2204 (Fdelete_window): Remove prototypes.
2205 (resize_frame_windows): Remove duplicate declaration.
2206
2207 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2208
2209 * window.h (resize_frame_windows, resize_window_check)
2210 (delete_deletable_window, resize_root_window)
2211 (resize_frame_windows): Declare prototypes.
2212
2213 * window.c (resize_window_apply): Make definition be "static" to
2214 match the prototype.
2215
2216 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2217
2218 * window.c: Remove declarations of Qwindow_size_fixed,
2219 window_min_size_1, window_min_size_2, window_min_size,
2220 size_window, window_fixed_size_p, enlarge_window, delete_window.
2221 Remove static from declaration of Qdelete_window, it's
2222 temporarily needed by Fbury_buffer.
2223 (replace_window): Don't assign orig_top_line and
2224 orig_total_lines.
2225 (Fdelete_window, delete_window): Remove. Window deletion is
2226 handled by window.el.
2227 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2228 Fdelete_window calls with calls to Qdelete_window.
2229 (Fdelete_other_windows): Remove. Deleting other windows is
2230 handled by window.el.
2231 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2232 handled in window.el.
2233 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2234 Window minimum sizes are handled in window.el.
2235 (shrink_windows, size_window, set_window_height)
2236 (set_window_width, change_window_heights, window_height)
2237 (window_width, CURBEG, CURSIZE, enlarge_window)
2238 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2239 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2240 handled in window.el.
2241 (make_dummy_parent): Rename to make_parent_window and give it a
2242 second argument horflag.
2243 (make_window): Don't set resize_proportionally any more.
2244 (Fsplit_window): Remove. Windows are split in window.el.
2245 (save_restore_action, save_restore_orig_size)
2246 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2247 Resize mini windows in window.el.
2248 (grow_mini_window, shrink_mini_window): Implement by calling
2249 Qresize_root_window_vertically, resize_window_check and
2250 resize_window_apply.
2251 (saved_window, Fset_window_configuration, save_window_save): Do
2252 not handle orig_top_line, orig_total_lines, and
2253 resize_proportionally.
2254 (window_min_height, window_min_width): Move to window.el.
2255 (keys_of_window): Move bindings for delete-other-windows,
2256 split-window, delete-window and enlarge-window to window.el.
2257
2258 * buffer.c: Temporarily extern Qdelete_window.
2259 (Fbury_buffer): Temporarily call Qdelete_window instead of
2260 Fdelete_window (Fbury_buffer will move to window.el soon).
2261
2262 * frame.c (set_menu_bar_lines_1): Remove code handling
2263 orig_top_line and orig_total_lines.
2264
2265 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2266 set_window_height but set heights directly.
2267 (change_frame_size_1): Use resize_frame_windows.
2268
2269 * xdisp.c (init_xdisp): Don't use set_window_height but set
2270 heights directly.
2271
2272 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2273 resize_frame_windows instead of change_window_heights and run
2274 run_window_configuration_change_hook.
2275
2276 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2277 instead of change_window_heights and run
2278 run_window_configuration_change_hook.
2279
2280 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2281
2282 * window.c (replace_window): Rename second argument REPLACEMENT to
2283 NEW. New third argument SETFLAG. Rewrite.
2284 (delete_window, make_dummy_parent): Call replace_window with
2285 third argument 1.
2286 (window_list_1): Move down in code.
2287 (run_window_configuration_change_hook): Move set_buffer part
2288 before select_frame_norecord part in order to unwind correctly.
2289 Rename count1 to count.
2290 (recombine_windows, delete_deletable_window, resize_root_window)
2291 (Fdelete_other_windows_internal)
2292 (Frun_window_configuration_change_hook, make_parent_window)
2293 (resize_window_check, resize_window_apply, Fresize_window_apply)
2294 (resize_frame_windows, Fsplit_window_internal)
2295 (Fdelete_window_internal, Fresize_mini_window_internal): New
2296 functions.
2297 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2298
2299 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2300
2301 * window.h (window): Add some new members to window structure -
2302 normal_lines, normal_cols, new_total, new_normal, clone_number,
2303 splits, nest, prev_buffers, next_buffers.
2304 (WINDOW_TOTAL_SIZE): Move here from window.c.
2305 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2306
2307 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2308 Remove.
2309 (make_dummy_parent): Set new members of windows structure.
2310 (make_window): Move down in code. Handle new members of window
2311 structure.
2312 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2313 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2314 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2315 (Fset_window_prev_buffers, Fwindow_next_buffers)
2316 (Fset_window_next_buffers, Fset_window_clone_number): New
2317 functions.
2318 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2319 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2320 Doc-string fixes.
2321 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2322 Argument WINDOW can be now internal window too.
2323 (Fwindow_use_time): Move up in code.
2324 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2325 Rewrite doc-string.
2326 (Fset_window_configuration, saved_window)
2327 (Fcurrent_window_configuration, save_window_save): Handle new
2328 members of window structure.
2329 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2330 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2331 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2332 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2333 Qget_mru_window, Qresize_root_window,
2334 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2335 Qauto_buffer_name; staticpro them.
2336
2337 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2338
2339 * window.c (Fwindow_total_size, Fwindow_left_column)
2340 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2341 (Fwindow_list_1): New functions.
2342 (window_box_text_cols): Replace with window_body_cols.
2343 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2344 window_body_cols instead of window_box_text_cols.
2345 (delete_window, Fset_window_configuration): Call
2346 delete_all_subwindows with window as argument.
2347 (delete_all_subwindows): Take a window as argument and not a
2348 structure. Rewrite.
2349 (window_loop): Remove handling of GET_LRU_WINDOW and
2350 GET_LARGEST_WINDOW.
2351 (Fget_lru_window, Fget_largest_window): Move to window.el.
2352
2353 * window.h: Extern window_body_cols instead of
2354 window_box_text_cols. delete_all_subwindows now takes a
2355 Lisp_Object as argument.
2356
2357 * indent.c (compute_motion, Fcompute_motion): Use
2358 window_body_cols instead of window_box_text_cols.
2359
2360 * frame.c (delete_frame): Call delete_all_subwindows with root
2361 window as argument.
2362
2363 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2364
2365 * fns.c (Fputhash): Document return value.
2366
2367 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2368
2369 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2370
2371 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2372
2373 Cons<->int and similar integer overflow fixes (Bug#8794).
2374
2375 Check for overflow when converting integer to cons and back.
2376 * charset.c (Fdefine_charset_internal, Fdecode_char):
2377 Use cons_to_unsigned to catch overflow.
2378 (Fencode_char): Use INTEGER_TO_CONS.
2379 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2380 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2381 * data.c (long_to_cons, cons_to_long): Remove.
2382 (cons_to_unsigned, cons_to_signed): New functions.
2383 These signal an error for invalid or out-of-range values.
2384 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2385 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2386 * font.c (Ffont_variation_glyphs):
2387 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2388 * lisp.h: Include <intprops.h>.
2389 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2390 (cons_to_signed, cons_to_unsigned): New decls.
2391 (long_to_cons, cons_to_long): Remove decls.
2392 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2393 (Fprimitive_undo): Use CONS_TO_INTEGER.
2394 * xfns.c (Fx_window_property): Likewise.
2395 * xselect.c: Include <limits.h>.
2396 (x_own_selection, selection_data_to_lisp_data):
2397 Use INTEGER_TO_CONS.
2398 (x_handle_selection_request, x_handle_selection_clear)
2399 (x_get_foreign_selection, Fx_disown_selection_internal)
2400 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2401 (lisp_data_to_selection_data): Use cons_to_unsigned.
2402 (x_fill_property_data): Use cons_to_signed.
2403 Report values out of range.
2404
2405 Check for buffer and string overflow more precisely.
2406 * buffer.h (BUF_BYTES_MAX): New macro.
2407 * lisp.h (STRING_BYTES_MAX): New macro.
2408 * alloc.c (Fmake_string):
2409 * character.c (string_escape_byte8):
2410 * coding.c (coding_alloc_by_realloc):
2411 * doprnt.c (doprnt):
2412 * editfns.c (Fformat):
2413 * eval.c (verror):
2414 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2415 since they may not be the same number.
2416 * editfns.c (Finsert_char):
2417 * fileio.c (Finsert_file_contents):
2418 Likewise for BUF_BYTES_MAX.
2419
2420 * image.c: Use ptrdiff_t, not int, for sizes.
2421 (slurp_file): Switch from int to ptrdiff_t.
2422 All uses changed.
2423 (slurp_file): Check that file size fits in both size_t (for
2424 malloc) and ptrdiff_t (for sanity and safety).
2425
2426 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2427 if b->modtime has its maximal value.
2428
2429 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2430
2431 Don't assume time_t can fit into int.
2432 * buffer.h (struct buffer.modtime): Now time_t, not int.
2433 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2434 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2435
2436 Minor fixes for signed vs unsigned integers.
2437 * character.h (MAYBE_UNIFY_CHAR):
2438 * charset.c (maybe_unify_char):
2439 * keyboard.c (read_char, reorder_modifiers):
2440 XINT -> XFASTINT, since the integer must be nonnegative.
2441 * ftfont.c (ftfont_spec_pattern):
2442 * keymap.c (access_keymap, silly_event_symbol_error):
2443 XUINT -> XFASTINT, since the integer must be nonnegative.
2444 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2445 since it makes no difference and we prefer signed.
2446 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2447 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2448 nonnegative.
2449
2450 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2451
2452 * window.h (Fwindow_frame): Declare.
2453
2454 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2455
2456 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2457 (SPARE_MEMORY): Always define.
2458 (LARGE_REQUEST): Remove.
2459 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2460
2461 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2462
2463 * lisp.h: Move EXFUNS for Fframe_root_window,
2464 Fframe_first_window and Fset_frame_selected_window to window.h.
2465
2466 * window.h: Move EXFUNS for Fframe_root_window,
2467 Fframe_first_window and Fset_frame_selected_window here from
2468 lisp.h.
2469
2470 * frame.c (Fwindow_frame, Fframe_first_window)
2471 (Fframe_root_window, Fframe_selected_window)
2472 (Fset_frame_selected_window): Move to window.c.
2473 (Factive_minibuffer_window): Move to minibuf.c.
2474 (Fother_visible_frames_p): New function.
2475
2476 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2477
2478 * window.c (decode_window, decode_any_window): Move up in code.
2479 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2480 (inhibit_frame_unsplittable): Remove unused variable.
2481 (Fwindow_buffer): Move up and rewrite doc-string.
2482 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2483 (Fwindow_prev): New functions.
2484 (Fwindow_frame): Move here from frame.c. Accept any window as
2485 argument.
2486 (Fframe_root_window, Fframe_first_window)
2487 (Fframe_selected_window): Move here from frame.c. Accept frame
2488 or arbitrary window as argument. Update doc-strings.
2489 (Fminibuffer_window): Move up in code.
2490 (Fwindow_minibuffer_p): Move up in code and simplify.
2491 (Fset_frame_selected_window): Move here from frame.c.
2492 Marginal rewrite.
2493 (Fselected_window, select_window, Fselect_window): Move up in
2494 code. Minor doc-string fixes.
2495
2496 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2497
2498 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2499 Do not assume that spare memory exists; that assumption is valid
2500 only if SYSTEM_MALLOC.
2501 (LARGE_REQUEST): New macro, so that the issue of large requests
2502 is separated from the issue of spare memory.
2503
2504 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2505
2506 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2507 format. (Bug#8806)
2508
2509 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2510
2511 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2512 before statements.
2513
2514 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2515
2516 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2517
2518 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2519
2520 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2521 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2522
2523 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2524
2525 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2526
2527 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2528
2529 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2530 (x_clipboard_manager_save): Add return value.
2531 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2532 New error handlers.
2533 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2534 Obey Vx_select_enable_clipboard_manager. Catch errors in
2535 x_clipboard_manager_save (Bug#8779).
2536 (Vx_select_enable_clipboard_manager): New variable.
2537 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2538
2539 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2540
2541 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2542
2543 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2544
2545 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2546 in the current matrix if keep_current_p is non-zero.
2547
2548 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2549
2550 * bidi.c (bidi_level_of_next_char): Fix last change.
2551
2552 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2553
2554 Support bidi reordering of text covered by display properties.
2555
2556 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2557 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2558 (bidi_cache_search, bidi_cache_iterator_state)
2559 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2560 (bidi_level_of_next_char, bidi_move_to_visually_next):
2561 Support character positions inside a run of characters covered by a
2562 display string.
2563 (bidi_paragraph_init, bidi_resolve_explicit_1)
2564 (bidi_level_of_next_char): Call bidi_fetch_char and
2565 bidi_fetch_char_advance instead of FETCH_CHAR and
2566 FETCH_CHAR_ADVANCE.
2567 (bidi_init_it): Initialize new members.
2568 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2569 definitions.
2570 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2571 instead of using explicit *_CHAR codes.
2572 (bidi_resolve_explicit, bidi_resolve_weak):
2573 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2574 bidirectional text is supported only in multibyte buffers.
2575 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2576 it to initialize the frame_window_p member of struct bidi_it.
2577 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2578 (bidi_resolve_explicit, bidi_resolve_weak)
2579 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2580 bidi_it->nchars is non-positive.
2581 (bidi_level_of_next_char): Don't try to lookup the cache for the
2582 next/previous character if nothing is cached there yet, or if we
2583 were just reseat()'ed to a new position.
2584
2585 * xdisp.c (set_cursor_from_row): Set start and stop points
2586 according to the row's direction when priming the loop that looks
2587 for the glyph on which to display cursor.
2588 (single_display_spec_intangible_p): Function deleted.
2589 (display_prop_intangible_p): Reimplement to call
2590 handle_display_spec instead of single_display_spec_intangible_p.
2591 Accept 3 additional arguments needed by handle_display_spec.
2592 This fixes incorrect cursor motion across display property with complex
2593 values: lists, `(when COND...)' forms, etc.
2594 (single_display_spec_string_p): Support property values that are
2595 lists with the argument STRING its top-level element.
2596 (display_prop_string_p): Fix the condition for processing a
2597 property that is a list to be consistent with handle_display_spec.
2598 (handle_display_spec): New function, refactored from the
2599 last portion of handle_display_prop.
2600 (compute_display_string_pos): Accept additional argument
2601 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2602 value of a `display' property is a "replacing spec".
2603 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2604 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2605 the display property, but just return a value indicating whether
2606 the display property will replace the characters it covers.
2607 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2608 frame_window_p members of struct bidi_it.
2609 (compute_display_string_pos, compute_display_string_end):
2610 New functions.
2611 (push_it): Accept second argument POSITION, where pop_it should
2612 jump to continue iteration.
2613 (reseat_1): Initialize bidi_it.disp_pos.
2614
2615 * keyboard.c (adjust_point_for_property): Adjust the call to
2616 display_prop_intangible_p to its new signature.
2617
2618 * dispextern.h (struct bidi_it): New member frame_window_p.
2619 (bidi_init_it): Update prototypes.
2620 (display_prop_intangible_p): Update prototype.
2621 (compute_display_string_pos, compute_display_string_end):
2622 Declare prototypes.
2623 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2624 EMACS_INT.
2625
2626 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2627
2628 Malloc failure behavior now depends on size of allocation.
2629 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2630 * lisp.h: Change signatures accordingly.
2631 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2632 All callers changed. (Bug#8762)
2633
2634 * gnutls.c: Use Emacs's memory allocators.
2635 Without this change, the gnutls library would invoke malloc etc.
2636 directly, which causes problems on non-SYNC_INPUT hosts, and which
2637 runs afoul of improving memory_full behavior. (Bug#8761)
2638 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2639 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2640 xfree instead of the default malloc, realloc, free.
2641 (Fgnutls_boot): No need to check for memory allocation failure,
2642 since xmalloc does that for us.
2643
2644 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2645 * category.c (hash_get_category_set):
2646 * ccl.c (ccl_driver):
2647 * charset.c (Fdefine_charset_internal):
2648 * charset.h (struct charset.hash_index):
2649 * composite.c (get_composition_id, gstring_lookup_cache)
2650 (composition_gstring_put_cache):
2651 * composite.h (struct composition.hash_index):
2652 * dispextern.h (struct image.hash):
2653 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2654 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2655 (hashfn_equal, hashfn_user_defined, make_hash_table)
2656 (maybe_resize_hash_table, hash_lookup, hash_put)
2657 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2658 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2659 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2660 * image.c (make_image, search_image_cache, lookup_image)
2661 (xpm_put_color_table_h):
2662 * lisp.h (struct Lisp_Hash_Table):
2663 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2664 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2665 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2666 * alloc.c (allocate_vectorlike):
2667 Check for overflow in vector size calculations.
2668 * ccl.c (ccl_driver):
2669 Check for overflow when converting EMACS_INT to int.
2670 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2671 need to be updated by these changes.
2672 * fns.c (make_hash_table, maybe_resize_hash_table):
2673 Check for integer overflow with large hash tables.
2674 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2675 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2676 (SXHASH_REDUCE): New macro.
2677 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2678 Use it instead of discarding useful hash info with large hash values.
2679 (sxhash_float): New function.
2680 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2681 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2682 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2683 Rewrite to use FIXNUM_BITS, as this simplifies things.
2684 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2685 Adjust signatures to match updated version of code.
2686 (consing_since_gc): Now EMACS_INT, since a single hash table can
2687 use more than INT_MAX bytes.
2688
2689 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2690
2691 Make it possible to build with GCC-4.6+ -O2 -flto.
2692
2693 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2694
2695 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2696
2697 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2698 Call minibuffer-inactive-mode.
2699
2700 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2701
2702 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2703 Update dependencies.
2704
2705 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2706
2707 * data.c (init_data): Remove code for UTS, this system is not
2708 supported anymore.
2709
2710 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2711
2712 Don't force ./temacs to start in terminal mode.
2713
2714 * frame.c (make_initial_frame): Initialize faces in all cases, not
2715 only when CANNOT_DUMP is defined.
2716 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2717
2718 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2719
2720 * dispnew.c (add_window_display_history): Use const for the string
2721 pointer. Remove declaration, not needed.
2722
2723 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2724
2725 Use 'inline', not 'INLINE'.
2726 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2727 * alloc.c, fontset.c (INLINE): Remove.
2728 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2729 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2730 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2731 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2732 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2733
2734 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2735
2736 Make it possible to run ./temacs.
2737
2738 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2739 syms_of_callproc does the same thing. Remove test for
2740 "initialized", do it in the caller.
2741 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2742
2743 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2744
2745 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2746 (read_minibuf): Use get_minibuffer.
2747 (syms_of_minibuf): Use DEFSYM.
2748 (Qmetadata): New var.
2749 * data.c (Qbuffer): Don't make it static.
2750 (syms_of_data): Use DEFSYM.
2751
2752 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2753
2754 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2755 (CCL_CODE_MIN): New macro.
2756
2757 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2758
2759 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2760
2761 * eval.c (Qdebug): Now static.
2762 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2763 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2764 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2765
2766 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2767
2768 * image.c: Various fixes to ImageMagick code comments.
2769 (Fimagemagick_types): Doc fix.
2770
2771 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2772
2773 Minor fixes prompted by GCC 4.6.0 warnings.
2774
2775 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2776
2777 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2778 (x_clipboard_manager_save_all): Move extern decl to ...
2779 * xterm.h: ... here, so that it can be checked for consistency.
2780
2781 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2782
2783 * xselect.c (x_clipboard_manager_save_frame)
2784 (x_clipboard_manager_save_all): New functions.
2785 (Fx_clipboard_manager_save): Lisp function deleted.
2786
2787 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2788 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2789
2790 * xterm.h: Update prototype.
2791
2792 2011-05-28 William Xu <william.xwl@gmail.com>
2793
2794 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2795 exiting (Bug#8239).
2796
2797 2011-05-28 Jim Meyering <meyering@redhat.com>
2798
2799 Avoid a sign-extension bug in crypto_hash_function.
2800 * fns.c (to_uchar): Define.
2801 (crypto_hash_function): Use it to convert some newly-signed
2802 variables to unsigned, to avoid sign-extension bugs. For example,
2803 without this change, (md5 "truc") would evaluate to
2804 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2805 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2806 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2807
2808 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2809
2810 Integer overflow fixes.
2811
2812 * dbusbind.c: Serial number integer overflow fixes.
2813 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2814 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2815 to hold a serial number that is too large for a fixnum.
2816 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2817 Check for serial numbers out of range. Decode any serial number
2818 that was so large that it became a float. (Bug#8722)
2819
2820 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2821 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2822 Use XFASTINT rather than XUINT when numbers are nonnegative.
2823 (xd_append_arg, Fdbus_method_return_internal):
2824 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2825 arguments, check that Lisp number is nonnegative, rather than
2826 silently wrapping negative numbers around. (Bug#8722)
2827 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2828 (Bug#8722)
2829
2830 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2831
2832 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2833
2834 ccl: add integer overflow checks
2835 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2836 (IN_INT_RANGE): New macros.
2837 (ccl_driver): Use them to check for integer overflow when
2838 decoding a CCL program. Many of the new checks are whether XINT (x)
2839 fits in int; it doesn't always, on 64-bit hosts. The new version
2840 doesn't catch all possible integer overflows, but it's an
2841 improvement. (Bug#8719)
2842
2843 * alloc.c (make_event_array): Use XINT, not XUINT.
2844 There's no need for unsigned here.
2845
2846 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2847 This follows up to the 2011-05-06 change that substituted uintptr_t
2848 for EMACS_INT. This case wasn't caught back then.
2849
2850 Rework Fformat to avoid integer overflow issues.
2851 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2852 now (part of C89). Include <verify.h>.
2853 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2854 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2855 (Fformat): Avoid the prepass trying to compute sizes; it was only
2856 approximate and thus did not catch overflow reliably. Instead, walk
2857 through the format just once, formatting and computing sizes as we go,
2858 checking for integer overflow at every step, and allocating a larger
2859 buffer as needed. Keep track separately whether the format is
2860 multibyte. Keep only the most-recently calculated precision, rather
2861 than them all. Record whether each argument has been converted to
2862 string. Use EMACS_INT, not int, for byte and char and arg counts.
2863 Support field widths and precisions larger than INT_MAX. Avoid
2864 sprintf's undefined behavior with conversion specifications such as %#d
2865 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2866 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2867 formatting out-of-range floating point numbers with int
2868 formats. (Bug#8668)
2869
2870 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2871
2872 * data.c: Avoid integer truncation in expressions involving floats.
2873 * data.c: Include <intprops.h>.
2874 (arith_driver): When there's an integer overflow in an expression
2875 involving floating point, convert the integers to floating point
2876 so that the resulting value does not suffer from catastrophic
2877 integer truncation. For example, on a 64-bit host (* 4
2878 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2879 Do not rely on undefined behavior after integer overflow.
2880
2881 merge count_size_as_multibyte, parse_str_to_multibyte
2882 * character.c, character.h (count_size_as_multibyte):
2883 Rename from parse_str_to_multibyte; all uses changed.
2884 Check for integer overflow.
2885 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2886 since it's now a duplicate of the other. This is more of
2887 a character than a buffer op, so better that it's in character.c.
2888 * fns.c, print.c: Adjust to above changes.
2889
2890 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2891
2892 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2893
2894 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2895
2896 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2897 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2898 (x_clipboard_manager_save): Now static.
2899 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2900
2901 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2902 (crypto_hash_function): Now static.
2903 Fix pointer signedness problems. Avoid unnecessary initializations.
2904
2905 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2906
2907 * termhooks.h (Vselection_alist): Make it terminal-local.
2908
2909 * terminal.c (create_terminal): Initialize it.
2910
2911 * xselect.c: Support for clipboard managers.
2912 (Vselection_alist): Move to termhooks.h as terminal-local var.
2913 (LOCAL_SELECTION): New macro.
2914 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2915 (symbol_to_x_atom): Remove gratuitous arg.
2916 (x_handle_selection_request, lisp_data_to_selection_data)
2917 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2918 (x_own_selection, x_get_local_selection, x_convert_selection):
2919 New arg, specifying work frame. Use terminal-local Vselection_alist.
2920 (some_frame_on_display): Delete unused function.
2921 (Fx_own_selection_internal, Fx_get_selection_internal)
2922 (Fx_disown_selection_internal, Fx_selection_owner_p)
2923 (Fx_selection_exists_p): New optional frame arg.
2924 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2925 (x_handle_selection_clear): Don't treat other terminals with the
2926 same keyboard specially. Use the terminal-local Vselection_alist.
2927 (x_clear_frame_selections): Use Frun_hook_with_args.
2928
2929 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2930
2931 * xterm.h: Add support for those atoms.
2932
2933 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2934
2935 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2936 (converted_selections, conversion_fail_tag): New global variables.
2937 (x_selection_request_lisp_error): Free the above.
2938 (x_get_local_selection): Remove unnecessary code.
2939 (x_reply_selection_request): Args changed; handle arbitrary array
2940 of converted selections stored in converted_selections.
2941 Separate the XChangeProperty and SelectionNotify steps.
2942 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2943 (x_convert_selection): New function.
2944 (x_handle_selection_event): Simplify.
2945 (x_get_foreign_selection): Don't ignore incoming requests while
2946 waiting for an answer; this will fail when we implement
2947 SAVE_TARGETS, and seems unnecessary anyway.
2948 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2949 (Vx_sent_selection_functions): Doc fix.
2950
2951 2011-05-26 Leo Liu <sdl.web@gmail.com>
2952
2953 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2954
2955 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2956
2957 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2958
2959 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2960 for fringe update if it has periodic bitmap.
2961 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2962 and fringe_bitmap_periodic_p.
2963
2964 * fringe.c (get_fringe_bitmap_data): New function.
2965 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2966 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2967 row. Mark glyph row for fringe update if periodicity changed.
2968
2969 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2970 for fringe update unless it has periodic bitmap.
2971
2972 2011-05-25 Kenichi Handa <handa@m17n.org>
2973
2974 * xdisp.c (get_next_display_element): Set correct it->face_id for
2975 a static composition.
2976
2977 2011-05-24 Leo Liu <sdl.web@gmail.com>
2978
2979 * deps.mk (fns.o):
2980 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2981
2982 * fns.c (crypto_hash_function, Fsha1): New function.
2983 (Fmd5): Use crypto_hash_function.
2984 (syms_of_fns): Add Ssha1.
2985
2986 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2987
2988 * gnutls.c: Remove unused macros.
2989 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2990 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2991 Remove macros that are defined and never used.
2992 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2993
2994 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2995
2996 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2997 (Fx_get_selection_internal): Minor cleanup.
2998 (Fx_own_selection_internal): Rename arguments for consistency with
2999 select.el.
3000
3001 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3002
3003 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3004
3005 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3006
3007 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3008
3009 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3010
3011 * dispnew.c (scrolling_window): Don't exclude the case that the
3012 last enabled row in the desired matrix touches the bottom boundary.
3013
3014 2011-05-21 Glenn Morris <rgm@gnu.org>
3015
3016 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3017 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3018 and add some more files.
3019
3020 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3021
3022 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3023 report_file_error introduced by the change from 2011-05-07.
3024
3025 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3026
3027 * systime.h (Time): Define only if emacs is defined.
3028 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3029 where the include path doesn't have X11/X.h by default. See
3030 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3031
3032 2011-05-20 Kenichi Handa <handa@m17n.org>
3033
3034 * composite.c (find_automatic_composition): Fix previous change.
3035
3036 2011-05-20 Glenn Morris <rgm@gnu.org>
3037
3038 * lisp.mk: New file, split from Makefile.in.
3039 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3040 (shortlisp): Remove.
3041 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3042
3043 2011-05-19 Glenn Morris <rgm@gnu.org>
3044
3045 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3046 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3047 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3048 (lisp): Set the order to that of loadup.el.
3049 (shortlisp): Make it a copy of $lisp.
3050 (SOME_MACHINE_LISP): Remove.
3051 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3052 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3053
3054 2011-05-18 Kenichi Handa <handa@m17n.org>
3055
3056 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3057 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3058 (find_automatic_composition): Mostly rewrite for efficiency.
3059
3060 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3061
3062 * makefile.w32-in: Update dependencies.
3063
3064 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3065
3066 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3067 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3068
3069 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3070
3071 Fix some integer overflow issues, such as string length overflow.
3072
3073 * insdel.c (count_size_as_multibyte): Check for string overflow.
3074
3075 * character.c (lisp_string_width): Check for string overflow.
3076 Use EMACS_INT, not int, for string indexes and lengths; in
3077 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3078 the resulting string length overflows an EMACS_INT; instead,
3079 report a string overflow if no precision given. When checking for
3080 precision exhaustion, use a check that cannot possibly have
3081 integer overflow. (Bug#8675)
3082 * character.h (lisp_string_width): Adjust to new signature.
3083
3084 * alloc.c (string_overflow): New function.
3085 (Fmake_string): Use it. This doesn't change behavior, but saves
3086 a few bytes and will simplify future changes.
3087 * character.c (string_escape_byte8): Likewise.
3088 * lisp.h (string_overflow): New decl.
3089
3090 Fixups, following up to the user-interface timestamp change.
3091 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3092 for UI timestamps, instead of unsigned long.
3093 * msdos.c (mouse_get_pos): Likewise.
3094 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3095 * w32gui.h (Time): Define by including "systime.h" rather than by
3096 declaring it ourselves. (Bug#8664)
3097
3098 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3099 * image.c (clear_image_cache): Likewise.
3100
3101 * term.c (term_mouse_position): Don't assume time_t wraparound.
3102
3103 Be more systematic about user-interface timestamps.
3104 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3105 and sometimes 'EMACS_UINT', to represent these timestamps.
3106 This change causes it to use 'Time' uniformly, as that's what X uses.
3107 This makes the code easier to follow, and makes it easier to catch
3108 integer overflow bugs such as Bug#8664.
3109 * frame.c (Fmouse_position, Fmouse_pixel_position):
3110 Use Time, not unsigned long, for user-interface timestamps.
3111 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3112 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3113 * keyboard.h (last_event_timestamp): Likewise.
3114 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3115 * menu.h (xmenu_show): Likewise.
3116 * term.c (term_mouse_position): Likewise.
3117 * termhooks.h (struct input_event.timestamp): Likewise.
3118 (struct terminal.mouse_position_hook): Likewise.
3119 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3120 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3121 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3122 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3123 what it was before.
3124 * menu.h, termhooks.h: Include "systime.h", for Time.
3125
3126 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3127 Don't assume that the difference between two unsigned long values
3128 can fit into an integer. At this point, we know button_down_time
3129 <= event->timestamp, so the difference must be nonnegative, so
3130 there's no need to cast the result if double-click-time is
3131 nonnegative, as it should be; check that it's nonnegative, just in
3132 case. This bug is triggered when events are more than 2**31 ms
3133 apart (about 25 days). (Bug#8664)
3134
3135 * xselect.c (last_event_timestamp): Remove duplicate decl.
3136 (x_own_selection): Remove needless cast to unsigned long.
3137
3138 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3139 that always fit in int. Use a sentinel instead of a counter, to
3140 avoid a temp and to allay GCC's concerns about possible int overflow.
3141 * frame.h (struct frame): Use int for menu_bar_items_used
3142 instead of EMACS_INT, since it always fits in int.
3143
3144 * menu.c (grow_menu_items): Check for int overflow.
3145
3146 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3147
3148 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3149 Before, the code was not consistent. These values cannot exceed
3150 2**31 - 1 so there's no need to make them unsigned.
3151 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3152 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3153 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3154 as modifiers.
3155 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3156
3157 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3158 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3159 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3160 presumably because the widths might not match.
3161
3162 * window.c (size_window): Avoid needless test at loop start.
3163
3164 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3165
3166 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3167
3168 2011-05-12 Drew Adams <drew.adams@oracle.com>
3169
3170 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3171
3172 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3173
3174 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3175 `width' to `bar_area_x' and `bar_area_width', respectively.
3176 (x_scroll_run): Take account of fringe background extension.
3177
3178 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3179 Rename local vars `left' and `width' to `bar_area_x' and
3180 `bar_area_width', respectively.
3181 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3182 background extension.
3183
3184 2011-05-10 Jim Meyering <meyering@redhat.com>
3185
3186 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3187
3188 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3189
3190 * image.c (Finit_image_library): Return t for built-in image types,
3191 like pbm and xbm. (Bug#8640)
3192
3193 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3194
3195 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3196
3197 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3198
3199 * w32console.c (Fset_screen_color): Doc fix.
3200 (Fget_screen_color): New function.
3201 (syms_of_ntterm): Defsubr it.
3202
3203 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3204 unlink the temporary file if Fcall_process didn't create it in the
3205 first place.
3206 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3207 child process will be redirected to a file specified with `:file'.
3208 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3209 cue to call_process_cleanup not to close that handle.
3210
3211 2011-05-07 Ben Key <bkey76@gmail.com>
3212
3213 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3214 one of two shell specific rules, either bootstrap-temacs-CMD or
3215 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3216 to the previous implementation of the bootstrap-temacs rule.
3217 The bootstrap-temacs-CMD rule is similar to the previous
3218 implementation of the bootstrap-temacs rule except that it
3219 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3220 variable.
3221
3222 These changes, along with some changes to nt/configure.bat,
3223 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3224 earlier fix to add support for --cflags and --ldflags options
3225 that include quotes so that it works whether make uses cmd or
3226 sh as the shell.
3227
3228 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3229
3230 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3231 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3232 is a constant.
3233 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3234 a string. Handle both cases.
3235 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3236 (Fdbus_register_method): Use Qinvalid_function.
3237
3238 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3239
3240 * makefile.w32-in: Update dependencies.
3241 (LISP_H): Add inttypes.h and stdin.h.
3242 (PROCESS_H): Add unistd.h.
3243
3244 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3245
3246 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3247 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3248
3249 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3250
3251 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3252
3253 * term.c (vfatal): Remove stray call to va_end.
3254 It's not needed and the C Standard doesn't allow it here anyway.
3255
3256 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3257 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3258
3259 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3260 bytes.
3261
3262 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3263
3264 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3265
3266 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3267
3268 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3269
3270 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3271
3272 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3273 * charset.c (Fdefine_charset_internal): Don't initialize
3274 charset.code_space[15]. The value was garbage, on hosts with
3275 32-bit int (Bug#8600).
3276
3277 * lread.c (read_integer): Be more consistent with string-to-number.
3278 Use string_to_number to do the actual conversion; this avoids
3279 rounding errors and fixes some other screwups. Without this fix,
3280 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3281 (digit_to_number): Move earlier, for benefit of read_integer.
3282 Return -1 if the digit is out of range for the base, -2 if it is
3283 not a digit in any supported base. (Bug#8602)
3284
3285 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3286
3287 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3288 to match comment at start of function. This also removes a
3289 GCC warning about overflow in a 32+64-bit port.
3290
3291 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3292
3293 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3294 Reported by Stefan Monnier in
3295 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3296 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3297 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3298
3299 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3300 (EMACS_UINTPTR): Likewise, with uintptr_t.
3301
3302 * lisp.h: Prefer 64-bit EMACS_INT if available.
3303 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3304 on 32-bit hosts that have 64-bit int, so that they can access
3305 large files.
3306 However, temporarily disable this change unless the temporary
3307 symbol WIDE_EMACS_INT is defined.
3308
3309 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3310
3311 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3312 This removes an assumption that EMACS_INT and long are the same
3313 width as pointers. The assumption is true for Emacs porting targets
3314 now, but we want to make other targets possible.
3315 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3316 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3317 In the rest of the code, change types of integers that hold casted
3318 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3319 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3320 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3321 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3322 No need to cast type when ORing.
3323 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3324 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3325 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3326 assume EMACS_INT is the same width as char *.
3327 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3328 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3329 Remove no-longer-needed casts.
3330 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3331 (xg_tool_bar_help_callback, xg_make_tool_item):
3332 Use EMACS_INTPTR to hold an integer
3333 that will be cast to void *; this can avoid a GCC warning
3334 if EMACS_INT is not the same width as void *.
3335 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3336 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3337 (current_message_1, set_message_1):
3338 Use a local to convert to proper width without a cast.
3339 * xmenu.c (dialog_selection_callback): Likewise.
3340
3341 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3342 Also, don't assume VALBITS / RAND_BITS is less than 5,
3343 and don't rely on undefined behavior when shifting a 1 left into
3344 the sign bit.
3345 * lisp.h (get_random): Change signature to match.
3346
3347 * lread.c (hash_string): Use size_t, not int, for hash computation.
3348 Normally we prefer signed values; but hashing is special, because
3349 it's better to use unsigned division on hash table sizes so that
3350 the remainder is nonnegative. Also, size_t is the natural width
3351 for hashing into memory. The previous code used 'int', which doesn't
3352 retain enough info to hash well into very large tables.
3353 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3354
3355 * dbusbind.c: Don't possibly lose pointer info when converting.
3356 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3357 Use XPNTR rather than XHASH, so that the high-order bits of
3358 the pointer aren't lost when converting through void *.
3359
3360 * eval.c (Fautoload): Don't double-shift a pointer.
3361
3362 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3363
3364 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3365
3366 * gnutls.c (DEF_GNUTLS_FN):
3367 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3368
3369 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3370
3371 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3372 marker. (Bug#8610)
3373
3374 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3375
3376 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3377 New version that can reserve upto 2GB of heap space.
3378
3379 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3380
3381 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3382
3383 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3384
3385 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3386 `gnutls_certificate_set_x509_key_file'.
3387
3388 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3389
3390 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3391 Update dependencies.
3392
3393 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3394
3395 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3396 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3397 Remove unused parameter `fildes'.
3398 * process.c (read_process_output, send_process): Don't pass it.
3399
3400 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3401
3402 Fix previous change: the library cache is defined in w32.c.
3403 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3404 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3405
3406 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3407
3408 Implement dynamic loading of GnuTLS on Windows.
3409
3410 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3411 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3412 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3413 Declare.
3414
3415 * gnutls.c (Qgnutls_dll): Define.
3416 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3417 (gnutls_*): Declare function pointers.
3418 (init_gnutls_functions): New function to initialize function pointers.
3419 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3420 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3421 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3422 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3423 (emacs_gnutls_write, emacs_gnutls_read)
3424 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3425 (Fgnutls_available_p): New function.
3426 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3427 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3428 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3429
3430 * image.c: Include w32.h.
3431 (Vimage_type_cache): Delete.
3432 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3433 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3434 (w32_delayed_load): Move to w32.c.
3435
3436 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3437
3438 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3439 (w32_delayed_load): Move from image.c. When loading a library, record
3440 its filename in the :loaded-from property of the library id.
3441 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3442 Initialize and staticpro them.
3443 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3444
3445 * process.c: Include lisp.h before w32.h, not after.
3446 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3447 instead of gnutls_record_check_pending.
3448
3449 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3450
3451 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3452
3453 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3454 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3455 as passed in.
3456
3457 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3458
3459 * xterm.c (x_set_frame_alpha): Do not set property on anything
3460 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3461
3462 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3463
3464 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3465
3466 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3467
3468 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3469 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3470 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3471 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3472 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3473 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3474 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3475 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3476 (Qgnutls_bootprop_callbacks_verify): Make static.
3477
3478 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3479
3480 * callproc.c: Indentation fixup.
3481
3482 * sysdep.c (wait_for_termination_1): Make static.
3483 (wait_for_termination, interruptible_wait_for_termination):
3484 Move after wait_for_termination_1.
3485
3486 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3487
3488 * sysdep.c (interruptible_wait_for_termination): New function
3489 which is like wait_for_termination, but allows keyboard
3490 interruptions.
3491
3492 * callproc.c (Fcall_process): Add (:file "file") as an option for
3493 the STDOUT buffer.
3494 (Fcall_process_region): Ditto.
3495
3496 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3497
3498 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3499 rather than `XVECTOR (FOO)->size'.
3500
3501 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3502 inttypes.h, as a gnulib replacement is used if it not available in
3503 system headers.
3504
3505 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3506
3507 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3508 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3509 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3510
3511 * coding.c (coding_alloc_by_realloc): Error out if destination
3512 will grow beyond MOST_POSITIVE_FIXNUM.
3513 (decode_coding_emacs_mule): Abort if there isn't enough place in
3514 charbuf for the composition carryover bytes. Reserve an extra
3515 space for up to 2 characters produced in a loop.
3516 (decode_coding_iso_2022): Abort if there isn't enough place in
3517 charbuf for the composition carryover bytes.
3518
3519 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3520
3521 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3522 aborting when %lld or %lll format is passed.
3523 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3524 %llo or %llx format is passed. (Bug#8545)
3525
3526 * window.c (window_scroll_line_based): Use a marker instead of
3527 simple variables to record original value of point. (Bug#7952)
3528
3529 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3530 produced by %s or %c overflows available buffer space. (Bug#8545)
3531
3532 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3533
3534 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3535 (SIZE_MAX): Move defn after all includes, as they might #define it.
3536
3537 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3538
3539 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3540
3541 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3542
3543 * keyboard.c (Qdelayed_warnings_hook): Define.
3544 (command_loop_1): Run `delayed-warnings-hook'
3545 if Vdelayed_warnings_list is non-nil.
3546 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3547 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3548
3549 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3550
3551 * doprnt.c (doprnt): Don't return value smaller than the buffer
3552 size if the message was truncated. (Bug#8545).
3553
3554 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3555
3556 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3557 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3558
3559 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3560
3561 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3562
3563 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3564
3565 * makefile.w32-in: Update dependencies.
3566
3567 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3568
3569 Improve `doprnt' and its usage. (Bug#8545)
3570 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3571 `format_end'. Remove support for %l as a conversion specifier.
3572 Don't use xrealloc. Improve diagnostics when the %l size modifier
3573 is used. Update the commentary.
3574
3575 * eval.c (verror): Simplify calculation of size_t.
3576
3577 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3578 messages.
3579
3580 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3581
3582 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3583 change.
3584
3585 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3586
3587 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3588 This makes this file independent of the recent pseudovector change.
3589
3590 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3591
3592 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3593
3594 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3595 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3596 Remove unused local.
3597 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3598
3599 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3600 GCC 4.6.0 optimizes based on type-based alias analysis.
3601 For example, if b is of type struct buffer * and v of type struct
3602 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3603 != &v->size, and therefore "v->size = 1; b->size = 2; return
3604 v->size;" must therefore return 1. This assumption is incorrect
3605 for Emacs, since it type-puns struct Lisp_Vector * with many other
3606 types. To fix this problem, this patch adds a new type struct
3607 vectorlike_header that documents the constraints on layout of vectors
3608 and pseudovectors, and helps optimizing compilers not get fooled
3609 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3610 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3611 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3612 the size member.
3613 (XSETPVECTYPE): Rewrite in terms of new macro.
3614 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3615 This is a bit clearer, and further avoids the possibility of
3616 undesirable aliasing.
3617 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3618 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3619 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3620 since Lisp_Subr is a special case (no "next" field).
3621 (ASIZE): Now uses header.size rather than size.
3622 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3623 to avoid the hassle of writing XVECTOR (foo)->header.size.
3624 (struct vectorlike_header): New type.
3625 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3626 object, to help avoid aliasing.
3627 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3628 (SUBRP): Likewise, since Lisp_Subr is a special case.
3629 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3630 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3631 (struct Lisp_Hash_Table): Combine first two members into a single
3632 struct vectorlike_header member. All uses of "size" and "next" members
3633 changed to be "header.size" and "header.next".
3634 * buffer.h (struct buffer): Likewise.
3635 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3636 * frame.h (struct frame): Likewise.
3637 * process.h (struct Lisp_Process): Likewise.
3638 * termhooks.h (struct terminal): Likewise.
3639 * window.c (struct save_window_data, struct saved_window): Likewise.
3640 * window.h (struct window): Likewise.
3641 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3642 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3643 * buffer.c (init_buffer_once): Likewise.
3644 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3645 special case.
3646 * process.c (Fformat_network_address): Use local var for size,
3647 for brevity.
3648
3649 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3650
3651 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3652 * data.c (atof): Remove decl; no longer used or needed.
3653 (digit_to_number): Move to lread.c.
3654 (Fstring_to_number): Use new string_to_number function, to be
3655 consistent with how the Lisp reader treats infinities and NaNs.
3656 Do not assume that floating-point numbers represent EMACS_INT
3657 without losing information; this is not true on most 64-bit hosts.
3658 Avoid double-rounding errors, by insisting on integers when
3659 parsing non-base-10 numbers, as the documentation specifies.
3660 * lisp.h (string_to_number): New decl, replacing ...
3661 (isfloat_string): Remove.
3662 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3663 (read1): Do not accept +. and -. as integers; this
3664 appears to have been a coding error. Similarly, do not accept
3665 strings like +-1e0 as floating point numbers. Do not report
3666 overflow for integer overflows unless the base is not 10 which
3667 means we have no simple and reliable way to continue.
3668 Break out the floating-point parsing into a new
3669 function string_to_number, so that Fstring_to_number parses
3670 floating point numbers consistently with the Lisp reader.
3671 (digit_to_number): Move here from data.c. Make it static inline.
3672 (E_CHAR, EXP_INT): Remove, replacing with ...
3673 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3674 (string_to_number): New function, replacing isfloat_string.
3675 This function checks for valid syntax and produces the resulting
3676 Lisp float number too. Rework it so that string-to-number
3677 no longer mishandles examples like "1.0e+". Use strtoumax,
3678 so that overflow for non-base-10 numbers is reported only when
3679 there's no portable and simple way to convert to floating point.
3680
3681 * textprop.c (set_text_properties_1): Rewrite for clarity,
3682 and to avoid GCC warning about integer overflow.
3683
3684 * intervals.h (struct interval): Use EMACS_INT for members
3685 where EMACS_UINT might cause problems. See
3686 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3687 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3688 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3689 All uses changed.
3690 (offset_intervals): Tell GCC not to worry about length overflow
3691 when negating a negative length.
3692
3693 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3694 (overrun_check_free): Likewise.
3695
3696 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3697 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3698 word size.
3699
3700 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3701 (gnutls_make_error): Rename local to avoid shadowing.
3702 (gnutls_emacs_global_deinit): ifdef out; not used.
3703 (Fgnutls_boot): Use const for pointer to readonly storage.
3704 Comment out unused local. Fix pointer signedness problems.
3705
3706 * lread.c (openp): Don't stuff size_t into an 'int'.
3707 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3708 about possible signed overflow.
3709
3710 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3711 (GDK_KEY_g): Don't define if already defined.
3712 (xg_prepare_tooltip): Avoid pointer signedness problem.
3713 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3714
3715 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3716 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3717
3718 * xfns.c (Fx_window_property): Simplify a bit,
3719 to make a bit faster and to avoid GCC 4.6.0 warning.
3720 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3721
3722 * fns.c (internal_equal): Don't assume size_t fits in int.
3723
3724 * alloc.c (compact_small_strings): Tighten assertion a little.
3725
3726 Replace pEd with more-general pI, and fix some printf arg casts.
3727 * lisp.h (pI): New macro, generalizing old pEd macro to other
3728 conversion specifiers. For example, use "...%"pI"d..." rather
3729 than "...%"pEd"...".
3730 (pEd): Remove. All uses replaced with similar uses of pI.
3731 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3732 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3733 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3734 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3735 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3736 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3737 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3738 64-bit hosts.
3739 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3740 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3741 * print.c (safe_debug_print, print_object): Likewise.
3742 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3743 to int.
3744 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3745 avoiding the 0 flag, which is not portable.
3746 * process.c (Fmake_network_process): Use pI to avoid cast.
3747 * region-cache.c (pp_cache): Likewise.
3748 * xdisp.c (decode_mode_spec): Likewise.
3749 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3750 behavior on 64-bit hosts with printf arg.
3751 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3752 (x_stop_queuing_selection_requests): Likewise.
3753 (x_get_window_property): Don't truncate byte count to an 'int'
3754 when tracing.
3755
3756 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3757 here, since it parses constructs like leading '-' and spaces,
3758 which are not wanted; and it overflows with large numbers.
3759 Instead, simply match F[0-9]+, which is what is wanted anyway.
3760
3761 * alloc.c: Remove unportable assumptions about struct layout.
3762 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3763 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3764 (allocate_vectorlike, make_pure_vector): Use the new macros,
3765 plus offsetof, to remove unportable assumptions about struct layout.
3766 These assumptions hold on all porting targets that I know of, but
3767 they are not guaranteed, they're easy to remove, and removing them
3768 makes further changes easier.
3769
3770 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3771 This doesn't fix a bug but makes the code clearer.
3772 (string_overrun_cookie): Now const. Use initializers that
3773 don't formally overflow signed char, to avoid warnings.
3774 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3775 can cause Emacs to crash when string overrun checking is enabled.
3776 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3777 multiple of sizeof (EMACS_INT); it need not be, if
3778 alignof(EMACS_INT) < sizeof (EMACS_INT).
3779 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3780
3781 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3782
3783 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3784
3785 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3786
3787 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3788 supposed to be handshaking. (Bug#8556)
3789 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3790
3791 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3792
3793 * lisp.h (Qdebug): List symbol.
3794 * eval.c (Qdebug): Restore global linkage.
3795 * keyboard.c (debug-on-event): New variable.
3796 (handle_user_signal): Break into debugger when debug-on-event
3797 matches the current signal symbol.
3798
3799 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3800
3801 * alloc.c (check_sblock, check_string_bytes)
3802 (check_string_free_list): Convert to standard C.
3803
3804 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3805
3806 * w32.c (emacs_gnutls_push): Fix typo.
3807
3808 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3809
3810 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3811 "cast to pointer from integer of different size".
3812
3813 Improve doprnt and its use in verror. (Bug#8545)
3814 * doprnt.c (doprnt): Document the set of format control sequences
3815 supported by the function. Use SAFE_ALLOCA instead of always
3816 using `alloca'.
3817
3818 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3819 is one byte too soon. Don't use xrealloc; instead xfree and
3820 xmalloc anew.
3821
3822 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3823
3824 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3825 callbacks stage.
3826
3827 * gnutls.c: Renamed global_initialized to
3828 gnutls_global_initialized. Added internals for the
3829 :verify-hostname-error, :verify-error, and :verify-flags
3830 parameters of `gnutls-boot' and documented those parameters in the
3831 docstring. Start callback support.
3832 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3833 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3834 on error. Return error code.
3835 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3836 (emacs_gnutls_read): Likewise.
3837 (Fgnutls_boot): Return handshake error code.
3838 (emacs_gnutls_handle_error): New function.
3839 (wsaerror_to_errno): Likewise.
3840
3841 * w32.h (emacs_gnutls_pull): Add prototype.
3842 (emacs_gnutls_push): Likewise.
3843
3844 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3845 (emacs_gnutls_push): Likewise.
3846
3847 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3848
3849 * process.c (wait_reading_process_output): Check if GnuTLS
3850 buffered some data internally if no FDs are set for TLS
3851 connections.
3852
3853 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3854 (LIBS): Link to USER_LIBS.
3855 ($(BLD)/gnutls.$(0)): New target.
3856
3857 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3858
3859 * xdisp.c (handle_single_display_spec): Rename the
3860 display_replaced_before_p argument into display_replaced_p, to
3861 make it consistent with the commentary. Fix typos in the
3862 commentary.
3863
3864 * textprop.c (syms_of_textprop): Remove dead code.
3865 (copy_text_properties): Delete obsolete commentary about an
3866 interface that was deleted long ago. Fix typos in the description
3867 of arguments.
3868
3869 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3870 to changes in oldXMenu/XMenu.h from 2011-04-16.
3871 <menu_help_message, prev_menu_help_message>: Constify.
3872 (IT_menu_make_room): menu->help_text is now `const char **';
3873 adjust.
3874
3875 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3876 to changes in oldXMenu/XMenu.h from 2011-04-16.
3877 (struct XMenu): Declare `help_text' `const char **'.
3878
3879 * xfaces.c <Qunspecified>: Make extern again.
3880
3881 * syntax.c: Include sys/types.h before including regex.h, as
3882 required by Posix.
3883
3884 * doc.c (get_doc_string): Improve the format passed to `error'.
3885
3886 * doprnt.c (doprnt): Improve commentary.
3887
3888 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3889
3890 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3891 them with etags.
3892
3893 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3894 changes in globals.h immediately force recompilation.
3895 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3896 $(CURDIR)/s/ms-w32.h.
3897 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3898
3899 * character.c (Fchar_direction): Function deleted.
3900 (syms_of_character): Don't defsubr it.
3901 <char-direction-table>: Deleted.
3902
3903 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3904
3905 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3906 * doprnt.c: Include limits.h.
3907 (SIZE_MAX): New macro.
3908 (doprnt): Return a size_t value. 2nd arg is now size_t.
3909 Many local variables are now size_t instead of int or unsigned.
3910 Improve overflow protection. Support `l' modifier for integer
3911 conversions. Support %l conversion. Don't assume an EMACS_INT
3912 argument for integer conversions and for %c.
3913
3914 * lisp.h (doprnt): Restore prototype.
3915
3916 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3917 $(SRC)/character.h.
3918
3919 * Makefile.in (base_obj): Add back doprnt.o.
3920
3921 * deps.mk (doprnt.o): Add back prerequisites.
3922 (callint.o): Depend on character.h.
3923
3924 * eval.c (internal_lisp_condition_case): Include the handler
3925 representation in the error message.
3926 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3927 when breaking from the loop.
3928
3929 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3930
3931 * callint.c (Fcall_interactively): When displaying error message
3932 about invalid control letter, pass the character's codepoint, not
3933 a pointer to its multibyte form. Improve display of the character
3934 in octal and display also its hex code.
3935
3936 * character.c (char_string): Use %x to display the (unsigned)
3937 codepoint of an invalid character, to avoid displaying a bogus
3938 negative value.
3939
3940 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3941 `error', not SYMBOL_NAME itself.
3942
3943 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3944 character arguments to `error'.
3945
3946 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3947 to `error' in error message about FINAL_CHAR argument. Make sure
3948 FINAL_CHAR is a character, and use %c when it is passed as
3949 argument to `error'.
3950
3951 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3952
3953 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3954
3955 * w32.c: Include <time.h>.
3956 (sys_localtime): New function.
3957
3958 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
3959
3960 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3961
3962 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3963
3964 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3965
3966 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3967 zombies (Bug#8467).
3968
3969 2011-04-19 Eli Zaretskii <eliz@gnu.org>
3970
3971 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3972 gl_state.e_property when gl_state.object is Qt.
3973
3974 * insdel.c (make_gap_larger): Remove limitation of buffer size
3975 to <= INT_MAX.
3976
3977 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
3978
3979 * xdisp.c (lookup_glyphless_char_display)
3980 (produce_glyphless_glyph): Handle cons cell entry in
3981 glyphless-char-display.
3982 (Vglyphless_char_display): Document it.
3983
3984 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3985 glyphless-char-display.
3986
3987 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
3988
3989 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3990
3991 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3992
3993 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3994 definition for no-X builds.
3995
3996 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3997
3998 Static checks with GCC 4.6.0 and non-default toolkits.
3999
4000 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4001
4002 * process.c (keyboard_bit_set): Define only if SIGIO.
4003 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4004 (send_process): Repair possible setjmp clobbering.
4005
4006 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4007
4008 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4009
4010 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4011
4012 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4013 Define only if needed.
4014
4015 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4016 by pacifying GCC about it. Maybe it's time to retire it?
4017 * xfaces.c (USG, __TIMEVAL__): Likewise.
4018
4019 * dispextern.h (struct redisplay_interface): Rename param
4020 to avoid shadowing.
4021 * termhooks.h (struct terminal): Likewise.
4022 * xterm.c (xembed_send_message): Likewise.
4023
4024 * insdel.c (make_gap_smaller): Define only if
4025 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4026
4027 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4028 it.
4029
4030 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4031 so that we aren't warned about unused symbols.
4032
4033 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4034
4035 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4036
4037 * xfns.c (x_real_positions): Mark locals as initialized.
4038
4039 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4040
4041 * xterm.c: Fix problems found by static analysis with other toolkits.
4042 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4043 (x_dispatch_event): Declare static if USE_GTK, and
4044 define if USE_GTK || USE_X_TOOLKIT.
4045 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4046 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4047 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4048 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4049
4050 * xmenu.c (menu_help_callback): Pointer type fixes.
4051 Use const pointers when pointing at readonly data. Avoid pointer
4052 signedness clashes.
4053 (FALSE): Remove unused macro.
4054 (update_frame_menubar): Remove unused decl.
4055
4056 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4057
4058 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4059 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4060 (single_menu_item): Rename local to avoid shadowing.
4061
4062 * keyboard.c (make_lispy_event): Remove unused local var.
4063
4064 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4065 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4066
4067 * bitmaps: Change bitmaps from unsigned char back to the X11
4068 compatible char. Avoid the old compiler warnings about
4069 out-of-range initializers by using, for example, '\xab' rather
4070 than 0xab.
4071
4072 * xgselect.c (xgselect_initialize): Check vs interface
4073 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4074
4075 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4076
4077 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4078 to read-only memory.
4079
4080 * fns.c (vector): Remove; this old hack is no longer needed.
4081
4082 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4083 Remove unused var.
4084 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4085
4086 * xrdb.c (x_load_resources): Omit unused local.
4087
4088 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4089 (x_window): Rename locals to avoid shadowing.
4090 (USG): Use the kludged USG macro, to pacify gcc.
4091
4092 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4093 (x_term_init): Remove local to avoid shadowing.
4094
4095 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4096
4097 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4098 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4099
4100 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4101
4102 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4103
4104 Fix regex.c, syntax.c and friends for buffers > 2GB.
4105 * syntax.h (struct gl_state_s): Declare character position members
4106 EMACS_INT.
4107
4108 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4109
4110 * textprop.c (verify_interval_modification, interval_of):
4111 Declare arguments EMACS_INT.
4112
4113 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4114 EMACS_INT.
4115
4116 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4117
4118 * indent.c (Fvertical_motion): Local variable it_start is now
4119 EMACS_INT.
4120
4121 * regex.c (re_match, re_match_2, re_match_2_internal)
4122 (bcmp_translate, regcomp, regexec, print_double_string)
4123 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4124 (re_compile_pattern, re_exec): Declare arguments and local
4125 variables `size_t' and `ssize_t' and return values `regoff_t', as
4126 appropriate.
4127 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4128 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4129 <compile_stack_type>: `size' and `avail' are now `size_t'.
4130
4131 * regex.h <regoff_t>: Use ssize_t, not int.
4132 (re_search, re_search_2, re_match, re_match_2): Arguments that
4133 specify buffer/string position and length are now ssize_t and
4134 size_t. Return type is regoff_t.
4135
4136 2011-04-16 Ben Key <bkey76@gmail.com>
4137
4138 * nsfont.m: Fixed bugs in ns_get_family and
4139 ns_descriptor_to_entity that were caused by using free to
4140 deallocate memory blocks that were allocated by xmalloc (via
4141 xstrdup). This caused Emacs to crash when compiled with
4142 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4143 --enable-checking=xmallocoverrun). xfree is now used to
4144 deallocate these memory blocks.
4145
4146 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4147
4148 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4149
4150 emacs_write: Accept and return EMACS_INT for sizes.
4151 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4152 et seq.
4153 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4154 Accept and return EMACS_INT.
4155 (emacs_gnutls_write): Return the number of bytes written on
4156 partial writes.
4157 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4158 (emacs_read, emacs_write): Remove check for negative size, as the
4159 Emacs source code has been audited now.
4160 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4161 (emacs_read, emacs_write): Use it.
4162 * process.c (send_process): Adjust to the new signatures of
4163 emacs_write and emacs_gnutls_write. Do not attempt to store
4164 a byte offset into an 'int'; it might overflow.
4165 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4166
4167 * sound.c: Don't assume sizes fit in 'int'.
4168 (struct sound_device.period_size, alsa_period_size):
4169 Return EMACS_INT, not int.
4170 (struct sound_device.write, vox_write, alsa_write):
4171 Accept EMACS_INT, not int.
4172 (wav_play, au_play): Use EMACS_INT to store sizes and to
4173 record read return values.
4174
4175 2011-04-15 Ben Key <bkey76@gmail.com>
4176
4177 * keyboard.c (Qundefined): Don't declare static since it is used
4178 in nsfns.m.
4179 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4180 static since they are used in nsfont.m.
4181
4182 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4183
4184 * process.c (Qprocessp): Don't declare static.
4185 * lisp.h (Qprocessp): Declare again.
4186
4187 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4188
4189 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4190
4191 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4192
4193 Improve C-level modularity by making more things 'static'.
4194
4195 Don't publish debugger-only interfaces to other modules.
4196 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4197 (verify_bytepos, count_markers): Move decls to the only modules
4198 that need them.
4199 * region-cache.h (pp_cache): Likewise.
4200 * window.h (check_all_windows): Likewise.
4201 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4202
4203 * sysdep.c (croak): Now static, if
4204 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4205 * syssignal.h (croak): Declare only if not static.
4206
4207 * alloc.c (refill_memory_reserve): Now static if
4208 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4209 * lisp.h (refill_memory_reserve): Declare only if not static.
4210
4211 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4212 Define only if USE_LUCID.
4213
4214 * xrdb.c (x_customization_string, x_rm_string): Now static.
4215
4216 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4217 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4218
4219 * xdisp.c (draw_row_with_mouse_face): Now static.
4220 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4221
4222 * window.h (check_all_windows): Mark externally visible.
4223
4224 * window.c (window_deletion_count): Now static.
4225
4226 * undo.c: Make symbols static if they're not exported.
4227 (last_undo_buffer, last_boundary_position, pending_boundary):
4228 Now static.
4229
4230 * textprop.c (interval_insert_behind_hooks): Now static.
4231 (interval_insert_in_front_hooks): Likewise.
4232
4233 * term.c: Make symbols static if they're not exported.
4234 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4235 (max_frame_lines, tty_set_terminal_modes):
4236 (tty_reset_terminal_modes, tty_turn_off_highlight):
4237 (get_tty_terminal): Now static.
4238 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4239 * termhooks.h (term_mouse_moveto): Do not declare if
4240 HAVE_WINDOW_SYSTEM.
4241 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4242 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4243
4244 * sysdep.c: Make symbols static if they're not exported.
4245 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4246 Now static.
4247 (sigprocmask_set, full_mask): Remove; unused.
4248 (wait_debugging): Mark as visible.
4249 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4250 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4251
4252 * syntax.c (syntax_temp): Define only if !__GNUC__.
4253
4254 * sound.c (current_sound_device, current_sound): Now static.
4255
4256 * search.c (searchbufs, searchbuf_head): Now static.
4257
4258 * scroll.c (scroll_cost): Remove; unused.
4259 * dispextern.h (scroll_cost): Remove decl.
4260
4261 * region-cache.h (pp_cache): Mark as externally visible.
4262
4263 * process.c: Make symbols static if they're not exported.
4264 (process_tick, update_tick, create_process, chan_process):
4265 (Vprocess_alist, proc_buffered_char, datagram_access):
4266 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4267 (deactivate_process): Mark defn as static, as well as decl.
4268 * lisp.h (create_process): Remove decl.
4269 * process.h (chan_process, Vprocess_alist): Remove decls.
4270
4271 * print.c: Make symbols static if they're not exported.
4272 (print_depth, new_backquote_output, being_printed, print_buffer):
4273 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4274 (print_interval, print_number_index, initial_stderr_stream):
4275 Now static.
4276 * lisp.h (Fprinc): Remove decl.
4277 (debug_output_compilation_hack): Mark as externally visible.
4278
4279 * sysdep.c (croak): Move decl from here to syssignal.h.
4280 * syssignal.h (croak): Put it here, so the API can be checked when
4281 'croak' is called from dissociate_if_controlling_tty.
4282
4283 * minibuf.c: Make symbols static if they're not exported.
4284 (minibuf_save_list, choose_minibuf_frame): Now static.
4285 * lisp.h (choose_minibuf_frame): Remove decl.
4286
4287 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4288
4289 * lread.c: Make symbols static if they're not exported.
4290 (read_objects, initial_obarray, oblookup_last_bucket_number):
4291 Now static.
4292 (make_symbol): Remove; unused.
4293 * lisp.h (initial_obarray, make_symbol): Remove decls.
4294
4295 * keyboard.c: Make symbols static if they're not exported.
4296 (single_kboard, recent_keys_index, total_keys, recent_keys):
4297 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4298 (this_single_command_key_start, echoing, last_auto_save):
4299 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4300 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4301 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4302 (Vlispy_mouse_stem, double_click_count):
4303 Now static.
4304 (force_auto_save_soon): Define only if SIGDANGER.
4305 (ignore_mouse_drag_p): Now static if
4306 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4307 (print_help): Remove; unused.
4308 (stop_character, last_timer_event): Mark as externally visible.
4309 * keyboard.h (ignore_mouse_drag_p): Declare only if
4310 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4311 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4312 * lisp.h (echoing): Remove decl.
4313 (force_auto_save_soon): Declare only if SIGDANGER.
4314 * xdisp.c (redisplay_window): Simplify code, to make it more
4315 obvious that ignore_mouse_drag_p is not accessed if !defined
4316 USE_GTK && !defined HAVE_NS.
4317
4318 * intervals.c: Make symbols static if they're not exported.
4319 (merge_properties_sticky, merge_interval_right, delete_interval):
4320 Now static.
4321 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4322
4323 * insdel.c: Make symbols static if they're not exported.
4324 However, leave prepare_to_modify_buffer alone. It's never
4325 called from outside this function, but that appears to be a bug.
4326 (combine_after_change_list, combine_after_change_buffer):
4327 (adjust_after_replace, signal_before_change): Now static.
4328 (adjust_after_replace_noundo): Remove; unused.
4329 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4330 (signal_before_change): Remove decls.
4331
4332 * indent.c (val_compute_motion, val_vmotion): Now static.
4333
4334 * image.c: Make symbols static if they're not exported.
4335 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4336 if USE_GTK.
4337 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4338 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4339
4340 * fringe.c (standard_bitmaps): Now static.
4341 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4342
4343 * frame.c: Make symbols static if they're not exported.
4344 (x_report_frame_params, make_terminal_frame): Now static.
4345 (get_frame_param): Now static, unless HAVE_NS.
4346 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4347 (x_get_resource_string): Remove; not used.
4348 * frame.h (make_terminal_frame, x_report_frame_params):
4349 (x_get_resource_string); Remove decls.
4350 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4351 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4352
4353 * font.c, fontset.c: Make symbols static if they're not exported.
4354 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4355 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4356 * font.c (font_close_object): Now static.
4357 * font.h (font_close_object): Remove.
4358 * fontset.c (FONTSET_OBJLIST): Remove.
4359 (free_realized_fontset) #if-0 the body, which does nothing.
4360 (face_suitable_for_char_p): #if-0, as it's never called.
4361 * fontset.h (face_suitable_for_char_p): Remove decl.
4362 * xfaces.c (face_at_string_position):
4363 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4364 since 0 is always ASCII.
4365
4366 * fns.c (weak_hash_tables): Now static.
4367
4368 * fileio.c: Make symbols static if they're not exported.
4369 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4370 (Vwrite_region_annotation_buffers): Now static.
4371
4372 * eval.c: Make symbols static if they're not exported.
4373 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4374 * lisp.h (backtrace_list): Remove decl.
4375
4376 * emacs.c: Make symbols static if they're not exported.
4377 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4378 (fatal_error_code, fatal_error_signal_hook, standard_args):
4379 Now static.
4380 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4381 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4382 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4383 * lisp.h (fatal_error_signal_hook): Remove decl.
4384 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4385
4386 * editfns.c: Move a (normally-unused) function to its only use.
4387 * editfns.c, lisp.h (get_operating_system_release): Remove.
4388 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4389 worth the hassle of breaking this out.
4390
4391 * xterm.c: Make symbols static if they're not exported.
4392 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4393 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4394 (x_destroy_window, x_delete_display):
4395 Now static.
4396 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4397 (x_mouse_leave): Remove; unused.
4398 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4399 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4400 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4401 Remove decls.
4402 (x_mouse_leave): Declare only if WINDOWSNT.
4403 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4404 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4405 USE_X_TOOLKIT.
4406
4407 * ftxfont.c: Make symbols static if they're not exported.
4408 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4409 HAVE_FREETYPE.
4410 * font.h (ftxfont_driver): Likewise.
4411
4412 * xfns.c: Make symbols static if they're not exported.
4413 (x_last_font_name, x_display_info_for_name):
4414 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4415 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4416 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4417 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4418 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4419 (last_show_tip_args): Now static.
4420 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4421 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4422 (x_screen_planes): Remove; unused.
4423 * dispextern.h (x_screen_planes): Remove decl.
4424
4425 * dispnew.c: Make symbols static if they're not exported.
4426 * dispextern.h (redraw_garbaged_frames, scrolling):
4427 (increment_row_positions): Remove.
4428 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4429 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4430 Now static.
4431 (redraw_garbaged_frames): Remove; unused.
4432
4433 * xfaces.c: Make symbols static if they're not exported.
4434 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4435 Remove decls.
4436 * xterm.h (defined_color): Remove decls.
4437 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4438 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4439 (menu_face_changed_default, defined_color, free_realized_face):
4440 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4441 (ascii_face_of_lisp_face): Remove; unused.
4442
4443 * xdisp.c: Make symbols static if they're not exported.
4444 * dispextern.h (scratch_glyph_row, window_box_edges):
4445 (glyph_to_pixel_coords, set_cursor_from_row):
4446 (get_next_display_element, set_iterator_to_next):
4447 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4448 (show_mouse_face): Remove decls
4449 * frame.h (message_buf_print): Likewise.
4450 * lisp.h (pop_message, set_message, check_point_in_composition):
4451 Likewise.
4452 * xterm.h (set_vertical_scroll_bar): Likewise.
4453 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4454 (message_buf_print, scratch_glyph_row, displayed_buffer):
4455 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4456 (get_next_display_element, show_mouse_face, window_box_edges):
4457 (frame_to_window_pixel_xy, check_point_in_composition):
4458 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4459 (glyph_to_pixel_coords): Remove; unused.
4460
4461 * dired.c (file_name_completion): Now static.
4462
4463 * dbusbind.c (xd_in_read_queued_messages): Now static.
4464
4465 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4466 * data.c (circular_list_error): Remove.
4467
4468 * commands.h (last_point_position, last_point_position_buffer):
4469 (last_point_position_window): Remove decls.
4470 * keyboard.c: Make these variables static.
4471
4472 * coding.h (coding, code_convert_region, encode_coding_gap):
4473 Remove decls.
4474 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4475 (iso_code_class, detect_coding, code_convert_region): Now static.
4476 (encode_coding_gap): Remove; unused.
4477
4478 * chartab.c (chartab_chars, chartab_bits): Now static.
4479
4480 * charset.h (charset_iso_8859_1): Remove decl.
4481 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4482 Now static.
4483
4484 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4485 * ccl.c (Vccl_program_table): Now static.
4486 (check_ccl_update): Remove; unused.
4487
4488 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4489 * category.h: ... from here.
4490 * category.c (check_category_table, set_category_set): Now static.
4491
4492 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4493 * lisp.h: Remove these decls.
4494
4495 * buffer.c (buffer_count): Remove unused var.
4496
4497 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4498 so that it's not optimized away.
4499 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4500 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4501 exported only to the debugger.
4502
4503 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4504 * atimer.h (run_all_atimers): Remove; not exported.
4505
4506 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4507 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4508 was inaccessible from Lisp.
4509 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4510 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4511
4512 alloc.c: Import and export fewer symbols, and remove unused items.
4513 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4514 is defined.
4515 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4516 it's not optimized away by whole-program optimization.
4517 (message_enable_multibyte, free_misc): Remove.
4518 (catchlist, handlerlist, mark_backtrace):
4519 Declare only if BYTE_MARK_STACK.
4520 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4521 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4522 (message_enable_multibyte): Remove decl.
4523 (free_misc, interval_free_list, float_block, float_block_index):
4524 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4525 (cons_free_list, last_marked_index):
4526 Now static.
4527 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4528 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4529 (mark_backtrace): Define only if BYTE_MARK_STACK.
4530 * xdisp.c (message_enable_multibyte): Now static.
4531
4532 Declare Lisp_Object Q* variables to be 'static' if not exported.
4533 This makes it easier for human readers (and static analyzers)
4534 to see whether these variables are used from other modules.
4535 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4536 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4537 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4538 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4539 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4540 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4541 * xmenu.c, xselect.c:
4542 Declare Q* vars static if they are not used in other modules.
4543 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4544 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4545 Remove decls of unexported vars.
4546 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4547
4548 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4549
4550 Make Emacs functions such as Fatom 'static' by default.
4551 This makes it easier for human readers (and static analyzers)
4552 to see whether these functions can be called from other modules.
4553 DEFUN now defines a static function. To make the function external
4554 so that it can be used in other C modules, use the new macro DEFUE.
4555 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4556 (Finit_image_library):
4557 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4558 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4559 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4560 Remove decls, since these functions are now static.
4561 (Funintern, Fget_internal_run_time): New decls, since these functions
4562 were already external.
4563
4564 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4565 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4566 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4567 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4568 * keyboard.c, keymap.c, lread.c:
4569 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4570 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4571 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4572 Mark functions with DEFUE instead of DEFUN,
4573 if they are used in other modules.
4574 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4575 decls for now-static functions.
4576 * buffer.h (Fdelete_overlay): Remove decl.
4577 * callproc.c (Fgetenv_internal): Mark as internal.
4578 * composite.c (Fremove_list_of_text_properties): Remove decl.
4579 (Fcomposition_get_gstring): New forward static decl.
4580 * composite.h (Fcomposite_get_gstring): Remove decl.
4581 * dired.c (Ffile_attributes): New forward static decl.
4582 * doc.c (Fdocumntation_property): New forward static decl.
4583 * eval.c (Ffetch_bytecode): New forward static decl.
4584 (Funintern): Remove extern decl; now in .h file where it belongs.
4585 * fileio.c (Fmake_symbolic_link): New forward static decl.
4586 * image.c (Finit_image_library): New forward static decl.
4587 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4588 * intervals.h (Fprevious_property_change):
4589 (Fremove_list_of_text_properties): Remove decls.
4590 * keyboard.c (Fthis_command_keys): Remove decl.
4591 (Fcommand_execute): New forward static decl.
4592 * keymap.c (Flookup_key): New forward static decl.
4593 (Fcopy_keymap): Now static.
4594 * keymap.h (Flookup_key): Remove decl.
4595 * process.c (Fget_process): New forward static decl.
4596 (Fprocess_datagram_address): Mark as internal.
4597 * syntax.c (Fsyntax_table_p): New forward static decl.
4598 (skip_chars): Remove duplicate decl.
4599 * textprop.c (Fprevious_property_change): New forward static decl.
4600 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4601 Now internal.
4602 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4603 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4604
4605 * editfns.c (Fformat): Remove unreachable code.
4606
4607 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4608
4609 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4610 change. (Bug#8496)
4611
4612 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4613
4614 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4615 when at ZV. (Bug#8487)
4616
4617 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4618
4619 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4620 (Bug#8437)
4621 * keyboard.c (parse_tool_bar_item): Likewise.
4622 * sound.c (sound_cleanup, alsa_close): Likewise.
4623 * termcap.c (tgetent): Likewise.
4624 * xfns.c (x_default_font_parameter): Likewise.
4625 * xsettings.c (read_and_apply_settings): Likewise.
4626
4627 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4628 (overrun_check_free): Protoize.
4629
4630 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4631
4632 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4633 since callers should never pass a negative size.
4634 Change the signature to match that of plain 'read' and 'write'; see
4635 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4636 * lisp.h: Update prototypes of emacs_write and emacs_read.
4637
4638 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4639
4640 * xdisp.c (redisplay_window): Don't try to determine the character
4641 position of the scroll margin if the window start point w->startp
4642 is outside the buffer's accessible region. (Bug#8468)
4643
4644 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4645
4646 Fix write-region and its subroutines for buffers > 2GB.
4647 * fileio.c (a_write, e_write): Modify declaration of arguments and
4648 local variables to support buffers larger than 2GB.
4649 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4650
4651 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4652 argument, local variables, and return value.
4653
4654 * lisp.h: Update prototypes of emacs_write and emacs_read.
4655
4656 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4657
4658 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4659
4660 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4661
4662 Fix more problems found by GCC 4.6.0's static checks.
4663
4664 * xdisp.c (vmessage): Use a better test for character truncation.
4665
4666 * charset.c (load_charset_map): <, not <=, for optimization,
4667 and to avoid potential problems with integer overflow.
4668 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4669 * casetab.c (set_identity, shuffle): Likewise.
4670 * editfns.c (Fformat): Likewise.
4671 * syntax.c (skip_chars): Likewise.
4672
4673 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4674 This also lets GCC 4.6.0 generate slightly better loop code.
4675
4676 * callint.c (Fcall_interactively): <, not <=, for optimization.
4677 (Fcall_interactively): Count the number of arguments produced,
4678 not the number of arguments given. This is simpler and lets GCC
4679 4.6.0 generate slightly better code.
4680
4681 * ftfont.c: Distingish more carefully between FcChar8 and char.
4682 The previous code passed unsigned char * to a functions like
4683 strlen and xstrcasecmp that expect char *, which does not
4684 conform to the C standard.
4685 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4686 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4687 char * when the C standard requires it.
4688
4689 * keyboard.c (read_char): Remove unused var.
4690
4691 * eval.c: Port to Windows vsnprintf (Bug#8435).
4692 Include <limits.h>.
4693 (SIZE_MAX): Define if the headers do not.
4694 (verror): Do not give up if vsnprintf returns a negative count.
4695 Instead, grow the buffer. This ports to Windows vsnprintf, which
4696 does not conform to C99. Problem reported by Eli Zaretskii.
4697 Also, simplify the allocation scheme, by avoiding the need for
4698 calling realloc, and removing the ALLOCATED variable.
4699
4700 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4701
4702 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4703 But keep the doprint source code for now, as we might revamp it
4704 and use it again (Bug#8435).
4705 * lisp.h (doprnt): Remove.
4706 * Makefile.in (base_obj): Remove doprnt.o.
4707 * deps.mk (doprnt.o): Remove.
4708
4709 error: Print 32- and 64-bit integers portably (Bug#8435).
4710 Without this change, on typical 64-bit hosts error ("...%d...", N)
4711 was used to print both 32- and 64-bit integers N, which relied on
4712 undefined behavior.
4713 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4714 New macro.
4715 * lisp.h (error, verror): Mark as printf-like functions.
4716 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4717 Report overflow in size calculations when allocating printf buffer.
4718 Do not truncate output string at its first null byte.
4719 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4720 Truncate the output at a character boundary, since vsnprintf does not
4721 do that.
4722 * charset.c (check_iso_charset_parameter): Convert internal
4723 character to string before calling 'error', since %c now has the
4724 printf meaning.
4725 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4726 overflow when computing char to be passed to 'error'. Do not
4727 pass Lisp_Object to 'error'; pass the integer instead.
4728 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4729 formatted with plain %d.
4730
4731 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4732
4733 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4734
4735 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4736
4737 * xterm.c (x_catch_errors): Remove duplicate declaration.
4738
4739 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4740
4741 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4742
4743 2011-04-10 Jim Meyering <meyering@redhat.com>
4744
4745 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4746 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4747 return ssize_t not "int", and use size_t as the buffer length.
4748 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4749 * gnutls.h: Update declarations.
4750 * process.c (read_process_output): Use ssize_t, to match.
4751 (send_process): Likewise.
4752
4753 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4754
4755 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4756
4757 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4758
4759 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4760 Use unsigned char, to match FcChar8 type definition.
4761
4762 * xterm.c (handle_one_xevent):
4763 * xmenu.c (create_and_show_popup_menu):
4764 * xselect.c (x_decline_selection_request)
4765 (x_reply_selection_request): Avoid type-punned deref of X events.
4766
4767 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4768
4769 Fix some uses of `int' instead of EMACS_INT.
4770 * search.c (string_match_1, fast_string_match)
4771 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4772 (scan_buffer, find_next_newline_no_quit)
4773 (find_before_next_newline, search_command, Freplace_match)
4774 (Fmatch_data): Make some `int' variables be EMACS_INT.
4775
4776 * xdisp.c (display_count_lines): 3rd argument and return value now
4777 EMACS_INT. All callers changed.
4778 (pint2hrstr): Last argument is now EMACS_INT.
4779
4780 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4781 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4782 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4783 (decode_coding_utf_16, decode_coding_emacs_mule)
4784 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4785 (decode_coding_ccl, decode_coding_charset)
4786 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4787 (decode_coding_iso_2022, decode_coding_emacs_mule)
4788 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4789 <char_offset, last_offset>: Declare EMACS_INT.
4790 (encode_coding_utf_8, encode_coding_utf_16)
4791 (encode_coding_emacs_mule, encode_invocation_designation)
4792 (encode_designation_at_bol, encode_coding_iso_2022)
4793 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4794 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4795 Declare EMACS_INT.
4796 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4797 (encode_invocation_designation): Last argument P_NCHARS is now
4798 EMACS_INT.
4799 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4800 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4801
4802 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4803 All users changed.
4804
4805 * ccl.c (Fccl_execute_on_string): Declare some variables
4806 EMACS_INT.
4807
4808 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4809
4810 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4811
4812 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4813
4814 * process.c (Fformat_network_address): Doc fix.
4815
4816 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4817
4818 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4819
4820 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4821
4822 * keyboard.c (read_char): Call Lisp function help-form-show,
4823 instead of using internal_with_output_to_temp_buffer.
4824 (Qhelp_form_show): New var.
4825 (syms_of_keyboard): Use DEFSYM macro.
4826
4827 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4828
4829 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4830
4831 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4832
4833 * process.c (Flist_processes): Remove to Lisp.
4834 (list_processes_1): Delete.
4835
4836 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4837
4838 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4839
4840 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4841
4842 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4843
4844 Fix more problems found by GCC 4.6.0's static checks.
4845
4846 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4847
4848 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4849
4850 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4851
4852 * xdisp.c (vmessage): Mark as a printf-like function.
4853
4854 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4855
4856 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4857
4858 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4859 printf-like functions.
4860 (tiff_load): Add casts to remove these marks before passing them
4861 to system-supplied API.
4862
4863 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4864
4865 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4866 This avoids several warnings with gcc -Wstrict-overflow.
4867 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4868 directly, rather than having caller test rule sign. This avoids
4869 some unnecessary tests.
4870 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4871 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4872 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4873
4874 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4875 (xfont_open): Avoid unnecessary tests.
4876
4877 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4878
4879 * composite.h, composite.c (composition_gstring_put_cache):
4880 Use EMACS_INT, not int, for length.
4881
4882 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4883 breaking out part of COMPOSITION_DECODE_RULE.
4884 (COMPOSITION_DECODE_RULE): Use it.
4885 * composite.c (get_composition_id): Remove unused local vars,
4886 by using the new macro.
4887
4888 * textprop.c (set_text_properties_1): Change while to do-while,
4889 since the condition is always true at first.
4890
4891 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4892 (interval_deletion_adjustment): Return unsigned value.
4893 All uses changed.
4894
4895 * process.c (list_processes_1, create_pty, read_process_output):
4896 (exec_sentinel): Remove vars that were set but not used.
4897 (create_pty): Remove unnecessary "volatile"s.
4898 (Fnetwork_interface_info): Avoid possibility of int overflow.
4899 (read_process_output): Do adaptive read buffering even if carryover.
4900 (read_process_output): Simplify nbytes computation if buffered.
4901
4902 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4903
4904 * syntax.c (scan_words): Remove var that was set but not used.
4905 (update_syntax_table): Use unsigned instead of int.
4906
4907 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4908 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4909 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4910
4911 * print.c (print_error_message): Avoid int overflow.
4912
4913 * font.c (font_list_entities): Redo for clarity,
4914 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4915
4916 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4917 (font_score): Avoid potential overflow in diff calculation.
4918
4919 * fns.c (substring_both): Remove var that is set but not used.
4920 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4921
4922 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4923
4924 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4925 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4926 can always succeed if overflow has undefined behavior.
4927
4928 * search.c (boyer_moore, wordify): Remove vars set but not used.
4929 (wordify): Omit three unnecessary tests.
4930
4931 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4932 All callers changed. This avoids the need for an unused var.
4933
4934 * casefiddle.c (casify_region): Remove var that is set but not used.
4935
4936 * dired.c (file_name_completion): Remove var that is set but not used.
4937
4938 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4939
4940 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4941 (Finsert_file_contents): Remove unnecessary code checking fd.
4942
4943 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4944 Check for integer overflow on size calculations.
4945
4946 * buffer.c (Fprevious_overlay_change): Remove var that is set
4947 but not used.
4948
4949 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4950 Remove vars that are set but not used.
4951 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4952 (timer_check_2): Mark vars as initialized.
4953
4954 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4955
4956 * image.c (lookup_image): Remove var that is set but not used.
4957 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4958
4959 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4960 that are set but not used.
4961
4962 * xfns.c (make_invisible_cursor): Don't return garbage
4963 if XCreateBitmapFromData fails (Bug#8410).
4964
4965 * xselect.c (x_get_local_selection, x_handle_property_notify):
4966 Remove vars that are set but not used.
4967
4968 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4969 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4970
4971 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4972 Remove var that is set but not used.
4973 (scroll_bar_windows_size): Now size_t, not int.
4974 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4975 Check for overflow.
4976
4977 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4978 (map_tty_color) [!defined MSDOS]: Likewise.
4979
4980 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4981
4982 * coding.c: Remove vars that are set but not used.
4983 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4984 All callers changed.
4985 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4986 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4987 (decode_coding_charset): Remove vars that are set but not used.
4988
4989 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4990 that is set but not used.
4991
4992 * print.c (print_object): Remove var that is set but not used.
4993
4994 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4995 The gnulib version avoids calling malloc in the usual case,
4996 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4997 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4998 * filelock.c (current_lock_owner): Likewise.
4999 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5000 * sysdep.c: Include allocator.h, careadlinkat.h.
5001 (emacs_no_realloc_allocator): New static constant.
5002 (emacs_readlink): New function.
5003 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5004 ../lib/careadlinkat.h.
5005
5006 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5007
5008 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5009 first non-nil return value).
5010
5011 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5012
5013 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5014 if not defined (Bug#8403).
5015
5016 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5017
5018 * xdisp.c (display_count_lines): Remove parameter `start',
5019 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5020 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5021 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5022 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5023 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5024 and thereabouts. All callers changed.
5025 (get_per_char_metric): Remove parameter `f', unused since
5026 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5027
5028 2011-04-02 Jim Meyering <meyering@redhat.com>
5029
5030 do not dereference NULL upon failed strdup
5031 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5032 (ns_get_family): Likewise.
5033
5034 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5035
5036 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5037
5038 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5039
5040 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5041 later (Bug#8403).
5042
5043 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5044
5045 Add lexical binding.
5046
5047 * window.c (Ftemp_output_buffer_show): New fun.
5048 (Fsave_window_excursion):
5049 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5050
5051 * lread.c (lisp_file_lexically_bound_p): New function.
5052 (Fload): Bind Qlexical_binding.
5053 (readevalloop): Remove `evalfun' arg.
5054 Bind Qinternal_interpreter_environment.
5055 (Feval_buffer): Bind Qlexical_binding.
5056 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5057 Mark as dynamic.
5058 (syms_of_lread): Declare `lexical-binding'.
5059
5060 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5061
5062 * keyboard.c (eval_dyn): New fun.
5063 (menu_item_eval_property): Use it.
5064
5065 * image.c (parse_image_spec): Use Ffunctionp.
5066
5067 * fns.c (concat, mapcar1): Accept byte-code-functions.
5068
5069 * eval.c (Fsetq): Handle lexical vars.
5070 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5071 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5072 (FletX, Flet): Obey lexical binding.
5073 (Fcommandp): Handle closures.
5074 (Feval): New `lexical' arg.
5075 (eval_sub): New function extracted from Feval. Use it almost
5076 everywhere where Feval was used. Look up vars in lexical env.
5077 Handle closures.
5078 (Ffunctionp): Move from subr.el.
5079 (Ffuncall): Handle closures.
5080 (apply_lambda): Remove `eval_flags'.
5081 (funcall_lambda): Handle closures and new byte-code-functions.
5082 (Fspecial_variable_p): New function.
5083 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5084 but without exporting it to Lisp.
5085
5086 * doc.c (Fdocumentation, store_function_docstring):
5087 * data.c (Finteractive_form): Handle closures.
5088
5089 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5090 interactive spec.
5091
5092 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5093 New byte-codes.
5094 (exec_byte_code): New function extracted from Fbyte_code to handle new
5095 calling convention for byte-code-functions. Add new byte-codes.
5096
5097 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5098
5099 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5100
5101 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5102
5103 * xdisp.c (redisplay_internal): Fix prototype.
5104
5105 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5106
5107 * xdisp.c (SCROLL_LIMIT): New macro.
5108 (try_scrolling): Use it when setting scroll_limit.
5109 Limit scrolling to 100 screen lines.
5110 (redisplay_window): Even when falling back on "recentering",
5111 position point in the window according to scroll-conservatively,
5112 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5113
5114 (try_scrolling): When point is above the window, allow searching
5115 as far as scroll_max, or one screenful, to compute vertical
5116 distance from PT to the scroll margin position. This prevents
5117 try_scrolling from unnecessarily failing when
5118 scroll-conservatively is set to a value slightly larger than the
5119 window height. Clean up the case of PT below the margin at bottom
5120 of window: scroll_max can no longer be INT_MAX. When aggressive
5121 scrolling is in use, don't let point enter the opposite scroll
5122 margin as result of the scroll.
5123 (syms_of_xdisp) <scroll-conservatively>: Document the
5124 threshold of 100 lines for never-recentering scrolling.
5125
5126 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5127
5128 * dispextern.h (move_it_by_lines):
5129 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5130 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5131 (message_log_check_duplicate): Remove parameters `prev_bol' and
5132 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5133 (redisplay_internal): Remove parameter `preserve_echo_area',
5134 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5135
5136 * indent.c (Fvertical_motion):
5137 * window.c (window_scroll_pixel_based, Frecenter):
5138 Don't pass `need_y_p' to `move_it_by_lines'.
5139
5140 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5141
5142 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5143 steal a few bits to be more compact.
5144 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5145 Remove unneeded casts.
5146
5147 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5148
5149 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5150
5151 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5152 binding" message (bug#7967).
5153
5154 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5155
5156 Fix more problems found by GCC 4.6.0's static checks.
5157
5158 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5159 Remove unused local var.
5160
5161 * editfns.c (Fmessage_box): Remove unused local var.
5162
5163 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5164 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5165 Omit unused local vars.
5166 * window.c (shrink_windows): Omit unused local var.
5167 * menu.c (digest_single_submenu): Omit unused local var.
5168 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5169 Omit unused local var.
5170
5171 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5172 Don't assume string length fits in int.
5173 (keyremap_step, read_key_sequence): Use size_t for sizes.
5174 (read_key_sequence): Don't check last_real_key_start redundantly.
5175
5176 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5177 instead of alloca (Bug#8344).
5178
5179 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5180 (Fbacktrace_frame): Don't assume nframes fits in int.
5181
5182 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5183
5184 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5185 concerns.
5186
5187 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5188
5189 * cm.c (calccost): Turn while-do into do-while, for clarity.
5190
5191 * keyboard.c (syms_of_keyboard): Use the same style as later
5192 in this function when indexing through an array. This also
5193 works around GCC bug 48267.
5194
5195 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5196
5197 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5198
5199 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5200 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5201
5202 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5203 This avoids undefined behavior on integer overflow, and is a bit
5204 more convenient anyway since it is compared to a size_t variable.
5205
5206 Variadic C functions now count arguments with size_t, not int.
5207 This avoids an unnecessary limitation on 64-bit machines, which
5208 caused (substring ...) to crash on large vectors (Bug#8344).
5209 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5210 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5211 All variadic functions and their callers changed accordingly.
5212 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5213 * data.c (arith_driver, float_arith_driver): Likewise.
5214 * editfns.c (general_insert_function): Likewise.
5215 * eval.c (struct backtrace.nargs, interactive_p)
5216 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5217 (funcall_lambda, mark_backtrace): Likewise.
5218 * fns.c (concat): Likewise.
5219 * frame.c (x_set_frame_parameters): Likewise.
5220 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5221 0 if not found, not -1. All callers changed.
5222
5223 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5224 (stack_copy_size): Now size_t, not int.
5225 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5226
5227 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5228
5229 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5230 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5231 All callers changed.
5232
5233 * lisp.h (multibyte_char_to_unibyte):
5234 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5235 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5236 * character.h (CHAR_TO_BYTE8):
5237 * cmds.c (internal_self_insert):
5238 * editfns.c (general_insert_function):
5239 * keymap.c (push_key_description):
5240 * search.c (Freplace_match):
5241 * xdisp.c (message_dolog, set_message_1): All callers changed.
5242
5243 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5244
5245 * keyboard.c (safe_run_hook_funcall): New function.
5246 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5247 don't set the hook to nil, but remove the offending function instead.
5248 (Qcommand_hook_internal): Remove, unused.
5249 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5250 Vcommand_hook_internal.
5251
5252 * eval.c (enum run_hooks_condition): Remove.
5253 (funcall_nil, funcall_not): New functions.
5254 (run_hook_with_args): Call each function through a `funcall' argument.
5255 Remove `cond' argument, now redundant.
5256 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5257 (Frun_hook_with_args_until_failure): Adjust accordingly.
5258 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5259
5260 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5261
5262 * dispextern.h (string_buffer_position): Remove declaration.
5263
5264 * print.c (strout): Remove parameter `multibyte', unused since
5265 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5266
5267 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5268 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5269 All callers changed.
5270
5271 * w32.c (_wsa_errlist): Use braces for struct initializers.
5272
5273 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5274 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5275 All callers changed.
5276 (string_buffer_position): Likewise. Also, make static (it's never
5277 used outside xdisp.c).
5278 (cursor_row_p): Remove parameter `w', unused since
5279 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5280 (decode_mode_spec): Remove parameter `precision', introduced during
5281 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5282 All callers changed.
5283
5284 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5285
5286 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5287
5288 2011-03-27 Anders Lindgren <andlind@gmail.com>
5289
5290 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5291 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5292 (ns_update_auto_hide_menu_bar): New functions.
5293 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5294 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5295 ns_constrain_all_frames.
5296 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5297 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5298
5299 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5300
5301 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5302
5303 2011-03-27 Glenn Morris <rgm@gnu.org>
5304
5305 * syssignal.h: Replace RETSIGTYPE with void.
5306 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5307 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5308 Replace SIGTYPE with void everywhere.
5309 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5310 * s/template.h (SIGTYPE): Remove commented out definition.
5311
5312 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5313
5314 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5315 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5316
5317 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5318
5319 * w32.c (read_unc_volume): Use parameter `henum', instead of
5320 global variable `wget_enum_handle'.
5321
5322 * keymap.c (describe_vector): Remove parameters `indices' and
5323 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5324 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5325
5326 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5327
5328 * keyboard.c (timer_check): Remove parameter `do_it_now',
5329 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5330 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5331 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5332
5333 * keyboard.c (read_char):
5334 * w32menu.c (w32_menu_display_help):
5335 * xmenu.c (show_help_event, menu_help_callback):
5336 Adjust calls to `show_help_echo'.
5337
5338 * gtkutil.c (xg_maybe_add_timer):
5339 * keyboard.c (readable_events):
5340 * process.c (wait_reading_process_output):
5341 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5342
5343 * insdel.c (adjust_markers_gap_motion):
5344 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5345 (gap_left, gap_right): Don't call it.
5346
5347 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5348
5349 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5350 incurred during fontification.
5351
5352 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5353
5354 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5355 (DEFVAR_PER_BUFFER): Don't pass it.
5356
5357 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5358 (scrolling_window): Don't pass it.
5359
5360 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5361
5362 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5363
5364 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5365 and `suffix'.
5366 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5367 of variables specific to SELinux and computation of `encoded_absname'.
5368
5369 * image.c (XPutPixel): Remove unused variable `height'.
5370
5371 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5372
5373 * unexw32.c (get_section_info): Remove unused variable `section'.
5374
5375 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5376 (system_process_attributes): Remove unused variable `sess'.
5377 (sys_read): Remove unused variable `err'.
5378
5379 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5380 (w32_wnd_proc): Remove unused variable `isdead'.
5381 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5382 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5383 (x_create_tip_frame): Remove unused variable `tem'.
5384
5385 * w32inevt.c (w32_console_read_socket):
5386 Remove unused variable `no_events'.
5387
5388 * w32term.c (x_draw_composite_glyph_string_foreground):
5389 Remove unused variable `width'.
5390
5391 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5392
5393 * w32term.c (x_set_glyph_string_clipping):
5394 Don't pass uninitialized region to CombineRgn.
5395
5396 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5397
5398 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5399 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5400 (Fx_close_connection): Remove unused variable `i'.
5401
5402 * w32font.c (w32font_draw): Return number of glyphs.
5403 (w32font_open_internal): Remove unused variable `i'.
5404 (w32font_driver): Add missing initializer.
5405
5406 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5407 (fill_in_menu): Remove unused variable `items_added'.
5408
5409 * w32term.c (last_mouse_press_frame): Remove static global variable.
5410 (w32_clip_to_row): Remove unused variable `f'.
5411 (x_delete_terminal): Remove unused variable `i'.
5412
5413 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5414 (NOTHING): Remove unused static global variable.
5415 (uniscribe_check_otf): Remove unused variable `table'.
5416 (uniscribe_font_driver): Add missing initializers.
5417
5418 2011-03-23 Julien Danjou <julien@danjou.info>
5419
5420 * term.c (Fsuspend_tty, Fresume_tty):
5421 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5422 * window.c (temp_output_buffer_show):
5423 * insdel.c (signal_before_change):
5424 * frame.c (Fhandle_switch_frame):
5425 * fileio.c (Fdo_auto_save):
5426 * emacs.c (Fkill_emacs):
5427 * editfns.c (save_excursion_restore):
5428 * cmds.c (internal_self_insert):
5429 * callint.c (Fcall_interactively):
5430 * buffer.c (Fkill_all_local_variables):
5431 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5432 Use Frun_hooks.
5433 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5434 unconditionnaly since it does the check itself.
5435
5436 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5437
5438 Fix more problems found by GCC 4.5.2's static checks.
5439
5440 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5441 the first time through the loop, since we know p0 < p1 then.
5442 This also avoids a gcc -Wstrict-overflow warning.
5443
5444 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5445 leading to a memory leak, possible in functions like
5446 load_charset_map_from_file that can allocate an unbounded number
5447 of objects (Bug#8318).
5448
5449 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5450 that could (at least in theory) be that large.
5451
5452 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5453 This is less likely to overflow, and avoids undefined behavior if
5454 overflow does occur. All callers changed. Use strtoul to scan
5455 for the unsigned long integer.
5456 (pint2hrstr): Simplify and tune code slightly.
5457 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5458
5459 * scroll.c (do_scrolling): Work around GCC bug 48228.
5460 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5461
5462 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5463 This also avoids a warning with gcc -Wstrict-overflow.
5464 (validate_x_resource_name): Simplify count usage.
5465 This also avoids a warning with gcc -Wstrict-overflow.
5466
5467 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5468 fail (Bug#8306).
5469
5470 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5471
5472 * process.c (Fmake_network_process): Use socklen_t, not int,
5473 where POSIX says socklen_t is required in portable programs.
5474 This fixes a porting bug on hosts like 64-bit HP-UX, where
5475 socklen_t is wider than int (Bug#8277).
5476 (Fmake_network_process, server_accept_connection):
5477 (wait_reading_process_output, read_process_output):
5478 Likewise.
5479
5480 * process.c: Rename or move locals to avoid shadowing.
5481 (list_processes_1, Fmake_network_process):
5482 (read_process_output_error_handler, exec_sentinel_error_handler):
5483 Rename or move locals.
5484 (Fmake_network_process): Define label "retry_connect" only if needed.
5485 (Fnetwork_interface_info): Fix pointer signedness.
5486 (process_send_signal): Add cast to avoid pointer signedness problem.
5487 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5488 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5489
5490 Make tparam.h and terminfo.c consistent.
5491 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5492 Include tparam.h instead, since it declares them.
5493 * cm.h (PC): Remove extern decl; tparam.h now does this.
5494 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5495 * terminfo.c: Include tparam.h, to check interfaces.
5496 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5497 (tparam): Adjust signature to match interface in tparam.h;
5498 this removes some undefined behavior. Check that outstring and len
5499 are zero, which they always are with Emacs.
5500 * tparam.h (PC, BC, UP): New extern decls.
5501
5502 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5503 (xftfont_open): Rename locals to avoid shadowing.
5504
5505 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5506 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5507 (OTF_TAG_SYM): Omit macro if not needed.
5508 (ftfont_list): Remove unused local.
5509 (get_adstyle_property, ftfont_pattern_entity):
5510 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5511 Rename locals to avoid shadowing.
5512
5513 * xfont.c (xfont_list_family): Mark var as initialized.
5514
5515 * xml.c (make_dom): Now static.
5516
5517 * composite.c (composition_compute_stop_pos): Rename local to
5518 avoid shadowing.
5519 (composition_reseat_it): Remove unused locals.
5520 (find_automatic_composition, composition_adjust_point): Likewise.
5521 (composition_update_it): Mark var as initialized.
5522 (find_automatic_composition): Mark vars as initialized,
5523 with a FIXME (Bug#8290).
5524
5525 character.h: Rename locals to avoid shadowing.
5526 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5527 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5528 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5529 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5530 to avoid shadowing.
5531
5532 * textprop.c (property_change_between_p): Remove; unused.
5533
5534 * intervals.c (interval_start_pos): Now static.
5535
5536 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5537
5538 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5539 Rename locals to avoid shadowing.
5540
5541 * sound.c (wav_play, au_play, Fplay_sound_internal):
5542 Fix pointer signedness.
5543 (alsa_choose_format): Remove unused local var.
5544 (wav_play): Initialize a variable to 0, to prevent undefined
5545 behavior (Bug#8278).
5546
5547 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5548
5549 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5550
5551 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5552 clobbering (Bug#8298).
5553 * sysdep.c (sys_subshell): Likewise.
5554 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5555
5556 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5557 This should get cleaned up, so that child_setup has the
5558 same signature on all platforms.
5559
5560 * callproc.c (call_process_cleanup): Now static.
5561 (relocate_fd): Rename locals to avoid shadowing.
5562
5563 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5564
5565 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5566 not to be necessary, and produces flickering.
5567
5568 2011-03-20 Glenn Morris <rgm@gnu.org>
5569
5570 * config.in: Remove file.
5571
5572 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5573
5574 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5575 are now in src/globals.h.
5576 (syms_of_minibuf): Remove spurious & from previous change.
5577
5578 2011-03-20 Leo <sdl.web@gmail.com>
5579
5580 * minibuf.c (completing-read-function): New variable.
5581 (completing-read-default): Rename from completing-read.
5582 (completing-read): Call completing-read-function.
5583
5584 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5585
5586 * xfaces.c (Fx_load_color_file):
5587 Read color file from absolute filename (bug#8250).
5588
5589 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5590
5591 * makefile.w32-in: Update dependencies.
5592
5593 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5594
5595 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5596
5597 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5598
5599 Fix more problems found by GCC 4.5.2's static checks.
5600
5601 * process.c (make_serial_process_unwind, send_process_trap):
5602 (sigchld_handler): Now static.
5603
5604 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5605 That way, the code declares only the vars that it needs.
5606 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5607 * s/cygwin.h (PTY_ITERATION): Likewise.
5608 * s/darwin.h (PTY_ITERATION): Likewise.
5609 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5610
5611 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5612 * process.c (allocate_pty): Don't declare stb unless it's needed.
5613
5614 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5615 (CONSTANTLIM): Remove; unused.
5616 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5617 Define only if needed.
5618
5619 * unexelf.c (unexec): Name an expression,
5620 to avoid gcc -Wbad-function-cast warning.
5621 Use a different way to cause a compilation error if anyone uses
5622 n rather than nn, a way that does not involve shadowing.
5623 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5624
5625 * deps.mk (unexalpha.o): Remove; unused.
5626
5627 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5628 * unexec.h: New file.
5629 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5630 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5631 Depend on unexec.h.
5632 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5633 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5634 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5635 Change as necessary to match prototype in unexec.h.
5636
5637 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5638 shadowing.
5639 (back_comment, skip_chars): Mark vars as initialized.
5640
5641 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5642 Rename locals to avoid shadowing.
5643
5644 * lread.c (read1): Rewrite so as not to use empty "else".
5645 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5646
5647 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5648
5649 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5650 warning when compiling print.c.
5651
5652 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5653 instead of using an uninitialized var.
5654 (font_sort_entities): Mark var as initialized.
5655
5656 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5657
5658 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5659 pointers to constants.
5660 (font_parse_fcname): Remove unused vars.
5661 (font_delete_unmatched): Now static.
5662 (font_get_spec): Remove; unused.
5663 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5664 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5665 Rename or move locals to avoid shadowing.
5666
5667 * fns.c (require_nesting_list, require_unwind): Now static.
5668 (Ffillarray): Rename locals to avoid shadowing.
5669
5670 * floatfns.c (domain_error2): Define only if needed.
5671 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5672
5673 * alloc.c (mark_backtrace): Move decl from here ...
5674 * lisp.h: ... to here, so that it can be checked.
5675
5676 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5677 (Fdefvar): Rewrite so as not to use empty "else".
5678 (lisp_indirect_variable): Name an expression,
5679 to avoid gcc -Wbad-function-cast warning.
5680 (Fdefvar): Rename locals to avoid shadowing.
5681
5682 * callint.c (quotify_arg, quotify_args): Now static.
5683 (Fcall_interactively): Rename locals to avoid shadowing.
5684 Use const pointer when appropriate.
5685
5686 * lisp.h (get_system_name, get_operating_system_release):
5687 Move decls here, to check interfaces.
5688 * process.c (get_operating_system_release): Move decl to lisp.h.
5689 * xrdb.c (get_system_name): Likewise.
5690 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5691 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5692 some of which prompt warnings from gcc -Wbad-function-cast.
5693 (Fformat_time_string, Fencode_time, Finsert_char):
5694 (Ftranslate_region_internal, Fformat):
5695 Rename or remove local vars to avoid shadowing.
5696 (Ftranslate_region_internal): Mark var as initialized.
5697
5698 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5699 avoid shadowing.
5700
5701 * lisp.h (eassert): Check that the argument compiles, even if
5702 ENABLE_CHECKING is not defined.
5703
5704 * data.c (Findirect_variable): Name an expression, to avoid
5705 gcc -Wbad-function-cast warning.
5706 (default_value, arithcompare, arith_driver, arith_error): Now static.
5707 (store_symval_forwarding): Rename local to avoid shadowing.
5708 (Fmake_variable_buffer_local, Fmake_local_variable):
5709 Mark variables as initialized.
5710 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5711
5712 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5713 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5714 Rename locals to avoid shadowing.
5715 (mark_stack): Move local variables into the #ifdef region where
5716 they're used.
5717 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5718 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5719 needed otherwise.
5720 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5721 (GC_STRING_CHARS): Remove; not used.
5722 (Fmemory_limit): Cast sbrk's returned value to char *.
5723
5724 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5725 avoids undefined behavior in theory.
5726
5727 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5728
5729 Use functions, not macros, for up- and down-casing (Bug#8254).
5730 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5731 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5732 to use the following functions instead of these macros.
5733 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5734 EMACS_INT, since callers assume the returned value fits in int.
5735 (upcase1): Likewise, for UPCASE_TABLE.
5736 (uppercasep, lowercasep, upcase): New static inline functions.
5737 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5738 the race-condition problem in the old DOWNCASE.
5739
5740 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5741 Rename locals to avoid shadowing.
5742 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5743 (regex_compile, re_search_2, re_match_2_internal):
5744 Remove unused local vars.
5745 (FREE_VAR): Rewrite so as not to use empty "else",
5746 which gcc can warn about.
5747 (regex_compile, re_match_2_internal): Mark locals as initialized.
5748 (RETALLOC_IF): Define only if needed.
5749 (WORDCHAR_P): Likewise. This one is never needed, but is used
5750 only in a comment talking about a compiler bug, so put inside
5751 the #if 0 of that comment.
5752 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5753 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5754 Remove; unused.
5755
5756 * search.c (boyer_moore): Rename locals to avoid shadowing.
5757 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5758 (PREV_CHAR_BOUNDARY): Likewise.
5759
5760 * search.c (simple_search): Remove unused var.
5761
5762 * dired.c (compile_pattern): Move decl from here ...
5763 * lisp.h: ... to here, so that it can be checked.
5764 (struct re_registers): New forward decl.
5765
5766 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5767
5768 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5769 All uses changed.
5770 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5771 Rename locals to avoid shadowing.
5772 (Fvertical_motion): Mark locals as initialized.
5773
5774 * casefiddle.c (casify_object, casify_region): Now static.
5775 (casify_region): Mark local as initialized.
5776
5777 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5778
5779 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5780 New macros, so that the caller can use some names other than
5781 gcpro1, gcpro2, etc.
5782 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5783 of the new macros.
5784 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5785 argument, for consistency with GCPRO2_VAR, etc: it is now the
5786 prefix of the variable, not the variable itself. All uses
5787 changed.
5788 * dired.c (directory_files_internal, file_name_completion):
5789 Rename locals to avoid shadowing.
5790
5791 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5792 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5793 dired.c's scmp function, had undefined behavior.
5794 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5795 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5796 * buffer.h: ... to here, because these macros use current_buffer,
5797 and the new implementation with inline functions needs to have
5798 current_buffer in scope now, rather than later when the macros
5799 are used.
5800 (downcase, upcase1): New static inline functions.
5801 (DOWNCASE, UPCASE1): Reimplement using these functions.
5802 This avoids undefined behavior in expressions like
5803 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5804 from race conditions in accessing the global variables
5805 case_temp1 and case_temp2.
5806 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5807 * lisp.h (case_temp1, case_temp2): Remove their decls.
5808 * character.h (ASCII_CHAR_P): Move from here ...
5809 * lisp.h: ... to here, so that the inline functions mentioned
5810 above can use them.
5811
5812 * dired.c (directory_files_internal_unwind): Now static.
5813
5814 * fileio.c (file_name_as_directory, directory_file_name):
5815 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5816 Now static.
5817 (file_name_as_directory): Use const pointers when appropriate.
5818 (Fexpand_file_name): Likewise. In particular, newdir might
5819 point at constant storage, so make it a const pointer.
5820 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5821 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5822 signedness issues.
5823 (Fset_file_times, Finsert_file_contents, auto_save_error):
5824 Rename locals to avoid shadowing.
5825
5826 * minibuf.c (choose_minibuf_frame_1): Now static.
5827 (Ftry_completion, Fall_completions): Rename or remove locals
5828 to avoid shadowing.
5829
5830 * marker.c (bytepos_to_charpos): Remove; unused.
5831
5832 * lisp.h (verify_bytepos, count_markers): New decls,
5833 so that gcc does not warn that these functions aren't declared.
5834
5835 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5836 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5837 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5838 (copy_text): Remove unused local var.
5839
5840 * filelock.c (within_one_second): Now static.
5841 (lock_file_1): Rename local to avoid shadowing.
5842
5843 * buffer.c (fix_overlays_before): Mark locals as initialized.
5844 (fix_start_end_in_overlays): Likewise. This function should be
5845 simplified by using pointers-to-pointers, but that's a different
5846 matter.
5847 (switch_to_buffer_1): Now static.
5848 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5849 (report_overlay_modification): Rename locals to avoid shadowing.
5850
5851 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5852 Fix pointer signedness issue.
5853 (sys_subshell): Mark local as volatile if checking for lint,
5854 to suppress a gcc -Wclobbered warning that does not seem to be right.
5855 (MAXPATHLEN): Define only if needed.
5856
5857 * process.c (serial_open, serial_configure): Move decls from here ...
5858 * systty.h: ... to here, so that they can be checked.
5859
5860 * fns.c (get_random, seed_random): Move extern decls from here ...
5861 * lisp.h: ... to here, so that they can be checked.
5862
5863 * sysdep.c (reset_io): Now static.
5864 (wait_for_termination_signal): Remove; unused.
5865
5866 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5867 (copy_keymap_item, append_key, push_text_char_description):
5868 Now static.
5869 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5870 (DENSE_TABLE_SIZE): Remove; unused.
5871 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5872 (describe_map_tree):
5873 Rename locals to avoid shadowing.
5874
5875 * keyboard.c: Declare functions static if they are not used elsewhere.
5876 (echo_char, echo_dash, cmd_error, top_level_2):
5877 (poll_for_input, handle_async_input): Now static.
5878 (read_char, kbd_buffer_get_event, make_lispy_position):
5879 (make_lispy_event, make_lispy_movement, apply_modifiers):
5880 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5881 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5882 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5883 (read_key_sequence, read_char): Mark locals as initialized.
5884 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5885
5886 * keyboard.h (make_ctrl_char): New decl.
5887 (mark_kboards): Move decl here ...
5888 * alloc.c (mark_kboards): ... from here.
5889
5890 * lisp.h (force_auto_save_soon): New decl.
5891
5892 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5893 (DEFINE_DUMMY_FUNCTION): New macro.
5894 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5895 Use it.
5896 (main): Add casts to avoid warnings
5897 if GCC considers string literals to be constants.
5898
5899 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5900
5901 * dbusbind.c: Pointer signedness fixes.
5902 (xd_signature, xd_append_arg, xd_initialize):
5903 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5904 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5905 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5906 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5907
5908 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5909 if GCC considers string literals to be constants.
5910 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5911
5912 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5913
5914 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5915 (print_preprocess, print_object): New macro to fix last change.
5916
5917 * print.c (print_preprocess): Don't forget font objects.
5918
5919 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5920
5921 * emacs.c (USAGE3): Doc fixes.
5922
5923 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5924
5925 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5926 structure.
5927
5928 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5929
5930 * lisp.h (VWindow_system, Qfile_name_history):
5931 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5932 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5933 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5934
5935 * w32select.c: Don't #include "keyboard.h".
5936 (run_protected): Add extern declaration for waiting_for_input.
5937
5938 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5939 * w32console.c (detect_input_pending, read_input_pending)
5940 (encode_terminal_code):
5941 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5942 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5943 (w32_system_caret_y, Qfile_name_history):
5944 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5945 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5946 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5947 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5948 * w32proc.c (Qlocal, report_file_error):
5949 * w32term.c (Vwindow_system, updating_frame):
5950 * w32uniscribe.c (initialized, uniscribe_font_driver):
5951 Remove unneeded extern declarations.
5952
5953 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5954
5955 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5956
5957 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
5958
5959 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5960 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5961 These macros can no longer be used for assignment.
5962
5963 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5964 Assign struct members directly, instead of using BUF_BEGV etc.
5965 (record_buffer_markers, fetch_buffer_markers): New functions for
5966 recording and fetching special buffer markers.
5967 (set_buffer_internal_1, set_buffer_temp): Use them.
5968
5969 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5970
5971 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5972
5973 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5974 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5975
5976 * xdisp.c (hscroll_window_tree):
5977 (reconsider_clip_changes): Use PT instead of BUF_PT.
5978
5979 2011-03-13 Eli Zaretskii <eliz@gnu.org>
5980
5981 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5982 $(EMACS_ROOT)/lib/intprops.h.
5983
5984 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5985
5986 Fix more problems found by GCC 4.5.2's static checks.
5987
5988 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5989 to unsigned char * to avoid compiler diagnostic.
5990 (xg_free_frame_widgets): Make it clear that a local variable is
5991 needed only if USE_GTK_TOOLTIP.
5992 (gdk_window_get_screen): Make it clear that this macro is needed
5993 only if USE_GTK_TOOLTIP.
5994 (int_gtk_range_get_value): New function, which avoids a diagnostic
5995 from gcc -Wbad-function-cast.
5996 (xg_set_toolkit_scroll_bar_thumb): Use it.
5997 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5998 diagnostic from gcc -Wbad-function-cast.
5999 (get_utf8_string, xg_get_file_with_chooser):
6000 Rename locals to avoid shadowing.
6001 (create_dialog): Move locals to avoid shadowing.
6002
6003 * xgselect.c (xg_select): Remove unused var.
6004
6005 * image.c (four_corners_best): Mark locals as initialized.
6006 (gif_load): Initialize transparent_p to zero (Bug#8238).
6007 Mark another local as initialized.
6008 (my_png_error, my_error_exit): Mark with NO_RETURN.
6009
6010 * image.c (clear_image_cache): Now static.
6011 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6012 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6013 (x_edge_detection): Remove unnecessary cast that
6014 gcc -Wbad-function-cast diagnoses.
6015 (gif_load): Fix pointer signedness.
6016 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6017 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6018
6019 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6020
6021 Improve quality of tests for time stamp overflow.
6022 For example, without this patch (encode-time 0 0 0 1 1
6023 1152921504606846976) returns the obviously-bogus value (-948597
6024 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6025 reports time overflow. See
6026 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6027 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6028 * editfns.c: Include limits.h and intprops.h.
6029 (TIME_T_MIN, TIME_T_MAX): New macros.
6030 (time_overflow): Move earlier, to before first use.
6031 (hi_time, lo_time): New functions, for an accurate test for
6032 out-of-range times.
6033 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6034 (Fget_internal_run_time): Don't assume time_t fits in int.
6035 (make_time): Use list2 instead of Fcons twice.
6036 (Fdecode_time): More accurate test for out-of-range times.
6037 (check_tm_member): New function.
6038 (Fencode_time): Use it, to test for out-of-range times.
6039 (lisp_time_argument): Don't rely on undefined left-shift and
6040 right-shift behavior when checking for time stamp overflow.
6041
6042 * editfns.c (time_overflow): New function, refactoring common code.
6043 (Fformat_time_string, Fdecode_time, Fencode_time):
6044 (Fcurrent_time_string): Use it.
6045
6046 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6047 * dired.c (make_time): Move to ...
6048 * editfns.c (make_time): ... here.
6049 * systime.h: Note the move.
6050
6051 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6052
6053 * fringe.c (update_window_fringes): Remove unused variables.
6054
6055 * unexmacosx.c (copy_data_segment): Also copy __got section.
6056 (Bug#8223)
6057
6058 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6059
6060 * termcap.c [MSDOS]: Include "msdos.h".
6061 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6062 Constify `char *' arguments and their references according to
6063 prototypes in tparam.h.
6064
6065 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6066
6067 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6068 Adapt all references accordingly.
6069
6070 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6071
6072 2011-03-11 Tom Tromey <tromey@redhat.com>
6073
6074 * buffer.c (syms_of_buffer): Remove obsolete comment.
6075
6076 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6077
6078 * termhooks.h (encode_terminal_code): Declare prototype.
6079
6080 * msdos.c (encode_terminal_code): Don't declare prototype.
6081
6082 * term.c (encode_terminal_code): Now external again, used by
6083 w32console.c and msdos.c.
6084
6085 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6086 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6087
6088 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6089
6090 Fix some minor problems found by GCC 4.5.2's static checks.
6091
6092 * fringe.c (update_window_fringes): Mark locals as initialized
6093 (Bug#8227).
6094 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6095
6096 * alloc.c (mark_fringe_data): Move decl from here ...
6097 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6098 to check its interface.
6099 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6100
6101 * fontset.c (free_realized_fontset): Now static.
6102 (Fset_fontset_font): Rename local to avoid shadowing.
6103 (fontset_font): Mark local as initialized.
6104 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6105
6106 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6107
6108 * xselect.c (x_disown_buffer_selections): Remove; not used.
6109 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6110 (x_own_selection, Fx_disown_selection_internal): Rename locals
6111 to avoid shadowing.
6112 (x_handle_dnd_message): Remove local to avoid shadowing.
6113
6114 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6115 so that the caller can use some name other than gcpro1.
6116 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6117 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6118 (Fx_backspace_delete_keys_p):
6119 Use them to avoid shadowing, and rename vars to avoid shadowing.
6120 (x_decode_color, x_set_name, x_window): Now static.
6121 (Fx_create_frame): Add braces to silence GCC warning.
6122 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6123 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6124 Remove unused locals.
6125 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6126 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6127 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6128 macros.
6129
6130 * xterm.h (x_mouse_leave): New decl.
6131
6132 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6133 Remove unused functions.
6134 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6135 (x_calc_absolute_position): Now static.
6136 (XTread_socket): Don't define label "out" unless it's used.
6137 Don't declare local "event" unless it's used.
6138 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6139 unless they are used.
6140 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6141 (x_fatal_error_signal): Remove; not used.
6142 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6143 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6144 (x_error_catcher, x_connection_closed, x_error_handler):
6145 (x_error_quitter, xembed_send_message, x_iconify_frame):
6146 (my_log_handler): Rename locals to avoid shadowing.
6147 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6148 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6149
6150 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6151 Rename or move locals to avoid shadowing.
6152 (tty_defined_color, merge_face_heights): Now static.
6153 (free_realized_faces_for_fontset): Remove; not used.
6154 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6155 does not deduce is never used uninitialized.
6156 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6157 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6158
6159 * terminal.c (store_terminal_param): Now static.
6160
6161 * xmenu.c (menu_highlight_callback): Now static.
6162 (set_frame_menubar): Remove unused local.
6163 (xmenu_show): Rename parameter to avoid shadowing.
6164 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6165 since they might point to immutable storage.
6166 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6167 since it's unused otherwise.
6168
6169 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6170 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6171 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6172 avoids a gcc -Wuninitialized diagnostic.
6173 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6174 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6175 does not deduce are never used uninitialized.
6176
6177 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6178
6179 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6180 * window.c (window_loop, size_window):
6181 (run_window_configuration_change_hook, enlarge_window): Likewise.
6182
6183 * window.c (display_buffer): Now static.
6184 (size_window): Mark variables that gcc -Wuninitialized
6185 does not deduce are never used uninitialized.
6186 * window.h (check_all_windows): New decl, to forestall
6187 gcc -Wmissing-prototypes diagnostic.
6188 * dispextern.h (bidi_dump_cached_states): Likewise.
6189
6190 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6191 shadowing.
6192 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6193 Include <limits.h>.
6194 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6195 and to avoid gcc -Wuninitialized warning.
6196 (load_charset_map): Mark variables that gcc -Wuninitialized
6197 does not deduce are never used uninitialized.
6198 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6199
6200 * coding.c (coding_set_source, coding_set_destination):
6201 Use "else { /* comment */ }" rather than "else /* comment */;"
6202 for clarity, and to avoid gcc -Wempty-body warning.
6203 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6204 a block, when the outer 'i' will do.
6205 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6206 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6207 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6208 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6209 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6210 Rename locals to avoid shadowing.
6211 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6212 * coding.c (emacs_mule_char, encode_invocation_designation):
6213 Now static, since they're not used elsewhere.
6214 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6215 (decode_coding_object, encode_coding_object, detect_coding_system):
6216 (decode_coding_emacs_mule): Mark variables that gcc
6217 -Wuninitialized does not deduce are never used uninitialized.
6218 (detect_coding_iso_2022): Initialize a local variable that might
6219 be used uninitialized. Leave a FIXME because it's not clear that
6220 this initialization is needed. (Bug#8211)
6221 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6222 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6223 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6224 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6225 Remove unused macros.
6226
6227 * category.c (hash_get_category_set): Remove unused local var.
6228 (copy_category_table): Now static, since it's not used elsewhere.
6229 * character.c (string_count_byte8): Likewise.
6230
6231 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6232 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6233
6234 * chartab.c (copy_sub_char_table): Now static, since it's not used
6235 elsewhere.
6236 (sub_char_table_ref_and_range, char_table_ref_and_range):
6237 Rename locals to avoid shadowing.
6238 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6239
6240 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6241 (BIDI_BOB): Remove unused macro.
6242
6243 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6244 deduce are never used uninitialized.
6245 * term.c (encode_terminal_code): Likewise.
6246
6247 * term.c (encode_terminal_code): Now static. Remove unused local.
6248
6249 * tparam.h: New file.
6250 * term.c, tparam.h: Include it.
6251 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6252 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6253 Move these decls to tparam.h, and make them agree with what
6254 is actually in tparam.c. The previous trick of using incompatible
6255 decls in different modules does not conform to the C standard.
6256 All callers of tparam changed to use tparam's actual API.
6257 * tparam.c (tparam1, tparam, tgoto):
6258 Use const pointers where appropriate.
6259
6260 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6261 * cm.h (struct cm): Likewise.
6262 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6263 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6264 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6265 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6266 (turn_on_face, init_tty): Likewise.
6267 * termchar.h (struct tty_display_info): Likewise.
6268
6269 * term.c (term_mouse_position): Rename local to avoid shadowing.
6270
6271 * alloc.c (mark_ttys): Move decl from here ...
6272 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6273
6274 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6275
6276 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6277
6278 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6279
6280 * search.c (compile_pattern_1): Remove argument regp, unused since
6281 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6282 (compile_pattern): Don't pass it.
6283
6284 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6285
6286 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6287 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6288 for ! HAVE_GTK3.
6289 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6290
6291 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6292
6293 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6294 gdk_window_get_screen, gdk_window_get_geometry,
6295 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6296 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6297 (xg_get_pixbuf_from_pixmap): New function.
6298 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6299 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6300 Call xg_get_pixbuf_from_pixmap instead of
6301 gdk_pixbuf_get_from_drawable.
6302 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6303 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6304 (xg_check_special_colors): Use GtkStyleContext and its functions
6305 for HAVE_GTK3.
6306 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6307 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6308 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6309 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6310 Call gtk_widget_get_preferred_size.
6311 (xg_frame_resized): gdk_window_get_geometry only takes 5
6312 parameters.
6313 (xg_win_to_widget, xg_event_is_for_menubar):
6314 Call gdk_x11_window_lookup_for_display.
6315 (xg_set_widget_bg): New function.
6316 (delete_cb): New function.
6317 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6318 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6319 (xg_set_background_color): Call xg_set_widget_bg.
6320 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6321 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6322 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6323 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6324 if ! HAVE_GTK3.
6325 (update_frame_tool_bar): Call gtk_widget_hide.
6326 (xg_initialize): Use GDK_KEY_g.
6327
6328 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6329 if ! HAVE_GTK3
6330 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6331
6332 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6333 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6334 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6335
6336 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6337
6338 * w32xfns.c (select_palette): Check success of RealizePalette against
6339 GDI_ERROR, not zero.
6340
6341 See ChangeLog.11 for earlier changes.
6342
6343 ;; Local Variables:
6344 ;; coding: utf-8
6345 ;; End:
6346
6347 Copyright (C) 2011 Free Software Foundation, Inc.
6348
6349 This file is part of GNU Emacs.
6350
6351 GNU Emacs is free software: you can redistribute it and/or modify
6352 it under the terms of the GNU General Public License as published by
6353 the Free Software Foundation, either version 3 of the License, or
6354 (at your option) any later version.
6355
6356 GNU Emacs is distributed in the hope that it will be useful,
6357 but WITHOUT ANY WARRANTY; without even the implied warranty of
6358 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6359 GNU General Public License for more details.
6360
6361 You should have received a copy of the GNU General Public License
6362 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.